gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         PR tui/23619:
   4         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
   5         (tui_redisplay_readline): Use rl_display_prompt.
   6         (tui_prep_terminal): Update.
   7
   8 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * configure: Regenerate.
  11         * configure.ac: Quote variable arguments of test.
  12         * gdbsupport/common.m4: Likewise.
  13
  14 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  15
  16         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
  17         2 to pow ().
  18
  19 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  20
  21         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
  22         log10 to double to fix Solaris 11 with gcc 5.5.
  23
  24 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
  27         "sun" to "saddr_un".
  28
  29 2019-12-19  Tom Tromey  <tromey@adacore.com>
  30
  31         * ui-out.h (enum class field_kind): Fix comment.
  32
  33 2019-12-11  Tom Tromey  <tromey@adacore.com>
  34
  35         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
  36
  37 2019-12-18  Tom Tromey  <tromey@adacore.com>
  38
  39         PR build/25268:
  40         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  41         type on macOS.  Add comment.
  42
  43 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  44
  45         * c-lang.c (c_get_string, asm_language_defn): Remove space
  46         before tab.
  47
  48 2019-12-18  Tom Tromey  <tromey@adacore.com>
  49
  50         PR build/25250:
  51         * ui-out.c (ui_out::vmessage): Update.
  52         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  53         Rename.
  54         (string_field): Update.
  55         (signed_field): Update.
  56
  57 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  58
  59         * top.c (print_gdb_configuration): Adjust indentation.
  60
  61 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  62
  63         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  64
  65 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  66
  67         * tui/tui-layout.h (class tui_layout_base): Add virtual
  68         destructor.
  69
  70 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  71
  72         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  73         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  74         (process_event_stop_test): Keep stepping over skipped inline functions.
  75
  76 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         * jit.c (struct gdb_block) <next>: Remove field.
  79         (struct gdb_symtab) <~gdb_symtab>: Remove.
  80         <blocks>: Change type to std::forward_list<gdb_block>.
  81         (compare_block): Remove.
  82         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  83         block at the beginning, don't mind about sorting.
  84         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  85         before using it.
  86
  87 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  88
  89         * jit.c (struct gdb_block): Add constructor, initialize
  90         real_block and next fields.
  91         <name>: Change type to gdb::unique_xmalloc_ptr.
  92         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  93         (jit_block_open_impl): Allocate gdb_block with new.
  94         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  95
  96 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  97
  98         * jit.c: Include forward_list.
  99         (struct gdb_symtab) <next>: Remove field.
 100         (struct gdb_object) <symtabs>: Change type to
 101         std::forward_list<gdb_symtab>.
 102         (jit_object_open_impl): Allocate gdb_object with new.
 103         (jit_symtab_open_impl): Adjust to std::forward_list.
 104         (finalize_symtab): Don't delete symtab.
 105         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 106         gdb_object with delete.
 107
 108 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 109
 110         * jit.c (struct gdb_symtab): Add constructor, destructor,
 111         initialize fields.
 112         <linetable>: Change type to unique_xmalloc_ptr.
 113         <file_name>: Change type to std::string.
 114         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 115         (jit_symtab_line_mapping_add_impl): Adjust.
 116         (finalize_symtab): Adjust, call delete on stab.
 117
 118 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 119
 120         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 121
 122 2019-12-16  Tom Tromey  <tromey@adacore.com>
 123
 124         * windows-nat.c (windows_nat_target::attach): Update.
 125         * remote.c (extended_remote_target::attach): Update.
 126         * procfs.c (procfs_target::attach): Update.
 127         * nto-procfs.c (nto_procfs_target::attach): Update.
 128         (nto_procfs_target::create_inferior): Update.
 129         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 130         * gnu-nat.c (gnu_nat_target::attach): Update.
 131         (gnu_nat_target::detach): Update.
 132         * darwin-nat.c (darwin_nat_target::attach): Update.
 133         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 134         return.
 135         * bsd-kvm.c (bsd_kvm_target_open): Update.
 136         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 137
 138 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 139
 140         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 141         (we no longer need to include time.h before pathmax.h)
 142
 143 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 144
 145         * ada-exp.y (write_ambiguous_var): Update.
 146         * coffread.c (process_coff_symbol): Update.
 147         * ctfread.c (ctf_add_enum_member_cb): Update.
 148         (new_symbol): Update.
 149         * dwarf2read.c (fixup_go_packaging): Update.
 150         (new_symbol): Update.
 151         * language.c (language_alloc_type_symbol): Update.
 152         * mdebugread.c (new_symbol): Update.
 153         * minsyms.c (minimal_symbol_reader::record_full): Update.
 154         * psymtab.c (add_psymbol_to_bcache): Update.
 155         * stabsread.c (define_symbol): Update.
 156         (read_enum_type): Update.
 157         * symtab.c (symbol_set_language): Make this a member function...
 158         (general_symbol_info::set_language): ... here.
 159         * symtab.h (struct general_symbol_info) <set_language>: New function.
 160         (SYMBOL_SET_LANGUAGE): Remove.
 161         (symbol_set_language): Remove.
 162
 163 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 164
 165         * ada-lang.c (ada_add_block_symbols): Update.
 166         (ada_collect_symbol_completion_matches): Update.
 167         * ax-gdb.c (gen_expr): Update.
 168         * block.c (block_lookup_symbol): Update.
 169         (block_lookup_symbol_primary): Update.
 170         (block_find_symbol): Update.
 171         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 172         * dbxread.c (process_one_symbol): Update.
 173         * dictionary.c (insert_symbol_hashed): Update.
 174         (collate_pending_symbols_by_language): Update.
 175         (mdict_add_symbol): Update.
 176         * dwarf-index-write.c (write_psymbols): Update.
 177         * dwarf2read.c (fixup_go_packaging): Update.
 178         * findvar.c (read_var_value): Update.
 179         * ft32-tdep.c (ft32_skip_prologue): Update.
 180         * go-lang.c (go_symbol_package_name): Update.
 181         * language.h (scoped_switch_to_sym_language_if_auto::
 182         scoped_switch_to_sym_language_if_auto): Update.
 183         * linespec.c (find_method): Update.
 184         (find_label_symbols_in_block): Update.
 185         * mdebugread.c (parse_symbol): Update.
 186         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 187         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 188         (minimal_symbol_reader::install): Update.
 189         * moxie-tdep.c (moxie_skip_prologue): Update.
 190         * parse.c (parse_exp_in_context): Update.
 191         * psymtab.c (psymbol_name_matches): Update.
 192         (match_partial_symbol): Update.
 193         (lookup_partial_symbol): Update.
 194         (psymbol_hash): Update.
 195         (psymbol_compare): Update.
 196         * python/py-framefilter.c (extract_sym): Update.
 197         (py_print_single_arg): Update.
 198         * stabsread.c (define_symbol): Update.
 199         * stack.c (print_frame_arg): Update.
 200         (find_frame_funname): Update.
 201         (info_frame_command_core): Update.
 202         * symfile.c (set_initial_language): Update.
 203         * symtab.c (symbol_set_demangled_name): Update.
 204         (symbol_get_demangled_name): Update.
 205         (symbol_set_language): Update.
 206         (symbol_find_demangled_name): Update.
 207         (symbol_set_names): Update.
 208         (general_symbol_info::natural_name): Update.
 209         (general_symbol_info::demangled_name): Update.
 210         (general_symbol_info::search_name): Update.
 211         (symbol_matches_search_name): Update.
 212         (eq_symbol_entry): Update.
 213         (iterate_over_symbols): Update.
 214         (completion_list_add_symbol): Update.
 215         (completion_list_add_msymbol): Update.
 216         (completion_list_add_fields): Update.
 217         * symtab.h (struct general_symbol_info) <language>: New function.
 218         <language>: Rename to...
 219         <m_language>: ...this.
 220         (SYMBOL_LANGUAGE): Remove.
 221         (MSYMBOL_LANGUAGE): Remove.
 222         (struct symbol) <ctor>: Update.
 223         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 224
 225 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 226
 227         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 228         set the language of sym.
 229         * language.c (language_alloc_type_symbol): Likewise.
 230
 231 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 232
 233         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 234         PR gdb/23613
 235         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 236         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 237         (core_target_open): Use 'gdb_abspath'.
 238         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 239         'current_directory == NULL' case.
 240         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 241         explain what happens when 'current_directory' is NULL.
 242         * go32-nat.c (go32_nat_target::wait): Check if
 243         'current_directory' is NULL before call to 'chdir'.
 244         * source.c (add_path): Use 'gdb_abspath'.
 245         * top.c: Include 'gdbsupport/pathstuff.h'.
 246         (init_history): Use 'gdb_abspath'.
 247         (set_history_filename): Likewise.
 248         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 249         (tfile_target_open): Use 'gdb_abspath'.
 250
 251 2019-12-13  Tom Tromey  <tromey@adacore.com>
 252
 253         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 254         warning or error.
 255
 256 2019-12-13  Tom Tromey  <tromey@adacore.com>
 257
 258         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 259
 260 2019-12-13  Tom Tromey  <tromey@adacore.com>
 261
 262         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 263
 264 2019-12-13  Tom Tromey  <tromey@adacore.com>
 265
 266         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 267
 268 2019-12-13  Tom Tromey  <tromey@adacore.com>
 269
 270         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 271         (string_vappendf): Add ARI comment.
 272
 273 2019-12-13  Tom Tromey  <tromey@adacore.com>
 274
 275         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 276         floatformat_to_double.
 277         * target-float.c (host_float_ops<T>::from_target): Add ARI
 278         comment.
 279
 280 2019-12-13  Tom Tromey  <tromey@adacore.com>
 281
 282         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 283         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 284         ARI marker to abort.
 285         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 286
 287 2019-12-13  Tom Tromey  <tromey@adacore.com>
 288
 289         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 290
 291 2019-12-13  Tom Tromey  <tromey@adacore.com>
 292
 293         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 294
 295 2019-12-13  Tom Tromey  <tromey@adacore.com>
 296
 297         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 298         checks.
 299
 300 2019-12-13  Tom Tromey  <tromey@adacore.com>
 301
 302         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 303         end>: No longer "const".
 304
 305 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 306
 307         * jit.c: Fix indentation, replace spaces with tabs where
 308         applicable.
 309
 310 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 311
 312         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 313
 314 2019-12-12  Tom Tromey  <tom@tromey.com>
 315
 316         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 317         unique_ptr.
 318
 319 2019-12-12  Tom Tromey  <tom@tromey.com>
 320
 321         * progspace.h (objfile_list): New typedef.
 322         (class unwrapping_objfile_iterator)
 323         (struct unwrapping_objfile_range): Newl
 324         (struct program_space) <objfiles_range>: Change type.
 325         <objfiles>: Change return type.
 326         <add_objfile>: Change type of "objfile" parameter.
 327         <objfiles_list>: Now a list of shared_ptr.
 328         * progspace.c (program_space::add_objfile): Change type of
 329         "objfile".  Update.
 330         (program_space::remove_objfile): Update.
 331         * objfiles.h (struct objfile) <~objfile>: Make public.
 332         * objfiles.c (objfile::make): Update.
 333         (objfile::unlink): Don't call delete.
 334
 335 2019-12-12  Tom Tromey  <tom@tromey.com>
 336
 337         * symfile.c (symbol_file_clear): Update.
 338         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 339         method.
 340         * progspace.c (program_space::free_all_objfiles): New method.
 341         * objfiles.h (free_all_objfiles): Don't declare.
 342         * objfiles.c (free_all_objfiles): Move to program_space.
 343
 344 2019-12-12  Tom Tromey  <tom@tromey.com>
 345
 346         * progspace.c (program_space::add_objfile)
 347         (program_space::remove_objfile): Update.
 348         (program_space::multi_objfile_p): Remove.
 349         * objfiles.h (struct objfile) <next>: Remove.
 350         * objfiles.c (objfile::objfile): Update.
 351         (put_objfile_before): Update.
 352         (unlink_objfile): Update.
 353         * progspace.h (object_files): Remove.
 354         (struct program_space) <objfiles_head>: Remove.
 355         <objfiles_list>: New member.
 356         <objfiles_range, objfiles_safe_range>: Change type.
 357         (objfiles): Change return type.
 358         (objfiles_safe): Update.
 359         (multi_objfile_p): Rewrite and inline.
 360         (object_files): Remove macro.
 361
 362 2019-12-12  Tom Tromey  <tom@tromey.com>
 363
 364         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 365         second constructor.
 366         (basic_safe_range): New class.
 367
 368 2019-12-12  Tom Tromey  <tom@tromey.com>
 369
 370         * progspace.c (program_space::multi_objfile_p): New method.
 371         * printcmd.c (info_symbol_command): Update.
 372         * maint.c (maintenance_translate_address): Update.
 373         * objfiles.h (MULTI_OBJFILE_P): Remove.
 374         * progspace.h (struct program_space) <multi_objfile_p>: New
 375         method.
 376
 377 2019-12-12  Tom Tromey  <tom@tromey.com>
 378
 379         * progspace.h (struct program_space) <remove_objfile>: Declare.
 380         * progspace.c (program_space::remove_objfile): New method.
 381         * objfiles.c (unlink_objfile): Remove.
 382         (objfile::unlink): Call remove_objfile.
 383         (objfile): Don't call unlink_objfile.
 384
 385 2019-12-12  Tom Tromey  <tom@tromey.com>
 386
 387         * progspace.h (struct program_space) <add_objfile>: Declare
 388         method.
 389         * progspace.c (program_space::add_objfile): New method.
 390         * objfiles.c (~objfile): Don't unlink objfile.
 391         (put_objfile_before): Remove.
 392         (add_separate_debug_objfile): Don't call put_objfile_before.
 393         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 394         the per-program-space data.
 395
 396 2019-12-12  Tom Tromey  <tom@tromey.com>
 397
 398         * symfile.c (syms_from_objfile_1): Use objfile_up.
 399         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 400         method.
 401         (reread_symbols): Use objfile_up.
 402         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 403         unlink method.
 404         * objfiles.h (struct objfile) <~objfile>: Now private.
 405         <unlink>: New method.
 406         (struct objfile_deleter): New.
 407         (objfile_up): New typedef.
 408         * objfiles.c (objfile::unlink): New method.
 409         (free_objfile_separate_debug, free_all_objfiles)
 410         (objfile_purge_solibs): Use it.
 411         * jit.c (jit_unregister_code): Remove.
 412         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 413         objfile.
 414         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 415         objfile.
 416         * compile/compile-object-load.c (compile_object_load): Use
 417         objfile_up.
 418
 419 2019-12-12  Tom Tromey  <tom@tromey.com>
 420
 421         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 422         objfile::make.
 423         * objfiles.h (struct objjfile) <make>: No longer inline.
 424         (add_separate_debug_objfile): Don't declare.
 425         * objfiles.c (add_separate_debug_objfile): Now static.
 426         (objfile::make): Move from objfiles.h.  Call
 427         add_separate_debug_objfile.  Add "parent" parameter.
 428
 429 2019-12-12  Tom Tromey  <tom@tromey.com>
 430
 431         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 432         * objfiles.h (struct objfile): Make constructor private.
 433         <make>: New static method.
 434         * jit.c (jit_object_close_impl): Update.
 435
 436 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 437
 438         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 439         gdb::byte_vector.
 440
 441 2019-12-12  Tom Tromey  <tromey@adacore.com>
 442
 443         * xml-support.c (xml_fetch_content_from_file): Don't call
 444         malloc_failure.
 445         * utils.h (class gdb_argv): Remove malloc_failure comment.
 446         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 447
 448 2019-12-12  Tom Tromey  <tromey@adacore.com>
 449
 450         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 451         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 452         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 453         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 454         * riscv-ravenscar-thread.c: New file.
 455         * riscv-ravenscar-thread.h: New file.
 456         * riscv-tdep.c (riscv_gdbarch_init): Call
 457         register_riscv_ravenscar_ops.
 458
 459 2019-12-12  Tom Tromey  <tromey@adacore.com>
 460
 461         * gdbsupport/thread-pool.c (set_thread_name): Use
 462         ATTRIBUTE_UNUSED.
 463
 464 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 465
 466         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 467         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 468         macros.
 469
 470 2019-12-11  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-win.c (tui_set_win_height_command): Call
 473         tui_adjust_window_height.
 474         (tui_adjust_win_heights, new_height_ok): Remove.
 475         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 476         * tui/tui-layout.c (tui_adjust_window_height): New function.
 477
 478 2019-12-11  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-win.c (tui_resize_all): Remove code, call
 481         tui_apply_current_layout.
 482
 483 2019-12-11  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 486         * tui/tui-layout.c (standard_layouts, applied_layout): New
 487         globals.
 488         (tui_apply_current_layout): New function.
 489         (show_layout): Set applied_layout.  Call
 490         tui_apply_current_layout.
 491         (show_source_command, show_disasm_command)
 492         (show_source_disasm_command, show_data)
 493         (show_source_or_disasm_and_command): Remove.
 494         (initialize_layouts): New function.
 495         (_initialize_tui_layout): Call initialize_layouts.
 496
 497 2019-12-11  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-layout.h (class tui_layout_base)
 500         (class tui_layout_window, class tui_layout_split): New.
 501         * tui/tui-layout.c (tui_get_window_by_name)
 502         (tui_layout_window::clone, tui_layout_window::apply)
 503         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 504         (tui_layout_split::add_window, tui_layout_split::clone)
 505         (tui_layout_split::get_sizes)
 506         (tui_layout_split::set_weights_from_heights)
 507         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 508         functions.
 509         (tui_layout_split::add_split, tui_layout_split::add_split)
 510         (tui_layout_split::set_weights_from_heights)
 511         (tui_layout_split::set_weights_from_heights): New functions.
 512
 513 2019-12-11  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 516         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 517         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 518         * tui/tui-data.h (struct tui_point): Remove.
 519         (struct tui_gen_win_info) <origin>: Remove.
 520         <x, y>: New fields.
 521         * tui/tui-command.c (tui_cmd_window::resize): Update.
 522
 523 2019-12-11  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 526         Implement.
 527         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 528         Implement.
 529         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 530         method.
 531         (struct tui_win_info) <min_height>: Implement.
 532
 533 2019-12-11  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 536         (struct tui_win_info) <can_box>: Update.
 537
 538 2019-12-11  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 541         method.
 542         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 543         method.
 544         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 545         method.
 546         (struct tui_win_info) <max_height>: Now override.
 547
 548 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 549
 550         * NEWS: Create a new section for the next release branch.
 551         Rename the section of the current branch, now that it has
 552         been cut.
 553
 554 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 555
 556         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 557         * version.in: Bump version to 10.0.50.DATE-git.
 558
 559 2019-12-11  Tom Tromey  <tromey@adacore.com>
 560
 561         PR build/25268:
 562         * gdbsupport/thread-pool.c (set_thread_name): New function.
 563         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 564         (thread_pool::thread_function): Call set_thread_name.
 565
 566 2019-12-11  Tom Tromey  <tromey@adacore.com>
 567
 568         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 569         bfd_get_signed_8.
 570
 571 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 572
 573         * NEWS: Document -raw-values option and the related setting commands.
 574         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 575         only set it on when /r is given.
 576         * valprint.c (value_print_option_defs): New element raw-values.
 577         * Makefile.in: Add the new file.
 578
 579 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 580
 581         * gdbsupport/safe-strerror.c: Supress the unused function warning
 582         for select_strerror_r.
 583
 584 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 585
 586         * config.in: Regenerate.
 587         * configure: Regenerate.
 588         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 589         safe_strerror instead of strerror.
 590         * gdbsupport/common.m4: Don't check for strerror.
 591         * gdbsupport/safe-strerror.c: Support both the glibc version
 592         of strerror_r and the XSI version.
 593
 594 2019-12-10  Tom Tromey  <tromey@adacore.com>
 595
 596         * ada-typeprint.c (print_choices): Use a single "?".
 597         (print_variant_part): Print "?" if the discriminant name
 598         is not known.
 599
 600 2019-12-10  George Barrett  <bob@bob131.so>
 601
 602         Fix scripted probe breakpoints.
 603         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 604         declaration forward.
 605         (breakpoint_ops_for_event_location_type)
 606         (breakpoint_ops_for_event_location): Add function definitions.
 607         (break_command_1, trace_command): Use
 608         breakpoint_ops_for_event_location.
 609         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 610         declarations.
 611         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 612         breakpoint_ops_for_event_location.
 613         * python/py-breakpoint.c (bppy_init): Use
 614         breakpoint_ops_for_event_location.
 615
 616 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 617
 618         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 619         when ranking an lvalue argument for an rvalue parameter.
 620
 621 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 622
 623         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 624         template argument for scoped_restore_tmpl from bool to int.
 625
 626 2019-12-07  Keith Seitz  <keiths@redhat.com>
 627
 628         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 629         (build_id_to_debug_bfd): Make static, rewriting to use
 630         build_id_to_bfd_suffix.
 631         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 632         adding `suffix' parameter. Append SUFFIX to file names
 633         when searching for matching files.
 634         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 635         (build_id_to_exec_bfd): Likewise.
 636         * build-id.h (build_id_to_debug_bfd): Clarify that function
 637         searches for BFD of debug info file.
 638         (build_id_to_exec_bfd): Declare.
 639         * corelow.c: Include build-id.h.
 640         (locate_exec_from_corefile_build_id): New function.
 641         (core_target_open): If no executable BFD is found,
 642         search for a core file BFD using build-id.
 643
 644 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 645
 646         * bcache.c: Put in namespace gdb.
 647         * bcache.h: Likewise.
 648         * gdbtypes.c (check_types_worklist): Update.
 649         (types_deeply_equal): Update.
 650         * macrotab.c (struct macro_table) <bcache>: Update.
 651         (new_macro_table): Update.
 652         * macrotab.h (struct bcache): Put this forward declaration
 653         inside namespace gdb.
 654         (new_macro_table): Update.
 655         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 656         Update.
 657         <macro_cache>: Update.
 658         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 659
 660 2019-12-06  Tom de Vries  <tdevries@suse.de>
 661
 662         PR symtab/24971
 663         * block.c (best_symbol, better_symbol): New function.
 664         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 665         decl.
 666
 667 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 668
 669         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 670         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 671         for ranking see-through reference cases.
 672
 673 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 674         * stack.c (faas_command): Check a command is provided.
 675         * thread.c (taas_command, tfaas_command): Likewise.
 676
 677 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 678         * inferior.c (prune_inferiors):  Only call delete_inferior,
 679         Do not modify the inferior list.
 680
 681 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 682
 683         * c-exp.y: Update calls to lookup_typename,
 684         lookup_signed_typename and lookup_unsigned_typename.
 685         * c-lang.c (evaluate_subexp_c): Likewise.
 686         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 687         Likewise.
 688         * eval.c (binop_promote): Likewise.
 689         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 690         (lookup_unsigned_typename): Likewise.
 691         (lookup_signed_typename): Likewise.
 692         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 693         (lookup_signed_typename): Likewise.
 694         (lookup_typename): Likewise.
 695         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 696         lookup_typename, lookup_signed_typename,
 697         lookup_unsigned_typename.
 698         * m2-exp.y: Likewise.
 699         * printcmd.c (printf_wide_c_string): Likewise.
 700         (ui_printf): Likewise.
 701         * python/py-type.c (typy_lookup_typename): Likewise.
 702         * python/py-xmethods.c (python_xmethod_worker::invoke):
 703         Likewise.
 704         * rust-exp.y: Likewise.
 705
 706 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 707
 708         * configure.nat (obsd64): Add missing files x86-nat.o and
 709         nat/x86-dregs.o.
 710
 711 2019-12-04  Tom Tromey  <tom@tromey.com>
 712
 713         * valprint.c (val_print_string): Use metadata_style.
 714         * go-valprint.c (print_go_string): Use metadata style.
 715         * p-valprint.c (pascal_object_print_static_field): Use metadata
 716         style.
 717         * cp-valprint.c (cp_print_static_field): Use metadata style.
 718
 719 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 720             Chris January  <chris.january@arm.com>
 721
 722         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 723         tokens.
 724         (typebase): New patterns for complex, single/double precision, and
 725         single/double complex.
 726         (f77_keywords): Change token for complex keyword, and add single,
 727         double, and precision keywords.
 728
 729 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 730
 731         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 732         "info io_registers".
 733
 734 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 735
 736         * regcache.c (cooked_read_test): Initialize thread list of
 737         mock_inferior.
 738
 739 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 740
 741         * aarch64-linux-tdep.c: Remove includes.
 742
 743 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 744
 745         * aarch64-tdep.c: Remove includes.
 746
 747 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 748
 749         * filtered-iterator.h (filtered_iterator) <operator==,
 750         operator!=>: Compare wrapped iterators, not wrapped pointers.
 751         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 752         unittests/filtered_iterator-selftests.c.
 753         * unittests/filtered_iterator-selftests.c: New file.
 754
 755 2019-12-04  Tom Tromey  <tromey@adacore.com>
 756
 757         * gdbtypes.c (create_range_type): Inherit endianity
 758         from base type.
 759
 760 2019-12-04  Tom Tromey  <tromey@adacore.com>
 761
 762         * ada-lang.c (decode_constrained_packed_array)
 763         (ada_value_assign, value_assign_to_component): Update.
 764         * dwarf2loc.c (rw_pieced_value, access_memory)
 765         (dwarf2_compile_expr_to_ax): Update.
 766         * dwarf2read.c (dwarf2_add_field): Update.
 767         * eval.c (evaluate_subexp_standard): Update.
 768         * gdbarch.c, gdbarch.h: Rebuild.
 769         * gdbarch.sh (bits_big_endian): Remove.
 770         * gdbtypes.h (union field_location): Update comment.
 771         * target-descriptions.c (make_gdb_type): Update.
 772         * valarith.c (value_bit_index): Update.
 773         * value.c (struct value) <bitpos>: Update comment.
 774         (unpack_bits_as_long, modify_field): Update.
 775         * value.h (value_bitpos): Update comment.
 776
 777 2019-12-04  Tom Tromey  <tromey@adacore.com>
 778
 779         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 780         endian-ness.
 781
 782 2019-12-04  Tom Tromey  <tromey@adacore.com>
 783
 784         * dwarf2read.c (dwarf2_init_float_type)
 785         (dwarf2_init_complex_target_type): Add byte_order parameter.
 786         (read_base_type): Compute byte order earlier.
 787         * gdbtypes.c (init_float_type): Add byte_order parameter.
 788         * gdbtypes.h (init_float_type): Add byte_order parameter.
 789
 790 2019-12-04  Tom Tromey  <tromey@adacore.com>
 791
 792         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 793
 794 2019-12-04  Tom Tromey  <tromey@adacore.com>
 795
 796         * dwarf2read.c (process_structure_scope): Initialize
 797         "discr_offset".
 798
 799 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 800
 801         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 802         add it into the search spec.
 803         (parse_max_results_option): New function.
 804         (mi_info_functions_or_variables): Parse -max-results flag and pass
 805         it to mi_symbol_info.
 806         (mi_cmd_symbol_info_modules): Likewise.
 807         (mi_cmd_symbol_info_types): Likewise.
 808         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 809         return type to bool, change result container into a set, and don't
 810         add new results if we have enough already.
 811         (global_symbol_searcher::add_matching_msymbols): Change return
 812         type to bool, and don't add new results if we have enough already.
 813         (sort_search_symbols_remove_dups): Delete.
 814         (global_symbol_searcher::search): Early exit from search loop when
 815         we have enough results.  Use a std::set to collect the results
 816         from calling add_matching_symbols.
 817         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 818         member function.
 819         (global_symbol_searcher) <m_max_search_results>: New member
 820         variable.
 821         (global_symbol_searcher) <add_matching_symbols>: Update header
 822         comment and change return type to bool.
 823         (global_symbol_searcher) <add_matching_msymbols>: Update header
 824         comment and change return type to bool.
 825
 826 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * symtab.c (symbol_search::compare_search_syms): Update header
 829         comment.
 830         (global_symbol_searcher::is_suitable_msymbol): New function.
 831         (global_symbol_searcher::expand_symtabs): New function.
 832         (global_symbol_searcher::add_matching_symbols): New function.
 833         (global_symbol_searcher::add_matching_msymbols): New function.
 834         (global_symbol_searcher::search): Move most of the content
 835         into the new functions above, and call them as needed.
 836         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 837         function.
 838         (global_symbol_searcher) <add_matching_symbols>: New member
 839         function.
 840         (global_symbol_searcher) <add_matching_msymbols>: New member
 841         function.
 842         (global_symbol_searcher) <is_suitable_msymbol>: New member
 843         function.
 844
 845 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 848         -symbol-info-module-variables entries.
 849         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 850         (mi_cmd_symbol_info_module_variables): Declare.
 851         * mi/mi-symbol-cmds.c
 852         (module_symbol_search_iterator): New typedef.
 853         (output_module_symbols_in_single_module_and_file): New function.
 854         (output_module_symbols_in_single_module): New function.
 855         (mi_info_module_functions_or_variables): New function.
 856         (mi_cmd_symbol_info_module_functions): New function.
 857         (mi_cmd_symbol_info_module_variables): New function.
 858         * NEWS: Mention new MI command.
 859
 860 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 861
 862         * bcache.c (hash): Remove.
 863         (hash_continue): Remove.
 864         * bcache.h (hash): Remove.
 865         (hash_continue): Remove.
 866         (struct bcache) <ctor>: Update.
 867         * psymtab.c (psymbol_hash): Update.
 868         * stabsread.c (hashname): Update.
 869         * utils.h (fast_hash): Add an argument for a start value,
 870         defaulting to zero.
 871
 872 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 873         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 874         (destroy_block_symbol_cache): New function.
 875         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 876         (resize_symbol_cache): Likewise.
 877
 878 2019-12-02  Tom Tromey  <tom@tromey.com>
 879
 880         * unittests/tui-selftests.c (run_tests): Make conditional.
 881         (_initialize_tui_selftest): Make conditional.
 882
 883 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 884
 885         * aix-thread.c (debug_aix_thread): Change type to bool.
 886
 887 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 888
 889         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 890
 891 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 892
 893         * dwarf2read.c (read_tag_string_type): Read the fields required to
 894         make a dynamic string, and possibly create a dynamic range for the
 895         string.
 896         (attr_to_dynamic_prop): Setup is_reference based on the type of
 897         attribute being processed.
 898         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 899         (resolve_dynamic_array): Rename to...
 900         (resolve_dynamic_array_or_string): ...this, update header comment,
 901         and accept TYPE_CODE_STRING.
 902         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 903
 904 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 907         of its implementation from...
 908         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 909         the new function.
 910
 911 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 914         create a range with stride where appropriate.
 915         * f-valprint.c: Include 'gdbarch.h'.
 916         (f77_print_array_1): Take the stride into account when walking the
 917         array.  Also convert the stride into addressable units.
 918         * gdbtypes.c (create_range_type): Initialise the stride to
 919         constant zero.
 920         (create_range_type_with_stride): New function, initialise the
 921         range as normal, and then setup the stride.
 922         (has_static_range): Include the stride here.  Also change the
 923         return type to bool.
 924         (create_array_type_with_stride): Consider the range stride if the
 925         array isn't given its own stride.
 926         (resolve_dynamic_range): Resolve the stride if needed.
 927         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 928         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 929         (TYPE_BIT_STRIDE): Define.
 930         (TYPE_ARRAY_BIT_STRIDE): Define.
 931         (create_range_type_with_stride): Declare.
 932         * valarith.c (value_subscripted_rvalue): Take range stride into
 933         account when walking the array.
 934
 935 2019-12-01  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 938         specially.
 939
 940 2019-12-01  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 943         \0.
 944         * unittests/tui-selftests.c: New file.
 945         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 946
 947 2019-12-01  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 950
 951 2019-12-01  Tom Tromey  <tom@tromey.com>
 952
 953         * NEWS: Document new settings.
 954         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 955         * tui/tui-win.c (_initialize_tui_win): Add border style
 956         observers.
 957         * tui/tui-io.h (tui_apply_style): Declare.
 958         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 959         longer static.
 960         (apply_ansi_escape, tui_set_reverse_mode): Update.
 961         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 962         Add "skip_intensity" parameter.
 963         <changed>: New member.
 964         <do_set_value>: Declare.
 965         (tui_border_style, tui_active_border_style): Declare.
 966         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 967         globals.
 968         (cli_style_option): Initialize "changed".
 969         (cli_style_option::do_set_value): New function.
 970         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 971         parameter.  Update.
 972         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 973         (_initialize_cli_style): Update.  Create TUI border style
 974         commands.
 975
 976 2019-12-01  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 979         parameter.
 980         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 981         parameter.
 982         * tui/tui-win.h (compact_source): Declare.
 983         * tui/tui-win.c (compact_source): New global.
 984         (tui_set_compact_source, tui_show_compact_source): New functions.
 985         (_initialize_tui_win): Add "compact-source" setting.
 986         * tui/tui-source.c (tui_source_window::set_contents): Handle
 987         compact_source setting.
 988         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 989         * NEWS: Document new setting.
 990
 991 2019-11-30  Tom Tromey  <tom@tromey.com>
 992
 993         * dwarf2read.c (dwarf2_add_field): Include field offset when
 994         computing variant part length.
 995
 996 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 997         * NEWS:  Mention define-prefix.  Tell that command names can now
 998         contain a . character.
 999
1000 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1001
1002         * command.h (valid_cmd_char_p): Declare.
1003         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1004         the check of valid command char.
1005         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1006         valid_cmd_char_p.
1007         * cli/cli-script.c (validate_comname): Likewise.
1008         * completer.c (gdb_completer_command_word_break_characters):
1009         Do not remove . from the word break char, update comments.
1010         (complete_line_internal_1): Use valid_cmd_char_p.
1011         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1012         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1013
1014 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1015
1016         * cli/cli-script.c (do_define_command): Ensure a redefined
1017         prefix command is kept as a prefix command.
1018         (define_prefix_command): New function.
1019         (show_user_1): Report user defined prefixes.
1020         (_initialize_cli_script):  Create the new 'define-prefix' command.
1021         Add completers for 'define' and 'document'.
1022         * top.c (execute_command):  If command is a user-defined prefix only
1023         command, report the list of commands for this prefix command.
1024
1025 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1026
1027         * valops.c (find_oload_champ): Improve debug output.
1028
1029 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1030
1031         * valops.c (find_oload_champ): Print part of debug messages
1032         before the badness vector is std::move'd.
1033
1034 2019-11-28  Tom Tromey  <tom@tromey.com>
1035
1036         * value.c (creal_internal_fn): Fix comment.
1037
1038 2019-11-28  Tom Tromey  <tom@tromey.com>
1039
1040         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1041         flag_bound_evaluated>: Now unsigned.
1042
1043 2019-11-28  Tom Tromey  <tom@tromey.com>
1044
1045         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1046         declare.
1047
1048 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1049
1050         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1051         debug output.
1052         * jit.c (jit_unregister_code): Add debug print to match
1053         `jit_register_code`.
1054
1055 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1056
1057         * NEWS: Mention the new multithreaded symbol loading.
1058
1059 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1060
1061         * maint.c (n_worker_threads): Default to 0.
1062         (worker_threads_disabled): New function.
1063         * maint.h (worker_threads_disabled): New function.
1064         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1065         here if worker_threads_disabled () is true.
1066         (minimal_symbol_reader::install): Skip all threading if
1067         worker_threads_disabled () is true.
1068
1069 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1070
1071         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1072         hash code if possible.
1073         (add_minsym_to_demangled_hash_table): Likewise.
1074         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1075         on the background thread.
1076         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1077         Add these fields.
1078
1079 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1080
1081         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1082         of the mangled name on the background thread.
1083         * symtab.c (symbol_set_names): Allow passing in the hash of the
1084         linkage_name.
1085         * symtab.h (symbol_set_names): Likewise.
1086
1087 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1088
1089         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1090         physnames are computed for inherited DIEs.
1091
1092 2019-11-27  Tom Tromey  <tromey@adacore.com>
1093
1094         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1095         backslashes.
1096         * cp-support.c: Remove unnecessary backslashes.
1097
1098 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1099
1100         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1101         with sym->set_linkage_name.
1102         * coffread.c (coff_read_enum_type): Likewise.
1103         * mdebugread.c (parse_symbol): Likewise.
1104         * stabsread.c (patch_block_stabs): Likewise.
1105         (define_symbol): Likewise.
1106         (read_enum_type): Likewise.
1107         (common_block_end): Likewise.
1108         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1109         function.
1110         (SYMBOL_SET_LINKAGE_NAME): Remove.
1111         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1112         with sym->set_linkage_name.
1113
1114 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1117         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1118         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1119         * NEWS: Mention new MI command.
1120
1121 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1124         '-symbol-info-types', and '-symbol-info-variables'.
1125         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1126         (mi_cmd_symbol_info_types): Declare.
1127         (mi_cmd_symbol_info_variables): Declare.
1128         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1129         (output_debug_symbol): New function.
1130         (output_nondebug_symbol): New function.
1131         (mi_symbol_info): New function.
1132         (mi_info_functions_or_variables): New function.
1133         (mi_cmd_symbol_info_functions): New function.
1134         (mi_cmd_symbol_info_types): New function.
1135         (mi_cmd_symbol_info_variables): New function.
1136         * NEWS: Mention new commands.
1137
1138 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * symtab.c (symbol_to_info_string): New function, most content
1141         moved from print_symbol_info, but updated to return a std::string.
1142         (print_symbol_info): Update to use symbol_to_info_string and print
1143         returned string.
1144         * symtab.h (symbol_to_info_string): Declare new function.
1145
1146 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * python/python.c (gdbpy_rbreak): Convert to using
1149         global_symbol_searcher.
1150         * symtab.c (file_matches): Convert return type to bool, change
1151         file list to std::vector, update header comment.
1152         (search_symbols): Rename to...
1153         (global_symbol_searcher::search): ...this and update now its
1154         a member function of global_symbol_searcher.  Take account of the
1155         changes to file_matches.
1156         (symtab_symbol_info): Convert to using global_symbol_searcher.
1157         (rbreak_command): Likewise.
1158         (search_module_symbols): Likewise.
1159         * symtab.h (enum symbol_search): Update comment.
1160         (search_symbols): Remove declaration.
1161         (class global_symbol_searcher): New class.
1162
1163 2019-11-26  Tom Tromey  <tromey@adacore.com>
1164
1165         * cp-support.c (_initialize_cp_support): Conditionally initialize
1166         gdb_demangle_attempt_core_dump.
1167
1168 2019-11-26  Tom Tromey  <tom@tromey.com>
1169
1170         * python/py-function.c (fnpy_init): Update.
1171         * value.h (add_internal_function): Adjust declaration.
1172         * value.c (function_destroyer): Remove.
1173         (do_add_internal_function): Don't set destroyer or copy name.
1174         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1175         Set name_allocated.
1176         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1177         (cmdpy_init): Set name_allocated.
1178         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1179         member.
1180         (~cmd_list_element): Free "name" if needed.
1181
1182 2019-11-26  Tom Tromey  <tom@tromey.com>
1183
1184         * value.h (add_internal_function): Add new overload.  Move
1185         documentation from value.h.
1186         * value.c (do_add_internal_function): New function.
1187         (add_internal_function): Use it.  Add new overload.
1188         (function_destroyer): Don't free doc.
1189         * python/py-function.c (fnpy_init): Update.
1190
1191 2019-11-26  Tom Tromey  <tom@tromey.com>
1192
1193         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1194         (cmdpy_init): Set "doc_allocated".
1195
1196 2019-11-26  Tom Tromey  <tom@tromey.com>
1197
1198         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1199         name of worker thread.
1200         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1201         pthread_setname_np.
1202         * configure, config.in: Rebuild.
1203
1204 2019-11-26  Tom Tromey  <tom@tromey.com>
1205
1206         * python/python.c (class gdbpy_gil): New.
1207         (struct gdbpy_event): Add constructor, destructor, operator().
1208         (gdbpy_post_event): Use run_on_main_thread.
1209         (gdbpy_initialize_events): Remove.
1210         (do_start_initialization): Update.
1211
1212 2019-11-26  Tom Tromey  <tom@tromey.com>
1213
1214         * NEWS: Add entry.
1215         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1216         commands.  Call update_thread_pool_size.
1217         (update_thread_pool_size, maintenance_set_worker_threads): New
1218         functions.
1219         (n_worker_threads): New global.
1220
1221 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1222             Tom Tromey  <tom@tromey.com>
1223
1224         * minsyms.c (minimal_symbol_reader::install): Use
1225         parallel_for_each.
1226         * gdbsupport/parallel-for.h: New file.
1227         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1228
1229 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1230             Tom Tromey  <tom@tromey.com>
1231
1232         * gdbsupport/thread-pool.h: New file.
1233         * gdbsupport/thread-pool.c: New file.
1234         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1235         (HFILES_NO_SRCDIR): Add thread-pool.h.
1236
1237 2019-11-26  Tom Tromey  <tom@tromey.com>
1238
1239         * event-top.h (thread_local_segv_handler): Declare.
1240         * event-top.c (thread_local_segv_handler): New global.
1241         (install_handle_sigsegv, handle_sigsegv): New functions.
1242         (async_init_signals): Install SIGSEGV handler.
1243         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1244         thread-local.
1245         (report_failed_demangle): New function.
1246         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1247         handler-setting code, instead use segv_handler.  Run warning code
1248         on main thread.
1249
1250 2019-11-26  Tom Tromey  <tom@tromey.com>
1251
1252         * run-on-main-thread.c: New file.
1253         * run-on-main-thread.h: New file.
1254         * unittests/main-thread-selftests.c: New file.
1255         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1256         main-thread-selftests.c.
1257         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1258         (COMMON_SFILES): Add run-on-main-thread.c.
1259
1260 2019-11-26  Tom Tromey  <tom@tromey.com>
1261
1262         * main.c (setup_alternate_signal_stack): Remove.
1263         (captured_main_1): Use gdb::alternate_signal_stack.
1264         * gdbsupport/alt-stack.h: New file.
1265
1266 2019-11-26  Tom Tromey  <tom@tromey.com>
1267
1268         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1269         Remove comment.
1270         (save_original_signals_state, restore_original_signals_state): Use
1271         gdb_sigmask.
1272         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1273         (_initialize_linux_nat): Use gdb_sigmask.
1274         * guile/guile.c (_initialize_guile): Use block_signals.
1275         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1276         * gdbsupport/gdb-sigmask.h: New file.
1277         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1278         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1279         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1280         pthread_sigmask.
1281         * configure, config.in: Rebuild.
1282         * gdbsupport/block-signals.h: New file.
1283
1284 2019-11-26  Tom Tromey  <tom@tromey.com>
1285
1286         * acinclude.m4: Include ax_pthread.m4.
1287         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1288         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1289         (CLIBS): Use PTHREAD_LIBS.
1290         (aclocal_m4_deps): Add ax_pthread.m4.
1291         * config.in, configure: Rebuild.
1292         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1293
1294 2019-11-26  Tom Tromey  <tom@tromey.com>
1295
1296         * symtab.h (struct minimal_symbol) <name_set>: New member.
1297         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1298         Don't call symbol_set_names.
1299         (minimal_symbol_reader::install): Call symbol_set_names.
1300
1301 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1302
1303         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1304         restore_active_ext_lang, as GIL is needed for (indirectly)
1305         called PyOS_InterruptOccurred.
1306
1307 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1308
1309         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1310         definition.
1311
1312 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1313
1314         * remote-sim.c (simulator_command): Make static, remove
1315         declaration.
1316
1317 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1318
1319         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1320         static.
1321         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1322         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1323         (main): Likewise.
1324         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1325         (main): Likewise.
1326         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1327         (main): Likewise.
1328         * unittests/basic_string_view/element_access/char/1.cc (test01):
1329         Likewise.
1330         (main): Likewise.
1331         * unittests/basic_string_view/element_access/char/empty.cc (main):
1332         Likewise.
1333         * unittests/basic_string_view/element_access/char/front_back.cc
1334         (test01): Likewise.
1335         (main): Likewise.
1336         * unittests/basic_string_view/inserters/char/2.cc (test05):
1337         Likewise.
1338         (main): Likewise.
1339         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1340         (test01): Likewise.
1341         (main): Likewise.
1342         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1343         (test01): Likewise.
1344         (main): Likewise.
1345         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1346         Likewise.
1347         * unittests/basic_string_view/operations/compare/char/1.cc
1348         (test01): Likewise.
1349         (main): Likewise.
1350         * unittests/basic_string_view/operations/compare/char/13650.cc
1351         (test01): Likewise.
1352         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1353         Likewise.
1354         (main): Likewise.
1355         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1356         Likewise.
1357         (main): Likewise.
1358         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1359         Likewise.
1360         (main): Likewise.
1361         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1362         Likewise.
1363         (main): Likewise.
1364         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1365         Likewise.
1366         (main): Likewise.
1367         * unittests/basic_string_view/operations/find/char/4.cc (main):
1368         Likewise.
1369         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1370         Likewise.
1371         (main): Likewise.
1372         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1373         Likewise.
1374         (main): Likewise.
1375         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1376         Likewise.
1377         (main): Likewise.
1378         * unittests/basic_string_view/operations/substr/char/1.cc
1379         (test01): Likewise.
1380         (main): Likewise.
1381         * unittests/basic_string_view/operators/char/2.cc (main):
1382         Likewise.
1383         * unittests/optional/assignment/1.cc (test): Likewise.
1384         * unittests/optional/assignment/2.cc (test): Likewise.
1385         * unittests/optional/assignment/3.cc (test): Likewise.
1386         * unittests/optional/assignment/4.cc (test): Likewise.
1387         * unittests/optional/assignment/5.cc (test): Likewise.
1388         * unittests/optional/assignment/6.cc (test): Likewise.
1389         * unittests/optional/assignment/7.cc (test): Likewise.
1390         * unittests/optional/cons/copy.cc (test): Likewise.
1391         * unittests/optional/cons/default.cc (test): Likewise.
1392         * unittests/optional/cons/move.cc (test): Likewise.
1393         * unittests/optional/cons/value.cc (test): Likewise.
1394         * unittests/optional/in_place.cc (test): Likewise.
1395         * unittests/optional/observers/1.cc (test): Likewise.
1396         * unittests/optional/observers/2.cc (test): Likewise.
1397
1398 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1399
1400         * tui-win.h (tui_set_var_cmd): Remove.
1401         * tui-win.c (tui_set_var_cmd): Make static.
1402
1403 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1404
1405         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1406         rbreak_command_wrapper): Remove.
1407         * symtab.c (rbreak_command_wrapper): Remove.
1408
1409 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1410
1411         * inferior.h (info_terminal_command): Remove declaration.
1412         * inflow.c (info_terminal_command): Make static.
1413
1414 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1415
1416         * inferior.c (exit_inferior_silent): Remove.
1417
1418 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1419
1420         * dictionary.c (dict_empty, mdict_empty): Remove.
1421         * dictionary.c (mdict_empty): Remove.
1422
1423 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1424
1425          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1426          (arc_insn_get_memory_offset): Likewise.
1427          (arc_insn_dump): Likewise.
1428          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1429          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1430          * dictionary.c (dict_iterator_next): Likewise.
1431          (dict_iter_match_first): Likewise.
1432          (dict_iter_match_next): Likewise.
1433          * f-lang.c (evaluate_subexp_f): Likewise.
1434          * hppa-tdep.c (hppa_read_pc): Likewise.
1435          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1436          * parse.c (write_exp_elt_msym): Likewise.
1437          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1438          * remote.c (remote_packet_size): Likewise.
1439          (remote_notif_stop_parse): Likewise.
1440          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1441          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1442          * source.c (prepare_path_for_appending): Likewise.
1443          * sparc64-linux-tdep.c
1444          (sparc64_linux_handle_segmentation_fault); Likewise.
1445          * stack.c (frame_selection_by_function_completer): Likewise.
1446
1447 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1448
1449         * completer.c (set_gdb_completion_word_break_characters):
1450         Remove.
1451
1452 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1453
1454         * dwarf-index-write.c: Include dwarf-index-write.h.
1455         * mi/mi-interp.c: Include mi/mi-interp.h.
1456
1457 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1458
1459         * aarch32-tdep.c: Include aarch32-tdep.h.
1460         * aarch32-tdep.h: Forward-declare struct target_desc.
1461
1462 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1463
1464         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1465         strerror.
1466         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1467         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1468
1469 2019-11-25  Tom de Vries  <tdevries@suse.de>
1470
1471         * contrib/words.sh: Add -c option.
1472
1473 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1474
1475         * solib.c (solib_find_1): Change int to bool.
1476         (exec_file_find): Change int to bool.
1477         (solib_find): Change int to bool.
1478         (solib_read_symbols): Change int to bool.
1479         (solib_used): Change int to bool.
1480         (solib_add): Change int to bool.
1481         (info_sharedlibrary_command): Change int to bool.
1482         (solib_contains_address_p): Change int to bool.
1483         (solib_keep_data_in_core): Change int to bool.
1484         (in_solib_dynsym_resolve_code): Change int to bool.
1485         (reload_shared_libraries_1): Change int to bool.
1486         (gdb_sysroot_changed): Change int to bool.
1487         * solib.h (solib_read_symbols): Change int to bool.
1488         (solib_contains_address_p): Change int to bool.
1489         (solib_keep_data_in_core): Change int to bool.
1490         (in_solib_dynsym_resolve_code): Change int to bool.
1491         (libpthread_name_p): Change int to bool.
1492
1493 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1494
1495         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1496         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1497         (remote_packet_max_chars): New static global.
1498         (show_remote_packet_max_chars): New function.
1499         (remote_target::putpkt_binary): Adjust to use new
1500         remote_packet_max_chars option.
1501         (remote_target::getpkt_or_notif_sane_1): Likewise.
1502         (_initialize_remote): Register new remote-packet-max-chars option.
1503
1504 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1505
1506         * m68k-linux-nat.c: Include gdbarch.h.
1507
1508 2019-11-24  Tom Tromey  <tom@tromey.com>
1509
1510         * symfile.c (read_symbols): Update.
1511         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1512         bool.
1513         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1514         (psym_lookup_symbol, psym_find_last_source_symtab)
1515         (psym_forget_cached_source_info, psym_print_stats)
1516         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1517         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1518         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1519         (psym_find_compunit_symtab_by_address)
1520         (maintenance_print_psymbols, maintenance_info_psymtabs)
1521         (maintenance_check_psymtabs): Update.
1522         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1523         bool.
1524
1525 2019-11-22  Tom Tromey  <tom@tromey.com>
1526
1527         * observable.h: Update comments.
1528
1529 2019-11-22  Tom Tromey  <tromey@adacore.com>
1530
1531         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1532         (print_ada_task_info): Don't try to fetch thread id if task is not
1533         alive.
1534
1535 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1536
1537         * ada-exp.y: Update.
1538         * ada-lang.c (sort_choices): Update.
1539         (ada_print_symbol_signature): Update.
1540         (resolve_subexp): Update.
1541         (ada_parse_renaming): Update.
1542         (ada_read_renaming_var_value): Update.
1543         (lesseq_defined_than): Update.
1544         (remove_extra_symbols): Update.
1545         (remove_irrelevant_renamings): Update.
1546         (ada_add_block_symbols): Update.
1547         (ada_collect_symbol_completion_matches): Update.
1548         (ada_is_renaming_symbol): Update.
1549         (aggregate_assign_from_choices): Update.
1550         (ada_evaluate_subexp): Update.
1551         (ada_has_this_exception_support): Update.
1552         (ada_is_non_standard_exception_sym): Update.
1553         (ada_add_exceptions_from_frame): Update.
1554         (ada_add_global_exceptions): Update.
1555         (ada_print_subexp): Update.
1556         * ax-gdb.c (gen_var_ref): Update.
1557         (gen_maybe_namespace_elt): Update.
1558         (gen_expr_for_cast): Update.
1559         (gen_expr): Update.
1560         * block.h: Update.
1561         * blockframe.c (find_pc_partial_function): Update.
1562         * breakpoint.c (print_breakpoint_location): Update.
1563         (update_static_tracepoint): Update.
1564         * btrace.c (ftrace_print_function_name): Update.
1565         (ftrace_function_switched): Update.
1566         * buildsym.c (find_symbol_in_list): Update.
1567         * c-exp.y: Update.
1568         * c-typeprint.c (c_print_typedef): Update.
1569         (c_type_print_template_args): Update.
1570         * cli/cli-cmds.c (edit_command): Update.
1571         (list_command): Update.
1572         (print_sal_location): Update.
1573         * coffread.c (patch_opaque_types): Update.
1574         (process_coff_symbol): Update.
1575         (coff_read_enum_type): Update.
1576         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1577         (convert_one_symbol): Update.
1578         (hash_symname): Update.
1579         (eq_symname): Update.
1580         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1581         * compile/compile-cplus-types.c (debug_print_scope): Update.
1582         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1583         * compile/compile-object-load.c (get_out_value_type): Update.
1584         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1585         (search_symbol_list): Update.
1586         (cp_lookup_symbol_imports_or_template): Update.
1587         * cp-support.c (overload_list_add_symbol): Update.
1588         * ctfread.c (psymtab_to_symtab): Update.
1589         * dbxread.c (cp_set_block_scope): Update.
1590         * dictionary.c (iter_match_first_hashed): Update.
1591         (iter_match_next_hashed): Update.
1592         (insert_symbol_hashed): Update.
1593         (iter_match_next_linear): Update.
1594         * dictionary.h: Update.
1595         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1596         (locexpr_describe_location_piece): Update.
1597         (locexpr_describe_location_1): Update.
1598         (locexpr_generate_c_location): Update.
1599         (loclist_describe_location): Update.
1600         (loclist_generate_c_location): Update.
1601         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1602         (read_func_scope): Update.
1603         (process_enumeration_scope): Update.
1604         (new_symbol): Update.
1605         (dwarf2_const_value): Update.
1606         (dwarf2_symbol_mark_computed): Update.
1607         * eval.c (evaluate_funcall): Update.
1608         (evaluate_subexp_standard): Update.
1609         * expprint.c (print_subexp_standard): Update.
1610         (dump_subexp_body_standard): Update.
1611         * f-valprint.c (info_common_command_for_block): Update.
1612         * findvar.c (get_hosting_frame): Update.
1613         (default_read_var_value): Update.
1614         * go-lang.c (go_symbol_package_name): Update.
1615         * guile/scm-block.c (bkscm_print_block_smob): Update.
1616         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1617         (gdbscm_symbol_name): Update.
1618         (gdbscm_symbol_linkage_name): Update.
1619         (gdbscm_symbol_print_name): Update.
1620         * infcall.c (get_function_name): Update.
1621         * infcmd.c (jump_command): Update.
1622         (finish_command): Update.
1623         * infrun.c (insert_exception_resume_breakpoint): Update.
1624         * linespec.c (canonicalize_linespec): Update.
1625         (create_sals_line_offset): Update.
1626         (convert_linespec_to_sals): Update.
1627         (complete_label): Update.
1628         (find_label_symbols_in_block): Update.
1629         * m2-typeprint.c (m2_print_typedef): Update.
1630         * mdebugread.c (mdebug_reg_to_regnum): Update.
1631         (parse_symbol): Update.
1632         (mylookup_symbol): Update.
1633         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1634         (list_args_or_locals): Update.
1635         * objc-lang.c (compare_selectors): Update.
1636         (info_selectors_command): Update.
1637         (compare_classes): Update.
1638         (info_classes_command): Update.
1639         (find_imps): Update.
1640         * p-typeprint.c (pascal_print_typedef): Update.
1641         * printcmd.c (build_address_symbolic): Update.
1642         (info_address_command): Update.
1643         (print_variable_and_value): Update.
1644         * python/py-framefilter.c (extract_sym): Update.
1645         (py_print_single_arg): Update.
1646         * python/py-symbol.c (sympy_str): Update.
1647         (sympy_get_name): Update.
1648         (sympy_get_linkage_name): Update.
1649         * python/python.c (gdbpy_rbreak): Update.
1650         * record-btrace.c (btrace_get_bfun_name): Update.
1651         (btrace_call_history): Update.
1652         * rust-lang.c (rust_print_typedef): Update.
1653         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1654         * stabsread.c (stab_reg_to_regnum): Update.
1655         (define_symbol): Update.
1656         (read_enum_type): Update.
1657         (common_block_end): Update.
1658         (cleanup_undefined_types_1): Update.
1659         (scan_file_globals): Update.
1660         * stack.c (print_frame_arg): Update.
1661         (print_frame_args): Update.
1662         (find_frame_funname): Update.
1663         (info_frame_command_core): Update.
1664         (iterate_over_block_locals): Update.
1665         (print_block_frame_labels): Update.
1666         (do_print_variable_and_value): Update.
1667         (iterate_over_block_arg_vars): Update.
1668         (return_command): Update.
1669         * symmisc.c (dump_symtab_1): Update.
1670         (print_symbol): Update.
1671         * symtab.c (eq_symbol_entry): Update.
1672         (symbol_cache_dump): Update.
1673         (lookup_language_this): Update.
1674         (find_pc_sect_line): Update.
1675         (skip_prologue_sal): Update.
1676         (symbol_search::compare_search_syms): Update.
1677         (treg_matches_sym_type_name): Update.
1678         (search_symbols): Update.
1679         (print_symbol_info): Update.
1680         (rbreak_command): Update.
1681         (completion_list_add_symbol): Update.
1682         (find_gnu_ifunc): Update.
1683         (get_symbol_address): Update.
1684         (search_module_symbols): Update.
1685         (info_module_subcommand): Update.
1686         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1687         (SYMBOL_LINKAGE_NAME): Remove.
1688         (SYMBOL_DEMANGLED_NAME): Remove.
1689         (SYMBOL_PRINT_NAME): Remove.
1690         (SYMBOL_SEARCH_NAME): Remove.
1691         * tracepoint.c (set_traceframe_context): Update.
1692         (validate_actionline): Update.
1693         (collection_list::collect_symbol): Update.
1694         (encode_actions_1): Update.
1695         (info_scope_command): Update.
1696         (print_one_static_tracepoint_marker): Update.
1697         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1698         * valops.c (address_of_variable): Update.
1699         (find_overload_match): Update.
1700         (find_oload_champ): Update.
1701
1702 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1703
1704         * ada-lang.c (ada_lookup_simple_minsym): Update.
1705         (ada_collect_symbol_completion_matches): Update.
1706         * ada-tasks.c (read_atcb): Update.
1707         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1708         (amd64_windows_skip_trampoline_code): Update.
1709         * arm-tdep.c (skip_prologue_function): Update.
1710         (arm_skip_stack_protector): Update.
1711         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1712         (arm_wince_skip_main_prologue): Update.
1713         * ax-gdb.c (gen_expr): Update.
1714         * block.c (call_site_for_pc): Update.
1715         * blockframe.c (find_pc_partial_function): Update.
1716         * breakpoint.c (set_breakpoint_location_function): Update.
1717         * btrace.c (ftrace_print_function_name): Update.
1718         (ftrace_function_switched): Update.
1719         * c-valprint.c (print_unpacked_pointer): Update.
1720         * coffread.c (coff_symfile_read): Update.
1721         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1722         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1723         * dwarf-index-write.c (write_psymbols): Update.
1724         * dwarf2loc.c (call_site_to_target_addr): Update.
1725         (func_verify_no_selftailcall): Update.
1726         (tailcall_dump): Update.
1727         (call_site_find_chain_1): Update.
1728         (dwarf_expr_reg_to_entry_parameter): Update.
1729         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1730         * eval.c (evaluate_funcall): Update.
1731         (evaluate_subexp_standard): Update.
1732         (evaluate_subexp_for_sizeof): Update.
1733         * expprint.c (print_subexp_standard): Update.
1734         (dump_subexp_body_standard): Update.
1735         * frame.c (get_prev_frame_always_1): Update.
1736         * frv-tdep.c (frv_skip_main_prologue): Update.
1737         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1738         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1739         (gnuv3_get_typename_from_type_info): Update.
1740         (gnuv3_skip_trampoline): Update.
1741         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1742         * i386-tdep.c (i386_skip_main_prologue): Update.
1743         (i386_pe_skip_trampoline_code): Update.
1744         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1745         * infcall.c (get_function_name): Update.
1746         * linespec.c (minsym_found): Update.
1747         * linux-fork.c (info_checkpoints_command): Update.
1748         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1749         (m32c_m16c_pointer_to_address): Update.
1750         * maint.c (maintenance_translate_address): Update.
1751         * minsyms.c (add_minsym_to_hash_table): Update.
1752         (add_minsym_to_demangled_hash_table): Update.
1753         (lookup_minimal_symbol_mangled): Update.
1754         (lookup_minimal_symbol_demangled): Update.
1755         (lookup_minimal_symbol_linkage): Update.
1756         (lookup_minimal_symbol_text): Update.
1757         (lookup_minimal_symbol_by_pc_name): Update.
1758         (minimal_symbol_is_less_than): Update.
1759         (compact_minimal_symbols): Update.
1760         (build_minimal_symbol_hash_tables): Update.
1761         (find_solib_trampoline_target): Update.
1762         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1763         (mips_skip_pic_trampoline_code): Update.
1764         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1765         * objc-lang.c (info_selectors_command): Update.
1766         (info_classes_command): Update.
1767         (find_methods): Update.
1768         (find_imps): Update.
1769         * p-valprint.c (pascal_val_print): Update.
1770         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1771         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1772         * printcmd.c (build_address_symbolic): Update.
1773         (info_symbol_command): Update.
1774         * psymtab.c (psymbol_name_matches): Update.
1775         (match_partial_symbol): Update.
1776         (lookup_partial_symbol): Update.
1777         (print_partial_symbols): Update.
1778         (sort_pst_symbols): Update.
1779         (maintenance_check_psymtabs): Update.
1780         * python/py-framefilter.c (py_print_frame): Update.
1781         * python/python.c (gdbpy_rbreak): Update.
1782         * record-btrace.c (btrace_get_bfun_name): Update.
1783         (btrace_call_history): Update.
1784         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1785         (rs6000_skip_trampoline_code): Update.
1786         * sol-thread.c (info_cb): Update.
1787         * stabsread.c (scan_file_globals): Update.
1788         * stack.c (find_frame_funname): Update.
1789         (info_frame_command_core): Update.
1790         * symmisc.c (dump_msymbols): Update.
1791         * symtab.c (symbol_natural_name): Rename to..,
1792         (general_symbol_info::natural_name): ...this.
1793         (symbol_demangled_name): Rename to...
1794         (general_symbol_info::demangled_name): ...this.
1795         (symbol_search_name): Rename to...
1796         (general_symbol_info::search_name): ...this.
1797         (symbol_matches_search_name): Update.
1798         (find_pc_sect_line): Update.
1799         (skip_prologue_sal): Update.
1800         (search_symbols): Update.
1801         (print_msymbol_info): Update.
1802         (rbreak_command): Update.
1803         (completion_list_add_msymbol): Update.
1804         (completion_list_objc_symbol): Update.
1805         (get_msymbol_address): Update.
1806         * symtab.h (struct general_symbol_info): Add member functions
1807         natural_name (), linkage_name (), print_name (), demangled_name (),
1808         and search_name ().
1809         (SYMBOL_NATURAL_NAME): Update.
1810         (symbol_natural_name): Move to a member function on general_symbol_info.
1811         (SYMBOL_DEMANGLED_NAME): Update.
1812         (symbol_demangled_name): Move to a member function on
1813         general_symbol_info.
1814         (SYMBOL_SEARCH_NAME): Update.
1815         (symbol_search_name): Move to a member function on general_symbol_info.
1816         (MSYMBOL_NATURAL_NAME): Remove.
1817         (MSYMBOL_LINKAGE_NAME): Remove.
1818         (MSYMBOL_PRINT_NAME): Remove.
1819         (MSYMBOL_DEMANGLED_NAME): Remove.
1820         (MSYMBOL_SEARCH_NAME): Remove.
1821         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1822
1823 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1824
1825         * symtab.c (create_demangled_names_hash): Use per_bfd->
1826         minimal_symbol_count for computing the initial size, if greater
1827         than our default size.
1828
1829 2019-11-22  Tom de Vries  <tdevries@suse.de>
1830
1831         * contrib/words.sh: Improve words extraction.
1832
1833 2019-11-22  Tom de Vries  <tdevries@suse.de>
1834
1835         * contrib/words.sh: Combine sed invocations.
1836
1837 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1838
1839         * Makefile.in: Update.
1840         * demangle.c: Rename to...
1841         * gdb-demangle.c: ..this.
1842         (is_cplus_marker): Change return type to bool.
1843         (_initialize_demangler): Rename to...
1844         (_initialize_gdb_demangle): ...this.
1845         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1846         * symtab.h (demangle): Remove declaration; instead include
1847         gdb-demangle.h.
1848
1849 2019-11-21  Tom Tromey  <tromey@adacore.com>
1850
1851         * gdbsupport/format.c (format_pieces): Parse %I64d.
1852         * unittests/format_pieces-selftests.c (test_windows_formats): New
1853         function.
1854         (run_tests): Call it.
1855
1856 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1857
1858         Byte reverse display of variables with DW_END_big, DW_END_little
1859         (DW_AT_endianity) dwarf attributes if different than the native
1860         byte order.
1861         * ada-lang.c (ada_value_binop):
1862         Use type_byte_order instead of gdbarch_byte_order.
1863         * ada-valprint.c (printstr):
1864         (ada_val_print_string):
1865         * ada-lang.c (value_pointer):
1866         (ada_value_binop):
1867         Use type_byte_order instead of gdbarch_byte_order.
1868         * c-lang.c (c_get_string):
1869         Use type_byte_order instead of gdbarch_byte_order.
1870         * c-valprint.c (c_val_print_array):
1871         Use type_byte_order instead of gdbarch_byte_order.
1872         * cp-valprint.c (cp_print_class_member):
1873         Use type_byte_order instead of gdbarch_byte_order.
1874         * dwarf2loc.c (rw_pieced_value):
1875         Use type_byte_order instead of gdbarch_byte_order.
1876         * dwarf2read.c (read_base_type): Handle DW_END_big,
1877         DW_END_little
1878         * f-lang.c (f_get_encoding):
1879         Use type_byte_order instead of gdbarch_byte_order.
1880         * findvar.c (default_read_var_value):
1881         Use type_byte_order instead of gdbarch_byte_order.
1882         * gdbtypes.c (check_types_equal):
1883         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1884         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1885         and TYPE_ENDIANITY_LITTLE if set.
1886         (type_byte_order): new function.
1887         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1888         (struct main_type) <flag_endianity_not_default>:
1889         New field.
1890         (type_byte_order): New function.
1891         * infcmd.c (default_print_one_register_info):
1892         Use type_byte_order instead of gdbarch_byte_order.
1893         * p-lang.c (pascal_printstr):
1894         Use type_byte_order instead of gdbarch_byte_order.
1895         * p-valprint.c (pascal_val_print):
1896         Use type_byte_order instead of gdbarch_byte_order.
1897         * printcmd.c (print_scalar_formatted):
1898         Use type_byte_order instead of gdbarch_byte_order.
1899         * solib-darwin.c (darwin_current_sos):
1900         Use type_byte_order instead of gdbarch_byte_order.
1901         * solib-svr4.c (solib_svr4_r_ldsomap):
1902         Use type_byte_order instead of gdbarch_byte_order.
1903         * stap-probe.c (stap_modify_semaphore):
1904         Use type_byte_order instead of gdbarch_byte_order.
1905         * target-float.c (target_float_same_format_p):
1906         Use type_byte_order instead of gdbarch_byte_order.
1907         * valarith.c (scalar_binop):
1908         (value_bit_index):
1909         Use type_byte_order instead of gdbarch_byte_order.
1910         * valops.c (value_cast):
1911         Use type_byte_order instead of gdbarch_byte_order.
1912         * valprint.c (generic_emit_char):
1913         (generic_printstr):
1914         (val_print_string):
1915         Use type_byte_order instead of gdbarch_byte_order.
1916         * value.c (unpack_long):
1917         (unpack_bits_as_long):
1918         (unpack_value_bitfield):
1919         (modify_field):
1920         (pack_long):
1921         (pack_unsigned_long):
1922         Use type_byte_order instead of gdbarch_byte_order.
1923         * findvar.c (unsigned_pointer_to_address):
1924         (signed_pointer_to_address):
1925         (unsigned_address_to_pointer):
1926         (address_to_signed_pointer):
1927         (default_read_var_value):
1928         (default_value_from_register):
1929         Use type_byte_order instead of gdbarch_byte_order.
1930         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1931         Use type_byte_order instead of gdbarch_byte_order.
1932         * riscv-tdep.c (riscv_print_one_register_info):
1933         Use type_byte_order instead of gdbarch_byte_order.
1934
1935 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1936
1937         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1938         (current_ui_gdb_stdin_ptr): Likewise.
1939         (current_ui_gdb_stderr_ptr): Likewise.
1940         (current_ui_gdb_stdlog_ptr): Likewise.
1941         (current_ui_current_uiout_ptr): Likewise.
1942         (gen_ret_current_ui_field_ptr): Remove.
1943
1944 2019-11-21  Tom de Vries  <tdevries@suse.de>
1945
1946         PR gdb/24956
1947         * cli/cli-script.c (execute_control_command): Only switch to
1948         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1949
1950 2019-11-19  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1953         Now static.  Change type of "name".
1954         (tui_set_win_height_command): Don't copy "arg".
1955         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1956         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1957
1958 2019-11-19  Ali Tamur <tamur@google.com>
1959
1960         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1961         "if (attr != nullptr)".
1962         (dwarf2_find_base_address): Likewise.
1963         (dwarf2_build_include_psymtabs): Likewise.
1964         (read_cutu_die_from_dwo): Likewise.
1965         (read_func_scope): Likewise.
1966         (read_call_site_scope): Likewise.
1967         (dwarf2_get_pc_bounds): Likewise.
1968         (dwarf2_record_block_ranges): Likewise.
1969         (dwarf2_add_field): Likewise.
1970         (dwarf2_add_member_fn): Likewise.
1971         (read_structure_type): Likewise.
1972         (read_enumeration_type): Likewise.
1973         (read_array_type): Likewise.
1974         (read_array_order): Likewise.
1975         (read_set_type): Likewise.
1976         (read_common_block): Likewise.
1977         (read_tag_reference_type): Likewise.
1978         (read_tag_string_type): Likewise.
1979         (read_subroutine_type): Likewise.
1980         (read_base_type): Likewise.
1981         (read_subrange_type): Likewise.
1982         (new_symbol): Likewise.
1983         (prepare_one_comp_unit): Likewise.
1984
1985 2019-11-19  Tom Tromey  <tromey@adacore.com>
1986
1987         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1988         result in error when DebugActiveProcess fails.
1989
1990 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1991             Pedro Alves  <palves@redhat.com>
1992
1993         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1994         * target.c (target_stack::push): Call 'unpush' if there's a
1995         target on top of the stack.
1996
1997 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1998
1999         * python/py-block.c (blpy_dealloc): Call tp_free.
2000         (blpy_block_syms_dealloc): Likewise.
2001         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2002         * python/py-inferior.c (infpy_dealloc): Likewise.
2003         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2004         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2005         * python/py-symbol.c (sympy_dealloc): Likewise.
2006         * python/py-symtab.c (stpy_dealloc): Likewise.
2007         * python/py-type.c (typy_iterator_dealloc): Likewise.
2008
2009 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2010
2011         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2012         constructor instead of using a class initializer.
2013
2014 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2015
2016         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2017         * configure: Regenerate.
2018         * configure.ac: Don't source common.host.
2019         * gdbsupport/common.host: Remove.
2020         * gdbsupport/mingw-strerror.c: Remove.
2021         * gdbsupport/posix-strerror.c: Rename to...
2022         * gdbsupport/safe-strerror.c: ...this.
2023
2024 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2025
2026         * maint.c (scoped_command_stats::print_time): Use localtime_r
2027         instead of localtime (provided through gnulib if necessary).
2028         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2029         of ctime.
2030
2031 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2034         avoid compile errors.
2035
2036 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2037
2038         * config.in: Regenerate.
2039         * configure: Regenerate.
2040         * gdbsupport/common.m4: No longer check for strerror_r.
2041         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2042         POSIX version of strerror_r, now that gnulib provides it if
2043         necessary.
2044
2045 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2046
2047         * README (`configure' options): Update.
2048
2049 2019-11-14  Tom Tromey  <tromey@adacore.com>
2050
2051         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2052         expected type for the RHS if the LHS is a convenience variable.
2053
2054 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2055
2056         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2057         Provide explicit default and copy constructor.
2058
2059 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2060
2061         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2062         only call Py_INCREF (newbp) in the bppy_pending_object case.
2063
2064 2019-11-13  Tom Tromey  <tromey@adacore.com>
2065
2066         PR build/25182:
2067         * psympriv.h (partial_symbol): Remove static assert.
2068         * symtab.h (general_symbol_info, symbol): Remove static assert.
2069
2070 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2071
2072         * gdbsupport/format.c (format_pieces::format_pieces): Support
2073         printf 'z' size modifier.
2074         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2075         * printcmd.c (ui_printf):  Handle size_t_arg.
2076         * ui-out.c (ui_out::vmessage): Likewise.
2077         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2078         function.
2079         (run_tests): Call test_format_int_sizes.
2080
2081 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2082
2083         * ada-exp.y (write_ambiguous_var): Update.
2084         * buildsym.c (add_symbol_to_list): Update.
2085         * dwarf2read.c (read_variable): Update.
2086         (new_symbol): Update.
2087         * jit.c (finalize_symtab): Update.
2088         * language.c (language_alloc_type_symbol): Update.
2089         * symtab.c (fixup_symbol_section): Update.
2090         (initialize_objfile_symbol_1): Move code to...
2091         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2092         (allocate_symbol): Update.
2093         (allocate_template_symbol): Update.
2094         (get_symbol_address): Update.
2095         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2096         of having as a field, and add a constructor.
2097         (SYMBOL_VALUE): Update.
2098         (SYMBOL_VALUE_ADDRESS): Update.
2099         (SET_SYMBOL_VALUE_ADDRESS): Update.
2100         (SYMBOL_VALUE_BYTES): Update.
2101         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2102         (SYMBOL_BLOCK_VALUE): Update.
2103         (SYMBOL_VALUE_CHAIN): Update.
2104         (SYMBOL_LANGUAGE): Update.
2105         (SYMBOL_SECTION): Update.
2106         (SYMBOL_OBJ_SECTION): Update.
2107         (SYMBOL_SET_LANGUAGE): Update.
2108         (SYMBOL_SET_LINKAGE_NAME): Update.
2109         (SYMBOL_SET_NAMES): Update.
2110         (SYMBOL_NATURAL_NAME): Update.
2111         (SYMBOL_LINKAGE_NAME): Update.
2112         (SYMBOL_DEMANGLED_NAME): Update.
2113         (SYMBOL_SEARCH_NAME): Update.
2114         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2115         (struct symbol): Update.
2116         (struct template_symbol): Update.
2117         (struct rust_vtable_symbol): Update.
2118         * xcoffread.c (SYMBOL_DUP): Update.
2119
2120 2019-11-12  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-layout.c (show_layout): Set current_layout.
2123         (show_source_disasm_command, show_data)
2124         (show_source_or_disasm_and_command): Don't set current_layout.
2125
2126 2019-11-12  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2129
2130 2019-11-12  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-win.c (resize_message): New global.
2133         (show_tui_resize_message): New function.
2134         (tui_async_resize_screen): Print message if requested.
2135         (_initialize_tui_win): Add tui-resize-message setting.
2136         * NEWS: Add entry for new commands.
2137
2138 2019-11-11  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2141         functions.
2142
2143 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2144
2145         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2146
2147 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2150         function.
2151         * python/python-internal.h (gdbpy_lookup_static_symbols):
2152         Declare new function.
2153         * python/python.c (python_GdbMethods): Add
2154         gdb.lookup_static_symbols method.
2155         * NEWS: Mention gdb.lookup_static_symbols.
2156
2157 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2160         static block of current object file first.  Also fix typo in
2161         header comment.
2162
2163 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * stack.c (set_last_displayed_sal): Delete.
2166         (last_displayed_sal_valid): Delete.
2167         (last_displayed_pspace): Delete.
2168         (last_displayed_addr): Delete.
2169         (last_displayed_symtab): Delete.
2170         (last_displayed_line): Delete.
2171         (class last_displayed_symtab_info_type): New.
2172         (last_displayed_symtab_info): New static global variable.
2173         (print_frame_info): Call methods on last_displayed_symtab_info.
2174         (clear_last_displayed_sal): Update header comment, and make use of
2175         last_displayed_symtab_info.
2176         (last_displayed_sal_is_valid): Likewise.
2177         (get_last_displayed_pspace): Likewise.
2178         (get_last_displayed_addr): Likewise.
2179         (get_last_displayed_symtab): Likewise.
2180         (get_last_displayed_line): Likewise.
2181         (get_last_displayed_sal): Likewise.
2182         * stack.h (clear_last_displayed_sal): Update header comment.
2183         (last_displayed_sal_is_valid): Likewise.
2184         (get_last_displayed_pspace): Likewise.
2185         (get_last_displayed_addr): Likewise.
2186         (get_last_displayed_symtab): Likewise.
2187         (get_last_displayed_line): Likewise.
2188         (get_last_displayed_sal): Likewise.
2189
2190 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * stack.c (frame_show_address): Convert return type to bool.
2193         * stack.h (frame_show_address): Likewise, and update header
2194         comment.
2195
2196 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2199         * unittests/vec-utils-selftests.c: New file.
2200         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2201
2202 2019-11-10  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2205         (tui_highlight_win): Likewise.
2206         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2207         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2208         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2209         Don't set can_highlight.
2210
2211 2019-11-10  Tom Tromey  <tom@tromey.com>
2212
2213         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2214         Remove unused declaration.
2215
2216 2019-11-08  Tom Tromey  <tromey@adacore.com>
2217
2218         * top.c (read_command_file): Update.
2219         (command_line_input): Make return type const.
2220         * python/py-gdb-readline.c: Update.
2221         * linespec.c (decode_line_2): Update.
2222         * defs.h (command_line_input): Make return type const.
2223         * cli/cli-script.c (read_next_line): Make return type const.
2224         * ada-lang.c (get_selections): Update.
2225
2226 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2227
2228         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2229         * mi/mi-main.c (output_cores): Likewise.
2230         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2231         (linux_xfer_osdata_modules): Likewise.
2232         * remote.c (register_remote_support_xml): Likewise.
2233         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2234         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2235
2236 2019-11-06  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-interp.c: Don't include readline.h.
2239         * tui/tui-hooks.c: Don't include readline.h.
2240         * symmisc.c: Include tilde.h, not readline.h.
2241         * symfile.c: Include tilde.h, not readline.h.
2242         * source.c: Include tilde.h, not readline.h.
2243         * solib.c: Include tilde.h, not readline.h.
2244         * psymtab.c: Include tilde.h, not readline.h.
2245         * exec.c: Include tilde.h, not readline.h.
2246         * corelow.c: Include tilde.h, not readline.h.
2247         * cli/cli-dump.c: Include tilde.h, not readline.h.
2248         * cli/cli-cmds.c: Don't include readline.h.
2249
2250 2019-11-05  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2253         (tui_disassemble): Set addr_size.
2254         (tui_disasm_window::set_contents): Use addr_size.
2255
2256 2019-11-05  Tom Tromey  <tom@tromey.com>
2257
2258         * rust-lang.c (rust_language_defn): Update.
2259         * python/py-value.c (valpy_string): Call c_get_string.
2260         * p-lang.c (pascal_language_defn): Update.
2261         * opencl-lang.c (opencl_language_defn): Update.
2262         * objc-lang.c (objc_language_defn): Update.
2263         * m2-lang.c (m2_language_defn): Update.
2264         * language.c (unknown_language_defn, auto_language_defn): Update.
2265         (default_get_string): Remove.
2266         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2267         * go-lang.c (go_language_defn): Update.
2268         * f-lang.c (f_language_defn): Update.
2269         * d-lang.c (d_language_defn): Update.
2270         * c-lang.c (c_language_defn, cplus_language_defn)
2271         (asm_language_defn, minimal_language_defn): Update.
2272         * ada-lang.c (ada_language_defn): Update.
2273         * language.h (struct language_defn) <la_get_string>: Remove.
2274         (LA_GET_STRING): Remove.
2275         (default_get_string): Don't declare.
2276
2277 2019-11-05  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-source.h (struct tui_source_window): Inline
2280         constructor.  Remove destructor.
2281         <style_changed, m_observable>: Move to superclass.
2282         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2283         (struct tui_source_window_base): Move private members to end.
2284         <style_changed, m_observable>: Move from tui_source_window.
2285         * tui/tui-winsource.c (tui_copy_source_line): Move from
2286         tui-source.c.  Rename from copy_source_line.  Add special handling
2287         for negative line number.
2288         (tui_source_window_base::style_changed): Move from
2289         tui_source_window.
2290         (tui_source_window_base): Register observer.
2291         (~tui_source_window_base): New.
2292         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2293         rename.
2294         (tui_source_window::set_contents): Use tui_copy_source_line.
2295         (tui_source_window::tui_source_window): Move to tui-source.h.
2296         (tui_source_window::~tui_source_window): Remove.
2297         (tui_source_window::style_changed): Move to superclass.
2298         * tui/tui-disasm.c (tui_disassemble): Create string file with
2299         styling, when possible.  Add "addr_size" parameter.
2300         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2301         Don't compute maximum size.
2302         (len_without_escapes): New function
2303
2304 2019-11-05  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2307         std::string.
2308         * tui/tui-winsource.c (tui_show_source_line): Update.
2309         * tui/tui-source.c (tui_source_window::set_contents): Update.
2310         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2311
2312 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2313
2314         * symtab.h (gdb_static_assert): Put && operator at the beginning
2315         of the line instead of the end.
2316
2317 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2318
2319         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2320         and sizeof (symbol).
2321         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2322
2323 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2324
2325         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2326         * configure.host: Mark *-*-solaris2.10* obsolete.
2327         * configure.tgt: Mark Solaris < 11 obsolete.
2328         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2329         Update target triplet.
2330
2331 2019-11-01  Tom Tromey  <tromey@adacore.com>
2332
2333         * utils.c (print_sys_errmsg): Simplify.
2334
2335 2019-11-01  Tom Tromey  <tromey@adacore.com>
2336
2337         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2338
2339 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2340
2341         * configure: Regenerate.
2342         * configure.ac: Remove check for strerror_r.
2343         * gdbsupport/common.m4: Check for strerror_r.
2344
2345 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2346
2347         PR gdb/25124
2348
2349         * arm-tdep.c (arm_per_objfile): Rename to ...
2350         (arm_per_bfd): ... this.
2351         (arm_objfile_data_key): Rename to ...
2352         (arm_bfd_data_key): ... this.
2353         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2354         data.
2355         (arm_record_special_symbol): Likewise.
2356
2357 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2358
2359         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2360         end.
2361         * c-typeprint.c (c_print_typedef): Likewise.
2362         * f-typeprint.c (f_print_typedef): Likewise.
2363         * m2-typeprint.c (m2_print_typedef): Likewise.
2364         * p-typeprint.c (pascal_print_typedef): Likewise.
2365         * rust-lang.c (rust_print_typedef): Likewise.
2366         * symtab.c (print_symbol_info): Print a newline after calling
2367         typedef_print.
2368
2369 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * symtab.c (info_module_cmdlist): New variable.
2372         (info_module_command): New function.
2373         (search_module_symbols): New function.
2374         (info_module_subcommand): New function.
2375         (struct info_modules_var_func_options): New struct.
2376         (info_modules_var_func_options_defs): New variable.
2377         (make_info_modules_var_func_options_def_group): New function.
2378         (info_module_functions_command): New function.
2379         (info_module_variables_command): New function.
2380         (info_module_var_func_command_completer): New function.
2381         (_initialize_symtab): Register new 'info module functions' and
2382         'info module variables' commands.
2383         * symtab.h (typedef symbol_search_in_module): New typedef.
2384         (search_module_symbols): Declare new function.
2385         * NEWS: Mention new commands.
2386
2387 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2390         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2391         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2392         MODULES_DOMAIN.
2393         (scan_partial_symbols): Only create partial module symbols for non
2394         declarations.
2395         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2396         and MODULES_DOMAIN.
2397         * symtab.c (search_domain_name): Likewise.
2398         (search_symbols): Likewise.
2399         (print_symbol_info): Likewise.
2400         (symtab_symbol_info): Likewise.
2401         (info_modules_command): New function.
2402         (_initialize_symtab): Register 'info modules' command.
2403         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2404         * NEWS: Mention new 'info modules' command.
2405
2406 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2407
2408         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2409         and $_gdb_maint_setting_str.
2410
2411 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2412
2413         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2414         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2415         (str_value_from_setting, gdb_setting_str_internal_fn)
2416         (gdb_maint_setting_str_internal_fn): New functions.
2417         (_initialize_cli_cmds): Define the new convenience functions.
2418         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2419         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2420
2421 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2422
2423         * agent.c (set_can_use_agent): When the setting is turned on,
2424         look up agent symbols if we don't have them yet.
2425         (agent_new_objfile): Don't look up agent symbols when the agent
2426         setting is off.
2427
2428 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * config.in: Regenerate.
2431
2432 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2433
2434         * configure: Regenerate.
2435         * configure.ac: Check for strerror_r.
2436         * gdbsupport/common-utils.h (safe_strerror): Change return value
2437         to const char * and document that this function is now threadsafe.
2438         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2439         thread_local and call strerror_r, if available.
2440         * utils.c (perror_string): Update.
2441         (print_sys_errmsg): Update.
2442
2443 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2444
2445         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2446         objfile_key.
2447         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2448         objfile to fetch per-bfd data.
2449         (arm_find_exidx_entry): Likewise.
2450
2451 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2452
2453         * gdbsupport/agent.c (debug_agent): Change type to bool.
2454         (use_agent): Likewise.
2455         (all_agent_symbols_look_up): Likewise.
2456         (agent_loaded_p): Change return value to bool.
2457         (agent_look_up_symbols): Update.
2458         (agent_capability_check): Change return value to bool.
2459         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2460         (debug_agent): Change type to bool.
2461         (use_agent): Likewise.
2462         (agent_capability_check): Change return value to bool.
2463
2464 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2465
2466         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2467         (build_minimal_symbol_hash_tables): Code to clear the table moved
2468         to clear_minimal_symbol_hash_tables.
2469         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2470         when needed.
2471
2472 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2473
2474         * infcmd.c: Remove includes.
2475         * infrun.c: Remove includes.
2476
2477 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2478
2479         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2480         (grow_vect): Remove declaration.
2481         (ada_type_of_array): Remove declaration.
2482         (ada_update_initial_language): Remove declaration.
2483         (ada_fold_name): Remove declaration.
2484         (ada_fill_in_ada_prototype): Remove declaration.
2485         (user_select_syms): Remove declaration.
2486         (get_selections): Remove declaration.
2487         (ada_tag_type): Remove declaration.
2488         (ada_value_tag): Remove declaration.
2489         (ada_is_others_clause): Remove declaration.
2490         (ada_in_variant): Remove declaration.
2491         (ada_value_struct_elt): Remove declaration.
2492         (ada_attribute_name): Remove declaration.
2493         (ada_system_address_type): Remove declaration.
2494         * ada-lang.c (ada_watch_location_expression): Make static.
2495         (GROW_VECT): Move here from ada-lang.h.
2496         (grow_vect): Make static.
2497         (ada_update_initial_language): Make static.
2498         (ada_fold_name): Make static.
2499         (ada_type_of_array): Make static.
2500         (encoded_ordered_before): Move up.
2501         (sort_choices): Move up.
2502         (print_signatures): Move up.
2503         (ada_print_symbol_signature): Move up.
2504         (get_selections): Move up and make static.
2505         (user_select_syms): Move up and make static.
2506         (ada_value_struct_elt): Move up and make static.
2507         (ada_tag_type): Make static.
2508         (ada_value_tag): Make static.
2509         (ada_is_others_clause): Make static.
2510         (ada_in_variant): Make static.
2511         (ada_attribute_name): Make static.
2512
2513 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2514
2515         * ada-lang.c: Remove includes.
2516         * ada-typeprint.c: Remove includes.
2517         * ada-valprint.c: Remove includes.
2518
2519 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2520
2521         * addrmap.c: Add static assertions of type size, moved from
2522         _initialize_addrmap.
2523         (_initialize_addrmap): Remove.
2524
2525 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2526
2527         * coffread.c (record_minimal_symbol): Update.
2528         (process_coff_symbol): Update.
2529         * dbxread.c (read_dbx_symtab): Update.
2530         * dwarf2read.c (add_partial_symbol): Update.
2531         (fixup_go_packaging): Update.
2532         (load_partial_dies): Update.
2533         (new_symbol): Update.
2534         * elfread.c (record_minimal_symbol): Change signature to use
2535         gdb::string_view instead of name+len.
2536         (elf_symtab_read): Update.
2537         (elf_rel_plt_read): Update.
2538         * mdebugread.c (parse_partial_symbols): Update.
2539         (handle_psymbol_enumerators): Update.
2540         (new_symbol): Update.
2541         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2542         to use gdb::string_view instead of name+len.
2543         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2544         * psympriv.h (add_psymbol_to_list): Likewise.
2545         * psymtab.c (add_psymbol_to_bcache): Likewise.
2546         (add_psymbol_to_list): Likewise.
2547         * stabsread.c (define_symbol): Update.
2548         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2549         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2550         (symbol_set_names): Likewise.
2551         * xcoffread.c (scan_xcoff_symtab): Update.
2552
2553 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2554
2555         * symtab.h (symbol_set_names): Document that copy_name must be
2556         set to true for non-nullterminated strings.
2557         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2558         linkage_name if the entry was not found and we need to demangle.
2559
2560 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2561
2562         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2563         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2564         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2565         * gdbsupport/gdb_binary_search.h: New file.
2566
2567 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2568
2569         * NEWS: Mention new --with-system-gdbinit-dir option.
2570         * config.in: Regenerate.
2571         * configure: Regenerate.
2572         * configure.ac: Add new option --with-system-gdbinit-dir.
2573         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2574         for a ".gdb" suffix.
2575         * main.c (get_init_files): Change system_gdbinit argument to
2576         a vector and return the files in SYSTEM_GDBINIT_DIR in
2577         addition to SYSTEM_GDBINIT.
2578         (captured_main_1): Update.
2579         (print_gdb_help): Update.
2580         * top.c (print_gdb_configuration): Also print the value of
2581         SYSTEM_GDBINIT_DIR.
2582
2583 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2584
2585         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2586         that takes gdb::string_view arguments.
2587
2588 2019-10-26  Tom de Vries  <tdevries@suse.de>
2589
2590         * aarch64-linux-tdep.c: Fix typos in comments.
2591         * aarch64-tdep.c: Same.
2592         * ada-lang.c: Same.
2593         * amd64-nat.c: Same.
2594         * arc-tdep.c: Same.
2595         * arch/aarch64-insn.c: Same.
2596         * block.c: Same.
2597         * breakpoint.h: Same.
2598         * btrace.h: Same.
2599         * c-varobj.c: Same.
2600         * cli/cli-decode.c: Same.
2601         * cli/cli-script.c: Same.
2602         * cli/cli-utils.h: Same.
2603         * coff-pe-read.c: Same.
2604         * coffread.c: Same.
2605         * compile/compile-cplus-symbols.c: Same.
2606         * compile/compile-object-run.c: Same.
2607         * completer.c: Same.
2608         * corelow.c: Same.
2609         * cp-support.c: Same.
2610         * demangle.c: Same.
2611         * dwarf-index-write.c: Same.
2612         * dwarf2-frame.c: Same.
2613         * dwarf2-frame.h: Same.
2614         * eval.c: Same.
2615         * frame-base.h: Same.
2616         * frame.h: Same.
2617         * gdbcmd.h: Same.
2618         * gdbtypes.h: Same.
2619         * gnu-nat.c: Same.
2620         * guile/scm-objfile.c: Same.
2621         * i386-tdep.c: Same.
2622         * i386-tdep.h: Same.
2623         * infcall.c: Same.
2624         * infcall.h: Same.
2625         * linux-nat.c: Same.
2626         * m68k-tdep.c: Same.
2627         * macroexp.c: Same.
2628         * memattr.c: Same.
2629         * mi/mi-cmd-disas.c: Same.
2630         * mi/mi-getopt.h: Same.
2631         * mi/mi-main.c: Same.
2632         * minsyms.c: Same.
2633         * nat/aarch64-sve-linux-sigcontext.h: Same.
2634         * objfiles.h: Same.
2635         * ppc-linux-nat.c: Same.
2636         * ppc-linux-tdep.c: Same.
2637         * ppc-tdep.h: Same.
2638         * progspace.h: Same.
2639         * prologue-value.h: Same.
2640         * python/py-evtregistry.c: Same.
2641         * python/py-instruction.h: Same.
2642         * record-btrace.c: Same.
2643         * record-full.c: Same.
2644         * remote.c: Same.
2645         * rs6000-tdep.c: Same.
2646         * ser-tcp.c: Same.
2647         * sol-thread.c: Same.
2648         * sparc-sol2-tdep.c: Same.
2649         * sparc64-tdep.c: Same.
2650         * stabsread.c: Same.
2651         * symfile.c: Same.
2652         * symtab.h: Same.
2653         * target.c: Same.
2654         * tracepoint.c: Same.
2655         * tui/tui-data.h: Same.
2656         * tui/tui-io.c: Same.
2657         * tui/tui-win.c: Same.
2658         * tui/tui.c: Same.
2659         * unittests/rsp-low-selftests.c: Same.
2660         * user-regs.h: Same.
2661         * utils.c: Same.
2662         * utils.h: Same.
2663         * valarith.c: Same.
2664         * valops.c: Same.
2665         * valprint.c: Same.
2666         * valprint.h: Same.
2667         * value.c: Same.
2668         * value.h: Same.
2669         * varobj.c: Same.
2670         * x86-nat.h: Same.
2671         * xtensa-tdep.c: Same.
2672
2673 2019-10-25  Ali Tamur <tamur@google.com>
2674
2675         * charset.c (find_charset_names): Reflect API change.
2676
2677 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2678
2679         * symtab.c (struct demangled_name_entry): Change demangled name
2680         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2681         part of the struct anymore.
2682         (symbol_set_names): No longer obstack allocate + copy the demangled
2683         name, just store the allocated name from bfd.
2684
2685 2019-10-25  Tom Tromey  <tromey@adacore.com>
2686
2687         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2688         (bsearch_cie_cmp, add_cie): Remove.
2689         (find_cie): Reimplement.
2690         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2691         (dwarf2_build_frame_info): Update.
2692
2693 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2694
2695         PR gdb/25126
2696         * symfile.c (reread_symbols): Call forget_cached_source_info to
2697         clear the stale source cache.
2698
2699 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2700
2701         * configure: Regenerate.
2702         * configure.ac: Remove code that sets python_has_threads.
2703
2704 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2705
2706         * config.in: Regenerate.
2707         * configure: Regenerate.
2708         * configure.ac: Remove the code that uses sed to get the python
2709         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2710
2711 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2712
2713         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2714         error paths.
2715
2716 2019-10-23  Tom Tromey  <tom@tromey.com>
2717
2718         * arc-tdep.c: Remove ".." from include.
2719         * frv-tdep.c: Remove ".." from include.
2720         * lm32-tdep.c: Remove ".." from include.
2721         * microblaze-tdep.c: Remove ".." from include.
2722         * or1k-tdep.h: Remove ".." from include.
2723         * s12z-tdep.c: Remove ".." from include.
2724         * Makefile.in (OPCODES_CFLAGS): Add comment.
2725         (TOP_CFLAGS): New variable.
2726         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2727
2728 2019-10-23  Tom Tromey  <tom@tromey.com>
2729
2730         * Makefile.in (READLINE_DIR): Update.
2731
2732 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2733
2734         * infcall.c (call_function_by_hand_dummy): Fix the function
2735         comment.  And extract out a code section into...
2736         (reserve_stack_space): ...this new function.
2737
2738 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2739
2740         * infcall.c (value_arg_coerce): Remove an unused parameter.
2741         (call_function_by_hand_dummy): Update the call to
2742         'value_arg_coerce'.
2743
2744 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2745
2746         * infcall.c (call_function_by_hand_dummy): Refactor.
2747
2748 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2749
2750         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2751
2752 2019-10-23  Tom Tromey  <tom@tromey.com>
2753
2754         * configure: Rebuild.
2755         * configure.ac: Don't check for sigprocmask.
2756         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2757
2758 2019-10-23  Tom Tromey  <tom@tromey.com>
2759
2760         * configure: Rebuild.
2761         * acinclude.m4: Use m4_include, not sinclude.
2762
2763 2019-10-23  Tom de Vries  <tdevries@suse.de>
2764
2765         PR breakpoints/24687
2766         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2767
2768 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2769
2770         * symtab.c (struct demangled_name_entry) <language>: Change from
2771         bitfield to regular variable.
2772
2773 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2774
2775         * symtab.c (struct demangled_name_entry): Add a constructor.
2776         (free_demangled_name_entry): New function to call the destructor
2777         for demangled_name_entry.
2778         (create_demangled_names_hash): Pass free_demangled_name_entry to
2779         htab_create_alloc.
2780         (symbol_set_names): Call placement new for demangled_name_entry.
2781         * utils.c: No longer include xxhash.h here, now that fast_hash
2782         is inlined in the header.
2783         * utils.h: Instead, include it here.
2784
2785 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2786
2787         * Makefile.in: Link with libxxhash.
2788         * config.in: Regenerate.
2789         * configure: Regenerate.
2790         * configure.ac: Search for libxxhash.
2791         * utils.c (fast_hash): Use xxhash if present.
2792
2793 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2794
2795         * utils.h (fast_hash): New function.
2796         * symtab.c (hash_demangled_name_entry): Call new function
2797         fast_hash.
2798
2799 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2800
2801         * symtab.c (struct demangled_name_entry): Change type of mangled
2802         to gdb::string_view. Also adds a constructor that takes the
2803         mangled name.
2804         (hash_demangled_name_entry): Update.
2805         (eq_demangled_name_entry): Update.
2806         (free_demangled_name_entry): New function to call the destructor
2807         now that this is not a POD anymore.
2808         (create_demangled_names_hash): Pass free_demangled_name_entry to
2809         htab_create_alloc.
2810         (symbol_set_names): Update.
2811
2812 2019-10-21  Ali Tamur  <tamu@google.com>
2813
2814         * dwarf2read.c (dir_index): Change type.
2815         (file_name_index): Likewise.
2816         (line_header::include_dir_at): Change comment and implementation on
2817         whether it is DWARF 5.
2818         (line_header::is_valid_file_index): New function.
2819         (line_header::file_name_at): Change comment and implementation on
2820         whether it is DWARF 5.
2821         (line_header::file_names): Change to private field renamed as
2822         m_file_names and introduce a new accessor method.
2823         (line_header::file_names_size): New method.
2824         (line_header::include_dirs): Change to private field and rename as
2825         m_include_dirs.
2826         (dw2_get_file_names_reader): Define local var at a smaller scope and
2827         reflect API change.
2828         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2829         (process_structure_scope): Likewise.
2830         (line_header::add_include_dir): Change message and reflect renaming.
2831         (line_header::add_file_name): Likewise.
2832         (read_formatted_entries): Handle DW_FORM_data16.
2833         (dwarf_decode_line_header): Fix line header length calculation.
2834         (psymtab_include_file_name): Change comment and API.
2835         (lnp_state_machine::m_file): Update comment and reflect type change.
2836         (lnp_state_machine::record_line): Reflect type change.
2837         (dwarf_decode_lines): Reflect API change.
2838         (file_file_name): Likewise.
2839         (file_full_name): Likewise.
2840
2841 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2844
2845 2019-10-21  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2848
2849 2019-10-21  Tom Tromey  <tom@tromey.com>
2850
2851         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2852         NM_H.   Use AC_CONFIG_LINKS.
2853         * configure: Rebuild.
2854         * Makefile.in (NM_H): New variable.
2855         (generated_files): Add NM_H.  Remove gcore.
2856         (nm.h, stamp-nmh): New targets.
2857
2858 2019-10-20  Tom Tromey  <tom@tromey.com>
2859
2860         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2861         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2862         obsolete comment.
2863         (put_objfile_before): Now static.
2864
2865 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2866
2867         * gdbsupport/common-utils.h (startswith): Change return type to
2868         bool.
2869
2870 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2871
2872         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2873         * breakpoint.c (bp_locations_compare): Rename to...
2874         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2875         (update_global_location_list): Use std::sort instead of qsort.
2876         * buildsym.c (compare_line_numbers): Rename to...
2877         (lte_is_less_than): ...this, and change to std::sort semantics.
2878         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2879         instead of qsort.
2880         * disasm.c (compare_lines): Rename to...
2881         (line_is_less_than): ...this, and change to std::sort semantics.
2882         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2883         of qsort.
2884         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2885         (fde_is_less_than): ...this, and change to std::sort semantics.
2886         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2887         * mdebugread.c (compare_blocks):
2888         (block_is_less_than): ...this, and change to std::sort semantics.
2889         (sort_blocks): Call std::sort instead of qsort.
2890         * objfiles.c (qsort_cmp): Rename to...
2891         (sort_cmp): ...this, and change to std::sort semantics.
2892         (update_section_map): Call std::sort instead of qsort.
2893         * remote.c (compare_pnums): Remove.
2894         (map_regcache_remote_table): Call std::sort instead of qsort.
2895         * utils.c (compare_positive_ints): Remove.
2896         * utils.h (compare_positive_ints): Remove.
2897         * xcoffread.c (compare_lte): Remove.
2898         (arrange_linetable): Call std::sort instead of qsort.
2899
2900 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2901
2902         * symfile.c (init_entry_point_info): Fix typo.
2903         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2904
2905 2019-10-18  Tom de Vries  <tdevries@suse.de>
2906
2907         * aarch64-tdep.c: Fix typos in comments.
2908         * ada-lang.c: Same.
2909         * ada-tasks.c: Same.
2910         * alpha-tdep.c: Same.
2911         * alpha-tdep.h: Same.
2912         * amd64-nat.c: Same.
2913         * amd64-windows-tdep.c: Same.
2914         * arc-tdep.c: Same.
2915         * arc-tdep.h: Same.
2916         * arch-utils.c: Same.
2917         * arm-nbsd-tdep.c: Same.
2918         * arm-tdep.c: Same.
2919         * ax-gdb.c: Same.
2920         * blockframe.c: Same.
2921         * btrace.c: Same.
2922         * c-varobj.c: Same.
2923         * coff-pe-read.c: Same.
2924         * coffread.c: Same.
2925         * cris-tdep.c: Same.
2926         * darwin-nat.c: Same.
2927         * dbxread.c: Same.
2928         * dcache.c: Same.
2929         * disasm.c: Same.
2930         * dtrace-probe.c: Same.
2931         * dwarf-index-write.c: Same.
2932         * dwarf2-frame-tailcall.c: Same.
2933         * dwarf2-frame.c: Same.
2934         * dwarf2read.c: Same.
2935         * eval.c: Same.
2936         * exceptions.c: Same.
2937         * fbsd-tdep.c: Same.
2938         * findvar.c: Same.
2939         * frame.c: Same.
2940         * frv-tdep.c: Same.
2941         * gnu-v3-abi.c: Same.
2942         * go32-nat.c: Same.
2943         * h8300-tdep.c: Same.
2944         * hppa-tdep.c: Same.
2945         * i386-linux-tdep.c: Same.
2946         * i386-tdep.c: Same.
2947         * ia64-libunwind-tdep.c: Same.
2948         * ia64-tdep.c: Same.
2949         * infcmd.c: Same.
2950         * infrun.c: Same.
2951         * linespec.c: Same.
2952         * linux-nat.c: Same.
2953         * linux-thread-db.c: Same.
2954         * machoread.c: Same.
2955         * mdebugread.c: Same.
2956         * mep-tdep.c: Same.
2957         * mn10300-tdep.c: Same.
2958         * namespace.c: Same.
2959         * objfiles.c: Same.
2960         * opencl-lang.c: Same.
2961         * or1k-tdep.c: Same.
2962         * osabi.c: Same.
2963         * ppc-linux-nat.c: Same.
2964         * ppc-linux-tdep.c: Same.
2965         * ppc-sysv-tdep.c: Same.
2966         * printcmd.c: Same.
2967         * procfs.c: Same.
2968         * record-btrace.c: Same.
2969         * record-full.c: Same.
2970         * remote-fileio.c: Same.
2971         * remote.c: Same.
2972         * rs6000-tdep.c: Same.
2973         * s12z-tdep.c: Same.
2974         * score-tdep.c: Same.
2975         * ser-base.c: Same.
2976         * ser-go32.c: Same.
2977         * skip.c: Same.
2978         * sol-thread.c: Same.
2979         * solib-svr4.c: Same.
2980         * solib.c: Same.
2981         * source.c: Same.
2982         * sparc-nat.c: Same.
2983         * sparc-sol2-tdep.c: Same.
2984         * sparc-tdep.c: Same.
2985         * sparc64-tdep.c: Same.
2986         * stabsread.c: Same.
2987         * stack.c: Same.
2988         * symfile.c: Same.
2989         * symtab.c: Same.
2990         * target-descriptions.c: Same.
2991         * target-float.c: Same.
2992         * thread.c: Same.
2993         * utils.c: Same.
2994         * valops.c: Same.
2995         * valprint.c: Same.
2996         * value.c: Same.
2997         * varobj.c: Same.
2998         * windows-nat.c: Same.
2999         * xcoffread.c: Same.
3000         * xstormy16-tdep.c: Same.
3001         * xtensa-tdep.c: Same.
3002
3003 2019-10-17  Tom Tromey  <tromey@adacore.com>
3004
3005         * configure: Rebuild.
3006         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3007         in AC_CONFIG_FILES invocation.
3008         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3009         new-style config.status invocation.
3010
3011 2019-10-17  Tom de Vries  <tdevries@suse.de>
3012
3013         * arm-nbsd-nat.c: Fix typos in comments.
3014         * arm-tdep.c: Same.
3015         * darwin-nat-info.c: Same.
3016         * dwarf2read.c: Same.
3017         * elfread.c: Same.
3018         * event-top.c: Same.
3019         * findvar.c: Same.
3020         * gdbtypes.c: Same.
3021         * hppa-tdep.c: Same.
3022         * i386-tdep.c: Same.
3023         * jit.c: Same.
3024         * main.c: Same.
3025         * mdebugread.c: Same.
3026         * moxie-tdep.c: Same.
3027         * nto-procfs.c: Same.
3028         * osabi.c: Same.
3029         * ppc-linux-tdep.c: Same.
3030         * remote.c: Same.
3031         * riscv-tdep.c: Same.
3032         * s390-tdep.c: Same.
3033         * sh-tdep.c: Same.
3034         * sparc-linux-tdep.c: Same.
3035         * sparc-nat.c: Same.
3036         * stack.c: Same.
3037         * target-descriptions.c: Same.
3038         * top.c: Same.
3039         * varobj.c: Same.
3040
3041 2019-10-16  Tom Tromey  <tom@tromey.com>
3042
3043         * objfiles.h (struct objfile) <original_name>: Now const.
3044
3045 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3046
3047         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3048         pass on to sigsetjmp's second argument.
3049         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3050
3051 2019-10-16  Keith Seitz  <keiths@redhat.com>
3052
3053         PR gdb/23567
3054         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3055         sections whose size is greater than the file size.
3056
3057 2019-10-16  Jim Wilson  <jimw@sifive.com>
3058
3059         * riscv-tdep.c (riscv_gcc_target_options): New.
3060         (riscv_gnu_triplet_regexp): New.
3061         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3062         set_gdbarch_gnu_triplet_regexp.
3063
3064 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3065
3066         * Makefile.in: Add xml-builtin.h.
3067         * features/feature_to_c.sh: Add an include for xml-builtin.h
3068         to ensure that the compiler checks that the types match.
3069         * xml-builtin.h: New file.
3070         * xml-support.c (fetch_xml_builtin): Add missing const.
3071         * xml-support.h: Remove declaration of xml_builtins.
3072
3073 2019-10-16  Tom de Vries  <tdevries@suse.de>
3074
3075         PR tdep/25096
3076         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3077         (amd64_classify_aggregate): ... here.
3078         (amd64_classify_aggregate_field): Handled fiels of nested structs
3079         recursively.
3080
3081 2019-10-16  Tom de Vries  <tdevries@suse.de>
3082
3083         PR tdep/24104
3084         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3085         that handles 'theclass'.
3086
3087 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * linespec.c (decode_digits_ordinary): Update comment.
3090         * make-target-delegates: No longer need to handle VEC case.
3091         * memrange.c (normalize_mem_ranges): Update comment.
3092         * namespace.c (add_using_directive): Update comment.
3093         * objc-lang.c (uniquify_strings): Update comment.
3094         * ppc-linux-nat.c (struct thread_points): Update comment.
3095         * probe.h (find_probes_in_objfile): Update comment.
3096         * target.h (enum flash_preserve_mode): Update comment.
3097         * varobj.c (varobj_restrict_range): Update comment.
3098         * varobj.h (varobj_list_children): Update comment.
3099
3100 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * Makefile.in: Remove references to vec.h and vec.c.
3103         * aarch64-tdep.c: No longer include vec.h.
3104         * ada-lang.c: Likewise.
3105         * ada-lang.h: Likewise.
3106         * arm-tdep.c: Likewise.
3107         * ax.h: Likewise.
3108         * breakpoint.h: Likewise.
3109         * charset.c: Likewise.
3110         * cp-support.h: Likewise.
3111         * dtrace-probe.c: Likewise.
3112         * dwarf2read.c: Likewise.
3113         * extension.h: Likewise.
3114         * gdb_bfd.c: Likewise.
3115         * gdbsupport/gdb_vecs.h: Likewise.
3116         * gdbsupport/vec.c: Remove.
3117         * gdbsupport/vec.h: Remove.
3118         * gdbthread.h: Likewise.
3119         * guile/scm-type.c: Likewise.
3120         * inline-frame.c: Likewise.
3121         * machoread.c: Likewise.
3122         * memattr.c: Likewise.
3123         * memrange.h: Likewise.
3124         * namespace.h: Likewise.
3125         * nat/linux-btrace.h: Likewise.
3126         * osdata.c: Likewise.
3127         * parser-defs.h: Likewise.
3128         * progspace.h: Likewise.
3129         * python/py-type.c: Likewise.
3130         * record-btrace.c: Likewise.
3131         * rust-exp.y: Likewise.
3132         * solib-target.c: Likewise.
3133         * stap-probe.c: Likewise.
3134         * target-descriptions.c: Likewise.
3135         * target-memory.c: Likewise.
3136         * target.h: Likewise.
3137         * varobj.c: Likewise.
3138         * varobj.h: Likewise.
3139         * xml-support.h: Likewise.
3140
3141 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3142
3143         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3144         Update for new std::vector based implementation.
3145         (process_psymtab_comp_unit_reader): Likewise.
3146         (scan_partial_symbols): Likewise.
3147         (recursively_compute_inclusions): Likewise.
3148         (compute_compunit_symtab_includes): Likewise.
3149         (process_imported_unit_die): Likewise.
3150         (queue_and_load_dwo_tu): Likewise.
3151         (follow_die_sig_1): Likewise.
3152         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3153         (typedef dwarf2_per_cu_ptr): Remove.
3154         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3155         function.
3156         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3157         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3158         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3159         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3160         std::vector.
3161
3162 2019-10-15  Tom Tromey  <tromey@adacore.com>
3163
3164         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3165         TID.
3166
3167 2019-10-15  Tom Tromey  <tromey@adacore.com>
3168
3169         * windows-nat.c (windows_nat_target::fetch_registers)
3170         (windows_nat_target::store_registers): Rename "pid" to "tid".
3171
3172 2019-10-15  Tom Tromey  <tromey@adacore.com>
3173
3174         * gdbarch.h, gdbarch.c: Rebuild.
3175         * gdbarch.sh (gcc_target_options): Change return type to
3176         std::string.
3177         * compile/compile.c (get_args): Update.
3178         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3179         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3180         std::string.
3181         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3182         std::string.
3183         * arch-utils.c (default_gcc_target_options): Return std::string.
3184         * arch-utils.h (default_gcc_target_options): Return std::string.
3185         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3186
3187 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3188
3189         * breakpoint.c (breakpoint_chain): Make static.
3190         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3191         of accessing breakpoint_chain.
3192
3193 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3194
3195         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3196         to a gdb::function_view and return value to bool.
3197         * breakpoint.h (iterate_over_breakpoints): Likewise.
3198         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3199         (pop_dummy_frame): Update.
3200         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3201         (gdbscm_breakpoints): Update.
3202         * python/py-breakpoint.c (build_bp_list): Update.
3203         (gdbpy_breakpoints): Update.
3204         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3205         Update.
3206         (bpfinishpy_handle_stop): Update.
3207         (bpfinishpy_handle_exit): Update.
3208         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3209         (svr4_update_solib_event_breakpoints): Update.
3210
3211 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3212
3213         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3214         when unwrapping single-field structs.
3215
3216 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3217
3218         * dwarf2read.c: Remove includes.
3219
3220 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3221
3222         * ui-out.c (ui_out::call_do_message): Silence
3223         -Wformat-nonliteral warning.
3224
3225 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3226
3227         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3228         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3229         include: readline/tilde.h.
3230
3231 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3232
3233         * remote.c (remote_target::get_trace_status): Remove declaration of
3234         trace_regblock_size.
3235
3236 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3237
3238         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3239         (show_user): Remove declaration of cmdlist.
3240         * cli/cli-cmds.h (max_user_call_depth): Declare.
3241         * cli/cli-script.c (execute_user_command): Remove declaration
3242         of max_user_call_depth.
3243
3244 2019-10-11  Jim Wilson  <jimw@sifive.com>
3245
3246         * gdbsupport/print-utils.h (pulongest): Fix comment.
3247         (plongest): Likewise.
3248         (phex): Add missing comment, mention leading zeros.
3249         (phex_nz): Add mention of no leading zeros to comment.
3250
3251         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3252         plongest instead of unsigned long long cast.
3253
3254 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3255
3256         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3257         for external_editor_command and gdbtk_test.
3258
3259 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3260
3261         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3262         * varobj.c (varobjdebug): Move comment to...
3263         * varobj.h (varobjdebug): ...here, and declare.
3264
3265 2019-10-09  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3268         erase_data_content.
3269
3270 2019-10-09  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3273         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3274         * tui/tui-command.c (tui_cmd_window::resize)
3275         (tui_refresh_cmd_win): Update.
3276         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3277         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3278         * tui/tui-data.c (~tui_gen_win_info): Remove.
3279         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3280         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3281         (tui_redisplay_readline, tui_mld_flush)
3282         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3283         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3284         (tui_data_window::erase_data_content)
3285         (tui_data_item_window::rerender)
3286         (tui_data_item_window::refresh_window): Update.
3287         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3288         (box_win, tui_gen_win_info::make_window)
3289         (tui_gen_win_info::make_visible): Update.
3290         (tui_delete_win): Remove.
3291         * tui/tui-winsource.c
3292         (tui_source_window_base::do_erase_source_content): Update.
3293         (tui_show_source_line, tui_source_window_base::update_tab_width)
3294         (tui_source_window_base::update_exec_info): Update.
3295         * tui/tui-data.h (struct curses_deleter): New.
3296         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3297         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3298
3299 2019-10-09  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3302
3303 2019-10-09  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3306         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3307
3308 2019-10-09  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3311         window height directly.
3312         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3313         declare.
3314         * tui/tui-layout.c (tui_default_win_height): Remove.
3315         (tui_default_win_viewport_height): Remove.
3316
3317 2019-10-09  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui.h: Remove comments.
3320
3321 2019-10-09  Tom de Vries  <tdevries@suse.de>
3322
3323         * python/lib/gdb/printer/bound_registers.py: Use
3324         '^builtin_type_bound128' as regexp argument for
3325         add_builtin_pretty_printer.
3326
3327 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3328
3329         * guile/guile.c (guile_extension_script_ops): Remove forward
3330         declaration and mark as static.
3331         (guile_script_ops): Likewise.
3332         (extension_language_guile): Move further down in the file so
3333         it can reference the definitions for guile_{extension_,}script_ops.
3334
3335 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3336
3337         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3338         except SORTL, DFLTCC, and KDSA.
3339
3340 2019-10-08  Tom Tromey  <tromey@adacore.com>
3341
3342         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3343         (struct safe_symbol_file_add_args): Remove.
3344
3345 2019-10-08  Tom Tromey  <tromey@adacore.com>
3346
3347         * windows-nat.c: Don't include buildsym-legacy.h.
3348
3349 2019-10-08  Tom Tromey  <tromey@adacore.com>
3350
3351         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3352
3353 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3354
3355         * gdbtypes.c (overload_debug): Move comment to header.
3356         * gdbtypes.h (overload_debug): Declare.
3357         * valops.c: Remove declaration of overload_debug, instead
3358         include gdbtypes.h.
3359
3360 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3361
3362         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3363         through _().
3364         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3365         move comment...
3366         * language.h (lang_frame_mismatch_warn): ... here. Also add
3367         declaration.
3368         * top.c (lang_frame_mismatch_warn): Remove declaration.
3369         (check_frame_language_change): Pass lang_frame_mismatch_warn
3370         through _().
3371
3372 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3373
3374         * c-lang.h (vtbl_ptr_name): Declare.
3375         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3376         it from the header.
3377         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3378
3379 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3380
3381         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3382         gdb_static_assert.
3383
3384 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3385
3386         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3387         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3388         * ctfread.c: New file.
3389         * ctfread.h: New file.
3390         * elfread.c: Include ctfread.h.
3391         (struct elfinfo text_p): New member ctfsect.
3392         (elf_locate_sections): Mark CTF section.
3393         (elf_symfile_read): Call elfctf_build_psymtabs.
3394         * Makefile.in (LIBCTF): Add.
3395         (CLIBS): Use it.
3396         (CDEPS): Likewise.
3397         (DIST): Add ctfread.c.
3398
3399 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * ctfread.c (struct nextfield): Renamed to ...
3402         (struct ctf_nextfield): ... this.
3403         (struct field_info): Renamed to ...
3404         (strut ctf_field_info): ... this.
3405         (attach_fields_to_type): Update for renamed structures.
3406         (ctf_add_member_cb): Likewise.
3407         (ctf_add_enum_member_cb): Likewise.
3408         (process_struct_members): Likewise.
3409         (process_enum_type): Likewise.
3410
3411 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3412
3413         * tracectf.h: Rename, was ctf.h.
3414         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3415         * tracefile.c: Likewise.
3416         * tracepoint.c: Remove unused include ctf.h.
3417         * mi/mi-main.c: Likewise.
3418         * Makefile.in Replace ctf.c with tracectf.c.
3419
3420 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3421
3422         * version.in: Change version number to "9.0.50.DATE-git".
3423
3424 2019-10-03  Tom Tromey  <tom@tromey.com>
3425
3426         PR rust/24976:
3427         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3428
3429 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3432         cp_search_name_hash.
3433         * NEWS: Add entry about nested function support.
3434
3435 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3436             Andrew Burgess  <andrew.burgess@embecosm.com>
3437
3438         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3439         for nested static variables when searchin VAR_DOMAIN.
3440         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3441         global scope, update comment.
3442         (add_partial_subprogram): Call add_partial_subprogram recursively
3443         for nested subroutines when processinng Fortran.
3444         (load_partial_dies): Process the child entities of a subprogram
3445         when processing Fortran.
3446         (partial_die_parent_scope): Handle building scope
3447         for Fortran nested functions.
3448         (process_die): Record that nested functions have a scope.
3449         (new_symbol): Always record Fortran subprograms on the global
3450         symbol list.
3451         (determine_prefix): How to build the prefix for Fortran
3452         subprograms.
3453
3454 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3457         have just sent the thread a SIGSTOP and are waiting for it to
3458         arrive.
3459
3460 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * btrace.c (btrace_add_pc): Remove whitespace before the template
3463         parameter in 'std::vector <...>'.
3464         (parse_xml_btrace_block): Likewise.
3465         (btrace_maint_decode_pt): Likewise.
3466         (btrace_maint_update_packets): Likewise.
3467         (btrace_maint_print_packets): Likewise.
3468         * btrace.h (struct btrace_maint_info): Likewise.
3469         * dwarf2read.c (struct type_unit_group): Likewise.
3470         (build_type_psymtabs_reader): Likewise.
3471         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3472         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3473         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3474
3475 2019-10-03  Tom de Vries  <tdevries@suse.de>
3476
3477         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3478         the first line of the help text for set/show style metadata.
3479
3480 2019-10-02  Tom Tromey  <tromey@adacore.com>
3481
3482         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3483         * gdbsupport/common-inferior.c: New file.
3484         * infcmd.c (startup_with_shell): Don't define.
3485         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3486         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3487         * inferior.h (startup_with_shell): Don't declare.
3488
3489 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3490
3491         * gdbsupport/gdb_assert.h: Include errors.h.
3492         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3493
3494 2019-10-02  Tom Tromey  <tromey@adacore.com>
3495
3496         * NEWS: Add $_ada_exception entry.
3497         * ada-lang.c (struct ada_catchpoint): Add constructor.
3498         <m_kind>: New member.
3499         (allocate_location_exception, re_set_exception): Remove
3500         "ex" parameter.
3501         (should_stop_exception): Compute $_ada_exception.
3502         (check_status_exception, print_it_exception)
3503         (print_one_exception, print_mention_exception): Remove
3504         "ex" parameter.
3505         (allocate_location_catch_exception, re_set_catch_exception)
3506         (check_status_exception, print_it_catch_exception)
3507         (print_one_catch_exception, print_mention_catch_exception)
3508         (print_recreate_catch_exception)
3509         (allocate_location_catch_exception_unhandled)
3510         (re_set_catch_exception_unhandled)
3511         (check_status_exception, print_it_catch_exception_unhandled)
3512         (print_one_catch_exception_unhandled)
3513         (print_mention_catch_exception_unhandled)
3514         (print_recreate_catch_exception_unhandled)
3515         (allocate_location_catch_assert, re_set_catch_assert)
3516         (check_status_assert, print_it_catch_assert)
3517         (print_one_catch_assert, print_mention_catch_assert)
3518         (print_recreate_catch_assert)
3519         (allocate_location_catch_handlers, re_set_catch_handlers)
3520         (check_status_handlers, print_it_catch_handlers)
3521         (print_one_catch_handlers, print_mention_catch_handlers)
3522         (print_recreate_catch_handlers): Remove.
3523         (create_ada_exception_catchpoint): Update.
3524         (initialize_ada_catchpoint_ops): Update.
3525
3526 2019-10-02  Tom Tromey  <tromey@adacore.com>
3527
3528         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3529         (create_excep_cond_exprs): Simplify exception string computation.
3530         (ada_exception_catchpoint_cond_string): Likewise.
3531
3532 2019-10-02  Tom Tromey  <tromey@adacore.com>
3533
3534         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3535         * ada-lang.c (lesseq_defined_than): Handle
3536         LOC_STATIC.
3537         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3538         parameter.
3539         (dwarf2_has_info): Likewise.
3540         (new_symbol): Set maybe_copied on symbol when
3541         appropriate.
3542         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3543         parameter.
3544         <can_copy>: New member.
3545         * elfread.c (record_minimal_symbol): Set maybe_copied
3546         on symbol when appropriate.
3547         (elf_symfile_read): Update call to dwarf2_has_info.
3548         * minsyms.c (lookup_minimal_symbol_linkage): New
3549         function.
3550         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3551         * symtab.c (get_symbol_address, get_msymbol_address):
3552         New functions.
3553         * symtab.h (get_symbol_address, get_msymbol_address):
3554         Declare.
3555         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3556         maybe_copied.
3557         (struct symbol, struct minimal_symbol) <maybe_copied>:
3558         New member.
3559
3560 2019-10-02  Tom Tromey  <tromey@adacore.com>
3561
3562         * source.c (struct current_source_location): New.
3563         (current_source_key): New global.
3564         (current_source_symtab, current_source_line)
3565         (current_source_pspace): Remove.
3566         (get_source_location): New function.
3567         (get_current_source_symtab_and_line)
3568         (set_default_source_symtab_and_line)
3569         (set_current_source_symtab_and_line)
3570         (clear_current_source_symtab_and_line, select_source_symtab)
3571         (info_source_command, print_source_lines_base)
3572         (info_line_command, search_command_helper, _initialize_source):
3573         Update.
3574
3575 2019-10-02  Tom Tromey  <tromey@adacore.com>
3576
3577         * source.c (select_source_symtab): Don't call
3578         decode_line_with_current_source.
3579
3580 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3581
3582         * symtab.c (lookup_global_symbol): Search global block.
3583
3584 2019-10-02  Tom Tromey  <tromey@adacore.com>
3585
3586         * coffread.c (process_coff_symbol): Update.
3587         * dwarf2read.c (var_decode_location, new_symbol): Update.
3588         * mdebugread.c (parse_symbol): Update.
3589         * objfiles.c (relocate_one_symbol): Update.
3590         * stabsread.c (define_symbol, fix_common_block)
3591         (scan_file_globals): Update.
3592         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3593         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3594         * xcoffread.c (process_xcoff_symbol): Update.
3595
3596 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3597
3598         * MAINTAINERS: Update my email address.
3599
3600 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3601
3602         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3603         std::vector.
3604         (build_type_psymtabs_reader): Update for std::vector.
3605         (build_type_psymtab_dependencies): Likewise.
3606         * dwarf2read.h: Remove use of DEF_VEC_P.
3607         (typedef sig_type_ptr): Delete.
3608
3609 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3612         to std::vector.
3613         (btrace_maint_decode_pt): Likewise, and move allocation of the
3614         vector outside of the loop.
3615         (btrace_maint_update_packets): Update to handle change from VEC to
3616         std::vector.
3617         (btrace_maint_print_packets): Likewise.
3618         (maint_info_btrace_cmd): Likewise.
3619         * btrace.h: Remove use of DEF_VEC_O.
3620         (typedef btrace_pt_packet_s): Delete.
3621         (struct btrace_maint_info) <packets>: Change fromm VEC to
3622         std::vector.
3623         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3624
3625 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3626
3627         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3628         make accesses into the vector constant references.
3629         (btrace_add_pc): Update for std::vector.
3630         (btrace_stitch_bts): Likewise.
3631         (parse_xml_btrace_block): Likewise.
3632         (btrace_maint_update_packets): Likewise.
3633         (btrace_maint_print_packets): Likewise.
3634         (maint_info_btrace_cmd): Likewise.
3635         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3636         std::vector.
3637         (btrace_data::empty): Likewise.
3638         (btrace_data_append): Likewise.
3639         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3640         (typedef btrace_block_s): Delete.
3641         (struct btrace_block): Add constructor.
3642         (struct btrace_data_bts) <blocks>: Change to std::vector.
3643         * nat/linux-btrace.c (perf_event_read_bts): Update for
3644         std::vector.
3645         (linux_read_bts): Likewise.
3646
3647 2019-10-01  Tom Tromey  <tom@tromey.com>
3648
3649         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3650
3651 2019-10-01  Tom Tromey  <tom@tromey.com>
3652
3653         * stack.c (print_frame, info_frame_command_core): Use
3654         styled_string.
3655         * linux-thread-db.c (try_thread_db_load_1)
3656         (try_thread_db_load_from_pdir_1): Use styled_string.
3657         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3658         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3659         (maybe_print_unsupported_script_warning)
3660         (maybe_print_script_not_found_warning): Use styled_string.
3661         * ada-lang.c (user_select_syms): Use styled_string.
3662
3663 2019-10-01  Tom Tromey  <tom@tromey.com>
3664
3665         * p-lang.c (pascal_printstr): Use metadata style.
3666         * value.c (show_convenience): Use metadata style.
3667         * valprint.c (valprint_check_validity, val_print_optimized_out)
3668         (val_print_not_saved, val_print_unavailable)
3669         (val_print_invalid_address, generic_val_print, val_print)
3670         (value_check_printable, val_print_array_elements): Use metadata
3671         style.
3672         * ui-out.h (class ui_out) <field_fmt>: New overload.
3673         <do_field_fmt>: Add style parameter.
3674         * ui-out.c (ui_out::field_fmt): New overload.
3675         * typeprint.c (type_print_unknown_return_type)
3676         (val_print_not_allocated, val_print_not_associated): Use metadata
3677         style.
3678         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3679         parameter.
3680         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3681         * tracepoint.c (tvariables_info_1): Use metadata style.
3682         * stack.c (print_frame_arg, print_frame_info, print_frame)
3683         (info_frame_command_core): Use metadata style.
3684         * skip.c (info_skip_command): Use metadata style.
3685         * rust-lang.c (rust_print_enum): Use metadata style.
3686         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3687         metadata style.
3688         * python/py-framefilter.c (py_print_single_arg): Use metadata
3689         style.
3690         * printcmd.c (do_one_display, print_variable_and_value): Use
3691         metadata style.
3692         * p-valprint.c (pascal_val_print)
3693         (pascal_object_print_value_fields): Use metadata style.
3694         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3695         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3696         parameter.
3697         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3698         * m2-valprint.c (m2_print_long_set): Use metadata style.
3699         * m2-typeprint.c (m2_print_type): Use metadata style.
3700         * infcmd.c (print_return_value_1): Use metadata style.
3701         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3702         * f-valprint.c (info_common_command_for_block): Use metadata
3703         style.
3704         * f-typeprint.c (f_type_print_base): Use metadata style.
3705         * expprint.c (print_subexp_standard): Use metadata style.
3706         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3707         * cli/cli-style.h (class cli_style_option): Add constructor.
3708         (metadata_style): Declare.
3709         * cli/cli-style.c (metadata_style): New global.
3710         (_initialize_cli_style): Register metadata style.
3711         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3712         parameter.
3713         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3714         * c-typeprint.c (c_type_print_base_struct_union)
3715         (c_type_print_base_1): Use metadata style.
3716         * breakpoint.c (watchpoint_value_print)
3717         (print_one_breakpoint_location): Use metadata style.
3718         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3719         style.
3720         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3721         style.
3722         * ada-valprint.c (val_print_packed_array_elements, printstr)
3723         (print_field_values, ada_val_print_ref, ada_val_print): Use
3724         metadata style.
3725         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3726         style.
3727         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3728         style.
3729         * ada-lang.c (user_select_syms): Use metadata style.
3730
3731 2019-10-01  Tom Tromey  <tom@tromey.com>
3732
3733         * cli/cli-cmds.c (pwd_command): Style output.
3734
3735 2019-10-01  Pedro Alves  <palves@redhat.com>
3736             Tom Tromey  <tom@tromey.com>
3737
3738         * symtab.c (print_symbol_info): Use %ps.
3739         (print_msymbol_info): Use %ps.
3740         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3741         * printcmd.c (print_variable_and_value): Use %ps.
3742         * macrocmd.c (show_pp_source_pos): Use %ps.
3743         * infrun.c (print_exited_reason): Use ui_out::message.
3744         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3745         (describe_other_breakpoints): Use ui_out::message and new
3746         formats.
3747         (say_where): Use new formats.
3748         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3749         and new formats.
3750
3751 2019-10-01  Pedro Alves  <palves@redhat.com>
3752             Tom Tromey  <tom@tromey.com>
3753
3754         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3755         (test_gdb_formats): New function.
3756         (run_tests): Call it.
3757         (test_format_specifier): Update.
3758         * utils.h (fputs_filtered): Update comment.
3759         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3760         (fputs_styled_unfiltered): Declare.
3761         * utils.c (fputs_styled_unfiltered): New function.
3762         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3763         (vfprintf_filtered): Update.
3764         (vfprintf_unfiltered, vprintf_filtered): Update.
3765         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3766         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3767         disallow_ui_out_field>: New constants.
3768         (enum class field_kind): New.
3769         (struct base_field_s, struct signed_field_s): New.
3770         (signed_field): New function.
3771         (struct string_field_s): New.
3772         (string_field): New function.
3773         (struct styled_string_s): New.
3774         (styled_string): New function.
3775         (class ui_out) <message>: Add comment.
3776         <vmessage, call_do_message>: New methods.
3777         <do_message>: Add style parameter.
3778         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3779         methods.
3780         (ui_out::message): Rewrite.
3781         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3782         parameter.
3783         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3784         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3785         gdb_extensions parameter.
3786         (class format_piece): Add parameter to constructor.
3787         (n_int_args): New field.
3788         * gdbsupport/format.c (format_pieces::format_pieces): Add
3789         gdb_extensions parameter.  Handle '*'.
3790         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3791         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3792         vfprintf_styled_no_gdbfmt.
3793         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3794         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3795         unfiltered output.
3796         * ui-style.h (struct ui_file_style) <ptr>: New method.
3797
3798 2019-10-01  Tom Tromey  <tom@tromey.com>
3799
3800         * unittests/format_pieces-selftests.c: Update.  Add final format.
3801         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3802         empty literal pieces.
3803
3804 2019-10-01  Tom Tromey  <tom@tromey.com>
3805
3806         * ui-out.h (enum class ui_out_style_kind): Remove.
3807         (class ui_out) <field_string, field_stsream, do_field_string>:
3808         Change type of "style".
3809         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3810         (ui_out::field_string): Update.
3811         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3812         of "style".
3813         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3814         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3815         * stack.c (print_frame_arg, print_frame_info, print_frame):
3816         Update.
3817         * source.c (print_source_lines_base): Update.
3818         * solib.c (info_sharedlibrary_command): Update.
3819         * skip.c (info_skip_command): Update.
3820         * record-btrace.c (btrace_call_history_src_line)
3821         (btrace_call_history): Update.
3822         * python/py-framefilter.c (py_print_frame): Update.
3823         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3824         "style".
3825         * mi/mi-out.c (mi_ui_out::do_table_header)
3826         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3827         (mi_ui_out::do_field_string): Update.
3828         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3829         Update.
3830         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3831         "style".
3832         * cli-out.c (cli_ui_out::do_table_header)
3833         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3834         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3835         (cli_ui_out::do_field_fmt): Update.
3836         * breakpoint.c (print_breakpoint_location): Update.
3837         (update_static_tracepoint): Update.
3838
3839 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3840
3841         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3842         conversion of gdb_datadir.
3843         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3844         remove not needed c_str ().
3845
3846 2019-09-30  Ali Tamur <tamur@google.com>
3847
3848         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3849         (dwarf2_string_attr): Likewise.
3850
3851 2019-09-30  Ali Tamur <tamur@google.com>
3852
3853         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3854         (process_full_type_unit): Likewise.
3855         (dump_die_shallow): Likewise.
3856         (cu_debug_loc_section): Likewise.
3857
3858 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3859
3860         * minsyms.c (compare_minimal_symbols): Rename to...
3861         (minimal_symbol_is_less_than): ...this, and adjust to STL
3862         conventions (return bool, take arguments as references)
3863         (minimal_symbol_reader::install): Call std::sort instead
3864         of qsort.
3865
3866 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3867
3868         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3869         hash and why.
3870         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3871         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3872
3873 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3874
3875         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3876         * psympriv.h (add_psymbol_to_list): Move comment here and update
3877         it.
3878
3879 2019-09-29  Tom de Vries  <tdevries@suse.de>
3880
3881         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3882         Use $tmpdir/$(basename "$output_file").dwz instead of
3883         "${output_file}.dwz".
3884
3885 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3886
3887         PR gdb/25045
3888         * hppa-linux-nat.c: Include gdbarch.h.
3889
3890 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3891
3892         * blockframe.c (find_pc_partial_function): Change return type to bool.
3893         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3894         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3895         (stub_gnu_ifunc_resolve_name): Likewise.
3896         * symtab.c (compare_filenames_for_search): Likewise.
3897         (compare_glob_filenames_for_search): Likewise.
3898         (matching_obj_sections): Likewise.
3899         (symbol_matches_domain): Likewise.
3900         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3901         (find_line_pc): Change return type to bool.
3902         (find_line_pc_range): Likewise.
3903         (producer_is_realview): Likewise.
3904         * symtab.h (symbol_matches_domain): Likewise.
3905         (find_pc_partial_function): Likewise.
3906         (find_pc_line_pc_range): Likewise.
3907         (in_gnu_ifunc_stub): Likewise.
3908         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3909         (find_line_pc): Likewise.
3910         (find_line_pc_range): Likewise.
3911         (matching_obj_sections): Likewise.
3912         (find_line_symtab): Change out parameter to bool.
3913         (producer_is_realview): Change return type to bool.
3914         (compare_filenames_for_search): Likewise.
3915         (compare_glob_filenames_for_search): Likewise.
3916
3917 2019-09-26  Tom Tromey  <tom@tromey.com>
3918
3919         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3920         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3921         * gdb_usleep.h: Remove.
3922         * gdb_usleep.c: Remove.
3923         * utils.c: Don't include gdb_usleep.h.
3924
3925 2019-09-26  Tom Tromey  <tromey@adacore.com>
3926
3927         * python/py-type.c (type_to_type_object): Call check_typedef
3928         for stub types.
3929
3930 2019-09-26  Tom Tromey  <tom@tromey.com>
3931
3932         * utils.h (initialize_utils): Don't declare.
3933         * top.c (gdb_init): Don't call initialize_utils.
3934         * utils.c (initialize_utils): Remove.  Move contents...
3935         (_initialize_utils): ... here.
3936
3937 2019-09-25  Tom Tromey  <tom@tromey.com>
3938
3939         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3940         * utils.h (make_hex_string): Don't declare.
3941         * utils.c (make_hex_string): Remove.
3942
3943 2019-09-24  Tom de Vries  <tdevries@suse.de>
3944
3945         PR gdb/23815
3946         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3947         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3948
3949 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3950
3951         * NEWS: Mention new simulator port for PRU.
3952
3953 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3954
3955         * ada-exp.y (write_object_remaining): Update.
3956         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3957         and eliminate the static buffer.
3958         (ada_decode_symbol): Update.
3959         (ada_la_decode): Update.
3960         (ada_sniff_from_mangled_name): Update.
3961         (is_valid_name_for_wild_match): Update.
3962         (ada_lookup_name_info::matches): Update and simplify.
3963         (name_matches_regex): Update.
3964         (ada_add_global_exceptions): Update.
3965         * ada-lang.h (ada_decode): Update signature.
3966         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3967         * dwarf-index-write.c (debug_names::insert): Update.
3968
3969 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3970
3971         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3972         formatting.
3973
3974 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3975
3976         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3977         Change "nonzero" to "true" in documentation.
3978
3979 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3980
3981         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3982         (_initialize_darwin_solib): Don't set
3983         darwin_so_ops.lookup_lib_global_symbol.
3984         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3985         set_gdbarch_iterate_over_objfiles_in_search_order.
3986         (elf_lookup_lib_symbol): Rename to...
3987         (svr4_iterate_over_objfiles_in_search_order): this, and update
3988         to iterate semantics.
3989         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3990         * solib.c (solib_global_lookup): Remove.
3991         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3992         (solib_global_lookup): Remove.
3993         * symtab.c (lookup_global_or_static_symbol): Remove call to
3994         solib_global_lookup.
3995
3996 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3997
3998         * NEWS: Move entries about default MI version now being
3999         version 3, and about the GDB/MI fix for multi-location
4000         breakpoints to the "since GDB 8.3" section.
4001
4002 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4003
4004         GDB 8.3.1 released.
4005
4006 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4007
4008         * NEWS: Mention that Cell/B.E. debugging support was removed.
4009         * MAINTAINERS: Remove spu target.
4010
4011         * config/djgpp/fnchange.lst: Remove entries for removed files.
4012
4013         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4014         spu-multiarch.o, and spu-tdep.o.
4015         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4016         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4017         spu-multiarch.c, and spu-tdep.c.
4018         * spu-linux-nat.c: Remove file.
4019         * spu-multiarch.c: Remove file.
4020         * spu-tdep.c: Remove file.
4021         * spu-tdep.h: Remove file.
4022         * solib-spu.c: Remove file.
4023         * solib-spu.h: Remove file.
4024
4025         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4026         * configure.nat (spu-linux): Remove.
4027         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4028         solib-multiarch.o from gdb_target_obs.
4029         (spu*-*-*): Remove.
4030
4031         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4032         feature flag.
4033         (ppc_linux_no_features): Update.
4034         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4035         Cell/B.E. support.
4036         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4037         (tdesc_powerpc_cell64l): Likewise.
4038         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4039         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4040         Cell/B.E. support.
4041         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4042         Do not include "features/rs6000/powerpc-cell32l.c" or
4043         "features/rs6000/powerpc-cell64l.c".
4044         (ppc_linux_spu_section): Remove.
4045         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4046         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4047         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4048         (ppc_linux_spe_context_lookup): Remove.
4049         (ppc_linux_spe_context_inferior_created): Remove.
4050         (ppc_linux_spe_context_solib_loaded): Remove.
4051         (ppc_linux_spe_context_solib_unloaded): Remove.
4052         (ppc_linux_spe_context): Remove.
4053         (struct ppu2spu_cache): Remove.
4054         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4055         (struct ppu2spu_data): Remove.
4056         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4057         ppu2spu_unwind): Remove.
4058         (ppc_linux_init_abi): Remove Cell/B.E. support.
4059         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4060
4061         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4062         (rs6000/powerpc-cell64l-expedite): Likewise
4063         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4064         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4065         rs6000/powerpc-cell64l.xml.
4066         * features/rs6000/powerpc-cell32l.xml: Remove.
4067         * features/rs6000/powerpc-cell64l.xml: Likewise.
4068         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4069         * features/rs6000/powerpc-cell64l.c: Likewise.
4070         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4071         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4072         * regformats/reg-spu.dat: Remove.
4073
4074         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4075         * corelow.c (struct spuid_list): Remove.
4076         (add_to_spuid_list): Remove.
4077         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4078         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4079         (remote_protocol_features): Remove associated entries.
4080         (_initialize_remote): No longer initialize them.
4081         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4082         * linux-nat.c (SPUFS_MAGIC): Remove.
4083         (linux_proc_xfer_spu): Remove.
4084         (spu_enumerate_spu_ids): Remove.
4085         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4086         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4087         (linux_make_corefile_notes): No longer call it.
4088
4089         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4090         (cooked_write_test): Likewise.
4091
4092 2019-09-20  Tom Tromey  <tom@tromey.com>
4093
4094         * NEWS: Mention case-sensitivity of TUI commands.
4095         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4096         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4097         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4098
4099 2019-09-20  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui-source.c (tui_source_window::set_contents): Use
4102         make_unique_xstrdup.
4103         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4104         make_unique_xstrdup.
4105
4106 2019-09-20  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-data.c: Remove separator comments.
4109         * tui/tui-layout.c: Remove separator comments.
4110         * tui/tui-win.c: Remove separator comments.
4111         * tui/tui-wingeneral.c: Remove separator comments.
4112
4113 2019-09-20  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui.h (strcat_to_buf): Don't declare.
4116         * tui/tui.c (strcat_to_buf): Remove.
4117
4118 2019-09-20  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4121         from "fullname".
4122         * tui/tui-source.c (tui_source_window::set_contents)
4123         (tui_source_window::location_matches_p)
4124         (tui_source_window::maybe_update): Update.
4125
4126 2019-09-20  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4129         Update.
4130         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4131         prefix.
4132         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4133         (tui_data_window::line_from_reg_element_no)
4134         (tui_data_window::first_reg_element_no_inline)
4135         (tui_data_window::show_registers)
4136         (tui_data_window::show_register_group)
4137         (tui_data_window::display_registers_from)
4138         (tui_data_window::display_registers_from_line)
4139         (tui_data_window::first_data_item_displayed)
4140         (tui_data_window::delete_data_content_windows)
4141         (tui_data_window::erase_data_content)
4142         (tui_data_window::do_scroll_vertical)
4143         (tui_data_window::refresh_window)
4144         (tui_data_window::check_register_values): Update.
4145
4146 2019-09-20  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4149         (struct tui_locator_window) <full_name, proc_name>: Now
4150         std::string.
4151         * tui/tui-stack.c (tui_locator_window::make_status_line)
4152         (tui_locator_window::set_locator_fullname)
4153         (tui_locator_window::set_locator_info): Update.
4154         * tui/tui-source.c (tui_source_window::set_contents)
4155         (tui_source_window::showing_source_p): Update.
4156
4157 2019-09-20  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4160         Don't call tui_locator_win_info_ptr.
4161
4162 2019-09-20  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4165
4166 2019-09-20  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4169         height for locator.
4170         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4171         * tui/tui-layout.c (show_source_disasm_command, show_data)
4172         (show_source_or_disasm_and_command): Use 1 as height for locator.
4173
4174 2019-09-20  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui.c (tui_enable): Update.
4177         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4178         Update.
4179         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4180         Update.
4181         * tui/tui-data.c (win_resized): Now bool.
4182         (tui_win_resized): Return bool.
4183         (tui_set_win_resized_to): Accept a bool.
4184
4185 2019-09-20  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4188         Change type of "refresh_values_only".
4189         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4190         type of "refresh_values_only".
4191
4192 2019-09-20  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4195         std::string.
4196         (tui_disassemble): Add "pos" parameter.
4197         (tui_disasm_window::set_contents): Simplify.
4198
4199 2019-09-20  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-winsource.h (struct tui_source_window_base)
4202         <show_source_content>: Now private.
4203         * tui/tui-winsource.c
4204         (tui_source_window_base::show_source_content): Don't handle empty
4205         content case.
4206
4207 2019-09-20  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-layout.c (show_source_disasm_command)
4210         (show_source_or_disasm_and_command): Don't call
4211         show_source_content.
4212
4213 2019-09-20  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4216         Declare.
4217         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4218         from tui_make_status_line.
4219         (tui_locator_window::rerender): Update.
4220
4221 2019-09-20  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4224         (tui_locator_window::rerender): Update.
4225
4226 2019-09-20  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-winsource.h (struct tui_source_window_base)
4229         <~tui_source_window_base>: Don't declare.
4230         <fullname>: Remove.
4231         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4232         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4233         member.
4234         * tui/tui-source.c (tui_source_window::set_contents): Update.
4235         (tui_source_window::location_matches_p)
4236         (tui_source_window::maybe_update): Update.
4237
4238 2019-09-20  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-winsource.h (~tui_source_element): Remove.
4241         (tui_source_element): Update.
4242         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4243         * tui/tui-winsource.c (tui_show_source_line): Update.
4244         * tui/tui-source.c (tui_source_window::set_contents): Update.
4245         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4246
4247 2019-09-20  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4250         declare.
4251         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4252         tui_clear_source_windows_detail.
4253         * tui/tui-winsource.h (struct tui_source_window_base)
4254         <clear_detail>: Don't declare.
4255         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4256         Remove.
4257         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4258
4259 2019-09-20  Tom Tromey  <tromey@adacore.com>
4260
4261         PR ada/24919:
4262         * block.c (contained_in): Fix final return value.
4263
4264 2019-09-20  Alan Modra  <amodra@gmail.com>
4265
4266         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4267         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4268         (read_indirect_string_from_dwz): Use bfd accessor.
4269         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4270         * machoread.c (macho_symfile_read_all_oso): Likewise.
4271         * solib.c (solib_bfd_open): Likewise.
4272
4273 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4274
4275         * eval.c: Move declaration of overload_resolution to...
4276         * value.h: ...here.
4277
4278 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4279
4280         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4281         * arm-linux-tdep.c: Likewise.
4282         * arm-nbsd-nat.c: Likewise.
4283         * arm-tdep.h: Declare arm_apcs_32.
4284         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4285
4286 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4287
4288         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4289         * dwarf2read.h: Declare dwarf_always_disassemble.
4290
4291 2019-09-19  Tom de Vries  <tdevries@suse.de>
4292
4293         PR gdb/25009
4294         * source-cache.c (source_cache::ensure): Catch exception thrown during
4295         construction of the highlighter.
4296
4297 2019-09-18  Alan Modra  <amodra@gmail.com>
4298
4299         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4300         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4301         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4302         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4303         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4304         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4305         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4306         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4307         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4308         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4309         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4310         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4311         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4312         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4313         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4314         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4315         * mi/mi-interp.c: Update throughout for bfd section macro and
4316         function changes.
4317         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4318         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4319
4320 2019-09-18  Tom Tromey  <tom@tromey.com>
4321
4322         * NEWS: Add entry.
4323         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4324         call rl_initialize.
4325         (tui_enable): Do not call rl_initialize.
4326
4327 2019-09-18  Christian Groessler  <chris@groessler.org>
4328
4329         * alpha-linux-nat.c: Include gdbarch.h.
4330
4331 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4332
4333         * ui-file.c: Include cli/cli-style.h.
4334         (term_cli_styling): Remove cli_styling declaration.
4335
4336 2019-09-18  Alan Modra  <amodra@gmail.com>
4337
4338         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4339         to bfd_asymbol_section.
4340
4341 2019-09-18  Alan Modra  <amodra@gmail.com>
4342
4343         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4344         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4345         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4346
4347 2019-09-18  Alan Modra  <amodra@gmail.com>
4348
4349         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4350         * spu-linux-nat.c (spu_bfd_open): Likewise.
4351
4352 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4353
4354         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4355         to bool to match definition in dwarf2read.c.
4356
4357 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4358
4359         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4360         (print_signatures): Likewise.
4361         (trust_pad_over_xvs): Likewise.
4362         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4363         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4364         * arm-linux-nat.c (arm_apcs_32): Likewise.
4365         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4366         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4367         * arm-tdep.c (arm_debug): Likewise.
4368         (arm_apcs_32): Likewise.
4369         * auto-load.c (debug_auto_load): Likewise.
4370         (auto_load_gdb_scripts): Likewise.
4371         (global_auto_load): Likewise.
4372         (auto_load_local_gdbinit): Likewise.
4373         (auto_load_local_gdbinit_loaded): Likewise.
4374         * auto-load.h (global_auto_load): Likewise.
4375         (auto_load_local_gdbinit): Likewise.
4376         (auto_load_local_gdbinit_loaded): Likewise.
4377         * breakpoint.c (disconnected_dprintf): Likewise.
4378         (breakpoint_proceeded): Likewise.
4379         (automatic_hardware_breakpoints): Likewise.
4380         (always_inserted_mode): Likewise.
4381         (target_exact_watchpoints): Likewise.
4382         (_initialize_breakpoint): Update.
4383         * breakpoint.h (target_exact_watchpoints): Change to bool.
4384         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4385         * cli/cli-cmds.c (trace_commands): Likewise.
4386         * cli/cli-cmds.h (trace_commands): Likewise.
4387         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4388         to bool*.
4389         * cli/cli-logging.c (logging_overwrite): Change to bool.
4390         (logging_redirect): Likewise.
4391         (debug_redirect): Likewise.
4392         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4393         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4394         to bool.
4395         <boolean_option_def>: Update.
4396         (struct flag_option_def): Change default type of Context to bool
4397         from int.
4398         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4399         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4400         (get_setshow_command_value_string): Likewise.
4401         * cli/cli-style.c (cli_styling): Change to bool.
4402         (source_styling): Likewise.
4403         * cli/cli-style.h (source_styling): Likewise.
4404         (cli_styling): Likewise.
4405         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4406         to bool.
4407         * command.h (var_types): Update comment.
4408         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4409         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4410         bool.
4411         (debug_compile_cplus_scopes): Likewise.
4412         * compile/compile-internal.h (compile_debug): Likewise.
4413         * compile/compile.c (compile_debug): Likewise.
4414         (struct compile_options) <raw>: Likewise.
4415         * cp-support.c (catch_demangler_crashes): Likewise.
4416         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4417         (usr_cmd_cris_dwarf2_cfi): Likewise.
4418         * csky-tdep.c (csky_debug): Likewise.
4419         * darwin-nat.c (enable_mach_exceptions): Likewise.
4420         * dcache.c (dcache_enabled_p): Likewise.
4421         * defs.h (info_verbose): Likewise.
4422         * demangle.c (demangle): Likewise.
4423         (asm_demangle): Likewise.
4424         * dwarf-index-cache.c (debug_index_cache): Likewise.
4425         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4426         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4427         * dwarf2read.c (check_physname): Likewise.
4428         (use_deprecated_index_sections): Likewise.
4429         (dwarf_always_disassemble): Likewise.
4430         * eval.c (overload_resolution): Likewise.
4431         * event-top.c (set_editing_cmd_var): Likewise.
4432         (exec_done_display_p): Likewise.
4433         * event-top.h (set_editing_cmd_var): Likewise.
4434         (exec_done_display_p): Likewise.
4435         * exec.c (write_files): Likewise.
4436         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4437         (debug_fbsd_nat): Likewise.
4438         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4439         Likewise.
4440         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4441         <backtrace_past_entry> Likewise.
4442         * gdb-demangle.h (demangle): Likewise.
4443         (asm_demangle): Likewise.
4444         * gdb_bfd.c (bfd_sharing): Likewise.
4445         * gdbcore.h (write_files): Likewise.
4446         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4447         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4448         * gdbthread.h (print_thread_events): Likewise.
4449         * gdbtypes.c (opaque_type_resolution): Likewise.
4450         (strict_type_checking): Likewise.
4451         * gnu-nat.c (gnu_debug_flag): Likewise.
4452         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4453         * guile/scm-param.c (pascm_variable): Add boolval.
4454         (add_setshow_generic): Update.
4455         (pascm_param_value): Update.
4456         (pascm_set_param_value_x): Update.
4457         * hppa-tdep.c (hppa_debug): Change to bool..
4458         * infcall.c (may_call_functions_p): Likewise.
4459         (coerce_float_to_double_p): Likewise.
4460         (unwind_on_signal_p): Likewise.
4461         (unwind_on_terminating_exception_p): Likewise.
4462         * infcmd.c (startup_with_shell): Likewise.
4463         * inferior.c (print_inferior_events): Likewise.
4464         * inferior.h (startup_with_shell): Likewise.
4465         (print_inferior_events): Likewise.
4466         * infrun.c (step_stop_if_no_debug): Likewise.
4467         (detach_fork): Likewise.
4468         (debug_displaced): Likewise.
4469         (disable_randomization): Likewise.
4470         (non_stop): Likewise.
4471         (non_stop_1): Likewise.
4472         (observer_mode): Likewise.
4473         (observer_mode_1): Likewise.
4474         (set_observer_mode): Update.
4475         (sched_multi): Change to bool.
4476         * infrun.h (debug_displaced): Likewise.
4477         (sched_multi): Likewise.
4478         (step_stop_if_no_debug): Likewise.
4479         (non_stop): Likewise.
4480         (disable_randomization): Likewise.
4481         * linux-tdep.c (use_coredump_filter): Likewise.
4482         (dump_excluded_mappings): Likewise.
4483         * linux-thread-db.c (auto_load_thread_db): Likewise.
4484         (check_thread_db_on_load): Likewise.
4485         * main.c (captured_main_1): Update.
4486         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4487         xx2_opt, boolean_opt>: Change to bool.
4488         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4489         * maint.c (maintenance_profile_p): Likewise.
4490         (per_command_time): Likewise.
4491         (per_command_space): Likewise.
4492         (per_command_symtab): Likewise.
4493         * memattr.c (inaccessible_by_default): Likewise.
4494         * mi/mi-main.c (mi_async): Likewise.
4495         (mi_async_1): Likewise.
4496         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4497         * nat/fork-inferior.h (startup_with_shell): Likewise.
4498         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4499         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4500         * nios2-tdep.c (nios2_debug): Likewise.
4501         * or1k-tdep.c (or1k_debug): Likewise.
4502         * parse.c (parser_debug): Likewise.
4503         * parser-defs.h (parser_debug): Likewise.
4504         * printcmd.c (print_symbol_filename): Likewise.
4505         * proc-api.c (procfs_trace): Likewise.
4506         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4507         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4508         (set_parameter_value): Update.
4509         (add_setshow_generic): Update.
4510         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4511         to bool*.
4512         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4513         int*.
4514         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4515         * record-btrace.c (record_btrace_target::store_registers): Update.
4516         * record-full.c (record_full_memory_query): Change to bool.
4517         (record_full_stop_at_limit): Likewise.
4518         * record-full.h (record_full_memory_query): Likewise.
4519         * remote-notif.c (notif_debug): Likewise.
4520         * remote-notif.h (notif_debug): Likewise.
4521         * remote.c (use_range_stepping): Likewise.
4522         (interrupt_on_connect): Likewise.
4523         (remote_break): Likewise.
4524         * ser-tcp.c (tcp_auto_retry): Likewise.
4525         * ser-unix.c (serial_hwflow): Likewise.
4526         * skip.c (debug_skip): Likewise.
4527         * solib-aix.c (solib_aix_debug): Likewise.
4528         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4529         (spu_auto_flush_cache_p): Likewise.
4530         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4531         Likewise.
4532         (struct info_print_options) <quiet>: Likewise.
4533         * symfile-debug.c (debug_symfile): Likewise.
4534         * symfile.c (auto_solib_add): Likewise.
4535         (separate_debug_file_debug): Likewise.
4536         * symfile.h (auto_solib_add): Likewise.
4537         (separate_debug_file_debug): Likewise.
4538         * symtab.c (basenames_may_differ): Likewise.
4539         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4540         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4541         (struct info_types_options) <quiet>: Likewise.
4542         * symtab.h (demangle): Likewise.
4543         (basenames_may_differ): Likewise.
4544         * target-dcache.c (stack_cache_enabled_1): Likewise.
4545         (code_cache_enabled_1): Likewise.
4546         * target.c (trust_readonly): Likewise.
4547         (may_write_registers): Likewise.
4548         (may_write_memory): Likewise.
4549         (may_insert_breakpoints): Likewise.
4550         (may_insert_tracepoints): Likewise.
4551         (may_insert_fast_tracepoints): Likewise.
4552         (may_stop): Likewise.
4553         (auto_connect_native_target): Likewise.
4554         (target_stop_and_wait): Update.
4555         (target_async_permitted): Change to bool.
4556         (target_async_permitted_1): Likewise.
4557         (may_write_registers_1): Likewise.
4558         (may_write_memory_1): Likewise.
4559         (may_insert_breakpoints_1): Likewise.
4560         (may_insert_tracepoints_1): Likewise.
4561         (may_insert_fast_tracepoints_1): Likewise.
4562         (may_stop_1): Likewise.
4563         * target.h (target_async_permitted): Likewise.
4564         (may_write_registers): Likewise.
4565         (may_write_memory): Likewise.
4566         (may_insert_breakpoints): Likewise.
4567         (may_insert_tracepoints): Likewise.
4568         (may_insert_fast_tracepoints): Likewise.
4569         (may_stop): Likewise.
4570         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4571         (make_thread_apply_all_options_def_group): Change argument from int*
4572         to bool*.
4573         (thread_apply_all_command): Update.
4574         (print_thread_events): Change to bool.
4575         * top.c (confirm): Likewise.
4576         (command_editing_p): Likewise.
4577         (history_expansion_p): Likewise.
4578         (write_history_p): Likewise.
4579         (info_verbose): Likewise.
4580         * top.h (confirm): Likewise.
4581         (history_expansion_p): Likewise.
4582         * tracepoint.c (disconnected_tracing): Likewise.
4583         (circular_trace_buffer): Likewise.
4584         * typeprint.c (print_methods): Likewise.
4585         (print_typedefs): Likewise.
4586         * utils.c (debug_timestamp): Likewise.
4587         (sevenbit_strings): Likewise.
4588         (pagination_enabled): Likewise.
4589         * utils.h (sevenbit_strings): Likewise.
4590         (pagination_enabled): Likewise.
4591         * valops.c (overload_resolution): Likewise.
4592         * valprint.h (struct value_print_options) <prettyformat_arrays,
4593         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4594         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4595         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4596         Likewise.
4597         * windows-nat.c (new_console): Likewise.
4598         (cygwin_exceptions): Likewise.
4599         (new_group): Likewise.
4600         (debug_exec): Likewise.
4601         (debug_events): Likewise.
4602         (debug_memory): Likewise.
4603         (debug_exceptions): Likewise.
4604         (useshell): Likewise.
4605         * windows-tdep.c (maint_display_all_tib): Likewise.
4606         * xml-support.c (debug_xml): Likewise.
4607
4608 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4609
4610         * source.c (prepare_path_for_appending): New function.
4611         (openp): Make use of new function.
4612         (find_and_open_source): Search for the compilation directory and
4613         source file as a relative path beneath the directory search path.
4614
4615 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * source-cache.c (source_cache::get_line_charpos): Catch
4618         exceptions and return false, this matches the behaviour documented
4619         in the header file.
4620
4621 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4622
4623         * ada-tasks.c (info_task): Remove quoting of the task's name.
4624
4625 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4626
4627         * symfile.c (auto_solib_add): Replace comment with a reference
4628         to the header file.
4629
4630 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4631
4632         * NEWS: Mention that gdb can now be compiled with Python 3
4633         on Windows.
4634
4635 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4636
4637         * maint.c (maint_print_section_data::maint_print_section_data):
4638         Force use of 'float log10 (float)' by casting the argument to
4639         float.
4640
4641 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * maint.c: Add 'cmath' include.
4644         (struct maint_print_section_data): New structure.
4645         (print_section_index): New function.
4646         (print_bfd_section_info): Add header comment, small whitespace
4647         cleanup, and update to call new print_section_index function.
4648         (print_objfile_section_info): Likewise.
4649         (maint_obj_section_from_bfd_section): New function.
4650         (print_bfd_section_info_maybe_relocated): New function.
4651         (maintenance_info_sections): Add header comment, always use
4652         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4653
4654 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4657         inner scope, add check that the objfile has psymtabs before
4658         checking psymtabs_addrmap.
4659         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4660
4661 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4662
4663         * NEWS: Announce that Ada task names are now shown at more places,
4664         and between quotes (except in info task output).
4665         * gdb/ada-tasks.c (task_to_str): New function.
4666         (display_current_task_id): Call task_to_str.
4667         (task_command_1): Likewise.
4668         (print_ada_task_info): In non-mi mode, Properly align headers and data
4669         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4670
4671 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4672
4673         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4674         prstatus.pr_lwp.pr_info instead of making it up.
4675
4676 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4677
4678         * auto-load.c (auto_load_expand_dir_vars): Update.
4679         * defs.h (gdb_datadir): Change to std::string.
4680         (python_libdir): Likewise.
4681         (relocate_gdb_directory): Change return type to std::string.
4682         * guile/guile.c (gdbscm_data_directory): Update.
4683         (initialize_scheme_side): Update.
4684         * jit.c (jit_reader_dir): Change to std::string.
4685         (jit_reader_load_command): Update.
4686         * main.c (gdb_datadir): Change to std::string.
4687         (python_libdir): Likewise.
4688         (set_gdb_data_directory): Update.
4689         (relocate_path): Change to return std::string.
4690         (relocate_gdb_directory): Change to return std::string.
4691         (relocate_gdbinit_path_maybe_in_datadir): Update.
4692         (captured_main_1): Update.
4693         * python/python.c (do_start_initialization): Update.
4694         * top.c (show_gdb_datadir): Update.
4695         * xml-syscall.c (xml_init_syscalls_info): Update.
4696         (init_syscalls_info): Update.
4697
4698 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4699
4700         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4701         out of get_init_files.
4702         (get_init_files): Update.
4703
4704 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4705
4706         * main.c (get_init_files): Change to use std::string.
4707         (captured_main_1): Update.
4708         (print_gdb_help): Update.
4709
4710 2019-09-11  Ali Tamur  <tamur@google.com>
4711
4712         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4713         implementation.
4714
4715 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4716
4717         * dbxread.c (read_dbx_symtab): Update.
4718         * dwarf2read.c (load_partial_dies): Update.
4719         * mdebugread.c (parse_partial_symbols): Update.
4720         (handle_psymbol_enumerators): Update.
4721         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4722         * psymtab.c (add_psymbol_to_bcache): Likewise.
4723         (add_psymbol_to_list): Likewise.
4724         * symtab.c (symbol_set_names): Likewise.
4725         * symtab.h (symbol_set_names): Likewise.
4726         * xcoffread.c (scan_xcoff_symtab): Update.
4727
4728 2019-09-11  Tom Tromey  <tom@tromey.com>
4729
4730         * symfile-mem.c (symbol_file_add_from_memory): Use
4731         bfd_set_filename.
4732         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4733         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4734
4735 2019-09-10  Tom Tromey  <tromey@adacore.com>
4736
4737         * dwarf-index-write.c (write_psymbols): Extend error message.
4738         (debug_names::insert): Add Ada code.
4739         (debug_names::write_psymbols): Remove Ada check.
4740         (debug_names) <m_string_obstack>: New member.
4741         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4742         (gdb_index_symbol_name_matcher::matches): Remove.
4743         (mapped_index_base::find_name_components_bounds): Add "lang"
4744         parameter.
4745         (mapped_index_base::build_name_components): Also split names
4746         according to Ada syntax.
4747         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4748         type of "match_callback".
4749         (check_match, check_find_bounds_finds)
4750         (dw2_expand_symtabs_matching): Update.
4751         (dw2_debug_names_iterator): Add new constructor.
4752         (dw2_debug_names_map_matching_symbols): New function.
4753         (dw2_debug_names_expand_symtabs_matching): Update.
4754         (dwarf2_debug_names_functions): Use
4755         dw2_debug_names_map_matching_symbols.
4756
4757 2019-09-10  Tom Tromey  <tromey@adacore.com>
4758
4759         * dwarf2read.c (dw2_get_file_names_reader): Add the
4760         CU's file name to the results.
4761
4762 2019-09-10  Tom Tromey  <tromey@adacore.com>
4763
4764         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4765         map_matching_symbols.  Update.
4766         * dwarf2read.c (dw2_map_matching_symbols): Update.
4767         * psymtab.c (match_partial_symbol): Change type; update.
4768         (psym_map_matching_symbols): Likewise.
4769         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4770         type; update.
4771         * symfile.h (struct quick_symbol_functions)
4772         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4773         Remove "match".
4774
4775 2019-09-10  Tom Tromey  <tromey@adacore.com>
4776
4777         * psymtab.c (map_block): Remove.
4778         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4779         * symtab.c (iterate_over_symbols_terminated): New function.
4780         * symtab.c (iterate_over_symbols_terminated): Declare.
4781
4782 2019-09-10  Tom Tromey  <tromey@adacore.com>
4783
4784         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4785         * language.h (struct language_defn) <la_iterate_over_symbols>:
4786         Return bool.
4787         * symtab.c (iterate_over_symbols): Return bool.
4788         * symtab.h (iterate_over_symbols): Return bool.
4789
4790 2019-09-10  Tom Tromey  <tromey@adacore.com>
4791
4792         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4793         (add_nonlocal_symbols): Update.
4794         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4795         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4796         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4797         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4798         Change type of "callback".  Remove "data".
4799
4800
4801 2019-09-09  Ali Tamur  <tamur@google.com>
4802
4803         * dwarf2read.c (comp_unit_head): Update comment.
4804         (dwarf2_dwo_name): New function declaration.
4805         (dwarf_unit_type_name): New function declaration.
4806         (read_comp_unit_head): Add support for new compilation units,
4807         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4808         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4809         (currently named as "signature") in their header. Also clarify error
4810         messages.
4811         (lookup_dwo_id): New function. Returns the dwo id of the given
4812         compile unit.
4813         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4814         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4815         functions.
4816         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4817         (dwarf2_dwo_name): Get the dwo name if present.
4818         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4819         purposes.
4820
4821 2019-09-09  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4824
4825 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4826
4827         * python/python.c (do_start_initialization): Make progname_copy static,
4828         to avoid a leak report.
4829
4830 2019-09-08  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4833
4834 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4835
4836         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4837         Change type to gdb::optional<block_enum>.
4838         (dw2_symtab_iter_init): Change block_index parameter type
4839         to gdb::optional<block_enum>.
4840         (dw2_lookup_symbol): Change block_index parameter
4841         type to block_enum.c
4842         (dw2_debug_names_lookup_symbol): Likewise.
4843         * psymtab.c (psym_lookup_symbol): Likewise.
4844         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4845         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4846         Likewise.
4847
4848 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4849
4850         * defs.h (relocate_gdb_directory): Change int to bool in
4851         signature and rename flag to relocatable.
4852         * main.c (relocate_path): Likewise.
4853         (relocate_gdb_directory): Likewise.
4854
4855 2019-09-06  Alan Modra  <amodra@gmail.com>
4856
4857         * coffread.c (coff_symfile_read): Constify filename variable.
4858         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4859         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4860         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4861         * solib.c (reload_shared_libraries_1): Likewise.
4862         * symfile.c (reread_symbols): Likewise.
4863         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4864         * solib-darwin.c (darwin_bfd_open): Likewise.
4865         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4866
4867 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4870         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4871
4872 2019-09-03  Tom Tromey  <tromey@adacore.com>
4873
4874         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4875         types.
4876         (has_negatives): Unbias a range type bound.
4877         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4878         * gdbtypes.c (operator==): Handle new field.
4879         (create_range_type): Add "bias" parameter.
4880         (create_static_range_type, resolve_dynamic_range): Update.
4881         * gdbtypes.h (struct range_bounds) <bias>: New member.
4882         (create_range_type): Add bias parameter.
4883         * printcmd.c (print_scalar_formatted): Unbias range types.
4884         * value.c (unpack_long): Unbias range types.
4885         (pack_long): Bias range types.
4886
4887 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4888
4889         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4890         probe arguments.
4891
4892 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4893
4894         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4895         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4896         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4897         (compile_probe_arg): Likewise.
4898         * probe.h (get_argument_count): Likewise.
4899         * solib-svr4.c (solib_event_probe_action): Likewise.
4900         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4901
4902 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4903
4904         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4905         code to here...
4906         (svr4_create_solib_event_breakpoints): ...from here.
4907
4908 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4909
4910         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4911         suffix from warning message.
4912
4913 2019-08-30  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-winsource.h (struct tui_source_window_base)
4916         <refresh_all>: Don't declare.
4917         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4918         Remove.
4919         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4920         tui_show_locator_content.
4921         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4922         declare.
4923         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4924         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4925         declare.
4926
4927 2019-08-30  Tom Tromey  <tom@tromey.com>
4928
4929         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4930
4931 2019-08-30  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4934         Remove unnecessary forward declarations.
4935
4936 2019-08-30  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4939         rerender.
4940         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4941         tui_show_locator_content.
4942
4943 2019-08-30  Tom Tromey  <tom@tromey.com>
4944
4945         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4946         (tui_locator_window::rerender): Rewrite using body of previous
4947         tui_show_locator_content.
4948
4949 2019-08-30  Tom Tromey  <tom@tromey.com>
4950
4951         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4952         set_locator_fullname>: New methods.
4953         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4954         Rename from tui_set_locator_fullname.
4955         (tui_locator_window::set_locator_info): Rename from
4956         tui_set_locator_info.  Return bool.
4957         (tui_update_locator_fullname, tui_show_frame_info): Update.
4958
4959 2019-08-30  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4962
4963 2019-08-30  Tom Tromey  <tom@tromey.com>
4964
4965         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4966         call touchwin.
4967
4968 2019-08-30  Tom Tromey  <tom@tromey.com>
4969
4970         * tui/tui-wingeneral.c (box_win): Assume win_info and
4971         win_info->handle cannot be NULL.
4972
4973 2019-08-30  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4976         refresh_window>: Declare.
4977         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4978         resize.
4979         (tui_data_item_window::rerender): Rename from
4980         tui_display_register.
4981         (tui_data_item_window::refresh_window): New method.
4982         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4983         no-op.
4984
4985 2019-08-30  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4988         regs_column_count, current_group>: Move later.  Now private.
4989         <get_current_group>: New method.
4990         * tui/tui-regs.c (tui_reg_command): Update.
4991         * tui/tui-layout.c (tui_set_layout): Update.
4992
4993 2019-08-30  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4996         (tui_data_window::rerender): Don't call
4997         check_and_display_highlight_if_needed.
4998         (tui_data_window::refresh_all): Remove call to
4999         erase_data_content.
5000
5001 2019-08-30  Tom Tromey  <tom@tromey.com>
5002
5003         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5004         (tui_data_window::display_registers_from)
5005         (tui_data_window::display_reg_element_at_line)
5006         (tui_data_window::display_registers_from_line): Remove checks of
5007         "empty".
5008
5009 2019-08-30  Tom Tromey  <tom@tromey.com>
5010
5011         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5012         Don't declare.
5013         * tui/tui-regs.c (tui_data_window::show_registers): Call
5014         rerender.
5015         (tui_data_window::rerender): Rename from display_all_data.
5016         (tui_data_window::rerender): Remove old implementation.
5017
5018 2019-08-30  Tom Tromey  <tom@tromey.com>
5019
5020         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5021         text.
5022         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5023
5024 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5025             Sergio Durigan Junior  <sergiodj@redhat.com>
5026
5027         PR win32/24284
5028         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5029
5030 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5031
5032         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5033         when searching for types.
5034
5035 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * f-lang.c (f_language_defn): Use f_print_typedef.
5038         * f-lang.h (f_print_typedef): Declare.
5039         * f-typeprint.c (f_print_typedef): Define.
5040
5041 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5042
5043         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5044
5045 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * cli/cli-utils.c (info_print_options_defs): Delete.
5048         (make_info_print_options_def_group): Delete.
5049         (extract_info_print_options): Delete.
5050         (info_print_command_completer): Delete.
5051         (info_print_args_help): Add extra parameter, and optionally
5052         include text about -n flag.
5053         * cli/cli-utils.h (struct info_print_options): Delete.
5054         (extract_info_print_options): Delete declaration.
5055         (info_print_command_completer): Delete declaration.
5056         (info_print_args_help): Add extra parameter, extend header
5057         comment.
5058         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5059         search_symbols.
5060         * stack.c (struct info_print_options): New type.
5061         (info_print_options_defs): New file scoped variable.
5062         (make_info_print_options_def_group): New static function.
5063         (info_print_command_completer): New static function.
5064         (info_locals_command): Update to use new local functions.
5065         (info_args_command): Likewise.
5066         (_initialize_stack): Add extra parameter to calls to
5067         info_print_args_help.
5068         * symtab.c (search_symbols): Add extra parameter, use this to
5069         possibly excluse non-debug symbols.
5070         (symtab_symbol_info): Add extra parameter, which is passed on to
5071         search_symbols.
5072         (struct info_print_options): New type.
5073         (info_print_options_defs): New file scoped variable.
5074         (make_info_print_options_def_group): New static function.
5075         (info_print_command_completer): New static function.
5076         (info_variables_command): Update to use local functions, and pass
5077         extra parameter through to symtab_symbol_info.
5078         (info_functions_command): Likewise.
5079         (info_types_command): Pass additional argument through to
5080         symtab_symbol_info.
5081         (rbreak_command): Pass extra argument to search_symbols.
5082         (_initialize_symtab): Add extra arguments for calls to
5083         info_print_args_help, and update help text for 'info variables',
5084         'whereis', and 'info functions' commands.
5085         * symtab.h (search_symbols): Add extra argument to declaration.
5086         * NEWS: Mention new flags.
5087
5088 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5089
5090         * symtab.c (lookup_static_symbol): Call the new function (and move
5091         it down to be next to lookup_global_symbol).
5092         (struct global_sym_lookup_data): Add block_enum member and rename to...
5093         (struct global_or_static_sym_lookup_data): ...this.
5094         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5095         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5096         (lookup_symbol_global_or_static_iterator_cb): ...this.
5097         (lookup_global_or_static_symbol): New function.
5098         (lookup_global_symbol): Call new function.
5099
5100 2019-08-26  Tom de Vries  <tdevries@suse.de>
5101
5102         PR c++/24852
5103         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5104         when pc_probe.prob == NULL.
5105
5106 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5107
5108         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5109         variable symbol_linkage to symbol_linkage_.
5110
5111 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5112
5113         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5114         represent whether the symbol is static, dynamic, or we don't
5115         know.
5116
5117 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5118
5119         * gdb/rx-tdep.c (rx_register_names): New.
5120         (rx_register_name): Delete.
5121         (rx_psw_type): Delete.
5122         (rx_fpsw_type): Delete.
5123         (rx_register_type): Delete.
5124         (rx_gdbarch_init): Convert target-descriptions.
5125         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5126         * gdb/features/Makefile: Add rx.xml.
5127         * gdb/features/rx.xml: New.
5128         * gdb/features/rx.c: Generated.
5129         * gdb/NEWS: Mention target description support.
5130
5131 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5132
5133         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5134         *slot_ptr.
5135
5136 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5137
5138         * configure.ac: Don't check for 'dlfcn.h' (moved to
5139         gdbsupport/common.m4).
5140         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5141         'gdbsupport/'.
5142         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5143         * compile/compile-c-support.c: Include
5144         'gdbsupport/gdb-dlfcn.h'.
5145         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5146         * gdb-dlfcn.c: Move to...
5147         * gdbsupport/gdb-dlfcn.c: ... here.
5148         * gdb-dlfcn.h: Move to...
5149         * gdbsupport/gdb-dlfcn.h: ... here.
5150
5151 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5152
5153         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5154         the offset field signed.
5155
5156 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5157
5158         * python/lib/gdb/__init__.py (_execute_file): New function.
5159         * python/python.c (python_run_simple_file): Call gdb._execute_file
5160         on Windows.
5161
5162 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5163
5164         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5165         all uses as this was never set to anything but a zero value.
5166
5167 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5168
5169         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5170
5171 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5172
5173         * tui/tui-data.h (tui_gen_win_info): Add an =default
5174         move constructor, required by some GCC versions.
5175
5176 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5177
5178         * go32-nat.c (go32_sysinfo): Add hygon_p.
5179
5180 2019-08-20  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5183         line_from_reg_element_no, first_reg_element_no_inline,
5184         display_all_data, delete_data_content_windows,
5185         erase_data_content>: Now private.
5186
5187 2019-08-20  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5190         (tui_unhighlight_win, tui_highlight_win)
5191         (tui_win_info::make_window): Update.
5192         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5193
5194 2019-08-20  Tom Tromey  <tom@tromey.com>
5195
5196         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5197         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5198         (MAX_PID_WIDTH): Move to tui-stack.c.
5199         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5200         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5201         (MAX_PID_WIDTH): Move from tui-data.h.
5202
5203 2019-08-20  Tom Tromey  <tom@tromey.com>
5204
5205         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5206         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5207         (box_win): Update.
5208         (tui_gen_win_info::make_window): Rename from tui_make_window.
5209         (tui_win_info::make_window): New method.
5210         (tui_gen_win_info::make_visible): Update.
5211         * tui/tui-source.c (tui_source_window::set_contents): Update.
5212         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5213         (tui_data_window::display_registers_from): Update.
5214         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5215         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5216         Declare.
5217         <can_box>: Remove.
5218         <title>: Remove.
5219         (struct tui_win_info) <make_window>: Declare.
5220         <can_box>: Now virtual.
5221         <title>: New member.
5222         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5223         * tui/tui-command.c (tui_cmd_window::resize): Update.
5224
5225 2019-08-20  Tom Tromey  <tom@tromey.com>
5226
5227         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5228         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5229         (tui_data_window::check_register_values): Update.
5230
5231 2019-08-20  Tom Tromey  <tom@tromey.com>
5232
5233         * tui/tui-regs.h (struct tui_data_window): Use
5234         DISABLE_COPY_AND_ASSIGN.
5235         <regs_content>: Change type, removing unique_ptr.
5236         <tui_data_window>: Add move constructor.
5237         * tui/tui-regs.c (tui_data_window::show_registers)
5238         (tui_data_window::show_register_group)
5239         (tui_data_window::display_registers_from)
5240         (tui_data_window::display_registers_from)
5241         (tui_data_window::first_data_item_displayed)
5242         (tui_data_window::delete_data_content_windows)
5243         (tui_data_window::rerender, tui_data_window::refresh_window)
5244         (tui_data_window::check_register_values): Update.
5245
5246 2019-08-20  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5249         show_register_group>: Declare.
5250         (tui_show_register_group): Don't declare.
5251         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5252         tui_show_registers.
5253         (tui_data_window::show_register_group): Rename from
5254         tui_show_register_group.
5255         (tui_data_window::check_register_values, tui_reg_command):
5256         Update.
5257         * tui/tui-layout.c (tui_set_layout): Update.
5258
5259 2019-08-20  Tom Tromey  <tom@tromey.com>
5260
5261         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5262         Declare.
5263         (tui_check_register_values): Don't declare.
5264         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5265         from tui_check_register_values.
5266         * tui/tui-hooks.c (tui_register_changed): Update.
5267
5268 2019-08-20  Tom Tromey  <tom@tromey.com>
5269
5270         * tui/tui-regs.c (tui_reg_layout): Move later.
5271         (tui_show_registers): Don't enable TUI mode or change layout.
5272
5273 2019-08-20  Tom Tromey  <tom@tromey.com>
5274
5275         * tui/tui-regs.h (struct tui_data_item_window)
5276         <~tui_data_item_window>: Remove.
5277         <content>: Now a unique_xmalloc_ptr.
5278         * tui/tui-regs.c (tui_register_format): Return a
5279         unique_xmalloc_ptr.
5280         (tui_get_register): Update.
5281         (~tui_data_item_window): Remove.
5282         (tui_data_window::display_registers_from, tui_display_register):
5283         Update.
5284         * tui/tui-io.h (tui_expand_tabs): Update.
5285         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5286         Remove "col" parameter.
5287
5288 2019-08-20  Tom Tromey  <tom@tromey.com>
5289
5290         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5291         field.
5292         * tui/tui-regs.c (~tui_data_item_window): Update.
5293
5294 2019-08-20  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5297         earlier.
5298
5299 2019-08-20  Tom Tromey  <tom@tromey.com>
5300
5301         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5302
5303 2019-08-20  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-source.h (struct tui_source_window): Update.
5306         * tui/tui-regs.c (tui_show_registers): Update.
5307         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5308         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5309         (NO_REGS_STRING): Remove defines.
5310
5311 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5312
5313         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5314         unnecessary thread walk if remote doesn't support the packet.
5315
5316 2019-08-19  Tom Tromey  <tromey@adacore.com>
5317
5318         * python/py-value.c (value_has_field): Fix indentation.
5319
5320 2019-08-19  Tom Tromey  <tromey@adacore.com>
5321
5322         * printcmd.c (do_one_display, info_display_command): Update.
5323         * block.h (contained_in): Return bool.  Add allow_nested
5324         parameter.
5325         * block.c (contained_in): Return bool.  Add allow_nested
5326         parameter.
5327
5328 2019-08-19  Tom Tromey  <tom@tromey.com>
5329
5330         * configure: Rebuild.
5331         * configure.ac: Disallow the combination of -static-libstdc++ and
5332         source highlight.
5333         * source-cache.c (get_language_name): Handle rust.
5334         (source_cache::get_source_lines): Ignore highlighting exceptions.
5335
5336 2019-08-16  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5339         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5340         (struct tui_source_window_base) <make_visible, refresh_window,
5341         resize>: Remove methods.
5342         <execution_info>: Remove field.
5343         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5344         (tui_show_source_line, tui_source_window_base)
5345         (~tui_source_window_base): Update.
5346         (tui_source_window_base::resize)
5347         (tui_source_window_base::make_visible)
5348         (tui_source_window_base::refresh_window): Remove.
5349         (tui_source_window_base::update_exec_info): Update.
5350         * tui/tui-source.c (tui_source_window::set_contents): Update.
5351         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5352
5353 2019-08-16  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5356         deprecated_query_hook.
5357
5358 2019-08-16  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5361         (tui_update_source_windows_with_line): Update.
5362         * tui/tui-source.h (struct tui_source_window)
5363         <show_symtab_source>: Declare.
5364         (tui_show_symtab_source): Don't declare.
5365         * tui/tui-source.c (tui_show_symtab_source): Rename from
5366         tui_show_symtab_source.
5367
5368 2019-08-16  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-winsource.h (struct tui_source_window_base)
5371         <set_contents>: Declare.
5372         * tui/tui-winsource.c
5373         (tui_source_window_base::update_source_window_as_is): Update.
5374         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5375         Declare.
5376         (tui_set_source_content): Don't declare.
5377         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5378         tui_set_source_content.
5379         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5380         Declare.
5381         (tui_set_disassem_content): Don't declare.
5382         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5383         tui_set_disassem_content.
5384
5385 2019-08-16  Tom Tromey  <tom@tromey.com>
5386
5387         * tui/tui-winsource.h (struct tui_source_window_base)
5388         <update_breakpoint_info>: Declare.
5389         (tui_update_breakpoint_info): Don't declare.
5390         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5391         (tui_update_all_breakpoint_info): Update.
5392         (tui_source_window_base::update_breakpoint_info): Rename from
5393         tui_update_breakpoint_info.
5394         (tui_source_window_base::update_exec_info): Update.
5395
5396 2019-08-16  Tom Tromey  <tom@tromey.com>
5397
5398         * tui/tui-winsource.h (struct tui_source_window_base)
5399         <update_source_window>: Declare.
5400         (tui_update_source_window): Don't declare.
5401         * tui/tui-winsource.c
5402         (tui_source_window_base::update_source_window): Rename from
5403         tui_update_source_window.
5404         (tui_source_window_base::rerender): Update.
5405         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5406         * tui/tui-disasm.c (tui_show_disassem)
5407         (tui_show_disassem_and_update_source)
5408         (tui_disasm_window::maybe_update): Update.
5409
5410 2019-08-16  Tom Tromey  <tom@tromey.com>
5411
5412         * tui/tui-winsource.h (struct tui_source_window_base)
5413         <update_source_window_as_is>: Declare.
5414         (tui_update_source_window_as_is): Don't declare.
5415         * tui/tui-winsource.c (tui_update_source_window): Update
5416         (tui_source_window_base::update_source_window_as_is): Rename from
5417         tui_update_source_window_as_is.
5418         (tui_source_window_base::refill): Update.
5419         * tui/tui-source.c (tui_show_symtab_source): Update.
5420         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5421         Update.
5422
5423 2019-08-16  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-winsource.h (tui_update_source_window)
5426         (tui_update_source_window_as_is): Remove "noerror" parameter.
5427         * tui/tui-winsource.c (tui_update_source_window)
5428         (tui_update_source_window_as_is): Remove "noerror" parameter.
5429         (tui_update_source_windows_with_addr)
5430         (tui_update_source_windows_with_line)
5431         (tui_source_window_base::rerender)
5432         (tui_source_window_base::refill): Update.
5433         * tui/tui-source.h (tui_set_source_content)
5434         (tui_show_symtab_source): Remove "noerror" parameter.
5435         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5436         parameter.
5437         (tui_show_symtab_source): Likewise.
5438         (tui_source_window::maybe_update): Update.
5439         * tui/tui-disasm.c (tui_show_disassem)
5440         (tui_show_disassem_and_update_source)
5441         (tui_disasm_window::do_scroll_vertical)
5442         (tui_disasm_window::maybe_update): Update.
5443
5444 2019-08-16  Tom Tromey  <tom@tromey.com>
5445
5446         * tui/tui.c (tui_is_window_visible): Update.
5447         * tui/tui-wingeneral.c (tui_make_window)
5448         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5449         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5450         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5451         (tui_set_win_height_command, parse_scrolling_args): Update.
5452         * tui/tui-source.c (tui_source_window::style_changed): Update.
5453         * tui/tui-regs.c (tui_show_registers)
5454         (tui_data_window::first_data_item_displayed)
5455         (tui_data_window::delete_data_content_windows)
5456         (tui_check_register_values, tui_reg_command): Update.
5457         * tui/tui-disasm.c (tui_show_disassem): Update.
5458         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5459         method.
5460         <is_visible>: Remove field.
5461         * tui/tui-data.c (tui_next_win, tui_prev_win)
5462         (tui_delete_invisible_windows): Update.
5463
5464 2019-08-16  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-winsource.h (struct tui_source_window_base)
5467         <m_has_locator>: Remove.
5468         * tui/tui-layout.c (show_source_disasm_command, show_data)
5469         (show_source_or_disasm_and_command): Update.
5470
5471 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5472
5473         * NEWS (Other MI changes): New subsection.
5474         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5475         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5476         * arch-utils.c (default_get_pc_address_flags): New function.
5477         * arch-utils.h (default_get_pc_address_flags): New declaration.
5478         * gdbarch.sh: Add get_pc_address_flags.
5479         * gdbarch.c: Regenerate.
5480         * gdbarch.h: Likewise.
5481         * stack.c (print_pc): New function.
5482         (print_frame_info) (print_frame): Call print_pc.
5483
5484 2019-08-16  Tom de Vries  <tdevries@suse.de>
5485
5486         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5487         print_objfile_section_info.
5488
5489 2019-08-15  Tom Tromey  <tom@tromey.com>
5490
5491         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5492         calling update_cmdwin_start_line.
5493         * tui/tui-winsource.h (struct tui_source_window_base)
5494         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5495         <rerender>: Declare.
5496         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5497         Call rerender.
5498         (tui_source_window_base::set_new_height): Remove.
5499         (tui_source_window_base::rerender): Rename from
5500         do_make_visible_with_new_height.
5501         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5502         resize method.
5503         (tui_win_info::make_invisible_and_set_new_height)
5504         (tui_win_info::make_visible_with_new_height): Remove.
5505         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5506         Declare.
5507         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5508         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5509         do_make_visible_with_new_height>: Don't declare.
5510         <rerender>: Declare.
5511         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5512         set_new_height.
5513         (tui_data_window::do_make_visible_with_new_height): Remove.
5514         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5515         call tui_show_locator_content.
5516         (tui_gen_win_info::resize): Call rerender.
5517         (show_source_or_disasm_and_command): Don't call
5518         tui_show_locator_content.
5519         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5520         method.
5521         (struct tui_win_info) <rerender>: Declare.
5522         <set_new_height, make_invisible_and_set_new_height,
5523         make_visible_with_new_height>: Don't declare.
5524         * tui/tui-data.c (tui_win_list::rerender): New method.
5525         * tui/tui-command.h (struct tui_cmd_window)
5526         <do_make_visible_with_new_height>: Don't declare.
5527         * tui/tui-command.c
5528         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5529
5530 2019-08-15  Tom Tromey  <tromey@adacore.com>
5531
5532         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5533         * ada-lang.c (ada_enum_name): Likewise.
5534
5535 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5536
5537         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5538         leading underscore.
5539         (GdbOutputErrorFile): Likewise.
5540         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5541         accordingly.
5542         (execute_unwinders): Rename to have a leading underscore.
5543         (auto_load_packages): Likewise.
5544         (global scope): Adjust call to auto_load_packages accordingly.
5545         (GdbSetPythonDirectory): Likewise.
5546         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5547         instead of execute_unwinders.
5548
5549 2019-08-15  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5552         (show_data): Don't change window visibility.
5553         (tui_gen_win_info::resize): Remove special case for command
5554         window.  Use wresize, when available.
5555         (show_source_or_disasm_and_command): Don't change window
5556         visibility.
5557         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5558         <make_visible>: New method.
5559         * tui/tui-command.c (tui_cmd_window::resize): New method.
5560
5561 2019-08-15  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5564         (struct tui_source_windows): New.
5565         * tui/tui-winsource.c (tui_display_main): Update.
5566         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5567         (new_height_ok, parse_scrolling_args): Update.
5568         * tui/tui-layout.c (show_layout, show_data): Update.
5569         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5570         (tui_add_to_source_windows): Don't declare.
5571         * tui/tui-data.c (source_windows, tui_source_windows)
5572         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5573
5574 2019-08-15  Tom Tromey  <tom@tromey.com>
5575
5576         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5577         Rename from reset.
5578         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5579         * tui/tui-layout.c (show_source_disasm_command, show_data):
5580         Update.
5581         (tui_gen_win_info::resize): Rename.
5582         (show_source_or_disasm_and_command): Update.
5583         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5584         reset.
5585
5586 2019-08-15  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5589         * tui/tui-interp.c (tui_interp::init): Don't call
5590         tui_initialize_static_data.
5591         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5592
5593 2019-08-15  Tom Tromey  <tom@tromey.com>
5594
5595         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5596         examine tui_win_list.
5597
5598 2019-08-15  Tom Tromey  <tom@tromey.com>
5599
5600         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5601         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5602         tui_clear_source_content.
5603         (tui_clear_source_content): Remove.
5604         (tui_source_window_base::do_erase_source_content): Hoist call to
5605         content.clear().
5606         * tui/tui-stack.c (tui_show_frame_info): Don't call
5607         tui_clear_source_content.
5608
5609 2019-08-15  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-winsource.h (struct tui_source_window_base)
5612         <do_erase_source_content>: New method.
5613         <erase_source_content>: New method.
5614         (tui_erase_source_content): Don't declare.
5615         * tui/tui-winsource.c (tui_clear_source_content): Update.
5616         (tui_source_window_base::do_erase_source_content): Rename from
5617         tui_erase_source_content.
5618         (tui_source_window_base::show_source_content): Update.
5619         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5620         * tui/tui-source.h (struct tui_source_window)
5621         <erase_source_content>: New method.
5622         * tui/tui-disasm.h (struct tui_disasm_window)
5623         <erase_source_content>: New method.
5624
5625 2019-08-15  Tom Tromey  <tom@tromey.com>
5626
5627         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5628         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5629         constructor.
5630         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5631         * tui/tui-source.c (tui_set_source_content): Update.
5632         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5633
5634 2019-08-15  Tom Tromey  <tom@tromey.com>
5635
5636         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5637         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5638         tui-source.c.
5639         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5640         Declare.
5641         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5642         method.
5643         (tui_source_window::maybe_update): Update.
5644
5645 2019-08-15  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5648         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5649         tui-disasm.c.
5650         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5651         Declare.
5652         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5653         method.
5654         (tui_disasm_window::maybe_update): Update.
5655
5656 2019-08-15  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui-winsource.h (struct tui_source_window_base)
5659         <maybe_update>: Declare.
5660         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5661         method.
5662         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5663         Declare.
5664         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5665         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5666         Declare.
5667         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5668
5669 2019-08-15  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5672
5673 2019-08-15  Tom Tromey  <tom@tromey.com>
5674
5675         * tui/tui-wingeneral.c: Include tui-stack.h.
5676         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5677         (struct tui_locator_window): Move from tui-data.h.
5678         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5679         (tui_initialize_static_data): Move from tui-data.c.
5680         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5681         (struct tui_locator_window): Move to tui-stack.c.
5682         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5683         (tui_initialize_static_data): Move to tui-stack.c.
5684
5685 2019-08-15  Tom Tromey  <tom@tromey.com>
5686
5687         * tui/tui-layout.c (show_source_disasm_command)
5688         (show_source_or_disasm_and_command): Use make_visible method, not
5689         tui_make_window.
5690         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5691         Remove.
5692
5693 2019-08-15  Tom Tromey  <tom@tromey.com>
5694
5695         * tui/tui-wingeneral.h (tui_make_window): Update.
5696         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5697         parameter.
5698         (tui_gen_win_info::make_visible): Update.
5699         * tui/tui-regs.c (tui_data_window::display_registers_from):
5700         Update.
5701         * tui/tui-layout.c (show_source_disasm_command)
5702         (show_source_or_disasm_and_command): Update.
5703         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5704         (enum tui_box): Remove.
5705         (struct tui_win_info) <can_box>: New method.
5706         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5707         method.
5708
5709 2019-08-15  Tom de Vries  <tdevries@suse.de>
5710
5711         * linux-nat-trad.c: Include gdbarch.h.
5712
5713 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5714
5715         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5716         register sizes.
5717
5718 2019-08-14  Tom Tromey  <tromey@adacore.com>
5719
5720         * darwin-nat.c: Include gdbarch.h.
5721         * darwin-nat-info.c: Include gdbarch.h.
5722
5723 2019-08-13  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5726         Remove.
5727         * tui/tui-data.c (tui_initialize_static_data): Update.
5728
5729 2019-08-13  Tom Tromey  <tom@tromey.com>
5730
5731         * tui/tui-winsource.h (struct tui_exec_info_window)
5732         <~tui_exec_info_window, maybe_allocate_content, get_content,
5733         m_content>: Remove.
5734         (struct tui_source_window_base) <set_exec_info_content,
5735         show_exec_info_content>: Don't declare.
5736         * tui/tui-winsource.c
5737         (tui_exec_info_window::maybe_allocate_content): Remove.
5738         (tui_source_window_base::update_exec_info): Rename from
5739         set_exec_info_content.
5740         (tui_source_window_base::show_exec_info_content)
5741         (tui_source_window_base::update_exec_info): Remove.
5742
5743 2019-08-13  Tom Tromey  <tom@tromey.com>
5744
5745         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5746         declare.
5747         * tui/tui-winsource.c (tui_update_source_window_as_is)
5748         (tui_update_source_windows_with_addr, tui_erase_source_content):
5749         Update.
5750         (tui_clear_exec_info_content): Remove.
5751
5752 2019-08-13  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5755         declare.
5756         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5757         call tui_erase_exec_info_content.
5758         (tui_clear_exec_info_content): Rename from
5759         tui_erase_exec_info_content.
5760         (tui_clear_exec_info_content): Delete.
5761
5762 2019-08-13  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-winsource.h (struct tui_source_window_base)
5765         <show_exec_info_content>: Declare.
5766         (tui_show_exec_info_content): Don't declare.
5767         * tui/tui-winsource.c
5768         (tui_source_window_base::show_exec_info_content): Rename from
5769         tui_show_exec_info_content.
5770         (tui_source_window_base::update_exec_info): Update.
5771
5772 2019-08-13  Tom Tromey  <tom@tromey.com>
5773
5774         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5775         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5776         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5777         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5778         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5779         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5780         ... here.
5781
5782 2019-08-13  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-winsource.h (struct tui_source_window_base)
5785         <update_exec_info>: Declare.
5786         (tui_update_exec_info): Don't declare.
5787         * tui/tui-winsource.c (tui_update_source_window_as_is)
5788         (tui_source_window_base::refresh_all)
5789         (tui_update_all_breakpoint_info): Update.
5790         (tui_source_window_base::update_exec_info): Rename from
5791         tui_update_exec_info.
5792         * tui/tui-stack.c (tui_show_frame_info): Update.
5793
5794 2019-08-13  Tom Tromey  <tom@tromey.com>
5795
5796         * tui/tui-winsource.h (struct tui_source_window_base)
5797         <set_exec_info_content>: Declare.
5798         (tui_set_exec_info_content): Don't declare.
5799         * tui/tui-winsource.c
5800         (tui_source_window_base::set_exec_info_content): Rename from
5801         tui_set_exec_info_content.
5802         (tui_update_exec_info): Update.
5803
5804 2019-08-13  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-winsource.h (struct tui_source_window_base)
5807         <show_source_content>: Declare.
5808         (tui_show_source_content): Don't declare.
5809         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5810         (tui_source_window_base::show_source_content): Rename from
5811         tui_show_source_content.
5812         (tui_source_window_base::refresh_all): Update.
5813         * tui/tui-layout.c (show_source_disasm_command)
5814         (show_source_or_disasm_and_command): Update.
5815
5816 2019-08-13  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-winsource.c (tui_erase_source_content)
5819         (tui_show_source_content, tui_source_window_base::refresh_all):
5820         Update.
5821         * tui/tui-wingeneral.h
5822         (tui_check_and_display_highlight_if_needed): Don't declare.
5823         * tui/tui-wingeneral.c
5824         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5825         check_and_display_highlight_if_needed.
5826         * tui/tui-win.c (tui_rehighlight_all)
5827         (tui_win_info::make_visible_with_new_height): Update.
5828         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5829         (tui_data_window::erase_data_content)
5830         (tui_data_window::display_all_data): Update.
5831         * tui/tui-data.h (struct tui_win_info)
5832         <check_and_display_highlight_if_needed>: Declare.
5833
5834 2019-08-13  Tom Tromey  <tom@tromey.com>
5835
5836         * tui/tui-win.c (tui_resize_all): Call
5837         tui_delete_invisible_windows.
5838         * tui/tui-layout.c (show_layout): Call
5839         tui_delete_invisible_windows.
5840         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5841         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5842
5843 2019-08-13  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5846         tui_add_win_to_layout.
5847
5848 2019-08-13  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5851         * tui/tui-layout.c (tui_default_win_height): Now static.
5852
5853 2019-08-13  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5856         single switch.
5857         (show_source_disasm_command, show_source_or_disasm_and_command):
5858         Don't check current layout.
5859
5860 2019-08-13  Tom Tromey  <tom@tromey.com>
5861
5862         * tui/tui-wingeneral.c (make_all_visible): Remove.
5863         (tui_make_all_invisible): Simplify.
5864         * tui/tui-layout.c (tui_make_all_invisible): Move from
5865         tui-wingeneral.c; simplify.
5866         (show_layout): Hoist call to tui_make_all_invisible.
5867         (show_data): Don't call tui_make_all_invisible.
5868
5869 2019-08-13  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5872         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5873
5874 2019-08-13  Tom Tromey  <tom@tromey.com>
5875
5876         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5877         tui-data.c.
5878         (show_source_disasm_command, show_data)
5879         (show_source_or_disasm_and_command): Don't use
5880         tui_set_current_layout_to.
5881         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5882         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5883         tui-layout.c.
5884         (tui_set_current_layout_to): Remove.
5885
5886 2019-08-13  Tom Tromey  <tom@tromey.com>
5887
5888         * tui/tui-layout.c (tui_set_layout): Update.
5889         * tui/tui-data.h (struct tui_layout_def): Remove.
5890         (tui_layout_def): Don't declare.
5891         * tui/tui-data.c (layout_def): Remove.
5892         (tui_layout_def): Remove.
5893
5894 2019-08-13  Tom Tromey  <tom@tromey.com>
5895
5896         * tui/tui-winsource.h (struct tui_source_window_base)
5897         <clear_detail>: No longer "override".
5898         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5899         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5900         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5901         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5902         Remove.
5903         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5904
5905 2019-08-13  Tom Tromey  <tromey@adacore.com>
5906
5907         * tracepoint.c: Don't include readline.h or history.h.
5908
5909 2019-08-12  Tom Tromey  <tom@tromey.com>
5910
5911         * configure: Rebuild.
5912         * configure.ac: Check for readline 7.
5913         * NEWS: Mention readline 7 requirement.
5914         * README: Update.
5915
5916 2019-08-12  Tom Tromey  <tom@tromey.com>
5917
5918         * mingw-hdep.c (gdb_select): Remove readline hack.
5919
5920 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5921
5922         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5923         when the function fails.
5924
5925 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5926
5927         * s390-tdep.c (s390_type_align): New function.
5928         (s390_gdbarch_init): Set it as type_align gdbarch method.
5929
5930 2019-08-09  Tom de Vries  <tdevries@suse.de>
5931
5932         PR gdb/24591
5933         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5934         pc_low with relocation offset.
5935
5936 2019-08-07  Tom Tromey  <tromey@adacore.com>
5937
5938         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5939         (print_frame_args): Update.
5940         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5941         Update.
5942         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5943         * frame.h (struct frame_arg): Add initializers.
5944         <error>: Now a unique_xmalloc_ptr.
5945
5946 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5947
5948         * NEWS: Expand the Pointer Authentication entry.
5949         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5950         (aarch64_frame_unmask_lr): ... to this.
5951         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5952         Call aarch64_frame_unmask_lr.
5953         * frame.c (struct frame_info): Add "masked" variable.
5954         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5955         (fprint_frame): Check for masked pc.
5956         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5957         declarations.
5958         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5959         * stack.c (print_frame): Check for masked pc.
5960
5961 2019-08-06  Tom Tromey  <tom@tromey.com>
5962
5963         * stabsread.c (patch_block_stabs, read_one_struct_field)
5964         (read_enum_type): Use obstack_strndup.
5965         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5966         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5967         * dwarf2read.c (guess_full_die_structure_name)
5968         (anonymous_struct_prefix): Use obstack_strndup.
5969         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5970         * c-exp.y (yylex): Use obstack_strndup.
5971         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5972         (write_var_or_type): Use obstack_strndup.
5973
5974 2019-08-06  Tom Tromey  <tom@tromey.com>
5975
5976         * symfile.c (reread_symbols): Use obstack_strdup.
5977         * stabsread.c (read_type): Use obstack_strdup.
5978         * gdb_obstack.h (obstack_strdup): New overload.
5979         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5980         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5981         (dwarf2_canonicalize_name): Use obstack_strdup.
5982         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5983         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5984         Use obstack_strdup.
5985
5986 2019-08-06  Tom Tromey  <tom@tromey.com>
5987
5988         * gdb_obstack.h (obstack_strdup): Define.
5989         * gdb_obstack.c (obstack_strdup): Don't define.
5990
5991 2019-08-06  Tom Tromey  <tom@tromey.com>
5992
5993         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5994         obstack_strdup.
5995         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5996         obstack_strdup.
5997         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5998         * stabsread.c (common_block_start): Use obstack_strdup.
5999         * objfiles.c (set_objfile_main_name, objfile): Use
6000         obstack_strdup.
6001         * namespace.c (add_using_directive): Use obstack_strdup.
6002         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6003         * jit.c (finalize_symtab): Use obstack_strdup.
6004         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6005         (guess_partial_die_structure_name, partial_die_info::fixup)
6006         (dwarf2_name): Use obstack_strdup.
6007         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6008         obstack_strdup.
6009         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6010         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6011         obstack_strdup.
6012         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6013
6014 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6015
6016         * unittests/help-doc-selftests.c: New file.
6017         * Makefile.in: Add the new file.
6018
6019 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6020
6021         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6022         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6023         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6024         the trailing '.' is not output, and the first character is uppercased.
6025         (print_help_for_command): Update call to print_doc_line.
6026         (print_doc_of_command): Likewise.
6027         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6028         * cli/cli-option.c (append_indented_doc): Do not append newline.
6029         (build_help_option): Append newline after first appended_indented_doc
6030         only if a second call is done.
6031         (build_help): Append 2 new lines before each option, except the first
6032         one.
6033         * compile/compile.c (_initialize_compile): Add new lines after
6034         %OPTIONS%, when not at the end of the help.
6035         Change help doc or code
6036         producing the help doc to respect the invariants.
6037         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6038         Also removed the new line after 'Options:', as all other commands
6039         do not put an empty line between 'Options:' and the first option.
6040         * printcmd.c (_initialize_printcmd): Likewise.
6041         * stack.c (_initialize_stack): Likewise.
6042         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6043         incorrectly telling COMMAND is optional.
6044         * ada-lang.c (_initialize_ada_language): Change help doc or code
6045         producing the help doc to respect the invariants.
6046         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6047         * breakpoint.c (_initialize_breakpoint): Likewise.
6048         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6049         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6050         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6051         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6052         _initialize_cli_style): Likewise.
6053         * corelow.c (core_target_info): Likewise.
6054         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6055         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6056         * filesystem.c (_initialize_filesystem): Likewise.
6057         * frame.c (_initialize_frame): Likewise.
6058         * gnu-nat.c (add_task_commands): Likewise.
6059         * infcall.c (_initialize_infcall): Likewise.
6060         * infcmd.c (_initialize_infcmd): Likewise.
6061         * interps.c (_initialize_interpreter): Likewise.
6062         * language.c (_initialize_language): Likewise.
6063         * linux-fork.c (_initialize_linux_fork): Likewise.
6064         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6065         * maint.c (_initialize_maint_cmds): Likewise.
6066         * memattr.c (_initialize_mem): Likewise.
6067         * printcmd.c (_initialize_printcmd): Likewise.
6068         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6069         _RegEx): Likewise.
6070         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6071         * record-btrace.c (_initialize_record_btrace): Likewise.
6072         * record-full.c (_initialize_record_full): Likewise.
6073         * record.c (_initialize_record): Likewise.
6074         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6075         * regcache.c (_initialize_regcache): Likewise.
6076         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6077         _initialize_remote): Likewise.
6078         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6079         * serial.c (_initialize_serial): Likewise.
6080         * skip.c (_initialize_step_skip): Likewise.
6081         * source.c (_initialize_source): Likewise.
6082         * stack.c (_initialize_stack): Likewise.
6083         * symfile.c (_initialize_symfile): Likewise.
6084         * symtab.c (_initialize_symtab): Likewise.
6085         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6086         * top.c (init_main): Likewise.
6087         * tracefile-tfile.c (tfile_target_info): Likewise.
6088         * tracepoint.c (_initialize_tracepoint): Likewise.
6089         * tui/tui-win.c (_initialize_tui_win): Likewise.
6090         * utils.c (add_internal_problem_command): Likewise.
6091         * valprint.c (value_print_option_defs): Likewise.
6092
6093 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6094
6095         PR build/24886
6096         * configure.ac: Drop enable-libmcheck support.
6097         * configure, config.in: Rebuild.
6098         * libmcheck.m4: Remove.
6099         * acinclude.m4: Don't include it.
6100         * Makefile.in: Don't distribute it.
6101         * top.c (print_gdb_configuration): Don't mention it.
6102
6103 2019-08-06  Tom Tromey  <tom@tromey.com>
6104
6105         * utils.c (set_output_style): Sometimes pass stream to
6106         emit_style_escape.
6107         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6108         * record-btrace.c (btrace_insn_history): Update.
6109         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6110         method.
6111         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6112         Update initializers.
6113         <m_uiout>: New field.
6114         <m_di>: Move lower.
6115         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6116         Remove "uiout" parameter.
6117         (dump_insns): Update.
6118         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6119         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6120
6121 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6122
6123         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6124         (error_in_psymtab_expansion): Likewise.
6125         (lookup_symbol_via_quick_fns): Likewise.
6126         (basic_lookup_transparent_type_quick): Likewise.
6127         (basic_lookup_transparent_type_1): Likewise.
6128
6129 2019-08-06  Tom Tromey  <tromey@adacore.com>
6130
6131         * source.c (last_source_error): Now bool.
6132         (print_source_lines_base): Make "noprint" bool.  Only open
6133         source file when last_source_visited changes.
6134
6135 2019-08-06  Tom Tromey  <tromey@adacore.com>
6136
6137         * annotate.c (annotate_source_line): Use g_source_cache.
6138         * source-cache.c (source_cache::get_plain_source_lines): Change
6139         parameters.  Populate m_offset_cache.
6140         (source_cache::ensure): New method.
6141         (source_cache::get_line_charpos): New method.
6142         (extract_lines): Move lower.  Change parameters.
6143         (source_cache::get_source_lines): Move lower.
6144         * source-cache.h (class source_cache): Update comment.
6145         <get_line_charpos>: New method.
6146         <get_source_lines>: Update comment.
6147         <clear>: Clear m_offset_cache.
6148         <get_plain_source_lines>: Change parameters.
6149         <ensure>: New method
6150         <m_offset_cache>: New member.
6151         * source.c (forget_cached_source_info_for_objfile): Update.
6152         (info_source_command): Use g_source_cache.
6153         (find_source_lines, open_source_file_with_line_charpos): Remove.
6154         (print_source_lines_base, search_command_helper): Use g_source_cache.
6155         * source.h (open_source_file_with_line_charpos): Don't declare.
6156         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6157         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6158         Use g_source_cache.
6159
6160 2019-08-06  Tom Tromey  <tromey@adacore.com>
6161
6162         * source-cache.c (source_cache::get_plain_source_lines):
6163         Remove "first_line" and "last_line" parameters.
6164         (source_cache::get_source_lines): Cache plain text.
6165         * source-cache.h (class source_cache)
6166         <get_plain_source_lines>: Update.
6167
6168 2019-08-06  Tom Tromey  <tromey@adacore.com>
6169
6170         * source-cache.c (extract_lines): No longer a method.
6171         Changed type of parameter.  Include final newline.
6172         (selftests::extract_lines_test): New function.
6173         (_initialize_source_cache): Likewise.
6174         * source-cache.h (class source_cache)
6175         <extract_lines>: Don't declare.
6176
6177 2019-08-06  Tom Tromey  <tromey@adacore.com>
6178
6179         * breakpoint.c (init_breakpoint_sal): Update.
6180         (breakpoint): Update.
6181         * breakpoint.h (struct breakpoint) <filter>: Now a
6182         unique_xmalloc_ptr.
6183
6184 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6185
6186         * NEWS: Mention dictionary access on blocks.
6187         * python/py-block.c (blpy_getitem): New function.
6188         (block_object_as_mapping): New struct.
6189         (block_object_type): Use new struct for tp_as_mapping field.
6190
6191 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6192
6193         * objfiles.h (objfile): Add a comment describing partial symbols.
6194
6195 2019-08-05  Tom Tromey  <tromey@adacore.com>
6196
6197         * compile/compile.c (_initialize_compile): Use _(), not N_().
6198         * thread.c (_initialize_thread): Use _(), not N_().
6199         * stack.c (_initialize_stack): Use _(), not N_().
6200         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6201
6202 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6203
6204         * dwarf2read.c (struct dw2_symtab_iterator):
6205         <want_specific_block>: Remove.
6206         <block_index>: Change type to gdb::optional.
6207         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6208         change type of BLOCK_INDEX parameter to gdb::optional.
6209         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6210         (dw2_lookup_symbol): Don't pass argument for
6211         WANT_SPECIFIC_BLOCK.
6212         (dw2_expand_symtabs_for_function): Don't pass argument for
6213         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6214         (class dw2_debug_names_iterator)
6215         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6216         parameter, change BLOCK_INDEX type to gdb::optional.
6217         <m_want_specific_block>: Remove.
6218         <m_block_index>: Change type to gdb::optional.
6219         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6220         gdb::optional.  Re-write in function of gdb::optional.
6221         (dw2_debug_names_lookup_symbol): Don't pass argument for
6222         WANT_SPECIFIC_BLOCK.
6223         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6224         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6225         BLOCK_INDEX.
6226
6227 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6228
6229         * NEWS: Mention changes to "info sources" command.
6230
6231 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * symtab.c (filename_partial_match_opts): New struct type.
6234         (struct output_source_filename_data): New members
6235         regexp, c_regexp, partial_match.
6236         (output_source_filename): Use new members to decide to print file.
6237         (info_sources_option_defs): New variable.
6238         (make_info_sources_options_def_group, print_info_sources_header,
6239         info_sources_command_completer):
6240         New functions.
6241         (info_sources_command): Read new optional arguments.
6242         (_initialize_symtab): Update info sources help.
6243
6244 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6245
6246         * ada-lang.c (exception_support_info_v0): Renamed from...
6247         (default_exception_support_info): ... this.  Create new
6248         definition for v1.
6249         (ada_has_this_exception_support): Look up catch_handlers_sym.
6250         (ada_exception_support_info_sniffer): Try v0 after default.
6251
6252 2019-08-01  Tom Tromey  <tromey@adacore.com>
6253
6254         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6255         gdbarch.h.
6256
6257 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6258
6259         * s12z-tdep.c: Fix include path for s12z-opc.h.
6260
6261 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6262
6263         * NEWS: Require GNU make 3.82.
6264
6265 2019-07-16  Tom Tromey  <tom@tromey.com>
6266
6267         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6268         declare.
6269
6270 2019-07-30  Tom Tromey  <tromey@adacore.com>
6271
6272         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6273
6274 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6275
6276         * printcmd.c (print_address_symbolic): Print negative offsets.
6277         (build_address_symbolic): Force signed arithmetic when computing
6278         offset.
6279
6280 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6281
6282         PR/24474: Add a function to lookup static variables.
6283         * NEWS: Mention this new function.
6284         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6285         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6286         * python/python.c (python_GdbMethods): Add new function.
6287
6288 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6289
6290         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6291         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6292         (objfpy_lookup_static_symbol): New function.
6293         (objfile_object_methods): Add new functions.
6294
6295 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6296
6297         * NEWS: Mention 'set|show print frame-info'.  Mention new
6298         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6299         backtrace argument.  Mention that python frame filtering code
6300         is now consistent with what 'backtrace' command prints.
6301
6302 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6303
6304         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6305         comments.
6306         (print_frame_info_auto, print_frame_info_source_line,
6307         print_frame_info_location, print_frame_info_source_and_location,
6308         print_frame_info_location_and_address, print_frame_info_short_location):
6309         New declarations.
6310         (struct frame_print_options): New member print_frame_info.
6311         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6312         * stack.h (get_user_print_what_frame_info): New declaration.
6313         (frame_show_address): New declaration.
6314         * stack.c (print_frame_arguments_choices): New value 'presence'.
6315         (print_frame_info_auto, print_frame_info_source_line,
6316         print_frame_info_location, print_frame_info_source_and_location,
6317         print_frame_info_location_and_address, print_frame_info_short_location,
6318         print_frame_info_choices, print_frame_info_print_what): New definitions.
6319         (print_frame_args): Only print dots for args if print frame-arguments
6320         is 'presence'.
6321         (frame_print_option_defs): New element for "frame-info".
6322         (get_user_print_what_frame_info): New function.
6323         (frame_show_address): Make non static.  Move comment to stack.h.
6324         (print_frame_info_to_print_what): New function.
6325         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6326         to decide what to print.
6327         (backtrace_command_1): Handle the new print_frame_arguments_presence
6328         value.
6329         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6330         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6331         (py_print_frame): In non-mi mode, use LOCATION as default for
6332         print_what, similarly to frame information printed directly by
6333         backtrace command. Handle frame-info user option in non MI mode.
6334
6335 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6336
6337         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6338         Add case for debugging 32-bit target on 64-bit host.  Revise
6339         comment.
6340
6341 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6342
6343         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6344         instead of find_function_entry_range_from_pc.
6345
6346 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6347
6348         * stack.c (find_frame_funname): Remove code which preferred
6349         minsym over symtab sym in "certain pathological cases".
6350
6351         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6352         parameter.  Change type of "do_demangle" to bool.
6353         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6354         Pass suitable "prefer_sym_over_minsym" flag to
6355         build_address_symbolic().  Don't output "+" for negative offsets.
6356         * printcmd.c (print_address_symbolic): Update invocation of
6357         build_address_symbolic to include a "prefer_sym_over_minsym"
6358         flag.
6359         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6360         Restrict cases in which use of minimal symbol is preferred to that
6361         of a found symbol.  Update comments.
6362
6363         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6364         for entry pc when entry pc is out of range for that FDE.
6365
6366 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6367
6368         PR gdb/24839:
6369         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6370         type.
6371
6372 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6373
6374         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6375         this function's Python signature.
6376
6377
6378 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6379
6380         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6381         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6382         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6383         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6384         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6385
6386
6387 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6388
6389         * h8300-tdep.c (h8300_register_name_common): New.
6390         h8300_register_name): Use h8300_register_name_common.
6391         (h8300s_register_name): Likewise.
6392         (h8300sx_register_name): Likewise.
6393         (h8300h_register_nam): New.
6394         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6395
6396
6397 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6398
6399         * arm-tdep.c (arm_skip_cmse_entry): New function.
6400         (arm_is_sgstubs_section): New function.
6401         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6402
6403 2019-07-22  Tom Tromey  <tom@tromey.com>
6404
6405         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6406         Don't self-assign.
6407
6408 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6411         type_print.
6412
6413 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6414
6415         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6416         so that GDB doesn't match any msymbols when searching in the
6417         TYPES_DOMAIN.
6418         (print_symbol_info): Print using typedef_print or type_print based
6419         on the type of the symbol.  Add updated FIXME comment moved from...
6420         (_initialize_symtab): ... move and update FIXME comment to above.
6421
6422 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * NEWS: Mention adding -q option to "info types".
6425         * symtab.c (struct info_types_options): New struct.
6426         (info_types_options_defs): New variable.
6427         (make_info_types_options_def_group): New function.
6428         (info_types_command): Use gdb::option framework to parse options.
6429         (info_types_command_completer): New function.
6430         (_initialize_symtab): Extend the help text on "info types" and
6431         register command completer.
6432
6433 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6434
6435         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6436         (lookup_symbol_in_objfile): Change int to block_enum and add a
6437         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6438
6439 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6440
6441         * MAINTAINERS (Write After Approval): Add self.
6442
6443 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6446         instruction to the dummy code region.
6447
6448 2019-07-19  Tom Tromey  <tromey@adacore.com>
6449
6450         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6451         (ARGSUSED, PARAMS, __func__): Remove rules.
6452
6453 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6454
6455         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6456         * features/arm/arm-with-iwmmxt.c: Remove.
6457         * features/arm/arm-with-iwmmxt.xml: Remove.
6458         * features/arm/arm-with-m-fpa-layout.c: Remove.
6459         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6460         * features/arm/arm-with-m-vfp-d16.c: Remove.
6461         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6462         * features/arm/arm-with-m.c: Remove.
6463         * features/arm/arm-with-m.xml: Remove.
6464         * features/arm/arm-with-neon.c: Remove.
6465         * features/arm/arm-with-neon.xml: Remove.
6466         * features/arm/arm-with-vfpv2.c: Remove.
6467         * features/arm/arm-with-vfpv2.xml: Remove.
6468         * features/arm/arm-with-vfpv3.c: Remove.
6469         * features/arm/arm-with-vfpv3.xml: Remove.
6470
6471 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6472
6473         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6474
6475 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6476
6477         * arch/aarch32.c (aarch32_create_target_description): Create
6478         target descriptions using features.
6479         * arch/arm.c (arm_create_target_description)
6480         (arm_create_mprofile_target_description): Likewise.
6481         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6482
6483 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6484
6485         * Makefile.in: Add new files.
6486         * aarch32-tdep.c: New file.
6487         * aarch32-tdep.h: New file.
6488         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6489         Call aarch32_read_description.
6490         * arch/aarch32.c: New file.
6491         * arch/aarch32.h: New file.
6492         * arch/arm.c (arm_create_target_description)
6493         (arm_create_mprofile_target_description): New function.
6494         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6495         (arm_create_target_description)
6496         (arm_create_mprofile_target_description): New declaration.
6497         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6498         read_description functions.
6499         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6500         Likewise.
6501         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6502         * arm-tdep.c (tdesc_arm_list): New variable.
6503         (arm_register_g_packet_guesses): Call create description functions.
6504         (arm_read_description) (arm_read_mprofile_description): New
6505         function.
6506         * arm-tdep.h (arm_read_description)
6507         (arm_read_mprofile_description): Add declaration.
6508         * configure.tgt: Add new files.
6509
6510 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6511
6512         * top.c (new_ui_command): Open specified terminal just once.
6513
6514 2019-07-18  Tom Tromey  <tromey@adacore.com>
6515
6516         * symtab.c (main_name): Constify return type.
6517         * symfile.c (set_initial_language): Update.
6518         * symtab.h (main_name): Constify return type.
6519
6520 2019-07-17  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-winsource.c (tui_update_source_window)
6523         (tui_update_source_window_as_is)
6524         (tui_update_source_windows_with_line): Remove return.
6525         * tui/tui-disasm.c (tui_show_disassem)
6526         (tui_show_disassem_and_update_source): Remove return.
6527         * tui/tui.c (tui_reset): Remove return.
6528         * tui/tui-wingeneral.c
6529         (tui_check_and_display_highlight_if_needed): Remove return.
6530
6531 2019-07-17  Tom Tromey  <tom@tromey.com>
6532
6533         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6534
6535 2019-07-17  Tom Tromey  <tom@tromey.com>
6536
6537         * tui/tui-winsource.h (struct tui_exec_info_window)
6538         (struct tui_source_window_base): Move from tui-data.h.
6539         * tui/tui-winsource.c: Move many method definitions from
6540         elsewhere.  Remove "structuring" comments.
6541         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6542         (tui_source_window_base::refresh_window): Move to
6543         tui-winsource.c.
6544         * tui/tui-win.c (tui_source_window_base::refresh_all)
6545         (tui_source_window_base::update_tab_width)
6546         (tui_source_window_base::set_new_height)
6547         (tui_source_window_base::do_make_visible_with_new_height): Move to
6548         tui-winsource.c.
6549         * tui/tui-source.h: Update.
6550         * tui/tui-source.c (tui_source_window_base::reset): Move to
6551         tui-winsource.c.
6552         * tui/tui-disasm.h: Update.
6553         * tui/tui-data.h (struct tui_exec_info_window): Move to
6554         tui-winsource.h.
6555         (struct tui_source_window_base): Likewise.
6556         * tui/tui-data.c (tui_source_window_base::clear_detail)
6557         (tui_source_window_base, ~tui_source_window_base): Move to
6558         tui-winsource.c.
6559
6560 2019-07-17  Tom Tromey  <tom@tromey.com>
6561
6562         * tui/tui-win.c (tui_resize_all)
6563         (tui_source_window_base::update_tab_width)
6564         (tui_adjust_win_heights): Update.
6565         (tui_win_info::make_invisible_and_set_new_height): Rename from
6566         make_invisible_and_set_new_height.
6567         * tui/tui-data.h (struct tui_win_info)
6568         <make_invisible_and_set_new_height>: New method.
6569
6570 2019-07-17  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui.c: Update.
6573         * tui/tui-source.h (struct tui_source_window): Move from
6574         tui-data.h.
6575         * tui/tui-layout.c: Update.
6576         * tui/tui-disasm.c: Update.
6577         * tui/tui-data.h (struct tui_source_window): Move to
6578         tui-source.h.
6579
6580 2019-07-17  Tom Tromey  <tom@tromey.com>
6581
6582         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6583         tui-data.h.
6584         * tui/tui-data.h (struct tui_disasm_window): Move to
6585         tui-disasm.h.
6586
6587 2019-07-17  Tom Tromey  <tom@tromey.com>
6588
6589         * tui/tui-regs.h (struct tui_data_item_window): Move from
6590         tui-data.h.
6591         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6592         * tui/tui-data.h (struct tui_data_item_window): Move to
6593         tui-regs.h.
6594         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6595
6596 2019-07-17  Tom Tromey  <tom@tromey.com>
6597
6598         * tui/tui.c: Update.
6599         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6600         (tui_cmd_window::max_height): Move to tui-command.c.
6601         * tui/tui-layout.c: Update.
6602         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6603         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6604         tui-command.c.
6605         * tui/tui-command.h (struct tui_cmd_window): Move from
6606         tui-data.h.
6607         * tui/tui-command.c: Remove "structuring" comments.
6608         (tui_cmd_window::clear_detail)
6609         (tui_cmd_window::do_make_visible_with_new_height)
6610         (tui_cmd_window::max_height): Move from elsewhere.
6611
6612 2019-07-17  Tom Tromey  <tom@tromey.com>
6613
6614         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6615         Now static.
6616         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6617         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6618
6619 2019-07-17  Tom Tromey  <tom@tromey.com>
6620
6621         * tui/tui.c: Update.
6622         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6623         tui-regs.c.
6624         * tui/tui-windata.h: Remove file.
6625         * tui/tui-windata.c: Remove file.
6626         * tui/tui-win.c (tui_data_window::set_new_height)
6627         (tui_data_window::do_make_visible_with_new_height): Move to
6628         tui-regs.c.
6629         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6630         * tui/tui-regs.c: Remove "structuring" comments.
6631         (tui_data_window::first_data_item_displayed)
6632         (tui_data_window::delete_data_content_windows)
6633         (tui_data_window::erase_data_content)
6634         (tui_data_window::display_all_data)
6635         (tui_data_window::refresh_all)
6636         (tui_data_window::do_scroll_vertical)
6637         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6638         (tui_data_window::do_make_visible_with_new_height)
6639         (tui_data_window::refresh_window): Move from elsewhere.
6640         (_initialize_tui_regs): Move to end of file.
6641         * tui/tui-layout.c: Update.
6642         * tui/tui-hooks.c: Update.
6643         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6644         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6645         tui-regs.c.
6646         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6647
6648 2019-07-17  Tom Tromey  <tom@tromey.com>
6649
6650         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6651         seen.
6652
6653 2019-07-17  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-win.c (tui_source_window_base::set_new_height)
6656         (tui_source_window_base::do_make_visible_with_new_height): Use
6657         m_has_locator field directly.
6658         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6659         method.
6660         (struct tui_source_window_base) <has_locator>: Likewise.
6661
6662 2019-07-17  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6665         Don't declare.
6666         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6667         Remove.
6668         * tui/tui-win.c (tui_source_window_base::set_new_height)
6669         (tui_source_window_base::set_new_height)
6670         (make_invisible_and_set_new_height)
6671         (tui_source_window_base::do_make_visible_with_new_height)
6672         (tui_source_window_base::do_make_visible_with_new_height):
6673         Update.
6674         * tui/tui-layout.c (show_source_disasm_command, show_data)
6675         (show_source_or_disasm_and_command): Update.
6676         * tui/tui-layout.c (show_layout): Update.
6677
6678 2019-07-17  Tom Tromey  <tom@tromey.com>
6679
6680         * tui/tui-layout.c (make_data_window): Remove.
6681         (show_data): Unify creation and re-initialization cases.
6682
6683 2019-07-17  Tom Tromey  <tom@tromey.com>
6684
6685         * tui/tui-layout.c (make_source_window, make_disasm_window):
6686         Remove.
6687         (show_data): Unify creation and re-initialization cases.
6688
6689 2019-07-17  Tom Tromey  <tom@tromey.com>
6690
6691         * tui/tui-layout.c (make_command_window): Remove.
6692         (show_source_disasm_command, show_source_or_disasm_and_command):
6693         Unify creation and re-initialization cases.
6694
6695 2019-07-17  Tom Tromey  <tom@tromey.com>
6696
6697         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6698         creation and re-initialization cases.
6699
6700 2019-07-17  Tom Tromey  <tom@tromey.com>
6701
6702         * tui/tui-regs.c (tui_get_register): Return void.
6703
6704 2019-07-17  Tom Tromey  <tom@tromey.com>
6705
6706         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6707         Simplify.
6708
6709 2019-07-17  Tom Tromey  <tom@tromey.com>
6710
6711         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6712         resetting.
6713
6714 2019-07-17  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6717         * tui/tui-regs.c (tui_reg_layout): New function.
6718         (tui_show_registers, tui_reg_command): Use it.
6719         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6720         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6721         parameters.
6722         (tui_layout_command): Remove.
6723
6724 2019-07-17  Tom Tromey  <tom@tromey.com>
6725
6726         * tui/tui-layout.h (tui/tui-layout): Return void.
6727         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6728
6729 2019-07-17  Tom Tromey  <tom@tromey.com>
6730
6731         * tui/tui-layout.c (show_source_disasm_command, show_data):
6732         Update.
6733         (reset_locator): Remove.
6734         (show_source_or_disasm_and_command): Update.
6735
6736 2019-07-17  Tom Tromey  <tom@tromey.com>
6737
6738         * tui/tui-source.c (tui_source_window_base::reset): Remove
6739         win_type parameter.
6740         * tui/tui-layout.c (make_command_window, make_source_window)
6741         (make_disasm_window, make_data_window)
6742         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6743         (reset_locator, show_source_or_disasm_and_command): Update.
6744         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6745         win_type parameter.
6746         (struct tui_source_window_base) <reset>: Likewise.
6747
6748 2019-07-17  Tom Tromey  <tom@tromey.com>
6749
6750         * tui/tui-layout.c (show_source_disasm_command): Use
6751         reset_locator.
6752         (reset_locator): New function.
6753         (init_and_make_win): Remove.
6754         (show_source_or_disasm_and_command): Use reset_locator.
6755
6756 2019-07-17  Tom Tromey  <tom@tromey.com>
6757
6758         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6759         condition.
6760         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6761         Remove condition.
6762         * tui/tui-source.c (tui_source_window_base::reset): New method.
6763         * tui/tui-layout.c (make_command_window): Don't call
6764         init_and_make_win.
6765         (make_source_window, make_disasm_window): Don't call
6766         make_source_or_disasm_window.
6767         (make_data_window): Don't call init_and_make_win.  Change calling
6768         convention.
6769         (show_source_disasm_command, show_data): Simplify.
6770         (make_source_or_disasm_window): Remove.
6771         (show_source_or_disasm_and_command): Simplify.
6772         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6773         (struct tui_source_window_base) <reset>: Likewise.
6774         <execution_info>: Remove initializer.
6775         * tui/tui-data.c (tui_source_window_base): Initialize
6776         execution_info.
6777
6778 2019-07-17  Tom Tromey  <tom@tromey.com>
6779
6780         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6781         variable.
6782
6783 2019-07-17  Tom Tromey  <tom@tromey.com>
6784
6785         * tui/tui.c (tui_rl_other_window): Update.
6786         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6787         superclass method first.  Always iterate over regs_content.
6788         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6789         method.
6790         * tui/tui-win.c (tui_set_focus_command): Update.
6791
6792 2019-07-17  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-win.c (tui_set_focus_command): Rename from
6795         tui_set_focus.  Call tui_enable.
6796         (tui_set_focus_command): Remove.
6797
6798 2019-07-17  Tom Tromey  <tom@tromey.com>
6799
6800         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6801         refresh_window.
6802         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6803         touchwin.
6804         (tui_data_window::refresh_window): Call refresh_window on data
6805         items.  Always call superclass refresh_window.
6806         (tui_win_info::refresh): Remove.
6807         (tui_source_window_base::refresh_window): Update.
6808         (tui_refresh_all): Update.
6809         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6810         refresh_window.
6811         (show_source_or_disasm_and_command): Likewise.
6812         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6813         (struct tui_source_window_base) <refresh>: Likewise.
6814
6815 2019-07-17  Tom Tromey  <tom@tromey.com>
6816
6817         * tui/tui-winsource.c (tui_clear_source_content)
6818         (tui_show_source_content): Update.
6819         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6820         whether content is empty.
6821         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6822         Remove.
6823
6824 2019-07-17  Tom Tromey  <tom@tromey.com>
6825
6826         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6827         window's contents.
6828         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6829         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6830
6831 2019-07-17  Tom Tromey  <tom@tromey.com>
6832
6833         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6834         (struct tui_data_item_window): Update.
6835
6836 2019-07-17  Tom Tromey  <tom@tromey.com>
6837
6838         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6839         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6840         defines.
6841
6842 2019-07-17  Tom Tromey  <tom@tromey.com>
6843
6844         * tui/tui-winsource.h (tui_erase_source_content)
6845         (tui_clear_source_content): Remove "display_prompt" parameter.
6846         * tui/tui-winsource.c (tui_update_source_window_as_is)
6847         (tui_update_source_windows_with_addr): Update.
6848         (tui_clear_source_content): Remove "display_prompt" parameter.
6849         (tui_erase_source_content): Likewise.  Simplify.
6850         (tui_show_source_content): Update.
6851         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6852         * tui/tui-stack.c (tui_show_frame_info): Update.
6853         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6854         Remove defines.
6855
6856 2019-07-17  Tom Tromey  <tom@tromey.com>
6857
6858         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6859         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6860         parameter.
6861         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6862         parameter.
6863
6864 2019-07-17  Tom Tromey  <tom@tromey.com>
6865
6866         * tui/tui-winsource.c (tui_clear_source_content)
6867         (tui_show_source_content, tui_show_exec_info_content)
6868         (tui_clear_exec_info_content): Update.
6869         * tui/tui-stack.c (tui_show_locator_content): Update.
6870         (tui_show_frame_info): Update.
6871         * tui/tui-source.h (tui_source_window): Don't declare.
6872         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6873         from tui_source_is_displayed.
6874         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6875         Remove field.
6876         (struct tui_source_window_base) <content_in_use>: New field.  Now
6877         bool.
6878         (struct tui_source_window) <showing_source_p>: New method.
6879         (TUI_SRC_WIN): Change cast.
6880         * tui/tui-data.c (tui_initialize_static_data): Update.
6881
6882 2019-07-17  Tom Tromey  <tom@tromey.com>
6883
6884         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6885         location_matches_p.
6886         * tui/tui-source.c (tui_source_window::location_matches_p): New
6887         method.
6888         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6889         method.
6890         * tui/tui-data.h (struct tui_source_window_base)
6891         <location_matches_p>: New method.
6892         (struct tui_source_window, struct tui_disasm_window)
6893         <location_matches_p>: Likewise.
6894
6895 2019-07-17  Tom Tromey  <tom@tromey.com>
6896
6897         * tui/tui-win.c (tui_set_win_height_command): Rename from
6898         tui_set_win_height.
6899         (tui_set_win_height_command): Remove.
6900
6901 2019-07-17  Tom Tromey  <tom@tromey.com>
6902
6903         * tui/tui-source.c (tui_source_window): New constructor.  Add
6904         observer.
6905         (~tui_source_window): New destructor.
6906         (tui_source_window::style_changed): New method.
6907         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6908         (tui_attach_detach_observers): Update.
6909         * tui/tui-data.h (struct tui_source_window): Make constructor not
6910         inline.  Add destructor.
6911         (struct tui_source_window) <style_changed>: New method.
6912         <m_observable>: New member.
6913
6914 2019-07-17  Tom Tromey  <tom@tromey.com>
6915
6916         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6917         * tui/tui-win.c (tui_resize_all): Fix typo.
6918
6919 2019-07-17  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6922         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6923         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6924         * tui/tui-win.c (window_name_completer): Use foreach.
6925         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6926         (update_tab_width): Likewise.
6927         * tui/tui-layout.c (show_layout): Update.
6928         * tui/tui-data.h (class tui_window_iterator): New.
6929         (struct all_tui_windows): New.
6930         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6931
6932 2019-07-17  Tom Tromey  <tom@tromey.com>
6933
6934         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6935         parameter.  Don't reference globals.
6936         (tui_reg_command): Update.
6937
6938 2019-07-17  Tom Tromey  <tom@tromey.com>
6939
6940         * tui/tui-regs.c (tui_show_registers): Simplify.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-regs.c (tui_show_registers): Update.
6945         (tui_show_register_group): Add win_info parameter.
6946
6947 2019-07-17  Tom Tromey  <tom@tromey.com>
6948
6949         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6950         Rename from tui_display_reg_element_at_line.
6951         (tui_data_window::display_registers_from_line): Update.
6952         * tui/tui-data.h (struct tui_data_window)
6953         <display_reg_element_at_line>: New method.
6954
6955 2019-07-17  Tom Tromey  <tom@tromey.com>
6956
6957         * tui/tui-regs.h (tui_display_registers_from)
6958         (tui_display_registers_from_line): Don't declare.
6959         * tui/tui-windata.c (tui_data_window::display_all_data)
6960         (tui_data_window::refresh_all)
6961         (tui_data_window::do_scroll_vertical): Update.
6962         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6963         from tui_display_registers_from.
6964         (tui_display_reg_element_at_line): Update.
6965         (tui_data_window::display_registers_from_line): Rename from
6966         tui_display_registers_from_line.
6967         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6968         display_registers_from_line>: New methods.
6969
6970 2019-07-17  Tom Tromey  <tom@tromey.com>
6971
6972         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6973         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6974         from tui_erase_data_content.
6975         (tui_data_window::display_all_data)
6976         (tui_data_window::refresh_all)
6977         (tui_data_window::do_scroll_vertical): Update.
6978         * tui/tui-regs.c (tui_show_registers): Update.
6979         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6980         New method.
6981
6982 2019-07-17  Tom Tromey  <tom@tromey.com>
6983
6984         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6985         declare.
6986         * tui/tui-windata.c
6987         (tui_data_window::delete_data_content_windows): Rename from
6988         tui_delete_data_content_windows.
6989         (tui_data_window::display_all_data)
6990         (tui_data_window::do_scroll_vertical): Update.
6991         * tui/tui-data.h (struct tui_data_window)
6992         <delete_data_content_windows>: New method.
6993
6994 2019-07-17  Tom Tromey  <tom@tromey.com>
6995
6996         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6997         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6998
6999 2019-07-17  Tom Tromey  <tom@tromey.com>
7000
7001         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7002         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7003         from tui_display_all_data.
7004         * tui/tui-win.c
7005         (tui_data_window::do_make_visible_with_new_height): Update.
7006         * tui/tui-regs.c (tui_show_registers): Update.
7007         * tui/tui-layout.c (tui_set_layout): Update.
7008         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7009         method.
7010
7011 2019-07-17  Tom Tromey  <tom@tromey.com>
7012
7013         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7014         * tui/tui-windata.c (tui_display_data_from): Remove.
7015         (tui_data_window::refresh_all): Update.
7016
7017 2019-07-17  Tom Tromey  <tom@tromey.com>
7018
7019         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7020         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7021         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7022         tui_display_registers_from_line.
7023         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7024         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7025         "force_display" parameter.
7026
7027 2019-07-17  Tom Tromey  <tom@tromey.com>
7028
7029         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7030         declare.
7031         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7032         Rename from tui_first_reg_element_no_inline.
7033         (tui_display_reg_element_at_line)
7034         (tui_display_registers_from_line): Update.
7035         * tui/tui-data.h (struct tui_data_window)
7036         <first_reg_element_no_inline>: New method.
7037
7038 2019-07-17  Tom Tromey  <tom@tromey.com>
7039
7040         * tui/tui-windata.c (tui_display_data_from)
7041         (tui_data_window::do_scroll_vertical): Update.
7042         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7043         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7044         Rename from tui_line_from_reg_element_no.
7045         (tui_display_registers_from_line): Update.
7046         * tui/tui-data.h (struct tui_data_window)
7047         <line_from_reg_element_no>: New method.
7048
7049 2019-07-17  Tom Tromey  <tom@tromey.com>
7050
7051         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7052         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7053         tui_last_regs_line_no.
7054         (tui_display_reg_element_at_line)
7055         (tui_display_registers_from_line): Update.
7056         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7057         method.
7058
7059 2019-07-17  Tom Tromey  <tom@tromey.com>
7060
7061         PR tui/24722:
7062         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7063         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7064         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7065         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7066         (tui_update_breakpoint_info): Likewise.
7067         * tui/tui-hooks.c (tui_event_create_breakpoint)
7068         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7069         Update.
7070
7071 2019-07-17  Tom Tromey  <tom@tromey.com>
7072
7073         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7074
7075 2019-07-17  Tom Tromey  <tom@tromey.com>
7076
7077         * tui/tui-winsource.c (tui_update_source_window_as_is)
7078         (tui_update_source_windows_with_addr): Update.
7079         * tui/tui-source.h (tui_set_source_content)
7080         (tui_show_symtab_source): Add "win_info" parameter.
7081         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7082         parameter.
7083         (tui_show_symtab_source): Likewise.
7084
7085 2019-07-17  Tom Tromey  <tom@tromey.com>
7086
7087         * tui/tui-wingeneral.c
7088         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7089
7090 2019-07-17  Tom Tromey  <tom@tromey.com>
7091
7092         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7093         (struct tui_cmd_window) <can_scroll>: New method.
7094         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7095         method.
7096
7097 2019-07-17  Tom Tromey  <tromey@adacore.com>
7098
7099         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7100         do_field_signed>: Rename.  Change type of "value".
7101         * ui-out.c (ui_out::field_signed): Rename from field_int.
7102         Change type of "value".
7103         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7104         type of "value".
7105         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7106         do_field_int.  Change type of "value".
7107         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7108         do_field_int.  Change type of "value".
7109         * tracepoint.c (trace_status_mi, tfind_1)
7110         (print_one_static_tracepoint_marker): Update.
7111         * thread.c (print_thread_info_1, print_selected_thread_frame):
7112         Update.
7113         * stack.c (print_frame, print_frame_info): Update.
7114         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7115         Update.
7116         * source.c (print_source_lines_base): Update.
7117         * skip.c (info_skip_command): Update.
7118         * record-btrace.c (btrace_ui_out_decode_error)
7119         (btrace_call_history_src_line): Update.
7120         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7121         Update.
7122         * progspace.c (print_program_space): Update.
7123         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7124         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7125         do_field_int.  Change type of "value".
7126         * mi/mi-out.c (mi_ui_out::do_table_begin)
7127         (mi_ui_out::do_table_header): Update.
7128         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7129         type of "value".
7130         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7131         (mi_cmd_data_list_changed_registers, output_register)
7132         (mi_cmd_data_read_memory, mi_load_progress)
7133         (mi_cmd_trace_frame_collected): Update.
7134         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7135         Update.
7136         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7137         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7138         (mi_cmd_var_list_children, varobj_update_one): Update.
7139         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7140         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7142         * inferior.c (print_inferior): Update.
7143         * gdb_bfd.c (print_one_bfd): Update.
7144         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7145         Update.
7146         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7147         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7148         do_field_int.  Change type of "value".
7149         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7150         do_field_int.  Change type of "value".
7151         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7152         (print_one_breakpoint_location, print_it_catch_fork)
7153         (print_one_catch_fork, print_it_catch_vfork)
7154         (print_one_catch_vfork, print_it_catch_solib)
7155         (print_it_catch_exec, print_it_ranged_breakpoint)
7156         (print_mention_watchpoint, print_mention_masked_watchpoint)
7157         (bkpt_print_it, update_static_tracepoint): Update.
7158         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7159         * break-catch-syscall.c (print_it_catch_syscall): Update.
7160         * ada-tasks.c (print_ada_task_info): Update.
7161         * ada-lang.c (print_it_exception, print_mention_exception):
7162         Update.
7163
7164 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7165
7166         PR breakpoints/24541
7167         * gdbarch.c: Regenerate.
7168         * gdbarch.h: Regenerate.
7169         * gdbarch.sh: Adjust return type and parameter types for
7170         'stap_adjust_register'.
7171         (i386_stap_adjust_register): Adjust signature and return new
7172         register name.
7173         * stap-probe.c (stap_parse_register_operand): Adjust use of
7174         'gdbarch_stap_adjust_register'.
7175
7176 2019-07-17  Tom Tromey  <tromey@adacore.com>
7177
7178         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7179         declare VEC.
7180         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7181         std::vector.
7182         (struct s390_process_info): Add initializers.
7183         (s390_add_process): Use new.
7184         (s390_linux_nat_target::low_forget_process): Use delete.
7185         (s390_linux_nat_target::low_new_fork)
7186         (s390_linux_nat_target::stopped_by_watchpoint)
7187         (s390_linux_nat_target::low_prepare_to_resume)
7188         (s390_linux_nat_target::insert_watchpoint)
7189         (s390_linux_nat_target::insert_hw_breakpoint)
7190         (s390_linux_nat_target::remove_watchpoint)
7191         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7192
7193 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7194
7195         * aarch64-fbsd-nat.c: Include regcache.h.
7196         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7197         argument.
7198         (aarch64_fbsd_nat_target::fetch_registers)
7199         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7200         variable.
7201         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7202
7203 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7204
7205         * fbsd-nat.c: Include gdbarch.h.
7206
7207 2019-07-15  Tom Tromey  <tromey@adacore.com>
7208
7209         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7210
7211 2019-07-15  Tom Tromey  <tromey@adacore.com>
7212
7213         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7214         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7215         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7216         * cli-out.c (cli_ui_out::do_field_int): New method.
7217         * ui-out.c (ui_out::field_unsigned): New method.
7218         * symfile.c (generic_load): Use field_unsigned.
7219         (print_transfer_performance): Likewise.
7220         * record-btrace.c (ui_out_field_uint): Remove.
7221         (btrace_call_history_insn_range, btrace_call_history): Use
7222         field_unsigned.
7223         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7224         field_unsigned.
7225         * ui-out.h (class ui_out) <field_unsigned>: New method.
7226         <do_field_unsigned>: Likewise.
7227
7228 2019-07-15  Tom Tromey  <tromey@adacore.com>
7229
7230         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7231         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7232         * target.c (flash_erase_command): Use field_string.
7233         * infrun.c (print_signal_received_reason): Use field_string.
7234         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7235         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7236         field_string.
7237         * ada-tasks.c (print_ada_task_info): Use field_string.
7238
7239 2019-07-15  Tom Tromey  <tromey@adacore.com>
7240
7241         * target.c (flash_erase_command): Use field_core_addr.
7242         * symfile.c (generic_load): Use field_core_addr.
7243         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7244         Use field_core_addr.
7245         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7246         field_core_addr.
7247
7248 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7251         value if its desired type is smaller than a CORE_ADDR and signed.
7252
7253 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7256         of changes to field names, and use new is_reference field to
7257         decide if a property is a reference or not.
7258         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7259         field.
7260         (struct dwarf2_property_baton): Update header comment, rename
7261         'referenced_type' to 'property_type' and update comments.
7262         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7263         default property type, store in property baton, update to take
7264         accound of renamed field.
7265         (read_func_scope): Update call to attr_to_dynamic_prop.
7266         (read_array_type): Likewise.
7267         (dwarf2_per_cu_addr_sized_int_type): New function.
7268         (read_subrange_index_type): Move type finding code to
7269         dwarf2_per_cu_addr_sized_int_type.
7270         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7271         (dwarf2_per_cu_addr_type): New function.
7272         (set_die_type): Update calls to attr_to_dynamic_prop.
7273
7274 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7275
7276         * dwarf2read.c (read_subrange_index_type): New function.
7277         (read_subrange_type): Move code into new function and call it.
7278         * gdbtypes.c (create_range_type): Add some asserts.
7279
7280 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7281
7282         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7283         update return statements.
7284         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7285         declaration, and update comment to match.
7286         * gdbtypes.c (resolve_dynamic_array): Update call to
7287         dwarf2_evaluate_property to match new return type.
7288
7289 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * valarith.c (value_subscripted_rvalue): Change lowerbound
7292         parameter type from int to LONGEST.
7293         * value.h (value_subscripted_rvalue): Likewise in declaration.
7294
7295 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7296
7297         * cli/cli-utils.c (info_print_command_completer): New function.
7298         * cli/cli-utils.h: Add 'completer.h' include, and forward
7299         declaration for 'struct cmd_list_element'.
7300         (info_print_command_completer): Declare.
7301         * stack.c (_initialize_stack): Add completer for 'info locals' and
7302         'info args'.
7303         * symtab.c (_initialize_symtab): Add completer for 'info
7304         variables' and 'info functions'.
7305         * NEWS: Mention completion for additional info commands.
7306
7307 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7308
7309         * cli/cli-utils.c (extract_info_print_args): Delete.
7310         (extract_arg_maybe_quoted): Delete.
7311         (info_print_options_defs): New variable.
7312         (make_info_print_options_def_group): New function.
7313         (extract_info_print_options): Define new function.
7314         * cli/cli-utils.h (extract_info_print_args): Delete.
7315         (struct info_print_options): New structure.
7316         (extract_info_print_options): Declare new function.
7317         * stack.c (info_locals_command): Update to use new
7318         extract_info_print_options, also add a header comment.
7319         (info_args_command): Likewise.
7320         * symtab.c (info_variables_command): Likewise.
7321         (info_functions_command): Likewise.
7322
7323 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7326         to extract string arguments.
7327         * common/common-utils.c (extract_string_maybe_quoted): New function.
7328         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7329
7330 2019-07-11  Tom Tromey  <tromey@adacore.com>
7331
7332         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7333         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7334         * top.h (gdbinit): Don't declare.
7335         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7336         into...
7337         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7338         * top.c (gdb_init): Don't call init_cli_cmds.
7339         (gdbinit): Remove.
7340         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7341
7342 2019-07-11  Tom Tromey  <tromey@adacore.com>
7343
7344         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7345         after it has been moved.
7346
7347 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7348
7349         * valops.c (value_must_coerce_to_target): Change return type to
7350         bool.
7351         * value.h (value_must_coerce_to_target): Likewise.
7352
7353 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7354
7355         * breakpoint.c (is_hardware_watchpoint): Remove
7356         forward-declaration.
7357         (is_masked_watchpoint): Change return type to bool.
7358         (is_tracepoint): Likewise.
7359         (is_breakpoint): Likewise.
7360         (is_hardware_watchpoint): Likewise.
7361         (is_watchpoint): Likewise.
7362         (is_no_memory_software_watchpoint): Likewise.
7363         (is_catchpoint): Likewise.
7364         (breakpoint_1): Make FILTER parameter's return type bool.
7365         is_masked_watchpoint): Change return type to bool.
7366         (save_breakpoints): Make FILTER parameter's return type bool.
7367         * breakpoint.h (is_breakpoint): Change return type to bool.
7368         (is_watchpoint): Likewise.
7369         (is_catchpoint): Likewise.
7370         (is_tracepoint): Likewise.
7371
7372 2019-07-10  Tom Tromey  <tom@tromey.com>
7373
7374         * defs.h: Don't include gdbarch.h.
7375         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7376         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7377         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7378         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7379         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7380         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7381         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7382         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7383         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7384         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7385         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7386         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7387         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7388         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7389         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7390         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7391         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7392         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7393         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7394         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7395         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7396         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7397         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7398         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7399         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7400         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7401         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7402
7403 2019-07-10  Tom Tromey  <tromey@adacore.com>
7404
7405         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7406         * breakpoint.c (init_ada_exception_breakpoint): Register as
7407         bp_catchpoint.
7408         (print_one_breakpoint_location, print_one_breakpoint): Use
7409         is_ada_exception_catchpoint.
7410         * ada-lang.c (class ada_catchpoint_location): Pass
7411         bp_loc_software_breakpoint to bp_location constructor.
7412         (is_ada_exception_catchpoint): New function.
7413
7414 2019-07-10  Tom Tromey  <tromey@adacore.com>
7415
7416         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7417         VEC.
7418         (struct arm_exidx_entry): New method operator<.
7419         (struct arm_exidx_data) <section_maps>: Change type.
7420         (arm_exidx_data_free): Remove.
7421         (arm_exidx_data_key): Change type.  Move lower.
7422         (arm_exidx_new_objfile): Update.
7423         (arm_compare_exidx_entries): Remove.
7424         (arm_find_exidx_entry, _initialize_arm_tdep)
7425
7426 2019-07-10  Tom Tromey  <tromey@adacore.com>
7427
7428         * solib-spu.c (ocl_program_data_key): Change type.
7429         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7430         Update.
7431
7432 2019-07-10  Tom Tromey  <tromey@adacore.com>
7433
7434         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7435         (struct solib_aix_inferior_data) <library_list>: Change type.
7436         (solib_aix_inferior_data_handle): Change type.
7437         (get_solib_aix_inferior_data): Update.
7438         (solib_aix_free_library_list): Remove.
7439         (library_list_start_library): Update.
7440         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7441         return type.
7442         (solib_aix_get_library_list)
7443         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7444         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7445
7446 2019-07-10  Tom Tromey  <tromey@adacore.com>
7447
7448         * solib-dsbt.c (struct dsbt_info): Add initializers.
7449         (solib_dsbt_pspace_data): Change type.
7450         (dsbt_pspace_data_cleanup): Remove.
7451         (get_dsbt_info, _initialize_dsbt_solib): Update.
7452
7453 2019-07-10  Tom Tromey  <tromey@adacore.com>
7454
7455         * spu-tdep.c (spu_overlay_data): Change type.
7456         (spu_get_overlay_table, spu_overlay_new_objfile)
7457         (_initialize_spu_tdep): Update.
7458
7459 2019-07-10  Tom Tromey  <tromey@adacore.com>
7460
7461         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7462         destructor.
7463         (dbx_objfile_data_key): Change type and declare later.
7464         (DBX_SYMFILE_INFO): Rewrite.
7465         * dbxread.c (dbx_objfile_data_key): Change type.
7466         (dbx_symfile_init): Update.
7467         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7468         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7469         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7470
7471 2019-07-10  Tom Tromey  <tromey@adacore.com>
7472
7473         * jit.c (jit_program_space_key): Change type.  Move lower.
7474         (get_jit_program_space_data): Update.
7475         (jit_program_space_data_cleanup): Remove.
7476         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7477         Update.
7478         (struct jit_program_space_data): Add initializers.
7479
7480 2019-07-10  Tom Tromey  <tromey@adacore.com>
7481
7482         * solib-darwin.c (struct darwin_info): Add initializers.
7483         (solib_darwin_pspace_data): Change type.
7484         (darwin_pspace_data_cleanup): Remove.
7485         (get_darwin_info, _initialize_darwin_solib): Update.
7486
7487 2019-07-10  Tom Tromey  <tromey@adacore.com>
7488
7489         * remote-sim.c (struct sim_inferior_data): Add initializers,
7490         constructor, and destructor.
7491         (sim_inferior_data_key): Change type.  Move lower.
7492         (check_for_duplicate_sim_descriptor): Update.
7493         (get_sim_inferior_data): Use new.  Update.
7494         (~sim_inferior_data_cleanup): Rename from
7495         sim_inferior_data_cleanup.  Simplify.
7496         (gdbsim_close_inferior, simulator_command)
7497         (sim_command_completer, _initialize_remote_sim): Update.
7498         (next_pid, INITIAL_PID): Move earlier.
7499
7500 2019-07-10  Tom Tromey  <tromey@adacore.com>
7501
7502         * python/python-internal.h (create_thread_object): Return
7503         gdbpy_ref.
7504         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7505         * python/py-inferior.c (struct threadlist_entry): Add
7506         constructor.
7507         <thread_obj>: Now a gdbpy_ref.
7508         (thread_to_thread_object): Update.
7509         (add_thread_object): Use new.
7510         (delete_thread_object): Use delete.
7511         (infpy_threads): Update.
7512         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7513         GIL.
7514
7515 2019-07-10  Tom Tromey  <tromey@adacore.com>
7516
7517         * valops.c (value_cast): Specialize error message for Ada.
7518
7519 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7520
7521         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7522
7523 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7524
7525         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7526         bpstat_should_step): Return bool, adjust comments.
7527         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7528         bpstat_should_step): Likewise.
7529
7530 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7531
7532         * features/Makefile: Use feature target descriptions for Arm.
7533         * features/arm/arm-core.c: Generate new file.
7534         * features/arm/arm-fpa.c: Likewise.
7535         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7536         * features/arm/arm-m-profile.c: Likewise.
7537         * features/arm/arm-vfpv2.c: Likewise.
7538         * features/arm/arm-vfpv3.c: Likewise.
7539         * features/arm/xscale-iwmmxt.c: Likewise.
7540         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7541
7542 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7543
7544         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7545         ptrace earlier.
7546
7547 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7548
7549         * features/aarch64-pauth.c: Regenerate.
7550
7551 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7552
7553         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7554         bool.
7555         (bpstat_what): Use false instead of 0.
7556
7557 2019-07-09  Pedro Alves  <palves@redhat.com>
7558
7559         * break-catch-throw.c (is_exception_catchpoint): New.
7560         * breakpoint.c (print_one_breakpoint_location): New parameter
7561         'raw_loc'.  Handle it.  Use
7562         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7563         looking at the breakpoint's type.
7564         (print_one_breakpoint): If handling "maint info breakpoints", also
7565         print locations of exception catchpoints.
7566         * breakpoint.h (is_exception_catchpoint): Declare.
7567
7568 2019-07-09  Pedro Alves  <palves@redhat.com>
7569
7570         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7571         "addr" field.
7572         (allocate_location_exception_catchpoint): New.
7573         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7574         (initialize_throw_catchpoint_ops): Install
7575         allocate_location_exception_catchpoint as allocate_location
7576         method.
7577         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7578         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7579         bp_loc_other.
7580         (breakpoint_address_is_meaningful): Delete.
7581         (bl_address_is_meaningful): New.
7582         (breakpoint_locations_match): Adjust comment.
7583         (bp_location_from_bp_type): New, factored out of...
7584         (bp_location::bp_location(breakpoint *)): ... this.
7585         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7586         factored out of...
7587         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7588         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7589         breakpoint_address_is_meaningful.
7590         (bp_locations_compare): Adjust comment.
7591         (update_global_location_list): Use bl_address_is_meaningful
7592         instead of breakpoint_address_is_meaningful.
7593         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7594         explicit.
7595         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7596         * python/py-breakpoint.c (bppy_get_location): No longer check
7597         whether location is null.
7598
7599 2019-07-09  Pedro Alves  <palves@redhat.com>
7600
7601         PR c++/15468
7602         * breakpoint.c (print_one_breakpoint_location): Remove
7603         single-location assert.
7604
7605 2019-07-09  Tom Tromey  <tom@tromey.com>
7606
7607         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7608         * configure: Rebuild.
7609         * configure.ac: Change common to gdbsupport.
7610         * gdbsupport: Rename from common.
7611         * acinclude.m4: Change common to gdbsupport.
7612         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7613         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7614         gdbsupport.
7615         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7616         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7617         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7618         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7619         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7620         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7621         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7622         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7623         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7624         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7625         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7626         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7627         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7628         coff-pe-read.c, command.h, compile/compile-c-support.c,
7629         compile/compile-c.h, compile/compile-cplus-symbols.c,
7630         compile/compile-cplus-types.c, compile/compile-cplus.h,
7631         compile/compile-loc2c.c, compile/compile.c, completer.c,
7632         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7633         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7634         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7635         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7636         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7637         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7638         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7639         features/aarch64-core.c, features/aarch64-fpu.c,
7640         features/aarch64-pauth.c, features/aarch64-sve.c,
7641         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7642         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7643         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7644         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7645         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7646         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7647         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7648         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7649         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7650         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7651         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7652         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7653         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7654         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7655         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7656         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7657         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7658         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7659         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7660         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7661         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7662         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7663         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7664         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7665         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7666         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7667         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7668         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7669         minsyms.c, mips-linux-tdep.c, namespace.h,
7670         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7671         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7672         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7673         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7674         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7675         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7676         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7677         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7678         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7679         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7680         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7681         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7682         procfs.c, producer.c, progspace.h, psymtab.h,
7683         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7684         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7685         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7686         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7687         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7688         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7689         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7690         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7691         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7692         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7693         target-memory.c, target.c, target.h, target/waitstatus.c,
7694         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7695         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7696         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7697         unittests/array-view-selftests.c,
7698         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7699         unittests/common-utils-selftests.c,
7700         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7701         unittests/format_pieces-selftests.c,
7702         unittests/function-view-selftests.c,
7703         unittests/lookup_name_info-selftests.c,
7704         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7705         unittests/mkdir-recursive-selftests.c,
7706         unittests/observable-selftests.c,
7707         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7708         unittests/parse-connection-spec-selftests.c,
7709         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7710         unittests/scoped_fd-selftests.c,
7711         unittests/scoped_mmap-selftests.c,
7712         unittests/scoped_restore-selftests.c,
7713         unittests/string_view-selftests.c, unittests/style-selftests.c,
7714         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7715         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7716         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7717         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7718         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7719         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7720
7721 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7724         bool value.
7725         (decode_digits_ordinary): Set explicit_line field in sal.
7726         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7727         symtab_and_line that was set on an explicit line number in
7728         assembler code.  Do always update the recorded symtab and line if
7729         we do skip the prologue.
7730
7731 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7732
7733         * breakpoint.c (set_breakpoint_location_function): Remove
7734         explicit_loc parameter.
7735         (momentary_breakpoint_from_master): Update call to
7736         set_breakpoint_location_function.
7737         (add_location_to_breakpoint): Likewise.
7738
7739 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7742         required features based on default bfd type when no specific bfd
7743         is present.
7744
7745 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7746
7747         * NEWS: Mention that GDB printf and eval commands can now print
7748         C-style and Ada-style convenience var strings without
7749         calling the inferior.
7750         * printcmd.c (printf_c_string): Locally print GDB internal var
7751         instead of transiting via the inferior.
7752         (printf_wide_c_string): Likewise.
7753
7754 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7755
7756         PR breakpoints/25011
7757         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7758
7759 2019-07-04  Tom Tromey  <tom@tromey.com>
7760
7761         PR tui/24724:
7762         * tui/tui-winsource.c (tui_clear_source_content): Update.
7763         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7764         (tui_update_breakpoint_info): Update.
7765         (tui_set_exec_info_content): Update.
7766         * tui/tui-source.c (tui_set_source_content_nil): Update.
7767         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7768         has_break.
7769         * tui/tui-data.h (enum tui_bp_flag): New.
7770         (tui_bp_flags): New enum flags type.
7771         (struct tui_source_element) <break_mode>: Change type.  Rename
7772         from has_break.
7773         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7774         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7775         constants.
7776         * tui/tui-winsource.h: Fix comment.
7777
7778 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7779
7780         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7781         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7782         (store_fpregs_to_thread)
7783         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7784         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7785         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7786         (IWMMXT_REGS_SIZE): Add define.
7787         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7788         (fetch_vfp_regs, store_vfp_regs)
7789         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7790         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7791
7792 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7793
7794         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7795         defines.
7796         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7797         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7798         (ARM_INT_REGISTER_SIZE): ...to this.
7799         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7800         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7801         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7802         (arm_linux_collect_gregset, supply_nwfpe_register)
7803         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7804         defines.
7805         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7806         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7807         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7808         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7809         (arm_return_in_memory, arm_store_return_value)
7810         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7811         (arm_record_ld_st_multiple): Likewise.
7812         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7813         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7814
7815 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7816
7817         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7818         AARCH64_DISPLACED_MODIFIED_INSNS.
7819         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7820         (aarch64_displaced_step_copy_insn): Likewise.
7821         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7822         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7823         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7824         ARM_DISPLACED_MODIFIED_INSNS.
7825         * arm-tdep.c (arm_gdbarch_init): Likewise.
7826         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7827         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7828         (struct arm_displaced_step_closure): Use
7829         ARM_DISPLACED_MODIFIED_INSNS.
7830
7831 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7832
7833         * features/Makefile: Remove unused xml files.
7834         * features/aarch64.xml: Remove.
7835         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7836         * features/i386/amd64-avx-avx512.xml: Remove.
7837         * features/i386/amd64-avx-linux.xml: Remove.
7838         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7839         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7840         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7841         * features/i386/amd64-avx-mpx.xml: Remove.
7842         * features/i386/amd64-avx.xml: Remove.
7843         * features/i386/amd64-linux.xml: Remove.
7844         * features/i386/amd64-mpx-linux.xml: Remove.
7845         * features/i386/amd64-mpx.xml: Remove.
7846         * features/i386/amd64.xml: Remove.
7847         * features/i386/i386-avx-avx512-linux.xml: Remove.
7848         * features/i386/i386-avx-avx512.xml: Remove.
7849         * features/i386/i386-avx-linux.xml: Remove.
7850         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7851         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7852         * features/i386/i386-avx-mpx-linux.xml: Remove.
7853         * features/i386/i386-avx-mpx.xml: Remove.
7854         * features/i386/i386-avx.xml: Remove.
7855         * features/i386/i386-linux.xml: Remove.
7856         * features/i386/i386-mmx-linux.xml: Remove.
7857         * features/i386/i386-mmx.xml: Remove.
7858         * features/i386/i386-mpx-linux.xml: Remove.
7859         * features/i386/i386-mpx.xml: Remove.
7860         * features/i386/i386.xml: Remove.
7861         * features/i386/x32-avx-avx512-linux.xml: Remove.
7862         * features/i386/x32-avx-linux.xml: Remove.
7863         * features/i386/x32-linux.xml: Remove.
7864
7865 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7866
7867         * regformats/aarch64.dat: Remove.
7868         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7869         * regformats/i386/amd64-avx-linux.dat: Remove.
7870         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7871         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7872         * regformats/i386/amd64-linux.dat: Remove.
7873         * regformats/i386/amd64-mpx-linux.dat: Remove.
7874         * regformats/i386/amd64.dat: Remove.
7875         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7876         * regformats/i386/i386-avx-linux.dat: Remove.
7877         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7878         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7879         * regformats/i386/i386-linux.dat: Remove.
7880         * regformats/i386/i386-mmx-linux.dat: Remove.
7881         * regformats/i386/i386-mpx-linux.dat: Remove.
7882         * regformats/i386/i386.dat: Remove.
7883         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7884         * regformats/i386/x32-avx-linux.dat: Remove.
7885         * regformats/i386/x32-linux.dat: Remove.
7886
7887 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7888
7889         * aarch64-tdep.c: Remove xml self tests.
7890         * amd64-linux-tdep.c: Likewise.
7891         * amd64-tdep.c: Likewise.
7892         * i386-linux-tdep.c: Likewise.
7893         * i386-tdep.c: Likewise.
7894
7895 2019-07-03  Pedro Alves  <palves@redhat.com>
7896
7897         PR cli/24732
7898         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7899         (pipe_cmd_option_defs): New.
7900         (make_pipe_cmd_options_def_group): New.
7901         (pipe_command): Use gdb::option::process_options.
7902         (pipe_command_completer): New function.
7903         (_initialize_cli_cmds): Install completer for "pipe" command.
7904
7905 2019-07-03  Pedro Alves  <palves@redhat.com>
7906
7907         * cli/cli-option.c (union option_value) <string>: New field.
7908         (struct option_def_and_value): Add ctor, move ctor, dtor and
7909         use DISABLE_COPY_AND_ASSIGN.
7910         (option_def_and_value::clear_value): New.
7911         (parse_option, save_option_value_in_ctx, get_val_type_str)
7912         (add_setshow_cmds_for_options): Handle var_string.
7913         * cli-option.h (union option_def::var_address) <string>: New
7914         field.
7915         (struct string_option_def): New.
7916         * maint-test-options.c (struct test_options_opts): Add default
7917         ctor and use DISABLE_COPY_AND_ASSIGN.
7918         <string_opt>: New field.
7919         (test_options_opts::~test_options_opts): New.
7920         (test_options_opts::dump): Also dump "-string".
7921         (test_options_option_defs): Install "string.
7922
7923 2019-07-03  Pedro Alves  <palves@redhat.com>
7924
7925         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7926         option_value with a null enumeration.
7927         (complete_options): Save the option values in the context.
7928         (save_option_value_in_ctx): New, factored out from ...
7929         (process_options): ... here.
7930         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7931         of the function.
7932         * maint-test-options.c (test_options_opts::dump): New, factored
7933         out from ...
7934         (maintenance_test_options_command_mode): ... here.
7935         (maintenance_test_options_command_completion_result): Delete.
7936         (maintenance_test_options_command_completion_text): Update
7937         comment.
7938         (maintenance_show_test_options_completion_result): Change
7939         prototype.  Just print
7940         maintenance_test_options_command_completion_text.
7941         (save_completion_result): New.
7942         (maintenance_test_options_completer_mode): Pass options context to
7943         complete_options, and then save a dump.
7944         (_initialize_maint_test_options): Use add_cmd to install "maint
7945         show test-options-completion-result".
7946
7947 2019-07-03  Pedro Alves  <palves@redhat.com>
7948
7949         * NEWS (New commands): Mention "with" and "maint with".
7950         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7951         (with_command, with_command_completer): New.
7952         (pipe_command): Adjust to new repeat_previous
7953         interface.
7954         (_initialize_cli_cmds): Install the "with" command and its "w"
7955         alias.
7956         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7957         declarations.
7958         * cli/cli-setshow.c (parse_cli_var_uinteger)
7959         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7960         argument strings for all var_types.
7961         (get_setshow_command_value_string): New, factored out from ...
7962         (do_show_command): ... this.
7963         * cli/cli-setshow.h: Include <string>.
7964         (get_setshow_command_value_string): Declare.
7965         * command.h (repeat_previous): Now returns const char *.  Adjust
7966         comment.
7967         * maint.c: Include "cli/cli-cmds.h".
7968         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7969         (_initialize_maint_cmds): Register the "maintenance with" command.
7970         * top.c (repeat_previous): Move bits from pipe_command here:
7971         Return the saved command line, if any; error out if there's no
7972         command to relaunch.
7973
7974 2019-07-03  Pedro Alves  <palves@redhat.com>
7975
7976         * NEWS (New commands): Mention "maint set/show test-settings"
7977         instead of "maint test-settings".
7978         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7979         (maintenance_test_settings_set_list): Rename to ...
7980         (maintenance_set_test_settings_list): ... this.
7981         (maintenance_test_settings_show_list): Rename to  ...
7982         (maintenance_show_test_settings_list): ... this.
7983         (maintenance_test_settings_cmd): Delete.
7984         (maintenance_test_settings_set_cmd): ...
7985         (maintenance_set_test_settings_cmd): ... this.
7986         (maintenance_test_settings_show_cmd): ...
7987         (maintenance_show_test_settings_cmd): ... this.
7988         (maintenance_test_settings_show_value_cmd):
7989         (maintenance_show_test_settings_value_cmd): ... this.
7990         (_initialize_maint_test_settings): No longer install the "maint
7991         test-settings" prefix command.  Rename "maint test-settings set"
7992         to "maint set test-settings", and "maint test-settings show" to
7993         "maint show test-settings".  Adjust all subcommands.
7994
7995 2019-07-03  Pedro Alves  <palves@redhat.com>
7996
7997         * maint-test-settings.c: Fix file's intro comment.  Replace all
7998         references to "test-options" with references to "test-settings",
7999         in comments.
8000
8001 2019-07-03  Pedro Alves  <palves@redhat.com>
8002
8003         * maint-test-settings.c (maintenance_test_settings_xxx)
8004         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8005         New.
8006         (maintenance_test_settings_enums): Use them.
8007         (maintenance_test_settings_enum): Default to
8008         maintenance_test_settings_xxx.
8009         (_initialize_maint_test_settings): Initialize
8010         MAINTENANCE_TEST_SETTINGS_FILENAME.
8011
8012 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8013
8014         * breakpoint.h (remove_breakpoints_inf): Change return type to
8015         void, move function documentation here.
8016         * breakpoint.c (remove_breakpoints_inf): Change return type to
8017         void, move function documentation to header.
8018
8019 2019-07-02  Pedro Alves  <palves@redhat.com>
8020
8021         * NEWS (Completion improvements): Mention "info threads".
8022         * thread.c (struct info_threads_opts, info_threads_option_defs)
8023         (make_info_threads_options_def_group): New.
8024         (info_threads_command): Use gdb::option::process_options.
8025         (info_threads_command_completer): New.
8026         (_initialize_thread): Use gdb::option::build_help to build the
8027         help text for "info threads".
8028
8029 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8030
8031         * defs.h (generic_load): Move from here...
8032         * symfile.h (generic_load): ... to here.  Rename name parameter
8033         to args.
8034         * symfile.c (generic_load): Add comment.
8035
8036 2019-07-01  Tom Tromey  <tromey@adacore.com>
8037
8038         * dwarf2read.c
8039         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8040         declaration of without_params.  Fix formatting.
8041
8042 2019-07-01  Tom Tromey  <tromey@adacore.com>
8043
8044         * ada-exp.y (find_primitive_type): Update.
8045         * ada-lang.h (ada_lookup_symbol): Update.
8046         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8047         parameter.
8048         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8049
8050 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8051
8052         PR breakpoints/24541
8053         * gdbarch.c: Regenerate.
8054         * gdbarch.h: Regenerate.
8055         * gdbarch.sh: Add 'stap_adjust_register'.
8056         * i386-tdep.c: Include '<unordered_set>'.
8057         (i386_stap_adjust_register): New function.
8058         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8059         * stap-probe.c (stap_parse_register_operand): Call
8060         'gdbarch_stap_adjust_register'.
8061
8062 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8063
8064         PR python/24742
8065         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8066         * python/python.c (do_start_initialization): Use 'xmalloc'
8067         instead of 'PyMem_Malloc'.
8068
8069 2019-06-28  Tom Tromey  <tromey@adacore.com>
8070
8071         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8072         for Ada.
8073
8074 2019-06-27  Tom Tromey  <tromey@adacore.com>
8075
8076         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8077         objfile_key.
8078         (arm_find_mapping_symbol, arm_record_special_symbol)
8079         (_initialize_arm_tdep): Update.
8080         (arm_objfile_data_free): Remove.
8081
8082 2019-06-27  Tom Tromey  <tromey@adacore.com>
8083
8084         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8085         to cp_print_static_field.
8086
8087 2019-06-26  Tom Tromey  <tromey@adacore.com>
8088
8089         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8090         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8091         declare.
8092
8093 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8094
8095         * features/aarch64-core.c (create_feature_aarch64_core):
8096         Regenerate.
8097         * features/aarch64-core.xml: Add cpsr flags.
8098
8099 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8100
8101         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8102         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8103
8104 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8105
8106         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8107         field.
8108         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8109         use.
8110         (arm_record_special_symbol): Don't insert new symbol in sorted
8111         position, push it at the end.
8112
8113 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8114
8115         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8116         (arm_mapping_symbol_s): Remove.
8117         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8118         (arm_mapping_symbol_vec): New typedef.
8119         (struct arm_per_objfile): Add constructor.
8120         <section_maps>: Change type to
8121         std::unique_ptr<arm_mapping_symbol_vec[]>.
8122         (arm_compare_mapping_symbols): Remove.
8123         (arm_find_mapping_symbol): Adjust to section_maps type change.
8124         (arm_objfile_data_free): Call delete on arm_per_objfile.
8125         (arm_record_special_symbol): Adjust to section_maps type change.
8126         Allocate arm_per_objfile with new.
8127
8128 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8129
8130         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8131         with the command prefix.
8132
8133 2019-06-25  Tom Tromey  <tom@tromey.com>
8134
8135         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8136         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8137
8138 2019-06-25  Tom Tromey  <tom@tromey.com>
8139
8140         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8141         type.
8142         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8143         protected.
8144
8145 2019-06-25  Tom Tromey  <tom@tromey.com>
8146
8147         * tui/tui-winsource.c
8148         (tui_source_window_base::set_is_exec_point_at): Add check against
8149         LOA_ADDRESS.
8150
8151 2019-06-25  Tom Tromey  <tom@tromey.com>
8152
8153         * tui/tui-source.c (tui_set_source_content): Don't check before
8154         xfree.
8155         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8156
8157 2019-06-25  Tom Tromey  <tom@tromey.com>
8158
8159         * tui/tui-winsource.h (tui_update_source_window_as_is)
8160         (tui_alloc_source_buffer, tui_line_is_displayed)
8161         (tui_addr_is_displayed): Change type of win_info.
8162         * tui/tui-winsource.c (tui_update_source_window_as_is)
8163         (tui_clear_source_content, tui_show_source_line)
8164         (tui_show_source_content, tui_source_window_base::refill)
8165         (tui_source_window_base::set_is_exec_point_at)
8166         (tui_source_window_base::set_is_exec_point_at)
8167         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8168         (tui_alloc_source_buffer, tui_line_is_displayed)
8169         (tui_addr_is_displayed): Change type of win_info.  Update.
8170         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8171         (tui_source_window_base::do_make_visible_with_new_height):
8172         Update.
8173         * tui/tui-source.c (tui_set_source_content)
8174         (tui_set_source_content_nil)
8175         (tui_source_window::do_scroll_vertical): Update.
8176         * tui/tui-layout.c (show_layout): Update.
8177         * tui/tui-disasm.c (tui_set_disassem_content)
8178         (tui_disasm_window::do_scroll_vertical): Update.
8179         * tui/tui-data.h (tui_win_content): Remove.
8180         (struct tui_gen_win_info) <content, content_size>: Remove.
8181         (struct tui_source_element): Add initializers and destructor.
8182         (union tui_which_element, struct tui_win_element): Remove.
8183         (struct tui_source_window_base) <content>: New field.
8184         (struct tui_data_window): Remove destructor.
8185         (tui_alloc_content, tui_free_win_content)
8186         (tui_free_all_source_wins_content): Don't declare.
8187         * tui/tui-data.c (tui_initialize_static_data): Update.
8188         (init_content_element, tui_alloc_content): Remove.
8189         (~tui_gen_win_info): Update.
8190         (~tui_data_window, tui_free_all_source_wins_content)
8191         (tui_free_win_content, free_content, free_content_elements):
8192         Remove.
8193
8194 2019-06-25  Tom Tromey  <tom@tromey.com>
8195
8196         * tui/tui-winsource.h (tui_clear_source_content)
8197         (tui_erase_source_content, tui_show_source_content): Change type
8198         of win_info.
8199         * tui/tui-winsource.c (tui_clear_source_content)
8200         (tui_erase_source_content, tui_show_source_content): Change type
8201         of win_info.
8202         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8203         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8204         win_info.
8205         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8206         win_info.
8207         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8208
8209 2019-06-25  Tom Tromey  <tom@tromey.com>
8210
8211         * tui/tui-winsource.c (tui_clear_source_content)
8212         (tui_source_window_base::set_is_exec_point_at): Update.
8213         * tui/tui-source.c (tui_set_source_content_nil): Update.
8214         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8215         a bool.
8216         * tui/tui-data.c (init_content_element): Update.
8217
8218 2019-06-25  Tom Tromey  <tom@tromey.com>
8219
8220         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8221         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8222         * tui/tui-layout.c (init_and_make_win): Update.
8223         * tui/tui.h (enum tui_win_type): Update.
8224         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8225         tui_win_is_auxillary.
8226         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8227         tui_win_is_auxillary.
8228
8229 2019-06-25  Tom Tromey  <tom@tromey.com>
8230
8231         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8232         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8233         (tui_delete_data_content_windows, tui_display_all_data)
8234         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8235         Update.
8236         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8237         * tui/tui-regs.c (tui_last_regs_line_no)
8238         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8239         (tui_show_registers): Update.
8240         (tui_show_register_group): Return void.  Update.
8241         (tui_display_registers_from, tui_display_reg_element_at_line)
8242         (tui_display_registers_from_line, tui_check_register_values):
8243         Update.
8244         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8245         member.
8246         (struct tui_data_window) <regs_content>: Now a std::vector.
8247         <regs_content_count>: Remove.
8248         (tui_add_content_elements, tui_free_data_content): Don't declare.
8249         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8250         (init_content_element): Remove DATA_WIN case.  Add assert.
8251         (tui_add_content_elements): Remove.
8252         (tui_data_window): Update.
8253         (tui_free_data_content): Remove.
8254         (free_content_elements): Remove DATA_WIN case.
8255
8256 2019-06-25  Tom Tromey  <tom@tromey.com>
8257
8258         * tui/tui-data.c (tui_data_item_window): Update.
8259         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8260         * tui/tui-windata.c (tui_display_all_data)
8261         (tui_display_data_from_line): Update.
8262         (tui_check_data_values): Remove.
8263         * tui/tui-regs.c (tui_show_register_group)
8264         (tui_display_reg_element_at_line): Update.
8265         * tui/tui-hooks.c (tui_register_changed)
8266         (tui_refresh_frame_and_register_information): Call
8267         tui_check_register_values.
8268         * tui/tui-data.h (struct tui_data_window) <data_content,
8269         data_content_count, data_type>: Remove.
8270         (enum tui_data_type): Remove.
8271
8272         * tui/tui-data.c (tui_data_window::clear_detail)
8273         (~tui_data_window): Update.
8274
8275 2019-06-25  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8278         declare.
8279         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8280         Rename from tui_first_data_item_displayed.  Update.
8281         (tui_data_window::refresh_all)
8282         (tui_data_window::do_scroll_vertical): Update.
8283         * tui/tui-data.h (struct tui_data_window)
8284         <first_data_item_displayed>: Declare new method.
8285
8286 2019-06-25  Tom Tromey  <tom@tromey.com>
8287
8288         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8289         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8290         contents...
8291         (tui_initialize_static_data): ...here.
8292
8293 2019-06-25  Tom Tromey  <tom@tromey.com>
8294
8295         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8296         (tui_display_registers_from, tui_check_register_values): Update.
8297         (tui_display_register): Remove win_info parameter; update.
8298         (tui_get_register): Change type of parameters.
8299         * tui/tui-data.h (struct tui_data_element): Remove.
8300         (union tui_which_element) <data>: Remove.
8301         <data_window>: Change type.
8302         (struct tui_data_item_window): New.
8303         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8304         case.  Add assert.
8305         (~tui_data_item_window): New destructor.
8306         (free_content_elements): Remove DATA_ITEM_WIN case.
8307
8308 2019-06-25  Tom Tromey  <tom@tromey.com>
8309
8310         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8311         Remove.
8312
8313 2019-06-25  Tom Tromey  <tom@tromey.com>
8314
8315         * tui/tui-data.h (struct tui_command_element): Remove.
8316         (union tui_which_element) <command>: Remove.
8317         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8318         assert.
8319         (free_content_elements): Remove CMD_WIN case.
8320
8321 2019-06-25  Tom Tromey  <tom@tromey.com>
8322
8323         * tui/tui-layout.c (tui_set_layout): Update.
8324         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8325         * tui/tui-data.c (layout_def): Update.
8326
8327 2019-06-25  Tom Tromey  <tom@tromey.com>
8328
8329         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8330         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8331         (tui_source_window_base::set_new_height): Update.
8332         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8333         Update.
8334         (tui_set_locator_fullname, tui_set_locator_info)
8335         (tui_show_frame_info): Update.
8336         * tui/tui-source.c (tui_set_source_content)
8337         (tui_source_is_displayed): Update.
8338         * tui/tui-layout.c (show_source_disasm_command, show_data)
8339         (show_source_or_disasm_and_command): Update.
8340         * tui/tui-disasm.c (tui_set_disassem_content)
8341         (tui_get_begin_asm_address): Update.
8342         * tui/tui-data.h (struct tui_locator_element): Remove.
8343         (union tui_which_element) <locator>: Remove.
8344         (struct tui_locator_window): New.
8345         (tui_locator_win_info_ptr): Change return type.
8346         * tui/tui-data.c (_locator): Change type.
8347         (tui_locator_win_info_ptr): Change return type.
8348         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8349         (tui_alloc_content): Add assert.
8350
8351 2019-06-25  Tom Tromey  <tom@tromey.com>
8352
8353         * tui/tui-winsource.c
8354         (tui_exec_info_window::maybe_allocate_content): New method.
8355         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8356         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8357         (make_source_or_disasm_window): Add cast.
8358         * tui/tui-data.h (union tui_which_element) <simple_string>:
8359         Remove.
8360         (struct tui_source_info): New.
8361         (struct tui_source_window_base) <execution_info>: Change type.
8362         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8363         case, and add assert.
8364         (tui_alloc_content): Add assert.
8365
8366 2019-06-25  Tom Tromey  <tom@tromey.com>
8367
8368         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8369         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8370         * tui/tui-data.c (tui_alloc_win_info): Remove.
8371
8372 2019-06-25  Tom Tromey  <tom@tromey.com>
8373
8374         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8375         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8376         can_highlight.
8377
8378 2019-06-25  Tom Tromey  <tom@tromey.com>
8379
8380         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8381         make_visible_with_new_height method.
8382         (tui_win_info::make_visible_with_new_height): New method.
8383         (tui_source_window_base::do_make_visible_with_new_height)
8384         (tui_data_window::do_make_visible_with_new_height)
8385         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8386         (make_visible_with_new_height): Remove.
8387         (tui_resize_all, tui_adjust_win_heights): Use
8388         make_visible_with_new_height method.
8389         * tui/tui-data.h (struct tui_win_info)
8390         <do_make_visible_with_new_height, make_visible_with_new_height>:
8391         New methods.
8392         (struct tui_source_window_base, struct tui_data_window)
8393         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8394         methods.
8395
8396 2019-06-25  Tom Tromey  <tom@tromey.com>
8397
8398         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8399         method.
8400         (update_tab_width): Call update_tab_width method.
8401         * tui/tui-data.h (struct tui_win_info)
8402         (struct tui_source_window_base) <update_tab_width>: New methods.
8403
8404 2019-06-25  Tom Tromey  <tom@tromey.com>
8405
8406         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8407         parameter.
8408         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8409         parameter.
8410         (tui_gen_win_info::make_visible): Update.
8411         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8412         parameter.
8413         * tui/tui-data.h (enum tui_box): New enum.
8414         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8415
8416 2019-06-25  Tom Tromey  <tom@tromey.com>
8417
8418         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8419         init_and_make_win for EXEC_INFO_WIN.
8420         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8421         longer inline.
8422         (struct tui_win_info) <~tui_win_info>: Inline.
8423         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8424         Don't declare.
8425         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8426         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8427         Remove.
8428         (tui_initialize_static_data): Update.
8429         (~tui_gen_win_info): Handle more cleanup here.
8430         (~tui_source_window_base): Delete "execution_info".
8431         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8432
8433 2019-06-25  Tom Tromey  <tom@tromey.com>
8434
8435         * tui/tui-layout.c (make_command_window): Don't set
8436         can_highlight.
8437         (show_source_disasm_command): Call the reset method.
8438         (show_data): Don't set can_highlight.  Call the reset method.
8439         (tui_gen_win_info::reset): Rename from init_gen_win_info
8440         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8441         (show_source_or_disasm_and_command): Call the reset method.
8442         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8443         (struct tui_cmd_window): Set can_highlight.
8444
8445 2019-06-25  Tom Tromey  <tom@tromey.com>
8446
8447         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8448         from make_visible.
8449         (tui_make_visible, tui_make_invisible): Rewrite.
8450         (tui_win_info::make_visible): Remove.
8451         (tui_source_window_base::make_visible): Update.
8452         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8453         method.  Moved from...
8454         (struct tui_win_info) <make_visible>: ...here.
8455
8456 2019-06-25  Tom Tromey  <tom@tromey.com>
8457
8458         * tui/tui-winsource.c
8459         (tui_source_window_base::do_scroll_horizontal): Remove direction
8460         parameter.
8461         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8462         direction parameter.
8463         * tui/tui-win.c (tui_win_info::forward_scroll)
8464         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8465         (tui_win_info::right_scroll): Update.
8466         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8467         direction parameter.
8468         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8469         direction parameter.
8470         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8471         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8472         Remove direction parameter.
8473         (struct tui_source_window_base, struct tui_source_window)
8474         (struct tui_disasm_window, struct tui_data_window)
8475         (struct tui_cmd_window): Update.
8476
8477 2019-06-25  Tom Tromey  <tom@tromey.com>
8478
8479         * tui/tui-winsource.h (tui_set_exec_info_content)
8480         (tui_show_exec_info_content, tui_erase_exec_info_content)
8481         (tui_clear_exec_info_content, tui_update_exec_info): Change
8482         argument to tui_source_window_base.
8483         * tui/tui-winsource.c (tui_set_exec_info_content)
8484         (tui_show_exec_info_content, tui_erase_exec_info_content)
8485         (tui_clear_exec_info_content, tui_update_exec_info): Change
8486         argument to tui_source_window_base.
8487
8488 2019-06-25  Tom Tromey  <tom@tromey.com>
8489
8490         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8491         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8492
8493 2019-06-25  Tom Tromey  <tom@tromey.com>
8494
8495         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8496         check.
8497
8498 2019-06-25  Tom Tromey  <tom@tromey.com>
8499
8500         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8501         type to void.
8502         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8503         type to void.
8504         * tui/tui-source.c (tui_set_source_content): Update.
8505         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8506
8507 2019-06-25  Tom Tromey  <tom@tromey.com>
8508
8509         * tui/tui-win.c (window_name_completer, tui_set_focus)
8510         (tui_all_windows_info): Use name method.
8511         * tui/tui-data.h (struct tui_gen_win_info)
8512         (struct tui_source_window, struct tui_disasm_window)
8513         (struct tui_data_window, struct tui_cmd_window) <name>: New
8514         method.
8515         (tui_win_name): Don't declare.
8516         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8517         (tui_win_name): Remove.
8518
8519 2019-06-25  Tom Tromey  <tom@tromey.com>
8520
8521         * tui/tui-winsource.h (tui_update_source_window)
8522         (tui_update_source_window_as_is): Change parameter type.
8523         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8524         to be a tui_source_window_base.
8525         (tui_update_source_window_as_is): Likewise.
8526         * tui/tui-win.c (make_visible_with_new_height): Update.
8527
8528 2019-06-25  Tom Tromey  <tom@tromey.com>
8529
8530         * tui/tui-winsource.c (tui_erase_source_content)
8531         (tui_show_source_content, tui_show_exec_info_content)
8532         (tui_erase_exec_info_content): Use refresh_window method.
8533         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8534         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8535         from tui_refresh_win.
8536         (tui_data_window::refresh_window): New method.
8537         (tui_win_info::refresh, tui_source_window_base::refresh)
8538         (tui_refresh_all): Use refresh_window method.
8539         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8540         method.
8541         * tui/tui-regs.c (tui_display_register): Call refresh_window
8542         method.
8543         * tui/tui-layout.c (show_source_disasm_command)
8544         (show_source_or_disasm_and_command): Call refresh_window method.
8545         * tui/tui-data.h (struct tui_gen_win_info)
8546         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8547         New method.
8548
8549 2019-06-25  Tom Tromey  <tom@tromey.com>
8550
8551         * tui/tui.c (tui_rl_other_window, tui_enable)
8552         (tui_is_window_visible, tui_get_command_dimension): Update.
8553         * tui/tui-winsource.c (tui_update_source_window_as_is)
8554         (tui_clear_source_content, tui_erase_source_content)
8555         (tui_show_source_line, tui_source_window_base::refill)
8556         (tui_source_window_base::do_scroll_horizontal)
8557         (tui_source_window_base::set_is_exec_point_at)
8558         (tui_update_breakpoint_info, tui_set_exec_info_content)
8559         (tui_alloc_source_buffer, tui_line_is_displayed)
8560         (tui_addr_is_displayed): Update.
8561         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8562         (tui_check_and_display_highlight_if_needed)
8563         (tui_win_info::make_visible, tui_win_info::refresh)
8564         (tui_refresh_all): Update.
8565         * tui/tui-windata.c (tui_first_data_item_displayed)
8566         (tui_delete_data_content_windows, tui_erase_data_content)
8567         (tui_display_all_data, tui_data_window::refresh_all)
8568         (tui_check_data_values): Update.
8569         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8570         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8571         (tui_win_info::backward_scroll, tui_refresh_all_win)
8572         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8573         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8574         (tui_source_window_base::set_new_height)
8575         (tui_data_window::set_new_height)
8576         (make_invisible_and_set_new_height)
8577         (make_visible_with_new_height, new_height_ok)
8578         (parse_scrolling_args): Update.
8579         * tui/tui-stack.c (tui_show_frame_info): Update.
8580         * tui/tui-source.c (tui_set_source_content)
8581         (tui_set_source_content_nil, tui_source_is_displayed)
8582         (tui_source_window::do_scroll_vertical): Update.
8583         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8584         (tui_display_registers_from, tui_display_reg_element_at_line)
8585         (tui_check_register_values, tui_reg_command): Update.
8586         * tui/tui-layout.c (tui_default_win_height)
8587         (show_source_disasm_command, show_data, init_and_make_win)
8588         (show_source_or_disasm_and_command): Update.
8589         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8590         (tui_redisplay_readline, tui_mld_flush)
8591         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8592         (tui_getc): Update.
8593         * tui/tui-disasm.c (tui_set_disassem_content)
8594         (tui_disasm_window::do_scroll_vertical): Update.
8595         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8596         Now virtual.
8597         (struct tui_win_info): Derive from tui_gen_win_info.
8598         <~tui_win_info>: Mark as override.
8599         <generic>: Remove member.
8600         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8601         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8602         (~tui_data_window, ~tui_win_info)
8603         (tui_free_all_source_wins_content): Update.
8604         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8605
8606 2019-06-25  Tom Tromey  <tom@tromey.com>
8607
8608         * tui/tui-layout.c (init_and_make_win): Use new.
8609         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8610         destructor, initializers.
8611         (tui_alloc_generic_win_info): Don't declare.
8612         * tui/tui-data.c (_locator): Add argument to constructor.
8613         (source_win, disasm_win): New globals.
8614         (exec_info): Remove.
8615         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8616         Update.
8617         (tui_alloc_generic_win_info): Remove.
8618         (init_content_element): Use new.
8619         (tui_win_info::tui_win_info): Update.
8620         (free_content_elements) <case DATA_WIN>: Use delete.
8621
8622 2019-06-25  Tom Tromey  <tom@tromey.com>
8623
8624         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8625         * tui/tui-windata.c (tui_first_data_item_displayed)
8626         (tui_delete_data_content_windows): Update.
8627         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8628         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8629         (tui_display_registers_from, tui_check_register_values): Update.
8630         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8631         pointer.
8632         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8633         window.
8634         (tui_free_data_content): Update.
8635         (free_content_elements) <case DATA_WIN>: Free the window.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8640         Update.
8641         * tui/tui-layout.c (make_command_window)
8642         (show_source_disasm_command, show_data, init_and_make_win)
8643         (show_source_or_disasm_and_command): Update.
8644         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8645         method.
8646         <can_highight, is_highlighted>: Now bool.
8647         (tui_set_win_highlight): Don't declare.
8648         * tui/tui-data.c (tui_set_win_highlight): Remove.
8649
8650 2019-06-25  Tom Tromey  <tom@tromey.com>
8651
8652         * tui/tui-wingeneral.c (make_visible): Remove check of window
8653         type.
8654
8655 2019-06-25  Tom Tromey  <tom@tromey.com>
8656
8657         * tui/tui-win.c (tui_win_info::max_height)
8658         (tui_cmd_window::max_height): New methods.
8659         (new_height_ok): Call max_height.
8660         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8661         <max_height>: New method.
8662
8663 2019-06-25  Tom Tromey  <tom@tromey.com>
8664
8665         * tui/tui-win.c (tui_source_window_base::set_new_height)
8666         (tui_data_window::set_new_height): New methods.
8667         (make_invisible_and_set_new_height): Call set_new_height method.
8668         * tui/tui-data.h (struct tui_win_info)
8669         (struct tui_source_window_base, struct tui_data_window)
8670         <set_new_height>: New method.
8671
8672 2019-06-25  Tom Tromey  <tom@tromey.com>
8673
8674         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8675         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8676         tui_refresh_data_win.
8677         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8678         method.
8679         (tui_refresh_all_win): Call the refresh_all method.
8680         (tui_set_focus): Likewise.
8681         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8682         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8683         Likewise.
8684
8685 2019-06-25  Tom Tromey  <tom@tromey.com>
8686
8687         * tui/tui-winsource.h (tui_refill_source_window)
8688         (tui_set_is_exec_point_at): Don't declare.
8689         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8690         (tui_source_window_base::refill): Rename from
8691         tui_refill_source_window.
8692         (tui_source_window_base::do_scroll_horizontal): Update.
8693         (tui_source_window_base::set_is_exec_point_at): Rename from
8694         tui_set_is_exec_point_at.
8695         (tui_update_all_breakpoint_info): Update.
8696         * tui/tui-stack.c (tui_show_frame_info): Update.
8697         * tui/tui-layout.c (show_data): Add cast.
8698         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8699         * tui/tui-data.h (struct tui_source_window_base) <refill,
8700         set_is_exec_point_at>: New methods.
8701         (tui_source_windows, tui_add_to_source_windows): Update types.
8702         (tui_add_to_source_windows): Remove redundant declaration.
8703         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8704         (tui_source_windows): Change return type.
8705         (tui_clear_source_windows_detail): Update.
8706         (tui_add_to_source_windows): Change type of parameter.
8707         (tui_free_all_source_wins_content): Update.
8708
8709 2019-06-25  Tom Tromey  <tom@tromey.com>
8710
8711         * tui/tui-wingeneral.c (tui_win_info::refresh)
8712         (tui_source_window_base::refresh): New methods.
8713         (tui_refresh_all): Call the refresh method.
8714         * tui/tui-data.h (struct tui_win_info)
8715         (struct tui_source_window_base) <refresh>: New method.
8716
8717 2019-06-25  Tom Tromey  <tom@tromey.com>
8718
8719         * tui/tui.h (tui_is_window_visible): Return bool.
8720         * tui/tui.c (tui_is_window_visible): Return bool.
8721         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8722         (tui_make_visible, tui_make_invisible)
8723         (tui_win_info::make_visible)
8724         (tui_source_window_base::make_visible, make_all_visible)
8725         (tui_make_all_visible, tui_make_all_invisible): Update.
8726         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8727         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8728         bool.
8729         (struct tui_win_info, struct tui_source_window_base)
8730         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8731         * tui/tui-data.c (tui_init_generic_part): Update.
8732
8733 2019-06-25  Tom Tromey  <tom@tromey.com>
8734
8735         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8736         (tui_source_window_base::make_visible): New methods.
8737         (make_all_visible): Make method call.
8738         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8739         (struct tui_source_window_base, struct tui_cmd_window): Override
8740         make_visible.
8741         (tui_win_is_source_type): Don't declare.
8742         * tui/tui-data.c (tui_win_is_source_type): Remove.
8743
8744 2019-06-25  Tom Tromey  <tom@tromey.com>
8745
8746         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8747         NULL check.
8748
8749 2019-06-25  Tom Tromey  <tom@tromey.com>
8750
8751         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8752         Inline constructor.  Add initializers for members.
8753         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8754         constructors; now inline in class.
8755
8756 2019-06-25  Tom Tromey  <tom@tromey.com>
8757
8758         * tui/tui-regs.c (tui_show_registers): Update.
8759         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8760         bool.
8761         * tui/tui-data.c (tui_data_window::clear_detail)
8762         (tui_data_window): Update.
8763
8764 2019-06-25  Tom Tromey  <tom@tromey.com>
8765
8766         * tui/tui-windata.c (tui_display_all_data)
8767         (tui_display_data_from_line, tui_display_data_from)
8768         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8769         Update.
8770         * tui/tui-regs.c (tui_last_regs_line_no)
8771         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8772         (tui_show_registers, tui_show_register_group)
8773         (tui_display_registers_from, tui_display_reg_element_at_line)
8774         (tui_display_registers_from_line, tui_check_register_values)
8775         (tui_reg_next, tui_reg_prev): Update.
8776         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8777         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8778         tui_data_window.
8779         (struct tui_win_info) <detail>: Remove.  Add new fields from
8780         tui_data_info.
8781         (TUI_DATA_WIN): Add cast.
8782         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8783         (~tui_data_window): Simplify.
8784
8785 2019-06-25  Tom Tromey  <tom@tromey.com>
8786
8787         * tui/tui-layout.c (show_source_disasm_command)
8788         (show_source_or_disasm_and_command): Update.
8789         * tui/tui-io.c (update_cmdwin_start_line)
8790         (tui_redisplay_readline): Update.
8791         * tui/tui-data.h (struct tui_command_info): Remove.
8792         (struct tui_win_info) <detail>: Remove command_info member.
8793         (struct tui_data_window) <start_line>: New member, from
8794         tui_command_info.
8795         (TUI_CMD_WIN): Add casts.
8796
8797 2019-06-25  Tom Tromey  <tom@tromey.com>
8798
8799         * tui/tui-winsource.c (tui_update_source_window)
8800         (tui_refill_source_window)
8801         (tui_source_window_base::do_scroll_horizontal)
8802         (tui_update_breakpoint_info, tui_set_exec_info_content)
8803         (tui_show_exec_info_content, tui_erase_exec_info_content)
8804         (tui_clear_exec_info_content): Update.
8805         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8806         Update.
8807         * tui/tui-win.c (make_invisible_and_set_new_height)
8808         (make_visible_with_new_height): Update.
8809         * tui/tui-source.c (tui_set_source_content)
8810         (tui_show_symtab_source): Update.
8811         * tui/tui-layout.c (extract_display_start_addr)
8812         (show_source_disasm_command, show_data)
8813         (make_source_or_disasm_window)
8814         (show_source_or_disasm_and_command): Update.
8815         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8816         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8817         "gdbarch".
8818         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8819         to tui_source_window_base.
8820         (struct tui_win_info) <detail>: Remove source_info member.
8821         (struct tui_source_window_base) <has_locator>: Inline.
8822         Move contents from tui_source_info; rename has_locator member to
8823         m_has_locator.
8824         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8825         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8826         header file.
8827         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8828         Simplify.
8829         (tui_free_all_source_wins_content): Cast to
8830         tui_source_window_base.
8831
8832 2019-06-25  Tom Tromey  <tom@tromey.com>
8833
8834         * tui/tui-win.c (make_invisible_and_set_new_height)
8835         (make_visible_with_new_height): Call has_locator method.
8836         * tui/tui-layout.c (show_source_disasm_command, show_data)
8837         (show_source_or_disasm_and_command): Update for bool change.
8838         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8839         (tui_win_info) <has_locator>: New method.
8840         (struct tui_source_window_base) <has_locator>: New method.
8841         (tui_win_has_locator): Don't declare.
8842         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8843         from tui_win_has_locator.
8844         (tui_source_window_base): Use false, not FALSE.
8845
8846 2019-06-25  Tom Tromey  <tom@tromey.com>
8847
8848         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8849         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8850         clear_detail method directly.
8851         (tui_clear_win_detail): Remove.
8852
8853 2019-06-25  Tom Tromey  <tom@tromey.com>
8854
8855         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8856         "this", not TUI_DISASM_WIN.
8857
8858 2019-06-25  Tom Tromey  <tom@tromey.com>
8859
8860         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8861         declare.
8862         * tui/tui-winsource.c
8863         (tui_source_window_base::do_scroll_horizontal): Rename from
8864         tui_horizontal_source_scroll.
8865         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8866         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8867         from tui_vertical_data_scroll.
8868         * tui/tui-win.h (tui_scroll): Don't declare.
8869         * tui/tui-win.c (tui_win_info::forward_scroll)
8870         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8871         (tui_win_info::right_scroll): Rename and update.
8872         (tui_scroll_forward_command, tui_scroll_backward_command)
8873         (tui_scroll_left_command, tui_scroll_right_command): Update.
8874         (tui_scroll): Remove.
8875         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8876         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8877         from tui_vertical_source_scroll.
8878         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8879         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8880         from tui_vertical_disassem_scroll.
8881         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8882         do_scroll_horizontal>: New methods.
8883         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8884         Likewise.
8885         (struct tui_source_window_base): Add do_scroll_horizontal.
8886         (struct tui_source_window, struct tui_disasm_window): Add
8887         do_scroll_vertical.
8888         (struct tui_data_window, struct tui_cmd_window): Add
8889         do_scroll_horizontal and do_scroll_vertical.
8890         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8891
8892 2019-06-25  Tom Tromey  <tom@tromey.com>
8893
8894         * tui/tui-data.h (struct tui_source_window_base): New struct.
8895         (struct tui_source_window): Derive from tui_source_window_base.
8896         (struct tui_disasm_window): New struct.
8897         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8898         from tui_source_window::clear_detail.
8899         (tui_source_window_base): Rename from tui_source_window.
8900         (~tui_source_window_base): Rename from ~tui_source_window.
8901         (tui_alloc_win_info): Create a tui_disasm_window.
8902
8903 2019-06-25  Tom Tromey  <tom@tromey.com>
8904
8905         * tui/tui-data.h (struct tui_source_window)
8906         (struct tui_data_window): Declare destructors.
8907         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8908         destructors.
8909         (tui_win_info): Simplify.
8910
8911 2019-06-25  Tom Tromey  <tom@tromey.com>
8912
8913         * tui/tui-winsource.c (tui_display_main)
8914         (tui_update_source_windows_with_addr)
8915         (tui_update_all_breakpoint_info): Update.
8916         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8917         (new_height_ok, parse_scrolling_args): Update.
8918         * tui/tui-stack.c (tui_show_frame_info): Update.
8919         * tui/tui-data.h (struct tui_list): Remove.
8920         (tui_source_windows): Return a reference to a std::vector.
8921         * tui/tui-data.c (source_windows): Now a std::vector.
8922         (tui_source_windows): Change return type.
8923         (tui_clear_source_windows): Rewrite.
8924         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8925         (tui_free_all_source_wins_content): Rewrite.
8926
8927 2019-06-25  Tom Tromey  <tom@tromey.com>
8928
8929         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8930         (struct tui_data_window, struct tui_cmd_window): Declare
8931         clear_detail method.
8932         * tui/tui-data.c (tui_source_window::clear_detail)
8933         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8934         methods.
8935         (tui_clear_win_detail): Simplify.
8936
8937 2019-06-25  Tom Tromey  <tom@tromey.com>
8938
8939         * tui/tui-layout.c (make_source_window, make_disasm_window)
8940         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8941         Return the new window.
8942         (show_source_disasm_command, show_data)
8943         (show_source_or_disasm_and_command): Update.
8944
8945 2019-06-25  Tom Tromey  <tom@tromey.com>
8946
8947         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8948         parameter.  Return the new window.
8949         (show_source_disasm_command): Update and remove NULL check.
8950         (show_source_or_disasm_and_command): Update.
8951
8952 2019-06-25  Tom Tromey  <tom@tromey.com>
8953
8954         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8955
8956 2019-06-25  Tom Tromey  <tom@tromey.com>
8957
8958         * tui/tui-data.h (struct tui_win_info): Make constructor
8959         protected.  Make destructor virtual.  Add initializers.
8960         (tui_source_window, tui_data_window, tui_cmd_window): New
8961         classes.
8962         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8963         constructor.  Add "type" parameter.
8964         (tui_source_window, tui_data_window, tui_cmd_window): New
8965         constructors.
8966         (tui_alloc_win_info): Instantiate the appropriate subclass.
8967
8968 2019-06-25  Tom Tromey  <tom@tromey.com>
8969
8970         * tui/tui-win.c (tui_resize_all): Use delete.
8971         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8972         destructor.
8973         (tui_free_window): Don't declare.
8974         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8975         Update.
8976
8977 2019-06-25  Tom Tromey  <tom@tromey.com>
8978
8979         * tui/tui-data.h (struct tui_win_info): Add constructor.
8980         * tui/tui-data.c (tui_alloc_win_info): Use new.
8981         (tui_free_window): Use delete.
8982
8983 2019-06-22  Tom Tromey  <tom@tromey.com>
8984
8985         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8986         declare.
8987         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8988
8989 2019-06-22  Tom Tromey  <tom@tromey.com>
8990
8991         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8992         declare.
8993         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8994
8995 2019-06-22  Tom de Vries  <tdevries@suse.de>
8996
8997         * dwarf2read.c (create_addrmap_from_aranges)
8998         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8999         instead of '%zu'.
9000
9001 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9002
9003         * dwarf2read.h (dwarf2_section_info_def): Remove.
9004         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9005         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9006         std::vector<dwarf2_section_info>.
9007         (struct dwo_file) <~dwo_file>: Remove.
9008         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9009         types field.
9010         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9011         (dwarf2_read_debug_names): Likewise.
9012         (create_debug_types_hash_table): Change parameter type to
9013         array_view, adjust code accordingly.
9014         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9015         (partial_die_info::fixup): Likewise.
9016         (determine_prefix): Likewise.
9017         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9018
9019 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9020
9021         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9022         gdb_bfd_ref_ptr.
9023         <~dwo_file>: Remove call to gdb_bfd_unref.
9024         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9025         gdb_bfd_ref_ptr::get.
9026
9027 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9028
9029         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9030         type to htab_up.
9031         * dwarf2read.c (struct dwo_file): Initialize fields.
9032         <~dwo_file>: New.
9033         (free_dwo_file): Remove, move content to ~dwo_file.
9034         (struct dwo_file_deleter): Remove.
9035         (dwo_file_up>: Remove custom deleter.
9036         (free_dwo_files): Remove.
9037         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9038         dwo_files.
9039         (process_skeletonless_type_units): Call unique_ptr::get.
9040         (allocate_dwo_file_hash_table): Add deleter to created hash
9041         table.  Change return type to htab_up.
9042         (lookup_dwo_file_slot): Don't memset dwo_file, call
9043         unique_ptr::get.
9044         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9045         (create_dwo_unit_in_dwp_v2): Likewise.
9046         (open_and_init_dwo_file): Likewise.
9047         (free_dwo_file_from_slot): Remove.
9048
9049 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9050
9051         * dwarf2read.h (struct dwarf2_section_info) <readin,
9052         is_virtual>: Change type to bool.
9053         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9054         true instead of 1.
9055
9056 2019-06-19  Tom Tromey  <tom@tromey.com>
9057
9058         * tui/tui-data.h (tui_init_content_element): Don't declare.
9059
9060 2019-06-19  Tom Tromey  <tom@tromey.com>
9061
9062         * tui/tui-data.h (tui_init_win_info): Don't declare.
9063
9064 2019-06-19  Tom de Vries  <tdevries@suse.de>
9065
9066         * dwarf2read.h (abstract_to_concrete): Change type to
9067         std::unordered_map<sect_offset, std::vector<sect_offset>,
9068         gdb::hash_enum<sect_offset>>.
9069
9070 2019-06-19  Tom Tromey  <tromey@adacore.com>
9071
9072         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9073         EVAL_AVOID_SIDE_EFFECTS specially.
9074
9075 2019-06-19  Tom Tromey  <tromey@adacore.com>
9076
9077         * source-cache.c (highlighter): New global.
9078         (source_cache::get_source_lines): Create a highlighter on demand.
9079
9080 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9081
9082         * defs.h (deprecated_interactive_hook): Delete declaration.
9083         * interps.c (clear_interpreter_hooks): Remove use of
9084         deprecated_interactive_hook.
9085         * top.c (deprecated_interactive_hook): Delete definition.
9086         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9087
9088 2019-06-18  Tom de Vries  <tdevries@suse.de>
9089
9090         PR gdb/24515
9091         * dwarf2read.h (abstract_to_concrete): Change type from
9092         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9093         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9094         * dwarf2read.c (read_variable): Update.
9095         (dwarf2_fetch_die_loc_sect_off): Update.
9096
9097 2019-06-17  Tom de Vries  <tdevries@suse.de>
9098
9099         PR gdb/24617
9100         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9101         accessing parent[parent_len - 1].
9102
9103 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9104
9105         PR gdb/24364
9106         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9107         call dtrace_process_dof with NULL dof.
9108
9109 2019-06-16  Tom de Vries  <tdevries@suse.de>
9110
9111         PR gdb/24445
9112         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9113
9114 2019-06-16  Tom Tromey  <tom@tromey.com>
9115
9116         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9117         (make_all_visible): Use address of member.
9118
9119 2019-06-16  Tom Tromey  <tom@tromey.com>
9120
9121         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9122         (tui_free_window, free_content, free_content_elements): Remove
9123         unnecessary cast.
9124         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9125         cast.
9126         * tui/tui-regs.c (tui_show_register_group)
9127         (tui_display_registers_from, tui_display_reg_element_at_line):
9128         Remove unnecessary cast.
9129
9130 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9131
9132         * linux-nat.c (normal_mask): Delete.
9133         (_initialize_linux_nat): Don't initialise normal_mask.
9134
9135 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9136
9137         PR gdb/24445
9138         * dwarf-index-write.h (write_psymtabs_to_index): Add
9139         dwz_basename parameter.
9140         * dwarf-index-write.c (write_gdbindex): Move file writing to
9141         write_gdbindex_1.  Change return type void.
9142         (assert_file_size): Move up, remove filename parameter.
9143         (write_gdbindex_1): New function.
9144         (write_debug_names): Change return type to void, call
9145         assert_file_size.
9146         (struct index_wip_file): New struct.
9147         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9148         file logic to index_wip_file.  Write index for dwz file if
9149         needed.
9150         (save_gdb_index_command): Pass basename of dwz file, if present.
9151         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9152         build-id of dwz file, if present.
9153         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9154         (dwarf2_get_dwz_file): Likewise.
9155         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9156         (dwarf2_get_dwz_file): Likewise.
9157
9158 2019-06-16  Tom Tromey  <tom@tromey.com>
9159
9160         * coffread.c (process_coff_symbol): Use xstrdup.
9161         * value.c (create_internalvar): Use xstrdup.
9162
9163 2019-06-16  Tom Tromey  <tom@tromey.com>
9164
9165         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9166         * breakpoint.c (stopin_command, stopat_command)
9167         (until_break_command, decode_location_default): Remove unnecessary
9168         cast.
9169         * utils.c (subset_compare): Remove unnecessary cast.
9170         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9171         cast.
9172         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9173         cast.
9174         * infcmd.c (path_command): Remove unnecessary cast.
9175         * coffread.c (decode_type): Remove unnecessary cast.
9176         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9177         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9178         * tui/tui-stack.c (tui_show_locator_content)
9179         (tui_show_frame_info): Remove unnecessary cast.
9180         * tui/tui-win.c (tui_scroll_forward_command)
9181         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9182         (parse_scrolling_args): Remove unnecessary cast.
9183         * tui/tui-data.c (init_win_info, tui_del_window)
9184         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9185         (free_content_elements): Remove unnecessary cast.
9186         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9187         unnecessary cast.
9188         * tui/tui-source.c (tui_set_source_content)
9189         (tui_vertical_source_scroll): Remove unnecessary cast.
9190         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9191         cast.
9192         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9193         * tui/tui-regs.c (tui_display_registers_from)
9194         (tui_display_register): Remove unnecessary cast.
9195         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9196         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9197         (make_visible): Remove unnecessary cast.
9198         * tui/tui-winsource.c (tui_erase_source_content)
9199         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9200         unnecessary cast.
9201         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9202         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9203         * stabsread.c (read_type, read_array_type, read_range_type):
9204         Remove unnecessary cast.
9205         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9206         (parse_symbol, parse_type, upgrade_type, parse_external)
9207         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9208         unnecessary cast.
9209         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9210
9211 2019-06-16  Tom Tromey  <tom@tromey.com>
9212
9213         * tui/tui-data.c (tui_alloc_generic_win_info)
9214         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9215         checks.
9216
9217 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9218             Andrew Burgess  <andrew.burgess@embecosm.com>
9219
9220         * f-typeprint.c (f_print_type): Don't return early for not
9221         associated or not allocated types.
9222         (f_type_print_varspec_suffix): Add print_rank parameter and print
9223         ranks of array types in case they dangling.
9224         (f_type_print_base): Add print_rank parameter.
9225
9226 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9227
9228         * NEWS: Mention new MI commands.
9229         * break-catch-throw.c (enum exception_event_kind): Move to
9230         breakpoint.h.
9231         (print_mention_exception_catchpoint): Output text as a single
9232         message.
9233         (catch_exception_command_1): Rename to...
9234         (catch_exception_event): ...this, make non-static, update header
9235         command, and change some parameter types.
9236         (catch_catch_command): Update for changes to
9237         catch_exception_command_1.
9238         (catch_throw_command): Likewise.
9239         (catch_rethrow_command): Likewise.
9240         * breakpoint.c (enum exception_event_kind): Delete.
9241         * breakpoint.h (enum exception_event_kind): Moved here from
9242         break-catch-throw.c.
9243         (catch_exception_event): Declare.
9244         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9245         (mi_cmd_catch_throw): New function.
9246         (mi_cmd_catch_rethrow): New function.
9247         (mi_cmd_catch_catch): New function.
9248         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9249         'catch-catch' entries.
9250         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9251         (mi_cmd_catch_rethrow): Declare.
9252         (mi_cmd_catch_catch): Declare.
9253
9254 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * annotate.c (annotate_source_line): Change return type to void,
9257         update implementation to match.
9258         * annotate.h (annotate_source_line): Change return type to void,
9259         update header comment.
9260         * stack.c (print_frame_info): Don't change what frame information
9261         is printed based on whether annotations are on or not.
9262
9263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9266         (annotate_source): Make static.
9267         (annotate_source_line): Moved from source.c and renamed from
9268         identify_source_line.  Update the return type.
9269         * annotate.h (annotate_source): Delete declaration.
9270         (annotate_source_line): Declaration moved from source.h, and
9271         renamed from identify_source_line.  Return type updated.
9272         * source.c (identify_source_line): Moved to annotate.c and renamed
9273         to annotate_source_line.
9274         (info_line_command): Remove check of annotation_level.
9275         * source.h (identify_source_line): Move declaration to annotate.h
9276         and rename to annotate_source_line.
9277         * stack.c: Add 'annotate.h' include.
9278         (print_frame_info): Remove check of annotation_level before
9279         calling annotate_source_line.
9280
9281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9282
9283         * source-cache.c (source_cache::get_plain_source_lines): Use
9284         open_source_file_with_line_charpos instead of just
9285         open_source_file, remove call to find_source_lines.
9286         (source_cache::get_source_lines): Likewise.
9287         * source.c (find_source_lines): Make static.
9288         (get_filename_and_charpos): Renamed into...
9289         (open_source_file_with_line_charpos): ..this along with changes to
9290         return a scoped_fd, and some other minor clean ups.
9291         (identify_source_line): Use open_source_file_with_line_charpos.
9292         (search_command_helper): Use open_source_file_with_line_charpos
9293         instead of just open_source_file, remove call to
9294         find_source_lines.
9295         * source.h (open_source_file_with_line_charpos): Declare new
9296         function.
9297         (find_source_lines): Delete declaration.
9298
9299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * source.c (get_filename_and_charpos): Remove fullname
9302         parameter.
9303         (identify_source_line): Update call to get_filename_and_charpos.
9304
9305 2019-06-14  Tom Tromey  <tromey@adacore.com>
9306
9307         PR gdb/24502:
9308         * ui-style.h (skip_ansi_escape): Update comment.
9309         * ui-file.h (class no_terminal_escape_file): New class.
9310         * ui-file.c (no_terminal_escape_file::write)
9311         (no_terminal_escape_file::puts): New methods.
9312         * cli/cli-logging.c (handle_redirections): Use
9313         no_terminal_escape_file.
9314
9315 2019-06-14  Tom Tromey  <tromey@adacore.com>
9316
9317         * NEWS: Move convenience variable news above Python news.
9318
9319 2019-06-14  Tom Tromey  <tom@tromey.com>
9320
9321         * gnulib: Move directory to top-level.
9322         * configure.ac: Don't configure gnulib.
9323         * configure: Rebuild.
9324         * common/common-defs.h: Use new path to gnulib.
9325         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9326         (GNULIB_H): Remove.
9327         (INCGNU): Look in new gnulib location.
9328         (HFILES_NO_SRCDIR): Remove gnulib files.
9329         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9330         (generated_files): Remove GNULIB_H.
9331         ($(LIBGNU), all-lib): Remove targets.
9332         (distclean): Don't mention GNULIB_BUILDDIR.
9333         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9334
9335 2019-06-14  Tom Tromey  <tromey@adacore.com>
9336
9337         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9338         Warn if symbol file does not provide any symbols.
9339
9340 2019-06-14  Tom Tromey  <tromey@adacore.com>
9341
9342         * source.c (find_and_open_source): Respect basenames_may_differ.
9343
9344 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * annotate.c (annotate_breakpoints_invalid): Make use of
9347         scoped_restore_terminal_state.
9348         (annotate_frames_invalid): Likewise.
9349
9350 2019-06-14  Tom Tromey  <tromey@adacore.com>
9351
9352         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9353         allow assignment to an internalvar.
9354
9355 2019-06-14  Tom Tromey  <tromey@adacore.com>
9356
9357         * ada-lex.l: Allow "_" in attribute names.
9358
9359 2019-06-14  Tom Tromey  <tromey@adacore.com>
9360
9361         PR gdb/24653:
9362         * regcache.c (registers_changed): Don't call alloca.
9363         * top.c (execute_command): Don't call alloca.
9364
9365 2019-06-13  Pedro Alves  <palves@redhat.com>
9366
9367         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9368         'expression'.  When parsing an expression, error out if there's
9369         junk after "unlimited".
9370         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9371         (do_set_command): Adjust calls to is_unlimited_literal.
9372
9373 2019-06-13  Pedro Alves  <palves@redhat.com>
9374
9375         * compile/compile.c (make_compile_options_def_group): Add braces
9376         around array_view initializer.
9377         * thread.c (make_thread_apply_all_options_def_group)
9378         (make_thread_apply_all_options_def_group): Likewise.
9379
9380 2019-06-13  Pedro Alves  <palves@redhat.com>
9381
9382         * NEWS (New commands): Mention "maint test-options
9383         require-delimiter", "maint test-options unknown-is-error", "maint
9384         test-options unknown-is-operand" and "maint show
9385         test-options-completion-result".
9386         (New command options, command completion): New section.
9387         (Completion improvements): New section.
9388         Mention that you can abbreviate "unlimited".
9389
9390 2019-06-13  Pedro Alves  <palves@redhat.com>
9391
9392         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9393         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9394         * unittests/cli-utils-selftests.c (test_parse_flags)
9395         (test_parse_flags_qcs): Delete.
9396         (test_cli_utils): Don't call deleted functions.
9397
9398 2019-06-13  Pedro Alves  <palves@redhat.com>
9399
9400         * thread.c: Include "cli/cli-option.h".
9401         (tp_array_compar_ascending): Global.
9402         (tp_array_compar): Delete function.
9403         (tp_array_compar_ascending, tp_array_compar_descending): New
9404         functions.
9405         (ascending_option_def, qcs_flag_option_def)
9406         (thr_qcs_flags_option_defs)
9407         (make_thread_apply_all_options_def_group)
9408         (make_thread_apply_options_def_group): New.
9409         (thread_apply_all_command): Use gdb::option::process_options.
9410         (thread_apply_command_completer)
9411         (thread_apply_all_command_completer): New.
9412         (thread_apply_command): Use gdb::option::process_options.
9413         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9414         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9415         to generate help text of "thread apply".  Adjust "taas"'s help.
9416         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9417         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9418
9419 2019-06-13  Pedro Alves  <palves@redhat.com>
9420
9421         * thread.c (thread_apply_command): Check for invalid TID with
9422         isdigit instead of !isalpha.
9423
9424 2019-06-13  Pedro Alves  <palves@redhat.com>
9425
9426         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9427         (validate_flags_qcs): New.
9428         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9429         (validate_flags_qcs): Declare.
9430         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9431         (make_frame_apply_options_def_group): New.
9432         (frame_apply_command_count): Process options with
9433         gdb::option::process_options.
9434         (frame_apply_completer): New.
9435         (frame_apply_level_completer, frame_apply_all_completer)
9436         (frame_apply_completer): New.
9437         (_initialize_stack): Update help of "frame apply", "frame apply
9438         level", "frame apply all" and "faas" to mention supported options
9439         and install command completers.
9440         * stack.h (frame_apply_all_completer): Declare.
9441         * thread.c: Include "stack.h".
9442         (tfaas_command): Add "--".
9443         (_initialize_thread): Update help "tfaas" to mention supported
9444         options and install command completer.
9445
9446 2019-06-13  Pedro Alves  <palves@redhat.com>
9447
9448         * completer.c (complete_nested_command_line): New.
9449         (gdb_completion_word_break_characters_throw): Add assertion.
9450         * completer.h (complete_nested_command_line): Declare.
9451
9452 2019-06-13  Pedro Alves  <palves@redhat.com>
9453
9454         * stack.c (parse_backtrace_qualifiers): New.
9455         (backtrace_command): Use it.
9456         (backtrace_command_completer): Complete on qualifiers.
9457
9458 2019-06-13  Pedro Alves  <palves@redhat.com>
9459
9460         * frame.c: Include "cli/cli-option.h.
9461         (user_set_backtrace_options): New.
9462         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9463         Delete.
9464         (get_prev_frame): Adjust.
9465         (boolean_option_def, uinteger_option_def)
9466         (set_backtrace_option_defs): New.
9467         (_initialize_frame): Adjust and use
9468         gdb::option::add_setshow_cmds_for_options to install "set
9469         backtrace past-main" and "set backtrace past-entry".
9470         * frame.h: Include "cli/cli-option.h".
9471         (struct frame_print_options): Forward declare.
9472         (print_frame_arguments_all, print_frame_arguments_scalars)
9473         (print_frame_arguments_none): Declare.
9474         (print_entry_values): Delete declaration.
9475         (struct frame_print_options, user_frame_print_options): New.
9476         (struct set_backtrace_options): New.
9477         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9478         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9479         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9480         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9481         (list_args_or_locals): Add frame_print_options parameter.
9482         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9483         * python/py-framefilter.c (enumerate_args): Pass down
9484         USER_FRAME_PRINT_OPTIONS.
9485         * stack.c: Include "cli/cli-option.h".
9486         (print_frame_arguments_all, print_frame_arguments_scalars)
9487         (print_frame_arguments_none): Declare.
9488         (print_raw_frame_arguments, print_entry_values): Delete.
9489         (user_frame_print_options): New.
9490         (boolean_option_def, enum_option_def, frame_print_option_defs):
9491         New.
9492         (struct backtrace_cmd_options): New.
9493         (bt_flag_option_def): New.
9494         (backtrace_command_option_defs): New.
9495         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9496         (print_frame_arg, read_frame_arg, print_frame_args)
9497         (print_frame_info, print_frame): Add frame_print_options parameter
9498         and use it.
9499         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9500         (backtrace_command_1): Add frame_print_options and
9501         backtrace_cmd_options parameters and use them.
9502         (make_backtrace_options_def_group): New.
9503         (backtrace_command): Process command options with
9504         gdb::option::process_options.
9505         (backtrace_command_completer): New.
9506         (_initialize_stack): Extend "backtrace"'s help to mention
9507         supported options.  Install completer for "backtrace".
9508         Install some settings commands with add_setshow_cmds_for_options.
9509
9510 2019-06-13  Pedro Alves  <palves@redhat.com>
9511
9512         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9513         and that "set/show print raw frame-arguments" are now deprecated.
9514
9515         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9516         command.
9517         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9518         * stack.c (_initialize_stack): Install "set/show print
9519         raw-frame-arguments", and deprecate "set/show print raw
9520         frame-arguments".
9521         * valprint.c (_initialize_valprint): Deprecate "set/show print
9522         raw".
9523
9524 2019-06-13  Pedro Alves  <palves@redhat.com>
9525
9526         * compile/compile.c (struct compile_options): New.
9527         (compile_flag_option_def, compile_command_option_defs)
9528         (make_compile_options_def_group): New.
9529         (compile_file_command): Handle options with
9530         gdb::option::process_options.
9531         (compile_file_command_completer): New function.
9532         (compile_code_command): Handle options with
9533         gdb::option::process_options.
9534         (compile_code_command_completer): New function.
9535         (_initialize_compiler): Install completers for "compile code" and
9536         "compile file".  Mention available options in "compile code" and
9537         "compile code"'s help.
9538         * completer.c (advance_to_completion_word): New, factored out from
9539         ...
9540         (advance_to_expression_complete_word_point): ... this.
9541         (advance_to_filename_complete_word_point): New.
9542         * completer.h (advance_to_filename_complete_word_point): New
9543         declaration.
9544
9545 2019-06-13  Pedro Alves  <palves@redhat.com>
9546
9547         * compile/compile.c: Include "cli/cli-option.h".
9548         (compile_print_value): Scope data pointer is now a
9549         value_print_options pointer; adjust.
9550         (compile_print_command): Process options.  Scope data pointer is
9551         now a value_print_options pointer; adjust.
9552         (_initialize_compile): Update "compile print"'s help to include
9553         supported options.  Install a completer for "compile print".
9554         * cp-valprint.c (show_vtblprint, show_objectprint)
9555         (show_static_field_print): Delete.
9556         (_initialize_cp_valprint): Don't install "set print
9557         static-members", "set print vtbl", "set print object" here.
9558         * printcmd.c: Include "cli/cli-option.h" and
9559         "common/gdb_optional.h".
9560         (print_command_parse_format): Rework to fill in a
9561         value_print_options instead of a format_data.
9562         (print_value): Change parameter type from format_data pointer to
9563         value_print_options reference.  Adjust.
9564         (print_command_1): Process options.  Adjust to pass down a
9565         value_print_options.
9566         (print_command_completer): New.
9567         (_initialize_printcmd): Install print_command_completer as
9568         handle_brkchars completer for the "print" command.  Update
9569         "print"'s help to include supported options.
9570         * valprint.c: Include "cli/cli-option.h".
9571         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9572         here from cp-valprint.c.
9573         (boolean_option_def, uinteger_option_def)
9574         (value_print_option_defs, make_value_print_options_def_group):
9575         New.  Use gdb::option::add_setshow_cmds_for_options to install
9576         "set print elements", "set print null-stop", "set print repeats",
9577         "set print pretty", "set print union", "set print array", "set
9578         print address", "set print symbol", "set print array-indexes".
9579         * valprint.h: Include <string> and "cli/cli-option.h".
9580         (make_value_print_options_def_group): Declare.
9581         (print_value): Change parameter type from format_data pointer to
9582         value_print_options reference.
9583         (print_command_completer): Declare.
9584
9585 2019-06-13  Pedro Alves  <palves@redhat.com>
9586
9587         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9588         (COMMON_SFILES): Add maint-test-settings.c.
9589         * cli/cli-decode.c (boolean_enums): New global, factored out from
9590         ...
9591         (add_setshow_boolean_cmd): ... here.
9592         * cli/cli-decode.h (boolean_enums): Declare.
9593         * cli/cli-option.c: New file.
9594         * cli/cli-option.h: New file.
9595         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9596         factored out from ...
9597         (parse_cli_boolean_value(const char *)): ... this.
9598         (is_unlimited_literal): Change parameter type to pointer to
9599         pointer.  Adjust and advance ARG pointer.
9600         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9601         (parse_cli_var_enum): New, factored out from ...
9602         (do_set_command): ... this.  Adjust.
9603         * cli/cli-setshow.h (parse_cli_boolean_value)
9604         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9605         (parse_cli_var_enum): Declare.
9606         * cli/cli-utils.c: Include "cli/cli-option.h".
9607         (get_ulongest): New.
9608         * cli/cli-utils.h (get_ulongest): Declare.
9609         (check_for_argument): New overloads.
9610         * maint-test-options.c: New file.
9611
9612 2019-06-13  Pedro Alves  <palves@redhat.com>
9613
9614         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9615         parse a range if "-" is at the end of the string.
9616
9617 2019-06-13  Pedro Alves  <palves@redhat.com>
9618
9619         * cli/cli-setshow.c (parse_auto_binary_operation)
9620         (parse_cli_boolean_value): Don't allow "o".
9621
9622 2019-06-13  Pedro Alves  <palves@redhat.com>
9623
9624         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9625         * NEWS: Mention maint test-settings KIND.
9626         * maint-test-settings.c: New file.
9627
9628 2019-06-13  Pedro Alves  <palves@redhat.com>
9629
9630         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9631         completer.
9632         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9633         "set" completers.
9634
9635 2019-06-13  Pedro Alves  <palves@redhat.com>
9636
9637         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9638         after item.
9639
9640 2019-06-13  Pedro Alves  <palves@redhat.com>
9641
9642         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9643
9644 2019-06-13  Pedro Alves <palves@redhat.com>
9645
9646         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9647         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9648         call.
9649         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9650         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9651         calls.
9652         (check_for_argument): Skip spaces after argument.
9653
9654 2019-06-13  Pedro Alves  <palves@redhat.com>
9655
9656         * thread.c (thread_apply_command): Adjust TID parsing.
9657         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9658         detected before end of string.
9659         (tid_is_in_list): Error out if LIST is invalid.
9660
9661 2019-06-13  Pedro Alves  <palves@redhat.com>
9662
9663         * completer.c (complete_line_internal_1): Rewind completion word
9664         point.
9665         (completion_tracker::advance_custom_word_point_by): Change
9666         parameter type to int.
9667         * completer.h (completion_tracker::advance_custom_word_point_by):
9668         Likewise.
9669
9670 2019-06-13  Pedro Alves  <palves@redhat.com>
9671
9672         * completer.c (advance_to_completion_word): Handle delimiters.
9673
9674 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9675
9676         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9677
9678 2019-06-11  Tom Tromey  <tom@tromey.com>
9679
9680         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9681         (xmalloc_failed): Move to alloc.c.
9682         * alloc.c: New file.
9683         * Makefile.in (COMMON_SFILES): Add alloc.c.
9684
9685 2019-06-11  Tom Tromey  <tom@tromey.com>
9686
9687         * nat/linux-waitpid.c: Don't include server.h.
9688         (linux_debug): Remove.
9689         (my_waitpid): Update.
9690
9691 2019-06-11  Tom Tromey  <tromey@adacore.com>
9692
9693         * infcall.c (_initialize_infcall): Remove trailing newline from
9694         help.
9695         * user-regs.c (_initialize_user_regs): Remove trailing newline
9696         from help.
9697         * typeprint.c (_initialize_typeprint): Remove trailing newline
9698         from help.
9699         * reverse.c (_initialize_reverse): Remove trailing newlines from
9700         help.
9701         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9702         from help.
9703         * language.c (add_set_language_command): Remove trailing newline
9704         from help.
9705         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9706         help.
9707         * disasm.c (_initialize_disasm): Remove trailing newline from
9708         help.
9709         * top.c (init_main): Remove trailing newline from help.
9710         * interps.c (_initialize_interpreter): Remove trailing newline
9711         from help.
9712         * btrace.c (_initialize_btrace): Remove trailing newlines from
9713         help.
9714         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9715         from help.
9716         * python/python.c (_initialize_python): Remove trailing newline
9717         from help.
9718         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9719         help.
9720         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9721         from help.  Reformat some text.
9722         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9723         from help.
9724         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9725         newline from help.
9726
9727 2019-06-11  Tom Tromey  <tromey@adacore.com>
9728
9729         * darwin-nat.c (darwin_decode_exception_message)
9730         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9731
9732 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * valops.c (value_slice): Check for not allocated or not
9735         associated values.
9736
9737 2019-06-10  Tom de Vries  <tdevries@suse.de>
9738
9739         PR gdb/24618
9740         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9741         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9742         invalid.
9743
9744 2019-06-10  Tom de Vries  <tdevries@suse.de>
9745
9746         PR gdb/24611
9747         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9748         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9749
9750 2019-06-10  Tom de Vries  <tdevries@suse.de>
9751
9752         PR symtab/24545
9753         * symtab.c (struct demangled_name_entry): Add language field.
9754         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9755         static minimal symbol".  Set and use language field.
9756
9757 2019-06-10  Tom Tromey  <tromey@adacore.com>
9758
9759         * ada-lang.c (_initialize_ada_language): Update help text.
9760
9761 2019-06-10  Tom Tromey  <tromey@adacore.com>
9762
9763         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9764         with a newline.
9765         * guile/guile.c (handle_boot_error): Don't end warning with a
9766         newline.
9767         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9768         warning with a newline.
9769         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9770         newline.
9771         (s12z_frame_cache): Likewise.
9772         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9773         a newline.
9774         * solib-svr4.c (disable_probes_interface): Don't end warning with
9775         a newline.
9776         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9777         newline.
9778         * python/python.c (do_finish_initialization): Don't end warning
9779         with a newline.
9780
9781 2019-06-10  Tom Tromey  <tom@tromey.com>
9782
9783         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9784         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9785         gdbpy_enter.
9786
9787 2019-06-10  Tom Tromey  <tromey@adacore.com>
9788
9789         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9790         data.
9791         (elf_new_init): Don't call stabsread_new_init.
9792         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9793         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9794         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9795
9796 2019-06-10  Tom de Vries  <tdevries@suse.de>
9797
9798         PR symtab/16264
9799         PR symtab/24517
9800         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9801
9802 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9803
9804         * source.c (find_and_open_source): Also rewrite relative file
9805         names.
9806
9807 2019-04-26  Amos Bird  <amosbird@gmail.com>
9808
9809         * annotate.c (annotate_thread_exited): Add "thread-exited"
9810         annotation.
9811
9812 2019-06-06  Tom Tromey  <tromey@adacore.com>
9813
9814         * maint.h (class scoped_command_stats): Use
9815         DISABLE_COPY_AND_ASSIGN.
9816         <print_time>: New method.
9817         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9818         print_time.
9819         (scoped_command_stats::print_time): New method.
9820
9821 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9824         instructions of lengths 6 or 8 bytes.
9825
9826 2019-06-04  Pedro Alves  <palves@redhat.com>
9827
9828         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9829
9830         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9831         * breakpoint.c (condition_completer): Likewise.
9832         * cli/cli-dump.c (scan_expression): Likewise.
9833         * common/filestuff.c (mkdir_recursive): Likewise.
9834         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9835         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9836         (gdb_abspath): Likewise.
9837         * compile/compile-cplus-types.c
9838         (compile_cplus_instance::decl_name): Likewise.
9839         * completer.c (complete_explicit_location):
9840         (signal_completer, reg_or_group_completer_1): Likewise.
9841         * cp-support.c (cp_remove_params_if_any): Likewise.
9842         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9843         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9844         * infcmd.c (strip_bg_char): Likewise.
9845         * linespec.c (copy_token_string): Likewise.
9846         * mi/mi-main.c (output_cores): Likewise.
9847         * psymtab.c (psymtab_search_name):
9848         * symfile.c (test_set_ext_lang_command): Likewise.
9849         * target.c (target_fileio_read_stralloc): Likewise.
9850         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9851         * value.c (complete_internalvar): Likewise.
9852
9853 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9854
9855         Add objfile property to gdb.Type.
9856         * NEWS: Mention Python API addition.
9857         * python/py-type.c (typy_get_objfile): New method.
9858
9859 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9860
9861         * NEWS: Mention the new set|show style [title|highlight].
9862         Mention changes to "show style", "help" and "apropos".
9863
9864 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9865
9866         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9867         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9868         instead of print_help_for_command.
9869         (print_doc_of_command): New function.
9870         (help_list): Add 'apropos -v word' suggestion.
9871         (print_help_for_command): Style the command name using title style.
9872         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9873         (_initialize_cli_cmds): Describe -v in apropos_command help.
9874
9875 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9876
9877         * cli/cli-style.h (cli_style_option): Add name in constructor,
9878         add m_name class member, add constructor with intensity,
9879         add name class function.
9880         (cli_style_option::add_setshow_commands): Remove name argument.
9881         (highlight_style, title_style): New styles.
9882         * cli/cli-style.c (do_show): New function that shows a style
9883         characteristic styling the style name with itself.
9884         (set_style_name): New function.
9885         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9886         Update all callers according to the changes in cli/cli-style.h.
9887         * utils.h (fputs_highlighted): New function.
9888         * utils.c (fputs_highlighted): Likewise.
9889
9890 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9891
9892         * NEWS: Mention new pipe command and new convenience variables.
9893
9894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9895
9896         * cli/cli-cmds.c (pipe_command): New function.
9897         (_initialize_cli_cmds): Call add_com for pipe_command.
9898         Define | as an alias for pipe.
9899         (exit_status_set_internal_vars): New function.
9900         (shell_escape): Call exit_status_set_internal_vars.
9901         cli/cli-decode.c (find_command_name_length): Recognize | as
9902         a single character command.
9903
9904 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9905
9906         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9907         top.c (execute_command_to_ui_file): New function, mostly a copy
9908         of execute_command_to_string.
9909         (execute_command_to_string): Implement by calling
9910         execute_command_to_ui_file.
9911
9912 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9913
9914         * top.h (saved_command_line): Remove declaration.
9915         * top.c (previous_saved_command_line, previous_repeat_arguments):
9916         New variables.
9917         (saved_command_line): Make static, define together with other
9918         'repeat variables'.
9919         (dont_repeat): Clear repeat_arguments.
9920         (repeat_previous, get_saved_command_line, save_command_line):
9921         New functions.
9922         (gdb_init): Initialize saved_command_line
9923         and previous_saved_command_line.
9924         * main.c (captured_main_1): Remove saved_command_line initialization.
9925         * event-top.c (handle_line_of_input): Update to use
9926         the new 'repeat' related functions instead of direct access to
9927         saved_command_line.
9928         * command.h (repeat_previous, get_saved_command_line,
9929         save_command_line): New declarations.
9930         (dont_repeat): Add comment.
9931
9932 2019-05-30  Tom Tromey  <tromey@adacore.com>
9933
9934         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9935         Fix comment.
9936         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9937
9938 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9939
9940         PR cli/24587
9941         * completer.c (complete): Initialize variable word.
9942
9943 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9944
9945         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9946         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9947         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9948         'body' is NULL to the outter 'if', protecting the '!is_define'
9949         situation as well.
9950
9951 2019-05-29  Tom Tromey  <tromey@adacore.com>
9952
9953         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9954         (dwarf_unknown): New function.
9955         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9956         (dwarf_type_encoding_name): Use dwarf_unknown.
9957
9958 2019-05-29  Tom Tromey  <tromey@adacore.com>
9959
9960         PR c++/20020:
9961         * cp-valprint.c (cp_print_value_fields): Call
9962         cp_print_static_field inside "try".
9963
9964 2019-05-29  Tom Tromey  <tromey@adacore.com>
9965
9966         * inflow.c (struct terminal_info): Add default operator=.
9967         * configure: Rebuild.
9968         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9969         -Wdeprecated-copy-dtor, -Wredundant-move.
9970
9971 2019-05-29  Tom Tromey  <tromey@adacore.com>
9972
9973         * NEWS: Add entry.
9974         * infcmd.c (print_return_value_1): Handle finish_print
9975         option.
9976         (show_print_finish): New function.
9977         (_initialize_infcmd): Add "set/show print finish" commands.
9978         * valprint.c (user_print_options): Initialize new member.
9979         * valprint.h (struct value_print_options) <finish_print>: New
9980         member.
9981
9982 2019-05-28  Tom Tromey  <tromey@adacore.com>
9983
9984         * ada-lang.c (ada_remove_Xbn_suffix)
9985         (find_old_style_renaming_symbol)
9986         (parse_old_style_renaming): Remove.
9987         (ada_find_renaming_symbol): Don't call
9988         find_old_style_renaming_symbol.
9989         (ada_is_renaming_symbol): Rename from
9990         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9991         bool.  Now static.
9992         (ada_read_var_value): Update and simplify.
9993         * ada-exp.y (write_var_or_type): Remove old code.
9994
9995 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9996
9997         PR gdb/25010
9998         * event-top.c: Remove include comment.
9999         * inflow.c (class scoped_ignore_sigttou): Move from here...
10000         * inflow.h (class scoped_ignore_sigttou): ...to here.
10001         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10002         * top.c:  Remove include comment.
10003
10004 2019-05-27  Tom Tromey  <tom@tromey.com>
10005
10006         * NEWS: Fix typo.
10007
10008 2019-05-22  Tom Tromey  <tromey@adacore.com>
10009
10010         * target.c (target_follow_exec): Constify parameter.
10011         * target-delegates.c: Rebuild.
10012         * remote.c (remote_target::follow_exec): Constify parameter.
10013         * infrun.c (follow_exec): Constify parameter.
10014         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10015         (target_follow_exec): Likewise.
10016
10017 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10018
10019         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10020         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10021
10022 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10023
10024         * NEWS: Add debugredirect and testsuite sections.
10025
10026 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10027
10028         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10029         target descriptions using exclusively floating point register name
10030         aliases.
10031
10032 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10033
10034         PR gdb/18644:
10035         * f-lang.c (build_fortran_types): Handle the case where
10036         gdbarch_floatformat_for_type returns a nullptr.
10037
10038 2019-05-21  Tom de Vries  <tdevries@suse.de>
10039
10040         PR cli/24587
10041         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10042
10043 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10044
10045         PR gdb/18644:
10046         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10047         16-byte floats.
10048         * i386-tdep.c (i386_floatformat_for_type): Use
10049         floatformats_ia64_quad for the 16-byte floating point component
10050         within a fortran 32-byte complex number.
10051
10052 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10053
10054         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10055         delete default constructor.
10056         (find_partial_die): Update to return const struct.
10057         (partial_die_parent_scope): Move variable declaration into scope
10058         of its use and change its type to auto.
10059         (guess_partial_die_structure_name): Likewise.
10060         (partial_die_info::fixup): Likewise.
10061
10062 2019-05-17  Tom Tromey  <tromey@adacore.com>
10063
10064         * source.c (find_and_open_source): Remove cast.
10065
10066 2019-05-17  Tom Tromey  <tromey@adacore.com>
10067
10068         * annotate.c (annotate_source): Make "filename" const.
10069         * annotate.h (annotate_source): Use const.
10070
10071 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10072
10073         * disasm.c (set_disassembler_options): Send errors to stderr.
10074
10075 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10076
10077         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10078         (cli_interp_base::set_logging): Check debug_redirect.
10079         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10080         * cli/cli-logging.c (debug_redirect): Add static variable.
10081         (pop_output_files): Add default param.
10082         (handle_redirections): Print debug setting.
10083         (show_logging_command): Likewise.
10084         (_initialize_cli_logging): Add debugredirect command.
10085         * interps.c (current_interp_set_logging): Add debug_redirect
10086         parameter.
10087         * interps.h (set_logging): Add debug_redirect parameter.
10088         (current_interp_set_logging): Likewise.
10089         * mi/mi-common.h: Likewise.
10090         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10091
10092 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10093             Tom Tromey  <tromey@adacore.com>
10094
10095         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10096         directly.
10097         * cli/cli-interp.h (make_logging_output): Remove declaration.
10098         * cli/cli-logging.c (make_logging_output): Remove function.
10099         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10100         directly.
10101         * ui-file.c (tee_file::tee_file): Remove bools.
10102         (tee_file::~tee_file): Remove deletes.
10103         * ui-file.h (tee_file): Remove bools.
10104
10105 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10106
10107         * mi/mi-cmds.h (mi_cmd_complete): New function.
10108         * mi/mi-main.c (mi_cmd_complete): Likewise.
10109         * mi/mi-cmds.c: Define new MI command -complete.
10110         * NEWS: Mention new -complete command.
10111
10112 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10113
10114         * completer.h (complete): New function.
10115         * completer.c (complete): Likewise.
10116         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10117         function defined in completer.h.
10118
10119 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10120
10121         * MAINTAINERS (Write After Approval): Add myself.
10122
10123 2019-05-17  Tom de Vries  <tdevries@suse.de>
10124
10125         PR gdb/24094
10126         * dwarf2read.c (struct cu_partial_die_info): New struct.
10127         (find_partial_die): Return cu_partial_die_info.
10128         (partial_die_parent_scope, guess_partial_die_structure_name)
10129         (partial_die_info::fixup): Handle new return type of find_partial_die.
10130
10131 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10132
10133         PR breakpoints/24541
10134         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10135         "std::string", simplifying the algorithm.
10136
10137 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10138
10139         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10140         (stap_static_probe_ops::get_probes): Likewise.
10141
10142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10143
10144         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10145         '-')" and "else if".
10146         (stap_parse_single_operand): Join checks for
10147         "gdbarch_stap_parse_special_token_p" and
10148         "gdbarch_stap_parse_special_token" in the same "if" statement.
10149         Invert check when verifying for operation on register
10150         displacement.
10151
10152 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10153
10154         * stap-probe.c (stap_get_opcode): Update comment.
10155         (stap_get_expected_argument_type): Likewise.
10156         (handle_stap_probe): Likewise.
10157
10158 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10159
10160         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10161         return type to 'bool'.  Adjust comment.  Use 'bool' when
10162         appropriate.
10163         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10164         * stap-probe.c (stap_parse_argument_1): Likewise.
10165         (stap_is_operator): Likewise.
10166         (stap_is_generic_prefix): Likewise.
10167         (stap_is_register_prefix): Likewise.
10168         (stap_is_register_indirection_prefix): Likewise.
10169         (stap_is_integer_prefix): Likewise.
10170         (stap_generic_check_suffix): Likewise.
10171         (stap_check_integer_suffix): Likewise.
10172         (stap_check_register_suffix): Likewise.
10173         (stap_check_register_indirection_suffix): Likewise.
10174         (stap_parse_register_operand): Likewise.
10175         (stap_parse_single_operand): Likewise.
10176         (stap_parse_argument_1): Likewise.
10177         (stap_probe::get_argument_count): Likewise.
10178         (stap_is_operator): Likewise.
10179
10180 2019-05-16  Tom Tromey  <tromey@adacore.com>
10181
10182         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10183         keyword to foreach.
10184
10185 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10186
10187         * linux-thread-db.c (try_thread_db_load_1): Change return type
10188         to bool.
10189         (try_thread_db_load): Likewise.
10190         (try_thread_db_load_from_pdir_1): Likewise.
10191         (try_thread_db_load_from_pdir): Likewise.
10192         (try_thread_db_load_from_sdir): Likewise.
10193         (try_thread_db_load_from_dir): Likewise.
10194         (thread_db_load_search): Likewise.
10195         (has_libpthread): Likewise.
10196         (thread_db_load): Likewise.
10197
10198 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10199
10200         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10201         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10202         NULL, and complain/return if that's the case.
10203
10204 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10205
10206         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10207         (advance, posn, abstract_read_memory): New functions.
10208         [struct mem_read_abstraction]: New struct.
10209         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10210
10211 2019-05-14  Tom Tromey  <tromey@adacore.com>
10212
10213         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10214         value is not lval_memory.
10215
10216 2019-05-14  Tom Tromey  <tromey@adacore.com>
10217
10218         * solib.c (info_sharedlibrary_command): Style the file name.
10219
10220 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10221
10222         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10223         (aarch64_vnv_type): Likewise.
10224         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10225         * common/tdesc.c: Likewise.
10226         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10227         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10228         * features/aarch64-fpu.xml: Add ieee half view.
10229         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10230         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10231         * gdbtypes.h (struct builtin_type): Likewise.
10232         (struct objfile_type): Likewise.
10233
10234 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10235
10236         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10237         typo.
10238         * location.h (string_to_event_location): Likewise.
10239
10240 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10241
10242         GDB 8.3 released.
10243
10244 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10245
10246         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10247         New variable declaration.
10248         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10249         New variable.
10250         (print_one_breakpoint): Use ui_out::test_flags and new global
10251         variable to compute use_fixed_output.
10252         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10253         Remove.
10254         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10255         (mi_multi_location_breakpoint_output_fixed): Remove.
10256         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10257         new variable.
10258         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10259         fix_multi_location_breakpoint_output flag if version >= 3.
10260         * ui-out.h (enum ui_out_flag)
10261         <fix_multi_location_breakpoint_output>: New enumerator.
10262
10263 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10264
10265         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10266
10267 2019-05-10  Tom Tromey  <tromey@adacore.com>
10268
10269         * ada-lang.c (catch_ada_completer): New function.
10270         (_initialize_ada_language): Use it.
10271
10272 2019-05-10  Tom Tromey  <tromey@adacore.com>
10273
10274         * thread.c (print_thread_info): Make "requested_threads" const.
10275         * gdbthread.h (print_thread_info): Make "requested_threads"
10276         const.
10277         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10278         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10279
10280 2019-05-08  Tom Tromey  <tom@tromey.com>
10281
10282         * gdbtypes.c (objfile_type_data): Change type.
10283         (objfile_type, _initialize_gdbtypes): Update.
10284
10285 2019-05-08  Tom Tromey  <tom@tromey.com>
10286
10287         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10288         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10289         (_initialize_dwarf2_frame): Update.
10290
10291 2019-05-08  Tom Tromey  <tom@tromey.com>
10292
10293         * objc-lang.c (objc_objfile_data): Change type.
10294         (find_methods): Update.
10295         (_initialize_objc_lang): Remove.
10296
10297 2019-05-08  Tom Tromey  <tom@tromey.com>
10298
10299         * stabsread.c (rs6000_builtin_type_data): Change type.
10300         (rs6000_builtin_type, _initialize_stabsread): Update.
10301
10302 2019-05-08  Tom Tromey  <tom@tromey.com>
10303
10304         * mips-tdep.c (mips_pdr_data): Remove.
10305         (_initialize_mips_tdep): Update.
10306
10307 2019-05-08  Tom Tromey  <tom@tromey.com>
10308
10309         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10310         (hppa_init_objfile_priv_data, read_unwind_info)
10311         (find_unwind_entry, _initialize_hppa_tdep): Update.
10312
10313 2019-05-08  Tom Tromey  <tom@tromey.com>
10314
10315         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10316         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10317         on obstack.
10318         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10319
10320 2019-05-08  Tom Tromey  <tom@tromey.com>
10321
10322         * mdebugread.c (basic_type_data): Change type.
10323         (basic_type, _initialize_mdebugread): Update.
10324
10325 2019-05-08  Tom Tromey  <tom@tromey.com>
10326
10327         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10328
10329 2019-05-08  Tom Tromey  <tom@tromey.com>
10330
10331         * nto-tdep.c (nto_inferior_data_reg): Change type.
10332         (nto_inferior_data): Update.
10333         (nto_inferior_data_cleanup, nto_new_inferior_data)
10334         (_initialize_nto_tdep): Remove.
10335         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10336
10337 2019-05-08  Tom Tromey  <tom@tromey.com>
10338
10339         * ada-lang.c (struct ada_inferior_data): Add initializers.
10340         (ada_inferior_data): Change type.
10341         (ada_inferior_data_cleanup): Remove.
10342         (get_ada_inferior_data, ada_inferior_exit)
10343         (struct ada_pspace_data): Add initializers, destructor.
10344         (ada_pspace_data_handle): Change type.
10345         (get_ada_pspace_data): Update.
10346         (ada_pspace_data_cleanup): Remove.
10347
10348 2019-05-08  Tom Tromey  <tom@tromey.com>
10349
10350         * coffread.c (struct coff_symfile_info): Add initializers.
10351         (coff_objfile_data_key): Move lower.  Change type.
10352         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10353         Update.
10354         (coff_free_info): Remove.
10355
10356 2019-05-08  Tom Tromey  <tom@tromey.com>
10357
10358         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10359         (fbsd_pspace_data_handle): Move lower.  Change type.
10360         (get_fbsd_pspace_data): Update.
10361         (fbsd_pspace_data_cleanup): Remove.
10362         (_initialize_fbsd_tdep): Update.
10363
10364 2019-05-08  Tom Tromey  <tom@tromey.com>
10365
10366         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10367         (get_ada_tasks_pspace_data): Update.
10368         (ada_tasks_pspace_data_cleanup): Remove.
10369         (_initialize_tasks): Update.
10370         (ada_tasks_inferior_data_handle): Change type.
10371         (get_ada_tasks_inferior_data): Update.
10372         (ada_tasks_inferior_data_cleanup): Remove.
10373         (struct ada_tasks_pspace_data): Add initializers.
10374
10375 2019-05-08  Tom Tromey  <tom@tromey.com>
10376
10377         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10378         * symfile-debug.c (debug_sym_get_probes): Change type.
10379         * stap-probe.c (handle_stap_probe):
10380         (stap_static_probe_ops::get_probes): Change type.
10381         * probe.h (class static_probe_ops) <get_probes>: Change type.
10382         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10383         (parse_probes_in_pspace): Update.
10384         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10385         Update.
10386         (any_static_probe_ops::get_probes): Change type.
10387         * elfread.c (elfread_data): New typedef.
10388         (probe_key): Change type.
10389         (elf_get_probes): Likewise.  Update.
10390         (probe_key_free): Remove.
10391         (_initialize_elfread): Update.
10392         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10393         Change type.
10394         (dtrace_process_dof_probe, dtrace_process_dof)
10395         (dtrace_static_probe_ops::get_probe): Change type.
10396
10397 2019-05-08  Tom Tromey  <tom@tromey.com>
10398
10399         * xcoffread.c (struct xcoff_symfile_info): Rename from
10400         coff_symfile_info.  Add initializers.
10401         (xcoff_objfile_data_key): Move lower.  Change type.
10402         (XCOFF_DATA): Rewrite.
10403         (xcoff_free_info): Remove.
10404         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10405         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10406         (xcoff_initial_scan): Update.
10407
10408 2019-05-08  Tom Tromey  <tom@tromey.com>
10409
10410         * solib-svr4.c (struct svr4_info): Add initializers and
10411         destructor.
10412         <probes_table>: Now an htab_up.
10413         (solib_svr4_pspace_data): Change type.
10414         (free_probes_table): Simplify.
10415         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10416         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10417         (probes_table_remove_objfile_probes, register_solib_event_probe)
10418         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10419         (_initialize_svr4_solib): Update.
10420
10421 2019-05-08  Tom Tromey  <tom@tromey.com>
10422
10423         * remote.c (remote_pspace_data): Change type.
10424         (remote_pspace_data_cleanup): Remove.
10425         (get_remote_exec_file, set_pspace_remote_exec_file)
10426         (_initialize_remote): Update.
10427
10428 2019-05-08  Tom Tromey  <tom@tromey.com>
10429
10430         * breakpoint.c (breakpoint_objfile_key): Change type.
10431         (get_breakpoint_objfile_data): Update.
10432         (free_breakpoint_objfile_data): Remove.
10433         (_initialize_breakpoint): Update.
10434
10435 2019-05-08  Tom Tromey  <tom@tromey.com>
10436
10437         * linux-tdep.c (struct linux_info): Add initializers.
10438         (linux_inferior_data): Move.  Change type.
10439         (invalidate_linux_cache_inf): Update.
10440         (linux_inferior_data_cleanup): Remove.
10441         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10442
10443 2019-05-08  Tom Tromey  <tom@tromey.com>
10444
10445         * auxv.c (auxv_inferior_data): Move.  Change type.
10446         (auxv_inferior_data_cleanup): Remove.
10447         (invalidate_auxv_cache_inf): Rewrite.
10448         (get_auxv_inferior_data, _initialize_auxv): Update.
10449
10450 2019-05-08  Tom Tromey  <tom@tromey.com>
10451
10452         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10453         (symfile_debug_objfile_data_key): Change type.
10454         (symfile_debug_installed, debug_qf_has_symbols)
10455         (debug_qf_find_last_source_symtab)
10456         (debug_qf_forget_cached_source_info)
10457         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10458         (debug_qf_print_stats, debug_qf_dump)
10459         (debug_qf_expand_symtabs_for_function)
10460         (debug_qf_expand_all_symtabs)
10461         (debug_qf_expand_symtabs_with_fullname)
10462         (debug_qf_map_matching_symbols)
10463         (debug_qf_expand_symtabs_matching)
10464         (debug_qf_find_pc_sect_compunit_symtab)
10465         (debug_qf_map_symbol_filenames)
10466         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10467         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10468         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10469         (debug_sym_read_linetable, debug_sym_relocate): Update.
10470         (symfile_debug_free_objfile): Remove.
10471         (install_symfile_debug_logging, _initialize_symfile_debug):
10472         Update.
10473
10474 2019-05-08  Tom Tromey  <tom@tromey.com>
10475
10476         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10477         allocate_on_obstack.
10478         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10479         (get_dwarf2_per_objfile): Update.
10480         (set_dwarf2_per_objfile): Remove.
10481         (dwarf2_has_info, dwarf2_get_section_info): Update.
10482         (dwarf2_free_objfile): Remove.
10483         (_initialize_dwarf2_read): Update.
10484
10485 2019-05-08  Tom Tromey  <tom@tromey.com>
10486
10487         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10488         initializers.
10489         <unsupported_script_warning_printed,
10490         script_not_found_warning_printed>: Now bool.
10491         (auto_load_pspace_data): Change type.
10492         (~auto_load_pspace_info): Rename from
10493         auto_load_pspace_data_cleanup.
10494         (get_auto_load_pspace_data, init_loaded_scripts_info)
10495         (clear_section_scripts, maybe_print_unsupported_script_warning)
10496         (maybe_print_script_not_found_warning, _initialize_auto_load):
10497         Update.
10498
10499 2019-05-08  Tom Tromey  <tom@tromey.com>
10500
10501         * objfiles.c (objfile_pspace_info): Add destructor and
10502         initializers.
10503         (objfiles_pspace_data): Change type.
10504         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10505         (get_objfile_pspace_data): Update.
10506         (objfiles_bfd_data): Change type.
10507         (get_objfile_bfd_data): Update.
10508         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10509
10510 2019-05-08  Tom Tromey  <tom@tromey.com>
10511
10512         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10513         Change type.
10514         (get_catch_syscall_inferior_data): Update.
10515         (catch_syscall_inferior_data_cleanup): Remove.
10516         (_initialize_break_catch_syscall): Update.
10517
10518 2019-05-08  Tom Tromey  <tom@tromey.com>
10519
10520         * inflow.c (struct terminal_info): Add destructor and
10521         initializers.
10522         (inflow_inferior_data): Change type.
10523         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10524         (get_inflow_inferior_data, inflow_inferior_exit)
10525         (swap_terminal_info, _initialize_inflow): Update.
10526
10527 2019-05-08  Tom Tromey  <tom@tromey.com>
10528
10529         * target-dcache.c (target_dcache_cleanup): Remove.
10530         (target_dcache_aspace_key): Change type.
10531         (target_dcache_init_p, target_dcache_invalidate)
10532         (target_dcache_get, target_dcache_get_or_init)
10533         (_initialize_target_dcache): Update.
10534         * dcache.h (struct dcache_deleter): New.
10535
10536 2019-05-08  Tom Tromey  <tom@tromey.com>
10537
10538         * symtab.c (struct symbol_cache): Add destructor and
10539         initializers.
10540         (symbol_cache_key): Move.  Change type.
10541         (make_symbol_cache, free_symbol_cache): Remove.
10542         (get_symbol_cache): Update.
10543         (symbol_cache_cleanup): Remove.
10544         (ALL_PSPACES, symbol_cache_flush)
10545         (maintenance_print_symbol_cache)
10546         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10547         Update.
10548
10549 2019-05-08  Tom Tromey  <tom@tromey.com>
10550
10551         * symtab.c (struct main_info): Add destructor and initializers.
10552         (main_progspace_key): Move.  Change type.
10553         (get_main_info): Update.
10554         (main_info_cleanup): Remove.
10555         (_initialize_symtab): Update.
10556
10557 2019-05-08  Tom Tromey  <tom@tromey.com>
10558
10559         * registry.h (DECLARE_REGISTRY): Define the _key class.
10560
10561 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10562
10563         * NEWS: Merge two 'New commands' sections.
10564
10565 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10566
10567         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10568         parameter and use Ada language definition instead.
10569         (ada_val_print_ptr): Remove unused language parameter.
10570         (ada_val_print_num): Remove language parameter and use Ada language
10571         definition instead.
10572         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10573         parameter.
10574         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10575         parameter and use Ada language definition instead.
10576         (ada_val_print_1): Update all ada_val_print_xxx calls.
10577         Remove language parameter.
10578         (ada_val_print): Update ada_val_print_1 call.
10579
10580 2019-05-08  Tom Tromey  <tromey@adacore.com>
10581
10582         * remote.c (remote_hw_watchpoint_limit)
10583         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10584         Now static.
10585
10586 2019-05-08  Tom Tromey  <tromey@adacore.com>
10587
10588         * maint.c (_initialize_maint_cmds): Move initialization code to
10589         remote.c.
10590         (watchdog, show_watchdog): Move to remote.c.
10591         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10592         "watchdog" static.
10593         (_initialize_remote): Move initialization code from maint.c.
10594         * defs.h (watchdog): Don't declare.
10595
10596 2019-05-08  Tom Tromey  <tromey@adacore.com>
10597
10598         * tui/tui-interp.c: Include main.h.
10599         * interps.c: Include main.h.
10600         * main.h (interpreter_p): Declare.
10601         * defs.h (interpreter_p): Don't declare.
10602
10603 2019-05-08  Tom Tromey  <tromey@adacore.com>
10604
10605         * dwarf2loc.c: Include dwarf2read.h.
10606         * defs.h (read_unsigned_leb128): Don't declare.
10607         * dwarf2read.h (read_unsigned_leb128): Declare.
10608
10609 2019-05-08  Tom Tromey  <tromey@adacore.com>
10610
10611         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10612         method.
10613
10614 2019-05-08  Tom Tromey  <tromey@adacore.com>
10615
10616         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10617         when no wrap column is set.
10618
10619 2019-05-08  Tom Tromey  <tromey@adacore.com>
10620
10621         * c-lang.c (c_get_string): Handle non-C-style arrays.
10622
10623 2019-05-08  Tom Tromey  <tromey@adacore.com>
10624
10625         * typeprint.c (print_offset_data::update): Print the bit offset,
10626         not the number of bits remaining.
10627
10628 2019-05-08  Tom Tromey  <tromey@adacore.com>
10629
10630         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10631         padding at end of comment.
10632
10633 2019-05-08  Tom Tromey  <tromey@adacore.com>
10634
10635         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10636         Compare main types.
10637
10638 2019-05-06  Tom Tromey  <tom@tromey.com>
10639
10640         * common/scoped_mmap.c: Include common-defs.h.
10641         * common/scoped_mmap.h: Don't include config.h.
10642
10643 2019-05-04  Tom Tromey  <tom@tromey.com>
10644
10645         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10646         (struct aarch64_call_info): Add initializers.
10647         <si>: Now a std::vector.
10648         (pass_on_stack, aarch64_push_dummy_call): Update.
10649
10650 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10651             Tom Tromey  <tom@tromey.com>
10652
10653         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10654         (ppc_threads): Now a std::vector.  Now static.
10655         (hwdebug_find_thread_points_by_tid)
10656         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10657         Update.
10658
10659 2019-05-04  Tom Tromey  <tom@tromey.com>
10660
10661         * arc-tdep.c (arc_tdesc_init): Return bool.
10662
10663 2019-05-04  Tom Tromey  <tom@tromey.com>
10664
10665         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10666         Use gdb_assert_not_reached.
10667
10668 2019-05-04  Tom Tromey  <tom@tromey.com>
10669
10670         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10671         "false".
10672
10673 2019-05-04  Tom Tromey  <tom@tromey.com>
10674
10675         * arc-tdep.c (arc_tdesc_init): Use bool.
10676
10677 2019-05-04  Tom Tromey  <tom@tromey.com>
10678
10679         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10680
10681 2019-05-04  Tom Tromey  <tom@tromey.com>
10682
10683         * cli/cli-cmds.c (valid_command_p): Return bool.
10684
10685 2019-05-04  Tom Tromey  <tom@tromey.com>
10686
10687         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10688         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10689
10690 2019-05-04  Raul Tambre  <raul@tambre.ee>
10691
10692         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10693         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10694         operator for comparison.
10695
10696 2019-05-04  Tom Tromey  <tom@tromey.com>
10697
10698         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10699         (lookup_partial_symbol, print_partial_symbols)
10700         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10701         (psymbol_compare): Update.
10702         (add_psymbol_to_bcache): Clear the entire psymbol.
10703         (maintenance_check_psymtabs): Update.
10704         * psympriv.h (struct partial_symbol): Don't derive from
10705         general_symbol_info.
10706         <obj_section, unrelocated_address, address,
10707         set_unrelocated_address>: Update.
10708         <ginfo>: New member.
10709         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10710         (debug_names::write_psymbols): Update.
10711
10712 2019-05-04  Tom de Vries  <tdevries@suse.de>
10713
10714         * contrib/cc-with-tweaks.sh: Support -n arg.
10715
10716 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10717
10718         * corelow.c (core_target::detach): Ensure frame cache and
10719         register caches are cleared.
10720         inferior.c (exit_inferior_1): Likewise.
10721
10722 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10723             Tom Tromey  <tom@tromey.com>
10724
10725         * dictionary.c (collate_pending_symbols_by_language): Remove
10726         "struct" from foreach.
10727         * symtab.c (lookup_global_symbol_from_objfile)
10728         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10729         foreach.
10730         * ser-tcp.c (net_open): Remove "struct" from foreach.
10731         * objfiles.c (objfile_relocate, objfile_rebase)
10732         (objfile_has_symbols): Remove "struct" from foreach.
10733         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10734         from foreach.
10735         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10736         foreach.
10737         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10738         "struct" from foreach.
10739         * ada-lang.c (create_excep_cond_exprs)
10740         (ada_exception_catchpoint_cond_string): Remove "struct" from
10741         foreach.
10742
10743 2019-05-03  Tom Tromey  <tromey@adacore.com>
10744
10745         * ada-exp.y (convert_char_literal): Check suffix of each
10746         enumerator.
10747
10748 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10749
10750         PR ada/21406:
10751         * ada-exp.y (yywrap): Don't define.
10752         * ada-lex.l (%option): Add noyywrap
10753         (yywrap): Remove.
10754
10755 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10756
10757         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10758         _WIN32_WINNT to the XP level, unless already defined to a higher
10759         level.
10760
10761         * unittests/parse-connection-spec-selftests.c:
10762         * ser-tcp.c:
10763         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10764         override.
10765
10766         * symfile.c (find_separate_debug_file): Remove colon from the
10767         drive spec of DOS/Windows file names of the target, so that the
10768         file name produced from DEBUGDIR and the target's directory will
10769         be valid on DOS/Windows systems.
10770
10771 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10772
10773         * rust-lang.c (val_print_struct): Handle printing structures
10774         containing strings.
10775
10776 2019-05-02  Tom Tromey  <tromey@adacore.com>
10777
10778         * valarith.c (_initialize_valarith): Remove.
10779
10780 2019-05-01  Tom Tromey  <tromey@adacore.com>
10781
10782         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10783         bitfields.
10784
10785 2019-05-01  Tom Tromey  <tromey@adacore.com>
10786
10787         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10788         for big-endian copies.
10789
10790 2019-04-30  Ali Tamur  <tamur@google.com>
10791         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10792         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10793         (read_3_bytes): New function.
10794
10795 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10796
10797         * windows-nat.c (main_thread_id): Delete.
10798         (handle_output_debug_string): Replace main_thread_id by
10799         current_event.dwThreadId.
10800         (fake_create_process): Likewise.
10801         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10802         Do not set main_thread_id.
10803         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10804         current_event.dwThreadId.
10805         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10806
10807 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10808
10809         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10810         Use current_event.dwThreadId instead of main_thread_id.
10811
10812 2019-04-30  Tom Tromey  <tromey@adacore.com>
10813
10814         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10815         (create_excep_cond_exprs): Iterate over program spaces.
10816         (ada_exception_catchpoint_cond_string): Examine all minimal
10817         symbols for exception types.
10818
10819 2019-04-30  Tom Tromey  <tromey@adacore.com>
10820
10821         PR c++/24470:
10822         * dwarf2read.c (process_structure_scope): Handle case where type
10823         has template parameters but no symbol was created.
10824
10825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10826             Chris January  <chris.january@arm.com>
10827
10828         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10829         qualifier.
10830         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10831
10832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10833
10834         * f-typeprint.c (f_print_type): Update rules for printing
10835         whitespace.
10836         (f_type_print_varspec_suffix): Likewise.
10837
10838 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10839             Chris January  <chris.january@arm.com>
10840
10841         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10842         function arguments.
10843
10844 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10845
10846         * f-lang.c (build_fortran_types): Change name of void type to
10847         lower case.
10848         * f-typeprint.c (f_type_print_base): Print the name of the void
10849         type, rather than a fixed string.
10850         * f-valprint.c (f_decorations): Use lower case void string.
10851
10852 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10853             Chris January  <chris.january@arm.com>
10854
10855         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10856         types for Fortran.
10857
10858 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10859             Chris January  <chris.january@arm.com>
10860             David Lecomber  <david.lecomber@arm.com>
10861
10862         * f-exp.y (BINOP_INTRINSIC): New token.
10863         (exp): New parser rule handling BINOP_INTRINSIC.
10864         (f77_keywords): Add new builtin procedures.
10865         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10866         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10867         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10868         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10869         (print_unop_subexp_f): New function.
10870         (print_binop_subexp_f): New function.
10871         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10872         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10873         (dump_subexp_body_f): Likewise.
10874         (operator_check_f): Likewise.
10875         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10876         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10877
10878 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10879
10880         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10881         UNOP_KIND.
10882         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10883         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10884         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10885         (operator_length_f): New fuction.
10886         (print_subexp_f): New function.
10887         (op_name_f): New function.
10888         (dump_subexp_body_f): New function.
10889         (operator_check_f): New function.
10890         (exp_descriptor_f): Replace standard expression handling functions
10891         with new functions.
10892         * gdb/fortran-operator.def: New file.
10893         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10894         * gdb/std-operator.def: Remove UNOP_KIND.
10895
10896 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10897
10898         * std-operator.def: Remove unbalanced, stray double quote
10899         character.
10900
10901 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10902             Chris January  <chris.january@arm.com>
10903             Daniel Everett  <daniel.everett@arm.com>
10904             Nick Forrington  <nick.forrington@arm.com>
10905             Richard Bunt  <richard.bunt@arm.com>
10906
10907         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10908         of depth when printing anonymous structs or unions.
10909         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10910         Don't print either the top-level value, or the children if the
10911         max-depth is exceeded.
10912         (ppscm_print_children): When printing the key of a map, allow one
10913         extra level of depth.
10914         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10915         print either the top-level value, or the children if the max-depth
10916         is exceeded.
10917         (print_children): When printing the key of a map, allow one extra
10918         level of depth.
10919         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10920         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10921         (user_print_options): Initialise max_depth field.
10922         (val_print_scalar_or_string_type_p): New function.
10923         (val_print): Check to see if the max depth has been reached.
10924         (val_print_check_max_depth): Define new function.
10925         (show_print_max_depth): New function.
10926         (_initialize_valprint): Add 'print max-depth' option.
10927         * valprint.h (struct value_print_options) <max_depth>: New field.
10928         (val_print_check_max_depth): Declare new function.
10929         * NEWS: Document new feature.
10930
10931 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10932
10933         * ada-lang.c (ada_language_defn): Initialise new field.
10934         * c-lang.c (c_is_string_type_p): New function.
10935         (c_language_defn): Initialise new field.
10936         (cplus_language_defn): Initialise new field.
10937         (asm_language_defn): Initialise new field.
10938         (minimal_language_defn): Initialise new field.
10939         * c-lang.h (c_is_string_type_p): Declare new function.
10940         * d-lang.c (d_language_defn): Initialise new field.
10941         * f-lang.c (f_is_string_type_p): New function.
10942         (f_language_defn): Initialise new field.
10943         * go-lang.c (go_is_string_type_p): New function.
10944         (go_language_defn): Initialise new field.
10945         * language.c (default_is_string_type_p): New function.
10946         (unknown_language_defn): Initialise new field.
10947         (auto_language_defn): Initialise new field.
10948         * language.h (struct language_defn) <la_is_string_type_p>: New
10949         member variable.
10950         (default_is_string_type_p): Declare new function.
10951         * m2-lang.c (m2_language_defn): Initialise new field.
10952         * objc-lang.c (objc_language_defn): Initialise new field.
10953         * opencl-lang.c (opencl_language_defn): Initialise new field.
10954         * p-lang.c (pascal_is_string_type_p): New function.
10955         (pascal_language_defn): Initialise new field.
10956         * rust-lang.c (rust_is_string_type_p): New function.
10957         (rust_language_defn): Initialise new field.
10958
10959 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10960
10961         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10962         New field.
10963         * ada-lang.c (ada_language_defn): Initialise new field.
10964         * c-lang.c (c_language_defn): Likewise.
10965         (cplus_language_defn): Likewise.
10966         (asm_language_defn): Likewise.
10967         (minimal_language_defn): Likewise.
10968         * d-lang.c (d_language_defn): Likewise.
10969         * f-lang.c (f_language_defn): Likewise.
10970         * go-lang.c (go_language_defn): Likewise.
10971         * language.c (unknown_language_defn): Likewise.
10972         (auto_language_defn): Likewise.
10973         * m2-lang.c (m2_language_defn): Likewise.
10974         * objc-lang.c (objc_language_defn): Likewise.
10975         * opencl-lang.c (opencl_language_defn): Likewise.
10976         * p-lang.c (pascal_language_defn): Likewise.
10977         * rust-lang.c (rust_language_defn): Likewise.
10978
10979 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10980
10981         * ada-lang.c (ada_is_character_type): Change return type to bool.
10982         (ada_is_string_type): Likewise.
10983         * ada-lang.h (ada_is_character_type): Update declaration
10984         (ada_is_string_type): Likewise.
10985
10986 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10987
10988         Support style in 'frame|thread apply'
10989
10990         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10991         * record.c (record_start, record_stop): Update callers of
10992         execute_command_to_string with false.
10993         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10994         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10995         methods.
10996         (class string_file): New constructor with term_out parameter.
10997         Override methods term_out and can_emit_style_escape.  New member
10998         term_out.
10999         (class stdio_file): Override can_emit_style_escape.
11000         (class tee_file): Override term_out and can_emit_style_escape.
11001         * utils.h (can_emit_style_escape): Remove.
11002         * utils.c (can_emit_style_escape): Likewise.
11003         Update all callers of can_emit_style_escape (SOMESTREAM) to
11004         SOMESTREAM->can_emit_style_escape.
11005         * source-cache.c (source_cache::get_source_lines): Likewise.
11006         * stack.c (frame_apply_command_count): Call execute_command_to_string
11007         passing the term_out characteristic of the current gdb_stdout.
11008         * thread.c (thr_try_catch_cmd): Likewise.
11009         * top.c (execute_command_to_string): pass term_out parameter
11010         to construct the string_file for the command output.
11011         * ui-file.c (term_cli_styling): New function (most code moved
11012         from utils.c can_emit_style_escape).
11013         (string_file::string_file, string_file::can_emit_style_escape,
11014         stdio_file::can_emit_style_escape, tee_file::term_out,
11015         tee_file::can_emit_style_escape): New functions.
11016
11017 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11018
11019         * NEWS: Mention the new set|show may-call-functions.
11020         * infcall.c (may_call_functions_p): New variable.
11021         (show_may_call_functions_p): New function.
11022         (call_function_by_hand_dummy): Throws an error if not
11023         may-call-functions.
11024         (_initialize_infcall): Call add_setshow_boolean_cmd for
11025         may-call-functions.
11026
11027 2019-04-25  Keith Seitz  <keiths@redhat.com>
11028
11029         PR c++/24367
11030         * cp-support.c (inspect_type): Don't attempt substitutions
11031         of symbol with the same name.
11032
11033 2019-04-25  Tom Tromey  <tromey@adacore.com>
11034
11035         PR gdb/24475:
11036         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11037         static.
11038
11039 2019-04-25  Tom Tromey  <tromey@adacore.com>
11040
11041         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11042         rvalue reference.
11043         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11044         (gdb_xml_parser::parse): Use std::move.
11045         * python/python-internal.h (gdbpy_convert_exception): Take a const
11046         reference.
11047         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11048         std::move.
11049         * python/py-utils.c (gdbpy_convert_exception): Take a const
11050         reference.
11051         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11052         Use std::move.
11053         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11054         Use std::move.
11055         * mi/mi-main.c (mi_print_exception): Take a const reference.
11056         * main.c (handle_command_errors): Take a const reference.
11057         * linespec.c (parse_linespec): Use std::move.
11058         * infcall.c (run_inferior_call): Use std::move.
11059         (call_function_by_hand_dummy): Use std::move.
11060         * exec.c (try_open_exec_file): Use std::move.
11061         * exceptions.h (exception_print, exception_fprintf)
11062         (exception_print_same): Update.
11063         * exceptions.c (print_exception, exception_print)
11064         (exception_fprintf, exception_print_same): Change parameters to
11065         const reference.
11066         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11067         * common/new-op.c: Use std::move.
11068         * common/common-exceptions.h (struct gdb_exception): Add move
11069         constructor.
11070         (struct gdb_exception_error, struct gdb_exception_quit, struct
11071         gdb_quit_bad_alloc): Change constructor to move constructor.
11072         (throw_exception): Change parameter to rvalue reference.
11073         * common/common-exceptions.c (throw_exception): Take rvalue
11074         reference.
11075         * cli/cli-interp.c (safe_execute_command): Use std::move.
11076         * breakpoint.c (insert_bp_location, location_to_sals): Use
11077         std::move.
11078
11079 2019-04-25  Tom Tromey  <tromey@adacore.com>
11080
11081         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11082         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11083         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11084         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11085         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11086         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11087         guile/scm-value.c: Use unpack.
11088         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11089         gdbscm_gdb_exception.
11090         (gdbscm_throw_gdb_exception): Likewise.
11091         (struct gdbscm_gdb_exception): New.
11092         (unpack): New function.
11093         (gdbscm_wrap): Use unpack.
11094
11095 2019-04-25  Tom Tromey  <tromey@adacore.com>
11096
11097         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11098         (gdb_rl_callback_handler): Use std::move.
11099         * common/common-exceptions.h (struct gdb_exception): Add move
11100         assignment operator.
11101         (throw_exception_sjlj): Change "exception" to const reference.
11102         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11103         (throw_exception_sjlj): Change "exception" to const reference.
11104
11105 2019-04-25  Tom Tromey  <tromey@adacore.com>
11106
11107         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11108         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11109         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11110         Update.
11111         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11112         Update.
11113         * mi/mi-interp.c (mi_interp::exec): Update.
11114         * linespec.c (parse_linespec): Update.
11115         * infcall.c (run_inferior_call): Update.
11116         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11117         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11118         (gdbscm_lookup_global_symbol): Update.
11119         * guile/scm-param.c (gdbscm_parameter_value): Update.
11120         * guile/scm-frame.c (gdbscm_frame_read_register)
11121         (gdbscm_frame_read_var): Update.
11122         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11123         * exec.c (try_open_exec_file): Update.
11124         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11125         (gdb_rl_callback_handler): Update.
11126         * common/common-exceptions.h (exception_none): Don't declare.
11127         * common/common-exceptions.c (exception_none): Don't define.
11128         (struct catcher) <exception>: Update.
11129         * cli/cli-interp.c (safe_execute_command): Update.
11130         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11131
11132 2019-04-25  Ali Tamur  <tamur@google.com>
11133
11134         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11135         (read_attribute_value): Likewise.
11136         (dwarf2_read_addr_index): Update comment.
11137         (read_str_index): Add DW_FORM_strx.
11138         (dwarf2_string_attr): Likewise.
11139         (dwarf2_const_value_attr): Likewise.
11140         (dump_die_shallow): Likewise.
11141         (dwarf2_fetch_constant_bytes): Likewise.
11142         (skip_form_bytes): Likewise.
11143         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11144
11145 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11146
11147         PR corefiles/11608
11148         PR corefiles/18187
11149         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11150         OFFSET.  Verify if current mapping contains an ELF header.
11151         (linux_find_memory_regions_full): Adjust call to
11152         dump_mapping_p.
11153
11154 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11155             Kang Li <kanglictf@gmail.com>
11156
11157         PR gdb/21600
11158
11159         * dwarf2-frame.c (read_initial_length): Be consistent about using
11160         unsigned representation of length.
11161         (decode_frame_entry_1): Likewise.  Check for wraparound of
11162         end pointer as well as buffer overflow.
11163
11164 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11165
11166         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11167         "vq".
11168
11169 2019-04-24  Tom Tromey  <tromey@adacore.com>
11170
11171         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11172
11173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11174
11175         * s12z-tdep.c (s12z_unwind_pc): Delete.
11176         (s12z_unwind_sp): Delete.
11177         (s12z_gdbarch_init): Don't register deleted functions with
11178         gdbarch.
11179
11180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11181
11182         * rl78-tdep.c (rl78_unwind_sp): Delete.
11183         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11184
11185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11188         (xstormy16_unwind_pc): Delete.
11189         (xstormy16_dummy_id): Delete.
11190         (xstormy16_gdbarch_init): Don't register deleted functions with
11191         gdbarch.
11192
11193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11194
11195         * vax-tdep.c (vax_unwind_pc): Delete.
11196         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11197
11198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11199
11200         * v850-tdep.c (v850_unwind_sp): Delete.
11201         (v850_unwind_pc): Delete.
11202         (v850_dummy_id): Delete.
11203         (v850_gdbarch_init): Don't register deleted functions with
11204         gdbarch.
11205
11206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11207
11208         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11209         (tilegx_unwind_pc): Delete.
11210         (tilegx_unwind_dummy_id): Delete.
11211         (tilegx_gdbarch_init): Don't register deleted functions with
11212         gdbarch.
11213
11214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11217         (tic6x_dummy_id): Delete.
11218         (tic6x_gdbarch_init): Don't register deleted functions with
11219         gdbarch.
11220
11221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11222
11223         * sparc-tdep.c (sparc_unwind_pc): Delete.
11224         (sparc32_gdbarch_init): Don't register deleted function with
11225         gdbarch.
11226
11227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11228
11229         * sh-tdep.c (sh_unwind_sp): Delete.
11230         (sh_unwind_pc): Delete.
11231         (sh_dummy_id): Delete.
11232         (sh_gdbarch_init): Don't register deleted functions with
11233         gdbarch.
11234
11235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11236
11237         * score-tdep.c (score_unwind_sp): Delete.
11238         (score_unwind_pc): Delete.
11239         (score_dummy_id): Delete.
11240         (score_gdbarch_init): Don't register deleted functions with
11241         gdbarch.
11242
11243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11244
11245         * rx-tdep.c (rx_unwind_pc): Delete.
11246         (rx_unwind_sp): Delete.
11247         (rx_dummy_id): Delete.
11248         (rx_gdbarch_init): Don't register deleted functions with
11249         gdbarch.  Update comment.
11250
11251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11252
11253         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11254         (rs6000_dummy_id): Delete.
11255         (rs6000_gdbarch_init): Don't register deleted functions with
11256         gdbarch.
11257
11258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11259
11260         * or1k-tdep.c (or1k_dummy_id): Delete.
11261         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11262
11263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11264
11265         * nios2-tdep.c (nios2_dummy_id): Delete.
11266         (nios2_unwind_sp): Delete.
11267         (nios2_gdbarch_init): Don't register deleted functions with
11268         gdbarch.
11269
11270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11271
11272         * nds32-tdep.c (nds32_dummy_id): Delete.
11273         (nds32_unwind_pc): Delete.
11274         (nds32_unwind_sp): Delete.
11275         (nds32_gdbarch_init): Don't register deleted functions with
11276         gdbarch.
11277
11278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11279
11280         * msp430-tdep.c (msp430_unwind_pc): Delete.
11281         (msp430_unwind_sp): Delete.
11282         (msp430_dummy_id): Delete.
11283         (msp430_gdbarch_init): Don't register deleted functions with
11284         gdbarch.
11285
11286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11287
11288         * moxie-tdep.c (moxie_unwind_sp): Delete.
11289         (moxie_unwind_pc): Delete.
11290         (moxie_dummy_id): Delete.
11291         (moxie_gdbarch_init): Don't register deleted functions with
11292         gdbarch.
11293
11294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11295
11296         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11297         (mn10300_unwind_pc): Delete.
11298         (mn10300_unwind_sp): Delete.
11299         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11300         mn10300_unwind_sp.
11301         (mn10300_frame_unwind_init): Don't register deleted functions with
11302         gdbarch.
11303
11304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11305
11306         * mep-tdep.c (mep_unwind_pc): Delete.
11307         (mep_unwind_sp): Delete.
11308         (mep_dummy_id): Delete.
11309         (mep_gdbarch_init): Don't register deleted functions with
11310         gdbarch.
11311
11312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11313
11314         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11315         (m68hc11_unwind_sp): Delete.
11316         (m68hc11_gdbarch_init): Don't register deleted functions with
11317         gdbarch.
11318
11319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11320
11321         * m32r-tdep.c (m32r_unwind_sp): Delete.
11322         (m32r_unwind_pc): Delete.
11323         (m32r_dummy_id): Delete.
11324         (m32r_gdbarch_init): Don't register deleted functions with
11325         gdbarch.
11326
11327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11328
11329         * m32c-tdep.c (m32c_unwind_pc): Delete.
11330         (m32c_unwind_sp): Delete.
11331         (m32c_dummy_id): Delete.
11332         (m32c_gdbarch_init): Don't register deleted functions with
11333         gdbarch.
11334
11335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11336
11337         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11338         (lm32_unwind_pc): Delete.
11339         (lm32_dummy_id): Delete.
11340         (lm32_gdbarch_init): Don't register deleted functions with
11341         gdbarch.
11342
11343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11344
11345         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11346         (iq2000_unwind_pc): Delete.
11347         (iq2000_dummy_id): Delete.
11348         (iq2000_gdbarch_init): Don't register deleted functions with
11349         gdbarch.
11350
11351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11352
11353         * nds32-tdep.c (nds32_type_align): Delete.
11354         (nds32_push_dummy_call): Use type_align instead.
11355
11356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11357
11358         * arm-tdep.c (arm_type_align): Only handle vector override case.
11359         (arm_push_dummy_call): Use type_align.
11360         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11361
11362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11363
11364         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11365         case.
11366         (pass_on_stack): Use type_align.
11367         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11368         function.
11369
11370 2019-04-23  Tom Tromey  <tromey@adacore.com>
11371
11372         * dwarf2read.c (line_header::file_name_at): Remove unused
11373         overload.
11374
11375 2019-04-23  Tom de Vries  <tdevries@suse.de>
11376
11377         PR gdb/24438
11378         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11379         invocation.
11380
11381
11382 2019-03-27  Ali Tamur  <tamur@google.com>
11383
11384         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11385         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11386         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11387         (dwarf_expr_context::get_addr_index): Likewise
11388         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11389         (symbol_needs_eval_context::get_addr_index): Likewise
11390         (disassemble_dwarf_expression): Add DW_OP_addrx
11391         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11392         (read_cutu_die_from_dwo): Update comment
11393         (skip_one_die): Add DW_FORM_addrx
11394         (read_attribute_value): Likewise
11395         (var_decode_location): Add DW_OP_addrx
11396         (dwarf2_const_value_attr): Add DW_FORM_addrx
11397         (dump_die_shallow): Likewise
11398         (dwarf2_fetch_constant_bytes): Likewise
11399         (decode_locdesc): Add DW_OP_addrx
11400         (skip_form_bytes): Add DW_FORM_addrx
11401
11402 2019-04-22  Ali Tamur  <tamur@google.com>
11403
11404         * MAINTAINERS (Write After Approval): Add self.
11405
11406 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11407
11408         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11409         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11410         (open_symbol_file_object): Likewise.
11411         (svr4_default_sos): Add info parameter.
11412         (svr4_read_so_list): Likewise.
11413         (svr4_current_sos_direct): Adjust functions calls to pass down
11414         info.
11415         (svr4_current_sos_1): Add info parameter.
11416         (svr4_current_sos): Call get_svr4_info, pass info down to
11417         svr4_current_sos_1.
11418         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11419         get_svr4_info.
11420         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11421         get_svr4_info.
11422         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11423         to get_svr4_info.
11424         (probes_table_remove_objfile_probes): Likewise.
11425         (register_solib_event_probe): Add info parameter.
11426         (solist_update_incremental): Pass info parameter down to
11427         svr4_read_so_list.
11428         (disable_probes_interface): Add info parameter.
11429         (svr4_handle_solib_event): Pass current_program_space to
11430         get_svr4_info.  Adjust disable_probes_interface cleanup.
11431         (svr4_create_probe_breakpoints): Add info parameter, pass it
11432         down to register_solib_event_probe.
11433         (svr4_create_solib_event_breakpoints): Add info parameter,
11434         pass it down to svr4_create_probe_breakpoints.
11435         (enable_break): Pass info down to
11436         svr4_create_solib_event_breakpoints.
11437         (svr4_solib_create_inferior_hook): Pass current_program_space to
11438         get_svr4_info.
11439         (svr4_clear_solib): Likewise.
11440
11441 2019-04-22  Pedro Alves  <palves@redhat.com>
11442
11443         * solib-svr4.c (svr4_free_objfile_observer): New.
11444         (probe_and_action::objfile): New field.
11445         (probes_table_htab_remove_objfile_probes)
11446         (probes_table_remove_objfile_probes): New functions.
11447         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11448         in the new probe_and_action.  Don't store the probe in 'lookup'.
11449         (svr4_create_probe_breakpoints): Pass objfile to
11450         register_solib_event_probe.
11451         (_initialize_svr4_solib): Register a free_objfile observer.
11452
11453 2019-04-19  Tom Tromey  <tom@tromey.com>
11454
11455         * common/queue.h: Remove.
11456
11457 2019-04-19  Tom Tromey  <tom@tromey.com>
11458
11459         * event-loop.c: Don't include "common/queue.h".
11460
11461 2019-04-19  Tom Tromey  <tom@tromey.com>
11462
11463         * remote.c (remote_target): Use delete.
11464         * remote-notif.h: Include <list>, not "common/queue.h".
11465         (notif_client_p): Remove typedef.
11466         (remote_notif_state): Add constructor, destructor, initializer.
11467         <notif_queue>: Now a std::list.
11468         (remote_notif_state_xfree): Don't declare.
11469         * remote-notif.c (remote_notif_process, handle_notification)
11470         (remote_notif_state_allocate): Update.
11471         (~remote_notif_state): Rename from remote_notif_state_xfree.
11472
11473 2019-04-19  Tom Tromey  <tom@tromey.com>
11474
11475         * symfile.c (reread_symbols): Update.
11476         * objfiles.c (objfile_register_static_link)
11477         (objfile_lookup_static_link): Update
11478         (~objfile) Don't delete static_links.
11479         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11480
11481 2019-04-19  Tom Tromey  <tom@tromey.com>
11482
11483         * type-stack.h (struct type_stack) <insert>: Constify string.
11484         * type-stack.c (type_stack::insert): Constify string.
11485         * gdbtypes.h (lookup_template_type): Update.
11486         (address_space_name_to_int): Update.
11487         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11488         const.
11489         (lookup_template_type): Make name const.
11490         * c-exp.y: Update rules.
11491         (lex_one_token, classify_name, classify_inner_name)
11492         (c_print_token): Update.
11493         * p-exp.y: Update rules.
11494         (yylex): Update.
11495         * f-exp.y: Update rules.
11496         (yylex): Update.
11497         * d-exp.y: Update rules.
11498         (lex_one_token, classify_name, classify_inner_name): Update.
11499         * parse.c (write_dollar_variable, copy_name): Return std::string.
11500         * parser-defs.h (copy_name): Change return type.
11501         * m2-exp.y: Update rules.
11502         (yylex): Update.
11503         * go-exp.y (lex_one_token): Update.
11504         Update rules.
11505         (classify_unsafe_function, classify_packaged_name)
11506         (classify_name, yylex): Update.
11507
11508 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11509
11510         * configure.ac: add --enable-source-highlight switch.
11511         * configure: Regenerate.
11512         * top.c (print_gdb_version): plumb --enable-source-highlight
11513         status to "show configuration".
11514
11515 2019-04-19  Tom Tromey  <tromey@adacore.com>
11516
11517         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11518         Check ADA_TYPE_P.
11519         (empty_record, ada_template_to_fixed_record_type_1)
11520         (template_to_static_fixed_type)
11521         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11522         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11523         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11524         macros.
11525
11526 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11527
11528         PR symtab/24423:
11529         * source.c (print_source_lines_base): Advance "iter" when a
11530         control character is seen.
11531
11532 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11533
11534         * inferior.h (struct infcall_suspend_state_deleter):
11535         Catch exception in destructor to avoid crash.
11536
11537 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11538
11539         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11540         close to the add_com "shell".
11541
11542 2019-04-18  Tom Tromey  <tromey@adacore.com>
11543
11544         * process-stratum-target.h (class process_stratum_target)
11545         <stratum>: Add "final".
11546
11547 2019-04-17  Tom Tromey  <tromey@adacore.com>
11548
11549         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11550         against nullptr before use.
11551
11552 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11553
11554         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11555
11556 2019-04-17  Jim Wilson  <jimw@sifive.com>
11557             Andrew Burgess  <andrew.burgess@embecosm.com>
11558
11559         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11560         code read might fail, assume 4-byte breakpoint in that case.
11561
11562 2019-04-15  Leszek Swirski  <leszeks@google.com>
11563
11564         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11565         rather than a hand-rolled POD check when checking for forced MEMORY
11566         classification.
11567
11568 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11569
11570         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11571         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11572         function.
11573         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11574         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11575         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11576         declaration.
11577
11578 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11579
11580         * aarch64-linux-nat.c
11581         (aarch64_linux_nat_target::thread_architecture): Add override.
11582         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11583         each VQ.
11584
11585 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11586
11587         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11588
11589 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11590
11591         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11592         target types of size 96-bits, add some additional comments, and
11593         check that the builtin type we found was the correct size.
11594
11595 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11596
11597         * utils.c (prompt_for_continue): Don't restore the styling at the
11598         end, as applied_style has the wrong value.  This fixes styling in
11599         long lists of file names that are interrupted by the "Continue?"
11600         prompt.
11601
11602 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11603
11604         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11605         * c-lang.c (c_language_defn): Likewise.
11606         (cplus_language_defn): Likewise.
11607         (asm_language_defn): Likewise.
11608         (minimal_language_defn): Likewise.
11609         * d-lang.c (d_language_defn): Likewise.
11610         * f-lang.c (f_language_defn): Likewise.
11611         * go-lang.c (go_language_defn): Likewise.
11612         * language.c (unknown_language_defn): Likewise.
11613         (auto_language_defn): Likewise.
11614         * language.h (struct language_defn): Remove la_magic field.
11615         (LANG_MAGIC): Delete.
11616         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11617         * objc-lang.c (objc_language_defn): Likewise.
11618         * opencl-lang.c (opencl_language_defn): Likewise.
11619         * p-lang.c (pascal_language_defn): Likewise.
11620         * rust-lang.c (rust_language_defn): Likewise.
11621
11622 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11623
11624         * riscv-tdep.c (riscv_type_align): New function.
11625         (riscv_type_alignment): Delete.
11626         (riscv_arg_location): Use 'type_align'.
11627         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11628
11629 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11630
11631         * gdbtypes.c (type_align): A struct with no non-static fields also
11632         has alignment of 1.
11633
11634 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11635
11636         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11637         component to 0.
11638         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11639         member.
11640         (riscv_struct_info::analyse): New implementation using new
11641         analyse_inner member function.
11642         (riscv_struct_info::field_offset): New member function.
11643         (riscv_struct_info::m_offsets): New member variable.
11644         (riscv_struct_info::analyse_inner): New private member function,
11645         takes the old implementation of riscv_struct_info::analyse but
11646         extended to track field offsets.
11647         (riscv_call_arg_struct): Update the struct folding special cases
11648         to handle cases where empty C++ structs, which are non-zero
11649         length, are found.
11650         (riscv_arg_location): Initialise the length of each location, a
11651         non-zero length now indicates the location is in use.
11652         (riscv_push_dummy_call): Allow for the first location having a
11653         non-zero offset when setting up arguments.
11654         (riscv_return_value): Likewise, but for return values.
11655
11656 2019-04-11  Tom Tromey  <tromey@adacore.com>
11657
11658         * utils.c (internal_vproblem): Make "msg" const.
11659
11660 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11661
11662         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11663         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11664         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11665         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11666
11667 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11668
11669         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11670         function.
11671         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11672         of amd64_collect_native_gregset.
11673         (amd64_linux_nat_target::store_registers): Likewise.
11674
11675 2019-04-10  Tom Tromey  <tom@tromey.com>
11676
11677         * symtab.c (lookup_global_symbol_from_objfile)
11678         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11679         * objfiles.h (class separate_debug_iterator): New.
11680         (class separate_debug_range): New.
11681         (struct objfile) <separate_debug_objfiles>: New method.
11682         (objfile_separate_debug_iterate): Don't declare.
11683         * objfiles.c (separate_debug_iterator::operator++): Rename from
11684         objfile_separate_debug_iterate.
11685         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11686         iterator.
11687         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11688         iterator.
11689
11690 2019-04-10  Tom Tromey  <tom@tromey.com>
11691
11692         * symfile.c (reread_symbols): Remove old comment.
11693         * objfiles.c (free_all_objfiles): Fix a typo.
11694
11695 2019-04-10  Tom Tromey  <tom@tromey.com>
11696
11697         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11698         * minsyms.c (lookup_minimal_symbol): Use foreach.
11699         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11700         (lookup_minimal_symbol_solib_trampoline): Likewise.
11701         * symfile.c (reread_symbols): Use foreach.
11702
11703 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11704             Tom Tromey  <tromey@adacore.com>
11705
11706         PR rust/24414:
11707         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11708         (rust_lex_int_test): Change "value" to be LONGEST.
11709         (rust_lex_tests): Add test for long integer literal.
11710
11711 2019-04-09  Tom Tromey  <tromey@adacore.com>
11712
11713         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11714         to bool.
11715         (extended_remote_target::attach): Update.
11716         (remote_target::remote_notice_new_inferior): Update.
11717         (remote_target::add_current_inferior_and_thread): Update.
11718         * inferior.c (exit_inferior_1): Use "false".
11719         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11720
11721 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11722
11723         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11724         the "start" command.
11725
11726 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11727
11728         * python/py-inferior.c (infpy_thread_from_thread_handle):
11729         Adjust comments to reflect renaming of thread_from_thread_handle
11730         to thread_from_handle.  Adjust keywords.  Fix type error message.
11731         (inferior_object_methods): Add thread_from_handle.  Retain
11732         thread_from_thread_handle, but mark it as deprecated.
11733
11734 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11735
11736         * gdbthread.h (find_thread_by_handle): Revise declaration.
11737         * thread.c (find_thread_by_handle): Likewise.  Adjust
11738         implementation too.
11739         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11740         support for buffer objects as handles.
11741
11742 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11743
11744         * python/py-infthread.c (thpy_thread_handle): New function.
11745         (thread_object_methods): Register thpy_thread_handle.
11746
11747 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11748
11749         * gdbthread.h (thread_to_thread_handle): Declare.
11750         * thread.c (gdbtypes.h): Include.
11751         (thread_to_thread_handle): New function.
11752
11753         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11754         (target_thread_info_to_thread_handle): Declare.
11755         * target.c (target_thread_info_to_thread_handle): New function.
11756         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11757         * target-delegates.c: Regenerate.
11758
11759         * linux-thread-db.c (class thread_db_target): Add method
11760         thread_info_to_thread_handle.
11761         (thread_db_target::thread_info_to_thread_handle): Define.
11762         * remote.c (class remote_target): Add new method
11763         thread_info_to_thread_handle.
11764         (remote_target::thread_info_to_thread_handle): Define.
11765
11766 2019-04-08  Pedro Alves  <palves@redhat.com>
11767
11768         * common/common-exceptions.c (throw_exception): Don't create
11769         named object to throw; throw directly.
11770         (throw_it): Likewise.  Don't initialize gdb_exception::message
11771         here, with new; pass FMT and AP to the ctor instead.
11772         * common/common-exceptions.h: Include <string>.
11773         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11774         const char *, va_list)): New ctor.  Use std::make_shared.
11775         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11776         errors)): Delete.
11777         (gdb_exception_error::gdb_exception_error(enum errors, const char
11778         *, va_list)): New.
11779         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11780         Add assertion.
11781         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11782         errors)): Delete.
11783         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11784         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11785         Add assertion.
11786
11787 2019-04-08  Tom Tromey  <tom@tromey.com>
11788
11789         * valops.c (value_rtti_indirect_type): Replace throw_exception
11790         with throw.
11791         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11792         with throw.
11793         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11794         throw.
11795         * target.c (target_translate_tls_address): Replace throw_exception
11796         with throw.
11797         * stack.c (frame_apply_command_count): Replace throw_exception
11798         with throw.
11799         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11800         throw.
11801         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11802         with throw.
11803         * rs6000-tdep.c (rs6000_frame_cache)
11804         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11805         * remote.c: Replace throw_exception with throw.
11806         * record-full.c (record_full_message, record_full_wait_1)
11807         (record_full_restore): Replace throw_exception with throw.
11808         * record-btrace.c:
11809         (get_thread_current_frame_id, record_btrace_start_replaying)
11810         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11811         (cmd_record_btrace_start): Replace throw_exception with throw.
11812         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11813         throw.
11814         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11815         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11816         * linespec.c:
11817         (find_linespec_symbols): Replace throw_exception with throw.
11818         * infrun.c (displaced_step_prepare, resume): Replace
11819         throw_exception with throw.
11820         * infcmd.c (post_create_inferior): Replace throw_exception with
11821         throw.
11822         * inf-loop.c (inferior_event_handler): Replace throw_exception
11823         with throw.
11824         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11825         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11826         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11827         (get_prev_frame_always, get_frame_pc_if_available)
11828         (get_frame_address_in_block_if_available, get_frame_language):
11829         Replace throw_exception with throw.
11830         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11831         throw_exception with throw.
11832         * eval.c (fetch_subexp_value, evaluate_var_value)
11833         (evaluate_funcall, evaluate_subexp_standard): Replace
11834         throw_exception with throw.
11835         * dwarf2loc.c (call_site_find_chain)
11836         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11837         Replace throw_exception with throw.
11838         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11839         with throw.
11840         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11841         throw.
11842         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11843         * completer.c (complete_line_internal): Replace throw_exception
11844         with throw.
11845         * compile/compile-object-run.c (compile_object_run): Replace
11846         throw_exception with throw.
11847         * cli/cli-script.c (process_next_line): Replace throw_exception
11848         with throw.
11849         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11850         (btrace_enable, btrace_maint_update_pt_packets): Replace
11851         throw_exception with throw.
11852         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11853         throw_exception with throw.
11854         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11855         throw_exception with throw.
11856         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11857         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11858         * aarch64-tdep.c (aarch64_make_prologue_cache)
11859         (aarch64_make_stub_cache): Replace throw_exception with throw.
11860
11861 2019-04-08  Tom Tromey  <tom@tromey.com>
11862
11863         * common/common-exceptions.c (throw_exception): Rename from
11864         throw_exception_cxx.  Remove old copy.  Make argument const.
11865         (throw_it): Create and throw exception objects directly.
11866         * common/common-exceptions.h (throw_exception): Make argument
11867         const.
11868         (struct gdb_exception_error): Add constructor.
11869         (struct gdb_exception_quit): Add constructor.
11870
11871 2019-04-08  Tom Tromey  <tom@tromey.com>
11872
11873         * common/common-exceptions.h (exception_rethrow): Don't declare.
11874         (TRY_SJLJ): Update comment.
11875         (TRY, CATCH, END_CATCH): Remove.
11876         * common/common-exceptions.c (exception_rethrow): Remove.
11877
11878 2019-04-08  Tom Tromey  <tom@tromey.com>
11879
11880         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11881         Remove.
11882         (gdb_exception_error): Rename from
11883         gdb_exception_RETURN_MASK_ERROR.
11884         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11885         (gdb_quit_bad_alloc): Update.
11886         * aarch64-tdep.c: Update.
11887         * ada-lang.c: Update.
11888         * ada-typeprint.c: Update.
11889         * ada-valprint.c: Update.
11890         * amd64-tdep.c: Update.
11891         * arch-utils.c: Update.
11892         * break-catch-throw.c: Update.
11893         * breakpoint.c: Update.
11894         * btrace.c: Update.
11895         * c-varobj.c: Update.
11896         * cli/cli-cmds.c: Update.
11897         * cli/cli-interp.c: Update.
11898         * cli/cli-script.c: Update.
11899         * common/common-exceptions.c: Update.
11900         * common/new-op.c: Update.
11901         * common/selftest.c: Update.
11902         * compile/compile-c-symbols.c: Update.
11903         * compile/compile-cplus-symbols.c: Update.
11904         * compile/compile-object-load.c: Update.
11905         * compile/compile-object-run.c: Update.
11906         * completer.c: Update.
11907         * corelow.c: Update.
11908         * cp-abi.c: Update.
11909         * cp-support.c: Update.
11910         * cp-valprint.c: Update.
11911         * darwin-nat.c: Update.
11912         * disasm-selftests.c: Update.
11913         * dtrace-probe.c: Update.
11914         * dwarf-index-cache.c: Update.
11915         * dwarf-index-write.c: Update.
11916         * dwarf2-frame-tailcall.c: Update.
11917         * dwarf2-frame.c: Update.
11918         * dwarf2loc.c: Update.
11919         * dwarf2read.c: Update.
11920         * eval.c: Update.
11921         * event-loop.c: Update.
11922         * event-top.c: Update.
11923         * exec.c: Update.
11924         * f-valprint.c: Update.
11925         * fbsd-tdep.c: Update.
11926         * frame-unwind.c: Update.
11927         * frame.c: Update.
11928         * gdbtypes.c: Update.
11929         * gnu-v3-abi.c: Update.
11930         * guile/guile-internal.h: Update.
11931         * guile/scm-block.c: Update.
11932         * guile/scm-breakpoint.c: Update.
11933         * guile/scm-cmd.c: Update.
11934         * guile/scm-disasm.c: Update.
11935         * guile/scm-frame.c: Update.
11936         * guile/scm-lazy-string.c: Update.
11937         * guile/scm-math.c: Update.
11938         * guile/scm-param.c: Update.
11939         * guile/scm-ports.c: Update.
11940         * guile/scm-pretty-print.c: Update.
11941         * guile/scm-symbol.c: Update.
11942         * guile/scm-symtab.c: Update.
11943         * guile/scm-type.c: Update.
11944         * guile/scm-value.c: Update.
11945         * i386-linux-tdep.c: Update.
11946         * i386-tdep.c: Update.
11947         * inf-loop.c: Update.
11948         * infcall.c: Update.
11949         * infcmd.c: Update.
11950         * infrun.c: Update.
11951         * jit.c: Update.
11952         * language.c: Update.
11953         * linespec.c: Update.
11954         * linux-fork.c: Update.
11955         * linux-nat.c: Update.
11956         * linux-tdep.c: Update.
11957         * linux-thread-db.c: Update.
11958         * main.c: Update.
11959         * mi/mi-cmd-break.c: Update.
11960         * mi/mi-cmd-stack.c: Update.
11961         * mi/mi-interp.c: Update.
11962         * mi/mi-main.c: Update.
11963         * objc-lang.c: Update.
11964         * p-valprint.c: Update.
11965         * parse.c: Update.
11966         * ppc-linux-tdep.c: Update.
11967         * printcmd.c: Update.
11968         * python/py-arch.c: Update.
11969         * python/py-breakpoint.c: Update.
11970         * python/py-cmd.c: Update.
11971         * python/py-finishbreakpoint.c: Update.
11972         * python/py-frame.c: Update.
11973         * python/py-framefilter.c: Update.
11974         * python/py-gdb-readline.c: Update.
11975         * python/py-inferior.c: Update.
11976         * python/py-infthread.c: Update.
11977         * python/py-lazy-string.c: Update.
11978         * python/py-linetable.c: Update.
11979         * python/py-objfile.c: Update.
11980         * python/py-param.c: Update.
11981         * python/py-prettyprint.c: Update.
11982         * python/py-progspace.c: Update.
11983         * python/py-record-btrace.c: Update.
11984         * python/py-record.c: Update.
11985         * python/py-symbol.c: Update.
11986         * python/py-type.c: Update.
11987         * python/py-unwind.c: Update.
11988         * python/py-utils.c: Update.
11989         * python/py-value.c: Update.
11990         * python/python.c: Update.
11991         * record-btrace.c: Update.
11992         * record-full.c: Update.
11993         * remote-fileio.c: Update.
11994         * remote.c: Update.
11995         * riscv-tdep.c: Update.
11996         * rs6000-aix-tdep.c: Update.
11997         * rs6000-tdep.c: Update.
11998         * rust-exp.y: Update.
11999         * rust-lang.c: Update.
12000         * s390-tdep.c: Update.
12001         * selftest-arch.c: Update.
12002         * solib-dsbt.c: Update.
12003         * solib-frv.c: Update.
12004         * solib-spu.c: Update.
12005         * solib-svr4.c: Update.
12006         * solib.c: Update.
12007         * sparc64-linux-tdep.c: Update.
12008         * stack.c: Update.
12009         * symfile-mem.c: Update.
12010         * symmisc.c: Update.
12011         * target.c: Update.
12012         * thread.c: Update.
12013         * top.c: Update.
12014         * tracefile-tfile.c: Update.
12015         * tui/tui.c: Update.
12016         * typeprint.c: Update.
12017         * unittests/cli-utils-selftests.c: Update.
12018         * unittests/parse-connection-spec-selftests.c: Update.
12019         * valops.c: Update.
12020         * valprint.c: Update.
12021         * value.c: Update.
12022         * varobj.c: Update.
12023         * windows-nat.c: Update.
12024         * x86-linux-nat.c: Update.
12025         * xml-support.c: Update.
12026
12027 2019-04-08  Tom Tromey  <tom@tromey.com>
12028
12029         * xml-support.c: Use C++ exception handling.
12030         * x86-linux-nat.c: Use C++ exception handling.
12031         * windows-nat.c: Use C++ exception handling.
12032         * varobj.c: Use C++ exception handling.
12033         * value.c: Use C++ exception handling.
12034         * valprint.c: Use C++ exception handling.
12035         * valops.c: Use C++ exception handling.
12036         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12037         handling.
12038         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12039         * typeprint.c: Use C++ exception handling.
12040         * tui/tui.c: Use C++ exception handling.
12041         * tracefile-tfile.c: Use C++ exception handling.
12042         * top.c: Use C++ exception handling.
12043         * thread.c: Use C++ exception handling.
12044         * target.c: Use C++ exception handling.
12045         * symmisc.c: Use C++ exception handling.
12046         * symfile-mem.c: Use C++ exception handling.
12047         * stack.c: Use C++ exception handling.
12048         * sparc64-linux-tdep.c: Use C++ exception handling.
12049         * solib.c: Use C++ exception handling.
12050         * solib-svr4.c: Use C++ exception handling.
12051         * solib-spu.c: Use C++ exception handling.
12052         * solib-frv.c: Use C++ exception handling.
12053         * solib-dsbt.c: Use C++ exception handling.
12054         * selftest-arch.c: Use C++ exception handling.
12055         * s390-tdep.c: Use C++ exception handling.
12056         * rust-lang.c: Use C++ exception handling.
12057         * rust-exp.y: Use C++ exception handling.
12058         * rs6000-tdep.c: Use C++ exception handling.
12059         * rs6000-aix-tdep.c: Use C++ exception handling.
12060         * riscv-tdep.c: Use C++ exception handling.
12061         * remote.c: Use C++ exception handling.
12062         * remote-fileio.c: Use C++ exception handling.
12063         * record-full.c: Use C++ exception handling.
12064         * record-btrace.c: Use C++ exception handling.
12065         * python/python.c: Use C++ exception handling.
12066         * python/py-value.c: Use C++ exception handling.
12067         * python/py-utils.c: Use C++ exception handling.
12068         * python/py-unwind.c: Use C++ exception handling.
12069         * python/py-type.c: Use C++ exception handling.
12070         * python/py-symbol.c: Use C++ exception handling.
12071         * python/py-record.c: Use C++ exception handling.
12072         * python/py-record-btrace.c: Use C++ exception handling.
12073         * python/py-progspace.c: Use C++ exception handling.
12074         * python/py-prettyprint.c: Use C++ exception handling.
12075         * python/py-param.c: Use C++ exception handling.
12076         * python/py-objfile.c: Use C++ exception handling.
12077         * python/py-linetable.c: Use C++ exception handling.
12078         * python/py-lazy-string.c: Use C++ exception handling.
12079         * python/py-infthread.c: Use C++ exception handling.
12080         * python/py-inferior.c: Use C++ exception handling.
12081         * python/py-gdb-readline.c: Use C++ exception handling.
12082         * python/py-framefilter.c: Use C++ exception handling.
12083         * python/py-frame.c: Use C++ exception handling.
12084         * python/py-finishbreakpoint.c: Use C++ exception handling.
12085         * python/py-cmd.c: Use C++ exception handling.
12086         * python/py-breakpoint.c: Use C++ exception handling.
12087         * python/py-arch.c: Use C++ exception handling.
12088         * printcmd.c: Use C++ exception handling.
12089         * ppc-linux-tdep.c: Use C++ exception handling.
12090         * parse.c: Use C++ exception handling.
12091         * p-valprint.c: Use C++ exception handling.
12092         * objc-lang.c: Use C++ exception handling.
12093         * mi/mi-main.c: Use C++ exception handling.
12094         * mi/mi-interp.c: Use C++ exception handling.
12095         * mi/mi-cmd-stack.c: Use C++ exception handling.
12096         * mi/mi-cmd-break.c: Use C++ exception handling.
12097         * main.c: Use C++ exception handling.
12098         * linux-thread-db.c: Use C++ exception handling.
12099         * linux-tdep.c: Use C++ exception handling.
12100         * linux-nat.c: Use C++ exception handling.
12101         * linux-fork.c: Use C++ exception handling.
12102         * linespec.c: Use C++ exception handling.
12103         * language.c: Use C++ exception handling.
12104         * jit.c: Use C++ exception handling.
12105         * infrun.c: Use C++ exception handling.
12106         * infcmd.c: Use C++ exception handling.
12107         * infcall.c: Use C++ exception handling.
12108         * inf-loop.c: Use C++ exception handling.
12109         * i386-tdep.c: Use C++ exception handling.
12110         * i386-linux-tdep.c: Use C++ exception handling.
12111         * guile/scm-value.c: Use C++ exception handling.
12112         * guile/scm-type.c: Use C++ exception handling.
12113         * guile/scm-symtab.c: Use C++ exception handling.
12114         * guile/scm-symbol.c: Use C++ exception handling.
12115         * guile/scm-pretty-print.c: Use C++ exception handling.
12116         * guile/scm-ports.c: Use C++ exception handling.
12117         * guile/scm-param.c: Use C++ exception handling.
12118         * guile/scm-math.c: Use C++ exception handling.
12119         * guile/scm-lazy-string.c: Use C++ exception handling.
12120         * guile/scm-frame.c: Use C++ exception handling.
12121         * guile/scm-disasm.c: Use C++ exception handling.
12122         * guile/scm-cmd.c: Use C++ exception handling.
12123         * guile/scm-breakpoint.c: Use C++ exception handling.
12124         * guile/scm-block.c: Use C++ exception handling.
12125         * guile/guile-internal.h: Use C++ exception handling.
12126         * gnu-v3-abi.c: Use C++ exception handling.
12127         * gdbtypes.c: Use C++ exception handling.
12128         * frame.c: Use C++ exception handling.
12129         * frame-unwind.c: Use C++ exception handling.
12130         * fbsd-tdep.c: Use C++ exception handling.
12131         * f-valprint.c: Use C++ exception handling.
12132         * exec.c: Use C++ exception handling.
12133         * event-top.c: Use C++ exception handling.
12134         * event-loop.c: Use C++ exception handling.
12135         * eval.c: Use C++ exception handling.
12136         * dwarf2read.c: Use C++ exception handling.
12137         * dwarf2loc.c: Use C++ exception handling.
12138         * dwarf2-frame.c: Use C++ exception handling.
12139         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12140         * dwarf-index-write.c: Use C++ exception handling.
12141         * dwarf-index-cache.c: Use C++ exception handling.
12142         * dtrace-probe.c: Use C++ exception handling.
12143         * disasm-selftests.c: Use C++ exception handling.
12144         * darwin-nat.c: Use C++ exception handling.
12145         * cp-valprint.c: Use C++ exception handling.
12146         * cp-support.c: Use C++ exception handling.
12147         * cp-abi.c: Use C++ exception handling.
12148         * corelow.c: Use C++ exception handling.
12149         * completer.c: Use C++ exception handling.
12150         * compile/compile-object-run.c: Use C++ exception handling.
12151         * compile/compile-object-load.c: Use C++ exception handling.
12152         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12153         * compile/compile-c-symbols.c: Use C++ exception handling.
12154         * common/selftest.c: Use C++ exception handling.
12155         * common/new-op.c: Use C++ exception handling.
12156         * cli/cli-script.c: Use C++ exception handling.
12157         * cli/cli-interp.c: Use C++ exception handling.
12158         * cli/cli-cmds.c: Use C++ exception handling.
12159         * c-varobj.c: Use C++ exception handling.
12160         * btrace.c: Use C++ exception handling.
12161         * breakpoint.c: Use C++ exception handling.
12162         * break-catch-throw.c: Use C++ exception handling.
12163         * arch-utils.c: Use C++ exception handling.
12164         * amd64-tdep.c: Use C++ exception handling.
12165         * ada-valprint.c: Use C++ exception handling.
12166         * ada-typeprint.c: Use C++ exception handling.
12167         * ada-lang.c: Use C++ exception handling.
12168         * aarch64-tdep.c: Use C++ exception handling.
12169
12170 2019-04-08  Tom Tromey  <tom@tromey.com>
12171
12172         * xml-support.c (gdb_xml_parser::parse): Update.
12173         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12174         * value.c (show_convenience): Update.
12175         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12176         (test_parse_flags_qcs): Update.
12177         * thread.c (thr_try_catch_cmd): Update.
12178         * target.c (target_translate_tls_address): Update.
12179         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12180         (info_frame_command_core, frame_apply_command_count): Update.
12181         * rust-exp.y (rust_lex_exception_test): Update.
12182         * riscv-tdep.c (riscv_print_one_register_info): Update.
12183         * remote.c (remote_target::enable_btrace): Update.
12184         * record-btrace.c (record_btrace_enable_warn): Update.
12185         * python/py-utils.c (gdbpy_convert_exception): Update.
12186         * printcmd.c (do_one_display, print_variable_and_value): Update.
12187         * mi/mi-main.c (mi_print_exception): Update.
12188         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12189         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12190         * linux-nat.c (linux_nat_target::attach): Update.
12191         * linux-fork.c (class scoped_switch_fork_info): Update.
12192         * infrun.c (displaced_step_prepare): Update.
12193         * infcall.c (call_function_by_hand_dummy): Update.
12194         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12195         * gnu-v3-abi.c (print_one_vtable): Update.
12196         * frame.c (get_prev_frame_always): Update.
12197         * f-valprint.c (info_common_command_for_block): Update.
12198         * exec.c (try_open_exec_file): Update.
12199         * exceptions.c (print_exception, exception_print)
12200         (exception_fprintf, exception_print_same): Update.
12201         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12202         * dwarf-index-cache.c (index_cache::store)
12203         (index_cache::lookup_gdb_index): Update.
12204         * darwin-nat.c (maybe_cache_shell): Update.
12205         * cp-valprint.c (cp_print_value_fields): Update.
12206         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12207         (gcc_cplus_symbol_address): Update.
12208         * compile/compile-c-symbols.c (gcc_convert_symbol)
12209         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12210         * common/selftest.c: Update.
12211         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12212         a std::string.
12213         (exception_try_scope_entry, exception_try_scope_exit): Don't
12214         declare.
12215         (struct exception_try_scope): Remove.
12216         (TRY): Don't use exception_try_scope.
12217         (struct gdb_exception): Add constructor, operator=.
12218         <what>: New method.
12219         (struct gdb_exception_RETURN_MASK_ALL)
12220         (struct gdb_exception_RETURN_MASK_ERROR)
12221         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12222         (struct gdb_quit_bad_alloc): Update.
12223         * common/common-exceptions.c (exception_none): Change
12224         initializer.
12225         (struct catcher) <state, exception>: Initialize inline.
12226         <prev>: Remove member.
12227         (current_catcher): Remove.
12228         (catchers): New global.
12229         (exceptions_state_mc_init): Simplify.
12230         (catcher_pop): Remove.
12231         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12232         (try_scope_depth, exception_try_scope_entry)
12233         (exception_try_scope_exit): Remove.
12234         (throw_exception_sjlj): Update.
12235         (exception_messages, exception_messages_size): Remove.
12236         (throw_it): Simplify.
12237         (gdb_exception_sliced_copy): Remove.
12238         (throw_exception_cxx): Update.
12239         * cli/cli-script.c (script_from_file): Update.
12240         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12241         Update.
12242         * ada-valprint.c (ada_val_print): Update.
12243         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12244         (create_excep_cond_exprs): Update.
12245
12246 2019-04-08  Tom Tromey  <tom@tromey.com>
12247
12248         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12249         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12250         (TRY, CATCH, END_CATCH): Remove some definitions.
12251         * common/common-exceptions.c: Don't use GDB_XCPT.
12252         (catcher_list_size): Remove.
12253         (throw_exception, throw_it): Simplify.
12254
12255 2019-04-05  Tom Tromey  <tom@tromey.com>
12256
12257         Revert the header-sorting patch.
12258         * ft32-tdep.c: Revert.
12259         * frv-tdep.c: Revert.
12260         * frv-linux-tdep.c: Revert.
12261         * frame.c: Revert.
12262         * frame-unwind.c: Revert.
12263         * frame-base.c: Revert.
12264         * fork-child.c: Revert.
12265         * findvar.c: Revert.
12266         * findcmd.c: Revert.
12267         * filesystem.c: Revert.
12268         * filename-seen-cache.h: Revert.
12269         * filename-seen-cache.c: Revert.
12270         * fbsd-tdep.c: Revert.
12271         * fbsd-nat.h: Revert.
12272         * fbsd-nat.c: Revert.
12273         * f-valprint.c: Revert.
12274         * f-typeprint.c: Revert.
12275         * f-lang.c: Revert.
12276         * extension.h: Revert.
12277         * extension.c: Revert.
12278         * extension-priv.h: Revert.
12279         * expprint.c: Revert.
12280         * exec.h: Revert.
12281         * exec.c: Revert.
12282         * exceptions.c: Revert.
12283         * event-top.c: Revert.
12284         * event-loop.c: Revert.
12285         * eval.c: Revert.
12286         * elfread.c: Revert.
12287         * dwarf2read.h: Revert.
12288         * dwarf2read.c: Revert.
12289         * dwarf2loc.c: Revert.
12290         * dwarf2expr.h: Revert.
12291         * dwarf2expr.c: Revert.
12292         * dwarf2-frame.c: Revert.
12293         * dwarf2-frame-tailcall.c: Revert.
12294         * dwarf-index-write.h: Revert.
12295         * dwarf-index-write.c: Revert.
12296         * dwarf-index-common.c: Revert.
12297         * dwarf-index-cache.h: Revert.
12298         * dwarf-index-cache.c: Revert.
12299         * dummy-frame.c: Revert.
12300         * dtrace-probe.c: Revert.
12301         * disasm.h: Revert.
12302         * disasm.c: Revert.
12303         * disasm-selftests.c: Revert.
12304         * dictionary.c: Revert.
12305         * dicos-tdep.c: Revert.
12306         * demangle.c: Revert.
12307         * dcache.h: Revert.
12308         * dcache.c: Revert.
12309         * darwin-nat.h: Revert.
12310         * darwin-nat.c: Revert.
12311         * darwin-nat-info.c: Revert.
12312         * d-valprint.c: Revert.
12313         * d-namespace.c: Revert.
12314         * d-lang.c: Revert.
12315         * ctf.c: Revert.
12316         * csky-tdep.c: Revert.
12317         * csky-linux-tdep.c: Revert.
12318         * cris-tdep.c: Revert.
12319         * cris-linux-tdep.c: Revert.
12320         * cp-valprint.c: Revert.
12321         * cp-support.c: Revert.
12322         * cp-namespace.c: Revert.
12323         * cp-abi.c: Revert.
12324         * corelow.c: Revert.
12325         * corefile.c: Revert.
12326         * continuations.c: Revert.
12327         * completer.h: Revert.
12328         * completer.c: Revert.
12329         * complaints.c: Revert.
12330         * coffread.c: Revert.
12331         * coff-pe-read.c: Revert.
12332         * cli-out.h: Revert.
12333         * cli-out.c: Revert.
12334         * charset.c: Revert.
12335         * c-varobj.c: Revert.
12336         * c-valprint.c: Revert.
12337         * c-typeprint.c: Revert.
12338         * c-lang.c: Revert.
12339         * buildsym.c: Revert.
12340         * buildsym-legacy.c: Revert.
12341         * build-id.h: Revert.
12342         * build-id.c: Revert.
12343         * btrace.c: Revert.
12344         * bsd-uthread.c: Revert.
12345         * breakpoint.h: Revert.
12346         * breakpoint.c: Revert.
12347         * break-catch-throw.c: Revert.
12348         * break-catch-syscall.c: Revert.
12349         * break-catch-sig.c: Revert.
12350         * blockframe.c: Revert.
12351         * block.c: Revert.
12352         * bfin-tdep.c: Revert.
12353         * bfin-linux-tdep.c: Revert.
12354         * bfd-target.c: Revert.
12355         * bcache.c: Revert.
12356         * ax-general.c: Revert.
12357         * ax-gdb.h: Revert.
12358         * ax-gdb.c: Revert.
12359         * avr-tdep.c: Revert.
12360         * auxv.c: Revert.
12361         * auto-load.c: Revert.
12362         * arm-wince-tdep.c: Revert.
12363         * arm-tdep.c: Revert.
12364         * arm-symbian-tdep.c: Revert.
12365         * arm-pikeos-tdep.c: Revert.
12366         * arm-obsd-tdep.c: Revert.
12367         * arm-nbsd-tdep.c: Revert.
12368         * arm-nbsd-nat.c: Revert.
12369         * arm-linux-tdep.c: Revert.
12370         * arm-linux-nat.c: Revert.
12371         * arm-fbsd-tdep.c: Revert.
12372         * arm-fbsd-nat.c: Revert.
12373         * arm-bsd-tdep.c: Revert.
12374         * arch-utils.c: Revert.
12375         * arc-tdep.c: Revert.
12376         * arc-newlib-tdep.c: Revert.
12377         * annotate.h: Revert.
12378         * annotate.c: Revert.
12379         * amd64-windows-tdep.c: Revert.
12380         * amd64-windows-nat.c: Revert.
12381         * amd64-tdep.c: Revert.
12382         * amd64-sol2-tdep.c: Revert.
12383         * amd64-obsd-tdep.c: Revert.
12384         * amd64-obsd-nat.c: Revert.
12385         * amd64-nbsd-tdep.c: Revert.
12386         * amd64-nbsd-nat.c: Revert.
12387         * amd64-nat.c: Revert.
12388         * amd64-linux-tdep.c: Revert.
12389         * amd64-linux-nat.c: Revert.
12390         * amd64-fbsd-tdep.c: Revert.
12391         * amd64-fbsd-nat.c: Revert.
12392         * amd64-dicos-tdep.c: Revert.
12393         * amd64-darwin-tdep.c: Revert.
12394         * amd64-bsd-nat.c: Revert.
12395         * alpha-tdep.c: Revert.
12396         * alpha-obsd-tdep.c: Revert.
12397         * alpha-nbsd-tdep.c: Revert.
12398         * alpha-mdebug-tdep.c: Revert.
12399         * alpha-linux-tdep.c: Revert.
12400         * alpha-linux-nat.c: Revert.
12401         * alpha-bsd-tdep.c: Revert.
12402         * alpha-bsd-nat.c: Revert.
12403         * aix-thread.c: Revert.
12404         * agent.c: Revert.
12405         * addrmap.c: Revert.
12406         * ada-varobj.c: Revert.
12407         * ada-valprint.c: Revert.
12408         * ada-typeprint.c: Revert.
12409         * ada-tasks.c: Revert.
12410         * ada-lang.c: Revert.
12411         * aarch64-tdep.c: Revert.
12412         * aarch64-ravenscar-thread.c: Revert.
12413         * aarch64-newlib-tdep.c: Revert.
12414         * aarch64-linux-tdep.c: Revert.
12415         * aarch64-linux-nat.c: Revert.
12416         * aarch64-fbsd-tdep.c: Revert.
12417         * aarch64-fbsd-nat.c: Revert.
12418         * aarch32-linux-nat.c: Revert.
12419
12420 2019-04-05  Tom Tromey  <tom@tromey.com>
12421
12422         * ft32-tdep.c: Sort headers.
12423         * frv-tdep.c: Sort headers.
12424         * frv-linux-tdep.c: Sort headers.
12425         * frame.c: Sort headers.
12426         * frame-unwind.c: Sort headers.
12427         * frame-base.c: Sort headers.
12428         * fork-child.c: Sort headers.
12429         * findvar.c: Sort headers.
12430         * findcmd.c: Sort headers.
12431         * filesystem.c: Sort headers.
12432         * filename-seen-cache.h: Sort headers.
12433         * filename-seen-cache.c: Sort headers.
12434         * fbsd-tdep.c: Sort headers.
12435         * fbsd-nat.h: Sort headers.
12436         * fbsd-nat.c: Sort headers.
12437         * f-valprint.c: Sort headers.
12438         * f-typeprint.c: Sort headers.
12439         * f-lang.c: Sort headers.
12440         * extension.h: Sort headers.
12441         * extension.c: Sort headers.
12442         * extension-priv.h: Sort headers.
12443         * expprint.c: Sort headers.
12444         * exec.h: Sort headers.
12445         * exec.c: Sort headers.
12446         * exceptions.c: Sort headers.
12447         * event-top.c: Sort headers.
12448         * event-loop.c: Sort headers.
12449         * eval.c: Sort headers.
12450         * elfread.c: Sort headers.
12451         * dwarf2read.h: Sort headers.
12452         * dwarf2read.c: Sort headers.
12453         * dwarf2loc.c: Sort headers.
12454         * dwarf2expr.h: Sort headers.
12455         * dwarf2expr.c: Sort headers.
12456         * dwarf2-frame.c: Sort headers.
12457         * dwarf2-frame-tailcall.c: Sort headers.
12458         * dwarf-index-write.h: Sort headers.
12459         * dwarf-index-write.c: Sort headers.
12460         * dwarf-index-common.c: Sort headers.
12461         * dwarf-index-cache.h: Sort headers.
12462         * dwarf-index-cache.c: Sort headers.
12463         * dummy-frame.c: Sort headers.
12464         * dtrace-probe.c: Sort headers.
12465         * disasm.h: Sort headers.
12466         * disasm.c: Sort headers.
12467         * disasm-selftests.c: Sort headers.
12468         * dictionary.c: Sort headers.
12469         * dicos-tdep.c: Sort headers.
12470         * demangle.c: Sort headers.
12471         * dcache.h: Sort headers.
12472         * dcache.c: Sort headers.
12473         * darwin-nat.h: Sort headers.
12474         * darwin-nat.c: Sort headers.
12475         * darwin-nat-info.c: Sort headers.
12476         * d-valprint.c: Sort headers.
12477         * d-namespace.c: Sort headers.
12478         * d-lang.c: Sort headers.
12479         * ctf.c: Sort headers.
12480         * csky-tdep.c: Sort headers.
12481         * csky-linux-tdep.c: Sort headers.
12482         * cris-tdep.c: Sort headers.
12483         * cris-linux-tdep.c: Sort headers.
12484         * cp-valprint.c: Sort headers.
12485         * cp-support.c: Sort headers.
12486         * cp-namespace.c: Sort headers.
12487         * cp-abi.c: Sort headers.
12488         * corelow.c: Sort headers.
12489         * corefile.c: Sort headers.
12490         * continuations.c: Sort headers.
12491         * completer.h: Sort headers.
12492         * completer.c: Sort headers.
12493         * complaints.c: Sort headers.
12494         * coffread.c: Sort headers.
12495         * coff-pe-read.c: Sort headers.
12496         * cli-out.h: Sort headers.
12497         * cli-out.c: Sort headers.
12498         * charset.c: Sort headers.
12499         * c-varobj.c: Sort headers.
12500         * c-valprint.c: Sort headers.
12501         * c-typeprint.c: Sort headers.
12502         * c-lang.c: Sort headers.
12503         * buildsym.c: Sort headers.
12504         * buildsym-legacy.c: Sort headers.
12505         * build-id.h: Sort headers.
12506         * build-id.c: Sort headers.
12507         * btrace.c: Sort headers.
12508         * bsd-uthread.c: Sort headers.
12509         * breakpoint.h: Sort headers.
12510         * breakpoint.c: Sort headers.
12511         * break-catch-throw.c: Sort headers.
12512         * break-catch-syscall.c: Sort headers.
12513         * break-catch-sig.c: Sort headers.
12514         * blockframe.c: Sort headers.
12515         * block.c: Sort headers.
12516         * bfin-tdep.c: Sort headers.
12517         * bfin-linux-tdep.c: Sort headers.
12518         * bfd-target.c: Sort headers.
12519         * bcache.c: Sort headers.
12520         * ax-general.c: Sort headers.
12521         * ax-gdb.h: Sort headers.
12522         * ax-gdb.c: Sort headers.
12523         * avr-tdep.c: Sort headers.
12524         * auxv.c: Sort headers.
12525         * auto-load.c: Sort headers.
12526         * arm-wince-tdep.c: Sort headers.
12527         * arm-tdep.c: Sort headers.
12528         * arm-symbian-tdep.c: Sort headers.
12529         * arm-pikeos-tdep.c: Sort headers.
12530         * arm-obsd-tdep.c: Sort headers.
12531         * arm-nbsd-tdep.c: Sort headers.
12532         * arm-nbsd-nat.c: Sort headers.
12533         * arm-linux-tdep.c: Sort headers.
12534         * arm-linux-nat.c: Sort headers.
12535         * arm-fbsd-tdep.c: Sort headers.
12536         * arm-fbsd-nat.c: Sort headers.
12537         * arm-bsd-tdep.c: Sort headers.
12538         * arch-utils.c: Sort headers.
12539         * arc-tdep.c: Sort headers.
12540         * arc-newlib-tdep.c: Sort headers.
12541         * annotate.h: Sort headers.
12542         * annotate.c: Sort headers.
12543         * amd64-windows-tdep.c: Sort headers.
12544         * amd64-windows-nat.c: Sort headers.
12545         * amd64-tdep.c: Sort headers.
12546         * amd64-sol2-tdep.c: Sort headers.
12547         * amd64-obsd-tdep.c: Sort headers.
12548         * amd64-obsd-nat.c: Sort headers.
12549         * amd64-nbsd-tdep.c: Sort headers.
12550         * amd64-nbsd-nat.c: Sort headers.
12551         * amd64-nat.c: Sort headers.
12552         * amd64-linux-tdep.c: Sort headers.
12553         * amd64-linux-nat.c: Sort headers.
12554         * amd64-fbsd-tdep.c: Sort headers.
12555         * amd64-fbsd-nat.c: Sort headers.
12556         * amd64-dicos-tdep.c: Sort headers.
12557         * amd64-darwin-tdep.c: Sort headers.
12558         * amd64-bsd-nat.c: Sort headers.
12559         * alpha-tdep.c: Sort headers.
12560         * alpha-obsd-tdep.c: Sort headers.
12561         * alpha-nbsd-tdep.c: Sort headers.
12562         * alpha-mdebug-tdep.c: Sort headers.
12563         * alpha-linux-tdep.c: Sort headers.
12564         * alpha-linux-nat.c: Sort headers.
12565         * alpha-bsd-tdep.c: Sort headers.
12566         * alpha-bsd-nat.c: Sort headers.
12567         * aix-thread.c: Sort headers.
12568         * agent.c: Sort headers.
12569         * addrmap.c: Sort headers.
12570         * ada-varobj.c: Sort headers.
12571         * ada-valprint.c: Sort headers.
12572         * ada-typeprint.c: Sort headers.
12573         * ada-tasks.c: Sort headers.
12574         * ada-lang.c: Sort headers.
12575         * aarch64-tdep.c: Sort headers.
12576         * aarch64-ravenscar-thread.c: Sort headers.
12577         * aarch64-newlib-tdep.c: Sort headers.
12578         * aarch64-linux-tdep.c: Sort headers.
12579         * aarch64-linux-nat.c: Sort headers.
12580         * aarch64-fbsd-tdep.c: Sort headers.
12581         * aarch64-fbsd-nat.c: Sort headers.
12582         * aarch32-linux-nat.c: Sort headers.
12583
12584 2019-04-04  Tom Tromey  <tom@tromey.com>
12585
12586         * varobj.c (varobj_create): Update.
12587         * rust-exp.y (struct rust_parser) <update_innermost_block,
12588         lookup_symbol>: New methods.
12589         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12590         Rename.
12591         (rust_parser::rust_lookup_type)
12592         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12593         * printcmd.c (display_command, do_one_display): Update.
12594         * parser-defs.h (struct parser_state) <parser_state>: Add
12595         "tracker" parameter.
12596         (block_tracker): New member.
12597         (class innermost_block_tracker) <innermost_block_tracker>: Add
12598         "types" parameter.
12599         <reset>: Remove method.
12600         (innermost_block): Don't declare.
12601         (null_post_parser): Update.
12602         * parse.c (innermost_block): Remove global.
12603         (write_dollar_variable): Update.
12604         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12605         Remove "tracker_types" parameter.
12606         (parse_expression): Add "tracker" parameter.
12607         (parse_expression_for_completion): Update.
12608         (null_post_parser): Add "tracker" parameter.
12609         * p-exp.y: Update rules.
12610         * m2-exp.y: Update rules.
12611         * language.h (struct language_defn) <la_post_parser>: Add
12612         "tracker" parameter.
12613         * go-exp.y: Update rules.
12614         * f-exp.y: Update rules.
12615         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12616         parameter.
12617         * d-exp.y: Update rules.
12618         * c-exp.y: Update rules.
12619         * breakpoint.c (set_breakpoint_condition): Create an
12620         innermost_block_tracker.
12621         (watch_command_1): Likewise.
12622         * ada-lang.c (resolve): Add "tracker" parameter.
12623         (resolve_subexp): Likewise.
12624         * ada-exp.y (write_var_from_sym): Update.
12625
12626 2019-04-04  Tom Tromey  <tom@tromey.com>
12627
12628         * type-stack.h: New file.
12629         * type-stack.c: New file.
12630         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12631         type-stack.h.
12632         (insert_into_type_stack, insert_type, push_type, push_type_int)
12633         (insert_type_address_space, pop_type, pop_type_int)
12634         (pop_typelist, pop_type_stack, append_type_stack)
12635         (push_type_stack, get_type_stack, push_typelist)
12636         (follow_type_instance_flags, follow_types): Don't declare.
12637         * parse.c (type_stack): Remove global.
12638         (parse_exp_in_context): Update.
12639         (insert_into_type_stack, insert_type, push_type, push_type_int)
12640         (insert_type_address_space, pop_type, pop_type_int)
12641         (pop_typelist, pop_type_stack, append_type_stack)
12642         (push_type_stack, get_type_stack, push_typelist)
12643         (follow_type_instance_flags, follow_types): Remove (moved to
12644         type-stack.c).
12645         * f-exp.y (type_stack): New global.
12646         Update rules.
12647         (push_kind_type, f_parse): Update.
12648         * d-exp.y (type_stack): New global.
12649         Update rules.
12650         (d_parse): Update.
12651         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12652         Update rules.
12653         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12654         (HFILES_NO_SRCDIR): Add type-stack.h.
12655
12656 2019-04-04  Tom Tromey  <tom@tromey.com>
12657
12658         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12659         (rust_parser::convert_ast_to_expression, rust_parse)
12660         (rust_lex_test_completion, rust_lex_tests): Update.
12661         * parser-defs.h (struct expr_completion_state): New.
12662         (struct parser_state) <parser_state>: Add completion parameter.
12663         <mark_struct_expression, mark_completion_tag>: New methods.
12664         <parse_completion, m_completion_state>: New members.
12665         (prefixify_expression, null_post_parser): Update.
12666         (mark_struct_expression, mark_completion_tag): Don't declare.
12667         * parse.c (parse_completion, expout_last_struct)
12668         (expout_tag_completion_type, expout_completion_name): Remove
12669         globals.
12670         (parser_state::mark_struct_expression)
12671         (parser_state::mark_completion_tag): Now methods.
12672         (prefixify_expression): Add last_struct parameter.
12673         (prefixify_subexp): Likewise.
12674         (parse_exp_1): Update.
12675         (parse_exp_in_context): Add cstate parameter.  Update.
12676         (parse_expression_for_completion): Create an
12677         expr_completion_state.
12678         (null_post_parser): Add "completion" parameter.
12679         * p-exp.y: Update rules.
12680         (yylex): Update.
12681         * language.h (struct language_defn) <la_post_parser>: Add
12682         "completing" parameter.
12683         * go-exp.y: Update rules.
12684         (lex_one_token): Update.
12685         * expression.h (parse_completion): Don't declare.
12686         * d-exp.y: Update rules.
12687         (lex_one_token): Update rules.
12688         * c-exp.y: Update rules.
12689         (lex_one_token): Update.
12690         * ada-lang.c (resolve): Add "parse_completion" parameter.
12691         (resolve_subexp): Likewise.
12692         (ada_resolve_function): Likewise.
12693
12694 2019-04-04  Tom Tromey  <tom@tromey.com>
12695
12696         * parser-defs.h (struct parser_state) <start_arglist,
12697         end_arglist>: New methods.
12698         <arglist_len, m_funcall_chain>: New members.
12699         (arglist_len, start_arglist, end_arglist): Don't declare.
12700         * parse.c (arglist_len, funcall_chain): Remove global.
12701         (start_arglist, end_arglist): Remove functions.
12702         (parse_exp_in_context): Update.
12703         * p-exp.y: Update rules.
12704         * m2-exp.y: Update rules.
12705         * go-exp.y: Update rules.
12706         * f-exp.y: Update rules.
12707         * d-exp.y: Update rules.
12708         * c-exp.y: Update rules.
12709
12710 2019-04-04  Tom Tromey  <tom@tromey.com>
12711
12712         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12713         lex_operator, push_back>: New methods.
12714         Update all rules.
12715         (rust_parser::lex_hex, lex_escape): Rename and update.
12716         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12717         (rust_parser::lex_operator): Rename and update.
12718         (rust_parser::lex_number, rustyylex, rustyyerror)
12719         (rust_lex_test_init, rust_lex_test_sequence)
12720         (rust_lex_test_push_back, rust_lex_tests): Update.
12721         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12722         parameter.
12723         <lexptr, prev_lexptr>: New members.
12724         (lexptr, prev_lexptr): Don't declare.
12725         * parse.c (lexptr, prev_lexptr): Remove globals.
12726         (parse_exp_in_context): Update.
12727         * p-exp.y (yylex, yyerror): Update.
12728         * m2-exp.y (parse_number, yylex, yyerror): Update.
12729         * go-exp.y (lex_one_token, yyerror): Update.
12730         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12731         * d-exp.y (lex_one_token, yyerror): Update.
12732         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12733         (lex_one_token, yyerror): Update.
12734         * ada-lex.l (YY_INPUT): Update.
12735         (rewind_to_char): Update.
12736         * ada-exp.y (yyerror): Update.
12737
12738 2019-04-04  Tom Tromey  <tom@tromey.com>
12739
12740         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12741         * parser-defs.h (struct parser_state) <parser_state>: Add new
12742         parameter.
12743         <comma_terminates>: New member.
12744         (comma_terminates): Don't declare global.
12745         * parse.c (comma_terminates): Remove global.
12746         (parse_exp_in_context): Update.
12747         * p-exp.y (yylex): Update.
12748         * m2-exp.y (yylex): Update.
12749         * go-exp.y (lex_one_token): Update.
12750         * f-exp.y (yylex): Update.
12751         * d-exp.y (lex_one_token): Update.
12752         * c-exp.y (lex_one_token): Update.
12753         * ada-lex.l: Update.
12754
12755 2019-04-04  Tom Tromey  <tom@tromey.com>
12756
12757         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12758         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12759         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12760         * parser-defs.h (paren_depth): Don't declare.
12761         * parse.c (paren_depth): Remove global.
12762         (parse_exp_in_context): Update.
12763         * p-exp.y (paren_depth): New global.
12764         (pascal_parse): Initialize it.
12765         * m2-exp.y (paren_depth): New global.
12766         (m2_parse): Initialize it.
12767         * go-exp.y (paren_depth): New global.
12768         (go_parse): Initialize it.
12769         * f-exp.y (paren_depth): New global.
12770         (f_parse): Initialize it.
12771         * d-exp.y (paren_depth): New global.
12772         (d_parse): Initialize it.
12773         * c-exp.y (paren_depth): New global.
12774         (c_parse): Initialize it.
12775         * ada-lex.l (paren_depth): New global.
12776         (lexer_init): Initialize it.
12777
12778 2019-04-04  Tom Tromey  <tom@tromey.com>
12779
12780         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12781         (rust_parser::convert_ast_to_type)
12782         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12783         * parser-defs.h (struct parser_state) <parser_state>: Add
12784         parameters.  Initialize new members.
12785         <expression_context_block, expression_context_pc>: New members.
12786         * parse.c (expression_context_block, expression_context_pc):
12787         Remove globals.
12788         (parse_exp_in_context): Update.
12789         * p-exp.y: Update all rules.
12790         (yylex): Update.
12791         * m2-exp.y: Update all rules.
12792         (yylex): Update.
12793         * go-exp.y (yylex): Update.
12794         * f-exp.y (yylex): Update.
12795         * d-exp.y: Update all rules.
12796         (yylex): Update.
12797         * c-exp.y: Update all rules.
12798         (lex_one_token, classify_name, yylex, c_parse): Update.
12799         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12800
12801 2019-04-04  Tom Tromey  <tom@tromey.com>
12802
12803         * gdbarch.h, gdbarch.c: Rebuild.
12804         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12805         * stap-probe.h:
12806         (struct stap_parse_info): Replace "parser_state" with
12807         "expr_builder".
12808         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12809         (parser_state): New class.
12810         * parse.c (expr_builder): Rename.
12811         (expr_builder::release): Rename.
12812         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12813         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12814         (write_exp_elt_longcst, write_exp_elt_floatcst)
12815         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12816         (write_exp_string_vector, write_exp_bitstring)
12817         (write_exp_msymbol, mark_struct_expression)
12818         (write_dollar_variable)
12819         (insert_type_address_space, increase_expout_size): Replace
12820         "parser_state" with "expr_builder".
12821         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12822         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12823         "parser_state" with "expr_builder".
12824
12825 2019-04-04  Tom Tromey  <tom@tromey.com>
12826
12827         * rust-exp.y: Replace "parse_language" with method call.
12828         * p-exp.y:
12829         (yylex): Replace "parse_language" with method call.
12830         * m2-exp.y:
12831         (yylex): Replace "parse_language" with method call.
12832         * go-exp.y (classify_name): Replace "parse_language" with method
12833         call.
12834         * f-exp.y (yylex): Replace "parse_language" with method call.
12835         * d-exp.y (lex_one_token): Replace "parse_language" with method
12836         call.
12837         * c-exp.y:
12838         (lex_one_token, classify_name, yylex): Replace "parse_language"
12839         with method call.
12840         * ada-exp.y (find_primitive_type, type_char)
12841         (type_system_address): Replace "parse_language" with method call.
12842
12843 2019-04-04  Tom Tromey  <tom@tromey.com>
12844
12845         * rust-exp.y: Replace "parse_gdbarch" with method call.
12846         * parse.c (write_dollar_variable, insert_type_address_space):
12847         Replace "parse_gdbarch" with method call.
12848         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12849         call.
12850         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12851         call.
12852         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12853         "parse_gdbarch" with method call.
12854         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12855         with method call.
12856         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12857         "parse_gdbarch" with method call.
12858         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12859         "parse_gdbarch" with method call.
12860         * c-exp.y (parse_type, parse_number, classify_name): Replace
12861         "parse_gdbarch" with method call.
12862         * ada-lex.l: Replace "parse_gdbarch" with method call.
12863         * ada-exp.y (parse_type, find_primitive_type, type_char)
12864         (type_system_address): Replace "parse_gdbarch" with method call.
12865
12866 2019-04-04  Tom Tromey  <tom@tromey.com>
12867
12868         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12869         * stap-probe.c (stap_parse_argument): Update.
12870         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12871         initial_size parameter.
12872         * rust-exp.y (rust_lex_tests): Update.
12873         * parse.c (parser_state): Update.
12874         (parse_exp_in_context): Update.
12875         * parser-defs.h (struct parser_state) <parser_state>: Remove
12876         "initial_size" parameter.
12877
12878 2019-04-04  Tom Tromey  <tom@tromey.com>
12879
12880         * parser-defs.h (increase_expout_size): Don't declare.
12881         * parse.c (increase_expout_size): Now static.
12882
12883 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12884
12885         * gnu-nat.c (gnu_nat_target::wait): Fix
12886         target_waitstatus_to_string call.
12887
12888 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12889
12890         * eval.c (evaluate_subexp_standard): Handle internal functions
12891         during Fortran function call handling.
12892
12893 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12894
12895         * NEWS: Mention new internal functions.
12896         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12897         (read_base_type): Use dwarf2_init_complex_target_type.
12898         * value.c (creal_internal_fn): New function.
12899         (cimag_internal_fn): New function.
12900         (_initialize_values): Register new internal functions.
12901
12902 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12903
12904         * infrun.c (stop_all_threads): If debug_infrun, always
12905         trace the wait status after wait_one, using
12906         target_waitstatus_to_string and target_pid_to_str.
12907         (handle_inferior_event): Replace various trace of
12908         wait status kind by a single trace.
12909         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12910         wait status kind image by target_waitstatus_to_string.
12911         * target/waitstatus.c (target_waitstatus_to_string): Fix
12912         obsolete comment.
12913
12914 2019-04-01  Tom Tromey  <tromey@adacore.com>
12915
12916         PR symtab/23331:
12917         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12918
12919 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12920             Pedro Alves  <palves@redhat.com>
12921
12922         * top.c (quit_force): Call 'finalize_values'.
12923         * value.c (finalize_values): New function.
12924         * value.h (finalize_values): Declare.
12925
12926 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12927
12928         * NEWS: Announce $_gdb_major and $_gdb_minor.
12929
12930         * top.c (init_gdb_version_vars): New function.
12931         (gdb_init): Call init_gdb_version_vars.
12932
12933 2019-03-29  Tom Tromey  <tromey@adacore.com>
12934
12935         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12936         help text.  Remove dead code.
12937
12938 2019-03-29  Keith Seitz  <keiths@redhat.com>
12939
12940         From Siddhesh Poyarekar:
12941         * f-lang.h (f77_get_upperbound): Return LONGEST.
12942         (f77_get_lowerbound): Likewise.
12943         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12944         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12945         print them.
12946         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12947         plongest to format print it.
12948         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12949         (f77_get_upperbound): Likewise.
12950         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12951         LOWER_BOUND to LONGEST.
12952         (f77_create_arrayprint_offset_tbl): Likewise.
12953
12954 2019-03-29  Keith Seitz  <keiths@redhat.com>
12955
12956         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12957         %s/pulongest for TYPE_LENGTH instead of %d in format
12958         strings.
12959         * ada-typerint.c (ada_print_type): Likewise.
12960         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12961         * compile/compile-c-support.c (generate_register_struct): Likewise.
12962         * gdbtypes.c (recursive_dump_type): Likewise.
12963         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12964         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12965         instead of %d in format strings.
12966         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12967         to std::min to ULONGEST.
12968         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12969         instead of %d in format strings.
12970         * tracepoint.c (info_scope_command): Likewise.
12971         * typeprint.c (print_offset_data::update)
12972         (print_offset_data::finish): Likewise.
12973         * xtensa-tdep.c (xtensa_store_return_value)
12974         (xtensa_push_dummy_call): Likewise.
12975
12976 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12977
12978         * windows-nat.c (display_selector): Fixed format specifications
12979         for 64-bit Cygwin.
12980
12981 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12982
12983         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12984
12985 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12986
12987         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12988         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12989         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12990         (nios2_linux_init_abi): Install it.
12991
12992 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12993
12994         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12995
12996 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12997
12998         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12999
13000 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13001             Tom Tromey  <tromey@adacore.com>
13002
13003         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13004
13005 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13006
13007         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13008         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13009         method to compute the bounds of range types. Also print "[evaluated]"
13010         if the bounds' values come from a dynamic evaluation.
13011
13012 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13013
13014         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13015         whitespace when pretty printing is on.
13016
13017 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13018
13019         * ppc-linux-nat.c: Add include.
13020
13021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13022
13023         * NEWS: Mention AArch64 Pointer Authentication.
13024
13025 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13026
13027         * arm-linux-nat.c: Add include.
13028
13029 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13030
13031         * source-cache.c (source_cache::get_source_lines): Re-read
13032         fullname after calling open_source_file.
13033
13034 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13035
13036         * NEWS: Mention TLS support for FreeBSD.
13037
13038 2019-03-25  Tom Tromey  <tromey@adacore.com>
13039
13040         * minsyms.c (BUNCH_SIZE): Update comment.
13041         (~minimal_symbol_reader): Remove old comment.
13042         (compact_minimal_symbols): Update comment.
13043         (minimal_symbol_reader::install): Remove old comment.  Update
13044         other comments.
13045
13046 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13047
13048         * s390-linux-nat.c: Add include.
13049
13050 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13051
13052         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13053         Call linux_get_hwcap.
13054         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13055         Likewise.
13056         (aarch64_linux_get_hwcap): Remove function.
13057         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13058         declaration.
13059         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13060         linux_get_hwcap.
13061         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13062         * linux-tdep.c (linux_get_hwcap): Add function.
13063         (linux_get_hwcap2): Likewise.
13064         * linux-tdep.h (linux_get_hwcap): Add declaration.
13065         (linux_get_hwcap2): Likewise.
13066         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13067         (ppc_linux_get_hwcap2): Likewise.
13068         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13069         linux_get_hwcap.
13070         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13071         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13072         (ppc_linux_nat_target::read_description): Likewise.
13073         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13074         * s390-linux-nat.c: Likewise.
13075         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13076
13077 2019-03-24  Tom Tromey  <tom@tromey.com>
13078
13079         * ada-lang.c (standard_lookup): Simplify initialization.
13080         (ada_lookup_symbol_nonlocal): Simplify return.
13081         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13082         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13083         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13084         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13085         initialization.
13086         * solib.c (solib_global_lookup): Simplify.
13087         * symtab.c (null_block_symbol): Remove.
13088         (symbol_cache_lookup): Simplify returns.
13089         (lookup_language_this): Simplify returns.
13090         (lookup_symbol_aux): Simplify return.
13091         (lookup_local_symbol): Simplify returns.
13092         (lookup_global_symbol_from_objfile): Simplify return.
13093         (lookup_symbol_in_objfile_symtabs)
13094         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13095         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13096         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13097         * cp-namespace.c (cp_lookup_bare_symbol)
13098         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13099         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13100         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13101         (cp_lookup_symbol_via_imports): Simplify initialization.
13102         (find_symbol_in_baseclass): Likewise.
13103         * symtab.h (null_block_symbol): Remove.
13104         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13105         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13106         (d_lookup_symbol_module): Likewise.
13107         (find_symbol_in_baseclass): Simplify initialization.
13108
13109 2019-03-24  Tom Tromey  <tom@tromey.com>
13110
13111         * expression.h: Don't include symtab.h.
13112         (struct block): Forward declare.
13113
13114 2019-03-24  Tom Tromey  <tom@tromey.com>
13115
13116         * c-exp.y (typebase): Remove casts.
13117         * gdbtypes.c (lookup_unsigned_typename, )
13118         (lookup_signed_typename): Remove cast.
13119         * eval.c (parse_to_comma_and_eval): Remove cast.
13120         * parse.c (write_dollar_variable): Remove cast.
13121         * block.h (struct block) <superblock>: Now const.
13122         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13123         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13124         (map_block): Make "block" const.
13125         * symfile.h (struct quick_symbol_functions)
13126         <map_matching_symbols>: Constify block argument to "callback".
13127         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13128         const.
13129         (find_pc_sect_compunit_symtab): Make "b" const.
13130         (find_symbol_at_address): Likewise.
13131         (search_symbols): Likewise.
13132         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13133         (dw2_debug_names_lookup_symbol): Likewise.
13134         (dw2_map_matching_symbols): Update.
13135         * p-valprint.c (pascal_val_print): Remove "block".
13136         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13137         (aux_add_nonlocal_symbols): Make "block" const.
13138         (resolve_subexp): Remove cast.
13139         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13140         const.
13141         (iterate_over_file_blocks): Likewise.
13142         * f-exp.y (%union) <bval>: Remove.
13143         * coffread.c (patch_opaque_types): Make "b" const.
13144         * spu-tdep.c (spu_catch_start): Make "block" const.
13145         * c-valprint.c (print_unpacked_pointer): Remove "block".
13146         * symmisc.c (dump_symtab_1): Make "b" const.
13147         (block_depth): Make "block" const.
13148         * d-exp.y (%union) <bval>: Remove.
13149         * cp-support.h (cp_lookup_rtti_type): Update.
13150         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13151         * psymtab.c (psym_lookup_symbol): Make "block" const.
13152         (maintenance_check_psymtabs): Make "b" const.
13153         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13154         (enumerate_locals, enumerate_args): Update.
13155         * python/py-symtab.c (stpy_global_block): Make "block" const.
13156         (stpy_static_block): Likewise.
13157         * inline-frame.c (block_starting_point_at): Make "new_block"
13158         const.
13159         * block.c (find_block_in_blockvector): Make return type const.
13160         (blockvector_for_pc_sect): Make "b" const.
13161         (find_block_in_blockvector): Make "b" const.
13162
13163 2019-03-23  Tom Tromey  <tom@tromey.com>
13164
13165         * varobj.c (varobj_create): Update.
13166         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13167         * printcmd.c (display_command, do_one_display): Don't reset
13168         innermost_block.
13169         * parser-defs.h (enum innermost_block_tracker_type): Move to
13170         expression.h.
13171         (innermost_block): Update comment.
13172         * parse.c (parse_exp_1): Add tracker_types parameter.
13173         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13174         tracker_types parameter.  Reset innermost_block.
13175         (parse_exp_in_context): Remove.
13176         (parse_expression_for_completion): Update.
13177         * objfiles.c (~objfile): Don't reset expression_context_block or
13178         innermost_block.
13179         * expression.h (enum innermost_block_tracker_type): Move from
13180         parser-defs.h.
13181         (parse_exp_1): Add tracker_types parameter.
13182         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13183         reset innermost_block.
13184
13185 2019-03-23  Tom Tromey  <tom@tromey.com>
13186
13187         * objfiles.h: Include bcache.h.
13188
13189 2019-03-23  Tom Tromey  <tom@tromey.com>
13190
13191         * linespec.c (get_current_search_block): Use
13192         scoped_restore_current_language.
13193         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13194
13195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13196             Jiong Wang  <jiong.wang@arm.com>
13197
13198         * aarch64-linux-tdep.c
13199         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13200         section.
13201         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13202
13203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13204             Jiong Wang  <jiong.wang@arm.com>
13205
13206         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13207         instructions.
13208         (aarch64_analyze_prologue_test): Add PACIASP test.
13209         (aarch64_prologue_prev_register): Unmask PC value.
13210
13211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13212             Jiong Wang  <jiong.wang@arm.com>
13213
13214         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13215         (aarch64_dwarf2_prev_register): Unmask PC value.
13216         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13217         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13218         DW_CFA_AARCH64_negate_ra_state.
13219         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13220
13221 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13222             Jiong Wang  <jiong.wang@arm.com>
13223
13224         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13225         registers.
13226         (aarch64_pseudo_register_name): Likewise.
13227         (aarch64_pseudo_register_type): Likewise.
13228         (aarch64_pseudo_register_reggroup_p): Likewise.
13229         (aarch64_gdbarch_init): Add pauth registers.
13230         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13231         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13232         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13233         (struct gdbarch_tdep): Add regnum for ra_state.
13234
13235 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13236             Jiong Wang  <jiong.wang@arm.com>
13237
13238         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13239
13240 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13241             Jiong Wang  <jiong.wang@arm.com>
13242
13243         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13244         function.
13245         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13246         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13247         (aarch64_gdbarch_init): Add puth registers.
13248         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13249         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13250         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13251
13252 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13253             Jiong Wang  <jiong.wang@arm.com>
13254
13255         * aarch64-linux-nat.c
13256         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13257         * aarch64-linux-tdep.c
13258         (aarch64_linux_core_read_description): Likewise.
13259         (aarch64_linux_get_hwcap): New function.
13260         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13261         (aarch64_linux_get_hwcap): New declaration.
13262
13263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13264             Jiong Wang  <jiong.wang@arm.com>
13265
13266         * aarch64-linux-nat.c
13267         (aarch64_linux_nat_target::read_description): Add pauth param.
13268         * aarch64-linux-tdep.c
13269         (aarch64_linux_core_read_description): Likewise.
13270         * aarch64-tdep.c (struct target_desc): Add in pauth.
13271         (aarch64_read_description): Add pauth param.
13272         (aarch64_gdbarch_init): Likewise.
13273         * aarch64-tdep.h (aarch64_read_description): Likewise.
13274         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13275         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13276         * features/Makefile: Add new files.
13277         * features/aarch64-pauth.c: New file.
13278         * features/aarch64-pauth.xml: New file.
13279
13280 2019-03-20  Tom Tromey  <tromey@adacore.com>
13281
13282         * infrun.c (handle_inferior_event): Rename from
13283         handle_inferior_event_1.  Create a scoped_value_mark.
13284         (handle_inferior_event): Remove.
13285
13286 2019-03-19  Tom Tromey  <tromey@adacore.com>
13287
13288         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13289         * infrun.h (print_stop_event): Add "displays" parameter.
13290         * infrun.c (print_stop_event): Add "displays" parameter.
13291
13292 2019-03-19  Pedro Alves  <palves@redhat.com>
13293
13294         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13295         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13296         to -1.  Fix TABs vs spaces.
13297         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13298         * tui/tui-out.h (tui_ui_out) Add intro comments.
13299         <m_line, m_start_of_line>: In-class initialize, and add describing
13300         comment.
13301
13302 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13303
13304         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13305         variable names.
13306         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13307
13308 2019-03-18  Pedro Alves  <palves@redhat.com>
13309             Eli Zaretskii <eliz@gnu.org>
13310
13311         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13312         m_line and m_start_of_line.
13313
13314 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13315
13316         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13317         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13318         it returns a newline.  This fixes a regression in TU mode, whereby
13319         the next line is output on the same screen line as the user input.
13320
13321 2019-03-18  Tom Tromey  <tromey@adacore.com>
13322
13323         * minsyms.c (minimal_symbol_reader::install): Remove call to
13324         obstack_blank.
13325
13326 2019-03-18  Pedro Alves  <palves@redhat.com>
13327
13328         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13329         New globals.
13330         (apply_style): New, factored out from ...
13331         (apply_ansi_escape): ... this.  Handle reverse video mode.
13332         (tui_set_reverse_mode): New function.
13333         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13334         * tui/tui-winsource.c (tui_show_source_line): Use
13335         tui_set_reverse_mode instead of setting A_STANDOUT.
13336         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13337         New setter methods.
13338
13339 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13340
13341         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13342         Handle tabs.
13343
13344 2019-03-18  Tom Tromey  <tromey@adacore.com>
13345
13346         * ada-lang.c (empty_array): Add "high" parameter.
13347         (ada_evaluate_subexp): Update.
13348
13349 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13350
13351         * unittests/string_view-selftests.c: Define
13352         _initialize_string_view_selftests unconditionally.
13353
13354 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13355
13356         PR gdb/24350
13357         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13358
13359 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13360
13361         PR gdb/24351
13362         * windows-nat.c (display_selector): Fix format specifiers.
13363
13364 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13365
13366         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13367         tui_refill_source_window instead of tui_refresh_win, to update the
13368         current execution line.  This fixes redisplay of the current line
13369         when stepping through the code with "next" or "step".
13370
13371 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13372
13373         * source-cache.c (source_cache::get_source_lines): Call
13374         find_source_lines to initialize s->nlines.  This fixes vertical
13375         scrolling of TUI source window when the DOWN arrow is pressed.
13376
13377 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13378
13379         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13380         linux-thread-db.c (_initialize_thread_db): Likewise.
13381
13382 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13383
13384         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13385         wclrtoeol in tui_show_source_line".  This reverts changes made in
13386         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13387
13388 2019-03-15  Tom Tromey  <tom@tromey.com>
13389
13390         * symtab.h (struct minimal_symbol): Derive from
13391         general_symbol_info.
13392         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13393         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13394         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13395         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13396         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13397         (MSYMBOL_SEARCH_NAME): Update.
13398         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13399         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13400         * minsyms.c (minimal_symbol_reader::record_full): Update.
13401
13402 2019-03-15  Tom Tromey  <tom@tromey.com>
13403
13404         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13405
13406 2019-03-15  Tom Tromey  <tom@tromey.com>
13407
13408         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13409         unique_xmalloc_ptr.
13410         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13411         Update.
13412         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13413         (build_minimal_symbol_hash_tables)
13414         (minimal_symbol_reader::install): Update.
13415
13416 2019-03-15  Tom Tromey  <tom@tromey.com>
13417
13418         * symtab.c (create_demangled_names_hash): Update.
13419         (symbol_set_names): Update.
13420         * objfiles.h (struct objfile_per_bfd_storage)
13421         <demangled_names_hash>: Now an htab_up.
13422         * objfiles.c (objfile_per_bfd_storage): Simplify.
13423
13424 2019-03-15  Tom Tromey  <tom@tromey.com>
13425
13426         * objfiles.h (struct objfile_per_bfd_storage): Declare
13427         destructor.
13428         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13429         New.
13430         (get_objfile_bfd_data): Use new.  Don't initialize
13431         language_of_main.
13432         (free_objfile_per_bfd_storage): Remove.
13433         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13434
13435 2019-03-15  Tom Tromey  <tom@tromey.com>
13436
13437         * symfile.c (reread_symbols): Update.
13438         * objfiles.c (objfile::objfile): Update.
13439         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13440         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13441         comment.
13442         (minimal_symbol_reader::install): Update.
13443         (terminate_minimal_symbol_table): Remove.
13444         * jit.c (jit_object_close_impl): Update.
13445
13446 2019-03-15  Tom Tromey  <tom@tromey.com>
13447
13448         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13449         initializations.
13450
13451 2019-03-15  Tom Tromey  <tom@tromey.com>
13452
13453         * objfiles.h (struct objfile_per_bfd_storage)
13454         <demangled_hash_languages>: Now a bitset.
13455         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13456         (lookup_minimal_symbol): Update.
13457
13458 2019-03-15  Tom Tromey  <tom@tromey.com>
13459
13460         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13461         Don't return the symbol.
13462         * coffread.c (record_minimal_symbol): Use record_full.
13463
13464 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13465
13466         The MS-Windows port of ncurses fails to switch to a color pair if
13467         one or both of the colors are the implicit default colors.  This
13468         change records the default colors when TUI is initialized, and
13469         then specifies them explicitly when a color pair uses the default
13470         colors.  This allows color styling in TUI mode on MS-Windows.
13471
13472         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13473         ncurses_norm_attr.
13474         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13475         colors in ncurses_norm_attr.
13476         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13477         "none", replace it with the default color recorded in
13478         ncurses_norm_attr.
13479
13480 2019-03-14  Tom Tromey  <tromey@adacore.com>
13481
13482         * source-cache.h (class source_cache) <get_source_lines>: Return
13483         std::string.
13484         * source-cache.c (source_cache::extract_lines): Handle case where
13485         first_pos==npos.  Return std::string.
13486         (source_cache::get_source_lines): Update.
13487
13488 2019-03-14  Tom Tromey  <tromey@adacore.com>
13489
13490         * NEWS: Add item for "style sources" commands.
13491         * source-cache.c (source_cache::get_source_lines): Check
13492         source_styling.
13493         * cli/cli-style.c (source_styling): New global.
13494         (_initialize_cli_style): Add "style sources" commands.
13495         (show_style_sources): New function.
13496         * cli/cli-style.h (source_styling): Declare.
13497
13498 2019-03-14  Pedro Alves  <palves@redhat.com>
13499             Tom Tromey  <tromey@adacore.com>
13500
13501         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13502         * tui/tui-winsource.c (tui_refill_source_window): New function,
13503         from...
13504         (tui_horizontal_source_scroll): ... here.  Move some logic.
13505         * cli/cli-style.c (set_style_enabled): Notify new observable.
13506         * tui/tui-hooks.c (tui_redisplay_source): New function.
13507         (tui_attach_detach_observers): Attach or detach
13508         tui_redisplay_source.
13509         * observable.h (source_styling_changed): New observable.
13510         * observable.c: Define source_styling_changed observable.
13511
13512 2019-03-13  Tom Tromey  <tromey@adacore.com>
13513
13514         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13515         (i386_gnu_nat_target::store_registers): Update.
13516         * target-debug.h (target_debug_print_std_string): New macro.
13517         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13518         * windows-tdep.c (display_one_tib): Update.
13519         * tui/tui-stack.c (tui_make_status_line): Update.
13520         * top.c (print_inferior_quit_action): Update.
13521         * thread.c (thr_try_catch_cmd): Update.
13522         (add_thread_with_info): Update.
13523         (thread_target_id_str): Update.
13524         (thr_try_catch_cmd): Update.
13525         (thread_command): Update.
13526         (thread_find_command): Update.
13527         * record-btrace.c (record_btrace_target::info_record)
13528         (record_btrace_resume_thread, record_btrace_target::resume)
13529         (record_btrace_cancel_resume, record_btrace_step_thread)
13530         (record_btrace_target::wait, record_btrace_target::wait)
13531         (record_btrace_target::wait, record_btrace_target::stop): Update.
13532         * progspace.c (print_program_space): Update.
13533         * process-stratum-target.c
13534         (process_stratum_target::thread_address_space): Update.
13535         * linux-fork.c (linux_fork_mourn_inferior)
13536         (detach_checkpoint_command, info_checkpoints_command)
13537         (linux_fork_context): Update.
13538         (linux_fork_detach): Update.
13539         (class scoped_switch_fork_info): Update.
13540         (delete_checkpoint_command): Update.
13541         * infrun.c (follow_fork_inferior): Update.
13542         (follow_fork_inferior): Update.
13543         (proceed_after_vfork_done): Update.
13544         (handle_vfork_child_exec_or_exit): Update.
13545         (follow_exec): Update.
13546         (displaced_step_prepare_throw): Update.
13547         (displaced_step_restore): Update.
13548         (start_step_over): Update.
13549         (resume_1): Update.
13550         (clear_proceed_status_thread): Update.
13551         (proceed): Update.
13552         (print_target_wait_results): Update.
13553         (do_target_wait): Update.
13554         (context_switch): Update.
13555         (stop_all_threads): Update.
13556         (restart_threads): Update.
13557         (finish_step_over): Update.
13558         (handle_signal_stop): Update.
13559         (switch_back_to_stepped_thread): Update.
13560         (keep_going_pass_signal): Update.
13561         (print_exited_reason): Update.
13562         (normal_stop): Update.
13563         * inferior.c (inferior_pid_to_str): Change return type.
13564         (print_selected_inferior): Update.
13565         (add_inferior): Update.
13566         (detach_inferior): Update.
13567         * dummy-frame.c (fprint_dummy_frames): Update.
13568         * dcache.c (dcache_info_1): Update.
13569         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13570         (btrace_fetch, btrace_clear): Update.
13571         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13572         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13573         type.
13574         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13575         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13576         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13577         * gdbarch.c, gdbarch.h: Rebuild.
13578         * gdbarch.sh (core_pid_to_str): Change return type.
13579         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13580         return type.
13581         (windows_nat_target::pid_to_str): Change return type.
13582         (windows_delete_thread): Update.
13583         (windows_nat_target::attach): Update.
13584         (windows_nat_target::files_info): Update.
13585         * target-delegates.c: Rebuild.
13586         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13587         return type.
13588         (sol_thread_target::pid_to_str): Change return type.
13589         * remote.c (class remote_target) <pid_to_str>: Change return
13590         type.
13591         (remote_target::pid_to_str): Change return type.
13592         (extended_remote_target::attach, remote_target::remote_stop_ns)
13593         (remote_target::remote_notif_remove_queued_reply)
13594         (remote_target::push_stop_reply, remote_target::disable_btrace):
13595         Update.
13596         (extended_remote_target::attach): Update.
13597         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13598         type.
13599         (gdbsim_target::pid_to_str): Change return type.
13600         * ravenscar-thread.c (struct ravenscar_thread_target)
13601         <pid_to_str>: Change return type.
13602         (ravenscar_thread_target::pid_to_str): Change return type.
13603         * procfs.c (class procfs_target) <pid_to_str>: Change return
13604         type.
13605         (procfs_target::pid_to_str): Change return type.
13606         (procfs_target::attach): Update.
13607         (procfs_target::detach): Update.
13608         (procfs_target::fetch_registers): Update.
13609         (procfs_target::store_registers): Update.
13610         (procfs_target::wait): Update.
13611         (procfs_target::files_info): Update.
13612         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13613         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13614         return type.
13615         (nto_procfs_target::pid_to_str): Change return type.
13616         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13617         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13618         return type.
13619         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13620         (exit_lwp): Update.
13621         (attach_proc_task_lwp_callback, get_detach_signal)
13622         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13623         (linux_nat_target::resume, wait_lwp, stop_callback)
13624         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13625         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13626         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13627         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13628         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13629         type.
13630         (inf_ptrace_target::attach): Update.
13631         (inf_ptrace_target::files_info): Update.
13632         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13633         type.
13634         (go32_nat_target::pid_to_str): Change return type.
13635         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13636         (gnu_nat_target::wait): Update.
13637         (gnu_nat_target::wait): Update.
13638         (gnu_nat_target::resume): Update.
13639         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13640         (fbsd_nat_target::wait): Update.
13641         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13642         type.
13643         (darwin_nat_target::attach): Update.
13644         * corelow.c (class core_target) <pid_to_str>: Change return type.
13645         (core_target::pid_to_str): Change return type.
13646         * target.c (normal_pid_to_str): Change return type.
13647         (default_pid_to_str): Likewise.
13648         (target_pid_to_str): Change return type.
13649         (target_translate_tls_address): Update.
13650         (target_announce_detach): Update.
13651         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13652         return type.
13653         (bsd_uthread_target::pid_to_str): Change return type.
13654         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13655         type.
13656         (bsd_kvm_target::pid_to_str): Change return type.
13657         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13658         return type.
13659         (aix_thread_target::pid_to_str): Change return type.
13660         * target.h (struct target_ops) <pid_to_str>: Change return type.
13661         (target_pid_to_str, normal_pid_to_str): Likewise.
13662         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13663         type.
13664         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13665         type.
13666         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13667         return type.
13668         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13669         type.
13670         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13671         type.
13672         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13673         return type.
13674
13675 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13676
13677         * NEWS: Mention that the new default MI version is 3.  Mention
13678         changes to the output of commands and events that deal with
13679         multi-location breakpoints.
13680         * breakpoint.c: Include "mi/mi-out.h".
13681         (print_one_breakpoint): Change output syntax if using MI version
13682         >= 3.
13683         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13684         New.
13685         (mi_multi_location_breakpoint_output_fixed): New.
13686         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13687         (mi_cmd_fix_multi_location_breakpoint_output): New.
13688         (mi_multi_location_breakpoint_output_fixed): New.
13689         * mi/mi-cmds.c (mi_cmds): Register command
13690         -fix-multi-location-breakpoint-output.
13691         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13692         interpreter "mi".
13693
13694 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13695
13696         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13697         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13698         instantiate mi_ui_out based on interpreter name.
13699         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13700         * mi/mi-main.c (mi_load_progress): Likewise.
13701
13702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13703
13704         * NEWS: Combine separate "New targets" sections for 8.3.
13705
13706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13707
13708         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13709         (ppcfbsd_init_abi): Install gdbarch
13710         "fetch_tls_load_module_address" and "get_thread_local_address"
13711         methods.
13712
13713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13714
13715         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13716         (riscv_fbsd_init_abi): Install gdbarch
13717         "fetch_tls_load_module_address" and "get_thread_local_address"
13718         methods.
13719
13720 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13721
13722         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13723         (i386fbsd_init_abi): Install gdbarch
13724         "fetch_tls_load_module_address" and "get_thread_local_address"
13725         methods.
13726
13727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13728
13729         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13730         (amd64fbsd_init_abi): Install gdbarch
13731         "fetch_tls_load_module_address" and "get_thread_local_address"
13732         methods.
13733
13734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13735
13736         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13737         (struct fbsd_pspace_data): New type.
13738         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13739         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13740         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13741         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13742         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13743
13744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13745
13746         * gdbtypes.c (lookup_struct_elt): New function.
13747         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13748         * gdbtypes.h (struct struct_elt): New type.
13749         (lookup_struct_elt): New prototype.
13750
13751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13752
13753         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13754         remove disabled code block.
13755
13756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13757
13758         * gdbarch.sh (get_thread_local_address): New method.
13759         * gdbarch.h, gdbarch.c: Regenerate.
13760         * target.c (target_translate_tls_address): Use
13761         gdbarch_get_thread_local_address if present instead of
13762         target::get_thread_local_address.
13763
13764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13765
13766         * target.h (target::get_thread_local_address): Update comment.
13767
13768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13769
13770         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13771         objfile->separate_debug_objfile_backlink if not NULL.
13772
13773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13774
13775         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13776         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13777         (amd64bsd_store_inferior_registers): Likewise.
13778         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13779         Enable segment base registers.
13780         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13781         PT_GETFSBASE and PT_GETGSBASE.
13782         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13783         PT_SETGSBASE.
13784         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13785         segment base registers.
13786         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13787
13788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13789
13790         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13791         Update calls to i386_target_description to add 'segments'
13792         parameter.
13793         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13794         add segment base registers.
13795         * arch/i386.c (i386_create_target_description): Add 'segments'
13796         parameter to enable segment base registers.
13797         * arch/i386.h (i386_create_target_description): Likewise.
13798         * features/i386/32bit-segments.xml: New file.
13799         * features/i386/32bit-segments.c: Generate.
13800         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13801         call to i386_target_description to add 'segments' parameter.
13802         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13803         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13804         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13805         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13806         if feature is present.
13807         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13808         Add 'segments' parameter to call to i386_target_description.
13809         (i386_target_description): Add 'segments' parameter to enable
13810         segment base registers.
13811         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13812         to call to i386_target_description.
13813         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13814         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13815         Define I386_NUM_REGS.
13816         (i386_target_description): Add 'segments' parameter to enable
13817         segment base registers.
13818
13819 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13820
13821         PR/24325
13822         * source-cache.c: #undef open and close, to avoid unresolved
13823         externals during linking.
13824
13825 2019-03-12  Tom Tromey  <tromey@adacore.com>
13826
13827         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13828         const.  Add initializers.
13829         (_initialize_remote): Don't initialize ptid globals.
13830
13831 2019-03-12  Pedro Alves  <palves@redhat.com>
13832
13833         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13834
13835 2019-03-12  Pedro Alves  <palves@redhat.com>
13836
13837         * cp-name-parser.y (main): Remove unused 'len' variable.
13838
13839 2019-03-12  Tom Tromey  <tromey@adacore.com>
13840
13841         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13842         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13843
13844 2019-03-12  Tom Tromey  <tromey@adacore.com>
13845
13846         * linux-nat.c (iterate_over_lwps): Update.
13847         (stop_callback): Remove parameter.
13848         (stop_wait_callback, detach_callback, resume_set_callback)
13849         (select_singlestep_lwp_callback, set_ignore_sigint)
13850         (status_callback, resumed_callback, resume_clear_callback)
13851         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13852         data parameter.
13853         (linux_nat_target::detach, linux_nat_target::resume)
13854         (linux_stop_and_wait_all_lwps, select_event_lwp)
13855         (linux_nat_filter_event, linux_nat_wait_1)
13856         (linux_nat_target::kill, linux_nat_target::stop)
13857         (linux_nat_target::stop): Update.
13858         (linux_nat_resume_callback): Change type.
13859         (resume_stopped_resumed_lwps, count_events_callback)
13860         (select_event_lwp_callback): Likewise.
13861         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13862         * arm-linux-nat.c (struct update_registers_data): Remove.
13863         (update_registers_callback): Change type.
13864         (arm_linux_insert_hw_breakpoint1): Update.
13865         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13866         parameter.
13867         (x86_linux_dr_set_addr): Update.
13868         (x86_linux_dr_set_control): Update.
13869         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13870         (iterate_over_lwps): Use gdb::function_view.
13871         * nat/aarch64-linux-hw-point.c (struct
13872         aarch64_dr_update_callback_param): Remove.
13873         (debug_reg_change_callback): Change type.
13874         (aarch64_notify_debug_reg_change): Update.
13875         * s390-linux-nat.c (s390_refresh_per_info): Update.
13876
13877 2019-03-11  Tom Tromey  <tromey@adacore.com>
13878
13879         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13880         redundant assignment to "this_cu".
13881
13882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13883
13884         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13885
13886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13887
13888         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13889         from...
13890         (rank_one_type): ... this.
13891
13892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13893
13894         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13895         from...
13896         (rank_one_type): ... this.
13897
13898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13899
13900         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13901         from...
13902         (rank_one_type): ... this.
13903
13904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13905
13906         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13907         from...
13908         (rank_one_type): ... this.
13909
13910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13911
13912         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13913         from...
13914         (rank_one_type): ... this.
13915
13916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13917
13918         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13919         from...
13920         (rank_one_type): ... this.
13921
13922 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13923
13924         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13925         from...
13926         (rank_one_type): ... this.
13927
13928 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13929
13930         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13931         from...
13932         (rank_one_type): ... this.
13933
13934 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13935
13936         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13937         from...
13938         (rank_one_type): ... this.
13939
13940 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13941
13942         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13943         from...
13944         (rank_one_type): ... this.
13945
13946 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13947
13948         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13949         from...
13950         (rank_one_type): ... this.
13951
13952 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13953
13954         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13955         from...
13956         (rank_one_type): ... this.
13957
13958 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13959
13960         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13961         inferior-events' shows the example events.
13962
13963 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13964
13965         Support styling on native MS-Windows console
13966
13967         PR/24315
13968         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13969         on MS-Windows if $TERM is not defined.
13970
13971         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13972
13973         * posix-hdep.c (gdb_console_fputs):
13974         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13975         functions.
13976         * ui-file.h (gdb_console_fputs): Add prototype.
13977
13978         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13979         back to fputs only if the former returns zero.
13980
13981 2019-03-07  Tom Tromey  <tom@tromey.com>
13982
13983         * symmisc.c (print_symbol_bcache_statistics): Update.
13984         (print_objfile_statistics): Update.
13985         * symfile.c (allocate_symtab): Update.
13986         * stabsread.c: Don't include bcache.h.
13987         * psymtab.h (struct psymbol_bcache): Don't declare.
13988         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13989         (psymbol_bcache_init, psymbol_bcache_free)
13990         (psymbol_bcache_get_bcache): Don't declare.
13991         * psymtab.c (struct psymbol_bcache): Remove.
13992         (psymtab_storage::psymtab_storage): Update.
13993         (psymtab_storage::~psymtab_storage): Update.
13994         (psymbol_bcache_init, psymbol_bcache_free)
13995         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13996         (add_psymbol_to_bcache): Update.
13997         (allocate_psymtab): Update.
13998         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13999         macro_cache>: No longer pointers.
14000         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14001         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14002         * macrotab.c (macro_bcache): Update.
14003         * macroexp.c: Don't include bcache.h.
14004         * gdbtypes.c (check_types_worklist): Update.
14005         (types_deeply_equal): Remove TRY/CATCH.  Update.
14006         * elfread.c (elf_symtab_read): Update.
14007         * dwarf2read.c: Don't include bcache.h.
14008         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14009         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14010         (print_bcache_statistics, bcache_memory_used): Don't declare.
14011         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14012         methods.  Rename all data members.
14013         * bcache.c (struct bcache): Move to bcache.h.
14014         (bcache::expand_hash_table): Rename from expand_hash_table.
14015         (bcache): Remove.
14016         (bcache::insert): Rename from bcache_full.
14017         (bcache::compare): Rename from bcache_compare.
14018         (bcache_xmalloc): Remove.
14019         (bcache::~bcache): Rename from bcache_xfree.
14020         (bcache::print_statistics): Rename from print_bcache_statistics.
14021         (bcache::memory_used): Rename from bcache_memory_used.
14022
14023 2019-03-07  Pedro Alves  <palves@redhat.com>
14024
14025         * infrun.c (normal_stop): Also check for
14026         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14027
14028 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14029
14030         * f-lang.c (value_from_host_double): Moved to...
14031         * value.c (value_from_host_double): ...here.
14032         * value.h (value_from_host_double): Declare.
14033         * guile/scm-math.c (vlscm_convert_typed_number): Use
14034         value_from_host_double.
14035         (vlscm_convert_number): Likewise.
14036         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14037         * python/py-value.c (convert_value_from_python): Likewise.
14038
14039 2019-03-06  Tom Tromey  <tom@tromey.com>
14040
14041         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14042
14043 2019-03-06  Tom Tromey  <tom@tromey.com>
14044
14045         * utils.h (free_current_contents): Don't declare.
14046         * utils.c (free_current_contents): Remove.
14047
14048 2019-03-06  Tom Tromey  <tom@tromey.com>
14049
14050         * top.c (quit_force): Update.
14051         * main.c (captured_command_loop): Update.
14052         * common/new-op.c (operator new): Update.
14053         * common/common-exceptions.c (struct catcher)
14054         <save_cleanup_chain>: Remove member.
14055         (exceptions_state_mc_init): Update.
14056         (exception_try_scope_entry): Return nullptr.
14057         (exception_try_scope_exit, exception_rethrow)
14058         (throw_exception_sjlj, throw_exception_cxx): Update.
14059         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14060         (all_cleanups, do_cleanups, discard_cleanups)
14061         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14062         (restore_cleanups, restore_final_cleanups): Don't declare.
14063         (do_final_cleanups): Remove parameter.
14064         * common/cleanups.c (cleanup_chain, make_cleanup)
14065         (make_cleanup_dtor, all_cleanups, do_cleanups)
14066         (discard_my_cleanups, discard_cleanups)
14067         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14068         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14069         (null_cleanup): Remove.
14070         (do_final_cleanups): Remove parameter.
14071
14072 2019-03-06  Tom Tromey  <tom@tromey.com>
14073
14074         * remote.c (remote_target::remote_parse_stop_reply): Use
14075         unique_xmalloc_ptr.
14076
14077 2019-03-06  Tom Tromey  <tom@tromey.com>
14078
14079         * stabsread.c (struct stabs_field_info): Rename from field_info.
14080         <list, fnlist>: Add initializers.
14081         <obstack>: New member.
14082         (read_member_functions, read_struct_fields, read_baseclasses):
14083         Allocate on obstack.  Don't use cleanups.
14084         (read_one_struct_field, read_member_functions, read_struct_fields)
14085         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14086         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14087         (read_struct_type): Update.
14088
14089 2019-03-06  Tom Tromey  <tom@tromey.com>
14090
14091         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14092         * common/filestuff.h (make_cleanup_close): Don't declare.
14093         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14094         Remove.
14095
14096 2019-03-06  Tom Tromey  <tom@tromey.com>
14097
14098         * solib-aix.c: Use make_scope_exit.
14099
14100 2019-03-06  Tom Tromey  <tom@tromey.com>
14101
14102         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14103         Use make_scope_exit.
14104
14105 2019-03-06  Tom Tromey  <tom@tromey.com>
14106
14107         * solib-svr4.c (disable_probes_interface): Remove parameter.
14108         (svr4_handle_solib_event): Use make_scope_exit.
14109
14110 2019-03-06  Tom Tromey  <tom@tromey.com>
14111
14112         * remote.c (struct stop_reply_deleter): Remove.
14113         (stop_reply_up): Update.
14114         (struct stop_reply): Derive from notif_event.  Don't typedef.
14115         <regcache>: Now a std::vector.
14116         (stop_reply_xfree): Remove.
14117         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14118         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14119         (remote_target::discard_pending_stop_replies): Use delete.
14120         (remote_target::remote_parse_stop_reply): Update.
14121         (remote_target::process_stop_reply): Update.
14122         * remote-notif.h (struct notif_event): Add virtual destructor.
14123         Remove "dtr" member.
14124         (struct notif_client) <alloc_event>: Return a unique_ptr.
14125         (notif_event_xfree): Don't declare.
14126         (notif_event_up): New typedef.
14127         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14128         (notif_event_xfree, do_notif_event_xfree): Remove.
14129         (remote_notif_state_xfree): Update.
14130
14131 2019-03-06  Tom Tromey  <tom@tromey.com>
14132
14133         * infrun.c (displaced_step_clear_cleanup): Now a
14134         forward_scope_exit type.
14135         (displaced_step_prepare_throw): Update.
14136         (displaced_step_fixup): Update.
14137
14138 2019-03-06  Tom Tromey  <tom@tromey.com>
14139
14140         * inferior.h (class inferior): Update comment.
14141         * gdbthread.h (class thread_info): Update comment.
14142
14143 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14144             Tom Tromey  <tom@tromey.com>
14145
14146         * stabsread.h (struct stab_section_list): Remove.
14147         (coffstab_build_psymtabs): Update.
14148         * dbxread.c (symbuf_sections): Now a std::vector.
14149         (sect_idx): New global.
14150         (fill_symbuf): Update.
14151         (coffstab_build_psymtabs): Change type of stabsects parameter.
14152         Update.
14153         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14154         std::vector.
14155         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14156         (coff_locate_sections): Update.
14157         (coff_symfile_read): Remove cleanups.  Update.
14158         (init_stringtab): Add storage parameter.
14159         (free_stringtab, free_stringtab_cleanup): Remove.
14160         (init_lineno): Add storage parameter.
14161         (free_linetab, free_linetab_cleanup): Remove.
14162
14163 2019-03-06  Pedro Alves  <palves@redhat.com>
14164
14165         * linux-fork.c (fork_info::clobber_regs): Delete.
14166         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14167         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14168         comment.  Adjust.
14169         (scoped_switch_fork_info::scoped_switch_fork_info)
14170         (checkpoint_command, linux_fork_context): Adjust
14171         fork_save_infrun_state calls.
14172
14173 2019-03-06  Pedro Alves  <palves@redhat.com>
14174
14175         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14176         (inf_has_multiple_threads): Return 'bool' and rewrite using
14177         inferior_info::threads().
14178
14179 2019-03-06  Pedro Alves  <palves@redhat.com>
14180
14181         * linux-fork.c: Include <list>.
14182         (fork_list): Now a std::list instance.
14183         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14184         (forks_exist_p, find_last_fork): Adjust.
14185         (new_fork): Delete.
14186         (one_fork_p): New.
14187         (add_fork): Adjust.
14188         (free_fork): Delete, folded into fork_info::~fork_info().
14189         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14190         Adjust.
14191         (init_fork_list): Delete.
14192         (linux_fork_killall, linux_fork_mourn_inferior)
14193         (linux_fork_detach, info_checkpoints_command): Adjust.
14194         (_initialize_linux_fork): No longer call init_fork_list.
14195
14196 2019-03-06  Pedro Alves  <palves@redhat.com>
14197
14198         * linux-fork.c (new_fork): New, split out of ...
14199         (add_fork): ... this.  Return void.  Move "first fork" special
14200         case from here, to ...
14201         (checkpoint_command): ... here.
14202         * linux-linux.h (add_fork): Return void.
14203
14204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14205
14206         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14207
14208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14209             Chris January  <chris.january@arm.com>
14210             David Lecomber  <david.lecomber@arm.com>
14211
14212         * f-exp.y: New token, UNOP_INTRINSIC.
14213         (exp): New pattern using UNOP_INTRINSIC token.
14214         (f77_keywords): Add 'abs' keyword.
14215         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14216         (value_from_host_double): New function.
14217         (evaluate_subexp_f): Support UNOP_ABS.
14218
14219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14220
14221         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14222         types.
14223
14224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14225
14226         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14227         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14228         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14229
14230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14231
14232         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14233
14234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14235             Chris January  <chris.january@arm.com>
14236
14237         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14238         * f-exp.y: Define 'KIND' token.
14239         (exp): New pattern for KIND expressions.
14240         (ptype): Handle types with a kind extension.
14241         (direct_abs_decl): Extend to spot kind extensions.
14242         (f77_keywords): Add 'kind' to the list.
14243         (push_kind_type): New function.
14244         (convert_to_kind_type): New function.
14245         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14246         * parse.c (operator_length_standard): Likewise.
14247         * parser-defs.h (enum type_pieces): Add tp_kind.
14248         * std-operator.def: Add UNOP_KIND.
14249
14250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14251
14252         * f-exp.y (f_parse): Set yydebug.
14253
14254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14255
14256         * f-lang.c (evaluate_subexp_f): New function.
14257         (exp_descriptor_f): New global.
14258         (f_language_defn): Use exp_descriptor_f instead of
14259         exp_descriptor_standard.
14260
14261 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14262
14263         * f-exp.y (struct token): Add comments.
14264         (dot_ops): Remove uppercase versions and the end marker.
14265         (f77_keywords): Likewise.
14266         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14267         entries in the dot_ops array are case insensitive, and use
14268         strncasecmp to compare strings.  Also some whitespace cleanup in
14269         this area.  Similar for the f77_keywords array, except entries in
14270         this list might be case sensitive.
14271
14272 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14273
14274         * f-exp.y (struct f77_boolean_val): Add comments.
14275         (boolean_values): Remove uppercase versions, and end marker.
14276         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14277         and use strncasecmp to achieve case insensitivity.  Additionally,
14278         perform whitespace cleanup around this code.
14279
14280 2019-03-06  Tom Tromey  <tromey@adacore.com>
14281
14282         * remote-sim.c (gdbsim_target_open): Use result of
14283         gdb_argv::release.
14284
14285 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14286         Dirk Schubert  <dirk.schubert@arm.com>
14287         Chris January  <chris.january@arm.com>
14288
14289         * eval.c (evaluate_subexp_standard): Call Fortran argument
14290         wrapping logic.
14291         * f-lang.c (struct value): A value which can be passed into a
14292         Fortran function call.
14293         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14294         where appropriate.
14295         (struct type): Value ready for a Fortran function call.
14296         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14297         is needed.
14298         * f-lang.h (fortran_argument_convert): Declaration.
14299         (fortran_preserve_arg_pointer): Declaration.
14300         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14301
14302 2019-03-05  Tom Tromey  <tromey@adacore.com>
14303
14304         * python/py-prettyprint.c (print_string_repr): Remove #if.
14305         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14306
14307 2019-03-05  Tom Tromey  <tromey@adacore.com>
14308
14309         * target.c (the_dummy_target): Move later.  Change type to
14310         "dummy_target".
14311         (initialize_targets): Don't initialize the_dummy_target.
14312
14313 2019-03-05  Tom Tromey  <tromey@adacore.com>
14314
14315         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14316         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14317
14318 2019-03-05  Tom Tromey  <tromey@adacore.com>
14319
14320         * windows-nat.c (windows_nat_target::attach)
14321         (windows_nat_target::detach): Don't call gdb_flush.
14322         * valprint.c (generic_val_print, val_print, val_print_string):
14323         Don't call gdb_flush.
14324         * utils.c (defaulted_query): Don't call gdb_flush.
14325         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14326         * target.c (target_announce_detach): Don't call gdb_flush.
14327         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14328         * remote.c (extended_remote_target::attach): Don't call
14329         gdb_flush.
14330         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14331         * printcmd.c (do_examine): Don't call gdb_flush.
14332         (info_display_command): Don't call gdb_flush.
14333         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14334         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14335         * memattr.c (info_mem_command): Don't call gdb_flush.
14336         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14337         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14338         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14339         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14340         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14341         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14342         (gnu_nat_target::detach): Don't call gdb_flush.
14343         * f-valprint.c (f_val_print): Don't call gdb_flush.
14344         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14345         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14346         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14347         gdb_flush.
14348         * c-valprint.c (c_val_print): Don't call gdb_flush.
14349         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14350
14351 2019-03-05  Tom Tromey  <tromey@adacore.com>
14352
14353         * varobj.c (update_dynamic_varobj_children): Update.
14354         (install_default_visualizer): Use reset, not release.
14355         * value.c (set_internalvar): Update.
14356         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14357         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14358         ATTRIBUTE_UNUSED_RESULT.
14359
14360 2019-03-05  Tom Tromey  <tromey@adacore.com>
14361
14362         * remote.c (class scoped_remote_fd) <release>: Add
14363         ATTRIBUTE_UNUSED_RESULT.
14364
14365 2019-03-05  Tom Tromey  <tromey@adacore.com>
14366
14367         * macroexp.c (struct macro_buffer) <release>: Add
14368         ATTRIBUTE_UNUSED_RESULT.
14369
14370 2019-03-05  Tom Tromey  <tromey@adacore.com>
14371
14372         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14373         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14374         ATTRIBUTE_UNUSED_RESULT.
14375
14376 2019-03-05  Tom Tromey  <tromey@adacore.com>
14377
14378         * common/scoped_fd.h (class scoped_fd) <release>: Add
14379         ATTRIBUTE_UNUSED_RESULT.
14380
14381 2019-03-05  Tom Tromey  <tromey@adacore.com>
14382
14383         * parser-defs.h (struct parser_state) <release>: Add
14384         ATTRIBUTE_UNUSED_RESULT.
14385
14386 2019-03-05  Tom Tromey  <tromey@adacore.com>
14387
14388         * utils.h (class gdb_argv) <release>: Add
14389         ATTRIBUTE_UNUSED_RESULT.
14390         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14391
14392 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14393
14394         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14395         for-loop range, to avoid compiler warnings.
14396
14397         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14398         avoid compiler warnings about unused variables.
14399
14400         * NEWS: Mention end of support for native debugging on MS-Windows
14401         before XP.
14402
14403         PR gdb/24292
14404         * common/netstuff.c:
14405         * gdbserver/gdbreplay.c
14406         * gdbserver/remote-utils.c:
14407         * ser-tcp.c:
14408         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14409         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14410         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14411         'getaddrinfo' and 'freeaddrinfo' were not available before
14412         Windows XP, and mingw.org's MinGW headers by default define
14413         _WIN32_WINNT to 0x500.
14414
14415 2019-03-01  Gary Benson <gbenson@redhat.com>
14416
14417         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14418
14419 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14420             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14421
14422         PR gdb/8527
14423         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14424         set_sigint_trap, clear_sigint_trap.
14425
14426 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14427
14428         * target.c (target_detach): Clear the regcache and the
14429         frame cache.
14430
14431 2019-02-27  Pedro Alves  <palves@redhat.com>
14432
14433         * utils.c (set_screen_size): When we cap the height/width sizes,
14434         tweak the corresponding command variable to show "unlimited":
14435
14436 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14437             Pedro Alves  <palves@redhat.com>
14438
14439         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14440         before calling rl_set_screen_size.
14441
14442 2019-02-27  Tom Tromey  <tromey@adacore.com>
14443
14444         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14445         define.
14446         * python/py-value.c: Remove Python 2.4 workaround.
14447         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14448         workaround.
14449         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14450         Python 2.4 workaround.
14451         * python/python-internal.h: Remove Python 2.4 comment.
14452         (Py_ssize_t): Don't define.
14453         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14454         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14455         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14456         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14457         * python/python.c (do_start_initialization): Remove Python 2.4
14458         workaround.
14459         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14460         (print_children): Remove Python 2.4 workaround.
14461         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14462         workaround.
14463         (CHARBUFFERPROC_NAME): Remove.
14464         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14465         Python 2.4 workaround.
14466
14467 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14468
14469         * NEWS: Note minimum Python version.
14470
14471 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14472
14473         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14474         code from these functions.  Remove corresponding ifdefs.  Use
14475         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14476         Remove gotos and target of gotos.
14477         (infpy_search_memory): Likewise.
14478
14479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14480
14481         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14482         (hppa_gdbarch_init): Don't register deleted functions with
14483         gdbarch.
14484
14485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14486
14487         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14488         (h8300_unwind_sp): Delete.
14489         (h8300_dummy_id): Delete.
14490         (h8300_gdbarch_init): Don't register deleted functions with
14491         gdbarch.
14492
14493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14494
14495         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14496         (ft32_unwind_pc): Delete.
14497         (ft32_unwind_sp): Delete.
14498         (ft32_gdbarch_init): Don't register deleted functions with
14499         gdbarch.
14500
14501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14502
14503         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14504         (frv_unwind_pc): Delete.
14505         (frv_unwind_sp): Delete.
14506         (frv_gdbarch_init): Don't register deleted functions with
14507         gdbarch.
14508
14509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14510
14511         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14512         (riscv_unwind_pc): Delete.
14513         (riscv_unwind_sp): Delete.
14514         (riscv_gdbarch_init): Don't register deleted functions with
14515         gdbarch.
14516
14517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14518
14519         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14520         (csky_unwind_pc): Delete.
14521         (csky_unwind_sp): Delete.
14522         (csky_gdbarch_init): Don't register deleted functions with
14523         gdbarch.
14524
14525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14526
14527         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14528         (cris_unwind_pc): Delete.
14529         (cris_unwind_sp): Delete.
14530         (cris_gdbarch_init): Don't register deleted functions with
14531         gdbarch.
14532
14533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14534
14535         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14536         (bfin_unwind_pc): Delete.
14537         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14538
14539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14540
14541         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14542         (arm_unwind_pc): Delete.
14543         (arm_unwind_sp): Delete.
14544         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14545
14546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14547
14548         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14549         (arc_unwind_pc): Delete.
14550         (arc_unwind_sp): Delete.
14551         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14552
14553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14554
14555         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14556         (alpha_unwind_pc): Delete.
14557         (alpha_gdbarch_init): Don't register deleted functions with
14558         gdbarch.
14559
14560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14561
14562         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14563         (aarch64_unwind_pc): Delete.
14564         (aarch64_unwind_sp): Delete.
14565         (aarch64_gdbarch_init): Don't register deleted functions with
14566         gdbarch.
14567
14568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14569
14570         * gdbtypes.c (type_align): Don't consider static members when
14571         computing structure alignment.
14572
14573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14574
14575         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14576         return 0 for other types.
14577         * arch-utils.c (default_type_align): Always return 0.
14578         * gdbarch.h: Regenerate.
14579         * gdbarch.sh (type_align): Extend comment.
14580         * gdbtypes.c (type_align): Add additional comments, always call
14581         gdbarch_type_align before applying the default rules.
14582         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14583         generic code will then apply a suitable default.
14584         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14585         types, return 0 for other types.
14586
14587 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14588
14589         * NEWS: Create a new section for the next release branch.
14590         Rename the section of the current branch, now that it has
14591         been cut.
14592
14593 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14594
14595         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14596         * version.in: Bump version to 8.3.50.DATE-git.
14597
14598 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14599
14600         * aix-thread.c (ptid_cmp): Remove unused variable.
14601         (get_signaled_thread): Likewise.
14602         (store_regs_user_thread): Likewise.
14603         (store_regs_kernel_thread): Likewise.
14604         (fetch_regs_kernel_thread): Remove shadowed variable.
14605
14606 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14607
14608         * features/riscv/32bit-cpu.xml: Add register numbers.
14609         * features/riscv/32bit-fpu.c: Regenerate.
14610         * features/riscv/32bit-fpu.xml: Add register numbers.
14611         * features/riscv/64bit-cpu.xml: Add register numbers.
14612         * features/riscv/64bit-fpu.c: Regenerate.
14613         * features/riscv/64bit-fpu.xml: Add register numbers.
14614
14615 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14616
14617         * NEWS: Mention two argument form of gdb.Value constructor.
14618         * python/py-value.c (convert_buffer_and_type_to_value): New
14619         function.
14620         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14621         Add support for handling an optional second argument.  Call
14622         convert_buffer_and_type_to_value as appropriate.
14623         * python/python-internal.h (Py_buffer_deleter): New struct.
14624         (Py_buffer_up): New typedef.
14625
14626 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14627
14628         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14629         instead of releasing ownership.
14630
14631 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14632
14633         * dwarf2read.c (open_and_init_dwp_file): Call
14634         elf_numsections instead of bfd_count_sections to initialize
14635         dwp_file->num_sections.
14636
14637 2019-02-25  Tom Tromey  <tromey@adacore.com>
14638
14639         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14640
14641 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14642
14643         * gcore.in: Add '--readnever' option when invoking GDB.
14644
14645 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14646
14647         * MAINTAINERS: Update my email address.
14648
14649 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14650
14651         * build-id.c (build_id_to_debug_bfd_1): New function.
14652         (build_id_to_debug_bfd): Look for separate debug file in
14653         sysroot.
14654
14655 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14656
14657         * gdbarch.sh: Update the copyright year range that is placed into
14658         generated files.
14659
14660 2019-02-22  Keith Seitz  <keiths@redhat.com>
14661
14662         PR symtab/23853
14663         * linespec.c (create_sals_line_offset): Search for the default
14664         symtab's filename instead of its fullname.
14665
14666 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14667
14668         * NEWS: Update style defaults.
14669
14670 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14671
14672         * main.c (captured_main_1): Disable styling in batch mode.
14673
14674 2019-02-20  Tom Tromey  <tom@tromey.com>
14675
14676         * symtab.c (symtab_symbol_info): Fix typos.
14677
14678 2019-02-20  Tom Tromey  <tromey@adacore.com>
14679
14680         * findcmd.c (_initialize_mem_search): Use upper case for
14681         metasyntactic variables.
14682
14683 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14684
14685         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14686         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14687
14688 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14689
14690         * top.h (source_file_name): Change to std::string.
14691         * top.c (source_file_name): Likewise.
14692         (command_line_input): Adjust.
14693         * cli/cli-script.c (script_from_file): Adjust.
14694
14695 2019-02-19  Tom Tromey  <tromey@adacore.com>
14696
14697         * ravenscar-thread.c
14698         (ravenscar_thread_target::update_thread_list): Don't call
14699         ada_build_task_list.
14700         * ada-lang.h (ada_build_task_list): Don't declare.
14701         * ada-tasks.c (struct ada_tasks_inferior_data)
14702         <task_list_valid_p>: Now bool.
14703         (read_known_tasks, ada_task_list_changed)
14704         (ada_tasks_invalidate_inferior_data): Update.
14705         (read_known_tasks_array): Return bool.
14706         (read_known_tasks_list): Likewise.
14707         (read_known_tasks): Return void.
14708         (ada_build_task_list): Now static.
14709
14710 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14711
14712         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14713         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14714
14715 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14716
14717         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14718         variant for ada_tasks_pspace_data_handle and
14719         ada_tasks_inferior_data_handle.
14720         (ada_tasks_pspace_data_cleanup): New function.
14721         (ada_tasks_inferior_data_cleanup): New function.
14722
14723 2019-02-17  Tom Tromey  <tom@tromey.com>
14724
14725         * macrotab.h (macro_source_fullname): Return a std::string.
14726         * macrotab.c (macro_include, check_for_redefinition)
14727         (macro_undef, macro_lookup_definition, foreach_macro)
14728         (foreach_macro_in_scope): Update.
14729         (macro_source_fullname): Return a std::string.
14730         * macrocmd.c (show_pp_source_pos): Update.
14731
14732 2019-02-17  Tom Tromey  <tom@tromey.com>
14733
14734         * macrocmd.c (show_pp_source_pos): Style the file names.
14735
14736 2019-02-17  Tom Tromey  <tom@tromey.com>
14737
14738         PR tui/24197:
14739         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14740
14741 2019-02-17  Tom Tromey  <tom@tromey.com>
14742
14743         * ada-lang.c (user_select_syms): Use filtered printing.
14744         * utils.c (wrap_style): New global.
14745         (desired_style): Remove.
14746         (emit_style_escape): Add stream parameter.
14747         (set_output_style, reset_terminal_style, prompt_for_continue):
14748         Update.
14749         (flush_wrap_buffer): Only flush gdb_stdout.
14750         (wrap_here): Set wrap_style.
14751         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14752         treat escape sequences as a character.  Change when wrap buffer is
14753         flushed.
14754         (fputs_styled): Do not set the output style when the default is
14755         requested.
14756         * ui-style.h (struct ui_file_style) <is_default>: New method.
14757         * source.c (print_source_lines_base): Emit escape sequences in one
14758         piece.
14759
14760 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14761
14762         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14763         integers and enumeration types.
14764
14765 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14766
14767         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14768         instead of lookup_symbol_in_language
14769         (do_exact_match): New function.
14770         (ada_get_symbol_name_matcher): Return do_exact_match when
14771         doing a verbatim match.
14772
14773 2019-02-15  Tom Tromey  <tromey@adacore.com>
14774
14775         * ravenscar-thread.c (ravenscar_thread_target::resume)
14776         (ravenscar_thread_target::wait): Special case wildcard requests.
14777
14778 2019-02-15  Tom Tromey  <tromey@adacore.com>
14779
14780         * ravenscar-thread.c (base_ptid): Remove.
14781         (struct ravenscar_thread_target) <close>: New method.
14782         <m_base_ptid>: New member.
14783         <update_inferior_ptid, active_task, task_is_currently_active,
14784         runtime_initialized>: Declare methods.
14785         <ravenscar_thread_target>: Add constructor.
14786         (ravenscar_thread_target::task_is_currently_active)
14787         (ravenscar_thread_target::update_inferior_ptid)
14788         (ravenscar_runtime_initialized): Rename.  Now methods.
14789         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14790         (ravenscar_thread_target::update_thread_list): Update.
14791         (ravenscar_thread_target::active_task): Now method.
14792         (ravenscar_thread_target::store_registers)
14793         (ravenscar_thread_target::prepare_to_store)
14794         (ravenscar_thread_target::prepare_to_store)
14795         (ravenscar_thread_target::mourn_inferior): Update.
14796         (ravenscar_inferior_created): Use "new" to create target.
14797         (ravenscar_thread_target::get_ada_task_ptid): Update.
14798         (_initialize_ravenscar): Don't initialize base_ptid.
14799         (ravenscar_ops): Remove global.
14800
14801 2019-02-15  Tom Tromey  <tromey@adacore.com>
14802
14803         * target.h (push_target): Declare new overload.
14804         * target.c (push_target): New overload, taking an rvalue reference.
14805         * remote.c (remote_target::open_1): Use push_target overload.
14806         * corelow.c (core_target_open): Use push_target overload.
14807
14808 2019-02-15  Tom Tromey  <tromey@adacore.com>
14809
14810         * ravenscar-thread.c (is_ravenscar_task)
14811         (ravenscar_task_is_currently_active): Return bool.
14812         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14813         (_initialize_ravenscar): Remove "(void)".
14814         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14815         Return bool.
14816
14817 2019-02-15  Tom Tromey  <tromey@adacore.com>
14818
14819         * ravenscar-thread.c (ravenscar_runtime_initializer)
14820         (has_ravenscar_runtime, get_running_thread_id)
14821         (ravenscar_thread_target::resume): Fix indentation.
14822
14823 2019-02-15  Tom Tromey  <tromey@adacore.com>
14824
14825         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14826         from ravenscar_arch_ops.
14827         (sparc_ravenscar_ops::fetch_registers)
14828         (sparc_ravenscar_ops::store_registers): Now methods.
14829         (sparc_ravenscar_prepare_to_store): Remove.
14830         (sparc_ravenscar_ops): Redefine.
14831         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14832         methods and destructor.  Remove members.
14833         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14834         (ravenscar_thread_target::store_registers)
14835         (ravenscar_thread_target::prepare_to_store): Update.
14836         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14837         Remove.
14838         (struct ppc_ravenscar_powerpc_ops): Derive from
14839         ravenscar_arch_ops.
14840         (ppc_ravenscar_powerpc_ops::fetch_registers)
14841         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14842         (ppc_ravenscar_powerpc_ops): Redefine.
14843         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14844         (ppc_ravenscar_e500_ops::fetch_registers)
14845         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14846         (ppc_ravenscar_e500_ops): Redefine.
14847         * aarch64-ravenscar-thread.c
14848         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14849         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14850         (aarch64_ravenscar_fetch_registers)
14851         (aarch64_ravenscar_store_registers): Now methods.
14852         (aarch64_ravenscar_ops): Redefine.
14853
14854 2019-02-15  Tom Tromey  <tromey@adacore.com>
14855
14856         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14857         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14858         (ravenscar_thread_target::stopped_by_watchpoint)
14859         (ravenscar_thread_target::stopped_data_address)
14860         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14861
14862 2019-02-15  Tom Tromey  <tromey@adacore.com>
14863
14864         * ravenscar-thread.c: Fix some typos.
14865
14866 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14867             Tom Tromey  <tromey@adacore.com>
14868
14869         * ada-lang.c (ada_exception_sal): Change addr_string to a
14870         std::string.
14871         (create_ada_exception_catchpoint): Update.
14872
14873 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14874             Tom Tromey  <tromey@adacore.com>
14875
14876         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14877         (bp_location_ops): Remove.
14878         (base_breakpoint_allocate_location): Update.
14879         (free_bp_location): Update.
14880         * ada-lang.c (class ada_catchpoint_location)
14881         <ada_catchpoint_location>: Remove ops parameter.
14882         (ada_catchpoint_location_dtor): Remove.
14883         (ada_catchpoint_location_ops): Remove.
14884         (allocate_location_exception): Update.
14885         * breakpoint.h (struct bp_location_ops): Remove.
14886         (class bp_location) <bp_location>: Remove bp_location_ops
14887         parameter.
14888         <~bp_location>: Add destructor.
14889         <ops>: Remove.
14890
14891 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14892             Pedro Alves  <palves@redhat.com>
14893
14894         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14895         'PATH_MAX'.
14896
14897 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14898             Samuel Thibault  <samuel.thibault@gnu.org>
14899             Thomas Schwinge  <thomas@codesourcery.com>
14900
14901         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14902         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14903
14904 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14905
14906         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14907         (check_empty): Use "const char *".
14908
14909         * gnu-nat.c (gnu_nat_target::detach): Instead of
14910         'detach_inferior (pid)' call
14911         'detach_inferior (find_inferior_pid (pid))'.
14912
14913         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14914         'nat/fork-inferior.o'.
14915         * gnu-nat.c: #include "nat/fork-inferior.h".
14916
14917         * gnu-nat.c (gnu_nat_target::detach): Instead of
14918         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14919         * gnu-nat.h: #include "inf-child.h".
14920         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14921         'i386_gnu_nat_target::fetch_registers'.
14922         (gnu_store_registers): Rename/move to
14923         'i386_gnu_nat_target::store_registers'.
14924
14925         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14926         * gnu-nat.h (mach_thread_info): New function.
14927         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14928
14929         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14930
14931 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14932
14933         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14934
14935 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14936
14937         * windows-nat.c (windows_add_thread): Add new parameter
14938         "main_thread_p" with default value set to false.  Update
14939         function documentation as well as all callers.
14940         (windows_delete_thread): Likewise.
14941         (fake_create_process): Update call to windows_add_thread.
14942         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14943         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14944         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14945         call to windows_delete_thread.
14946
14947 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14948
14949         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14950
14951 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14952
14953         * symfile.c (find_separate_debug_file): Use canonical path of
14954         sysroot with child_path instead of gdb_sysroot if it is valid.
14955
14956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14957
14958         * symfile.c (find_separate_debug_file): Use child_path to
14959         determine if an object file is under a sysroot.
14960
14961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14962
14963         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14964         unittests/child-path-selftests.c.
14965         * common/pathstuff.c (child_path): New function.
14966         * common/pathstuff.h (child_path): New prototype.
14967         * unittests/child-path-selftests.c: New file.
14968
14969 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14970
14971         * symfile.c (find_separate_debug_file): Look for separate debug
14972         files in debug directories under the sysroot.
14973
14974 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14975
14976         * symtab.h (struct minimal_symbol data_p): New const method.
14977         (struct minimal_symbol text_p): Likewise.
14978         * symtab.c (output_source_filename): Use file name style
14979         to print file name.
14980         (print_symbol_info): Likewise.
14981         (print_msymbol_info): Use address style to print addresses.
14982         Use function name style to print executable text symbols.
14983         (expand_symtab_containing_pc): Use data_p.
14984         (find_pc_sect_compunit_symtab): Likewise.
14985
14986 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14987
14988         * breakpoint.c (describe_other_breakpoints): Use address style
14989         to print addresses.
14990         (say_where): Likewise.
14991
14992 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14993
14994         * ada-typeprint.c (print_func_type): Print function name
14995         style to print function name.
14996         * c-typeprint.c (c_print_type_1): Likewise.
14997
14998 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14999
15000         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15001         for execve.
15002
15003 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15004
15005         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15006         type_stack.
15007
15008 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15009
15010         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15011         TYPE_CODE_REF types.
15012
15013 2019-02-08  Jim Wilson  <jimw@sifive.com>
15014
15015         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15016         (riscv_linux_fregset): New.
15017         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15018
15019 2019-02-07  Tom Tromey  <tom@tromey.com>
15020
15021         * thread.c (thread_cancel_execution_command): Update.
15022         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15023         methods.
15024         (struct thread_fsm_ops): Remove.
15025         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15026         (thread_fsm_should_stop, thread_fsm_return_value)
15027         (thread_fsm_set_finished, thread_fsm_finished_p)
15028         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15029         Don't declare.
15030         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15031         * infrun.c (clear_proceed_status_thread)
15032         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15033         (print_stop_event): Update.
15034         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15035         Add constructor.
15036         (step_command_fsm_ops): Remove.
15037         (new_step_command_fsm): Remove.
15038         (step_1): Update.
15039         (step_command_fsm::should_stop): Rename from
15040         step_command_fsm_should_stop.
15041         (step_command_fsm::clean_up): Rename from
15042         step_command_fsm_clean_up.
15043         (step_command_fsm::do_async_reply_reason): Rename from
15044         step_command_fsm_async_reply_reason.
15045         (struct until_next_fsm): Inherit from thread_fsm.  Add
15046         constructor.
15047         (until_next_fsm_ops): Remove.
15048         (new_until_next_fsm): Remove.
15049         (until_next_fsm::should_stop): Rename from
15050         until_next_fsm_should_stop.
15051         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15052         (until_next_fsm::do_async_reply_reason): Rename from
15053         until_next_fsm_async_reply_reason.
15054         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15055         constructor.  Change type of breakpoint.
15056         (finish_command_fsm_ops): Remove.
15057         (new_finish_command_fsm): Remove.
15058         (finish_command_fsm::should_stop): Rename from
15059         finish_command_fsm_should_stop.
15060         (finish_command_fsm::clean_up): Rename from
15061         finish_command_fsm_clean_up.
15062         (finish_command_fsm::return_value): Rename from
15063         finish_command_fsm_return_value.
15064         (finish_command_fsm::do_async_reply_reason): Rename from
15065         finish_command_fsm_async_reply_reason.
15066         (finish_command): Update.
15067         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15068         Add constructor.
15069         (call_thread_fsm_ops): Remove.
15070         (call_thread_fsm::call_thread_fsm): Rename from
15071         new_call_thread_fsm.
15072         (call_thread_fsm::should_stop): Rename from
15073         call_thread_fsm_should_stop.
15074         (call_thread_fsm::should_notify_stop): Rename from
15075         call_thread_fsm_should_notify_stop.
15076         (run_inferior_call, call_function_by_hand_dummy): Update.
15077         * cli/cli-interp.c (should_print_stop_to_console): Update.
15078         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15079         Add constructor.  Change type of location_breakpoint,
15080         caller_breakpoint.
15081         (until_break_fsm_ops): Remove.
15082         (new_until_break_fsm): Remove.
15083         (until_break_fsm::should_stop): Rename from
15084         until_break_fsm_should_stop.
15085         (until_break_fsm::clean_up): Rename from
15086         until_break_fsm_clean_up.
15087         (until_break_fsm::do_async_reply_reason): Rename from
15088         until_break_fsm_async_reply_reason.
15089         (until_break_command): Update.
15090         * thread-fsm.c: Remove.
15091         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15092
15093 2019-02-07  Tom Tromey  <tom@tromey.com>
15094
15095         * yy-remap.h: Add include guard.
15096         * xtensa-tdep.h: Add include guard.
15097         * xcoffread.h: Rename include guard.
15098         * varobj-iter.h: Add include guard.
15099         * tui/tui.h: Rename include guard.
15100         * tui/tui-winsource.h: Rename include guard.
15101         * tui/tui-wingeneral.h: Rename include guard.
15102         * tui/tui-windata.h: Rename include guard.
15103         * tui/tui-win.h: Rename include guard.
15104         * tui/tui-stack.h: Rename include guard.
15105         * tui/tui-source.h: Rename include guard.
15106         * tui/tui-regs.h: Rename include guard.
15107         * tui/tui-out.h: Rename include guard.
15108         * tui/tui-layout.h: Rename include guard.
15109         * tui/tui-io.h: Rename include guard.
15110         * tui/tui-hooks.h: Rename include guard.
15111         * tui/tui-file.h: Rename include guard.
15112         * tui/tui-disasm.h: Rename include guard.
15113         * tui/tui-data.h: Rename include guard.
15114         * tui/tui-command.h: Rename include guard.
15115         * tic6x-tdep.h: Add include guard.
15116         * target/waitstatus.h: Rename include guard.
15117         * target/wait.h: Rename include guard.
15118         * target/target.h: Rename include guard.
15119         * target/resume.h: Rename include guard.
15120         * target-float.h: Rename include guard.
15121         * stabsread.h: Add include guard.
15122         * rs6000-tdep.h: Add include guard.
15123         * riscv-fbsd-tdep.h: Add include guard.
15124         * regformats/regdef.h: Rename include guard.
15125         * record.h: Rename include guard.
15126         * python/python.h: Rename include guard.
15127         * python/python-internal.h: Rename include guard.
15128         * python/py-stopevent.h: Rename include guard.
15129         * python/py-ref.h: Rename include guard.
15130         * python/py-record.h: Rename include guard.
15131         * python/py-record-full.h: Rename include guard.
15132         * python/py-record-btrace.h: Rename include guard.
15133         * python/py-instruction.h: Rename include guard.
15134         * python/py-events.h: Rename include guard.
15135         * python/py-event.h: Rename include guard.
15136         * procfs.h: Add include guard.
15137         * proc-utils.h: Add include guard.
15138         * p-lang.h: Add include guard.
15139         * or1k-tdep.h: Rename include guard.
15140         * observable.h: Rename include guard.
15141         * nto-tdep.h: Rename include guard.
15142         * nat/x86-linux.h: Rename include guard.
15143         * nat/x86-linux-dregs.h: Rename include guard.
15144         * nat/x86-gcc-cpuid.h: Add include guard.
15145         * nat/x86-dregs.h: Rename include guard.
15146         * nat/x86-cpuid.h: Rename include guard.
15147         * nat/ppc-linux.h: Rename include guard.
15148         * nat/mips-linux-watch.h: Rename include guard.
15149         * nat/linux-waitpid.h: Rename include guard.
15150         * nat/linux-ptrace.h: Rename include guard.
15151         * nat/linux-procfs.h: Rename include guard.
15152         * nat/linux-osdata.h: Rename include guard.
15153         * nat/linux-nat.h: Rename include guard.
15154         * nat/linux-namespaces.h: Rename include guard.
15155         * nat/linux-btrace.h: Rename include guard.
15156         * nat/glibc_thread_db.h: Rename include guard.
15157         * nat/gdb_thread_db.h: Rename include guard.
15158         * nat/gdb_ptrace.h: Rename include guard.
15159         * nat/fork-inferior.h: Rename include guard.
15160         * nat/amd64-linux-siginfo.h: Rename include guard.
15161         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15162         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15163         * nat/aarch64-linux.h: Rename include guard.
15164         * nat/aarch64-linux-hw-point.h: Rename include guard.
15165         * mn10300-tdep.h: Add include guard.
15166         * mips-linux-tdep.h: Add include guard.
15167         * mi/mi-parse.h: Rename include guard.
15168         * mi/mi-out.h: Rename include guard.
15169         * mi/mi-main.h: Rename include guard.
15170         * mi/mi-interp.h: Rename include guard.
15171         * mi/mi-getopt.h: Rename include guard.
15172         * mi/mi-console.h: Rename include guard.
15173         * mi/mi-common.h: Rename include guard.
15174         * mi/mi-cmds.h: Rename include guard.
15175         * mi/mi-cmd-break.h: Rename include guard.
15176         * m2-lang.h: Add include guard.
15177         * location.h: Rename include guard.
15178         * linux-record.h: Rename include guard.
15179         * linux-nat.h: Add include guard.
15180         * linux-fork.h: Add include guard.
15181         * i386-darwin-tdep.h: Rename include guard.
15182         * hppa-linux-offsets.h: Add include guard.
15183         * guile/guile.h: Rename include guard.
15184         * guile/guile-internal.h: Rename include guard.
15185         * gnu-nat.h: Rename include guard.
15186         * gdb-stabs.h: Rename include guard.
15187         * frv-tdep.h: Add include guard.
15188         * f-lang.h: Add include guard.
15189         * event-loop.h: Add include guard.
15190         * darwin-nat.h: Rename include guard.
15191         * cp-abi.h: Rename include guard.
15192         * config/sparc/nm-sol2.h: Rename include guard.
15193         * config/nm-nto.h: Rename include guard.
15194         * config/nm-linux.h: Add include guard.
15195         * config/i386/nm-i386gnu.h: Rename include guard.
15196         * config/djgpp/nl_types.h: Rename include guard.
15197         * config/djgpp/langinfo.h: Rename include guard.
15198         * compile/gcc-cp-plugin.h: Add include guard.
15199         * compile/gcc-c-plugin.h: Add include guard.
15200         * compile/compile.h: Rename include guard.
15201         * compile/compile-object-run.h: Rename include guard.
15202         * compile/compile-object-load.h: Rename include guard.
15203         * compile/compile-internal.h: Rename include guard.
15204         * compile/compile-cplus.h: Rename include guard.
15205         * compile/compile-c.h: Rename include guard.
15206         * common/xml-utils.h: Rename include guard.
15207         * common/x86-xstate.h: Rename include guard.
15208         * common/version.h: Rename include guard.
15209         * common/vec.h: Rename include guard.
15210         * common/tdesc.h: Rename include guard.
15211         * common/selftest.h: Rename include guard.
15212         * common/scoped_restore.h: Rename include guard.
15213         * common/scoped_mmap.h: Rename include guard.
15214         * common/scoped_fd.h: Rename include guard.
15215         * common/safe-iterator.h: Rename include guard.
15216         * common/run-time-clock.h: Rename include guard.
15217         * common/refcounted-object.h: Rename include guard.
15218         * common/queue.h: Rename include guard.
15219         * common/ptid.h: Rename include guard.
15220         * common/print-utils.h: Rename include guard.
15221         * common/preprocessor.h: Rename include guard.
15222         * common/pathstuff.h: Rename include guard.
15223         * common/observable.h: Rename include guard.
15224         * common/netstuff.h: Rename include guard.
15225         * common/job-control.h: Rename include guard.
15226         * common/host-defs.h: Rename include guard.
15227         * common/gdb_wait.h: Rename include guard.
15228         * common/gdb_vecs.h: Rename include guard.
15229         * common/gdb_unlinker.h: Rename include guard.
15230         * common/gdb_unique_ptr.h: Rename include guard.
15231         * common/gdb_tilde_expand.h: Rename include guard.
15232         * common/gdb_sys_time.h: Rename include guard.
15233         * common/gdb_string_view.h: Rename include guard.
15234         * common/gdb_splay_tree.h: Rename include guard.
15235         * common/gdb_setjmp.h: Rename include guard.
15236         * common/gdb_ref_ptr.h: Rename include guard.
15237         * common/gdb_optional.h: Rename include guard.
15238         * common/gdb_locale.h: Rename include guard.
15239         * common/gdb_assert.h: Rename include guard.
15240         * common/filtered-iterator.h: Rename include guard.
15241         * common/filestuff.h: Rename include guard.
15242         * common/fileio.h: Rename include guard.
15243         * common/environ.h: Rename include guard.
15244         * common/common-utils.h: Rename include guard.
15245         * common/common-types.h: Rename include guard.
15246         * common/common-regcache.h: Rename include guard.
15247         * common/common-inferior.h: Rename include guard.
15248         * common/common-gdbthread.h: Rename include guard.
15249         * common/common-exceptions.h: Rename include guard.
15250         * common/common-defs.h: Rename include guard.
15251         * common/common-debug.h: Rename include guard.
15252         * common/cleanups.h: Rename include guard.
15253         * common/buffer.h: Rename include guard.
15254         * common/btrace-common.h: Rename include guard.
15255         * common/break-common.h: Rename include guard.
15256         * cli/cli-utils.h: Rename include guard.
15257         * cli/cli-style.h: Rename include guard.
15258         * cli/cli-setshow.h: Rename include guard.
15259         * cli/cli-script.h: Rename include guard.
15260         * cli/cli-interp.h: Rename include guard.
15261         * cli/cli-decode.h: Rename include guard.
15262         * cli/cli-cmds.h: Rename include guard.
15263         * charset-list.h: Add include guard.
15264         * buildsym-legacy.h: Rename include guard.
15265         * bfin-tdep.h: Add include guard.
15266         * ax.h: Rename include guard.
15267         * arm-linux-tdep.h: Add include guard.
15268         * arm-fbsd-tdep.h: Add include guard.
15269         * arch/xtensa.h: Rename include guard.
15270         * arch/tic6x.h: Add include guard.
15271         * arch/i386.h: Add include guard.
15272         * arch/arm.h: Rename include guard.
15273         * arch/arm-linux.h: Rename include guard.
15274         * arch/arm-get-next-pcs.h: Rename include guard.
15275         * arch/amd64.h: Add include guard.
15276         * arch/aarch64-insn.h: Rename include guard.
15277         * arch-utils.h: Rename include guard.
15278         * annotate.h: Add include guard.
15279         * amd64-darwin-tdep.h: Rename include guard.
15280         * aarch64-linux-tdep.h: Add include guard.
15281         * aarch64-fbsd-tdep.h: Add include guard.
15282         * aarch32-linux-nat.h: Add include guard.
15283
15284 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15285
15286         * macrotab.c (macro_define_internal): New function that
15287         factorizes macro_define_object_internal and macro_define_function
15288         code.
15289         (macro_define_object_internal): Use macro_define_internal.
15290         (macro_define_function): Likewise.
15291
15292 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15293
15294         * macrocmd.c (extract_identifier): Return
15295         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15296         callers.
15297
15298 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15299
15300         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15301
15302 2019-02-05  Tom Tromey  <tom@tromey.com>
15303
15304         * target.c (target_stack::unpush): Move assertion earlier.
15305
15306 2019-01-30  Tom Tromey  <tom@tromey.com>
15307
15308         PR python/23615:
15309         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15310         (gdbpy_parse_and_eval): Likewise.
15311         * python/python-internal.h (gdbpy_allow_threads): New class.
15312
15313 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15314
15315         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15316         (aarch64_fbsd_fpregmap): Move earlier.
15317         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15318         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15319         instead of individual calls to trad_frame_set_reg_addr.
15320         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15321         earlier.
15322         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15323         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15324         instead of individual calls to trad_frame_set_reg_addr.
15325
15326 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15327
15328         * CONTRIBUTE: Replace contribution list with wiki link.
15329
15330 2019-01-25  Tom Tromey  <tom@tromey.com>
15331
15332         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15333
15334 2019-01-25  Tom Tromey  <tom@tromey.com>
15335
15336         * xtensa-linux-nat.c: Fix common/ includes.
15337         * xml-support.h: Fix common/ includes.
15338         * xml-support.c: Fix common/ includes.
15339         * x86-linux-nat.c: Fix common/ includes.
15340         * windows-nat.c: Fix common/ includes.
15341         * varobj.h: Fix common/ includes.
15342         * varobj.c: Fix common/ includes.
15343         * value.c: Fix common/ includes.
15344         * valops.c: Fix common/ includes.
15345         * utils.c: Fix common/ includes.
15346         * unittests/xml-utils-selftests.c: Fix common/ includes.
15347         * unittests/utils-selftests.c: Fix common/ includes.
15348         * unittests/unpack-selftests.c: Fix common/ includes.
15349         * unittests/tracepoint-selftests.c: Fix common/ includes.
15350         * unittests/style-selftests.c: Fix common/ includes.
15351         * unittests/string_view-selftests.c: Fix common/ includes.
15352         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15353         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15354         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15355         * unittests/rsp-low-selftests.c: Fix common/ includes.
15356         * unittests/parse-connection-spec-selftests.c: Fix common/
15357         includes.
15358         * unittests/optional-selftests.c: Fix common/ includes.
15359         * unittests/offset-type-selftests.c: Fix common/ includes.
15360         * unittests/observable-selftests.c: Fix common/ includes.
15361         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15362         * unittests/memrange-selftests.c: Fix common/ includes.
15363         * unittests/memory-map-selftests.c: Fix common/ includes.
15364         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15365         * unittests/function-view-selftests.c: Fix common/ includes.
15366         * unittests/environ-selftests.c: Fix common/ includes.
15367         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15368         * unittests/common-utils-selftests.c: Fix common/ includes.
15369         * unittests/cli-utils-selftests.c: Fix common/ includes.
15370         * unittests/array-view-selftests.c: Fix common/ includes.
15371         * ui-file.c: Fix common/ includes.
15372         * tui/tui-io.c: Fix common/ includes.
15373         * tracepoint.h: Fix common/ includes.
15374         * tracepoint.c: Fix common/ includes.
15375         * tracefile-tfile.c: Fix common/ includes.
15376         * top.h: Fix common/ includes.
15377         * top.c: Fix common/ includes.
15378         * thread.c: Fix common/ includes.
15379         * target/waitstatus.h: Fix common/ includes.
15380         * target/waitstatus.c: Fix common/ includes.
15381         * target.h: Fix common/ includes.
15382         * target.c: Fix common/ includes.
15383         * target-memory.c: Fix common/ includes.
15384         * target-descriptions.c: Fix common/ includes.
15385         * symtab.h: Fix common/ includes.
15386         * symfile.c: Fix common/ includes.
15387         * stap-probe.c: Fix common/ includes.
15388         * spu-linux-nat.c: Fix common/ includes.
15389         * sparc-nat.c: Fix common/ includes.
15390         * source.c: Fix common/ includes.
15391         * solib.c: Fix common/ includes.
15392         * solib-target.c: Fix common/ includes.
15393         * ser-unix.c: Fix common/ includes.
15394         * ser-tcp.c: Fix common/ includes.
15395         * ser-pipe.c: Fix common/ includes.
15396         * ser-base.c: Fix common/ includes.
15397         * selftest-arch.c: Fix common/ includes.
15398         * s12z-tdep.c: Fix common/ includes.
15399         * rust-exp.y: Fix common/ includes.
15400         * rs6000-aix-tdep.c: Fix common/ includes.
15401         * riscv-tdep.c: Fix common/ includes.
15402         * remote.c: Fix common/ includes.
15403         * remote-notif.h: Fix common/ includes.
15404         * remote-fileio.h: Fix common/ includes.
15405         * remote-fileio.c: Fix common/ includes.
15406         * regcache.h: Fix common/ includes.
15407         * regcache.c: Fix common/ includes.
15408         * record-btrace.c: Fix common/ includes.
15409         * python/python.c: Fix common/ includes.
15410         * python/py-type.c: Fix common/ includes.
15411         * python/py-inferior.c: Fix common/ includes.
15412         * progspace.h: Fix common/ includes.
15413         * producer.c: Fix common/ includes.
15414         * procfs.c: Fix common/ includes.
15415         * proc-api.c: Fix common/ includes.
15416         * printcmd.c: Fix common/ includes.
15417         * ppc-linux-nat.c: Fix common/ includes.
15418         * parser-defs.h: Fix common/ includes.
15419         * osdata.c: Fix common/ includes.
15420         * obsd-nat.c: Fix common/ includes.
15421         * nat/x86-linux.c: Fix common/ includes.
15422         * nat/x86-linux-dregs.c: Fix common/ includes.
15423         * nat/x86-dregs.h: Fix common/ includes.
15424         * nat/x86-dregs.c: Fix common/ includes.
15425         * nat/ppc-linux.c: Fix common/ includes.
15426         * nat/mips-linux-watch.h: Fix common/ includes.
15427         * nat/mips-linux-watch.c: Fix common/ includes.
15428         * nat/linux-waitpid.c: Fix common/ includes.
15429         * nat/linux-ptrace.h: Fix common/ includes.
15430         * nat/linux-ptrace.c: Fix common/ includes.
15431         * nat/linux-procfs.c: Fix common/ includes.
15432         * nat/linux-personality.c: Fix common/ includes.
15433         * nat/linux-osdata.c: Fix common/ includes.
15434         * nat/linux-namespaces.c: Fix common/ includes.
15435         * nat/linux-btrace.h: Fix common/ includes.
15436         * nat/linux-btrace.c: Fix common/ includes.
15437         * nat/fork-inferior.c: Fix common/ includes.
15438         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15439         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15440         * nat/aarch64-linux.c: Fix common/ includes.
15441         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15442         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15443         * namespace.h: Fix common/ includes.
15444         * mips-linux-tdep.c: Fix common/ includes.
15445         * minsyms.c: Fix common/ includes.
15446         * mi/mi-parse.h: Fix common/ includes.
15447         * mi/mi-main.c: Fix common/ includes.
15448         * mi/mi-cmd-env.c: Fix common/ includes.
15449         * memrange.h: Fix common/ includes.
15450         * memattr.c: Fix common/ includes.
15451         * maint.h: Fix common/ includes.
15452         * maint.c: Fix common/ includes.
15453         * main.c: Fix common/ includes.
15454         * machoread.c: Fix common/ includes.
15455         * location.c: Fix common/ includes.
15456         * linux-thread-db.c: Fix common/ includes.
15457         * linux-nat.c: Fix common/ includes.
15458         * linux-fork.c: Fix common/ includes.
15459         * inline-frame.c: Fix common/ includes.
15460         * infrun.c: Fix common/ includes.
15461         * inflow.c: Fix common/ includes.
15462         * inferior.h: Fix common/ includes.
15463         * inferior.c: Fix common/ includes.
15464         * infcmd.c: Fix common/ includes.
15465         * inf-ptrace.c: Fix common/ includes.
15466         * inf-child.c: Fix common/ includes.
15467         * ia64-linux-nat.c: Fix common/ includes.
15468         * i387-tdep.c: Fix common/ includes.
15469         * i386-tdep.c: Fix common/ includes.
15470         * i386-linux-tdep.c: Fix common/ includes.
15471         * i386-linux-nat.c: Fix common/ includes.
15472         * i386-go32-tdep.c: Fix common/ includes.
15473         * i386-fbsd-tdep.c: Fix common/ includes.
15474         * i386-fbsd-nat.c: Fix common/ includes.
15475         * guile/scm-type.c: Fix common/ includes.
15476         * guile/guile.c: Fix common/ includes.
15477         * go32-nat.c: Fix common/ includes.
15478         * gnu-nat.c: Fix common/ includes.
15479         * gdbthread.h: Fix common/ includes.
15480         * gdbarch-selftests.c: Fix common/ includes.
15481         * gdb_usleep.c: Fix common/ includes.
15482         * gdb_select.h: Fix common/ includes.
15483         * gdb_bfd.c: Fix common/ includes.
15484         * gcore.c: Fix common/ includes.
15485         * fork-child.c: Fix common/ includes.
15486         * findvar.c: Fix common/ includes.
15487         * fbsd-nat.c: Fix common/ includes.
15488         * event-top.c: Fix common/ includes.
15489         * event-loop.c: Fix common/ includes.
15490         * dwarf2read.c: Fix common/ includes.
15491         * dwarf2loc.c: Fix common/ includes.
15492         * dwarf2-frame.c: Fix common/ includes.
15493         * dwarf-index-cache.c: Fix common/ includes.
15494         * dtrace-probe.c: Fix common/ includes.
15495         * disasm-selftests.c: Fix common/ includes.
15496         * defs.h: Fix common/ includes.
15497         * csky-tdep.c: Fix common/ includes.
15498         * cp-valprint.c: Fix common/ includes.
15499         * cp-support.h: Fix common/ includes.
15500         * cp-support.c: Fix common/ includes.
15501         * corelow.c: Fix common/ includes.
15502         * completer.h: Fix common/ includes.
15503         * completer.c: Fix common/ includes.
15504         * compile/compile.c: Fix common/ includes.
15505         * compile/compile-loc2c.c: Fix common/ includes.
15506         * compile/compile-cplus-types.c: Fix common/ includes.
15507         * compile/compile-cplus-symbols.c: Fix common/ includes.
15508         * command.h: Fix common/ includes.
15509         * cli/cli-dump.c: Fix common/ includes.
15510         * cli/cli-cmds.c: Fix common/ includes.
15511         * charset.c: Fix common/ includes.
15512         * build-id.c: Fix common/ includes.
15513         * btrace.h: Fix common/ includes.
15514         * btrace.c: Fix common/ includes.
15515         * breakpoint.h: Fix common/ includes.
15516         * breakpoint.c: Fix common/ includes.
15517         * ax.h:
15518         (enum agent_op): Fix common/ includes.
15519         * ax-general.c (struct aop_map): Fix common/ includes.
15520         * ax-gdb.c: Fix common/ includes.
15521         * auxv.c: Fix common/ includes.
15522         * auto-load.c: Fix common/ includes.
15523         * arm-tdep.c: Fix common/ includes.
15524         * arch/riscv.c: Fix common/ includes.
15525         * arch/ppc-linux-common.c: Fix common/ includes.
15526         * arch/i386.c: Fix common/ includes.
15527         * arch/arm.c: Fix common/ includes.
15528         * arch/arm-linux.c: Fix common/ includes.
15529         * arch/arm-get-next-pcs.c: Fix common/ includes.
15530         * arch/amd64.c: Fix common/ includes.
15531         * arch/aarch64.c: Fix common/ includes.
15532         * arch/aarch64-insn.c: Fix common/ includes.
15533         * arch-utils.c: Fix common/ includes.
15534         * amd64-windows-tdep.c: Fix common/ includes.
15535         * amd64-tdep.c: Fix common/ includes.
15536         * amd64-sol2-tdep.c: Fix common/ includes.
15537         * amd64-obsd-tdep.c: Fix common/ includes.
15538         * amd64-nbsd-tdep.c: Fix common/ includes.
15539         * amd64-linux-tdep.c: Fix common/ includes.
15540         * amd64-linux-nat.c: Fix common/ includes.
15541         * amd64-fbsd-tdep.c: Fix common/ includes.
15542         * amd64-fbsd-nat.c: Fix common/ includes.
15543         * amd64-dicos-tdep.c: Fix common/ includes.
15544         * amd64-darwin-tdep.c: Fix common/ includes.
15545         * agent.c: Fix common/ includes.
15546         * ada-lang.h: Fix common/ includes.
15547         * ada-lang.c: Fix common/ includes.
15548         * aarch64-tdep.c: Fix common/ includes.
15549
15550 2019-01-25  Tom Tromey  <tom@tromey.com>
15551
15552         * common/create-version.sh: Use common/version.h.
15553
15554 2019-01-24  Pedro Alves  <palves@redhat.com>
15555
15556         * infrun.c (signal_stop, signal_print, signal_program)
15557         (signal_catch, signal_pass): Now arrays instead of pointers.
15558         (update_signals_program_target, do_target_resume)
15559         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15560         * linux-nat.c (linux_nat_target::pass_signals)
15561         (linux_nat_target::create_inferior, linux_nat_target::attach):
15562         Adjust.
15563         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15564         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15565         * procfs.c (procfs_target::pass_signals): Adjust.
15566         * record-full.c (record_full_target::resume): Adjust.
15567         * remote.c (remote_target::pass_signals)
15568         (remote_target::program_signals): Adjust.
15569         * target-debug.h (target_debug_print_signals): Now takes a
15570         gdb::array_view as parameter.  Adjust.
15571         * target.h (target_ops) <pass_signals, program_signals>: Replace
15572         pointer and length parameters with gdb::array_view.
15573         (target_pass_signals, target_program_signals): Likewise.
15574         * target-delegates.c: Regenerate.
15575
15576 2019-01-24  Pedro Alves  <palves@redhat.com>
15577
15578         * common/forward-scope-exit.h
15579         (forward_scope_exit::forward_scope_exit): Pass arguments to
15580         m_bind_function directly, instead of creating a std::bind and
15581         copying that.
15582
15583 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15584
15585         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15586         for static members.
15587         (pass_in_v_vfp_candidate): Likewise.
15588
15589 2019-01-23  Tom Tromey  <tom@tromey.com>
15590             Pedro Alves  <palves@redhat.com>
15591
15592         * regcache.c (class regcache_invalidator): Remove.
15593         (regcache::raw_write): Use make_scope_exit.
15594
15595 2019-01-23  Tom Tromey  <tom@tromey.com>
15596
15597         * ui-out.h (class ui_out_emit_type): Update comment.
15598
15599 2019-01-23  Tom Tromey  <tom@tromey.com>
15600
15601         * infrun.c (fetch_inferior_event): Update comment.
15602
15603 2019-01-23  Tom Tromey  <tom@tromey.com>
15604             Pedro Alves  <palves@redhat.com>
15605
15606         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15607         parameter.
15608         (fetch_inferior_event): Use SCOPE_EXIT.
15609
15610
15611 2019-01-23  Tom Tromey  <tom@tromey.com>
15612             Pedro Alves  <palves@redhat.com>
15613
15614         * infrun.c (disable_thread_events): Delete.
15615         (stop_all_threads): Use SCOPE_EXIT.
15616
15617 2019-01-23  Tom Tromey  <tom@tromey.com>
15618             Pedro Alves  <palves@redhat.com>
15619
15620         * symfile.c: Include forward-scope-exit.h.
15621         (clear_symtab_users_cleanup): Replace forward declaration with
15622         a FORWARD_SCOPE_EXIT.
15623         (syms_from_objfile_1): Use the forward_scope_exit and
15624         gdb::optional instead of cleanup_function.
15625         (reread_symbols): Use the forward_scope_exit instead of
15626         cleanup_function.
15627         (clear_symtab_users_cleanup): Remove function.
15628
15629 2019-01-23  Tom Tromey  <tom@tromey.com>
15630             Pedro Alves  <palves@redhat.com>
15631
15632         * linux-nat.c: Include scope-exit.h.
15633         (cleanup_target_stop): Remove.
15634         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15635         SCOPE_EXIT.
15636
15637 2019-01-23  Tom Tromey  <tom@tromey.com>
15638             Pedro Alves  <palves@redhat.com>
15639
15640         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15641         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15642
15643 2019-01-23  Tom Tromey  <tom@tromey.com>
15644             Andrew Burgess  <andrew.burgess@embecosm.com>
15645             Pedro Alves  <palves@redhat.com>
15646
15647         * infrun.c (fetch_inferior_event): Use scope_exit.
15648         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15649         * top.c (execute_command): Use scope_exit.
15650         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15651         * utils.c (do_bpstat_clear_actions_cleanup)
15652         (make_bpstat_clear_actions_cleanup): Remove.
15653
15654 2019-01-23  Tom Tromey  <tom@tromey.com>
15655             Pedro Alves  <palves@redhat.com>
15656
15657         * infrun.c: Include "common/scope-exit.h"
15658         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15659         (wait_for_inferior): Use SCOPE_EXIT.
15660         (fetch_inferior_event): Use scope_exit.
15661
15662 2019-01-23  Tom Tromey  <tom@tromey.com>
15663             Pedro Alves  <palves@redhat.com>
15664
15665         * breakpoint.c (create_breakpoint): Remove cleanup.
15666
15667 2019-01-23  Tom Tromey  <tom@tromey.com>
15668             Andrew Burgess  <andrew.burgess@embecosm.com>
15669             Pedro Alves  <palves@redhat.com>
15670
15671 2019-01-23  Pedro Alves  <palves@redhat.com>
15672
15673         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15674
15675 2019-01-23  Pedro Alves  <palves@redhat.com>
15676             Andrew Burgess  <andrew.burgess@embecosm.com>
15677
15678         * gdbthread.h: Include "common/forward-scope-exit.h".
15679         (scoped_finish_thread_state): Redefine custom class in terms of
15680         forward_scope_exit.
15681
15682 2019-01-23  Pedro Alves  <palves@redhat.com>
15683             Andrew Burgess  <andrew.burgess@embecosm.com>
15684
15685         * common/forward-scope-exit.h: New file.
15686
15687 2019-01-23  Pedro Alves  <palves@redhat.com>
15688             Andrew Burgess  <andrew.burgess@embecosm.com>
15689             Tom Tromey  <tom@tromey.com>
15690
15691         * common/scope-exit.h: New file.
15692
15693 2019-01-23  Pedro Alves  <palves@redhat.com>
15694
15695         * common/preprocessor.h (ESC): Rename to ...
15696         (ESC_PARENS): ... this.
15697         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15698         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15699
15700 2019-01-23  Tom Tromey  <tom@tromey.com>
15701
15702         * language.h (class scoped_switch_to_sym_language_if_auto):
15703         Initialize m_lang in both cases.
15704
15705 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15706
15707         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15708         with XCNEW.
15709
15710 2019-01-22  Tom Tromey  <tom@tromey.com>
15711
15712         * corelow.c: Do not include sys/file.h.
15713
15714 2019-01-22  Tom Tromey  <tom@tromey.com>
15715
15716         * tui/tui-wingeneral.h: Include gdb_curses.h.
15717
15718 2019-01-22  Tom Tromey  <tom@tromey.com>
15719
15720         * source-cache.h (class source_cache) <get_source_lines,
15721         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15722
15723 2019-01-22  Tom Tromey  <tom@tromey.com>
15724
15725         * remote-fileio.h (struct remote_target): Declare.
15726
15727 2019-01-22  Tom Tromey  <tom@tromey.com>
15728
15729         * python/py-arch.c: Do not include py-ref.h.
15730         * python/py-bpevent.c: Do not include py-ref.h.
15731         * python/py-cmd.c: Do not include py-ref.h.
15732         * python/py-continueevent.c: Do not include py-ref.h.
15733         * python/py-event.h: Do not include py-ref.h.
15734         * python/py-evtregistry.c: Do not include py-ref.h.
15735         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15736         * python/py-frame.c: Do not include py-ref.h.
15737         * python/py-framefilter.c: Do not include py-ref.h.
15738         * python/py-function.c: Do not include py-ref.h.
15739         * python/py-infevents.c: Do not include py-ref.h.
15740         * python/py-linetable.c: Do not include py-ref.h.
15741         * python/py-objfile.c: Do not include py-ref.h.
15742         * python/py-param.c: Do not include py-ref.h.
15743         * python/py-prettyprint.c: Do not include py-ref.h.
15744         * python/py-progspace.c: Do not include py-ref.h.
15745         * python/py-symbol.c: Do not include py-ref.h.
15746         * python/py-symtab.c: Do not include py-ref.h.
15747         * python/py-type.c: Do not include py-ref.h.
15748         * python/py-unwind.c: Do not include py-ref.h.
15749         * python/py-utils.c: Do not include py-ref.h.
15750         * python/py-value.c: Do not include py-ref.h.
15751         * python/py-varobj.c: Do not include py-ref.h.
15752         * python/py-xmethods.c: Do not include py-ref.h.
15753         * python/python.c: Do not include py-ref.h.
15754         * varobj.c: Do not include py-ref.h.
15755
15756 2019-01-22  Tom Tromey  <tom@tromey.com>
15757
15758         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15759         keyword for bcache.
15760
15761 2019-01-22  Tom Tromey  <tom@tromey.com>
15762
15763         * compile/compile-cplus-types.c: Remove a comment by #include.
15764
15765 2019-01-22  Tom Tromey  <tom@tromey.com>
15766
15767         * compile/gcc-c-plugin.h: Include compile-internal.h.
15768
15769 2019-01-22  Tom Tromey  <tom@tromey.com>
15770
15771         * stabsread.c (EXTERN): Do not define.
15772         (symnum, next_symbol_text_func, processing_gcc_compilation)
15773         (within_function, global_sym_chain, global_stabs)
15774         (previous_stab_code, this_object_header_files)
15775         (n_this_object_header_files)
15776         (n_allocated_this_object_header_files): Define.
15777         * stabsread.h (EXTERN): Never define.  Use "extern".
15778
15779 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15780
15781         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15782         history_value.
15783
15784 2019-01-21  Tom Tromey  <tom@tromey.com>
15785
15786         * ui-out.c: Fix includes.
15787         * tui/tui-source.c: Fix includes.
15788         * target.c: Fix includes.
15789         * remote.c: Fix includes.
15790         * regcache.c: Fix includes.
15791         * python/py-block.c: Fix includes.
15792         * printcmd.c: Fix includes.
15793         * or1k-tdep.c: Fix includes.
15794         * mi/mi-main.c: Fix includes.
15795         * m32r-tdep.c: Fix includes.
15796         * csky-tdep.c: Fix includes.
15797         * compile/compile-cplus-types.c: Fix includes.
15798         * cli/cli-interp.c: Fix includes.
15799
15800 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15801
15802         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15803         for padding.
15804
15805 2019-01-16  Tom Tromey  <tom@tromey.com>
15806
15807         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15808         earlier.
15809         (struct objfile) <msymbols_range>: Move from top level.
15810         <msymbols>: New method.
15811         (class objfile_msymbols): Remove.
15812         * symtab.c (default_collect_symbol_completion_matches_break_on):
15813         Update.
15814         * symmisc.c (dump_msymbols): Update.
15815         * stabsread.c (scan_file_globals): Update.
15816         * objc-lang.c (info_selectors_command, info_classes_command)
15817         (find_methods): Update.
15818         * minsyms.c (find_solib_trampoline_target): Update.
15819         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15820         * coffread.c (coff_symfile_read): Update.
15821         * ada-lang.c (ada_lookup_simple_minsym)
15822         (ada_collect_symbol_completion_matches): Update.
15823
15824 2019-01-16  Tom Tromey  <tom@tromey.com>
15825
15826         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15827         type.  Remove no-argument constructor.
15828         <iterator::operator++>: Simplify.
15829         <begin>: Update.
15830         <end>: Use minimal_symbol_count.
15831
15832 2019-01-16  Tom Tromey  <tom@tromey.com>
15833
15834         * objfiles.h (struct objfile) <psymtabs>: New method.
15835         (class objfile_psymtabs): Remove.
15836         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15837         typedef.
15838         <range>: New method.
15839         (require_partial_symbols): Change return type.
15840         * psymtab.c (require_partial_symbols)
15841         (psym_expand_symtabs_matching): Update.
15842         * mdebugread.c (parse_partial_symbols): Update.
15843         * dbxread.c (dbx_end_psymtab): Update.
15844
15845 2019-01-15  Tom Tromey  <tom@tromey.com>
15846
15847         * symtab.c (lookup_objfile_from_block)
15848         (lookup_symbol_in_objfile_symtabs)
15849         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15850         (find_line_symtab, info_sources_command)
15851         (default_collect_symbol_completion_matches_break_on)
15852         (make_source_files_completion_list): Update.
15853         * symmisc.c (print_objfile_statistics, dump_objfile)
15854         (maintenance_print_symbols, maintenance_info_symtabs)
15855         (maintenance_check_symtabs, maintenance_info_line_tables):
15856         Update.
15857         * source.c (select_source_symtab)
15858         (forget_cached_source_info_for_objfile): Update.
15859         * objfiles.h (class objfile_compunits): Remove.
15860         (struct objfile) <compunits_range>: New typedef.
15861         (compunits): New method.
15862         * objfiles.c (objfile_relocate1): Update.
15863         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15864         * maint.c (count_symtabs_and_blocks): Update.
15865         * linespec.c (iterate_over_all_matching_symtabs): Update.
15866         * cp-support.c (add_symbol_overload_list_qualified): Update.
15867         * coffread.c (coff_symtab_read): Update.
15868         * ada-lang.c (add_nonlocal_symbols)
15869         (ada_collect_symbol_completion_matches)
15870         (ada_add_global_exceptions): Update.
15871
15872 2019-01-15  Tom Tromey  <tom@tromey.com>
15873
15874         * progspace.h (program_space) <objfiles_safe_range>: New
15875         typedef.
15876         <objfiles_safe>: New method.
15877         * objfiles.h (class all_objfiles_safe): Remove.
15878         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15879         * jit.c (jit_inferior_exit_hook): Update.
15880
15881 2019-01-17  Tom Tromey  <tom@tromey.com>
15882
15883         * progspace.h (program_space) <objfiles_range>: New typedef.
15884         <objfiles>: New method.
15885         <objfiles_head>: Rename from objfiles.
15886         (object_files): Update.
15887         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15888         * guile/scm-pretty-print.c
15889         (ppscm_find_pretty_printer_from_objfiles): Update.
15890         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15891         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15892         Update.
15893         * python/py-progspace.c (pspy_get_objfiles): Update.
15894         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15895         Update.
15896         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15897         (objfpy_lookup_objfile_by_build_id): Update.
15898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15899         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15900         Update.
15901         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15902         (expand_symtab_containing_pc, lookup_objfile_from_block)
15903         (lookup_static_symbol, basic_lookup_transparent_type)
15904         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15905         (find_line_symtab, info_sources_command)
15906         (default_collect_symbol_completion_matches_break_on)
15907         (make_source_files_completion_list, find_main_name): Update.
15908         * symmisc.c (print_symbol_bcache_statistics)
15909         (print_objfile_statistics, maintenance_print_symbols)
15910         (maintenance_print_msymbols, maintenance_print_objfiles)
15911         (maintenance_info_symtabs, maintenance_check_symtabs)
15912         (maintenance_expand_symtabs, maintenance_info_line_tables):
15913         Update.
15914         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15915         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15916         (map_overlay_command, unmap_overlay_command)
15917         (simple_overlay_update, expand_symtabs_matching)
15918         (map_symbol_filenames): Update.
15919         * symfile-debug.c (set_debug_symfile): Update.
15920         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15921         Update.
15922         * source.c (select_source_symtab, forget_cached_source_info):
15923         Update.
15924         * solib.c (solib_read_symbols): Update.
15925         * solib-spu.c (append_ocl_sos): Update.
15926         * psymtab.c (maintenance_print_psymbols)
15927         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15928         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15929         * printcmd.c (info_symbol_command): Update.
15930         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15931         Update.
15932         * objfiles.h (class all_objfiles): Remove.
15933         * objfiles.c (have_partial_symbols, have_full_symbols)
15934         (have_minimal_symbols, qsort_cmp, update_section_map)
15935         (shared_objfile_contains_address_p)
15936         (default_iterate_over_objfiles_in_search_order): Update.
15937         * objc-lang.c (info_selectors_command, info_classes_command)
15938         (find_methods): Update.
15939         * minsyms.c (find_solib_trampoline_target): Update.
15940         * maint.c (maintenance_info_sections)
15941         (maintenance_translate_address, count_symtabs_and_blocks):
15942         Update.
15943         * main.c (captured_main_1): Update.
15944         * linux-thread-db.c (try_thread_db_load_from_pdir)
15945         (has_libpthread): Update.
15946         * linespec.c (iterate_over_all_matching_symtabs)
15947         (search_minsyms_for_name): Update.
15948         * jit.c (jit_find_objf_with_entry_addr): Update.
15949         * hppa-tdep.c (find_unwind_entry)
15950         (hppa_lookup_stub_minimal_symbol): Update.
15951         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15952         Update.
15953         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15954         (elf_gnu_ifunc_resolve_by_got): Update.
15955         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15956         * dwarf-index-write.c (save_gdb_index_command): Update.
15957         * cp-support.c (add_symbol_overload_list_qualified): Update.
15958         * breakpoint.c (create_overlay_event_breakpoint)
15959         (create_longjmp_master_breakpoint)
15960         (create_std_terminate_master_breakpoint)
15961         (create_exception_master_breakpoint): Update.
15962         * blockframe.c (find_pc_partial_function): Update.
15963         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15964         (ada_collect_symbol_completion_matches)
15965         (ada_add_global_exceptions): Update.
15966
15967 2019-01-17  Tom Tromey  <tom@tromey.com>
15968
15969         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15970         declare VEC.
15971         (solib_target_parse_libraries): Change return type.
15972         (library_list_start_segment, library_list_start_section)
15973         (library_list_end_library, library_list_start_library); Update.
15974         (solib_target_free_library_list): Remove.
15975         (solib_target_parse_libraries): Remove cleanup.  Change return
15976         type.
15977         (solib_target_current_sos): Update.
15978
15979 2019-01-17  Tom Tromey  <tromey@bapiya>
15980
15981         * valprint.c: Replace "the the" with "the".
15982         * symtab.c: Replace "the the" with "the".
15983         * solib.c: Replace "the the" with "the".
15984         * solib-dsbt.c: Replace "the the" with "the".
15985         * linespec.c: Replace "the the" with "the".
15986         * dwarf2loc.h: Replace "the the" with "the".
15987         * amd64-windows-tdep.c: Replace "the the" with "the".
15988         * aarch64-tdep.c: Replace "the the" with "the".
15989
15990 2019-01-16  Keith Seitz  <keiths@redhat.com>
15991
15992         PR gdb/23773
15993         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15994         <builder>: Rename to ..
15995         <m_builder>: ... this and make private.
15996         (dwarf2_cu::get_builder): New method.  Change all users of
15997         `builder' to use this method.
15998         (dwarf2_start_symtab): Move to ...
15999         (dwarf2_cu::start_symtab): ... here.  Update all callers
16000         (setup_type_unit_groups): Move to ...
16001         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16002         callers.
16003         (dwarf2_cu::reset_builder): New method.
16004         (process_full_compunit, process_full_type_unit): Use
16005         dwarf2_cu::reset_builder.
16006         (follow_die_offset): Record the ancestor CU if it is different
16007         from the followed DIE's CU.
16008         (follow_die_sig_1): Likewise.
16009
16010 2019-01-15  Tom Tromey  <tom@tromey.com>
16011
16012         * remote.c (class remote_state) <buf>: Now a char_vector.
16013         <buf_size>: Remove.
16014         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16015         parameter.
16016         (remote_target::getpkt_or_notif_sane_1)
16017         (remote_target::getpkt_sane)
16018         (remote_target::getpkt_or_notif_sane): Likewise.
16019         (class remote_target) <putpkt>: New overload.
16020         (remote_target::read_frame): Change type of "buf_p".  Remove
16021         sizeof_p parameter.
16022         (packet_ok): New overload.
16023         (packet_check_result): New overload.
16024         Update all uses.
16025
16026 2019-01-14  Tom Tromey  <tom@tromey.com>
16027
16028         * remote-notif.c (handle_notification, remote_notif_ack)
16029         (remote_notif_parse): Make "buf" const.
16030         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16031         const.
16032         (remote_notif_parse, remote_notif_ack, handle_notification):
16033         Likewise.
16034         * remote.c (remote_notif_stop_parse): Make "buf" const.
16035         (remote_target::remote_parse_stop_reply): Make "buf" const.
16036         (remote_notif_stop_ack): Make "buf" const.
16037
16038 2019-01-14  Tom Tromey  <tom@tromey.com>
16039
16040         * remote.c (remote_console_output): Make parameter const.
16041
16042 2019-01-14  Tom Tromey  <tom@tromey.com>
16043
16044         * target-debug.h (target_debug_print_signals): Constify.
16045         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16046         * procfs.c (procfs_target::pass_signals): Update.
16047         * linux-nat.c (linux_nat_target::pass_signals): Update.
16048         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16049         * target-delegates.c: Rebuild.
16050         * remote.c (remote_target::program_signals): Update.
16051         (remote_target::pass_signals): Update.
16052         * target.c (target_pass_signals): Constify argument.
16053         (target_program_signals): Likewise.
16054         * target.h (struct target_ops) <pass_signals, program_signals>:
16055         Constify argument.
16056         (target_pass_signals, target_program_signals): Constify argument.
16057
16058 2019-01-14  Tom Tromey  <tom@tromey.com>
16059
16060         PR tui/28819:
16061         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16062
16063 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16064
16065         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16066         field.
16067         * rs6000-tdep.c: Include reggroups.h.
16068         (IS_V_ALIAS_PSEUDOREG): Define.
16069         (rs6000_register_name): Return names for the "vX" aliases.
16070         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16071         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16072         aliases.  Call default_register_reggroup_p for all other
16073         pseudo-registers.
16074         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16075         New functions.
16076         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16077         Handle "vX" aliases.
16078         (v_alias_pseudo_register_collect): New function.
16079         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16080         (rs6000_gdbarch_init): Initialize "vX" aliases as
16081         pseudo-registers.  Restore registration of
16082         rs6000_pseudo_register_reggroup_p with
16083         set_tdesc_pseudo_register_reggroup_p.
16084
16085 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16086
16087         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16088         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16089         set_gdbarch_num_pseudo_regs.
16090
16091 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16092
16093         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16094         Remove arg prefixname, add do_set and do_show.
16095         Add member functions set_list and show_list.
16096         * cli/cli-style.c (class cli_style_option): Update accordingly.
16097         (style_set_list): Move to file scope.
16098         (style_show_list): Likewise.
16099         (set_style): Call help_list.
16100         (show_style): Call cmd_show_list.
16101         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16102         Update to use the new macro.
16103
16104 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16105
16106         * ada-lang.c (_initialize_ada_language): Expand the help text
16107         for the "catch exception" command.
16108
16109 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16110
16111         * symtab.c (matching_obj_sections): Initialize obj,
16112         declare it closer to its usage.
16113
16114 2019-01-10  Tom Tromey  <tom@tromey.com>
16115
16116         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16117         (basic_inf_threads_range): Remove.
16118         (inf_threads_range, inf_non_exited_threads_range)
16119         (safe_inf_threads_range): Use next_adapter.
16120
16121 2019-01-10  Keith Seitz  <keiths@redhat.com>
16122
16123         PR gdb/23712
16124         PR symtab/23010
16125         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16126         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16127
16128 2019-01-10  Keith Seitz  <keiths@redhat.com>
16129
16130         PR gdb/23712
16131         PR symtab/23010
16132         * dictionary.c (pending_to_vector): Remove.
16133         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16134         Remove _1 suffix, replacing functions of the same name.  Update
16135         all callers.
16136         (dict_create_hashed, dict_create_hashed_expandable)
16137         (dict_create_linear, dict_create_linear_expandable, dict_free)
16138         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16139         Make functions static.
16140
16141 2019-01-10  Keith Seitz  <keiths@redhat.com>
16142
16143         PR gdb/23712
16144         PR symtab/23010
16145         * dictionary.h (struct dictionary): Replace declaration with
16146         multidictionary.
16147         (dict_create_hashed, dict_create_hashed_expandable)
16148         (dict_create_linear, dict_create_linear_expandable)
16149         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16150         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16151         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16152         taking multidictionary argument.
16153         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16154         * block.h (struct block) <dict>: Change to multidictionary
16155         and rename `multidict'.
16156         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16157         symmisc.c: Update all dictionary references to multidictionary.
16158
16159 2019-01-10  Keith Seitz  <keiths@redhat.com>
16160
16161         PR gdb/23712
16162         PR symtab/23010
16163         * dictionary.c: Include unordered_map.
16164         (pending_to_vector): New function.
16165         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16166         Rewrite the non-"_1" functions to take vector instead
16167         of linked list.
16168         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16169         "new" _1 versions of the same name.
16170         (multidictionary): Define.
16171         (std::hash<enum language): New definition.
16172         (collate_pending_symbols_by_language, mdict_create_hashed)
16173         (mdict_create_hashed_expandable, mdict_create_linear)
16174         (mdict_create_linear_expandable, mdict_free)
16175         (find_language_dictionary, create_new_language_dictionary)
16176         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16177         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16178         (mdict_size, mdict_empty): New functions.
16179         * dictionary.h (mdict_iterator): Define.
16180
16181 2019-01-10  Pedro Alves  <palves@redhat.com>
16182
16183         * breakpoint.c (read_uploaded_action)
16184         (create_tracepoint_from_upload): Adjust to use
16185         gdb::unique_xmalloc_ptr.
16186         * ctf.c (ctf_write_uploaded_tp):
16187         (SET_ARRAY_FIELD): Use emplace_back.
16188         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16189         * tracefile-tfile.c (tfile_write_uploaded_tp):
16190         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16191         gdb::unique_xmalloc_ptr.
16192         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16193         at_string, cond_string, cmd_strings>: Replace char pointers
16194         with gdb::unique_xmalloc_ptr.
16195
16196 2019-01-10  Pedro Alves  <palves@redhat.com>
16197
16198         * solib-target.c (library_list_start_library): Don't xstrdup name.
16199
16200 2019-01-10  Pedro Alves  <palves@redhat.com>
16201
16202         * mdebugread.c (parse_partial_symbols): Use
16203         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16204
16205 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16206
16207         * linux-fork.c (scoped_switch_fork_info)
16208         <~scoped_switch_fork_info>: Fix incorrect variable name.
16209
16210 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16211
16212         * linux-fork.c (scoped_switch_fork_info)
16213         <scoped_switch_fork_info>: Make explicit.
16214         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16215
16216 2019-01-10  Tom Tromey  <tom@tromey.com>
16217
16218         * objfiles.h (objfile::reset_psymtabs): Update.
16219         * objfiles.c (objfile::objfile): Update.
16220         * psymtab.h (psymtab_storage::obstack): Update.
16221         (psymtab_storage::m_obstack): Use gdb::optional.
16222         (class psymtab_storage): Update comment.  Remove objfile
16223         parameter.
16224         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16225
16226 2019-01-10  Tom Tromey  <tom@tromey.com>
16227
16228         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16229         <free_psymtabs>: Now private.
16230         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16231         (allocate_psymtab): Use new method.
16232
16233 2019-01-10  Tom Tromey  <tom@tromey.com>
16234
16235         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16236         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16237         * mdebugread.c (parse_partial_symbols): Use
16238         allocate_dependencies.
16239         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16240         allocate_dependencies.
16241         (process_psymtab_comp_unit_reader)
16242         (build_type_psymtab_dependencies): Likewise.
16243         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16244
16245 2019-01-10  Tom Tromey  <tom@tromey.com>
16246
16247         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16248         PSYMBOL_SET_LANGUAGE.
16249         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16250
16251 2019-01-10  Tom Tromey  <tom@tromey.com>
16252
16253         * psymtab.h (psymtab_storage::obstack): New method.
16254         <m_obstack>: Rename from obstack; now private.
16255         * psymtab.c (psymtab_storage): Update.
16256         * dwarf2read.c (create_addrmap_from_index)
16257         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16258         Update.
16259
16260 2019-01-10  Tom Tromey  <tom@tromey.com>
16261
16262         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16263         * objfiles.h (objfile::reset_psymtabs): New method.
16264
16265 2019-01-10  Tom Tromey  <tom@tromey.com>
16266
16267         * symmisc.c (print_symbol_bcache_statistics): Update.
16268         (print_objfile_statistics): Update.
16269         * symfile.c (reread_symbols): Update.
16270         * psymtab.h (class psymtab_storage): New.
16271         * psymtab.c (psymtab_storage): New constructor.
16272         (~psymtab_storage): New destructor.
16273         (require_partial_symbols): Update.
16274         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16275         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16276         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16277         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16278         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16279         (start_psymtab_common, end_psymtab_common)
16280         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16281         (allocate_psymtab): Update.
16282         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16283         Update.
16284         (dump_psymtab_addrmap, maintenance_print_psymbols)
16285         (maintenance_check_psymtabs): Update.
16286         (class objfile_psymtabs): Move to objfiles.h.
16287         * psympriv.h (discard_psymtab): Now inline.
16288         (psymtab_discarder::psymtab_discarder): Update.
16289         (psymtab_discarder::~psymtab_discarder): Update.
16290         (ALL_OBJFILE_PSYMTABS): Rewrite.
16291         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16292         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16293         Remove fields.
16294         <partial_symtabs>: New field.
16295         (class objfile_psymtabs): Move from psymtab.h.  Update.
16296         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16297         psymbol_cache.
16298         (objfile::~objfile): Don't destroy psymbol_cache.
16299         * mdebugread.c (parse_partial_symbols): Update.
16300         * dwarf2read.c (create_addrmap_from_index)
16301         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16302         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16303         (add_partial_subprogram, dwarf2_ranges_read): Update.
16304         * dwarf-index-write.c (write_address_map)
16305         (write_one_signatured_type, recursively_write_psymbols)
16306         (class debug_names, class debug_names, write_psymtabs_to_index):
16307         Update.
16308
16309 2019-01-10  Tom Tromey  <tom@tromey.com>
16310
16311         * symtab.h (SYMBOL_SET_NAMES): Update.
16312         (symbol_set_names): Update.
16313         (MSYMBOL_SET_NAMES): Update.
16314         * symtab.c (symbol_set_names): Change argument to be an
16315         objfile_per_bfd_storage.
16316         * psymtab.c (add_psymbol_to_bcache): Update.
16317         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16318
16319 2019-01-10  Tom Tromey  <tom@tromey.com>
16320
16321         * symtab.c (create_demangled_names_hash): Change argument to be an
16322         objfile_per_bfd_storage.
16323         (symbol_set_names): Update.
16324
16325 2019-01-10  Tom Tromey  <tom@tromey.com>
16326
16327         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16328         init_psymbol_list.
16329         * psymtab.c (init_psymbol_list): Do nothing if already called.
16330         * psympriv.h (init_psymbol_list): Add comment.
16331         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16332         init_psymbol_list.
16333         * dbxread.c (dbx_symfile_read): Unconditionally call
16334         init_psymbol_list.
16335
16336 2019-01-10  Tom Tromey  <tom@tromey.com>
16337
16338         * xcoffread.c (scan_xcoff_symtab): Update.
16339         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16340         "where".
16341         * mdebugread.c (parse_partial_symbols)
16342         (handle_psymbol_enumerators): Update.
16343         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16344         * dbxread.c (read_dbx_symtab): Update.
16345         * psympriv.h (psymbol_placement): New enum.
16346         (add_psymbol_to_list): Update.
16347
16348 2019-01-10  Tom Tromey  <tom@tromey.com>
16349
16350         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16351         static_psymbols parameters.
16352         (scan_xcoff_symtab): Update.
16353         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16354         static_psymbols parameters.
16355         * psympriv.h (start_psymtab_common): Update.
16356         * mdebugread.c (parse_partial_symbols): Update.
16357         * dwarf2read.c (create_partial_symtab): Update.
16358         * dbxread.c (read_dbx_symtab): Update.
16359         (start_psymtab): Remove global_psymbols and static_psymbols
16360         parameters.
16361
16362 2019-01-10  Tom Tromey  <tom@tromey.com>
16363
16364         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16365         * psymtab.c (allocate_psymtab): Add comment.
16366         * psympriv.h (allocate_psymtab): Add comment.
16367         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16368         initializations.
16369         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16370
16371 2019-01-10  Tom Tromey  <tom@tromey.com>
16372
16373         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16374         Don't declare.
16375         * mipsread.c: Include mdebugread.h.
16376         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16377         Declare.
16378         * elfread.c: Include mdebugread.h.
16379
16380 2019-01-09  Tom Tromey  <tom@tromey.com>
16381
16382         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16383         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16384         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16385         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16386         (psym_lookup_symbol, psym_find_last_source_symtab)
16387         (psym_forget_cached_source_info, psym_print_stats)
16388         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16389         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16390         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16391         (psym_find_compunit_symtab_by_address)
16392         (maintenance_print_psymbols, maintenance_info_psymtabs)
16393         (maintenance_check_psymtabs): Use ranged for.
16394         * psymtab.h (class objfile_psymtabs): New.
16395         (require_partial_symbols): Return objfile_psymtabs.
16396         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16397
16398 2019-01-09  Tom Tromey  <tom@tromey.com>
16399
16400         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16401         (find_pc_mapped_section, list_overlays_command)
16402         (map_overlay_command, unmap_overlay_command)
16403         (simple_overlay_update): Use all_objfiles.
16404         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16405         * printcmd.c (info_symbol_command): Use all_objfiles.
16406         * objfiles.h (ALL_OBJSECTIONS): Remove.
16407         * maint.c (maintenance_translate_address): Use all_objfiles.
16408         * gcore.c (gcore_create_callback): Use all_objfiles.
16409         (objfile_find_memory_regions): Likewise.
16410
16411 2019-01-09  Tom Tromey  <tom@tromey.com>
16412
16413         * symtab.c (find_line_symtab, info_sources_command)
16414         (make_source_files_completion_list): Use objfile_compunits.
16415         * source.c (select_source_symtab): Use objfile_compunits.
16416         * objfiles.h (struct objfile): Update comment.
16417         (ALL_OBJFILES): Remove.
16418         (ALL_FILETABS): Remove.
16419         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16420         objfile_compunits.
16421
16422 2019-01-09  Tom Tromey  <tom@tromey.com>
16423
16424         * symmisc.c (print_objfile_statistics, dump_objfile)
16425         (maintenance_print_symbols): Use compunit_filetabs.
16426         * source.c (forget_cached_source_info_for_objfile): Use
16427         compunit_filetabs.
16428         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16429         (ALL_FILETABS): Use compunit_filetabs.
16430         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16431         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16432
16433 2019-01-09  Tom Tromey  <tom@tromey.com>
16434
16435         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16436         (compunit_filetabs): New.
16437         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16438         compunit_filetabs.
16439         (info_sources_command, make_source_files_completion_list): Remove
16440         declaration.
16441         * symmisc.c (print_objfile_statistics, dump_objfile)
16442         (maintenance_print_symbols): Remove declaration.
16443         (maintenance_info_symtabs): Use compunit_filetabs.
16444         (maintenance_info_line_tables): Likewise.
16445         * source.c (select_source_symtab): Change local variable name.
16446         (forget_cached_source_info_for_objfile): Remove declaration.
16447         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16448         * objfiles.c (objfile_relocate1): Remove declaration.
16449         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16450         declaration.
16451         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16452         * coffread.c (coff_symtab_read): Remove declaration.
16453         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16454         compunit_filetabs.
16455
16456 2019-01-09  Tom Tromey  <tom@tromey.com>
16457
16458         * symtab.c (lookup_objfile_from_block)
16459         (find_pc_sect_compunit_symtab, search_symbols)
16460         (default_collect_symbol_completion_matches_break_on): Use
16461         objfile_compunits.
16462         * objfiles.h (ALL_COMPUNITS): Remove.
16463         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16464         * cp-support.c (add_symbol_overload_list_qualified): Use
16465         objfile_compunits.
16466         * ada-lang.c (ada_collect_symbol_completion_matches)
16467         (ada_add_global_exceptions): Use objfile_compunits.
16468
16469 2019-01-09  Tom Tromey  <tom@tromey.com>
16470
16471         * source.c (select_source_symtab)
16472         (forget_cached_source_info_for_objfile): Remove declaration.
16473         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16474         declaration.
16475         * maint.c (count_symtabs_and_blocks): Remove declaration.
16476         * cp-support.c (add_symbol_overload_list_qualified): Remove
16477         declaration.
16478         * coffread.c (coff_symtab_read): Remove declaration.
16479         * symtab.c (lookup_symbol_in_objfile_symtabs)
16480         (basic_lookup_transparent_type_1): Use objfile_compunits.
16481         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16482         (info_sources_command, search_symbols)
16483         (default_collect_symbol_completion_matches_break_on)
16484         (make_source_files_completion_list): Remove declaration.
16485         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16486         (ada_collect_symbol_completion_matches)
16487         (ada_add_global_exceptions): Remove declaration.
16488         * linespec.c (iterate_over_all_matching_symtabs): Use
16489         objfile_compunits.
16490         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16491         (class objfile_compunits): New.
16492         (ALL_COMPUNITS): Use objfile_compunits.
16493         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16494         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16495         objfile_compunits.
16496         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16497
16498 2019-01-09  Tom Tromey  <tom@tromey.com>
16499
16500         * symtab.c (search_symbols)
16501         (default_collect_symbol_completion_matches_break_on): Use
16502         objfile_msymbols.
16503         * ada-lang.c (ada_lookup_simple_minsym)
16504         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16505         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16506         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16507         objfile_msymbols.
16508         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16509         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16510         * objc-lang.c (find_methods): Use objfile_msymbols.
16511         (info_selectors_command, info_classes_command): Likewise.
16512         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16513         * objfiles.h (class objfile_msymbols): New.
16514         (ALL_OBJFILE_MSYMBOLS): Remove.
16515         (ALL_MSYMBOLS): Remove.
16516
16517 2019-01-09  Tom Tromey  <tom@tromey.com>
16518
16519         * common/next-iterator.h (next_adapter): Add Iterator template
16520         parameter.
16521         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16522         (class all_objfiles_safe): New.
16523         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16524         * objfiles.c (put_objfile_before): Update comment.
16525         (add_separate_debug_objfile): Likewise.
16526         (free_all_objfiles): Use all_objfiles_safe.
16527         (objfile_purge_solibs): Likewise.
16528
16529 2019-01-09  Tom Tromey  <tom@tromey.com>
16530
16531         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16532         (expand_symtab_containing_pc, lookup_static_symbol)
16533         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16534         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16535         all_objfiles.
16536         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16537         * breakpoint.c (create_overlay_event_breakpoint)
16538         (create_longjmp_master_breakpoint)
16539         (create_std_terminate_master_breakpoint)
16540         (create_exception_master_breakpoint): Use all_objfiles.
16541         * linux-thread-db.c (try_thread_db_load_from_pdir)
16542         (has_libpthread): Use all_objfiles.
16543         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16544         * linespec.c (iterate_over_all_matching_symtabs)
16545         (search_minsyms_for_name): Use all_objfiles.
16546         * maint.c (maintenance_info_sections): Use all_objfiles.
16547         * main.c (captured_main_1): Use all_objfiles.
16548         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16549         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16550         * guile/scm-pretty-print.c
16551         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16552         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16553         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16554         (maintenance_print_msymbols): Use all_objfiles.
16555         * source.c (select_source_symtab): Use all_objfiles.
16556         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16557         * symfile.c (remove_symbol_file_command)
16558         (expand_symtabs_matching, map_symbol_filenames): Use
16559         all_objfiles.
16560         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16561         all_objfiles.
16562         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16563         * objc-lang.c (find_methods): Use all_objfiles.
16564         * objfiles.c (have_partial_symbols, have_full_symbols)
16565         (have_minimal_symbols, qsort_cmp)
16566         (default_iterate_over_objfiles_in_search_order): Use
16567         all_objfiles.
16568         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16569         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16570         (maintenance_check_psymtabs): Use all_objfiles.
16571         (ALL_PSYMTABS): Remove.
16572         * compile/compile-object-run.c (do_module_cleanup): Use
16573         all_objfiles.
16574         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16575         * cp-support.c (add_symbol_overload_list_qualified): Use
16576         all_objfiles.
16577         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16578         Use all_objfiles.
16579         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16580         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16581         all_objfiles.
16582         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16583         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16584         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16585         Uses all_objfiles.
16586         * solib.c (solib_read_symbols): Use all_objfiles
16587
16588 2019-01-09  Tom Tromey  <tom@tromey.com>
16589
16590         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16591         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16592         all_objfiles.
16593         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16594         * symmisc.c (print_symbol_bcache_statistics)
16595         (print_objfile_statistics, maintenance_print_objfiles)
16596         (maintenance_info_symtabs, maintenance_check_symtabs)
16597         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16598         all_objfiles.
16599         * source.c (forget_cached_source_info): Use all_objfiles.
16600         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16601         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16602         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16603         * objfiles.c (update_section_map): Use all_objfiles.
16604         (shared_objfile_contains_address_p): Likewise.
16605         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16606         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16607
16608 2019-01-09  Tom Tromey  <tom@tromey.com>
16609
16610         * common/next-iterator.h: New file.
16611         * objfiles.h (class all_objfiles): New.
16612         (struct objfile_iterator): New.
16613
16614 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16615
16616         * NEWS: Move the description of the changed "frame", "select-frame",
16617          and "info frame" commands to the Changed commands section.
16618
16619 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16620
16621         * gdbtypes.c (check_stub_method_group): Remove handling of old
16622         mangling schemes.
16623         * linespec.c (find_methods): Likewise.
16624         * stabsread.c (read_member_functions): Likewise.
16625         * valops.c (search_struct_method): Likewise.
16626         (value_struct_elt_for_reference): Likewise.
16627         * NEWS: Mention this change.
16628
16629 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16630
16631         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16632         print_source_lines.
16633         * source.c (print_source_lines_base): Update line number check.
16634         (print_source_lines): New function.
16635         (source_lines_range::source_lines_range): New function.
16636         * source.h (class source_lines_range): New class.
16637         (print_source_lines): New declaration.
16638
16639 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16640
16641         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16642
16643 2019-01-08  Tom Tromey  <tom@tromey.com>
16644             Simon Marchi  <simon.marchi@ericsson.com>
16645
16646         PR gdb/24060
16647         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16648         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16649         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16650         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16651         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16652         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16653
16654 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16655
16656         * source.c (select_source_symtab): Move header comment to
16657         declaration in source.h.
16658         (forget_cached_source_info_for_objfile): Likewise.
16659         (forget_cached_source_info): Likewise.
16660         (identify_source_line): Likewise.
16661         * source.h (identify_source_line): Move declaration from symtab.h
16662         and add comment from source.c
16663         (print_source_lines): Likewise.
16664         (forget_cached_source_info_for_objfile): Likewise.
16665         (forget_cached_source_info): Likewise.
16666         (select_source_symtab): Likewise.
16667         (enum print_source_lines_flag): Move definition from symtab.h.
16668         * symtab.h (identify_source_line): Move declaration to source.h.
16669         (print_source_lines): Likewise.
16670         (forget_cached_source_info_for_objfile): Likewise.
16671         (forget_cached_source_info): Likewise.
16672         (select_source_symtab): Likewise.
16673         (enum print_source_lines_flag): Move definition to source.h.
16674         * tui/tui-hooks.c: Add 'source.h' include.
16675
16676 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16677
16678         * source.c (print_source_lines_base): Handle requests to print
16679         reverse line number sequences, and guard against empty lines
16680         string.
16681
16682 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16683
16684         * source.c (print_source_lines_base): Fix skip of '\r' if next
16685         character is '\n'.
16686
16687 2019-01-06  Tom Tromey  <tom@tromey.com>
16688
16689         * c-exp.y (struct c_parse_state) <macro_original_text,
16690         expansion_obstack>: New member.
16691         (macro_original_text, expansion_obstack): Remove globals.
16692         (scan_macro_expansion, scanning_macro_expansion)
16693         (finished_macro_expansion): Update.
16694         (scan_macro_cleanup): Remove.
16695         (yylex, c_parse): Update.
16696
16697 2019-01-06  Tom Tromey  <tom@tromey.com>
16698
16699         * c-exp.y (struct c_parse_state) <strings>: New member.
16700         (operator_stoken): Update.
16701
16702 2019-01-06  Tom Tromey  <tom@tromey.com>
16703
16704         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16705         (union type_stack_elt) <typelist_val>: Now a pointer to
16706         std::vector.
16707         (type_stack_cleanup): Don't declare.
16708         (push_typelist): Update.
16709         * parse.c (pop_typelist): Return a std::vector.
16710         (push_typelist): Take a std::vector.
16711         (follow_types): Update.  Do not free args.
16712         (type_stack_cleanup): Remove.
16713         * c-exp.y (struct c_parse_state): New.
16714         (cpstate): New global.
16715         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16716         (nonempty_typelist): Update.
16717         (func_mod): Create a new vector.
16718         (c_parse): Create a c_parse_state.
16719         (check_parameter_typelist): Do not delete params.
16720         (function_method): Update.  Do not delete type_list.
16721
16722 2019-01-06  Tom Tromey  <tom@tromey.com>
16723
16724         PR gdb/28155:
16725         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16726         check_typedef.
16727         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16728         (print_return_value): Likewise.
16729
16730 2019-01-05  Tom Tromey  <tom@tromey.com>
16731
16732         * contrib/cleanup_check.py: Remove.
16733         * contrib/gcc-with-excheck: Remove.
16734         * contrib/exsummary.py: Remove.
16735         * contrib/excheck.py: Remove.
16736
16737 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16738
16739         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16740         NULL. Initialize tpprev to NULL instead of assigning it
16741         to NULL on the next statement.
16742         * windows-nat.c (windows_delete_thread): Remove check for
16743         main_thread_id before printing thread exit notifications.
16744         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16745         Remove thread ID check against main_thread_id.
16746         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16747         windows_delete_thread.
16748         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16749
16750 2019-01-04  Tom Tromey  <tom@tromey.com>
16751
16752         * compile/compile.c (_initialize_compile): Use upper case for
16753         metasyntactic variables.
16754         * symmisc.c (_initialize_symmisc): Use upper case for
16755         metasyntactic variables.
16756         * psymtab.c (_initialize_psymtab): Use upper case for
16757         metasyntactic variables.
16758         * demangle.c (demangle_command): Use upper case for metasyntactic
16759         variables.
16760         (_initialize_demangler): Likewise.
16761         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16762         variables.
16763
16764 2019-01-03  Tom Tromey  <tom@tromey.com>
16765
16766         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16767
16768 2019-01-03  Tom Tromey  <tom@tromey.com>
16769
16770         * python/py-symtab.c (salpy_str): Update.
16771         (struct salpy_sal_object) <symtab>: Now a PyObject.
16772         (salpy_dealloc): Update.
16773         (del_objfile_sal): Use gdbpy_ref.
16774
16775 2019-01-03  Tom Tromey  <tom@tromey.com>
16776
16777         * python/py-type.c (convert_field): Use new_reference.  Return
16778         gdbpy_ref.
16779         (make_fielditem): Return gdbpy_ref.
16780         (typy_fields): Update.
16781         (typy_getitem): Update.
16782         (field_name): Return gdbpy_ref.  Use new_reference.
16783         (typy_iterator_iternext): Update.
16784
16785 2019-01-03  Tom Tromey  <tom@tromey.com>
16786
16787         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16788
16789 2019-01-03  Tom Tromey  <tom@tromey.com>
16790
16791         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16792         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16793         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16794         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16795         (pspy_set_type_printers): Likewise.
16796         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16797         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16798         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16799         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16800         (objfpy_set_type_printers): Likewise.
16801
16802 2019-01-03  Tom Tromey  <tom@tromey.com>
16803
16804         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16805         (gdbpy_print_stack): Use gdbpy_err_fetch.
16806         * python/python-internal.h (class gdbpy_err_fetch): New class.
16807         (class gdbpy_enter) <m_error_type, m_error_value,
16808         m_error_traceback>: Remove.
16809         <m_error>: New member.
16810         (gdbpy_exception_to_string): Don't declare.
16811         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16812         * python/py-value.c (convert_value_from_python): Use
16813         gdbpy_err_fetch.
16814         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16815         gdbpy_exception_to_string.
16816         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16817         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16818         gdbpy_err_fetch.
16819
16820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16821
16822         * linux-nat.c (delete_lwp_cleanup): Delete.
16823         (struct lwp_deleter): New struct.
16824         (lwp_info_up): New typedef.
16825         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16826         lwp_info_up.
16827
16828 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16829
16830         * linux-fork.c (class scoped_switch_fork_info): New class.
16831         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16832
16833 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16834
16835         * valops.c (find_overload_match): Remove use of null_cleanup, and
16836         calls to do_cleanups.
16837
16838 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16839
16840         * compile/compile-cplus-types.c
16841         (compile_cplus_instance::decl_name): Handle changes to
16842         cp_func_name.
16843         * cp-support.c (cp_func_name): Update header comment, update
16844         return type.
16845         * cp-support.h (cp_func_name): Update return type in declaration.
16846         * valops.c (find_overload_match): Move temp_func local to top
16847         level of function and change its type.  Use temp_func to hold and
16848         delete temporary string obtained from cp_func_name.
16849
16850 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16851
16852         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16853         gdb::char_vector, remove cleanup, and update uses of `msg`.
16854
16855 2019-01-03  Jim Wilson  <jimw@sifive.com>
16856
16857         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16858
16859 2019-01-02  Tom Tromey  <tom@tromey.com>
16860
16861         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16862         (tdesc_parse_xml): Remove cleanups.
16863         * target-descriptions.h (make_cleanup_free_target_description):
16864         Don't declare.
16865         (target_desc_deleter): New struct.
16866         (target_desc_up): New typedef.
16867         * target-descriptions.c (target_desc_deleter::operator()): Rename
16868         from free_target_description.
16869         (make_cleanup_free_target_description): Remove.
16870
16871 2019-01-02  Tom Tromey  <tom@tromey.com>
16872
16873         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16874         constructor, destructor.
16875         (linespec_parser): Remove typedef.
16876         (~linespec_parser): Rename from linespec_parser_delete.
16877         (linespec_lex_to_end, linespec_complete_label)
16878         (linespec_complete): Update.
16879         (decode_line_full): Remove cleanups.
16880         (decode_line_1): Update.
16881
16882 2019-01-02  Tom Tromey  <tom@tromey.com>
16883
16884         * python/python-internal.h (inferior_to_inferior_object): Change
16885         return type.
16886         * python/py-exitedevent.c (create_exited_event_object): Update.
16887         * python/py-inferior.c (inferior_to_inferior_object): Return
16888         gdbpy_ref.
16889         (python_new_inferior, python_inferior_deleted)
16890         (thread_to_thread_object, delete_thread_object)
16891         (build_inferior_list, gdbpy_selected_inferior): Update.
16892         * python/py-infthread.c (create_thread_object): Update.  Also fail
16893         if inferior_to_inferior_object fails.
16894
16895 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16896
16897         * inferior.h (class inferior) <displaced_step_state>: New field.
16898         * infrun.h (struct displaced_step_state): Move here from
16899         infrun.c.  Initialize fields, add constructor.
16900         <inf>: Remove field.
16901         <reset>: New method.
16902         * infrun.c (struct displaced_step_inferior_state): Move to
16903         infrun.h.
16904         (displaced_step_inferior_states): Remove.
16905         (get_displaced_stepping_state): Adust.
16906         (displaced_step_in_progress_any_inferior): Adjust.
16907         (displaced_step_in_progress_thread): Adjust.
16908         (displaced_step_in_progress): Adjust.
16909         (add_displaced_stepping_state): Remove.
16910         (get_displaced_step_closure_by_addr): Adjust.
16911         (remove_displaced_stepping_state): Remove.
16912         (infrun_inferior_exit): Call displaced_step_state.reset.
16913         (use_displaced_stepping): Don't check for NULL.
16914         (displaced_step_prepare_throw): Call
16915         get_displaced_stepping_state.
16916         (displaced_step_fixup): Don't check for NULL.
16917         (prepare_for_detach): Don't check for NULL.
16918
16919 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16920
16921         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16922          in case of call that did not complete.
16923
16924 2019-01-02  Andrey Utkin  <autkin@undo.io>
16925
16926         * symfile.c (find_separate_debug_file): Fix search of debug files for
16927         remote debuggee.
16928
16929 2019-01-02  Tom Tromey  <tom@tromey.com>
16930
16931         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16932         indentation.
16933         * python/py-frame.c (frapy_older): Remove cast.
16934         (frapy_newer): Likewise.
16935         * python/py-breakpoint.c (local_setattro): Remove cast.
16936         * python/py-arch.c (archpy_name): Remove local variable.
16937         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16938
16939 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16940
16941         * unittests/basic_string_view/element_access/char/empty.cc:
16942         Fix year range in copyright header.
16943
16944 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16945
16946         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16947         Delete.
16948         <operator==>: Update with for removed field.
16949         <hash>: Likewise.
16950         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16951         <isa_features>: ...this.
16952         <abi_features>: New field.
16953         (riscv_isa_flen): Update comment.
16954         (riscv_abi_xlen): New declaration.
16955         (riscv_abi_flen): New declaration.
16956         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16957         isa_features.
16958         (riscv_abi_xlen): New function.
16959         (riscv_isa_flen): Update to get answer from isa_features.
16960         (riscv_abi_flen): New function.
16961         (riscv_has_fp_abi): Update to get answer from abi_features.
16962         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16963         xlen and flen.
16964         (riscv_call_info) <xlen, flen>: Update comment.
16965         (riscv_call_arg_struct): Remove invalid assertions
16966         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16967         is removed.
16968         (riscv_gdbarch_init): Gather isa features and abi features
16969         separately, ensure both match on the gdbarch when reusing an old
16970         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16971         a target with 64-bit float hardware.
16972
16973 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16974
16975         * source.c (search_command_helper): Stop reverse search
16976         when line 1 has been searched.
16977
16978 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16979
16980         * record-full.c (record_full_base_target::close): Rewrite
16981         record_full_core_buf_list free logic.
16982
16983 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16984
16985         * break-catch-syscall.c (print_one_catch_syscall): xfree
16986         the last text.
16987
16988 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16989
16990         * top.c (print_gdb_version): Update Copyright year in version
16991         message.
16992
16993 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16994
16995         Update copyright year range in all GDB files.
16996
16997 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16998
16999         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17000
17001 For older changes see ChangeLog-2018.
17002 \f
17003 Local Variables:
17004 mode: change-log
17005 left-margin: 8
17006 fill-column: 74
17007 version-control: never
17008 coding: utf-8
17009 End:
17010