gdb/ChangeLog

   1 2019-07-03  Pedro Alves  <palves@redhat.com>
   2
   3         * maint-test-settings.c: Fix file's intro comment.  Replace all
   4         references to "test-options" with references to "test-settings",
   5         in comments.
   6
   7 2019-07-03  Pedro Alves  <palves@redhat.com>
   8
   9         * maint-test-settings.c (maintenance_test_settings_xxx)
  10         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
  11         New.
  12         (maintenance_test_settings_enums): Use them.
  13         (maintenance_test_settings_enum): Default to
  14         maintenance_test_settings_xxx.
  15         (_initialize_maint_test_settings): Initialize
  16         MAINTENANCE_TEST_SETTINGS_FILENAME.
  17
  18 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  19
  20         * breakpoint.h (remove_breakpoints_inf): Change return type to
  21         void, move function documentation here.
  22         * breakpoint.c (remove_breakpoints_inf): Change return type to
  23         void, move function documentation to header.
  24
  25 2019-07-02  Pedro Alves  <palves@redhat.com>
  26
  27         * NEWS (Completion improvements): Mention "info threads".
  28         * thread.c (struct info_threads_opts, info_threads_option_defs)
  29         (make_info_threads_options_def_group): New.
  30         (info_threads_command): Use gdb::option::process_options.
  31         (info_threads_command_completer): New.
  32         (_initialize_thread): Use gdb::option::build_help to build the
  33         help text for "info threads".
  34
  35 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  36
  37         * defs.h (generic_load): Move from here...
  38         * symfile.h (generic_load): ... to here.  Rename name parameter
  39         to args.
  40         * symfile.c (generic_load): Add comment.
  41
  42 2019-07-01  Tom Tromey  <tromey@adacore.com>
  43
  44         * dwarf2read.c
  45         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  46         declaration of without_params.  Fix formatting.
  47
  48 2019-07-01  Tom Tromey  <tromey@adacore.com>
  49
  50         * ada-exp.y (find_primitive_type): Update.
  51         * ada-lang.h (ada_lookup_symbol): Update.
  52         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
  53         parameter.
  54         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
  55
  56 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  57
  58         PR breakpoints/24541
  59         * gdbarch.c: Regenerate.
  60         * gdbarch.h: Regenerate.
  61         * gdbarch.sh: Add 'stap_adjust_register'.
  62         * i386-tdep.c: Include '<unordered_set>'.
  63         (i386_stap_adjust_register): New function.
  64         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  65         * stap-probe.c (stap_parse_register_operand): Call
  66         'gdbarch_stap_adjust_register'.
  67
  68 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  69
  70         PR python/24742
  71         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  72         * python/python.c (do_start_initialization): Use 'xmalloc'
  73         instead of 'PyMem_Malloc'.
  74
  75 2019-06-28  Tom Tromey  <tromey@adacore.com>
  76
  77         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  78         for Ada.
  79
  80 2019-06-27  Tom Tromey  <tromey@adacore.com>
  81
  82         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  83         objfile_key.
  84         (arm_find_mapping_symbol, arm_record_special_symbol)
  85         (_initialize_arm_tdep): Update.
  86         (arm_objfile_data_free): Remove.
  87
  88 2019-06-27  Tom Tromey  <tromey@adacore.com>
  89
  90         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  91         to cp_print_static_field.
  92
  93 2019-06-26  Tom Tromey  <tromey@adacore.com>
  94
  95         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  96         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  97         declare.
  98
  99 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 100
 101         * features/aarch64-core.c (create_feature_aarch64_core):
 102         Regenerate.
 103         * features/aarch64-core.xml: Add cpsr flags.
 104
 105 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 106
 107         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 108         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 109
 110 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 111
 112         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 113         field.
 114         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 115         use.
 116         (arm_record_special_symbol): Don't insert new symbol in sorted
 117         position, push it at the end.
 118
 119 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 120
 121         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 122         (arm_mapping_symbol_s): Remove.
 123         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 124         (arm_mapping_symbol_vec): New typedef.
 125         (struct arm_per_objfile): Add constructor.
 126         <section_maps>: Change type to
 127         std::unique_ptr<arm_mapping_symbol_vec[]>.
 128         (arm_compare_mapping_symbols): Remove.
 129         (arm_find_mapping_symbol): Adjust to section_maps type change.
 130         (arm_objfile_data_free): Call delete on arm_per_objfile.
 131         (arm_record_special_symbol): Adjust to section_maps type change.
 132         Allocate arm_per_objfile with new.
 133
 134 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 135
 136         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 137         with the command prefix.
 138
 139 2019-06-25  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 142         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 143
 144 2019-06-25  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 147         type.
 148         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 149         protected.
 150
 151 2019-06-25  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.c
 154         (tui_source_window_base::set_is_exec_point_at): Add check against
 155         LOA_ADDRESS.
 156
 157 2019-06-25  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-source.c (tui_set_source_content): Don't check before
 160         xfree.
 161         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 162
 163 2019-06-25  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-winsource.h (tui_update_source_window_as_is)
 166         (tui_alloc_source_buffer, tui_line_is_displayed)
 167         (tui_addr_is_displayed): Change type of win_info.
 168         * tui/tui-winsource.c (tui_update_source_window_as_is)
 169         (tui_clear_source_content, tui_show_source_line)
 170         (tui_show_source_content, tui_source_window_base::refill)
 171         (tui_source_window_base::set_is_exec_point_at)
 172         (tui_source_window_base::set_is_exec_point_at)
 173         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 174         (tui_alloc_source_buffer, tui_line_is_displayed)
 175         (tui_addr_is_displayed): Change type of win_info.  Update.
 176         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 177         (tui_source_window_base::do_make_visible_with_new_height):
 178         Update.
 179         * tui/tui-source.c (tui_set_source_content)
 180         (tui_set_source_content_nil)
 181         (tui_source_window::do_scroll_vertical): Update.
 182         * tui/tui-layout.c (show_layout): Update.
 183         * tui/tui-disasm.c (tui_set_disassem_content)
 184         (tui_disasm_window::do_scroll_vertical): Update.
 185         * tui/tui-data.h (tui_win_content): Remove.
 186         (struct tui_gen_win_info) <content, content_size>: Remove.
 187         (struct tui_source_element): Add initializers and destructor.
 188         (union tui_which_element, struct tui_win_element): Remove.
 189         (struct tui_source_window_base) <content>: New field.
 190         (struct tui_data_window): Remove destructor.
 191         (tui_alloc_content, tui_free_win_content)
 192         (tui_free_all_source_wins_content): Don't declare.
 193         * tui/tui-data.c (tui_initialize_static_data): Update.
 194         (init_content_element, tui_alloc_content): Remove.
 195         (~tui_gen_win_info): Update.
 196         (~tui_data_window, tui_free_all_source_wins_content)
 197         (tui_free_win_content, free_content, free_content_elements):
 198         Remove.
 199
 200 2019-06-25  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-winsource.h (tui_clear_source_content)
 203         (tui_erase_source_content, tui_show_source_content): Change type
 204         of win_info.
 205         * tui/tui-winsource.c (tui_clear_source_content)
 206         (tui_erase_source_content, tui_show_source_content): Change type
 207         of win_info.
 208         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 209         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 210         win_info.
 211         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 212         win_info.
 213         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 214
 215 2019-06-25  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-winsource.c (tui_clear_source_content)
 218         (tui_source_window_base::set_is_exec_point_at): Update.
 219         * tui/tui-source.c (tui_set_source_content_nil): Update.
 220         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 221         a bool.
 222         * tui/tui-data.c (init_content_element): Update.
 223
 224 2019-06-25  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 227         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 228         * tui/tui-layout.c (init_and_make_win): Update.
 229         * tui/tui.h (enum tui_win_type): Update.
 230         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 231         tui_win_is_auxillary.
 232         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 233         tui_win_is_auxillary.
 234
 235 2019-06-25  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 238         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 239         (tui_delete_data_content_windows, tui_display_all_data)
 240         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 241         Update.
 242         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 243         * tui/tui-regs.c (tui_last_regs_line_no)
 244         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 245         (tui_show_registers): Update.
 246         (tui_show_register_group): Return void.  Update.
 247         (tui_display_registers_from, tui_display_reg_element_at_line)
 248         (tui_display_registers_from_line, tui_check_register_values):
 249         Update.
 250         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 251         member.
 252         (struct tui_data_window) <regs_content>: Now a std::vector.
 253         <regs_content_count>: Remove.
 254         (tui_add_content_elements, tui_free_data_content): Don't declare.
 255         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 256         (init_content_element): Remove DATA_WIN case.  Add assert.
 257         (tui_add_content_elements): Remove.
 258         (tui_data_window): Update.
 259         (tui_free_data_content): Remove.
 260         (free_content_elements): Remove DATA_WIN case.
 261
 262 2019-06-25  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-data.c (tui_data_item_window): Update.
 265         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 266         * tui/tui-windata.c (tui_display_all_data)
 267         (tui_display_data_from_line): Update.
 268         (tui_check_data_values): Remove.
 269         * tui/tui-regs.c (tui_show_register_group)
 270         (tui_display_reg_element_at_line): Update.
 271         * tui/tui-hooks.c (tui_register_changed)
 272         (tui_refresh_frame_and_register_information): Call
 273         tui_check_register_values.
 274         * tui/tui-data.h (struct tui_data_window) <data_content,
 275         data_content_count, data_type>: Remove.
 276         (enum tui_data_type): Remove.
 277
 278         * tui/tui-data.c (tui_data_window::clear_detail)
 279         (~tui_data_window): Update.
 280
 281 2019-06-25  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 284         declare.
 285         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 286         Rename from tui_first_data_item_displayed.  Update.
 287         (tui_data_window::refresh_all)
 288         (tui_data_window::do_scroll_vertical): Update.
 289         * tui/tui-data.h (struct tui_data_window)
 290         <first_data_item_displayed>: Declare new method.
 291
 292 2019-06-25  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 295         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 296         contents...
 297         (tui_initialize_static_data): ...here.
 298
 299 2019-06-25  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 302         (tui_display_registers_from, tui_check_register_values): Update.
 303         (tui_display_register): Remove win_info parameter; update.
 304         (tui_get_register): Change type of parameters.
 305         * tui/tui-data.h (struct tui_data_element): Remove.
 306         (union tui_which_element) <data>: Remove.
 307         <data_window>: Change type.
 308         (struct tui_data_item_window): New.
 309         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 310         case.  Add assert.
 311         (~tui_data_item_window): New destructor.
 312         (free_content_elements): Remove DATA_ITEM_WIN case.
 313
 314 2019-06-25  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 317         Remove.
 318
 319 2019-06-25  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-data.h (struct tui_command_element): Remove.
 322         (union tui_which_element) <command>: Remove.
 323         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 324         assert.
 325         (free_content_elements): Remove CMD_WIN case.
 326
 327 2019-06-25  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-layout.c (tui_set_layout): Update.
 330         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 331         * tui/tui-data.c (layout_def): Update.
 332
 333 2019-06-25  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 337         (tui_source_window_base::set_new_height): Update.
 338         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 339         Update.
 340         (tui_set_locator_fullname, tui_set_locator_info)
 341         (tui_show_frame_info): Update.
 342         * tui/tui-source.c (tui_set_source_content)
 343         (tui_source_is_displayed): Update.
 344         * tui/tui-layout.c (show_source_disasm_command, show_data)
 345         (show_source_or_disasm_and_command): Update.
 346         * tui/tui-disasm.c (tui_set_disassem_content)
 347         (tui_get_begin_asm_address): Update.
 348         * tui/tui-data.h (struct tui_locator_element): Remove.
 349         (union tui_which_element) <locator>: Remove.
 350         (struct tui_locator_window): New.
 351         (tui_locator_win_info_ptr): Change return type.
 352         * tui/tui-data.c (_locator): Change type.
 353         (tui_locator_win_info_ptr): Change return type.
 354         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 355         (tui_alloc_content): Add assert.
 356
 357 2019-06-25  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-winsource.c
 360         (tui_exec_info_window::maybe_allocate_content): New method.
 361         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 362         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 363         (make_source_or_disasm_window): Add cast.
 364         * tui/tui-data.h (union tui_which_element) <simple_string>:
 365         Remove.
 366         (struct tui_source_info): New.
 367         (struct tui_source_window_base) <execution_info>: Change type.
 368         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 369         case, and add assert.
 370         (tui_alloc_content): Add assert.
 371
 372 2019-06-25  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 375         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 376         * tui/tui-data.c (tui_alloc_win_info): Remove.
 377
 378 2019-06-25  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 381         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 382         can_highlight.
 383
 384 2019-06-25  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 387         make_visible_with_new_height method.
 388         (tui_win_info::make_visible_with_new_height): New method.
 389         (tui_source_window_base::do_make_visible_with_new_height)
 390         (tui_data_window::do_make_visible_with_new_height)
 391         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 392         (make_visible_with_new_height): Remove.
 393         (tui_resize_all, tui_adjust_win_heights): Use
 394         make_visible_with_new_height method.
 395         * tui/tui-data.h (struct tui_win_info)
 396         <do_make_visible_with_new_height, make_visible_with_new_height>:
 397         New methods.
 398         (struct tui_source_window_base, struct tui_data_window)
 399         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 400         methods.
 401
 402 2019-06-25  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 405         method.
 406         (update_tab_width): Call update_tab_width method.
 407         * tui/tui-data.h (struct tui_win_info)
 408         (struct tui_source_window_base) <update_tab_width>: New methods.
 409
 410 2019-06-25  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 413         parameter.
 414         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 415         parameter.
 416         (tui_gen_win_info::make_visible): Update.
 417         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 418         parameter.
 419         * tui/tui-data.h (enum tui_box): New enum.
 420         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 421
 422 2019-06-25  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 425         init_and_make_win for EXEC_INFO_WIN.
 426         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 427         longer inline.
 428         (struct tui_win_info) <~tui_win_info>: Inline.
 429         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 430         Don't declare.
 431         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 432         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 433         Remove.
 434         (tui_initialize_static_data): Update.
 435         (~tui_gen_win_info): Handle more cleanup here.
 436         (~tui_source_window_base): Delete "execution_info".
 437         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 438
 439 2019-06-25  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-layout.c (make_command_window): Don't set
 442         can_highlight.
 443         (show_source_disasm_command): Call the reset method.
 444         (show_data): Don't set can_highlight.  Call the reset method.
 445         (tui_gen_win_info::reset): Rename from init_gen_win_info
 446         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 447         (show_source_or_disasm_and_command): Call the reset method.
 448         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 449         (struct tui_cmd_window): Set can_highlight.
 450
 451 2019-06-25  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 454         from make_visible.
 455         (tui_make_visible, tui_make_invisible): Rewrite.
 456         (tui_win_info::make_visible): Remove.
 457         (tui_source_window_base::make_visible): Update.
 458         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 459         method.  Moved from...
 460         (struct tui_win_info) <make_visible>: ...here.
 461
 462 2019-06-25  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-winsource.c
 465         (tui_source_window_base::do_scroll_horizontal): Remove direction
 466         parameter.
 467         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 468         direction parameter.
 469         * tui/tui-win.c (tui_win_info::forward_scroll)
 470         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 471         (tui_win_info::right_scroll): Update.
 472         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 473         direction parameter.
 474         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 475         direction parameter.
 476         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 477         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 478         Remove direction parameter.
 479         (struct tui_source_window_base, struct tui_source_window)
 480         (struct tui_disasm_window, struct tui_data_window)
 481         (struct tui_cmd_window): Update.
 482
 483 2019-06-25  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-winsource.h (tui_set_exec_info_content)
 486         (tui_show_exec_info_content, tui_erase_exec_info_content)
 487         (tui_clear_exec_info_content, tui_update_exec_info): Change
 488         argument to tui_source_window_base.
 489         * tui/tui-winsource.c (tui_set_exec_info_content)
 490         (tui_show_exec_info_content, tui_erase_exec_info_content)
 491         (tui_clear_exec_info_content, tui_update_exec_info): Change
 492         argument to tui_source_window_base.
 493
 494 2019-06-25  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 497         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 498
 499 2019-06-25  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 502         check.
 503
 504 2019-06-25  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 507         type to void.
 508         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 509         type to void.
 510         * tui/tui-source.c (tui_set_source_content): Update.
 511         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 512
 513 2019-06-25  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-win.c (window_name_completer, tui_set_focus)
 516         (tui_all_windows_info): Use name method.
 517         * tui/tui-data.h (struct tui_gen_win_info)
 518         (struct tui_source_window, struct tui_disasm_window)
 519         (struct tui_data_window, struct tui_cmd_window) <name>: New
 520         method.
 521         (tui_win_name): Don't declare.
 522         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 523         (tui_win_name): Remove.
 524
 525 2019-06-25  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-winsource.h (tui_update_source_window)
 528         (tui_update_source_window_as_is): Change parameter type.
 529         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 530         to be a tui_source_window_base.
 531         (tui_update_source_window_as_is): Likewise.
 532         * tui/tui-win.c (make_visible_with_new_height): Update.
 533
 534 2019-06-25  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.c (tui_erase_source_content)
 537         (tui_show_source_content, tui_show_exec_info_content)
 538         (tui_erase_exec_info_content): Use refresh_window method.
 539         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 540         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 541         from tui_refresh_win.
 542         (tui_data_window::refresh_window): New method.
 543         (tui_win_info::refresh, tui_source_window_base::refresh)
 544         (tui_refresh_all): Use refresh_window method.
 545         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 546         method.
 547         * tui/tui-regs.c (tui_display_register): Call refresh_window
 548         method.
 549         * tui/tui-layout.c (show_source_disasm_command)
 550         (show_source_or_disasm_and_command): Call refresh_window method.
 551         * tui/tui-data.h (struct tui_gen_win_info)
 552         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 553         New method.
 554
 555 2019-06-25  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui.c (tui_rl_other_window, tui_enable)
 558         (tui_is_window_visible, tui_get_command_dimension): Update.
 559         * tui/tui-winsource.c (tui_update_source_window_as_is)
 560         (tui_clear_source_content, tui_erase_source_content)
 561         (tui_show_source_line, tui_source_window_base::refill)
 562         (tui_source_window_base::do_scroll_horizontal)
 563         (tui_source_window_base::set_is_exec_point_at)
 564         (tui_update_breakpoint_info, tui_set_exec_info_content)
 565         (tui_alloc_source_buffer, tui_line_is_displayed)
 566         (tui_addr_is_displayed): Update.
 567         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 568         (tui_check_and_display_highlight_if_needed)
 569         (tui_win_info::make_visible, tui_win_info::refresh)
 570         (tui_refresh_all): Update.
 571         * tui/tui-windata.c (tui_first_data_item_displayed)
 572         (tui_delete_data_content_windows, tui_erase_data_content)
 573         (tui_display_all_data, tui_data_window::refresh_all)
 574         (tui_check_data_values): Update.
 575         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 576         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 577         (tui_win_info::backward_scroll, tui_refresh_all_win)
 578         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 579         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 580         (tui_source_window_base::set_new_height)
 581         (tui_data_window::set_new_height)
 582         (make_invisible_and_set_new_height)
 583         (make_visible_with_new_height, new_height_ok)
 584         (parse_scrolling_args): Update.
 585         * tui/tui-stack.c (tui_show_frame_info): Update.
 586         * tui/tui-source.c (tui_set_source_content)
 587         (tui_set_source_content_nil, tui_source_is_displayed)
 588         (tui_source_window::do_scroll_vertical): Update.
 589         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 590         (tui_display_registers_from, tui_display_reg_element_at_line)
 591         (tui_check_register_values, tui_reg_command): Update.
 592         * tui/tui-layout.c (tui_default_win_height)
 593         (show_source_disasm_command, show_data, init_and_make_win)
 594         (show_source_or_disasm_and_command): Update.
 595         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 596         (tui_redisplay_readline, tui_mld_flush)
 597         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 598         (tui_getc): Update.
 599         * tui/tui-disasm.c (tui_set_disassem_content)
 600         (tui_disasm_window::do_scroll_vertical): Update.
 601         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 602         Now virtual.
 603         (struct tui_win_info): Derive from tui_gen_win_info.
 604         <~tui_win_info>: Mark as override.
 605         <generic>: Remove member.
 606         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 607         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 608         (~tui_data_window, ~tui_win_info)
 609         (tui_free_all_source_wins_content): Update.
 610         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 611
 612 2019-06-25  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-layout.c (init_and_make_win): Use new.
 615         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 616         destructor, initializers.
 617         (tui_alloc_generic_win_info): Don't declare.
 618         * tui/tui-data.c (_locator): Add argument to constructor.
 619         (source_win, disasm_win): New globals.
 620         (exec_info): Remove.
 621         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 622         Update.
 623         (tui_alloc_generic_win_info): Remove.
 624         (init_content_element): Use new.
 625         (tui_win_info::tui_win_info): Update.
 626         (free_content_elements) <case DATA_WIN>: Use delete.
 627
 628 2019-06-25  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 631         * tui/tui-windata.c (tui_first_data_item_displayed)
 632         (tui_delete_data_content_windows): Update.
 633         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 634         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 635         (tui_display_registers_from, tui_check_register_values): Update.
 636         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 637         pointer.
 638         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 639         window.
 640         (tui_free_data_content): Update.
 641         (free_content_elements) <case DATA_WIN>: Free the window.
 642
 643 2019-06-25  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 646         Update.
 647         * tui/tui-layout.c (make_command_window)
 648         (show_source_disasm_command, show_data, init_and_make_win)
 649         (show_source_or_disasm_and_command): Update.
 650         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 651         method.
 652         <can_highight, is_highlighted>: Now bool.
 653         (tui_set_win_highlight): Don't declare.
 654         * tui/tui-data.c (tui_set_win_highlight): Remove.
 655
 656 2019-06-25  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-wingeneral.c (make_visible): Remove check of window
 659         type.
 660
 661 2019-06-25  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-win.c (tui_win_info::max_height)
 664         (tui_cmd_window::max_height): New methods.
 665         (new_height_ok): Call max_height.
 666         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 667         <max_height>: New method.
 668
 669 2019-06-25  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-win.c (tui_source_window_base::set_new_height)
 672         (tui_data_window::set_new_height): New methods.
 673         (make_invisible_and_set_new_height): Call set_new_height method.
 674         * tui/tui-data.h (struct tui_win_info)
 675         (struct tui_source_window_base, struct tui_data_window)
 676         <set_new_height>: New method.
 677
 678 2019-06-25  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 681         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 682         tui_refresh_data_win.
 683         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 684         method.
 685         (tui_refresh_all_win): Call the refresh_all method.
 686         (tui_set_focus): Likewise.
 687         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 688         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 689         Likewise.
 690
 691 2019-06-25  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-winsource.h (tui_refill_source_window)
 694         (tui_set_is_exec_point_at): Don't declare.
 695         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 696         (tui_source_window_base::refill): Rename from
 697         tui_refill_source_window.
 698         (tui_source_window_base::do_scroll_horizontal): Update.
 699         (tui_source_window_base::set_is_exec_point_at): Rename from
 700         tui_set_is_exec_point_at.
 701         (tui_update_all_breakpoint_info): Update.
 702         * tui/tui-stack.c (tui_show_frame_info): Update.
 703         * tui/tui-layout.c (show_data): Add cast.
 704         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 705         * tui/tui-data.h (struct tui_source_window_base) <refill,
 706         set_is_exec_point_at>: New methods.
 707         (tui_source_windows, tui_add_to_source_windows): Update types.
 708         (tui_add_to_source_windows): Remove redundant declaration.
 709         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 710         (tui_source_windows): Change return type.
 711         (tui_clear_source_windows_detail): Update.
 712         (tui_add_to_source_windows): Change type of parameter.
 713         (tui_free_all_source_wins_content): Update.
 714
 715 2019-06-25  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-wingeneral.c (tui_win_info::refresh)
 718         (tui_source_window_base::refresh): New methods.
 719         (tui_refresh_all): Call the refresh method.
 720         * tui/tui-data.h (struct tui_win_info)
 721         (struct tui_source_window_base) <refresh>: New method.
 722
 723 2019-06-25  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui.h (tui_is_window_visible): Return bool.
 726         * tui/tui.c (tui_is_window_visible): Return bool.
 727         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 728         (tui_make_visible, tui_make_invisible)
 729         (tui_win_info::make_visible)
 730         (tui_source_window_base::make_visible, make_all_visible)
 731         (tui_make_all_visible, tui_make_all_invisible): Update.
 732         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 733         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 734         bool.
 735         (struct tui_win_info, struct tui_source_window_base)
 736         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 737         * tui/tui-data.c (tui_init_generic_part): Update.
 738
 739 2019-06-25  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 742         (tui_source_window_base::make_visible): New methods.
 743         (make_all_visible): Make method call.
 744         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 745         (struct tui_source_window_base, struct tui_cmd_window): Override
 746         make_visible.
 747         (tui_win_is_source_type): Don't declare.
 748         * tui/tui-data.c (tui_win_is_source_type): Remove.
 749
 750 2019-06-25  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 753         NULL check.
 754
 755 2019-06-25  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 758         Inline constructor.  Add initializers for members.
 759         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 760         constructors; now inline in class.
 761
 762 2019-06-25  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-regs.c (tui_show_registers): Update.
 765         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 766         bool.
 767         * tui/tui-data.c (tui_data_window::clear_detail)
 768         (tui_data_window): Update.
 769
 770 2019-06-25  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-windata.c (tui_display_all_data)
 773         (tui_display_data_from_line, tui_display_data_from)
 774         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 775         Update.
 776         * tui/tui-regs.c (tui_last_regs_line_no)
 777         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 778         (tui_show_registers, tui_show_register_group)
 779         (tui_display_registers_from, tui_display_reg_element_at_line)
 780         (tui_display_registers_from_line, tui_check_register_values)
 781         (tui_reg_next, tui_reg_prev): Update.
 782         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 783         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 784         tui_data_window.
 785         (struct tui_win_info) <detail>: Remove.  Add new fields from
 786         tui_data_info.
 787         (TUI_DATA_WIN): Add cast.
 788         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 789         (~tui_data_window): Simplify.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-layout.c (show_source_disasm_command)
 794         (show_source_or_disasm_and_command): Update.
 795         * tui/tui-io.c (update_cmdwin_start_line)
 796         (tui_redisplay_readline): Update.
 797         * tui/tui-data.h (struct tui_command_info): Remove.
 798         (struct tui_win_info) <detail>: Remove command_info member.
 799         (struct tui_data_window) <start_line>: New member, from
 800         tui_command_info.
 801         (TUI_CMD_WIN): Add casts.
 802
 803 2019-06-25  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-winsource.c (tui_update_source_window)
 806         (tui_refill_source_window)
 807         (tui_source_window_base::do_scroll_horizontal)
 808         (tui_update_breakpoint_info, tui_set_exec_info_content)
 809         (tui_show_exec_info_content, tui_erase_exec_info_content)
 810         (tui_clear_exec_info_content): Update.
 811         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 812         Update.
 813         * tui/tui-win.c (make_invisible_and_set_new_height)
 814         (make_visible_with_new_height): Update.
 815         * tui/tui-source.c (tui_set_source_content)
 816         (tui_show_symtab_source): Update.
 817         * tui/tui-layout.c (extract_display_start_addr)
 818         (show_source_disasm_command, show_data)
 819         (make_source_or_disasm_window)
 820         (show_source_or_disasm_and_command): Update.
 821         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 822         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 823         "gdbarch".
 824         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 825         to tui_source_window_base.
 826         (struct tui_win_info) <detail>: Remove source_info member.
 827         (struct tui_source_window_base) <has_locator>: Inline.
 828         Move contents from tui_source_info; rename has_locator member to
 829         m_has_locator.
 830         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 831         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 832         header file.
 833         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 834         Simplify.
 835         (tui_free_all_source_wins_content): Cast to
 836         tui_source_window_base.
 837
 838 2019-06-25  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-win.c (make_invisible_and_set_new_height)
 841         (make_visible_with_new_height): Call has_locator method.
 842         * tui/tui-layout.c (show_source_disasm_command, show_data)
 843         (show_source_or_disasm_and_command): Update for bool change.
 844         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 845         (tui_win_info) <has_locator>: New method.
 846         (struct tui_source_window_base) <has_locator>: New method.
 847         (tui_win_has_locator): Don't declare.
 848         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 849         from tui_win_has_locator.
 850         (tui_source_window_base): Use false, not FALSE.
 851
 852 2019-06-25  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 855         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 856         clear_detail method directly.
 857         (tui_clear_win_detail): Remove.
 858
 859 2019-06-25  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 862         "this", not TUI_DISASM_WIN.
 863
 864 2019-06-25  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 867         declare.
 868         * tui/tui-winsource.c
 869         (tui_source_window_base::do_scroll_horizontal): Rename from
 870         tui_horizontal_source_scroll.
 871         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 872         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 873         from tui_vertical_data_scroll.
 874         * tui/tui-win.h (tui_scroll): Don't declare.
 875         * tui/tui-win.c (tui_win_info::forward_scroll)
 876         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 877         (tui_win_info::right_scroll): Rename and update.
 878         (tui_scroll_forward_command, tui_scroll_backward_command)
 879         (tui_scroll_left_command, tui_scroll_right_command): Update.
 880         (tui_scroll): Remove.
 881         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 882         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 883         from tui_vertical_source_scroll.
 884         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 885         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 886         from tui_vertical_disassem_scroll.
 887         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 888         do_scroll_horizontal>: New methods.
 889         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 890         Likewise.
 891         (struct tui_source_window_base): Add do_scroll_horizontal.
 892         (struct tui_source_window, struct tui_disasm_window): Add
 893         do_scroll_vertical.
 894         (struct tui_data_window, struct tui_cmd_window): Add
 895         do_scroll_horizontal and do_scroll_vertical.
 896         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 897
 898 2019-06-25  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-data.h (struct tui_source_window_base): New struct.
 901         (struct tui_source_window): Derive from tui_source_window_base.
 902         (struct tui_disasm_window): New struct.
 903         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 904         from tui_source_window::clear_detail.
 905         (tui_source_window_base): Rename from tui_source_window.
 906         (~tui_source_window_base): Rename from ~tui_source_window.
 907         (tui_alloc_win_info): Create a tui_disasm_window.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-data.h (struct tui_source_window)
 912         (struct tui_data_window): Declare destructors.
 913         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 914         destructors.
 915         (tui_win_info): Simplify.
 916
 917 2019-06-25  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-winsource.c (tui_display_main)
 920         (tui_update_source_windows_with_addr)
 921         (tui_update_all_breakpoint_info): Update.
 922         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 923         (new_height_ok, parse_scrolling_args): Update.
 924         * tui/tui-stack.c (tui_show_frame_info): Update.
 925         * tui/tui-data.h (struct tui_list): Remove.
 926         (tui_source_windows): Return a reference to a std::vector.
 927         * tui/tui-data.c (source_windows): Now a std::vector.
 928         (tui_source_windows): Change return type.
 929         (tui_clear_source_windows): Rewrite.
 930         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 931         (tui_free_all_source_wins_content): Rewrite.
 932
 933 2019-06-25  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 936         (struct tui_data_window, struct tui_cmd_window): Declare
 937         clear_detail method.
 938         * tui/tui-data.c (tui_source_window::clear_detail)
 939         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 940         methods.
 941         (tui_clear_win_detail): Simplify.
 942
 943 2019-06-25  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-layout.c (make_source_window, make_disasm_window)
 946         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 947         Return the new window.
 948         (show_source_disasm_command, show_data)
 949         (show_source_or_disasm_and_command): Update.
 950
 951 2019-06-25  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 954         parameter.  Return the new window.
 955         (show_source_disasm_command): Update and remove NULL check.
 956         (show_source_or_disasm_and_command): Update.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 961
 962 2019-06-25  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-data.h (struct tui_win_info): Make constructor
 965         protected.  Make destructor virtual.  Add initializers.
 966         (tui_source_window, tui_data_window, tui_cmd_window): New
 967         classes.
 968         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 969         constructor.  Add "type" parameter.
 970         (tui_source_window, tui_data_window, tui_cmd_window): New
 971         constructors.
 972         (tui_alloc_win_info): Instantiate the appropriate subclass.
 973
 974 2019-06-25  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-win.c (tui_resize_all): Use delete.
 977         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 978         destructor.
 979         (tui_free_window): Don't declare.
 980         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 981         Update.
 982
 983 2019-06-25  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-data.h (struct tui_win_info): Add constructor.
 986         * tui/tui-data.c (tui_alloc_win_info): Use new.
 987         (tui_free_window): Use delete.
 988
 989 2019-06-22  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 992         declare.
 993         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 994
 995 2019-06-22  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 998         declare.
 999         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1000
1001 2019-06-22  Tom de Vries  <tdevries@suse.de>
1002
1003         * dwarf2read.c (create_addrmap_from_aranges)
1004         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1005         instead of '%zu'.
1006
1007 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1008
1009         * dwarf2read.h (dwarf2_section_info_def): Remove.
1010         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1011         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1012         std::vector<dwarf2_section_info>.
1013         (struct dwo_file) <~dwo_file>: Remove.
1014         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1015         types field.
1016         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1017         (dwarf2_read_debug_names): Likewise.
1018         (create_debug_types_hash_table): Change parameter type to
1019         array_view, adjust code accordingly.
1020         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1021         (partial_die_info::fixup): Likewise.
1022         (determine_prefix): Likewise.
1023         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1024
1025 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1026
1027         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1028         gdb_bfd_ref_ptr.
1029         <~dwo_file>: Remove call to gdb_bfd_unref.
1030         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1031         gdb_bfd_ref_ptr::get.
1032
1033 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1034
1035         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1036         type to htab_up.
1037         * dwarf2read.c (struct dwo_file): Initialize fields.
1038         <~dwo_file>: New.
1039         (free_dwo_file): Remove, move content to ~dwo_file.
1040         (struct dwo_file_deleter): Remove.
1041         (dwo_file_up>: Remove custom deleter.
1042         (free_dwo_files): Remove.
1043         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1044         dwo_files.
1045         (process_skeletonless_type_units): Call unique_ptr::get.
1046         (allocate_dwo_file_hash_table): Add deleter to created hash
1047         table.  Change return type to htab_up.
1048         (lookup_dwo_file_slot): Don't memset dwo_file, call
1049         unique_ptr::get.
1050         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1051         (create_dwo_unit_in_dwp_v2): Likewise.
1052         (open_and_init_dwo_file): Likewise.
1053         (free_dwo_file_from_slot): Remove.
1054
1055 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1056
1057         * dwarf2read.h (struct dwarf2_section_info) <readin,
1058         is_virtual>: Change type to bool.
1059         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1060         true instead of 1.
1061
1062 2019-06-19  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-data.h (tui_init_content_element): Don't declare.
1065
1066 2019-06-19  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-data.h (tui_init_win_info): Don't declare.
1069
1070 2019-06-19  Tom de Vries  <tdevries@suse.de>
1071
1072         * dwarf2read.h (abstract_to_concrete): Change type to
1073         std::unordered_map<sect_offset, std::vector<sect_offset>,
1074         gdb::hash_enum<sect_offset>>.
1075
1076 2019-06-19  Tom Tromey  <tromey@adacore.com>
1077
1078         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1079         EVAL_AVOID_SIDE_EFFECTS specially.
1080
1081 2019-06-19  Tom Tromey  <tromey@adacore.com>
1082
1083         * source-cache.c (highlighter): New global.
1084         (source_cache::get_source_lines): Create a highlighter on demand.
1085
1086 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * defs.h (deprecated_interactive_hook): Delete declaration.
1089         * interps.c (clear_interpreter_hooks): Remove use of
1090         deprecated_interactive_hook.
1091         * top.c (deprecated_interactive_hook): Delete definition.
1092         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1093
1094 2019-06-18  Tom de Vries  <tdevries@suse.de>
1095
1096         PR gdb/24515
1097         * dwarf2read.h (abstract_to_concrete): Change type from
1098         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1099         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1100         * dwarf2read.c (read_variable): Update.
1101         (dwarf2_fetch_die_loc_sect_off): Update.
1102
1103 2019-06-17  Tom de Vries  <tdevries@suse.de>
1104
1105         PR gdb/24617
1106         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1107         accessing parent[parent_len - 1].
1108
1109 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1110
1111         PR gdb/24364
1112         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1113         call dtrace_process_dof with NULL dof.
1114
1115 2019-06-16  Tom de Vries  <tdevries@suse.de>
1116
1117         PR gdb/24445
1118         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1119
1120 2019-06-16  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1123         (make_all_visible): Use address of member.
1124
1125 2019-06-16  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1128         (tui_free_window, free_content, free_content_elements): Remove
1129         unnecessary cast.
1130         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1131         cast.
1132         * tui/tui-regs.c (tui_show_register_group)
1133         (tui_display_registers_from, tui_display_reg_element_at_line):
1134         Remove unnecessary cast.
1135
1136 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * linux-nat.c (normal_mask): Delete.
1139         (_initialize_linux_nat): Don't initialise normal_mask.
1140
1141 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1142
1143         PR gdb/24445
1144         * dwarf-index-write.h (write_psymtabs_to_index): Add
1145         dwz_basename parameter.
1146         * dwarf-index-write.c (write_gdbindex): Move file writing to
1147         write_gdbindex_1.  Change return type void.
1148         (assert_file_size): Move up, remove filename parameter.
1149         (write_gdbindex_1): New function.
1150         (write_debug_names): Change return type to void, call
1151         assert_file_size.
1152         (struct index_wip_file): New struct.
1153         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1154         file logic to index_wip_file.  Write index for dwz file if
1155         needed.
1156         (save_gdb_index_command): Pass basename of dwz file, if present.
1157         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1158         build-id of dwz file, if present.
1159         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1160         (dwarf2_get_dwz_file): Likewise.
1161         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1162         (dwarf2_get_dwz_file): Likewise.
1163
1164 2019-06-16  Tom Tromey  <tom@tromey.com>
1165
1166         * coffread.c (process_coff_symbol): Use xstrdup.
1167         * value.c (create_internalvar): Use xstrdup.
1168
1169 2019-06-16  Tom Tromey  <tom@tromey.com>
1170
1171         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1172         * breakpoint.c (stopin_command, stopat_command)
1173         (until_break_command, decode_location_default): Remove unnecessary
1174         cast.
1175         * utils.c (subset_compare): Remove unnecessary cast.
1176         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1177         cast.
1178         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1179         cast.
1180         * infcmd.c (path_command): Remove unnecessary cast.
1181         * coffread.c (decode_type): Remove unnecessary cast.
1182         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1183         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1184         * tui/tui-stack.c (tui_show_locator_content)
1185         (tui_show_frame_info): Remove unnecessary cast.
1186         * tui/tui-win.c (tui_scroll_forward_command)
1187         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1188         (parse_scrolling_args): Remove unnecessary cast.
1189         * tui/tui-data.c (init_win_info, tui_del_window)
1190         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1191         (free_content_elements): Remove unnecessary cast.
1192         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1193         unnecessary cast.
1194         * tui/tui-source.c (tui_set_source_content)
1195         (tui_vertical_source_scroll): Remove unnecessary cast.
1196         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1197         cast.
1198         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1199         * tui/tui-regs.c (tui_display_registers_from)
1200         (tui_display_register): Remove unnecessary cast.
1201         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1202         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1203         (make_visible): Remove unnecessary cast.
1204         * tui/tui-winsource.c (tui_erase_source_content)
1205         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1206         unnecessary cast.
1207         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1208         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1209         * stabsread.c (read_type, read_array_type, read_range_type):
1210         Remove unnecessary cast.
1211         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1212         (parse_symbol, parse_type, upgrade_type, parse_external)
1213         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1214         unnecessary cast.
1215         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1216
1217 2019-06-16  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-data.c (tui_alloc_generic_win_info)
1220         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1221         checks.
1222
1223 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1224             Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * f-typeprint.c (f_print_type): Don't return early for not
1227         associated or not allocated types.
1228         (f_type_print_varspec_suffix): Add print_rank parameter and print
1229         ranks of array types in case they dangling.
1230         (f_type_print_base): Add print_rank parameter.
1231
1232 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * NEWS: Mention new MI commands.
1235         * break-catch-throw.c (enum exception_event_kind): Move to
1236         breakpoint.h.
1237         (print_mention_exception_catchpoint): Output text as a single
1238         message.
1239         (catch_exception_command_1): Rename to...
1240         (catch_exception_event): ...this, make non-static, update header
1241         command, and change some parameter types.
1242         (catch_catch_command): Update for changes to
1243         catch_exception_command_1.
1244         (catch_throw_command): Likewise.
1245         (catch_rethrow_command): Likewise.
1246         * breakpoint.c (enum exception_event_kind): Delete.
1247         * breakpoint.h (enum exception_event_kind): Moved here from
1248         break-catch-throw.c.
1249         (catch_exception_event): Declare.
1250         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1251         (mi_cmd_catch_throw): New function.
1252         (mi_cmd_catch_rethrow): New function.
1253         (mi_cmd_catch_catch): New function.
1254         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1255         'catch-catch' entries.
1256         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1257         (mi_cmd_catch_rethrow): Declare.
1258         (mi_cmd_catch_catch): Declare.
1259
1260 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * annotate.c (annotate_source_line): Change return type to void,
1263         update implementation to match.
1264         * annotate.h (annotate_source_line): Change return type to void,
1265         update header comment.
1266         * stack.c (print_frame_info): Don't change what frame information
1267         is printed based on whether annotations are on or not.
1268
1269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1272         (annotate_source): Make static.
1273         (annotate_source_line): Moved from source.c and renamed from
1274         identify_source_line.  Update the return type.
1275         * annotate.h (annotate_source): Delete declaration.
1276         (annotate_source_line): Declaration moved from source.h, and
1277         renamed from identify_source_line.  Return type updated.
1278         * source.c (identify_source_line): Moved to annotate.c and renamed
1279         to annotate_source_line.
1280         (info_line_command): Remove check of annotation_level.
1281         * source.h (identify_source_line): Move declaration to annotate.h
1282         and rename to annotate_source_line.
1283         * stack.c: Add 'annotate.h' include.
1284         (print_frame_info): Remove check of annotation_level before
1285         calling annotate_source_line.
1286
1287 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * source-cache.c (source_cache::get_plain_source_lines): Use
1290         open_source_file_with_line_charpos instead of just
1291         open_source_file, remove call to find_source_lines.
1292         (source_cache::get_source_lines): Likewise.
1293         * source.c (find_source_lines): Make static.
1294         (get_filename_and_charpos): Renamed into...
1295         (open_source_file_with_line_charpos): ..this along with changes to
1296         return a scoped_fd, and some other minor clean ups.
1297         (identify_source_line): Use open_source_file_with_line_charpos.
1298         (search_command_helper): Use open_source_file_with_line_charpos
1299         instead of just open_source_file, remove call to
1300         find_source_lines.
1301         * source.h (open_source_file_with_line_charpos): Declare new
1302         function.
1303         (find_source_lines): Delete declaration.
1304
1305 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * source.c (get_filename_and_charpos): Remove fullname
1308         parameter.
1309         (identify_source_line): Update call to get_filename_and_charpos.
1310
1311 2019-06-14  Tom Tromey  <tromey@adacore.com>
1312
1313         PR gdb/24502:
1314         * ui-style.h (skip_ansi_escape): Update comment.
1315         * ui-file.h (class no_terminal_escape_file): New class.
1316         * ui-file.c (no_terminal_escape_file::write)
1317         (no_terminal_escape_file::puts): New methods.
1318         * cli/cli-logging.c (handle_redirections): Use
1319         no_terminal_escape_file.
1320
1321 2019-06-14  Tom Tromey  <tromey@adacore.com>
1322
1323         * NEWS: Move convenience variable news above Python news.
1324
1325 2019-06-14  Tom Tromey  <tom@tromey.com>
1326
1327         * gnulib: Move directory to top-level.
1328         * configure.ac: Don't configure gnulib.
1329         * configure: Rebuild.
1330         * common/common-defs.h: Use new path to gnulib.
1331         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1332         (GNULIB_H): Remove.
1333         (INCGNU): Look in new gnulib location.
1334         (HFILES_NO_SRCDIR): Remove gnulib files.
1335         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1336         (generated_files): Remove GNULIB_H.
1337         ($(LIBGNU), all-lib): Remove targets.
1338         (distclean): Don't mention GNULIB_BUILDDIR.
1339         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1340
1341 2019-06-14  Tom Tromey  <tromey@adacore.com>
1342
1343         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1344         Warn if symbol file does not provide any symbols.
1345
1346 2019-06-14  Tom Tromey  <tromey@adacore.com>
1347
1348         * source.c (find_and_open_source): Respect basenames_may_differ.
1349
1350 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * annotate.c (annotate_breakpoints_invalid): Make use of
1353         scoped_restore_terminal_state.
1354         (annotate_frames_invalid): Likewise.
1355
1356 2019-06-14  Tom Tromey  <tromey@adacore.com>
1357
1358         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1359         allow assignment to an internalvar.
1360
1361 2019-06-14  Tom Tromey  <tromey@adacore.com>
1362
1363         * ada-lex.l: Allow "_" in attribute names.
1364
1365 2019-06-14  Tom Tromey  <tromey@adacore.com>
1366
1367         PR gdb/24653:
1368         * regcache.c (registers_changed): Don't call alloca.
1369         * top.c (execute_command): Don't call alloca.
1370
1371 2019-06-13  Pedro Alves  <palves@redhat.com>
1372
1373         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1374         'expression'.  When parsing an expression, error out if there's
1375         junk after "unlimited".
1376         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1377         (do_set_command): Adjust calls to is_unlimited_literal.
1378
1379 2019-06-13  Pedro Alves  <palves@redhat.com>
1380
1381         * compile/compile.c (make_compile_options_def_group): Add braces
1382         around array_view initializer.
1383         * thread.c (make_thread_apply_all_options_def_group)
1384         (make_thread_apply_all_options_def_group): Likewise.
1385
1386 2019-06-13  Pedro Alves  <palves@redhat.com>
1387
1388         * NEWS (New commands): Mention "maint test-options
1389         require-delimiter", "maint test-options unknown-is-error", "maint
1390         test-options unknown-is-operand" and "maint show
1391         test-options-completion-result".
1392         (New command options, command completion): New section.
1393         (Completion improvements): New section.
1394         Mention that you can abbreviate "unlimited".
1395
1396 2019-06-13  Pedro Alves  <palves@redhat.com>
1397
1398         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1399         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1400         * unittests/cli-utils-selftests.c (test_parse_flags)
1401         (test_parse_flags_qcs): Delete.
1402         (test_cli_utils): Don't call deleted functions.
1403
1404 2019-06-13  Pedro Alves  <palves@redhat.com>
1405
1406         * thread.c: Include "cli/cli-option.h".
1407         (tp_array_compar_ascending): Global.
1408         (tp_array_compar): Delete function.
1409         (tp_array_compar_ascending, tp_array_compar_descending): New
1410         functions.
1411         (ascending_option_def, qcs_flag_option_def)
1412         (thr_qcs_flags_option_defs)
1413         (make_thread_apply_all_options_def_group)
1414         (make_thread_apply_options_def_group): New.
1415         (thread_apply_all_command): Use gdb::option::process_options.
1416         (thread_apply_command_completer)
1417         (thread_apply_all_command_completer): New.
1418         (thread_apply_command): Use gdb::option::process_options.
1419         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1420         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1421         to generate help text of "thread apply".  Adjust "taas"'s help.
1422         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1423         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1424
1425 2019-06-13  Pedro Alves  <palves@redhat.com>
1426
1427         * thread.c (thread_apply_command): Check for invalid TID with
1428         isdigit instead of !isalpha.
1429
1430 2019-06-13  Pedro Alves  <palves@redhat.com>
1431
1432         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1433         (validate_flags_qcs): New.
1434         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1435         (validate_flags_qcs): Declare.
1436         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1437         (make_frame_apply_options_def_group): New.
1438         (frame_apply_command_count): Process options with
1439         gdb::option::process_options.
1440         (frame_apply_completer): New.
1441         (frame_apply_level_completer, frame_apply_all_completer)
1442         (frame_apply_completer): New.
1443         (_initialize_stack): Update help of "frame apply", "frame apply
1444         level", "frame apply all" and "faas" to mention supported options
1445         and install command completers.
1446         * stack.h (frame_apply_all_completer): Declare.
1447         * thread.c: Include "stack.h".
1448         (tfaas_command): Add "--".
1449         (_initialize_thread): Update help "tfaas" to mention supported
1450         options and install command completer.
1451
1452 2019-06-13  Pedro Alves  <palves@redhat.com>
1453
1454         * completer.c (complete_nested_command_line): New.
1455         (gdb_completion_word_break_characters_throw): Add assertion.
1456         * completer.h (complete_nested_command_line): Declare.
1457
1458 2019-06-13  Pedro Alves  <palves@redhat.com>
1459
1460         * stack.c (parse_backtrace_qualifiers): New.
1461         (backtrace_command): Use it.
1462         (backtrace_command_completer): Complete on qualifiers.
1463
1464 2019-06-13  Pedro Alves  <palves@redhat.com>
1465
1466         * frame.c: Include "cli/cli-option.h.
1467         (user_set_backtrace_options): New.
1468         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1469         Delete.
1470         (get_prev_frame): Adjust.
1471         (boolean_option_def, uinteger_option_def)
1472         (set_backtrace_option_defs): New.
1473         (_initialize_frame): Adjust and use
1474         gdb::option::add_setshow_cmds_for_options to install "set
1475         backtrace past-main" and "set backtrace past-entry".
1476         * frame.h: Include "cli/cli-option.h".
1477         (struct frame_print_options): Forward declare.
1478         (print_frame_arguments_all, print_frame_arguments_scalars)
1479         (print_frame_arguments_none): Declare.
1480         (print_entry_values): Delete declaration.
1481         (struct frame_print_options, user_frame_print_options): New.
1482         (struct set_backtrace_options): New.
1483         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1484         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1485         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1486         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1487         (list_args_or_locals): Add frame_print_options parameter.
1488         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1489         * python/py-framefilter.c (enumerate_args): Pass down
1490         USER_FRAME_PRINT_OPTIONS.
1491         * stack.c: Include "cli/cli-option.h".
1492         (print_frame_arguments_all, print_frame_arguments_scalars)
1493         (print_frame_arguments_none): Declare.
1494         (print_raw_frame_arguments, print_entry_values): Delete.
1495         (user_frame_print_options): New.
1496         (boolean_option_def, enum_option_def, frame_print_option_defs):
1497         New.
1498         (struct backtrace_cmd_options): New.
1499         (bt_flag_option_def): New.
1500         (backtrace_command_option_defs): New.
1501         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1502         (print_frame_arg, read_frame_arg, print_frame_args)
1503         (print_frame_info, print_frame): Add frame_print_options parameter
1504         and use it.
1505         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1506         (backtrace_command_1): Add frame_print_options and
1507         backtrace_cmd_options parameters and use them.
1508         (make_backtrace_options_def_group): New.
1509         (backtrace_command): Process command options with
1510         gdb::option::process_options.
1511         (backtrace_command_completer): New.
1512         (_initialize_stack): Extend "backtrace"'s help to mention
1513         supported options.  Install completer for "backtrace".
1514         Install some settings commands with add_setshow_cmds_for_options.
1515
1516 2019-06-13  Pedro Alves  <palves@redhat.com>
1517
1518         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1519         and that "set/show print raw frame-arguments" are now deprecated.
1520
1521         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1522         command.
1523         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1524         * stack.c (_initialize_stack): Install "set/show print
1525         raw-frame-arguments", and deprecate "set/show print raw
1526         frame-arguments".
1527         * valprint.c (_initialize_valprint): Deprecate "set/show print
1528         raw".
1529
1530 2019-06-13  Pedro Alves  <palves@redhat.com>
1531
1532         * compile/compile.c (struct compile_options): New.
1533         (compile_flag_option_def, compile_command_option_defs)
1534         (make_compile_options_def_group): New.
1535         (compile_file_command): Handle options with
1536         gdb::option::process_options.
1537         (compile_file_command_completer): New function.
1538         (compile_code_command): Handle options with
1539         gdb::option::process_options.
1540         (compile_code_command_completer): New function.
1541         (_initialize_compiler): Install completers for "compile code" and
1542         "compile file".  Mention available options in "compile code" and
1543         "compile code"'s help.
1544         * completer.c (advance_to_completion_word): New, factored out from
1545         ...
1546         (advance_to_expression_complete_word_point): ... this.
1547         (advance_to_filename_complete_word_point): New.
1548         * completer.h (advance_to_filename_complete_word_point): New
1549         declaration.
1550
1551 2019-06-13  Pedro Alves  <palves@redhat.com>
1552
1553         * compile/compile.c: Include "cli/cli-option.h".
1554         (compile_print_value): Scope data pointer is now a
1555         value_print_options pointer; adjust.
1556         (compile_print_command): Process options.  Scope data pointer is
1557         now a value_print_options pointer; adjust.
1558         (_initialize_compile): Update "compile print"'s help to include
1559         supported options.  Install a completer for "compile print".
1560         * cp-valprint.c (show_vtblprint, show_objectprint)
1561         (show_static_field_print): Delete.
1562         (_initialize_cp_valprint): Don't install "set print
1563         static-members", "set print vtbl", "set print object" here.
1564         * printcmd.c: Include "cli/cli-option.h" and
1565         "common/gdb_optional.h".
1566         (print_command_parse_format): Rework to fill in a
1567         value_print_options instead of a format_data.
1568         (print_value): Change parameter type from format_data pointer to
1569         value_print_options reference.  Adjust.
1570         (print_command_1): Process options.  Adjust to pass down a
1571         value_print_options.
1572         (print_command_completer): New.
1573         (_initialize_printcmd): Install print_command_completer as
1574         handle_brkchars completer for the "print" command.  Update
1575         "print"'s help to include supported options.
1576         * valprint.c: Include "cli/cli-option.h".
1577         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1578         here from cp-valprint.c.
1579         (boolean_option_def, uinteger_option_def)
1580         (value_print_option_defs, make_value_print_options_def_group):
1581         New.  Use gdb::option::add_setshow_cmds_for_options to install
1582         "set print elements", "set print null-stop", "set print repeats",
1583         "set print pretty", "set print union", "set print array", "set
1584         print address", "set print symbol", "set print array-indexes".
1585         * valprint.h: Include <string> and "cli/cli-option.h".
1586         (make_value_print_options_def_group): Declare.
1587         (print_value): Change parameter type from format_data pointer to
1588         value_print_options reference.
1589         (print_command_completer): Declare.
1590
1591 2019-06-13  Pedro Alves  <palves@redhat.com>
1592
1593         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1594         (COMMON_SFILES): Add maint-test-settings.c.
1595         * cli/cli-decode.c (boolean_enums): New global, factored out from
1596         ...
1597         (add_setshow_boolean_cmd): ... here.
1598         * cli/cli-decode.h (boolean_enums): Declare.
1599         * cli/cli-option.c: New file.
1600         * cli/cli-option.h: New file.
1601         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1602         factored out from ...
1603         (parse_cli_boolean_value(const char *)): ... this.
1604         (is_unlimited_literal): Change parameter type to pointer to
1605         pointer.  Adjust and advance ARG pointer.
1606         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1607         (parse_cli_var_enum): New, factored out from ...
1608         (do_set_command): ... this.  Adjust.
1609         * cli/cli-setshow.h (parse_cli_boolean_value)
1610         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1611         (parse_cli_var_enum): Declare.
1612         * cli/cli-utils.c: Include "cli/cli-option.h".
1613         (get_ulongest): New.
1614         * cli/cli-utils.h (get_ulongest): Declare.
1615         (check_for_argument): New overloads.
1616         * maint-test-options.c: New file.
1617
1618 2019-06-13  Pedro Alves  <palves@redhat.com>
1619
1620         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1621         parse a range if "-" is at the end of the string.
1622
1623 2019-06-13  Pedro Alves  <palves@redhat.com>
1624
1625         * cli/cli-setshow.c (parse_auto_binary_operation)
1626         (parse_cli_boolean_value): Don't allow "o".
1627
1628 2019-06-13  Pedro Alves  <palves@redhat.com>
1629
1630         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1631         * NEWS: Mention maint test-settings KIND.
1632         * maint-test-settings.c: New file.
1633
1634 2019-06-13  Pedro Alves  <palves@redhat.com>
1635
1636         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1637         completer.
1638         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1639         "set" completers.
1640
1641 2019-06-13  Pedro Alves  <palves@redhat.com>
1642
1643         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1644         after item.
1645
1646 2019-06-13  Pedro Alves  <palves@redhat.com>
1647
1648         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1649
1650 2019-06-13  Pedro Alves <palves@redhat.com>
1651
1652         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1653         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1654         call.
1655         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1656         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1657         calls.
1658         (check_for_argument): Skip spaces after argument.
1659
1660 2019-06-13  Pedro Alves  <palves@redhat.com>
1661
1662         * thread.c (thread_apply_command): Adjust TID parsing.
1663         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1664         detected before end of string.
1665         (tid_is_in_list): Error out if LIST is invalid.
1666
1667 2019-06-13  Pedro Alves  <palves@redhat.com>
1668
1669         * completer.c (complete_line_internal_1): Rewind completion word
1670         point.
1671         (completion_tracker::advance_custom_word_point_by): Change
1672         parameter type to int.
1673         * completer.h (completion_tracker::advance_custom_word_point_by):
1674         Likewise.
1675
1676 2019-06-13  Pedro Alves  <palves@redhat.com>
1677
1678         * completer.c (advance_to_completion_word): Handle delimiters.
1679
1680 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1681
1682         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1683
1684 2019-06-11  Tom Tromey  <tom@tromey.com>
1685
1686         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1687         (xmalloc_failed): Move to alloc.c.
1688         * alloc.c: New file.
1689         * Makefile.in (COMMON_SFILES): Add alloc.c.
1690
1691 2019-06-11  Tom Tromey  <tom@tromey.com>
1692
1693         * nat/linux-waitpid.c: Don't include server.h.
1694         (linux_debug): Remove.
1695         (my_waitpid): Update.
1696
1697 2019-06-11  Tom Tromey  <tromey@adacore.com>
1698
1699         * infcall.c (_initialize_infcall): Remove trailing newline from
1700         help.
1701         * user-regs.c (_initialize_user_regs): Remove trailing newline
1702         from help.
1703         * typeprint.c (_initialize_typeprint): Remove trailing newline
1704         from help.
1705         * reverse.c (_initialize_reverse): Remove trailing newlines from
1706         help.
1707         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1708         from help.
1709         * language.c (add_set_language_command): Remove trailing newline
1710         from help.
1711         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1712         help.
1713         * disasm.c (_initialize_disasm): Remove trailing newline from
1714         help.
1715         * top.c (init_main): Remove trailing newline from help.
1716         * interps.c (_initialize_interpreter): Remove trailing newline
1717         from help.
1718         * btrace.c (_initialize_btrace): Remove trailing newlines from
1719         help.
1720         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1721         from help.
1722         * python/python.c (_initialize_python): Remove trailing newline
1723         from help.
1724         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1725         help.
1726         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1727         from help.  Reformat some text.
1728         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1729         from help.
1730         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1731         newline from help.
1732
1733 2019-06-11  Tom Tromey  <tromey@adacore.com>
1734
1735         * darwin-nat.c (darwin_decode_exception_message)
1736         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1737
1738 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * valops.c (value_slice): Check for not allocated or not
1741         associated values.
1742
1743 2019-06-10  Tom de Vries  <tdevries@suse.de>
1744
1745         PR gdb/24618
1746         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1747         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1748         invalid.
1749
1750 2019-06-10  Tom de Vries  <tdevries@suse.de>
1751
1752         PR gdb/24611
1753         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1754         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1755
1756 2019-06-10  Tom de Vries  <tdevries@suse.de>
1757
1758         PR symtab/24545
1759         * symtab.c (struct demangled_name_entry): Add language field.
1760         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1761         static minimal symbol".  Set and use language field.
1762
1763 2019-06-10  Tom Tromey  <tromey@adacore.com>
1764
1765         * ada-lang.c (_initialize_ada_language): Update help text.
1766
1767 2019-06-10  Tom Tromey  <tromey@adacore.com>
1768
1769         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1770         with a newline.
1771         * guile/guile.c (handle_boot_error): Don't end warning with a
1772         newline.
1773         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1774         warning with a newline.
1775         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1776         newline.
1777         (s12z_frame_cache): Likewise.
1778         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1779         a newline.
1780         * solib-svr4.c (disable_probes_interface): Don't end warning with
1781         a newline.
1782         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1783         newline.
1784         * python/python.c (do_finish_initialization): Don't end warning
1785         with a newline.
1786
1787 2019-06-10  Tom Tromey  <tom@tromey.com>
1788
1789         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1790         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1791         gdbpy_enter.
1792
1793 2019-06-10  Tom Tromey  <tromey@adacore.com>
1794
1795         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1796         data.
1797         (elf_new_init): Don't call stabsread_new_init.
1798         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1799         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1800         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1801
1802 2019-06-10  Tom de Vries  <tdevries@suse.de>
1803
1804         PR symtab/16264
1805         PR symtab/24517
1806         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1807
1808 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1809
1810         * source.c (find_and_open_source): Also rewrite relative file
1811         names.
1812
1813 2019-04-26  Amos Bird  <amosbird@gmail.com>
1814
1815         * annotate.c (annotate_thread_exited): Add "thread-exited"
1816         annotation.
1817
1818 2019-06-06  Tom Tromey  <tromey@adacore.com>
1819
1820         * maint.h (class scoped_command_stats): Use
1821         DISABLE_COPY_AND_ASSIGN.
1822         <print_time>: New method.
1823         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1824         print_time.
1825         (scoped_command_stats::print_time): New method.
1826
1827 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1828
1829         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1830         instructions of lengths 6 or 8 bytes.
1831
1832 2019-06-04  Pedro Alves  <palves@redhat.com>
1833
1834         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1835
1836         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1837         * breakpoint.c (condition_completer): Likewise.
1838         * cli/cli-dump.c (scan_expression): Likewise.
1839         * common/filestuff.c (mkdir_recursive): Likewise.
1840         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1841         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1842         (gdb_abspath): Likewise.
1843         * compile/compile-cplus-types.c
1844         (compile_cplus_instance::decl_name): Likewise.
1845         * completer.c (complete_explicit_location):
1846         (signal_completer, reg_or_group_completer_1): Likewise.
1847         * cp-support.c (cp_remove_params_if_any): Likewise.
1848         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1849         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1850         * infcmd.c (strip_bg_char): Likewise.
1851         * linespec.c (copy_token_string): Likewise.
1852         * mi/mi-main.c (output_cores): Likewise.
1853         * psymtab.c (psymtab_search_name):
1854         * symfile.c (test_set_ext_lang_command): Likewise.
1855         * target.c (target_fileio_read_stralloc): Likewise.
1856         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1857         * value.c (complete_internalvar): Likewise.
1858
1859 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1860
1861         Add objfile property to gdb.Type.
1862         * NEWS: Mention Python API addition.
1863         * python/py-type.c (typy_get_objfile): New method.
1864
1865 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1866
1867         * NEWS: Mention the new set|show style [title|highlight].
1868         Mention changes to "show style", "help" and "apropos".
1869
1870 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1871
1872         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1873         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1874         instead of print_help_for_command.
1875         (print_doc_of_command): New function.
1876         (help_list): Add 'apropos -v word' suggestion.
1877         (print_help_for_command): Style the command name using title style.
1878         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1879         (_initialize_cli_cmds): Describe -v in apropos_command help.
1880
1881 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1882
1883         * cli/cli-style.h (cli_style_option): Add name in constructor,
1884         add m_name class member, add constructor with intensity,
1885         add name class function.
1886         (cli_style_option::add_setshow_commands): Remove name argument.
1887         (highlight_style, title_style): New styles.
1888         * cli/cli-style.c (do_show): New function that shows a style
1889         characteristic styling the style name with itself.
1890         (set_style_name): New function.
1891         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1892         Update all callers according to the changes in cli/cli-style.h.
1893         * utils.h (fputs_highlighted): New function.
1894         * utils.c (fputs_highlighted): Likewise.
1895
1896 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1897
1898         * NEWS: Mention new pipe command and new convenience variables.
1899
1900 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1901
1902         * cli/cli-cmds.c (pipe_command): New function.
1903         (_initialize_cli_cmds): Call add_com for pipe_command.
1904         Define | as an alias for pipe.
1905         (exit_status_set_internal_vars): New function.
1906         (shell_escape): Call exit_status_set_internal_vars.
1907         cli/cli-decode.c (find_command_name_length): Recognize | as
1908         a single character command.
1909
1910 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1911
1912         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1913         top.c (execute_command_to_ui_file): New function, mostly a copy
1914         of execute_command_to_string.
1915         (execute_command_to_string): Implement by calling
1916         execute_command_to_ui_file.
1917
1918 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1919
1920         * top.h (saved_command_line): Remove declaration.
1921         * top.c (previous_saved_command_line, previous_repeat_arguments):
1922         New variables.
1923         (saved_command_line): Make static, define together with other
1924         'repeat variables'.
1925         (dont_repeat): Clear repeat_arguments.
1926         (repeat_previous, get_saved_command_line, save_command_line):
1927         New functions.
1928         (gdb_init): Initialize saved_command_line
1929         and previous_saved_command_line.
1930         * main.c (captured_main_1): Remove saved_command_line initialization.
1931         * event-top.c (handle_line_of_input): Update to use
1932         the new 'repeat' related functions instead of direct access to
1933         saved_command_line.
1934         * command.h (repeat_previous, get_saved_command_line,
1935         save_command_line): New declarations.
1936         (dont_repeat): Add comment.
1937
1938 2019-05-30  Tom Tromey  <tromey@adacore.com>
1939
1940         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1941         Fix comment.
1942         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1943
1944 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1945
1946         PR cli/24587
1947         * completer.c (complete): Initialize variable word.
1948
1949 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1950
1951         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1952         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1953         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1954         'body' is NULL to the outter 'if', protecting the '!is_define'
1955         situation as well.
1956
1957 2019-05-29  Tom Tromey  <tromey@adacore.com>
1958
1959         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1960         (dwarf_unknown): New function.
1961         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1962         (dwarf_type_encoding_name): Use dwarf_unknown.
1963
1964 2019-05-29  Tom Tromey  <tromey@adacore.com>
1965
1966         PR c++/20020:
1967         * cp-valprint.c (cp_print_value_fields): Call
1968         cp_print_static_field inside "try".
1969
1970 2019-05-29  Tom Tromey  <tromey@adacore.com>
1971
1972         * inflow.c (struct terminal_info): Add default operator=.
1973         * configure: Rebuild.
1974         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1975         -Wdeprecated-copy-dtor, -Wredundant-move.
1976
1977 2019-05-29  Tom Tromey  <tromey@adacore.com>
1978
1979         * NEWS: Add entry.
1980         * infcmd.c (print_return_value_1): Handle finish_print
1981         option.
1982         (show_print_finish): New function.
1983         (_initialize_infcmd): Add "set/show print finish" commands.
1984         * valprint.c (user_print_options): Initialize new member.
1985         * valprint.h (struct value_print_options) <finish_print>: New
1986         member.
1987
1988 2019-05-28  Tom Tromey  <tromey@adacore.com>
1989
1990         * ada-lang.c (ada_remove_Xbn_suffix)
1991         (find_old_style_renaming_symbol)
1992         (parse_old_style_renaming): Remove.
1993         (ada_find_renaming_symbol): Don't call
1994         find_old_style_renaming_symbol.
1995         (ada_is_renaming_symbol): Rename from
1996         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1997         bool.  Now static.
1998         (ada_read_var_value): Update and simplify.
1999         * ada-exp.y (write_var_or_type): Remove old code.
2000
2001 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2002
2003         * event-top.c: Remove include comment.
2004         * inflow.c (class scoped_ignore_sigttou): Move from here...
2005         * inflow.h (class scoped_ignore_sigttou): ...to here.
2006         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2007         * top.c:  Remove include comment.
2008
2009 2019-05-27  Tom Tromey  <tom@tromey.com>
2010
2011         * NEWS: Fix typo.
2012
2013 2019-05-22  Tom Tromey  <tromey@adacore.com>
2014
2015         * target.c (target_follow_exec): Constify parameter.
2016         * target-delegates.c: Rebuild.
2017         * remote.c (remote_target::follow_exec): Constify parameter.
2018         * infrun.c (follow_exec): Constify parameter.
2019         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2020         (target_follow_exec): Likewise.
2021
2022 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2023
2024         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2025         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2026
2027 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2028
2029         * NEWS: Add debugredirect and testsuite sections.
2030
2031 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2032
2033         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2034         target descriptions using exclusively floating point register name
2035         aliases.
2036
2037 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         PR gdb/18644:
2040         * f-lang.c (build_fortran_types): Handle the case where
2041         gdbarch_floatformat_for_type returns a nullptr.
2042
2043 2019-05-21  Tom de Vries  <tdevries@suse.de>
2044
2045         PR cli/24587
2046         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2047
2048 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         PR gdb/18644:
2051         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2052         16-byte floats.
2053         * i386-tdep.c (i386_floatformat_for_type): Use
2054         floatformats_ia64_quad for the 16-byte floating point component
2055         within a fortran 32-byte complex number.
2056
2057 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2060         delete default constructor.
2061         (find_partial_die): Update to return const struct.
2062         (partial_die_parent_scope): Move variable declaration into scope
2063         of its use and change its type to auto.
2064         (guess_partial_die_structure_name): Likewise.
2065         (partial_die_info::fixup): Likewise.
2066
2067 2019-05-17  Tom Tromey  <tromey@adacore.com>
2068
2069         * source.c (find_and_open_source): Remove cast.
2070
2071 2019-05-17  Tom Tromey  <tromey@adacore.com>
2072
2073         * annotate.c (annotate_source): Make "filename" const.
2074         * annotate.h (annotate_source): Use const.
2075
2076 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2077
2078         * disasm.c (set_disassembler_options): Send errors to stderr.
2079
2080 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2081
2082         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2083         (cli_interp_base::set_logging): Check debug_redirect.
2084         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2085         * cli/cli-logging.c (debug_redirect): Add static variable.
2086         (pop_output_files): Add default param.
2087         (handle_redirections): Print debug setting.
2088         (show_logging_command): Likewise.
2089         (_initialize_cli_logging): Add debugredirect command.
2090         * interps.c (current_interp_set_logging): Add debug_redirect
2091         parameter.
2092         * interps.h (set_logging): Add debug_redirect parameter.
2093         (current_interp_set_logging): Likewise.
2094         * mi/mi-common.h: Likewise.
2095         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2096
2097 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2098             Tom Tromey  <tromey@adacore.com>
2099
2100         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2101         directly.
2102         * cli/cli-interp.h (make_logging_output): Remove declaration.
2103         * cli/cli-logging.c (make_logging_output): Remove function.
2104         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2105         directly.
2106         * ui-file.c (tee_file::tee_file): Remove bools.
2107         (tee_file::~tee_file): Remove deletes.
2108         * ui-file.h (tee_file): Remove bools.
2109
2110 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2111
2112         * mi/mi-cmds.h (mi_cmd_complete): New function.
2113         * mi/mi-main.c (mi_cmd_complete): Likewise.
2114         * mi/mi-cmds.c: Define new MI command -complete.
2115         * NEWS: Mention new -complete command.
2116
2117 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2118
2119         * completer.h (complete): New function.
2120         * completer.c (complete): Likewise.
2121         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2122         function defined in completer.h.
2123
2124 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2125
2126         * MAINTAINERS (Write After Approval): Add myself.
2127
2128 2019-05-17  Tom de Vries  <tdevries@suse.de>
2129
2130         PR gdb/24094
2131         * dwarf2read.c (struct cu_partial_die_info): New struct.
2132         (find_partial_die): Return cu_partial_die_info.
2133         (partial_die_parent_scope, guess_partial_die_structure_name)
2134         (partial_die_info::fixup): Handle new return type of find_partial_die.
2135
2136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2137
2138         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2139         "std::string", simplifying the algorithm.
2140
2141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2142
2143         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2144         (stap_static_probe_ops::get_probes): Likewise.
2145
2146 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2147
2148         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2149         '-')" and "else if".
2150         (stap_parse_single_operand): Join checks for
2151         "gdbarch_stap_parse_special_token_p" and
2152         "gdbarch_stap_parse_special_token" in the same "if" statement.
2153         Invert check when verifying for operation on register
2154         displacement.
2155
2156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2157
2158         * stap-probe.c (stap_get_opcode): Update comment.
2159         (stap_get_expected_argument_type): Likewise.
2160         (handle_stap_probe): Likewise.
2161
2162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2163
2164         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2165         return type to 'bool'.  Adjust comment.  Use 'bool' when
2166         appropriate.
2167         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2168         * stap-probe.c (stap_parse_argument_1): Likewise.
2169         (stap_is_operator): Likewise.
2170         (stap_is_generic_prefix): Likewise.
2171         (stap_is_register_prefix): Likewise.
2172         (stap_is_register_indirection_prefix): Likewise.
2173         (stap_is_integer_prefix): Likewise.
2174         (stap_generic_check_suffix): Likewise.
2175         (stap_check_integer_suffix): Likewise.
2176         (stap_check_register_suffix): Likewise.
2177         (stap_check_register_indirection_suffix): Likewise.
2178         (stap_parse_register_operand): Likewise.
2179         (stap_parse_single_operand): Likewise.
2180         (stap_parse_argument_1): Likewise.
2181         (stap_probe::get_argument_count): Likewise.
2182         (stap_is_operator): Likewise.
2183
2184 2019-05-16  Tom Tromey  <tromey@adacore.com>
2185
2186         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2187         keyword to foreach.
2188
2189 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2190
2191         * linux-thread-db.c (try_thread_db_load_1): Change return type
2192         to bool.
2193         (try_thread_db_load): Likewise.
2194         (try_thread_db_load_from_pdir_1): Likewise.
2195         (try_thread_db_load_from_pdir): Likewise.
2196         (try_thread_db_load_from_sdir): Likewise.
2197         (try_thread_db_load_from_dir): Likewise.
2198         (thread_db_load_search): Likewise.
2199         (has_libpthread): Likewise.
2200         (thread_db_load): Likewise.
2201
2202 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2203
2204         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2205         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2206         NULL, and complain/return if that's the case.
2207
2208 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2209
2210         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2211         (advance, posn, abstract_read_memory): New functions.
2212         [struct mem_read_abstraction]: New struct.
2213         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2214
2215 2019-05-14  Tom Tromey  <tromey@adacore.com>
2216
2217         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2218         value is not lval_memory.
2219
2220 2019-05-14  Tom Tromey  <tromey@adacore.com>
2221
2222         * solib.c (info_sharedlibrary_command): Style the file name.
2223
2224 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2225
2226         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2227         (aarch64_vnv_type): Likewise.
2228         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2229         * common/tdesc.c: Likewise.
2230         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2231         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2232         * features/aarch64-fpu.xml: Add ieee half view.
2233         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2234         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2235         * gdbtypes.h (struct builtin_type): Likewise.
2236         (struct objfile_type): Likewise.
2237
2238 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2239
2240         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2241         typo.
2242         * location.h (string_to_event_location): Likewise.
2243
2244 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2245
2246         GDB 8.3 released.
2247
2248 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2249
2250         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2251         New variable declaration.
2252         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2253         New variable.
2254         (print_one_breakpoint): Use ui_out::test_flags and new global
2255         variable to compute use_fixed_output.
2256         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2257         Remove.
2258         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2259         (mi_multi_location_breakpoint_output_fixed): Remove.
2260         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2261         new variable.
2262         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2263         fix_multi_location_breakpoint_output flag if version >= 3.
2264         * ui-out.h (enum ui_out_flag)
2265         <fix_multi_location_breakpoint_output>: New enumerator.
2266
2267 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2268
2269         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2270
2271 2019-05-10  Tom Tromey  <tromey@adacore.com>
2272
2273         * ada-lang.c (catch_ada_completer): New function.
2274         (_initialize_ada_language): Use it.
2275
2276 2019-05-10  Tom Tromey  <tromey@adacore.com>
2277
2278         * thread.c (print_thread_info): Make "requested_threads" const.
2279         * gdbthread.h (print_thread_info): Make "requested_threads"
2280         const.
2281         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2282         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2283
2284 2019-05-08  Tom Tromey  <tom@tromey.com>
2285
2286         * gdbtypes.c (objfile_type_data): Change type.
2287         (objfile_type, _initialize_gdbtypes): Update.
2288
2289 2019-05-08  Tom Tromey  <tom@tromey.com>
2290
2291         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2292         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2293         (_initialize_dwarf2_frame): Update.
2294
2295 2019-05-08  Tom Tromey  <tom@tromey.com>
2296
2297         * objc-lang.c (objc_objfile_data): Change type.
2298         (find_methods): Update.
2299         (_initialize_objc_lang): Remove.
2300
2301 2019-05-08  Tom Tromey  <tom@tromey.com>
2302
2303         * stabsread.c (rs6000_builtin_type_data): Change type.
2304         (rs6000_builtin_type, _initialize_stabsread): Update.
2305
2306 2019-05-08  Tom Tromey  <tom@tromey.com>
2307
2308         * mips-tdep.c (mips_pdr_data): Remove.
2309         (_initialize_mips_tdep): Update.
2310
2311 2019-05-08  Tom Tromey  <tom@tromey.com>
2312
2313         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2314         (hppa_init_objfile_priv_data, read_unwind_info)
2315         (find_unwind_entry, _initialize_hppa_tdep): Update.
2316
2317 2019-05-08  Tom Tromey  <tom@tromey.com>
2318
2319         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2320         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2321         on obstack.
2322         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2323
2324 2019-05-08  Tom Tromey  <tom@tromey.com>
2325
2326         * mdebugread.c (basic_type_data): Change type.
2327         (basic_type, _initialize_mdebugread): Update.
2328
2329 2019-05-08  Tom Tromey  <tom@tromey.com>
2330
2331         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2332
2333 2019-05-08  Tom Tromey  <tom@tromey.com>
2334
2335         * nto-tdep.c (nto_inferior_data_reg): Change type.
2336         (nto_inferior_data): Update.
2337         (nto_inferior_data_cleanup, nto_new_inferior_data)
2338         (_initialize_nto_tdep): Remove.
2339         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2340
2341 2019-05-08  Tom Tromey  <tom@tromey.com>
2342
2343         * ada-lang.c (struct ada_inferior_data): Add initializers.
2344         (ada_inferior_data): Change type.
2345         (ada_inferior_data_cleanup): Remove.
2346         (get_ada_inferior_data, ada_inferior_exit)
2347         (struct ada_pspace_data): Add initializers, destructor.
2348         (ada_pspace_data_handle): Change type.
2349         (get_ada_pspace_data): Update.
2350         (ada_pspace_data_cleanup): Remove.
2351
2352 2019-05-08  Tom Tromey  <tom@tromey.com>
2353
2354         * coffread.c (struct coff_symfile_info): Add initializers.
2355         (coff_objfile_data_key): Move lower.  Change type.
2356         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2357         Update.
2358         (coff_free_info): Remove.
2359
2360 2019-05-08  Tom Tromey  <tom@tromey.com>
2361
2362         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2363         (fbsd_pspace_data_handle): Move lower.  Change type.
2364         (get_fbsd_pspace_data): Update.
2365         (fbsd_pspace_data_cleanup): Remove.
2366         (_initialize_fbsd_tdep): Update.
2367
2368 2019-05-08  Tom Tromey  <tom@tromey.com>
2369
2370         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2371         (get_ada_tasks_pspace_data): Update.
2372         (ada_tasks_pspace_data_cleanup): Remove.
2373         (_initialize_tasks): Update.
2374         (ada_tasks_inferior_data_handle): Change type.
2375         (get_ada_tasks_inferior_data): Update.
2376         (ada_tasks_inferior_data_cleanup): Remove.
2377         (struct ada_tasks_pspace_data): Add initializers.
2378
2379 2019-05-08  Tom Tromey  <tom@tromey.com>
2380
2381         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2382         * symfile-debug.c (debug_sym_get_probes): Change type.
2383         * stap-probe.c (handle_stap_probe):
2384         (stap_static_probe_ops::get_probes): Change type.
2385         * probe.h (class static_probe_ops) <get_probes>: Change type.
2386         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2387         (parse_probes_in_pspace): Update.
2388         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2389         Update.
2390         (any_static_probe_ops::get_probes): Change type.
2391         * elfread.c (elfread_data): New typedef.
2392         (probe_key): Change type.
2393         (elf_get_probes): Likewise.  Update.
2394         (probe_key_free): Remove.
2395         (_initialize_elfread): Update.
2396         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2397         Change type.
2398         (dtrace_process_dof_probe, dtrace_process_dof)
2399         (dtrace_static_probe_ops::get_probe): Change type.
2400
2401 2019-05-08  Tom Tromey  <tom@tromey.com>
2402
2403         * xcoffread.c (struct xcoff_symfile_info): Rename from
2404         coff_symfile_info.  Add initializers.
2405         (xcoff_objfile_data_key): Move lower.  Change type.
2406         (XCOFF_DATA): Rewrite.
2407         (xcoff_free_info): Remove.
2408         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2409         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2410         (xcoff_initial_scan): Update.
2411
2412 2019-05-08  Tom Tromey  <tom@tromey.com>
2413
2414         * solib-svr4.c (struct svr4_info): Add initializers and
2415         destructor.
2416         <probes_table>: Now an htab_up.
2417         (solib_svr4_pspace_data): Change type.
2418         (free_probes_table): Simplify.
2419         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2420         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2421         (probes_table_remove_objfile_probes, register_solib_event_probe)
2422         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2423         (_initialize_svr4_solib): Update.
2424
2425 2019-05-08  Tom Tromey  <tom@tromey.com>
2426
2427         * remote.c (remote_pspace_data): Change type.
2428         (remote_pspace_data_cleanup): Remove.
2429         (get_remote_exec_file, set_pspace_remote_exec_file)
2430         (_initialize_remote): Update.
2431
2432 2019-05-08  Tom Tromey  <tom@tromey.com>
2433
2434         * breakpoint.c (breakpoint_objfile_key): Change type.
2435         (get_breakpoint_objfile_data): Update.
2436         (free_breakpoint_objfile_data): Remove.
2437         (_initialize_breakpoint): Update.
2438
2439 2019-05-08  Tom Tromey  <tom@tromey.com>
2440
2441         * linux-tdep.c (struct linux_info): Add initializers.
2442         (linux_inferior_data): Move.  Change type.
2443         (invalidate_linux_cache_inf): Update.
2444         (linux_inferior_data_cleanup): Remove.
2445         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2446
2447 2019-05-08  Tom Tromey  <tom@tromey.com>
2448
2449         * auxv.c (auxv_inferior_data): Move.  Change type.
2450         (auxv_inferior_data_cleanup): Remove.
2451         (invalidate_auxv_cache_inf): Rewrite.
2452         (get_auxv_inferior_data, _initialize_auxv): Update.
2453
2454 2019-05-08  Tom Tromey  <tom@tromey.com>
2455
2456         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2457         (symfile_debug_objfile_data_key): Change type.
2458         (symfile_debug_installed, debug_qf_has_symbols)
2459         (debug_qf_find_last_source_symtab)
2460         (debug_qf_forget_cached_source_info)
2461         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2462         (debug_qf_print_stats, debug_qf_dump)
2463         (debug_qf_expand_symtabs_for_function)
2464         (debug_qf_expand_all_symtabs)
2465         (debug_qf_expand_symtabs_with_fullname)
2466         (debug_qf_map_matching_symbols)
2467         (debug_qf_expand_symtabs_matching)
2468         (debug_qf_find_pc_sect_compunit_symtab)
2469         (debug_qf_map_symbol_filenames)
2470         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2471         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2472         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2473         (debug_sym_read_linetable, debug_sym_relocate): Update.
2474         (symfile_debug_free_objfile): Remove.
2475         (install_symfile_debug_logging, _initialize_symfile_debug):
2476         Update.
2477
2478 2019-05-08  Tom Tromey  <tom@tromey.com>
2479
2480         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2481         allocate_on_obstack.
2482         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2483         (get_dwarf2_per_objfile): Update.
2484         (set_dwarf2_per_objfile): Remove.
2485         (dwarf2_has_info, dwarf2_get_section_info): Update.
2486         (dwarf2_free_objfile): Remove.
2487         (_initialize_dwarf2_read): Update.
2488
2489 2019-05-08  Tom Tromey  <tom@tromey.com>
2490
2491         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2492         initializers.
2493         <unsupported_script_warning_printed,
2494         script_not_found_warning_printed>: Now bool.
2495         (auto_load_pspace_data): Change type.
2496         (~auto_load_pspace_info): Rename from
2497         auto_load_pspace_data_cleanup.
2498         (get_auto_load_pspace_data, init_loaded_scripts_info)
2499         (clear_section_scripts, maybe_print_unsupported_script_warning)
2500         (maybe_print_script_not_found_warning, _initialize_auto_load):
2501         Update.
2502
2503 2019-05-08  Tom Tromey  <tom@tromey.com>
2504
2505         * objfiles.c (objfile_pspace_info): Add destructor and
2506         initializers.
2507         (objfiles_pspace_data): Change type.
2508         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2509         (get_objfile_pspace_data): Update.
2510         (objfiles_bfd_data): Change type.
2511         (get_objfile_bfd_data): Update.
2512         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2513
2514 2019-05-08  Tom Tromey  <tom@tromey.com>
2515
2516         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2517         Change type.
2518         (get_catch_syscall_inferior_data): Update.
2519         (catch_syscall_inferior_data_cleanup): Remove.
2520         (_initialize_break_catch_syscall): Update.
2521
2522 2019-05-08  Tom Tromey  <tom@tromey.com>
2523
2524         * inflow.c (struct terminal_info): Add destructor and
2525         initializers.
2526         (inflow_inferior_data): Change type.
2527         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2528         (get_inflow_inferior_data, inflow_inferior_exit)
2529         (swap_terminal_info, _initialize_inflow): Update.
2530
2531 2019-05-08  Tom Tromey  <tom@tromey.com>
2532
2533         * target-dcache.c (target_dcache_cleanup): Remove.
2534         (target_dcache_aspace_key): Change type.
2535         (target_dcache_init_p, target_dcache_invalidate)
2536         (target_dcache_get, target_dcache_get_or_init)
2537         (_initialize_target_dcache): Update.
2538         * dcache.h (struct dcache_deleter): New.
2539
2540 2019-05-08  Tom Tromey  <tom@tromey.com>
2541
2542         * symtab.c (struct symbol_cache): Add destructor and
2543         initializers.
2544         (symbol_cache_key): Move.  Change type.
2545         (make_symbol_cache, free_symbol_cache): Remove.
2546         (get_symbol_cache): Update.
2547         (symbol_cache_cleanup): Remove.
2548         (ALL_PSPACES, symbol_cache_flush)
2549         (maintenance_print_symbol_cache)
2550         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2551         Update.
2552
2553 2019-05-08  Tom Tromey  <tom@tromey.com>
2554
2555         * symtab.c (struct main_info): Add destructor and initializers.
2556         (main_progspace_key): Move.  Change type.
2557         (get_main_info): Update.
2558         (main_info_cleanup): Remove.
2559         (_initialize_symtab): Update.
2560
2561 2019-05-08  Tom Tromey  <tom@tromey.com>
2562
2563         * registry.h (DECLARE_REGISTRY): Define the _key class.
2564
2565 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * NEWS: Merge two 'New commands' sections.
2568
2569 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2570
2571         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2572         parameter and use Ada language definition instead.
2573         (ada_val_print_ptr): Remove unused language parameter.
2574         (ada_val_print_num): Remove language parameter and use Ada language
2575         definition instead.
2576         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2577         parameter.
2578         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2579         parameter and use Ada language definition instead.
2580         (ada_val_print_1): Update all ada_val_print_xxx calls.
2581         Remove language parameter.
2582         (ada_val_print): Update ada_val_print_1 call.
2583
2584 2019-05-08  Tom Tromey  <tromey@adacore.com>
2585
2586         * remote.c (remote_hw_watchpoint_limit)
2587         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2588         Now static.
2589
2590 2019-05-08  Tom Tromey  <tromey@adacore.com>
2591
2592         * maint.c (_initialize_maint_cmds): Move initialization code to
2593         remote.c.
2594         (watchdog, show_watchdog): Move to remote.c.
2595         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2596         "watchdog" static.
2597         (_initialize_remote): Move initialization code from maint.c.
2598         * defs.h (watchdog): Don't declare.
2599
2600 2019-05-08  Tom Tromey  <tromey@adacore.com>
2601
2602         * tui/tui-interp.c: Include main.h.
2603         * interps.c: Include main.h.
2604         * main.h (interpreter_p): Declare.
2605         * defs.h (interpreter_p): Don't declare.
2606
2607 2019-05-08  Tom Tromey  <tromey@adacore.com>
2608
2609         * dwarf2loc.c: Include dwarf2read.h.
2610         * defs.h (read_unsigned_leb128): Don't declare.
2611         * dwarf2read.h (read_unsigned_leb128): Declare.
2612
2613 2019-05-08  Tom Tromey  <tromey@adacore.com>
2614
2615         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2616         method.
2617
2618 2019-05-08  Tom Tromey  <tromey@adacore.com>
2619
2620         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2621         when no wrap column is set.
2622
2623 2019-05-08  Tom Tromey  <tromey@adacore.com>
2624
2625         * c-lang.c (c_get_string): Handle non-C-style arrays.
2626
2627 2019-05-08  Tom Tromey  <tromey@adacore.com>
2628
2629         * typeprint.c (print_offset_data::update): Print the bit offset,
2630         not the number of bits remaining.
2631
2632 2019-05-08  Tom Tromey  <tromey@adacore.com>
2633
2634         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2635         padding at end of comment.
2636
2637 2019-05-08  Tom Tromey  <tromey@adacore.com>
2638
2639         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2640         Compare main types.
2641
2642 2019-05-06  Tom Tromey  <tom@tromey.com>
2643
2644         * common/scoped_mmap.c: Include common-defs.h.
2645         * common/scoped_mmap.h: Don't include config.h.
2646
2647 2019-05-04  Tom Tromey  <tom@tromey.com>
2648
2649         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2650         (struct aarch64_call_info): Add initializers.
2651         <si>: Now a std::vector.
2652         (pass_on_stack, aarch64_push_dummy_call): Update.
2653
2654 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2655             Tom Tromey  <tom@tromey.com>
2656
2657         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2658         (ppc_threads): Now a std::vector.  Now static.
2659         (hwdebug_find_thread_points_by_tid)
2660         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2661         Update.
2662
2663 2019-05-04  Tom Tromey  <tom@tromey.com>
2664
2665         * arc-tdep.c (arc_tdesc_init): Return bool.
2666
2667 2019-05-04  Tom Tromey  <tom@tromey.com>
2668
2669         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2670         Use gdb_assert_not_reached.
2671
2672 2019-05-04  Tom Tromey  <tom@tromey.com>
2673
2674         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2675         "false".
2676
2677 2019-05-04  Tom Tromey  <tom@tromey.com>
2678
2679         * arc-tdep.c (arc_tdesc_init): Use bool.
2680
2681 2019-05-04  Tom Tromey  <tom@tromey.com>
2682
2683         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2684
2685 2019-05-04  Tom Tromey  <tom@tromey.com>
2686
2687         * cli/cli-cmds.c (valid_command_p): Return bool.
2688
2689 2019-05-04  Tom Tromey  <tom@tromey.com>
2690
2691         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2692         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2693
2694 2019-05-04  Raul Tambre  <raul@tambre.ee>
2695
2696         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2697         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2698         operator for comparison.
2699
2700 2019-05-04  Tom Tromey  <tom@tromey.com>
2701
2702         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2703         (lookup_partial_symbol, print_partial_symbols)
2704         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2705         (psymbol_compare): Update.
2706         (add_psymbol_to_bcache): Clear the entire psymbol.
2707         (maintenance_check_psymtabs): Update.
2708         * psympriv.h (struct partial_symbol): Don't derive from
2709         general_symbol_info.
2710         <obj_section, unrelocated_address, address,
2711         set_unrelocated_address>: Update.
2712         <ginfo>: New member.
2713         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2714         (debug_names::write_psymbols): Update.
2715
2716 2019-05-04  Tom de Vries  <tdevries@suse.de>
2717
2718         * contrib/cc-with-tweaks.sh: Support -n arg.
2719
2720 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2721
2722         * corelow.c (core_target::detach): Ensure frame cache and
2723         register caches are cleared.
2724         inferior.c (exit_inferior_1): Likewise.
2725
2726 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2727             Tom Tromey  <tom@tromey.com>
2728
2729         * dictionary.c (collate_pending_symbols_by_language): Remove
2730         "struct" from foreach.
2731         * symtab.c (lookup_global_symbol_from_objfile)
2732         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2733         foreach.
2734         * ser-tcp.c (net_open): Remove "struct" from foreach.
2735         * objfiles.c (objfile_relocate, objfile_rebase)
2736         (objfile_has_symbols): Remove "struct" from foreach.
2737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2738         from foreach.
2739         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2740         foreach.
2741         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2742         "struct" from foreach.
2743         * ada-lang.c (create_excep_cond_exprs)
2744         (ada_exception_catchpoint_cond_string): Remove "struct" from
2745         foreach.
2746
2747 2019-05-03  Tom Tromey  <tromey@adacore.com>
2748
2749         * ada-exp.y (convert_char_literal): Check suffix of each
2750         enumerator.
2751
2752 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2753
2754         PR ada/21406:
2755         * ada-exp.y (yywrap): Don't define.
2756         * ada-lex.l (%option): Add noyywrap
2757         (yywrap): Remove.
2758
2759 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2760
2761         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2762         _WIN32_WINNT to the XP level, unless already defined to a higher
2763         level.
2764
2765         * unittests/parse-connection-spec-selftests.c:
2766         * ser-tcp.c:
2767         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2768         override.
2769
2770         * symfile.c (find_separate_debug_file): Remove colon from the
2771         drive spec of DOS/Windows file names of the target, so that the
2772         file name produced from DEBUGDIR and the target's directory will
2773         be valid on DOS/Windows systems.
2774
2775 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * rust-lang.c (val_print_struct): Handle printing structures
2778         containing strings.
2779
2780 2019-05-02  Tom Tromey  <tromey@adacore.com>
2781
2782         * valarith.c (_initialize_valarith): Remove.
2783
2784 2019-05-01  Tom Tromey  <tromey@adacore.com>
2785
2786         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2787         bitfields.
2788
2789 2019-05-01  Tom Tromey  <tromey@adacore.com>
2790
2791         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2792         for big-endian copies.
2793
2794 2019-04-30  Ali Tamur  <tamur@google.com>
2795         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2796         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2797         (read_3_bytes): New function.
2798
2799 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2800
2801         * windows-nat.c (main_thread_id): Delete.
2802         (handle_output_debug_string): Replace main_thread_id by
2803         current_event.dwThreadId.
2804         (fake_create_process): Likewise.
2805         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2806         Do not set main_thread_id.
2807         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2808         current_event.dwThreadId.
2809         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2810
2811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2812
2813         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2814         Use current_event.dwThreadId instead of main_thread_id.
2815
2816 2019-04-30  Tom Tromey  <tromey@adacore.com>
2817
2818         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2819         (create_excep_cond_exprs): Iterate over program spaces.
2820         (ada_exception_catchpoint_cond_string): Examine all minimal
2821         symbols for exception types.
2822
2823 2019-04-30  Tom Tromey  <tromey@adacore.com>
2824
2825         PR c++/24470:
2826         * dwarf2read.c (process_structure_scope): Handle case where type
2827         has template parameters but no symbol was created.
2828
2829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2830             Chris January  <chris.january@arm.com>
2831
2832         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2833         qualifier.
2834         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2835
2836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * f-typeprint.c (f_print_type): Update rules for printing
2839         whitespace.
2840         (f_type_print_varspec_suffix): Likewise.
2841
2842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2843             Chris January  <chris.january@arm.com>
2844
2845         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2846         function arguments.
2847
2848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * f-lang.c (build_fortran_types): Change name of void type to
2851         lower case.
2852         * f-typeprint.c (f_type_print_base): Print the name of the void
2853         type, rather than a fixed string.
2854         * f-valprint.c (f_decorations): Use lower case void string.
2855
2856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2857             Chris January  <chris.january@arm.com>
2858
2859         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2860         types for Fortran.
2861
2862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2863             Chris January  <chris.january@arm.com>
2864             David Lecomber  <david.lecomber@arm.com>
2865
2866         * f-exp.y (BINOP_INTRINSIC): New token.
2867         (exp): New parser rule handling BINOP_INTRINSIC.
2868         (f77_keywords): Add new builtin procedures.
2869         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2870         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2871         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2872         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2873         (print_unop_subexp_f): New function.
2874         (print_binop_subexp_f): New function.
2875         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2876         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2877         (dump_subexp_body_f): Likewise.
2878         (operator_check_f): Likewise.
2879         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2880         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2881
2882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2883
2884         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2885         UNOP_KIND.
2886         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2887         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2888         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2889         (operator_length_f): New fuction.
2890         (print_subexp_f): New function.
2891         (op_name_f): New function.
2892         (dump_subexp_body_f): New function.
2893         (operator_check_f): New function.
2894         (exp_descriptor_f): Replace standard expression handling functions
2895         with new functions.
2896         * gdb/fortran-operator.def: New file.
2897         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2898         * gdb/std-operator.def: Remove UNOP_KIND.
2899
2900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2901
2902         * std-operator.def: Remove unbalanced, stray double quote
2903         character.
2904
2905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2906             Chris January  <chris.january@arm.com>
2907             Daniel Everett  <daniel.everett@arm.com>
2908             Nick Forrington  <nick.forrington@arm.com>
2909             Richard Bunt  <richard.bunt@arm.com>
2910
2911         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2912         of depth when printing anonymous structs or unions.
2913         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2914         Don't print either the top-level value, or the children if the
2915         max-depth is exceeded.
2916         (ppscm_print_children): When printing the key of a map, allow one
2917         extra level of depth.
2918         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2919         print either the top-level value, or the children if the max-depth
2920         is exceeded.
2921         (print_children): When printing the key of a map, allow one extra
2922         level of depth.
2923         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2924         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2925         (user_print_options): Initialise max_depth field.
2926         (val_print_scalar_or_string_type_p): New function.
2927         (val_print): Check to see if the max depth has been reached.
2928         (val_print_check_max_depth): Define new function.
2929         (show_print_max_depth): New function.
2930         (_initialize_valprint): Add 'print max-depth' option.
2931         * valprint.h (struct value_print_options) <max_depth>: New field.
2932         (val_print_check_max_depth): Declare new function.
2933         * NEWS: Document new feature.
2934
2935 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2936
2937         * ada-lang.c (ada_language_defn): Initialise new field.
2938         * c-lang.c (c_is_string_type_p): New function.
2939         (c_language_defn): Initialise new field.
2940         (cplus_language_defn): Initialise new field.
2941         (asm_language_defn): Initialise new field.
2942         (minimal_language_defn): Initialise new field.
2943         * c-lang.h (c_is_string_type_p): Declare new function.
2944         * d-lang.c (d_language_defn): Initialise new field.
2945         * f-lang.c (f_is_string_type_p): New function.
2946         (f_language_defn): Initialise new field.
2947         * go-lang.c (go_is_string_type_p): New function.
2948         (go_language_defn): Initialise new field.
2949         * language.c (default_is_string_type_p): New function.
2950         (unknown_language_defn): Initialise new field.
2951         (auto_language_defn): Initialise new field.
2952         * language.h (struct language_defn) <la_is_string_type_p>: New
2953         member variable.
2954         (default_is_string_type_p): Declare new function.
2955         * m2-lang.c (m2_language_defn): Initialise new field.
2956         * objc-lang.c (objc_language_defn): Initialise new field.
2957         * opencl-lang.c (opencl_language_defn): Initialise new field.
2958         * p-lang.c (pascal_is_string_type_p): New function.
2959         (pascal_language_defn): Initialise new field.
2960         * rust-lang.c (rust_is_string_type_p): New function.
2961         (rust_language_defn): Initialise new field.
2962
2963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2964
2965         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2966         New field.
2967         * ada-lang.c (ada_language_defn): Initialise new field.
2968         * c-lang.c (c_language_defn): Likewise.
2969         (cplus_language_defn): Likewise.
2970         (asm_language_defn): Likewise.
2971         (minimal_language_defn): Likewise.
2972         * d-lang.c (d_language_defn): Likewise.
2973         * f-lang.c (f_language_defn): Likewise.
2974         * go-lang.c (go_language_defn): Likewise.
2975         * language.c (unknown_language_defn): Likewise.
2976         (auto_language_defn): Likewise.
2977         * m2-lang.c (m2_language_defn): Likewise.
2978         * objc-lang.c (objc_language_defn): Likewise.
2979         * opencl-lang.c (opencl_language_defn): Likewise.
2980         * p-lang.c (pascal_language_defn): Likewise.
2981         * rust-lang.c (rust_language_defn): Likewise.
2982
2983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * ada-lang.c (ada_is_character_type): Change return type to bool.
2986         (ada_is_string_type): Likewise.
2987         * ada-lang.h (ada_is_character_type): Update declaration
2988         (ada_is_string_type): Likewise.
2989
2990 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2991
2992         Support style in 'frame|thread apply'
2993
2994         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2995         * record.c (record_start, record_stop): Update callers of
2996         execute_command_to_string with false.
2997         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2998         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2999         methods.
3000         (class string_file): New constructor with term_out parameter.
3001         Override methods term_out and can_emit_style_escape.  New member
3002         term_out.
3003         (class stdio_file): Override can_emit_style_escape.
3004         (class tee_file): Override term_out and can_emit_style_escape.
3005         * utils.h (can_emit_style_escape): Remove.
3006         * utils.c (can_emit_style_escape): Likewise.
3007         Update all callers of can_emit_style_escape (SOMESTREAM) to
3008         SOMESTREAM->can_emit_style_escape.
3009         * source-cache.c (source_cache::get_source_lines): Likewise.
3010         * stack.c (frame_apply_command_count): Call execute_command_to_string
3011         passing the term_out characteristic of the current gdb_stdout.
3012         * thread.c (thr_try_catch_cmd): Likewise.
3013         * top.c (execute_command_to_string): pass term_out parameter
3014         to construct the string_file for the command output.
3015         * ui-file.c (term_cli_styling): New function (most code moved
3016         from utils.c can_emit_style_escape).
3017         (string_file::string_file, string_file::can_emit_style_escape,
3018         stdio_file::can_emit_style_escape, tee_file::term_out,
3019         tee_file::can_emit_style_escape): New functions.
3020
3021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3022
3023         * NEWS: Mention the new set|show may-call-functions.
3024         * infcall.c (may_call_functions_p): New variable.
3025         (show_may_call_functions_p): New function.
3026         (call_function_by_hand_dummy): Throws an error if not
3027         may-call-functions.
3028         (_initialize_infcall): Call add_setshow_boolean_cmd for
3029         may-call-functions.
3030
3031 2019-04-25  Keith Seitz  <keiths@redhat.com>
3032
3033         PR c++/24367
3034         * cp-support.c (inspect_type): Don't attempt substitutions
3035         of symbol with the same name.
3036
3037 2019-04-25  Tom Tromey  <tromey@adacore.com>
3038
3039         PR gdb/24475:
3040         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3041         static.
3042
3043 2019-04-25  Tom Tromey  <tromey@adacore.com>
3044
3045         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3046         rvalue reference.
3047         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3048         (gdb_xml_parser::parse): Use std::move.
3049         * python/python-internal.h (gdbpy_convert_exception): Take a const
3050         reference.
3051         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3052         std::move.
3053         * python/py-utils.c (gdbpy_convert_exception): Take a const
3054         reference.
3055         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3056         Use std::move.
3057         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3058         Use std::move.
3059         * mi/mi-main.c (mi_print_exception): Take a const reference.
3060         * main.c (handle_command_errors): Take a const reference.
3061         * linespec.c (parse_linespec): Use std::move.
3062         * infcall.c (run_inferior_call): Use std::move.
3063         (call_function_by_hand_dummy): Use std::move.
3064         * exec.c (try_open_exec_file): Use std::move.
3065         * exceptions.h (exception_print, exception_fprintf)
3066         (exception_print_same): Update.
3067         * exceptions.c (print_exception, exception_print)
3068         (exception_fprintf, exception_print_same): Change parameters to
3069         const reference.
3070         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3071         * common/new-op.c: Use std::move.
3072         * common/common-exceptions.h (struct gdb_exception): Add move
3073         constructor.
3074         (struct gdb_exception_error, struct gdb_exception_quit, struct
3075         gdb_quit_bad_alloc): Change constructor to move constructor.
3076         (throw_exception): Change parameter to rvalue reference.
3077         * common/common-exceptions.c (throw_exception): Take rvalue
3078         reference.
3079         * cli/cli-interp.c (safe_execute_command): Use std::move.
3080         * breakpoint.c (insert_bp_location, location_to_sals): Use
3081         std::move.
3082
3083 2019-04-25  Tom Tromey  <tromey@adacore.com>
3084
3085         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3086         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3087         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3088         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3089         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3090         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3091         guile/scm-value.c: Use unpack.
3092         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3093         gdbscm_gdb_exception.
3094         (gdbscm_throw_gdb_exception): Likewise.
3095         (struct gdbscm_gdb_exception): New.
3096         (unpack): New function.
3097         (gdbscm_wrap): Use unpack.
3098
3099 2019-04-25  Tom Tromey  <tromey@adacore.com>
3100
3101         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3102         (gdb_rl_callback_handler): Use std::move.
3103         * common/common-exceptions.h (struct gdb_exception): Add move
3104         assignment operator.
3105         (throw_exception_sjlj): Change "exception" to const reference.
3106         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3107         (throw_exception_sjlj): Change "exception" to const reference.
3108
3109 2019-04-25  Tom Tromey  <tromey@adacore.com>
3110
3111         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3112         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3114         Update.
3115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3116         Update.
3117         * mi/mi-interp.c (mi_interp::exec): Update.
3118         * linespec.c (parse_linespec): Update.
3119         * infcall.c (run_inferior_call): Update.
3120         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3121         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3122         (gdbscm_lookup_global_symbol): Update.
3123         * guile/scm-param.c (gdbscm_parameter_value): Update.
3124         * guile/scm-frame.c (gdbscm_frame_read_register)
3125         (gdbscm_frame_read_var): Update.
3126         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3127         * exec.c (try_open_exec_file): Update.
3128         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3129         (gdb_rl_callback_handler): Update.
3130         * common/common-exceptions.h (exception_none): Don't declare.
3131         * common/common-exceptions.c (exception_none): Don't define.
3132         (struct catcher) <exception>: Update.
3133         * cli/cli-interp.c (safe_execute_command): Update.
3134         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3135
3136 2019-04-25  Ali Tamur  <tamur@google.com>
3137
3138         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3139         (read_attribute_value): Likewise.
3140         (dwarf2_read_addr_index): Update comment.
3141         (read_str_index): Add DW_FORM_strx.
3142         (dwarf2_string_attr): Likewise.
3143         (dwarf2_const_value_attr): Likewise.
3144         (dump_die_shallow): Likewise.
3145         (dwarf2_fetch_constant_bytes): Likewise.
3146         (skip_form_bytes): Likewise.
3147         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3148
3149 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3150
3151         PR corefiles/11608
3152         PR corefiles/18187
3153         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3154         OFFSET.  Verify if current mapping contains an ELF header.
3155         (linux_find_memory_regions_full): Adjust call to
3156         dump_mapping_p.
3157
3158 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3159             Kang Li <kanglictf@gmail.com>
3160
3161         PR gdb/21600
3162
3163         * dwarf2-frame.c (read_initial_length): Be consistent about using
3164         unsigned representation of length.
3165         (decode_frame_entry_1): Likewise.  Check for wraparound of
3166         end pointer as well as buffer overflow.
3167
3168 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3169
3170         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3171         "vq".
3172
3173 2019-04-24  Tom Tromey  <tromey@adacore.com>
3174
3175         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3176
3177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3178
3179         * s12z-tdep.c (s12z_unwind_pc): Delete.
3180         (s12z_unwind_sp): Delete.
3181         (s12z_gdbarch_init): Don't register deleted functions with
3182         gdbarch.
3183
3184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * rl78-tdep.c (rl78_unwind_sp): Delete.
3187         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3188
3189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3192         (xstormy16_unwind_pc): Delete.
3193         (xstormy16_dummy_id): Delete.
3194         (xstormy16_gdbarch_init): Don't register deleted functions with
3195         gdbarch.
3196
3197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * vax-tdep.c (vax_unwind_pc): Delete.
3200         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3201
3202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3203
3204         * v850-tdep.c (v850_unwind_sp): Delete.
3205         (v850_unwind_pc): Delete.
3206         (v850_dummy_id): Delete.
3207         (v850_gdbarch_init): Don't register deleted functions with
3208         gdbarch.
3209
3210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3213         (tilegx_unwind_pc): Delete.
3214         (tilegx_unwind_dummy_id): Delete.
3215         (tilegx_gdbarch_init): Don't register deleted functions with
3216         gdbarch.
3217
3218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3221         (tic6x_dummy_id): Delete.
3222         (tic6x_gdbarch_init): Don't register deleted functions with
3223         gdbarch.
3224
3225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * sparc-tdep.c (sparc_unwind_pc): Delete.
3228         (sparc32_gdbarch_init): Don't register deleted function with
3229         gdbarch.
3230
3231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3232
3233         * sh-tdep.c (sh_unwind_sp): Delete.
3234         (sh_unwind_pc): Delete.
3235         (sh_dummy_id): Delete.
3236         (sh_gdbarch_init): Don't register deleted functions with
3237         gdbarch.
3238
3239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * score-tdep.c (score_unwind_sp): Delete.
3242         (score_unwind_pc): Delete.
3243         (score_dummy_id): Delete.
3244         (score_gdbarch_init): Don't register deleted functions with
3245         gdbarch.
3246
3247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3248
3249         * rx-tdep.c (rx_unwind_pc): Delete.
3250         (rx_unwind_sp): Delete.
3251         (rx_dummy_id): Delete.
3252         (rx_gdbarch_init): Don't register deleted functions with
3253         gdbarch.  Update comment.
3254
3255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3256
3257         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3258         (rs6000_dummy_id): Delete.
3259         (rs6000_gdbarch_init): Don't register deleted functions with
3260         gdbarch.
3261
3262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3263
3264         * or1k-tdep.c (or1k_dummy_id): Delete.
3265         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3266
3267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * nios2-tdep.c (nios2_dummy_id): Delete.
3270         (nios2_unwind_sp): Delete.
3271         (nios2_gdbarch_init): Don't register deleted functions with
3272         gdbarch.
3273
3274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * nds32-tdep.c (nds32_dummy_id): Delete.
3277         (nds32_unwind_pc): Delete.
3278         (nds32_unwind_sp): Delete.
3279         (nds32_gdbarch_init): Don't register deleted functions with
3280         gdbarch.
3281
3282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * msp430-tdep.c (msp430_unwind_pc): Delete.
3285         (msp430_unwind_sp): Delete.
3286         (msp430_dummy_id): Delete.
3287         (msp430_gdbarch_init): Don't register deleted functions with
3288         gdbarch.
3289
3290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3291
3292         * moxie-tdep.c (moxie_unwind_sp): Delete.
3293         (moxie_unwind_pc): Delete.
3294         (moxie_dummy_id): Delete.
3295         (moxie_gdbarch_init): Don't register deleted functions with
3296         gdbarch.
3297
3298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3299
3300         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3301         (mn10300_unwind_pc): Delete.
3302         (mn10300_unwind_sp): Delete.
3303         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3304         mn10300_unwind_sp.
3305         (mn10300_frame_unwind_init): Don't register deleted functions with
3306         gdbarch.
3307
3308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * mep-tdep.c (mep_unwind_pc): Delete.
3311         (mep_unwind_sp): Delete.
3312         (mep_dummy_id): Delete.
3313         (mep_gdbarch_init): Don't register deleted functions with
3314         gdbarch.
3315
3316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3317
3318         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3319         (m68hc11_unwind_sp): Delete.
3320         (m68hc11_gdbarch_init): Don't register deleted functions with
3321         gdbarch.
3322
3323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * m32r-tdep.c (m32r_unwind_sp): Delete.
3326         (m32r_unwind_pc): Delete.
3327         (m32r_dummy_id): Delete.
3328         (m32r_gdbarch_init): Don't register deleted functions with
3329         gdbarch.
3330
3331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3332
3333         * m32c-tdep.c (m32c_unwind_pc): Delete.
3334         (m32c_unwind_sp): Delete.
3335         (m32c_dummy_id): Delete.
3336         (m32c_gdbarch_init): Don't register deleted functions with
3337         gdbarch.
3338
3339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3342         (lm32_unwind_pc): Delete.
3343         (lm32_dummy_id): Delete.
3344         (lm32_gdbarch_init): Don't register deleted functions with
3345         gdbarch.
3346
3347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3350         (iq2000_unwind_pc): Delete.
3351         (iq2000_dummy_id): Delete.
3352         (iq2000_gdbarch_init): Don't register deleted functions with
3353         gdbarch.
3354
3355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3356
3357         * nds32-tdep.c (nds32_type_align): Delete.
3358         (nds32_push_dummy_call): Use type_align instead.
3359
3360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3361
3362         * arm-tdep.c (arm_type_align): Only handle vector override case.
3363         (arm_push_dummy_call): Use type_align.
3364         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3365
3366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3369         case.
3370         (pass_on_stack): Use type_align.
3371         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3372         function.
3373
3374 2019-04-23  Tom Tromey  <tromey@adacore.com>
3375
3376         * dwarf2read.c (line_header::file_name_at): Remove unused
3377         overload.
3378
3379 2019-04-23  Tom de Vries  <tdevries@suse.de>
3380
3381         PR gdb/24438
3382         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3383         invocation.
3384
3385
3386 2019-03-27  Ali Tamur  <tamur@google.com>
3387
3388         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3389         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3390         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3391         (dwarf_expr_context::get_addr_index): Likewise
3392         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3393         (symbol_needs_eval_context::get_addr_index): Likewise
3394         (disassemble_dwarf_expression): Add DW_OP_addrx
3395         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3396         (read_cutu_die_from_dwo): Update comment
3397         (skip_one_die): Add DW_FORM_addrx
3398         (read_attribute_value): Likewise
3399         (var_decode_location): Add DW_OP_addrx
3400         (dwarf2_const_value_attr): Add DW_FORM_addrx
3401         (dump_die_shallow): Likewise
3402         (dwarf2_fetch_constant_bytes): Likewise
3403         (decode_locdesc): Add DW_OP_addrx
3404         (skip_form_bytes): Add DW_FORM_addrx
3405
3406 2019-04-22  Ali Tamur  <tamur@google.com>
3407
3408         * MAINTAINERS (Write After Approval): Add self.
3409
3410 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3411
3412         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3413         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3414         (open_symbol_file_object): Likewise.
3415         (svr4_default_sos): Add info parameter.
3416         (svr4_read_so_list): Likewise.
3417         (svr4_current_sos_direct): Adjust functions calls to pass down
3418         info.
3419         (svr4_current_sos_1): Add info parameter.
3420         (svr4_current_sos): Call get_svr4_info, pass info down to
3421         svr4_current_sos_1.
3422         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3423         get_svr4_info.
3424         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3425         get_svr4_info.
3426         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3427         to get_svr4_info.
3428         (probes_table_remove_objfile_probes): Likewise.
3429         (register_solib_event_probe): Add info parameter.
3430         (solist_update_incremental): Pass info parameter down to
3431         svr4_read_so_list.
3432         (disable_probes_interface): Add info parameter.
3433         (svr4_handle_solib_event): Pass current_program_space to
3434         get_svr4_info.  Adjust disable_probes_interface cleanup.
3435         (svr4_create_probe_breakpoints): Add info parameter, pass it
3436         down to register_solib_event_probe.
3437         (svr4_create_solib_event_breakpoints): Add info parameter,
3438         pass it down to svr4_create_probe_breakpoints.
3439         (enable_break): Pass info down to
3440         svr4_create_solib_event_breakpoints.
3441         (svr4_solib_create_inferior_hook): Pass current_program_space to
3442         get_svr4_info.
3443         (svr4_clear_solib): Likewise.
3444
3445 2019-04-22  Pedro Alves  <palves@redhat.com>
3446
3447         * solib-svr4.c (svr4_free_objfile_observer): New.
3448         (probe_and_action::objfile): New field.
3449         (probes_table_htab_remove_objfile_probes)
3450         (probes_table_remove_objfile_probes): New functions.
3451         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3452         in the new probe_and_action.  Don't store the probe in 'lookup'.
3453         (svr4_create_probe_breakpoints): Pass objfile to
3454         register_solib_event_probe.
3455         (_initialize_svr4_solib): Register a free_objfile observer.
3456
3457 2019-04-19  Tom Tromey  <tom@tromey.com>
3458
3459         * common/queue.h: Remove.
3460
3461 2019-04-19  Tom Tromey  <tom@tromey.com>
3462
3463         * event-loop.c: Don't include "common/queue.h".
3464
3465 2019-04-19  Tom Tromey  <tom@tromey.com>
3466
3467         * remote.c (remote_target): Use delete.
3468         * remote-notif.h: Include <list>, not "common/queue.h".
3469         (notif_client_p): Remove typedef.
3470         (remote_notif_state): Add constructor, destructor, initializer.
3471         <notif_queue>: Now a std::list.
3472         (remote_notif_state_xfree): Don't declare.
3473         * remote-notif.c (remote_notif_process, handle_notification)
3474         (remote_notif_state_allocate): Update.
3475         (~remote_notif_state): Rename from remote_notif_state_xfree.
3476
3477 2019-04-19  Tom Tromey  <tom@tromey.com>
3478
3479         * symfile.c (reread_symbols): Update.
3480         * objfiles.c (objfile_register_static_link)
3481         (objfile_lookup_static_link): Update
3482         (~objfile) Don't delete static_links.
3483         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3484
3485 2019-04-19  Tom Tromey  <tom@tromey.com>
3486
3487         * type-stack.h (struct type_stack) <insert>: Constify string.
3488         * type-stack.c (type_stack::insert): Constify string.
3489         * gdbtypes.h (lookup_template_type): Update.
3490         (address_space_name_to_int): Update.
3491         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3492         const.
3493         (lookup_template_type): Make name const.
3494         * c-exp.y: Update rules.
3495         (lex_one_token, classify_name, classify_inner_name)
3496         (c_print_token): Update.
3497         * p-exp.y: Update rules.
3498         (yylex): Update.
3499         * f-exp.y: Update rules.
3500         (yylex): Update.
3501         * d-exp.y: Update rules.
3502         (lex_one_token, classify_name, classify_inner_name): Update.
3503         * parse.c (write_dollar_variable, copy_name): Return std::string.
3504         * parser-defs.h (copy_name): Change return type.
3505         * m2-exp.y: Update rules.
3506         (yylex): Update.
3507         * go-exp.y (lex_one_token): Update.
3508         Update rules.
3509         (classify_unsafe_function, classify_packaged_name)
3510         (classify_name, yylex): Update.
3511
3512 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3513
3514         * configure.ac: add --enable-source-highlight switch.
3515         * configure: Regenerate.
3516         * top.c (print_gdb_version): plumb --enable-source-highlight
3517         status to "show configuration".
3518
3519 2019-04-19  Tom Tromey  <tromey@adacore.com>
3520
3521         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3522         Check ADA_TYPE_P.
3523         (empty_record, ada_template_to_fixed_record_type_1)
3524         (template_to_static_fixed_type)
3525         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3526         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3527         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3528         macros.
3529
3530 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3531
3532         PR symtab/24423:
3533         * source.c (print_source_lines_base): Advance "iter" when a
3534         control character is seen.
3535
3536 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3537
3538         * inferior.h (struct infcall_suspend_state_deleter):
3539         Catch exception in destructor to avoid crash.
3540
3541 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3542
3543         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3544         close to the add_com "shell".
3545
3546 2019-04-18  Tom Tromey  <tromey@adacore.com>
3547
3548         * process-stratum-target.h (class process_stratum_target)
3549         <stratum>: Add "final".
3550
3551 2019-04-17  Tom Tromey  <tromey@adacore.com>
3552
3553         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3554         against nullptr before use.
3555
3556 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3557
3558         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3559
3560 2019-04-17  Jim Wilson  <jimw@sifive.com>
3561             Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3564         code read might fail, assume 4-byte breakpoint in that case.
3565
3566 2019-04-15  Leszek Swirski  <leszeks@google.com>
3567
3568         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3569         rather than a hand-rolled POD check when checking for forced MEMORY
3570         classification.
3571
3572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3573
3574         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3575         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3576         function.
3577         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3578         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3579         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3580         declaration.
3581
3582 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3583
3584         * aarch64-linux-nat.c
3585         (aarch64_linux_nat_target::thread_architecture): Add override.
3586         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3587         each VQ.
3588
3589 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3590
3591         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3592
3593 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3596         target types of size 96-bits, add some additional comments, and
3597         check that the builtin type we found was the correct size.
3598
3599 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3600
3601         * utils.c (prompt_for_continue): Don't restore the styling at the
3602         end, as applied_style has the wrong value.  This fixes styling in
3603         long lists of file names that are interrupted by the "Continue?"
3604         prompt.
3605
3606 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3609         * c-lang.c (c_language_defn): Likewise.
3610         (cplus_language_defn): Likewise.
3611         (asm_language_defn): Likewise.
3612         (minimal_language_defn): Likewise.
3613         * d-lang.c (d_language_defn): Likewise.
3614         * f-lang.c (f_language_defn): Likewise.
3615         * go-lang.c (go_language_defn): Likewise.
3616         * language.c (unknown_language_defn): Likewise.
3617         (auto_language_defn): Likewise.
3618         * language.h (struct language_defn): Remove la_magic field.
3619         (LANG_MAGIC): Delete.
3620         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3621         * objc-lang.c (objc_language_defn): Likewise.
3622         * opencl-lang.c (opencl_language_defn): Likewise.
3623         * p-lang.c (pascal_language_defn): Likewise.
3624         * rust-lang.c (rust_language_defn): Likewise.
3625
3626 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * riscv-tdep.c (riscv_type_align): New function.
3629         (riscv_type_alignment): Delete.
3630         (riscv_arg_location): Use 'type_align'.
3631         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3632
3633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         * gdbtypes.c (type_align): A struct with no non-static fields also
3636         has alignment of 1.
3637
3638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3641         component to 0.
3642         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3643         member.
3644         (riscv_struct_info::analyse): New implementation using new
3645         analyse_inner member function.
3646         (riscv_struct_info::field_offset): New member function.
3647         (riscv_struct_info::m_offsets): New member variable.
3648         (riscv_struct_info::analyse_inner): New private member function,
3649         takes the old implementation of riscv_struct_info::analyse but
3650         extended to track field offsets.
3651         (riscv_call_arg_struct): Update the struct folding special cases
3652         to handle cases where empty C++ structs, which are non-zero
3653         length, are found.
3654         (riscv_arg_location): Initialise the length of each location, a
3655         non-zero length now indicates the location is in use.
3656         (riscv_push_dummy_call): Allow for the first location having a
3657         non-zero offset when setting up arguments.
3658         (riscv_return_value): Likewise, but for return values.
3659
3660 2019-04-11  Tom Tromey  <tromey@adacore.com>
3661
3662         * utils.c (internal_vproblem): Make "msg" const.
3663
3664 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3665
3666         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3667         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3668         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3669         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3670
3671 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3672
3673         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3674         function.
3675         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3676         of amd64_collect_native_gregset.
3677         (amd64_linux_nat_target::store_registers): Likewise.
3678
3679 2019-04-10  Tom Tromey  <tom@tromey.com>
3680
3681         * symtab.c (lookup_global_symbol_from_objfile)
3682         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3683         * objfiles.h (class separate_debug_iterator): New.
3684         (class separate_debug_range): New.
3685         (struct objfile) <separate_debug_objfiles>: New method.
3686         (objfile_separate_debug_iterate): Don't declare.
3687         * objfiles.c (separate_debug_iterator::operator++): Rename from
3688         objfile_separate_debug_iterate.
3689         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3690         iterator.
3691         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3692         iterator.
3693
3694 2019-04-10  Tom Tromey  <tom@tromey.com>
3695
3696         * symfile.c (reread_symbols): Remove old comment.
3697         * objfiles.c (free_all_objfiles): Fix a typo.
3698
3699 2019-04-10  Tom Tromey  <tom@tromey.com>
3700
3701         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3702         * minsyms.c (lookup_minimal_symbol): Use foreach.
3703         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3704         (lookup_minimal_symbol_solib_trampoline): Likewise.
3705         * symfile.c (reread_symbols): Use foreach.
3706
3707 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3708             Tom Tromey  <tromey@adacore.com>
3709
3710         PR rust/24414:
3711         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3712         (rust_lex_int_test): Change "value" to be LONGEST.
3713         (rust_lex_tests): Add test for long integer literal.
3714
3715 2019-04-09  Tom Tromey  <tromey@adacore.com>
3716
3717         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3718         to bool.
3719         (extended_remote_target::attach): Update.
3720         (remote_target::remote_notice_new_inferior): Update.
3721         (remote_target::add_current_inferior_and_thread): Update.
3722         * inferior.c (exit_inferior_1): Use "false".
3723         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3724
3725 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3726
3727         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3728         the "start" command.
3729
3730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3731
3732         * python/py-inferior.c (infpy_thread_from_thread_handle):
3733         Adjust comments to reflect renaming of thread_from_thread_handle
3734         to thread_from_handle.  Adjust keywords.  Fix type error message.
3735         (inferior_object_methods): Add thread_from_handle.  Retain
3736         thread_from_thread_handle, but mark it as deprecated.
3737
3738 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3739
3740         * gdbthread.h (find_thread_by_handle): Revise declaration.
3741         * thread.c (find_thread_by_handle): Likewise.  Adjust
3742         implementation too.
3743         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3744         support for buffer objects as handles.
3745
3746 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3747
3748         * python/py-infthread.c (thpy_thread_handle): New function.
3749         (thread_object_methods): Register thpy_thread_handle.
3750
3751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3752
3753         * gdbthread.h (thread_to_thread_handle): Declare.
3754         * thread.c (gdbtypes.h): Include.
3755         (thread_to_thread_handle): New function.
3756
3757         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3758         (target_thread_info_to_thread_handle): Declare.
3759         * target.c (target_thread_info_to_thread_handle): New function.
3760         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3761         * target-delegates.c: Regenerate.
3762
3763         * linux-thread-db.c (class thread_db_target): Add method
3764         thread_info_to_thread_handle.
3765         (thread_db_target::thread_info_to_thread_handle): Define.
3766         * remote.c (class remote_target): Add new method
3767         thread_info_to_thread_handle.
3768         (remote_target::thread_info_to_thread_handle): Define.
3769
3770 2019-04-08  Pedro Alves  <palves@redhat.com>
3771
3772         * common/common-exceptions.c (throw_exception): Don't create
3773         named object to throw; throw directly.
3774         (throw_it): Likewise.  Don't initialize gdb_exception::message
3775         here, with new; pass FMT and AP to the ctor instead.
3776         * common/common-exceptions.h: Include <string>.
3777         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3778         const char *, va_list)): New ctor.  Use std::make_shared.
3779         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3780         errors)): Delete.
3781         (gdb_exception_error::gdb_exception_error(enum errors, const char
3782         *, va_list)): New.
3783         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3784         Add assertion.
3785         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3786         errors)): Delete.
3787         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3788         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3789         Add assertion.
3790
3791 2019-04-08  Tom Tromey  <tom@tromey.com>
3792
3793         * valops.c (value_rtti_indirect_type): Replace throw_exception
3794         with throw.
3795         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3796         with throw.
3797         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3798         throw.
3799         * target.c (target_translate_tls_address): Replace throw_exception
3800         with throw.
3801         * stack.c (frame_apply_command_count): Replace throw_exception
3802         with throw.
3803         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3804         throw.
3805         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3806         with throw.
3807         * rs6000-tdep.c (rs6000_frame_cache)
3808         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3809         * remote.c: Replace throw_exception with throw.
3810         * record-full.c (record_full_message, record_full_wait_1)
3811         (record_full_restore): Replace throw_exception with throw.
3812         * record-btrace.c:
3813         (get_thread_current_frame_id, record_btrace_start_replaying)
3814         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3815         (cmd_record_btrace_start): Replace throw_exception with throw.
3816         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3817         throw.
3818         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3819         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3820         * linespec.c:
3821         (find_linespec_symbols): Replace throw_exception with throw.
3822         * infrun.c (displaced_step_prepare, resume): Replace
3823         throw_exception with throw.
3824         * infcmd.c (post_create_inferior): Replace throw_exception with
3825         throw.
3826         * inf-loop.c (inferior_event_handler): Replace throw_exception
3827         with throw.
3828         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3829         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3830         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3831         (get_prev_frame_always, get_frame_pc_if_available)
3832         (get_frame_address_in_block_if_available, get_frame_language):
3833         Replace throw_exception with throw.
3834         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3835         throw_exception with throw.
3836         * eval.c (fetch_subexp_value, evaluate_var_value)
3837         (evaluate_funcall, evaluate_subexp_standard): Replace
3838         throw_exception with throw.
3839         * dwarf2loc.c (call_site_find_chain)
3840         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3841         Replace throw_exception with throw.
3842         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3843         with throw.
3844         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3845         throw.
3846         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3847         * completer.c (complete_line_internal): Replace throw_exception
3848         with throw.
3849         * compile/compile-object-run.c (compile_object_run): Replace
3850         throw_exception with throw.
3851         * cli/cli-script.c (process_next_line): Replace throw_exception
3852         with throw.
3853         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3854         (btrace_enable, btrace_maint_update_pt_packets): Replace
3855         throw_exception with throw.
3856         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3857         throw_exception with throw.
3858         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3859         throw_exception with throw.
3860         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3861         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3862         * aarch64-tdep.c (aarch64_make_prologue_cache)
3863         (aarch64_make_stub_cache): Replace throw_exception with throw.
3864
3865 2019-04-08  Tom Tromey  <tom@tromey.com>
3866
3867         * common/common-exceptions.c (throw_exception): Rename from
3868         throw_exception_cxx.  Remove old copy.  Make argument const.
3869         (throw_it): Create and throw exception objects directly.
3870         * common/common-exceptions.h (throw_exception): Make argument
3871         const.
3872         (struct gdb_exception_error): Add constructor.
3873         (struct gdb_exception_quit): Add constructor.
3874
3875 2019-04-08  Tom Tromey  <tom@tromey.com>
3876
3877         * common/common-exceptions.h (exception_rethrow): Don't declare.
3878         (TRY_SJLJ): Update comment.
3879         (TRY, CATCH, END_CATCH): Remove.
3880         * common/common-exceptions.c (exception_rethrow): Remove.
3881
3882 2019-04-08  Tom Tromey  <tom@tromey.com>
3883
3884         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3885         Remove.
3886         (gdb_exception_error): Rename from
3887         gdb_exception_RETURN_MASK_ERROR.
3888         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3889         (gdb_quit_bad_alloc): Update.
3890         * aarch64-tdep.c: Update.
3891         * ada-lang.c: Update.
3892         * ada-typeprint.c: Update.
3893         * ada-valprint.c: Update.
3894         * amd64-tdep.c: Update.
3895         * arch-utils.c: Update.
3896         * break-catch-throw.c: Update.
3897         * breakpoint.c: Update.
3898         * btrace.c: Update.
3899         * c-varobj.c: Update.
3900         * cli/cli-cmds.c: Update.
3901         * cli/cli-interp.c: Update.
3902         * cli/cli-script.c: Update.
3903         * common/common-exceptions.c: Update.
3904         * common/new-op.c: Update.
3905         * common/selftest.c: Update.
3906         * compile/compile-c-symbols.c: Update.
3907         * compile/compile-cplus-symbols.c: Update.
3908         * compile/compile-object-load.c: Update.
3909         * compile/compile-object-run.c: Update.
3910         * completer.c: Update.
3911         * corelow.c: Update.
3912         * cp-abi.c: Update.
3913         * cp-support.c: Update.
3914         * cp-valprint.c: Update.
3915         * darwin-nat.c: Update.
3916         * disasm-selftests.c: Update.
3917         * dtrace-probe.c: Update.
3918         * dwarf-index-cache.c: Update.
3919         * dwarf-index-write.c: Update.
3920         * dwarf2-frame-tailcall.c: Update.
3921         * dwarf2-frame.c: Update.
3922         * dwarf2loc.c: Update.
3923         * dwarf2read.c: Update.
3924         * eval.c: Update.
3925         * event-loop.c: Update.
3926         * event-top.c: Update.
3927         * exec.c: Update.
3928         * f-valprint.c: Update.
3929         * fbsd-tdep.c: Update.
3930         * frame-unwind.c: Update.
3931         * frame.c: Update.
3932         * gdbtypes.c: Update.
3933         * gnu-v3-abi.c: Update.
3934         * guile/guile-internal.h: Update.
3935         * guile/scm-block.c: Update.
3936         * guile/scm-breakpoint.c: Update.
3937         * guile/scm-cmd.c: Update.
3938         * guile/scm-disasm.c: Update.
3939         * guile/scm-frame.c: Update.
3940         * guile/scm-lazy-string.c: Update.
3941         * guile/scm-math.c: Update.
3942         * guile/scm-param.c: Update.
3943         * guile/scm-ports.c: Update.
3944         * guile/scm-pretty-print.c: Update.
3945         * guile/scm-symbol.c: Update.
3946         * guile/scm-symtab.c: Update.
3947         * guile/scm-type.c: Update.
3948         * guile/scm-value.c: Update.
3949         * i386-linux-tdep.c: Update.
3950         * i386-tdep.c: Update.
3951         * inf-loop.c: Update.
3952         * infcall.c: Update.
3953         * infcmd.c: Update.
3954         * infrun.c: Update.
3955         * jit.c: Update.
3956         * language.c: Update.
3957         * linespec.c: Update.
3958         * linux-fork.c: Update.
3959         * linux-nat.c: Update.
3960         * linux-tdep.c: Update.
3961         * linux-thread-db.c: Update.
3962         * main.c: Update.
3963         * mi/mi-cmd-break.c: Update.
3964         * mi/mi-cmd-stack.c: Update.
3965         * mi/mi-interp.c: Update.
3966         * mi/mi-main.c: Update.
3967         * objc-lang.c: Update.
3968         * p-valprint.c: Update.
3969         * parse.c: Update.
3970         * ppc-linux-tdep.c: Update.
3971         * printcmd.c: Update.
3972         * python/py-arch.c: Update.
3973         * python/py-breakpoint.c: Update.
3974         * python/py-cmd.c: Update.
3975         * python/py-finishbreakpoint.c: Update.
3976         * python/py-frame.c: Update.
3977         * python/py-framefilter.c: Update.
3978         * python/py-gdb-readline.c: Update.
3979         * python/py-inferior.c: Update.
3980         * python/py-infthread.c: Update.
3981         * python/py-lazy-string.c: Update.
3982         * python/py-linetable.c: Update.
3983         * python/py-objfile.c: Update.
3984         * python/py-param.c: Update.
3985         * python/py-prettyprint.c: Update.
3986         * python/py-progspace.c: Update.
3987         * python/py-record-btrace.c: Update.
3988         * python/py-record.c: Update.
3989         * python/py-symbol.c: Update.
3990         * python/py-type.c: Update.
3991         * python/py-unwind.c: Update.
3992         * python/py-utils.c: Update.
3993         * python/py-value.c: Update.
3994         * python/python.c: Update.
3995         * record-btrace.c: Update.
3996         * record-full.c: Update.
3997         * remote-fileio.c: Update.
3998         * remote.c: Update.
3999         * riscv-tdep.c: Update.
4000         * rs6000-aix-tdep.c: Update.
4001         * rs6000-tdep.c: Update.
4002         * rust-exp.y: Update.
4003         * rust-lang.c: Update.
4004         * s390-tdep.c: Update.
4005         * selftest-arch.c: Update.
4006         * solib-dsbt.c: Update.
4007         * solib-frv.c: Update.
4008         * solib-spu.c: Update.
4009         * solib-svr4.c: Update.
4010         * solib.c: Update.
4011         * sparc64-linux-tdep.c: Update.
4012         * stack.c: Update.
4013         * symfile-mem.c: Update.
4014         * symmisc.c: Update.
4015         * target.c: Update.
4016         * thread.c: Update.
4017         * top.c: Update.
4018         * tracefile-tfile.c: Update.
4019         * tui/tui.c: Update.
4020         * typeprint.c: Update.
4021         * unittests/cli-utils-selftests.c: Update.
4022         * unittests/parse-connection-spec-selftests.c: Update.
4023         * valops.c: Update.
4024         * valprint.c: Update.
4025         * value.c: Update.
4026         * varobj.c: Update.
4027         * windows-nat.c: Update.
4028         * x86-linux-nat.c: Update.
4029         * xml-support.c: Update.
4030
4031 2019-04-08  Tom Tromey  <tom@tromey.com>
4032
4033         * xml-support.c: Use C++ exception handling.
4034         * x86-linux-nat.c: Use C++ exception handling.
4035         * windows-nat.c: Use C++ exception handling.
4036         * varobj.c: Use C++ exception handling.
4037         * value.c: Use C++ exception handling.
4038         * valprint.c: Use C++ exception handling.
4039         * valops.c: Use C++ exception handling.
4040         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4041         handling.
4042         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4043         * typeprint.c: Use C++ exception handling.
4044         * tui/tui.c: Use C++ exception handling.
4045         * tracefile-tfile.c: Use C++ exception handling.
4046         * top.c: Use C++ exception handling.
4047         * thread.c: Use C++ exception handling.
4048         * target.c: Use C++ exception handling.
4049         * symmisc.c: Use C++ exception handling.
4050         * symfile-mem.c: Use C++ exception handling.
4051         * stack.c: Use C++ exception handling.
4052         * sparc64-linux-tdep.c: Use C++ exception handling.
4053         * solib.c: Use C++ exception handling.
4054         * solib-svr4.c: Use C++ exception handling.
4055         * solib-spu.c: Use C++ exception handling.
4056         * solib-frv.c: Use C++ exception handling.
4057         * solib-dsbt.c: Use C++ exception handling.
4058         * selftest-arch.c: Use C++ exception handling.
4059         * s390-tdep.c: Use C++ exception handling.
4060         * rust-lang.c: Use C++ exception handling.
4061         * rust-exp.y: Use C++ exception handling.
4062         * rs6000-tdep.c: Use C++ exception handling.
4063         * rs6000-aix-tdep.c: Use C++ exception handling.
4064         * riscv-tdep.c: Use C++ exception handling.
4065         * remote.c: Use C++ exception handling.
4066         * remote-fileio.c: Use C++ exception handling.
4067         * record-full.c: Use C++ exception handling.
4068         * record-btrace.c: Use C++ exception handling.
4069         * python/python.c: Use C++ exception handling.
4070         * python/py-value.c: Use C++ exception handling.
4071         * python/py-utils.c: Use C++ exception handling.
4072         * python/py-unwind.c: Use C++ exception handling.
4073         * python/py-type.c: Use C++ exception handling.
4074         * python/py-symbol.c: Use C++ exception handling.
4075         * python/py-record.c: Use C++ exception handling.
4076         * python/py-record-btrace.c: Use C++ exception handling.
4077         * python/py-progspace.c: Use C++ exception handling.
4078         * python/py-prettyprint.c: Use C++ exception handling.
4079         * python/py-param.c: Use C++ exception handling.
4080         * python/py-objfile.c: Use C++ exception handling.
4081         * python/py-linetable.c: Use C++ exception handling.
4082         * python/py-lazy-string.c: Use C++ exception handling.
4083         * python/py-infthread.c: Use C++ exception handling.
4084         * python/py-inferior.c: Use C++ exception handling.
4085         * python/py-gdb-readline.c: Use C++ exception handling.
4086         * python/py-framefilter.c: Use C++ exception handling.
4087         * python/py-frame.c: Use C++ exception handling.
4088         * python/py-finishbreakpoint.c: Use C++ exception handling.
4089         * python/py-cmd.c: Use C++ exception handling.
4090         * python/py-breakpoint.c: Use C++ exception handling.
4091         * python/py-arch.c: Use C++ exception handling.
4092         * printcmd.c: Use C++ exception handling.
4093         * ppc-linux-tdep.c: Use C++ exception handling.
4094         * parse.c: Use C++ exception handling.
4095         * p-valprint.c: Use C++ exception handling.
4096         * objc-lang.c: Use C++ exception handling.
4097         * mi/mi-main.c: Use C++ exception handling.
4098         * mi/mi-interp.c: Use C++ exception handling.
4099         * mi/mi-cmd-stack.c: Use C++ exception handling.
4100         * mi/mi-cmd-break.c: Use C++ exception handling.
4101         * main.c: Use C++ exception handling.
4102         * linux-thread-db.c: Use C++ exception handling.
4103         * linux-tdep.c: Use C++ exception handling.
4104         * linux-nat.c: Use C++ exception handling.
4105         * linux-fork.c: Use C++ exception handling.
4106         * linespec.c: Use C++ exception handling.
4107         * language.c: Use C++ exception handling.
4108         * jit.c: Use C++ exception handling.
4109         * infrun.c: Use C++ exception handling.
4110         * infcmd.c: Use C++ exception handling.
4111         * infcall.c: Use C++ exception handling.
4112         * inf-loop.c: Use C++ exception handling.
4113         * i386-tdep.c: Use C++ exception handling.
4114         * i386-linux-tdep.c: Use C++ exception handling.
4115         * guile/scm-value.c: Use C++ exception handling.
4116         * guile/scm-type.c: Use C++ exception handling.
4117         * guile/scm-symtab.c: Use C++ exception handling.
4118         * guile/scm-symbol.c: Use C++ exception handling.
4119         * guile/scm-pretty-print.c: Use C++ exception handling.
4120         * guile/scm-ports.c: Use C++ exception handling.
4121         * guile/scm-param.c: Use C++ exception handling.
4122         * guile/scm-math.c: Use C++ exception handling.
4123         * guile/scm-lazy-string.c: Use C++ exception handling.
4124         * guile/scm-frame.c: Use C++ exception handling.
4125         * guile/scm-disasm.c: Use C++ exception handling.
4126         * guile/scm-cmd.c: Use C++ exception handling.
4127         * guile/scm-breakpoint.c: Use C++ exception handling.
4128         * guile/scm-block.c: Use C++ exception handling.
4129         * guile/guile-internal.h: Use C++ exception handling.
4130         * gnu-v3-abi.c: Use C++ exception handling.
4131         * gdbtypes.c: Use C++ exception handling.
4132         * frame.c: Use C++ exception handling.
4133         * frame-unwind.c: Use C++ exception handling.
4134         * fbsd-tdep.c: Use C++ exception handling.
4135         * f-valprint.c: Use C++ exception handling.
4136         * exec.c: Use C++ exception handling.
4137         * event-top.c: Use C++ exception handling.
4138         * event-loop.c: Use C++ exception handling.
4139         * eval.c: Use C++ exception handling.
4140         * dwarf2read.c: Use C++ exception handling.
4141         * dwarf2loc.c: Use C++ exception handling.
4142         * dwarf2-frame.c: Use C++ exception handling.
4143         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4144         * dwarf-index-write.c: Use C++ exception handling.
4145         * dwarf-index-cache.c: Use C++ exception handling.
4146         * dtrace-probe.c: Use C++ exception handling.
4147         * disasm-selftests.c: Use C++ exception handling.
4148         * darwin-nat.c: Use C++ exception handling.
4149         * cp-valprint.c: Use C++ exception handling.
4150         * cp-support.c: Use C++ exception handling.
4151         * cp-abi.c: Use C++ exception handling.
4152         * corelow.c: Use C++ exception handling.
4153         * completer.c: Use C++ exception handling.
4154         * compile/compile-object-run.c: Use C++ exception handling.
4155         * compile/compile-object-load.c: Use C++ exception handling.
4156         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4157         * compile/compile-c-symbols.c: Use C++ exception handling.
4158         * common/selftest.c: Use C++ exception handling.
4159         * common/new-op.c: Use C++ exception handling.
4160         * cli/cli-script.c: Use C++ exception handling.
4161         * cli/cli-interp.c: Use C++ exception handling.
4162         * cli/cli-cmds.c: Use C++ exception handling.
4163         * c-varobj.c: Use C++ exception handling.
4164         * btrace.c: Use C++ exception handling.
4165         * breakpoint.c: Use C++ exception handling.
4166         * break-catch-throw.c: Use C++ exception handling.
4167         * arch-utils.c: Use C++ exception handling.
4168         * amd64-tdep.c: Use C++ exception handling.
4169         * ada-valprint.c: Use C++ exception handling.
4170         * ada-typeprint.c: Use C++ exception handling.
4171         * ada-lang.c: Use C++ exception handling.
4172         * aarch64-tdep.c: Use C++ exception handling.
4173
4174 2019-04-08  Tom Tromey  <tom@tromey.com>
4175
4176         * xml-support.c (gdb_xml_parser::parse): Update.
4177         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4178         * value.c (show_convenience): Update.
4179         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4180         (test_parse_flags_qcs): Update.
4181         * thread.c (thr_try_catch_cmd): Update.
4182         * target.c (target_translate_tls_address): Update.
4183         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4184         (info_frame_command_core, frame_apply_command_count): Update.
4185         * rust-exp.y (rust_lex_exception_test): Update.
4186         * riscv-tdep.c (riscv_print_one_register_info): Update.
4187         * remote.c (remote_target::enable_btrace): Update.
4188         * record-btrace.c (record_btrace_enable_warn): Update.
4189         * python/py-utils.c (gdbpy_convert_exception): Update.
4190         * printcmd.c (do_one_display, print_variable_and_value): Update.
4191         * mi/mi-main.c (mi_print_exception): Update.
4192         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4193         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4194         * linux-nat.c (linux_nat_target::attach): Update.
4195         * linux-fork.c (class scoped_switch_fork_info): Update.
4196         * infrun.c (displaced_step_prepare): Update.
4197         * infcall.c (call_function_by_hand_dummy): Update.
4198         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4199         * gnu-v3-abi.c (print_one_vtable): Update.
4200         * frame.c (get_prev_frame_always): Update.
4201         * f-valprint.c (info_common_command_for_block): Update.
4202         * exec.c (try_open_exec_file): Update.
4203         * exceptions.c (print_exception, exception_print)
4204         (exception_fprintf, exception_print_same): Update.
4205         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4206         * dwarf-index-cache.c (index_cache::store)
4207         (index_cache::lookup_gdb_index): Update.
4208         * darwin-nat.c (maybe_cache_shell): Update.
4209         * cp-valprint.c (cp_print_value_fields): Update.
4210         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4211         (gcc_cplus_symbol_address): Update.
4212         * compile/compile-c-symbols.c (gcc_convert_symbol)
4213         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4214         * common/selftest.c: Update.
4215         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4216         a std::string.
4217         (exception_try_scope_entry, exception_try_scope_exit): Don't
4218         declare.
4219         (struct exception_try_scope): Remove.
4220         (TRY): Don't use exception_try_scope.
4221         (struct gdb_exception): Add constructor, operator=.
4222         <what>: New method.
4223         (struct gdb_exception_RETURN_MASK_ALL)
4224         (struct gdb_exception_RETURN_MASK_ERROR)
4225         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4226         (struct gdb_quit_bad_alloc): Update.
4227         * common/common-exceptions.c (exception_none): Change
4228         initializer.
4229         (struct catcher) <state, exception>: Initialize inline.
4230         <prev>: Remove member.
4231         (current_catcher): Remove.
4232         (catchers): New global.
4233         (exceptions_state_mc_init): Simplify.
4234         (catcher_pop): Remove.
4235         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4236         (try_scope_depth, exception_try_scope_entry)
4237         (exception_try_scope_exit): Remove.
4238         (throw_exception_sjlj): Update.
4239         (exception_messages, exception_messages_size): Remove.
4240         (throw_it): Simplify.
4241         (gdb_exception_sliced_copy): Remove.
4242         (throw_exception_cxx): Update.
4243         * cli/cli-script.c (script_from_file): Update.
4244         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4245         Update.
4246         * ada-valprint.c (ada_val_print): Update.
4247         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4248         (create_excep_cond_exprs): Update.
4249
4250 2019-04-08  Tom Tromey  <tom@tromey.com>
4251
4252         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4253         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4254         (TRY, CATCH, END_CATCH): Remove some definitions.
4255         * common/common-exceptions.c: Don't use GDB_XCPT.
4256         (catcher_list_size): Remove.
4257         (throw_exception, throw_it): Simplify.
4258
4259 2019-04-05  Tom Tromey  <tom@tromey.com>
4260
4261         Revert the header-sorting patch.
4262         * ft32-tdep.c: Revert.
4263         * frv-tdep.c: Revert.
4264         * frv-linux-tdep.c: Revert.
4265         * frame.c: Revert.
4266         * frame-unwind.c: Revert.
4267         * frame-base.c: Revert.
4268         * fork-child.c: Revert.
4269         * findvar.c: Revert.
4270         * findcmd.c: Revert.
4271         * filesystem.c: Revert.
4272         * filename-seen-cache.h: Revert.
4273         * filename-seen-cache.c: Revert.
4274         * fbsd-tdep.c: Revert.
4275         * fbsd-nat.h: Revert.
4276         * fbsd-nat.c: Revert.
4277         * f-valprint.c: Revert.
4278         * f-typeprint.c: Revert.
4279         * f-lang.c: Revert.
4280         * extension.h: Revert.
4281         * extension.c: Revert.
4282         * extension-priv.h: Revert.
4283         * expprint.c: Revert.
4284         * exec.h: Revert.
4285         * exec.c: Revert.
4286         * exceptions.c: Revert.
4287         * event-top.c: Revert.
4288         * event-loop.c: Revert.
4289         * eval.c: Revert.
4290         * elfread.c: Revert.
4291         * dwarf2read.h: Revert.
4292         * dwarf2read.c: Revert.
4293         * dwarf2loc.c: Revert.
4294         * dwarf2expr.h: Revert.
4295         * dwarf2expr.c: Revert.
4296         * dwarf2-frame.c: Revert.
4297         * dwarf2-frame-tailcall.c: Revert.
4298         * dwarf-index-write.h: Revert.
4299         * dwarf-index-write.c: Revert.
4300         * dwarf-index-common.c: Revert.
4301         * dwarf-index-cache.h: Revert.
4302         * dwarf-index-cache.c: Revert.
4303         * dummy-frame.c: Revert.
4304         * dtrace-probe.c: Revert.
4305         * disasm.h: Revert.
4306         * disasm.c: Revert.
4307         * disasm-selftests.c: Revert.
4308         * dictionary.c: Revert.
4309         * dicos-tdep.c: Revert.
4310         * demangle.c: Revert.
4311         * dcache.h: Revert.
4312         * dcache.c: Revert.
4313         * darwin-nat.h: Revert.
4314         * darwin-nat.c: Revert.
4315         * darwin-nat-info.c: Revert.
4316         * d-valprint.c: Revert.
4317         * d-namespace.c: Revert.
4318         * d-lang.c: Revert.
4319         * ctf.c: Revert.
4320         * csky-tdep.c: Revert.
4321         * csky-linux-tdep.c: Revert.
4322         * cris-tdep.c: Revert.
4323         * cris-linux-tdep.c: Revert.
4324         * cp-valprint.c: Revert.
4325         * cp-support.c: Revert.
4326         * cp-namespace.c: Revert.
4327         * cp-abi.c: Revert.
4328         * corelow.c: Revert.
4329         * corefile.c: Revert.
4330         * continuations.c: Revert.
4331         * completer.h: Revert.
4332         * completer.c: Revert.
4333         * complaints.c: Revert.
4334         * coffread.c: Revert.
4335         * coff-pe-read.c: Revert.
4336         * cli-out.h: Revert.
4337         * cli-out.c: Revert.
4338         * charset.c: Revert.
4339         * c-varobj.c: Revert.
4340         * c-valprint.c: Revert.
4341         * c-typeprint.c: Revert.
4342         * c-lang.c: Revert.
4343         * buildsym.c: Revert.
4344         * buildsym-legacy.c: Revert.
4345         * build-id.h: Revert.
4346         * build-id.c: Revert.
4347         * btrace.c: Revert.
4348         * bsd-uthread.c: Revert.
4349         * breakpoint.h: Revert.
4350         * breakpoint.c: Revert.
4351         * break-catch-throw.c: Revert.
4352         * break-catch-syscall.c: Revert.
4353         * break-catch-sig.c: Revert.
4354         * blockframe.c: Revert.
4355         * block.c: Revert.
4356         * bfin-tdep.c: Revert.
4357         * bfin-linux-tdep.c: Revert.
4358         * bfd-target.c: Revert.
4359         * bcache.c: Revert.
4360         * ax-general.c: Revert.
4361         * ax-gdb.h: Revert.
4362         * ax-gdb.c: Revert.
4363         * avr-tdep.c: Revert.
4364         * auxv.c: Revert.
4365         * auto-load.c: Revert.
4366         * arm-wince-tdep.c: Revert.
4367         * arm-tdep.c: Revert.
4368         * arm-symbian-tdep.c: Revert.
4369         * arm-pikeos-tdep.c: Revert.
4370         * arm-obsd-tdep.c: Revert.
4371         * arm-nbsd-tdep.c: Revert.
4372         * arm-nbsd-nat.c: Revert.
4373         * arm-linux-tdep.c: Revert.
4374         * arm-linux-nat.c: Revert.
4375         * arm-fbsd-tdep.c: Revert.
4376         * arm-fbsd-nat.c: Revert.
4377         * arm-bsd-tdep.c: Revert.
4378         * arch-utils.c: Revert.
4379         * arc-tdep.c: Revert.
4380         * arc-newlib-tdep.c: Revert.
4381         * annotate.h: Revert.
4382         * annotate.c: Revert.
4383         * amd64-windows-tdep.c: Revert.
4384         * amd64-windows-nat.c: Revert.
4385         * amd64-tdep.c: Revert.
4386         * amd64-sol2-tdep.c: Revert.
4387         * amd64-obsd-tdep.c: Revert.
4388         * amd64-obsd-nat.c: Revert.
4389         * amd64-nbsd-tdep.c: Revert.
4390         * amd64-nbsd-nat.c: Revert.
4391         * amd64-nat.c: Revert.
4392         * amd64-linux-tdep.c: Revert.
4393         * amd64-linux-nat.c: Revert.
4394         * amd64-fbsd-tdep.c: Revert.
4395         * amd64-fbsd-nat.c: Revert.
4396         * amd64-dicos-tdep.c: Revert.
4397         * amd64-darwin-tdep.c: Revert.
4398         * amd64-bsd-nat.c: Revert.
4399         * alpha-tdep.c: Revert.
4400         * alpha-obsd-tdep.c: Revert.
4401         * alpha-nbsd-tdep.c: Revert.
4402         * alpha-mdebug-tdep.c: Revert.
4403         * alpha-linux-tdep.c: Revert.
4404         * alpha-linux-nat.c: Revert.
4405         * alpha-bsd-tdep.c: Revert.
4406         * alpha-bsd-nat.c: Revert.
4407         * aix-thread.c: Revert.
4408         * agent.c: Revert.
4409         * addrmap.c: Revert.
4410         * ada-varobj.c: Revert.
4411         * ada-valprint.c: Revert.
4412         * ada-typeprint.c: Revert.
4413         * ada-tasks.c: Revert.
4414         * ada-lang.c: Revert.
4415         * aarch64-tdep.c: Revert.
4416         * aarch64-ravenscar-thread.c: Revert.
4417         * aarch64-newlib-tdep.c: Revert.
4418         * aarch64-linux-tdep.c: Revert.
4419         * aarch64-linux-nat.c: Revert.
4420         * aarch64-fbsd-tdep.c: Revert.
4421         * aarch64-fbsd-nat.c: Revert.
4422         * aarch32-linux-nat.c: Revert.
4423
4424 2019-04-05  Tom Tromey  <tom@tromey.com>
4425
4426         * ft32-tdep.c: Sort headers.
4427         * frv-tdep.c: Sort headers.
4428         * frv-linux-tdep.c: Sort headers.
4429         * frame.c: Sort headers.
4430         * frame-unwind.c: Sort headers.
4431         * frame-base.c: Sort headers.
4432         * fork-child.c: Sort headers.
4433         * findvar.c: Sort headers.
4434         * findcmd.c: Sort headers.
4435         * filesystem.c: Sort headers.
4436         * filename-seen-cache.h: Sort headers.
4437         * filename-seen-cache.c: Sort headers.
4438         * fbsd-tdep.c: Sort headers.
4439         * fbsd-nat.h: Sort headers.
4440         * fbsd-nat.c: Sort headers.
4441         * f-valprint.c: Sort headers.
4442         * f-typeprint.c: Sort headers.
4443         * f-lang.c: Sort headers.
4444         * extension.h: Sort headers.
4445         * extension.c: Sort headers.
4446         * extension-priv.h: Sort headers.
4447         * expprint.c: Sort headers.
4448         * exec.h: Sort headers.
4449         * exec.c: Sort headers.
4450         * exceptions.c: Sort headers.
4451         * event-top.c: Sort headers.
4452         * event-loop.c: Sort headers.
4453         * eval.c: Sort headers.
4454         * elfread.c: Sort headers.
4455         * dwarf2read.h: Sort headers.
4456         * dwarf2read.c: Sort headers.
4457         * dwarf2loc.c: Sort headers.
4458         * dwarf2expr.h: Sort headers.
4459         * dwarf2expr.c: Sort headers.
4460         * dwarf2-frame.c: Sort headers.
4461         * dwarf2-frame-tailcall.c: Sort headers.
4462         * dwarf-index-write.h: Sort headers.
4463         * dwarf-index-write.c: Sort headers.
4464         * dwarf-index-common.c: Sort headers.
4465         * dwarf-index-cache.h: Sort headers.
4466         * dwarf-index-cache.c: Sort headers.
4467         * dummy-frame.c: Sort headers.
4468         * dtrace-probe.c: Sort headers.
4469         * disasm.h: Sort headers.
4470         * disasm.c: Sort headers.
4471         * disasm-selftests.c: Sort headers.
4472         * dictionary.c: Sort headers.
4473         * dicos-tdep.c: Sort headers.
4474         * demangle.c: Sort headers.
4475         * dcache.h: Sort headers.
4476         * dcache.c: Sort headers.
4477         * darwin-nat.h: Sort headers.
4478         * darwin-nat.c: Sort headers.
4479         * darwin-nat-info.c: Sort headers.
4480         * d-valprint.c: Sort headers.
4481         * d-namespace.c: Sort headers.
4482         * d-lang.c: Sort headers.
4483         * ctf.c: Sort headers.
4484         * csky-tdep.c: Sort headers.
4485         * csky-linux-tdep.c: Sort headers.
4486         * cris-tdep.c: Sort headers.
4487         * cris-linux-tdep.c: Sort headers.
4488         * cp-valprint.c: Sort headers.
4489         * cp-support.c: Sort headers.
4490         * cp-namespace.c: Sort headers.
4491         * cp-abi.c: Sort headers.
4492         * corelow.c: Sort headers.
4493         * corefile.c: Sort headers.
4494         * continuations.c: Sort headers.
4495         * completer.h: Sort headers.
4496         * completer.c: Sort headers.
4497         * complaints.c: Sort headers.
4498         * coffread.c: Sort headers.
4499         * coff-pe-read.c: Sort headers.
4500         * cli-out.h: Sort headers.
4501         * cli-out.c: Sort headers.
4502         * charset.c: Sort headers.
4503         * c-varobj.c: Sort headers.
4504         * c-valprint.c: Sort headers.
4505         * c-typeprint.c: Sort headers.
4506         * c-lang.c: Sort headers.
4507         * buildsym.c: Sort headers.
4508         * buildsym-legacy.c: Sort headers.
4509         * build-id.h: Sort headers.
4510         * build-id.c: Sort headers.
4511         * btrace.c: Sort headers.
4512         * bsd-uthread.c: Sort headers.
4513         * breakpoint.h: Sort headers.
4514         * breakpoint.c: Sort headers.
4515         * break-catch-throw.c: Sort headers.
4516         * break-catch-syscall.c: Sort headers.
4517         * break-catch-sig.c: Sort headers.
4518         * blockframe.c: Sort headers.
4519         * block.c: Sort headers.
4520         * bfin-tdep.c: Sort headers.
4521         * bfin-linux-tdep.c: Sort headers.
4522         * bfd-target.c: Sort headers.
4523         * bcache.c: Sort headers.
4524         * ax-general.c: Sort headers.
4525         * ax-gdb.h: Sort headers.
4526         * ax-gdb.c: Sort headers.
4527         * avr-tdep.c: Sort headers.
4528         * auxv.c: Sort headers.
4529         * auto-load.c: Sort headers.
4530         * arm-wince-tdep.c: Sort headers.
4531         * arm-tdep.c: Sort headers.
4532         * arm-symbian-tdep.c: Sort headers.
4533         * arm-pikeos-tdep.c: Sort headers.
4534         * arm-obsd-tdep.c: Sort headers.
4535         * arm-nbsd-tdep.c: Sort headers.
4536         * arm-nbsd-nat.c: Sort headers.
4537         * arm-linux-tdep.c: Sort headers.
4538         * arm-linux-nat.c: Sort headers.
4539         * arm-fbsd-tdep.c: Sort headers.
4540         * arm-fbsd-nat.c: Sort headers.
4541         * arm-bsd-tdep.c: Sort headers.
4542         * arch-utils.c: Sort headers.
4543         * arc-tdep.c: Sort headers.
4544         * arc-newlib-tdep.c: Sort headers.
4545         * annotate.h: Sort headers.
4546         * annotate.c: Sort headers.
4547         * amd64-windows-tdep.c: Sort headers.
4548         * amd64-windows-nat.c: Sort headers.
4549         * amd64-tdep.c: Sort headers.
4550         * amd64-sol2-tdep.c: Sort headers.
4551         * amd64-obsd-tdep.c: Sort headers.
4552         * amd64-obsd-nat.c: Sort headers.
4553         * amd64-nbsd-tdep.c: Sort headers.
4554         * amd64-nbsd-nat.c: Sort headers.
4555         * amd64-nat.c: Sort headers.
4556         * amd64-linux-tdep.c: Sort headers.
4557         * amd64-linux-nat.c: Sort headers.
4558         * amd64-fbsd-tdep.c: Sort headers.
4559         * amd64-fbsd-nat.c: Sort headers.
4560         * amd64-dicos-tdep.c: Sort headers.
4561         * amd64-darwin-tdep.c: Sort headers.
4562         * amd64-bsd-nat.c: Sort headers.
4563         * alpha-tdep.c: Sort headers.
4564         * alpha-obsd-tdep.c: Sort headers.
4565         * alpha-nbsd-tdep.c: Sort headers.
4566         * alpha-mdebug-tdep.c: Sort headers.
4567         * alpha-linux-tdep.c: Sort headers.
4568         * alpha-linux-nat.c: Sort headers.
4569         * alpha-bsd-tdep.c: Sort headers.
4570         * alpha-bsd-nat.c: Sort headers.
4571         * aix-thread.c: Sort headers.
4572         * agent.c: Sort headers.
4573         * addrmap.c: Sort headers.
4574         * ada-varobj.c: Sort headers.
4575         * ada-valprint.c: Sort headers.
4576         * ada-typeprint.c: Sort headers.
4577         * ada-tasks.c: Sort headers.
4578         * ada-lang.c: Sort headers.
4579         * aarch64-tdep.c: Sort headers.
4580         * aarch64-ravenscar-thread.c: Sort headers.
4581         * aarch64-newlib-tdep.c: Sort headers.
4582         * aarch64-linux-tdep.c: Sort headers.
4583         * aarch64-linux-nat.c: Sort headers.
4584         * aarch64-fbsd-tdep.c: Sort headers.
4585         * aarch64-fbsd-nat.c: Sort headers.
4586         * aarch32-linux-nat.c: Sort headers.
4587
4588 2019-04-04  Tom Tromey  <tom@tromey.com>
4589
4590         * varobj.c (varobj_create): Update.
4591         * rust-exp.y (struct rust_parser) <update_innermost_block,
4592         lookup_symbol>: New methods.
4593         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4594         Rename.
4595         (rust_parser::rust_lookup_type)
4596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4597         * printcmd.c (display_command, do_one_display): Update.
4598         * parser-defs.h (struct parser_state) <parser_state>: Add
4599         "tracker" parameter.
4600         (block_tracker): New member.
4601         (class innermost_block_tracker) <innermost_block_tracker>: Add
4602         "types" parameter.
4603         <reset>: Remove method.
4604         (innermost_block): Don't declare.
4605         (null_post_parser): Update.
4606         * parse.c (innermost_block): Remove global.
4607         (write_dollar_variable): Update.
4608         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4609         Remove "tracker_types" parameter.
4610         (parse_expression): Add "tracker" parameter.
4611         (parse_expression_for_completion): Update.
4612         (null_post_parser): Add "tracker" parameter.
4613         * p-exp.y: Update rules.
4614         * m2-exp.y: Update rules.
4615         * language.h (struct language_defn) <la_post_parser>: Add
4616         "tracker" parameter.
4617         * go-exp.y: Update rules.
4618         * f-exp.y: Update rules.
4619         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4620         parameter.
4621         * d-exp.y: Update rules.
4622         * c-exp.y: Update rules.
4623         * breakpoint.c (set_breakpoint_condition): Create an
4624         innermost_block_tracker.
4625         (watch_command_1): Likewise.
4626         * ada-lang.c (resolve): Add "tracker" parameter.
4627         (resolve_subexp): Likewise.
4628         * ada-exp.y (write_var_from_sym): Update.
4629
4630 2019-04-04  Tom Tromey  <tom@tromey.com>
4631
4632         * type-stack.h: New file.
4633         * type-stack.c: New file.
4634         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4635         type-stack.h.
4636         (insert_into_type_stack, insert_type, push_type, push_type_int)
4637         (insert_type_address_space, pop_type, pop_type_int)
4638         (pop_typelist, pop_type_stack, append_type_stack)
4639         (push_type_stack, get_type_stack, push_typelist)
4640         (follow_type_instance_flags, follow_types): Don't declare.
4641         * parse.c (type_stack): Remove global.
4642         (parse_exp_in_context): Update.
4643         (insert_into_type_stack, insert_type, push_type, push_type_int)
4644         (insert_type_address_space, pop_type, pop_type_int)
4645         (pop_typelist, pop_type_stack, append_type_stack)
4646         (push_type_stack, get_type_stack, push_typelist)
4647         (follow_type_instance_flags, follow_types): Remove (moved to
4648         type-stack.c).
4649         * f-exp.y (type_stack): New global.
4650         Update rules.
4651         (push_kind_type, f_parse): Update.
4652         * d-exp.y (type_stack): New global.
4653         Update rules.
4654         (d_parse): Update.
4655         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4656         Update rules.
4657         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4658         (HFILES_NO_SRCDIR): Add type-stack.h.
4659
4660 2019-04-04  Tom Tromey  <tom@tromey.com>
4661
4662         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4663         (rust_parser::convert_ast_to_expression, rust_parse)
4664         (rust_lex_test_completion, rust_lex_tests): Update.
4665         * parser-defs.h (struct expr_completion_state): New.
4666         (struct parser_state) <parser_state>: Add completion parameter.
4667         <mark_struct_expression, mark_completion_tag>: New methods.
4668         <parse_completion, m_completion_state>: New members.
4669         (prefixify_expression, null_post_parser): Update.
4670         (mark_struct_expression, mark_completion_tag): Don't declare.
4671         * parse.c (parse_completion, expout_last_struct)
4672         (expout_tag_completion_type, expout_completion_name): Remove
4673         globals.
4674         (parser_state::mark_struct_expression)
4675         (parser_state::mark_completion_tag): Now methods.
4676         (prefixify_expression): Add last_struct parameter.
4677         (prefixify_subexp): Likewise.
4678         (parse_exp_1): Update.
4679         (parse_exp_in_context): Add cstate parameter.  Update.
4680         (parse_expression_for_completion): Create an
4681         expr_completion_state.
4682         (null_post_parser): Add "completion" parameter.
4683         * p-exp.y: Update rules.
4684         (yylex): Update.
4685         * language.h (struct language_defn) <la_post_parser>: Add
4686         "completing" parameter.
4687         * go-exp.y: Update rules.
4688         (lex_one_token): Update.
4689         * expression.h (parse_completion): Don't declare.
4690         * d-exp.y: Update rules.
4691         (lex_one_token): Update rules.
4692         * c-exp.y: Update rules.
4693         (lex_one_token): Update.
4694         * ada-lang.c (resolve): Add "parse_completion" parameter.
4695         (resolve_subexp): Likewise.
4696         (ada_resolve_function): Likewise.
4697
4698 2019-04-04  Tom Tromey  <tom@tromey.com>
4699
4700         * parser-defs.h (struct parser_state) <start_arglist,
4701         end_arglist>: New methods.
4702         <arglist_len, m_funcall_chain>: New members.
4703         (arglist_len, start_arglist, end_arglist): Don't declare.
4704         * parse.c (arglist_len, funcall_chain): Remove global.
4705         (start_arglist, end_arglist): Remove functions.
4706         (parse_exp_in_context): Update.
4707         * p-exp.y: Update rules.
4708         * m2-exp.y: Update rules.
4709         * go-exp.y: Update rules.
4710         * f-exp.y: Update rules.
4711         * d-exp.y: Update rules.
4712         * c-exp.y: Update rules.
4713
4714 2019-04-04  Tom Tromey  <tom@tromey.com>
4715
4716         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4717         lex_operator, push_back>: New methods.
4718         Update all rules.
4719         (rust_parser::lex_hex, lex_escape): Rename and update.
4720         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4721         (rust_parser::lex_operator): Rename and update.
4722         (rust_parser::lex_number, rustyylex, rustyyerror)
4723         (rust_lex_test_init, rust_lex_test_sequence)
4724         (rust_lex_test_push_back, rust_lex_tests): Update.
4725         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4726         parameter.
4727         <lexptr, prev_lexptr>: New members.
4728         (lexptr, prev_lexptr): Don't declare.
4729         * parse.c (lexptr, prev_lexptr): Remove globals.
4730         (parse_exp_in_context): Update.
4731         * p-exp.y (yylex, yyerror): Update.
4732         * m2-exp.y (parse_number, yylex, yyerror): Update.
4733         * go-exp.y (lex_one_token, yyerror): Update.
4734         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4735         * d-exp.y (lex_one_token, yyerror): Update.
4736         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4737         (lex_one_token, yyerror): Update.
4738         * ada-lex.l (YY_INPUT): Update.
4739         (rewind_to_char): Update.
4740         * ada-exp.y (yyerror): Update.
4741
4742 2019-04-04  Tom Tromey  <tom@tromey.com>
4743
4744         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4745         * parser-defs.h (struct parser_state) <parser_state>: Add new
4746         parameter.
4747         <comma_terminates>: New member.
4748         (comma_terminates): Don't declare global.
4749         * parse.c (comma_terminates): Remove global.
4750         (parse_exp_in_context): Update.
4751         * p-exp.y (yylex): Update.
4752         * m2-exp.y (yylex): Update.
4753         * go-exp.y (lex_one_token): Update.
4754         * f-exp.y (yylex): Update.
4755         * d-exp.y (lex_one_token): Update.
4756         * c-exp.y (lex_one_token): Update.
4757         * ada-lex.l: Update.
4758
4759 2019-04-04  Tom Tromey  <tom@tromey.com>
4760
4761         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4762         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4763         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4764         * parser-defs.h (paren_depth): Don't declare.
4765         * parse.c (paren_depth): Remove global.
4766         (parse_exp_in_context): Update.
4767         * p-exp.y (paren_depth): New global.
4768         (pascal_parse): Initialize it.
4769         * m2-exp.y (paren_depth): New global.
4770         (m2_parse): Initialize it.
4771         * go-exp.y (paren_depth): New global.
4772         (go_parse): Initialize it.
4773         * f-exp.y (paren_depth): New global.
4774         (f_parse): Initialize it.
4775         * d-exp.y (paren_depth): New global.
4776         (d_parse): Initialize it.
4777         * c-exp.y (paren_depth): New global.
4778         (c_parse): Initialize it.
4779         * ada-lex.l (paren_depth): New global.
4780         (lexer_init): Initialize it.
4781
4782 2019-04-04  Tom Tromey  <tom@tromey.com>
4783
4784         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4785         (rust_parser::convert_ast_to_type)
4786         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4787         * parser-defs.h (struct parser_state) <parser_state>: Add
4788         parameters.  Initialize new members.
4789         <expression_context_block, expression_context_pc>: New members.
4790         * parse.c (expression_context_block, expression_context_pc):
4791         Remove globals.
4792         (parse_exp_in_context): Update.
4793         * p-exp.y: Update all rules.
4794         (yylex): Update.
4795         * m2-exp.y: Update all rules.
4796         (yylex): Update.
4797         * go-exp.y (yylex): Update.
4798         * f-exp.y (yylex): Update.
4799         * d-exp.y: Update all rules.
4800         (yylex): Update.
4801         * c-exp.y: Update all rules.
4802         (lex_one_token, classify_name, yylex, c_parse): Update.
4803         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4804
4805 2019-04-04  Tom Tromey  <tom@tromey.com>
4806
4807         * gdbarch.h, gdbarch.c: Rebuild.
4808         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4809         * stap-probe.h:
4810         (struct stap_parse_info): Replace "parser_state" with
4811         "expr_builder".
4812         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4813         (parser_state): New class.
4814         * parse.c (expr_builder): Rename.
4815         (expr_builder::release): Rename.
4816         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4817         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4818         (write_exp_elt_longcst, write_exp_elt_floatcst)
4819         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4820         (write_exp_string_vector, write_exp_bitstring)
4821         (write_exp_msymbol, mark_struct_expression)
4822         (write_dollar_variable)
4823         (insert_type_address_space, increase_expout_size): Replace
4824         "parser_state" with "expr_builder".
4825         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4826         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4827         "parser_state" with "expr_builder".
4828
4829 2019-04-04  Tom Tromey  <tom@tromey.com>
4830
4831         * rust-exp.y: Replace "parse_language" with method call.
4832         * p-exp.y:
4833         (yylex): Replace "parse_language" with method call.
4834         * m2-exp.y:
4835         (yylex): Replace "parse_language" with method call.
4836         * go-exp.y (classify_name): Replace "parse_language" with method
4837         call.
4838         * f-exp.y (yylex): Replace "parse_language" with method call.
4839         * d-exp.y (lex_one_token): Replace "parse_language" with method
4840         call.
4841         * c-exp.y:
4842         (lex_one_token, classify_name, yylex): Replace "parse_language"
4843         with method call.
4844         * ada-exp.y (find_primitive_type, type_char)
4845         (type_system_address): Replace "parse_language" with method call.
4846
4847 2019-04-04  Tom Tromey  <tom@tromey.com>
4848
4849         * rust-exp.y: Replace "parse_gdbarch" with method call.
4850         * parse.c (write_dollar_variable, insert_type_address_space):
4851         Replace "parse_gdbarch" with method call.
4852         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4853         call.
4854         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4855         call.
4856         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4857         "parse_gdbarch" with method call.
4858         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4859         with method call.
4860         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4861         "parse_gdbarch" with method call.
4862         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4863         "parse_gdbarch" with method call.
4864         * c-exp.y (parse_type, parse_number, classify_name): Replace
4865         "parse_gdbarch" with method call.
4866         * ada-lex.l: Replace "parse_gdbarch" with method call.
4867         * ada-exp.y (parse_type, find_primitive_type, type_char)
4868         (type_system_address): Replace "parse_gdbarch" with method call.
4869
4870 2019-04-04  Tom Tromey  <tom@tromey.com>
4871
4872         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4873         * stap-probe.c (stap_parse_argument): Update.
4874         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4875         initial_size parameter.
4876         * rust-exp.y (rust_lex_tests): Update.
4877         * parse.c (parser_state): Update.
4878         (parse_exp_in_context): Update.
4879         * parser-defs.h (struct parser_state) <parser_state>: Remove
4880         "initial_size" parameter.
4881
4882 2019-04-04  Tom Tromey  <tom@tromey.com>
4883
4884         * parser-defs.h (increase_expout_size): Don't declare.
4885         * parse.c (increase_expout_size): Now static.
4886
4887 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4888
4889         * gnu-nat.c (gnu_nat_target::wait): Fix
4890         target_waitstatus_to_string call.
4891
4892 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * eval.c (evaluate_subexp_standard): Handle internal functions
4895         during Fortran function call handling.
4896
4897 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * NEWS: Mention new internal functions.
4900         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4901         (read_base_type): Use dwarf2_init_complex_target_type.
4902         * value.c (creal_internal_fn): New function.
4903         (cimag_internal_fn): New function.
4904         (_initialize_values): Register new internal functions.
4905
4906 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4907
4908         * infrun.c (stop_all_threads): If debug_infrun, always
4909         trace the wait status after wait_one, using
4910         target_waitstatus_to_string and target_pid_to_str.
4911         (handle_inferior_event): Replace various trace of
4912         wait status kind by a single trace.
4913         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4914         wait status kind image by target_waitstatus_to_string.
4915         * target/waitstatus.c (target_waitstatus_to_string): Fix
4916         obsolete comment.
4917
4918 2019-04-01  Tom Tromey  <tromey@adacore.com>
4919
4920         PR symtab/23331:
4921         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4922
4923 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4924             Pedro Alves  <palves@redhat.com>
4925
4926         * top.c (quit_force): Call 'finalize_values'.
4927         * value.c (finalize_values): New function.
4928         * value.h (finalize_values): Declare.
4929
4930 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4931
4932         * NEWS: Announce $_gdb_major and $_gdb_minor.
4933
4934         * top.c (init_gdb_version_vars): New function.
4935         (gdb_init): Call init_gdb_version_vars.
4936
4937 2019-03-29  Tom Tromey  <tromey@adacore.com>
4938
4939         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4940         help text.  Remove dead code.
4941
4942 2019-03-29  Keith Seitz  <keiths@redhat.com>
4943
4944         From Siddhesh Poyarekar:
4945         * f-lang.h (f77_get_upperbound): Return LONGEST.
4946         (f77_get_lowerbound): Likewise.
4947         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4948         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4949         print them.
4950         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4951         plongest to format print it.
4952         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4953         (f77_get_upperbound): Likewise.
4954         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4955         LOWER_BOUND to LONGEST.
4956         (f77_create_arrayprint_offset_tbl): Likewise.
4957
4958 2019-03-29  Keith Seitz  <keiths@redhat.com>
4959
4960         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4961         %s/pulongest for TYPE_LENGTH instead of %d in format
4962         strings.
4963         * ada-typerint.c (ada_print_type): Likewise.
4964         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4965         * compile/compile-c-support.c (generate_register_struct): Likewise.
4966         * gdbtypes.c (recursive_dump_type): Likewise.
4967         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4968         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4969         instead of %d in format strings.
4970         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4971         to std::min to ULONGEST.
4972         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4973         instead of %d in format strings.
4974         * tracepoint.c (info_scope_command): Likewise.
4975         * typeprint.c (print_offset_data::update)
4976         (print_offset_data::finish): Likewise.
4977         * xtensa-tdep.c (xtensa_store_return_value)
4978         (xtensa_push_dummy_call): Likewise.
4979
4980 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4981
4982         * windows-nat.c (display_selector): Fixed format specifications
4983         for 64-bit Cygwin.
4984
4985 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4986
4987         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4988
4989 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4990
4991         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4992         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4993         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4994         (nios2_linux_init_abi): Install it.
4995
4996 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4999
5000 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5001
5002         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5003
5004 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5005             Tom Tromey  <tromey@adacore.com>
5006
5007         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5008
5009 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5010
5011         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5012         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5013         method to compute the bounds of range types. Also print "[evaluated]"
5014         if the bounds' values come from a dynamic evaluation.
5015
5016 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5019         whitespace when pretty printing is on.
5020
5021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5022
5023         * ppc-linux-nat.c: Add include.
5024
5025 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5026
5027         * NEWS: Mention AArch64 Pointer Authentication.
5028
5029 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5030
5031         * arm-linux-nat.c: Add include.
5032
5033 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5034
5035         * source-cache.c (source_cache::get_source_lines): Re-read
5036         fullname after calling open_source_file.
5037
5038 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5039
5040         * NEWS: Mention TLS support for FreeBSD.
5041
5042 2019-03-25  Tom Tromey  <tromey@adacore.com>
5043
5044         * minsyms.c (BUNCH_SIZE): Update comment.
5045         (~minimal_symbol_reader): Remove old comment.
5046         (compact_minimal_symbols): Update comment.
5047         (minimal_symbol_reader::install): Remove old comment.  Update
5048         other comments.
5049
5050 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5051
5052         * s390-linux-nat.c: Add include.
5053
5054 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5055
5056         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5057         Call linux_get_hwcap.
5058         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5059         Likewise.
5060         (aarch64_linux_get_hwcap): Remove function.
5061         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5062         declaration.
5063         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5064         linux_get_hwcap.
5065         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5066         * linux-tdep.c (linux_get_hwcap): Add function.
5067         (linux_get_hwcap2): Likewise.
5068         * linux-tdep.h (linux_get_hwcap): Add declaration.
5069         (linux_get_hwcap2): Likewise.
5070         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5071         (ppc_linux_get_hwcap2): Likewise.
5072         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5073         linux_get_hwcap.
5074         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5075         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5076         (ppc_linux_nat_target::read_description): Likewise.
5077         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5078         * s390-linux-nat.c: Likewise.
5079         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5080
5081 2019-03-24  Tom Tromey  <tom@tromey.com>
5082
5083         * ada-lang.c (standard_lookup): Simplify initialization.
5084         (ada_lookup_symbol_nonlocal): Simplify return.
5085         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5086         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5087         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5088         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5089         initialization.
5090         * solib.c (solib_global_lookup): Simplify.
5091         * symtab.c (null_block_symbol): Remove.
5092         (symbol_cache_lookup): Simplify returns.
5093         (lookup_language_this): Simplify returns.
5094         (lookup_symbol_aux): Simplify return.
5095         (lookup_local_symbol): Simplify returns.
5096         (lookup_global_symbol_from_objfile): Simplify return.
5097         (lookup_symbol_in_objfile_symtabs)
5098         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5099         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5100         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5101         * cp-namespace.c (cp_lookup_bare_symbol)
5102         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5103         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5104         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5105         (cp_lookup_symbol_via_imports): Simplify initialization.
5106         (find_symbol_in_baseclass): Likewise.
5107         * symtab.h (null_block_symbol): Remove.
5108         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5109         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5110         (d_lookup_symbol_module): Likewise.
5111         (find_symbol_in_baseclass): Simplify initialization.
5112
5113 2019-03-24  Tom Tromey  <tom@tromey.com>
5114
5115         * expression.h: Don't include symtab.h.
5116         (struct block): Forward declare.
5117
5118 2019-03-24  Tom Tromey  <tom@tromey.com>
5119
5120         * c-exp.y (typebase): Remove casts.
5121         * gdbtypes.c (lookup_unsigned_typename, )
5122         (lookup_signed_typename): Remove cast.
5123         * eval.c (parse_to_comma_and_eval): Remove cast.
5124         * parse.c (write_dollar_variable): Remove cast.
5125         * block.h (struct block) <superblock>: Now const.
5126         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5127         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5128         (map_block): Make "block" const.
5129         * symfile.h (struct quick_symbol_functions)
5130         <map_matching_symbols>: Constify block argument to "callback".
5131         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5132         const.
5133         (find_pc_sect_compunit_symtab): Make "b" const.
5134         (find_symbol_at_address): Likewise.
5135         (search_symbols): Likewise.
5136         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5137         (dw2_debug_names_lookup_symbol): Likewise.
5138         (dw2_map_matching_symbols): Update.
5139         * p-valprint.c (pascal_val_print): Remove "block".
5140         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5141         (aux_add_nonlocal_symbols): Make "block" const.
5142         (resolve_subexp): Remove cast.
5143         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5144         const.
5145         (iterate_over_file_blocks): Likewise.
5146         * f-exp.y (%union) <bval>: Remove.
5147         * coffread.c (patch_opaque_types): Make "b" const.
5148         * spu-tdep.c (spu_catch_start): Make "block" const.
5149         * c-valprint.c (print_unpacked_pointer): Remove "block".
5150         * symmisc.c (dump_symtab_1): Make "b" const.
5151         (block_depth): Make "block" const.
5152         * d-exp.y (%union) <bval>: Remove.
5153         * cp-support.h (cp_lookup_rtti_type): Update.
5154         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5155         * psymtab.c (psym_lookup_symbol): Make "block" const.
5156         (maintenance_check_psymtabs): Make "b" const.
5157         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5158         (enumerate_locals, enumerate_args): Update.
5159         * python/py-symtab.c (stpy_global_block): Make "block" const.
5160         (stpy_static_block): Likewise.
5161         * inline-frame.c (block_starting_point_at): Make "new_block"
5162         const.
5163         * block.c (find_block_in_blockvector): Make return type const.
5164         (blockvector_for_pc_sect): Make "b" const.
5165         (find_block_in_blockvector): Make "b" const.
5166
5167 2019-03-23  Tom Tromey  <tom@tromey.com>
5168
5169         * varobj.c (varobj_create): Update.
5170         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5171         * printcmd.c (display_command, do_one_display): Don't reset
5172         innermost_block.
5173         * parser-defs.h (enum innermost_block_tracker_type): Move to
5174         expression.h.
5175         (innermost_block): Update comment.
5176         * parse.c (parse_exp_1): Add tracker_types parameter.
5177         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5178         tracker_types parameter.  Reset innermost_block.
5179         (parse_exp_in_context): Remove.
5180         (parse_expression_for_completion): Update.
5181         * objfiles.c (~objfile): Don't reset expression_context_block or
5182         innermost_block.
5183         * expression.h (enum innermost_block_tracker_type): Move from
5184         parser-defs.h.
5185         (parse_exp_1): Add tracker_types parameter.
5186         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5187         reset innermost_block.
5188
5189 2019-03-23  Tom Tromey  <tom@tromey.com>
5190
5191         * objfiles.h: Include bcache.h.
5192
5193 2019-03-23  Tom Tromey  <tom@tromey.com>
5194
5195         * linespec.c (get_current_search_block): Use
5196         scoped_restore_current_language.
5197         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5198
5199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5200             Jiong Wang  <jiong.wang@arm.com>
5201
5202         * aarch64-linux-tdep.c
5203         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5204         section.
5205         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5206
5207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5208             Jiong Wang  <jiong.wang@arm.com>
5209
5210         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5211         instructions.
5212         (aarch64_analyze_prologue_test): Add PACIASP test.
5213         (aarch64_prologue_prev_register): Unmask PC value.
5214
5215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5216             Jiong Wang  <jiong.wang@arm.com>
5217
5218         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5219         (aarch64_dwarf2_prev_register): Unmask PC value.
5220         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5221         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5222         DW_CFA_AARCH64_negate_ra_state.
5223         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5224
5225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5226             Jiong Wang  <jiong.wang@arm.com>
5227
5228         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5229         registers.
5230         (aarch64_pseudo_register_name): Likewise.
5231         (aarch64_pseudo_register_type): Likewise.
5232         (aarch64_pseudo_register_reggroup_p): Likewise.
5233         (aarch64_gdbarch_init): Add pauth registers.
5234         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5235         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5236         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5237         (struct gdbarch_tdep): Add regnum for ra_state.
5238
5239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5240             Jiong Wang  <jiong.wang@arm.com>
5241
5242         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5243
5244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5245             Jiong Wang  <jiong.wang@arm.com>
5246
5247         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5248         function.
5249         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5250         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5251         (aarch64_gdbarch_init): Add puth registers.
5252         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5253         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5254         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5255
5256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5257             Jiong Wang  <jiong.wang@arm.com>
5258
5259         * aarch64-linux-nat.c
5260         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5261         * aarch64-linux-tdep.c
5262         (aarch64_linux_core_read_description): Likewise.
5263         (aarch64_linux_get_hwcap): New function.
5264         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5265         (aarch64_linux_get_hwcap): New declaration.
5266
5267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5268             Jiong Wang  <jiong.wang@arm.com>
5269
5270         * aarch64-linux-nat.c
5271         (aarch64_linux_nat_target::read_description): Add pauth param.
5272         * aarch64-linux-tdep.c
5273         (aarch64_linux_core_read_description): Likewise.
5274         * aarch64-tdep.c (struct target_desc): Add in pauth.
5275         (aarch64_read_description): Add pauth param.
5276         (aarch64_gdbarch_init): Likewise.
5277         * aarch64-tdep.h (aarch64_read_description): Likewise.
5278         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5279         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5280         * features/Makefile: Add new files.
5281         * features/aarch64-pauth.c: New file.
5282         * features/aarch64-pauth.xml: New file.
5283
5284 2019-03-20  Tom Tromey  <tromey@adacore.com>
5285
5286         * infrun.c (handle_inferior_event): Rename from
5287         handle_inferior_event_1.  Create a scoped_value_mark.
5288         (handle_inferior_event): Remove.
5289
5290 2019-03-19  Tom Tromey  <tromey@adacore.com>
5291
5292         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5293         * infrun.h (print_stop_event): Add "displays" parameter.
5294         * infrun.c (print_stop_event): Add "displays" parameter.
5295
5296 2019-03-19  Pedro Alves  <palves@redhat.com>
5297
5298         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5299         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5300         to -1.  Fix TABs vs spaces.
5301         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5302         * tui/tui-out.h (tui_ui_out) Add intro comments.
5303         <m_line, m_start_of_line>: In-class initialize, and add describing
5304         comment.
5305
5306 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5307
5308         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5309         variable names.
5310         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5311
5312 2019-03-18  Pedro Alves  <palves@redhat.com>
5313             Eli Zaretskii <eliz@gnu.org>
5314
5315         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5316         m_line and m_start_of_line.
5317
5318 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5319
5320         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5321         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5322         it returns a newline.  This fixes a regression in TU mode, whereby
5323         the next line is output on the same screen line as the user input.
5324
5325 2019-03-18  Tom Tromey  <tromey@adacore.com>
5326
5327         * minsyms.c (minimal_symbol_reader::install): Remove call to
5328         obstack_blank.
5329
5330 2019-03-18  Pedro Alves  <palves@redhat.com>
5331
5332         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5333         New globals.
5334         (apply_style): New, factored out from ...
5335         (apply_ansi_escape): ... this.  Handle reverse video mode.
5336         (tui_set_reverse_mode): New function.
5337         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5338         * tui/tui-winsource.c (tui_show_source_line): Use
5339         tui_set_reverse_mode instead of setting A_STANDOUT.
5340         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5341         New setter methods.
5342
5343 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5344
5345         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5346         Handle tabs.
5347
5348 2019-03-18  Tom Tromey  <tromey@adacore.com>
5349
5350         * ada-lang.c (empty_array): Add "high" parameter.
5351         (ada_evaluate_subexp): Update.
5352
5353 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5354
5355         * unittests/string_view-selftests.c: Define
5356         _initialize_string_view_selftests unconditionally.
5357
5358 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5359
5360         PR gdb/24350
5361         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5362
5363 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5364
5365         PR gdb/24351
5366         * windows-nat.c (display_selector): Fix format specifiers.
5367
5368 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5369
5370         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5371         tui_refill_source_window instead of tui_refresh_win, to update the
5372         current execution line.  This fixes redisplay of the current line
5373         when stepping through the code with "next" or "step".
5374
5375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5376
5377         * source-cache.c (source_cache::get_source_lines): Call
5378         find_source_lines to initialize s->nlines.  This fixes vertical
5379         scrolling of TUI source window when the DOWN arrow is pressed.
5380
5381 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5382
5383         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5384         linux-thread-db.c (_initialize_thread_db): Likewise.
5385
5386 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5387
5388         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5389         wclrtoeol in tui_show_source_line".  This reverts changes made in
5390         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5391
5392 2019-03-15  Tom Tromey  <tom@tromey.com>
5393
5394         * symtab.h (struct minimal_symbol): Derive from
5395         general_symbol_info.
5396         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5397         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5398         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5399         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5400         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5401         (MSYMBOL_SEARCH_NAME): Update.
5402         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5403         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5404         * minsyms.c (minimal_symbol_reader::record_full): Update.
5405
5406 2019-03-15  Tom Tromey  <tom@tromey.com>
5407
5408         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5409
5410 2019-03-15  Tom Tromey  <tom@tromey.com>
5411
5412         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5413         unique_xmalloc_ptr.
5414         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5415         Update.
5416         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5417         (build_minimal_symbol_hash_tables)
5418         (minimal_symbol_reader::install): Update.
5419
5420 2019-03-15  Tom Tromey  <tom@tromey.com>
5421
5422         * symtab.c (create_demangled_names_hash): Update.
5423         (symbol_set_names): Update.
5424         * objfiles.h (struct objfile_per_bfd_storage)
5425         <demangled_names_hash>: Now an htab_up.
5426         * objfiles.c (objfile_per_bfd_storage): Simplify.
5427
5428 2019-03-15  Tom Tromey  <tom@tromey.com>
5429
5430         * objfiles.h (struct objfile_per_bfd_storage): Declare
5431         destructor.
5432         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5433         New.
5434         (get_objfile_bfd_data): Use new.  Don't initialize
5435         language_of_main.
5436         (free_objfile_per_bfd_storage): Remove.
5437         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5438
5439 2019-03-15  Tom Tromey  <tom@tromey.com>
5440
5441         * symfile.c (reread_symbols): Update.
5442         * objfiles.c (objfile::objfile): Update.
5443         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5444         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5445         comment.
5446         (minimal_symbol_reader::install): Update.
5447         (terminate_minimal_symbol_table): Remove.
5448         * jit.c (jit_object_close_impl): Update.
5449
5450 2019-03-15  Tom Tromey  <tom@tromey.com>
5451
5452         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5453         initializations.
5454
5455 2019-03-15  Tom Tromey  <tom@tromey.com>
5456
5457         * objfiles.h (struct objfile_per_bfd_storage)
5458         <demangled_hash_languages>: Now a bitset.
5459         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5460         (lookup_minimal_symbol): Update.
5461
5462 2019-03-15  Tom Tromey  <tom@tromey.com>
5463
5464         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5465         Don't return the symbol.
5466         * coffread.c (record_minimal_symbol): Use record_full.
5467
5468 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5469
5470         The MS-Windows port of ncurses fails to switch to a color pair if
5471         one or both of the colors are the implicit default colors.  This
5472         change records the default colors when TUI is initialized, and
5473         then specifies them explicitly when a color pair uses the default
5474         colors.  This allows color styling in TUI mode on MS-Windows.
5475
5476         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5477         ncurses_norm_attr.
5478         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5479         colors in ncurses_norm_attr.
5480         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5481         "none", replace it with the default color recorded in
5482         ncurses_norm_attr.
5483
5484 2019-03-14  Tom Tromey  <tromey@adacore.com>
5485
5486         * source-cache.h (class source_cache) <get_source_lines>: Return
5487         std::string.
5488         * source-cache.c (source_cache::extract_lines): Handle case where
5489         first_pos==npos.  Return std::string.
5490         (source_cache::get_source_lines): Update.
5491
5492 2019-03-14  Tom Tromey  <tromey@adacore.com>
5493
5494         * NEWS: Add item for "style sources" commands.
5495         * source-cache.c (source_cache::get_source_lines): Check
5496         source_styling.
5497         * cli/cli-style.c (source_styling): New global.
5498         (_initialize_cli_style): Add "style sources" commands.
5499         (show_style_sources): New function.
5500         * cli/cli-style.h (source_styling): Declare.
5501
5502 2019-03-14  Pedro Alves  <palves@redhat.com>
5503             Tom Tromey  <tromey@adacore.com>
5504
5505         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5506         * tui/tui-winsource.c (tui_refill_source_window): New function,
5507         from...
5508         (tui_horizontal_source_scroll): ... here.  Move some logic.
5509         * cli/cli-style.c (set_style_enabled): Notify new observable.
5510         * tui/tui-hooks.c (tui_redisplay_source): New function.
5511         (tui_attach_detach_observers): Attach or detach
5512         tui_redisplay_source.
5513         * observable.h (source_styling_changed): New observable.
5514         * observable.c: Define source_styling_changed observable.
5515
5516 2019-03-13  Tom Tromey  <tromey@adacore.com>
5517
5518         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5519         (i386_gnu_nat_target::store_registers): Update.
5520         * target-debug.h (target_debug_print_std_string): New macro.
5521         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5522         * windows-tdep.c (display_one_tib): Update.
5523         * tui/tui-stack.c (tui_make_status_line): Update.
5524         * top.c (print_inferior_quit_action): Update.
5525         * thread.c (thr_try_catch_cmd): Update.
5526         (add_thread_with_info): Update.
5527         (thread_target_id_str): Update.
5528         (thr_try_catch_cmd): Update.
5529         (thread_command): Update.
5530         (thread_find_command): Update.
5531         * record-btrace.c (record_btrace_target::info_record)
5532         (record_btrace_resume_thread, record_btrace_target::resume)
5533         (record_btrace_cancel_resume, record_btrace_step_thread)
5534         (record_btrace_target::wait, record_btrace_target::wait)
5535         (record_btrace_target::wait, record_btrace_target::stop): Update.
5536         * progspace.c (print_program_space): Update.
5537         * process-stratum-target.c
5538         (process_stratum_target::thread_address_space): Update.
5539         * linux-fork.c (linux_fork_mourn_inferior)
5540         (detach_checkpoint_command, info_checkpoints_command)
5541         (linux_fork_context): Update.
5542         (linux_fork_detach): Update.
5543         (class scoped_switch_fork_info): Update.
5544         (delete_checkpoint_command): Update.
5545         * infrun.c (follow_fork_inferior): Update.
5546         (follow_fork_inferior): Update.
5547         (proceed_after_vfork_done): Update.
5548         (handle_vfork_child_exec_or_exit): Update.
5549         (follow_exec): Update.
5550         (displaced_step_prepare_throw): Update.
5551         (displaced_step_restore): Update.
5552         (start_step_over): Update.
5553         (resume_1): Update.
5554         (clear_proceed_status_thread): Update.
5555         (proceed): Update.
5556         (print_target_wait_results): Update.
5557         (do_target_wait): Update.
5558         (context_switch): Update.
5559         (stop_all_threads): Update.
5560         (restart_threads): Update.
5561         (finish_step_over): Update.
5562         (handle_signal_stop): Update.
5563         (switch_back_to_stepped_thread): Update.
5564         (keep_going_pass_signal): Update.
5565         (print_exited_reason): Update.
5566         (normal_stop): Update.
5567         * inferior.c (inferior_pid_to_str): Change return type.
5568         (print_selected_inferior): Update.
5569         (add_inferior): Update.
5570         (detach_inferior): Update.
5571         * dummy-frame.c (fprint_dummy_frames): Update.
5572         * dcache.c (dcache_info_1): Update.
5573         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5574         (btrace_fetch, btrace_clear): Update.
5575         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5576         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5577         type.
5578         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5579         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5580         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5581         * gdbarch.c, gdbarch.h: Rebuild.
5582         * gdbarch.sh (core_pid_to_str): Change return type.
5583         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5584         return type.
5585         (windows_nat_target::pid_to_str): Change return type.
5586         (windows_delete_thread): Update.
5587         (windows_nat_target::attach): Update.
5588         (windows_nat_target::files_info): Update.
5589         * target-delegates.c: Rebuild.
5590         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5591         return type.
5592         (sol_thread_target::pid_to_str): Change return type.
5593         * remote.c (class remote_target) <pid_to_str>: Change return
5594         type.
5595         (remote_target::pid_to_str): Change return type.
5596         (extended_remote_target::attach, remote_target::remote_stop_ns)
5597         (remote_target::remote_notif_remove_queued_reply)
5598         (remote_target::push_stop_reply, remote_target::disable_btrace):
5599         Update.
5600         (extended_remote_target::attach): Update.
5601         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5602         type.
5603         (gdbsim_target::pid_to_str): Change return type.
5604         * ravenscar-thread.c (struct ravenscar_thread_target)
5605         <pid_to_str>: Change return type.
5606         (ravenscar_thread_target::pid_to_str): Change return type.
5607         * procfs.c (class procfs_target) <pid_to_str>: Change return
5608         type.
5609         (procfs_target::pid_to_str): Change return type.
5610         (procfs_target::attach): Update.
5611         (procfs_target::detach): Update.
5612         (procfs_target::fetch_registers): Update.
5613         (procfs_target::store_registers): Update.
5614         (procfs_target::wait): Update.
5615         (procfs_target::files_info): Update.
5616         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5617         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5618         return type.
5619         (nto_procfs_target::pid_to_str): Change return type.
5620         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5621         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5622         return type.
5623         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5624         (exit_lwp): Update.
5625         (attach_proc_task_lwp_callback, get_detach_signal)
5626         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5627         (linux_nat_target::resume, wait_lwp, stop_callback)
5628         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5629         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5630         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5631         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5632         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5633         type.
5634         (inf_ptrace_target::attach): Update.
5635         (inf_ptrace_target::files_info): Update.
5636         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5637         type.
5638         (go32_nat_target::pid_to_str): Change return type.
5639         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5640         (gnu_nat_target::wait): Update.
5641         (gnu_nat_target::wait): Update.
5642         (gnu_nat_target::resume): Update.
5643         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5644         (fbsd_nat_target::wait): Update.
5645         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5646         type.
5647         (darwin_nat_target::attach): Update.
5648         * corelow.c (class core_target) <pid_to_str>: Change return type.
5649         (core_target::pid_to_str): Change return type.
5650         * target.c (normal_pid_to_str): Change return type.
5651         (default_pid_to_str): Likewise.
5652         (target_pid_to_str): Change return type.
5653         (target_translate_tls_address): Update.
5654         (target_announce_detach): Update.
5655         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5656         return type.
5657         (bsd_uthread_target::pid_to_str): Change return type.
5658         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5659         type.
5660         (bsd_kvm_target::pid_to_str): Change return type.
5661         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5662         return type.
5663         (aix_thread_target::pid_to_str): Change return type.
5664         * target.h (struct target_ops) <pid_to_str>: Change return type.
5665         (target_pid_to_str, normal_pid_to_str): Likewise.
5666         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5667         type.
5668         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5669         type.
5670         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5671         return type.
5672         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5673         type.
5674         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5675         type.
5676         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5677         return type.
5678
5679 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5680
5681         * NEWS: Mention that the new default MI version is 3.  Mention
5682         changes to the output of commands and events that deal with
5683         multi-location breakpoints.
5684         * breakpoint.c: Include "mi/mi-out.h".
5685         (print_one_breakpoint): Change output syntax if using MI version
5686         >= 3.
5687         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5688         New.
5689         (mi_multi_location_breakpoint_output_fixed): New.
5690         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5691         (mi_cmd_fix_multi_location_breakpoint_output): New.
5692         (mi_multi_location_breakpoint_output_fixed): New.
5693         * mi/mi-cmds.c (mi_cmds): Register command
5694         -fix-multi-location-breakpoint-output.
5695         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5696         interpreter "mi".
5697
5698 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5699
5700         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5701         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5702         instantiate mi_ui_out based on interpreter name.
5703         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5704         * mi/mi-main.c (mi_load_progress): Likewise.
5705
5706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5707
5708         * NEWS: Combine separate "New targets" sections for 8.3.
5709
5710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5711
5712         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5713         (ppcfbsd_init_abi): Install gdbarch
5714         "fetch_tls_load_module_address" and "get_thread_local_address"
5715         methods.
5716
5717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5718
5719         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5720         (riscv_fbsd_init_abi): Install gdbarch
5721         "fetch_tls_load_module_address" and "get_thread_local_address"
5722         methods.
5723
5724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5725
5726         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5727         (i386fbsd_init_abi): Install gdbarch
5728         "fetch_tls_load_module_address" and "get_thread_local_address"
5729         methods.
5730
5731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5732
5733         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5734         (amd64fbsd_init_abi): Install gdbarch
5735         "fetch_tls_load_module_address" and "get_thread_local_address"
5736         methods.
5737
5738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5739
5740         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5741         (struct fbsd_pspace_data): New type.
5742         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5743         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5744         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5745         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5746         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5747
5748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5749
5750         * gdbtypes.c (lookup_struct_elt): New function.
5751         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5752         * gdbtypes.h (struct struct_elt): New type.
5753         (lookup_struct_elt): New prototype.
5754
5755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5756
5757         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5758         remove disabled code block.
5759
5760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5761
5762         * gdbarch.sh (get_thread_local_address): New method.
5763         * gdbarch.h, gdbarch.c: Regenerate.
5764         * target.c (target_translate_tls_address): Use
5765         gdbarch_get_thread_local_address if present instead of
5766         target::get_thread_local_address.
5767
5768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5769
5770         * target.h (target::get_thread_local_address): Update comment.
5771
5772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5773
5774         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5775         objfile->separate_debug_objfile_backlink if not NULL.
5776
5777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5778
5779         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5780         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5781         (amd64bsd_store_inferior_registers): Likewise.
5782         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5783         Enable segment base registers.
5784         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5785         PT_GETFSBASE and PT_GETGSBASE.
5786         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5787         PT_SETGSBASE.
5788         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5789         segment base registers.
5790         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5791
5792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5793
5794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5795         Update calls to i386_target_description to add 'segments'
5796         parameter.
5797         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5798         add segment base registers.
5799         * arch/i386.c (i386_create_target_description): Add 'segments'
5800         parameter to enable segment base registers.
5801         * arch/i386.h (i386_create_target_description): Likewise.
5802         * features/i386/32bit-segments.xml: New file.
5803         * features/i386/32bit-segments.c: Generate.
5804         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5805         call to i386_target_description to add 'segments' parameter.
5806         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5807         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5808         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5809         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5810         if feature is present.
5811         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5812         Add 'segments' parameter to call to i386_target_description.
5813         (i386_target_description): Add 'segments' parameter to enable
5814         segment base registers.
5815         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5816         to call to i386_target_description.
5817         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5818         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5819         Define I386_NUM_REGS.
5820         (i386_target_description): Add 'segments' parameter to enable
5821         segment base registers.
5822
5823 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5824
5825         PR/24325
5826         * source-cache.c: #undef open and close, to avoid unresolved
5827         externals during linking.
5828
5829 2019-03-12  Tom Tromey  <tromey@adacore.com>
5830
5831         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5832         const.  Add initializers.
5833         (_initialize_remote): Don't initialize ptid globals.
5834
5835 2019-03-12  Pedro Alves  <palves@redhat.com>
5836
5837         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5838
5839 2019-03-12  Pedro Alves  <palves@redhat.com>
5840
5841         * cp-name-parser.y (main): Remove unused 'len' variable.
5842
5843 2019-03-12  Tom Tromey  <tromey@adacore.com>
5844
5845         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5846         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5847
5848 2019-03-12  Tom Tromey  <tromey@adacore.com>
5849
5850         * linux-nat.c (iterate_over_lwps): Update.
5851         (stop_callback): Remove parameter.
5852         (stop_wait_callback, detach_callback, resume_set_callback)
5853         (select_singlestep_lwp_callback, set_ignore_sigint)
5854         (status_callback, resumed_callback, resume_clear_callback)
5855         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5856         data parameter.
5857         (linux_nat_target::detach, linux_nat_target::resume)
5858         (linux_stop_and_wait_all_lwps, select_event_lwp)
5859         (linux_nat_filter_event, linux_nat_wait_1)
5860         (linux_nat_target::kill, linux_nat_target::stop)
5861         (linux_nat_target::stop): Update.
5862         (linux_nat_resume_callback): Change type.
5863         (resume_stopped_resumed_lwps, count_events_callback)
5864         (select_event_lwp_callback): Likewise.
5865         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5866         * arm-linux-nat.c (struct update_registers_data): Remove.
5867         (update_registers_callback): Change type.
5868         (arm_linux_insert_hw_breakpoint1): Update.
5869         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5870         parameter.
5871         (x86_linux_dr_set_addr): Update.
5872         (x86_linux_dr_set_control): Update.
5873         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5874         (iterate_over_lwps): Use gdb::function_view.
5875         * nat/aarch64-linux-hw-point.c (struct
5876         aarch64_dr_update_callback_param): Remove.
5877         (debug_reg_change_callback): Change type.
5878         (aarch64_notify_debug_reg_change): Update.
5879         * s390-linux-nat.c (s390_refresh_per_info): Update.
5880
5881 2019-03-11  Tom Tromey  <tromey@adacore.com>
5882
5883         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5884         redundant assignment to "this_cu".
5885
5886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5887
5888         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5889
5890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5891
5892         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5893         from...
5894         (rank_one_type): ... this.
5895
5896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5897
5898         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5899         from...
5900         (rank_one_type): ... this.
5901
5902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5903
5904         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5905         from...
5906         (rank_one_type): ... this.
5907
5908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5909
5910         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5911         from...
5912         (rank_one_type): ... this.
5913
5914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5915
5916         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5917         from...
5918         (rank_one_type): ... this.
5919
5920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5921
5922         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5923         from...
5924         (rank_one_type): ... this.
5925
5926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5927
5928         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5929         from...
5930         (rank_one_type): ... this.
5931
5932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5933
5934         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5935         from...
5936         (rank_one_type): ... this.
5937
5938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5939
5940         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5941         from...
5942         (rank_one_type): ... this.
5943
5944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5945
5946         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5947         from...
5948         (rank_one_type): ... this.
5949
5950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5951
5952         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5953         from...
5954         (rank_one_type): ... this.
5955
5956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5957
5958         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5959         from...
5960         (rank_one_type): ... this.
5961
5962 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5963
5964         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5965         inferior-events' shows the example events.
5966
5967 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5968
5969         Support styling on native MS-Windows console
5970
5971         PR/24315
5972         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5973         on MS-Windows if $TERM is not defined.
5974
5975         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5976
5977         * posix-hdep.c (gdb_console_fputs):
5978         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5979         functions.
5980         * ui-file.h (gdb_console_fputs): Add prototype.
5981
5982         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5983         back to fputs only if the former returns zero.
5984
5985 2019-03-07  Tom Tromey  <tom@tromey.com>
5986
5987         * symmisc.c (print_symbol_bcache_statistics): Update.
5988         (print_objfile_statistics): Update.
5989         * symfile.c (allocate_symtab): Update.
5990         * stabsread.c: Don't include bcache.h.
5991         * psymtab.h (struct psymbol_bcache): Don't declare.
5992         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5993         (psymbol_bcache_init, psymbol_bcache_free)
5994         (psymbol_bcache_get_bcache): Don't declare.
5995         * psymtab.c (struct psymbol_bcache): Remove.
5996         (psymtab_storage::psymtab_storage): Update.
5997         (psymtab_storage::~psymtab_storage): Update.
5998         (psymbol_bcache_init, psymbol_bcache_free)
5999         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6000         (add_psymbol_to_bcache): Update.
6001         (allocate_psymtab): Update.
6002         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6003         macro_cache>: No longer pointers.
6004         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6005         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6006         * macrotab.c (macro_bcache): Update.
6007         * macroexp.c: Don't include bcache.h.
6008         * gdbtypes.c (check_types_worklist): Update.
6009         (types_deeply_equal): Remove TRY/CATCH.  Update.
6010         * elfread.c (elf_symtab_read): Update.
6011         * dwarf2read.c: Don't include bcache.h.
6012         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6013         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6014         (print_bcache_statistics, bcache_memory_used): Don't declare.
6015         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6016         methods.  Rename all data members.
6017         * bcache.c (struct bcache): Move to bcache.h.
6018         (bcache::expand_hash_table): Rename from expand_hash_table.
6019         (bcache): Remove.
6020         (bcache::insert): Rename from bcache_full.
6021         (bcache::compare): Rename from bcache_compare.
6022         (bcache_xmalloc): Remove.
6023         (bcache::~bcache): Rename from bcache_xfree.
6024         (bcache::print_statistics): Rename from print_bcache_statistics.
6025         (bcache::memory_used): Rename from bcache_memory_used.
6026
6027 2019-03-07  Pedro Alves  <palves@redhat.com>
6028
6029         * infrun.c (normal_stop): Also check for
6030         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6031
6032 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * f-lang.c (value_from_host_double): Moved to...
6035         * value.c (value_from_host_double): ...here.
6036         * value.h (value_from_host_double): Declare.
6037         * guile/scm-math.c (vlscm_convert_typed_number): Use
6038         value_from_host_double.
6039         (vlscm_convert_number): Likewise.
6040         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6041         * python/py-value.c (convert_value_from_python): Likewise.
6042
6043 2019-03-06  Tom Tromey  <tom@tromey.com>
6044
6045         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6046
6047 2019-03-06  Tom Tromey  <tom@tromey.com>
6048
6049         * utils.h (free_current_contents): Don't declare.
6050         * utils.c (free_current_contents): Remove.
6051
6052 2019-03-06  Tom Tromey  <tom@tromey.com>
6053
6054         * top.c (quit_force): Update.
6055         * main.c (captured_command_loop): Update.
6056         * common/new-op.c (operator new): Update.
6057         * common/common-exceptions.c (struct catcher)
6058         <save_cleanup_chain>: Remove member.
6059         (exceptions_state_mc_init): Update.
6060         (exception_try_scope_entry): Return nullptr.
6061         (exception_try_scope_exit, exception_rethrow)
6062         (throw_exception_sjlj, throw_exception_cxx): Update.
6063         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6064         (all_cleanups, do_cleanups, discard_cleanups)
6065         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6066         (restore_cleanups, restore_final_cleanups): Don't declare.
6067         (do_final_cleanups): Remove parameter.
6068         * common/cleanups.c (cleanup_chain, make_cleanup)
6069         (make_cleanup_dtor, all_cleanups, do_cleanups)
6070         (discard_my_cleanups, discard_cleanups)
6071         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6072         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6073         (null_cleanup): Remove.
6074         (do_final_cleanups): Remove parameter.
6075
6076 2019-03-06  Tom Tromey  <tom@tromey.com>
6077
6078         * remote.c (remote_target::remote_parse_stop_reply): Use
6079         unique_xmalloc_ptr.
6080
6081 2019-03-06  Tom Tromey  <tom@tromey.com>
6082
6083         * stabsread.c (struct stabs_field_info): Rename from field_info.
6084         <list, fnlist>: Add initializers.
6085         <obstack>: New member.
6086         (read_member_functions, read_struct_fields, read_baseclasses):
6087         Allocate on obstack.  Don't use cleanups.
6088         (read_one_struct_field, read_member_functions, read_struct_fields)
6089         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6090         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6091         (read_struct_type): Update.
6092
6093 2019-03-06  Tom Tromey  <tom@tromey.com>
6094
6095         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6096         * common/filestuff.h (make_cleanup_close): Don't declare.
6097         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6098         Remove.
6099
6100 2019-03-06  Tom Tromey  <tom@tromey.com>
6101
6102         * solib-aix.c: Use make_scope_exit.
6103
6104 2019-03-06  Tom Tromey  <tom@tromey.com>
6105
6106         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6107         Use make_scope_exit.
6108
6109 2019-03-06  Tom Tromey  <tom@tromey.com>
6110
6111         * solib-svr4.c (disable_probes_interface): Remove parameter.
6112         (svr4_handle_solib_event): Use make_scope_exit.
6113
6114 2019-03-06  Tom Tromey  <tom@tromey.com>
6115
6116         * remote.c (struct stop_reply_deleter): Remove.
6117         (stop_reply_up): Update.
6118         (struct stop_reply): Derive from notif_event.  Don't typedef.
6119         <regcache>: Now a std::vector.
6120         (stop_reply_xfree): Remove.
6121         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6122         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6123         (remote_target::discard_pending_stop_replies): Use delete.
6124         (remote_target::remote_parse_stop_reply): Update.
6125         (remote_target::process_stop_reply): Update.
6126         * remote-notif.h (struct notif_event): Add virtual destructor.
6127         Remove "dtr" member.
6128         (struct notif_client) <alloc_event>: Return a unique_ptr.
6129         (notif_event_xfree): Don't declare.
6130         (notif_event_up): New typedef.
6131         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6132         (notif_event_xfree, do_notif_event_xfree): Remove.
6133         (remote_notif_state_xfree): Update.
6134
6135 2019-03-06  Tom Tromey  <tom@tromey.com>
6136
6137         * infrun.c (displaced_step_clear_cleanup): Now a
6138         forward_scope_exit type.
6139         (displaced_step_prepare_throw): Update.
6140         (displaced_step_fixup): Update.
6141
6142 2019-03-06  Tom Tromey  <tom@tromey.com>
6143
6144         * inferior.h (class inferior): Update comment.
6145         * gdbthread.h (class thread_info): Update comment.
6146
6147 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6148             Tom Tromey  <tom@tromey.com>
6149
6150         * stabsread.h (struct stab_section_list): Remove.
6151         (coffstab_build_psymtabs): Update.
6152         * dbxread.c (symbuf_sections): Now a std::vector.
6153         (sect_idx): New global.
6154         (fill_symbuf): Update.
6155         (coffstab_build_psymtabs): Change type of stabsects parameter.
6156         Update.
6157         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6158         std::vector.
6159         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6160         (coff_locate_sections): Update.
6161         (coff_symfile_read): Remove cleanups.  Update.
6162         (init_stringtab): Add storage parameter.
6163         (free_stringtab, free_stringtab_cleanup): Remove.
6164         (init_lineno): Add storage parameter.
6165         (free_linetab, free_linetab_cleanup): Remove.
6166
6167 2019-03-06  Pedro Alves  <palves@redhat.com>
6168
6169         * linux-fork.c (fork_info::clobber_regs): Delete.
6170         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6171         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6172         comment.  Adjust.
6173         (scoped_switch_fork_info::scoped_switch_fork_info)
6174         (checkpoint_command, linux_fork_context): Adjust
6175         fork_save_infrun_state calls.
6176
6177 2019-03-06  Pedro Alves  <palves@redhat.com>
6178
6179         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6180         (inf_has_multiple_threads): Return 'bool' and rewrite using
6181         inferior_info::threads().
6182
6183 2019-03-06  Pedro Alves  <palves@redhat.com>
6184
6185         * linux-fork.c: Include <list>.
6186         (fork_list): Now a std::list instance.
6187         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6188         (forks_exist_p, find_last_fork): Adjust.
6189         (new_fork): Delete.
6190         (one_fork_p): New.
6191         (add_fork): Adjust.
6192         (free_fork): Delete, folded into fork_info::~fork_info().
6193         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6194         Adjust.
6195         (init_fork_list): Delete.
6196         (linux_fork_killall, linux_fork_mourn_inferior)
6197         (linux_fork_detach, info_checkpoints_command): Adjust.
6198         (_initialize_linux_fork): No longer call init_fork_list.
6199
6200 2019-03-06  Pedro Alves  <palves@redhat.com>
6201
6202         * linux-fork.c (new_fork): New, split out of ...
6203         (add_fork): ... this.  Return void.  Move "first fork" special
6204         case from here, to ...
6205         (checkpoint_command): ... here.
6206         * linux-linux.h (add_fork): Return void.
6207
6208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6211
6212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6213             Chris January  <chris.january@arm.com>
6214             David Lecomber  <david.lecomber@arm.com>
6215
6216         * f-exp.y: New token, UNOP_INTRINSIC.
6217         (exp): New pattern using UNOP_INTRINSIC token.
6218         (f77_keywords): Add 'abs' keyword.
6219         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6220         (value_from_host_double): New function.
6221         (evaluate_subexp_f): Support UNOP_ABS.
6222
6223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6226         types.
6227
6228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6229
6230         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6231         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6232         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6233
6234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6237
6238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6239             Chris January  <chris.january@arm.com>
6240
6241         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6242         * f-exp.y: Define 'KIND' token.
6243         (exp): New pattern for KIND expressions.
6244         (ptype): Handle types with a kind extension.
6245         (direct_abs_decl): Extend to spot kind extensions.
6246         (f77_keywords): Add 'kind' to the list.
6247         (push_kind_type): New function.
6248         (convert_to_kind_type): New function.
6249         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6250         * parse.c (operator_length_standard): Likewise.
6251         * parser-defs.h (enum type_pieces): Add tp_kind.
6252         * std-operator.def: Add UNOP_KIND.
6253
6254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6255
6256         * f-exp.y (f_parse): Set yydebug.
6257
6258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6259
6260         * f-lang.c (evaluate_subexp_f): New function.
6261         (exp_descriptor_f): New global.
6262         (f_language_defn): Use exp_descriptor_f instead of
6263         exp_descriptor_standard.
6264
6265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6266
6267         * f-exp.y (struct token): Add comments.
6268         (dot_ops): Remove uppercase versions and the end marker.
6269         (f77_keywords): Likewise.
6270         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6271         entries in the dot_ops array are case insensitive, and use
6272         strncasecmp to compare strings.  Also some whitespace cleanup in
6273         this area.  Similar for the f77_keywords array, except entries in
6274         this list might be case sensitive.
6275
6276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * f-exp.y (struct f77_boolean_val): Add comments.
6279         (boolean_values): Remove uppercase versions, and end marker.
6280         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6281         and use strncasecmp to achieve case insensitivity.  Additionally,
6282         perform whitespace cleanup around this code.
6283
6284 2019-03-06  Tom Tromey  <tromey@adacore.com>
6285
6286         * remote-sim.c (gdbsim_target_open): Use result of
6287         gdb_argv::release.
6288
6289 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6290         Dirk Schubert  <dirk.schubert@arm.com>
6291         Chris January  <chris.january@arm.com>
6292
6293         * eval.c (evaluate_subexp_standard): Call Fortran argument
6294         wrapping logic.
6295         * f-lang.c (struct value): A value which can be passed into a
6296         Fortran function call.
6297         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6298         where appropriate.
6299         (struct type): Value ready for a Fortran function call.
6300         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6301         is needed.
6302         * f-lang.h (fortran_argument_convert): Declaration.
6303         (fortran_preserve_arg_pointer): Declaration.
6304         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6305
6306 2019-03-05  Tom Tromey  <tromey@adacore.com>
6307
6308         * python/py-prettyprint.c (print_string_repr): Remove #if.
6309         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6310
6311 2019-03-05  Tom Tromey  <tromey@adacore.com>
6312
6313         * target.c (the_dummy_target): Move later.  Change type to
6314         "dummy_target".
6315         (initialize_targets): Don't initialize the_dummy_target.
6316
6317 2019-03-05  Tom Tromey  <tromey@adacore.com>
6318
6319         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6320         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6321
6322 2019-03-05  Tom Tromey  <tromey@adacore.com>
6323
6324         * windows-nat.c (windows_nat_target::attach)
6325         (windows_nat_target::detach): Don't call gdb_flush.
6326         * valprint.c (generic_val_print, val_print, val_print_string):
6327         Don't call gdb_flush.
6328         * utils.c (defaulted_query): Don't call gdb_flush.
6329         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6330         * target.c (target_announce_detach): Don't call gdb_flush.
6331         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6332         * remote.c (extended_remote_target::attach): Don't call
6333         gdb_flush.
6334         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6335         * printcmd.c (do_examine): Don't call gdb_flush.
6336         (info_display_command): Don't call gdb_flush.
6337         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6338         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6339         * memattr.c (info_mem_command): Don't call gdb_flush.
6340         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6341         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6342         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6343         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6344         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6345         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6346         (gnu_nat_target::detach): Don't call gdb_flush.
6347         * f-valprint.c (f_val_print): Don't call gdb_flush.
6348         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6349         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6350         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6351         gdb_flush.
6352         * c-valprint.c (c_val_print): Don't call gdb_flush.
6353         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6354
6355 2019-03-05  Tom Tromey  <tromey@adacore.com>
6356
6357         * varobj.c (update_dynamic_varobj_children): Update.
6358         (install_default_visualizer): Use reset, not release.
6359         * value.c (set_internalvar): Update.
6360         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6361         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6362         ATTRIBUTE_UNUSED_RESULT.
6363
6364 2019-03-05  Tom Tromey  <tromey@adacore.com>
6365
6366         * remote.c (class scoped_remote_fd) <release>: Add
6367         ATTRIBUTE_UNUSED_RESULT.
6368
6369 2019-03-05  Tom Tromey  <tromey@adacore.com>
6370
6371         * macroexp.c (struct macro_buffer) <release>: Add
6372         ATTRIBUTE_UNUSED_RESULT.
6373
6374 2019-03-05  Tom Tromey  <tromey@adacore.com>
6375
6376         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6377         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6378         ATTRIBUTE_UNUSED_RESULT.
6379
6380 2019-03-05  Tom Tromey  <tromey@adacore.com>
6381
6382         * common/scoped_fd.h (class scoped_fd) <release>: Add
6383         ATTRIBUTE_UNUSED_RESULT.
6384
6385 2019-03-05  Tom Tromey  <tromey@adacore.com>
6386
6387         * parser-defs.h (struct parser_state) <release>: Add
6388         ATTRIBUTE_UNUSED_RESULT.
6389
6390 2019-03-05  Tom Tromey  <tromey@adacore.com>
6391
6392         * utils.h (class gdb_argv) <release>: Add
6393         ATTRIBUTE_UNUSED_RESULT.
6394         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6395
6396 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6397
6398         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6399         for-loop range, to avoid compiler warnings.
6400
6401         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6402         avoid compiler warnings about unused variables.
6403
6404         * NEWS: Mention end of support for native debugging on MS-Windows
6405         before XP.
6406
6407         PR gdb/24292
6408         * common/netstuff.c:
6409         * gdbserver/gdbreplay.c
6410         * gdbserver/remote-utils.c:
6411         * ser-tcp.c:
6412         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6413         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6414         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6415         'getaddrinfo' and 'freeaddrinfo' were not available before
6416         Windows XP, and mingw.org's MinGW headers by default define
6417         _WIN32_WINNT to 0x500.
6418
6419 2019-03-01  Gary Benson <gbenson@redhat.com>
6420
6421         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6422
6423 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6424             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6425
6426         PR gdb/8527
6427         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6428         set_sigint_trap, clear_sigint_trap.
6429
6430 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6431
6432         * target.c (target_detach): Clear the regcache and the
6433         frame cache.
6434
6435 2019-02-27  Pedro Alves  <palves@redhat.com>
6436
6437         * utils.c (set_screen_size): When we cap the height/width sizes,
6438         tweak the corresponding command variable to show "unlimited":
6439
6440 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6441             Pedro Alves  <palves@redhat.com>
6442
6443         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6444         before calling rl_set_screen_size.
6445
6446 2019-02-27  Tom Tromey  <tromey@adacore.com>
6447
6448         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6449         define.
6450         * python/py-value.c: Remove Python 2.4 workaround.
6451         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6452         workaround.
6453         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6454         Python 2.4 workaround.
6455         * python/python-internal.h: Remove Python 2.4 comment.
6456         (Py_ssize_t): Don't define.
6457         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6458         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6459         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6460         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6461         * python/python.c (do_start_initialization): Remove Python 2.4
6462         workaround.
6463         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6464         (print_children): Remove Python 2.4 workaround.
6465         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6466         workaround.
6467         (CHARBUFFERPROC_NAME): Remove.
6468         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6469         Python 2.4 workaround.
6470
6471 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6472
6473         * NEWS: Note minimum Python version.
6474
6475 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6476
6477         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6478         code from these functions.  Remove corresponding ifdefs.  Use
6479         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6480         Remove gotos and target of gotos.
6481         (infpy_search_memory): Likewise.
6482
6483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6486         (hppa_gdbarch_init): Don't register deleted functions with
6487         gdbarch.
6488
6489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6492         (h8300_unwind_sp): Delete.
6493         (h8300_dummy_id): Delete.
6494         (h8300_gdbarch_init): Don't register deleted functions with
6495         gdbarch.
6496
6497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6500         (ft32_unwind_pc): Delete.
6501         (ft32_unwind_sp): Delete.
6502         (ft32_gdbarch_init): Don't register deleted functions with
6503         gdbarch.
6504
6505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6506
6507         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6508         (frv_unwind_pc): Delete.
6509         (frv_unwind_sp): Delete.
6510         (frv_gdbarch_init): Don't register deleted functions with
6511         gdbarch.
6512
6513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6514
6515         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6516         (riscv_unwind_pc): Delete.
6517         (riscv_unwind_sp): Delete.
6518         (riscv_gdbarch_init): Don't register deleted functions with
6519         gdbarch.
6520
6521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6524         (csky_unwind_pc): Delete.
6525         (csky_unwind_sp): Delete.
6526         (csky_gdbarch_init): Don't register deleted functions with
6527         gdbarch.
6528
6529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6530
6531         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6532         (cris_unwind_pc): Delete.
6533         (cris_unwind_sp): Delete.
6534         (cris_gdbarch_init): Don't register deleted functions with
6535         gdbarch.
6536
6537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6540         (bfin_unwind_pc): Delete.
6541         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6542
6543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6546         (arm_unwind_pc): Delete.
6547         (arm_unwind_sp): Delete.
6548         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6549
6550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6553         (arc_unwind_pc): Delete.
6554         (arc_unwind_sp): Delete.
6555         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6556
6557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6560         (alpha_unwind_pc): Delete.
6561         (alpha_gdbarch_init): Don't register deleted functions with
6562         gdbarch.
6563
6564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6567         (aarch64_unwind_pc): Delete.
6568         (aarch64_unwind_sp): Delete.
6569         (aarch64_gdbarch_init): Don't register deleted functions with
6570         gdbarch.
6571
6572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * gdbtypes.c (type_align): Don't consider static members when
6575         computing structure alignment.
6576
6577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6580         return 0 for other types.
6581         * arch-utils.c (default_type_align): Always return 0.
6582         * gdbarch.h: Regenerate.
6583         * gdbarch.sh (type_align): Extend comment.
6584         * gdbtypes.c (type_align): Add additional comments, always call
6585         gdbarch_type_align before applying the default rules.
6586         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6587         generic code will then apply a suitable default.
6588         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6589         types, return 0 for other types.
6590
6591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6592
6593         * NEWS: Create a new section for the next release branch.
6594         Rename the section of the current branch, now that it has
6595         been cut.
6596
6597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6598
6599         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6600         * version.in: Bump version to 8.3.50.DATE-git.
6601
6602 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6603
6604         * aix-thread.c (ptid_cmp): Remove unused variable.
6605         (get_signaled_thread): Likewise.
6606         (store_regs_user_thread): Likewise.
6607         (store_regs_kernel_thread): Likewise.
6608         (fetch_regs_kernel_thread): Remove shadowed variable.
6609
6610 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6611
6612         * features/riscv/32bit-cpu.xml: Add register numbers.
6613         * features/riscv/32bit-fpu.c: Regenerate.
6614         * features/riscv/32bit-fpu.xml: Add register numbers.
6615         * features/riscv/64bit-cpu.xml: Add register numbers.
6616         * features/riscv/64bit-fpu.c: Regenerate.
6617         * features/riscv/64bit-fpu.xml: Add register numbers.
6618
6619 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6620
6621         * NEWS: Mention two argument form of gdb.Value constructor.
6622         * python/py-value.c (convert_buffer_and_type_to_value): New
6623         function.
6624         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6625         Add support for handling an optional second argument.  Call
6626         convert_buffer_and_type_to_value as appropriate.
6627         * python/python-internal.h (Py_buffer_deleter): New struct.
6628         (Py_buffer_up): New typedef.
6629
6630 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6631
6632         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6633         instead of releasing ownership.
6634
6635 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6636
6637         * dwarf2read.c (open_and_init_dwp_file): Call
6638         elf_numsections instead of bfd_count_sections to initialize
6639         dwp_file->num_sections.
6640
6641 2019-02-25  Tom Tromey  <tromey@adacore.com>
6642
6643         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6644
6645 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6646
6647         * gcore.in: Add '--readnever' option when invoking GDB.
6648
6649 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6650
6651         * MAINTAINERS: Update my email address.
6652
6653 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6654
6655         * build-id.c (build_id_to_debug_bfd_1): New function.
6656         (build_id_to_debug_bfd): Look for separate debug file in
6657         sysroot.
6658
6659 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * gdbarch.sh: Update the copyright year range that is placed into
6662         generated files.
6663
6664 2019-02-22  Keith Seitz  <keiths@redhat.com>
6665
6666         PR symtab/23853
6667         * linespec.c (create_sals_line_offset): Search for the default
6668         symtab's filename instead of its fullname.
6669
6670 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6671
6672         * NEWS: Update style defaults.
6673
6674 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6675
6676         * main.c (captured_main_1): Disable styling in batch mode.
6677
6678 2019-02-20  Tom Tromey  <tom@tromey.com>
6679
6680         * symtab.c (symtab_symbol_info): Fix typos.
6681
6682 2019-02-20  Tom Tromey  <tromey@adacore.com>
6683
6684         * findcmd.c (_initialize_mem_search): Use upper case for
6685         metasyntactic variables.
6686
6687 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6688
6689         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6690         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6691
6692 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6693
6694         * top.h (source_file_name): Change to std::string.
6695         * top.c (source_file_name): Likewise.
6696         (command_line_input): Adjust.
6697         * cli/cli-script.c (script_from_file): Adjust.
6698
6699 2019-02-19  Tom Tromey  <tromey@adacore.com>
6700
6701         * ravenscar-thread.c
6702         (ravenscar_thread_target::update_thread_list): Don't call
6703         ada_build_task_list.
6704         * ada-lang.h (ada_build_task_list): Don't declare.
6705         * ada-tasks.c (struct ada_tasks_inferior_data)
6706         <task_list_valid_p>: Now bool.
6707         (read_known_tasks, ada_task_list_changed)
6708         (ada_tasks_invalidate_inferior_data): Update.
6709         (read_known_tasks_array): Return bool.
6710         (read_known_tasks_list): Likewise.
6711         (read_known_tasks): Return void.
6712         (ada_build_task_list): Now static.
6713
6714 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6715
6716         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6717         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6718
6719 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6720
6721         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6722         variant for ada_tasks_pspace_data_handle and
6723         ada_tasks_inferior_data_handle.
6724         (ada_tasks_pspace_data_cleanup): New function.
6725         (ada_tasks_inferior_data_cleanup): New function.
6726
6727 2019-02-17  Tom Tromey  <tom@tromey.com>
6728
6729         * macrotab.h (macro_source_fullname): Return a std::string.
6730         * macrotab.c (macro_include, check_for_redefinition)
6731         (macro_undef, macro_lookup_definition, foreach_macro)
6732         (foreach_macro_in_scope): Update.
6733         (macro_source_fullname): Return a std::string.
6734         * macrocmd.c (show_pp_source_pos): Update.
6735
6736 2019-02-17  Tom Tromey  <tom@tromey.com>
6737
6738         * macrocmd.c (show_pp_source_pos): Style the file names.
6739
6740 2019-02-17  Tom Tromey  <tom@tromey.com>
6741
6742         PR tui/24197:
6743         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6744
6745 2019-02-17  Tom Tromey  <tom@tromey.com>
6746
6747         * ada-lang.c (user_select_syms): Use filtered printing.
6748         * utils.c (wrap_style): New global.
6749         (desired_style): Remove.
6750         (emit_style_escape): Add stream parameter.
6751         (set_output_style, reset_terminal_style, prompt_for_continue):
6752         Update.
6753         (flush_wrap_buffer): Only flush gdb_stdout.
6754         (wrap_here): Set wrap_style.
6755         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6756         treat escape sequences as a character.  Change when wrap buffer is
6757         flushed.
6758         (fputs_styled): Do not set the output style when the default is
6759         requested.
6760         * ui-style.h (struct ui_file_style) <is_default>: New method.
6761         * source.c (print_source_lines_base): Emit escape sequences in one
6762         piece.
6763
6764 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6765
6766         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6767         integers and enumeration types.
6768
6769 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6770
6771         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6772         instead of lookup_symbol_in_language
6773         (do_exact_match): New function.
6774         (ada_get_symbol_name_matcher): Return do_exact_match when
6775         doing a verbatim match.
6776
6777 2019-02-15  Tom Tromey  <tromey@adacore.com>
6778
6779         * ravenscar-thread.c (ravenscar_thread_target::resume)
6780         (ravenscar_thread_target::wait): Special case wildcard requests.
6781
6782 2019-02-15  Tom Tromey  <tromey@adacore.com>
6783
6784         * ravenscar-thread.c (base_ptid): Remove.
6785         (struct ravenscar_thread_target) <close>: New method.
6786         <m_base_ptid>: New member.
6787         <update_inferior_ptid, active_task, task_is_currently_active,
6788         runtime_initialized>: Declare methods.
6789         <ravenscar_thread_target>: Add constructor.
6790         (ravenscar_thread_target::task_is_currently_active)
6791         (ravenscar_thread_target::update_inferior_ptid)
6792         (ravenscar_runtime_initialized): Rename.  Now methods.
6793         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6794         (ravenscar_thread_target::update_thread_list): Update.
6795         (ravenscar_thread_target::active_task): Now method.
6796         (ravenscar_thread_target::store_registers)
6797         (ravenscar_thread_target::prepare_to_store)
6798         (ravenscar_thread_target::prepare_to_store)
6799         (ravenscar_thread_target::mourn_inferior): Update.
6800         (ravenscar_inferior_created): Use "new" to create target.
6801         (ravenscar_thread_target::get_ada_task_ptid): Update.
6802         (_initialize_ravenscar): Don't initialize base_ptid.
6803         (ravenscar_ops): Remove global.
6804
6805 2019-02-15  Tom Tromey  <tromey@adacore.com>
6806
6807         * target.h (push_target): Declare new overload.
6808         * target.c (push_target): New overload, taking an rvalue reference.
6809         * remote.c (remote_target::open_1): Use push_target overload.
6810         * corelow.c (core_target_open): Use push_target overload.
6811
6812 2019-02-15  Tom Tromey  <tromey@adacore.com>
6813
6814         * ravenscar-thread.c (is_ravenscar_task)
6815         (ravenscar_task_is_currently_active): Return bool.
6816         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6817         (_initialize_ravenscar): Remove "(void)".
6818         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6819         Return bool.
6820
6821 2019-02-15  Tom Tromey  <tromey@adacore.com>
6822
6823         * ravenscar-thread.c (ravenscar_runtime_initializer)
6824         (has_ravenscar_runtime, get_running_thread_id)
6825         (ravenscar_thread_target::resume): Fix indentation.
6826
6827 2019-02-15  Tom Tromey  <tromey@adacore.com>
6828
6829         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6830         from ravenscar_arch_ops.
6831         (sparc_ravenscar_ops::fetch_registers)
6832         (sparc_ravenscar_ops::store_registers): Now methods.
6833         (sparc_ravenscar_prepare_to_store): Remove.
6834         (sparc_ravenscar_ops): Redefine.
6835         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6836         methods and destructor.  Remove members.
6837         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6838         (ravenscar_thread_target::store_registers)
6839         (ravenscar_thread_target::prepare_to_store): Update.
6840         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6841         Remove.
6842         (struct ppc_ravenscar_powerpc_ops): Derive from
6843         ravenscar_arch_ops.
6844         (ppc_ravenscar_powerpc_ops::fetch_registers)
6845         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6846         (ppc_ravenscar_powerpc_ops): Redefine.
6847         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6848         (ppc_ravenscar_e500_ops::fetch_registers)
6849         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6850         (ppc_ravenscar_e500_ops): Redefine.
6851         * aarch64-ravenscar-thread.c
6852         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6853         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6854         (aarch64_ravenscar_fetch_registers)
6855         (aarch64_ravenscar_store_registers): Now methods.
6856         (aarch64_ravenscar_ops): Redefine.
6857
6858 2019-02-15  Tom Tromey  <tromey@adacore.com>
6859
6860         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6861         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6862         (ravenscar_thread_target::stopped_by_watchpoint)
6863         (ravenscar_thread_target::stopped_data_address)
6864         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6865
6866 2019-02-15  Tom Tromey  <tromey@adacore.com>
6867
6868         * ravenscar-thread.c: Fix some typos.
6869
6870 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6871             Tom Tromey  <tromey@adacore.com>
6872
6873         * ada-lang.c (ada_exception_sal): Change addr_string to a
6874         std::string.
6875         (create_ada_exception_catchpoint): Update.
6876
6877 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6878             Tom Tromey  <tromey@adacore.com>
6879
6880         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6881         (bp_location_ops): Remove.
6882         (base_breakpoint_allocate_location): Update.
6883         (free_bp_location): Update.
6884         * ada-lang.c (class ada_catchpoint_location)
6885         <ada_catchpoint_location>: Remove ops parameter.
6886         (ada_catchpoint_location_dtor): Remove.
6887         (ada_catchpoint_location_ops): Remove.
6888         (allocate_location_exception): Update.
6889         * breakpoint.h (struct bp_location_ops): Remove.
6890         (class bp_location) <bp_location>: Remove bp_location_ops
6891         parameter.
6892         <~bp_location>: Add destructor.
6893         <ops>: Remove.
6894
6895 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6896             Pedro Alves  <palves@redhat.com>
6897
6898         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6899         'PATH_MAX'.
6900
6901 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6902             Samuel Thibault  <samuel.thibault@gnu.org>
6903             Thomas Schwinge  <thomas@codesourcery.com>
6904
6905         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6906         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6907
6908 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6909
6910         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6911         (check_empty): Use "const char *".
6912
6913         * gnu-nat.c (gnu_nat_target::detach): Instead of
6914         'detach_inferior (pid)' call
6915         'detach_inferior (find_inferior_pid (pid))'.
6916
6917         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6918         'nat/fork-inferior.o'.
6919         * gnu-nat.c: #include "nat/fork-inferior.h".
6920
6921         * gnu-nat.c (gnu_nat_target::detach): Instead of
6922         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6923         * gnu-nat.h: #include "inf-child.h".
6924         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6925         'i386_gnu_nat_target::fetch_registers'.
6926         (gnu_store_registers): Rename/move to
6927         'i386_gnu_nat_target::store_registers'.
6928
6929         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6930         * gnu-nat.h (mach_thread_info): New function.
6931         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6932
6933         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6934
6935 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6936
6937         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6938
6939 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6940
6941         * windows-nat.c (windows_add_thread): Add new parameter
6942         "main_thread_p" with default value set to false.  Update
6943         function documentation as well as all callers.
6944         (windows_delete_thread): Likewise.
6945         (fake_create_process): Update call to windows_add_thread.
6946         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6947         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6948         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6949         call to windows_delete_thread.
6950
6951 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6952
6953         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6954
6955 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6956
6957         * symfile.c (find_separate_debug_file): Use canonical path of
6958         sysroot with child_path instead of gdb_sysroot if it is valid.
6959
6960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6961
6962         * symfile.c (find_separate_debug_file): Use child_path to
6963         determine if an object file is under a sysroot.
6964
6965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6966
6967         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6968         unittests/child-path-selftests.c.
6969         * common/pathstuff.c (child_path): New function.
6970         * common/pathstuff.h (child_path): New prototype.
6971         * unittests/child-path-selftests.c: New file.
6972
6973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6974
6975         * symfile.c (find_separate_debug_file): Look for separate debug
6976         files in debug directories under the sysroot.
6977
6978 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6979
6980         * symtab.h (struct minimal_symbol data_p): New const method.
6981         (struct minimal_symbol text_p): Likewise.
6982         * symtab.c (output_source_filename): Use file name style
6983         to print file name.
6984         (print_symbol_info): Likewise.
6985         (print_msymbol_info): Use address style to print addresses.
6986         Use function name style to print executable text symbols.
6987         (expand_symtab_containing_pc): Use data_p.
6988         (find_pc_sect_compunit_symtab): Likewise.
6989
6990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6991
6992         * breakpoint.c (describe_other_breakpoints): Use address style
6993         to print addresses.
6994         (say_where): Likewise.
6995
6996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6997
6998         * ada-typeprint.c (print_func_type): Print function name
6999         style to print function name.
7000         * c-typeprint.c (c_print_type_1): Likewise.
7001
7002 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7003
7004         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7005         for execve.
7006
7007 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7008
7009         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7010         type_stack.
7011
7012 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7013
7014         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7015         TYPE_CODE_REF types.
7016
7017 2019-02-08  Jim Wilson  <jimw@sifive.com>
7018
7019         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7020         (riscv_linux_fregset): New.
7021         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7022
7023 2019-02-07  Tom Tromey  <tom@tromey.com>
7024
7025         * thread.c (thread_cancel_execution_command): Update.
7026         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7027         methods.
7028         (struct thread_fsm_ops): Remove.
7029         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7030         (thread_fsm_should_stop, thread_fsm_return_value)
7031         (thread_fsm_set_finished, thread_fsm_finished_p)
7032         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7033         Don't declare.
7034         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7035         * infrun.c (clear_proceed_status_thread)
7036         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7037         (print_stop_event): Update.
7038         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7039         Add constructor.
7040         (step_command_fsm_ops): Remove.
7041         (new_step_command_fsm): Remove.
7042         (step_1): Update.
7043         (step_command_fsm::should_stop): Rename from
7044         step_command_fsm_should_stop.
7045         (step_command_fsm::clean_up): Rename from
7046         step_command_fsm_clean_up.
7047         (step_command_fsm::do_async_reply_reason): Rename from
7048         step_command_fsm_async_reply_reason.
7049         (struct until_next_fsm): Inherit from thread_fsm.  Add
7050         constructor.
7051         (until_next_fsm_ops): Remove.
7052         (new_until_next_fsm): Remove.
7053         (until_next_fsm::should_stop): Rename from
7054         until_next_fsm_should_stop.
7055         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7056         (until_next_fsm::do_async_reply_reason): Rename from
7057         until_next_fsm_async_reply_reason.
7058         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7059         constructor.  Change type of breakpoint.
7060         (finish_command_fsm_ops): Remove.
7061         (new_finish_command_fsm): Remove.
7062         (finish_command_fsm::should_stop): Rename from
7063         finish_command_fsm_should_stop.
7064         (finish_command_fsm::clean_up): Rename from
7065         finish_command_fsm_clean_up.
7066         (finish_command_fsm::return_value): Rename from
7067         finish_command_fsm_return_value.
7068         (finish_command_fsm::do_async_reply_reason): Rename from
7069         finish_command_fsm_async_reply_reason.
7070         (finish_command): Update.
7071         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7072         Add constructor.
7073         (call_thread_fsm_ops): Remove.
7074         (call_thread_fsm::call_thread_fsm): Rename from
7075         new_call_thread_fsm.
7076         (call_thread_fsm::should_stop): Rename from
7077         call_thread_fsm_should_stop.
7078         (call_thread_fsm::should_notify_stop): Rename from
7079         call_thread_fsm_should_notify_stop.
7080         (run_inferior_call, call_function_by_hand_dummy): Update.
7081         * cli/cli-interp.c (should_print_stop_to_console): Update.
7082         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7083         Add constructor.  Change type of location_breakpoint,
7084         caller_breakpoint.
7085         (until_break_fsm_ops): Remove.
7086         (new_until_break_fsm): Remove.
7087         (until_break_fsm::should_stop): Rename from
7088         until_break_fsm_should_stop.
7089         (until_break_fsm::clean_up): Rename from
7090         until_break_fsm_clean_up.
7091         (until_break_fsm::do_async_reply_reason): Rename from
7092         until_break_fsm_async_reply_reason.
7093         (until_break_command): Update.
7094         * thread-fsm.c: Remove.
7095         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7096
7097 2019-02-07  Tom Tromey  <tom@tromey.com>
7098
7099         * yy-remap.h: Add include guard.
7100         * xtensa-tdep.h: Add include guard.
7101         * xcoffread.h: Rename include guard.
7102         * varobj-iter.h: Add include guard.
7103         * tui/tui.h: Rename include guard.
7104         * tui/tui-winsource.h: Rename include guard.
7105         * tui/tui-wingeneral.h: Rename include guard.
7106         * tui/tui-windata.h: Rename include guard.
7107         * tui/tui-win.h: Rename include guard.
7108         * tui/tui-stack.h: Rename include guard.
7109         * tui/tui-source.h: Rename include guard.
7110         * tui/tui-regs.h: Rename include guard.
7111         * tui/tui-out.h: Rename include guard.
7112         * tui/tui-layout.h: Rename include guard.
7113         * tui/tui-io.h: Rename include guard.
7114         * tui/tui-hooks.h: Rename include guard.
7115         * tui/tui-file.h: Rename include guard.
7116         * tui/tui-disasm.h: Rename include guard.
7117         * tui/tui-data.h: Rename include guard.
7118         * tui/tui-command.h: Rename include guard.
7119         * tic6x-tdep.h: Add include guard.
7120         * target/waitstatus.h: Rename include guard.
7121         * target/wait.h: Rename include guard.
7122         * target/target.h: Rename include guard.
7123         * target/resume.h: Rename include guard.
7124         * target-float.h: Rename include guard.
7125         * stabsread.h: Add include guard.
7126         * rs6000-tdep.h: Add include guard.
7127         * riscv-fbsd-tdep.h: Add include guard.
7128         * regformats/regdef.h: Rename include guard.
7129         * record.h: Rename include guard.
7130         * python/python.h: Rename include guard.
7131         * python/python-internal.h: Rename include guard.
7132         * python/py-stopevent.h: Rename include guard.
7133         * python/py-ref.h: Rename include guard.
7134         * python/py-record.h: Rename include guard.
7135         * python/py-record-full.h: Rename include guard.
7136         * python/py-record-btrace.h: Rename include guard.
7137         * python/py-instruction.h: Rename include guard.
7138         * python/py-events.h: Rename include guard.
7139         * python/py-event.h: Rename include guard.
7140         * procfs.h: Add include guard.
7141         * proc-utils.h: Add include guard.
7142         * p-lang.h: Add include guard.
7143         * or1k-tdep.h: Rename include guard.
7144         * observable.h: Rename include guard.
7145         * nto-tdep.h: Rename include guard.
7146         * nat/x86-linux.h: Rename include guard.
7147         * nat/x86-linux-dregs.h: Rename include guard.
7148         * nat/x86-gcc-cpuid.h: Add include guard.
7149         * nat/x86-dregs.h: Rename include guard.
7150         * nat/x86-cpuid.h: Rename include guard.
7151         * nat/ppc-linux.h: Rename include guard.
7152         * nat/mips-linux-watch.h: Rename include guard.
7153         * nat/linux-waitpid.h: Rename include guard.
7154         * nat/linux-ptrace.h: Rename include guard.
7155         * nat/linux-procfs.h: Rename include guard.
7156         * nat/linux-osdata.h: Rename include guard.
7157         * nat/linux-nat.h: Rename include guard.
7158         * nat/linux-namespaces.h: Rename include guard.
7159         * nat/linux-btrace.h: Rename include guard.
7160         * nat/glibc_thread_db.h: Rename include guard.
7161         * nat/gdb_thread_db.h: Rename include guard.
7162         * nat/gdb_ptrace.h: Rename include guard.
7163         * nat/fork-inferior.h: Rename include guard.
7164         * nat/amd64-linux-siginfo.h: Rename include guard.
7165         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7166         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7167         * nat/aarch64-linux.h: Rename include guard.
7168         * nat/aarch64-linux-hw-point.h: Rename include guard.
7169         * mn10300-tdep.h: Add include guard.
7170         * mips-linux-tdep.h: Add include guard.
7171         * mi/mi-parse.h: Rename include guard.
7172         * mi/mi-out.h: Rename include guard.
7173         * mi/mi-main.h: Rename include guard.
7174         * mi/mi-interp.h: Rename include guard.
7175         * mi/mi-getopt.h: Rename include guard.
7176         * mi/mi-console.h: Rename include guard.
7177         * mi/mi-common.h: Rename include guard.
7178         * mi/mi-cmds.h: Rename include guard.
7179         * mi/mi-cmd-break.h: Rename include guard.
7180         * m2-lang.h: Add include guard.
7181         * location.h: Rename include guard.
7182         * linux-record.h: Rename include guard.
7183         * linux-nat.h: Add include guard.
7184         * linux-fork.h: Add include guard.
7185         * i386-darwin-tdep.h: Rename include guard.
7186         * hppa-linux-offsets.h: Add include guard.
7187         * guile/guile.h: Rename include guard.
7188         * guile/guile-internal.h: Rename include guard.
7189         * gnu-nat.h: Rename include guard.
7190         * gdb-stabs.h: Rename include guard.
7191         * frv-tdep.h: Add include guard.
7192         * f-lang.h: Add include guard.
7193         * event-loop.h: Add include guard.
7194         * darwin-nat.h: Rename include guard.
7195         * cp-abi.h: Rename include guard.
7196         * config/sparc/nm-sol2.h: Rename include guard.
7197         * config/nm-nto.h: Rename include guard.
7198         * config/nm-linux.h: Add include guard.
7199         * config/i386/nm-i386gnu.h: Rename include guard.
7200         * config/djgpp/nl_types.h: Rename include guard.
7201         * config/djgpp/langinfo.h: Rename include guard.
7202         * compile/gcc-cp-plugin.h: Add include guard.
7203         * compile/gcc-c-plugin.h: Add include guard.
7204         * compile/compile.h: Rename include guard.
7205         * compile/compile-object-run.h: Rename include guard.
7206         * compile/compile-object-load.h: Rename include guard.
7207         * compile/compile-internal.h: Rename include guard.
7208         * compile/compile-cplus.h: Rename include guard.
7209         * compile/compile-c.h: Rename include guard.
7210         * common/xml-utils.h: Rename include guard.
7211         * common/x86-xstate.h: Rename include guard.
7212         * common/version.h: Rename include guard.
7213         * common/vec.h: Rename include guard.
7214         * common/tdesc.h: Rename include guard.
7215         * common/selftest.h: Rename include guard.
7216         * common/scoped_restore.h: Rename include guard.
7217         * common/scoped_mmap.h: Rename include guard.
7218         * common/scoped_fd.h: Rename include guard.
7219         * common/safe-iterator.h: Rename include guard.
7220         * common/run-time-clock.h: Rename include guard.
7221         * common/refcounted-object.h: Rename include guard.
7222         * common/queue.h: Rename include guard.
7223         * common/ptid.h: Rename include guard.
7224         * common/print-utils.h: Rename include guard.
7225         * common/preprocessor.h: Rename include guard.
7226         * common/pathstuff.h: Rename include guard.
7227         * common/observable.h: Rename include guard.
7228         * common/netstuff.h: Rename include guard.
7229         * common/job-control.h: Rename include guard.
7230         * common/host-defs.h: Rename include guard.
7231         * common/gdb_wait.h: Rename include guard.
7232         * common/gdb_vecs.h: Rename include guard.
7233         * common/gdb_unlinker.h: Rename include guard.
7234         * common/gdb_unique_ptr.h: Rename include guard.
7235         * common/gdb_tilde_expand.h: Rename include guard.
7236         * common/gdb_sys_time.h: Rename include guard.
7237         * common/gdb_string_view.h: Rename include guard.
7238         * common/gdb_splay_tree.h: Rename include guard.
7239         * common/gdb_setjmp.h: Rename include guard.
7240         * common/gdb_ref_ptr.h: Rename include guard.
7241         * common/gdb_optional.h: Rename include guard.
7242         * common/gdb_locale.h: Rename include guard.
7243         * common/gdb_assert.h: Rename include guard.
7244         * common/filtered-iterator.h: Rename include guard.
7245         * common/filestuff.h: Rename include guard.
7246         * common/fileio.h: Rename include guard.
7247         * common/environ.h: Rename include guard.
7248         * common/common-utils.h: Rename include guard.
7249         * common/common-types.h: Rename include guard.
7250         * common/common-regcache.h: Rename include guard.
7251         * common/common-inferior.h: Rename include guard.
7252         * common/common-gdbthread.h: Rename include guard.
7253         * common/common-exceptions.h: Rename include guard.
7254         * common/common-defs.h: Rename include guard.
7255         * common/common-debug.h: Rename include guard.
7256         * common/cleanups.h: Rename include guard.
7257         * common/buffer.h: Rename include guard.
7258         * common/btrace-common.h: Rename include guard.
7259         * common/break-common.h: Rename include guard.
7260         * cli/cli-utils.h: Rename include guard.
7261         * cli/cli-style.h: Rename include guard.
7262         * cli/cli-setshow.h: Rename include guard.
7263         * cli/cli-script.h: Rename include guard.
7264         * cli/cli-interp.h: Rename include guard.
7265         * cli/cli-decode.h: Rename include guard.
7266         * cli/cli-cmds.h: Rename include guard.
7267         * charset-list.h: Add include guard.
7268         * buildsym-legacy.h: Rename include guard.
7269         * bfin-tdep.h: Add include guard.
7270         * ax.h: Rename include guard.
7271         * arm-linux-tdep.h: Add include guard.
7272         * arm-fbsd-tdep.h: Add include guard.
7273         * arch/xtensa.h: Rename include guard.
7274         * arch/tic6x.h: Add include guard.
7275         * arch/i386.h: Add include guard.
7276         * arch/arm.h: Rename include guard.
7277         * arch/arm-linux.h: Rename include guard.
7278         * arch/arm-get-next-pcs.h: Rename include guard.
7279         * arch/amd64.h: Add include guard.
7280         * arch/aarch64-insn.h: Rename include guard.
7281         * arch-utils.h: Rename include guard.
7282         * annotate.h: Add include guard.
7283         * amd64-darwin-tdep.h: Rename include guard.
7284         * aarch64-linux-tdep.h: Add include guard.
7285         * aarch64-fbsd-tdep.h: Add include guard.
7286         * aarch32-linux-nat.h: Add include guard.
7287
7288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7289
7290         * macrotab.c (macro_define_internal): New function that
7291         factorizes macro_define_object_internal and macro_define_function
7292         code.
7293         (macro_define_object_internal): Use macro_define_internal.
7294         (macro_define_function): Likewise.
7295
7296 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7297
7298         * macrocmd.c (extract_identifier): Return
7299         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7300         callers.
7301
7302 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7303
7304         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7305
7306 2019-02-05  Tom Tromey  <tom@tromey.com>
7307
7308         * target.c (target_stack::unpush): Move assertion earlier.
7309
7310 2019-01-30  Tom Tromey  <tom@tromey.com>
7311
7312         PR python/23615:
7313         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7314         (gdbpy_parse_and_eval): Likewise.
7315         * python/python-internal.h (gdbpy_allow_threads): New class.
7316
7317 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7318
7319         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7320         (aarch64_fbsd_fpregmap): Move earlier.
7321         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7322         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7323         instead of individual calls to trad_frame_set_reg_addr.
7324         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7325         earlier.
7326         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7327         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7328         instead of individual calls to trad_frame_set_reg_addr.
7329
7330 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7331
7332         * CONTRIBUTE: Replace contribution list with wiki link.
7333
7334 2019-01-25  Tom Tromey  <tom@tromey.com>
7335
7336         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7337
7338 2019-01-25  Tom Tromey  <tom@tromey.com>
7339
7340         * xtensa-linux-nat.c: Fix common/ includes.
7341         * xml-support.h: Fix common/ includes.
7342         * xml-support.c: Fix common/ includes.
7343         * x86-linux-nat.c: Fix common/ includes.
7344         * windows-nat.c: Fix common/ includes.
7345         * varobj.h: Fix common/ includes.
7346         * varobj.c: Fix common/ includes.
7347         * value.c: Fix common/ includes.
7348         * valops.c: Fix common/ includes.
7349         * utils.c: Fix common/ includes.
7350         * unittests/xml-utils-selftests.c: Fix common/ includes.
7351         * unittests/utils-selftests.c: Fix common/ includes.
7352         * unittests/unpack-selftests.c: Fix common/ includes.
7353         * unittests/tracepoint-selftests.c: Fix common/ includes.
7354         * unittests/style-selftests.c: Fix common/ includes.
7355         * unittests/string_view-selftests.c: Fix common/ includes.
7356         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7357         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7358         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7359         * unittests/rsp-low-selftests.c: Fix common/ includes.
7360         * unittests/parse-connection-spec-selftests.c: Fix common/
7361         includes.
7362         * unittests/optional-selftests.c: Fix common/ includes.
7363         * unittests/offset-type-selftests.c: Fix common/ includes.
7364         * unittests/observable-selftests.c: Fix common/ includes.
7365         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7366         * unittests/memrange-selftests.c: Fix common/ includes.
7367         * unittests/memory-map-selftests.c: Fix common/ includes.
7368         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7369         * unittests/function-view-selftests.c: Fix common/ includes.
7370         * unittests/environ-selftests.c: Fix common/ includes.
7371         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7372         * unittests/common-utils-selftests.c: Fix common/ includes.
7373         * unittests/cli-utils-selftests.c: Fix common/ includes.
7374         * unittests/array-view-selftests.c: Fix common/ includes.
7375         * ui-file.c: Fix common/ includes.
7376         * tui/tui-io.c: Fix common/ includes.
7377         * tracepoint.h: Fix common/ includes.
7378         * tracepoint.c: Fix common/ includes.
7379         * tracefile-tfile.c: Fix common/ includes.
7380         * top.h: Fix common/ includes.
7381         * top.c: Fix common/ includes.
7382         * thread.c: Fix common/ includes.
7383         * target/waitstatus.h: Fix common/ includes.
7384         * target/waitstatus.c: Fix common/ includes.
7385         * target.h: Fix common/ includes.
7386         * target.c: Fix common/ includes.
7387         * target-memory.c: Fix common/ includes.
7388         * target-descriptions.c: Fix common/ includes.
7389         * symtab.h: Fix common/ includes.
7390         * symfile.c: Fix common/ includes.
7391         * stap-probe.c: Fix common/ includes.
7392         * spu-linux-nat.c: Fix common/ includes.
7393         * sparc-nat.c: Fix common/ includes.
7394         * source.c: Fix common/ includes.
7395         * solib.c: Fix common/ includes.
7396         * solib-target.c: Fix common/ includes.
7397         * ser-unix.c: Fix common/ includes.
7398         * ser-tcp.c: Fix common/ includes.
7399         * ser-pipe.c: Fix common/ includes.
7400         * ser-base.c: Fix common/ includes.
7401         * selftest-arch.c: Fix common/ includes.
7402         * s12z-tdep.c: Fix common/ includes.
7403         * rust-exp.y: Fix common/ includes.
7404         * rs6000-aix-tdep.c: Fix common/ includes.
7405         * riscv-tdep.c: Fix common/ includes.
7406         * remote.c: Fix common/ includes.
7407         * remote-notif.h: Fix common/ includes.
7408         * remote-fileio.h: Fix common/ includes.
7409         * remote-fileio.c: Fix common/ includes.
7410         * regcache.h: Fix common/ includes.
7411         * regcache.c: Fix common/ includes.
7412         * record-btrace.c: Fix common/ includes.
7413         * python/python.c: Fix common/ includes.
7414         * python/py-type.c: Fix common/ includes.
7415         * python/py-inferior.c: Fix common/ includes.
7416         * progspace.h: Fix common/ includes.
7417         * producer.c: Fix common/ includes.
7418         * procfs.c: Fix common/ includes.
7419         * proc-api.c: Fix common/ includes.
7420         * printcmd.c: Fix common/ includes.
7421         * ppc-linux-nat.c: Fix common/ includes.
7422         * parser-defs.h: Fix common/ includes.
7423         * osdata.c: Fix common/ includes.
7424         * obsd-nat.c: Fix common/ includes.
7425         * nat/x86-linux.c: Fix common/ includes.
7426         * nat/x86-linux-dregs.c: Fix common/ includes.
7427         * nat/x86-dregs.h: Fix common/ includes.
7428         * nat/x86-dregs.c: Fix common/ includes.
7429         * nat/ppc-linux.c: Fix common/ includes.
7430         * nat/mips-linux-watch.h: Fix common/ includes.
7431         * nat/mips-linux-watch.c: Fix common/ includes.
7432         * nat/linux-waitpid.c: Fix common/ includes.
7433         * nat/linux-ptrace.h: Fix common/ includes.
7434         * nat/linux-ptrace.c: Fix common/ includes.
7435         * nat/linux-procfs.c: Fix common/ includes.
7436         * nat/linux-personality.c: Fix common/ includes.
7437         * nat/linux-osdata.c: Fix common/ includes.
7438         * nat/linux-namespaces.c: Fix common/ includes.
7439         * nat/linux-btrace.h: Fix common/ includes.
7440         * nat/linux-btrace.c: Fix common/ includes.
7441         * nat/fork-inferior.c: Fix common/ includes.
7442         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7443         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7444         * nat/aarch64-linux.c: Fix common/ includes.
7445         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7446         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7447         * namespace.h: Fix common/ includes.
7448         * mips-linux-tdep.c: Fix common/ includes.
7449         * minsyms.c: Fix common/ includes.
7450         * mi/mi-parse.h: Fix common/ includes.
7451         * mi/mi-main.c: Fix common/ includes.
7452         * mi/mi-cmd-env.c: Fix common/ includes.
7453         * memrange.h: Fix common/ includes.
7454         * memattr.c: Fix common/ includes.
7455         * maint.h: Fix common/ includes.
7456         * maint.c: Fix common/ includes.
7457         * main.c: Fix common/ includes.
7458         * machoread.c: Fix common/ includes.
7459         * location.c: Fix common/ includes.
7460         * linux-thread-db.c: Fix common/ includes.
7461         * linux-nat.c: Fix common/ includes.
7462         * linux-fork.c: Fix common/ includes.
7463         * inline-frame.c: Fix common/ includes.
7464         * infrun.c: Fix common/ includes.
7465         * inflow.c: Fix common/ includes.
7466         * inferior.h: Fix common/ includes.
7467         * inferior.c: Fix common/ includes.
7468         * infcmd.c: Fix common/ includes.
7469         * inf-ptrace.c: Fix common/ includes.
7470         * inf-child.c: Fix common/ includes.
7471         * ia64-linux-nat.c: Fix common/ includes.
7472         * i387-tdep.c: Fix common/ includes.
7473         * i386-tdep.c: Fix common/ includes.
7474         * i386-linux-tdep.c: Fix common/ includes.
7475         * i386-linux-nat.c: Fix common/ includes.
7476         * i386-go32-tdep.c: Fix common/ includes.
7477         * i386-fbsd-tdep.c: Fix common/ includes.
7478         * i386-fbsd-nat.c: Fix common/ includes.
7479         * guile/scm-type.c: Fix common/ includes.
7480         * guile/guile.c: Fix common/ includes.
7481         * go32-nat.c: Fix common/ includes.
7482         * gnu-nat.c: Fix common/ includes.
7483         * gdbthread.h: Fix common/ includes.
7484         * gdbarch-selftests.c: Fix common/ includes.
7485         * gdb_usleep.c: Fix common/ includes.
7486         * gdb_select.h: Fix common/ includes.
7487         * gdb_bfd.c: Fix common/ includes.
7488         * gcore.c: Fix common/ includes.
7489         * fork-child.c: Fix common/ includes.
7490         * findvar.c: Fix common/ includes.
7491         * fbsd-nat.c: Fix common/ includes.
7492         * event-top.c: Fix common/ includes.
7493         * event-loop.c: Fix common/ includes.
7494         * dwarf2read.c: Fix common/ includes.
7495         * dwarf2loc.c: Fix common/ includes.
7496         * dwarf2-frame.c: Fix common/ includes.
7497         * dwarf-index-cache.c: Fix common/ includes.
7498         * dtrace-probe.c: Fix common/ includes.
7499         * disasm-selftests.c: Fix common/ includes.
7500         * defs.h: Fix common/ includes.
7501         * csky-tdep.c: Fix common/ includes.
7502         * cp-valprint.c: Fix common/ includes.
7503         * cp-support.h: Fix common/ includes.
7504         * cp-support.c: Fix common/ includes.
7505         * corelow.c: Fix common/ includes.
7506         * completer.h: Fix common/ includes.
7507         * completer.c: Fix common/ includes.
7508         * compile/compile.c: Fix common/ includes.
7509         * compile/compile-loc2c.c: Fix common/ includes.
7510         * compile/compile-cplus-types.c: Fix common/ includes.
7511         * compile/compile-cplus-symbols.c: Fix common/ includes.
7512         * command.h: Fix common/ includes.
7513         * cli/cli-dump.c: Fix common/ includes.
7514         * cli/cli-cmds.c: Fix common/ includes.
7515         * charset.c: Fix common/ includes.
7516         * build-id.c: Fix common/ includes.
7517         * btrace.h: Fix common/ includes.
7518         * btrace.c: Fix common/ includes.
7519         * breakpoint.h: Fix common/ includes.
7520         * breakpoint.c: Fix common/ includes.
7521         * ax.h:
7522         (enum agent_op): Fix common/ includes.
7523         * ax-general.c (struct aop_map): Fix common/ includes.
7524         * ax-gdb.c: Fix common/ includes.
7525         * auxv.c: Fix common/ includes.
7526         * auto-load.c: Fix common/ includes.
7527         * arm-tdep.c: Fix common/ includes.
7528         * arch/riscv.c: Fix common/ includes.
7529         * arch/ppc-linux-common.c: Fix common/ includes.
7530         * arch/i386.c: Fix common/ includes.
7531         * arch/arm.c: Fix common/ includes.
7532         * arch/arm-linux.c: Fix common/ includes.
7533         * arch/arm-get-next-pcs.c: Fix common/ includes.
7534         * arch/amd64.c: Fix common/ includes.
7535         * arch/aarch64.c: Fix common/ includes.
7536         * arch/aarch64-insn.c: Fix common/ includes.
7537         * arch-utils.c: Fix common/ includes.
7538         * amd64-windows-tdep.c: Fix common/ includes.
7539         * amd64-tdep.c: Fix common/ includes.
7540         * amd64-sol2-tdep.c: Fix common/ includes.
7541         * amd64-obsd-tdep.c: Fix common/ includes.
7542         * amd64-nbsd-tdep.c: Fix common/ includes.
7543         * amd64-linux-tdep.c: Fix common/ includes.
7544         * amd64-linux-nat.c: Fix common/ includes.
7545         * amd64-fbsd-tdep.c: Fix common/ includes.
7546         * amd64-fbsd-nat.c: Fix common/ includes.
7547         * amd64-dicos-tdep.c: Fix common/ includes.
7548         * amd64-darwin-tdep.c: Fix common/ includes.
7549         * agent.c: Fix common/ includes.
7550         * ada-lang.h: Fix common/ includes.
7551         * ada-lang.c: Fix common/ includes.
7552         * aarch64-tdep.c: Fix common/ includes.
7553
7554 2019-01-25  Tom Tromey  <tom@tromey.com>
7555
7556         * common/create-version.sh: Use common/version.h.
7557
7558 2019-01-24  Pedro Alves  <palves@redhat.com>
7559
7560         * infrun.c (signal_stop, signal_print, signal_program)
7561         (signal_catch, signal_pass): Now arrays instead of pointers.
7562         (update_signals_program_target, do_target_resume)
7563         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7564         * linux-nat.c (linux_nat_target::pass_signals)
7565         (linux_nat_target::create_inferior, linux_nat_target::attach):
7566         Adjust.
7567         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7568         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7569         * procfs.c (procfs_target::pass_signals): Adjust.
7570         * record-full.c (record_full_target::resume): Adjust.
7571         * remote.c (remote_target::pass_signals)
7572         (remote_target::program_signals): Adjust.
7573         * target-debug.h (target_debug_print_signals): Now takes a
7574         gdb::array_view as parameter.  Adjust.
7575         * target.h (target_ops) <pass_signals, program_signals>: Replace
7576         pointer and length parameters with gdb::array_view.
7577         (target_pass_signals, target_program_signals): Likewise.
7578         * target-delegates.c: Regenerate.
7579
7580 2019-01-24  Pedro Alves  <palves@redhat.com>
7581
7582         * common/forward-scope-exit.h
7583         (forward_scope_exit::forward_scope_exit): Pass arguments to
7584         m_bind_function directly, instead of creating a std::bind and
7585         copying that.
7586
7587 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7588
7589         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7590         for static members.
7591         (pass_in_v_vfp_candidate): Likewise.
7592
7593 2019-01-23  Tom Tromey  <tom@tromey.com>
7594             Pedro Alves  <palves@redhat.com>
7595
7596         * regcache.c (class regcache_invalidator): Remove.
7597         (regcache::raw_write): Use make_scope_exit.
7598
7599 2019-01-23  Tom Tromey  <tom@tromey.com>
7600
7601         * ui-out.h (class ui_out_emit_type): Update comment.
7602
7603 2019-01-23  Tom Tromey  <tom@tromey.com>
7604
7605         * infrun.c (fetch_inferior_event): Update comment.
7606
7607 2019-01-23  Tom Tromey  <tom@tromey.com>
7608             Pedro Alves  <palves@redhat.com>
7609
7610         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7611         parameter.
7612         (fetch_inferior_event): Use SCOPE_EXIT.
7613
7614
7615 2019-01-23  Tom Tromey  <tom@tromey.com>
7616             Pedro Alves  <palves@redhat.com>
7617
7618         * infrun.c (disable_thread_events): Delete.
7619         (stop_all_threads): Use SCOPE_EXIT.
7620
7621 2019-01-23  Tom Tromey  <tom@tromey.com>
7622             Pedro Alves  <palves@redhat.com>
7623
7624         * symfile.c: Include forward-scope-exit.h.
7625         (clear_symtab_users_cleanup): Replace forward declaration with
7626         a FORWARD_SCOPE_EXIT.
7627         (syms_from_objfile_1): Use the forward_scope_exit and
7628         gdb::optional instead of cleanup_function.
7629         (reread_symbols): Use the forward_scope_exit instead of
7630         cleanup_function.
7631         (clear_symtab_users_cleanup): Remove function.
7632
7633 2019-01-23  Tom Tromey  <tom@tromey.com>
7634             Pedro Alves  <palves@redhat.com>
7635
7636         * linux-nat.c: Include scope-exit.h.
7637         (cleanup_target_stop): Remove.
7638         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7639         SCOPE_EXIT.
7640
7641 2019-01-23  Tom Tromey  <tom@tromey.com>
7642             Pedro Alves  <palves@redhat.com>
7643
7644         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7645         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7646
7647 2019-01-23  Tom Tromey  <tom@tromey.com>
7648             Andrew Burgess  <andrew.burgess@embecosm.com>
7649             Pedro Alves  <palves@redhat.com>
7650
7651         * infrun.c (fetch_inferior_event): Use scope_exit.
7652         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7653         * top.c (execute_command): Use scope_exit.
7654         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7655         * utils.c (do_bpstat_clear_actions_cleanup)
7656         (make_bpstat_clear_actions_cleanup): Remove.
7657
7658 2019-01-23  Tom Tromey  <tom@tromey.com>
7659             Pedro Alves  <palves@redhat.com>
7660
7661         * infrun.c: Include "common/scope-exit.h"
7662         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7663         (wait_for_inferior): Use SCOPE_EXIT.
7664         (fetch_inferior_event): Use scope_exit.
7665
7666 2019-01-23  Tom Tromey  <tom@tromey.com>
7667             Pedro Alves  <palves@redhat.com>
7668
7669         * breakpoint.c (create_breakpoint): Remove cleanup.
7670
7671 2019-01-23  Tom Tromey  <tom@tromey.com>
7672             Andrew Burgess  <andrew.burgess@embecosm.com>
7673             Pedro Alves  <palves@redhat.com>
7674
7675 2019-01-23  Pedro Alves  <palves@redhat.com>
7676
7677         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7678
7679 2019-01-23  Pedro Alves  <palves@redhat.com>
7680             Andrew Burgess  <andrew.burgess@embecosm.com>
7681
7682         * gdbthread.h: Include "common/forward-scope-exit.h".
7683         (scoped_finish_thread_state): Redefine custom class in terms of
7684         forward_scope_exit.
7685
7686 2019-01-23  Pedro Alves  <palves@redhat.com>
7687             Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         * common/forward-scope-exit.h: New file.
7690
7691 2019-01-23  Pedro Alves  <palves@redhat.com>
7692             Andrew Burgess  <andrew.burgess@embecosm.com>
7693             Tom Tromey  <tom@tromey.com>
7694
7695         * common/scope-exit.h: New file.
7696
7697 2019-01-23  Pedro Alves  <palves@redhat.com>
7698
7699         * common/preprocessor.h (ESC): Rename to ...
7700         (ESC_PARENS): ... this.
7701         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7702         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7703
7704 2019-01-23  Tom Tromey  <tom@tromey.com>
7705
7706         * language.h (class scoped_switch_to_sym_language_if_auto):
7707         Initialize m_lang in both cases.
7708
7709 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7710
7711         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7712         with XCNEW.
7713
7714 2019-01-22  Tom Tromey  <tom@tromey.com>
7715
7716         * corelow.c: Do not include sys/file.h.
7717
7718 2019-01-22  Tom Tromey  <tom@tromey.com>
7719
7720         * tui/tui-wingeneral.h: Include gdb_curses.h.
7721
7722 2019-01-22  Tom Tromey  <tom@tromey.com>
7723
7724         * source-cache.h (class source_cache) <get_source_lines,
7725         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7726
7727 2019-01-22  Tom Tromey  <tom@tromey.com>
7728
7729         * remote-fileio.h (struct remote_target): Declare.
7730
7731 2019-01-22  Tom Tromey  <tom@tromey.com>
7732
7733         * python/py-arch.c: Do not include py-ref.h.
7734         * python/py-bpevent.c: Do not include py-ref.h.
7735         * python/py-cmd.c: Do not include py-ref.h.
7736         * python/py-continueevent.c: Do not include py-ref.h.
7737         * python/py-event.h: Do not include py-ref.h.
7738         * python/py-evtregistry.c: Do not include py-ref.h.
7739         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7740         * python/py-frame.c: Do not include py-ref.h.
7741         * python/py-framefilter.c: Do not include py-ref.h.
7742         * python/py-function.c: Do not include py-ref.h.
7743         * python/py-infevents.c: Do not include py-ref.h.
7744         * python/py-linetable.c: Do not include py-ref.h.
7745         * python/py-objfile.c: Do not include py-ref.h.
7746         * python/py-param.c: Do not include py-ref.h.
7747         * python/py-prettyprint.c: Do not include py-ref.h.
7748         * python/py-progspace.c: Do not include py-ref.h.
7749         * python/py-symbol.c: Do not include py-ref.h.
7750         * python/py-symtab.c: Do not include py-ref.h.
7751         * python/py-type.c: Do not include py-ref.h.
7752         * python/py-unwind.c: Do not include py-ref.h.
7753         * python/py-utils.c: Do not include py-ref.h.
7754         * python/py-value.c: Do not include py-ref.h.
7755         * python/py-varobj.c: Do not include py-ref.h.
7756         * python/py-xmethods.c: Do not include py-ref.h.
7757         * python/python.c: Do not include py-ref.h.
7758         * varobj.c: Do not include py-ref.h.
7759
7760 2019-01-22  Tom Tromey  <tom@tromey.com>
7761
7762         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7763         keyword for bcache.
7764
7765 2019-01-22  Tom Tromey  <tom@tromey.com>
7766
7767         * compile/compile-cplus-types.c: Remove a comment by #include.
7768
7769 2019-01-22  Tom Tromey  <tom@tromey.com>
7770
7771         * compile/gcc-c-plugin.h: Include compile-internal.h.
7772
7773 2019-01-22  Tom Tromey  <tom@tromey.com>
7774
7775         * stabsread.c (EXTERN): Do not define.
7776         (symnum, next_symbol_text_func, processing_gcc_compilation)
7777         (within_function, global_sym_chain, global_stabs)
7778         (previous_stab_code, this_object_header_files)
7779         (n_this_object_header_files)
7780         (n_allocated_this_object_header_files): Define.
7781         * stabsread.h (EXTERN): Never define.  Use "extern".
7782
7783 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7784
7785         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7786         history_value.
7787
7788 2019-01-21  Tom Tromey  <tom@tromey.com>
7789
7790         * ui-out.c: Fix includes.
7791         * tui/tui-source.c: Fix includes.
7792         * target.c: Fix includes.
7793         * remote.c: Fix includes.
7794         * regcache.c: Fix includes.
7795         * python/py-block.c: Fix includes.
7796         * printcmd.c: Fix includes.
7797         * or1k-tdep.c: Fix includes.
7798         * mi/mi-main.c: Fix includes.
7799         * m32r-tdep.c: Fix includes.
7800         * csky-tdep.c: Fix includes.
7801         * compile/compile-cplus-types.c: Fix includes.
7802         * cli/cli-interp.c: Fix includes.
7803
7804 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7805
7806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7807         for padding.
7808
7809 2019-01-16  Tom Tromey  <tom@tromey.com>
7810
7811         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7812         earlier.
7813         (struct objfile) <msymbols_range>: Move from top level.
7814         <msymbols>: New method.
7815         (class objfile_msymbols): Remove.
7816         * symtab.c (default_collect_symbol_completion_matches_break_on):
7817         Update.
7818         * symmisc.c (dump_msymbols): Update.
7819         * stabsread.c (scan_file_globals): Update.
7820         * objc-lang.c (info_selectors_command, info_classes_command)
7821         (find_methods): Update.
7822         * minsyms.c (find_solib_trampoline_target): Update.
7823         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7824         * coffread.c (coff_symfile_read): Update.
7825         * ada-lang.c (ada_lookup_simple_minsym)
7826         (ada_collect_symbol_completion_matches): Update.
7827
7828 2019-01-16  Tom Tromey  <tom@tromey.com>
7829
7830         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7831         type.  Remove no-argument constructor.
7832         <iterator::operator++>: Simplify.
7833         <begin>: Update.
7834         <end>: Use minimal_symbol_count.
7835
7836 2019-01-16  Tom Tromey  <tom@tromey.com>
7837
7838         * objfiles.h (struct objfile) <psymtabs>: New method.
7839         (class objfile_psymtabs): Remove.
7840         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7841         typedef.
7842         <range>: New method.
7843         (require_partial_symbols): Change return type.
7844         * psymtab.c (require_partial_symbols)
7845         (psym_expand_symtabs_matching): Update.
7846         * mdebugread.c (parse_partial_symbols): Update.
7847         * dbxread.c (dbx_end_psymtab): Update.
7848
7849 2019-01-15  Tom Tromey  <tom@tromey.com>
7850
7851         * symtab.c (lookup_objfile_from_block)
7852         (lookup_symbol_in_objfile_symtabs)
7853         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7854         (find_line_symtab, info_sources_command)
7855         (default_collect_symbol_completion_matches_break_on)
7856         (make_source_files_completion_list): Update.
7857         * symmisc.c (print_objfile_statistics, dump_objfile)
7858         (maintenance_print_symbols, maintenance_info_symtabs)
7859         (maintenance_check_symtabs, maintenance_info_line_tables):
7860         Update.
7861         * source.c (select_source_symtab)
7862         (forget_cached_source_info_for_objfile): Update.
7863         * objfiles.h (class objfile_compunits): Remove.
7864         (struct objfile) <compunits_range>: New typedef.
7865         (compunits): New method.
7866         * objfiles.c (objfile_relocate1): Update.
7867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7868         * maint.c (count_symtabs_and_blocks): Update.
7869         * linespec.c (iterate_over_all_matching_symtabs): Update.
7870         * cp-support.c (add_symbol_overload_list_qualified): Update.
7871         * coffread.c (coff_symtab_read): Update.
7872         * ada-lang.c (add_nonlocal_symbols)
7873         (ada_collect_symbol_completion_matches)
7874         (ada_add_global_exceptions): Update.
7875
7876 2019-01-15  Tom Tromey  <tom@tromey.com>
7877
7878         * progspace.h (program_space) <objfiles_safe_range>: New
7879         typedef.
7880         <objfiles_safe>: New method.
7881         * objfiles.h (class all_objfiles_safe): Remove.
7882         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7883         * jit.c (jit_inferior_exit_hook): Update.
7884
7885 2019-01-17  Tom Tromey  <tom@tromey.com>
7886
7887         * progspace.h (program_space) <objfiles_range>: New typedef.
7888         <objfiles>: New method.
7889         <objfiles_head>: Rename from objfiles.
7890         (object_files): Update.
7891         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7892         * guile/scm-pretty-print.c
7893         (ppscm_find_pretty_printer_from_objfiles): Update.
7894         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7895         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7896         Update.
7897         * python/py-progspace.c (pspy_get_objfiles): Update.
7898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7899         Update.
7900         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7901         (objfpy_lookup_objfile_by_build_id): Update.
7902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7904         Update.
7905         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7906         (expand_symtab_containing_pc, lookup_objfile_from_block)
7907         (lookup_static_symbol, basic_lookup_transparent_type)
7908         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7909         (find_line_symtab, info_sources_command)
7910         (default_collect_symbol_completion_matches_break_on)
7911         (make_source_files_completion_list, find_main_name): Update.
7912         * symmisc.c (print_symbol_bcache_statistics)
7913         (print_objfile_statistics, maintenance_print_symbols)
7914         (maintenance_print_msymbols, maintenance_print_objfiles)
7915         (maintenance_info_symtabs, maintenance_check_symtabs)
7916         (maintenance_expand_symtabs, maintenance_info_line_tables):
7917         Update.
7918         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7919         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7920         (map_overlay_command, unmap_overlay_command)
7921         (simple_overlay_update, expand_symtabs_matching)
7922         (map_symbol_filenames): Update.
7923         * symfile-debug.c (set_debug_symfile): Update.
7924         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7925         Update.
7926         * source.c (select_source_symtab, forget_cached_source_info):
7927         Update.
7928         * solib.c (solib_read_symbols): Update.
7929         * solib-spu.c (append_ocl_sos): Update.
7930         * psymtab.c (maintenance_print_psymbols)
7931         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7932         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7933         * printcmd.c (info_symbol_command): Update.
7934         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7935         Update.
7936         * objfiles.h (class all_objfiles): Remove.
7937         * objfiles.c (have_partial_symbols, have_full_symbols)
7938         (have_minimal_symbols, qsort_cmp, update_section_map)
7939         (shared_objfile_contains_address_p)
7940         (default_iterate_over_objfiles_in_search_order): Update.
7941         * objc-lang.c (info_selectors_command, info_classes_command)
7942         (find_methods): Update.
7943         * minsyms.c (find_solib_trampoline_target): Update.
7944         * maint.c (maintenance_info_sections)
7945         (maintenance_translate_address, count_symtabs_and_blocks):
7946         Update.
7947         * main.c (captured_main_1): Update.
7948         * linux-thread-db.c (try_thread_db_load_from_pdir)
7949         (has_libpthread): Update.
7950         * linespec.c (iterate_over_all_matching_symtabs)
7951         (search_minsyms_for_name): Update.
7952         * jit.c (jit_find_objf_with_entry_addr): Update.
7953         * hppa-tdep.c (find_unwind_entry)
7954         (hppa_lookup_stub_minimal_symbol): Update.
7955         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7956         Update.
7957         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7958         (elf_gnu_ifunc_resolve_by_got): Update.
7959         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7960         * dwarf-index-write.c (save_gdb_index_command): Update.
7961         * cp-support.c (add_symbol_overload_list_qualified): Update.
7962         * breakpoint.c (create_overlay_event_breakpoint)
7963         (create_longjmp_master_breakpoint)
7964         (create_std_terminate_master_breakpoint)
7965         (create_exception_master_breakpoint): Update.
7966         * blockframe.c (find_pc_partial_function): Update.
7967         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7968         (ada_collect_symbol_completion_matches)
7969         (ada_add_global_exceptions): Update.
7970
7971 2019-01-17  Tom Tromey  <tom@tromey.com>
7972
7973         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7974         declare VEC.
7975         (solib_target_parse_libraries): Change return type.
7976         (library_list_start_segment, library_list_start_section)
7977         (library_list_end_library, library_list_start_library); Update.
7978         (solib_target_free_library_list): Remove.
7979         (solib_target_parse_libraries): Remove cleanup.  Change return
7980         type.
7981         (solib_target_current_sos): Update.
7982
7983 2019-01-17  Tom Tromey  <tromey@bapiya>
7984
7985         * valprint.c: Replace "the the" with "the".
7986         * symtab.c: Replace "the the" with "the".
7987         * solib.c: Replace "the the" with "the".
7988         * solib-dsbt.c: Replace "the the" with "the".
7989         * linespec.c: Replace "the the" with "the".
7990         * dwarf2loc.h: Replace "the the" with "the".
7991         * amd64-windows-tdep.c: Replace "the the" with "the".
7992         * aarch64-tdep.c: Replace "the the" with "the".
7993
7994 2019-01-16  Keith Seitz  <keiths@redhat.com>
7995
7996         PR gdb/23773
7997         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7998         <builder>: Rename to ..
7999         <m_builder>: ... this and make private.
8000         (dwarf2_cu::get_builder): New method.  Change all users of
8001         `builder' to use this method.
8002         (dwarf2_start_symtab): Move to ...
8003         (dwarf2_cu::start_symtab): ... here.  Update all callers
8004         (setup_type_unit_groups): Move to ...
8005         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8006         callers.
8007         (dwarf2_cu::reset_builder): New method.
8008         (process_full_compunit, process_full_type_unit): Use
8009         dwarf2_cu::reset_builder.
8010         (follow_die_offset): Record the ancestor CU if it is different
8011         from the followed DIE's CU.
8012         (follow_die_sig_1): Likewise.
8013
8014 2019-01-15  Tom Tromey  <tom@tromey.com>
8015
8016         * remote.c (class remote_state) <buf>: Now a char_vector.
8017         <buf_size>: Remove.
8018         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8019         parameter.
8020         (remote_target::getpkt_or_notif_sane_1)
8021         (remote_target::getpkt_sane)
8022         (remote_target::getpkt_or_notif_sane): Likewise.
8023         (class remote_target) <putpkt>: New overload.
8024         (remote_target::read_frame): Change type of "buf_p".  Remove
8025         sizeof_p parameter.
8026         (packet_ok): New overload.
8027         (packet_check_result): New overload.
8028         Update all uses.
8029
8030 2019-01-14  Tom Tromey  <tom@tromey.com>
8031
8032         * remote-notif.c (handle_notification, remote_notif_ack)
8033         (remote_notif_parse): Make "buf" const.
8034         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8035         const.
8036         (remote_notif_parse, remote_notif_ack, handle_notification):
8037         Likewise.
8038         * remote.c (remote_notif_stop_parse): Make "buf" const.
8039         (remote_target::remote_parse_stop_reply): Make "buf" const.
8040         (remote_notif_stop_ack): Make "buf" const.
8041
8042 2019-01-14  Tom Tromey  <tom@tromey.com>
8043
8044         * remote.c (remote_console_output): Make parameter const.
8045
8046 2019-01-14  Tom Tromey  <tom@tromey.com>
8047
8048         * target-debug.h (target_debug_print_signals): Constify.
8049         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8050         * procfs.c (procfs_target::pass_signals): Update.
8051         * linux-nat.c (linux_nat_target::pass_signals): Update.
8052         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8053         * target-delegates.c: Rebuild.
8054         * remote.c (remote_target::program_signals): Update.
8055         (remote_target::pass_signals): Update.
8056         * target.c (target_pass_signals): Constify argument.
8057         (target_program_signals): Likewise.
8058         * target.h (struct target_ops) <pass_signals, program_signals>:
8059         Constify argument.
8060         (target_pass_signals, target_program_signals): Constify argument.
8061
8062 2019-01-14  Tom Tromey  <tom@tromey.com>
8063
8064         PR tui/28819:
8065         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8066
8067 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8068
8069         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8070         field.
8071         * rs6000-tdep.c: Include reggroups.h.
8072         (IS_V_ALIAS_PSEUDOREG): Define.
8073         (rs6000_register_name): Return names for the "vX" aliases.
8074         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8075         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8076         aliases.  Call default_register_reggroup_p for all other
8077         pseudo-registers.
8078         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8079         New functions.
8080         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8081         Handle "vX" aliases.
8082         (v_alias_pseudo_register_collect): New function.
8083         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8084         (rs6000_gdbarch_init): Initialize "vX" aliases as
8085         pseudo-registers.  Restore registration of
8086         rs6000_pseudo_register_reggroup_p with
8087         set_tdesc_pseudo_register_reggroup_p.
8088
8089 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8090
8091         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8092         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8093         set_gdbarch_num_pseudo_regs.
8094
8095 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8096
8097         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8098         Remove arg prefixname, add do_set and do_show.
8099         Add member functions set_list and show_list.
8100         * cli/cli-style.c (class cli_style_option): Update accordingly.
8101         (style_set_list): Move to file scope.
8102         (style_show_list): Likewise.
8103         (set_style): Call help_list.
8104         (show_style): Call cmd_show_list.
8105         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8106         Update to use the new macro.
8107
8108 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8109
8110         * ada-lang.c (_initialize_ada_language): Expand the help text
8111         for the "catch exception" command.
8112
8113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8114
8115         * symtab.c (matching_obj_sections): Initialize obj,
8116         declare it closer to its usage.
8117
8118 2019-01-10  Tom Tromey  <tom@tromey.com>
8119
8120         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8121         (basic_inf_threads_range): Remove.
8122         (inf_threads_range, inf_non_exited_threads_range)
8123         (safe_inf_threads_range): Use next_adapter.
8124
8125 2019-01-10  Keith Seitz  <keiths@redhat.com>
8126
8127         PR gdb/23712
8128         PR symtab/23010
8129         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8130         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8131
8132 2019-01-10  Keith Seitz  <keiths@redhat.com>
8133
8134         PR gdb/23712
8135         PR symtab/23010
8136         * dictionary.c (pending_to_vector): Remove.
8137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8138         Remove _1 suffix, replacing functions of the same name.  Update
8139         all callers.
8140         (dict_create_hashed, dict_create_hashed_expandable)
8141         (dict_create_linear, dict_create_linear_expandable, dict_free)
8142         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8143         Make functions static.
8144
8145 2019-01-10  Keith Seitz  <keiths@redhat.com>
8146
8147         PR gdb/23712
8148         PR symtab/23010
8149         * dictionary.h (struct dictionary): Replace declaration with
8150         multidictionary.
8151         (dict_create_hashed, dict_create_hashed_expandable)
8152         (dict_create_linear, dict_create_linear_expandable)
8153         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8154         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8155         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8156         taking multidictionary argument.
8157         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8158         * block.h (struct block) <dict>: Change to multidictionary
8159         and rename `multidict'.
8160         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8161         symmisc.c: Update all dictionary references to multidictionary.
8162
8163 2019-01-10  Keith Seitz  <keiths@redhat.com>
8164
8165         PR gdb/23712
8166         PR symtab/23010
8167         * dictionary.c: Include unordered_map.
8168         (pending_to_vector): New function.
8169         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8170         Rewrite the non-"_1" functions to take vector instead
8171         of linked list.
8172         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8173         "new" _1 versions of the same name.
8174         (multidictionary): Define.
8175         (std::hash<enum language): New definition.
8176         (collate_pending_symbols_by_language, mdict_create_hashed)
8177         (mdict_create_hashed_expandable, mdict_create_linear)
8178         (mdict_create_linear_expandable, mdict_free)
8179         (find_language_dictionary, create_new_language_dictionary)
8180         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8181         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8182         (mdict_size, mdict_empty): New functions.
8183         * dictionary.h (mdict_iterator): Define.
8184
8185 2019-01-10  Pedro Alves  <palves@redhat.com>
8186
8187         * breakpoint.c (read_uploaded_action)
8188         (create_tracepoint_from_upload): Adjust to use
8189         gdb::unique_xmalloc_ptr.
8190         * ctf.c (ctf_write_uploaded_tp):
8191         (SET_ARRAY_FIELD): Use emplace_back.
8192         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8193         * tracefile-tfile.c (tfile_write_uploaded_tp):
8194         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8195         gdb::unique_xmalloc_ptr.
8196         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8197         at_string, cond_string, cmd_strings>: Replace char pointers
8198         with gdb::unique_xmalloc_ptr.
8199
8200 2019-01-10  Pedro Alves  <palves@redhat.com>
8201
8202         * solib-target.c (library_list_start_library): Don't xstrdup name.
8203
8204 2019-01-10  Pedro Alves  <palves@redhat.com>
8205
8206         * mdebugread.c (parse_partial_symbols): Use
8207         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8208
8209 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8210
8211         * linux-fork.c (scoped_switch_fork_info)
8212         <~scoped_switch_fork_info>: Fix incorrect variable name.
8213
8214 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8215
8216         * linux-fork.c (scoped_switch_fork_info)
8217         <scoped_switch_fork_info>: Make explicit.
8218         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8219
8220 2019-01-10  Tom Tromey  <tom@tromey.com>
8221
8222         * objfiles.h (objfile::reset_psymtabs): Update.
8223         * objfiles.c (objfile::objfile): Update.
8224         * psymtab.h (psymtab_storage::obstack): Update.
8225         (psymtab_storage::m_obstack): Use gdb::optional.
8226         (class psymtab_storage): Update comment.  Remove objfile
8227         parameter.
8228         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8229
8230 2019-01-10  Tom Tromey  <tom@tromey.com>
8231
8232         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8233         <free_psymtabs>: Now private.
8234         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8235         (allocate_psymtab): Use new method.
8236
8237 2019-01-10  Tom Tromey  <tom@tromey.com>
8238
8239         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8240         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8241         * mdebugread.c (parse_partial_symbols): Use
8242         allocate_dependencies.
8243         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8244         allocate_dependencies.
8245         (process_psymtab_comp_unit_reader)
8246         (build_type_psymtab_dependencies): Likewise.
8247         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8248
8249 2019-01-10  Tom Tromey  <tom@tromey.com>
8250
8251         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8252         PSYMBOL_SET_LANGUAGE.
8253         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8254
8255 2019-01-10  Tom Tromey  <tom@tromey.com>
8256
8257         * psymtab.h (psymtab_storage::obstack): New method.
8258         <m_obstack>: Rename from obstack; now private.
8259         * psymtab.c (psymtab_storage): Update.
8260         * dwarf2read.c (create_addrmap_from_index)
8261         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8262         Update.
8263
8264 2019-01-10  Tom Tromey  <tom@tromey.com>
8265
8266         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8267         * objfiles.h (objfile::reset_psymtabs): New method.
8268
8269 2019-01-10  Tom Tromey  <tom@tromey.com>
8270
8271         * symmisc.c (print_symbol_bcache_statistics): Update.
8272         (print_objfile_statistics): Update.
8273         * symfile.c (reread_symbols): Update.
8274         * psymtab.h (class psymtab_storage): New.
8275         * psymtab.c (psymtab_storage): New constructor.
8276         (~psymtab_storage): New destructor.
8277         (require_partial_symbols): Update.
8278         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8279         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8280         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8281         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8282         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8283         (start_psymtab_common, end_psymtab_common)
8284         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8285         (allocate_psymtab): Update.
8286         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8287         Update.
8288         (dump_psymtab_addrmap, maintenance_print_psymbols)
8289         (maintenance_check_psymtabs): Update.
8290         (class objfile_psymtabs): Move to objfiles.h.
8291         * psympriv.h (discard_psymtab): Now inline.
8292         (psymtab_discarder::psymtab_discarder): Update.
8293         (psymtab_discarder::~psymtab_discarder): Update.
8294         (ALL_OBJFILE_PSYMTABS): Rewrite.
8295         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8296         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8297         Remove fields.
8298         <partial_symtabs>: New field.
8299         (class objfile_psymtabs): Move from psymtab.h.  Update.
8300         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8301         psymbol_cache.
8302         (objfile::~objfile): Don't destroy psymbol_cache.
8303         * mdebugread.c (parse_partial_symbols): Update.
8304         * dwarf2read.c (create_addrmap_from_index)
8305         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8306         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8307         (add_partial_subprogram, dwarf2_ranges_read): Update.
8308         * dwarf-index-write.c (write_address_map)
8309         (write_one_signatured_type, recursively_write_psymbols)
8310         (class debug_names, class debug_names, write_psymtabs_to_index):
8311         Update.
8312
8313 2019-01-10  Tom Tromey  <tom@tromey.com>
8314
8315         * symtab.h (SYMBOL_SET_NAMES): Update.
8316         (symbol_set_names): Update.
8317         (MSYMBOL_SET_NAMES): Update.
8318         * symtab.c (symbol_set_names): Change argument to be an
8319         objfile_per_bfd_storage.
8320         * psymtab.c (add_psymbol_to_bcache): Update.
8321         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8322
8323 2019-01-10  Tom Tromey  <tom@tromey.com>
8324
8325         * symtab.c (create_demangled_names_hash): Change argument to be an
8326         objfile_per_bfd_storage.
8327         (symbol_set_names): Update.
8328
8329 2019-01-10  Tom Tromey  <tom@tromey.com>
8330
8331         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8332         init_psymbol_list.
8333         * psymtab.c (init_psymbol_list): Do nothing if already called.
8334         * psympriv.h (init_psymbol_list): Add comment.
8335         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8336         init_psymbol_list.
8337         * dbxread.c (dbx_symfile_read): Unconditionally call
8338         init_psymbol_list.
8339
8340 2019-01-10  Tom Tromey  <tom@tromey.com>
8341
8342         * xcoffread.c (scan_xcoff_symtab): Update.
8343         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8344         "where".
8345         * mdebugread.c (parse_partial_symbols)
8346         (handle_psymbol_enumerators): Update.
8347         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8348         * dbxread.c (read_dbx_symtab): Update.
8349         * psympriv.h (psymbol_placement): New enum.
8350         (add_psymbol_to_list): Update.
8351
8352 2019-01-10  Tom Tromey  <tom@tromey.com>
8353
8354         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8355         static_psymbols parameters.
8356         (scan_xcoff_symtab): Update.
8357         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8358         static_psymbols parameters.
8359         * psympriv.h (start_psymtab_common): Update.
8360         * mdebugread.c (parse_partial_symbols): Update.
8361         * dwarf2read.c (create_partial_symtab): Update.
8362         * dbxread.c (read_dbx_symtab): Update.
8363         (start_psymtab): Remove global_psymbols and static_psymbols
8364         parameters.
8365
8366 2019-01-10  Tom Tromey  <tom@tromey.com>
8367
8368         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8369         * psymtab.c (allocate_psymtab): Add comment.
8370         * psympriv.h (allocate_psymtab): Add comment.
8371         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8372         initializations.
8373         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8374
8375 2019-01-10  Tom Tromey  <tom@tromey.com>
8376
8377         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8378         Don't declare.
8379         * mipsread.c: Include mdebugread.h.
8380         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8381         Declare.
8382         * elfread.c: Include mdebugread.h.
8383
8384 2019-01-09  Tom Tromey  <tom@tromey.com>
8385
8386         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8387         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8388         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8389         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8390         (psym_lookup_symbol, psym_find_last_source_symtab)
8391         (psym_forget_cached_source_info, psym_print_stats)
8392         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8393         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8394         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8395         (psym_find_compunit_symtab_by_address)
8396         (maintenance_print_psymbols, maintenance_info_psymtabs)
8397         (maintenance_check_psymtabs): Use ranged for.
8398         * psymtab.h (class objfile_psymtabs): New.
8399         (require_partial_symbols): Return objfile_psymtabs.
8400         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8401
8402 2019-01-09  Tom Tromey  <tom@tromey.com>
8403
8404         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8405         (find_pc_mapped_section, list_overlays_command)
8406         (map_overlay_command, unmap_overlay_command)
8407         (simple_overlay_update): Use all_objfiles.
8408         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8409         * printcmd.c (info_symbol_command): Use all_objfiles.
8410         * objfiles.h (ALL_OBJSECTIONS): Remove.
8411         * maint.c (maintenance_translate_address): Use all_objfiles.
8412         * gcore.c (gcore_create_callback): Use all_objfiles.
8413         (objfile_find_memory_regions): Likewise.
8414
8415 2019-01-09  Tom Tromey  <tom@tromey.com>
8416
8417         * symtab.c (find_line_symtab, info_sources_command)
8418         (make_source_files_completion_list): Use objfile_compunits.
8419         * source.c (select_source_symtab): Use objfile_compunits.
8420         * objfiles.h (struct objfile): Update comment.
8421         (ALL_OBJFILES): Remove.
8422         (ALL_FILETABS): Remove.
8423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8424         objfile_compunits.
8425
8426 2019-01-09  Tom Tromey  <tom@tromey.com>
8427
8428         * symmisc.c (print_objfile_statistics, dump_objfile)
8429         (maintenance_print_symbols): Use compunit_filetabs.
8430         * source.c (forget_cached_source_info_for_objfile): Use
8431         compunit_filetabs.
8432         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8433         (ALL_FILETABS): Use compunit_filetabs.
8434         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8435         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8436
8437 2019-01-09  Tom Tromey  <tom@tromey.com>
8438
8439         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8440         (compunit_filetabs): New.
8441         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8442         compunit_filetabs.
8443         (info_sources_command, make_source_files_completion_list): Remove
8444         declaration.
8445         * symmisc.c (print_objfile_statistics, dump_objfile)
8446         (maintenance_print_symbols): Remove declaration.
8447         (maintenance_info_symtabs): Use compunit_filetabs.
8448         (maintenance_info_line_tables): Likewise.
8449         * source.c (select_source_symtab): Change local variable name.
8450         (forget_cached_source_info_for_objfile): Remove declaration.
8451         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8452         * objfiles.c (objfile_relocate1): Remove declaration.
8453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8454         declaration.
8455         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8456         * coffread.c (coff_symtab_read): Remove declaration.
8457         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8458         compunit_filetabs.
8459
8460 2019-01-09  Tom Tromey  <tom@tromey.com>
8461
8462         * symtab.c (lookup_objfile_from_block)
8463         (find_pc_sect_compunit_symtab, search_symbols)
8464         (default_collect_symbol_completion_matches_break_on): Use
8465         objfile_compunits.
8466         * objfiles.h (ALL_COMPUNITS): Remove.
8467         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8468         * cp-support.c (add_symbol_overload_list_qualified): Use
8469         objfile_compunits.
8470         * ada-lang.c (ada_collect_symbol_completion_matches)
8471         (ada_add_global_exceptions): Use objfile_compunits.
8472
8473 2019-01-09  Tom Tromey  <tom@tromey.com>
8474
8475         * source.c (select_source_symtab)
8476         (forget_cached_source_info_for_objfile): Remove declaration.
8477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8478         declaration.
8479         * maint.c (count_symtabs_and_blocks): Remove declaration.
8480         * cp-support.c (add_symbol_overload_list_qualified): Remove
8481         declaration.
8482         * coffread.c (coff_symtab_read): Remove declaration.
8483         * symtab.c (lookup_symbol_in_objfile_symtabs)
8484         (basic_lookup_transparent_type_1): Use objfile_compunits.
8485         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8486         (info_sources_command, search_symbols)
8487         (default_collect_symbol_completion_matches_break_on)
8488         (make_source_files_completion_list): Remove declaration.
8489         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8490         (ada_collect_symbol_completion_matches)
8491         (ada_add_global_exceptions): Remove declaration.
8492         * linespec.c (iterate_over_all_matching_symtabs): Use
8493         objfile_compunits.
8494         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8495         (class objfile_compunits): New.
8496         (ALL_COMPUNITS): Use objfile_compunits.
8497         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8498         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8499         objfile_compunits.
8500         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8501
8502 2019-01-09  Tom Tromey  <tom@tromey.com>
8503
8504         * symtab.c (search_symbols)
8505         (default_collect_symbol_completion_matches_break_on): Use
8506         objfile_msymbols.
8507         * ada-lang.c (ada_lookup_simple_minsym)
8508         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8509         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8510         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8511         objfile_msymbols.
8512         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8513         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8514         * objc-lang.c (find_methods): Use objfile_msymbols.
8515         (info_selectors_command, info_classes_command): Likewise.
8516         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8517         * objfiles.h (class objfile_msymbols): New.
8518         (ALL_OBJFILE_MSYMBOLS): Remove.
8519         (ALL_MSYMBOLS): Remove.
8520
8521 2019-01-09  Tom Tromey  <tom@tromey.com>
8522
8523         * common/next-iterator.h (next_adapter): Add Iterator template
8524         parameter.
8525         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8526         (class all_objfiles_safe): New.
8527         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8528         * objfiles.c (put_objfile_before): Update comment.
8529         (add_separate_debug_objfile): Likewise.
8530         (free_all_objfiles): Use all_objfiles_safe.
8531         (objfile_purge_solibs): Likewise.
8532
8533 2019-01-09  Tom Tromey  <tom@tromey.com>
8534
8535         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8536         (expand_symtab_containing_pc, lookup_static_symbol)
8537         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8538         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8539         all_objfiles.
8540         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8541         * breakpoint.c (create_overlay_event_breakpoint)
8542         (create_longjmp_master_breakpoint)
8543         (create_std_terminate_master_breakpoint)
8544         (create_exception_master_breakpoint): Use all_objfiles.
8545         * linux-thread-db.c (try_thread_db_load_from_pdir)
8546         (has_libpthread): Use all_objfiles.
8547         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8548         * linespec.c (iterate_over_all_matching_symtabs)
8549         (search_minsyms_for_name): Use all_objfiles.
8550         * maint.c (maintenance_info_sections): Use all_objfiles.
8551         * main.c (captured_main_1): Use all_objfiles.
8552         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8553         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8554         * guile/scm-pretty-print.c
8555         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8556         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8557         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8558         (maintenance_print_msymbols): Use all_objfiles.
8559         * source.c (select_source_symtab): Use all_objfiles.
8560         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8561         * symfile.c (remove_symbol_file_command)
8562         (expand_symtabs_matching, map_symbol_filenames): Use
8563         all_objfiles.
8564         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8565         all_objfiles.
8566         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8567         * objc-lang.c (find_methods): Use all_objfiles.
8568         * objfiles.c (have_partial_symbols, have_full_symbols)
8569         (have_minimal_symbols, qsort_cmp)
8570         (default_iterate_over_objfiles_in_search_order): Use
8571         all_objfiles.
8572         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8573         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8574         (maintenance_check_psymtabs): Use all_objfiles.
8575         (ALL_PSYMTABS): Remove.
8576         * compile/compile-object-run.c (do_module_cleanup): Use
8577         all_objfiles.
8578         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8579         * cp-support.c (add_symbol_overload_list_qualified): Use
8580         all_objfiles.
8581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8582         Use all_objfiles.
8583         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8584         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8585         all_objfiles.
8586         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8587         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8589         Uses all_objfiles.
8590         * solib.c (solib_read_symbols): Use all_objfiles
8591
8592 2019-01-09  Tom Tromey  <tom@tromey.com>
8593
8594         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8595         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8596         all_objfiles.
8597         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8598         * symmisc.c (print_symbol_bcache_statistics)
8599         (print_objfile_statistics, maintenance_print_objfiles)
8600         (maintenance_info_symtabs, maintenance_check_symtabs)
8601         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8602         all_objfiles.
8603         * source.c (forget_cached_source_info): Use all_objfiles.
8604         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8605         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8606         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8607         * objfiles.c (update_section_map): Use all_objfiles.
8608         (shared_objfile_contains_address_p): Likewise.
8609         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8610         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8611
8612 2019-01-09  Tom Tromey  <tom@tromey.com>
8613
8614         * common/next-iterator.h: New file.
8615         * objfiles.h (class all_objfiles): New.
8616         (struct objfile_iterator): New.
8617
8618 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8619
8620         * NEWS: Move the description of the changed "frame", "select-frame",
8621          and "info frame" commands to the Changed commands section.
8622
8623 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8624
8625         * gdbtypes.c (check_stub_method_group): Remove handling of old
8626         mangling schemes.
8627         * linespec.c (find_methods): Likewise.
8628         * stabsread.c (read_member_functions): Likewise.
8629         * valops.c (search_struct_method): Likewise.
8630         (value_struct_elt_for_reference): Likewise.
8631         * NEWS: Mention this change.
8632
8633 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8634
8635         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8636         print_source_lines.
8637         * source.c (print_source_lines_base): Update line number check.
8638         (print_source_lines): New function.
8639         (source_lines_range::source_lines_range): New function.
8640         * source.h (class source_lines_range): New class.
8641         (print_source_lines): New declaration.
8642
8643 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8644
8645         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8646
8647 2019-01-08  Tom Tromey  <tom@tromey.com>
8648             Simon Marchi  <simon.marchi@ericsson.com>
8649
8650         PR gdb/24060
8651         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8652         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8653         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8654         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8655         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8656         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8657
8658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8659
8660         * source.c (select_source_symtab): Move header comment to
8661         declaration in source.h.
8662         (forget_cached_source_info_for_objfile): Likewise.
8663         (forget_cached_source_info): Likewise.
8664         (identify_source_line): Likewise.
8665         * source.h (identify_source_line): Move declaration from symtab.h
8666         and add comment from source.c
8667         (print_source_lines): Likewise.
8668         (forget_cached_source_info_for_objfile): Likewise.
8669         (forget_cached_source_info): Likewise.
8670         (select_source_symtab): Likewise.
8671         (enum print_source_lines_flag): Move definition from symtab.h.
8672         * symtab.h (identify_source_line): Move declaration to source.h.
8673         (print_source_lines): Likewise.
8674         (forget_cached_source_info_for_objfile): Likewise.
8675         (forget_cached_source_info): Likewise.
8676         (select_source_symtab): Likewise.
8677         (enum print_source_lines_flag): Move definition to source.h.
8678         * tui/tui-hooks.c: Add 'source.h' include.
8679
8680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * source.c (print_source_lines_base): Handle requests to print
8683         reverse line number sequences, and guard against empty lines
8684         string.
8685
8686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8687
8688         * source.c (print_source_lines_base): Fix skip of '\r' if next
8689         character is '\n'.
8690
8691 2019-01-06  Tom Tromey  <tom@tromey.com>
8692
8693         * c-exp.y (struct c_parse_state) <macro_original_text,
8694         expansion_obstack>: New member.
8695         (macro_original_text, expansion_obstack): Remove globals.
8696         (scan_macro_expansion, scanning_macro_expansion)
8697         (finished_macro_expansion): Update.
8698         (scan_macro_cleanup): Remove.
8699         (yylex, c_parse): Update.
8700
8701 2019-01-06  Tom Tromey  <tom@tromey.com>
8702
8703         * c-exp.y (struct c_parse_state) <strings>: New member.
8704         (operator_stoken): Update.
8705
8706 2019-01-06  Tom Tromey  <tom@tromey.com>
8707
8708         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8709         (union type_stack_elt) <typelist_val>: Now a pointer to
8710         std::vector.
8711         (type_stack_cleanup): Don't declare.
8712         (push_typelist): Update.
8713         * parse.c (pop_typelist): Return a std::vector.
8714         (push_typelist): Take a std::vector.
8715         (follow_types): Update.  Do not free args.
8716         (type_stack_cleanup): Remove.
8717         * c-exp.y (struct c_parse_state): New.
8718         (cpstate): New global.
8719         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8720         (nonempty_typelist): Update.
8721         (func_mod): Create a new vector.
8722         (c_parse): Create a c_parse_state.
8723         (check_parameter_typelist): Do not delete params.
8724         (function_method): Update.  Do not delete type_list.
8725
8726 2019-01-06  Tom Tromey  <tom@tromey.com>
8727
8728         PR gdb/28155:
8729         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8730         check_typedef.
8731         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8732         (print_return_value): Likewise.
8733
8734 2019-01-05  Tom Tromey  <tom@tromey.com>
8735
8736         * contrib/cleanup_check.py: Remove.
8737         * contrib/gcc-with-excheck: Remove.
8738         * contrib/exsummary.py: Remove.
8739         * contrib/excheck.py: Remove.
8740
8741 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8742
8743         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8744         NULL. Initialize tpprev to NULL instead of assigning it
8745         to NULL on the next statement.
8746         * windows-nat.c (windows_delete_thread): Remove check for
8747         main_thread_id before printing thread exit notifications.
8748         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8749         Remove thread ID check against main_thread_id.
8750         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8751         windows_delete_thread.
8752         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8753
8754 2019-01-04  Tom Tromey  <tom@tromey.com>
8755
8756         * compile/compile.c (_initialize_compile): Use upper case for
8757         metasyntactic variables.
8758         * symmisc.c (_initialize_symmisc): Use upper case for
8759         metasyntactic variables.
8760         * psymtab.c (_initialize_psymtab): Use upper case for
8761         metasyntactic variables.
8762         * demangle.c (demangle_command): Use upper case for metasyntactic
8763         variables.
8764         (_initialize_demangler): Likewise.
8765         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8766         variables.
8767
8768 2019-01-03  Tom Tromey  <tom@tromey.com>
8769
8770         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8771
8772 2019-01-03  Tom Tromey  <tom@tromey.com>
8773
8774         * python/py-symtab.c (salpy_str): Update.
8775         (struct salpy_sal_object) <symtab>: Now a PyObject.
8776         (salpy_dealloc): Update.
8777         (del_objfile_sal): Use gdbpy_ref.
8778
8779 2019-01-03  Tom Tromey  <tom@tromey.com>
8780
8781         * python/py-type.c (convert_field): Use new_reference.  Return
8782         gdbpy_ref.
8783         (make_fielditem): Return gdbpy_ref.
8784         (typy_fields): Update.
8785         (typy_getitem): Update.
8786         (field_name): Return gdbpy_ref.  Use new_reference.
8787         (typy_iterator_iternext): Update.
8788
8789 2019-01-03  Tom Tromey  <tom@tromey.com>
8790
8791         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8792
8793 2019-01-03  Tom Tromey  <tom@tromey.com>
8794
8795         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8796         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8797         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8798         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8799         (pspy_set_type_printers): Likewise.
8800         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8801         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8802         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8803         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8804         (objfpy_set_type_printers): Likewise.
8805
8806 2019-01-03  Tom Tromey  <tom@tromey.com>
8807
8808         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8809         (gdbpy_print_stack): Use gdbpy_err_fetch.
8810         * python/python-internal.h (class gdbpy_err_fetch): New class.
8811         (class gdbpy_enter) <m_error_type, m_error_value,
8812         m_error_traceback>: Remove.
8813         <m_error>: New member.
8814         (gdbpy_exception_to_string): Don't declare.
8815         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8816         * python/py-value.c (convert_value_from_python): Use
8817         gdbpy_err_fetch.
8818         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8819         gdbpy_exception_to_string.
8820         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8821         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8822         gdbpy_err_fetch.
8823
8824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8825
8826         * linux-nat.c (delete_lwp_cleanup): Delete.
8827         (struct lwp_deleter): New struct.
8828         (lwp_info_up): New typedef.
8829         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8830         lwp_info_up.
8831
8832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * linux-fork.c (class scoped_switch_fork_info): New class.
8835         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8836
8837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8838
8839         * valops.c (find_overload_match): Remove use of null_cleanup, and
8840         calls to do_cleanups.
8841
8842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * compile/compile-cplus-types.c
8845         (compile_cplus_instance::decl_name): Handle changes to
8846         cp_func_name.
8847         * cp-support.c (cp_func_name): Update header comment, update
8848         return type.
8849         * cp-support.h (cp_func_name): Update return type in declaration.
8850         * valops.c (find_overload_match): Move temp_func local to top
8851         level of function and change its type.  Use temp_func to hold and
8852         delete temporary string obtained from cp_func_name.
8853
8854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8855
8856         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8857         gdb::char_vector, remove cleanup, and update uses of `msg`.
8858
8859 2019-01-03  Jim Wilson  <jimw@sifive.com>
8860
8861         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8862
8863 2019-01-02  Tom Tromey  <tom@tromey.com>
8864
8865         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8866         (tdesc_parse_xml): Remove cleanups.
8867         * target-descriptions.h (make_cleanup_free_target_description):
8868         Don't declare.
8869         (target_desc_deleter): New struct.
8870         (target_desc_up): New typedef.
8871         * target-descriptions.c (target_desc_deleter::operator()): Rename
8872         from free_target_description.
8873         (make_cleanup_free_target_description): Remove.
8874
8875 2019-01-02  Tom Tromey  <tom@tromey.com>
8876
8877         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8878         constructor, destructor.
8879         (linespec_parser): Remove typedef.
8880         (~linespec_parser): Rename from linespec_parser_delete.
8881         (linespec_lex_to_end, linespec_complete_label)
8882         (linespec_complete): Update.
8883         (decode_line_full): Remove cleanups.
8884         (decode_line_1): Update.
8885
8886 2019-01-02  Tom Tromey  <tom@tromey.com>
8887
8888         * python/python-internal.h (inferior_to_inferior_object): Change
8889         return type.
8890         * python/py-exitedevent.c (create_exited_event_object): Update.
8891         * python/py-inferior.c (inferior_to_inferior_object): Return
8892         gdbpy_ref.
8893         (python_new_inferior, python_inferior_deleted)
8894         (thread_to_thread_object, delete_thread_object)
8895         (build_inferior_list, gdbpy_selected_inferior): Update.
8896         * python/py-infthread.c (create_thread_object): Update.  Also fail
8897         if inferior_to_inferior_object fails.
8898
8899 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8900
8901         * inferior.h (class inferior) <displaced_step_state>: New field.
8902         * infrun.h (struct displaced_step_state): Move here from
8903         infrun.c.  Initialize fields, add constructor.
8904         <inf>: Remove field.
8905         <reset>: New method.
8906         * infrun.c (struct displaced_step_inferior_state): Move to
8907         infrun.h.
8908         (displaced_step_inferior_states): Remove.
8909         (get_displaced_stepping_state): Adust.
8910         (displaced_step_in_progress_any_inferior): Adjust.
8911         (displaced_step_in_progress_thread): Adjust.
8912         (displaced_step_in_progress): Adjust.
8913         (add_displaced_stepping_state): Remove.
8914         (get_displaced_step_closure_by_addr): Adjust.
8915         (remove_displaced_stepping_state): Remove.
8916         (infrun_inferior_exit): Call displaced_step_state.reset.
8917         (use_displaced_stepping): Don't check for NULL.
8918         (displaced_step_prepare_throw): Call
8919         get_displaced_stepping_state.
8920         (displaced_step_fixup): Don't check for NULL.
8921         (prepare_for_detach): Don't check for NULL.
8922
8923 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8924
8925         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8926          in case of call that did not complete.
8927
8928 2019-01-02  Andrey Utkin  <autkin@undo.io>
8929
8930         * symfile.c (find_separate_debug_file): Fix search of debug files for
8931         remote debuggee.
8932
8933 2019-01-02  Tom Tromey  <tom@tromey.com>
8934
8935         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8936         indentation.
8937         * python/py-frame.c (frapy_older): Remove cast.
8938         (frapy_newer): Likewise.
8939         * python/py-breakpoint.c (local_setattro): Remove cast.
8940         * python/py-arch.c (archpy_name): Remove local variable.
8941         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8942
8943 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8944
8945         * unittests/basic_string_view/element_access/char/empty.cc:
8946         Fix year range in copyright header.
8947
8948 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8951         Delete.
8952         <operator==>: Update with for removed field.
8953         <hash>: Likewise.
8954         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8955         <isa_features>: ...this.
8956         <abi_features>: New field.
8957         (riscv_isa_flen): Update comment.
8958         (riscv_abi_xlen): New declaration.
8959         (riscv_abi_flen): New declaration.
8960         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8961         isa_features.
8962         (riscv_abi_xlen): New function.
8963         (riscv_isa_flen): Update to get answer from isa_features.
8964         (riscv_abi_flen): New function.
8965         (riscv_has_fp_abi): Update to get answer from abi_features.
8966         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8967         xlen and flen.
8968         (riscv_call_info) <xlen, flen>: Update comment.
8969         (riscv_call_arg_struct): Remove invalid assertions
8970         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8971         is removed.
8972         (riscv_gdbarch_init): Gather isa features and abi features
8973         separately, ensure both match on the gdbarch when reusing an old
8974         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8975         a target with 64-bit float hardware.
8976
8977 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8978
8979         * source.c (search_command_helper): Stop reverse search
8980         when line 1 has been searched.
8981
8982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8983
8984         * record-full.c (record_full_base_target::close): Rewrite
8985         record_full_core_buf_list free logic.
8986
8987 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8988
8989         * break-catch-syscall.c (print_one_catch_syscall): xfree
8990         the last text.
8991
8992 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8993
8994         * top.c (print_gdb_version): Update Copyright year in version
8995         message.
8996
8997 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8998
8999         Update copyright year range in all GDB files.
9000
9001 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9002
9003         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9004
9005 For older changes see ChangeLog-2018.
9006 \f
9007 Local Variables:
9008 mode: change-log
9009 left-margin: 8
9010 fill-column: 74
9011 version-control: never
9012 coding: utf-8
9013 End:
9014