gdb/ChangeLog

   1 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * f-exp.y (struct f77_boolean_val): Add comments.
   4         (boolean_values): Remove uppercase versions, and end marker.
   5         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
   6         and use strncasecmp to achieve case insensitivity.  Additionally,
   7         perform whitespace cleanup around this code.
   8
   9 2019-03-06  Tom Tromey  <tromey@adacore.com>
  10
  11         * remote-sim.c (gdbsim_target_open): Use result of
  12         gdb_argv::release.
  13
  14 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
  15         Dirk Schubert  <dirk.schubert@arm.com>
  16         Chris January  <chris.january@arm.com>
  17
  18         * eval.c (evaluate_subexp_standard): Call Fortran argument
  19         wrapping logic.
  20         * f-lang.c (struct value): A value which can be passed into a
  21         Fortran function call.
  22         (fortran_argument_convert): Wrap Fortran arguments in a pointer
  23         where appropriate.
  24         (struct type): Value ready for a Fortran function call.
  25         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
  26         is needed.
  27         * f-lang.h (fortran_argument_convert): Declaration.
  28         (fortran_preserve_arg_pointer): Declaration.
  29         * infcall.c (value_arg_coerce): Call Fortran argument logic.
  30
  31 2019-03-05  Tom Tromey  <tromey@adacore.com>
  32
  33         * python/py-prettyprint.c (print_string_repr): Remove #if.
  34         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
  35
  36 2019-03-05  Tom Tromey  <tromey@adacore.com>
  37
  38         * target.c (the_dummy_target): Move later.  Change type to
  39         "dummy_target".
  40         (initialize_targets): Don't initialize the_dummy_target.
  41
  42 2019-03-05  Tom Tromey  <tromey@adacore.com>
  43
  44         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
  45         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
  46
  47 2019-03-05  Tom Tromey  <tromey@adacore.com>
  48
  49         * windows-nat.c (windows_nat_target::attach)
  50         (windows_nat_target::detach): Don't call gdb_flush.
  51         * valprint.c (generic_val_print, val_print, val_print_string):
  52         Don't call gdb_flush.
  53         * utils.c (defaulted_query): Don't call gdb_flush.
  54         * typeprint.c (print_type_scalar): Don't call gdb_flush.
  55         * target.c (target_announce_detach): Don't call gdb_flush.
  56         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
  57         * remote.c (extended_remote_target::attach): Don't call
  58         gdb_flush.
  59         * procfs.c (procfs_target::detach): Don't call gdb_flush.
  60         * printcmd.c (do_examine): Don't call gdb_flush.
  61         (info_display_command): Don't call gdb_flush.
  62         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
  63         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
  64         * memattr.c (info_mem_command): Don't call gdb_flush.
  65         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
  66         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
  67         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
  68         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
  69         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
  70         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
  71         (gnu_nat_target::detach): Don't call gdb_flush.
  72         * f-valprint.c (f_val_print): Don't call gdb_flush.
  73         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
  74         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
  75         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
  76         gdb_flush.
  77         * c-valprint.c (c_val_print): Don't call gdb_flush.
  78         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
  79
  80 2019-03-05  Tom Tromey  <tromey@adacore.com>
  81
  82         * varobj.c (update_dynamic_varobj_children): Update.
  83         (install_default_visualizer): Use reset, not release.
  84         * value.c (set_internalvar): Update.
  85         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
  86         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
  87         ATTRIBUTE_UNUSED_RESULT.
  88
  89 2019-03-05  Tom Tromey  <tromey@adacore.com>
  90
  91         * remote.c (class scoped_remote_fd) <release>: Add
  92         ATTRIBUTE_UNUSED_RESULT.
  93
  94 2019-03-05  Tom Tromey  <tromey@adacore.com>
  95
  96         * macroexp.c (struct macro_buffer) <release>: Add
  97         ATTRIBUTE_UNUSED_RESULT.
  98
  99 2019-03-05  Tom Tromey  <tromey@adacore.com>
 100
 101         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 102         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 103         ATTRIBUTE_UNUSED_RESULT.
 104
 105 2019-03-05  Tom Tromey  <tromey@adacore.com>
 106
 107         * common/scoped_fd.h (class scoped_fd) <release>: Add
 108         ATTRIBUTE_UNUSED_RESULT.
 109
 110 2019-03-05  Tom Tromey  <tromey@adacore.com>
 111
 112         * parser-defs.h (struct parser_state) <release>: Add
 113         ATTRIBUTE_UNUSED_RESULT.
 114
 115 2019-03-05  Tom Tromey  <tromey@adacore.com>
 116
 117         * utils.h (class gdb_argv) <release>: Add
 118         ATTRIBUTE_UNUSED_RESULT.
 119         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 120
 121 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 122
 123         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 124         for-loop range, to avoid compiler warnings.
 125
 126         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 127         avoid compiler warnings about unused variables.
 128
 129         * NEWS: Mention end of support for native debugging on MS-Windows
 130         before XP.
 131
 132         PR gdb/24292
 133         * common/netstuff.c:
 134         * gdbserver/gdbreplay.c
 135         * gdbserver/remote-utils.c:
 136         * ser-tcp.c:
 137         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 138         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 139         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 140         'getaddrinfo' and 'freeaddrinfo' were not available before
 141         Windows XP, and mingw.org's MinGW headers by default define
 142         _WIN32_WINNT to 0x500.
 143
 144 2019-03-01  Gary Benson <gbenson@redhat.com>
 145
 146         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 147
 148 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 149             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 150
 151         PR gdb/8527
 152         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 153         set_sigint_trap, clear_sigint_trap.
 154
 155 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 156
 157         * target.c (target_detach): Clear the regcache and the
 158         frame cache.
 159
 160 2019-02-27  Pedro Alves  <palves@redhat.com>
 161
 162         * utils.c (set_screen_size): When we cap the height/width sizes,
 163         tweak the corresponding command variable to show "unlimited":
 164
 165 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 166             Pedro Alves  <palves@redhat.com>
 167
 168         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 169         before calling rl_set_screen_size.
 170
 171 2019-02-27  Tom Tromey  <tromey@adacore.com>
 172
 173         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 174         define.
 175         * python/py-value.c: Remove Python 2.4 workaround.
 176         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 177         workaround.
 178         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 179         Python 2.4 workaround.
 180         * python/python-internal.h: Remove Python 2.4 comment.
 181         (Py_ssize_t): Don't define.
 182         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 183         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 184         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 185         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 186         * python/python.c (do_start_initialization): Remove Python 2.4
 187         workaround.
 188         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 189         (print_children): Remove Python 2.4 workaround.
 190         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 191         workaround.
 192         (CHARBUFFERPROC_NAME): Remove.
 193         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 194         Python 2.4 workaround.
 195
 196 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 197
 198         * NEWS: Note minimum Python version.
 199
 200 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 201
 202         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 203         code from these functions.  Remove corresponding ifdefs.  Use
 204         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 205         Remove gotos and target of gotos.
 206         (infpy_search_memory): Likewise.
 207
 208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 209
 210         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 211         (hppa_gdbarch_init): Don't register deleted functions with
 212         gdbarch.
 213
 214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 217         (h8300_unwind_sp): Delete.
 218         (h8300_dummy_id): Delete.
 219         (h8300_gdbarch_init): Don't register deleted functions with
 220         gdbarch.
 221
 222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 223
 224         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 225         (ft32_unwind_pc): Delete.
 226         (ft32_unwind_sp): Delete.
 227         (ft32_gdbarch_init): Don't register deleted functions with
 228         gdbarch.
 229
 230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 233         (frv_unwind_pc): Delete.
 234         (frv_unwind_sp): Delete.
 235         (frv_gdbarch_init): Don't register deleted functions with
 236         gdbarch.
 237
 238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 241         (riscv_unwind_pc): Delete.
 242         (riscv_unwind_sp): Delete.
 243         (riscv_gdbarch_init): Don't register deleted functions with
 244         gdbarch.
 245
 246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 249         (csky_unwind_pc): Delete.
 250         (csky_unwind_sp): Delete.
 251         (csky_gdbarch_init): Don't register deleted functions with
 252         gdbarch.
 253
 254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 257         (cris_unwind_pc): Delete.
 258         (cris_unwind_sp): Delete.
 259         (cris_gdbarch_init): Don't register deleted functions with
 260         gdbarch.
 261
 262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 263
 264         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 265         (bfin_unwind_pc): Delete.
 266         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 267
 268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 269
 270         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 271         (arm_unwind_pc): Delete.
 272         (arm_unwind_sp): Delete.
 273         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 274
 275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 278         (arc_unwind_pc): Delete.
 279         (arc_unwind_sp): Delete.
 280         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 281
 282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 285         (alpha_unwind_pc): Delete.
 286         (alpha_gdbarch_init): Don't register deleted functions with
 287         gdbarch.
 288
 289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 292         (aarch64_unwind_pc): Delete.
 293         (aarch64_unwind_sp): Delete.
 294         (aarch64_gdbarch_init): Don't register deleted functions with
 295         gdbarch.
 296
 297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 298
 299         * gdbtypes.c (type_align): Don't consider static members when
 300         computing structure alignment.
 301
 302 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 303
 304         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 305         return 0 for other types.
 306         * arch-utils.c (default_type_align): Always return 0.
 307         * gdbarch.h: Regenerate.
 308         * gdbarch.sh (type_align): Extend comment.
 309         * gdbtypes.c (type_align): Add additional comments, always call
 310         gdbarch_type_align before applying the default rules.
 311         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 312         generic code will then apply a suitable default.
 313         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 314         types, return 0 for other types.
 315
 316 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 317
 318         * NEWS: Create a new section for the next release branch.
 319         Rename the section of the current branch, now that it has
 320         been cut.
 321
 322 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 323
 324         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 325         * version.in: Bump version to 8.3.50.DATE-git.
 326
 327 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 328
 329         * aix-thread.c (ptid_cmp): Remove unused variable.
 330         (get_signaled_thread): Likewise.
 331         (store_regs_user_thread): Likewise.
 332         (store_regs_kernel_thread): Likewise.
 333         (fetch_regs_kernel_thread): Remove shadowed variable.
 334
 335 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * features/riscv/32bit-cpu.xml: Add register numbers.
 338         * features/riscv/32bit-fpu.c: Regenerate.
 339         * features/riscv/32bit-fpu.xml: Add register numbers.
 340         * features/riscv/64bit-cpu.xml: Add register numbers.
 341         * features/riscv/64bit-fpu.c: Regenerate.
 342         * features/riscv/64bit-fpu.xml: Add register numbers.
 343
 344 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 345
 346         * NEWS: Mention two argument form of gdb.Value constructor.
 347         * python/py-value.c (convert_buffer_and_type_to_value): New
 348         function.
 349         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 350         Add support for handling an optional second argument.  Call
 351         convert_buffer_and_type_to_value as appropriate.
 352         * python/python-internal.h (Py_buffer_deleter): New struct.
 353         (Py_buffer_up): New typedef.
 354
 355 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 356
 357         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 358         instead of releasing ownership.
 359
 360 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 361
 362         * dwarf2read.c (open_and_init_dwp_file): Call
 363         elf_numsections instead of bfd_count_sections to initialize
 364         dwp_file->num_sections.
 365
 366 2019-02-25  Tom Tromey  <tromey@adacore.com>
 367
 368         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 369
 370 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 371
 372         * gcore.in: Add '--readnever' option when invoking GDB.
 373
 374 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 375
 376         * MAINTAINERS: Update my email address.
 377
 378 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 379
 380         * build-id.c (build_id_to_debug_bfd_1): New function.
 381         (build_id_to_debug_bfd): Look for separate debug file in
 382         sysroot.
 383
 384 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * gdbarch.sh: Update the copyright year range that is placed into
 387         generated files.
 388
 389 2019-02-22  Keith Seitz  <keiths@redhat.com>
 390
 391         PR symtab/23853
 392         * linespec.c (create_sals_line_offset): Search for the default
 393         symtab's filename instead of its fullname.
 394
 395 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 396
 397         * NEWS: Update style defaults.
 398
 399 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 400
 401         * main.c (captured_main_1): Disable styling in batch mode.
 402
 403 2019-02-20  Tom Tromey  <tom@tromey.com>
 404
 405         * symtab.c (symtab_symbol_info): Fix typos.
 406
 407 2019-02-20  Tom Tromey  <tromey@adacore.com>
 408
 409         * findcmd.c (_initialize_mem_search): Use upper case for
 410         metasyntactic variables.
 411
 412 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 413
 414         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 415         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 416
 417 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 418
 419         * top.h (source_file_name): Change to std::string.
 420         * top.c (source_file_name): Likewise.
 421         (command_line_input): Adjust.
 422         * cli/cli-script.c (script_from_file): Adjust.
 423
 424 2019-02-19  Tom Tromey  <tromey@adacore.com>
 425
 426         * ravenscar-thread.c
 427         (ravenscar_thread_target::update_thread_list): Don't call
 428         ada_build_task_list.
 429         * ada-lang.h (ada_build_task_list): Don't declare.
 430         * ada-tasks.c (struct ada_tasks_inferior_data)
 431         <task_list_valid_p>: Now bool.
 432         (read_known_tasks, ada_task_list_changed)
 433         (ada_tasks_invalidate_inferior_data): Update.
 434         (read_known_tasks_array): Return bool.
 435         (read_known_tasks_list): Likewise.
 436         (read_known_tasks): Return void.
 437         (ada_build_task_list): Now static.
 438
 439 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 442         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 443
 444 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 445
 446         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 447         variant for ada_tasks_pspace_data_handle and
 448         ada_tasks_inferior_data_handle.
 449         (ada_tasks_pspace_data_cleanup): New function.
 450         (ada_tasks_inferior_data_cleanup): New function.
 451
 452 2019-02-17  Tom Tromey  <tom@tromey.com>
 453
 454         * macrotab.h (macro_source_fullname): Return a std::string.
 455         * macrotab.c (macro_include, check_for_redefinition)
 456         (macro_undef, macro_lookup_definition, foreach_macro)
 457         (foreach_macro_in_scope): Update.
 458         (macro_source_fullname): Return a std::string.
 459         * macrocmd.c (show_pp_source_pos): Update.
 460
 461 2019-02-17  Tom Tromey  <tom@tromey.com>
 462
 463         * macrocmd.c (show_pp_source_pos): Style the file names.
 464
 465 2019-02-17  Tom Tromey  <tom@tromey.com>
 466
 467         PR tui/24197:
 468         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 469
 470 2019-02-17  Tom Tromey  <tom@tromey.com>
 471
 472         * ada-lang.c (user_select_syms): Use filtered printing.
 473         * utils.c (wrap_style): New global.
 474         (desired_style): Remove.
 475         (emit_style_escape): Add stream parameter.
 476         (set_output_style, reset_terminal_style, prompt_for_continue):
 477         Update.
 478         (flush_wrap_buffer): Only flush gdb_stdout.
 479         (wrap_here): Set wrap_style.
 480         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 481         treat escape sequences as a character.  Change when wrap buffer is
 482         flushed.
 483         (fputs_styled): Do not set the output style when the default is
 484         requested.
 485         * ui-style.h (struct ui_file_style) <is_default>: New method.
 486         * source.c (print_source_lines_base): Emit escape sequences in one
 487         piece.
 488
 489 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 490
 491         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 492         integers and enumeration types.
 493
 494 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 495
 496         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 497         instead of lookup_symbol_in_language
 498         (do_exact_match): New function.
 499         (ada_get_symbol_name_matcher): Return do_exact_match when
 500         doing a verbatim match.
 501
 502 2019-02-15  Tom Tromey  <tromey@adacore.com>
 503
 504         * ravenscar-thread.c (ravenscar_thread_target::resume)
 505         (ravenscar_thread_target::wait): Special case wildcard requests.
 506
 507 2019-02-15  Tom Tromey  <tromey@adacore.com>
 508
 509         * ravenscar-thread.c (base_ptid): Remove.
 510         (struct ravenscar_thread_target) <close>: New method.
 511         <m_base_ptid>: New member.
 512         <update_inferior_ptid, active_task, task_is_currently_active,
 513         runtime_initialized>: Declare methods.
 514         <ravenscar_thread_target>: Add constructor.
 515         (ravenscar_thread_target::task_is_currently_active)
 516         (ravenscar_thread_target::update_inferior_ptid)
 517         (ravenscar_runtime_initialized): Rename.  Now methods.
 518         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 519         (ravenscar_thread_target::update_thread_list): Update.
 520         (ravenscar_thread_target::active_task): Now method.
 521         (ravenscar_thread_target::store_registers)
 522         (ravenscar_thread_target::prepare_to_store)
 523         (ravenscar_thread_target::prepare_to_store)
 524         (ravenscar_thread_target::mourn_inferior): Update.
 525         (ravenscar_inferior_created): Use "new" to create target.
 526         (ravenscar_thread_target::get_ada_task_ptid): Update.
 527         (_initialize_ravenscar): Don't initialize base_ptid.
 528         (ravenscar_ops): Remove global.
 529
 530 2019-02-15  Tom Tromey  <tromey@adacore.com>
 531
 532         * target.h (push_target): Declare new overload.
 533         * target.c (push_target): New overload, taking an rvalue reference.
 534         * remote.c (remote_target::open_1): Use push_target overload.
 535         * corelow.c (core_target_open): Use push_target overload.
 536
 537 2019-02-15  Tom Tromey  <tromey@adacore.com>
 538
 539         * ravenscar-thread.c (is_ravenscar_task)
 540         (ravenscar_task_is_currently_active): Return bool.
 541         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 542         (_initialize_ravenscar): Remove "(void)".
 543         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 544         Return bool.
 545
 546 2019-02-15  Tom Tromey  <tromey@adacore.com>
 547
 548         * ravenscar-thread.c (ravenscar_runtime_initializer)
 549         (has_ravenscar_runtime, get_running_thread_id)
 550         (ravenscar_thread_target::resume): Fix indentation.
 551
 552 2019-02-15  Tom Tromey  <tromey@adacore.com>
 553
 554         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 555         from ravenscar_arch_ops.
 556         (sparc_ravenscar_ops::fetch_registers)
 557         (sparc_ravenscar_ops::store_registers): Now methods.
 558         (sparc_ravenscar_prepare_to_store): Remove.
 559         (sparc_ravenscar_ops): Redefine.
 560         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 561         methods and destructor.  Remove members.
 562         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 563         (ravenscar_thread_target::store_registers)
 564         (ravenscar_thread_target::prepare_to_store): Update.
 565         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 566         Remove.
 567         (struct ppc_ravenscar_powerpc_ops): Derive from
 568         ravenscar_arch_ops.
 569         (ppc_ravenscar_powerpc_ops::fetch_registers)
 570         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 571         (ppc_ravenscar_powerpc_ops): Redefine.
 572         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 573         (ppc_ravenscar_e500_ops::fetch_registers)
 574         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 575         (ppc_ravenscar_e500_ops): Redefine.
 576         * aarch64-ravenscar-thread.c
 577         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 578         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 579         (aarch64_ravenscar_fetch_registers)
 580         (aarch64_ravenscar_store_registers): Now methods.
 581         (aarch64_ravenscar_ops): Redefine.
 582
 583 2019-02-15  Tom Tromey  <tromey@adacore.com>
 584
 585         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 586         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 587         (ravenscar_thread_target::stopped_by_watchpoint)
 588         (ravenscar_thread_target::stopped_data_address)
 589         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 590
 591 2019-02-15  Tom Tromey  <tromey@adacore.com>
 592
 593         * ravenscar-thread.c: Fix some typos.
 594
 595 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 596             Tom Tromey  <tromey@adacore.com>
 597
 598         * ada-lang.c (ada_exception_sal): Change addr_string to a
 599         std::string.
 600         (create_ada_exception_catchpoint): Update.
 601
 602 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 603             Tom Tromey  <tromey@adacore.com>
 604
 605         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 606         (bp_location_ops): Remove.
 607         (base_breakpoint_allocate_location): Update.
 608         (free_bp_location): Update.
 609         * ada-lang.c (class ada_catchpoint_location)
 610         <ada_catchpoint_location>: Remove ops parameter.
 611         (ada_catchpoint_location_dtor): Remove.
 612         (ada_catchpoint_location_ops): Remove.
 613         (allocate_location_exception): Update.
 614         * breakpoint.h (struct bp_location_ops): Remove.
 615         (class bp_location) <bp_location>: Remove bp_location_ops
 616         parameter.
 617         <~bp_location>: Add destructor.
 618         <ops>: Remove.
 619
 620 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 621             Pedro Alves  <palves@redhat.com>
 622
 623         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 624         'PATH_MAX'.
 625
 626 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 627             Samuel Thibault  <samuel.thibault@gnu.org>
 628             Thomas Schwinge  <thomas@codesourcery.com>
 629
 630         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 631         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 632
 633 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 634
 635         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 636         (check_empty): Use "const char *".
 637
 638         * gnu-nat.c (gnu_nat_target::detach): Instead of
 639         'detach_inferior (pid)' call
 640         'detach_inferior (find_inferior_pid (pid))'.
 641
 642         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 643         'nat/fork-inferior.o'.
 644         * gnu-nat.c: #include "nat/fork-inferior.h".
 645
 646         * gnu-nat.c (gnu_nat_target::detach): Instead of
 647         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 648         * gnu-nat.h: #include "inf-child.h".
 649         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 650         'i386_gnu_nat_target::fetch_registers'.
 651         (gnu_store_registers): Rename/move to
 652         'i386_gnu_nat_target::store_registers'.
 653
 654         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 655         * gnu-nat.h (mach_thread_info): New function.
 656         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 657
 658         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 659
 660 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 661
 662         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 663
 664 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 665
 666         * windows-nat.c (windows_add_thread): Add new parameter
 667         "main_thread_p" with default value set to false.  Update
 668         function documentation as well as all callers.
 669         (windows_delete_thread): Likewise.
 670         (fake_create_process): Update call to windows_add_thread.
 671         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 672         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 673         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 674         call to windows_delete_thread.
 675
 676 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 677
 678         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 679
 680 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 681
 682         * symfile.c (find_separate_debug_file): Use canonical path of
 683         sysroot with child_path instead of gdb_sysroot if it is valid.
 684
 685 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 686
 687         * symfile.c (find_separate_debug_file): Use child_path to
 688         determine if an object file is under a sysroot.
 689
 690 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 691
 692         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 693         unittests/child-path-selftests.c.
 694         * common/pathstuff.c (child_path): New function.
 695         * common/pathstuff.h (child_path): New prototype.
 696         * unittests/child-path-selftests.c: New file.
 697
 698 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 699
 700         * symfile.c (find_separate_debug_file): Look for separate debug
 701         files in debug directories under the sysroot.
 702
 703 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 704
 705         * symtab.h (struct minimal_symbol data_p): New const method.
 706         (struct minimal_symbol text_p): Likewise.
 707         * symtab.c (output_source_filename): Use file name style
 708         to print file name.
 709         (print_symbol_info): Likewise.
 710         (print_msymbol_info): Use address style to print addresses.
 711         Use function name style to print executable text symbols.
 712         (expand_symtab_containing_pc): Use data_p.
 713         (find_pc_sect_compunit_symtab): Likewise.
 714
 715 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 716
 717         * breakpoint.c (describe_other_breakpoints): Use address style
 718         to print addresses.
 719         (say_where): Likewise.
 720
 721 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 722
 723         * ada-typeprint.c (print_func_type): Print function name
 724         style to print function name.
 725         * c-typeprint.c (c_print_type_1): Likewise.
 726
 727 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 728
 729         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 730         for execve.
 731
 732 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 733
 734         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 735         type_stack.
 736
 737 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 738
 739         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 740         TYPE_CODE_REF types.
 741
 742 2019-02-08  Jim Wilson  <jimw@sifive.com>
 743
 744         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 745         (riscv_linux_fregset): New.
 746         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 747
 748 2019-02-07  Tom Tromey  <tom@tromey.com>
 749
 750         * thread.c (thread_cancel_execution_command): Update.
 751         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 752         methods.
 753         (struct thread_fsm_ops): Remove.
 754         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 755         (thread_fsm_should_stop, thread_fsm_return_value)
 756         (thread_fsm_set_finished, thread_fsm_finished_p)
 757         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 758         Don't declare.
 759         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 760         * infrun.c (clear_proceed_status_thread)
 761         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 762         (print_stop_event): Update.
 763         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 764         Add constructor.
 765         (step_command_fsm_ops): Remove.
 766         (new_step_command_fsm): Remove.
 767         (step_1): Update.
 768         (step_command_fsm::should_stop): Rename from
 769         step_command_fsm_should_stop.
 770         (step_command_fsm::clean_up): Rename from
 771         step_command_fsm_clean_up.
 772         (step_command_fsm::do_async_reply_reason): Rename from
 773         step_command_fsm_async_reply_reason.
 774         (struct until_next_fsm): Inherit from thread_fsm.  Add
 775         constructor.
 776         (until_next_fsm_ops): Remove.
 777         (new_until_next_fsm): Remove.
 778         (until_next_fsm::should_stop): Rename from
 779         until_next_fsm_should_stop.
 780         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 781         (until_next_fsm::do_async_reply_reason): Rename from
 782         until_next_fsm_async_reply_reason.
 783         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 784         constructor.  Change type of breakpoint.
 785         (finish_command_fsm_ops): Remove.
 786         (new_finish_command_fsm): Remove.
 787         (finish_command_fsm::should_stop): Rename from
 788         finish_command_fsm_should_stop.
 789         (finish_command_fsm::clean_up): Rename from
 790         finish_command_fsm_clean_up.
 791         (finish_command_fsm::return_value): Rename from
 792         finish_command_fsm_return_value.
 793         (finish_command_fsm::do_async_reply_reason): Rename from
 794         finish_command_fsm_async_reply_reason.
 795         (finish_command): Update.
 796         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 797         Add constructor.
 798         (call_thread_fsm_ops): Remove.
 799         (call_thread_fsm::call_thread_fsm): Rename from
 800         new_call_thread_fsm.
 801         (call_thread_fsm::should_stop): Rename from
 802         call_thread_fsm_should_stop.
 803         (call_thread_fsm::should_notify_stop): Rename from
 804         call_thread_fsm_should_notify_stop.
 805         (run_inferior_call, call_function_by_hand_dummy): Update.
 806         * cli/cli-interp.c (should_print_stop_to_console): Update.
 807         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 808         Add constructor.  Change type of location_breakpoint,
 809         caller_breakpoint.
 810         (until_break_fsm_ops): Remove.
 811         (new_until_break_fsm): Remove.
 812         (until_break_fsm::should_stop): Rename from
 813         until_break_fsm_should_stop.
 814         (until_break_fsm::clean_up): Rename from
 815         until_break_fsm_clean_up.
 816         (until_break_fsm::do_async_reply_reason): Rename from
 817         until_break_fsm_async_reply_reason.
 818         (until_break_command): Update.
 819         * thread-fsm.c: Remove.
 820         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 821
 822 2019-02-07  Tom Tromey  <tom@tromey.com>
 823
 824         * yy-remap.h: Add include guard.
 825         * xtensa-tdep.h: Add include guard.
 826         * xcoffread.h: Rename include guard.
 827         * varobj-iter.h: Add include guard.
 828         * tui/tui.h: Rename include guard.
 829         * tui/tui-winsource.h: Rename include guard.
 830         * tui/tui-wingeneral.h: Rename include guard.
 831         * tui/tui-windata.h: Rename include guard.
 832         * tui/tui-win.h: Rename include guard.
 833         * tui/tui-stack.h: Rename include guard.
 834         * tui/tui-source.h: Rename include guard.
 835         * tui/tui-regs.h: Rename include guard.
 836         * tui/tui-out.h: Rename include guard.
 837         * tui/tui-layout.h: Rename include guard.
 838         * tui/tui-io.h: Rename include guard.
 839         * tui/tui-hooks.h: Rename include guard.
 840         * tui/tui-file.h: Rename include guard.
 841         * tui/tui-disasm.h: Rename include guard.
 842         * tui/tui-data.h: Rename include guard.
 843         * tui/tui-command.h: Rename include guard.
 844         * tic6x-tdep.h: Add include guard.
 845         * target/waitstatus.h: Rename include guard.
 846         * target/wait.h: Rename include guard.
 847         * target/target.h: Rename include guard.
 848         * target/resume.h: Rename include guard.
 849         * target-float.h: Rename include guard.
 850         * stabsread.h: Add include guard.
 851         * rs6000-tdep.h: Add include guard.
 852         * riscv-fbsd-tdep.h: Add include guard.
 853         * regformats/regdef.h: Rename include guard.
 854         * record.h: Rename include guard.
 855         * python/python.h: Rename include guard.
 856         * python/python-internal.h: Rename include guard.
 857         * python/py-stopevent.h: Rename include guard.
 858         * python/py-ref.h: Rename include guard.
 859         * python/py-record.h: Rename include guard.
 860         * python/py-record-full.h: Rename include guard.
 861         * python/py-record-btrace.h: Rename include guard.
 862         * python/py-instruction.h: Rename include guard.
 863         * python/py-events.h: Rename include guard.
 864         * python/py-event.h: Rename include guard.
 865         * procfs.h: Add include guard.
 866         * proc-utils.h: Add include guard.
 867         * p-lang.h: Add include guard.
 868         * or1k-tdep.h: Rename include guard.
 869         * observable.h: Rename include guard.
 870         * nto-tdep.h: Rename include guard.
 871         * nat/x86-linux.h: Rename include guard.
 872         * nat/x86-linux-dregs.h: Rename include guard.
 873         * nat/x86-gcc-cpuid.h: Add include guard.
 874         * nat/x86-dregs.h: Rename include guard.
 875         * nat/x86-cpuid.h: Rename include guard.
 876         * nat/ppc-linux.h: Rename include guard.
 877         * nat/mips-linux-watch.h: Rename include guard.
 878         * nat/linux-waitpid.h: Rename include guard.
 879         * nat/linux-ptrace.h: Rename include guard.
 880         * nat/linux-procfs.h: Rename include guard.
 881         * nat/linux-osdata.h: Rename include guard.
 882         * nat/linux-nat.h: Rename include guard.
 883         * nat/linux-namespaces.h: Rename include guard.
 884         * nat/linux-btrace.h: Rename include guard.
 885         * nat/glibc_thread_db.h: Rename include guard.
 886         * nat/gdb_thread_db.h: Rename include guard.
 887         * nat/gdb_ptrace.h: Rename include guard.
 888         * nat/fork-inferior.h: Rename include guard.
 889         * nat/amd64-linux-siginfo.h: Rename include guard.
 890         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 891         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 892         * nat/aarch64-linux.h: Rename include guard.
 893         * nat/aarch64-linux-hw-point.h: Rename include guard.
 894         * mn10300-tdep.h: Add include guard.
 895         * mips-linux-tdep.h: Add include guard.
 896         * mi/mi-parse.h: Rename include guard.
 897         * mi/mi-out.h: Rename include guard.
 898         * mi/mi-main.h: Rename include guard.
 899         * mi/mi-interp.h: Rename include guard.
 900         * mi/mi-getopt.h: Rename include guard.
 901         * mi/mi-console.h: Rename include guard.
 902         * mi/mi-common.h: Rename include guard.
 903         * mi/mi-cmds.h: Rename include guard.
 904         * mi/mi-cmd-break.h: Rename include guard.
 905         * m2-lang.h: Add include guard.
 906         * location.h: Rename include guard.
 907         * linux-record.h: Rename include guard.
 908         * linux-nat.h: Add include guard.
 909         * linux-fork.h: Add include guard.
 910         * i386-darwin-tdep.h: Rename include guard.
 911         * hppa-linux-offsets.h: Add include guard.
 912         * guile/guile.h: Rename include guard.
 913         * guile/guile-internal.h: Rename include guard.
 914         * gnu-nat.h: Rename include guard.
 915         * gdb-stabs.h: Rename include guard.
 916         * frv-tdep.h: Add include guard.
 917         * f-lang.h: Add include guard.
 918         * event-loop.h: Add include guard.
 919         * darwin-nat.h: Rename include guard.
 920         * cp-abi.h: Rename include guard.
 921         * config/sparc/nm-sol2.h: Rename include guard.
 922         * config/nm-nto.h: Rename include guard.
 923         * config/nm-linux.h: Add include guard.
 924         * config/i386/nm-i386gnu.h: Rename include guard.
 925         * config/djgpp/nl_types.h: Rename include guard.
 926         * config/djgpp/langinfo.h: Rename include guard.
 927         * compile/gcc-cp-plugin.h: Add include guard.
 928         * compile/gcc-c-plugin.h: Add include guard.
 929         * compile/compile.h: Rename include guard.
 930         * compile/compile-object-run.h: Rename include guard.
 931         * compile/compile-object-load.h: Rename include guard.
 932         * compile/compile-internal.h: Rename include guard.
 933         * compile/compile-cplus.h: Rename include guard.
 934         * compile/compile-c.h: Rename include guard.
 935         * common/xml-utils.h: Rename include guard.
 936         * common/x86-xstate.h: Rename include guard.
 937         * common/version.h: Rename include guard.
 938         * common/vec.h: Rename include guard.
 939         * common/tdesc.h: Rename include guard.
 940         * common/selftest.h: Rename include guard.
 941         * common/scoped_restore.h: Rename include guard.
 942         * common/scoped_mmap.h: Rename include guard.
 943         * common/scoped_fd.h: Rename include guard.
 944         * common/safe-iterator.h: Rename include guard.
 945         * common/run-time-clock.h: Rename include guard.
 946         * common/refcounted-object.h: Rename include guard.
 947         * common/queue.h: Rename include guard.
 948         * common/ptid.h: Rename include guard.
 949         * common/print-utils.h: Rename include guard.
 950         * common/preprocessor.h: Rename include guard.
 951         * common/pathstuff.h: Rename include guard.
 952         * common/observable.h: Rename include guard.
 953         * common/netstuff.h: Rename include guard.
 954         * common/job-control.h: Rename include guard.
 955         * common/host-defs.h: Rename include guard.
 956         * common/gdb_wait.h: Rename include guard.
 957         * common/gdb_vecs.h: Rename include guard.
 958         * common/gdb_unlinker.h: Rename include guard.
 959         * common/gdb_unique_ptr.h: Rename include guard.
 960         * common/gdb_tilde_expand.h: Rename include guard.
 961         * common/gdb_sys_time.h: Rename include guard.
 962         * common/gdb_string_view.h: Rename include guard.
 963         * common/gdb_splay_tree.h: Rename include guard.
 964         * common/gdb_setjmp.h: Rename include guard.
 965         * common/gdb_ref_ptr.h: Rename include guard.
 966         * common/gdb_optional.h: Rename include guard.
 967         * common/gdb_locale.h: Rename include guard.
 968         * common/gdb_assert.h: Rename include guard.
 969         * common/filtered-iterator.h: Rename include guard.
 970         * common/filestuff.h: Rename include guard.
 971         * common/fileio.h: Rename include guard.
 972         * common/environ.h: Rename include guard.
 973         * common/common-utils.h: Rename include guard.
 974         * common/common-types.h: Rename include guard.
 975         * common/common-regcache.h: Rename include guard.
 976         * common/common-inferior.h: Rename include guard.
 977         * common/common-gdbthread.h: Rename include guard.
 978         * common/common-exceptions.h: Rename include guard.
 979         * common/common-defs.h: Rename include guard.
 980         * common/common-debug.h: Rename include guard.
 981         * common/cleanups.h: Rename include guard.
 982         * common/buffer.h: Rename include guard.
 983         * common/btrace-common.h: Rename include guard.
 984         * common/break-common.h: Rename include guard.
 985         * cli/cli-utils.h: Rename include guard.
 986         * cli/cli-style.h: Rename include guard.
 987         * cli/cli-setshow.h: Rename include guard.
 988         * cli/cli-script.h: Rename include guard.
 989         * cli/cli-interp.h: Rename include guard.
 990         * cli/cli-decode.h: Rename include guard.
 991         * cli/cli-cmds.h: Rename include guard.
 992         * charset-list.h: Add include guard.
 993         * buildsym-legacy.h: Rename include guard.
 994         * bfin-tdep.h: Add include guard.
 995         * ax.h: Rename include guard.
 996         * arm-linux-tdep.h: Add include guard.
 997         * arm-fbsd-tdep.h: Add include guard.
 998         * arch/xtensa.h: Rename include guard.
 999         * arch/tic6x.h: Add include guard.
1000         * arch/i386.h: Add include guard.
1001         * arch/arm.h: Rename include guard.
1002         * arch/arm-linux.h: Rename include guard.
1003         * arch/arm-get-next-pcs.h: Rename include guard.
1004         * arch/amd64.h: Add include guard.
1005         * arch/aarch64-insn.h: Rename include guard.
1006         * arch-utils.h: Rename include guard.
1007         * annotate.h: Add include guard.
1008         * amd64-darwin-tdep.h: Rename include guard.
1009         * aarch64-linux-tdep.h: Add include guard.
1010         * aarch64-fbsd-tdep.h: Add include guard.
1011         * aarch32-linux-nat.h: Add include guard.
1012
1013 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1014
1015         * macrotab.c (macro_define_internal): New function that
1016         factorizes macro_define_object_internal and macro_define_function
1017         code.
1018         (macro_define_object_internal): Use macro_define_internal.
1019         (macro_define_function): Likewise.
1020
1021 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1022
1023         * macrocmd.c (extract_identifier): Return
1024         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1025         callers.
1026
1027 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1028
1029         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1030
1031 2019-02-05  Tom Tromey  <tom@tromey.com>
1032
1033         * target.c (target_stack::unpush): Move assertion earlier.
1034
1035 2019-01-30  Tom Tromey  <tom@tromey.com>
1036
1037         PR python/23615:
1038         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1039         (gdbpy_parse_and_eval): Likewise.
1040         * python/python-internal.h (gdbpy_allow_threads): New class.
1041
1042 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1043
1044         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1045         (aarch64_fbsd_fpregmap): Move earlier.
1046         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1047         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1048         instead of individual calls to trad_frame_set_reg_addr.
1049         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1050         earlier.
1051         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1052         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1053         instead of individual calls to trad_frame_set_reg_addr.
1054
1055 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1056
1057         * CONTRIBUTE: Replace contribution list with wiki link.
1058
1059 2019-01-25  Tom Tromey  <tom@tromey.com>
1060
1061         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1062
1063 2019-01-25  Tom Tromey  <tom@tromey.com>
1064
1065         * xtensa-linux-nat.c: Fix common/ includes.
1066         * xml-support.h: Fix common/ includes.
1067         * xml-support.c: Fix common/ includes.
1068         * x86-linux-nat.c: Fix common/ includes.
1069         * windows-nat.c: Fix common/ includes.
1070         * varobj.h: Fix common/ includes.
1071         * varobj.c: Fix common/ includes.
1072         * value.c: Fix common/ includes.
1073         * valops.c: Fix common/ includes.
1074         * utils.c: Fix common/ includes.
1075         * unittests/xml-utils-selftests.c: Fix common/ includes.
1076         * unittests/utils-selftests.c: Fix common/ includes.
1077         * unittests/unpack-selftests.c: Fix common/ includes.
1078         * unittests/tracepoint-selftests.c: Fix common/ includes.
1079         * unittests/style-selftests.c: Fix common/ includes.
1080         * unittests/string_view-selftests.c: Fix common/ includes.
1081         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1082         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1083         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1084         * unittests/rsp-low-selftests.c: Fix common/ includes.
1085         * unittests/parse-connection-spec-selftests.c: Fix common/
1086         includes.
1087         * unittests/optional-selftests.c: Fix common/ includes.
1088         * unittests/offset-type-selftests.c: Fix common/ includes.
1089         * unittests/observable-selftests.c: Fix common/ includes.
1090         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1091         * unittests/memrange-selftests.c: Fix common/ includes.
1092         * unittests/memory-map-selftests.c: Fix common/ includes.
1093         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1094         * unittests/function-view-selftests.c: Fix common/ includes.
1095         * unittests/environ-selftests.c: Fix common/ includes.
1096         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1097         * unittests/common-utils-selftests.c: Fix common/ includes.
1098         * unittests/cli-utils-selftests.c: Fix common/ includes.
1099         * unittests/array-view-selftests.c: Fix common/ includes.
1100         * ui-file.c: Fix common/ includes.
1101         * tui/tui-io.c: Fix common/ includes.
1102         * tracepoint.h: Fix common/ includes.
1103         * tracepoint.c: Fix common/ includes.
1104         * tracefile-tfile.c: Fix common/ includes.
1105         * top.h: Fix common/ includes.
1106         * top.c: Fix common/ includes.
1107         * thread.c: Fix common/ includes.
1108         * target/waitstatus.h: Fix common/ includes.
1109         * target/waitstatus.c: Fix common/ includes.
1110         * target.h: Fix common/ includes.
1111         * target.c: Fix common/ includes.
1112         * target-memory.c: Fix common/ includes.
1113         * target-descriptions.c: Fix common/ includes.
1114         * symtab.h: Fix common/ includes.
1115         * symfile.c: Fix common/ includes.
1116         * stap-probe.c: Fix common/ includes.
1117         * spu-linux-nat.c: Fix common/ includes.
1118         * sparc-nat.c: Fix common/ includes.
1119         * source.c: Fix common/ includes.
1120         * solib.c: Fix common/ includes.
1121         * solib-target.c: Fix common/ includes.
1122         * ser-unix.c: Fix common/ includes.
1123         * ser-tcp.c: Fix common/ includes.
1124         * ser-pipe.c: Fix common/ includes.
1125         * ser-base.c: Fix common/ includes.
1126         * selftest-arch.c: Fix common/ includes.
1127         * s12z-tdep.c: Fix common/ includes.
1128         * rust-exp.y: Fix common/ includes.
1129         * rs6000-aix-tdep.c: Fix common/ includes.
1130         * riscv-tdep.c: Fix common/ includes.
1131         * remote.c: Fix common/ includes.
1132         * remote-notif.h: Fix common/ includes.
1133         * remote-fileio.h: Fix common/ includes.
1134         * remote-fileio.c: Fix common/ includes.
1135         * regcache.h: Fix common/ includes.
1136         * regcache.c: Fix common/ includes.
1137         * record-btrace.c: Fix common/ includes.
1138         * python/python.c: Fix common/ includes.
1139         * python/py-type.c: Fix common/ includes.
1140         * python/py-inferior.c: Fix common/ includes.
1141         * progspace.h: Fix common/ includes.
1142         * producer.c: Fix common/ includes.
1143         * procfs.c: Fix common/ includes.
1144         * proc-api.c: Fix common/ includes.
1145         * printcmd.c: Fix common/ includes.
1146         * ppc-linux-nat.c: Fix common/ includes.
1147         * parser-defs.h: Fix common/ includes.
1148         * osdata.c: Fix common/ includes.
1149         * obsd-nat.c: Fix common/ includes.
1150         * nat/x86-linux.c: Fix common/ includes.
1151         * nat/x86-linux-dregs.c: Fix common/ includes.
1152         * nat/x86-dregs.h: Fix common/ includes.
1153         * nat/x86-dregs.c: Fix common/ includes.
1154         * nat/ppc-linux.c: Fix common/ includes.
1155         * nat/mips-linux-watch.h: Fix common/ includes.
1156         * nat/mips-linux-watch.c: Fix common/ includes.
1157         * nat/linux-waitpid.c: Fix common/ includes.
1158         * nat/linux-ptrace.h: Fix common/ includes.
1159         * nat/linux-ptrace.c: Fix common/ includes.
1160         * nat/linux-procfs.c: Fix common/ includes.
1161         * nat/linux-personality.c: Fix common/ includes.
1162         * nat/linux-osdata.c: Fix common/ includes.
1163         * nat/linux-namespaces.c: Fix common/ includes.
1164         * nat/linux-btrace.h: Fix common/ includes.
1165         * nat/linux-btrace.c: Fix common/ includes.
1166         * nat/fork-inferior.c: Fix common/ includes.
1167         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1168         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1169         * nat/aarch64-linux.c: Fix common/ includes.
1170         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1171         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1172         * namespace.h: Fix common/ includes.
1173         * mips-linux-tdep.c: Fix common/ includes.
1174         * minsyms.c: Fix common/ includes.
1175         * mi/mi-parse.h: Fix common/ includes.
1176         * mi/mi-main.c: Fix common/ includes.
1177         * mi/mi-cmd-env.c: Fix common/ includes.
1178         * memrange.h: Fix common/ includes.
1179         * memattr.c: Fix common/ includes.
1180         * maint.h: Fix common/ includes.
1181         * maint.c: Fix common/ includes.
1182         * main.c: Fix common/ includes.
1183         * machoread.c: Fix common/ includes.
1184         * location.c: Fix common/ includes.
1185         * linux-thread-db.c: Fix common/ includes.
1186         * linux-nat.c: Fix common/ includes.
1187         * linux-fork.c: Fix common/ includes.
1188         * inline-frame.c: Fix common/ includes.
1189         * infrun.c: Fix common/ includes.
1190         * inflow.c: Fix common/ includes.
1191         * inferior.h: Fix common/ includes.
1192         * inferior.c: Fix common/ includes.
1193         * infcmd.c: Fix common/ includes.
1194         * inf-ptrace.c: Fix common/ includes.
1195         * inf-child.c: Fix common/ includes.
1196         * ia64-linux-nat.c: Fix common/ includes.
1197         * i387-tdep.c: Fix common/ includes.
1198         * i386-tdep.c: Fix common/ includes.
1199         * i386-linux-tdep.c: Fix common/ includes.
1200         * i386-linux-nat.c: Fix common/ includes.
1201         * i386-go32-tdep.c: Fix common/ includes.
1202         * i386-fbsd-tdep.c: Fix common/ includes.
1203         * i386-fbsd-nat.c: Fix common/ includes.
1204         * guile/scm-type.c: Fix common/ includes.
1205         * guile/guile.c: Fix common/ includes.
1206         * go32-nat.c: Fix common/ includes.
1207         * gnu-nat.c: Fix common/ includes.
1208         * gdbthread.h: Fix common/ includes.
1209         * gdbarch-selftests.c: Fix common/ includes.
1210         * gdb_usleep.c: Fix common/ includes.
1211         * gdb_select.h: Fix common/ includes.
1212         * gdb_bfd.c: Fix common/ includes.
1213         * gcore.c: Fix common/ includes.
1214         * fork-child.c: Fix common/ includes.
1215         * findvar.c: Fix common/ includes.
1216         * fbsd-nat.c: Fix common/ includes.
1217         * event-top.c: Fix common/ includes.
1218         * event-loop.c: Fix common/ includes.
1219         * dwarf2read.c: Fix common/ includes.
1220         * dwarf2loc.c: Fix common/ includes.
1221         * dwarf2-frame.c: Fix common/ includes.
1222         * dwarf-index-cache.c: Fix common/ includes.
1223         * dtrace-probe.c: Fix common/ includes.
1224         * disasm-selftests.c: Fix common/ includes.
1225         * defs.h: Fix common/ includes.
1226         * csky-tdep.c: Fix common/ includes.
1227         * cp-valprint.c: Fix common/ includes.
1228         * cp-support.h: Fix common/ includes.
1229         * cp-support.c: Fix common/ includes.
1230         * corelow.c: Fix common/ includes.
1231         * completer.h: Fix common/ includes.
1232         * completer.c: Fix common/ includes.
1233         * compile/compile.c: Fix common/ includes.
1234         * compile/compile-loc2c.c: Fix common/ includes.
1235         * compile/compile-cplus-types.c: Fix common/ includes.
1236         * compile/compile-cplus-symbols.c: Fix common/ includes.
1237         * command.h: Fix common/ includes.
1238         * cli/cli-dump.c: Fix common/ includes.
1239         * cli/cli-cmds.c: Fix common/ includes.
1240         * charset.c: Fix common/ includes.
1241         * build-id.c: Fix common/ includes.
1242         * btrace.h: Fix common/ includes.
1243         * btrace.c: Fix common/ includes.
1244         * breakpoint.h: Fix common/ includes.
1245         * breakpoint.c: Fix common/ includes.
1246         * ax.h:
1247         (enum agent_op): Fix common/ includes.
1248         * ax-general.c (struct aop_map): Fix common/ includes.
1249         * ax-gdb.c: Fix common/ includes.
1250         * auxv.c: Fix common/ includes.
1251         * auto-load.c: Fix common/ includes.
1252         * arm-tdep.c: Fix common/ includes.
1253         * arch/riscv.c: Fix common/ includes.
1254         * arch/ppc-linux-common.c: Fix common/ includes.
1255         * arch/i386.c: Fix common/ includes.
1256         * arch/arm.c: Fix common/ includes.
1257         * arch/arm-linux.c: Fix common/ includes.
1258         * arch/arm-get-next-pcs.c: Fix common/ includes.
1259         * arch/amd64.c: Fix common/ includes.
1260         * arch/aarch64.c: Fix common/ includes.
1261         * arch/aarch64-insn.c: Fix common/ includes.
1262         * arch-utils.c: Fix common/ includes.
1263         * amd64-windows-tdep.c: Fix common/ includes.
1264         * amd64-tdep.c: Fix common/ includes.
1265         * amd64-sol2-tdep.c: Fix common/ includes.
1266         * amd64-obsd-tdep.c: Fix common/ includes.
1267         * amd64-nbsd-tdep.c: Fix common/ includes.
1268         * amd64-linux-tdep.c: Fix common/ includes.
1269         * amd64-linux-nat.c: Fix common/ includes.
1270         * amd64-fbsd-tdep.c: Fix common/ includes.
1271         * amd64-fbsd-nat.c: Fix common/ includes.
1272         * amd64-dicos-tdep.c: Fix common/ includes.
1273         * amd64-darwin-tdep.c: Fix common/ includes.
1274         * agent.c: Fix common/ includes.
1275         * ada-lang.h: Fix common/ includes.
1276         * ada-lang.c: Fix common/ includes.
1277         * aarch64-tdep.c: Fix common/ includes.
1278
1279 2019-01-25  Tom Tromey  <tom@tromey.com>
1280
1281         * common/create-version.sh: Use common/version.h.
1282
1283 2019-01-24  Pedro Alves  <palves@redhat.com>
1284
1285         * infrun.c (signal_stop, signal_print, signal_program)
1286         (signal_catch, signal_pass): Now arrays instead of pointers.
1287         (update_signals_program_target, do_target_resume)
1288         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1289         * linux-nat.c (linux_nat_target::pass_signals)
1290         (linux_nat_target::create_inferior, linux_nat_target::attach):
1291         Adjust.
1292         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1293         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1294         * procfs.c (procfs_target::pass_signals): Adjust.
1295         * record-full.c (record_full_target::resume): Adjust.
1296         * remote.c (remote_target::pass_signals)
1297         (remote_target::program_signals): Adjust.
1298         * target-debug.h (target_debug_print_signals): Now takes a
1299         gdb::array_view as parameter.  Adjust.
1300         * target.h (target_ops) <pass_signals, program_signals>: Replace
1301         pointer and length parameters with gdb::array_view.
1302         (target_pass_signals, target_program_signals): Likewise.
1303         * target-delegates.c: Regenerate.
1304
1305 2019-01-24  Pedro Alves  <palves@redhat.com>
1306
1307         * common/forward-scope-exit.h
1308         (forward_scope_exit::forward_scope_exit): Pass arguments to
1309         m_bind_function directly, instead of creating a std::bind and
1310         copying that.
1311
1312 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1313
1314         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1315         for static members.
1316         (pass_in_v_vfp_candidate): Likewise.
1317
1318 2019-01-23  Tom Tromey  <tom@tromey.com>
1319             Pedro Alves  <palves@redhat.com>
1320
1321         * regcache.c (class regcache_invalidator): Remove.
1322         (regcache::raw_write): Use make_scope_exit.
1323
1324 2019-01-23  Tom Tromey  <tom@tromey.com>
1325
1326         * ui-out.h (class ui_out_emit_type): Update comment.
1327
1328 2019-01-23  Tom Tromey  <tom@tromey.com>
1329
1330         * infrun.c (fetch_inferior_event): Update comment.
1331
1332 2019-01-23  Tom Tromey  <tom@tromey.com>
1333             Pedro Alves  <palves@redhat.com>
1334
1335         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1336         parameter.
1337         (fetch_inferior_event): Use SCOPE_EXIT.
1338
1339
1340 2019-01-23  Tom Tromey  <tom@tromey.com>
1341             Pedro Alves  <palves@redhat.com>
1342
1343         * infrun.c (disable_thread_events): Delete.
1344         (stop_all_threads): Use SCOPE_EXIT.
1345
1346 2019-01-23  Tom Tromey  <tom@tromey.com>
1347             Pedro Alves  <palves@redhat.com>
1348
1349         * symfile.c: Include forward-scope-exit.h.
1350         (clear_symtab_users_cleanup): Replace forward declaration with
1351         a FORWARD_SCOPE_EXIT.
1352         (syms_from_objfile_1): Use the forward_scope_exit and
1353         gdb::optional instead of cleanup_function.
1354         (reread_symbols): Use the forward_scope_exit instead of
1355         cleanup_function.
1356         (clear_symtab_users_cleanup): Remove function.
1357
1358 2019-01-23  Tom Tromey  <tom@tromey.com>
1359             Pedro Alves  <palves@redhat.com>
1360
1361         * linux-nat.c: Include scope-exit.h.
1362         (cleanup_target_stop): Remove.
1363         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1364         SCOPE_EXIT.
1365
1366 2019-01-23  Tom Tromey  <tom@tromey.com>
1367             Pedro Alves  <palves@redhat.com>
1368
1369         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1370         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1371
1372 2019-01-23  Tom Tromey  <tom@tromey.com>
1373             Andrew Burgess  <andrew.burgess@embecosm.com>
1374             Pedro Alves  <palves@redhat.com>
1375
1376         * infrun.c (fetch_inferior_event): Use scope_exit.
1377         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1378         * top.c (execute_command): Use scope_exit.
1379         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1380         * utils.c (do_bpstat_clear_actions_cleanup)
1381         (make_bpstat_clear_actions_cleanup): Remove.
1382
1383 2019-01-23  Tom Tromey  <tom@tromey.com>
1384             Pedro Alves  <palves@redhat.com>
1385
1386         * infrun.c: Include "common/scope-exit.h"
1387         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1388         (wait_for_inferior): Use SCOPE_EXIT.
1389         (fetch_inferior_event): Use scope_exit.
1390
1391 2019-01-23  Tom Tromey  <tom@tromey.com>
1392             Pedro Alves  <palves@redhat.com>
1393
1394         * breakpoint.c (create_breakpoint): Remove cleanup.
1395
1396 2019-01-23  Tom Tromey  <tom@tromey.com>
1397             Andrew Burgess  <andrew.burgess@embecosm.com>
1398             Pedro Alves  <palves@redhat.com>
1399
1400 2019-01-23  Pedro Alves  <palves@redhat.com>
1401
1402         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1403
1404 2019-01-23  Pedro Alves  <palves@redhat.com>
1405             Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * gdbthread.h: Include "common/forward-scope-exit.h".
1408         (scoped_finish_thread_state): Redefine custom class in terms of
1409         forward_scope_exit.
1410
1411 2019-01-23  Pedro Alves  <palves@redhat.com>
1412             Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * common/forward-scope-exit.h: New file.
1415
1416 2019-01-23  Pedro Alves  <palves@redhat.com>
1417             Andrew Burgess  <andrew.burgess@embecosm.com>
1418             Tom Tromey  <tom@tromey.com>
1419
1420         * common/scope-exit.h: New file.
1421
1422 2019-01-23  Pedro Alves  <palves@redhat.com>
1423
1424         * common/preprocessor.h (ESC): Rename to ...
1425         (ESC_PARENS): ... this.
1426         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1427         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1428
1429 2019-01-23  Tom Tromey  <tom@tromey.com>
1430
1431         * language.h (class scoped_switch_to_sym_language_if_auto):
1432         Initialize m_lang in both cases.
1433
1434 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1435
1436         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1437         with XCNEW.
1438
1439 2019-01-22  Tom Tromey  <tom@tromey.com>
1440
1441         * corelow.c: Do not include sys/file.h.
1442
1443 2019-01-22  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-wingeneral.h: Include gdb_curses.h.
1446
1447 2019-01-22  Tom Tromey  <tom@tromey.com>
1448
1449         * source-cache.h (class source_cache) <get_source_lines,
1450         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1451
1452 2019-01-22  Tom Tromey  <tom@tromey.com>
1453
1454         * remote-fileio.h (struct remote_target): Declare.
1455
1456 2019-01-22  Tom Tromey  <tom@tromey.com>
1457
1458         * python/py-arch.c: Do not include py-ref.h.
1459         * python/py-bpevent.c: Do not include py-ref.h.
1460         * python/py-cmd.c: Do not include py-ref.h.
1461         * python/py-continueevent.c: Do not include py-ref.h.
1462         * python/py-event.h: Do not include py-ref.h.
1463         * python/py-evtregistry.c: Do not include py-ref.h.
1464         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1465         * python/py-frame.c: Do not include py-ref.h.
1466         * python/py-framefilter.c: Do not include py-ref.h.
1467         * python/py-function.c: Do not include py-ref.h.
1468         * python/py-infevents.c: Do not include py-ref.h.
1469         * python/py-linetable.c: Do not include py-ref.h.
1470         * python/py-objfile.c: Do not include py-ref.h.
1471         * python/py-param.c: Do not include py-ref.h.
1472         * python/py-prettyprint.c: Do not include py-ref.h.
1473         * python/py-progspace.c: Do not include py-ref.h.
1474         * python/py-symbol.c: Do not include py-ref.h.
1475         * python/py-symtab.c: Do not include py-ref.h.
1476         * python/py-type.c: Do not include py-ref.h.
1477         * python/py-unwind.c: Do not include py-ref.h.
1478         * python/py-utils.c: Do not include py-ref.h.
1479         * python/py-value.c: Do not include py-ref.h.
1480         * python/py-varobj.c: Do not include py-ref.h.
1481         * python/py-xmethods.c: Do not include py-ref.h.
1482         * python/python.c: Do not include py-ref.h.
1483         * varobj.c: Do not include py-ref.h.
1484
1485 2019-01-22  Tom Tromey  <tom@tromey.com>
1486
1487         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1488         keyword for bcache.
1489
1490 2019-01-22  Tom Tromey  <tom@tromey.com>
1491
1492         * compile/compile-cplus-types.c: Remove a comment by #include.
1493
1494 2019-01-22  Tom Tromey  <tom@tromey.com>
1495
1496         * compile/gcc-c-plugin.h: Include compile-internal.h.
1497
1498 2019-01-22  Tom Tromey  <tom@tromey.com>
1499
1500         * stabsread.c (EXTERN): Do not define.
1501         (symnum, next_symbol_text_func, processing_gcc_compilation)
1502         (within_function, global_sym_chain, global_stabs)
1503         (previous_stab_code, this_object_header_files)
1504         (n_this_object_header_files)
1505         (n_allocated_this_object_header_files): Define.
1506         * stabsread.h (EXTERN): Never define.  Use "extern".
1507
1508 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1509
1510         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1511         history_value.
1512
1513 2019-01-21  Tom Tromey  <tom@tromey.com>
1514
1515         * ui-out.c: Fix includes.
1516         * tui/tui-source.c: Fix includes.
1517         * target.c: Fix includes.
1518         * remote.c: Fix includes.
1519         * regcache.c: Fix includes.
1520         * python/py-block.c: Fix includes.
1521         * printcmd.c: Fix includes.
1522         * or1k-tdep.c: Fix includes.
1523         * mi/mi-main.c: Fix includes.
1524         * m32r-tdep.c: Fix includes.
1525         * csky-tdep.c: Fix includes.
1526         * compile/compile-cplus-types.c: Fix includes.
1527         * cli/cli-interp.c: Fix includes.
1528
1529 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1532         for padding.
1533
1534 2019-01-16  Tom Tromey  <tom@tromey.com>
1535
1536         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1537         earlier.
1538         (struct objfile) <msymbols_range>: Move from top level.
1539         <msymbols>: New method.
1540         (class objfile_msymbols): Remove.
1541         * symtab.c (default_collect_symbol_completion_matches_break_on):
1542         Update.
1543         * symmisc.c (dump_msymbols): Update.
1544         * stabsread.c (scan_file_globals): Update.
1545         * objc-lang.c (info_selectors_command, info_classes_command)
1546         (find_methods): Update.
1547         * minsyms.c (find_solib_trampoline_target): Update.
1548         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1549         * coffread.c (coff_symfile_read): Update.
1550         * ada-lang.c (ada_lookup_simple_minsym)
1551         (ada_collect_symbol_completion_matches): Update.
1552
1553 2019-01-16  Tom Tromey  <tom@tromey.com>
1554
1555         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1556         type.  Remove no-argument constructor.
1557         <iterator::operator++>: Simplify.
1558         <begin>: Update.
1559         <end>: Use minimal_symbol_count.
1560
1561 2019-01-16  Tom Tromey  <tom@tromey.com>
1562
1563         * objfiles.h (struct objfile) <psymtabs>: New method.
1564         (class objfile_psymtabs): Remove.
1565         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1566         typedef.
1567         <range>: New method.
1568         (require_partial_symbols): Change return type.
1569         * psymtab.c (require_partial_symbols)
1570         (psym_expand_symtabs_matching): Update.
1571         * mdebugread.c (parse_partial_symbols): Update.
1572         * dbxread.c (dbx_end_psymtab): Update.
1573
1574 2019-01-15  Tom Tromey  <tom@tromey.com>
1575
1576         * symtab.c (lookup_objfile_from_block)
1577         (lookup_symbol_in_objfile_symtabs)
1578         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1579         (find_line_symtab, info_sources_command)
1580         (default_collect_symbol_completion_matches_break_on)
1581         (make_source_files_completion_list): Update.
1582         * symmisc.c (print_objfile_statistics, dump_objfile)
1583         (maintenance_print_symbols, maintenance_info_symtabs)
1584         (maintenance_check_symtabs, maintenance_info_line_tables):
1585         Update.
1586         * source.c (select_source_symtab)
1587         (forget_cached_source_info_for_objfile): Update.
1588         * objfiles.h (class objfile_compunits): Remove.
1589         (struct objfile) <compunits_range>: New typedef.
1590         (compunits): New method.
1591         * objfiles.c (objfile_relocate1): Update.
1592         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1593         * maint.c (count_symtabs_and_blocks): Update.
1594         * linespec.c (iterate_over_all_matching_symtabs): Update.
1595         * cp-support.c (add_symbol_overload_list_qualified): Update.
1596         * coffread.c (coff_symtab_read): Update.
1597         * ada-lang.c (add_nonlocal_symbols)
1598         (ada_collect_symbol_completion_matches)
1599         (ada_add_global_exceptions): Update.
1600
1601 2019-01-15  Tom Tromey  <tom@tromey.com>
1602
1603         * progspace.h (program_space) <objfiles_safe_range>: New
1604         typedef.
1605         <objfiles_safe>: New method.
1606         * objfiles.h (class all_objfiles_safe): Remove.
1607         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1608         * jit.c (jit_inferior_exit_hook): Update.
1609
1610 2019-01-17  Tom Tromey  <tom@tromey.com>
1611
1612         * progspace.h (program_space) <objfiles_range>: New typedef.
1613         <objfiles>: New method.
1614         <objfiles_head>: Rename from objfiles.
1615         (object_files): Update.
1616         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1617         * guile/scm-pretty-print.c
1618         (ppscm_find_pretty_printer_from_objfiles): Update.
1619         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1620         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1621         Update.
1622         * python/py-progspace.c (pspy_get_objfiles): Update.
1623         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1624         Update.
1625         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1626         (objfpy_lookup_objfile_by_build_id): Update.
1627         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1628         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1629         Update.
1630         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1631         (expand_symtab_containing_pc, lookup_objfile_from_block)
1632         (lookup_static_symbol, basic_lookup_transparent_type)
1633         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1634         (find_line_symtab, info_sources_command)
1635         (default_collect_symbol_completion_matches_break_on)
1636         (make_source_files_completion_list, find_main_name): Update.
1637         * symmisc.c (print_symbol_bcache_statistics)
1638         (print_objfile_statistics, maintenance_print_symbols)
1639         (maintenance_print_msymbols, maintenance_print_objfiles)
1640         (maintenance_info_symtabs, maintenance_check_symtabs)
1641         (maintenance_expand_symtabs, maintenance_info_line_tables):
1642         Update.
1643         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1644         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1645         (map_overlay_command, unmap_overlay_command)
1646         (simple_overlay_update, expand_symtabs_matching)
1647         (map_symbol_filenames): Update.
1648         * symfile-debug.c (set_debug_symfile): Update.
1649         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1650         Update.
1651         * source.c (select_source_symtab, forget_cached_source_info):
1652         Update.
1653         * solib.c (solib_read_symbols): Update.
1654         * solib-spu.c (append_ocl_sos): Update.
1655         * psymtab.c (maintenance_print_psymbols)
1656         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1657         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1658         * printcmd.c (info_symbol_command): Update.
1659         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1660         Update.
1661         * objfiles.h (class all_objfiles): Remove.
1662         * objfiles.c (have_partial_symbols, have_full_symbols)
1663         (have_minimal_symbols, qsort_cmp, update_section_map)
1664         (shared_objfile_contains_address_p)
1665         (default_iterate_over_objfiles_in_search_order): Update.
1666         * objc-lang.c (info_selectors_command, info_classes_command)
1667         (find_methods): Update.
1668         * minsyms.c (find_solib_trampoline_target): Update.
1669         * maint.c (maintenance_info_sections)
1670         (maintenance_translate_address, count_symtabs_and_blocks):
1671         Update.
1672         * main.c (captured_main_1): Update.
1673         * linux-thread-db.c (try_thread_db_load_from_pdir)
1674         (has_libpthread): Update.
1675         * linespec.c (iterate_over_all_matching_symtabs)
1676         (search_minsyms_for_name): Update.
1677         * jit.c (jit_find_objf_with_entry_addr): Update.
1678         * hppa-tdep.c (find_unwind_entry)
1679         (hppa_lookup_stub_minimal_symbol): Update.
1680         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1681         Update.
1682         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1683         (elf_gnu_ifunc_resolve_by_got): Update.
1684         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1685         * dwarf-index-write.c (save_gdb_index_command): Update.
1686         * cp-support.c (add_symbol_overload_list_qualified): Update.
1687         * breakpoint.c (create_overlay_event_breakpoint)
1688         (create_longjmp_master_breakpoint)
1689         (create_std_terminate_master_breakpoint)
1690         (create_exception_master_breakpoint): Update.
1691         * blockframe.c (find_pc_partial_function): Update.
1692         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1693         (ada_collect_symbol_completion_matches)
1694         (ada_add_global_exceptions): Update.
1695
1696 2019-01-17  Tom Tromey  <tom@tromey.com>
1697
1698         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1699         declare VEC.
1700         (solib_target_parse_libraries): Change return type.
1701         (library_list_start_segment, library_list_start_section)
1702         (library_list_end_library, library_list_start_library); Update.
1703         (solib_target_free_library_list): Remove.
1704         (solib_target_parse_libraries): Remove cleanup.  Change return
1705         type.
1706         (solib_target_current_sos): Update.
1707
1708 2019-01-17  Tom Tromey  <tromey@bapiya>
1709
1710         * valprint.c: Replace "the the" with "the".
1711         * symtab.c: Replace "the the" with "the".
1712         * solib.c: Replace "the the" with "the".
1713         * solib-dsbt.c: Replace "the the" with "the".
1714         * linespec.c: Replace "the the" with "the".
1715         * dwarf2loc.h: Replace "the the" with "the".
1716         * amd64-windows-tdep.c: Replace "the the" with "the".
1717         * aarch64-tdep.c: Replace "the the" with "the".
1718
1719 2019-01-16  Keith Seitz  <keiths@redhat.com>
1720
1721         PR gdb/23773
1722         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1723         <builder>: Rename to ..
1724         <m_builder>: ... this and make private.
1725         (dwarf2_cu::get_builder): New method.  Change all users of
1726         `builder' to use this method.
1727         (dwarf2_start_symtab): Move to ...
1728         (dwarf2_cu::start_symtab): ... here.  Update all callers
1729         (setup_type_unit_groups): Move to ...
1730         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1731         callers.
1732         (dwarf2_cu::reset_builder): New method.
1733         (process_full_compunit, process_full_type_unit): Use
1734         dwarf2_cu::reset_builder.
1735         (follow_die_offset): Record the ancestor CU if it is different
1736         from the followed DIE's CU.
1737         (follow_die_sig_1): Likewise.
1738
1739 2019-01-15  Tom Tromey  <tom@tromey.com>
1740
1741         * remote.c (class remote_state) <buf>: Now a char_vector.
1742         <buf_size>: Remove.
1743         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1744         parameter.
1745         (remote_target::getpkt_or_notif_sane_1)
1746         (remote_target::getpkt_sane)
1747         (remote_target::getpkt_or_notif_sane): Likewise.
1748         (class remote_target) <putpkt>: New overload.
1749         (remote_target::read_frame): Change type of "buf_p".  Remove
1750         sizeof_p parameter.
1751         (packet_ok): New overload.
1752         (packet_check_result): New overload.
1753         Update all uses.
1754
1755 2019-01-14  Tom Tromey  <tom@tromey.com>
1756
1757         * remote-notif.c (handle_notification, remote_notif_ack)
1758         (remote_notif_parse): Make "buf" const.
1759         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1760         const.
1761         (remote_notif_parse, remote_notif_ack, handle_notification):
1762         Likewise.
1763         * remote.c (remote_notif_stop_parse): Make "buf" const.
1764         (remote_target::remote_parse_stop_reply): Make "buf" const.
1765         (remote_notif_stop_ack): Make "buf" const.
1766
1767 2019-01-14  Tom Tromey  <tom@tromey.com>
1768
1769         * remote.c (remote_console_output): Make parameter const.
1770
1771 2019-01-14  Tom Tromey  <tom@tromey.com>
1772
1773         * target-debug.h (target_debug_print_signals): Constify.
1774         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1775         * procfs.c (procfs_target::pass_signals): Update.
1776         * linux-nat.c (linux_nat_target::pass_signals): Update.
1777         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1778         * target-delegates.c: Rebuild.
1779         * remote.c (remote_target::program_signals): Update.
1780         (remote_target::pass_signals): Update.
1781         * target.c (target_pass_signals): Constify argument.
1782         (target_program_signals): Likewise.
1783         * target.h (struct target_ops) <pass_signals, program_signals>:
1784         Constify argument.
1785         (target_pass_signals, target_program_signals): Constify argument.
1786
1787 2019-01-14  Tom Tromey  <tom@tromey.com>
1788
1789         PR tui/28819:
1790         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1791
1792 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1793
1794         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1795         field.
1796         * rs6000-tdep.c: Include reggroups.h.
1797         (IS_V_ALIAS_PSEUDOREG): Define.
1798         (rs6000_register_name): Return names for the "vX" aliases.
1799         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1800         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1801         aliases.  Call default_register_reggroup_p for all other
1802         pseudo-registers.
1803         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1804         New functions.
1805         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1806         Handle "vX" aliases.
1807         (v_alias_pseudo_register_collect): New function.
1808         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1809         (rs6000_gdbarch_init): Initialize "vX" aliases as
1810         pseudo-registers.  Restore registration of
1811         rs6000_pseudo_register_reggroup_p with
1812         set_tdesc_pseudo_register_reggroup_p.
1813
1814 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1815
1816         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1817         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1818         set_gdbarch_num_pseudo_regs.
1819
1820 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1821
1822         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1823         Remove arg prefixname, add do_set and do_show.
1824         Add member functions set_list and show_list.
1825         * cli/cli-style.c (class cli_style_option): Update accordingly.
1826         (style_set_list): Move to file scope.
1827         (style_show_list): Likewise.
1828         (set_style): Call help_list.
1829         (show_style): Call cmd_show_list.
1830         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1831         Update to use the new macro.
1832
1833 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1834
1835         * ada-lang.c (_initialize_ada_language): Expand the help text
1836         for the "catch exception" command.
1837
1838 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1839
1840         * symtab.c (matching_obj_sections): Initialize obj,
1841         declare it closer to its usage.
1842
1843 2019-01-10  Tom Tromey  <tom@tromey.com>
1844
1845         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1846         (basic_inf_threads_range): Remove.
1847         (inf_threads_range, inf_non_exited_threads_range)
1848         (safe_inf_threads_range): Use next_adapter.
1849
1850 2019-01-10  Keith Seitz  <keiths@redhat.com>
1851
1852         PR gdb/23712
1853         PR symtab/23010
1854         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1855         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1856
1857 2019-01-10  Keith Seitz  <keiths@redhat.com>
1858
1859         PR gdb/23712
1860         PR symtab/23010
1861         * dictionary.c (pending_to_vector): Remove.
1862         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1863         Remove _1 suffix, replacing functions of the same name.  Update
1864         all callers.
1865         (dict_create_hashed, dict_create_hashed_expandable)
1866         (dict_create_linear, dict_create_linear_expandable, dict_free)
1867         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1868         Make functions static.
1869
1870 2019-01-10  Keith Seitz  <keiths@redhat.com>
1871
1872         PR gdb/23712
1873         PR symtab/23010
1874         * dictionary.h (struct dictionary): Replace declaration with
1875         multidictionary.
1876         (dict_create_hashed, dict_create_hashed_expandable)
1877         (dict_create_linear, dict_create_linear_expandable)
1878         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1879         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1880         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1881         taking multidictionary argument.
1882         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1883         * block.h (struct block) <dict>: Change to multidictionary
1884         and rename `multidict'.
1885         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1886         symmisc.c: Update all dictionary references to multidictionary.
1887
1888 2019-01-10  Keith Seitz  <keiths@redhat.com>
1889
1890         PR gdb/23712
1891         PR symtab/23010
1892         * dictionary.c: Include unordered_map.
1893         (pending_to_vector): New function.
1894         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1895         Rewrite the non-"_1" functions to take vector instead
1896         of linked list.
1897         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1898         "new" _1 versions of the same name.
1899         (multidictionary): Define.
1900         (std::hash<enum language): New definition.
1901         (collate_pending_symbols_by_language, mdict_create_hashed)
1902         (mdict_create_hashed_expandable, mdict_create_linear)
1903         (mdict_create_linear_expandable, mdict_free)
1904         (find_language_dictionary, create_new_language_dictionary)
1905         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1906         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1907         (mdict_size, mdict_empty): New functions.
1908         * dictionary.h (mdict_iterator): Define.
1909
1910 2019-01-10  Pedro Alves  <palves@redhat.com>
1911
1912         * breakpoint.c (read_uploaded_action)
1913         (create_tracepoint_from_upload): Adjust to use
1914         gdb::unique_xmalloc_ptr.
1915         * ctf.c (ctf_write_uploaded_tp):
1916         (SET_ARRAY_FIELD): Use emplace_back.
1917         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1918         * tracefile-tfile.c (tfile_write_uploaded_tp):
1919         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1920         gdb::unique_xmalloc_ptr.
1921         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1922         at_string, cond_string, cmd_strings>: Replace char pointers
1923         with gdb::unique_xmalloc_ptr.
1924
1925 2019-01-10  Pedro Alves  <palves@redhat.com>
1926
1927         * solib-target.c (library_list_start_library): Don't xstrdup name.
1928
1929 2019-01-10  Pedro Alves  <palves@redhat.com>
1930
1931         * mdebugread.c (parse_partial_symbols): Use
1932         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1933
1934 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1935
1936         * linux-fork.c (scoped_switch_fork_info)
1937         <~scoped_switch_fork_info>: Fix incorrect variable name.
1938
1939 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * linux-fork.c (scoped_switch_fork_info)
1942         <scoped_switch_fork_info>: Make explicit.
1943         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1944
1945 2019-01-10  Tom Tromey  <tom@tromey.com>
1946
1947         * objfiles.h (objfile::reset_psymtabs): Update.
1948         * objfiles.c (objfile::objfile): Update.
1949         * psymtab.h (psymtab_storage::obstack): Update.
1950         (psymtab_storage::m_obstack): Use gdb::optional.
1951         (class psymtab_storage): Update comment.  Remove objfile
1952         parameter.
1953         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1954
1955 2019-01-10  Tom Tromey  <tom@tromey.com>
1956
1957         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1958         <free_psymtabs>: Now private.
1959         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1960         (allocate_psymtab): Use new method.
1961
1962 2019-01-10  Tom Tromey  <tom@tromey.com>
1963
1964         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1965         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1966         * mdebugread.c (parse_partial_symbols): Use
1967         allocate_dependencies.
1968         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1969         allocate_dependencies.
1970         (process_psymtab_comp_unit_reader)
1971         (build_type_psymtab_dependencies): Likewise.
1972         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1973
1974 2019-01-10  Tom Tromey  <tom@tromey.com>
1975
1976         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1977         PSYMBOL_SET_LANGUAGE.
1978         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1979
1980 2019-01-10  Tom Tromey  <tom@tromey.com>
1981
1982         * psymtab.h (psymtab_storage::obstack): New method.
1983         <m_obstack>: Rename from obstack; now private.
1984         * psymtab.c (psymtab_storage): Update.
1985         * dwarf2read.c (create_addrmap_from_index)
1986         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1987         Update.
1988
1989 2019-01-10  Tom Tromey  <tom@tromey.com>
1990
1991         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1992         * objfiles.h (objfile::reset_psymtabs): New method.
1993
1994 2019-01-10  Tom Tromey  <tom@tromey.com>
1995
1996         * symmisc.c (print_symbol_bcache_statistics): Update.
1997         (print_objfile_statistics): Update.
1998         * symfile.c (reread_symbols): Update.
1999         * psymtab.h (class psymtab_storage): New.
2000         * psymtab.c (psymtab_storage): New constructor.
2001         (~psymtab_storage): New destructor.
2002         (require_partial_symbols): Update.
2003         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2004         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2005         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2006         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2007         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2008         (start_psymtab_common, end_psymtab_common)
2009         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2010         (allocate_psymtab): Update.
2011         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2012         Update.
2013         (dump_psymtab_addrmap, maintenance_print_psymbols)
2014         (maintenance_check_psymtabs): Update.
2015         (class objfile_psymtabs): Move to objfiles.h.
2016         * psympriv.h (discard_psymtab): Now inline.
2017         (psymtab_discarder::psymtab_discarder): Update.
2018         (psymtab_discarder::~psymtab_discarder): Update.
2019         (ALL_OBJFILE_PSYMTABS): Rewrite.
2020         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2021         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2022         Remove fields.
2023         <partial_symtabs>: New field.
2024         (class objfile_psymtabs): Move from psymtab.h.  Update.
2025         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2026         psymbol_cache.
2027         (objfile::~objfile): Don't destroy psymbol_cache.
2028         * mdebugread.c (parse_partial_symbols): Update.
2029         * dwarf2read.c (create_addrmap_from_index)
2030         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2031         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2032         (add_partial_subprogram, dwarf2_ranges_read): Update.
2033         * dwarf-index-write.c (write_address_map)
2034         (write_one_signatured_type, recursively_write_psymbols)
2035         (class debug_names, class debug_names, write_psymtabs_to_index):
2036         Update.
2037
2038 2019-01-10  Tom Tromey  <tom@tromey.com>
2039
2040         * symtab.h (SYMBOL_SET_NAMES): Update.
2041         (symbol_set_names): Update.
2042         (MSYMBOL_SET_NAMES): Update.
2043         * symtab.c (symbol_set_names): Change argument to be an
2044         objfile_per_bfd_storage.
2045         * psymtab.c (add_psymbol_to_bcache): Update.
2046         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2047
2048 2019-01-10  Tom Tromey  <tom@tromey.com>
2049
2050         * symtab.c (create_demangled_names_hash): Change argument to be an
2051         objfile_per_bfd_storage.
2052         (symbol_set_names): Update.
2053
2054 2019-01-10  Tom Tromey  <tom@tromey.com>
2055
2056         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2057         init_psymbol_list.
2058         * psymtab.c (init_psymbol_list): Do nothing if already called.
2059         * psympriv.h (init_psymbol_list): Add comment.
2060         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2061         init_psymbol_list.
2062         * dbxread.c (dbx_symfile_read): Unconditionally call
2063         init_psymbol_list.
2064
2065 2019-01-10  Tom Tromey  <tom@tromey.com>
2066
2067         * xcoffread.c (scan_xcoff_symtab): Update.
2068         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2069         "where".
2070         * mdebugread.c (parse_partial_symbols)
2071         (handle_psymbol_enumerators): Update.
2072         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2073         * dbxread.c (read_dbx_symtab): Update.
2074         * psympriv.h (psymbol_placement): New enum.
2075         (add_psymbol_to_list): Update.
2076
2077 2019-01-10  Tom Tromey  <tom@tromey.com>
2078
2079         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2080         static_psymbols parameters.
2081         (scan_xcoff_symtab): Update.
2082         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2083         static_psymbols parameters.
2084         * psympriv.h (start_psymtab_common): Update.
2085         * mdebugread.c (parse_partial_symbols): Update.
2086         * dwarf2read.c (create_partial_symtab): Update.
2087         * dbxread.c (read_dbx_symtab): Update.
2088         (start_psymtab): Remove global_psymbols and static_psymbols
2089         parameters.
2090
2091 2019-01-10  Tom Tromey  <tom@tromey.com>
2092
2093         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2094         * psymtab.c (allocate_psymtab): Add comment.
2095         * psympriv.h (allocate_psymtab): Add comment.
2096         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2097         initializations.
2098         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2099
2100 2019-01-10  Tom Tromey  <tom@tromey.com>
2101
2102         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2103         Don't declare.
2104         * mipsread.c: Include mdebugread.h.
2105         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2106         Declare.
2107         * elfread.c: Include mdebugread.h.
2108
2109 2019-01-09  Tom Tromey  <tom@tromey.com>
2110
2111         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2112         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2113         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2114         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2115         (psym_lookup_symbol, psym_find_last_source_symtab)
2116         (psym_forget_cached_source_info, psym_print_stats)
2117         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2118         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2119         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2120         (psym_find_compunit_symtab_by_address)
2121         (maintenance_print_psymbols, maintenance_info_psymtabs)
2122         (maintenance_check_psymtabs): Use ranged for.
2123         * psymtab.h (class objfile_psymtabs): New.
2124         (require_partial_symbols): Return objfile_psymtabs.
2125         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2126
2127 2019-01-09  Tom Tromey  <tom@tromey.com>
2128
2129         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2130         (find_pc_mapped_section, list_overlays_command)
2131         (map_overlay_command, unmap_overlay_command)
2132         (simple_overlay_update): Use all_objfiles.
2133         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2134         * printcmd.c (info_symbol_command): Use all_objfiles.
2135         * objfiles.h (ALL_OBJSECTIONS): Remove.
2136         * maint.c (maintenance_translate_address): Use all_objfiles.
2137         * gcore.c (gcore_create_callback): Use all_objfiles.
2138         (objfile_find_memory_regions): Likewise.
2139
2140 2019-01-09  Tom Tromey  <tom@tromey.com>
2141
2142         * symtab.c (find_line_symtab, info_sources_command)
2143         (make_source_files_completion_list): Use objfile_compunits.
2144         * source.c (select_source_symtab): Use objfile_compunits.
2145         * objfiles.h (struct objfile): Update comment.
2146         (ALL_OBJFILES): Remove.
2147         (ALL_FILETABS): Remove.
2148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2149         objfile_compunits.
2150
2151 2019-01-09  Tom Tromey  <tom@tromey.com>
2152
2153         * symmisc.c (print_objfile_statistics, dump_objfile)
2154         (maintenance_print_symbols): Use compunit_filetabs.
2155         * source.c (forget_cached_source_info_for_objfile): Use
2156         compunit_filetabs.
2157         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2158         (ALL_FILETABS): Use compunit_filetabs.
2159         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2160         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2161
2162 2019-01-09  Tom Tromey  <tom@tromey.com>
2163
2164         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2165         (compunit_filetabs): New.
2166         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2167         compunit_filetabs.
2168         (info_sources_command, make_source_files_completion_list): Remove
2169         declaration.
2170         * symmisc.c (print_objfile_statistics, dump_objfile)
2171         (maintenance_print_symbols): Remove declaration.
2172         (maintenance_info_symtabs): Use compunit_filetabs.
2173         (maintenance_info_line_tables): Likewise.
2174         * source.c (select_source_symtab): Change local variable name.
2175         (forget_cached_source_info_for_objfile): Remove declaration.
2176         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2177         * objfiles.c (objfile_relocate1): Remove declaration.
2178         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2179         declaration.
2180         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2181         * coffread.c (coff_symtab_read): Remove declaration.
2182         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2183         compunit_filetabs.
2184
2185 2019-01-09  Tom Tromey  <tom@tromey.com>
2186
2187         * symtab.c (lookup_objfile_from_block)
2188         (find_pc_sect_compunit_symtab, search_symbols)
2189         (default_collect_symbol_completion_matches_break_on): Use
2190         objfile_compunits.
2191         * objfiles.h (ALL_COMPUNITS): Remove.
2192         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2193         * cp-support.c (add_symbol_overload_list_qualified): Use
2194         objfile_compunits.
2195         * ada-lang.c (ada_collect_symbol_completion_matches)
2196         (ada_add_global_exceptions): Use objfile_compunits.
2197
2198 2019-01-09  Tom Tromey  <tom@tromey.com>
2199
2200         * source.c (select_source_symtab)
2201         (forget_cached_source_info_for_objfile): Remove declaration.
2202         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2203         declaration.
2204         * maint.c (count_symtabs_and_blocks): Remove declaration.
2205         * cp-support.c (add_symbol_overload_list_qualified): Remove
2206         declaration.
2207         * coffread.c (coff_symtab_read): Remove declaration.
2208         * symtab.c (lookup_symbol_in_objfile_symtabs)
2209         (basic_lookup_transparent_type_1): Use objfile_compunits.
2210         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2211         (info_sources_command, search_symbols)
2212         (default_collect_symbol_completion_matches_break_on)
2213         (make_source_files_completion_list): Remove declaration.
2214         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2215         (ada_collect_symbol_completion_matches)
2216         (ada_add_global_exceptions): Remove declaration.
2217         * linespec.c (iterate_over_all_matching_symtabs): Use
2218         objfile_compunits.
2219         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2220         (class objfile_compunits): New.
2221         (ALL_COMPUNITS): Use objfile_compunits.
2222         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2223         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2224         objfile_compunits.
2225         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2226
2227 2019-01-09  Tom Tromey  <tom@tromey.com>
2228
2229         * symtab.c (search_symbols)
2230         (default_collect_symbol_completion_matches_break_on): Use
2231         objfile_msymbols.
2232         * ada-lang.c (ada_lookup_simple_minsym)
2233         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2234         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2235         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2236         objfile_msymbols.
2237         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2238         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2239         * objc-lang.c (find_methods): Use objfile_msymbols.
2240         (info_selectors_command, info_classes_command): Likewise.
2241         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2242         * objfiles.h (class objfile_msymbols): New.
2243         (ALL_OBJFILE_MSYMBOLS): Remove.
2244         (ALL_MSYMBOLS): Remove.
2245
2246 2019-01-09  Tom Tromey  <tom@tromey.com>
2247
2248         * common/next-iterator.h (next_adapter): Add Iterator template
2249         parameter.
2250         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2251         (class all_objfiles_safe): New.
2252         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2253         * objfiles.c (put_objfile_before): Update comment.
2254         (add_separate_debug_objfile): Likewise.
2255         (free_all_objfiles): Use all_objfiles_safe.
2256         (objfile_purge_solibs): Likewise.
2257
2258 2019-01-09  Tom Tromey  <tom@tromey.com>
2259
2260         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2261         (expand_symtab_containing_pc, lookup_static_symbol)
2262         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2263         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2264         all_objfiles.
2265         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2266         * breakpoint.c (create_overlay_event_breakpoint)
2267         (create_longjmp_master_breakpoint)
2268         (create_std_terminate_master_breakpoint)
2269         (create_exception_master_breakpoint): Use all_objfiles.
2270         * linux-thread-db.c (try_thread_db_load_from_pdir)
2271         (has_libpthread): Use all_objfiles.
2272         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2273         * linespec.c (iterate_over_all_matching_symtabs)
2274         (search_minsyms_for_name): Use all_objfiles.
2275         * maint.c (maintenance_info_sections): Use all_objfiles.
2276         * main.c (captured_main_1): Use all_objfiles.
2277         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2278         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2279         * guile/scm-pretty-print.c
2280         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2281         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2282         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2283         (maintenance_print_msymbols): Use all_objfiles.
2284         * source.c (select_source_symtab): Use all_objfiles.
2285         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2286         * symfile.c (remove_symbol_file_command)
2287         (expand_symtabs_matching, map_symbol_filenames): Use
2288         all_objfiles.
2289         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2290         all_objfiles.
2291         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2292         * objc-lang.c (find_methods): Use all_objfiles.
2293         * objfiles.c (have_partial_symbols, have_full_symbols)
2294         (have_minimal_symbols, qsort_cmp)
2295         (default_iterate_over_objfiles_in_search_order): Use
2296         all_objfiles.
2297         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2298         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2299         (maintenance_check_psymtabs): Use all_objfiles.
2300         (ALL_PSYMTABS): Remove.
2301         * compile/compile-object-run.c (do_module_cleanup): Use
2302         all_objfiles.
2303         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2304         * cp-support.c (add_symbol_overload_list_qualified): Use
2305         all_objfiles.
2306         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2307         Use all_objfiles.
2308         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2309         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2310         all_objfiles.
2311         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2312         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2313         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2314         Uses all_objfiles.
2315         * solib.c (solib_read_symbols): Use all_objfiles
2316
2317 2019-01-09  Tom Tromey  <tom@tromey.com>
2318
2319         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2320         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2321         all_objfiles.
2322         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2323         * symmisc.c (print_symbol_bcache_statistics)
2324         (print_objfile_statistics, maintenance_print_objfiles)
2325         (maintenance_info_symtabs, maintenance_check_symtabs)
2326         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2327         all_objfiles.
2328         * source.c (forget_cached_source_info): Use all_objfiles.
2329         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2330         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2331         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2332         * objfiles.c (update_section_map): Use all_objfiles.
2333         (shared_objfile_contains_address_p): Likewise.
2334         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2335         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2336
2337 2019-01-09  Tom Tromey  <tom@tromey.com>
2338
2339         * common/next-iterator.h: New file.
2340         * objfiles.h (class all_objfiles): New.
2341         (struct objfile_iterator): New.
2342
2343 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2344
2345         * NEWS: Move the description of the changed "frame", "select-frame",
2346          and "info frame" commands to the Changed commands section.
2347
2348 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2349
2350         * gdbtypes.c (check_stub_method_group): Remove handling of old
2351         mangling schemes.
2352         * linespec.c (find_methods): Likewise.
2353         * stabsread.c (read_member_functions): Likewise.
2354         * valops.c (search_struct_method): Likewise.
2355         (value_struct_elt_for_reference): Likewise.
2356         * NEWS: Mention this change.
2357
2358 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2359
2360         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2361         print_source_lines.
2362         * source.c (print_source_lines_base): Update line number check.
2363         (print_source_lines): New function.
2364         (source_lines_range::source_lines_range): New function.
2365         * source.h (class source_lines_range): New class.
2366         (print_source_lines): New declaration.
2367
2368 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2369
2370         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2371
2372 2019-01-08  Tom Tromey  <tom@tromey.com>
2373             Simon Marchi  <simon.marchi@ericsson.com>
2374
2375         PR gdb/24060
2376         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2377         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2378         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2379         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2380         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2381         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2382
2383 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2384
2385         * source.c (select_source_symtab): Move header comment to
2386         declaration in source.h.
2387         (forget_cached_source_info_for_objfile): Likewise.
2388         (forget_cached_source_info): Likewise.
2389         (identify_source_line): Likewise.
2390         * source.h (identify_source_line): Move declaration from symtab.h
2391         and add comment from source.c
2392         (print_source_lines): Likewise.
2393         (forget_cached_source_info_for_objfile): Likewise.
2394         (forget_cached_source_info): Likewise.
2395         (select_source_symtab): Likewise.
2396         (enum print_source_lines_flag): Move definition from symtab.h.
2397         * symtab.h (identify_source_line): Move declaration to source.h.
2398         (print_source_lines): Likewise.
2399         (forget_cached_source_info_for_objfile): Likewise.
2400         (forget_cached_source_info): Likewise.
2401         (select_source_symtab): Likewise.
2402         (enum print_source_lines_flag): Move definition to source.h.
2403         * tui/tui-hooks.c: Add 'source.h' include.
2404
2405 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2406
2407         * source.c (print_source_lines_base): Handle requests to print
2408         reverse line number sequences, and guard against empty lines
2409         string.
2410
2411 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * source.c (print_source_lines_base): Fix skip of '\r' if next
2414         character is '\n'.
2415
2416 2019-01-06  Tom Tromey  <tom@tromey.com>
2417
2418         * c-exp.y (struct c_parse_state) <macro_original_text,
2419         expansion_obstack>: New member.
2420         (macro_original_text, expansion_obstack): Remove globals.
2421         (scan_macro_expansion, scanning_macro_expansion)
2422         (finished_macro_expansion): Update.
2423         (scan_macro_cleanup): Remove.
2424         (yylex, c_parse): Update.
2425
2426 2019-01-06  Tom Tromey  <tom@tromey.com>
2427
2428         * c-exp.y (struct c_parse_state) <strings>: New member.
2429         (operator_stoken): Update.
2430
2431 2019-01-06  Tom Tromey  <tom@tromey.com>
2432
2433         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2434         (union type_stack_elt) <typelist_val>: Now a pointer to
2435         std::vector.
2436         (type_stack_cleanup): Don't declare.
2437         (push_typelist): Update.
2438         * parse.c (pop_typelist): Return a std::vector.
2439         (push_typelist): Take a std::vector.
2440         (follow_types): Update.  Do not free args.
2441         (type_stack_cleanup): Remove.
2442         * c-exp.y (struct c_parse_state): New.
2443         (cpstate): New global.
2444         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2445         (nonempty_typelist): Update.
2446         (func_mod): Create a new vector.
2447         (c_parse): Create a c_parse_state.
2448         (check_parameter_typelist): Do not delete params.
2449         (function_method): Update.  Do not delete type_list.
2450
2451 2019-01-06  Tom Tromey  <tom@tromey.com>
2452
2453         PR gdb/28155:
2454         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2455         check_typedef.
2456         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2457         (print_return_value): Likewise.
2458
2459 2019-01-05  Tom Tromey  <tom@tromey.com>
2460
2461         * contrib/cleanup_check.py: Remove.
2462         * contrib/gcc-with-excheck: Remove.
2463         * contrib/exsummary.py: Remove.
2464         * contrib/excheck.py: Remove.
2465
2466 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2467
2468         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2469         NULL. Initialize tpprev to NULL instead of assigning it
2470         to NULL on the next statement.
2471         * windows-nat.c (windows_delete_thread): Remove check for
2472         main_thread_id before printing thread exit notifications.
2473         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2474         Remove thread ID check against main_thread_id.
2475         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2476         windows_delete_thread.
2477         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2478
2479 2019-01-04  Tom Tromey  <tom@tromey.com>
2480
2481         * compile/compile.c (_initialize_compile): Use upper case for
2482         metasyntactic variables.
2483         * symmisc.c (_initialize_symmisc): Use upper case for
2484         metasyntactic variables.
2485         * psymtab.c (_initialize_psymtab): Use upper case for
2486         metasyntactic variables.
2487         * demangle.c (demangle_command): Use upper case for metasyntactic
2488         variables.
2489         (_initialize_demangler): Likewise.
2490         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2491         variables.
2492
2493 2019-01-03  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2496
2497 2019-01-03  Tom Tromey  <tom@tromey.com>
2498
2499         * python/py-symtab.c (salpy_str): Update.
2500         (struct salpy_sal_object) <symtab>: Now a PyObject.
2501         (salpy_dealloc): Update.
2502         (del_objfile_sal): Use gdbpy_ref.
2503
2504 2019-01-03  Tom Tromey  <tom@tromey.com>
2505
2506         * python/py-type.c (convert_field): Use new_reference.  Return
2507         gdbpy_ref.
2508         (make_fielditem): Return gdbpy_ref.
2509         (typy_fields): Update.
2510         (typy_getitem): Update.
2511         (field_name): Return gdbpy_ref.  Use new_reference.
2512         (typy_iterator_iternext): Update.
2513
2514 2019-01-03  Tom Tromey  <tom@tromey.com>
2515
2516         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2517
2518 2019-01-03  Tom Tromey  <tom@tromey.com>
2519
2520         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2521         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2522         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2523         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2524         (pspy_set_type_printers): Likewise.
2525         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2526         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2527         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2528         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2529         (objfpy_set_type_printers): Likewise.
2530
2531 2019-01-03  Tom Tromey  <tom@tromey.com>
2532
2533         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2534         (gdbpy_print_stack): Use gdbpy_err_fetch.
2535         * python/python-internal.h (class gdbpy_err_fetch): New class.
2536         (class gdbpy_enter) <m_error_type, m_error_value,
2537         m_error_traceback>: Remove.
2538         <m_error>: New member.
2539         (gdbpy_exception_to_string): Don't declare.
2540         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2541         * python/py-value.c (convert_value_from_python): Use
2542         gdbpy_err_fetch.
2543         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2544         gdbpy_exception_to_string.
2545         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2546         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2547         gdbpy_err_fetch.
2548
2549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * linux-nat.c (delete_lwp_cleanup): Delete.
2552         (struct lwp_deleter): New struct.
2553         (lwp_info_up): New typedef.
2554         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2555         lwp_info_up.
2556
2557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * linux-fork.c (class scoped_switch_fork_info): New class.
2560         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2561
2562 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * valops.c (find_overload_match): Remove use of null_cleanup, and
2565         calls to do_cleanups.
2566
2567 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * compile/compile-cplus-types.c
2570         (compile_cplus_instance::decl_name): Handle changes to
2571         cp_func_name.
2572         * cp-support.c (cp_func_name): Update header comment, update
2573         return type.
2574         * cp-support.h (cp_func_name): Update return type in declaration.
2575         * valops.c (find_overload_match): Move temp_func local to top
2576         level of function and change its type.  Use temp_func to hold and
2577         delete temporary string obtained from cp_func_name.
2578
2579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2582         gdb::char_vector, remove cleanup, and update uses of `msg`.
2583
2584 2019-01-03  Jim Wilson  <jimw@sifive.com>
2585
2586         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2587
2588 2019-01-02  Tom Tromey  <tom@tromey.com>
2589
2590         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2591         (tdesc_parse_xml): Remove cleanups.
2592         * target-descriptions.h (make_cleanup_free_target_description):
2593         Don't declare.
2594         (target_desc_deleter): New struct.
2595         (target_desc_up): New typedef.
2596         * target-descriptions.c (target_desc_deleter::operator()): Rename
2597         from free_target_description.
2598         (make_cleanup_free_target_description): Remove.
2599
2600 2019-01-02  Tom Tromey  <tom@tromey.com>
2601
2602         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2603         constructor, destructor.
2604         (linespec_parser): Remove typedef.
2605         (~linespec_parser): Rename from linespec_parser_delete.
2606         (linespec_lex_to_end, linespec_complete_label)
2607         (linespec_complete): Update.
2608         (decode_line_full): Remove cleanups.
2609         (decode_line_1): Update.
2610
2611 2019-01-02  Tom Tromey  <tom@tromey.com>
2612
2613         * python/python-internal.h (inferior_to_inferior_object): Change
2614         return type.
2615         * python/py-exitedevent.c (create_exited_event_object): Update.
2616         * python/py-inferior.c (inferior_to_inferior_object): Return
2617         gdbpy_ref.
2618         (python_new_inferior, python_inferior_deleted)
2619         (thread_to_thread_object, delete_thread_object)
2620         (build_inferior_list, gdbpy_selected_inferior): Update.
2621         * python/py-infthread.c (create_thread_object): Update.  Also fail
2622         if inferior_to_inferior_object fails.
2623
2624 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2625
2626         * inferior.h (class inferior) <displaced_step_state>: New field.
2627         * infrun.h (struct displaced_step_state): Move here from
2628         infrun.c.  Initialize fields, add constructor.
2629         <inf>: Remove field.
2630         <reset>: New method.
2631         * infrun.c (struct displaced_step_inferior_state): Move to
2632         infrun.h.
2633         (displaced_step_inferior_states): Remove.
2634         (get_displaced_stepping_state): Adust.
2635         (displaced_step_in_progress_any_inferior): Adjust.
2636         (displaced_step_in_progress_thread): Adjust.
2637         (displaced_step_in_progress): Adjust.
2638         (add_displaced_stepping_state): Remove.
2639         (get_displaced_step_closure_by_addr): Adjust.
2640         (remove_displaced_stepping_state): Remove.
2641         (infrun_inferior_exit): Call displaced_step_state.reset.
2642         (use_displaced_stepping): Don't check for NULL.
2643         (displaced_step_prepare_throw): Call
2644         get_displaced_stepping_state.
2645         (displaced_step_fixup): Don't check for NULL.
2646         (prepare_for_detach): Don't check for NULL.
2647
2648 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2649
2650         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2651          in case of call that did not complete.
2652
2653 2019-01-02  Andrey Utkin  <autkin@undo.io>
2654
2655         * symfile.c (find_separate_debug_file): Fix search of debug files for
2656         remote debuggee.
2657
2658 2019-01-02  Tom Tromey  <tom@tromey.com>
2659
2660         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2661         indentation.
2662         * python/py-frame.c (frapy_older): Remove cast.
2663         (frapy_newer): Likewise.
2664         * python/py-breakpoint.c (local_setattro): Remove cast.
2665         * python/py-arch.c (archpy_name): Remove local variable.
2666         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2667
2668 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2669
2670         * unittests/basic_string_view/element_access/char/empty.cc:
2671         Fix year range in copyright header.
2672
2673 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2676         Delete.
2677         <operator==>: Update with for removed field.
2678         <hash>: Likewise.
2679         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2680         <isa_features>: ...this.
2681         <abi_features>: New field.
2682         (riscv_isa_flen): Update comment.
2683         (riscv_abi_xlen): New declaration.
2684         (riscv_abi_flen): New declaration.
2685         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2686         isa_features.
2687         (riscv_abi_xlen): New function.
2688         (riscv_isa_flen): Update to get answer from isa_features.
2689         (riscv_abi_flen): New function.
2690         (riscv_has_fp_abi): Update to get answer from abi_features.
2691         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2692         xlen and flen.
2693         (riscv_call_info) <xlen, flen>: Update comment.
2694         (riscv_call_arg_struct): Remove invalid assertions
2695         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2696         is removed.
2697         (riscv_gdbarch_init): Gather isa features and abi features
2698         separately, ensure both match on the gdbarch when reusing an old
2699         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2700         a target with 64-bit float hardware.
2701
2702 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2703
2704         * source.c (search_command_helper): Stop reverse search
2705         when line 1 has been searched.
2706
2707 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2708
2709         * record-full.c (record_full_base_target::close): Rewrite
2710         record_full_core_buf_list free logic.
2711
2712 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2713
2714         * break-catch-syscall.c (print_one_catch_syscall): xfree
2715         the last text.
2716
2717 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2718
2719         * top.c (print_gdb_version): Update Copyright year in version
2720         message.
2721
2722 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2723
2724         Update copyright year range in all GDB files.
2725
2726 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2727
2728         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2729
2730 For older changes see ChangeLog-2018.
2731 \f
2732 Local Variables:
2733 mode: change-log
2734 left-margin: 8
2735 fill-column: 74
2736 version-control: never
2737 coding: utf-8
2738 End:
2739