gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
   4         (symfile_debug_objfile_data_key): Change type.
   5         (symfile_debug_installed, debug_qf_has_symbols)
   6         (debug_qf_find_last_source_symtab)
   7         (debug_qf_forget_cached_source_info)
   8         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
   9         (debug_qf_print_stats, debug_qf_dump)
  10         (debug_qf_expand_symtabs_for_function)
  11         (debug_qf_expand_all_symtabs)
  12         (debug_qf_expand_symtabs_with_fullname)
  13         (debug_qf_map_matching_symbols)
  14         (debug_qf_expand_symtabs_matching)
  15         (debug_qf_find_pc_sect_compunit_symtab)
  16         (debug_qf_map_symbol_filenames)
  17         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
  18         (debug_sym_new_init, debug_sym_init, debug_sym_read)
  19         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
  20         (debug_sym_read_linetable, debug_sym_relocate): Update.
  21         (symfile_debug_free_objfile): Remove.
  22         (install_symfile_debug_logging, _initialize_symfile_debug):
  23         Update.
  24
  25 2019-05-08  Tom Tromey  <tom@tromey.com>
  26
  27         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
  28         allocate_on_obstack.
  29         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
  30         (get_dwarf2_per_objfile): Update.
  31         (set_dwarf2_per_objfile): Remove.
  32         (dwarf2_has_info, dwarf2_get_section_info): Update.
  33         (dwarf2_free_objfile): Remove.
  34         (_initialize_dwarf2_read): Update.
  35
  36 2019-05-08  Tom Tromey  <tom@tromey.com>
  37
  38         * auto-load.c (struct auto_load_pspace_info): Add destructor and
  39         initializers.
  40         <unsupported_script_warning_printed,
  41         script_not_found_warning_printed>: Now bool.
  42         (auto_load_pspace_data): Change type.
  43         (~auto_load_pspace_info): Rename from
  44         auto_load_pspace_data_cleanup.
  45         (get_auto_load_pspace_data, init_loaded_scripts_info)
  46         (clear_section_scripts, maybe_print_unsupported_script_warning)
  47         (maybe_print_script_not_found_warning, _initialize_auto_load):
  48         Update.
  49
  50 2019-05-08  Tom Tromey  <tom@tromey.com>
  51
  52         * objfiles.c (objfile_pspace_info): Add destructor and
  53         initializers.
  54         (objfiles_pspace_data): Change type.
  55         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
  56         (get_objfile_pspace_data): Update.
  57         (objfiles_bfd_data): Change type.
  58         (get_objfile_bfd_data): Update.
  59         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  60
  61 2019-05-08  Tom Tromey  <tom@tromey.com>
  62
  63         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  64         Change type.
  65         (get_catch_syscall_inferior_data): Update.
  66         (catch_syscall_inferior_data_cleanup): Remove.
  67         (_initialize_break_catch_syscall): Update.
  68
  69 2019-05-08  Tom Tromey  <tom@tromey.com>
  70
  71         * inflow.c (struct terminal_info): Add destructor and
  72         initializers.
  73         (inflow_inferior_data): Change type.
  74         (~terminal_info): Rename from inflow_inferior_data_cleanup.
  75         (get_inflow_inferior_data, inflow_inferior_exit)
  76         (swap_terminal_info, _initialize_inflow): Update.
  77
  78 2019-05-08  Tom Tromey  <tom@tromey.com>
  79
  80         * target-dcache.c (target_dcache_cleanup): Remove.
  81         (target_dcache_aspace_key): Change type.
  82         (target_dcache_init_p, target_dcache_invalidate)
  83         (target_dcache_get, target_dcache_get_or_init)
  84         (_initialize_target_dcache): Update.
  85         * dcache.h (struct dcache_deleter): New.
  86
  87 2019-05-08  Tom Tromey  <tom@tromey.com>
  88
  89         * symtab.c (struct symbol_cache): Add destructor and
  90         initializers.
  91         (symbol_cache_key): Move.  Change type.
  92         (make_symbol_cache, free_symbol_cache): Remove.
  93         (get_symbol_cache): Update.
  94         (symbol_cache_cleanup): Remove.
  95         (ALL_PSPACES, symbol_cache_flush)
  96         (maintenance_print_symbol_cache)
  97         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
  98         Update.
  99
 100 2019-05-08  Tom Tromey  <tom@tromey.com>
 101
 102         * symtab.c (struct main_info): Add destructor and initializers.
 103         (main_progspace_key): Move.  Change type.
 104         (get_main_info): Update.
 105         (main_info_cleanup): Remove.
 106         (_initialize_symtab): Update.
 107
 108 2019-05-08  Tom Tromey  <tom@tromey.com>
 109
 110         * registry.h (DECLARE_REGISTRY): Define the _key class.
 111
 112 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 113
 114         * NEWS: Merge two 'New commands' sections.
 115
 116 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 117
 118         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 119         parameter and use Ada language definition instead.
 120         (ada_val_print_ptr): Remove unused language parameter.
 121         (ada_val_print_num): Remove language parameter and use Ada language
 122         definition instead.
 123         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 124         parameter.
 125         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 126         parameter and use Ada language definition instead.
 127         (ada_val_print_1): Update all ada_val_print_xxx calls.
 128         Remove language parameter.
 129         (ada_val_print): Update ada_val_print_1 call.
 130
 131 2019-05-08  Tom Tromey  <tromey@adacore.com>
 132
 133         * remote.c (remote_hw_watchpoint_limit)
 134         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 135         Now static.
 136
 137 2019-05-08  Tom Tromey  <tromey@adacore.com>
 138
 139         * maint.c (_initialize_maint_cmds): Move initialization code to
 140         remote.c.
 141         (watchdog, show_watchdog): Move to remote.c.
 142         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 143         "watchdog" static.
 144         (_initialize_remote): Move initialization code from maint.c.
 145         * defs.h (watchdog): Don't declare.
 146
 147 2019-05-08  Tom Tromey  <tromey@adacore.com>
 148
 149         * tui/tui-interp.c: Include main.h.
 150         * interps.c: Include main.h.
 151         * main.h (interpreter_p): Declare.
 152         * defs.h (interpreter_p): Don't declare.
 153
 154 2019-05-08  Tom Tromey  <tromey@adacore.com>
 155
 156         * dwarf2loc.c: Include dwarf2read.h.
 157         * defs.h (read_unsigned_leb128): Don't declare.
 158         * dwarf2read.h (read_unsigned_leb128): Declare.
 159
 160 2019-05-08  Tom Tromey  <tromey@adacore.com>
 161
 162         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 163         method.
 164
 165 2019-05-08  Tom Tromey  <tromey@adacore.com>
 166
 167         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 168         when no wrap column is set.
 169
 170 2019-05-08  Tom Tromey  <tromey@adacore.com>
 171
 172         * c-lang.c (c_get_string): Handle non-C-style arrays.
 173
 174 2019-05-08  Tom Tromey  <tromey@adacore.com>
 175
 176         * typeprint.c (print_offset_data::update): Print the bit offset,
 177         not the number of bits remaining.
 178
 179 2019-05-08  Tom Tromey  <tromey@adacore.com>
 180
 181         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 182         padding at end of comment.
 183
 184 2019-05-08  Tom Tromey  <tromey@adacore.com>
 185
 186         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 187         Compare main types.
 188
 189 2019-05-06  Tom Tromey  <tom@tromey.com>
 190
 191         * common/scoped_mmap.c: Include common-defs.h.
 192         * common/scoped_mmap.h: Don't include config.h.
 193
 194 2019-05-04  Tom Tromey  <tom@tromey.com>
 195
 196         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 197         (struct aarch64_call_info): Add initializers.
 198         <si>: Now a std::vector.
 199         (pass_on_stack, aarch64_push_dummy_call): Update.
 200
 201 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 202             Tom Tromey  <tom@tromey.com>
 203
 204         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 205         (ppc_threads): Now a std::vector.  Now static.
 206         (hwdebug_find_thread_points_by_tid)
 207         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 208         Update.
 209
 210 2019-05-04  Tom Tromey  <tom@tromey.com>
 211
 212         * arc-tdep.c (arc_tdesc_init): Return bool.
 213
 214 2019-05-04  Tom Tromey  <tom@tromey.com>
 215
 216         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 217         Use gdb_assert_not_reached.
 218
 219 2019-05-04  Tom Tromey  <tom@tromey.com>
 220
 221         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 222         "false".
 223
 224 2019-05-04  Tom Tromey  <tom@tromey.com>
 225
 226         * arc-tdep.c (arc_tdesc_init): Use bool.
 227
 228 2019-05-04  Tom Tromey  <tom@tromey.com>
 229
 230         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 231
 232 2019-05-04  Tom Tromey  <tom@tromey.com>
 233
 234         * cli/cli-cmds.c (valid_command_p): Return bool.
 235
 236 2019-05-04  Tom Tromey  <tom@tromey.com>
 237
 238         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 239         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 240
 241 2019-05-04  Raul Tambre  <raul@tambre.ee>
 242
 243         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 244         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 245         operator for comparison.
 246
 247 2019-05-04  Tom Tromey  <tom@tromey.com>
 248
 249         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 250         (lookup_partial_symbol, print_partial_symbols)
 251         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 252         (psymbol_compare): Update.
 253         (add_psymbol_to_bcache): Clear the entire psymbol.
 254         (maintenance_check_psymtabs): Update.
 255         * psympriv.h (struct partial_symbol): Don't derive from
 256         general_symbol_info.
 257         <obj_section, unrelocated_address, address,
 258         set_unrelocated_address>: Update.
 259         <ginfo>: New member.
 260         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 261         (debug_names::write_psymbols): Update.
 262
 263 2019-05-04  Tom de Vries  <tdevries@suse.de>
 264
 265         * contrib/cc-with-tweaks.sh: Support -n arg.
 266
 267 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 268
 269         * corelow.c (core_target::detach): Ensure frame cache and
 270         register caches are cleared.
 271         inferior.c (exit_inferior_1): Likewise.
 272
 273 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 274             Tom Tromey  <tom@tromey.com>
 275
 276         * dictionary.c (collate_pending_symbols_by_language): Remove
 277         "struct" from foreach.
 278         * symtab.c (lookup_global_symbol_from_objfile)
 279         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 280         foreach.
 281         * ser-tcp.c (net_open): Remove "struct" from foreach.
 282         * objfiles.c (objfile_relocate, objfile_rebase)
 283         (objfile_has_symbols): Remove "struct" from foreach.
 284         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 285         from foreach.
 286         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 287         foreach.
 288         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 289         "struct" from foreach.
 290         * ada-lang.c (create_excep_cond_exprs)
 291         (ada_exception_catchpoint_cond_string): Remove "struct" from
 292         foreach.
 293
 294 2019-05-03  Tom Tromey  <tromey@adacore.com>
 295
 296         * ada-exp.y (convert_char_literal): Check suffix of each
 297         enumerator.
 298
 299 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 300
 301         PR ada/21406:
 302         * ada-exp.y (yywrap): Don't define.
 303         * ada-lex.l (%option): Add noyywrap
 304         (yywrap): Remove.
 305
 306 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 307
 308         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 309         _WIN32_WINNT to the XP level, unless already defined to a higher
 310         level.
 311
 312         * unittests/parse-connection-spec-selftests.c:
 313         * ser-tcp.c:
 314         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 315         override.
 316
 317         * symfile.c (find_separate_debug_file): Remove colon from the
 318         drive spec of DOS/Windows file names of the target, so that the
 319         file name produced from DEBUGDIR and the target's directory will
 320         be valid on DOS/Windows systems.
 321
 322 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * rust-lang.c (val_print_struct): Handle printing structures
 325         containing strings.
 326
 327 2019-05-02  Tom Tromey  <tromey@adacore.com>
 328
 329         * valarith.c (_initialize_valarith): Remove.
 330
 331 2019-05-01  Tom Tromey  <tromey@adacore.com>
 332
 333         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 334         bitfields.
 335
 336 2019-05-01  Tom Tromey  <tromey@adacore.com>
 337
 338         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 339         for big-endian copies.
 340
 341 2019-04-30  Ali Tamur  <tamur@google.com>
 342         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 343         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 344         (read_3_bytes): New function.
 345
 346 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 347
 348         * windows-nat.c (main_thread_id): Delete.
 349         (handle_output_debug_string): Replace main_thread_id by
 350         current_event.dwThreadId.
 351         (fake_create_process): Likewise.
 352         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 353         Do not set main_thread_id.
 354         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 355         current_event.dwThreadId.
 356         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 357
 358 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 359
 360         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 361         Use current_event.dwThreadId instead of main_thread_id.
 362
 363 2019-04-30  Tom Tromey  <tromey@adacore.com>
 364
 365         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 366         (create_excep_cond_exprs): Iterate over program spaces.
 367         (ada_exception_catchpoint_cond_string): Examine all minimal
 368         symbols for exception types.
 369
 370 2019-04-30  Tom Tromey  <tromey@adacore.com>
 371
 372         PR c++/24470:
 373         * dwarf2read.c (process_structure_scope): Handle case where type
 374         has template parameters but no symbol was created.
 375
 376 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 377             Chris January  <chris.january@arm.com>
 378
 379         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 380         qualifier.
 381         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 382
 383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 384
 385         * f-typeprint.c (f_print_type): Update rules for printing
 386         whitespace.
 387         (f_type_print_varspec_suffix): Likewise.
 388
 389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 390             Chris January  <chris.january@arm.com>
 391
 392         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 393         function arguments.
 394
 395 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * f-lang.c (build_fortran_types): Change name of void type to
 398         lower case.
 399         * f-typeprint.c (f_type_print_base): Print the name of the void
 400         type, rather than a fixed string.
 401         * f-valprint.c (f_decorations): Use lower case void string.
 402
 403 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 404             Chris January  <chris.january@arm.com>
 405
 406         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 407         types for Fortran.
 408
 409 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 410             Chris January  <chris.january@arm.com>
 411             David Lecomber  <david.lecomber@arm.com>
 412
 413         * f-exp.y (BINOP_INTRINSIC): New token.
 414         (exp): New parser rule handling BINOP_INTRINSIC.
 415         (f77_keywords): Add new builtin procedures.
 416         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 417         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 418         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 419         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 420         (print_unop_subexp_f): New function.
 421         (print_binop_subexp_f): New function.
 422         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 423         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 424         (dump_subexp_body_f): Likewise.
 425         (operator_check_f): Likewise.
 426         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 427         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 428
 429 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 432         UNOP_KIND.
 433         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 434         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 435         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 436         (operator_length_f): New fuction.
 437         (print_subexp_f): New function.
 438         (op_name_f): New function.
 439         (dump_subexp_body_f): New function.
 440         (operator_check_f): New function.
 441         (exp_descriptor_f): Replace standard expression handling functions
 442         with new functions.
 443         * gdb/fortran-operator.def: New file.
 444         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 445         * gdb/std-operator.def: Remove UNOP_KIND.
 446
 447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 448
 449         * std-operator.def: Remove unbalanced, stray double quote
 450         character.
 451
 452 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 453             Chris January  <chris.january@arm.com>
 454             Daniel Everett  <daniel.everett@arm.com>
 455             Nick Forrington  <nick.forrington@arm.com>
 456             Richard Bunt  <richard.bunt@arm.com>
 457
 458         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 459         of depth when printing anonymous structs or unions.
 460         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 461         Don't print either the top-level value, or the children if the
 462         max-depth is exceeded.
 463         (ppscm_print_children): When printing the key of a map, allow one
 464         extra level of depth.
 465         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 466         print either the top-level value, or the children if the max-depth
 467         is exceeded.
 468         (print_children): When printing the key of a map, allow one extra
 469         level of depth.
 470         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 471         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 472         (user_print_options): Initialise max_depth field.
 473         (val_print_scalar_or_string_type_p): New function.
 474         (val_print): Check to see if the max depth has been reached.
 475         (val_print_check_max_depth): Define new function.
 476         (show_print_max_depth): New function.
 477         (_initialize_valprint): Add 'print max-depth' option.
 478         * valprint.h (struct value_print_options) <max_depth>: New field.
 479         (val_print_check_max_depth): Declare new function.
 480         * NEWS: Document new feature.
 481
 482 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         * ada-lang.c (ada_language_defn): Initialise new field.
 485         * c-lang.c (c_is_string_type_p): New function.
 486         (c_language_defn): Initialise new field.
 487         (cplus_language_defn): Initialise new field.
 488         (asm_language_defn): Initialise new field.
 489         (minimal_language_defn): Initialise new field.
 490         * c-lang.h (c_is_string_type_p): Declare new function.
 491         * d-lang.c (d_language_defn): Initialise new field.
 492         * f-lang.c (f_is_string_type_p): New function.
 493         (f_language_defn): Initialise new field.
 494         * go-lang.c (go_is_string_type_p): New function.
 495         (go_language_defn): Initialise new field.
 496         * language.c (default_is_string_type_p): New function.
 497         (unknown_language_defn): Initialise new field.
 498         (auto_language_defn): Initialise new field.
 499         * language.h (struct language_defn) <la_is_string_type_p>: New
 500         member variable.
 501         (default_is_string_type_p): Declare new function.
 502         * m2-lang.c (m2_language_defn): Initialise new field.
 503         * objc-lang.c (objc_language_defn): Initialise new field.
 504         * opencl-lang.c (opencl_language_defn): Initialise new field.
 505         * p-lang.c (pascal_is_string_type_p): New function.
 506         (pascal_language_defn): Initialise new field.
 507         * rust-lang.c (rust_is_string_type_p): New function.
 508         (rust_language_defn): Initialise new field.
 509
 510 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 513         New field.
 514         * ada-lang.c (ada_language_defn): Initialise new field.
 515         * c-lang.c (c_language_defn): Likewise.
 516         (cplus_language_defn): Likewise.
 517         (asm_language_defn): Likewise.
 518         (minimal_language_defn): Likewise.
 519         * d-lang.c (d_language_defn): Likewise.
 520         * f-lang.c (f_language_defn): Likewise.
 521         * go-lang.c (go_language_defn): Likewise.
 522         * language.c (unknown_language_defn): Likewise.
 523         (auto_language_defn): Likewise.
 524         * m2-lang.c (m2_language_defn): Likewise.
 525         * objc-lang.c (objc_language_defn): Likewise.
 526         * opencl-lang.c (opencl_language_defn): Likewise.
 527         * p-lang.c (pascal_language_defn): Likewise.
 528         * rust-lang.c (rust_language_defn): Likewise.
 529
 530 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * ada-lang.c (ada_is_character_type): Change return type to bool.
 533         (ada_is_string_type): Likewise.
 534         * ada-lang.h (ada_is_character_type): Update declaration
 535         (ada_is_string_type): Likewise.
 536
 537 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 538
 539         Support style in 'frame|thread apply'
 540
 541         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 542         * record.c (record_start, record_stop): Update callers of
 543         execute_command_to_string with false.
 544         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 545         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 546         methods.
 547         (class string_file): New constructor with term_out parameter.
 548         Override methods term_out and can_emit_style_escape.  New member
 549         term_out.
 550         (class stdio_file): Override can_emit_style_escape.
 551         (class tee_file): Override term_out and can_emit_style_escape.
 552         * utils.h (can_emit_style_escape): Remove.
 553         * utils.c (can_emit_style_escape): Likewise.
 554         Update all callers of can_emit_style_escape (SOMESTREAM) to
 555         SOMESTREAM->can_emit_style_escape.
 556         * source-cache.c (source_cache::get_source_lines): Likewise.
 557         * stack.c (frame_apply_command_count): Call execute_command_to_string
 558         passing the term_out characteristic of the current gdb_stdout.
 559         * thread.c (thr_try_catch_cmd): Likewise.
 560         * top.c (execute_command_to_string): pass term_out parameter
 561         to construct the string_file for the command output.
 562         * ui-file.c (term_cli_styling): New function (most code moved
 563         from utils.c can_emit_style_escape).
 564         (string_file::string_file, string_file::can_emit_style_escape,
 565         stdio_file::can_emit_style_escape, tee_file::term_out,
 566         tee_file::can_emit_style_escape): New functions.
 567
 568 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 569
 570         * NEWS: Mention the new set|show may-call-functions.
 571         * infcall.c (may_call_functions_p): New variable.
 572         (show_may_call_functions_p): New function.
 573         (call_function_by_hand_dummy): Throws an error if not
 574         may-call-functions.
 575         (_initialize_infcall): Call add_setshow_boolean_cmd for
 576         may-call-functions.
 577
 578 2019-04-25  Keith Seitz  <keiths@redhat.com>
 579
 580         PR c++/24367
 581         * cp-support.c (inspect_type): Don't attempt substitutions
 582         of symbol with the same name.
 583
 584 2019-04-25  Tom Tromey  <tromey@adacore.com>
 585
 586         PR gdb/24475:
 587         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 588         static.
 589
 590 2019-04-25  Tom Tromey  <tromey@adacore.com>
 591
 592         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 593         rvalue reference.
 594         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 595         (gdb_xml_parser::parse): Use std::move.
 596         * python/python-internal.h (gdbpy_convert_exception): Take a const
 597         reference.
 598         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 599         std::move.
 600         * python/py-utils.c (gdbpy_convert_exception): Take a const
 601         reference.
 602         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 603         Use std::move.
 604         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 605         Use std::move.
 606         * mi/mi-main.c (mi_print_exception): Take a const reference.
 607         * main.c (handle_command_errors): Take a const reference.
 608         * linespec.c (parse_linespec): Use std::move.
 609         * infcall.c (run_inferior_call): Use std::move.
 610         (call_function_by_hand_dummy): Use std::move.
 611         * exec.c (try_open_exec_file): Use std::move.
 612         * exceptions.h (exception_print, exception_fprintf)
 613         (exception_print_same): Update.
 614         * exceptions.c (print_exception, exception_print)
 615         (exception_fprintf, exception_print_same): Change parameters to
 616         const reference.
 617         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 618         * common/new-op.c: Use std::move.
 619         * common/common-exceptions.h (struct gdb_exception): Add move
 620         constructor.
 621         (struct gdb_exception_error, struct gdb_exception_quit, struct
 622         gdb_quit_bad_alloc): Change constructor to move constructor.
 623         (throw_exception): Change parameter to rvalue reference.
 624         * common/common-exceptions.c (throw_exception): Take rvalue
 625         reference.
 626         * cli/cli-interp.c (safe_execute_command): Use std::move.
 627         * breakpoint.c (insert_bp_location, location_to_sals): Use
 628         std::move.
 629
 630 2019-04-25  Tom Tromey  <tromey@adacore.com>
 631
 632         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 633         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 634         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 635         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 636         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 637         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 638         guile/scm-value.c: Use unpack.
 639         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 640         gdbscm_gdb_exception.
 641         (gdbscm_throw_gdb_exception): Likewise.
 642         (struct gdbscm_gdb_exception): New.
 643         (unpack): New function.
 644         (gdbscm_wrap): Use unpack.
 645
 646 2019-04-25  Tom Tromey  <tromey@adacore.com>
 647
 648         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 649         (gdb_rl_callback_handler): Use std::move.
 650         * common/common-exceptions.h (struct gdb_exception): Add move
 651         assignment operator.
 652         (throw_exception_sjlj): Change "exception" to const reference.
 653         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 654         (throw_exception_sjlj): Change "exception" to const reference.
 655
 656 2019-04-25  Tom Tromey  <tromey@adacore.com>
 657
 658         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 659         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 660         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 661         Update.
 662         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 663         Update.
 664         * mi/mi-interp.c (mi_interp::exec): Update.
 665         * linespec.c (parse_linespec): Update.
 666         * infcall.c (run_inferior_call): Update.
 667         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 668         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 669         (gdbscm_lookup_global_symbol): Update.
 670         * guile/scm-param.c (gdbscm_parameter_value): Update.
 671         * guile/scm-frame.c (gdbscm_frame_read_register)
 672         (gdbscm_frame_read_var): Update.
 673         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 674         * exec.c (try_open_exec_file): Update.
 675         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 676         (gdb_rl_callback_handler): Update.
 677         * common/common-exceptions.h (exception_none): Don't declare.
 678         * common/common-exceptions.c (exception_none): Don't define.
 679         (struct catcher) <exception>: Update.
 680         * cli/cli-interp.c (safe_execute_command): Update.
 681         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 682
 683 2019-04-25  Ali Tamur  <tamur@google.com>
 684
 685         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 686         (read_attribute_value): Likewise.
 687         (dwarf2_read_addr_index): Update comment.
 688         (read_str_index): Add DW_FORM_strx.
 689         (dwarf2_string_attr): Likewise.
 690         (dwarf2_const_value_attr): Likewise.
 691         (dump_die_shallow): Likewise.
 692         (dwarf2_fetch_constant_bytes): Likewise.
 693         (skip_form_bytes): Likewise.
 694         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 695
 696 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 697
 698         PR corefiles/11608
 699         PR corefiles/18187
 700         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 701         OFFSET.  Verify if current mapping contains an ELF header.
 702         (linux_find_memory_regions_full): Adjust call to
 703         dump_mapping_p.
 704
 705 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 706             Kang Li <kanglictf@gmail.com>
 707
 708         PR gdb/21600
 709
 710         * dwarf2-frame.c (read_initial_length): Be consistent about using
 711         unsigned representation of length.
 712         (decode_frame_entry_1): Likewise.  Check for wraparound of
 713         end pointer as well as buffer overflow.
 714
 715 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 716
 717         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 718         "vq".
 719
 720 2019-04-24  Tom Tromey  <tromey@adacore.com>
 721
 722         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 723
 724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         * s12z-tdep.c (s12z_unwind_pc): Delete.
 727         (s12z_unwind_sp): Delete.
 728         (s12z_gdbarch_init): Don't register deleted functions with
 729         gdbarch.
 730
 731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * rl78-tdep.c (rl78_unwind_sp): Delete.
 734         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 735
 736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 739         (xstormy16_unwind_pc): Delete.
 740         (xstormy16_dummy_id): Delete.
 741         (xstormy16_gdbarch_init): Don't register deleted functions with
 742         gdbarch.
 743
 744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * vax-tdep.c (vax_unwind_pc): Delete.
 747         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 748
 749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 750
 751         * v850-tdep.c (v850_unwind_sp): Delete.
 752         (v850_unwind_pc): Delete.
 753         (v850_dummy_id): Delete.
 754         (v850_gdbarch_init): Don't register deleted functions with
 755         gdbarch.
 756
 757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 760         (tilegx_unwind_pc): Delete.
 761         (tilegx_unwind_dummy_id): Delete.
 762         (tilegx_gdbarch_init): Don't register deleted functions with
 763         gdbarch.
 764
 765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 768         (tic6x_dummy_id): Delete.
 769         (tic6x_gdbarch_init): Don't register deleted functions with
 770         gdbarch.
 771
 772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 773
 774         * sparc-tdep.c (sparc_unwind_pc): Delete.
 775         (sparc32_gdbarch_init): Don't register deleted function with
 776         gdbarch.
 777
 778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * sh-tdep.c (sh_unwind_sp): Delete.
 781         (sh_unwind_pc): Delete.
 782         (sh_dummy_id): Delete.
 783         (sh_gdbarch_init): Don't register deleted functions with
 784         gdbarch.
 785
 786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * score-tdep.c (score_unwind_sp): Delete.
 789         (score_unwind_pc): Delete.
 790         (score_dummy_id): Delete.
 791         (score_gdbarch_init): Don't register deleted functions with
 792         gdbarch.
 793
 794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * rx-tdep.c (rx_unwind_pc): Delete.
 797         (rx_unwind_sp): Delete.
 798         (rx_dummy_id): Delete.
 799         (rx_gdbarch_init): Don't register deleted functions with
 800         gdbarch.  Update comment.
 801
 802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 803
 804         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 805         (rs6000_dummy_id): Delete.
 806         (rs6000_gdbarch_init): Don't register deleted functions with
 807         gdbarch.
 808
 809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * or1k-tdep.c (or1k_dummy_id): Delete.
 812         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 813
 814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 815
 816         * nios2-tdep.c (nios2_dummy_id): Delete.
 817         (nios2_unwind_sp): Delete.
 818         (nios2_gdbarch_init): Don't register deleted functions with
 819         gdbarch.
 820
 821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * nds32-tdep.c (nds32_dummy_id): Delete.
 824         (nds32_unwind_pc): Delete.
 825         (nds32_unwind_sp): Delete.
 826         (nds32_gdbarch_init): Don't register deleted functions with
 827         gdbarch.
 828
 829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 830
 831         * msp430-tdep.c (msp430_unwind_pc): Delete.
 832         (msp430_unwind_sp): Delete.
 833         (msp430_dummy_id): Delete.
 834         (msp430_gdbarch_init): Don't register deleted functions with
 835         gdbarch.
 836
 837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * moxie-tdep.c (moxie_unwind_sp): Delete.
 840         (moxie_unwind_pc): Delete.
 841         (moxie_dummy_id): Delete.
 842         (moxie_gdbarch_init): Don't register deleted functions with
 843         gdbarch.
 844
 845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 848         (mn10300_unwind_pc): Delete.
 849         (mn10300_unwind_sp): Delete.
 850         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 851         mn10300_unwind_sp.
 852         (mn10300_frame_unwind_init): Don't register deleted functions with
 853         gdbarch.
 854
 855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * mep-tdep.c (mep_unwind_pc): Delete.
 858         (mep_unwind_sp): Delete.
 859         (mep_dummy_id): Delete.
 860         (mep_gdbarch_init): Don't register deleted functions with
 861         gdbarch.
 862
 863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 866         (m68hc11_unwind_sp): Delete.
 867         (m68hc11_gdbarch_init): Don't register deleted functions with
 868         gdbarch.
 869
 870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * m32r-tdep.c (m32r_unwind_sp): Delete.
 873         (m32r_unwind_pc): Delete.
 874         (m32r_dummy_id): Delete.
 875         (m32r_gdbarch_init): Don't register deleted functions with
 876         gdbarch.
 877
 878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * m32c-tdep.c (m32c_unwind_pc): Delete.
 881         (m32c_unwind_sp): Delete.
 882         (m32c_dummy_id): Delete.
 883         (m32c_gdbarch_init): Don't register deleted functions with
 884         gdbarch.
 885
 886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 889         (lm32_unwind_pc): Delete.
 890         (lm32_dummy_id): Delete.
 891         (lm32_gdbarch_init): Don't register deleted functions with
 892         gdbarch.
 893
 894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 897         (iq2000_unwind_pc): Delete.
 898         (iq2000_dummy_id): Delete.
 899         (iq2000_gdbarch_init): Don't register deleted functions with
 900         gdbarch.
 901
 902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * nds32-tdep.c (nds32_type_align): Delete.
 905         (nds32_push_dummy_call): Use type_align instead.
 906
 907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * arm-tdep.c (arm_type_align): Only handle vector override case.
 910         (arm_push_dummy_call): Use type_align.
 911         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 912
 913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 916         case.
 917         (pass_on_stack): Use type_align.
 918         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 919         function.
 920
 921 2019-04-23  Tom Tromey  <tromey@adacore.com>
 922
 923         * dwarf2read.c (line_header::file_name_at): Remove unused
 924         overload.
 925
 926 2019-04-23  Tom de Vries  <tdevries@suse.de>
 927
 928         PR gdb/24438
 929         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 930         invocation.
 931
 932
 933 2019-03-27  Ali Tamur  <tamur@google.com>
 934
 935         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 936         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 937         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 938         (dwarf_expr_context::get_addr_index): Likewise
 939         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 940         (symbol_needs_eval_context::get_addr_index): Likewise
 941         (disassemble_dwarf_expression): Add DW_OP_addrx
 942         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 943         (read_cutu_die_from_dwo): Update comment
 944         (skip_one_die): Add DW_FORM_addrx
 945         (read_attribute_value): Likewise
 946         (var_decode_location): Add DW_OP_addrx
 947         (dwarf2_const_value_attr): Add DW_FORM_addrx
 948         (dump_die_shallow): Likewise
 949         (dwarf2_fetch_constant_bytes): Likewise
 950         (decode_locdesc): Add DW_OP_addrx
 951         (skip_form_bytes): Add DW_FORM_addrx
 952
 953 2019-04-22  Ali Tamur  <tamur@google.com>
 954
 955         * MAINTAINERS (Write After Approval): Add self.
 956
 957 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 958
 959         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 960         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 961         (open_symbol_file_object): Likewise.
 962         (svr4_default_sos): Add info parameter.
 963         (svr4_read_so_list): Likewise.
 964         (svr4_current_sos_direct): Adjust functions calls to pass down
 965         info.
 966         (svr4_current_sos_1): Add info parameter.
 967         (svr4_current_sos): Call get_svr4_info, pass info down to
 968         svr4_current_sos_1.
 969         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 970         get_svr4_info.
 971         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 972         get_svr4_info.
 973         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 974         to get_svr4_info.
 975         (probes_table_remove_objfile_probes): Likewise.
 976         (register_solib_event_probe): Add info parameter.
 977         (solist_update_incremental): Pass info parameter down to
 978         svr4_read_so_list.
 979         (disable_probes_interface): Add info parameter.
 980         (svr4_handle_solib_event): Pass current_program_space to
 981         get_svr4_info.  Adjust disable_probes_interface cleanup.
 982         (svr4_create_probe_breakpoints): Add info parameter, pass it
 983         down to register_solib_event_probe.
 984         (svr4_create_solib_event_breakpoints): Add info parameter,
 985         pass it down to svr4_create_probe_breakpoints.
 986         (enable_break): Pass info down to
 987         svr4_create_solib_event_breakpoints.
 988         (svr4_solib_create_inferior_hook): Pass current_program_space to
 989         get_svr4_info.
 990         (svr4_clear_solib): Likewise.
 991
 992 2019-04-22  Pedro Alves  <palves@redhat.com>
 993
 994         * solib-svr4.c (svr4_free_objfile_observer): New.
 995         (probe_and_action::objfile): New field.
 996         (probes_table_htab_remove_objfile_probes)
 997         (probes_table_remove_objfile_probes): New functions.
 998         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 999         in the new probe_and_action.  Don't store the probe in 'lookup'.
1000         (svr4_create_probe_breakpoints): Pass objfile to
1001         register_solib_event_probe.
1002         (_initialize_svr4_solib): Register a free_objfile observer.
1003
1004 2019-04-19  Tom Tromey  <tom@tromey.com>
1005
1006         * common/queue.h: Remove.
1007
1008 2019-04-19  Tom Tromey  <tom@tromey.com>
1009
1010         * event-loop.c: Don't include "common/queue.h".
1011
1012 2019-04-19  Tom Tromey  <tom@tromey.com>
1013
1014         * remote.c (remote_target): Use delete.
1015         * remote-notif.h: Include <list>, not "common/queue.h".
1016         (notif_client_p): Remove typedef.
1017         (remote_notif_state): Add constructor, destructor, initializer.
1018         <notif_queue>: Now a std::list.
1019         (remote_notif_state_xfree): Don't declare.
1020         * remote-notif.c (remote_notif_process, handle_notification)
1021         (remote_notif_state_allocate): Update.
1022         (~remote_notif_state): Rename from remote_notif_state_xfree.
1023
1024 2019-04-19  Tom Tromey  <tom@tromey.com>
1025
1026         * symfile.c (reread_symbols): Update.
1027         * objfiles.c (objfile_register_static_link)
1028         (objfile_lookup_static_link): Update
1029         (~objfile) Don't delete static_links.
1030         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1031
1032 2019-04-19  Tom Tromey  <tom@tromey.com>
1033
1034         * type-stack.h (struct type_stack) <insert>: Constify string.
1035         * type-stack.c (type_stack::insert): Constify string.
1036         * gdbtypes.h (lookup_template_type): Update.
1037         (address_space_name_to_int): Update.
1038         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1039         const.
1040         (lookup_template_type): Make name const.
1041         * c-exp.y: Update rules.
1042         (lex_one_token, classify_name, classify_inner_name)
1043         (c_print_token): Update.
1044         * p-exp.y: Update rules.
1045         (yylex): Update.
1046         * f-exp.y: Update rules.
1047         (yylex): Update.
1048         * d-exp.y: Update rules.
1049         (lex_one_token, classify_name, classify_inner_name): Update.
1050         * parse.c (write_dollar_variable, copy_name): Return std::string.
1051         * parser-defs.h (copy_name): Change return type.
1052         * m2-exp.y: Update rules.
1053         (yylex): Update.
1054         * go-exp.y (lex_one_token): Update.
1055         Update rules.
1056         (classify_unsafe_function, classify_packaged_name)
1057         (classify_name, yylex): Update.
1058
1059 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1060
1061         * configure.ac: add --enable-source-highlight switch.
1062         * configure: Regenerate.
1063         * top.c (print_gdb_version): plumb --enable-source-highlight
1064         status to "show configuration".
1065
1066 2019-04-19  Tom Tromey  <tromey@adacore.com>
1067
1068         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1069         Check ADA_TYPE_P.
1070         (empty_record, ada_template_to_fixed_record_type_1)
1071         (template_to_static_fixed_type)
1072         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1073         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1074         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1075         macros.
1076
1077 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1078
1079         PR symtab/24423:
1080         * source.c (print_source_lines_base): Advance "iter" when a
1081         control character is seen.
1082
1083 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1084
1085         * inferior.h (struct infcall_suspend_state_deleter):
1086         Catch exception in destructor to avoid crash.
1087
1088 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1089
1090         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1091         close to the add_com "shell".
1092
1093 2019-04-18  Tom Tromey  <tromey@adacore.com>
1094
1095         * process-stratum-target.h (class process_stratum_target)
1096         <stratum>: Add "final".
1097
1098 2019-04-17  Tom Tromey  <tromey@adacore.com>
1099
1100         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1101         against nullptr before use.
1102
1103 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1104
1105         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1106
1107 2019-04-17  Jim Wilson  <jimw@sifive.com>
1108             Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1111         code read might fail, assume 4-byte breakpoint in that case.
1112
1113 2019-04-15  Leszek Swirski  <leszeks@google.com>
1114
1115         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1116         rather than a hand-rolled POD check when checking for forced MEMORY
1117         classification.
1118
1119 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1120
1121         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1122         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1123         function.
1124         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1125         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1126         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1127         declaration.
1128
1129 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1130
1131         * aarch64-linux-nat.c
1132         (aarch64_linux_nat_target::thread_architecture): Add override.
1133         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1134         each VQ.
1135
1136 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1139
1140 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1143         target types of size 96-bits, add some additional comments, and
1144         check that the builtin type we found was the correct size.
1145
1146 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1147
1148         * utils.c (prompt_for_continue): Don't restore the styling at the
1149         end, as applied_style has the wrong value.  This fixes styling in
1150         long lists of file names that are interrupted by the "Continue?"
1151         prompt.
1152
1153 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1156         * c-lang.c (c_language_defn): Likewise.
1157         (cplus_language_defn): Likewise.
1158         (asm_language_defn): Likewise.
1159         (minimal_language_defn): Likewise.
1160         * d-lang.c (d_language_defn): Likewise.
1161         * f-lang.c (f_language_defn): Likewise.
1162         * go-lang.c (go_language_defn): Likewise.
1163         * language.c (unknown_language_defn): Likewise.
1164         (auto_language_defn): Likewise.
1165         * language.h (struct language_defn): Remove la_magic field.
1166         (LANG_MAGIC): Delete.
1167         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1168         * objc-lang.c (objc_language_defn): Likewise.
1169         * opencl-lang.c (opencl_language_defn): Likewise.
1170         * p-lang.c (pascal_language_defn): Likewise.
1171         * rust-lang.c (rust_language_defn): Likewise.
1172
1173 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * riscv-tdep.c (riscv_type_align): New function.
1176         (riscv_type_alignment): Delete.
1177         (riscv_arg_location): Use 'type_align'.
1178         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1179
1180 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * gdbtypes.c (type_align): A struct with no non-static fields also
1183         has alignment of 1.
1184
1185 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1188         component to 0.
1189         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1190         member.
1191         (riscv_struct_info::analyse): New implementation using new
1192         analyse_inner member function.
1193         (riscv_struct_info::field_offset): New member function.
1194         (riscv_struct_info::m_offsets): New member variable.
1195         (riscv_struct_info::analyse_inner): New private member function,
1196         takes the old implementation of riscv_struct_info::analyse but
1197         extended to track field offsets.
1198         (riscv_call_arg_struct): Update the struct folding special cases
1199         to handle cases where empty C++ structs, which are non-zero
1200         length, are found.
1201         (riscv_arg_location): Initialise the length of each location, a
1202         non-zero length now indicates the location is in use.
1203         (riscv_push_dummy_call): Allow for the first location having a
1204         non-zero offset when setting up arguments.
1205         (riscv_return_value): Likewise, but for return values.
1206
1207 2019-04-11  Tom Tromey  <tromey@adacore.com>
1208
1209         * utils.c (internal_vproblem): Make "msg" const.
1210
1211 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1212
1213         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1214         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1215         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1216         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1217
1218 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1219
1220         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1221         function.
1222         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1223         of amd64_collect_native_gregset.
1224         (amd64_linux_nat_target::store_registers): Likewise.
1225
1226 2019-04-10  Tom Tromey  <tom@tromey.com>
1227
1228         * symtab.c (lookup_global_symbol_from_objfile)
1229         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1230         * objfiles.h (class separate_debug_iterator): New.
1231         (class separate_debug_range): New.
1232         (struct objfile) <separate_debug_objfiles>: New method.
1233         (objfile_separate_debug_iterate): Don't declare.
1234         * objfiles.c (separate_debug_iterator::operator++): Rename from
1235         objfile_separate_debug_iterate.
1236         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1237         iterator.
1238         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1239         iterator.
1240
1241 2019-04-10  Tom Tromey  <tom@tromey.com>
1242
1243         * symfile.c (reread_symbols): Remove old comment.
1244         * objfiles.c (free_all_objfiles): Fix a typo.
1245
1246 2019-04-10  Tom Tromey  <tom@tromey.com>
1247
1248         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1249         * minsyms.c (lookup_minimal_symbol): Use foreach.
1250         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1251         (lookup_minimal_symbol_solib_trampoline): Likewise.
1252         * symfile.c (reread_symbols): Use foreach.
1253
1254 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1255             Tom Tromey  <tromey@adacore.com>
1256
1257         PR rust/24414:
1258         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1259         (rust_lex_int_test): Change "value" to be LONGEST.
1260         (rust_lex_tests): Add test for long integer literal.
1261
1262 2019-04-09  Tom Tromey  <tromey@adacore.com>
1263
1264         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1265         to bool.
1266         (extended_remote_target::attach): Update.
1267         (remote_target::remote_notice_new_inferior): Update.
1268         (remote_target::add_current_inferior_and_thread): Update.
1269         * inferior.c (exit_inferior_1): Use "false".
1270         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1271
1272 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1273
1274         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1275         the "start" command.
1276
1277 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1278
1279         * python/py-inferior.c (infpy_thread_from_thread_handle):
1280         Adjust comments to reflect renaming of thread_from_thread_handle
1281         to thread_from_handle.  Adjust keywords.  Fix type error message.
1282         (inferior_object_methods): Add thread_from_handle.  Retain
1283         thread_from_thread_handle, but mark it as deprecated.
1284
1285 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1286
1287         * gdbthread.h (find_thread_by_handle): Revise declaration.
1288         * thread.c (find_thread_by_handle): Likewise.  Adjust
1289         implementation too.
1290         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1291         support for buffer objects as handles.
1292
1293 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1294
1295         * python/py-infthread.c (thpy_thread_handle): New function.
1296         (thread_object_methods): Register thpy_thread_handle.
1297
1298 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1299
1300         * gdbthread.h (thread_to_thread_handle): Declare.
1301         * thread.c (gdbtypes.h): Include.
1302         (thread_to_thread_handle): New function.
1303
1304         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1305         (target_thread_info_to_thread_handle): Declare.
1306         * target.c (target_thread_info_to_thread_handle): New function.
1307         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1308         * target-delegates.c: Regenerate.
1309
1310         * linux-thread-db.c (class thread_db_target): Add method
1311         thread_info_to_thread_handle.
1312         (thread_db_target::thread_info_to_thread_handle): Define.
1313         * remote.c (class remote_target): Add new method
1314         thread_info_to_thread_handle.
1315         (remote_target::thread_info_to_thread_handle): Define.
1316
1317 2019-04-08  Pedro Alves  <palves@redhat.com>
1318
1319         * common/common-exceptions.c (throw_exception): Don't create
1320         named object to throw; throw directly.
1321         (throw_it): Likewise.  Don't initialize gdb_exception::message
1322         here, with new; pass FMT and AP to the ctor instead.
1323         * common/common-exceptions.h: Include <string>.
1324         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1325         const char *, va_list)): New ctor.  Use std::make_shared.
1326         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1327         errors)): Delete.
1328         (gdb_exception_error::gdb_exception_error(enum errors, const char
1329         *, va_list)): New.
1330         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1331         Add assertion.
1332         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1333         errors)): Delete.
1334         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1335         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1336         Add assertion.
1337
1338 2019-04-08  Tom Tromey  <tom@tromey.com>
1339
1340         * valops.c (value_rtti_indirect_type): Replace throw_exception
1341         with throw.
1342         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1343         with throw.
1344         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1345         throw.
1346         * target.c (target_translate_tls_address): Replace throw_exception
1347         with throw.
1348         * stack.c (frame_apply_command_count): Replace throw_exception
1349         with throw.
1350         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1351         throw.
1352         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1353         with throw.
1354         * rs6000-tdep.c (rs6000_frame_cache)
1355         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1356         * remote.c: Replace throw_exception with throw.
1357         * record-full.c (record_full_message, record_full_wait_1)
1358         (record_full_restore): Replace throw_exception with throw.
1359         * record-btrace.c:
1360         (get_thread_current_frame_id, record_btrace_start_replaying)
1361         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1362         (cmd_record_btrace_start): Replace throw_exception with throw.
1363         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1364         throw.
1365         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1366         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1367         * linespec.c:
1368         (find_linespec_symbols): Replace throw_exception with throw.
1369         * infrun.c (displaced_step_prepare, resume): Replace
1370         throw_exception with throw.
1371         * infcmd.c (post_create_inferior): Replace throw_exception with
1372         throw.
1373         * inf-loop.c (inferior_event_handler): Replace throw_exception
1374         with throw.
1375         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1376         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1377         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1378         (get_prev_frame_always, get_frame_pc_if_available)
1379         (get_frame_address_in_block_if_available, get_frame_language):
1380         Replace throw_exception with throw.
1381         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1382         throw_exception with throw.
1383         * eval.c (fetch_subexp_value, evaluate_var_value)
1384         (evaluate_funcall, evaluate_subexp_standard): Replace
1385         throw_exception with throw.
1386         * dwarf2loc.c (call_site_find_chain)
1387         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1388         Replace throw_exception with throw.
1389         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1390         with throw.
1391         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1392         throw.
1393         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1394         * completer.c (complete_line_internal): Replace throw_exception
1395         with throw.
1396         * compile/compile-object-run.c (compile_object_run): Replace
1397         throw_exception with throw.
1398         * cli/cli-script.c (process_next_line): Replace throw_exception
1399         with throw.
1400         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1401         (btrace_enable, btrace_maint_update_pt_packets): Replace
1402         throw_exception with throw.
1403         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1404         throw_exception with throw.
1405         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1406         throw_exception with throw.
1407         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1408         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1409         * aarch64-tdep.c (aarch64_make_prologue_cache)
1410         (aarch64_make_stub_cache): Replace throw_exception with throw.
1411
1412 2019-04-08  Tom Tromey  <tom@tromey.com>
1413
1414         * common/common-exceptions.c (throw_exception): Rename from
1415         throw_exception_cxx.  Remove old copy.  Make argument const.
1416         (throw_it): Create and throw exception objects directly.
1417         * common/common-exceptions.h (throw_exception): Make argument
1418         const.
1419         (struct gdb_exception_error): Add constructor.
1420         (struct gdb_exception_quit): Add constructor.
1421
1422 2019-04-08  Tom Tromey  <tom@tromey.com>
1423
1424         * common/common-exceptions.h (exception_rethrow): Don't declare.
1425         (TRY_SJLJ): Update comment.
1426         (TRY, CATCH, END_CATCH): Remove.
1427         * common/common-exceptions.c (exception_rethrow): Remove.
1428
1429 2019-04-08  Tom Tromey  <tom@tromey.com>
1430
1431         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1432         Remove.
1433         (gdb_exception_error): Rename from
1434         gdb_exception_RETURN_MASK_ERROR.
1435         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1436         (gdb_quit_bad_alloc): Update.
1437         * aarch64-tdep.c: Update.
1438         * ada-lang.c: Update.
1439         * ada-typeprint.c: Update.
1440         * ada-valprint.c: Update.
1441         * amd64-tdep.c: Update.
1442         * arch-utils.c: Update.
1443         * break-catch-throw.c: Update.
1444         * breakpoint.c: Update.
1445         * btrace.c: Update.
1446         * c-varobj.c: Update.
1447         * cli/cli-cmds.c: Update.
1448         * cli/cli-interp.c: Update.
1449         * cli/cli-script.c: Update.
1450         * common/common-exceptions.c: Update.
1451         * common/new-op.c: Update.
1452         * common/selftest.c: Update.
1453         * compile/compile-c-symbols.c: Update.
1454         * compile/compile-cplus-symbols.c: Update.
1455         * compile/compile-object-load.c: Update.
1456         * compile/compile-object-run.c: Update.
1457         * completer.c: Update.
1458         * corelow.c: Update.
1459         * cp-abi.c: Update.
1460         * cp-support.c: Update.
1461         * cp-valprint.c: Update.
1462         * darwin-nat.c: Update.
1463         * disasm-selftests.c: Update.
1464         * dtrace-probe.c: Update.
1465         * dwarf-index-cache.c: Update.
1466         * dwarf-index-write.c: Update.
1467         * dwarf2-frame-tailcall.c: Update.
1468         * dwarf2-frame.c: Update.
1469         * dwarf2loc.c: Update.
1470         * dwarf2read.c: Update.
1471         * eval.c: Update.
1472         * event-loop.c: Update.
1473         * event-top.c: Update.
1474         * exec.c: Update.
1475         * f-valprint.c: Update.
1476         * fbsd-tdep.c: Update.
1477         * frame-unwind.c: Update.
1478         * frame.c: Update.
1479         * gdbtypes.c: Update.
1480         * gnu-v3-abi.c: Update.
1481         * guile/guile-internal.h: Update.
1482         * guile/scm-block.c: Update.
1483         * guile/scm-breakpoint.c: Update.
1484         * guile/scm-cmd.c: Update.
1485         * guile/scm-disasm.c: Update.
1486         * guile/scm-frame.c: Update.
1487         * guile/scm-lazy-string.c: Update.
1488         * guile/scm-math.c: Update.
1489         * guile/scm-param.c: Update.
1490         * guile/scm-ports.c: Update.
1491         * guile/scm-pretty-print.c: Update.
1492         * guile/scm-symbol.c: Update.
1493         * guile/scm-symtab.c: Update.
1494         * guile/scm-type.c: Update.
1495         * guile/scm-value.c: Update.
1496         * i386-linux-tdep.c: Update.
1497         * i386-tdep.c: Update.
1498         * inf-loop.c: Update.
1499         * infcall.c: Update.
1500         * infcmd.c: Update.
1501         * infrun.c: Update.
1502         * jit.c: Update.
1503         * language.c: Update.
1504         * linespec.c: Update.
1505         * linux-fork.c: Update.
1506         * linux-nat.c: Update.
1507         * linux-tdep.c: Update.
1508         * linux-thread-db.c: Update.
1509         * main.c: Update.
1510         * mi/mi-cmd-break.c: Update.
1511         * mi/mi-cmd-stack.c: Update.
1512         * mi/mi-interp.c: Update.
1513         * mi/mi-main.c: Update.
1514         * objc-lang.c: Update.
1515         * p-valprint.c: Update.
1516         * parse.c: Update.
1517         * ppc-linux-tdep.c: Update.
1518         * printcmd.c: Update.
1519         * python/py-arch.c: Update.
1520         * python/py-breakpoint.c: Update.
1521         * python/py-cmd.c: Update.
1522         * python/py-finishbreakpoint.c: Update.
1523         * python/py-frame.c: Update.
1524         * python/py-framefilter.c: Update.
1525         * python/py-gdb-readline.c: Update.
1526         * python/py-inferior.c: Update.
1527         * python/py-infthread.c: Update.
1528         * python/py-lazy-string.c: Update.
1529         * python/py-linetable.c: Update.
1530         * python/py-objfile.c: Update.
1531         * python/py-param.c: Update.
1532         * python/py-prettyprint.c: Update.
1533         * python/py-progspace.c: Update.
1534         * python/py-record-btrace.c: Update.
1535         * python/py-record.c: Update.
1536         * python/py-symbol.c: Update.
1537         * python/py-type.c: Update.
1538         * python/py-unwind.c: Update.
1539         * python/py-utils.c: Update.
1540         * python/py-value.c: Update.
1541         * python/python.c: Update.
1542         * record-btrace.c: Update.
1543         * record-full.c: Update.
1544         * remote-fileio.c: Update.
1545         * remote.c: Update.
1546         * riscv-tdep.c: Update.
1547         * rs6000-aix-tdep.c: Update.
1548         * rs6000-tdep.c: Update.
1549         * rust-exp.y: Update.
1550         * rust-lang.c: Update.
1551         * s390-tdep.c: Update.
1552         * selftest-arch.c: Update.
1553         * solib-dsbt.c: Update.
1554         * solib-frv.c: Update.
1555         * solib-spu.c: Update.
1556         * solib-svr4.c: Update.
1557         * solib.c: Update.
1558         * sparc64-linux-tdep.c: Update.
1559         * stack.c: Update.
1560         * symfile-mem.c: Update.
1561         * symmisc.c: Update.
1562         * target.c: Update.
1563         * thread.c: Update.
1564         * top.c: Update.
1565         * tracefile-tfile.c: Update.
1566         * tui/tui.c: Update.
1567         * typeprint.c: Update.
1568         * unittests/cli-utils-selftests.c: Update.
1569         * unittests/parse-connection-spec-selftests.c: Update.
1570         * valops.c: Update.
1571         * valprint.c: Update.
1572         * value.c: Update.
1573         * varobj.c: Update.
1574         * windows-nat.c: Update.
1575         * x86-linux-nat.c: Update.
1576         * xml-support.c: Update.
1577
1578 2019-04-08  Tom Tromey  <tom@tromey.com>
1579
1580         * xml-support.c: Use C++ exception handling.
1581         * x86-linux-nat.c: Use C++ exception handling.
1582         * windows-nat.c: Use C++ exception handling.
1583         * varobj.c: Use C++ exception handling.
1584         * value.c: Use C++ exception handling.
1585         * valprint.c: Use C++ exception handling.
1586         * valops.c: Use C++ exception handling.
1587         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1588         handling.
1589         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1590         * typeprint.c: Use C++ exception handling.
1591         * tui/tui.c: Use C++ exception handling.
1592         * tracefile-tfile.c: Use C++ exception handling.
1593         * top.c: Use C++ exception handling.
1594         * thread.c: Use C++ exception handling.
1595         * target.c: Use C++ exception handling.
1596         * symmisc.c: Use C++ exception handling.
1597         * symfile-mem.c: Use C++ exception handling.
1598         * stack.c: Use C++ exception handling.
1599         * sparc64-linux-tdep.c: Use C++ exception handling.
1600         * solib.c: Use C++ exception handling.
1601         * solib-svr4.c: Use C++ exception handling.
1602         * solib-spu.c: Use C++ exception handling.
1603         * solib-frv.c: Use C++ exception handling.
1604         * solib-dsbt.c: Use C++ exception handling.
1605         * selftest-arch.c: Use C++ exception handling.
1606         * s390-tdep.c: Use C++ exception handling.
1607         * rust-lang.c: Use C++ exception handling.
1608         * rust-exp.y: Use C++ exception handling.
1609         * rs6000-tdep.c: Use C++ exception handling.
1610         * rs6000-aix-tdep.c: Use C++ exception handling.
1611         * riscv-tdep.c: Use C++ exception handling.
1612         * remote.c: Use C++ exception handling.
1613         * remote-fileio.c: Use C++ exception handling.
1614         * record-full.c: Use C++ exception handling.
1615         * record-btrace.c: Use C++ exception handling.
1616         * python/python.c: Use C++ exception handling.
1617         * python/py-value.c: Use C++ exception handling.
1618         * python/py-utils.c: Use C++ exception handling.
1619         * python/py-unwind.c: Use C++ exception handling.
1620         * python/py-type.c: Use C++ exception handling.
1621         * python/py-symbol.c: Use C++ exception handling.
1622         * python/py-record.c: Use C++ exception handling.
1623         * python/py-record-btrace.c: Use C++ exception handling.
1624         * python/py-progspace.c: Use C++ exception handling.
1625         * python/py-prettyprint.c: Use C++ exception handling.
1626         * python/py-param.c: Use C++ exception handling.
1627         * python/py-objfile.c: Use C++ exception handling.
1628         * python/py-linetable.c: Use C++ exception handling.
1629         * python/py-lazy-string.c: Use C++ exception handling.
1630         * python/py-infthread.c: Use C++ exception handling.
1631         * python/py-inferior.c: Use C++ exception handling.
1632         * python/py-gdb-readline.c: Use C++ exception handling.
1633         * python/py-framefilter.c: Use C++ exception handling.
1634         * python/py-frame.c: Use C++ exception handling.
1635         * python/py-finishbreakpoint.c: Use C++ exception handling.
1636         * python/py-cmd.c: Use C++ exception handling.
1637         * python/py-breakpoint.c: Use C++ exception handling.
1638         * python/py-arch.c: Use C++ exception handling.
1639         * printcmd.c: Use C++ exception handling.
1640         * ppc-linux-tdep.c: Use C++ exception handling.
1641         * parse.c: Use C++ exception handling.
1642         * p-valprint.c: Use C++ exception handling.
1643         * objc-lang.c: Use C++ exception handling.
1644         * mi/mi-main.c: Use C++ exception handling.
1645         * mi/mi-interp.c: Use C++ exception handling.
1646         * mi/mi-cmd-stack.c: Use C++ exception handling.
1647         * mi/mi-cmd-break.c: Use C++ exception handling.
1648         * main.c: Use C++ exception handling.
1649         * linux-thread-db.c: Use C++ exception handling.
1650         * linux-tdep.c: Use C++ exception handling.
1651         * linux-nat.c: Use C++ exception handling.
1652         * linux-fork.c: Use C++ exception handling.
1653         * linespec.c: Use C++ exception handling.
1654         * language.c: Use C++ exception handling.
1655         * jit.c: Use C++ exception handling.
1656         * infrun.c: Use C++ exception handling.
1657         * infcmd.c: Use C++ exception handling.
1658         * infcall.c: Use C++ exception handling.
1659         * inf-loop.c: Use C++ exception handling.
1660         * i386-tdep.c: Use C++ exception handling.
1661         * i386-linux-tdep.c: Use C++ exception handling.
1662         * guile/scm-value.c: Use C++ exception handling.
1663         * guile/scm-type.c: Use C++ exception handling.
1664         * guile/scm-symtab.c: Use C++ exception handling.
1665         * guile/scm-symbol.c: Use C++ exception handling.
1666         * guile/scm-pretty-print.c: Use C++ exception handling.
1667         * guile/scm-ports.c: Use C++ exception handling.
1668         * guile/scm-param.c: Use C++ exception handling.
1669         * guile/scm-math.c: Use C++ exception handling.
1670         * guile/scm-lazy-string.c: Use C++ exception handling.
1671         * guile/scm-frame.c: Use C++ exception handling.
1672         * guile/scm-disasm.c: Use C++ exception handling.
1673         * guile/scm-cmd.c: Use C++ exception handling.
1674         * guile/scm-breakpoint.c: Use C++ exception handling.
1675         * guile/scm-block.c: Use C++ exception handling.
1676         * guile/guile-internal.h: Use C++ exception handling.
1677         * gnu-v3-abi.c: Use C++ exception handling.
1678         * gdbtypes.c: Use C++ exception handling.
1679         * frame.c: Use C++ exception handling.
1680         * frame-unwind.c: Use C++ exception handling.
1681         * fbsd-tdep.c: Use C++ exception handling.
1682         * f-valprint.c: Use C++ exception handling.
1683         * exec.c: Use C++ exception handling.
1684         * event-top.c: Use C++ exception handling.
1685         * event-loop.c: Use C++ exception handling.
1686         * eval.c: Use C++ exception handling.
1687         * dwarf2read.c: Use C++ exception handling.
1688         * dwarf2loc.c: Use C++ exception handling.
1689         * dwarf2-frame.c: Use C++ exception handling.
1690         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1691         * dwarf-index-write.c: Use C++ exception handling.
1692         * dwarf-index-cache.c: Use C++ exception handling.
1693         * dtrace-probe.c: Use C++ exception handling.
1694         * disasm-selftests.c: Use C++ exception handling.
1695         * darwin-nat.c: Use C++ exception handling.
1696         * cp-valprint.c: Use C++ exception handling.
1697         * cp-support.c: Use C++ exception handling.
1698         * cp-abi.c: Use C++ exception handling.
1699         * corelow.c: Use C++ exception handling.
1700         * completer.c: Use C++ exception handling.
1701         * compile/compile-object-run.c: Use C++ exception handling.
1702         * compile/compile-object-load.c: Use C++ exception handling.
1703         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1704         * compile/compile-c-symbols.c: Use C++ exception handling.
1705         * common/selftest.c: Use C++ exception handling.
1706         * common/new-op.c: Use C++ exception handling.
1707         * cli/cli-script.c: Use C++ exception handling.
1708         * cli/cli-interp.c: Use C++ exception handling.
1709         * cli/cli-cmds.c: Use C++ exception handling.
1710         * c-varobj.c: Use C++ exception handling.
1711         * btrace.c: Use C++ exception handling.
1712         * breakpoint.c: Use C++ exception handling.
1713         * break-catch-throw.c: Use C++ exception handling.
1714         * arch-utils.c: Use C++ exception handling.
1715         * amd64-tdep.c: Use C++ exception handling.
1716         * ada-valprint.c: Use C++ exception handling.
1717         * ada-typeprint.c: Use C++ exception handling.
1718         * ada-lang.c: Use C++ exception handling.
1719         * aarch64-tdep.c: Use C++ exception handling.
1720
1721 2019-04-08  Tom Tromey  <tom@tromey.com>
1722
1723         * xml-support.c (gdb_xml_parser::parse): Update.
1724         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1725         * value.c (show_convenience): Update.
1726         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1727         (test_parse_flags_qcs): Update.
1728         * thread.c (thr_try_catch_cmd): Update.
1729         * target.c (target_translate_tls_address): Update.
1730         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1731         (info_frame_command_core, frame_apply_command_count): Update.
1732         * rust-exp.y (rust_lex_exception_test): Update.
1733         * riscv-tdep.c (riscv_print_one_register_info): Update.
1734         * remote.c (remote_target::enable_btrace): Update.
1735         * record-btrace.c (record_btrace_enable_warn): Update.
1736         * python/py-utils.c (gdbpy_convert_exception): Update.
1737         * printcmd.c (do_one_display, print_variable_and_value): Update.
1738         * mi/mi-main.c (mi_print_exception): Update.
1739         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1740         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1741         * linux-nat.c (linux_nat_target::attach): Update.
1742         * linux-fork.c (class scoped_switch_fork_info): Update.
1743         * infrun.c (displaced_step_prepare): Update.
1744         * infcall.c (call_function_by_hand_dummy): Update.
1745         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1746         * gnu-v3-abi.c (print_one_vtable): Update.
1747         * frame.c (get_prev_frame_always): Update.
1748         * f-valprint.c (info_common_command_for_block): Update.
1749         * exec.c (try_open_exec_file): Update.
1750         * exceptions.c (print_exception, exception_print)
1751         (exception_fprintf, exception_print_same): Update.
1752         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1753         * dwarf-index-cache.c (index_cache::store)
1754         (index_cache::lookup_gdb_index): Update.
1755         * darwin-nat.c (maybe_cache_shell): Update.
1756         * cp-valprint.c (cp_print_value_fields): Update.
1757         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1758         (gcc_cplus_symbol_address): Update.
1759         * compile/compile-c-symbols.c (gcc_convert_symbol)
1760         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1761         * common/selftest.c: Update.
1762         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1763         a std::string.
1764         (exception_try_scope_entry, exception_try_scope_exit): Don't
1765         declare.
1766         (struct exception_try_scope): Remove.
1767         (TRY): Don't use exception_try_scope.
1768         (struct gdb_exception): Add constructor, operator=.
1769         <what>: New method.
1770         (struct gdb_exception_RETURN_MASK_ALL)
1771         (struct gdb_exception_RETURN_MASK_ERROR)
1772         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1773         (struct gdb_quit_bad_alloc): Update.
1774         * common/common-exceptions.c (exception_none): Change
1775         initializer.
1776         (struct catcher) <state, exception>: Initialize inline.
1777         <prev>: Remove member.
1778         (current_catcher): Remove.
1779         (catchers): New global.
1780         (exceptions_state_mc_init): Simplify.
1781         (catcher_pop): Remove.
1782         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1783         (try_scope_depth, exception_try_scope_entry)
1784         (exception_try_scope_exit): Remove.
1785         (throw_exception_sjlj): Update.
1786         (exception_messages, exception_messages_size): Remove.
1787         (throw_it): Simplify.
1788         (gdb_exception_sliced_copy): Remove.
1789         (throw_exception_cxx): Update.
1790         * cli/cli-script.c (script_from_file): Update.
1791         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1792         Update.
1793         * ada-valprint.c (ada_val_print): Update.
1794         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1795         (create_excep_cond_exprs): Update.
1796
1797 2019-04-08  Tom Tromey  <tom@tromey.com>
1798
1799         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1800         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1801         (TRY, CATCH, END_CATCH): Remove some definitions.
1802         * common/common-exceptions.c: Don't use GDB_XCPT.
1803         (catcher_list_size): Remove.
1804         (throw_exception, throw_it): Simplify.
1805
1806 2019-04-05  Tom Tromey  <tom@tromey.com>
1807
1808         Revert the header-sorting patch.
1809         * ft32-tdep.c: Revert.
1810         * frv-tdep.c: Revert.
1811         * frv-linux-tdep.c: Revert.
1812         * frame.c: Revert.
1813         * frame-unwind.c: Revert.
1814         * frame-base.c: Revert.
1815         * fork-child.c: Revert.
1816         * findvar.c: Revert.
1817         * findcmd.c: Revert.
1818         * filesystem.c: Revert.
1819         * filename-seen-cache.h: Revert.
1820         * filename-seen-cache.c: Revert.
1821         * fbsd-tdep.c: Revert.
1822         * fbsd-nat.h: Revert.
1823         * fbsd-nat.c: Revert.
1824         * f-valprint.c: Revert.
1825         * f-typeprint.c: Revert.
1826         * f-lang.c: Revert.
1827         * extension.h: Revert.
1828         * extension.c: Revert.
1829         * extension-priv.h: Revert.
1830         * expprint.c: Revert.
1831         * exec.h: Revert.
1832         * exec.c: Revert.
1833         * exceptions.c: Revert.
1834         * event-top.c: Revert.
1835         * event-loop.c: Revert.
1836         * eval.c: Revert.
1837         * elfread.c: Revert.
1838         * dwarf2read.h: Revert.
1839         * dwarf2read.c: Revert.
1840         * dwarf2loc.c: Revert.
1841         * dwarf2expr.h: Revert.
1842         * dwarf2expr.c: Revert.
1843         * dwarf2-frame.c: Revert.
1844         * dwarf2-frame-tailcall.c: Revert.
1845         * dwarf-index-write.h: Revert.
1846         * dwarf-index-write.c: Revert.
1847         * dwarf-index-common.c: Revert.
1848         * dwarf-index-cache.h: Revert.
1849         * dwarf-index-cache.c: Revert.
1850         * dummy-frame.c: Revert.
1851         * dtrace-probe.c: Revert.
1852         * disasm.h: Revert.
1853         * disasm.c: Revert.
1854         * disasm-selftests.c: Revert.
1855         * dictionary.c: Revert.
1856         * dicos-tdep.c: Revert.
1857         * demangle.c: Revert.
1858         * dcache.h: Revert.
1859         * dcache.c: Revert.
1860         * darwin-nat.h: Revert.
1861         * darwin-nat.c: Revert.
1862         * darwin-nat-info.c: Revert.
1863         * d-valprint.c: Revert.
1864         * d-namespace.c: Revert.
1865         * d-lang.c: Revert.
1866         * ctf.c: Revert.
1867         * csky-tdep.c: Revert.
1868         * csky-linux-tdep.c: Revert.
1869         * cris-tdep.c: Revert.
1870         * cris-linux-tdep.c: Revert.
1871         * cp-valprint.c: Revert.
1872         * cp-support.c: Revert.
1873         * cp-namespace.c: Revert.
1874         * cp-abi.c: Revert.
1875         * corelow.c: Revert.
1876         * corefile.c: Revert.
1877         * continuations.c: Revert.
1878         * completer.h: Revert.
1879         * completer.c: Revert.
1880         * complaints.c: Revert.
1881         * coffread.c: Revert.
1882         * coff-pe-read.c: Revert.
1883         * cli-out.h: Revert.
1884         * cli-out.c: Revert.
1885         * charset.c: Revert.
1886         * c-varobj.c: Revert.
1887         * c-valprint.c: Revert.
1888         * c-typeprint.c: Revert.
1889         * c-lang.c: Revert.
1890         * buildsym.c: Revert.
1891         * buildsym-legacy.c: Revert.
1892         * build-id.h: Revert.
1893         * build-id.c: Revert.
1894         * btrace.c: Revert.
1895         * bsd-uthread.c: Revert.
1896         * breakpoint.h: Revert.
1897         * breakpoint.c: Revert.
1898         * break-catch-throw.c: Revert.
1899         * break-catch-syscall.c: Revert.
1900         * break-catch-sig.c: Revert.
1901         * blockframe.c: Revert.
1902         * block.c: Revert.
1903         * bfin-tdep.c: Revert.
1904         * bfin-linux-tdep.c: Revert.
1905         * bfd-target.c: Revert.
1906         * bcache.c: Revert.
1907         * ax-general.c: Revert.
1908         * ax-gdb.h: Revert.
1909         * ax-gdb.c: Revert.
1910         * avr-tdep.c: Revert.
1911         * auxv.c: Revert.
1912         * auto-load.c: Revert.
1913         * arm-wince-tdep.c: Revert.
1914         * arm-tdep.c: Revert.
1915         * arm-symbian-tdep.c: Revert.
1916         * arm-pikeos-tdep.c: Revert.
1917         * arm-obsd-tdep.c: Revert.
1918         * arm-nbsd-tdep.c: Revert.
1919         * arm-nbsd-nat.c: Revert.
1920         * arm-linux-tdep.c: Revert.
1921         * arm-linux-nat.c: Revert.
1922         * arm-fbsd-tdep.c: Revert.
1923         * arm-fbsd-nat.c: Revert.
1924         * arm-bsd-tdep.c: Revert.
1925         * arch-utils.c: Revert.
1926         * arc-tdep.c: Revert.
1927         * arc-newlib-tdep.c: Revert.
1928         * annotate.h: Revert.
1929         * annotate.c: Revert.
1930         * amd64-windows-tdep.c: Revert.
1931         * amd64-windows-nat.c: Revert.
1932         * amd64-tdep.c: Revert.
1933         * amd64-sol2-tdep.c: Revert.
1934         * amd64-obsd-tdep.c: Revert.
1935         * amd64-obsd-nat.c: Revert.
1936         * amd64-nbsd-tdep.c: Revert.
1937         * amd64-nbsd-nat.c: Revert.
1938         * amd64-nat.c: Revert.
1939         * amd64-linux-tdep.c: Revert.
1940         * amd64-linux-nat.c: Revert.
1941         * amd64-fbsd-tdep.c: Revert.
1942         * amd64-fbsd-nat.c: Revert.
1943         * amd64-dicos-tdep.c: Revert.
1944         * amd64-darwin-tdep.c: Revert.
1945         * amd64-bsd-nat.c: Revert.
1946         * alpha-tdep.c: Revert.
1947         * alpha-obsd-tdep.c: Revert.
1948         * alpha-nbsd-tdep.c: Revert.
1949         * alpha-mdebug-tdep.c: Revert.
1950         * alpha-linux-tdep.c: Revert.
1951         * alpha-linux-nat.c: Revert.
1952         * alpha-bsd-tdep.c: Revert.
1953         * alpha-bsd-nat.c: Revert.
1954         * aix-thread.c: Revert.
1955         * agent.c: Revert.
1956         * addrmap.c: Revert.
1957         * ada-varobj.c: Revert.
1958         * ada-valprint.c: Revert.
1959         * ada-typeprint.c: Revert.
1960         * ada-tasks.c: Revert.
1961         * ada-lang.c: Revert.
1962         * aarch64-tdep.c: Revert.
1963         * aarch64-ravenscar-thread.c: Revert.
1964         * aarch64-newlib-tdep.c: Revert.
1965         * aarch64-linux-tdep.c: Revert.
1966         * aarch64-linux-nat.c: Revert.
1967         * aarch64-fbsd-tdep.c: Revert.
1968         * aarch64-fbsd-nat.c: Revert.
1969         * aarch32-linux-nat.c: Revert.
1970
1971 2019-04-05  Tom Tromey  <tom@tromey.com>
1972
1973         * ft32-tdep.c: Sort headers.
1974         * frv-tdep.c: Sort headers.
1975         * frv-linux-tdep.c: Sort headers.
1976         * frame.c: Sort headers.
1977         * frame-unwind.c: Sort headers.
1978         * frame-base.c: Sort headers.
1979         * fork-child.c: Sort headers.
1980         * findvar.c: Sort headers.
1981         * findcmd.c: Sort headers.
1982         * filesystem.c: Sort headers.
1983         * filename-seen-cache.h: Sort headers.
1984         * filename-seen-cache.c: Sort headers.
1985         * fbsd-tdep.c: Sort headers.
1986         * fbsd-nat.h: Sort headers.
1987         * fbsd-nat.c: Sort headers.
1988         * f-valprint.c: Sort headers.
1989         * f-typeprint.c: Sort headers.
1990         * f-lang.c: Sort headers.
1991         * extension.h: Sort headers.
1992         * extension.c: Sort headers.
1993         * extension-priv.h: Sort headers.
1994         * expprint.c: Sort headers.
1995         * exec.h: Sort headers.
1996         * exec.c: Sort headers.
1997         * exceptions.c: Sort headers.
1998         * event-top.c: Sort headers.
1999         * event-loop.c: Sort headers.
2000         * eval.c: Sort headers.
2001         * elfread.c: Sort headers.
2002         * dwarf2read.h: Sort headers.
2003         * dwarf2read.c: Sort headers.
2004         * dwarf2loc.c: Sort headers.
2005         * dwarf2expr.h: Sort headers.
2006         * dwarf2expr.c: Sort headers.
2007         * dwarf2-frame.c: Sort headers.
2008         * dwarf2-frame-tailcall.c: Sort headers.
2009         * dwarf-index-write.h: Sort headers.
2010         * dwarf-index-write.c: Sort headers.
2011         * dwarf-index-common.c: Sort headers.
2012         * dwarf-index-cache.h: Sort headers.
2013         * dwarf-index-cache.c: Sort headers.
2014         * dummy-frame.c: Sort headers.
2015         * dtrace-probe.c: Sort headers.
2016         * disasm.h: Sort headers.
2017         * disasm.c: Sort headers.
2018         * disasm-selftests.c: Sort headers.
2019         * dictionary.c: Sort headers.
2020         * dicos-tdep.c: Sort headers.
2021         * demangle.c: Sort headers.
2022         * dcache.h: Sort headers.
2023         * dcache.c: Sort headers.
2024         * darwin-nat.h: Sort headers.
2025         * darwin-nat.c: Sort headers.
2026         * darwin-nat-info.c: Sort headers.
2027         * d-valprint.c: Sort headers.
2028         * d-namespace.c: Sort headers.
2029         * d-lang.c: Sort headers.
2030         * ctf.c: Sort headers.
2031         * csky-tdep.c: Sort headers.
2032         * csky-linux-tdep.c: Sort headers.
2033         * cris-tdep.c: Sort headers.
2034         * cris-linux-tdep.c: Sort headers.
2035         * cp-valprint.c: Sort headers.
2036         * cp-support.c: Sort headers.
2037         * cp-namespace.c: Sort headers.
2038         * cp-abi.c: Sort headers.
2039         * corelow.c: Sort headers.
2040         * corefile.c: Sort headers.
2041         * continuations.c: Sort headers.
2042         * completer.h: Sort headers.
2043         * completer.c: Sort headers.
2044         * complaints.c: Sort headers.
2045         * coffread.c: Sort headers.
2046         * coff-pe-read.c: Sort headers.
2047         * cli-out.h: Sort headers.
2048         * cli-out.c: Sort headers.
2049         * charset.c: Sort headers.
2050         * c-varobj.c: Sort headers.
2051         * c-valprint.c: Sort headers.
2052         * c-typeprint.c: Sort headers.
2053         * c-lang.c: Sort headers.
2054         * buildsym.c: Sort headers.
2055         * buildsym-legacy.c: Sort headers.
2056         * build-id.h: Sort headers.
2057         * build-id.c: Sort headers.
2058         * btrace.c: Sort headers.
2059         * bsd-uthread.c: Sort headers.
2060         * breakpoint.h: Sort headers.
2061         * breakpoint.c: Sort headers.
2062         * break-catch-throw.c: Sort headers.
2063         * break-catch-syscall.c: Sort headers.
2064         * break-catch-sig.c: Sort headers.
2065         * blockframe.c: Sort headers.
2066         * block.c: Sort headers.
2067         * bfin-tdep.c: Sort headers.
2068         * bfin-linux-tdep.c: Sort headers.
2069         * bfd-target.c: Sort headers.
2070         * bcache.c: Sort headers.
2071         * ax-general.c: Sort headers.
2072         * ax-gdb.h: Sort headers.
2073         * ax-gdb.c: Sort headers.
2074         * avr-tdep.c: Sort headers.
2075         * auxv.c: Sort headers.
2076         * auto-load.c: Sort headers.
2077         * arm-wince-tdep.c: Sort headers.
2078         * arm-tdep.c: Sort headers.
2079         * arm-symbian-tdep.c: Sort headers.
2080         * arm-pikeos-tdep.c: Sort headers.
2081         * arm-obsd-tdep.c: Sort headers.
2082         * arm-nbsd-tdep.c: Sort headers.
2083         * arm-nbsd-nat.c: Sort headers.
2084         * arm-linux-tdep.c: Sort headers.
2085         * arm-linux-nat.c: Sort headers.
2086         * arm-fbsd-tdep.c: Sort headers.
2087         * arm-fbsd-nat.c: Sort headers.
2088         * arm-bsd-tdep.c: Sort headers.
2089         * arch-utils.c: Sort headers.
2090         * arc-tdep.c: Sort headers.
2091         * arc-newlib-tdep.c: Sort headers.
2092         * annotate.h: Sort headers.
2093         * annotate.c: Sort headers.
2094         * amd64-windows-tdep.c: Sort headers.
2095         * amd64-windows-nat.c: Sort headers.
2096         * amd64-tdep.c: Sort headers.
2097         * amd64-sol2-tdep.c: Sort headers.
2098         * amd64-obsd-tdep.c: Sort headers.
2099         * amd64-obsd-nat.c: Sort headers.
2100         * amd64-nbsd-tdep.c: Sort headers.
2101         * amd64-nbsd-nat.c: Sort headers.
2102         * amd64-nat.c: Sort headers.
2103         * amd64-linux-tdep.c: Sort headers.
2104         * amd64-linux-nat.c: Sort headers.
2105         * amd64-fbsd-tdep.c: Sort headers.
2106         * amd64-fbsd-nat.c: Sort headers.
2107         * amd64-dicos-tdep.c: Sort headers.
2108         * amd64-darwin-tdep.c: Sort headers.
2109         * amd64-bsd-nat.c: Sort headers.
2110         * alpha-tdep.c: Sort headers.
2111         * alpha-obsd-tdep.c: Sort headers.
2112         * alpha-nbsd-tdep.c: Sort headers.
2113         * alpha-mdebug-tdep.c: Sort headers.
2114         * alpha-linux-tdep.c: Sort headers.
2115         * alpha-linux-nat.c: Sort headers.
2116         * alpha-bsd-tdep.c: Sort headers.
2117         * alpha-bsd-nat.c: Sort headers.
2118         * aix-thread.c: Sort headers.
2119         * agent.c: Sort headers.
2120         * addrmap.c: Sort headers.
2121         * ada-varobj.c: Sort headers.
2122         * ada-valprint.c: Sort headers.
2123         * ada-typeprint.c: Sort headers.
2124         * ada-tasks.c: Sort headers.
2125         * ada-lang.c: Sort headers.
2126         * aarch64-tdep.c: Sort headers.
2127         * aarch64-ravenscar-thread.c: Sort headers.
2128         * aarch64-newlib-tdep.c: Sort headers.
2129         * aarch64-linux-tdep.c: Sort headers.
2130         * aarch64-linux-nat.c: Sort headers.
2131         * aarch64-fbsd-tdep.c: Sort headers.
2132         * aarch64-fbsd-nat.c: Sort headers.
2133         * aarch32-linux-nat.c: Sort headers.
2134
2135 2019-04-04  Tom Tromey  <tom@tromey.com>
2136
2137         * varobj.c (varobj_create): Update.
2138         * rust-exp.y (struct rust_parser) <update_innermost_block,
2139         lookup_symbol>: New methods.
2140         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2141         Rename.
2142         (rust_parser::rust_lookup_type)
2143         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2144         * printcmd.c (display_command, do_one_display): Update.
2145         * parser-defs.h (struct parser_state) <parser_state>: Add
2146         "tracker" parameter.
2147         (block_tracker): New member.
2148         (class innermost_block_tracker) <innermost_block_tracker>: Add
2149         "types" parameter.
2150         <reset>: Remove method.
2151         (innermost_block): Don't declare.
2152         (null_post_parser): Update.
2153         * parse.c (innermost_block): Remove global.
2154         (write_dollar_variable): Update.
2155         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2156         Remove "tracker_types" parameter.
2157         (parse_expression): Add "tracker" parameter.
2158         (parse_expression_for_completion): Update.
2159         (null_post_parser): Add "tracker" parameter.
2160         * p-exp.y: Update rules.
2161         * m2-exp.y: Update rules.
2162         * language.h (struct language_defn) <la_post_parser>: Add
2163         "tracker" parameter.
2164         * go-exp.y: Update rules.
2165         * f-exp.y: Update rules.
2166         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2167         parameter.
2168         * d-exp.y: Update rules.
2169         * c-exp.y: Update rules.
2170         * breakpoint.c (set_breakpoint_condition): Create an
2171         innermost_block_tracker.
2172         (watch_command_1): Likewise.
2173         * ada-lang.c (resolve): Add "tracker" parameter.
2174         (resolve_subexp): Likewise.
2175         * ada-exp.y (write_var_from_sym): Update.
2176
2177 2019-04-04  Tom Tromey  <tom@tromey.com>
2178
2179         * type-stack.h: New file.
2180         * type-stack.c: New file.
2181         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2182         type-stack.h.
2183         (insert_into_type_stack, insert_type, push_type, push_type_int)
2184         (insert_type_address_space, pop_type, pop_type_int)
2185         (pop_typelist, pop_type_stack, append_type_stack)
2186         (push_type_stack, get_type_stack, push_typelist)
2187         (follow_type_instance_flags, follow_types): Don't declare.
2188         * parse.c (type_stack): Remove global.
2189         (parse_exp_in_context): Update.
2190         (insert_into_type_stack, insert_type, push_type, push_type_int)
2191         (insert_type_address_space, pop_type, pop_type_int)
2192         (pop_typelist, pop_type_stack, append_type_stack)
2193         (push_type_stack, get_type_stack, push_typelist)
2194         (follow_type_instance_flags, follow_types): Remove (moved to
2195         type-stack.c).
2196         * f-exp.y (type_stack): New global.
2197         Update rules.
2198         (push_kind_type, f_parse): Update.
2199         * d-exp.y (type_stack): New global.
2200         Update rules.
2201         (d_parse): Update.
2202         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2203         Update rules.
2204         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2205         (HFILES_NO_SRCDIR): Add type-stack.h.
2206
2207 2019-04-04  Tom Tromey  <tom@tromey.com>
2208
2209         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2210         (rust_parser::convert_ast_to_expression, rust_parse)
2211         (rust_lex_test_completion, rust_lex_tests): Update.
2212         * parser-defs.h (struct expr_completion_state): New.
2213         (struct parser_state) <parser_state>: Add completion parameter.
2214         <mark_struct_expression, mark_completion_tag>: New methods.
2215         <parse_completion, m_completion_state>: New members.
2216         (prefixify_expression, null_post_parser): Update.
2217         (mark_struct_expression, mark_completion_tag): Don't declare.
2218         * parse.c (parse_completion, expout_last_struct)
2219         (expout_tag_completion_type, expout_completion_name): Remove
2220         globals.
2221         (parser_state::mark_struct_expression)
2222         (parser_state::mark_completion_tag): Now methods.
2223         (prefixify_expression): Add last_struct parameter.
2224         (prefixify_subexp): Likewise.
2225         (parse_exp_1): Update.
2226         (parse_exp_in_context): Add cstate parameter.  Update.
2227         (parse_expression_for_completion): Create an
2228         expr_completion_state.
2229         (null_post_parser): Add "completion" parameter.
2230         * p-exp.y: Update rules.
2231         (yylex): Update.
2232         * language.h (struct language_defn) <la_post_parser>: Add
2233         "completing" parameter.
2234         * go-exp.y: Update rules.
2235         (lex_one_token): Update.
2236         * expression.h (parse_completion): Don't declare.
2237         * d-exp.y: Update rules.
2238         (lex_one_token): Update rules.
2239         * c-exp.y: Update rules.
2240         (lex_one_token): Update.
2241         * ada-lang.c (resolve): Add "parse_completion" parameter.
2242         (resolve_subexp): Likewise.
2243         (ada_resolve_function): Likewise.
2244
2245 2019-04-04  Tom Tromey  <tom@tromey.com>
2246
2247         * parser-defs.h (struct parser_state) <start_arglist,
2248         end_arglist>: New methods.
2249         <arglist_len, m_funcall_chain>: New members.
2250         (arglist_len, start_arglist, end_arglist): Don't declare.
2251         * parse.c (arglist_len, funcall_chain): Remove global.
2252         (start_arglist, end_arglist): Remove functions.
2253         (parse_exp_in_context): Update.
2254         * p-exp.y: Update rules.
2255         * m2-exp.y: Update rules.
2256         * go-exp.y: Update rules.
2257         * f-exp.y: Update rules.
2258         * d-exp.y: Update rules.
2259         * c-exp.y: Update rules.
2260
2261 2019-04-04  Tom Tromey  <tom@tromey.com>
2262
2263         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2264         lex_operator, push_back>: New methods.
2265         Update all rules.
2266         (rust_parser::lex_hex, lex_escape): Rename and update.
2267         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2268         (rust_parser::lex_operator): Rename and update.
2269         (rust_parser::lex_number, rustyylex, rustyyerror)
2270         (rust_lex_test_init, rust_lex_test_sequence)
2271         (rust_lex_test_push_back, rust_lex_tests): Update.
2272         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2273         parameter.
2274         <lexptr, prev_lexptr>: New members.
2275         (lexptr, prev_lexptr): Don't declare.
2276         * parse.c (lexptr, prev_lexptr): Remove globals.
2277         (parse_exp_in_context): Update.
2278         * p-exp.y (yylex, yyerror): Update.
2279         * m2-exp.y (parse_number, yylex, yyerror): Update.
2280         * go-exp.y (lex_one_token, yyerror): Update.
2281         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2282         * d-exp.y (lex_one_token, yyerror): Update.
2283         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2284         (lex_one_token, yyerror): Update.
2285         * ada-lex.l (YY_INPUT): Update.
2286         (rewind_to_char): Update.
2287         * ada-exp.y (yyerror): Update.
2288
2289 2019-04-04  Tom Tromey  <tom@tromey.com>
2290
2291         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2292         * parser-defs.h (struct parser_state) <parser_state>: Add new
2293         parameter.
2294         <comma_terminates>: New member.
2295         (comma_terminates): Don't declare global.
2296         * parse.c (comma_terminates): Remove global.
2297         (parse_exp_in_context): Update.
2298         * p-exp.y (yylex): Update.
2299         * m2-exp.y (yylex): Update.
2300         * go-exp.y (lex_one_token): Update.
2301         * f-exp.y (yylex): Update.
2302         * d-exp.y (lex_one_token): Update.
2303         * c-exp.y (lex_one_token): Update.
2304         * ada-lex.l: Update.
2305
2306 2019-04-04  Tom Tromey  <tom@tromey.com>
2307
2308         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2309         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2310         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2311         * parser-defs.h (paren_depth): Don't declare.
2312         * parse.c (paren_depth): Remove global.
2313         (parse_exp_in_context): Update.
2314         * p-exp.y (paren_depth): New global.
2315         (pascal_parse): Initialize it.
2316         * m2-exp.y (paren_depth): New global.
2317         (m2_parse): Initialize it.
2318         * go-exp.y (paren_depth): New global.
2319         (go_parse): Initialize it.
2320         * f-exp.y (paren_depth): New global.
2321         (f_parse): Initialize it.
2322         * d-exp.y (paren_depth): New global.
2323         (d_parse): Initialize it.
2324         * c-exp.y (paren_depth): New global.
2325         (c_parse): Initialize it.
2326         * ada-lex.l (paren_depth): New global.
2327         (lexer_init): Initialize it.
2328
2329 2019-04-04  Tom Tromey  <tom@tromey.com>
2330
2331         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2332         (rust_parser::convert_ast_to_type)
2333         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2334         * parser-defs.h (struct parser_state) <parser_state>: Add
2335         parameters.  Initialize new members.
2336         <expression_context_block, expression_context_pc>: New members.
2337         * parse.c (expression_context_block, expression_context_pc):
2338         Remove globals.
2339         (parse_exp_in_context): Update.
2340         * p-exp.y: Update all rules.
2341         (yylex): Update.
2342         * m2-exp.y: Update all rules.
2343         (yylex): Update.
2344         * go-exp.y (yylex): Update.
2345         * f-exp.y (yylex): Update.
2346         * d-exp.y: Update all rules.
2347         (yylex): Update.
2348         * c-exp.y: Update all rules.
2349         (lex_one_token, classify_name, yylex, c_parse): Update.
2350         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2351
2352 2019-04-04  Tom Tromey  <tom@tromey.com>
2353
2354         * gdbarch.h, gdbarch.c: Rebuild.
2355         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2356         * stap-probe.h:
2357         (struct stap_parse_info): Replace "parser_state" with
2358         "expr_builder".
2359         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2360         (parser_state): New class.
2361         * parse.c (expr_builder): Rename.
2362         (expr_builder::release): Rename.
2363         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2364         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2365         (write_exp_elt_longcst, write_exp_elt_floatcst)
2366         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2367         (write_exp_string_vector, write_exp_bitstring)
2368         (write_exp_msymbol, mark_struct_expression)
2369         (write_dollar_variable)
2370         (insert_type_address_space, increase_expout_size): Replace
2371         "parser_state" with "expr_builder".
2372         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2373         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2374         "parser_state" with "expr_builder".
2375
2376 2019-04-04  Tom Tromey  <tom@tromey.com>
2377
2378         * rust-exp.y: Replace "parse_language" with method call.
2379         * p-exp.y:
2380         (yylex): Replace "parse_language" with method call.
2381         * m2-exp.y:
2382         (yylex): Replace "parse_language" with method call.
2383         * go-exp.y (classify_name): Replace "parse_language" with method
2384         call.
2385         * f-exp.y (yylex): Replace "parse_language" with method call.
2386         * d-exp.y (lex_one_token): Replace "parse_language" with method
2387         call.
2388         * c-exp.y:
2389         (lex_one_token, classify_name, yylex): Replace "parse_language"
2390         with method call.
2391         * ada-exp.y (find_primitive_type, type_char)
2392         (type_system_address): Replace "parse_language" with method call.
2393
2394 2019-04-04  Tom Tromey  <tom@tromey.com>
2395
2396         * rust-exp.y: Replace "parse_gdbarch" with method call.
2397         * parse.c (write_dollar_variable, insert_type_address_space):
2398         Replace "parse_gdbarch" with method call.
2399         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2400         call.
2401         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2402         call.
2403         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2404         "parse_gdbarch" with method call.
2405         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2406         with method call.
2407         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2408         "parse_gdbarch" with method call.
2409         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2410         "parse_gdbarch" with method call.
2411         * c-exp.y (parse_type, parse_number, classify_name): Replace
2412         "parse_gdbarch" with method call.
2413         * ada-lex.l: Replace "parse_gdbarch" with method call.
2414         * ada-exp.y (parse_type, find_primitive_type, type_char)
2415         (type_system_address): Replace "parse_gdbarch" with method call.
2416
2417 2019-04-04  Tom Tromey  <tom@tromey.com>
2418
2419         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2420         * stap-probe.c (stap_parse_argument): Update.
2421         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2422         initial_size parameter.
2423         * rust-exp.y (rust_lex_tests): Update.
2424         * parse.c (parser_state): Update.
2425         (parse_exp_in_context): Update.
2426         * parser-defs.h (struct parser_state) <parser_state>: Remove
2427         "initial_size" parameter.
2428
2429 2019-04-04  Tom Tromey  <tom@tromey.com>
2430
2431         * parser-defs.h (increase_expout_size): Don't declare.
2432         * parse.c (increase_expout_size): Now static.
2433
2434 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2435
2436         * gnu-nat.c (gnu_nat_target::wait): Fix
2437         target_waitstatus_to_string call.
2438
2439 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * eval.c (evaluate_subexp_standard): Handle internal functions
2442         during Fortran function call handling.
2443
2444 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * NEWS: Mention new internal functions.
2447         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2448         (read_base_type): Use dwarf2_init_complex_target_type.
2449         * value.c (creal_internal_fn): New function.
2450         (cimag_internal_fn): New function.
2451         (_initialize_values): Register new internal functions.
2452
2453 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2454
2455         * infrun.c (stop_all_threads): If debug_infrun, always
2456         trace the wait status after wait_one, using
2457         target_waitstatus_to_string and target_pid_to_str.
2458         (handle_inferior_event): Replace various trace of
2459         wait status kind by a single trace.
2460         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2461         wait status kind image by target_waitstatus_to_string.
2462         * target/waitstatus.c (target_waitstatus_to_string): Fix
2463         obsolete comment.
2464
2465 2019-04-01  Tom Tromey  <tromey@adacore.com>
2466
2467         PR symtab/23331:
2468         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2469
2470 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2471             Pedro Alves  <palves@redhat.com>
2472
2473         * top.c (quit_force): Call 'finalize_values'.
2474         * value.c (finalize_values): New function.
2475         * value.h (finalize_values): Declare.
2476
2477 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2478
2479         * NEWS: Announce $_gdb_major and $_gdb_minor.
2480
2481         * top.c (init_gdb_version_vars): New function.
2482         (gdb_init): Call init_gdb_version_vars.
2483
2484 2019-03-29  Tom Tromey  <tromey@adacore.com>
2485
2486         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2487         help text.  Remove dead code.
2488
2489 2019-03-29  Keith Seitz  <keiths@redhat.com>
2490
2491         From Siddhesh Poyarekar:
2492         * f-lang.h (f77_get_upperbound): Return LONGEST.
2493         (f77_get_lowerbound): Likewise.
2494         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2495         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2496         print them.
2497         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2498         plongest to format print it.
2499         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2500         (f77_get_upperbound): Likewise.
2501         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2502         LOWER_BOUND to LONGEST.
2503         (f77_create_arrayprint_offset_tbl): Likewise.
2504
2505 2019-03-29  Keith Seitz  <keiths@redhat.com>
2506
2507         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2508         %s/pulongest for TYPE_LENGTH instead of %d in format
2509         strings.
2510         * ada-typerint.c (ada_print_type): Likewise.
2511         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2512         * compile/compile-c-support.c (generate_register_struct): Likewise.
2513         * gdbtypes.c (recursive_dump_type): Likewise.
2514         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2515         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2516         instead of %d in format strings.
2517         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2518         to std::min to ULONGEST.
2519         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2520         instead of %d in format strings.
2521         * tracepoint.c (info_scope_command): Likewise.
2522         * typeprint.c (print_offset_data::update)
2523         (print_offset_data::finish): Likewise.
2524         * xtensa-tdep.c (xtensa_store_return_value)
2525         (xtensa_push_dummy_call): Likewise.
2526
2527 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2528
2529         * windows-nat.c (display_selector): Fixed format specifications
2530         for 64-bit Cygwin.
2531
2532 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2533
2534         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2535
2536 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2537
2538         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2539         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2540         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2541         (nios2_linux_init_abi): Install it.
2542
2543 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2544
2545         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2546
2547 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2548
2549         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2550
2551 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2552             Tom Tromey  <tromey@adacore.com>
2553
2554         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2555
2556 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2557
2558         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2559         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2560         method to compute the bounds of range types. Also print "[evaluated]"
2561         if the bounds' values come from a dynamic evaluation.
2562
2563 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2566         whitespace when pretty printing is on.
2567
2568 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2569
2570         * ppc-linux-nat.c: Add include.
2571
2572 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * NEWS: Mention AArch64 Pointer Authentication.
2575
2576 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2577
2578         * arm-linux-nat.c: Add include.
2579
2580 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2581
2582         * source-cache.c (source_cache::get_source_lines): Re-read
2583         fullname after calling open_source_file.
2584
2585 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2586
2587         * NEWS: Mention TLS support for FreeBSD.
2588
2589 2019-03-25  Tom Tromey  <tromey@adacore.com>
2590
2591         * minsyms.c (BUNCH_SIZE): Update comment.
2592         (~minimal_symbol_reader): Remove old comment.
2593         (compact_minimal_symbols): Update comment.
2594         (minimal_symbol_reader::install): Remove old comment.  Update
2595         other comments.
2596
2597 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2598
2599         * s390-linux-nat.c: Add include.
2600
2601 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2602
2603         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2604         Call linux_get_hwcap.
2605         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2606         Likewise.
2607         (aarch64_linux_get_hwcap): Remove function.
2608         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2609         declaration.
2610         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2611         linux_get_hwcap.
2612         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2613         * linux-tdep.c (linux_get_hwcap): Add function.
2614         (linux_get_hwcap2): Likewise.
2615         * linux-tdep.h (linux_get_hwcap): Add declaration.
2616         (linux_get_hwcap2): Likewise.
2617         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2618         (ppc_linux_get_hwcap2): Likewise.
2619         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2620         linux_get_hwcap.
2621         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2622         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2623         (ppc_linux_nat_target::read_description): Likewise.
2624         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2625         * s390-linux-nat.c: Likewise.
2626         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2627
2628 2019-03-24  Tom Tromey  <tom@tromey.com>
2629
2630         * ada-lang.c (standard_lookup): Simplify initialization.
2631         (ada_lookup_symbol_nonlocal): Simplify return.
2632         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2633         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2634         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2635         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2636         initialization.
2637         * solib.c (solib_global_lookup): Simplify.
2638         * symtab.c (null_block_symbol): Remove.
2639         (symbol_cache_lookup): Simplify returns.
2640         (lookup_language_this): Simplify returns.
2641         (lookup_symbol_aux): Simplify return.
2642         (lookup_local_symbol): Simplify returns.
2643         (lookup_global_symbol_from_objfile): Simplify return.
2644         (lookup_symbol_in_objfile_symtabs)
2645         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2646         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2647         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2648         * cp-namespace.c (cp_lookup_bare_symbol)
2649         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2650         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2651         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2652         (cp_lookup_symbol_via_imports): Simplify initialization.
2653         (find_symbol_in_baseclass): Likewise.
2654         * symtab.h (null_block_symbol): Remove.
2655         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2656         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2657         (d_lookup_symbol_module): Likewise.
2658         (find_symbol_in_baseclass): Simplify initialization.
2659
2660 2019-03-24  Tom Tromey  <tom@tromey.com>
2661
2662         * expression.h: Don't include symtab.h.
2663         (struct block): Forward declare.
2664
2665 2019-03-24  Tom Tromey  <tom@tromey.com>
2666
2667         * c-exp.y (typebase): Remove casts.
2668         * gdbtypes.c (lookup_unsigned_typename, )
2669         (lookup_signed_typename): Remove cast.
2670         * eval.c (parse_to_comma_and_eval): Remove cast.
2671         * parse.c (write_dollar_variable): Remove cast.
2672         * block.h (struct block) <superblock>: Now const.
2673         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2674         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2675         (map_block): Make "block" const.
2676         * symfile.h (struct quick_symbol_functions)
2677         <map_matching_symbols>: Constify block argument to "callback".
2678         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2679         const.
2680         (find_pc_sect_compunit_symtab): Make "b" const.
2681         (find_symbol_at_address): Likewise.
2682         (search_symbols): Likewise.
2683         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2684         (dw2_debug_names_lookup_symbol): Likewise.
2685         (dw2_map_matching_symbols): Update.
2686         * p-valprint.c (pascal_val_print): Remove "block".
2687         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2688         (aux_add_nonlocal_symbols): Make "block" const.
2689         (resolve_subexp): Remove cast.
2690         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2691         const.
2692         (iterate_over_file_blocks): Likewise.
2693         * f-exp.y (%union) <bval>: Remove.
2694         * coffread.c (patch_opaque_types): Make "b" const.
2695         * spu-tdep.c (spu_catch_start): Make "block" const.
2696         * c-valprint.c (print_unpacked_pointer): Remove "block".
2697         * symmisc.c (dump_symtab_1): Make "b" const.
2698         (block_depth): Make "block" const.
2699         * d-exp.y (%union) <bval>: Remove.
2700         * cp-support.h (cp_lookup_rtti_type): Update.
2701         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2702         * psymtab.c (psym_lookup_symbol): Make "block" const.
2703         (maintenance_check_psymtabs): Make "b" const.
2704         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2705         (enumerate_locals, enumerate_args): Update.
2706         * python/py-symtab.c (stpy_global_block): Make "block" const.
2707         (stpy_static_block): Likewise.
2708         * inline-frame.c (block_starting_point_at): Make "new_block"
2709         const.
2710         * block.c (find_block_in_blockvector): Make return type const.
2711         (blockvector_for_pc_sect): Make "b" const.
2712         (find_block_in_blockvector): Make "b" const.
2713
2714 2019-03-23  Tom Tromey  <tom@tromey.com>
2715
2716         * varobj.c (varobj_create): Update.
2717         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2718         * printcmd.c (display_command, do_one_display): Don't reset
2719         innermost_block.
2720         * parser-defs.h (enum innermost_block_tracker_type): Move to
2721         expression.h.
2722         (innermost_block): Update comment.
2723         * parse.c (parse_exp_1): Add tracker_types parameter.
2724         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2725         tracker_types parameter.  Reset innermost_block.
2726         (parse_exp_in_context): Remove.
2727         (parse_expression_for_completion): Update.
2728         * objfiles.c (~objfile): Don't reset expression_context_block or
2729         innermost_block.
2730         * expression.h (enum innermost_block_tracker_type): Move from
2731         parser-defs.h.
2732         (parse_exp_1): Add tracker_types parameter.
2733         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2734         reset innermost_block.
2735
2736 2019-03-23  Tom Tromey  <tom@tromey.com>
2737
2738         * objfiles.h: Include bcache.h.
2739
2740 2019-03-23  Tom Tromey  <tom@tromey.com>
2741
2742         * linespec.c (get_current_search_block): Use
2743         scoped_restore_current_language.
2744         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2745
2746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2747             Jiong Wang  <jiong.wang@arm.com>
2748
2749         * aarch64-linux-tdep.c
2750         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2751         section.
2752         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2753
2754 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2755             Jiong Wang  <jiong.wang@arm.com>
2756
2757         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2758         instructions.
2759         (aarch64_analyze_prologue_test): Add PACIASP test.
2760         (aarch64_prologue_prev_register): Unmask PC value.
2761
2762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2763             Jiong Wang  <jiong.wang@arm.com>
2764
2765         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2766         (aarch64_dwarf2_prev_register): Unmask PC value.
2767         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2768         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2769         DW_CFA_AARCH64_negate_ra_state.
2770         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2771
2772 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2773             Jiong Wang  <jiong.wang@arm.com>
2774
2775         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2776         registers.
2777         (aarch64_pseudo_register_name): Likewise.
2778         (aarch64_pseudo_register_type): Likewise.
2779         (aarch64_pseudo_register_reggroup_p): Likewise.
2780         (aarch64_gdbarch_init): Add pauth registers.
2781         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2782         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2783         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2784         (struct gdbarch_tdep): Add regnum for ra_state.
2785
2786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2787             Jiong Wang  <jiong.wang@arm.com>
2788
2789         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2790
2791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2792             Jiong Wang  <jiong.wang@arm.com>
2793
2794         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2795         function.
2796         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2797         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2798         (aarch64_gdbarch_init): Add puth registers.
2799         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2800         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2801         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2802
2803 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2804             Jiong Wang  <jiong.wang@arm.com>
2805
2806         * aarch64-linux-nat.c
2807         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2808         * aarch64-linux-tdep.c
2809         (aarch64_linux_core_read_description): Likewise.
2810         (aarch64_linux_get_hwcap): New function.
2811         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2812         (aarch64_linux_get_hwcap): New declaration.
2813
2814 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2815             Jiong Wang  <jiong.wang@arm.com>
2816
2817         * aarch64-linux-nat.c
2818         (aarch64_linux_nat_target::read_description): Add pauth param.
2819         * aarch64-linux-tdep.c
2820         (aarch64_linux_core_read_description): Likewise.
2821         * aarch64-tdep.c (struct target_desc): Add in pauth.
2822         (aarch64_read_description): Add pauth param.
2823         (aarch64_gdbarch_init): Likewise.
2824         * aarch64-tdep.h (aarch64_read_description): Likewise.
2825         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2826         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2827         * features/Makefile: Add new files.
2828         * features/aarch64-pauth.c: New file.
2829         * features/aarch64-pauth.xml: New file.
2830
2831 2019-03-20  Tom Tromey  <tromey@adacore.com>
2832
2833         * infrun.c (handle_inferior_event): Rename from
2834         handle_inferior_event_1.  Create a scoped_value_mark.
2835         (handle_inferior_event): Remove.
2836
2837 2019-03-19  Tom Tromey  <tromey@adacore.com>
2838
2839         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2840         * infrun.h (print_stop_event): Add "displays" parameter.
2841         * infrun.c (print_stop_event): Add "displays" parameter.
2842
2843 2019-03-19  Pedro Alves  <palves@redhat.com>
2844
2845         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2846         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2847         to -1.  Fix TABs vs spaces.
2848         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2849         * tui/tui-out.h (tui_ui_out) Add intro comments.
2850         <m_line, m_start_of_line>: In-class initialize, and add describing
2851         comment.
2852
2853 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2854
2855         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2856         variable names.
2857         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2858
2859 2019-03-18  Pedro Alves  <palves@redhat.com>
2860             Eli Zaretskii <eliz@gnu.org>
2861
2862         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2863         m_line and m_start_of_line.
2864
2865 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2866
2867         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2868         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2869         it returns a newline.  This fixes a regression in TU mode, whereby
2870         the next line is output on the same screen line as the user input.
2871
2872 2019-03-18  Tom Tromey  <tromey@adacore.com>
2873
2874         * minsyms.c (minimal_symbol_reader::install): Remove call to
2875         obstack_blank.
2876
2877 2019-03-18  Pedro Alves  <palves@redhat.com>
2878
2879         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2880         New globals.
2881         (apply_style): New, factored out from ...
2882         (apply_ansi_escape): ... this.  Handle reverse video mode.
2883         (tui_set_reverse_mode): New function.
2884         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2885         * tui/tui-winsource.c (tui_show_source_line): Use
2886         tui_set_reverse_mode instead of setting A_STANDOUT.
2887         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2888         New setter methods.
2889
2890 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2891
2892         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2893         Handle tabs.
2894
2895 2019-03-18  Tom Tromey  <tromey@adacore.com>
2896
2897         * ada-lang.c (empty_array): Add "high" parameter.
2898         (ada_evaluate_subexp): Update.
2899
2900 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2901
2902         * unittests/string_view-selftests.c: Define
2903         _initialize_string_view_selftests unconditionally.
2904
2905 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2906
2907         PR gdb/24350
2908         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2909
2910 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2911
2912         PR gdb/24351
2913         * windows-nat.c (display_selector): Fix format specifiers.
2914
2915 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2916
2917         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2918         tui_refill_source_window instead of tui_refresh_win, to update the
2919         current execution line.  This fixes redisplay of the current line
2920         when stepping through the code with "next" or "step".
2921
2922 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2923
2924         * source-cache.c (source_cache::get_source_lines): Call
2925         find_source_lines to initialize s->nlines.  This fixes vertical
2926         scrolling of TUI source window when the DOWN arrow is pressed.
2927
2928 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2929
2930         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2931         linux-thread-db.c (_initialize_thread_db): Likewise.
2932
2933 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2934
2935         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2936         wclrtoeol in tui_show_source_line".  This reverts changes made in
2937         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2938
2939 2019-03-15  Tom Tromey  <tom@tromey.com>
2940
2941         * symtab.h (struct minimal_symbol): Derive from
2942         general_symbol_info.
2943         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2944         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2945         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2946         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2947         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2948         (MSYMBOL_SEARCH_NAME): Update.
2949         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2950         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2951         * minsyms.c (minimal_symbol_reader::record_full): Update.
2952
2953 2019-03-15  Tom Tromey  <tom@tromey.com>
2954
2955         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2956
2957 2019-03-15  Tom Tromey  <tom@tromey.com>
2958
2959         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2960         unique_xmalloc_ptr.
2961         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2962         Update.
2963         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2964         (build_minimal_symbol_hash_tables)
2965         (minimal_symbol_reader::install): Update.
2966
2967 2019-03-15  Tom Tromey  <tom@tromey.com>
2968
2969         * symtab.c (create_demangled_names_hash): Update.
2970         (symbol_set_names): Update.
2971         * objfiles.h (struct objfile_per_bfd_storage)
2972         <demangled_names_hash>: Now an htab_up.
2973         * objfiles.c (objfile_per_bfd_storage): Simplify.
2974
2975 2019-03-15  Tom Tromey  <tom@tromey.com>
2976
2977         * objfiles.h (struct objfile_per_bfd_storage): Declare
2978         destructor.
2979         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2980         New.
2981         (get_objfile_bfd_data): Use new.  Don't initialize
2982         language_of_main.
2983         (free_objfile_per_bfd_storage): Remove.
2984         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2985
2986 2019-03-15  Tom Tromey  <tom@tromey.com>
2987
2988         * symfile.c (reread_symbols): Update.
2989         * objfiles.c (objfile::objfile): Update.
2990         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2991         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2992         comment.
2993         (minimal_symbol_reader::install): Update.
2994         (terminate_minimal_symbol_table): Remove.
2995         * jit.c (jit_object_close_impl): Update.
2996
2997 2019-03-15  Tom Tromey  <tom@tromey.com>
2998
2999         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3000         initializations.
3001
3002 2019-03-15  Tom Tromey  <tom@tromey.com>
3003
3004         * objfiles.h (struct objfile_per_bfd_storage)
3005         <demangled_hash_languages>: Now a bitset.
3006         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3007         (lookup_minimal_symbol): Update.
3008
3009 2019-03-15  Tom Tromey  <tom@tromey.com>
3010
3011         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3012         Don't return the symbol.
3013         * coffread.c (record_minimal_symbol): Use record_full.
3014
3015 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3016
3017         The MS-Windows port of ncurses fails to switch to a color pair if
3018         one or both of the colors are the implicit default colors.  This
3019         change records the default colors when TUI is initialized, and
3020         then specifies them explicitly when a color pair uses the default
3021         colors.  This allows color styling in TUI mode on MS-Windows.
3022
3023         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3024         ncurses_norm_attr.
3025         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3026         colors in ncurses_norm_attr.
3027         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3028         "none", replace it with the default color recorded in
3029         ncurses_norm_attr.
3030
3031 2019-03-14  Tom Tromey  <tromey@adacore.com>
3032
3033         * source-cache.h (class source_cache) <get_source_lines>: Return
3034         std::string.
3035         * source-cache.c (source_cache::extract_lines): Handle case where
3036         first_pos==npos.  Return std::string.
3037         (source_cache::get_source_lines): Update.
3038
3039 2019-03-14  Tom Tromey  <tromey@adacore.com>
3040
3041         * NEWS: Add item for "style sources" commands.
3042         * source-cache.c (source_cache::get_source_lines): Check
3043         source_styling.
3044         * cli/cli-style.c (source_styling): New global.
3045         (_initialize_cli_style): Add "style sources" commands.
3046         (show_style_sources): New function.
3047         * cli/cli-style.h (source_styling): Declare.
3048
3049 2019-03-14  Pedro Alves  <palves@redhat.com>
3050             Tom Tromey  <tromey@adacore.com>
3051
3052         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3053         * tui/tui-winsource.c (tui_refill_source_window): New function,
3054         from...
3055         (tui_horizontal_source_scroll): ... here.  Move some logic.
3056         * cli/cli-style.c (set_style_enabled): Notify new observable.
3057         * tui/tui-hooks.c (tui_redisplay_source): New function.
3058         (tui_attach_detach_observers): Attach or detach
3059         tui_redisplay_source.
3060         * observable.h (source_styling_changed): New observable.
3061         * observable.c: Define source_styling_changed observable.
3062
3063 2019-03-13  Tom Tromey  <tromey@adacore.com>
3064
3065         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3066         (i386_gnu_nat_target::store_registers): Update.
3067         * target-debug.h (target_debug_print_std_string): New macro.
3068         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3069         * windows-tdep.c (display_one_tib): Update.
3070         * tui/tui-stack.c (tui_make_status_line): Update.
3071         * top.c (print_inferior_quit_action): Update.
3072         * thread.c (thr_try_catch_cmd): Update.
3073         (add_thread_with_info): Update.
3074         (thread_target_id_str): Update.
3075         (thr_try_catch_cmd): Update.
3076         (thread_command): Update.
3077         (thread_find_command): Update.
3078         * record-btrace.c (record_btrace_target::info_record)
3079         (record_btrace_resume_thread, record_btrace_target::resume)
3080         (record_btrace_cancel_resume, record_btrace_step_thread)
3081         (record_btrace_target::wait, record_btrace_target::wait)
3082         (record_btrace_target::wait, record_btrace_target::stop): Update.
3083         * progspace.c (print_program_space): Update.
3084         * process-stratum-target.c
3085         (process_stratum_target::thread_address_space): Update.
3086         * linux-fork.c (linux_fork_mourn_inferior)
3087         (detach_checkpoint_command, info_checkpoints_command)
3088         (linux_fork_context): Update.
3089         (linux_fork_detach): Update.
3090         (class scoped_switch_fork_info): Update.
3091         (delete_checkpoint_command): Update.
3092         * infrun.c (follow_fork_inferior): Update.
3093         (follow_fork_inferior): Update.
3094         (proceed_after_vfork_done): Update.
3095         (handle_vfork_child_exec_or_exit): Update.
3096         (follow_exec): Update.
3097         (displaced_step_prepare_throw): Update.
3098         (displaced_step_restore): Update.
3099         (start_step_over): Update.
3100         (resume_1): Update.
3101         (clear_proceed_status_thread): Update.
3102         (proceed): Update.
3103         (print_target_wait_results): Update.
3104         (do_target_wait): Update.
3105         (context_switch): Update.
3106         (stop_all_threads): Update.
3107         (restart_threads): Update.
3108         (finish_step_over): Update.
3109         (handle_signal_stop): Update.
3110         (switch_back_to_stepped_thread): Update.
3111         (keep_going_pass_signal): Update.
3112         (print_exited_reason): Update.
3113         (normal_stop): Update.
3114         * inferior.c (inferior_pid_to_str): Change return type.
3115         (print_selected_inferior): Update.
3116         (add_inferior): Update.
3117         (detach_inferior): Update.
3118         * dummy-frame.c (fprint_dummy_frames): Update.
3119         * dcache.c (dcache_info_1): Update.
3120         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3121         (btrace_fetch, btrace_clear): Update.
3122         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3123         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3124         type.
3125         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3126         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3127         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3128         * gdbarch.c, gdbarch.h: Rebuild.
3129         * gdbarch.sh (core_pid_to_str): Change return type.
3130         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3131         return type.
3132         (windows_nat_target::pid_to_str): Change return type.
3133         (windows_delete_thread): Update.
3134         (windows_nat_target::attach): Update.
3135         (windows_nat_target::files_info): Update.
3136         * target-delegates.c: Rebuild.
3137         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3138         return type.
3139         (sol_thread_target::pid_to_str): Change return type.
3140         * remote.c (class remote_target) <pid_to_str>: Change return
3141         type.
3142         (remote_target::pid_to_str): Change return type.
3143         (extended_remote_target::attach, remote_target::remote_stop_ns)
3144         (remote_target::remote_notif_remove_queued_reply)
3145         (remote_target::push_stop_reply, remote_target::disable_btrace):
3146         Update.
3147         (extended_remote_target::attach): Update.
3148         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3149         type.
3150         (gdbsim_target::pid_to_str): Change return type.
3151         * ravenscar-thread.c (struct ravenscar_thread_target)
3152         <pid_to_str>: Change return type.
3153         (ravenscar_thread_target::pid_to_str): Change return type.
3154         * procfs.c (class procfs_target) <pid_to_str>: Change return
3155         type.
3156         (procfs_target::pid_to_str): Change return type.
3157         (procfs_target::attach): Update.
3158         (procfs_target::detach): Update.
3159         (procfs_target::fetch_registers): Update.
3160         (procfs_target::store_registers): Update.
3161         (procfs_target::wait): Update.
3162         (procfs_target::files_info): Update.
3163         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3164         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3165         return type.
3166         (nto_procfs_target::pid_to_str): Change return type.
3167         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3168         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3169         return type.
3170         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3171         (exit_lwp): Update.
3172         (attach_proc_task_lwp_callback, get_detach_signal)
3173         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3174         (linux_nat_target::resume, wait_lwp, stop_callback)
3175         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3176         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3177         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3178         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3179         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3180         type.
3181         (inf_ptrace_target::attach): Update.
3182         (inf_ptrace_target::files_info): Update.
3183         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3184         type.
3185         (go32_nat_target::pid_to_str): Change return type.
3186         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3187         (gnu_nat_target::wait): Update.
3188         (gnu_nat_target::wait): Update.
3189         (gnu_nat_target::resume): Update.
3190         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3191         (fbsd_nat_target::wait): Update.
3192         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3193         type.
3194         (darwin_nat_target::attach): Update.
3195         * corelow.c (class core_target) <pid_to_str>: Change return type.
3196         (core_target::pid_to_str): Change return type.
3197         * target.c (normal_pid_to_str): Change return type.
3198         (default_pid_to_str): Likewise.
3199         (target_pid_to_str): Change return type.
3200         (target_translate_tls_address): Update.
3201         (target_announce_detach): Update.
3202         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3203         return type.
3204         (bsd_uthread_target::pid_to_str): Change return type.
3205         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3206         type.
3207         (bsd_kvm_target::pid_to_str): Change return type.
3208         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3209         return type.
3210         (aix_thread_target::pid_to_str): Change return type.
3211         * target.h (struct target_ops) <pid_to_str>: Change return type.
3212         (target_pid_to_str, normal_pid_to_str): Likewise.
3213         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3214         type.
3215         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3216         type.
3217         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3218         return type.
3219         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3220         type.
3221         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3222         type.
3223         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3224         return type.
3225
3226 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3227
3228         * NEWS: Mention that the new default MI version is 3.  Mention
3229         changes to the output of commands and events that deal with
3230         multi-location breakpoints.
3231         * breakpoint.c: Include "mi/mi-out.h".
3232         (print_one_breakpoint): Change output syntax if using MI version
3233         >= 3.
3234         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3235         New.
3236         (mi_multi_location_breakpoint_output_fixed): New.
3237         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3238         (mi_cmd_fix_multi_location_breakpoint_output): New.
3239         (mi_multi_location_breakpoint_output_fixed): New.
3240         * mi/mi-cmds.c (mi_cmds): Register command
3241         -fix-multi-location-breakpoint-output.
3242         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3243         interpreter "mi".
3244
3245 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3246
3247         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3248         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3249         instantiate mi_ui_out based on interpreter name.
3250         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3251         * mi/mi-main.c (mi_load_progress): Likewise.
3252
3253 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3254
3255         * NEWS: Combine separate "New targets" sections for 8.3.
3256
3257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3258
3259         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3260         (ppcfbsd_init_abi): Install gdbarch
3261         "fetch_tls_load_module_address" and "get_thread_local_address"
3262         methods.
3263
3264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3265
3266         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3267         (riscv_fbsd_init_abi): Install gdbarch
3268         "fetch_tls_load_module_address" and "get_thread_local_address"
3269         methods.
3270
3271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3272
3273         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3274         (i386fbsd_init_abi): Install gdbarch
3275         "fetch_tls_load_module_address" and "get_thread_local_address"
3276         methods.
3277
3278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3279
3280         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3281         (amd64fbsd_init_abi): Install gdbarch
3282         "fetch_tls_load_module_address" and "get_thread_local_address"
3283         methods.
3284
3285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3286
3287         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3288         (struct fbsd_pspace_data): New type.
3289         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3290         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3291         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3292         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3293         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3294
3295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3296
3297         * gdbtypes.c (lookup_struct_elt): New function.
3298         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3299         * gdbtypes.h (struct struct_elt): New type.
3300         (lookup_struct_elt): New prototype.
3301
3302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3303
3304         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3305         remove disabled code block.
3306
3307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3308
3309         * gdbarch.sh (get_thread_local_address): New method.
3310         * gdbarch.h, gdbarch.c: Regenerate.
3311         * target.c (target_translate_tls_address): Use
3312         gdbarch_get_thread_local_address if present instead of
3313         target::get_thread_local_address.
3314
3315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3316
3317         * target.h (target::get_thread_local_address): Update comment.
3318
3319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3320
3321         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3322         objfile->separate_debug_objfile_backlink if not NULL.
3323
3324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3325
3326         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3327         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3328         (amd64bsd_store_inferior_registers): Likewise.
3329         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3330         Enable segment base registers.
3331         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3332         PT_GETFSBASE and PT_GETGSBASE.
3333         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3334         PT_SETGSBASE.
3335         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3336         segment base registers.
3337         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3338
3339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3340
3341         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3342         Update calls to i386_target_description to add 'segments'
3343         parameter.
3344         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3345         add segment base registers.
3346         * arch/i386.c (i386_create_target_description): Add 'segments'
3347         parameter to enable segment base registers.
3348         * arch/i386.h (i386_create_target_description): Likewise.
3349         * features/i386/32bit-segments.xml: New file.
3350         * features/i386/32bit-segments.c: Generate.
3351         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3352         call to i386_target_description to add 'segments' parameter.
3353         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3354         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3355         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3356         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3357         if feature is present.
3358         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3359         Add 'segments' parameter to call to i386_target_description.
3360         (i386_target_description): Add 'segments' parameter to enable
3361         segment base registers.
3362         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3363         to call to i386_target_description.
3364         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3365         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3366         Define I386_NUM_REGS.
3367         (i386_target_description): Add 'segments' parameter to enable
3368         segment base registers.
3369
3370 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3371
3372         PR/24325
3373         * source-cache.c: #undef open and close, to avoid unresolved
3374         externals during linking.
3375
3376 2019-03-12  Tom Tromey  <tromey@adacore.com>
3377
3378         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3379         const.  Add initializers.
3380         (_initialize_remote): Don't initialize ptid globals.
3381
3382 2019-03-12  Pedro Alves  <palves@redhat.com>
3383
3384         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3385
3386 2019-03-12  Pedro Alves  <palves@redhat.com>
3387
3388         * cp-name-parser.y (main): Remove unused 'len' variable.
3389
3390 2019-03-12  Tom Tromey  <tromey@adacore.com>
3391
3392         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3393         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3394
3395 2019-03-12  Tom Tromey  <tromey@adacore.com>
3396
3397         * linux-nat.c (iterate_over_lwps): Update.
3398         (stop_callback): Remove parameter.
3399         (stop_wait_callback, detach_callback, resume_set_callback)
3400         (select_singlestep_lwp_callback, set_ignore_sigint)
3401         (status_callback, resumed_callback, resume_clear_callback)
3402         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3403         data parameter.
3404         (linux_nat_target::detach, linux_nat_target::resume)
3405         (linux_stop_and_wait_all_lwps, select_event_lwp)
3406         (linux_nat_filter_event, linux_nat_wait_1)
3407         (linux_nat_target::kill, linux_nat_target::stop)
3408         (linux_nat_target::stop): Update.
3409         (linux_nat_resume_callback): Change type.
3410         (resume_stopped_resumed_lwps, count_events_callback)
3411         (select_event_lwp_callback): Likewise.
3412         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3413         * arm-linux-nat.c (struct update_registers_data): Remove.
3414         (update_registers_callback): Change type.
3415         (arm_linux_insert_hw_breakpoint1): Update.
3416         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3417         parameter.
3418         (x86_linux_dr_set_addr): Update.
3419         (x86_linux_dr_set_control): Update.
3420         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3421         (iterate_over_lwps): Use gdb::function_view.
3422         * nat/aarch64-linux-hw-point.c (struct
3423         aarch64_dr_update_callback_param): Remove.
3424         (debug_reg_change_callback): Change type.
3425         (aarch64_notify_debug_reg_change): Update.
3426         * s390-linux-nat.c (s390_refresh_per_info): Update.
3427
3428 2019-03-11  Tom Tromey  <tromey@adacore.com>
3429
3430         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3431         redundant assignment to "this_cu".
3432
3433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3434
3435         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3436
3437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3438
3439         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3440         from...
3441         (rank_one_type): ... this.
3442
3443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3444
3445         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3446         from...
3447         (rank_one_type): ... this.
3448
3449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3450
3451         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3452         from...
3453         (rank_one_type): ... this.
3454
3455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3456
3457         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3458         from...
3459         (rank_one_type): ... this.
3460
3461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3462
3463         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3464         from...
3465         (rank_one_type): ... this.
3466
3467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3468
3469         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3470         from...
3471         (rank_one_type): ... this.
3472
3473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3474
3475         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3476         from...
3477         (rank_one_type): ... this.
3478
3479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3480
3481         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3482         from...
3483         (rank_one_type): ... this.
3484
3485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3486
3487         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3488         from...
3489         (rank_one_type): ... this.
3490
3491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3492
3493         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3494         from...
3495         (rank_one_type): ... this.
3496
3497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3498
3499         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3500         from...
3501         (rank_one_type): ... this.
3502
3503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3504
3505         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3506         from...
3507         (rank_one_type): ... this.
3508
3509 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3510
3511         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3512         inferior-events' shows the example events.
3513
3514 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3515
3516         Support styling on native MS-Windows console
3517
3518         PR/24315
3519         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3520         on MS-Windows if $TERM is not defined.
3521
3522         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3523
3524         * posix-hdep.c (gdb_console_fputs):
3525         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3526         functions.
3527         * ui-file.h (gdb_console_fputs): Add prototype.
3528
3529         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3530         back to fputs only if the former returns zero.
3531
3532 2019-03-07  Tom Tromey  <tom@tromey.com>
3533
3534         * symmisc.c (print_symbol_bcache_statistics): Update.
3535         (print_objfile_statistics): Update.
3536         * symfile.c (allocate_symtab): Update.
3537         * stabsread.c: Don't include bcache.h.
3538         * psymtab.h (struct psymbol_bcache): Don't declare.
3539         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3540         (psymbol_bcache_init, psymbol_bcache_free)
3541         (psymbol_bcache_get_bcache): Don't declare.
3542         * psymtab.c (struct psymbol_bcache): Remove.
3543         (psymtab_storage::psymtab_storage): Update.
3544         (psymtab_storage::~psymtab_storage): Update.
3545         (psymbol_bcache_init, psymbol_bcache_free)
3546         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3547         (add_psymbol_to_bcache): Update.
3548         (allocate_psymtab): Update.
3549         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3550         macro_cache>: No longer pointers.
3551         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3552         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3553         * macrotab.c (macro_bcache): Update.
3554         * macroexp.c: Don't include bcache.h.
3555         * gdbtypes.c (check_types_worklist): Update.
3556         (types_deeply_equal): Remove TRY/CATCH.  Update.
3557         * elfread.c (elf_symtab_read): Update.
3558         * dwarf2read.c: Don't include bcache.h.
3559         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3560         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3561         (print_bcache_statistics, bcache_memory_used): Don't declare.
3562         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3563         methods.  Rename all data members.
3564         * bcache.c (struct bcache): Move to bcache.h.
3565         (bcache::expand_hash_table): Rename from expand_hash_table.
3566         (bcache): Remove.
3567         (bcache::insert): Rename from bcache_full.
3568         (bcache::compare): Rename from bcache_compare.
3569         (bcache_xmalloc): Remove.
3570         (bcache::~bcache): Rename from bcache_xfree.
3571         (bcache::print_statistics): Rename from print_bcache_statistics.
3572         (bcache::memory_used): Rename from bcache_memory_used.
3573
3574 2019-03-07  Pedro Alves  <palves@redhat.com>
3575
3576         * infrun.c (normal_stop): Also check for
3577         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3578
3579 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * f-lang.c (value_from_host_double): Moved to...
3582         * value.c (value_from_host_double): ...here.
3583         * value.h (value_from_host_double): Declare.
3584         * guile/scm-math.c (vlscm_convert_typed_number): Use
3585         value_from_host_double.
3586         (vlscm_convert_number): Likewise.
3587         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3588         * python/py-value.c (convert_value_from_python): Likewise.
3589
3590 2019-03-06  Tom Tromey  <tom@tromey.com>
3591
3592         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3593
3594 2019-03-06  Tom Tromey  <tom@tromey.com>
3595
3596         * utils.h (free_current_contents): Don't declare.
3597         * utils.c (free_current_contents): Remove.
3598
3599 2019-03-06  Tom Tromey  <tom@tromey.com>
3600
3601         * top.c (quit_force): Update.
3602         * main.c (captured_command_loop): Update.
3603         * common/new-op.c (operator new): Update.
3604         * common/common-exceptions.c (struct catcher)
3605         <save_cleanup_chain>: Remove member.
3606         (exceptions_state_mc_init): Update.
3607         (exception_try_scope_entry): Return nullptr.
3608         (exception_try_scope_exit, exception_rethrow)
3609         (throw_exception_sjlj, throw_exception_cxx): Update.
3610         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3611         (all_cleanups, do_cleanups, discard_cleanups)
3612         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3613         (restore_cleanups, restore_final_cleanups): Don't declare.
3614         (do_final_cleanups): Remove parameter.
3615         * common/cleanups.c (cleanup_chain, make_cleanup)
3616         (make_cleanup_dtor, all_cleanups, do_cleanups)
3617         (discard_my_cleanups, discard_cleanups)
3618         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3619         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3620         (null_cleanup): Remove.
3621         (do_final_cleanups): Remove parameter.
3622
3623 2019-03-06  Tom Tromey  <tom@tromey.com>
3624
3625         * remote.c (remote_target::remote_parse_stop_reply): Use
3626         unique_xmalloc_ptr.
3627
3628 2019-03-06  Tom Tromey  <tom@tromey.com>
3629
3630         * stabsread.c (struct stabs_field_info): Rename from field_info.
3631         <list, fnlist>: Add initializers.
3632         <obstack>: New member.
3633         (read_member_functions, read_struct_fields, read_baseclasses):
3634         Allocate on obstack.  Don't use cleanups.
3635         (read_one_struct_field, read_member_functions, read_struct_fields)
3636         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3637         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3638         (read_struct_type): Update.
3639
3640 2019-03-06  Tom Tromey  <tom@tromey.com>
3641
3642         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3643         * common/filestuff.h (make_cleanup_close): Don't declare.
3644         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3645         Remove.
3646
3647 2019-03-06  Tom Tromey  <tom@tromey.com>
3648
3649         * solib-aix.c: Use make_scope_exit.
3650
3651 2019-03-06  Tom Tromey  <tom@tromey.com>
3652
3653         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3654         Use make_scope_exit.
3655
3656 2019-03-06  Tom Tromey  <tom@tromey.com>
3657
3658         * solib-svr4.c (disable_probes_interface): Remove parameter.
3659         (svr4_handle_solib_event): Use make_scope_exit.
3660
3661 2019-03-06  Tom Tromey  <tom@tromey.com>
3662
3663         * remote.c (struct stop_reply_deleter): Remove.
3664         (stop_reply_up): Update.
3665         (struct stop_reply): Derive from notif_event.  Don't typedef.
3666         <regcache>: Now a std::vector.
3667         (stop_reply_xfree): Remove.
3668         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3669         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3670         (remote_target::discard_pending_stop_replies): Use delete.
3671         (remote_target::remote_parse_stop_reply): Update.
3672         (remote_target::process_stop_reply): Update.
3673         * remote-notif.h (struct notif_event): Add virtual destructor.
3674         Remove "dtr" member.
3675         (struct notif_client) <alloc_event>: Return a unique_ptr.
3676         (notif_event_xfree): Don't declare.
3677         (notif_event_up): New typedef.
3678         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3679         (notif_event_xfree, do_notif_event_xfree): Remove.
3680         (remote_notif_state_xfree): Update.
3681
3682 2019-03-06  Tom Tromey  <tom@tromey.com>
3683
3684         * infrun.c (displaced_step_clear_cleanup): Now a
3685         forward_scope_exit type.
3686         (displaced_step_prepare_throw): Update.
3687         (displaced_step_fixup): Update.
3688
3689 2019-03-06  Tom Tromey  <tom@tromey.com>
3690
3691         * inferior.h (class inferior): Update comment.
3692         * gdbthread.h (class thread_info): Update comment.
3693
3694 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3695             Tom Tromey  <tom@tromey.com>
3696
3697         * stabsread.h (struct stab_section_list): Remove.
3698         (coffstab_build_psymtabs): Update.
3699         * dbxread.c (symbuf_sections): Now a std::vector.
3700         (sect_idx): New global.
3701         (fill_symbuf): Update.
3702         (coffstab_build_psymtabs): Change type of stabsects parameter.
3703         Update.
3704         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3705         std::vector.
3706         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3707         (coff_locate_sections): Update.
3708         (coff_symfile_read): Remove cleanups.  Update.
3709         (init_stringtab): Add storage parameter.
3710         (free_stringtab, free_stringtab_cleanup): Remove.
3711         (init_lineno): Add storage parameter.
3712         (free_linetab, free_linetab_cleanup): Remove.
3713
3714 2019-03-06  Pedro Alves  <palves@redhat.com>
3715
3716         * linux-fork.c (fork_info::clobber_regs): Delete.
3717         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3718         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3719         comment.  Adjust.
3720         (scoped_switch_fork_info::scoped_switch_fork_info)
3721         (checkpoint_command, linux_fork_context): Adjust
3722         fork_save_infrun_state calls.
3723
3724 2019-03-06  Pedro Alves  <palves@redhat.com>
3725
3726         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3727         (inf_has_multiple_threads): Return 'bool' and rewrite using
3728         inferior_info::threads().
3729
3730 2019-03-06  Pedro Alves  <palves@redhat.com>
3731
3732         * linux-fork.c: Include <list>.
3733         (fork_list): Now a std::list instance.
3734         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3735         (forks_exist_p, find_last_fork): Adjust.
3736         (new_fork): Delete.
3737         (one_fork_p): New.
3738         (add_fork): Adjust.
3739         (free_fork): Delete, folded into fork_info::~fork_info().
3740         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3741         Adjust.
3742         (init_fork_list): Delete.
3743         (linux_fork_killall, linux_fork_mourn_inferior)
3744         (linux_fork_detach, info_checkpoints_command): Adjust.
3745         (_initialize_linux_fork): No longer call init_fork_list.
3746
3747 2019-03-06  Pedro Alves  <palves@redhat.com>
3748
3749         * linux-fork.c (new_fork): New, split out of ...
3750         (add_fork): ... this.  Return void.  Move "first fork" special
3751         case from here, to ...
3752         (checkpoint_command): ... here.
3753         * linux-linux.h (add_fork): Return void.
3754
3755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3758
3759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3760             Chris January  <chris.january@arm.com>
3761             David Lecomber  <david.lecomber@arm.com>
3762
3763         * f-exp.y: New token, UNOP_INTRINSIC.
3764         (exp): New pattern using UNOP_INTRINSIC token.
3765         (f77_keywords): Add 'abs' keyword.
3766         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3767         (value_from_host_double): New function.
3768         (evaluate_subexp_f): Support UNOP_ABS.
3769
3770 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3773         types.
3774
3775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3778         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3779         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3780
3781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3784
3785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3786             Chris January  <chris.january@arm.com>
3787
3788         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3789         * f-exp.y: Define 'KIND' token.
3790         (exp): New pattern for KIND expressions.
3791         (ptype): Handle types with a kind extension.
3792         (direct_abs_decl): Extend to spot kind extensions.
3793         (f77_keywords): Add 'kind' to the list.
3794         (push_kind_type): New function.
3795         (convert_to_kind_type): New function.
3796         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3797         * parse.c (operator_length_standard): Likewise.
3798         * parser-defs.h (enum type_pieces): Add tp_kind.
3799         * std-operator.def: Add UNOP_KIND.
3800
3801 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         * f-exp.y (f_parse): Set yydebug.
3804
3805 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * f-lang.c (evaluate_subexp_f): New function.
3808         (exp_descriptor_f): New global.
3809         (f_language_defn): Use exp_descriptor_f instead of
3810         exp_descriptor_standard.
3811
3812 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * f-exp.y (struct token): Add comments.
3815         (dot_ops): Remove uppercase versions and the end marker.
3816         (f77_keywords): Likewise.
3817         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3818         entries in the dot_ops array are case insensitive, and use
3819         strncasecmp to compare strings.  Also some whitespace cleanup in
3820         this area.  Similar for the f77_keywords array, except entries in
3821         this list might be case sensitive.
3822
3823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * f-exp.y (struct f77_boolean_val): Add comments.
3826         (boolean_values): Remove uppercase versions, and end marker.
3827         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3828         and use strncasecmp to achieve case insensitivity.  Additionally,
3829         perform whitespace cleanup around this code.
3830
3831 2019-03-06  Tom Tromey  <tromey@adacore.com>
3832
3833         * remote-sim.c (gdbsim_target_open): Use result of
3834         gdb_argv::release.
3835
3836 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3837         Dirk Schubert  <dirk.schubert@arm.com>
3838         Chris January  <chris.january@arm.com>
3839
3840         * eval.c (evaluate_subexp_standard): Call Fortran argument
3841         wrapping logic.
3842         * f-lang.c (struct value): A value which can be passed into a
3843         Fortran function call.
3844         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3845         where appropriate.
3846         (struct type): Value ready for a Fortran function call.
3847         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3848         is needed.
3849         * f-lang.h (fortran_argument_convert): Declaration.
3850         (fortran_preserve_arg_pointer): Declaration.
3851         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3852
3853 2019-03-05  Tom Tromey  <tromey@adacore.com>
3854
3855         * python/py-prettyprint.c (print_string_repr): Remove #if.
3856         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3857
3858 2019-03-05  Tom Tromey  <tromey@adacore.com>
3859
3860         * target.c (the_dummy_target): Move later.  Change type to
3861         "dummy_target".
3862         (initialize_targets): Don't initialize the_dummy_target.
3863
3864 2019-03-05  Tom Tromey  <tromey@adacore.com>
3865
3866         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3867         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3868
3869 2019-03-05  Tom Tromey  <tromey@adacore.com>
3870
3871         * windows-nat.c (windows_nat_target::attach)
3872         (windows_nat_target::detach): Don't call gdb_flush.
3873         * valprint.c (generic_val_print, val_print, val_print_string):
3874         Don't call gdb_flush.
3875         * utils.c (defaulted_query): Don't call gdb_flush.
3876         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3877         * target.c (target_announce_detach): Don't call gdb_flush.
3878         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3879         * remote.c (extended_remote_target::attach): Don't call
3880         gdb_flush.
3881         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3882         * printcmd.c (do_examine): Don't call gdb_flush.
3883         (info_display_command): Don't call gdb_flush.
3884         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3885         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3886         * memattr.c (info_mem_command): Don't call gdb_flush.
3887         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3888         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3889         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3890         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3891         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3892         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3893         (gnu_nat_target::detach): Don't call gdb_flush.
3894         * f-valprint.c (f_val_print): Don't call gdb_flush.
3895         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3896         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3897         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3898         gdb_flush.
3899         * c-valprint.c (c_val_print): Don't call gdb_flush.
3900         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3901
3902 2019-03-05  Tom Tromey  <tromey@adacore.com>
3903
3904         * varobj.c (update_dynamic_varobj_children): Update.
3905         (install_default_visualizer): Use reset, not release.
3906         * value.c (set_internalvar): Update.
3907         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3908         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3909         ATTRIBUTE_UNUSED_RESULT.
3910
3911 2019-03-05  Tom Tromey  <tromey@adacore.com>
3912
3913         * remote.c (class scoped_remote_fd) <release>: Add
3914         ATTRIBUTE_UNUSED_RESULT.
3915
3916 2019-03-05  Tom Tromey  <tromey@adacore.com>
3917
3918         * macroexp.c (struct macro_buffer) <release>: Add
3919         ATTRIBUTE_UNUSED_RESULT.
3920
3921 2019-03-05  Tom Tromey  <tromey@adacore.com>
3922
3923         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3924         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3925         ATTRIBUTE_UNUSED_RESULT.
3926
3927 2019-03-05  Tom Tromey  <tromey@adacore.com>
3928
3929         * common/scoped_fd.h (class scoped_fd) <release>: Add
3930         ATTRIBUTE_UNUSED_RESULT.
3931
3932 2019-03-05  Tom Tromey  <tromey@adacore.com>
3933
3934         * parser-defs.h (struct parser_state) <release>: Add
3935         ATTRIBUTE_UNUSED_RESULT.
3936
3937 2019-03-05  Tom Tromey  <tromey@adacore.com>
3938
3939         * utils.h (class gdb_argv) <release>: Add
3940         ATTRIBUTE_UNUSED_RESULT.
3941         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3942
3943 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3944
3945         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3946         for-loop range, to avoid compiler warnings.
3947
3948         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3949         avoid compiler warnings about unused variables.
3950
3951         * NEWS: Mention end of support for native debugging on MS-Windows
3952         before XP.
3953
3954         PR gdb/24292
3955         * common/netstuff.c:
3956         * gdbserver/gdbreplay.c
3957         * gdbserver/remote-utils.c:
3958         * ser-tcp.c:
3959         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3960         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3961         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3962         'getaddrinfo' and 'freeaddrinfo' were not available before
3963         Windows XP, and mingw.org's MinGW headers by default define
3964         _WIN32_WINNT to 0x500.
3965
3966 2019-03-01  Gary Benson <gbenson@redhat.com>
3967
3968         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3969
3970 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3971             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3972
3973         PR gdb/8527
3974         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3975         set_sigint_trap, clear_sigint_trap.
3976
3977 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3978
3979         * target.c (target_detach): Clear the regcache and the
3980         frame cache.
3981
3982 2019-02-27  Pedro Alves  <palves@redhat.com>
3983
3984         * utils.c (set_screen_size): When we cap the height/width sizes,
3985         tweak the corresponding command variable to show "unlimited":
3986
3987 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3988             Pedro Alves  <palves@redhat.com>
3989
3990         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3991         before calling rl_set_screen_size.
3992
3993 2019-02-27  Tom Tromey  <tromey@adacore.com>
3994
3995         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3996         define.
3997         * python/py-value.c: Remove Python 2.4 workaround.
3998         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3999         workaround.
4000         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4001         Python 2.4 workaround.
4002         * python/python-internal.h: Remove Python 2.4 comment.
4003         (Py_ssize_t): Don't define.
4004         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4005         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4006         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4007         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4008         * python/python.c (do_start_initialization): Remove Python 2.4
4009         workaround.
4010         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4011         (print_children): Remove Python 2.4 workaround.
4012         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4013         workaround.
4014         (CHARBUFFERPROC_NAME): Remove.
4015         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4016         Python 2.4 workaround.
4017
4018 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4019
4020         * NEWS: Note minimum Python version.
4021
4022 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4023
4024         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4025         code from these functions.  Remove corresponding ifdefs.  Use
4026         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4027         Remove gotos and target of gotos.
4028         (infpy_search_memory): Likewise.
4029
4030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4033         (hppa_gdbarch_init): Don't register deleted functions with
4034         gdbarch.
4035
4036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4037
4038         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4039         (h8300_unwind_sp): Delete.
4040         (h8300_dummy_id): Delete.
4041         (h8300_gdbarch_init): Don't register deleted functions with
4042         gdbarch.
4043
4044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4045
4046         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4047         (ft32_unwind_pc): Delete.
4048         (ft32_unwind_sp): Delete.
4049         (ft32_gdbarch_init): Don't register deleted functions with
4050         gdbarch.
4051
4052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4055         (frv_unwind_pc): Delete.
4056         (frv_unwind_sp): Delete.
4057         (frv_gdbarch_init): Don't register deleted functions with
4058         gdbarch.
4059
4060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4063         (riscv_unwind_pc): Delete.
4064         (riscv_unwind_sp): Delete.
4065         (riscv_gdbarch_init): Don't register deleted functions with
4066         gdbarch.
4067
4068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4071         (csky_unwind_pc): Delete.
4072         (csky_unwind_sp): Delete.
4073         (csky_gdbarch_init): Don't register deleted functions with
4074         gdbarch.
4075
4076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4077
4078         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4079         (cris_unwind_pc): Delete.
4080         (cris_unwind_sp): Delete.
4081         (cris_gdbarch_init): Don't register deleted functions with
4082         gdbarch.
4083
4084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4087         (bfin_unwind_pc): Delete.
4088         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4089
4090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4093         (arm_unwind_pc): Delete.
4094         (arm_unwind_sp): Delete.
4095         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4096
4097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4100         (arc_unwind_pc): Delete.
4101         (arc_unwind_sp): Delete.
4102         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4103
4104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4105
4106         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4107         (alpha_unwind_pc): Delete.
4108         (alpha_gdbarch_init): Don't register deleted functions with
4109         gdbarch.
4110
4111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4114         (aarch64_unwind_pc): Delete.
4115         (aarch64_unwind_sp): Delete.
4116         (aarch64_gdbarch_init): Don't register deleted functions with
4117         gdbarch.
4118
4119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * gdbtypes.c (type_align): Don't consider static members when
4122         computing structure alignment.
4123
4124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4125
4126         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4127         return 0 for other types.
4128         * arch-utils.c (default_type_align): Always return 0.
4129         * gdbarch.h: Regenerate.
4130         * gdbarch.sh (type_align): Extend comment.
4131         * gdbtypes.c (type_align): Add additional comments, always call
4132         gdbarch_type_align before applying the default rules.
4133         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4134         generic code will then apply a suitable default.
4135         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4136         types, return 0 for other types.
4137
4138 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4139
4140         * NEWS: Create a new section for the next release branch.
4141         Rename the section of the current branch, now that it has
4142         been cut.
4143
4144 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4145
4146         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4147         * version.in: Bump version to 8.3.50.DATE-git.
4148
4149 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4150
4151         * aix-thread.c (ptid_cmp): Remove unused variable.
4152         (get_signaled_thread): Likewise.
4153         (store_regs_user_thread): Likewise.
4154         (store_regs_kernel_thread): Likewise.
4155         (fetch_regs_kernel_thread): Remove shadowed variable.
4156
4157 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * features/riscv/32bit-cpu.xml: Add register numbers.
4160         * features/riscv/32bit-fpu.c: Regenerate.
4161         * features/riscv/32bit-fpu.xml: Add register numbers.
4162         * features/riscv/64bit-cpu.xml: Add register numbers.
4163         * features/riscv/64bit-fpu.c: Regenerate.
4164         * features/riscv/64bit-fpu.xml: Add register numbers.
4165
4166 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4167
4168         * NEWS: Mention two argument form of gdb.Value constructor.
4169         * python/py-value.c (convert_buffer_and_type_to_value): New
4170         function.
4171         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4172         Add support for handling an optional second argument.  Call
4173         convert_buffer_and_type_to_value as appropriate.
4174         * python/python-internal.h (Py_buffer_deleter): New struct.
4175         (Py_buffer_up): New typedef.
4176
4177 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4178
4179         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4180         instead of releasing ownership.
4181
4182 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4183
4184         * dwarf2read.c (open_and_init_dwp_file): Call
4185         elf_numsections instead of bfd_count_sections to initialize
4186         dwp_file->num_sections.
4187
4188 2019-02-25  Tom Tromey  <tromey@adacore.com>
4189
4190         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4191
4192 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4193
4194         * gcore.in: Add '--readnever' option when invoking GDB.
4195
4196 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4197
4198         * MAINTAINERS: Update my email address.
4199
4200 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4201
4202         * build-id.c (build_id_to_debug_bfd_1): New function.
4203         (build_id_to_debug_bfd): Look for separate debug file in
4204         sysroot.
4205
4206 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * gdbarch.sh: Update the copyright year range that is placed into
4209         generated files.
4210
4211 2019-02-22  Keith Seitz  <keiths@redhat.com>
4212
4213         PR symtab/23853
4214         * linespec.c (create_sals_line_offset): Search for the default
4215         symtab's filename instead of its fullname.
4216
4217 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4218
4219         * NEWS: Update style defaults.
4220
4221 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4222
4223         * main.c (captured_main_1): Disable styling in batch mode.
4224
4225 2019-02-20  Tom Tromey  <tom@tromey.com>
4226
4227         * symtab.c (symtab_symbol_info): Fix typos.
4228
4229 2019-02-20  Tom Tromey  <tromey@adacore.com>
4230
4231         * findcmd.c (_initialize_mem_search): Use upper case for
4232         metasyntactic variables.
4233
4234 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4235
4236         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4237         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4238
4239 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4240
4241         * top.h (source_file_name): Change to std::string.
4242         * top.c (source_file_name): Likewise.
4243         (command_line_input): Adjust.
4244         * cli/cli-script.c (script_from_file): Adjust.
4245
4246 2019-02-19  Tom Tromey  <tromey@adacore.com>
4247
4248         * ravenscar-thread.c
4249         (ravenscar_thread_target::update_thread_list): Don't call
4250         ada_build_task_list.
4251         * ada-lang.h (ada_build_task_list): Don't declare.
4252         * ada-tasks.c (struct ada_tasks_inferior_data)
4253         <task_list_valid_p>: Now bool.
4254         (read_known_tasks, ada_task_list_changed)
4255         (ada_tasks_invalidate_inferior_data): Update.
4256         (read_known_tasks_array): Return bool.
4257         (read_known_tasks_list): Likewise.
4258         (read_known_tasks): Return void.
4259         (ada_build_task_list): Now static.
4260
4261 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4262
4263         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4264         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4265
4266 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4267
4268         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4269         variant for ada_tasks_pspace_data_handle and
4270         ada_tasks_inferior_data_handle.
4271         (ada_tasks_pspace_data_cleanup): New function.
4272         (ada_tasks_inferior_data_cleanup): New function.
4273
4274 2019-02-17  Tom Tromey  <tom@tromey.com>
4275
4276         * macrotab.h (macro_source_fullname): Return a std::string.
4277         * macrotab.c (macro_include, check_for_redefinition)
4278         (macro_undef, macro_lookup_definition, foreach_macro)
4279         (foreach_macro_in_scope): Update.
4280         (macro_source_fullname): Return a std::string.
4281         * macrocmd.c (show_pp_source_pos): Update.
4282
4283 2019-02-17  Tom Tromey  <tom@tromey.com>
4284
4285         * macrocmd.c (show_pp_source_pos): Style the file names.
4286
4287 2019-02-17  Tom Tromey  <tom@tromey.com>
4288
4289         PR tui/24197:
4290         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4291
4292 2019-02-17  Tom Tromey  <tom@tromey.com>
4293
4294         * ada-lang.c (user_select_syms): Use filtered printing.
4295         * utils.c (wrap_style): New global.
4296         (desired_style): Remove.
4297         (emit_style_escape): Add stream parameter.
4298         (set_output_style, reset_terminal_style, prompt_for_continue):
4299         Update.
4300         (flush_wrap_buffer): Only flush gdb_stdout.
4301         (wrap_here): Set wrap_style.
4302         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4303         treat escape sequences as a character.  Change when wrap buffer is
4304         flushed.
4305         (fputs_styled): Do not set the output style when the default is
4306         requested.
4307         * ui-style.h (struct ui_file_style) <is_default>: New method.
4308         * source.c (print_source_lines_base): Emit escape sequences in one
4309         piece.
4310
4311 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4312
4313         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4314         integers and enumeration types.
4315
4316 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4317
4318         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4319         instead of lookup_symbol_in_language
4320         (do_exact_match): New function.
4321         (ada_get_symbol_name_matcher): Return do_exact_match when
4322         doing a verbatim match.
4323
4324 2019-02-15  Tom Tromey  <tromey@adacore.com>
4325
4326         * ravenscar-thread.c (ravenscar_thread_target::resume)
4327         (ravenscar_thread_target::wait): Special case wildcard requests.
4328
4329 2019-02-15  Tom Tromey  <tromey@adacore.com>
4330
4331         * ravenscar-thread.c (base_ptid): Remove.
4332         (struct ravenscar_thread_target) <close>: New method.
4333         <m_base_ptid>: New member.
4334         <update_inferior_ptid, active_task, task_is_currently_active,
4335         runtime_initialized>: Declare methods.
4336         <ravenscar_thread_target>: Add constructor.
4337         (ravenscar_thread_target::task_is_currently_active)
4338         (ravenscar_thread_target::update_inferior_ptid)
4339         (ravenscar_runtime_initialized): Rename.  Now methods.
4340         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4341         (ravenscar_thread_target::update_thread_list): Update.
4342         (ravenscar_thread_target::active_task): Now method.
4343         (ravenscar_thread_target::store_registers)
4344         (ravenscar_thread_target::prepare_to_store)
4345         (ravenscar_thread_target::prepare_to_store)
4346         (ravenscar_thread_target::mourn_inferior): Update.
4347         (ravenscar_inferior_created): Use "new" to create target.
4348         (ravenscar_thread_target::get_ada_task_ptid): Update.
4349         (_initialize_ravenscar): Don't initialize base_ptid.
4350         (ravenscar_ops): Remove global.
4351
4352 2019-02-15  Tom Tromey  <tromey@adacore.com>
4353
4354         * target.h (push_target): Declare new overload.
4355         * target.c (push_target): New overload, taking an rvalue reference.
4356         * remote.c (remote_target::open_1): Use push_target overload.
4357         * corelow.c (core_target_open): Use push_target overload.
4358
4359 2019-02-15  Tom Tromey  <tromey@adacore.com>
4360
4361         * ravenscar-thread.c (is_ravenscar_task)
4362         (ravenscar_task_is_currently_active): Return bool.
4363         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4364         (_initialize_ravenscar): Remove "(void)".
4365         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4366         Return bool.
4367
4368 2019-02-15  Tom Tromey  <tromey@adacore.com>
4369
4370         * ravenscar-thread.c (ravenscar_runtime_initializer)
4371         (has_ravenscar_runtime, get_running_thread_id)
4372         (ravenscar_thread_target::resume): Fix indentation.
4373
4374 2019-02-15  Tom Tromey  <tromey@adacore.com>
4375
4376         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4377         from ravenscar_arch_ops.
4378         (sparc_ravenscar_ops::fetch_registers)
4379         (sparc_ravenscar_ops::store_registers): Now methods.
4380         (sparc_ravenscar_prepare_to_store): Remove.
4381         (sparc_ravenscar_ops): Redefine.
4382         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4383         methods and destructor.  Remove members.
4384         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4385         (ravenscar_thread_target::store_registers)
4386         (ravenscar_thread_target::prepare_to_store): Update.
4387         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4388         Remove.
4389         (struct ppc_ravenscar_powerpc_ops): Derive from
4390         ravenscar_arch_ops.
4391         (ppc_ravenscar_powerpc_ops::fetch_registers)
4392         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4393         (ppc_ravenscar_powerpc_ops): Redefine.
4394         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4395         (ppc_ravenscar_e500_ops::fetch_registers)
4396         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4397         (ppc_ravenscar_e500_ops): Redefine.
4398         * aarch64-ravenscar-thread.c
4399         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4400         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4401         (aarch64_ravenscar_fetch_registers)
4402         (aarch64_ravenscar_store_registers): Now methods.
4403         (aarch64_ravenscar_ops): Redefine.
4404
4405 2019-02-15  Tom Tromey  <tromey@adacore.com>
4406
4407         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4408         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4409         (ravenscar_thread_target::stopped_by_watchpoint)
4410         (ravenscar_thread_target::stopped_data_address)
4411         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4412
4413 2019-02-15  Tom Tromey  <tromey@adacore.com>
4414
4415         * ravenscar-thread.c: Fix some typos.
4416
4417 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4418             Tom Tromey  <tromey@adacore.com>
4419
4420         * ada-lang.c (ada_exception_sal): Change addr_string to a
4421         std::string.
4422         (create_ada_exception_catchpoint): Update.
4423
4424 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4425             Tom Tromey  <tromey@adacore.com>
4426
4427         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4428         (bp_location_ops): Remove.
4429         (base_breakpoint_allocate_location): Update.
4430         (free_bp_location): Update.
4431         * ada-lang.c (class ada_catchpoint_location)
4432         <ada_catchpoint_location>: Remove ops parameter.
4433         (ada_catchpoint_location_dtor): Remove.
4434         (ada_catchpoint_location_ops): Remove.
4435         (allocate_location_exception): Update.
4436         * breakpoint.h (struct bp_location_ops): Remove.
4437         (class bp_location) <bp_location>: Remove bp_location_ops
4438         parameter.
4439         <~bp_location>: Add destructor.
4440         <ops>: Remove.
4441
4442 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4443             Pedro Alves  <palves@redhat.com>
4444
4445         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4446         'PATH_MAX'.
4447
4448 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4449             Samuel Thibault  <samuel.thibault@gnu.org>
4450             Thomas Schwinge  <thomas@codesourcery.com>
4451
4452         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4453         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4454
4455 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4456
4457         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4458         (check_empty): Use "const char *".
4459
4460         * gnu-nat.c (gnu_nat_target::detach): Instead of
4461         'detach_inferior (pid)' call
4462         'detach_inferior (find_inferior_pid (pid))'.
4463
4464         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4465         'nat/fork-inferior.o'.
4466         * gnu-nat.c: #include "nat/fork-inferior.h".
4467
4468         * gnu-nat.c (gnu_nat_target::detach): Instead of
4469         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4470         * gnu-nat.h: #include "inf-child.h".
4471         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4472         'i386_gnu_nat_target::fetch_registers'.
4473         (gnu_store_registers): Rename/move to
4474         'i386_gnu_nat_target::store_registers'.
4475
4476         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4477         * gnu-nat.h (mach_thread_info): New function.
4478         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4479
4480         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4481
4482 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4483
4484         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4485
4486 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4487
4488         * windows-nat.c (windows_add_thread): Add new parameter
4489         "main_thread_p" with default value set to false.  Update
4490         function documentation as well as all callers.
4491         (windows_delete_thread): Likewise.
4492         (fake_create_process): Update call to windows_add_thread.
4493         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4494         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4495         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4496         call to windows_delete_thread.
4497
4498 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4499
4500         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4501
4502 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4503
4504         * symfile.c (find_separate_debug_file): Use canonical path of
4505         sysroot with child_path instead of gdb_sysroot if it is valid.
4506
4507 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4508
4509         * symfile.c (find_separate_debug_file): Use child_path to
4510         determine if an object file is under a sysroot.
4511
4512 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4513
4514         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4515         unittests/child-path-selftests.c.
4516         * common/pathstuff.c (child_path): New function.
4517         * common/pathstuff.h (child_path): New prototype.
4518         * unittests/child-path-selftests.c: New file.
4519
4520 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4521
4522         * symfile.c (find_separate_debug_file): Look for separate debug
4523         files in debug directories under the sysroot.
4524
4525 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4526
4527         * symtab.h (struct minimal_symbol data_p): New const method.
4528         (struct minimal_symbol text_p): Likewise.
4529         * symtab.c (output_source_filename): Use file name style
4530         to print file name.
4531         (print_symbol_info): Likewise.
4532         (print_msymbol_info): Use address style to print addresses.
4533         Use function name style to print executable text symbols.
4534         (expand_symtab_containing_pc): Use data_p.
4535         (find_pc_sect_compunit_symtab): Likewise.
4536
4537 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4538
4539         * breakpoint.c (describe_other_breakpoints): Use address style
4540         to print addresses.
4541         (say_where): Likewise.
4542
4543 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4544
4545         * ada-typeprint.c (print_func_type): Print function name
4546         style to print function name.
4547         * c-typeprint.c (c_print_type_1): Likewise.
4548
4549 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4550
4551         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4552         for execve.
4553
4554 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4557         type_stack.
4558
4559 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4560
4561         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4562         TYPE_CODE_REF types.
4563
4564 2019-02-08  Jim Wilson  <jimw@sifive.com>
4565
4566         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4567         (riscv_linux_fregset): New.
4568         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4569
4570 2019-02-07  Tom Tromey  <tom@tromey.com>
4571
4572         * thread.c (thread_cancel_execution_command): Update.
4573         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4574         methods.
4575         (struct thread_fsm_ops): Remove.
4576         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4577         (thread_fsm_should_stop, thread_fsm_return_value)
4578         (thread_fsm_set_finished, thread_fsm_finished_p)
4579         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4580         Don't declare.
4581         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4582         * infrun.c (clear_proceed_status_thread)
4583         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4584         (print_stop_event): Update.
4585         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4586         Add constructor.
4587         (step_command_fsm_ops): Remove.
4588         (new_step_command_fsm): Remove.
4589         (step_1): Update.
4590         (step_command_fsm::should_stop): Rename from
4591         step_command_fsm_should_stop.
4592         (step_command_fsm::clean_up): Rename from
4593         step_command_fsm_clean_up.
4594         (step_command_fsm::do_async_reply_reason): Rename from
4595         step_command_fsm_async_reply_reason.
4596         (struct until_next_fsm): Inherit from thread_fsm.  Add
4597         constructor.
4598         (until_next_fsm_ops): Remove.
4599         (new_until_next_fsm): Remove.
4600         (until_next_fsm::should_stop): Rename from
4601         until_next_fsm_should_stop.
4602         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4603         (until_next_fsm::do_async_reply_reason): Rename from
4604         until_next_fsm_async_reply_reason.
4605         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4606         constructor.  Change type of breakpoint.
4607         (finish_command_fsm_ops): Remove.
4608         (new_finish_command_fsm): Remove.
4609         (finish_command_fsm::should_stop): Rename from
4610         finish_command_fsm_should_stop.
4611         (finish_command_fsm::clean_up): Rename from
4612         finish_command_fsm_clean_up.
4613         (finish_command_fsm::return_value): Rename from
4614         finish_command_fsm_return_value.
4615         (finish_command_fsm::do_async_reply_reason): Rename from
4616         finish_command_fsm_async_reply_reason.
4617         (finish_command): Update.
4618         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4619         Add constructor.
4620         (call_thread_fsm_ops): Remove.
4621         (call_thread_fsm::call_thread_fsm): Rename from
4622         new_call_thread_fsm.
4623         (call_thread_fsm::should_stop): Rename from
4624         call_thread_fsm_should_stop.
4625         (call_thread_fsm::should_notify_stop): Rename from
4626         call_thread_fsm_should_notify_stop.
4627         (run_inferior_call, call_function_by_hand_dummy): Update.
4628         * cli/cli-interp.c (should_print_stop_to_console): Update.
4629         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4630         Add constructor.  Change type of location_breakpoint,
4631         caller_breakpoint.
4632         (until_break_fsm_ops): Remove.
4633         (new_until_break_fsm): Remove.
4634         (until_break_fsm::should_stop): Rename from
4635         until_break_fsm_should_stop.
4636         (until_break_fsm::clean_up): Rename from
4637         until_break_fsm_clean_up.
4638         (until_break_fsm::do_async_reply_reason): Rename from
4639         until_break_fsm_async_reply_reason.
4640         (until_break_command): Update.
4641         * thread-fsm.c: Remove.
4642         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4643
4644 2019-02-07  Tom Tromey  <tom@tromey.com>
4645
4646         * yy-remap.h: Add include guard.
4647         * xtensa-tdep.h: Add include guard.
4648         * xcoffread.h: Rename include guard.
4649         * varobj-iter.h: Add include guard.
4650         * tui/tui.h: Rename include guard.
4651         * tui/tui-winsource.h: Rename include guard.
4652         * tui/tui-wingeneral.h: Rename include guard.
4653         * tui/tui-windata.h: Rename include guard.
4654         * tui/tui-win.h: Rename include guard.
4655         * tui/tui-stack.h: Rename include guard.
4656         * tui/tui-source.h: Rename include guard.
4657         * tui/tui-regs.h: Rename include guard.
4658         * tui/tui-out.h: Rename include guard.
4659         * tui/tui-layout.h: Rename include guard.
4660         * tui/tui-io.h: Rename include guard.
4661         * tui/tui-hooks.h: Rename include guard.
4662         * tui/tui-file.h: Rename include guard.
4663         * tui/tui-disasm.h: Rename include guard.
4664         * tui/tui-data.h: Rename include guard.
4665         * tui/tui-command.h: Rename include guard.
4666         * tic6x-tdep.h: Add include guard.
4667         * target/waitstatus.h: Rename include guard.
4668         * target/wait.h: Rename include guard.
4669         * target/target.h: Rename include guard.
4670         * target/resume.h: Rename include guard.
4671         * target-float.h: Rename include guard.
4672         * stabsread.h: Add include guard.
4673         * rs6000-tdep.h: Add include guard.
4674         * riscv-fbsd-tdep.h: Add include guard.
4675         * regformats/regdef.h: Rename include guard.
4676         * record.h: Rename include guard.
4677         * python/python.h: Rename include guard.
4678         * python/python-internal.h: Rename include guard.
4679         * python/py-stopevent.h: Rename include guard.
4680         * python/py-ref.h: Rename include guard.
4681         * python/py-record.h: Rename include guard.
4682         * python/py-record-full.h: Rename include guard.
4683         * python/py-record-btrace.h: Rename include guard.
4684         * python/py-instruction.h: Rename include guard.
4685         * python/py-events.h: Rename include guard.
4686         * python/py-event.h: Rename include guard.
4687         * procfs.h: Add include guard.
4688         * proc-utils.h: Add include guard.
4689         * p-lang.h: Add include guard.
4690         * or1k-tdep.h: Rename include guard.
4691         * observable.h: Rename include guard.
4692         * nto-tdep.h: Rename include guard.
4693         * nat/x86-linux.h: Rename include guard.
4694         * nat/x86-linux-dregs.h: Rename include guard.
4695         * nat/x86-gcc-cpuid.h: Add include guard.
4696         * nat/x86-dregs.h: Rename include guard.
4697         * nat/x86-cpuid.h: Rename include guard.
4698         * nat/ppc-linux.h: Rename include guard.
4699         * nat/mips-linux-watch.h: Rename include guard.
4700         * nat/linux-waitpid.h: Rename include guard.
4701         * nat/linux-ptrace.h: Rename include guard.
4702         * nat/linux-procfs.h: Rename include guard.
4703         * nat/linux-osdata.h: Rename include guard.
4704         * nat/linux-nat.h: Rename include guard.
4705         * nat/linux-namespaces.h: Rename include guard.
4706         * nat/linux-btrace.h: Rename include guard.
4707         * nat/glibc_thread_db.h: Rename include guard.
4708         * nat/gdb_thread_db.h: Rename include guard.
4709         * nat/gdb_ptrace.h: Rename include guard.
4710         * nat/fork-inferior.h: Rename include guard.
4711         * nat/amd64-linux-siginfo.h: Rename include guard.
4712         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4713         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4714         * nat/aarch64-linux.h: Rename include guard.
4715         * nat/aarch64-linux-hw-point.h: Rename include guard.
4716         * mn10300-tdep.h: Add include guard.
4717         * mips-linux-tdep.h: Add include guard.
4718         * mi/mi-parse.h: Rename include guard.
4719         * mi/mi-out.h: Rename include guard.
4720         * mi/mi-main.h: Rename include guard.
4721         * mi/mi-interp.h: Rename include guard.
4722         * mi/mi-getopt.h: Rename include guard.
4723         * mi/mi-console.h: Rename include guard.
4724         * mi/mi-common.h: Rename include guard.
4725         * mi/mi-cmds.h: Rename include guard.
4726         * mi/mi-cmd-break.h: Rename include guard.
4727         * m2-lang.h: Add include guard.
4728         * location.h: Rename include guard.
4729         * linux-record.h: Rename include guard.
4730         * linux-nat.h: Add include guard.
4731         * linux-fork.h: Add include guard.
4732         * i386-darwin-tdep.h: Rename include guard.
4733         * hppa-linux-offsets.h: Add include guard.
4734         * guile/guile.h: Rename include guard.
4735         * guile/guile-internal.h: Rename include guard.
4736         * gnu-nat.h: Rename include guard.
4737         * gdb-stabs.h: Rename include guard.
4738         * frv-tdep.h: Add include guard.
4739         * f-lang.h: Add include guard.
4740         * event-loop.h: Add include guard.
4741         * darwin-nat.h: Rename include guard.
4742         * cp-abi.h: Rename include guard.
4743         * config/sparc/nm-sol2.h: Rename include guard.
4744         * config/nm-nto.h: Rename include guard.
4745         * config/nm-linux.h: Add include guard.
4746         * config/i386/nm-i386gnu.h: Rename include guard.
4747         * config/djgpp/nl_types.h: Rename include guard.
4748         * config/djgpp/langinfo.h: Rename include guard.
4749         * compile/gcc-cp-plugin.h: Add include guard.
4750         * compile/gcc-c-plugin.h: Add include guard.
4751         * compile/compile.h: Rename include guard.
4752         * compile/compile-object-run.h: Rename include guard.
4753         * compile/compile-object-load.h: Rename include guard.
4754         * compile/compile-internal.h: Rename include guard.
4755         * compile/compile-cplus.h: Rename include guard.
4756         * compile/compile-c.h: Rename include guard.
4757         * common/xml-utils.h: Rename include guard.
4758         * common/x86-xstate.h: Rename include guard.
4759         * common/version.h: Rename include guard.
4760         * common/vec.h: Rename include guard.
4761         * common/tdesc.h: Rename include guard.
4762         * common/selftest.h: Rename include guard.
4763         * common/scoped_restore.h: Rename include guard.
4764         * common/scoped_mmap.h: Rename include guard.
4765         * common/scoped_fd.h: Rename include guard.
4766         * common/safe-iterator.h: Rename include guard.
4767         * common/run-time-clock.h: Rename include guard.
4768         * common/refcounted-object.h: Rename include guard.
4769         * common/queue.h: Rename include guard.
4770         * common/ptid.h: Rename include guard.
4771         * common/print-utils.h: Rename include guard.
4772         * common/preprocessor.h: Rename include guard.
4773         * common/pathstuff.h: Rename include guard.
4774         * common/observable.h: Rename include guard.
4775         * common/netstuff.h: Rename include guard.
4776         * common/job-control.h: Rename include guard.
4777         * common/host-defs.h: Rename include guard.
4778         * common/gdb_wait.h: Rename include guard.
4779         * common/gdb_vecs.h: Rename include guard.
4780         * common/gdb_unlinker.h: Rename include guard.
4781         * common/gdb_unique_ptr.h: Rename include guard.
4782         * common/gdb_tilde_expand.h: Rename include guard.
4783         * common/gdb_sys_time.h: Rename include guard.
4784         * common/gdb_string_view.h: Rename include guard.
4785         * common/gdb_splay_tree.h: Rename include guard.
4786         * common/gdb_setjmp.h: Rename include guard.
4787         * common/gdb_ref_ptr.h: Rename include guard.
4788         * common/gdb_optional.h: Rename include guard.
4789         * common/gdb_locale.h: Rename include guard.
4790         * common/gdb_assert.h: Rename include guard.
4791         * common/filtered-iterator.h: Rename include guard.
4792         * common/filestuff.h: Rename include guard.
4793         * common/fileio.h: Rename include guard.
4794         * common/environ.h: Rename include guard.
4795         * common/common-utils.h: Rename include guard.
4796         * common/common-types.h: Rename include guard.
4797         * common/common-regcache.h: Rename include guard.
4798         * common/common-inferior.h: Rename include guard.
4799         * common/common-gdbthread.h: Rename include guard.
4800         * common/common-exceptions.h: Rename include guard.
4801         * common/common-defs.h: Rename include guard.
4802         * common/common-debug.h: Rename include guard.
4803         * common/cleanups.h: Rename include guard.
4804         * common/buffer.h: Rename include guard.
4805         * common/btrace-common.h: Rename include guard.
4806         * common/break-common.h: Rename include guard.
4807         * cli/cli-utils.h: Rename include guard.
4808         * cli/cli-style.h: Rename include guard.
4809         * cli/cli-setshow.h: Rename include guard.
4810         * cli/cli-script.h: Rename include guard.
4811         * cli/cli-interp.h: Rename include guard.
4812         * cli/cli-decode.h: Rename include guard.
4813         * cli/cli-cmds.h: Rename include guard.
4814         * charset-list.h: Add include guard.
4815         * buildsym-legacy.h: Rename include guard.
4816         * bfin-tdep.h: Add include guard.
4817         * ax.h: Rename include guard.
4818         * arm-linux-tdep.h: Add include guard.
4819         * arm-fbsd-tdep.h: Add include guard.
4820         * arch/xtensa.h: Rename include guard.
4821         * arch/tic6x.h: Add include guard.
4822         * arch/i386.h: Add include guard.
4823         * arch/arm.h: Rename include guard.
4824         * arch/arm-linux.h: Rename include guard.
4825         * arch/arm-get-next-pcs.h: Rename include guard.
4826         * arch/amd64.h: Add include guard.
4827         * arch/aarch64-insn.h: Rename include guard.
4828         * arch-utils.h: Rename include guard.
4829         * annotate.h: Add include guard.
4830         * amd64-darwin-tdep.h: Rename include guard.
4831         * aarch64-linux-tdep.h: Add include guard.
4832         * aarch64-fbsd-tdep.h: Add include guard.
4833         * aarch32-linux-nat.h: Add include guard.
4834
4835 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * macrotab.c (macro_define_internal): New function that
4838         factorizes macro_define_object_internal and macro_define_function
4839         code.
4840         (macro_define_object_internal): Use macro_define_internal.
4841         (macro_define_function): Likewise.
4842
4843 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4844
4845         * macrocmd.c (extract_identifier): Return
4846         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4847         callers.
4848
4849 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4850
4851         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4852
4853 2019-02-05  Tom Tromey  <tom@tromey.com>
4854
4855         * target.c (target_stack::unpush): Move assertion earlier.
4856
4857 2019-01-30  Tom Tromey  <tom@tromey.com>
4858
4859         PR python/23615:
4860         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4861         (gdbpy_parse_and_eval): Likewise.
4862         * python/python-internal.h (gdbpy_allow_threads): New class.
4863
4864 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4865
4866         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4867         (aarch64_fbsd_fpregmap): Move earlier.
4868         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4869         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4870         instead of individual calls to trad_frame_set_reg_addr.
4871         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4872         earlier.
4873         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4874         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4875         instead of individual calls to trad_frame_set_reg_addr.
4876
4877 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4878
4879         * CONTRIBUTE: Replace contribution list with wiki link.
4880
4881 2019-01-25  Tom Tromey  <tom@tromey.com>
4882
4883         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4884
4885 2019-01-25  Tom Tromey  <tom@tromey.com>
4886
4887         * xtensa-linux-nat.c: Fix common/ includes.
4888         * xml-support.h: Fix common/ includes.
4889         * xml-support.c: Fix common/ includes.
4890         * x86-linux-nat.c: Fix common/ includes.
4891         * windows-nat.c: Fix common/ includes.
4892         * varobj.h: Fix common/ includes.
4893         * varobj.c: Fix common/ includes.
4894         * value.c: Fix common/ includes.
4895         * valops.c: Fix common/ includes.
4896         * utils.c: Fix common/ includes.
4897         * unittests/xml-utils-selftests.c: Fix common/ includes.
4898         * unittests/utils-selftests.c: Fix common/ includes.
4899         * unittests/unpack-selftests.c: Fix common/ includes.
4900         * unittests/tracepoint-selftests.c: Fix common/ includes.
4901         * unittests/style-selftests.c: Fix common/ includes.
4902         * unittests/string_view-selftests.c: Fix common/ includes.
4903         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4904         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4905         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4906         * unittests/rsp-low-selftests.c: Fix common/ includes.
4907         * unittests/parse-connection-spec-selftests.c: Fix common/
4908         includes.
4909         * unittests/optional-selftests.c: Fix common/ includes.
4910         * unittests/offset-type-selftests.c: Fix common/ includes.
4911         * unittests/observable-selftests.c: Fix common/ includes.
4912         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4913         * unittests/memrange-selftests.c: Fix common/ includes.
4914         * unittests/memory-map-selftests.c: Fix common/ includes.
4915         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4916         * unittests/function-view-selftests.c: Fix common/ includes.
4917         * unittests/environ-selftests.c: Fix common/ includes.
4918         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4919         * unittests/common-utils-selftests.c: Fix common/ includes.
4920         * unittests/cli-utils-selftests.c: Fix common/ includes.
4921         * unittests/array-view-selftests.c: Fix common/ includes.
4922         * ui-file.c: Fix common/ includes.
4923         * tui/tui-io.c: Fix common/ includes.
4924         * tracepoint.h: Fix common/ includes.
4925         * tracepoint.c: Fix common/ includes.
4926         * tracefile-tfile.c: Fix common/ includes.
4927         * top.h: Fix common/ includes.
4928         * top.c: Fix common/ includes.
4929         * thread.c: Fix common/ includes.
4930         * target/waitstatus.h: Fix common/ includes.
4931         * target/waitstatus.c: Fix common/ includes.
4932         * target.h: Fix common/ includes.
4933         * target.c: Fix common/ includes.
4934         * target-memory.c: Fix common/ includes.
4935         * target-descriptions.c: Fix common/ includes.
4936         * symtab.h: Fix common/ includes.
4937         * symfile.c: Fix common/ includes.
4938         * stap-probe.c: Fix common/ includes.
4939         * spu-linux-nat.c: Fix common/ includes.
4940         * sparc-nat.c: Fix common/ includes.
4941         * source.c: Fix common/ includes.
4942         * solib.c: Fix common/ includes.
4943         * solib-target.c: Fix common/ includes.
4944         * ser-unix.c: Fix common/ includes.
4945         * ser-tcp.c: Fix common/ includes.
4946         * ser-pipe.c: Fix common/ includes.
4947         * ser-base.c: Fix common/ includes.
4948         * selftest-arch.c: Fix common/ includes.
4949         * s12z-tdep.c: Fix common/ includes.
4950         * rust-exp.y: Fix common/ includes.
4951         * rs6000-aix-tdep.c: Fix common/ includes.
4952         * riscv-tdep.c: Fix common/ includes.
4953         * remote.c: Fix common/ includes.
4954         * remote-notif.h: Fix common/ includes.
4955         * remote-fileio.h: Fix common/ includes.
4956         * remote-fileio.c: Fix common/ includes.
4957         * regcache.h: Fix common/ includes.
4958         * regcache.c: Fix common/ includes.
4959         * record-btrace.c: Fix common/ includes.
4960         * python/python.c: Fix common/ includes.
4961         * python/py-type.c: Fix common/ includes.
4962         * python/py-inferior.c: Fix common/ includes.
4963         * progspace.h: Fix common/ includes.
4964         * producer.c: Fix common/ includes.
4965         * procfs.c: Fix common/ includes.
4966         * proc-api.c: Fix common/ includes.
4967         * printcmd.c: Fix common/ includes.
4968         * ppc-linux-nat.c: Fix common/ includes.
4969         * parser-defs.h: Fix common/ includes.
4970         * osdata.c: Fix common/ includes.
4971         * obsd-nat.c: Fix common/ includes.
4972         * nat/x86-linux.c: Fix common/ includes.
4973         * nat/x86-linux-dregs.c: Fix common/ includes.
4974         * nat/x86-dregs.h: Fix common/ includes.
4975         * nat/x86-dregs.c: Fix common/ includes.
4976         * nat/ppc-linux.c: Fix common/ includes.
4977         * nat/mips-linux-watch.h: Fix common/ includes.
4978         * nat/mips-linux-watch.c: Fix common/ includes.
4979         * nat/linux-waitpid.c: Fix common/ includes.
4980         * nat/linux-ptrace.h: Fix common/ includes.
4981         * nat/linux-ptrace.c: Fix common/ includes.
4982         * nat/linux-procfs.c: Fix common/ includes.
4983         * nat/linux-personality.c: Fix common/ includes.
4984         * nat/linux-osdata.c: Fix common/ includes.
4985         * nat/linux-namespaces.c: Fix common/ includes.
4986         * nat/linux-btrace.h: Fix common/ includes.
4987         * nat/linux-btrace.c: Fix common/ includes.
4988         * nat/fork-inferior.c: Fix common/ includes.
4989         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4990         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4991         * nat/aarch64-linux.c: Fix common/ includes.
4992         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4993         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4994         * namespace.h: Fix common/ includes.
4995         * mips-linux-tdep.c: Fix common/ includes.
4996         * minsyms.c: Fix common/ includes.
4997         * mi/mi-parse.h: Fix common/ includes.
4998         * mi/mi-main.c: Fix common/ includes.
4999         * mi/mi-cmd-env.c: Fix common/ includes.
5000         * memrange.h: Fix common/ includes.
5001         * memattr.c: Fix common/ includes.
5002         * maint.h: Fix common/ includes.
5003         * maint.c: Fix common/ includes.
5004         * main.c: Fix common/ includes.
5005         * machoread.c: Fix common/ includes.
5006         * location.c: Fix common/ includes.
5007         * linux-thread-db.c: Fix common/ includes.
5008         * linux-nat.c: Fix common/ includes.
5009         * linux-fork.c: Fix common/ includes.
5010         * inline-frame.c: Fix common/ includes.
5011         * infrun.c: Fix common/ includes.
5012         * inflow.c: Fix common/ includes.
5013         * inferior.h: Fix common/ includes.
5014         * inferior.c: Fix common/ includes.
5015         * infcmd.c: Fix common/ includes.
5016         * inf-ptrace.c: Fix common/ includes.
5017         * inf-child.c: Fix common/ includes.
5018         * ia64-linux-nat.c: Fix common/ includes.
5019         * i387-tdep.c: Fix common/ includes.
5020         * i386-tdep.c: Fix common/ includes.
5021         * i386-linux-tdep.c: Fix common/ includes.
5022         * i386-linux-nat.c: Fix common/ includes.
5023         * i386-go32-tdep.c: Fix common/ includes.
5024         * i386-fbsd-tdep.c: Fix common/ includes.
5025         * i386-fbsd-nat.c: Fix common/ includes.
5026         * guile/scm-type.c: Fix common/ includes.
5027         * guile/guile.c: Fix common/ includes.
5028         * go32-nat.c: Fix common/ includes.
5029         * gnu-nat.c: Fix common/ includes.
5030         * gdbthread.h: Fix common/ includes.
5031         * gdbarch-selftests.c: Fix common/ includes.
5032         * gdb_usleep.c: Fix common/ includes.
5033         * gdb_select.h: Fix common/ includes.
5034         * gdb_bfd.c: Fix common/ includes.
5035         * gcore.c: Fix common/ includes.
5036         * fork-child.c: Fix common/ includes.
5037         * findvar.c: Fix common/ includes.
5038         * fbsd-nat.c: Fix common/ includes.
5039         * event-top.c: Fix common/ includes.
5040         * event-loop.c: Fix common/ includes.
5041         * dwarf2read.c: Fix common/ includes.
5042         * dwarf2loc.c: Fix common/ includes.
5043         * dwarf2-frame.c: Fix common/ includes.
5044         * dwarf-index-cache.c: Fix common/ includes.
5045         * dtrace-probe.c: Fix common/ includes.
5046         * disasm-selftests.c: Fix common/ includes.
5047         * defs.h: Fix common/ includes.
5048         * csky-tdep.c: Fix common/ includes.
5049         * cp-valprint.c: Fix common/ includes.
5050         * cp-support.h: Fix common/ includes.
5051         * cp-support.c: Fix common/ includes.
5052         * corelow.c: Fix common/ includes.
5053         * completer.h: Fix common/ includes.
5054         * completer.c: Fix common/ includes.
5055         * compile/compile.c: Fix common/ includes.
5056         * compile/compile-loc2c.c: Fix common/ includes.
5057         * compile/compile-cplus-types.c: Fix common/ includes.
5058         * compile/compile-cplus-symbols.c: Fix common/ includes.
5059         * command.h: Fix common/ includes.
5060         * cli/cli-dump.c: Fix common/ includes.
5061         * cli/cli-cmds.c: Fix common/ includes.
5062         * charset.c: Fix common/ includes.
5063         * build-id.c: Fix common/ includes.
5064         * btrace.h: Fix common/ includes.
5065         * btrace.c: Fix common/ includes.
5066         * breakpoint.h: Fix common/ includes.
5067         * breakpoint.c: Fix common/ includes.
5068         * ax.h:
5069         (enum agent_op): Fix common/ includes.
5070         * ax-general.c (struct aop_map): Fix common/ includes.
5071         * ax-gdb.c: Fix common/ includes.
5072         * auxv.c: Fix common/ includes.
5073         * auto-load.c: Fix common/ includes.
5074         * arm-tdep.c: Fix common/ includes.
5075         * arch/riscv.c: Fix common/ includes.
5076         * arch/ppc-linux-common.c: Fix common/ includes.
5077         * arch/i386.c: Fix common/ includes.
5078         * arch/arm.c: Fix common/ includes.
5079         * arch/arm-linux.c: Fix common/ includes.
5080         * arch/arm-get-next-pcs.c: Fix common/ includes.
5081         * arch/amd64.c: Fix common/ includes.
5082         * arch/aarch64.c: Fix common/ includes.
5083         * arch/aarch64-insn.c: Fix common/ includes.
5084         * arch-utils.c: Fix common/ includes.
5085         * amd64-windows-tdep.c: Fix common/ includes.
5086         * amd64-tdep.c: Fix common/ includes.
5087         * amd64-sol2-tdep.c: Fix common/ includes.
5088         * amd64-obsd-tdep.c: Fix common/ includes.
5089         * amd64-nbsd-tdep.c: Fix common/ includes.
5090         * amd64-linux-tdep.c: Fix common/ includes.
5091         * amd64-linux-nat.c: Fix common/ includes.
5092         * amd64-fbsd-tdep.c: Fix common/ includes.
5093         * amd64-fbsd-nat.c: Fix common/ includes.
5094         * amd64-dicos-tdep.c: Fix common/ includes.
5095         * amd64-darwin-tdep.c: Fix common/ includes.
5096         * agent.c: Fix common/ includes.
5097         * ada-lang.h: Fix common/ includes.
5098         * ada-lang.c: Fix common/ includes.
5099         * aarch64-tdep.c: Fix common/ includes.
5100
5101 2019-01-25  Tom Tromey  <tom@tromey.com>
5102
5103         * common/create-version.sh: Use common/version.h.
5104
5105 2019-01-24  Pedro Alves  <palves@redhat.com>
5106
5107         * infrun.c (signal_stop, signal_print, signal_program)
5108         (signal_catch, signal_pass): Now arrays instead of pointers.
5109         (update_signals_program_target, do_target_resume)
5110         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5111         * linux-nat.c (linux_nat_target::pass_signals)
5112         (linux_nat_target::create_inferior, linux_nat_target::attach):
5113         Adjust.
5114         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5115         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5116         * procfs.c (procfs_target::pass_signals): Adjust.
5117         * record-full.c (record_full_target::resume): Adjust.
5118         * remote.c (remote_target::pass_signals)
5119         (remote_target::program_signals): Adjust.
5120         * target-debug.h (target_debug_print_signals): Now takes a
5121         gdb::array_view as parameter.  Adjust.
5122         * target.h (target_ops) <pass_signals, program_signals>: Replace
5123         pointer and length parameters with gdb::array_view.
5124         (target_pass_signals, target_program_signals): Likewise.
5125         * target-delegates.c: Regenerate.
5126
5127 2019-01-24  Pedro Alves  <palves@redhat.com>
5128
5129         * common/forward-scope-exit.h
5130         (forward_scope_exit::forward_scope_exit): Pass arguments to
5131         m_bind_function directly, instead of creating a std::bind and
5132         copying that.
5133
5134 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5135
5136         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5137         for static members.
5138         (pass_in_v_vfp_candidate): Likewise.
5139
5140 2019-01-23  Tom Tromey  <tom@tromey.com>
5141             Pedro Alves  <palves@redhat.com>
5142
5143         * regcache.c (class regcache_invalidator): Remove.
5144         (regcache::raw_write): Use make_scope_exit.
5145
5146 2019-01-23  Tom Tromey  <tom@tromey.com>
5147
5148         * ui-out.h (class ui_out_emit_type): Update comment.
5149
5150 2019-01-23  Tom Tromey  <tom@tromey.com>
5151
5152         * infrun.c (fetch_inferior_event): Update comment.
5153
5154 2019-01-23  Tom Tromey  <tom@tromey.com>
5155             Pedro Alves  <palves@redhat.com>
5156
5157         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5158         parameter.
5159         (fetch_inferior_event): Use SCOPE_EXIT.
5160
5161
5162 2019-01-23  Tom Tromey  <tom@tromey.com>
5163             Pedro Alves  <palves@redhat.com>
5164
5165         * infrun.c (disable_thread_events): Delete.
5166         (stop_all_threads): Use SCOPE_EXIT.
5167
5168 2019-01-23  Tom Tromey  <tom@tromey.com>
5169             Pedro Alves  <palves@redhat.com>
5170
5171         * symfile.c: Include forward-scope-exit.h.
5172         (clear_symtab_users_cleanup): Replace forward declaration with
5173         a FORWARD_SCOPE_EXIT.
5174         (syms_from_objfile_1): Use the forward_scope_exit and
5175         gdb::optional instead of cleanup_function.
5176         (reread_symbols): Use the forward_scope_exit instead of
5177         cleanup_function.
5178         (clear_symtab_users_cleanup): Remove function.
5179
5180 2019-01-23  Tom Tromey  <tom@tromey.com>
5181             Pedro Alves  <palves@redhat.com>
5182
5183         * linux-nat.c: Include scope-exit.h.
5184         (cleanup_target_stop): Remove.
5185         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5186         SCOPE_EXIT.
5187
5188 2019-01-23  Tom Tromey  <tom@tromey.com>
5189             Pedro Alves  <palves@redhat.com>
5190
5191         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5192         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5193
5194 2019-01-23  Tom Tromey  <tom@tromey.com>
5195             Andrew Burgess  <andrew.burgess@embecosm.com>
5196             Pedro Alves  <palves@redhat.com>
5197
5198         * infrun.c (fetch_inferior_event): Use scope_exit.
5199         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5200         * top.c (execute_command): Use scope_exit.
5201         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5202         * utils.c (do_bpstat_clear_actions_cleanup)
5203         (make_bpstat_clear_actions_cleanup): Remove.
5204
5205 2019-01-23  Tom Tromey  <tom@tromey.com>
5206             Pedro Alves  <palves@redhat.com>
5207
5208         * infrun.c: Include "common/scope-exit.h"
5209         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5210         (wait_for_inferior): Use SCOPE_EXIT.
5211         (fetch_inferior_event): Use scope_exit.
5212
5213 2019-01-23  Tom Tromey  <tom@tromey.com>
5214             Pedro Alves  <palves@redhat.com>
5215
5216         * breakpoint.c (create_breakpoint): Remove cleanup.
5217
5218 2019-01-23  Tom Tromey  <tom@tromey.com>
5219             Andrew Burgess  <andrew.burgess@embecosm.com>
5220             Pedro Alves  <palves@redhat.com>
5221
5222 2019-01-23  Pedro Alves  <palves@redhat.com>
5223
5224         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5225
5226 2019-01-23  Pedro Alves  <palves@redhat.com>
5227             Andrew Burgess  <andrew.burgess@embecosm.com>
5228
5229         * gdbthread.h: Include "common/forward-scope-exit.h".
5230         (scoped_finish_thread_state): Redefine custom class in terms of
5231         forward_scope_exit.
5232
5233 2019-01-23  Pedro Alves  <palves@redhat.com>
5234             Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * common/forward-scope-exit.h: New file.
5237
5238 2019-01-23  Pedro Alves  <palves@redhat.com>
5239             Andrew Burgess  <andrew.burgess@embecosm.com>
5240             Tom Tromey  <tom@tromey.com>
5241
5242         * common/scope-exit.h: New file.
5243
5244 2019-01-23  Pedro Alves  <palves@redhat.com>
5245
5246         * common/preprocessor.h (ESC): Rename to ...
5247         (ESC_PARENS): ... this.
5248         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5249         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5250
5251 2019-01-23  Tom Tromey  <tom@tromey.com>
5252
5253         * language.h (class scoped_switch_to_sym_language_if_auto):
5254         Initialize m_lang in both cases.
5255
5256 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5257
5258         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5259         with XCNEW.
5260
5261 2019-01-22  Tom Tromey  <tom@tromey.com>
5262
5263         * corelow.c: Do not include sys/file.h.
5264
5265 2019-01-22  Tom Tromey  <tom@tromey.com>
5266
5267         * tui/tui-wingeneral.h: Include gdb_curses.h.
5268
5269 2019-01-22  Tom Tromey  <tom@tromey.com>
5270
5271         * source-cache.h (class source_cache) <get_source_lines,
5272         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5273
5274 2019-01-22  Tom Tromey  <tom@tromey.com>
5275
5276         * remote-fileio.h (struct remote_target): Declare.
5277
5278 2019-01-22  Tom Tromey  <tom@tromey.com>
5279
5280         * python/py-arch.c: Do not include py-ref.h.
5281         * python/py-bpevent.c: Do not include py-ref.h.
5282         * python/py-cmd.c: Do not include py-ref.h.
5283         * python/py-continueevent.c: Do not include py-ref.h.
5284         * python/py-event.h: Do not include py-ref.h.
5285         * python/py-evtregistry.c: Do not include py-ref.h.
5286         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5287         * python/py-frame.c: Do not include py-ref.h.
5288         * python/py-framefilter.c: Do not include py-ref.h.
5289         * python/py-function.c: Do not include py-ref.h.
5290         * python/py-infevents.c: Do not include py-ref.h.
5291         * python/py-linetable.c: Do not include py-ref.h.
5292         * python/py-objfile.c: Do not include py-ref.h.
5293         * python/py-param.c: Do not include py-ref.h.
5294         * python/py-prettyprint.c: Do not include py-ref.h.
5295         * python/py-progspace.c: Do not include py-ref.h.
5296         * python/py-symbol.c: Do not include py-ref.h.
5297         * python/py-symtab.c: Do not include py-ref.h.
5298         * python/py-type.c: Do not include py-ref.h.
5299         * python/py-unwind.c: Do not include py-ref.h.
5300         * python/py-utils.c: Do not include py-ref.h.
5301         * python/py-value.c: Do not include py-ref.h.
5302         * python/py-varobj.c: Do not include py-ref.h.
5303         * python/py-xmethods.c: Do not include py-ref.h.
5304         * python/python.c: Do not include py-ref.h.
5305         * varobj.c: Do not include py-ref.h.
5306
5307 2019-01-22  Tom Tromey  <tom@tromey.com>
5308
5309         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5310         keyword for bcache.
5311
5312 2019-01-22  Tom Tromey  <tom@tromey.com>
5313
5314         * compile/compile-cplus-types.c: Remove a comment by #include.
5315
5316 2019-01-22  Tom Tromey  <tom@tromey.com>
5317
5318         * compile/gcc-c-plugin.h: Include compile-internal.h.
5319
5320 2019-01-22  Tom Tromey  <tom@tromey.com>
5321
5322         * stabsread.c (EXTERN): Do not define.
5323         (symnum, next_symbol_text_func, processing_gcc_compilation)
5324         (within_function, global_sym_chain, global_stabs)
5325         (previous_stab_code, this_object_header_files)
5326         (n_this_object_header_files)
5327         (n_allocated_this_object_header_files): Define.
5328         * stabsread.h (EXTERN): Never define.  Use "extern".
5329
5330 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5331
5332         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5333         history_value.
5334
5335 2019-01-21  Tom Tromey  <tom@tromey.com>
5336
5337         * ui-out.c: Fix includes.
5338         * tui/tui-source.c: Fix includes.
5339         * target.c: Fix includes.
5340         * remote.c: Fix includes.
5341         * regcache.c: Fix includes.
5342         * python/py-block.c: Fix includes.
5343         * printcmd.c: Fix includes.
5344         * or1k-tdep.c: Fix includes.
5345         * mi/mi-main.c: Fix includes.
5346         * m32r-tdep.c: Fix includes.
5347         * csky-tdep.c: Fix includes.
5348         * compile/compile-cplus-types.c: Fix includes.
5349         * cli/cli-interp.c: Fix includes.
5350
5351 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5352
5353         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5354         for padding.
5355
5356 2019-01-16  Tom Tromey  <tom@tromey.com>
5357
5358         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5359         earlier.
5360         (struct objfile) <msymbols_range>: Move from top level.
5361         <msymbols>: New method.
5362         (class objfile_msymbols): Remove.
5363         * symtab.c (default_collect_symbol_completion_matches_break_on):
5364         Update.
5365         * symmisc.c (dump_msymbols): Update.
5366         * stabsread.c (scan_file_globals): Update.
5367         * objc-lang.c (info_selectors_command, info_classes_command)
5368         (find_methods): Update.
5369         * minsyms.c (find_solib_trampoline_target): Update.
5370         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5371         * coffread.c (coff_symfile_read): Update.
5372         * ada-lang.c (ada_lookup_simple_minsym)
5373         (ada_collect_symbol_completion_matches): Update.
5374
5375 2019-01-16  Tom Tromey  <tom@tromey.com>
5376
5377         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5378         type.  Remove no-argument constructor.
5379         <iterator::operator++>: Simplify.
5380         <begin>: Update.
5381         <end>: Use minimal_symbol_count.
5382
5383 2019-01-16  Tom Tromey  <tom@tromey.com>
5384
5385         * objfiles.h (struct objfile) <psymtabs>: New method.
5386         (class objfile_psymtabs): Remove.
5387         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5388         typedef.
5389         <range>: New method.
5390         (require_partial_symbols): Change return type.
5391         * psymtab.c (require_partial_symbols)
5392         (psym_expand_symtabs_matching): Update.
5393         * mdebugread.c (parse_partial_symbols): Update.
5394         * dbxread.c (dbx_end_psymtab): Update.
5395
5396 2019-01-15  Tom Tromey  <tom@tromey.com>
5397
5398         * symtab.c (lookup_objfile_from_block)
5399         (lookup_symbol_in_objfile_symtabs)
5400         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5401         (find_line_symtab, info_sources_command)
5402         (default_collect_symbol_completion_matches_break_on)
5403         (make_source_files_completion_list): Update.
5404         * symmisc.c (print_objfile_statistics, dump_objfile)
5405         (maintenance_print_symbols, maintenance_info_symtabs)
5406         (maintenance_check_symtabs, maintenance_info_line_tables):
5407         Update.
5408         * source.c (select_source_symtab)
5409         (forget_cached_source_info_for_objfile): Update.
5410         * objfiles.h (class objfile_compunits): Remove.
5411         (struct objfile) <compunits_range>: New typedef.
5412         (compunits): New method.
5413         * objfiles.c (objfile_relocate1): Update.
5414         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5415         * maint.c (count_symtabs_and_blocks): Update.
5416         * linespec.c (iterate_over_all_matching_symtabs): Update.
5417         * cp-support.c (add_symbol_overload_list_qualified): Update.
5418         * coffread.c (coff_symtab_read): Update.
5419         * ada-lang.c (add_nonlocal_symbols)
5420         (ada_collect_symbol_completion_matches)
5421         (ada_add_global_exceptions): Update.
5422
5423 2019-01-15  Tom Tromey  <tom@tromey.com>
5424
5425         * progspace.h (program_space) <objfiles_safe_range>: New
5426         typedef.
5427         <objfiles_safe>: New method.
5428         * objfiles.h (class all_objfiles_safe): Remove.
5429         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5430         * jit.c (jit_inferior_exit_hook): Update.
5431
5432 2019-01-17  Tom Tromey  <tom@tromey.com>
5433
5434         * progspace.h (program_space) <objfiles_range>: New typedef.
5435         <objfiles>: New method.
5436         <objfiles_head>: Rename from objfiles.
5437         (object_files): Update.
5438         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5439         * guile/scm-pretty-print.c
5440         (ppscm_find_pretty_printer_from_objfiles): Update.
5441         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5442         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5443         Update.
5444         * python/py-progspace.c (pspy_get_objfiles): Update.
5445         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5446         Update.
5447         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5448         (objfpy_lookup_objfile_by_build_id): Update.
5449         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5450         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5451         Update.
5452         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5453         (expand_symtab_containing_pc, lookup_objfile_from_block)
5454         (lookup_static_symbol, basic_lookup_transparent_type)
5455         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5456         (find_line_symtab, info_sources_command)
5457         (default_collect_symbol_completion_matches_break_on)
5458         (make_source_files_completion_list, find_main_name): Update.
5459         * symmisc.c (print_symbol_bcache_statistics)
5460         (print_objfile_statistics, maintenance_print_symbols)
5461         (maintenance_print_msymbols, maintenance_print_objfiles)
5462         (maintenance_info_symtabs, maintenance_check_symtabs)
5463         (maintenance_expand_symtabs, maintenance_info_line_tables):
5464         Update.
5465         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5466         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5467         (map_overlay_command, unmap_overlay_command)
5468         (simple_overlay_update, expand_symtabs_matching)
5469         (map_symbol_filenames): Update.
5470         * symfile-debug.c (set_debug_symfile): Update.
5471         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5472         Update.
5473         * source.c (select_source_symtab, forget_cached_source_info):
5474         Update.
5475         * solib.c (solib_read_symbols): Update.
5476         * solib-spu.c (append_ocl_sos): Update.
5477         * psymtab.c (maintenance_print_psymbols)
5478         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5479         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5480         * printcmd.c (info_symbol_command): Update.
5481         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5482         Update.
5483         * objfiles.h (class all_objfiles): Remove.
5484         * objfiles.c (have_partial_symbols, have_full_symbols)
5485         (have_minimal_symbols, qsort_cmp, update_section_map)
5486         (shared_objfile_contains_address_p)
5487         (default_iterate_over_objfiles_in_search_order): Update.
5488         * objc-lang.c (info_selectors_command, info_classes_command)
5489         (find_methods): Update.
5490         * minsyms.c (find_solib_trampoline_target): Update.
5491         * maint.c (maintenance_info_sections)
5492         (maintenance_translate_address, count_symtabs_and_blocks):
5493         Update.
5494         * main.c (captured_main_1): Update.
5495         * linux-thread-db.c (try_thread_db_load_from_pdir)
5496         (has_libpthread): Update.
5497         * linespec.c (iterate_over_all_matching_symtabs)
5498         (search_minsyms_for_name): Update.
5499         * jit.c (jit_find_objf_with_entry_addr): Update.
5500         * hppa-tdep.c (find_unwind_entry)
5501         (hppa_lookup_stub_minimal_symbol): Update.
5502         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5503         Update.
5504         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5505         (elf_gnu_ifunc_resolve_by_got): Update.
5506         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5507         * dwarf-index-write.c (save_gdb_index_command): Update.
5508         * cp-support.c (add_symbol_overload_list_qualified): Update.
5509         * breakpoint.c (create_overlay_event_breakpoint)
5510         (create_longjmp_master_breakpoint)
5511         (create_std_terminate_master_breakpoint)
5512         (create_exception_master_breakpoint): Update.
5513         * blockframe.c (find_pc_partial_function): Update.
5514         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5515         (ada_collect_symbol_completion_matches)
5516         (ada_add_global_exceptions): Update.
5517
5518 2019-01-17  Tom Tromey  <tom@tromey.com>
5519
5520         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5521         declare VEC.
5522         (solib_target_parse_libraries): Change return type.
5523         (library_list_start_segment, library_list_start_section)
5524         (library_list_end_library, library_list_start_library); Update.
5525         (solib_target_free_library_list): Remove.
5526         (solib_target_parse_libraries): Remove cleanup.  Change return
5527         type.
5528         (solib_target_current_sos): Update.
5529
5530 2019-01-17  Tom Tromey  <tromey@bapiya>
5531
5532         * valprint.c: Replace "the the" with "the".
5533         * symtab.c: Replace "the the" with "the".
5534         * solib.c: Replace "the the" with "the".
5535         * solib-dsbt.c: Replace "the the" with "the".
5536         * linespec.c: Replace "the the" with "the".
5537         * dwarf2loc.h: Replace "the the" with "the".
5538         * amd64-windows-tdep.c: Replace "the the" with "the".
5539         * aarch64-tdep.c: Replace "the the" with "the".
5540
5541 2019-01-16  Keith Seitz  <keiths@redhat.com>
5542
5543         PR gdb/23773
5544         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5545         <builder>: Rename to ..
5546         <m_builder>: ... this and make private.
5547         (dwarf2_cu::get_builder): New method.  Change all users of
5548         `builder' to use this method.
5549         (dwarf2_start_symtab): Move to ...
5550         (dwarf2_cu::start_symtab): ... here.  Update all callers
5551         (setup_type_unit_groups): Move to ...
5552         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5553         callers.
5554         (dwarf2_cu::reset_builder): New method.
5555         (process_full_compunit, process_full_type_unit): Use
5556         dwarf2_cu::reset_builder.
5557         (follow_die_offset): Record the ancestor CU if it is different
5558         from the followed DIE's CU.
5559         (follow_die_sig_1): Likewise.
5560
5561 2019-01-15  Tom Tromey  <tom@tromey.com>
5562
5563         * remote.c (class remote_state) <buf>: Now a char_vector.
5564         <buf_size>: Remove.
5565         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5566         parameter.
5567         (remote_target::getpkt_or_notif_sane_1)
5568         (remote_target::getpkt_sane)
5569         (remote_target::getpkt_or_notif_sane): Likewise.
5570         (class remote_target) <putpkt>: New overload.
5571         (remote_target::read_frame): Change type of "buf_p".  Remove
5572         sizeof_p parameter.
5573         (packet_ok): New overload.
5574         (packet_check_result): New overload.
5575         Update all uses.
5576
5577 2019-01-14  Tom Tromey  <tom@tromey.com>
5578
5579         * remote-notif.c (handle_notification, remote_notif_ack)
5580         (remote_notif_parse): Make "buf" const.
5581         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5582         const.
5583         (remote_notif_parse, remote_notif_ack, handle_notification):
5584         Likewise.
5585         * remote.c (remote_notif_stop_parse): Make "buf" const.
5586         (remote_target::remote_parse_stop_reply): Make "buf" const.
5587         (remote_notif_stop_ack): Make "buf" const.
5588
5589 2019-01-14  Tom Tromey  <tom@tromey.com>
5590
5591         * remote.c (remote_console_output): Make parameter const.
5592
5593 2019-01-14  Tom Tromey  <tom@tromey.com>
5594
5595         * target-debug.h (target_debug_print_signals): Constify.
5596         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5597         * procfs.c (procfs_target::pass_signals): Update.
5598         * linux-nat.c (linux_nat_target::pass_signals): Update.
5599         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5600         * target-delegates.c: Rebuild.
5601         * remote.c (remote_target::program_signals): Update.
5602         (remote_target::pass_signals): Update.
5603         * target.c (target_pass_signals): Constify argument.
5604         (target_program_signals): Likewise.
5605         * target.h (struct target_ops) <pass_signals, program_signals>:
5606         Constify argument.
5607         (target_pass_signals, target_program_signals): Constify argument.
5608
5609 2019-01-14  Tom Tromey  <tom@tromey.com>
5610
5611         PR tui/28819:
5612         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5613
5614 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5615
5616         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5617         field.
5618         * rs6000-tdep.c: Include reggroups.h.
5619         (IS_V_ALIAS_PSEUDOREG): Define.
5620         (rs6000_register_name): Return names for the "vX" aliases.
5621         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5622         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5623         aliases.  Call default_register_reggroup_p for all other
5624         pseudo-registers.
5625         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5626         New functions.
5627         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5628         Handle "vX" aliases.
5629         (v_alias_pseudo_register_collect): New function.
5630         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5631         (rs6000_gdbarch_init): Initialize "vX" aliases as
5632         pseudo-registers.  Restore registration of
5633         rs6000_pseudo_register_reggroup_p with
5634         set_tdesc_pseudo_register_reggroup_p.
5635
5636 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5637
5638         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5639         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5640         set_gdbarch_num_pseudo_regs.
5641
5642 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5643
5644         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5645         Remove arg prefixname, add do_set and do_show.
5646         Add member functions set_list and show_list.
5647         * cli/cli-style.c (class cli_style_option): Update accordingly.
5648         (style_set_list): Move to file scope.
5649         (style_show_list): Likewise.
5650         (set_style): Call help_list.
5651         (show_style): Call cmd_show_list.
5652         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5653         Update to use the new macro.
5654
5655 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5656
5657         * ada-lang.c (_initialize_ada_language): Expand the help text
5658         for the "catch exception" command.
5659
5660 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5661
5662         * symtab.c (matching_obj_sections): Initialize obj,
5663         declare it closer to its usage.
5664
5665 2019-01-10  Tom Tromey  <tom@tromey.com>
5666
5667         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5668         (basic_inf_threads_range): Remove.
5669         (inf_threads_range, inf_non_exited_threads_range)
5670         (safe_inf_threads_range): Use next_adapter.
5671
5672 2019-01-10  Keith Seitz  <keiths@redhat.com>
5673
5674         PR gdb/23712
5675         PR symtab/23010
5676         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5677         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5678
5679 2019-01-10  Keith Seitz  <keiths@redhat.com>
5680
5681         PR gdb/23712
5682         PR symtab/23010
5683         * dictionary.c (pending_to_vector): Remove.
5684         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5685         Remove _1 suffix, replacing functions of the same name.  Update
5686         all callers.
5687         (dict_create_hashed, dict_create_hashed_expandable)
5688         (dict_create_linear, dict_create_linear_expandable, dict_free)
5689         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5690         Make functions static.
5691
5692 2019-01-10  Keith Seitz  <keiths@redhat.com>
5693
5694         PR gdb/23712
5695         PR symtab/23010
5696         * dictionary.h (struct dictionary): Replace declaration with
5697         multidictionary.
5698         (dict_create_hashed, dict_create_hashed_expandable)
5699         (dict_create_linear, dict_create_linear_expandable)
5700         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5701         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5702         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5703         taking multidictionary argument.
5704         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5705         * block.h (struct block) <dict>: Change to multidictionary
5706         and rename `multidict'.
5707         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5708         symmisc.c: Update all dictionary references to multidictionary.
5709
5710 2019-01-10  Keith Seitz  <keiths@redhat.com>
5711
5712         PR gdb/23712
5713         PR symtab/23010
5714         * dictionary.c: Include unordered_map.
5715         (pending_to_vector): New function.
5716         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5717         Rewrite the non-"_1" functions to take vector instead
5718         of linked list.
5719         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5720         "new" _1 versions of the same name.
5721         (multidictionary): Define.
5722         (std::hash<enum language): New definition.
5723         (collate_pending_symbols_by_language, mdict_create_hashed)
5724         (mdict_create_hashed_expandable, mdict_create_linear)
5725         (mdict_create_linear_expandable, mdict_free)
5726         (find_language_dictionary, create_new_language_dictionary)
5727         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5728         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5729         (mdict_size, mdict_empty): New functions.
5730         * dictionary.h (mdict_iterator): Define.
5731
5732 2019-01-10  Pedro Alves  <palves@redhat.com>
5733
5734         * breakpoint.c (read_uploaded_action)
5735         (create_tracepoint_from_upload): Adjust to use
5736         gdb::unique_xmalloc_ptr.
5737         * ctf.c (ctf_write_uploaded_tp):
5738         (SET_ARRAY_FIELD): Use emplace_back.
5739         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5740         * tracefile-tfile.c (tfile_write_uploaded_tp):
5741         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5742         gdb::unique_xmalloc_ptr.
5743         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5744         at_string, cond_string, cmd_strings>: Replace char pointers
5745         with gdb::unique_xmalloc_ptr.
5746
5747 2019-01-10  Pedro Alves  <palves@redhat.com>
5748
5749         * solib-target.c (library_list_start_library): Don't xstrdup name.
5750
5751 2019-01-10  Pedro Alves  <palves@redhat.com>
5752
5753         * mdebugread.c (parse_partial_symbols): Use
5754         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5755
5756 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5757
5758         * linux-fork.c (scoped_switch_fork_info)
5759         <~scoped_switch_fork_info>: Fix incorrect variable name.
5760
5761 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * linux-fork.c (scoped_switch_fork_info)
5764         <scoped_switch_fork_info>: Make explicit.
5765         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5766
5767 2019-01-10  Tom Tromey  <tom@tromey.com>
5768
5769         * objfiles.h (objfile::reset_psymtabs): Update.
5770         * objfiles.c (objfile::objfile): Update.
5771         * psymtab.h (psymtab_storage::obstack): Update.
5772         (psymtab_storage::m_obstack): Use gdb::optional.
5773         (class psymtab_storage): Update comment.  Remove objfile
5774         parameter.
5775         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5776
5777 2019-01-10  Tom Tromey  <tom@tromey.com>
5778
5779         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5780         <free_psymtabs>: Now private.
5781         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5782         (allocate_psymtab): Use new method.
5783
5784 2019-01-10  Tom Tromey  <tom@tromey.com>
5785
5786         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5787         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5788         * mdebugread.c (parse_partial_symbols): Use
5789         allocate_dependencies.
5790         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5791         allocate_dependencies.
5792         (process_psymtab_comp_unit_reader)
5793         (build_type_psymtab_dependencies): Likewise.
5794         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5795
5796 2019-01-10  Tom Tromey  <tom@tromey.com>
5797
5798         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5799         PSYMBOL_SET_LANGUAGE.
5800         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5801
5802 2019-01-10  Tom Tromey  <tom@tromey.com>
5803
5804         * psymtab.h (psymtab_storage::obstack): New method.
5805         <m_obstack>: Rename from obstack; now private.
5806         * psymtab.c (psymtab_storage): Update.
5807         * dwarf2read.c (create_addrmap_from_index)
5808         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5809         Update.
5810
5811 2019-01-10  Tom Tromey  <tom@tromey.com>
5812
5813         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5814         * objfiles.h (objfile::reset_psymtabs): New method.
5815
5816 2019-01-10  Tom Tromey  <tom@tromey.com>
5817
5818         * symmisc.c (print_symbol_bcache_statistics): Update.
5819         (print_objfile_statistics): Update.
5820         * symfile.c (reread_symbols): Update.
5821         * psymtab.h (class psymtab_storage): New.
5822         * psymtab.c (psymtab_storage): New constructor.
5823         (~psymtab_storage): New destructor.
5824         (require_partial_symbols): Update.
5825         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5826         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5827         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5828         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5829         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5830         (start_psymtab_common, end_psymtab_common)
5831         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5832         (allocate_psymtab): Update.
5833         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5834         Update.
5835         (dump_psymtab_addrmap, maintenance_print_psymbols)
5836         (maintenance_check_psymtabs): Update.
5837         (class objfile_psymtabs): Move to objfiles.h.
5838         * psympriv.h (discard_psymtab): Now inline.
5839         (psymtab_discarder::psymtab_discarder): Update.
5840         (psymtab_discarder::~psymtab_discarder): Update.
5841         (ALL_OBJFILE_PSYMTABS): Rewrite.
5842         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5843         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5844         Remove fields.
5845         <partial_symtabs>: New field.
5846         (class objfile_psymtabs): Move from psymtab.h.  Update.
5847         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5848         psymbol_cache.
5849         (objfile::~objfile): Don't destroy psymbol_cache.
5850         * mdebugread.c (parse_partial_symbols): Update.
5851         * dwarf2read.c (create_addrmap_from_index)
5852         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5853         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5854         (add_partial_subprogram, dwarf2_ranges_read): Update.
5855         * dwarf-index-write.c (write_address_map)
5856         (write_one_signatured_type, recursively_write_psymbols)
5857         (class debug_names, class debug_names, write_psymtabs_to_index):
5858         Update.
5859
5860 2019-01-10  Tom Tromey  <tom@tromey.com>
5861
5862         * symtab.h (SYMBOL_SET_NAMES): Update.
5863         (symbol_set_names): Update.
5864         (MSYMBOL_SET_NAMES): Update.
5865         * symtab.c (symbol_set_names): Change argument to be an
5866         objfile_per_bfd_storage.
5867         * psymtab.c (add_psymbol_to_bcache): Update.
5868         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5869
5870 2019-01-10  Tom Tromey  <tom@tromey.com>
5871
5872         * symtab.c (create_demangled_names_hash): Change argument to be an
5873         objfile_per_bfd_storage.
5874         (symbol_set_names): Update.
5875
5876 2019-01-10  Tom Tromey  <tom@tromey.com>
5877
5878         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5879         init_psymbol_list.
5880         * psymtab.c (init_psymbol_list): Do nothing if already called.
5881         * psympriv.h (init_psymbol_list): Add comment.
5882         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5883         init_psymbol_list.
5884         * dbxread.c (dbx_symfile_read): Unconditionally call
5885         init_psymbol_list.
5886
5887 2019-01-10  Tom Tromey  <tom@tromey.com>
5888
5889         * xcoffread.c (scan_xcoff_symtab): Update.
5890         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5891         "where".
5892         * mdebugread.c (parse_partial_symbols)
5893         (handle_psymbol_enumerators): Update.
5894         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5895         * dbxread.c (read_dbx_symtab): Update.
5896         * psympriv.h (psymbol_placement): New enum.
5897         (add_psymbol_to_list): Update.
5898
5899 2019-01-10  Tom Tromey  <tom@tromey.com>
5900
5901         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5902         static_psymbols parameters.
5903         (scan_xcoff_symtab): Update.
5904         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5905         static_psymbols parameters.
5906         * psympriv.h (start_psymtab_common): Update.
5907         * mdebugread.c (parse_partial_symbols): Update.
5908         * dwarf2read.c (create_partial_symtab): Update.
5909         * dbxread.c (read_dbx_symtab): Update.
5910         (start_psymtab): Remove global_psymbols and static_psymbols
5911         parameters.
5912
5913 2019-01-10  Tom Tromey  <tom@tromey.com>
5914
5915         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5916         * psymtab.c (allocate_psymtab): Add comment.
5917         * psympriv.h (allocate_psymtab): Add comment.
5918         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5919         initializations.
5920         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5921
5922 2019-01-10  Tom Tromey  <tom@tromey.com>
5923
5924         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5925         Don't declare.
5926         * mipsread.c: Include mdebugread.h.
5927         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5928         Declare.
5929         * elfread.c: Include mdebugread.h.
5930
5931 2019-01-09  Tom Tromey  <tom@tromey.com>
5932
5933         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5934         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5935         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5936         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5937         (psym_lookup_symbol, psym_find_last_source_symtab)
5938         (psym_forget_cached_source_info, psym_print_stats)
5939         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5940         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5941         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5942         (psym_find_compunit_symtab_by_address)
5943         (maintenance_print_psymbols, maintenance_info_psymtabs)
5944         (maintenance_check_psymtabs): Use ranged for.
5945         * psymtab.h (class objfile_psymtabs): New.
5946         (require_partial_symbols): Return objfile_psymtabs.
5947         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5948
5949 2019-01-09  Tom Tromey  <tom@tromey.com>
5950
5951         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5952         (find_pc_mapped_section, list_overlays_command)
5953         (map_overlay_command, unmap_overlay_command)
5954         (simple_overlay_update): Use all_objfiles.
5955         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5956         * printcmd.c (info_symbol_command): Use all_objfiles.
5957         * objfiles.h (ALL_OBJSECTIONS): Remove.
5958         * maint.c (maintenance_translate_address): Use all_objfiles.
5959         * gcore.c (gcore_create_callback): Use all_objfiles.
5960         (objfile_find_memory_regions): Likewise.
5961
5962 2019-01-09  Tom Tromey  <tom@tromey.com>
5963
5964         * symtab.c (find_line_symtab, info_sources_command)
5965         (make_source_files_completion_list): Use objfile_compunits.
5966         * source.c (select_source_symtab): Use objfile_compunits.
5967         * objfiles.h (struct objfile): Update comment.
5968         (ALL_OBJFILES): Remove.
5969         (ALL_FILETABS): Remove.
5970         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5971         objfile_compunits.
5972
5973 2019-01-09  Tom Tromey  <tom@tromey.com>
5974
5975         * symmisc.c (print_objfile_statistics, dump_objfile)
5976         (maintenance_print_symbols): Use compunit_filetabs.
5977         * source.c (forget_cached_source_info_for_objfile): Use
5978         compunit_filetabs.
5979         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5980         (ALL_FILETABS): Use compunit_filetabs.
5981         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5982         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5983
5984 2019-01-09  Tom Tromey  <tom@tromey.com>
5985
5986         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5987         (compunit_filetabs): New.
5988         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5989         compunit_filetabs.
5990         (info_sources_command, make_source_files_completion_list): Remove
5991         declaration.
5992         * symmisc.c (print_objfile_statistics, dump_objfile)
5993         (maintenance_print_symbols): Remove declaration.
5994         (maintenance_info_symtabs): Use compunit_filetabs.
5995         (maintenance_info_line_tables): Likewise.
5996         * source.c (select_source_symtab): Change local variable name.
5997         (forget_cached_source_info_for_objfile): Remove declaration.
5998         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5999         * objfiles.c (objfile_relocate1): Remove declaration.
6000         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6001         declaration.
6002         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6003         * coffread.c (coff_symtab_read): Remove declaration.
6004         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6005         compunit_filetabs.
6006
6007 2019-01-09  Tom Tromey  <tom@tromey.com>
6008
6009         * symtab.c (lookup_objfile_from_block)
6010         (find_pc_sect_compunit_symtab, search_symbols)
6011         (default_collect_symbol_completion_matches_break_on): Use
6012         objfile_compunits.
6013         * objfiles.h (ALL_COMPUNITS): Remove.
6014         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6015         * cp-support.c (add_symbol_overload_list_qualified): Use
6016         objfile_compunits.
6017         * ada-lang.c (ada_collect_symbol_completion_matches)
6018         (ada_add_global_exceptions): Use objfile_compunits.
6019
6020 2019-01-09  Tom Tromey  <tom@tromey.com>
6021
6022         * source.c (select_source_symtab)
6023         (forget_cached_source_info_for_objfile): Remove declaration.
6024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6025         declaration.
6026         * maint.c (count_symtabs_and_blocks): Remove declaration.
6027         * cp-support.c (add_symbol_overload_list_qualified): Remove
6028         declaration.
6029         * coffread.c (coff_symtab_read): Remove declaration.
6030         * symtab.c (lookup_symbol_in_objfile_symtabs)
6031         (basic_lookup_transparent_type_1): Use objfile_compunits.
6032         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6033         (info_sources_command, search_symbols)
6034         (default_collect_symbol_completion_matches_break_on)
6035         (make_source_files_completion_list): Remove declaration.
6036         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6037         (ada_collect_symbol_completion_matches)
6038         (ada_add_global_exceptions): Remove declaration.
6039         * linespec.c (iterate_over_all_matching_symtabs): Use
6040         objfile_compunits.
6041         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6042         (class objfile_compunits): New.
6043         (ALL_COMPUNITS): Use objfile_compunits.
6044         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6045         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6046         objfile_compunits.
6047         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6048
6049 2019-01-09  Tom Tromey  <tom@tromey.com>
6050
6051         * symtab.c (search_symbols)
6052         (default_collect_symbol_completion_matches_break_on): Use
6053         objfile_msymbols.
6054         * ada-lang.c (ada_lookup_simple_minsym)
6055         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6056         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6057         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6058         objfile_msymbols.
6059         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6060         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6061         * objc-lang.c (find_methods): Use objfile_msymbols.
6062         (info_selectors_command, info_classes_command): Likewise.
6063         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6064         * objfiles.h (class objfile_msymbols): New.
6065         (ALL_OBJFILE_MSYMBOLS): Remove.
6066         (ALL_MSYMBOLS): Remove.
6067
6068 2019-01-09  Tom Tromey  <tom@tromey.com>
6069
6070         * common/next-iterator.h (next_adapter): Add Iterator template
6071         parameter.
6072         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6073         (class all_objfiles_safe): New.
6074         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6075         * objfiles.c (put_objfile_before): Update comment.
6076         (add_separate_debug_objfile): Likewise.
6077         (free_all_objfiles): Use all_objfiles_safe.
6078         (objfile_purge_solibs): Likewise.
6079
6080 2019-01-09  Tom Tromey  <tom@tromey.com>
6081
6082         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6083         (expand_symtab_containing_pc, lookup_static_symbol)
6084         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6085         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6086         all_objfiles.
6087         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6088         * breakpoint.c (create_overlay_event_breakpoint)
6089         (create_longjmp_master_breakpoint)
6090         (create_std_terminate_master_breakpoint)
6091         (create_exception_master_breakpoint): Use all_objfiles.
6092         * linux-thread-db.c (try_thread_db_load_from_pdir)
6093         (has_libpthread): Use all_objfiles.
6094         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6095         * linespec.c (iterate_over_all_matching_symtabs)
6096         (search_minsyms_for_name): Use all_objfiles.
6097         * maint.c (maintenance_info_sections): Use all_objfiles.
6098         * main.c (captured_main_1): Use all_objfiles.
6099         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6100         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6101         * guile/scm-pretty-print.c
6102         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6103         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6104         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6105         (maintenance_print_msymbols): Use all_objfiles.
6106         * source.c (select_source_symtab): Use all_objfiles.
6107         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6108         * symfile.c (remove_symbol_file_command)
6109         (expand_symtabs_matching, map_symbol_filenames): Use
6110         all_objfiles.
6111         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6112         all_objfiles.
6113         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6114         * objc-lang.c (find_methods): Use all_objfiles.
6115         * objfiles.c (have_partial_symbols, have_full_symbols)
6116         (have_minimal_symbols, qsort_cmp)
6117         (default_iterate_over_objfiles_in_search_order): Use
6118         all_objfiles.
6119         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6120         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6121         (maintenance_check_psymtabs): Use all_objfiles.
6122         (ALL_PSYMTABS): Remove.
6123         * compile/compile-object-run.c (do_module_cleanup): Use
6124         all_objfiles.
6125         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6126         * cp-support.c (add_symbol_overload_list_qualified): Use
6127         all_objfiles.
6128         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6129         Use all_objfiles.
6130         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6131         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6132         all_objfiles.
6133         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6134         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6135         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6136         Uses all_objfiles.
6137         * solib.c (solib_read_symbols): Use all_objfiles
6138
6139 2019-01-09  Tom Tromey  <tom@tromey.com>
6140
6141         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6142         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6143         all_objfiles.
6144         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6145         * symmisc.c (print_symbol_bcache_statistics)
6146         (print_objfile_statistics, maintenance_print_objfiles)
6147         (maintenance_info_symtabs, maintenance_check_symtabs)
6148         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6149         all_objfiles.
6150         * source.c (forget_cached_source_info): Use all_objfiles.
6151         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6152         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6153         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6154         * objfiles.c (update_section_map): Use all_objfiles.
6155         (shared_objfile_contains_address_p): Likewise.
6156         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6157         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6158
6159 2019-01-09  Tom Tromey  <tom@tromey.com>
6160
6161         * common/next-iterator.h: New file.
6162         * objfiles.h (class all_objfiles): New.
6163         (struct objfile_iterator): New.
6164
6165 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6166
6167         * NEWS: Move the description of the changed "frame", "select-frame",
6168          and "info frame" commands to the Changed commands section.
6169
6170 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6171
6172         * gdbtypes.c (check_stub_method_group): Remove handling of old
6173         mangling schemes.
6174         * linespec.c (find_methods): Likewise.
6175         * stabsread.c (read_member_functions): Likewise.
6176         * valops.c (search_struct_method): Likewise.
6177         (value_struct_elt_for_reference): Likewise.
6178         * NEWS: Mention this change.
6179
6180 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6181
6182         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6183         print_source_lines.
6184         * source.c (print_source_lines_base): Update line number check.
6185         (print_source_lines): New function.
6186         (source_lines_range::source_lines_range): New function.
6187         * source.h (class source_lines_range): New class.
6188         (print_source_lines): New declaration.
6189
6190 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6191
6192         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6193
6194 2019-01-08  Tom Tromey  <tom@tromey.com>
6195             Simon Marchi  <simon.marchi@ericsson.com>
6196
6197         PR gdb/24060
6198         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6199         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6200         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6201         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6202         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6203         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6204
6205 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6206
6207         * source.c (select_source_symtab): Move header comment to
6208         declaration in source.h.
6209         (forget_cached_source_info_for_objfile): Likewise.
6210         (forget_cached_source_info): Likewise.
6211         (identify_source_line): Likewise.
6212         * source.h (identify_source_line): Move declaration from symtab.h
6213         and add comment from source.c
6214         (print_source_lines): Likewise.
6215         (forget_cached_source_info_for_objfile): Likewise.
6216         (forget_cached_source_info): Likewise.
6217         (select_source_symtab): Likewise.
6218         (enum print_source_lines_flag): Move definition from symtab.h.
6219         * symtab.h (identify_source_line): Move declaration to source.h.
6220         (print_source_lines): Likewise.
6221         (forget_cached_source_info_for_objfile): Likewise.
6222         (forget_cached_source_info): Likewise.
6223         (select_source_symtab): Likewise.
6224         (enum print_source_lines_flag): Move definition to source.h.
6225         * tui/tui-hooks.c: Add 'source.h' include.
6226
6227 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * source.c (print_source_lines_base): Handle requests to print
6230         reverse line number sequences, and guard against empty lines
6231         string.
6232
6233 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * source.c (print_source_lines_base): Fix skip of '\r' if next
6236         character is '\n'.
6237
6238 2019-01-06  Tom Tromey  <tom@tromey.com>
6239
6240         * c-exp.y (struct c_parse_state) <macro_original_text,
6241         expansion_obstack>: New member.
6242         (macro_original_text, expansion_obstack): Remove globals.
6243         (scan_macro_expansion, scanning_macro_expansion)
6244         (finished_macro_expansion): Update.
6245         (scan_macro_cleanup): Remove.
6246         (yylex, c_parse): Update.
6247
6248 2019-01-06  Tom Tromey  <tom@tromey.com>
6249
6250         * c-exp.y (struct c_parse_state) <strings>: New member.
6251         (operator_stoken): Update.
6252
6253 2019-01-06  Tom Tromey  <tom@tromey.com>
6254
6255         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6256         (union type_stack_elt) <typelist_val>: Now a pointer to
6257         std::vector.
6258         (type_stack_cleanup): Don't declare.
6259         (push_typelist): Update.
6260         * parse.c (pop_typelist): Return a std::vector.
6261         (push_typelist): Take a std::vector.
6262         (follow_types): Update.  Do not free args.
6263         (type_stack_cleanup): Remove.
6264         * c-exp.y (struct c_parse_state): New.
6265         (cpstate): New global.
6266         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6267         (nonempty_typelist): Update.
6268         (func_mod): Create a new vector.
6269         (c_parse): Create a c_parse_state.
6270         (check_parameter_typelist): Do not delete params.
6271         (function_method): Update.  Do not delete type_list.
6272
6273 2019-01-06  Tom Tromey  <tom@tromey.com>
6274
6275         PR gdb/28155:
6276         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6277         check_typedef.
6278         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6279         (print_return_value): Likewise.
6280
6281 2019-01-05  Tom Tromey  <tom@tromey.com>
6282
6283         * contrib/cleanup_check.py: Remove.
6284         * contrib/gcc-with-excheck: Remove.
6285         * contrib/exsummary.py: Remove.
6286         * contrib/excheck.py: Remove.
6287
6288 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6289
6290         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6291         NULL. Initialize tpprev to NULL instead of assigning it
6292         to NULL on the next statement.
6293         * windows-nat.c (windows_delete_thread): Remove check for
6294         main_thread_id before printing thread exit notifications.
6295         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6296         Remove thread ID check against main_thread_id.
6297         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6298         windows_delete_thread.
6299         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6300
6301 2019-01-04  Tom Tromey  <tom@tromey.com>
6302
6303         * compile/compile.c (_initialize_compile): Use upper case for
6304         metasyntactic variables.
6305         * symmisc.c (_initialize_symmisc): Use upper case for
6306         metasyntactic variables.
6307         * psymtab.c (_initialize_psymtab): Use upper case for
6308         metasyntactic variables.
6309         * demangle.c (demangle_command): Use upper case for metasyntactic
6310         variables.
6311         (_initialize_demangler): Likewise.
6312         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6313         variables.
6314
6315 2019-01-03  Tom Tromey  <tom@tromey.com>
6316
6317         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6318
6319 2019-01-03  Tom Tromey  <tom@tromey.com>
6320
6321         * python/py-symtab.c (salpy_str): Update.
6322         (struct salpy_sal_object) <symtab>: Now a PyObject.
6323         (salpy_dealloc): Update.
6324         (del_objfile_sal): Use gdbpy_ref.
6325
6326 2019-01-03  Tom Tromey  <tom@tromey.com>
6327
6328         * python/py-type.c (convert_field): Use new_reference.  Return
6329         gdbpy_ref.
6330         (make_fielditem): Return gdbpy_ref.
6331         (typy_fields): Update.
6332         (typy_getitem): Update.
6333         (field_name): Return gdbpy_ref.  Use new_reference.
6334         (typy_iterator_iternext): Update.
6335
6336 2019-01-03  Tom Tromey  <tom@tromey.com>
6337
6338         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6339
6340 2019-01-03  Tom Tromey  <tom@tromey.com>
6341
6342         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6343         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6344         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6345         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6346         (pspy_set_type_printers): Likewise.
6347         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6348         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6349         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6350         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6351         (objfpy_set_type_printers): Likewise.
6352
6353 2019-01-03  Tom Tromey  <tom@tromey.com>
6354
6355         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6356         (gdbpy_print_stack): Use gdbpy_err_fetch.
6357         * python/python-internal.h (class gdbpy_err_fetch): New class.
6358         (class gdbpy_enter) <m_error_type, m_error_value,
6359         m_error_traceback>: Remove.
6360         <m_error>: New member.
6361         (gdbpy_exception_to_string): Don't declare.
6362         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6363         * python/py-value.c (convert_value_from_python): Use
6364         gdbpy_err_fetch.
6365         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6366         gdbpy_exception_to_string.
6367         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6368         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6369         gdbpy_err_fetch.
6370
6371 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * linux-nat.c (delete_lwp_cleanup): Delete.
6374         (struct lwp_deleter): New struct.
6375         (lwp_info_up): New typedef.
6376         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6377         lwp_info_up.
6378
6379 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * linux-fork.c (class scoped_switch_fork_info): New class.
6382         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6383
6384 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * valops.c (find_overload_match): Remove use of null_cleanup, and
6387         calls to do_cleanups.
6388
6389 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * compile/compile-cplus-types.c
6392         (compile_cplus_instance::decl_name): Handle changes to
6393         cp_func_name.
6394         * cp-support.c (cp_func_name): Update header comment, update
6395         return type.
6396         * cp-support.h (cp_func_name): Update return type in declaration.
6397         * valops.c (find_overload_match): Move temp_func local to top
6398         level of function and change its type.  Use temp_func to hold and
6399         delete temporary string obtained from cp_func_name.
6400
6401 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6404         gdb::char_vector, remove cleanup, and update uses of `msg`.
6405
6406 2019-01-03  Jim Wilson  <jimw@sifive.com>
6407
6408         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6409
6410 2019-01-02  Tom Tromey  <tom@tromey.com>
6411
6412         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6413         (tdesc_parse_xml): Remove cleanups.
6414         * target-descriptions.h (make_cleanup_free_target_description):
6415         Don't declare.
6416         (target_desc_deleter): New struct.
6417         (target_desc_up): New typedef.
6418         * target-descriptions.c (target_desc_deleter::operator()): Rename
6419         from free_target_description.
6420         (make_cleanup_free_target_description): Remove.
6421
6422 2019-01-02  Tom Tromey  <tom@tromey.com>
6423
6424         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6425         constructor, destructor.
6426         (linespec_parser): Remove typedef.
6427         (~linespec_parser): Rename from linespec_parser_delete.
6428         (linespec_lex_to_end, linespec_complete_label)
6429         (linespec_complete): Update.
6430         (decode_line_full): Remove cleanups.
6431         (decode_line_1): Update.
6432
6433 2019-01-02  Tom Tromey  <tom@tromey.com>
6434
6435         * python/python-internal.h (inferior_to_inferior_object): Change
6436         return type.
6437         * python/py-exitedevent.c (create_exited_event_object): Update.
6438         * python/py-inferior.c (inferior_to_inferior_object): Return
6439         gdbpy_ref.
6440         (python_new_inferior, python_inferior_deleted)
6441         (thread_to_thread_object, delete_thread_object)
6442         (build_inferior_list, gdbpy_selected_inferior): Update.
6443         * python/py-infthread.c (create_thread_object): Update.  Also fail
6444         if inferior_to_inferior_object fails.
6445
6446 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6447
6448         * inferior.h (class inferior) <displaced_step_state>: New field.
6449         * infrun.h (struct displaced_step_state): Move here from
6450         infrun.c.  Initialize fields, add constructor.
6451         <inf>: Remove field.
6452         <reset>: New method.
6453         * infrun.c (struct displaced_step_inferior_state): Move to
6454         infrun.h.
6455         (displaced_step_inferior_states): Remove.
6456         (get_displaced_stepping_state): Adust.
6457         (displaced_step_in_progress_any_inferior): Adjust.
6458         (displaced_step_in_progress_thread): Adjust.
6459         (displaced_step_in_progress): Adjust.
6460         (add_displaced_stepping_state): Remove.
6461         (get_displaced_step_closure_by_addr): Adjust.
6462         (remove_displaced_stepping_state): Remove.
6463         (infrun_inferior_exit): Call displaced_step_state.reset.
6464         (use_displaced_stepping): Don't check for NULL.
6465         (displaced_step_prepare_throw): Call
6466         get_displaced_stepping_state.
6467         (displaced_step_fixup): Don't check for NULL.
6468         (prepare_for_detach): Don't check for NULL.
6469
6470 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6471
6472         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6473          in case of call that did not complete.
6474
6475 2019-01-02  Andrey Utkin  <autkin@undo.io>
6476
6477         * symfile.c (find_separate_debug_file): Fix search of debug files for
6478         remote debuggee.
6479
6480 2019-01-02  Tom Tromey  <tom@tromey.com>
6481
6482         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6483         indentation.
6484         * python/py-frame.c (frapy_older): Remove cast.
6485         (frapy_newer): Likewise.
6486         * python/py-breakpoint.c (local_setattro): Remove cast.
6487         * python/py-arch.c (archpy_name): Remove local variable.
6488         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6489
6490 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6491
6492         * unittests/basic_string_view/element_access/char/empty.cc:
6493         Fix year range in copyright header.
6494
6495 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6496
6497         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6498         Delete.
6499         <operator==>: Update with for removed field.
6500         <hash>: Likewise.
6501         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6502         <isa_features>: ...this.
6503         <abi_features>: New field.
6504         (riscv_isa_flen): Update comment.
6505         (riscv_abi_xlen): New declaration.
6506         (riscv_abi_flen): New declaration.
6507         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6508         isa_features.
6509         (riscv_abi_xlen): New function.
6510         (riscv_isa_flen): Update to get answer from isa_features.
6511         (riscv_abi_flen): New function.
6512         (riscv_has_fp_abi): Update to get answer from abi_features.
6513         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6514         xlen and flen.
6515         (riscv_call_info) <xlen, flen>: Update comment.
6516         (riscv_call_arg_struct): Remove invalid assertions
6517         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6518         is removed.
6519         (riscv_gdbarch_init): Gather isa features and abi features
6520         separately, ensure both match on the gdbarch when reusing an old
6521         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6522         a target with 64-bit float hardware.
6523
6524 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6525
6526         * source.c (search_command_helper): Stop reverse search
6527         when line 1 has been searched.
6528
6529 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6530
6531         * record-full.c (record_full_base_target::close): Rewrite
6532         record_full_core_buf_list free logic.
6533
6534 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6535
6536         * break-catch-syscall.c (print_one_catch_syscall): xfree
6537         the last text.
6538
6539 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6540
6541         * top.c (print_gdb_version): Update Copyright year in version
6542         message.
6543
6544 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6545
6546         Update copyright year range in all GDB files.
6547
6548 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6549
6550         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6551
6552 For older changes see ChangeLog-2018.
6553 \f
6554 Local Variables:
6555 mode: change-log
6556 left-margin: 8
6557 fill-column: 74
6558 version-control: never
6559 coding: utf-8
6560 End:
6561