gdb/ChangeLog

   1 2018-08-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>
   2
   3         * remote.c (remote_target::download_tracepoint): Change char* to
   4         const char*.
   5
   6 2018-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
   7
   8         * target.h (target_options_to_string): Return an std::string.
   9         * target.c (str_comma_list_concat_elem): Return void, use
  10         std::string.
  11         (do_option): Likewise.
  12         (target_options_to_string): Return an std::string.
  13         * linux-nat.c (linux_nat_target::wait): Adjust.
  14         * target-debug.h (target_debug_print_options): Adjust.
  15
  16 2018-08-07  Tom Tromey  <tom@tromey.com>
  17
  18         * Makefile.in (CPPFLAGS): New variable.
  19         (INTERNAL_CPPFLAGS): Use it.
  20
  21 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  22
  23         * NEWS: Mention the index cache.
  24
  25 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  26
  27         * common/pathstuff.h (get_standard_cache_dir): New.
  28         * common/pathstuff.c (get_standard_cache_dir): New.
  29         * build-id.h (build_id_to_string): New.
  30         * dwarf-index-common.h (INDEX4_SUFFIX, INDEX5_SUFFIX,
  31         DEBUG_STR_SUFFIX): Move to here.
  32         * dwarf-index-write.c (INDEX4_SUFFIX, INDEX5_SUFFIX,
  33         DEBUG_STR_SUFFIX): Move from there.
  34         (write_psymtabs_to_index): Make non-static, add basename
  35         parameter.  Write to temporary files, rename when done.
  36         (save_gdb_index_command): Adjust call to
  37         write_psymtabs_to_index.
  38         * dwarf2read.h (dwarf2_per_objfile) <index_cache_res>: New
  39         field.
  40         * dwarf2read.c (dwz_file) <index_cache_res>: New field.
  41         (get_gdb_index_contents_from_cache): New.
  42         (get_gdb_index_contents_from_cache_dwz): New.
  43         (dwarf2_initialize_objfile): Read index from cache.
  44         (dwarf2_build_psymtabs): Save to index.
  45         * dwarf-index-cache.h: New file.
  46         * dwarf-index-cache.c: New file.
  47         * dwarf-index-write.h: New file.
  48
  49 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  50
  51         * gnulib/aclocal.m4: Re-generate.
  52         * gnulib/config.in: Re-generate.
  53         * gnulib/configure: Re-generate.
  54         * gnulib/import/Makefile.am: Re-generate.
  55         * gnulib/import/Makefile.in: Re-generate.
  56         * gnulib/import/m4/gnulib-cache.m4: Re-generate.
  57         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
  58         * gnulib/import/m4/mkdir.m4: New file.
  59         * gnulib/import/mkdir.c: New file.
  60         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkdir
  61         module.
  62
  63 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  64
  65         * Makefile.in (COMMON_SFILES): Add common/scoped_mmap.c.
  66         * common/scoped_mmap.c: New file.
  67         * common/scoped_mmap.h (destroy): New method.
  68         (~scoped_mmap, reset): Use destroy.
  69         (scoped_mmap): New move constructor.
  70         (mmap_file): New declaration.
  71         * unittests/scoped_mmap-selftests.c (test_normal,
  72         test_invalid_filename, run_tests): New functions.
  73         (_initialize_scoped_mmap_selftests): Register selftest.
  74
  75 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  76
  77         * dwarf2read.c (read_gdb_index_from_section): Rename to...
  78         (read_gdb_index_from_buffer): ... this.  Remove section
  79         parameter, add buffer parameter.
  80         (get_gdb_index_contents_ftype,
  81         get_gdb_index_contents_dwz_ftype): New typedefs.
  82         (dwarf2_read_gdb_index): Add callback parameters to get the
  83         index contents.
  84         (get_gdb_index_contents_from_section): New.
  85         (dwarf2_initialize_objfile): Update call to
  86         dwarf2_read_gdb_index.
  87
  88 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  89
  90         * common/filestuff.h (gdb_fopen_cloexec): New overload.
  91         (gdb_open_cloexec): Likewise.
  92         * nat/linux-osdata.c (command_from_pid): Use string_printf.
  93         (commandline_from_pid): Likewise.
  94         (linux_xfer_osdata_threads): Likewise.
  95         (linux_xfer_osdata_fds): Likewise.
  96         * ada-lang.c (is_package_name): Likewise.
  97         * auxv.c (procfs_xfer_auxv): Likewise.
  98         * breakpoint.c (print_one_breakpoint_location): Use
  99         uiout::field_fmt.
 100         (print_one_catch_solib): Use string_printf.
 101         * coff-pe-read.c (add_pe_exported_sym): Likewise.
 102         (add_pe_forwarded_sym): Likewise.
 103         * dwarf2read.c (create_type_unit_group): Likewise.
 104         (build_error_marker_type): Likewise.
 105         * infcall.c (get_function_name): Likewise.
 106         * valprint.c (print_converted_chars_to_obstack): Likewise.
 107         * xtensa-tdep.c (xtensa_register_type): Likewise.
 108
 109 2018-08-06  Simon Marchi  <simon.marchi@ericsson.com>
 110
 111         * remote.c (remote_target::download_tracepoint): Fix format
 112         string errors.
 113
 114 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 115
 116         * tracefile.c: Include common/byte-vector.h.
 117         (trace_save): Change type of buf to gdb::byte_vector.  Initialize
 118         with trace_regblock_size if needed.  Update uses of buf.
 119
 120 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 121
 122         * tracepoint.h (collection_list) <m_regs_mask>: Change type to
 123         std::vector<unsigned char>.
 124         * tracepoint.c (collection_list::collection_list): Remove
 125         m_regs_mask initializer from initializer list.  Resize
 126         m_regs_mask using the largest remote register number.
 127         (collection_list::add_remote_register): Remove size check on
 128         m_regs_mask.  Use at to access element.
 129         (collection_list::stringify): Change type of temp_buf to
 130         gdb::char_vector.  Update uses of temp_buf.  Resize if needed to
 131         stringify the register mask.  Use pack_hex_byte for the register
 132         mask.
 133
 134 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 135
 136         * tracepoint.h (class collection_list) <add_register>: Remove.
 137         <add_remote_register, add_ax_registers, add_local_register>:
 138         Declare.
 139         <add_memrange>: Add scope parameter.
 140         * tracepoint.c (encode_actions_1): Likewise.
 141         (collection_list::add_register): Rename to ...
 142         (collection_list::add_remote_register): ... this.  Update
 143         comment.
 144         (collection_list::add_ax_registers, add_local_register): New
 145         methods.
 146         (collection_list::add_memrange): Add scope parameter.  Call
 147         add_local_register instead of add_register.
 148         (finalize_tracepoint_aexpr): New function.
 149         (collection_list::collect_symbol): Update calls to add_memrange.
 150         Call add_local_register instead of add_register.  Call
 151         add_ax_registers.  Call finalize_tracepoint_aexpr.
 152         (encode_actions_1): Get remote regnos for $reg action.  Call
 153         add_remote_register, add_ax_registers, and add_local_register.
 154         Update call to add_memrange.  Call finalize_tracepoint_aexpr.
 155         (validate_actionline): Call finalize_tracepoint_aexpr.
 156
 157 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 158
 159         * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
 160         Replace array buf with gdb::char_vector buf, of size
 161         get_remote_packet_size ().  Replace references to buf and
 162         BUF_SIZE to buf.data () and buf.size ().  Replace strcpy, strcat
 163         and xsnprintf with snprintf.  Raise errors if the buffer is too
 164         small.
 165
 166 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 167
 168         * remote.c (remote_target::download_tracepoint): Fix the has_more
 169         predicate in the QTDP action list iteration.
 170
 171 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 172
 173         * remote.c (remote_target::download_tracepoint): Fix indentation
 174         in for block.
 175
 176 2018-08-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 177
 178         * proc-api.c (_initialize_proc_api): Remove c, unused.
 179         * procfs.c (procfs_init_inferior): Remove signals, unused.
 180         (procfs_target::make_corefile_notes): Remove old_chain, fpregs,
 181         unused.
 182
 183 2018-08-06  Sergey Korolev  <s.korolev@ndmsystems.com>
 184             Andrew Burgess  <andrew.burgess@embecosm.com>
 185
 186         * linux-nat.c (linux_nat_target::follow_fork): Avoid using
 187         'W_STOPCODE (0)' as this could be ambiguous.
 188
 189 2018-08-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 190
 191         * ser-tcp.c (net_open): Fix thinko when deciding whether to
 192         disable TCP's Nagle algorithm (use "ai_protocol" instead of
 193         "ai_socktype").
 194
 195 2018-08-02  Tom Tromey  <tom@tromey.com>
 196
 197         PR symtab/16842.
 198         * dwarf2read.c (read_func_scope): Set symtab on template parameter
 199         symbols.
 200         (process_structure_scope): Likewise.
 201
 202 2018-08-02  Xavier Roirand  <roirand@adacore.com>
 203
 204         PR gdb/22629:
 205         * darwin-nat.c (darwin_kill_inferior): Fix handling of
 206         kill inferior.
 207
 208 2018-08-02  Tom Tromey  <tom@tromey.com>
 209
 210         * darwin-nat.c (find_inferior_task_it, darwin_find_thread)
 211         (darwin_suspend_inferior, darwin_resume_inferior)
 212         (darwin_decode_notify_message, darwin_resume_inferior_threads)
 213         (darwin_check_new_threads): Check result of get_darwin_inferior.
 214
 215 2018-07-31  Joel Brobecker  <brobecker@adacore.com>
 216
 217         GDB 8.1.1 released.
 218
 219 2018-07-31  Jan Vrany  <jan.vrany@fit.cvut.cz>
 220
 221         * varobj.c (varobj_get_path_expr_parent): Report an error if
 222         parent is a dynamic varobj.
 223
 224 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
 225
 226         * gnulib/aclocal.m4: Re-generate.
 227         * gnulib/config.in: Re-generate.
 228         * gnulib/configure: Re-generate.
 229         * gnulib/import/Makefile.in: Re-generate.
 230         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
 231         * gnulib/import/m4/onceonly.m4: Re-generate.
 232
 233 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
 234
 235         * target-descriptions.c (struct xml_test_tdesc): New.
 236         (xml_tdesc): Change type to std::vector<xml_test_tdesc>.
 237         (record_xml_tdesc): Update.
 238         (maintenance_check_xml_descriptions): Update.
 239         * target-descriptions.h (record_xml_tdesc): Update comment.
 240
 241 2018-07-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 242
 243         * eval.c (evaluate_subexp_for_sizeof): Check for array type before
 244         checking array bounds are defined.
 245
 246 2018-07-30  Tom Tromey  <tom@tromey.com>
 247
 248         * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
 249         irreflexivity violation.
 250
 251 2018-07-30  Tom Tromey  <tom@tromey.com>
 252
 253         * cli/cli-decode.c (lookup_cmd): Remove lint code.
 254         * value.c (unpack_long): Remove lint code.
 255         * valops.c (value_ind): Remove lint code.
 256         * valarith.c (value_x_binop, value_x_unop, value_equal)
 257         (value_pos): Remove lint code.
 258
 259 2018-07-28  Tom de Vries  <tdevries@suse.de>
 260
 261         * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type
 262         with undefined upper bound as <optimized out>.
 263
 264 2018-07-27  Sergio Durigan Junior  <sergiodj@redhat.com>
 265
 266         * gcore.in: Rename variable "name" to "prefix".  Expand
 267         "usage" text.
 268
 269 2018-07-14  Jon Turney  <jon.turney@dronecode.org.uk>
 270
 271         * windows-nat.c (windows_nat_target::create_inferior): Update to
 272         call close() in global namespace.
 273
 274 2018-07-26  Tom Tromey  <tom@tromey.com>
 275
 276         * dwarf-index-write.c (add_address_entry): Don't add objfile
 277         offsets.
 278         * dbxread.c (find_stab_function): Rename from
 279         find_stab_function_addr.  Return a bound_minimal_symbol.
 280         (read_dbx_symtab): Use raw_text_low, raw_text_high.
 281         Don't add objfile offsets.
 282         (end_psymtab): Use raw_text_low, raw_text_high,
 283         MSYMBOL_VALUE_RAW_ADDRESS.
 284         (read_ofile_symtab): Update.
 285         (process_one_symbol): Update.
 286         * dwarf2read.c (create_addrmap_from_index): Don't add objfile
 287         offsets.
 288         (dw2_relocate): Remove.
 289         (dw2_find_pc_sect_symtab): Bias PC by the text offset before
 290         searching addrmap.
 291         (dwarf2_gdb_index_functions, dwarf2_debug_names_functions):
 292         Update.
 293         (process_psymtab_comp_unit_reader, add_partial_symbol)
 294         (add_partial_subprogram, dwarf2_ranges_read): Update.
 295         (load_partial_dies): Update.
 296         (add_address_entry): Don't add objfile offsets.
 297         (dwarf2_build_include_psymtabs): Update.
 298         (create_addrmap_from_aranges): Don't add objfile offsets.
 299         (dw2_find_pc_sect_compunit_symtab): Update.
 300         * mdebugread.c (parse_symbol): Don't add objfile offsets.
 301         (parse_lines): Remove 'pst' parameter, replace with 'textlow'.
 302         Update.
 303         (parse_partial_symbols): Don't add objfile offsets.  Use
 304         raw_text_low, raw_text_high.  Update.
 305         (handle_psymbol_enumerators, psymtab_to_symtab_1): Update.
 306         * objfiles.c (objfile_relocate1): Don't relocate psymtabs_addrmap
 307         or call 'relocate' quick function.  Clear psymbol_map.
 308         * psympriv.h (struct partial_symbol) <address>: Add section
 309         offset.
 310         <set_unrelocated_address>: Rename from set_address.
 311         <raw_text_low, raw_text_high>: New methods.
 312         <text_low, text_high>: Add objfile parameter.
 313         (add_psymbol_to_bcache): Add 'section' parameter.  Call
 314         set_unrelocated_address.
 315         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 316         (find_pc_psymbol): Update.
 317         (fixup_psymbol_section, relocate_psymtabs): Remove.
 318         (dump_psymtab, psym_functions): Update.
 319         (add_psymbol_to_bcache, add_psymbol_to_list): Add 'section'
 320         parameter.
 321         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 322         (start_psymtab_common): Update.
 323         * symfile-debug.c (debug_qf_relocate): Remove.
 324         (debug_sym_quick_functions): Update.
 325         * symfile.h (struct quick_symbol_functions) <relocate>: Remove.
 326         * xcoffread.c (scan_xcoff_symtab): Don't add objfile offsets.
 327         Update.
 328
 329 2018-07-26  Tom Tromey  <tromey@redhat.com>
 330
 331         * dbxread.c (end_psymtab): Use text_high_valid and
 332         text_low_valid.
 333         * mdebugread.c (parse_partial_symbols): Use text_low_valid.
 334         (psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
 335         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
 336         Update comment.
 337         <text_low_valid, text_high_valid>: New fields.
 338         <set_text_low, set_text_high>: Update.
 339         * xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
 340
 341 2018-07-26  Tom Tromey  <tom@tromey.com>
 342
 343         * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
 344         Update.
 345         * dwarf2read.c (dwarf2_create_include_psymtab): Don't initialize
 346         textlow and texthigh fields.
 347         (process_psymtab_comp_unit_reader, dwarf2_build_include_psymtabs):
 348         Update.
 349         * mdebugread.c (parse_lines, parse_partial_symbols)
 350         (psymtab_to_symtab_1): Update.
 351         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
 352         Rename fields.  Update comment.  Now private.
 353         <text_low, text_high, set_text_low, set_text_high>: New methods.
 354         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 355         (find_pc_sect_psymbol, relocate_psymtabs, dump_psymtab)
 356         (start_psymtab_common, maintenance_info_psymtabs)
 357         (maintenance_check_psymtabs): Update.
 358         * xcoffread.c (xcoff_end_psymtab): Don't initialize textlow and
 359         texthigh fields.
 360         (scan_xcoff_symtab): Update.
 361
 362 2018-07-26  Tom Tromey  <tromey@redhat.com>
 363
 364         * psympriv.h (struct partial_symbol) <unrelocated_address,
 365         address, set_address>: New methods.
 366         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol)
 367         (fixup_psymbol_section, relocate_psymtabs): Update.
 368         (print_partial_symbols): Add 'objfile' parameter.  Update.
 369         (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map):
 370         Update.
 371
 372 2018-07-26  Tom Tromey  <tom@tromey.com>
 373
 374         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 375         (debug_names::write_psymbols): Update.
 376         * psympriv.h (struct partial_symbol): Derive from
 377         general_symbol_info.
 378         <obj_section>: New method.
 379         (PSYMBOL_DOMAIN, PSYMBOL_CLASS): Remove.n
 380         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 381         (find_pc_sect_psymbol, fixup_psymbol_section)
 382         (match_partial_symbol, lookup_partial_symbol, relocate_psymtabs)
 383         (print_partial_symbols, recursively_search_psymtabs)
 384         (compare_psymbols, psymbol_hash, psymbol_compare)
 385         (add_psymbol_to_bcache, maintenance_check_psymtabs)
 386         (psymbol_name_matches, psym_fill_psymbol_map): Update.
 387
 388 2018-07-26  Tom Tromey  <tromey@redhat.com>
 389
 390         * dbxread.c (end_psymtab): Remove dead code.
 391
 392 2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 393
 394         * dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
 395         DWARF unwinders are disabled.
 396         * dwarf2-frame.c: Add dwarf2read.h include.
 397         (dwarf2_frame_sniffer): Exit early if DWARF unwinders are
 398         disabled.
 399         (dwarf2_frame_unwinders_enabled_p): Define.
 400         (show_dwarf_unwinders_enabled_p): New function.
 401         (_initialize_dwarf2_frame): Register switch to control DWARF
 402         unwinder use.
 403         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
 404         * dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
 405         (show_dwarf_cmdlist): Remove static keyword.
 406         * dwarf2read.h (set_dwarf_cmdlist): Declare.
 407         (show_dwarf_cmdlist): Declare.
 408         * NEWS: Document new feature.
 409
 410 2018-07-26  Tom de Vries  <tdevries@suse.de>
 411
 412         PR breakpoints/23366
 413         * infcmd.c (info_program_command): Handle ptid == minus_one_ptid.
 414
 415 2018-07-26  Tom de Vries  <tdevries@suse.de>
 416
 417         * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
 418         DW_AT_count can't be translated to a dynamic prop.
 419
 420 2018-07-25  Tom de Vries  <tdevries@suse.de>
 421
 422         * dwarf2loc.c (dwarf2_locexpr_baton_eval): Wrap ctx.eval call in
 423         try/catch.
 424
 425 2018-07-25  Jan Vrany  <jan.vrany@fit.cvut.cz>
 426
 427         * breakpoint.c (enable_disable_bp_num_loc): Notify observers.
 428
 429 2018-07-25  Joel Brobecker  <brobecker@adacore.com>
 430
 431         * MAINTAINERS (Global Maintainers): Add Tom Tromey.
 432
 433 2018-07-24  Keith Seitz  <keiths@redhat.comt
 434
 435         PR symtab/23010
 436         * dwarf2read.c (dw2_add_symbol_to_list): New function.
 437         (fixup_go_packaging, new_symbol): Use dw2_add_symbol_to_list
 438         instead of add_symbol_to_list.
 439         (read_file_scope): Call prepare_one_comp_unit before reading
 440         any other DIEs.
 441
 442 2018-07-24  Simon Marchi  <simon.marchi@ericsson.com>
 443
 444         * common/scoped_mmap.h (class scoped_mmap): Fix indentation.
 445
 446 2018-07-24  Tom Tromey  <tom@tromey.com>
 447
 448         * utils.c (malloc, realloc, free): Don't declare.
 449         * configure, config.in: Rebuild.
 450         * configure.ac: Don't check for declarations of free, malloc, or
 451         realloc.
 452
 453 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 454
 455         * aarch64-linux-nat.c
 456         (aarch64_linux_nat_target::stopped_data_address): Remove unused
 457         variable.
 458         * arm-linux-nat.c (fetch_regs): Likewise.
 459         (store_regs): Likewise.
 460         (fetch_vfp_regs): Likewise.
 461         (store_vfp_regs): Likewise.
 462         (arm_linux_nat_target::insert_hw_breakpoint): Likewise.
 463         (arm_linux_nat_target::remove_hw_breakpoint): Likewise.
 464         (arm_linux_nat_target::insert_watchpoint): Likewise.
 465         (arm_linux_nat_target::remove_watchpoint): Likewise.
 466         * mips-linux-nat.c (mips_linux_nat_target::insert_watchpoint):
 467         Likewise.
 468         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs):
 469         Likewise.
 470         * ppc-linux-nat.c (fetch_register): Likewise.
 471         (fetch_all_gp_regs): Likewise.
 472         (fetch_ppc_registers): Likewise.
 473         (store_all_gp_regs): Likewise.
 474         (store_ppc_registers): Likewise.
 475         (hwdebug_insert_point): Likewise.
 476         (can_use_watchpoint_cond_accel): Likewise.
 477         * remote-sim.c (gdb_os_write_stdout): Likewise.
 478
 479 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 480             Tom Tromey  <tom@tromey.com>
 481
 482         * warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
 483         test for it.
 484         * configure: Rebuild.
 485
 486 2018-07-22  Tom Tromey  <tom@tromey.com>
 487
 488         * regformats/regdat.sh: Define xmltarget_${name} inside
 489         #ifndef IN_PROCESS_AGENT.
 490
 491 2018-07-22  Tom Tromey  <tom@tromey.com>
 492
 493         * value.c (value_fetch_lazy_bitfield): Remove unused variable.
 494
 495 2018-07-22  Tom Tromey  <tom@tromey.com>
 496
 497         * symfile.c (reread_symbols): Notify iter, not objfile.
 498
 499 2018-07-22  Tom Tromey  <tom@tromey.com>
 500
 501         * ravenscar-thread.c (ravenscar_thread_target::store_registers):
 502         Use arch_ops.
 503         (ravenscar_thread_target::prepare_to_store): Likewise.
 504
 505 2018-07-22  Tom Tromey  <tom@tromey.com>
 506
 507         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
 508         unused variable.  Call value_fetch_lazy when needed.
 509         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 510         Remove unused variable.  Call value_fetch_lazy when needed.
 511
 512 2018-07-22  Tom Tromey  <tom@tromey.com>
 513
 514         * m32c-tdep.c (mark_dma): Return void.
 515         (make_regs): Remove unused declarations.
 516
 517 2018-07-22  Tom Tromey  <tom@tromey.com>
 518
 519         * guile/scm-cmd.c (gdbscm_dont_repeat): Call
 520         cmdscm_get_valid_command_smob_arg_unsafe for effect.
 521         * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
 522         bkscm_get_valid_block_smob_arg_unsafe for effect.
 523
 524 2018-07-22  Tom Tromey  <tom@tromey.com>
 525
 526         * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
 527         value_type.
 528
 529 2018-07-22  Tom Tromey  <tom@tromey.com>
 530
 531         * windows-nat.c (saved_context): Conditionally define.
 532         * remote.c (remote_target::remote_btrace_maybe_reopen):
 533         Conditionally declare "warned".
 534         * inflow.c (sigquit_ours): Conditionally define.
 535         (new_tty): Move "tty" declaration inside #if.
 536         * guile/guile.c (guile_datadir): Conditionally define.
 537         * charset.c (set_be_le_names): Move some declarations inside #if.
 538         * btrace.c (parse_xml_btrace): Move "errcode" declaration inside
 539         #if.
 540         (parse_xml_btrace_conf): Likewise.
 541
 542 2018-07-22  Tom Tromey  <tom@tromey.com>
 543
 544         * spu-tdep.c (spu_get_overlay_table): Remove unused variable.
 545
 546 2018-07-22  Tom Tromey  <tom@tromey.com>
 547
 548         * guile/scm-value.c (gdbscm_value_call): Remove unused variables.
 549         * guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
 550         (vlscm_convert_typed_value_from_scheme): Remove unused variable.
 551         * buildsym-legacy.c (get_macro_table): Remove unused variable.
 552         * stack.c (frame_apply_level_command): Remove unused variable.
 553         * tic6x-tdep.c (tic6x_push_dummy_call): Remove unused variable.
 554         * sparc64-tdep.c (adi_examine_command): Remove unused variable.
 555         * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Remove
 556         unused variable.
 557         * nios2-tdep.c (nios2_push_dummy_call): Remove unused variable.
 558         * mep-tdep.c (mep_push_dummy_call): Remove unused variable.
 559         * ada-lang.c (ada_lookup_symbol_list_worker): Remove unused
 560         variable.
 561         * amd64-tdep.c (amd64_supply_xsave): Remove unused variable.
 562         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Remove unused
 563         variable.
 564         * breakpoint.c (check_no_tracepoint_commands, update_watchpoint):
 565         Remove unused variable.
 566         * cli/cli-script.c (recurse_read_control_structure): Remove unused
 567         variable.
 568         * common/tdesc.c (print_xml_feature::visit): Remove unused
 569         variable.
 570         * compile/compile-object-load.c (store_regs): Remove unused
 571         variables.
 572         * complaints.c (clear_complaints): Remove unused variable.
 573         * corelow.c (core_target_open): Remove unused variable.
 574         * fbsd-tdep.c (fbsd_core_info_proc_status): Remove unused
 575         variable.
 576         * guile/scm-frame.c (gdbscm_frame_read_var): Remove unused
 577         variable.
 578         * guile/scm-symtab.c (stscm_print_sal_smob): Remove unused
 579         variable.
 580         * guile/scm-type.c (gdbscm_field_baseclass_p): Remove unused
 581         variable.
 582         * guile/scm-utils.c (gdbscm_parse_function_args): Remove unused
 583         variable.
 584         * hppa-tdep.c (hppa_stub_frame_unwind_cache): Remove unused
 585         variable.
 586         * ia64-tdep.c (examine_prologue): Remove unused variable.
 587         * infcall.c (run_inferior_call): Remove unused variable.
 588         * inferior.c (exit_inferior): Remove unused variable.
 589         * infrun.c (infrun_thread_ptid_changed): Remove unused variable.
 590         * linespec.c (decode_line_2): Remove unused variable.
 591         * linux-nat.c (super_close): Remove.
 592         * linux-tdep.c (linux_info_proc): Remove unused variable.
 593         * mi/mi-main.c (mi_execute_command): Remove unused variable.
 594         * microblaze-linux-tdep.c (microblaze_linux_sigtramp_cache):
 595         Remove unused variable.
 596         * parse.c (find_minsym_type_and_address): Remove unused variable.
 597         * printcmd.c (info_symbol_command, printf_floating): Remove unused
 598         variable.
 599         * python/py-breakpoint.c (bppy_set_commands): Remove unused
 600         variable.
 601         * python/py-unwind.c (unwind_infopy_dealloc): Remove unused
 602         variables.
 603         * record-btrace.c (record_btrace_target::store_registers): Remove
 604         unused variable.
 605         (cmd_show_record_btrace_cpu): Remove unused variable.
 606         * riscv-tdep.c (riscv_register_reggroup_p)
 607         (riscv_push_dummy_call, riscv_return_value): Remove unused
 608         variable.
 609         * rust-exp.y (literal): Remove unused variable.
 610         * rust-lang.c (rust_evaluate_subexp) <OP_RUST_ARARAY>: Remove
 611         unused variable.
 612         <STRUCTOP_ANONYMOUS>: Likewise.
 613         * s390-linux-tdep.c (s390_linux_init_abi_31)
 614         (s390_linux_init_abi_64): Remove unused variable.
 615         * ser-ming2.c (ser_windows_read_prim, pipe_select_thread)
 616         (file_select_thread, net_windows_open, _initialize_ser_windows):
 617         Remove unused variables.
 618         * symtab.c (find_pc_sect_line): Remove unused variable.
 619         * target-memory.c (compute_garbled_blocks): Remove unused
 620         variable.
 621         (target_write_memory_blocks): Remove unused variable.
 622         * target.c (target_stack::unpush): Remove unused variables.
 623         * tracepoint.c (start_tracing, all_tracepoint_actions)
 624         (merge_uploaded_trace_state_variables)
 625         (print_one_static_tracepoint_marker): Remove unused variable.
 626         * unittests/basic_string_view/element_access/char/1.cc (test01):
 627         Remove unused variable.
 628         * windows-nat.c (windows_continue, windows_add_all_dlls)
 629         (do_initial_windows_stuff, windows_nat_target::create_inferior):
 630         Remove unused variables.
 631
 632 2018-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
 633
 634         * arm-tdep.c (arm_gdbarch_init): Declare attr_arch and
 635         attr_profile in HAVE_ELF.
 636         * rs6000-tdep.c (bfd_uses_spe_extensions): Declare vector_abi in
 637         HAVE_ELF.
 638
 639 2018-07-20  Simon Marchi  <simon.marchi@polymtl.ca>
 640
 641         * frame.c (frame_register_unwind): Change parameter name.
 642         (frame_unwind_register): Likewise.
 643         (frame_unwind_register_value): Likewise.
 644         (frame_unwind_register_signed): Likewise.
 645         (frame_unwind_register_unsigned): Likewise.
 646         * frame.h (frame_register_unwind): Likewise.
 647         (frame_unwind_register): Likewise.
 648         (frame_unwind_register_value): Likewise.
 649         (frame_unwind_register_signed): Likewise.
 650         (frame_unwind_register_unsigned): Likewise.
 651         (frame_unwind_arch): Likewise.
 652
 653 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
 654
 655         * MAINTAINERS: Update my e-mail address, downgrade to MIPS I-IV
 656         ISA maintenance.
 657
 658 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
 659
 660         * mips-linux-nat.c (mips_linux_nat_target::read_description):
 661         Call `get_ptrace_pid' rather than extracting the ptrace PID by
 662         hand.
 663
 664 2018-07-20  Keith Seitz  <keiths@redhat.com>
 665
 666         * buildsym.h (struct buildsym_compunit) <m_objfile, m_subfiles,
 667         m_main_subfile, m_comp_dir, m_producer, m_debugformat,
 668         m_compunit_symtab, m_language>: Add "m_" prefix.
 669         Update all uses.
 670         * buildsym.c: Update all uses.
 671
 672 2018-07-20  Tom Tromey  <tom@tromey.com>
 673
 674         * buildsym-legacy.h (record_line): Don't use record_line_ftype.
 675         * buildsym.h (record_line_ftype): Remove typedef.
 676
 677 2018-07-20  Tom Tromey  <tom@tromey.com>
 678
 679         * buildsym-legacy.h (augment_type_symtab): Don't declare.
 680         (end_expandable_symtab): Likewise.
 681         (end_symtab_get_static_block): Likewise.
 682         (end_symtab_from_static_block): Likewise.
 683         * buildsym-legacy.c (augment_type_symtab): Remove.
 684         (end_expandable_symtab): Remove.
 685         (end_symtab_get_static_block): Remove.
 686         (end_symtab_from_static_block): Remove.
 687
 688 2018-07-20  Tom Tromey  <tom@tromey.com>
 689
 690         * dwarf2read.c: Include buildsym.h.
 691         (struct dwarf2_cu) <builder>: New method.
 692         (fixup_go_packaging): Update.
 693         (process_full_comp_unit, process_full_type_unit): Update.  Don't
 694         use scoped_free_pendings.
 695         (using_directives): Add "cu" parameter, remove "language".
 696         (read_import_statement, setup_type_unit_groups, )
 697         (read_func_scope, read_lexical_block_scope)
 698         (dwarf2_record_block_ranges, read_namespace): Update.
 699         (lnp_state_machine::lnp_state_machine): Add cu parameter.
 700         (lnp_state_machine::handle_end_sequence): Update.
 701         (class lnp_state_machine) <m_cu>: New member.
 702         <m_record_line_callback>: Remove.
 703         <m_currently_recording_lines>: New member.
 704         (lnp_state_machine::handle_set_file): Update.
 705         (noop_record_line): Remove.
 706         (dwarf_record_line_p): Add cu parameter.
 707         (dwarf_record_line_1, dwarf_finish_line): Likewise.
 708         (lnp_state_machine::record_line)
 709         (lnp_state_machine::lnp_state_machine)
 710         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 711         (dwarf_decode_lines): Update.
 712         (dwarf2_start_subfile): Add cu parameter.
 713         (dwarf2_start_symtab, new_symbol): Update.
 714         (macro_start_file, dwarf_decode_macro_bytes): Add cu parameter.
 715         Remove dwarf2_per_objfile parameter.
 716         (dwarf_decode_macros): Update.
 717
 718 2018-07-20  Tom Tromey  <tom@tromey.com>
 719
 720         * stabsread.c (define_symbol): Update.
 721         * buildsym-legacy.h (get_buildsym_compunit): Declare.
 722         * dwarf2read.c (new_symbol): Update.
 723         * cp-support.h (cp_scan_for_anonymous_namespaces): Update.
 724         * cp-namespace.c: Include buildsym.h.
 725         (cp_scan_for_anonymous_namespaces): Add "compunit" parameter.
 726         * buildsym-legacy.c (get_buildsym_compunit): New function.
 727
 728 2018-07-20  Tom Tromey  <tom@tromey.com>
 729
 730         * xcoffread.c: Include buildsym-legacy.h.
 731         * windows-nat.c: Include buildsym-legacy.h.
 732         * stabsread.c: Include buildsym-legacy.h.
 733         * mdebugread.c: Include buildsym-legacy.h.
 734         * buildsym-legacy.h: New file.
 735         * buildsym-legacy.c: New file, from buildsym.c.
 736         * go32-nat.c: Include buildsym-legacy.h.
 737         * dwarf2read.c: Include buildsym-legacy.h.
 738         * dbxread.c: Include buildsym-legacy.h.
 739         * cp-namespace.c: Include buildsym-legacy.h.
 740         * coffread.c: Include buildsym-legacy.h.
 741         * buildsym.h: Move some contents to buildsym-legacy.h.
 742         * buildsym.c: Include buildsym-legacy.h.  Move many functions to
 743         buildsym-legacy.c.
 744         * Makefile.in (HFILES_NO_SRCDIR): Add buildsym-legacy.h.
 745
 746 2018-07-20  Tom Tromey  <tom@tromey.com>
 747
 748         * buildsym.h (struct buildsym_compunit): Move from buildsym.c.
 749         * buildsym.c (struct buildsym_compunit): Move to buildsym.h.
 750         (buildsym_compunit::buildsym_compunit)
 751         (buildsym_compunit::~buildsym_compunit)
 752         (buildsym_compunit::get_macro_table): Define.
 753
 754 2018-07-20  Tom Tromey  <tom@tromey.com>
 755
 756         * buildsym.c (reset_symtab_globals): Remove.
 757         (buildsym_compunit::end_symtab_from_static_block): Update.
 758         (buildsym_compunit::augment_type_symtab): Update.
 759         (end_symtab_from_static_block): Call free_buildsym_compunit.
 760         (augment_type_symtab, end_symtab, end_expandable_symtab):
 761         Likewise.
 762
 763 2018-07-20  Tom Tromey  <tom@tromey.com>
 764
 765         * arch-utils.c: Do not include buildsym.h.
 766         * mipsread.c: Do not include buildsym.h.
 767         * machoread.c: Do not include buildsym.h.
 768         * elfread.c: Do not include buildsym.h.
 769
 770 2018-07-20  Tom Tromey  <tom@tromey.com>
 771
 772         * buildsym.c (buildsym_compunit::buildsym_compunit): Do more
 773         initialization.
 774         (buildsym_compunit): Add new constructor.
 775         (struct buildsym_compunit) <get_last_source_file, finish_block,
 776         record_block_range, start_subfile, patch_subfile_names,
 777         push_subfile, pop_subfile, record_line, get_compunit_symtab,
 778         set_last_source_start_addr, get_last_source_start_addr,
 779         get_local_using_directives, set_local_using_directives,
 780         get_global_using_directives, outermost_context_p,
 781         get_current_context_stack, get_context_stack_depth,
 782         get_current_subfile, get_local_symbols, get_file_symbols,
 783         get_global_symbols, record_debugformat, record_producer,
 784         push_context, pop_context, end_symtab_get_static_block,
 785         end_symtab_from_static_block, end_symtab, end_expandable_symtab>:
 786         New public methods.
 787         <record_pending_block, finish_block_internal, make_blockvector,
 788         watch_main_source_file_lossage, end_symtab_with_blockvector>: New
 789         private methods.
 790         Update all users.
 791
 792 2018-05-22  Tom Tromey  <tom@tromey.com>
 793
 794         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
 795         parameter.
 796         (finish_block_internal): Update.
 797
 798 2018-07-20  Tom Tromey  <tom@tromey.com>
 799
 800         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
 801         parameter.
 802         (finish_block_internal): Update.
 803
 804 2018-07-20  Tom Tromey  <tom@tromey.com>
 805
 806         * buildsym.h (EXTERN): Don't define or undef.
 807         * buildsym.c (EXTERN): Don't define.
 808
 809 2018-07-20  Tom Tromey  <tom@tromey.com>
 810
 811         * buildsym.c: Remove TODO comment.
 812
 813 2018-07-20  Tom Tromey  <tom@tromey.com>
 814
 815         * coffread.c (coff_symtab_read): Update.
 816         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 817         (xcoff_new_init): Update.
 818         * mipsread.c (mipscoff_new_init): Update.
 819         * mdebugread.c (mdebug_build_psymtabs): Update.
 820         * elfread.c (elf_new_init): Update.
 821         * dwarf2read.c (process_full_comp_unit, process_full_type_unit):
 822         Update.
 823         * dbxread.c (dbx_new_init, dbx_psymtab_to_symtab_1)
 824         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 825         (stabsect_build_psymtabs): Update.
 826         * buildsym.h (buildsym_init): Don't declare.
 827         * buildsym.c: Update comment.
 828         (prepare_for_building): Remove.
 829         (start_symtab, restart_symtab): Update.
 830         (reset_symtab_globals): Update comment.
 831         (buildsym_init): Remove.
 832
 833 2018-07-20  Tom Tromey  <tom@tromey.com>
 834
 835         * xcoffread.c (read_xcoff_symtab, process_xcoff_symbol): Update.
 836         * stabsread.c (patch_block_stabs, define_symbol, read_type)
 837         (read_enum_type, common_block_start, common_block_end)
 838         (cleanup_undefined_types_1, finish_global_stabs): Update.
 839         * mdebugread.c (psymtab_to_symtab_1): Update.
 840         * dwarf2read.c (fixup_go_packaging, read_func_scope)
 841         (read_lexical_block_scope, new_symbol): Update.
 842         * dbxread.c (process_one_symbol): Update.
 843         * coffread.c (coff_symtab_read, process_coff_symbol)
 844         (coff_read_enum_type): Update.
 845         * buildsym.h (file_symbols, global_symbols, local_symbols): Don't
 846         declare.
 847         (get_local_symbols, get_file_symbols, get_global_symbols): New
 848         functions.
 849         * buildsym.c (~buildsym_compunit): Clean up m_file_symbols and
 850         m_global_symbols.
 851         <m_file_symbols, m_local_symbols, m_global_symbols>: New members.
 852         (~scoped_free_pendings): Update.
 853         (finish_block, prepare_for_building, reset_symtab_globals)
 854         (end_symtab_get_static_block, end_symtab_with_blockvector)
 855         (augment_type_symtab, push_context): Update.
 856         (get_local_symbols, get_file_symbols, get_global_symbols): New
 857         functions.
 858         (buildsym_init): Update.
 859
 860 2018-07-20  Tom Tromey  <tom@tromey.com>
 861
 862         * dwarf2read.c (process_full_comp_unit): Do not set list_in_scope.
 863         (process_full_type_unit): Likewise.
 864         (dwarf2_start_symtab): Set list_in_scope.
 865
 866 2018-07-20  Tom Tromey  <tom@tromey.com>
 867
 868         * dwarf2read.c (process_psymtab_comp_unit_reader)
 869         (build_type_psymtabs_reader): Do not set list_in_scope.
 870
 871 2018-07-20  Tom Tromey  <tom@tromey.com>
 872
 873         * buildsym.c (free_pendings): Remove.
 874         (add_symbol_to_list, scoped_free_pendings)
 875         (finish_block_internal, buildsym_init): Update.
 876
 877 2018-07-20  Tom Tromey  <tom@tromey.com>
 878
 879         * xcoffread.c (read_xcoff_symtab): Update.
 880         * dwarf2read.c (read_func_scope, read_lexical_block_scope):
 881         Update.
 882         * dbxread.c (process_one_symbol): Update.
 883         * coffread.c (coff_symtab_read): Update.
 884         * buildsym.h (finish_block): Update.
 885         * buildsym.c (finish_block): Remove "listhead" argument.
 886         (end_symtab_get_static_block): Update.
 887
 888 2018-07-20  Tom Tromey  <tom@tromey.com>
 889
 890         * buildsym.h (class scoped_free_pendings): Remove constructor.
 891         * buildsym.c (struct buildsym_compunit) <free_pending_blocks>: New
 892         method.
 893         <m_pending_block_obstack, m_pending_blocks>: New members.
 894         (pending_block_obstack, pending_blocks): Remove.
 895         (scoped_free_pendings::scoped_free_pendings): Default.
 896         (~scoped_free_pendings): Update.
 897         (free_pending_blocks): Remove.
 898         (finish_block_internal, record_pending_block, make_blockvector)
 899         (end_symtab_get_static_block, augment_type_symtab, push_context)
 900         (buildsym_init): Update.
 901
 902 2018-07-20  Tom Tromey  <tom@tromey.com>
 903
 904         * buildsym.c (struct buildsym_compunit) <m_pending_addrmap,
 905         m_pending_addrmap_obstack, m_pending_addrmap_interesting>: New
 906         members.
 907         (pending_addrmap, pending_addrmap_obstack)
 908         (pending_addrmap_interesting): Remove.
 909         (scoped_free_pendings, record_block_range, make_blockvector)
 910         (prepare_for_building, reset_symtab_globals, buildsym_init):
 911         Update.
 912
 913 2018-07-20  Tom Tromey  <tom@tromey.com>
 914
 915         * xcoffread.c (process_linenos): Update.
 916         * stabsread.c (define_symbol, read_type, read_enum_type): Update.
 917         * mdebugread.c (psymtab_to_symtab_1): Update.
 918         * dwarf2read.c (setup_type_unit_groups)
 919         (lnp_state_machine::handle_set_file, dwarf_record_line_p)
 920         (lnp_state_machine::record_line, dwarf_decode_lines): Update.
 921         * dbxread.c (process_one_symbol): Update.
 922         * coffread.c (coff_symtab_read, enter_linenos)
 923         (process_coff_symbol): Update.
 924         * buildsym.h (current_subfile): Don't declare.
 925         (get_current_subfile): Declare.
 926         * buildsym.c (struct buildsym_compunit) <m_current_subfile>: New
 927         member.
 928         (start_subfile, free_buildsym_compunit, push_subfile)
 929         (prepare_for_building, start_symtab): Update.
 930         (get_current_subfile): New function.
 931
 932 2018-07-20  Tom Tromey  <tom@tromey.com>
 933
 934         * coffread.c (coff_symtab_read): Update.
 935         * xcoffread.c (read_xcoff_symtab): Update.
 936         * dwarf2read.c (new_symbol): Update.
 937         (read_func_scope, read_lexical_block_scope): Update.
 938         * dbxread.c (process_one_symbol): Update.
 939         * buildsym.h (context_stack, context_stack_depth): Don't declare.
 940         (outermost_context_p): Remove macro.
 941         (outermost_context_p, get_current_context_stack)
 942         (get_context_stack_depth): Declare.
 943         (pop_context): Return struct context_stack.
 944         * buildsym.c (struct buildsym_compunit) <m_context_stack: New
 945         member.
 946         (context_stack_size): Remove.
 947         (INITIAL_CONTEXT_STACK_SIZE): Remove.
 948         (prepare_for_building, end_symtab_get_static_block)
 949         (augment_type_symtab, push_context): Update.
 950         (pop_context): Return struct context_stack.
 951         (outermost_context_p, get_current_context_stack)
 952         (get_context_stack_depth): New functions.
 953         (buildsym_init): Update.
 954
 955 2018-07-20  Tom Tromey  <tom@tromey.com>
 956
 957         * rust-exp.y: Now a pure parser.  Update all rules.
 958         (%union): Move earlier.
 959         (current_parser, work_obstack): Remove globals.
 960         (rust_parser, ~rust_parser): Update.
 961         (class rust_parser) <copy_name, concat3, crate_name, super_name,
 962         lex_character, lex_number, lex_string, lex_identifier,
 963         rust_lookup_type, convert_params_to_types, convert_ast_to_type,
 964         convert_name, convert_params_to_expression,
 965         convert_ast_to_expression, ast_basic_type, ast_operation,
 966         ast_compound_assignment, rust_op, ast_literal, ast_dliteral,
 967         ast_structop, ast_structop_anonymous, ast_unary, ast_cast,
 968         ast_call_ish, ast_path, ast_string, ast_struct, ast_range,
 969         ast_array_type, ast_slice_type, ast_reference_type,
 970         ast_pointer_type, ast_function_type, ast_tuple_type>: New methods.
 971         (rust_parse): Update.
 972         (rustyyerror, rustyylex): Add parser parameter.
 973         (rust_lex_test_one, rust_lex_int_test, rust_lex_exception_test)
 974         (rust_lex_stringish_test, rust_lex_test_sequence)
 975         (rust_lex_test_trailing_dot, rust_lex_test_completion)
 976         (rust_lex_test_push_back, rust_lex_tests): Update.
 977
 978 2018-07-19  Pedro Alves  <palves@redhat.com>
 979
 980         * guile/guile-internal.h (gdbscm_scm_to_c_string): Now returns a
 981         gdb::unique_xmalloc_ptr.
 982         * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x):
 983         Adjust to use dbscm_wrap and gdb::unique_xmalloc_ptr.
 984         * guile/scm-exception.c (gdbscm_exception_message_to_string): Use
 985         copy-initialization.
 986         * guile/scm-pretty-print.c (ppscm_print_children): Use
 987         gdb::unique_xmalloc_ptr instead of cleanups.
 988         (gdbscm_apply_val_pretty_printer): Remove cleanups.
 989         * guile/scm-string.c (gdbscm_scm_to_c_string): Now returns a
 990         gdb::unique_xmalloc_ptr.
 991         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
 992         Adjust to use gdb::unique_xmalloc_ptr.
 993         * guile/scm-utils.c (extract_arg): Adjust.
 994         * guile/scm-value.c (gdbscm_value_field): Adjust to use
 995         gdb::unique_xmalloc_ptr instead of a cleanup.
 996
 997 2018-07-19  Tom Tromey  <tom@tromey.com>
 998
 999         * utils.c (do_value_free_to_mark)
1000         (make_cleanup_value_free_to_mark): Remove.
1001         * utils.h (make_cleanup_value_free_to_mark): Remove.
1002
1003 2018-07-19  Pedro Alves  <palves@redhat.com>
1004
1005         * guile/guile-internal.h (gdbscm_wrap): Really make 'args' a
1006         forwarding reference.
1007
1008 2018-07-18  Pedro Alves  <palves@redhat.com>
1009
1010         * guile/guile.c (gdbscm_execute_gdb_command): Adjust to use
1011         gdbscm_wrap.  Use gdb::unique_xmalloc_ptr<char> instead of a
1012         cleanup.
1013
1014 2018-07-18  Pedro Alves  <palves@redhat.com>
1015
1016         * guile/guile-internal.h: Add comment about mixing GDB and Scheme
1017         exceptions.
1018         (GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS): Delete.
1019         (gdbscm_wrap): New.
1020         * guile/scm-frame.c (gdbscm_frame_read_register): Use xfree
1021         directly instead of a cleanup.
1022         * guile/scm-math.c (vlscm_unop_gdbthrow): New, factored out from ...
1023         (vlscm_unop): ... this.  Reimplement using gdbscm_wrap.
1024         (vlscm_binop_gdbthrow): New, factored out from ...
1025         (vlscm_binop): ... this.  Reimplement using gdbscm_wrap.
1026         (vlscm_rich_compare): Use gdbscm_wrap.
1027         * guile/scm-symbol.c (gdbscm_lookup_symbol): Use xfree directly
1028         instead of a cleanup.
1029         (gdbscm_lookup_global_symbol): Use xfree directly instead of a
1030         cleanup.
1031         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
1032         Use xfree directly instead of a cleanup.
1033         * guile/scm-value.c (gdbscm_make_value, gdbscm_make_lazy_value):
1034         Adjust to use gdbscm_wrap and scoped_value_mark.
1035         (gdbscm_value_optimized_out_p): Adjust to use gdbscm_wrap.
1036         (gdbscm_value_address, gdbscm_value_dereference)
1037         (gdbscm_value_referenced_value): Adjust to use gdbscm_wrap and
1038         scoped_value_mark.
1039         (gdbscm_value_dynamic_type): Use scoped_value_mark.
1040         (vlscm_do_cast, gdbscm_value_field): Adjust to use gdbscm_wrap and
1041         scoped_value_mark.
1042         (gdbscm_value_subscript, gdbscm_value_call): Adjust to use
1043         gdbscm_wrap and scoped_value_mark.
1044         (gdbscm_value_to_string): Use xfree directly instead of a
1045         cleanup.  Move 'buffer' unique_ptr to TRY scope.
1046         (gdbscm_value_to_lazy_string): Use xfree directly instead of a
1047         cleanup.  Move 'buffer' unique_ptr to TRY scope.  Use
1048         scoped_value_mark.
1049         (gdbscm_value_fetch_lazy_x): Use gdbscm_wrap.
1050         (gdbscm_parse_and_eval): Adjust to use gdbscm_wrap and
1051         scoped_value_mark.
1052         (gdbscm_history_ref, gdbscm_history_append_x): Adjust to use
1053         gdbscm_wrap.
1054
1055 2018-07-18  Tom de Vries  <tdevries@suse.de>
1056
1057         * findvar.c (default_read_var_value): Also resolve dynamic type for
1058         LOC_OPTIMIZED_OUT vars.
1059
1060 2018-07-18  Maciej W. Rozycki  <macro@mips.com>
1061
1062         * mips-tdep.c (micromips_next_pc): Add SYSCALL instruction
1063         decoding.
1064
1065 2018-07-17  Tom Tromey  <tom@tromey.com>
1066
1067         * guile/scm-param.c (pascm_set_func, pascm_show_func)
1068         (compute_enum_list, pascm_set_param_value_x)
1069         (gdbscm_parameter_value): Update.
1070         * guile/guile-internal.h (gdbscm_scm_to_string): Update.
1071         (gdbscm_scm_to_host_string): Update.
1072         * guile/scm-math.c (vlscm_convert_typed_value_from_scheme):
1073         Update.
1074         * guile/scm-cmd.c (cmdscm_add_completion): Update.
1075         * guile/scm-pretty-print.c (ppscm_print_string_repr): Update.
1076         * guile/scm-string.c (gdbscm_scm_to_string): Return
1077         unique_xmalloc_ptr.
1078         (gdbscm_scm_to_host_string): Likewise.
1079
1080 2018-07-17  Tom Tromey  <tom@tromey.com>
1081
1082         * guile/guile.c (gdbscm_eval_from_control_command): Update.
1083         * guile/guile-internal.h (gdbscm_safe_eval_string): Update.
1084         * guile/scm-objfile.c (gdbscm_execute_objfile_script): Update.
1085         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Return
1086         unique_xmalloc_ptr.
1087
1088 2018-07-17  Tom Tromey  <tom@tromey.com>
1089
1090         * guile/scm-param.c (pascm_signal_setshow_error): Update.
1091         * guile/guile-internal.h (gdbscm_exception_message_to_string):
1092         Update.
1093         * guile/scm-cmd.c (cmdscm_function): Update.
1094         * guile/scm-pretty-print.c
1095         (ppscm_print_exception_unless_memory_error): Update.
1096         * guile/scm-exception.c (gdbscm_exception_message_to_string):
1097         Return unique_xmalloc_ptr.
1098
1099 2018-07-17  Tom Tromey  <tom@tromey.com>
1100
1101         * guile/scm-pretty-print.c (ppscm_make_pp_type_error_exception):
1102         Use string_printf.
1103
1104 2018-07-17  Jim Wilson  <jimw@sifive.com>
1105
1106         * riscv-tdep.c (riscv_has_feature): Delete comment that refers to
1107         set_gdbarch_decr_pc_after_break.  Call riscv_read_misa_reg always.
1108         (riscv_gdbarch_init): Delete local has_compressed_isa.  Delete now
1109         unecessary braces after EF_RISCV_RVC test.  Delete call to
1110         set_gdbarch_decr_pc_after_break.
1111
1112         * riscv-tdep.h (DECLARE_CSR): Use RISCV_FIRST_CSR_REGNUM instead of
1113         RISCV_LAST_FP_REGNUM + 1.
1114         (RSICV_CSR_LEGACY_MISA_REGNUM): Add RISCV_FIRST_CSR_REGNUM.
1115
1116 2018-07-17  Tom Tromey  <tom@tromey.com>
1117
1118         * configure.ac: Remove --disable-gdbcli.
1119         * configure: Rebuild.
1120         * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS)
1121         (SUBDIR_CLI_CFLAGS): Remove.
1122         (SFILES): Use SUBDIR_CLI_SRCS.
1123         (COMMON_OBS): Use SUBDIR_CLI_OBS.
1124
1125 2018-07-17  Tom Tromey  <tom@tromey.com>
1126
1127         PR gdb/18624:
1128         * coffread.c (coff_symtab_read): Use scoped_free_pendings.
1129
1130 2018-07-16  Jim Wilson  <jimw@sifive.com>
1131
1132         * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
1133
1134 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1135
1136         * ia64-libunwind-tdep.c (libunwind_frame_cache): Remove unused
1137         variable.
1138         (libunwind_frame_sniffer): Likewise.
1139         (libunwind_frame_prev_register): Likewise.
1140         (libunwind_sigtramp_frame_sniffer): Likewise.
1141         * ia64-tdep.c (ia64_access_reg): Likewise.
1142         (ia64_access_rse_reg): Likewise.
1143         (ia64_libunwind_sigtramp_frame_this_id): Likewise.
1144         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Likewise.
1145
1146 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1147
1148         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Add cast.
1149
1150 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1151
1152         * remote-sim.c (gdbsim_target::close,
1153         gdbsim_target::mourn_inferior): Remove unused variables.
1154
1155 2018-07-16  Simon Marchi  <simon.marchi@polymtl.ca>
1156
1157         * ia64-tdep.c (ktab_buf): New global.
1158         (getunwind_table): Return a gdb::optional<gdb::byte_vector>.
1159         (get_kernel_table): Adjust.
1160
1161 2018-07-16  Tom Tromey  <tom@tromey.com>
1162
1163         * xcoffread.c (read_xcoff_symtab): Use outermost_context_p.
1164         * dwarf2read.c (using_directives, new_symbol): Use
1165         outermost_context_p.
1166         * dbxread.c (process_one_symbol): Use outermost_context_p.
1167         * coffread.c (coff_symtab_read): Use outermost_context_p.
1168
1169 2018-07-16  Tom Tromey  <tom@tromey.com>
1170
1171         * dwarf2read.c (using_directives, read_func_scope)
1172         (read_lexical_block_scope): Update.
1173         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1174         * buildsym.h (local_using_directives, global_using_directives):
1175         Don't declare.
1176         (get_local_using_directives, set_local_using_directives)
1177         (get_global_using_directives): Declare.
1178         * buildsym.c (struct buildsym_compunit) <m_local_using_directives,
1179         m_global_using_directives>: New members.
1180         (finish_block_internal, prepare_for_building)
1181         (reset_symtab_globals, end_symtab_get_static_block)
1182         (push_context): Update.
1183         (get_local_using_directives, set_local_using_directives)
1184         (get_global_using_directives): New functions.
1185         (buildsym_init): Update.
1186
1187 2018-07-16  Tom Tromey  <tom@tromey.com>
1188
1189         * xcoffread.c (xcoff_initial_scan): Don't call
1190         free_pending_blocks.
1191         * dbxread.c (dbx_symfile_read): Don't call free_pending_blocks.
1192         * buildsym.h (class scoped_free_pendings): Add constructor.
1193         (free_pending_blocks): Don't declare.
1194         * buildsym.c (scoped_free_pendings::scoped_free_pendings): New.
1195         (free_pending_blocks): Now static.
1196
1197 2018-07-16  Tom Tromey  <tom@tromey.com>
1198
1199         * buildsym.h (push_subfile, pop_subfile): Update declarations.
1200         * buildsym.c (struct buildsym_compunit) <m_subfile_stack>: New
1201         member.
1202         (struct subfile_stack): Remove.
1203         (subfile_stack): Remove.
1204         (push_subfile, pop_subfile, buildsym_init): Update.
1205
1206 2018-07-16  Tom Tromey  <tom@tromey.com>
1207
1208         * buildsym.c (push_subfile): Use gdb_assert.
1209         (pop_subfile): Use gdb_assert.
1210
1211 2018-07-16  Tom Tromey  <tom@tromey.com>
1212
1213         * buildsym.h (merge_symbol_lists): Remove.
1214         * buildsym.c (merge_symbol_lists): Remove.
1215
1216 2018-07-16  Tom Tromey  <tom@tromey.com>
1217
1218         * stabsread.c (scan_file_globals): Update comment.
1219         * stabsread.h (scan_file_globals): Move from buildsym.h.
1220         * buildsym.h (scan_file_globals): Move to stabsread.h.
1221
1222 2018-07-16  Tom Tromey  <tom@tromey.com>
1223
1224         * xcoffread.c (xcoff_new_init): Update.
1225         * mipsread.c (mipscoff_new_init): Update.
1226         * mdebugread.c (mdebug_build_psymtabs): Update.
1227         * elfread.c (elf_new_init): Update.
1228         * dbxread.c (dbx_new_init, coffstab_build_psymtabs)
1229         (elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
1230         * buildsym.h (buildsym_new_init): Don't declare.
1231         * buildsym.c (buildsym_new_init): Remove.
1232
1233 2018-07-16  Tom Tromey  <tom@tromey.com>
1234
1235         * stabsread.h (within_function): Move from buildsym.h.
1236         * stabsread.c (start_stabs): Clear within_function.
1237         * coffread.c (coff_start_symtab): Clear within_function.
1238         * buildsym.h (within_function): Move to stabsread.h.
1239         * buildsym.c (prepare_for_building): Update.
1240
1241 2018-07-16  Tom Tromey  <tom@tromey.com>
1242
1243         * stabsread.h (processing_gcc_compilation): Move from buildsym.h.
1244         * dwarf2read.c (dwarf2_start_symtab): Don't set
1245         processing_gcc_compilation.
1246         * buildsym.h (processing_gcc_compilation): Move to stabsread.h.
1247
1248 2018-07-16  Tom Tromey  <tom@tromey.com>
1249
1250         * stabsread.h (HASHSIZE, hashname, symnum, next_symbol_text)
1251         (next_symbol_text_func): Move from buildsym.h.
1252         * stabsread.c (hashname): Move from buildsym.c.
1253         * buildsym.h (HASHSIZE, symnum, next_symbol_text)
1254         (next_symbol_text_func, hashname): Move to stabsread.h.
1255         * buildsym.c: Don't include bcache.h
1256         (hashname): Move to stasbread.c.
1257
1258 2018-07-16  Tom Tromey  <tom@tromey.com>
1259
1260         * buildsym.h (context_stack_size): Don't declare.
1261         * buildsym.c (context_stack_size): New global.
1262
1263 2018-07-16  Tom Tromey  <tom@tromey.com>
1264
1265         * dbxread.c (processing_acc_compilation): New global.
1266         * buildsym.h (processing_acc_compilation): Don't declare.
1267
1268 2018-07-16  Tom Tromey  <tom@tromey.com>
1269
1270         * xcoffread.c (aix_process_linenos, complete_symtab): Update.
1271         * dbxread.c (read_ofile_symtab): Update.
1272         * coffread.c (coff_start_symtab, coff_end_symtab): Update.
1273         * buildsym.h (last_source_start_addr): Remove.
1274         (set_last_source_start_addr, get_last_source_start_addr):
1275         Declare.
1276         * buildsym.c (buildsym_compunit::buildsym_compunit): Add last_addr
1277         parameter.
1278         (struct buildsym_compunit) <m_last_source_start_addr>: New
1279         member.
1280         (prepare_for_building): Remove start_addr parameter.
1281         (start_symtab, restart_symtab, end_symtab_get_static_block)
1282         (end_symtab_with_blockvector): Update.
1283         (set_last_source_start_addr, get_last_source_start_addr): New
1284         functions.
1285
1286 2018-07-16  Tom Tromey  <tom@tromey.com>
1287
1288         * buildsym.c (struct buildsym_compunit) <m_have_line_numbers>: New
1289         member.
1290         (have_line_numbers): Remove.
1291         (record_line, prepare_for_building, end_symtab_get_static_block)
1292         (augment_type_symtab): Update.
1293
1294 2018-07-16  Tom Tromey  <tom@tromey.com>
1295
1296         * buildsym.c (~buildsym_compunit): Free the macro table.
1297         (struct buildsym_compunit) <get_macro_table, release_macros>: New
1298         methods.
1299         <m_pending_macros>: New member.
1300         (pending_macros): Remove.
1301         (~scoped_free_pendings, get_macro_table, prepare_for_building)
1302         (reset_symtab_globals, end_symtab_get_static_block)
1303         (end_symtab_with_blockvector, augment_type_symtab)
1304         (buildsym_init): Update.
1305
1306 2018-07-16  Tom Tromey  <tom@tromey.com>
1307
1308         * buildsym.c (buildsym_compunit::buildsym_compunit): Add name
1309         parameter.
1310         (buildsym_compunit::set_last_source_file): New method.
1311         <m_last_source_file>: New member.
1312         (prepare_for_building): Remove "name" parameter.
1313         (start_symtab, restart_symtab, reset_symtab_globals): Update.
1314         (last_source_file): Remove.
1315         (set_last_source_file, get_last_source_file): Update.
1316
1317 2018-07-16  Tom Tromey  <tom@tromey.com>
1318
1319         * buildsym.c (prepare_for_building): Add assert.
1320
1321 2018-07-16  Tom Tromey  <tom@tromey.com>
1322
1323         * buildsym.c (~buildsym_compunit): Update.
1324         (struct buildsym_compunit) <comp_unit>: Now a unique_xmalloc_ptr.
1325         (start_subfile, patch_subfile_names)
1326         (end_symtab_with_blockvector): Update.
1327
1328 2018-07-16  Tom Tromey  <tom@tromey.com>
1329
1330         * buildsym.c (struct buildsym_compunit): Add constructor,
1331         destructor, initializers.
1332         (start_buildsym_compunit): Remove.
1333         (free_buildsym_compunit): Use "delete".
1334         (start_symtab, restart_symtab): Use "new".
1335
1336 2018-07-13  Simon Marchi  <simon.marchi@polymtl.ca>
1337
1338         * symfile.c (set_objfile_default_section_offset): Remove struct
1339         keyword.
1340
1341 2018-07-14  Stafford Horne  <shorne@gmail.com>
1342
1343         * (Responsible Maintainers): Add myself as or1k maintainer.
1344
1345 2018-07-13  Tom Tromey  <tom@tromey.com>
1346
1347         * symfile.c (set_objfile_default_section_offset): Use extra braces
1348         around initializer.
1349
1350 2018-07-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1351
1352         * s390-tdep.c (s390_displaced_step_fixup): Adjust PC for a
1353         non-branching basr.
1354
1355 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1356
1357         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1358         unittests/cli-utils-selftests.c
1359         * unittests/cli-utils-selftests.c: New file.
1360
1361 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1362
1363         * NEWS: Mention new commands. Mention change to 'thread apply'.
1364
1365 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1366
1367         * thread.c (thr_try_catch_cmd): New function.
1368         (thread_apply_all_command): Handle qcs flags.
1369         (thread_apply_command): Handle qcs flags.
1370         (taas_command): New function.
1371         (tfaas_command): New function.
1372         (_initialize_thread): Update to setup the new commands 'taas
1373         and 'tfaas'. Change doc string for 'thread apply'.
1374
1375 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1376
1377         * stack.c: (trailing_outermost_frame): New function, mostly
1378         extracted from backtrace_command_1.
1379         (leading_innermost_frame): New function.
1380         (backtrace_command_1): Update to call trailing_outermost_frame.
1381         (frame_apply_command_count): New function.
1382         (frame_apply_level_command): New function.
1383         (frame_apply_all_command): New function.
1384         (frame_apply_command): New function.
1385         (faas_command): New function.
1386         (frame_cmd_list): New variable.
1387         (_initialize_stack): Update to setup the new commands 'frame apply'
1388         and 'faas'.
1389
1390 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1391
1392         * cli-utils.c (number_or_range_parser::get_number): Only handle
1393         numbers or convenience var as numbers.
1394         (parse_flags): New function.
1395         (parse_flags_qcs): New function.
1396         (number_or_range_parser::finished): Ensure parsing end is detected
1397         before end of string.
1398         * cli-utils.h (parse_flags): New function.
1399         (parse_flags_qcs): New function.
1400         (number_or_range_parser): Remove m_finished bool.
1401         (number_or_range_parser::skip_range): Set m_in_range to false.
1402
1403 2018-07-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1404
1405         * ser-tcp.c (try_connect): Declare 'ioarg' as 'u_long' if building
1406         on Windows.
1407
1408 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
1409             Jan Kratochvil  <jan.kratochvil@redhat.com>
1410             Paul Fertser  <fercerpav@gmail.com>
1411             Tsutomu Seki  <sekiriki@gmail.com>
1412             Pedro Alves  <palves@redhat.com>
1413
1414         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1415         'unittests/parse-connection-spec-selftests.c'.
1416         (COMMON_SFILES): Add 'common/netstuff.c'.
1417         (HFILES_NO_SRCDIR): Add 'common/netstuff.h'.
1418         * NEWS (Changes since GDB 8.2): Mention IPv6 support.
1419         * common/netstuff.c: New file.
1420         * common/netstuff.h: New file.
1421         * ser-tcp.c: Include 'netstuff.h' and 'wspiapi.h'.
1422         (wait_for_connect): Update comment.  New parameter
1423         'gdb::optional<int> sock' instead of 'struct serial *scb'.
1424         Use 'sock' directly instead of 'scb->fd'.
1425         (try_connect): New function, with code from 'net_open'.
1426         (net_open): Rewrite main loop to deal with multiple
1427         sockets/addresses.  Handle IPv6-style hostnames; implement
1428         support for IPv6 connections.
1429         * unittests/parse-connection-spec-selftests.c: New file.
1430
1431 2018-07-11  Pedro Alves  <palves@redhat.com>
1432
1433         PR gdb/23377
1434         * remote.c (remote_target::remote_detach_pid): Call
1435         set_current_process.
1436
1437 2018-07-11  Pedro Alves  <palves@redhat.com>
1438
1439         * h8300-tdep.c (h8300_gdbarch_init): Remove
1440         set_gdbarch_ecoff_reg_to_regnum calls.
1441
1442 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
1443
1444         PR c++/23373
1445         * c-typeprint.c (c_type_print_base_struct_union): Don't print
1446         offsets/sizes for static members of a class/struct.
1447
1448 2018-07-11  Alan Hayward  <alan.hayward@arm.com>
1449
1450         * target-descriptions.c (tdesc_register_bitsize): Rename.
1451         * target-descriptions.h (tdesc_register_bitsize): Likewise.
1452         * rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
1453         * aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
1454
1455 2018-07-10  Tom Tromey  <tom@tromey.com>
1456
1457         * breakpoint.c (moribund_locations): Now static and a
1458         std::vector.
1459         (breakpoint_init_inferior, moribund_breakpoint_here_p)
1460         (build_bpstat_chain, update_global_location_list)
1461         (breakpoint_retire_moribund): Update.
1462         * breakpoint.h (bp_location_p): Remove typedef.  Don't declare
1463         VEC.
1464
1465 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * riscv-tdep.c (riscv_is_fp_regno_p): New function.
1468         (riscv_register_reggroup_p): Use new function, remove unneeded
1469         parenthesis.
1470         (riscv_push_dummy_call): Extend assert to compare against xlen or
1471         flen based on register type.
1472
1473 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * riscv-tdep.c (riscv_print_arg_location): Use TYPE_SAFE_NAME.
1476
1477 2018-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * remote.c (show_hardware_watchpoint_limit): New function.
1480         (show_hardware_watchpoint_length_limit): New function.
1481         (show_hardware_breakpoint_limit): New function.
1482         (_initialize_remote): Use add_setshow_zuinteger_unlimited_cmd
1483         where appropriate, update help text.
1484
1485 2018-07-09  Tom Tromey  <tom@tromey.com>
1486
1487         * Makefile.in (CDEPS): Don't mention XM_CDEPS.
1488         (CLIBS): Don't mention NAT_CLIBS.
1489
1490 2018-07-09  Tom Tromey  <tom@tromey.com>
1491
1492         * Makefile.in (ADD_FILES, ADD_DEPS): Remove.
1493         (LIBGDB_OBS, clean mostlyclean): Update.
1494         (gdb$(EXEEXT), insight$(EXEEXT)): Update.
1495
1496 2018-07-09  Tom Tromey  <tom@tromey.com>
1497
1498         * Makefile.in (%.c: %.y): Use ECHO_YACC.
1499         (%.c: %.l): Use ECHO_LEX.  Just fail if flex not available.
1500         * silent-rules.mk (ECHO_YACC, ECHO_LEX): New variables.
1501
1502 2018-07-09  Tom Tromey  <tom@tromey.com>
1503
1504         * Makefile.in (ALLDEPFILES): Remove exec.c.
1505         (COMMON_OBS): Remove exec.o.
1506         (COMMON_SFILES): Add exec.c.
1507
1508 2018-07-09  Tom Tromey  <tom@tromey.com>
1509
1510         * Makefile.in (LINT, LINTFLAGS, LINTFILES, lint): Remove.
1511
1512 2018-07-09  Tom Tromey  <tom@tromey.com>
1513
1514         * Makefile.in (clean mostlyclean): Remove stamp-version.
1515         (version.c): Depend on stamp-version.
1516         (stamp-version): New rule, from version.c rule.
1517
1518 2018-07-09  Tom Tromey  <tom@tromey.com>
1519
1520         * Makefile.in (init.c): Depend on stamp-init.
1521         (stamp-init): New rule, from init.c rule.
1522         (clean mostlyclean): Remove stamp-init.
1523
1524 2018-07-09  Tom Tromey  <tom@tromey.com>
1525
1526         * Makefile.in (INIT_FILES): Remove CONFIG_SRCS,
1527         SUBDIR_GCC_COMPILE_SRCS.
1528
1529 2018-07-09  Tom Tromey  <tom@tromey.com>
1530
1531         * Makefile.in (init.c): Remove some unused sed rules.
1532
1533 2018-07-09  Tom Tromey  <tom@tromey.com>
1534
1535         * Makefile.in (TSOBS): Remove.
1536         (INIT_FILES): Update.
1537         (LIBGDB_OBS): Update.
1538         (COMMON_SFILES): Add inflow.c.
1539         (SFILES): Remove inflow.c.
1540
1541 2018-07-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
1542
1543         * contrib/gdb-add-index.sh ($dwarf5): New, use it.
1544
1545 2018-07-07  Simon Marchi  <simon.marchi@polymtl.ca>
1546
1547         * ia64-libunwind-tdep.c (get_reg_name, get_fpreg_name,
1548         get_saveloc_name, is_signal_frame_name, step_name,
1549         init_remote_name, create_addr_space_name,
1550         destroy_addr_space_name, search_unwind_table_name,
1551         find_dyn_list_name): Constify.
1552
1553 2018-07-05  Simon Marchi  <simon.marchi@polymtl.ca>
1554
1555         * darwin-nat.c (darwin_pthread_kill): New function.
1556         (darwin_resume_thread): Use darwin_pthread_kill.
1557
1558 2018-07-05  Tom de Vries  <tdevries@suse.de>
1559
1560         * macroexp.c (macro_buffer) <operator=>: New member function.
1561
1562 2018-07-04  Tom Tromey  <tom@tromey.com>
1563
1564         * darwin-nat.c (darwin_attach_pid): Use exit_inferior.
1565
1566 2018-07-04  Simon Marchi  <simon.marchi@polymtl.ca>
1567
1568         * common/common-defs.h (HAVE_USEFUL_SBRK): Define.
1569         * main.c: Use HAVE_USEFUL_SBRK instead of HAVE_SBRK.
1570         * maint.c: Likewise.
1571         * top.c: Likewise.
1572
1573 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
1574
1575         * NEWS: Create a new section for the next release branch.
1576         Rename the section of the current branch, now that it has
1577         been cut.
1578
1579 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
1580
1581         GDB 8.2 branch created (1b919490e8ba30bf1d6941df0ed112b0e557017e):
1582         * version.in: Bump version to 8.2.50.DATE-git.
1583
1584 2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
1585             Pedro Alves  <palves@redhat.com>
1586
1587         * linux-nat.c (linux_init_ptrace): Rename to ...
1588         (linux_init_ptrace_procfs): ... this.  Call
1589         linux_proc_init_warnings.
1590         (linux_nat_target::post_attach)
1591         (linux_nat_target::post_startup_inferior): Adjust.
1592         * nat/linux-procfs.c (linux_proc_init_warnings): Define function.
1593         * nat/linux-procfs.h (linux_proc_init_warnings): Declare function.
1594
1595 2018-07-04  Tom de Vries  <tdevries@suse.de>
1596
1597         * dwarf2read.c (error_check_comp_unit_head): Move dwarf version
1598         check ...
1599         (read_comp_unit_head): ... here.
1600
1601 2018-07-03  Tom Tromey  <tom@tromey.com>
1602
1603         * tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
1604         (stop_tracing, tstatus_command)
1605         (find_matching_tracepoint_location, merge_uploaded_tracepoints)
1606         (print_one_static_tracepoint_marker): Update.
1607         * breakpoint.c (static_tracepoints_here, all_tracepoints): Return
1608         std::vector.
1609         * breakpoint.h (breakpoint_p): Remove typedef.  Don't declare
1610         VEC.
1611         (all_tracepoints, static_tracepoints_here): Return std::vector.
1612
1613 2018-07-03  Tom Tromey  <tom@tromey.com>
1614
1615         * common/ptid.c (ptid_equal): Remove.
1616         * common/ptid.h (ptid_equal): Don't declare.
1617         * ada-tasks.c: Update.
1618         * breakpoint.c: Update.
1619         * common/agent.c: Update.
1620         * corelow.c: Update.
1621         * darwin-nat-info.c: Update.
1622         * darwin-nat.c: Update.
1623         * dcache.c: Update.
1624         * dtrace-probe.c: Update.
1625         * dummy-frame.c: Update.
1626         * fbsd-nat.c: Update.
1627         * frame.c: Update.
1628         * gdbthread.h: Update.
1629         * gnu-nat.c: Update.
1630         * go32-nat.c: Update.
1631         * inf-loop.c: Update.
1632         * inf-ptrace.c: Update.
1633         * infcall.c: Update.
1634         * infcmd.c: Update.
1635         * inflow.c: Update.
1636         * infrun.c: Update.
1637         * linux-fork.c: Update.
1638         * linux-nat.c: Update.
1639         * linux-thread-db.c: Update.
1640         * mi/mi-cmd-var.c: Update.
1641         * mi/mi-interp.c: Update.
1642         * mi/mi-main.c: Update.
1643         * nto-procfs.c: Update.
1644         * ppc-linux-tdep.c: Update.
1645         * procfs.c: Update.
1646         * python/py-inferior.c: Update.
1647         * python/py-record-btrace.c: Update.
1648         * python/py-record.c: Update.
1649         * ravenscar-thread.c: Update.
1650         * regcache.c: Update.
1651         * remote-sim.c: Update.
1652         * remote.c: Update.
1653         * sol-thread.c: Update.
1654         * solib.c: Update.
1655         * target.c: Update.
1656         * tui/tui-stack.c: Update.
1657         * varobj.c: Update.
1658         * windows-nat.c: Update.
1659         * windows-tdep.c: Update.
1660
1661 2018-07-03  Tom Tromey  <tom@tromey.com>
1662
1663         * common/ptid.c (ptid_match): Remove.
1664         * common/ptid.h (ptid_match): Don't declare.
1665         * fbsd-nat.c: Update.
1666         * infcmd.c: Update.
1667         * infrun.c: Update.
1668         * linux-nat.c: Update.
1669         * record-btrace.c: Update.
1670         * regcache.c: Update.
1671         * remote.c: Update.
1672
1673 2018-07-03  Tom Tromey  <tom@tromey.com>
1674
1675         * common/ptid.c (ptid_tid_p): Remove.
1676         * common/ptid.h (ptid_tid_p): Don't declare.
1677         * sol-thread.c: Update.
1678
1679 2018-07-03  Tom Tromey  <tom@tromey.com>
1680
1681         * common/ptid.c (ptid_lwp_p): Remove.
1682         * common/ptid.h (ptid_lwp_p): Don't declare.
1683         * fbsd-nat.c: Update.
1684         * linux-nat.c: Update.
1685         * nat/linux-procfs.c: Update.
1686         * nat/x86-linux-dregs.c: Update.
1687         * sol-thread.c: Update.
1688
1689 2018-07-03  Tom Tromey  <tom@tromey.com>
1690
1691         * common/ptid.c (ptid_is_pid): Remove.
1692         * common/ptid.h (ptid_is_pid): Don't declare.
1693         * infrun.c: Update.
1694         * linux-nat.c: Update.
1695         * mi/mi-interp.c: Update.
1696         * remote.c: Update.
1697         * thread.c: Update.
1698
1699 2018-07-03  Tom Tromey  <tom@tromey.com>
1700
1701         * common/ptid.c (ptid_get_tid): Remove.
1702         * common/ptid.h (ptid_get_tid): Don't declare.
1703         * ada-tasks.c: Update.
1704         * aix-thread.c: Update.
1705         * bsd-uthread.c: Update.
1706         * darwin-nat.c: Update.
1707         * fbsd-nat.c: Update.
1708         * i386-darwin-nat.c: Update.
1709         * infrun.c: Update.
1710         * linux-tdep.c: Update.
1711         * nto-procfs.c: Update.
1712         * ppc-ravenscar-thread.c: Update.
1713         * python/py-infthread.c: Update.
1714         * ravenscar-thread.c: Update.
1715         * sol-thread.c: Update.
1716         * sparc-ravenscar-thread.c: Update.
1717         * windows-nat.c: Update.
1718
1719 2018-07-03  Tom Tromey  <tom@tromey.com>
1720
1721         * common/ptid.c (ptid_get_lwp): Remove.
1722         * common/ptid.h (ptid_get_lwp): Don't declare.
1723         * aarch64-linux-nat.c: Update.
1724         * ada-tasks.c: Update.
1725         * aix-thread.c: Update.
1726         * amd64-linux-nat.c: Update.
1727         * arm-linux-nat.c: Update.
1728         * corelow.c: Update.
1729         * fbsd-nat.c: Update.
1730         * fbsd-tdep.c: Update.
1731         * gnu-nat.c: Update.
1732         * i386-cygwin-tdep.c: Update.
1733         * i386-gnu-nat.c: Update.
1734         * i386-linux-nat.c: Update.
1735         * ia64-linux-nat.c: Update.
1736         * inf-ptrace.c: Update.
1737         * infrun.c: Update.
1738         * linux-fork.c: Update.
1739         * linux-nat.c: Update.
1740         * linux-tdep.c: Update.
1741         * linux-thread-db.c: Update.
1742         * mips-linux-nat.c: Update.
1743         * nat/aarch64-linux-hw-point.c: Update.
1744         * nat/aarch64-linux.c: Update.
1745         * nat/linux-btrace.c: Update.
1746         * nat/linux-osdata.c: Update.
1747         * nat/linux-procfs.c: Update.
1748         * nat/x86-linux-dregs.c: Update.
1749         * obsd-nat.c: Update.
1750         * ppc-fbsd-nat.c: Update.
1751         * ppc-linux-nat.c: Update.
1752         * procfs.c: Update.
1753         * python/py-infthread.c: Update.
1754         * ravenscar-thread.c: Update.
1755         * remote.c: Update.
1756         * s390-linux-nat.c: Update.
1757         * sol-thread.c: Update.
1758         * sol2-tdep.c: Update.
1759         * spu-linux-nat.c: Update.
1760         * x86-linux-nat.c: Update.
1761         * xtensa-linux-nat.c: Update.
1762
1763 2018-07-03  Tom Tromey  <tom@tromey.com>
1764
1765         * common/ptid.c (ptid_get_pid): Remove.
1766         * common/ptid.h (ptid_get_pid): Don't declare.
1767         * aarch64-linux-nat.c: Update.
1768         * ada-lang.c: Update.
1769         * aix-thread.c: Update.
1770         * alpha-bsd-nat.c: Update.
1771         * amd64-fbsd-nat.c: Update.
1772         * amd64-linux-nat.c: Update.
1773         * arm-linux-nat.c: Update.
1774         * arm-nbsd-nat.c: Update.
1775         * auxv.c: Update.
1776         * break-catch-syscall.c: Update.
1777         * breakpoint.c: Update.
1778         * bsd-uthread.c: Update.
1779         * corelow.c: Update.
1780         * ctf.c: Update.
1781         * darwin-nat.c: Update.
1782         * fbsd-nat.c: Update.
1783         * fbsd-tdep.c: Update.
1784         * gcore.c: Update.
1785         * gnu-nat.c: Update.
1786         * hppa-nbsd-nat.c: Update.
1787         * hppa-obsd-nat.c: Update.
1788         * i386-fbsd-nat.c: Update.
1789         * ia64-linux-nat.c: Update.
1790         * inf-ptrace.c: Update.
1791         * infcmd.c: Update.
1792         * inferior.c: Update.
1793         * inferior.h: Update.
1794         * inflow.c: Update.
1795         * infrun.c: Update.
1796         * linux-fork.c: Update.
1797         * linux-nat.c: Update.
1798         * linux-tdep.c: Update.
1799         * linux-thread-db.c: Update.
1800         * m68k-bsd-nat.c: Update.
1801         * mi/mi-interp.c: Update.
1802         * mi/mi-main.c: Update.
1803         * mips-linux-nat.c: Update.
1804         * mips-nbsd-nat.c: Update.
1805         * mips64-obsd-nat.c: Update.
1806         * nat/aarch64-linux-hw-point.c: Update.
1807         * nat/aarch64-linux.c: Update.
1808         * nat/linux-btrace.c: Update.
1809         * nat/linux-osdata.c: Update.
1810         * nat/linux-procfs.c: Update.
1811         * nat/x86-linux-dregs.c: Update.
1812         * nto-procfs.c: Update.
1813         * obsd-nat.c: Update.
1814         * ppc-linux-nat.c: Update.
1815         * ppc-nbsd-nat.c: Update.
1816         * ppc-obsd-nat.c: Update.
1817         * proc-service.c: Update.
1818         * procfs.c: Update.
1819         * python/py-inferior.c: Update.
1820         * python/py-infthread.c: Update.
1821         * ravenscar-thread.c: Update.
1822         * record.c: Update.
1823         * remote-sim.c: Update.
1824         * remote.c: Update.
1825         * rs6000-nat.c: Update.
1826         * s390-linux-nat.c: Update.
1827         * sh-nbsd-nat.c: Update.
1828         * sol-thread.c: Update.
1829         * sparc-nat.c: Update.
1830         * sparc64-tdep.c: Update.
1831         * spu-linux-nat.c: Update.
1832         * spu-tdep.c: Update.
1833         * target-debug.h: Update.
1834         * target.c: Update.
1835         * thread.c: Update.
1836         * tid-parse.c: Update.
1837         * tracefile-tfile.c: Update.
1838         * vax-bsd-nat.c: Update.
1839         * windows-nat.c: Update.
1840         * x86-linux-nat.c: Update.
1841         * x86-nat.c: Update.
1842
1843 2018-07-03  Tom Tromey  <tom@tromey.com>
1844
1845         * common/ptid.c (pid_to_ptid): Remove.
1846         * common/ptid.h (pid_to_ptid): Don't declare.
1847         * aix-thread.c: Update.
1848         * arm-linux-nat.c: Update.
1849         * common/ptid.c: Update.
1850         * common/ptid.h: Update.
1851         * corelow.c: Update.
1852         * ctf.c: Update.
1853         * darwin-nat.c: Update.
1854         * fbsd-nat.c: Update.
1855         * fork-child.c: Update.
1856         * gnu-nat.c: Update.
1857         * go32-nat.c: Update.
1858         * inf-ptrace.c: Update.
1859         * infcmd.c: Update.
1860         * inferior.c: Update.
1861         * infrun.c: Update.
1862         * linux-fork.c: Update.
1863         * linux-nat.c: Update.
1864         * nat/aarch64-linux-hw-point.c: Update.
1865         * nat/fork-inferior.c: Update.
1866         * nat/x86-linux-dregs.c: Update.
1867         * nto-procfs.c: Update.
1868         * obsd-nat.c: Update.
1869         * procfs.c: Update.
1870         * progspace.c: Update.
1871         * remote.c: Update.
1872         * rs6000-nat.c: Update.
1873         * s390-linux-nat.c: Update.
1874         * sol-thread.c: Update.
1875         * spu-linux-nat.c: Update.
1876         * target.c: Update.
1877         * top.c: Update.
1878         * tracefile-tfile.c: Update.
1879         * windows-nat.c: Update.
1880
1881 2018-07-03  Tom Tromey  <tom@tromey.com>
1882
1883         * common/ptid.h (ptid_build): Don't declare.
1884         * common/ptid.c (ptid_build): Remove.
1885         * aix-thread.c: Update.
1886         * bsd-kvm.c: Update.
1887         * bsd-uthread.c: Update.
1888         * common/agent.c: Update.
1889         * common/ptid.c: Update.
1890         * common/ptid.h: Update.
1891         * corelow.c: Update.
1892         * darwin-nat.c: Update.
1893         * fbsd-nat.c: Update.
1894         * gnu-nat.c: Update.
1895         * linux-fork.c: Update.
1896         * linux-nat.c: Update.
1897         * linux-thread-db.c: Update.
1898         * nat/linux-osdata.c: Update.
1899         * nat/linux-procfs.c: Update.
1900         * nto-procfs.c: Update.
1901         * obsd-nat.c: Update.
1902         * proc-service.c: Update.
1903         * procfs.c: Update.
1904         * ravenscar-thread.c: Update.
1905         * remote-sim.c: Update.
1906         * remote.c: Update.
1907         * sol-thread.c: Update.
1908         * target.c: Update.
1909         * windows-nat.c: Update.
1910
1911 2018-07-03  Tom Tromey  <tom@tromey.com>
1912
1913         * infrun.c (follow_exec): Use exit_inferior_silent.
1914         * inferior.c (exit_inferior_num_silent): Remove.
1915         * inferior.h (exit_inferior_num_silent): Don't declare.
1916
1917 2018-07-03  Tom Tromey  <tom@tromey.com>
1918
1919         PR cli/23340:
1920         * darwin-nat.c (darwin_attach_pid): Reset inferior and
1921         inferior_ptid on error.
1922
1923 2018-07-02  Maciej W. Rozycki  <macro@mips.com>
1924             Simon Marchi  <simon.marchi@polymtl.ca>
1925
1926         PR tdep/8282
1927         * disasm.h (gdb_disassembler): Add
1928         `m_disassembler_options_holder'. member
1929         * disasm.c (get_all_disassembler_options): New function.
1930         (gdb_disassembler::gdb_disassembler): Use it.
1931         (gdb_buffered_insn_length_init_dis): Likewise.
1932         (gdb_buffered_insn_length): Adjust accordingly.
1933         (set_disassembler_options): Handle options with arguments.
1934         (show_disassembler_options_sfunc): Likewise.  Add a leading new
1935         line if showing options with descriptions.
1936         (disassembler_options_completer): Adapt to using the
1937         `disasm_options_and_args_t' structure.
1938         * mips-tdep.c (mips_disassembler_options): New variable.
1939         (mips_disassembler_options_o32): Likewise.
1940         (mips_disassembler_options_n32): Likewise.
1941         (mips_disassembler_options_n64): Likewise.
1942         (gdb_print_insn_mips): Don't set `disassembler_options'.
1943         (gdb_print_insn_mips_n32, gdb_print_insn_mips_n64): Remove
1944         functions.
1945         (mips_gdbarch_init): Always set `gdbarch_print_insn' to
1946         `gdb_print_insn_mips'.  Set `gdbarch_disassembler_options',
1947         `gdbarch_disassembler_options_implicit' and
1948         `gdbarch_valid_disassembler_options'.
1949         * arm-tdep.c (_initialize_arm_tdep): Adapt to using the
1950         `disasm_options_and_args_t' structure.
1951         * gdbarch.sh (disassembler_options_implicit): New `gdbarch'
1952         method.
1953         (valid_disassembler_options): Switch from `disasm_options_t' to
1954         the `disasm_options_and_args_t' structure.
1955         * NEWS: Document `set disassembler-options' support for the MIPS
1956         target.
1957         * gdbarch.h: Regenerate.
1958         * gdbarch.c: Regenerate.
1959
1960 2018-07-02  Sebastian Huber  <sebastian.huber@embedded-brains.de>
1961
1962         * riscv-tdep.c (riscv_register_aliases): Swap "fp" and "s0" entries.
1963
1964 2018-06-29  Joel Brobecker  <brobecker@adacore.com>
1965
1966         * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
1967         parameter in call to amd64_target_description.
1968         * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
1969         * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
1970         (amd64fbsd_init_abi): Likewise.
1971         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1972         * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
1973         * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
1974         * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
1975
1976 2018-06-29  Pedro Alves  <palves@redhat.com>
1977
1978         * gdb/amd64-tdep.h (amd64_create_target_description): Add
1979         "segments" parameter.
1980         * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
1981         (_initialize_amd64_tdep): Update call to
1982         amd64_create_target_description.
1983         (amd64_target_description): Add "segments" parameter.  Adjust
1984         the implementation to use it.
1985         * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
1986         call to amd64_create_target_description.
1987         * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
1988         * gdb/arch/amd64.h (amd64_create_target_description): Add
1989         "segments" register.
1990         * gdb/arch/amd64.c (amd64_create_target_description): Add
1991         "segments" parameter.  Call create_feature_i386_64bit_segments
1992         only if SEGMENTS is true.
1993         * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
1994         call to amd64_create_target_description.
1995
1996 2018-06-29  Pedro Alves  <palves@redhat.com>
1997
1998         * thread.c (thread_target_id_str): New, factored out from ...
1999         (print_thread_info_1): ... here.  Use it to compute the max
2000         "Target Id" column width.
2001
2002 2018-06-29  Pedro Alves  <palves@redhat.com>
2003
2004         * remote.c (remote_target::extra_thread_info): Delete
2005         'display_buf' and 'n' locals.  from the cache, regardless of
2006         packet mechanims is in use.  Use cache for qThreadExtra and qP
2007         methods too.
2008
2009 2018-06-29  Pedro Alves  <palves@redhat.com>
2010
2011         * blockframe.c (find_pc_sect_containing_function): New function.
2012         * breakpoint.c (print_breakpoint_location): Don't call
2013         find_pc_sect_function.
2014         * linespec.c (create_sals_line_offset): Record the location's
2015         symbol in the sal.
2016         * linespec.c (convert_address_location_to_sals): Fill in sal's
2017         symbol with find_pc_sect_containing_function.
2018         * symtab.c (find_function_start_sal): Rename to ...
2019         (find_function_start_sal_1): ... this.
2020         (find_function_start_sal): Reimplement as wrapper around
2021         find_function_start_sal_1, and use
2022         find_pc_sect_containing_function to fill in the sal's symbol.
2023         (find_function_start_sal(symbol*, bool)): Adjust.
2024         * symtab.h (find_pc_function, find_pc_sect_function): Adjust
2025         comments.
2026         (find_pc_sect_containing_function): Declare.
2027
2028 2018-06-29  Pedro Alves  <palves@redhat.com>
2029
2030         * inline-frame.c (stopped_by_user_bp_inline_frame): Return
2031         true if the the location has no symbol.
2032
2033 2018-06-28  Tom Tromey  <tom@tromey.com>
2034
2035         * NEWS: Mention --enable-codesign.
2036         * silent-rules.mk (ECHO_SIGN): New variable.
2037         * configure.ac: Add --enable-codesign.
2038         * configure: Rebuild.
2039         * Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
2040         (gdb$(EXEEXT)): Optionally invoke codesign.
2041
2042 2018-06-28  Pedro Alves  <palves@redhat.com>
2043
2044         * gdbthread.h (struct thread_suspend_state) <stop_pc>: Extend
2045         comments.
2046         (switch_to_thread_no_regs): Adjust comment.
2047         * infcmd.c (stop_pc): Delete.
2048         (post_create_inferior, info_program_command): Replace references
2049         to stop_pc with references to thread_info->suspend.stop_pc.
2050         * inferior.h (stop_pc): Delete declaration.
2051         * infrun.c (proceed, handle_syscall_event, fill_in_stop_func)
2052         (handle_inferior_event_1, handle_signal_stop)
2053         (process_event_stop_test, keep_going_stepped_thread)
2054         (handle_step_into_function, handle_step_into_function_backward)
2055         (print_stop_location): Replace references to stop_pc with
2056         references to thread_info->suspend.stop_pc.
2057         (struct infcall_suspend_state) <stop_pc>: Delete field.
2058         (save_infcall_suspend_state, restore_infcall_suspend_state):
2059         Remove references to inf_stat->stop_pc.
2060         * linux-fork.c (fork_load_infrun_state): Likewise.
2061         * record-btrace.c (record_btrace_set_replay): Likewise.
2062         * record-full.c (record_full_goto_entry): Likewise.
2063         * remote.c (print_one_stopped_thread): Likewise.
2064         * target.c (target_resume): Extend comment.
2065         * thread.c (set_executing_thread): New.
2066         (set_executing): Use it.
2067         (switch_to_thread_no_regs, switch_to_no_thread, switch_to_thread):
2068         Remove references to stop_pc.
2069
2070 2018-06-28  Pedro Alves  <palves@redhat.com>
2071
2072         * infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>:
2073         Moving fetching stop_pc until after ecs->event_thread is refreshed.
2074
2075 2018-06-28  Tom Tromey  <tom@tromey.com>
2076
2077         * coffread.c (coff_symfile_finish): Update.
2078         * xcoffread.c (xcoff_symfile_finish): Update.
2079         * elfread.c (elf_symfile_finish): Update.
2080         * symfile.h (dwarf2_free_objfile): Don't declare.
2081         * dwarf2read.c (_initialize_dwarf2_read): Use
2082         register_objfile_data_with_cleanup.
2083         (dwarf2_free_objfile): Now static.  Change signature.
2084
2085 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2086
2087         * symfile.c (add_symbol_file_command, _initialize_symfile): Add
2088         option "-o" to add-symbol-file-load to add an offset to each
2089         section's load address.
2090         * symfile.c (set_objfile_default_section_offset): New function.
2091
2092 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2093
2094         * symfile.c (add_symbol_file_command): Make sure that sections
2095         with the same name are sorted in the same order.
2096
2097 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2098
2099         * symfile.c (add_symbol_file_command, _initialize_symfile): Do not
2100         require the second argument.  If omitted, load sections at the
2101         addresses specified in the file.
2102
2103 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2104
2105         * symfile.c (symbol_file_command, symbol_file_add_main_1)
2106         (_initialize_symfile): Add option "-o" to symbol-file to add an
2107         offset to each section of the symbol file.
2108
2109 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2110
2111         * MAINTAINERS (Write After Approval): Add Petr Tesarik.
2112
2113 2018-06-27  Tom Tromey  <tom@tromey.com>
2114
2115         * stack.c (_initialize_stack): Update "func" help text.
2116
2117 2018-06-27  Tom Tromey  <tom@tromey.com>
2118
2119         * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
2120         std::vector.
2121         (unwind_infopy_str, pyuw_create_unwind_info)
2122         (unwind_infopy_add_saved_register, pyuw_sniffer)
2123         (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
2124         Update.
2125         (struct saved_reg): Add constructor.
2126         <value>: Now a gdbpy_ref<>.
2127
2128 2018-06-27  Tom Tromey  <tom@tromey.com>
2129
2130         * machoread.c (macho_symfile_read): Define "symbol_table" earlier.
2131
2132 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2133
2134         * gdb-gdb.py.in: Format using autopep8.
2135
2136 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2137
2138         * gdb-gdb.py.in (CoreAddrPrettyPrinter): New class.
2139         (type_lookup_function): Recognize CORE_ADDR values.
2140
2141 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2142
2143         * gdb-gdb.py.in (StructMainTypePrettyPrinter) <to_string>: Don't
2144         print tag_name.
2145
2146 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2147
2148         * gdb-gdb.py.in (TypeFlag) <__cmp__>: Remove.
2149         <__lt__>: Add.
2150
2151 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2152
2153         * gdb-gdb.py: Move to...
2154         * gdb-gdb.py.in: ... here.
2155         * configure.ac (AC_CONFIG_FILES): Add gdb-gdb.py.
2156         * Makefile.in (all): Add gdb-gdb.gdb and gdb-gdb.py as
2157         dependencies.
2158         (distclean): Remove gdb-gdb.py when cleaning.
2159         (gdb-gdb.py, gdb-gdb.gdb): New rules.
2160         * configure: Re-generate.
2161
2162 2018-06-27  Pedro Alves  <palves@redhat.com>
2163
2164         * proc-service.c (get_ps_regcache): New.
2165         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs)
2166         (ps_lsetfpregs): Use it.
2167
2168 2018-06-27  Omair Javaid  <omair.javaid@linaro.org>
2169
2170         PR gdb/21695
2171         * dwarf2read.c (lnp_state_machine::check_line_address): Update declaration.
2172         (dwarf_decode_lines_1): Adjust.
2173
2174 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2175
2176         * fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
2177         override.
2178         <info_proc>: Likewise.
2179
2180 2018-06-26  Joel Brobecker  <brobecker@adacore.com>
2181
2182         * windows-nat.c (do_windows_fetch_inferior_registers): Rename
2183         to windows_fetch_one_register, and only handle the case of
2184         fetching one register.  Move the code that reloads the context
2185         and iterates over all registers if R is negative to...
2186         (windows_nat_target::fetch_registers): ... here.
2187         (do_windows_store_inferior_registers): Rename to
2188         windows_store_one_register, and only handle the case of storing
2189         one register.  Move the code that handles the case where r is
2190         negative to...
2191         (windows_nat_target::store_registers) ... here.
2192
2193 2018-06-26  Tom Tromey  <tom@tromey.com>
2194
2195         PR rust/22574:
2196         * typeprint.c (whatis_exp): Allow ptype/o for Rust.
2197         * rust-lang.c (rust_print_struct_def): Add podata parameter.
2198         Update.
2199         (rust_internal_print_type): Add podata parameter.
2200         (rust_print_type): Update.
2201
2202 2018-06-26  Tom Tromey  <tom@tromey.com>
2203
2204         * typeprint.h (struct print_offset_data) <update, finish,
2205         maybe_print_hole>: New methods.
2206         <indentation>: New constant.
2207         * typeprint.c (print_offset_data::indentation): Define.
2208         (print_offset_data::maybe_print_hole, print_offset_data::update)
2209         (print_offset_data::finish): Move from c-typeprint.c and rename.
2210         * c-typeprint.c (OFFSET_SPC_LEN): Remove.
2211         (print_spaces_filtered_with_print_options): Update.
2212         (c_print_type_union_field_offset, maybe_print_hole)
2213         (c_print_type_struct_field_offset): Move to typeprint.c and
2214         rename.
2215         (c_type_print_base_struct_union): Update.
2216
2217 2018-06-25  Pedro Alves  <palves@redhat.com>
2218
2219         * gdbthread.h (thread_info_ref, delete_thread)
2220         (delete_thread_silent, first_thread_of_inferior)
2221         (any_thread_of_inferior, switch_to_thread)
2222         (enable_thread_stack_temporaries)
2223         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2224         (get_last_thread_stack_temporary)
2225         (value_in_thread_stack_temporaries, can_access_registers_thread):
2226         Spell out "struct thread_info" instead of just "thread_info".
2227         * inferior.h (notice_new_inferior): Likewise.
2228
2229 2018-06-25  Pedro Alves  <palves@redhat.com>
2230
2231         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
2232         pass thread_info pointer to delete_thread.
2233         (windows_nat_target::detach): Pass inferior pointer to
2234         detach_inferior.
2235         * aix-thread.c (sync_threadlists): Pass thread_info pointer to
2236         delete_thread.
2237         * bsd-kvm.c (bsd_kvm_target::close): Use discard_all_inferiors.
2238         * darwin-nat.c (darwin_check_new_threads): Use find_thread_ptid
2239         and pass a thread_info pointer to delete_thread.
2240         * fbsd-nat.c (fbsd_nat_target::wait): Use find_thread_ptid and
2241         pass thread_info pointer to delete_thread.
2242         * go32-nat.c (go32_nat_target::mourn_inferior): Remove
2243         delete_thread_silent call.
2244         * procfs.c (procfs_target::detach): Pass inferior pointer to
2245         detach_inferior.
2246         (procfs_target::wait): Pass thread_info pointer to delete_thread.
2247         * remote-sim.c (gdbsim_target::mourn_inferior): Remove
2248         delete_thread_silent call.
2249         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
2250         pass thread_info pointer to delete_thread.
2251         (windows_nat_target::detach): Pass inferior pointer to
2252         delete_inferior.
2253
2254 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
2255
2256         * regcache.c (readable_regcache::read_part): Fix asserts.
2257         (reg_buffer::raw_collect_part): New function.
2258         (regcache::write_part): Fix asserts.
2259         (reg_buffer::raw_supply_part): New function.
2260         (regcache::transfer_regset_register): New helper function.
2261         (regcache::transfer_regset): Call new functions.
2262         (regcache_supply_regset): Use gdb_byte*.
2263         (regcache::supply_regset): Likewise.
2264         (regcache_collect_regset): Likewise.
2265         (regcache::collect_regset): Likewise.
2266         * regcache.h (reg_buffer::raw_collect_part): New declaration.
2267         (reg_buffer::raw_supply_part): Likewise.
2268         (regcache::transfer_regset_register): Likewise.
2269         (regcache::transfer_regset): Use gdb_byte*.
2270
2271 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * nat/aarch64-sve-linux-ptrace.h (HAS_SVE_STATE): Use &.
2274
2275 2018-06-21  Pedro Alves  <palves@redhat.com>
2276
2277         * ada-lang.h (ada_get_task_number): Take a thread_info pointer
2278         instead of a ptid_t.  All callers adjusted.
2279         * ada-tasks.c (ada_get_task_number): Likewise.  All callers
2280         adjusted.
2281         (print_ada_task_info, display_current_task_id, task_command_1):
2282         Adjust.
2283         * breakpoint.c (watchpoint_in_thread_scope): Adjust to use
2284         inferior_thread.
2285         (breakpoint_kind): Adjust.
2286         (remove_breakpoints_pid): Rename to ...
2287         (remove_breakpoints_inf): ... this.  Adjust to take an inferior
2288         pointer.  All callers adjusted.
2289         (bpstat_clear_actions): Use inferior_thread.
2290         (get_bpstat_thread): New.
2291         (bpstat_do_actions): Use it.
2292         (bpstat_check_breakpoint_conditions, bpstat_stop_status): Adjust
2293         to take a thread_info pointer.  All callers adjusted.
2294         (set_longjmp_breakpoint_for_call_dummy, set_momentary_breakpoint)
2295         (breakpoint_re_set_thread): Use inferior_thread.
2296         * breakpoint.h (struct inferior): Forward declare.
2297         (bpstat_stop_status): Update.
2298         (remove_breakpoints_pid): Delete.
2299         (remove_breakpoints_inf): New.
2300         * bsd-uthread.c (bsd_uthread_target::wait)
2301         (bsd_uthread_target::update_thread_list): Use find_thread_ptid.
2302         * btrace.c (btrace_add_pc, btrace_enable, btrace_fetch)
2303         (maint_btrace_packet_history_cmd)
2304         (maint_btrace_clear_packet_history_cmd): Adjust.
2305         (maint_btrace_clear_cmd, maint_info_btrace_cmd): Adjust to use
2306         inferior_thread.
2307         * cli/cli-interp.c: Include "inferior.h".
2308         * common/refcounted-object.h (struct
2309         refcounted_object_ref_policy): New.
2310         * compile/compile-object-load.c: Include gdbthread.h.
2311         (store_regs): Use inferior_thread.
2312         * corelow.c (core_target::close): Use current_inferior.
2313         (core_target_open): Adjust to use first_thread_of_inferior and use
2314         the current inferior.
2315         * ctf.c (ctf_target::close): Adjust to use current_inferior.
2316         * dummy-frame.c (dummy_frame_id) <ptid>: Delete, replaced by ...
2317         <thread>: ... this new field.  All references adjusted.
2318         (dummy_frame_pop, dummy_frame_discard, register_dummy_frame_dtor):
2319         Take a thread_info pointer instead of a ptid_t.
2320         * dummy-frame.h (dummy_frame_push, dummy_frame_pop)
2321         (dummy_frame_discard, register_dummy_frame_dtor): Take a
2322         thread_info pointer instead of a ptid_t.
2323         * elfread.c: Include "inferior.h".
2324         (elf_gnu_ifunc_resolver_stop, elf_gnu_ifunc_resolver_return_stop):
2325         Use inferior_thread.
2326         * eval.c (evaluate_subexp): Likewise.
2327         * frame.c (frame_pop, has_stack_frames, find_frame_sal): Use
2328         inferior_thread.
2329         * gdb_proc_service.h (struct thread_info): Forward declare.
2330         (struct ps_prochandle) <ptid>: Delete, replaced by ...
2331         <thread>: ... this new field.  All references adjusted.
2332         * gdbarch.h, gdbarch.c: Regenerate.
2333         * gdbarch.sh (get_syscall_number): Replace 'ptid' parameter with a
2334         'thread' parameter.  All implementations and callers adjusted.
2335         * gdbthread.h (thread_info) <set_running>: New method.
2336         (delete_thread, delete_thread_silent): Take a thread_info pointer
2337         instead of a ptid.
2338         (global_thread_id_to_ptid, ptid_to_global_thread_id): Delete.
2339         (first_thread_of_process): Delete, replaced by ...
2340         (first_thread_of_inferior): ... this new function.  All callers
2341         adjusted.
2342         (any_live_thread_of_process): Delete, replaced by ...
2343         (any_live_thread_of_inferior): ... this new function.  All callers
2344         adjusted.
2345         (switch_to_thread, switch_to_no_thread): Declare.
2346         (is_executing): Delete.
2347         (enable_thread_stack_temporaries): Update comment.
2348         <enable_thread_stack_temporaries>: Take a thread_info pointer
2349         instead of a ptid_t.  Incref the thread.
2350         <~enable_thread_stack_temporaries>: Decref the thread.
2351         <m_ptid>: Delete
2352         <m_thr>: New.
2353         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2354         (get_last_thread_stack_temporary)
2355         (value_in_thread_stack_temporaries, can_access_registers_thread):
2356         Take a thread_info pointer instead of a ptid_t.  All callers
2357         adjusted.
2358         * infcall.c (get_call_return_value): Use inferior_thread.
2359         (run_inferior_call): Work with thread pointers instead of ptid_t.
2360         (call_function_by_hand_dummy): Work with thread pointers instead
2361         of ptid_t.  Use thread_info_ref.
2362         * infcmd.c (proceed_thread_callback): Access thread's state
2363         directly.
2364         (ensure_valid_thread, ensure_not_running): Use inferior_thread,
2365         access thread's state directly.
2366         (continue_command): Use inferior_thread.
2367         (info_program_command): Use find_thread_ptid and access thread
2368         state directly.
2369         (proceed_after_attach_callback): Use thread state directly.
2370         (notice_new_inferior): Take a thread_info pointer instead of a
2371         ptid_t.  All callers adjusted.
2372         (exit_inferior): Take an inferior pointer instead of a pid.  All
2373         callers adjusted.
2374         (exit_inferior_silent): New.
2375         (detach_inferior): Delete.
2376         (valid_gdb_inferior_id, pid_to_gdb_inferior_id)
2377         (gdb_inferior_id_to_pid, in_inferior_list): Delete.
2378         (detach_inferior_command, kill_inferior_command): Use
2379         find_inferior_id instead of valid_gdb_inferior_id and
2380         gdb_inferior_id_to_pid.
2381         (inferior_command): Use inferior and thread pointers.
2382         * inferior.h (struct thread_info): Forward declare.
2383         (notice_new_inferior): Take a thread_info pointer instead of a
2384         ptid_t.  All callers adjusted.
2385         (detach_inferior): Delete declaration.
2386         (exit_inferior, exit_inferior_silent): Take an inferior pointer
2387         instead of a pid.  All callers adjusted.
2388         (gdb_inferior_id_to_pid, pid_to_gdb_inferior_id, in_inferior_list)
2389         (valid_gdb_inferior_id): Delete.
2390         * infrun.c (follow_fork_inferior, proceed_after_vfork_done)
2391         (handle_vfork_child_exec_or_exit, follow_exec): Adjust.
2392         (struct displaced_step_inferior_state) <pid>: Delete, replaced by
2393         ...
2394         <inf>: ... this new field.
2395         <step_ptid>: Delete, replaced by ...
2396         <step_thread>: ... this new field.
2397         (get_displaced_stepping_state): Take an inferior pointer instead
2398         of a pid.  All callers adjusted.
2399         (displaced_step_in_progress_any_inferior): Adjust.
2400         (displaced_step_in_progress_thread): Take a thread pointer instead
2401         of a ptid_t.  All callers adjusted.
2402         (displaced_step_in_progress, add_displaced_stepping_state): Take
2403         an inferior pointer instead of a pid.  All callers adjusted.
2404         (get_displaced_step_closure_by_addr): Adjust.
2405         (remove_displaced_stepping_state): Take an inferior pointer
2406         instead of a pid.  All callers adjusted.
2407         (displaced_step_prepare_throw, displaced_step_prepare)
2408         (displaced_step_fixup): Take a thread pointer instead of a ptid_t.
2409         All callers adjusted.
2410         (start_step_over): Adjust.
2411         (infrun_thread_ptid_changed): Remove bit updating ptids in the
2412         displaced step queue.
2413         (do_target_resume): Adjust.
2414         (fetch_inferior_event): Use inferior_thread.
2415         (context_switch, get_inferior_stop_soon): Take an
2416         execution_control_state pointer instead of a ptid_t.  All callers
2417         adjusted.
2418         (switch_to_thread_cleanup): Delete.
2419         (stop_all_threads): Use scoped_restore_current_thread.
2420         * inline-frame.c: Include "gdbthread.h".
2421         (inline_state) <inline_state>: Take a thread pointer instead of a
2422         ptid_t.  All callers adjusted.
2423         <ptid>: Delete, replaced by ...
2424         <thread>: ... this new field.
2425         (find_inline_frame_state): Take a thread pointer instead of a
2426         ptid_t.  All callers adjusted.
2427         (skip_inline_frames, step_into_inline_frame)
2428         (inline_skipped_frames, inline_skipped_symbol): Take a thread
2429         pointer instead of a ptid_t.  All callers adjusted.
2430         * inline-frame.h (skip_inline_frames, step_into_inline_frame)
2431         (inline_skipped_frames, inline_skipped_symbol): Likewise.
2432         * linux-fork.c (delete_checkpoint_command): Adjust to use thread
2433         pointers directly.
2434         * linux-nat.c (get_detach_signal): Likewise.
2435         * linux-thread-db.c (thread_from_lwp): New 'stopped' parameter.
2436         (thread_db_notice_clone): Adjust.
2437         (thread_db_find_new_threads_silently)
2438         (thread_db_find_new_threads_2, thread_db_find_new_threads_1): Take
2439         a thread pointer instead of a ptid_t.  All callers adjusted.
2440         * mi/mi-cmd-var.c: Include "inferior.h".
2441         (mi_cmd_var_update_iter): Update to use thread pointers.
2442         * mi/mi-interp.c (mi_new_thread): Update to use the thread's
2443         inferior directly.
2444         (mi_output_running_pid, mi_inferior_count): Delete, bits factored
2445         out to ...
2446         (mi_output_running): ... this new function.
2447         (mi_on_resume_1): Adjust to use it.
2448         (mi_user_selected_context_changed): Adjust to use inferior_thread.
2449         * mi/mi-main.c (proceed_thread): Adjust to use thread pointers
2450         directly.
2451         (interrupt_thread_callback): : Adjust to use thread and inferior
2452         pointers.
2453         * proc-service.c: Include "gdbthread.h".
2454         (ps_pglobal_lookup): Adjust to use the thread's inferior directly.
2455         * progspace-and-thread.c: Include "inferior.h".
2456         * progspace.c: Include "inferior.h".
2457         * python/py-exitedevent.c (create_exited_event_object): Adjust to
2458         hold a reference to an inferior_object.
2459         * python/py-finishbreakpoint.c (bpfinishpy_init): Adjust to use
2460         inferior_thread.
2461         * python/py-inferior.c (struct inferior_object): Give the type a
2462         tag name instead of a typedef.
2463         (python_on_normal_stop): No need to check if the current thread is
2464         listed.
2465         (inferior_to_inferior_object): Change return type to
2466         inferior_object.  All callers adjusted.
2467         (find_thread_object): Delete, bits factored out to ...
2468         (thread_to_thread_object): ... this new function.
2469         * python/py-infthread.c (create_thread_object): Use
2470         inferior_to_inferior_object.
2471         (thpy_is_stopped): Use thread pointer directly.
2472         (gdbpy_selected_thread): Use inferior_thread.
2473         * python/py-record-btrace.c (btpy_list_object) <ptid>: Delete
2474         field, replaced with ...
2475         <thread>: ... this new field.  All users adjusted.
2476         (btpy_insn_or_gap_new): Drop const.
2477         (btpy_list_new): Take a thread pointer instead of a ptid_t.  All
2478         callers adjusted.
2479         * python/py-record.c: Include "gdbthread.h".
2480         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
2481         a ptid_t.  All callers adjusted.
2482         (gdbpy_current_recording): Use inferior_thread.
2483         * python/py-record.h (recpy_record_object) <ptid>: Delete
2484         field, replaced with ...
2485         <thread>: ... this new field.  All users adjusted.
2486         (recpy_element_object) <ptid>: Delete
2487         field, replaced with ...
2488         <thread>: ... this new field.  All users adjusted.
2489         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
2490         a ptid_t.  All callers adjusted.
2491         * python/py-threadevent.c: Include "gdbthread.h".
2492         (get_event_thread): Use thread_to_thread_object.
2493         * python/python-internal.h (struct inferior_object): Forward
2494         declare.
2495         (find_thread_object, find_inferior_object): Delete declarations.
2496         (thread_to_thread_object, inferior_to_inferior_object): New
2497         declarations.
2498         * record-btrace.c: Include "inferior.h".
2499         (require_btrace_thread): Use inferior_thread.
2500         (record_btrace_frame_sniffer)
2501         (record_btrace_tailcall_frame_sniffer): Use inferior_thread.
2502         (get_thread_current_frame): Use scoped_restore_current_thread and
2503         switch_to_thread.
2504         (get_thread_current_frame): Use thread pointer directly.
2505         (record_btrace_replay_at_breakpoint): Use thread's inferior
2506         pointer directly.
2507         * record-full.c: Include "inferior.h".
2508         * regcache.c: Include "gdbthread.h".
2509         (get_thread_arch_regcache): Use the inferior's address space
2510         directly.
2511         (get_thread_regcache, registers_changed_thread): New.
2512         * regcache.h (get_thread_regcache(thread_info *thread)): New
2513         overload.
2514         (registers_changed_thread): New.
2515         (remote_target) <remote_detach_1>: Swap order of parameters.
2516         (remote_add_thread): <remote_add_thread>: Return the new thread.
2517         (get_remote_thread_info(ptid_t)): New overload.
2518         (remote_target::remote_notice_new_inferior): Use thread pointers
2519         directly.
2520         (remote_target::process_initial_stop_replies): Use
2521         thread_info::set_running.
2522         (remote_target::remote_detach_1, remote_target::detach)
2523         (extended_remote_target::detach): Adjust.
2524         * stack.c (frame_show_address): Use inferior_thread.
2525         * target-debug.h (target_debug_print_thread_info_pp): New.
2526         * target-delegates.c: Regenerate.
2527         * target.c (default_thread_address_space): Delete.
2528         (memory_xfer_partial_1): Use current_inferior.
2529         (target_detach): Use current_inferior.
2530         (target_thread_address_space): Delete.
2531         (generic_mourn_inferior): Use current_inferior.
2532         * target.h (struct target_ops) <thread_address_space>: Delete.
2533         (target_thread_address_space): Delete.
2534         * thread.c (init_thread_list): Use ALL_THREADS_SAFE.  Use thread
2535         pointers directly.
2536         (delete_thread_1, delete_thread, delete_thread_silent): Take a
2537         thread pointer instead of a ptid_t.  Adjust all callers.
2538         (ptid_to_global_thread_id, global_thread_id_to_ptid): Delete.
2539         (first_thread_of_process): Delete, replaced by ...
2540         (first_thread_of_inferior): ... this new function.  All callers
2541         adjusted.
2542         (any_thread_of_process): Rename to ...
2543         (any_thread_of_inferior): ... this, and take an inferior pointer.
2544         (any_live_thread_of_process): Rename to ...
2545         (any_live_thread_of_inferior): ... this, and take an inferior
2546         pointer.
2547         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2548         (value_in_thread_stack_temporaries)
2549         (get_last_thread_stack_temporary): Take a thread pointer instead
2550         of a ptid_t.  Adjust all callers.
2551         (thread_info::set_running): New.
2552         (validate_registers_access): Use inferior_thread.
2553         (can_access_registers_ptid): Rename to ...
2554         (can_access_registers_thread): ... this, and take a thread
2555         pointer.
2556         (print_thread_info_1): Adjust to compare thread pointers instead
2557         of ptids.
2558         (switch_to_no_thread, switch_to_thread): Make extern.
2559         (scoped_restore_current_thread::~scoped_restore_current_thread):
2560         Use m_thread pointer directly.
2561         (scoped_restore_current_thread::scoped_restore_current_thread):
2562         Use inferior_thread.
2563         (thread_command): Use thread pointer directly.
2564         (thread_num_make_value_helper): Use inferior_thread.
2565         * top.c (execute_command): Use inferior_thread.
2566         * tui/tui-interp.c: Include "inferior.h".
2567         * varobj.c (varobj_create): Use inferior_thread.
2568         (value_of_root_1): Use find_thread_global_id instead of
2569         global_thread_id_to_ptid.
2570
2571 2018-06-21  Alan Hayward  <alan.hayward@arm.com>
2572
2573         * regcache.c (readable_regcache::read_part): Avoid memcpy when
2574         possible.
2575         (regcache::write_part): Likewise.
2576         (readable_regcache::cooked_read_part): Update comment.
2577         (readable_regcache::cooked_write_part): Likewise.
2578         * regcache.h: (readable_regcache::read_part): Likewise.
2579         (regcache::write_part): Likewise.
2580
2581 2018-06-21  Richard Bunt  <richard.bunt@arm.com>
2582             Dirk Schubert  <dirk.schubert@arm.com>
2583
2584         * aarch64-linux-nat.c (post_attach): New.
2585         (aarch64_linux_nat_target::post_attach): Override post_attach to
2586         record the number of hardware debug registers.
2587
2588 2018-06-20  Tom Tromey  <tom@tromey.com>
2589
2590         * python/py-param.c (add_setshow_generic): Make parameters const.
2591         (parmpy_init): Update.
2592
2593 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
2594
2595         * regcache.h (regcache_cooked_read_ftype): Rename to...
2596         (register_read_ftype): ...this, change type to function_view.
2597         (class reg_buffer) <save>: Remove src parameter.
2598         (readonly_detached_regcache) <readonly_detached_regcache>: Make
2599         parameter non-const in first overload.  Remove src parameter in
2600         second overload.
2601         * regcache.c (do_cooked_read): Remove.
2602         (readonly_detached_regcache::readonly_detached_regcache): Make
2603         parameter non-const, adjust call to other constructor.
2604         (reg_buffer::save): Remove src parameter.
2605         * frame.c (do_frame_register_read): Remove.
2606         (frame_save_as_regcache): Use lambda function.
2607         * ppc-linux-tdep.c (ppu2spu_unwind_register): Change type of src
2608         parameter to ppu2spu_data *.
2609         (ppu2spu_sniffer): Use lambda function.
2610
2611 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
2612
2613         * record-full.c (record_full_target::insert_breakpoint): Remove
2614         "struct" keyword, add const.
2615
2616 2018-06-19  Simon Marchi  <simon.marchi@ericsson.com>
2617
2618         * common/common-defs.h (PACKAGE_NAME, PACKAGE_VERSION,
2619         PACKAGE_STRING, PACKAGE_TARNAME): Undefine.
2620         * configure.ac: Remove AC_PREREQ, add missing quoting.
2621         * gnulib/configure.ac: Modernize usage of
2622         AC_INIT/AM_INIT_AUTOMAKE.  Remove AC_PREREQ.
2623         * gnulib/update-gnulib.sh (AUTOCONF_VERSION): Bump to 2.69.
2624         (AUTOMAKE_VERSION): Bump to 1.15.1.
2625         * configure: Re-generate.
2626         * config.in: Re-generate.
2627         * aclocal.m4: Re-generate.
2628         * gnulib/aclocal.m4: Re-generate.
2629         * gnulib/config.in: Re-generate.
2630         * gnulib/configure: Re-generate.
2631         * gnulib/import/Makefile.in: Re-generate.
2632
2633 2018-06-19  Pedro Alves  <palves@redhat.com>
2634
2635         * minsyms.c (msym_prefer_to_msym_type): New, factored out from ...
2636         (lookup_minimal_symbol_by_pc_section): ... here with
2637         gdb_assert_not_reached added.
2638
2639 2018-06-19  Pedro Alves  <palves@redhat.com>
2640
2641         * inline-frame.c (stopped_by_user_bp_inline_frame): Replace PC
2642         parameter with a block parameter.  Compare location's block symbol
2643         with the frame's block instead of addresses.
2644         (skip_inline_frames): Pass the current block instead of the
2645         frame's address.  Break out as soon as we determine the frame
2646         should not be skipped.
2647
2648 2018-06-18  Tom Tromey  <tom@tromey.com>
2649
2650         * solib-aix.c (solib_aix_get_section_offsets): Return
2651         unique_xmalloc_ptr.
2652         (solib_aix_solib_create_inferior_hook): Update.
2653
2654 2018-06-18  Tom Tromey  <tom@tromey.com>
2655
2656         * solib-darwin.c (darwin_current_sos): Use unique_xmalloc_ptr.
2657
2658 2018-06-18  Tom Tromey  <tom@tromey.com>
2659
2660         * solib-frv.c (frv_relocate_main_executable): Use
2661         unique_xmalloc_ptr.
2662         * solib-dsbt.c (dsbt_relocate_main_executable): Use
2663         unique_xmalloc_ptr.
2664
2665 2018-06-18  Tom Tromey  <tom@tromey.com>
2666
2667         * objfiles.h (inhibit_section_map_updates): Update.
2668         (resume_section_map_updates, resume_section_map_updates_cleanup):
2669         Remove.
2670         * solib-svr4.c (svr4_handle_solib_event): Update.
2671         * objfiles.c (inhibit_section_map_updates): Return
2672         scoped_restore_tmpl<int>.
2673         (resume_section_map_updates, resume_section_map_updates_cleanup):
2674         Remove.
2675
2676 2018-06-18  Tom Tromey  <tom@tromey.com>
2677
2678         * valprint.h (read_string): Update.
2679         * valprint.c (read_string): Change type of "buffer".
2680         (val_print_string): Update.
2681         * python/py-value.c (valpy_string): Update.
2682         * language.h (struct language_defn) <la_get_string>: Change
2683         type of "buffer".
2684         (default_get_string, c_get_string): Update.
2685         * language.c (default_get_string): Change type of "buffer".
2686         * guile/scm-value.c (gdbscm_value_to_string): Update.
2687         * c-lang.c (c_get_string): Change type of "buffer".
2688
2689 2018-06-18  Tom Tromey  <tom@tromey.com>
2690
2691         * ser-mingw.c (struct pipe_state_destroyer): New.
2692         (pipe_state_up): New typedef.
2693         (cleanup_pipe_state): Remove.
2694         (pipe_windows_open): Use pipe_state_up.  Don't release argv.
2695
2696 2018-06-18  Tom Tromey  <tom@tromey.com>
2697
2698         * rust-lang.h (rust_yyerror): Don't declare.
2699         * rust-lang.c (rust_language_defn): Update.
2700         * rust-exp.y (yyerror): Now static.
2701         * parse.c (parse_exp_in_context_1): Update.
2702         * p-lang.h (p_yyerror): Don't declare.
2703         * p-lang.c (p_language_defn): Update.
2704         * p-exp.y (yyerror): Now static.
2705         * opencl-lang.c (opencl_language_defn): Update.
2706         * objc-lang.c (objc_language_defn): Update.
2707         * m2-lang.h (m2_yyerror): Don't declare.
2708         * m2-lang.c (m2_language_defn): Update.
2709         * m2-exp.y (yyerror): Now static.
2710         * language.h (struct language_defn) <la_error>: Remove.
2711         * language.c (unk_lang_error): Remove.
2712         (unknown_language_defn, auto_language_defn): Remove.
2713         * go-lang.h (go_yyerror): Don't declare.
2714         * go-lang.c (go_language_defn): Update.
2715         * go-exp.y (yyerror): Now static.
2716         * f-lang.h (f_yyerror): Don't declare.
2717         * f-lang.c (f_language_defn): Update.
2718         * f-exp.y (yyerror): Now static.
2719         * d-lang.h (d_yyerror): Don't declare.
2720         * d-lang.c (d_language_defn): Update.
2721         * d-exp.y (yyerror): Now static.
2722         * c-lang.h (c_yyerror): Don't declare.
2723         * c-lang.c (c_language_defn, cplus_language_defn)
2724         (asm_language_defn, minimal_language_defn): Update.
2725         * c-exp.y (yyerror): Now static.
2726         * ada-lang.h (ada_yyerror): Don't declare.
2727         * ada-lang.c (ada_language_defn): Update.
2728         * ada-exp.y (yyerror): Now static.
2729
2730 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
2731
2732         * aarch64-linux-nat.c (fetch_sveregs_from_thread): New function.
2733         (store_sveregs_to_thread): Likewise.
2734         (aarch64_linux_fetch_inferior_registers): Check for SVE.
2735         (aarch64_linux_store_inferior_registers): Likewise.
2736         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs): New
2737         function.
2738         (aarch64_sve_regs_copy_to_regcache): Likewise.
2739         (aarch64_sve_regs_copy_from_regcache): Likewise.
2740         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_sveregs): New
2741         declaration.
2742         (aarch64_sve_regs_copy_to_regcache): Likewise.
2743         (aarch64_sve_regs_copy_from_regcache): Likewise.
2744         (sve_context): Structure from Linux headers.
2745         (SVE_SIG_ZREGS_SIZE): Define from Linux headers.
2746         (SVE_SIG_ZREG_SIZE): Likewise.
2747         (SVE_SIG_PREG_SIZE): Likewise.
2748         (SVE_SIG_FFR_SIZE): Likewise.
2749         (SVE_SIG_REGS_OFFSET): Likewise.
2750         (SVE_SIG_ZREGS_OFFSET): Likewise.
2751         (SVE_SIG_ZREG_OFFSET): Likewise.
2752         (SVE_SIG_ZREGS_SIZE): Likewise.
2753         (SVE_SIG_PREGS_OFFSET): Likewise.
2754         (SVE_SIG_PREG_OFFSET): Likewise.
2755         (SVE_SIG_PREGS_SIZE): Likewise.
2756         (SVE_SIG_FFR_OFFSET): Likewise.
2757         (SVE_SIG_REGS_SIZE): Likewise.
2758         (SVE_SIG_CONTEXT_SIZE): Likewise.
2759         (SVE_PT_REGS_MASK): Likewise.
2760         (SVE_PT_REGS_FPSIMD): Likewise.
2761         (SVE_PT_REGS_SVE): Likewise.
2762         (SVE_PT_VL_INHERIT): Likewise.
2763         (SVE_PT_VL_ONEXEC): Likewise.
2764         (SVE_PT_REGS_OFFSET): Likewise.
2765         (SVE_PT_FPSIMD_OFFSET): Likewise.
2766         (SVE_PT_FPSIMD_SIZE): Likewise.
2767         (SVE_PT_SVE_ZREG_SIZE): Likewise.
2768         (SVE_PT_SVE_PREG_SIZE): Likewise.
2769         (SVE_PT_SVE_FFR_SIZE): Likewise.
2770         (SVE_PT_SVE_FPSR_SIZE): Likewise.
2771         (SVE_PT_SVE_FPCR_SIZE): Likewise.
2772         (__SVE_SIG_TO_PT): Likewise.
2773         (SVE_PT_SVE_OFFSET): Likewise.
2774         (SVE_PT_SVE_ZREGS_OFFSET): Likewise.
2775         (SVE_PT_SVE_ZREG_OFFSET): Likewise.
2776         (SVE_PT_SVE_ZREGS_SIZE): Likewise.
2777         (SVE_PT_SVE_PREGS_OFFSET): Likewise.
2778         (SVE_PT_SVE_PREG_OFFSET): Likewise.
2779         (SVE_PT_SVE_PREGS_SIZE): Likewise.
2780         (SVE_PT_SVE_FFR_OFFSET): Likewise.
2781         (SVE_PT_SVE_FPSR_OFFSET): Likewise.
2782         (SVE_PT_SVE_FPCR_OFFSET): Likewise.
2783         (SVE_PT_SVE_SIZE): Likewise.
2784         (SVE_PT_SIZE): Likewise.
2785         (HAS_SVE_STATE): New define.
2786
2787 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
2788
2789         * nat/aarch64-sve-linux-sigcontext.h: New file.
2790         * nat/aarch64-sve-linux-ptrace.h (SVE_VQ_BYTES): Move to
2791         new files.
2792         (SVE_VQ_MIN): Likewise.
2793         (SVE_VQ_MAX): Likewise.
2794         (SVE_VL_MIN): Likewise.
2795         (SVE_VL_MAX): Likewise.
2796         (SVE_NUM_ZREGS): Likewise.
2797         (SVE_NUM_PREGS): Likewise.
2798         (sve_vl_valid): Likewise.
2799         (struct user_sve_header): Likewise.
2800
2801 2018-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2802             Richard Bunt <Richard.Bunt@arm.com>
2803
2804         * linux-nat.c (stop_wait_callback): Don't discard SIGSTOP if it
2805         was requested by GDB.
2806
2807 2018-06-15  Tom de Vries  <tdevries@suse.de>
2808
2809         * MAINTAINERS (Write After Approval): Add Tom de Vries.
2810
2811 2018-06-14  Simon Marchi  <simon.marchi@polymtl.ca>
2812
2813         * gnulib/update-gnulib.sh: Print expected versions of
2814         autoconf/aclocal.
2815
2816 2018-06-14  Simon Marchi  <simon.marchi@ericsson.com>
2817
2818         * arch-utils.c (default_type_align): Use type_length_units.
2819         * gdbtypes.c (type_align): Use type_length_units.
2820
2821 2018-06-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2822
2823         * cli/cli-script.c (_initialize_cli_script): Fix online documentation
2824         of 'define' command.
2825
2826 2018-06-14  Tom de Vries  <tdevries@suse.de>
2827
2828         PR cli/22573
2829         * infcmd.c (print_return_value_1): Use get_user_print_options instead of
2830         get_no_prettyformat_print_options.
2831
2832 2018-06-13  Simon Marchi  <simon.marchi@ericsson.com>
2833
2834         * sparc-nat.h: Include target.h.
2835         * sparc64-linux-nat.c (class sparc64_linux_nat_target)
2836         <fetch_registers>: Remove this argument in function call.
2837         <store_registers>: Remove this argument in function call, remove
2838         extra semicolon.
2839         <low_forget_process>: Call sparc64_forget_process instead of
2840         sparc_forget_process.
2841
2842 2018-06-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2843
2844         * procfs.c (_initialize_procfs): Use add_inf_child_target.
2845         (procfs_target::make_corefile_notes): Adjust to new
2846         target_read_alloc return type.
2847
2848 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2849             Stephen Roberts  <stephen.roberts@arm.com>
2850
2851         PR gdb/22882
2852         * infrun.c (fetch_inferior_event): If GDB is not proceeding then
2853         run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
2854         Move should_notify_stop local into more inner scope.
2855
2856 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2857             Stephen Roberts  <stephen.roberts@arm.com>
2858
2859         PR gdb/22882
2860         * infrun.c (resume_1): Add call to mark_async_event_handler.
2861
2862 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * infrun.c (do_target_wait): Change old version of $pc printed.
2865
2866 2018-06-11  Simon Marchi  <simon.marchi@ericsson.com>
2867
2868         * dwarf2read.c (read_index_from_section): Rename to...
2869         (read_gdb_index_from_section): ... this, update all callers.
2870         (dwarf2_read_index): Rename to...
2871         (dwarf2_read_gdb_index): ... this, update all callers.
2872
2873 2018-06-11  John David Anglin  <danglin@gcc.gnu.org>
2874
2875         * gdb/hppa-linux-nat.c
2876         (hppa_linux_nat_target::fetch_inferior_registers): Rename to
2877         hppa_linux_nat_target::fetch_registers.
2878
2879 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
2880
2881         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Add mappings.
2882         * aarch64-tdep.h (AARCH64_DWARF_SVE_VG): Add define.
2883         (AARCH64_DWARF_SVE_FFR): Likewise.
2884         (AARCH64_DWARF_SVE_P0): Likewise.
2885         (AARCH64_DWARF_SVE_Z0): Likewise.
2886
2887 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
2888
2889         * common/common-regcache.h (raw_compare): New function.
2890         * regcache.c (regcache::raw_compare): Likewise.
2891         * regcache.h (regcache::raw_compare): New declaration.
2892
2893 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
2894
2895         * common/common-regcache.h (reg_buffer_common): New structure.
2896         * regcache.c (reg_buffer::invalidate): Move from detached_regcache.
2897         (reg_buffer::raw_supply): Likewise.
2898         (reg_buffer::raw_supply_integer): Likewise.
2899         (reg_buffer::raw_supply_zeroed): Likewise.
2900         (reg_buffer::raw_collect): Likewise.
2901         (reg_buffer::raw_collect_integer): Likewise.
2902         * regcache.h (reg_buffer::invalidate): Move from detached_regcache.
2903         (reg_buffer::raw_supply): Likewise.
2904         (reg_buffer::raw_supply_integer): Likewise.
2905         (reg_buffer::raw_supply_zeroed): Likewise.
2906         (reg_buffer::raw_collect): Likewise.
2907         (reg_buffer::raw_collect_integer): Likewise.
2908
2909 2018-06-10  Tom Tromey  <tom@tromey.com>
2910
2911         * remote.c (stop_reply_p): Remove typedef.  Don't declare queue.
2912         (class remote_state) <stop_reply_queue>: Now std::vector.
2913         (remote_state::~remote_state)
2914         (remote_target::stop_reply_queue_length): Update.
2915         (struct queue_iter_param, remove_child_of_pending_fork)
2916         (struct check_pending_event_prevents_wildcard_vcont_callback_data)
2917         (check_pending_event_prevents_wildcard_vcont_callback)
2918         (remove_stop_reply_for_inferior)
2919         (remove_stop_reply_of_remote_state)
2920         (remote_notif_remove_once_on_match)
2921         (stop_reply_match_ptid_and_ws)
2922         (remote_kill_child_of_pending_fork): Remove.
2923         (remote_target::remove_new_fork_children)
2924         (remote_target::check_pending_events_prevent_wildcard_vcont)
2925         (remote_target::discard_pending_stop_replies)
2926         (remote_target::discard_pending_stop_replies_in_queue)
2927         (remote_target::remote_notif_remove_queued_reply)
2928         (remote_target::queued_stop_reply)
2929         (remote_target::push_stop_reply, remote_target::peek_stop_reply)
2930         (remote_target::wait, remote_target::kill_new_fork_children)
2931         (remote_target::async): Update.
2932
2933 2018-06-10  Tom Tromey  <tom@tromey.com>
2934
2935         * record-full.c (record_full_arch_list_cleanups): Remove.
2936         (record_full_message): Use try/catch.
2937         (record_full_wait_cleanups): Remove.
2938         (record_full_wait_1): Use try/catch.
2939         (record_full_restore): Likewise.
2940
2941 2018-06-10  Tom Tromey  <tom@tromey.com>
2942
2943         * record-full.c (record_full_breakpoint_p): Remove typedef.  Don't
2944         declare VEC.  Add constructor.
2945         <in_target_beneath>: Now bool.
2946         (record_full_breakpoints): Now a std::vector, static.
2947         (record_full_sync_record_breakpoints)
2948         (record_full_init_record_breakpoints)
2949         (record_full_target::insert_breakpoint)
2950         (record_full_target::remove_breakpoint): Update.  Don't use XNEW.
2951
2952 2018-06-10  Simon Marchi  <simon.marchi@polymtl.ca>
2953
2954         * dwarf2read.c (process_cu_includes): Remove struct keyword.
2955         * serial.c (serial_interface_lookup): Remove struct keyword.
2956
2957 2018-06-10  Tom Tromey  <tom@tromey.com>
2958
2959         * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
2960         method.
2961         * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
2962         a method.
2963         * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
2964         method.
2965         * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
2966         "beneath" as a method.
2967         * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
2968         Use "beneath" as a method.
2969
2970 2018-06-10  Tom Tromey  <tom@tromey.com>
2971
2972         * tracefile.c (struct trace_file_writer_deleter): New.
2973         <operator()>: Rename from trace_file_writer_xfree.
2974         (trace_file_writer_up): New typedef.
2975         (tsave_command, trace_save_tfile, trace_save_ctf): Update.
2976
2977 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
2978
2979         * regcache.h (reg_buffer) <~reg_buffer>: Use default destructor.
2980         <m_registers, m_register_status>: Change type to
2981         std::unique_ptr.
2982         * regcache.c (reg_buffer::reg_buffer): Use new instead of
2983         XCNEWVEC.
2984
2985 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
2986
2987         * common/common-regcache.h (enum register_status): Add
2988         underlying type "signed char".
2989         * regcache.h (reg_buffer) <m_register_status>: Change type to
2990         register_status *.
2991         * regcache.c (reg_buffer::reg_buffer): Alocate arrays of
2992         register_status instead of signed char.
2993         (reg_buffer::save): Use REG_UNKNOWN instead of 0.
2994         (reg_buffer::get_register_status): Remove cast.
2995         (readable_regcache::raw_read): Remove cast.
2996         (readable_regcache::cooked_read): Remove cast.
2997
2998 2018-06-09  Tom Tromey  <tom@tromey.com>
2999
3000         * source.c (reverse_search_command, forward_search_command): Use
3001         scoped_fd.
3002
3003 2018-06-09  Tom Tromey  <tom@tromey.com>
3004
3005         * serial.c (serial_ops_p): Remove typedef.  Don't declare VEC.
3006         (serial_ops_list): Now static, std::vector.
3007         (serial_interface_lookup, serial_add_interface): Update.
3008
3009 2018-06-09  Tom Tromey  <tom@tromey.com>
3010
3011         * dwarf2read.c (process_cu_includes): Update.
3012         (process_full_comp_unit): Update.
3013         * dwarf2read.h (struct dwarf2_per_objfile) <just_read_cus>: Now a
3014         std::vector.
3015
3016 2018-06-08  Paul Koning  <paul_koning@dell.com>
3017
3018         PR gdb/23252
3019
3020         * python/python.c (do_start_initialization):
3021         Avoid call to internal Python API.
3022         (init__gdb_module): New function.
3023
3024 2018-06-08  Gary Benson <gbenson@redhat.com>
3025
3026         * linux-thread-db.c (valprint.h): New include.
3027         (struct check_thread_db_info): New structure.
3028         (check_thread_db_on_load, tdb_testinfo): New static globals.
3029         (check_thread_db, check_thread_db_callback): New functions.
3030         (try_thread_db_load_1): Run integrity checks if requested.
3031         (maintenance_check_libthread_db): New function.
3032         (_initialize_thread_db): Register "maint check libthread-db"
3033         and "maint set/show check-libthread-db".
3034         * NEWS: Mention the above new commands.
3035
3036 2018-06-08  Tom Tromey  <tom@tromey.com>
3037
3038         * windows-nat.c (windows_nat_target::xfer_partial): "beneath" is
3039         now a method.
3040
3041 2018-06-08  Tom Tromey  <tom@tromey.com>
3042
3043         * btrace.c (parse_xml_raw): Use gdb::unique_xmalloc_ptr.
3044
3045 2018-06-08  Tom Tromey  <tom@tromey.com>
3046
3047         * common/btrace-common.h (struct btrace_data): Add constructor,
3048         destructor, move assignment operator.
3049         <empty, clear, fini>: New methods.
3050         <format>: Initialize.
3051         (btrace_data_init, btrace_data_fini, btrace_data_clear)
3052         (btrace_data_empty): Don't declare.
3053         * common/btrace-common.c (btrace_data_init): Remove.
3054         (btrace_data::fini): Rename from btrace_data_fini.
3055         (btrace_data::empty): Rename from btrace_data_empty.
3056         (btrace_data::clear): Rename from btrace_data_clear.  Return
3057         bool.
3058         * btrace.h (make_cleanup_btrace_data): Don't declare.
3059         * btrace.c (btrace_add_pc, btrace_stitch_trace, btrace_clear)
3060         (parse_xml_btrace): Update.
3061         (do_btrace_data_cleanup, make_cleanup_btrace_data): Remove.
3062         (maint_btrace_clear_packet_history_cmd): Update.
3063
3064 2018-06-07  Pedro Alves  <palves@redhat.com>
3065
3066         * target.h (target_ops) <beneath>: Now a method.  All references
3067         updated.
3068         (class target_stack): New.
3069         * target.c (g_target_stack): New.
3070         (g_current_top_target): Delete.
3071         (current_top_target): Get the top target out of g_target_stack.
3072         (target_stack::push, target_stack::unpush): New.
3073         (push_target, unpush_target): Reimplement.
3074         (target_is_pushed): Reimplement in terms of g_target_stack.
3075         (target_ops::beneath, target_stack::find_beneath): New.
3076
3077 2018-06-07  Pedro Alves  <palves@redhat.com>
3078
3079         * target.h (find_target_beneath): Delete declaration.
3080         * target.c (find_target_beneath): Delete definition.
3081         * aix-thread.c: All callers of find_target_beneath adjusted to
3082         call target_ops::beneath instead.
3083         * bsd-uthread.c: Likewise.
3084         * linux-thread-db.c: Likewise.
3085         * ravenscar-thread.c: Likewise.
3086         * sol-thread.c: Likewise.
3087         * spu-multiarch.c: Likewise.
3088
3089 2018-06-07  Pedro Alves  <palves@redhat.com>
3090
3091         * target.h (target_ops) <beneath>: Now a method.  All references
3092         updated.
3093         (target_ops) <m_beneath>: New.
3094         * target.c (target_ops::beneath): New.
3095         * corelow.c: Adjust all references to target_ops::beneath.
3096         * linux-thread-db.c: Likewise.
3097         * make-target-delegates: Likewise.
3098         * record-btrace.c: Likewise.
3099         * record-full.c: Likewise.
3100         * remote.c: Likewise.
3101         * target.c: Likewise.
3102         * target-delegates.c: Regenerate.
3103
3104 2018-06-07  Pedro Alves  <palves@redhat.com>
3105
3106         * target.h (target_stack): Delete.
3107         (current_top_target): Declare function.
3108         * target.c (target_stack): Delete.
3109         (g_current_top_target): New.
3110         (current_top_target): New function.
3111         * auxv.c: Use current_top_target instead of target_stack
3112         throughout.
3113         * avr-tdep.c: Likewise.
3114         * breakpoint.c: Likewise.
3115         * corefile.c: Likewise.
3116         * elfread.c: Likewise.
3117         * eval.c: Likewise.
3118         * exceptions.c: Likewise.
3119         * frame.c: Likewise.
3120         * gdbarch-selftests.c: Likewise.
3121         * gnu-v3-abi.c: Likewise.
3122         * ia64-tdep.c: Likewise.
3123         * ia64-vms-tdep.c: Likewise.
3124         * infcall.c: Likewise.
3125         * infcmd.c: Likewise.
3126         * infrun.c: Likewise.
3127         * linespec.c: Likewise.
3128         * linux-tdep.c: Likewise.
3129         * minsyms.c: Likewise.
3130         * ppc-linux-nat.c: Likewise.
3131         * ppc-linux-tdep.c: Likewise.
3132         * procfs.c: Likewise.
3133         * regcache.c: Likewise.
3134         * remote.c: Likewise.
3135         * rs6000-tdep.c: Likewise.
3136         * s390-linux-nat.c: Likewise.
3137         * s390-tdep.c: Likewise.
3138         * solib-aix.c: Likewise.
3139         * solib-darwin.c: Likewise.
3140         * solib-dsbt.c: Likewise.
3141         * solib-spu.c: Likewise.
3142         * solib-svr4.c: Likewise.
3143         * solib-target.c: Likewise.
3144         * sparc-tdep.c: Likewise.
3145         * sparc64-tdep.c: Likewise.
3146         * spu-tdep.c: Likewise.
3147         * symfile.c: Likewise.
3148         * symtab.c: Likewise.
3149         * target-descriptions.c: Likewise.
3150         * target-memory.c: Likewise.
3151         * target.c: Likewise.
3152         * target.h: Likewise.
3153         * tracefile-tfile.c: Likewise.
3154         * tracepoint.c: Likewise.
3155         * valops.c: Likewise.
3156         * valprint.c: Likewise.
3157         * value.c: Likewise.
3158         * windows-tdep.c: Likewise.
3159         * mi/mi-main.c: Likewise.
3160
3161 2018-06-07  Tom Tromey  <tom@tromey.com>
3162
3163         * valprint.h (build_address_symbolic): Declare.
3164         * printcmd.c (print_address_symbolic): Update.
3165         (build_address_symbolic): Change "name" and "filename" to
3166         std::string.
3167         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3168         Update.
3169         * defs.h (build_address_symbolic): Remove declaration.
3170
3171 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
3172
3173         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
3174         (aarch64_vnv_type): Add function.
3175         (aarch64_pseudo_register_name): Add V regs for SVE.
3176         (aarch64_pseudo_register_type): Likewise.
3177         (aarch64_pseudo_register_reggroup_p): Likewise.
3178         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
3179         (aarch64_pseudo_read_value): Add V regs for SVE.
3180         (aarch64_pseudo_write_2): Use V0 offset for SVE
3181         (aarch64_pseudo_write): Add V regs for SVE.
3182         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
3183
3184 2018-06-06  Sergio Durigan Junior  <sergiodj@redhat.com>
3185
3186         * arch/aarch64.h (sve_vq_from_vl): Guard with #ifndef.
3187         (sve_vl_from_vq): Likewise.
3188
3189 2018-06-05  Tom Tromey  <tom@tromey.com>
3190
3191         * cli/cli-cmds.c (show_version): Update.
3192         * top.c (print_gdb_version): Add "interactive" parameter.
3193         Update.
3194         * main.c (captured_main_1): Update.
3195         * top.h (print_gdb_version): Add "interactive" parameter and a
3196         comment.
3197
3198 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
3199
3200         * common/enum-flags.h: Add trailing semicolon to example in
3201         comment.
3202
3203 2018-06-05  Tom Tromey  <tom@tromey.com>
3204
3205         PR cli/12326:
3206         * NEWS: Add entry about pager.
3207         * utils.c (pagination_disabled_for_command): New global.
3208         (prompt_for_continue): Allow "c" response to prompt.
3209         (reinitialize_more_filter): Clear
3210         pagination_disabled_for_command.
3211         (fputs_maybe_filtered): Check pagination_disabled_for_command.
3212
3213 2018-06-04  Tom Tromey  <tom@tromey.com>
3214
3215         * ada-lang.h (ada_lookup_symbol_list): Update.
3216         * ada-lang.c (resolve_subexp): Update.
3217         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
3218         parameter.
3219         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
3220         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
3221         results parameter to std::vector.
3222         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
3223         Update.
3224         * ada-exp.y (block_lookup): Update.
3225         (select_possible_type_sym): Change type of syms.  Remove nsyms
3226         parameter.
3227         (write_var_or_type, write_name_assoc): Update.
3228
3229 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
3230
3231         * windows-nat.c (windows_nat_target::xfer_partial): Return
3232         TARGET_XFER_E_IO if we need to delegate to the target beneath
3233         but BENEATH is NULL.
3234
3235 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
3236
3237         * Makefile.in (config.status): Add configure.nat as a
3238         dependency.
3239
3240 2018-06-04  Tom Tromey  <tom@tromey.com>
3241
3242         * cp-name-parser.y (cpname_state): Add method declarations.
3243         (HANDLE_QUAL): Update.
3244         (cpname_state::d_grab, cpname_state::fill_comp)
3245         (cpname_state::make_operator, cpname_state::make_dtor)
3246         (cpname_state::make_builtin_type, cpname_state::make_name)
3247         (cpname_state::d_qualify, cpname_state::d_int_type)
3248         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
3249         (%union): Move earlier.
3250
3251 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3252
3253         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
3254
3255 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3256
3257         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
3258         (aarch64_pseudo_write_1): Likewise.
3259         (aarch64_pseudo_read_value): Use helper.
3260         (aarch64_pseudo_write): Likewise.
3261
3262 2018-06-04  Pedro Alves  <palves@redhat.com>
3263
3264         * darwin-nat.c (darwin_ops): Delete.
3265         (darwin_attach_pid): Use get_native_target.
3266
3267 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3268
3269         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
3270         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
3271
3272 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3273
3274         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
3275         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
3276         (aarch64_gdbarch_init): Check for SVE.
3277         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
3278
3279 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3280
3281         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
3282         * aarch64-tdep.h (aarch64_read_description): Likewise.
3283         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3284         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3285         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
3286         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
3287         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
3288
3289 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
3290
3291         * value.c (value_fetch_lazy_bitfield): New.
3292         (value_fetch_lazy_memory): New.
3293         (value_fetch_lazy_register): New.
3294         (value_fetch_lazy): Factor out to smaller functions.
3295
3296 2018-06-01  Tom Tromey  <tom@tromey.com>
3297
3298         * cp-name-parser.y (backslashable, represented): Now const.
3299
3300 2018-06-01  Tom Tromey  <tom@tromey.com>
3301
3302         * cp-name-parser.y: Include parser-defs.h.
3303         (parser_fprintf): Remove declaration.
3304
3305 2018-06-01  Tom Tromey  <tom@tromey.com>
3306
3307         * cp-name-parser.y: Use %pure-parser, %lex-param, and
3308         %parse-param.
3309         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
3310         (global_result): Remove globals.
3311         (struct cpname_state): New.
3312         (yyparse): Don't declare.
3313         (yylex, yyerror): Move declarations after %union.
3314         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
3315         (make_name): Add state parameter.
3316         Update all callers.
3317         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
3318         parameter.
3319         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
3320         Update.
3321         (yylex): Add lvalp, state parameters.
3322         (yyerror): Add state parameter.
3323         (cp_demangled_name_to_comp): Update.
3324
3325 2018-06-01  Tom Tromey  <tom@tromey.com>
3326
3327         * cp-name-parser.y (parser_fprintf): Declare.
3328         (GDB_YY_REMAP_PREFIX): Define.
3329         Include yy-remap.h.  Don't redefine yy* identifiers.
3330
3331 2018-06-01  Tom Tromey  <tom@tromey.com>
3332
3333         * python/py-type.c (typy_legacy_template_argument): Update.
3334         * cp-support.h (cp_demangled_name_to_comp): Update.
3335         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
3336         parameter to be a "std::string *".
3337         (main): Update.
3338
3339 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
3340
3341         * ada-lex.l: Include "diagnostics.h" instead of
3342         "common/diagnostics.h".
3343         * unittests/environ-selftests.c: Likewise.
3344         * common/diagnostics.h: Moved to ../include.
3345
3346 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
3347
3348         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
3349         to language_mode_manual while calling breakpoint_re_set_one.
3350
3351 2018-06-01  Tom Tromey  <tom@tromey.com>
3352
3353         * valops.c (value_cast_structs, destructor_name_p): Update.
3354         * symtab.c (gdb_mangle_name): Update.
3355         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
3356         Update.
3357         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
3358         (pascal_object_print_value_fields, pascal_object_print_value):
3359         Update.
3360         * p-typeprint.c (pascal_type_print_derivation_info): Update.
3361         * linespec.c (find_methods): Update.
3362         * gdbtypes.h (type_name_no_tag): Remove.
3363         (type_name_or_error): Rename from type_name_no_tag_or_error.
3364         * gdbtypes.c (type_name_no_tag): Remove.
3365         (type_name_or_error): Rename from type_name_no_tag_or_error.
3366         (lookup_struct_elt_type, check_typedef): Update.
3367         * expprint.c (print_subexp_standard): Update.
3368         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
3369         * d-namespace.c (d_lookup_nested_symbol): Update.
3370         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
3371         (cp_print_class_member): Update.
3372         * cp-namespace.c (cp_lookup_nested_symbol): Update.
3373         * completer.c (add_struct_fields): Update.
3374         * c-typeprint.c (cp_type_print_derivation_info)
3375         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
3376         Update.
3377         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
3378         (ada_prefer_type, ada_is_exception_sym): Update.
3379
3380 2018-06-01  Tom Tromey  <tom@tromey.com>
3381
3382         * valops.c (enum_constant_from_type, value_namespace_elt)
3383         (value_maybe_namespace_elt): Update.
3384         * valarith.c (find_size_for_pointer_math): Update.
3385         * target-descriptions.c (make_gdb_type): Update.
3386         * symmisc.c (print_symbol): Update.
3387         * stabsread.c (define_symbol, read_type)
3388         (complain_about_struct_wipeout, add_undefined_type)
3389         (cleanup_undefined_types_1): Update.
3390         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
3391         (rust_range_type_p, val_print_struct, rust_print_struct_def)
3392         (rust_internal_print_type, rust_composite_type)
3393         (rust_evaluate_funcall, rust_evaluate_subexp)
3394         (rust_inclusive_range_type_p): Update.
3395         * python/py-type.c (typy_get_tag): Update.
3396         * p-typeprint.c (pascal_type_print_base): Update.
3397         * mdebugread.c (parse_symbol, parse_type): Update.
3398         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
3399         Update.
3400         * guile/scm-type.c (gdbscm_type_tag): Update.
3401         * go-lang.c (sixg_string_p): Update.
3402         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
3403         Update.
3404         * gdbtypes.h (struct main_type) <tag_name>: Remove.
3405         (TYPE_TAG_NAME): Remove.
3406         * gdbtypes.c (type_name_no_tag): Simplify.
3407         (check_typedef, check_types_equal, recursive_dump_type)
3408         (copy_type_recursive, arch_composite_type): Update.
3409         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
3410         in summary mode when needed.
3411         * eval.c (evaluate_funcall): Update.
3412         * dwarf2read.c (fixup_go_packaging, read_structure_type)
3413         (process_structure_scope, read_enumeration_type)
3414         (read_namespace_type, read_module_type, determine_prefix): Update.
3415         * cp-support.c (inspect_type): Update.
3416         * coffread.c (process_coff_symbol, decode_base_type): Update.
3417         * c-varobj.c (c_is_path_expr_parent): Update.
3418         * c-typeprint.c (c_type_print_base_struct_union): Update.
3419         (c_type_print_base_1): Update.  Print struct/class/union/enum in
3420         summary when using C language.
3421         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
3422         (gen_maybe_namespace_elt): Update.
3423         * ada-lang.c (ada_type_name): Simplify.
3424         (empty_record, ada_template_to_fixed_record_type_1)
3425         (template_to_static_fixed_type)
3426         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
3427
3428 2018-06-01  Tom Tromey  <tom@tromey.com>
3429
3430         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
3431         c_print_type.
3432         * c-typeprint.c (c_print_type_1): Add "language" parameter.
3433         (c_print_type): Update.
3434         (c_print_type): New overload.
3435         (c_type_print_varspec_prefix, c_type_print_args)
3436         (c_type_print_varspec_suffix, c_print_type_no_offsets)
3437         (c_type_print_base_struct_union, c_type_print_base_1)
3438         (cp_type_print_method_args): Add "language" parameter.
3439         (c_type_print_base): Update.
3440         * c-lang.h (c_print_type): Add new overload.
3441
3442 2018-06-01  Tom Tromey  <tom@tromey.com>
3443
3444         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
3445         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
3446
3447 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
3448
3449         * aarch64-tdep.c (aarch64_sve_register_names): New const
3450         var.
3451         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
3452         (AARCH64_SVE_Z_REGS_NUM): New define.
3453         (AARCH64_SVE_P_REGS_NUM): Likewise.
3454         (AARCH64_SVE_NUM_REGS): Likewise.
3455
3456 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
3457
3458         * nat/linux-ptrace.h [__alpha__]
3459         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
3460         definitions.
3461
3462 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
3463
3464         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
3465         the endianness selected.
3466         * NEWS: Document `set endian auto' mode operation update.
3467
3468 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
3469
3470         * Makefile.in: Add new header.
3471         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
3472         (sve_vl_from_vg): Likewise.
3473         (sve_vq_from_vl): Likewise.
3474         (sve_vl_from_vq): Likewise.
3475         (sve_vq_from_vg): Likewise.
3476         (sve_vg_from_vq): Likewise.
3477         * configure.nat: Add new c file.
3478         * nat/aarch64-sve-linux-ptrace.c: New file.
3479         * nat/aarch64-sve-linux-ptrace.h: New file.
3480
3481 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
3482
3483         * aarch64-linux-nat.c (aarch64_linux_read_description):
3484         Add parmeter zero.
3485         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3486         Likewise.
3487         * aarch64-tdep.c (tdesc_aarch64_list): Add.
3488         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
3489         (aarch64_gdbarch_init): Add parmeter zero.
3490         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
3491         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
3492         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
3493         parmeter.
3494         * doc/gdb.texinfo: Describe SVE feature
3495         * features/aarch64-sve.c: New file.
3496
3497 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
3498
3499         PR gdb/23210
3500         * gdbarch.sh (significant_addr_bit): Default to zero when
3501         not set by target architecture.
3502         * gdbarch.c: Re-generated.
3503         * utils.c (address_significant): Update.
3504
3505 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
3506
3507         * stack.c (func_command): Remove trailing newline in call to error.
3508
3509 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3510
3511         * regcache.h (regcache_raw_collect): Remove, update callers to
3512         use regcache::raw_collect.
3513         * regcache.c (regcache_raw_collect): Remove.
3514
3515 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3516
3517         * regcache.h (regcache_raw_supply): Remove, update callers to
3518         use detached_regcache::raw_supply.
3519         * regcache.c (regcache_raw_supply): Remove.
3520
3521 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3522
3523         * regcache.h (regcache_cooked_write_part): Remove, update
3524         callers to use regcache::cooked_write_part.
3525         * regcache.c (regcache_cooked_write_part): Remove.
3526
3527 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3528
3529         * regcache.h (regcache_cooked_read_part): Remove, update callers
3530         to use readable_regcache::cooked_read_part.
3531         * regcache.c (regcache_cooked_read_part): Remove.
3532
3533 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3534
3535         * regcache.h (regcache_cooked_read_value): Remove, update
3536         callers to use readable_regcache::cooked_read_value.
3537         * regcache.c (regcache_cooked_read_value): Remove.
3538
3539 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3540
3541         * regcache.h (regcache_cooked_write): Remove, update callers to
3542         use regcache::cooked_write.
3543         * regcache.c (regcache_cooked_write): Remove.
3544
3545 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3546
3547         * regcache.h (regcache_invalidate): Remove, update callers to
3548         use detached_regcache::invalidate instead.
3549         * regcache.c (regcache_invalidate): Remove.
3550
3551 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3552
3553         * regcache.h (regcache_raw_write_part): Remove, update callers
3554         to use regcache::raw_write_part instead.
3555         * regcache.c (regcache_raw_write_part): Remove.
3556
3557 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3558
3559         * regcache.h (regcache_raw_read_part): Remove, update callers to
3560         use readable_regcache::raw_read_part instead.
3561         * regcache.c (regcache_raw_read_part): Remove.
3562
3563 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3564
3565         * regcache.h (regcache_cooked_read): Remove, update callers to
3566         use readable_regcache::cooked_read instead.
3567         * regcache.c (regcache_cooked_read): Remove.
3568
3569 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3570
3571         * regcache.h (regcache_raw_write): Remove, update callers to use
3572         regcache::raw_write instead.
3573         * regcache.c (regcache_raw_write): Remove.
3574
3575 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3576
3577         * regcache.h (regcache_raw_read): Remove, update callers to use
3578         readable_regcache::raw_read instead.
3579         * regcache.c (regcache_raw_read): Remove.
3580
3581 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3582
3583         * regcache.h (regcache_raw_update): Remove, update callers to
3584         use readable_regcache::raw_update instead.
3585         * regcache.c (regcache_raw_update): Remove.
3586
3587 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3588
3589         * regcache.h (regcache_register_status): Remove, update callers
3590         to use reg_buffer::get_register_status directly instead.
3591         * regcache.c (regcache_register_status): Remove.
3592
3593 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3594
3595         * regcache.h (regcache_get_ptid): Remove, update all callers to
3596         call regcache::ptid instead.
3597         * regcache.c (regcache_get_ptid): Remove.
3598
3599 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3600
3601         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
3602
3603 2018-05-30  Pedro Alves  <palves@redhat.com>
3604
3605         * common/common-exceptions.h (exception_rethrow): Use
3606         ATTRIBUTE_NORETURN.
3607
3608 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
3609
3610         * breakpoint.c (print_solib_event, check_status_catch_solib):
3611         Remove struct keyword in range-based for loops.
3612         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
3613         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
3614         Likewise.
3615         * linespec.c (find_superclass_methods, search_minsyms_for_name):
3616         Likewise.
3617         * symfile.c (addr_info_make_relative): Likewise.
3618         * thread.c (value_in_thread_stack_temporaries): Likewise.
3619
3620 2018-06-12  Weimin Pan  <weimin.pan@oracle.com>
3621
3622         PR gdb/16841
3623         * valops.c (value_struct_elt_for_reference): Call check_typedef on
3624         aggregate type to get its real type before accessing it.
3625
3626 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
3627
3628         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
3629         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
3630         * coff-pe-read.c (add_pe_forwarded_sym): Replace
3631         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
3632         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
3633         * jit.c (jit_breakpoint_re_set_internal): Likewise.
3634         * printcmd.c (info_address_command): Likewise.
3635
3636 2018-05-29  Tom Tromey  <tom@tromey.com>
3637
3638         * windows-nat.c (handle_exception): Update fall-through comment.
3639
3640 2018-05-29  Tom Tromey  <tom@tromey.com>
3641
3642         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
3643         (struct program_space) <added_solibs>: Now a std::vector.
3644         * breakpoint.c (print_solib_event): Update.
3645         (check_status_catch_solib): Update.
3646         * progspace.c (clear_program_space_solib_cache): Update.
3647         * solib.c (update_solib_list): Update.
3648
3649 2018-05-29  Tom Tromey  <tom@tromey.com>
3650
3651         * python/py-type.c (typy_richcompare): Update.
3652         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
3653         * gdbtypes.h (types_deeply_equal): Return bool.
3654         (types_equal): Likewise.
3655         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
3656         declare VEC.
3657         (check_types_equal): Change worklist to std::vector.  Return
3658         bool.
3659         (struct type_equality_entry): Add constructor.
3660         (compare_maybe_null_strings): Return bool.
3661         (check_types_worklist): Return bool.  Change worklist to
3662         std::vector.
3663         (types_deeply_equal): Use std::vector.
3664         (types_equal): Return bool.
3665         (compare_maybe_null_strings): Simplify.
3666
3667 2018-05-29  Tom Tromey  <tom@tromey.com>
3668
3669         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
3670
3671 2018-05-29  Tom Tromey  <tom@tromey.com>
3672
3673         * objc-lang.h: Don't include cp-support.h.
3674         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
3675         declare VEC.
3676
3677 2018-05-27  Tom Tromey  <tom@tromey.com>
3678
3679         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
3680
3681 2018-05-25  Tom Tromey  <tom@tromey.com>
3682
3683         * value.c (value::location): Initialize.
3684
3685 2018-05-25  Tom Tromey  <tom@tromey.com>
3686
3687         * dbxread.c (init_bincl_list): Remove.
3688         (bincl_list): Now a std::vector.
3689         (bincls_allocated, next_bincl): Remove.
3690         (free_bincl_list, do_free_bincl_list_cleanup)
3691         (make_cleanup_free_bincl_list): Remove.
3692         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
3693         unique_xmalloc_ptr.
3694         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
3695         (struct header_file_location): Add constructor.
3696         (add_bincl_to_list): Remove.
3697
3698 2018-05-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui.c (tui_enable): Update.
3701         * mi/mi-interp.c (mi_interp::init): Update.
3702         * interps.h (class interp) <name>: New method.
3703         <m_name>: Rename from name.
3704         (~scoped_restore_interp): Update.
3705         * interps.c (interp::interp): Update.
3706         (interp_add, interp_set, interp_lookup_existing)
3707         (current_interp_named_p): Update.
3708
3709 2018-05-25  Tom Tromey  <tom@tromey.com>
3710
3711         * interps.c (interp_name): Remove.
3712         * mi/mi-interp.c (mi_interp::init): Update.
3713         * interps.h (interp_name): Remove.
3714         (~scoped_restore_interp): Update.
3715         * tui/tui.c (tui_enable): Update.
3716
3717 2018-05-25  Tom Tromey  <tom@tromey.com>
3718
3719         * utils.c (fputs_maybe_filtered): Update.
3720         * linespec.c (decode_line_full): Update.
3721         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
3722         (mi_print_breakpoint_for_event, mi_solib_loaded)
3723         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
3724         (mi_user_selected_context_changed): Update.
3725         * mi/mi-main.c (mi_execute_command): Update.
3726         * cli/cli-script.c (execute_control_command): Update.
3727         * python/python.c (execute_gdb_command): Update.
3728         * solib.c (info_sharedlibrary_command): Update.
3729         * interps.c (interp_ui_out): Remove.
3730         * interps.h (interp_ui_out): Remove.
3731
3732 2018-05-25  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
3735         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
3736         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
3737
3738 2018-05-25  Tom Tromey  <tom@tromey.com>
3739
3740         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
3741         * interps.c (interp_exec): Use scoped_restore.
3742
3743 2018-05-25  Tom Tromey  <tom@tromey.com>
3744
3745         * remote.c (remote_target::remote_file_get): Use
3746         gdb::byte_vector.
3747         (remote_target::remote_file_put): Likewise.
3748
3749 2018-05-25  Tom Tromey  <tom@tromey.com>
3750
3751         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
3752         a std::string.
3753         (get_pe_section_index, add_pe_exported_sym): Update.
3754         (read_pe_exported_syms): Use gdb::def_vector.
3755
3756 2018-05-25  Tom Tromey  <tom@tromey.com>
3757
3758         * frame.c (remove_prev_frame): Remove.
3759         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
3760
3761 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
3762
3763         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
3764         Remove prototypes.
3765         * mips-linux-nat.c (supply_fpregset): Always call
3766         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
3767         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
3768         `mips_fill_fpregset'.
3769         * mips-linux-tdep.c (mips_supply_fpregset)
3770         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
3771         (mips_fill_fpregset_wrapper): Remove functions.
3772         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
3773         (mips_linux_fpregset): Remove variable.
3774         (mips_linux_iterate_over_regset_sections): Use
3775         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
3776         (mips_linux_o32_sigframe_init): Remove comment.
3777
3778 2018-05-25  Pedro Alves  <palves@redhat.com>
3779
3780         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
3781         (struct readahead_cache, struct packet_reg, struct
3782         remote_arch_state, class remote_state): Move higher up in the
3783         file.
3784         (remote_target::m_remote_state): Now an object instead of a pointer.
3785         (remote_target::get_remote_state): Adjust.
3786
3787 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * stack.c (select_and_print_frame): Delete.
3790         (struct function_bounds): Move struct within function.
3791         (func_command): Most content moved into new function
3792         find_frame_for_function, use new function, print result, add
3793         function comment.
3794         (find_frame_for_function): New function, now returns a result.
3795
3796 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3797
3798         * stack.c (iterate_over_block_arg_vars): Fix comment.
3799         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
3800
3801 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         PR gdb/23203
3804         * frame.c
3805         (scoped_restore_selected_frame::scoped_restore_selected_frame):
3806         Define.
3807         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
3808         Define.
3809         * frame.h (class scoped_restore_selected_frame): New class.
3810         * stack.c (print_frame_local_vars): Remove catching and rethrowing
3811         of any exception, use scoped_restore_selected_frame to restore the
3812         frame instead.
3813
3814 2018-05-24  Pedro Alves  <palves@redhat.com>
3815
3816         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
3817         override.
3818
3819 2018-05-23  Tom Tromey  <tom@tromey.com>
3820
3821         * complaints.c (struct complaints): Remove.
3822         (symfile_complaint_book): Remove.
3823         (series): New global.
3824         (complaint_internal): Update.
3825         (clear_complaints): Update.
3826
3827 2018-05-23  Tom Tromey  <tom@tromey.com>
3828
3829         * complaints.c (counters): New global.
3830         (struct complain): Remove.
3831         (struct complaints) <root>: Remove.
3832         (complaint_sentinel): Remove.
3833         (symfile_complaint_book): Update.
3834         (find_complaint) Remove.
3835         (complaint_internal, clear_complaints): Update.
3836
3837 2018-05-23  Tom Tromey  <tom@tromey.com>
3838
3839         * complaints.c (struct complain) <file, line>: Remove.
3840         (find_complaint): Remove file, line parameters.
3841         (complaint_internal): Update.
3842
3843 2018-05-23  Tom Tromey  <tom@tromey.com>
3844
3845         * complaints.c (vcomplaint): Remove.
3846         (complaint_internal) Merge in contents of vcomplaint.
3847
3848 2018-05-23  Tom Tromey  <tom@tromey.com>
3849
3850         * complaints.c (struct complaints) <explanation>: Remove.
3851         (symfile_explanations): Remove.
3852         (symfile_complaint_book): Update.
3853         (vcomplaint): Update.
3854         (struct explanation): Remove.
3855
3856 2018-05-23  Tom Tromey  <tom@tromey.com>
3857
3858         * complaints.c (symfile_complaints): Remove.
3859         (complaint_internal): Remove "complaints" parameter.
3860         (clear_complaints, vcomplaint): Remove "c" parameter.
3861         (get_complaints): Remove.
3862         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
3863         (dwarf2_debug_line_missing_file_complaint)
3864         (dwarf2_debug_line_missing_end_sequence_complaint)
3865         (dwarf2_complex_location_expr_complaint)
3866         (dwarf2_const_value_length_mismatch_complaint)
3867         (dwarf2_section_buffer_overflow_complaint)
3868         (dwarf2_macro_malformed_definition_complaint)
3869         (dwarf2_invalid_attrib_class_complaint)
3870         (create_addrmap_from_index, dw2_symtab_iter_next)
3871         (dw2_expand_marked_cus)
3872         (dw2_debug_names_iterator::find_vec_in_debug_names)
3873         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
3874         (create_debug_type_hash_table, init_cutu_and_read_dies)
3875         (partial_die_parent_scope, add_partial_enumeration)
3876         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
3877         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
3878         (read_import_statement, read_file_scope, create_dwo_cu_reader)
3879         (create_cus_hash_table, create_dwp_hash_table)
3880         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
3881         (dwarf2_rnglists_process, dwarf2_ranges_process)
3882         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
3883         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
3884         (handle_struct_member_die, process_structure_scope)
3885         (read_array_type, read_common_block, read_module_type)
3886         (read_tag_pointer_type, read_typedef, read_base_type)
3887         (read_subrange_type, load_partial_dies, partial_die_info::read)
3888         (partial_die_info::read, partial_die_info::read)
3889         (partial_die_info::read, read_checked_initial_length_and_offset)
3890         (dwarf2_string_attr, read_formatted_entries)
3891         (dwarf_decode_line_header)
3892         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
3893         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
3894         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
3895         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
3896         (get_signatured_type, get_DW_AT_signature_type)
3897         (decode_locdesc, file_file_name, consume_improper_spaces)
3898         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
3899         (dwarf_decode_macro_bytes, dwarf_decode_macros)
3900         (dwarf2_symbol_mark_computed, set_die_type)
3901         (read_attribute_value): Update.
3902         * stap-probe.c (handle_stap_probe, get_stap_base_address):
3903         Update.
3904         * dbxread.c (unknown_symtype_complaint)
3905         (lbrac_mismatch_complaint, repeated_header_complaint)
3906         (set_namestring, function_outside_compilation_unit_complaint)
3907         (read_dbx_symtab, process_one_symbol): Update.
3908         * gdbtypes.c (stub_noname_complaint): Update.
3909         * windows-nat.c (handle_unload_dll): Update.
3910         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
3911         (decode_base_type): Update.
3912         * xcoffread.c (bf_notfound_complaint, ef_complaint)
3913         (eb_complaint, record_include_begin, record_include_end)
3914         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
3915         (process_xcoff_symbol, read_symbol)
3916         (function_outside_compilation_unit_complaint)
3917         (scan_xcoff_symtab): Update.
3918         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
3919         * buildsym.c (finish_block_internal, make_blockvector)
3920         (end_symtab_get_static_block, augment_type_symtab): Update.
3921         * dtrace-probe.c (dtrace_process_dof)
3922         (dtrace_static_probe_ops::get_probes): Update.
3923         * complaints.h (struct complaint): Don't declare.
3924         (symfile_complaints): Remove.
3925         (complaint_internal): Remove "complaints" parameter.
3926         (complaint): Likewise.
3927         (clear_complaints): Likewise.
3928         * symfile.c (syms_from_objfile_1, finish_new_objfile)
3929         (reread_symbols): Update.
3930         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
3931         (dwarf2_frame_cache, decode_frame_entry): Update.
3932         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
3933         * objc-lang.c (lookup_objc_class, lookup_child_selector)
3934         (info_selectors_command): Update.
3935         * macrotab.c (macro_include, check_for_redefinition)
3936         (macro_undef): Update.
3937         * objfiles.c (filter_overlapping_sections): Update.
3938         * stabsread.c (invalid_cpp_abbrev_complaint)
3939         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
3940         (define_symbol, error_type, read_type, rs6000_builtin_type)
3941         (stabs_method_name_from_physname, read_member_functions)
3942         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
3943         (attach_fields_to_type, complain_about_struct_wipeout)
3944         (read_range_type, read_args, common_block_start)
3945         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
3946         Update.
3947         * mdebugread.c (index_complaint, unknown_ext_complaint)
3948         (basic_type_complaint, bad_tag_guess_complaint)
3949         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
3950         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
3951         (parse_procedure, parse_lines)
3952         (function_outside_compilation_unit_complaint)
3953         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
3954         (bad_tag_guess_complaint, reg_value_complaint): Update.
3955         * cp-support.c (demangled_name_complaint): Update.
3956         * macroscope.c (sal_macro_scope): Update.
3957         * dwarf-index-write.c (class debug_names): Update.
3958
3959 2018-05-23  Tom Tromey  <tom@tromey.com>
3960
3961         * complaints.c (clear_complaints): Remove "noisy" parameter.
3962         * complaints.h (clear_complaints): Update.
3963         * symfile.c (syms_from_objfile_1, finish_new_objfile)
3964         (reread_symbols): Update.
3965
3966 2018-05-23  Tom Tromey  <tom@tromey.com>
3967
3968         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
3969         SUBSEQUENT_MESSAGE.
3970         (vcomplaint, clear_complaints): Update.
3971         (symfile_explanations): Remove some messages.
3972
3973 2018-05-23  Tom Tromey  <tom@tromey.com>
3974
3975         * complaints.c (internal_complaint): Remove.
3976         * complaints.h (internal_complaint): Remove.
3977
3978 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
3979
3980         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
3981
3982 2018-05-22  Pedro Alves  <palves@redhat.com>
3983
3984         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
3985         (remote_fileio_badfd, remote_fileio_return_errno)
3986         (remote_fileio_return_success, remote_fileio_func_open)
3987         (remote_fileio_func_open, remote_fileio_func_close)
3988         (remote_fileio_func_read, remote_fileio_func_write)
3989         (remote_fileio_func_lseek, remote_fileio_func_rename)
3990         (remote_fileio_func_unlink, remote_fileio_func_stat)
3991         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
3992         (remote_fileio_func_isatty, remote_fileio_func_system): Add
3993         remote_target parameter.
3994         (remote_fio_func_map) <func>: Add remote_target parameter.
3995         (do_remote_fileio_request, remote_fileio_request):
3996         * remote-fileio.h (remote_fileio_request):
3997         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
3998         remote_target parameter.
3999         (remote_notif_process, handle_notification): Adjust to pass down
4000         the remote.
4001         (remote_notif_state_allocate): Add remote_target parameter.  Save
4002         it.
4003         * remote-notif.h (struct remote_target): Forward declare.
4004         (struct notif_client) <parse, ack, can_get_pending_events>: Add
4005         remote_target parameter.
4006         (struct remote_notif_state) <remote>: New field.
4007         (remote_notif_ack, remote_notif_parse): Add remote_target
4008         parameter.
4009         (remote_notif_state_allocate, remote_notif_state_allocate): Add
4010         remote_target parameter.
4011         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
4012         (threads_listing_context, rmt_thread_action, protocol_feature)
4013         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
4014         (packet_result, struct threads_listing_context, remote_state):
4015         Move definitions and declarations higher up.
4016         (remote_target) <~remote_target>: Declare.
4017         (remote_download_command_source, remote_file_put, remote_file_get)
4018         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
4019         (remote_hostio_pread_vFile, remote_hostio_send_command)
4020         (remote_hostio_set_filesystem, remote_hostio_open)
4021         (remote_hostio_close, remote_hostio_unlink, remote_state)
4022         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
4023         (get_memory_write_packet_size, get_memory_read_packet_size)
4024         (append_pending_thread_resumptions, remote_detach_1)
4025         (append_resumption, remote_resume_with_vcont)
4026         (add_current_inferior_and_thread, wait_ns, wait_as)
4027         (process_stop_reply, remote_notice_new_inferior)
4028         (process_initial_stop_replies, remote_add_thread)
4029         (btrace_sync_conf, remote_btrace_maybe_reopen)
4030         (remove_new_fork_children, kill_new_fork_children)
4031         (discard_pending_stop_replies, stop_reply_queue_length)
4032         (check_pending_events_prevent_wildcard_vcont)
4033         (discard_pending_stop_replies_in_queue, stop_reply)
4034         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
4035         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
4036         (remote_interrupt_as, remote_interrupt_ns)
4037         (remote_get_noisy_reply, remote_query_attached)
4038         (remote_add_inferior, remote_current_thread, get_current_thread)
4039         (set_thread, set_general_thread, set_continue_thread)
4040         (set_general_process, write_ptid)
4041         (remote_unpack_thread_info_response, remote_get_threadinfo)
4042         (parse_threadlist_response, remote_get_threadlist)
4043         (remote_threadlist_iterator, remote_get_threads_with_ql)
4044         (remote_get_threads_with_qxfer)
4045         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
4046         (get_offsets, remote_check_symbols, remote_supported_packet)
4047         (remote_query_supported, remote_packet_size)
4048         (remote_serial_quit_handler, remote_detach_pid)
4049         (remote_vcont_probe, remote_resume_with_hc)
4050         (send_interrupt_sequence, interrupt_query)
4051         (remote_notif_get_pending_events, fetch_register_using_p)
4052         (send_g_packet, process_g_packet, fetch_registers_using_g)
4053         (store_register_using_P, store_registers_using_G)
4054         (set_remote_traceframe, check_binary_download)
4055         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
4056         (remote_xfer_live_readonly_partial, remote_read_bytes)
4057         (remote_send_printf, remote_flash_write, readchar)
4058         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
4059         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
4060         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
4061         (extended_remote_disable_randomization, extended_remote_run)
4062         (send_environment_packet, extended_remote_environment_support)
4063         (extended_remote_set_inferior_cwd, remote_write_qxfer)
4064         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
4065         (packet_command): Now methods of ...
4066         (remote_target): ... this class.
4067         (m_remote_state) <remote_target>: New field.
4068         (struct remote_state) <stop_reply_queue,
4069         remote_async_inferior_event_token, wait_forever_enabled_p>: New
4070         fields.
4071         (remote_state::remote_state): Allocate stop_reply_queue.
4072         (remote_state): Delete global.
4073         (get_remote_state_raw): Delete.
4074         (remote_target::get_remote_state): Allocate m_remote_state on
4075         demand.
4076         (get_current_remote_target): New.
4077         (remote_ops, extended_remote_ops): Delete.
4078         (wait_forever_enabled_p, remote_async_inferior_event_token):
4079         Delete, moved to struct remote_state.
4080         (remote_target::close): Delete self.  Destruction bits split to
4081         ...
4082         (remote_target::~remote_target): ... this.
4083         (show_memory_packet_size): Adjust to use
4084         get_current_remote_target.
4085         (struct protocol_feature) <func>: Add remote_target parameter.
4086         All callers adjusted.
4087         (curr_quit_handler_target): New.
4088         (remote_serial_quit_handler): Reimplement.
4089         (remote_target::open_1): Adjust to use get_current_remote_target.
4090         Heap-allocate remote_target/extended_remote_target instances.
4091         (vcont_builder::vcont_builder): Add remote_target parameter, and
4092         save it in m_remote.  All callers adjusted.
4093         (vcont_builder::m_remote): New field.
4094         (vcont_builder::restart, vcont_builder::flush)
4095         (vcont_builder::push_action): Use it.
4096         (remote_target::commit_resume): Use it.
4097         (struct queue_iter_param) <remote>: New field.
4098         (remote_target::remove_new_fork_children): Fill in 'remote' field.
4099         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
4100         (check_pending_event_prevents_wildcard_vcont_callback)
4101         (remote_target::check_pending_events_prevent_wildcard_vcont)
4102         (remote_target::discard_pending_stop_replies)
4103         (remote_target::discard_pending_stop_replies_in_queue)
4104         (remote_target::remote_notif_remove_queued_reply): Fill in
4105         'remote' field.
4106         (remote_notif_get_pending_events): New.
4107         (remote_target::readchar, remote_target::remote_serial_write):
4108         Save/restore curr_quit_handler_target.
4109         (putpkt): New.
4110         (kill_new_fork_children): Fill in 'remote' field.
4111         (packet_command): Use get_current_remote_target, defer to
4112         remote_target method of same name.
4113         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
4114         parameter, and save it in m_remote.  All callers adjusted.
4115         (scoped_remote_fd::release): Use m_remote.
4116         (scoped_remote_fd::m_remote): New field.
4117         (remote_file_put, remote_file_get, remote_file_delete): Use
4118         get_current_remote_target, defer to remote_target method of same
4119         name.
4120         (remote_btrace_reset): Add remote_state paremeter.  Update all
4121         callers.
4122         (remote_async_inferior_event_handler). Pass down 'data'.
4123         (remote_new_objfile): Use get_current_remote_target.
4124         (remote_target::vcont_r_supported): New.
4125         (set_range_stepping): Use get_current_remote_target and
4126         remote_target::vcont_r_supported.
4127         (_initialize_remote): Don't allocate 'remote_state' and
4128         'stop_reply_queue' globals.
4129         * remote.h (struct remote_target): Forward declare.
4130         (getpkt, putpkt, remote_notif_get_pending_events): Add
4131         'remote_target' parameter.
4132
4133 2018-05-22  Pedro Alves  <palves@redhat.com>
4134
4135         * remote.c (vcont_builder): Now a class.  Make all data members
4136         private.
4137         (vcont_builder) <vcont_builder, restart, flush, push_action>:
4138         Declare methods.
4139         (vcont_builder_restart): Rename to ...
4140         (vcont_builder::restart): ... this.
4141         (vcont_builder_flush): Rename to ...
4142         (vcont_builder::flush): ... this.
4143         (vcont_builder_push_action): Rename to ...
4144         (vcont_builder::push_action): ... this.
4145         (remote_target::commit_resume): Adjust.
4146
4147 2018-05-22  Pedro Alves  <palves@redhat.com>
4148
4149         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
4150         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
4151         (get_fixed_memory_packet_size): New.
4152         (get_memory_packet_size): Use it.
4153         (set_memory_packet_size): Don't override the config size with
4154         DEFAULT_MAX_MEMORY_PACKET_SIZE.
4155         (show_memory_packet_size): Use get_fixed_memory_packet_size.
4156         Don't refer to get_memory_packet_size if not connected to a remote
4157         target.  Show "(default)" if configured size is 0.
4158
4159 2018-05-22  Pedro Alves  <palves@redhat.com>
4160
4161         * remote.c (remote_target::mourn_inferior): Move
4162         discard_pending_stop_replies call here from ...
4163         (_initialize_remote): ... here.
4164
4165 2018-05-22  Pedro Alves  <palves@redhat.com>
4166
4167         * remote.c (compare_section_command): Remove set_general_process
4168         call.
4169
4170 2018-05-22  Pedro Alves  <palves@redhat.com>
4171
4172         * remote.c (struct packet_reg, struct remote_arch_state):
4173         Move higher up in the file.
4174         (remote_state) <m_arch_states>: Store remote_arch_state values
4175         instead of remote_arch_state pointers.
4176         (remote_state::get_remote_arch_state): Adjust.
4177
4178 2018-05-22  Pedro Alves  <palves@redhat.com>
4179
4180         * remote.c: Include <unordered_map>.
4181         (remote_state): Now a class.
4182         (remote_state) <get_remote_arch_state>: Declare method.
4183         <get_remote_arch_state>: New field.
4184         (remote_arch_state) <remote_arch_state>: Declare ctor.
4185         <regs>: Now a unique_ptr.
4186         (remote_gdbarch_data_handle): Delete.
4187         (get_remote_arch_state): Delete.
4188         (remote_state::get_remote_arch_state): New.
4189         (get_remote_state): Adjust to call remote_state's
4190         get_remote_arch_state method.
4191         (init_remote_state): Delete, bits factored out to ...
4192         (remote_arch_state::remote_arch_state): ... this new method.
4193         (get_remote_packet_size, get_memory_packet_size)
4194         (process_g_packet, remote_target::fetch_registers)
4195         (remote_target::prepare_to_store, store_registers_using_G)
4196         (remote_target::store_registers, remote_target::get_trace_status):
4197         Adjust to call remote_state's method.
4198         (_initialize_remote): Remove reference to
4199         remote_gdbarch_data_handle.
4200
4201 2018-05-22  Pedro Alves  <palves@redhat.com>
4202
4203         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
4204         pread>: New method declarations.
4205         (remote_target::open_1): Adjust.
4206         (readahead_cache_invalidate): Rename to ...
4207         (readahead_cache::invalidate): ... this, and adjust to be a class
4208         method.
4209         (readahead_cache_invalidate_fd): Rename to ...
4210         (readahead_cache::invalidate_fd): ... this, and adjust to be a
4211         class method.
4212         (remote_hostio_pwrite): Adjust.
4213         (remote_hostio_pread_from_cache): Rename to ...
4214         (readahead_cache::pread): ... this, and adjust to be a class
4215         method.
4216         (remote_hostio_close): Adjust.
4217
4218 2018-05-22  Pedro Alves  <palves@redhat.com>
4219
4220         * remote.c (remote_hostio_close_cleanup): Delete.
4221         (class scoped_remote_fd): New.
4222         (remote_file_put, remote_file_get): Use it.
4223
4224 2018-05-22  Pedro Alves  <palves@redhat.com>
4225
4226         (struct vCont_action_support): Use bool and initialize all fields.
4227         (struct readahead_cache): Initialize all fields.
4228         (remote_state): Use bool and initialize all fields.
4229         (remote_state::remote_state, remote_state::~remote_state): New.
4230         (new_remote_state): Delete.
4231         (_initialize_remote): Use new to allocate remote_state.
4232
4233 2018-05-22  Pedro Alves  <palves@redhat.com>
4234             張俊芝  <zjz@zjz.name>
4235
4236         PR gdb/22973
4237         * c-exp.y: Include "c-support.h".
4238         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
4239         of tolower.  Use c_ident_is_alpha to scan names.
4240         * c-lang.c: Include "c-support.h".
4241         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
4242         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
4243         * c-support.h: New file, with bits factored out from ...
4244         * cp-name-parser.y: ... this file.
4245         Include "c-support.h".
4246         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
4247         c-support.h and renamed.
4248         (symbol_end, yylex): Adjust.
4249
4250 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4251
4252         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
4253         parameter type to CORE_ADDR.
4254         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
4255         parameter type in declaration to CORE_ADDR.
4256         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
4257         target_auxv_search to get AT_HWCAP and use the result to get the
4258         target description.
4259         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
4260         to CORE_ADDR. Remove the cast of the return value to unsigned
4261         long. Fix error predicate of target_auxv_search.
4262         (ppc_linux_nat_target::read_description): Change the type of the
4263         hwcap variable to CORE_ADDR.
4264
4265 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4266
4267         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
4268         if the size of fpscr is larger than 32 bits.
4269
4270 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4271
4272         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
4273         (ppc32_linux_vsxregmap): New global.
4274         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
4275         regcache_supply_regset, and regcache_collect_regset.
4276         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
4277         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
4278         (fetch_vsx_register, store_vsx_register): Remove.
4279         (fetch_vsx_registers): Add regno parameter. Get regset using
4280         ppc_linux_vsxregset. Use regset to supply registers.
4281         (store_vsx_registers): Add regno parameter. Get regset using
4282         ppc_linux_vsxregset. Use regset to collect registers.
4283         (fetch_register): Call fetch_vsx_registers instead of
4284         fetch_vsx_register.
4285         (store_register): Call store_vsx_registers instead of
4286         store_vsx_register.
4287         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
4288         new regno parameter.
4289         (store_ppc_registers): Call store_vsx_registers with -1 for the
4290         new regno parameter.
4291         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
4292         (ppc_collect_vsxregset): Remove.
4293
4294 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4295
4296         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
4297         offset fields.
4298         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
4299         for vector register offset fields.
4300         (ppc64_fbsd_reg_offsets): Likewise.
4301         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
4302         to vector register offset fields.
4303         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
4304         to vector register offset fields.
4305         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
4306         vector register offset fields.
4307         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
4308         initializers for vector register offset fields.
4309         (rs6000_aix64_reg_offsets): Likewise.
4310         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
4311         (ppc_supply_vrregset): Remove.
4312         (ppc_collect_vrregset): Remove.
4313         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
4314         (ppc_linux_vrregset) : New function.
4315         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
4316         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
4317         (ppc32_linux_vrregset): Remove.
4318         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
4319         and use result instead of ppc32_linux_vrregset.
4320         (ppc32_linux_reg_offsets): Remove initializers for vector register
4321         offset fields.
4322         (ppc64_linux_reg_offsets): Likewise.
4323         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
4324         * ppc-linux-nat.c: Include regset.h.
4325         (gdb_vrregset_t): Adjust comment to account for little-endian
4326         mode.
4327         (supply_vrregset, fill_vrregset): Remove.
4328         (fetch_altivec_register, store_altivec_register): Remove.
4329         (fetch_altivec_registers): Add regno parameter. Get regset using
4330         ppc_linux_vrregset. Use regset to supply registers.
4331         (store_altivec_registers): Add regno parameter. Get regset using
4332         ppc_linux_vrregset. Use regset to collect registers.
4333         (fetch_register): Call fetch_altivec_registers instead of
4334         fetch_altivec_register.
4335         (store_register): Call store_altivec_registers instead of
4336         store_altivec_register.
4337         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
4338         the new regno parameter.
4339         (store_ppc_registers): Call store_altivec_registers with -1 for
4340         the new regno parameter.
4341
4342 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4343
4344         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
4345         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
4346         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
4347         (gdb_vrregset_t): Change array type size to
4348         PPC_LINUX_SIZEOF_VRREGSET.
4349         (gdb_vsxregset_t): Change array type size to
4350         PPC_LINUX_SIZEOF_VSXREGSET.
4351         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
4352         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
4353         PPC_LINUX_SIZEOF_VSXREGSET.
4354
4355 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4356
4357         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
4358         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
4359         nat/ppc-linux.c.
4360         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
4361         ppc_linux_target_wordsize with tid.
4362         (ppc_linux_nat_target::read_description): Call ppc_linux_target
4363         wordsize with tid.
4364         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
4365         (ppc64_64bit_inferior_p): Add static and inline specifiers.
4366         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
4367         tid parameter. Remove static specifier.
4368         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
4369         (ppc_linux_target_wordsize): New declaration.
4370
4371 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4372
4373         * arch/ppc-linux-common.c: New file.
4374         * arch/ppc-linux-common.h: New file.
4375         * arch/ppc-linux-tdesc.h: New file.
4376         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
4377         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
4378         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
4379         arch/ppc-linux-tdesc.h.
4380         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
4381         arch/ppc-linux-tdesc.h.
4382         (ppc_linux_nat_target::read_description): Remove target
4383         description matching code. Fill a ppc_linux_features struct and
4384         call ppc_linux_match_description with it. Move comment about ISA
4385         2.05 to ppc-linux-common.c.
4386         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
4387         arch/ppc-linux-tdesc.h.
4388         (ppc_linux_core_read_description): Remove target description
4389         matching code. Fill a ppc_linux_features struct and call
4390         ppc_linux_match_description with it.
4391         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
4392         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
4393         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
4394         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
4395         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
4396         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
4397         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
4398         (tdesc_powerpc_e500l): Remove.
4399
4400 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
4401
4402         * ada-lang.c (catch_assert_command): Pass empty string instead
4403         of NULL for excep_string argument.
4404
4405 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
4406
4407         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
4408         the width of the requested register exceeds the width of the
4409         `ptrace' data type.
4410
4411 2018-05-21  Tom Tromey  <tom@tromey.com>
4412
4413         * printcmd.c (output_command): Remove.
4414         (output_command_const): Rename to output_command.
4415         * valprint.h (output_command): Rename from output_command_const.
4416         * tracepoint.c (trace_dump_actions): Call output_command.
4417
4418 2018-05-21  Tom Tromey  <tom@tromey.com>
4419
4420         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
4421         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
4422         * ada-lang.h (create_ada_exception_catchpoint): Update.
4423         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
4424         std::string.
4425         (create_excep_cond_exprs, ~ada_catchpoint)
4426         (should_stop_exception, print_one_exception)
4427         (print_mention_exception, print_recreate_exception): Update.
4428         (ada_get_next_arg): Remove.
4429         (catch_ada_exception_command_split): Use std::string.  Change type
4430         of "excep_string", "cond_string".
4431         (catch_ada_exception_command): Update.
4432         (create_ada_exception_catchpoint): Change type of excep_string.
4433         (ada_exception_sal): Remove excep_string parameter.
4434         (~ada_catchpoint): Remove.
4435
4436 2018-05-21  Tom Tromey  <tom@tromey.com>
4437
4438         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
4439         cleanup.
4440
4441 2018-05-21  Tom Tromey  <tom@tromey.com>
4442
4443         * ada-lang.c (ada_exception_message_1, ada_exception_message):
4444         Return unique_xmalloc_ptr.
4445         (print_it_exception): Update.
4446
4447 2018-05-21  Tom Tromey  <tom@tromey.com>
4448
4449         * tracepoint.c (trace_dump_actions): Use std::string.
4450
4451 2018-05-21  Tom Tromey  <tom@tromey.com>
4452
4453         * symfile.c (reread_symbols): Use std::string for original_name.
4454
4455 2018-05-21  Tom Tromey  <tom@tromey.com>
4456
4457         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
4458         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
4459         constructor.
4460
4461 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
4462
4463         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
4464         instance to...
4465         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
4466         * objfiles.c (get_objfile_bfd_data): Allocate
4467         objfile_per_bfd_storage with obstack_new when allocating on
4468         obstack.
4469
4470 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
4471
4472         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
4473         OBSTACK_ZALLOC.
4474         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
4475         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
4476         * mdebugread.c (mdebug_build_psymtabs): Likewise.
4477         (add_pending): Likewise.
4478         (parse_symbol): Likewise.
4479         (parse_partial_symbols): Likewise.
4480         (psymtab_to_symtab_1): Likewise.
4481         (new_psymtab): Likewise.
4482         (elfmdebug_build_psymtabs): Likewise.
4483         * minsyms.c (terminate_minimal_symbol_table): Likewise.
4484         * objfiles.c (get_objfile_bfd_data): Likewise.
4485         (objfile_register_static_link): Likewise.
4486         * psymtab.c (allocate_psymtab): Likewise.
4487         * stabsread.c (read_member_functions): Likewise.
4488         * xcoffread.c (xcoff_end_psymtab): Likewise.
4489
4490 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
4491
4492         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
4493         compiler supports std::is_trivially_constructible.
4494         * common/poison.h: Include obstack.h.
4495         (IsMallocable): Define to is_trivially_constructible if the
4496         compiler supports it, define to true_type otherwise.
4497         (xobnew): New.
4498         (XOBNEW): Redefine.
4499         (xobnewvec): New.
4500         (XOBNEWVEC): Redefine.
4501         * gdb_obstack.h (obstack_zalloc): New.
4502         (OBSTACK_ZALLOC): Redefine.
4503         (obstack_calloc): New.
4504         (OBSTACK_CALLOC): Redefine.
4505         (obstack_new): New.
4506         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
4507         (gdbarch_obstack): New declaration in gdbarch.h, definition in
4508         gdbarch.c.
4509         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
4510         obstack_calloc/obstack_zalloc.
4511         (gdbarch_obstack_zalloc): Remove.
4512         * target-descriptions.c (tdesc_data_init): Use obstack_new.
4513
4514 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4515
4516         * stack.c (backtrace_command_1): Remove useless variable int i.
4517
4518 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4519
4520         * stack.c (print_frame_info): Fix comment.
4521
4522 2018-05-18  Tom Tromey  <tom@tromey.com>
4523
4524         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
4525         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
4526         (~dwarf2_per_objfile): Update
4527         (dwarf2_get_dwz_file): Use new.
4528         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
4529         unique_ptr.
4530
4531 2018-05-18  Tom Tromey  <tom@tromey.com>
4532
4533         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
4534         unique_ptr.
4535         * dwarf2read.c (struct dwp_file): Add constructor and
4536         initializers.
4537         (open_and_init_dwp_file): Return a unique_ptr.
4538         (dwarf2_per_objfile, create_dwp_hash_table)
4539         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
4540         (lookup_dwo_unit_in_dwp): Update.
4541         (open_and_init_dwp_file, get_dwp_file): Update.
4542
4543 2018-05-18  Tom Tromey  <tom@tromey.com>
4544
4545         * dwarf2read.c (dwarf2_per_objfile): Update.
4546         (struct mapped_index): Add initializers.
4547         (dwarf2_read_index): Use new.
4548         (dw2_symtab_iter_init): Update.
4549         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
4550         unique_ptr.
4551
4552 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
4553
4554         * dwarf2read.c (mapped_index) <total_size>: Remove.
4555
4556 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
4557
4558         * unittests/format_pieces-selftests.c (test_format_specifier):
4559         Add ARI comments.
4560
4561 2018-05-18  Tom Tromey  <tom@tromey.com>
4562
4563         * c-typeprint.c (maybe_print_hole): New function.
4564         (c_print_type_struct_field_offset): Update.
4565         (c_type_print_base_struct_union): Call maybe_print_hole.
4566
4567 2018-05-17  Keith Seitz  <keiths@redhat.com>
4568
4569         * breakpoint.c (build_bpstat_chain): New function, moved from
4570         bpstat_stop_status.
4571         (bpstat_stop_status): Add optional parameter, `stop_chain'.
4572         If no stop chain is passed, call build_bpstat_chain to build it.
4573         * breakpoint.h (build_bpstat_chain): Declare.
4574         (bpstat_stop_status): Move documentation here from breakpoint.c.
4575         * infrun.c (handle_signal_stop): Before eliding inlined frames,
4576         build the stop chain and pass it to skip_inline_frames.
4577         Pass this stop chain to bpstat_stop_status.
4578         * inline-frame.c: Include breakpoint.h.
4579         (stopped_by_user_bp_inline_frame): New function.
4580         (skip_inline_frames): Add parameter `stop_chain'.
4581         Move documention to inline-frame.h.
4582         If non-NULL, use stopped_by_user_bp_inline_frame to determine
4583         whether the frame should be elided.
4584         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
4585         Add moved documentation and update for new parameter.
4586
4587 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
4588
4589         PR cli/14975
4590         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4591         unittests/format_pieces-selftests.c.
4592         * common/format.h (format_piece) <operator==>: New.
4593         (format_pieces) <operator[]>: Remove.
4594         * common/format.c (format_pieces::format_pieces): Handle \e.
4595         * unittests/format_pieces-selftests.c: New.
4596
4597 2018-05-17  Tom Tromey  <tom@tromey.com>
4598
4599         PR symtab/23010:
4600         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
4601         (dw2_instantiate_symtab): Add skip_partial parameter.
4602         (dw2_find_last_source_symtab, dw2_map_expand_apply)
4603         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
4604         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
4605         (dw2_expand_symtabs_matching_one)
4606         (dw2_find_pc_sect_compunit_symtab)
4607         (dw2_debug_names_lookup_symbol)
4608         (dw2_debug_names_expand_symtabs_for_function): Update.
4609         (init_cutu_and_read_dies): Add skip_partial parameter.
4610         (process_psymtab_comp_unit, build_type_psymtabs_1)
4611         (process_skeletonless_type_unit, load_partial_comp_unit)
4612         (psymtab_to_symtab_1): Update.
4613         (load_full_comp_unit): Add skip_partial parameter.
4614         (process_imported_unit_die, dwarf2_read_addr_index)
4615         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
4616         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
4617         (read_signatured_type): Update.
4618
4619 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
4620
4621         * value.c (release_value): Remove unused variable.
4622         (record_latest_value): Likewise.
4623         (access_value_history): Likewise.
4624         (preserve_values): Likewise.
4625
4626 2018-05-17  Tom Tromey  <tom@tromey.com>
4627
4628         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
4629         Initialize.
4630
4631 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
4632
4633         PR gdb/22286
4634         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
4635         Also handle registers whose width is not a multiple of
4636         PTRACE_TYPE_RET.
4637         (linux_nat_trad_target::store_register): Likewise.
4638
4639 2018-05-16  Tom Tromey  <tom@tromey.com>
4640
4641         * gdbcore.h (core_bfd): Redefine.
4642         * corelow.c (core_target::close): Update.
4643         (core_target_open): Update.
4644         * progspace.h (struct program_space) <cbfd>: Now a
4645         gdb_bfd_ref_ptr.
4646
4647 2018-05-16  Tom Tromey  <tom@tromey.com>
4648
4649         PR cli/19551:
4650         * symfile-add-flags.h (enum symfile_add_flags)
4651         <SYMFILE_NOT_FILENAME>: New constant.
4652         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
4653         objfile name from BFD.
4654         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
4655         * minidebug.c (find_separate_debug_file_in_section): Put
4656         ".gnu_debugdata" into BFD's file name.
4657
4658 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
4659
4660         * regcache.c (regcache_read_ftype, regcache_write_ftype):
4661         Remove.
4662
4663 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
4664
4665         PR binutils/21446
4666         * aarch64-tdep.c (aarch64_analyze_prologue,
4667         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
4668         Indicate not interested in errors.
4669
4670 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
4671
4672         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
4673         Supply the MIPS_ZERO_REGNUM register.
4674
4675 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
4676
4677         * mips-tdep.c (mask_address_var): Make variable static.
4678
4679 2018-05-14  Tom Tromey  <tom@tromey.com>
4680
4681         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
4682
4683 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4684
4685         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
4686         FXSAVE_ADDR for the mxcsr register.
4687
4688 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
4689
4690         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
4691
4692 2018-05-11  Pedro Alves  <palves@redhat.com>
4693
4694         * corelow.c (core_target) <core_target>: No longer inline.
4695         Initialize m_core_gdbarch, m_core_vec and build the section table
4696         here.
4697         <~core_target>: New.
4698         <core_gdbarch, get_core_register_section>: New methods.
4699         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
4700         factored out from ...
4701         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
4702         (core_ops): Delete.
4703         (sniff_core_bfd): Add gdbarch parameter.
4704         (core_close): Delete, merged into ...
4705         (core_target::close): ... here.  Delete self.
4706         (core_close_cleanup): Delete.
4707         (core_target_open): Allocate a core_target on the heap.  Use a
4708         unique_ptr instead of a cleanup.  Bits moved into the core_target
4709         ctor.  Adjust to use core_target methods instead of globals.
4710         (get_core_register_section): Rename to ...
4711         (core_target::get_core_register_section): ... this and adjust.
4712         (struct get_core_registers_cb_data): New.
4713         (get_core_registers_cb): Use it.  Use bool.
4714         (core_target::fetch_registers, core_target::files_info)
4715         (core_target::xfer_partial, core_target::read_description)
4716         (core_target::pid_to, core_target::thread_name): Adjust to
4717         reference class fields instead of globals.
4718         * target.h (struct target_ops_deleter, target_ops_up): New.
4719
4720 2018-05-11  Pedro Alves  <palves@redhat.com>
4721
4722         * corefile.c (core_file_command): Move to corelow.c.
4723         * corelow.c (the_core_target): Delete.
4724         (core_file_command): Moved from corefile.c.  Check exec_bfd
4725         instead of the_core_target.  Use target_detach instead of calling
4726         into the_core_target directly.
4727         (maybe_say_no_core_file_now): New.
4728         (core_target::detach): Use it.
4729         (_initialize_corelow): Remove references to the_core_target.
4730         * gdbcore.h (the_core_target): Delete.
4731
4732 2018-05-11  Tom Tromey  <tromey@redhat.com>
4733             Pedro Alves  <palves@redhat.com>
4734
4735         * corefile.c (core_bfd): Remove.
4736         * gdbcore.h (core_bfd): Now a macro.
4737         * progspace.h (struct program_space) <cbfd>: New field.
4738
4739 2018-05-11  Tom Tromey  <tom@tromey.com>
4740
4741         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
4742         gdb::def_vector.
4743
4744 2018-05-10  Tom Tromey  <tom@tromey.com>
4745
4746         * configure: Rebuild.
4747         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
4748
4749 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
4750
4751         PR server/23158:
4752         * regformats/regdat.sh: Adjust script, following the addition
4753         of the new expedite_regs parameter to init_target_desc.
4754
4755 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
4756
4757         PR gdb/23127
4758         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
4759         set_gdbarch_significant_addr_bit.
4760         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
4761         set_gdbarch_significant_addr_bit.
4762         * utils.c (address_significant): Update to sign extend addr.
4763
4764 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
4765
4766         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
4767         (xtensa_linux_init_abi): Limit tdep->num_regs by
4768         tdep->num_nopriv_regs.
4769         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
4770         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
4771         not initialized.
4772
4773 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
4774
4775         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
4776
4777 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
4780         (I387_MXCSR_INIT_VAL): New constant.
4781         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
4782         buffer if it was supplied by the inferior.
4783         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
4784         (i387_xsave_get_clear_bv): New function.
4785         (i387_supply_xsave): Only read x87 control registers from the
4786         xsave buffer if the feature is enabled, and the state will have
4787         been written, otherwise, provide a suitable default.
4788         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
4789         including x87 control registers.  Update control registers if they
4790         have changed from the default value, and mark features as enabled
4791         as required.
4792         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
4793
4794 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
4795
4796         * spu-tdep.c (info_spu_event_command): Fix output formatting.
4797
4798 2018-05-07  Tom Tromey  <tom@tromey.com>
4799
4800         * configure: Rebuild.
4801         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
4802
4803 2018-05-07  Tom Tromey  <tom@tromey.com>
4804
4805         PR tdep/20362:
4806         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
4807         bit.  Use correct value for VDIV.
4808
4809 2018-05-04  Tom Tromey  <tom@tromey.com>
4810
4811         * configure: Rebuild.
4812         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
4813
4814 2018-05-04  Tom Tromey  <tom@tromey.com>
4815
4816         * linux-record.c (record_linux_system_call) <case
4817         RECORD_SYS_RECVFROM>: Add "break".
4818
4819 2018-05-04  Tom Tromey  <tom@tromey.com>
4820
4821         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
4822         Add missing "break".
4823         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
4824         Add missing "break".
4825
4826 2018-05-04  Tom Tromey  <tom@tromey.com>
4827
4828         * rs6000-tdep.c (ppc_process_record_op4)
4829         (ppc_process_record_op63): Add fall-through comment.
4830
4831 2018-05-04  Tom Tromey  <tom@tromey.com>
4832
4833         * i386-tdep.c (i386_process_record): Add fall-through comment.
4834
4835 2018-05-04  Tom Tromey  <tom@tromey.com>
4836
4837         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
4838         comment.
4839
4840 2018-05-04  Tom Tromey  <tom@tromey.com>
4841
4842         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
4843         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
4844         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
4845         comment.
4846         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
4847         comment.
4848         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
4849         comment.
4850
4851 2018-05-04  Tom Tromey  <tom@tromey.com>
4852
4853         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
4854
4855 2018-05-04  Tom Tromey  <tom@tromey.com>
4856
4857         * s390-tdep.c (s390_process_record): Fix fall-through comments.
4858         * xcoffread.c (scan_xcoff_symtab): Move comment later.
4859         * symfile.c (section_is_mapped): Fix fall-through comment.
4860         * stabsread.c (define_symbol, read_member_functions): Fix
4861         fall-through comment.
4862         * s390-linux-tdep.c (s390_process_record): Fix fall-through
4863         comment.
4864         * remote.c (remote_wait_as): Fix fall-through comment.
4865         * p-exp.y (yylex): Fix fall-through comment.
4866         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
4867         comment.
4868         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
4869         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
4870         * jv-exp.y (yylex): Fix fall-through comment.
4871         * go-exp.y (lex_one_token): Fix fall-through comment.
4872         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
4873         fall-through comment.
4874         * f-exp.y (yylex): Fix fall-through comment.
4875         * dwarf2read.c (process_die): Fix fall-through comments.
4876         * dbxread.c (process_one_symbol): Fix fall-through comment.
4877         * d-exp.y (lex_one_token): Fix fall-through comment.
4878         * cp-name-parser.y (yylex): Fix fall-through comment.
4879         * coffread.c (coff_symtab_read): Fix fall-through comment.
4880         * c-exp.y (lex_one_token): Fix fall-through comment.
4881         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
4882         comment.
4883         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
4884         comment.
4885
4886 2018-05-04  Tom Tromey  <tom@tromey.com>
4887
4888         PR python/22730:
4889         * NEWS: Mention gdb.execute change.
4890         * gdbcmd.h (execute_control_command): Don't declare.
4891         * python/python.c (execute_gdb_command): Use read_command_lines_1,
4892         execute_control_commands, execute_control_commands_to_string.
4893         * cli/cli-script.h (execute_control_commands)
4894         (execute_control_commands_to_string): Declare.
4895         (execute_control_command): Add from_tty parameter.
4896         * cli/cli-script.c (execute_control_commands)
4897         (execute_control_commands_to_string): New functions.
4898         (execute_user_command): Use execute_control_commands.
4899         (execute_control_command_1): Add "from_tty" parameter.  Update.
4900         (execute_control_command): Likewise.
4901
4902 2018-05-04  Tom Tromey  <tom@tromey.com>
4903
4904         PR python/22731:
4905         * NEWS: Mention that breakpoint commands are writable.
4906         * python/py-breakpoint.c (bppy_set_commands): New function.
4907         (breakpoint_object_getset) <"commands">: Use it.
4908
4909 2018-05-04  Tom Tromey  <tom@tromey.com>
4910
4911         * tracepoint.c (actions_command): Update.
4912         * mi/mi-cmd-break.c (mi_command_line_array)
4913         (mi_command_line_array_cnt, mi_command_line_array_ptr)
4914         (mi_read_next_line): Remove.
4915         (mi_cmd_break_commands): Update.
4916         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
4917         function_view.
4918         * cli/cli-script.c (get_command_line): Update.
4919         (process_next_line): Use function_view.  Constify.
4920         (recurse_read_control_structure, read_command_lines)
4921         (read_command_lines_1): Change argument types to function_view.
4922         (do_define_command, document_command): Update.
4923         * breakpoint.h (check_tracepoint_command): Don't declare.
4924         * breakpoint.c (check_tracepoint_command): Remove.
4925         (commands_command_1, create_tracepoint_from_upload): Update.
4926
4927 2018-05-04  Tom Tromey  <tom@tromey.com>
4928
4929         PR gdb/11750:
4930         * cli/cli-script.h (enum command_control_type) <define_control>:
4931         New constant.
4932         * cli/cli-script.c (multi_line_command_p): Handle define_control.
4933         (build_command_line, execute_control_command_1)
4934         (process_next_line): Likewise.
4935         (do_define_command): New function, extracted from define_command.
4936         (define_command): Use it.
4937
4938 2018-05-04  Tom Tromey  <tom@tromey.com>
4939
4940         * tracepoint.c (actions_command): Update.
4941         * cli/cli-script.h (read_command_lines): Update.
4942         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
4943         (MAX_TMPBUF): Remove define.
4944         (define_command): Use string_printf.
4945         (document_command): Likewise.
4946         * breakpoint.c (commands_command_1): Update.
4947
4948 2018-05-04  Tom Tromey  <tom@tromey.com>
4949
4950         * top.c (execute_command): Update.
4951         * cli/cli-script.h (print_command_lines): Now varargs.
4952         * cli/cli-script.c (print_command_lines): Now varargs.
4953         (execute_control_command_1) <case while_control, case if_control>:
4954         Update.
4955
4956 2018-05-04  Tom Tromey  <tom@tromey.com>
4957
4958         * tracepoint.c (all_tracepoint_actions): Rename from
4959         all_tracepoint_actions_and_cleanup.  Change return type.
4960         (actions_command, encode_actions_1, encode_actions)
4961         (trace_dump_actions, tdump_command): Update.
4962         * remote.c (remote_download_command_source): Update.
4963         * python/python.c (gdbpy_eval_from_control_command)
4964         (python_command, python_interactive_command): Update.
4965         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
4966         * guile/guile.c (guile_command)
4967         (gdbscm_eval_from_control_command, guile_command): Update.
4968         * compile/compile.c (compile_code_command)
4969         (compile_print_command, compile_to_object): Update.
4970         * cli/cli-script.h (struct command_lines_deleter): New.
4971         (counted_command_line): New typedef.
4972         (struct command_line): Add constructor, destructor.
4973         <body_list>: Remove.
4974         <body_list_0, body_list_1>: New members.
4975         (command_line_up): Remove typedef.
4976         (read_command_lines, read_command_lines_1, get_command_line):
4977         Update.
4978         (copy_command_lines): Don't declare.
4979         * cli/cli-script.c (build_command_line): Use "new".
4980         (get_command_line): Return counted_command_line.
4981         (print_command_lines, execute_user_command)
4982         (execute_control_command_1, while_command, if_command): Update.
4983         (realloc_body_list): Remove.
4984         (process_next_line, recurse_read_control_structure): Update.
4985         (read_command_lines, read_command_lines_1): Return counted_command_line.
4986         (free_command_lines): Use "delete".
4987         (copy_command_lines): Remove.
4988         (define_command, document_command, show_user_1): Update.
4989         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
4990         a counted_command_line.
4991         * breakpoint.h (counted_command_line): Remove typedef.
4992         (breakpoint_set_commands): Update.
4993         * breakpoint.c (check_no_tracepoint_commands)
4994         (validate_commands_for_breakpoint): Update.
4995         (breakpoint_set_commands): Change commands to be a
4996         counted_command_line.
4997         (commands_command_1, update_dprintf_command_list)
4998         (create_tracepoint_from_upload): Update.
4999
5000 2018-05-04  Tom Tromey  <tom@tromey.com>
5001
5002         * cli/cli-decode.h (cmd_list_element): New constructor.
5003         (~cmd_list_element): New destructor.
5004         (struct cmd_list_element): Add initializers.
5005         * cli/cli-decode.c (do_add_cmd): Use "new".
5006         (delete_cmd): Use "delete".
5007
5008 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
5009             Pedro Alves <palves@redhat.com>
5010
5011         PR breakpoints/19806 and support for PR external/20207.
5012         * NEWS: Mention Aarch64 watchpoint improvements.
5013         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
5014         watchpoints and PR external/20207 watchpoints.
5015         * nat/aarch64-linux-hw-point.c
5016         (kernel_supports_any_contiguous_range): New.
5017         (aarch64_watchpoint_offset): New.
5018         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
5019         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
5020         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
5021         (aarch64_align_watchpoint): New parameters aligned_offset_p and
5022         next_addr_orig_p.  Support PR external/20207 watchpoints.
5023         (aarch64_downgrade_regs): New.
5024         (aarch64_dr_state_insert_one_point): New parameters offset and
5025         addr_orig.
5026         (aarch64_dr_state_remove_one_point): Likewise.
5027         (aarch64_handle_breakpoint): Update caller.
5028         (aarch64_handle_aligned_watchpoint): Likewise.
5029         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
5030         aligned_offset.
5031         (aarch64_linux_set_debug_regs): Remove const from state.  Call
5032         aarch64_downgrade_regs.
5033         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
5034         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
5035         (DR_CONTROL_MASK): ... this.
5036         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
5037         (unsigned int aarch64_watchpoint_offset): New prototype.
5038         (aarch64_linux_set_debug_regs): Remove const from state.
5039         * utils.c (align_up, align_down): Move to ...
5040         * common/common-utils.c (align_up, align_down): ... here.
5041         * utils.h (align_up, align_down): Move to ...
5042         * common/common-utils.h (align_up, align_down): ... here.
5043
5044 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
5045
5046         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
5047         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
5048         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
5049         Re-implement to match the ABI as summarized in GCC's
5050         gcc/config/sparc/sparc.c.  All callers updated.
5051         (sparc32_store_arguments): Remove assertion.
5052
5053 2018-05-04  Tom Tromey  <tom@tromey.com>
5054
5055         * printcmd.c: Don't include tui.h.
5056         (decode_format): Use skip_spaces.
5057
5058 2018-05-04  Tom Tromey  <tom@tromey.com>
5059
5060         PR gdb/22619:
5061         * printcmd.c (last_count): New global.
5062         (x_command): Use saved count when repeating.
5063
5064 2018-05-04  Tom Tromey  <tom@tromey.com>
5065
5066         * nto-procfs.c (do_closedir_cleanup): Remove.
5067         (procfs_pidlist): Use gdb_dir_up.
5068         * procfs.c (do_closedir_cleanup): Remove.
5069         (proc_update_threads): Use gdb_dir_up.
5070         * common/filestuff.h (struct gdb_dir_deleter): New.
5071         (gdb_dir_up): New typedef.
5072
5073 2018-05-04  Tom Tromey  <tom@tromey.com>
5074
5075         * ada-lang.c (print_mention_exception): Use std::string.
5076
5077 2018-05-04  Tom Tromey  <tom@tromey.com>
5078
5079         * ada-lang.c (create_excep_cond_exprs): Update.
5080         (ada_exception_catchpoint_cond_string): Use std::string.
5081
5082 2018-05-04  Tom Tromey  <tom@tromey.com>
5083
5084         * ada-lang.c (xget_renaming_scope): Return std::string.
5085         (old_renaming_is_invisible): Update.
5086
5087 2018-05-04  Tom Tromey  <tom@tromey.com>
5088
5089         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
5090         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
5091
5092 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
5093
5094         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
5095
5096 2018-05-04  Tom Tromey  <tom@tromey.com>
5097
5098         * remote.c (remote_query_supported_append): Change type.
5099         (remote_check_symbols): Update.
5100
5101 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
5102
5103         PR gdb/11420
5104         * configure.ac: Prepend libpython.
5105         * python/python-config.py: Likewise.
5106         * configure: Regenerate.
5107
5108 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
5109
5110         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
5111
5112 2018-05-03  Pedro Alves  <palves@redhat.com>
5113
5114         * s390-linux-nat.c
5115         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
5116         override.  Write 'true' instead of '1'.
5117         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
5118         declaration.
5119
5120 2018-05-02  Pedro Alves  <palves@redhat.com>
5121
5122         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
5123         add_inf_child_target.
5124         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
5125         add_inf_child_target.
5126         * aix-thread.c (aix_thread_target_info): New.
5127         (aix_thread_target) <shortname, longname, doc>: Delete.
5128         <info>: New.
5129         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
5130         add_inf_child_target.
5131         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
5132         add_inf_child_target.
5133         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
5134         add_inf_child_target.
5135         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
5136         add_inf_child_target.
5137         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
5138         add_inf_child_target.
5139         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
5140         add_inf_child_target.
5141         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
5142         add_inf_child_target.
5143         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
5144         add_inf_child_target.
5145         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
5146         add_inf_child_target.
5147         * bfd-target.c (target_bfd_target_info): New.
5148         (target_bfd) <shortname, longname, doc>: Delete.
5149         <info>: New.
5150         * bsd-kvm.c (bsd_kvm_target_info): New.
5151         (bsd_kvm_target) <shortname, longname, doc>: Delete.
5152         <info>: New.
5153         (bsd_kvm_target::open): Rename to ...
5154         (bsd_kvm_target_open): ... this.  Adjust.
5155         * bsd-uthread.c (bsd_uthread_target_info): New.
5156         (bsd_uthread_target) <shortname, longname, doc>: Delete.
5157         <info>: New.
5158         * corefile.c (core_file_command): Adjust.
5159         * corelow.c (core_target_info): New.
5160         (core_target) <shortname, longname, doc>: Delete.
5161         <info>: New.
5162         (core_target::open): Rename to ...
5163         (core_target_open): ... this.  Adjust.
5164         * ctf.c (ctf_target_info): New.
5165         (ctf_target) <shortname, longname, doc>: Delete.
5166         <info>: New.
5167         (ctf_target::open): Rename to ...
5168         (ctf_target_open): ... this.
5169         (_initialize_ctf): Adjust.
5170         * exec.c (exec_target_info): New.
5171         (exec_target) <shortname, longname, doc>: Delete.
5172         <info>: New.
5173         (exec_target::open): Rename to ...
5174         (exec_target_open): ... this.
5175         * gdbcore.h (core_target_open): Declare.
5176         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
5177         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
5178         add_inf_child_target.
5179         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
5180         add_inf_child_target.
5181         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
5182         add_inf_child_target.
5183         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
5184         add_inf_child_target.
5185         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
5186         add_inf_child_target.
5187         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
5188         add_inf_child_target.
5189         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
5190         add_inf_child_target.
5191         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
5192         add_inf_child_target.
5193         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
5194         add_inf_child_target.
5195         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
5196         add_inf_child_target.
5197         * inf-child.c (inf_child_target_info): New.
5198         (inf_child_target::info): New.
5199         (inf_child_open_target): Remove 'target' parameter.  Use
5200         get_native_target instead.
5201         (inf_child_target::open): Delete.
5202         (add_inf_child_target): New.
5203         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
5204         Delete.
5205         <info>: New.
5206         (add_inf_child_target): Declare.
5207         (inf_child_open_target): Declare.
5208         * linux-thread-db.c (thread_db_target_info): New.
5209         (thread_db_target) <shortname, longname, doc>: Delete.
5210         <info>: New.
5211         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
5212         add_inf_child_target.
5213         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
5214         add_inf_child_target.
5215         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
5216         add_inf_child_target.
5217         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
5218         add_inf_child_target.
5219         * make-target-delegates (print_class): Adjust.
5220         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
5221         add_inf_child_target.
5222         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
5223         add_inf_child_target.
5224         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
5225         add_inf_child_target.
5226         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
5227         add_inf_child_target.
5228         * nto-procfs.c (nto_native_target_info): New.
5229         (nto_procfs_target_native) <shortname, longname, doc>:
5230         Delete.
5231         <info>: New.
5232         (nto_procfs_target_info): New.
5233         (nto_procfs_target_procfs) <shortname, longname, doc>:
5234         Delete.
5235         <info>: New.
5236         (init_procfs_targets): Adjust.
5237         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
5238         add_inf_child_target.
5239         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
5240         add_inf_child_target.
5241         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
5242         add_inf_child_target.
5243         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
5244         add_inf_child_target.
5245         * ravenscar-thread.c (ravenscar_target_info): New.
5246         (ravenscar_thread_target) <shortname, longname, doc>:
5247         Delete.
5248         <info>: New.
5249         * record-btrace.c (record_btrace_target_info):
5250         (record_btrace_target) <shortname, longname, doc>: Delete.
5251         <info>: New.
5252         (record_btrace_target::open): Rename to ...
5253         (record_btrace_target_open): ... this.  Adjust.
5254         * record-full.c (record_longname, record_doc): New.
5255         (record_full_base_target) <shortname, longname, doc>: Delete.
5256         <info>: New.
5257         (record_full_target_info): New.
5258         (record_full_target): <shortname>: Delete.
5259         <info>: New.
5260         (record_full_core_open_1, record_full_open_1): Update comments.
5261         (record_full_base_target::open): Rename to ...
5262         (record_full_open): ... this.
5263         (cmd_record_full_restore): Update.
5264         (_initialize_record_full): Update.
5265         * remote-sim.c (remote_sim_target_info): New.
5266         (gdbsim_target) <shortname, longname, doc>: Delete.
5267         <info>: New.
5268         (gdbsim_target::open): Rename to ...
5269         (gdbsim_target_open): ... this.
5270         (_initialize_remote_sim): Adjust.
5271         * remote.c (remote_doc): New.
5272         (remote_target_info): New.
5273         (remote_target) <shortname, longname, doc>: Delete.
5274         <info>: New.
5275         (extended_remote_target_info): New.
5276         (extended_remote_target) <shortname, longname, doc>: Delete.
5277         <info>: New.
5278         (remote_target::open_1): Make static.  Adjust.
5279         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
5280         * s390-linux-nat.c (_initialize_s390_nat): Use
5281         add_inf_child_target.
5282         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
5283         add_inf_child_target.
5284         * sol-thread.c (thread_db_target_info): New.
5285         (sol_thread_target) <shortname, longname, doc>: Delete.
5286         <info>: New.
5287         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
5288         add_inf_child_target.
5289         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
5290         add_inf_child_target.
5291         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
5292         add_inf_child_target.
5293         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
5294         add_inf_child_target.
5295         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
5296         add_inf_child_target.
5297         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
5298         add_inf_child_target.
5299         * spu-linux-nat.c (_initialize_spu_nat): Use
5300         add_inf_child_target.
5301         * spu-multiarch.c (spu_multiarch_target_info): New.
5302         (spu_multiarch_target) <shortname, longname, doc>: Delete.
5303         <info>: New.
5304         * target-delegates.c: Regenerate.
5305         * target.c: Include <unordered_map>.
5306         (target_ops_p): Delete.
5307         (DEF_VEC_P(target_ops_p)): Delete.
5308         (target_factories): New.
5309         (test_target_info): New.
5310         (test_target_ops::info): New.
5311         (open_target): Adjust to use target_factories.
5312         (add_target_with_completer): Rename to ...
5313         (add_target): ... this.  Change prototype.  Register target_info
5314         and open callback in target_factories.  Register target_info in
5315         command context instead of target_ops.
5316         (add_target): Delete old implementation.
5317         (add_deprecated_target_alias): Change prototype.  Adjust.
5318         (the_native_target): New.
5319         (set_native_target, get_native_target): New.
5320         (find_default_run_target): Use the_native_target.
5321         (find_attach_target, find_run_target): Simplify.
5322         (target_ops::open): Delete.
5323         (dummy_target_info): New.
5324         (dummy_target::shortname, dummy_target::longname)
5325         (dummy_target::doc): Delete.
5326         (dummy_target::info): New.
5327         (debug_target::shortname, debug_target::longname)
5328         (debug_target::doc): Delete.
5329         (debug_target::info): New.
5330         * target.h (struct target_info): New.
5331         (target_ops::~target_ops): Add comment.
5332         (target_ops::info): New.
5333         (target_ops::shortname, target_ops::longname, target_ops::doc): No
5334         longer virtual.  Implement in terms of target_info.
5335         (set_native_target, get_native_target): Declare.
5336         (target_open_ftype): New.
5337         (add_target, add_target_with_completer)
5338         (add_deprecated_target_alias): Change prototype.
5339         (test_target) <shortname, longname, doc>: Delete.
5340         <info>: New.
5341         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
5342         add_inf_child_target.
5343         * tracefile-tfile.c (tfile_target_info): New.
5344         (tfile_target) <shortname, longname, doc>: Delete.
5345         <info>: New.
5346         (tfile_target::open): Rename to ...
5347         (tfile_target_open): ... this.
5348         (_initialize_tracefile_tfile): Adjust.
5349         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
5350         add_inf_child_target.
5351         * windows-nat.c (_initialize_windows_nat): Use
5352         add_inf_child_target.
5353         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
5354         add_inf_child_target.
5355
5356 2018-05-02  Pedro Alves  <palves@redhat.com>
5357
5358         * linux-nat.h (linux_nat_target) <low_new_thread,
5359         low_delete_thread, low_new_fork, low_forget_process,
5360         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
5361         New virtual methods.
5362         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
5363         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
5364         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
5365         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
5366         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
5367         Delete.
5368         * linux-fork.c (delete_fork): Adjust to call low method.
5369         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
5370         (linux_nat_new_fork, linux_nat_forget_process_hook)
5371         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
5372         (linux_nat_status_is_event):
5373         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
5374         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
5375         to call low method.
5376         (sigtrap_is_event): Rename to ...
5377         (linux_nat_target::low_status_is_event): ... this.
5378         (linux_nat_set_status_is_event): Delete.
5379         (save_stop_reason, linux_nat_wait_1)
5380         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
5381         low methods.
5382         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
5383         (linux_nat_set_new_fork, linux_nat_set_forget_process)
5384         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
5385         (linux_nat_set_prepare_to_resume): Delete.
5386         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
5387         low virtual methods.
5388         * amd64-linux-nat.c: Likewise.
5389         * arm-linux-nat.c: Likewise.
5390         * i386-linux-nat.c: Likewise.
5391         * ia64-linux-nat.c: Likewise.
5392         * mips-linux-nat.c: Likewise.
5393         * ppc-linux-nat.c: Likewise.
5394         * s390-linux-nat.c: Likewise.
5395         * sparc64-linux-nat.c: Likewise.
5396         * x86-linux-nat.c: Likewise.
5397         * x86-linux-nat.h: Include "nat/x86-linux.h".
5398         (x86_linux_nat_target) <low_new_fork, low_forget_process,
5399         low_prepare_to_resume, low_new_thread, low_delete_thread>:
5400         Override methods.
5401
5402 2018-05-02  Pedro Alves  <palves@redhat.com>
5403
5404         * target.h (target_ops)
5405         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
5406         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
5407         stopped_by_watchpoint, have_continuable_watchpoint,
5408         stopped_data_address, watchpoint_addr_within_range,
5409         can_accel_watchpoint_condition, can_run, thread_alive,
5410         has_all_memory, has_memory, has_stack, has_registers,
5411         has_execution, can_async_p, is_async_p, supports_non_stop,
5412         always_non_stop_p, can_execute_reverse, supports_multi_process,
5413         supports_enable_disable_tracepoint,
5414         supports_disable_randomization, supports_string_tracing,
5415         supports_evaluation_of_breakpoint_conditions,
5416         can_run_breakpoint_commands, filesystem_is_local,
5417         can_download_tracepoint, get_trace_state_variable_value,
5418         set_trace_notes, get_tib_address, use_agent, can_use_agent,
5419         record_is_replaying, record_will_replay,
5420         augmented_libraries_svr4_read>: Adjust to return bool.
5421         * aarch64-linux-nat.c: All implementations adjusted.
5422         * aix-thread.c: All implementations adjusted.
5423         * arm-linux-nat.c: All implementations adjusted.
5424         * breakpoint.c: All implementations adjusted.
5425         * bsd-kvm.c: All implementations adjusted.
5426         * bsd-uthread.c: All implementations adjusted.
5427         * corelow.c: All implementations adjusted.
5428         * ctf.c: All implementations adjusted.
5429         * darwin-nat.c: All implementations adjusted.
5430         * darwin-nat.h: All implementations adjusted.
5431         * exec.c: All implementations adjusted.
5432         * fbsd-nat.c: All implementations adjusted.
5433         * fbsd-nat.h: All implementations adjusted.
5434         * gnu-nat.c: All implementations adjusted.
5435         * gnu-nat.h: All implementations adjusted.
5436         * go32-nat.c: All implementations adjusted.
5437         * ia64-linux-nat.c: All implementations adjusted.
5438         * inf-child.c: All implementations adjusted.
5439         * inf-child.h: All implementations adjusted.
5440         * inf-ptrace.c: All implementations adjusted.
5441         * inf-ptrace.h: All implementations adjusted.
5442         * linux-nat.c: All implementations adjusted.
5443         * linux-nat.h: All implementations adjusted.
5444         * mips-linux-nat.c: All implementations adjusted.
5445         * nto-procfs.c: All implementations adjusted.
5446         * ppc-linux-nat.c: All implementations adjusted.
5447         * procfs.c: All implementations adjusted.
5448         * ravenscar-thread.c: All implementations adjusted.
5449         * record-btrace.c: All implementations adjusted.
5450         * record-full.c: All implementations adjusted.
5451         * remote-sim.c: All implementations adjusted.
5452         * remote.c: All implementations adjusted.
5453         * s390-linux-nat.c: All implementations adjusted.
5454         * sol-thread.c: All implementations adjusted.
5455         * spu-multiarch.c: All implementations adjusted.
5456         * target-delegates.c: All implementations adjusted.
5457         * target.c: All implementations adjusted.
5458         * target.h: All implementations adjusted.
5459         * tracefile-tfile.c: All implementations adjusted.
5460         * tracefile.c: All implementations adjusted.
5461         * tracefile.h: All implementations adjusted.
5462         * windows-nat.c: All implementations adjusted.
5463         * x86-linux-nat.h: All implementations adjusted.
5464         * x86-nat.h: All implementations adjusted.
5465
5466 2018-05-02  Pedro Alves  <palves@redhat.com>
5467
5468         * make-target-delegates (scan_target_h): Don't trim lines here.
5469         Replace sequences of tabs and/or whitespace with a single
5470         whitespace.
5471         (top level, parsing methods): Trim each line before processing it
5472         here.
5473
5474 2018-05-02  Pedro Alves  <palves@redhat.com>
5475             John Baldwin  <jhb@freebsd.org>
5476
5477         * target.h (enum strata) <debug_stratum>: New.
5478         (struct target_ops) <all delegation methods>: Replace by C++
5479         virtual methods, and drop "to_" prefix.  All references updated
5480         throughout.
5481         <to_shortname, to_longname, to_doc, to_data,
5482         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
5483         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
5484         virtual methods.  All references updated throughout.
5485         <can_attach, supports_terminal_ours, can_create_inferior,
5486         get_thread_control_capabilities, attach_no_wait>: New
5487         virtual methods.
5488         <insert_breakpoint, remove_breakpoint>: Now
5489         TARGET_DEFAULT_NORETURN methods.
5490         <info_proc>: Now returns bool.
5491         <to_magic>: Delete.
5492         (OPS_MAGIC): Delete.
5493         (current_target): Delete.  All references replaced by references
5494         to ...
5495         (target_stack): ... this.  New.
5496         (target_shortname, target_longname): Adjust.
5497         (target_can_run): Now a function declaration.
5498         (default_child_has_all_memory, default_child_has_memory)
5499         (default_child_has_stack, default_child_has_registers)
5500         (default_child_has_execution): Remove target_ops parameter.
5501         (complete_target_initialization): Delete.
5502         (memory_breakpoint_target): New template class.
5503         (test_target_ops): Refactor as a C++ class with virtual methods.
5504         * make-target-delegates (NAME_PART): Tighten.
5505         (POINTER_PART, CP_SYMBOL): New.
5506         (SIMPLE_RETURN_PART): Reimplement.
5507         (VEC_RETURN_PART): Expect less.
5508         (RETURN_PART, VIRTUAL_PART): New.
5509         (METHOD): Adjust to C++ virtual methods.
5510         (scan_target_h): Remove reference to C99.
5511         (dname): Output "target_ops::" prefix.
5512         (write_function_header): Adjust to output a C++ class method.
5513         (write_declaration): New.
5514         (write_delegator): Adjust to output a C++ class method.
5515         (tdname): Output "dummy_target::" prefix.
5516         (write_tdefault, write_debugmethod): Adjust to output a C++ class
5517         method.
5518         (tdefault_names, debug_names): Delete.
5519         (return_types, tdefaults, styles, argtypes_array): New.
5520         (top level): All methods are delegators.
5521         (print_class): New.
5522         (top level): Print dummy_target and debug_target classes.
5523         * target-delegates.c: Regenerate.
5524         * target-debug.h (target_debug_print_enum_info_proc_what)
5525         (target_debug_print_thread_control_capabilities)
5526         (target_debug_print_thread_info_p): New.
5527         * target.c (dummy_target): Delete.
5528         (the_dummy_target, the_debug_target): New.
5529         (target_stack): Now extern.
5530         (set_targetdebug): Push/unpush debug target.
5531         (default_child_has_all_memory, default_child_has_memory)
5532         (default_child_has_stack, default_child_has_registers)
5533         (default_child_has_execution): Remove target_ops parameter.
5534         (complete_target_initialization): Delete.
5535         (add_target_with_completer): No longer call
5536         complete_target_initialization.
5537         (target_supports_terminal_ours): Use regular delegation.
5538         (update_current_target): Delete.
5539         (push_target): No longer check magic number.  Don't call
5540         update_current_target.
5541         (unpush_target): Don't call update_current_target.
5542         (target_is_pushed): No longer check magic number.
5543         (target_require_runnable): Skip for all stratums over
5544         process_stratum.
5545         (target_ops::info_proc): New.
5546         (target_info_proc): Use find_target_at and
5547         find_default_run_target.
5548         (target_supports_disable_randomization): Use regular delegation.
5549         (target_get_osdata): Use find_target_at.
5550         (target_ops::open, target_ops::close, target_ops::can_attach)
5551         (target_ops::attach, target_ops::can_create_inferior)
5552         (target_ops::create_inferior, target_ops::can_run)
5553         (target_can_run): New.
5554         (default_fileio_target): Use regular delegation.
5555         (target_ops::fileio_open, target_ops::fileio_pwrite)
5556         (target_ops::fileio_pread, target_ops::fileio_fstat)
5557         (target_ops::fileio_close, target_ops::fileio_unlink)
5558         (target_ops::fileio_readlink): New.
5559         (target_fileio_open_1, target_fileio_unlink)
5560         (target_fileio_readlink): Always call the target method.  Handle
5561         FILEIO_ENOSYS.
5562         (return_zero, return_zero_has_execution): Delete.
5563         (init_dummy_target): Delete.
5564         (dummy_target::dummy_target, dummy_target::shortname)
5565         (dummy_target::longname, dummy_target::doc)
5566         (debug_target::debug_target, debug_target::shortname)
5567         (debug_target::longname, debug_target::doc): New.
5568         (target_supports_delete_record): Use regular delegation.
5569         (setup_target_debug): Delete.
5570         (maintenance_print_target_stack): Skip debug_stratum.
5571         (initialize_targets): Instantiate the_dummy_target and
5572         the_debug_target.
5573         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
5574         use target_stack.
5575         (target_auxv_search, fprint_target_auxv): Adjust.
5576         (info_auxv_command): Adjust to use target_stack.
5577         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
5578         * exceptions.c (print_flush): Handle a NULL target_stack.
5579         * regcache.c (target_ops_no_register): Refactor as class with
5580         virtual methods.
5581
5582         * exec.c (exec_target): New class.
5583         (exec_ops): Now an exec_target.
5584         (exec_open, exec_close_1, exec_get_section_table)
5585         (exec_xfer_partial, exec_files_info, exec_has_memory)
5586         (exec_make_note_section): Refactor as exec_target methods.
5587         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
5588         Delete.
5589         (exec_target::find_memory_regions): New.
5590         (_initialize_exec): Don't call init_exec_ops.
5591         * gdbcore.h (exec_file_clear): Delete.
5592
5593         * corefile.c (core_target): Delete.
5594         (core_file_command): Adjust.
5595         * corelow.c (core_target): New class.
5596         (the_core_target): New.
5597         (core_close): Remove target_ops parameter.
5598         (core_close_cleanup): Adjust.
5599         (core_target::close): New.
5600         (core_open, core_detach, get_core_registers, core_files_info)
5601         (core_xfer_partial, core_thread_alive, core_read_description)
5602         (core_pid_to_str, core_thread_name, core_has_memory)
5603         (core_has_stack, core_has_registers, core_info_proc): Rework as
5604         core_target methods.
5605         (ignore, core_remove_breakpoint, init_core_ops): Delete.
5606         (_initialize_corelow): Initialize the_core_target.
5607         * gdbcore.h (core_target): Delete.
5608         (the_core_target): New.
5609
5610         * ctf.c: (ctf_target): New class.
5611         (ctf_ops): Now a ctf_target.
5612         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
5613         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
5614         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
5615         methods.
5616         (init_ctf_ops): Delete.
5617         (_initialize_ctf): Don't call it.
5618         * tracefile-tfile.c (tfile_target): New class.
5619         (tfile_ops): Now a tfile_target.
5620         (tfile_open, tfile_close, tfile_files_info)
5621         (tfile_get_tracepoint_status, tfile_trace_find)
5622         (tfile_fetch_registers, tfile_xfer_partial)
5623         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
5624         Refactor as tfile_target methods.
5625         (tfile_xfer_partial_features): Remove target_ops parameter.
5626         (init_tfile_ops): Delete.
5627         (_initialize_tracefile_tfile): Don't call it.
5628         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
5629         (tracefile_has_stack, tracefile_has_registers)
5630         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
5631         tracefile_target methods.
5632         (init_tracefile_ops): Delete.
5633         (tracefile_target::tracefile_target): New.
5634         * tracefile.h: Include "target.h".
5635         (tracefile_target): New class.
5636         (init_tracefile_ops): Delete.
5637
5638         * spu-multiarch.c (spu_multiarch_target): New class.
5639         (spu_ops): Now a spu_multiarch_target.
5640         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
5641         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
5642         (spu_search_memory, spu_mourn_inferior): Refactor as
5643         spu_multiarch_target methods.
5644         (init_spu_ops): Delete.
5645         (_initialize_spu_multiarch): Remove references to init_spu_ops,
5646         complete_target_initialization.
5647
5648         * ravenscar-thread.c (ravenscar_thread_target): New class.
5649         (ravenscar_ops): Now a ravenscar_thread_target.
5650         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
5651         (ravenscar_thread_alive, ravenscar_pid_to_str)
5652         (ravenscar_fetch_registers, ravenscar_store_registers)
5653         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
5654         (ravenscar_stopped_by_hw_breakpoint)
5655         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
5656         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
5657         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
5658         methods.
5659         (init_ravenscar_thread_ops): Delete.
5660         (_initialize_ravenscar): Remove references to
5661         init_ravenscar_thread_ops and complete_target_initialization.
5662
5663         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
5664         (bsd_uthread_target): New class.
5665         (bsd_uthread_ops): Now a bsd_uthread_target.
5666         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
5667         (bsd_uthread_close, bsd_uthread_mourn_inferior)
5668         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
5669         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
5670         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
5671         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
5672         (bsd_uthread_target): Delete function.
5673         (_initialize_bsd_uthread): Remove reference to
5674         complete_target_initialization.
5675
5676         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
5677         (target_bfd): ... this new class.
5678         (target_bfd_xfer_partial, target_bfd_get_section_table)
5679         (target_bfd_close): Refactor as target_bfd methods.
5680         (target_bfd::~target_bfd): New.
5681         (target_bfd_reopen): Adjust.
5682         (target_bfd::close): New.
5683
5684         * record-btrace.c (record_btrace_target): New class.
5685         (record_btrace_ops): Now a record_btrace_target.
5686         (record_btrace_open, record_btrace_stop_recording)
5687         (record_btrace_disconnect, record_btrace_close)
5688         (record_btrace_async, record_btrace_info)
5689         (record_btrace_insn_history, record_btrace_insn_history_range)
5690         (record_btrace_insn_history_from, record_btrace_call_history)
5691         (record_btrace_call_history_range)
5692         (record_btrace_call_history_from, record_btrace_record_method)
5693         (record_btrace_is_replaying, record_btrace_will_replay)
5694         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
5695         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
5696         (record_btrace_store_registers, record_btrace_prepare_to_store)
5697         (record_btrace_to_get_unwinder)
5698         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
5699         (record_btrace_commit_resume, record_btrace_wait)
5700         (record_btrace_stop, record_btrace_can_execute_reverse)
5701         (record_btrace_stopped_by_sw_breakpoint)
5702         (record_btrace_supports_stopped_by_sw_breakpoint)
5703         (record_btrace_stopped_by_hw_breakpoint)
5704         (record_btrace_supports_stopped_by_hw_breakpoint)
5705         (record_btrace_update_thread_list, record_btrace_thread_alive)
5706         (record_btrace_goto_begin, record_btrace_goto_end)
5707         (record_btrace_goto, record_btrace_stop_replaying_all)
5708         (record_btrace_execution_direction)
5709         (record_btrace_prepare_to_generate_core)
5710         (record_btrace_done_generating_core): Refactor as
5711         record_btrace_target methods.
5712         (init_record_btrace_ops): Delete.
5713         (_initialize_record_btrace): Remove reference to
5714         init_record_btrace_ops.
5715         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
5716         the execution_direction global.
5717         (record_full_base_target, record_full_target)
5718         (record_full_core_target): New classes.
5719         (record_full_ops): Now a record_full_target.
5720         (record_full_core_ops): Now a record_full_core_target.
5721         (record_full_target::detach, record_full_target::disconnect)
5722         (record_full_core_target::disconnect)
5723         (record_full_target::mourn_inferior, record_full_target::kill):
5724         New.
5725         (record_full_open, record_full_close, record_full_async): Refactor
5726         as methods of the record_full_base_target class.
5727         (record_full_resume, record_full_commit_resume): Refactor
5728         as methods of the record_full_target class.
5729         (record_full_wait, record_full_stopped_by_watchpoint)
5730         (record_full_stopped_data_address)
5731         (record_full_stopped_by_sw_breakpoint)
5732         (record_full_supports_stopped_by_sw_breakpoint)
5733         (record_full_stopped_by_hw_breakpoint)
5734         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
5735         methods of the record_full_base_target class.
5736         (record_full_store_registers, record_full_xfer_partial)
5737         (record_full_insert_breakpoint, record_full_remove_breakpoint):
5738         Refactor as methods of the record_full_target class.
5739         (record_full_can_execute_reverse, record_full_get_bookmark)
5740         (record_full_goto_bookmark, record_full_execution_direction)
5741         (record_full_record_method, record_full_info, record_full_delete)
5742         (record_full_is_replaying, record_full_will_replay)
5743         (record_full_goto_begin, record_full_goto_end, record_full_goto)
5744         (record_full_stop_replaying): Refactor as methods of the
5745         record_full_base_target class.
5746         (record_full_core_resume, record_full_core_kill)
5747         (record_full_core_fetch_registers)
5748         (record_full_core_prepare_to_store)
5749         (record_full_core_store_registers, record_full_core_xfer_partial)
5750         (record_full_core_insert_breakpoint)
5751         (record_full_core_remove_breakpoint)
5752         (record_full_core_has_execution): Refactor
5753         as methods of the record_full_core_target class.
5754         (record_full_base_target::supports_delete_record): New.
5755         (init_record_full_ops): Delete.
5756         (init_record_full_core_ops): Delete.
5757         (record_full_save): Refactor as method of the
5758         record_full_base_target class.
5759         (_initialize_record_full): Remove references to
5760         init_record_full_ops and init_record_full_core_ops.
5761
5762         * remote.c (remote_target, extended_remote_target): New classes.
5763         (remote_ops): Now a remote_target.
5764         (extended_remote_ops): Now an extended_remote_target.
5765         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
5766         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
5767         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
5768         (remote_pass_signals, remote_set_syscall_catchpoint)
5769         (remote_program_signals, )
5770         (remote_thread_always_alive): Remove target_ops parameter.
5771         (remote_thread_alive, remote_thread_name)
5772         (remote_update_thread_list, remote_threads_extra_info)
5773         (remote_static_tracepoint_marker_at)
5774         (remote_static_tracepoint_markers_by_strid)
5775         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
5776         (remote_open): Refactor as methods of remote_target.
5777         (extended_remote_open, extended_remote_detach)
5778         (extended_remote_attach, extended_remote_post_attach):
5779         (extended_remote_supports_disable_randomization)
5780         (extended_remote_create_inferior): : Refactor as method of
5781         extended_remote_target.
5782         (remote_set_permissions, remote_open_1, remote_detach)
5783         (remote_follow_fork, remote_follow_exec, remote_disconnect)
5784         (remote_resume, remote_commit_resume, remote_stop)
5785         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
5786         (remote_terminal_ours, remote_wait, remote_fetch_registers)
5787         (remote_prepare_to_store, remote_store_registers)
5788         (remote_flash_erase, remote_flash_done, remote_files_info)
5789         (remote_kill, remote_mourn, remote_insert_breakpoint)
5790         (remote_remove_breakpoint, remote_insert_watchpoint)
5791         (remote_watchpoint_addr_within_range)
5792         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
5793         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
5794         (remote_supports_stopped_by_sw_breakpoint)
5795         (remote_stopped_by_hw_breakpoint)
5796         (remote_supports_stopped_by_hw_breakpoint)
5797         (remote_stopped_by_watchpoint, remote_stopped_data_address)
5798         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
5799         (remote_verify_memory): Refactor as methods of remote_target.
5800         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
5801         parameter.
5802         (remote_xfer_partial, remote_get_memory_xfer_limit)
5803         (remote_search_memory, remote_rcmd, remote_memory_map)
5804         (remote_pid_to_str, remote_get_thread_local_address)
5805         (remote_get_tib_address, remote_read_description): Refactor as
5806         methods of remote_target.
5807         (remote_target::fileio_open, remote_target::fileio_pwrite)
5808         (remote_target::fileio_pread, remote_target::fileio_close): New.
5809         (remote_hostio_readlink, remote_hostio_fstat)
5810         (remote_filesystem_is_local, remote_can_execute_reverse)
5811         (remote_supports_non_stop, remote_supports_disable_randomization)
5812         (remote_supports_multi_process, remote_supports_cond_breakpoints)
5813         (remote_supports_enable_disable_tracepoint)
5814         (remote_supports_string_tracing)
5815         (remote_can_run_breakpoint_commands, remote_trace_init)
5816         (remote_download_tracepoint, remote_can_download_tracepoint)
5817         (remote_download_trace_state_variable, remote_enable_tracepoint)
5818         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
5819         (remote_trace_start, remote_get_trace_status)
5820         (remote_get_tracepoint_status, remote_trace_stop)
5821         (remote_trace_find, remote_get_trace_state_variable_value)
5822         (remote_save_trace_data, remote_get_raw_trace_data)
5823         (remote_set_disconnected_tracing, remote_core_of_thread)
5824         (remote_set_circular_trace_buffer, remote_traceframe_info)
5825         (remote_get_min_fast_tracepoint_insn_len)
5826         (remote_set_trace_buffer_size, remote_set_trace_notes)
5827         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
5828         (remote_disable_btrace, remote_teardown_btrace)
5829         (remote_read_btrace, remote_btrace_conf)
5830         (remote_augmented_libraries_svr4_read, remote_load)
5831         (remote_pid_to_exec_file, remote_can_do_single_step)
5832         (remote_execution_direction, remote_thread_handle_to_thread_info):
5833         Refactor as methods of remote_target.
5834         (init_remote_ops, init_extended_remote_ops): Delete.
5835         (remote_can_async_p, remote_is_async_p, remote_async)
5836         (remote_thread_events, remote_upload_tracepoints)
5837         (remote_upload_trace_state_variables): Refactor as methods of
5838         remote_target.
5839         (_initialize_remote): Remove references to init_remote_ops and
5840         init_extended_remote_ops.
5841
5842         * remote-sim.c (gdbsim_target): New class.
5843         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
5844         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
5845         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
5846         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
5847         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
5848         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
5849         Refactor as methods of gdbsim_target.
5850         (gdbsim_ops): Now a gdbsim_target.
5851         (init_gdbsim_ops): Delete.
5852         (gdbsim_cntrl_c): Adjust.
5853         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
5854
5855         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
5856         (the_amd64_linux_nat_target): New.
5857         (amd64_linux_fetch_inferior_registers)
5858         (amd64_linux_store_inferior_registers): Refactor as methods of
5859         amd64_linux_nat_target.
5860         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
5861         * i386-linux-nat.c: Don't include "linux-nat.h".
5862         (i386_linux_nat_target): New class.
5863         (the_i386_linux_nat_target): New.
5864         (i386_linux_fetch_inferior_registers)
5865         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
5866         as methods of i386_linux_nat_target.
5867         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
5868         * inf-child.c (inf_child_ops): Delete.
5869         (inf_child_fetch_inferior_registers)
5870         (inf_child_store_inferior_registers): Delete.
5871         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
5872         methods of inf_child_target.
5873         (inf_child_target::supports_terminal_ours)
5874         (inf_child_target::terminal_init)
5875         (inf_child_target::terminal_inferior)
5876         (inf_child_target::terminal_ours_for_output)
5877         (inf_child_target::terminal_ours, inf_child_target::interrupt)
5878         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
5879         New.
5880         (inf_child_open, inf_child_disconnect, inf_child_close)
5881         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
5882         (inf_child_post_startup_inferior, inf_child_can_run)
5883         (inf_child_pid_to_exec_file): Refactor as methods of
5884         inf_child_target.
5885         (inf_child_follow_fork): Delete.
5886         (inf_child_target::can_create_inferior)
5887         (inf_child_target::can_attach): New.
5888         (inf_child_target::has_all_memory, inf_child_target::has_memory)
5889         (inf_child_target::has_stack, inf_child_target::has_registers)
5890         (inf_child_target::has_execution): New.
5891         (inf_child_fileio_open, inf_child_fileio_pwrite)
5892         (inf_child_fileio_pread, inf_child_fileio_fstat)
5893         (inf_child_fileio_close, inf_child_fileio_unlink)
5894         (inf_child_fileio_readlink, inf_child_use_agent)
5895         (inf_child_can_use_agent): Refactor as methods of
5896         inf_child_target.
5897         (return_zero, inf_child_target): Delete.
5898         (inf_child_target::inf_child_target): New.
5899         * inf-child.h: Include "target.h".
5900         (inf_child_target): Delete function prototype.
5901         (inf_child_target): New class.
5902         (inf_child_open_target, inf_child_mourn_inferior)
5903         (inf_child_maybe_unpush_target): Delete.
5904         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
5905         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
5906         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
5907         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
5908         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
5909         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
5910         (inf_ptrace_wait, inf_ptrace_xfer_partial)
5911         (inf_ptrace_thread_alive, inf_ptrace_files_info)
5912         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
5913         methods of inf_ptrace_target.
5914         (inf_ptrace_target): Delete function.
5915         * inf-ptrace.h: Include "inf-child.h".
5916         (inf_ptrace_target): Delete function declaration.
5917         (inf_ptrace_target): New class.
5918         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
5919         * linux-nat.c (linux_target): New.
5920         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
5921         (linux_nat_target::~linux_nat_target): New.
5922         (linux_child_post_attach, linux_child_post_startup_inferior)
5923         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
5924         (linux_child_remove_fork_catchpoint)
5925         (linux_child_insert_vfork_catchpoint)
5926         (linux_child_remove_vfork_catchpoint)
5927         (linux_child_insert_exec_catchpoint)
5928         (linux_child_remove_exec_catchpoint)
5929         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
5930         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
5931         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
5932         (linux_nat_stopped_data_address)
5933         (linux_nat_stopped_by_sw_breakpoint)
5934         (linux_nat_supports_stopped_by_sw_breakpoint)
5935         (linux_nat_stopped_by_hw_breakpoint)
5936         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
5937         (linux_nat_kill, linux_nat_mourn_inferior)
5938         (linux_nat_xfer_partial, linux_nat_thread_alive)
5939         (linux_nat_update_thread_list, linux_nat_pid_to_str)
5940         (linux_nat_thread_name, linux_child_pid_to_exec_file)
5941         (linux_child_static_tracepoint_markers_by_strid)
5942         (linux_nat_is_async_p, linux_nat_can_async_p)
5943         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
5944         (linux_nat_supports_multi_process)
5945         (linux_nat_supports_disable_randomization, linux_nat_async)
5946         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
5947         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
5948         (linux_nat_fileio_open, linux_nat_fileio_readlink)
5949         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
5950         methods of linux_nat_target.
5951         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
5952         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
5953         parameter.
5954         (check_stopped_by_watchpoint): Adjust.
5955         (linux_xfer_partial): Delete.
5956         (linux_target_install_ops, linux_target, linux_nat_add_target):
5957         Delete.
5958         (linux_nat_target::linux_nat_target): New.
5959         * linux-nat.h: Include "inf-ptrace.h".
5960         (linux_nat_target): New.
5961         (linux_target, linux_target_install_ops, linux_nat_add_target):
5962         Delete function declarations.
5963         (linux_target): Declare global.
5964         * linux-thread-db.c (thread_db_target): New.
5965         (thread_db_target::thread_db_target): New.
5966         (thread_db_ops): Delete.
5967         (the_thread_db_target): New.
5968         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
5969         (thread_db_update_thread_list, thread_db_pid_to_str)
5970         (thread_db_extra_thread_info)
5971         (thread_db_thread_handle_to_thread_info)
5972         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
5973         (thread_db_resume): Refactor as methods of thread_db_target.
5974         (init_thread_db_ops): Delete.
5975         (_initialize_thread_db): Remove reference to init_thread_db_ops.
5976         * x86-linux-nat.c: Don't include "linux-nat.h".
5977         (super_post_startup_inferior): Delete.
5978         (x86_linux_nat_target::~x86_linux_nat_target): New.
5979         (x86_linux_child_post_startup_inferior)
5980         (x86_linux_read_description, x86_linux_enable_btrace)
5981         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
5982         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
5983         methods of x86_linux_nat_target.
5984         (x86_linux_create_target): Delete.  Bits folded ...
5985         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
5986         pointer.
5987         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
5988         (x86_linux_nat_target): New class.
5989         (x86_linux_create_target): Delete.
5990         (x86_linux_add_target): Now takes a linux_nat_target pointer.
5991         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
5992         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
5993         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
5994         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
5995         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
5996         make extern.
5997         (x86_use_watchpoints): Delete.
5998         * x86-nat.h: Include "breakpoint.h" and "target.h".
5999         (x86_use_watchpoints): Delete.
6000         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
6001         (x86_stopped_by_watchpoint, x86_stopped_data_address)
6002         (x86_insert_watchpoint, x86_remove_watchpoint)
6003         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
6004         (x86_stopped_by_hw_breakpoint): New declarations.
6005         (x86_nat_target): New template class.
6006
6007         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
6008         (the_ppc_linux_nat_target): New.
6009         (ppc_linux_fetch_inferior_registers)
6010         (ppc_linux_can_use_hw_breakpoint)
6011         (ppc_linux_region_ok_for_hw_watchpoint)
6012         (ppc_linux_ranged_break_num_registers)
6013         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
6014         (ppc_linux_insert_mask_watchpoint)
6015         (ppc_linux_remove_mask_watchpoint)
6016         (ppc_linux_can_accel_watchpoint_condition)
6017         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
6018         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
6019         (ppc_linux_watchpoint_addr_within_range)
6020         (ppc_linux_masked_watch_num_registers)
6021         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
6022         (ppc_linux_read_description): Refactor as methods of
6023         ppc_linux_nat_target.
6024         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
6025
6026         * procfs.c (procfs_xfer_partial): Delete forward declaration.
6027         (procfs_target): New class.
6028         (the_procfs_target): New.
6029         (procfs_target): Delete function.
6030         (procfs_auxv_parse, procfs_attach, procfs_detach)
6031         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
6032         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
6033         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
6034         (procfs_create_inferior, procfs_update_thread_list)
6035         (procfs_thread_alive, procfs_pid_to_str)
6036         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
6037         (procfs_stopped_data_address, procfs_insert_watchpoint)
6038         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
6039         (proc_find_memory_regions, procfs_info_proc)
6040         (procfs_make_note_section): Refactor as methods of procfs_target.
6041         (_initialize_procfs): Adjust.
6042         * sol-thread.c (sol_thread_target): New class.
6043         (sol_thread_ops): Now a sol_thread_target.
6044         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
6045         (sol_thread_fetch_registers, sol_thread_store_registers)
6046         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
6047         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
6048         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
6049         (init_sol_thread_ops): Delete.
6050         (_initialize_sol_thread): Adjust.  Remove references to
6051         init_sol_thread_ops and complete_target_initialization.
6052
6053         * windows-nat.c (windows_nat_target): New class.
6054         (windows_fetch_inferior_registers)
6055         (windows_store_inferior_registers, windows_resume, windows_wait)
6056         (windows_attach, windows_detach, windows_pid_to_exec_file)
6057         (windows_files_info, windows_create_inferior)
6058         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
6059         (windows_close, windows_pid_to_str, windows_xfer_partial)
6060         (windows_get_tib_address, windows_get_ada_task_ptid)
6061         (windows_thread_name, windows_thread_alive): Refactor as
6062         windows_nat_target methods.
6063         (do_initial_windows_stuff): Adjust.
6064         (windows_target): Delete function.
6065         (_initialize_windows_nat): Adjust.
6066
6067         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
6068         (darwin_mourn_inferior, darwin_kill_inferior)
6069         (darwin_create_inferior, darwin_attach, darwin_detach)
6070         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
6071         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
6072         (darwin_supports_multi_process): Refactor as darwin_nat_target
6073         methods.
6074         (darwin_resume_to, darwin_files_info): Delete.
6075         (_initialize_darwin_inferior): Rename to ...
6076         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
6077         * darwin-nat.h: Include "inf-child.h".
6078         (darwin_nat_target): New class.
6079         (darwin_complete_target): Delete.
6080         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
6081         (darwin_target): New.
6082         (i386_darwin_fetch_inferior_registers)
6083         (i386_darwin_store_inferior_registers): Refactor as methods of
6084         darwin_nat_target.
6085         (darwin_complete_target): Delete, with ...
6086         (_initialize_i386_darwin_nat): ... bits factored out here.
6087
6088         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
6089         (the_alpha_linux_nat_target): New.
6090         (alpha_linux_register_u_offset): Refactor as
6091         alpha_linux_nat_target method.
6092         (_initialize_alpha_linux_nat): Adjust.
6093         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
6094         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
6095         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
6096         methods of linux_nat_trad_target.
6097         (linux_trad_target): Delete.
6098         * linux-nat-trad.h (linux_trad_target): Delete function.
6099         (linux_nat_trad_target): New class.
6100         * mips-linux-nat.c (mips_linux_nat_target): New class.
6101         (super_fetch_registers, super_store_registers, super_close):
6102         Delete.
6103         (the_mips_linux_nat_target): New.
6104         (mips64_linux_regsets_fetch_registers)
6105         (mips64_linux_regsets_store_registers)
6106         (mips64_linux_fetch_registers, mips64_linux_store_registers)
6107         (mips_linux_register_u_offset, mips_linux_read_description)
6108         (mips_linux_can_use_hw_breakpoint)
6109         (mips_linux_stopped_by_watchpoint)
6110         (mips_linux_stopped_data_address)
6111         (mips_linux_region_ok_for_hw_watchpoint)
6112         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
6113         (mips_linux_close): Refactor as methods of mips_linux_nat.
6114         (_initialize_mips_linux_nat): Adjust to C++ification.
6115
6116         * aix-thread.c (aix_thread_target): New class.
6117         (aix_thread_ops): Now an aix_thread_target.
6118         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
6119         (aix_thread_fetch_registers, aix_thread_store_registers)
6120         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
6121         (aix_thread_thread_alive, aix_thread_pid_to_str)
6122         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
6123         Refactor as methods of aix_thread_target.
6124         (init_aix_thread_ops): Delete.
6125         (_initialize_aix_thread): Remove references to init_aix_thread_ops
6126         and complete_target_initialization.
6127         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
6128         (rs6000_nat_target): New class.
6129         (the_rs6000_nat_target): New.
6130         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
6131         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
6132         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
6133         (super_create_inferior): Delete.
6134         (_initialize_rs6000_nat): Adjust to C++ification.
6135
6136         * arm-linux-nat.c (arm_linux_nat_target): New class.
6137         (the_arm_linux_nat_target): New.
6138         (arm_linux_fetch_inferior_registers)
6139         (arm_linux_store_inferior_registers, arm_linux_read_description)
6140         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
6141         (arm_linux_remove_hw_breakpoint)
6142         (arm_linux_region_ok_for_hw_watchpoint)
6143         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
6144         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
6145         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
6146         arm_linux_nat_target.
6147         (_initialize_arm_linux_nat): Adjust to C++ification.
6148
6149         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
6150         (the_aarch64_linux_nat_target): New.
6151         (aarch64_linux_fetch_inferior_registers)
6152         (aarch64_linux_store_inferior_registers)
6153         (aarch64_linux_child_post_startup_inferior)
6154         (aarch64_linux_read_description)
6155         (aarch64_linux_can_use_hw_breakpoint)
6156         (aarch64_linux_insert_hw_breakpoint)
6157         (aarch64_linux_remove_hw_breakpoint)
6158         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
6159         (aarch64_linux_region_ok_for_hw_watchpoint)
6160         (aarch64_linux_stopped_data_address)
6161         (aarch64_linux_stopped_by_watchpoint)
6162         (aarch64_linux_watchpoint_addr_within_range)
6163         (aarch64_linux_can_do_single_step): Refactor as methods of
6164         aarch64_linux_nat_target.
6165         (super_post_startup_inferior): Delete.
6166         (_initialize_aarch64_linux_nat): Adjust to C++ification.
6167
6168         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
6169         (the_hppa_linux_nat_target): New.
6170         (hppa_linux_fetch_inferior_registers)
6171         (hppa_linux_store_inferior_registers): Refactor as methods of
6172         hppa_linux_nat_target.
6173         (_initialize_hppa_linux_nat): Adjust to C++ification.
6174
6175         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
6176         (the_ia64_linux_nat_target): New.
6177         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
6178         (ia64_linux_stopped_data_address)
6179         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
6180         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
6181         ia64_linux_nat_target methods.
6182         (super_xfer_partial): Delete.
6183         (_initialize_ia64_linux_nat): Adjust to C++ification.
6184
6185         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
6186         (the_m32r_linux_nat_target): New.
6187         (m32r_linux_fetch_inferior_registers)
6188         (m32r_linux_store_inferior_registers): Refactor as
6189         m32r_linux_nat_target methods.
6190         (_initialize_m32r_linux_nat): Adjust to C++ification.
6191
6192         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
6193         (the_m68k_linux_nat_target): New.
6194         (m68k_linux_fetch_inferior_registers)
6195         (m68k_linux_store_inferior_registers): Refactor as
6196         m68k_linux_nat_target methods.
6197         (_initialize_m68k_linux_nat): Adjust to C++ification.
6198
6199         * s390-linux-nat.c (s390_linux_nat_target): New class.
6200         (the_s390_linux_nat_target): New.
6201         (s390_linux_fetch_inferior_registers)
6202         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
6203         (s390_insert_watchpoint, s390_remove_watchpoint)
6204         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
6205         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
6206         (s390_auxv_parse, s390_read_description): Refactor as methods of
6207         s390_linux_nat_target.
6208         (_initialize_s390_nat): Adjust to C++ification.
6209
6210         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
6211         (the_sparc_linux_nat_target): New.
6212         (_initialize_sparc_linux_nat): Adjust to C++ification.
6213         * sparc-nat.c (sparc_fetch_inferior_registers)
6214         (sparc_store_inferior_registers): Remove target_ops parameter.
6215         * sparc-nat.h (sparc_fetch_inferior_registers)
6216         (sparc_store_inferior_registers): Remove target_ops parameter.
6217         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
6218         (the_sparc64_linux_nat_target): New.
6219         (_initialize_sparc64_linux_nat): Adjust to C++ification.
6220
6221         * spu-linux-nat.c (spu_linux_nat_target): New class.
6222         (the_spu_linux_nat_target): New.
6223         (spu_child_post_startup_inferior, spu_child_post_attach)
6224         (spu_child_wait, spu_fetch_inferior_registers)
6225         (spu_store_inferior_registers, spu_xfer_partial)
6226         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
6227         methods.
6228         (_initialize_spu_nat): Adjust to C++ification.
6229
6230         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
6231         (the_tilegx_linux_nat_target): New.
6232         (fetch_inferior_registers, store_inferior_registers):
6233         Refactor as methods.
6234         (_initialize_tile_linux_nat): Adjust to C++ification.
6235
6236         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
6237         (the_xtensa_linux_nat_target): New.
6238         (xtensa_linux_fetch_inferior_registers)
6239         (xtensa_linux_store_inferior_registers): Refactor as
6240         xtensa_linux_nat_target methods.
6241         (_initialize_xtensa_linux_nat): Adjust to C++ification.
6242
6243         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
6244         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
6245         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
6246         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
6247         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
6248         (fbsd_stopped_by_sw_breakpoint)
6249         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
6250         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
6251         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
6252         (fbsd_post_startup_inferior, fbsd_post_attach)
6253         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
6254         (fbsd_set_syscall_catchpoint)
6255         (super_xfer_partial, super_resume, super_wait)
6256         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
6257         (fbsd_handle_debug_trap): Remove target_ops parameter.
6258         (fbsd_nat_add_target): Delete.
6259         * fbsd-nat.h: Include "inf-ptrace.h".
6260         (fbsd_nat_add_target): Delete.
6261         (USE_SIGTRAP_SIGINFO): Define.
6262         (fbsd_nat_target): New class.
6263
6264         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
6265         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
6266         (amd64bsd_target): Delete.
6267         * amd64-bsd-nat.h: New file.
6268         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
6269         "x86-bsd-nat.h".
6270         (amd64_fbsd_nat_target): New class.
6271         (the_amd64_fbsd_nat_target): New.
6272         (amd64fbsd_read_description): Refactor as method of
6273         amd64_fbsd_nat_target.
6274         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
6275         (_initialize_amd64fbsd_nat): Adjust to C++ification.
6276         * amd64-nat.h (amd64bsd_target): Delete function declaration.
6277         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
6278         (i386bsd_store_inferior_registers): Remove target_ops parameter.
6279         (i386bsd_target): Delete.
6280         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
6281         (i386bsd_fetch_inferior_registers)
6282         (i386bsd_store_inferior_registers): Declare.
6283         (i386_bsd_nat_target): New class.
6284         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
6285         (the_i386_fbsd_nat_target): New.
6286         (i386fbsd_resume, i386fbsd_read_description): Refactor as
6287         i386_fbsd_nat_target methods.
6288         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
6289         (_initialize_i386fbsd_nat): Adjust to C++ification.
6290         * x86-bsd-nat.c (super_mourn_inferior): Delete.
6291         (x86bsd_mourn_inferior, x86bsd_target): Delete.
6292         (_initialize_x86_bsd_nat): Adjust to C++ification.
6293         * x86-bsd-nat.h: Include "x86-nat.h".
6294         (x86bsd_target): Delete declaration.
6295         (x86bsd_nat_target): New class.
6296
6297         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
6298         (the_aarch64_fbsd_nat_target): New.
6299         (aarch64_fbsd_fetch_inferior_registers)
6300         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
6301         aarch64_fbsd_nat_target.
6302         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
6303         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
6304         (the_alpha_bsd_nat_target): New.
6305         (alphabsd_fetch_inferior_registers)
6306         (alphabsd_store_inferior_registers): Refactor as
6307         alpha_bsd_nat_target methods.
6308         (_initialize_alphabsd_nat): Refactor as methods of
6309         alpha_bsd_nat_target.
6310         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
6311         (the_amd64_nbsd_nat_target): New.
6312         (_initialize_amd64nbsd_nat): Adjust to C++ification.
6313         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
6314         (the_amd64_obsd_nat_target): New.
6315         (_initialize_amd64obsd_nat): Adjust to C++ification.
6316         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
6317         (the_arm_fbsd_nat_target): New.
6318         (arm_fbsd_fetch_inferior_registers)
6319         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
6320         (_initialize_arm_fbsd_nat): Refactor as methods of
6321         arm_fbsd_nat_target.
6322         (_initialize_arm_fbsd_nat): Adjust to C++ification.
6323         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
6324         (the_arm_netbsd_nat_target): New.
6325         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
6326         arm_netbsd_nat_target.
6327         (_initialize_arm_netbsd_nat): Adjust to C++ification.
6328         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
6329         (the_hppa_nbsd_nat_target): New.
6330         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
6331         hppa_nbsd_nat_target methods.
6332         (_initialize_hppanbsd_nat): Adjust to C++ification.
6333         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
6334         (the_hppa_obsd_nat_target): New.
6335         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
6336         methods of hppa_obsd_nat_target.
6337         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
6338         add_target.
6339         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
6340         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
6341         add_target.
6342         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
6343         (_initialize_i386obsd_nat): Use add_target.
6344         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
6345         (the_m68k_bsd_nat_target): New.
6346         (m68kbsd_fetch_inferior_registers)
6347         (m68kbsd_store_inferior_registers): Refactor as methods of
6348         m68k_bsd_nat_target.
6349         (_initialize_m68kbsd_nat): Adjust to C++ification.
6350         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
6351         (the_mips_fbsd_nat_target): New.
6352         (mips_fbsd_fetch_inferior_registers)
6353         (mips_fbsd_store_inferior_registers): Refactor as methods of
6354         mips_fbsd_nat_target.
6355         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
6356         add_target.
6357         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
6358         (the_mips_nbsd_nat_target): New.
6359         (mipsnbsd_fetch_inferior_registers)
6360         (mipsnbsd_store_inferior_registers): Refactor as methods of
6361         mips_nbsd_nat_target.
6362         (_initialize_mipsnbsd_nat): Adjust to C++ification.
6363         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
6364         (the_mips64_obsd_nat_target): New.
6365         (mips64obsd_fetch_inferior_registers)
6366         (mips64obsd_store_inferior_registers): Refactor as methods of
6367         mips64_obsd_nat_target.
6368         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
6369         add_target.
6370         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
6371         nbsd_nat_target.
6372         * nbsd-nat.h: Include "inf-ptrace.h".
6373         (nbsd_nat_target): New class.
6374         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
6375         (obsd_wait): Refactor as methods of obsd_nat_target.
6376         (obsd_add_target): Delete.
6377         * obsd-nat.h: Include "inf-ptrace.h".
6378         (obsd_nat_target): New class.
6379         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
6380         (the_ppc_fbsd_nat_target): New.
6381         (ppcfbsd_fetch_inferior_registers)
6382         (ppcfbsd_store_inferior_registers): Refactor as methods of
6383         ppc_fbsd_nat_target.
6384         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
6385         add_target.
6386         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
6387         (the_ppc_nbsd_nat_target): New.
6388         (ppcnbsd_fetch_inferior_registers)
6389         (ppcnbsd_store_inferior_registers): Refactor as methods of
6390         ppc_nbsd_nat_target.
6391         (_initialize_ppcnbsd_nat): Adjust to C++ification.
6392         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
6393         (the_ppc_obsd_nat_target): New.
6394         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
6395         methods of ppc_obsd_nat_target.
6396         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
6397         add_target.
6398         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
6399         (the_sh_nbsd_nat_target): New.
6400         (shnbsd_fetch_inferior_registers)
6401         (shnbsd_store_inferior_registers): Refactor as methods of
6402         sh_nbsd_nat_target.
6403         (_initialize_shnbsd_nat): Adjust to C++ification.
6404         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
6405         (inf_ptrace_xfer_partial): Delete.
6406         (sparc_xfer_partial, sparc_target): Delete.
6407         * sparc-nat.h (sparc_fetch_inferior_registers)
6408         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
6409         (sparc_target): Delete function declaration.
6410         (sparc_target): New template class.
6411         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
6412         (_initialize_sparcnbsd_nat): Adjust to C++ification.
6413         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
6414         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
6415         add_target.
6416         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
6417         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
6418         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
6419         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
6420         add_target.
6421         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
6422         (the_vax_bsd_nat_target): New.
6423         (vaxbsd_fetch_inferior_registers)
6424         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
6425         methods.
6426         (_initialize_vaxbsd_nat): Adjust to C++ification.
6427
6428         * bsd-kvm.c (bsd_kvm_target): New class.
6429         (bsd_kvm_ops): Now a bsd_kvm_target.
6430         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
6431         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
6432         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
6433         bsd_kvm_target.
6434         (bsd_kvm_return_one): Delete.
6435         (bsd_kvm_add_target): Adjust to C++ification.
6436
6437         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
6438         (nto_procfs_target_procfs): New classes.
6439         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
6440         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
6441         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
6442         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
6443         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
6444         (procfs_remove_hw_breakpoint, procfs_resume)
6445         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
6446         (procfs_kill_inferior, procfs_store_registers)
6447         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
6448         as methods of nto_procfs_target.
6449         (nto_procfs_ops): Now an nto_procfs_target_procfs.
6450         (nto_native_ops): Delete.
6451         (procfs_open, procfs_native_open): Delete.
6452         (nto_native_ops): Now an nto_procfs_target_native.
6453         (init_procfs_targets): Adjust to C++ification.
6454         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
6455         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
6456         Refactor as methods of nto_procfs_target.
6457
6458         * go32-nat.c (go32_nat_target): New class.
6459         (the_go32_nat_target): New.
6460         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
6461         (go32_store_registers, go32_xfer_partial, go32_files_info)
6462         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
6463         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
6464         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
6465         (go32_pid_to_str): Refactor as methods of go32_nat_target.
6466         (go32_target): Delete.
6467         (_initialize_go32_nat): Adjust to C++ification.
6468
6469         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
6470         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
6471         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
6472         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
6473         gnu_nat_target.
6474         (gnu_target): Delete.
6475         * gnu-nat.h (gnu_target): Delete.
6476         (gnu_nat_target): New class.
6477         * i386-gnu-nat.c (gnu_base_target): New.
6478         (i386_gnu_nat_target): New class.
6479         (the_i386_gnu_nat_target): New.
6480         (_initialize_i386gnu_nat): Adjust to C++ification.
6481
6482 2018-05-02  Pedro Alves  <palves@redhat.com>
6483
6484         * bfd-target.c (target_bfd_xclose): Rename to ...
6485         (target_bfd_close): ... this.
6486         (target_bfd_reopen): Adjust.
6487         * target.c (target_close): Remove references to to_xclose.
6488         * target.h (target_ops::to_xclose): Delete.
6489         (target_ops::to_close): Update comments.
6490
6491 2018-05-02  Pedro Alves  <palves@redhat.com>
6492
6493         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
6494         "linux-nat.h".
6495         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
6496         * inf-ptrace.c (inf_ptrace_register_u_offset)
6497         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
6498         (inf_ptrace_store_register, inf_ptrace_store_registers)
6499         (inf_ptrace_trad_target): Move to ...
6500         * linux-nat-trad.c: ... this new file.
6501         * linux-nat-trad.h: New file.
6502         * linux-nat.c (linux_target_install_ops): Make extern.
6503         (linux_trad_target): Delete.
6504         * linux-nat.h (linux_trad_target): Delete declaration.
6505         (linux_target_install_ops): Declare.
6506         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
6507         "linux-nat.h".
6508
6509 2018-05-02  Pedro Alves  <palves@redhat.com>
6510
6511         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
6512         procfs_target/add_target here.
6513         * procfs.c (procfs_target): Make static.
6514         (_initialize_procfs): Call add_target here.
6515         * procfs.h (struct target_ops): Remove forward declaration.
6516         (procfs_target): Remove declaration.
6517         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
6518
6519 2018-05-02  Pedro Alves  <palves@redhat.com>
6520
6521         * procfs.c (procfs_stopped_by_watchpoint)
6522         (procfs_insert_watchpoint, procfs_remove_watchpoint)
6523         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
6524         Forward declare.
6525         (procfs_use_watchpoints): Delete, move contents...
6526         (procfs_target): ... here.
6527         * procfs.h (procfs_use_watchpoints): Delete declaration.
6528         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
6529         procfs_use_watchpoints.
6530         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
6531         procfs_use_watchpoints.
6532
6533 2018-05-02  Tom Tromey  <tom@tromey.com>
6534
6535         PR python/20084:
6536         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
6537         and var_zuinteger_unlimited.
6538         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
6539         and PARAM_ZUINTEGER_UNLIMITED.
6540         (set_parameter_value): Handle var_zuinteger and
6541         var_zuinteger_unlimited.
6542         (add_setshow_generic): Likewise.
6543         (parmpy_init): Likewise.
6544
6545 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
6546
6547         PR rust/23124
6548         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
6549         pointer is not null before dereferencing it.
6550
6551 2018-04-30  Tom Tromey  <tom@tromey.com>
6552
6553         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
6554         is_mi_like_p.
6555
6556 2018-04-30  Tom Tromey  <tom@tromey.com>
6557
6558         * breakpoint.c (mention): Remove use of is_mi_like_p.
6559         (print_mention_ranged_breakpoint): Likewise.
6560         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
6561         of is_mi_like_p.
6562
6563 2018-04-30  Tom Tromey  <tom@tromey.com>
6564
6565         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
6566
6567 2018-04-30  Tom Tromey  <tom@tromey.com>
6568
6569         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
6570         (info_spu_event_command): Remove some uses of is_mi_like_p.
6571
6572 2018-04-30  Tom Tromey  <tom@tromey.com>
6573
6574         * python/py-framefilter.c (py_print_single_arg)
6575         (enumerate_locals, py_print_args, py_print_frame): Remove some
6576         uses of is_mi_like_p.
6577
6578 2018-04-30  Tom Tromey  <tom@tromey.com>
6579
6580         * ui-out.c: Update.
6581         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
6582         * ui-out.h (ui_out::is_mi_like_p): Now const.
6583         (ui_out::do_is_mi_like_p): Now const.
6584         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
6585
6586 2018-04-30  Tom Tromey  <tom@tromey.com>
6587
6588         * varobj.c (varobj_set_visualizer): Use new_reference.
6589         * python/python.c (gdbpy_decode_line): Use new_reference.
6590         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
6591         new_reference.
6592
6593 2018-04-30  Tom Tromey  <tom@tromey.com>
6594
6595         * varobj.c (install_new_value): Use new_reference.
6596         * value.h (value_incref): Return void.  Swap intro comment with
6597         value_decref.
6598         * value.c (set_value_parent): Use new_reference.
6599         (value_incref): Return void.  Update intro comment.
6600         (release_value): Use new_reference.
6601         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
6602
6603 2018-04-30  Tom Tromey  <tom@tromey.com>
6604
6605         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
6606         * gdb_bfd.h (new_bfd_ref): Remove.
6607         (gdb_bfd_open): Update comment.
6608         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
6609         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
6610         (gdb_bfd_fdopenr): Use new_reference.
6611         * exec.c (exec_file_attach): Use new_reference.
6612
6613 2018-04-30  Tom Tromey  <tom@tromey.com>
6614
6615         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
6616         method.
6617
6618 2018-04-30  Tom Tromey  <tom@tromey.com>
6619
6620         * jit.c (jit_read_code_entry): Use type_align.
6621         * i386-tdep.c (i386_gdbarch_init): Don't call
6622         set_gdbarch_long_long_align_bit.
6623         * gdbarch.sh: Remove long_long_align_bit.
6624         * gdbarch.c, gdbarch.h: Rebuild.
6625         * arc-tdep.c (arc_type_align): New function.
6626         (arc_gdbarch_init): Use arc_type_align.  Don't call
6627         set_gdbarch_long_long_align_bit.
6628
6629 2018-04-30  Tom Tromey  <tom@tromey.com>
6630
6631         * rust-lang.c (rust_type_alignment): Remove.
6632         (rust_composite_type): Use type_align.
6633
6634 2018-04-30  Tom Tromey  <tom@tromey.com>
6635
6636         * NEWS: Mention Type.align.
6637         * python/py-type.c (typy_get_alignof): New function.
6638         (type_object_getset): Add "alignof".
6639
6640 2018-04-30  Tom Tromey  <tom@tromey.com>
6641
6642         PR exp/17095:
6643         * NEWS: Update.
6644         * std-operator.def (UNOP_ALIGNOF): New operator.
6645         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
6646         New.
6647         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
6648         * c-lang.c (c_op_print_tab): Add alignof.
6649         * c-exp.y (ALIGNOF): New token.
6650         (exp): Add "ALIGNOF" production.
6651         (ident_tokens): Add _Alignof and alignof.
6652
6653 2018-04-30  Tom Tromey  <tom@tromey.com>
6654
6655         * i386-tdep.c (i386_type_align): New function.
6656         (i386_gdbarch_init): Update.
6657         * gdbarch.sh (type_align): New method.
6658         * gdbarch.c, gdbarch.h: Rebuild.
6659         * arch-utils.h (default_type_align): Declare.
6660         * arch-utils.c (default_type_align): New function.
6661         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
6662         (struct type) <align_log2>: New field.
6663         <instance_flags>: Now a bitfield.
6664         (TYPE_RAW_ALIGN): New macro.
6665         (type_align, type_raw_align, set_type_align): Declare.
6666         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
6667         functions.
6668         * dwarf2read.c (quirk_rust_enum): Set type alignment.
6669         (get_alignment, maybe_set_alignment): New functions.
6670         (read_structure_type, read_enumeration_type, read_array_type)
6671         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
6672         (read_subrange_type, read_base_type): Set type alignment.
6673
6674 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
6675
6676         * dwarf2read.c (read_index_from_section): Use bool.
6677
6678 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
6679
6680         PR gdb/22950
6681         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
6682         with #ifdef.
6683
6684 2018-04-29  John Reiser  <jreiser@BitWagon.com>
6685
6686         PR build/22873
6687         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
6688         last step, and do it atomically.
6689
6690 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
6691
6692         * compile/compile-c-types.c (convert_int, convert_float):
6693         Update for C FE v1.
6694
6695 2018-04-27  Tom Tromey  <tom@tromey.com>
6696
6697         PR rust/22545:
6698         * rust-lang.c (rust_inclusive_range_type_p): New function.
6699         (rust_range): Handle inclusive ranges.
6700         (rust_compute_range): Likewise.
6701         * rust-exp.y (struct rust_op) <inclusive>: New field.
6702         (DOTDOTEQ): New constant.
6703         (range_expr): Add "..=" productions.
6704         (operator_tokens): Add "..=" token.
6705         (ast_range): Add "inclusive" parameter.
6706         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
6707         ranges.
6708         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
6709         bounds values.
6710         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
6711         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
6712         Update comments.
6713         * expprint.c (print_subexp_standard): Handle new bounds values.
6714         (dump_subexp_body_standard): Likewise.
6715
6716 2018-04-27  Tom Tromey  <tom@tromey.com>
6717
6718         * configure: Rebuild.
6719         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
6720         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
6721         "OVERRIDE".
6722         (class symbol_needs_eval_context): Likewise.
6723         * dwarf2read.c (mock_mapped_index::symbol_name_count)
6724         (mock_mapped_index::symbol_name_at): Use "override".  Remove
6725         "virtual".
6726         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
6727         "override".
6728         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
6729         * aarch64-tdep.c (instruction_reader::read): Use "override".
6730         (instruction_reader_test::read): Likewise.
6731         * arm-tdep.c (instruction_reader::read): Use "override".
6732         (instruction_reader_thumb::read): Likewise.
6733
6734 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
6735
6736         PR remote/9665
6737         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
6738         instead of remote_send.
6739         (remote_send): Remove.
6740
6741 2018-04-26  Pedro Alves  <palves@redhat.com>
6742
6743         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
6744         find_function_start_sal instead of find_pc_line.
6745
6746 2018-04-26  Pedro Alves  <palves@redhat.com>
6747
6748         * breakpoint.c (set_breakpoint_location_function): Handle
6749         mst_data_gnu_ifunc.
6750         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
6751         * elfread.c (elf_symtab_read): Give data symbols with
6752         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
6753         (elf_rel_plt_read): Update comment.
6754         * linespec.c (convert_linespec_to_sals): Handle
6755         mst_data_gnu_ifunc.
6756         (minsym_found): Handle mst_data_gnu_ifunc.
6757         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
6758         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
6759         * parse.c (find_minsym_type_and_address): Handle
6760         mst_data_gnu_ifunc.
6761         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
6762         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
6763         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
6764         comment.
6765         <mst_data_gnu_ifunc>: New enumerator.
6766
6767 2018-04-26  Pedro Alves  <palves@redhat.com>
6768
6769         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
6770         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
6771         'want_trampoline' parameter by a lookup_msym_prefer parameter.
6772         Handle it.
6773         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
6774         (lookup_minimal_symbol_by_pc): Adjust.
6775         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
6776         (lookup_solib_trampoline_symbol_by_pc): Adjust.
6777         * minsyms.h (lookup_msym_prefer): New enum.
6778         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
6779         parameter by a lookup_msym_prefer parameter.
6780
6781 2018-04-26  Pedro Alves  <palves@redhat.com>
6782
6783         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
6784         ends in "@plt" instead of looking at the symbol's section.
6785
6786 2018-04-26  Pedro Alves  <palves@redhat.com>
6787
6788         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
6789         all references.
6790         (find_pc_partial_function_gnu_ifunc): Rename to ...
6791         (find_pc_partial_function): ... this, and remove references to
6792         'is_gnu_ifunc_p'.
6793         (find_pc_partial_function): Delete old implementation.
6794         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
6795
6796 2018-04-26  Pedro Alves  <palves@redhat.com>
6797
6798         * linespec.c (struct bound_minimal_symbol_search_key): New.
6799         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
6800         skip first line if we found a GNU ifunc minimal symbol by name.
6801         (compare_msymbols): Change parameters to work with a destructured
6802         lhs minsym.
6803         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
6804         functions.
6805
6806 2018-04-26  Pedro Alves  <palves@redhat.com>
6807
6808         * breakpoint.c (set_breakpoint_location_function): Don't resolve
6809         ifunc targets here.  Instead, if we have an ifunc minsym, use its
6810         address/name.
6811         (add_location_to_breakpoint): Store the minsym and the objfile in
6812         the breakpoint location.
6813         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
6814         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
6815         Record the minsym in the sal.
6816         * symtab.h (symtab_and_line) <msymbol>: New field.
6817
6818 2018-04-26  Pedro Alves  <palves@redhat.com>
6819
6820         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
6821         unless we actually resolved the ifunc.
6822
6823 2018-04-26  Pedro Alves  <palves@redhat.com>
6824
6825         * c-exp.y (variable production): Prefer ifunc minsyms over
6826         regular function symbols.
6827         * symtab.c (find_gnu_ifunc): New function.
6828         * minsyms.h (lookup_msym_prefer): New enum.
6829         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
6830         parameter by a lookup_msym_prefer parameter.
6831         * symtab.h (find_gnu_ifunc): New declaration.
6832
6833 2018-04-26  Pedro Alves  <palves@redhat.com>
6834
6835         * blockframe.c (find_gnu_ifunc_target_type): New function.
6836         (find_function_type): New.
6837         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
6838         return a value with a memory address.
6839         (eval_call): For calls to GNU ifunc functions, try to find the
6840         type of the target function from the type that the resolver
6841         returns.
6842         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
6843         symbols.
6844         * infcall.c (find_function_return_type): Delete.
6845         (find_function_addr): Add 'function_type' parameter.  For calls to
6846         GNU ifunc functions, try to find the type of the target function
6847         from the type that the resolver returns, and return it via
6848         FUNCTION_TYPE.
6849         (call_function_by_hand_dummy): Adjust to use the function type
6850         returned by find_function_addr.
6851         (find_function_addr): Add 'function_type' parameter and move
6852         description here.
6853         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
6854         declarations.
6855
6856 2018-04-26  Pedro Alves  <palves@redhat.com>
6857
6858         * c-exp.y (variable production): Skip finding an alias for ifunc
6859         symbols.
6860
6861 2018-04-26  Pedro Alves  <palves@redhat.com>
6862
6863         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
6864
6865 2018-04-25  Pedro Alves  <palves@redhat.com>
6866
6867         * infcmd.c (kill_command): Print the pid as string, not the whole
6868         thread's ptid.  Add comment.  s/has been killed/killed/ in output
6869         message.
6870         * remote.c (remote_detach_1): Print the pid as string, not the
6871         whole thread's ptid.
6872
6873 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
6874             Sergio Durigan Junior  <sergiodj@redhat.com>
6875             Pedro Alves  <palves@redhat.com>
6876
6877         * infcmd.c (kill_command): Print message when inferior has
6878         been killed.
6879         * inferior.c (print_inferior_events): Remove 'static'.  Set as
6880         '1'.
6881         (add_inferior): Improve message printed when
6882         'print_inferior_events' is on.
6883         (exit_inferior): Remove message printed when
6884         'print_inferior_events' is on.
6885         (detach_inferior): Improve message printed when
6886         'print_inferior_events' is on.
6887         (initialize_inferiors): Use 'add_inferior_silent' to set
6888         'current_inferior_'.
6889         * inferior.h (print_inferior_events): Declare here as
6890         'extern'.
6891         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
6892         '[Detaching...]' messages when 'print_inferior_events' is on.
6893         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
6894         as prefix/suffix for messages.  Remove periods.  Fix erroneous
6895         'Detaching after fork from child...', replace it by '... from
6896         parent...'.
6897         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
6898         prefix/suffix when printing 'Detaching...' messages.  Print
6899         them when 'print_inferior_events' is on.
6900         * remote.c (remote_detach_1): Print message when detaching
6901         from inferior and '!is_fork_parent'.
6902
6903 2018-04-24  Tom Tromey  <tom@tromey.com>
6904
6905         * cli-out.h: Reindent.
6906
6907 2018-04-24  Tom Tromey  <tom@tromey.com>
6908
6909         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
6910         (cli_ui_out::do_field_string): Use fputs_filtered.
6911         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
6912
6913 2018-04-23  Tom Tromey  <tom@tromey.com>
6914
6915         * guile/scm-frame.c (gdbscm_frame_read_var): Use
6916         gdb::unique_xmalloc_ptr.
6917
6918 2018-04-23  Tom Tromey  <tom@tromey.com>
6919
6920         * configure: Rebuild.
6921
6922 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
6923
6924         PR gdb/23095
6925         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
6926         prepare_for_testing.  Set normal_bp to r_debug_state if target
6927         is bsd.
6928
6929 2018-04-21  Pedro Alves  <palves@redhat.com>
6930             Rajendra SY  <rajendra.sy@gmail.com>
6931
6932         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
6933         * remote.c (extended_remote_attach): In all-stop mode, mark the
6934         thread as executing.
6935
6936 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6937
6938         * thread.c (thread_apply_all_command): Fix comment.
6939         (thread_command): Fix comment.
6940
6941 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
6942
6943         * common/tdesc.h (tdesc_create_feature): Remove xml filename
6944         parameter.
6945         * features/aarch64-core.c (create_feature_aarch64_core):
6946         Regenerate.
6947         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
6948         Likewise.
6949         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
6950         Likewise.
6951         * features/i386/32bit-avx512.c
6952         (create_feature_i386_32bit_avx512): Likewise.
6953         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
6954         Likewise.
6955         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
6956         Likewise.
6957         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
6958         Likewise.
6959         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
6960         Likewise.
6961         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
6962         Likewise.
6963         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
6964         Likewise.
6965         * features/i386/64bit-avx512.c
6966         (create_feature_i386_64bit_avx512): Likewise.
6967         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
6968         Likewise.
6969         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
6970         Likewise.
6971         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
6972         Likewise.
6973         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
6974         Likewise.
6975         * features/i386/64bit-segments.c
6976         (create_feature_i386_64bit_segments): Likewise.
6977         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
6978         Likewise.
6979         * features/i386/x32-core.c
6980         (create_feature_i386_x32_core): Likewise.
6981         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
6982         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
6983         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
6984         * target-descriptions.c: In generated code, don't pass xml
6985         filename.
6986
6987 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
6988
6989         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
6990         (print_xml_feature::visit_post): Likewise.
6991         (print_xml_feature::visit): Likewise.
6992         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
6993         (print_xml_feature): Add new class.
6994         * regformats/regdat.sh: Null xmltarget on feature targets.
6995         * target-descriptions.c (struct target_desc): Add xmltarget.
6996         (maintenance_check_tdesc_xml_convert): Add unittest function.
6997         (tdesc_get_features_xml): Add function to get xml.
6998         (maintenance_check_xml_descriptions): Test xml generation.
6999         * xml-tdesc.c (string_read_description_xml): Add function.
7000         * xml-tdesc.h (string_read_description_xml): Add declaration.
7001
7002 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7003
7004         * features/Makefile: Add feature marker to targets with new style
7005         target descriptions.
7006         * regformats/aarch64.dat: Regenerate.
7007         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
7008         * regformats/i386/amd64-avx-linux.dat: Likewise.
7009         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
7010         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
7011         * regformats/i386/amd64-linux.dat: Likewise.
7012         * regformats/i386/amd64-mpx-linux.dat: Likewise.
7013         * regformats/i386/amd64.dat: Likewise.
7014         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
7015         * regformats/i386/i386-avx-linux.dat: Likewise.
7016         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
7017         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
7018         * regformats/i386/i386-linux.dat: Likewise.
7019         * regformats/i386/i386-mmx-linux.dat: Likewise.
7020         * regformats/i386/i386-mpx-linux.dat: Likewise.
7021         * regformats/i386/i386.dat: Likewise.
7022         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
7023         * regformats/i386/x32-avx-linux.dat: Likewise.
7024         * regformats/i386/x32-linux.dat: Likewise.
7025         * regformats/tic6x-c62x-linux.dat: Likewise.
7026         * regformats/tic6x-c64x-linux.dat: Likewise.
7027         * regformats/tic6x-c64xp-linux.dat: Likewise.
7028         * regformats/regdat.sh: Parse feature marker.
7029
7030 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7031
7032         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
7033         (tdesc_osabi_name): Likewise.
7034         * target-descriptions.c (tdesc_architecture_name): Add new
7035         function.
7036         (tdesc_osabi_name): Likewise.
7037
7038 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7039
7040         * common/tdesc.c (tdesc_predefined_type): Move to here.
7041         (tdesc_named_type): Likewise.
7042         (tdesc_create_vector): Likewise.
7043         (tdesc_create_struct): Likewise.
7044         (tdesc_set_struct_size): Likewise.
7045         (tdesc_create_union): Likewise.
7046         (tdesc_create_flags): Likewise.
7047         (tdesc_create_enum): Likewise.
7048         (tdesc_add_field): Likewise.
7049         (tdesc_add_typed_bitfield): Likewise.
7050         (tdesc_add_bitfield): Likewise.
7051         (tdesc_add_flag): Likewise.
7052         (tdesc_add_enum_value): Likewise.
7053         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
7054         (struct tdesc_type_vector): Likewise.
7055         (struct tdesc_type_field): Likewise.
7056         (struct tdesc_type_with_fields): Likewise.
7057         (tdesc_create_enum): Add declaration.
7058         (tdesc_add_typed_bitfield): Likewise.
7059         (tdesc_add_enum_value): Likewise.
7060         * target-descriptions.c (tdesc_type_field): Move from here.
7061         (tdesc_type_builtin): Likewise.
7062         (tdesc_type_vector): Likewise.
7063         (tdesc_type_with_fields): Likewise.
7064         (tdesc_predefined_types): Likewise.
7065         (tdesc_named_type): Likewise.
7066         (tdesc_create_vector): Likewise.
7067         (tdesc_create_struct): Likewise.
7068         (tdesc_set_struct_size): Likewise.
7069         (tdesc_create_union): Likewise.
7070         (tdesc_create_flags): Likewise.
7071         (tdesc_create_enum): Likewise.
7072         (tdesc_add_field): Likewise.
7073         (tdesc_add_typed_bitfield): Likewise.
7074         (tdesc_add_bitfield): Likewise.
7075         (tdesc_add_flag): Likewise.
7076         (tdesc_add_enum_value): Likewise.
7077         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
7078         (tdesc_add_typed_bitfield): Likewise.
7079         (tdesc_add_enum_value): Likewise.
7080
7081 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7082
7083         * common/tdesc.c (tdesc_feature::accept): Move to here.
7084         (tdesc_feature::operator==): Likewise.
7085         (tdesc_create_reg): Likewise.
7086         * common/tdesc.h (tdesc_type_kind): Likewise.
7087         (struct tdesc_type): Likewise.
7088         (struct tdesc_feature): Likewise.
7089         * regformats/regdat.sh: Create a feature.
7090         * target-descriptions.c (tdesc_type_kind): Move from here.
7091         (tdesc_type): Likewise.
7092         (tdesc_type_up): Likewise.
7093         (tdesc_feature): Likewise.
7094         (tdesc_create_reg): Likewise.
7095
7096 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7097
7098         * Makefile.in: Add arch/tdesc.c
7099         * common/tdesc.c: New file.
7100         * common/tdesc.h (tdesc_element_visitor): Move to here.
7101         (tdesc_element): Likewise.
7102         (tdesc_reg): Likewise.
7103         (tdesc_reg_up): Likewise.
7104         * regformats/regdef.h (reg): Add offset to constructors.
7105         * target-descriptions.c (tdesc_element_visitor): Move from here.
7106         (tdesc_element): Likewise.
7107         (tdesc_reg): Likewise.
7108         (tdesc_reg_up): Likewise.
7109
7110 2018-04-17  Tom Tromey  <tom@tromey.com>
7111
7112         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
7113         discriminant field.
7114
7115 2018-04-17  Tom Tromey  <tom@tromey.com>
7116
7117         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
7118
7119 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7120
7121         * symtab.c (print_symbol_info): Skip printing filename and line
7122         number when `last' is NULL.
7123         (symtab_symbol_info): Use empty string instead of NULL for first
7124         invocation of print_symbol_info.
7125         (rbreak_command): Pass NULL to `last' parameter of
7126         print_symbol_info.
7127
7128 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
7129
7130         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
7131         instead of nullptr.
7132
7133 2018-04-16  Pedro Alves  <palves@redhat.com>
7134
7135         * MAINTAINERS (sh): Remove.
7136         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
7137         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
7138         (ALLDEPFILES): Remove sh64-tdep.c.
7139         * NEWS: Mentions that support for SH-5/SH64 is removed.
7140         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
7141         (sh*-*-openbsd*): Ditto.
7142         (sh64-*-elf*): Remove.
7143         (sh*): Remove.
7144         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
7145         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
7146         * sh-tdep.c: No longer include "sh64-tdep.h".
7147         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
7148         * sh64-tdep.c, sh64-tdep.h: Remove files.
7149
7150 2018-04-16  Pedro Alves  <palves@redhat.com>
7151
7152         * MAINTAINERS: Remove m88k.
7153         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
7154         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
7155         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
7156         * NEWS: Mention that support for m88k was removed.
7157         * configure.host (m88*-*-*): Remove support.
7158         * configure.nat (m88k-*-*): Remove support.
7159         * configure.tgt (m88*-*-openbsd*): Remove.
7160         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
7161
7162 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
7163
7164         * configure.tgt (x86_tobjs): New variable.
7165         (amd64_tobjs, i386_tobjs): Use it.
7166
7167 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7168
7169         * symtab.c (print_symbol_info): Precede the symbol definition by
7170         the line number when available.
7171         * NEWS: Advertise this enhancement.
7172
7173 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7174
7175         * NEWS (New options): announce set/show record btrace cpu.
7176         * btrace.c: Include record-btrace.h.
7177         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
7178         the vendor is unknown.
7179         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
7180         Maybe overwrite the btrace configuration's cpu.
7181         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
7182         (btrace_fetch): Add cpu parameter.  Update callers.
7183         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
7184         Maybe overwrite the btrace configuration's cpu.  Skip enabling
7185         errata workarounds if the vendor is unknown.
7186         * python/py-record-btrace.c: Include record-btrace.h.
7187         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
7188         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
7189         * record-btrace.c (record_btrace_cpu_state_kind): New.
7190         (record_btrace_cpu): New.
7191         (set_record_btrace_cpu_cmdlist): New.
7192         (record_btrace_get_cpu): New.
7193         (require_btrace_thread, record_btrace_info)
7194         (record_btrace_resume_thread): Call record_btrace_get_cpu.
7195         (cmd_set_record_btrace_cpu_none): New.
7196         (cmd_set_record_btrace_cpu_auto): New.
7197         (cmd_set_record_btrace_cpu): New.
7198         (cmd_show_record_btrace_cpu): New.
7199         (_initialize_record_btrace): Initialize set/show record btrace cpu
7200         commands.
7201         * record-btrace.h (record_btrace_get_cpu): New.
7202
7203 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7204
7205         * record.c (set_record_command): Fix typo in message.
7206
7207 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7208
7209         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
7210
7211 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7212
7213         * infrun.c (process_event_stop_test): Call
7214         gdbarch_in_indirect_branch_thunk.
7215         * gdbarch.sh (in_indirect_branch_thunk): New.
7216         * gdbarch.c: Regenerated.
7217         * gdbarch.h: Regenerated.
7218         * x86-tdep.h: New.
7219         * x86-tdep.c: New.
7220         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
7221         (HFILES_NO_SRCDIR): Add x86-tdep.h.
7222         (ALLDEPFILES): Add x86-tdep.c.
7223         * arch-utils.h (default_in_indirect_branch_thunk): New.
7224         * arch-utils.c (default_in_indirect_branch_thunk): New.
7225         * i386-tdep: Include x86-tdep.h.
7226         (i386_in_indirect_branch_thunk): New.
7227         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
7228         function.
7229         * amd64-tdep: Include x86-tdep.h.
7230         (amd64_in_indirect_branch_thunk): New.
7231         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
7232
7233 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
7234
7235         PR gdb/23053
7236         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
7237         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
7238         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
7239         regression.
7240
7241 2018-04-12  Tom Tromey  <tom@tromey.com>
7242
7243         * rust-lang.c (rust_print_struct_def): Remove univariant code.
7244         (rust_evaluate_subexp): Likewise.
7245
7246 2018-04-12  Pedro Alves  <palves@redhat.com>
7247
7248         * procfs.c (procfs_detach): Make forward declaration's prototype
7249         match definition's protototype.
7250         (proc_get_LDT_entry): Remove stale do_cleanups call.
7251
7252 2018-04-12  Pedro Alves  <palves@redhat.com>
7253
7254         * target.h (target_ops::to_has_exited): Delete.
7255         (target_has_exited): Delete.
7256         * target-delegates.c: Regenerate.
7257
7258 2018-04-11  Pedro Alves  <palves@redhat.com>
7259
7260         * target.c (fileio_fh_t::t): Add comment.
7261         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
7262         (target_fileio_close): Handle a NULL target.
7263         (invalidate_fileio_fh): New.
7264         (target_close): Call it.
7265         * remote.c (remote_hostio_send_command): No longer check whether
7266         remote_desc is open.
7267
7268 2018-04-11  Pedro Alves  <palves@redhat.com>
7269
7270         * target.c (fileio_fh_t): Make it a named struct instead of a
7271         typedef.
7272         (fileio_fh_t::is_closed): New method.
7273         (DEF_VEC_O (fileio_fh_t)): Remove.
7274         (fileio_fhandles): Now a std::vector.
7275         (is_closed_fileio_fh): Delete.
7276         (acquire_fileio_fd): Adjust.  Rename parameters.
7277         (release_fileio_fd): Adjust.
7278         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
7279         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
7280         (target_fileio_close): Adjust.
7281
7282 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
7283
7284         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
7285         index.
7286
7287 2018-04-10  Pedro Alves  <palves@redhat.com>
7288
7289         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
7290         (scoped_finish_thread_state): New class.
7291         * infcmd.c (run_command_1): Use it instead of finish_thread_state
7292         cleanup.
7293         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
7294         (fetch_inferior_event, normal_stop): Likewise.
7295         * thread.c (finish_thread_state_cleanup): Delete.
7296
7297 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7298             Pedro Alves  <palves@redhat.com>
7299
7300         * value.c: Include "selftest.h" and "common/array-view.h".
7301         (struct range) <operator ==>: New.
7302         (test_ranges_contain): New.
7303         (check_ranges_vector): New.
7304         (test_insert_into_bit_range_vector): New.
7305         (_initialize_values): Register selftests.
7306         * common/array-view.h (operator==, operator!=): New.
7307
7308 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7309
7310         * common/gdb_vecs.h (unordered_remove): Add overload that takes
7311         an iterator.
7312         * inline-frame.c: Include <algorithm>.
7313         (struct inline_state): Add constructor.
7314         (inline_state_s): Remove.
7315         (DEF_VEC_O(inline_state_s)): Remove.
7316         (inline_states): Change type to std::vector.
7317         (find_inline_frame_state): Adjust to std::vector.
7318         (allocate_inline_frame_state): Remove.
7319         (clear_inline_frame_state): Adjust to std::vector.
7320         (skip_inline_frames): Adjust to std::vector.
7321
7322 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7323
7324         * tracepoint.h (struct trace_state_variable): Add constructor.
7325         <name>: Change type to std::string.
7326         * tracepoint.c (tsv_s): Remove.
7327         (DEF_VEC_O(tsv_s)): Remove.
7328         (tvariables): Change to std::vector.
7329         (create_trace_state_variable): Adjust to std::vector.
7330         (find_trace_state_variable): Likewise.
7331         (find_trace_state_variable_by_number): Likewise.
7332         (delete_trace_state_variable): Likewise.
7333         (trace_variable_command): Adjust to std::string.
7334         (delete_trace_variable_command): Likewise.
7335         (tvariables_info_1): Adjust to std::vector.
7336         (save_trace_state_variables): Likewise.
7337         (start_tracing): Likewise.
7338         (merge_uploaded_trace_state_variables): Adjust to std::vector
7339         and std::string.
7340         * target.h (struct target_ops)
7341         <to_download_trace_state_variable>: Pass reference to
7342         trace_state_variable.
7343         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
7344         * target-delegates.c: Re-generate.
7345         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
7346         (mi_tsv_deleted): Likewise.
7347         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
7348         * remote.c (remote_download_trace_state_variable): Change
7349         pointer to reference and adjust.
7350         * make-target-delegates (parse_argtypes): Handle references.
7351         (write_function_header): Likewise.
7352         (munge_type): Likewise.
7353
7354 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7355
7356         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7357         string_view-selftests.c.
7358         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
7359         testsuite.
7360         * unittests/basic_string_view/cons/char/1.cc: Likewise.
7361         * unittests/basic_string_view/cons/char/2.cc: Likewise.
7362         * unittests/basic_string_view/cons/char/3.cc: Likewise.
7363         * unittests/basic_string_view/element_access/char/1.cc:
7364         Likewise.
7365         * unittests/basic_string_view/element_access/char/empty.cc:
7366         Likewise.
7367         * unittests/basic_string_view/element_access/char/front_back.cc:
7368         Likewise.
7369         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
7370         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
7371         Likewise.
7372         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
7373         Likewise.
7374         * unittests/basic_string_view/modifiers/swap/char/1.cc:
7375         Likewise.
7376         * unittests/basic_string_view/operations/compare/char/1.cc:
7377         Likewise.
7378         * unittests/basic_string_view/operations/compare/char/13650.cc:
7379         Likewise.
7380         * unittests/basic_string_view/operations/copy/char/1.cc:
7381         Likewise.
7382         * unittests/basic_string_view/operations/data/char/1.cc:
7383         Likewise.
7384         * unittests/basic_string_view/operations/find/char/1.cc:
7385         Likewise.
7386         * unittests/basic_string_view/operations/find/char/2.cc:
7387         Likewise.
7388         * unittests/basic_string_view/operations/find/char/3.cc:
7389         Likewise.
7390         * unittests/basic_string_view/operations/find/char/4.cc:
7391         Likewise.
7392         * unittests/basic_string_view/operations/rfind/char/1.cc:
7393         Likewise.
7394         * unittests/basic_string_view/operations/rfind/char/2.cc:
7395         Likewise.
7396         * unittests/basic_string_view/operations/rfind/char/3.cc:
7397         Likewise.
7398         * unittests/basic_string_view/operations/substr/char/1.cc:
7399         Likewise.
7400         * unittests/basic_string_view/operators/char/2.cc: Likewise.
7401         * unittests/string_view-selftests.c: New file.
7402
7403 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7404
7405         * unittests/basic_string_view/capacity/1.cc: New file.
7406         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
7407         * unittests/basic_string_view/cons/char/1.cc: New file.
7408         * unittests/basic_string_view/cons/char/2.cc: New file.
7409         * unittests/basic_string_view/cons/char/3.cc: New file.
7410         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
7411         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
7412         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
7413         * unittests/basic_string_view/element_access/char/1.cc: New file.
7414         * unittests/basic_string_view/element_access/char/2.cc: New file.
7415         * unittests/basic_string_view/element_access/char/empty.cc: New file.
7416         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
7417         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
7418         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
7419         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
7420         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
7421         * unittests/basic_string_view/include.cc: New file.
7422         * unittests/basic_string_view/inserters/char/1.cc: New file.
7423         * unittests/basic_string_view/inserters/char/2.cc: New file.
7424         * unittests/basic_string_view/inserters/char/3.cc: New file.
7425         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
7426         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
7427         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
7428         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
7429         * unittests/basic_string_view/literals/types.cc: New file.
7430         * unittests/basic_string_view/literals/values.cc: New file.
7431         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
7432         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
7433         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
7434         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
7435         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
7436         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
7437         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
7438         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
7439         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
7440         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
7441         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
7442         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
7443         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
7444         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
7445         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
7446         * unittests/basic_string_view/operations/data/char/1.cc: New file.
7447         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
7448         * unittests/basic_string_view/operations/find/char/1.cc: New file.
7449         * unittests/basic_string_view/operations/find/char/2.cc: New file.
7450         * unittests/basic_string_view/operations/find/char/3.cc: New file.
7451         * unittests/basic_string_view/operations/find/char/4.cc: New file.
7452         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
7453         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
7454         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
7455         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
7456         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
7457         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
7458         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
7459         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
7460         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
7461         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
7462         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
7463         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
7464         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
7465         * unittests/basic_string_view/operators/char/2.cc: New file.
7466         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
7467         * unittests/basic_string_view/range_access/char/1.cc: New file.
7468         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
7469         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
7470         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
7471         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
7472         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
7473         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
7474         * unittests/basic_string_view/requirements/typedefs.cc: New file.
7475         * unittests/basic_string_view/typedefs.cc: New file.
7476         * unittests/basic_string_view/types/1.cc: New file.
7477
7478 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7479
7480         * common/gdb_string_view.h: Remove libstdc++ implementation
7481         details, adjust to gdb reality.
7482         * common/gdb_string_view.tcc: Likewise.
7483         * cli/cli-script.c (struct string_view): Remove.
7484         (user_args) <m_args>: Change element type to gdb::string_view.
7485         (user_args::insert_args): Adjust.
7486
7487 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7488
7489         * common/gdb_string_view.h: New file.
7490         * common/gdb_string_view.tcc: New file.
7491
7492 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7493
7494         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
7495         * configure: Re-generate.
7496
7497 2018-04-09  Pedro Alves  <palves@redhat.com>
7498
7499         * gdbarch.sh: Include "observable.h" instead of "observer.h".
7500         (set_target_gdbarch): Call
7501         gdb::observers::architecture_changed.notify instead of
7502         observer_notify_architecture_changed.
7503
7504 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7505
7506         * tracepoint.c (struct current_traceframe_cleanup): Remove.
7507         (do_restore_current_traceframe_cleanup): Remove.
7508         (restore_current_traceframe_cleanup_dtor): Remove.
7509         (make_cleanup_restore_current_traceframe): Remove.
7510         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
7511         New.
7512         * tracepoint.h (struct scoped_restore_current_traceframe): New.
7513         * infrun.c (fetch_inferior_event): Use
7514         scoped_restore_current_traceframe.
7515
7516 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7517
7518         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
7519         Remove.
7520         <n_allocated_type_units>: Remove.
7521         <all_type_units>: Change to std::vector.
7522         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
7523         to std::vector change.
7524         (dwarf2_per_objfile::get_cutu): Likewise.
7525         (dwarf2_per_objfile::get_tu): Likewise.
7526         (create_signatured_type_table_from_index): Likewise.
7527         (create_signatured_type_table_from_debug_names): Likewise.
7528         (dw2_symtab_iter_next): Likewise.
7529         (dw2_print_stats): Likewise.
7530         (dw2_expand_all_symtabs): Likewise.
7531         (dw2_expand_marked_cus): Likewise.
7532         (dw2_debug_names_iterator::next): Likewise.
7533         (dwarf2_initialize_objfile): Likewise.
7534         (add_signatured_type_cu_to_table): Likewise.
7535         (create_all_type_units): Likewise.
7536         (add_type_unit): Likewise.
7537         (struct tu_abbrev_offset): Add constructor.
7538         (build_type_psymtabs_1): Adjust to std::vector change.
7539         (print_tu_stats): Likewise.
7540         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
7541         (write_debug_names): Likewise.
7542
7543 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7544
7545         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
7546         Make an std::vector.
7547         <n_comp_units>: Remove.
7548         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
7549         to std::vector change.
7550         (dwarf2_per_objfile::get_cutu): Likewise.
7551         (dwarf2_per_objfile::get_cu): Likewise.
7552         (create_cus_from_index): Likewise.
7553         (create_addrmap_from_index): Likewise.
7554         (create_addrmap_from_aranges): Likewise.
7555         (dwarf2_read_index): Likewise.
7556         (dw2_find_last_source_symtab): Likewise.
7557         (dw2_map_symtabs_matching_filename): Likewise.
7558         (dw2_symtab_iter_next): Likewise.
7559         (dw2_print_stats): Likewise.
7560         (dw2_expand_all_symtabs): Likewise.
7561         (dw2_expand_symtabs_with_fullname): Likewise.
7562         (dw2_expand_marked_cus): Likewise.
7563         (dw2_map_symbol_filenames): Likewise.
7564         (create_cus_from_debug_names): Likewise.
7565         (dwarf2_read_debug_names): Likewise.
7566         (dw2_debug_names_iterator::next): Likewise.
7567         (dwarf2_initialize_objfile): Likewise.
7568         (set_partial_user): Likewise.
7569         (dwarf2_build_psymtabs_hard): Likewise.
7570         (read_comp_units_from_section): Remove arguments, adjust to
7571         std::vector change.
7572         (create_all_comp_units): Adjust to std::vector and
7573         read_comp_units_from_section changes.
7574         (dwarf2_find_containing_comp_unit): Adjust to std::vector
7575         change.
7576         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
7577         (psyms_seen_size): Likewise.
7578         (write_gdbindex): Likewise.
7579         (write_debug_names): Likewise.
7580
7581 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7582
7583         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
7584         with dwarf2_per_objfile.
7585         (create_cus_from_index): Likewise.
7586         (create_signatured_type_table_from_index): Likewise.
7587         (dwarf2_read_index): Likewise.
7588         (dwarf2_initialize_objfile): Likewise.
7589         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
7590         per_cu rather than get_dwarf2_per_objfile.
7591
7592 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7593
7594         * dwarf2read.h (struct signatured_type): Forward declare.
7595         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
7596         New methods.
7597         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
7598         (dw2_get_cutu): ...this.
7599         (dwarf2_per_objfile::get_cu): Rename from...
7600         (dw2_get_cu): ...this.
7601         (dwarf2_per_objfile::get_tu): New.
7602         (create_addrmap_from_index): Adjust.
7603         (create_addrmap_from_aranges): Adjust.
7604         (dw2_find_last_source_symtab): Adjust.
7605         (dw2_map_symtabs_matching_filename): Adjust.
7606         (dw2_symtab_iter_next): Adjust.
7607         (dw2_print_stats): Adjust.
7608         (dw2_expand_all_symtabs): Adjust.
7609         (dw2_expand_symtabs_with_fullname): Adjust.
7610         (dw2_expand_marked_cus): Adjust.
7611         (dw_expand_symtabs_matching_file_matcher): Adjust.
7612         (dw2_map_symbol_filenames): Adjust.
7613         (dw2_debug_names_iterator::next): Adjust.
7614         (dwarf2_initialize_objfile): Adjust.
7615         (set_partial_user): Adjust.
7616         (dwarf2_build_psymtabs_hard): Adjust.
7617
7618 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7619
7620         * dwarf2read.c (create_signatured_type_table_from_debug_names):
7621         Remove unused variables.
7622         (dw2_map_symtabs_matching_filename): Likewise.
7623         (dwarf2_record_block_ranges): Likewise.
7624         (dwarf2_read_addr_index): Likewise.
7625         (follow_die_offset): Likewise.
7626
7627 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7628
7629         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
7630         to symbol_file_add_main.
7631
7632 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7633
7634         PR mi/22299
7635         * mi/mi-console.c (do_fputc_async_safe): New.
7636         (mi_console_file::write_async_safe): New.
7637         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
7638         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
7639         New.
7640         * ui-file.c (ui_file::putstrn): Adjust call to
7641         fputstrn_unfiltered.
7642         * utils.c (printchar): Replace do_fputs and do_fprintf
7643         parameters by do_fputc.
7644         (fputstr_filtered): Adjust call to printchar.
7645         (fputstr_unfiltered): Likewise.
7646         (fputstrn_filtered): Likewise.
7647         (fputstrn_unfiltered): Add do_fputc parameter, pass to
7648         printchar.
7649         * utils.h (do_fputc_ftype): New typedef.
7650         (fputstrn_unfiltered): Add do_fputc parameter.
7651
7652 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7653
7654         * regformats/i386/i386-avx.dat: Remove.
7655
7656 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7657
7658         PR gdb/22979
7659         * amd64-tdep.c (amd64_none_init_abi): New function.
7660         (amd64_x32_none_init_abi): New function.
7661         (_initialize_amd64_tdep): Register handlers for x86-64 and
7662         x64_32 with GDB_OSABI_NONE.
7663         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
7664         GDB_OSABI_NONE osabi.
7665
7666 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7667
7668         PR gdb/22980
7669         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
7670         GDB_OSABI_NONE.
7671         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
7672         * osabi.c (gdb_osabi_names): Add "unknown" entry.
7673
7674 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7675
7676         * common/byte-vector.h (char_vector): New type.
7677         * target.h (target_read_alloc): Return
7678         gdb::optional<byte_vector>.
7679         (target_read_stralloc): Return gdb::optional<char_vector>.
7680         (target_get_osdata): Return gdb::optional<char_vector>.
7681         * target.c (target_read_alloc_1): Templatize.  Replacement
7682         manual memory management with vector.
7683         (target_read_alloc): Change return type, adjust.
7684         (target_read_stralloc): Change return type, adjust.
7685         (target_get_osdata): Change return type, adjust.
7686         * auxv.c (struct auxv_info) <length>: Remove.
7687         <data>: Change type to gdb::optional<byte_vector>.
7688         (auxv_inferior_data_cleanup): Free auxv_info with delete.
7689         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
7690         (target_auxv_search): Adjust.
7691         (fprint_target_auxv): Adjust.
7692         * avr-tdep.c (avr_io_reg_read_command): Adjust.
7693         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
7694         (linux_make_corefile_notes): Adjust.
7695         * osdata.c (get_osdata): Adjust.
7696         * remote.c (remote_get_threads_with_qxfer): Adjust.
7697         (remote_memory_map): Adjust.
7698         (remote_traceframe_info): Adjust.
7699         (btrace_read_config): Adjust.
7700         (remote_read_btrace): Adjust.
7701         (remote_pid_to_exec_file): Adjust.
7702         * solib-aix.c (solib_aix_get_library_list): Adjust.
7703         * solib-dsbt.c (decode_loadmap): Don't free buf.
7704         (dsbt_get_initial_loadmaps): Adjust.
7705         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
7706         * solib-target.c (solib_target_current_sos): Adjust.
7707         * tracepoint.c (sdata_make_value): Adjust.
7708         * xml-support.c (xinclude_start_include): Adjust.
7709         (xml_fetch_content_from_file): Adjust.
7710         * xml-support.h (xml_fetch_another): Change return type.
7711         (xml_fetch_content_from_file): Change return type.
7712         * xml-syscall.c (xml_init_syscalls_info): Adjust.
7713         * xml-tdesc.c (file_read_description_xml): Adjust.
7714         (fetch_available_features_from_target): Change return type.
7715         (target_fetch_description_xml): Adjust.
7716         (target_read_description_xml): Adjust.
7717
7718 2018-04-06  Tom Tromey  <tom@tromey.com>
7719
7720         * value.c (~value): Update.
7721         (struct value) <contents>: Now unique_xmalloc_ptr.
7722         (value_contents_bits_eq, allocate_value_contents)
7723         (value_contents_raw, value_contents_all_raw)
7724         (value_contents_for_printing, value_contents_for_printing_const)
7725         (set_value_enclosing_type): Update.
7726
7727 2018-04-06  Tom Tromey  <tom@tromey.com>
7728
7729         * value.c (range_s): Remove typedef, VEC.
7730         (struct range): Add operator<.
7731         (range_lessthan): Remove.
7732         (ranges_contain): Change type.
7733         (~value): Update.
7734         (struct value) <unavailable, optimized_out>: Now std::vector.
7735         (value_entirely_available)
7736         (value_entirely_covered_by_range_vector)
7737         (value_entirely_unavailable, value_entirely_optimized_out):
7738         Update.
7739         (insert_into_bit_range_vector): Change argument type.
7740         (find_first_range_overlap): Likewise.
7741         (struct ranges_and_idx, value_contents_bits_eq)
7742         (require_not_optimized_out, require_available): Update.
7743         (ranges_copy_adjusted): Change argument types.
7744         (value_optimized_out, value_copy, value_fetch_lazy): Update.
7745
7746 2018-04-06  Tom Tromey  <tom@tromey.com>
7747
7748         * value.c (~value): Update.
7749         (struct value) <parent>: Now a value_ref_ptr.
7750         (value_parent, set_value_parent, value_address, value_copy):
7751         Update.
7752
7753 2018-04-06  Tom Tromey  <tom@tromey.com>
7754
7755         * value.c (struct value): Add constructor, destructor, and member
7756         initializers.
7757         (allocate_value_lazy, value_decref): Update.
7758
7759 2018-04-06  Tom Tromey  <tom@tromey.com>
7760
7761         * value.c (struct value) <released, next>: Remove.
7762         (all_values): Now a std::vector.
7763         (allocate_value_lazy): Update.
7764         (value_next): Remove.
7765         (value_mark, value_free_to_mark, release_value)
7766         (value_release_to_mark): Update.
7767
7768 2018-04-06  Tom Tromey  <tom@tromey.com>
7769
7770         * value.h (fetch_subexp_value, value_release_to_mark): Update.
7771         (free_value_chain): Remove.
7772         * value.c (free_value_chain): Remove.
7773         (value_release_to_mark): Return a std::vector.
7774         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
7775         std::vector.
7776         (check_condition): Update.
7777         * eval.c (fetch_subexp_value): Change "val_chain" to a
7778         std::vector.
7779         * breakpoint.c (update_watchpoint): Update.
7780         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
7781
7782 2018-04-06  Tom Tromey  <tom@tromey.com>
7783
7784         * value.h (free_all_values): Remove.
7785         * value.c (free_all_values): Remove.
7786
7787 2018-04-06  Tom Tromey  <tom@tromey.com>
7788
7789         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
7790         (value_history_chain, value_history_count): Remove.
7791         (value_history): New global.
7792         (record_latest_value, access_value_history, show_values)
7793         (preserve_values): Update.
7794
7795 2018-04-06  Tom Tromey  <tom@tromey.com>
7796
7797         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
7798         * varobj.c (varobj_set_display_format, varobj_set_value)
7799         (install_default_visualizer, construct_visualizer)
7800         (install_new_value, ~varobj, varobj_get_value_type)
7801         (my_value_of_variable, varobj_editable_p): Update.
7802         * c-varobj.c (c_describe_child, c_value_of_variable)
7803         (cplus_number_of_children, cplus_describe_child): Update.
7804         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
7805         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
7806         (ada_value_of_variable, ada_value_is_changeable_p): Update.
7807
7808 2018-04-06  Tom Tromey  <tom@tromey.com>
7809
7810         * printcmd.c (last_examine_address): Change type to
7811         value_ref_ptr.
7812         (do_examine, x_command): Update.
7813
7814 2018-04-06  Tom Tromey  <tom@tromey.com>
7815
7816         * value.c (release_value): Update.
7817         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
7818         (struct bpstats) <val>: Now a value_ref_ptr.
7819         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
7820         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
7821         (~watchpoint, print_it_watchpoint, watch_command_1)
7822         (invalidate_bp_value_on_memory_change): Update.
7823
7824 2018-04-06  Tom Tromey  <tom@tromey.com>
7825
7826         * varobj.c (varobj_clear_saved_item)
7827         (update_dynamic_varobj_children, install_new_value, ~varobj):
7828         Update.
7829         * value.h (value_incref): Move declaration earlier.
7830         (value_decref): Rename from value_free.
7831         (struct value_ref_policy): New.
7832         (value_ref_ptr): New typedef.
7833         (struct value_deleter): Remove.
7834         (gdb_value_up): Remove typedef.
7835         (release_value): Change return type.
7836         (release_value_or_incref): Remove.
7837         * value.c (set_value_parent): Update.
7838         (value_incref): Change return type.
7839         (value_decref): Rename from value_free.
7840         (value_free_to_mark, free_all_values, free_value_chain): Update.
7841         (release_value): Return value_ref_ptr.
7842         (release_value_or_incref): Remove.
7843         (record_latest_value, set_internalvar, clear_internalvar):
7844         Update.
7845         * stack.c (info_frame_command): Don't call value_free.
7846         * python/py-value.c (valpy_dealloc, valpy_new)
7847         (value_to_value_object): Update.
7848         * printcmd.c (do_examine): Update.
7849         * opencl-lang.c (lval_func_free_closure): Update.
7850         * mi/mi-main.c (register_changed_p): Don't call value_free.
7851         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
7852         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
7853         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
7854         value_free.
7855         * guile/scm-value.c (vlscm_free_value_smob)
7856         (vlscm_scm_from_value): Update.
7857         * frame.c (frame_register_unwind, frame_unwind_register_signed)
7858         (frame_unwind_register_unsigned, get_frame_register_bytes)
7859         (put_frame_register_bytes): Don't call value_free.
7860         * findvar.c (address_from_register): Don't call value_free.
7861         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
7862         * dwarf2loc.c (entry_data_value_free_closure)
7863         (value_of_dwarf_reg_entry, free_pieced_value_closure)
7864         (dwarf2_evaluate_loc_desc_full): Update.
7865         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
7866         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
7867         (~watchpoint, watch_command_1)
7868         (invalidate_bp_value_on_memory_change): Update.
7869         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
7870
7871 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
7872
7873         PR gdb/23022
7874         * warning.m4: Add -Wno-error=deprecated-register.
7875         * configure: Re-generate.
7876
7877 2018-04-05  Tom Tromey  <tom@tromey.com>
7878
7879         * linespec.h: Remove include of "vec.h".
7880
7881 2018-04-05  Tom Tromey  <tom@tromey.com>
7882
7883         * linespec.c (typep): Remove typedef.
7884         (find_methods, find_superclass_methods): Take a std::vector.
7885         (find_method): Use std::vector.
7886
7887 2018-04-05  Tom Tromey  <tom@tromey.com>
7888
7889         * utils.c (compare_strings): Remove.
7890         * utils.h (compare_strings): Remove.
7891         * objc-lang.h (find_imps): Update.
7892         * objc-lang.c (find_methods): Take a std::vector.
7893         (uniquify_strings, find_imps): Likewise.
7894         * linespec.c (find_methods): Take a std::vector.
7895         (decode_objc): Use std::vector.
7896         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
7897         a std::vector.
7898         (find_method, find_function_symbols): Use std::vector.
7899
7900 2018-04-05  Tom Tromey  <tom@tromey.com>
7901
7902         * completer.c (completion_tracker::completion_tracker): Remove
7903         cast.
7904         (completion_tracker::discard_completions): Likewise.
7905         * breakpoint.c (ambiguous_names_p): Remove cast.
7906         * ada-lang.c (_initialize_ada_language): Remove cast.
7907         * utils.h (streq): Update.
7908         (streq_hash): Add new declaration.
7909         * utils.c (streq): Return bool.
7910         (streq_hash): New function.
7911
7912 2018-04-05  Tom Tromey  <tom@tromey.com>
7913
7914         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
7915         Remove a string copy.
7916
7917 2018-04-05  Tom Tromey  <tom@tromey.com>
7918
7919         * linespec.c (filter_results): Use std::vector.
7920         (decode_line_2, decode_line_full): Update.
7921
7922 2018-04-05  Tom Tromey  <tom@tromey.com>
7923
7924         * linespec.c (canonical_to_fullform): Return std::string.
7925         (filter_results): Update.
7926         (struct decode_line_2_item): Add constructor.
7927         <fullform, displayform>: Now std::string.
7928         (decode_line_2_compare_items): Now a std::sort comparator.
7929         (decode_line_2): Update.
7930
7931 2018-04-05  Tom Tromey  <tom@tromey.com>
7932
7933         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
7934         (unexpected_linespec_error): Update.
7935         (linespec_parse_basic, parse_linespec): Update.
7936
7937 2018-04-05  Tom Tromey  <tom@tromey.com>
7938
7939         * linespec.c (linespec_parse_basic): Reindent.
7940
7941 2018-04-05  Tom Tromey  <tom@tromey.com>
7942
7943         * minsyms.h (iterate_over_minimal_symbols): Update.
7944         * minsyms.c (iterate_over_minimal_symbols): Take a
7945         gdb::function_view.
7946         * linespec.c (struct collect_minsyms): Remove.
7947         (compare_msyms): Now a std::sort comparator.
7948         (add_minsym): Add parameters.
7949         (search_minsyms_for_name): Update.  Use std::vector.
7950
7951 2018-04-03  Tom Tromey  <tom@tromey.com>
7952
7953         * mipsread.c (read_alphacoff_dynamic_symtab): Use
7954         gdb::byte_vector.
7955
7956 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
7957
7958         * MAINTAINERS (Write After Approval): Add Weimin Pan.
7959
7960 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
7961
7962         PR gdb/16959
7963         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
7964         printing static type.
7965
7966 2018-04-01  Tom Tromey  <tom@tromey.com>
7967
7968         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
7969         (rs6000_xfer_shared_libraries): Update.
7970
7971 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
7972
7973         * common/gdb_vecs.h (char_ptr): Remove.
7974         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
7975
7976 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
7977
7978         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
7979         with std::vector.
7980         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
7981
7982 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
7983
7984         * tracepoint.h (struct uploaded_tp): Initialize fields.
7985         <actions, step_actions, cmd_strings>: Change type to
7986         std::vector<char *>.
7987         * tracepoint.c (get_uploaded_tp): Allocate with new.
7988         (free_uploaded_tps): Free with delete.
7989         (parse_tracepoint_definition): Adjust to std::vector change.
7990         * breakpoint.c (read_uploaded_action): Likewise.
7991         (create_tracepoint_from_upload): Likewise.
7992         * ctf.c (ctf_write_uploaded_tp): Likewise.
7993         (SET_ARRAY_FIELD): Likewise.
7994         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
7995
7996 2018-03-30  Tom Tromey  <tom@tromey.com>
7997
7998         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
7999         std::unique_ptr.
8000         (svr4_keep_data_in_core): Update.
8001         (svr4_read_so_list): Update.
8002
8003 2018-03-30  Tom Tromey  <tom@tromey.com>
8004
8005         * windows-nat.c (handle_output_debug_string, handle_exception):
8006         Update.
8007         * target.h (target_read_string): Update.
8008         * target.c (target_read_string): Change "string" to
8009         unique_xmalloc_ptr.
8010         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
8011         Update.
8012         * solib-frv.c (frv_current_sos): Update.
8013         * solib-dsbt.c (dsbt_current_sos): Update.
8014         * solib-darwin.c (darwin_current_sos): Update.
8015         * linux-thread-db.c (inferior_has_bug): Update.
8016         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
8017         Update.  Remove alloca.
8018         * ada-lang.c (ada_main_name): Update.
8019
8020 2018-03-30  Tom Tromey  <tom@tromey.com>
8021
8022         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
8023         (struct dwo_file_deleter): New.
8024         (dwo_file_up): New typedef.
8025         (open_and_init_dwo_file): Use dwo_file_up.
8026         (free_dwo_file_cleanup): Remove.
8027
8028 2018-03-30  Tom Tromey  <tom@tromey.com>
8029
8030         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
8031         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
8032
8033 2018-03-30  Tom Tromey  <tom@tromey.com>
8034
8035         * dwarf2read.c (class free_cached_comp_units): New class.
8036         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
8037         (free_cached_comp_units): Remove function.
8038
8039 2018-03-30  Tom Tromey  <tom@tromey.com>
8040
8041         * utils.h (make_cleanup_unpush_target): Remove.
8042         * inf-ptrace.c (struct target_unpusher): New.
8043         (target_unpush_up) New typedef.
8044         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
8045         target_unpush_up.
8046         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
8047
8048 2018-03-27  Tom Tromey  <tom@tromey.com>
8049
8050         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
8051
8052 2018-03-27  Pedro Alves  <palves@redhat.com>
8053             Tom Tromey  <tom@tromey.com>
8054
8055         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
8056         destructor.  Now a class.
8057         (gdb_readline_wrapper_cleanup): Remove function.
8058         (gdb_readline_wrapper): Remove cleanups.
8059
8060 2018-03-27  Tom Tromey  <tom@tromey.com>
8061
8062         * typeprint.h (struct type_print_options) <local_typedefs,
8063         global_typedefs>: Remove "struct" keyword.
8064         (class typedef_hash_table): New class.
8065         (recursively_update_typedef_hash, add_template_parameters)
8066         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
8067         (find_typedef_in_hash): Don't declare.
8068         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
8069         (typedef_hash_table::recursively_update): Rename from
8070         recursively_update_typedef_hash.  Now a member.
8071         (typedef_hash_table::add_template_parameters): Rename from
8072         add_template_parameters.  Now a member.
8073         (typedef_hash_table::typedef_hash_table): Now a constructor;
8074         rename from create_typedef_hash.
8075         (typedef_hash_table::~typedef_hash_table): Now a destructor;
8076         rename from free_typedef_hash.
8077         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
8078         (do_free_global_table): Remove.
8079         (typedef_hash_table::typedef_hash_table): New constructor; renamed
8080         from copy_type_recursive.
8081         (create_global_typedef_table): Remove.
8082         (typedef_hash_table::find_global_typedef): Now a member of
8083         typedef_hash_table.
8084         (typedef_hash_table::find_typedef): Rename from
8085         find_typedef_in_hash; now a member.
8086         (whatis_exp): Update.
8087         * extension.h (struct ext_lang_type_printers): Add constructor and
8088         destructor.
8089         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
8090         declare.
8091         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
8092         Now a constructor; rename from start_ext_lang_type_printers.
8093         (ext_lang_type_printers): Now a destructor; rename from
8094         free_ext_lang_type_printers.
8095         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
8096         Update.
8097         (c_type_print_base_struct_union): Update.  Remove cleanups.
8098
8099 2018-03-27  Tom Tromey  <tom@tromey.com>
8100
8101         * dwarf-index-write.c: Include <cmath>.
8102
8103 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
8104
8105         * NEWS: Add entry describing new "set|show varsize-limit" command.
8106         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
8107         command.
8108         * printcmd.c (_initialize_printcmd): Add "set var" alias of
8109         "set variable".
8110
8111 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
8112
8113         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
8114         dwarf-index-write.c
8115         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
8116         * dwarf-index-common.c: New file.
8117         * dwarf-index-common.h: New file.
8118         * dwarf-index-write.c: New file.
8119         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
8120         (struct dwarf2_section_info): Move from here.
8121         (dwarf2_section_info_def): Likewise.
8122         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
8123         (offset_type): Likewise.
8124         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
8125         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
8126         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
8127         (byte_swap): Likewise.
8128         (MAYBE_SWAP): Likewise.
8129         (dwarf2_per_cu_ptr): Likewise.
8130         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
8131         (struct tu_stats): Likewise.
8132         (struct dwarf2_per_objfile): Likewise.
8133         (struct dwarf2_per_cu_data): Likewise.
8134         (struct signatured_type): Likewise.
8135         (sig_type_ptr): Likewise.
8136         (DEF_VEC_P (sig_type_ptr)): Likewise.
8137         (INDEX4_SUFFIX): Likewise.
8138         (INDEX5_SUFFIX): Likewise.
8139         (DEBUG_STR_SUFFIX): Likewise.
8140         (dwarf2_read_section): Make non-static.
8141         (mapped_index_string_hash): Move from here.
8142         (dwarf5_djb_hash): Likewise.
8143         (file_write): Likewise.
8144         (class data_buf): Likewise.
8145         (struct symtab_index_entry): Likewise.
8146         (struct mapped_symtab): Likewise.
8147         (find_slot): Likewise.
8148         (hash_expand): Likewise.
8149         (add_index_entry): Likewise.
8150         (uniquify_cu_indices): Likewise.
8151         (class c_str_view): Likewise.
8152         (class c_str_view_hasher): Likewise.
8153         (class vector_hasher): Likewise.
8154         (write_hash_table): Likewise.
8155         (psym_index_map): Likewise.
8156         (struct addrmap_index_data): Likewise.
8157         (add_address_entry): Likewise.
8158         (add_address_entry_worker): Likewise.
8159         (write_address_map): Likewise.
8160         (symbol_kind): Likewise.
8161         (write_psymbols): Likewise.
8162         (struct signatured_type_index_data): Likewise.
8163         (write_one_signatured_type): Likewise.
8164         (recursively_count_psymbols): Likewise.
8165         (recursively_write_psymbols): Likewise.
8166         (class debug_names): Likewise.
8167         (check_dwarf64_offsets): Likewise.
8168         (psyms_seen_size): Likewise.
8169         (write_gdbindex): Likewise.
8170         (write_debug_names): Likewise.
8171         (assert_file_size): Likewise.
8172         (write_psymtabs_to_index): Likewise.
8173         (save_gdb_index_command): Likewise.
8174         (_initialize_dwarf2_read): Don't register the "save gdb-index"
8175         command.
8176         * dwarf2read.h: New file.
8177
8178 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
8179
8180         PR gdb/22670
8181         * dwarf2read.c (dwarf2_physname): Do not return the demangled
8182         symbol name if the CU's language stores symbol names in linkage
8183         format.
8184         * language.h (struct language_defn)
8185         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
8186         all instances of this struct.
8187
8188 2018-03-26  Tom Tromey  <tom@tromey.com>
8189
8190         * stack.c (backtrace_command_1): Remove verbose code.
8191
8192 2018-03-26  Tom Tromey  <tom@tromey.com>
8193
8194         * python/py-framefilter.c (py_print_type): Don't catch
8195         exceptions.  Return void.
8196         (py_print_value): Likewise.
8197         (py_print_single_arg): Likewise.
8198         (enumerate_args): Don't catch exceptions.
8199         (py_print_args): Likewise.
8200         (py_print_frame): Likewise.
8201         (gdbpy_apply_frame_filter): Catch exceptions here.
8202
8203 2018-03-26  Tom Tromey  <tom@tromey.com>
8204
8205         * stack.c (_initialize_stack): Remove trailing newlines from help
8206         text.  Add "Usage" line to "backtrace" help.
8207
8208 2018-03-26  Tom Tromey  <tom@tromey.com>
8209
8210         PR python/16486:
8211         * python/py-framefilter.c (py_print_args): Call wrap_hint.
8212
8213 2018-03-26  Tom Tromey  <tom@tromey.com>
8214
8215         * python/py-framefilter.c (py_print_single_arg): Return
8216         EXT_LANG_BT_ERROR from catch.
8217
8218 2018-03-26  Tom Tromey  <tom@tromey.com>
8219
8220         PR backtrace/15584:
8221         * stack.c (backtrace_command_1): Move some code into no-filters
8222         "if".
8223
8224 2018-03-26  Tom Tromey  <tom@tromey.com>
8225
8226         * python/py-framefilter.c (throw_quit_or_print_exception): New
8227         function.
8228         (gdbpy_apply_frame_filter): Use it.
8229
8230 2018-03-26  Tom Tromey  <tom@tromey.com>
8231
8232         PR cli/17716:
8233         * python/py-framefilter.c (py_print_type, py_print_value)
8234         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
8235         RETURN_MASK_ERROR.
8236
8237 2018-03-26  Tom Tromey  <tom@tromey.com>
8238
8239         * python/py-framefilter.c (enumerate_args): Use
8240         gdb::unique_xmalloc_ptr.
8241
8242 2018-03-26  Tom Tromey  <tom@tromey.com>
8243
8244         * python/py-framefilter.c (py_print_frame): Return
8245         EXT_LANG_BT_OK.
8246         (gdbpy_apply_frame_filter): Update comment.
8247         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
8248         Remove.
8249         <EXT_LANG_BT_NO_FILTERS>: Change value.
8250
8251 2018-03-26  Tom Tromey  <tom@tromey.com>
8252
8253         PR backtrace/15582:
8254         * stack.c (backtrace_command): Parse "hide" argument.
8255         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
8256         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
8257         constant.
8258
8259 2018-03-26  Tom Tromey  <tom@tromey.com>
8260
8261         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
8262         add "flags".
8263         (backtrace_command): Remove "fulltrace", add "flags".
8264
8265 2018-03-26  Tom Tromey  <tom@tromey.com>
8266
8267         * stack.c (backtrace_command): Rewrite command line parsing.
8268
8269 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
8270
8271         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
8272
8273 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
8274
8275         * filename-seen-cache.h: Add include guard.
8276
8277 2018-03-26  Keith Seitz  <keiths@redhat.com>
8278
8279         * symfile.c (place_section): Remove "struct" from section_addr_info
8280         in comment.
8281         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
8282         "struct" keyword from section_addr_info.
8283
8284 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
8285
8286         * regformats/regdef.h (reg): Add constructors.
8287
8288 2018-03-25  Pedro Alves  <palves@redhat.com>
8289
8290         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
8291         if then/else bodies in var_func_name extraction.
8292
8293 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
8294
8295         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
8296         lookup_minimal_symbol() to find symbol entry.
8297         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
8298
8299 2018-03-23  Keith Seitz  <keiths@redhat.com>
8300
8301         PR c++/22968
8302         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
8303         nested type definitions for C++, too.
8304
8305 2018-03-23  Tom Tromey  <tom@tromey.com>
8306
8307         * machoread.c (struct oso_el): Add a constructor.  Don't define as
8308         a typedef.
8309         (macho_register_oso): Remove.
8310         (macho_symtab_read): Take a std::vector.
8311         (oso_el_compare_name): Now a std::sort comparator.
8312         (macho_symfile_read_all_oso): Take a std::vector.
8313         (macho_symfile_read): Use std::vector.  Remove cleanups.
8314
8315 2018-03-22  Tom Tromey  <tom@tromey.com>
8316
8317         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
8318         (record_full_goto_bookmark): Use std::string.
8319
8320 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8321
8322         PR tdep/18295
8323         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
8324         a single mask.
8325
8326 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8327
8328         * rs6000-tdep.c (store_insn_p): New function.
8329         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
8330         and cr_reg to their unshifted values. Use store_insn_p to
8331         match LR saves using either R1 or fdata->alloca_reg. Use
8332         store_insn_p to match CR saves. Set alloca_reg_offset
8333         when alloca_reg and framep are set. Remove lr_reg shift
8334         when assigning to fdata->lr_register.
8335
8336 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
8337
8338         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
8339         command line args instead of emitting a warning.
8340
8341 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
8342
8343         * tracepoint.h (struct static_tracepoint_marker): Initialize
8344         fields, define default constructor, move constructor and move
8345         assignment, disable the rest.
8346         <str_id, extra>: Make std::string.
8347         (release_static_tracepoint_marker): Remove.
8348         (free_current_marker): Remove.
8349         * tracepoint.c (free_current_marker): Remove.
8350         (parse_static_tracepoint_marker_definition): Adjust to
8351         std::string, use new hex2str overload.
8352         (release_static_tracepoint_marker): Remove.
8353         (print_one_static_tracepoint_marker): Get marker by reference
8354         and adjust to std::string.
8355         (info_static_tracepoint_markers_command): Adjust to std::vector
8356         changes
8357         * target.h (static_tracepoint_marker_p): Remove typedef.
8358         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
8359         (struct target_ops) <to_static_tracepoint_marker_at>: Return
8360         bool.
8361         <to_static_tracepoint_markers_by_strid>: Return std::vector.
8362         * target-debug.h
8363         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
8364         (target_debug_print_std_vector_static_tracepoint_marker): New.
8365         (target_debug_print_struct_static_tracepoint_marker_p): Rename
8366         to...
8367         (target_debug_print_static_tracepoint_marker_p): ... this.
8368         * target-delegates.c: Re-generate.
8369         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
8370         Make std::string.
8371         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
8372         (decode_static_tracepoint_spec): Adjust to std::vector.
8373         (tracepoint_print_one_detail): Adjust to std::string.
8374         (strace_marker_decode_location): Adjust to std::string.
8375         (update_static_tracepoint): Adjust to std::string, remove call
8376         to release_static_tracepoint_marker.
8377         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
8378         Adjust to std::vector.
8379         * remote.c (remote_static_tracepoint_marker_at): Return bool.
8380         (remote_static_tracepoint_markers_by_strid): Adjust to
8381         std::vector.
8382         * common/rsp-low.h (hex2str): New overload with explicit count
8383         of bytes.
8384         * common/rsp-low.c (hex2str): New overload with explicit count
8385         of bytes.
8386         * unittests/rsp-low-selftests.c (test_hex2str): New function.
8387         (_initialize_rsp_low_selftests): Add test_hex2str test.
8388         * unittests/tracepoint-selftests.c
8389         (test_parse_static_tracepoint_marker_definition): Adjust to
8390         std::string.
8391
8392 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
8393
8394         * tracepoint.c (parse_static_tracepoint_marker_definition):
8395         Consider case where the definition is followed by more
8396         definitions.
8397         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8398         tracepoint-selftests.c.
8399         * unittests/tracepoint-selftests.c: New.
8400
8401 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8402
8403         * MAINTAINERS (Write After Approval): Add Pedro Franco de
8404         Carvalho.
8405
8406 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
8407
8408         * symtab.c (find_pc_sect_line): fixed indentation.
8409
8410 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
8411
8412         * symtab.c (find_pc_sect_line): now uses binary search.
8413
8414 2018-03-19  Tom Tromey  <tom@tromey.com>
8415
8416         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
8417         "IDENT" production.
8418
8419 2018-03-19  Pedro Alves  <palves@redhat.com>
8420             Tom Tromey  <tom@tromey.com>
8421
8422         * unittests/observable-selftests.c: New file.
8423         * common/observable.h: New file.
8424         * observable.h: New file.
8425         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
8426         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
8427         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
8428         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
8429         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
8430         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
8431         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
8432         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
8433         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
8434         python/py-breakpoint.c, python/py-finishbreakpoint.c,
8435         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
8436         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
8437         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
8438         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
8439         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
8440         tui/tui-interp.c, valops.c: Update all users.
8441         * tui/tui-hooks.c (tui_bp_created_observer)
8442         (tui_bp_deleted_observer, tui_bp_modified_observer)
8443         (tui_inferior_exit_observer, tui_before_prompt_observer)
8444         (tui_normal_stop_observer, tui_register_changed_observer):
8445         Remove.
8446         (tui_observers_token): New global.
8447         (attach_or_detach, tui_attach_detach_observers): New functions.
8448         (tui_install_hooks, tui_remove_hooks): Use
8449         tui_attach_detach_observers.
8450         * record-btrace.c (record_btrace_thread_observer): Remove.
8451         (record_btrace_thread_observer_token): New global.
8452         * observer.sh: Remove.
8453         * observer.c: Rename to observable.c.
8454         * observable.c (namespace gdb_observers): Define new objects.
8455         (observer_debug): Move into gdb_observers namespace.
8456         (struct observer, struct observer_list, xalloc_observer_list_node)
8457         (xfree_observer_list_node, generic_observer_attach)
8458         (generic_observer_detach, generic_observer_notify): Remove.
8459         (_initialize_observer): Update.
8460         Don't include observer.inc.
8461         * Makefile.in (generated_files): Remove observer.h, observer.inc.
8462         (clean mostlyclean): Likewise.
8463         (observer.h, observer.inc): Remove targets.
8464         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
8465         (COMMON_SFILES): Use observable.c, not observer.c.
8466         * .gitignore: Remove observer.h.
8467
8468 2018-03-18  Tom Tromey  <tom@tromey.com>
8469
8470         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
8471         gdb::def_vector.
8472         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
8473
8474 2018-03-17  Tom Tromey  <tom@tromey.com>
8475
8476         * auto-load.c (auto_load_objfile_script_1): Use std::string.
8477
8478 2018-03-17  Tom Tromey  <tom@tromey.com>
8479
8480         * target.c (class scoped_target_fd): New.
8481         (target_fileio_close_cleanup): Remove.
8482         (target_fileio_read_alloc_1): Use scoped_target_fd.
8483
8484 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
8485
8486         * silent-rules.mk: New.
8487         * Makefile.in: Include silent-rules.mk
8488         (srcdir, VPATH, top_srcdir): Move up.
8489         (COMPILE): Add ECHO_CXX.
8490         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
8491         (init.c): Add ECHO_INIT_C.
8492         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
8493         (version.c): Add ECHO_GEN.
8494         (printcmd.o): Add ECHO_CXX.
8495         (target-float.o): Add ECHO_CXX.
8496         (ada-exp.o): Add ECHO_CXX.
8497         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
8498         (insight$(EXEEXT)): Add ECHO_CXXLD.
8499         * gnulib/configure.ac: Add AM_SILENT_RULES.
8500         * gnulib/aclocal.m4: Re-generate.
8501         * gnulib/configure: Re-generate.
8502         * gnulib/import/Makefile.in: Re-generate.
8503
8504 2018-03-16  Tom Tromey  <tom@tromey.com>
8505
8506         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
8507         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
8508         * utils.c (do_free_section_addr_info)
8509         (make_cleanup_free_section_addr_info): Remove.
8510         * symfile.h (struct other_sections): Add constructor.
8511         (struct section_addr_info): Remove.
8512         (section_addr_info): New typedef.
8513         (struct sym_fns) <sym_offsets>: Change type of parameter.
8514         (build_section_addr_info_from_objfile)
8515         (relative_addr_info_to_section_offsets, addr_info_make_relative)
8516         (default_symfile_offsets, symbol_file_add)
8517         (symbol_file_add_from_bfd)
8518         (build_section_addr_info_from_section_table): Update.
8519         (alloc_section_addr_info, free_section_addr_info): Don't declare.
8520         * symfile.c (alloc_section_addr_info): Remove.
8521         (build_section_addr_info_from_section_table): Change return type.
8522         Update.
8523         (build_section_addr_info_from_bfd)
8524         (build_section_addr_info_from_objfile): Likewise.
8525         (free_section_addr_info): Remove.
8526         (relative_addr_info_to_section_offsets): Change type of "addrs".
8527         (addrs_section_compar): Now a std::sort comparator.
8528         (addrs_section_sort): Change return type.
8529         (addr_info_make_relative): Change type of "addrs".  Update.
8530         (default_symfile_offsets, syms_from_objfile_1)
8531         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
8532         (symbol_file_add_separate): Update.
8533         (symbol_file_add): Change type of "addrs".  Update.
8534         (add_symbol_file_command): Update.  Remove cleanups.
8535         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
8536         cleanups.
8537         * symfile-debug.c (debug_sym_offsets): Change type of "info".
8538         * solib.c (solib_read_symbols): Update.
8539         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
8540         * machoread.c (macho_symfile_offsets): Update.
8541         * jit.c (jit_bfd_try_read_symtab): Update.
8542
8543 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
8544
8545         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8546         unittests/utils-selftests.c.
8547         * unittests/utils-selftests.c: New file.
8548
8549 2018-03-14  Tom Tromey  <tom@tromey.com>
8550
8551         PR cli/14977:
8552         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
8553         for NULL.
8554
8555 2018-03-14  Tom Tromey  <tom@tromey.com>
8556
8557         PR cli/19918:
8558         * printcmd.c (printf_pointer): Allow "-" in format.
8559
8560 2018-03-14  Tom Tromey  <tom@tromey.com>
8561
8562         * printcmd.c (_initialize_printcmd): Add usage to printf.
8563
8564 2018-03-14  Yao Qi  <qiyao@sourceware.org>
8565
8566         * MAINTAINERS: Update my email address.
8567
8568 2018-03-13  Tom Tromey  <tom@tromey.com>
8569
8570         * machoread.c (macho_check_dsym): Change filenamep to a
8571         std::string*.
8572         (macho_symfile_read): Update.
8573         * symfile.c (load_command): Use std::string.
8574
8575 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
8578         to error message string.
8579         (riscv_register_name): Use xsnprintf instead of sprintf.
8580         (riscv_insn::fetch_instruction): Use gdb_assert instead of
8581         internal_error.
8582         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
8583         error.
8584         (riscv_push_dummy_call): Likewise.
8585
8586 2018-03-12  Tom Tromey  <tom@tromey.com>
8587
8588         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
8589         Use gdb::byte_vector.
8590         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
8591
8592 2018-03-12  Yao Qi  <yao.qi@linaro.org>
8593
8594         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
8595         parameter type to readable_regcache.
8596         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
8597         the declaration.
8598
8599 2018-03-11  Tom Tromey  <tom@tromey.com>
8600
8601         * dwarf2read.c (struct nextfield): Add initializers.
8602         (struct nextfnfield): Remove.
8603         (struct fnfieldlist): Add initializers.  Remove "length" and
8604         "head", use std::vector.
8605         (struct decl_field_list): Remove.
8606         (struct field_info): Add initializers.
8607         <fields, baseclasses>: Now std::vector.
8608         <nbaseclasses, nfnfields, typedef_field_list_count,
8609         nested_types_list_count>: Remove.
8610         (dwarf2_add_field, dwarf2_add_type_defn)
8611         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
8612         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
8613         (process_structure_scope): Update.
8614
8615 2018-03-11  Tom Tromey  <tom@tromey.com>
8616
8617         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
8618         for use by std::sort.
8619         (build_type_psymtabs_1): Use std::vector.
8620
8621 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
8622
8623         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
8624         and LIBMPFR in the printed configuration.
8625
8626 2018-03-08  Tom Tromey  <tom@tromey.com>
8627
8628         * source.c (get_filename_and_charpos): Use scoped_fd.
8629         * nto-procfs.c (procfs_open_1): Use scoped_fd.
8630         (procfs_pidlist): Likewise.
8631         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
8632         (iterate_over_mappings): Likewise.
8633
8634 2018-03-08  Tom Tromey  <tom@tromey.com>
8635
8636         * infcall.c (struct call_return_meta_info)
8637         <stack_temporaries_enabled>: Remove.
8638         (get_call_return_value, call_function_by_hand_dummy): Update.
8639         * thread.c (disable_thread_stack_temporaries): Remove.
8640         (enable_thread_stack_temporaries): Remove.
8641         (thread_stack_temporaries_enabled_p): Return bool.
8642         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
8643         (get_last_thread_stack_temporary): Update.
8644         * eval.c (evaluate_subexp): Update.
8645         * gdbthread.h (class enable_thread_stack_temporaries): Now a
8646         class, not a function.
8647         (value_ptr, value_vec): Remove typedefs.
8648         (class thread_info) <stack_temporaries_enabled>: Now bool.
8649         <stack_temporaries>: Now a std::vector.
8650         (thread_stack_temporaries_enabled_p)
8651         (value_in_thread_stack_temporaries): Return bool.
8652
8653 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
8654
8655         * remote.c (putpkt_binary): Fix omitted bytes reporting.
8656         (getpkt_or_notif_sane_1): Likewise.
8657
8658 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8659
8660         * build-id.c (build_id_to_debug_bfd): Use std::string.
8661
8662 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8663
8664         * build-id.c (find_separate_debug_file_by_buildid): Return
8665         std::string.
8666         * build-id.h (find_separate_debug_file_by_buildid): Return
8667         std::string.
8668         * coffread.c (coff_symfile_read): Adjust to std::string.
8669         * elfread.c (elf_symfile_read): Adjust to std::string.
8670         * symfile.c (separate_debug_file_exists): Change parameter to
8671         std::string.
8672         (find_separate_debug_file): Return std::string.
8673         (find_separate_debug_file_by_debuglink): Return std::string.
8674         * symfile.h (find_separate_debug_file_by_debuglink): Return
8675         std::string.
8676
8677 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8678
8679         * common/xml-utils.c (xml_escape_text): Move code to...
8680         (xml_escape_text_append): ... this new function.
8681         * common/xml-utils.h (xml_escape_text_append): New declaration.
8682         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
8683         New function.
8684         (_initialize_xml_utils): register test_xml_escape_text_append as
8685         a selftest.
8686
8687 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
8688
8689         * defs.h: Remove MAX_REGISTER_SIZE.
8690         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
8691         asserts.
8692         * python/py-unwind.c (pyuw_sniffer): Likewise.
8693
8694 2018-03-07  Tom Tromey  <tom@tromey.com>
8695
8696         * linux-tdep.c (linux_info_proc): Update.
8697         * target.h (struct target_ops) <to_fileio_readlink>: Return
8698         optional<string>.
8699         (target_fileio_readlink): Return optional<string>.
8700         * remote.c (remote_hostio_readlink): Return optional<string>.
8701         * inf-child.c (inf_child_fileio_readlink): Return
8702         optional<string>.
8703         * target.c (target_fileio_readlink): Return optional<string>.
8704
8705 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8706
8707         * regcache.c (cooked_read_test): Add riscv to the list of
8708         architectures that have a save_reggroup.
8709
8710 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
8711
8712         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
8713         value is not a dynamic class object.
8714
8715 2018-03-06  Tom Tromey  <tom@tromey.com>
8716
8717         * rust-exp.y: Formatting fixes.
8718
8719 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8720
8721         * riscv-tdep.c (riscv_register_name): Remove target description
8722         support.
8723         (riscv_gdbarch_init): Remove target description check.
8724
8725 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8726
8727         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
8728         comment.
8729         * riscv-tdep.h: Likewise.
8730
8731 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8732
8733         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
8734         (riscv_pseudo_register_write): Delete.
8735         (riscv_gdbarch_init): Remove all use of pseudo registers.
8736
8737 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8738
8739         * record-btrace.c (btrace_print_lines): Replace cleanup
8740         parameter with RAII equivalents.
8741         (btrace_insn_history): Replace cleanup with RAII equivalents.
8742         * ui-out.h (make_cleanup_ui_out_list_begin_end,
8743         make_cleanup_ui_out_tuple_begin_end): Remove.
8744         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
8745         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
8746         make_cleanup_ui_out_list_begin_end): Remove.
8747
8748 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8749
8750         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
8751         parameter types to std::vector.  Use bool.
8752         (record_btrace_wait): Replace VEC(tp_t) with
8753         std::vector<thread_info *>.
8754         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
8755
8756 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8757
8758         * record-btrace.c (record_btrace_disable_callback): Remove.
8759         (struct scoped_btrace_disable): New.
8760         (record_btrace_open): Use scoped_btrace_disable.
8761
8762 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
8765         reading values from registers.
8766
8767 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8768
8769         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
8770         where appropriate.
8771
8772 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8773
8774         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
8775         change parameter type.  Use GDB's print functions, and use
8776         core_addr_to_string where appropriate.
8777         (riscv_push_dummy_call): Use core_addr_to_string where
8778         appropriate, update call to riscv_print_arg_location, and reindent
8779         a few lines.
8780         (riscv_return_value): Update call to riscv_print_arg_location.
8781
8782 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8783             Tim Newsome <tim@sifive.com>
8784             Albert Ou <a0u@eecs.berkeley.edu>
8785             Darius Rad <darius@bluespec.com>
8786
8787         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
8788         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
8789         (ALLDEPFILES): Add riscv-tdep.c
8790         * configure.tgt: Add riscv support.
8791         * riscv-tdep.c: New file.
8792         * riscv-tdep.h: New file.
8793         * NEWS: Mention new target.
8794         * MAINTAINERS: Add entry for riscv.
8795
8796 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8797
8798         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
8799         fields within aggregates.
8800
8801 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
8802
8803         * record-btrace.c (btrace_print_lines): Change type of flags to
8804         gdb_disassembly_flags.
8805
8806 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
8807
8808         * fbsd-nat.c: Include "inf-ptrace.h".
8809         (USE_SIGTRAP_SIGINFO): Conditionally define.
8810         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
8811         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
8812         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
8813         function.
8814         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
8815         Likewise.
8816         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
8817         Likewise.
8818         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
8819         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
8820         "supports_stopped_by_hw_breakpoint" target methods.
8821
8822 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
8823
8824         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
8825         * fbsd-nat.c (debug_fbsd_nat): New variable.
8826         (show_fbsd_nat_debug): New function.
8827         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
8828         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
8829
8830 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
8831
8832         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
8833         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
8834         prototype.
8835         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
8836         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
8837         method.
8838
8839 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8840
8841         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
8842         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
8843
8844 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8845
8846         * charset.c (struct charset_vector): New.
8847         (charsets): Change type to charset_vector.
8848         (find_charset_names): Adjust.
8849         (add_one): Adjust.
8850         (_initialize_charset): Adjust.
8851
8852 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8853
8854         * progspace.h (struct program_space) <deleted_solibs>: Change
8855         type to std::vector<std::string>.
8856         * progspace.c (clear_program_space_solib_cache): Adjust.
8857         * breakpoint.c (print_solib_event): Adjust.
8858         (check_status_catch_solib): Adjust.
8859         * solib.c (update_solib_list): Adjust.
8860         * ui-out.h (class ui_out) <field_string>: New overload.
8861         * ui-out.c (ui_out::field_string): New overload.
8862
8863 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8864
8865         * progspace.h (struct program_space): Add constructor and
8866         destructor, initialize fields.
8867         (add_program_space): Remove.
8868         * progspace.c (add_program_space): Rename to...
8869         (program_space::program_space): ... this.
8870         (release_program_space): Rename to...
8871         (program_space::~program_space): ... this.
8872         (delete_program_space): Use delete to delete program_space.
8873         (initialize_progspace): Use new to allocate program_space.
8874         * inferior.c (add_inferior_with_spaces): Likewise.
8875         (clone_inferior_command): Likewise.
8876         * infrun.c (follow_fork_inferior): Likewise.
8877         (handle_vfork_child_exec_or_exit): Likewise.
8878
8879 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8880
8881         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
8882         (delim_string_to_char_ptr_vec): Return std::vector of
8883         gdb::unique_xmalloc_ptr.
8884         (dirnames_to_char_ptr_vec_append): Take std::vector of
8885         gdb::unique_xmalloc_ptr.
8886         (dirnames_to_char_ptr_vec): Return std::vector of
8887         gdb::unique_xmalloc_ptr.
8888         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
8889         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
8890         (delim_string_to_char_ptr_vec): Return an std::vector of
8891         gdb::unique_xmalloc_ptr, adjust the code.
8892         (dirnames_to_char_ptr_vec_append): Take an std::vector of
8893         gdb::unique_xmalloc_ptr, adjust the code.
8894         (dirnames_to_char_ptr_vec): Return an std::vector of
8895         gdb::unique_xmalloc_ptr, adjust the code.
8896         * auto-load.c (auto_load_safe_path_vec): Change type to
8897         std::vector of gdb::unique_xmalloc_ptr.
8898         (auto_load_expand_dir_vars): Return an std::vector of
8899         gdb::unique_xmalloc_ptr, adjust the code.
8900         (auto_load_safe_path_vec_update): Adjust.
8901         (filename_is_in_auto_load_safe_path_vec): Adjust.
8902         (auto_load_objfile_script_1): Adjust.
8903         * build-id.c (build_id_to_debug_bfd): Adjust.
8904         * linux-thread-db.c (thread_db_load_search): Adjust.
8905         * source.c (add_path): Adjust.
8906         (openp): Adjust.
8907         * symfile.c (find_separate_debug_file): Adjust.
8908         * utils.c (do_free_char_ptr_vec): Remove.
8909         (make_cleanup_free_char_ptr_vec): Remove.
8910
8911 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8912
8913         PR gdb/22907
8914         * common/pathstuff.c: Conditionally include "<windows.h>".
8915
8916 2018-03-01  Georg Sauthoff  <mail@georg.so>
8917
8918         PR gdb/22888
8919         * gcore.in: Quote variables and switch interpreter to bash.
8920
8921 2018-03-01  Tom Tromey  <tom@tromey.com>
8922
8923         * dwarf2read.c (alloc_discriminant_info): Fix default_index
8924         assertion.  Add assertion for discriminant_index.
8925         (quirk_rust_enum): Use correct base type name in univariant case.
8926
8927 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
8928
8929         * record.c (get_call_history_modifiers): Return a
8930         record_print_flags.
8931         (cmd_record_call_history): Adjust.
8932         * record-btrace.c (record_btrace_call_history): Adjust.
8933         (record_btrace_call_history_range): Adjust.
8934         (record_btrace_call_history_from): Adjust.
8935         * target-debug.h (target_debug_print_record_print_flags): New.
8936         * target-delegates.c: Re-generate.
8937         * target.c (target_call_history): Change flags type.
8938         (target_call_history_from): Likewise.
8939         (target_call_history_range): Likewise.
8940         * target.h (struct target_ops) <target_call_history>: Likewise.
8941         (target_call_history_from): Likewise.
8942         (target_call_history_range): Likewise.
8943
8944 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8945             Simon Marchi  <simon.marchi@polymtl.ca>
8946
8947         * common/common-utils.c: Include "sys/stat.h".
8948         (is_regular_file): Move here from "source.c"; change return
8949         type to "bool".
8950         * common/common-utils.h (is_regular_file): New prototype.
8951         * common/pathstuff.c (contains_dir_separator): New function.
8952         * common/pathstuff.h (contains_dir_separator): New prototype.
8953         * source.c: Don't include "sys/stat.h".
8954         (is_regular_file): Move to "common/common-utils.c".
8955
8956 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8957
8958         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
8959         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
8960         * auto-load.c: Include "common/pathstuff.h".
8961         * common/common-def.h (current_directory): Move here.
8962         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
8963         function.
8964         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
8965         prototype.
8966         * common/pathstuff.c: New file.
8967         * common/pathstuff.h: New file.
8968         * compile/compile.c: Include "common/pathstuff.h".
8969         * defs.h (current_directory): Move to "common/common-defs.h".
8970         * dwarf2read.c: Include "common/pathstuff.h".
8971         * exec.c: Likewise.
8972         * guile/scm-safe-call.c: Likewise.
8973         * linux-thread-db.c: Likewise.
8974         * main.c: Likewise.
8975         * nto-tdep.c: Likewise.
8976         * objfiles.c: Likewise.
8977         * source.c: Likewise.
8978         * symtab.c: Likewise.
8979         * utils.c: Include "common/pathstuff.h".
8980         (gdb_realpath): Move to "common/pathstuff.c".
8981         (gdb_realpath_keepfile): Likewise.
8982         (gdb_abspath): Likewise.
8983         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
8984         (gdb_realpath_keepfile): Likewise.
8985         (gdb_abspath): Likewise.
8986
8987 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
8988
8989         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
8990         wildcard process pid for super_resume for kernels with a
8991         specific bug.
8992
8993 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
8994
8995         * compile/compile.c (get_args): Add additional comments
8996         explaining function.
8997
8998 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
8999             Tom Tromey  <tom@tromey.com>
9000
9001         * target.h (memory_write_request_s): Remove typedef.  Don't define
9002         VEC.
9003         (target_write_memory_blocks): Change argument to std::vector.
9004         (struct memory_write_request): Add constructor.
9005         * target-memory.c (compare_block_starting_address): Return bool.
9006         Change argument types.
9007         (claim_memory): Change arguments to use std::vector.
9008         (split_regular_and_flash_blocks, blocks_to_erase)
9009         (compute_garbled_blocks): Likewise.
9010         (cleanup_request_data, cleanup_write_requests_vector): Remove.
9011         (target_write_memory_blocks): Change argument to std::vector.
9012         * symfile.c (struct load_section_data): Add constructor and
9013         destructor.  Use std::vector for "requests".
9014         (struct load_progress_data): Add initializers.
9015         (load_section_callback): Update.  Use "new".
9016         (clear_memory_write_data): Remove.
9017         (generic_load): Update.
9018
9019 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
9020
9021         * arch/aarch64.h: Use common/tdesc.h.
9022
9023 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
9024
9025         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
9026         architecture with a 64-bit ABI.
9027
9028 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
9029
9030         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
9031         ahead of target description loading.
9032
9033 2018-02-26  Tom Tromey  <tom@tromey.com>
9034
9035         * stack.c (backtrace_command_1): Update.
9036         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
9037         of "flags".
9038         * python/py-framefilter.c (py_print_frame)
9039         (gdbpy_apply_frame_filter): Change type of "flags".
9040         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
9041         of "flags".
9042         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
9043         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
9044         * extension.h (enum frame_filter_flag): Rename from
9045         frame_filter_flags.
9046         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
9047         (apply_ext_lang_frame_filter): Change type of "flags".
9048         * extension.c (apply_ext_lang_frame_filter): Change type of
9049         "flags".
9050         * extension-priv.h (struct extension_language_ops)
9051         <apply_frame_filter>: Change type of "flags".
9052
9053 2018-02-26  Tom Tromey  <tom@tromey.com>
9054
9055         PR python/16497:
9056         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
9057         off-by-one in py_end computation.
9058         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
9059         PRINT_MORE_FRAMES.
9060         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
9061         constant.
9062
9063 2018-02-26  Tom Tromey  <tom@tromey.com>
9064
9065         * dwarf2read.c (struct variant_field): New.
9066         (struct nextfield) <variant>: New field.
9067         (dwarf2_add_field): Handle DW_TAG_variant_part.
9068         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
9069         discriminated union.
9070         (read_structure_type): Handle DW_TAG_variant_part.
9071         (handle_struct_member_die): New function, extracted from
9072         process_structure_scope.  Handle DW_TAG_variant.
9073         (process_structure_scope): Handle discriminated unions.  Call
9074         handle_struct_member_die.
9075
9076 2018-02-26  Tom Tromey  <tom@tromey.com>
9077
9078         * rust-lang.h (rust_last_path_segment): Declare.
9079         * rust-lang.c (rust_last_path_segment): Now public.  Change
9080         contract.
9081         (struct disr_info): Remove.
9082         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
9083         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
9084         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
9085         (rust_enum_p, rust_enum_variant): New function.
9086         (rust_underscore_fields): Remove "offset" parameter.
9087         (rust_print_enum): New function.
9088         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
9089         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
9090         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
9091         enums.
9092         (rust_internal_print_type): New function, from rust_print_type.
9093         Remove enum code.
9094         (rust_print_type): Call rust_internal_print_type.
9095         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
9096         Update enum handling.
9097         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
9098         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
9099         (rust_union_quirks): New functions.
9100         (process_full_comp_unit, process_full_type_unit): Call
9101         rust_union_quirks.
9102         (process_structure_scope): Update rust_unions if necessary.
9103
9104 2018-02-26  Tom Tromey  <tom@tromey.com>
9105
9106         * value.h (value_union_variant): Declare.
9107         * valops.c (value_union_variant): New function.
9108         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
9109         (struct discriminant_info): New.
9110         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
9111         enumerator.
9112         (struct main_type) <flag_discriminated_union>: New field.
9113
9114 2018-02-26  Tom Tromey  <tom@tromey.com>
9115
9116         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9117         unittests/unpack-selftests.c.
9118         * unittests/unpack-selftests.c: New file.
9119         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
9120
9121 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9122
9123         * dwarf2read.c (struct partial_die_info) <read>: New method.
9124         (read_partial_die): Remove the declaration.
9125         (load_partial_dies): Update.
9126         (partial_die_info::partial_die_info):
9127         (read_partial_die): Change it to partial_die_info::read.
9128
9129 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9130
9131         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
9132         (fixup_partial_die): Remove declaration.
9133         (scan_partial_symbols): Update.
9134         (partial_die_parent_scope): Likewise.
9135         (partial_die_full_name): Likewise.
9136         (fixup_partial_die): Change it to partial_die_info::fixup.
9137
9138 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9139
9140         * dwarf2read.c (read_partial_die): Update the declaration.
9141         (load_partial_dies): Caller update.
9142         (read_partial_die): Remove one argument abbrev_len.
9143
9144 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9145
9146         * dwarf2read.c (struct partial_die_info): Add ctor, delete
9147         assignment operator.
9148         (load_partial_dies): Use ctor and copy ctor.
9149         (read_partial_die): Update.
9150         (dwarf2_cu::find_partial_die): Use ctor.
9151
9152 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9153
9154         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
9155         (find_partial_die_in_comp_unit): Change it to
9156         dwarf2_cu::find_partial_die.
9157         (find_partial_die): Update.
9158
9159 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9160
9161         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
9162         is NULL.
9163
9164 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9165
9166         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
9167
9168 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
9169
9170         * arch/amd64.h: Use common/tdesc.h.
9171         * arch/i386.c: Likewise.
9172         * arch/i386.h: Likewise.
9173         * arch/tic6x.c: Likewise.
9174         * arch/tdesc.h: Move file from here...
9175         * common/tdesc.h: ...to here.
9176         * features/aarch64-core.c: Regenerate.
9177         * features/aarch64-fpu.c: Regenerate.
9178         * features/i386/32bit-avx.c: Regenerate.
9179         * features/i386/32bit-avx512.c: Regenerate.
9180         * features/i386/32bit-core.c: Regenerate.
9181         * features/i386/32bit-linux.c: Regenerate.
9182         * features/i386/32bit-mpx.c: Regenerate.
9183         * features/i386/32bit-pkeys.c: Regenerate.
9184         * features/i386/32bit-sse.c: Regenerate.
9185         * features/i386/64bit-avx.c: Regenerate.
9186         * features/i386/64bit-avx512.c: Regenerate.
9187         * features/i386/64bit-core.c: Regenerate.
9188         * features/i386/64bit-linux.c: Regenerate.
9189         * features/i386/64bit-mpx.c: Regenerate.
9190         * features/i386/64bit-pkeys.c: Regenerate.
9191         * features/i386/64bit-segments.c: Regenerate.
9192         * features/i386/64bit-sse.c: Regenerate.
9193         * features/i386/x32-core.c: Regenerate.
9194         * features/tic6x-c6xp.c: Regenerate.
9195         * features/tic6x-core.c: Regenerate.
9196         * features/tic6x-gp.c: Regenerate.
9197         * target-descriptions.c: Use common/tdesc.h.
9198         * target-descriptions.h: Likewise.
9199
9200 2018-02-24  Tom Tromey  <tom@tromey.com>
9201
9202         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
9203         (try_thread_db_load_from_dir, thread_db_load_search): Use
9204         std::string.
9205         (info_auto_load_libthread_db_compare): Return bool.  Change
9206         argument types.
9207         (info_auto_load_libthread_db): Use std::vector, std::string.
9208         Remove cleanups.
9209
9210 2018-02-24  Tom Tromey  <tom@tromey.com>
9211
9212         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
9213         std::string.
9214         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
9215         std::string*.
9216         * gdbarch.c: Rebuild.
9217         * gdbarch.h: Rebuild.
9218         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
9219         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
9220         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
9221         std::string*.
9222
9223 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
9224
9225         * gdbtypes.h (sect_offset): Change type to uint64_t.
9226         (sect_offset_str): New function.
9227         * dwarf2read.c (create_addrmap_from_aranges): Use
9228         sect_offset_str.
9229         (error_check_comp_unit_head): Likewise.
9230         (create_debug_type_hash_table): Likewise.
9231         (read_cutu_die_from_dwo): Likewise.
9232         (init_cutu_and_read_dies): Likewise.
9233         (init_cutu_and_read_dies_no_follow): Likewise.
9234         (process_psymtab_comp_unit_reader): Likewise.
9235         (partial_die_parent_scope): Likewise.
9236         (peek_die_abbrev): Likewise.
9237         (process_queue): Likewise.
9238         (dwarf2_physname): Likewise.
9239         (read_namespace_alias): Likewise.
9240         (read_import_statement): Likewise.
9241         (create_dwo_cu_reader): Likewise.
9242         (create_cus_hash_table): Likewise.
9243         (lookup_dwo_cutu): Likewise.
9244         (inherit_abstract_dies): Likewise.
9245         (read_func_scope): Likewise.
9246         (read_call_site_scope): Likewise.
9247         (dwarf2_add_member_fn): Likewise.
9248         (read_common_block): Likewise.
9249         (read_module_type): Likewise.
9250         (read_typedef): Likewise.
9251         (read_subrange_type): Likewise.
9252         (load_partial_dies): Likewise.
9253         (read_partial_die): Likewise.
9254         (find_partial_die): Likewise.
9255         (read_str_index): Likewise.
9256         (dwarf2_string_attr): Likewise.
9257         (build_error_marker_type): Likewise.
9258         (lookup_die_type): Likewise.
9259         (dump_die_shallow): Likewise.
9260         (follow_die_ref): Likewise.
9261         (dwarf2_fetch_die_loc_sect_off): Likewise.
9262         (dwarf2_fetch_constant_bytes): Likewise.
9263         (follow_die_sig): Likewise.
9264         (get_signatured_type): Likewise.
9265         (get_DW_AT_signature_type): Likewise.
9266         (dwarf2_find_containing_comp_unit): Likewise.
9267         (set_die_type): Likewise.
9268
9269 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
9270
9271         * arch/aarch64.c: Include "common-defs.h".
9272         * arch/amd64.c: Likewise.
9273         * arch/i386.c: Likewise.
9274
9275 2018-02-21  Tom Tromey  <tom@tromey.com>
9276
9277         * value.h: (extract_field_op): Update.
9278         * eval.c (extract_field_op): Return a const char *.
9279         * expression.h (parse_expression_for_completion): Update.
9280         * completer.c (complete_expression): Update.
9281         (add_struct_fields): Make fieldname const.
9282         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
9283         (mark_completion_tag, parse_exp_in_context_1): Update.
9284         (parse_expression_for_completion): Change "name" to
9285         unique_xmalloc_ptr*.
9286
9287 2018-02-21  Tom Tromey  <tom@tromey.com>
9288
9289         * infcall.c (call_function_by_hand_dummy): Use std::vector.
9290
9291 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9292
9293         * avr-tdep.c (avr_read_pc): Change parameter type to
9294         readable_regcache.
9295         * gdbarch.sh (read_pc): Likewise.
9296         * gdbarch.c: Re-generated.
9297         * gdbarch.h: Re-generated.
9298         * hppa-tdep.c (hppa_read_pc): Change parameter type to
9299         readable_regcache.
9300         * ia64-tdep.c (ia64_read_pc): Likewise.
9301         * mips-tdep.c (mips_read_pc): Likewise.
9302         * spu-tdep.c (spu_read_pc): Likewise.
9303
9304 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9305
9306         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
9307         * regcache-dump.c: New file.
9308         * regcache.c: Move register_dump to regcache-dump.c.
9309         (maintenance_print_registers): Likewise.
9310         (maintenance_print_raw_registers): Likewise.
9311         (maintenance_print_cooked_registers): Likewise.
9312         (maintenance_print_register_groups): Likewise.
9313         (maintenance_print_remote_registers): Likewise.
9314         (_initialize_regcache): Likewise.
9315         * regcache.h (register_dump): Moved from regcache.c.
9316
9317 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9318
9319         * regcache.c (regcache::regcache): Update.
9320         (regcache::invalidate): Move it to detached_regcache::invalidate.
9321         (get_thread_arch_aspace_regcache): Update.
9322         (regcache::raw_update): Update.
9323         (regcache::cooked_read): Remove some code.
9324         (regcache::cooked_read_value): Likewise.
9325         (regcache::raw_write): Remove assert on m_readonly_p.
9326         (regcache::raw_supply_integer): Move it to
9327         detached_regcache::raw_supply_integer.
9328         (regcache::raw_supply_zeroed): Likewise.
9329         * regcache.h (detached_regcache) <raw_supply_integer>: New
9330         declaration.
9331         <raw_supply_zeroed, invalidate>: Likewise.
9332         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
9333         <invalidate>: Likewise.
9334         <m_readonly_p>: Removed.
9335
9336 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9337
9338         * infcmd.c (get_return_value): Let stop_regs point to
9339         get_current_regcache.
9340         * regcache.c (regcache::regcache): Remove.
9341         (register_dump_reg_buffer): New class.
9342         (regcache_print): Adjust.
9343         * regcache.h (regcache): Remove constructors.
9344
9345 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9346
9347         * regcache.c (class register_dump): New class.
9348         (register_dump_regcache, register_dump_none): New class.
9349         (register_dump_remote, register_dump_groups): New class.
9350         (regcache_print): Update.
9351         * regcache.h (regcache_dump_what): Move it to regcache.c.
9352         (regcache) <dump>: Remove.
9353
9354 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9355
9356         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
9357          reg_buffer_rw *.
9358         (jit_unwind_reg_set_impl): Call raw_supply.
9359         (jit_frame_sniffer): Use reg_buffer_rw.
9360         * record-full.c (record_full_core_regbuf): Change its type.
9361         (record_full_core_open_1): Use reg_buffer_rw.
9362         (record_full_close): Likewise.
9363         (record_full_core_fetch_registers): Use regcache->raw_supply.
9364         (record_full_core_store_registers): Likewise.
9365         * regcache.c (regcache::get_register_status): Move it to
9366         reg_buffer.
9367         (regcache_raw_set_cached_value): Remove.
9368         (regcache::raw_set_cached_value): Remove.
9369         (regcache::raw_write): Call raw_supply.
9370         (regcache::raw_supply): Move it to reg_buffer_rw.
9371         * regcache.h (regcache_raw_set_cached_value): Remove.
9372         (reg_buffer_rw): New class.
9373
9374 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9375
9376         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
9377         readonly_detached_regcache.
9378         (dummy_frame_prev_register): Use regcache->cooked_read.
9379         * frame.c (frame_save_as_regcache): Change return type.
9380         (frame_pop): Update.
9381         * frame.h (frame_save_as_regcache): Update declaration.
9382         * inferior.h (get_infcall_suspend_state_regcache): Update
9383         declaration.
9384         * infrun.c (infcall_suspend_state) <registers>: use
9385         readonly_detached_regcache.
9386         (save_infcall_suspend_state): Don't use regcache_dup.
9387         (get_infcall_suspend_state_regcache): Change return type.
9388         * linux-fork.c (struct fork_info) <savedregs>: Change to
9389         readonly_detached_regcache.
9390         <pc>: New field.
9391         (fork_save_infrun_state): Don't use regcache_dup.
9392         (info_checkpoints_command): Adjust.
9393         * mi/mi-main.c (register_changed_p): Update declaration.
9394         (mi_cmd_data_list_changed_registers): Use
9395         readonly_detached_regcache.
9396         (register_changed_p): Change parameter type to
9397         readonly_detached_regcache.
9398         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
9399         readonly_detached_regcache.
9400         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
9401         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
9402         New.
9403         (regcache::save): Move it to reg_buffer.
9404         (regcache::restore): Change parameter type.
9405         (regcache_dup): Remove.
9406         * regcache.h (reg_buffer) <save>: New method.
9407         (readonly_detached_regcache): New class.
9408         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
9409         readonly_detached_regcache.
9410         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
9411
9412 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9413
9414         * frame.c (frame_save_as_regcache): Use regcache method save.
9415         (frame_pop): Use regcache method restore.
9416         * infrun.c (restore_infcall_suspend_state): Likewise.
9417         * linux-fork.c (fork_load_infrun_state): Likewise.
9418         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
9419         save.
9420         * regcache.c (regcache_save): Remove.
9421         (regcache::restore): More asserts.
9422         (regcache_cpy): Remove.
9423         * regcache.h (regcache_save): Remove the declaration.
9424         (regcache::restore): Move from private to public.
9425         Remove the friend declaration of regcache_cpy.
9426         (regcache_cpy): Remove declaration.
9427
9428 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9429
9430         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
9431         parameter type to 'readable_regcache *'.
9432         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
9433         * arm-tdep.c (arm_neon_quad_read): Likewise.
9434         (arm_pseudo_read): Likewise.
9435         * avr-tdep.c (avr_pseudo_register_read): Likewise.
9436         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
9437         * frv-tdep.c (frv_pseudo_register_read): Likewise.
9438         * gdbarch.c: Re-generated.
9439         * gdbarch.h: Re-generated.
9440         * gdbarch.sh (pseudo_register_read): Change parameter type to
9441         'readable_regcache *'.
9442         (pseudo_register_read_value): Likewise.
9443         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
9444         (h8300_pseudo_register_read): Likewise.
9445         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
9446         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
9447         (i386_pseudo_register_read_into_value): Likewise.
9448         (i386_pseudo_register_read_value): Likewise.
9449         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
9450         declaration.
9451         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
9452         * m32c-tdep.c (m32c_raw_read): Likewise.
9453         (m32c_read_flg): Likewise.
9454         (m32c_banked_register): Likewise.
9455         (m32c_banked_read): Likewise.
9456         (m32c_sb_read): Likewise.
9457         (m32c_part_read): Likewise.
9458         (m32c_cat_read): Likewise.
9459         (m32c_r3r2r1r0_read): Likewise.
9460         (m32c_pseudo_register_read): Likewise.
9461         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
9462         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
9463         (mep_pseudo_cr64_read): Likewise.
9464         (mep_pseudo_register_read): Likewise.
9465         * mips-tdep.c (mips_pseudo_register_read): Likewise.
9466         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
9467         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
9468         * regcache.c (regcache::raw_read): Move it to readable_regcache.
9469         (regcache::cooked_read): Likewise.
9470         (regcache::cooked_read_value): Likewise.
9471         (regcache_cooked_read_signed):
9472         (regcache::cooked_read): Likewise.
9473         * regcache.h (readable_regcache): New class.
9474         (regcache): Inherit readable_regcache.  Move some methods to
9475         readable_regcache.
9476         * rl78-tdep.c (rl78_pseudo_register_read): Change
9477         parameter type to 'readable_regcache *'.
9478         * rs6000-tdep.c (do_regcache_raw_read): Remove.
9479         (e500_pseudo_register_read): Change parameter type to
9480         'readable_regcache *'.
9481         (dfp_pseudo_register_read): Likewise.
9482         (vsx_pseudo_register_read): Likewise.
9483         (efpr_pseudo_register_read): Likewise.
9484         * s390-tdep.c (s390_pseudo_register_read): Likewise.
9485         * sh-tdep.c (sh_pseudo_register_read): Likewise.
9486         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
9487         (sh64_pseudo_register_read): Likewise.
9488         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
9489         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
9490         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
9491         (spu_pseudo_register_read): Likewise.
9492         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
9493         (xtensa_pseudo_register_read): Likewise.
9494
9495 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9496
9497         * regcache.c (regcache::regcache): Call reg_buffer ctor.
9498         (regcache::arch): Move it to reg_buffer::arch.
9499         (regcache::register_buffer): Likewise.
9500         (regcache::assert_regnum): Likewise.
9501         (regcache::num_raw_registers): Likewise.
9502         * regcache.h (reg_buffer): New class.
9503         (regcache): Inherit reg_buffer.
9504
9505 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
9506
9507         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
9508         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
9509
9510 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
9511
9512         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
9513
9514 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
9515
9516         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
9517         (SFILES): Remove common/*.c files.
9518         (COMMON_OBS): Remove some *.o files built from common/*.c files.
9519         * common/common.host: Add common reference.
9520         * configure.ac: Likewise.
9521         * configure: Regenerate.
9522
9523 2018-02-16  Yao Qi  <yao.qi@linaro.org>
9524
9525         * block.c (block_namespace_info): Inherit allocate_on_obstack.
9526         (block_initialize_namespace): Use new.
9527         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
9528         (dwarf2_free_objfile): Use delete.
9529         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
9530         (copy_type_recursive): Use new.
9531         * gdb_obstack.h (allocate_on_obstack): New.
9532
9533 2018-02-15  Yao Qi  <yao.qi@linaro.org>
9534
9535         PR gdb/22849
9536         * inferior.c (exit_inferior_1): Reset inf->control.
9537
9538 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
9539
9540         * ada-lang.c (ada_to_fixed_value_create): Delete advance
9541         declaration.
9542
9543 2018-02-14  Pedro Alves  <palves@redhat.com>
9544
9545         * frame-unwind.c (frame_unwind_try_unwinder): Always call
9546         frame_cleanup_after_sniffer on exception.
9547
9548 2018-02-14  Tom Tromey  <tom@tromey.com>
9549
9550         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
9551         const.
9552         (solib_bfd_open): Make pathname const.
9553         * solib.c (solib_bfd_open): Make pathname const.
9554         * solib-spu.c (spu_bfd_fopen): Make name const.
9555         (spu_bfd_open): Make pathname const.
9556         * solib-darwin.c (darwin_bfd_open): Make pathname const.
9557         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
9558
9559 2018-02-14  Tom Tromey  <tom@tromey.com>
9560
9561         * symfile.c (symfile_bfd_open): Update.
9562         * source.h (openp, source_full_path_of, find_and_open_source):
9563         Change argument type to unique_xmalloc_ptr.
9564         * source.c (openp): Take a unique_xmalloc_ptr.
9565         (source_full_path_of, find_and_open_source): Likewise.
9566         (open_source_file, symtab_to_fullname): Update.
9567         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
9568         unique_xmalloc_ptr.
9569         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
9570         (exec_file_find): Update.
9571         * psymtab.c (psymtab_to_fullname): Update.
9572         * nto-tdep.h (nto_find_and_open_solib): Update.
9573         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
9574         unique_xmalloc_ptr.
9575         * exec.c (exec_file_attach): Update.
9576         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
9577         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
9578
9579 2018-02-14  Tom Tromey  <tom@tromey.com>
9580
9581         * solib.c: Include source.h.
9582         * nto-tdep.c: Include source.h.
9583         * mi/mi-cmd-env.c: Include source.h.
9584         * infcmd.c: Include source.h.
9585         * exec.c: Include source.h.
9586         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
9587         (add_path, directory_switch, source_path, init_source_path): Move
9588         declarations...
9589         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
9590         (add_path, directory_switch, source_path, init_source_path):
9591         ...here.
9592
9593 2018-02-14  Tom Tromey  <tom@tromey.com>
9594
9595         * solist.h (exec_file_find, solib_find): Return
9596         unique_xmalloc_ptr.
9597         (solib_bfd_fopen): Take a const char *.
9598         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
9599         (exec_file_find, solib_find): Likewise.
9600         (solib_bfd_fopen): Do not take ownership of "pathname".
9601         (solib_bfd_open): Use unique_xmalloc_ptr.
9602         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
9603         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
9604         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
9605         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
9606
9607 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
9608
9609         * ada-lang.c (name_match_type_from_name): Remove reference to
9610         ada_name_for_lookup in function's documentation.
9611         * ada-lang.h (ada_name_for_lookup): Delete declaration.
9612
9613 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
9614
9615         * defs.h (enum openp_flags): New enum.
9616         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
9617         Move to enum openp_flags.
9618         (openp_flags): New enum flags.
9619         (openp): Change parameter type to openp_flags.
9620         * source.c (openp): Change parameter type to openp_flags.
9621         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
9622         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
9623
9624 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
9625
9626         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
9627         per-command.
9628
9629 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
9632         into...
9633         (class dwarf2_queue_guard): ...the destructor of this new class.
9634         (dw2_do_instantiate_symtab): Create instance of the new class
9635         dwarf2_queue_guard, remove cleanup.
9636
9637 2018-02-09  Tom Tromey  <tom@tromey.com>
9638
9639         * source.c (find_source_lines): Don't reference past the end of
9640         the vector.
9641
9642 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9643
9644         * remote.c (remote_btrace_maybe_reopen): Change error message.
9645         * btrace.c (btrace_enable): Likewise.
9646         (parse_xml_btrace): Likewise.
9647         (parse_xml_btrace_conf): Likewise.
9648
9649 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9650
9651         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
9652         (linux_enable_pt, linux_enable_bts): Call
9653         diagnose_perf_event_open_fail.
9654
9655 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9656
9657         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
9658         Remove parameter and change return type.  Update callers.  Move it.
9659         (linux_enable_bts, linux_enable_pt): Improve error message.
9660         (linux_enable_pt): Remove zero buffer size check.
9661         (linux_enable_btrace): Improve error messages.  Remove NULL return
9662         check.
9663
9664 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9665
9666         * btrace.c (btrace_enable): Remove target_supports_btrace call.
9667         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
9668         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
9669         (linux_supports_pt, linux_supports_btrace): Remove.
9670         (linux_enable_bts): Call cpu_supports_bts.
9671         * nat/linux-btrace.h (linux_supports_btrace): Remove.
9672         * remote.c (remote_supports_btrace): Remove.
9673         (init_remote_ops): Remove remote_supports_btrace.
9674         * target-delegates.c: Regenerated.
9675         * target.c (target_supports_btrace): Remove.
9676         * target.h (target_ops) <to_supports_btrace>: Remove
9677         (target_supports_btrace): Remove.
9678         * x86-linux-nat.c (x86_linux_create_target): Remove
9679         linux_supports_btrace.
9680
9681 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9682
9683         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
9684         btrace failed.
9685         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
9686         exception and use message in own exception.
9687
9688 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9689
9690         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
9691         (perf_event_pt_event_type): Use gdb_file_up.
9692         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
9693         scoped_fd, and scoped_mmap.
9694
9695 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9696
9697         * common/scoped_mmap.h: New.
9698         * unittests/scoped_mmap-selftest.c: New.
9699         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9700         unittests/scoped_mmap-selftest.c.
9701
9702 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9703
9704         * common/scoped_fd.h: New.
9705         * unittests/scoped_fd-selftest.c: New.
9706         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9707         unittests/scoped_fd-selftest.c.
9708
9709 2018-02-09  Tom Tromey  <tom@tromey.com>
9710
9711         * auto-load.c (auto_load_section_scripts): Use
9712         gdb::unique_xmalloc_ptr.
9713
9714 2018-02-09  Tom Tromey  <tom@tromey.com>
9715
9716         * auto-load.c (execute_script_contents): Use std::string.
9717
9718 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
9719
9720         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
9721         Python function, rather than a new command.
9722
9723 2018-02-08  Tom Tromey  <tom@tromey.com>
9724
9725         * solib.c (solib_find_1): Use std::string.
9726         (solib_bfd_fopen): Use unique_xmalloc_ptr.
9727
9728 2018-02-08  Tom Tromey  <tom@tromey.com>
9729
9730         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
9731
9732 2018-02-08  Tom Tromey  <tom@tromey.com>
9733
9734         * source.c (find_source_lines): Use gdb::def_vector.
9735
9736 2018-02-08  Tom Tromey  <tom@tromey.com>
9737
9738         * macrocmd.c (struct temporary_macro_definition): New.
9739         (macro_define_command): Use temporary_macro_definition.  Remove
9740         cleanups.
9741         (free_macro_definition_ptr): Remove.
9742
9743 2018-02-08  Tom Tromey  <tom@tromey.com>
9744
9745         * macroexp.c (maybe_expand): Use std::string.
9746
9747 2018-02-08  Tom Tromey  <tom@tromey.com>
9748
9749         * macroexp.c (struct macro_buffer): Add initializers for some
9750         members.
9751         (init_buffer, init_shared_buffer, free_buffer)
9752         (free_buffer_return_text): Remove.
9753         (macro_buffer): New constructors.
9754         (~macro_buffer): New destructor.
9755         (macro_buffer::set_shared): New method.
9756         (macro_buffer::resize_buffer, macro_buffer::appendc)
9757         (macro_buffer::appendmem): Now methods, not free functions.
9758         (set_token, append_tokens_without_splicing, stringify)
9759         (macro_stringify): Update.
9760         (gather_arguments): Change return type.  Remove argc_p argument,
9761         add args_ptr argument.  Use std::vector.
9762         (substitute_args): Remove argc argument.  Accept std::vector.
9763         (expand): Update.  Use std::vector.
9764         (scan, macro_expand, macro_expand_next): Update.
9765
9766 2018-02-08  Tom Tromey  <tom@tromey.com>
9767
9768         * symtab.c (default_collect_symbol_completion_matches_break_on):
9769         Use unique_xmalloc_ptr.
9770         * macroscope.h: (sal_macro_scope, user_macro_scope)
9771         (default_macro_scope): Return unique_xmalloc_ptr.
9772         * macroscope.c (sal_macro_scope, user_macro_scope)
9773         (default_macro_scope): Return unique_xmalloc_ptr.
9774         * macroexp.h (macro_expand, macro_expand_once): Return
9775         unique_xmalloc_ptr.
9776         * macroexp.c (macro_expand, macro_expand_once): Return
9777         unique_xmalloc_ptr.
9778         * macrocmd.c (macro_expand_command, macro_expand_once_command)
9779         (info_macro_command, info_macros_command): Use
9780         unique_xmalloc_ptr.
9781         * compile/compile-c-support.c (write_macro_definitions): Use
9782         unique_xmalloc_ptr.
9783         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
9784
9785 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
9786
9787         * value.c (value_static_field): Assign field type instead of
9788         containing type when returning an optimized out value.
9789
9790 2018-02-06  Yao Qi  <yao.qi@linaro.org>
9791
9792         * ft32-tdep.c (ft32_read_pc): Remove.
9793         (ft32_write_pc): Remove.
9794         (ft32_gdbarch_init): Update.
9795         * m32r-tdep.c (m32r_read_pc): Remove.
9796         (m32r_gdbarch_init): Update.
9797         * mep-tdep.c (mep_read_pc): Remove.
9798         (mep_gdbarch_init): Update.
9799         * microblaze-tdep.c (microblaze_write_pc): Remove.
9800         (microblaze_gdbarch_init): Update.
9801         * mn10300-tdep.c (mn10300_read_pc): Remove.
9802         (mn10300_write_pc): Remove.
9803         (mn10300_gdbarch_init): Update.
9804         * moxie-tdep.c (moxie_read_pc): Remove.
9805         (moxie_write_pc): Remove.
9806         (moxie_gdbarch_init): Update.
9807
9808 2018-02-06  Yao Qi  <yao.qi@linaro.org>
9809
9810         * expprint.c (print_subexp_standard): Handle
9811         OP_F77_UNDETERMINED_ARGLIST.
9812         (dump_subexp_body_standard): Likewise.
9813
9814 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
9815
9816         * target-descriptions.c (tdesc_element_visitor) Add empty
9817         implementations.
9818         (tdesc_type): Move make_gdb_type from here.
9819         (tdesc_type_builtin): Likewise.
9820         (tdesc_type_vector): Likewise.
9821         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
9822         (make_gdb_type_struct): Move from tdesc_type_with_fields.
9823         (make_gdb_type_union): Likewise.
9824         (make_gdb_type_flags): Likewise.
9825         (make_gdb_type_enum): Likewise.
9826         (make_gdb_type): New function.
9827         (tdesc_register_type): Use static make_gdb_type.
9828
9829 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
9830
9831         * infcmd.c (default_print_one_register_info): Align natural-format
9832         column values consistently one under another.
9833         (pad_to_column): New function.
9834
9835 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
9836
9837         * dwarf2read.c (dwarf2_physname): Move commment.
9838
9839 2018-02-01  Leszek Swirski  <leszeks@google.com>
9840
9841         * varobj.c (varobj_formatted_print_options): Allow recursive
9842         pretty printing if pretty printing is enabled.
9843
9844 2018-02-01  Leszek Swirski  <leszeks@google.com>
9845
9846         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
9847         names after a structop as a filename.
9848
9849 2018-02-01  Yao Qi  <yao.qi@linaro.org>
9850
9851         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
9852         (arm_record_coproc_data_proc): Likewise.
9853
9854 2018-02-01  Yao Qi  <yao.qi@linaro.org>
9855
9856         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
9857
9858 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
9859
9860         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
9861         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
9862
9863 2018-01-31  Pedro Alves  <palves@redhat.com>
9864
9865         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
9866         * inflow.c (child_terminal_save_inferior): Wrap reference to
9867         tcgetpgrp in HAVE_TERMIOS_H.
9868         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
9869         _WIN32.
9870         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
9871         always iterate over all inferiors.
9872         (gdbsim_cntrl_c): Adjust.
9873         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
9874
9875 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
9876
9877         * gdbtypes.c (lookup_array_range_type): Make sure the array's
9878         index type is objfile-owned if the element type is as well.
9879
9880 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
9881
9882         GDB 8.1 released.
9883
9884 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
9885
9886         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
9887         "features/s390x-linux64.c".
9888         (_initialize_s390_linux_tdep): Remove initialization of tdescs
9889         s390_linux32 and s390x_linux64.
9890         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
9891         default tdesc.
9892         * s390-tdep.c: Include "features/s390-linux32.c" and
9893         "features/s390x-linux64.c".
9894         (s390_tdesc_valid): Add check for tdesc_has_registers.
9895         (s390_gdbarch_init): Make sure there is always a valid tdesc.
9896         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
9897         tdesc_s390x_linux64.
9898         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
9899         tdesc_s390x_linux64 to...
9900         * s390-tdep.h: ...here.
9901
9902 2018-01-30  Pedro Alves  <palves@redhat.com>
9903
9904         PR gdb/13211
9905         * config.in, configure: Regenerate.
9906         * configure.ac: Check for getpgid.
9907         * go32-nat.c (go32_pass_ctrlc): New.
9908         (go32_target): Install it.
9909         * inf-child.c (inf_child_target): Install
9910         child_terminal_save_inferior, child_pass_ctrlc and
9911         child_interrupt.
9912         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
9913         (inf_ptrace_target): No longer install it.
9914         * infcmd.c (interrupt_target_1): Adjust.
9915         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
9916         (child_interrupt): Declare.
9917         (inferior::terminal_state): New.
9918         * inflow.c (struct terminal_info): Update comments.
9919         (inferior_process_group): Delete.
9920         (terminal_is_ours): Delete.
9921         (gdb_tty_state): New.
9922         (child_terminal_init): Adjust.
9923         (is_gdb_terminal, sharing_input_terminal_1)
9924         (sharing_input_terminal): New functions.
9925         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
9926         Set the process's actual process group in the foreground if
9927         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
9928         mark terminal as the inferior's if not sharing GDB's terminal.
9929         Don't check attach_flag.
9930         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
9931         pass down a target_terminal_state.
9932         (child_terminal_save_inferior): New, factored out from ...
9933         (child_terminal_ours_1): ... this.  Handle
9934         target_terminal_state::is_ours_for_output.
9935         (child_interrupt, child_pass_ctrlc): New.
9936         (inflow_inferior_exit): Clear the inferior's terminal_state.
9937         (copy_terminal_info): Copy the inferior's terminal state.
9938         (_initialize_inflow): Remove reference to terminal_is_ours.
9939         * inflow.h (inferior_process_group): Delete.
9940         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
9941         * procfs.c (procfs_target): Don't install procfs_interrupt.
9942         (procfs_interrupt): Delete.
9943         * remote.c (remote_serial_quit_handler): Adjust.
9944         (remote_interrupt): Remove ptid parameter.  Adjust.
9945         * target-delegates.c: Regenerate.
9946         * target.c: Include "terminal.h".
9947         (target_terminal::terminal_state): Rename to ...
9948         (target_terminal::m_terminal_state): ... this.
9949         (target_terminal::init): Adjust.
9950         (target_terminal::inferior): Adjust to per-inferior
9951         terminal_state.
9952         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
9953         (target_terminal::ours, target_terminal::ours_for_output): Use
9954         target_terminal_is_ours_kind.
9955         (target_interrupt): Remove ptid parameter.  Adjust.
9956         (default_target_pass_ctrlc): Adjust.
9957         * target.h (target_ops::to_terminal_save_inferior): New field.
9958         (target_ops::to_interrupt): Remove ptid_t parameter.
9959         (target_interrupt): Remove ptid_t parameter.  Update comment.
9960         (target_pass_ctrlc): Update comment.
9961         * target/target.h (target_terminal_state): New scoped enum,
9962         factored out of ...
9963         (target_terminal::terminal_state): ... here.
9964         (target_terminal::inferior): Update comments.
9965         (target_terminal::restore_inferior): New.
9966         (target_terminal::is_inferior, target_terminal::is_ours)
9967         (target_terminal::is_ours_for_output): Adjust.
9968         (target_terminal::scoped_restore_terminal_state): Adjust to
9969         rename, and call restore_inferior() instead of inferior().
9970         (target_terminal::scoped_restore_terminal_state::m_state): Change
9971         type.
9972         (target_terminal::terminal_state): Rename to ...
9973         (target_terminal::m_terminal_state): ... this and change type.
9974
9975 2018-01-30  Pedro Alves  <palves@redhat.com>
9976
9977         * linux-nat.c (wait_for_signal): New function.
9978         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
9979         directly.
9980         (async_terminal_is_ours)
9981         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
9982         (linux_nat_add_target): Don't override
9983         to_terminal_inferior/to_terminal_ours.
9984
9985 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9986
9987         * remote.c (remote_follow_fork): Don't call "detach_inferior".
9988
9989 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
9990
9991         * dwarf2read.c (free_dwo_files): Add forward-declaration.
9992         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
9993         dwarf2_per_objfile_free here.
9994         (dwarf2_per_objfile_free): Remove.
9995         (_initialize_dwarf2_read): Don't register
9996         dwarf2_per_objfile_free as a registry cleanup.
9997
9998 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
9999
10000         Avoid compilation errors in MinGW native builds
10001
10002         The error is triggered by including python-internal.h, and the
10003         error message is:
10004
10005              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
10006                       from build-gnulib/import/math.h:27,
10007                       from d:/usr/Python26/include/pyport.h:235,
10008                       from d:/usr/Python26/include/Python.h:58,
10009                       from python/python-internal.h:94,
10010                       from python/py-arch.c:24:
10011              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
10012         using ::hypot;
10013                 ^~~~~
10014
10015         This happens because Python headers define 'hypot' to expand t
10016         '_hypot' in the Windows builds.
10017         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
10018         'hypoth'.  This avoids a compilation error.
10019
10020 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
10021
10022         * MAINTAINERS (Write After Approval): Fix ordering.
10023
10024 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
10025
10026         * MAINTAINERS (Write After Approval): Add Alan Hayward.
10027
10028 2018-01-26  Alan Modra  <amodra@gmail.com>
10029
10030         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
10031         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
10032         Remove nop.  Make const.  Comment.
10033         (powerpc32_plt_stub_so_2): New.
10034         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
10035         Correct count.  Update uses.
10036         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
10037         Move common code reading PLT entry word.  Correct
10038         powerpc32_plt_stub PLT address calculation.
10039         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
10040         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
10041         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
10042         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
10043         (ppc64_standard_linkage8): Likewise.
10044         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
10045         Correct insns description.
10046         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
10047
10048 2018-01-24  Pedro Alves  <palves@redhat.com>
10049
10050         GCC PR libstdc++/83906
10051         * gdbtypes.c (operator==(const dynamic_prop &,
10052         const dynamic_prop &)): New.
10053         (operator==(const range_bounds &, const range_bounds &)): New.
10054         (check_types_equal): Use them instead of memcmp.
10055         * gdbtypes.h (operator==(const dynamic_prop &,
10056         const dynamic_prop &)): Declare.
10057         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
10058         (operator==(const range_bounds &, const range_bounds &)): Declare.
10059         (operator!=(const range_bounds &, const range_bounds &)): Declare.
10060
10061 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10062
10063         * s390-linux-tdep.c (s390_record_address_mask)
10064         (s390_record_calc_disp_common, s390_record_calc_disp)
10065         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
10066         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
10067         (s390_process_record): Move to s390-tdep.c.
10068         (s390_linux_init_abi_any): Adjust.
10069         * s390-tdep.c (s390_record_address_mask)
10070         (s390_record_calc_disp_common, s390_record_calc_disp)
10071         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
10072         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
10073         (s390_process_record): Moved from s390-linux-tdep.c
10074         (s390_gdbarch_init): Adjust.
10075
10076 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10077
10078         * s390-linux-nat.c (s390-tdep.h): New include.
10079         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
10080         (HFILES_NO_SRCDIR): Add s390-tdep.h.
10081         (ALLDEPFILES): Add s390-tdep.c.
10082         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
10083         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
10084         * s390-tdep.h: ...this.  New file.
10085         * s390-linux-tdep.c (s390-tdep.h): New include.
10086         (_initialize_s390_tdep): Rename to...
10087         (_initialize_s390_linux_tdep): ...this and adjust.
10088         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
10089         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
10090         s390-tdep.h.
10091         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
10092         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
10093         (s390_is_partial_instruction, s390_software_single_step)
10094         (is_non_branch_ril, s390_displaced_step_copy_insn)
10095         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
10096         (s390_prologue_data, s390_addr, s390_store, s390_load)
10097         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
10098         (s390_register_call_saved, s390_guess_tracepoint_registers)
10099         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
10100         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
10101         (s390_pseudo_register_name, s390_pseudo_register_type)
10102         (s390_pseudo_register_read, s390_pseudo_register_write)
10103         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
10104         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
10105         (s390_addr_bits_remove, s390_address_class_type_flags)
10106         (s390_address_class_type_flags_to_name)
10107         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
10108         (s390_function_arg_float, s390_function_arg_vector)
10109         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
10110         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
10111         (s390_frame_align, s390_register_return_value, s390_return_value)
10112         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
10113         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
10114         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
10115         (s390_trad_frame_prev_register, s390_unwind_cache)
10116         (s390_prologue_frame_unwind_cache)
10117         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
10118         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
10119         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
10120         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
10121         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
10122         (s390_frame_base_address, s390_local_base_address)
10123         (s390_frame_base, s390_gcc_target_options)
10124         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
10125         (s390_validate_reg_range, s390_tdesc_valid)
10126         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
10127         * s390-tdep.c: ...this.  New file.
10128
10129 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10130
10131         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
10132         (s390_process_record, s390_gdbarch_tdep_alloc)
10133         (s390_linux_init_abi_any): Use/set new hook.
10134
10135 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10136
10137         * s390-linux-tdep.c (osabi.h): New include.
10138         (s390_linux_init_abi_31, s390_linux_init_abi_64)
10139         (s390_linux_init_abi_any): New functions.
10140         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
10141
10142 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10143
10144         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
10145         tdesc_has_registers check
10146
10147 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10148
10149         * s390-linux-tdep.c (s390_tdesc_valid): New function.
10150         (s390_validate_reg_range): New macro.
10151         (s390_gdbarch_init): Adjust.
10152
10153 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10154
10155         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
10156         (s390_gdbarch_tdep_alloc): Adjust.
10157         (s390_gdbarch_init): Adjust.
10158
10159 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10160
10161         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
10162         <have_tdb>: Change type to bool.
10163         (s390_gdbarch_tdep_alloc): Adjust.
10164         (s390_gdbarch_init): Adjust.
10165
10166 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10167
10168         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
10169         (gdbarch_tdep) <have_upper, have_vx>: New fields.
10170         (s390_gdbarch_tdep_alloc): New function.
10171         (s390_gdbarch_init): Allocate tdep at start and use its fields
10172         instead of separate variables.
10173
10174 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10175
10176         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
10177         when looking for cached gdbarch and add comment for remaining.
10178
10179 2018-01-22  Pedro Alves  <palves@redhat.com>
10180             Sergio Durigan Junior  <sergiodj@redhat.com>
10181
10182         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
10183         case.
10184
10185 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
10186
10187         * MAINTAINERS: Update my company e-mail address.
10188
10189 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10190
10191         * regcache.c (cooked_write_test): New function.
10192         (_initialize_regcache): Register the test.
10193
10194 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10195
10196         * ia64-tdep.c (ia64_pseudo_register_read): Call
10197         regcache->cooked_read instead of regcache_cooked_read_unsigned.
10198         * m32c-tdep.c (m32c_cat_read): Likewise.
10199         (m32c_r3r2r1r0_read): Likewise.
10200         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
10201         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
10202
10203 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10204
10205         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
10206         method raw_read instead of regcache_raw_read.
10207         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
10208         * arm-tdep.c (arm_neon_quad_read): Likewise.
10209         * avr-tdep.c (avr_pseudo_register_read): Likewise.
10210         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
10211         * frv-tdep.c (frv_pseudo_register_read): Likewise.
10212         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
10213         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
10214         (i386_pseudo_register_read_into_value): Likewise.
10215         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
10216         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
10217         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
10218         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
10219         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
10220         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
10221         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
10222         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
10223         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
10224
10225 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10226
10227         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
10228         * configure.tgt: Remove target mt.
10229         * mt-tdep.c: Remove.
10230         * regcache.c (cooked_read_test): Remove the check for mt.
10231
10232 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10233
10234         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
10235         instead of gdbarch_pseudo_register_read_value.
10236
10237 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
10238
10239         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
10240         language is Ada.
10241
10242 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
10243
10244         * linespec.c (create_sals_line_offset): Remove code that preserved
10245         the symtab_and_line's line number.
10246
10247 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * varobj.c (varobj_create): Don't set valid_block when creating a
10250         floating varobj.
10251
10252 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10253
10254         * varobj.c (varobj_create): Remove out of date comment.
10255
10256 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10257
10258         PR mi/20395
10259         * ada-exp.y (write_var_from_sym): Pass extra parameter when
10260         updating innermost block.
10261         * parse.c (innermost_block_tracker::update): Take extra type
10262         parameter, and check types match before updating innermost block.
10263         (write_dollar_variable): Update innermost block for registers.
10264         * parser-defs.h (enum innermost_block_tracker_type): New enum.
10265         (innermost_block_tracker::innermost_block_tracker): Initialise
10266         m_types member.
10267         (innermost_block_tracker::reset): Take type parameter.
10268         (innermost_block_tracker::update): Take type parameter, and pass
10269         type through as needed.
10270         (innermost_block_tracker::m_types): New member.
10271         * varobj.c (varobj_create): Pass type when reseting innermost
10272         block.
10273
10274 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10275
10276         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
10277         * ada-lang.c (resolve_subexp): Likewise.
10278         * breakpoint.c (set_breakpoint_condition) Likewise.
10279         (watch_command_1) Likewise.
10280         * c-exp.y (variable): Likewise.
10281         * d-exp.y (PrimaryExpression): Likewise.
10282         * f-exp.y (variable): Likewise.
10283         * go-exp.y (variable): Likewise.
10284         * m2-exp.y (variable): Likewise.
10285         * objfiles.c (objfile::~objfile): Likewise.
10286         * p-exp.y (variable): Likewise.
10287         * parse.c (innermost_block): Change type.
10288         * parser-defs.h (class innermost_block_tracker): New.
10289         (innermost_block): Change to innermost_block_tracker.
10290         * printcmd.c (display_command): Switch to innermost_block API.
10291         (do_one_display): Likewise.
10292         * rust-exp.y (do_one_display): Likewise.
10293         * symfile.c (clear_symtab_users): Likewise.
10294         * varobj.c (varobj_create): Switch to innermost_block API, replace
10295         use of innermost_block with block stored on varobj object.
10296
10297 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10298
10299         * expression.h (innermost_block): Remove declaration.
10300         * varobj.c: Add 'parser-defs.h' include.
10301
10302 2018-01-19  Tom Tromey  <tom@tromey.com>
10303
10304         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
10305         symbols in the static and global blocks.
10306
10307 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
10308
10309         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
10310         gdb_ptrace.h, and move including gdb_wait.h ...
10311         * nat/linux-ptrace.h: ... to here.
10312
10313 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10314
10315         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
10316         inf_ptrace_detach_success.
10317         (inf_ptrace_detach_success): Add inferior parameter, use it
10318         instead of inferior_ptid, pass it to detach_inferior.
10319         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
10320         parameter.
10321         * inferior.c (detach_inferior): Add overload that takes an
10322         inferior object.
10323         * inferior.h (detach_inferior): Likewise.
10324         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
10325         use inferior_ptid, adjust call to inf_ptrace_detach_success.
10326         * linux-thread-db.c (thread_db_detach): Use inf parameter.
10327
10328 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10329
10330         * target.h (struct target_ops) <to_detach>: Add inferior
10331         parameter.
10332         (target_detach): Likewise.
10333         * target.c (dispose_inferior): Pass inferior down.
10334         (target_detach): Pass inferior down.  Assert that it is equal to
10335         the current inferior.
10336         * aix-thread.c (aix_thread_detach): Pass inferior down.
10337         * corefile.c (core_file_command): Pass current_inferior() down.
10338         * corelow.c (core_detach): Add inferior parameter.
10339         * darwin-nat.c (darwin_detach): Likewise.
10340         * gnu-nat.c (gnu_detach): Likewise.
10341         * inf-ptrace.c (inf_ptrace_detach): Likewise.
10342         * infcmd.c (detach_command): Pass current_inferior() down to
10343         target_detach.
10344         * infrun.c (follow_fork_inferior): Pass parent_inf to
10345         target_detach.
10346         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
10347         target_detach.
10348         * linux-nat.c (linux_nat_detach): Add inferior parameter.
10349         * linux-thread-db.c (thread_db_detach): Likewise.
10350         * nto-procfs.c (procfs_detach): Likewise.
10351         * procfs.c (procfs_detach): Likewise.
10352         * record.c (record_detach): Likewise.
10353         * record.h (struct inferior): Forward-declare.
10354         (record_detach): Add inferior parameter.
10355         * remote-sim.c (gdbsim_detach): Likewise.
10356         * remote.c (remote_detach_1): Likewise.
10357         (remote_detach): Likewise.
10358         (extended_remote_detach): Likewise.
10359         * sol-thread.c (sol_thread_detach): Likewise.
10360         * target-debug.h (target_debug_print_inferior_p): New macro.
10361         * target-delegates.c: Re-generate.
10362         * top.c (kill_or_detach): Pass inferior down to target_detach.
10363         * windows-nat.c (windows_detach): Add inferior parameter.
10364
10365 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10366
10367         * target.h (struct target_ops) <to_detach>: Remove args
10368         parameter.
10369         (target_detach): Likewise.
10370         * target.c (dispose_inferior): Adjust.
10371         (target_detach): Remove args parameter, adjust.
10372         * aix-thread.c (aix_thread_detach): Adjust.
10373         * corefile.c (core_file_command): Adjust.
10374         * corelow.c (core_detach): Adjust.
10375         * darwin-nat.c (darwin_detach): Adjust.
10376         * gnu-nat.c (gnu_detach): Adjust.
10377         * inf-ptrace.c (inf_ptrace_detach): Adjust.
10378         * infcmd.c (detach_command): Adjust
10379         * infrun.c (follow_fork_inferior): Adjust.
10380         (handle_vfork_child_exec_or_exit): Adjust.
10381         * linux-fork.c (linux_fork_detach): Remove args parameter.
10382         * linux-fork.h (linux_fork_detach): Likewise.
10383         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
10384         * linux-thread-db.c (thread_db_detach): Likewise.
10385         * nto-procfs.c (procfs_detach): Likewise.
10386         * procfs.c (procfs_detach): Likewise.
10387         (do_detach): Remove signo parameter.
10388         * record.c (record_detach): Remove args parameter.
10389         * record.h (record_detach): Likewise.
10390         * remote-sim.c (gdbsim_detach): Likewise.
10391         * remote.c (remote_detach_1): Likewise.
10392         (remote_detach): Likewise.
10393         (extended_remote_detach): Likewise.
10394         * sol-thread.c (sol_thread_detach): Likewise.
10395         * target-delegates.c: Re-generate.
10396         * top.c (struct qt_args) <args>: Remove field.
10397         (kill_or_detach): Don't pass args.
10398         (quit_force): Don't set args.
10399         * windows-nat.c (windows_detach): Remove args parameter.
10400
10401 2018-01-19  Yao Qi  <yao.qi@linaro.org>
10402
10403         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
10404         (arm_linux_init_abi): Install it.
10405
10406 2018-01-19  Yao Qi  <yao.qi@linaro.org>
10407
10408         * osabi.c (gdb_osabi_names): Extend the regexp for
10409         arm-linux-gnueabihf.
10410
10411 2018-01-18  Yao Qi  <yao.qi@linaro.org>
10412
10413         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
10414         m_abbrevs.
10415         (abbrev_table::add_abbrev): Update.
10416         (abbrev_table::lookup_abbrev): Update.
10417
10418 2018-01-18  Yao Qi  <yao.qi@linaro.org>
10419
10420         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
10421
10422 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
10423
10424         * compile/compile.c (compile_to_object): Convert "triplet_rx"
10425         to "std::string".
10426
10427 2018-01-17  Tom Tromey  <tom@tromey.com>
10428
10429         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
10430
10431 2018-01-17  Tom Tromey  <tom@tromey.com>
10432
10433         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
10434         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
10435         (create_array_type_with_stride): Update.
10436         * dwarf2read.c (set_die_type): Update.
10437
10438 2018-01-17  Tom Tromey  <tom@tromey.com>
10439
10440         * dwarf2read.c (delayed_method_info): Remove typedef.
10441         (dwarf2_cu::method_info): Now a std::vector.
10442         (add_to_method_list): Update.
10443         (free_delayed_list): Remove.
10444         (compute_delayed_physnames): Update.
10445         (process_full_comp_unit, process_full_type_unit): Clear the method
10446         list.  Remove cleanups.
10447         (psymtab_include_file_name): Add name_holder parameter.  Use
10448         unique_xmalloc_ptr.
10449         (dwarf_decode_lines): Update.
10450
10451 2018-01-17  Tom Tromey  <tom@tromey.com>
10452             Simon Marchi  <simon.marchi@ericsson.com>
10453
10454         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
10455         (dwarf2_per_objfile::free_cached_comp_units)
10456         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
10457         (init_cutu_and_read_dies_no_follow): Update.
10458         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
10459         (dwarf2_cu::~dwarf2_cu): New.
10460         (free_heap_comp_unit, free_stack_comp_unit): Remove.
10461         (age_cached_comp_units, free_one_cached_comp_unit): Update.
10462
10463 2018-01-17  Tom Tromey  <tom@tromey.com>
10464             Simon Marchi  <simon.marchi@ericsson.com>
10465
10466         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
10467         (struct die_reader_specs) <abbrev_table>: New member.
10468         (struct abbrev_table): Add constructor.
10469         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
10470         <abbrev_obstack>: Now an auto_obstack.
10471         (abbrev_table_up): New typedef.
10472         (init_cu_die_reader): Add abbrev_table parameter.
10473         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
10474         Add result_dwo_abbrev_table.
10475         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
10476         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
10477         Update.
10478         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
10479         parameter.
10480         (skip_children): Update.
10481         (abbrev_table::alloc_abbrev): Rename from
10482         abbrev_table_alloc_abbrev.
10483         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
10484         (abbrev_table::lookup_abbrev): Rename from
10485         abbrev_table_lookup_abbrev.
10486         (abbrev_table_read_table): Return abbrev_table_up.
10487         (abbrev_table_free, abbrev_table_free_cleanup)
10488         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
10489         (load_partial_dies): Update.
10490
10491 2018-01-17  Tom Tromey  <tom@tromey.com>
10492
10493         * dwarf2read.c (dwarf2_compute_name): Update comment.
10494         (read_func_scope, read_variable): Update.
10495         (new_symbol): Remove.
10496         (new_symbol_full): Rename to new_symbol.
10497
10498 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
10499
10500         PR gdb/16577
10501         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
10502         a warning instead of throwing an error, set section size to 0 and return
10503         NULL.
10504         * gdb_bfd.h (gdb_bfd_map_section): Update description.
10505
10506 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
10507
10508         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
10509         std::string.
10510         (linux_ptrace_attach_fail_reason_string): Likewise.
10511         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
10512         Likewise.
10513         (linux_ptrace_attach_fail_reason_string): Likewise.
10514         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
10515
10516 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
10517
10518         * linux-nat.c (linux_nat_attach): Remove xstrdup.
10519
10520 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
10521
10522         PR gdb/21559
10523         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
10524         checking for fs_base/gs_base fields in struct user_regs_struct.
10525         * configure: Regenerate.
10526
10527 2018-01-17  Yao Qi  <yao.qi@linaro.org>
10528
10529         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
10530         function.
10531         (aarch64_linux_init_abi): Install it to gdbarch hook
10532         gcc_target_options.
10533
10534 2018-01-15  Pedro Alves  <palves@redhat.com>
10535
10536         * common/signals-state-save-restore.c
10537         (save_original_signals_state): Fix typos.
10538
10539 2017-01-12  Tom Tromey  <tom@tromey.com>
10540             Sergio Durigan Junior  <sergiodj@redhat.com>
10541
10542         * Makefile.in (install-only): Install gdb-add-index.
10543
10544 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
10545
10546         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
10547
10548 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10549
10550         * infrun.c (keep_going_pass_signal): Clear step-over info when
10551         insert_breakpoints fails.
10552
10553 2018-01-11  Pedro Alves  <palves@redhat.com>
10554
10555         PR gdb/22583
10556         * infrun.c (resume): Rename to ...
10557         (resume_1): ... this.
10558         (resume): Reimplement as wrapper around resume_1.
10559
10560 2018-01-11  Pedro Alves  <palves@redhat.com>
10561
10562         PR remote/22597
10563         * remote.c (remote_parse_stop_reply): Default to the last-set
10564         general thread instead of to 'magic_null_ptid'.
10565
10566 2018-01-10  Pedro Alves  <palves@redhat.com>
10567
10568         * language.h (language_get_symbol_name_matcher): Rename ...
10569         (get_symbol_name_matcher): ... this.
10570         * language.c (language_get_symbol_name_matcher): Ditto.
10571         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
10572         callers adjusted.
10573
10574 2018-01-10  Pedro Alves  <palves@redhat.com>
10575
10576         PR gdb/22670
10577         * dwarf2read.c
10578         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
10579         Adjust to use language_get_symbol_name_matcher instead of
10580         language_defn::la_get_symbol_name_matcher.
10581         * language.c (language_get_symbol_name_matcher): If in Ada mode
10582         and the lookup name is a verbatim match, return Ada's matcher.
10583         * language.h (language_get_symbol_name_matcher): Adjust comment.
10584         (ada_lookup_name_info::verbatim_p):: New method.
10585
10586 2018-01-10  Pedro Alves  <palves@redhat.com>
10587
10588         PR gdb/22670
10589         * ada-lang.c (ada_collect_symbol_completion_matches): If the
10590         minsym's language is language_auto or language_cplus, pass down
10591         language_ada instead.
10592         * symtab.c (compare_symbol_name): Don't frob symbol language here.
10593
10594 2018-01-10  Pedro Alves  <palves@redhat.com>
10595
10596         PR gdb/22670
10597         * minsyms.c (linkage_name_str): New function.
10598         (iterate_over_minimal_symbols): Use it.
10599
10600 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10601
10602         * NEWS: Document that 'info proc' now works on FreeBSD.
10603
10604 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10605
10606         * configure.ac: Check for kinfo_getfile in libutil.
10607         * configure: Regenerate.
10608         * config.in: Regenerate.
10609         * fbsd-nat.c: Include "fbsd-tdep.h".
10610         (fbsd_fetch_cmdline): New.
10611         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
10612         rather than calling error.
10613         (fbsd_info_proc): New.
10614         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
10615         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
10616         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
10617
10618 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10619
10620         * fbsd-nat.c (struct free_deleter): Remove.
10621         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
10622
10623 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10624
10625         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
10626         NULL for an empty pathname.
10627
10628 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10629
10630         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
10631         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
10632         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
10633         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
10634         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
10635         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
10636         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
10637         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
10638         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
10639         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
10640         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
10641         (fbsd_core_fetch_timeval, fbsd_print_sigset)
10642         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
10643         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
10644         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
10645
10646 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
10647
10648         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
10649         (gnu_xfer_auxv): New function.
10650         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
10651         TARGET_OBJECT_AUXV.
10652
10653 2018-01-08  Yao Qi  <yao.qi@linaro.org>
10654             Simon Marchi  <simon.marchi@ericsson.com>
10655
10656         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
10657         common/selftest.c.
10658         (COMMON_OBS): Remove selftest.o.
10659         * configure.ac: Append selftest-arch.c and common/selftest.c to
10660         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
10661         * configure: Re-generated.
10662         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
10663         GDB_SELF_TEST.
10664         (maintenance_info_selftests): Likewise.
10665
10666 2018-01-08  Xavier Roirand  <roirand@adacore.com>
10667
10668         * ada-valprint.c (val_print_packed_array_elements): Use
10669         proper number of elements when printing an array indexed
10670         by an enumeration type.
10671
10672 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
10673
10674         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
10675         (dw2_get_file_names_reader): Adjust.
10676         (lookup_dwo_signatured_type): Adjust.
10677         (lookup_dwp_signatured_type): Adjust.
10678         (lookup_signatured_type): Adjust.
10679         (create_type_unit_group): Adjust.
10680         (get_type_unit_group): Adjust.
10681         (process_psymtab_comp_unit_reader): Adjust.
10682         (build_type_psymtabs_reader): Adjust.
10683         (scan_partial_symbols): Adjust.
10684         (add_partial_symbol): Adjust.
10685         (add_partial_subprogram): Adjust.
10686         (peek_die_abbrev): Adjust.
10687         (fixup_go_packaging): Adjust.
10688         (process_imported_unit_die): Adjust.
10689         (dwarf2_compute_name): Adjust.
10690         (dwarf2_physname): Adjust.
10691         (read_import_statement): Adjust.
10692         (handle_DW_AT_stmt_list): Adjust.
10693         (read_file_scope): Adjust.
10694         (read_func_scope): Adjust.
10695         (read_lexical_block_scope): Adjust.
10696         (read_call_site_scope): Adjust.
10697         (read_variable): Adjust.
10698         (dwarf2_rnglists_process): Adjust.
10699         (dwarf2_ranges_process): Adjust.
10700         (dwarf2_ranges_read): Adjust.
10701         (dwarf2_get_pc_bounds): Adjust.
10702         (dwarf2_record_block_ranges): Adjust.
10703         (dwarf2_add_field): Adjust.
10704         (dwarf2_add_member_fn): Adjust.
10705         (read_structure_type): Adjust.
10706         (process_structure_scope): Adjust.
10707         (read_enumeration_type): Adjust.
10708         (read_array_type): Adjust.
10709         (mark_common_block_symbol_computed): Adjust.
10710         (read_common_block): Adjust.
10711         (read_namespace_type): Adjust.
10712         (read_namespace): Adjust.
10713         (read_module_type): Adjust.
10714         (read_tag_pointer_type): Adjust.
10715         (read_tag_ptr_to_member_type): Adjust.
10716         (read_tag_string_type): Adjust.
10717         (read_subroutine_type): Adjust.
10718         (read_typedef): Adjust.
10719         (read_base_type): Adjust.
10720         (attr_to_dynamic_prop): Adjust.
10721         (read_subrange_type): Adjust.
10722         (read_unspecified_type): Adjust.
10723         (dwarf2_read_abbrevs): Adjust.
10724         (load_partial_dies): Adjust.
10725         (read_partial_die): Adjust.
10726         (find_partial_die): Adjust.
10727         (guess_partial_die_structure_name): Adjust.
10728         (fixup_partial_die): Adjust.
10729         (read_attribute_value): Adjust.
10730         (read_addr_index): Adjust.
10731         (read_addr_index_from_leb128): Adjust.
10732         (read_str_index): Adjust.
10733         (dwarf2_string_attr): Adjust.
10734         (get_debug_line_section): Adjust.
10735         (dwarf_decode_line_header): Adjust.
10736         (lnp_state_machine::check_line_address): Adjust.
10737         (dwarf_decode_lines_1): Adjust.
10738         (dwarf_decode_lines): Adjust.
10739         (dwarf2_start_symtab): Adjust.
10740         (var_decode_location): Adjust.
10741         (new_symbol_full): Adjust.
10742         (dwarf2_const_value_data): Adjust.
10743         (dwarf2_const_value_attr): Adjust.
10744         (dwarf2_const_value): Adjust.
10745         (die_type): Adjust.
10746         (die_containing_type): Adjust.
10747         (build_error_marker_type): Adjust.
10748         (lookup_die_type): Adjust.
10749         (guess_full_die_structure_name): Adjust.
10750         (anonymous_struct_prefix): Adjust.
10751         (determine_prefix): Adjust.
10752         (dwarf2_name): Adjust.
10753         (follow_die_ref_or_sig): Adjust.
10754         (follow_die_offset): Adjust.
10755         (follow_die_ref): Adjust.
10756         (follow_die_sig_1): Adjust.
10757         (follow_die_sig): Adjust.
10758         (get_signatured_type): Adjust.
10759         (get_DW_AT_signature_type): Adjust.
10760         (decode_locdesc): Adjust.
10761         (dwarf_decode_macros): Adjust.
10762         (cu_debug_loc_section): Adjust.
10763         (fill_in_loclist_baton): Adjust.
10764         (dwarf2_symbol_mark_computed): Adjust.
10765         (init_one_comp_unit): Don't assign
10766         dwarf2_cu::dwarf2_per_objfile.
10767         (set_die_type): Adjust.
10768
10769 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
10770
10771         * dwarf2read.c (struct mapped_debug_names): Add constructor.
10772         <dwarf2_per_objfile>: New field.
10773         (dwarf2_per_objfile): Remove global.
10774         (get_dwarf2_per_objfile): New function.
10775         (set_dwarf2_per_objfile): New function.
10776         (dwarf2_build_psymtabs_hard): Change objfile parameter to
10777         dwarf2_per_objfile.
10778         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
10779         (read_abbrev_offset): Likewise.
10780         (read_indirect_string): Likewise.
10781         (read_indirect_line_string): Likewise.
10782         (read_indirect_string_at_offset): Likewise.
10783         (read_indirect_string_from_dwz): Likewise.
10784         (dwarf2_find_containing_comp_unit): Change objfile parameter to
10785         dwarf2_per_objfile.
10786         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
10787         (create_all_comp_units): Change objfile parameter to
10788         dwarf2_per_objfile.
10789         (create_all_type_units): Likewise.
10790         (process_queue): Add dwarf2_per_objfile parameter.
10791         (read_and_check_comp_unit_head): Likewise.
10792         (lookup_dwo_unit_in_dwp): Likewise.
10793         (get_dwp_file): Likewise.
10794         (process_cu_includes): Likewise.
10795         (struct free_dwo_file_cleanup_data): New struct.
10796         (dwarf2_has_info): Use get_dwarf2_per_objfile and
10797         set_dwarf2_per_objfile.
10798         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
10799         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
10800         context, adjust calls.
10801         (dw2_instantiate_symtab): Likewise.
10802         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
10803         (dw2_get_cu): Likewise.
10804         (create_cu_from_index_list): Change objfile parameter to
10805         dwarf2_per_objfile.
10806         (create_cus_from_index_list): Get dwarf2_per_objfile from
10807         context, adjust calls.
10808         (create_cus_from_index): Likewise.
10809         (create_signatured_type_table_from_index): Change objfile
10810         parameter to dwarf2_per_objfile.
10811         (create_signatured_type_table_from_debug_names): Change objfile
10812         parameter to dwarf2_per_objfile.
10813         (create_addrmap_from_index): Likewise.
10814         (create_addrmap_from_aranges): Likewise.
10815         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
10816         (dw2_setup): Remove.
10817         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
10818         context.
10819         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
10820         get_dwarf2_per_objfile.
10821         (dw2_forget_cached_source_info): Likewise.
10822         (dw2_map_symtabs_matching_filename): Likewise.
10823         (struct dw2_symtab_iterator) <index>: Remove.
10824         <dwarf2_per_objfile>: New field.
10825         (dw2_symtab_iter_init): Replace index parameter with
10826         dwarf2_per_objfile.
10827         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
10828         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
10829         (dw2_print_stats): Likewise.
10830         (dw2_dump): Likewise.
10831         (dw2_expand_symtabs_for_function): Likewise.
10832         (dw2_expand_all_symtabs): Likewise.
10833         (dw2_expand_symtabs_with_fullname): Likewise.
10834         (dw2_expand_marked_cus): Replace index and objfile parameters
10835         with dwarf2_per_objfile.
10836         (dw_expand_symtabs_matching_file_matcher): Add
10837         dwarf2_per_objfile parameter and adjust calls.
10838         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
10839         adjust calls.
10840         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
10841         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
10842         adjust calls.
10843         (create_cus_from_debug_names_list): Replace objfile parameter
10844         with dwarf2_per_objfile and adjust calls.
10845         (create_cus_from_debug_names): Likewise.
10846         (dwarf2_read_debug_names): Likewise.
10847         (mapped_debug_names::namei_to_name): Adjust call.
10848         (dw2_debug_names_iterator::next): Likewise.
10849         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
10850         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
10851         (dw2_debug_names_dump): Likewise.
10852         (dw2_debug_names_expand_symtabs_for_function): Likewise.
10853         (dw2_debug_names_expand_symtabs_matching): Likewise.
10854         (dwarf2_initialize_objfile): Likewise.
10855         (dwarf2_build_psymtabs): Likewise.
10856         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
10857         this_cu.
10858         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
10859         (read_and_check_comp_unit_head): Likewise.
10860         (read_abbrev_offset): Likewise.
10861         (create_debug_type_hash_table): Likewise.
10862         (create_debug_types_hash_table): Likewise.
10863         (create_all_type_units): Replace objfile parameter with
10864         dwarf2_per_objfile.
10865         (add_type_unit): Add dwarf2_per_objfile parameter.
10866         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
10867         with dwarf2_per_objfile.
10868         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
10869         (lookup_dwp_signatured_type): Likewise.
10870         (lookup_signatured_type): Likewise.
10871         (read_cutu_die_from_dwo): Likewise.
10872         (init_tu_and_read_dwo_dies): Likewise.
10873         (init_cutu_and_read_dies): Likewise.
10874         (init_cutu_and_read_dies_no_follow): Likewise.
10875         (allocate_type_unit_groups_table): Add objfile parameter.
10876         (create_type_unit_group): Use dwarf2_per_objfile from cu.
10877         (get_type_unit_group): Likewise.
10878         (process_psymtab_comp_unit): Update call.
10879         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
10880         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
10881         (print_tu_stats): Likewise.
10882         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
10883         in void* parameter.
10884         (build_type_psymtabs): Change objfile parameter to
10885         dwarf2_per_objfile.
10886         (process_skeletonless_type_unit): Use dwarf2_per_objfile
10887         passed in void* parameter.
10888         (process_skeletonless_type_units): Change objfile parameter to
10889         dwarf2_per_objfile.
10890         (set_partial_user): Likewise.
10891         (dwarf2_build_psymtabs_hard): Likewise.
10892         (read_comp_units_from_section): Likewise.
10893         (create_all_comp_units): Likewise.
10894         (scan_partial_symbols): Update calls.
10895         (add_partial_symbol): Likewise.
10896         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
10897         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
10898         (process_queue): Add dwarf2_per_objfile parameter.
10899         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
10900         (compute_compunit_symtab_includes): Likewise.
10901         (process_cu_includes): Add dwarf2_per_objfile parameter.
10902         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
10903         (process_full_type_unit): Likewise.
10904         (process_imported_unit_die): Update call.
10905         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
10906         (read_file_scope): Likewise.
10907         (allocate_dwo_file_hash_table): Add objfile parameter.
10908         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
10909         (create_cus_hash_table): Likewise.
10910         (create_dwp_hash_table): Likewise.
10911         (create_dwo_unit_in_dwp_v1): Likewise.
10912         (create_dwp_v2_section): Likewise.
10913         (create_dwo_unit_in_dwp_v2): Likewise.
10914         (lookup_dwo_unit_in_dwp): Likewise.
10915         (try_open_dwop_file): Likewise.
10916         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
10917         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
10918         cleanup to include a reference to dwarf2_per_objfile.
10919         (open_dwp_file): Add dwarf2_per_objfile parameter.
10920         (open_and_init_dwp_file): Likewise.
10921         (get_dwp_file): Likewise.
10922         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
10923         (queue_and_load_all_dwo_tus): Update call.
10924         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
10925         data.
10926         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
10927         (dwarf2_ranges_process): Likewise.
10928         (dwarf2_get_pc_bounds): Likewise.
10929         (mark_common_block_symbol_computed): Likewise.
10930         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
10931         (dwarf2_read_abbrevs): Update call.
10932         (read_partial_die): Use dwarf2_per_objfile from cu.
10933         (find_partial_die): Likewise.
10934         (fixup_partial_die): Likewise.
10935         (read_attribute_value): Likewise.
10936         (read_indirect_string_at_offset_from): Add objfile parameter.
10937         (read_indirect_string_at_offset): Add dwarf2_per_objfile
10938         parameter.
10939         (read_indirect_string_from_dwz): Add objfile parameter.
10940         (read_indirect_string): Add objfile parameter.
10941         (read_addr_index_1): Add dwarf2_per_objfile parameter.
10942         (read_addr_index): Use dwarf2_per_objfile from cu.
10943         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
10944         call dw2_setup.
10945         (read_str_index): Use dwarf2_per_objfile from cu.
10946         (get_debug_line_section): Likewise.
10947         (read_formatted_entries): Add dwarf2_per_objfile parameter.
10948         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
10949         (new_symbol_full): Use dwarf2_per_objfile from cu.
10950         (build_error_marker_type): Likewise.
10951         (lookup_die_type): Likewise.
10952         (determine_prefix): Likewise.
10953         (follow_die_offset): Likewise.
10954         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
10955         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
10956         (dwarf2_fetch_die_type_sect_off): Likewise.
10957         (dwarf2_get_die_type): Likewise.
10958         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
10959         (get_signatured_type): Likewise.
10960         (get_DW_AT_signature_type): Likewise.
10961         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
10962         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
10963         (cu_debug_loc_section): Likewise.
10964         (fill_in_loclist_baton): Likewise.
10965         (dwarf2_symbol_mark_computed): Likewise.
10966         (dwarf2_find_containing_comp_unit): Change objfile parameter to
10967         dwarf2_per_objfile.
10968         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
10969         parameter.
10970         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
10971         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
10972         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
10973         (set_die_type): Use dwarf2_free_objfile from cu.
10974         (get_die_type_at_offset): Likewise.
10975         (dwarf2_per_objfile_free): Don't assign global variable.
10976         (debug_names) <constructor>: Add dwarf2_per_objfile
10977         parameter, update m_debugstrlookup construction.
10978         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
10979         parameter.
10980         <m_dwarf2_per_objfile>: New field.
10981         <lookup>: Use m_dwarf2_per_objfile.
10982         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
10983         (psyms_seen_size): Likewise.
10984         (write_gdbindex): Replace objfile parameter with
10985         dwarf2_per_objfile.
10986         (write_debug_names): Likewise.
10987         (write_psymtabs_to_index): Likewise.
10988         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
10989         calls.
10990
10991 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
10992
10993         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
10994         <dwarf2_per_objfile>: New field.
10995         (struct dwarf2_per_cu_data) <objfile>: Remove.
10996         <dwarf2_per_objfile>: New field.
10997         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
10998         of objfile.
10999         (create_signatured_type_table_from_index): Likewise.
11000         (create_debug_type_hash_table): Likewise.
11001         (fill_in_sig_entry_from_dwo_entry): Likewise.
11002         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
11003         (create_type_unit_group): Assign dwarf2_per_objfile instead of
11004         objfile.
11005         (create_partial_symtab): Access objfile through
11006         dwarf2_per_objfile.
11007         (process_psymtab_comp_unit_reader): Likewise.
11008         (read_comp_units_from_section): Likewise.
11009         (scan_partial_symbols): Likewise.
11010         (add_partial_symbol): Likewise.
11011         (add_partial_subprogram): Likewise.
11012         (peek_die_abbrev): Likewise.
11013         (fixup_go_packaging): Likewise.
11014         (process_full_comp_unit): Likewise.
11015         (process_full_type_unit): Likewise.
11016         (process_imported_unit_die): Likewise.
11017         (dwarf2_compute_name): Likewise.
11018         (dwarf2_physname): Likewise.
11019         (read_import_statement): Likewise.
11020         (create_cus_hash_table): Assign dwarf2_physname instead of
11021         objfile.
11022         (read_func_scope): Access objfile through dwarf2_per_objfile.
11023         (read_lexical_block_scope): Likewise.
11024         (read_call_site_scope): Likewise.
11025         (read_variable): Likewise.
11026         (dwarf2_rnglists_process): Likewise.
11027         (dwarf2_ranges_process): Likewise.
11028         (dwarf2_ranges_read): Likewise.
11029         (dwarf2_record_block_ranges): Likewise.
11030         (dwarf2_add_field): Likewise.
11031         (dwarf2_add_member_fn): Likewise.
11032         (read_structure_type): Likewise.
11033         (process_structure_scope): Likewise.
11034         (read_enumeration_type): Likewise.
11035         (read_array_type): Likewise.
11036         (read_common_block): Likewise.
11037         (read_namespace_type): Likewise.
11038         (read_namespace): Likewise.
11039         (read_module_type): Likewise.
11040         (read_tag_pointer_type): Likewise.
11041         (read_tag_ptr_to_member_type): Likewise.
11042         (read_tag_string_type): Likewise.
11043         (read_subroutine_type): Likewise.
11044         (read_typedef): Likewise.
11045         (read_base_type): Likewise.
11046         (attr_to_dynamic_prop): Likewise.
11047         (read_subrange_type): Likewise.
11048         (read_unspecified_type): Likewise.
11049         (load_partial_dies): Likewise.
11050         (read_partial_die): Likewise.
11051         (find_partial_die): Likewise.
11052         (guess_partial_die_structure_name): Likewise.
11053         (fixup_partial_die): Likewise.
11054         (read_attribute_value): Likewise.
11055         (read_addr_index_from_leb128): Likewise.
11056         (dwarf2_read_addr_index): Likewise.
11057         (dwarf2_string_attr): Likewise.
11058         (lnp_state_machine::check_line_address): Likewise.
11059         (dwarf_decode_lines_1): Likewise.
11060         (dwarf_decode_lines): Likewise.
11061         (dwarf2_start_symtab): Likewise.
11062         (var_decode_location): Likewise.
11063         (new_symbol_full): Likewise.
11064         (dwarf2_const_value_data): Likewise.
11065         (dwarf2_const_value_attr): Likewise.
11066         (dwarf2_const_value): Likewise.
11067         (die_type): Likewise.
11068         (die_containing_type): Likewise.
11069         (lookup_die_type): Likewise.
11070         (guess_full_die_structure_name): Likewise.
11071         (anonymous_struct_prefix): Likewise.
11072         (dwarf2_name): Likewise.
11073         (follow_die_ref_or_sig): Likewise.
11074         (follow_die_offset): Likewise.
11075         (follow_die_ref): Likewise.
11076         (dwarf2_fetch_die_loc_sect_off): Likewise.
11077         (dwarf2_fetch_constant_bytes): Likewise.
11078         (dwarf2_fetch_die_type_sect_off): Likewise.
11079         (dwarf2_get_die_type): Likewise.
11080         (follow_die_sig): Likewise.
11081         (decode_locdesc): Likewise.
11082         (dwarf2_per_cu_objfile): Likewise.
11083         (dwarf2_per_cu_text_offset): Likewise.
11084         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
11085         objfile.
11086         (set_die_type): Access objfile through
11087         dwarf2_per_objfile.
11088
11089 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
11090
11091         * valprint.c (converted_character_d): Remove typedef.
11092         (DEF_VEC_O (converted_character_d)): Remove.
11093         (count_next_character): Use std::vector.
11094         (print_converted_chars_to_obstack): Likewise.
11095         (generic_printstr): Likewise.
11096
11097 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11098
11099         * xml-support.h (struct gdb_xml_value): Add constructor.
11100         <value>: Change type to unique_xmalloc_ptr.
11101         (gdb_xml_value_s): Remove typedef.
11102         (DEF_VEC_O (gdb_xml_value_s)): Remove.
11103         (gdb_xml_element_start_handler): Change parameter type to
11104         std::vector.
11105         (xml_find_attribute): Likewise.
11106         * xml-support.c (xml_find_attribute): Change parameter type to
11107         std::vector and adjust.
11108         (gdb_xml_values_cleanup): Remove.
11109         (gdb_xml_parser::start_element): Adjust to std::vector.
11110         (xinclude_start_include): Change paraeter type to std::vector
11111         and adjust.
11112         * btrace.c (check_xml_btrace_version): Likewise.
11113         (parse_xml_btrace_block): Likewise.
11114         (parse_xml_btrace_pt_config_cpu): Likewise.
11115         (parse_xml_btrace_pt): Likewise.
11116         (parse_xml_btrace_conf_bts): Likewise.
11117         (parse_xml_btrace_conf_pt): Likewise.
11118         * memory-map.c (memory_map_start_memory): Likewise.
11119         (memory_map_start_property): Likewise.
11120         * osdata.c (osdata_start_osdata): Likewise.
11121         (osdata_start_item): Likewise.
11122         (osdata_start_column): Likewise.
11123         * remote.c (start_thread): Likewise.
11124         * solib-aix.c (library_list_start_library): Likewise.
11125         (library_list_start_list): Likewise.
11126         * solib-svr4.c (library_list_start_library): Likewise.
11127         (svr4_library_list_start_list): Likewise.
11128         * solib-target.c (library_list_start_segment): Likewise.
11129         (library_list_start_section): Likewise.
11130         (library_list_start_library): Likewise.
11131         (library_list_start_list): Likewise.
11132         * tracepoint.c (traceframe_info_start_memory): Likewise.
11133         (traceframe_info_start_tvar): Likewise.
11134         * xml-syscall.c (syscall_start_syscall): Likewise.
11135         * xml-tdesc.c (tdesc_start_target): Likewise.
11136         (tdesc_start_feature): Likewise.
11137         (tdesc_start_reg): Likewise.
11138         (tdesc_start_union): Likewise.
11139         (tdesc_start_struct): Likewise.
11140         (tdesc_start_flags): Likewise.
11141         (tdesc_start_enum): Likewise.
11142         (tdesc_start_field): Likewise.
11143         (tdesc_start_enum_value): Likewise.
11144         (tdesc_start_vector): Likewise.
11145
11146 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11147
11148         * extension.h (struct xmethod_worker) <clone>: Remove.
11149         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
11150         Remove.
11151         (python_xmethod_worker::clone): Remove.
11152         * valops.c (find_overload_match): Use std::move instead of
11153         clone.
11154
11155 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11156
11157         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
11158         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
11159         <free_xmethod_worker_data>: Remove.
11160         <get_matching_xmethod_workers>: Chance VEC to std::vector.
11161         <get_xmethod_arg_types>: Remove.
11162         <get_xmethod_result_type>: Remove.
11163         <invoke_xmethod>: Remove.
11164         * extension.c (new_xmethod_worker): Remove.
11165         (clone_xmethod_worker): Remove.
11166         (get_matching_xmethod_workers): Return void, pass std::vector by
11167         pointer.
11168         (get_xmethod_arg_types): Rename to...
11169         (xmethod_worker::get_arg_types): ... this, and adjust.
11170         (get_xmethod_result_type): Rename to...
11171         (xmethod_worker::get_result_type): ... this, and adjust.
11172         (invoke_xmethod): Remove.
11173         (free_xmethod_worker): Remove.
11174         (free_xmethod_worker_vec): Remove.
11175         * extension.h (enum ext_lang_rc): Move here from
11176         extension-priv.h.
11177         (struct xmethod_worker): Add constructor and destructor.
11178         <data>: Remove.
11179         <value>: Remove.
11180         <invoke, clone, do_get_result_type, do_get_arg_types>: New
11181         virtual pure methods.
11182         <get_arg_types, get_result_type>: New methods.
11183         (xmethod_worker_ptr): Remove typedef.
11184         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
11185         (xmethod_worker_vec): Remove typedef.
11186         (xmethod_worker_up): New typedef.
11187         (invoke_xmethod): Remove.
11188         (clone_xmethod_worker): Remove.
11189         (free_xmethod_worker): Remove.
11190         (free_xmethod_worker_vec): Remove.
11191         (get_xmethod_arg_types): Remove.
11192         (get_xmethod_result_type): Remove.
11193         * valops.c (find_method_list): Use std::vector, don't use
11194         intermediate vector.
11195         (value_find_oload_method_list): Use std::vector.
11196         (find_overload_match): Use std::vector.
11197         (find_oload_champ): Use std::vector.
11198         * value.c (value_free): Use operator delete.
11199         (value_of_xmethod): Rename to...
11200         (value_from_xmethod): ... this.  Don't assign
11201         xmethod_worker::value, take rvalue-reference.
11202         (result_type_of_xmethod): Adjust.
11203         (call_xmethod): Adjust.
11204         * value.h: Include extension.h.
11205         (struct xmethod_worker): Don't forward-declare.
11206         (value_of_xmethod): Rename to...
11207         (value_from_xmethod): ... this, take rvalue-reference.
11208         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
11209         (struct python_xmethod_worker): ... this, add constructor and
11210         destructor.
11211         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
11212         (gdbpy_free_xmethod_worker_data): Rename to...
11213         (python_xmethod_worker::~python_xmethod_worker): ... this and
11214         adjust.
11215         (gdbpy_clone_xmethod_worker_data): Rename to...
11216         (python_xmethod_worker::clone): ... this and adjust.
11217         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
11218         temporary vector.
11219         (gdbpy_get_xmethod_arg_types): Rename to...
11220         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
11221         (gdbpy_get_xmethod_result_type): Rename to...
11222         (python_xmethod_worker::do_get_result_type): ... this and
11223         adjust.
11224         (gdbpy_invoke_xmethod): Rename to...
11225         (python_xmethod_worker::invoke): ... this and adjust.
11226         (new_python_xmethod_worker): Rename to...
11227         (python_xmethod_worker::python_xmethod_worker): ... this and
11228         adjust.
11229         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
11230         Remove.
11231         (gdbpy_free_xmethod_worker_data): Remove.
11232         (gdbpy_get_matching_xmethod_workers): Use std::vector.
11233         (gdbpy_get_xmethod_arg_types): Remove.
11234         (gdbpy_get_xmethod_result_type): Remove.
11235         (gdbpy_invoke_xmethod): Remove.
11236         * python/python.c (python_extension_ops): Remove obsolete
11237         callbacks.
11238
11239 2018-01-05  Pedro Alves  <palves@redhat.com>
11240
11241         PR gdb/18653
11242         * common/signals-state-save-restore.c
11243         (save_original_signals_state): New parameter 'quiet'.  Warn if we
11244         find a custom handler preinstalled, instead of internal erroring.
11245         But only warn if !quiet.
11246         * common/signals-state-save-restore.h
11247         (save_original_signals_state): New parameter 'quiet'.
11248         * main.c (captured_main_1): Move save_original_signals_state call
11249         after option handling, and pass QUIET.
11250
11251 2018-01-05  Pedro Alves  <palves@redhat.com>
11252
11253         * spu-tdep.c (spu_catch_start): Pass
11254         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
11255
11256 2018-01-05  Pedro Alves  <palves@redhat.com>
11257
11258         PR gdb/22670
11259         * ada-lang.c (literal_symbol_name_matcher): New function.
11260         (ada_get_symbol_name_matcher): Use it for
11261         symbol_name_match_type::SEARCH_NAME.
11262         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
11263         it down instead of assuming symbol_name_match_type::FULL.
11264         * block.h (block_lookup_symbol): New parameter 'match_type'.
11265         * c-valprint.c (print_unpacked_pointer): Use
11266         lookup_symbol_search_name instead of lookup_symbol.
11267         * compile/compile-object-load.c (get_out_value_type): Pass down
11268         symbol_name_match_type::SEARCH_NAME.
11269         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
11270         symbol_name_match_type::FULL.
11271         * cp-support.c (cp_get_symbol_name_matcher): Handle
11272         symbol_name_match_type::SEARCH_NAME.
11273         * infrun.c (insert_exception_resume_breakpoint): Use
11274         lookup_symbol_search_name.
11275         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
11276         * psymtab.c (maintenance_check_psymtabs): Use
11277         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
11278         * stack.c (print_frame_args): Use lookup_symbol_search_name and
11279         SYMBOL_SEARCH_NAME.
11280         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
11281         if symbol_name_match_type::SEARCH_NAME.
11282         (lookup_symbol_in_language): Pass down
11283         symbol_name_match_type::FULL.
11284         (lookup_symbol_search_name): New.
11285         (lookup_language_this): Pass down
11286         symbol_name_match_type::SEARCH_NAME.
11287         (lookup_symbol_aux, lookup_local_symbol): New parameter
11288         'match_type'.  Pass it down.
11289         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
11290         (lookup_symbol_search_name): New declaration.
11291         (lookup_symbol_in_block): New 'match_type' parameter.
11292
11293 2018-01-05  Pedro Alves  <palves@redhat.com>
11294
11295         PR gdb/22670
11296         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
11297         ada_lookup_symbol.
11298         (ada_lookup_symbol): Reimplement in terms of
11299         ada_lookup_symbol_list, bits factored out from
11300         ada_lookup_encoded_symbol.
11301
11302 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11303
11304         * ada-exp.y (write_object_renaming): When subscripting an array
11305         using a symbol as the index, pass the block in call to
11306         ada_lookup_encoded_symbol when looking that symbol up.
11307
11308 2018-01-05  Jerome Guitton  <guitton@adacore.com>
11309
11310         * ada-lang.c (ada_array_length): Use ada_index_type instead of
11311         TYPE_INDEX_TYPE.
11312
11313 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11314
11315         * ada-lang.c (ada_to_fixed_value_create): Add handling of
11316         the case where VALUE_LVAL (val0) is not lval_memory.
11317
11318 2018-01-05  Xavier Roirand  <roirand@adacore.com>
11319
11320         * ada-valprint.c (print_optional_low_bound): Handle
11321         character-indexed array printing like boolean-indexed array
11322         printing.
11323
11324 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11325
11326         * NEWS: Create a new section for the next release branch.
11327         Rename the section of the current branch, now that it has
11328         been cut.
11329
11330 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11331
11332         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
11333         * version.in: Bump version to 8.1.50.DATE-git.
11334
11335 2018-01-03  Xavier Roirand  <roirand@adacore.com>
11336
11337         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
11338         Add field.
11339         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
11340         Add field.
11341         (default_exception_support_info) <catch_handlers_sym>: Add field.
11342         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
11343         (ada_exception_name_addr_1): Add "catch handlers" handling.
11344         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
11345         Update all callers.
11346         (create_excep_cond_exprs) <ex>: Add parameter.
11347         (re_set_exception): Update create_excep_cond_exprs call.
11348         (print_it_exception, print_one_exception, print_mention_exception)
11349         (print_recreate_exception): Add "catch handler" handling.
11350         (allocate_location_catch_handlers, re_set_catch_handlers)
11351         (check_status_catch_handlers, print_it_catch_handlers)
11352         (print_one_catch_handlers, print_mention_catch_handlers)
11353         (print_recreate_catch_handlers): New function.
11354         (catch_handlers_breakpoint_ops): New variable.
11355         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
11356         Add parameter.  Add "catch handler" handling.
11357         (ada_exception_sym_name, ada_exception_breakpoint_ops):
11358         Add "catch handler" handling.
11359         (ada_exception_catchpoint_cond_string): Add "catch handler"
11360         handling.
11361         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
11362         call.
11363         (catch_ada_handlers_command): New function.
11364         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
11365         operations structure.
11366         (_initialize_ada_language): Add "catch handlers" command entry.
11367         * NEWS: Document "catch handlers" feature.
11368
11369 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11370
11371         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
11372         account when creating the array type of the slice.
11373         (ada_value_slice): Likewise.
11374
11375 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11376
11377         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
11378         New enum value.
11379         (create_array_type_with_stride): Add byte_stride_prop parameter.
11380         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
11381         New parameter.  Update all callers in this file.
11382         (array_type_has_dynamic_stride): New function.
11383         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
11384         of arrays with dynamic byte strides.
11385         * dwarf2read.c (read_array_type): Add support for dynamic
11386         DW_AT_byte_stride attributes.
11387
11388 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11389
11390         * dwarf2read.c (read_unspecified_type): Treat
11391         DW_TAG_enumeration_type DIEs from Ada units as stubs.
11392
11393 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11394
11395         Update copyright year range in all GDB files.
11396
11397 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11398
11399         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
11400         and gdb/testsuite/gdb.base/step-line.c.
11401
11402 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11403
11404         * copyright.py (main): Dump the contents of
11405         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
11406         even if BY_HAND is empty.
11407
11408 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11409
11410         * top.c (print_gdb_version): Update Copyright year in version
11411         message.
11412
11413 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11414
11415         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
11416
11417 For older changes see ChangeLog-2017.
11418 \f
11419 Local Variables:
11420 mode: change-log
11421 left-margin: 8
11422 fill-column: 74
11423 version-control: never
11424 coding: utf-8
11425 End: