gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * NEWS (New commands): Mention "maint test-options
   4         require-delimiter", "maint test-options unknown-is-error", "maint
   5         test-options unknown-is-operand" and "maint show
   6         test-options-completion-result".
   7         (New command options, command completion): New section.
   8         (Completion improvements): New section.
   9         Mention that you can abbreviate "unlimited".
  10
  11 2019-06-13  Pedro Alves  <palves@redhat.com>
  12
  13         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  14         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  15         * unittests/cli-utils-selftests.c (test_parse_flags)
  16         (test_parse_flags_qcs): Delete.
  17         (test_cli_utils): Don't call deleted functions.
  18
  19 2019-06-13  Pedro Alves  <palves@redhat.com>
  20
  21         * thread.c: Include "cli/cli-option.h".
  22         (tp_array_compar_ascending): Global.
  23         (tp_array_compar): Delete function.
  24         (tp_array_compar_ascending, tp_array_compar_descending): New
  25         functions.
  26         (ascending_option_def, qcs_flag_option_def)
  27         (thr_qcs_flags_option_defs)
  28         (make_thread_apply_all_options_def_group)
  29         (make_thread_apply_options_def_group): New.
  30         (thread_apply_all_command): Use gdb::option::process_options.
  31         (thread_apply_command_completer)
  32         (thread_apply_all_command_completer): New.
  33         (thread_apply_command): Use gdb::option::process_options.
  34         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
  35         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
  36         to generate help text of "thread apply".  Adjust "taas"'s help.
  37         * tid-parse.c (tid_range_parser::in_thread_range): New method.
  38         * tid-parse.h (tid_range_parser::in_thread_range): New method.
  39
  40 2019-06-13  Pedro Alves  <palves@redhat.com>
  41
  42         * thread.c (thread_apply_command): Check for invalid TID with
  43         isdigit instead of !isalpha.
  44
  45 2019-06-13  Pedro Alves  <palves@redhat.com>
  46
  47         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
  48         (validate_flags_qcs): New.
  49         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
  50         (validate_flags_qcs): Declare.
  51         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
  52         (make_frame_apply_options_def_group): New.
  53         (frame_apply_command_count): Process options with
  54         gdb::option::process_options.
  55         (frame_apply_completer): New.
  56         (frame_apply_level_completer, frame_apply_all_completer)
  57         (frame_apply_completer): New.
  58         (_initialize_stack): Update help of "frame apply", "frame apply
  59         level", "frame apply all" and "faas" to mention supported options
  60         and install command completers.
  61         * stack.h (frame_apply_all_completer): Declare.
  62         * thread.c: Include "stack.h".
  63         (tfaas_command): Add "--".
  64         (_initialize_thread): Update help "tfaas" to mention supported
  65         options and install command completer.
  66
  67 2019-06-13  Pedro Alves  <palves@redhat.com>
  68
  69         * completer.c (complete_nested_command_line): New.
  70         (gdb_completion_word_break_characters_throw): Add assertion.
  71         * completer.h (complete_nested_command_line): Declare.
  72
  73 2019-06-13  Pedro Alves  <palves@redhat.com>
  74
  75         * stack.c (parse_backtrace_qualifiers): New.
  76         (backtrace_command): Use it.
  77         (backtrace_command_completer): Complete on qualifiers.
  78
  79 2019-06-13  Pedro Alves  <palves@redhat.com>
  80
  81         * frame.c: Include "cli/cli-option.h.
  82         (user_set_backtrace_options): New.
  83         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
  84         Delete.
  85         (get_prev_frame): Adjust.
  86         (boolean_option_def, uinteger_option_def)
  87         (set_backtrace_option_defs): New.
  88         (_initialize_frame): Adjust and use
  89         gdb::option::add_setshow_cmds_for_options to install "set
  90         backtrace past-main" and "set backtrace past-entry".
  91         * frame.h: Include "cli/cli-option.h".
  92         (struct frame_print_options): Forward declare.
  93         (print_frame_arguments_all, print_frame_arguments_scalars)
  94         (print_frame_arguments_none): Declare.
  95         (print_entry_values): Delete declaration.
  96         (struct frame_print_options, user_frame_print_options): New.
  97         (struct set_backtrace_options): New.
  98         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
  99         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 100         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 101         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 102         (list_args_or_locals): Add frame_print_options parameter.
 103         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 104         * python/py-framefilter.c (enumerate_args): Pass down
 105         USER_FRAME_PRINT_OPTIONS.
 106         * stack.c: Include "cli/cli-option.h".
 107         (print_frame_arguments_all, print_frame_arguments_scalars)
 108         (print_frame_arguments_none): Declare.
 109         (print_raw_frame_arguments, print_entry_values): Delete.
 110         (user_frame_print_options): New.
 111         (boolean_option_def, enum_option_def, frame_print_option_defs):
 112         New.
 113         (struct backtrace_cmd_options): New.
 114         (bt_flag_option_def): New.
 115         (backtrace_command_option_defs): New.
 116         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 117         (print_frame_arg, read_frame_arg, print_frame_args)
 118         (print_frame_info, print_frame): Add frame_print_options parameter
 119         and use it.
 120         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 121         (backtrace_command_1): Add frame_print_options and
 122         backtrace_cmd_options parameters and use them.
 123         (make_backtrace_options_def_group): New.
 124         (backtrace_command): Process command options with
 125         gdb::option::process_options.
 126         (backtrace_command_completer): New.
 127         (_initialize_stack): Extend "backtrace"'s help to mention
 128         supported options.  Install completer for "backtrace".
 129         Install some settings commands with add_setshow_cmds_for_options.
 130
 131 2019-06-13  Pedro Alves  <palves@redhat.com>
 132
 133         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 134         and that "set/show print raw frame-arguments" are now deprecated.
 135
 136         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 137         command.
 138         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 139         * stack.c (_initialize_stack): Install "set/show print
 140         raw-frame-arguments", and deprecate "set/show print raw
 141         frame-arguments".
 142         * valprint.c (_initialize_valprint): Deprecate "set/show print
 143         raw".
 144
 145 2019-06-13  Pedro Alves  <palves@redhat.com>
 146
 147         * compile/compile.c (struct compile_options): New.
 148         (compile_flag_option_def, compile_command_option_defs)
 149         (make_compile_options_def_group): New.
 150         (compile_file_command): Handle options with
 151         gdb::option::process_options.
 152         (compile_file_command_completer): New function.
 153         (compile_code_command): Handle options with
 154         gdb::option::process_options.
 155         (compile_code_command_completer): New function.
 156         (_initialize_compiler): Install completers for "compile code" and
 157         "compile file".  Mention available options in "compile code" and
 158         "compile code"'s help.
 159         * completer.c (advance_to_completion_word): New, factored out from
 160         ...
 161         (advance_to_expression_complete_word_point): ... this.
 162         (advance_to_filename_complete_word_point): New.
 163         * completer.h (advance_to_filename_complete_word_point): New
 164         declaration.
 165
 166 2019-06-13  Pedro Alves  <palves@redhat.com>
 167
 168         * compile/compile.c: Include "cli/cli-option.h".
 169         (compile_print_value): Scope data pointer is now a
 170         value_print_options pointer; adjust.
 171         (compile_print_command): Process options.  Scope data pointer is
 172         now a value_print_options pointer; adjust.
 173         (_initialize_compile): Update "compile print"'s help to include
 174         supported options.  Install a completer for "compile print".
 175         * cp-valprint.c (show_vtblprint, show_objectprint)
 176         (show_static_field_print): Delete.
 177         (_initialize_cp_valprint): Don't install "set print
 178         static-members", "set print vtbl", "set print object" here.
 179         * printcmd.c: Include "cli/cli-option.h" and
 180         "common/gdb_optional.h".
 181         (print_command_parse_format): Rework to fill in a
 182         value_print_options instead of a format_data.
 183         (print_value): Change parameter type from format_data pointer to
 184         value_print_options reference.  Adjust.
 185         (print_command_1): Process options.  Adjust to pass down a
 186         value_print_options.
 187         (print_command_completer): New.
 188         (_initialize_printcmd): Install print_command_completer as
 189         handle_brkchars completer for the "print" command.  Update
 190         "print"'s help to include supported options.
 191         * valprint.c: Include "cli/cli-option.h".
 192         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 193         here from cp-valprint.c.
 194         (boolean_option_def, uinteger_option_def)
 195         (value_print_option_defs, make_value_print_options_def_group):
 196         New.  Use gdb::option::add_setshow_cmds_for_options to install
 197         "set print elements", "set print null-stop", "set print repeats",
 198         "set print pretty", "set print union", "set print array", "set
 199         print address", "set print symbol", "set print array-indexes".
 200         * valprint.h: Include <string> and "cli/cli-option.h".
 201         (make_value_print_options_def_group): Declare.
 202         (print_value): Change parameter type from format_data pointer to
 203         value_print_options reference.
 204         (print_command_completer): Declare.
 205
 206 2019-06-13  Pedro Alves  <palves@redhat.com>
 207
 208         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 209         (COMMON_SFILES): Add maint-test-settings.c.
 210         * cli/cli-decode.c (boolean_enums): New global, factored out from
 211         ...
 212         (add_setshow_boolean_cmd): ... here.
 213         * cli/cli-decode.h (boolean_enums): Declare.
 214         * cli/cli-option.c: New file.
 215         * cli/cli-option.h: New file.
 216         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 217         factored out from ...
 218         (parse_cli_boolean_value(const char *)): ... this.
 219         (is_unlimited_literal): Change parameter type to pointer to
 220         pointer.  Adjust and advance ARG pointer.
 221         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 222         (parse_cli_var_enum): New, factored out from ...
 223         (do_set_command): ... this.  Adjust.
 224         * cli/cli-setshow.h (parse_cli_boolean_value)
 225         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 226         (parse_cli_var_enum): Declare.
 227         * cli/cli-utils.c: Include "cli/cli-option.h".
 228         (get_ulongest): New.
 229         * cli/cli-utils.h (get_ulongest): Declare.
 230         (check_for_argument): New overloads.
 231         * maint-test-options.c: New file.
 232
 233 2019-06-13  Pedro Alves  <palves@redhat.com>
 234
 235         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 236         parse a range if "-" is at the end of the string.
 237
 238 2019-06-13  Pedro Alves  <palves@redhat.com>
 239
 240         * cli/cli-setshow.c (parse_auto_binary_operation)
 241         (parse_cli_boolean_value): Don't allow "o".
 242
 243 2019-06-13  Pedro Alves  <palves@redhat.com>
 244
 245         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 246         * NEWS: Mention maint test-settings KIND.
 247         * maint-test-settings.c: New file.
 248
 249 2019-06-13  Pedro Alves  <palves@redhat.com>
 250
 251         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 252         completer.
 253         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 254         "set" completers.
 255
 256 2019-06-13  Pedro Alves  <palves@redhat.com>
 257
 258         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 259         after item.
 260
 261 2019-06-13  Pedro Alves  <palves@redhat.com>
 262
 263         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 264
 265 2019-06-13  Pedro Alves <palves@redhat.com>
 266
 267         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 268         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 269         call.
 270         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 271         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 272         calls.
 273         (check_for_argument): Skip spaces after argument.
 274
 275 2019-06-13  Pedro Alves  <palves@redhat.com>
 276
 277         * thread.c (thread_apply_command): Adjust TID parsing.
 278         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 279         detected before end of string.
 280         (tid_is_in_list): Error out if LIST is invalid.
 281
 282 2019-06-13  Pedro Alves  <palves@redhat.com>
 283
 284         * completer.c (complete_line_internal_1): Rewind completion word
 285         point.
 286         (completion_tracker::advance_custom_word_point_by): Change
 287         parameter type to int.
 288         * completer.h (completion_tracker::advance_custom_word_point_by):
 289         Likewise.
 290
 291 2019-06-13  Pedro Alves  <palves@redhat.com>
 292
 293         * completer.c (advance_to_completion_word): Handle delimiters.
 294
 295 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 296
 297         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 298
 299 2019-06-11  Tom Tromey  <tom@tromey.com>
 300
 301         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 302         (xmalloc_failed): Move to alloc.c.
 303         * alloc.c: New file.
 304         * Makefile.in (COMMON_SFILES): Add alloc.c.
 305
 306 2019-06-11  Tom Tromey  <tom@tromey.com>
 307
 308         * nat/linux-waitpid.c: Don't include server.h.
 309         (linux_debug): Remove.
 310         (my_waitpid): Update.
 311
 312 2019-06-11  Tom Tromey  <tromey@adacore.com>
 313
 314         * infcall.c (_initialize_infcall): Remove trailing newline from
 315         help.
 316         * user-regs.c (_initialize_user_regs): Remove trailing newline
 317         from help.
 318         * typeprint.c (_initialize_typeprint): Remove trailing newline
 319         from help.
 320         * reverse.c (_initialize_reverse): Remove trailing newlines from
 321         help.
 322         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 323         from help.
 324         * language.c (add_set_language_command): Remove trailing newline
 325         from help.
 326         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 327         help.
 328         * disasm.c (_initialize_disasm): Remove trailing newline from
 329         help.
 330         * top.c (init_main): Remove trailing newline from help.
 331         * interps.c (_initialize_interpreter): Remove trailing newline
 332         from help.
 333         * btrace.c (_initialize_btrace): Remove trailing newlines from
 334         help.
 335         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 336         from help.
 337         * python/python.c (_initialize_python): Remove trailing newline
 338         from help.
 339         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 340         help.
 341         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 342         from help.  Reformat some text.
 343         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 344         from help.
 345         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 346         newline from help.
 347
 348 2019-06-11  Tom Tromey  <tromey@adacore.com>
 349
 350         * darwin-nat.c (darwin_decode_exception_message)
 351         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 352
 353 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 354
 355         * valops.c (value_slice): Check for not allocated or not
 356         associated values.
 357
 358 2019-06-10  Tom de Vries  <tdevries@suse.de>
 359
 360         PR gdb/24618
 361         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 362         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 363         invalid.
 364
 365 2019-06-10  Tom de Vries  <tdevries@suse.de>
 366
 367         PR gdb/24611
 368         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 369         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 370
 371 2019-06-10  Tom de Vries  <tdevries@suse.de>
 372
 373         PR symtab/24545
 374         * symtab.c (struct demangled_name_entry): Add language field.
 375         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 376         static minimal symbol".  Set and use language field.
 377
 378 2019-06-10  Tom Tromey  <tromey@adacore.com>
 379
 380         * ada-lang.c (_initialize_ada_language): Update help text.
 381
 382 2019-06-10  Tom Tromey  <tromey@adacore.com>
 383
 384         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 385         with a newline.
 386         * guile/guile.c (handle_boot_error): Don't end warning with a
 387         newline.
 388         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 389         warning with a newline.
 390         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 391         newline.
 392         (s12z_frame_cache): Likewise.
 393         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 394         a newline.
 395         * solib-svr4.c (disable_probes_interface): Don't end warning with
 396         a newline.
 397         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 398         newline.
 399         * python/python.c (do_finish_initialization): Don't end warning
 400         with a newline.
 401
 402 2019-06-10  Tom Tromey  <tom@tromey.com>
 403
 404         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 405         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 406         gdbpy_enter.
 407
 408 2019-06-10  Tom Tromey  <tromey@adacore.com>
 409
 410         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 411         data.
 412         (elf_new_init): Don't call stabsread_new_init.
 413         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 414         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 415         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 416
 417 2019-06-10  Tom de Vries  <tdevries@suse.de>
 418
 419         PR symtab/16264
 420         PR symtab/24517
 421         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 422
 423 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 424
 425         * source.c (find_and_open_source): Also rewrite relative file
 426         names.
 427
 428 2019-04-26  Amos Bird  <amosbird@gmail.com>
 429
 430         * annotate.c (annotate_thread_exited): Add "thread-exited"
 431         annotation.
 432
 433 2019-06-06  Tom Tromey  <tromey@adacore.com>
 434
 435         * maint.h (class scoped_command_stats): Use
 436         DISABLE_COPY_AND_ASSIGN.
 437         <print_time>: New method.
 438         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 439         print_time.
 440         (scoped_command_stats::print_time): New method.
 441
 442 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 445         instructions of lengths 6 or 8 bytes.
 446
 447 2019-06-04  Pedro Alves  <palves@redhat.com>
 448
 449         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 450
 451         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 452         * breakpoint.c (condition_completer): Likewise.
 453         * cli/cli-dump.c (scan_expression): Likewise.
 454         * common/filestuff.c (mkdir_recursive): Likewise.
 455         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 456         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 457         (gdb_abspath): Likewise.
 458         * compile/compile-cplus-types.c
 459         (compile_cplus_instance::decl_name): Likewise.
 460         * completer.c (complete_explicit_location):
 461         (signal_completer, reg_or_group_completer_1): Likewise.
 462         * cp-support.c (cp_remove_params_if_any): Likewise.
 463         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 464         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 465         * infcmd.c (strip_bg_char): Likewise.
 466         * linespec.c (copy_token_string): Likewise.
 467         * mi/mi-main.c (output_cores): Likewise.
 468         * psymtab.c (psymtab_search_name):
 469         * symfile.c (test_set_ext_lang_command): Likewise.
 470         * target.c (target_fileio_read_stralloc): Likewise.
 471         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 472         * value.c (complete_internalvar): Likewise.
 473
 474 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 475
 476         Add objfile property to gdb.Type.
 477         * NEWS: Mention Python API addition.
 478         * python/py-type.c (typy_get_objfile): New method.
 479
 480 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 481
 482         * NEWS: Mention the new set|show style [title|highlight].
 483         Mention changes to "show style", "help" and "apropos".
 484
 485 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 486
 487         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 488         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 489         instead of print_help_for_command.
 490         (print_doc_of_command): New function.
 491         (help_list): Add 'apropos -v word' suggestion.
 492         (print_help_for_command): Style the command name using title style.
 493         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 494         (_initialize_cli_cmds): Describe -v in apropos_command help.
 495
 496 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 497
 498         * cli/cli-style.h (cli_style_option): Add name in constructor,
 499         add m_name class member, add constructor with intensity,
 500         add name class function.
 501         (cli_style_option::add_setshow_commands): Remove name argument.
 502         (highlight_style, title_style): New styles.
 503         * cli/cli-style.c (do_show): New function that shows a style
 504         characteristic styling the style name with itself.
 505         (set_style_name): New function.
 506         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 507         Update all callers according to the changes in cli/cli-style.h.
 508         * utils.h (fputs_highlighted): New function.
 509         * utils.c (fputs_highlighted): Likewise.
 510
 511 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 512
 513         * NEWS: Mention new pipe command and new convenience variables.
 514
 515 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 516
 517         * cli/cli-cmds.c (pipe_command): New function.
 518         (_initialize_cli_cmds): Call add_com for pipe_command.
 519         Define | as an alias for pipe.
 520         (exit_status_set_internal_vars): New function.
 521         (shell_escape): Call exit_status_set_internal_vars.
 522         cli/cli-decode.c (find_command_name_length): Recognize | as
 523         a single character command.
 524
 525 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 526
 527         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 528         top.c (execute_command_to_ui_file): New function, mostly a copy
 529         of execute_command_to_string.
 530         (execute_command_to_string): Implement by calling
 531         execute_command_to_ui_file.
 532
 533 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 534
 535         * top.h (saved_command_line): Remove declaration.
 536         * top.c (previous_saved_command_line, previous_repeat_arguments):
 537         New variables.
 538         (saved_command_line): Make static, define together with other
 539         'repeat variables'.
 540         (dont_repeat): Clear repeat_arguments.
 541         (repeat_previous, get_saved_command_line, save_command_line):
 542         New functions.
 543         (gdb_init): Initialize saved_command_line
 544         and previous_saved_command_line.
 545         * main.c (captured_main_1): Remove saved_command_line initialization.
 546         * event-top.c (handle_line_of_input): Update to use
 547         the new 'repeat' related functions instead of direct access to
 548         saved_command_line.
 549         * command.h (repeat_previous, get_saved_command_line,
 550         save_command_line): New declarations.
 551         (dont_repeat): Add comment.
 552
 553 2019-05-30  Tom Tromey  <tromey@adacore.com>
 554
 555         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 556         Fix comment.
 557         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 558
 559 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 560
 561         PR cli/24587
 562         * completer.c (complete): Initialize variable word.
 563
 564 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 565
 566         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 567         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 568         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 569         'body' is NULL to the outter 'if', protecting the '!is_define'
 570         situation as well.
 571
 572 2019-05-29  Tom Tromey  <tromey@adacore.com>
 573
 574         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 575         (dwarf_unknown): New function.
 576         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 577         (dwarf_type_encoding_name): Use dwarf_unknown.
 578
 579 2019-05-29  Tom Tromey  <tromey@adacore.com>
 580
 581         PR c++/20020:
 582         * cp-valprint.c (cp_print_value_fields): Call
 583         cp_print_static_field inside "try".
 584
 585 2019-05-29  Tom Tromey  <tromey@adacore.com>
 586
 587         * inflow.c (struct terminal_info): Add default operator=.
 588         * configure: Rebuild.
 589         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 590         -Wdeprecated-copy-dtor, -Wredundant-move.
 591
 592 2019-05-29  Tom Tromey  <tromey@adacore.com>
 593
 594         * NEWS: Add entry.
 595         * infcmd.c (print_return_value_1): Handle finish_print
 596         option.
 597         (show_print_finish): New function.
 598         (_initialize_infcmd): Add "set/show print finish" commands.
 599         * valprint.c (user_print_options): Initialize new member.
 600         * valprint.h (struct value_print_options) <finish_print>: New
 601         member.
 602
 603 2019-05-28  Tom Tromey  <tromey@adacore.com>
 604
 605         * ada-lang.c (ada_remove_Xbn_suffix)
 606         (find_old_style_renaming_symbol)
 607         (parse_old_style_renaming): Remove.
 608         (ada_find_renaming_symbol): Don't call
 609         find_old_style_renaming_symbol.
 610         (ada_is_renaming_symbol): Rename from
 611         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 612         bool.  Now static.
 613         (ada_read_var_value): Update and simplify.
 614         * ada-exp.y (write_var_or_type): Remove old code.
 615
 616 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 617
 618         * event-top.c: Remove include comment.
 619         * inflow.c (class scoped_ignore_sigttou): Move from here...
 620         * inflow.h (class scoped_ignore_sigttou): ...to here.
 621         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 622         * top.c:  Remove include comment.
 623
 624 2019-05-27  Tom Tromey  <tom@tromey.com>
 625
 626         * NEWS: Fix typo.
 627
 628 2019-05-22  Tom Tromey  <tromey@adacore.com>
 629
 630         * target.c (target_follow_exec): Constify parameter.
 631         * target-delegates.c: Rebuild.
 632         * remote.c (remote_target::follow_exec): Constify parameter.
 633         * infrun.c (follow_exec): Constify parameter.
 634         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 635         (target_follow_exec): Likewise.
 636
 637 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 638
 639         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 640         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 641
 642 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 643
 644         * NEWS: Add debugredirect and testsuite sections.
 645
 646 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 647
 648         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 649         target descriptions using exclusively floating point register name
 650         aliases.
 651
 652 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         PR gdb/18644:
 655         * f-lang.c (build_fortran_types): Handle the case where
 656         gdbarch_floatformat_for_type returns a nullptr.
 657
 658 2019-05-21  Tom de Vries  <tdevries@suse.de>
 659
 660         PR cli/24587
 661         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 662
 663 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         PR gdb/18644:
 666         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 667         16-byte floats.
 668         * i386-tdep.c (i386_floatformat_for_type): Use
 669         floatformats_ia64_quad for the 16-byte floating point component
 670         within a fortran 32-byte complex number.
 671
 672 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 675         delete default constructor.
 676         (find_partial_die): Update to return const struct.
 677         (partial_die_parent_scope): Move variable declaration into scope
 678         of its use and change its type to auto.
 679         (guess_partial_die_structure_name): Likewise.
 680         (partial_die_info::fixup): Likewise.
 681
 682 2019-05-17  Tom Tromey  <tromey@adacore.com>
 683
 684         * source.c (find_and_open_source): Remove cast.
 685
 686 2019-05-17  Tom Tromey  <tromey@adacore.com>
 687
 688         * annotate.c (annotate_source): Make "filename" const.
 689         * annotate.h (annotate_source): Use const.
 690
 691 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 692
 693         * disasm.c (set_disassembler_options): Send errors to stderr.
 694
 695 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 696
 697         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 698         (cli_interp_base::set_logging): Check debug_redirect.
 699         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 700         * cli/cli-logging.c (debug_redirect): Add static variable.
 701         (pop_output_files): Add default param.
 702         (handle_redirections): Print debug setting.
 703         (show_logging_command): Likewise.
 704         (_initialize_cli_logging): Add debugredirect command.
 705         * interps.c (current_interp_set_logging): Add debug_redirect
 706         parameter.
 707         * interps.h (set_logging): Add debug_redirect parameter.
 708         (current_interp_set_logging): Likewise.
 709         * mi/mi-common.h: Likewise.
 710         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 711
 712 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 713             Tom Tromey  <tromey@adacore.com>
 714
 715         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 716         directly.
 717         * cli/cli-interp.h (make_logging_output): Remove declaration.
 718         * cli/cli-logging.c (make_logging_output): Remove function.
 719         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 720         directly.
 721         * ui-file.c (tee_file::tee_file): Remove bools.
 722         (tee_file::~tee_file): Remove deletes.
 723         * ui-file.h (tee_file): Remove bools.
 724
 725 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 726
 727         * mi/mi-cmds.h (mi_cmd_complete): New function.
 728         * mi/mi-main.c (mi_cmd_complete): Likewise.
 729         * mi/mi-cmds.c: Define new MI command -complete.
 730         * NEWS: Mention new -complete command.
 731
 732 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 733
 734         * completer.h (complete): New function.
 735         * completer.c (complete): Likewise.
 736         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 737         function defined in completer.h.
 738
 739 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 740
 741        * MAINTAINERS (Write After Approval): Add myself.
 742
 743 2019-05-17  Tom de Vries  <tdevries@suse.de>
 744
 745         PR gdb/24094
 746         * dwarf2read.c (struct cu_partial_die_info): New struct.
 747         (find_partial_die): Return cu_partial_die_info.
 748         (partial_die_parent_scope, guess_partial_die_structure_name)
 749         (partial_die_info::fixup): Handle new return type of find_partial_die.
 750
 751 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 752
 753         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 754         "std::string", simplifying the algorithm.
 755
 756 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 757
 758         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 759         (stap_static_probe_ops::get_probes): Likewise.
 760
 761 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 762
 763         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 764         '-')" and "else if".
 765         (stap_parse_single_operand): Join checks for
 766         "gdbarch_stap_parse_special_token_p" and
 767         "gdbarch_stap_parse_special_token" in the same "if" statement.
 768         Invert check when verifying for operation on register
 769         displacement.
 770
 771 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 772
 773         * stap-probe.c (stap_get_opcode): Update comment.
 774         (stap_get_expected_argument_type): Likewise.
 775         (handle_stap_probe): Likewise.
 776
 777 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 778
 779         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 780         return type to 'bool'.  Adjust comment.  Use 'bool' when
 781         appropriate.
 782         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 783         * stap-probe.c (stap_parse_argument_1): Likewise.
 784         (stap_is_operator): Likewise.
 785         (stap_is_generic_prefix): Likewise.
 786         (stap_is_register_prefix): Likewise.
 787         (stap_is_register_indirection_prefix): Likewise.
 788         (stap_is_integer_prefix): Likewise.
 789         (stap_generic_check_suffix): Likewise.
 790         (stap_check_integer_suffix): Likewise.
 791         (stap_check_register_suffix): Likewise.
 792         (stap_check_register_indirection_suffix): Likewise.
 793         (stap_parse_register_operand): Likewise.
 794         (stap_parse_single_operand): Likewise.
 795         (stap_parse_argument_1): Likewise.
 796         (stap_probe::get_argument_count): Likewise.
 797         (stap_is_operator): Likewise.
 798
 799 2019-05-16  Tom Tromey  <tromey@adacore.com>
 800
 801         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 802         keyword to foreach.
 803
 804 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 805
 806         * linux-thread-db.c (try_thread_db_load_1): Change return type
 807         to bool.
 808         (try_thread_db_load): Likewise.
 809         (try_thread_db_load_from_pdir_1): Likewise.
 810         (try_thread_db_load_from_pdir): Likewise.
 811         (try_thread_db_load_from_sdir): Likewise.
 812         (try_thread_db_load_from_dir): Likewise.
 813         (thread_db_load_search): Likewise.
 814         (has_libpthread): Likewise.
 815         (thread_db_load): Likewise.
 816
 817 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 818
 819         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 820         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 821         NULL, and complain/return if that's the case.
 822
 823 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 824
 825         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 826         (advance, posn, abstract_read_memory): New functions.
 827         [struct mem_read_abstraction]: New struct.
 828         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 829
 830 2019-05-14  Tom Tromey  <tromey@adacore.com>
 831
 832         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 833         value is not lval_memory.
 834
 835 2019-05-14  Tom Tromey  <tromey@adacore.com>
 836
 837         * solib.c (info_sharedlibrary_command): Style the file name.
 838
 839 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 840
 841         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 842         (aarch64_vnv_type): Likewise.
 843         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 844         * common/tdesc.c: Likewise.
 845         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 846         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 847         * features/aarch64-fpu.xml: Add ieee half view.
 848         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 849         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 850         * gdbtypes.h (struct builtin_type): Likewise.
 851         (struct objfile_type): Likewise.
 852
 853 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 854
 855         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 856         typo.
 857         * location.h (string_to_event_location): Likewise.
 858
 859 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 860
 861         GDB 8.3 released.
 862
 863 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 864
 865         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 866         New variable declaration.
 867         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 868         New variable.
 869         (print_one_breakpoint): Use ui_out::test_flags and new global
 870         variable to compute use_fixed_output.
 871         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 872         Remove.
 873         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 874         (mi_multi_location_breakpoint_output_fixed): Remove.
 875         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 876         new variable.
 877         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 878         fix_multi_location_breakpoint_output flag if version >= 3.
 879         * ui-out.h (enum ui_out_flag)
 880         <fix_multi_location_breakpoint_output>: New enumerator.
 881
 882 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 885
 886 2019-05-10  Tom Tromey  <tromey@adacore.com>
 887
 888         * ada-lang.c (catch_ada_completer): New function.
 889         (_initialize_ada_language): Use it.
 890
 891 2019-05-10  Tom Tromey  <tromey@adacore.com>
 892
 893         * thread.c (print_thread_info): Make "requested_threads" const.
 894         * gdbthread.h (print_thread_info): Make "requested_threads"
 895         const.
 896         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 897         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 898
 899 2019-05-08  Tom Tromey  <tom@tromey.com>
 900
 901         * gdbtypes.c (objfile_type_data): Change type.
 902         (objfile_type, _initialize_gdbtypes): Update.
 903
 904 2019-05-08  Tom Tromey  <tom@tromey.com>
 905
 906         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 907         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 908         (_initialize_dwarf2_frame): Update.
 909
 910 2019-05-08  Tom Tromey  <tom@tromey.com>
 911
 912         * objc-lang.c (objc_objfile_data): Change type.
 913         (find_methods): Update.
 914         (_initialize_objc_lang): Remove.
 915
 916 2019-05-08  Tom Tromey  <tom@tromey.com>
 917
 918         * stabsread.c (rs6000_builtin_type_data): Change type.
 919         (rs6000_builtin_type, _initialize_stabsread): Update.
 920
 921 2019-05-08  Tom Tromey  <tom@tromey.com>
 922
 923         * mips-tdep.c (mips_pdr_data): Remove.
 924         (_initialize_mips_tdep): Update.
 925
 926 2019-05-08  Tom Tromey  <tom@tromey.com>
 927
 928         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 929         (hppa_init_objfile_priv_data, read_unwind_info)
 930         (find_unwind_entry, _initialize_hppa_tdep): Update.
 931
 932 2019-05-08  Tom Tromey  <tom@tromey.com>
 933
 934         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 935         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 936         on obstack.
 937         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 938
 939 2019-05-08  Tom Tromey  <tom@tromey.com>
 940
 941         * mdebugread.c (basic_type_data): Change type.
 942         (basic_type, _initialize_mdebugread): Update.
 943
 944 2019-05-08  Tom Tromey  <tom@tromey.com>
 945
 946         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 947
 948 2019-05-08  Tom Tromey  <tom@tromey.com>
 949
 950         * nto-tdep.c (nto_inferior_data_reg): Change type.
 951         (nto_inferior_data): Update.
 952         (nto_inferior_data_cleanup, nto_new_inferior_data)
 953         (_initialize_nto_tdep): Remove.
 954         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 955
 956 2019-05-08  Tom Tromey  <tom@tromey.com>
 957
 958         * ada-lang.c (struct ada_inferior_data): Add initializers.
 959         (ada_inferior_data): Change type.
 960         (ada_inferior_data_cleanup): Remove.
 961         (get_ada_inferior_data, ada_inferior_exit)
 962         (struct ada_pspace_data): Add initializers, destructor.
 963         (ada_pspace_data_handle): Change type.
 964         (get_ada_pspace_data): Update.
 965         (ada_pspace_data_cleanup): Remove.
 966
 967 2019-05-08  Tom Tromey  <tom@tromey.com>
 968
 969         * coffread.c (struct coff_symfile_info): Add initializers.
 970         (coff_objfile_data_key): Move lower.  Change type.
 971         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 972         Update.
 973         (coff_free_info): Remove.
 974
 975 2019-05-08  Tom Tromey  <tom@tromey.com>
 976
 977         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 978         (fbsd_pspace_data_handle): Move lower.  Change type.
 979         (get_fbsd_pspace_data): Update.
 980         (fbsd_pspace_data_cleanup): Remove.
 981         (_initialize_fbsd_tdep): Update.
 982
 983 2019-05-08  Tom Tromey  <tom@tromey.com>
 984
 985         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 986         (get_ada_tasks_pspace_data): Update.
 987         (ada_tasks_pspace_data_cleanup): Remove.
 988         (_initialize_tasks): Update.
 989         (ada_tasks_inferior_data_handle): Change type.
 990         (get_ada_tasks_inferior_data): Update.
 991         (ada_tasks_inferior_data_cleanup): Remove.
 992         (struct ada_tasks_pspace_data): Add initializers.
 993
 994 2019-05-08  Tom Tromey  <tom@tromey.com>
 995
 996         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 997         * symfile-debug.c (debug_sym_get_probes): Change type.
 998         * stap-probe.c (handle_stap_probe):
 999         (stap_static_probe_ops::get_probes): Change type.
1000         * probe.h (class static_probe_ops) <get_probes>: Change type.
1001         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1002         (parse_probes_in_pspace): Update.
1003         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1004         Update.
1005         (any_static_probe_ops::get_probes): Change type.
1006         * elfread.c (elfread_data): New typedef.
1007         (probe_key): Change type.
1008         (elf_get_probes): Likewise.  Update.
1009         (probe_key_free): Remove.
1010         (_initialize_elfread): Update.
1011         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1012         Change type.
1013         (dtrace_process_dof_probe, dtrace_process_dof)
1014         (dtrace_static_probe_ops::get_probe): Change type.
1015
1016 2019-05-08  Tom Tromey  <tom@tromey.com>
1017
1018         * xcoffread.c (struct xcoff_symfile_info): Rename from
1019         coff_symfile_info.  Add initializers.
1020         (xcoff_objfile_data_key): Move lower.  Change type.
1021         (XCOFF_DATA): Rewrite.
1022         (xcoff_free_info): Remove.
1023         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1024         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1025         (xcoff_initial_scan): Update.
1026
1027 2019-05-08  Tom Tromey  <tom@tromey.com>
1028
1029         * solib-svr4.c (struct svr4_info): Add initializers and
1030         destructor.
1031         <probes_table>: Now an htab_up.
1032         (solib_svr4_pspace_data): Change type.
1033         (free_probes_table): Simplify.
1034         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1035         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1036         (probes_table_remove_objfile_probes, register_solib_event_probe)
1037         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1038         (_initialize_svr4_solib): Update.
1039
1040 2019-05-08  Tom Tromey  <tom@tromey.com>
1041
1042         * remote.c (remote_pspace_data): Change type.
1043         (remote_pspace_data_cleanup): Remove.
1044         (get_remote_exec_file, set_pspace_remote_exec_file)
1045         (_initialize_remote): Update.
1046
1047 2019-05-08  Tom Tromey  <tom@tromey.com>
1048
1049         * breakpoint.c (breakpoint_objfile_key): Change type.
1050         (get_breakpoint_objfile_data): Update.
1051         (free_breakpoint_objfile_data): Remove.
1052         (_initialize_breakpoint): Update.
1053
1054 2019-05-08  Tom Tromey  <tom@tromey.com>
1055
1056         * linux-tdep.c (struct linux_info): Add initializers.
1057         (linux_inferior_data): Move.  Change type.
1058         (invalidate_linux_cache_inf): Update.
1059         (linux_inferior_data_cleanup): Remove.
1060         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1061
1062 2019-05-08  Tom Tromey  <tom@tromey.com>
1063
1064         * auxv.c (auxv_inferior_data): Move.  Change type.
1065         (auxv_inferior_data_cleanup): Remove.
1066         (invalidate_auxv_cache_inf): Rewrite.
1067         (get_auxv_inferior_data, _initialize_auxv): Update.
1068
1069 2019-05-08  Tom Tromey  <tom@tromey.com>
1070
1071         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1072         (symfile_debug_objfile_data_key): Change type.
1073         (symfile_debug_installed, debug_qf_has_symbols)
1074         (debug_qf_find_last_source_symtab)
1075         (debug_qf_forget_cached_source_info)
1076         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1077         (debug_qf_print_stats, debug_qf_dump)
1078         (debug_qf_expand_symtabs_for_function)
1079         (debug_qf_expand_all_symtabs)
1080         (debug_qf_expand_symtabs_with_fullname)
1081         (debug_qf_map_matching_symbols)
1082         (debug_qf_expand_symtabs_matching)
1083         (debug_qf_find_pc_sect_compunit_symtab)
1084         (debug_qf_map_symbol_filenames)
1085         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1086         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1087         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1088         (debug_sym_read_linetable, debug_sym_relocate): Update.
1089         (symfile_debug_free_objfile): Remove.
1090         (install_symfile_debug_logging, _initialize_symfile_debug):
1091         Update.
1092
1093 2019-05-08  Tom Tromey  <tom@tromey.com>
1094
1095         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1096         allocate_on_obstack.
1097         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1098         (get_dwarf2_per_objfile): Update.
1099         (set_dwarf2_per_objfile): Remove.
1100         (dwarf2_has_info, dwarf2_get_section_info): Update.
1101         (dwarf2_free_objfile): Remove.
1102         (_initialize_dwarf2_read): Update.
1103
1104 2019-05-08  Tom Tromey  <tom@tromey.com>
1105
1106         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1107         initializers.
1108         <unsupported_script_warning_printed,
1109         script_not_found_warning_printed>: Now bool.
1110         (auto_load_pspace_data): Change type.
1111         (~auto_load_pspace_info): Rename from
1112         auto_load_pspace_data_cleanup.
1113         (get_auto_load_pspace_data, init_loaded_scripts_info)
1114         (clear_section_scripts, maybe_print_unsupported_script_warning)
1115         (maybe_print_script_not_found_warning, _initialize_auto_load):
1116         Update.
1117
1118 2019-05-08  Tom Tromey  <tom@tromey.com>
1119
1120         * objfiles.c (objfile_pspace_info): Add destructor and
1121         initializers.
1122         (objfiles_pspace_data): Change type.
1123         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1124         (get_objfile_pspace_data): Update.
1125         (objfiles_bfd_data): Change type.
1126         (get_objfile_bfd_data): Update.
1127         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1128
1129 2019-05-08  Tom Tromey  <tom@tromey.com>
1130
1131         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1132         Change type.
1133         (get_catch_syscall_inferior_data): Update.
1134         (catch_syscall_inferior_data_cleanup): Remove.
1135         (_initialize_break_catch_syscall): Update.
1136
1137 2019-05-08  Tom Tromey  <tom@tromey.com>
1138
1139         * inflow.c (struct terminal_info): Add destructor and
1140         initializers.
1141         (inflow_inferior_data): Change type.
1142         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1143         (get_inflow_inferior_data, inflow_inferior_exit)
1144         (swap_terminal_info, _initialize_inflow): Update.
1145
1146 2019-05-08  Tom Tromey  <tom@tromey.com>
1147
1148         * target-dcache.c (target_dcache_cleanup): Remove.
1149         (target_dcache_aspace_key): Change type.
1150         (target_dcache_init_p, target_dcache_invalidate)
1151         (target_dcache_get, target_dcache_get_or_init)
1152         (_initialize_target_dcache): Update.
1153         * dcache.h (struct dcache_deleter): New.
1154
1155 2019-05-08  Tom Tromey  <tom@tromey.com>
1156
1157         * symtab.c (struct symbol_cache): Add destructor and
1158         initializers.
1159         (symbol_cache_key): Move.  Change type.
1160         (make_symbol_cache, free_symbol_cache): Remove.
1161         (get_symbol_cache): Update.
1162         (symbol_cache_cleanup): Remove.
1163         (ALL_PSPACES, symbol_cache_flush)
1164         (maintenance_print_symbol_cache)
1165         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1166         Update.
1167
1168 2019-05-08  Tom Tromey  <tom@tromey.com>
1169
1170         * symtab.c (struct main_info): Add destructor and initializers.
1171         (main_progspace_key): Move.  Change type.
1172         (get_main_info): Update.
1173         (main_info_cleanup): Remove.
1174         (_initialize_symtab): Update.
1175
1176 2019-05-08  Tom Tromey  <tom@tromey.com>
1177
1178         * registry.h (DECLARE_REGISTRY): Define the _key class.
1179
1180 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * NEWS: Merge two 'New commands' sections.
1183
1184 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1185
1186         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1187         parameter and use Ada language definition instead.
1188         (ada_val_print_ptr): Remove unused language parameter.
1189         (ada_val_print_num): Remove language parameter and use Ada language
1190         definition instead.
1191         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1192         parameter.
1193         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1194         parameter and use Ada language definition instead.
1195         (ada_val_print_1): Update all ada_val_print_xxx calls.
1196         Remove language parameter.
1197         (ada_val_print): Update ada_val_print_1 call.
1198
1199 2019-05-08  Tom Tromey  <tromey@adacore.com>
1200
1201         * remote.c (remote_hw_watchpoint_limit)
1202         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1203         Now static.
1204
1205 2019-05-08  Tom Tromey  <tromey@adacore.com>
1206
1207         * maint.c (_initialize_maint_cmds): Move initialization code to
1208         remote.c.
1209         (watchdog, show_watchdog): Move to remote.c.
1210         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1211         "watchdog" static.
1212         (_initialize_remote): Move initialization code from maint.c.
1213         * defs.h (watchdog): Don't declare.
1214
1215 2019-05-08  Tom Tromey  <tromey@adacore.com>
1216
1217         * tui/tui-interp.c: Include main.h.
1218         * interps.c: Include main.h.
1219         * main.h (interpreter_p): Declare.
1220         * defs.h (interpreter_p): Don't declare.
1221
1222 2019-05-08  Tom Tromey  <tromey@adacore.com>
1223
1224         * dwarf2loc.c: Include dwarf2read.h.
1225         * defs.h (read_unsigned_leb128): Don't declare.
1226         * dwarf2read.h (read_unsigned_leb128): Declare.
1227
1228 2019-05-08  Tom Tromey  <tromey@adacore.com>
1229
1230         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1231         method.
1232
1233 2019-05-08  Tom Tromey  <tromey@adacore.com>
1234
1235         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1236         when no wrap column is set.
1237
1238 2019-05-08  Tom Tromey  <tromey@adacore.com>
1239
1240         * c-lang.c (c_get_string): Handle non-C-style arrays.
1241
1242 2019-05-08  Tom Tromey  <tromey@adacore.com>
1243
1244         * typeprint.c (print_offset_data::update): Print the bit offset,
1245         not the number of bits remaining.
1246
1247 2019-05-08  Tom Tromey  <tromey@adacore.com>
1248
1249         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1250         padding at end of comment.
1251
1252 2019-05-08  Tom Tromey  <tromey@adacore.com>
1253
1254         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1255         Compare main types.
1256
1257 2019-05-06  Tom Tromey  <tom@tromey.com>
1258
1259         * common/scoped_mmap.c: Include common-defs.h.
1260         * common/scoped_mmap.h: Don't include config.h.
1261
1262 2019-05-04  Tom Tromey  <tom@tromey.com>
1263
1264         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1265         (struct aarch64_call_info): Add initializers.
1266         <si>: Now a std::vector.
1267         (pass_on_stack, aarch64_push_dummy_call): Update.
1268
1269 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1270             Tom Tromey  <tom@tromey.com>
1271
1272         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1273         (ppc_threads): Now a std::vector.  Now static.
1274         (hwdebug_find_thread_points_by_tid)
1275         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1276         Update.
1277
1278 2019-05-04  Tom Tromey  <tom@tromey.com>
1279
1280         * arc-tdep.c (arc_tdesc_init): Return bool.
1281
1282 2019-05-04  Tom Tromey  <tom@tromey.com>
1283
1284         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1285         Use gdb_assert_not_reached.
1286
1287 2019-05-04  Tom Tromey  <tom@tromey.com>
1288
1289         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1290         "false".
1291
1292 2019-05-04  Tom Tromey  <tom@tromey.com>
1293
1294         * arc-tdep.c (arc_tdesc_init): Use bool.
1295
1296 2019-05-04  Tom Tromey  <tom@tromey.com>
1297
1298         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1299
1300 2019-05-04  Tom Tromey  <tom@tromey.com>
1301
1302         * cli/cli-cmds.c (valid_command_p): Return bool.
1303
1304 2019-05-04  Tom Tromey  <tom@tromey.com>
1305
1306         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1307         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1308
1309 2019-05-04  Raul Tambre  <raul@tambre.ee>
1310
1311         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1312         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1313         operator for comparison.
1314
1315 2019-05-04  Tom Tromey  <tom@tromey.com>
1316
1317         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1318         (lookup_partial_symbol, print_partial_symbols)
1319         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1320         (psymbol_compare): Update.
1321         (add_psymbol_to_bcache): Clear the entire psymbol.
1322         (maintenance_check_psymtabs): Update.
1323         * psympriv.h (struct partial_symbol): Don't derive from
1324         general_symbol_info.
1325         <obj_section, unrelocated_address, address,
1326         set_unrelocated_address>: Update.
1327         <ginfo>: New member.
1328         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1329         (debug_names::write_psymbols): Update.
1330
1331 2019-05-04  Tom de Vries  <tdevries@suse.de>
1332
1333         * contrib/cc-with-tweaks.sh: Support -n arg.
1334
1335 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1336
1337         * corelow.c (core_target::detach): Ensure frame cache and
1338         register caches are cleared.
1339         inferior.c (exit_inferior_1): Likewise.
1340
1341 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1342             Tom Tromey  <tom@tromey.com>
1343
1344         * dictionary.c (collate_pending_symbols_by_language): Remove
1345         "struct" from foreach.
1346         * symtab.c (lookup_global_symbol_from_objfile)
1347         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1348         foreach.
1349         * ser-tcp.c (net_open): Remove "struct" from foreach.
1350         * objfiles.c (objfile_relocate, objfile_rebase)
1351         (objfile_has_symbols): Remove "struct" from foreach.
1352         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1353         from foreach.
1354         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1355         foreach.
1356         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1357         "struct" from foreach.
1358         * ada-lang.c (create_excep_cond_exprs)
1359         (ada_exception_catchpoint_cond_string): Remove "struct" from
1360         foreach.
1361
1362 2019-05-03  Tom Tromey  <tromey@adacore.com>
1363
1364         * ada-exp.y (convert_char_literal): Check suffix of each
1365         enumerator.
1366
1367 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1368
1369         PR ada/21406:
1370         * ada-exp.y (yywrap): Don't define.
1371         * ada-lex.l (%option): Add noyywrap
1372         (yywrap): Remove.
1373
1374 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1375
1376         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1377         _WIN32_WINNT to the XP level, unless already defined to a higher
1378         level.
1379
1380         * unittests/parse-connection-spec-selftests.c:
1381         * ser-tcp.c:
1382         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1383         override.
1384
1385         * symfile.c (find_separate_debug_file): Remove colon from the
1386         drive spec of DOS/Windows file names of the target, so that the
1387         file name produced from DEBUGDIR and the target's directory will
1388         be valid on DOS/Windows systems.
1389
1390 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * rust-lang.c (val_print_struct): Handle printing structures
1393         containing strings.
1394
1395 2019-05-02  Tom Tromey  <tromey@adacore.com>
1396
1397         * valarith.c (_initialize_valarith): Remove.
1398
1399 2019-05-01  Tom Tromey  <tromey@adacore.com>
1400
1401         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1402         bitfields.
1403
1404 2019-05-01  Tom Tromey  <tromey@adacore.com>
1405
1406         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1407         for big-endian copies.
1408
1409 2019-04-30  Ali Tamur  <tamur@google.com>
1410         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1411         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1412         (read_3_bytes): New function.
1413
1414 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1415
1416         * windows-nat.c (main_thread_id): Delete.
1417         (handle_output_debug_string): Replace main_thread_id by
1418         current_event.dwThreadId.
1419         (fake_create_process): Likewise.
1420         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1421         Do not set main_thread_id.
1422         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1423         current_event.dwThreadId.
1424         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1425
1426 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1427
1428         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1429         Use current_event.dwThreadId instead of main_thread_id.
1430
1431 2019-04-30  Tom Tromey  <tromey@adacore.com>
1432
1433         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1434         (create_excep_cond_exprs): Iterate over program spaces.
1435         (ada_exception_catchpoint_cond_string): Examine all minimal
1436         symbols for exception types.
1437
1438 2019-04-30  Tom Tromey  <tromey@adacore.com>
1439
1440         PR c++/24470:
1441         * dwarf2read.c (process_structure_scope): Handle case where type
1442         has template parameters but no symbol was created.
1443
1444 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1445             Chris January  <chris.january@arm.com>
1446
1447         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1448         qualifier.
1449         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1450
1451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * f-typeprint.c (f_print_type): Update rules for printing
1454         whitespace.
1455         (f_type_print_varspec_suffix): Likewise.
1456
1457 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1458             Chris January  <chris.january@arm.com>
1459
1460         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1461         function arguments.
1462
1463 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1464
1465         * f-lang.c (build_fortran_types): Change name of void type to
1466         lower case.
1467         * f-typeprint.c (f_type_print_base): Print the name of the void
1468         type, rather than a fixed string.
1469         * f-valprint.c (f_decorations): Use lower case void string.
1470
1471 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1472             Chris January  <chris.january@arm.com>
1473
1474         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1475         types for Fortran.
1476
1477 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1478             Chris January  <chris.january@arm.com>
1479             David Lecomber  <david.lecomber@arm.com>
1480
1481         * f-exp.y (BINOP_INTRINSIC): New token.
1482         (exp): New parser rule handling BINOP_INTRINSIC.
1483         (f77_keywords): Add new builtin procedures.
1484         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1485         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1486         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1487         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1488         (print_unop_subexp_f): New function.
1489         (print_binop_subexp_f): New function.
1490         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1491         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1492         (dump_subexp_body_f): Likewise.
1493         (operator_check_f): Likewise.
1494         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1495         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1496
1497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1500         UNOP_KIND.
1501         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1502         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1503         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1504         (operator_length_f): New fuction.
1505         (print_subexp_f): New function.
1506         (op_name_f): New function.
1507         (dump_subexp_body_f): New function.
1508         (operator_check_f): New function.
1509         (exp_descriptor_f): Replace standard expression handling functions
1510         with new functions.
1511         * gdb/fortran-operator.def: New file.
1512         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1513         * gdb/std-operator.def: Remove UNOP_KIND.
1514
1515 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * std-operator.def: Remove unbalanced, stray double quote
1518         character.
1519
1520 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1521             Chris January  <chris.january@arm.com>
1522             Daniel Everett  <daniel.everett@arm.com>
1523             Nick Forrington  <nick.forrington@arm.com>
1524             Richard Bunt  <richard.bunt@arm.com>
1525
1526         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1527         of depth when printing anonymous structs or unions.
1528         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1529         Don't print either the top-level value, or the children if the
1530         max-depth is exceeded.
1531         (ppscm_print_children): When printing the key of a map, allow one
1532         extra level of depth.
1533         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1534         print either the top-level value, or the children if the max-depth
1535         is exceeded.
1536         (print_children): When printing the key of a map, allow one extra
1537         level of depth.
1538         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1539         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1540         (user_print_options): Initialise max_depth field.
1541         (val_print_scalar_or_string_type_p): New function.
1542         (val_print): Check to see if the max depth has been reached.
1543         (val_print_check_max_depth): Define new function.
1544         (show_print_max_depth): New function.
1545         (_initialize_valprint): Add 'print max-depth' option.
1546         * valprint.h (struct value_print_options) <max_depth>: New field.
1547         (val_print_check_max_depth): Declare new function.
1548         * NEWS: Document new feature.
1549
1550 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * ada-lang.c (ada_language_defn): Initialise new field.
1553         * c-lang.c (c_is_string_type_p): New function.
1554         (c_language_defn): Initialise new field.
1555         (cplus_language_defn): Initialise new field.
1556         (asm_language_defn): Initialise new field.
1557         (minimal_language_defn): Initialise new field.
1558         * c-lang.h (c_is_string_type_p): Declare new function.
1559         * d-lang.c (d_language_defn): Initialise new field.
1560         * f-lang.c (f_is_string_type_p): New function.
1561         (f_language_defn): Initialise new field.
1562         * go-lang.c (go_is_string_type_p): New function.
1563         (go_language_defn): Initialise new field.
1564         * language.c (default_is_string_type_p): New function.
1565         (unknown_language_defn): Initialise new field.
1566         (auto_language_defn): Initialise new field.
1567         * language.h (struct language_defn) <la_is_string_type_p>: New
1568         member variable.
1569         (default_is_string_type_p): Declare new function.
1570         * m2-lang.c (m2_language_defn): Initialise new field.
1571         * objc-lang.c (objc_language_defn): Initialise new field.
1572         * opencl-lang.c (opencl_language_defn): Initialise new field.
1573         * p-lang.c (pascal_is_string_type_p): New function.
1574         (pascal_language_defn): Initialise new field.
1575         * rust-lang.c (rust_is_string_type_p): New function.
1576         (rust_language_defn): Initialise new field.
1577
1578 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1581         New field.
1582         * ada-lang.c (ada_language_defn): Initialise new field.
1583         * c-lang.c (c_language_defn): Likewise.
1584         (cplus_language_defn): Likewise.
1585         (asm_language_defn): Likewise.
1586         (minimal_language_defn): Likewise.
1587         * d-lang.c (d_language_defn): Likewise.
1588         * f-lang.c (f_language_defn): Likewise.
1589         * go-lang.c (go_language_defn): Likewise.
1590         * language.c (unknown_language_defn): Likewise.
1591         (auto_language_defn): Likewise.
1592         * m2-lang.c (m2_language_defn): Likewise.
1593         * objc-lang.c (objc_language_defn): Likewise.
1594         * opencl-lang.c (opencl_language_defn): Likewise.
1595         * p-lang.c (pascal_language_defn): Likewise.
1596         * rust-lang.c (rust_language_defn): Likewise.
1597
1598 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         * ada-lang.c (ada_is_character_type): Change return type to bool.
1601         (ada_is_string_type): Likewise.
1602         * ada-lang.h (ada_is_character_type): Update declaration
1603         (ada_is_string_type): Likewise.
1604
1605 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1606
1607         Support style in 'frame|thread apply'
1608
1609         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1610         * record.c (record_start, record_stop): Update callers of
1611         execute_command_to_string with false.
1612         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1613         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1614         methods.
1615         (class string_file): New constructor with term_out parameter.
1616         Override methods term_out and can_emit_style_escape.  New member
1617         term_out.
1618         (class stdio_file): Override can_emit_style_escape.
1619         (class tee_file): Override term_out and can_emit_style_escape.
1620         * utils.h (can_emit_style_escape): Remove.
1621         * utils.c (can_emit_style_escape): Likewise.
1622         Update all callers of can_emit_style_escape (SOMESTREAM) to
1623         SOMESTREAM->can_emit_style_escape.
1624         * source-cache.c (source_cache::get_source_lines): Likewise.
1625         * stack.c (frame_apply_command_count): Call execute_command_to_string
1626         passing the term_out characteristic of the current gdb_stdout.
1627         * thread.c (thr_try_catch_cmd): Likewise.
1628         * top.c (execute_command_to_string): pass term_out parameter
1629         to construct the string_file for the command output.
1630         * ui-file.c (term_cli_styling): New function (most code moved
1631         from utils.c can_emit_style_escape).
1632         (string_file::string_file, string_file::can_emit_style_escape,
1633         stdio_file::can_emit_style_escape, tee_file::term_out,
1634         tee_file::can_emit_style_escape): New functions.
1635
1636 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1637
1638         * NEWS: Mention the new set|show may-call-functions.
1639         * infcall.c (may_call_functions_p): New variable.
1640         (show_may_call_functions_p): New function.
1641         (call_function_by_hand_dummy): Throws an error if not
1642         may-call-functions.
1643         (_initialize_infcall): Call add_setshow_boolean_cmd for
1644         may-call-functions.
1645
1646 2019-04-25  Keith Seitz  <keiths@redhat.com>
1647
1648         PR c++/24367
1649         * cp-support.c (inspect_type): Don't attempt substitutions
1650         of symbol with the same name.
1651
1652 2019-04-25  Tom Tromey  <tromey@adacore.com>
1653
1654         PR gdb/24475:
1655         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1656         static.
1657
1658 2019-04-25  Tom Tromey  <tromey@adacore.com>
1659
1660         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1661         rvalue reference.
1662         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1663         (gdb_xml_parser::parse): Use std::move.
1664         * python/python-internal.h (gdbpy_convert_exception): Take a const
1665         reference.
1666         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1667         std::move.
1668         * python/py-utils.c (gdbpy_convert_exception): Take a const
1669         reference.
1670         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1671         Use std::move.
1672         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1673         Use std::move.
1674         * mi/mi-main.c (mi_print_exception): Take a const reference.
1675         * main.c (handle_command_errors): Take a const reference.
1676         * linespec.c (parse_linespec): Use std::move.
1677         * infcall.c (run_inferior_call): Use std::move.
1678         (call_function_by_hand_dummy): Use std::move.
1679         * exec.c (try_open_exec_file): Use std::move.
1680         * exceptions.h (exception_print, exception_fprintf)
1681         (exception_print_same): Update.
1682         * exceptions.c (print_exception, exception_print)
1683         (exception_fprintf, exception_print_same): Change parameters to
1684         const reference.
1685         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1686         * common/new-op.c: Use std::move.
1687         * common/common-exceptions.h (struct gdb_exception): Add move
1688         constructor.
1689         (struct gdb_exception_error, struct gdb_exception_quit, struct
1690         gdb_quit_bad_alloc): Change constructor to move constructor.
1691         (throw_exception): Change parameter to rvalue reference.
1692         * common/common-exceptions.c (throw_exception): Take rvalue
1693         reference.
1694         * cli/cli-interp.c (safe_execute_command): Use std::move.
1695         * breakpoint.c (insert_bp_location, location_to_sals): Use
1696         std::move.
1697
1698 2019-04-25  Tom Tromey  <tromey@adacore.com>
1699
1700         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1701         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1702         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1703         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1704         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1705         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1706         guile/scm-value.c: Use unpack.
1707         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1708         gdbscm_gdb_exception.
1709         (gdbscm_throw_gdb_exception): Likewise.
1710         (struct gdbscm_gdb_exception): New.
1711         (unpack): New function.
1712         (gdbscm_wrap): Use unpack.
1713
1714 2019-04-25  Tom Tromey  <tromey@adacore.com>
1715
1716         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1717         (gdb_rl_callback_handler): Use std::move.
1718         * common/common-exceptions.h (struct gdb_exception): Add move
1719         assignment operator.
1720         (throw_exception_sjlj): Change "exception" to const reference.
1721         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1722         (throw_exception_sjlj): Change "exception" to const reference.
1723
1724 2019-04-25  Tom Tromey  <tromey@adacore.com>
1725
1726         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1727         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1728         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1729         Update.
1730         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1731         Update.
1732         * mi/mi-interp.c (mi_interp::exec): Update.
1733         * linespec.c (parse_linespec): Update.
1734         * infcall.c (run_inferior_call): Update.
1735         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1736         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1737         (gdbscm_lookup_global_symbol): Update.
1738         * guile/scm-param.c (gdbscm_parameter_value): Update.
1739         * guile/scm-frame.c (gdbscm_frame_read_register)
1740         (gdbscm_frame_read_var): Update.
1741         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1742         * exec.c (try_open_exec_file): Update.
1743         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1744         (gdb_rl_callback_handler): Update.
1745         * common/common-exceptions.h (exception_none): Don't declare.
1746         * common/common-exceptions.c (exception_none): Don't define.
1747         (struct catcher) <exception>: Update.
1748         * cli/cli-interp.c (safe_execute_command): Update.
1749         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1750
1751 2019-04-25  Ali Tamur  <tamur@google.com>
1752
1753         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1754         (read_attribute_value): Likewise.
1755         (dwarf2_read_addr_index): Update comment.
1756         (read_str_index): Add DW_FORM_strx.
1757         (dwarf2_string_attr): Likewise.
1758         (dwarf2_const_value_attr): Likewise.
1759         (dump_die_shallow): Likewise.
1760         (dwarf2_fetch_constant_bytes): Likewise.
1761         (skip_form_bytes): Likewise.
1762         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1763
1764 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1765
1766         PR corefiles/11608
1767         PR corefiles/18187
1768         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1769         OFFSET.  Verify if current mapping contains an ELF header.
1770         (linux_find_memory_regions_full): Adjust call to
1771         dump_mapping_p.
1772
1773 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1774             Kang Li <kanglictf@gmail.com>
1775
1776         PR gdb/21600
1777
1778         * dwarf2-frame.c (read_initial_length): Be consistent about using
1779         unsigned representation of length.
1780         (decode_frame_entry_1): Likewise.  Check for wraparound of
1781         end pointer as well as buffer overflow.
1782
1783 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1784
1785         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1786         "vq".
1787
1788 2019-04-24  Tom Tromey  <tromey@adacore.com>
1789
1790         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1791
1792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * s12z-tdep.c (s12z_unwind_pc): Delete.
1795         (s12z_unwind_sp): Delete.
1796         (s12z_gdbarch_init): Don't register deleted functions with
1797         gdbarch.
1798
1799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1800
1801         * rl78-tdep.c (rl78_unwind_sp): Delete.
1802         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1803
1804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1807         (xstormy16_unwind_pc): Delete.
1808         (xstormy16_dummy_id): Delete.
1809         (xstormy16_gdbarch_init): Don't register deleted functions with
1810         gdbarch.
1811
1812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * vax-tdep.c (vax_unwind_pc): Delete.
1815         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1816
1817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * v850-tdep.c (v850_unwind_sp): Delete.
1820         (v850_unwind_pc): Delete.
1821         (v850_dummy_id): Delete.
1822         (v850_gdbarch_init): Don't register deleted functions with
1823         gdbarch.
1824
1825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1828         (tilegx_unwind_pc): Delete.
1829         (tilegx_unwind_dummy_id): Delete.
1830         (tilegx_gdbarch_init): Don't register deleted functions with
1831         gdbarch.
1832
1833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1834
1835         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1836         (tic6x_dummy_id): Delete.
1837         (tic6x_gdbarch_init): Don't register deleted functions with
1838         gdbarch.
1839
1840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * sparc-tdep.c (sparc_unwind_pc): Delete.
1843         (sparc32_gdbarch_init): Don't register deleted function with
1844         gdbarch.
1845
1846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * sh-tdep.c (sh_unwind_sp): Delete.
1849         (sh_unwind_pc): Delete.
1850         (sh_dummy_id): Delete.
1851         (sh_gdbarch_init): Don't register deleted functions with
1852         gdbarch.
1853
1854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * score-tdep.c (score_unwind_sp): Delete.
1857         (score_unwind_pc): Delete.
1858         (score_dummy_id): Delete.
1859         (score_gdbarch_init): Don't register deleted functions with
1860         gdbarch.
1861
1862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1863
1864         * rx-tdep.c (rx_unwind_pc): Delete.
1865         (rx_unwind_sp): Delete.
1866         (rx_dummy_id): Delete.
1867         (rx_gdbarch_init): Don't register deleted functions with
1868         gdbarch.  Update comment.
1869
1870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1871
1872         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1873         (rs6000_dummy_id): Delete.
1874         (rs6000_gdbarch_init): Don't register deleted functions with
1875         gdbarch.
1876
1877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * or1k-tdep.c (or1k_dummy_id): Delete.
1880         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1881
1882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * nios2-tdep.c (nios2_dummy_id): Delete.
1885         (nios2_unwind_sp): Delete.
1886         (nios2_gdbarch_init): Don't register deleted functions with
1887         gdbarch.
1888
1889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1890
1891         * nds32-tdep.c (nds32_dummy_id): Delete.
1892         (nds32_unwind_pc): Delete.
1893         (nds32_unwind_sp): Delete.
1894         (nds32_gdbarch_init): Don't register deleted functions with
1895         gdbarch.
1896
1897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * msp430-tdep.c (msp430_unwind_pc): Delete.
1900         (msp430_unwind_sp): Delete.
1901         (msp430_dummy_id): Delete.
1902         (msp430_gdbarch_init): Don't register deleted functions with
1903         gdbarch.
1904
1905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * moxie-tdep.c (moxie_unwind_sp): Delete.
1908         (moxie_unwind_pc): Delete.
1909         (moxie_dummy_id): Delete.
1910         (moxie_gdbarch_init): Don't register deleted functions with
1911         gdbarch.
1912
1913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1916         (mn10300_unwind_pc): Delete.
1917         (mn10300_unwind_sp): Delete.
1918         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1919         mn10300_unwind_sp.
1920         (mn10300_frame_unwind_init): Don't register deleted functions with
1921         gdbarch.
1922
1923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * mep-tdep.c (mep_unwind_pc): Delete.
1926         (mep_unwind_sp): Delete.
1927         (mep_dummy_id): Delete.
1928         (mep_gdbarch_init): Don't register deleted functions with
1929         gdbarch.
1930
1931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1934         (m68hc11_unwind_sp): Delete.
1935         (m68hc11_gdbarch_init): Don't register deleted functions with
1936         gdbarch.
1937
1938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * m32r-tdep.c (m32r_unwind_sp): Delete.
1941         (m32r_unwind_pc): Delete.
1942         (m32r_dummy_id): Delete.
1943         (m32r_gdbarch_init): Don't register deleted functions with
1944         gdbarch.
1945
1946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * m32c-tdep.c (m32c_unwind_pc): Delete.
1949         (m32c_unwind_sp): Delete.
1950         (m32c_dummy_id): Delete.
1951         (m32c_gdbarch_init): Don't register deleted functions with
1952         gdbarch.
1953
1954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1955
1956         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1957         (lm32_unwind_pc): Delete.
1958         (lm32_dummy_id): Delete.
1959         (lm32_gdbarch_init): Don't register deleted functions with
1960         gdbarch.
1961
1962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1965         (iq2000_unwind_pc): Delete.
1966         (iq2000_dummy_id): Delete.
1967         (iq2000_gdbarch_init): Don't register deleted functions with
1968         gdbarch.
1969
1970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * nds32-tdep.c (nds32_type_align): Delete.
1973         (nds32_push_dummy_call): Use type_align instead.
1974
1975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1976
1977         * arm-tdep.c (arm_type_align): Only handle vector override case.
1978         (arm_push_dummy_call): Use type_align.
1979         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1980
1981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1982
1983         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1984         case.
1985         (pass_on_stack): Use type_align.
1986         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1987         function.
1988
1989 2019-04-23  Tom Tromey  <tromey@adacore.com>
1990
1991         * dwarf2read.c (line_header::file_name_at): Remove unused
1992         overload.
1993
1994 2019-04-23  Tom de Vries  <tdevries@suse.de>
1995
1996         PR gdb/24438
1997         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1998         invocation.
1999
2000
2001 2019-03-27  Ali Tamur  <tamur@google.com>
2002
2003         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2004         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2005         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2006         (dwarf_expr_context::get_addr_index): Likewise
2007         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2008         (symbol_needs_eval_context::get_addr_index): Likewise
2009         (disassemble_dwarf_expression): Add DW_OP_addrx
2010         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2011         (read_cutu_die_from_dwo): Update comment
2012         (skip_one_die): Add DW_FORM_addrx
2013         (read_attribute_value): Likewise
2014         (var_decode_location): Add DW_OP_addrx
2015         (dwarf2_const_value_attr): Add DW_FORM_addrx
2016         (dump_die_shallow): Likewise
2017         (dwarf2_fetch_constant_bytes): Likewise
2018         (decode_locdesc): Add DW_OP_addrx
2019         (skip_form_bytes): Add DW_FORM_addrx
2020
2021 2019-04-22  Ali Tamur  <tamur@google.com>
2022
2023         * MAINTAINERS (Write After Approval): Add self.
2024
2025 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2026
2027         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2028         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2029         (open_symbol_file_object): Likewise.
2030         (svr4_default_sos): Add info parameter.
2031         (svr4_read_so_list): Likewise.
2032         (svr4_current_sos_direct): Adjust functions calls to pass down
2033         info.
2034         (svr4_current_sos_1): Add info parameter.
2035         (svr4_current_sos): Call get_svr4_info, pass info down to
2036         svr4_current_sos_1.
2037         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2038         get_svr4_info.
2039         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2040         get_svr4_info.
2041         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2042         to get_svr4_info.
2043         (probes_table_remove_objfile_probes): Likewise.
2044         (register_solib_event_probe): Add info parameter.
2045         (solist_update_incremental): Pass info parameter down to
2046         svr4_read_so_list.
2047         (disable_probes_interface): Add info parameter.
2048         (svr4_handle_solib_event): Pass current_program_space to
2049         get_svr4_info.  Adjust disable_probes_interface cleanup.
2050         (svr4_create_probe_breakpoints): Add info parameter, pass it
2051         down to register_solib_event_probe.
2052         (svr4_create_solib_event_breakpoints): Add info parameter,
2053         pass it down to svr4_create_probe_breakpoints.
2054         (enable_break): Pass info down to
2055         svr4_create_solib_event_breakpoints.
2056         (svr4_solib_create_inferior_hook): Pass current_program_space to
2057         get_svr4_info.
2058         (svr4_clear_solib): Likewise.
2059
2060 2019-04-22  Pedro Alves  <palves@redhat.com>
2061
2062         * solib-svr4.c (svr4_free_objfile_observer): New.
2063         (probe_and_action::objfile): New field.
2064         (probes_table_htab_remove_objfile_probes)
2065         (probes_table_remove_objfile_probes): New functions.
2066         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2067         in the new probe_and_action.  Don't store the probe in 'lookup'.
2068         (svr4_create_probe_breakpoints): Pass objfile to
2069         register_solib_event_probe.
2070         (_initialize_svr4_solib): Register a free_objfile observer.
2071
2072 2019-04-19  Tom Tromey  <tom@tromey.com>
2073
2074         * common/queue.h: Remove.
2075
2076 2019-04-19  Tom Tromey  <tom@tromey.com>
2077
2078         * event-loop.c: Don't include "common/queue.h".
2079
2080 2019-04-19  Tom Tromey  <tom@tromey.com>
2081
2082         * remote.c (remote_target): Use delete.
2083         * remote-notif.h: Include <list>, not "common/queue.h".
2084         (notif_client_p): Remove typedef.
2085         (remote_notif_state): Add constructor, destructor, initializer.
2086         <notif_queue>: Now a std::list.
2087         (remote_notif_state_xfree): Don't declare.
2088         * remote-notif.c (remote_notif_process, handle_notification)
2089         (remote_notif_state_allocate): Update.
2090         (~remote_notif_state): Rename from remote_notif_state_xfree.
2091
2092 2019-04-19  Tom Tromey  <tom@tromey.com>
2093
2094         * symfile.c (reread_symbols): Update.
2095         * objfiles.c (objfile_register_static_link)
2096         (objfile_lookup_static_link): Update
2097         (~objfile) Don't delete static_links.
2098         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2099
2100 2019-04-19  Tom Tromey  <tom@tromey.com>
2101
2102         * type-stack.h (struct type_stack) <insert>: Constify string.
2103         * type-stack.c (type_stack::insert): Constify string.
2104         * gdbtypes.h (lookup_template_type): Update.
2105         (address_space_name_to_int): Update.
2106         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2107         const.
2108         (lookup_template_type): Make name const.
2109         * c-exp.y: Update rules.
2110         (lex_one_token, classify_name, classify_inner_name)
2111         (c_print_token): Update.
2112         * p-exp.y: Update rules.
2113         (yylex): Update.
2114         * f-exp.y: Update rules.
2115         (yylex): Update.
2116         * d-exp.y: Update rules.
2117         (lex_one_token, classify_name, classify_inner_name): Update.
2118         * parse.c (write_dollar_variable, copy_name): Return std::string.
2119         * parser-defs.h (copy_name): Change return type.
2120         * m2-exp.y: Update rules.
2121         (yylex): Update.
2122         * go-exp.y (lex_one_token): Update.
2123         Update rules.
2124         (classify_unsafe_function, classify_packaged_name)
2125         (classify_name, yylex): Update.
2126
2127 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2128
2129         * configure.ac: add --enable-source-highlight switch.
2130         * configure: Regenerate.
2131         * top.c (print_gdb_version): plumb --enable-source-highlight
2132         status to "show configuration".
2133
2134 2019-04-19  Tom Tromey  <tromey@adacore.com>
2135
2136         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2137         Check ADA_TYPE_P.
2138         (empty_record, ada_template_to_fixed_record_type_1)
2139         (template_to_static_fixed_type)
2140         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2141         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2142         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2143         macros.
2144
2145 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2146
2147         PR symtab/24423:
2148         * source.c (print_source_lines_base): Advance "iter" when a
2149         control character is seen.
2150
2151 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2152
2153         * inferior.h (struct infcall_suspend_state_deleter):
2154         Catch exception in destructor to avoid crash.
2155
2156 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2157
2158         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2159         close to the add_com "shell".
2160
2161 2019-04-18  Tom Tromey  <tromey@adacore.com>
2162
2163         * process-stratum-target.h (class process_stratum_target)
2164         <stratum>: Add "final".
2165
2166 2019-04-17  Tom Tromey  <tromey@adacore.com>
2167
2168         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2169         against nullptr before use.
2170
2171 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2172
2173         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2174
2175 2019-04-17  Jim Wilson  <jimw@sifive.com>
2176             Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2179         code read might fail, assume 4-byte breakpoint in that case.
2180
2181 2019-04-15  Leszek Swirski  <leszeks@google.com>
2182
2183         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2184         rather than a hand-rolled POD check when checking for forced MEMORY
2185         classification.
2186
2187 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2188
2189         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2190         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2191         function.
2192         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2193         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2194         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2195         declaration.
2196
2197 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2198
2199         * aarch64-linux-nat.c
2200         (aarch64_linux_nat_target::thread_architecture): Add override.
2201         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2202         each VQ.
2203
2204 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2205
2206         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2207
2208 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2211         target types of size 96-bits, add some additional comments, and
2212         check that the builtin type we found was the correct size.
2213
2214 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2215
2216         * utils.c (prompt_for_continue): Don't restore the styling at the
2217         end, as applied_style has the wrong value.  This fixes styling in
2218         long lists of file names that are interrupted by the "Continue?"
2219         prompt.
2220
2221 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2224         * c-lang.c (c_language_defn): Likewise.
2225         (cplus_language_defn): Likewise.
2226         (asm_language_defn): Likewise.
2227         (minimal_language_defn): Likewise.
2228         * d-lang.c (d_language_defn): Likewise.
2229         * f-lang.c (f_language_defn): Likewise.
2230         * go-lang.c (go_language_defn): Likewise.
2231         * language.c (unknown_language_defn): Likewise.
2232         (auto_language_defn): Likewise.
2233         * language.h (struct language_defn): Remove la_magic field.
2234         (LANG_MAGIC): Delete.
2235         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2236         * objc-lang.c (objc_language_defn): Likewise.
2237         * opencl-lang.c (opencl_language_defn): Likewise.
2238         * p-lang.c (pascal_language_defn): Likewise.
2239         * rust-lang.c (rust_language_defn): Likewise.
2240
2241 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * riscv-tdep.c (riscv_type_align): New function.
2244         (riscv_type_alignment): Delete.
2245         (riscv_arg_location): Use 'type_align'.
2246         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2247
2248 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * gdbtypes.c (type_align): A struct with no non-static fields also
2251         has alignment of 1.
2252
2253 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2256         component to 0.
2257         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2258         member.
2259         (riscv_struct_info::analyse): New implementation using new
2260         analyse_inner member function.
2261         (riscv_struct_info::field_offset): New member function.
2262         (riscv_struct_info::m_offsets): New member variable.
2263         (riscv_struct_info::analyse_inner): New private member function,
2264         takes the old implementation of riscv_struct_info::analyse but
2265         extended to track field offsets.
2266         (riscv_call_arg_struct): Update the struct folding special cases
2267         to handle cases where empty C++ structs, which are non-zero
2268         length, are found.
2269         (riscv_arg_location): Initialise the length of each location, a
2270         non-zero length now indicates the location is in use.
2271         (riscv_push_dummy_call): Allow for the first location having a
2272         non-zero offset when setting up arguments.
2273         (riscv_return_value): Likewise, but for return values.
2274
2275 2019-04-11  Tom Tromey  <tromey@adacore.com>
2276
2277         * utils.c (internal_vproblem): Make "msg" const.
2278
2279 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2280
2281         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2282         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2283         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2284         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2285
2286 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2287
2288         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2289         function.
2290         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2291         of amd64_collect_native_gregset.
2292         (amd64_linux_nat_target::store_registers): Likewise.
2293
2294 2019-04-10  Tom Tromey  <tom@tromey.com>
2295
2296         * symtab.c (lookup_global_symbol_from_objfile)
2297         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2298         * objfiles.h (class separate_debug_iterator): New.
2299         (class separate_debug_range): New.
2300         (struct objfile) <separate_debug_objfiles>: New method.
2301         (objfile_separate_debug_iterate): Don't declare.
2302         * objfiles.c (separate_debug_iterator::operator++): Rename from
2303         objfile_separate_debug_iterate.
2304         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2305         iterator.
2306         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2307         iterator.
2308
2309 2019-04-10  Tom Tromey  <tom@tromey.com>
2310
2311         * symfile.c (reread_symbols): Remove old comment.
2312         * objfiles.c (free_all_objfiles): Fix a typo.
2313
2314 2019-04-10  Tom Tromey  <tom@tromey.com>
2315
2316         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2317         * minsyms.c (lookup_minimal_symbol): Use foreach.
2318         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2319         (lookup_minimal_symbol_solib_trampoline): Likewise.
2320         * symfile.c (reread_symbols): Use foreach.
2321
2322 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2323             Tom Tromey  <tromey@adacore.com>
2324
2325         PR rust/24414:
2326         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2327         (rust_lex_int_test): Change "value" to be LONGEST.
2328         (rust_lex_tests): Add test for long integer literal.
2329
2330 2019-04-09  Tom Tromey  <tromey@adacore.com>
2331
2332         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2333         to bool.
2334         (extended_remote_target::attach): Update.
2335         (remote_target::remote_notice_new_inferior): Update.
2336         (remote_target::add_current_inferior_and_thread): Update.
2337         * inferior.c (exit_inferior_1): Use "false".
2338         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2339
2340 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2341
2342         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2343         the "start" command.
2344
2345 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2346
2347         * python/py-inferior.c (infpy_thread_from_thread_handle):
2348         Adjust comments to reflect renaming of thread_from_thread_handle
2349         to thread_from_handle.  Adjust keywords.  Fix type error message.
2350         (inferior_object_methods): Add thread_from_handle.  Retain
2351         thread_from_thread_handle, but mark it as deprecated.
2352
2353 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2354
2355         * gdbthread.h (find_thread_by_handle): Revise declaration.
2356         * thread.c (find_thread_by_handle): Likewise.  Adjust
2357         implementation too.
2358         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2359         support for buffer objects as handles.
2360
2361 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2362
2363         * python/py-infthread.c (thpy_thread_handle): New function.
2364         (thread_object_methods): Register thpy_thread_handle.
2365
2366 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2367
2368         * gdbthread.h (thread_to_thread_handle): Declare.
2369         * thread.c (gdbtypes.h): Include.
2370         (thread_to_thread_handle): New function.
2371
2372         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2373         (target_thread_info_to_thread_handle): Declare.
2374         * target.c (target_thread_info_to_thread_handle): New function.
2375         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2376         * target-delegates.c: Regenerate.
2377
2378         * linux-thread-db.c (class thread_db_target): Add method
2379         thread_info_to_thread_handle.
2380         (thread_db_target::thread_info_to_thread_handle): Define.
2381         * remote.c (class remote_target): Add new method
2382         thread_info_to_thread_handle.
2383         (remote_target::thread_info_to_thread_handle): Define.
2384
2385 2019-04-08  Pedro Alves  <palves@redhat.com>
2386
2387         * common/common-exceptions.c (throw_exception): Don't create
2388         named object to throw; throw directly.
2389         (throw_it): Likewise.  Don't initialize gdb_exception::message
2390         here, with new; pass FMT and AP to the ctor instead.
2391         * common/common-exceptions.h: Include <string>.
2392         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2393         const char *, va_list)): New ctor.  Use std::make_shared.
2394         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2395         errors)): Delete.
2396         (gdb_exception_error::gdb_exception_error(enum errors, const char
2397         *, va_list)): New.
2398         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2399         Add assertion.
2400         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2401         errors)): Delete.
2402         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2403         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2404         Add assertion.
2405
2406 2019-04-08  Tom Tromey  <tom@tromey.com>
2407
2408         * valops.c (value_rtti_indirect_type): Replace throw_exception
2409         with throw.
2410         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2411         with throw.
2412         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2413         throw.
2414         * target.c (target_translate_tls_address): Replace throw_exception
2415         with throw.
2416         * stack.c (frame_apply_command_count): Replace throw_exception
2417         with throw.
2418         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2419         throw.
2420         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2421         with throw.
2422         * rs6000-tdep.c (rs6000_frame_cache)
2423         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2424         * remote.c: Replace throw_exception with throw.
2425         * record-full.c (record_full_message, record_full_wait_1)
2426         (record_full_restore): Replace throw_exception with throw.
2427         * record-btrace.c:
2428         (get_thread_current_frame_id, record_btrace_start_replaying)
2429         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2430         (cmd_record_btrace_start): Replace throw_exception with throw.
2431         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2432         throw.
2433         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2434         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2435         * linespec.c:
2436         (find_linespec_symbols): Replace throw_exception with throw.
2437         * infrun.c (displaced_step_prepare, resume): Replace
2438         throw_exception with throw.
2439         * infcmd.c (post_create_inferior): Replace throw_exception with
2440         throw.
2441         * inf-loop.c (inferior_event_handler): Replace throw_exception
2442         with throw.
2443         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2444         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2445         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2446         (get_prev_frame_always, get_frame_pc_if_available)
2447         (get_frame_address_in_block_if_available, get_frame_language):
2448         Replace throw_exception with throw.
2449         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2450         throw_exception with throw.
2451         * eval.c (fetch_subexp_value, evaluate_var_value)
2452         (evaluate_funcall, evaluate_subexp_standard): Replace
2453         throw_exception with throw.
2454         * dwarf2loc.c (call_site_find_chain)
2455         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2456         Replace throw_exception with throw.
2457         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2458         with throw.
2459         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2460         throw.
2461         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2462         * completer.c (complete_line_internal): Replace throw_exception
2463         with throw.
2464         * compile/compile-object-run.c (compile_object_run): Replace
2465         throw_exception with throw.
2466         * cli/cli-script.c (process_next_line): Replace throw_exception
2467         with throw.
2468         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2469         (btrace_enable, btrace_maint_update_pt_packets): Replace
2470         throw_exception with throw.
2471         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2472         throw_exception with throw.
2473         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2474         throw_exception with throw.
2475         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2476         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2477         * aarch64-tdep.c (aarch64_make_prologue_cache)
2478         (aarch64_make_stub_cache): Replace throw_exception with throw.
2479
2480 2019-04-08  Tom Tromey  <tom@tromey.com>
2481
2482         * common/common-exceptions.c (throw_exception): Rename from
2483         throw_exception_cxx.  Remove old copy.  Make argument const.
2484         (throw_it): Create and throw exception objects directly.
2485         * common/common-exceptions.h (throw_exception): Make argument
2486         const.
2487         (struct gdb_exception_error): Add constructor.
2488         (struct gdb_exception_quit): Add constructor.
2489
2490 2019-04-08  Tom Tromey  <tom@tromey.com>
2491
2492         * common/common-exceptions.h (exception_rethrow): Don't declare.
2493         (TRY_SJLJ): Update comment.
2494         (TRY, CATCH, END_CATCH): Remove.
2495         * common/common-exceptions.c (exception_rethrow): Remove.
2496
2497 2019-04-08  Tom Tromey  <tom@tromey.com>
2498
2499         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2500         Remove.
2501         (gdb_exception_error): Rename from
2502         gdb_exception_RETURN_MASK_ERROR.
2503         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2504         (gdb_quit_bad_alloc): Update.
2505         * aarch64-tdep.c: Update.
2506         * ada-lang.c: Update.
2507         * ada-typeprint.c: Update.
2508         * ada-valprint.c: Update.
2509         * amd64-tdep.c: Update.
2510         * arch-utils.c: Update.
2511         * break-catch-throw.c: Update.
2512         * breakpoint.c: Update.
2513         * btrace.c: Update.
2514         * c-varobj.c: Update.
2515         * cli/cli-cmds.c: Update.
2516         * cli/cli-interp.c: Update.
2517         * cli/cli-script.c: Update.
2518         * common/common-exceptions.c: Update.
2519         * common/new-op.c: Update.
2520         * common/selftest.c: Update.
2521         * compile/compile-c-symbols.c: Update.
2522         * compile/compile-cplus-symbols.c: Update.
2523         * compile/compile-object-load.c: Update.
2524         * compile/compile-object-run.c: Update.
2525         * completer.c: Update.
2526         * corelow.c: Update.
2527         * cp-abi.c: Update.
2528         * cp-support.c: Update.
2529         * cp-valprint.c: Update.
2530         * darwin-nat.c: Update.
2531         * disasm-selftests.c: Update.
2532         * dtrace-probe.c: Update.
2533         * dwarf-index-cache.c: Update.
2534         * dwarf-index-write.c: Update.
2535         * dwarf2-frame-tailcall.c: Update.
2536         * dwarf2-frame.c: Update.
2537         * dwarf2loc.c: Update.
2538         * dwarf2read.c: Update.
2539         * eval.c: Update.
2540         * event-loop.c: Update.
2541         * event-top.c: Update.
2542         * exec.c: Update.
2543         * f-valprint.c: Update.
2544         * fbsd-tdep.c: Update.
2545         * frame-unwind.c: Update.
2546         * frame.c: Update.
2547         * gdbtypes.c: Update.
2548         * gnu-v3-abi.c: Update.
2549         * guile/guile-internal.h: Update.
2550         * guile/scm-block.c: Update.
2551         * guile/scm-breakpoint.c: Update.
2552         * guile/scm-cmd.c: Update.
2553         * guile/scm-disasm.c: Update.
2554         * guile/scm-frame.c: Update.
2555         * guile/scm-lazy-string.c: Update.
2556         * guile/scm-math.c: Update.
2557         * guile/scm-param.c: Update.
2558         * guile/scm-ports.c: Update.
2559         * guile/scm-pretty-print.c: Update.
2560         * guile/scm-symbol.c: Update.
2561         * guile/scm-symtab.c: Update.
2562         * guile/scm-type.c: Update.
2563         * guile/scm-value.c: Update.
2564         * i386-linux-tdep.c: Update.
2565         * i386-tdep.c: Update.
2566         * inf-loop.c: Update.
2567         * infcall.c: Update.
2568         * infcmd.c: Update.
2569         * infrun.c: Update.
2570         * jit.c: Update.
2571         * language.c: Update.
2572         * linespec.c: Update.
2573         * linux-fork.c: Update.
2574         * linux-nat.c: Update.
2575         * linux-tdep.c: Update.
2576         * linux-thread-db.c: Update.
2577         * main.c: Update.
2578         * mi/mi-cmd-break.c: Update.
2579         * mi/mi-cmd-stack.c: Update.
2580         * mi/mi-interp.c: Update.
2581         * mi/mi-main.c: Update.
2582         * objc-lang.c: Update.
2583         * p-valprint.c: Update.
2584         * parse.c: Update.
2585         * ppc-linux-tdep.c: Update.
2586         * printcmd.c: Update.
2587         * python/py-arch.c: Update.
2588         * python/py-breakpoint.c: Update.
2589         * python/py-cmd.c: Update.
2590         * python/py-finishbreakpoint.c: Update.
2591         * python/py-frame.c: Update.
2592         * python/py-framefilter.c: Update.
2593         * python/py-gdb-readline.c: Update.
2594         * python/py-inferior.c: Update.
2595         * python/py-infthread.c: Update.
2596         * python/py-lazy-string.c: Update.
2597         * python/py-linetable.c: Update.
2598         * python/py-objfile.c: Update.
2599         * python/py-param.c: Update.
2600         * python/py-prettyprint.c: Update.
2601         * python/py-progspace.c: Update.
2602         * python/py-record-btrace.c: Update.
2603         * python/py-record.c: Update.
2604         * python/py-symbol.c: Update.
2605         * python/py-type.c: Update.
2606         * python/py-unwind.c: Update.
2607         * python/py-utils.c: Update.
2608         * python/py-value.c: Update.
2609         * python/python.c: Update.
2610         * record-btrace.c: Update.
2611         * record-full.c: Update.
2612         * remote-fileio.c: Update.
2613         * remote.c: Update.
2614         * riscv-tdep.c: Update.
2615         * rs6000-aix-tdep.c: Update.
2616         * rs6000-tdep.c: Update.
2617         * rust-exp.y: Update.
2618         * rust-lang.c: Update.
2619         * s390-tdep.c: Update.
2620         * selftest-arch.c: Update.
2621         * solib-dsbt.c: Update.
2622         * solib-frv.c: Update.
2623         * solib-spu.c: Update.
2624         * solib-svr4.c: Update.
2625         * solib.c: Update.
2626         * sparc64-linux-tdep.c: Update.
2627         * stack.c: Update.
2628         * symfile-mem.c: Update.
2629         * symmisc.c: Update.
2630         * target.c: Update.
2631         * thread.c: Update.
2632         * top.c: Update.
2633         * tracefile-tfile.c: Update.
2634         * tui/tui.c: Update.
2635         * typeprint.c: Update.
2636         * unittests/cli-utils-selftests.c: Update.
2637         * unittests/parse-connection-spec-selftests.c: Update.
2638         * valops.c: Update.
2639         * valprint.c: Update.
2640         * value.c: Update.
2641         * varobj.c: Update.
2642         * windows-nat.c: Update.
2643         * x86-linux-nat.c: Update.
2644         * xml-support.c: Update.
2645
2646 2019-04-08  Tom Tromey  <tom@tromey.com>
2647
2648         * xml-support.c: Use C++ exception handling.
2649         * x86-linux-nat.c: Use C++ exception handling.
2650         * windows-nat.c: Use C++ exception handling.
2651         * varobj.c: Use C++ exception handling.
2652         * value.c: Use C++ exception handling.
2653         * valprint.c: Use C++ exception handling.
2654         * valops.c: Use C++ exception handling.
2655         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2656         handling.
2657         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2658         * typeprint.c: Use C++ exception handling.
2659         * tui/tui.c: Use C++ exception handling.
2660         * tracefile-tfile.c: Use C++ exception handling.
2661         * top.c: Use C++ exception handling.
2662         * thread.c: Use C++ exception handling.
2663         * target.c: Use C++ exception handling.
2664         * symmisc.c: Use C++ exception handling.
2665         * symfile-mem.c: Use C++ exception handling.
2666         * stack.c: Use C++ exception handling.
2667         * sparc64-linux-tdep.c: Use C++ exception handling.
2668         * solib.c: Use C++ exception handling.
2669         * solib-svr4.c: Use C++ exception handling.
2670         * solib-spu.c: Use C++ exception handling.
2671         * solib-frv.c: Use C++ exception handling.
2672         * solib-dsbt.c: Use C++ exception handling.
2673         * selftest-arch.c: Use C++ exception handling.
2674         * s390-tdep.c: Use C++ exception handling.
2675         * rust-lang.c: Use C++ exception handling.
2676         * rust-exp.y: Use C++ exception handling.
2677         * rs6000-tdep.c: Use C++ exception handling.
2678         * rs6000-aix-tdep.c: Use C++ exception handling.
2679         * riscv-tdep.c: Use C++ exception handling.
2680         * remote.c: Use C++ exception handling.
2681         * remote-fileio.c: Use C++ exception handling.
2682         * record-full.c: Use C++ exception handling.
2683         * record-btrace.c: Use C++ exception handling.
2684         * python/python.c: Use C++ exception handling.
2685         * python/py-value.c: Use C++ exception handling.
2686         * python/py-utils.c: Use C++ exception handling.
2687         * python/py-unwind.c: Use C++ exception handling.
2688         * python/py-type.c: Use C++ exception handling.
2689         * python/py-symbol.c: Use C++ exception handling.
2690         * python/py-record.c: Use C++ exception handling.
2691         * python/py-record-btrace.c: Use C++ exception handling.
2692         * python/py-progspace.c: Use C++ exception handling.
2693         * python/py-prettyprint.c: Use C++ exception handling.
2694         * python/py-param.c: Use C++ exception handling.
2695         * python/py-objfile.c: Use C++ exception handling.
2696         * python/py-linetable.c: Use C++ exception handling.
2697         * python/py-lazy-string.c: Use C++ exception handling.
2698         * python/py-infthread.c: Use C++ exception handling.
2699         * python/py-inferior.c: Use C++ exception handling.
2700         * python/py-gdb-readline.c: Use C++ exception handling.
2701         * python/py-framefilter.c: Use C++ exception handling.
2702         * python/py-frame.c: Use C++ exception handling.
2703         * python/py-finishbreakpoint.c: Use C++ exception handling.
2704         * python/py-cmd.c: Use C++ exception handling.
2705         * python/py-breakpoint.c: Use C++ exception handling.
2706         * python/py-arch.c: Use C++ exception handling.
2707         * printcmd.c: Use C++ exception handling.
2708         * ppc-linux-tdep.c: Use C++ exception handling.
2709         * parse.c: Use C++ exception handling.
2710         * p-valprint.c: Use C++ exception handling.
2711         * objc-lang.c: Use C++ exception handling.
2712         * mi/mi-main.c: Use C++ exception handling.
2713         * mi/mi-interp.c: Use C++ exception handling.
2714         * mi/mi-cmd-stack.c: Use C++ exception handling.
2715         * mi/mi-cmd-break.c: Use C++ exception handling.
2716         * main.c: Use C++ exception handling.
2717         * linux-thread-db.c: Use C++ exception handling.
2718         * linux-tdep.c: Use C++ exception handling.
2719         * linux-nat.c: Use C++ exception handling.
2720         * linux-fork.c: Use C++ exception handling.
2721         * linespec.c: Use C++ exception handling.
2722         * language.c: Use C++ exception handling.
2723         * jit.c: Use C++ exception handling.
2724         * infrun.c: Use C++ exception handling.
2725         * infcmd.c: Use C++ exception handling.
2726         * infcall.c: Use C++ exception handling.
2727         * inf-loop.c: Use C++ exception handling.
2728         * i386-tdep.c: Use C++ exception handling.
2729         * i386-linux-tdep.c: Use C++ exception handling.
2730         * guile/scm-value.c: Use C++ exception handling.
2731         * guile/scm-type.c: Use C++ exception handling.
2732         * guile/scm-symtab.c: Use C++ exception handling.
2733         * guile/scm-symbol.c: Use C++ exception handling.
2734         * guile/scm-pretty-print.c: Use C++ exception handling.
2735         * guile/scm-ports.c: Use C++ exception handling.
2736         * guile/scm-param.c: Use C++ exception handling.
2737         * guile/scm-math.c: Use C++ exception handling.
2738         * guile/scm-lazy-string.c: Use C++ exception handling.
2739         * guile/scm-frame.c: Use C++ exception handling.
2740         * guile/scm-disasm.c: Use C++ exception handling.
2741         * guile/scm-cmd.c: Use C++ exception handling.
2742         * guile/scm-breakpoint.c: Use C++ exception handling.
2743         * guile/scm-block.c: Use C++ exception handling.
2744         * guile/guile-internal.h: Use C++ exception handling.
2745         * gnu-v3-abi.c: Use C++ exception handling.
2746         * gdbtypes.c: Use C++ exception handling.
2747         * frame.c: Use C++ exception handling.
2748         * frame-unwind.c: Use C++ exception handling.
2749         * fbsd-tdep.c: Use C++ exception handling.
2750         * f-valprint.c: Use C++ exception handling.
2751         * exec.c: Use C++ exception handling.
2752         * event-top.c: Use C++ exception handling.
2753         * event-loop.c: Use C++ exception handling.
2754         * eval.c: Use C++ exception handling.
2755         * dwarf2read.c: Use C++ exception handling.
2756         * dwarf2loc.c: Use C++ exception handling.
2757         * dwarf2-frame.c: Use C++ exception handling.
2758         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2759         * dwarf-index-write.c: Use C++ exception handling.
2760         * dwarf-index-cache.c: Use C++ exception handling.
2761         * dtrace-probe.c: Use C++ exception handling.
2762         * disasm-selftests.c: Use C++ exception handling.
2763         * darwin-nat.c: Use C++ exception handling.
2764         * cp-valprint.c: Use C++ exception handling.
2765         * cp-support.c: Use C++ exception handling.
2766         * cp-abi.c: Use C++ exception handling.
2767         * corelow.c: Use C++ exception handling.
2768         * completer.c: Use C++ exception handling.
2769         * compile/compile-object-run.c: Use C++ exception handling.
2770         * compile/compile-object-load.c: Use C++ exception handling.
2771         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2772         * compile/compile-c-symbols.c: Use C++ exception handling.
2773         * common/selftest.c: Use C++ exception handling.
2774         * common/new-op.c: Use C++ exception handling.
2775         * cli/cli-script.c: Use C++ exception handling.
2776         * cli/cli-interp.c: Use C++ exception handling.
2777         * cli/cli-cmds.c: Use C++ exception handling.
2778         * c-varobj.c: Use C++ exception handling.
2779         * btrace.c: Use C++ exception handling.
2780         * breakpoint.c: Use C++ exception handling.
2781         * break-catch-throw.c: Use C++ exception handling.
2782         * arch-utils.c: Use C++ exception handling.
2783         * amd64-tdep.c: Use C++ exception handling.
2784         * ada-valprint.c: Use C++ exception handling.
2785         * ada-typeprint.c: Use C++ exception handling.
2786         * ada-lang.c: Use C++ exception handling.
2787         * aarch64-tdep.c: Use C++ exception handling.
2788
2789 2019-04-08  Tom Tromey  <tom@tromey.com>
2790
2791         * xml-support.c (gdb_xml_parser::parse): Update.
2792         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2793         * value.c (show_convenience): Update.
2794         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2795         (test_parse_flags_qcs): Update.
2796         * thread.c (thr_try_catch_cmd): Update.
2797         * target.c (target_translate_tls_address): Update.
2798         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2799         (info_frame_command_core, frame_apply_command_count): Update.
2800         * rust-exp.y (rust_lex_exception_test): Update.
2801         * riscv-tdep.c (riscv_print_one_register_info): Update.
2802         * remote.c (remote_target::enable_btrace): Update.
2803         * record-btrace.c (record_btrace_enable_warn): Update.
2804         * python/py-utils.c (gdbpy_convert_exception): Update.
2805         * printcmd.c (do_one_display, print_variable_and_value): Update.
2806         * mi/mi-main.c (mi_print_exception): Update.
2807         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2808         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2809         * linux-nat.c (linux_nat_target::attach): Update.
2810         * linux-fork.c (class scoped_switch_fork_info): Update.
2811         * infrun.c (displaced_step_prepare): Update.
2812         * infcall.c (call_function_by_hand_dummy): Update.
2813         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2814         * gnu-v3-abi.c (print_one_vtable): Update.
2815         * frame.c (get_prev_frame_always): Update.
2816         * f-valprint.c (info_common_command_for_block): Update.
2817         * exec.c (try_open_exec_file): Update.
2818         * exceptions.c (print_exception, exception_print)
2819         (exception_fprintf, exception_print_same): Update.
2820         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2821         * dwarf-index-cache.c (index_cache::store)
2822         (index_cache::lookup_gdb_index): Update.
2823         * darwin-nat.c (maybe_cache_shell): Update.
2824         * cp-valprint.c (cp_print_value_fields): Update.
2825         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2826         (gcc_cplus_symbol_address): Update.
2827         * compile/compile-c-symbols.c (gcc_convert_symbol)
2828         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2829         * common/selftest.c: Update.
2830         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2831         a std::string.
2832         (exception_try_scope_entry, exception_try_scope_exit): Don't
2833         declare.
2834         (struct exception_try_scope): Remove.
2835         (TRY): Don't use exception_try_scope.
2836         (struct gdb_exception): Add constructor, operator=.
2837         <what>: New method.
2838         (struct gdb_exception_RETURN_MASK_ALL)
2839         (struct gdb_exception_RETURN_MASK_ERROR)
2840         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2841         (struct gdb_quit_bad_alloc): Update.
2842         * common/common-exceptions.c (exception_none): Change
2843         initializer.
2844         (struct catcher) <state, exception>: Initialize inline.
2845         <prev>: Remove member.
2846         (current_catcher): Remove.
2847         (catchers): New global.
2848         (exceptions_state_mc_init): Simplify.
2849         (catcher_pop): Remove.
2850         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2851         (try_scope_depth, exception_try_scope_entry)
2852         (exception_try_scope_exit): Remove.
2853         (throw_exception_sjlj): Update.
2854         (exception_messages, exception_messages_size): Remove.
2855         (throw_it): Simplify.
2856         (gdb_exception_sliced_copy): Remove.
2857         (throw_exception_cxx): Update.
2858         * cli/cli-script.c (script_from_file): Update.
2859         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2860         Update.
2861         * ada-valprint.c (ada_val_print): Update.
2862         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2863         (create_excep_cond_exprs): Update.
2864
2865 2019-04-08  Tom Tromey  <tom@tromey.com>
2866
2867         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2868         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2869         (TRY, CATCH, END_CATCH): Remove some definitions.
2870         * common/common-exceptions.c: Don't use GDB_XCPT.
2871         (catcher_list_size): Remove.
2872         (throw_exception, throw_it): Simplify.
2873
2874 2019-04-05  Tom Tromey  <tom@tromey.com>
2875
2876         Revert the header-sorting patch.
2877         * ft32-tdep.c: Revert.
2878         * frv-tdep.c: Revert.
2879         * frv-linux-tdep.c: Revert.
2880         * frame.c: Revert.
2881         * frame-unwind.c: Revert.
2882         * frame-base.c: Revert.
2883         * fork-child.c: Revert.
2884         * findvar.c: Revert.
2885         * findcmd.c: Revert.
2886         * filesystem.c: Revert.
2887         * filename-seen-cache.h: Revert.
2888         * filename-seen-cache.c: Revert.
2889         * fbsd-tdep.c: Revert.
2890         * fbsd-nat.h: Revert.
2891         * fbsd-nat.c: Revert.
2892         * f-valprint.c: Revert.
2893         * f-typeprint.c: Revert.
2894         * f-lang.c: Revert.
2895         * extension.h: Revert.
2896         * extension.c: Revert.
2897         * extension-priv.h: Revert.
2898         * expprint.c: Revert.
2899         * exec.h: Revert.
2900         * exec.c: Revert.
2901         * exceptions.c: Revert.
2902         * event-top.c: Revert.
2903         * event-loop.c: Revert.
2904         * eval.c: Revert.
2905         * elfread.c: Revert.
2906         * dwarf2read.h: Revert.
2907         * dwarf2read.c: Revert.
2908         * dwarf2loc.c: Revert.
2909         * dwarf2expr.h: Revert.
2910         * dwarf2expr.c: Revert.
2911         * dwarf2-frame.c: Revert.
2912         * dwarf2-frame-tailcall.c: Revert.
2913         * dwarf-index-write.h: Revert.
2914         * dwarf-index-write.c: Revert.
2915         * dwarf-index-common.c: Revert.
2916         * dwarf-index-cache.h: Revert.
2917         * dwarf-index-cache.c: Revert.
2918         * dummy-frame.c: Revert.
2919         * dtrace-probe.c: Revert.
2920         * disasm.h: Revert.
2921         * disasm.c: Revert.
2922         * disasm-selftests.c: Revert.
2923         * dictionary.c: Revert.
2924         * dicos-tdep.c: Revert.
2925         * demangle.c: Revert.
2926         * dcache.h: Revert.
2927         * dcache.c: Revert.
2928         * darwin-nat.h: Revert.
2929         * darwin-nat.c: Revert.
2930         * darwin-nat-info.c: Revert.
2931         * d-valprint.c: Revert.
2932         * d-namespace.c: Revert.
2933         * d-lang.c: Revert.
2934         * ctf.c: Revert.
2935         * csky-tdep.c: Revert.
2936         * csky-linux-tdep.c: Revert.
2937         * cris-tdep.c: Revert.
2938         * cris-linux-tdep.c: Revert.
2939         * cp-valprint.c: Revert.
2940         * cp-support.c: Revert.
2941         * cp-namespace.c: Revert.
2942         * cp-abi.c: Revert.
2943         * corelow.c: Revert.
2944         * corefile.c: Revert.
2945         * continuations.c: Revert.
2946         * completer.h: Revert.
2947         * completer.c: Revert.
2948         * complaints.c: Revert.
2949         * coffread.c: Revert.
2950         * coff-pe-read.c: Revert.
2951         * cli-out.h: Revert.
2952         * cli-out.c: Revert.
2953         * charset.c: Revert.
2954         * c-varobj.c: Revert.
2955         * c-valprint.c: Revert.
2956         * c-typeprint.c: Revert.
2957         * c-lang.c: Revert.
2958         * buildsym.c: Revert.
2959         * buildsym-legacy.c: Revert.
2960         * build-id.h: Revert.
2961         * build-id.c: Revert.
2962         * btrace.c: Revert.
2963         * bsd-uthread.c: Revert.
2964         * breakpoint.h: Revert.
2965         * breakpoint.c: Revert.
2966         * break-catch-throw.c: Revert.
2967         * break-catch-syscall.c: Revert.
2968         * break-catch-sig.c: Revert.
2969         * blockframe.c: Revert.
2970         * block.c: Revert.
2971         * bfin-tdep.c: Revert.
2972         * bfin-linux-tdep.c: Revert.
2973         * bfd-target.c: Revert.
2974         * bcache.c: Revert.
2975         * ax-general.c: Revert.
2976         * ax-gdb.h: Revert.
2977         * ax-gdb.c: Revert.
2978         * avr-tdep.c: Revert.
2979         * auxv.c: Revert.
2980         * auto-load.c: Revert.
2981         * arm-wince-tdep.c: Revert.
2982         * arm-tdep.c: Revert.
2983         * arm-symbian-tdep.c: Revert.
2984         * arm-pikeos-tdep.c: Revert.
2985         * arm-obsd-tdep.c: Revert.
2986         * arm-nbsd-tdep.c: Revert.
2987         * arm-nbsd-nat.c: Revert.
2988         * arm-linux-tdep.c: Revert.
2989         * arm-linux-nat.c: Revert.
2990         * arm-fbsd-tdep.c: Revert.
2991         * arm-fbsd-nat.c: Revert.
2992         * arm-bsd-tdep.c: Revert.
2993         * arch-utils.c: Revert.
2994         * arc-tdep.c: Revert.
2995         * arc-newlib-tdep.c: Revert.
2996         * annotate.h: Revert.
2997         * annotate.c: Revert.
2998         * amd64-windows-tdep.c: Revert.
2999         * amd64-windows-nat.c: Revert.
3000         * amd64-tdep.c: Revert.
3001         * amd64-sol2-tdep.c: Revert.
3002         * amd64-obsd-tdep.c: Revert.
3003         * amd64-obsd-nat.c: Revert.
3004         * amd64-nbsd-tdep.c: Revert.
3005         * amd64-nbsd-nat.c: Revert.
3006         * amd64-nat.c: Revert.
3007         * amd64-linux-tdep.c: Revert.
3008         * amd64-linux-nat.c: Revert.
3009         * amd64-fbsd-tdep.c: Revert.
3010         * amd64-fbsd-nat.c: Revert.
3011         * amd64-dicos-tdep.c: Revert.
3012         * amd64-darwin-tdep.c: Revert.
3013         * amd64-bsd-nat.c: Revert.
3014         * alpha-tdep.c: Revert.
3015         * alpha-obsd-tdep.c: Revert.
3016         * alpha-nbsd-tdep.c: Revert.
3017         * alpha-mdebug-tdep.c: Revert.
3018         * alpha-linux-tdep.c: Revert.
3019         * alpha-linux-nat.c: Revert.
3020         * alpha-bsd-tdep.c: Revert.
3021         * alpha-bsd-nat.c: Revert.
3022         * aix-thread.c: Revert.
3023         * agent.c: Revert.
3024         * addrmap.c: Revert.
3025         * ada-varobj.c: Revert.
3026         * ada-valprint.c: Revert.
3027         * ada-typeprint.c: Revert.
3028         * ada-tasks.c: Revert.
3029         * ada-lang.c: Revert.
3030         * aarch64-tdep.c: Revert.
3031         * aarch64-ravenscar-thread.c: Revert.
3032         * aarch64-newlib-tdep.c: Revert.
3033         * aarch64-linux-tdep.c: Revert.
3034         * aarch64-linux-nat.c: Revert.
3035         * aarch64-fbsd-tdep.c: Revert.
3036         * aarch64-fbsd-nat.c: Revert.
3037         * aarch32-linux-nat.c: Revert.
3038
3039 2019-04-05  Tom Tromey  <tom@tromey.com>
3040
3041         * ft32-tdep.c: Sort headers.
3042         * frv-tdep.c: Sort headers.
3043         * frv-linux-tdep.c: Sort headers.
3044         * frame.c: Sort headers.
3045         * frame-unwind.c: Sort headers.
3046         * frame-base.c: Sort headers.
3047         * fork-child.c: Sort headers.
3048         * findvar.c: Sort headers.
3049         * findcmd.c: Sort headers.
3050         * filesystem.c: Sort headers.
3051         * filename-seen-cache.h: Sort headers.
3052         * filename-seen-cache.c: Sort headers.
3053         * fbsd-tdep.c: Sort headers.
3054         * fbsd-nat.h: Sort headers.
3055         * fbsd-nat.c: Sort headers.
3056         * f-valprint.c: Sort headers.
3057         * f-typeprint.c: Sort headers.
3058         * f-lang.c: Sort headers.
3059         * extension.h: Sort headers.
3060         * extension.c: Sort headers.
3061         * extension-priv.h: Sort headers.
3062         * expprint.c: Sort headers.
3063         * exec.h: Sort headers.
3064         * exec.c: Sort headers.
3065         * exceptions.c: Sort headers.
3066         * event-top.c: Sort headers.
3067         * event-loop.c: Sort headers.
3068         * eval.c: Sort headers.
3069         * elfread.c: Sort headers.
3070         * dwarf2read.h: Sort headers.
3071         * dwarf2read.c: Sort headers.
3072         * dwarf2loc.c: Sort headers.
3073         * dwarf2expr.h: Sort headers.
3074         * dwarf2expr.c: Sort headers.
3075         * dwarf2-frame.c: Sort headers.
3076         * dwarf2-frame-tailcall.c: Sort headers.
3077         * dwarf-index-write.h: Sort headers.
3078         * dwarf-index-write.c: Sort headers.
3079         * dwarf-index-common.c: Sort headers.
3080         * dwarf-index-cache.h: Sort headers.
3081         * dwarf-index-cache.c: Sort headers.
3082         * dummy-frame.c: Sort headers.
3083         * dtrace-probe.c: Sort headers.
3084         * disasm.h: Sort headers.
3085         * disasm.c: Sort headers.
3086         * disasm-selftests.c: Sort headers.
3087         * dictionary.c: Sort headers.
3088         * dicos-tdep.c: Sort headers.
3089         * demangle.c: Sort headers.
3090         * dcache.h: Sort headers.
3091         * dcache.c: Sort headers.
3092         * darwin-nat.h: Sort headers.
3093         * darwin-nat.c: Sort headers.
3094         * darwin-nat-info.c: Sort headers.
3095         * d-valprint.c: Sort headers.
3096         * d-namespace.c: Sort headers.
3097         * d-lang.c: Sort headers.
3098         * ctf.c: Sort headers.
3099         * csky-tdep.c: Sort headers.
3100         * csky-linux-tdep.c: Sort headers.
3101         * cris-tdep.c: Sort headers.
3102         * cris-linux-tdep.c: Sort headers.
3103         * cp-valprint.c: Sort headers.
3104         * cp-support.c: Sort headers.
3105         * cp-namespace.c: Sort headers.
3106         * cp-abi.c: Sort headers.
3107         * corelow.c: Sort headers.
3108         * corefile.c: Sort headers.
3109         * continuations.c: Sort headers.
3110         * completer.h: Sort headers.
3111         * completer.c: Sort headers.
3112         * complaints.c: Sort headers.
3113         * coffread.c: Sort headers.
3114         * coff-pe-read.c: Sort headers.
3115         * cli-out.h: Sort headers.
3116         * cli-out.c: Sort headers.
3117         * charset.c: Sort headers.
3118         * c-varobj.c: Sort headers.
3119         * c-valprint.c: Sort headers.
3120         * c-typeprint.c: Sort headers.
3121         * c-lang.c: Sort headers.
3122         * buildsym.c: Sort headers.
3123         * buildsym-legacy.c: Sort headers.
3124         * build-id.h: Sort headers.
3125         * build-id.c: Sort headers.
3126         * btrace.c: Sort headers.
3127         * bsd-uthread.c: Sort headers.
3128         * breakpoint.h: Sort headers.
3129         * breakpoint.c: Sort headers.
3130         * break-catch-throw.c: Sort headers.
3131         * break-catch-syscall.c: Sort headers.
3132         * break-catch-sig.c: Sort headers.
3133         * blockframe.c: Sort headers.
3134         * block.c: Sort headers.
3135         * bfin-tdep.c: Sort headers.
3136         * bfin-linux-tdep.c: Sort headers.
3137         * bfd-target.c: Sort headers.
3138         * bcache.c: Sort headers.
3139         * ax-general.c: Sort headers.
3140         * ax-gdb.h: Sort headers.
3141         * ax-gdb.c: Sort headers.
3142         * avr-tdep.c: Sort headers.
3143         * auxv.c: Sort headers.
3144         * auto-load.c: Sort headers.
3145         * arm-wince-tdep.c: Sort headers.
3146         * arm-tdep.c: Sort headers.
3147         * arm-symbian-tdep.c: Sort headers.
3148         * arm-pikeos-tdep.c: Sort headers.
3149         * arm-obsd-tdep.c: Sort headers.
3150         * arm-nbsd-tdep.c: Sort headers.
3151         * arm-nbsd-nat.c: Sort headers.
3152         * arm-linux-tdep.c: Sort headers.
3153         * arm-linux-nat.c: Sort headers.
3154         * arm-fbsd-tdep.c: Sort headers.
3155         * arm-fbsd-nat.c: Sort headers.
3156         * arm-bsd-tdep.c: Sort headers.
3157         * arch-utils.c: Sort headers.
3158         * arc-tdep.c: Sort headers.
3159         * arc-newlib-tdep.c: Sort headers.
3160         * annotate.h: Sort headers.
3161         * annotate.c: Sort headers.
3162         * amd64-windows-tdep.c: Sort headers.
3163         * amd64-windows-nat.c: Sort headers.
3164         * amd64-tdep.c: Sort headers.
3165         * amd64-sol2-tdep.c: Sort headers.
3166         * amd64-obsd-tdep.c: Sort headers.
3167         * amd64-obsd-nat.c: Sort headers.
3168         * amd64-nbsd-tdep.c: Sort headers.
3169         * amd64-nbsd-nat.c: Sort headers.
3170         * amd64-nat.c: Sort headers.
3171         * amd64-linux-tdep.c: Sort headers.
3172         * amd64-linux-nat.c: Sort headers.
3173         * amd64-fbsd-tdep.c: Sort headers.
3174         * amd64-fbsd-nat.c: Sort headers.
3175         * amd64-dicos-tdep.c: Sort headers.
3176         * amd64-darwin-tdep.c: Sort headers.
3177         * amd64-bsd-nat.c: Sort headers.
3178         * alpha-tdep.c: Sort headers.
3179         * alpha-obsd-tdep.c: Sort headers.
3180         * alpha-nbsd-tdep.c: Sort headers.
3181         * alpha-mdebug-tdep.c: Sort headers.
3182         * alpha-linux-tdep.c: Sort headers.
3183         * alpha-linux-nat.c: Sort headers.
3184         * alpha-bsd-tdep.c: Sort headers.
3185         * alpha-bsd-nat.c: Sort headers.
3186         * aix-thread.c: Sort headers.
3187         * agent.c: Sort headers.
3188         * addrmap.c: Sort headers.
3189         * ada-varobj.c: Sort headers.
3190         * ada-valprint.c: Sort headers.
3191         * ada-typeprint.c: Sort headers.
3192         * ada-tasks.c: Sort headers.
3193         * ada-lang.c: Sort headers.
3194         * aarch64-tdep.c: Sort headers.
3195         * aarch64-ravenscar-thread.c: Sort headers.
3196         * aarch64-newlib-tdep.c: Sort headers.
3197         * aarch64-linux-tdep.c: Sort headers.
3198         * aarch64-linux-nat.c: Sort headers.
3199         * aarch64-fbsd-tdep.c: Sort headers.
3200         * aarch64-fbsd-nat.c: Sort headers.
3201         * aarch32-linux-nat.c: Sort headers.
3202
3203 2019-04-04  Tom Tromey  <tom@tromey.com>
3204
3205         * varobj.c (varobj_create): Update.
3206         * rust-exp.y (struct rust_parser) <update_innermost_block,
3207         lookup_symbol>: New methods.
3208         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3209         Rename.
3210         (rust_parser::rust_lookup_type)
3211         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3212         * printcmd.c (display_command, do_one_display): Update.
3213         * parser-defs.h (struct parser_state) <parser_state>: Add
3214         "tracker" parameter.
3215         (block_tracker): New member.
3216         (class innermost_block_tracker) <innermost_block_tracker>: Add
3217         "types" parameter.
3218         <reset>: Remove method.
3219         (innermost_block): Don't declare.
3220         (null_post_parser): Update.
3221         * parse.c (innermost_block): Remove global.
3222         (write_dollar_variable): Update.
3223         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3224         Remove "tracker_types" parameter.
3225         (parse_expression): Add "tracker" parameter.
3226         (parse_expression_for_completion): Update.
3227         (null_post_parser): Add "tracker" parameter.
3228         * p-exp.y: Update rules.
3229         * m2-exp.y: Update rules.
3230         * language.h (struct language_defn) <la_post_parser>: Add
3231         "tracker" parameter.
3232         * go-exp.y: Update rules.
3233         * f-exp.y: Update rules.
3234         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3235         parameter.
3236         * d-exp.y: Update rules.
3237         * c-exp.y: Update rules.
3238         * breakpoint.c (set_breakpoint_condition): Create an
3239         innermost_block_tracker.
3240         (watch_command_1): Likewise.
3241         * ada-lang.c (resolve): Add "tracker" parameter.
3242         (resolve_subexp): Likewise.
3243         * ada-exp.y (write_var_from_sym): Update.
3244
3245 2019-04-04  Tom Tromey  <tom@tromey.com>
3246
3247         * type-stack.h: New file.
3248         * type-stack.c: New file.
3249         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3250         type-stack.h.
3251         (insert_into_type_stack, insert_type, push_type, push_type_int)
3252         (insert_type_address_space, pop_type, pop_type_int)
3253         (pop_typelist, pop_type_stack, append_type_stack)
3254         (push_type_stack, get_type_stack, push_typelist)
3255         (follow_type_instance_flags, follow_types): Don't declare.
3256         * parse.c (type_stack): Remove global.
3257         (parse_exp_in_context): Update.
3258         (insert_into_type_stack, insert_type, push_type, push_type_int)
3259         (insert_type_address_space, pop_type, pop_type_int)
3260         (pop_typelist, pop_type_stack, append_type_stack)
3261         (push_type_stack, get_type_stack, push_typelist)
3262         (follow_type_instance_flags, follow_types): Remove (moved to
3263         type-stack.c).
3264         * f-exp.y (type_stack): New global.
3265         Update rules.
3266         (push_kind_type, f_parse): Update.
3267         * d-exp.y (type_stack): New global.
3268         Update rules.
3269         (d_parse): Update.
3270         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3271         Update rules.
3272         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3273         (HFILES_NO_SRCDIR): Add type-stack.h.
3274
3275 2019-04-04  Tom Tromey  <tom@tromey.com>
3276
3277         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3278         (rust_parser::convert_ast_to_expression, rust_parse)
3279         (rust_lex_test_completion, rust_lex_tests): Update.
3280         * parser-defs.h (struct expr_completion_state): New.
3281         (struct parser_state) <parser_state>: Add completion parameter.
3282         <mark_struct_expression, mark_completion_tag>: New methods.
3283         <parse_completion, m_completion_state>: New members.
3284         (prefixify_expression, null_post_parser): Update.
3285         (mark_struct_expression, mark_completion_tag): Don't declare.
3286         * parse.c (parse_completion, expout_last_struct)
3287         (expout_tag_completion_type, expout_completion_name): Remove
3288         globals.
3289         (parser_state::mark_struct_expression)
3290         (parser_state::mark_completion_tag): Now methods.
3291         (prefixify_expression): Add last_struct parameter.
3292         (prefixify_subexp): Likewise.
3293         (parse_exp_1): Update.
3294         (parse_exp_in_context): Add cstate parameter.  Update.
3295         (parse_expression_for_completion): Create an
3296         expr_completion_state.
3297         (null_post_parser): Add "completion" parameter.
3298         * p-exp.y: Update rules.
3299         (yylex): Update.
3300         * language.h (struct language_defn) <la_post_parser>: Add
3301         "completing" parameter.
3302         * go-exp.y: Update rules.
3303         (lex_one_token): Update.
3304         * expression.h (parse_completion): Don't declare.
3305         * d-exp.y: Update rules.
3306         (lex_one_token): Update rules.
3307         * c-exp.y: Update rules.
3308         (lex_one_token): Update.
3309         * ada-lang.c (resolve): Add "parse_completion" parameter.
3310         (resolve_subexp): Likewise.
3311         (ada_resolve_function): Likewise.
3312
3313 2019-04-04  Tom Tromey  <tom@tromey.com>
3314
3315         * parser-defs.h (struct parser_state) <start_arglist,
3316         end_arglist>: New methods.
3317         <arglist_len, m_funcall_chain>: New members.
3318         (arglist_len, start_arglist, end_arglist): Don't declare.
3319         * parse.c (arglist_len, funcall_chain): Remove global.
3320         (start_arglist, end_arglist): Remove functions.
3321         (parse_exp_in_context): Update.
3322         * p-exp.y: Update rules.
3323         * m2-exp.y: Update rules.
3324         * go-exp.y: Update rules.
3325         * f-exp.y: Update rules.
3326         * d-exp.y: Update rules.
3327         * c-exp.y: Update rules.
3328
3329 2019-04-04  Tom Tromey  <tom@tromey.com>
3330
3331         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3332         lex_operator, push_back>: New methods.
3333         Update all rules.
3334         (rust_parser::lex_hex, lex_escape): Rename and update.
3335         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3336         (rust_parser::lex_operator): Rename and update.
3337         (rust_parser::lex_number, rustyylex, rustyyerror)
3338         (rust_lex_test_init, rust_lex_test_sequence)
3339         (rust_lex_test_push_back, rust_lex_tests): Update.
3340         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3341         parameter.
3342         <lexptr, prev_lexptr>: New members.
3343         (lexptr, prev_lexptr): Don't declare.
3344         * parse.c (lexptr, prev_lexptr): Remove globals.
3345         (parse_exp_in_context): Update.
3346         * p-exp.y (yylex, yyerror): Update.
3347         * m2-exp.y (parse_number, yylex, yyerror): Update.
3348         * go-exp.y (lex_one_token, yyerror): Update.
3349         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3350         * d-exp.y (lex_one_token, yyerror): Update.
3351         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3352         (lex_one_token, yyerror): Update.
3353         * ada-lex.l (YY_INPUT): Update.
3354         (rewind_to_char): Update.
3355         * ada-exp.y (yyerror): Update.
3356
3357 2019-04-04  Tom Tromey  <tom@tromey.com>
3358
3359         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3360         * parser-defs.h (struct parser_state) <parser_state>: Add new
3361         parameter.
3362         <comma_terminates>: New member.
3363         (comma_terminates): Don't declare global.
3364         * parse.c (comma_terminates): Remove global.
3365         (parse_exp_in_context): Update.
3366         * p-exp.y (yylex): Update.
3367         * m2-exp.y (yylex): Update.
3368         * go-exp.y (lex_one_token): Update.
3369         * f-exp.y (yylex): Update.
3370         * d-exp.y (lex_one_token): Update.
3371         * c-exp.y (lex_one_token): Update.
3372         * ada-lex.l: Update.
3373
3374 2019-04-04  Tom Tromey  <tom@tromey.com>
3375
3376         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3377         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3378         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3379         * parser-defs.h (paren_depth): Don't declare.
3380         * parse.c (paren_depth): Remove global.
3381         (parse_exp_in_context): Update.
3382         * p-exp.y (paren_depth): New global.
3383         (pascal_parse): Initialize it.
3384         * m2-exp.y (paren_depth): New global.
3385         (m2_parse): Initialize it.
3386         * go-exp.y (paren_depth): New global.
3387         (go_parse): Initialize it.
3388         * f-exp.y (paren_depth): New global.
3389         (f_parse): Initialize it.
3390         * d-exp.y (paren_depth): New global.
3391         (d_parse): Initialize it.
3392         * c-exp.y (paren_depth): New global.
3393         (c_parse): Initialize it.
3394         * ada-lex.l (paren_depth): New global.
3395         (lexer_init): Initialize it.
3396
3397 2019-04-04  Tom Tromey  <tom@tromey.com>
3398
3399         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3400         (rust_parser::convert_ast_to_type)
3401         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3402         * parser-defs.h (struct parser_state) <parser_state>: Add
3403         parameters.  Initialize new members.
3404         <expression_context_block, expression_context_pc>: New members.
3405         * parse.c (expression_context_block, expression_context_pc):
3406         Remove globals.
3407         (parse_exp_in_context): Update.
3408         * p-exp.y: Update all rules.
3409         (yylex): Update.
3410         * m2-exp.y: Update all rules.
3411         (yylex): Update.
3412         * go-exp.y (yylex): Update.
3413         * f-exp.y (yylex): Update.
3414         * d-exp.y: Update all rules.
3415         (yylex): Update.
3416         * c-exp.y: Update all rules.
3417         (lex_one_token, classify_name, yylex, c_parse): Update.
3418         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3419
3420 2019-04-04  Tom Tromey  <tom@tromey.com>
3421
3422         * gdbarch.h, gdbarch.c: Rebuild.
3423         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3424         * stap-probe.h:
3425         (struct stap_parse_info): Replace "parser_state" with
3426         "expr_builder".
3427         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3428         (parser_state): New class.
3429         * parse.c (expr_builder): Rename.
3430         (expr_builder::release): Rename.
3431         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3432         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3433         (write_exp_elt_longcst, write_exp_elt_floatcst)
3434         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3435         (write_exp_string_vector, write_exp_bitstring)
3436         (write_exp_msymbol, mark_struct_expression)
3437         (write_dollar_variable)
3438         (insert_type_address_space, increase_expout_size): Replace
3439         "parser_state" with "expr_builder".
3440         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3441         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3442         "parser_state" with "expr_builder".
3443
3444 2019-04-04  Tom Tromey  <tom@tromey.com>
3445
3446         * rust-exp.y: Replace "parse_language" with method call.
3447         * p-exp.y:
3448         (yylex): Replace "parse_language" with method call.
3449         * m2-exp.y:
3450         (yylex): Replace "parse_language" with method call.
3451         * go-exp.y (classify_name): Replace "parse_language" with method
3452         call.
3453         * f-exp.y (yylex): Replace "parse_language" with method call.
3454         * d-exp.y (lex_one_token): Replace "parse_language" with method
3455         call.
3456         * c-exp.y:
3457         (lex_one_token, classify_name, yylex): Replace "parse_language"
3458         with method call.
3459         * ada-exp.y (find_primitive_type, type_char)
3460         (type_system_address): Replace "parse_language" with method call.
3461
3462 2019-04-04  Tom Tromey  <tom@tromey.com>
3463
3464         * rust-exp.y: Replace "parse_gdbarch" with method call.
3465         * parse.c (write_dollar_variable, insert_type_address_space):
3466         Replace "parse_gdbarch" with method call.
3467         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3468         call.
3469         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3470         call.
3471         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3472         "parse_gdbarch" with method call.
3473         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3474         with method call.
3475         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3476         "parse_gdbarch" with method call.
3477         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3478         "parse_gdbarch" with method call.
3479         * c-exp.y (parse_type, parse_number, classify_name): Replace
3480         "parse_gdbarch" with method call.
3481         * ada-lex.l: Replace "parse_gdbarch" with method call.
3482         * ada-exp.y (parse_type, find_primitive_type, type_char)
3483         (type_system_address): Replace "parse_gdbarch" with method call.
3484
3485 2019-04-04  Tom Tromey  <tom@tromey.com>
3486
3487         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3488         * stap-probe.c (stap_parse_argument): Update.
3489         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3490         initial_size parameter.
3491         * rust-exp.y (rust_lex_tests): Update.
3492         * parse.c (parser_state): Update.
3493         (parse_exp_in_context): Update.
3494         * parser-defs.h (struct parser_state) <parser_state>: Remove
3495         "initial_size" parameter.
3496
3497 2019-04-04  Tom Tromey  <tom@tromey.com>
3498
3499         * parser-defs.h (increase_expout_size): Don't declare.
3500         * parse.c (increase_expout_size): Now static.
3501
3502 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3503
3504         * gnu-nat.c (gnu_nat_target::wait): Fix
3505         target_waitstatus_to_string call.
3506
3507 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         * eval.c (evaluate_subexp_standard): Handle internal functions
3510         during Fortran function call handling.
3511
3512 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * NEWS: Mention new internal functions.
3515         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3516         (read_base_type): Use dwarf2_init_complex_target_type.
3517         * value.c (creal_internal_fn): New function.
3518         (cimag_internal_fn): New function.
3519         (_initialize_values): Register new internal functions.
3520
3521 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3522
3523         * infrun.c (stop_all_threads): If debug_infrun, always
3524         trace the wait status after wait_one, using
3525         target_waitstatus_to_string and target_pid_to_str.
3526         (handle_inferior_event): Replace various trace of
3527         wait status kind by a single trace.
3528         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3529         wait status kind image by target_waitstatus_to_string.
3530         * target/waitstatus.c (target_waitstatus_to_string): Fix
3531         obsolete comment.
3532
3533 2019-04-01  Tom Tromey  <tromey@adacore.com>
3534
3535         PR symtab/23331:
3536         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3537
3538 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3539             Pedro Alves  <palves@redhat.com>
3540
3541         * top.c (quit_force): Call 'finalize_values'.
3542         * value.c (finalize_values): New function.
3543         * value.h (finalize_values): Declare.
3544
3545 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3546
3547         * NEWS: Announce $_gdb_major and $_gdb_minor.
3548
3549         * top.c (init_gdb_version_vars): New function.
3550         (gdb_init): Call init_gdb_version_vars.
3551
3552 2019-03-29  Tom Tromey  <tromey@adacore.com>
3553
3554         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3555         help text.  Remove dead code.
3556
3557 2019-03-29  Keith Seitz  <keiths@redhat.com>
3558
3559         From Siddhesh Poyarekar:
3560         * f-lang.h (f77_get_upperbound): Return LONGEST.
3561         (f77_get_lowerbound): Likewise.
3562         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3563         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3564         print them.
3565         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3566         plongest to format print it.
3567         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3568         (f77_get_upperbound): Likewise.
3569         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3570         LOWER_BOUND to LONGEST.
3571         (f77_create_arrayprint_offset_tbl): Likewise.
3572
3573 2019-03-29  Keith Seitz  <keiths@redhat.com>
3574
3575         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3576         %s/pulongest for TYPE_LENGTH instead of %d in format
3577         strings.
3578         * ada-typerint.c (ada_print_type): Likewise.
3579         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3580         * compile/compile-c-support.c (generate_register_struct): Likewise.
3581         * gdbtypes.c (recursive_dump_type): Likewise.
3582         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3583         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3584         instead of %d in format strings.
3585         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3586         to std::min to ULONGEST.
3587         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3588         instead of %d in format strings.
3589         * tracepoint.c (info_scope_command): Likewise.
3590         * typeprint.c (print_offset_data::update)
3591         (print_offset_data::finish): Likewise.
3592         * xtensa-tdep.c (xtensa_store_return_value)
3593         (xtensa_push_dummy_call): Likewise.
3594
3595 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3596
3597         * windows-nat.c (display_selector): Fixed format specifications
3598         for 64-bit Cygwin.
3599
3600 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3601
3602         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3603
3604 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3605
3606         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3607         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3608         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3609         (nios2_linux_init_abi): Install it.
3610
3611 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3612
3613         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3614
3615 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3616
3617         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3618
3619 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3620             Tom Tromey  <tromey@adacore.com>
3621
3622         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3623
3624 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3625
3626         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3627         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3628         method to compute the bounds of range types. Also print "[evaluated]"
3629         if the bounds' values come from a dynamic evaluation.
3630
3631 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3632
3633         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3634         whitespace when pretty printing is on.
3635
3636 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3637
3638         * ppc-linux-nat.c: Add include.
3639
3640 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3641
3642         * NEWS: Mention AArch64 Pointer Authentication.
3643
3644 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3645
3646         * arm-linux-nat.c: Add include.
3647
3648 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3649
3650         * source-cache.c (source_cache::get_source_lines): Re-read
3651         fullname after calling open_source_file.
3652
3653 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3654
3655         * NEWS: Mention TLS support for FreeBSD.
3656
3657 2019-03-25  Tom Tromey  <tromey@adacore.com>
3658
3659         * minsyms.c (BUNCH_SIZE): Update comment.
3660         (~minimal_symbol_reader): Remove old comment.
3661         (compact_minimal_symbols): Update comment.
3662         (minimal_symbol_reader::install): Remove old comment.  Update
3663         other comments.
3664
3665 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3666
3667         * s390-linux-nat.c: Add include.
3668
3669 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3670
3671         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3672         Call linux_get_hwcap.
3673         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3674         Likewise.
3675         (aarch64_linux_get_hwcap): Remove function.
3676         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3677         declaration.
3678         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3679         linux_get_hwcap.
3680         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3681         * linux-tdep.c (linux_get_hwcap): Add function.
3682         (linux_get_hwcap2): Likewise.
3683         * linux-tdep.h (linux_get_hwcap): Add declaration.
3684         (linux_get_hwcap2): Likewise.
3685         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3686         (ppc_linux_get_hwcap2): Likewise.
3687         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3688         linux_get_hwcap.
3689         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3690         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3691         (ppc_linux_nat_target::read_description): Likewise.
3692         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3693         * s390-linux-nat.c: Likewise.
3694         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3695
3696 2019-03-24  Tom Tromey  <tom@tromey.com>
3697
3698         * ada-lang.c (standard_lookup): Simplify initialization.
3699         (ada_lookup_symbol_nonlocal): Simplify return.
3700         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3701         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3702         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3703         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3704         initialization.
3705         * solib.c (solib_global_lookup): Simplify.
3706         * symtab.c (null_block_symbol): Remove.
3707         (symbol_cache_lookup): Simplify returns.
3708         (lookup_language_this): Simplify returns.
3709         (lookup_symbol_aux): Simplify return.
3710         (lookup_local_symbol): Simplify returns.
3711         (lookup_global_symbol_from_objfile): Simplify return.
3712         (lookup_symbol_in_objfile_symtabs)
3713         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3714         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3715         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3716         * cp-namespace.c (cp_lookup_bare_symbol)
3717         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3718         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3719         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3720         (cp_lookup_symbol_via_imports): Simplify initialization.
3721         (find_symbol_in_baseclass): Likewise.
3722         * symtab.h (null_block_symbol): Remove.
3723         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3724         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3725         (d_lookup_symbol_module): Likewise.
3726         (find_symbol_in_baseclass): Simplify initialization.
3727
3728 2019-03-24  Tom Tromey  <tom@tromey.com>
3729
3730         * expression.h: Don't include symtab.h.
3731         (struct block): Forward declare.
3732
3733 2019-03-24  Tom Tromey  <tom@tromey.com>
3734
3735         * c-exp.y (typebase): Remove casts.
3736         * gdbtypes.c (lookup_unsigned_typename, )
3737         (lookup_signed_typename): Remove cast.
3738         * eval.c (parse_to_comma_and_eval): Remove cast.
3739         * parse.c (write_dollar_variable): Remove cast.
3740         * block.h (struct block) <superblock>: Now const.
3741         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3742         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3743         (map_block): Make "block" const.
3744         * symfile.h (struct quick_symbol_functions)
3745         <map_matching_symbols>: Constify block argument to "callback".
3746         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3747         const.
3748         (find_pc_sect_compunit_symtab): Make "b" const.
3749         (find_symbol_at_address): Likewise.
3750         (search_symbols): Likewise.
3751         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3752         (dw2_debug_names_lookup_symbol): Likewise.
3753         (dw2_map_matching_symbols): Update.
3754         * p-valprint.c (pascal_val_print): Remove "block".
3755         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3756         (aux_add_nonlocal_symbols): Make "block" const.
3757         (resolve_subexp): Remove cast.
3758         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3759         const.
3760         (iterate_over_file_blocks): Likewise.
3761         * f-exp.y (%union) <bval>: Remove.
3762         * coffread.c (patch_opaque_types): Make "b" const.
3763         * spu-tdep.c (spu_catch_start): Make "block" const.
3764         * c-valprint.c (print_unpacked_pointer): Remove "block".
3765         * symmisc.c (dump_symtab_1): Make "b" const.
3766         (block_depth): Make "block" const.
3767         * d-exp.y (%union) <bval>: Remove.
3768         * cp-support.h (cp_lookup_rtti_type): Update.
3769         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3770         * psymtab.c (psym_lookup_symbol): Make "block" const.
3771         (maintenance_check_psymtabs): Make "b" const.
3772         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3773         (enumerate_locals, enumerate_args): Update.
3774         * python/py-symtab.c (stpy_global_block): Make "block" const.
3775         (stpy_static_block): Likewise.
3776         * inline-frame.c (block_starting_point_at): Make "new_block"
3777         const.
3778         * block.c (find_block_in_blockvector): Make return type const.
3779         (blockvector_for_pc_sect): Make "b" const.
3780         (find_block_in_blockvector): Make "b" const.
3781
3782 2019-03-23  Tom Tromey  <tom@tromey.com>
3783
3784         * varobj.c (varobj_create): Update.
3785         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3786         * printcmd.c (display_command, do_one_display): Don't reset
3787         innermost_block.
3788         * parser-defs.h (enum innermost_block_tracker_type): Move to
3789         expression.h.
3790         (innermost_block): Update comment.
3791         * parse.c (parse_exp_1): Add tracker_types parameter.
3792         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3793         tracker_types parameter.  Reset innermost_block.
3794         (parse_exp_in_context): Remove.
3795         (parse_expression_for_completion): Update.
3796         * objfiles.c (~objfile): Don't reset expression_context_block or
3797         innermost_block.
3798         * expression.h (enum innermost_block_tracker_type): Move from
3799         parser-defs.h.
3800         (parse_exp_1): Add tracker_types parameter.
3801         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3802         reset innermost_block.
3803
3804 2019-03-23  Tom Tromey  <tom@tromey.com>
3805
3806         * objfiles.h: Include bcache.h.
3807
3808 2019-03-23  Tom Tromey  <tom@tromey.com>
3809
3810         * linespec.c (get_current_search_block): Use
3811         scoped_restore_current_language.
3812         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3813
3814 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3815             Jiong Wang  <jiong.wang@arm.com>
3816
3817         * aarch64-linux-tdep.c
3818         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3819         section.
3820         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3821
3822 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3823             Jiong Wang  <jiong.wang@arm.com>
3824
3825         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3826         instructions.
3827         (aarch64_analyze_prologue_test): Add PACIASP test.
3828         (aarch64_prologue_prev_register): Unmask PC value.
3829
3830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3831             Jiong Wang  <jiong.wang@arm.com>
3832
3833         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3834         (aarch64_dwarf2_prev_register): Unmask PC value.
3835         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3836         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3837         DW_CFA_AARCH64_negate_ra_state.
3838         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3839
3840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3841             Jiong Wang  <jiong.wang@arm.com>
3842
3843         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3844         registers.
3845         (aarch64_pseudo_register_name): Likewise.
3846         (aarch64_pseudo_register_type): Likewise.
3847         (aarch64_pseudo_register_reggroup_p): Likewise.
3848         (aarch64_gdbarch_init): Add pauth registers.
3849         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3850         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3851         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3852         (struct gdbarch_tdep): Add regnum for ra_state.
3853
3854 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3855             Jiong Wang  <jiong.wang@arm.com>
3856
3857         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3858
3859 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3860             Jiong Wang  <jiong.wang@arm.com>
3861
3862         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3863         function.
3864         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3865         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3866         (aarch64_gdbarch_init): Add puth registers.
3867         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3868         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3869         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3870
3871 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3872             Jiong Wang  <jiong.wang@arm.com>
3873
3874         * aarch64-linux-nat.c
3875         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3876         * aarch64-linux-tdep.c
3877         (aarch64_linux_core_read_description): Likewise.
3878         (aarch64_linux_get_hwcap): New function.
3879         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3880         (aarch64_linux_get_hwcap): New declaration.
3881
3882 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3883             Jiong Wang  <jiong.wang@arm.com>
3884
3885         * aarch64-linux-nat.c
3886         (aarch64_linux_nat_target::read_description): Add pauth param.
3887         * aarch64-linux-tdep.c
3888         (aarch64_linux_core_read_description): Likewise.
3889         * aarch64-tdep.c (struct target_desc): Add in pauth.
3890         (aarch64_read_description): Add pauth param.
3891         (aarch64_gdbarch_init): Likewise.
3892         * aarch64-tdep.h (aarch64_read_description): Likewise.
3893         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3894         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3895         * features/Makefile: Add new files.
3896         * features/aarch64-pauth.c: New file.
3897         * features/aarch64-pauth.xml: New file.
3898
3899 2019-03-20  Tom Tromey  <tromey@adacore.com>
3900
3901         * infrun.c (handle_inferior_event): Rename from
3902         handle_inferior_event_1.  Create a scoped_value_mark.
3903         (handle_inferior_event): Remove.
3904
3905 2019-03-19  Tom Tromey  <tromey@adacore.com>
3906
3907         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3908         * infrun.h (print_stop_event): Add "displays" parameter.
3909         * infrun.c (print_stop_event): Add "displays" parameter.
3910
3911 2019-03-19  Pedro Alves  <palves@redhat.com>
3912
3913         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3914         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3915         to -1.  Fix TABs vs spaces.
3916         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3917         * tui/tui-out.h (tui_ui_out) Add intro comments.
3918         <m_line, m_start_of_line>: In-class initialize, and add describing
3919         comment.
3920
3921 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3922
3923         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3924         variable names.
3925         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3926
3927 2019-03-18  Pedro Alves  <palves@redhat.com>
3928             Eli Zaretskii <eliz@gnu.org>
3929
3930         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3931         m_line and m_start_of_line.
3932
3933 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3934
3935         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3936         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3937         it returns a newline.  This fixes a regression in TU mode, whereby
3938         the next line is output on the same screen line as the user input.
3939
3940 2019-03-18  Tom Tromey  <tromey@adacore.com>
3941
3942         * minsyms.c (minimal_symbol_reader::install): Remove call to
3943         obstack_blank.
3944
3945 2019-03-18  Pedro Alves  <palves@redhat.com>
3946
3947         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3948         New globals.
3949         (apply_style): New, factored out from ...
3950         (apply_ansi_escape): ... this.  Handle reverse video mode.
3951         (tui_set_reverse_mode): New function.
3952         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3953         * tui/tui-winsource.c (tui_show_source_line): Use
3954         tui_set_reverse_mode instead of setting A_STANDOUT.
3955         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3956         New setter methods.
3957
3958 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3959
3960         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3961         Handle tabs.
3962
3963 2019-03-18  Tom Tromey  <tromey@adacore.com>
3964
3965         * ada-lang.c (empty_array): Add "high" parameter.
3966         (ada_evaluate_subexp): Update.
3967
3968 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3969
3970         * unittests/string_view-selftests.c: Define
3971         _initialize_string_view_selftests unconditionally.
3972
3973 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3974
3975         PR gdb/24350
3976         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3977
3978 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3979
3980         PR gdb/24351
3981         * windows-nat.c (display_selector): Fix format specifiers.
3982
3983 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3984
3985         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3986         tui_refill_source_window instead of tui_refresh_win, to update the
3987         current execution line.  This fixes redisplay of the current line
3988         when stepping through the code with "next" or "step".
3989
3990 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3991
3992         * source-cache.c (source_cache::get_source_lines): Call
3993         find_source_lines to initialize s->nlines.  This fixes vertical
3994         scrolling of TUI source window when the DOWN arrow is pressed.
3995
3996 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3997
3998         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3999         linux-thread-db.c (_initialize_thread_db): Likewise.
4000
4001 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4002
4003         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4004         wclrtoeol in tui_show_source_line".  This reverts changes made in
4005         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4006
4007 2019-03-15  Tom Tromey  <tom@tromey.com>
4008
4009         * symtab.h (struct minimal_symbol): Derive from
4010         general_symbol_info.
4011         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4012         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4013         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4014         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4015         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4016         (MSYMBOL_SEARCH_NAME): Update.
4017         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4018         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4019         * minsyms.c (minimal_symbol_reader::record_full): Update.
4020
4021 2019-03-15  Tom Tromey  <tom@tromey.com>
4022
4023         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4024
4025 2019-03-15  Tom Tromey  <tom@tromey.com>
4026
4027         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4028         unique_xmalloc_ptr.
4029         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4030         Update.
4031         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4032         (build_minimal_symbol_hash_tables)
4033         (minimal_symbol_reader::install): Update.
4034
4035 2019-03-15  Tom Tromey  <tom@tromey.com>
4036
4037         * symtab.c (create_demangled_names_hash): Update.
4038         (symbol_set_names): Update.
4039         * objfiles.h (struct objfile_per_bfd_storage)
4040         <demangled_names_hash>: Now an htab_up.
4041         * objfiles.c (objfile_per_bfd_storage): Simplify.
4042
4043 2019-03-15  Tom Tromey  <tom@tromey.com>
4044
4045         * objfiles.h (struct objfile_per_bfd_storage): Declare
4046         destructor.
4047         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4048         New.
4049         (get_objfile_bfd_data): Use new.  Don't initialize
4050         language_of_main.
4051         (free_objfile_per_bfd_storage): Remove.
4052         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4053
4054 2019-03-15  Tom Tromey  <tom@tromey.com>
4055
4056         * symfile.c (reread_symbols): Update.
4057         * objfiles.c (objfile::objfile): Update.
4058         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4059         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4060         comment.
4061         (minimal_symbol_reader::install): Update.
4062         (terminate_minimal_symbol_table): Remove.
4063         * jit.c (jit_object_close_impl): Update.
4064
4065 2019-03-15  Tom Tromey  <tom@tromey.com>
4066
4067         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4068         initializations.
4069
4070 2019-03-15  Tom Tromey  <tom@tromey.com>
4071
4072         * objfiles.h (struct objfile_per_bfd_storage)
4073         <demangled_hash_languages>: Now a bitset.
4074         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4075         (lookup_minimal_symbol): Update.
4076
4077 2019-03-15  Tom Tromey  <tom@tromey.com>
4078
4079         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4080         Don't return the symbol.
4081         * coffread.c (record_minimal_symbol): Use record_full.
4082
4083 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4084
4085         The MS-Windows port of ncurses fails to switch to a color pair if
4086         one or both of the colors are the implicit default colors.  This
4087         change records the default colors when TUI is initialized, and
4088         then specifies them explicitly when a color pair uses the default
4089         colors.  This allows color styling in TUI mode on MS-Windows.
4090
4091         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4092         ncurses_norm_attr.
4093         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4094         colors in ncurses_norm_attr.
4095         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4096         "none", replace it with the default color recorded in
4097         ncurses_norm_attr.
4098
4099 2019-03-14  Tom Tromey  <tromey@adacore.com>
4100
4101         * source-cache.h (class source_cache) <get_source_lines>: Return
4102         std::string.
4103         * source-cache.c (source_cache::extract_lines): Handle case where
4104         first_pos==npos.  Return std::string.
4105         (source_cache::get_source_lines): Update.
4106
4107 2019-03-14  Tom Tromey  <tromey@adacore.com>
4108
4109         * NEWS: Add item for "style sources" commands.
4110         * source-cache.c (source_cache::get_source_lines): Check
4111         source_styling.
4112         * cli/cli-style.c (source_styling): New global.
4113         (_initialize_cli_style): Add "style sources" commands.
4114         (show_style_sources): New function.
4115         * cli/cli-style.h (source_styling): Declare.
4116
4117 2019-03-14  Pedro Alves  <palves@redhat.com>
4118             Tom Tromey  <tromey@adacore.com>
4119
4120         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4121         * tui/tui-winsource.c (tui_refill_source_window): New function,
4122         from...
4123         (tui_horizontal_source_scroll): ... here.  Move some logic.
4124         * cli/cli-style.c (set_style_enabled): Notify new observable.
4125         * tui/tui-hooks.c (tui_redisplay_source): New function.
4126         (tui_attach_detach_observers): Attach or detach
4127         tui_redisplay_source.
4128         * observable.h (source_styling_changed): New observable.
4129         * observable.c: Define source_styling_changed observable.
4130
4131 2019-03-13  Tom Tromey  <tromey@adacore.com>
4132
4133         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4134         (i386_gnu_nat_target::store_registers): Update.
4135         * target-debug.h (target_debug_print_std_string): New macro.
4136         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4137         * windows-tdep.c (display_one_tib): Update.
4138         * tui/tui-stack.c (tui_make_status_line): Update.
4139         * top.c (print_inferior_quit_action): Update.
4140         * thread.c (thr_try_catch_cmd): Update.
4141         (add_thread_with_info): Update.
4142         (thread_target_id_str): Update.
4143         (thr_try_catch_cmd): Update.
4144         (thread_command): Update.
4145         (thread_find_command): Update.
4146         * record-btrace.c (record_btrace_target::info_record)
4147         (record_btrace_resume_thread, record_btrace_target::resume)
4148         (record_btrace_cancel_resume, record_btrace_step_thread)
4149         (record_btrace_target::wait, record_btrace_target::wait)
4150         (record_btrace_target::wait, record_btrace_target::stop): Update.
4151         * progspace.c (print_program_space): Update.
4152         * process-stratum-target.c
4153         (process_stratum_target::thread_address_space): Update.
4154         * linux-fork.c (linux_fork_mourn_inferior)
4155         (detach_checkpoint_command, info_checkpoints_command)
4156         (linux_fork_context): Update.
4157         (linux_fork_detach): Update.
4158         (class scoped_switch_fork_info): Update.
4159         (delete_checkpoint_command): Update.
4160         * infrun.c (follow_fork_inferior): Update.
4161         (follow_fork_inferior): Update.
4162         (proceed_after_vfork_done): Update.
4163         (handle_vfork_child_exec_or_exit): Update.
4164         (follow_exec): Update.
4165         (displaced_step_prepare_throw): Update.
4166         (displaced_step_restore): Update.
4167         (start_step_over): Update.
4168         (resume_1): Update.
4169         (clear_proceed_status_thread): Update.
4170         (proceed): Update.
4171         (print_target_wait_results): Update.
4172         (do_target_wait): Update.
4173         (context_switch): Update.
4174         (stop_all_threads): Update.
4175         (restart_threads): Update.
4176         (finish_step_over): Update.
4177         (handle_signal_stop): Update.
4178         (switch_back_to_stepped_thread): Update.
4179         (keep_going_pass_signal): Update.
4180         (print_exited_reason): Update.
4181         (normal_stop): Update.
4182         * inferior.c (inferior_pid_to_str): Change return type.
4183         (print_selected_inferior): Update.
4184         (add_inferior): Update.
4185         (detach_inferior): Update.
4186         * dummy-frame.c (fprint_dummy_frames): Update.
4187         * dcache.c (dcache_info_1): Update.
4188         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4189         (btrace_fetch, btrace_clear): Update.
4190         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4191         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4192         type.
4193         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4194         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4195         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4196         * gdbarch.c, gdbarch.h: Rebuild.
4197         * gdbarch.sh (core_pid_to_str): Change return type.
4198         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4199         return type.
4200         (windows_nat_target::pid_to_str): Change return type.
4201         (windows_delete_thread): Update.
4202         (windows_nat_target::attach): Update.
4203         (windows_nat_target::files_info): Update.
4204         * target-delegates.c: Rebuild.
4205         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4206         return type.
4207         (sol_thread_target::pid_to_str): Change return type.
4208         * remote.c (class remote_target) <pid_to_str>: Change return
4209         type.
4210         (remote_target::pid_to_str): Change return type.
4211         (extended_remote_target::attach, remote_target::remote_stop_ns)
4212         (remote_target::remote_notif_remove_queued_reply)
4213         (remote_target::push_stop_reply, remote_target::disable_btrace):
4214         Update.
4215         (extended_remote_target::attach): Update.
4216         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4217         type.
4218         (gdbsim_target::pid_to_str): Change return type.
4219         * ravenscar-thread.c (struct ravenscar_thread_target)
4220         <pid_to_str>: Change return type.
4221         (ravenscar_thread_target::pid_to_str): Change return type.
4222         * procfs.c (class procfs_target) <pid_to_str>: Change return
4223         type.
4224         (procfs_target::pid_to_str): Change return type.
4225         (procfs_target::attach): Update.
4226         (procfs_target::detach): Update.
4227         (procfs_target::fetch_registers): Update.
4228         (procfs_target::store_registers): Update.
4229         (procfs_target::wait): Update.
4230         (procfs_target::files_info): Update.
4231         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4232         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4233         return type.
4234         (nto_procfs_target::pid_to_str): Change return type.
4235         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4236         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4237         return type.
4238         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4239         (exit_lwp): Update.
4240         (attach_proc_task_lwp_callback, get_detach_signal)
4241         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4242         (linux_nat_target::resume, wait_lwp, stop_callback)
4243         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4244         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4245         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4246         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4247         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4248         type.
4249         (inf_ptrace_target::attach): Update.
4250         (inf_ptrace_target::files_info): Update.
4251         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4252         type.
4253         (go32_nat_target::pid_to_str): Change return type.
4254         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4255         (gnu_nat_target::wait): Update.
4256         (gnu_nat_target::wait): Update.
4257         (gnu_nat_target::resume): Update.
4258         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4259         (fbsd_nat_target::wait): Update.
4260         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4261         type.
4262         (darwin_nat_target::attach): Update.
4263         * corelow.c (class core_target) <pid_to_str>: Change return type.
4264         (core_target::pid_to_str): Change return type.
4265         * target.c (normal_pid_to_str): Change return type.
4266         (default_pid_to_str): Likewise.
4267         (target_pid_to_str): Change return type.
4268         (target_translate_tls_address): Update.
4269         (target_announce_detach): Update.
4270         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4271         return type.
4272         (bsd_uthread_target::pid_to_str): Change return type.
4273         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4274         type.
4275         (bsd_kvm_target::pid_to_str): Change return type.
4276         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4277         return type.
4278         (aix_thread_target::pid_to_str): Change return type.
4279         * target.h (struct target_ops) <pid_to_str>: Change return type.
4280         (target_pid_to_str, normal_pid_to_str): Likewise.
4281         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4282         type.
4283         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4284         type.
4285         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4286         return type.
4287         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4288         type.
4289         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4290         type.
4291         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4292         return type.
4293
4294 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4295
4296         * NEWS: Mention that the new default MI version is 3.  Mention
4297         changes to the output of commands and events that deal with
4298         multi-location breakpoints.
4299         * breakpoint.c: Include "mi/mi-out.h".
4300         (print_one_breakpoint): Change output syntax if using MI version
4301         >= 3.
4302         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4303         New.
4304         (mi_multi_location_breakpoint_output_fixed): New.
4305         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4306         (mi_cmd_fix_multi_location_breakpoint_output): New.
4307         (mi_multi_location_breakpoint_output_fixed): New.
4308         * mi/mi-cmds.c (mi_cmds): Register command
4309         -fix-multi-location-breakpoint-output.
4310         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4311         interpreter "mi".
4312
4313 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4314
4315         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4316         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4317         instantiate mi_ui_out based on interpreter name.
4318         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4319         * mi/mi-main.c (mi_load_progress): Likewise.
4320
4321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4322
4323         * NEWS: Combine separate "New targets" sections for 8.3.
4324
4325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4326
4327         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4328         (ppcfbsd_init_abi): Install gdbarch
4329         "fetch_tls_load_module_address" and "get_thread_local_address"
4330         methods.
4331
4332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4333
4334         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4335         (riscv_fbsd_init_abi): Install gdbarch
4336         "fetch_tls_load_module_address" and "get_thread_local_address"
4337         methods.
4338
4339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4340
4341         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4342         (i386fbsd_init_abi): Install gdbarch
4343         "fetch_tls_load_module_address" and "get_thread_local_address"
4344         methods.
4345
4346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4347
4348         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4349         (amd64fbsd_init_abi): Install gdbarch
4350         "fetch_tls_load_module_address" and "get_thread_local_address"
4351         methods.
4352
4353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4354
4355         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4356         (struct fbsd_pspace_data): New type.
4357         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4358         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4359         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4360         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4361         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4362
4363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4364
4365         * gdbtypes.c (lookup_struct_elt): New function.
4366         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4367         * gdbtypes.h (struct struct_elt): New type.
4368         (lookup_struct_elt): New prototype.
4369
4370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4371
4372         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4373         remove disabled code block.
4374
4375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4376
4377         * gdbarch.sh (get_thread_local_address): New method.
4378         * gdbarch.h, gdbarch.c: Regenerate.
4379         * target.c (target_translate_tls_address): Use
4380         gdbarch_get_thread_local_address if present instead of
4381         target::get_thread_local_address.
4382
4383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4384
4385         * target.h (target::get_thread_local_address): Update comment.
4386
4387 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4388
4389         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4390         objfile->separate_debug_objfile_backlink if not NULL.
4391
4392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4393
4394         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4395         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4396         (amd64bsd_store_inferior_registers): Likewise.
4397         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4398         Enable segment base registers.
4399         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4400         PT_GETFSBASE and PT_GETGSBASE.
4401         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4402         PT_SETGSBASE.
4403         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4404         segment base registers.
4405         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4406
4407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4408
4409         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4410         Update calls to i386_target_description to add 'segments'
4411         parameter.
4412         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4413         add segment base registers.
4414         * arch/i386.c (i386_create_target_description): Add 'segments'
4415         parameter to enable segment base registers.
4416         * arch/i386.h (i386_create_target_description): Likewise.
4417         * features/i386/32bit-segments.xml: New file.
4418         * features/i386/32bit-segments.c: Generate.
4419         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4420         call to i386_target_description to add 'segments' parameter.
4421         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4422         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4423         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4424         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4425         if feature is present.
4426         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4427         Add 'segments' parameter to call to i386_target_description.
4428         (i386_target_description): Add 'segments' parameter to enable
4429         segment base registers.
4430         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4431         to call to i386_target_description.
4432         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4433         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4434         Define I386_NUM_REGS.
4435         (i386_target_description): Add 'segments' parameter to enable
4436         segment base registers.
4437
4438 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4439
4440         PR/24325
4441         * source-cache.c: #undef open and close, to avoid unresolved
4442         externals during linking.
4443
4444 2019-03-12  Tom Tromey  <tromey@adacore.com>
4445
4446         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4447         const.  Add initializers.
4448         (_initialize_remote): Don't initialize ptid globals.
4449
4450 2019-03-12  Pedro Alves  <palves@redhat.com>
4451
4452         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4453
4454 2019-03-12  Pedro Alves  <palves@redhat.com>
4455
4456         * cp-name-parser.y (main): Remove unused 'len' variable.
4457
4458 2019-03-12  Tom Tromey  <tromey@adacore.com>
4459
4460         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4461         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4462
4463 2019-03-12  Tom Tromey  <tromey@adacore.com>
4464
4465         * linux-nat.c (iterate_over_lwps): Update.
4466         (stop_callback): Remove parameter.
4467         (stop_wait_callback, detach_callback, resume_set_callback)
4468         (select_singlestep_lwp_callback, set_ignore_sigint)
4469         (status_callback, resumed_callback, resume_clear_callback)
4470         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4471         data parameter.
4472         (linux_nat_target::detach, linux_nat_target::resume)
4473         (linux_stop_and_wait_all_lwps, select_event_lwp)
4474         (linux_nat_filter_event, linux_nat_wait_1)
4475         (linux_nat_target::kill, linux_nat_target::stop)
4476         (linux_nat_target::stop): Update.
4477         (linux_nat_resume_callback): Change type.
4478         (resume_stopped_resumed_lwps, count_events_callback)
4479         (select_event_lwp_callback): Likewise.
4480         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4481         * arm-linux-nat.c (struct update_registers_data): Remove.
4482         (update_registers_callback): Change type.
4483         (arm_linux_insert_hw_breakpoint1): Update.
4484         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4485         parameter.
4486         (x86_linux_dr_set_addr): Update.
4487         (x86_linux_dr_set_control): Update.
4488         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4489         (iterate_over_lwps): Use gdb::function_view.
4490         * nat/aarch64-linux-hw-point.c (struct
4491         aarch64_dr_update_callback_param): Remove.
4492         (debug_reg_change_callback): Change type.
4493         (aarch64_notify_debug_reg_change): Update.
4494         * s390-linux-nat.c (s390_refresh_per_info): Update.
4495
4496 2019-03-11  Tom Tromey  <tromey@adacore.com>
4497
4498         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4499         redundant assignment to "this_cu".
4500
4501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4502
4503         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4504
4505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4506
4507         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4508         from...
4509         (rank_one_type): ... this.
4510
4511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4512
4513         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4514         from...
4515         (rank_one_type): ... this.
4516
4517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4518
4519         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4520         from...
4521         (rank_one_type): ... this.
4522
4523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4524
4525         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4526         from...
4527         (rank_one_type): ... this.
4528
4529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4530
4531         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4532         from...
4533         (rank_one_type): ... this.
4534
4535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4536
4537         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4538         from...
4539         (rank_one_type): ... this.
4540
4541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4542
4543         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4544         from...
4545         (rank_one_type): ... this.
4546
4547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4548
4549         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4550         from...
4551         (rank_one_type): ... this.
4552
4553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4554
4555         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4556         from...
4557         (rank_one_type): ... this.
4558
4559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4560
4561         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4562         from...
4563         (rank_one_type): ... this.
4564
4565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4566
4567         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4568         from...
4569         (rank_one_type): ... this.
4570
4571 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4572
4573         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4574         from...
4575         (rank_one_type): ... this.
4576
4577 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4578
4579         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4580         inferior-events' shows the example events.
4581
4582 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4583
4584         Support styling on native MS-Windows console
4585
4586         PR/24315
4587         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4588         on MS-Windows if $TERM is not defined.
4589
4590         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4591
4592         * posix-hdep.c (gdb_console_fputs):
4593         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4594         functions.
4595         * ui-file.h (gdb_console_fputs): Add prototype.
4596
4597         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4598         back to fputs only if the former returns zero.
4599
4600 2019-03-07  Tom Tromey  <tom@tromey.com>
4601
4602         * symmisc.c (print_symbol_bcache_statistics): Update.
4603         (print_objfile_statistics): Update.
4604         * symfile.c (allocate_symtab): Update.
4605         * stabsread.c: Don't include bcache.h.
4606         * psymtab.h (struct psymbol_bcache): Don't declare.
4607         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4608         (psymbol_bcache_init, psymbol_bcache_free)
4609         (psymbol_bcache_get_bcache): Don't declare.
4610         * psymtab.c (struct psymbol_bcache): Remove.
4611         (psymtab_storage::psymtab_storage): Update.
4612         (psymtab_storage::~psymtab_storage): Update.
4613         (psymbol_bcache_init, psymbol_bcache_free)
4614         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4615         (add_psymbol_to_bcache): Update.
4616         (allocate_psymtab): Update.
4617         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4618         macro_cache>: No longer pointers.
4619         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4620         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4621         * macrotab.c (macro_bcache): Update.
4622         * macroexp.c: Don't include bcache.h.
4623         * gdbtypes.c (check_types_worklist): Update.
4624         (types_deeply_equal): Remove TRY/CATCH.  Update.
4625         * elfread.c (elf_symtab_read): Update.
4626         * dwarf2read.c: Don't include bcache.h.
4627         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4628         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4629         (print_bcache_statistics, bcache_memory_used): Don't declare.
4630         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4631         methods.  Rename all data members.
4632         * bcache.c (struct bcache): Move to bcache.h.
4633         (bcache::expand_hash_table): Rename from expand_hash_table.
4634         (bcache): Remove.
4635         (bcache::insert): Rename from bcache_full.
4636         (bcache::compare): Rename from bcache_compare.
4637         (bcache_xmalloc): Remove.
4638         (bcache::~bcache): Rename from bcache_xfree.
4639         (bcache::print_statistics): Rename from print_bcache_statistics.
4640         (bcache::memory_used): Rename from bcache_memory_used.
4641
4642 2019-03-07  Pedro Alves  <palves@redhat.com>
4643
4644         * infrun.c (normal_stop): Also check for
4645         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4646
4647 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * f-lang.c (value_from_host_double): Moved to...
4650         * value.c (value_from_host_double): ...here.
4651         * value.h (value_from_host_double): Declare.
4652         * guile/scm-math.c (vlscm_convert_typed_number): Use
4653         value_from_host_double.
4654         (vlscm_convert_number): Likewise.
4655         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4656         * python/py-value.c (convert_value_from_python): Likewise.
4657
4658 2019-03-06  Tom Tromey  <tom@tromey.com>
4659
4660         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4661
4662 2019-03-06  Tom Tromey  <tom@tromey.com>
4663
4664         * utils.h (free_current_contents): Don't declare.
4665         * utils.c (free_current_contents): Remove.
4666
4667 2019-03-06  Tom Tromey  <tom@tromey.com>
4668
4669         * top.c (quit_force): Update.
4670         * main.c (captured_command_loop): Update.
4671         * common/new-op.c (operator new): Update.
4672         * common/common-exceptions.c (struct catcher)
4673         <save_cleanup_chain>: Remove member.
4674         (exceptions_state_mc_init): Update.
4675         (exception_try_scope_entry): Return nullptr.
4676         (exception_try_scope_exit, exception_rethrow)
4677         (throw_exception_sjlj, throw_exception_cxx): Update.
4678         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4679         (all_cleanups, do_cleanups, discard_cleanups)
4680         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4681         (restore_cleanups, restore_final_cleanups): Don't declare.
4682         (do_final_cleanups): Remove parameter.
4683         * common/cleanups.c (cleanup_chain, make_cleanup)
4684         (make_cleanup_dtor, all_cleanups, do_cleanups)
4685         (discard_my_cleanups, discard_cleanups)
4686         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4687         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4688         (null_cleanup): Remove.
4689         (do_final_cleanups): Remove parameter.
4690
4691 2019-03-06  Tom Tromey  <tom@tromey.com>
4692
4693         * remote.c (remote_target::remote_parse_stop_reply): Use
4694         unique_xmalloc_ptr.
4695
4696 2019-03-06  Tom Tromey  <tom@tromey.com>
4697
4698         * stabsread.c (struct stabs_field_info): Rename from field_info.
4699         <list, fnlist>: Add initializers.
4700         <obstack>: New member.
4701         (read_member_functions, read_struct_fields, read_baseclasses):
4702         Allocate on obstack.  Don't use cleanups.
4703         (read_one_struct_field, read_member_functions, read_struct_fields)
4704         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4705         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4706         (read_struct_type): Update.
4707
4708 2019-03-06  Tom Tromey  <tom@tromey.com>
4709
4710         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4711         * common/filestuff.h (make_cleanup_close): Don't declare.
4712         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4713         Remove.
4714
4715 2019-03-06  Tom Tromey  <tom@tromey.com>
4716
4717         * solib-aix.c: Use make_scope_exit.
4718
4719 2019-03-06  Tom Tromey  <tom@tromey.com>
4720
4721         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4722         Use make_scope_exit.
4723
4724 2019-03-06  Tom Tromey  <tom@tromey.com>
4725
4726         * solib-svr4.c (disable_probes_interface): Remove parameter.
4727         (svr4_handle_solib_event): Use make_scope_exit.
4728
4729 2019-03-06  Tom Tromey  <tom@tromey.com>
4730
4731         * remote.c (struct stop_reply_deleter): Remove.
4732         (stop_reply_up): Update.
4733         (struct stop_reply): Derive from notif_event.  Don't typedef.
4734         <regcache>: Now a std::vector.
4735         (stop_reply_xfree): Remove.
4736         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4737         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4738         (remote_target::discard_pending_stop_replies): Use delete.
4739         (remote_target::remote_parse_stop_reply): Update.
4740         (remote_target::process_stop_reply): Update.
4741         * remote-notif.h (struct notif_event): Add virtual destructor.
4742         Remove "dtr" member.
4743         (struct notif_client) <alloc_event>: Return a unique_ptr.
4744         (notif_event_xfree): Don't declare.
4745         (notif_event_up): New typedef.
4746         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4747         (notif_event_xfree, do_notif_event_xfree): Remove.
4748         (remote_notif_state_xfree): Update.
4749
4750 2019-03-06  Tom Tromey  <tom@tromey.com>
4751
4752         * infrun.c (displaced_step_clear_cleanup): Now a
4753         forward_scope_exit type.
4754         (displaced_step_prepare_throw): Update.
4755         (displaced_step_fixup): Update.
4756
4757 2019-03-06  Tom Tromey  <tom@tromey.com>
4758
4759         * inferior.h (class inferior): Update comment.
4760         * gdbthread.h (class thread_info): Update comment.
4761
4762 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4763             Tom Tromey  <tom@tromey.com>
4764
4765         * stabsread.h (struct stab_section_list): Remove.
4766         (coffstab_build_psymtabs): Update.
4767         * dbxread.c (symbuf_sections): Now a std::vector.
4768         (sect_idx): New global.
4769         (fill_symbuf): Update.
4770         (coffstab_build_psymtabs): Change type of stabsects parameter.
4771         Update.
4772         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4773         std::vector.
4774         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4775         (coff_locate_sections): Update.
4776         (coff_symfile_read): Remove cleanups.  Update.
4777         (init_stringtab): Add storage parameter.
4778         (free_stringtab, free_stringtab_cleanup): Remove.
4779         (init_lineno): Add storage parameter.
4780         (free_linetab, free_linetab_cleanup): Remove.
4781
4782 2019-03-06  Pedro Alves  <palves@redhat.com>
4783
4784         * linux-fork.c (fork_info::clobber_regs): Delete.
4785         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4786         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4787         comment.  Adjust.
4788         (scoped_switch_fork_info::scoped_switch_fork_info)
4789         (checkpoint_command, linux_fork_context): Adjust
4790         fork_save_infrun_state calls.
4791
4792 2019-03-06  Pedro Alves  <palves@redhat.com>
4793
4794         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4795         (inf_has_multiple_threads): Return 'bool' and rewrite using
4796         inferior_info::threads().
4797
4798 2019-03-06  Pedro Alves  <palves@redhat.com>
4799
4800         * linux-fork.c: Include <list>.
4801         (fork_list): Now a std::list instance.
4802         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4803         (forks_exist_p, find_last_fork): Adjust.
4804         (new_fork): Delete.
4805         (one_fork_p): New.
4806         (add_fork): Adjust.
4807         (free_fork): Delete, folded into fork_info::~fork_info().
4808         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4809         Adjust.
4810         (init_fork_list): Delete.
4811         (linux_fork_killall, linux_fork_mourn_inferior)
4812         (linux_fork_detach, info_checkpoints_command): Adjust.
4813         (_initialize_linux_fork): No longer call init_fork_list.
4814
4815 2019-03-06  Pedro Alves  <palves@redhat.com>
4816
4817         * linux-fork.c (new_fork): New, split out of ...
4818         (add_fork): ... this.  Return void.  Move "first fork" special
4819         case from here, to ...
4820         (checkpoint_command): ... here.
4821         * linux-linux.h (add_fork): Return void.
4822
4823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4826
4827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4828             Chris January  <chris.january@arm.com>
4829             David Lecomber  <david.lecomber@arm.com>
4830
4831         * f-exp.y: New token, UNOP_INTRINSIC.
4832         (exp): New pattern using UNOP_INTRINSIC token.
4833         (f77_keywords): Add 'abs' keyword.
4834         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4835         (value_from_host_double): New function.
4836         (evaluate_subexp_f): Support UNOP_ABS.
4837
4838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4841         types.
4842
4843 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4846         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4847         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4848
4849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4852
4853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4854             Chris January  <chris.january@arm.com>
4855
4856         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4857         * f-exp.y: Define 'KIND' token.
4858         (exp): New pattern for KIND expressions.
4859         (ptype): Handle types with a kind extension.
4860         (direct_abs_decl): Extend to spot kind extensions.
4861         (f77_keywords): Add 'kind' to the list.
4862         (push_kind_type): New function.
4863         (convert_to_kind_type): New function.
4864         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4865         * parse.c (operator_length_standard): Likewise.
4866         * parser-defs.h (enum type_pieces): Add tp_kind.
4867         * std-operator.def: Add UNOP_KIND.
4868
4869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * f-exp.y (f_parse): Set yydebug.
4872
4873 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * f-lang.c (evaluate_subexp_f): New function.
4876         (exp_descriptor_f): New global.
4877         (f_language_defn): Use exp_descriptor_f instead of
4878         exp_descriptor_standard.
4879
4880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * f-exp.y (struct token): Add comments.
4883         (dot_ops): Remove uppercase versions and the end marker.
4884         (f77_keywords): Likewise.
4885         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4886         entries in the dot_ops array are case insensitive, and use
4887         strncasecmp to compare strings.  Also some whitespace cleanup in
4888         this area.  Similar for the f77_keywords array, except entries in
4889         this list might be case sensitive.
4890
4891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * f-exp.y (struct f77_boolean_val): Add comments.
4894         (boolean_values): Remove uppercase versions, and end marker.
4895         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4896         and use strncasecmp to achieve case insensitivity.  Additionally,
4897         perform whitespace cleanup around this code.
4898
4899 2019-03-06  Tom Tromey  <tromey@adacore.com>
4900
4901         * remote-sim.c (gdbsim_target_open): Use result of
4902         gdb_argv::release.
4903
4904 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4905         Dirk Schubert  <dirk.schubert@arm.com>
4906         Chris January  <chris.january@arm.com>
4907
4908         * eval.c (evaluate_subexp_standard): Call Fortran argument
4909         wrapping logic.
4910         * f-lang.c (struct value): A value which can be passed into a
4911         Fortran function call.
4912         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4913         where appropriate.
4914         (struct type): Value ready for a Fortran function call.
4915         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4916         is needed.
4917         * f-lang.h (fortran_argument_convert): Declaration.
4918         (fortran_preserve_arg_pointer): Declaration.
4919         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4920
4921 2019-03-05  Tom Tromey  <tromey@adacore.com>
4922
4923         * python/py-prettyprint.c (print_string_repr): Remove #if.
4924         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4925
4926 2019-03-05  Tom Tromey  <tromey@adacore.com>
4927
4928         * target.c (the_dummy_target): Move later.  Change type to
4929         "dummy_target".
4930         (initialize_targets): Don't initialize the_dummy_target.
4931
4932 2019-03-05  Tom Tromey  <tromey@adacore.com>
4933
4934         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4935         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4936
4937 2019-03-05  Tom Tromey  <tromey@adacore.com>
4938
4939         * windows-nat.c (windows_nat_target::attach)
4940         (windows_nat_target::detach): Don't call gdb_flush.
4941         * valprint.c (generic_val_print, val_print, val_print_string):
4942         Don't call gdb_flush.
4943         * utils.c (defaulted_query): Don't call gdb_flush.
4944         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4945         * target.c (target_announce_detach): Don't call gdb_flush.
4946         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4947         * remote.c (extended_remote_target::attach): Don't call
4948         gdb_flush.
4949         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4950         * printcmd.c (do_examine): Don't call gdb_flush.
4951         (info_display_command): Don't call gdb_flush.
4952         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4953         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4954         * memattr.c (info_mem_command): Don't call gdb_flush.
4955         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4956         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4957         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4958         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4959         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4960         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4961         (gnu_nat_target::detach): Don't call gdb_flush.
4962         * f-valprint.c (f_val_print): Don't call gdb_flush.
4963         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4964         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4965         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4966         gdb_flush.
4967         * c-valprint.c (c_val_print): Don't call gdb_flush.
4968         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4969
4970 2019-03-05  Tom Tromey  <tromey@adacore.com>
4971
4972         * varobj.c (update_dynamic_varobj_children): Update.
4973         (install_default_visualizer): Use reset, not release.
4974         * value.c (set_internalvar): Update.
4975         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4976         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4977         ATTRIBUTE_UNUSED_RESULT.
4978
4979 2019-03-05  Tom Tromey  <tromey@adacore.com>
4980
4981         * remote.c (class scoped_remote_fd) <release>: Add
4982         ATTRIBUTE_UNUSED_RESULT.
4983
4984 2019-03-05  Tom Tromey  <tromey@adacore.com>
4985
4986         * macroexp.c (struct macro_buffer) <release>: Add
4987         ATTRIBUTE_UNUSED_RESULT.
4988
4989 2019-03-05  Tom Tromey  <tromey@adacore.com>
4990
4991         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4992         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4993         ATTRIBUTE_UNUSED_RESULT.
4994
4995 2019-03-05  Tom Tromey  <tromey@adacore.com>
4996
4997         * common/scoped_fd.h (class scoped_fd) <release>: Add
4998         ATTRIBUTE_UNUSED_RESULT.
4999
5000 2019-03-05  Tom Tromey  <tromey@adacore.com>
5001
5002         * parser-defs.h (struct parser_state) <release>: Add
5003         ATTRIBUTE_UNUSED_RESULT.
5004
5005 2019-03-05  Tom Tromey  <tromey@adacore.com>
5006
5007         * utils.h (class gdb_argv) <release>: Add
5008         ATTRIBUTE_UNUSED_RESULT.
5009         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5010
5011 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5012
5013         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5014         for-loop range, to avoid compiler warnings.
5015
5016         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5017         avoid compiler warnings about unused variables.
5018
5019         * NEWS: Mention end of support for native debugging on MS-Windows
5020         before XP.
5021
5022         PR gdb/24292
5023         * common/netstuff.c:
5024         * gdbserver/gdbreplay.c
5025         * gdbserver/remote-utils.c:
5026         * ser-tcp.c:
5027         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5028         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5029         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5030         'getaddrinfo' and 'freeaddrinfo' were not available before
5031         Windows XP, and mingw.org's MinGW headers by default define
5032         _WIN32_WINNT to 0x500.
5033
5034 2019-03-01  Gary Benson <gbenson@redhat.com>
5035
5036         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5037
5038 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5039             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5040
5041         PR gdb/8527
5042         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5043         set_sigint_trap, clear_sigint_trap.
5044
5045 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5046
5047         * target.c (target_detach): Clear the regcache and the
5048         frame cache.
5049
5050 2019-02-27  Pedro Alves  <palves@redhat.com>
5051
5052         * utils.c (set_screen_size): When we cap the height/width sizes,
5053         tweak the corresponding command variable to show "unlimited":
5054
5055 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5056             Pedro Alves  <palves@redhat.com>
5057
5058         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5059         before calling rl_set_screen_size.
5060
5061 2019-02-27  Tom Tromey  <tromey@adacore.com>
5062
5063         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5064         define.
5065         * python/py-value.c: Remove Python 2.4 workaround.
5066         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5067         workaround.
5068         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5069         Python 2.4 workaround.
5070         * python/python-internal.h: Remove Python 2.4 comment.
5071         (Py_ssize_t): Don't define.
5072         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5073         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5074         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5075         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5076         * python/python.c (do_start_initialization): Remove Python 2.4
5077         workaround.
5078         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5079         (print_children): Remove Python 2.4 workaround.
5080         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5081         workaround.
5082         (CHARBUFFERPROC_NAME): Remove.
5083         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5084         Python 2.4 workaround.
5085
5086 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5087
5088         * NEWS: Note minimum Python version.
5089
5090 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5091
5092         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5093         code from these functions.  Remove corresponding ifdefs.  Use
5094         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5095         Remove gotos and target of gotos.
5096         (infpy_search_memory): Likewise.
5097
5098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5101         (hppa_gdbarch_init): Don't register deleted functions with
5102         gdbarch.
5103
5104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5107         (h8300_unwind_sp): Delete.
5108         (h8300_dummy_id): Delete.
5109         (h8300_gdbarch_init): Don't register deleted functions with
5110         gdbarch.
5111
5112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5115         (ft32_unwind_pc): Delete.
5116         (ft32_unwind_sp): Delete.
5117         (ft32_gdbarch_init): Don't register deleted functions with
5118         gdbarch.
5119
5120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5123         (frv_unwind_pc): Delete.
5124         (frv_unwind_sp): Delete.
5125         (frv_gdbarch_init): Don't register deleted functions with
5126         gdbarch.
5127
5128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5131         (riscv_unwind_pc): Delete.
5132         (riscv_unwind_sp): Delete.
5133         (riscv_gdbarch_init): Don't register deleted functions with
5134         gdbarch.
5135
5136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5139         (csky_unwind_pc): Delete.
5140         (csky_unwind_sp): Delete.
5141         (csky_gdbarch_init): Don't register deleted functions with
5142         gdbarch.
5143
5144 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5147         (cris_unwind_pc): Delete.
5148         (cris_unwind_sp): Delete.
5149         (cris_gdbarch_init): Don't register deleted functions with
5150         gdbarch.
5151
5152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5155         (bfin_unwind_pc): Delete.
5156         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5157
5158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5159
5160         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5161         (arm_unwind_pc): Delete.
5162         (arm_unwind_sp): Delete.
5163         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5164
5165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5168         (arc_unwind_pc): Delete.
5169         (arc_unwind_sp): Delete.
5170         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5171
5172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5175         (alpha_unwind_pc): Delete.
5176         (alpha_gdbarch_init): Don't register deleted functions with
5177         gdbarch.
5178
5179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5182         (aarch64_unwind_pc): Delete.
5183         (aarch64_unwind_sp): Delete.
5184         (aarch64_gdbarch_init): Don't register deleted functions with
5185         gdbarch.
5186
5187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5188
5189         * gdbtypes.c (type_align): Don't consider static members when
5190         computing structure alignment.
5191
5192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5193
5194         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5195         return 0 for other types.
5196         * arch-utils.c (default_type_align): Always return 0.
5197         * gdbarch.h: Regenerate.
5198         * gdbarch.sh (type_align): Extend comment.
5199         * gdbtypes.c (type_align): Add additional comments, always call
5200         gdbarch_type_align before applying the default rules.
5201         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5202         generic code will then apply a suitable default.
5203         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5204         types, return 0 for other types.
5205
5206 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5207
5208         * NEWS: Create a new section for the next release branch.
5209         Rename the section of the current branch, now that it has
5210         been cut.
5211
5212 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5213
5214         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5215         * version.in: Bump version to 8.3.50.DATE-git.
5216
5217 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5218
5219         * aix-thread.c (ptid_cmp): Remove unused variable.
5220         (get_signaled_thread): Likewise.
5221         (store_regs_user_thread): Likewise.
5222         (store_regs_kernel_thread): Likewise.
5223         (fetch_regs_kernel_thread): Remove shadowed variable.
5224
5225 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * features/riscv/32bit-cpu.xml: Add register numbers.
5228         * features/riscv/32bit-fpu.c: Regenerate.
5229         * features/riscv/32bit-fpu.xml: Add register numbers.
5230         * features/riscv/64bit-cpu.xml: Add register numbers.
5231         * features/riscv/64bit-fpu.c: Regenerate.
5232         * features/riscv/64bit-fpu.xml: Add register numbers.
5233
5234 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5235
5236         * NEWS: Mention two argument form of gdb.Value constructor.
5237         * python/py-value.c (convert_buffer_and_type_to_value): New
5238         function.
5239         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5240         Add support for handling an optional second argument.  Call
5241         convert_buffer_and_type_to_value as appropriate.
5242         * python/python-internal.h (Py_buffer_deleter): New struct.
5243         (Py_buffer_up): New typedef.
5244
5245 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5246
5247         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5248         instead of releasing ownership.
5249
5250 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5251
5252         * dwarf2read.c (open_and_init_dwp_file): Call
5253         elf_numsections instead of bfd_count_sections to initialize
5254         dwp_file->num_sections.
5255
5256 2019-02-25  Tom Tromey  <tromey@adacore.com>
5257
5258         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5259
5260 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5261
5262         * gcore.in: Add '--readnever' option when invoking GDB.
5263
5264 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5265
5266         * MAINTAINERS: Update my email address.
5267
5268 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5269
5270         * build-id.c (build_id_to_debug_bfd_1): New function.
5271         (build_id_to_debug_bfd): Look for separate debug file in
5272         sysroot.
5273
5274 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5275
5276         * gdbarch.sh: Update the copyright year range that is placed into
5277         generated files.
5278
5279 2019-02-22  Keith Seitz  <keiths@redhat.com>
5280
5281         PR symtab/23853
5282         * linespec.c (create_sals_line_offset): Search for the default
5283         symtab's filename instead of its fullname.
5284
5285 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5286
5287         * NEWS: Update style defaults.
5288
5289 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5290
5291         * main.c (captured_main_1): Disable styling in batch mode.
5292
5293 2019-02-20  Tom Tromey  <tom@tromey.com>
5294
5295         * symtab.c (symtab_symbol_info): Fix typos.
5296
5297 2019-02-20  Tom Tromey  <tromey@adacore.com>
5298
5299         * findcmd.c (_initialize_mem_search): Use upper case for
5300         metasyntactic variables.
5301
5302 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5303
5304         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5305         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5306
5307 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5308
5309         * top.h (source_file_name): Change to std::string.
5310         * top.c (source_file_name): Likewise.
5311         (command_line_input): Adjust.
5312         * cli/cli-script.c (script_from_file): Adjust.
5313
5314 2019-02-19  Tom Tromey  <tromey@adacore.com>
5315
5316         * ravenscar-thread.c
5317         (ravenscar_thread_target::update_thread_list): Don't call
5318         ada_build_task_list.
5319         * ada-lang.h (ada_build_task_list): Don't declare.
5320         * ada-tasks.c (struct ada_tasks_inferior_data)
5321         <task_list_valid_p>: Now bool.
5322         (read_known_tasks, ada_task_list_changed)
5323         (ada_tasks_invalidate_inferior_data): Update.
5324         (read_known_tasks_array): Return bool.
5325         (read_known_tasks_list): Likewise.
5326         (read_known_tasks): Return void.
5327         (ada_build_task_list): Now static.
5328
5329 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5332         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5333
5334 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5335
5336         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5337         variant for ada_tasks_pspace_data_handle and
5338         ada_tasks_inferior_data_handle.
5339         (ada_tasks_pspace_data_cleanup): New function.
5340         (ada_tasks_inferior_data_cleanup): New function.
5341
5342 2019-02-17  Tom Tromey  <tom@tromey.com>
5343
5344         * macrotab.h (macro_source_fullname): Return a std::string.
5345         * macrotab.c (macro_include, check_for_redefinition)
5346         (macro_undef, macro_lookup_definition, foreach_macro)
5347         (foreach_macro_in_scope): Update.
5348         (macro_source_fullname): Return a std::string.
5349         * macrocmd.c (show_pp_source_pos): Update.
5350
5351 2019-02-17  Tom Tromey  <tom@tromey.com>
5352
5353         * macrocmd.c (show_pp_source_pos): Style the file names.
5354
5355 2019-02-17  Tom Tromey  <tom@tromey.com>
5356
5357         PR tui/24197:
5358         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5359
5360 2019-02-17  Tom Tromey  <tom@tromey.com>
5361
5362         * ada-lang.c (user_select_syms): Use filtered printing.
5363         * utils.c (wrap_style): New global.
5364         (desired_style): Remove.
5365         (emit_style_escape): Add stream parameter.
5366         (set_output_style, reset_terminal_style, prompt_for_continue):
5367         Update.
5368         (flush_wrap_buffer): Only flush gdb_stdout.
5369         (wrap_here): Set wrap_style.
5370         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5371         treat escape sequences as a character.  Change when wrap buffer is
5372         flushed.
5373         (fputs_styled): Do not set the output style when the default is
5374         requested.
5375         * ui-style.h (struct ui_file_style) <is_default>: New method.
5376         * source.c (print_source_lines_base): Emit escape sequences in one
5377         piece.
5378
5379 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5380
5381         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5382         integers and enumeration types.
5383
5384 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5385
5386         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5387         instead of lookup_symbol_in_language
5388         (do_exact_match): New function.
5389         (ada_get_symbol_name_matcher): Return do_exact_match when
5390         doing a verbatim match.
5391
5392 2019-02-15  Tom Tromey  <tromey@adacore.com>
5393
5394         * ravenscar-thread.c (ravenscar_thread_target::resume)
5395         (ravenscar_thread_target::wait): Special case wildcard requests.
5396
5397 2019-02-15  Tom Tromey  <tromey@adacore.com>
5398
5399         * ravenscar-thread.c (base_ptid): Remove.
5400         (struct ravenscar_thread_target) <close>: New method.
5401         <m_base_ptid>: New member.
5402         <update_inferior_ptid, active_task, task_is_currently_active,
5403         runtime_initialized>: Declare methods.
5404         <ravenscar_thread_target>: Add constructor.
5405         (ravenscar_thread_target::task_is_currently_active)
5406         (ravenscar_thread_target::update_inferior_ptid)
5407         (ravenscar_runtime_initialized): Rename.  Now methods.
5408         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5409         (ravenscar_thread_target::update_thread_list): Update.
5410         (ravenscar_thread_target::active_task): Now method.
5411         (ravenscar_thread_target::store_registers)
5412         (ravenscar_thread_target::prepare_to_store)
5413         (ravenscar_thread_target::prepare_to_store)
5414         (ravenscar_thread_target::mourn_inferior): Update.
5415         (ravenscar_inferior_created): Use "new" to create target.
5416         (ravenscar_thread_target::get_ada_task_ptid): Update.
5417         (_initialize_ravenscar): Don't initialize base_ptid.
5418         (ravenscar_ops): Remove global.
5419
5420 2019-02-15  Tom Tromey  <tromey@adacore.com>
5421
5422         * target.h (push_target): Declare new overload.
5423         * target.c (push_target): New overload, taking an rvalue reference.
5424         * remote.c (remote_target::open_1): Use push_target overload.
5425         * corelow.c (core_target_open): Use push_target overload.
5426
5427 2019-02-15  Tom Tromey  <tromey@adacore.com>
5428
5429         * ravenscar-thread.c (is_ravenscar_task)
5430         (ravenscar_task_is_currently_active): Return bool.
5431         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5432         (_initialize_ravenscar): Remove "(void)".
5433         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5434         Return bool.
5435
5436 2019-02-15  Tom Tromey  <tromey@adacore.com>
5437
5438         * ravenscar-thread.c (ravenscar_runtime_initializer)
5439         (has_ravenscar_runtime, get_running_thread_id)
5440         (ravenscar_thread_target::resume): Fix indentation.
5441
5442 2019-02-15  Tom Tromey  <tromey@adacore.com>
5443
5444         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5445         from ravenscar_arch_ops.
5446         (sparc_ravenscar_ops::fetch_registers)
5447         (sparc_ravenscar_ops::store_registers): Now methods.
5448         (sparc_ravenscar_prepare_to_store): Remove.
5449         (sparc_ravenscar_ops): Redefine.
5450         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5451         methods and destructor.  Remove members.
5452         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5453         (ravenscar_thread_target::store_registers)
5454         (ravenscar_thread_target::prepare_to_store): Update.
5455         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5456         Remove.
5457         (struct ppc_ravenscar_powerpc_ops): Derive from
5458         ravenscar_arch_ops.
5459         (ppc_ravenscar_powerpc_ops::fetch_registers)
5460         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5461         (ppc_ravenscar_powerpc_ops): Redefine.
5462         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5463         (ppc_ravenscar_e500_ops::fetch_registers)
5464         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5465         (ppc_ravenscar_e500_ops): Redefine.
5466         * aarch64-ravenscar-thread.c
5467         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5468         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5469         (aarch64_ravenscar_fetch_registers)
5470         (aarch64_ravenscar_store_registers): Now methods.
5471         (aarch64_ravenscar_ops): Redefine.
5472
5473 2019-02-15  Tom Tromey  <tromey@adacore.com>
5474
5475         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5476         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5477         (ravenscar_thread_target::stopped_by_watchpoint)
5478         (ravenscar_thread_target::stopped_data_address)
5479         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5480
5481 2019-02-15  Tom Tromey  <tromey@adacore.com>
5482
5483         * ravenscar-thread.c: Fix some typos.
5484
5485 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5486             Tom Tromey  <tromey@adacore.com>
5487
5488         * ada-lang.c (ada_exception_sal): Change addr_string to a
5489         std::string.
5490         (create_ada_exception_catchpoint): Update.
5491
5492 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5493             Tom Tromey  <tromey@adacore.com>
5494
5495         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5496         (bp_location_ops): Remove.
5497         (base_breakpoint_allocate_location): Update.
5498         (free_bp_location): Update.
5499         * ada-lang.c (class ada_catchpoint_location)
5500         <ada_catchpoint_location>: Remove ops parameter.
5501         (ada_catchpoint_location_dtor): Remove.
5502         (ada_catchpoint_location_ops): Remove.
5503         (allocate_location_exception): Update.
5504         * breakpoint.h (struct bp_location_ops): Remove.
5505         (class bp_location) <bp_location>: Remove bp_location_ops
5506         parameter.
5507         <~bp_location>: Add destructor.
5508         <ops>: Remove.
5509
5510 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5511             Pedro Alves  <palves@redhat.com>
5512
5513         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5514         'PATH_MAX'.
5515
5516 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5517             Samuel Thibault  <samuel.thibault@gnu.org>
5518             Thomas Schwinge  <thomas@codesourcery.com>
5519
5520         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5521         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5522
5523 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5524
5525         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5526         (check_empty): Use "const char *".
5527
5528         * gnu-nat.c (gnu_nat_target::detach): Instead of
5529         'detach_inferior (pid)' call
5530         'detach_inferior (find_inferior_pid (pid))'.
5531
5532         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5533         'nat/fork-inferior.o'.
5534         * gnu-nat.c: #include "nat/fork-inferior.h".
5535
5536         * gnu-nat.c (gnu_nat_target::detach): Instead of
5537         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5538         * gnu-nat.h: #include "inf-child.h".
5539         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5540         'i386_gnu_nat_target::fetch_registers'.
5541         (gnu_store_registers): Rename/move to
5542         'i386_gnu_nat_target::store_registers'.
5543
5544         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5545         * gnu-nat.h (mach_thread_info): New function.
5546         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5547
5548         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5549
5550 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5551
5552         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5553
5554 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5555
5556         * windows-nat.c (windows_add_thread): Add new parameter
5557         "main_thread_p" with default value set to false.  Update
5558         function documentation as well as all callers.
5559         (windows_delete_thread): Likewise.
5560         (fake_create_process): Update call to windows_add_thread.
5561         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5562         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5563         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5564         call to windows_delete_thread.
5565
5566 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5567
5568         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5569
5570 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5571
5572         * symfile.c (find_separate_debug_file): Use canonical path of
5573         sysroot with child_path instead of gdb_sysroot if it is valid.
5574
5575 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5576
5577         * symfile.c (find_separate_debug_file): Use child_path to
5578         determine if an object file is under a sysroot.
5579
5580 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5581
5582         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5583         unittests/child-path-selftests.c.
5584         * common/pathstuff.c (child_path): New function.
5585         * common/pathstuff.h (child_path): New prototype.
5586         * unittests/child-path-selftests.c: New file.
5587
5588 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5589
5590         * symfile.c (find_separate_debug_file): Look for separate debug
5591         files in debug directories under the sysroot.
5592
5593 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5594
5595         * symtab.h (struct minimal_symbol data_p): New const method.
5596         (struct minimal_symbol text_p): Likewise.
5597         * symtab.c (output_source_filename): Use file name style
5598         to print file name.
5599         (print_symbol_info): Likewise.
5600         (print_msymbol_info): Use address style to print addresses.
5601         Use function name style to print executable text symbols.
5602         (expand_symtab_containing_pc): Use data_p.
5603         (find_pc_sect_compunit_symtab): Likewise.
5604
5605 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5606
5607         * breakpoint.c (describe_other_breakpoints): Use address style
5608         to print addresses.
5609         (say_where): Likewise.
5610
5611 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5612
5613         * ada-typeprint.c (print_func_type): Print function name
5614         style to print function name.
5615         * c-typeprint.c (c_print_type_1): Likewise.
5616
5617 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5618
5619         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5620         for execve.
5621
5622 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5623
5624         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5625         type_stack.
5626
5627 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5628
5629         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5630         TYPE_CODE_REF types.
5631
5632 2019-02-08  Jim Wilson  <jimw@sifive.com>
5633
5634         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5635         (riscv_linux_fregset): New.
5636         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5637
5638 2019-02-07  Tom Tromey  <tom@tromey.com>
5639
5640         * thread.c (thread_cancel_execution_command): Update.
5641         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5642         methods.
5643         (struct thread_fsm_ops): Remove.
5644         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5645         (thread_fsm_should_stop, thread_fsm_return_value)
5646         (thread_fsm_set_finished, thread_fsm_finished_p)
5647         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5648         Don't declare.
5649         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5650         * infrun.c (clear_proceed_status_thread)
5651         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5652         (print_stop_event): Update.
5653         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5654         Add constructor.
5655         (step_command_fsm_ops): Remove.
5656         (new_step_command_fsm): Remove.
5657         (step_1): Update.
5658         (step_command_fsm::should_stop): Rename from
5659         step_command_fsm_should_stop.
5660         (step_command_fsm::clean_up): Rename from
5661         step_command_fsm_clean_up.
5662         (step_command_fsm::do_async_reply_reason): Rename from
5663         step_command_fsm_async_reply_reason.
5664         (struct until_next_fsm): Inherit from thread_fsm.  Add
5665         constructor.
5666         (until_next_fsm_ops): Remove.
5667         (new_until_next_fsm): Remove.
5668         (until_next_fsm::should_stop): Rename from
5669         until_next_fsm_should_stop.
5670         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5671         (until_next_fsm::do_async_reply_reason): Rename from
5672         until_next_fsm_async_reply_reason.
5673         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5674         constructor.  Change type of breakpoint.
5675         (finish_command_fsm_ops): Remove.
5676         (new_finish_command_fsm): Remove.
5677         (finish_command_fsm::should_stop): Rename from
5678         finish_command_fsm_should_stop.
5679         (finish_command_fsm::clean_up): Rename from
5680         finish_command_fsm_clean_up.
5681         (finish_command_fsm::return_value): Rename from
5682         finish_command_fsm_return_value.
5683         (finish_command_fsm::do_async_reply_reason): Rename from
5684         finish_command_fsm_async_reply_reason.
5685         (finish_command): Update.
5686         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5687         Add constructor.
5688         (call_thread_fsm_ops): Remove.
5689         (call_thread_fsm::call_thread_fsm): Rename from
5690         new_call_thread_fsm.
5691         (call_thread_fsm::should_stop): Rename from
5692         call_thread_fsm_should_stop.
5693         (call_thread_fsm::should_notify_stop): Rename from
5694         call_thread_fsm_should_notify_stop.
5695         (run_inferior_call, call_function_by_hand_dummy): Update.
5696         * cli/cli-interp.c (should_print_stop_to_console): Update.
5697         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5698         Add constructor.  Change type of location_breakpoint,
5699         caller_breakpoint.
5700         (until_break_fsm_ops): Remove.
5701         (new_until_break_fsm): Remove.
5702         (until_break_fsm::should_stop): Rename from
5703         until_break_fsm_should_stop.
5704         (until_break_fsm::clean_up): Rename from
5705         until_break_fsm_clean_up.
5706         (until_break_fsm::do_async_reply_reason): Rename from
5707         until_break_fsm_async_reply_reason.
5708         (until_break_command): Update.
5709         * thread-fsm.c: Remove.
5710         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5711
5712 2019-02-07  Tom Tromey  <tom@tromey.com>
5713
5714         * yy-remap.h: Add include guard.
5715         * xtensa-tdep.h: Add include guard.
5716         * xcoffread.h: Rename include guard.
5717         * varobj-iter.h: Add include guard.
5718         * tui/tui.h: Rename include guard.
5719         * tui/tui-winsource.h: Rename include guard.
5720         * tui/tui-wingeneral.h: Rename include guard.
5721         * tui/tui-windata.h: Rename include guard.
5722         * tui/tui-win.h: Rename include guard.
5723         * tui/tui-stack.h: Rename include guard.
5724         * tui/tui-source.h: Rename include guard.
5725         * tui/tui-regs.h: Rename include guard.
5726         * tui/tui-out.h: Rename include guard.
5727         * tui/tui-layout.h: Rename include guard.
5728         * tui/tui-io.h: Rename include guard.
5729         * tui/tui-hooks.h: Rename include guard.
5730         * tui/tui-file.h: Rename include guard.
5731         * tui/tui-disasm.h: Rename include guard.
5732         * tui/tui-data.h: Rename include guard.
5733         * tui/tui-command.h: Rename include guard.
5734         * tic6x-tdep.h: Add include guard.
5735         * target/waitstatus.h: Rename include guard.
5736         * target/wait.h: Rename include guard.
5737         * target/target.h: Rename include guard.
5738         * target/resume.h: Rename include guard.
5739         * target-float.h: Rename include guard.
5740         * stabsread.h: Add include guard.
5741         * rs6000-tdep.h: Add include guard.
5742         * riscv-fbsd-tdep.h: Add include guard.
5743         * regformats/regdef.h: Rename include guard.
5744         * record.h: Rename include guard.
5745         * python/python.h: Rename include guard.
5746         * python/python-internal.h: Rename include guard.
5747         * python/py-stopevent.h: Rename include guard.
5748         * python/py-ref.h: Rename include guard.
5749         * python/py-record.h: Rename include guard.
5750         * python/py-record-full.h: Rename include guard.
5751         * python/py-record-btrace.h: Rename include guard.
5752         * python/py-instruction.h: Rename include guard.
5753         * python/py-events.h: Rename include guard.
5754         * python/py-event.h: Rename include guard.
5755         * procfs.h: Add include guard.
5756         * proc-utils.h: Add include guard.
5757         * p-lang.h: Add include guard.
5758         * or1k-tdep.h: Rename include guard.
5759         * observable.h: Rename include guard.
5760         * nto-tdep.h: Rename include guard.
5761         * nat/x86-linux.h: Rename include guard.
5762         * nat/x86-linux-dregs.h: Rename include guard.
5763         * nat/x86-gcc-cpuid.h: Add include guard.
5764         * nat/x86-dregs.h: Rename include guard.
5765         * nat/x86-cpuid.h: Rename include guard.
5766         * nat/ppc-linux.h: Rename include guard.
5767         * nat/mips-linux-watch.h: Rename include guard.
5768         * nat/linux-waitpid.h: Rename include guard.
5769         * nat/linux-ptrace.h: Rename include guard.
5770         * nat/linux-procfs.h: Rename include guard.
5771         * nat/linux-osdata.h: Rename include guard.
5772         * nat/linux-nat.h: Rename include guard.
5773         * nat/linux-namespaces.h: Rename include guard.
5774         * nat/linux-btrace.h: Rename include guard.
5775         * nat/glibc_thread_db.h: Rename include guard.
5776         * nat/gdb_thread_db.h: Rename include guard.
5777         * nat/gdb_ptrace.h: Rename include guard.
5778         * nat/fork-inferior.h: Rename include guard.
5779         * nat/amd64-linux-siginfo.h: Rename include guard.
5780         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5781         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5782         * nat/aarch64-linux.h: Rename include guard.
5783         * nat/aarch64-linux-hw-point.h: Rename include guard.
5784         * mn10300-tdep.h: Add include guard.
5785         * mips-linux-tdep.h: Add include guard.
5786         * mi/mi-parse.h: Rename include guard.
5787         * mi/mi-out.h: Rename include guard.
5788         * mi/mi-main.h: Rename include guard.
5789         * mi/mi-interp.h: Rename include guard.
5790         * mi/mi-getopt.h: Rename include guard.
5791         * mi/mi-console.h: Rename include guard.
5792         * mi/mi-common.h: Rename include guard.
5793         * mi/mi-cmds.h: Rename include guard.
5794         * mi/mi-cmd-break.h: Rename include guard.
5795         * m2-lang.h: Add include guard.
5796         * location.h: Rename include guard.
5797         * linux-record.h: Rename include guard.
5798         * linux-nat.h: Add include guard.
5799         * linux-fork.h: Add include guard.
5800         * i386-darwin-tdep.h: Rename include guard.
5801         * hppa-linux-offsets.h: Add include guard.
5802         * guile/guile.h: Rename include guard.
5803         * guile/guile-internal.h: Rename include guard.
5804         * gnu-nat.h: Rename include guard.
5805         * gdb-stabs.h: Rename include guard.
5806         * frv-tdep.h: Add include guard.
5807         * f-lang.h: Add include guard.
5808         * event-loop.h: Add include guard.
5809         * darwin-nat.h: Rename include guard.
5810         * cp-abi.h: Rename include guard.
5811         * config/sparc/nm-sol2.h: Rename include guard.
5812         * config/nm-nto.h: Rename include guard.
5813         * config/nm-linux.h: Add include guard.
5814         * config/i386/nm-i386gnu.h: Rename include guard.
5815         * config/djgpp/nl_types.h: Rename include guard.
5816         * config/djgpp/langinfo.h: Rename include guard.
5817         * compile/gcc-cp-plugin.h: Add include guard.
5818         * compile/gcc-c-plugin.h: Add include guard.
5819         * compile/compile.h: Rename include guard.
5820         * compile/compile-object-run.h: Rename include guard.
5821         * compile/compile-object-load.h: Rename include guard.
5822         * compile/compile-internal.h: Rename include guard.
5823         * compile/compile-cplus.h: Rename include guard.
5824         * compile/compile-c.h: Rename include guard.
5825         * common/xml-utils.h: Rename include guard.
5826         * common/x86-xstate.h: Rename include guard.
5827         * common/version.h: Rename include guard.
5828         * common/vec.h: Rename include guard.
5829         * common/tdesc.h: Rename include guard.
5830         * common/selftest.h: Rename include guard.
5831         * common/scoped_restore.h: Rename include guard.
5832         * common/scoped_mmap.h: Rename include guard.
5833         * common/scoped_fd.h: Rename include guard.
5834         * common/safe-iterator.h: Rename include guard.
5835         * common/run-time-clock.h: Rename include guard.
5836         * common/refcounted-object.h: Rename include guard.
5837         * common/queue.h: Rename include guard.
5838         * common/ptid.h: Rename include guard.
5839         * common/print-utils.h: Rename include guard.
5840         * common/preprocessor.h: Rename include guard.
5841         * common/pathstuff.h: Rename include guard.
5842         * common/observable.h: Rename include guard.
5843         * common/netstuff.h: Rename include guard.
5844         * common/job-control.h: Rename include guard.
5845         * common/host-defs.h: Rename include guard.
5846         * common/gdb_wait.h: Rename include guard.
5847         * common/gdb_vecs.h: Rename include guard.
5848         * common/gdb_unlinker.h: Rename include guard.
5849         * common/gdb_unique_ptr.h: Rename include guard.
5850         * common/gdb_tilde_expand.h: Rename include guard.
5851         * common/gdb_sys_time.h: Rename include guard.
5852         * common/gdb_string_view.h: Rename include guard.
5853         * common/gdb_splay_tree.h: Rename include guard.
5854         * common/gdb_setjmp.h: Rename include guard.
5855         * common/gdb_ref_ptr.h: Rename include guard.
5856         * common/gdb_optional.h: Rename include guard.
5857         * common/gdb_locale.h: Rename include guard.
5858         * common/gdb_assert.h: Rename include guard.
5859         * common/filtered-iterator.h: Rename include guard.
5860         * common/filestuff.h: Rename include guard.
5861         * common/fileio.h: Rename include guard.
5862         * common/environ.h: Rename include guard.
5863         * common/common-utils.h: Rename include guard.
5864         * common/common-types.h: Rename include guard.
5865         * common/common-regcache.h: Rename include guard.
5866         * common/common-inferior.h: Rename include guard.
5867         * common/common-gdbthread.h: Rename include guard.
5868         * common/common-exceptions.h: Rename include guard.
5869         * common/common-defs.h: Rename include guard.
5870         * common/common-debug.h: Rename include guard.
5871         * common/cleanups.h: Rename include guard.
5872         * common/buffer.h: Rename include guard.
5873         * common/btrace-common.h: Rename include guard.
5874         * common/break-common.h: Rename include guard.
5875         * cli/cli-utils.h: Rename include guard.
5876         * cli/cli-style.h: Rename include guard.
5877         * cli/cli-setshow.h: Rename include guard.
5878         * cli/cli-script.h: Rename include guard.
5879         * cli/cli-interp.h: Rename include guard.
5880         * cli/cli-decode.h: Rename include guard.
5881         * cli/cli-cmds.h: Rename include guard.
5882         * charset-list.h: Add include guard.
5883         * buildsym-legacy.h: Rename include guard.
5884         * bfin-tdep.h: Add include guard.
5885         * ax.h: Rename include guard.
5886         * arm-linux-tdep.h: Add include guard.
5887         * arm-fbsd-tdep.h: Add include guard.
5888         * arch/xtensa.h: Rename include guard.
5889         * arch/tic6x.h: Add include guard.
5890         * arch/i386.h: Add include guard.
5891         * arch/arm.h: Rename include guard.
5892         * arch/arm-linux.h: Rename include guard.
5893         * arch/arm-get-next-pcs.h: Rename include guard.
5894         * arch/amd64.h: Add include guard.
5895         * arch/aarch64-insn.h: Rename include guard.
5896         * arch-utils.h: Rename include guard.
5897         * annotate.h: Add include guard.
5898         * amd64-darwin-tdep.h: Rename include guard.
5899         * aarch64-linux-tdep.h: Add include guard.
5900         * aarch64-fbsd-tdep.h: Add include guard.
5901         * aarch32-linux-nat.h: Add include guard.
5902
5903 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5904
5905         * macrotab.c (macro_define_internal): New function that
5906         factorizes macro_define_object_internal and macro_define_function
5907         code.
5908         (macro_define_object_internal): Use macro_define_internal.
5909         (macro_define_function): Likewise.
5910
5911 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5912
5913         * macrocmd.c (extract_identifier): Return
5914         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5915         callers.
5916
5917 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5918
5919         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5920
5921 2019-02-05  Tom Tromey  <tom@tromey.com>
5922
5923         * target.c (target_stack::unpush): Move assertion earlier.
5924
5925 2019-01-30  Tom Tromey  <tom@tromey.com>
5926
5927         PR python/23615:
5928         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5929         (gdbpy_parse_and_eval): Likewise.
5930         * python/python-internal.h (gdbpy_allow_threads): New class.
5931
5932 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5933
5934         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5935         (aarch64_fbsd_fpregmap): Move earlier.
5936         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5937         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5938         instead of individual calls to trad_frame_set_reg_addr.
5939         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5940         earlier.
5941         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5942         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5943         instead of individual calls to trad_frame_set_reg_addr.
5944
5945 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5946
5947         * CONTRIBUTE: Replace contribution list with wiki link.
5948
5949 2019-01-25  Tom Tromey  <tom@tromey.com>
5950
5951         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5952
5953 2019-01-25  Tom Tromey  <tom@tromey.com>
5954
5955         * xtensa-linux-nat.c: Fix common/ includes.
5956         * xml-support.h: Fix common/ includes.
5957         * xml-support.c: Fix common/ includes.
5958         * x86-linux-nat.c: Fix common/ includes.
5959         * windows-nat.c: Fix common/ includes.
5960         * varobj.h: Fix common/ includes.
5961         * varobj.c: Fix common/ includes.
5962         * value.c: Fix common/ includes.
5963         * valops.c: Fix common/ includes.
5964         * utils.c: Fix common/ includes.
5965         * unittests/xml-utils-selftests.c: Fix common/ includes.
5966         * unittests/utils-selftests.c: Fix common/ includes.
5967         * unittests/unpack-selftests.c: Fix common/ includes.
5968         * unittests/tracepoint-selftests.c: Fix common/ includes.
5969         * unittests/style-selftests.c: Fix common/ includes.
5970         * unittests/string_view-selftests.c: Fix common/ includes.
5971         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5972         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5973         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5974         * unittests/rsp-low-selftests.c: Fix common/ includes.
5975         * unittests/parse-connection-spec-selftests.c: Fix common/
5976         includes.
5977         * unittests/optional-selftests.c: Fix common/ includes.
5978         * unittests/offset-type-selftests.c: Fix common/ includes.
5979         * unittests/observable-selftests.c: Fix common/ includes.
5980         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5981         * unittests/memrange-selftests.c: Fix common/ includes.
5982         * unittests/memory-map-selftests.c: Fix common/ includes.
5983         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5984         * unittests/function-view-selftests.c: Fix common/ includes.
5985         * unittests/environ-selftests.c: Fix common/ includes.
5986         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5987         * unittests/common-utils-selftests.c: Fix common/ includes.
5988         * unittests/cli-utils-selftests.c: Fix common/ includes.
5989         * unittests/array-view-selftests.c: Fix common/ includes.
5990         * ui-file.c: Fix common/ includes.
5991         * tui/tui-io.c: Fix common/ includes.
5992         * tracepoint.h: Fix common/ includes.
5993         * tracepoint.c: Fix common/ includes.
5994         * tracefile-tfile.c: Fix common/ includes.
5995         * top.h: Fix common/ includes.
5996         * top.c: Fix common/ includes.
5997         * thread.c: Fix common/ includes.
5998         * target/waitstatus.h: Fix common/ includes.
5999         * target/waitstatus.c: Fix common/ includes.
6000         * target.h: Fix common/ includes.
6001         * target.c: Fix common/ includes.
6002         * target-memory.c: Fix common/ includes.
6003         * target-descriptions.c: Fix common/ includes.
6004         * symtab.h: Fix common/ includes.
6005         * symfile.c: Fix common/ includes.
6006         * stap-probe.c: Fix common/ includes.
6007         * spu-linux-nat.c: Fix common/ includes.
6008         * sparc-nat.c: Fix common/ includes.
6009         * source.c: Fix common/ includes.
6010         * solib.c: Fix common/ includes.
6011         * solib-target.c: Fix common/ includes.
6012         * ser-unix.c: Fix common/ includes.
6013         * ser-tcp.c: Fix common/ includes.
6014         * ser-pipe.c: Fix common/ includes.
6015         * ser-base.c: Fix common/ includes.
6016         * selftest-arch.c: Fix common/ includes.
6017         * s12z-tdep.c: Fix common/ includes.
6018         * rust-exp.y: Fix common/ includes.
6019         * rs6000-aix-tdep.c: Fix common/ includes.
6020         * riscv-tdep.c: Fix common/ includes.
6021         * remote.c: Fix common/ includes.
6022         * remote-notif.h: Fix common/ includes.
6023         * remote-fileio.h: Fix common/ includes.
6024         * remote-fileio.c: Fix common/ includes.
6025         * regcache.h: Fix common/ includes.
6026         * regcache.c: Fix common/ includes.
6027         * record-btrace.c: Fix common/ includes.
6028         * python/python.c: Fix common/ includes.
6029         * python/py-type.c: Fix common/ includes.
6030         * python/py-inferior.c: Fix common/ includes.
6031         * progspace.h: Fix common/ includes.
6032         * producer.c: Fix common/ includes.
6033         * procfs.c: Fix common/ includes.
6034         * proc-api.c: Fix common/ includes.
6035         * printcmd.c: Fix common/ includes.
6036         * ppc-linux-nat.c: Fix common/ includes.
6037         * parser-defs.h: Fix common/ includes.
6038         * osdata.c: Fix common/ includes.
6039         * obsd-nat.c: Fix common/ includes.
6040         * nat/x86-linux.c: Fix common/ includes.
6041         * nat/x86-linux-dregs.c: Fix common/ includes.
6042         * nat/x86-dregs.h: Fix common/ includes.
6043         * nat/x86-dregs.c: Fix common/ includes.
6044         * nat/ppc-linux.c: Fix common/ includes.
6045         * nat/mips-linux-watch.h: Fix common/ includes.
6046         * nat/mips-linux-watch.c: Fix common/ includes.
6047         * nat/linux-waitpid.c: Fix common/ includes.
6048         * nat/linux-ptrace.h: Fix common/ includes.
6049         * nat/linux-ptrace.c: Fix common/ includes.
6050         * nat/linux-procfs.c: Fix common/ includes.
6051         * nat/linux-personality.c: Fix common/ includes.
6052         * nat/linux-osdata.c: Fix common/ includes.
6053         * nat/linux-namespaces.c: Fix common/ includes.
6054         * nat/linux-btrace.h: Fix common/ includes.
6055         * nat/linux-btrace.c: Fix common/ includes.
6056         * nat/fork-inferior.c: Fix common/ includes.
6057         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6058         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6059         * nat/aarch64-linux.c: Fix common/ includes.
6060         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6061         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6062         * namespace.h: Fix common/ includes.
6063         * mips-linux-tdep.c: Fix common/ includes.
6064         * minsyms.c: Fix common/ includes.
6065         * mi/mi-parse.h: Fix common/ includes.
6066         * mi/mi-main.c: Fix common/ includes.
6067         * mi/mi-cmd-env.c: Fix common/ includes.
6068         * memrange.h: Fix common/ includes.
6069         * memattr.c: Fix common/ includes.
6070         * maint.h: Fix common/ includes.
6071         * maint.c: Fix common/ includes.
6072         * main.c: Fix common/ includes.
6073         * machoread.c: Fix common/ includes.
6074         * location.c: Fix common/ includes.
6075         * linux-thread-db.c: Fix common/ includes.
6076         * linux-nat.c: Fix common/ includes.
6077         * linux-fork.c: Fix common/ includes.
6078         * inline-frame.c: Fix common/ includes.
6079         * infrun.c: Fix common/ includes.
6080         * inflow.c: Fix common/ includes.
6081         * inferior.h: Fix common/ includes.
6082         * inferior.c: Fix common/ includes.
6083         * infcmd.c: Fix common/ includes.
6084         * inf-ptrace.c: Fix common/ includes.
6085         * inf-child.c: Fix common/ includes.
6086         * ia64-linux-nat.c: Fix common/ includes.
6087         * i387-tdep.c: Fix common/ includes.
6088         * i386-tdep.c: Fix common/ includes.
6089         * i386-linux-tdep.c: Fix common/ includes.
6090         * i386-linux-nat.c: Fix common/ includes.
6091         * i386-go32-tdep.c: Fix common/ includes.
6092         * i386-fbsd-tdep.c: Fix common/ includes.
6093         * i386-fbsd-nat.c: Fix common/ includes.
6094         * guile/scm-type.c: Fix common/ includes.
6095         * guile/guile.c: Fix common/ includes.
6096         * go32-nat.c: Fix common/ includes.
6097         * gnu-nat.c: Fix common/ includes.
6098         * gdbthread.h: Fix common/ includes.
6099         * gdbarch-selftests.c: Fix common/ includes.
6100         * gdb_usleep.c: Fix common/ includes.
6101         * gdb_select.h: Fix common/ includes.
6102         * gdb_bfd.c: Fix common/ includes.
6103         * gcore.c: Fix common/ includes.
6104         * fork-child.c: Fix common/ includes.
6105         * findvar.c: Fix common/ includes.
6106         * fbsd-nat.c: Fix common/ includes.
6107         * event-top.c: Fix common/ includes.
6108         * event-loop.c: Fix common/ includes.
6109         * dwarf2read.c: Fix common/ includes.
6110         * dwarf2loc.c: Fix common/ includes.
6111         * dwarf2-frame.c: Fix common/ includes.
6112         * dwarf-index-cache.c: Fix common/ includes.
6113         * dtrace-probe.c: Fix common/ includes.
6114         * disasm-selftests.c: Fix common/ includes.
6115         * defs.h: Fix common/ includes.
6116         * csky-tdep.c: Fix common/ includes.
6117         * cp-valprint.c: Fix common/ includes.
6118         * cp-support.h: Fix common/ includes.
6119         * cp-support.c: Fix common/ includes.
6120         * corelow.c: Fix common/ includes.
6121         * completer.h: Fix common/ includes.
6122         * completer.c: Fix common/ includes.
6123         * compile/compile.c: Fix common/ includes.
6124         * compile/compile-loc2c.c: Fix common/ includes.
6125         * compile/compile-cplus-types.c: Fix common/ includes.
6126         * compile/compile-cplus-symbols.c: Fix common/ includes.
6127         * command.h: Fix common/ includes.
6128         * cli/cli-dump.c: Fix common/ includes.
6129         * cli/cli-cmds.c: Fix common/ includes.
6130         * charset.c: Fix common/ includes.
6131         * build-id.c: Fix common/ includes.
6132         * btrace.h: Fix common/ includes.
6133         * btrace.c: Fix common/ includes.
6134         * breakpoint.h: Fix common/ includes.
6135         * breakpoint.c: Fix common/ includes.
6136         * ax.h:
6137         (enum agent_op): Fix common/ includes.
6138         * ax-general.c (struct aop_map): Fix common/ includes.
6139         * ax-gdb.c: Fix common/ includes.
6140         * auxv.c: Fix common/ includes.
6141         * auto-load.c: Fix common/ includes.
6142         * arm-tdep.c: Fix common/ includes.
6143         * arch/riscv.c: Fix common/ includes.
6144         * arch/ppc-linux-common.c: Fix common/ includes.
6145         * arch/i386.c: Fix common/ includes.
6146         * arch/arm.c: Fix common/ includes.
6147         * arch/arm-linux.c: Fix common/ includes.
6148         * arch/arm-get-next-pcs.c: Fix common/ includes.
6149         * arch/amd64.c: Fix common/ includes.
6150         * arch/aarch64.c: Fix common/ includes.
6151         * arch/aarch64-insn.c: Fix common/ includes.
6152         * arch-utils.c: Fix common/ includes.
6153         * amd64-windows-tdep.c: Fix common/ includes.
6154         * amd64-tdep.c: Fix common/ includes.
6155         * amd64-sol2-tdep.c: Fix common/ includes.
6156         * amd64-obsd-tdep.c: Fix common/ includes.
6157         * amd64-nbsd-tdep.c: Fix common/ includes.
6158         * amd64-linux-tdep.c: Fix common/ includes.
6159         * amd64-linux-nat.c: Fix common/ includes.
6160         * amd64-fbsd-tdep.c: Fix common/ includes.
6161         * amd64-fbsd-nat.c: Fix common/ includes.
6162         * amd64-dicos-tdep.c: Fix common/ includes.
6163         * amd64-darwin-tdep.c: Fix common/ includes.
6164         * agent.c: Fix common/ includes.
6165         * ada-lang.h: Fix common/ includes.
6166         * ada-lang.c: Fix common/ includes.
6167         * aarch64-tdep.c: Fix common/ includes.
6168
6169 2019-01-25  Tom Tromey  <tom@tromey.com>
6170
6171         * common/create-version.sh: Use common/version.h.
6172
6173 2019-01-24  Pedro Alves  <palves@redhat.com>
6174
6175         * infrun.c (signal_stop, signal_print, signal_program)
6176         (signal_catch, signal_pass): Now arrays instead of pointers.
6177         (update_signals_program_target, do_target_resume)
6178         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6179         * linux-nat.c (linux_nat_target::pass_signals)
6180         (linux_nat_target::create_inferior, linux_nat_target::attach):
6181         Adjust.
6182         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6183         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6184         * procfs.c (procfs_target::pass_signals): Adjust.
6185         * record-full.c (record_full_target::resume): Adjust.
6186         * remote.c (remote_target::pass_signals)
6187         (remote_target::program_signals): Adjust.
6188         * target-debug.h (target_debug_print_signals): Now takes a
6189         gdb::array_view as parameter.  Adjust.
6190         * target.h (target_ops) <pass_signals, program_signals>: Replace
6191         pointer and length parameters with gdb::array_view.
6192         (target_pass_signals, target_program_signals): Likewise.
6193         * target-delegates.c: Regenerate.
6194
6195 2019-01-24  Pedro Alves  <palves@redhat.com>
6196
6197         * common/forward-scope-exit.h
6198         (forward_scope_exit::forward_scope_exit): Pass arguments to
6199         m_bind_function directly, instead of creating a std::bind and
6200         copying that.
6201
6202 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6203
6204         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6205         for static members.
6206         (pass_in_v_vfp_candidate): Likewise.
6207
6208 2019-01-23  Tom Tromey  <tom@tromey.com>
6209             Pedro Alves  <palves@redhat.com>
6210
6211         * regcache.c (class regcache_invalidator): Remove.
6212         (regcache::raw_write): Use make_scope_exit.
6213
6214 2019-01-23  Tom Tromey  <tom@tromey.com>
6215
6216         * ui-out.h (class ui_out_emit_type): Update comment.
6217
6218 2019-01-23  Tom Tromey  <tom@tromey.com>
6219
6220         * infrun.c (fetch_inferior_event): Update comment.
6221
6222 2019-01-23  Tom Tromey  <tom@tromey.com>
6223             Pedro Alves  <palves@redhat.com>
6224
6225         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6226         parameter.
6227         (fetch_inferior_event): Use SCOPE_EXIT.
6228
6229
6230 2019-01-23  Tom Tromey  <tom@tromey.com>
6231             Pedro Alves  <palves@redhat.com>
6232
6233         * infrun.c (disable_thread_events): Delete.
6234         (stop_all_threads): Use SCOPE_EXIT.
6235
6236 2019-01-23  Tom Tromey  <tom@tromey.com>
6237             Pedro Alves  <palves@redhat.com>
6238
6239         * symfile.c: Include forward-scope-exit.h.
6240         (clear_symtab_users_cleanup): Replace forward declaration with
6241         a FORWARD_SCOPE_EXIT.
6242         (syms_from_objfile_1): Use the forward_scope_exit and
6243         gdb::optional instead of cleanup_function.
6244         (reread_symbols): Use the forward_scope_exit instead of
6245         cleanup_function.
6246         (clear_symtab_users_cleanup): Remove function.
6247
6248 2019-01-23  Tom Tromey  <tom@tromey.com>
6249             Pedro Alves  <palves@redhat.com>
6250
6251         * linux-nat.c: Include scope-exit.h.
6252         (cleanup_target_stop): Remove.
6253         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6254         SCOPE_EXIT.
6255
6256 2019-01-23  Tom Tromey  <tom@tromey.com>
6257             Pedro Alves  <palves@redhat.com>
6258
6259         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6260         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6261
6262 2019-01-23  Tom Tromey  <tom@tromey.com>
6263             Andrew Burgess  <andrew.burgess@embecosm.com>
6264             Pedro Alves  <palves@redhat.com>
6265
6266         * infrun.c (fetch_inferior_event): Use scope_exit.
6267         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6268         * top.c (execute_command): Use scope_exit.
6269         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6270         * utils.c (do_bpstat_clear_actions_cleanup)
6271         (make_bpstat_clear_actions_cleanup): Remove.
6272
6273 2019-01-23  Tom Tromey  <tom@tromey.com>
6274             Pedro Alves  <palves@redhat.com>
6275
6276         * infrun.c: Include "common/scope-exit.h"
6277         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6278         (wait_for_inferior): Use SCOPE_EXIT.
6279         (fetch_inferior_event): Use scope_exit.
6280
6281 2019-01-23  Tom Tromey  <tom@tromey.com>
6282             Pedro Alves  <palves@redhat.com>
6283
6284         * breakpoint.c (create_breakpoint): Remove cleanup.
6285
6286 2019-01-23  Tom Tromey  <tom@tromey.com>
6287             Andrew Burgess  <andrew.burgess@embecosm.com>
6288             Pedro Alves  <palves@redhat.com>
6289
6290 2019-01-23  Pedro Alves  <palves@redhat.com>
6291
6292         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6293
6294 2019-01-23  Pedro Alves  <palves@redhat.com>
6295             Andrew Burgess  <andrew.burgess@embecosm.com>
6296
6297         * gdbthread.h: Include "common/forward-scope-exit.h".
6298         (scoped_finish_thread_state): Redefine custom class in terms of
6299         forward_scope_exit.
6300
6301 2019-01-23  Pedro Alves  <palves@redhat.com>
6302             Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * common/forward-scope-exit.h: New file.
6305
6306 2019-01-23  Pedro Alves  <palves@redhat.com>
6307             Andrew Burgess  <andrew.burgess@embecosm.com>
6308             Tom Tromey  <tom@tromey.com>
6309
6310         * common/scope-exit.h: New file.
6311
6312 2019-01-23  Pedro Alves  <palves@redhat.com>
6313
6314         * common/preprocessor.h (ESC): Rename to ...
6315         (ESC_PARENS): ... this.
6316         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6317         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6318
6319 2019-01-23  Tom Tromey  <tom@tromey.com>
6320
6321         * language.h (class scoped_switch_to_sym_language_if_auto):
6322         Initialize m_lang in both cases.
6323
6324 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6325
6326         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6327         with XCNEW.
6328
6329 2019-01-22  Tom Tromey  <tom@tromey.com>
6330
6331         * corelow.c: Do not include sys/file.h.
6332
6333 2019-01-22  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-wingeneral.h: Include gdb_curses.h.
6336
6337 2019-01-22  Tom Tromey  <tom@tromey.com>
6338
6339         * source-cache.h (class source_cache) <get_source_lines,
6340         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6341
6342 2019-01-22  Tom Tromey  <tom@tromey.com>
6343
6344         * remote-fileio.h (struct remote_target): Declare.
6345
6346 2019-01-22  Tom Tromey  <tom@tromey.com>
6347
6348         * python/py-arch.c: Do not include py-ref.h.
6349         * python/py-bpevent.c: Do not include py-ref.h.
6350         * python/py-cmd.c: Do not include py-ref.h.
6351         * python/py-continueevent.c: Do not include py-ref.h.
6352         * python/py-event.h: Do not include py-ref.h.
6353         * python/py-evtregistry.c: Do not include py-ref.h.
6354         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6355         * python/py-frame.c: Do not include py-ref.h.
6356         * python/py-framefilter.c: Do not include py-ref.h.
6357         * python/py-function.c: Do not include py-ref.h.
6358         * python/py-infevents.c: Do not include py-ref.h.
6359         * python/py-linetable.c: Do not include py-ref.h.
6360         * python/py-objfile.c: Do not include py-ref.h.
6361         * python/py-param.c: Do not include py-ref.h.
6362         * python/py-prettyprint.c: Do not include py-ref.h.
6363         * python/py-progspace.c: Do not include py-ref.h.
6364         * python/py-symbol.c: Do not include py-ref.h.
6365         * python/py-symtab.c: Do not include py-ref.h.
6366         * python/py-type.c: Do not include py-ref.h.
6367         * python/py-unwind.c: Do not include py-ref.h.
6368         * python/py-utils.c: Do not include py-ref.h.
6369         * python/py-value.c: Do not include py-ref.h.
6370         * python/py-varobj.c: Do not include py-ref.h.
6371         * python/py-xmethods.c: Do not include py-ref.h.
6372         * python/python.c: Do not include py-ref.h.
6373         * varobj.c: Do not include py-ref.h.
6374
6375 2019-01-22  Tom Tromey  <tom@tromey.com>
6376
6377         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6378         keyword for bcache.
6379
6380 2019-01-22  Tom Tromey  <tom@tromey.com>
6381
6382         * compile/compile-cplus-types.c: Remove a comment by #include.
6383
6384 2019-01-22  Tom Tromey  <tom@tromey.com>
6385
6386         * compile/gcc-c-plugin.h: Include compile-internal.h.
6387
6388 2019-01-22  Tom Tromey  <tom@tromey.com>
6389
6390         * stabsread.c (EXTERN): Do not define.
6391         (symnum, next_symbol_text_func, processing_gcc_compilation)
6392         (within_function, global_sym_chain, global_stabs)
6393         (previous_stab_code, this_object_header_files)
6394         (n_this_object_header_files)
6395         (n_allocated_this_object_header_files): Define.
6396         * stabsread.h (EXTERN): Never define.  Use "extern".
6397
6398 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6399
6400         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6401         history_value.
6402
6403 2019-01-21  Tom Tromey  <tom@tromey.com>
6404
6405         * ui-out.c: Fix includes.
6406         * tui/tui-source.c: Fix includes.
6407         * target.c: Fix includes.
6408         * remote.c: Fix includes.
6409         * regcache.c: Fix includes.
6410         * python/py-block.c: Fix includes.
6411         * printcmd.c: Fix includes.
6412         * or1k-tdep.c: Fix includes.
6413         * mi/mi-main.c: Fix includes.
6414         * m32r-tdep.c: Fix includes.
6415         * csky-tdep.c: Fix includes.
6416         * compile/compile-cplus-types.c: Fix includes.
6417         * cli/cli-interp.c: Fix includes.
6418
6419 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6420
6421         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6422         for padding.
6423
6424 2019-01-16  Tom Tromey  <tom@tromey.com>
6425
6426         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6427         earlier.
6428         (struct objfile) <msymbols_range>: Move from top level.
6429         <msymbols>: New method.
6430         (class objfile_msymbols): Remove.
6431         * symtab.c (default_collect_symbol_completion_matches_break_on):
6432         Update.
6433         * symmisc.c (dump_msymbols): Update.
6434         * stabsread.c (scan_file_globals): Update.
6435         * objc-lang.c (info_selectors_command, info_classes_command)
6436         (find_methods): Update.
6437         * minsyms.c (find_solib_trampoline_target): Update.
6438         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6439         * coffread.c (coff_symfile_read): Update.
6440         * ada-lang.c (ada_lookup_simple_minsym)
6441         (ada_collect_symbol_completion_matches): Update.
6442
6443 2019-01-16  Tom Tromey  <tom@tromey.com>
6444
6445         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6446         type.  Remove no-argument constructor.
6447         <iterator::operator++>: Simplify.
6448         <begin>: Update.
6449         <end>: Use minimal_symbol_count.
6450
6451 2019-01-16  Tom Tromey  <tom@tromey.com>
6452
6453         * objfiles.h (struct objfile) <psymtabs>: New method.
6454         (class objfile_psymtabs): Remove.
6455         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6456         typedef.
6457         <range>: New method.
6458         (require_partial_symbols): Change return type.
6459         * psymtab.c (require_partial_symbols)
6460         (psym_expand_symtabs_matching): Update.
6461         * mdebugread.c (parse_partial_symbols): Update.
6462         * dbxread.c (dbx_end_psymtab): Update.
6463
6464 2019-01-15  Tom Tromey  <tom@tromey.com>
6465
6466         * symtab.c (lookup_objfile_from_block)
6467         (lookup_symbol_in_objfile_symtabs)
6468         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6469         (find_line_symtab, info_sources_command)
6470         (default_collect_symbol_completion_matches_break_on)
6471         (make_source_files_completion_list): Update.
6472         * symmisc.c (print_objfile_statistics, dump_objfile)
6473         (maintenance_print_symbols, maintenance_info_symtabs)
6474         (maintenance_check_symtabs, maintenance_info_line_tables):
6475         Update.
6476         * source.c (select_source_symtab)
6477         (forget_cached_source_info_for_objfile): Update.
6478         * objfiles.h (class objfile_compunits): Remove.
6479         (struct objfile) <compunits_range>: New typedef.
6480         (compunits): New method.
6481         * objfiles.c (objfile_relocate1): Update.
6482         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6483         * maint.c (count_symtabs_and_blocks): Update.
6484         * linespec.c (iterate_over_all_matching_symtabs): Update.
6485         * cp-support.c (add_symbol_overload_list_qualified): Update.
6486         * coffread.c (coff_symtab_read): Update.
6487         * ada-lang.c (add_nonlocal_symbols)
6488         (ada_collect_symbol_completion_matches)
6489         (ada_add_global_exceptions): Update.
6490
6491 2019-01-15  Tom Tromey  <tom@tromey.com>
6492
6493         * progspace.h (program_space) <objfiles_safe_range>: New
6494         typedef.
6495         <objfiles_safe>: New method.
6496         * objfiles.h (class all_objfiles_safe): Remove.
6497         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6498         * jit.c (jit_inferior_exit_hook): Update.
6499
6500 2019-01-17  Tom Tromey  <tom@tromey.com>
6501
6502         * progspace.h (program_space) <objfiles_range>: New typedef.
6503         <objfiles>: New method.
6504         <objfiles_head>: Rename from objfiles.
6505         (object_files): Update.
6506         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6507         * guile/scm-pretty-print.c
6508         (ppscm_find_pretty_printer_from_objfiles): Update.
6509         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6510         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6511         Update.
6512         * python/py-progspace.c (pspy_get_objfiles): Update.
6513         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6514         Update.
6515         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6516         (objfpy_lookup_objfile_by_build_id): Update.
6517         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6518         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6519         Update.
6520         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6521         (expand_symtab_containing_pc, lookup_objfile_from_block)
6522         (lookup_static_symbol, basic_lookup_transparent_type)
6523         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6524         (find_line_symtab, info_sources_command)
6525         (default_collect_symbol_completion_matches_break_on)
6526         (make_source_files_completion_list, find_main_name): Update.
6527         * symmisc.c (print_symbol_bcache_statistics)
6528         (print_objfile_statistics, maintenance_print_symbols)
6529         (maintenance_print_msymbols, maintenance_print_objfiles)
6530         (maintenance_info_symtabs, maintenance_check_symtabs)
6531         (maintenance_expand_symtabs, maintenance_info_line_tables):
6532         Update.
6533         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6534         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6535         (map_overlay_command, unmap_overlay_command)
6536         (simple_overlay_update, expand_symtabs_matching)
6537         (map_symbol_filenames): Update.
6538         * symfile-debug.c (set_debug_symfile): Update.
6539         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6540         Update.
6541         * source.c (select_source_symtab, forget_cached_source_info):
6542         Update.
6543         * solib.c (solib_read_symbols): Update.
6544         * solib-spu.c (append_ocl_sos): Update.
6545         * psymtab.c (maintenance_print_psymbols)
6546         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6547         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6548         * printcmd.c (info_symbol_command): Update.
6549         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6550         Update.
6551         * objfiles.h (class all_objfiles): Remove.
6552         * objfiles.c (have_partial_symbols, have_full_symbols)
6553         (have_minimal_symbols, qsort_cmp, update_section_map)
6554         (shared_objfile_contains_address_p)
6555         (default_iterate_over_objfiles_in_search_order): Update.
6556         * objc-lang.c (info_selectors_command, info_classes_command)
6557         (find_methods): Update.
6558         * minsyms.c (find_solib_trampoline_target): Update.
6559         * maint.c (maintenance_info_sections)
6560         (maintenance_translate_address, count_symtabs_and_blocks):
6561         Update.
6562         * main.c (captured_main_1): Update.
6563         * linux-thread-db.c (try_thread_db_load_from_pdir)
6564         (has_libpthread): Update.
6565         * linespec.c (iterate_over_all_matching_symtabs)
6566         (search_minsyms_for_name): Update.
6567         * jit.c (jit_find_objf_with_entry_addr): Update.
6568         * hppa-tdep.c (find_unwind_entry)
6569         (hppa_lookup_stub_minimal_symbol): Update.
6570         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6571         Update.
6572         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6573         (elf_gnu_ifunc_resolve_by_got): Update.
6574         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6575         * dwarf-index-write.c (save_gdb_index_command): Update.
6576         * cp-support.c (add_symbol_overload_list_qualified): Update.
6577         * breakpoint.c (create_overlay_event_breakpoint)
6578         (create_longjmp_master_breakpoint)
6579         (create_std_terminate_master_breakpoint)
6580         (create_exception_master_breakpoint): Update.
6581         * blockframe.c (find_pc_partial_function): Update.
6582         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6583         (ada_collect_symbol_completion_matches)
6584         (ada_add_global_exceptions): Update.
6585
6586 2019-01-17  Tom Tromey  <tom@tromey.com>
6587
6588         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6589         declare VEC.
6590         (solib_target_parse_libraries): Change return type.
6591         (library_list_start_segment, library_list_start_section)
6592         (library_list_end_library, library_list_start_library); Update.
6593         (solib_target_free_library_list): Remove.
6594         (solib_target_parse_libraries): Remove cleanup.  Change return
6595         type.
6596         (solib_target_current_sos): Update.
6597
6598 2019-01-17  Tom Tromey  <tromey@bapiya>
6599
6600         * valprint.c: Replace "the the" with "the".
6601         * symtab.c: Replace "the the" with "the".
6602         * solib.c: Replace "the the" with "the".
6603         * solib-dsbt.c: Replace "the the" with "the".
6604         * linespec.c: Replace "the the" with "the".
6605         * dwarf2loc.h: Replace "the the" with "the".
6606         * amd64-windows-tdep.c: Replace "the the" with "the".
6607         * aarch64-tdep.c: Replace "the the" with "the".
6608
6609 2019-01-16  Keith Seitz  <keiths@redhat.com>
6610
6611         PR gdb/23773
6612         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6613         <builder>: Rename to ..
6614         <m_builder>: ... this and make private.
6615         (dwarf2_cu::get_builder): New method.  Change all users of
6616         `builder' to use this method.
6617         (dwarf2_start_symtab): Move to ...
6618         (dwarf2_cu::start_symtab): ... here.  Update all callers
6619         (setup_type_unit_groups): Move to ...
6620         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6621         callers.
6622         (dwarf2_cu::reset_builder): New method.
6623         (process_full_compunit, process_full_type_unit): Use
6624         dwarf2_cu::reset_builder.
6625         (follow_die_offset): Record the ancestor CU if it is different
6626         from the followed DIE's CU.
6627         (follow_die_sig_1): Likewise.
6628
6629 2019-01-15  Tom Tromey  <tom@tromey.com>
6630
6631         * remote.c (class remote_state) <buf>: Now a char_vector.
6632         <buf_size>: Remove.
6633         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6634         parameter.
6635         (remote_target::getpkt_or_notif_sane_1)
6636         (remote_target::getpkt_sane)
6637         (remote_target::getpkt_or_notif_sane): Likewise.
6638         (class remote_target) <putpkt>: New overload.
6639         (remote_target::read_frame): Change type of "buf_p".  Remove
6640         sizeof_p parameter.
6641         (packet_ok): New overload.
6642         (packet_check_result): New overload.
6643         Update all uses.
6644
6645 2019-01-14  Tom Tromey  <tom@tromey.com>
6646
6647         * remote-notif.c (handle_notification, remote_notif_ack)
6648         (remote_notif_parse): Make "buf" const.
6649         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6650         const.
6651         (remote_notif_parse, remote_notif_ack, handle_notification):
6652         Likewise.
6653         * remote.c (remote_notif_stop_parse): Make "buf" const.
6654         (remote_target::remote_parse_stop_reply): Make "buf" const.
6655         (remote_notif_stop_ack): Make "buf" const.
6656
6657 2019-01-14  Tom Tromey  <tom@tromey.com>
6658
6659         * remote.c (remote_console_output): Make parameter const.
6660
6661 2019-01-14  Tom Tromey  <tom@tromey.com>
6662
6663         * target-debug.h (target_debug_print_signals): Constify.
6664         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6665         * procfs.c (procfs_target::pass_signals): Update.
6666         * linux-nat.c (linux_nat_target::pass_signals): Update.
6667         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6668         * target-delegates.c: Rebuild.
6669         * remote.c (remote_target::program_signals): Update.
6670         (remote_target::pass_signals): Update.
6671         * target.c (target_pass_signals): Constify argument.
6672         (target_program_signals): Likewise.
6673         * target.h (struct target_ops) <pass_signals, program_signals>:
6674         Constify argument.
6675         (target_pass_signals, target_program_signals): Constify argument.
6676
6677 2019-01-14  Tom Tromey  <tom@tromey.com>
6678
6679         PR tui/28819:
6680         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6681
6682 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6683
6684         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6685         field.
6686         * rs6000-tdep.c: Include reggroups.h.
6687         (IS_V_ALIAS_PSEUDOREG): Define.
6688         (rs6000_register_name): Return names for the "vX" aliases.
6689         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6690         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6691         aliases.  Call default_register_reggroup_p for all other
6692         pseudo-registers.
6693         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6694         New functions.
6695         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6696         Handle "vX" aliases.
6697         (v_alias_pseudo_register_collect): New function.
6698         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6699         (rs6000_gdbarch_init): Initialize "vX" aliases as
6700         pseudo-registers.  Restore registration of
6701         rs6000_pseudo_register_reggroup_p with
6702         set_tdesc_pseudo_register_reggroup_p.
6703
6704 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6705
6706         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6707         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6708         set_gdbarch_num_pseudo_regs.
6709
6710 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6711
6712         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6713         Remove arg prefixname, add do_set and do_show.
6714         Add member functions set_list and show_list.
6715         * cli/cli-style.c (class cli_style_option): Update accordingly.
6716         (style_set_list): Move to file scope.
6717         (style_show_list): Likewise.
6718         (set_style): Call help_list.
6719         (show_style): Call cmd_show_list.
6720         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6721         Update to use the new macro.
6722
6723 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6724
6725         * ada-lang.c (_initialize_ada_language): Expand the help text
6726         for the "catch exception" command.
6727
6728 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6729
6730         * symtab.c (matching_obj_sections): Initialize obj,
6731         declare it closer to its usage.
6732
6733 2019-01-10  Tom Tromey  <tom@tromey.com>
6734
6735         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6736         (basic_inf_threads_range): Remove.
6737         (inf_threads_range, inf_non_exited_threads_range)
6738         (safe_inf_threads_range): Use next_adapter.
6739
6740 2019-01-10  Keith Seitz  <keiths@redhat.com>
6741
6742         PR gdb/23712
6743         PR symtab/23010
6744         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6745         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6746
6747 2019-01-10  Keith Seitz  <keiths@redhat.com>
6748
6749         PR gdb/23712
6750         PR symtab/23010
6751         * dictionary.c (pending_to_vector): Remove.
6752         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6753         Remove _1 suffix, replacing functions of the same name.  Update
6754         all callers.
6755         (dict_create_hashed, dict_create_hashed_expandable)
6756         (dict_create_linear, dict_create_linear_expandable, dict_free)
6757         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6758         Make functions static.
6759
6760 2019-01-10  Keith Seitz  <keiths@redhat.com>
6761
6762         PR gdb/23712
6763         PR symtab/23010
6764         * dictionary.h (struct dictionary): Replace declaration with
6765         multidictionary.
6766         (dict_create_hashed, dict_create_hashed_expandable)
6767         (dict_create_linear, dict_create_linear_expandable)
6768         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6769         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6770         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6771         taking multidictionary argument.
6772         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6773         * block.h (struct block) <dict>: Change to multidictionary
6774         and rename `multidict'.
6775         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6776         symmisc.c: Update all dictionary references to multidictionary.
6777
6778 2019-01-10  Keith Seitz  <keiths@redhat.com>
6779
6780         PR gdb/23712
6781         PR symtab/23010
6782         * dictionary.c: Include unordered_map.
6783         (pending_to_vector): New function.
6784         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6785         Rewrite the non-"_1" functions to take vector instead
6786         of linked list.
6787         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6788         "new" _1 versions of the same name.
6789         (multidictionary): Define.
6790         (std::hash<enum language): New definition.
6791         (collate_pending_symbols_by_language, mdict_create_hashed)
6792         (mdict_create_hashed_expandable, mdict_create_linear)
6793         (mdict_create_linear_expandable, mdict_free)
6794         (find_language_dictionary, create_new_language_dictionary)
6795         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6796         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6797         (mdict_size, mdict_empty): New functions.
6798         * dictionary.h (mdict_iterator): Define.
6799
6800 2019-01-10  Pedro Alves  <palves@redhat.com>
6801
6802         * breakpoint.c (read_uploaded_action)
6803         (create_tracepoint_from_upload): Adjust to use
6804         gdb::unique_xmalloc_ptr.
6805         * ctf.c (ctf_write_uploaded_tp):
6806         (SET_ARRAY_FIELD): Use emplace_back.
6807         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6808         * tracefile-tfile.c (tfile_write_uploaded_tp):
6809         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6810         gdb::unique_xmalloc_ptr.
6811         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6812         at_string, cond_string, cmd_strings>: Replace char pointers
6813         with gdb::unique_xmalloc_ptr.
6814
6815 2019-01-10  Pedro Alves  <palves@redhat.com>
6816
6817         * solib-target.c (library_list_start_library): Don't xstrdup name.
6818
6819 2019-01-10  Pedro Alves  <palves@redhat.com>
6820
6821         * mdebugread.c (parse_partial_symbols): Use
6822         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6823
6824 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * linux-fork.c (scoped_switch_fork_info)
6827         <~scoped_switch_fork_info>: Fix incorrect variable name.
6828
6829 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6830
6831         * linux-fork.c (scoped_switch_fork_info)
6832         <scoped_switch_fork_info>: Make explicit.
6833         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6834
6835 2019-01-10  Tom Tromey  <tom@tromey.com>
6836
6837         * objfiles.h (objfile::reset_psymtabs): Update.
6838         * objfiles.c (objfile::objfile): Update.
6839         * psymtab.h (psymtab_storage::obstack): Update.
6840         (psymtab_storage::m_obstack): Use gdb::optional.
6841         (class psymtab_storage): Update comment.  Remove objfile
6842         parameter.
6843         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6844
6845 2019-01-10  Tom Tromey  <tom@tromey.com>
6846
6847         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6848         <free_psymtabs>: Now private.
6849         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6850         (allocate_psymtab): Use new method.
6851
6852 2019-01-10  Tom Tromey  <tom@tromey.com>
6853
6854         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6855         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6856         * mdebugread.c (parse_partial_symbols): Use
6857         allocate_dependencies.
6858         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6859         allocate_dependencies.
6860         (process_psymtab_comp_unit_reader)
6861         (build_type_psymtab_dependencies): Likewise.
6862         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6863
6864 2019-01-10  Tom Tromey  <tom@tromey.com>
6865
6866         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6867         PSYMBOL_SET_LANGUAGE.
6868         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6869
6870 2019-01-10  Tom Tromey  <tom@tromey.com>
6871
6872         * psymtab.h (psymtab_storage::obstack): New method.
6873         <m_obstack>: Rename from obstack; now private.
6874         * psymtab.c (psymtab_storage): Update.
6875         * dwarf2read.c (create_addrmap_from_index)
6876         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6877         Update.
6878
6879 2019-01-10  Tom Tromey  <tom@tromey.com>
6880
6881         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6882         * objfiles.h (objfile::reset_psymtabs): New method.
6883
6884 2019-01-10  Tom Tromey  <tom@tromey.com>
6885
6886         * symmisc.c (print_symbol_bcache_statistics): Update.
6887         (print_objfile_statistics): Update.
6888         * symfile.c (reread_symbols): Update.
6889         * psymtab.h (class psymtab_storage): New.
6890         * psymtab.c (psymtab_storage): New constructor.
6891         (~psymtab_storage): New destructor.
6892         (require_partial_symbols): Update.
6893         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6894         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6895         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6896         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6897         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6898         (start_psymtab_common, end_psymtab_common)
6899         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6900         (allocate_psymtab): Update.
6901         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6902         Update.
6903         (dump_psymtab_addrmap, maintenance_print_psymbols)
6904         (maintenance_check_psymtabs): Update.
6905         (class objfile_psymtabs): Move to objfiles.h.
6906         * psympriv.h (discard_psymtab): Now inline.
6907         (psymtab_discarder::psymtab_discarder): Update.
6908         (psymtab_discarder::~psymtab_discarder): Update.
6909         (ALL_OBJFILE_PSYMTABS): Rewrite.
6910         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6911         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6912         Remove fields.
6913         <partial_symtabs>: New field.
6914         (class objfile_psymtabs): Move from psymtab.h.  Update.
6915         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6916         psymbol_cache.
6917         (objfile::~objfile): Don't destroy psymbol_cache.
6918         * mdebugread.c (parse_partial_symbols): Update.
6919         * dwarf2read.c (create_addrmap_from_index)
6920         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6921         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6922         (add_partial_subprogram, dwarf2_ranges_read): Update.
6923         * dwarf-index-write.c (write_address_map)
6924         (write_one_signatured_type, recursively_write_psymbols)
6925         (class debug_names, class debug_names, write_psymtabs_to_index):
6926         Update.
6927
6928 2019-01-10  Tom Tromey  <tom@tromey.com>
6929
6930         * symtab.h (SYMBOL_SET_NAMES): Update.
6931         (symbol_set_names): Update.
6932         (MSYMBOL_SET_NAMES): Update.
6933         * symtab.c (symbol_set_names): Change argument to be an
6934         objfile_per_bfd_storage.
6935         * psymtab.c (add_psymbol_to_bcache): Update.
6936         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6937
6938 2019-01-10  Tom Tromey  <tom@tromey.com>
6939
6940         * symtab.c (create_demangled_names_hash): Change argument to be an
6941         objfile_per_bfd_storage.
6942         (symbol_set_names): Update.
6943
6944 2019-01-10  Tom Tromey  <tom@tromey.com>
6945
6946         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6947         init_psymbol_list.
6948         * psymtab.c (init_psymbol_list): Do nothing if already called.
6949         * psympriv.h (init_psymbol_list): Add comment.
6950         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6951         init_psymbol_list.
6952         * dbxread.c (dbx_symfile_read): Unconditionally call
6953         init_psymbol_list.
6954
6955 2019-01-10  Tom Tromey  <tom@tromey.com>
6956
6957         * xcoffread.c (scan_xcoff_symtab): Update.
6958         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6959         "where".
6960         * mdebugread.c (parse_partial_symbols)
6961         (handle_psymbol_enumerators): Update.
6962         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6963         * dbxread.c (read_dbx_symtab): Update.
6964         * psympriv.h (psymbol_placement): New enum.
6965         (add_psymbol_to_list): Update.
6966
6967 2019-01-10  Tom Tromey  <tom@tromey.com>
6968
6969         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6970         static_psymbols parameters.
6971         (scan_xcoff_symtab): Update.
6972         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6973         static_psymbols parameters.
6974         * psympriv.h (start_psymtab_common): Update.
6975         * mdebugread.c (parse_partial_symbols): Update.
6976         * dwarf2read.c (create_partial_symtab): Update.
6977         * dbxread.c (read_dbx_symtab): Update.
6978         (start_psymtab): Remove global_psymbols and static_psymbols
6979         parameters.
6980
6981 2019-01-10  Tom Tromey  <tom@tromey.com>
6982
6983         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6984         * psymtab.c (allocate_psymtab): Add comment.
6985         * psympriv.h (allocate_psymtab): Add comment.
6986         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6987         initializations.
6988         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6989
6990 2019-01-10  Tom Tromey  <tom@tromey.com>
6991
6992         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6993         Don't declare.
6994         * mipsread.c: Include mdebugread.h.
6995         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6996         Declare.
6997         * elfread.c: Include mdebugread.h.
6998
6999 2019-01-09  Tom Tromey  <tom@tromey.com>
7000
7001         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7002         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7003         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7004         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7005         (psym_lookup_symbol, psym_find_last_source_symtab)
7006         (psym_forget_cached_source_info, psym_print_stats)
7007         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7008         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7009         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7010         (psym_find_compunit_symtab_by_address)
7011         (maintenance_print_psymbols, maintenance_info_psymtabs)
7012         (maintenance_check_psymtabs): Use ranged for.
7013         * psymtab.h (class objfile_psymtabs): New.
7014         (require_partial_symbols): Return objfile_psymtabs.
7015         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7016
7017 2019-01-09  Tom Tromey  <tom@tromey.com>
7018
7019         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7020         (find_pc_mapped_section, list_overlays_command)
7021         (map_overlay_command, unmap_overlay_command)
7022         (simple_overlay_update): Use all_objfiles.
7023         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7024         * printcmd.c (info_symbol_command): Use all_objfiles.
7025         * objfiles.h (ALL_OBJSECTIONS): Remove.
7026         * maint.c (maintenance_translate_address): Use all_objfiles.
7027         * gcore.c (gcore_create_callback): Use all_objfiles.
7028         (objfile_find_memory_regions): Likewise.
7029
7030 2019-01-09  Tom Tromey  <tom@tromey.com>
7031
7032         * symtab.c (find_line_symtab, info_sources_command)
7033         (make_source_files_completion_list): Use objfile_compunits.
7034         * source.c (select_source_symtab): Use objfile_compunits.
7035         * objfiles.h (struct objfile): Update comment.
7036         (ALL_OBJFILES): Remove.
7037         (ALL_FILETABS): Remove.
7038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7039         objfile_compunits.
7040
7041 2019-01-09  Tom Tromey  <tom@tromey.com>
7042
7043         * symmisc.c (print_objfile_statistics, dump_objfile)
7044         (maintenance_print_symbols): Use compunit_filetabs.
7045         * source.c (forget_cached_source_info_for_objfile): Use
7046         compunit_filetabs.
7047         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7048         (ALL_FILETABS): Use compunit_filetabs.
7049         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7050         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7051
7052 2019-01-09  Tom Tromey  <tom@tromey.com>
7053
7054         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7055         (compunit_filetabs): New.
7056         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7057         compunit_filetabs.
7058         (info_sources_command, make_source_files_completion_list): Remove
7059         declaration.
7060         * symmisc.c (print_objfile_statistics, dump_objfile)
7061         (maintenance_print_symbols): Remove declaration.
7062         (maintenance_info_symtabs): Use compunit_filetabs.
7063         (maintenance_info_line_tables): Likewise.
7064         * source.c (select_source_symtab): Change local variable name.
7065         (forget_cached_source_info_for_objfile): Remove declaration.
7066         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7067         * objfiles.c (objfile_relocate1): Remove declaration.
7068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7069         declaration.
7070         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7071         * coffread.c (coff_symtab_read): Remove declaration.
7072         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7073         compunit_filetabs.
7074
7075 2019-01-09  Tom Tromey  <tom@tromey.com>
7076
7077         * symtab.c (lookup_objfile_from_block)
7078         (find_pc_sect_compunit_symtab, search_symbols)
7079         (default_collect_symbol_completion_matches_break_on): Use
7080         objfile_compunits.
7081         * objfiles.h (ALL_COMPUNITS): Remove.
7082         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7083         * cp-support.c (add_symbol_overload_list_qualified): Use
7084         objfile_compunits.
7085         * ada-lang.c (ada_collect_symbol_completion_matches)
7086         (ada_add_global_exceptions): Use objfile_compunits.
7087
7088 2019-01-09  Tom Tromey  <tom@tromey.com>
7089
7090         * source.c (select_source_symtab)
7091         (forget_cached_source_info_for_objfile): Remove declaration.
7092         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7093         declaration.
7094         * maint.c (count_symtabs_and_blocks): Remove declaration.
7095         * cp-support.c (add_symbol_overload_list_qualified): Remove
7096         declaration.
7097         * coffread.c (coff_symtab_read): Remove declaration.
7098         * symtab.c (lookup_symbol_in_objfile_symtabs)
7099         (basic_lookup_transparent_type_1): Use objfile_compunits.
7100         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7101         (info_sources_command, search_symbols)
7102         (default_collect_symbol_completion_matches_break_on)
7103         (make_source_files_completion_list): Remove declaration.
7104         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7105         (ada_collect_symbol_completion_matches)
7106         (ada_add_global_exceptions): Remove declaration.
7107         * linespec.c (iterate_over_all_matching_symtabs): Use
7108         objfile_compunits.
7109         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7110         (class objfile_compunits): New.
7111         (ALL_COMPUNITS): Use objfile_compunits.
7112         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7113         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7114         objfile_compunits.
7115         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7116
7117 2019-01-09  Tom Tromey  <tom@tromey.com>
7118
7119         * symtab.c (search_symbols)
7120         (default_collect_symbol_completion_matches_break_on): Use
7121         objfile_msymbols.
7122         * ada-lang.c (ada_lookup_simple_minsym)
7123         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7124         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7125         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7126         objfile_msymbols.
7127         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7128         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7129         * objc-lang.c (find_methods): Use objfile_msymbols.
7130         (info_selectors_command, info_classes_command): Likewise.
7131         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7132         * objfiles.h (class objfile_msymbols): New.
7133         (ALL_OBJFILE_MSYMBOLS): Remove.
7134         (ALL_MSYMBOLS): Remove.
7135
7136 2019-01-09  Tom Tromey  <tom@tromey.com>
7137
7138         * common/next-iterator.h (next_adapter): Add Iterator template
7139         parameter.
7140         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7141         (class all_objfiles_safe): New.
7142         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7143         * objfiles.c (put_objfile_before): Update comment.
7144         (add_separate_debug_objfile): Likewise.
7145         (free_all_objfiles): Use all_objfiles_safe.
7146         (objfile_purge_solibs): Likewise.
7147
7148 2019-01-09  Tom Tromey  <tom@tromey.com>
7149
7150         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7151         (expand_symtab_containing_pc, lookup_static_symbol)
7152         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7153         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7154         all_objfiles.
7155         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7156         * breakpoint.c (create_overlay_event_breakpoint)
7157         (create_longjmp_master_breakpoint)
7158         (create_std_terminate_master_breakpoint)
7159         (create_exception_master_breakpoint): Use all_objfiles.
7160         * linux-thread-db.c (try_thread_db_load_from_pdir)
7161         (has_libpthread): Use all_objfiles.
7162         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7163         * linespec.c (iterate_over_all_matching_symtabs)
7164         (search_minsyms_for_name): Use all_objfiles.
7165         * maint.c (maintenance_info_sections): Use all_objfiles.
7166         * main.c (captured_main_1): Use all_objfiles.
7167         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7168         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7169         * guile/scm-pretty-print.c
7170         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7171         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7172         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7173         (maintenance_print_msymbols): Use all_objfiles.
7174         * source.c (select_source_symtab): Use all_objfiles.
7175         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7176         * symfile.c (remove_symbol_file_command)
7177         (expand_symtabs_matching, map_symbol_filenames): Use
7178         all_objfiles.
7179         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7180         all_objfiles.
7181         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7182         * objc-lang.c (find_methods): Use all_objfiles.
7183         * objfiles.c (have_partial_symbols, have_full_symbols)
7184         (have_minimal_symbols, qsort_cmp)
7185         (default_iterate_over_objfiles_in_search_order): Use
7186         all_objfiles.
7187         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7188         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7189         (maintenance_check_psymtabs): Use all_objfiles.
7190         (ALL_PSYMTABS): Remove.
7191         * compile/compile-object-run.c (do_module_cleanup): Use
7192         all_objfiles.
7193         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7194         * cp-support.c (add_symbol_overload_list_qualified): Use
7195         all_objfiles.
7196         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7197         Use all_objfiles.
7198         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7199         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7200         all_objfiles.
7201         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7202         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7203         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7204         Uses all_objfiles.
7205         * solib.c (solib_read_symbols): Use all_objfiles
7206
7207 2019-01-09  Tom Tromey  <tom@tromey.com>
7208
7209         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7210         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7211         all_objfiles.
7212         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7213         * symmisc.c (print_symbol_bcache_statistics)
7214         (print_objfile_statistics, maintenance_print_objfiles)
7215         (maintenance_info_symtabs, maintenance_check_symtabs)
7216         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7217         all_objfiles.
7218         * source.c (forget_cached_source_info): Use all_objfiles.
7219         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7220         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7221         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7222         * objfiles.c (update_section_map): Use all_objfiles.
7223         (shared_objfile_contains_address_p): Likewise.
7224         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7225         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7226
7227 2019-01-09  Tom Tromey  <tom@tromey.com>
7228
7229         * common/next-iterator.h: New file.
7230         * objfiles.h (class all_objfiles): New.
7231         (struct objfile_iterator): New.
7232
7233 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7234
7235         * NEWS: Move the description of the changed "frame", "select-frame",
7236          and "info frame" commands to the Changed commands section.
7237
7238 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7239
7240         * gdbtypes.c (check_stub_method_group): Remove handling of old
7241         mangling schemes.
7242         * linespec.c (find_methods): Likewise.
7243         * stabsread.c (read_member_functions): Likewise.
7244         * valops.c (search_struct_method): Likewise.
7245         (value_struct_elt_for_reference): Likewise.
7246         * NEWS: Mention this change.
7247
7248 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7251         print_source_lines.
7252         * source.c (print_source_lines_base): Update line number check.
7253         (print_source_lines): New function.
7254         (source_lines_range::source_lines_range): New function.
7255         * source.h (class source_lines_range): New class.
7256         (print_source_lines): New declaration.
7257
7258 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7259
7260         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7261
7262 2019-01-08  Tom Tromey  <tom@tromey.com>
7263             Simon Marchi  <simon.marchi@ericsson.com>
7264
7265         PR gdb/24060
7266         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7267         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7268         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7269         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7270         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7271         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7272
7273 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7274
7275         * source.c (select_source_symtab): Move header comment to
7276         declaration in source.h.
7277         (forget_cached_source_info_for_objfile): Likewise.
7278         (forget_cached_source_info): Likewise.
7279         (identify_source_line): Likewise.
7280         * source.h (identify_source_line): Move declaration from symtab.h
7281         and add comment from source.c
7282         (print_source_lines): Likewise.
7283         (forget_cached_source_info_for_objfile): Likewise.
7284         (forget_cached_source_info): Likewise.
7285         (select_source_symtab): Likewise.
7286         (enum print_source_lines_flag): Move definition from symtab.h.
7287         * symtab.h (identify_source_line): Move declaration to source.h.
7288         (print_source_lines): Likewise.
7289         (forget_cached_source_info_for_objfile): Likewise.
7290         (forget_cached_source_info): Likewise.
7291         (select_source_symtab): Likewise.
7292         (enum print_source_lines_flag): Move definition to source.h.
7293         * tui/tui-hooks.c: Add 'source.h' include.
7294
7295 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7296
7297         * source.c (print_source_lines_base): Handle requests to print
7298         reverse line number sequences, and guard against empty lines
7299         string.
7300
7301 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7302
7303         * source.c (print_source_lines_base): Fix skip of '\r' if next
7304         character is '\n'.
7305
7306 2019-01-06  Tom Tromey  <tom@tromey.com>
7307
7308         * c-exp.y (struct c_parse_state) <macro_original_text,
7309         expansion_obstack>: New member.
7310         (macro_original_text, expansion_obstack): Remove globals.
7311         (scan_macro_expansion, scanning_macro_expansion)
7312         (finished_macro_expansion): Update.
7313         (scan_macro_cleanup): Remove.
7314         (yylex, c_parse): Update.
7315
7316 2019-01-06  Tom Tromey  <tom@tromey.com>
7317
7318         * c-exp.y (struct c_parse_state) <strings>: New member.
7319         (operator_stoken): Update.
7320
7321 2019-01-06  Tom Tromey  <tom@tromey.com>
7322
7323         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7324         (union type_stack_elt) <typelist_val>: Now a pointer to
7325         std::vector.
7326         (type_stack_cleanup): Don't declare.
7327         (push_typelist): Update.
7328         * parse.c (pop_typelist): Return a std::vector.
7329         (push_typelist): Take a std::vector.
7330         (follow_types): Update.  Do not free args.
7331         (type_stack_cleanup): Remove.
7332         * c-exp.y (struct c_parse_state): New.
7333         (cpstate): New global.
7334         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7335         (nonempty_typelist): Update.
7336         (func_mod): Create a new vector.
7337         (c_parse): Create a c_parse_state.
7338         (check_parameter_typelist): Do not delete params.
7339         (function_method): Update.  Do not delete type_list.
7340
7341 2019-01-06  Tom Tromey  <tom@tromey.com>
7342
7343         PR gdb/28155:
7344         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7345         check_typedef.
7346         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7347         (print_return_value): Likewise.
7348
7349 2019-01-05  Tom Tromey  <tom@tromey.com>
7350
7351         * contrib/cleanup_check.py: Remove.
7352         * contrib/gcc-with-excheck: Remove.
7353         * contrib/exsummary.py: Remove.
7354         * contrib/excheck.py: Remove.
7355
7356 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7357
7358         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7359         NULL. Initialize tpprev to NULL instead of assigning it
7360         to NULL on the next statement.
7361         * windows-nat.c (windows_delete_thread): Remove check for
7362         main_thread_id before printing thread exit notifications.
7363         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7364         Remove thread ID check against main_thread_id.
7365         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7366         windows_delete_thread.
7367         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7368
7369 2019-01-04  Tom Tromey  <tom@tromey.com>
7370
7371         * compile/compile.c (_initialize_compile): Use upper case for
7372         metasyntactic variables.
7373         * symmisc.c (_initialize_symmisc): Use upper case for
7374         metasyntactic variables.
7375         * psymtab.c (_initialize_psymtab): Use upper case for
7376         metasyntactic variables.
7377         * demangle.c (demangle_command): Use upper case for metasyntactic
7378         variables.
7379         (_initialize_demangler): Likewise.
7380         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7381         variables.
7382
7383 2019-01-03  Tom Tromey  <tom@tromey.com>
7384
7385         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7386
7387 2019-01-03  Tom Tromey  <tom@tromey.com>
7388
7389         * python/py-symtab.c (salpy_str): Update.
7390         (struct salpy_sal_object) <symtab>: Now a PyObject.
7391         (salpy_dealloc): Update.
7392         (del_objfile_sal): Use gdbpy_ref.
7393
7394 2019-01-03  Tom Tromey  <tom@tromey.com>
7395
7396         * python/py-type.c (convert_field): Use new_reference.  Return
7397         gdbpy_ref.
7398         (make_fielditem): Return gdbpy_ref.
7399         (typy_fields): Update.
7400         (typy_getitem): Update.
7401         (field_name): Return gdbpy_ref.  Use new_reference.
7402         (typy_iterator_iternext): Update.
7403
7404 2019-01-03  Tom Tromey  <tom@tromey.com>
7405
7406         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7407
7408 2019-01-03  Tom Tromey  <tom@tromey.com>
7409
7410         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7411         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7412         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7413         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7414         (pspy_set_type_printers): Likewise.
7415         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7416         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7417         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7418         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7419         (objfpy_set_type_printers): Likewise.
7420
7421 2019-01-03  Tom Tromey  <tom@tromey.com>
7422
7423         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7424         (gdbpy_print_stack): Use gdbpy_err_fetch.
7425         * python/python-internal.h (class gdbpy_err_fetch): New class.
7426         (class gdbpy_enter) <m_error_type, m_error_value,
7427         m_error_traceback>: Remove.
7428         <m_error>: New member.
7429         (gdbpy_exception_to_string): Don't declare.
7430         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7431         * python/py-value.c (convert_value_from_python): Use
7432         gdbpy_err_fetch.
7433         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7434         gdbpy_exception_to_string.
7435         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7436         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7437         gdbpy_err_fetch.
7438
7439 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * linux-nat.c (delete_lwp_cleanup): Delete.
7442         (struct lwp_deleter): New struct.
7443         (lwp_info_up): New typedef.
7444         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7445         lwp_info_up.
7446
7447 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * linux-fork.c (class scoped_switch_fork_info): New class.
7450         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7451
7452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7453
7454         * valops.c (find_overload_match): Remove use of null_cleanup, and
7455         calls to do_cleanups.
7456
7457 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7458
7459         * compile/compile-cplus-types.c
7460         (compile_cplus_instance::decl_name): Handle changes to
7461         cp_func_name.
7462         * cp-support.c (cp_func_name): Update header comment, update
7463         return type.
7464         * cp-support.h (cp_func_name): Update return type in declaration.
7465         * valops.c (find_overload_match): Move temp_func local to top
7466         level of function and change its type.  Use temp_func to hold and
7467         delete temporary string obtained from cp_func_name.
7468
7469 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7472         gdb::char_vector, remove cleanup, and update uses of `msg`.
7473
7474 2019-01-03  Jim Wilson  <jimw@sifive.com>
7475
7476         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7477
7478 2019-01-02  Tom Tromey  <tom@tromey.com>
7479
7480         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7481         (tdesc_parse_xml): Remove cleanups.
7482         * target-descriptions.h (make_cleanup_free_target_description):
7483         Don't declare.
7484         (target_desc_deleter): New struct.
7485         (target_desc_up): New typedef.
7486         * target-descriptions.c (target_desc_deleter::operator()): Rename
7487         from free_target_description.
7488         (make_cleanup_free_target_description): Remove.
7489
7490 2019-01-02  Tom Tromey  <tom@tromey.com>
7491
7492         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7493         constructor, destructor.
7494         (linespec_parser): Remove typedef.
7495         (~linespec_parser): Rename from linespec_parser_delete.
7496         (linespec_lex_to_end, linespec_complete_label)
7497         (linespec_complete): Update.
7498         (decode_line_full): Remove cleanups.
7499         (decode_line_1): Update.
7500
7501 2019-01-02  Tom Tromey  <tom@tromey.com>
7502
7503         * python/python-internal.h (inferior_to_inferior_object): Change
7504         return type.
7505         * python/py-exitedevent.c (create_exited_event_object): Update.
7506         * python/py-inferior.c (inferior_to_inferior_object): Return
7507         gdbpy_ref.
7508         (python_new_inferior, python_inferior_deleted)
7509         (thread_to_thread_object, delete_thread_object)
7510         (build_inferior_list, gdbpy_selected_inferior): Update.
7511         * python/py-infthread.c (create_thread_object): Update.  Also fail
7512         if inferior_to_inferior_object fails.
7513
7514 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7515
7516         * inferior.h (class inferior) <displaced_step_state>: New field.
7517         * infrun.h (struct displaced_step_state): Move here from
7518         infrun.c.  Initialize fields, add constructor.
7519         <inf>: Remove field.
7520         <reset>: New method.
7521         * infrun.c (struct displaced_step_inferior_state): Move to
7522         infrun.h.
7523         (displaced_step_inferior_states): Remove.
7524         (get_displaced_stepping_state): Adust.
7525         (displaced_step_in_progress_any_inferior): Adjust.
7526         (displaced_step_in_progress_thread): Adjust.
7527         (displaced_step_in_progress): Adjust.
7528         (add_displaced_stepping_state): Remove.
7529         (get_displaced_step_closure_by_addr): Adjust.
7530         (remove_displaced_stepping_state): Remove.
7531         (infrun_inferior_exit): Call displaced_step_state.reset.
7532         (use_displaced_stepping): Don't check for NULL.
7533         (displaced_step_prepare_throw): Call
7534         get_displaced_stepping_state.
7535         (displaced_step_fixup): Don't check for NULL.
7536         (prepare_for_detach): Don't check for NULL.
7537
7538 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7539
7540         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7541          in case of call that did not complete.
7542
7543 2019-01-02  Andrey Utkin  <autkin@undo.io>
7544
7545         * symfile.c (find_separate_debug_file): Fix search of debug files for
7546         remote debuggee.
7547
7548 2019-01-02  Tom Tromey  <tom@tromey.com>
7549
7550         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7551         indentation.
7552         * python/py-frame.c (frapy_older): Remove cast.
7553         (frapy_newer): Likewise.
7554         * python/py-breakpoint.c (local_setattro): Remove cast.
7555         * python/py-arch.c (archpy_name): Remove local variable.
7556         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7557
7558 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7559
7560         * unittests/basic_string_view/element_access/char/empty.cc:
7561         Fix year range in copyright header.
7562
7563 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7566         Delete.
7567         <operator==>: Update with for removed field.
7568         <hash>: Likewise.
7569         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7570         <isa_features>: ...this.
7571         <abi_features>: New field.
7572         (riscv_isa_flen): Update comment.
7573         (riscv_abi_xlen): New declaration.
7574         (riscv_abi_flen): New declaration.
7575         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7576         isa_features.
7577         (riscv_abi_xlen): New function.
7578         (riscv_isa_flen): Update to get answer from isa_features.
7579         (riscv_abi_flen): New function.
7580         (riscv_has_fp_abi): Update to get answer from abi_features.
7581         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7582         xlen and flen.
7583         (riscv_call_info) <xlen, flen>: Update comment.
7584         (riscv_call_arg_struct): Remove invalid assertions
7585         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7586         is removed.
7587         (riscv_gdbarch_init): Gather isa features and abi features
7588         separately, ensure both match on the gdbarch when reusing an old
7589         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7590         a target with 64-bit float hardware.
7591
7592 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7593
7594         * source.c (search_command_helper): Stop reverse search
7595         when line 1 has been searched.
7596
7597 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7598
7599         * record-full.c (record_full_base_target::close): Rewrite
7600         record_full_core_buf_list free logic.
7601
7602 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7603
7604         * break-catch-syscall.c (print_one_catch_syscall): xfree
7605         the last text.
7606
7607 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7608
7609         * top.c (print_gdb_version): Update Copyright year in version
7610         message.
7611
7612 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7613
7614         Update copyright year range in all GDB files.
7615
7616 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7617
7618         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7619
7620 For older changes see ChangeLog-2018.
7621 \f
7622 Local Variables:
7623 mode: change-log
7624 left-margin: 8
7625 fill-column: 74
7626 version-control: never
7627 coding: utf-8
7628 End:
7629