gdb/ChangeLog

   1 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
   4         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
   5
   6 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * NEWS: Add debugredirect and testsuite sections.
   9
  10 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  11
  12         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  13         target descriptions using exclusively floating point register name
  14         aliases.
  15
  16 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         PR gdb/18644:
  19         * f-lang.c (build_fortran_types): Handle the case where
  20         gdbarch_floatformat_for_type returns a nullptr.
  21
  22 2019-05-21  Tom de Vries  <tdevries@suse.de>
  23
  24         PR cli/24587
  25         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  26
  27 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         PR gdb/18644:
  30         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  31         16-byte floats.
  32         * i386-tdep.c (i386_floatformat_for_type): Use
  33         floatformats_ia64_quad for the 16-byte floating point component
  34         within a fortran 32-byte complex number.
  35
  36 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  37
  38         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  39         delete default constructor.
  40         (find_partial_die): Update to return const struct.
  41         (partial_die_parent_scope): Move variable declaration into scope
  42         of its use and change its type to auto.
  43         (guess_partial_die_structure_name): Likewise.
  44         (partial_die_info::fixup): Likewise.
  45
  46 2019-05-17  Tom Tromey  <tromey@adacore.com>
  47
  48         * source.c (find_and_open_source): Remove cast.
  49
  50 2019-05-17  Tom Tromey  <tromey@adacore.com>
  51
  52         * annotate.c (annotate_source): Make "filename" const.
  53         * annotate.h (annotate_source): Use const.
  54
  55 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  56
  57         * disasm.c (set_disassembler_options): Send errors to stderr.
  58
  59 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  60
  61         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  62         (cli_interp_base::set_logging): Check debug_redirect.
  63         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  64         * cli/cli-logging.c (debug_redirect): Add static variable.
  65         (pop_output_files): Add default param.
  66         (handle_redirections): Print debug setting.
  67         (show_logging_command): Likewise.
  68         (_initialize_cli_logging): Add debugredirect command.
  69         * interps.c (current_interp_set_logging): Add debug_redirect
  70         parameter.
  71         * interps.h (set_logging): Add debug_redirect parameter.
  72         (current_interp_set_logging): Likewise.
  73         * mi/mi-common.h: Likewise.
  74         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  75
  76 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  77             Tom Tromey  <tromey@adacore.com>
  78
  79         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  80         directly.
  81         * cli/cli-interp.h (make_logging_output): Remove declaration.
  82         * cli/cli-logging.c (make_logging_output): Remove function.
  83         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  84         directly.
  85         * ui-file.c (tee_file::tee_file): Remove bools.
  86         (tee_file::~tee_file): Remove deletes.
  87         * ui-file.h (tee_file): Remove bools.
  88
  89 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  90
  91         * mi/mi-cmds.h (mi_cmd_complete): New function.
  92         * mi/mi-main.c (mi_cmd_complete): Likewise.
  93         * mi/mi-cmds.c: Define new MI command -complete.
  94         * NEWS: Mention new -complete command.
  95
  96 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  97
  98         * completer.h (complete): New function.
  99         * completer.c (complete): Likewise.
 100         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 101         function defined in completer.h.
 102
 103 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 104
 105        * MAINTAINERS (Write After Approval): Add myself.
 106
 107 2019-05-17  Tom de Vries  <tdevries@suse.de>
 108
 109         PR gdb/24094
 110         * dwarf2read.c (struct cu_partial_die_info): New struct.
 111         (find_partial_die): Return cu_partial_die_info.
 112         (partial_die_parent_scope, guess_partial_die_structure_name)
 113         (partial_die_info::fixup): Handle new return type of find_partial_die.
 114
 115 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 116
 117         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 118         "std::string", simplifying the algorithm.
 119
 120 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 121
 122         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 123         (stap_static_probe_ops::get_probes): Likewise.
 124
 125 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 126
 127         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 128         '-')" and "else if".
 129         (stap_parse_single_operand): Join checks for
 130         "gdbarch_stap_parse_special_token_p" and
 131         "gdbarch_stap_parse_special_token" in the same "if" statement.
 132         Invert check when verifying for operation on register
 133         displacement.
 134
 135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 136
 137         * stap-probe.c (stap_get_opcode): Update comment.
 138         (stap_get_expected_argument_type): Likewise.
 139         (handle_stap_probe): Likewise.
 140
 141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 142
 143         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 144         return type to 'bool'.  Adjust comment.  Use 'bool' when
 145         appropriate.
 146         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 147         * stap-probe.c (stap_parse_argument_1): Likewise.
 148         (stap_is_operator): Likewise.
 149         (stap_is_generic_prefix): Likewise.
 150         (stap_is_register_prefix): Likewise.
 151         (stap_is_register_indirection_prefix): Likewise.
 152         (stap_is_integer_prefix): Likewise.
 153         (stap_generic_check_suffix): Likewise.
 154         (stap_check_integer_suffix): Likewise.
 155         (stap_check_register_suffix): Likewise.
 156         (stap_check_register_indirection_suffix): Likewise.
 157         (stap_parse_register_operand): Likewise.
 158         (stap_parse_single_operand): Likewise.
 159         (stap_parse_argument_1): Likewise.
 160         (stap_probe::get_argument_count): Likewise.
 161         (stap_is_operator): Likewise.
 162
 163 2019-05-16  Tom Tromey  <tromey@adacore.com>
 164
 165         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 166         keyword to foreach.
 167
 168 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 169
 170         * linux-thread-db.c (try_thread_db_load_1): Change return type
 171         to bool.
 172         (try_thread_db_load): Likewise.
 173         (try_thread_db_load_from_pdir_1): Likewise.
 174         (try_thread_db_load_from_pdir): Likewise.
 175         (try_thread_db_load_from_sdir): Likewise.
 176         (try_thread_db_load_from_dir): Likewise.
 177         (thread_db_load_search): Likewise.
 178         (has_libpthread): Likewise.
 179         (thread_db_load): Likewise.
 180
 181 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 182
 183         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 184         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 185         NULL, and complain/return if that's the case.
 186
 187 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 188
 189         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 190         (advance, posn, abstract_read_memory): New functions.
 191         [struct mem_read_abstraction]: New struct.
 192         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 193
 194 2019-05-14  Tom Tromey  <tromey@adacore.com>
 195
 196         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 197         value is not lval_memory.
 198
 199 2019-05-14  Tom Tromey  <tromey@adacore.com>
 200
 201         * solib.c (info_sharedlibrary_command): Style the file name.
 202
 203 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 204
 205         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 206         (aarch64_vnv_type): Likewise.
 207         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 208         * common/tdesc.c: Likewise.
 209         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 210         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 211         * features/aarch64-fpu.xml: Add ieee half view.
 212         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 213         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 214         * gdbtypes.h (struct builtin_type): Likewise.
 215         (struct objfile_type): Likewise.
 216
 217 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 218
 219         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 220         typo.
 221         * location.h (string_to_event_location): Likewise.
 222
 223 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 224
 225         GDB 8.3 released.
 226
 227 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 228
 229         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 230         New variable declaration.
 231         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 232         New variable.
 233         (print_one_breakpoint): Use ui_out::test_flags and new global
 234         variable to compute use_fixed_output.
 235         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 236         Remove.
 237         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 238         (mi_multi_location_breakpoint_output_fixed): Remove.
 239         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 240         new variable.
 241         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 242         fix_multi_location_breakpoint_output flag if version >= 3.
 243         * ui-out.h (enum ui_out_flag)
 244         <fix_multi_location_breakpoint_output>: New enumerator.
 245
 246 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 247
 248         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 249
 250 2019-05-10  Tom Tromey  <tromey@adacore.com>
 251
 252         * ada-lang.c (catch_ada_completer): New function.
 253         (_initialize_ada_language): Use it.
 254
 255 2019-05-10  Tom Tromey  <tromey@adacore.com>
 256
 257         * thread.c (print_thread_info): Make "requested_threads" const.
 258         * gdbthread.h (print_thread_info): Make "requested_threads"
 259         const.
 260         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 261         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 262
 263 2019-05-08  Tom Tromey  <tom@tromey.com>
 264
 265         * gdbtypes.c (objfile_type_data): Change type.
 266         (objfile_type, _initialize_gdbtypes): Update.
 267
 268 2019-05-08  Tom Tromey  <tom@tromey.com>
 269
 270         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 271         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 272         (_initialize_dwarf2_frame): Update.
 273
 274 2019-05-08  Tom Tromey  <tom@tromey.com>
 275
 276         * objc-lang.c (objc_objfile_data): Change type.
 277         (find_methods): Update.
 278         (_initialize_objc_lang): Remove.
 279
 280 2019-05-08  Tom Tromey  <tom@tromey.com>
 281
 282         * stabsread.c (rs6000_builtin_type_data): Change type.
 283         (rs6000_builtin_type, _initialize_stabsread): Update.
 284
 285 2019-05-08  Tom Tromey  <tom@tromey.com>
 286
 287         * mips-tdep.c (mips_pdr_data): Remove.
 288         (_initialize_mips_tdep): Update.
 289
 290 2019-05-08  Tom Tromey  <tom@tromey.com>
 291
 292         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 293         (hppa_init_objfile_priv_data, read_unwind_info)
 294         (find_unwind_entry, _initialize_hppa_tdep): Update.
 295
 296 2019-05-08  Tom Tromey  <tom@tromey.com>
 297
 298         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 299         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 300         on obstack.
 301         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 302
 303 2019-05-08  Tom Tromey  <tom@tromey.com>
 304
 305         * mdebugread.c (basic_type_data): Change type.
 306         (basic_type, _initialize_mdebugread): Update.
 307
 308 2019-05-08  Tom Tromey  <tom@tromey.com>
 309
 310         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 311
 312 2019-05-08  Tom Tromey  <tom@tromey.com>
 313
 314         * nto-tdep.c (nto_inferior_data_reg): Change type.
 315         (nto_inferior_data): Update.
 316         (nto_inferior_data_cleanup, nto_new_inferior_data)
 317         (_initialize_nto_tdep): Remove.
 318         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 319
 320 2019-05-08  Tom Tromey  <tom@tromey.com>
 321
 322         * ada-lang.c (struct ada_inferior_data): Add initializers.
 323         (ada_inferior_data): Change type.
 324         (ada_inferior_data_cleanup): Remove.
 325         (get_ada_inferior_data, ada_inferior_exit)
 326         (struct ada_pspace_data): Add initializers, destructor.
 327         (ada_pspace_data_handle): Change type.
 328         (get_ada_pspace_data): Update.
 329         (ada_pspace_data_cleanup): Remove.
 330
 331 2019-05-08  Tom Tromey  <tom@tromey.com>
 332
 333         * coffread.c (struct coff_symfile_info): Add initializers.
 334         (coff_objfile_data_key): Move lower.  Change type.
 335         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 336         Update.
 337         (coff_free_info): Remove.
 338
 339 2019-05-08  Tom Tromey  <tom@tromey.com>
 340
 341         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 342         (fbsd_pspace_data_handle): Move lower.  Change type.
 343         (get_fbsd_pspace_data): Update.
 344         (fbsd_pspace_data_cleanup): Remove.
 345         (_initialize_fbsd_tdep): Update.
 346
 347 2019-05-08  Tom Tromey  <tom@tromey.com>
 348
 349         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 350         (get_ada_tasks_pspace_data): Update.
 351         (ada_tasks_pspace_data_cleanup): Remove.
 352         (_initialize_tasks): Update.
 353         (ada_tasks_inferior_data_handle): Change type.
 354         (get_ada_tasks_inferior_data): Update.
 355         (ada_tasks_inferior_data_cleanup): Remove.
 356         (struct ada_tasks_pspace_data): Add initializers.
 357
 358 2019-05-08  Tom Tromey  <tom@tromey.com>
 359
 360         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 361         * symfile-debug.c (debug_sym_get_probes): Change type.
 362         * stap-probe.c (handle_stap_probe):
 363         (stap_static_probe_ops::get_probes): Change type.
 364         * probe.h (class static_probe_ops) <get_probes>: Change type.
 365         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 366         (parse_probes_in_pspace): Update.
 367         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 368         Update.
 369         (any_static_probe_ops::get_probes): Change type.
 370         * elfread.c (elfread_data): New typedef.
 371         (probe_key): Change type.
 372         (elf_get_probes): Likewise.  Update.
 373         (probe_key_free): Remove.
 374         (_initialize_elfread): Update.
 375         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 376         Change type.
 377         (dtrace_process_dof_probe, dtrace_process_dof)
 378         (dtrace_static_probe_ops::get_probe): Change type.
 379
 380 2019-05-08  Tom Tromey  <tom@tromey.com>
 381
 382         * xcoffread.c (struct xcoff_symfile_info): Rename from
 383         coff_symfile_info.  Add initializers.
 384         (xcoff_objfile_data_key): Move lower.  Change type.
 385         (XCOFF_DATA): Rewrite.
 386         (xcoff_free_info): Remove.
 387         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 388         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 389         (xcoff_initial_scan): Update.
 390
 391 2019-05-08  Tom Tromey  <tom@tromey.com>
 392
 393         * solib-svr4.c (struct svr4_info): Add initializers and
 394         destructor.
 395         <probes_table>: Now an htab_up.
 396         (solib_svr4_pspace_data): Change type.
 397         (free_probes_table): Simplify.
 398         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 399         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 400         (probes_table_remove_objfile_probes, register_solib_event_probe)
 401         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 402         (_initialize_svr4_solib): Update.
 403
 404 2019-05-08  Tom Tromey  <tom@tromey.com>
 405
 406         * remote.c (remote_pspace_data): Change type.
 407         (remote_pspace_data_cleanup): Remove.
 408         (get_remote_exec_file, set_pspace_remote_exec_file)
 409         (_initialize_remote): Update.
 410
 411 2019-05-08  Tom Tromey  <tom@tromey.com>
 412
 413         * breakpoint.c (breakpoint_objfile_key): Change type.
 414         (get_breakpoint_objfile_data): Update.
 415         (free_breakpoint_objfile_data): Remove.
 416         (_initialize_breakpoint): Update.
 417
 418 2019-05-08  Tom Tromey  <tom@tromey.com>
 419
 420         * linux-tdep.c (struct linux_info): Add initializers.
 421         (linux_inferior_data): Move.  Change type.
 422         (invalidate_linux_cache_inf): Update.
 423         (linux_inferior_data_cleanup): Remove.
 424         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 425
 426 2019-05-08  Tom Tromey  <tom@tromey.com>
 427
 428         * auxv.c (auxv_inferior_data): Move.  Change type.
 429         (auxv_inferior_data_cleanup): Remove.
 430         (invalidate_auxv_cache_inf): Rewrite.
 431         (get_auxv_inferior_data, _initialize_auxv): Update.
 432
 433 2019-05-08  Tom Tromey  <tom@tromey.com>
 434
 435         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 436         (symfile_debug_objfile_data_key): Change type.
 437         (symfile_debug_installed, debug_qf_has_symbols)
 438         (debug_qf_find_last_source_symtab)
 439         (debug_qf_forget_cached_source_info)
 440         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 441         (debug_qf_print_stats, debug_qf_dump)
 442         (debug_qf_expand_symtabs_for_function)
 443         (debug_qf_expand_all_symtabs)
 444         (debug_qf_expand_symtabs_with_fullname)
 445         (debug_qf_map_matching_symbols)
 446         (debug_qf_expand_symtabs_matching)
 447         (debug_qf_find_pc_sect_compunit_symtab)
 448         (debug_qf_map_symbol_filenames)
 449         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 450         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 451         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 452         (debug_sym_read_linetable, debug_sym_relocate): Update.
 453         (symfile_debug_free_objfile): Remove.
 454         (install_symfile_debug_logging, _initialize_symfile_debug):
 455         Update.
 456
 457 2019-05-08  Tom Tromey  <tom@tromey.com>
 458
 459         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 460         allocate_on_obstack.
 461         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 462         (get_dwarf2_per_objfile): Update.
 463         (set_dwarf2_per_objfile): Remove.
 464         (dwarf2_has_info, dwarf2_get_section_info): Update.
 465         (dwarf2_free_objfile): Remove.
 466         (_initialize_dwarf2_read): Update.
 467
 468 2019-05-08  Tom Tromey  <tom@tromey.com>
 469
 470         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 471         initializers.
 472         <unsupported_script_warning_printed,
 473         script_not_found_warning_printed>: Now bool.
 474         (auto_load_pspace_data): Change type.
 475         (~auto_load_pspace_info): Rename from
 476         auto_load_pspace_data_cleanup.
 477         (get_auto_load_pspace_data, init_loaded_scripts_info)
 478         (clear_section_scripts, maybe_print_unsupported_script_warning)
 479         (maybe_print_script_not_found_warning, _initialize_auto_load):
 480         Update.
 481
 482 2019-05-08  Tom Tromey  <tom@tromey.com>
 483
 484         * objfiles.c (objfile_pspace_info): Add destructor and
 485         initializers.
 486         (objfiles_pspace_data): Change type.
 487         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 488         (get_objfile_pspace_data): Update.
 489         (objfiles_bfd_data): Change type.
 490         (get_objfile_bfd_data): Update.
 491         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 492
 493 2019-05-08  Tom Tromey  <tom@tromey.com>
 494
 495         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 496         Change type.
 497         (get_catch_syscall_inferior_data): Update.
 498         (catch_syscall_inferior_data_cleanup): Remove.
 499         (_initialize_break_catch_syscall): Update.
 500
 501 2019-05-08  Tom Tromey  <tom@tromey.com>
 502
 503         * inflow.c (struct terminal_info): Add destructor and
 504         initializers.
 505         (inflow_inferior_data): Change type.
 506         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 507         (get_inflow_inferior_data, inflow_inferior_exit)
 508         (swap_terminal_info, _initialize_inflow): Update.
 509
 510 2019-05-08  Tom Tromey  <tom@tromey.com>
 511
 512         * target-dcache.c (target_dcache_cleanup): Remove.
 513         (target_dcache_aspace_key): Change type.
 514         (target_dcache_init_p, target_dcache_invalidate)
 515         (target_dcache_get, target_dcache_get_or_init)
 516         (_initialize_target_dcache): Update.
 517         * dcache.h (struct dcache_deleter): New.
 518
 519 2019-05-08  Tom Tromey  <tom@tromey.com>
 520
 521         * symtab.c (struct symbol_cache): Add destructor and
 522         initializers.
 523         (symbol_cache_key): Move.  Change type.
 524         (make_symbol_cache, free_symbol_cache): Remove.
 525         (get_symbol_cache): Update.
 526         (symbol_cache_cleanup): Remove.
 527         (ALL_PSPACES, symbol_cache_flush)
 528         (maintenance_print_symbol_cache)
 529         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 530         Update.
 531
 532 2019-05-08  Tom Tromey  <tom@tromey.com>
 533
 534         * symtab.c (struct main_info): Add destructor and initializers.
 535         (main_progspace_key): Move.  Change type.
 536         (get_main_info): Update.
 537         (main_info_cleanup): Remove.
 538         (_initialize_symtab): Update.
 539
 540 2019-05-08  Tom Tromey  <tom@tromey.com>
 541
 542         * registry.h (DECLARE_REGISTRY): Define the _key class.
 543
 544 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * NEWS: Merge two 'New commands' sections.
 547
 548 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 549
 550         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 551         parameter and use Ada language definition instead.
 552         (ada_val_print_ptr): Remove unused language parameter.
 553         (ada_val_print_num): Remove language parameter and use Ada language
 554         definition instead.
 555         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 556         parameter.
 557         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 558         parameter and use Ada language definition instead.
 559         (ada_val_print_1): Update all ada_val_print_xxx calls.
 560         Remove language parameter.
 561         (ada_val_print): Update ada_val_print_1 call.
 562
 563 2019-05-08  Tom Tromey  <tromey@adacore.com>
 564
 565         * remote.c (remote_hw_watchpoint_limit)
 566         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 567         Now static.
 568
 569 2019-05-08  Tom Tromey  <tromey@adacore.com>
 570
 571         * maint.c (_initialize_maint_cmds): Move initialization code to
 572         remote.c.
 573         (watchdog, show_watchdog): Move to remote.c.
 574         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 575         "watchdog" static.
 576         (_initialize_remote): Move initialization code from maint.c.
 577         * defs.h (watchdog): Don't declare.
 578
 579 2019-05-08  Tom Tromey  <tromey@adacore.com>
 580
 581         * tui/tui-interp.c: Include main.h.
 582         * interps.c: Include main.h.
 583         * main.h (interpreter_p): Declare.
 584         * defs.h (interpreter_p): Don't declare.
 585
 586 2019-05-08  Tom Tromey  <tromey@adacore.com>
 587
 588         * dwarf2loc.c: Include dwarf2read.h.
 589         * defs.h (read_unsigned_leb128): Don't declare.
 590         * dwarf2read.h (read_unsigned_leb128): Declare.
 591
 592 2019-05-08  Tom Tromey  <tromey@adacore.com>
 593
 594         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 595         method.
 596
 597 2019-05-08  Tom Tromey  <tromey@adacore.com>
 598
 599         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 600         when no wrap column is set.
 601
 602 2019-05-08  Tom Tromey  <tromey@adacore.com>
 603
 604         * c-lang.c (c_get_string): Handle non-C-style arrays.
 605
 606 2019-05-08  Tom Tromey  <tromey@adacore.com>
 607
 608         * typeprint.c (print_offset_data::update): Print the bit offset,
 609         not the number of bits remaining.
 610
 611 2019-05-08  Tom Tromey  <tromey@adacore.com>
 612
 613         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 614         padding at end of comment.
 615
 616 2019-05-08  Tom Tromey  <tromey@adacore.com>
 617
 618         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 619         Compare main types.
 620
 621 2019-05-06  Tom Tromey  <tom@tromey.com>
 622
 623         * common/scoped_mmap.c: Include common-defs.h.
 624         * common/scoped_mmap.h: Don't include config.h.
 625
 626 2019-05-04  Tom Tromey  <tom@tromey.com>
 627
 628         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 629         (struct aarch64_call_info): Add initializers.
 630         <si>: Now a std::vector.
 631         (pass_on_stack, aarch64_push_dummy_call): Update.
 632
 633 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 634             Tom Tromey  <tom@tromey.com>
 635
 636         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 637         (ppc_threads): Now a std::vector.  Now static.
 638         (hwdebug_find_thread_points_by_tid)
 639         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 640         Update.
 641
 642 2019-05-04  Tom Tromey  <tom@tromey.com>
 643
 644         * arc-tdep.c (arc_tdesc_init): Return bool.
 645
 646 2019-05-04  Tom Tromey  <tom@tromey.com>
 647
 648         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 649         Use gdb_assert_not_reached.
 650
 651 2019-05-04  Tom Tromey  <tom@tromey.com>
 652
 653         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 654         "false".
 655
 656 2019-05-04  Tom Tromey  <tom@tromey.com>
 657
 658         * arc-tdep.c (arc_tdesc_init): Use bool.
 659
 660 2019-05-04  Tom Tromey  <tom@tromey.com>
 661
 662         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 663
 664 2019-05-04  Tom Tromey  <tom@tromey.com>
 665
 666         * cli/cli-cmds.c (valid_command_p): Return bool.
 667
 668 2019-05-04  Tom Tromey  <tom@tromey.com>
 669
 670         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 671         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 672
 673 2019-05-04  Raul Tambre  <raul@tambre.ee>
 674
 675         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 676         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 677         operator for comparison.
 678
 679 2019-05-04  Tom Tromey  <tom@tromey.com>
 680
 681         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 682         (lookup_partial_symbol, print_partial_symbols)
 683         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 684         (psymbol_compare): Update.
 685         (add_psymbol_to_bcache): Clear the entire psymbol.
 686         (maintenance_check_psymtabs): Update.
 687         * psympriv.h (struct partial_symbol): Don't derive from
 688         general_symbol_info.
 689         <obj_section, unrelocated_address, address,
 690         set_unrelocated_address>: Update.
 691         <ginfo>: New member.
 692         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 693         (debug_names::write_psymbols): Update.
 694
 695 2019-05-04  Tom de Vries  <tdevries@suse.de>
 696
 697         * contrib/cc-with-tweaks.sh: Support -n arg.
 698
 699 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 700
 701         * corelow.c (core_target::detach): Ensure frame cache and
 702         register caches are cleared.
 703         inferior.c (exit_inferior_1): Likewise.
 704
 705 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 706             Tom Tromey  <tom@tromey.com>
 707
 708         * dictionary.c (collate_pending_symbols_by_language): Remove
 709         "struct" from foreach.
 710         * symtab.c (lookup_global_symbol_from_objfile)
 711         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 712         foreach.
 713         * ser-tcp.c (net_open): Remove "struct" from foreach.
 714         * objfiles.c (objfile_relocate, objfile_rebase)
 715         (objfile_has_symbols): Remove "struct" from foreach.
 716         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 717         from foreach.
 718         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 719         foreach.
 720         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 721         "struct" from foreach.
 722         * ada-lang.c (create_excep_cond_exprs)
 723         (ada_exception_catchpoint_cond_string): Remove "struct" from
 724         foreach.
 725
 726 2019-05-03  Tom Tromey  <tromey@adacore.com>
 727
 728         * ada-exp.y (convert_char_literal): Check suffix of each
 729         enumerator.
 730
 731 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 732
 733         PR ada/21406:
 734         * ada-exp.y (yywrap): Don't define.
 735         * ada-lex.l (%option): Add noyywrap
 736         (yywrap): Remove.
 737
 738 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 739
 740         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 741         _WIN32_WINNT to the XP level, unless already defined to a higher
 742         level.
 743
 744         * unittests/parse-connection-spec-selftests.c:
 745         * ser-tcp.c:
 746         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 747         override.
 748
 749         * symfile.c (find_separate_debug_file): Remove colon from the
 750         drive spec of DOS/Windows file names of the target, so that the
 751         file name produced from DEBUGDIR and the target's directory will
 752         be valid on DOS/Windows systems.
 753
 754 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * rust-lang.c (val_print_struct): Handle printing structures
 757         containing strings.
 758
 759 2019-05-02  Tom Tromey  <tromey@adacore.com>
 760
 761         * valarith.c (_initialize_valarith): Remove.
 762
 763 2019-05-01  Tom Tromey  <tromey@adacore.com>
 764
 765         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 766         bitfields.
 767
 768 2019-05-01  Tom Tromey  <tromey@adacore.com>
 769
 770         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 771         for big-endian copies.
 772
 773 2019-04-30  Ali Tamur  <tamur@google.com>
 774         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 775         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 776         (read_3_bytes): New function.
 777
 778 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 779
 780         * windows-nat.c (main_thread_id): Delete.
 781         (handle_output_debug_string): Replace main_thread_id by
 782         current_event.dwThreadId.
 783         (fake_create_process): Likewise.
 784         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 785         Do not set main_thread_id.
 786         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 787         current_event.dwThreadId.
 788         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 789
 790 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 791
 792         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 793         Use current_event.dwThreadId instead of main_thread_id.
 794
 795 2019-04-30  Tom Tromey  <tromey@adacore.com>
 796
 797         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 798         (create_excep_cond_exprs): Iterate over program spaces.
 799         (ada_exception_catchpoint_cond_string): Examine all minimal
 800         symbols for exception types.
 801
 802 2019-04-30  Tom Tromey  <tromey@adacore.com>
 803
 804         PR c++/24470:
 805         * dwarf2read.c (process_structure_scope): Handle case where type
 806         has template parameters but no symbol was created.
 807
 808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 809             Chris January  <chris.january@arm.com>
 810
 811         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 812         qualifier.
 813         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 814
 815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * f-typeprint.c (f_print_type): Update rules for printing
 818         whitespace.
 819         (f_type_print_varspec_suffix): Likewise.
 820
 821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 822             Chris January  <chris.january@arm.com>
 823
 824         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 825         function arguments.
 826
 827 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * f-lang.c (build_fortran_types): Change name of void type to
 830         lower case.
 831         * f-typeprint.c (f_type_print_base): Print the name of the void
 832         type, rather than a fixed string.
 833         * f-valprint.c (f_decorations): Use lower case void string.
 834
 835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 836             Chris January  <chris.january@arm.com>
 837
 838         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 839         types for Fortran.
 840
 841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 842             Chris January  <chris.january@arm.com>
 843             David Lecomber  <david.lecomber@arm.com>
 844
 845         * f-exp.y (BINOP_INTRINSIC): New token.
 846         (exp): New parser rule handling BINOP_INTRINSIC.
 847         (f77_keywords): Add new builtin procedures.
 848         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 849         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 850         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 851         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 852         (print_unop_subexp_f): New function.
 853         (print_binop_subexp_f): New function.
 854         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 855         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 856         (dump_subexp_body_f): Likewise.
 857         (operator_check_f): Likewise.
 858         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 859         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 860
 861 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 864         UNOP_KIND.
 865         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 866         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 867         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 868         (operator_length_f): New fuction.
 869         (print_subexp_f): New function.
 870         (op_name_f): New function.
 871         (dump_subexp_body_f): New function.
 872         (operator_check_f): New function.
 873         (exp_descriptor_f): Replace standard expression handling functions
 874         with new functions.
 875         * gdb/fortran-operator.def: New file.
 876         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 877         * gdb/std-operator.def: Remove UNOP_KIND.
 878
 879 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * std-operator.def: Remove unbalanced, stray double quote
 882         character.
 883
 884 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 885             Chris January  <chris.january@arm.com>
 886             Daniel Everett  <daniel.everett@arm.com>
 887             Nick Forrington  <nick.forrington@arm.com>
 888             Richard Bunt  <richard.bunt@arm.com>
 889
 890         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 891         of depth when printing anonymous structs or unions.
 892         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 893         Don't print either the top-level value, or the children if the
 894         max-depth is exceeded.
 895         (ppscm_print_children): When printing the key of a map, allow one
 896         extra level of depth.
 897         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 898         print either the top-level value, or the children if the max-depth
 899         is exceeded.
 900         (print_children): When printing the key of a map, allow one extra
 901         level of depth.
 902         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 903         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 904         (user_print_options): Initialise max_depth field.
 905         (val_print_scalar_or_string_type_p): New function.
 906         (val_print): Check to see if the max depth has been reached.
 907         (val_print_check_max_depth): Define new function.
 908         (show_print_max_depth): New function.
 909         (_initialize_valprint): Add 'print max-depth' option.
 910         * valprint.h (struct value_print_options) <max_depth>: New field.
 911         (val_print_check_max_depth): Declare new function.
 912         * NEWS: Document new feature.
 913
 914 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * ada-lang.c (ada_language_defn): Initialise new field.
 917         * c-lang.c (c_is_string_type_p): New function.
 918         (c_language_defn): Initialise new field.
 919         (cplus_language_defn): Initialise new field.
 920         (asm_language_defn): Initialise new field.
 921         (minimal_language_defn): Initialise new field.
 922         * c-lang.h (c_is_string_type_p): Declare new function.
 923         * d-lang.c (d_language_defn): Initialise new field.
 924         * f-lang.c (f_is_string_type_p): New function.
 925         (f_language_defn): Initialise new field.
 926         * go-lang.c (go_is_string_type_p): New function.
 927         (go_language_defn): Initialise new field.
 928         * language.c (default_is_string_type_p): New function.
 929         (unknown_language_defn): Initialise new field.
 930         (auto_language_defn): Initialise new field.
 931         * language.h (struct language_defn) <la_is_string_type_p>: New
 932         member variable.
 933         (default_is_string_type_p): Declare new function.
 934         * m2-lang.c (m2_language_defn): Initialise new field.
 935         * objc-lang.c (objc_language_defn): Initialise new field.
 936         * opencl-lang.c (opencl_language_defn): Initialise new field.
 937         * p-lang.c (pascal_is_string_type_p): New function.
 938         (pascal_language_defn): Initialise new field.
 939         * rust-lang.c (rust_is_string_type_p): New function.
 940         (rust_language_defn): Initialise new field.
 941
 942 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 945         New field.
 946         * ada-lang.c (ada_language_defn): Initialise new field.
 947         * c-lang.c (c_language_defn): Likewise.
 948         (cplus_language_defn): Likewise.
 949         (asm_language_defn): Likewise.
 950         (minimal_language_defn): Likewise.
 951         * d-lang.c (d_language_defn): Likewise.
 952         * f-lang.c (f_language_defn): Likewise.
 953         * go-lang.c (go_language_defn): Likewise.
 954         * language.c (unknown_language_defn): Likewise.
 955         (auto_language_defn): Likewise.
 956         * m2-lang.c (m2_language_defn): Likewise.
 957         * objc-lang.c (objc_language_defn): Likewise.
 958         * opencl-lang.c (opencl_language_defn): Likewise.
 959         * p-lang.c (pascal_language_defn): Likewise.
 960         * rust-lang.c (rust_language_defn): Likewise.
 961
 962 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * ada-lang.c (ada_is_character_type): Change return type to bool.
 965         (ada_is_string_type): Likewise.
 966         * ada-lang.h (ada_is_character_type): Update declaration
 967         (ada_is_string_type): Likewise.
 968
 969 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 970
 971         Support style in 'frame|thread apply'
 972
 973         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 974         * record.c (record_start, record_stop): Update callers of
 975         execute_command_to_string with false.
 976         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 977         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 978         methods.
 979         (class string_file): New constructor with term_out parameter.
 980         Override methods term_out and can_emit_style_escape.  New member
 981         term_out.
 982         (class stdio_file): Override can_emit_style_escape.
 983         (class tee_file): Override term_out and can_emit_style_escape.
 984         * utils.h (can_emit_style_escape): Remove.
 985         * utils.c (can_emit_style_escape): Likewise.
 986         Update all callers of can_emit_style_escape (SOMESTREAM) to
 987         SOMESTREAM->can_emit_style_escape.
 988         * source-cache.c (source_cache::get_source_lines): Likewise.
 989         * stack.c (frame_apply_command_count): Call execute_command_to_string
 990         passing the term_out characteristic of the current gdb_stdout.
 991         * thread.c (thr_try_catch_cmd): Likewise.
 992         * top.c (execute_command_to_string): pass term_out parameter
 993         to construct the string_file for the command output.
 994         * ui-file.c (term_cli_styling): New function (most code moved
 995         from utils.c can_emit_style_escape).
 996         (string_file::string_file, string_file::can_emit_style_escape,
 997         stdio_file::can_emit_style_escape, tee_file::term_out,
 998         tee_file::can_emit_style_escape): New functions.
 999
1000 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1001
1002         * NEWS: Mention the new set|show may-call-functions.
1003         * infcall.c (may_call_functions_p): New variable.
1004         (show_may_call_functions_p): New function.
1005         (call_function_by_hand_dummy): Throws an error if not
1006         may-call-functions.
1007         (_initialize_infcall): Call add_setshow_boolean_cmd for
1008         may-call-functions.
1009
1010 2019-04-25  Keith Seitz  <keiths@redhat.com>
1011
1012         PR c++/24367
1013         * cp-support.c (inspect_type): Don't attempt substitutions
1014         of symbol with the same name.
1015
1016 2019-04-25  Tom Tromey  <tromey@adacore.com>
1017
1018         PR gdb/24475:
1019         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1020         static.
1021
1022 2019-04-25  Tom Tromey  <tromey@adacore.com>
1023
1024         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1025         rvalue reference.
1026         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1027         (gdb_xml_parser::parse): Use std::move.
1028         * python/python-internal.h (gdbpy_convert_exception): Take a const
1029         reference.
1030         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1031         std::move.
1032         * python/py-utils.c (gdbpy_convert_exception): Take a const
1033         reference.
1034         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1035         Use std::move.
1036         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1037         Use std::move.
1038         * mi/mi-main.c (mi_print_exception): Take a const reference.
1039         * main.c (handle_command_errors): Take a const reference.
1040         * linespec.c (parse_linespec): Use std::move.
1041         * infcall.c (run_inferior_call): Use std::move.
1042         (call_function_by_hand_dummy): Use std::move.
1043         * exec.c (try_open_exec_file): Use std::move.
1044         * exceptions.h (exception_print, exception_fprintf)
1045         (exception_print_same): Update.
1046         * exceptions.c (print_exception, exception_print)
1047         (exception_fprintf, exception_print_same): Change parameters to
1048         const reference.
1049         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1050         * common/new-op.c: Use std::move.
1051         * common/common-exceptions.h (struct gdb_exception): Add move
1052         constructor.
1053         (struct gdb_exception_error, struct gdb_exception_quit, struct
1054         gdb_quit_bad_alloc): Change constructor to move constructor.
1055         (throw_exception): Change parameter to rvalue reference.
1056         * common/common-exceptions.c (throw_exception): Take rvalue
1057         reference.
1058         * cli/cli-interp.c (safe_execute_command): Use std::move.
1059         * breakpoint.c (insert_bp_location, location_to_sals): Use
1060         std::move.
1061
1062 2019-04-25  Tom Tromey  <tromey@adacore.com>
1063
1064         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1065         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1066         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1067         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1068         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1069         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1070         guile/scm-value.c: Use unpack.
1071         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1072         gdbscm_gdb_exception.
1073         (gdbscm_throw_gdb_exception): Likewise.
1074         (struct gdbscm_gdb_exception): New.
1075         (unpack): New function.
1076         (gdbscm_wrap): Use unpack.
1077
1078 2019-04-25  Tom Tromey  <tromey@adacore.com>
1079
1080         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1081         (gdb_rl_callback_handler): Use std::move.
1082         * common/common-exceptions.h (struct gdb_exception): Add move
1083         assignment operator.
1084         (throw_exception_sjlj): Change "exception" to const reference.
1085         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1086         (throw_exception_sjlj): Change "exception" to const reference.
1087
1088 2019-04-25  Tom Tromey  <tromey@adacore.com>
1089
1090         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1091         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1092         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1093         Update.
1094         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1095         Update.
1096         * mi/mi-interp.c (mi_interp::exec): Update.
1097         * linespec.c (parse_linespec): Update.
1098         * infcall.c (run_inferior_call): Update.
1099         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1100         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1101         (gdbscm_lookup_global_symbol): Update.
1102         * guile/scm-param.c (gdbscm_parameter_value): Update.
1103         * guile/scm-frame.c (gdbscm_frame_read_register)
1104         (gdbscm_frame_read_var): Update.
1105         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1106         * exec.c (try_open_exec_file): Update.
1107         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1108         (gdb_rl_callback_handler): Update.
1109         * common/common-exceptions.h (exception_none): Don't declare.
1110         * common/common-exceptions.c (exception_none): Don't define.
1111         (struct catcher) <exception>: Update.
1112         * cli/cli-interp.c (safe_execute_command): Update.
1113         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1114
1115 2019-04-25  Ali Tamur  <tamur@google.com>
1116
1117         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1118         (read_attribute_value): Likewise.
1119         (dwarf2_read_addr_index): Update comment.
1120         (read_str_index): Add DW_FORM_strx.
1121         (dwarf2_string_attr): Likewise.
1122         (dwarf2_const_value_attr): Likewise.
1123         (dump_die_shallow): Likewise.
1124         (dwarf2_fetch_constant_bytes): Likewise.
1125         (skip_form_bytes): Likewise.
1126         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1127
1128 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1129
1130         PR corefiles/11608
1131         PR corefiles/18187
1132         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1133         OFFSET.  Verify if current mapping contains an ELF header.
1134         (linux_find_memory_regions_full): Adjust call to
1135         dump_mapping_p.
1136
1137 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1138             Kang Li <kanglictf@gmail.com>
1139
1140         PR gdb/21600
1141
1142         * dwarf2-frame.c (read_initial_length): Be consistent about using
1143         unsigned representation of length.
1144         (decode_frame_entry_1): Likewise.  Check for wraparound of
1145         end pointer as well as buffer overflow.
1146
1147 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1148
1149         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1150         "vq".
1151
1152 2019-04-24  Tom Tromey  <tromey@adacore.com>
1153
1154         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1155
1156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * s12z-tdep.c (s12z_unwind_pc): Delete.
1159         (s12z_unwind_sp): Delete.
1160         (s12z_gdbarch_init): Don't register deleted functions with
1161         gdbarch.
1162
1163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * rl78-tdep.c (rl78_unwind_sp): Delete.
1166         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1167
1168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1171         (xstormy16_unwind_pc): Delete.
1172         (xstormy16_dummy_id): Delete.
1173         (xstormy16_gdbarch_init): Don't register deleted functions with
1174         gdbarch.
1175
1176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * vax-tdep.c (vax_unwind_pc): Delete.
1179         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1180
1181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * v850-tdep.c (v850_unwind_sp): Delete.
1184         (v850_unwind_pc): Delete.
1185         (v850_dummy_id): Delete.
1186         (v850_gdbarch_init): Don't register deleted functions with
1187         gdbarch.
1188
1189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1192         (tilegx_unwind_pc): Delete.
1193         (tilegx_unwind_dummy_id): Delete.
1194         (tilegx_gdbarch_init): Don't register deleted functions with
1195         gdbarch.
1196
1197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1200         (tic6x_dummy_id): Delete.
1201         (tic6x_gdbarch_init): Don't register deleted functions with
1202         gdbarch.
1203
1204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * sparc-tdep.c (sparc_unwind_pc): Delete.
1207         (sparc32_gdbarch_init): Don't register deleted function with
1208         gdbarch.
1209
1210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * sh-tdep.c (sh_unwind_sp): Delete.
1213         (sh_unwind_pc): Delete.
1214         (sh_dummy_id): Delete.
1215         (sh_gdbarch_init): Don't register deleted functions with
1216         gdbarch.
1217
1218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * score-tdep.c (score_unwind_sp): Delete.
1221         (score_unwind_pc): Delete.
1222         (score_dummy_id): Delete.
1223         (score_gdbarch_init): Don't register deleted functions with
1224         gdbarch.
1225
1226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * rx-tdep.c (rx_unwind_pc): Delete.
1229         (rx_unwind_sp): Delete.
1230         (rx_dummy_id): Delete.
1231         (rx_gdbarch_init): Don't register deleted functions with
1232         gdbarch.  Update comment.
1233
1234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1237         (rs6000_dummy_id): Delete.
1238         (rs6000_gdbarch_init): Don't register deleted functions with
1239         gdbarch.
1240
1241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * or1k-tdep.c (or1k_dummy_id): Delete.
1244         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1245
1246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * nios2-tdep.c (nios2_dummy_id): Delete.
1249         (nios2_unwind_sp): Delete.
1250         (nios2_gdbarch_init): Don't register deleted functions with
1251         gdbarch.
1252
1253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * nds32-tdep.c (nds32_dummy_id): Delete.
1256         (nds32_unwind_pc): Delete.
1257         (nds32_unwind_sp): Delete.
1258         (nds32_gdbarch_init): Don't register deleted functions with
1259         gdbarch.
1260
1261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * msp430-tdep.c (msp430_unwind_pc): Delete.
1264         (msp430_unwind_sp): Delete.
1265         (msp430_dummy_id): Delete.
1266         (msp430_gdbarch_init): Don't register deleted functions with
1267         gdbarch.
1268
1269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * moxie-tdep.c (moxie_unwind_sp): Delete.
1272         (moxie_unwind_pc): Delete.
1273         (moxie_dummy_id): Delete.
1274         (moxie_gdbarch_init): Don't register deleted functions with
1275         gdbarch.
1276
1277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1280         (mn10300_unwind_pc): Delete.
1281         (mn10300_unwind_sp): Delete.
1282         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1283         mn10300_unwind_sp.
1284         (mn10300_frame_unwind_init): Don't register deleted functions with
1285         gdbarch.
1286
1287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * mep-tdep.c (mep_unwind_pc): Delete.
1290         (mep_unwind_sp): Delete.
1291         (mep_dummy_id): Delete.
1292         (mep_gdbarch_init): Don't register deleted functions with
1293         gdbarch.
1294
1295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1298         (m68hc11_unwind_sp): Delete.
1299         (m68hc11_gdbarch_init): Don't register deleted functions with
1300         gdbarch.
1301
1302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1303
1304         * m32r-tdep.c (m32r_unwind_sp): Delete.
1305         (m32r_unwind_pc): Delete.
1306         (m32r_dummy_id): Delete.
1307         (m32r_gdbarch_init): Don't register deleted functions with
1308         gdbarch.
1309
1310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * m32c-tdep.c (m32c_unwind_pc): Delete.
1313         (m32c_unwind_sp): Delete.
1314         (m32c_dummy_id): Delete.
1315         (m32c_gdbarch_init): Don't register deleted functions with
1316         gdbarch.
1317
1318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1321         (lm32_unwind_pc): Delete.
1322         (lm32_dummy_id): Delete.
1323         (lm32_gdbarch_init): Don't register deleted functions with
1324         gdbarch.
1325
1326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1329         (iq2000_unwind_pc): Delete.
1330         (iq2000_dummy_id): Delete.
1331         (iq2000_gdbarch_init): Don't register deleted functions with
1332         gdbarch.
1333
1334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * nds32-tdep.c (nds32_type_align): Delete.
1337         (nds32_push_dummy_call): Use type_align instead.
1338
1339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * arm-tdep.c (arm_type_align): Only handle vector override case.
1342         (arm_push_dummy_call): Use type_align.
1343         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1344
1345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1348         case.
1349         (pass_on_stack): Use type_align.
1350         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1351         function.
1352
1353 2019-04-23  Tom Tromey  <tromey@adacore.com>
1354
1355         * dwarf2read.c (line_header::file_name_at): Remove unused
1356         overload.
1357
1358 2019-04-23  Tom de Vries  <tdevries@suse.de>
1359
1360         PR gdb/24438
1361         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1362         invocation.
1363
1364
1365 2019-03-27  Ali Tamur  <tamur@google.com>
1366
1367         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1368         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1369         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1370         (dwarf_expr_context::get_addr_index): Likewise
1371         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1372         (symbol_needs_eval_context::get_addr_index): Likewise
1373         (disassemble_dwarf_expression): Add DW_OP_addrx
1374         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1375         (read_cutu_die_from_dwo): Update comment
1376         (skip_one_die): Add DW_FORM_addrx
1377         (read_attribute_value): Likewise
1378         (var_decode_location): Add DW_OP_addrx
1379         (dwarf2_const_value_attr): Add DW_FORM_addrx
1380         (dump_die_shallow): Likewise
1381         (dwarf2_fetch_constant_bytes): Likewise
1382         (decode_locdesc): Add DW_OP_addrx
1383         (skip_form_bytes): Add DW_FORM_addrx
1384
1385 2019-04-22  Ali Tamur  <tamur@google.com>
1386
1387         * MAINTAINERS (Write After Approval): Add self.
1388
1389 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1390
1391         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1392         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1393         (open_symbol_file_object): Likewise.
1394         (svr4_default_sos): Add info parameter.
1395         (svr4_read_so_list): Likewise.
1396         (svr4_current_sos_direct): Adjust functions calls to pass down
1397         info.
1398         (svr4_current_sos_1): Add info parameter.
1399         (svr4_current_sos): Call get_svr4_info, pass info down to
1400         svr4_current_sos_1.
1401         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1402         get_svr4_info.
1403         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1404         get_svr4_info.
1405         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1406         to get_svr4_info.
1407         (probes_table_remove_objfile_probes): Likewise.
1408         (register_solib_event_probe): Add info parameter.
1409         (solist_update_incremental): Pass info parameter down to
1410         svr4_read_so_list.
1411         (disable_probes_interface): Add info parameter.
1412         (svr4_handle_solib_event): Pass current_program_space to
1413         get_svr4_info.  Adjust disable_probes_interface cleanup.
1414         (svr4_create_probe_breakpoints): Add info parameter, pass it
1415         down to register_solib_event_probe.
1416         (svr4_create_solib_event_breakpoints): Add info parameter,
1417         pass it down to svr4_create_probe_breakpoints.
1418         (enable_break): Pass info down to
1419         svr4_create_solib_event_breakpoints.
1420         (svr4_solib_create_inferior_hook): Pass current_program_space to
1421         get_svr4_info.
1422         (svr4_clear_solib): Likewise.
1423
1424 2019-04-22  Pedro Alves  <palves@redhat.com>
1425
1426         * solib-svr4.c (svr4_free_objfile_observer): New.
1427         (probe_and_action::objfile): New field.
1428         (probes_table_htab_remove_objfile_probes)
1429         (probes_table_remove_objfile_probes): New functions.
1430         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1431         in the new probe_and_action.  Don't store the probe in 'lookup'.
1432         (svr4_create_probe_breakpoints): Pass objfile to
1433         register_solib_event_probe.
1434         (_initialize_svr4_solib): Register a free_objfile observer.
1435
1436 2019-04-19  Tom Tromey  <tom@tromey.com>
1437
1438         * common/queue.h: Remove.
1439
1440 2019-04-19  Tom Tromey  <tom@tromey.com>
1441
1442         * event-loop.c: Don't include "common/queue.h".
1443
1444 2019-04-19  Tom Tromey  <tom@tromey.com>
1445
1446         * remote.c (remote_target): Use delete.
1447         * remote-notif.h: Include <list>, not "common/queue.h".
1448         (notif_client_p): Remove typedef.
1449         (remote_notif_state): Add constructor, destructor, initializer.
1450         <notif_queue>: Now a std::list.
1451         (remote_notif_state_xfree): Don't declare.
1452         * remote-notif.c (remote_notif_process, handle_notification)
1453         (remote_notif_state_allocate): Update.
1454         (~remote_notif_state): Rename from remote_notif_state_xfree.
1455
1456 2019-04-19  Tom Tromey  <tom@tromey.com>
1457
1458         * symfile.c (reread_symbols): Update.
1459         * objfiles.c (objfile_register_static_link)
1460         (objfile_lookup_static_link): Update
1461         (~objfile) Don't delete static_links.
1462         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1463
1464 2019-04-19  Tom Tromey  <tom@tromey.com>
1465
1466         * type-stack.h (struct type_stack) <insert>: Constify string.
1467         * type-stack.c (type_stack::insert): Constify string.
1468         * gdbtypes.h (lookup_template_type): Update.
1469         (address_space_name_to_int): Update.
1470         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1471         const.
1472         (lookup_template_type): Make name const.
1473         * c-exp.y: Update rules.
1474         (lex_one_token, classify_name, classify_inner_name)
1475         (c_print_token): Update.
1476         * p-exp.y: Update rules.
1477         (yylex): Update.
1478         * f-exp.y: Update rules.
1479         (yylex): Update.
1480         * d-exp.y: Update rules.
1481         (lex_one_token, classify_name, classify_inner_name): Update.
1482         * parse.c (write_dollar_variable, copy_name): Return std::string.
1483         * parser-defs.h (copy_name): Change return type.
1484         * m2-exp.y: Update rules.
1485         (yylex): Update.
1486         * go-exp.y (lex_one_token): Update.
1487         Update rules.
1488         (classify_unsafe_function, classify_packaged_name)
1489         (classify_name, yylex): Update.
1490
1491 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1492
1493         * configure.ac: add --enable-source-highlight switch.
1494         * configure: Regenerate.
1495         * top.c (print_gdb_version): plumb --enable-source-highlight
1496         status to "show configuration".
1497
1498 2019-04-19  Tom Tromey  <tromey@adacore.com>
1499
1500         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1501         Check ADA_TYPE_P.
1502         (empty_record, ada_template_to_fixed_record_type_1)
1503         (template_to_static_fixed_type)
1504         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1505         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1506         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1507         macros.
1508
1509 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1510
1511         PR symtab/24423:
1512         * source.c (print_source_lines_base): Advance "iter" when a
1513         control character is seen.
1514
1515 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1516
1517         * inferior.h (struct infcall_suspend_state_deleter):
1518         Catch exception in destructor to avoid crash.
1519
1520 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1521
1522         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1523         close to the add_com "shell".
1524
1525 2019-04-18  Tom Tromey  <tromey@adacore.com>
1526
1527         * process-stratum-target.h (class process_stratum_target)
1528         <stratum>: Add "final".
1529
1530 2019-04-17  Tom Tromey  <tromey@adacore.com>
1531
1532         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1533         against nullptr before use.
1534
1535 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1536
1537         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1538
1539 2019-04-17  Jim Wilson  <jimw@sifive.com>
1540             Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1543         code read might fail, assume 4-byte breakpoint in that case.
1544
1545 2019-04-15  Leszek Swirski  <leszeks@google.com>
1546
1547         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1548         rather than a hand-rolled POD check when checking for forced MEMORY
1549         classification.
1550
1551 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1552
1553         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1554         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1555         function.
1556         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1557         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1558         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1559         declaration.
1560
1561 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1562
1563         * aarch64-linux-nat.c
1564         (aarch64_linux_nat_target::thread_architecture): Add override.
1565         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1566         each VQ.
1567
1568 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1569
1570         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1571
1572 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1575         target types of size 96-bits, add some additional comments, and
1576         check that the builtin type we found was the correct size.
1577
1578 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1579
1580         * utils.c (prompt_for_continue): Don't restore the styling at the
1581         end, as applied_style has the wrong value.  This fixes styling in
1582         long lists of file names that are interrupted by the "Continue?"
1583         prompt.
1584
1585 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1588         * c-lang.c (c_language_defn): Likewise.
1589         (cplus_language_defn): Likewise.
1590         (asm_language_defn): Likewise.
1591         (minimal_language_defn): Likewise.
1592         * d-lang.c (d_language_defn): Likewise.
1593         * f-lang.c (f_language_defn): Likewise.
1594         * go-lang.c (go_language_defn): Likewise.
1595         * language.c (unknown_language_defn): Likewise.
1596         (auto_language_defn): Likewise.
1597         * language.h (struct language_defn): Remove la_magic field.
1598         (LANG_MAGIC): Delete.
1599         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1600         * objc-lang.c (objc_language_defn): Likewise.
1601         * opencl-lang.c (opencl_language_defn): Likewise.
1602         * p-lang.c (pascal_language_defn): Likewise.
1603         * rust-lang.c (rust_language_defn): Likewise.
1604
1605 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * riscv-tdep.c (riscv_type_align): New function.
1608         (riscv_type_alignment): Delete.
1609         (riscv_arg_location): Use 'type_align'.
1610         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1611
1612 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1613
1614         * gdbtypes.c (type_align): A struct with no non-static fields also
1615         has alignment of 1.
1616
1617 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1620         component to 0.
1621         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1622         member.
1623         (riscv_struct_info::analyse): New implementation using new
1624         analyse_inner member function.
1625         (riscv_struct_info::field_offset): New member function.
1626         (riscv_struct_info::m_offsets): New member variable.
1627         (riscv_struct_info::analyse_inner): New private member function,
1628         takes the old implementation of riscv_struct_info::analyse but
1629         extended to track field offsets.
1630         (riscv_call_arg_struct): Update the struct folding special cases
1631         to handle cases where empty C++ structs, which are non-zero
1632         length, are found.
1633         (riscv_arg_location): Initialise the length of each location, a
1634         non-zero length now indicates the location is in use.
1635         (riscv_push_dummy_call): Allow for the first location having a
1636         non-zero offset when setting up arguments.
1637         (riscv_return_value): Likewise, but for return values.
1638
1639 2019-04-11  Tom Tromey  <tromey@adacore.com>
1640
1641         * utils.c (internal_vproblem): Make "msg" const.
1642
1643 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1644
1645         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1646         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1647         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1648         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1649
1650 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1651
1652         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1653         function.
1654         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1655         of amd64_collect_native_gregset.
1656         (amd64_linux_nat_target::store_registers): Likewise.
1657
1658 2019-04-10  Tom Tromey  <tom@tromey.com>
1659
1660         * symtab.c (lookup_global_symbol_from_objfile)
1661         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1662         * objfiles.h (class separate_debug_iterator): New.
1663         (class separate_debug_range): New.
1664         (struct objfile) <separate_debug_objfiles>: New method.
1665         (objfile_separate_debug_iterate): Don't declare.
1666         * objfiles.c (separate_debug_iterator::operator++): Rename from
1667         objfile_separate_debug_iterate.
1668         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1669         iterator.
1670         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1671         iterator.
1672
1673 2019-04-10  Tom Tromey  <tom@tromey.com>
1674
1675         * symfile.c (reread_symbols): Remove old comment.
1676         * objfiles.c (free_all_objfiles): Fix a typo.
1677
1678 2019-04-10  Tom Tromey  <tom@tromey.com>
1679
1680         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1681         * minsyms.c (lookup_minimal_symbol): Use foreach.
1682         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1683         (lookup_minimal_symbol_solib_trampoline): Likewise.
1684         * symfile.c (reread_symbols): Use foreach.
1685
1686 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1687             Tom Tromey  <tromey@adacore.com>
1688
1689         PR rust/24414:
1690         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1691         (rust_lex_int_test): Change "value" to be LONGEST.
1692         (rust_lex_tests): Add test for long integer literal.
1693
1694 2019-04-09  Tom Tromey  <tromey@adacore.com>
1695
1696         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1697         to bool.
1698         (extended_remote_target::attach): Update.
1699         (remote_target::remote_notice_new_inferior): Update.
1700         (remote_target::add_current_inferior_and_thread): Update.
1701         * inferior.c (exit_inferior_1): Use "false".
1702         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1703
1704 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1705
1706         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1707         the "start" command.
1708
1709 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1710
1711         * python/py-inferior.c (infpy_thread_from_thread_handle):
1712         Adjust comments to reflect renaming of thread_from_thread_handle
1713         to thread_from_handle.  Adjust keywords.  Fix type error message.
1714         (inferior_object_methods): Add thread_from_handle.  Retain
1715         thread_from_thread_handle, but mark it as deprecated.
1716
1717 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1718
1719         * gdbthread.h (find_thread_by_handle): Revise declaration.
1720         * thread.c (find_thread_by_handle): Likewise.  Adjust
1721         implementation too.
1722         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1723         support for buffer objects as handles.
1724
1725 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1726
1727         * python/py-infthread.c (thpy_thread_handle): New function.
1728         (thread_object_methods): Register thpy_thread_handle.
1729
1730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1731
1732         * gdbthread.h (thread_to_thread_handle): Declare.
1733         * thread.c (gdbtypes.h): Include.
1734         (thread_to_thread_handle): New function.
1735
1736         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1737         (target_thread_info_to_thread_handle): Declare.
1738         * target.c (target_thread_info_to_thread_handle): New function.
1739         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1740         * target-delegates.c: Regenerate.
1741
1742         * linux-thread-db.c (class thread_db_target): Add method
1743         thread_info_to_thread_handle.
1744         (thread_db_target::thread_info_to_thread_handle): Define.
1745         * remote.c (class remote_target): Add new method
1746         thread_info_to_thread_handle.
1747         (remote_target::thread_info_to_thread_handle): Define.
1748
1749 2019-04-08  Pedro Alves  <palves@redhat.com>
1750
1751         * common/common-exceptions.c (throw_exception): Don't create
1752         named object to throw; throw directly.
1753         (throw_it): Likewise.  Don't initialize gdb_exception::message
1754         here, with new; pass FMT and AP to the ctor instead.
1755         * common/common-exceptions.h: Include <string>.
1756         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1757         const char *, va_list)): New ctor.  Use std::make_shared.
1758         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1759         errors)): Delete.
1760         (gdb_exception_error::gdb_exception_error(enum errors, const char
1761         *, va_list)): New.
1762         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1763         Add assertion.
1764         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1765         errors)): Delete.
1766         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1767         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1768         Add assertion.
1769
1770 2019-04-08  Tom Tromey  <tom@tromey.com>
1771
1772         * valops.c (value_rtti_indirect_type): Replace throw_exception
1773         with throw.
1774         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1775         with throw.
1776         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1777         throw.
1778         * target.c (target_translate_tls_address): Replace throw_exception
1779         with throw.
1780         * stack.c (frame_apply_command_count): Replace throw_exception
1781         with throw.
1782         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1783         throw.
1784         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1785         with throw.
1786         * rs6000-tdep.c (rs6000_frame_cache)
1787         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1788         * remote.c: Replace throw_exception with throw.
1789         * record-full.c (record_full_message, record_full_wait_1)
1790         (record_full_restore): Replace throw_exception with throw.
1791         * record-btrace.c:
1792         (get_thread_current_frame_id, record_btrace_start_replaying)
1793         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1794         (cmd_record_btrace_start): Replace throw_exception with throw.
1795         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1796         throw.
1797         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1798         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1799         * linespec.c:
1800         (find_linespec_symbols): Replace throw_exception with throw.
1801         * infrun.c (displaced_step_prepare, resume): Replace
1802         throw_exception with throw.
1803         * infcmd.c (post_create_inferior): Replace throw_exception with
1804         throw.
1805         * inf-loop.c (inferior_event_handler): Replace throw_exception
1806         with throw.
1807         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1808         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1809         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1810         (get_prev_frame_always, get_frame_pc_if_available)
1811         (get_frame_address_in_block_if_available, get_frame_language):
1812         Replace throw_exception with throw.
1813         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1814         throw_exception with throw.
1815         * eval.c (fetch_subexp_value, evaluate_var_value)
1816         (evaluate_funcall, evaluate_subexp_standard): Replace
1817         throw_exception with throw.
1818         * dwarf2loc.c (call_site_find_chain)
1819         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1820         Replace throw_exception with throw.
1821         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1822         with throw.
1823         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1824         throw.
1825         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1826         * completer.c (complete_line_internal): Replace throw_exception
1827         with throw.
1828         * compile/compile-object-run.c (compile_object_run): Replace
1829         throw_exception with throw.
1830         * cli/cli-script.c (process_next_line): Replace throw_exception
1831         with throw.
1832         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1833         (btrace_enable, btrace_maint_update_pt_packets): Replace
1834         throw_exception with throw.
1835         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1836         throw_exception with throw.
1837         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1838         throw_exception with throw.
1839         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1840         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1841         * aarch64-tdep.c (aarch64_make_prologue_cache)
1842         (aarch64_make_stub_cache): Replace throw_exception with throw.
1843
1844 2019-04-08  Tom Tromey  <tom@tromey.com>
1845
1846         * common/common-exceptions.c (throw_exception): Rename from
1847         throw_exception_cxx.  Remove old copy.  Make argument const.
1848         (throw_it): Create and throw exception objects directly.
1849         * common/common-exceptions.h (throw_exception): Make argument
1850         const.
1851         (struct gdb_exception_error): Add constructor.
1852         (struct gdb_exception_quit): Add constructor.
1853
1854 2019-04-08  Tom Tromey  <tom@tromey.com>
1855
1856         * common/common-exceptions.h (exception_rethrow): Don't declare.
1857         (TRY_SJLJ): Update comment.
1858         (TRY, CATCH, END_CATCH): Remove.
1859         * common/common-exceptions.c (exception_rethrow): Remove.
1860
1861 2019-04-08  Tom Tromey  <tom@tromey.com>
1862
1863         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1864         Remove.
1865         (gdb_exception_error): Rename from
1866         gdb_exception_RETURN_MASK_ERROR.
1867         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1868         (gdb_quit_bad_alloc): Update.
1869         * aarch64-tdep.c: Update.
1870         * ada-lang.c: Update.
1871         * ada-typeprint.c: Update.
1872         * ada-valprint.c: Update.
1873         * amd64-tdep.c: Update.
1874         * arch-utils.c: Update.
1875         * break-catch-throw.c: Update.
1876         * breakpoint.c: Update.
1877         * btrace.c: Update.
1878         * c-varobj.c: Update.
1879         * cli/cli-cmds.c: Update.
1880         * cli/cli-interp.c: Update.
1881         * cli/cli-script.c: Update.
1882         * common/common-exceptions.c: Update.
1883         * common/new-op.c: Update.
1884         * common/selftest.c: Update.
1885         * compile/compile-c-symbols.c: Update.
1886         * compile/compile-cplus-symbols.c: Update.
1887         * compile/compile-object-load.c: Update.
1888         * compile/compile-object-run.c: Update.
1889         * completer.c: Update.
1890         * corelow.c: Update.
1891         * cp-abi.c: Update.
1892         * cp-support.c: Update.
1893         * cp-valprint.c: Update.
1894         * darwin-nat.c: Update.
1895         * disasm-selftests.c: Update.
1896         * dtrace-probe.c: Update.
1897         * dwarf-index-cache.c: Update.
1898         * dwarf-index-write.c: Update.
1899         * dwarf2-frame-tailcall.c: Update.
1900         * dwarf2-frame.c: Update.
1901         * dwarf2loc.c: Update.
1902         * dwarf2read.c: Update.
1903         * eval.c: Update.
1904         * event-loop.c: Update.
1905         * event-top.c: Update.
1906         * exec.c: Update.
1907         * f-valprint.c: Update.
1908         * fbsd-tdep.c: Update.
1909         * frame-unwind.c: Update.
1910         * frame.c: Update.
1911         * gdbtypes.c: Update.
1912         * gnu-v3-abi.c: Update.
1913         * guile/guile-internal.h: Update.
1914         * guile/scm-block.c: Update.
1915         * guile/scm-breakpoint.c: Update.
1916         * guile/scm-cmd.c: Update.
1917         * guile/scm-disasm.c: Update.
1918         * guile/scm-frame.c: Update.
1919         * guile/scm-lazy-string.c: Update.
1920         * guile/scm-math.c: Update.
1921         * guile/scm-param.c: Update.
1922         * guile/scm-ports.c: Update.
1923         * guile/scm-pretty-print.c: Update.
1924         * guile/scm-symbol.c: Update.
1925         * guile/scm-symtab.c: Update.
1926         * guile/scm-type.c: Update.
1927         * guile/scm-value.c: Update.
1928         * i386-linux-tdep.c: Update.
1929         * i386-tdep.c: Update.
1930         * inf-loop.c: Update.
1931         * infcall.c: Update.
1932         * infcmd.c: Update.
1933         * infrun.c: Update.
1934         * jit.c: Update.
1935         * language.c: Update.
1936         * linespec.c: Update.
1937         * linux-fork.c: Update.
1938         * linux-nat.c: Update.
1939         * linux-tdep.c: Update.
1940         * linux-thread-db.c: Update.
1941         * main.c: Update.
1942         * mi/mi-cmd-break.c: Update.
1943         * mi/mi-cmd-stack.c: Update.
1944         * mi/mi-interp.c: Update.
1945         * mi/mi-main.c: Update.
1946         * objc-lang.c: Update.
1947         * p-valprint.c: Update.
1948         * parse.c: Update.
1949         * ppc-linux-tdep.c: Update.
1950         * printcmd.c: Update.
1951         * python/py-arch.c: Update.
1952         * python/py-breakpoint.c: Update.
1953         * python/py-cmd.c: Update.
1954         * python/py-finishbreakpoint.c: Update.
1955         * python/py-frame.c: Update.
1956         * python/py-framefilter.c: Update.
1957         * python/py-gdb-readline.c: Update.
1958         * python/py-inferior.c: Update.
1959         * python/py-infthread.c: Update.
1960         * python/py-lazy-string.c: Update.
1961         * python/py-linetable.c: Update.
1962         * python/py-objfile.c: Update.
1963         * python/py-param.c: Update.
1964         * python/py-prettyprint.c: Update.
1965         * python/py-progspace.c: Update.
1966         * python/py-record-btrace.c: Update.
1967         * python/py-record.c: Update.
1968         * python/py-symbol.c: Update.
1969         * python/py-type.c: Update.
1970         * python/py-unwind.c: Update.
1971         * python/py-utils.c: Update.
1972         * python/py-value.c: Update.
1973         * python/python.c: Update.
1974         * record-btrace.c: Update.
1975         * record-full.c: Update.
1976         * remote-fileio.c: Update.
1977         * remote.c: Update.
1978         * riscv-tdep.c: Update.
1979         * rs6000-aix-tdep.c: Update.
1980         * rs6000-tdep.c: Update.
1981         * rust-exp.y: Update.
1982         * rust-lang.c: Update.
1983         * s390-tdep.c: Update.
1984         * selftest-arch.c: Update.
1985         * solib-dsbt.c: Update.
1986         * solib-frv.c: Update.
1987         * solib-spu.c: Update.
1988         * solib-svr4.c: Update.
1989         * solib.c: Update.
1990         * sparc64-linux-tdep.c: Update.
1991         * stack.c: Update.
1992         * symfile-mem.c: Update.
1993         * symmisc.c: Update.
1994         * target.c: Update.
1995         * thread.c: Update.
1996         * top.c: Update.
1997         * tracefile-tfile.c: Update.
1998         * tui/tui.c: Update.
1999         * typeprint.c: Update.
2000         * unittests/cli-utils-selftests.c: Update.
2001         * unittests/parse-connection-spec-selftests.c: Update.
2002         * valops.c: Update.
2003         * valprint.c: Update.
2004         * value.c: Update.
2005         * varobj.c: Update.
2006         * windows-nat.c: Update.
2007         * x86-linux-nat.c: Update.
2008         * xml-support.c: Update.
2009
2010 2019-04-08  Tom Tromey  <tom@tromey.com>
2011
2012         * xml-support.c: Use C++ exception handling.
2013         * x86-linux-nat.c: Use C++ exception handling.
2014         * windows-nat.c: Use C++ exception handling.
2015         * varobj.c: Use C++ exception handling.
2016         * value.c: Use C++ exception handling.
2017         * valprint.c: Use C++ exception handling.
2018         * valops.c: Use C++ exception handling.
2019         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2020         handling.
2021         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2022         * typeprint.c: Use C++ exception handling.
2023         * tui/tui.c: Use C++ exception handling.
2024         * tracefile-tfile.c: Use C++ exception handling.
2025         * top.c: Use C++ exception handling.
2026         * thread.c: Use C++ exception handling.
2027         * target.c: Use C++ exception handling.
2028         * symmisc.c: Use C++ exception handling.
2029         * symfile-mem.c: Use C++ exception handling.
2030         * stack.c: Use C++ exception handling.
2031         * sparc64-linux-tdep.c: Use C++ exception handling.
2032         * solib.c: Use C++ exception handling.
2033         * solib-svr4.c: Use C++ exception handling.
2034         * solib-spu.c: Use C++ exception handling.
2035         * solib-frv.c: Use C++ exception handling.
2036         * solib-dsbt.c: Use C++ exception handling.
2037         * selftest-arch.c: Use C++ exception handling.
2038         * s390-tdep.c: Use C++ exception handling.
2039         * rust-lang.c: Use C++ exception handling.
2040         * rust-exp.y: Use C++ exception handling.
2041         * rs6000-tdep.c: Use C++ exception handling.
2042         * rs6000-aix-tdep.c: Use C++ exception handling.
2043         * riscv-tdep.c: Use C++ exception handling.
2044         * remote.c: Use C++ exception handling.
2045         * remote-fileio.c: Use C++ exception handling.
2046         * record-full.c: Use C++ exception handling.
2047         * record-btrace.c: Use C++ exception handling.
2048         * python/python.c: Use C++ exception handling.
2049         * python/py-value.c: Use C++ exception handling.
2050         * python/py-utils.c: Use C++ exception handling.
2051         * python/py-unwind.c: Use C++ exception handling.
2052         * python/py-type.c: Use C++ exception handling.
2053         * python/py-symbol.c: Use C++ exception handling.
2054         * python/py-record.c: Use C++ exception handling.
2055         * python/py-record-btrace.c: Use C++ exception handling.
2056         * python/py-progspace.c: Use C++ exception handling.
2057         * python/py-prettyprint.c: Use C++ exception handling.
2058         * python/py-param.c: Use C++ exception handling.
2059         * python/py-objfile.c: Use C++ exception handling.
2060         * python/py-linetable.c: Use C++ exception handling.
2061         * python/py-lazy-string.c: Use C++ exception handling.
2062         * python/py-infthread.c: Use C++ exception handling.
2063         * python/py-inferior.c: Use C++ exception handling.
2064         * python/py-gdb-readline.c: Use C++ exception handling.
2065         * python/py-framefilter.c: Use C++ exception handling.
2066         * python/py-frame.c: Use C++ exception handling.
2067         * python/py-finishbreakpoint.c: Use C++ exception handling.
2068         * python/py-cmd.c: Use C++ exception handling.
2069         * python/py-breakpoint.c: Use C++ exception handling.
2070         * python/py-arch.c: Use C++ exception handling.
2071         * printcmd.c: Use C++ exception handling.
2072         * ppc-linux-tdep.c: Use C++ exception handling.
2073         * parse.c: Use C++ exception handling.
2074         * p-valprint.c: Use C++ exception handling.
2075         * objc-lang.c: Use C++ exception handling.
2076         * mi/mi-main.c: Use C++ exception handling.
2077         * mi/mi-interp.c: Use C++ exception handling.
2078         * mi/mi-cmd-stack.c: Use C++ exception handling.
2079         * mi/mi-cmd-break.c: Use C++ exception handling.
2080         * main.c: Use C++ exception handling.
2081         * linux-thread-db.c: Use C++ exception handling.
2082         * linux-tdep.c: Use C++ exception handling.
2083         * linux-nat.c: Use C++ exception handling.
2084         * linux-fork.c: Use C++ exception handling.
2085         * linespec.c: Use C++ exception handling.
2086         * language.c: Use C++ exception handling.
2087         * jit.c: Use C++ exception handling.
2088         * infrun.c: Use C++ exception handling.
2089         * infcmd.c: Use C++ exception handling.
2090         * infcall.c: Use C++ exception handling.
2091         * inf-loop.c: Use C++ exception handling.
2092         * i386-tdep.c: Use C++ exception handling.
2093         * i386-linux-tdep.c: Use C++ exception handling.
2094         * guile/scm-value.c: Use C++ exception handling.
2095         * guile/scm-type.c: Use C++ exception handling.
2096         * guile/scm-symtab.c: Use C++ exception handling.
2097         * guile/scm-symbol.c: Use C++ exception handling.
2098         * guile/scm-pretty-print.c: Use C++ exception handling.
2099         * guile/scm-ports.c: Use C++ exception handling.
2100         * guile/scm-param.c: Use C++ exception handling.
2101         * guile/scm-math.c: Use C++ exception handling.
2102         * guile/scm-lazy-string.c: Use C++ exception handling.
2103         * guile/scm-frame.c: Use C++ exception handling.
2104         * guile/scm-disasm.c: Use C++ exception handling.
2105         * guile/scm-cmd.c: Use C++ exception handling.
2106         * guile/scm-breakpoint.c: Use C++ exception handling.
2107         * guile/scm-block.c: Use C++ exception handling.
2108         * guile/guile-internal.h: Use C++ exception handling.
2109         * gnu-v3-abi.c: Use C++ exception handling.
2110         * gdbtypes.c: Use C++ exception handling.
2111         * frame.c: Use C++ exception handling.
2112         * frame-unwind.c: Use C++ exception handling.
2113         * fbsd-tdep.c: Use C++ exception handling.
2114         * f-valprint.c: Use C++ exception handling.
2115         * exec.c: Use C++ exception handling.
2116         * event-top.c: Use C++ exception handling.
2117         * event-loop.c: Use C++ exception handling.
2118         * eval.c: Use C++ exception handling.
2119         * dwarf2read.c: Use C++ exception handling.
2120         * dwarf2loc.c: Use C++ exception handling.
2121         * dwarf2-frame.c: Use C++ exception handling.
2122         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2123         * dwarf-index-write.c: Use C++ exception handling.
2124         * dwarf-index-cache.c: Use C++ exception handling.
2125         * dtrace-probe.c: Use C++ exception handling.
2126         * disasm-selftests.c: Use C++ exception handling.
2127         * darwin-nat.c: Use C++ exception handling.
2128         * cp-valprint.c: Use C++ exception handling.
2129         * cp-support.c: Use C++ exception handling.
2130         * cp-abi.c: Use C++ exception handling.
2131         * corelow.c: Use C++ exception handling.
2132         * completer.c: Use C++ exception handling.
2133         * compile/compile-object-run.c: Use C++ exception handling.
2134         * compile/compile-object-load.c: Use C++ exception handling.
2135         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2136         * compile/compile-c-symbols.c: Use C++ exception handling.
2137         * common/selftest.c: Use C++ exception handling.
2138         * common/new-op.c: Use C++ exception handling.
2139         * cli/cli-script.c: Use C++ exception handling.
2140         * cli/cli-interp.c: Use C++ exception handling.
2141         * cli/cli-cmds.c: Use C++ exception handling.
2142         * c-varobj.c: Use C++ exception handling.
2143         * btrace.c: Use C++ exception handling.
2144         * breakpoint.c: Use C++ exception handling.
2145         * break-catch-throw.c: Use C++ exception handling.
2146         * arch-utils.c: Use C++ exception handling.
2147         * amd64-tdep.c: Use C++ exception handling.
2148         * ada-valprint.c: Use C++ exception handling.
2149         * ada-typeprint.c: Use C++ exception handling.
2150         * ada-lang.c: Use C++ exception handling.
2151         * aarch64-tdep.c: Use C++ exception handling.
2152
2153 2019-04-08  Tom Tromey  <tom@tromey.com>
2154
2155         * xml-support.c (gdb_xml_parser::parse): Update.
2156         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2157         * value.c (show_convenience): Update.
2158         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2159         (test_parse_flags_qcs): Update.
2160         * thread.c (thr_try_catch_cmd): Update.
2161         * target.c (target_translate_tls_address): Update.
2162         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2163         (info_frame_command_core, frame_apply_command_count): Update.
2164         * rust-exp.y (rust_lex_exception_test): Update.
2165         * riscv-tdep.c (riscv_print_one_register_info): Update.
2166         * remote.c (remote_target::enable_btrace): Update.
2167         * record-btrace.c (record_btrace_enable_warn): Update.
2168         * python/py-utils.c (gdbpy_convert_exception): Update.
2169         * printcmd.c (do_one_display, print_variable_and_value): Update.
2170         * mi/mi-main.c (mi_print_exception): Update.
2171         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2172         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2173         * linux-nat.c (linux_nat_target::attach): Update.
2174         * linux-fork.c (class scoped_switch_fork_info): Update.
2175         * infrun.c (displaced_step_prepare): Update.
2176         * infcall.c (call_function_by_hand_dummy): Update.
2177         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2178         * gnu-v3-abi.c (print_one_vtable): Update.
2179         * frame.c (get_prev_frame_always): Update.
2180         * f-valprint.c (info_common_command_for_block): Update.
2181         * exec.c (try_open_exec_file): Update.
2182         * exceptions.c (print_exception, exception_print)
2183         (exception_fprintf, exception_print_same): Update.
2184         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2185         * dwarf-index-cache.c (index_cache::store)
2186         (index_cache::lookup_gdb_index): Update.
2187         * darwin-nat.c (maybe_cache_shell): Update.
2188         * cp-valprint.c (cp_print_value_fields): Update.
2189         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2190         (gcc_cplus_symbol_address): Update.
2191         * compile/compile-c-symbols.c (gcc_convert_symbol)
2192         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2193         * common/selftest.c: Update.
2194         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2195         a std::string.
2196         (exception_try_scope_entry, exception_try_scope_exit): Don't
2197         declare.
2198         (struct exception_try_scope): Remove.
2199         (TRY): Don't use exception_try_scope.
2200         (struct gdb_exception): Add constructor, operator=.
2201         <what>: New method.
2202         (struct gdb_exception_RETURN_MASK_ALL)
2203         (struct gdb_exception_RETURN_MASK_ERROR)
2204         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2205         (struct gdb_quit_bad_alloc): Update.
2206         * common/common-exceptions.c (exception_none): Change
2207         initializer.
2208         (struct catcher) <state, exception>: Initialize inline.
2209         <prev>: Remove member.
2210         (current_catcher): Remove.
2211         (catchers): New global.
2212         (exceptions_state_mc_init): Simplify.
2213         (catcher_pop): Remove.
2214         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2215         (try_scope_depth, exception_try_scope_entry)
2216         (exception_try_scope_exit): Remove.
2217         (throw_exception_sjlj): Update.
2218         (exception_messages, exception_messages_size): Remove.
2219         (throw_it): Simplify.
2220         (gdb_exception_sliced_copy): Remove.
2221         (throw_exception_cxx): Update.
2222         * cli/cli-script.c (script_from_file): Update.
2223         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2224         Update.
2225         * ada-valprint.c (ada_val_print): Update.
2226         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2227         (create_excep_cond_exprs): Update.
2228
2229 2019-04-08  Tom Tromey  <tom@tromey.com>
2230
2231         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2232         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2233         (TRY, CATCH, END_CATCH): Remove some definitions.
2234         * common/common-exceptions.c: Don't use GDB_XCPT.
2235         (catcher_list_size): Remove.
2236         (throw_exception, throw_it): Simplify.
2237
2238 2019-04-05  Tom Tromey  <tom@tromey.com>
2239
2240         Revert the header-sorting patch.
2241         * ft32-tdep.c: Revert.
2242         * frv-tdep.c: Revert.
2243         * frv-linux-tdep.c: Revert.
2244         * frame.c: Revert.
2245         * frame-unwind.c: Revert.
2246         * frame-base.c: Revert.
2247         * fork-child.c: Revert.
2248         * findvar.c: Revert.
2249         * findcmd.c: Revert.
2250         * filesystem.c: Revert.
2251         * filename-seen-cache.h: Revert.
2252         * filename-seen-cache.c: Revert.
2253         * fbsd-tdep.c: Revert.
2254         * fbsd-nat.h: Revert.
2255         * fbsd-nat.c: Revert.
2256         * f-valprint.c: Revert.
2257         * f-typeprint.c: Revert.
2258         * f-lang.c: Revert.
2259         * extension.h: Revert.
2260         * extension.c: Revert.
2261         * extension-priv.h: Revert.
2262         * expprint.c: Revert.
2263         * exec.h: Revert.
2264         * exec.c: Revert.
2265         * exceptions.c: Revert.
2266         * event-top.c: Revert.
2267         * event-loop.c: Revert.
2268         * eval.c: Revert.
2269         * elfread.c: Revert.
2270         * dwarf2read.h: Revert.
2271         * dwarf2read.c: Revert.
2272         * dwarf2loc.c: Revert.
2273         * dwarf2expr.h: Revert.
2274         * dwarf2expr.c: Revert.
2275         * dwarf2-frame.c: Revert.
2276         * dwarf2-frame-tailcall.c: Revert.
2277         * dwarf-index-write.h: Revert.
2278         * dwarf-index-write.c: Revert.
2279         * dwarf-index-common.c: Revert.
2280         * dwarf-index-cache.h: Revert.
2281         * dwarf-index-cache.c: Revert.
2282         * dummy-frame.c: Revert.
2283         * dtrace-probe.c: Revert.
2284         * disasm.h: Revert.
2285         * disasm.c: Revert.
2286         * disasm-selftests.c: Revert.
2287         * dictionary.c: Revert.
2288         * dicos-tdep.c: Revert.
2289         * demangle.c: Revert.
2290         * dcache.h: Revert.
2291         * dcache.c: Revert.
2292         * darwin-nat.h: Revert.
2293         * darwin-nat.c: Revert.
2294         * darwin-nat-info.c: Revert.
2295         * d-valprint.c: Revert.
2296         * d-namespace.c: Revert.
2297         * d-lang.c: Revert.
2298         * ctf.c: Revert.
2299         * csky-tdep.c: Revert.
2300         * csky-linux-tdep.c: Revert.
2301         * cris-tdep.c: Revert.
2302         * cris-linux-tdep.c: Revert.
2303         * cp-valprint.c: Revert.
2304         * cp-support.c: Revert.
2305         * cp-namespace.c: Revert.
2306         * cp-abi.c: Revert.
2307         * corelow.c: Revert.
2308         * corefile.c: Revert.
2309         * continuations.c: Revert.
2310         * completer.h: Revert.
2311         * completer.c: Revert.
2312         * complaints.c: Revert.
2313         * coffread.c: Revert.
2314         * coff-pe-read.c: Revert.
2315         * cli-out.h: Revert.
2316         * cli-out.c: Revert.
2317         * charset.c: Revert.
2318         * c-varobj.c: Revert.
2319         * c-valprint.c: Revert.
2320         * c-typeprint.c: Revert.
2321         * c-lang.c: Revert.
2322         * buildsym.c: Revert.
2323         * buildsym-legacy.c: Revert.
2324         * build-id.h: Revert.
2325         * build-id.c: Revert.
2326         * btrace.c: Revert.
2327         * bsd-uthread.c: Revert.
2328         * breakpoint.h: Revert.
2329         * breakpoint.c: Revert.
2330         * break-catch-throw.c: Revert.
2331         * break-catch-syscall.c: Revert.
2332         * break-catch-sig.c: Revert.
2333         * blockframe.c: Revert.
2334         * block.c: Revert.
2335         * bfin-tdep.c: Revert.
2336         * bfin-linux-tdep.c: Revert.
2337         * bfd-target.c: Revert.
2338         * bcache.c: Revert.
2339         * ax-general.c: Revert.
2340         * ax-gdb.h: Revert.
2341         * ax-gdb.c: Revert.
2342         * avr-tdep.c: Revert.
2343         * auxv.c: Revert.
2344         * auto-load.c: Revert.
2345         * arm-wince-tdep.c: Revert.
2346         * arm-tdep.c: Revert.
2347         * arm-symbian-tdep.c: Revert.
2348         * arm-pikeos-tdep.c: Revert.
2349         * arm-obsd-tdep.c: Revert.
2350         * arm-nbsd-tdep.c: Revert.
2351         * arm-nbsd-nat.c: Revert.
2352         * arm-linux-tdep.c: Revert.
2353         * arm-linux-nat.c: Revert.
2354         * arm-fbsd-tdep.c: Revert.
2355         * arm-fbsd-nat.c: Revert.
2356         * arm-bsd-tdep.c: Revert.
2357         * arch-utils.c: Revert.
2358         * arc-tdep.c: Revert.
2359         * arc-newlib-tdep.c: Revert.
2360         * annotate.h: Revert.
2361         * annotate.c: Revert.
2362         * amd64-windows-tdep.c: Revert.
2363         * amd64-windows-nat.c: Revert.
2364         * amd64-tdep.c: Revert.
2365         * amd64-sol2-tdep.c: Revert.
2366         * amd64-obsd-tdep.c: Revert.
2367         * amd64-obsd-nat.c: Revert.
2368         * amd64-nbsd-tdep.c: Revert.
2369         * amd64-nbsd-nat.c: Revert.
2370         * amd64-nat.c: Revert.
2371         * amd64-linux-tdep.c: Revert.
2372         * amd64-linux-nat.c: Revert.
2373         * amd64-fbsd-tdep.c: Revert.
2374         * amd64-fbsd-nat.c: Revert.
2375         * amd64-dicos-tdep.c: Revert.
2376         * amd64-darwin-tdep.c: Revert.
2377         * amd64-bsd-nat.c: Revert.
2378         * alpha-tdep.c: Revert.
2379         * alpha-obsd-tdep.c: Revert.
2380         * alpha-nbsd-tdep.c: Revert.
2381         * alpha-mdebug-tdep.c: Revert.
2382         * alpha-linux-tdep.c: Revert.
2383         * alpha-linux-nat.c: Revert.
2384         * alpha-bsd-tdep.c: Revert.
2385         * alpha-bsd-nat.c: Revert.
2386         * aix-thread.c: Revert.
2387         * agent.c: Revert.
2388         * addrmap.c: Revert.
2389         * ada-varobj.c: Revert.
2390         * ada-valprint.c: Revert.
2391         * ada-typeprint.c: Revert.
2392         * ada-tasks.c: Revert.
2393         * ada-lang.c: Revert.
2394         * aarch64-tdep.c: Revert.
2395         * aarch64-ravenscar-thread.c: Revert.
2396         * aarch64-newlib-tdep.c: Revert.
2397         * aarch64-linux-tdep.c: Revert.
2398         * aarch64-linux-nat.c: Revert.
2399         * aarch64-fbsd-tdep.c: Revert.
2400         * aarch64-fbsd-nat.c: Revert.
2401         * aarch32-linux-nat.c: Revert.
2402
2403 2019-04-05  Tom Tromey  <tom@tromey.com>
2404
2405         * ft32-tdep.c: Sort headers.
2406         * frv-tdep.c: Sort headers.
2407         * frv-linux-tdep.c: Sort headers.
2408         * frame.c: Sort headers.
2409         * frame-unwind.c: Sort headers.
2410         * frame-base.c: Sort headers.
2411         * fork-child.c: Sort headers.
2412         * findvar.c: Sort headers.
2413         * findcmd.c: Sort headers.
2414         * filesystem.c: Sort headers.
2415         * filename-seen-cache.h: Sort headers.
2416         * filename-seen-cache.c: Sort headers.
2417         * fbsd-tdep.c: Sort headers.
2418         * fbsd-nat.h: Sort headers.
2419         * fbsd-nat.c: Sort headers.
2420         * f-valprint.c: Sort headers.
2421         * f-typeprint.c: Sort headers.
2422         * f-lang.c: Sort headers.
2423         * extension.h: Sort headers.
2424         * extension.c: Sort headers.
2425         * extension-priv.h: Sort headers.
2426         * expprint.c: Sort headers.
2427         * exec.h: Sort headers.
2428         * exec.c: Sort headers.
2429         * exceptions.c: Sort headers.
2430         * event-top.c: Sort headers.
2431         * event-loop.c: Sort headers.
2432         * eval.c: Sort headers.
2433         * elfread.c: Sort headers.
2434         * dwarf2read.h: Sort headers.
2435         * dwarf2read.c: Sort headers.
2436         * dwarf2loc.c: Sort headers.
2437         * dwarf2expr.h: Sort headers.
2438         * dwarf2expr.c: Sort headers.
2439         * dwarf2-frame.c: Sort headers.
2440         * dwarf2-frame-tailcall.c: Sort headers.
2441         * dwarf-index-write.h: Sort headers.
2442         * dwarf-index-write.c: Sort headers.
2443         * dwarf-index-common.c: Sort headers.
2444         * dwarf-index-cache.h: Sort headers.
2445         * dwarf-index-cache.c: Sort headers.
2446         * dummy-frame.c: Sort headers.
2447         * dtrace-probe.c: Sort headers.
2448         * disasm.h: Sort headers.
2449         * disasm.c: Sort headers.
2450         * disasm-selftests.c: Sort headers.
2451         * dictionary.c: Sort headers.
2452         * dicos-tdep.c: Sort headers.
2453         * demangle.c: Sort headers.
2454         * dcache.h: Sort headers.
2455         * dcache.c: Sort headers.
2456         * darwin-nat.h: Sort headers.
2457         * darwin-nat.c: Sort headers.
2458         * darwin-nat-info.c: Sort headers.
2459         * d-valprint.c: Sort headers.
2460         * d-namespace.c: Sort headers.
2461         * d-lang.c: Sort headers.
2462         * ctf.c: Sort headers.
2463         * csky-tdep.c: Sort headers.
2464         * csky-linux-tdep.c: Sort headers.
2465         * cris-tdep.c: Sort headers.
2466         * cris-linux-tdep.c: Sort headers.
2467         * cp-valprint.c: Sort headers.
2468         * cp-support.c: Sort headers.
2469         * cp-namespace.c: Sort headers.
2470         * cp-abi.c: Sort headers.
2471         * corelow.c: Sort headers.
2472         * corefile.c: Sort headers.
2473         * continuations.c: Sort headers.
2474         * completer.h: Sort headers.
2475         * completer.c: Sort headers.
2476         * complaints.c: Sort headers.
2477         * coffread.c: Sort headers.
2478         * coff-pe-read.c: Sort headers.
2479         * cli-out.h: Sort headers.
2480         * cli-out.c: Sort headers.
2481         * charset.c: Sort headers.
2482         * c-varobj.c: Sort headers.
2483         * c-valprint.c: Sort headers.
2484         * c-typeprint.c: Sort headers.
2485         * c-lang.c: Sort headers.
2486         * buildsym.c: Sort headers.
2487         * buildsym-legacy.c: Sort headers.
2488         * build-id.h: Sort headers.
2489         * build-id.c: Sort headers.
2490         * btrace.c: Sort headers.
2491         * bsd-uthread.c: Sort headers.
2492         * breakpoint.h: Sort headers.
2493         * breakpoint.c: Sort headers.
2494         * break-catch-throw.c: Sort headers.
2495         * break-catch-syscall.c: Sort headers.
2496         * break-catch-sig.c: Sort headers.
2497         * blockframe.c: Sort headers.
2498         * block.c: Sort headers.
2499         * bfin-tdep.c: Sort headers.
2500         * bfin-linux-tdep.c: Sort headers.
2501         * bfd-target.c: Sort headers.
2502         * bcache.c: Sort headers.
2503         * ax-general.c: Sort headers.
2504         * ax-gdb.h: Sort headers.
2505         * ax-gdb.c: Sort headers.
2506         * avr-tdep.c: Sort headers.
2507         * auxv.c: Sort headers.
2508         * auto-load.c: Sort headers.
2509         * arm-wince-tdep.c: Sort headers.
2510         * arm-tdep.c: Sort headers.
2511         * arm-symbian-tdep.c: Sort headers.
2512         * arm-pikeos-tdep.c: Sort headers.
2513         * arm-obsd-tdep.c: Sort headers.
2514         * arm-nbsd-tdep.c: Sort headers.
2515         * arm-nbsd-nat.c: Sort headers.
2516         * arm-linux-tdep.c: Sort headers.
2517         * arm-linux-nat.c: Sort headers.
2518         * arm-fbsd-tdep.c: Sort headers.
2519         * arm-fbsd-nat.c: Sort headers.
2520         * arm-bsd-tdep.c: Sort headers.
2521         * arch-utils.c: Sort headers.
2522         * arc-tdep.c: Sort headers.
2523         * arc-newlib-tdep.c: Sort headers.
2524         * annotate.h: Sort headers.
2525         * annotate.c: Sort headers.
2526         * amd64-windows-tdep.c: Sort headers.
2527         * amd64-windows-nat.c: Sort headers.
2528         * amd64-tdep.c: Sort headers.
2529         * amd64-sol2-tdep.c: Sort headers.
2530         * amd64-obsd-tdep.c: Sort headers.
2531         * amd64-obsd-nat.c: Sort headers.
2532         * amd64-nbsd-tdep.c: Sort headers.
2533         * amd64-nbsd-nat.c: Sort headers.
2534         * amd64-nat.c: Sort headers.
2535         * amd64-linux-tdep.c: Sort headers.
2536         * amd64-linux-nat.c: Sort headers.
2537         * amd64-fbsd-tdep.c: Sort headers.
2538         * amd64-fbsd-nat.c: Sort headers.
2539         * amd64-dicos-tdep.c: Sort headers.
2540         * amd64-darwin-tdep.c: Sort headers.
2541         * amd64-bsd-nat.c: Sort headers.
2542         * alpha-tdep.c: Sort headers.
2543         * alpha-obsd-tdep.c: Sort headers.
2544         * alpha-nbsd-tdep.c: Sort headers.
2545         * alpha-mdebug-tdep.c: Sort headers.
2546         * alpha-linux-tdep.c: Sort headers.
2547         * alpha-linux-nat.c: Sort headers.
2548         * alpha-bsd-tdep.c: Sort headers.
2549         * alpha-bsd-nat.c: Sort headers.
2550         * aix-thread.c: Sort headers.
2551         * agent.c: Sort headers.
2552         * addrmap.c: Sort headers.
2553         * ada-varobj.c: Sort headers.
2554         * ada-valprint.c: Sort headers.
2555         * ada-typeprint.c: Sort headers.
2556         * ada-tasks.c: Sort headers.
2557         * ada-lang.c: Sort headers.
2558         * aarch64-tdep.c: Sort headers.
2559         * aarch64-ravenscar-thread.c: Sort headers.
2560         * aarch64-newlib-tdep.c: Sort headers.
2561         * aarch64-linux-tdep.c: Sort headers.
2562         * aarch64-linux-nat.c: Sort headers.
2563         * aarch64-fbsd-tdep.c: Sort headers.
2564         * aarch64-fbsd-nat.c: Sort headers.
2565         * aarch32-linux-nat.c: Sort headers.
2566
2567 2019-04-04  Tom Tromey  <tom@tromey.com>
2568
2569         * varobj.c (varobj_create): Update.
2570         * rust-exp.y (struct rust_parser) <update_innermost_block,
2571         lookup_symbol>: New methods.
2572         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2573         Rename.
2574         (rust_parser::rust_lookup_type)
2575         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2576         * printcmd.c (display_command, do_one_display): Update.
2577         * parser-defs.h (struct parser_state) <parser_state>: Add
2578         "tracker" parameter.
2579         (block_tracker): New member.
2580         (class innermost_block_tracker) <innermost_block_tracker>: Add
2581         "types" parameter.
2582         <reset>: Remove method.
2583         (innermost_block): Don't declare.
2584         (null_post_parser): Update.
2585         * parse.c (innermost_block): Remove global.
2586         (write_dollar_variable): Update.
2587         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2588         Remove "tracker_types" parameter.
2589         (parse_expression): Add "tracker" parameter.
2590         (parse_expression_for_completion): Update.
2591         (null_post_parser): Add "tracker" parameter.
2592         * p-exp.y: Update rules.
2593         * m2-exp.y: Update rules.
2594         * language.h (struct language_defn) <la_post_parser>: Add
2595         "tracker" parameter.
2596         * go-exp.y: Update rules.
2597         * f-exp.y: Update rules.
2598         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2599         parameter.
2600         * d-exp.y: Update rules.
2601         * c-exp.y: Update rules.
2602         * breakpoint.c (set_breakpoint_condition): Create an
2603         innermost_block_tracker.
2604         (watch_command_1): Likewise.
2605         * ada-lang.c (resolve): Add "tracker" parameter.
2606         (resolve_subexp): Likewise.
2607         * ada-exp.y (write_var_from_sym): Update.
2608
2609 2019-04-04  Tom Tromey  <tom@tromey.com>
2610
2611         * type-stack.h: New file.
2612         * type-stack.c: New file.
2613         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2614         type-stack.h.
2615         (insert_into_type_stack, insert_type, push_type, push_type_int)
2616         (insert_type_address_space, pop_type, pop_type_int)
2617         (pop_typelist, pop_type_stack, append_type_stack)
2618         (push_type_stack, get_type_stack, push_typelist)
2619         (follow_type_instance_flags, follow_types): Don't declare.
2620         * parse.c (type_stack): Remove global.
2621         (parse_exp_in_context): Update.
2622         (insert_into_type_stack, insert_type, push_type, push_type_int)
2623         (insert_type_address_space, pop_type, pop_type_int)
2624         (pop_typelist, pop_type_stack, append_type_stack)
2625         (push_type_stack, get_type_stack, push_typelist)
2626         (follow_type_instance_flags, follow_types): Remove (moved to
2627         type-stack.c).
2628         * f-exp.y (type_stack): New global.
2629         Update rules.
2630         (push_kind_type, f_parse): Update.
2631         * d-exp.y (type_stack): New global.
2632         Update rules.
2633         (d_parse): Update.
2634         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2635         Update rules.
2636         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2637         (HFILES_NO_SRCDIR): Add type-stack.h.
2638
2639 2019-04-04  Tom Tromey  <tom@tromey.com>
2640
2641         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2642         (rust_parser::convert_ast_to_expression, rust_parse)
2643         (rust_lex_test_completion, rust_lex_tests): Update.
2644         * parser-defs.h (struct expr_completion_state): New.
2645         (struct parser_state) <parser_state>: Add completion parameter.
2646         <mark_struct_expression, mark_completion_tag>: New methods.
2647         <parse_completion, m_completion_state>: New members.
2648         (prefixify_expression, null_post_parser): Update.
2649         (mark_struct_expression, mark_completion_tag): Don't declare.
2650         * parse.c (parse_completion, expout_last_struct)
2651         (expout_tag_completion_type, expout_completion_name): Remove
2652         globals.
2653         (parser_state::mark_struct_expression)
2654         (parser_state::mark_completion_tag): Now methods.
2655         (prefixify_expression): Add last_struct parameter.
2656         (prefixify_subexp): Likewise.
2657         (parse_exp_1): Update.
2658         (parse_exp_in_context): Add cstate parameter.  Update.
2659         (parse_expression_for_completion): Create an
2660         expr_completion_state.
2661         (null_post_parser): Add "completion" parameter.
2662         * p-exp.y: Update rules.
2663         (yylex): Update.
2664         * language.h (struct language_defn) <la_post_parser>: Add
2665         "completing" parameter.
2666         * go-exp.y: Update rules.
2667         (lex_one_token): Update.
2668         * expression.h (parse_completion): Don't declare.
2669         * d-exp.y: Update rules.
2670         (lex_one_token): Update rules.
2671         * c-exp.y: Update rules.
2672         (lex_one_token): Update.
2673         * ada-lang.c (resolve): Add "parse_completion" parameter.
2674         (resolve_subexp): Likewise.
2675         (ada_resolve_function): Likewise.
2676
2677 2019-04-04  Tom Tromey  <tom@tromey.com>
2678
2679         * parser-defs.h (struct parser_state) <start_arglist,
2680         end_arglist>: New methods.
2681         <arglist_len, m_funcall_chain>: New members.
2682         (arglist_len, start_arglist, end_arglist): Don't declare.
2683         * parse.c (arglist_len, funcall_chain): Remove global.
2684         (start_arglist, end_arglist): Remove functions.
2685         (parse_exp_in_context): Update.
2686         * p-exp.y: Update rules.
2687         * m2-exp.y: Update rules.
2688         * go-exp.y: Update rules.
2689         * f-exp.y: Update rules.
2690         * d-exp.y: Update rules.
2691         * c-exp.y: Update rules.
2692
2693 2019-04-04  Tom Tromey  <tom@tromey.com>
2694
2695         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2696         lex_operator, push_back>: New methods.
2697         Update all rules.
2698         (rust_parser::lex_hex, lex_escape): Rename and update.
2699         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2700         (rust_parser::lex_operator): Rename and update.
2701         (rust_parser::lex_number, rustyylex, rustyyerror)
2702         (rust_lex_test_init, rust_lex_test_sequence)
2703         (rust_lex_test_push_back, rust_lex_tests): Update.
2704         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2705         parameter.
2706         <lexptr, prev_lexptr>: New members.
2707         (lexptr, prev_lexptr): Don't declare.
2708         * parse.c (lexptr, prev_lexptr): Remove globals.
2709         (parse_exp_in_context): Update.
2710         * p-exp.y (yylex, yyerror): Update.
2711         * m2-exp.y (parse_number, yylex, yyerror): Update.
2712         * go-exp.y (lex_one_token, yyerror): Update.
2713         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2714         * d-exp.y (lex_one_token, yyerror): Update.
2715         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2716         (lex_one_token, yyerror): Update.
2717         * ada-lex.l (YY_INPUT): Update.
2718         (rewind_to_char): Update.
2719         * ada-exp.y (yyerror): Update.
2720
2721 2019-04-04  Tom Tromey  <tom@tromey.com>
2722
2723         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2724         * parser-defs.h (struct parser_state) <parser_state>: Add new
2725         parameter.
2726         <comma_terminates>: New member.
2727         (comma_terminates): Don't declare global.
2728         * parse.c (comma_terminates): Remove global.
2729         (parse_exp_in_context): Update.
2730         * p-exp.y (yylex): Update.
2731         * m2-exp.y (yylex): Update.
2732         * go-exp.y (lex_one_token): Update.
2733         * f-exp.y (yylex): Update.
2734         * d-exp.y (lex_one_token): Update.
2735         * c-exp.y (lex_one_token): Update.
2736         * ada-lex.l: Update.
2737
2738 2019-04-04  Tom Tromey  <tom@tromey.com>
2739
2740         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2741         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2742         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2743         * parser-defs.h (paren_depth): Don't declare.
2744         * parse.c (paren_depth): Remove global.
2745         (parse_exp_in_context): Update.
2746         * p-exp.y (paren_depth): New global.
2747         (pascal_parse): Initialize it.
2748         * m2-exp.y (paren_depth): New global.
2749         (m2_parse): Initialize it.
2750         * go-exp.y (paren_depth): New global.
2751         (go_parse): Initialize it.
2752         * f-exp.y (paren_depth): New global.
2753         (f_parse): Initialize it.
2754         * d-exp.y (paren_depth): New global.
2755         (d_parse): Initialize it.
2756         * c-exp.y (paren_depth): New global.
2757         (c_parse): Initialize it.
2758         * ada-lex.l (paren_depth): New global.
2759         (lexer_init): Initialize it.
2760
2761 2019-04-04  Tom Tromey  <tom@tromey.com>
2762
2763         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2764         (rust_parser::convert_ast_to_type)
2765         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2766         * parser-defs.h (struct parser_state) <parser_state>: Add
2767         parameters.  Initialize new members.
2768         <expression_context_block, expression_context_pc>: New members.
2769         * parse.c (expression_context_block, expression_context_pc):
2770         Remove globals.
2771         (parse_exp_in_context): Update.
2772         * p-exp.y: Update all rules.
2773         (yylex): Update.
2774         * m2-exp.y: Update all rules.
2775         (yylex): Update.
2776         * go-exp.y (yylex): Update.
2777         * f-exp.y (yylex): Update.
2778         * d-exp.y: Update all rules.
2779         (yylex): Update.
2780         * c-exp.y: Update all rules.
2781         (lex_one_token, classify_name, yylex, c_parse): Update.
2782         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2783
2784 2019-04-04  Tom Tromey  <tom@tromey.com>
2785
2786         * gdbarch.h, gdbarch.c: Rebuild.
2787         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2788         * stap-probe.h:
2789         (struct stap_parse_info): Replace "parser_state" with
2790         "expr_builder".
2791         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2792         (parser_state): New class.
2793         * parse.c (expr_builder): Rename.
2794         (expr_builder::release): Rename.
2795         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2796         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2797         (write_exp_elt_longcst, write_exp_elt_floatcst)
2798         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2799         (write_exp_string_vector, write_exp_bitstring)
2800         (write_exp_msymbol, mark_struct_expression)
2801         (write_dollar_variable)
2802         (insert_type_address_space, increase_expout_size): Replace
2803         "parser_state" with "expr_builder".
2804         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2805         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2806         "parser_state" with "expr_builder".
2807
2808 2019-04-04  Tom Tromey  <tom@tromey.com>
2809
2810         * rust-exp.y: Replace "parse_language" with method call.
2811         * p-exp.y:
2812         (yylex): Replace "parse_language" with method call.
2813         * m2-exp.y:
2814         (yylex): Replace "parse_language" with method call.
2815         * go-exp.y (classify_name): Replace "parse_language" with method
2816         call.
2817         * f-exp.y (yylex): Replace "parse_language" with method call.
2818         * d-exp.y (lex_one_token): Replace "parse_language" with method
2819         call.
2820         * c-exp.y:
2821         (lex_one_token, classify_name, yylex): Replace "parse_language"
2822         with method call.
2823         * ada-exp.y (find_primitive_type, type_char)
2824         (type_system_address): Replace "parse_language" with method call.
2825
2826 2019-04-04  Tom Tromey  <tom@tromey.com>
2827
2828         * rust-exp.y: Replace "parse_gdbarch" with method call.
2829         * parse.c (write_dollar_variable, insert_type_address_space):
2830         Replace "parse_gdbarch" with method call.
2831         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2832         call.
2833         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2834         call.
2835         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2836         "parse_gdbarch" with method call.
2837         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2838         with method call.
2839         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2840         "parse_gdbarch" with method call.
2841         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2842         "parse_gdbarch" with method call.
2843         * c-exp.y (parse_type, parse_number, classify_name): Replace
2844         "parse_gdbarch" with method call.
2845         * ada-lex.l: Replace "parse_gdbarch" with method call.
2846         * ada-exp.y (parse_type, find_primitive_type, type_char)
2847         (type_system_address): Replace "parse_gdbarch" with method call.
2848
2849 2019-04-04  Tom Tromey  <tom@tromey.com>
2850
2851         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2852         * stap-probe.c (stap_parse_argument): Update.
2853         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2854         initial_size parameter.
2855         * rust-exp.y (rust_lex_tests): Update.
2856         * parse.c (parser_state): Update.
2857         (parse_exp_in_context): Update.
2858         * parser-defs.h (struct parser_state) <parser_state>: Remove
2859         "initial_size" parameter.
2860
2861 2019-04-04  Tom Tromey  <tom@tromey.com>
2862
2863         * parser-defs.h (increase_expout_size): Don't declare.
2864         * parse.c (increase_expout_size): Now static.
2865
2866 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2867
2868         * gnu-nat.c (gnu_nat_target::wait): Fix
2869         target_waitstatus_to_string call.
2870
2871 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * eval.c (evaluate_subexp_standard): Handle internal functions
2874         during Fortran function call handling.
2875
2876 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * NEWS: Mention new internal functions.
2879         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2880         (read_base_type): Use dwarf2_init_complex_target_type.
2881         * value.c (creal_internal_fn): New function.
2882         (cimag_internal_fn): New function.
2883         (_initialize_values): Register new internal functions.
2884
2885 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2886
2887         * infrun.c (stop_all_threads): If debug_infrun, always
2888         trace the wait status after wait_one, using
2889         target_waitstatus_to_string and target_pid_to_str.
2890         (handle_inferior_event): Replace various trace of
2891         wait status kind by a single trace.
2892         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2893         wait status kind image by target_waitstatus_to_string.
2894         * target/waitstatus.c (target_waitstatus_to_string): Fix
2895         obsolete comment.
2896
2897 2019-04-01  Tom Tromey  <tromey@adacore.com>
2898
2899         PR symtab/23331:
2900         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2901
2902 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2903             Pedro Alves  <palves@redhat.com>
2904
2905         * top.c (quit_force): Call 'finalize_values'.
2906         * value.c (finalize_values): New function.
2907         * value.h (finalize_values): Declare.
2908
2909 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2910
2911         * NEWS: Announce $_gdb_major and $_gdb_minor.
2912
2913         * top.c (init_gdb_version_vars): New function.
2914         (gdb_init): Call init_gdb_version_vars.
2915
2916 2019-03-29  Tom Tromey  <tromey@adacore.com>
2917
2918         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2919         help text.  Remove dead code.
2920
2921 2019-03-29  Keith Seitz  <keiths@redhat.com>
2922
2923         From Siddhesh Poyarekar:
2924         * f-lang.h (f77_get_upperbound): Return LONGEST.
2925         (f77_get_lowerbound): Likewise.
2926         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2927         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2928         print them.
2929         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2930         plongest to format print it.
2931         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2932         (f77_get_upperbound): Likewise.
2933         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2934         LOWER_BOUND to LONGEST.
2935         (f77_create_arrayprint_offset_tbl): Likewise.
2936
2937 2019-03-29  Keith Seitz  <keiths@redhat.com>
2938
2939         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2940         %s/pulongest for TYPE_LENGTH instead of %d in format
2941         strings.
2942         * ada-typerint.c (ada_print_type): Likewise.
2943         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2944         * compile/compile-c-support.c (generate_register_struct): Likewise.
2945         * gdbtypes.c (recursive_dump_type): Likewise.
2946         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2947         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2948         instead of %d in format strings.
2949         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2950         to std::min to ULONGEST.
2951         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2952         instead of %d in format strings.
2953         * tracepoint.c (info_scope_command): Likewise.
2954         * typeprint.c (print_offset_data::update)
2955         (print_offset_data::finish): Likewise.
2956         * xtensa-tdep.c (xtensa_store_return_value)
2957         (xtensa_push_dummy_call): Likewise.
2958
2959 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2960
2961         * windows-nat.c (display_selector): Fixed format specifications
2962         for 64-bit Cygwin.
2963
2964 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2965
2966         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2967
2968 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2969
2970         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2971         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2972         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2973         (nios2_linux_init_abi): Install it.
2974
2975 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2976
2977         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2978
2979 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2980
2981         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2982
2983 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2984             Tom Tromey  <tromey@adacore.com>
2985
2986         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2987
2988 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2989
2990         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2991         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2992         method to compute the bounds of range types. Also print "[evaluated]"
2993         if the bounds' values come from a dynamic evaluation.
2994
2995 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2998         whitespace when pretty printing is on.
2999
3000 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3001
3002         * ppc-linux-nat.c: Add include.
3003
3004 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3005
3006         * NEWS: Mention AArch64 Pointer Authentication.
3007
3008 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3009
3010         * arm-linux-nat.c: Add include.
3011
3012 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3013
3014         * source-cache.c (source_cache::get_source_lines): Re-read
3015         fullname after calling open_source_file.
3016
3017 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3018
3019         * NEWS: Mention TLS support for FreeBSD.
3020
3021 2019-03-25  Tom Tromey  <tromey@adacore.com>
3022
3023         * minsyms.c (BUNCH_SIZE): Update comment.
3024         (~minimal_symbol_reader): Remove old comment.
3025         (compact_minimal_symbols): Update comment.
3026         (minimal_symbol_reader::install): Remove old comment.  Update
3027         other comments.
3028
3029 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3030
3031         * s390-linux-nat.c: Add include.
3032
3033 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3034
3035         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3036         Call linux_get_hwcap.
3037         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3038         Likewise.
3039         (aarch64_linux_get_hwcap): Remove function.
3040         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3041         declaration.
3042         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3043         linux_get_hwcap.
3044         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3045         * linux-tdep.c (linux_get_hwcap): Add function.
3046         (linux_get_hwcap2): Likewise.
3047         * linux-tdep.h (linux_get_hwcap): Add declaration.
3048         (linux_get_hwcap2): Likewise.
3049         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3050         (ppc_linux_get_hwcap2): Likewise.
3051         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3052         linux_get_hwcap.
3053         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3054         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3055         (ppc_linux_nat_target::read_description): Likewise.
3056         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3057         * s390-linux-nat.c: Likewise.
3058         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3059
3060 2019-03-24  Tom Tromey  <tom@tromey.com>
3061
3062         * ada-lang.c (standard_lookup): Simplify initialization.
3063         (ada_lookup_symbol_nonlocal): Simplify return.
3064         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3065         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3066         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3067         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3068         initialization.
3069         * solib.c (solib_global_lookup): Simplify.
3070         * symtab.c (null_block_symbol): Remove.
3071         (symbol_cache_lookup): Simplify returns.
3072         (lookup_language_this): Simplify returns.
3073         (lookup_symbol_aux): Simplify return.
3074         (lookup_local_symbol): Simplify returns.
3075         (lookup_global_symbol_from_objfile): Simplify return.
3076         (lookup_symbol_in_objfile_symtabs)
3077         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3078         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3079         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3080         * cp-namespace.c (cp_lookup_bare_symbol)
3081         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3082         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3083         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3084         (cp_lookup_symbol_via_imports): Simplify initialization.
3085         (find_symbol_in_baseclass): Likewise.
3086         * symtab.h (null_block_symbol): Remove.
3087         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3088         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3089         (d_lookup_symbol_module): Likewise.
3090         (find_symbol_in_baseclass): Simplify initialization.
3091
3092 2019-03-24  Tom Tromey  <tom@tromey.com>
3093
3094         * expression.h: Don't include symtab.h.
3095         (struct block): Forward declare.
3096
3097 2019-03-24  Tom Tromey  <tom@tromey.com>
3098
3099         * c-exp.y (typebase): Remove casts.
3100         * gdbtypes.c (lookup_unsigned_typename, )
3101         (lookup_signed_typename): Remove cast.
3102         * eval.c (parse_to_comma_and_eval): Remove cast.
3103         * parse.c (write_dollar_variable): Remove cast.
3104         * block.h (struct block) <superblock>: Now const.
3105         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3106         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3107         (map_block): Make "block" const.
3108         * symfile.h (struct quick_symbol_functions)
3109         <map_matching_symbols>: Constify block argument to "callback".
3110         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3111         const.
3112         (find_pc_sect_compunit_symtab): Make "b" const.
3113         (find_symbol_at_address): Likewise.
3114         (search_symbols): Likewise.
3115         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3116         (dw2_debug_names_lookup_symbol): Likewise.
3117         (dw2_map_matching_symbols): Update.
3118         * p-valprint.c (pascal_val_print): Remove "block".
3119         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3120         (aux_add_nonlocal_symbols): Make "block" const.
3121         (resolve_subexp): Remove cast.
3122         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3123         const.
3124         (iterate_over_file_blocks): Likewise.
3125         * f-exp.y (%union) <bval>: Remove.
3126         * coffread.c (patch_opaque_types): Make "b" const.
3127         * spu-tdep.c (spu_catch_start): Make "block" const.
3128         * c-valprint.c (print_unpacked_pointer): Remove "block".
3129         * symmisc.c (dump_symtab_1): Make "b" const.
3130         (block_depth): Make "block" const.
3131         * d-exp.y (%union) <bval>: Remove.
3132         * cp-support.h (cp_lookup_rtti_type): Update.
3133         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3134         * psymtab.c (psym_lookup_symbol): Make "block" const.
3135         (maintenance_check_psymtabs): Make "b" const.
3136         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3137         (enumerate_locals, enumerate_args): Update.
3138         * python/py-symtab.c (stpy_global_block): Make "block" const.
3139         (stpy_static_block): Likewise.
3140         * inline-frame.c (block_starting_point_at): Make "new_block"
3141         const.
3142         * block.c (find_block_in_blockvector): Make return type const.
3143         (blockvector_for_pc_sect): Make "b" const.
3144         (find_block_in_blockvector): Make "b" const.
3145
3146 2019-03-23  Tom Tromey  <tom@tromey.com>
3147
3148         * varobj.c (varobj_create): Update.
3149         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3150         * printcmd.c (display_command, do_one_display): Don't reset
3151         innermost_block.
3152         * parser-defs.h (enum innermost_block_tracker_type): Move to
3153         expression.h.
3154         (innermost_block): Update comment.
3155         * parse.c (parse_exp_1): Add tracker_types parameter.
3156         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3157         tracker_types parameter.  Reset innermost_block.
3158         (parse_exp_in_context): Remove.
3159         (parse_expression_for_completion): Update.
3160         * objfiles.c (~objfile): Don't reset expression_context_block or
3161         innermost_block.
3162         * expression.h (enum innermost_block_tracker_type): Move from
3163         parser-defs.h.
3164         (parse_exp_1): Add tracker_types parameter.
3165         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3166         reset innermost_block.
3167
3168 2019-03-23  Tom Tromey  <tom@tromey.com>
3169
3170         * objfiles.h: Include bcache.h.
3171
3172 2019-03-23  Tom Tromey  <tom@tromey.com>
3173
3174         * linespec.c (get_current_search_block): Use
3175         scoped_restore_current_language.
3176         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3177
3178 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3179             Jiong Wang  <jiong.wang@arm.com>
3180
3181         * aarch64-linux-tdep.c
3182         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3183         section.
3184         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3185
3186 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3187             Jiong Wang  <jiong.wang@arm.com>
3188
3189         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3190         instructions.
3191         (aarch64_analyze_prologue_test): Add PACIASP test.
3192         (aarch64_prologue_prev_register): Unmask PC value.
3193
3194 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3195             Jiong Wang  <jiong.wang@arm.com>
3196
3197         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3198         (aarch64_dwarf2_prev_register): Unmask PC value.
3199         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3200         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3201         DW_CFA_AARCH64_negate_ra_state.
3202         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3203
3204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3205             Jiong Wang  <jiong.wang@arm.com>
3206
3207         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3208         registers.
3209         (aarch64_pseudo_register_name): Likewise.
3210         (aarch64_pseudo_register_type): Likewise.
3211         (aarch64_pseudo_register_reggroup_p): Likewise.
3212         (aarch64_gdbarch_init): Add pauth registers.
3213         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3214         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3215         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3216         (struct gdbarch_tdep): Add regnum for ra_state.
3217
3218 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3219             Jiong Wang  <jiong.wang@arm.com>
3220
3221         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3222
3223 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3224             Jiong Wang  <jiong.wang@arm.com>
3225
3226         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3227         function.
3228         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3229         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3230         (aarch64_gdbarch_init): Add puth registers.
3231         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3232         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3233         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3234
3235 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3236             Jiong Wang  <jiong.wang@arm.com>
3237
3238         * aarch64-linux-nat.c
3239         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3240         * aarch64-linux-tdep.c
3241         (aarch64_linux_core_read_description): Likewise.
3242         (aarch64_linux_get_hwcap): New function.
3243         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3244         (aarch64_linux_get_hwcap): New declaration.
3245
3246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3247             Jiong Wang  <jiong.wang@arm.com>
3248
3249         * aarch64-linux-nat.c
3250         (aarch64_linux_nat_target::read_description): Add pauth param.
3251         * aarch64-linux-tdep.c
3252         (aarch64_linux_core_read_description): Likewise.
3253         * aarch64-tdep.c (struct target_desc): Add in pauth.
3254         (aarch64_read_description): Add pauth param.
3255         (aarch64_gdbarch_init): Likewise.
3256         * aarch64-tdep.h (aarch64_read_description): Likewise.
3257         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3258         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3259         * features/Makefile: Add new files.
3260         * features/aarch64-pauth.c: New file.
3261         * features/aarch64-pauth.xml: New file.
3262
3263 2019-03-20  Tom Tromey  <tromey@adacore.com>
3264
3265         * infrun.c (handle_inferior_event): Rename from
3266         handle_inferior_event_1.  Create a scoped_value_mark.
3267         (handle_inferior_event): Remove.
3268
3269 2019-03-19  Tom Tromey  <tromey@adacore.com>
3270
3271         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3272         * infrun.h (print_stop_event): Add "displays" parameter.
3273         * infrun.c (print_stop_event): Add "displays" parameter.
3274
3275 2019-03-19  Pedro Alves  <palves@redhat.com>
3276
3277         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3278         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3279         to -1.  Fix TABs vs spaces.
3280         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3281         * tui/tui-out.h (tui_ui_out) Add intro comments.
3282         <m_line, m_start_of_line>: In-class initialize, and add describing
3283         comment.
3284
3285 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3286
3287         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3288         variable names.
3289         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3290
3291 2019-03-18  Pedro Alves  <palves@redhat.com>
3292             Eli Zaretskii <eliz@gnu.org>
3293
3294         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3295         m_line and m_start_of_line.
3296
3297 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3298
3299         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3300         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3301         it returns a newline.  This fixes a regression in TU mode, whereby
3302         the next line is output on the same screen line as the user input.
3303
3304 2019-03-18  Tom Tromey  <tromey@adacore.com>
3305
3306         * minsyms.c (minimal_symbol_reader::install): Remove call to
3307         obstack_blank.
3308
3309 2019-03-18  Pedro Alves  <palves@redhat.com>
3310
3311         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3312         New globals.
3313         (apply_style): New, factored out from ...
3314         (apply_ansi_escape): ... this.  Handle reverse video mode.
3315         (tui_set_reverse_mode): New function.
3316         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3317         * tui/tui-winsource.c (tui_show_source_line): Use
3318         tui_set_reverse_mode instead of setting A_STANDOUT.
3319         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3320         New setter methods.
3321
3322 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3323
3324         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3325         Handle tabs.
3326
3327 2019-03-18  Tom Tromey  <tromey@adacore.com>
3328
3329         * ada-lang.c (empty_array): Add "high" parameter.
3330         (ada_evaluate_subexp): Update.
3331
3332 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3333
3334         * unittests/string_view-selftests.c: Define
3335         _initialize_string_view_selftests unconditionally.
3336
3337 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3338
3339         PR gdb/24350
3340         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3341
3342 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3343
3344         PR gdb/24351
3345         * windows-nat.c (display_selector): Fix format specifiers.
3346
3347 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3348
3349         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3350         tui_refill_source_window instead of tui_refresh_win, to update the
3351         current execution line.  This fixes redisplay of the current line
3352         when stepping through the code with "next" or "step".
3353
3354 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3355
3356         * source-cache.c (source_cache::get_source_lines): Call
3357         find_source_lines to initialize s->nlines.  This fixes vertical
3358         scrolling of TUI source window when the DOWN arrow is pressed.
3359
3360 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3361
3362         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3363         linux-thread-db.c (_initialize_thread_db): Likewise.
3364
3365 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3366
3367         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3368         wclrtoeol in tui_show_source_line".  This reverts changes made in
3369         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3370
3371 2019-03-15  Tom Tromey  <tom@tromey.com>
3372
3373         * symtab.h (struct minimal_symbol): Derive from
3374         general_symbol_info.
3375         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3376         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3377         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3378         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3379         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3380         (MSYMBOL_SEARCH_NAME): Update.
3381         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3382         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3383         * minsyms.c (minimal_symbol_reader::record_full): Update.
3384
3385 2019-03-15  Tom Tromey  <tom@tromey.com>
3386
3387         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3388
3389 2019-03-15  Tom Tromey  <tom@tromey.com>
3390
3391         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3392         unique_xmalloc_ptr.
3393         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3394         Update.
3395         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3396         (build_minimal_symbol_hash_tables)
3397         (minimal_symbol_reader::install): Update.
3398
3399 2019-03-15  Tom Tromey  <tom@tromey.com>
3400
3401         * symtab.c (create_demangled_names_hash): Update.
3402         (symbol_set_names): Update.
3403         * objfiles.h (struct objfile_per_bfd_storage)
3404         <demangled_names_hash>: Now an htab_up.
3405         * objfiles.c (objfile_per_bfd_storage): Simplify.
3406
3407 2019-03-15  Tom Tromey  <tom@tromey.com>
3408
3409         * objfiles.h (struct objfile_per_bfd_storage): Declare
3410         destructor.
3411         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3412         New.
3413         (get_objfile_bfd_data): Use new.  Don't initialize
3414         language_of_main.
3415         (free_objfile_per_bfd_storage): Remove.
3416         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3417
3418 2019-03-15  Tom Tromey  <tom@tromey.com>
3419
3420         * symfile.c (reread_symbols): Update.
3421         * objfiles.c (objfile::objfile): Update.
3422         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3423         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3424         comment.
3425         (minimal_symbol_reader::install): Update.
3426         (terminate_minimal_symbol_table): Remove.
3427         * jit.c (jit_object_close_impl): Update.
3428
3429 2019-03-15  Tom Tromey  <tom@tromey.com>
3430
3431         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3432         initializations.
3433
3434 2019-03-15  Tom Tromey  <tom@tromey.com>
3435
3436         * objfiles.h (struct objfile_per_bfd_storage)
3437         <demangled_hash_languages>: Now a bitset.
3438         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3439         (lookup_minimal_symbol): Update.
3440
3441 2019-03-15  Tom Tromey  <tom@tromey.com>
3442
3443         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3444         Don't return the symbol.
3445         * coffread.c (record_minimal_symbol): Use record_full.
3446
3447 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3448
3449         The MS-Windows port of ncurses fails to switch to a color pair if
3450         one or both of the colors are the implicit default colors.  This
3451         change records the default colors when TUI is initialized, and
3452         then specifies them explicitly when a color pair uses the default
3453         colors.  This allows color styling in TUI mode on MS-Windows.
3454
3455         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3456         ncurses_norm_attr.
3457         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3458         colors in ncurses_norm_attr.
3459         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3460         "none", replace it with the default color recorded in
3461         ncurses_norm_attr.
3462
3463 2019-03-14  Tom Tromey  <tromey@adacore.com>
3464
3465         * source-cache.h (class source_cache) <get_source_lines>: Return
3466         std::string.
3467         * source-cache.c (source_cache::extract_lines): Handle case where
3468         first_pos==npos.  Return std::string.
3469         (source_cache::get_source_lines): Update.
3470
3471 2019-03-14  Tom Tromey  <tromey@adacore.com>
3472
3473         * NEWS: Add item for "style sources" commands.
3474         * source-cache.c (source_cache::get_source_lines): Check
3475         source_styling.
3476         * cli/cli-style.c (source_styling): New global.
3477         (_initialize_cli_style): Add "style sources" commands.
3478         (show_style_sources): New function.
3479         * cli/cli-style.h (source_styling): Declare.
3480
3481 2019-03-14  Pedro Alves  <palves@redhat.com>
3482             Tom Tromey  <tromey@adacore.com>
3483
3484         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3485         * tui/tui-winsource.c (tui_refill_source_window): New function,
3486         from...
3487         (tui_horizontal_source_scroll): ... here.  Move some logic.
3488         * cli/cli-style.c (set_style_enabled): Notify new observable.
3489         * tui/tui-hooks.c (tui_redisplay_source): New function.
3490         (tui_attach_detach_observers): Attach or detach
3491         tui_redisplay_source.
3492         * observable.h (source_styling_changed): New observable.
3493         * observable.c: Define source_styling_changed observable.
3494
3495 2019-03-13  Tom Tromey  <tromey@adacore.com>
3496
3497         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3498         (i386_gnu_nat_target::store_registers): Update.
3499         * target-debug.h (target_debug_print_std_string): New macro.
3500         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3501         * windows-tdep.c (display_one_tib): Update.
3502         * tui/tui-stack.c (tui_make_status_line): Update.
3503         * top.c (print_inferior_quit_action): Update.
3504         * thread.c (thr_try_catch_cmd): Update.
3505         (add_thread_with_info): Update.
3506         (thread_target_id_str): Update.
3507         (thr_try_catch_cmd): Update.
3508         (thread_command): Update.
3509         (thread_find_command): Update.
3510         * record-btrace.c (record_btrace_target::info_record)
3511         (record_btrace_resume_thread, record_btrace_target::resume)
3512         (record_btrace_cancel_resume, record_btrace_step_thread)
3513         (record_btrace_target::wait, record_btrace_target::wait)
3514         (record_btrace_target::wait, record_btrace_target::stop): Update.
3515         * progspace.c (print_program_space): Update.
3516         * process-stratum-target.c
3517         (process_stratum_target::thread_address_space): Update.
3518         * linux-fork.c (linux_fork_mourn_inferior)
3519         (detach_checkpoint_command, info_checkpoints_command)
3520         (linux_fork_context): Update.
3521         (linux_fork_detach): Update.
3522         (class scoped_switch_fork_info): Update.
3523         (delete_checkpoint_command): Update.
3524         * infrun.c (follow_fork_inferior): Update.
3525         (follow_fork_inferior): Update.
3526         (proceed_after_vfork_done): Update.
3527         (handle_vfork_child_exec_or_exit): Update.
3528         (follow_exec): Update.
3529         (displaced_step_prepare_throw): Update.
3530         (displaced_step_restore): Update.
3531         (start_step_over): Update.
3532         (resume_1): Update.
3533         (clear_proceed_status_thread): Update.
3534         (proceed): Update.
3535         (print_target_wait_results): Update.
3536         (do_target_wait): Update.
3537         (context_switch): Update.
3538         (stop_all_threads): Update.
3539         (restart_threads): Update.
3540         (finish_step_over): Update.
3541         (handle_signal_stop): Update.
3542         (switch_back_to_stepped_thread): Update.
3543         (keep_going_pass_signal): Update.
3544         (print_exited_reason): Update.
3545         (normal_stop): Update.
3546         * inferior.c (inferior_pid_to_str): Change return type.
3547         (print_selected_inferior): Update.
3548         (add_inferior): Update.
3549         (detach_inferior): Update.
3550         * dummy-frame.c (fprint_dummy_frames): Update.
3551         * dcache.c (dcache_info_1): Update.
3552         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3553         (btrace_fetch, btrace_clear): Update.
3554         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3555         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3556         type.
3557         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3558         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3559         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3560         * gdbarch.c, gdbarch.h: Rebuild.
3561         * gdbarch.sh (core_pid_to_str): Change return type.
3562         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3563         return type.
3564         (windows_nat_target::pid_to_str): Change return type.
3565         (windows_delete_thread): Update.
3566         (windows_nat_target::attach): Update.
3567         (windows_nat_target::files_info): Update.
3568         * target-delegates.c: Rebuild.
3569         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3570         return type.
3571         (sol_thread_target::pid_to_str): Change return type.
3572         * remote.c (class remote_target) <pid_to_str>: Change return
3573         type.
3574         (remote_target::pid_to_str): Change return type.
3575         (extended_remote_target::attach, remote_target::remote_stop_ns)
3576         (remote_target::remote_notif_remove_queued_reply)
3577         (remote_target::push_stop_reply, remote_target::disable_btrace):
3578         Update.
3579         (extended_remote_target::attach): Update.
3580         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3581         type.
3582         (gdbsim_target::pid_to_str): Change return type.
3583         * ravenscar-thread.c (struct ravenscar_thread_target)
3584         <pid_to_str>: Change return type.
3585         (ravenscar_thread_target::pid_to_str): Change return type.
3586         * procfs.c (class procfs_target) <pid_to_str>: Change return
3587         type.
3588         (procfs_target::pid_to_str): Change return type.
3589         (procfs_target::attach): Update.
3590         (procfs_target::detach): Update.
3591         (procfs_target::fetch_registers): Update.
3592         (procfs_target::store_registers): Update.
3593         (procfs_target::wait): Update.
3594         (procfs_target::files_info): Update.
3595         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3596         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3597         return type.
3598         (nto_procfs_target::pid_to_str): Change return type.
3599         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3600         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3601         return type.
3602         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3603         (exit_lwp): Update.
3604         (attach_proc_task_lwp_callback, get_detach_signal)
3605         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3606         (linux_nat_target::resume, wait_lwp, stop_callback)
3607         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3608         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3609         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3610         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3611         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3612         type.
3613         (inf_ptrace_target::attach): Update.
3614         (inf_ptrace_target::files_info): Update.
3615         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3616         type.
3617         (go32_nat_target::pid_to_str): Change return type.
3618         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3619         (gnu_nat_target::wait): Update.
3620         (gnu_nat_target::wait): Update.
3621         (gnu_nat_target::resume): Update.
3622         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3623         (fbsd_nat_target::wait): Update.
3624         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3625         type.
3626         (darwin_nat_target::attach): Update.
3627         * corelow.c (class core_target) <pid_to_str>: Change return type.
3628         (core_target::pid_to_str): Change return type.
3629         * target.c (normal_pid_to_str): Change return type.
3630         (default_pid_to_str): Likewise.
3631         (target_pid_to_str): Change return type.
3632         (target_translate_tls_address): Update.
3633         (target_announce_detach): Update.
3634         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3635         return type.
3636         (bsd_uthread_target::pid_to_str): Change return type.
3637         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3638         type.
3639         (bsd_kvm_target::pid_to_str): Change return type.
3640         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3641         return type.
3642         (aix_thread_target::pid_to_str): Change return type.
3643         * target.h (struct target_ops) <pid_to_str>: Change return type.
3644         (target_pid_to_str, normal_pid_to_str): Likewise.
3645         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3646         type.
3647         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3648         type.
3649         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3650         return type.
3651         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3652         type.
3653         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3654         type.
3655         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3656         return type.
3657
3658 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3659
3660         * NEWS: Mention that the new default MI version is 3.  Mention
3661         changes to the output of commands and events that deal with
3662         multi-location breakpoints.
3663         * breakpoint.c: Include "mi/mi-out.h".
3664         (print_one_breakpoint): Change output syntax if using MI version
3665         >= 3.
3666         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3667         New.
3668         (mi_multi_location_breakpoint_output_fixed): New.
3669         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3670         (mi_cmd_fix_multi_location_breakpoint_output): New.
3671         (mi_multi_location_breakpoint_output_fixed): New.
3672         * mi/mi-cmds.c (mi_cmds): Register command
3673         -fix-multi-location-breakpoint-output.
3674         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3675         interpreter "mi".
3676
3677 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3678
3679         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3680         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3681         instantiate mi_ui_out based on interpreter name.
3682         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3683         * mi/mi-main.c (mi_load_progress): Likewise.
3684
3685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3686
3687         * NEWS: Combine separate "New targets" sections for 8.3.
3688
3689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3690
3691         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3692         (ppcfbsd_init_abi): Install gdbarch
3693         "fetch_tls_load_module_address" and "get_thread_local_address"
3694         methods.
3695
3696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3697
3698         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3699         (riscv_fbsd_init_abi): Install gdbarch
3700         "fetch_tls_load_module_address" and "get_thread_local_address"
3701         methods.
3702
3703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3704
3705         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3706         (i386fbsd_init_abi): Install gdbarch
3707         "fetch_tls_load_module_address" and "get_thread_local_address"
3708         methods.
3709
3710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3711
3712         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3713         (amd64fbsd_init_abi): Install gdbarch
3714         "fetch_tls_load_module_address" and "get_thread_local_address"
3715         methods.
3716
3717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3718
3719         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3720         (struct fbsd_pspace_data): New type.
3721         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3722         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3723         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3724         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3725         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3726
3727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3728
3729         * gdbtypes.c (lookup_struct_elt): New function.
3730         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3731         * gdbtypes.h (struct struct_elt): New type.
3732         (lookup_struct_elt): New prototype.
3733
3734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3735
3736         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3737         remove disabled code block.
3738
3739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3740
3741         * gdbarch.sh (get_thread_local_address): New method.
3742         * gdbarch.h, gdbarch.c: Regenerate.
3743         * target.c (target_translate_tls_address): Use
3744         gdbarch_get_thread_local_address if present instead of
3745         target::get_thread_local_address.
3746
3747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3748
3749         * target.h (target::get_thread_local_address): Update comment.
3750
3751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3752
3753         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3754         objfile->separate_debug_objfile_backlink if not NULL.
3755
3756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3757
3758         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3759         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3760         (amd64bsd_store_inferior_registers): Likewise.
3761         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3762         Enable segment base registers.
3763         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3764         PT_GETFSBASE and PT_GETGSBASE.
3765         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3766         PT_SETGSBASE.
3767         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3768         segment base registers.
3769         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3770
3771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3772
3773         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3774         Update calls to i386_target_description to add 'segments'
3775         parameter.
3776         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3777         add segment base registers.
3778         * arch/i386.c (i386_create_target_description): Add 'segments'
3779         parameter to enable segment base registers.
3780         * arch/i386.h (i386_create_target_description): Likewise.
3781         * features/i386/32bit-segments.xml: New file.
3782         * features/i386/32bit-segments.c: Generate.
3783         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3784         call to i386_target_description to add 'segments' parameter.
3785         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3786         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3787         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3788         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3789         if feature is present.
3790         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3791         Add 'segments' parameter to call to i386_target_description.
3792         (i386_target_description): Add 'segments' parameter to enable
3793         segment base registers.
3794         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3795         to call to i386_target_description.
3796         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3797         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3798         Define I386_NUM_REGS.
3799         (i386_target_description): Add 'segments' parameter to enable
3800         segment base registers.
3801
3802 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3803
3804         PR/24325
3805         * source-cache.c: #undef open and close, to avoid unresolved
3806         externals during linking.
3807
3808 2019-03-12  Tom Tromey  <tromey@adacore.com>
3809
3810         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3811         const.  Add initializers.
3812         (_initialize_remote): Don't initialize ptid globals.
3813
3814 2019-03-12  Pedro Alves  <palves@redhat.com>
3815
3816         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3817
3818 2019-03-12  Pedro Alves  <palves@redhat.com>
3819
3820         * cp-name-parser.y (main): Remove unused 'len' variable.
3821
3822 2019-03-12  Tom Tromey  <tromey@adacore.com>
3823
3824         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3825         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3826
3827 2019-03-12  Tom Tromey  <tromey@adacore.com>
3828
3829         * linux-nat.c (iterate_over_lwps): Update.
3830         (stop_callback): Remove parameter.
3831         (stop_wait_callback, detach_callback, resume_set_callback)
3832         (select_singlestep_lwp_callback, set_ignore_sigint)
3833         (status_callback, resumed_callback, resume_clear_callback)
3834         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3835         data parameter.
3836         (linux_nat_target::detach, linux_nat_target::resume)
3837         (linux_stop_and_wait_all_lwps, select_event_lwp)
3838         (linux_nat_filter_event, linux_nat_wait_1)
3839         (linux_nat_target::kill, linux_nat_target::stop)
3840         (linux_nat_target::stop): Update.
3841         (linux_nat_resume_callback): Change type.
3842         (resume_stopped_resumed_lwps, count_events_callback)
3843         (select_event_lwp_callback): Likewise.
3844         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3845         * arm-linux-nat.c (struct update_registers_data): Remove.
3846         (update_registers_callback): Change type.
3847         (arm_linux_insert_hw_breakpoint1): Update.
3848         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3849         parameter.
3850         (x86_linux_dr_set_addr): Update.
3851         (x86_linux_dr_set_control): Update.
3852         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3853         (iterate_over_lwps): Use gdb::function_view.
3854         * nat/aarch64-linux-hw-point.c (struct
3855         aarch64_dr_update_callback_param): Remove.
3856         (debug_reg_change_callback): Change type.
3857         (aarch64_notify_debug_reg_change): Update.
3858         * s390-linux-nat.c (s390_refresh_per_info): Update.
3859
3860 2019-03-11  Tom Tromey  <tromey@adacore.com>
3861
3862         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3863         redundant assignment to "this_cu".
3864
3865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3866
3867         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3868
3869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3870
3871         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3872         from...
3873         (rank_one_type): ... this.
3874
3875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3876
3877         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3878         from...
3879         (rank_one_type): ... this.
3880
3881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3882
3883         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3884         from...
3885         (rank_one_type): ... this.
3886
3887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3888
3889         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3890         from...
3891         (rank_one_type): ... this.
3892
3893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3894
3895         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3896         from...
3897         (rank_one_type): ... this.
3898
3899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3900
3901         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3902         from...
3903         (rank_one_type): ... this.
3904
3905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3906
3907         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3908         from...
3909         (rank_one_type): ... this.
3910
3911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3912
3913         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3914         from...
3915         (rank_one_type): ... this.
3916
3917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3918
3919         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3920         from...
3921         (rank_one_type): ... this.
3922
3923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3924
3925         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3926         from...
3927         (rank_one_type): ... this.
3928
3929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3930
3931         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3932         from...
3933         (rank_one_type): ... this.
3934
3935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3936
3937         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3938         from...
3939         (rank_one_type): ... this.
3940
3941 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3942
3943         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3944         inferior-events' shows the example events.
3945
3946 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3947
3948         Support styling on native MS-Windows console
3949
3950         PR/24315
3951         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3952         on MS-Windows if $TERM is not defined.
3953
3954         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3955
3956         * posix-hdep.c (gdb_console_fputs):
3957         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3958         functions.
3959         * ui-file.h (gdb_console_fputs): Add prototype.
3960
3961         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3962         back to fputs only if the former returns zero.
3963
3964 2019-03-07  Tom Tromey  <tom@tromey.com>
3965
3966         * symmisc.c (print_symbol_bcache_statistics): Update.
3967         (print_objfile_statistics): Update.
3968         * symfile.c (allocate_symtab): Update.
3969         * stabsread.c: Don't include bcache.h.
3970         * psymtab.h (struct psymbol_bcache): Don't declare.
3971         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3972         (psymbol_bcache_init, psymbol_bcache_free)
3973         (psymbol_bcache_get_bcache): Don't declare.
3974         * psymtab.c (struct psymbol_bcache): Remove.
3975         (psymtab_storage::psymtab_storage): Update.
3976         (psymtab_storage::~psymtab_storage): Update.
3977         (psymbol_bcache_init, psymbol_bcache_free)
3978         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3979         (add_psymbol_to_bcache): Update.
3980         (allocate_psymtab): Update.
3981         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3982         macro_cache>: No longer pointers.
3983         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3984         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3985         * macrotab.c (macro_bcache): Update.
3986         * macroexp.c: Don't include bcache.h.
3987         * gdbtypes.c (check_types_worklist): Update.
3988         (types_deeply_equal): Remove TRY/CATCH.  Update.
3989         * elfread.c (elf_symtab_read): Update.
3990         * dwarf2read.c: Don't include bcache.h.
3991         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3992         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3993         (print_bcache_statistics, bcache_memory_used): Don't declare.
3994         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3995         methods.  Rename all data members.
3996         * bcache.c (struct bcache): Move to bcache.h.
3997         (bcache::expand_hash_table): Rename from expand_hash_table.
3998         (bcache): Remove.
3999         (bcache::insert): Rename from bcache_full.
4000         (bcache::compare): Rename from bcache_compare.
4001         (bcache_xmalloc): Remove.
4002         (bcache::~bcache): Rename from bcache_xfree.
4003         (bcache::print_statistics): Rename from print_bcache_statistics.
4004         (bcache::memory_used): Rename from bcache_memory_used.
4005
4006 2019-03-07  Pedro Alves  <palves@redhat.com>
4007
4008         * infrun.c (normal_stop): Also check for
4009         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4010
4011 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * f-lang.c (value_from_host_double): Moved to...
4014         * value.c (value_from_host_double): ...here.
4015         * value.h (value_from_host_double): Declare.
4016         * guile/scm-math.c (vlscm_convert_typed_number): Use
4017         value_from_host_double.
4018         (vlscm_convert_number): Likewise.
4019         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4020         * python/py-value.c (convert_value_from_python): Likewise.
4021
4022 2019-03-06  Tom Tromey  <tom@tromey.com>
4023
4024         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4025
4026 2019-03-06  Tom Tromey  <tom@tromey.com>
4027
4028         * utils.h (free_current_contents): Don't declare.
4029         * utils.c (free_current_contents): Remove.
4030
4031 2019-03-06  Tom Tromey  <tom@tromey.com>
4032
4033         * top.c (quit_force): Update.
4034         * main.c (captured_command_loop): Update.
4035         * common/new-op.c (operator new): Update.
4036         * common/common-exceptions.c (struct catcher)
4037         <save_cleanup_chain>: Remove member.
4038         (exceptions_state_mc_init): Update.
4039         (exception_try_scope_entry): Return nullptr.
4040         (exception_try_scope_exit, exception_rethrow)
4041         (throw_exception_sjlj, throw_exception_cxx): Update.
4042         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4043         (all_cleanups, do_cleanups, discard_cleanups)
4044         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4045         (restore_cleanups, restore_final_cleanups): Don't declare.
4046         (do_final_cleanups): Remove parameter.
4047         * common/cleanups.c (cleanup_chain, make_cleanup)
4048         (make_cleanup_dtor, all_cleanups, do_cleanups)
4049         (discard_my_cleanups, discard_cleanups)
4050         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4051         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4052         (null_cleanup): Remove.
4053         (do_final_cleanups): Remove parameter.
4054
4055 2019-03-06  Tom Tromey  <tom@tromey.com>
4056
4057         * remote.c (remote_target::remote_parse_stop_reply): Use
4058         unique_xmalloc_ptr.
4059
4060 2019-03-06  Tom Tromey  <tom@tromey.com>
4061
4062         * stabsread.c (struct stabs_field_info): Rename from field_info.
4063         <list, fnlist>: Add initializers.
4064         <obstack>: New member.
4065         (read_member_functions, read_struct_fields, read_baseclasses):
4066         Allocate on obstack.  Don't use cleanups.
4067         (read_one_struct_field, read_member_functions, read_struct_fields)
4068         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4069         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4070         (read_struct_type): Update.
4071
4072 2019-03-06  Tom Tromey  <tom@tromey.com>
4073
4074         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4075         * common/filestuff.h (make_cleanup_close): Don't declare.
4076         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4077         Remove.
4078
4079 2019-03-06  Tom Tromey  <tom@tromey.com>
4080
4081         * solib-aix.c: Use make_scope_exit.
4082
4083 2019-03-06  Tom Tromey  <tom@tromey.com>
4084
4085         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4086         Use make_scope_exit.
4087
4088 2019-03-06  Tom Tromey  <tom@tromey.com>
4089
4090         * solib-svr4.c (disable_probes_interface): Remove parameter.
4091         (svr4_handle_solib_event): Use make_scope_exit.
4092
4093 2019-03-06  Tom Tromey  <tom@tromey.com>
4094
4095         * remote.c (struct stop_reply_deleter): Remove.
4096         (stop_reply_up): Update.
4097         (struct stop_reply): Derive from notif_event.  Don't typedef.
4098         <regcache>: Now a std::vector.
4099         (stop_reply_xfree): Remove.
4100         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4101         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4102         (remote_target::discard_pending_stop_replies): Use delete.
4103         (remote_target::remote_parse_stop_reply): Update.
4104         (remote_target::process_stop_reply): Update.
4105         * remote-notif.h (struct notif_event): Add virtual destructor.
4106         Remove "dtr" member.
4107         (struct notif_client) <alloc_event>: Return a unique_ptr.
4108         (notif_event_xfree): Don't declare.
4109         (notif_event_up): New typedef.
4110         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4111         (notif_event_xfree, do_notif_event_xfree): Remove.
4112         (remote_notif_state_xfree): Update.
4113
4114 2019-03-06  Tom Tromey  <tom@tromey.com>
4115
4116         * infrun.c (displaced_step_clear_cleanup): Now a
4117         forward_scope_exit type.
4118         (displaced_step_prepare_throw): Update.
4119         (displaced_step_fixup): Update.
4120
4121 2019-03-06  Tom Tromey  <tom@tromey.com>
4122
4123         * inferior.h (class inferior): Update comment.
4124         * gdbthread.h (class thread_info): Update comment.
4125
4126 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4127             Tom Tromey  <tom@tromey.com>
4128
4129         * stabsread.h (struct stab_section_list): Remove.
4130         (coffstab_build_psymtabs): Update.
4131         * dbxread.c (symbuf_sections): Now a std::vector.
4132         (sect_idx): New global.
4133         (fill_symbuf): Update.
4134         (coffstab_build_psymtabs): Change type of stabsects parameter.
4135         Update.
4136         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4137         std::vector.
4138         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4139         (coff_locate_sections): Update.
4140         (coff_symfile_read): Remove cleanups.  Update.
4141         (init_stringtab): Add storage parameter.
4142         (free_stringtab, free_stringtab_cleanup): Remove.
4143         (init_lineno): Add storage parameter.
4144         (free_linetab, free_linetab_cleanup): Remove.
4145
4146 2019-03-06  Pedro Alves  <palves@redhat.com>
4147
4148         * linux-fork.c (fork_info::clobber_regs): Delete.
4149         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4150         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4151         comment.  Adjust.
4152         (scoped_switch_fork_info::scoped_switch_fork_info)
4153         (checkpoint_command, linux_fork_context): Adjust
4154         fork_save_infrun_state calls.
4155
4156 2019-03-06  Pedro Alves  <palves@redhat.com>
4157
4158         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4159         (inf_has_multiple_threads): Return 'bool' and rewrite using
4160         inferior_info::threads().
4161
4162 2019-03-06  Pedro Alves  <palves@redhat.com>
4163
4164         * linux-fork.c: Include <list>.
4165         (fork_list): Now a std::list instance.
4166         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4167         (forks_exist_p, find_last_fork): Adjust.
4168         (new_fork): Delete.
4169         (one_fork_p): New.
4170         (add_fork): Adjust.
4171         (free_fork): Delete, folded into fork_info::~fork_info().
4172         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4173         Adjust.
4174         (init_fork_list): Delete.
4175         (linux_fork_killall, linux_fork_mourn_inferior)
4176         (linux_fork_detach, info_checkpoints_command): Adjust.
4177         (_initialize_linux_fork): No longer call init_fork_list.
4178
4179 2019-03-06  Pedro Alves  <palves@redhat.com>
4180
4181         * linux-fork.c (new_fork): New, split out of ...
4182         (add_fork): ... this.  Return void.  Move "first fork" special
4183         case from here, to ...
4184         (checkpoint_command): ... here.
4185         * linux-linux.h (add_fork): Return void.
4186
4187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4190
4191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4192             Chris January  <chris.january@arm.com>
4193             David Lecomber  <david.lecomber@arm.com>
4194
4195         * f-exp.y: New token, UNOP_INTRINSIC.
4196         (exp): New pattern using UNOP_INTRINSIC token.
4197         (f77_keywords): Add 'abs' keyword.
4198         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4199         (value_from_host_double): New function.
4200         (evaluate_subexp_f): Support UNOP_ABS.
4201
4202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4205         types.
4206
4207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4208
4209         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4210         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4211         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4212
4213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4216
4217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4218             Chris January  <chris.january@arm.com>
4219
4220         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4221         * f-exp.y: Define 'KIND' token.
4222         (exp): New pattern for KIND expressions.
4223         (ptype): Handle types with a kind extension.
4224         (direct_abs_decl): Extend to spot kind extensions.
4225         (f77_keywords): Add 'kind' to the list.
4226         (push_kind_type): New function.
4227         (convert_to_kind_type): New function.
4228         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4229         * parse.c (operator_length_standard): Likewise.
4230         * parser-defs.h (enum type_pieces): Add tp_kind.
4231         * std-operator.def: Add UNOP_KIND.
4232
4233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * f-exp.y (f_parse): Set yydebug.
4236
4237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * f-lang.c (evaluate_subexp_f): New function.
4240         (exp_descriptor_f): New global.
4241         (f_language_defn): Use exp_descriptor_f instead of
4242         exp_descriptor_standard.
4243
4244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4245
4246         * f-exp.y (struct token): Add comments.
4247         (dot_ops): Remove uppercase versions and the end marker.
4248         (f77_keywords): Likewise.
4249         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4250         entries in the dot_ops array are case insensitive, and use
4251         strncasecmp to compare strings.  Also some whitespace cleanup in
4252         this area.  Similar for the f77_keywords array, except entries in
4253         this list might be case sensitive.
4254
4255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * f-exp.y (struct f77_boolean_val): Add comments.
4258         (boolean_values): Remove uppercase versions, and end marker.
4259         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4260         and use strncasecmp to achieve case insensitivity.  Additionally,
4261         perform whitespace cleanup around this code.
4262
4263 2019-03-06  Tom Tromey  <tromey@adacore.com>
4264
4265         * remote-sim.c (gdbsim_target_open): Use result of
4266         gdb_argv::release.
4267
4268 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4269         Dirk Schubert  <dirk.schubert@arm.com>
4270         Chris January  <chris.january@arm.com>
4271
4272         * eval.c (evaluate_subexp_standard): Call Fortran argument
4273         wrapping logic.
4274         * f-lang.c (struct value): A value which can be passed into a
4275         Fortran function call.
4276         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4277         where appropriate.
4278         (struct type): Value ready for a Fortran function call.
4279         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4280         is needed.
4281         * f-lang.h (fortran_argument_convert): Declaration.
4282         (fortran_preserve_arg_pointer): Declaration.
4283         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4284
4285 2019-03-05  Tom Tromey  <tromey@adacore.com>
4286
4287         * python/py-prettyprint.c (print_string_repr): Remove #if.
4288         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4289
4290 2019-03-05  Tom Tromey  <tromey@adacore.com>
4291
4292         * target.c (the_dummy_target): Move later.  Change type to
4293         "dummy_target".
4294         (initialize_targets): Don't initialize the_dummy_target.
4295
4296 2019-03-05  Tom Tromey  <tromey@adacore.com>
4297
4298         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4299         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4300
4301 2019-03-05  Tom Tromey  <tromey@adacore.com>
4302
4303         * windows-nat.c (windows_nat_target::attach)
4304         (windows_nat_target::detach): Don't call gdb_flush.
4305         * valprint.c (generic_val_print, val_print, val_print_string):
4306         Don't call gdb_flush.
4307         * utils.c (defaulted_query): Don't call gdb_flush.
4308         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4309         * target.c (target_announce_detach): Don't call gdb_flush.
4310         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4311         * remote.c (extended_remote_target::attach): Don't call
4312         gdb_flush.
4313         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4314         * printcmd.c (do_examine): Don't call gdb_flush.
4315         (info_display_command): Don't call gdb_flush.
4316         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4317         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4318         * memattr.c (info_mem_command): Don't call gdb_flush.
4319         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4320         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4321         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4322         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4323         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4324         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4325         (gnu_nat_target::detach): Don't call gdb_flush.
4326         * f-valprint.c (f_val_print): Don't call gdb_flush.
4327         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4328         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4329         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4330         gdb_flush.
4331         * c-valprint.c (c_val_print): Don't call gdb_flush.
4332         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4333
4334 2019-03-05  Tom Tromey  <tromey@adacore.com>
4335
4336         * varobj.c (update_dynamic_varobj_children): Update.
4337         (install_default_visualizer): Use reset, not release.
4338         * value.c (set_internalvar): Update.
4339         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4340         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4341         ATTRIBUTE_UNUSED_RESULT.
4342
4343 2019-03-05  Tom Tromey  <tromey@adacore.com>
4344
4345         * remote.c (class scoped_remote_fd) <release>: Add
4346         ATTRIBUTE_UNUSED_RESULT.
4347
4348 2019-03-05  Tom Tromey  <tromey@adacore.com>
4349
4350         * macroexp.c (struct macro_buffer) <release>: Add
4351         ATTRIBUTE_UNUSED_RESULT.
4352
4353 2019-03-05  Tom Tromey  <tromey@adacore.com>
4354
4355         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4356         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4357         ATTRIBUTE_UNUSED_RESULT.
4358
4359 2019-03-05  Tom Tromey  <tromey@adacore.com>
4360
4361         * common/scoped_fd.h (class scoped_fd) <release>: Add
4362         ATTRIBUTE_UNUSED_RESULT.
4363
4364 2019-03-05  Tom Tromey  <tromey@adacore.com>
4365
4366         * parser-defs.h (struct parser_state) <release>: Add
4367         ATTRIBUTE_UNUSED_RESULT.
4368
4369 2019-03-05  Tom Tromey  <tromey@adacore.com>
4370
4371         * utils.h (class gdb_argv) <release>: Add
4372         ATTRIBUTE_UNUSED_RESULT.
4373         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4374
4375 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4376
4377         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4378         for-loop range, to avoid compiler warnings.
4379
4380         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4381         avoid compiler warnings about unused variables.
4382
4383         * NEWS: Mention end of support for native debugging on MS-Windows
4384         before XP.
4385
4386         PR gdb/24292
4387         * common/netstuff.c:
4388         * gdbserver/gdbreplay.c
4389         * gdbserver/remote-utils.c:
4390         * ser-tcp.c:
4391         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4392         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4393         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4394         'getaddrinfo' and 'freeaddrinfo' were not available before
4395         Windows XP, and mingw.org's MinGW headers by default define
4396         _WIN32_WINNT to 0x500.
4397
4398 2019-03-01  Gary Benson <gbenson@redhat.com>
4399
4400         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4401
4402 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4403             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4404
4405         PR gdb/8527
4406         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4407         set_sigint_trap, clear_sigint_trap.
4408
4409 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4410
4411         * target.c (target_detach): Clear the regcache and the
4412         frame cache.
4413
4414 2019-02-27  Pedro Alves  <palves@redhat.com>
4415
4416         * utils.c (set_screen_size): When we cap the height/width sizes,
4417         tweak the corresponding command variable to show "unlimited":
4418
4419 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4420             Pedro Alves  <palves@redhat.com>
4421
4422         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4423         before calling rl_set_screen_size.
4424
4425 2019-02-27  Tom Tromey  <tromey@adacore.com>
4426
4427         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4428         define.
4429         * python/py-value.c: Remove Python 2.4 workaround.
4430         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4431         workaround.
4432         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4433         Python 2.4 workaround.
4434         * python/python-internal.h: Remove Python 2.4 comment.
4435         (Py_ssize_t): Don't define.
4436         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4437         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4438         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4439         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4440         * python/python.c (do_start_initialization): Remove Python 2.4
4441         workaround.
4442         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4443         (print_children): Remove Python 2.4 workaround.
4444         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4445         workaround.
4446         (CHARBUFFERPROC_NAME): Remove.
4447         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4448         Python 2.4 workaround.
4449
4450 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4451
4452         * NEWS: Note minimum Python version.
4453
4454 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4455
4456         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4457         code from these functions.  Remove corresponding ifdefs.  Use
4458         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4459         Remove gotos and target of gotos.
4460         (infpy_search_memory): Likewise.
4461
4462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4463
4464         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4465         (hppa_gdbarch_init): Don't register deleted functions with
4466         gdbarch.
4467
4468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4471         (h8300_unwind_sp): Delete.
4472         (h8300_dummy_id): Delete.
4473         (h8300_gdbarch_init): Don't register deleted functions with
4474         gdbarch.
4475
4476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4479         (ft32_unwind_pc): Delete.
4480         (ft32_unwind_sp): Delete.
4481         (ft32_gdbarch_init): Don't register deleted functions with
4482         gdbarch.
4483
4484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4487         (frv_unwind_pc): Delete.
4488         (frv_unwind_sp): Delete.
4489         (frv_gdbarch_init): Don't register deleted functions with
4490         gdbarch.
4491
4492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4493
4494         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4495         (riscv_unwind_pc): Delete.
4496         (riscv_unwind_sp): Delete.
4497         (riscv_gdbarch_init): Don't register deleted functions with
4498         gdbarch.
4499
4500 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4503         (csky_unwind_pc): Delete.
4504         (csky_unwind_sp): Delete.
4505         (csky_gdbarch_init): Don't register deleted functions with
4506         gdbarch.
4507
4508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4511         (cris_unwind_pc): Delete.
4512         (cris_unwind_sp): Delete.
4513         (cris_gdbarch_init): Don't register deleted functions with
4514         gdbarch.
4515
4516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4519         (bfin_unwind_pc): Delete.
4520         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4521
4522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4525         (arm_unwind_pc): Delete.
4526         (arm_unwind_sp): Delete.
4527         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4528
4529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4532         (arc_unwind_pc): Delete.
4533         (arc_unwind_sp): Delete.
4534         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4535
4536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4539         (alpha_unwind_pc): Delete.
4540         (alpha_gdbarch_init): Don't register deleted functions with
4541         gdbarch.
4542
4543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4546         (aarch64_unwind_pc): Delete.
4547         (aarch64_unwind_sp): Delete.
4548         (aarch64_gdbarch_init): Don't register deleted functions with
4549         gdbarch.
4550
4551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * gdbtypes.c (type_align): Don't consider static members when
4554         computing structure alignment.
4555
4556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4559         return 0 for other types.
4560         * arch-utils.c (default_type_align): Always return 0.
4561         * gdbarch.h: Regenerate.
4562         * gdbarch.sh (type_align): Extend comment.
4563         * gdbtypes.c (type_align): Add additional comments, always call
4564         gdbarch_type_align before applying the default rules.
4565         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4566         generic code will then apply a suitable default.
4567         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4568         types, return 0 for other types.
4569
4570 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4571
4572         * NEWS: Create a new section for the next release branch.
4573         Rename the section of the current branch, now that it has
4574         been cut.
4575
4576 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4577
4578         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4579         * version.in: Bump version to 8.3.50.DATE-git.
4580
4581 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4582
4583         * aix-thread.c (ptid_cmp): Remove unused variable.
4584         (get_signaled_thread): Likewise.
4585         (store_regs_user_thread): Likewise.
4586         (store_regs_kernel_thread): Likewise.
4587         (fetch_regs_kernel_thread): Remove shadowed variable.
4588
4589 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * features/riscv/32bit-cpu.xml: Add register numbers.
4592         * features/riscv/32bit-fpu.c: Regenerate.
4593         * features/riscv/32bit-fpu.xml: Add register numbers.
4594         * features/riscv/64bit-cpu.xml: Add register numbers.
4595         * features/riscv/64bit-fpu.c: Regenerate.
4596         * features/riscv/64bit-fpu.xml: Add register numbers.
4597
4598 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4599
4600         * NEWS: Mention two argument form of gdb.Value constructor.
4601         * python/py-value.c (convert_buffer_and_type_to_value): New
4602         function.
4603         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4604         Add support for handling an optional second argument.  Call
4605         convert_buffer_and_type_to_value as appropriate.
4606         * python/python-internal.h (Py_buffer_deleter): New struct.
4607         (Py_buffer_up): New typedef.
4608
4609 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4610
4611         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4612         instead of releasing ownership.
4613
4614 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4615
4616         * dwarf2read.c (open_and_init_dwp_file): Call
4617         elf_numsections instead of bfd_count_sections to initialize
4618         dwp_file->num_sections.
4619
4620 2019-02-25  Tom Tromey  <tromey@adacore.com>
4621
4622         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4623
4624 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4625
4626         * gcore.in: Add '--readnever' option when invoking GDB.
4627
4628 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4629
4630         * MAINTAINERS: Update my email address.
4631
4632 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4633
4634         * build-id.c (build_id_to_debug_bfd_1): New function.
4635         (build_id_to_debug_bfd): Look for separate debug file in
4636         sysroot.
4637
4638 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * gdbarch.sh: Update the copyright year range that is placed into
4641         generated files.
4642
4643 2019-02-22  Keith Seitz  <keiths@redhat.com>
4644
4645         PR symtab/23853
4646         * linespec.c (create_sals_line_offset): Search for the default
4647         symtab's filename instead of its fullname.
4648
4649 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4650
4651         * NEWS: Update style defaults.
4652
4653 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4654
4655         * main.c (captured_main_1): Disable styling in batch mode.
4656
4657 2019-02-20  Tom Tromey  <tom@tromey.com>
4658
4659         * symtab.c (symtab_symbol_info): Fix typos.
4660
4661 2019-02-20  Tom Tromey  <tromey@adacore.com>
4662
4663         * findcmd.c (_initialize_mem_search): Use upper case for
4664         metasyntactic variables.
4665
4666 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4667
4668         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4669         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4670
4671 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4672
4673         * top.h (source_file_name): Change to std::string.
4674         * top.c (source_file_name): Likewise.
4675         (command_line_input): Adjust.
4676         * cli/cli-script.c (script_from_file): Adjust.
4677
4678 2019-02-19  Tom Tromey  <tromey@adacore.com>
4679
4680         * ravenscar-thread.c
4681         (ravenscar_thread_target::update_thread_list): Don't call
4682         ada_build_task_list.
4683         * ada-lang.h (ada_build_task_list): Don't declare.
4684         * ada-tasks.c (struct ada_tasks_inferior_data)
4685         <task_list_valid_p>: Now bool.
4686         (read_known_tasks, ada_task_list_changed)
4687         (ada_tasks_invalidate_inferior_data): Update.
4688         (read_known_tasks_array): Return bool.
4689         (read_known_tasks_list): Likewise.
4690         (read_known_tasks): Return void.
4691         (ada_build_task_list): Now static.
4692
4693 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4696         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4697
4698 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4699
4700         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4701         variant for ada_tasks_pspace_data_handle and
4702         ada_tasks_inferior_data_handle.
4703         (ada_tasks_pspace_data_cleanup): New function.
4704         (ada_tasks_inferior_data_cleanup): New function.
4705
4706 2019-02-17  Tom Tromey  <tom@tromey.com>
4707
4708         * macrotab.h (macro_source_fullname): Return a std::string.
4709         * macrotab.c (macro_include, check_for_redefinition)
4710         (macro_undef, macro_lookup_definition, foreach_macro)
4711         (foreach_macro_in_scope): Update.
4712         (macro_source_fullname): Return a std::string.
4713         * macrocmd.c (show_pp_source_pos): Update.
4714
4715 2019-02-17  Tom Tromey  <tom@tromey.com>
4716
4717         * macrocmd.c (show_pp_source_pos): Style the file names.
4718
4719 2019-02-17  Tom Tromey  <tom@tromey.com>
4720
4721         PR tui/24197:
4722         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4723
4724 2019-02-17  Tom Tromey  <tom@tromey.com>
4725
4726         * ada-lang.c (user_select_syms): Use filtered printing.
4727         * utils.c (wrap_style): New global.
4728         (desired_style): Remove.
4729         (emit_style_escape): Add stream parameter.
4730         (set_output_style, reset_terminal_style, prompt_for_continue):
4731         Update.
4732         (flush_wrap_buffer): Only flush gdb_stdout.
4733         (wrap_here): Set wrap_style.
4734         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4735         treat escape sequences as a character.  Change when wrap buffer is
4736         flushed.
4737         (fputs_styled): Do not set the output style when the default is
4738         requested.
4739         * ui-style.h (struct ui_file_style) <is_default>: New method.
4740         * source.c (print_source_lines_base): Emit escape sequences in one
4741         piece.
4742
4743 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4744
4745         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4746         integers and enumeration types.
4747
4748 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4749
4750         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4751         instead of lookup_symbol_in_language
4752         (do_exact_match): New function.
4753         (ada_get_symbol_name_matcher): Return do_exact_match when
4754         doing a verbatim match.
4755
4756 2019-02-15  Tom Tromey  <tromey@adacore.com>
4757
4758         * ravenscar-thread.c (ravenscar_thread_target::resume)
4759         (ravenscar_thread_target::wait): Special case wildcard requests.
4760
4761 2019-02-15  Tom Tromey  <tromey@adacore.com>
4762
4763         * ravenscar-thread.c (base_ptid): Remove.
4764         (struct ravenscar_thread_target) <close>: New method.
4765         <m_base_ptid>: New member.
4766         <update_inferior_ptid, active_task, task_is_currently_active,
4767         runtime_initialized>: Declare methods.
4768         <ravenscar_thread_target>: Add constructor.
4769         (ravenscar_thread_target::task_is_currently_active)
4770         (ravenscar_thread_target::update_inferior_ptid)
4771         (ravenscar_runtime_initialized): Rename.  Now methods.
4772         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4773         (ravenscar_thread_target::update_thread_list): Update.
4774         (ravenscar_thread_target::active_task): Now method.
4775         (ravenscar_thread_target::store_registers)
4776         (ravenscar_thread_target::prepare_to_store)
4777         (ravenscar_thread_target::prepare_to_store)
4778         (ravenscar_thread_target::mourn_inferior): Update.
4779         (ravenscar_inferior_created): Use "new" to create target.
4780         (ravenscar_thread_target::get_ada_task_ptid): Update.
4781         (_initialize_ravenscar): Don't initialize base_ptid.
4782         (ravenscar_ops): Remove global.
4783
4784 2019-02-15  Tom Tromey  <tromey@adacore.com>
4785
4786         * target.h (push_target): Declare new overload.
4787         * target.c (push_target): New overload, taking an rvalue reference.
4788         * remote.c (remote_target::open_1): Use push_target overload.
4789         * corelow.c (core_target_open): Use push_target overload.
4790
4791 2019-02-15  Tom Tromey  <tromey@adacore.com>
4792
4793         * ravenscar-thread.c (is_ravenscar_task)
4794         (ravenscar_task_is_currently_active): Return bool.
4795         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4796         (_initialize_ravenscar): Remove "(void)".
4797         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4798         Return bool.
4799
4800 2019-02-15  Tom Tromey  <tromey@adacore.com>
4801
4802         * ravenscar-thread.c (ravenscar_runtime_initializer)
4803         (has_ravenscar_runtime, get_running_thread_id)
4804         (ravenscar_thread_target::resume): Fix indentation.
4805
4806 2019-02-15  Tom Tromey  <tromey@adacore.com>
4807
4808         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4809         from ravenscar_arch_ops.
4810         (sparc_ravenscar_ops::fetch_registers)
4811         (sparc_ravenscar_ops::store_registers): Now methods.
4812         (sparc_ravenscar_prepare_to_store): Remove.
4813         (sparc_ravenscar_ops): Redefine.
4814         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4815         methods and destructor.  Remove members.
4816         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4817         (ravenscar_thread_target::store_registers)
4818         (ravenscar_thread_target::prepare_to_store): Update.
4819         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4820         Remove.
4821         (struct ppc_ravenscar_powerpc_ops): Derive from
4822         ravenscar_arch_ops.
4823         (ppc_ravenscar_powerpc_ops::fetch_registers)
4824         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4825         (ppc_ravenscar_powerpc_ops): Redefine.
4826         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4827         (ppc_ravenscar_e500_ops::fetch_registers)
4828         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4829         (ppc_ravenscar_e500_ops): Redefine.
4830         * aarch64-ravenscar-thread.c
4831         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4832         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4833         (aarch64_ravenscar_fetch_registers)
4834         (aarch64_ravenscar_store_registers): Now methods.
4835         (aarch64_ravenscar_ops): Redefine.
4836
4837 2019-02-15  Tom Tromey  <tromey@adacore.com>
4838
4839         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4840         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4841         (ravenscar_thread_target::stopped_by_watchpoint)
4842         (ravenscar_thread_target::stopped_data_address)
4843         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4844
4845 2019-02-15  Tom Tromey  <tromey@adacore.com>
4846
4847         * ravenscar-thread.c: Fix some typos.
4848
4849 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4850             Tom Tromey  <tromey@adacore.com>
4851
4852         * ada-lang.c (ada_exception_sal): Change addr_string to a
4853         std::string.
4854         (create_ada_exception_catchpoint): Update.
4855
4856 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4857             Tom Tromey  <tromey@adacore.com>
4858
4859         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4860         (bp_location_ops): Remove.
4861         (base_breakpoint_allocate_location): Update.
4862         (free_bp_location): Update.
4863         * ada-lang.c (class ada_catchpoint_location)
4864         <ada_catchpoint_location>: Remove ops parameter.
4865         (ada_catchpoint_location_dtor): Remove.
4866         (ada_catchpoint_location_ops): Remove.
4867         (allocate_location_exception): Update.
4868         * breakpoint.h (struct bp_location_ops): Remove.
4869         (class bp_location) <bp_location>: Remove bp_location_ops
4870         parameter.
4871         <~bp_location>: Add destructor.
4872         <ops>: Remove.
4873
4874 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4875             Pedro Alves  <palves@redhat.com>
4876
4877         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4878         'PATH_MAX'.
4879
4880 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4881             Samuel Thibault  <samuel.thibault@gnu.org>
4882             Thomas Schwinge  <thomas@codesourcery.com>
4883
4884         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4885         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4886
4887 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4888
4889         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4890         (check_empty): Use "const char *".
4891
4892         * gnu-nat.c (gnu_nat_target::detach): Instead of
4893         'detach_inferior (pid)' call
4894         'detach_inferior (find_inferior_pid (pid))'.
4895
4896         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4897         'nat/fork-inferior.o'.
4898         * gnu-nat.c: #include "nat/fork-inferior.h".
4899
4900         * gnu-nat.c (gnu_nat_target::detach): Instead of
4901         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4902         * gnu-nat.h: #include "inf-child.h".
4903         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4904         'i386_gnu_nat_target::fetch_registers'.
4905         (gnu_store_registers): Rename/move to
4906         'i386_gnu_nat_target::store_registers'.
4907
4908         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4909         * gnu-nat.h (mach_thread_info): New function.
4910         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4911
4912         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4913
4914 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4915
4916         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4917
4918 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4919
4920         * windows-nat.c (windows_add_thread): Add new parameter
4921         "main_thread_p" with default value set to false.  Update
4922         function documentation as well as all callers.
4923         (windows_delete_thread): Likewise.
4924         (fake_create_process): Update call to windows_add_thread.
4925         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4926         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4927         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4928         call to windows_delete_thread.
4929
4930 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4931
4932         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4933
4934 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4935
4936         * symfile.c (find_separate_debug_file): Use canonical path of
4937         sysroot with child_path instead of gdb_sysroot if it is valid.
4938
4939 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4940
4941         * symfile.c (find_separate_debug_file): Use child_path to
4942         determine if an object file is under a sysroot.
4943
4944 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4945
4946         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4947         unittests/child-path-selftests.c.
4948         * common/pathstuff.c (child_path): New function.
4949         * common/pathstuff.h (child_path): New prototype.
4950         * unittests/child-path-selftests.c: New file.
4951
4952 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4953
4954         * symfile.c (find_separate_debug_file): Look for separate debug
4955         files in debug directories under the sysroot.
4956
4957 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4958
4959         * symtab.h (struct minimal_symbol data_p): New const method.
4960         (struct minimal_symbol text_p): Likewise.
4961         * symtab.c (output_source_filename): Use file name style
4962         to print file name.
4963         (print_symbol_info): Likewise.
4964         (print_msymbol_info): Use address style to print addresses.
4965         Use function name style to print executable text symbols.
4966         (expand_symtab_containing_pc): Use data_p.
4967         (find_pc_sect_compunit_symtab): Likewise.
4968
4969 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4970
4971         * breakpoint.c (describe_other_breakpoints): Use address style
4972         to print addresses.
4973         (say_where): Likewise.
4974
4975 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4976
4977         * ada-typeprint.c (print_func_type): Print function name
4978         style to print function name.
4979         * c-typeprint.c (c_print_type_1): Likewise.
4980
4981 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4982
4983         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4984         for execve.
4985
4986 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4987
4988         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4989         type_stack.
4990
4991 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4992
4993         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4994         TYPE_CODE_REF types.
4995
4996 2019-02-08  Jim Wilson  <jimw@sifive.com>
4997
4998         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4999         (riscv_linux_fregset): New.
5000         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5001
5002 2019-02-07  Tom Tromey  <tom@tromey.com>
5003
5004         * thread.c (thread_cancel_execution_command): Update.
5005         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5006         methods.
5007         (struct thread_fsm_ops): Remove.
5008         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5009         (thread_fsm_should_stop, thread_fsm_return_value)
5010         (thread_fsm_set_finished, thread_fsm_finished_p)
5011         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5012         Don't declare.
5013         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5014         * infrun.c (clear_proceed_status_thread)
5015         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5016         (print_stop_event): Update.
5017         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5018         Add constructor.
5019         (step_command_fsm_ops): Remove.
5020         (new_step_command_fsm): Remove.
5021         (step_1): Update.
5022         (step_command_fsm::should_stop): Rename from
5023         step_command_fsm_should_stop.
5024         (step_command_fsm::clean_up): Rename from
5025         step_command_fsm_clean_up.
5026         (step_command_fsm::do_async_reply_reason): Rename from
5027         step_command_fsm_async_reply_reason.
5028         (struct until_next_fsm): Inherit from thread_fsm.  Add
5029         constructor.
5030         (until_next_fsm_ops): Remove.
5031         (new_until_next_fsm): Remove.
5032         (until_next_fsm::should_stop): Rename from
5033         until_next_fsm_should_stop.
5034         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5035         (until_next_fsm::do_async_reply_reason): Rename from
5036         until_next_fsm_async_reply_reason.
5037         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5038         constructor.  Change type of breakpoint.
5039         (finish_command_fsm_ops): Remove.
5040         (new_finish_command_fsm): Remove.
5041         (finish_command_fsm::should_stop): Rename from
5042         finish_command_fsm_should_stop.
5043         (finish_command_fsm::clean_up): Rename from
5044         finish_command_fsm_clean_up.
5045         (finish_command_fsm::return_value): Rename from
5046         finish_command_fsm_return_value.
5047         (finish_command_fsm::do_async_reply_reason): Rename from
5048         finish_command_fsm_async_reply_reason.
5049         (finish_command): Update.
5050         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5051         Add constructor.
5052         (call_thread_fsm_ops): Remove.
5053         (call_thread_fsm::call_thread_fsm): Rename from
5054         new_call_thread_fsm.
5055         (call_thread_fsm::should_stop): Rename from
5056         call_thread_fsm_should_stop.
5057         (call_thread_fsm::should_notify_stop): Rename from
5058         call_thread_fsm_should_notify_stop.
5059         (run_inferior_call, call_function_by_hand_dummy): Update.
5060         * cli/cli-interp.c (should_print_stop_to_console): Update.
5061         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5062         Add constructor.  Change type of location_breakpoint,
5063         caller_breakpoint.
5064         (until_break_fsm_ops): Remove.
5065         (new_until_break_fsm): Remove.
5066         (until_break_fsm::should_stop): Rename from
5067         until_break_fsm_should_stop.
5068         (until_break_fsm::clean_up): Rename from
5069         until_break_fsm_clean_up.
5070         (until_break_fsm::do_async_reply_reason): Rename from
5071         until_break_fsm_async_reply_reason.
5072         (until_break_command): Update.
5073         * thread-fsm.c: Remove.
5074         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5075
5076 2019-02-07  Tom Tromey  <tom@tromey.com>
5077
5078         * yy-remap.h: Add include guard.
5079         * xtensa-tdep.h: Add include guard.
5080         * xcoffread.h: Rename include guard.
5081         * varobj-iter.h: Add include guard.
5082         * tui/tui.h: Rename include guard.
5083         * tui/tui-winsource.h: Rename include guard.
5084         * tui/tui-wingeneral.h: Rename include guard.
5085         * tui/tui-windata.h: Rename include guard.
5086         * tui/tui-win.h: Rename include guard.
5087         * tui/tui-stack.h: Rename include guard.
5088         * tui/tui-source.h: Rename include guard.
5089         * tui/tui-regs.h: Rename include guard.
5090         * tui/tui-out.h: Rename include guard.
5091         * tui/tui-layout.h: Rename include guard.
5092         * tui/tui-io.h: Rename include guard.
5093         * tui/tui-hooks.h: Rename include guard.
5094         * tui/tui-file.h: Rename include guard.
5095         * tui/tui-disasm.h: Rename include guard.
5096         * tui/tui-data.h: Rename include guard.
5097         * tui/tui-command.h: Rename include guard.
5098         * tic6x-tdep.h: Add include guard.
5099         * target/waitstatus.h: Rename include guard.
5100         * target/wait.h: Rename include guard.
5101         * target/target.h: Rename include guard.
5102         * target/resume.h: Rename include guard.
5103         * target-float.h: Rename include guard.
5104         * stabsread.h: Add include guard.
5105         * rs6000-tdep.h: Add include guard.
5106         * riscv-fbsd-tdep.h: Add include guard.
5107         * regformats/regdef.h: Rename include guard.
5108         * record.h: Rename include guard.
5109         * python/python.h: Rename include guard.
5110         * python/python-internal.h: Rename include guard.
5111         * python/py-stopevent.h: Rename include guard.
5112         * python/py-ref.h: Rename include guard.
5113         * python/py-record.h: Rename include guard.
5114         * python/py-record-full.h: Rename include guard.
5115         * python/py-record-btrace.h: Rename include guard.
5116         * python/py-instruction.h: Rename include guard.
5117         * python/py-events.h: Rename include guard.
5118         * python/py-event.h: Rename include guard.
5119         * procfs.h: Add include guard.
5120         * proc-utils.h: Add include guard.
5121         * p-lang.h: Add include guard.
5122         * or1k-tdep.h: Rename include guard.
5123         * observable.h: Rename include guard.
5124         * nto-tdep.h: Rename include guard.
5125         * nat/x86-linux.h: Rename include guard.
5126         * nat/x86-linux-dregs.h: Rename include guard.
5127         * nat/x86-gcc-cpuid.h: Add include guard.
5128         * nat/x86-dregs.h: Rename include guard.
5129         * nat/x86-cpuid.h: Rename include guard.
5130         * nat/ppc-linux.h: Rename include guard.
5131         * nat/mips-linux-watch.h: Rename include guard.
5132         * nat/linux-waitpid.h: Rename include guard.
5133         * nat/linux-ptrace.h: Rename include guard.
5134         * nat/linux-procfs.h: Rename include guard.
5135         * nat/linux-osdata.h: Rename include guard.
5136         * nat/linux-nat.h: Rename include guard.
5137         * nat/linux-namespaces.h: Rename include guard.
5138         * nat/linux-btrace.h: Rename include guard.
5139         * nat/glibc_thread_db.h: Rename include guard.
5140         * nat/gdb_thread_db.h: Rename include guard.
5141         * nat/gdb_ptrace.h: Rename include guard.
5142         * nat/fork-inferior.h: Rename include guard.
5143         * nat/amd64-linux-siginfo.h: Rename include guard.
5144         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5145         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5146         * nat/aarch64-linux.h: Rename include guard.
5147         * nat/aarch64-linux-hw-point.h: Rename include guard.
5148         * mn10300-tdep.h: Add include guard.
5149         * mips-linux-tdep.h: Add include guard.
5150         * mi/mi-parse.h: Rename include guard.
5151         * mi/mi-out.h: Rename include guard.
5152         * mi/mi-main.h: Rename include guard.
5153         * mi/mi-interp.h: Rename include guard.
5154         * mi/mi-getopt.h: Rename include guard.
5155         * mi/mi-console.h: Rename include guard.
5156         * mi/mi-common.h: Rename include guard.
5157         * mi/mi-cmds.h: Rename include guard.
5158         * mi/mi-cmd-break.h: Rename include guard.
5159         * m2-lang.h: Add include guard.
5160         * location.h: Rename include guard.
5161         * linux-record.h: Rename include guard.
5162         * linux-nat.h: Add include guard.
5163         * linux-fork.h: Add include guard.
5164         * i386-darwin-tdep.h: Rename include guard.
5165         * hppa-linux-offsets.h: Add include guard.
5166         * guile/guile.h: Rename include guard.
5167         * guile/guile-internal.h: Rename include guard.
5168         * gnu-nat.h: Rename include guard.
5169         * gdb-stabs.h: Rename include guard.
5170         * frv-tdep.h: Add include guard.
5171         * f-lang.h: Add include guard.
5172         * event-loop.h: Add include guard.
5173         * darwin-nat.h: Rename include guard.
5174         * cp-abi.h: Rename include guard.
5175         * config/sparc/nm-sol2.h: Rename include guard.
5176         * config/nm-nto.h: Rename include guard.
5177         * config/nm-linux.h: Add include guard.
5178         * config/i386/nm-i386gnu.h: Rename include guard.
5179         * config/djgpp/nl_types.h: Rename include guard.
5180         * config/djgpp/langinfo.h: Rename include guard.
5181         * compile/gcc-cp-plugin.h: Add include guard.
5182         * compile/gcc-c-plugin.h: Add include guard.
5183         * compile/compile.h: Rename include guard.
5184         * compile/compile-object-run.h: Rename include guard.
5185         * compile/compile-object-load.h: Rename include guard.
5186         * compile/compile-internal.h: Rename include guard.
5187         * compile/compile-cplus.h: Rename include guard.
5188         * compile/compile-c.h: Rename include guard.
5189         * common/xml-utils.h: Rename include guard.
5190         * common/x86-xstate.h: Rename include guard.
5191         * common/version.h: Rename include guard.
5192         * common/vec.h: Rename include guard.
5193         * common/tdesc.h: Rename include guard.
5194         * common/selftest.h: Rename include guard.
5195         * common/scoped_restore.h: Rename include guard.
5196         * common/scoped_mmap.h: Rename include guard.
5197         * common/scoped_fd.h: Rename include guard.
5198         * common/safe-iterator.h: Rename include guard.
5199         * common/run-time-clock.h: Rename include guard.
5200         * common/refcounted-object.h: Rename include guard.
5201         * common/queue.h: Rename include guard.
5202         * common/ptid.h: Rename include guard.
5203         * common/print-utils.h: Rename include guard.
5204         * common/preprocessor.h: Rename include guard.
5205         * common/pathstuff.h: Rename include guard.
5206         * common/observable.h: Rename include guard.
5207         * common/netstuff.h: Rename include guard.
5208         * common/job-control.h: Rename include guard.
5209         * common/host-defs.h: Rename include guard.
5210         * common/gdb_wait.h: Rename include guard.
5211         * common/gdb_vecs.h: Rename include guard.
5212         * common/gdb_unlinker.h: Rename include guard.
5213         * common/gdb_unique_ptr.h: Rename include guard.
5214         * common/gdb_tilde_expand.h: Rename include guard.
5215         * common/gdb_sys_time.h: Rename include guard.
5216         * common/gdb_string_view.h: Rename include guard.
5217         * common/gdb_splay_tree.h: Rename include guard.
5218         * common/gdb_setjmp.h: Rename include guard.
5219         * common/gdb_ref_ptr.h: Rename include guard.
5220         * common/gdb_optional.h: Rename include guard.
5221         * common/gdb_locale.h: Rename include guard.
5222         * common/gdb_assert.h: Rename include guard.
5223         * common/filtered-iterator.h: Rename include guard.
5224         * common/filestuff.h: Rename include guard.
5225         * common/fileio.h: Rename include guard.
5226         * common/environ.h: Rename include guard.
5227         * common/common-utils.h: Rename include guard.
5228         * common/common-types.h: Rename include guard.
5229         * common/common-regcache.h: Rename include guard.
5230         * common/common-inferior.h: Rename include guard.
5231         * common/common-gdbthread.h: Rename include guard.
5232         * common/common-exceptions.h: Rename include guard.
5233         * common/common-defs.h: Rename include guard.
5234         * common/common-debug.h: Rename include guard.
5235         * common/cleanups.h: Rename include guard.
5236         * common/buffer.h: Rename include guard.
5237         * common/btrace-common.h: Rename include guard.
5238         * common/break-common.h: Rename include guard.
5239         * cli/cli-utils.h: Rename include guard.
5240         * cli/cli-style.h: Rename include guard.
5241         * cli/cli-setshow.h: Rename include guard.
5242         * cli/cli-script.h: Rename include guard.
5243         * cli/cli-interp.h: Rename include guard.
5244         * cli/cli-decode.h: Rename include guard.
5245         * cli/cli-cmds.h: Rename include guard.
5246         * charset-list.h: Add include guard.
5247         * buildsym-legacy.h: Rename include guard.
5248         * bfin-tdep.h: Add include guard.
5249         * ax.h: Rename include guard.
5250         * arm-linux-tdep.h: Add include guard.
5251         * arm-fbsd-tdep.h: Add include guard.
5252         * arch/xtensa.h: Rename include guard.
5253         * arch/tic6x.h: Add include guard.
5254         * arch/i386.h: Add include guard.
5255         * arch/arm.h: Rename include guard.
5256         * arch/arm-linux.h: Rename include guard.
5257         * arch/arm-get-next-pcs.h: Rename include guard.
5258         * arch/amd64.h: Add include guard.
5259         * arch/aarch64-insn.h: Rename include guard.
5260         * arch-utils.h: Rename include guard.
5261         * annotate.h: Add include guard.
5262         * amd64-darwin-tdep.h: Rename include guard.
5263         * aarch64-linux-tdep.h: Add include guard.
5264         * aarch64-fbsd-tdep.h: Add include guard.
5265         * aarch32-linux-nat.h: Add include guard.
5266
5267 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5268
5269         * macrotab.c (macro_define_internal): New function that
5270         factorizes macro_define_object_internal and macro_define_function
5271         code.
5272         (macro_define_object_internal): Use macro_define_internal.
5273         (macro_define_function): Likewise.
5274
5275 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5276
5277         * macrocmd.c (extract_identifier): Return
5278         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5279         callers.
5280
5281 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5282
5283         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5284
5285 2019-02-05  Tom Tromey  <tom@tromey.com>
5286
5287         * target.c (target_stack::unpush): Move assertion earlier.
5288
5289 2019-01-30  Tom Tromey  <tom@tromey.com>
5290
5291         PR python/23615:
5292         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5293         (gdbpy_parse_and_eval): Likewise.
5294         * python/python-internal.h (gdbpy_allow_threads): New class.
5295
5296 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5297
5298         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5299         (aarch64_fbsd_fpregmap): Move earlier.
5300         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5301         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5302         instead of individual calls to trad_frame_set_reg_addr.
5303         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5304         earlier.
5305         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5306         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5307         instead of individual calls to trad_frame_set_reg_addr.
5308
5309 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * CONTRIBUTE: Replace contribution list with wiki link.
5312
5313 2019-01-25  Tom Tromey  <tom@tromey.com>
5314
5315         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5316
5317 2019-01-25  Tom Tromey  <tom@tromey.com>
5318
5319         * xtensa-linux-nat.c: Fix common/ includes.
5320         * xml-support.h: Fix common/ includes.
5321         * xml-support.c: Fix common/ includes.
5322         * x86-linux-nat.c: Fix common/ includes.
5323         * windows-nat.c: Fix common/ includes.
5324         * varobj.h: Fix common/ includes.
5325         * varobj.c: Fix common/ includes.
5326         * value.c: Fix common/ includes.
5327         * valops.c: Fix common/ includes.
5328         * utils.c: Fix common/ includes.
5329         * unittests/xml-utils-selftests.c: Fix common/ includes.
5330         * unittests/utils-selftests.c: Fix common/ includes.
5331         * unittests/unpack-selftests.c: Fix common/ includes.
5332         * unittests/tracepoint-selftests.c: Fix common/ includes.
5333         * unittests/style-selftests.c: Fix common/ includes.
5334         * unittests/string_view-selftests.c: Fix common/ includes.
5335         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5336         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5337         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5338         * unittests/rsp-low-selftests.c: Fix common/ includes.
5339         * unittests/parse-connection-spec-selftests.c: Fix common/
5340         includes.
5341         * unittests/optional-selftests.c: Fix common/ includes.
5342         * unittests/offset-type-selftests.c: Fix common/ includes.
5343         * unittests/observable-selftests.c: Fix common/ includes.
5344         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5345         * unittests/memrange-selftests.c: Fix common/ includes.
5346         * unittests/memory-map-selftests.c: Fix common/ includes.
5347         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5348         * unittests/function-view-selftests.c: Fix common/ includes.
5349         * unittests/environ-selftests.c: Fix common/ includes.
5350         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5351         * unittests/common-utils-selftests.c: Fix common/ includes.
5352         * unittests/cli-utils-selftests.c: Fix common/ includes.
5353         * unittests/array-view-selftests.c: Fix common/ includes.
5354         * ui-file.c: Fix common/ includes.
5355         * tui/tui-io.c: Fix common/ includes.
5356         * tracepoint.h: Fix common/ includes.
5357         * tracepoint.c: Fix common/ includes.
5358         * tracefile-tfile.c: Fix common/ includes.
5359         * top.h: Fix common/ includes.
5360         * top.c: Fix common/ includes.
5361         * thread.c: Fix common/ includes.
5362         * target/waitstatus.h: Fix common/ includes.
5363         * target/waitstatus.c: Fix common/ includes.
5364         * target.h: Fix common/ includes.
5365         * target.c: Fix common/ includes.
5366         * target-memory.c: Fix common/ includes.
5367         * target-descriptions.c: Fix common/ includes.
5368         * symtab.h: Fix common/ includes.
5369         * symfile.c: Fix common/ includes.
5370         * stap-probe.c: Fix common/ includes.
5371         * spu-linux-nat.c: Fix common/ includes.
5372         * sparc-nat.c: Fix common/ includes.
5373         * source.c: Fix common/ includes.
5374         * solib.c: Fix common/ includes.
5375         * solib-target.c: Fix common/ includes.
5376         * ser-unix.c: Fix common/ includes.
5377         * ser-tcp.c: Fix common/ includes.
5378         * ser-pipe.c: Fix common/ includes.
5379         * ser-base.c: Fix common/ includes.
5380         * selftest-arch.c: Fix common/ includes.
5381         * s12z-tdep.c: Fix common/ includes.
5382         * rust-exp.y: Fix common/ includes.
5383         * rs6000-aix-tdep.c: Fix common/ includes.
5384         * riscv-tdep.c: Fix common/ includes.
5385         * remote.c: Fix common/ includes.
5386         * remote-notif.h: Fix common/ includes.
5387         * remote-fileio.h: Fix common/ includes.
5388         * remote-fileio.c: Fix common/ includes.
5389         * regcache.h: Fix common/ includes.
5390         * regcache.c: Fix common/ includes.
5391         * record-btrace.c: Fix common/ includes.
5392         * python/python.c: Fix common/ includes.
5393         * python/py-type.c: Fix common/ includes.
5394         * python/py-inferior.c: Fix common/ includes.
5395         * progspace.h: Fix common/ includes.
5396         * producer.c: Fix common/ includes.
5397         * procfs.c: Fix common/ includes.
5398         * proc-api.c: Fix common/ includes.
5399         * printcmd.c: Fix common/ includes.
5400         * ppc-linux-nat.c: Fix common/ includes.
5401         * parser-defs.h: Fix common/ includes.
5402         * osdata.c: Fix common/ includes.
5403         * obsd-nat.c: Fix common/ includes.
5404         * nat/x86-linux.c: Fix common/ includes.
5405         * nat/x86-linux-dregs.c: Fix common/ includes.
5406         * nat/x86-dregs.h: Fix common/ includes.
5407         * nat/x86-dregs.c: Fix common/ includes.
5408         * nat/ppc-linux.c: Fix common/ includes.
5409         * nat/mips-linux-watch.h: Fix common/ includes.
5410         * nat/mips-linux-watch.c: Fix common/ includes.
5411         * nat/linux-waitpid.c: Fix common/ includes.
5412         * nat/linux-ptrace.h: Fix common/ includes.
5413         * nat/linux-ptrace.c: Fix common/ includes.
5414         * nat/linux-procfs.c: Fix common/ includes.
5415         * nat/linux-personality.c: Fix common/ includes.
5416         * nat/linux-osdata.c: Fix common/ includes.
5417         * nat/linux-namespaces.c: Fix common/ includes.
5418         * nat/linux-btrace.h: Fix common/ includes.
5419         * nat/linux-btrace.c: Fix common/ includes.
5420         * nat/fork-inferior.c: Fix common/ includes.
5421         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5422         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5423         * nat/aarch64-linux.c: Fix common/ includes.
5424         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5425         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5426         * namespace.h: Fix common/ includes.
5427         * mips-linux-tdep.c: Fix common/ includes.
5428         * minsyms.c: Fix common/ includes.
5429         * mi/mi-parse.h: Fix common/ includes.
5430         * mi/mi-main.c: Fix common/ includes.
5431         * mi/mi-cmd-env.c: Fix common/ includes.
5432         * memrange.h: Fix common/ includes.
5433         * memattr.c: Fix common/ includes.
5434         * maint.h: Fix common/ includes.
5435         * maint.c: Fix common/ includes.
5436         * main.c: Fix common/ includes.
5437         * machoread.c: Fix common/ includes.
5438         * location.c: Fix common/ includes.
5439         * linux-thread-db.c: Fix common/ includes.
5440         * linux-nat.c: Fix common/ includes.
5441         * linux-fork.c: Fix common/ includes.
5442         * inline-frame.c: Fix common/ includes.
5443         * infrun.c: Fix common/ includes.
5444         * inflow.c: Fix common/ includes.
5445         * inferior.h: Fix common/ includes.
5446         * inferior.c: Fix common/ includes.
5447         * infcmd.c: Fix common/ includes.
5448         * inf-ptrace.c: Fix common/ includes.
5449         * inf-child.c: Fix common/ includes.
5450         * ia64-linux-nat.c: Fix common/ includes.
5451         * i387-tdep.c: Fix common/ includes.
5452         * i386-tdep.c: Fix common/ includes.
5453         * i386-linux-tdep.c: Fix common/ includes.
5454         * i386-linux-nat.c: Fix common/ includes.
5455         * i386-go32-tdep.c: Fix common/ includes.
5456         * i386-fbsd-tdep.c: Fix common/ includes.
5457         * i386-fbsd-nat.c: Fix common/ includes.
5458         * guile/scm-type.c: Fix common/ includes.
5459         * guile/guile.c: Fix common/ includes.
5460         * go32-nat.c: Fix common/ includes.
5461         * gnu-nat.c: Fix common/ includes.
5462         * gdbthread.h: Fix common/ includes.
5463         * gdbarch-selftests.c: Fix common/ includes.
5464         * gdb_usleep.c: Fix common/ includes.
5465         * gdb_select.h: Fix common/ includes.
5466         * gdb_bfd.c: Fix common/ includes.
5467         * gcore.c: Fix common/ includes.
5468         * fork-child.c: Fix common/ includes.
5469         * findvar.c: Fix common/ includes.
5470         * fbsd-nat.c: Fix common/ includes.
5471         * event-top.c: Fix common/ includes.
5472         * event-loop.c: Fix common/ includes.
5473         * dwarf2read.c: Fix common/ includes.
5474         * dwarf2loc.c: Fix common/ includes.
5475         * dwarf2-frame.c: Fix common/ includes.
5476         * dwarf-index-cache.c: Fix common/ includes.
5477         * dtrace-probe.c: Fix common/ includes.
5478         * disasm-selftests.c: Fix common/ includes.
5479         * defs.h: Fix common/ includes.
5480         * csky-tdep.c: Fix common/ includes.
5481         * cp-valprint.c: Fix common/ includes.
5482         * cp-support.h: Fix common/ includes.
5483         * cp-support.c: Fix common/ includes.
5484         * corelow.c: Fix common/ includes.
5485         * completer.h: Fix common/ includes.
5486         * completer.c: Fix common/ includes.
5487         * compile/compile.c: Fix common/ includes.
5488         * compile/compile-loc2c.c: Fix common/ includes.
5489         * compile/compile-cplus-types.c: Fix common/ includes.
5490         * compile/compile-cplus-symbols.c: Fix common/ includes.
5491         * command.h: Fix common/ includes.
5492         * cli/cli-dump.c: Fix common/ includes.
5493         * cli/cli-cmds.c: Fix common/ includes.
5494         * charset.c: Fix common/ includes.
5495         * build-id.c: Fix common/ includes.
5496         * btrace.h: Fix common/ includes.
5497         * btrace.c: Fix common/ includes.
5498         * breakpoint.h: Fix common/ includes.
5499         * breakpoint.c: Fix common/ includes.
5500         * ax.h:
5501         (enum agent_op): Fix common/ includes.
5502         * ax-general.c (struct aop_map): Fix common/ includes.
5503         * ax-gdb.c: Fix common/ includes.
5504         * auxv.c: Fix common/ includes.
5505         * auto-load.c: Fix common/ includes.
5506         * arm-tdep.c: Fix common/ includes.
5507         * arch/riscv.c: Fix common/ includes.
5508         * arch/ppc-linux-common.c: Fix common/ includes.
5509         * arch/i386.c: Fix common/ includes.
5510         * arch/arm.c: Fix common/ includes.
5511         * arch/arm-linux.c: Fix common/ includes.
5512         * arch/arm-get-next-pcs.c: Fix common/ includes.
5513         * arch/amd64.c: Fix common/ includes.
5514         * arch/aarch64.c: Fix common/ includes.
5515         * arch/aarch64-insn.c: Fix common/ includes.
5516         * arch-utils.c: Fix common/ includes.
5517         * amd64-windows-tdep.c: Fix common/ includes.
5518         * amd64-tdep.c: Fix common/ includes.
5519         * amd64-sol2-tdep.c: Fix common/ includes.
5520         * amd64-obsd-tdep.c: Fix common/ includes.
5521         * amd64-nbsd-tdep.c: Fix common/ includes.
5522         * amd64-linux-tdep.c: Fix common/ includes.
5523         * amd64-linux-nat.c: Fix common/ includes.
5524         * amd64-fbsd-tdep.c: Fix common/ includes.
5525         * amd64-fbsd-nat.c: Fix common/ includes.
5526         * amd64-dicos-tdep.c: Fix common/ includes.
5527         * amd64-darwin-tdep.c: Fix common/ includes.
5528         * agent.c: Fix common/ includes.
5529         * ada-lang.h: Fix common/ includes.
5530         * ada-lang.c: Fix common/ includes.
5531         * aarch64-tdep.c: Fix common/ includes.
5532
5533 2019-01-25  Tom Tromey  <tom@tromey.com>
5534
5535         * common/create-version.sh: Use common/version.h.
5536
5537 2019-01-24  Pedro Alves  <palves@redhat.com>
5538
5539         * infrun.c (signal_stop, signal_print, signal_program)
5540         (signal_catch, signal_pass): Now arrays instead of pointers.
5541         (update_signals_program_target, do_target_resume)
5542         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5543         * linux-nat.c (linux_nat_target::pass_signals)
5544         (linux_nat_target::create_inferior, linux_nat_target::attach):
5545         Adjust.
5546         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5547         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5548         * procfs.c (procfs_target::pass_signals): Adjust.
5549         * record-full.c (record_full_target::resume): Adjust.
5550         * remote.c (remote_target::pass_signals)
5551         (remote_target::program_signals): Adjust.
5552         * target-debug.h (target_debug_print_signals): Now takes a
5553         gdb::array_view as parameter.  Adjust.
5554         * target.h (target_ops) <pass_signals, program_signals>: Replace
5555         pointer and length parameters with gdb::array_view.
5556         (target_pass_signals, target_program_signals): Likewise.
5557         * target-delegates.c: Regenerate.
5558
5559 2019-01-24  Pedro Alves  <palves@redhat.com>
5560
5561         * common/forward-scope-exit.h
5562         (forward_scope_exit::forward_scope_exit): Pass arguments to
5563         m_bind_function directly, instead of creating a std::bind and
5564         copying that.
5565
5566 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5567
5568         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5569         for static members.
5570         (pass_in_v_vfp_candidate): Likewise.
5571
5572 2019-01-23  Tom Tromey  <tom@tromey.com>
5573             Pedro Alves  <palves@redhat.com>
5574
5575         * regcache.c (class regcache_invalidator): Remove.
5576         (regcache::raw_write): Use make_scope_exit.
5577
5578 2019-01-23  Tom Tromey  <tom@tromey.com>
5579
5580         * ui-out.h (class ui_out_emit_type): Update comment.
5581
5582 2019-01-23  Tom Tromey  <tom@tromey.com>
5583
5584         * infrun.c (fetch_inferior_event): Update comment.
5585
5586 2019-01-23  Tom Tromey  <tom@tromey.com>
5587             Pedro Alves  <palves@redhat.com>
5588
5589         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5590         parameter.
5591         (fetch_inferior_event): Use SCOPE_EXIT.
5592
5593
5594 2019-01-23  Tom Tromey  <tom@tromey.com>
5595             Pedro Alves  <palves@redhat.com>
5596
5597         * infrun.c (disable_thread_events): Delete.
5598         (stop_all_threads): Use SCOPE_EXIT.
5599
5600 2019-01-23  Tom Tromey  <tom@tromey.com>
5601             Pedro Alves  <palves@redhat.com>
5602
5603         * symfile.c: Include forward-scope-exit.h.
5604         (clear_symtab_users_cleanup): Replace forward declaration with
5605         a FORWARD_SCOPE_EXIT.
5606         (syms_from_objfile_1): Use the forward_scope_exit and
5607         gdb::optional instead of cleanup_function.
5608         (reread_symbols): Use the forward_scope_exit instead of
5609         cleanup_function.
5610         (clear_symtab_users_cleanup): Remove function.
5611
5612 2019-01-23  Tom Tromey  <tom@tromey.com>
5613             Pedro Alves  <palves@redhat.com>
5614
5615         * linux-nat.c: Include scope-exit.h.
5616         (cleanup_target_stop): Remove.
5617         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5618         SCOPE_EXIT.
5619
5620 2019-01-23  Tom Tromey  <tom@tromey.com>
5621             Pedro Alves  <palves@redhat.com>
5622
5623         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5624         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5625
5626 2019-01-23  Tom Tromey  <tom@tromey.com>
5627             Andrew Burgess  <andrew.burgess@embecosm.com>
5628             Pedro Alves  <palves@redhat.com>
5629
5630         * infrun.c (fetch_inferior_event): Use scope_exit.
5631         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5632         * top.c (execute_command): Use scope_exit.
5633         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5634         * utils.c (do_bpstat_clear_actions_cleanup)
5635         (make_bpstat_clear_actions_cleanup): Remove.
5636
5637 2019-01-23  Tom Tromey  <tom@tromey.com>
5638             Pedro Alves  <palves@redhat.com>
5639
5640         * infrun.c: Include "common/scope-exit.h"
5641         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5642         (wait_for_inferior): Use SCOPE_EXIT.
5643         (fetch_inferior_event): Use scope_exit.
5644
5645 2019-01-23  Tom Tromey  <tom@tromey.com>
5646             Pedro Alves  <palves@redhat.com>
5647
5648         * breakpoint.c (create_breakpoint): Remove cleanup.
5649
5650 2019-01-23  Tom Tromey  <tom@tromey.com>
5651             Andrew Burgess  <andrew.burgess@embecosm.com>
5652             Pedro Alves  <palves@redhat.com>
5653
5654 2019-01-23  Pedro Alves  <palves@redhat.com>
5655
5656         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5657
5658 2019-01-23  Pedro Alves  <palves@redhat.com>
5659             Andrew Burgess  <andrew.burgess@embecosm.com>
5660
5661         * gdbthread.h: Include "common/forward-scope-exit.h".
5662         (scoped_finish_thread_state): Redefine custom class in terms of
5663         forward_scope_exit.
5664
5665 2019-01-23  Pedro Alves  <palves@redhat.com>
5666             Andrew Burgess  <andrew.burgess@embecosm.com>
5667
5668         * common/forward-scope-exit.h: New file.
5669
5670 2019-01-23  Pedro Alves  <palves@redhat.com>
5671             Andrew Burgess  <andrew.burgess@embecosm.com>
5672             Tom Tromey  <tom@tromey.com>
5673
5674         * common/scope-exit.h: New file.
5675
5676 2019-01-23  Pedro Alves  <palves@redhat.com>
5677
5678         * common/preprocessor.h (ESC): Rename to ...
5679         (ESC_PARENS): ... this.
5680         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5681         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5682
5683 2019-01-23  Tom Tromey  <tom@tromey.com>
5684
5685         * language.h (class scoped_switch_to_sym_language_if_auto):
5686         Initialize m_lang in both cases.
5687
5688 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5689
5690         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5691         with XCNEW.
5692
5693 2019-01-22  Tom Tromey  <tom@tromey.com>
5694
5695         * corelow.c: Do not include sys/file.h.
5696
5697 2019-01-22  Tom Tromey  <tom@tromey.com>
5698
5699         * tui/tui-wingeneral.h: Include gdb_curses.h.
5700
5701 2019-01-22  Tom Tromey  <tom@tromey.com>
5702
5703         * source-cache.h (class source_cache) <get_source_lines,
5704         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5705
5706 2019-01-22  Tom Tromey  <tom@tromey.com>
5707
5708         * remote-fileio.h (struct remote_target): Declare.
5709
5710 2019-01-22  Tom Tromey  <tom@tromey.com>
5711
5712         * python/py-arch.c: Do not include py-ref.h.
5713         * python/py-bpevent.c: Do not include py-ref.h.
5714         * python/py-cmd.c: Do not include py-ref.h.
5715         * python/py-continueevent.c: Do not include py-ref.h.
5716         * python/py-event.h: Do not include py-ref.h.
5717         * python/py-evtregistry.c: Do not include py-ref.h.
5718         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5719         * python/py-frame.c: Do not include py-ref.h.
5720         * python/py-framefilter.c: Do not include py-ref.h.
5721         * python/py-function.c: Do not include py-ref.h.
5722         * python/py-infevents.c: Do not include py-ref.h.
5723         * python/py-linetable.c: Do not include py-ref.h.
5724         * python/py-objfile.c: Do not include py-ref.h.
5725         * python/py-param.c: Do not include py-ref.h.
5726         * python/py-prettyprint.c: Do not include py-ref.h.
5727         * python/py-progspace.c: Do not include py-ref.h.
5728         * python/py-symbol.c: Do not include py-ref.h.
5729         * python/py-symtab.c: Do not include py-ref.h.
5730         * python/py-type.c: Do not include py-ref.h.
5731         * python/py-unwind.c: Do not include py-ref.h.
5732         * python/py-utils.c: Do not include py-ref.h.
5733         * python/py-value.c: Do not include py-ref.h.
5734         * python/py-varobj.c: Do not include py-ref.h.
5735         * python/py-xmethods.c: Do not include py-ref.h.
5736         * python/python.c: Do not include py-ref.h.
5737         * varobj.c: Do not include py-ref.h.
5738
5739 2019-01-22  Tom Tromey  <tom@tromey.com>
5740
5741         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5742         keyword for bcache.
5743
5744 2019-01-22  Tom Tromey  <tom@tromey.com>
5745
5746         * compile/compile-cplus-types.c: Remove a comment by #include.
5747
5748 2019-01-22  Tom Tromey  <tom@tromey.com>
5749
5750         * compile/gcc-c-plugin.h: Include compile-internal.h.
5751
5752 2019-01-22  Tom Tromey  <tom@tromey.com>
5753
5754         * stabsread.c (EXTERN): Do not define.
5755         (symnum, next_symbol_text_func, processing_gcc_compilation)
5756         (within_function, global_sym_chain, global_stabs)
5757         (previous_stab_code, this_object_header_files)
5758         (n_this_object_header_files)
5759         (n_allocated_this_object_header_files): Define.
5760         * stabsread.h (EXTERN): Never define.  Use "extern".
5761
5762 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5763
5764         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5765         history_value.
5766
5767 2019-01-21  Tom Tromey  <tom@tromey.com>
5768
5769         * ui-out.c: Fix includes.
5770         * tui/tui-source.c: Fix includes.
5771         * target.c: Fix includes.
5772         * remote.c: Fix includes.
5773         * regcache.c: Fix includes.
5774         * python/py-block.c: Fix includes.
5775         * printcmd.c: Fix includes.
5776         * or1k-tdep.c: Fix includes.
5777         * mi/mi-main.c: Fix includes.
5778         * m32r-tdep.c: Fix includes.
5779         * csky-tdep.c: Fix includes.
5780         * compile/compile-cplus-types.c: Fix includes.
5781         * cli/cli-interp.c: Fix includes.
5782
5783 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5784
5785         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5786         for padding.
5787
5788 2019-01-16  Tom Tromey  <tom@tromey.com>
5789
5790         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5791         earlier.
5792         (struct objfile) <msymbols_range>: Move from top level.
5793         <msymbols>: New method.
5794         (class objfile_msymbols): Remove.
5795         * symtab.c (default_collect_symbol_completion_matches_break_on):
5796         Update.
5797         * symmisc.c (dump_msymbols): Update.
5798         * stabsread.c (scan_file_globals): Update.
5799         * objc-lang.c (info_selectors_command, info_classes_command)
5800         (find_methods): Update.
5801         * minsyms.c (find_solib_trampoline_target): Update.
5802         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5803         * coffread.c (coff_symfile_read): Update.
5804         * ada-lang.c (ada_lookup_simple_minsym)
5805         (ada_collect_symbol_completion_matches): Update.
5806
5807 2019-01-16  Tom Tromey  <tom@tromey.com>
5808
5809         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5810         type.  Remove no-argument constructor.
5811         <iterator::operator++>: Simplify.
5812         <begin>: Update.
5813         <end>: Use minimal_symbol_count.
5814
5815 2019-01-16  Tom Tromey  <tom@tromey.com>
5816
5817         * objfiles.h (struct objfile) <psymtabs>: New method.
5818         (class objfile_psymtabs): Remove.
5819         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5820         typedef.
5821         <range>: New method.
5822         (require_partial_symbols): Change return type.
5823         * psymtab.c (require_partial_symbols)
5824         (psym_expand_symtabs_matching): Update.
5825         * mdebugread.c (parse_partial_symbols): Update.
5826         * dbxread.c (dbx_end_psymtab): Update.
5827
5828 2019-01-15  Tom Tromey  <tom@tromey.com>
5829
5830         * symtab.c (lookup_objfile_from_block)
5831         (lookup_symbol_in_objfile_symtabs)
5832         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5833         (find_line_symtab, info_sources_command)
5834         (default_collect_symbol_completion_matches_break_on)
5835         (make_source_files_completion_list): Update.
5836         * symmisc.c (print_objfile_statistics, dump_objfile)
5837         (maintenance_print_symbols, maintenance_info_symtabs)
5838         (maintenance_check_symtabs, maintenance_info_line_tables):
5839         Update.
5840         * source.c (select_source_symtab)
5841         (forget_cached_source_info_for_objfile): Update.
5842         * objfiles.h (class objfile_compunits): Remove.
5843         (struct objfile) <compunits_range>: New typedef.
5844         (compunits): New method.
5845         * objfiles.c (objfile_relocate1): Update.
5846         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5847         * maint.c (count_symtabs_and_blocks): Update.
5848         * linespec.c (iterate_over_all_matching_symtabs): Update.
5849         * cp-support.c (add_symbol_overload_list_qualified): Update.
5850         * coffread.c (coff_symtab_read): Update.
5851         * ada-lang.c (add_nonlocal_symbols)
5852         (ada_collect_symbol_completion_matches)
5853         (ada_add_global_exceptions): Update.
5854
5855 2019-01-15  Tom Tromey  <tom@tromey.com>
5856
5857         * progspace.h (program_space) <objfiles_safe_range>: New
5858         typedef.
5859         <objfiles_safe>: New method.
5860         * objfiles.h (class all_objfiles_safe): Remove.
5861         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5862         * jit.c (jit_inferior_exit_hook): Update.
5863
5864 2019-01-17  Tom Tromey  <tom@tromey.com>
5865
5866         * progspace.h (program_space) <objfiles_range>: New typedef.
5867         <objfiles>: New method.
5868         <objfiles_head>: Rename from objfiles.
5869         (object_files): Update.
5870         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5871         * guile/scm-pretty-print.c
5872         (ppscm_find_pretty_printer_from_objfiles): Update.
5873         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5874         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5875         Update.
5876         * python/py-progspace.c (pspy_get_objfiles): Update.
5877         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5878         Update.
5879         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5880         (objfpy_lookup_objfile_by_build_id): Update.
5881         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5882         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5883         Update.
5884         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5885         (expand_symtab_containing_pc, lookup_objfile_from_block)
5886         (lookup_static_symbol, basic_lookup_transparent_type)
5887         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5888         (find_line_symtab, info_sources_command)
5889         (default_collect_symbol_completion_matches_break_on)
5890         (make_source_files_completion_list, find_main_name): Update.
5891         * symmisc.c (print_symbol_bcache_statistics)
5892         (print_objfile_statistics, maintenance_print_symbols)
5893         (maintenance_print_msymbols, maintenance_print_objfiles)
5894         (maintenance_info_symtabs, maintenance_check_symtabs)
5895         (maintenance_expand_symtabs, maintenance_info_line_tables):
5896         Update.
5897         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5898         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5899         (map_overlay_command, unmap_overlay_command)
5900         (simple_overlay_update, expand_symtabs_matching)
5901         (map_symbol_filenames): Update.
5902         * symfile-debug.c (set_debug_symfile): Update.
5903         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5904         Update.
5905         * source.c (select_source_symtab, forget_cached_source_info):
5906         Update.
5907         * solib.c (solib_read_symbols): Update.
5908         * solib-spu.c (append_ocl_sos): Update.
5909         * psymtab.c (maintenance_print_psymbols)
5910         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5911         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5912         * printcmd.c (info_symbol_command): Update.
5913         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5914         Update.
5915         * objfiles.h (class all_objfiles): Remove.
5916         * objfiles.c (have_partial_symbols, have_full_symbols)
5917         (have_minimal_symbols, qsort_cmp, update_section_map)
5918         (shared_objfile_contains_address_p)
5919         (default_iterate_over_objfiles_in_search_order): Update.
5920         * objc-lang.c (info_selectors_command, info_classes_command)
5921         (find_methods): Update.
5922         * minsyms.c (find_solib_trampoline_target): Update.
5923         * maint.c (maintenance_info_sections)
5924         (maintenance_translate_address, count_symtabs_and_blocks):
5925         Update.
5926         * main.c (captured_main_1): Update.
5927         * linux-thread-db.c (try_thread_db_load_from_pdir)
5928         (has_libpthread): Update.
5929         * linespec.c (iterate_over_all_matching_symtabs)
5930         (search_minsyms_for_name): Update.
5931         * jit.c (jit_find_objf_with_entry_addr): Update.
5932         * hppa-tdep.c (find_unwind_entry)
5933         (hppa_lookup_stub_minimal_symbol): Update.
5934         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5935         Update.
5936         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5937         (elf_gnu_ifunc_resolve_by_got): Update.
5938         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5939         * dwarf-index-write.c (save_gdb_index_command): Update.
5940         * cp-support.c (add_symbol_overload_list_qualified): Update.
5941         * breakpoint.c (create_overlay_event_breakpoint)
5942         (create_longjmp_master_breakpoint)
5943         (create_std_terminate_master_breakpoint)
5944         (create_exception_master_breakpoint): Update.
5945         * blockframe.c (find_pc_partial_function): Update.
5946         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5947         (ada_collect_symbol_completion_matches)
5948         (ada_add_global_exceptions): Update.
5949
5950 2019-01-17  Tom Tromey  <tom@tromey.com>
5951
5952         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5953         declare VEC.
5954         (solib_target_parse_libraries): Change return type.
5955         (library_list_start_segment, library_list_start_section)
5956         (library_list_end_library, library_list_start_library); Update.
5957         (solib_target_free_library_list): Remove.
5958         (solib_target_parse_libraries): Remove cleanup.  Change return
5959         type.
5960         (solib_target_current_sos): Update.
5961
5962 2019-01-17  Tom Tromey  <tromey@bapiya>
5963
5964         * valprint.c: Replace "the the" with "the".
5965         * symtab.c: Replace "the the" with "the".
5966         * solib.c: Replace "the the" with "the".
5967         * solib-dsbt.c: Replace "the the" with "the".
5968         * linespec.c: Replace "the the" with "the".
5969         * dwarf2loc.h: Replace "the the" with "the".
5970         * amd64-windows-tdep.c: Replace "the the" with "the".
5971         * aarch64-tdep.c: Replace "the the" with "the".
5972
5973 2019-01-16  Keith Seitz  <keiths@redhat.com>
5974
5975         PR gdb/23773
5976         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5977         <builder>: Rename to ..
5978         <m_builder>: ... this and make private.
5979         (dwarf2_cu::get_builder): New method.  Change all users of
5980         `builder' to use this method.
5981         (dwarf2_start_symtab): Move to ...
5982         (dwarf2_cu::start_symtab): ... here.  Update all callers
5983         (setup_type_unit_groups): Move to ...
5984         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5985         callers.
5986         (dwarf2_cu::reset_builder): New method.
5987         (process_full_compunit, process_full_type_unit): Use
5988         dwarf2_cu::reset_builder.
5989         (follow_die_offset): Record the ancestor CU if it is different
5990         from the followed DIE's CU.
5991         (follow_die_sig_1): Likewise.
5992
5993 2019-01-15  Tom Tromey  <tom@tromey.com>
5994
5995         * remote.c (class remote_state) <buf>: Now a char_vector.
5996         <buf_size>: Remove.
5997         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5998         parameter.
5999         (remote_target::getpkt_or_notif_sane_1)
6000         (remote_target::getpkt_sane)
6001         (remote_target::getpkt_or_notif_sane): Likewise.
6002         (class remote_target) <putpkt>: New overload.
6003         (remote_target::read_frame): Change type of "buf_p".  Remove
6004         sizeof_p parameter.
6005         (packet_ok): New overload.
6006         (packet_check_result): New overload.
6007         Update all uses.
6008
6009 2019-01-14  Tom Tromey  <tom@tromey.com>
6010
6011         * remote-notif.c (handle_notification, remote_notif_ack)
6012         (remote_notif_parse): Make "buf" const.
6013         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6014         const.
6015         (remote_notif_parse, remote_notif_ack, handle_notification):
6016         Likewise.
6017         * remote.c (remote_notif_stop_parse): Make "buf" const.
6018         (remote_target::remote_parse_stop_reply): Make "buf" const.
6019         (remote_notif_stop_ack): Make "buf" const.
6020
6021 2019-01-14  Tom Tromey  <tom@tromey.com>
6022
6023         * remote.c (remote_console_output): Make parameter const.
6024
6025 2019-01-14  Tom Tromey  <tom@tromey.com>
6026
6027         * target-debug.h (target_debug_print_signals): Constify.
6028         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6029         * procfs.c (procfs_target::pass_signals): Update.
6030         * linux-nat.c (linux_nat_target::pass_signals): Update.
6031         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6032         * target-delegates.c: Rebuild.
6033         * remote.c (remote_target::program_signals): Update.
6034         (remote_target::pass_signals): Update.
6035         * target.c (target_pass_signals): Constify argument.
6036         (target_program_signals): Likewise.
6037         * target.h (struct target_ops) <pass_signals, program_signals>:
6038         Constify argument.
6039         (target_pass_signals, target_program_signals): Constify argument.
6040
6041 2019-01-14  Tom Tromey  <tom@tromey.com>
6042
6043         PR tui/28819:
6044         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6045
6046 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6047
6048         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6049         field.
6050         * rs6000-tdep.c: Include reggroups.h.
6051         (IS_V_ALIAS_PSEUDOREG): Define.
6052         (rs6000_register_name): Return names for the "vX" aliases.
6053         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6054         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6055         aliases.  Call default_register_reggroup_p for all other
6056         pseudo-registers.
6057         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6058         New functions.
6059         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6060         Handle "vX" aliases.
6061         (v_alias_pseudo_register_collect): New function.
6062         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6063         (rs6000_gdbarch_init): Initialize "vX" aliases as
6064         pseudo-registers.  Restore registration of
6065         rs6000_pseudo_register_reggroup_p with
6066         set_tdesc_pseudo_register_reggroup_p.
6067
6068 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6069
6070         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6071         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6072         set_gdbarch_num_pseudo_regs.
6073
6074 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6075
6076         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6077         Remove arg prefixname, add do_set and do_show.
6078         Add member functions set_list and show_list.
6079         * cli/cli-style.c (class cli_style_option): Update accordingly.
6080         (style_set_list): Move to file scope.
6081         (style_show_list): Likewise.
6082         (set_style): Call help_list.
6083         (show_style): Call cmd_show_list.
6084         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6085         Update to use the new macro.
6086
6087 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6088
6089         * ada-lang.c (_initialize_ada_language): Expand the help text
6090         for the "catch exception" command.
6091
6092 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6093
6094         * symtab.c (matching_obj_sections): Initialize obj,
6095         declare it closer to its usage.
6096
6097 2019-01-10  Tom Tromey  <tom@tromey.com>
6098
6099         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6100         (basic_inf_threads_range): Remove.
6101         (inf_threads_range, inf_non_exited_threads_range)
6102         (safe_inf_threads_range): Use next_adapter.
6103
6104 2019-01-10  Keith Seitz  <keiths@redhat.com>
6105
6106         PR gdb/23712
6107         PR symtab/23010
6108         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6109         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6110
6111 2019-01-10  Keith Seitz  <keiths@redhat.com>
6112
6113         PR gdb/23712
6114         PR symtab/23010
6115         * dictionary.c (pending_to_vector): Remove.
6116         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6117         Remove _1 suffix, replacing functions of the same name.  Update
6118         all callers.
6119         (dict_create_hashed, dict_create_hashed_expandable)
6120         (dict_create_linear, dict_create_linear_expandable, dict_free)
6121         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6122         Make functions static.
6123
6124 2019-01-10  Keith Seitz  <keiths@redhat.com>
6125
6126         PR gdb/23712
6127         PR symtab/23010
6128         * dictionary.h (struct dictionary): Replace declaration with
6129         multidictionary.
6130         (dict_create_hashed, dict_create_hashed_expandable)
6131         (dict_create_linear, dict_create_linear_expandable)
6132         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6133         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6134         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6135         taking multidictionary argument.
6136         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6137         * block.h (struct block) <dict>: Change to multidictionary
6138         and rename `multidict'.
6139         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6140         symmisc.c: Update all dictionary references to multidictionary.
6141
6142 2019-01-10  Keith Seitz  <keiths@redhat.com>
6143
6144         PR gdb/23712
6145         PR symtab/23010
6146         * dictionary.c: Include unordered_map.
6147         (pending_to_vector): New function.
6148         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6149         Rewrite the non-"_1" functions to take vector instead
6150         of linked list.
6151         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6152         "new" _1 versions of the same name.
6153         (multidictionary): Define.
6154         (std::hash<enum language): New definition.
6155         (collate_pending_symbols_by_language, mdict_create_hashed)
6156         (mdict_create_hashed_expandable, mdict_create_linear)
6157         (mdict_create_linear_expandable, mdict_free)
6158         (find_language_dictionary, create_new_language_dictionary)
6159         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6160         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6161         (mdict_size, mdict_empty): New functions.
6162         * dictionary.h (mdict_iterator): Define.
6163
6164 2019-01-10  Pedro Alves  <palves@redhat.com>
6165
6166         * breakpoint.c (read_uploaded_action)
6167         (create_tracepoint_from_upload): Adjust to use
6168         gdb::unique_xmalloc_ptr.
6169         * ctf.c (ctf_write_uploaded_tp):
6170         (SET_ARRAY_FIELD): Use emplace_back.
6171         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6172         * tracefile-tfile.c (tfile_write_uploaded_tp):
6173         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6174         gdb::unique_xmalloc_ptr.
6175         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6176         at_string, cond_string, cmd_strings>: Replace char pointers
6177         with gdb::unique_xmalloc_ptr.
6178
6179 2019-01-10  Pedro Alves  <palves@redhat.com>
6180
6181         * solib-target.c (library_list_start_library): Don't xstrdup name.
6182
6183 2019-01-10  Pedro Alves  <palves@redhat.com>
6184
6185         * mdebugread.c (parse_partial_symbols): Use
6186         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6187
6188 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6189
6190         * linux-fork.c (scoped_switch_fork_info)
6191         <~scoped_switch_fork_info>: Fix incorrect variable name.
6192
6193 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * linux-fork.c (scoped_switch_fork_info)
6196         <scoped_switch_fork_info>: Make explicit.
6197         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6198
6199 2019-01-10  Tom Tromey  <tom@tromey.com>
6200
6201         * objfiles.h (objfile::reset_psymtabs): Update.
6202         * objfiles.c (objfile::objfile): Update.
6203         * psymtab.h (psymtab_storage::obstack): Update.
6204         (psymtab_storage::m_obstack): Use gdb::optional.
6205         (class psymtab_storage): Update comment.  Remove objfile
6206         parameter.
6207         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6208
6209 2019-01-10  Tom Tromey  <tom@tromey.com>
6210
6211         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6212         <free_psymtabs>: Now private.
6213         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6214         (allocate_psymtab): Use new method.
6215
6216 2019-01-10  Tom Tromey  <tom@tromey.com>
6217
6218         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6219         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6220         * mdebugread.c (parse_partial_symbols): Use
6221         allocate_dependencies.
6222         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6223         allocate_dependencies.
6224         (process_psymtab_comp_unit_reader)
6225         (build_type_psymtab_dependencies): Likewise.
6226         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6227
6228 2019-01-10  Tom Tromey  <tom@tromey.com>
6229
6230         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6231         PSYMBOL_SET_LANGUAGE.
6232         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6233
6234 2019-01-10  Tom Tromey  <tom@tromey.com>
6235
6236         * psymtab.h (psymtab_storage::obstack): New method.
6237         <m_obstack>: Rename from obstack; now private.
6238         * psymtab.c (psymtab_storage): Update.
6239         * dwarf2read.c (create_addrmap_from_index)
6240         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6241         Update.
6242
6243 2019-01-10  Tom Tromey  <tom@tromey.com>
6244
6245         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6246         * objfiles.h (objfile::reset_psymtabs): New method.
6247
6248 2019-01-10  Tom Tromey  <tom@tromey.com>
6249
6250         * symmisc.c (print_symbol_bcache_statistics): Update.
6251         (print_objfile_statistics): Update.
6252         * symfile.c (reread_symbols): Update.
6253         * psymtab.h (class psymtab_storage): New.
6254         * psymtab.c (psymtab_storage): New constructor.
6255         (~psymtab_storage): New destructor.
6256         (require_partial_symbols): Update.
6257         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6258         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6259         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6260         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6261         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6262         (start_psymtab_common, end_psymtab_common)
6263         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6264         (allocate_psymtab): Update.
6265         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6266         Update.
6267         (dump_psymtab_addrmap, maintenance_print_psymbols)
6268         (maintenance_check_psymtabs): Update.
6269         (class objfile_psymtabs): Move to objfiles.h.
6270         * psympriv.h (discard_psymtab): Now inline.
6271         (psymtab_discarder::psymtab_discarder): Update.
6272         (psymtab_discarder::~psymtab_discarder): Update.
6273         (ALL_OBJFILE_PSYMTABS): Rewrite.
6274         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6275         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6276         Remove fields.
6277         <partial_symtabs>: New field.
6278         (class objfile_psymtabs): Move from psymtab.h.  Update.
6279         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6280         psymbol_cache.
6281         (objfile::~objfile): Don't destroy psymbol_cache.
6282         * mdebugread.c (parse_partial_symbols): Update.
6283         * dwarf2read.c (create_addrmap_from_index)
6284         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6285         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6286         (add_partial_subprogram, dwarf2_ranges_read): Update.
6287         * dwarf-index-write.c (write_address_map)
6288         (write_one_signatured_type, recursively_write_psymbols)
6289         (class debug_names, class debug_names, write_psymtabs_to_index):
6290         Update.
6291
6292 2019-01-10  Tom Tromey  <tom@tromey.com>
6293
6294         * symtab.h (SYMBOL_SET_NAMES): Update.
6295         (symbol_set_names): Update.
6296         (MSYMBOL_SET_NAMES): Update.
6297         * symtab.c (symbol_set_names): Change argument to be an
6298         objfile_per_bfd_storage.
6299         * psymtab.c (add_psymbol_to_bcache): Update.
6300         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6301
6302 2019-01-10  Tom Tromey  <tom@tromey.com>
6303
6304         * symtab.c (create_demangled_names_hash): Change argument to be an
6305         objfile_per_bfd_storage.
6306         (symbol_set_names): Update.
6307
6308 2019-01-10  Tom Tromey  <tom@tromey.com>
6309
6310         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6311         init_psymbol_list.
6312         * psymtab.c (init_psymbol_list): Do nothing if already called.
6313         * psympriv.h (init_psymbol_list): Add comment.
6314         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6315         init_psymbol_list.
6316         * dbxread.c (dbx_symfile_read): Unconditionally call
6317         init_psymbol_list.
6318
6319 2019-01-10  Tom Tromey  <tom@tromey.com>
6320
6321         * xcoffread.c (scan_xcoff_symtab): Update.
6322         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6323         "where".
6324         * mdebugread.c (parse_partial_symbols)
6325         (handle_psymbol_enumerators): Update.
6326         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6327         * dbxread.c (read_dbx_symtab): Update.
6328         * psympriv.h (psymbol_placement): New enum.
6329         (add_psymbol_to_list): Update.
6330
6331 2019-01-10  Tom Tromey  <tom@tromey.com>
6332
6333         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6334         static_psymbols parameters.
6335         (scan_xcoff_symtab): Update.
6336         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6337         static_psymbols parameters.
6338         * psympriv.h (start_psymtab_common): Update.
6339         * mdebugread.c (parse_partial_symbols): Update.
6340         * dwarf2read.c (create_partial_symtab): Update.
6341         * dbxread.c (read_dbx_symtab): Update.
6342         (start_psymtab): Remove global_psymbols and static_psymbols
6343         parameters.
6344
6345 2019-01-10  Tom Tromey  <tom@tromey.com>
6346
6347         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6348         * psymtab.c (allocate_psymtab): Add comment.
6349         * psympriv.h (allocate_psymtab): Add comment.
6350         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6351         initializations.
6352         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6353
6354 2019-01-10  Tom Tromey  <tom@tromey.com>
6355
6356         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6357         Don't declare.
6358         * mipsread.c: Include mdebugread.h.
6359         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6360         Declare.
6361         * elfread.c: Include mdebugread.h.
6362
6363 2019-01-09  Tom Tromey  <tom@tromey.com>
6364
6365         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6366         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6367         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6368         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6369         (psym_lookup_symbol, psym_find_last_source_symtab)
6370         (psym_forget_cached_source_info, psym_print_stats)
6371         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6372         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6373         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6374         (psym_find_compunit_symtab_by_address)
6375         (maintenance_print_psymbols, maintenance_info_psymtabs)
6376         (maintenance_check_psymtabs): Use ranged for.
6377         * psymtab.h (class objfile_psymtabs): New.
6378         (require_partial_symbols): Return objfile_psymtabs.
6379         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6380
6381 2019-01-09  Tom Tromey  <tom@tromey.com>
6382
6383         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6384         (find_pc_mapped_section, list_overlays_command)
6385         (map_overlay_command, unmap_overlay_command)
6386         (simple_overlay_update): Use all_objfiles.
6387         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6388         * printcmd.c (info_symbol_command): Use all_objfiles.
6389         * objfiles.h (ALL_OBJSECTIONS): Remove.
6390         * maint.c (maintenance_translate_address): Use all_objfiles.
6391         * gcore.c (gcore_create_callback): Use all_objfiles.
6392         (objfile_find_memory_regions): Likewise.
6393
6394 2019-01-09  Tom Tromey  <tom@tromey.com>
6395
6396         * symtab.c (find_line_symtab, info_sources_command)
6397         (make_source_files_completion_list): Use objfile_compunits.
6398         * source.c (select_source_symtab): Use objfile_compunits.
6399         * objfiles.h (struct objfile): Update comment.
6400         (ALL_OBJFILES): Remove.
6401         (ALL_FILETABS): Remove.
6402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6403         objfile_compunits.
6404
6405 2019-01-09  Tom Tromey  <tom@tromey.com>
6406
6407         * symmisc.c (print_objfile_statistics, dump_objfile)
6408         (maintenance_print_symbols): Use compunit_filetabs.
6409         * source.c (forget_cached_source_info_for_objfile): Use
6410         compunit_filetabs.
6411         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6412         (ALL_FILETABS): Use compunit_filetabs.
6413         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6414         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6415
6416 2019-01-09  Tom Tromey  <tom@tromey.com>
6417
6418         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6419         (compunit_filetabs): New.
6420         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6421         compunit_filetabs.
6422         (info_sources_command, make_source_files_completion_list): Remove
6423         declaration.
6424         * symmisc.c (print_objfile_statistics, dump_objfile)
6425         (maintenance_print_symbols): Remove declaration.
6426         (maintenance_info_symtabs): Use compunit_filetabs.
6427         (maintenance_info_line_tables): Likewise.
6428         * source.c (select_source_symtab): Change local variable name.
6429         (forget_cached_source_info_for_objfile): Remove declaration.
6430         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6431         * objfiles.c (objfile_relocate1): Remove declaration.
6432         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6433         declaration.
6434         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6435         * coffread.c (coff_symtab_read): Remove declaration.
6436         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6437         compunit_filetabs.
6438
6439 2019-01-09  Tom Tromey  <tom@tromey.com>
6440
6441         * symtab.c (lookup_objfile_from_block)
6442         (find_pc_sect_compunit_symtab, search_symbols)
6443         (default_collect_symbol_completion_matches_break_on): Use
6444         objfile_compunits.
6445         * objfiles.h (ALL_COMPUNITS): Remove.
6446         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6447         * cp-support.c (add_symbol_overload_list_qualified): Use
6448         objfile_compunits.
6449         * ada-lang.c (ada_collect_symbol_completion_matches)
6450         (ada_add_global_exceptions): Use objfile_compunits.
6451
6452 2019-01-09  Tom Tromey  <tom@tromey.com>
6453
6454         * source.c (select_source_symtab)
6455         (forget_cached_source_info_for_objfile): Remove declaration.
6456         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6457         declaration.
6458         * maint.c (count_symtabs_and_blocks): Remove declaration.
6459         * cp-support.c (add_symbol_overload_list_qualified): Remove
6460         declaration.
6461         * coffread.c (coff_symtab_read): Remove declaration.
6462         * symtab.c (lookup_symbol_in_objfile_symtabs)
6463         (basic_lookup_transparent_type_1): Use objfile_compunits.
6464         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6465         (info_sources_command, search_symbols)
6466         (default_collect_symbol_completion_matches_break_on)
6467         (make_source_files_completion_list): Remove declaration.
6468         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6469         (ada_collect_symbol_completion_matches)
6470         (ada_add_global_exceptions): Remove declaration.
6471         * linespec.c (iterate_over_all_matching_symtabs): Use
6472         objfile_compunits.
6473         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6474         (class objfile_compunits): New.
6475         (ALL_COMPUNITS): Use objfile_compunits.
6476         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6477         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6478         objfile_compunits.
6479         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6480
6481 2019-01-09  Tom Tromey  <tom@tromey.com>
6482
6483         * symtab.c (search_symbols)
6484         (default_collect_symbol_completion_matches_break_on): Use
6485         objfile_msymbols.
6486         * ada-lang.c (ada_lookup_simple_minsym)
6487         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6488         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6489         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6490         objfile_msymbols.
6491         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6492         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6493         * objc-lang.c (find_methods): Use objfile_msymbols.
6494         (info_selectors_command, info_classes_command): Likewise.
6495         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6496         * objfiles.h (class objfile_msymbols): New.
6497         (ALL_OBJFILE_MSYMBOLS): Remove.
6498         (ALL_MSYMBOLS): Remove.
6499
6500 2019-01-09  Tom Tromey  <tom@tromey.com>
6501
6502         * common/next-iterator.h (next_adapter): Add Iterator template
6503         parameter.
6504         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6505         (class all_objfiles_safe): New.
6506         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6507         * objfiles.c (put_objfile_before): Update comment.
6508         (add_separate_debug_objfile): Likewise.
6509         (free_all_objfiles): Use all_objfiles_safe.
6510         (objfile_purge_solibs): Likewise.
6511
6512 2019-01-09  Tom Tromey  <tom@tromey.com>
6513
6514         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6515         (expand_symtab_containing_pc, lookup_static_symbol)
6516         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6517         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6518         all_objfiles.
6519         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6520         * breakpoint.c (create_overlay_event_breakpoint)
6521         (create_longjmp_master_breakpoint)
6522         (create_std_terminate_master_breakpoint)
6523         (create_exception_master_breakpoint): Use all_objfiles.
6524         * linux-thread-db.c (try_thread_db_load_from_pdir)
6525         (has_libpthread): Use all_objfiles.
6526         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6527         * linespec.c (iterate_over_all_matching_symtabs)
6528         (search_minsyms_for_name): Use all_objfiles.
6529         * maint.c (maintenance_info_sections): Use all_objfiles.
6530         * main.c (captured_main_1): Use all_objfiles.
6531         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6532         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6533         * guile/scm-pretty-print.c
6534         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6535         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6536         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6537         (maintenance_print_msymbols): Use all_objfiles.
6538         * source.c (select_source_symtab): Use all_objfiles.
6539         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6540         * symfile.c (remove_symbol_file_command)
6541         (expand_symtabs_matching, map_symbol_filenames): Use
6542         all_objfiles.
6543         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6544         all_objfiles.
6545         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6546         * objc-lang.c (find_methods): Use all_objfiles.
6547         * objfiles.c (have_partial_symbols, have_full_symbols)
6548         (have_minimal_symbols, qsort_cmp)
6549         (default_iterate_over_objfiles_in_search_order): Use
6550         all_objfiles.
6551         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6552         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6553         (maintenance_check_psymtabs): Use all_objfiles.
6554         (ALL_PSYMTABS): Remove.
6555         * compile/compile-object-run.c (do_module_cleanup): Use
6556         all_objfiles.
6557         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6558         * cp-support.c (add_symbol_overload_list_qualified): Use
6559         all_objfiles.
6560         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6561         Use all_objfiles.
6562         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6563         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6564         all_objfiles.
6565         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6566         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6567         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6568         Uses all_objfiles.
6569         * solib.c (solib_read_symbols): Use all_objfiles
6570
6571 2019-01-09  Tom Tromey  <tom@tromey.com>
6572
6573         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6574         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6575         all_objfiles.
6576         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6577         * symmisc.c (print_symbol_bcache_statistics)
6578         (print_objfile_statistics, maintenance_print_objfiles)
6579         (maintenance_info_symtabs, maintenance_check_symtabs)
6580         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6581         all_objfiles.
6582         * source.c (forget_cached_source_info): Use all_objfiles.
6583         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6584         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6585         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6586         * objfiles.c (update_section_map): Use all_objfiles.
6587         (shared_objfile_contains_address_p): Likewise.
6588         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6589         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6590
6591 2019-01-09  Tom Tromey  <tom@tromey.com>
6592
6593         * common/next-iterator.h: New file.
6594         * objfiles.h (class all_objfiles): New.
6595         (struct objfile_iterator): New.
6596
6597 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6598
6599         * NEWS: Move the description of the changed "frame", "select-frame",
6600          and "info frame" commands to the Changed commands section.
6601
6602 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6603
6604         * gdbtypes.c (check_stub_method_group): Remove handling of old
6605         mangling schemes.
6606         * linespec.c (find_methods): Likewise.
6607         * stabsread.c (read_member_functions): Likewise.
6608         * valops.c (search_struct_method): Likewise.
6609         (value_struct_elt_for_reference): Likewise.
6610         * NEWS: Mention this change.
6611
6612 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6615         print_source_lines.
6616         * source.c (print_source_lines_base): Update line number check.
6617         (print_source_lines): New function.
6618         (source_lines_range::source_lines_range): New function.
6619         * source.h (class source_lines_range): New class.
6620         (print_source_lines): New declaration.
6621
6622 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6623
6624         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6625
6626 2019-01-08  Tom Tromey  <tom@tromey.com>
6627             Simon Marchi  <simon.marchi@ericsson.com>
6628
6629         PR gdb/24060
6630         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6631         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6632         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6633         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6634         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6635         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6636
6637 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6638
6639         * source.c (select_source_symtab): Move header comment to
6640         declaration in source.h.
6641         (forget_cached_source_info_for_objfile): Likewise.
6642         (forget_cached_source_info): Likewise.
6643         (identify_source_line): Likewise.
6644         * source.h (identify_source_line): Move declaration from symtab.h
6645         and add comment from source.c
6646         (print_source_lines): Likewise.
6647         (forget_cached_source_info_for_objfile): Likewise.
6648         (forget_cached_source_info): Likewise.
6649         (select_source_symtab): Likewise.
6650         (enum print_source_lines_flag): Move definition from symtab.h.
6651         * symtab.h (identify_source_line): Move declaration to source.h.
6652         (print_source_lines): Likewise.
6653         (forget_cached_source_info_for_objfile): Likewise.
6654         (forget_cached_source_info): Likewise.
6655         (select_source_symtab): Likewise.
6656         (enum print_source_lines_flag): Move definition to source.h.
6657         * tui/tui-hooks.c: Add 'source.h' include.
6658
6659 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * source.c (print_source_lines_base): Handle requests to print
6662         reverse line number sequences, and guard against empty lines
6663         string.
6664
6665 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6666
6667         * source.c (print_source_lines_base): Fix skip of '\r' if next
6668         character is '\n'.
6669
6670 2019-01-06  Tom Tromey  <tom@tromey.com>
6671
6672         * c-exp.y (struct c_parse_state) <macro_original_text,
6673         expansion_obstack>: New member.
6674         (macro_original_text, expansion_obstack): Remove globals.
6675         (scan_macro_expansion, scanning_macro_expansion)
6676         (finished_macro_expansion): Update.
6677         (scan_macro_cleanup): Remove.
6678         (yylex, c_parse): Update.
6679
6680 2019-01-06  Tom Tromey  <tom@tromey.com>
6681
6682         * c-exp.y (struct c_parse_state) <strings>: New member.
6683         (operator_stoken): Update.
6684
6685 2019-01-06  Tom Tromey  <tom@tromey.com>
6686
6687         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6688         (union type_stack_elt) <typelist_val>: Now a pointer to
6689         std::vector.
6690         (type_stack_cleanup): Don't declare.
6691         (push_typelist): Update.
6692         * parse.c (pop_typelist): Return a std::vector.
6693         (push_typelist): Take a std::vector.
6694         (follow_types): Update.  Do not free args.
6695         (type_stack_cleanup): Remove.
6696         * c-exp.y (struct c_parse_state): New.
6697         (cpstate): New global.
6698         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6699         (nonempty_typelist): Update.
6700         (func_mod): Create a new vector.
6701         (c_parse): Create a c_parse_state.
6702         (check_parameter_typelist): Do not delete params.
6703         (function_method): Update.  Do not delete type_list.
6704
6705 2019-01-06  Tom Tromey  <tom@tromey.com>
6706
6707         PR gdb/28155:
6708         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6709         check_typedef.
6710         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6711         (print_return_value): Likewise.
6712
6713 2019-01-05  Tom Tromey  <tom@tromey.com>
6714
6715         * contrib/cleanup_check.py: Remove.
6716         * contrib/gcc-with-excheck: Remove.
6717         * contrib/exsummary.py: Remove.
6718         * contrib/excheck.py: Remove.
6719
6720 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6721
6722         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6723         NULL. Initialize tpprev to NULL instead of assigning it
6724         to NULL on the next statement.
6725         * windows-nat.c (windows_delete_thread): Remove check for
6726         main_thread_id before printing thread exit notifications.
6727         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6728         Remove thread ID check against main_thread_id.
6729         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6730         windows_delete_thread.
6731         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6732
6733 2019-01-04  Tom Tromey  <tom@tromey.com>
6734
6735         * compile/compile.c (_initialize_compile): Use upper case for
6736         metasyntactic variables.
6737         * symmisc.c (_initialize_symmisc): Use upper case for
6738         metasyntactic variables.
6739         * psymtab.c (_initialize_psymtab): Use upper case for
6740         metasyntactic variables.
6741         * demangle.c (demangle_command): Use upper case for metasyntactic
6742         variables.
6743         (_initialize_demangler): Likewise.
6744         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6745         variables.
6746
6747 2019-01-03  Tom Tromey  <tom@tromey.com>
6748
6749         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6750
6751 2019-01-03  Tom Tromey  <tom@tromey.com>
6752
6753         * python/py-symtab.c (salpy_str): Update.
6754         (struct salpy_sal_object) <symtab>: Now a PyObject.
6755         (salpy_dealloc): Update.
6756         (del_objfile_sal): Use gdbpy_ref.
6757
6758 2019-01-03  Tom Tromey  <tom@tromey.com>
6759
6760         * python/py-type.c (convert_field): Use new_reference.  Return
6761         gdbpy_ref.
6762         (make_fielditem): Return gdbpy_ref.
6763         (typy_fields): Update.
6764         (typy_getitem): Update.
6765         (field_name): Return gdbpy_ref.  Use new_reference.
6766         (typy_iterator_iternext): Update.
6767
6768 2019-01-03  Tom Tromey  <tom@tromey.com>
6769
6770         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6771
6772 2019-01-03  Tom Tromey  <tom@tromey.com>
6773
6774         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6775         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6776         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6777         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6778         (pspy_set_type_printers): Likewise.
6779         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6780         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6781         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6782         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6783         (objfpy_set_type_printers): Likewise.
6784
6785 2019-01-03  Tom Tromey  <tom@tromey.com>
6786
6787         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6788         (gdbpy_print_stack): Use gdbpy_err_fetch.
6789         * python/python-internal.h (class gdbpy_err_fetch): New class.
6790         (class gdbpy_enter) <m_error_type, m_error_value,
6791         m_error_traceback>: Remove.
6792         <m_error>: New member.
6793         (gdbpy_exception_to_string): Don't declare.
6794         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6795         * python/py-value.c (convert_value_from_python): Use
6796         gdbpy_err_fetch.
6797         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6798         gdbpy_exception_to_string.
6799         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6800         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6801         gdbpy_err_fetch.
6802
6803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6804
6805         * linux-nat.c (delete_lwp_cleanup): Delete.
6806         (struct lwp_deleter): New struct.
6807         (lwp_info_up): New typedef.
6808         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6809         lwp_info_up.
6810
6811 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * linux-fork.c (class scoped_switch_fork_info): New class.
6814         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6815
6816 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * valops.c (find_overload_match): Remove use of null_cleanup, and
6819         calls to do_cleanups.
6820
6821 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * compile/compile-cplus-types.c
6824         (compile_cplus_instance::decl_name): Handle changes to
6825         cp_func_name.
6826         * cp-support.c (cp_func_name): Update header comment, update
6827         return type.
6828         * cp-support.h (cp_func_name): Update return type in declaration.
6829         * valops.c (find_overload_match): Move temp_func local to top
6830         level of function and change its type.  Use temp_func to hold and
6831         delete temporary string obtained from cp_func_name.
6832
6833 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6834
6835         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6836         gdb::char_vector, remove cleanup, and update uses of `msg`.
6837
6838 2019-01-03  Jim Wilson  <jimw@sifive.com>
6839
6840         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6841
6842 2019-01-02  Tom Tromey  <tom@tromey.com>
6843
6844         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6845         (tdesc_parse_xml): Remove cleanups.
6846         * target-descriptions.h (make_cleanup_free_target_description):
6847         Don't declare.
6848         (target_desc_deleter): New struct.
6849         (target_desc_up): New typedef.
6850         * target-descriptions.c (target_desc_deleter::operator()): Rename
6851         from free_target_description.
6852         (make_cleanup_free_target_description): Remove.
6853
6854 2019-01-02  Tom Tromey  <tom@tromey.com>
6855
6856         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6857         constructor, destructor.
6858         (linespec_parser): Remove typedef.
6859         (~linespec_parser): Rename from linespec_parser_delete.
6860         (linespec_lex_to_end, linespec_complete_label)
6861         (linespec_complete): Update.
6862         (decode_line_full): Remove cleanups.
6863         (decode_line_1): Update.
6864
6865 2019-01-02  Tom Tromey  <tom@tromey.com>
6866
6867         * python/python-internal.h (inferior_to_inferior_object): Change
6868         return type.
6869         * python/py-exitedevent.c (create_exited_event_object): Update.
6870         * python/py-inferior.c (inferior_to_inferior_object): Return
6871         gdbpy_ref.
6872         (python_new_inferior, python_inferior_deleted)
6873         (thread_to_thread_object, delete_thread_object)
6874         (build_inferior_list, gdbpy_selected_inferior): Update.
6875         * python/py-infthread.c (create_thread_object): Update.  Also fail
6876         if inferior_to_inferior_object fails.
6877
6878 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6879
6880         * inferior.h (class inferior) <displaced_step_state>: New field.
6881         * infrun.h (struct displaced_step_state): Move here from
6882         infrun.c.  Initialize fields, add constructor.
6883         <inf>: Remove field.
6884         <reset>: New method.
6885         * infrun.c (struct displaced_step_inferior_state): Move to
6886         infrun.h.
6887         (displaced_step_inferior_states): Remove.
6888         (get_displaced_stepping_state): Adust.
6889         (displaced_step_in_progress_any_inferior): Adjust.
6890         (displaced_step_in_progress_thread): Adjust.
6891         (displaced_step_in_progress): Adjust.
6892         (add_displaced_stepping_state): Remove.
6893         (get_displaced_step_closure_by_addr): Adjust.
6894         (remove_displaced_stepping_state): Remove.
6895         (infrun_inferior_exit): Call displaced_step_state.reset.
6896         (use_displaced_stepping): Don't check for NULL.
6897         (displaced_step_prepare_throw): Call
6898         get_displaced_stepping_state.
6899         (displaced_step_fixup): Don't check for NULL.
6900         (prepare_for_detach): Don't check for NULL.
6901
6902 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6903
6904         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6905          in case of call that did not complete.
6906
6907 2019-01-02  Andrey Utkin  <autkin@undo.io>
6908
6909         * symfile.c (find_separate_debug_file): Fix search of debug files for
6910         remote debuggee.
6911
6912 2019-01-02  Tom Tromey  <tom@tromey.com>
6913
6914         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6915         indentation.
6916         * python/py-frame.c (frapy_older): Remove cast.
6917         (frapy_newer): Likewise.
6918         * python/py-breakpoint.c (local_setattro): Remove cast.
6919         * python/py-arch.c (archpy_name): Remove local variable.
6920         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6921
6922 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6923
6924         * unittests/basic_string_view/element_access/char/empty.cc:
6925         Fix year range in copyright header.
6926
6927 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6928
6929         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6930         Delete.
6931         <operator==>: Update with for removed field.
6932         <hash>: Likewise.
6933         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6934         <isa_features>: ...this.
6935         <abi_features>: New field.
6936         (riscv_isa_flen): Update comment.
6937         (riscv_abi_xlen): New declaration.
6938         (riscv_abi_flen): New declaration.
6939         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6940         isa_features.
6941         (riscv_abi_xlen): New function.
6942         (riscv_isa_flen): Update to get answer from isa_features.
6943         (riscv_abi_flen): New function.
6944         (riscv_has_fp_abi): Update to get answer from abi_features.
6945         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6946         xlen and flen.
6947         (riscv_call_info) <xlen, flen>: Update comment.
6948         (riscv_call_arg_struct): Remove invalid assertions
6949         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6950         is removed.
6951         (riscv_gdbarch_init): Gather isa features and abi features
6952         separately, ensure both match on the gdbarch when reusing an old
6953         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6954         a target with 64-bit float hardware.
6955
6956 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6957
6958         * source.c (search_command_helper): Stop reverse search
6959         when line 1 has been searched.
6960
6961 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6962
6963         * record-full.c (record_full_base_target::close): Rewrite
6964         record_full_core_buf_list free logic.
6965
6966 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6967
6968         * break-catch-syscall.c (print_one_catch_syscall): xfree
6969         the last text.
6970
6971 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6972
6973         * top.c (print_gdb_version): Update Copyright year in version
6974         message.
6975
6976 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6977
6978         Update copyright year range in all GDB files.
6979
6980 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6981
6982         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6983
6984 For older changes see ChangeLog-2018.
6985 \f
6986 Local Variables:
6987 mode: change-log
6988 left-margin: 8
6989 fill-column: 74
6990 version-control: never
6991 coding: utf-8
6992 End:
6993