gdb/ChangeLog

   1 2019-11-01  Tom Tromey  <tromey@adacore.com>
   2
   3         * utils.c (print_sys_errmsg): Simplify.
   4
   5 2019-11-01  Tom Tromey  <tromey@adacore.com>
   6
   7         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
   8
   9 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
  10
  11         * configure: Regenerate.
  12         * configure.ac: Remove check for strerror_r.
  13         * gdbsupport/common.m4: Check for strerror_r.
  14
  15 2019-11-01  Luis Machado  <luis.machado@linaro.org>
  16
  17         PR gdb/25124
  18
  19         * arm-tdep.c (arm_per_objfile): Rename to ...
  20         (arm_per_bfd): ... this.
  21         (arm_objfile_data_key): Rename to ...
  22         (arm_bfd_data_key): ... this.
  23         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
  24         data.
  25         (arm_record_special_symbol): Likewise.
  26
  27 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
  30         end.
  31         * c-typeprint.c (c_print_typedef): Likewise.
  32         * f-typeprint.c (f_print_typedef): Likewise.
  33         * m2-typeprint.c (m2_print_typedef): Likewise.
  34         * p-typeprint.c (pascal_print_typedef): Likewise.
  35         * rust-lang.c (rust_print_typedef): Likewise.
  36         * symtab.c (print_symbol_info): Print a newline after calling
  37         typedef_print.
  38
  39 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  40
  41         * symtab.c (info_module_cmdlist): New variable.
  42         (info_module_command): New function.
  43         (search_module_symbols): New function.
  44         (info_module_subcommand): New function.
  45         (struct info_modules_var_func_options): New struct.
  46         (info_modules_var_func_options_defs): New variable.
  47         (make_info_modules_var_func_options_def_group): New function.
  48         (info_module_functions_command): New function.
  49         (info_module_variables_command): New function.
  50         (info_module_var_func_command_completer): New function.
  51         (_initialize_symtab): Register new 'info module functions' and
  52         'info module variables' commands.
  53         * symtab.h (typedef symbol_search_in_module): New typedef.
  54         (search_module_symbols): Declare new function.
  55         * NEWS: Mention new commands.
  56
  57 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
  60         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
  61         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
  62         MODULES_DOMAIN.
  63         (scan_partial_symbols): Only create partial module symbols for non
  64         declarations.
  65         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
  66         and MODULES_DOMAIN.
  67         * symtab.c (search_domain_name): Likewise.
  68         (search_symbols): Likewise.
  69         (print_symbol_info): Likewise.
  70         (symtab_symbol_info): Likewise.
  71         (info_modules_command): New function.
  72         (_initialize_symtab): Register 'info modules' command.
  73         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
  74         * NEWS: Mention new 'info modules' command.
  75
  76 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  77
  78         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
  79         and $_gdb_maint_setting_str.
  80
  81 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  82
  83         * cli/cli-cmds.c (setting_cmd, value_from_setting)
  84         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
  85         (str_value_from_setting, gdb_setting_str_internal_fn)
  86         (gdb_maint_setting_str_internal_fn): New functions.
  87         (_initialize_cli_cmds): Define the new convenience functions.
  88         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
  89         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  90
  91 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  92
  93         * agent.c (set_can_use_agent): When the setting is turned on,
  94         look up agent symbols if we don't have them yet.
  95         (agent_new_objfile): Don't look up agent symbols when the agent
  96         setting is off.
  97
  98 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * config.in: Regenerate.
 101
 102 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 103
 104         * configure: Regenerate.
 105         * configure.ac: Check for strerror_r.
 106         * gdbsupport/common-utils.h (safe_strerror): Change return value
 107         to const char * and document that this function is now threadsafe.
 108         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 109         thread_local and call strerror_r, if available.
 110         * utils.c (perror_string): Update.
 111         (print_sys_errmsg): Update.
 112
 113 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 114
 115         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 116         objfile_key.
 117         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 118         objfile to fetch per-bfd data.
 119         (arm_find_exidx_entry): Likewise.
 120
 121 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 122
 123         * gdbsupport/agent.c (debug_agent): Change type to bool.
 124         (use_agent): Likewise.
 125         (all_agent_symbols_look_up): Likewise.
 126         (agent_loaded_p): Change return value to bool.
 127         (agent_look_up_symbols): Update.
 128         (agent_capability_check): Change return value to bool.
 129         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 130         (debug_agent): Change type to bool.
 131         (use_agent): Likewise.
 132         (agent_capability_check): Change return value to bool.
 133
 134 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 135
 136         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 137         (build_minimal_symbol_hash_tables): Code to clear the table moved
 138         to clear_minimal_symbol_hash_tables.
 139         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 140         when needed.
 141
 142 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 143
 144         * infcmd.c: Remove includes.
 145         * infrun.c: Remove includes.
 146
 147 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 148
 149         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 150         (grow_vect): Remove declaration.
 151         (ada_type_of_array): Remove declaration.
 152         (ada_update_initial_language): Remove declaration.
 153         (ada_fold_name): Remove declaration.
 154         (ada_fill_in_ada_prototype): Remove declaration.
 155         (user_select_syms): Remove declaration.
 156         (get_selections): Remove declaration.
 157         (ada_tag_type): Remove declaration.
 158         (ada_value_tag): Remove declaration.
 159         (ada_is_others_clause): Remove declaration.
 160         (ada_in_variant): Remove declaration.
 161         (ada_value_struct_elt): Remove declaration.
 162         (ada_attribute_name): Remove declaration.
 163         (ada_system_address_type): Remove declaration.
 164         * ada-lang.c (ada_watch_location_expression): Make static.
 165         (GROW_VECT): Move here from ada-lang.h.
 166         (grow_vect): Make static.
 167         (ada_update_initial_language): Make static.
 168         (ada_fold_name): Make static.
 169         (ada_type_of_array): Make static.
 170         (encoded_ordered_before): Move up.
 171         (sort_choices): Move up.
 172         (print_signatures): Move up.
 173         (ada_print_symbol_signature): Move up.
 174         (get_selections): Move up and make static.
 175         (user_select_syms): Move up and make static.
 176         (ada_value_struct_elt): Move up and make static.
 177         (ada_tag_type): Make static.
 178         (ada_value_tag): Make static.
 179         (ada_is_others_clause): Make static.
 180         (ada_in_variant): Make static.
 181         (ada_attribute_name): Make static.
 182
 183 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 184
 185         * ada-lang.c: Remove includes.
 186         * ada-typeprint.c: Remove includes.
 187         * ada-valprint.c: Remove includes.
 188
 189 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 190
 191         * addrmap.c: Add static assertions of type size, moved from
 192         _initialize_addrmap.
 193         (_initialize_addrmap): Remove.
 194
 195 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 196
 197         * coffread.c (record_minimal_symbol): Update.
 198         (process_coff_symbol): Update.
 199         * dbxread.c (read_dbx_symtab): Update.
 200         * dwarf2read.c (add_partial_symbol): Update.
 201         (fixup_go_packaging): Update.
 202         (load_partial_dies): Update.
 203         (new_symbol): Update.
 204         * elfread.c (record_minimal_symbol): Change signature to use
 205         gdb::string_view instead of name+len.
 206         (elf_symtab_read): Update.
 207         (elf_rel_plt_read): Update.
 208         * mdebugread.c (parse_partial_symbols): Update.
 209         (handle_psymbol_enumerators): Update.
 210         (new_symbol): Update.
 211         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 212         to use gdb::string_view instead of name+len.
 213         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 214         * psympriv.h (add_psymbol_to_list): Likewise.
 215         * psymtab.c (add_psymbol_to_bcache): Likewise.
 216         (add_psymbol_to_list): Likewise.
 217         * stabsread.c (define_symbol): Update.
 218         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 219         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 220         (symbol_set_names): Likewise.
 221         * xcoffread.c (scan_xcoff_symtab): Update.
 222
 223 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 224
 225         * symtab.h (symbol_set_names): Document that copy_name must be
 226         set to true for non-nullterminated strings.
 227         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 228         linkage_name if the entry was not found and we need to demangle.
 229
 230 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 231
 232         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 233         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 234         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 235         * gdbsupport/gdb_binary_search.h: New file.
 236
 237 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 238
 239         * NEWS: Mention new --with-system-gdbinit-dir option.
 240         * config.in: Regenerate.
 241         * configure: Regenerate.
 242         * configure.ac: Add new option --with-system-gdbinit-dir.
 243         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 244         for a ".gdb" suffix.
 245         * main.c (get_init_files): Change system_gdbinit argument to
 246         a vector and return the files in SYSTEM_GDBINIT_DIR in
 247         addition to SYSTEM_GDBINIT.
 248         (captured_main_1): Update.
 249         (print_gdb_help): Update.
 250         * top.c (print_gdb_configuration): Also print the value of
 251         SYSTEM_GDBINIT_DIR.
 252
 253 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 254
 255         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 256         that takes gdb::string_view arguments.
 257
 258 2019-10-26  Tom de Vries  <tdevries@suse.de>
 259
 260         * aarch64-linux-tdep.c: Fix typos in comments.
 261         * aarch64-tdep.c: Same.
 262         * ada-lang.c: Same.
 263         * amd64-nat.c: Same.
 264         * arc-tdep.c: Same.
 265         * arch/aarch64-insn.c: Same.
 266         * block.c: Same.
 267         * breakpoint.h: Same.
 268         * btrace.h: Same.
 269         * c-varobj.c: Same.
 270         * cli/cli-decode.c: Same.
 271         * cli/cli-script.c: Same.
 272         * cli/cli-utils.h: Same.
 273         * coff-pe-read.c: Same.
 274         * coffread.c: Same.
 275         * compile/compile-cplus-symbols.c: Same.
 276         * compile/compile-object-run.c: Same.
 277         * completer.c: Same.
 278         * corelow.c: Same.
 279         * cp-support.c: Same.
 280         * demangle.c: Same.
 281         * dwarf-index-write.c: Same.
 282         * dwarf2-frame.c: Same.
 283         * dwarf2-frame.h: Same.
 284         * eval.c: Same.
 285         * frame-base.h: Same.
 286         * frame.h: Same.
 287         * gdbcmd.h: Same.
 288         * gdbtypes.h: Same.
 289         * gnu-nat.c: Same.
 290         * guile/scm-objfile.c: Same.
 291         * i386-tdep.c: Same.
 292         * i386-tdep.h: Same.
 293         * infcall.c: Same.
 294         * infcall.h: Same.
 295         * linux-nat.c: Same.
 296         * m68k-tdep.c: Same.
 297         * macroexp.c: Same.
 298         * memattr.c: Same.
 299         * mi/mi-cmd-disas.c: Same.
 300         * mi/mi-getopt.h: Same.
 301         * mi/mi-main.c: Same.
 302         * minsyms.c: Same.
 303         * nat/aarch64-sve-linux-sigcontext.h: Same.
 304         * objfiles.h: Same.
 305         * ppc-linux-nat.c: Same.
 306         * ppc-linux-tdep.c: Same.
 307         * ppc-tdep.h: Same.
 308         * progspace.h: Same.
 309         * prologue-value.h: Same.
 310         * python/py-evtregistry.c: Same.
 311         * python/py-instruction.h: Same.
 312         * record-btrace.c: Same.
 313         * record-full.c: Same.
 314         * remote.c: Same.
 315         * rs6000-tdep.c: Same.
 316         * ser-tcp.c: Same.
 317         * sol-thread.c: Same.
 318         * sparc-sol2-tdep.c: Same.
 319         * sparc64-tdep.c: Same.
 320         * stabsread.c: Same.
 321         * symfile.c: Same.
 322         * symtab.h: Same.
 323         * target.c: Same.
 324         * tracepoint.c: Same.
 325         * tui/tui-data.h: Same.
 326         * tui/tui-io.c: Same.
 327         * tui/tui-win.c: Same.
 328         * tui/tui.c: Same.
 329         * unittests/rsp-low-selftests.c: Same.
 330         * user-regs.h: Same.
 331         * utils.c: Same.
 332         * utils.h: Same.
 333         * valarith.c: Same.
 334         * valops.c: Same.
 335         * valprint.c: Same.
 336         * valprint.h: Same.
 337         * value.c: Same.
 338         * value.h: Same.
 339         * varobj.c: Same.
 340         * x86-nat.h: Same.
 341         * xtensa-tdep.c: Same.
 342
 343 2019-10-25  Ali Tamur <tamur@google.com>
 344
 345         * charset.c (find_charset_names): Reflect API change.
 346
 347 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 348
 349         * symtab.c (struct demangled_name_entry): Change demangled name
 350         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 351         part of the struct anymore.
 352         (symbol_set_names): No longer obstack allocate + copy the demangled
 353         name, just store the allocated name from bfd.
 354
 355 2019-10-25  Tom Tromey  <tromey@adacore.com>
 356
 357         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 358         (bsearch_cie_cmp, add_cie): Remove.
 359         (find_cie): Reimplement.
 360         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 361         (dwarf2_build_frame_info): Update.
 362
 363 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 364
 365         PR gdb/25126
 366         * symfile.c (reread_symbols): Call forget_cached_source_info to
 367         clear the stale source cache.
 368
 369 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * configure: Regenerate.
 372         * configure.ac: Remove code that sets python_has_threads.
 373
 374 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 375
 376         * config.in: Regenerate.
 377         * configure: Regenerate.
 378         * configure.ac: Remove the code that uses sed to get the python
 379         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 380
 381 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 382
 383         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 384         error paths.
 385
 386 2019-10-23  Tom Tromey  <tom@tromey.com>
 387
 388         * arc-tdep.c: Remove ".." from include.
 389         * frv-tdep.c: Remove ".." from include.
 390         * lm32-tdep.c: Remove ".." from include.
 391         * microblaze-tdep.c: Remove ".." from include.
 392         * or1k-tdep.h: Remove ".." from include.
 393         * s12z-tdep.c: Remove ".." from include.
 394         * Makefile.in (OPCODES_CFLAGS): Add comment.
 395         (TOP_CFLAGS): New variable.
 396         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 397
 398 2019-10-23  Tom Tromey  <tom@tromey.com>
 399
 400         * Makefile.in (READLINE_DIR): Update.
 401
 402 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 403
 404         * infcall.c (call_function_by_hand_dummy): Fix the function
 405         comment.  And extract out a code section into...
 406         (reserve_stack_space): ...this new function.
 407
 408 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 409
 410         * infcall.c (value_arg_coerce): Remove an unused parameter.
 411         (call_function_by_hand_dummy): Update the call to
 412         'value_arg_coerce'.
 413
 414 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 415
 416         * infcall.c (call_function_by_hand_dummy): Refactor.
 417
 418 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 419
 420         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 421
 422 2019-10-23  Tom Tromey  <tom@tromey.com>
 423
 424         * configure: Rebuild.
 425         * configure.ac: Don't check for sigprocmask.
 426         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 427
 428 2019-10-23  Tom Tromey  <tom@tromey.com>
 429
 430         * configure: Rebuild.
 431         * acinclude.m4: Use m4_include, not sinclude.
 432
 433 2019-10-23  Tom de Vries  <tdevries@suse.de>
 434
 435         PR breakpoints/24687
 436         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 437
 438 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 439
 440         * symtab.c (struct demangled_name_entry) <language>: Change from
 441         bitfield to regular variable.
 442
 443 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 444
 445         * symtab.c (struct demangled_name_entry): Add a constructor.
 446         (free_demangled_name_entry): New function to call the destructor
 447         for demangled_name_entry.
 448         (create_demangled_names_hash): Pass free_demangled_name_entry to
 449         htab_create_alloc.
 450         (symbol_set_names): Call placement new for demangled_name_entry.
 451         * utils.c: No longer include xxhash.h here, now that fast_hash
 452         is inlined in the header.
 453         * utils.h: Instead, include it here.
 454
 455 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 456
 457         * Makefile.in: Link with libxxhash.
 458         * config.in: Regenerate.
 459         * configure: Regenerate.
 460         * configure.ac: Search for libxxhash.
 461         * utils.c (fast_hash): Use xxhash if present.
 462
 463 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * utils.h (fast_hash): New function.
 466         * symtab.c (hash_demangled_name_entry): Call new function
 467         fast_hash.
 468
 469 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 470
 471         * symtab.c (struct demangled_name_entry): Change type of mangled
 472         to gdb::string_view. Also adds a constructor that takes the
 473         mangled name.
 474         (hash_demangled_name_entry): Update.
 475         (eq_demangled_name_entry): Update.
 476         (free_demangled_name_entry): New function to call the destructor
 477         now that this is not a POD anymore.
 478         (create_demangled_names_hash): Pass free_demangled_name_entry to
 479         htab_create_alloc.
 480         (symbol_set_names): Update.
 481
 482 2019-10-21  Ali Tamur  <tamu@google.com>
 483
 484         * dwarf2read.c (dir_index): Change type.
 485         (file_name_index): Likewise.
 486         (line_header::include_dir_at): Change comment and implementation on
 487         whether it is DWARF 5.
 488         (line_header::is_valid_file_index): New function.
 489         (line_header::file_name_at): Change comment and implementation on
 490         whether it is DWARF 5.
 491         (line_header::file_names): Change to private field renamed as
 492         m_file_names and introduce a new accessor method.
 493         (line_header::file_names_size): New method.
 494         (line_header::include_dirs): Change to private field and rename as
 495         m_include_dirs.
 496         (dw2_get_file_names_reader): Define local var at a smaller scope and
 497         reflect API change.
 498         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 499         (process_structure_scope): Likewise.
 500         (line_header::add_include_dir): Change message and reflect renaming.
 501         (line_header::add_file_name): Likewise.
 502         (read_formatted_entries): Handle DW_FORM_data16.
 503         (dwarf_decode_line_header): Fix line header length calculation.
 504         (psymtab_include_file_name): Change comment and API.
 505         (lnp_state_machine::m_file): Update comment and reflect type change.
 506         (lnp_state_machine::record_line): Reflect type change.
 507         (dwarf_decode_lines): Reflect API change.
 508         (file_file_name): Likewise.
 509         (file_full_name): Likewise.
 510
 511 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 514
 515 2019-10-21  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 518
 519 2019-10-21  Tom Tromey  <tom@tromey.com>
 520
 521         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 522         NM_H.   Use AC_CONFIG_LINKS.
 523         * configure: Rebuild.
 524         * Makefile.in (NM_H): New variable.
 525         (generated_files): Add NM_H.  Remove gcore.
 526         (nm.h, stamp-nmh): New targets.
 527
 528 2019-10-20  Tom Tromey  <tom@tromey.com>
 529
 530         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 531         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 532         obsolete comment.
 533         (put_objfile_before): Now static.
 534
 535 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 536
 537         * gdbsupport/common-utils.h (startswith): Change return type to
 538         bool.
 539
 540 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 541
 542         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 543         * breakpoint.c (bp_locations_compare): Rename to...
 544         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 545         (update_global_location_list): Use std::sort instead of qsort.
 546         * buildsym.c (compare_line_numbers): Rename to...
 547         (lte_is_less_than): ...this, and change to std::sort semantics.
 548         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 549         instead of qsort.
 550         * disasm.c (compare_lines): Rename to...
 551         (line_is_less_than): ...this, and change to std::sort semantics.
 552         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 553         of qsort.
 554         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 555         (fde_is_less_than): ...this, and change to std::sort semantics.
 556         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 557         * mdebugread.c (compare_blocks):
 558         (block_is_less_than): ...this, and change to std::sort semantics.
 559         (sort_blocks): Call std::sort instead of qsort.
 560         * objfiles.c (qsort_cmp): Rename to...
 561         (sort_cmp): ...this, and change to std::sort semantics.
 562         (update_section_map): Call std::sort instead of qsort.
 563         * remote.c (compare_pnums): Remove.
 564         (map_regcache_remote_table): Call std::sort instead of qsort.
 565         * utils.c (compare_positive_ints): Remove.
 566         * utils.h (compare_positive_ints): Remove.
 567         * xcoffread.c (compare_lte): Remove.
 568         (arrange_linetable): Call std::sort instead of qsort.
 569
 570 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 571
 572         * symfile.c (init_entry_point_info): Fix typo.
 573         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 574
 575 2019-10-18  Tom de Vries  <tdevries@suse.de>
 576
 577         * aarch64-tdep.c: Fix typos in comments.
 578         * ada-lang.c: Same.
 579         * ada-tasks.c: Same.
 580         * alpha-tdep.c: Same.
 581         * alpha-tdep.h: Same.
 582         * amd64-nat.c: Same.
 583         * amd64-windows-tdep.c: Same.
 584         * arc-tdep.c: Same.
 585         * arc-tdep.h: Same.
 586         * arch-utils.c: Same.
 587         * arm-nbsd-tdep.c: Same.
 588         * arm-tdep.c: Same.
 589         * ax-gdb.c: Same.
 590         * blockframe.c: Same.
 591         * btrace.c: Same.
 592         * c-varobj.c: Same.
 593         * coff-pe-read.c: Same.
 594         * coffread.c: Same.
 595         * cris-tdep.c: Same.
 596         * darwin-nat.c: Same.
 597         * dbxread.c: Same.
 598         * dcache.c: Same.
 599         * disasm.c: Same.
 600         * dtrace-probe.c: Same.
 601         * dwarf-index-write.c: Same.
 602         * dwarf2-frame-tailcall.c: Same.
 603         * dwarf2-frame.c: Same.
 604         * dwarf2read.c: Same.
 605         * eval.c: Same.
 606         * exceptions.c: Same.
 607         * fbsd-tdep.c: Same.
 608         * findvar.c: Same.
 609         * frame.c: Same.
 610         * frv-tdep.c: Same.
 611         * gnu-v3-abi.c: Same.
 612         * go32-nat.c: Same.
 613         * h8300-tdep.c: Same.
 614         * hppa-tdep.c: Same.
 615         * i386-linux-tdep.c: Same.
 616         * i386-tdep.c: Same.
 617         * ia64-libunwind-tdep.c: Same.
 618         * ia64-tdep.c: Same.
 619         * infcmd.c: Same.
 620         * infrun.c: Same.
 621         * linespec.c: Same.
 622         * linux-nat.c: Same.
 623         * linux-thread-db.c: Same.
 624         * machoread.c: Same.
 625         * mdebugread.c: Same.
 626         * mep-tdep.c: Same.
 627         * mn10300-tdep.c: Same.
 628         * namespace.c: Same.
 629         * objfiles.c: Same.
 630         * opencl-lang.c: Same.
 631         * or1k-tdep.c: Same.
 632         * osabi.c: Same.
 633         * ppc-linux-nat.c: Same.
 634         * ppc-linux-tdep.c: Same.
 635         * ppc-sysv-tdep.c: Same.
 636         * printcmd.c: Same.
 637         * procfs.c: Same.
 638         * record-btrace.c: Same.
 639         * record-full.c: Same.
 640         * remote-fileio.c: Same.
 641         * remote.c: Same.
 642         * rs6000-tdep.c: Same.
 643         * s12z-tdep.c: Same.
 644         * score-tdep.c: Same.
 645         * ser-base.c: Same.
 646         * ser-go32.c: Same.
 647         * skip.c: Same.
 648         * sol-thread.c: Same.
 649         * solib-svr4.c: Same.
 650         * solib.c: Same.
 651         * source.c: Same.
 652         * sparc-nat.c: Same.
 653         * sparc-sol2-tdep.c: Same.
 654         * sparc-tdep.c: Same.
 655         * sparc64-tdep.c: Same.
 656         * stabsread.c: Same.
 657         * stack.c: Same.
 658         * symfile.c: Same.
 659         * symtab.c: Same.
 660         * target-descriptions.c: Same.
 661         * target-float.c: Same.
 662         * thread.c: Same.
 663         * utils.c: Same.
 664         * valops.c: Same.
 665         * valprint.c: Same.
 666         * value.c: Same.
 667         * varobj.c: Same.
 668         * windows-nat.c: Same.
 669         * xcoffread.c: Same.
 670         * xstormy16-tdep.c: Same.
 671         * xtensa-tdep.c: Same.
 672
 673 2019-10-17  Tom Tromey  <tromey@adacore.com>
 674
 675         * configure: Rebuild.
 676         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 677         in AC_CONFIG_FILES invocation.
 678         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 679         new-style config.status invocation.
 680
 681 2019-10-17  Tom de Vries  <tdevries@suse.de>
 682
 683         * arm-nbsd-nat.c: Fix typos in comments.
 684         * arm-tdep.c: Same.
 685         * darwin-nat-info.c: Same.
 686         * dwarf2read.c: Same.
 687         * elfread.c: Same.
 688         * event-top.c: Same.
 689         * findvar.c: Same.
 690         * gdbtypes.c: Same.
 691         * hppa-tdep.c: Same.
 692         * i386-tdep.c: Same.
 693         * jit.c: Same.
 694         * main.c: Same.
 695         * mdebugread.c: Same.
 696         * moxie-tdep.c: Same.
 697         * nto-procfs.c: Same.
 698         * osabi.c: Same.
 699         * ppc-linux-tdep.c: Same.
 700         * remote.c: Same.
 701         * riscv-tdep.c: Same.
 702         * s390-tdep.c: Same.
 703         * sh-tdep.c: Same.
 704         * sparc-linux-tdep.c: Same.
 705         * sparc-nat.c: Same.
 706         * stack.c: Same.
 707         * target-descriptions.c: Same.
 708         * top.c: Same.
 709         * varobj.c: Same.
 710
 711 2019-10-16  Tom Tromey  <tom@tromey.com>
 712
 713         * objfiles.h (struct objfile) <original_name>: Now const.
 714
 715 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 718         pass on to sigsetjmp's second argument.
 719         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 720
 721 2019-10-16  Keith Seitz  <keiths@redhat.com>
 722
 723         PR gdb/23567
 724         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 725         sections whose size is greater than the file size.
 726
 727 2019-10-16  Jim Wilson  <jimw@sifive.com>
 728
 729         * riscv-tdep.c (riscv_gcc_target_options): New.
 730         (riscv_gnu_triplet_regexp): New.
 731         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 732         set_gdbarch_gnu_triplet_regexp.
 733
 734 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 735
 736         * Makefile.in: Add xml-builtin.h.
 737         * features/feature_to_c.sh: Add an include for xml-builtin.h
 738         to ensure that the compiler checks that the types match.
 739         * xml-builtin.h: New file.
 740         * xml-support.c (fetch_xml_builtin): Add missing const.
 741         * xml-support.h: Remove declaration of xml_builtins.
 742
 743 2019-10-16  Tom de Vries  <tdevries@suse.de>
 744
 745         PR tdep/25096
 746         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 747         (amd64_classify_aggregate): ... here.
 748         (amd64_classify_aggregate_field): Handled fiels of nested structs
 749         recursively.
 750
 751 2019-10-16  Tom de Vries  <tdevries@suse.de>
 752
 753         PR tdep/24104
 754         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 755         that handles 'theclass'.
 756
 757 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         * linespec.c (decode_digits_ordinary): Update comment.
 760         * make-target-delegates: No longer need to handle VEC case.
 761         * memrange.c (normalize_mem_ranges): Update comment.
 762         * namespace.c (add_using_directive): Update comment.
 763         * objc-lang.c (uniquify_strings): Update comment.
 764         * ppc-linux-nat.c (struct thread_points): Update comment.
 765         * probe.h (find_probes_in_objfile): Update comment.
 766         * target.h (enum flash_preserve_mode): Update comment.
 767         * varobj.c (varobj_restrict_range): Update comment.
 768         * varobj.h (varobj_list_children): Update comment.
 769
 770 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * Makefile.in: Remove references to vec.h and vec.c.
 773         * aarch64-tdep.c: No longer include vec.h.
 774         * ada-lang.c: Likewise.
 775         * ada-lang.h: Likewise.
 776         * arm-tdep.c: Likewise.
 777         * ax.h: Likewise.
 778         * breakpoint.h: Likewise.
 779         * charset.c: Likewise.
 780         * cp-support.h: Likewise.
 781         * dtrace-probe.c: Likewise.
 782         * dwarf2read.c: Likewise.
 783         * extension.h: Likewise.
 784         * gdb_bfd.c: Likewise.
 785         * gdbsupport/gdb_vecs.h: Likewise.
 786         * gdbsupport/vec.c: Remove.
 787         * gdbsupport/vec.h: Remove.
 788         * gdbthread.h: Likewise.
 789         * guile/scm-type.c: Likewise.
 790         * inline-frame.c: Likewise.
 791         * machoread.c: Likewise.
 792         * memattr.c: Likewise.
 793         * memrange.h: Likewise.
 794         * namespace.h: Likewise.
 795         * nat/linux-btrace.h: Likewise.
 796         * osdata.c: Likewise.
 797         * parser-defs.h: Likewise.
 798         * progspace.h: Likewise.
 799         * python/py-type.c: Likewise.
 800         * record-btrace.c: Likewise.
 801         * rust-exp.y: Likewise.
 802         * solib-target.c: Likewise.
 803         * stap-probe.c: Likewise.
 804         * target-descriptions.c: Likewise.
 805         * target-memory.c: Likewise.
 806         * target.h: Likewise.
 807         * varobj.c: Likewise.
 808         * varobj.h: Likewise.
 809         * xml-support.h: Likewise.
 810
 811 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 814         Update for new std::vector based implementation.
 815         (process_psymtab_comp_unit_reader): Likewise.
 816         (scan_partial_symbols): Likewise.
 817         (recursively_compute_inclusions): Likewise.
 818         (compute_compunit_symtab_includes): Likewise.
 819         (process_imported_unit_die): Likewise.
 820         (queue_and_load_dwo_tu): Likewise.
 821         (follow_die_sig_1): Likewise.
 822         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 823         (typedef dwarf2_per_cu_ptr): Remove.
 824         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 825         function.
 826         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 827         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 828         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 829         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 830         std::vector.
 831
 832 2019-10-15  Tom Tromey  <tromey@adacore.com>
 833
 834         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 835         TID.
 836
 837 2019-10-15  Tom Tromey  <tromey@adacore.com>
 838
 839         * windows-nat.c (windows_nat_target::fetch_registers)
 840         (windows_nat_target::store_registers): Rename "pid" to "tid".
 841
 842 2019-10-15  Tom Tromey  <tromey@adacore.com>
 843
 844         * gdbarch.h, gdbarch.c: Rebuild.
 845         * gdbarch.sh (gcc_target_options): Change return type to
 846         std::string.
 847         * compile/compile.c (get_args): Update.
 848         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 849         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 850         std::string.
 851         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 852         std::string.
 853         * arch-utils.c (default_gcc_target_options): Return std::string.
 854         * arch-utils.h (default_gcc_target_options): Return std::string.
 855         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 856
 857 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 858
 859         * breakpoint.c (breakpoint_chain): Make static.
 860         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 861         of accessing breakpoint_chain.
 862
 863 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 864
 865         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 866         to a gdb::function_view and return value to bool.
 867         * breakpoint.h (iterate_over_breakpoints): Likewise.
 868         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 869         (pop_dummy_frame): Update.
 870         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 871         (gdbscm_breakpoints): Update.
 872         * python/py-breakpoint.c (build_bp_list): Update.
 873         (gdbpy_breakpoints): Update.
 874         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 875         Update.
 876         (bpfinishpy_handle_stop): Update.
 877         (bpfinishpy_handle_exit): Update.
 878         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 879         (svr4_update_solib_event_breakpoints): Update.
 880
 881 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 882
 883         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 884         when unwrapping single-field structs.
 885
 886 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 887
 888         * dwarf2read.c: Remove includes.
 889
 890 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 891
 892         * ui-out.c (ui_out::call_do_message): Silence
 893         -Wformat-nonliteral warning.
 894
 895 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 896
 897         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 898         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 899         include: readline/tilde.h.
 900
 901 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 902
 903         * remote.c (remote_target::get_trace_status): Remove declaration of
 904         trace_regblock_size.
 905
 906 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 907
 908         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 909         (show_user): Remove declaration of cmdlist.
 910         * cli/cli-cmds.h (max_user_call_depth): Declare.
 911         * cli/cli-script.c (execute_user_command): Remove declaration
 912         of max_user_call_depth.
 913
 914 2019-10-11  Jim Wilson  <jimw@sifive.com>
 915
 916         * gdbsupport/print-utils.h (pulongest): Fix comment.
 917         (plongest): Likewise.
 918         (phex): Add missing comment, mention leading zeros.
 919         (phex_nz): Add mention of no leading zeros to comment.
 920
 921         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 922         plongest instead of unsigned long long cast.
 923
 924 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 925
 926         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 927         for external_editor_command and gdbtk_test.
 928
 929 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 930
 931         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 932         * varobj.c (varobjdebug): Move comment to...
 933         * varobj.h (varobjdebug): ...here, and declare.
 934
 935 2019-10-09  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 938         erase_data_content.
 939
 940 2019-10-09  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 943         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 944         * tui/tui-command.c (tui_cmd_window::resize)
 945         (tui_refresh_cmd_win): Update.
 946         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 947         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 948         * tui/tui-data.c (~tui_gen_win_info): Remove.
 949         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 950         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 951         (tui_redisplay_readline, tui_mld_flush)
 952         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 953         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 954         (tui_data_window::erase_data_content)
 955         (tui_data_item_window::rerender)
 956         (tui_data_item_window::refresh_window): Update.
 957         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 958         (box_win, tui_gen_win_info::make_window)
 959         (tui_gen_win_info::make_visible): Update.
 960         (tui_delete_win): Remove.
 961         * tui/tui-winsource.c
 962         (tui_source_window_base::do_erase_source_content): Update.
 963         (tui_show_source_line, tui_source_window_base::update_tab_width)
 964         (tui_source_window_base::update_exec_info): Update.
 965         * tui/tui-data.h (struct curses_deleter): New.
 966         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 967         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 968
 969 2019-10-09  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 972
 973 2019-10-09  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 976         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 977
 978 2019-10-09  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 981         window height directly.
 982         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 983         declare.
 984         * tui/tui-layout.c (tui_default_win_height): Remove.
 985         (tui_default_win_viewport_height): Remove.
 986
 987 2019-10-09  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui.h: Remove comments.
 990
 991 2019-10-09  Tom de Vries  <tdevries@suse.de>
 992
 993         * python/lib/gdb/printer/bound_registers.py: Use
 994         '^builtin_type_bound128' as regexp argument for
 995         add_builtin_pretty_printer.
 996
 997 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 998
 999         * guile/guile.c (guile_extension_script_ops): Remove forward
1000         declaration and mark as static.
1001         (guile_script_ops): Likewise.
1002         (extension_language_guile): Move further down in the file so
1003         it can reference the definitions for guile_{extension_,}script_ops.
1004
1005 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1006
1007         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1008         except SORTL, DFLTCC, and KDSA.
1009
1010 2019-10-08  Tom Tromey  <tromey@adacore.com>
1011
1012         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1013         (struct safe_symbol_file_add_args): Remove.
1014
1015 2019-10-08  Tom Tromey  <tromey@adacore.com>
1016
1017         * windows-nat.c: Don't include buildsym-legacy.h.
1018
1019 2019-10-08  Tom Tromey  <tromey@adacore.com>
1020
1021         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1022
1023 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1024
1025         * gdbtypes.c (overload_debug): Move comment to header.
1026         * gdbtypes.h (overload_debug): Declare.
1027         * valops.c: Remove declaration of overload_debug, instead
1028         include gdbtypes.h.
1029
1030 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1031
1032         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1033         through _().
1034         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1035         move comment...
1036         * language.h (lang_frame_mismatch_warn): ... here. Also add
1037         declaration.
1038         * top.c (lang_frame_mismatch_warn): Remove declaration.
1039         (check_frame_language_change): Pass lang_frame_mismatch_warn
1040         through _().
1041
1042 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1043
1044         * c-lang.h (vtbl_ptr_name): Declare.
1045         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1046         it from the header.
1047         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1048
1049 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1050
1051         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1052         gdb_static_assert.
1053
1054 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1055
1056         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1057         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1058         * ctfread.c: New file.
1059         * ctfread.h: New file.
1060         * elfread.c: Include ctfread.h.
1061         (struct elfinfo text_p): New member ctfsect.
1062         (elf_locate_sections): Mark CTF section.
1063         (elf_symfile_read): Call elfctf_build_psymtabs.
1064         * Makefile.in (LIBCTF): Add.
1065         (CLIBS): Use it.
1066         (CDEPS): Likewise.
1067         (DIST): Add ctfread.c.
1068
1069 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * ctfread.c (struct nextfield): Renamed to ...
1072         (struct ctf_nextfield): ... this.
1073         (struct field_info): Renamed to ...
1074         (strut ctf_field_info): ... this.
1075         (attach_fields_to_type): Update for renamed structures.
1076         (ctf_add_member_cb): Likewise.
1077         (ctf_add_enum_member_cb): Likewise.
1078         (process_struct_members): Likewise.
1079         (process_enum_type): Likewise.
1080
1081 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1082
1083         * tracectf.h: Rename, was ctf.h.
1084         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1085         * tracefile.c: Likewise.
1086         * tracepoint.c: Remove unused include ctf.h.
1087         * mi/mi-main.c: Likewise.
1088         * Makefile.in Replace ctf.c with tracectf.c.
1089
1090 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1091
1092         * version.in: Change version number to "9.0.50.DATE-git".
1093
1094 2019-10-03  Tom Tromey  <tom@tromey.com>
1095
1096         PR rust/24976:
1097         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1098
1099 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1102         cp_search_name_hash.
1103         * NEWS: Add entry about nested function support.
1104
1105 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1106             Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1109         for nested static variables when searchin VAR_DOMAIN.
1110         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1111         global scope, update comment.
1112         (add_partial_subprogram): Call add_partial_subprogram recursively
1113         for nested subroutines when processinng Fortran.
1114         (load_partial_dies): Process the child entities of a subprogram
1115         when processing Fortran.
1116         (partial_die_parent_scope): Handle building scope
1117         for Fortran nested functions.
1118         (process_die): Record that nested functions have a scope.
1119         (new_symbol): Always record Fortran subprograms on the global
1120         symbol list.
1121         (determine_prefix): How to build the prefix for Fortran
1122         subprograms.
1123
1124 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1127         have just sent the thread a SIGSTOP and are waiting for it to
1128         arrive.
1129
1130 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * btrace.c (btrace_add_pc): Remove whitespace before the template
1133         parameter in 'std::vector <...>'.
1134         (parse_xml_btrace_block): Likewise.
1135         (btrace_maint_decode_pt): Likewise.
1136         (btrace_maint_update_packets): Likewise.
1137         (btrace_maint_print_packets): Likewise.
1138         * btrace.h (struct btrace_maint_info): Likewise.
1139         * dwarf2read.c (struct type_unit_group): Likewise.
1140         (build_type_psymtabs_reader): Likewise.
1141         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1142         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1143         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1144
1145 2019-10-03  Tom de Vries  <tdevries@suse.de>
1146
1147         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1148         the first line of the help text for set/show style metadata.
1149
1150 2019-10-02  Tom Tromey  <tromey@adacore.com>
1151
1152         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1153         * gdbsupport/common-inferior.c: New file.
1154         * infcmd.c (startup_with_shell): Don't define.
1155         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1156         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1157         * inferior.h (startup_with_shell): Don't declare.
1158
1159 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1160
1161         * gdbsupport/gdb_assert.h: Include errors.h.
1162         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1163
1164 2019-10-02  Tom Tromey  <tromey@adacore.com>
1165
1166         * NEWS: Add $_ada_exception entry.
1167         * ada-lang.c (struct ada_catchpoint): Add constructor.
1168         <m_kind>: New member.
1169         (allocate_location_exception, re_set_exception): Remove
1170         "ex" parameter.
1171         (should_stop_exception): Compute $_ada_exception.
1172         (check_status_exception, print_it_exception)
1173         (print_one_exception, print_mention_exception): Remove
1174         "ex" parameter.
1175         (allocate_location_catch_exception, re_set_catch_exception)
1176         (check_status_exception, print_it_catch_exception)
1177         (print_one_catch_exception, print_mention_catch_exception)
1178         (print_recreate_catch_exception)
1179         (allocate_location_catch_exception_unhandled)
1180         (re_set_catch_exception_unhandled)
1181         (check_status_exception, print_it_catch_exception_unhandled)
1182         (print_one_catch_exception_unhandled)
1183         (print_mention_catch_exception_unhandled)
1184         (print_recreate_catch_exception_unhandled)
1185         (allocate_location_catch_assert, re_set_catch_assert)
1186         (check_status_assert, print_it_catch_assert)
1187         (print_one_catch_assert, print_mention_catch_assert)
1188         (print_recreate_catch_assert)
1189         (allocate_location_catch_handlers, re_set_catch_handlers)
1190         (check_status_handlers, print_it_catch_handlers)
1191         (print_one_catch_handlers, print_mention_catch_handlers)
1192         (print_recreate_catch_handlers): Remove.
1193         (create_ada_exception_catchpoint): Update.
1194         (initialize_ada_catchpoint_ops): Update.
1195
1196 2019-10-02  Tom Tromey  <tromey@adacore.com>
1197
1198         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1199         (create_excep_cond_exprs): Simplify exception string computation.
1200         (ada_exception_catchpoint_cond_string): Likewise.
1201
1202 2019-10-02  Tom Tromey  <tromey@adacore.com>
1203
1204         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1205         * ada-lang.c (lesseq_defined_than): Handle
1206         LOC_STATIC.
1207         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1208         parameter.
1209         (dwarf2_has_info): Likewise.
1210         (new_symbol): Set maybe_copied on symbol when
1211         appropriate.
1212         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1213         parameter.
1214         <can_copy>: New member.
1215         * elfread.c (record_minimal_symbol): Set maybe_copied
1216         on symbol when appropriate.
1217         (elf_symfile_read): Update call to dwarf2_has_info.
1218         * minsyms.c (lookup_minimal_symbol_linkage): New
1219         function.
1220         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1221         * symtab.c (get_symbol_address, get_msymbol_address):
1222         New functions.
1223         * symtab.h (get_symbol_address, get_msymbol_address):
1224         Declare.
1225         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1226         maybe_copied.
1227         (struct symbol, struct minimal_symbol) <maybe_copied>:
1228         New member.
1229
1230 2019-10-02  Tom Tromey  <tromey@adacore.com>
1231
1232         * source.c (struct current_source_location): New.
1233         (current_source_key): New global.
1234         (current_source_symtab, current_source_line)
1235         (current_source_pspace): Remove.
1236         (get_source_location): New function.
1237         (get_current_source_symtab_and_line)
1238         (set_default_source_symtab_and_line)
1239         (set_current_source_symtab_and_line)
1240         (clear_current_source_symtab_and_line, select_source_symtab)
1241         (info_source_command, print_source_lines_base)
1242         (info_line_command, search_command_helper, _initialize_source):
1243         Update.
1244
1245 2019-10-02  Tom Tromey  <tromey@adacore.com>
1246
1247         * source.c (select_source_symtab): Don't call
1248         decode_line_with_current_source.
1249
1250 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * symtab.c (lookup_global_symbol): Search global block.
1253
1254 2019-10-02  Tom Tromey  <tromey@adacore.com>
1255
1256         * coffread.c (process_coff_symbol): Update.
1257         * dwarf2read.c (var_decode_location, new_symbol): Update.
1258         * mdebugread.c (parse_symbol): Update.
1259         * objfiles.c (relocate_one_symbol): Update.
1260         * stabsread.c (define_symbol, fix_common_block)
1261         (scan_file_globals): Update.
1262         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1263         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1264         * xcoffread.c (process_xcoff_symbol): Update.
1265
1266 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1267
1268         * MAINTAINERS: Update my email address.
1269
1270 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1273         std::vector.
1274         (build_type_psymtabs_reader): Update for std::vector.
1275         (build_type_psymtab_dependencies): Likewise.
1276         * dwarf2read.h: Remove use of DEF_VEC_P.
1277         (typedef sig_type_ptr): Delete.
1278
1279 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1282         to std::vector.
1283         (btrace_maint_decode_pt): Likewise, and move allocation of the
1284         vector outside of the loop.
1285         (btrace_maint_update_packets): Update to handle change from VEC to
1286         std::vector.
1287         (btrace_maint_print_packets): Likewise.
1288         (maint_info_btrace_cmd): Likewise.
1289         * btrace.h: Remove use of DEF_VEC_O.
1290         (typedef btrace_pt_packet_s): Delete.
1291         (struct btrace_maint_info) <packets>: Change fromm VEC to
1292         std::vector.
1293         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1294
1295 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1298         make accesses into the vector constant references.
1299         (btrace_add_pc): Update for std::vector.
1300         (btrace_stitch_bts): Likewise.
1301         (parse_xml_btrace_block): Likewise.
1302         (btrace_maint_update_packets): Likewise.
1303         (btrace_maint_print_packets): Likewise.
1304         (maint_info_btrace_cmd): Likewise.
1305         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1306         std::vector.
1307         (btrace_data::empty): Likewise.
1308         (btrace_data_append): Likewise.
1309         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1310         (typedef btrace_block_s): Delete.
1311         (struct btrace_block): Add constructor.
1312         (struct btrace_data_bts) <blocks>: Change to std::vector.
1313         * nat/linux-btrace.c (perf_event_read_bts): Update for
1314         std::vector.
1315         (linux_read_bts): Likewise.
1316
1317 2019-10-01  Tom Tromey  <tom@tromey.com>
1318
1319         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1320
1321 2019-10-01  Tom Tromey  <tom@tromey.com>
1322
1323         * stack.c (print_frame, info_frame_command_core): Use
1324         styled_string.
1325         * linux-thread-db.c (try_thread_db_load_1)
1326         (try_thread_db_load_from_pdir_1): Use styled_string.
1327         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1328         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1329         (maybe_print_unsupported_script_warning)
1330         (maybe_print_script_not_found_warning): Use styled_string.
1331         * ada-lang.c (user_select_syms): Use styled_string.
1332
1333 2019-10-01  Tom Tromey  <tom@tromey.com>
1334
1335         * p-lang.c (pascal_printstr): Use metadata style.
1336         * value.c (show_convenience): Use metadata style.
1337         * valprint.c (valprint_check_validity, val_print_optimized_out)
1338         (val_print_not_saved, val_print_unavailable)
1339         (val_print_invalid_address, generic_val_print, val_print)
1340         (value_check_printable, val_print_array_elements): Use metadata
1341         style.
1342         * ui-out.h (class ui_out) <field_fmt>: New overload.
1343         <do_field_fmt>: Add style parameter.
1344         * ui-out.c (ui_out::field_fmt): New overload.
1345         * typeprint.c (type_print_unknown_return_type)
1346         (val_print_not_allocated, val_print_not_associated): Use metadata
1347         style.
1348         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1349         parameter.
1350         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1351         * tracepoint.c (tvariables_info_1): Use metadata style.
1352         * stack.c (print_frame_arg, print_frame_info, print_frame)
1353         (info_frame_command_core): Use metadata style.
1354         * skip.c (info_skip_command): Use metadata style.
1355         * rust-lang.c (rust_print_enum): Use metadata style.
1356         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1357         metadata style.
1358         * python/py-framefilter.c (py_print_single_arg): Use metadata
1359         style.
1360         * printcmd.c (do_one_display, print_variable_and_value): Use
1361         metadata style.
1362         * p-valprint.c (pascal_val_print)
1363         (pascal_object_print_value_fields): Use metadata style.
1364         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1365         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1366         parameter.
1367         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1368         * m2-valprint.c (m2_print_long_set): Use metadata style.
1369         * m2-typeprint.c (m2_print_type): Use metadata style.
1370         * infcmd.c (print_return_value_1): Use metadata style.
1371         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1372         * f-valprint.c (info_common_command_for_block): Use metadata
1373         style.
1374         * f-typeprint.c (f_type_print_base): Use metadata style.
1375         * expprint.c (print_subexp_standard): Use metadata style.
1376         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1377         * cli/cli-style.h (class cli_style_option): Add constructor.
1378         (metadata_style): Declare.
1379         * cli/cli-style.c (metadata_style): New global.
1380         (_initialize_cli_style): Register metadata style.
1381         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1382         parameter.
1383         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1384         * c-typeprint.c (c_type_print_base_struct_union)
1385         (c_type_print_base_1): Use metadata style.
1386         * breakpoint.c (watchpoint_value_print)
1387         (print_one_breakpoint_location): Use metadata style.
1388         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1389         style.
1390         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1391         style.
1392         * ada-valprint.c (val_print_packed_array_elements, printstr)
1393         (print_field_values, ada_val_print_ref, ada_val_print): Use
1394         metadata style.
1395         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1396         style.
1397         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1398         style.
1399         * ada-lang.c (user_select_syms): Use metadata style.
1400
1401 2019-10-01  Tom Tromey  <tom@tromey.com>
1402
1403         * cli/cli-cmds.c (pwd_command): Style output.
1404
1405 2019-10-01  Pedro Alves  <palves@redhat.com>
1406             Tom Tromey  <tom@tromey.com>
1407
1408         * symtab.c (print_symbol_info): Use %ps.
1409         (print_msymbol_info): Use %ps.
1410         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1411         * printcmd.c (print_variable_and_value): Use %ps.
1412         * macrocmd.c (show_pp_source_pos): Use %ps.
1413         * infrun.c (print_exited_reason): Use ui_out::message.
1414         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1415         (describe_other_breakpoints): Use ui_out::message and new
1416         formats.
1417         (say_where): Use new formats.
1418         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1419         and new formats.
1420
1421 2019-10-01  Pedro Alves  <palves@redhat.com>
1422             Tom Tromey  <tom@tromey.com>
1423
1424         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1425         (test_gdb_formats): New function.
1426         (run_tests): Call it.
1427         (test_format_specifier): Update.
1428         * utils.h (fputs_filtered): Update comment.
1429         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1430         (fputs_styled_unfiltered): Declare.
1431         * utils.c (fputs_styled_unfiltered): New function.
1432         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1433         (vfprintf_filtered): Update.
1434         (vfprintf_unfiltered, vprintf_filtered): Update.
1435         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1436         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1437         disallow_ui_out_field>: New constants.
1438         (enum class field_kind): New.
1439         (struct base_field_s, struct signed_field_s): New.
1440         (signed_field): New function.
1441         (struct string_field_s): New.
1442         (string_field): New function.
1443         (struct styled_string_s): New.
1444         (styled_string): New function.
1445         (class ui_out) <message>: Add comment.
1446         <vmessage, call_do_message>: New methods.
1447         <do_message>: Add style parameter.
1448         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1449         methods.
1450         (ui_out::message): Rewrite.
1451         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1452         parameter.
1453         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1454         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1455         gdb_extensions parameter.
1456         (class format_piece): Add parameter to constructor.
1457         (n_int_args): New field.
1458         * gdbsupport/format.c (format_pieces::format_pieces): Add
1459         gdb_extensions parameter.  Handle '*'.
1460         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1461         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1462         vfprintf_styled_no_gdbfmt.
1463         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1464         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1465         unfiltered output.
1466         * ui-style.h (struct ui_file_style) <ptr>: New method.
1467
1468 2019-10-01  Tom Tromey  <tom@tromey.com>
1469
1470         * unittests/format_pieces-selftests.c: Update.  Add final format.
1471         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1472         empty literal pieces.
1473
1474 2019-10-01  Tom Tromey  <tom@tromey.com>
1475
1476         * ui-out.h (enum class ui_out_style_kind): Remove.
1477         (class ui_out) <field_string, field_stsream, do_field_string>:
1478         Change type of "style".
1479         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1480         (ui_out::field_string): Update.
1481         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1482         of "style".
1483         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1484         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1485         * stack.c (print_frame_arg, print_frame_info, print_frame):
1486         Update.
1487         * source.c (print_source_lines_base): Update.
1488         * solib.c (info_sharedlibrary_command): Update.
1489         * skip.c (info_skip_command): Update.
1490         * record-btrace.c (btrace_call_history_src_line)
1491         (btrace_call_history): Update.
1492         * python/py-framefilter.c (py_print_frame): Update.
1493         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1494         "style".
1495         * mi/mi-out.c (mi_ui_out::do_table_header)
1496         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1497         (mi_ui_out::do_field_string): Update.
1498         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1499         Update.
1500         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1501         "style".
1502         * cli-out.c (cli_ui_out::do_table_header)
1503         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1504         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1505         (cli_ui_out::do_field_fmt): Update.
1506         * breakpoint.c (print_breakpoint_location): Update.
1507         (update_static_tracepoint): Update.
1508
1509 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1510
1511         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1512         conversion of gdb_datadir.
1513         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1514         remove not needed c_str ().
1515
1516 2019-09-30  Ali Tamur <tamur@google.com>
1517
1518         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1519         (dwarf2_string_attr): Likewise.
1520
1521 2019-09-30  Ali Tamur <tamur@google.com>
1522
1523         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1524         (process_full_type_unit): Likewise.
1525         (dump_die_shallow): Likewise.
1526         (cu_debug_loc_section): Likewise.
1527
1528 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1529
1530         * minsyms.c (compare_minimal_symbols): Rename to...
1531         (minimal_symbol_is_less_than): ...this, and adjust to STL
1532         conventions (return bool, take arguments as references)
1533         (minimal_symbol_reader::install): Call std::sort instead
1534         of qsort.
1535
1536 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1537
1538         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1539         hash and why.
1540         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1541         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1542
1543 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1544
1545         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1546         * psympriv.h (add_psymbol_to_list): Move comment here and update
1547         it.
1548
1549 2019-09-29  Tom de Vries  <tdevries@suse.de>
1550
1551         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1552         Use $tmpdir/$(basename "$output_file").dwz instead of
1553         "${output_file}.dwz".
1554
1555 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1556
1557         PR gdb/25045
1558         * hppa-linux-nat.c: Include gdbarch.h.
1559
1560 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1561
1562         * blockframe.c (find_pc_partial_function): Change return type to bool.
1563         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1564         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1565         (stub_gnu_ifunc_resolve_name): Likewise.
1566         * symtab.c (compare_filenames_for_search): Likewise.
1567         (compare_glob_filenames_for_search): Likewise.
1568         (matching_obj_sections): Likewise.
1569         (symbol_matches_domain): Likewise.
1570         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1571         (find_line_pc): Change return type to bool.
1572         (find_line_pc_range): Likewise.
1573         (producer_is_realview): Likewise.
1574         * symtab.h (symbol_matches_domain): Likewise.
1575         (find_pc_partial_function): Likewise.
1576         (find_pc_line_pc_range): Likewise.
1577         (in_gnu_ifunc_stub): Likewise.
1578         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1579         (find_line_pc): Likewise.
1580         (find_line_pc_range): Likewise.
1581         (matching_obj_sections): Likewise.
1582         (find_line_symtab): Change out parameter to bool.
1583         (producer_is_realview): Change return type to bool.
1584         (compare_filenames_for_search): Likewise.
1585         (compare_glob_filenames_for_search): Likewise.
1586
1587 2019-09-26  Tom Tromey  <tom@tromey.com>
1588
1589         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1590         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1591         * gdb_usleep.h: Remove.
1592         * gdb_usleep.c: Remove.
1593         * utils.c: Don't include gdb_usleep.h.
1594
1595 2019-09-26  Tom Tromey  <tromey@adacore.com>
1596
1597         * python/py-type.c (type_to_type_object): Call check_typedef
1598         for stub types.
1599
1600 2019-09-26  Tom Tromey  <tom@tromey.com>
1601
1602         * utils.h (initialize_utils): Don't declare.
1603         * top.c (gdb_init): Don't call initialize_utils.
1604         * utils.c (initialize_utils): Remove.  Move contents...
1605         (_initialize_utils): ... here.
1606
1607 2019-09-25  Tom Tromey  <tom@tromey.com>
1608
1609         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1610         * utils.h (make_hex_string): Don't declare.
1611         * utils.c (make_hex_string): Remove.
1612
1613 2019-09-24  Tom de Vries  <tdevries@suse.de>
1614
1615         PR gdb/23815
1616         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1617         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1618
1619 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1620
1621         * NEWS: Mention new simulator port for PRU.
1622
1623 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1624
1625         * ada-exp.y (write_object_remaining): Update.
1626         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1627         and eliminate the static buffer.
1628         (ada_decode_symbol): Update.
1629         (ada_la_decode): Update.
1630         (ada_sniff_from_mangled_name): Update.
1631         (is_valid_name_for_wild_match): Update.
1632         (ada_lookup_name_info::matches): Update and simplify.
1633         (name_matches_regex): Update.
1634         (ada_add_global_exceptions): Update.
1635         * ada-lang.h (ada_decode): Update signature.
1636         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1637         * dwarf-index-write.c (debug_names::insert): Update.
1638
1639 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1640
1641         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1642         formatting.
1643
1644 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1645
1646         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1647         Change "nonzero" to "true" in documentation.
1648
1649 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1650
1651         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1652         (_initialize_darwin_solib): Don't set
1653         darwin_so_ops.lookup_lib_global_symbol.
1654         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1655         set_gdbarch_iterate_over_objfiles_in_search_order.
1656         (elf_lookup_lib_symbol): Rename to...
1657         (svr4_iterate_over_objfiles_in_search_order): this, and update
1658         to iterate semantics.
1659         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1660         * solib.c (solib_global_lookup): Remove.
1661         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1662         (solib_global_lookup): Remove.
1663         * symtab.c (lookup_global_or_static_symbol): Remove call to
1664         solib_global_lookup.
1665
1666 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1667
1668         * NEWS: Move entries about default MI version now being
1669         version 3, and about the GDB/MI fix for multi-location
1670         breakpoints to the "since GDB 8.3" section.
1671
1672 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1673
1674         GDB 8.3.1 released.
1675
1676 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1677
1678         * NEWS: Mention that Cell/B.E. debugging support was removed.
1679         * MAINTAINERS: Remove spu target.
1680
1681         * config/djgpp/fnchange.lst: Remove entries for removed files.
1682
1683         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1684         spu-multiarch.o, and spu-tdep.o.
1685         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1686         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1687         spu-multiarch.c, and spu-tdep.c.
1688         * spu-linux-nat.c: Remove file.
1689         * spu-multiarch.c: Remove file.
1690         * spu-tdep.c: Remove file.
1691         * spu-tdep.h: Remove file.
1692         * solib-spu.c: Remove file.
1693         * solib-spu.h: Remove file.
1694
1695         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1696         * configure.nat (spu-linux): Remove.
1697         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1698         solib-multiarch.o from gdb_target_obs.
1699         (spu*-*-*): Remove.
1700
1701         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1702         feature flag.
1703         (ppc_linux_no_features): Update.
1704         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1705         Cell/B.E. support.
1706         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1707         (tdesc_powerpc_cell64l): Likewise.
1708         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1709         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1710         Cell/B.E. support.
1711         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1712         Do not include "features/rs6000/powerpc-cell32l.c" or
1713         "features/rs6000/powerpc-cell64l.c".
1714         (ppc_linux_spu_section): Remove.
1715         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1716         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1717         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1718         (ppc_linux_spe_context_lookup): Remove.
1719         (ppc_linux_spe_context_inferior_created): Remove.
1720         (ppc_linux_spe_context_solib_loaded): Remove.
1721         (ppc_linux_spe_context_solib_unloaded): Remove.
1722         (ppc_linux_spe_context): Remove.
1723         (struct ppu2spu_cache): Remove.
1724         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1725         (struct ppu2spu_data): Remove.
1726         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1727         ppu2spu_unwind): Remove.
1728         (ppc_linux_init_abi): Remove Cell/B.E. support.
1729         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1730
1731         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1732         (rs6000/powerpc-cell64l-expedite): Likewise
1733         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1734         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1735         rs6000/powerpc-cell64l.xml.
1736         * features/rs6000/powerpc-cell32l.xml: Remove.
1737         * features/rs6000/powerpc-cell64l.xml: Likewise.
1738         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1739         * features/rs6000/powerpc-cell64l.c: Likewise.
1740         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1741         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1742         * regformats/reg-spu.dat: Remove.
1743
1744         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1745         * corelow.c (struct spuid_list): Remove.
1746         (add_to_spuid_list): Remove.
1747         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1748         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1749         (remote_protocol_features): Remove associated entries.
1750         (_initialize_remote): No longer initialize them.
1751         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1752         * linux-nat.c (SPUFS_MAGIC): Remove.
1753         (linux_proc_xfer_spu): Remove.
1754         (spu_enumerate_spu_ids): Remove.
1755         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1756         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1757         (linux_make_corefile_notes): No longer call it.
1758
1759         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1760         (cooked_write_test): Likewise.
1761
1762 2019-09-20  Tom Tromey  <tom@tromey.com>
1763
1764         * NEWS: Mention case-sensitivity of TUI commands.
1765         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1766         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1767         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1768
1769 2019-09-20  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-source.c (tui_source_window::set_contents): Use
1772         make_unique_xstrdup.
1773         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1774         make_unique_xstrdup.
1775
1776 2019-09-20  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-data.c: Remove separator comments.
1779         * tui/tui-layout.c: Remove separator comments.
1780         * tui/tui-win.c: Remove separator comments.
1781         * tui/tui-wingeneral.c: Remove separator comments.
1782
1783 2019-09-20  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui.h (strcat_to_buf): Don't declare.
1786         * tui/tui.c (strcat_to_buf): Remove.
1787
1788 2019-09-20  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1791         from "fullname".
1792         * tui/tui-source.c (tui_source_window::set_contents)
1793         (tui_source_window::location_matches_p)
1794         (tui_source_window::maybe_update): Update.
1795
1796 2019-09-20  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1799         Update.
1800         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1801         prefix.
1802         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1803         (tui_data_window::line_from_reg_element_no)
1804         (tui_data_window::first_reg_element_no_inline)
1805         (tui_data_window::show_registers)
1806         (tui_data_window::show_register_group)
1807         (tui_data_window::display_registers_from)
1808         (tui_data_window::display_registers_from_line)
1809         (tui_data_window::first_data_item_displayed)
1810         (tui_data_window::delete_data_content_windows)
1811         (tui_data_window::erase_data_content)
1812         (tui_data_window::do_scroll_vertical)
1813         (tui_data_window::refresh_window)
1814         (tui_data_window::check_register_values): Update.
1815
1816 2019-09-20  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1819         (struct tui_locator_window) <full_name, proc_name>: Now
1820         std::string.
1821         * tui/tui-stack.c (tui_locator_window::make_status_line)
1822         (tui_locator_window::set_locator_fullname)
1823         (tui_locator_window::set_locator_info): Update.
1824         * tui/tui-source.c (tui_source_window::set_contents)
1825         (tui_source_window::showing_source_p): Update.
1826
1827 2019-09-20  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1830         Don't call tui_locator_win_info_ptr.
1831
1832 2019-09-20  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1835
1836 2019-09-20  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1839         height for locator.
1840         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1841         * tui/tui-layout.c (show_source_disasm_command, show_data)
1842         (show_source_or_disasm_and_command): Use 1 as height for locator.
1843
1844 2019-09-20  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui.c (tui_enable): Update.
1847         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1848         Update.
1849         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1850         Update.
1851         * tui/tui-data.c (win_resized): Now bool.
1852         (tui_win_resized): Return bool.
1853         (tui_set_win_resized_to): Accept a bool.
1854
1855 2019-09-20  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1858         Change type of "refresh_values_only".
1859         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1860         type of "refresh_values_only".
1861
1862 2019-09-20  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1865         std::string.
1866         (tui_disassemble): Add "pos" parameter.
1867         (tui_disasm_window::set_contents): Simplify.
1868
1869 2019-09-20  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-winsource.h (struct tui_source_window_base)
1872         <show_source_content>: Now private.
1873         * tui/tui-winsource.c
1874         (tui_source_window_base::show_source_content): Don't handle empty
1875         content case.
1876
1877 2019-09-20  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-layout.c (show_source_disasm_command)
1880         (show_source_or_disasm_and_command): Don't call
1881         show_source_content.
1882
1883 2019-09-20  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1886         Declare.
1887         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1888         from tui_make_status_line.
1889         (tui_locator_window::rerender): Update.
1890
1891 2019-09-20  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1894         (tui_locator_window::rerender): Update.
1895
1896 2019-09-20  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.h (struct tui_source_window_base)
1899         <~tui_source_window_base>: Don't declare.
1900         <fullname>: Remove.
1901         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1902         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1903         member.
1904         * tui/tui-source.c (tui_source_window::set_contents): Update.
1905         (tui_source_window::location_matches_p)
1906         (tui_source_window::maybe_update): Update.
1907
1908 2019-09-20  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-winsource.h (~tui_source_element): Remove.
1911         (tui_source_element): Update.
1912         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1913         * tui/tui-winsource.c (tui_show_source_line): Update.
1914         * tui/tui-source.c (tui_source_window::set_contents): Update.
1915         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1916
1917 2019-09-20  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1920         declare.
1921         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1922         tui_clear_source_windows_detail.
1923         * tui/tui-winsource.h (struct tui_source_window_base)
1924         <clear_detail>: Don't declare.
1925         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1926         Remove.
1927         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1928
1929 2019-09-20  Tom Tromey  <tromey@adacore.com>
1930
1931         PR ada/24919:
1932         * block.c (contained_in): Fix final return value.
1933
1934 2019-09-20  Alan Modra  <amodra@gmail.com>
1935
1936         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1937         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1938         (read_indirect_string_from_dwz): Use bfd accessor.
1939         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1940         * machoread.c (macho_symfile_read_all_oso): Likewise.
1941         * solib.c (solib_bfd_open): Likewise.
1942
1943 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1944
1945         * eval.c: Move declaration of overload_resolution to...
1946         * value.h: ...here.
1947
1948 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1949
1950         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1951         * arm-linux-tdep.c: Likewise.
1952         * arm-nbsd-nat.c: Likewise.
1953         * arm-tdep.h: Declare arm_apcs_32.
1954         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1955
1956 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1957
1958         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1959         * dwarf2read.h: Declare dwarf_always_disassemble.
1960
1961 2019-09-19  Tom de Vries  <tdevries@suse.de>
1962
1963         PR gdb/25009
1964         * source-cache.c (source_cache::ensure): Catch exception thrown during
1965         construction of the highlighter.
1966
1967 2019-09-18  Alan Modra  <amodra@gmail.com>
1968
1969         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1970         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1971         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1972         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1973         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1974         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1975         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1976         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1977         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1978         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1979         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1980         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1981         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1982         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1983         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1984         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1985         * mi/mi-interp.c: Update throughout for bfd section macro and
1986         function changes.
1987         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1988         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1989
1990 2019-09-18  Tom Tromey  <tom@tromey.com>
1991
1992         * NEWS: Add entry.
1993         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1994         call rl_initialize.
1995         (tui_enable): Do not call rl_initialize.
1996
1997 2019-09-18  Christian Groessler  <chris@groessler.org>
1998
1999         * alpha-linux-nat.c: Include gdbarch.h.
2000
2001 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2002
2003         * ui-file.c: Include cli/cli-style.h.
2004         (term_cli_styling): Remove cli_styling declaration.
2005
2006 2019-09-18  Alan Modra  <amodra@gmail.com>
2007
2008         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2009         to bfd_asymbol_section.
2010
2011 2019-09-18  Alan Modra  <amodra@gmail.com>
2012
2013         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2014         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2015         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2016
2017 2019-09-18  Alan Modra  <amodra@gmail.com>
2018
2019         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2020         * spu-linux-nat.c (spu_bfd_open): Likewise.
2021
2022 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2023
2024         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2025         to bool to match definition in dwarf2read.c.
2026
2027 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2028
2029         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2030         (print_signatures): Likewise.
2031         (trust_pad_over_xvs): Likewise.
2032         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2033         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2034         * arm-linux-nat.c (arm_apcs_32): Likewise.
2035         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2036         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2037         * arm-tdep.c (arm_debug): Likewise.
2038         (arm_apcs_32): Likewise.
2039         * auto-load.c (debug_auto_load): Likewise.
2040         (auto_load_gdb_scripts): Likewise.
2041         (global_auto_load): Likewise.
2042         (auto_load_local_gdbinit): Likewise.
2043         (auto_load_local_gdbinit_loaded): Likewise.
2044         * auto-load.h (global_auto_load): Likewise.
2045         (auto_load_local_gdbinit): Likewise.
2046         (auto_load_local_gdbinit_loaded): Likewise.
2047         * breakpoint.c (disconnected_dprintf): Likewise.
2048         (breakpoint_proceeded): Likewise.
2049         (automatic_hardware_breakpoints): Likewise.
2050         (always_inserted_mode): Likewise.
2051         (target_exact_watchpoints): Likewise.
2052         (_initialize_breakpoint): Update.
2053         * breakpoint.h (target_exact_watchpoints): Change to bool.
2054         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2055         * cli/cli-cmds.c (trace_commands): Likewise.
2056         * cli/cli-cmds.h (trace_commands): Likewise.
2057         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2058         to bool*.
2059         * cli/cli-logging.c (logging_overwrite): Change to bool.
2060         (logging_redirect): Likewise.
2061         (debug_redirect): Likewise.
2062         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2063         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2064         to bool.
2065         <boolean_option_def>: Update.
2066         (struct flag_option_def): Change default type of Context to bool
2067         from int.
2068         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2069         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2070         (get_setshow_command_value_string): Likewise.
2071         * cli/cli-style.c (cli_styling): Change to bool.
2072         (source_styling): Likewise.
2073         * cli/cli-style.h (source_styling): Likewise.
2074         (cli_styling): Likewise.
2075         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2076         to bool.
2077         * command.h (var_types): Update comment.
2078         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2079         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2080         bool.
2081         (debug_compile_cplus_scopes): Likewise.
2082         * compile/compile-internal.h (compile_debug): Likewise.
2083         * compile/compile.c (compile_debug): Likewise.
2084         (struct compile_options) <raw>: Likewise.
2085         * cp-support.c (catch_demangler_crashes): Likewise.
2086         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2087         (usr_cmd_cris_dwarf2_cfi): Likewise.
2088         * csky-tdep.c (csky_debug): Likewise.
2089         * darwin-nat.c (enable_mach_exceptions): Likewise.
2090         * dcache.c (dcache_enabled_p): Likewise.
2091         * defs.h (info_verbose): Likewise.
2092         * demangle.c (demangle): Likewise.
2093         (asm_demangle): Likewise.
2094         * dwarf-index-cache.c (debug_index_cache): Likewise.
2095         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2096         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2097         * dwarf2read.c (check_physname): Likewise.
2098         (use_deprecated_index_sections): Likewise.
2099         (dwarf_always_disassemble): Likewise.
2100         * eval.c (overload_resolution): Likewise.
2101         * event-top.c (set_editing_cmd_var): Likewise.
2102         (exec_done_display_p): Likewise.
2103         * event-top.h (set_editing_cmd_var): Likewise.
2104         (exec_done_display_p): Likewise.
2105         * exec.c (write_files): Likewise.
2106         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2107         (debug_fbsd_nat): Likewise.
2108         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2109         Likewise.
2110         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2111         <backtrace_past_entry> Likewise.
2112         * gdb-demangle.h (demangle): Likewise.
2113         (asm_demangle): Likewise.
2114         * gdb_bfd.c (bfd_sharing): Likewise.
2115         * gdbcore.h (write_files): Likewise.
2116         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2117         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2118         * gdbthread.h (print_thread_events): Likewise.
2119         * gdbtypes.c (opaque_type_resolution): Likewise.
2120         (strict_type_checking): Likewise.
2121         * gnu-nat.c (gnu_debug_flag): Likewise.
2122         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2123         * guile/scm-param.c (pascm_variable): Add boolval.
2124         (add_setshow_generic): Update.
2125         (pascm_param_value): Update.
2126         (pascm_set_param_value_x): Update.
2127         * hppa-tdep.c (hppa_debug): Change to bool..
2128         * infcall.c (may_call_functions_p): Likewise.
2129         (coerce_float_to_double_p): Likewise.
2130         (unwind_on_signal_p): Likewise.
2131         (unwind_on_terminating_exception_p): Likewise.
2132         * infcmd.c (startup_with_shell): Likewise.
2133         * inferior.c (print_inferior_events): Likewise.
2134         * inferior.h (startup_with_shell): Likewise.
2135         (print_inferior_events): Likewise.
2136         * infrun.c (step_stop_if_no_debug): Likewise.
2137         (detach_fork): Likewise.
2138         (debug_displaced): Likewise.
2139         (disable_randomization): Likewise.
2140         (non_stop): Likewise.
2141         (non_stop_1): Likewise.
2142         (observer_mode): Likewise.
2143         (observer_mode_1): Likewise.
2144         (set_observer_mode): Update.
2145         (sched_multi): Change to bool.
2146         * infrun.h (debug_displaced): Likewise.
2147         (sched_multi): Likewise.
2148         (step_stop_if_no_debug): Likewise.
2149         (non_stop): Likewise.
2150         (disable_randomization): Likewise.
2151         * linux-tdep.c (use_coredump_filter): Likewise.
2152         (dump_excluded_mappings): Likewise.
2153         * linux-thread-db.c (auto_load_thread_db): Likewise.
2154         (check_thread_db_on_load): Likewise.
2155         * main.c (captured_main_1): Update.
2156         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2157         xx2_opt, boolean_opt>: Change to bool.
2158         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2159         * maint.c (maintenance_profile_p): Likewise.
2160         (per_command_time): Likewise.
2161         (per_command_space): Likewise.
2162         (per_command_symtab): Likewise.
2163         * memattr.c (inaccessible_by_default): Likewise.
2164         * mi/mi-main.c (mi_async): Likewise.
2165         (mi_async_1): Likewise.
2166         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2167         * nat/fork-inferior.h (startup_with_shell): Likewise.
2168         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2169         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2170         * nios2-tdep.c (nios2_debug): Likewise.
2171         * or1k-tdep.c (or1k_debug): Likewise.
2172         * parse.c (parser_debug): Likewise.
2173         * parser-defs.h (parser_debug): Likewise.
2174         * printcmd.c (print_symbol_filename): Likewise.
2175         * proc-api.c (procfs_trace): Likewise.
2176         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2177         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2178         (set_parameter_value): Update.
2179         (add_setshow_generic): Update.
2180         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2181         to bool*.
2182         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2183         int*.
2184         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2185         * record-btrace.c (record_btrace_target::store_registers): Update.
2186         * record-full.c (record_full_memory_query): Change to bool.
2187         (record_full_stop_at_limit): Likewise.
2188         * record-full.h (record_full_memory_query): Likewise.
2189         * remote-notif.c (notif_debug): Likewise.
2190         * remote-notif.h (notif_debug): Likewise.
2191         * remote.c (use_range_stepping): Likewise.
2192         (interrupt_on_connect): Likewise.
2193         (remote_break): Likewise.
2194         * ser-tcp.c (tcp_auto_retry): Likewise.
2195         * ser-unix.c (serial_hwflow): Likewise.
2196         * skip.c (debug_skip): Likewise.
2197         * solib-aix.c (solib_aix_debug): Likewise.
2198         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2199         (spu_auto_flush_cache_p): Likewise.
2200         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2201         Likewise.
2202         (struct info_print_options) <quiet>: Likewise.
2203         * symfile-debug.c (debug_symfile): Likewise.
2204         * symfile.c (auto_solib_add): Likewise.
2205         (separate_debug_file_debug): Likewise.
2206         * symfile.h (auto_solib_add): Likewise.
2207         (separate_debug_file_debug): Likewise.
2208         * symtab.c (basenames_may_differ): Likewise.
2209         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2210         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2211         (struct info_types_options) <quiet>: Likewise.
2212         * symtab.h (demangle): Likewise.
2213         (basenames_may_differ): Likewise.
2214         * target-dcache.c (stack_cache_enabled_1): Likewise.
2215         (code_cache_enabled_1): Likewise.
2216         * target.c (trust_readonly): Likewise.
2217         (may_write_registers): Likewise.
2218         (may_write_memory): Likewise.
2219         (may_insert_breakpoints): Likewise.
2220         (may_insert_tracepoints): Likewise.
2221         (may_insert_fast_tracepoints): Likewise.
2222         (may_stop): Likewise.
2223         (auto_connect_native_target): Likewise.
2224         (target_stop_and_wait): Update.
2225         (target_async_permitted): Change to bool.
2226         (target_async_permitted_1): Likewise.
2227         (may_write_registers_1): Likewise.
2228         (may_write_memory_1): Likewise.
2229         (may_insert_breakpoints_1): Likewise.
2230         (may_insert_tracepoints_1): Likewise.
2231         (may_insert_fast_tracepoints_1): Likewise.
2232         (may_stop_1): Likewise.
2233         * target.h (target_async_permitted): Likewise.
2234         (may_write_registers): Likewise.
2235         (may_write_memory): Likewise.
2236         (may_insert_breakpoints): Likewise.
2237         (may_insert_tracepoints): Likewise.
2238         (may_insert_fast_tracepoints): Likewise.
2239         (may_stop): Likewise.
2240         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2241         (make_thread_apply_all_options_def_group): Change argument from int*
2242         to bool*.
2243         (thread_apply_all_command): Update.
2244         (print_thread_events): Change to bool.
2245         * top.c (confirm): Likewise.
2246         (command_editing_p): Likewise.
2247         (history_expansion_p): Likewise.
2248         (write_history_p): Likewise.
2249         (info_verbose): Likewise.
2250         * top.h (confirm): Likewise.
2251         (history_expansion_p): Likewise.
2252         * tracepoint.c (disconnected_tracing): Likewise.
2253         (circular_trace_buffer): Likewise.
2254         * typeprint.c (print_methods): Likewise.
2255         (print_typedefs): Likewise.
2256         * utils.c (debug_timestamp): Likewise.
2257         (sevenbit_strings): Likewise.
2258         (pagination_enabled): Likewise.
2259         * utils.h (sevenbit_strings): Likewise.
2260         (pagination_enabled): Likewise.
2261         * valops.c (overload_resolution): Likewise.
2262         * valprint.h (struct value_print_options) <prettyformat_arrays,
2263         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2264         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2265         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2266         Likewise.
2267         * windows-nat.c (new_console): Likewise.
2268         (cygwin_exceptions): Likewise.
2269         (new_group): Likewise.
2270         (debug_exec): Likewise.
2271         (debug_events): Likewise.
2272         (debug_memory): Likewise.
2273         (debug_exceptions): Likewise.
2274         (useshell): Likewise.
2275         * windows-tdep.c (maint_display_all_tib): Likewise.
2276         * xml-support.c (debug_xml): Likewise.
2277
2278 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2279
2280         * source.c (prepare_path_for_appending): New function.
2281         (openp): Make use of new function.
2282         (find_and_open_source): Search for the compilation directory and
2283         source file as a relative path beneath the directory search path.
2284
2285 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * source-cache.c (source_cache::get_line_charpos): Catch
2288         exceptions and return false, this matches the behaviour documented
2289         in the header file.
2290
2291 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2292
2293         * ada-tasks.c (info_task): Remove quoting of the task's name.
2294
2295 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2296
2297         * symfile.c (auto_solib_add): Replace comment with a reference
2298         to the header file.
2299
2300 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2301
2302         * NEWS: Mention that gdb can now be compiled with Python 3
2303         on Windows.
2304
2305 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * maint.c (maint_print_section_data::maint_print_section_data):
2308         Force use of 'float log10 (float)' by casting the argument to
2309         float.
2310
2311 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2312
2313         * maint.c: Add 'cmath' include.
2314         (struct maint_print_section_data): New structure.
2315         (print_section_index): New function.
2316         (print_bfd_section_info): Add header comment, small whitespace
2317         cleanup, and update to call new print_section_index function.
2318         (print_objfile_section_info): Likewise.
2319         (maint_obj_section_from_bfd_section): New function.
2320         (print_bfd_section_info_maybe_relocated): New function.
2321         (maintenance_info_sections): Add header comment, always use
2322         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2323
2324 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2327         inner scope, add check that the objfile has psymtabs before
2328         checking psymtabs_addrmap.
2329         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2330
2331 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * NEWS: Announce that Ada task names are now shown at more places,
2334         and between quotes (except in info task output).
2335         * gdb/ada-tasks.c (task_to_str): New function.
2336         (display_current_task_id): Call task_to_str.
2337         (task_command_1): Likewise.
2338         (print_ada_task_info): In non-mi mode, Properly align headers and data
2339         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2340
2341 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2342
2343         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2344         prstatus.pr_lwp.pr_info instead of making it up.
2345
2346 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2347
2348         * auto-load.c (auto_load_expand_dir_vars): Update.
2349         * defs.h (gdb_datadir): Change to std::string.
2350         (python_libdir): Likewise.
2351         (relocate_gdb_directory): Change return type to std::string.
2352         * guile/guile.c (gdbscm_data_directory): Update.
2353         (initialize_scheme_side): Update.
2354         * jit.c (jit_reader_dir): Change to std::string.
2355         (jit_reader_load_command): Update.
2356         * main.c (gdb_datadir): Change to std::string.
2357         (python_libdir): Likewise.
2358         (set_gdb_data_directory): Update.
2359         (relocate_path): Change to return std::string.
2360         (relocate_gdb_directory): Change to return std::string.
2361         (relocate_gdbinit_path_maybe_in_datadir): Update.
2362         (captured_main_1): Update.
2363         * python/python.c (do_start_initialization): Update.
2364         * top.c (show_gdb_datadir): Update.
2365         * xml-syscall.c (xml_init_syscalls_info): Update.
2366         (init_syscalls_info): Update.
2367
2368 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2369
2370         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2371         out of get_init_files.
2372         (get_init_files): Update.
2373
2374 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2375
2376         * main.c (get_init_files): Change to use std::string.
2377         (captured_main_1): Update.
2378         (print_gdb_help): Update.
2379
2380 2019-09-11  Ali Tamur  <tamur@google.com>
2381
2382         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2383         implementation.
2384
2385 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2386
2387         * dbxread.c (read_dbx_symtab): Update.
2388         * dwarf2read.c (load_partial_dies): Update.
2389         * mdebugread.c (parse_partial_symbols): Update.
2390         (handle_psymbol_enumerators): Update.
2391         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2392         * psymtab.c (add_psymbol_to_bcache): Likewise.
2393         (add_psymbol_to_list): Likewise.
2394         * symtab.c (symbol_set_names): Likewise.
2395         * symtab.h (symbol_set_names): Likewise.
2396         * xcoffread.c (scan_xcoff_symtab): Update.
2397
2398 2019-09-11  Tom Tromey  <tom@tromey.com>
2399
2400         * symfile-mem.c (symbol_file_add_from_memory): Use
2401         bfd_set_filename.
2402         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2403         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2404
2405 2019-09-10  Tom Tromey  <tromey@adacore.com>
2406
2407         * dwarf-index-write.c (write_psymbols): Extend error message.
2408         (debug_names::insert): Add Ada code.
2409         (debug_names::write_psymbols): Remove Ada check.
2410         (debug_names) <m_string_obstack>: New member.
2411         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2412         (gdb_index_symbol_name_matcher::matches): Remove.
2413         (mapped_index_base::find_name_components_bounds): Add "lang"
2414         parameter.
2415         (mapped_index_base::build_name_components): Also split names
2416         according to Ada syntax.
2417         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2418         type of "match_callback".
2419         (check_match, check_find_bounds_finds)
2420         (dw2_expand_symtabs_matching): Update.
2421         (dw2_debug_names_iterator): Add new constructor.
2422         (dw2_debug_names_map_matching_symbols): New function.
2423         (dw2_debug_names_expand_symtabs_matching): Update.
2424         (dwarf2_debug_names_functions): Use
2425         dw2_debug_names_map_matching_symbols.
2426
2427 2019-09-10  Tom Tromey  <tromey@adacore.com>
2428
2429         * dwarf2read.c (dw2_get_file_names_reader): Add the
2430         CU's file name to the results.
2431
2432 2019-09-10  Tom Tromey  <tromey@adacore.com>
2433
2434         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2435         map_matching_symbols.  Update.
2436         * dwarf2read.c (dw2_map_matching_symbols): Update.
2437         * psymtab.c (match_partial_symbol): Change type; update.
2438         (psym_map_matching_symbols): Likewise.
2439         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2440         type; update.
2441         * symfile.h (struct quick_symbol_functions)
2442         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2443         Remove "match".
2444
2445 2019-09-10  Tom Tromey  <tromey@adacore.com>
2446
2447         * psymtab.c (map_block): Remove.
2448         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2449         * symtab.c (iterate_over_symbols_terminated): New function.
2450         * symtab.c (iterate_over_symbols_terminated): Declare.
2451
2452 2019-09-10  Tom Tromey  <tromey@adacore.com>
2453
2454         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2455         * language.h (struct language_defn) <la_iterate_over_symbols>:
2456         Return bool.
2457         * symtab.c (iterate_over_symbols): Return bool.
2458         * symtab.h (iterate_over_symbols): Return bool.
2459
2460 2019-09-10  Tom Tromey  <tromey@adacore.com>
2461
2462         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2463         (add_nonlocal_symbols): Update.
2464         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2465         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2466         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2467         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2468         Change type of "callback".  Remove "data".
2469
2470
2471 2019-09-09  Ali Tamur  <tamur@google.com>
2472
2473         * dwarf2read.c (comp_unit_head): Update comment.
2474         (dwarf2_dwo_name): New function declaration.
2475         (dwarf_unit_type_name): New function declaration.
2476         (read_comp_unit_head): Add support for new compilation units,
2477         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2478         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2479         (currently named as "signature") in their header. Also clarify error
2480         messages.
2481         (lookup_dwo_id): New function. Returns the dwo id of the given
2482         compile unit.
2483         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2484         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2485         functions.
2486         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2487         (dwarf2_dwo_name): Get the dwo name if present.
2488         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2489         purposes.
2490
2491 2019-09-09  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2494
2495 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2496
2497         * python/python.c (do_start_initialization): Make progname_copy static,
2498         to avoid a leak report.
2499
2500 2019-09-08  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2503
2504 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2505
2506         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2507         Change type to gdb::optional<block_enum>.
2508         (dw2_symtab_iter_init): Change block_index parameter type
2509         to gdb::optional<block_enum>.
2510         (dw2_lookup_symbol): Change block_index parameter
2511         type to block_enum.c
2512         (dw2_debug_names_lookup_symbol): Likewise.
2513         * psymtab.c (psym_lookup_symbol): Likewise.
2514         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2515         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2516         Likewise.
2517
2518 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2519
2520         * defs.h (relocate_gdb_directory): Change int to bool in
2521         signature and rename flag to relocatable.
2522         * main.c (relocate_path): Likewise.
2523         (relocate_gdb_directory): Likewise.
2524
2525 2019-09-06  Alan Modra  <amodra@gmail.com>
2526
2527         * coffread.c (coff_symfile_read): Constify filename variable.
2528         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2529         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2530         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2531         * solib.c (reload_shared_libraries_1): Likewise.
2532         * symfile.c (reread_symbols): Likewise.
2533         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2534         * solib-darwin.c (darwin_bfd_open): Likewise.
2535         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2536
2537 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2540         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2541
2542 2019-09-03  Tom Tromey  <tromey@adacore.com>
2543
2544         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2545         types.
2546         (has_negatives): Unbias a range type bound.
2547         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2548         * gdbtypes.c (operator==): Handle new field.
2549         (create_range_type): Add "bias" parameter.
2550         (create_static_range_type, resolve_dynamic_range): Update.
2551         * gdbtypes.h (struct range_bounds) <bias>: New member.
2552         (create_range_type): Add bias parameter.
2553         * printcmd.c (print_scalar_formatted): Unbias range types.
2554         * value.c (unpack_long): Unbias range types.
2555         (pack_long): Bias range types.
2556
2557 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2558
2559         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2560         probe arguments.
2561
2562 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2563
2564         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2565         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2566         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2567         (compile_probe_arg): Likewise.
2568         * probe.h (get_argument_count): Likewise.
2569         * solib-svr4.c (solib_event_probe_action): Likewise.
2570         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2571
2572 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2575         code to here...
2576         (svr4_create_solib_event_breakpoints): ...from here.
2577
2578 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2579
2580         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2581         suffix from warning message.
2582
2583 2019-08-30  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-winsource.h (struct tui_source_window_base)
2586         <refresh_all>: Don't declare.
2587         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2588         Remove.
2589         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2590         tui_show_locator_content.
2591         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2592         declare.
2593         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2594         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2595         declare.
2596
2597 2019-08-30  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2600
2601 2019-08-30  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2604         Remove unnecessary forward declarations.
2605
2606 2019-08-30  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2609         rerender.
2610         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2611         tui_show_locator_content.
2612
2613 2019-08-30  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2616         (tui_locator_window::rerender): Rewrite using body of previous
2617         tui_show_locator_content.
2618
2619 2019-08-30  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2622         set_locator_fullname>: New methods.
2623         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2624         Rename from tui_set_locator_fullname.
2625         (tui_locator_window::set_locator_info): Rename from
2626         tui_set_locator_info.  Return bool.
2627         (tui_update_locator_fullname, tui_show_frame_info): Update.
2628
2629 2019-08-30  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2632
2633 2019-08-30  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2636         call touchwin.
2637
2638 2019-08-30  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-wingeneral.c (box_win): Assume win_info and
2641         win_info->handle cannot be NULL.
2642
2643 2019-08-30  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2646         refresh_window>: Declare.
2647         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2648         resize.
2649         (tui_data_item_window::rerender): Rename from
2650         tui_display_register.
2651         (tui_data_item_window::refresh_window): New method.
2652         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2653         no-op.
2654
2655 2019-08-30  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2658         regs_column_count, current_group>: Move later.  Now private.
2659         <get_current_group>: New method.
2660         * tui/tui-regs.c (tui_reg_command): Update.
2661         * tui/tui-layout.c (tui_set_layout): Update.
2662
2663 2019-08-30  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2666         (tui_data_window::rerender): Don't call
2667         check_and_display_highlight_if_needed.
2668         (tui_data_window::refresh_all): Remove call to
2669         erase_data_content.
2670
2671 2019-08-30  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2674         (tui_data_window::display_registers_from)
2675         (tui_data_window::display_reg_element_at_line)
2676         (tui_data_window::display_registers_from_line): Remove checks of
2677         "empty".
2678
2679 2019-08-30  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2682         Don't declare.
2683         * tui/tui-regs.c (tui_data_window::show_registers): Call
2684         rerender.
2685         (tui_data_window::rerender): Rename from display_all_data.
2686         (tui_data_window::rerender): Remove old implementation.
2687
2688 2019-08-30  Tom Tromey  <tom@tromey.com>
2689
2690         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2691         text.
2692         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2693
2694 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2695             Sergio Durigan Junior  <sergiodj@redhat.com>
2696
2697         PR win32/24284
2698         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2699
2700 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2703         when searching for types.
2704
2705 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * f-lang.c (f_language_defn): Use f_print_typedef.
2708         * f-lang.h (f_print_typedef): Declare.
2709         * f-typeprint.c (f_print_typedef): Define.
2710
2711 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2712
2713         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2714
2715 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * cli/cli-utils.c (info_print_options_defs): Delete.
2718         (make_info_print_options_def_group): Delete.
2719         (extract_info_print_options): Delete.
2720         (info_print_command_completer): Delete.
2721         (info_print_args_help): Add extra parameter, and optionally
2722         include text about -n flag.
2723         * cli/cli-utils.h (struct info_print_options): Delete.
2724         (extract_info_print_options): Delete declaration.
2725         (info_print_command_completer): Delete declaration.
2726         (info_print_args_help): Add extra parameter, extend header
2727         comment.
2728         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2729         search_symbols.
2730         * stack.c (struct info_print_options): New type.
2731         (info_print_options_defs): New file scoped variable.
2732         (make_info_print_options_def_group): New static function.
2733         (info_print_command_completer): New static function.
2734         (info_locals_command): Update to use new local functions.
2735         (info_args_command): Likewise.
2736         (_initialize_stack): Add extra parameter to calls to
2737         info_print_args_help.
2738         * symtab.c (search_symbols): Add extra parameter, use this to
2739         possibly excluse non-debug symbols.
2740         (symtab_symbol_info): Add extra parameter, which is passed on to
2741         search_symbols.
2742         (struct info_print_options): New type.
2743         (info_print_options_defs): New file scoped variable.
2744         (make_info_print_options_def_group): New static function.
2745         (info_print_command_completer): New static function.
2746         (info_variables_command): Update to use local functions, and pass
2747         extra parameter through to symtab_symbol_info.
2748         (info_functions_command): Likewise.
2749         (info_types_command): Pass additional argument through to
2750         symtab_symbol_info.
2751         (rbreak_command): Pass extra argument to search_symbols.
2752         (_initialize_symtab): Add extra arguments for calls to
2753         info_print_args_help, and update help text for 'info variables',
2754         'whereis', and 'info functions' commands.
2755         * symtab.h (search_symbols): Add extra argument to declaration.
2756         * NEWS: Mention new flags.
2757
2758 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2759
2760         * symtab.c (lookup_static_symbol): Call the new function (and move
2761         it down to be next to lookup_global_symbol).
2762         (struct global_sym_lookup_data): Add block_enum member and rename to...
2763         (struct global_or_static_sym_lookup_data): ...this.
2764         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2765         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2766         (lookup_symbol_global_or_static_iterator_cb): ...this.
2767         (lookup_global_or_static_symbol): New function.
2768         (lookup_global_symbol): Call new function.
2769
2770 2019-08-26  Tom de Vries  <tdevries@suse.de>
2771
2772         PR c++/24852
2773         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2774         when pc_probe.prob == NULL.
2775
2776 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2777
2778         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2779         variable symbol_linkage to symbol_linkage_.
2780
2781 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2782
2783         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2784         represent whether the symbol is static, dynamic, or we don't
2785         know.
2786
2787 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2788
2789         * gdb/rx-tdep.c (rx_register_names): New.
2790         (rx_register_name): Delete.
2791         (rx_psw_type): Delete.
2792         (rx_fpsw_type): Delete.
2793         (rx_register_type): Delete.
2794         (rx_gdbarch_init): Convert target-descriptions.
2795         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2796         * gdb/features/Makefile: Add rx.xml.
2797         * gdb/features/rx.xml: New.
2798         * gdb/features/rx.c: Generated.
2799         * gdb/NEWS: Mention target description support.
2800
2801 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2802
2803         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2804         *slot_ptr.
2805
2806 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2807
2808         * configure.ac: Don't check for 'dlfcn.h' (moved to
2809         gdbsupport/common.m4).
2810         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2811         'gdbsupport/'.
2812         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2813         * compile/compile-c-support.c: Include
2814         'gdbsupport/gdb-dlfcn.h'.
2815         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2816         * gdb-dlfcn.c: Move to...
2817         * gdbsupport/gdb-dlfcn.c: ... here.
2818         * gdb-dlfcn.h: Move to...
2819         * gdbsupport/gdb-dlfcn.h: ... here.
2820
2821 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2822
2823         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2824         the offset field signed.
2825
2826 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2827
2828         * python/lib/gdb/__init__.py (_execute_file): New function.
2829         * python/python.c (python_run_simple_file): Call gdb._execute_file
2830         on Windows.
2831
2832 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2835         all uses as this was never set to anything but a zero value.
2836
2837 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2838
2839         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2840
2841 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2842
2843         * tui/tui-data.h (tui_gen_win_info): Add an =default
2844         move constructor, required by some GCC versions.
2845
2846 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2847
2848         * go32-nat.c (go32_sysinfo): Add hygon_p.
2849
2850 2019-08-20  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2853         line_from_reg_element_no, first_reg_element_no_inline,
2854         display_all_data, delete_data_content_windows,
2855         erase_data_content>: Now private.
2856
2857 2019-08-20  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2860         (tui_unhighlight_win, tui_highlight_win)
2861         (tui_win_info::make_window): Update.
2862         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2863
2864 2019-08-20  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2867         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2868         (MAX_PID_WIDTH): Move to tui-stack.c.
2869         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2870         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2871         (MAX_PID_WIDTH): Move from tui-data.h.
2872
2873 2019-08-20  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2876         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2877         (box_win): Update.
2878         (tui_gen_win_info::make_window): Rename from tui_make_window.
2879         (tui_win_info::make_window): New method.
2880         (tui_gen_win_info::make_visible): Update.
2881         * tui/tui-source.c (tui_source_window::set_contents): Update.
2882         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2883         (tui_data_window::display_registers_from): Update.
2884         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2885         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2886         Declare.
2887         <can_box>: Remove.
2888         <title>: Remove.
2889         (struct tui_win_info) <make_window>: Declare.
2890         <can_box>: Now virtual.
2891         <title>: New member.
2892         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2893         * tui/tui-command.c (tui_cmd_window::resize): Update.
2894
2895 2019-08-20  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2898         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2899         (tui_data_window::check_register_values): Update.
2900
2901 2019-08-20  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-regs.h (struct tui_data_window): Use
2904         DISABLE_COPY_AND_ASSIGN.
2905         <regs_content>: Change type, removing unique_ptr.
2906         <tui_data_window>: Add move constructor.
2907         * tui/tui-regs.c (tui_data_window::show_registers)
2908         (tui_data_window::show_register_group)
2909         (tui_data_window::display_registers_from)
2910         (tui_data_window::display_registers_from)
2911         (tui_data_window::first_data_item_displayed)
2912         (tui_data_window::delete_data_content_windows)
2913         (tui_data_window::rerender, tui_data_window::refresh_window)
2914         (tui_data_window::check_register_values): Update.
2915
2916 2019-08-20  Tom Tromey  <tom@tromey.com>
2917
2918         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2919         show_register_group>: Declare.
2920         (tui_show_register_group): Don't declare.
2921         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2922         tui_show_registers.
2923         (tui_data_window::show_register_group): Rename from
2924         tui_show_register_group.
2925         (tui_data_window::check_register_values, tui_reg_command):
2926         Update.
2927         * tui/tui-layout.c (tui_set_layout): Update.
2928
2929 2019-08-20  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2932         Declare.
2933         (tui_check_register_values): Don't declare.
2934         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2935         from tui_check_register_values.
2936         * tui/tui-hooks.c (tui_register_changed): Update.
2937
2938 2019-08-20  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-regs.c (tui_reg_layout): Move later.
2941         (tui_show_registers): Don't enable TUI mode or change layout.
2942
2943 2019-08-20  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-regs.h (struct tui_data_item_window)
2946         <~tui_data_item_window>: Remove.
2947         <content>: Now a unique_xmalloc_ptr.
2948         * tui/tui-regs.c (tui_register_format): Return a
2949         unique_xmalloc_ptr.
2950         (tui_get_register): Update.
2951         (~tui_data_item_window): Remove.
2952         (tui_data_window::display_registers_from, tui_display_register):
2953         Update.
2954         * tui/tui-io.h (tui_expand_tabs): Update.
2955         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2956         Remove "col" parameter.
2957
2958 2019-08-20  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2961         field.
2962         * tui/tui-regs.c (~tui_data_item_window): Update.
2963
2964 2019-08-20  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2967         earlier.
2968
2969 2019-08-20  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2972
2973 2019-08-20  Tom Tromey  <tom@tromey.com>
2974
2975         * tui/tui-source.h (struct tui_source_window): Update.
2976         * tui/tui-regs.c (tui_show_registers): Update.
2977         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2978         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2979         (NO_REGS_STRING): Remove defines.
2980
2981 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2982
2983         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2984         unnecessary thread walk if remote doesn't support the packet.
2985
2986 2019-08-19  Tom Tromey  <tromey@adacore.com>
2987
2988         * python/py-value.c (value_has_field): Fix indentation.
2989
2990 2019-08-19  Tom Tromey  <tromey@adacore.com>
2991
2992         * printcmd.c (do_one_display, info_display_command): Update.
2993         * block.h (contained_in): Return bool.  Add allow_nested
2994         parameter.
2995         * block.c (contained_in): Return bool.  Add allow_nested
2996         parameter.
2997
2998 2019-08-19  Tom Tromey  <tom@tromey.com>
2999
3000         * configure: Rebuild.
3001         * configure.ac: Disallow the combination of -static-libstdc++ and
3002         source highlight.
3003         * source-cache.c (get_language_name): Handle rust.
3004         (source_cache::get_source_lines): Ignore highlighting exceptions.
3005
3006 2019-08-16  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3009         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3010         (struct tui_source_window_base) <make_visible, refresh_window,
3011         resize>: Remove methods.
3012         <execution_info>: Remove field.
3013         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3014         (tui_show_source_line, tui_source_window_base)
3015         (~tui_source_window_base): Update.
3016         (tui_source_window_base::resize)
3017         (tui_source_window_base::make_visible)
3018         (tui_source_window_base::refresh_window): Remove.
3019         (tui_source_window_base::update_exec_info): Update.
3020         * tui/tui-source.c (tui_source_window::set_contents): Update.
3021         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3022
3023 2019-08-16  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3026         deprecated_query_hook.
3027
3028 2019-08-16  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3031         (tui_update_source_windows_with_line): Update.
3032         * tui/tui-source.h (struct tui_source_window)
3033         <show_symtab_source>: Declare.
3034         (tui_show_symtab_source): Don't declare.
3035         * tui/tui-source.c (tui_show_symtab_source): Rename from
3036         tui_show_symtab_source.
3037
3038 2019-08-16  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-winsource.h (struct tui_source_window_base)
3041         <set_contents>: Declare.
3042         * tui/tui-winsource.c
3043         (tui_source_window_base::update_source_window_as_is): Update.
3044         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3045         Declare.
3046         (tui_set_source_content): Don't declare.
3047         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3048         tui_set_source_content.
3049         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3050         Declare.
3051         (tui_set_disassem_content): Don't declare.
3052         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3053         tui_set_disassem_content.
3054
3055 2019-08-16  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-winsource.h (struct tui_source_window_base)
3058         <update_breakpoint_info>: Declare.
3059         (tui_update_breakpoint_info): Don't declare.
3060         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3061         (tui_update_all_breakpoint_info): Update.
3062         (tui_source_window_base::update_breakpoint_info): Rename from
3063         tui_update_breakpoint_info.
3064         (tui_source_window_base::update_exec_info): Update.
3065
3066 2019-08-16  Tom Tromey  <tom@tromey.com>
3067
3068         * tui/tui-winsource.h (struct tui_source_window_base)
3069         <update_source_window>: Declare.
3070         (tui_update_source_window): Don't declare.
3071         * tui/tui-winsource.c
3072         (tui_source_window_base::update_source_window): Rename from
3073         tui_update_source_window.
3074         (tui_source_window_base::rerender): Update.
3075         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3076         * tui/tui-disasm.c (tui_show_disassem)
3077         (tui_show_disassem_and_update_source)
3078         (tui_disasm_window::maybe_update): Update.
3079
3080 2019-08-16  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-winsource.h (struct tui_source_window_base)
3083         <update_source_window_as_is>: Declare.
3084         (tui_update_source_window_as_is): Don't declare.
3085         * tui/tui-winsource.c (tui_update_source_window): Update
3086         (tui_source_window_base::update_source_window_as_is): Rename from
3087         tui_update_source_window_as_is.
3088         (tui_source_window_base::refill): Update.
3089         * tui/tui-source.c (tui_show_symtab_source): Update.
3090         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3091         Update.
3092
3093 2019-08-16  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-winsource.h (tui_update_source_window)
3096         (tui_update_source_window_as_is): Remove "noerror" parameter.
3097         * tui/tui-winsource.c (tui_update_source_window)
3098         (tui_update_source_window_as_is): Remove "noerror" parameter.
3099         (tui_update_source_windows_with_addr)
3100         (tui_update_source_windows_with_line)
3101         (tui_source_window_base::rerender)
3102         (tui_source_window_base::refill): Update.
3103         * tui/tui-source.h (tui_set_source_content)
3104         (tui_show_symtab_source): Remove "noerror" parameter.
3105         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3106         parameter.
3107         (tui_show_symtab_source): Likewise.
3108         (tui_source_window::maybe_update): Update.
3109         * tui/tui-disasm.c (tui_show_disassem)
3110         (tui_show_disassem_and_update_source)
3111         (tui_disasm_window::do_scroll_vertical)
3112         (tui_disasm_window::maybe_update): Update.
3113
3114 2019-08-16  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui.c (tui_is_window_visible): Update.
3117         * tui/tui-wingeneral.c (tui_make_window)
3118         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3119         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3120         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3121         (tui_set_win_height_command, parse_scrolling_args): Update.
3122         * tui/tui-source.c (tui_source_window::style_changed): Update.
3123         * tui/tui-regs.c (tui_show_registers)
3124         (tui_data_window::first_data_item_displayed)
3125         (tui_data_window::delete_data_content_windows)
3126         (tui_check_register_values, tui_reg_command): Update.
3127         * tui/tui-disasm.c (tui_show_disassem): Update.
3128         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3129         method.
3130         <is_visible>: Remove field.
3131         * tui/tui-data.c (tui_next_win, tui_prev_win)
3132         (tui_delete_invisible_windows): Update.
3133
3134 2019-08-16  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-winsource.h (struct tui_source_window_base)
3137         <m_has_locator>: Remove.
3138         * tui/tui-layout.c (show_source_disasm_command, show_data)
3139         (show_source_or_disasm_and_command): Update.
3140
3141 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3142
3143         * NEWS (Other MI changes): New subsection.
3144         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3145         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3146         * arch-utils.c (default_get_pc_address_flags): New function.
3147         * arch-utils.h (default_get_pc_address_flags): New declaration.
3148         * gdbarch.sh: Add get_pc_address_flags.
3149         * gdbarch.c: Regenerate.
3150         * gdbarch.h: Likewise.
3151         * stack.c (print_pc): New function.
3152         (print_frame_info) (print_frame): Call print_pc.
3153
3154 2019-08-16  Tom de Vries  <tdevries@suse.de>
3155
3156         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3157         print_objfile_section_info.
3158
3159 2019-08-15  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3162         calling update_cmdwin_start_line.
3163         * tui/tui-winsource.h (struct tui_source_window_base)
3164         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3165         <rerender>: Declare.
3166         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3167         Call rerender.
3168         (tui_source_window_base::set_new_height): Remove.
3169         (tui_source_window_base::rerender): Rename from
3170         do_make_visible_with_new_height.
3171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3172         resize method.
3173         (tui_win_info::make_invisible_and_set_new_height)
3174         (tui_win_info::make_visible_with_new_height): Remove.
3175         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3176         Declare.
3177         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3178         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3179         do_make_visible_with_new_height>: Don't declare.
3180         <rerender>: Declare.
3181         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3182         set_new_height.
3183         (tui_data_window::do_make_visible_with_new_height): Remove.
3184         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3185         call tui_show_locator_content.
3186         (tui_gen_win_info::resize): Call rerender.
3187         (show_source_or_disasm_and_command): Don't call
3188         tui_show_locator_content.
3189         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3190         method.
3191         (struct tui_win_info) <rerender>: Declare.
3192         <set_new_height, make_invisible_and_set_new_height,
3193         make_visible_with_new_height>: Don't declare.
3194         * tui/tui-data.c (tui_win_list::rerender): New method.
3195         * tui/tui-command.h (struct tui_cmd_window)
3196         <do_make_visible_with_new_height>: Don't declare.
3197         * tui/tui-command.c
3198         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3199
3200 2019-08-15  Tom Tromey  <tromey@adacore.com>
3201
3202         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3203         * ada-lang.c (ada_enum_name): Likewise.
3204
3205 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3206
3207         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3208         leading underscore.
3209         (GdbOutputErrorFile): Likewise.
3210         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3211         accordingly.
3212         (execute_unwinders): Rename to have a leading underscore.
3213         (auto_load_packages): Likewise.
3214         (global scope): Adjust call to auto_load_packages accordingly.
3215         (GdbSetPythonDirectory): Likewise.
3216         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3217         instead of execute_unwinders.
3218
3219 2019-08-15  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3222         (show_data): Don't change window visibility.
3223         (tui_gen_win_info::resize): Remove special case for command
3224         window.  Use wresize, when available.
3225         (show_source_or_disasm_and_command): Don't change window
3226         visibility.
3227         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3228         <make_visible>: New method.
3229         * tui/tui-command.c (tui_cmd_window::resize): New method.
3230
3231 2019-08-15  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3234         (struct tui_source_windows): New.
3235         * tui/tui-winsource.c (tui_display_main): Update.
3236         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3237         (new_height_ok, parse_scrolling_args): Update.
3238         * tui/tui-layout.c (show_layout, show_data): Update.
3239         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3240         (tui_add_to_source_windows): Don't declare.
3241         * tui/tui-data.c (source_windows, tui_source_windows)
3242         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3243
3244 2019-08-15  Tom Tromey  <tom@tromey.com>
3245
3246         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3247         Rename from reset.
3248         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3249         * tui/tui-layout.c (show_source_disasm_command, show_data):
3250         Update.
3251         (tui_gen_win_info::resize): Rename.
3252         (show_source_or_disasm_and_command): Update.
3253         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3254         reset.
3255
3256 2019-08-15  Tom Tromey  <tom@tromey.com>
3257
3258         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3259         * tui/tui-interp.c (tui_interp::init): Don't call
3260         tui_initialize_static_data.
3261         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3262
3263 2019-08-15  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3266         examine tui_win_list.
3267
3268 2019-08-15  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3271         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3272         tui_clear_source_content.
3273         (tui_clear_source_content): Remove.
3274         (tui_source_window_base::do_erase_source_content): Hoist call to
3275         content.clear().
3276         * tui/tui-stack.c (tui_show_frame_info): Don't call
3277         tui_clear_source_content.
3278
3279 2019-08-15  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-winsource.h (struct tui_source_window_base)
3282         <do_erase_source_content>: New method.
3283         <erase_source_content>: New method.
3284         (tui_erase_source_content): Don't declare.
3285         * tui/tui-winsource.c (tui_clear_source_content): Update.
3286         (tui_source_window_base::do_erase_source_content): Rename from
3287         tui_erase_source_content.
3288         (tui_source_window_base::show_source_content): Update.
3289         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3290         * tui/tui-source.h (struct tui_source_window)
3291         <erase_source_content>: New method.
3292         * tui/tui-disasm.h (struct tui_disasm_window)
3293         <erase_source_content>: New method.
3294
3295 2019-08-15  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3298         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3299         constructor.
3300         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3301         * tui/tui-source.c (tui_set_source_content): Update.
3302         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3303
3304 2019-08-15  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3307         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3308         tui-source.c.
3309         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3310         Declare.
3311         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3312         method.
3313         (tui_source_window::maybe_update): Update.
3314
3315 2019-08-15  Tom Tromey  <tom@tromey.com>
3316
3317         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3318         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3319         tui-disasm.c.
3320         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3321         Declare.
3322         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3323         method.
3324         (tui_disasm_window::maybe_update): Update.
3325
3326 2019-08-15  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-winsource.h (struct tui_source_window_base)
3329         <maybe_update>: Declare.
3330         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3331         method.
3332         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3333         Declare.
3334         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3335         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3336         Declare.
3337         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3338
3339 2019-08-15  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3342
3343 2019-08-15  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-wingeneral.c: Include tui-stack.h.
3346         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3347         (struct tui_locator_window): Move from tui-data.h.
3348         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3349         (tui_initialize_static_data): Move from tui-data.c.
3350         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3351         (struct tui_locator_window): Move to tui-stack.c.
3352         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3353         (tui_initialize_static_data): Move to tui-stack.c.
3354
3355 2019-08-15  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-layout.c (show_source_disasm_command)
3358         (show_source_or_disasm_and_command): Use make_visible method, not
3359         tui_make_window.
3360         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3361         Remove.
3362
3363 2019-08-15  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-wingeneral.h (tui_make_window): Update.
3366         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3367         parameter.
3368         (tui_gen_win_info::make_visible): Update.
3369         * tui/tui-regs.c (tui_data_window::display_registers_from):
3370         Update.
3371         * tui/tui-layout.c (show_source_disasm_command)
3372         (show_source_or_disasm_and_command): Update.
3373         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3374         (enum tui_box): Remove.
3375         (struct tui_win_info) <can_box>: New method.
3376         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3377         method.
3378
3379 2019-08-15  Tom de Vries  <tdevries@suse.de>
3380
3381         * linux-nat-trad.c: Include gdbarch.h.
3382
3383 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3384
3385         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3386         register sizes.
3387
3388 2019-08-14  Tom Tromey  <tromey@adacore.com>
3389
3390         * darwin-nat.c: Include gdbarch.h.
3391         * darwin-nat-info.c: Include gdbarch.h.
3392
3393 2019-08-13  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3396         Remove.
3397         * tui/tui-data.c (tui_initialize_static_data): Update.
3398
3399 2019-08-13  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-winsource.h (struct tui_exec_info_window)
3402         <~tui_exec_info_window, maybe_allocate_content, get_content,
3403         m_content>: Remove.
3404         (struct tui_source_window_base) <set_exec_info_content,
3405         show_exec_info_content>: Don't declare.
3406         * tui/tui-winsource.c
3407         (tui_exec_info_window::maybe_allocate_content): Remove.
3408         (tui_source_window_base::update_exec_info): Rename from
3409         set_exec_info_content.
3410         (tui_source_window_base::show_exec_info_content)
3411         (tui_source_window_base::update_exec_info): Remove.
3412
3413 2019-08-13  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3416         declare.
3417         * tui/tui-winsource.c (tui_update_source_window_as_is)
3418         (tui_update_source_windows_with_addr, tui_erase_source_content):
3419         Update.
3420         (tui_clear_exec_info_content): Remove.
3421
3422 2019-08-13  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3425         declare.
3426         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3427         call tui_erase_exec_info_content.
3428         (tui_clear_exec_info_content): Rename from
3429         tui_erase_exec_info_content.
3430         (tui_clear_exec_info_content): Delete.
3431
3432 2019-08-13  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-winsource.h (struct tui_source_window_base)
3435         <show_exec_info_content>: Declare.
3436         (tui_show_exec_info_content): Don't declare.
3437         * tui/tui-winsource.c
3438         (tui_source_window_base::show_exec_info_content): Rename from
3439         tui_show_exec_info_content.
3440         (tui_source_window_base::update_exec_info): Update.
3441
3442 2019-08-13  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3445         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3446         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3447         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3448         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3449         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3450         ... here.
3451
3452 2019-08-13  Tom Tromey  <tom@tromey.com>
3453
3454         * tui/tui-winsource.h (struct tui_source_window_base)
3455         <update_exec_info>: Declare.
3456         (tui_update_exec_info): Don't declare.
3457         * tui/tui-winsource.c (tui_update_source_window_as_is)
3458         (tui_source_window_base::refresh_all)
3459         (tui_update_all_breakpoint_info): Update.
3460         (tui_source_window_base::update_exec_info): Rename from
3461         tui_update_exec_info.
3462         * tui/tui-stack.c (tui_show_frame_info): Update.
3463
3464 2019-08-13  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-winsource.h (struct tui_source_window_base)
3467         <set_exec_info_content>: Declare.
3468         (tui_set_exec_info_content): Don't declare.
3469         * tui/tui-winsource.c
3470         (tui_source_window_base::set_exec_info_content): Rename from
3471         tui_set_exec_info_content.
3472         (tui_update_exec_info): Update.
3473
3474 2019-08-13  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-winsource.h (struct tui_source_window_base)
3477         <show_source_content>: Declare.
3478         (tui_show_source_content): Don't declare.
3479         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3480         (tui_source_window_base::show_source_content): Rename from
3481         tui_show_source_content.
3482         (tui_source_window_base::refresh_all): Update.
3483         * tui/tui-layout.c (show_source_disasm_command)
3484         (show_source_or_disasm_and_command): Update.
3485
3486 2019-08-13  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-winsource.c (tui_erase_source_content)
3489         (tui_show_source_content, tui_source_window_base::refresh_all):
3490         Update.
3491         * tui/tui-wingeneral.h
3492         (tui_check_and_display_highlight_if_needed): Don't declare.
3493         * tui/tui-wingeneral.c
3494         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3495         check_and_display_highlight_if_needed.
3496         * tui/tui-win.c (tui_rehighlight_all)
3497         (tui_win_info::make_visible_with_new_height): Update.
3498         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3499         (tui_data_window::erase_data_content)
3500         (tui_data_window::display_all_data): Update.
3501         * tui/tui-data.h (struct tui_win_info)
3502         <check_and_display_highlight_if_needed>: Declare.
3503
3504 2019-08-13  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-win.c (tui_resize_all): Call
3507         tui_delete_invisible_windows.
3508         * tui/tui-layout.c (show_layout): Call
3509         tui_delete_invisible_windows.
3510         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3511         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3512
3513 2019-08-13  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3516         tui_add_win_to_layout.
3517
3518 2019-08-13  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3521         * tui/tui-layout.c (tui_default_win_height): Now static.
3522
3523 2019-08-13  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3526         single switch.
3527         (show_source_disasm_command, show_source_or_disasm_and_command):
3528         Don't check current layout.
3529
3530 2019-08-13  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-wingeneral.c (make_all_visible): Remove.
3533         (tui_make_all_invisible): Simplify.
3534         * tui/tui-layout.c (tui_make_all_invisible): Move from
3535         tui-wingeneral.c; simplify.
3536         (show_layout): Hoist call to tui_make_all_invisible.
3537         (show_data): Don't call tui_make_all_invisible.
3538
3539 2019-08-13  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3542         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3543
3544 2019-08-13  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3547         tui-data.c.
3548         (show_source_disasm_command, show_data)
3549         (show_source_or_disasm_and_command): Don't use
3550         tui_set_current_layout_to.
3551         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3552         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3553         tui-layout.c.
3554         (tui_set_current_layout_to): Remove.
3555
3556 2019-08-13  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-layout.c (tui_set_layout): Update.
3559         * tui/tui-data.h (struct tui_layout_def): Remove.
3560         (tui_layout_def): Don't declare.
3561         * tui/tui-data.c (layout_def): Remove.
3562         (tui_layout_def): Remove.
3563
3564 2019-08-13  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-winsource.h (struct tui_source_window_base)
3567         <clear_detail>: No longer "override".
3568         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3569         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3570         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3571         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3572         Remove.
3573         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3574
3575 2019-08-13  Tom Tromey  <tromey@adacore.com>
3576
3577         * tracepoint.c: Don't include readline.h or history.h.
3578
3579 2019-08-12  Tom Tromey  <tom@tromey.com>
3580
3581         * configure: Rebuild.
3582         * configure.ac: Check for readline 7.
3583         * NEWS: Mention readline 7 requirement.
3584         * README: Update.
3585
3586 2019-08-12  Tom Tromey  <tom@tromey.com>
3587
3588         * mingw-hdep.c (gdb_select): Remove readline hack.
3589
3590 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3591
3592         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3593         when the function fails.
3594
3595 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3596
3597         * s390-tdep.c (s390_type_align): New function.
3598         (s390_gdbarch_init): Set it as type_align gdbarch method.
3599
3600 2019-08-09  Tom de Vries  <tdevries@suse.de>
3601
3602         PR gdb/24591
3603         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3604         pc_low with relocation offset.
3605
3606 2019-08-07  Tom Tromey  <tromey@adacore.com>
3607
3608         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3609         (print_frame_args): Update.
3610         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3611         Update.
3612         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3613         * frame.h (struct frame_arg): Add initializers.
3614         <error>: Now a unique_xmalloc_ptr.
3615
3616 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3617
3618         * NEWS: Expand the Pointer Authentication entry.
3619         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3620         (aarch64_frame_unmask_lr): ... to this.
3621         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3622         Call aarch64_frame_unmask_lr.
3623         * frame.c (struct frame_info): Add "masked" variable.
3624         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3625         (fprint_frame): Check for masked pc.
3626         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3627         declarations.
3628         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3629         * stack.c (print_frame): Check for masked pc.
3630
3631 2019-08-06  Tom Tromey  <tom@tromey.com>
3632
3633         * stabsread.c (patch_block_stabs, read_one_struct_field)
3634         (read_enum_type): Use obstack_strndup.
3635         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3636         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3637         * dwarf2read.c (guess_full_die_structure_name)
3638         (anonymous_struct_prefix): Use obstack_strndup.
3639         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3640         * c-exp.y (yylex): Use obstack_strndup.
3641         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3642         (write_var_or_type): Use obstack_strndup.
3643
3644 2019-08-06  Tom Tromey  <tom@tromey.com>
3645
3646         * symfile.c (reread_symbols): Use obstack_strdup.
3647         * stabsread.c (read_type): Use obstack_strdup.
3648         * gdb_obstack.h (obstack_strdup): New overload.
3649         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3650         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3651         (dwarf2_canonicalize_name): Use obstack_strdup.
3652         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3653         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3654         Use obstack_strdup.
3655
3656 2019-08-06  Tom Tromey  <tom@tromey.com>
3657
3658         * gdb_obstack.h (obstack_strdup): Define.
3659         * gdb_obstack.c (obstack_strdup): Don't define.
3660
3661 2019-08-06  Tom Tromey  <tom@tromey.com>
3662
3663         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3664         obstack_strdup.
3665         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3666         obstack_strdup.
3667         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3668         * stabsread.c (common_block_start): Use obstack_strdup.
3669         * objfiles.c (set_objfile_main_name, objfile): Use
3670         obstack_strdup.
3671         * namespace.c (add_using_directive): Use obstack_strdup.
3672         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3673         * jit.c (finalize_symtab): Use obstack_strdup.
3674         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3675         (guess_partial_die_structure_name, partial_die_info::fixup)
3676         (dwarf2_name): Use obstack_strdup.
3677         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3678         obstack_strdup.
3679         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3680         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3681         obstack_strdup.
3682         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3683
3684 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3685
3686         * unittests/help-doc-selftests.c: New file.
3687         * Makefile.in: Add the new file.
3688
3689 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3690
3691         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3692         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3693         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3694         the trailing '.' is not output, and the first character is uppercased.
3695         (print_help_for_command): Update call to print_doc_line.
3696         (print_doc_of_command): Likewise.
3697         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3698         * cli/cli-option.c (append_indented_doc): Do not append newline.
3699         (build_help_option): Append newline after first appended_indented_doc
3700         only if a second call is done.
3701         (build_help): Append 2 new lines before each option, except the first
3702         one.
3703         * compile/compile.c (_initialize_compile): Add new lines after
3704         %OPTIONS%, when not at the end of the help.
3705         Change help doc or code
3706         producing the help doc to respect the invariants.
3707         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3708         Also removed the new line after 'Options:', as all other commands
3709         do not put an empty line between 'Options:' and the first option.
3710         * printcmd.c (_initialize_printcmd): Likewise.
3711         * stack.c (_initialize_stack): Likewise.
3712         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3713         incorrectly telling COMMAND is optional.
3714         * ada-lang.c (_initialize_ada_language): Change help doc or code
3715         producing the help doc to respect the invariants.
3716         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3717         * breakpoint.c (_initialize_breakpoint): Likewise.
3718         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3719         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3720         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3721         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3722         _initialize_cli_style): Likewise.
3723         * corelow.c (core_target_info): Likewise.
3724         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3725         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3726         * filesystem.c (_initialize_filesystem): Likewise.
3727         * frame.c (_initialize_frame): Likewise.
3728         * gnu-nat.c (add_task_commands): Likewise.
3729         * infcall.c (_initialize_infcall): Likewise.
3730         * infcmd.c (_initialize_infcmd): Likewise.
3731         * interps.c (_initialize_interpreter): Likewise.
3732         * language.c (_initialize_language): Likewise.
3733         * linux-fork.c (_initialize_linux_fork): Likewise.
3734         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3735         * maint.c (_initialize_maint_cmds): Likewise.
3736         * memattr.c (_initialize_mem): Likewise.
3737         * printcmd.c (_initialize_printcmd): Likewise.
3738         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3739         _RegEx): Likewise.
3740         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3741         * record-btrace.c (_initialize_record_btrace): Likewise.
3742         * record-full.c (_initialize_record_full): Likewise.
3743         * record.c (_initialize_record): Likewise.
3744         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3745         * regcache.c (_initialize_regcache): Likewise.
3746         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3747         _initialize_remote): Likewise.
3748         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3749         * serial.c (_initialize_serial): Likewise.
3750         * skip.c (_initialize_step_skip): Likewise.
3751         * source.c (_initialize_source): Likewise.
3752         * stack.c (_initialize_stack): Likewise.
3753         * symfile.c (_initialize_symfile): Likewise.
3754         * symtab.c (_initialize_symtab): Likewise.
3755         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3756         * top.c (init_main): Likewise.
3757         * tracefile-tfile.c (tfile_target_info): Likewise.
3758         * tracepoint.c (_initialize_tracepoint): Likewise.
3759         * tui/tui-win.c (_initialize_tui_win): Likewise.
3760         * utils.c (add_internal_problem_command): Likewise.
3761         * valprint.c (value_print_option_defs): Likewise.
3762
3763 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3764
3765         PR build/24886
3766         * configure.ac: Drop enable-libmcheck support.
3767         * configure, config.in: Rebuild.
3768         * libmcheck.m4: Remove.
3769         * acinclude.m4: Don't include it.
3770         * Makefile.in: Don't distribute it.
3771         * top.c (print_gdb_configuration): Don't mention it.
3772
3773 2019-08-06  Tom Tromey  <tom@tromey.com>
3774
3775         * utils.c (set_output_style): Sometimes pass stream to
3776         emit_style_escape.
3777         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3778         * record-btrace.c (btrace_insn_history): Update.
3779         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3780         method.
3781         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3782         Update initializers.
3783         <m_uiout>: New field.
3784         <m_di>: Move lower.
3785         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3786         Remove "uiout" parameter.
3787         (dump_insns): Update.
3788         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3789         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3790
3791 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3792
3793         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3794         (error_in_psymtab_expansion): Likewise.
3795         (lookup_symbol_via_quick_fns): Likewise.
3796         (basic_lookup_transparent_type_quick): Likewise.
3797         (basic_lookup_transparent_type_1): Likewise.
3798
3799 2019-08-06  Tom Tromey  <tromey@adacore.com>
3800
3801         * source.c (last_source_error): Now bool.
3802         (print_source_lines_base): Make "noprint" bool.  Only open
3803         source file when last_source_visited changes.
3804
3805 2019-08-06  Tom Tromey  <tromey@adacore.com>
3806
3807         * annotate.c (annotate_source_line): Use g_source_cache.
3808         * source-cache.c (source_cache::get_plain_source_lines): Change
3809         parameters.  Populate m_offset_cache.
3810         (source_cache::ensure): New method.
3811         (source_cache::get_line_charpos): New method.
3812         (extract_lines): Move lower.  Change parameters.
3813         (source_cache::get_source_lines): Move lower.
3814         * source-cache.h (class source_cache): Update comment.
3815         <get_line_charpos>: New method.
3816         <get_source_lines>: Update comment.
3817         <clear>: Clear m_offset_cache.
3818         <get_plain_source_lines>: Change parameters.
3819         <ensure>: New method
3820         <m_offset_cache>: New member.
3821         * source.c (forget_cached_source_info_for_objfile): Update.
3822         (info_source_command): Use g_source_cache.
3823         (find_source_lines, open_source_file_with_line_charpos): Remove.
3824         (print_source_lines_base, search_command_helper): Use g_source_cache.
3825         * source.h (open_source_file_with_line_charpos): Don't declare.
3826         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3827         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3828         Use g_source_cache.
3829
3830 2019-08-06  Tom Tromey  <tromey@adacore.com>
3831
3832         * source-cache.c (source_cache::get_plain_source_lines):
3833         Remove "first_line" and "last_line" parameters.
3834         (source_cache::get_source_lines): Cache plain text.
3835         * source-cache.h (class source_cache)
3836         <get_plain_source_lines>: Update.
3837
3838 2019-08-06  Tom Tromey  <tromey@adacore.com>
3839
3840         * source-cache.c (extract_lines): No longer a method.
3841         Changed type of parameter.  Include final newline.
3842         (selftests::extract_lines_test): New function.
3843         (_initialize_source_cache): Likewise.
3844         * source-cache.h (class source_cache)
3845         <extract_lines>: Don't declare.
3846
3847 2019-08-06  Tom Tromey  <tromey@adacore.com>
3848
3849         * breakpoint.c (init_breakpoint_sal): Update.
3850         (breakpoint): Update.
3851         * breakpoint.h (struct breakpoint) <filter>: Now a
3852         unique_xmalloc_ptr.
3853
3854 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3855
3856         * NEWS: Mention dictionary access on blocks.
3857         * python/py-block.c (blpy_getitem): New function.
3858         (block_object_as_mapping): New struct.
3859         (block_object_type): Use new struct for tp_as_mapping field.
3860
3861 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3862
3863         * objfiles.h (objfile): Add a comment describing partial symbols.
3864
3865 2019-08-05  Tom Tromey  <tromey@adacore.com>
3866
3867         * compile/compile.c (_initialize_compile): Use _(), not N_().
3868         * thread.c (_initialize_thread): Use _(), not N_().
3869         * stack.c (_initialize_stack): Use _(), not N_().
3870         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3871
3872 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3873
3874         * dwarf2read.c (struct dw2_symtab_iterator):
3875         <want_specific_block>: Remove.
3876         <block_index>: Change type to gdb::optional.
3877         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3878         change type of BLOCK_INDEX parameter to gdb::optional.
3879         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3880         (dw2_lookup_symbol): Don't pass argument for
3881         WANT_SPECIFIC_BLOCK.
3882         (dw2_expand_symtabs_for_function): Don't pass argument for
3883         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3884         (class dw2_debug_names_iterator)
3885         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3886         parameter, change BLOCK_INDEX type to gdb::optional.
3887         <m_want_specific_block>: Remove.
3888         <m_block_index>: Change type to gdb::optional.
3889         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3890         gdb::optional.  Re-write in function of gdb::optional.
3891         (dw2_debug_names_lookup_symbol): Don't pass argument for
3892         WANT_SPECIFIC_BLOCK.
3893         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3894         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3895         BLOCK_INDEX.
3896
3897 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3898
3899         * NEWS: Mention changes to "info sources" command.
3900
3901 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3902
3903         * symtab.c (filename_partial_match_opts): New struct type.
3904         (struct output_source_filename_data): New members
3905         regexp, c_regexp, partial_match.
3906         (output_source_filename): Use new members to decide to print file.
3907         (info_sources_option_defs): New variable.
3908         (make_info_sources_options_def_group, print_info_sources_header,
3909         info_sources_command_completer):
3910         New functions.
3911         (info_sources_command): Read new optional arguments.
3912         (_initialize_symtab): Update info sources help.
3913
3914 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3915
3916         * ada-lang.c (exception_support_info_v0): Renamed from...
3917         (default_exception_support_info): ... this.  Create new
3918         definition for v1.
3919         (ada_has_this_exception_support): Look up catch_handlers_sym.
3920         (ada_exception_support_info_sniffer): Try v0 after default.
3921
3922 2019-08-01  Tom Tromey  <tromey@adacore.com>
3923
3924         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3925         gdbarch.h.
3926
3927 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3928
3929         * s12z-tdep.c: Fix include path for s12z-opc.h.
3930
3931 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3932
3933         * NEWS: Require GNU make 3.82.
3934
3935 2019-07-16  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3938         declare.
3939
3940 2019-07-30  Tom Tromey  <tromey@adacore.com>
3941
3942         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3943
3944 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3945
3946         * printcmd.c (print_address_symbolic): Print negative offsets.
3947         (build_address_symbolic): Force signed arithmetic when computing
3948         offset.
3949
3950 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3951
3952         PR/24474: Add a function to lookup static variables.
3953         * NEWS: Mention this new function.
3954         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3955         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3956         * python/python.c (python_GdbMethods): Add new function.
3957
3958 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3959
3960         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3961         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3962         (objfpy_lookup_static_symbol): New function.
3963         (objfile_object_methods): Add new functions.
3964
3965 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3966
3967         * NEWS: Mention 'set|show print frame-info'.  Mention new
3968         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3969         backtrace argument.  Mention that python frame filtering code
3970         is now consistent with what 'backtrace' command prints.
3971
3972 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3973
3974         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3975         comments.
3976         (print_frame_info_auto, print_frame_info_source_line,
3977         print_frame_info_location, print_frame_info_source_and_location,
3978         print_frame_info_location_and_address, print_frame_info_short_location):
3979         New declarations.
3980         (struct frame_print_options): New member print_frame_info.
3981         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3982         * stack.h (get_user_print_what_frame_info): New declaration.
3983         (frame_show_address): New declaration.
3984         * stack.c (print_frame_arguments_choices): New value 'presence'.
3985         (print_frame_info_auto, print_frame_info_source_line,
3986         print_frame_info_location, print_frame_info_source_and_location,
3987         print_frame_info_location_and_address, print_frame_info_short_location,
3988         print_frame_info_choices, print_frame_info_print_what): New definitions.
3989         (print_frame_args): Only print dots for args if print frame-arguments
3990         is 'presence'.
3991         (frame_print_option_defs): New element for "frame-info".
3992         (get_user_print_what_frame_info): New function.
3993         (frame_show_address): Make non static.  Move comment to stack.h.
3994         (print_frame_info_to_print_what): New function.
3995         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3996         to decide what to print.
3997         (backtrace_command_1): Handle the new print_frame_arguments_presence
3998         value.
3999         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4000         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4001         (py_print_frame): In non-mi mode, use LOCATION as default for
4002         print_what, similarly to frame information printed directly by
4003         backtrace command. Handle frame-info user option in non MI mode.
4004
4005 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4006
4007         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4008         Add case for debugging 32-bit target on 64-bit host.  Revise
4009         comment.
4010
4011 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4012
4013         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4014         instead of find_function_entry_range_from_pc.
4015
4016 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4017
4018         * stack.c (find_frame_funname): Remove code which preferred
4019         minsym over symtab sym in "certain pathological cases".
4020
4021         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4022         parameter.  Change type of "do_demangle" to bool.
4023         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4024         Pass suitable "prefer_sym_over_minsym" flag to
4025         build_address_symbolic().  Don't output "+" for negative offsets.
4026         * printcmd.c (print_address_symbolic): Update invocation of
4027         build_address_symbolic to include a "prefer_sym_over_minsym"
4028         flag.
4029         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4030         Restrict cases in which use of minimal symbol is preferred to that
4031         of a found symbol.  Update comments.
4032
4033         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4034         for entry pc when entry pc is out of range for that FDE.
4035
4036 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4037
4038         PR gdb/24839:
4039         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4040         type.
4041
4042 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4043
4044         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4045         this function's Python signature.
4046
4047
4048 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4049
4050         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4051         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4052         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4053         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4054         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4055
4056
4057 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4058
4059         * h8300-tdep.c (h8300_register_name_common): New.
4060         h8300_register_name): Use h8300_register_name_common.
4061         (h8300s_register_name): Likewise.
4062         (h8300sx_register_name): Likewise.
4063         (h8300h_register_nam): New.
4064         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4065
4066
4067 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4068
4069         * arm-tdep.c (arm_skip_cmse_entry): New function.
4070         (arm_is_sgstubs_section): New function.
4071         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4072
4073 2019-07-22  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4076         Don't self-assign.
4077
4078 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4079
4080         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4081         type_print.
4082
4083 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4086         so that GDB doesn't match any msymbols when searching in the
4087         TYPES_DOMAIN.
4088         (print_symbol_info): Print using typedef_print or type_print based
4089         on the type of the symbol.  Add updated FIXME comment moved from...
4090         (_initialize_symtab): ... move and update FIXME comment to above.
4091
4092 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * NEWS: Mention adding -q option to "info types".
4095         * symtab.c (struct info_types_options): New struct.
4096         (info_types_options_defs): New variable.
4097         (make_info_types_options_def_group): New function.
4098         (info_types_command): Use gdb::option framework to parse options.
4099         (info_types_command_completer): New function.
4100         (_initialize_symtab): Extend the help text on "info types" and
4101         register command completer.
4102
4103 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4104
4105         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4106         (lookup_symbol_in_objfile): Change int to block_enum and add a
4107         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4108
4109 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4110
4111         * MAINTAINERS (Write After Approval): Add self.
4112
4113 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4116         instruction to the dummy code region.
4117
4118 2019-07-19  Tom Tromey  <tromey@adacore.com>
4119
4120         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4121         (ARGSUSED, PARAMS, __func__): Remove rules.
4122
4123 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4124
4125         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4126         * features/arm/arm-with-iwmmxt.c: Remove.
4127         * features/arm/arm-with-iwmmxt.xml: Remove.
4128         * features/arm/arm-with-m-fpa-layout.c: Remove.
4129         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4130         * features/arm/arm-with-m-vfp-d16.c: Remove.
4131         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4132         * features/arm/arm-with-m.c: Remove.
4133         * features/arm/arm-with-m.xml: Remove.
4134         * features/arm/arm-with-neon.c: Remove.
4135         * features/arm/arm-with-neon.xml: Remove.
4136         * features/arm/arm-with-vfpv2.c: Remove.
4137         * features/arm/arm-with-vfpv2.xml: Remove.
4138         * features/arm/arm-with-vfpv3.c: Remove.
4139         * features/arm/arm-with-vfpv3.xml: Remove.
4140
4141 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4142
4143         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4144
4145 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4146
4147         * arch/aarch32.c (aarch32_create_target_description): Create
4148         target descriptions using features.
4149         * arch/arm.c (arm_create_target_description)
4150         (arm_create_mprofile_target_description): Likewise.
4151         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4152
4153 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4154
4155         * Makefile.in: Add new files.
4156         * aarch32-tdep.c: New file.
4157         * aarch32-tdep.h: New file.
4158         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4159         Call aarch32_read_description.
4160         * arch/aarch32.c: New file.
4161         * arch/aarch32.h: New file.
4162         * arch/arm.c (arm_create_target_description)
4163         (arm_create_mprofile_target_description): New function.
4164         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4165         (arm_create_target_description)
4166         (arm_create_mprofile_target_description): New declaration.
4167         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4168         read_description functions.
4169         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4170         Likewise.
4171         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4172         * arm-tdep.c (tdesc_arm_list): New variable.
4173         (arm_register_g_packet_guesses): Call create description functions.
4174         (arm_read_description) (arm_read_mprofile_description): New
4175         function.
4176         * arm-tdep.h (arm_read_description)
4177         (arm_read_mprofile_description): Add declaration.
4178         * configure.tgt: Add new files.
4179
4180 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4181
4182         * top.c (new_ui_command): Open specified terminal just once.
4183
4184 2019-07-18  Tom Tromey  <tromey@adacore.com>
4185
4186         * symtab.c (main_name): Constify return type.
4187         * symfile.c (set_initial_language): Update.
4188         * symtab.h (main_name): Constify return type.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-winsource.c (tui_update_source_window)
4193         (tui_update_source_window_as_is)
4194         (tui_update_source_windows_with_line): Remove return.
4195         * tui/tui-disasm.c (tui_show_disassem)
4196         (tui_show_disassem_and_update_source): Remove return.
4197         * tui/tui.c (tui_reset): Remove return.
4198         * tui/tui-wingeneral.c
4199         (tui_check_and_display_highlight_if_needed): Remove return.
4200
4201 2019-07-17  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4204
4205 2019-07-17  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-winsource.h (struct tui_exec_info_window)
4208         (struct tui_source_window_base): Move from tui-data.h.
4209         * tui/tui-winsource.c: Move many method definitions from
4210         elsewhere.  Remove "structuring" comments.
4211         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4212         (tui_source_window_base::refresh_window): Move to
4213         tui-winsource.c.
4214         * tui/tui-win.c (tui_source_window_base::refresh_all)
4215         (tui_source_window_base::update_tab_width)
4216         (tui_source_window_base::set_new_height)
4217         (tui_source_window_base::do_make_visible_with_new_height): Move to
4218         tui-winsource.c.
4219         * tui/tui-source.h: Update.
4220         * tui/tui-source.c (tui_source_window_base::reset): Move to
4221         tui-winsource.c.
4222         * tui/tui-disasm.h: Update.
4223         * tui/tui-data.h (struct tui_exec_info_window): Move to
4224         tui-winsource.h.
4225         (struct tui_source_window_base): Likewise.
4226         * tui/tui-data.c (tui_source_window_base::clear_detail)
4227         (tui_source_window_base, ~tui_source_window_base): Move to
4228         tui-winsource.c.
4229
4230 2019-07-17  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-win.c (tui_resize_all)
4233         (tui_source_window_base::update_tab_width)
4234         (tui_adjust_win_heights): Update.
4235         (tui_win_info::make_invisible_and_set_new_height): Rename from
4236         make_invisible_and_set_new_height.
4237         * tui/tui-data.h (struct tui_win_info)
4238         <make_invisible_and_set_new_height>: New method.
4239
4240 2019-07-17  Tom Tromey  <tom@tromey.com>
4241
4242         * tui/tui.c: Update.
4243         * tui/tui-source.h (struct tui_source_window): Move from
4244         tui-data.h.
4245         * tui/tui-layout.c: Update.
4246         * tui/tui-disasm.c: Update.
4247         * tui/tui-data.h (struct tui_source_window): Move to
4248         tui-source.h.
4249
4250 2019-07-17  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4253         tui-data.h.
4254         * tui/tui-data.h (struct tui_disasm_window): Move to
4255         tui-disasm.h.
4256
4257 2019-07-17  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-regs.h (struct tui_data_item_window): Move from
4260         tui-data.h.
4261         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4262         * tui/tui-data.h (struct tui_data_item_window): Move to
4263         tui-regs.h.
4264         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4265
4266 2019-07-17  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui.c: Update.
4269         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4270         (tui_cmd_window::max_height): Move to tui-command.c.
4271         * tui/tui-layout.c: Update.
4272         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4273         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4274         tui-command.c.
4275         * tui/tui-command.h (struct tui_cmd_window): Move from
4276         tui-data.h.
4277         * tui/tui-command.c: Remove "structuring" comments.
4278         (tui_cmd_window::clear_detail)
4279         (tui_cmd_window::do_make_visible_with_new_height)
4280         (tui_cmd_window::max_height): Move from elsewhere.
4281
4282 2019-07-17  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4285         Now static.
4286         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4287         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4288
4289 2019-07-17  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui.c: Update.
4292         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4293         tui-regs.c.
4294         * tui/tui-windata.h: Remove file.
4295         * tui/tui-windata.c: Remove file.
4296         * tui/tui-win.c (tui_data_window::set_new_height)
4297         (tui_data_window::do_make_visible_with_new_height): Move to
4298         tui-regs.c.
4299         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4300         * tui/tui-regs.c: Remove "structuring" comments.
4301         (tui_data_window::first_data_item_displayed)
4302         (tui_data_window::delete_data_content_windows)
4303         (tui_data_window::erase_data_content)
4304         (tui_data_window::display_all_data)
4305         (tui_data_window::refresh_all)
4306         (tui_data_window::do_scroll_vertical)
4307         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4308         (tui_data_window::do_make_visible_with_new_height)
4309         (tui_data_window::refresh_window): Move from elsewhere.
4310         (_initialize_tui_regs): Move to end of file.
4311         * tui/tui-layout.c: Update.
4312         * tui/tui-hooks.c: Update.
4313         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4314         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4315         tui-regs.c.
4316         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4317
4318 2019-07-17  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4321         seen.
4322
4323 2019-07-17  Tom Tromey  <tom@tromey.com>
4324
4325         * tui/tui-win.c (tui_source_window_base::set_new_height)
4326         (tui_source_window_base::do_make_visible_with_new_height): Use
4327         m_has_locator field directly.
4328         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4329         method.
4330         (struct tui_source_window_base) <has_locator>: Likewise.
4331
4332 2019-07-17  Tom Tromey  <tom@tromey.com>
4333
4334         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4335         Don't declare.
4336         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4337         Remove.
4338         * tui/tui-win.c (tui_source_window_base::set_new_height)
4339         (tui_source_window_base::set_new_height)
4340         (make_invisible_and_set_new_height)
4341         (tui_source_window_base::do_make_visible_with_new_height)
4342         (tui_source_window_base::do_make_visible_with_new_height):
4343         Update.
4344         * tui/tui-layout.c (show_source_disasm_command, show_data)
4345         (show_source_or_disasm_and_command): Update.
4346         * tui/tui-layout.c (show_layout): Update.
4347
4348 2019-07-17  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-layout.c (make_data_window): Remove.
4351         (show_data): Unify creation and re-initialization cases.
4352
4353 2019-07-17  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-layout.c (make_source_window, make_disasm_window):
4356         Remove.
4357         (show_data): Unify creation and re-initialization cases.
4358
4359 2019-07-17  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-layout.c (make_command_window): Remove.
4362         (show_source_disasm_command, show_source_or_disasm_and_command):
4363         Unify creation and re-initialization cases.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4368         creation and re-initialization cases.
4369
4370 2019-07-17  Tom Tromey  <tom@tromey.com>
4371
4372         * tui/tui-regs.c (tui_get_register): Return void.
4373
4374 2019-07-17  Tom Tromey  <tom@tromey.com>
4375
4376         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4377         Simplify.
4378
4379 2019-07-17  Tom Tromey  <tom@tromey.com>
4380
4381         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4382         resetting.
4383
4384 2019-07-17  Tom Tromey  <tom@tromey.com>
4385
4386         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4387         * tui/tui-regs.c (tui_reg_layout): New function.
4388         (tui_show_registers, tui_reg_command): Use it.
4389         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4390         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4391         parameters.
4392         (tui_layout_command): Remove.
4393
4394 2019-07-17  Tom Tromey  <tom@tromey.com>
4395
4396         * tui/tui-layout.h (tui/tui-layout): Return void.
4397         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4398
4399 2019-07-17  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-layout.c (show_source_disasm_command, show_data):
4402         Update.
4403         (reset_locator): Remove.
4404         (show_source_or_disasm_and_command): Update.
4405
4406 2019-07-17  Tom Tromey  <tom@tromey.com>
4407
4408         * tui/tui-source.c (tui_source_window_base::reset): Remove
4409         win_type parameter.
4410         * tui/tui-layout.c (make_command_window, make_source_window)
4411         (make_disasm_window, make_data_window)
4412         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4413         (reset_locator, show_source_or_disasm_and_command): Update.
4414         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4415         win_type parameter.
4416         (struct tui_source_window_base) <reset>: Likewise.
4417
4418 2019-07-17  Tom Tromey  <tom@tromey.com>
4419
4420         * tui/tui-layout.c (show_source_disasm_command): Use
4421         reset_locator.
4422         (reset_locator): New function.
4423         (init_and_make_win): Remove.
4424         (show_source_or_disasm_and_command): Use reset_locator.
4425
4426 2019-07-17  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4429         condition.
4430         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4431         Remove condition.
4432         * tui/tui-source.c (tui_source_window_base::reset): New method.
4433         * tui/tui-layout.c (make_command_window): Don't call
4434         init_and_make_win.
4435         (make_source_window, make_disasm_window): Don't call
4436         make_source_or_disasm_window.
4437         (make_data_window): Don't call init_and_make_win.  Change calling
4438         convention.
4439         (show_source_disasm_command, show_data): Simplify.
4440         (make_source_or_disasm_window): Remove.
4441         (show_source_or_disasm_and_command): Simplify.
4442         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4443         (struct tui_source_window_base) <reset>: Likewise.
4444         <execution_info>: Remove initializer.
4445         * tui/tui-data.c (tui_source_window_base): Initialize
4446         execution_info.
4447
4448 2019-07-17  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4451         variable.
4452
4453 2019-07-17  Tom Tromey  <tom@tromey.com>
4454
4455         * tui/tui.c (tui_rl_other_window): Update.
4456         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4457         superclass method first.  Always iterate over regs_content.
4458         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4459         method.
4460         * tui/tui-win.c (tui_set_focus_command): Update.
4461
4462 2019-07-17  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-win.c (tui_set_focus_command): Rename from
4465         tui_set_focus.  Call tui_enable.
4466         (tui_set_focus_command): Remove.
4467
4468 2019-07-17  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4471         refresh_window.
4472         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4473         touchwin.
4474         (tui_data_window::refresh_window): Call refresh_window on data
4475         items.  Always call superclass refresh_window.
4476         (tui_win_info::refresh): Remove.
4477         (tui_source_window_base::refresh_window): Update.
4478         (tui_refresh_all): Update.
4479         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4480         refresh_window.
4481         (show_source_or_disasm_and_command): Likewise.
4482         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4483         (struct tui_source_window_base) <refresh>: Likewise.
4484
4485 2019-07-17  Tom Tromey  <tom@tromey.com>
4486
4487         * tui/tui-winsource.c (tui_clear_source_content)
4488         (tui_show_source_content): Update.
4489         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4490         whether content is empty.
4491         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4492         Remove.
4493
4494 2019-07-17  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4497         window's contents.
4498         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4499         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4500
4501 2019-07-17  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4504         (struct tui_data_item_window): Update.
4505
4506 2019-07-17  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4509         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4510         defines.
4511
4512 2019-07-17  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-winsource.h (tui_erase_source_content)
4515         (tui_clear_source_content): Remove "display_prompt" parameter.
4516         * tui/tui-winsource.c (tui_update_source_window_as_is)
4517         (tui_update_source_windows_with_addr): Update.
4518         (tui_clear_source_content): Remove "display_prompt" parameter.
4519         (tui_erase_source_content): Likewise.  Simplify.
4520         (tui_show_source_content): Update.
4521         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4522         * tui/tui-stack.c (tui_show_frame_info): Update.
4523         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4524         Remove defines.
4525
4526 2019-07-17  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4529         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4530         parameter.
4531         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4532         parameter.
4533
4534 2019-07-17  Tom Tromey  <tom@tromey.com>
4535
4536         * tui/tui-winsource.c (tui_clear_source_content)
4537         (tui_show_source_content, tui_show_exec_info_content)
4538         (tui_clear_exec_info_content): Update.
4539         * tui/tui-stack.c (tui_show_locator_content): Update.
4540         (tui_show_frame_info): Update.
4541         * tui/tui-source.h (tui_source_window): Don't declare.
4542         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4543         from tui_source_is_displayed.
4544         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4545         Remove field.
4546         (struct tui_source_window_base) <content_in_use>: New field.  Now
4547         bool.
4548         (struct tui_source_window) <showing_source_p>: New method.
4549         (TUI_SRC_WIN): Change cast.
4550         * tui/tui-data.c (tui_initialize_static_data): Update.
4551
4552 2019-07-17  Tom Tromey  <tom@tromey.com>
4553
4554         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4555         location_matches_p.
4556         * tui/tui-source.c (tui_source_window::location_matches_p): New
4557         method.
4558         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4559         method.
4560         * tui/tui-data.h (struct tui_source_window_base)
4561         <location_matches_p>: New method.
4562         (struct tui_source_window, struct tui_disasm_window)
4563         <location_matches_p>: Likewise.
4564
4565 2019-07-17  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-win.c (tui_set_win_height_command): Rename from
4568         tui_set_win_height.
4569         (tui_set_win_height_command): Remove.
4570
4571 2019-07-17  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui-source.c (tui_source_window): New constructor.  Add
4574         observer.
4575         (~tui_source_window): New destructor.
4576         (tui_source_window::style_changed): New method.
4577         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4578         (tui_attach_detach_observers): Update.
4579         * tui/tui-data.h (struct tui_source_window): Make constructor not
4580         inline.  Add destructor.
4581         (struct tui_source_window) <style_changed>: New method.
4582         <m_observable>: New member.
4583
4584 2019-07-17  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4587         * tui/tui-win.c (tui_resize_all): Fix typo.
4588
4589 2019-07-17  Tom Tromey  <tom@tromey.com>
4590
4591         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4592         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4593         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4594         * tui/tui-win.c (window_name_completer): Use foreach.
4595         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4596         (update_tab_width): Likewise.
4597         * tui/tui-layout.c (show_layout): Update.
4598         * tui/tui-data.h (class tui_window_iterator): New.
4599         (struct all_tui_windows): New.
4600         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4601
4602 2019-07-17  Tom Tromey  <tom@tromey.com>
4603
4604         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4605         parameter.  Don't reference globals.
4606         (tui_reg_command): Update.
4607
4608 2019-07-17  Tom Tromey  <tom@tromey.com>
4609
4610         * tui/tui-regs.c (tui_show_registers): Simplify.
4611
4612 2019-07-17  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui-regs.c (tui_show_registers): Update.
4615         (tui_show_register_group): Add win_info parameter.
4616
4617 2019-07-17  Tom Tromey  <tom@tromey.com>
4618
4619         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4620         Rename from tui_display_reg_element_at_line.
4621         (tui_data_window::display_registers_from_line): Update.
4622         * tui/tui-data.h (struct tui_data_window)
4623         <display_reg_element_at_line>: New method.
4624
4625 2019-07-17  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-regs.h (tui_display_registers_from)
4628         (tui_display_registers_from_line): Don't declare.
4629         * tui/tui-windata.c (tui_data_window::display_all_data)
4630         (tui_data_window::refresh_all)
4631         (tui_data_window::do_scroll_vertical): Update.
4632         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4633         from tui_display_registers_from.
4634         (tui_display_reg_element_at_line): Update.
4635         (tui_data_window::display_registers_from_line): Rename from
4636         tui_display_registers_from_line.
4637         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4638         display_registers_from_line>: New methods.
4639
4640 2019-07-17  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4643         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4644         from tui_erase_data_content.
4645         (tui_data_window::display_all_data)
4646         (tui_data_window::refresh_all)
4647         (tui_data_window::do_scroll_vertical): Update.
4648         * tui/tui-regs.c (tui_show_registers): Update.
4649         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4650         New method.
4651
4652 2019-07-17  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4655         declare.
4656         * tui/tui-windata.c
4657         (tui_data_window::delete_data_content_windows): Rename from
4658         tui_delete_data_content_windows.
4659         (tui_data_window::display_all_data)
4660         (tui_data_window::do_scroll_vertical): Update.
4661         * tui/tui-data.h (struct tui_data_window)
4662         <delete_data_content_windows>: New method.
4663
4664 2019-07-17  Tom Tromey  <tom@tromey.com>
4665
4666         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4667         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4668
4669 2019-07-17  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4672         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4673         from tui_display_all_data.
4674         * tui/tui-win.c
4675         (tui_data_window::do_make_visible_with_new_height): Update.
4676         * tui/tui-regs.c (tui_show_registers): Update.
4677         * tui/tui-layout.c (tui_set_layout): Update.
4678         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4679         method.
4680
4681 2019-07-17  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4684         * tui/tui-windata.c (tui_display_data_from): Remove.
4685         (tui_data_window::refresh_all): Update.
4686
4687 2019-07-17  Tom Tromey  <tom@tromey.com>
4688
4689         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4690         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4691         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4692         tui_display_registers_from_line.
4693         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4694         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4695         "force_display" parameter.
4696
4697 2019-07-17  Tom Tromey  <tom@tromey.com>
4698
4699         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4700         declare.
4701         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4702         Rename from tui_first_reg_element_no_inline.
4703         (tui_display_reg_element_at_line)
4704         (tui_display_registers_from_line): Update.
4705         * tui/tui-data.h (struct tui_data_window)
4706         <first_reg_element_no_inline>: New method.
4707
4708 2019-07-17  Tom Tromey  <tom@tromey.com>
4709
4710         * tui/tui-windata.c (tui_display_data_from)
4711         (tui_data_window::do_scroll_vertical): Update.
4712         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4713         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4714         Rename from tui_line_from_reg_element_no.
4715         (tui_display_registers_from_line): Update.
4716         * tui/tui-data.h (struct tui_data_window)
4717         <line_from_reg_element_no>: New method.
4718
4719 2019-07-17  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4722         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4723         tui_last_regs_line_no.
4724         (tui_display_reg_element_at_line)
4725         (tui_display_registers_from_line): Update.
4726         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4727         method.
4728
4729 2019-07-17  Tom Tromey  <tom@tromey.com>
4730
4731         PR tui/24722:
4732         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4733         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4734         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4735         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4736         (tui_update_breakpoint_info): Likewise.
4737         * tui/tui-hooks.c (tui_event_create_breakpoint)
4738         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4739         Update.
4740
4741 2019-07-17  Tom Tromey  <tom@tromey.com>
4742
4743         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4744
4745 2019-07-17  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui-winsource.c (tui_update_source_window_as_is)
4748         (tui_update_source_windows_with_addr): Update.
4749         * tui/tui-source.h (tui_set_source_content)
4750         (tui_show_symtab_source): Add "win_info" parameter.
4751         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4752         parameter.
4753         (tui_show_symtab_source): Likewise.
4754
4755 2019-07-17  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-wingeneral.c
4758         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4759
4760 2019-07-17  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4763         (struct tui_cmd_window) <can_scroll>: New method.
4764         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4765         method.
4766
4767 2019-07-17  Tom Tromey  <tromey@adacore.com>
4768
4769         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4770         do_field_signed>: Rename.  Change type of "value".
4771         * ui-out.c (ui_out::field_signed): Rename from field_int.
4772         Change type of "value".
4773         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4774         type of "value".
4775         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4776         do_field_int.  Change type of "value".
4777         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4778         do_field_int.  Change type of "value".
4779         * tracepoint.c (trace_status_mi, tfind_1)
4780         (print_one_static_tracepoint_marker): Update.
4781         * thread.c (print_thread_info_1, print_selected_thread_frame):
4782         Update.
4783         * stack.c (print_frame, print_frame_info): Update.
4784         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4785         Update.
4786         * source.c (print_source_lines_base): Update.
4787         * skip.c (info_skip_command): Update.
4788         * record-btrace.c (btrace_ui_out_decode_error)
4789         (btrace_call_history_src_line): Update.
4790         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4791         Update.
4792         * progspace.c (print_program_space): Update.
4793         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4794         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4795         do_field_int.  Change type of "value".
4796         * mi/mi-out.c (mi_ui_out::do_table_begin)
4797         (mi_ui_out::do_table_header): Update.
4798         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4799         type of "value".
4800         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4801         (mi_cmd_data_list_changed_registers, output_register)
4802         (mi_cmd_data_read_memory, mi_load_progress)
4803         (mi_cmd_trace_frame_collected): Update.
4804         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4805         Update.
4806         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4807         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4808         (mi_cmd_var_list_children, varobj_update_one): Update.
4809         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4810         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4812         * inferior.c (print_inferior): Update.
4813         * gdb_bfd.c (print_one_bfd): Update.
4814         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4815         Update.
4816         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4817         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4818         do_field_int.  Change type of "value".
4819         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4820         do_field_int.  Change type of "value".
4821         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4822         (print_one_breakpoint_location, print_it_catch_fork)
4823         (print_one_catch_fork, print_it_catch_vfork)
4824         (print_one_catch_vfork, print_it_catch_solib)
4825         (print_it_catch_exec, print_it_ranged_breakpoint)
4826         (print_mention_watchpoint, print_mention_masked_watchpoint)
4827         (bkpt_print_it, update_static_tracepoint): Update.
4828         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4829         * break-catch-syscall.c (print_it_catch_syscall): Update.
4830         * ada-tasks.c (print_ada_task_info): Update.
4831         * ada-lang.c (print_it_exception, print_mention_exception):
4832         Update.
4833
4834 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         PR breakpoints/24541
4837         * gdbarch.c: Regenerate.
4838         * gdbarch.h: Regenerate.
4839         * gdbarch.sh: Adjust return type and parameter types for
4840         'stap_adjust_register'.
4841         (i386_stap_adjust_register): Adjust signature and return new
4842         register name.
4843         * stap-probe.c (stap_parse_register_operand): Adjust use of
4844         'gdbarch_stap_adjust_register'.
4845
4846 2019-07-17  Tom Tromey  <tromey@adacore.com>
4847
4848         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4849         declare VEC.
4850         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4851         std::vector.
4852         (struct s390_process_info): Add initializers.
4853         (s390_add_process): Use new.
4854         (s390_linux_nat_target::low_forget_process): Use delete.
4855         (s390_linux_nat_target::low_new_fork)
4856         (s390_linux_nat_target::stopped_by_watchpoint)
4857         (s390_linux_nat_target::low_prepare_to_resume)
4858         (s390_linux_nat_target::insert_watchpoint)
4859         (s390_linux_nat_target::insert_hw_breakpoint)
4860         (s390_linux_nat_target::remove_watchpoint)
4861         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4862
4863 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4864
4865         * aarch64-fbsd-nat.c: Include regcache.h.
4866         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4867         argument.
4868         (aarch64_fbsd_nat_target::fetch_registers)
4869         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4870         variable.
4871         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4872
4873 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4874
4875         * fbsd-nat.c: Include gdbarch.h.
4876
4877 2019-07-15  Tom Tromey  <tromey@adacore.com>
4878
4879         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4880
4881 2019-07-15  Tom Tromey  <tromey@adacore.com>
4882
4883         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4884         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4885         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4886         * cli-out.c (cli_ui_out::do_field_int): New method.
4887         * ui-out.c (ui_out::field_unsigned): New method.
4888         * symfile.c (generic_load): Use field_unsigned.
4889         (print_transfer_performance): Likewise.
4890         * record-btrace.c (ui_out_field_uint): Remove.
4891         (btrace_call_history_insn_range, btrace_call_history): Use
4892         field_unsigned.
4893         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4894         field_unsigned.
4895         * ui-out.h (class ui_out) <field_unsigned>: New method.
4896         <do_field_unsigned>: Likewise.
4897
4898 2019-07-15  Tom Tromey  <tromey@adacore.com>
4899
4900         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4901         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4902         * target.c (flash_erase_command): Use field_string.
4903         * infrun.c (print_signal_received_reason): Use field_string.
4904         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4905         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4906         field_string.
4907         * ada-tasks.c (print_ada_task_info): Use field_string.
4908
4909 2019-07-15  Tom Tromey  <tromey@adacore.com>
4910
4911         * target.c (flash_erase_command): Use field_core_addr.
4912         * symfile.c (generic_load): Use field_core_addr.
4913         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4914         Use field_core_addr.
4915         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4916         field_core_addr.
4917
4918 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4921         value if its desired type is smaller than a CORE_ADDR and signed.
4922
4923 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4926         of changes to field names, and use new is_reference field to
4927         decide if a property is a reference or not.
4928         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4929         field.
4930         (struct dwarf2_property_baton): Update header comment, rename
4931         'referenced_type' to 'property_type' and update comments.
4932         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4933         default property type, store in property baton, update to take
4934         accound of renamed field.
4935         (read_func_scope): Update call to attr_to_dynamic_prop.
4936         (read_array_type): Likewise.
4937         (dwarf2_per_cu_addr_sized_int_type): New function.
4938         (read_subrange_index_type): Move type finding code to
4939         dwarf2_per_cu_addr_sized_int_type.
4940         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4941         (dwarf2_per_cu_addr_type): New function.
4942         (set_die_type): Update calls to attr_to_dynamic_prop.
4943
4944 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * dwarf2read.c (read_subrange_index_type): New function.
4947         (read_subrange_type): Move code into new function and call it.
4948         * gdbtypes.c (create_range_type): Add some asserts.
4949
4950 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4953         update return statements.
4954         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4955         declaration, and update comment to match.
4956         * gdbtypes.c (resolve_dynamic_array): Update call to
4957         dwarf2_evaluate_property to match new return type.
4958
4959 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4960
4961         * valarith.c (value_subscripted_rvalue): Change lowerbound
4962         parameter type from int to LONGEST.
4963         * value.h (value_subscripted_rvalue): Likewise in declaration.
4964
4965 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * cli/cli-utils.c (info_print_command_completer): New function.
4968         * cli/cli-utils.h: Add 'completer.h' include, and forward
4969         declaration for 'struct cmd_list_element'.
4970         (info_print_command_completer): Declare.
4971         * stack.c (_initialize_stack): Add completer for 'info locals' and
4972         'info args'.
4973         * symtab.c (_initialize_symtab): Add completer for 'info
4974         variables' and 'info functions'.
4975         * NEWS: Mention completion for additional info commands.
4976
4977 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4978
4979         * cli/cli-utils.c (extract_info_print_args): Delete.
4980         (extract_arg_maybe_quoted): Delete.
4981         (info_print_options_defs): New variable.
4982         (make_info_print_options_def_group): New function.
4983         (extract_info_print_options): Define new function.
4984         * cli/cli-utils.h (extract_info_print_args): Delete.
4985         (struct info_print_options): New structure.
4986         (extract_info_print_options): Declare new function.
4987         * stack.c (info_locals_command): Update to use new
4988         extract_info_print_options, also add a header comment.
4989         (info_args_command): Likewise.
4990         * symtab.c (info_variables_command): Likewise.
4991         (info_functions_command): Likewise.
4992
4993 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4996         to extract string arguments.
4997         * common/common-utils.c (extract_string_maybe_quoted): New function.
4998         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4999
5000 2019-07-11  Tom Tromey  <tromey@adacore.com>
5001
5002         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5003         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5004         * top.h (gdbinit): Don't declare.
5005         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5006         into...
5007         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5008         * top.c (gdb_init): Don't call init_cli_cmds.
5009         (gdbinit): Remove.
5010         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5011
5012 2019-07-11  Tom Tromey  <tromey@adacore.com>
5013
5014         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5015         after it has been moved.
5016
5017 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5018
5019         * valops.c (value_must_coerce_to_target): Change return type to
5020         bool.
5021         * value.h (value_must_coerce_to_target): Likewise.
5022
5023 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5024
5025         * breakpoint.c (is_hardware_watchpoint): Remove
5026         forward-declaration.
5027         (is_masked_watchpoint): Change return type to bool.
5028         (is_tracepoint): Likewise.
5029         (is_breakpoint): Likewise.
5030         (is_hardware_watchpoint): Likewise.
5031         (is_watchpoint): Likewise.
5032         (is_no_memory_software_watchpoint): Likewise.
5033         (is_catchpoint): Likewise.
5034         (breakpoint_1): Make FILTER parameter's return type bool.
5035         is_masked_watchpoint): Change return type to bool.
5036         (save_breakpoints): Make FILTER parameter's return type bool.
5037         * breakpoint.h (is_breakpoint): Change return type to bool.
5038         (is_watchpoint): Likewise.
5039         (is_catchpoint): Likewise.
5040         (is_tracepoint): Likewise.
5041
5042 2019-07-10  Tom Tromey  <tom@tromey.com>
5043
5044         * defs.h: Don't include gdbarch.h.
5045         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5046         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5047         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5048         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5049         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5050         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5051         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5052         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5053         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5054         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5055         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5056         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5057         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5058         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5059         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5060         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5061         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5062         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5063         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5064         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5065         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5066         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5067         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5068         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5069         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5070         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5071         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5072
5073 2019-07-10  Tom Tromey  <tromey@adacore.com>
5074
5075         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5076         * breakpoint.c (init_ada_exception_breakpoint): Register as
5077         bp_catchpoint.
5078         (print_one_breakpoint_location, print_one_breakpoint): Use
5079         is_ada_exception_catchpoint.
5080         * ada-lang.c (class ada_catchpoint_location): Pass
5081         bp_loc_software_breakpoint to bp_location constructor.
5082         (is_ada_exception_catchpoint): New function.
5083
5084 2019-07-10  Tom Tromey  <tromey@adacore.com>
5085
5086         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5087         VEC.
5088         (struct arm_exidx_entry): New method operator<.
5089         (struct arm_exidx_data) <section_maps>: Change type.
5090         (arm_exidx_data_free): Remove.
5091         (arm_exidx_data_key): Change type.  Move lower.
5092         (arm_exidx_new_objfile): Update.
5093         (arm_compare_exidx_entries): Remove.
5094         (arm_find_exidx_entry, _initialize_arm_tdep)
5095
5096 2019-07-10  Tom Tromey  <tromey@adacore.com>
5097
5098         * solib-spu.c (ocl_program_data_key): Change type.
5099         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5100         Update.
5101
5102 2019-07-10  Tom Tromey  <tromey@adacore.com>
5103
5104         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5105         (struct solib_aix_inferior_data) <library_list>: Change type.
5106         (solib_aix_inferior_data_handle): Change type.
5107         (get_solib_aix_inferior_data): Update.
5108         (solib_aix_free_library_list): Remove.
5109         (library_list_start_library): Update.
5110         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5111         return type.
5112         (solib_aix_get_library_list)
5113         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5114         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5115
5116 2019-07-10  Tom Tromey  <tromey@adacore.com>
5117
5118         * solib-dsbt.c (struct dsbt_info): Add initializers.
5119         (solib_dsbt_pspace_data): Change type.
5120         (dsbt_pspace_data_cleanup): Remove.
5121         (get_dsbt_info, _initialize_dsbt_solib): Update.
5122
5123 2019-07-10  Tom Tromey  <tromey@adacore.com>
5124
5125         * spu-tdep.c (spu_overlay_data): Change type.
5126         (spu_get_overlay_table, spu_overlay_new_objfile)
5127         (_initialize_spu_tdep): Update.
5128
5129 2019-07-10  Tom Tromey  <tromey@adacore.com>
5130
5131         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5132         destructor.
5133         (dbx_objfile_data_key): Change type and declare later.
5134         (DBX_SYMFILE_INFO): Rewrite.
5135         * dbxread.c (dbx_objfile_data_key): Change type.
5136         (dbx_symfile_init): Update.
5137         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5138         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5139         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5140
5141 2019-07-10  Tom Tromey  <tromey@adacore.com>
5142
5143         * jit.c (jit_program_space_key): Change type.  Move lower.
5144         (get_jit_program_space_data): Update.
5145         (jit_program_space_data_cleanup): Remove.
5146         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5147         Update.
5148         (struct jit_program_space_data): Add initializers.
5149
5150 2019-07-10  Tom Tromey  <tromey@adacore.com>
5151
5152         * solib-darwin.c (struct darwin_info): Add initializers.
5153         (solib_darwin_pspace_data): Change type.
5154         (darwin_pspace_data_cleanup): Remove.
5155         (get_darwin_info, _initialize_darwin_solib): Update.
5156
5157 2019-07-10  Tom Tromey  <tromey@adacore.com>
5158
5159         * remote-sim.c (struct sim_inferior_data): Add initializers,
5160         constructor, and destructor.
5161         (sim_inferior_data_key): Change type.  Move lower.
5162         (check_for_duplicate_sim_descriptor): Update.
5163         (get_sim_inferior_data): Use new.  Update.
5164         (~sim_inferior_data_cleanup): Rename from
5165         sim_inferior_data_cleanup.  Simplify.
5166         (gdbsim_close_inferior, simulator_command)
5167         (sim_command_completer, _initialize_remote_sim): Update.
5168         (next_pid, INITIAL_PID): Move earlier.
5169
5170 2019-07-10  Tom Tromey  <tromey@adacore.com>
5171
5172         * python/python-internal.h (create_thread_object): Return
5173         gdbpy_ref.
5174         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5175         * python/py-inferior.c (struct threadlist_entry): Add
5176         constructor.
5177         <thread_obj>: Now a gdbpy_ref.
5178         (thread_to_thread_object): Update.
5179         (add_thread_object): Use new.
5180         (delete_thread_object): Use delete.
5181         (infpy_threads): Update.
5182         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5183         GIL.
5184
5185 2019-07-10  Tom Tromey  <tromey@adacore.com>
5186
5187         * valops.c (value_cast): Specialize error message for Ada.
5188
5189 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5190
5191         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5192
5193 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5194
5195         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5196         bpstat_should_step): Return bool, adjust comments.
5197         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5198         bpstat_should_step): Likewise.
5199
5200 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5201
5202         * features/Makefile: Use feature target descriptions for Arm.
5203         * features/arm/arm-core.c: Generate new file.
5204         * features/arm/arm-fpa.c: Likewise.
5205         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5206         * features/arm/arm-m-profile.c: Likewise.
5207         * features/arm/arm-vfpv2.c: Likewise.
5208         * features/arm/arm-vfpv3.c: Likewise.
5209         * features/arm/xscale-iwmmxt.c: Likewise.
5210         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5211
5212 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5213
5214         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5215         ptrace earlier.
5216
5217 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5218
5219         * features/aarch64-pauth.c: Regenerate.
5220
5221 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5222
5223         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5224         bool.
5225         (bpstat_what): Use false instead of 0.
5226
5227 2019-07-09  Pedro Alves  <palves@redhat.com>
5228
5229         * break-catch-throw.c (is_exception_catchpoint): New.
5230         * breakpoint.c (print_one_breakpoint_location): New parameter
5231         'raw_loc'.  Handle it.  Use
5232         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5233         looking at the breakpoint's type.
5234         (print_one_breakpoint): If handling "maint info breakpoints", also
5235         print locations of exception catchpoints.
5236         * breakpoint.h (is_exception_catchpoint): Declare.
5237
5238 2019-07-09  Pedro Alves  <palves@redhat.com>
5239
5240         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5241         "addr" field.
5242         (allocate_location_exception_catchpoint): New.
5243         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5244         (initialize_throw_catchpoint_ops): Install
5245         allocate_location_exception_catchpoint as allocate_location
5246         method.
5247         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5248         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5249         bp_loc_other.
5250         (breakpoint_address_is_meaningful): Delete.
5251         (bl_address_is_meaningful): New.
5252         (breakpoint_locations_match): Adjust comment.
5253         (bp_location_from_bp_type): New, factored out of...
5254         (bp_location::bp_location(breakpoint *)): ... this.
5255         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5256         factored out of...
5257         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5258         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5259         breakpoint_address_is_meaningful.
5260         (bp_locations_compare): Adjust comment.
5261         (update_global_location_list): Use bl_address_is_meaningful
5262         instead of breakpoint_address_is_meaningful.
5263         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5264         explicit.
5265         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5266         * python/py-breakpoint.c (bppy_get_location): No longer check
5267         whether location is null.
5268
5269 2019-07-09  Pedro Alves  <palves@redhat.com>
5270
5271         PR c++/15468
5272         * breakpoint.c (print_one_breakpoint_location): Remove
5273         single-location assert.
5274
5275 2019-07-09  Tom Tromey  <tom@tromey.com>
5276
5277         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5278         * configure: Rebuild.
5279         * configure.ac: Change common to gdbsupport.
5280         * gdbsupport: Rename from common.
5281         * acinclude.m4: Change common to gdbsupport.
5282         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5283         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5284         gdbsupport.
5285         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5286         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5287         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5288         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5289         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5290         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5291         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5292         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5293         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5294         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5295         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5296         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5297         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5298         coff-pe-read.c, command.h, compile/compile-c-support.c,
5299         compile/compile-c.h, compile/compile-cplus-symbols.c,
5300         compile/compile-cplus-types.c, compile/compile-cplus.h,
5301         compile/compile-loc2c.c, compile/compile.c, completer.c,
5302         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5303         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5304         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5305         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5306         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5307         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5308         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5309         features/aarch64-core.c, features/aarch64-fpu.c,
5310         features/aarch64-pauth.c, features/aarch64-sve.c,
5311         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5312         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5313         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5314         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5315         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5316         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5317         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5318         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5319         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5320         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5321         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5322         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5323         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5324         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5325         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5326         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5327         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5328         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5329         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5330         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5331         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5332         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5333         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5334         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5335         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5336         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5337         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5338         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5339         minsyms.c, mips-linux-tdep.c, namespace.h,
5340         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5341         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5342         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5343         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5344         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5345         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5346         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5347         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5348         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5349         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5350         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5351         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5352         procfs.c, producer.c, progspace.h, psymtab.h,
5353         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5354         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5355         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5356         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5357         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5358         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5359         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5360         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5361         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5362         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5363         target-memory.c, target.c, target.h, target/waitstatus.c,
5364         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5365         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5366         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5367         unittests/array-view-selftests.c,
5368         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5369         unittests/common-utils-selftests.c,
5370         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5371         unittests/format_pieces-selftests.c,
5372         unittests/function-view-selftests.c,
5373         unittests/lookup_name_info-selftests.c,
5374         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5375         unittests/mkdir-recursive-selftests.c,
5376         unittests/observable-selftests.c,
5377         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5378         unittests/parse-connection-spec-selftests.c,
5379         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5380         unittests/scoped_fd-selftests.c,
5381         unittests/scoped_mmap-selftests.c,
5382         unittests/scoped_restore-selftests.c,
5383         unittests/string_view-selftests.c, unittests/style-selftests.c,
5384         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5385         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5386         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5387         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5388         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5389         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5390
5391 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5394         bool value.
5395         (decode_digits_ordinary): Set explicit_line field in sal.
5396         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5397         symtab_and_line that was set on an explicit line number in
5398         assembler code.  Do always update the recorded symtab and line if
5399         we do skip the prologue.
5400
5401 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * breakpoint.c (set_breakpoint_location_function): Remove
5404         explicit_loc parameter.
5405         (momentary_breakpoint_from_master): Update call to
5406         set_breakpoint_location_function.
5407         (add_location_to_breakpoint): Likewise.
5408
5409 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5412         required features based on default bfd type when no specific bfd
5413         is present.
5414
5415 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5416
5417         * NEWS: Mention that GDB printf and eval commands can now print
5418         C-style and Ada-style convenience var strings without
5419         calling the inferior.
5420         * printcmd.c (printf_c_string): Locally print GDB internal var
5421         instead of transiting via the inferior.
5422         (printf_wide_c_string): Likewise.
5423
5424 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5425
5426         PR breakpoints/25011
5427         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5428
5429 2019-07-04  Tom Tromey  <tom@tromey.com>
5430
5431         PR tui/24724:
5432         * tui/tui-winsource.c (tui_clear_source_content): Update.
5433         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5434         (tui_update_breakpoint_info): Update.
5435         (tui_set_exec_info_content): Update.
5436         * tui/tui-source.c (tui_set_source_content_nil): Update.
5437         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5438         has_break.
5439         * tui/tui-data.h (enum tui_bp_flag): New.
5440         (tui_bp_flags): New enum flags type.
5441         (struct tui_source_element) <break_mode>: Change type.  Rename
5442         from has_break.
5443         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5444         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5445         constants.
5446         * tui/tui-winsource.h: Fix comment.
5447
5448 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5449
5450         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5451         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5452         (store_fpregs_to_thread)
5453         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5454         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5455         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5456         (IWMMXT_REGS_SIZE): Add define.
5457         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5458         (fetch_vfp_regs, store_vfp_regs)
5459         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5460         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5461
5462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5463
5464         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5465         defines.
5466         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5467         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5468         (ARM_INT_REGISTER_SIZE): ...to this.
5469         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5470         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5471         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5472         (arm_linux_collect_gregset, supply_nwfpe_register)
5473         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5474         defines.
5475         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5476         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5477         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5478         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5479         (arm_return_in_memory, arm_store_return_value)
5480         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5481         (arm_record_ld_st_multiple): Likewise.
5482         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5483         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5484
5485 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5486
5487         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5488         AARCH64_DISPLACED_MODIFIED_INSNS.
5489         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5490         (aarch64_displaced_step_copy_insn): Likewise.
5491         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5492         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5493         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5494         ARM_DISPLACED_MODIFIED_INSNS.
5495         * arm-tdep.c (arm_gdbarch_init): Likewise.
5496         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5497         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5498         (struct arm_displaced_step_closure): Use
5499         ARM_DISPLACED_MODIFIED_INSNS.
5500
5501 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5502
5503         * features/Makefile: Remove unused xml files.
5504         * features/aarch64.xml: Remove.
5505         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5506         * features/i386/amd64-avx-avx512.xml: Remove.
5507         * features/i386/amd64-avx-linux.xml: Remove.
5508         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5509         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5510         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5511         * features/i386/amd64-avx-mpx.xml: Remove.
5512         * features/i386/amd64-avx.xml: Remove.
5513         * features/i386/amd64-linux.xml: Remove.
5514         * features/i386/amd64-mpx-linux.xml: Remove.
5515         * features/i386/amd64-mpx.xml: Remove.
5516         * features/i386/amd64.xml: Remove.
5517         * features/i386/i386-avx-avx512-linux.xml: Remove.
5518         * features/i386/i386-avx-avx512.xml: Remove.
5519         * features/i386/i386-avx-linux.xml: Remove.
5520         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5521         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5522         * features/i386/i386-avx-mpx-linux.xml: Remove.
5523         * features/i386/i386-avx-mpx.xml: Remove.
5524         * features/i386/i386-avx.xml: Remove.
5525         * features/i386/i386-linux.xml: Remove.
5526         * features/i386/i386-mmx-linux.xml: Remove.
5527         * features/i386/i386-mmx.xml: Remove.
5528         * features/i386/i386-mpx-linux.xml: Remove.
5529         * features/i386/i386-mpx.xml: Remove.
5530         * features/i386/i386.xml: Remove.
5531         * features/i386/x32-avx-avx512-linux.xml: Remove.
5532         * features/i386/x32-avx-linux.xml: Remove.
5533         * features/i386/x32-linux.xml: Remove.
5534
5535 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5536
5537         * regformats/aarch64.dat: Remove.
5538         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5539         * regformats/i386/amd64-avx-linux.dat: Remove.
5540         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5541         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5542         * regformats/i386/amd64-linux.dat: Remove.
5543         * regformats/i386/amd64-mpx-linux.dat: Remove.
5544         * regformats/i386/amd64.dat: Remove.
5545         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5546         * regformats/i386/i386-avx-linux.dat: Remove.
5547         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5548         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5549         * regformats/i386/i386-linux.dat: Remove.
5550         * regformats/i386/i386-mmx-linux.dat: Remove.
5551         * regformats/i386/i386-mpx-linux.dat: Remove.
5552         * regformats/i386/i386.dat: Remove.
5553         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5554         * regformats/i386/x32-avx-linux.dat: Remove.
5555         * regformats/i386/x32-linux.dat: Remove.
5556
5557 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5558
5559         * aarch64-tdep.c: Remove xml self tests.
5560         * amd64-linux-tdep.c: Likewise.
5561         * amd64-tdep.c: Likewise.
5562         * i386-linux-tdep.c: Likewise.
5563         * i386-tdep.c: Likewise.
5564
5565 2019-07-03  Pedro Alves  <palves@redhat.com>
5566
5567         PR cli/24732
5568         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5569         (pipe_cmd_option_defs): New.
5570         (make_pipe_cmd_options_def_group): New.
5571         (pipe_command): Use gdb::option::process_options.
5572         (pipe_command_completer): New function.
5573         (_initialize_cli_cmds): Install completer for "pipe" command.
5574
5575 2019-07-03  Pedro Alves  <palves@redhat.com>
5576
5577         * cli/cli-option.c (union option_value) <string>: New field.
5578         (struct option_def_and_value): Add ctor, move ctor, dtor and
5579         use DISABLE_COPY_AND_ASSIGN.
5580         (option_def_and_value::clear_value): New.
5581         (parse_option, save_option_value_in_ctx, get_val_type_str)
5582         (add_setshow_cmds_for_options): Handle var_string.
5583         * cli-option.h (union option_def::var_address) <string>: New
5584         field.
5585         (struct string_option_def): New.
5586         * maint-test-options.c (struct test_options_opts): Add default
5587         ctor and use DISABLE_COPY_AND_ASSIGN.
5588         <string_opt>: New field.
5589         (test_options_opts::~test_options_opts): New.
5590         (test_options_opts::dump): Also dump "-string".
5591         (test_options_option_defs): Install "string.
5592
5593 2019-07-03  Pedro Alves  <palves@redhat.com>
5594
5595         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5596         option_value with a null enumeration.
5597         (complete_options): Save the option values in the context.
5598         (save_option_value_in_ctx): New, factored out from ...
5599         (process_options): ... here.
5600         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5601         of the function.
5602         * maint-test-options.c (test_options_opts::dump): New, factored
5603         out from ...
5604         (maintenance_test_options_command_mode): ... here.
5605         (maintenance_test_options_command_completion_result): Delete.
5606         (maintenance_test_options_command_completion_text): Update
5607         comment.
5608         (maintenance_show_test_options_completion_result): Change
5609         prototype.  Just print
5610         maintenance_test_options_command_completion_text.
5611         (save_completion_result): New.
5612         (maintenance_test_options_completer_mode): Pass options context to
5613         complete_options, and then save a dump.
5614         (_initialize_maint_test_options): Use add_cmd to install "maint
5615         show test-options-completion-result".
5616
5617 2019-07-03  Pedro Alves  <palves@redhat.com>
5618
5619         * NEWS (New commands): Mention "with" and "maint with".
5620         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5621         (with_command, with_command_completer): New.
5622         (pipe_command): Adjust to new repeat_previous
5623         interface.
5624         (_initialize_cli_cmds): Install the "with" command and its "w"
5625         alias.
5626         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5627         declarations.
5628         * cli/cli-setshow.c (parse_cli_var_uinteger)
5629         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5630         argument strings for all var_types.
5631         (get_setshow_command_value_string): New, factored out from ...
5632         (do_show_command): ... this.
5633         * cli/cli-setshow.h: Include <string>.
5634         (get_setshow_command_value_string): Declare.
5635         * command.h (repeat_previous): Now returns const char *.  Adjust
5636         comment.
5637         * maint.c: Include "cli/cli-cmds.h".
5638         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5639         (_initialize_maint_cmds): Register the "maintenance with" command.
5640         * top.c (repeat_previous): Move bits from pipe_command here:
5641         Return the saved command line, if any; error out if there's no
5642         command to relaunch.
5643
5644 2019-07-03  Pedro Alves  <palves@redhat.com>
5645
5646         * NEWS (New commands): Mention "maint set/show test-settings"
5647         instead of "maint test-settings".
5648         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5649         (maintenance_test_settings_set_list): Rename to ...
5650         (maintenance_set_test_settings_list): ... this.
5651         (maintenance_test_settings_show_list): Rename to  ...
5652         (maintenance_show_test_settings_list): ... this.
5653         (maintenance_test_settings_cmd): Delete.
5654         (maintenance_test_settings_set_cmd): ...
5655         (maintenance_set_test_settings_cmd): ... this.
5656         (maintenance_test_settings_show_cmd): ...
5657         (maintenance_show_test_settings_cmd): ... this.
5658         (maintenance_test_settings_show_value_cmd):
5659         (maintenance_show_test_settings_value_cmd): ... this.
5660         (_initialize_maint_test_settings): No longer install the "maint
5661         test-settings" prefix command.  Rename "maint test-settings set"
5662         to "maint set test-settings", and "maint test-settings show" to
5663         "maint show test-settings".  Adjust all subcommands.
5664
5665 2019-07-03  Pedro Alves  <palves@redhat.com>
5666
5667         * maint-test-settings.c: Fix file's intro comment.  Replace all
5668         references to "test-options" with references to "test-settings",
5669         in comments.
5670
5671 2019-07-03  Pedro Alves  <palves@redhat.com>
5672
5673         * maint-test-settings.c (maintenance_test_settings_xxx)
5674         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5675         New.
5676         (maintenance_test_settings_enums): Use them.
5677         (maintenance_test_settings_enum): Default to
5678         maintenance_test_settings_xxx.
5679         (_initialize_maint_test_settings): Initialize
5680         MAINTENANCE_TEST_SETTINGS_FILENAME.
5681
5682 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5683
5684         * breakpoint.h (remove_breakpoints_inf): Change return type to
5685         void, move function documentation here.
5686         * breakpoint.c (remove_breakpoints_inf): Change return type to
5687         void, move function documentation to header.
5688
5689 2019-07-02  Pedro Alves  <palves@redhat.com>
5690
5691         * NEWS (Completion improvements): Mention "info threads".
5692         * thread.c (struct info_threads_opts, info_threads_option_defs)
5693         (make_info_threads_options_def_group): New.
5694         (info_threads_command): Use gdb::option::process_options.
5695         (info_threads_command_completer): New.
5696         (_initialize_thread): Use gdb::option::build_help to build the
5697         help text for "info threads".
5698
5699 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5700
5701         * defs.h (generic_load): Move from here...
5702         * symfile.h (generic_load): ... to here.  Rename name parameter
5703         to args.
5704         * symfile.c (generic_load): Add comment.
5705
5706 2019-07-01  Tom Tromey  <tromey@adacore.com>
5707
5708         * dwarf2read.c
5709         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5710         declaration of without_params.  Fix formatting.
5711
5712 2019-07-01  Tom Tromey  <tromey@adacore.com>
5713
5714         * ada-exp.y (find_primitive_type): Update.
5715         * ada-lang.h (ada_lookup_symbol): Update.
5716         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5717         parameter.
5718         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5719
5720 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5721
5722         PR breakpoints/24541
5723         * gdbarch.c: Regenerate.
5724         * gdbarch.h: Regenerate.
5725         * gdbarch.sh: Add 'stap_adjust_register'.
5726         * i386-tdep.c: Include '<unordered_set>'.
5727         (i386_stap_adjust_register): New function.
5728         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5729         * stap-probe.c (stap_parse_register_operand): Call
5730         'gdbarch_stap_adjust_register'.
5731
5732 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5733
5734         PR python/24742
5735         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5736         * python/python.c (do_start_initialization): Use 'xmalloc'
5737         instead of 'PyMem_Malloc'.
5738
5739 2019-06-28  Tom Tromey  <tromey@adacore.com>
5740
5741         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5742         for Ada.
5743
5744 2019-06-27  Tom Tromey  <tromey@adacore.com>
5745
5746         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5747         objfile_key.
5748         (arm_find_mapping_symbol, arm_record_special_symbol)
5749         (_initialize_arm_tdep): Update.
5750         (arm_objfile_data_free): Remove.
5751
5752 2019-06-27  Tom Tromey  <tromey@adacore.com>
5753
5754         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5755         to cp_print_static_field.
5756
5757 2019-06-26  Tom Tromey  <tromey@adacore.com>
5758
5759         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5760         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5761         declare.
5762
5763 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5764
5765         * features/aarch64-core.c (create_feature_aarch64_core):
5766         Regenerate.
5767         * features/aarch64-core.xml: Add cpsr flags.
5768
5769 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5770
5771         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5772         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5773
5774 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5775
5776         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5777         field.
5778         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5779         use.
5780         (arm_record_special_symbol): Don't insert new symbol in sorted
5781         position, push it at the end.
5782
5783 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5784
5785         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5786         (arm_mapping_symbol_s): Remove.
5787         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5788         (arm_mapping_symbol_vec): New typedef.
5789         (struct arm_per_objfile): Add constructor.
5790         <section_maps>: Change type to
5791         std::unique_ptr<arm_mapping_symbol_vec[]>.
5792         (arm_compare_mapping_symbols): Remove.
5793         (arm_find_mapping_symbol): Adjust to section_maps type change.
5794         (arm_objfile_data_free): Call delete on arm_per_objfile.
5795         (arm_record_special_symbol): Adjust to section_maps type change.
5796         Allocate arm_per_objfile with new.
5797
5798 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5799
5800         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5801         with the command prefix.
5802
5803 2019-06-25  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5806         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5807
5808 2019-06-25  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5811         type.
5812         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5813         protected.
5814
5815 2019-06-25  Tom Tromey  <tom@tromey.com>
5816
5817         * tui/tui-winsource.c
5818         (tui_source_window_base::set_is_exec_point_at): Add check against
5819         LOA_ADDRESS.
5820
5821 2019-06-25  Tom Tromey  <tom@tromey.com>
5822
5823         * tui/tui-source.c (tui_set_source_content): Don't check before
5824         xfree.
5825         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5826
5827 2019-06-25  Tom Tromey  <tom@tromey.com>
5828
5829         * tui/tui-winsource.h (tui_update_source_window_as_is)
5830         (tui_alloc_source_buffer, tui_line_is_displayed)
5831         (tui_addr_is_displayed): Change type of win_info.
5832         * tui/tui-winsource.c (tui_update_source_window_as_is)
5833         (tui_clear_source_content, tui_show_source_line)
5834         (tui_show_source_content, tui_source_window_base::refill)
5835         (tui_source_window_base::set_is_exec_point_at)
5836         (tui_source_window_base::set_is_exec_point_at)
5837         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5838         (tui_alloc_source_buffer, tui_line_is_displayed)
5839         (tui_addr_is_displayed): Change type of win_info.  Update.
5840         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5841         (tui_source_window_base::do_make_visible_with_new_height):
5842         Update.
5843         * tui/tui-source.c (tui_set_source_content)
5844         (tui_set_source_content_nil)
5845         (tui_source_window::do_scroll_vertical): Update.
5846         * tui/tui-layout.c (show_layout): Update.
5847         * tui/tui-disasm.c (tui_set_disassem_content)
5848         (tui_disasm_window::do_scroll_vertical): Update.
5849         * tui/tui-data.h (tui_win_content): Remove.
5850         (struct tui_gen_win_info) <content, content_size>: Remove.
5851         (struct tui_source_element): Add initializers and destructor.
5852         (union tui_which_element, struct tui_win_element): Remove.
5853         (struct tui_source_window_base) <content>: New field.
5854         (struct tui_data_window): Remove destructor.
5855         (tui_alloc_content, tui_free_win_content)
5856         (tui_free_all_source_wins_content): Don't declare.
5857         * tui/tui-data.c (tui_initialize_static_data): Update.
5858         (init_content_element, tui_alloc_content): Remove.
5859         (~tui_gen_win_info): Update.
5860         (~tui_data_window, tui_free_all_source_wins_content)
5861         (tui_free_win_content, free_content, free_content_elements):
5862         Remove.
5863
5864 2019-06-25  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-winsource.h (tui_clear_source_content)
5867         (tui_erase_source_content, tui_show_source_content): Change type
5868         of win_info.
5869         * tui/tui-winsource.c (tui_clear_source_content)
5870         (tui_erase_source_content, tui_show_source_content): Change type
5871         of win_info.
5872         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5873         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5874         win_info.
5875         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5876         win_info.
5877         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5878
5879 2019-06-25  Tom Tromey  <tom@tromey.com>
5880
5881         * tui/tui-winsource.c (tui_clear_source_content)
5882         (tui_source_window_base::set_is_exec_point_at): Update.
5883         * tui/tui-source.c (tui_set_source_content_nil): Update.
5884         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5885         a bool.
5886         * tui/tui-data.c (init_content_element): Update.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5891         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5892         * tui/tui-layout.c (init_and_make_win): Update.
5893         * tui/tui.h (enum tui_win_type): Update.
5894         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5895         tui_win_is_auxillary.
5896         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5897         tui_win_is_auxillary.
5898
5899 2019-06-25  Tom Tromey  <tom@tromey.com>
5900
5901         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5902         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5903         (tui_delete_data_content_windows, tui_display_all_data)
5904         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5905         Update.
5906         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5907         * tui/tui-regs.c (tui_last_regs_line_no)
5908         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5909         (tui_show_registers): Update.
5910         (tui_show_register_group): Return void.  Update.
5911         (tui_display_registers_from, tui_display_reg_element_at_line)
5912         (tui_display_registers_from_line, tui_check_register_values):
5913         Update.
5914         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5915         member.
5916         (struct tui_data_window) <regs_content>: Now a std::vector.
5917         <regs_content_count>: Remove.
5918         (tui_add_content_elements, tui_free_data_content): Don't declare.
5919         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5920         (init_content_element): Remove DATA_WIN case.  Add assert.
5921         (tui_add_content_elements): Remove.
5922         (tui_data_window): Update.
5923         (tui_free_data_content): Remove.
5924         (free_content_elements): Remove DATA_WIN case.
5925
5926 2019-06-25  Tom Tromey  <tom@tromey.com>
5927
5928         * tui/tui-data.c (tui_data_item_window): Update.
5929         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5930         * tui/tui-windata.c (tui_display_all_data)
5931         (tui_display_data_from_line): Update.
5932         (tui_check_data_values): Remove.
5933         * tui/tui-regs.c (tui_show_register_group)
5934         (tui_display_reg_element_at_line): Update.
5935         * tui/tui-hooks.c (tui_register_changed)
5936         (tui_refresh_frame_and_register_information): Call
5937         tui_check_register_values.
5938         * tui/tui-data.h (struct tui_data_window) <data_content,
5939         data_content_count, data_type>: Remove.
5940         (enum tui_data_type): Remove.
5941
5942         * tui/tui-data.c (tui_data_window::clear_detail)
5943         (~tui_data_window): Update.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5948         declare.
5949         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5950         Rename from tui_first_data_item_displayed.  Update.
5951         (tui_data_window::refresh_all)
5952         (tui_data_window::do_scroll_vertical): Update.
5953         * tui/tui-data.h (struct tui_data_window)
5954         <first_data_item_displayed>: Declare new method.
5955
5956 2019-06-25  Tom Tromey  <tom@tromey.com>
5957
5958         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5959         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5960         contents...
5961         (tui_initialize_static_data): ...here.
5962
5963 2019-06-25  Tom Tromey  <tom@tromey.com>
5964
5965         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5966         (tui_display_registers_from, tui_check_register_values): Update.
5967         (tui_display_register): Remove win_info parameter; update.
5968         (tui_get_register): Change type of parameters.
5969         * tui/tui-data.h (struct tui_data_element): Remove.
5970         (union tui_which_element) <data>: Remove.
5971         <data_window>: Change type.
5972         (struct tui_data_item_window): New.
5973         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5974         case.  Add assert.
5975         (~tui_data_item_window): New destructor.
5976         (free_content_elements): Remove DATA_ITEM_WIN case.
5977
5978 2019-06-25  Tom Tromey  <tom@tromey.com>
5979
5980         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5981         Remove.
5982
5983 2019-06-25  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-data.h (struct tui_command_element): Remove.
5986         (union tui_which_element) <command>: Remove.
5987         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5988         assert.
5989         (free_content_elements): Remove CMD_WIN case.
5990
5991 2019-06-25  Tom Tromey  <tom@tromey.com>
5992
5993         * tui/tui-layout.c (tui_set_layout): Update.
5994         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5995         * tui/tui-data.c (layout_def): Update.
5996
5997 2019-06-25  Tom Tromey  <tom@tromey.com>
5998
5999         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6000         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6001         (tui_source_window_base::set_new_height): Update.
6002         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6003         Update.
6004         (tui_set_locator_fullname, tui_set_locator_info)
6005         (tui_show_frame_info): Update.
6006         * tui/tui-source.c (tui_set_source_content)
6007         (tui_source_is_displayed): Update.
6008         * tui/tui-layout.c (show_source_disasm_command, show_data)
6009         (show_source_or_disasm_and_command): Update.
6010         * tui/tui-disasm.c (tui_set_disassem_content)
6011         (tui_get_begin_asm_address): Update.
6012         * tui/tui-data.h (struct tui_locator_element): Remove.
6013         (union tui_which_element) <locator>: Remove.
6014         (struct tui_locator_window): New.
6015         (tui_locator_win_info_ptr): Change return type.
6016         * tui/tui-data.c (_locator): Change type.
6017         (tui_locator_win_info_ptr): Change return type.
6018         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6019         (tui_alloc_content): Add assert.
6020
6021 2019-06-25  Tom Tromey  <tom@tromey.com>
6022
6023         * tui/tui-winsource.c
6024         (tui_exec_info_window::maybe_allocate_content): New method.
6025         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6026         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6027         (make_source_or_disasm_window): Add cast.
6028         * tui/tui-data.h (union tui_which_element) <simple_string>:
6029         Remove.
6030         (struct tui_source_info): New.
6031         (struct tui_source_window_base) <execution_info>: Change type.
6032         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6033         case, and add assert.
6034         (tui_alloc_content): Add assert.
6035
6036 2019-06-25  Tom Tromey  <tom@tromey.com>
6037
6038         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6039         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6040         * tui/tui-data.c (tui_alloc_win_info): Remove.
6041
6042 2019-06-25  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6045         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6046         can_highlight.
6047
6048 2019-06-25  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6051         make_visible_with_new_height method.
6052         (tui_win_info::make_visible_with_new_height): New method.
6053         (tui_source_window_base::do_make_visible_with_new_height)
6054         (tui_data_window::do_make_visible_with_new_height)
6055         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6056         (make_visible_with_new_height): Remove.
6057         (tui_resize_all, tui_adjust_win_heights): Use
6058         make_visible_with_new_height method.
6059         * tui/tui-data.h (struct tui_win_info)
6060         <do_make_visible_with_new_height, make_visible_with_new_height>:
6061         New methods.
6062         (struct tui_source_window_base, struct tui_data_window)
6063         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6064         methods.
6065
6066 2019-06-25  Tom Tromey  <tom@tromey.com>
6067
6068         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6069         method.
6070         (update_tab_width): Call update_tab_width method.
6071         * tui/tui-data.h (struct tui_win_info)
6072         (struct tui_source_window_base) <update_tab_width>: New methods.
6073
6074 2019-06-25  Tom Tromey  <tom@tromey.com>
6075
6076         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6077         parameter.
6078         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6079         parameter.
6080         (tui_gen_win_info::make_visible): Update.
6081         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6082         parameter.
6083         * tui/tui-data.h (enum tui_box): New enum.
6084         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6085
6086 2019-06-25  Tom Tromey  <tom@tromey.com>
6087
6088         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6089         init_and_make_win for EXEC_INFO_WIN.
6090         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6091         longer inline.
6092         (struct tui_win_info) <~tui_win_info>: Inline.
6093         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6094         Don't declare.
6095         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6096         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6097         Remove.
6098         (tui_initialize_static_data): Update.
6099         (~tui_gen_win_info): Handle more cleanup here.
6100         (~tui_source_window_base): Delete "execution_info".
6101         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6102
6103 2019-06-25  Tom Tromey  <tom@tromey.com>
6104
6105         * tui/tui-layout.c (make_command_window): Don't set
6106         can_highlight.
6107         (show_source_disasm_command): Call the reset method.
6108         (show_data): Don't set can_highlight.  Call the reset method.
6109         (tui_gen_win_info::reset): Rename from init_gen_win_info
6110         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6111         (show_source_or_disasm_and_command): Call the reset method.
6112         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6113         (struct tui_cmd_window): Set can_highlight.
6114
6115 2019-06-25  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6118         from make_visible.
6119         (tui_make_visible, tui_make_invisible): Rewrite.
6120         (tui_win_info::make_visible): Remove.
6121         (tui_source_window_base::make_visible): Update.
6122         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6123         method.  Moved from...
6124         (struct tui_win_info) <make_visible>: ...here.
6125
6126 2019-06-25  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-winsource.c
6129         (tui_source_window_base::do_scroll_horizontal): Remove direction
6130         parameter.
6131         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6132         direction parameter.
6133         * tui/tui-win.c (tui_win_info::forward_scroll)
6134         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6135         (tui_win_info::right_scroll): Update.
6136         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6137         direction parameter.
6138         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6139         direction parameter.
6140         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6141         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6142         Remove direction parameter.
6143         (struct tui_source_window_base, struct tui_source_window)
6144         (struct tui_disasm_window, struct tui_data_window)
6145         (struct tui_cmd_window): Update.
6146
6147 2019-06-25  Tom Tromey  <tom@tromey.com>
6148
6149         * tui/tui-winsource.h (tui_set_exec_info_content)
6150         (tui_show_exec_info_content, tui_erase_exec_info_content)
6151         (tui_clear_exec_info_content, tui_update_exec_info): Change
6152         argument to tui_source_window_base.
6153         * tui/tui-winsource.c (tui_set_exec_info_content)
6154         (tui_show_exec_info_content, tui_erase_exec_info_content)
6155         (tui_clear_exec_info_content, tui_update_exec_info): Change
6156         argument to tui_source_window_base.
6157
6158 2019-06-25  Tom Tromey  <tom@tromey.com>
6159
6160         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6161         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6162
6163 2019-06-25  Tom Tromey  <tom@tromey.com>
6164
6165         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6166         check.
6167
6168 2019-06-25  Tom Tromey  <tom@tromey.com>
6169
6170         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6171         type to void.
6172         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6173         type to void.
6174         * tui/tui-source.c (tui_set_source_content): Update.
6175         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6176
6177 2019-06-25  Tom Tromey  <tom@tromey.com>
6178
6179         * tui/tui-win.c (window_name_completer, tui_set_focus)
6180         (tui_all_windows_info): Use name method.
6181         * tui/tui-data.h (struct tui_gen_win_info)
6182         (struct tui_source_window, struct tui_disasm_window)
6183         (struct tui_data_window, struct tui_cmd_window) <name>: New
6184         method.
6185         (tui_win_name): Don't declare.
6186         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6187         (tui_win_name): Remove.
6188
6189 2019-06-25  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-winsource.h (tui_update_source_window)
6192         (tui_update_source_window_as_is): Change parameter type.
6193         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6194         to be a tui_source_window_base.
6195         (tui_update_source_window_as_is): Likewise.
6196         * tui/tui-win.c (make_visible_with_new_height): Update.
6197
6198 2019-06-25  Tom Tromey  <tom@tromey.com>
6199
6200         * tui/tui-winsource.c (tui_erase_source_content)
6201         (tui_show_source_content, tui_show_exec_info_content)
6202         (tui_erase_exec_info_content): Use refresh_window method.
6203         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6204         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6205         from tui_refresh_win.
6206         (tui_data_window::refresh_window): New method.
6207         (tui_win_info::refresh, tui_source_window_base::refresh)
6208         (tui_refresh_all): Use refresh_window method.
6209         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6210         method.
6211         * tui/tui-regs.c (tui_display_register): Call refresh_window
6212         method.
6213         * tui/tui-layout.c (show_source_disasm_command)
6214         (show_source_or_disasm_and_command): Call refresh_window method.
6215         * tui/tui-data.h (struct tui_gen_win_info)
6216         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6217         New method.
6218
6219 2019-06-25  Tom Tromey  <tom@tromey.com>
6220
6221         * tui/tui.c (tui_rl_other_window, tui_enable)
6222         (tui_is_window_visible, tui_get_command_dimension): Update.
6223         * tui/tui-winsource.c (tui_update_source_window_as_is)
6224         (tui_clear_source_content, tui_erase_source_content)
6225         (tui_show_source_line, tui_source_window_base::refill)
6226         (tui_source_window_base::do_scroll_horizontal)
6227         (tui_source_window_base::set_is_exec_point_at)
6228         (tui_update_breakpoint_info, tui_set_exec_info_content)
6229         (tui_alloc_source_buffer, tui_line_is_displayed)
6230         (tui_addr_is_displayed): Update.
6231         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6232         (tui_check_and_display_highlight_if_needed)
6233         (tui_win_info::make_visible, tui_win_info::refresh)
6234         (tui_refresh_all): Update.
6235         * tui/tui-windata.c (tui_first_data_item_displayed)
6236         (tui_delete_data_content_windows, tui_erase_data_content)
6237         (tui_display_all_data, tui_data_window::refresh_all)
6238         (tui_check_data_values): Update.
6239         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6240         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6241         (tui_win_info::backward_scroll, tui_refresh_all_win)
6242         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6243         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6244         (tui_source_window_base::set_new_height)
6245         (tui_data_window::set_new_height)
6246         (make_invisible_and_set_new_height)
6247         (make_visible_with_new_height, new_height_ok)
6248         (parse_scrolling_args): Update.
6249         * tui/tui-stack.c (tui_show_frame_info): Update.
6250         * tui/tui-source.c (tui_set_source_content)
6251         (tui_set_source_content_nil, tui_source_is_displayed)
6252         (tui_source_window::do_scroll_vertical): Update.
6253         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6254         (tui_display_registers_from, tui_display_reg_element_at_line)
6255         (tui_check_register_values, tui_reg_command): Update.
6256         * tui/tui-layout.c (tui_default_win_height)
6257         (show_source_disasm_command, show_data, init_and_make_win)
6258         (show_source_or_disasm_and_command): Update.
6259         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6260         (tui_redisplay_readline, tui_mld_flush)
6261         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6262         (tui_getc): Update.
6263         * tui/tui-disasm.c (tui_set_disassem_content)
6264         (tui_disasm_window::do_scroll_vertical): Update.
6265         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6266         Now virtual.
6267         (struct tui_win_info): Derive from tui_gen_win_info.
6268         <~tui_win_info>: Mark as override.
6269         <generic>: Remove member.
6270         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6271         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6272         (~tui_data_window, ~tui_win_info)
6273         (tui_free_all_source_wins_content): Update.
6274         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6275
6276 2019-06-25  Tom Tromey  <tom@tromey.com>
6277
6278         * tui/tui-layout.c (init_and_make_win): Use new.
6279         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6280         destructor, initializers.
6281         (tui_alloc_generic_win_info): Don't declare.
6282         * tui/tui-data.c (_locator): Add argument to constructor.
6283         (source_win, disasm_win): New globals.
6284         (exec_info): Remove.
6285         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6286         Update.
6287         (tui_alloc_generic_win_info): Remove.
6288         (init_content_element): Use new.
6289         (tui_win_info::tui_win_info): Update.
6290         (free_content_elements) <case DATA_WIN>: Use delete.
6291
6292 2019-06-25  Tom Tromey  <tom@tromey.com>
6293
6294         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6295         * tui/tui-windata.c (tui_first_data_item_displayed)
6296         (tui_delete_data_content_windows): Update.
6297         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6298         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6299         (tui_display_registers_from, tui_check_register_values): Update.
6300         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6301         pointer.
6302         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6303         window.
6304         (tui_free_data_content): Update.
6305         (free_content_elements) <case DATA_WIN>: Free the window.
6306
6307 2019-06-25  Tom Tromey  <tom@tromey.com>
6308
6309         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6310         Update.
6311         * tui/tui-layout.c (make_command_window)
6312         (show_source_disasm_command, show_data, init_and_make_win)
6313         (show_source_or_disasm_and_command): Update.
6314         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6315         method.
6316         <can_highight, is_highlighted>: Now bool.
6317         (tui_set_win_highlight): Don't declare.
6318         * tui/tui-data.c (tui_set_win_highlight): Remove.
6319
6320 2019-06-25  Tom Tromey  <tom@tromey.com>
6321
6322         * tui/tui-wingeneral.c (make_visible): Remove check of window
6323         type.
6324
6325 2019-06-25  Tom Tromey  <tom@tromey.com>
6326
6327         * tui/tui-win.c (tui_win_info::max_height)
6328         (tui_cmd_window::max_height): New methods.
6329         (new_height_ok): Call max_height.
6330         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6331         <max_height>: New method.
6332
6333 2019-06-25  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-win.c (tui_source_window_base::set_new_height)
6336         (tui_data_window::set_new_height): New methods.
6337         (make_invisible_and_set_new_height): Call set_new_height method.
6338         * tui/tui-data.h (struct tui_win_info)
6339         (struct tui_source_window_base, struct tui_data_window)
6340         <set_new_height>: New method.
6341
6342 2019-06-25  Tom Tromey  <tom@tromey.com>
6343
6344         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6345         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6346         tui_refresh_data_win.
6347         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6348         method.
6349         (tui_refresh_all_win): Call the refresh_all method.
6350         (tui_set_focus): Likewise.
6351         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6352         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6353         Likewise.
6354
6355 2019-06-25  Tom Tromey  <tom@tromey.com>
6356
6357         * tui/tui-winsource.h (tui_refill_source_window)
6358         (tui_set_is_exec_point_at): Don't declare.
6359         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6360         (tui_source_window_base::refill): Rename from
6361         tui_refill_source_window.
6362         (tui_source_window_base::do_scroll_horizontal): Update.
6363         (tui_source_window_base::set_is_exec_point_at): Rename from
6364         tui_set_is_exec_point_at.
6365         (tui_update_all_breakpoint_info): Update.
6366         * tui/tui-stack.c (tui_show_frame_info): Update.
6367         * tui/tui-layout.c (show_data): Add cast.
6368         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6369         * tui/tui-data.h (struct tui_source_window_base) <refill,
6370         set_is_exec_point_at>: New methods.
6371         (tui_source_windows, tui_add_to_source_windows): Update types.
6372         (tui_add_to_source_windows): Remove redundant declaration.
6373         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6374         (tui_source_windows): Change return type.
6375         (tui_clear_source_windows_detail): Update.
6376         (tui_add_to_source_windows): Change type of parameter.
6377         (tui_free_all_source_wins_content): Update.
6378
6379 2019-06-25  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-wingeneral.c (tui_win_info::refresh)
6382         (tui_source_window_base::refresh): New methods.
6383         (tui_refresh_all): Call the refresh method.
6384         * tui/tui-data.h (struct tui_win_info)
6385         (struct tui_source_window_base) <refresh>: New method.
6386
6387 2019-06-25  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui.h (tui_is_window_visible): Return bool.
6390         * tui/tui.c (tui_is_window_visible): Return bool.
6391         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6392         (tui_make_visible, tui_make_invisible)
6393         (tui_win_info::make_visible)
6394         (tui_source_window_base::make_visible, make_all_visible)
6395         (tui_make_all_visible, tui_make_all_invisible): Update.
6396         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6397         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6398         bool.
6399         (struct tui_win_info, struct tui_source_window_base)
6400         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6401         * tui/tui-data.c (tui_init_generic_part): Update.
6402
6403 2019-06-25  Tom Tromey  <tom@tromey.com>
6404
6405         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6406         (tui_source_window_base::make_visible): New methods.
6407         (make_all_visible): Make method call.
6408         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6409         (struct tui_source_window_base, struct tui_cmd_window): Override
6410         make_visible.
6411         (tui_win_is_source_type): Don't declare.
6412         * tui/tui-data.c (tui_win_is_source_type): Remove.
6413
6414 2019-06-25  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6417         NULL check.
6418
6419 2019-06-25  Tom Tromey  <tom@tromey.com>
6420
6421         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6422         Inline constructor.  Add initializers for members.
6423         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6424         constructors; now inline in class.
6425
6426 2019-06-25  Tom Tromey  <tom@tromey.com>
6427
6428         * tui/tui-regs.c (tui_show_registers): Update.
6429         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6430         bool.
6431         * tui/tui-data.c (tui_data_window::clear_detail)
6432         (tui_data_window): Update.
6433
6434 2019-06-25  Tom Tromey  <tom@tromey.com>
6435
6436         * tui/tui-windata.c (tui_display_all_data)
6437         (tui_display_data_from_line, tui_display_data_from)
6438         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6439         Update.
6440         * tui/tui-regs.c (tui_last_regs_line_no)
6441         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6442         (tui_show_registers, tui_show_register_group)
6443         (tui_display_registers_from, tui_display_reg_element_at_line)
6444         (tui_display_registers_from_line, tui_check_register_values)
6445         (tui_reg_next, tui_reg_prev): Update.
6446         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6447         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6448         tui_data_window.
6449         (struct tui_win_info) <detail>: Remove.  Add new fields from
6450         tui_data_info.
6451         (TUI_DATA_WIN): Add cast.
6452         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6453         (~tui_data_window): Simplify.
6454
6455 2019-06-25  Tom Tromey  <tom@tromey.com>
6456
6457         * tui/tui-layout.c (show_source_disasm_command)
6458         (show_source_or_disasm_and_command): Update.
6459         * tui/tui-io.c (update_cmdwin_start_line)
6460         (tui_redisplay_readline): Update.
6461         * tui/tui-data.h (struct tui_command_info): Remove.
6462         (struct tui_win_info) <detail>: Remove command_info member.
6463         (struct tui_data_window) <start_line>: New member, from
6464         tui_command_info.
6465         (TUI_CMD_WIN): Add casts.
6466
6467 2019-06-25  Tom Tromey  <tom@tromey.com>
6468
6469         * tui/tui-winsource.c (tui_update_source_window)
6470         (tui_refill_source_window)
6471         (tui_source_window_base::do_scroll_horizontal)
6472         (tui_update_breakpoint_info, tui_set_exec_info_content)
6473         (tui_show_exec_info_content, tui_erase_exec_info_content)
6474         (tui_clear_exec_info_content): Update.
6475         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6476         Update.
6477         * tui/tui-win.c (make_invisible_and_set_new_height)
6478         (make_visible_with_new_height): Update.
6479         * tui/tui-source.c (tui_set_source_content)
6480         (tui_show_symtab_source): Update.
6481         * tui/tui-layout.c (extract_display_start_addr)
6482         (show_source_disasm_command, show_data)
6483         (make_source_or_disasm_window)
6484         (show_source_or_disasm_and_command): Update.
6485         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6486         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6487         "gdbarch".
6488         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6489         to tui_source_window_base.
6490         (struct tui_win_info) <detail>: Remove source_info member.
6491         (struct tui_source_window_base) <has_locator>: Inline.
6492         Move contents from tui_source_info; rename has_locator member to
6493         m_has_locator.
6494         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6495         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6496         header file.
6497         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6498         Simplify.
6499         (tui_free_all_source_wins_content): Cast to
6500         tui_source_window_base.
6501
6502 2019-06-25  Tom Tromey  <tom@tromey.com>
6503
6504         * tui/tui-win.c (make_invisible_and_set_new_height)
6505         (make_visible_with_new_height): Call has_locator method.
6506         * tui/tui-layout.c (show_source_disasm_command, show_data)
6507         (show_source_or_disasm_and_command): Update for bool change.
6508         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6509         (tui_win_info) <has_locator>: New method.
6510         (struct tui_source_window_base) <has_locator>: New method.
6511         (tui_win_has_locator): Don't declare.
6512         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6513         from tui_win_has_locator.
6514         (tui_source_window_base): Use false, not FALSE.
6515
6516 2019-06-25  Tom Tromey  <tom@tromey.com>
6517
6518         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6519         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6520         clear_detail method directly.
6521         (tui_clear_win_detail): Remove.
6522
6523 2019-06-25  Tom Tromey  <tom@tromey.com>
6524
6525         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6526         "this", not TUI_DISASM_WIN.
6527
6528 2019-06-25  Tom Tromey  <tom@tromey.com>
6529
6530         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6531         declare.
6532         * tui/tui-winsource.c
6533         (tui_source_window_base::do_scroll_horizontal): Rename from
6534         tui_horizontal_source_scroll.
6535         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6536         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6537         from tui_vertical_data_scroll.
6538         * tui/tui-win.h (tui_scroll): Don't declare.
6539         * tui/tui-win.c (tui_win_info::forward_scroll)
6540         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6541         (tui_win_info::right_scroll): Rename and update.
6542         (tui_scroll_forward_command, tui_scroll_backward_command)
6543         (tui_scroll_left_command, tui_scroll_right_command): Update.
6544         (tui_scroll): Remove.
6545         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6546         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6547         from tui_vertical_source_scroll.
6548         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6549         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6550         from tui_vertical_disassem_scroll.
6551         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6552         do_scroll_horizontal>: New methods.
6553         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6554         Likewise.
6555         (struct tui_source_window_base): Add do_scroll_horizontal.
6556         (struct tui_source_window, struct tui_disasm_window): Add
6557         do_scroll_vertical.
6558         (struct tui_data_window, struct tui_cmd_window): Add
6559         do_scroll_horizontal and do_scroll_vertical.
6560         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6561
6562 2019-06-25  Tom Tromey  <tom@tromey.com>
6563
6564         * tui/tui-data.h (struct tui_source_window_base): New struct.
6565         (struct tui_source_window): Derive from tui_source_window_base.
6566         (struct tui_disasm_window): New struct.
6567         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6568         from tui_source_window::clear_detail.
6569         (tui_source_window_base): Rename from tui_source_window.
6570         (~tui_source_window_base): Rename from ~tui_source_window.
6571         (tui_alloc_win_info): Create a tui_disasm_window.
6572
6573 2019-06-25  Tom Tromey  <tom@tromey.com>
6574
6575         * tui/tui-data.h (struct tui_source_window)
6576         (struct tui_data_window): Declare destructors.
6577         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6578         destructors.
6579         (tui_win_info): Simplify.
6580
6581 2019-06-25  Tom Tromey  <tom@tromey.com>
6582
6583         * tui/tui-winsource.c (tui_display_main)
6584         (tui_update_source_windows_with_addr)
6585         (tui_update_all_breakpoint_info): Update.
6586         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6587         (new_height_ok, parse_scrolling_args): Update.
6588         * tui/tui-stack.c (tui_show_frame_info): Update.
6589         * tui/tui-data.h (struct tui_list): Remove.
6590         (tui_source_windows): Return a reference to a std::vector.
6591         * tui/tui-data.c (source_windows): Now a std::vector.
6592         (tui_source_windows): Change return type.
6593         (tui_clear_source_windows): Rewrite.
6594         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6595         (tui_free_all_source_wins_content): Rewrite.
6596
6597 2019-06-25  Tom Tromey  <tom@tromey.com>
6598
6599         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6600         (struct tui_data_window, struct tui_cmd_window): Declare
6601         clear_detail method.
6602         * tui/tui-data.c (tui_source_window::clear_detail)
6603         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6604         methods.
6605         (tui_clear_win_detail): Simplify.
6606
6607 2019-06-25  Tom Tromey  <tom@tromey.com>
6608
6609         * tui/tui-layout.c (make_source_window, make_disasm_window)
6610         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6611         Return the new window.
6612         (show_source_disasm_command, show_data)
6613         (show_source_or_disasm_and_command): Update.
6614
6615 2019-06-25  Tom Tromey  <tom@tromey.com>
6616
6617         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6618         parameter.  Return the new window.
6619         (show_source_disasm_command): Update and remove NULL check.
6620         (show_source_or_disasm_and_command): Update.
6621
6622 2019-06-25  Tom Tromey  <tom@tromey.com>
6623
6624         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6625
6626 2019-06-25  Tom Tromey  <tom@tromey.com>
6627
6628         * tui/tui-data.h (struct tui_win_info): Make constructor
6629         protected.  Make destructor virtual.  Add initializers.
6630         (tui_source_window, tui_data_window, tui_cmd_window): New
6631         classes.
6632         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6633         constructor.  Add "type" parameter.
6634         (tui_source_window, tui_data_window, tui_cmd_window): New
6635         constructors.
6636         (tui_alloc_win_info): Instantiate the appropriate subclass.
6637
6638 2019-06-25  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-win.c (tui_resize_all): Use delete.
6641         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6642         destructor.
6643         (tui_free_window): Don't declare.
6644         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6645         Update.
6646
6647 2019-06-25  Tom Tromey  <tom@tromey.com>
6648
6649         * tui/tui-data.h (struct tui_win_info): Add constructor.
6650         * tui/tui-data.c (tui_alloc_win_info): Use new.
6651         (tui_free_window): Use delete.
6652
6653 2019-06-22  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6656         declare.
6657         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6658
6659 2019-06-22  Tom Tromey  <tom@tromey.com>
6660
6661         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6662         declare.
6663         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6664
6665 2019-06-22  Tom de Vries  <tdevries@suse.de>
6666
6667         * dwarf2read.c (create_addrmap_from_aranges)
6668         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6669         instead of '%zu'.
6670
6671 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6672
6673         * dwarf2read.h (dwarf2_section_info_def): Remove.
6674         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6675         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6676         std::vector<dwarf2_section_info>.
6677         (struct dwo_file) <~dwo_file>: Remove.
6678         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6679         types field.
6680         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6681         (dwarf2_read_debug_names): Likewise.
6682         (create_debug_types_hash_table): Change parameter type to
6683         array_view, adjust code accordingly.
6684         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6685         (partial_die_info::fixup): Likewise.
6686         (determine_prefix): Likewise.
6687         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6688
6689 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6690
6691         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6692         gdb_bfd_ref_ptr.
6693         <~dwo_file>: Remove call to gdb_bfd_unref.
6694         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6695         gdb_bfd_ref_ptr::get.
6696
6697 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6698
6699         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6700         type to htab_up.
6701         * dwarf2read.c (struct dwo_file): Initialize fields.
6702         <~dwo_file>: New.
6703         (free_dwo_file): Remove, move content to ~dwo_file.
6704         (struct dwo_file_deleter): Remove.
6705         (dwo_file_up>: Remove custom deleter.
6706         (free_dwo_files): Remove.
6707         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6708         dwo_files.
6709         (process_skeletonless_type_units): Call unique_ptr::get.
6710         (allocate_dwo_file_hash_table): Add deleter to created hash
6711         table.  Change return type to htab_up.
6712         (lookup_dwo_file_slot): Don't memset dwo_file, call
6713         unique_ptr::get.
6714         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6715         (create_dwo_unit_in_dwp_v2): Likewise.
6716         (open_and_init_dwo_file): Likewise.
6717         (free_dwo_file_from_slot): Remove.
6718
6719 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6720
6721         * dwarf2read.h (struct dwarf2_section_info) <readin,
6722         is_virtual>: Change type to bool.
6723         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6724         true instead of 1.
6725
6726 2019-06-19  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-data.h (tui_init_content_element): Don't declare.
6729
6730 2019-06-19  Tom Tromey  <tom@tromey.com>
6731
6732         * tui/tui-data.h (tui_init_win_info): Don't declare.
6733
6734 2019-06-19  Tom de Vries  <tdevries@suse.de>
6735
6736         * dwarf2read.h (abstract_to_concrete): Change type to
6737         std::unordered_map<sect_offset, std::vector<sect_offset>,
6738         gdb::hash_enum<sect_offset>>.
6739
6740 2019-06-19  Tom Tromey  <tromey@adacore.com>
6741
6742         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6743         EVAL_AVOID_SIDE_EFFECTS specially.
6744
6745 2019-06-19  Tom Tromey  <tromey@adacore.com>
6746
6747         * source-cache.c (highlighter): New global.
6748         (source_cache::get_source_lines): Create a highlighter on demand.
6749
6750 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6751
6752         * defs.h (deprecated_interactive_hook): Delete declaration.
6753         * interps.c (clear_interpreter_hooks): Remove use of
6754         deprecated_interactive_hook.
6755         * top.c (deprecated_interactive_hook): Delete definition.
6756         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6757
6758 2019-06-18  Tom de Vries  <tdevries@suse.de>
6759
6760         PR gdb/24515
6761         * dwarf2read.h (abstract_to_concrete): Change type from
6762         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6763         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6764         * dwarf2read.c (read_variable): Update.
6765         (dwarf2_fetch_die_loc_sect_off): Update.
6766
6767 2019-06-17  Tom de Vries  <tdevries@suse.de>
6768
6769         PR gdb/24617
6770         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6771         accessing parent[parent_len - 1].
6772
6773 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6774
6775         PR gdb/24364
6776         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6777         call dtrace_process_dof with NULL dof.
6778
6779 2019-06-16  Tom de Vries  <tdevries@suse.de>
6780
6781         PR gdb/24445
6782         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6783
6784 2019-06-16  Tom Tromey  <tom@tromey.com>
6785
6786         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6787         (make_all_visible): Use address of member.
6788
6789 2019-06-16  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6792         (tui_free_window, free_content, free_content_elements): Remove
6793         unnecessary cast.
6794         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6795         cast.
6796         * tui/tui-regs.c (tui_show_register_group)
6797         (tui_display_registers_from, tui_display_reg_element_at_line):
6798         Remove unnecessary cast.
6799
6800 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * linux-nat.c (normal_mask): Delete.
6803         (_initialize_linux_nat): Don't initialise normal_mask.
6804
6805 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6806
6807         PR gdb/24445
6808         * dwarf-index-write.h (write_psymtabs_to_index): Add
6809         dwz_basename parameter.
6810         * dwarf-index-write.c (write_gdbindex): Move file writing to
6811         write_gdbindex_1.  Change return type void.
6812         (assert_file_size): Move up, remove filename parameter.
6813         (write_gdbindex_1): New function.
6814         (write_debug_names): Change return type to void, call
6815         assert_file_size.
6816         (struct index_wip_file): New struct.
6817         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6818         file logic to index_wip_file.  Write index for dwz file if
6819         needed.
6820         (save_gdb_index_command): Pass basename of dwz file, if present.
6821         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6822         build-id of dwz file, if present.
6823         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6824         (dwarf2_get_dwz_file): Likewise.
6825         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6826         (dwarf2_get_dwz_file): Likewise.
6827
6828 2019-06-16  Tom Tromey  <tom@tromey.com>
6829
6830         * coffread.c (process_coff_symbol): Use xstrdup.
6831         * value.c (create_internalvar): Use xstrdup.
6832
6833 2019-06-16  Tom Tromey  <tom@tromey.com>
6834
6835         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6836         * breakpoint.c (stopin_command, stopat_command)
6837         (until_break_command, decode_location_default): Remove unnecessary
6838         cast.
6839         * utils.c (subset_compare): Remove unnecessary cast.
6840         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6841         cast.
6842         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6843         cast.
6844         * infcmd.c (path_command): Remove unnecessary cast.
6845         * coffread.c (decode_type): Remove unnecessary cast.
6846         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6847         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6848         * tui/tui-stack.c (tui_show_locator_content)
6849         (tui_show_frame_info): Remove unnecessary cast.
6850         * tui/tui-win.c (tui_scroll_forward_command)
6851         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6852         (parse_scrolling_args): Remove unnecessary cast.
6853         * tui/tui-data.c (init_win_info, tui_del_window)
6854         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6855         (free_content_elements): Remove unnecessary cast.
6856         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6857         unnecessary cast.
6858         * tui/tui-source.c (tui_set_source_content)
6859         (tui_vertical_source_scroll): Remove unnecessary cast.
6860         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6861         cast.
6862         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6863         * tui/tui-regs.c (tui_display_registers_from)
6864         (tui_display_register): Remove unnecessary cast.
6865         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6866         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6867         (make_visible): Remove unnecessary cast.
6868         * tui/tui-winsource.c (tui_erase_source_content)
6869         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6870         unnecessary cast.
6871         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6872         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6873         * stabsread.c (read_type, read_array_type, read_range_type):
6874         Remove unnecessary cast.
6875         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6876         (parse_symbol, parse_type, upgrade_type, parse_external)
6877         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6878         unnecessary cast.
6879         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6880
6881 2019-06-16  Tom Tromey  <tom@tromey.com>
6882
6883         * tui/tui-data.c (tui_alloc_generic_win_info)
6884         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6885         checks.
6886
6887 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6888             Andrew Burgess  <andrew.burgess@embecosm.com>
6889
6890         * f-typeprint.c (f_print_type): Don't return early for not
6891         associated or not allocated types.
6892         (f_type_print_varspec_suffix): Add print_rank parameter and print
6893         ranks of array types in case they dangling.
6894         (f_type_print_base): Add print_rank parameter.
6895
6896 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6897
6898         * NEWS: Mention new MI commands.
6899         * break-catch-throw.c (enum exception_event_kind): Move to
6900         breakpoint.h.
6901         (print_mention_exception_catchpoint): Output text as a single
6902         message.
6903         (catch_exception_command_1): Rename to...
6904         (catch_exception_event): ...this, make non-static, update header
6905         command, and change some parameter types.
6906         (catch_catch_command): Update for changes to
6907         catch_exception_command_1.
6908         (catch_throw_command): Likewise.
6909         (catch_rethrow_command): Likewise.
6910         * breakpoint.c (enum exception_event_kind): Delete.
6911         * breakpoint.h (enum exception_event_kind): Moved here from
6912         break-catch-throw.c.
6913         (catch_exception_event): Declare.
6914         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6915         (mi_cmd_catch_throw): New function.
6916         (mi_cmd_catch_rethrow): New function.
6917         (mi_cmd_catch_catch): New function.
6918         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6919         'catch-catch' entries.
6920         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6921         (mi_cmd_catch_rethrow): Declare.
6922         (mi_cmd_catch_catch): Declare.
6923
6924 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6925
6926         * annotate.c (annotate_source_line): Change return type to void,
6927         update implementation to match.
6928         * annotate.h (annotate_source_line): Change return type to void,
6929         update header comment.
6930         * stack.c (print_frame_info): Don't change what frame information
6931         is printed based on whether annotations are on or not.
6932
6933 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6934
6935         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6936         (annotate_source): Make static.
6937         (annotate_source_line): Moved from source.c and renamed from
6938         identify_source_line.  Update the return type.
6939         * annotate.h (annotate_source): Delete declaration.
6940         (annotate_source_line): Declaration moved from source.h, and
6941         renamed from identify_source_line.  Return type updated.
6942         * source.c (identify_source_line): Moved to annotate.c and renamed
6943         to annotate_source_line.
6944         (info_line_command): Remove check of annotation_level.
6945         * source.h (identify_source_line): Move declaration to annotate.h
6946         and rename to annotate_source_line.
6947         * stack.c: Add 'annotate.h' include.
6948         (print_frame_info): Remove check of annotation_level before
6949         calling annotate_source_line.
6950
6951 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6952
6953         * source-cache.c (source_cache::get_plain_source_lines): Use
6954         open_source_file_with_line_charpos instead of just
6955         open_source_file, remove call to find_source_lines.
6956         (source_cache::get_source_lines): Likewise.
6957         * source.c (find_source_lines): Make static.
6958         (get_filename_and_charpos): Renamed into...
6959         (open_source_file_with_line_charpos): ..this along with changes to
6960         return a scoped_fd, and some other minor clean ups.
6961         (identify_source_line): Use open_source_file_with_line_charpos.
6962         (search_command_helper): Use open_source_file_with_line_charpos
6963         instead of just open_source_file, remove call to
6964         find_source_lines.
6965         * source.h (open_source_file_with_line_charpos): Declare new
6966         function.
6967         (find_source_lines): Delete declaration.
6968
6969 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * source.c (get_filename_and_charpos): Remove fullname
6972         parameter.
6973         (identify_source_line): Update call to get_filename_and_charpos.
6974
6975 2019-06-14  Tom Tromey  <tromey@adacore.com>
6976
6977         PR gdb/24502:
6978         * ui-style.h (skip_ansi_escape): Update comment.
6979         * ui-file.h (class no_terminal_escape_file): New class.
6980         * ui-file.c (no_terminal_escape_file::write)
6981         (no_terminal_escape_file::puts): New methods.
6982         * cli/cli-logging.c (handle_redirections): Use
6983         no_terminal_escape_file.
6984
6985 2019-06-14  Tom Tromey  <tromey@adacore.com>
6986
6987         * NEWS: Move convenience variable news above Python news.
6988
6989 2019-06-14  Tom Tromey  <tom@tromey.com>
6990
6991         * gnulib: Move directory to top-level.
6992         * configure.ac: Don't configure gnulib.
6993         * configure: Rebuild.
6994         * common/common-defs.h: Use new path to gnulib.
6995         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6996         (GNULIB_H): Remove.
6997         (INCGNU): Look in new gnulib location.
6998         (HFILES_NO_SRCDIR): Remove gnulib files.
6999         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7000         (generated_files): Remove GNULIB_H.
7001         ($(LIBGNU), all-lib): Remove targets.
7002         (distclean): Don't mention GNULIB_BUILDDIR.
7003         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7004
7005 2019-06-14  Tom Tromey  <tromey@adacore.com>
7006
7007         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7008         Warn if symbol file does not provide any symbols.
7009
7010 2019-06-14  Tom Tromey  <tromey@adacore.com>
7011
7012         * source.c (find_and_open_source): Respect basenames_may_differ.
7013
7014 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * annotate.c (annotate_breakpoints_invalid): Make use of
7017         scoped_restore_terminal_state.
7018         (annotate_frames_invalid): Likewise.
7019
7020 2019-06-14  Tom Tromey  <tromey@adacore.com>
7021
7022         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7023         allow assignment to an internalvar.
7024
7025 2019-06-14  Tom Tromey  <tromey@adacore.com>
7026
7027         * ada-lex.l: Allow "_" in attribute names.
7028
7029 2019-06-14  Tom Tromey  <tromey@adacore.com>
7030
7031         PR gdb/24653:
7032         * regcache.c (registers_changed): Don't call alloca.
7033         * top.c (execute_command): Don't call alloca.
7034
7035 2019-06-13  Pedro Alves  <palves@redhat.com>
7036
7037         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7038         'expression'.  When parsing an expression, error out if there's
7039         junk after "unlimited".
7040         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7041         (do_set_command): Adjust calls to is_unlimited_literal.
7042
7043 2019-06-13  Pedro Alves  <palves@redhat.com>
7044
7045         * compile/compile.c (make_compile_options_def_group): Add braces
7046         around array_view initializer.
7047         * thread.c (make_thread_apply_all_options_def_group)
7048         (make_thread_apply_all_options_def_group): Likewise.
7049
7050 2019-06-13  Pedro Alves  <palves@redhat.com>
7051
7052         * NEWS (New commands): Mention "maint test-options
7053         require-delimiter", "maint test-options unknown-is-error", "maint
7054         test-options unknown-is-operand" and "maint show
7055         test-options-completion-result".
7056         (New command options, command completion): New section.
7057         (Completion improvements): New section.
7058         Mention that you can abbreviate "unlimited".
7059
7060 2019-06-13  Pedro Alves  <palves@redhat.com>
7061
7062         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7063         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7064         * unittests/cli-utils-selftests.c (test_parse_flags)
7065         (test_parse_flags_qcs): Delete.
7066         (test_cli_utils): Don't call deleted functions.
7067
7068 2019-06-13  Pedro Alves  <palves@redhat.com>
7069
7070         * thread.c: Include "cli/cli-option.h".
7071         (tp_array_compar_ascending): Global.
7072         (tp_array_compar): Delete function.
7073         (tp_array_compar_ascending, tp_array_compar_descending): New
7074         functions.
7075         (ascending_option_def, qcs_flag_option_def)
7076         (thr_qcs_flags_option_defs)
7077         (make_thread_apply_all_options_def_group)
7078         (make_thread_apply_options_def_group): New.
7079         (thread_apply_all_command): Use gdb::option::process_options.
7080         (thread_apply_command_completer)
7081         (thread_apply_all_command_completer): New.
7082         (thread_apply_command): Use gdb::option::process_options.
7083         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7084         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7085         to generate help text of "thread apply".  Adjust "taas"'s help.
7086         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7087         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7088
7089 2019-06-13  Pedro Alves  <palves@redhat.com>
7090
7091         * thread.c (thread_apply_command): Check for invalid TID with
7092         isdigit instead of !isalpha.
7093
7094 2019-06-13  Pedro Alves  <palves@redhat.com>
7095
7096         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7097         (validate_flags_qcs): New.
7098         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7099         (validate_flags_qcs): Declare.
7100         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7101         (make_frame_apply_options_def_group): New.
7102         (frame_apply_command_count): Process options with
7103         gdb::option::process_options.
7104         (frame_apply_completer): New.
7105         (frame_apply_level_completer, frame_apply_all_completer)
7106         (frame_apply_completer): New.
7107         (_initialize_stack): Update help of "frame apply", "frame apply
7108         level", "frame apply all" and "faas" to mention supported options
7109         and install command completers.
7110         * stack.h (frame_apply_all_completer): Declare.
7111         * thread.c: Include "stack.h".
7112         (tfaas_command): Add "--".
7113         (_initialize_thread): Update help "tfaas" to mention supported
7114         options and install command completer.
7115
7116 2019-06-13  Pedro Alves  <palves@redhat.com>
7117
7118         * completer.c (complete_nested_command_line): New.
7119         (gdb_completion_word_break_characters_throw): Add assertion.
7120         * completer.h (complete_nested_command_line): Declare.
7121
7122 2019-06-13  Pedro Alves  <palves@redhat.com>
7123
7124         * stack.c (parse_backtrace_qualifiers): New.
7125         (backtrace_command): Use it.
7126         (backtrace_command_completer): Complete on qualifiers.
7127
7128 2019-06-13  Pedro Alves  <palves@redhat.com>
7129
7130         * frame.c: Include "cli/cli-option.h.
7131         (user_set_backtrace_options): New.
7132         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7133         Delete.
7134         (get_prev_frame): Adjust.
7135         (boolean_option_def, uinteger_option_def)
7136         (set_backtrace_option_defs): New.
7137         (_initialize_frame): Adjust and use
7138         gdb::option::add_setshow_cmds_for_options to install "set
7139         backtrace past-main" and "set backtrace past-entry".
7140         * frame.h: Include "cli/cli-option.h".
7141         (struct frame_print_options): Forward declare.
7142         (print_frame_arguments_all, print_frame_arguments_scalars)
7143         (print_frame_arguments_none): Declare.
7144         (print_entry_values): Delete declaration.
7145         (struct frame_print_options, user_frame_print_options): New.
7146         (struct set_backtrace_options): New.
7147         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7148         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7149         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7150         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7151         (list_args_or_locals): Add frame_print_options parameter.
7152         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7153         * python/py-framefilter.c (enumerate_args): Pass down
7154         USER_FRAME_PRINT_OPTIONS.
7155         * stack.c: Include "cli/cli-option.h".
7156         (print_frame_arguments_all, print_frame_arguments_scalars)
7157         (print_frame_arguments_none): Declare.
7158         (print_raw_frame_arguments, print_entry_values): Delete.
7159         (user_frame_print_options): New.
7160         (boolean_option_def, enum_option_def, frame_print_option_defs):
7161         New.
7162         (struct backtrace_cmd_options): New.
7163         (bt_flag_option_def): New.
7164         (backtrace_command_option_defs): New.
7165         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7166         (print_frame_arg, read_frame_arg, print_frame_args)
7167         (print_frame_info, print_frame): Add frame_print_options parameter
7168         and use it.
7169         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7170         (backtrace_command_1): Add frame_print_options and
7171         backtrace_cmd_options parameters and use them.
7172         (make_backtrace_options_def_group): New.
7173         (backtrace_command): Process command options with
7174         gdb::option::process_options.
7175         (backtrace_command_completer): New.
7176         (_initialize_stack): Extend "backtrace"'s help to mention
7177         supported options.  Install completer for "backtrace".
7178         Install some settings commands with add_setshow_cmds_for_options.
7179
7180 2019-06-13  Pedro Alves  <palves@redhat.com>
7181
7182         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7183         and that "set/show print raw frame-arguments" are now deprecated.
7184
7185         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7186         command.
7187         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7188         * stack.c (_initialize_stack): Install "set/show print
7189         raw-frame-arguments", and deprecate "set/show print raw
7190         frame-arguments".
7191         * valprint.c (_initialize_valprint): Deprecate "set/show print
7192         raw".
7193
7194 2019-06-13  Pedro Alves  <palves@redhat.com>
7195
7196         * compile/compile.c (struct compile_options): New.
7197         (compile_flag_option_def, compile_command_option_defs)
7198         (make_compile_options_def_group): New.
7199         (compile_file_command): Handle options with
7200         gdb::option::process_options.
7201         (compile_file_command_completer): New function.
7202         (compile_code_command): Handle options with
7203         gdb::option::process_options.
7204         (compile_code_command_completer): New function.
7205         (_initialize_compiler): Install completers for "compile code" and
7206         "compile file".  Mention available options in "compile code" and
7207         "compile code"'s help.
7208         * completer.c (advance_to_completion_word): New, factored out from
7209         ...
7210         (advance_to_expression_complete_word_point): ... this.
7211         (advance_to_filename_complete_word_point): New.
7212         * completer.h (advance_to_filename_complete_word_point): New
7213         declaration.
7214
7215 2019-06-13  Pedro Alves  <palves@redhat.com>
7216
7217         * compile/compile.c: Include "cli/cli-option.h".
7218         (compile_print_value): Scope data pointer is now a
7219         value_print_options pointer; adjust.
7220         (compile_print_command): Process options.  Scope data pointer is
7221         now a value_print_options pointer; adjust.
7222         (_initialize_compile): Update "compile print"'s help to include
7223         supported options.  Install a completer for "compile print".
7224         * cp-valprint.c (show_vtblprint, show_objectprint)
7225         (show_static_field_print): Delete.
7226         (_initialize_cp_valprint): Don't install "set print
7227         static-members", "set print vtbl", "set print object" here.
7228         * printcmd.c: Include "cli/cli-option.h" and
7229         "common/gdb_optional.h".
7230         (print_command_parse_format): Rework to fill in a
7231         value_print_options instead of a format_data.
7232         (print_value): Change parameter type from format_data pointer to
7233         value_print_options reference.  Adjust.
7234         (print_command_1): Process options.  Adjust to pass down a
7235         value_print_options.
7236         (print_command_completer): New.
7237         (_initialize_printcmd): Install print_command_completer as
7238         handle_brkchars completer for the "print" command.  Update
7239         "print"'s help to include supported options.
7240         * valprint.c: Include "cli/cli-option.h".
7241         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7242         here from cp-valprint.c.
7243         (boolean_option_def, uinteger_option_def)
7244         (value_print_option_defs, make_value_print_options_def_group):
7245         New.  Use gdb::option::add_setshow_cmds_for_options to install
7246         "set print elements", "set print null-stop", "set print repeats",
7247         "set print pretty", "set print union", "set print array", "set
7248         print address", "set print symbol", "set print array-indexes".
7249         * valprint.h: Include <string> and "cli/cli-option.h".
7250         (make_value_print_options_def_group): Declare.
7251         (print_value): Change parameter type from format_data pointer to
7252         value_print_options reference.
7253         (print_command_completer): Declare.
7254
7255 2019-06-13  Pedro Alves  <palves@redhat.com>
7256
7257         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7258         (COMMON_SFILES): Add maint-test-settings.c.
7259         * cli/cli-decode.c (boolean_enums): New global, factored out from
7260         ...
7261         (add_setshow_boolean_cmd): ... here.
7262         * cli/cli-decode.h (boolean_enums): Declare.
7263         * cli/cli-option.c: New file.
7264         * cli/cli-option.h: New file.
7265         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7266         factored out from ...
7267         (parse_cli_boolean_value(const char *)): ... this.
7268         (is_unlimited_literal): Change parameter type to pointer to
7269         pointer.  Adjust and advance ARG pointer.
7270         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7271         (parse_cli_var_enum): New, factored out from ...
7272         (do_set_command): ... this.  Adjust.
7273         * cli/cli-setshow.h (parse_cli_boolean_value)
7274         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7275         (parse_cli_var_enum): Declare.
7276         * cli/cli-utils.c: Include "cli/cli-option.h".
7277         (get_ulongest): New.
7278         * cli/cli-utils.h (get_ulongest): Declare.
7279         (check_for_argument): New overloads.
7280         * maint-test-options.c: New file.
7281
7282 2019-06-13  Pedro Alves  <palves@redhat.com>
7283
7284         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7285         parse a range if "-" is at the end of the string.
7286
7287 2019-06-13  Pedro Alves  <palves@redhat.com>
7288
7289         * cli/cli-setshow.c (parse_auto_binary_operation)
7290         (parse_cli_boolean_value): Don't allow "o".
7291
7292 2019-06-13  Pedro Alves  <palves@redhat.com>
7293
7294         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7295         * NEWS: Mention maint test-settings KIND.
7296         * maint-test-settings.c: New file.
7297
7298 2019-06-13  Pedro Alves  <palves@redhat.com>
7299
7300         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7301         completer.
7302         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7303         "set" completers.
7304
7305 2019-06-13  Pedro Alves  <palves@redhat.com>
7306
7307         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7308         after item.
7309
7310 2019-06-13  Pedro Alves  <palves@redhat.com>
7311
7312         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7313
7314 2019-06-13  Pedro Alves <palves@redhat.com>
7315
7316         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7317         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7318         call.
7319         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7320         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7321         calls.
7322         (check_for_argument): Skip spaces after argument.
7323
7324 2019-06-13  Pedro Alves  <palves@redhat.com>
7325
7326         * thread.c (thread_apply_command): Adjust TID parsing.
7327         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7328         detected before end of string.
7329         (tid_is_in_list): Error out if LIST is invalid.
7330
7331 2019-06-13  Pedro Alves  <palves@redhat.com>
7332
7333         * completer.c (complete_line_internal_1): Rewind completion word
7334         point.
7335         (completion_tracker::advance_custom_word_point_by): Change
7336         parameter type to int.
7337         * completer.h (completion_tracker::advance_custom_word_point_by):
7338         Likewise.
7339
7340 2019-06-13  Pedro Alves  <palves@redhat.com>
7341
7342         * completer.c (advance_to_completion_word): Handle delimiters.
7343
7344 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7345
7346         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7347
7348 2019-06-11  Tom Tromey  <tom@tromey.com>
7349
7350         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7351         (xmalloc_failed): Move to alloc.c.
7352         * alloc.c: New file.
7353         * Makefile.in (COMMON_SFILES): Add alloc.c.
7354
7355 2019-06-11  Tom Tromey  <tom@tromey.com>
7356
7357         * nat/linux-waitpid.c: Don't include server.h.
7358         (linux_debug): Remove.
7359         (my_waitpid): Update.
7360
7361 2019-06-11  Tom Tromey  <tromey@adacore.com>
7362
7363         * infcall.c (_initialize_infcall): Remove trailing newline from
7364         help.
7365         * user-regs.c (_initialize_user_regs): Remove trailing newline
7366         from help.
7367         * typeprint.c (_initialize_typeprint): Remove trailing newline
7368         from help.
7369         * reverse.c (_initialize_reverse): Remove trailing newlines from
7370         help.
7371         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7372         from help.
7373         * language.c (add_set_language_command): Remove trailing newline
7374         from help.
7375         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7376         help.
7377         * disasm.c (_initialize_disasm): Remove trailing newline from
7378         help.
7379         * top.c (init_main): Remove trailing newline from help.
7380         * interps.c (_initialize_interpreter): Remove trailing newline
7381         from help.
7382         * btrace.c (_initialize_btrace): Remove trailing newlines from
7383         help.
7384         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7385         from help.
7386         * python/python.c (_initialize_python): Remove trailing newline
7387         from help.
7388         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7389         help.
7390         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7391         from help.  Reformat some text.
7392         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7393         from help.
7394         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7395         newline from help.
7396
7397 2019-06-11  Tom Tromey  <tromey@adacore.com>
7398
7399         * darwin-nat.c (darwin_decode_exception_message)
7400         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7401
7402 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * valops.c (value_slice): Check for not allocated or not
7405         associated values.
7406
7407 2019-06-10  Tom de Vries  <tdevries@suse.de>
7408
7409         PR gdb/24618
7410         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7411         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7412         invalid.
7413
7414 2019-06-10  Tom de Vries  <tdevries@suse.de>
7415
7416         PR gdb/24611
7417         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7418         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7419
7420 2019-06-10  Tom de Vries  <tdevries@suse.de>
7421
7422         PR symtab/24545
7423         * symtab.c (struct demangled_name_entry): Add language field.
7424         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7425         static minimal symbol".  Set and use language field.
7426
7427 2019-06-10  Tom Tromey  <tromey@adacore.com>
7428
7429         * ada-lang.c (_initialize_ada_language): Update help text.
7430
7431 2019-06-10  Tom Tromey  <tromey@adacore.com>
7432
7433         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7434         with a newline.
7435         * guile/guile.c (handle_boot_error): Don't end warning with a
7436         newline.
7437         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7438         warning with a newline.
7439         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7440         newline.
7441         (s12z_frame_cache): Likewise.
7442         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7443         a newline.
7444         * solib-svr4.c (disable_probes_interface): Don't end warning with
7445         a newline.
7446         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7447         newline.
7448         * python/python.c (do_finish_initialization): Don't end warning
7449         with a newline.
7450
7451 2019-06-10  Tom Tromey  <tom@tromey.com>
7452
7453         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7454         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7455         gdbpy_enter.
7456
7457 2019-06-10  Tom Tromey  <tromey@adacore.com>
7458
7459         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7460         data.
7461         (elf_new_init): Don't call stabsread_new_init.
7462         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7463         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7464         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7465
7466 2019-06-10  Tom de Vries  <tdevries@suse.de>
7467
7468         PR symtab/16264
7469         PR symtab/24517
7470         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7471
7472 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7473
7474         * source.c (find_and_open_source): Also rewrite relative file
7475         names.
7476
7477 2019-04-26  Amos Bird  <amosbird@gmail.com>
7478
7479         * annotate.c (annotate_thread_exited): Add "thread-exited"
7480         annotation.
7481
7482 2019-06-06  Tom Tromey  <tromey@adacore.com>
7483
7484         * maint.h (class scoped_command_stats): Use
7485         DISABLE_COPY_AND_ASSIGN.
7486         <print_time>: New method.
7487         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7488         print_time.
7489         (scoped_command_stats::print_time): New method.
7490
7491 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7492
7493         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7494         instructions of lengths 6 or 8 bytes.
7495
7496 2019-06-04  Pedro Alves  <palves@redhat.com>
7497
7498         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7499
7500         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7501         * breakpoint.c (condition_completer): Likewise.
7502         * cli/cli-dump.c (scan_expression): Likewise.
7503         * common/filestuff.c (mkdir_recursive): Likewise.
7504         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7505         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7506         (gdb_abspath): Likewise.
7507         * compile/compile-cplus-types.c
7508         (compile_cplus_instance::decl_name): Likewise.
7509         * completer.c (complete_explicit_location):
7510         (signal_completer, reg_or_group_completer_1): Likewise.
7511         * cp-support.c (cp_remove_params_if_any): Likewise.
7512         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7513         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7514         * infcmd.c (strip_bg_char): Likewise.
7515         * linespec.c (copy_token_string): Likewise.
7516         * mi/mi-main.c (output_cores): Likewise.
7517         * psymtab.c (psymtab_search_name):
7518         * symfile.c (test_set_ext_lang_command): Likewise.
7519         * target.c (target_fileio_read_stralloc): Likewise.
7520         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7521         * value.c (complete_internalvar): Likewise.
7522
7523 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7524
7525         Add objfile property to gdb.Type.
7526         * NEWS: Mention Python API addition.
7527         * python/py-type.c (typy_get_objfile): New method.
7528
7529 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7530
7531         * NEWS: Mention the new set|show style [title|highlight].
7532         Mention changes to "show style", "help" and "apropos".
7533
7534 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7535
7536         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7537         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7538         instead of print_help_for_command.
7539         (print_doc_of_command): New function.
7540         (help_list): Add 'apropos -v word' suggestion.
7541         (print_help_for_command): Style the command name using title style.
7542         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7543         (_initialize_cli_cmds): Describe -v in apropos_command help.
7544
7545 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7546
7547         * cli/cli-style.h (cli_style_option): Add name in constructor,
7548         add m_name class member, add constructor with intensity,
7549         add name class function.
7550         (cli_style_option::add_setshow_commands): Remove name argument.
7551         (highlight_style, title_style): New styles.
7552         * cli/cli-style.c (do_show): New function that shows a style
7553         characteristic styling the style name with itself.
7554         (set_style_name): New function.
7555         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7556         Update all callers according to the changes in cli/cli-style.h.
7557         * utils.h (fputs_highlighted): New function.
7558         * utils.c (fputs_highlighted): Likewise.
7559
7560 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7561
7562         * NEWS: Mention new pipe command and new convenience variables.
7563
7564 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7565
7566         * cli/cli-cmds.c (pipe_command): New function.
7567         (_initialize_cli_cmds): Call add_com for pipe_command.
7568         Define | as an alias for pipe.
7569         (exit_status_set_internal_vars): New function.
7570         (shell_escape): Call exit_status_set_internal_vars.
7571         cli/cli-decode.c (find_command_name_length): Recognize | as
7572         a single character command.
7573
7574 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7575
7576         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7577         top.c (execute_command_to_ui_file): New function, mostly a copy
7578         of execute_command_to_string.
7579         (execute_command_to_string): Implement by calling
7580         execute_command_to_ui_file.
7581
7582 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7583
7584         * top.h (saved_command_line): Remove declaration.
7585         * top.c (previous_saved_command_line, previous_repeat_arguments):
7586         New variables.
7587         (saved_command_line): Make static, define together with other
7588         'repeat variables'.
7589         (dont_repeat): Clear repeat_arguments.
7590         (repeat_previous, get_saved_command_line, save_command_line):
7591         New functions.
7592         (gdb_init): Initialize saved_command_line
7593         and previous_saved_command_line.
7594         * main.c (captured_main_1): Remove saved_command_line initialization.
7595         * event-top.c (handle_line_of_input): Update to use
7596         the new 'repeat' related functions instead of direct access to
7597         saved_command_line.
7598         * command.h (repeat_previous, get_saved_command_line,
7599         save_command_line): New declarations.
7600         (dont_repeat): Add comment.
7601
7602 2019-05-30  Tom Tromey  <tromey@adacore.com>
7603
7604         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7605         Fix comment.
7606         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7607
7608 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7609
7610         PR cli/24587
7611         * completer.c (complete): Initialize variable word.
7612
7613 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7614
7615         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7616         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7617         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7618         'body' is NULL to the outter 'if', protecting the '!is_define'
7619         situation as well.
7620
7621 2019-05-29  Tom Tromey  <tromey@adacore.com>
7622
7623         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7624         (dwarf_unknown): New function.
7625         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7626         (dwarf_type_encoding_name): Use dwarf_unknown.
7627
7628 2019-05-29  Tom Tromey  <tromey@adacore.com>
7629
7630         PR c++/20020:
7631         * cp-valprint.c (cp_print_value_fields): Call
7632         cp_print_static_field inside "try".
7633
7634 2019-05-29  Tom Tromey  <tromey@adacore.com>
7635
7636         * inflow.c (struct terminal_info): Add default operator=.
7637         * configure: Rebuild.
7638         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7639         -Wdeprecated-copy-dtor, -Wredundant-move.
7640
7641 2019-05-29  Tom Tromey  <tromey@adacore.com>
7642
7643         * NEWS: Add entry.
7644         * infcmd.c (print_return_value_1): Handle finish_print
7645         option.
7646         (show_print_finish): New function.
7647         (_initialize_infcmd): Add "set/show print finish" commands.
7648         * valprint.c (user_print_options): Initialize new member.
7649         * valprint.h (struct value_print_options) <finish_print>: New
7650         member.
7651
7652 2019-05-28  Tom Tromey  <tromey@adacore.com>
7653
7654         * ada-lang.c (ada_remove_Xbn_suffix)
7655         (find_old_style_renaming_symbol)
7656         (parse_old_style_renaming): Remove.
7657         (ada_find_renaming_symbol): Don't call
7658         find_old_style_renaming_symbol.
7659         (ada_is_renaming_symbol): Rename from
7660         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7661         bool.  Now static.
7662         (ada_read_var_value): Update and simplify.
7663         * ada-exp.y (write_var_or_type): Remove old code.
7664
7665 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7666
7667         PR gdb/25010
7668         * event-top.c: Remove include comment.
7669         * inflow.c (class scoped_ignore_sigttou): Move from here...
7670         * inflow.h (class scoped_ignore_sigttou): ...to here.
7671         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7672         * top.c:  Remove include comment.
7673
7674 2019-05-27  Tom Tromey  <tom@tromey.com>
7675
7676         * NEWS: Fix typo.
7677
7678 2019-05-22  Tom Tromey  <tromey@adacore.com>
7679
7680         * target.c (target_follow_exec): Constify parameter.
7681         * target-delegates.c: Rebuild.
7682         * remote.c (remote_target::follow_exec): Constify parameter.
7683         * infrun.c (follow_exec): Constify parameter.
7684         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7685         (target_follow_exec): Likewise.
7686
7687 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7688
7689         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7690         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7691
7692 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7693
7694         * NEWS: Add debugredirect and testsuite sections.
7695
7696 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7697
7698         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7699         target descriptions using exclusively floating point register name
7700         aliases.
7701
7702 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         PR gdb/18644:
7705         * f-lang.c (build_fortran_types): Handle the case where
7706         gdbarch_floatformat_for_type returns a nullptr.
7707
7708 2019-05-21  Tom de Vries  <tdevries@suse.de>
7709
7710         PR cli/24587
7711         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7712
7713 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         PR gdb/18644:
7716         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7717         16-byte floats.
7718         * i386-tdep.c (i386_floatformat_for_type): Use
7719         floatformats_ia64_quad for the 16-byte floating point component
7720         within a fortran 32-byte complex number.
7721
7722 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7725         delete default constructor.
7726         (find_partial_die): Update to return const struct.
7727         (partial_die_parent_scope): Move variable declaration into scope
7728         of its use and change its type to auto.
7729         (guess_partial_die_structure_name): Likewise.
7730         (partial_die_info::fixup): Likewise.
7731
7732 2019-05-17  Tom Tromey  <tromey@adacore.com>
7733
7734         * source.c (find_and_open_source): Remove cast.
7735
7736 2019-05-17  Tom Tromey  <tromey@adacore.com>
7737
7738         * annotate.c (annotate_source): Make "filename" const.
7739         * annotate.h (annotate_source): Use const.
7740
7741 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7742
7743         * disasm.c (set_disassembler_options): Send errors to stderr.
7744
7745 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7746
7747         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7748         (cli_interp_base::set_logging): Check debug_redirect.
7749         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7750         * cli/cli-logging.c (debug_redirect): Add static variable.
7751         (pop_output_files): Add default param.
7752         (handle_redirections): Print debug setting.
7753         (show_logging_command): Likewise.
7754         (_initialize_cli_logging): Add debugredirect command.
7755         * interps.c (current_interp_set_logging): Add debug_redirect
7756         parameter.
7757         * interps.h (set_logging): Add debug_redirect parameter.
7758         (current_interp_set_logging): Likewise.
7759         * mi/mi-common.h: Likewise.
7760         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7761
7762 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7763             Tom Tromey  <tromey@adacore.com>
7764
7765         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7766         directly.
7767         * cli/cli-interp.h (make_logging_output): Remove declaration.
7768         * cli/cli-logging.c (make_logging_output): Remove function.
7769         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7770         directly.
7771         * ui-file.c (tee_file::tee_file): Remove bools.
7772         (tee_file::~tee_file): Remove deletes.
7773         * ui-file.h (tee_file): Remove bools.
7774
7775 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7776
7777         * mi/mi-cmds.h (mi_cmd_complete): New function.
7778         * mi/mi-main.c (mi_cmd_complete): Likewise.
7779         * mi/mi-cmds.c: Define new MI command -complete.
7780         * NEWS: Mention new -complete command.
7781
7782 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7783
7784         * completer.h (complete): New function.
7785         * completer.c (complete): Likewise.
7786         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7787         function defined in completer.h.
7788
7789 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7790
7791         * MAINTAINERS (Write After Approval): Add myself.
7792
7793 2019-05-17  Tom de Vries  <tdevries@suse.de>
7794
7795         PR gdb/24094
7796         * dwarf2read.c (struct cu_partial_die_info): New struct.
7797         (find_partial_die): Return cu_partial_die_info.
7798         (partial_die_parent_scope, guess_partial_die_structure_name)
7799         (partial_die_info::fixup): Handle new return type of find_partial_die.
7800
7801 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7802
7803         PR breakpoints/24541
7804         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7805         "std::string", simplifying the algorithm.
7806
7807 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7808
7809         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7810         (stap_static_probe_ops::get_probes): Likewise.
7811
7812 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7813
7814         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7815         '-')" and "else if".
7816         (stap_parse_single_operand): Join checks for
7817         "gdbarch_stap_parse_special_token_p" and
7818         "gdbarch_stap_parse_special_token" in the same "if" statement.
7819         Invert check when verifying for operation on register
7820         displacement.
7821
7822 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7823
7824         * stap-probe.c (stap_get_opcode): Update comment.
7825         (stap_get_expected_argument_type): Likewise.
7826         (handle_stap_probe): Likewise.
7827
7828 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7829
7830         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7831         return type to 'bool'.  Adjust comment.  Use 'bool' when
7832         appropriate.
7833         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7834         * stap-probe.c (stap_parse_argument_1): Likewise.
7835         (stap_is_operator): Likewise.
7836         (stap_is_generic_prefix): Likewise.
7837         (stap_is_register_prefix): Likewise.
7838         (stap_is_register_indirection_prefix): Likewise.
7839         (stap_is_integer_prefix): Likewise.
7840         (stap_generic_check_suffix): Likewise.
7841         (stap_check_integer_suffix): Likewise.
7842         (stap_check_register_suffix): Likewise.
7843         (stap_check_register_indirection_suffix): Likewise.
7844         (stap_parse_register_operand): Likewise.
7845         (stap_parse_single_operand): Likewise.
7846         (stap_parse_argument_1): Likewise.
7847         (stap_probe::get_argument_count): Likewise.
7848         (stap_is_operator): Likewise.
7849
7850 2019-05-16  Tom Tromey  <tromey@adacore.com>
7851
7852         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7853         keyword to foreach.
7854
7855 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7856
7857         * linux-thread-db.c (try_thread_db_load_1): Change return type
7858         to bool.
7859         (try_thread_db_load): Likewise.
7860         (try_thread_db_load_from_pdir_1): Likewise.
7861         (try_thread_db_load_from_pdir): Likewise.
7862         (try_thread_db_load_from_sdir): Likewise.
7863         (try_thread_db_load_from_dir): Likewise.
7864         (thread_db_load_search): Likewise.
7865         (has_libpthread): Likewise.
7866         (thread_db_load): Likewise.
7867
7868 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7869
7870         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7871         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7872         NULL, and complain/return if that's the case.
7873
7874 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7875
7876         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7877         (advance, posn, abstract_read_memory): New functions.
7878         [struct mem_read_abstraction]: New struct.
7879         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7880
7881 2019-05-14  Tom Tromey  <tromey@adacore.com>
7882
7883         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7884         value is not lval_memory.
7885
7886 2019-05-14  Tom Tromey  <tromey@adacore.com>
7887
7888         * solib.c (info_sharedlibrary_command): Style the file name.
7889
7890 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7891
7892         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7893         (aarch64_vnv_type): Likewise.
7894         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7895         * common/tdesc.c: Likewise.
7896         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7897         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7898         * features/aarch64-fpu.xml: Add ieee half view.
7899         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7900         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7901         * gdbtypes.h (struct builtin_type): Likewise.
7902         (struct objfile_type): Likewise.
7903
7904 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7905
7906         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7907         typo.
7908         * location.h (string_to_event_location): Likewise.
7909
7910 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7911
7912         GDB 8.3 released.
7913
7914 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7915
7916         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7917         New variable declaration.
7918         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7919         New variable.
7920         (print_one_breakpoint): Use ui_out::test_flags and new global
7921         variable to compute use_fixed_output.
7922         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7923         Remove.
7924         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7925         (mi_multi_location_breakpoint_output_fixed): Remove.
7926         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7927         new variable.
7928         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7929         fix_multi_location_breakpoint_output flag if version >= 3.
7930         * ui-out.h (enum ui_out_flag)
7931         <fix_multi_location_breakpoint_output>: New enumerator.
7932
7933 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7934
7935         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7936
7937 2019-05-10  Tom Tromey  <tromey@adacore.com>
7938
7939         * ada-lang.c (catch_ada_completer): New function.
7940         (_initialize_ada_language): Use it.
7941
7942 2019-05-10  Tom Tromey  <tromey@adacore.com>
7943
7944         * thread.c (print_thread_info): Make "requested_threads" const.
7945         * gdbthread.h (print_thread_info): Make "requested_threads"
7946         const.
7947         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7948         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7949
7950 2019-05-08  Tom Tromey  <tom@tromey.com>
7951
7952         * gdbtypes.c (objfile_type_data): Change type.
7953         (objfile_type, _initialize_gdbtypes): Update.
7954
7955 2019-05-08  Tom Tromey  <tom@tromey.com>
7956
7957         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7958         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7959         (_initialize_dwarf2_frame): Update.
7960
7961 2019-05-08  Tom Tromey  <tom@tromey.com>
7962
7963         * objc-lang.c (objc_objfile_data): Change type.
7964         (find_methods): Update.
7965         (_initialize_objc_lang): Remove.
7966
7967 2019-05-08  Tom Tromey  <tom@tromey.com>
7968
7969         * stabsread.c (rs6000_builtin_type_data): Change type.
7970         (rs6000_builtin_type, _initialize_stabsread): Update.
7971
7972 2019-05-08  Tom Tromey  <tom@tromey.com>
7973
7974         * mips-tdep.c (mips_pdr_data): Remove.
7975         (_initialize_mips_tdep): Update.
7976
7977 2019-05-08  Tom Tromey  <tom@tromey.com>
7978
7979         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7980         (hppa_init_objfile_priv_data, read_unwind_info)
7981         (find_unwind_entry, _initialize_hppa_tdep): Update.
7982
7983 2019-05-08  Tom Tromey  <tom@tromey.com>
7984
7985         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7986         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7987         on obstack.
7988         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7989
7990 2019-05-08  Tom Tromey  <tom@tromey.com>
7991
7992         * mdebugread.c (basic_type_data): Change type.
7993         (basic_type, _initialize_mdebugread): Update.
7994
7995 2019-05-08  Tom Tromey  <tom@tromey.com>
7996
7997         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7998
7999 2019-05-08  Tom Tromey  <tom@tromey.com>
8000
8001         * nto-tdep.c (nto_inferior_data_reg): Change type.
8002         (nto_inferior_data): Update.
8003         (nto_inferior_data_cleanup, nto_new_inferior_data)
8004         (_initialize_nto_tdep): Remove.
8005         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8006
8007 2019-05-08  Tom Tromey  <tom@tromey.com>
8008
8009         * ada-lang.c (struct ada_inferior_data): Add initializers.
8010         (ada_inferior_data): Change type.
8011         (ada_inferior_data_cleanup): Remove.
8012         (get_ada_inferior_data, ada_inferior_exit)
8013         (struct ada_pspace_data): Add initializers, destructor.
8014         (ada_pspace_data_handle): Change type.
8015         (get_ada_pspace_data): Update.
8016         (ada_pspace_data_cleanup): Remove.
8017
8018 2019-05-08  Tom Tromey  <tom@tromey.com>
8019
8020         * coffread.c (struct coff_symfile_info): Add initializers.
8021         (coff_objfile_data_key): Move lower.  Change type.
8022         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8023         Update.
8024         (coff_free_info): Remove.
8025
8026 2019-05-08  Tom Tromey  <tom@tromey.com>
8027
8028         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8029         (fbsd_pspace_data_handle): Move lower.  Change type.
8030         (get_fbsd_pspace_data): Update.
8031         (fbsd_pspace_data_cleanup): Remove.
8032         (_initialize_fbsd_tdep): Update.
8033
8034 2019-05-08  Tom Tromey  <tom@tromey.com>
8035
8036         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8037         (get_ada_tasks_pspace_data): Update.
8038         (ada_tasks_pspace_data_cleanup): Remove.
8039         (_initialize_tasks): Update.
8040         (ada_tasks_inferior_data_handle): Change type.
8041         (get_ada_tasks_inferior_data): Update.
8042         (ada_tasks_inferior_data_cleanup): Remove.
8043         (struct ada_tasks_pspace_data): Add initializers.
8044
8045 2019-05-08  Tom Tromey  <tom@tromey.com>
8046
8047         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8048         * symfile-debug.c (debug_sym_get_probes): Change type.
8049         * stap-probe.c (handle_stap_probe):
8050         (stap_static_probe_ops::get_probes): Change type.
8051         * probe.h (class static_probe_ops) <get_probes>: Change type.
8052         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8053         (parse_probes_in_pspace): Update.
8054         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8055         Update.
8056         (any_static_probe_ops::get_probes): Change type.
8057         * elfread.c (elfread_data): New typedef.
8058         (probe_key): Change type.
8059         (elf_get_probes): Likewise.  Update.
8060         (probe_key_free): Remove.
8061         (_initialize_elfread): Update.
8062         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8063         Change type.
8064         (dtrace_process_dof_probe, dtrace_process_dof)
8065         (dtrace_static_probe_ops::get_probe): Change type.
8066
8067 2019-05-08  Tom Tromey  <tom@tromey.com>
8068
8069         * xcoffread.c (struct xcoff_symfile_info): Rename from
8070         coff_symfile_info.  Add initializers.
8071         (xcoff_objfile_data_key): Move lower.  Change type.
8072         (XCOFF_DATA): Rewrite.
8073         (xcoff_free_info): Remove.
8074         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8075         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8076         (xcoff_initial_scan): Update.
8077
8078 2019-05-08  Tom Tromey  <tom@tromey.com>
8079
8080         * solib-svr4.c (struct svr4_info): Add initializers and
8081         destructor.
8082         <probes_table>: Now an htab_up.
8083         (solib_svr4_pspace_data): Change type.
8084         (free_probes_table): Simplify.
8085         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8086         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8087         (probes_table_remove_objfile_probes, register_solib_event_probe)
8088         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8089         (_initialize_svr4_solib): Update.
8090
8091 2019-05-08  Tom Tromey  <tom@tromey.com>
8092
8093         * remote.c (remote_pspace_data): Change type.
8094         (remote_pspace_data_cleanup): Remove.
8095         (get_remote_exec_file, set_pspace_remote_exec_file)
8096         (_initialize_remote): Update.
8097
8098 2019-05-08  Tom Tromey  <tom@tromey.com>
8099
8100         * breakpoint.c (breakpoint_objfile_key): Change type.
8101         (get_breakpoint_objfile_data): Update.
8102         (free_breakpoint_objfile_data): Remove.
8103         (_initialize_breakpoint): Update.
8104
8105 2019-05-08  Tom Tromey  <tom@tromey.com>
8106
8107         * linux-tdep.c (struct linux_info): Add initializers.
8108         (linux_inferior_data): Move.  Change type.
8109         (invalidate_linux_cache_inf): Update.
8110         (linux_inferior_data_cleanup): Remove.
8111         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8112
8113 2019-05-08  Tom Tromey  <tom@tromey.com>
8114
8115         * auxv.c (auxv_inferior_data): Move.  Change type.
8116         (auxv_inferior_data_cleanup): Remove.
8117         (invalidate_auxv_cache_inf): Rewrite.
8118         (get_auxv_inferior_data, _initialize_auxv): Update.
8119
8120 2019-05-08  Tom Tromey  <tom@tromey.com>
8121
8122         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8123         (symfile_debug_objfile_data_key): Change type.
8124         (symfile_debug_installed, debug_qf_has_symbols)
8125         (debug_qf_find_last_source_symtab)
8126         (debug_qf_forget_cached_source_info)
8127         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8128         (debug_qf_print_stats, debug_qf_dump)
8129         (debug_qf_expand_symtabs_for_function)
8130         (debug_qf_expand_all_symtabs)
8131         (debug_qf_expand_symtabs_with_fullname)
8132         (debug_qf_map_matching_symbols)
8133         (debug_qf_expand_symtabs_matching)
8134         (debug_qf_find_pc_sect_compunit_symtab)
8135         (debug_qf_map_symbol_filenames)
8136         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8137         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8138         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8139         (debug_sym_read_linetable, debug_sym_relocate): Update.
8140         (symfile_debug_free_objfile): Remove.
8141         (install_symfile_debug_logging, _initialize_symfile_debug):
8142         Update.
8143
8144 2019-05-08  Tom Tromey  <tom@tromey.com>
8145
8146         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8147         allocate_on_obstack.
8148         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8149         (get_dwarf2_per_objfile): Update.
8150         (set_dwarf2_per_objfile): Remove.
8151         (dwarf2_has_info, dwarf2_get_section_info): Update.
8152         (dwarf2_free_objfile): Remove.
8153         (_initialize_dwarf2_read): Update.
8154
8155 2019-05-08  Tom Tromey  <tom@tromey.com>
8156
8157         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8158         initializers.
8159         <unsupported_script_warning_printed,
8160         script_not_found_warning_printed>: Now bool.
8161         (auto_load_pspace_data): Change type.
8162         (~auto_load_pspace_info): Rename from
8163         auto_load_pspace_data_cleanup.
8164         (get_auto_load_pspace_data, init_loaded_scripts_info)
8165         (clear_section_scripts, maybe_print_unsupported_script_warning)
8166         (maybe_print_script_not_found_warning, _initialize_auto_load):
8167         Update.
8168
8169 2019-05-08  Tom Tromey  <tom@tromey.com>
8170
8171         * objfiles.c (objfile_pspace_info): Add destructor and
8172         initializers.
8173         (objfiles_pspace_data): Change type.
8174         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8175         (get_objfile_pspace_data): Update.
8176         (objfiles_bfd_data): Change type.
8177         (get_objfile_bfd_data): Update.
8178         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8179
8180 2019-05-08  Tom Tromey  <tom@tromey.com>
8181
8182         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8183         Change type.
8184         (get_catch_syscall_inferior_data): Update.
8185         (catch_syscall_inferior_data_cleanup): Remove.
8186         (_initialize_break_catch_syscall): Update.
8187
8188 2019-05-08  Tom Tromey  <tom@tromey.com>
8189
8190         * inflow.c (struct terminal_info): Add destructor and
8191         initializers.
8192         (inflow_inferior_data): Change type.
8193         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8194         (get_inflow_inferior_data, inflow_inferior_exit)
8195         (swap_terminal_info, _initialize_inflow): Update.
8196
8197 2019-05-08  Tom Tromey  <tom@tromey.com>
8198
8199         * target-dcache.c (target_dcache_cleanup): Remove.
8200         (target_dcache_aspace_key): Change type.
8201         (target_dcache_init_p, target_dcache_invalidate)
8202         (target_dcache_get, target_dcache_get_or_init)
8203         (_initialize_target_dcache): Update.
8204         * dcache.h (struct dcache_deleter): New.
8205
8206 2019-05-08  Tom Tromey  <tom@tromey.com>
8207
8208         * symtab.c (struct symbol_cache): Add destructor and
8209         initializers.
8210         (symbol_cache_key): Move.  Change type.
8211         (make_symbol_cache, free_symbol_cache): Remove.
8212         (get_symbol_cache): Update.
8213         (symbol_cache_cleanup): Remove.
8214         (ALL_PSPACES, symbol_cache_flush)
8215         (maintenance_print_symbol_cache)
8216         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8217         Update.
8218
8219 2019-05-08  Tom Tromey  <tom@tromey.com>
8220
8221         * symtab.c (struct main_info): Add destructor and initializers.
8222         (main_progspace_key): Move.  Change type.
8223         (get_main_info): Update.
8224         (main_info_cleanup): Remove.
8225         (_initialize_symtab): Update.
8226
8227 2019-05-08  Tom Tromey  <tom@tromey.com>
8228
8229         * registry.h (DECLARE_REGISTRY): Define the _key class.
8230
8231 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8232
8233         * NEWS: Merge two 'New commands' sections.
8234
8235 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8236
8237         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8238         parameter and use Ada language definition instead.
8239         (ada_val_print_ptr): Remove unused language parameter.
8240         (ada_val_print_num): Remove language parameter and use Ada language
8241         definition instead.
8242         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8243         parameter.
8244         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8245         parameter and use Ada language definition instead.
8246         (ada_val_print_1): Update all ada_val_print_xxx calls.
8247         Remove language parameter.
8248         (ada_val_print): Update ada_val_print_1 call.
8249
8250 2019-05-08  Tom Tromey  <tromey@adacore.com>
8251
8252         * remote.c (remote_hw_watchpoint_limit)
8253         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8254         Now static.
8255
8256 2019-05-08  Tom Tromey  <tromey@adacore.com>
8257
8258         * maint.c (_initialize_maint_cmds): Move initialization code to
8259         remote.c.
8260         (watchdog, show_watchdog): Move to remote.c.
8261         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8262         "watchdog" static.
8263         (_initialize_remote): Move initialization code from maint.c.
8264         * defs.h (watchdog): Don't declare.
8265
8266 2019-05-08  Tom Tromey  <tromey@adacore.com>
8267
8268         * tui/tui-interp.c: Include main.h.
8269         * interps.c: Include main.h.
8270         * main.h (interpreter_p): Declare.
8271         * defs.h (interpreter_p): Don't declare.
8272
8273 2019-05-08  Tom Tromey  <tromey@adacore.com>
8274
8275         * dwarf2loc.c: Include dwarf2read.h.
8276         * defs.h (read_unsigned_leb128): Don't declare.
8277         * dwarf2read.h (read_unsigned_leb128): Declare.
8278
8279 2019-05-08  Tom Tromey  <tromey@adacore.com>
8280
8281         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8282         method.
8283
8284 2019-05-08  Tom Tromey  <tromey@adacore.com>
8285
8286         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8287         when no wrap column is set.
8288
8289 2019-05-08  Tom Tromey  <tromey@adacore.com>
8290
8291         * c-lang.c (c_get_string): Handle non-C-style arrays.
8292
8293 2019-05-08  Tom Tromey  <tromey@adacore.com>
8294
8295         * typeprint.c (print_offset_data::update): Print the bit offset,
8296         not the number of bits remaining.
8297
8298 2019-05-08  Tom Tromey  <tromey@adacore.com>
8299
8300         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8301         padding at end of comment.
8302
8303 2019-05-08  Tom Tromey  <tromey@adacore.com>
8304
8305         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8306         Compare main types.
8307
8308 2019-05-06  Tom Tromey  <tom@tromey.com>
8309
8310         * common/scoped_mmap.c: Include common-defs.h.
8311         * common/scoped_mmap.h: Don't include config.h.
8312
8313 2019-05-04  Tom Tromey  <tom@tromey.com>
8314
8315         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8316         (struct aarch64_call_info): Add initializers.
8317         <si>: Now a std::vector.
8318         (pass_on_stack, aarch64_push_dummy_call): Update.
8319
8320 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8321             Tom Tromey  <tom@tromey.com>
8322
8323         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8324         (ppc_threads): Now a std::vector.  Now static.
8325         (hwdebug_find_thread_points_by_tid)
8326         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8327         Update.
8328
8329 2019-05-04  Tom Tromey  <tom@tromey.com>
8330
8331         * arc-tdep.c (arc_tdesc_init): Return bool.
8332
8333 2019-05-04  Tom Tromey  <tom@tromey.com>
8334
8335         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8336         Use gdb_assert_not_reached.
8337
8338 2019-05-04  Tom Tromey  <tom@tromey.com>
8339
8340         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8341         "false".
8342
8343 2019-05-04  Tom Tromey  <tom@tromey.com>
8344
8345         * arc-tdep.c (arc_tdesc_init): Use bool.
8346
8347 2019-05-04  Tom Tromey  <tom@tromey.com>
8348
8349         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8350
8351 2019-05-04  Tom Tromey  <tom@tromey.com>
8352
8353         * cli/cli-cmds.c (valid_command_p): Return bool.
8354
8355 2019-05-04  Tom Tromey  <tom@tromey.com>
8356
8357         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8358         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8359
8360 2019-05-04  Raul Tambre  <raul@tambre.ee>
8361
8362         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8363         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8364         operator for comparison.
8365
8366 2019-05-04  Tom Tromey  <tom@tromey.com>
8367
8368         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8369         (lookup_partial_symbol, print_partial_symbols)
8370         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8371         (psymbol_compare): Update.
8372         (add_psymbol_to_bcache): Clear the entire psymbol.
8373         (maintenance_check_psymtabs): Update.
8374         * psympriv.h (struct partial_symbol): Don't derive from
8375         general_symbol_info.
8376         <obj_section, unrelocated_address, address,
8377         set_unrelocated_address>: Update.
8378         <ginfo>: New member.
8379         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8380         (debug_names::write_psymbols): Update.
8381
8382 2019-05-04  Tom de Vries  <tdevries@suse.de>
8383
8384         * contrib/cc-with-tweaks.sh: Support -n arg.
8385
8386 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8387
8388         * corelow.c (core_target::detach): Ensure frame cache and
8389         register caches are cleared.
8390         inferior.c (exit_inferior_1): Likewise.
8391
8392 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8393             Tom Tromey  <tom@tromey.com>
8394
8395         * dictionary.c (collate_pending_symbols_by_language): Remove
8396         "struct" from foreach.
8397         * symtab.c (lookup_global_symbol_from_objfile)
8398         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8399         foreach.
8400         * ser-tcp.c (net_open): Remove "struct" from foreach.
8401         * objfiles.c (objfile_relocate, objfile_rebase)
8402         (objfile_has_symbols): Remove "struct" from foreach.
8403         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8404         from foreach.
8405         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8406         foreach.
8407         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8408         "struct" from foreach.
8409         * ada-lang.c (create_excep_cond_exprs)
8410         (ada_exception_catchpoint_cond_string): Remove "struct" from
8411         foreach.
8412
8413 2019-05-03  Tom Tromey  <tromey@adacore.com>
8414
8415         * ada-exp.y (convert_char_literal): Check suffix of each
8416         enumerator.
8417
8418 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8419
8420         PR ada/21406:
8421         * ada-exp.y (yywrap): Don't define.
8422         * ada-lex.l (%option): Add noyywrap
8423         (yywrap): Remove.
8424
8425 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8426
8427         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8428         _WIN32_WINNT to the XP level, unless already defined to a higher
8429         level.
8430
8431         * unittests/parse-connection-spec-selftests.c:
8432         * ser-tcp.c:
8433         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8434         override.
8435
8436         * symfile.c (find_separate_debug_file): Remove colon from the
8437         drive spec of DOS/Windows file names of the target, so that the
8438         file name produced from DEBUGDIR and the target's directory will
8439         be valid on DOS/Windows systems.
8440
8441 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8442
8443         * rust-lang.c (val_print_struct): Handle printing structures
8444         containing strings.
8445
8446 2019-05-02  Tom Tromey  <tromey@adacore.com>
8447
8448         * valarith.c (_initialize_valarith): Remove.
8449
8450 2019-05-01  Tom Tromey  <tromey@adacore.com>
8451
8452         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8453         bitfields.
8454
8455 2019-05-01  Tom Tromey  <tromey@adacore.com>
8456
8457         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8458         for big-endian copies.
8459
8460 2019-04-30  Ali Tamur  <tamur@google.com>
8461         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8462         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8463         (read_3_bytes): New function.
8464
8465 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8466
8467         * windows-nat.c (main_thread_id): Delete.
8468         (handle_output_debug_string): Replace main_thread_id by
8469         current_event.dwThreadId.
8470         (fake_create_process): Likewise.
8471         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8472         Do not set main_thread_id.
8473         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8474         current_event.dwThreadId.
8475         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8476
8477 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8478
8479         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8480         Use current_event.dwThreadId instead of main_thread_id.
8481
8482 2019-04-30  Tom Tromey  <tromey@adacore.com>
8483
8484         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8485         (create_excep_cond_exprs): Iterate over program spaces.
8486         (ada_exception_catchpoint_cond_string): Examine all minimal
8487         symbols for exception types.
8488
8489 2019-04-30  Tom Tromey  <tromey@adacore.com>
8490
8491         PR c++/24470:
8492         * dwarf2read.c (process_structure_scope): Handle case where type
8493         has template parameters but no symbol was created.
8494
8495 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8496             Chris January  <chris.january@arm.com>
8497
8498         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8499         qualifier.
8500         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8501
8502 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8503
8504         * f-typeprint.c (f_print_type): Update rules for printing
8505         whitespace.
8506         (f_type_print_varspec_suffix): Likewise.
8507
8508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8509             Chris January  <chris.january@arm.com>
8510
8511         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8512         function arguments.
8513
8514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8515
8516         * f-lang.c (build_fortran_types): Change name of void type to
8517         lower case.
8518         * f-typeprint.c (f_type_print_base): Print the name of the void
8519         type, rather than a fixed string.
8520         * f-valprint.c (f_decorations): Use lower case void string.
8521
8522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8523             Chris January  <chris.january@arm.com>
8524
8525         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8526         types for Fortran.
8527
8528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8529             Chris January  <chris.january@arm.com>
8530             David Lecomber  <david.lecomber@arm.com>
8531
8532         * f-exp.y (BINOP_INTRINSIC): New token.
8533         (exp): New parser rule handling BINOP_INTRINSIC.
8534         (f77_keywords): Add new builtin procedures.
8535         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8536         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8537         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8538         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8539         (print_unop_subexp_f): New function.
8540         (print_binop_subexp_f): New function.
8541         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8542         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8543         (dump_subexp_body_f): Likewise.
8544         (operator_check_f): Likewise.
8545         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8546         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8547
8548 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8551         UNOP_KIND.
8552         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8553         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8554         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8555         (operator_length_f): New fuction.
8556         (print_subexp_f): New function.
8557         (op_name_f): New function.
8558         (dump_subexp_body_f): New function.
8559         (operator_check_f): New function.
8560         (exp_descriptor_f): Replace standard expression handling functions
8561         with new functions.
8562         * gdb/fortran-operator.def: New file.
8563         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8564         * gdb/std-operator.def: Remove UNOP_KIND.
8565
8566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8567
8568         * std-operator.def: Remove unbalanced, stray double quote
8569         character.
8570
8571 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8572             Chris January  <chris.january@arm.com>
8573             Daniel Everett  <daniel.everett@arm.com>
8574             Nick Forrington  <nick.forrington@arm.com>
8575             Richard Bunt  <richard.bunt@arm.com>
8576
8577         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8578         of depth when printing anonymous structs or unions.
8579         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8580         Don't print either the top-level value, or the children if the
8581         max-depth is exceeded.
8582         (ppscm_print_children): When printing the key of a map, allow one
8583         extra level of depth.
8584         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8585         print either the top-level value, or the children if the max-depth
8586         is exceeded.
8587         (print_children): When printing the key of a map, allow one extra
8588         level of depth.
8589         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8590         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8591         (user_print_options): Initialise max_depth field.
8592         (val_print_scalar_or_string_type_p): New function.
8593         (val_print): Check to see if the max depth has been reached.
8594         (val_print_check_max_depth): Define new function.
8595         (show_print_max_depth): New function.
8596         (_initialize_valprint): Add 'print max-depth' option.
8597         * valprint.h (struct value_print_options) <max_depth>: New field.
8598         (val_print_check_max_depth): Declare new function.
8599         * NEWS: Document new feature.
8600
8601 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8602
8603         * ada-lang.c (ada_language_defn): Initialise new field.
8604         * c-lang.c (c_is_string_type_p): New function.
8605         (c_language_defn): Initialise new field.
8606         (cplus_language_defn): Initialise new field.
8607         (asm_language_defn): Initialise new field.
8608         (minimal_language_defn): Initialise new field.
8609         * c-lang.h (c_is_string_type_p): Declare new function.
8610         * d-lang.c (d_language_defn): Initialise new field.
8611         * f-lang.c (f_is_string_type_p): New function.
8612         (f_language_defn): Initialise new field.
8613         * go-lang.c (go_is_string_type_p): New function.
8614         (go_language_defn): Initialise new field.
8615         * language.c (default_is_string_type_p): New function.
8616         (unknown_language_defn): Initialise new field.
8617         (auto_language_defn): Initialise new field.
8618         * language.h (struct language_defn) <la_is_string_type_p>: New
8619         member variable.
8620         (default_is_string_type_p): Declare new function.
8621         * m2-lang.c (m2_language_defn): Initialise new field.
8622         * objc-lang.c (objc_language_defn): Initialise new field.
8623         * opencl-lang.c (opencl_language_defn): Initialise new field.
8624         * p-lang.c (pascal_is_string_type_p): New function.
8625         (pascal_language_defn): Initialise new field.
8626         * rust-lang.c (rust_is_string_type_p): New function.
8627         (rust_language_defn): Initialise new field.
8628
8629 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8630
8631         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8632         New field.
8633         * ada-lang.c (ada_language_defn): Initialise new field.
8634         * c-lang.c (c_language_defn): Likewise.
8635         (cplus_language_defn): Likewise.
8636         (asm_language_defn): Likewise.
8637         (minimal_language_defn): Likewise.
8638         * d-lang.c (d_language_defn): Likewise.
8639         * f-lang.c (f_language_defn): Likewise.
8640         * go-lang.c (go_language_defn): Likewise.
8641         * language.c (unknown_language_defn): Likewise.
8642         (auto_language_defn): Likewise.
8643         * m2-lang.c (m2_language_defn): Likewise.
8644         * objc-lang.c (objc_language_defn): Likewise.
8645         * opencl-lang.c (opencl_language_defn): Likewise.
8646         * p-lang.c (pascal_language_defn): Likewise.
8647         * rust-lang.c (rust_language_defn): Likewise.
8648
8649 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8650
8651         * ada-lang.c (ada_is_character_type): Change return type to bool.
8652         (ada_is_string_type): Likewise.
8653         * ada-lang.h (ada_is_character_type): Update declaration
8654         (ada_is_string_type): Likewise.
8655
8656 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8657
8658         Support style in 'frame|thread apply'
8659
8660         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8661         * record.c (record_start, record_stop): Update callers of
8662         execute_command_to_string with false.
8663         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8664         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8665         methods.
8666         (class string_file): New constructor with term_out parameter.
8667         Override methods term_out and can_emit_style_escape.  New member
8668         term_out.
8669         (class stdio_file): Override can_emit_style_escape.
8670         (class tee_file): Override term_out and can_emit_style_escape.
8671         * utils.h (can_emit_style_escape): Remove.
8672         * utils.c (can_emit_style_escape): Likewise.
8673         Update all callers of can_emit_style_escape (SOMESTREAM) to
8674         SOMESTREAM->can_emit_style_escape.
8675         * source-cache.c (source_cache::get_source_lines): Likewise.
8676         * stack.c (frame_apply_command_count): Call execute_command_to_string
8677         passing the term_out characteristic of the current gdb_stdout.
8678         * thread.c (thr_try_catch_cmd): Likewise.
8679         * top.c (execute_command_to_string): pass term_out parameter
8680         to construct the string_file for the command output.
8681         * ui-file.c (term_cli_styling): New function (most code moved
8682         from utils.c can_emit_style_escape).
8683         (string_file::string_file, string_file::can_emit_style_escape,
8684         stdio_file::can_emit_style_escape, tee_file::term_out,
8685         tee_file::can_emit_style_escape): New functions.
8686
8687 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8688
8689         * NEWS: Mention the new set|show may-call-functions.
8690         * infcall.c (may_call_functions_p): New variable.
8691         (show_may_call_functions_p): New function.
8692         (call_function_by_hand_dummy): Throws an error if not
8693         may-call-functions.
8694         (_initialize_infcall): Call add_setshow_boolean_cmd for
8695         may-call-functions.
8696
8697 2019-04-25  Keith Seitz  <keiths@redhat.com>
8698
8699         PR c++/24367
8700         * cp-support.c (inspect_type): Don't attempt substitutions
8701         of symbol with the same name.
8702
8703 2019-04-25  Tom Tromey  <tromey@adacore.com>
8704
8705         PR gdb/24475:
8706         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8707         static.
8708
8709 2019-04-25  Tom Tromey  <tromey@adacore.com>
8710
8711         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8712         rvalue reference.
8713         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8714         (gdb_xml_parser::parse): Use std::move.
8715         * python/python-internal.h (gdbpy_convert_exception): Take a const
8716         reference.
8717         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8718         std::move.
8719         * python/py-utils.c (gdbpy_convert_exception): Take a const
8720         reference.
8721         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8722         Use std::move.
8723         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8724         Use std::move.
8725         * mi/mi-main.c (mi_print_exception): Take a const reference.
8726         * main.c (handle_command_errors): Take a const reference.
8727         * linespec.c (parse_linespec): Use std::move.
8728         * infcall.c (run_inferior_call): Use std::move.
8729         (call_function_by_hand_dummy): Use std::move.
8730         * exec.c (try_open_exec_file): Use std::move.
8731         * exceptions.h (exception_print, exception_fprintf)
8732         (exception_print_same): Update.
8733         * exceptions.c (print_exception, exception_print)
8734         (exception_fprintf, exception_print_same): Change parameters to
8735         const reference.
8736         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8737         * common/new-op.c: Use std::move.
8738         * common/common-exceptions.h (struct gdb_exception): Add move
8739         constructor.
8740         (struct gdb_exception_error, struct gdb_exception_quit, struct
8741         gdb_quit_bad_alloc): Change constructor to move constructor.
8742         (throw_exception): Change parameter to rvalue reference.
8743         * common/common-exceptions.c (throw_exception): Take rvalue
8744         reference.
8745         * cli/cli-interp.c (safe_execute_command): Use std::move.
8746         * breakpoint.c (insert_bp_location, location_to_sals): Use
8747         std::move.
8748
8749 2019-04-25  Tom Tromey  <tromey@adacore.com>
8750
8751         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8752         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8753         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8754         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8755         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8756         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8757         guile/scm-value.c: Use unpack.
8758         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8759         gdbscm_gdb_exception.
8760         (gdbscm_throw_gdb_exception): Likewise.
8761         (struct gdbscm_gdb_exception): New.
8762         (unpack): New function.
8763         (gdbscm_wrap): Use unpack.
8764
8765 2019-04-25  Tom Tromey  <tromey@adacore.com>
8766
8767         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8768         (gdb_rl_callback_handler): Use std::move.
8769         * common/common-exceptions.h (struct gdb_exception): Add move
8770         assignment operator.
8771         (throw_exception_sjlj): Change "exception" to const reference.
8772         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8773         (throw_exception_sjlj): Change "exception" to const reference.
8774
8775 2019-04-25  Tom Tromey  <tromey@adacore.com>
8776
8777         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8778         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8779         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8780         Update.
8781         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8782         Update.
8783         * mi/mi-interp.c (mi_interp::exec): Update.
8784         * linespec.c (parse_linespec): Update.
8785         * infcall.c (run_inferior_call): Update.
8786         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8787         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8788         (gdbscm_lookup_global_symbol): Update.
8789         * guile/scm-param.c (gdbscm_parameter_value): Update.
8790         * guile/scm-frame.c (gdbscm_frame_read_register)
8791         (gdbscm_frame_read_var): Update.
8792         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8793         * exec.c (try_open_exec_file): Update.
8794         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8795         (gdb_rl_callback_handler): Update.
8796         * common/common-exceptions.h (exception_none): Don't declare.
8797         * common/common-exceptions.c (exception_none): Don't define.
8798         (struct catcher) <exception>: Update.
8799         * cli/cli-interp.c (safe_execute_command): Update.
8800         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8801
8802 2019-04-25  Ali Tamur  <tamur@google.com>
8803
8804         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8805         (read_attribute_value): Likewise.
8806         (dwarf2_read_addr_index): Update comment.
8807         (read_str_index): Add DW_FORM_strx.
8808         (dwarf2_string_attr): Likewise.
8809         (dwarf2_const_value_attr): Likewise.
8810         (dump_die_shallow): Likewise.
8811         (dwarf2_fetch_constant_bytes): Likewise.
8812         (skip_form_bytes): Likewise.
8813         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8814
8815 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8816
8817         PR corefiles/11608
8818         PR corefiles/18187
8819         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8820         OFFSET.  Verify if current mapping contains an ELF header.
8821         (linux_find_memory_regions_full): Adjust call to
8822         dump_mapping_p.
8823
8824 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8825             Kang Li <kanglictf@gmail.com>
8826
8827         PR gdb/21600
8828
8829         * dwarf2-frame.c (read_initial_length): Be consistent about using
8830         unsigned representation of length.
8831         (decode_frame_entry_1): Likewise.  Check for wraparound of
8832         end pointer as well as buffer overflow.
8833
8834 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8835
8836         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8837         "vq".
8838
8839 2019-04-24  Tom Tromey  <tromey@adacore.com>
8840
8841         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8842
8843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * s12z-tdep.c (s12z_unwind_pc): Delete.
8846         (s12z_unwind_sp): Delete.
8847         (s12z_gdbarch_init): Don't register deleted functions with
8848         gdbarch.
8849
8850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * rl78-tdep.c (rl78_unwind_sp): Delete.
8853         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8854
8855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8858         (xstormy16_unwind_pc): Delete.
8859         (xstormy16_dummy_id): Delete.
8860         (xstormy16_gdbarch_init): Don't register deleted functions with
8861         gdbarch.
8862
8863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8864
8865         * vax-tdep.c (vax_unwind_pc): Delete.
8866         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8867
8868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8869
8870         * v850-tdep.c (v850_unwind_sp): Delete.
8871         (v850_unwind_pc): Delete.
8872         (v850_dummy_id): Delete.
8873         (v850_gdbarch_init): Don't register deleted functions with
8874         gdbarch.
8875
8876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8877
8878         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8879         (tilegx_unwind_pc): Delete.
8880         (tilegx_unwind_dummy_id): Delete.
8881         (tilegx_gdbarch_init): Don't register deleted functions with
8882         gdbarch.
8883
8884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8885
8886         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8887         (tic6x_dummy_id): Delete.
8888         (tic6x_gdbarch_init): Don't register deleted functions with
8889         gdbarch.
8890
8891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * sparc-tdep.c (sparc_unwind_pc): Delete.
8894         (sparc32_gdbarch_init): Don't register deleted function with
8895         gdbarch.
8896
8897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * sh-tdep.c (sh_unwind_sp): Delete.
8900         (sh_unwind_pc): Delete.
8901         (sh_dummy_id): Delete.
8902         (sh_gdbarch_init): Don't register deleted functions with
8903         gdbarch.
8904
8905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8906
8907         * score-tdep.c (score_unwind_sp): Delete.
8908         (score_unwind_pc): Delete.
8909         (score_dummy_id): Delete.
8910         (score_gdbarch_init): Don't register deleted functions with
8911         gdbarch.
8912
8913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * rx-tdep.c (rx_unwind_pc): Delete.
8916         (rx_unwind_sp): Delete.
8917         (rx_dummy_id): Delete.
8918         (rx_gdbarch_init): Don't register deleted functions with
8919         gdbarch.  Update comment.
8920
8921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8922
8923         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8924         (rs6000_dummy_id): Delete.
8925         (rs6000_gdbarch_init): Don't register deleted functions with
8926         gdbarch.
8927
8928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8929
8930         * or1k-tdep.c (or1k_dummy_id): Delete.
8931         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8932
8933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8934
8935         * nios2-tdep.c (nios2_dummy_id): Delete.
8936         (nios2_unwind_sp): Delete.
8937         (nios2_gdbarch_init): Don't register deleted functions with
8938         gdbarch.
8939
8940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8941
8942         * nds32-tdep.c (nds32_dummy_id): Delete.
8943         (nds32_unwind_pc): Delete.
8944         (nds32_unwind_sp): Delete.
8945         (nds32_gdbarch_init): Don't register deleted functions with
8946         gdbarch.
8947
8948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * msp430-tdep.c (msp430_unwind_pc): Delete.
8951         (msp430_unwind_sp): Delete.
8952         (msp430_dummy_id): Delete.
8953         (msp430_gdbarch_init): Don't register deleted functions with
8954         gdbarch.
8955
8956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * moxie-tdep.c (moxie_unwind_sp): Delete.
8959         (moxie_unwind_pc): Delete.
8960         (moxie_dummy_id): Delete.
8961         (moxie_gdbarch_init): Don't register deleted functions with
8962         gdbarch.
8963
8964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8965
8966         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8967         (mn10300_unwind_pc): Delete.
8968         (mn10300_unwind_sp): Delete.
8969         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8970         mn10300_unwind_sp.
8971         (mn10300_frame_unwind_init): Don't register deleted functions with
8972         gdbarch.
8973
8974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8975
8976         * mep-tdep.c (mep_unwind_pc): Delete.
8977         (mep_unwind_sp): Delete.
8978         (mep_dummy_id): Delete.
8979         (mep_gdbarch_init): Don't register deleted functions with
8980         gdbarch.
8981
8982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8983
8984         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8985         (m68hc11_unwind_sp): Delete.
8986         (m68hc11_gdbarch_init): Don't register deleted functions with
8987         gdbarch.
8988
8989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8990
8991         * m32r-tdep.c (m32r_unwind_sp): Delete.
8992         (m32r_unwind_pc): Delete.
8993         (m32r_dummy_id): Delete.
8994         (m32r_gdbarch_init): Don't register deleted functions with
8995         gdbarch.
8996
8997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * m32c-tdep.c (m32c_unwind_pc): Delete.
9000         (m32c_unwind_sp): Delete.
9001         (m32c_dummy_id): Delete.
9002         (m32c_gdbarch_init): Don't register deleted functions with
9003         gdbarch.
9004
9005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9008         (lm32_unwind_pc): Delete.
9009         (lm32_dummy_id): Delete.
9010         (lm32_gdbarch_init): Don't register deleted functions with
9011         gdbarch.
9012
9013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9016         (iq2000_unwind_pc): Delete.
9017         (iq2000_dummy_id): Delete.
9018         (iq2000_gdbarch_init): Don't register deleted functions with
9019         gdbarch.
9020
9021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * nds32-tdep.c (nds32_type_align): Delete.
9024         (nds32_push_dummy_call): Use type_align instead.
9025
9026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9027
9028         * arm-tdep.c (arm_type_align): Only handle vector override case.
9029         (arm_push_dummy_call): Use type_align.
9030         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9031
9032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9033
9034         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9035         case.
9036         (pass_on_stack): Use type_align.
9037         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9038         function.
9039
9040 2019-04-23  Tom Tromey  <tromey@adacore.com>
9041
9042         * dwarf2read.c (line_header::file_name_at): Remove unused
9043         overload.
9044
9045 2019-04-23  Tom de Vries  <tdevries@suse.de>
9046
9047         PR gdb/24438
9048         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9049         invocation.
9050
9051
9052 2019-03-27  Ali Tamur  <tamur@google.com>
9053
9054         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9055         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9056         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9057         (dwarf_expr_context::get_addr_index): Likewise
9058         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9059         (symbol_needs_eval_context::get_addr_index): Likewise
9060         (disassemble_dwarf_expression): Add DW_OP_addrx
9061         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9062         (read_cutu_die_from_dwo): Update comment
9063         (skip_one_die): Add DW_FORM_addrx
9064         (read_attribute_value): Likewise
9065         (var_decode_location): Add DW_OP_addrx
9066         (dwarf2_const_value_attr): Add DW_FORM_addrx
9067         (dump_die_shallow): Likewise
9068         (dwarf2_fetch_constant_bytes): Likewise
9069         (decode_locdesc): Add DW_OP_addrx
9070         (skip_form_bytes): Add DW_FORM_addrx
9071
9072 2019-04-22  Ali Tamur  <tamur@google.com>
9073
9074         * MAINTAINERS (Write After Approval): Add self.
9075
9076 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9077
9078         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9079         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9080         (open_symbol_file_object): Likewise.
9081         (svr4_default_sos): Add info parameter.
9082         (svr4_read_so_list): Likewise.
9083         (svr4_current_sos_direct): Adjust functions calls to pass down
9084         info.
9085         (svr4_current_sos_1): Add info parameter.
9086         (svr4_current_sos): Call get_svr4_info, pass info down to
9087         svr4_current_sos_1.
9088         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9089         get_svr4_info.
9090         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9091         get_svr4_info.
9092         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9093         to get_svr4_info.
9094         (probes_table_remove_objfile_probes): Likewise.
9095         (register_solib_event_probe): Add info parameter.
9096         (solist_update_incremental): Pass info parameter down to
9097         svr4_read_so_list.
9098         (disable_probes_interface): Add info parameter.
9099         (svr4_handle_solib_event): Pass current_program_space to
9100         get_svr4_info.  Adjust disable_probes_interface cleanup.
9101         (svr4_create_probe_breakpoints): Add info parameter, pass it
9102         down to register_solib_event_probe.
9103         (svr4_create_solib_event_breakpoints): Add info parameter,
9104         pass it down to svr4_create_probe_breakpoints.
9105         (enable_break): Pass info down to
9106         svr4_create_solib_event_breakpoints.
9107         (svr4_solib_create_inferior_hook): Pass current_program_space to
9108         get_svr4_info.
9109         (svr4_clear_solib): Likewise.
9110
9111 2019-04-22  Pedro Alves  <palves@redhat.com>
9112
9113         * solib-svr4.c (svr4_free_objfile_observer): New.
9114         (probe_and_action::objfile): New field.
9115         (probes_table_htab_remove_objfile_probes)
9116         (probes_table_remove_objfile_probes): New functions.
9117         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9118         in the new probe_and_action.  Don't store the probe in 'lookup'.
9119         (svr4_create_probe_breakpoints): Pass objfile to
9120         register_solib_event_probe.
9121         (_initialize_svr4_solib): Register a free_objfile observer.
9122
9123 2019-04-19  Tom Tromey  <tom@tromey.com>
9124
9125         * common/queue.h: Remove.
9126
9127 2019-04-19  Tom Tromey  <tom@tromey.com>
9128
9129         * event-loop.c: Don't include "common/queue.h".
9130
9131 2019-04-19  Tom Tromey  <tom@tromey.com>
9132
9133         * remote.c (remote_target): Use delete.
9134         * remote-notif.h: Include <list>, not "common/queue.h".
9135         (notif_client_p): Remove typedef.
9136         (remote_notif_state): Add constructor, destructor, initializer.
9137         <notif_queue>: Now a std::list.
9138         (remote_notif_state_xfree): Don't declare.
9139         * remote-notif.c (remote_notif_process, handle_notification)
9140         (remote_notif_state_allocate): Update.
9141         (~remote_notif_state): Rename from remote_notif_state_xfree.
9142
9143 2019-04-19  Tom Tromey  <tom@tromey.com>
9144
9145         * symfile.c (reread_symbols): Update.
9146         * objfiles.c (objfile_register_static_link)
9147         (objfile_lookup_static_link): Update
9148         (~objfile) Don't delete static_links.
9149         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9150
9151 2019-04-19  Tom Tromey  <tom@tromey.com>
9152
9153         * type-stack.h (struct type_stack) <insert>: Constify string.
9154         * type-stack.c (type_stack::insert): Constify string.
9155         * gdbtypes.h (lookup_template_type): Update.
9156         (address_space_name_to_int): Update.
9157         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9158         const.
9159         (lookup_template_type): Make name const.
9160         * c-exp.y: Update rules.
9161         (lex_one_token, classify_name, classify_inner_name)
9162         (c_print_token): Update.
9163         * p-exp.y: Update rules.
9164         (yylex): Update.
9165         * f-exp.y: Update rules.
9166         (yylex): Update.
9167         * d-exp.y: Update rules.
9168         (lex_one_token, classify_name, classify_inner_name): Update.
9169         * parse.c (write_dollar_variable, copy_name): Return std::string.
9170         * parser-defs.h (copy_name): Change return type.
9171         * m2-exp.y: Update rules.
9172         (yylex): Update.
9173         * go-exp.y (lex_one_token): Update.
9174         Update rules.
9175         (classify_unsafe_function, classify_packaged_name)
9176         (classify_name, yylex): Update.
9177
9178 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9179
9180         * configure.ac: add --enable-source-highlight switch.
9181         * configure: Regenerate.
9182         * top.c (print_gdb_version): plumb --enable-source-highlight
9183         status to "show configuration".
9184
9185 2019-04-19  Tom Tromey  <tromey@adacore.com>
9186
9187         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9188         Check ADA_TYPE_P.
9189         (empty_record, ada_template_to_fixed_record_type_1)
9190         (template_to_static_fixed_type)
9191         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9192         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9193         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9194         macros.
9195
9196 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9197
9198         PR symtab/24423:
9199         * source.c (print_source_lines_base): Advance "iter" when a
9200         control character is seen.
9201
9202 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9203
9204         * inferior.h (struct infcall_suspend_state_deleter):
9205         Catch exception in destructor to avoid crash.
9206
9207 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9208
9209         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9210         close to the add_com "shell".
9211
9212 2019-04-18  Tom Tromey  <tromey@adacore.com>
9213
9214         * process-stratum-target.h (class process_stratum_target)
9215         <stratum>: Add "final".
9216
9217 2019-04-17  Tom Tromey  <tromey@adacore.com>
9218
9219         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9220         against nullptr before use.
9221
9222 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9223
9224         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9225
9226 2019-04-17  Jim Wilson  <jimw@sifive.com>
9227             Andrew Burgess  <andrew.burgess@embecosm.com>
9228
9229         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9230         code read might fail, assume 4-byte breakpoint in that case.
9231
9232 2019-04-15  Leszek Swirski  <leszeks@google.com>
9233
9234         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9235         rather than a hand-rolled POD check when checking for forced MEMORY
9236         classification.
9237
9238 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9239
9240         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9241         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9242         function.
9243         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9244         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9245         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9246         declaration.
9247
9248 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9249
9250         * aarch64-linux-nat.c
9251         (aarch64_linux_nat_target::thread_architecture): Add override.
9252         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9253         each VQ.
9254
9255 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9256
9257         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9258
9259 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9262         target types of size 96-bits, add some additional comments, and
9263         check that the builtin type we found was the correct size.
9264
9265 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9266
9267         * utils.c (prompt_for_continue): Don't restore the styling at the
9268         end, as applied_style has the wrong value.  This fixes styling in
9269         long lists of file names that are interrupted by the "Continue?"
9270         prompt.
9271
9272 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9273
9274         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9275         * c-lang.c (c_language_defn): Likewise.
9276         (cplus_language_defn): Likewise.
9277         (asm_language_defn): Likewise.
9278         (minimal_language_defn): Likewise.
9279         * d-lang.c (d_language_defn): Likewise.
9280         * f-lang.c (f_language_defn): Likewise.
9281         * go-lang.c (go_language_defn): Likewise.
9282         * language.c (unknown_language_defn): Likewise.
9283         (auto_language_defn): Likewise.
9284         * language.h (struct language_defn): Remove la_magic field.
9285         (LANG_MAGIC): Delete.
9286         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9287         * objc-lang.c (objc_language_defn): Likewise.
9288         * opencl-lang.c (opencl_language_defn): Likewise.
9289         * p-lang.c (pascal_language_defn): Likewise.
9290         * rust-lang.c (rust_language_defn): Likewise.
9291
9292 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9293
9294         * riscv-tdep.c (riscv_type_align): New function.
9295         (riscv_type_alignment): Delete.
9296         (riscv_arg_location): Use 'type_align'.
9297         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9298
9299 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * gdbtypes.c (type_align): A struct with no non-static fields also
9302         has alignment of 1.
9303
9304 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9307         component to 0.
9308         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9309         member.
9310         (riscv_struct_info::analyse): New implementation using new
9311         analyse_inner member function.
9312         (riscv_struct_info::field_offset): New member function.
9313         (riscv_struct_info::m_offsets): New member variable.
9314         (riscv_struct_info::analyse_inner): New private member function,
9315         takes the old implementation of riscv_struct_info::analyse but
9316         extended to track field offsets.
9317         (riscv_call_arg_struct): Update the struct folding special cases
9318         to handle cases where empty C++ structs, which are non-zero
9319         length, are found.
9320         (riscv_arg_location): Initialise the length of each location, a
9321         non-zero length now indicates the location is in use.
9322         (riscv_push_dummy_call): Allow for the first location having a
9323         non-zero offset when setting up arguments.
9324         (riscv_return_value): Likewise, but for return values.
9325
9326 2019-04-11  Tom Tromey  <tromey@adacore.com>
9327
9328         * utils.c (internal_vproblem): Make "msg" const.
9329
9330 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9331
9332         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9333         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9334         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9335         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9336
9337 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9338
9339         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9340         function.
9341         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9342         of amd64_collect_native_gregset.
9343         (amd64_linux_nat_target::store_registers): Likewise.
9344
9345 2019-04-10  Tom Tromey  <tom@tromey.com>
9346
9347         * symtab.c (lookup_global_symbol_from_objfile)
9348         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9349         * objfiles.h (class separate_debug_iterator): New.
9350         (class separate_debug_range): New.
9351         (struct objfile) <separate_debug_objfiles>: New method.
9352         (objfile_separate_debug_iterate): Don't declare.
9353         * objfiles.c (separate_debug_iterator::operator++): Rename from
9354         objfile_separate_debug_iterate.
9355         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9356         iterator.
9357         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9358         iterator.
9359
9360 2019-04-10  Tom Tromey  <tom@tromey.com>
9361
9362         * symfile.c (reread_symbols): Remove old comment.
9363         * objfiles.c (free_all_objfiles): Fix a typo.
9364
9365 2019-04-10  Tom Tromey  <tom@tromey.com>
9366
9367         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9368         * minsyms.c (lookup_minimal_symbol): Use foreach.
9369         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9370         (lookup_minimal_symbol_solib_trampoline): Likewise.
9371         * symfile.c (reread_symbols): Use foreach.
9372
9373 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9374             Tom Tromey  <tromey@adacore.com>
9375
9376         PR rust/24414:
9377         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9378         (rust_lex_int_test): Change "value" to be LONGEST.
9379         (rust_lex_tests): Add test for long integer literal.
9380
9381 2019-04-09  Tom Tromey  <tromey@adacore.com>
9382
9383         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9384         to bool.
9385         (extended_remote_target::attach): Update.
9386         (remote_target::remote_notice_new_inferior): Update.
9387         (remote_target::add_current_inferior_and_thread): Update.
9388         * inferior.c (exit_inferior_1): Use "false".
9389         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9390
9391 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9392
9393         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9394         the "start" command.
9395
9396 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9397
9398         * python/py-inferior.c (infpy_thread_from_thread_handle):
9399         Adjust comments to reflect renaming of thread_from_thread_handle
9400         to thread_from_handle.  Adjust keywords.  Fix type error message.
9401         (inferior_object_methods): Add thread_from_handle.  Retain
9402         thread_from_thread_handle, but mark it as deprecated.
9403
9404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9405
9406         * gdbthread.h (find_thread_by_handle): Revise declaration.
9407         * thread.c (find_thread_by_handle): Likewise.  Adjust
9408         implementation too.
9409         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9410         support for buffer objects as handles.
9411
9412 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9413
9414         * python/py-infthread.c (thpy_thread_handle): New function.
9415         (thread_object_methods): Register thpy_thread_handle.
9416
9417 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9418
9419         * gdbthread.h (thread_to_thread_handle): Declare.
9420         * thread.c (gdbtypes.h): Include.
9421         (thread_to_thread_handle): New function.
9422
9423         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9424         (target_thread_info_to_thread_handle): Declare.
9425         * target.c (target_thread_info_to_thread_handle): New function.
9426         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9427         * target-delegates.c: Regenerate.
9428
9429         * linux-thread-db.c (class thread_db_target): Add method
9430         thread_info_to_thread_handle.
9431         (thread_db_target::thread_info_to_thread_handle): Define.
9432         * remote.c (class remote_target): Add new method
9433         thread_info_to_thread_handle.
9434         (remote_target::thread_info_to_thread_handle): Define.
9435
9436 2019-04-08  Pedro Alves  <palves@redhat.com>
9437
9438         * common/common-exceptions.c (throw_exception): Don't create
9439         named object to throw; throw directly.
9440         (throw_it): Likewise.  Don't initialize gdb_exception::message
9441         here, with new; pass FMT and AP to the ctor instead.
9442         * common/common-exceptions.h: Include <string>.
9443         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9444         const char *, va_list)): New ctor.  Use std::make_shared.
9445         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9446         errors)): Delete.
9447         (gdb_exception_error::gdb_exception_error(enum errors, const char
9448         *, va_list)): New.
9449         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9450         Add assertion.
9451         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9452         errors)): Delete.
9453         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9454         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9455         Add assertion.
9456
9457 2019-04-08  Tom Tromey  <tom@tromey.com>
9458
9459         * valops.c (value_rtti_indirect_type): Replace throw_exception
9460         with throw.
9461         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9462         with throw.
9463         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9464         throw.
9465         * target.c (target_translate_tls_address): Replace throw_exception
9466         with throw.
9467         * stack.c (frame_apply_command_count): Replace throw_exception
9468         with throw.
9469         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9470         throw.
9471         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9472         with throw.
9473         * rs6000-tdep.c (rs6000_frame_cache)
9474         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9475         * remote.c: Replace throw_exception with throw.
9476         * record-full.c (record_full_message, record_full_wait_1)
9477         (record_full_restore): Replace throw_exception with throw.
9478         * record-btrace.c:
9479         (get_thread_current_frame_id, record_btrace_start_replaying)
9480         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9481         (cmd_record_btrace_start): Replace throw_exception with throw.
9482         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9483         throw.
9484         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9485         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9486         * linespec.c:
9487         (find_linespec_symbols): Replace throw_exception with throw.
9488         * infrun.c (displaced_step_prepare, resume): Replace
9489         throw_exception with throw.
9490         * infcmd.c (post_create_inferior): Replace throw_exception with
9491         throw.
9492         * inf-loop.c (inferior_event_handler): Replace throw_exception
9493         with throw.
9494         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9495         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9496         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9497         (get_prev_frame_always, get_frame_pc_if_available)
9498         (get_frame_address_in_block_if_available, get_frame_language):
9499         Replace throw_exception with throw.
9500         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9501         throw_exception with throw.
9502         * eval.c (fetch_subexp_value, evaluate_var_value)
9503         (evaluate_funcall, evaluate_subexp_standard): Replace
9504         throw_exception with throw.
9505         * dwarf2loc.c (call_site_find_chain)
9506         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9507         Replace throw_exception with throw.
9508         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9509         with throw.
9510         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9511         throw.
9512         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9513         * completer.c (complete_line_internal): Replace throw_exception
9514         with throw.
9515         * compile/compile-object-run.c (compile_object_run): Replace
9516         throw_exception with throw.
9517         * cli/cli-script.c (process_next_line): Replace throw_exception
9518         with throw.
9519         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9520         (btrace_enable, btrace_maint_update_pt_packets): Replace
9521         throw_exception with throw.
9522         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9523         throw_exception with throw.
9524         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9525         throw_exception with throw.
9526         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9527         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9528         * aarch64-tdep.c (aarch64_make_prologue_cache)
9529         (aarch64_make_stub_cache): Replace throw_exception with throw.
9530
9531 2019-04-08  Tom Tromey  <tom@tromey.com>
9532
9533         * common/common-exceptions.c (throw_exception): Rename from
9534         throw_exception_cxx.  Remove old copy.  Make argument const.
9535         (throw_it): Create and throw exception objects directly.
9536         * common/common-exceptions.h (throw_exception): Make argument
9537         const.
9538         (struct gdb_exception_error): Add constructor.
9539         (struct gdb_exception_quit): Add constructor.
9540
9541 2019-04-08  Tom Tromey  <tom@tromey.com>
9542
9543         * common/common-exceptions.h (exception_rethrow): Don't declare.
9544         (TRY_SJLJ): Update comment.
9545         (TRY, CATCH, END_CATCH): Remove.
9546         * common/common-exceptions.c (exception_rethrow): Remove.
9547
9548 2019-04-08  Tom Tromey  <tom@tromey.com>
9549
9550         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9551         Remove.
9552         (gdb_exception_error): Rename from
9553         gdb_exception_RETURN_MASK_ERROR.
9554         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9555         (gdb_quit_bad_alloc): Update.
9556         * aarch64-tdep.c: Update.
9557         * ada-lang.c: Update.
9558         * ada-typeprint.c: Update.
9559         * ada-valprint.c: Update.
9560         * amd64-tdep.c: Update.
9561         * arch-utils.c: Update.
9562         * break-catch-throw.c: Update.
9563         * breakpoint.c: Update.
9564         * btrace.c: Update.
9565         * c-varobj.c: Update.
9566         * cli/cli-cmds.c: Update.
9567         * cli/cli-interp.c: Update.
9568         * cli/cli-script.c: Update.
9569         * common/common-exceptions.c: Update.
9570         * common/new-op.c: Update.
9571         * common/selftest.c: Update.
9572         * compile/compile-c-symbols.c: Update.
9573         * compile/compile-cplus-symbols.c: Update.
9574         * compile/compile-object-load.c: Update.
9575         * compile/compile-object-run.c: Update.
9576         * completer.c: Update.
9577         * corelow.c: Update.
9578         * cp-abi.c: Update.
9579         * cp-support.c: Update.
9580         * cp-valprint.c: Update.
9581         * darwin-nat.c: Update.
9582         * disasm-selftests.c: Update.
9583         * dtrace-probe.c: Update.
9584         * dwarf-index-cache.c: Update.
9585         * dwarf-index-write.c: Update.
9586         * dwarf2-frame-tailcall.c: Update.
9587         * dwarf2-frame.c: Update.
9588         * dwarf2loc.c: Update.
9589         * dwarf2read.c: Update.
9590         * eval.c: Update.
9591         * event-loop.c: Update.
9592         * event-top.c: Update.
9593         * exec.c: Update.
9594         * f-valprint.c: Update.
9595         * fbsd-tdep.c: Update.
9596         * frame-unwind.c: Update.
9597         * frame.c: Update.
9598         * gdbtypes.c: Update.
9599         * gnu-v3-abi.c: Update.
9600         * guile/guile-internal.h: Update.
9601         * guile/scm-block.c: Update.
9602         * guile/scm-breakpoint.c: Update.
9603         * guile/scm-cmd.c: Update.
9604         * guile/scm-disasm.c: Update.
9605         * guile/scm-frame.c: Update.
9606         * guile/scm-lazy-string.c: Update.
9607         * guile/scm-math.c: Update.
9608         * guile/scm-param.c: Update.
9609         * guile/scm-ports.c: Update.
9610         * guile/scm-pretty-print.c: Update.
9611         * guile/scm-symbol.c: Update.
9612         * guile/scm-symtab.c: Update.
9613         * guile/scm-type.c: Update.
9614         * guile/scm-value.c: Update.
9615         * i386-linux-tdep.c: Update.
9616         * i386-tdep.c: Update.
9617         * inf-loop.c: Update.
9618         * infcall.c: Update.
9619         * infcmd.c: Update.
9620         * infrun.c: Update.
9621         * jit.c: Update.
9622         * language.c: Update.
9623         * linespec.c: Update.
9624         * linux-fork.c: Update.
9625         * linux-nat.c: Update.
9626         * linux-tdep.c: Update.
9627         * linux-thread-db.c: Update.
9628         * main.c: Update.
9629         * mi/mi-cmd-break.c: Update.
9630         * mi/mi-cmd-stack.c: Update.
9631         * mi/mi-interp.c: Update.
9632         * mi/mi-main.c: Update.
9633         * objc-lang.c: Update.
9634         * p-valprint.c: Update.
9635         * parse.c: Update.
9636         * ppc-linux-tdep.c: Update.
9637         * printcmd.c: Update.
9638         * python/py-arch.c: Update.
9639         * python/py-breakpoint.c: Update.
9640         * python/py-cmd.c: Update.
9641         * python/py-finishbreakpoint.c: Update.
9642         * python/py-frame.c: Update.
9643         * python/py-framefilter.c: Update.
9644         * python/py-gdb-readline.c: Update.
9645         * python/py-inferior.c: Update.
9646         * python/py-infthread.c: Update.
9647         * python/py-lazy-string.c: Update.
9648         * python/py-linetable.c: Update.
9649         * python/py-objfile.c: Update.
9650         * python/py-param.c: Update.
9651         * python/py-prettyprint.c: Update.
9652         * python/py-progspace.c: Update.
9653         * python/py-record-btrace.c: Update.
9654         * python/py-record.c: Update.
9655         * python/py-symbol.c: Update.
9656         * python/py-type.c: Update.
9657         * python/py-unwind.c: Update.
9658         * python/py-utils.c: Update.
9659         * python/py-value.c: Update.
9660         * python/python.c: Update.
9661         * record-btrace.c: Update.
9662         * record-full.c: Update.
9663         * remote-fileio.c: Update.
9664         * remote.c: Update.
9665         * riscv-tdep.c: Update.
9666         * rs6000-aix-tdep.c: Update.
9667         * rs6000-tdep.c: Update.
9668         * rust-exp.y: Update.
9669         * rust-lang.c: Update.
9670         * s390-tdep.c: Update.
9671         * selftest-arch.c: Update.
9672         * solib-dsbt.c: Update.
9673         * solib-frv.c: Update.
9674         * solib-spu.c: Update.
9675         * solib-svr4.c: Update.
9676         * solib.c: Update.
9677         * sparc64-linux-tdep.c: Update.
9678         * stack.c: Update.
9679         * symfile-mem.c: Update.
9680         * symmisc.c: Update.
9681         * target.c: Update.
9682         * thread.c: Update.
9683         * top.c: Update.
9684         * tracefile-tfile.c: Update.
9685         * tui/tui.c: Update.
9686         * typeprint.c: Update.
9687         * unittests/cli-utils-selftests.c: Update.
9688         * unittests/parse-connection-spec-selftests.c: Update.
9689         * valops.c: Update.
9690         * valprint.c: Update.
9691         * value.c: Update.
9692         * varobj.c: Update.
9693         * windows-nat.c: Update.
9694         * x86-linux-nat.c: Update.
9695         * xml-support.c: Update.
9696
9697 2019-04-08  Tom Tromey  <tom@tromey.com>
9698
9699         * xml-support.c: Use C++ exception handling.
9700         * x86-linux-nat.c: Use C++ exception handling.
9701         * windows-nat.c: Use C++ exception handling.
9702         * varobj.c: Use C++ exception handling.
9703         * value.c: Use C++ exception handling.
9704         * valprint.c: Use C++ exception handling.
9705         * valops.c: Use C++ exception handling.
9706         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9707         handling.
9708         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9709         * typeprint.c: Use C++ exception handling.
9710         * tui/tui.c: Use C++ exception handling.
9711         * tracefile-tfile.c: Use C++ exception handling.
9712         * top.c: Use C++ exception handling.
9713         * thread.c: Use C++ exception handling.
9714         * target.c: Use C++ exception handling.
9715         * symmisc.c: Use C++ exception handling.
9716         * symfile-mem.c: Use C++ exception handling.
9717         * stack.c: Use C++ exception handling.
9718         * sparc64-linux-tdep.c: Use C++ exception handling.
9719         * solib.c: Use C++ exception handling.
9720         * solib-svr4.c: Use C++ exception handling.
9721         * solib-spu.c: Use C++ exception handling.
9722         * solib-frv.c: Use C++ exception handling.
9723         * solib-dsbt.c: Use C++ exception handling.
9724         * selftest-arch.c: Use C++ exception handling.
9725         * s390-tdep.c: Use C++ exception handling.
9726         * rust-lang.c: Use C++ exception handling.
9727         * rust-exp.y: Use C++ exception handling.
9728         * rs6000-tdep.c: Use C++ exception handling.
9729         * rs6000-aix-tdep.c: Use C++ exception handling.
9730         * riscv-tdep.c: Use C++ exception handling.
9731         * remote.c: Use C++ exception handling.
9732         * remote-fileio.c: Use C++ exception handling.
9733         * record-full.c: Use C++ exception handling.
9734         * record-btrace.c: Use C++ exception handling.
9735         * python/python.c: Use C++ exception handling.
9736         * python/py-value.c: Use C++ exception handling.
9737         * python/py-utils.c: Use C++ exception handling.
9738         * python/py-unwind.c: Use C++ exception handling.
9739         * python/py-type.c: Use C++ exception handling.
9740         * python/py-symbol.c: Use C++ exception handling.
9741         * python/py-record.c: Use C++ exception handling.
9742         * python/py-record-btrace.c: Use C++ exception handling.
9743         * python/py-progspace.c: Use C++ exception handling.
9744         * python/py-prettyprint.c: Use C++ exception handling.
9745         * python/py-param.c: Use C++ exception handling.
9746         * python/py-objfile.c: Use C++ exception handling.
9747         * python/py-linetable.c: Use C++ exception handling.
9748         * python/py-lazy-string.c: Use C++ exception handling.
9749         * python/py-infthread.c: Use C++ exception handling.
9750         * python/py-inferior.c: Use C++ exception handling.
9751         * python/py-gdb-readline.c: Use C++ exception handling.
9752         * python/py-framefilter.c: Use C++ exception handling.
9753         * python/py-frame.c: Use C++ exception handling.
9754         * python/py-finishbreakpoint.c: Use C++ exception handling.
9755         * python/py-cmd.c: Use C++ exception handling.
9756         * python/py-breakpoint.c: Use C++ exception handling.
9757         * python/py-arch.c: Use C++ exception handling.
9758         * printcmd.c: Use C++ exception handling.
9759         * ppc-linux-tdep.c: Use C++ exception handling.
9760         * parse.c: Use C++ exception handling.
9761         * p-valprint.c: Use C++ exception handling.
9762         * objc-lang.c: Use C++ exception handling.
9763         * mi/mi-main.c: Use C++ exception handling.
9764         * mi/mi-interp.c: Use C++ exception handling.
9765         * mi/mi-cmd-stack.c: Use C++ exception handling.
9766         * mi/mi-cmd-break.c: Use C++ exception handling.
9767         * main.c: Use C++ exception handling.
9768         * linux-thread-db.c: Use C++ exception handling.
9769         * linux-tdep.c: Use C++ exception handling.
9770         * linux-nat.c: Use C++ exception handling.
9771         * linux-fork.c: Use C++ exception handling.
9772         * linespec.c: Use C++ exception handling.
9773         * language.c: Use C++ exception handling.
9774         * jit.c: Use C++ exception handling.
9775         * infrun.c: Use C++ exception handling.
9776         * infcmd.c: Use C++ exception handling.
9777         * infcall.c: Use C++ exception handling.
9778         * inf-loop.c: Use C++ exception handling.
9779         * i386-tdep.c: Use C++ exception handling.
9780         * i386-linux-tdep.c: Use C++ exception handling.
9781         * guile/scm-value.c: Use C++ exception handling.
9782         * guile/scm-type.c: Use C++ exception handling.
9783         * guile/scm-symtab.c: Use C++ exception handling.
9784         * guile/scm-symbol.c: Use C++ exception handling.
9785         * guile/scm-pretty-print.c: Use C++ exception handling.
9786         * guile/scm-ports.c: Use C++ exception handling.
9787         * guile/scm-param.c: Use C++ exception handling.
9788         * guile/scm-math.c: Use C++ exception handling.
9789         * guile/scm-lazy-string.c: Use C++ exception handling.
9790         * guile/scm-frame.c: Use C++ exception handling.
9791         * guile/scm-disasm.c: Use C++ exception handling.
9792         * guile/scm-cmd.c: Use C++ exception handling.
9793         * guile/scm-breakpoint.c: Use C++ exception handling.
9794         * guile/scm-block.c: Use C++ exception handling.
9795         * guile/guile-internal.h: Use C++ exception handling.
9796         * gnu-v3-abi.c: Use C++ exception handling.
9797         * gdbtypes.c: Use C++ exception handling.
9798         * frame.c: Use C++ exception handling.
9799         * frame-unwind.c: Use C++ exception handling.
9800         * fbsd-tdep.c: Use C++ exception handling.
9801         * f-valprint.c: Use C++ exception handling.
9802         * exec.c: Use C++ exception handling.
9803         * event-top.c: Use C++ exception handling.
9804         * event-loop.c: Use C++ exception handling.
9805         * eval.c: Use C++ exception handling.
9806         * dwarf2read.c: Use C++ exception handling.
9807         * dwarf2loc.c: Use C++ exception handling.
9808         * dwarf2-frame.c: Use C++ exception handling.
9809         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9810         * dwarf-index-write.c: Use C++ exception handling.
9811         * dwarf-index-cache.c: Use C++ exception handling.
9812         * dtrace-probe.c: Use C++ exception handling.
9813         * disasm-selftests.c: Use C++ exception handling.
9814         * darwin-nat.c: Use C++ exception handling.
9815         * cp-valprint.c: Use C++ exception handling.
9816         * cp-support.c: Use C++ exception handling.
9817         * cp-abi.c: Use C++ exception handling.
9818         * corelow.c: Use C++ exception handling.
9819         * completer.c: Use C++ exception handling.
9820         * compile/compile-object-run.c: Use C++ exception handling.
9821         * compile/compile-object-load.c: Use C++ exception handling.
9822         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9823         * compile/compile-c-symbols.c: Use C++ exception handling.
9824         * common/selftest.c: Use C++ exception handling.
9825         * common/new-op.c: Use C++ exception handling.
9826         * cli/cli-script.c: Use C++ exception handling.
9827         * cli/cli-interp.c: Use C++ exception handling.
9828         * cli/cli-cmds.c: Use C++ exception handling.
9829         * c-varobj.c: Use C++ exception handling.
9830         * btrace.c: Use C++ exception handling.
9831         * breakpoint.c: Use C++ exception handling.
9832         * break-catch-throw.c: Use C++ exception handling.
9833         * arch-utils.c: Use C++ exception handling.
9834         * amd64-tdep.c: Use C++ exception handling.
9835         * ada-valprint.c: Use C++ exception handling.
9836         * ada-typeprint.c: Use C++ exception handling.
9837         * ada-lang.c: Use C++ exception handling.
9838         * aarch64-tdep.c: Use C++ exception handling.
9839
9840 2019-04-08  Tom Tromey  <tom@tromey.com>
9841
9842         * xml-support.c (gdb_xml_parser::parse): Update.
9843         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9844         * value.c (show_convenience): Update.
9845         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9846         (test_parse_flags_qcs): Update.
9847         * thread.c (thr_try_catch_cmd): Update.
9848         * target.c (target_translate_tls_address): Update.
9849         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9850         (info_frame_command_core, frame_apply_command_count): Update.
9851         * rust-exp.y (rust_lex_exception_test): Update.
9852         * riscv-tdep.c (riscv_print_one_register_info): Update.
9853         * remote.c (remote_target::enable_btrace): Update.
9854         * record-btrace.c (record_btrace_enable_warn): Update.
9855         * python/py-utils.c (gdbpy_convert_exception): Update.
9856         * printcmd.c (do_one_display, print_variable_and_value): Update.
9857         * mi/mi-main.c (mi_print_exception): Update.
9858         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9859         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9860         * linux-nat.c (linux_nat_target::attach): Update.
9861         * linux-fork.c (class scoped_switch_fork_info): Update.
9862         * infrun.c (displaced_step_prepare): Update.
9863         * infcall.c (call_function_by_hand_dummy): Update.
9864         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9865         * gnu-v3-abi.c (print_one_vtable): Update.
9866         * frame.c (get_prev_frame_always): Update.
9867         * f-valprint.c (info_common_command_for_block): Update.
9868         * exec.c (try_open_exec_file): Update.
9869         * exceptions.c (print_exception, exception_print)
9870         (exception_fprintf, exception_print_same): Update.
9871         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9872         * dwarf-index-cache.c (index_cache::store)
9873         (index_cache::lookup_gdb_index): Update.
9874         * darwin-nat.c (maybe_cache_shell): Update.
9875         * cp-valprint.c (cp_print_value_fields): Update.
9876         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9877         (gcc_cplus_symbol_address): Update.
9878         * compile/compile-c-symbols.c (gcc_convert_symbol)
9879         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9880         * common/selftest.c: Update.
9881         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9882         a std::string.
9883         (exception_try_scope_entry, exception_try_scope_exit): Don't
9884         declare.
9885         (struct exception_try_scope): Remove.
9886         (TRY): Don't use exception_try_scope.
9887         (struct gdb_exception): Add constructor, operator=.
9888         <what>: New method.
9889         (struct gdb_exception_RETURN_MASK_ALL)
9890         (struct gdb_exception_RETURN_MASK_ERROR)
9891         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9892         (struct gdb_quit_bad_alloc): Update.
9893         * common/common-exceptions.c (exception_none): Change
9894         initializer.
9895         (struct catcher) <state, exception>: Initialize inline.
9896         <prev>: Remove member.
9897         (current_catcher): Remove.
9898         (catchers): New global.
9899         (exceptions_state_mc_init): Simplify.
9900         (catcher_pop): Remove.
9901         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9902         (try_scope_depth, exception_try_scope_entry)
9903         (exception_try_scope_exit): Remove.
9904         (throw_exception_sjlj): Update.
9905         (exception_messages, exception_messages_size): Remove.
9906         (throw_it): Simplify.
9907         (gdb_exception_sliced_copy): Remove.
9908         (throw_exception_cxx): Update.
9909         * cli/cli-script.c (script_from_file): Update.
9910         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9911         Update.
9912         * ada-valprint.c (ada_val_print): Update.
9913         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9914         (create_excep_cond_exprs): Update.
9915
9916 2019-04-08  Tom Tromey  <tom@tromey.com>
9917
9918         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9919         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9920         (TRY, CATCH, END_CATCH): Remove some definitions.
9921         * common/common-exceptions.c: Don't use GDB_XCPT.
9922         (catcher_list_size): Remove.
9923         (throw_exception, throw_it): Simplify.
9924
9925 2019-04-05  Tom Tromey  <tom@tromey.com>
9926
9927         Revert the header-sorting patch.
9928         * ft32-tdep.c: Revert.
9929         * frv-tdep.c: Revert.
9930         * frv-linux-tdep.c: Revert.
9931         * frame.c: Revert.
9932         * frame-unwind.c: Revert.
9933         * frame-base.c: Revert.
9934         * fork-child.c: Revert.
9935         * findvar.c: Revert.
9936         * findcmd.c: Revert.
9937         * filesystem.c: Revert.
9938         * filename-seen-cache.h: Revert.
9939         * filename-seen-cache.c: Revert.
9940         * fbsd-tdep.c: Revert.
9941         * fbsd-nat.h: Revert.
9942         * fbsd-nat.c: Revert.
9943         * f-valprint.c: Revert.
9944         * f-typeprint.c: Revert.
9945         * f-lang.c: Revert.
9946         * extension.h: Revert.
9947         * extension.c: Revert.
9948         * extension-priv.h: Revert.
9949         * expprint.c: Revert.
9950         * exec.h: Revert.
9951         * exec.c: Revert.
9952         * exceptions.c: Revert.
9953         * event-top.c: Revert.
9954         * event-loop.c: Revert.
9955         * eval.c: Revert.
9956         * elfread.c: Revert.
9957         * dwarf2read.h: Revert.
9958         * dwarf2read.c: Revert.
9959         * dwarf2loc.c: Revert.
9960         * dwarf2expr.h: Revert.
9961         * dwarf2expr.c: Revert.
9962         * dwarf2-frame.c: Revert.
9963         * dwarf2-frame-tailcall.c: Revert.
9964         * dwarf-index-write.h: Revert.
9965         * dwarf-index-write.c: Revert.
9966         * dwarf-index-common.c: Revert.
9967         * dwarf-index-cache.h: Revert.
9968         * dwarf-index-cache.c: Revert.
9969         * dummy-frame.c: Revert.
9970         * dtrace-probe.c: Revert.
9971         * disasm.h: Revert.
9972         * disasm.c: Revert.
9973         * disasm-selftests.c: Revert.
9974         * dictionary.c: Revert.
9975         * dicos-tdep.c: Revert.
9976         * demangle.c: Revert.
9977         * dcache.h: Revert.
9978         * dcache.c: Revert.
9979         * darwin-nat.h: Revert.
9980         * darwin-nat.c: Revert.
9981         * darwin-nat-info.c: Revert.
9982         * d-valprint.c: Revert.
9983         * d-namespace.c: Revert.
9984         * d-lang.c: Revert.
9985         * ctf.c: Revert.
9986         * csky-tdep.c: Revert.
9987         * csky-linux-tdep.c: Revert.
9988         * cris-tdep.c: Revert.
9989         * cris-linux-tdep.c: Revert.
9990         * cp-valprint.c: Revert.
9991         * cp-support.c: Revert.
9992         * cp-namespace.c: Revert.
9993         * cp-abi.c: Revert.
9994         * corelow.c: Revert.
9995         * corefile.c: Revert.
9996         * continuations.c: Revert.
9997         * completer.h: Revert.
9998         * completer.c: Revert.
9999         * complaints.c: Revert.
10000         * coffread.c: Revert.
10001         * coff-pe-read.c: Revert.
10002         * cli-out.h: Revert.
10003         * cli-out.c: Revert.
10004         * charset.c: Revert.
10005         * c-varobj.c: Revert.
10006         * c-valprint.c: Revert.
10007         * c-typeprint.c: Revert.
10008         * c-lang.c: Revert.
10009         * buildsym.c: Revert.
10010         * buildsym-legacy.c: Revert.
10011         * build-id.h: Revert.
10012         * build-id.c: Revert.
10013         * btrace.c: Revert.
10014         * bsd-uthread.c: Revert.
10015         * breakpoint.h: Revert.
10016         * breakpoint.c: Revert.
10017         * break-catch-throw.c: Revert.
10018         * break-catch-syscall.c: Revert.
10019         * break-catch-sig.c: Revert.
10020         * blockframe.c: Revert.
10021         * block.c: Revert.
10022         * bfin-tdep.c: Revert.
10023         * bfin-linux-tdep.c: Revert.
10024         * bfd-target.c: Revert.
10025         * bcache.c: Revert.
10026         * ax-general.c: Revert.
10027         * ax-gdb.h: Revert.
10028         * ax-gdb.c: Revert.
10029         * avr-tdep.c: Revert.
10030         * auxv.c: Revert.
10031         * auto-load.c: Revert.
10032         * arm-wince-tdep.c: Revert.
10033         * arm-tdep.c: Revert.
10034         * arm-symbian-tdep.c: Revert.
10035         * arm-pikeos-tdep.c: Revert.
10036         * arm-obsd-tdep.c: Revert.
10037         * arm-nbsd-tdep.c: Revert.
10038         * arm-nbsd-nat.c: Revert.
10039         * arm-linux-tdep.c: Revert.
10040         * arm-linux-nat.c: Revert.
10041         * arm-fbsd-tdep.c: Revert.
10042         * arm-fbsd-nat.c: Revert.
10043         * arm-bsd-tdep.c: Revert.
10044         * arch-utils.c: Revert.
10045         * arc-tdep.c: Revert.
10046         * arc-newlib-tdep.c: Revert.
10047         * annotate.h: Revert.
10048         * annotate.c: Revert.
10049         * amd64-windows-tdep.c: Revert.
10050         * amd64-windows-nat.c: Revert.
10051         * amd64-tdep.c: Revert.
10052         * amd64-sol2-tdep.c: Revert.
10053         * amd64-obsd-tdep.c: Revert.
10054         * amd64-obsd-nat.c: Revert.
10055         * amd64-nbsd-tdep.c: Revert.
10056         * amd64-nbsd-nat.c: Revert.
10057         * amd64-nat.c: Revert.
10058         * amd64-linux-tdep.c: Revert.
10059         * amd64-linux-nat.c: Revert.
10060         * amd64-fbsd-tdep.c: Revert.
10061         * amd64-fbsd-nat.c: Revert.
10062         * amd64-dicos-tdep.c: Revert.
10063         * amd64-darwin-tdep.c: Revert.
10064         * amd64-bsd-nat.c: Revert.
10065         * alpha-tdep.c: Revert.
10066         * alpha-obsd-tdep.c: Revert.
10067         * alpha-nbsd-tdep.c: Revert.
10068         * alpha-mdebug-tdep.c: Revert.
10069         * alpha-linux-tdep.c: Revert.
10070         * alpha-linux-nat.c: Revert.
10071         * alpha-bsd-tdep.c: Revert.
10072         * alpha-bsd-nat.c: Revert.
10073         * aix-thread.c: Revert.
10074         * agent.c: Revert.
10075         * addrmap.c: Revert.
10076         * ada-varobj.c: Revert.
10077         * ada-valprint.c: Revert.
10078         * ada-typeprint.c: Revert.
10079         * ada-tasks.c: Revert.
10080         * ada-lang.c: Revert.
10081         * aarch64-tdep.c: Revert.
10082         * aarch64-ravenscar-thread.c: Revert.
10083         * aarch64-newlib-tdep.c: Revert.
10084         * aarch64-linux-tdep.c: Revert.
10085         * aarch64-linux-nat.c: Revert.
10086         * aarch64-fbsd-tdep.c: Revert.
10087         * aarch64-fbsd-nat.c: Revert.
10088         * aarch32-linux-nat.c: Revert.
10089
10090 2019-04-05  Tom Tromey  <tom@tromey.com>
10091
10092         * ft32-tdep.c: Sort headers.
10093         * frv-tdep.c: Sort headers.
10094         * frv-linux-tdep.c: Sort headers.
10095         * frame.c: Sort headers.
10096         * frame-unwind.c: Sort headers.
10097         * frame-base.c: Sort headers.
10098         * fork-child.c: Sort headers.
10099         * findvar.c: Sort headers.
10100         * findcmd.c: Sort headers.
10101         * filesystem.c: Sort headers.
10102         * filename-seen-cache.h: Sort headers.
10103         * filename-seen-cache.c: Sort headers.
10104         * fbsd-tdep.c: Sort headers.
10105         * fbsd-nat.h: Sort headers.
10106         * fbsd-nat.c: Sort headers.
10107         * f-valprint.c: Sort headers.
10108         * f-typeprint.c: Sort headers.
10109         * f-lang.c: Sort headers.
10110         * extension.h: Sort headers.
10111         * extension.c: Sort headers.
10112         * extension-priv.h: Sort headers.
10113         * expprint.c: Sort headers.
10114         * exec.h: Sort headers.
10115         * exec.c: Sort headers.
10116         * exceptions.c: Sort headers.
10117         * event-top.c: Sort headers.
10118         * event-loop.c: Sort headers.
10119         * eval.c: Sort headers.
10120         * elfread.c: Sort headers.
10121         * dwarf2read.h: Sort headers.
10122         * dwarf2read.c: Sort headers.
10123         * dwarf2loc.c: Sort headers.
10124         * dwarf2expr.h: Sort headers.
10125         * dwarf2expr.c: Sort headers.
10126         * dwarf2-frame.c: Sort headers.
10127         * dwarf2-frame-tailcall.c: Sort headers.
10128         * dwarf-index-write.h: Sort headers.
10129         * dwarf-index-write.c: Sort headers.
10130         * dwarf-index-common.c: Sort headers.
10131         * dwarf-index-cache.h: Sort headers.
10132         * dwarf-index-cache.c: Sort headers.
10133         * dummy-frame.c: Sort headers.
10134         * dtrace-probe.c: Sort headers.
10135         * disasm.h: Sort headers.
10136         * disasm.c: Sort headers.
10137         * disasm-selftests.c: Sort headers.
10138         * dictionary.c: Sort headers.
10139         * dicos-tdep.c: Sort headers.
10140         * demangle.c: Sort headers.
10141         * dcache.h: Sort headers.
10142         * dcache.c: Sort headers.
10143         * darwin-nat.h: Sort headers.
10144         * darwin-nat.c: Sort headers.
10145         * darwin-nat-info.c: Sort headers.
10146         * d-valprint.c: Sort headers.
10147         * d-namespace.c: Sort headers.
10148         * d-lang.c: Sort headers.
10149         * ctf.c: Sort headers.
10150         * csky-tdep.c: Sort headers.
10151         * csky-linux-tdep.c: Sort headers.
10152         * cris-tdep.c: Sort headers.
10153         * cris-linux-tdep.c: Sort headers.
10154         * cp-valprint.c: Sort headers.
10155         * cp-support.c: Sort headers.
10156         * cp-namespace.c: Sort headers.
10157         * cp-abi.c: Sort headers.
10158         * corelow.c: Sort headers.
10159         * corefile.c: Sort headers.
10160         * continuations.c: Sort headers.
10161         * completer.h: Sort headers.
10162         * completer.c: Sort headers.
10163         * complaints.c: Sort headers.
10164         * coffread.c: Sort headers.
10165         * coff-pe-read.c: Sort headers.
10166         * cli-out.h: Sort headers.
10167         * cli-out.c: Sort headers.
10168         * charset.c: Sort headers.
10169         * c-varobj.c: Sort headers.
10170         * c-valprint.c: Sort headers.
10171         * c-typeprint.c: Sort headers.
10172         * c-lang.c: Sort headers.
10173         * buildsym.c: Sort headers.
10174         * buildsym-legacy.c: Sort headers.
10175         * build-id.h: Sort headers.
10176         * build-id.c: Sort headers.
10177         * btrace.c: Sort headers.
10178         * bsd-uthread.c: Sort headers.
10179         * breakpoint.h: Sort headers.
10180         * breakpoint.c: Sort headers.
10181         * break-catch-throw.c: Sort headers.
10182         * break-catch-syscall.c: Sort headers.
10183         * break-catch-sig.c: Sort headers.
10184         * blockframe.c: Sort headers.
10185         * block.c: Sort headers.
10186         * bfin-tdep.c: Sort headers.
10187         * bfin-linux-tdep.c: Sort headers.
10188         * bfd-target.c: Sort headers.
10189         * bcache.c: Sort headers.
10190         * ax-general.c: Sort headers.
10191         * ax-gdb.h: Sort headers.
10192         * ax-gdb.c: Sort headers.
10193         * avr-tdep.c: Sort headers.
10194         * auxv.c: Sort headers.
10195         * auto-load.c: Sort headers.
10196         * arm-wince-tdep.c: Sort headers.
10197         * arm-tdep.c: Sort headers.
10198         * arm-symbian-tdep.c: Sort headers.
10199         * arm-pikeos-tdep.c: Sort headers.
10200         * arm-obsd-tdep.c: Sort headers.
10201         * arm-nbsd-tdep.c: Sort headers.
10202         * arm-nbsd-nat.c: Sort headers.
10203         * arm-linux-tdep.c: Sort headers.
10204         * arm-linux-nat.c: Sort headers.
10205         * arm-fbsd-tdep.c: Sort headers.
10206         * arm-fbsd-nat.c: Sort headers.
10207         * arm-bsd-tdep.c: Sort headers.
10208         * arch-utils.c: Sort headers.
10209         * arc-tdep.c: Sort headers.
10210         * arc-newlib-tdep.c: Sort headers.
10211         * annotate.h: Sort headers.
10212         * annotate.c: Sort headers.
10213         * amd64-windows-tdep.c: Sort headers.
10214         * amd64-windows-nat.c: Sort headers.
10215         * amd64-tdep.c: Sort headers.
10216         * amd64-sol2-tdep.c: Sort headers.
10217         * amd64-obsd-tdep.c: Sort headers.
10218         * amd64-obsd-nat.c: Sort headers.
10219         * amd64-nbsd-tdep.c: Sort headers.
10220         * amd64-nbsd-nat.c: Sort headers.
10221         * amd64-nat.c: Sort headers.
10222         * amd64-linux-tdep.c: Sort headers.
10223         * amd64-linux-nat.c: Sort headers.
10224         * amd64-fbsd-tdep.c: Sort headers.
10225         * amd64-fbsd-nat.c: Sort headers.
10226         * amd64-dicos-tdep.c: Sort headers.
10227         * amd64-darwin-tdep.c: Sort headers.
10228         * amd64-bsd-nat.c: Sort headers.
10229         * alpha-tdep.c: Sort headers.
10230         * alpha-obsd-tdep.c: Sort headers.
10231         * alpha-nbsd-tdep.c: Sort headers.
10232         * alpha-mdebug-tdep.c: Sort headers.
10233         * alpha-linux-tdep.c: Sort headers.
10234         * alpha-linux-nat.c: Sort headers.
10235         * alpha-bsd-tdep.c: Sort headers.
10236         * alpha-bsd-nat.c: Sort headers.
10237         * aix-thread.c: Sort headers.
10238         * agent.c: Sort headers.
10239         * addrmap.c: Sort headers.
10240         * ada-varobj.c: Sort headers.
10241         * ada-valprint.c: Sort headers.
10242         * ada-typeprint.c: Sort headers.
10243         * ada-tasks.c: Sort headers.
10244         * ada-lang.c: Sort headers.
10245         * aarch64-tdep.c: Sort headers.
10246         * aarch64-ravenscar-thread.c: Sort headers.
10247         * aarch64-newlib-tdep.c: Sort headers.
10248         * aarch64-linux-tdep.c: Sort headers.
10249         * aarch64-linux-nat.c: Sort headers.
10250         * aarch64-fbsd-tdep.c: Sort headers.
10251         * aarch64-fbsd-nat.c: Sort headers.
10252         * aarch32-linux-nat.c: Sort headers.
10253
10254 2019-04-04  Tom Tromey  <tom@tromey.com>
10255
10256         * varobj.c (varobj_create): Update.
10257         * rust-exp.y (struct rust_parser) <update_innermost_block,
10258         lookup_symbol>: New methods.
10259         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10260         Rename.
10261         (rust_parser::rust_lookup_type)
10262         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10263         * printcmd.c (display_command, do_one_display): Update.
10264         * parser-defs.h (struct parser_state) <parser_state>: Add
10265         "tracker" parameter.
10266         (block_tracker): New member.
10267         (class innermost_block_tracker) <innermost_block_tracker>: Add
10268         "types" parameter.
10269         <reset>: Remove method.
10270         (innermost_block): Don't declare.
10271         (null_post_parser): Update.
10272         * parse.c (innermost_block): Remove global.
10273         (write_dollar_variable): Update.
10274         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10275         Remove "tracker_types" parameter.
10276         (parse_expression): Add "tracker" parameter.
10277         (parse_expression_for_completion): Update.
10278         (null_post_parser): Add "tracker" parameter.
10279         * p-exp.y: Update rules.
10280         * m2-exp.y: Update rules.
10281         * language.h (struct language_defn) <la_post_parser>: Add
10282         "tracker" parameter.
10283         * go-exp.y: Update rules.
10284         * f-exp.y: Update rules.
10285         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10286         parameter.
10287         * d-exp.y: Update rules.
10288         * c-exp.y: Update rules.
10289         * breakpoint.c (set_breakpoint_condition): Create an
10290         innermost_block_tracker.
10291         (watch_command_1): Likewise.
10292         * ada-lang.c (resolve): Add "tracker" parameter.
10293         (resolve_subexp): Likewise.
10294         * ada-exp.y (write_var_from_sym): Update.
10295
10296 2019-04-04  Tom Tromey  <tom@tromey.com>
10297
10298         * type-stack.h: New file.
10299         * type-stack.c: New file.
10300         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10301         type-stack.h.
10302         (insert_into_type_stack, insert_type, push_type, push_type_int)
10303         (insert_type_address_space, pop_type, pop_type_int)
10304         (pop_typelist, pop_type_stack, append_type_stack)
10305         (push_type_stack, get_type_stack, push_typelist)
10306         (follow_type_instance_flags, follow_types): Don't declare.
10307         * parse.c (type_stack): Remove global.
10308         (parse_exp_in_context): Update.
10309         (insert_into_type_stack, insert_type, push_type, push_type_int)
10310         (insert_type_address_space, pop_type, pop_type_int)
10311         (pop_typelist, pop_type_stack, append_type_stack)
10312         (push_type_stack, get_type_stack, push_typelist)
10313         (follow_type_instance_flags, follow_types): Remove (moved to
10314         type-stack.c).
10315         * f-exp.y (type_stack): New global.
10316         Update rules.
10317         (push_kind_type, f_parse): Update.
10318         * d-exp.y (type_stack): New global.
10319         Update rules.
10320         (d_parse): Update.
10321         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10322         Update rules.
10323         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10324         (HFILES_NO_SRCDIR): Add type-stack.h.
10325
10326 2019-04-04  Tom Tromey  <tom@tromey.com>
10327
10328         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10329         (rust_parser::convert_ast_to_expression, rust_parse)
10330         (rust_lex_test_completion, rust_lex_tests): Update.
10331         * parser-defs.h (struct expr_completion_state): New.
10332         (struct parser_state) <parser_state>: Add completion parameter.
10333         <mark_struct_expression, mark_completion_tag>: New methods.
10334         <parse_completion, m_completion_state>: New members.
10335         (prefixify_expression, null_post_parser): Update.
10336         (mark_struct_expression, mark_completion_tag): Don't declare.
10337         * parse.c (parse_completion, expout_last_struct)
10338         (expout_tag_completion_type, expout_completion_name): Remove
10339         globals.
10340         (parser_state::mark_struct_expression)
10341         (parser_state::mark_completion_tag): Now methods.
10342         (prefixify_expression): Add last_struct parameter.
10343         (prefixify_subexp): Likewise.
10344         (parse_exp_1): Update.
10345         (parse_exp_in_context): Add cstate parameter.  Update.
10346         (parse_expression_for_completion): Create an
10347         expr_completion_state.
10348         (null_post_parser): Add "completion" parameter.
10349         * p-exp.y: Update rules.
10350         (yylex): Update.
10351         * language.h (struct language_defn) <la_post_parser>: Add
10352         "completing" parameter.
10353         * go-exp.y: Update rules.
10354         (lex_one_token): Update.
10355         * expression.h (parse_completion): Don't declare.
10356         * d-exp.y: Update rules.
10357         (lex_one_token): Update rules.
10358         * c-exp.y: Update rules.
10359         (lex_one_token): Update.
10360         * ada-lang.c (resolve): Add "parse_completion" parameter.
10361         (resolve_subexp): Likewise.
10362         (ada_resolve_function): Likewise.
10363
10364 2019-04-04  Tom Tromey  <tom@tromey.com>
10365
10366         * parser-defs.h (struct parser_state) <start_arglist,
10367         end_arglist>: New methods.
10368         <arglist_len, m_funcall_chain>: New members.
10369         (arglist_len, start_arglist, end_arglist): Don't declare.
10370         * parse.c (arglist_len, funcall_chain): Remove global.
10371         (start_arglist, end_arglist): Remove functions.
10372         (parse_exp_in_context): Update.
10373         * p-exp.y: Update rules.
10374         * m2-exp.y: Update rules.
10375         * go-exp.y: Update rules.
10376         * f-exp.y: Update rules.
10377         * d-exp.y: Update rules.
10378         * c-exp.y: Update rules.
10379
10380 2019-04-04  Tom Tromey  <tom@tromey.com>
10381
10382         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10383         lex_operator, push_back>: New methods.
10384         Update all rules.
10385         (rust_parser::lex_hex, lex_escape): Rename and update.
10386         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10387         (rust_parser::lex_operator): Rename and update.
10388         (rust_parser::lex_number, rustyylex, rustyyerror)
10389         (rust_lex_test_init, rust_lex_test_sequence)
10390         (rust_lex_test_push_back, rust_lex_tests): Update.
10391         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10392         parameter.
10393         <lexptr, prev_lexptr>: New members.
10394         (lexptr, prev_lexptr): Don't declare.
10395         * parse.c (lexptr, prev_lexptr): Remove globals.
10396         (parse_exp_in_context): Update.
10397         * p-exp.y (yylex, yyerror): Update.
10398         * m2-exp.y (parse_number, yylex, yyerror): Update.
10399         * go-exp.y (lex_one_token, yyerror): Update.
10400         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10401         * d-exp.y (lex_one_token, yyerror): Update.
10402         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10403         (lex_one_token, yyerror): Update.
10404         * ada-lex.l (YY_INPUT): Update.
10405         (rewind_to_char): Update.
10406         * ada-exp.y (yyerror): Update.
10407
10408 2019-04-04  Tom Tromey  <tom@tromey.com>
10409
10410         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10411         * parser-defs.h (struct parser_state) <parser_state>: Add new
10412         parameter.
10413         <comma_terminates>: New member.
10414         (comma_terminates): Don't declare global.
10415         * parse.c (comma_terminates): Remove global.
10416         (parse_exp_in_context): Update.
10417         * p-exp.y (yylex): Update.
10418         * m2-exp.y (yylex): Update.
10419         * go-exp.y (lex_one_token): Update.
10420         * f-exp.y (yylex): Update.
10421         * d-exp.y (lex_one_token): Update.
10422         * c-exp.y (lex_one_token): Update.
10423         * ada-lex.l: Update.
10424
10425 2019-04-04  Tom Tromey  <tom@tromey.com>
10426
10427         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10428         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10429         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10430         * parser-defs.h (paren_depth): Don't declare.
10431         * parse.c (paren_depth): Remove global.
10432         (parse_exp_in_context): Update.
10433         * p-exp.y (paren_depth): New global.
10434         (pascal_parse): Initialize it.
10435         * m2-exp.y (paren_depth): New global.
10436         (m2_parse): Initialize it.
10437         * go-exp.y (paren_depth): New global.
10438         (go_parse): Initialize it.
10439         * f-exp.y (paren_depth): New global.
10440         (f_parse): Initialize it.
10441         * d-exp.y (paren_depth): New global.
10442         (d_parse): Initialize it.
10443         * c-exp.y (paren_depth): New global.
10444         (c_parse): Initialize it.
10445         * ada-lex.l (paren_depth): New global.
10446         (lexer_init): Initialize it.
10447
10448 2019-04-04  Tom Tromey  <tom@tromey.com>
10449
10450         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10451         (rust_parser::convert_ast_to_type)
10452         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10453         * parser-defs.h (struct parser_state) <parser_state>: Add
10454         parameters.  Initialize new members.
10455         <expression_context_block, expression_context_pc>: New members.
10456         * parse.c (expression_context_block, expression_context_pc):
10457         Remove globals.
10458         (parse_exp_in_context): Update.
10459         * p-exp.y: Update all rules.
10460         (yylex): Update.
10461         * m2-exp.y: Update all rules.
10462         (yylex): Update.
10463         * go-exp.y (yylex): Update.
10464         * f-exp.y (yylex): Update.
10465         * d-exp.y: Update all rules.
10466         (yylex): Update.
10467         * c-exp.y: Update all rules.
10468         (lex_one_token, classify_name, yylex, c_parse): Update.
10469         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10470
10471 2019-04-04  Tom Tromey  <tom@tromey.com>
10472
10473         * gdbarch.h, gdbarch.c: Rebuild.
10474         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10475         * stap-probe.h:
10476         (struct stap_parse_info): Replace "parser_state" with
10477         "expr_builder".
10478         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10479         (parser_state): New class.
10480         * parse.c (expr_builder): Rename.
10481         (expr_builder::release): Rename.
10482         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10483         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10484         (write_exp_elt_longcst, write_exp_elt_floatcst)
10485         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10486         (write_exp_string_vector, write_exp_bitstring)
10487         (write_exp_msymbol, mark_struct_expression)
10488         (write_dollar_variable)
10489         (insert_type_address_space, increase_expout_size): Replace
10490         "parser_state" with "expr_builder".
10491         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10492         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10493         "parser_state" with "expr_builder".
10494
10495 2019-04-04  Tom Tromey  <tom@tromey.com>
10496
10497         * rust-exp.y: Replace "parse_language" with method call.
10498         * p-exp.y:
10499         (yylex): Replace "parse_language" with method call.
10500         * m2-exp.y:
10501         (yylex): Replace "parse_language" with method call.
10502         * go-exp.y (classify_name): Replace "parse_language" with method
10503         call.
10504         * f-exp.y (yylex): Replace "parse_language" with method call.
10505         * d-exp.y (lex_one_token): Replace "parse_language" with method
10506         call.
10507         * c-exp.y:
10508         (lex_one_token, classify_name, yylex): Replace "parse_language"
10509         with method call.
10510         * ada-exp.y (find_primitive_type, type_char)
10511         (type_system_address): Replace "parse_language" with method call.
10512
10513 2019-04-04  Tom Tromey  <tom@tromey.com>
10514
10515         * rust-exp.y: Replace "parse_gdbarch" with method call.
10516         * parse.c (write_dollar_variable, insert_type_address_space):
10517         Replace "parse_gdbarch" with method call.
10518         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10519         call.
10520         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10521         call.
10522         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10523         "parse_gdbarch" with method call.
10524         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10525         with method call.
10526         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10527         "parse_gdbarch" with method call.
10528         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10529         "parse_gdbarch" with method call.
10530         * c-exp.y (parse_type, parse_number, classify_name): Replace
10531         "parse_gdbarch" with method call.
10532         * ada-lex.l: Replace "parse_gdbarch" with method call.
10533         * ada-exp.y (parse_type, find_primitive_type, type_char)
10534         (type_system_address): Replace "parse_gdbarch" with method call.
10535
10536 2019-04-04  Tom Tromey  <tom@tromey.com>
10537
10538         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10539         * stap-probe.c (stap_parse_argument): Update.
10540         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10541         initial_size parameter.
10542         * rust-exp.y (rust_lex_tests): Update.
10543         * parse.c (parser_state): Update.
10544         (parse_exp_in_context): Update.
10545         * parser-defs.h (struct parser_state) <parser_state>: Remove
10546         "initial_size" parameter.
10547
10548 2019-04-04  Tom Tromey  <tom@tromey.com>
10549
10550         * parser-defs.h (increase_expout_size): Don't declare.
10551         * parse.c (increase_expout_size): Now static.
10552
10553 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10554
10555         * gnu-nat.c (gnu_nat_target::wait): Fix
10556         target_waitstatus_to_string call.
10557
10558 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10559
10560         * eval.c (evaluate_subexp_standard): Handle internal functions
10561         during Fortran function call handling.
10562
10563 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10564
10565         * NEWS: Mention new internal functions.
10566         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10567         (read_base_type): Use dwarf2_init_complex_target_type.
10568         * value.c (creal_internal_fn): New function.
10569         (cimag_internal_fn): New function.
10570         (_initialize_values): Register new internal functions.
10571
10572 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10573
10574         * infrun.c (stop_all_threads): If debug_infrun, always
10575         trace the wait status after wait_one, using
10576         target_waitstatus_to_string and target_pid_to_str.
10577         (handle_inferior_event): Replace various trace of
10578         wait status kind by a single trace.
10579         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10580         wait status kind image by target_waitstatus_to_string.
10581         * target/waitstatus.c (target_waitstatus_to_string): Fix
10582         obsolete comment.
10583
10584 2019-04-01  Tom Tromey  <tromey@adacore.com>
10585
10586         PR symtab/23331:
10587         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10588
10589 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10590             Pedro Alves  <palves@redhat.com>
10591
10592         * top.c (quit_force): Call 'finalize_values'.
10593         * value.c (finalize_values): New function.
10594         * value.h (finalize_values): Declare.
10595
10596 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10597
10598         * NEWS: Announce $_gdb_major and $_gdb_minor.
10599
10600         * top.c (init_gdb_version_vars): New function.
10601         (gdb_init): Call init_gdb_version_vars.
10602
10603 2019-03-29  Tom Tromey  <tromey@adacore.com>
10604
10605         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10606         help text.  Remove dead code.
10607
10608 2019-03-29  Keith Seitz  <keiths@redhat.com>
10609
10610         From Siddhesh Poyarekar:
10611         * f-lang.h (f77_get_upperbound): Return LONGEST.
10612         (f77_get_lowerbound): Likewise.
10613         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10614         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10615         print them.
10616         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10617         plongest to format print it.
10618         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10619         (f77_get_upperbound): Likewise.
10620         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10621         LOWER_BOUND to LONGEST.
10622         (f77_create_arrayprint_offset_tbl): Likewise.
10623
10624 2019-03-29  Keith Seitz  <keiths@redhat.com>
10625
10626         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10627         %s/pulongest for TYPE_LENGTH instead of %d in format
10628         strings.
10629         * ada-typerint.c (ada_print_type): Likewise.
10630         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10631         * compile/compile-c-support.c (generate_register_struct): Likewise.
10632         * gdbtypes.c (recursive_dump_type): Likewise.
10633         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10634         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10635         instead of %d in format strings.
10636         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10637         to std::min to ULONGEST.
10638         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10639         instead of %d in format strings.
10640         * tracepoint.c (info_scope_command): Likewise.
10641         * typeprint.c (print_offset_data::update)
10642         (print_offset_data::finish): Likewise.
10643         * xtensa-tdep.c (xtensa_store_return_value)
10644         (xtensa_push_dummy_call): Likewise.
10645
10646 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10647
10648         * windows-nat.c (display_selector): Fixed format specifications
10649         for 64-bit Cygwin.
10650
10651 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10652
10653         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10654
10655 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10656
10657         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10658         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10659         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10660         (nios2_linux_init_abi): Install it.
10661
10662 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10663
10664         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10665
10666 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10667
10668         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10669
10670 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10671             Tom Tromey  <tromey@adacore.com>
10672
10673         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10674
10675 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10676
10677         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10678         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10679         method to compute the bounds of range types. Also print "[evaluated]"
10680         if the bounds' values come from a dynamic evaluation.
10681
10682 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10683
10684         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10685         whitespace when pretty printing is on.
10686
10687 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10688
10689         * ppc-linux-nat.c: Add include.
10690
10691 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10692
10693         * NEWS: Mention AArch64 Pointer Authentication.
10694
10695 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10696
10697         * arm-linux-nat.c: Add include.
10698
10699 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10700
10701         * source-cache.c (source_cache::get_source_lines): Re-read
10702         fullname after calling open_source_file.
10703
10704 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10705
10706         * NEWS: Mention TLS support for FreeBSD.
10707
10708 2019-03-25  Tom Tromey  <tromey@adacore.com>
10709
10710         * minsyms.c (BUNCH_SIZE): Update comment.
10711         (~minimal_symbol_reader): Remove old comment.
10712         (compact_minimal_symbols): Update comment.
10713         (minimal_symbol_reader::install): Remove old comment.  Update
10714         other comments.
10715
10716 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10717
10718         * s390-linux-nat.c: Add include.
10719
10720 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10721
10722         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10723         Call linux_get_hwcap.
10724         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10725         Likewise.
10726         (aarch64_linux_get_hwcap): Remove function.
10727         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10728         declaration.
10729         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10730         linux_get_hwcap.
10731         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10732         * linux-tdep.c (linux_get_hwcap): Add function.
10733         (linux_get_hwcap2): Likewise.
10734         * linux-tdep.h (linux_get_hwcap): Add declaration.
10735         (linux_get_hwcap2): Likewise.
10736         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10737         (ppc_linux_get_hwcap2): Likewise.
10738         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10739         linux_get_hwcap.
10740         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10741         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10742         (ppc_linux_nat_target::read_description): Likewise.
10743         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10744         * s390-linux-nat.c: Likewise.
10745         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10746
10747 2019-03-24  Tom Tromey  <tom@tromey.com>
10748
10749         * ada-lang.c (standard_lookup): Simplify initialization.
10750         (ada_lookup_symbol_nonlocal): Simplify return.
10751         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10752         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10753         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10754         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10755         initialization.
10756         * solib.c (solib_global_lookup): Simplify.
10757         * symtab.c (null_block_symbol): Remove.
10758         (symbol_cache_lookup): Simplify returns.
10759         (lookup_language_this): Simplify returns.
10760         (lookup_symbol_aux): Simplify return.
10761         (lookup_local_symbol): Simplify returns.
10762         (lookup_global_symbol_from_objfile): Simplify return.
10763         (lookup_symbol_in_objfile_symtabs)
10764         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10765         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10766         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10767         * cp-namespace.c (cp_lookup_bare_symbol)
10768         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10769         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10770         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10771         (cp_lookup_symbol_via_imports): Simplify initialization.
10772         (find_symbol_in_baseclass): Likewise.
10773         * symtab.h (null_block_symbol): Remove.
10774         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10775         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10776         (d_lookup_symbol_module): Likewise.
10777         (find_symbol_in_baseclass): Simplify initialization.
10778
10779 2019-03-24  Tom Tromey  <tom@tromey.com>
10780
10781         * expression.h: Don't include symtab.h.
10782         (struct block): Forward declare.
10783
10784 2019-03-24  Tom Tromey  <tom@tromey.com>
10785
10786         * c-exp.y (typebase): Remove casts.
10787         * gdbtypes.c (lookup_unsigned_typename, )
10788         (lookup_signed_typename): Remove cast.
10789         * eval.c (parse_to_comma_and_eval): Remove cast.
10790         * parse.c (write_dollar_variable): Remove cast.
10791         * block.h (struct block) <superblock>: Now const.
10792         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10793         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10794         (map_block): Make "block" const.
10795         * symfile.h (struct quick_symbol_functions)
10796         <map_matching_symbols>: Constify block argument to "callback".
10797         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10798         const.
10799         (find_pc_sect_compunit_symtab): Make "b" const.
10800         (find_symbol_at_address): Likewise.
10801         (search_symbols): Likewise.
10802         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10803         (dw2_debug_names_lookup_symbol): Likewise.
10804         (dw2_map_matching_symbols): Update.
10805         * p-valprint.c (pascal_val_print): Remove "block".
10806         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10807         (aux_add_nonlocal_symbols): Make "block" const.
10808         (resolve_subexp): Remove cast.
10809         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10810         const.
10811         (iterate_over_file_blocks): Likewise.
10812         * f-exp.y (%union) <bval>: Remove.
10813         * coffread.c (patch_opaque_types): Make "b" const.
10814         * spu-tdep.c (spu_catch_start): Make "block" const.
10815         * c-valprint.c (print_unpacked_pointer): Remove "block".
10816         * symmisc.c (dump_symtab_1): Make "b" const.
10817         (block_depth): Make "block" const.
10818         * d-exp.y (%union) <bval>: Remove.
10819         * cp-support.h (cp_lookup_rtti_type): Update.
10820         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10821         * psymtab.c (psym_lookup_symbol): Make "block" const.
10822         (maintenance_check_psymtabs): Make "b" const.
10823         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10824         (enumerate_locals, enumerate_args): Update.
10825         * python/py-symtab.c (stpy_global_block): Make "block" const.
10826         (stpy_static_block): Likewise.
10827         * inline-frame.c (block_starting_point_at): Make "new_block"
10828         const.
10829         * block.c (find_block_in_blockvector): Make return type const.
10830         (blockvector_for_pc_sect): Make "b" const.
10831         (find_block_in_blockvector): Make "b" const.
10832
10833 2019-03-23  Tom Tromey  <tom@tromey.com>
10834
10835         * varobj.c (varobj_create): Update.
10836         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10837         * printcmd.c (display_command, do_one_display): Don't reset
10838         innermost_block.
10839         * parser-defs.h (enum innermost_block_tracker_type): Move to
10840         expression.h.
10841         (innermost_block): Update comment.
10842         * parse.c (parse_exp_1): Add tracker_types parameter.
10843         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10844         tracker_types parameter.  Reset innermost_block.
10845         (parse_exp_in_context): Remove.
10846         (parse_expression_for_completion): Update.
10847         * objfiles.c (~objfile): Don't reset expression_context_block or
10848         innermost_block.
10849         * expression.h (enum innermost_block_tracker_type): Move from
10850         parser-defs.h.
10851         (parse_exp_1): Add tracker_types parameter.
10852         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10853         reset innermost_block.
10854
10855 2019-03-23  Tom Tromey  <tom@tromey.com>
10856
10857         * objfiles.h: Include bcache.h.
10858
10859 2019-03-23  Tom Tromey  <tom@tromey.com>
10860
10861         * linespec.c (get_current_search_block): Use
10862         scoped_restore_current_language.
10863         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10864
10865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10866             Jiong Wang  <jiong.wang@arm.com>
10867
10868         * aarch64-linux-tdep.c
10869         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10870         section.
10871         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10872
10873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10874             Jiong Wang  <jiong.wang@arm.com>
10875
10876         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10877         instructions.
10878         (aarch64_analyze_prologue_test): Add PACIASP test.
10879         (aarch64_prologue_prev_register): Unmask PC value.
10880
10881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10882             Jiong Wang  <jiong.wang@arm.com>
10883
10884         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10885         (aarch64_dwarf2_prev_register): Unmask PC value.
10886         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10887         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10888         DW_CFA_AARCH64_negate_ra_state.
10889         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10890
10891 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10892             Jiong Wang  <jiong.wang@arm.com>
10893
10894         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10895         registers.
10896         (aarch64_pseudo_register_name): Likewise.
10897         (aarch64_pseudo_register_type): Likewise.
10898         (aarch64_pseudo_register_reggroup_p): Likewise.
10899         (aarch64_gdbarch_init): Add pauth registers.
10900         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10901         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10902         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10903         (struct gdbarch_tdep): Add regnum for ra_state.
10904
10905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10906             Jiong Wang  <jiong.wang@arm.com>
10907
10908         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10909
10910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10911             Jiong Wang  <jiong.wang@arm.com>
10912
10913         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10914         function.
10915         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10916         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10917         (aarch64_gdbarch_init): Add puth registers.
10918         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10919         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10920         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10921
10922 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10923             Jiong Wang  <jiong.wang@arm.com>
10924
10925         * aarch64-linux-nat.c
10926         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10927         * aarch64-linux-tdep.c
10928         (aarch64_linux_core_read_description): Likewise.
10929         (aarch64_linux_get_hwcap): New function.
10930         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10931         (aarch64_linux_get_hwcap): New declaration.
10932
10933 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10934             Jiong Wang  <jiong.wang@arm.com>
10935
10936         * aarch64-linux-nat.c
10937         (aarch64_linux_nat_target::read_description): Add pauth param.
10938         * aarch64-linux-tdep.c
10939         (aarch64_linux_core_read_description): Likewise.
10940         * aarch64-tdep.c (struct target_desc): Add in pauth.
10941         (aarch64_read_description): Add pauth param.
10942         (aarch64_gdbarch_init): Likewise.
10943         * aarch64-tdep.h (aarch64_read_description): Likewise.
10944         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10945         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10946         * features/Makefile: Add new files.
10947         * features/aarch64-pauth.c: New file.
10948         * features/aarch64-pauth.xml: New file.
10949
10950 2019-03-20  Tom Tromey  <tromey@adacore.com>
10951
10952         * infrun.c (handle_inferior_event): Rename from
10953         handle_inferior_event_1.  Create a scoped_value_mark.
10954         (handle_inferior_event): Remove.
10955
10956 2019-03-19  Tom Tromey  <tromey@adacore.com>
10957
10958         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10959         * infrun.h (print_stop_event): Add "displays" parameter.
10960         * infrun.c (print_stop_event): Add "displays" parameter.
10961
10962 2019-03-19  Pedro Alves  <palves@redhat.com>
10963
10964         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10965         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10966         to -1.  Fix TABs vs spaces.
10967         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10968         * tui/tui-out.h (tui_ui_out) Add intro comments.
10969         <m_line, m_start_of_line>: In-class initialize, and add describing
10970         comment.
10971
10972 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10973
10974         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10975         variable names.
10976         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10977
10978 2019-03-18  Pedro Alves  <palves@redhat.com>
10979             Eli Zaretskii <eliz@gnu.org>
10980
10981         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10982         m_line and m_start_of_line.
10983
10984 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10985
10986         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10987         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10988         it returns a newline.  This fixes a regression in TU mode, whereby
10989         the next line is output on the same screen line as the user input.
10990
10991 2019-03-18  Tom Tromey  <tromey@adacore.com>
10992
10993         * minsyms.c (minimal_symbol_reader::install): Remove call to
10994         obstack_blank.
10995
10996 2019-03-18  Pedro Alves  <palves@redhat.com>
10997
10998         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10999         New globals.
11000         (apply_style): New, factored out from ...
11001         (apply_ansi_escape): ... this.  Handle reverse video mode.
11002         (tui_set_reverse_mode): New function.
11003         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11004         * tui/tui-winsource.c (tui_show_source_line): Use
11005         tui_set_reverse_mode instead of setting A_STANDOUT.
11006         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11007         New setter methods.
11008
11009 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11010
11011         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11012         Handle tabs.
11013
11014 2019-03-18  Tom Tromey  <tromey@adacore.com>
11015
11016         * ada-lang.c (empty_array): Add "high" parameter.
11017         (ada_evaluate_subexp): Update.
11018
11019 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11020
11021         * unittests/string_view-selftests.c: Define
11022         _initialize_string_view_selftests unconditionally.
11023
11024 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11025
11026         PR gdb/24350
11027         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11028
11029 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11030
11031         PR gdb/24351
11032         * windows-nat.c (display_selector): Fix format specifiers.
11033
11034 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11035
11036         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11037         tui_refill_source_window instead of tui_refresh_win, to update the
11038         current execution line.  This fixes redisplay of the current line
11039         when stepping through the code with "next" or "step".
11040
11041 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11042
11043         * source-cache.c (source_cache::get_source_lines): Call
11044         find_source_lines to initialize s->nlines.  This fixes vertical
11045         scrolling of TUI source window when the DOWN arrow is pressed.
11046
11047 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11048
11049         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11050         linux-thread-db.c (_initialize_thread_db): Likewise.
11051
11052 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11053
11054         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11055         wclrtoeol in tui_show_source_line".  This reverts changes made in
11056         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11057
11058 2019-03-15  Tom Tromey  <tom@tromey.com>
11059
11060         * symtab.h (struct minimal_symbol): Derive from
11061         general_symbol_info.
11062         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11063         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11064         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11065         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11066         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11067         (MSYMBOL_SEARCH_NAME): Update.
11068         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11069         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11070         * minsyms.c (minimal_symbol_reader::record_full): Update.
11071
11072 2019-03-15  Tom Tromey  <tom@tromey.com>
11073
11074         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11075
11076 2019-03-15  Tom Tromey  <tom@tromey.com>
11077
11078         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11079         unique_xmalloc_ptr.
11080         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11081         Update.
11082         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11083         (build_minimal_symbol_hash_tables)
11084         (minimal_symbol_reader::install): Update.
11085
11086 2019-03-15  Tom Tromey  <tom@tromey.com>
11087
11088         * symtab.c (create_demangled_names_hash): Update.
11089         (symbol_set_names): Update.
11090         * objfiles.h (struct objfile_per_bfd_storage)
11091         <demangled_names_hash>: Now an htab_up.
11092         * objfiles.c (objfile_per_bfd_storage): Simplify.
11093
11094 2019-03-15  Tom Tromey  <tom@tromey.com>
11095
11096         * objfiles.h (struct objfile_per_bfd_storage): Declare
11097         destructor.
11098         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11099         New.
11100         (get_objfile_bfd_data): Use new.  Don't initialize
11101         language_of_main.
11102         (free_objfile_per_bfd_storage): Remove.
11103         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11104
11105 2019-03-15  Tom Tromey  <tom@tromey.com>
11106
11107         * symfile.c (reread_symbols): Update.
11108         * objfiles.c (objfile::objfile): Update.
11109         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11110         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11111         comment.
11112         (minimal_symbol_reader::install): Update.
11113         (terminate_minimal_symbol_table): Remove.
11114         * jit.c (jit_object_close_impl): Update.
11115
11116 2019-03-15  Tom Tromey  <tom@tromey.com>
11117
11118         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11119         initializations.
11120
11121 2019-03-15  Tom Tromey  <tom@tromey.com>
11122
11123         * objfiles.h (struct objfile_per_bfd_storage)
11124         <demangled_hash_languages>: Now a bitset.
11125         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11126         (lookup_minimal_symbol): Update.
11127
11128 2019-03-15  Tom Tromey  <tom@tromey.com>
11129
11130         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11131         Don't return the symbol.
11132         * coffread.c (record_minimal_symbol): Use record_full.
11133
11134 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11135
11136         The MS-Windows port of ncurses fails to switch to a color pair if
11137         one or both of the colors are the implicit default colors.  This
11138         change records the default colors when TUI is initialized, and
11139         then specifies them explicitly when a color pair uses the default
11140         colors.  This allows color styling in TUI mode on MS-Windows.
11141
11142         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11143         ncurses_norm_attr.
11144         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11145         colors in ncurses_norm_attr.
11146         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11147         "none", replace it with the default color recorded in
11148         ncurses_norm_attr.
11149
11150 2019-03-14  Tom Tromey  <tromey@adacore.com>
11151
11152         * source-cache.h (class source_cache) <get_source_lines>: Return
11153         std::string.
11154         * source-cache.c (source_cache::extract_lines): Handle case where
11155         first_pos==npos.  Return std::string.
11156         (source_cache::get_source_lines): Update.
11157
11158 2019-03-14  Tom Tromey  <tromey@adacore.com>
11159
11160         * NEWS: Add item for "style sources" commands.
11161         * source-cache.c (source_cache::get_source_lines): Check
11162         source_styling.
11163         * cli/cli-style.c (source_styling): New global.
11164         (_initialize_cli_style): Add "style sources" commands.
11165         (show_style_sources): New function.
11166         * cli/cli-style.h (source_styling): Declare.
11167
11168 2019-03-14  Pedro Alves  <palves@redhat.com>
11169             Tom Tromey  <tromey@adacore.com>
11170
11171         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11172         * tui/tui-winsource.c (tui_refill_source_window): New function,
11173         from...
11174         (tui_horizontal_source_scroll): ... here.  Move some logic.
11175         * cli/cli-style.c (set_style_enabled): Notify new observable.
11176         * tui/tui-hooks.c (tui_redisplay_source): New function.
11177         (tui_attach_detach_observers): Attach or detach
11178         tui_redisplay_source.
11179         * observable.h (source_styling_changed): New observable.
11180         * observable.c: Define source_styling_changed observable.
11181
11182 2019-03-13  Tom Tromey  <tromey@adacore.com>
11183
11184         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11185         (i386_gnu_nat_target::store_registers): Update.
11186         * target-debug.h (target_debug_print_std_string): New macro.
11187         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11188         * windows-tdep.c (display_one_tib): Update.
11189         * tui/tui-stack.c (tui_make_status_line): Update.
11190         * top.c (print_inferior_quit_action): Update.
11191         * thread.c (thr_try_catch_cmd): Update.
11192         (add_thread_with_info): Update.
11193         (thread_target_id_str): Update.
11194         (thr_try_catch_cmd): Update.
11195         (thread_command): Update.
11196         (thread_find_command): Update.
11197         * record-btrace.c (record_btrace_target::info_record)
11198         (record_btrace_resume_thread, record_btrace_target::resume)
11199         (record_btrace_cancel_resume, record_btrace_step_thread)
11200         (record_btrace_target::wait, record_btrace_target::wait)
11201         (record_btrace_target::wait, record_btrace_target::stop): Update.
11202         * progspace.c (print_program_space): Update.
11203         * process-stratum-target.c
11204         (process_stratum_target::thread_address_space): Update.
11205         * linux-fork.c (linux_fork_mourn_inferior)
11206         (detach_checkpoint_command, info_checkpoints_command)
11207         (linux_fork_context): Update.
11208         (linux_fork_detach): Update.
11209         (class scoped_switch_fork_info): Update.
11210         (delete_checkpoint_command): Update.
11211         * infrun.c (follow_fork_inferior): Update.
11212         (follow_fork_inferior): Update.
11213         (proceed_after_vfork_done): Update.
11214         (handle_vfork_child_exec_or_exit): Update.
11215         (follow_exec): Update.
11216         (displaced_step_prepare_throw): Update.
11217         (displaced_step_restore): Update.
11218         (start_step_over): Update.
11219         (resume_1): Update.
11220         (clear_proceed_status_thread): Update.
11221         (proceed): Update.
11222         (print_target_wait_results): Update.
11223         (do_target_wait): Update.
11224         (context_switch): Update.
11225         (stop_all_threads): Update.
11226         (restart_threads): Update.
11227         (finish_step_over): Update.
11228         (handle_signal_stop): Update.
11229         (switch_back_to_stepped_thread): Update.
11230         (keep_going_pass_signal): Update.
11231         (print_exited_reason): Update.
11232         (normal_stop): Update.
11233         * inferior.c (inferior_pid_to_str): Change return type.
11234         (print_selected_inferior): Update.
11235         (add_inferior): Update.
11236         (detach_inferior): Update.
11237         * dummy-frame.c (fprint_dummy_frames): Update.
11238         * dcache.c (dcache_info_1): Update.
11239         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11240         (btrace_fetch, btrace_clear): Update.
11241         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11242         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11243         type.
11244         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11245         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11246         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11247         * gdbarch.c, gdbarch.h: Rebuild.
11248         * gdbarch.sh (core_pid_to_str): Change return type.
11249         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11250         return type.
11251         (windows_nat_target::pid_to_str): Change return type.
11252         (windows_delete_thread): Update.
11253         (windows_nat_target::attach): Update.
11254         (windows_nat_target::files_info): Update.
11255         * target-delegates.c: Rebuild.
11256         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11257         return type.
11258         (sol_thread_target::pid_to_str): Change return type.
11259         * remote.c (class remote_target) <pid_to_str>: Change return
11260         type.
11261         (remote_target::pid_to_str): Change return type.
11262         (extended_remote_target::attach, remote_target::remote_stop_ns)
11263         (remote_target::remote_notif_remove_queued_reply)
11264         (remote_target::push_stop_reply, remote_target::disable_btrace):
11265         Update.
11266         (extended_remote_target::attach): Update.
11267         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11268         type.
11269         (gdbsim_target::pid_to_str): Change return type.
11270         * ravenscar-thread.c (struct ravenscar_thread_target)
11271         <pid_to_str>: Change return type.
11272         (ravenscar_thread_target::pid_to_str): Change return type.
11273         * procfs.c (class procfs_target) <pid_to_str>: Change return
11274         type.
11275         (procfs_target::pid_to_str): Change return type.
11276         (procfs_target::attach): Update.
11277         (procfs_target::detach): Update.
11278         (procfs_target::fetch_registers): Update.
11279         (procfs_target::store_registers): Update.
11280         (procfs_target::wait): Update.
11281         (procfs_target::files_info): Update.
11282         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11283         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11284         return type.
11285         (nto_procfs_target::pid_to_str): Change return type.
11286         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11287         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11288         return type.
11289         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11290         (exit_lwp): Update.
11291         (attach_proc_task_lwp_callback, get_detach_signal)
11292         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11293         (linux_nat_target::resume, wait_lwp, stop_callback)
11294         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11295         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11296         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11297         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11298         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11299         type.
11300         (inf_ptrace_target::attach): Update.
11301         (inf_ptrace_target::files_info): Update.
11302         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11303         type.
11304         (go32_nat_target::pid_to_str): Change return type.
11305         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11306         (gnu_nat_target::wait): Update.
11307         (gnu_nat_target::wait): Update.
11308         (gnu_nat_target::resume): Update.
11309         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11310         (fbsd_nat_target::wait): Update.
11311         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11312         type.
11313         (darwin_nat_target::attach): Update.
11314         * corelow.c (class core_target) <pid_to_str>: Change return type.
11315         (core_target::pid_to_str): Change return type.
11316         * target.c (normal_pid_to_str): Change return type.
11317         (default_pid_to_str): Likewise.
11318         (target_pid_to_str): Change return type.
11319         (target_translate_tls_address): Update.
11320         (target_announce_detach): Update.
11321         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11322         return type.
11323         (bsd_uthread_target::pid_to_str): Change return type.
11324         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11325         type.
11326         (bsd_kvm_target::pid_to_str): Change return type.
11327         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11328         return type.
11329         (aix_thread_target::pid_to_str): Change return type.
11330         * target.h (struct target_ops) <pid_to_str>: Change return type.
11331         (target_pid_to_str, normal_pid_to_str): Likewise.
11332         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11333         type.
11334         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11335         type.
11336         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11337         return type.
11338         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11339         type.
11340         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11341         type.
11342         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11343         return type.
11344
11345 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11346
11347         * NEWS: Mention that the new default MI version is 3.  Mention
11348         changes to the output of commands and events that deal with
11349         multi-location breakpoints.
11350         * breakpoint.c: Include "mi/mi-out.h".
11351         (print_one_breakpoint): Change output syntax if using MI version
11352         >= 3.
11353         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11354         New.
11355         (mi_multi_location_breakpoint_output_fixed): New.
11356         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11357         (mi_cmd_fix_multi_location_breakpoint_output): New.
11358         (mi_multi_location_breakpoint_output_fixed): New.
11359         * mi/mi-cmds.c (mi_cmds): Register command
11360         -fix-multi-location-breakpoint-output.
11361         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11362         interpreter "mi".
11363
11364 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11365
11366         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11367         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11368         instantiate mi_ui_out based on interpreter name.
11369         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11370         * mi/mi-main.c (mi_load_progress): Likewise.
11371
11372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11373
11374         * NEWS: Combine separate "New targets" sections for 8.3.
11375
11376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11377
11378         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11379         (ppcfbsd_init_abi): Install gdbarch
11380         "fetch_tls_load_module_address" and "get_thread_local_address"
11381         methods.
11382
11383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11384
11385         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11386         (riscv_fbsd_init_abi): Install gdbarch
11387         "fetch_tls_load_module_address" and "get_thread_local_address"
11388         methods.
11389
11390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11391
11392         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11393         (i386fbsd_init_abi): Install gdbarch
11394         "fetch_tls_load_module_address" and "get_thread_local_address"
11395         methods.
11396
11397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11398
11399         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11400         (amd64fbsd_init_abi): Install gdbarch
11401         "fetch_tls_load_module_address" and "get_thread_local_address"
11402         methods.
11403
11404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11405
11406         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11407         (struct fbsd_pspace_data): New type.
11408         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11409         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11410         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11411         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11412         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11413
11414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11415
11416         * gdbtypes.c (lookup_struct_elt): New function.
11417         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11418         * gdbtypes.h (struct struct_elt): New type.
11419         (lookup_struct_elt): New prototype.
11420
11421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11422
11423         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11424         remove disabled code block.
11425
11426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11427
11428         * gdbarch.sh (get_thread_local_address): New method.
11429         * gdbarch.h, gdbarch.c: Regenerate.
11430         * target.c (target_translate_tls_address): Use
11431         gdbarch_get_thread_local_address if present instead of
11432         target::get_thread_local_address.
11433
11434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11435
11436         * target.h (target::get_thread_local_address): Update comment.
11437
11438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11439
11440         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11441         objfile->separate_debug_objfile_backlink if not NULL.
11442
11443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11444
11445         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11446         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11447         (amd64bsd_store_inferior_registers): Likewise.
11448         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11449         Enable segment base registers.
11450         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11451         PT_GETFSBASE and PT_GETGSBASE.
11452         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11453         PT_SETGSBASE.
11454         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11455         segment base registers.
11456         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11457
11458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11459
11460         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11461         Update calls to i386_target_description to add 'segments'
11462         parameter.
11463         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11464         add segment base registers.
11465         * arch/i386.c (i386_create_target_description): Add 'segments'
11466         parameter to enable segment base registers.
11467         * arch/i386.h (i386_create_target_description): Likewise.
11468         * features/i386/32bit-segments.xml: New file.
11469         * features/i386/32bit-segments.c: Generate.
11470         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11471         call to i386_target_description to add 'segments' parameter.
11472         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11473         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11474         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11475         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11476         if feature is present.
11477         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11478         Add 'segments' parameter to call to i386_target_description.
11479         (i386_target_description): Add 'segments' parameter to enable
11480         segment base registers.
11481         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11482         to call to i386_target_description.
11483         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11484         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11485         Define I386_NUM_REGS.
11486         (i386_target_description): Add 'segments' parameter to enable
11487         segment base registers.
11488
11489 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11490
11491         PR/24325
11492         * source-cache.c: #undef open and close, to avoid unresolved
11493         externals during linking.
11494
11495 2019-03-12  Tom Tromey  <tromey@adacore.com>
11496
11497         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11498         const.  Add initializers.
11499         (_initialize_remote): Don't initialize ptid globals.
11500
11501 2019-03-12  Pedro Alves  <palves@redhat.com>
11502
11503         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11504
11505 2019-03-12  Pedro Alves  <palves@redhat.com>
11506
11507         * cp-name-parser.y (main): Remove unused 'len' variable.
11508
11509 2019-03-12  Tom Tromey  <tromey@adacore.com>
11510
11511         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11512         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11513
11514 2019-03-12  Tom Tromey  <tromey@adacore.com>
11515
11516         * linux-nat.c (iterate_over_lwps): Update.
11517         (stop_callback): Remove parameter.
11518         (stop_wait_callback, detach_callback, resume_set_callback)
11519         (select_singlestep_lwp_callback, set_ignore_sigint)
11520         (status_callback, resumed_callback, resume_clear_callback)
11521         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11522         data parameter.
11523         (linux_nat_target::detach, linux_nat_target::resume)
11524         (linux_stop_and_wait_all_lwps, select_event_lwp)
11525         (linux_nat_filter_event, linux_nat_wait_1)
11526         (linux_nat_target::kill, linux_nat_target::stop)
11527         (linux_nat_target::stop): Update.
11528         (linux_nat_resume_callback): Change type.
11529         (resume_stopped_resumed_lwps, count_events_callback)
11530         (select_event_lwp_callback): Likewise.
11531         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11532         * arm-linux-nat.c (struct update_registers_data): Remove.
11533         (update_registers_callback): Change type.
11534         (arm_linux_insert_hw_breakpoint1): Update.
11535         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11536         parameter.
11537         (x86_linux_dr_set_addr): Update.
11538         (x86_linux_dr_set_control): Update.
11539         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11540         (iterate_over_lwps): Use gdb::function_view.
11541         * nat/aarch64-linux-hw-point.c (struct
11542         aarch64_dr_update_callback_param): Remove.
11543         (debug_reg_change_callback): Change type.
11544         (aarch64_notify_debug_reg_change): Update.
11545         * s390-linux-nat.c (s390_refresh_per_info): Update.
11546
11547 2019-03-11  Tom Tromey  <tromey@adacore.com>
11548
11549         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11550         redundant assignment to "this_cu".
11551
11552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11553
11554         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11555
11556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11557
11558         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11559         from...
11560         (rank_one_type): ... this.
11561
11562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11563
11564         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11565         from...
11566         (rank_one_type): ... this.
11567
11568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11569
11570         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11571         from...
11572         (rank_one_type): ... this.
11573
11574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11575
11576         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11577         from...
11578         (rank_one_type): ... this.
11579
11580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11581
11582         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11583         from...
11584         (rank_one_type): ... this.
11585
11586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11587
11588         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11589         from...
11590         (rank_one_type): ... this.
11591
11592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11593
11594         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11595         from...
11596         (rank_one_type): ... this.
11597
11598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11599
11600         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11601         from...
11602         (rank_one_type): ... this.
11603
11604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11605
11606         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11607         from...
11608         (rank_one_type): ... this.
11609
11610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11611
11612         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11613         from...
11614         (rank_one_type): ... this.
11615
11616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11617
11618         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11619         from...
11620         (rank_one_type): ... this.
11621
11622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11623
11624         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11625         from...
11626         (rank_one_type): ... this.
11627
11628 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11629
11630         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11631         inferior-events' shows the example events.
11632
11633 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11634
11635         Support styling on native MS-Windows console
11636
11637         PR/24315
11638         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11639         on MS-Windows if $TERM is not defined.
11640
11641         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11642
11643         * posix-hdep.c (gdb_console_fputs):
11644         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11645         functions.
11646         * ui-file.h (gdb_console_fputs): Add prototype.
11647
11648         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11649         back to fputs only if the former returns zero.
11650
11651 2019-03-07  Tom Tromey  <tom@tromey.com>
11652
11653         * symmisc.c (print_symbol_bcache_statistics): Update.
11654         (print_objfile_statistics): Update.
11655         * symfile.c (allocate_symtab): Update.
11656         * stabsread.c: Don't include bcache.h.
11657         * psymtab.h (struct psymbol_bcache): Don't declare.
11658         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11659         (psymbol_bcache_init, psymbol_bcache_free)
11660         (psymbol_bcache_get_bcache): Don't declare.
11661         * psymtab.c (struct psymbol_bcache): Remove.
11662         (psymtab_storage::psymtab_storage): Update.
11663         (psymtab_storage::~psymtab_storage): Update.
11664         (psymbol_bcache_init, psymbol_bcache_free)
11665         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11666         (add_psymbol_to_bcache): Update.
11667         (allocate_psymtab): Update.
11668         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11669         macro_cache>: No longer pointers.
11670         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11671         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11672         * macrotab.c (macro_bcache): Update.
11673         * macroexp.c: Don't include bcache.h.
11674         * gdbtypes.c (check_types_worklist): Update.
11675         (types_deeply_equal): Remove TRY/CATCH.  Update.
11676         * elfread.c (elf_symtab_read): Update.
11677         * dwarf2read.c: Don't include bcache.h.
11678         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11679         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11680         (print_bcache_statistics, bcache_memory_used): Don't declare.
11681         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11682         methods.  Rename all data members.
11683         * bcache.c (struct bcache): Move to bcache.h.
11684         (bcache::expand_hash_table): Rename from expand_hash_table.
11685         (bcache): Remove.
11686         (bcache::insert): Rename from bcache_full.
11687         (bcache::compare): Rename from bcache_compare.
11688         (bcache_xmalloc): Remove.
11689         (bcache::~bcache): Rename from bcache_xfree.
11690         (bcache::print_statistics): Rename from print_bcache_statistics.
11691         (bcache::memory_used): Rename from bcache_memory_used.
11692
11693 2019-03-07  Pedro Alves  <palves@redhat.com>
11694
11695         * infrun.c (normal_stop): Also check for
11696         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11697
11698 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11699
11700         * f-lang.c (value_from_host_double): Moved to...
11701         * value.c (value_from_host_double): ...here.
11702         * value.h (value_from_host_double): Declare.
11703         * guile/scm-math.c (vlscm_convert_typed_number): Use
11704         value_from_host_double.
11705         (vlscm_convert_number): Likewise.
11706         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11707         * python/py-value.c (convert_value_from_python): Likewise.
11708
11709 2019-03-06  Tom Tromey  <tom@tromey.com>
11710
11711         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11712
11713 2019-03-06  Tom Tromey  <tom@tromey.com>
11714
11715         * utils.h (free_current_contents): Don't declare.
11716         * utils.c (free_current_contents): Remove.
11717
11718 2019-03-06  Tom Tromey  <tom@tromey.com>
11719
11720         * top.c (quit_force): Update.
11721         * main.c (captured_command_loop): Update.
11722         * common/new-op.c (operator new): Update.
11723         * common/common-exceptions.c (struct catcher)
11724         <save_cleanup_chain>: Remove member.
11725         (exceptions_state_mc_init): Update.
11726         (exception_try_scope_entry): Return nullptr.
11727         (exception_try_scope_exit, exception_rethrow)
11728         (throw_exception_sjlj, throw_exception_cxx): Update.
11729         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11730         (all_cleanups, do_cleanups, discard_cleanups)
11731         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11732         (restore_cleanups, restore_final_cleanups): Don't declare.
11733         (do_final_cleanups): Remove parameter.
11734         * common/cleanups.c (cleanup_chain, make_cleanup)
11735         (make_cleanup_dtor, all_cleanups, do_cleanups)
11736         (discard_my_cleanups, discard_cleanups)
11737         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11738         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11739         (null_cleanup): Remove.
11740         (do_final_cleanups): Remove parameter.
11741
11742 2019-03-06  Tom Tromey  <tom@tromey.com>
11743
11744         * remote.c (remote_target::remote_parse_stop_reply): Use
11745         unique_xmalloc_ptr.
11746
11747 2019-03-06  Tom Tromey  <tom@tromey.com>
11748
11749         * stabsread.c (struct stabs_field_info): Rename from field_info.
11750         <list, fnlist>: Add initializers.
11751         <obstack>: New member.
11752         (read_member_functions, read_struct_fields, read_baseclasses):
11753         Allocate on obstack.  Don't use cleanups.
11754         (read_one_struct_field, read_member_functions, read_struct_fields)
11755         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11756         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11757         (read_struct_type): Update.
11758
11759 2019-03-06  Tom Tromey  <tom@tromey.com>
11760
11761         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11762         * common/filestuff.h (make_cleanup_close): Don't declare.
11763         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11764         Remove.
11765
11766 2019-03-06  Tom Tromey  <tom@tromey.com>
11767
11768         * solib-aix.c: Use make_scope_exit.
11769
11770 2019-03-06  Tom Tromey  <tom@tromey.com>
11771
11772         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11773         Use make_scope_exit.
11774
11775 2019-03-06  Tom Tromey  <tom@tromey.com>
11776
11777         * solib-svr4.c (disable_probes_interface): Remove parameter.
11778         (svr4_handle_solib_event): Use make_scope_exit.
11779
11780 2019-03-06  Tom Tromey  <tom@tromey.com>
11781
11782         * remote.c (struct stop_reply_deleter): Remove.
11783         (stop_reply_up): Update.
11784         (struct stop_reply): Derive from notif_event.  Don't typedef.
11785         <regcache>: Now a std::vector.
11786         (stop_reply_xfree): Remove.
11787         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11788         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11789         (remote_target::discard_pending_stop_replies): Use delete.
11790         (remote_target::remote_parse_stop_reply): Update.
11791         (remote_target::process_stop_reply): Update.
11792         * remote-notif.h (struct notif_event): Add virtual destructor.
11793         Remove "dtr" member.
11794         (struct notif_client) <alloc_event>: Return a unique_ptr.
11795         (notif_event_xfree): Don't declare.
11796         (notif_event_up): New typedef.
11797         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11798         (notif_event_xfree, do_notif_event_xfree): Remove.
11799         (remote_notif_state_xfree): Update.
11800
11801 2019-03-06  Tom Tromey  <tom@tromey.com>
11802
11803         * infrun.c (displaced_step_clear_cleanup): Now a
11804         forward_scope_exit type.
11805         (displaced_step_prepare_throw): Update.
11806         (displaced_step_fixup): Update.
11807
11808 2019-03-06  Tom Tromey  <tom@tromey.com>
11809
11810         * inferior.h (class inferior): Update comment.
11811         * gdbthread.h (class thread_info): Update comment.
11812
11813 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11814             Tom Tromey  <tom@tromey.com>
11815
11816         * stabsread.h (struct stab_section_list): Remove.
11817         (coffstab_build_psymtabs): Update.
11818         * dbxread.c (symbuf_sections): Now a std::vector.
11819         (sect_idx): New global.
11820         (fill_symbuf): Update.
11821         (coffstab_build_psymtabs): Change type of stabsects parameter.
11822         Update.
11823         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11824         std::vector.
11825         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11826         (coff_locate_sections): Update.
11827         (coff_symfile_read): Remove cleanups.  Update.
11828         (init_stringtab): Add storage parameter.
11829         (free_stringtab, free_stringtab_cleanup): Remove.
11830         (init_lineno): Add storage parameter.
11831         (free_linetab, free_linetab_cleanup): Remove.
11832
11833 2019-03-06  Pedro Alves  <palves@redhat.com>
11834
11835         * linux-fork.c (fork_info::clobber_regs): Delete.
11836         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11837         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11838         comment.  Adjust.
11839         (scoped_switch_fork_info::scoped_switch_fork_info)
11840         (checkpoint_command, linux_fork_context): Adjust
11841         fork_save_infrun_state calls.
11842
11843 2019-03-06  Pedro Alves  <palves@redhat.com>
11844
11845         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11846         (inf_has_multiple_threads): Return 'bool' and rewrite using
11847         inferior_info::threads().
11848
11849 2019-03-06  Pedro Alves  <palves@redhat.com>
11850
11851         * linux-fork.c: Include <list>.
11852         (fork_list): Now a std::list instance.
11853         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11854         (forks_exist_p, find_last_fork): Adjust.
11855         (new_fork): Delete.
11856         (one_fork_p): New.
11857         (add_fork): Adjust.
11858         (free_fork): Delete, folded into fork_info::~fork_info().
11859         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11860         Adjust.
11861         (init_fork_list): Delete.
11862         (linux_fork_killall, linux_fork_mourn_inferior)
11863         (linux_fork_detach, info_checkpoints_command): Adjust.
11864         (_initialize_linux_fork): No longer call init_fork_list.
11865
11866 2019-03-06  Pedro Alves  <palves@redhat.com>
11867
11868         * linux-fork.c (new_fork): New, split out of ...
11869         (add_fork): ... this.  Return void.  Move "first fork" special
11870         case from here, to ...
11871         (checkpoint_command): ... here.
11872         * linux-linux.h (add_fork): Return void.
11873
11874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11875
11876         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11877
11878 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11879             Chris January  <chris.january@arm.com>
11880             David Lecomber  <david.lecomber@arm.com>
11881
11882         * f-exp.y: New token, UNOP_INTRINSIC.
11883         (exp): New pattern using UNOP_INTRINSIC token.
11884         (f77_keywords): Add 'abs' keyword.
11885         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11886         (value_from_host_double): New function.
11887         (evaluate_subexp_f): Support UNOP_ABS.
11888
11889 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11890
11891         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11892         types.
11893
11894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11895
11896         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11897         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11898         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11899
11900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11901
11902         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11903
11904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11905             Chris January  <chris.january@arm.com>
11906
11907         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11908         * f-exp.y: Define 'KIND' token.
11909         (exp): New pattern for KIND expressions.
11910         (ptype): Handle types with a kind extension.
11911         (direct_abs_decl): Extend to spot kind extensions.
11912         (f77_keywords): Add 'kind' to the list.
11913         (push_kind_type): New function.
11914         (convert_to_kind_type): New function.
11915         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11916         * parse.c (operator_length_standard): Likewise.
11917         * parser-defs.h (enum type_pieces): Add tp_kind.
11918         * std-operator.def: Add UNOP_KIND.
11919
11920 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11921
11922         * f-exp.y (f_parse): Set yydebug.
11923
11924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11925
11926         * f-lang.c (evaluate_subexp_f): New function.
11927         (exp_descriptor_f): New global.
11928         (f_language_defn): Use exp_descriptor_f instead of
11929         exp_descriptor_standard.
11930
11931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11932
11933         * f-exp.y (struct token): Add comments.
11934         (dot_ops): Remove uppercase versions and the end marker.
11935         (f77_keywords): Likewise.
11936         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11937         entries in the dot_ops array are case insensitive, and use
11938         strncasecmp to compare strings.  Also some whitespace cleanup in
11939         this area.  Similar for the f77_keywords array, except entries in
11940         this list might be case sensitive.
11941
11942 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11943
11944         * f-exp.y (struct f77_boolean_val): Add comments.
11945         (boolean_values): Remove uppercase versions, and end marker.
11946         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11947         and use strncasecmp to achieve case insensitivity.  Additionally,
11948         perform whitespace cleanup around this code.
11949
11950 2019-03-06  Tom Tromey  <tromey@adacore.com>
11951
11952         * remote-sim.c (gdbsim_target_open): Use result of
11953         gdb_argv::release.
11954
11955 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11956         Dirk Schubert  <dirk.schubert@arm.com>
11957         Chris January  <chris.january@arm.com>
11958
11959         * eval.c (evaluate_subexp_standard): Call Fortran argument
11960         wrapping logic.
11961         * f-lang.c (struct value): A value which can be passed into a
11962         Fortran function call.
11963         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11964         where appropriate.
11965         (struct type): Value ready for a Fortran function call.
11966         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11967         is needed.
11968         * f-lang.h (fortran_argument_convert): Declaration.
11969         (fortran_preserve_arg_pointer): Declaration.
11970         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11971
11972 2019-03-05  Tom Tromey  <tromey@adacore.com>
11973
11974         * python/py-prettyprint.c (print_string_repr): Remove #if.
11975         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11976
11977 2019-03-05  Tom Tromey  <tromey@adacore.com>
11978
11979         * target.c (the_dummy_target): Move later.  Change type to
11980         "dummy_target".
11981         (initialize_targets): Don't initialize the_dummy_target.
11982
11983 2019-03-05  Tom Tromey  <tromey@adacore.com>
11984
11985         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11986         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11987
11988 2019-03-05  Tom Tromey  <tromey@adacore.com>
11989
11990         * windows-nat.c (windows_nat_target::attach)
11991         (windows_nat_target::detach): Don't call gdb_flush.
11992         * valprint.c (generic_val_print, val_print, val_print_string):
11993         Don't call gdb_flush.
11994         * utils.c (defaulted_query): Don't call gdb_flush.
11995         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11996         * target.c (target_announce_detach): Don't call gdb_flush.
11997         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11998         * remote.c (extended_remote_target::attach): Don't call
11999         gdb_flush.
12000         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12001         * printcmd.c (do_examine): Don't call gdb_flush.
12002         (info_display_command): Don't call gdb_flush.
12003         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12004         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12005         * memattr.c (info_mem_command): Don't call gdb_flush.
12006         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12007         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12008         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12009         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12010         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12011         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12012         (gnu_nat_target::detach): Don't call gdb_flush.
12013         * f-valprint.c (f_val_print): Don't call gdb_flush.
12014         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12015         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12016         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12017         gdb_flush.
12018         * c-valprint.c (c_val_print): Don't call gdb_flush.
12019         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12020
12021 2019-03-05  Tom Tromey  <tromey@adacore.com>
12022
12023         * varobj.c (update_dynamic_varobj_children): Update.
12024         (install_default_visualizer): Use reset, not release.
12025         * value.c (set_internalvar): Update.
12026         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12027         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12028         ATTRIBUTE_UNUSED_RESULT.
12029
12030 2019-03-05  Tom Tromey  <tromey@adacore.com>
12031
12032         * remote.c (class scoped_remote_fd) <release>: Add
12033         ATTRIBUTE_UNUSED_RESULT.
12034
12035 2019-03-05  Tom Tromey  <tromey@adacore.com>
12036
12037         * macroexp.c (struct macro_buffer) <release>: Add
12038         ATTRIBUTE_UNUSED_RESULT.
12039
12040 2019-03-05  Tom Tromey  <tromey@adacore.com>
12041
12042         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12043         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12044         ATTRIBUTE_UNUSED_RESULT.
12045
12046 2019-03-05  Tom Tromey  <tromey@adacore.com>
12047
12048         * common/scoped_fd.h (class scoped_fd) <release>: Add
12049         ATTRIBUTE_UNUSED_RESULT.
12050
12051 2019-03-05  Tom Tromey  <tromey@adacore.com>
12052
12053         * parser-defs.h (struct parser_state) <release>: Add
12054         ATTRIBUTE_UNUSED_RESULT.
12055
12056 2019-03-05  Tom Tromey  <tromey@adacore.com>
12057
12058         * utils.h (class gdb_argv) <release>: Add
12059         ATTRIBUTE_UNUSED_RESULT.
12060         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12061
12062 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12063
12064         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12065         for-loop range, to avoid compiler warnings.
12066
12067         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12068         avoid compiler warnings about unused variables.
12069
12070         * NEWS: Mention end of support for native debugging on MS-Windows
12071         before XP.
12072
12073         PR gdb/24292
12074         * common/netstuff.c:
12075         * gdbserver/gdbreplay.c
12076         * gdbserver/remote-utils.c:
12077         * ser-tcp.c:
12078         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12079         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12080         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12081         'getaddrinfo' and 'freeaddrinfo' were not available before
12082         Windows XP, and mingw.org's MinGW headers by default define
12083         _WIN32_WINNT to 0x500.
12084
12085 2019-03-01  Gary Benson <gbenson@redhat.com>
12086
12087         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12088
12089 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12090             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12091
12092         PR gdb/8527
12093         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12094         set_sigint_trap, clear_sigint_trap.
12095
12096 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12097
12098         * target.c (target_detach): Clear the regcache and the
12099         frame cache.
12100
12101 2019-02-27  Pedro Alves  <palves@redhat.com>
12102
12103         * utils.c (set_screen_size): When we cap the height/width sizes,
12104         tweak the corresponding command variable to show "unlimited":
12105
12106 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12107             Pedro Alves  <palves@redhat.com>
12108
12109         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12110         before calling rl_set_screen_size.
12111
12112 2019-02-27  Tom Tromey  <tromey@adacore.com>
12113
12114         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12115         define.
12116         * python/py-value.c: Remove Python 2.4 workaround.
12117         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12118         workaround.
12119         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12120         Python 2.4 workaround.
12121         * python/python-internal.h: Remove Python 2.4 comment.
12122         (Py_ssize_t): Don't define.
12123         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12124         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12125         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12126         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12127         * python/python.c (do_start_initialization): Remove Python 2.4
12128         workaround.
12129         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12130         (print_children): Remove Python 2.4 workaround.
12131         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12132         workaround.
12133         (CHARBUFFERPROC_NAME): Remove.
12134         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12135         Python 2.4 workaround.
12136
12137 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12138
12139         * NEWS: Note minimum Python version.
12140
12141 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12142
12143         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12144         code from these functions.  Remove corresponding ifdefs.  Use
12145         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12146         Remove gotos and target of gotos.
12147         (infpy_search_memory): Likewise.
12148
12149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12150
12151         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12152         (hppa_gdbarch_init): Don't register deleted functions with
12153         gdbarch.
12154
12155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12156
12157         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12158         (h8300_unwind_sp): Delete.
12159         (h8300_dummy_id): Delete.
12160         (h8300_gdbarch_init): Don't register deleted functions with
12161         gdbarch.
12162
12163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12164
12165         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12166         (ft32_unwind_pc): Delete.
12167         (ft32_unwind_sp): Delete.
12168         (ft32_gdbarch_init): Don't register deleted functions with
12169         gdbarch.
12170
12171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12172
12173         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12174         (frv_unwind_pc): Delete.
12175         (frv_unwind_sp): Delete.
12176         (frv_gdbarch_init): Don't register deleted functions with
12177         gdbarch.
12178
12179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12180
12181         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12182         (riscv_unwind_pc): Delete.
12183         (riscv_unwind_sp): Delete.
12184         (riscv_gdbarch_init): Don't register deleted functions with
12185         gdbarch.
12186
12187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12188
12189         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12190         (csky_unwind_pc): Delete.
12191         (csky_unwind_sp): Delete.
12192         (csky_gdbarch_init): Don't register deleted functions with
12193         gdbarch.
12194
12195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12196
12197         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12198         (cris_unwind_pc): Delete.
12199         (cris_unwind_sp): Delete.
12200         (cris_gdbarch_init): Don't register deleted functions with
12201         gdbarch.
12202
12203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12204
12205         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12206         (bfin_unwind_pc): Delete.
12207         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12208
12209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12210
12211         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12212         (arm_unwind_pc): Delete.
12213         (arm_unwind_sp): Delete.
12214         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12215
12216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12217
12218         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12219         (arc_unwind_pc): Delete.
12220         (arc_unwind_sp): Delete.
12221         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12222
12223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12224
12225         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12226         (alpha_unwind_pc): Delete.
12227         (alpha_gdbarch_init): Don't register deleted functions with
12228         gdbarch.
12229
12230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12231
12232         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12233         (aarch64_unwind_pc): Delete.
12234         (aarch64_unwind_sp): Delete.
12235         (aarch64_gdbarch_init): Don't register deleted functions with
12236         gdbarch.
12237
12238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12239
12240         * gdbtypes.c (type_align): Don't consider static members when
12241         computing structure alignment.
12242
12243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12244
12245         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12246         return 0 for other types.
12247         * arch-utils.c (default_type_align): Always return 0.
12248         * gdbarch.h: Regenerate.
12249         * gdbarch.sh (type_align): Extend comment.
12250         * gdbtypes.c (type_align): Add additional comments, always call
12251         gdbarch_type_align before applying the default rules.
12252         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12253         generic code will then apply a suitable default.
12254         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12255         types, return 0 for other types.
12256
12257 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12258
12259         * NEWS: Create a new section for the next release branch.
12260         Rename the section of the current branch, now that it has
12261         been cut.
12262
12263 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12264
12265         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12266         * version.in: Bump version to 8.3.50.DATE-git.
12267
12268 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12269
12270         * aix-thread.c (ptid_cmp): Remove unused variable.
12271         (get_signaled_thread): Likewise.
12272         (store_regs_user_thread): Likewise.
12273         (store_regs_kernel_thread): Likewise.
12274         (fetch_regs_kernel_thread): Remove shadowed variable.
12275
12276 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12277
12278         * features/riscv/32bit-cpu.xml: Add register numbers.
12279         * features/riscv/32bit-fpu.c: Regenerate.
12280         * features/riscv/32bit-fpu.xml: Add register numbers.
12281         * features/riscv/64bit-cpu.xml: Add register numbers.
12282         * features/riscv/64bit-fpu.c: Regenerate.
12283         * features/riscv/64bit-fpu.xml: Add register numbers.
12284
12285 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12286
12287         * NEWS: Mention two argument form of gdb.Value constructor.
12288         * python/py-value.c (convert_buffer_and_type_to_value): New
12289         function.
12290         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12291         Add support for handling an optional second argument.  Call
12292         convert_buffer_and_type_to_value as appropriate.
12293         * python/python-internal.h (Py_buffer_deleter): New struct.
12294         (Py_buffer_up): New typedef.
12295
12296 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12297
12298         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12299         instead of releasing ownership.
12300
12301 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12302
12303         * dwarf2read.c (open_and_init_dwp_file): Call
12304         elf_numsections instead of bfd_count_sections to initialize
12305         dwp_file->num_sections.
12306
12307 2019-02-25  Tom Tromey  <tromey@adacore.com>
12308
12309         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12310
12311 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12312
12313         * gcore.in: Add '--readnever' option when invoking GDB.
12314
12315 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12316
12317         * MAINTAINERS: Update my email address.
12318
12319 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12320
12321         * build-id.c (build_id_to_debug_bfd_1): New function.
12322         (build_id_to_debug_bfd): Look for separate debug file in
12323         sysroot.
12324
12325 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12326
12327         * gdbarch.sh: Update the copyright year range that is placed into
12328         generated files.
12329
12330 2019-02-22  Keith Seitz  <keiths@redhat.com>
12331
12332         PR symtab/23853
12333         * linespec.c (create_sals_line_offset): Search for the default
12334         symtab's filename instead of its fullname.
12335
12336 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12337
12338         * NEWS: Update style defaults.
12339
12340 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12341
12342         * main.c (captured_main_1): Disable styling in batch mode.
12343
12344 2019-02-20  Tom Tromey  <tom@tromey.com>
12345
12346         * symtab.c (symtab_symbol_info): Fix typos.
12347
12348 2019-02-20  Tom Tromey  <tromey@adacore.com>
12349
12350         * findcmd.c (_initialize_mem_search): Use upper case for
12351         metasyntactic variables.
12352
12353 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12354
12355         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12356         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12357
12358 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12359
12360         * top.h (source_file_name): Change to std::string.
12361         * top.c (source_file_name): Likewise.
12362         (command_line_input): Adjust.
12363         * cli/cli-script.c (script_from_file): Adjust.
12364
12365 2019-02-19  Tom Tromey  <tromey@adacore.com>
12366
12367         * ravenscar-thread.c
12368         (ravenscar_thread_target::update_thread_list): Don't call
12369         ada_build_task_list.
12370         * ada-lang.h (ada_build_task_list): Don't declare.
12371         * ada-tasks.c (struct ada_tasks_inferior_data)
12372         <task_list_valid_p>: Now bool.
12373         (read_known_tasks, ada_task_list_changed)
12374         (ada_tasks_invalidate_inferior_data): Update.
12375         (read_known_tasks_array): Return bool.
12376         (read_known_tasks_list): Likewise.
12377         (read_known_tasks): Return void.
12378         (ada_build_task_list): Now static.
12379
12380 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12381
12382         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12383         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12384
12385 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12386
12387         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12388         variant for ada_tasks_pspace_data_handle and
12389         ada_tasks_inferior_data_handle.
12390         (ada_tasks_pspace_data_cleanup): New function.
12391         (ada_tasks_inferior_data_cleanup): New function.
12392
12393 2019-02-17  Tom Tromey  <tom@tromey.com>
12394
12395         * macrotab.h (macro_source_fullname): Return a std::string.
12396         * macrotab.c (macro_include, check_for_redefinition)
12397         (macro_undef, macro_lookup_definition, foreach_macro)
12398         (foreach_macro_in_scope): Update.
12399         (macro_source_fullname): Return a std::string.
12400         * macrocmd.c (show_pp_source_pos): Update.
12401
12402 2019-02-17  Tom Tromey  <tom@tromey.com>
12403
12404         * macrocmd.c (show_pp_source_pos): Style the file names.
12405
12406 2019-02-17  Tom Tromey  <tom@tromey.com>
12407
12408         PR tui/24197:
12409         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12410
12411 2019-02-17  Tom Tromey  <tom@tromey.com>
12412
12413         * ada-lang.c (user_select_syms): Use filtered printing.
12414         * utils.c (wrap_style): New global.
12415         (desired_style): Remove.
12416         (emit_style_escape): Add stream parameter.
12417         (set_output_style, reset_terminal_style, prompt_for_continue):
12418         Update.
12419         (flush_wrap_buffer): Only flush gdb_stdout.
12420         (wrap_here): Set wrap_style.
12421         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12422         treat escape sequences as a character.  Change when wrap buffer is
12423         flushed.
12424         (fputs_styled): Do not set the output style when the default is
12425         requested.
12426         * ui-style.h (struct ui_file_style) <is_default>: New method.
12427         * source.c (print_source_lines_base): Emit escape sequences in one
12428         piece.
12429
12430 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12431
12432         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12433         integers and enumeration types.
12434
12435 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12436
12437         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12438         instead of lookup_symbol_in_language
12439         (do_exact_match): New function.
12440         (ada_get_symbol_name_matcher): Return do_exact_match when
12441         doing a verbatim match.
12442
12443 2019-02-15  Tom Tromey  <tromey@adacore.com>
12444
12445         * ravenscar-thread.c (ravenscar_thread_target::resume)
12446         (ravenscar_thread_target::wait): Special case wildcard requests.
12447
12448 2019-02-15  Tom Tromey  <tromey@adacore.com>
12449
12450         * ravenscar-thread.c (base_ptid): Remove.
12451         (struct ravenscar_thread_target) <close>: New method.
12452         <m_base_ptid>: New member.
12453         <update_inferior_ptid, active_task, task_is_currently_active,
12454         runtime_initialized>: Declare methods.
12455         <ravenscar_thread_target>: Add constructor.
12456         (ravenscar_thread_target::task_is_currently_active)
12457         (ravenscar_thread_target::update_inferior_ptid)
12458         (ravenscar_runtime_initialized): Rename.  Now methods.
12459         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12460         (ravenscar_thread_target::update_thread_list): Update.
12461         (ravenscar_thread_target::active_task): Now method.
12462         (ravenscar_thread_target::store_registers)
12463         (ravenscar_thread_target::prepare_to_store)
12464         (ravenscar_thread_target::prepare_to_store)
12465         (ravenscar_thread_target::mourn_inferior): Update.
12466         (ravenscar_inferior_created): Use "new" to create target.
12467         (ravenscar_thread_target::get_ada_task_ptid): Update.
12468         (_initialize_ravenscar): Don't initialize base_ptid.
12469         (ravenscar_ops): Remove global.
12470
12471 2019-02-15  Tom Tromey  <tromey@adacore.com>
12472
12473         * target.h (push_target): Declare new overload.
12474         * target.c (push_target): New overload, taking an rvalue reference.
12475         * remote.c (remote_target::open_1): Use push_target overload.
12476         * corelow.c (core_target_open): Use push_target overload.
12477
12478 2019-02-15  Tom Tromey  <tromey@adacore.com>
12479
12480         * ravenscar-thread.c (is_ravenscar_task)
12481         (ravenscar_task_is_currently_active): Return bool.
12482         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12483         (_initialize_ravenscar): Remove "(void)".
12484         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12485         Return bool.
12486
12487 2019-02-15  Tom Tromey  <tromey@adacore.com>
12488
12489         * ravenscar-thread.c (ravenscar_runtime_initializer)
12490         (has_ravenscar_runtime, get_running_thread_id)
12491         (ravenscar_thread_target::resume): Fix indentation.
12492
12493 2019-02-15  Tom Tromey  <tromey@adacore.com>
12494
12495         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12496         from ravenscar_arch_ops.
12497         (sparc_ravenscar_ops::fetch_registers)
12498         (sparc_ravenscar_ops::store_registers): Now methods.
12499         (sparc_ravenscar_prepare_to_store): Remove.
12500         (sparc_ravenscar_ops): Redefine.
12501         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12502         methods and destructor.  Remove members.
12503         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12504         (ravenscar_thread_target::store_registers)
12505         (ravenscar_thread_target::prepare_to_store): Update.
12506         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12507         Remove.
12508         (struct ppc_ravenscar_powerpc_ops): Derive from
12509         ravenscar_arch_ops.
12510         (ppc_ravenscar_powerpc_ops::fetch_registers)
12511         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12512         (ppc_ravenscar_powerpc_ops): Redefine.
12513         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12514         (ppc_ravenscar_e500_ops::fetch_registers)
12515         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12516         (ppc_ravenscar_e500_ops): Redefine.
12517         * aarch64-ravenscar-thread.c
12518         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12519         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12520         (aarch64_ravenscar_fetch_registers)
12521         (aarch64_ravenscar_store_registers): Now methods.
12522         (aarch64_ravenscar_ops): Redefine.
12523
12524 2019-02-15  Tom Tromey  <tromey@adacore.com>
12525
12526         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12527         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12528         (ravenscar_thread_target::stopped_by_watchpoint)
12529         (ravenscar_thread_target::stopped_data_address)
12530         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12531
12532 2019-02-15  Tom Tromey  <tromey@adacore.com>
12533
12534         * ravenscar-thread.c: Fix some typos.
12535
12536 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12537             Tom Tromey  <tromey@adacore.com>
12538
12539         * ada-lang.c (ada_exception_sal): Change addr_string to a
12540         std::string.
12541         (create_ada_exception_catchpoint): Update.
12542
12543 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12544             Tom Tromey  <tromey@adacore.com>
12545
12546         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12547         (bp_location_ops): Remove.
12548         (base_breakpoint_allocate_location): Update.
12549         (free_bp_location): Update.
12550         * ada-lang.c (class ada_catchpoint_location)
12551         <ada_catchpoint_location>: Remove ops parameter.
12552         (ada_catchpoint_location_dtor): Remove.
12553         (ada_catchpoint_location_ops): Remove.
12554         (allocate_location_exception): Update.
12555         * breakpoint.h (struct bp_location_ops): Remove.
12556         (class bp_location) <bp_location>: Remove bp_location_ops
12557         parameter.
12558         <~bp_location>: Add destructor.
12559         <ops>: Remove.
12560
12561 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12562             Pedro Alves  <palves@redhat.com>
12563
12564         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12565         'PATH_MAX'.
12566
12567 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12568             Samuel Thibault  <samuel.thibault@gnu.org>
12569             Thomas Schwinge  <thomas@codesourcery.com>
12570
12571         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12572         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12573
12574 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12575
12576         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12577         (check_empty): Use "const char *".
12578
12579         * gnu-nat.c (gnu_nat_target::detach): Instead of
12580         'detach_inferior (pid)' call
12581         'detach_inferior (find_inferior_pid (pid))'.
12582
12583         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12584         'nat/fork-inferior.o'.
12585         * gnu-nat.c: #include "nat/fork-inferior.h".
12586
12587         * gnu-nat.c (gnu_nat_target::detach): Instead of
12588         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12589         * gnu-nat.h: #include "inf-child.h".
12590         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12591         'i386_gnu_nat_target::fetch_registers'.
12592         (gnu_store_registers): Rename/move to
12593         'i386_gnu_nat_target::store_registers'.
12594
12595         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12596         * gnu-nat.h (mach_thread_info): New function.
12597         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12598
12599         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12600
12601 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12602
12603         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12604
12605 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12606
12607         * windows-nat.c (windows_add_thread): Add new parameter
12608         "main_thread_p" with default value set to false.  Update
12609         function documentation as well as all callers.
12610         (windows_delete_thread): Likewise.
12611         (fake_create_process): Update call to windows_add_thread.
12612         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12613         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12614         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12615         call to windows_delete_thread.
12616
12617 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12618
12619         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12620
12621 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12622
12623         * symfile.c (find_separate_debug_file): Use canonical path of
12624         sysroot with child_path instead of gdb_sysroot if it is valid.
12625
12626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12627
12628         * symfile.c (find_separate_debug_file): Use child_path to
12629         determine if an object file is under a sysroot.
12630
12631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12632
12633         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12634         unittests/child-path-selftests.c.
12635         * common/pathstuff.c (child_path): New function.
12636         * common/pathstuff.h (child_path): New prototype.
12637         * unittests/child-path-selftests.c: New file.
12638
12639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12640
12641         * symfile.c (find_separate_debug_file): Look for separate debug
12642         files in debug directories under the sysroot.
12643
12644 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12645
12646         * symtab.h (struct minimal_symbol data_p): New const method.
12647         (struct minimal_symbol text_p): Likewise.
12648         * symtab.c (output_source_filename): Use file name style
12649         to print file name.
12650         (print_symbol_info): Likewise.
12651         (print_msymbol_info): Use address style to print addresses.
12652         Use function name style to print executable text symbols.
12653         (expand_symtab_containing_pc): Use data_p.
12654         (find_pc_sect_compunit_symtab): Likewise.
12655
12656 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12657
12658         * breakpoint.c (describe_other_breakpoints): Use address style
12659         to print addresses.
12660         (say_where): Likewise.
12661
12662 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12663
12664         * ada-typeprint.c (print_func_type): Print function name
12665         style to print function name.
12666         * c-typeprint.c (c_print_type_1): Likewise.
12667
12668 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12669
12670         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12671         for execve.
12672
12673 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12674
12675         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12676         type_stack.
12677
12678 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12679
12680         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12681         TYPE_CODE_REF types.
12682
12683 2019-02-08  Jim Wilson  <jimw@sifive.com>
12684
12685         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12686         (riscv_linux_fregset): New.
12687         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12688
12689 2019-02-07  Tom Tromey  <tom@tromey.com>
12690
12691         * thread.c (thread_cancel_execution_command): Update.
12692         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12693         methods.
12694         (struct thread_fsm_ops): Remove.
12695         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12696         (thread_fsm_should_stop, thread_fsm_return_value)
12697         (thread_fsm_set_finished, thread_fsm_finished_p)
12698         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12699         Don't declare.
12700         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12701         * infrun.c (clear_proceed_status_thread)
12702         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12703         (print_stop_event): Update.
12704         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12705         Add constructor.
12706         (step_command_fsm_ops): Remove.
12707         (new_step_command_fsm): Remove.
12708         (step_1): Update.
12709         (step_command_fsm::should_stop): Rename from
12710         step_command_fsm_should_stop.
12711         (step_command_fsm::clean_up): Rename from
12712         step_command_fsm_clean_up.
12713         (step_command_fsm::do_async_reply_reason): Rename from
12714         step_command_fsm_async_reply_reason.
12715         (struct until_next_fsm): Inherit from thread_fsm.  Add
12716         constructor.
12717         (until_next_fsm_ops): Remove.
12718         (new_until_next_fsm): Remove.
12719         (until_next_fsm::should_stop): Rename from
12720         until_next_fsm_should_stop.
12721         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12722         (until_next_fsm::do_async_reply_reason): Rename from
12723         until_next_fsm_async_reply_reason.
12724         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12725         constructor.  Change type of breakpoint.
12726         (finish_command_fsm_ops): Remove.
12727         (new_finish_command_fsm): Remove.
12728         (finish_command_fsm::should_stop): Rename from
12729         finish_command_fsm_should_stop.
12730         (finish_command_fsm::clean_up): Rename from
12731         finish_command_fsm_clean_up.
12732         (finish_command_fsm::return_value): Rename from
12733         finish_command_fsm_return_value.
12734         (finish_command_fsm::do_async_reply_reason): Rename from
12735         finish_command_fsm_async_reply_reason.
12736         (finish_command): Update.
12737         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12738         Add constructor.
12739         (call_thread_fsm_ops): Remove.
12740         (call_thread_fsm::call_thread_fsm): Rename from
12741         new_call_thread_fsm.
12742         (call_thread_fsm::should_stop): Rename from
12743         call_thread_fsm_should_stop.
12744         (call_thread_fsm::should_notify_stop): Rename from
12745         call_thread_fsm_should_notify_stop.
12746         (run_inferior_call, call_function_by_hand_dummy): Update.
12747         * cli/cli-interp.c (should_print_stop_to_console): Update.
12748         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12749         Add constructor.  Change type of location_breakpoint,
12750         caller_breakpoint.
12751         (until_break_fsm_ops): Remove.
12752         (new_until_break_fsm): Remove.
12753         (until_break_fsm::should_stop): Rename from
12754         until_break_fsm_should_stop.
12755         (until_break_fsm::clean_up): Rename from
12756         until_break_fsm_clean_up.
12757         (until_break_fsm::do_async_reply_reason): Rename from
12758         until_break_fsm_async_reply_reason.
12759         (until_break_command): Update.
12760         * thread-fsm.c: Remove.
12761         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12762
12763 2019-02-07  Tom Tromey  <tom@tromey.com>
12764
12765         * yy-remap.h: Add include guard.
12766         * xtensa-tdep.h: Add include guard.
12767         * xcoffread.h: Rename include guard.
12768         * varobj-iter.h: Add include guard.
12769         * tui/tui.h: Rename include guard.
12770         * tui/tui-winsource.h: Rename include guard.
12771         * tui/tui-wingeneral.h: Rename include guard.
12772         * tui/tui-windata.h: Rename include guard.
12773         * tui/tui-win.h: Rename include guard.
12774         * tui/tui-stack.h: Rename include guard.
12775         * tui/tui-source.h: Rename include guard.
12776         * tui/tui-regs.h: Rename include guard.
12777         * tui/tui-out.h: Rename include guard.
12778         * tui/tui-layout.h: Rename include guard.
12779         * tui/tui-io.h: Rename include guard.
12780         * tui/tui-hooks.h: Rename include guard.
12781         * tui/tui-file.h: Rename include guard.
12782         * tui/tui-disasm.h: Rename include guard.
12783         * tui/tui-data.h: Rename include guard.
12784         * tui/tui-command.h: Rename include guard.
12785         * tic6x-tdep.h: Add include guard.
12786         * target/waitstatus.h: Rename include guard.
12787         * target/wait.h: Rename include guard.
12788         * target/target.h: Rename include guard.
12789         * target/resume.h: Rename include guard.
12790         * target-float.h: Rename include guard.
12791         * stabsread.h: Add include guard.
12792         * rs6000-tdep.h: Add include guard.
12793         * riscv-fbsd-tdep.h: Add include guard.
12794         * regformats/regdef.h: Rename include guard.
12795         * record.h: Rename include guard.
12796         * python/python.h: Rename include guard.
12797         * python/python-internal.h: Rename include guard.
12798         * python/py-stopevent.h: Rename include guard.
12799         * python/py-ref.h: Rename include guard.
12800         * python/py-record.h: Rename include guard.
12801         * python/py-record-full.h: Rename include guard.
12802         * python/py-record-btrace.h: Rename include guard.
12803         * python/py-instruction.h: Rename include guard.
12804         * python/py-events.h: Rename include guard.
12805         * python/py-event.h: Rename include guard.
12806         * procfs.h: Add include guard.
12807         * proc-utils.h: Add include guard.
12808         * p-lang.h: Add include guard.
12809         * or1k-tdep.h: Rename include guard.
12810         * observable.h: Rename include guard.
12811         * nto-tdep.h: Rename include guard.
12812         * nat/x86-linux.h: Rename include guard.
12813         * nat/x86-linux-dregs.h: Rename include guard.
12814         * nat/x86-gcc-cpuid.h: Add include guard.
12815         * nat/x86-dregs.h: Rename include guard.
12816         * nat/x86-cpuid.h: Rename include guard.
12817         * nat/ppc-linux.h: Rename include guard.
12818         * nat/mips-linux-watch.h: Rename include guard.
12819         * nat/linux-waitpid.h: Rename include guard.
12820         * nat/linux-ptrace.h: Rename include guard.
12821         * nat/linux-procfs.h: Rename include guard.
12822         * nat/linux-osdata.h: Rename include guard.
12823         * nat/linux-nat.h: Rename include guard.
12824         * nat/linux-namespaces.h: Rename include guard.
12825         * nat/linux-btrace.h: Rename include guard.
12826         * nat/glibc_thread_db.h: Rename include guard.
12827         * nat/gdb_thread_db.h: Rename include guard.
12828         * nat/gdb_ptrace.h: Rename include guard.
12829         * nat/fork-inferior.h: Rename include guard.
12830         * nat/amd64-linux-siginfo.h: Rename include guard.
12831         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12832         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12833         * nat/aarch64-linux.h: Rename include guard.
12834         * nat/aarch64-linux-hw-point.h: Rename include guard.
12835         * mn10300-tdep.h: Add include guard.
12836         * mips-linux-tdep.h: Add include guard.
12837         * mi/mi-parse.h: Rename include guard.
12838         * mi/mi-out.h: Rename include guard.
12839         * mi/mi-main.h: Rename include guard.
12840         * mi/mi-interp.h: Rename include guard.
12841         * mi/mi-getopt.h: Rename include guard.
12842         * mi/mi-console.h: Rename include guard.
12843         * mi/mi-common.h: Rename include guard.
12844         * mi/mi-cmds.h: Rename include guard.
12845         * mi/mi-cmd-break.h: Rename include guard.
12846         * m2-lang.h: Add include guard.
12847         * location.h: Rename include guard.
12848         * linux-record.h: Rename include guard.
12849         * linux-nat.h: Add include guard.
12850         * linux-fork.h: Add include guard.
12851         * i386-darwin-tdep.h: Rename include guard.
12852         * hppa-linux-offsets.h: Add include guard.
12853         * guile/guile.h: Rename include guard.
12854         * guile/guile-internal.h: Rename include guard.
12855         * gnu-nat.h: Rename include guard.
12856         * gdb-stabs.h: Rename include guard.
12857         * frv-tdep.h: Add include guard.
12858         * f-lang.h: Add include guard.
12859         * event-loop.h: Add include guard.
12860         * darwin-nat.h: Rename include guard.
12861         * cp-abi.h: Rename include guard.
12862         * config/sparc/nm-sol2.h: Rename include guard.
12863         * config/nm-nto.h: Rename include guard.
12864         * config/nm-linux.h: Add include guard.
12865         * config/i386/nm-i386gnu.h: Rename include guard.
12866         * config/djgpp/nl_types.h: Rename include guard.
12867         * config/djgpp/langinfo.h: Rename include guard.
12868         * compile/gcc-cp-plugin.h: Add include guard.
12869         * compile/gcc-c-plugin.h: Add include guard.
12870         * compile/compile.h: Rename include guard.
12871         * compile/compile-object-run.h: Rename include guard.
12872         * compile/compile-object-load.h: Rename include guard.
12873         * compile/compile-internal.h: Rename include guard.
12874         * compile/compile-cplus.h: Rename include guard.
12875         * compile/compile-c.h: Rename include guard.
12876         * common/xml-utils.h: Rename include guard.
12877         * common/x86-xstate.h: Rename include guard.
12878         * common/version.h: Rename include guard.
12879         * common/vec.h: Rename include guard.
12880         * common/tdesc.h: Rename include guard.
12881         * common/selftest.h: Rename include guard.
12882         * common/scoped_restore.h: Rename include guard.
12883         * common/scoped_mmap.h: Rename include guard.
12884         * common/scoped_fd.h: Rename include guard.
12885         * common/safe-iterator.h: Rename include guard.
12886         * common/run-time-clock.h: Rename include guard.
12887         * common/refcounted-object.h: Rename include guard.
12888         * common/queue.h: Rename include guard.
12889         * common/ptid.h: Rename include guard.
12890         * common/print-utils.h: Rename include guard.
12891         * common/preprocessor.h: Rename include guard.
12892         * common/pathstuff.h: Rename include guard.
12893         * common/observable.h: Rename include guard.
12894         * common/netstuff.h: Rename include guard.
12895         * common/job-control.h: Rename include guard.
12896         * common/host-defs.h: Rename include guard.
12897         * common/gdb_wait.h: Rename include guard.
12898         * common/gdb_vecs.h: Rename include guard.
12899         * common/gdb_unlinker.h: Rename include guard.
12900         * common/gdb_unique_ptr.h: Rename include guard.
12901         * common/gdb_tilde_expand.h: Rename include guard.
12902         * common/gdb_sys_time.h: Rename include guard.
12903         * common/gdb_string_view.h: Rename include guard.
12904         * common/gdb_splay_tree.h: Rename include guard.
12905         * common/gdb_setjmp.h: Rename include guard.
12906         * common/gdb_ref_ptr.h: Rename include guard.
12907         * common/gdb_optional.h: Rename include guard.
12908         * common/gdb_locale.h: Rename include guard.
12909         * common/gdb_assert.h: Rename include guard.
12910         * common/filtered-iterator.h: Rename include guard.
12911         * common/filestuff.h: Rename include guard.
12912         * common/fileio.h: Rename include guard.
12913         * common/environ.h: Rename include guard.
12914         * common/common-utils.h: Rename include guard.
12915         * common/common-types.h: Rename include guard.
12916         * common/common-regcache.h: Rename include guard.
12917         * common/common-inferior.h: Rename include guard.
12918         * common/common-gdbthread.h: Rename include guard.
12919         * common/common-exceptions.h: Rename include guard.
12920         * common/common-defs.h: Rename include guard.
12921         * common/common-debug.h: Rename include guard.
12922         * common/cleanups.h: Rename include guard.
12923         * common/buffer.h: Rename include guard.
12924         * common/btrace-common.h: Rename include guard.
12925         * common/break-common.h: Rename include guard.
12926         * cli/cli-utils.h: Rename include guard.
12927         * cli/cli-style.h: Rename include guard.
12928         * cli/cli-setshow.h: Rename include guard.
12929         * cli/cli-script.h: Rename include guard.
12930         * cli/cli-interp.h: Rename include guard.
12931         * cli/cli-decode.h: Rename include guard.
12932         * cli/cli-cmds.h: Rename include guard.
12933         * charset-list.h: Add include guard.
12934         * buildsym-legacy.h: Rename include guard.
12935         * bfin-tdep.h: Add include guard.
12936         * ax.h: Rename include guard.
12937         * arm-linux-tdep.h: Add include guard.
12938         * arm-fbsd-tdep.h: Add include guard.
12939         * arch/xtensa.h: Rename include guard.
12940         * arch/tic6x.h: Add include guard.
12941         * arch/i386.h: Add include guard.
12942         * arch/arm.h: Rename include guard.
12943         * arch/arm-linux.h: Rename include guard.
12944         * arch/arm-get-next-pcs.h: Rename include guard.
12945         * arch/amd64.h: Add include guard.
12946         * arch/aarch64-insn.h: Rename include guard.
12947         * arch-utils.h: Rename include guard.
12948         * annotate.h: Add include guard.
12949         * amd64-darwin-tdep.h: Rename include guard.
12950         * aarch64-linux-tdep.h: Add include guard.
12951         * aarch64-fbsd-tdep.h: Add include guard.
12952         * aarch32-linux-nat.h: Add include guard.
12953
12954 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12955
12956         * macrotab.c (macro_define_internal): New function that
12957         factorizes macro_define_object_internal and macro_define_function
12958         code.
12959         (macro_define_object_internal): Use macro_define_internal.
12960         (macro_define_function): Likewise.
12961
12962 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12963
12964         * macrocmd.c (extract_identifier): Return
12965         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12966         callers.
12967
12968 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12969
12970         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12971
12972 2019-02-05  Tom Tromey  <tom@tromey.com>
12973
12974         * target.c (target_stack::unpush): Move assertion earlier.
12975
12976 2019-01-30  Tom Tromey  <tom@tromey.com>
12977
12978         PR python/23615:
12979         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12980         (gdbpy_parse_and_eval): Likewise.
12981         * python/python-internal.h (gdbpy_allow_threads): New class.
12982
12983 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12984
12985         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12986         (aarch64_fbsd_fpregmap): Move earlier.
12987         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12988         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12989         instead of individual calls to trad_frame_set_reg_addr.
12990         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12991         earlier.
12992         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12993         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12994         instead of individual calls to trad_frame_set_reg_addr.
12995
12996 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12997
12998         * CONTRIBUTE: Replace contribution list with wiki link.
12999
13000 2019-01-25  Tom Tromey  <tom@tromey.com>
13001
13002         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13003
13004 2019-01-25  Tom Tromey  <tom@tromey.com>
13005
13006         * xtensa-linux-nat.c: Fix common/ includes.
13007         * xml-support.h: Fix common/ includes.
13008         * xml-support.c: Fix common/ includes.
13009         * x86-linux-nat.c: Fix common/ includes.
13010         * windows-nat.c: Fix common/ includes.
13011         * varobj.h: Fix common/ includes.
13012         * varobj.c: Fix common/ includes.
13013         * value.c: Fix common/ includes.
13014         * valops.c: Fix common/ includes.
13015         * utils.c: Fix common/ includes.
13016         * unittests/xml-utils-selftests.c: Fix common/ includes.
13017         * unittests/utils-selftests.c: Fix common/ includes.
13018         * unittests/unpack-selftests.c: Fix common/ includes.
13019         * unittests/tracepoint-selftests.c: Fix common/ includes.
13020         * unittests/style-selftests.c: Fix common/ includes.
13021         * unittests/string_view-selftests.c: Fix common/ includes.
13022         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13023         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13024         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13025         * unittests/rsp-low-selftests.c: Fix common/ includes.
13026         * unittests/parse-connection-spec-selftests.c: Fix common/
13027         includes.
13028         * unittests/optional-selftests.c: Fix common/ includes.
13029         * unittests/offset-type-selftests.c: Fix common/ includes.
13030         * unittests/observable-selftests.c: Fix common/ includes.
13031         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13032         * unittests/memrange-selftests.c: Fix common/ includes.
13033         * unittests/memory-map-selftests.c: Fix common/ includes.
13034         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13035         * unittests/function-view-selftests.c: Fix common/ includes.
13036         * unittests/environ-selftests.c: Fix common/ includes.
13037         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13038         * unittests/common-utils-selftests.c: Fix common/ includes.
13039         * unittests/cli-utils-selftests.c: Fix common/ includes.
13040         * unittests/array-view-selftests.c: Fix common/ includes.
13041         * ui-file.c: Fix common/ includes.
13042         * tui/tui-io.c: Fix common/ includes.
13043         * tracepoint.h: Fix common/ includes.
13044         * tracepoint.c: Fix common/ includes.
13045         * tracefile-tfile.c: Fix common/ includes.
13046         * top.h: Fix common/ includes.
13047         * top.c: Fix common/ includes.
13048         * thread.c: Fix common/ includes.
13049         * target/waitstatus.h: Fix common/ includes.
13050         * target/waitstatus.c: Fix common/ includes.
13051         * target.h: Fix common/ includes.
13052         * target.c: Fix common/ includes.
13053         * target-memory.c: Fix common/ includes.
13054         * target-descriptions.c: Fix common/ includes.
13055         * symtab.h: Fix common/ includes.
13056         * symfile.c: Fix common/ includes.
13057         * stap-probe.c: Fix common/ includes.
13058         * spu-linux-nat.c: Fix common/ includes.
13059         * sparc-nat.c: Fix common/ includes.
13060         * source.c: Fix common/ includes.
13061         * solib.c: Fix common/ includes.
13062         * solib-target.c: Fix common/ includes.
13063         * ser-unix.c: Fix common/ includes.
13064         * ser-tcp.c: Fix common/ includes.
13065         * ser-pipe.c: Fix common/ includes.
13066         * ser-base.c: Fix common/ includes.
13067         * selftest-arch.c: Fix common/ includes.
13068         * s12z-tdep.c: Fix common/ includes.
13069         * rust-exp.y: Fix common/ includes.
13070         * rs6000-aix-tdep.c: Fix common/ includes.
13071         * riscv-tdep.c: Fix common/ includes.
13072         * remote.c: Fix common/ includes.
13073         * remote-notif.h: Fix common/ includes.
13074         * remote-fileio.h: Fix common/ includes.
13075         * remote-fileio.c: Fix common/ includes.
13076         * regcache.h: Fix common/ includes.
13077         * regcache.c: Fix common/ includes.
13078         * record-btrace.c: Fix common/ includes.
13079         * python/python.c: Fix common/ includes.
13080         * python/py-type.c: Fix common/ includes.
13081         * python/py-inferior.c: Fix common/ includes.
13082         * progspace.h: Fix common/ includes.
13083         * producer.c: Fix common/ includes.
13084         * procfs.c: Fix common/ includes.
13085         * proc-api.c: Fix common/ includes.
13086         * printcmd.c: Fix common/ includes.
13087         * ppc-linux-nat.c: Fix common/ includes.
13088         * parser-defs.h: Fix common/ includes.
13089         * osdata.c: Fix common/ includes.
13090         * obsd-nat.c: Fix common/ includes.
13091         * nat/x86-linux.c: Fix common/ includes.
13092         * nat/x86-linux-dregs.c: Fix common/ includes.
13093         * nat/x86-dregs.h: Fix common/ includes.
13094         * nat/x86-dregs.c: Fix common/ includes.
13095         * nat/ppc-linux.c: Fix common/ includes.
13096         * nat/mips-linux-watch.h: Fix common/ includes.
13097         * nat/mips-linux-watch.c: Fix common/ includes.
13098         * nat/linux-waitpid.c: Fix common/ includes.
13099         * nat/linux-ptrace.h: Fix common/ includes.
13100         * nat/linux-ptrace.c: Fix common/ includes.
13101         * nat/linux-procfs.c: Fix common/ includes.
13102         * nat/linux-personality.c: Fix common/ includes.
13103         * nat/linux-osdata.c: Fix common/ includes.
13104         * nat/linux-namespaces.c: Fix common/ includes.
13105         * nat/linux-btrace.h: Fix common/ includes.
13106         * nat/linux-btrace.c: Fix common/ includes.
13107         * nat/fork-inferior.c: Fix common/ includes.
13108         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13109         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13110         * nat/aarch64-linux.c: Fix common/ includes.
13111         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13112         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13113         * namespace.h: Fix common/ includes.
13114         * mips-linux-tdep.c: Fix common/ includes.
13115         * minsyms.c: Fix common/ includes.
13116         * mi/mi-parse.h: Fix common/ includes.
13117         * mi/mi-main.c: Fix common/ includes.
13118         * mi/mi-cmd-env.c: Fix common/ includes.
13119         * memrange.h: Fix common/ includes.
13120         * memattr.c: Fix common/ includes.
13121         * maint.h: Fix common/ includes.
13122         * maint.c: Fix common/ includes.
13123         * main.c: Fix common/ includes.
13124         * machoread.c: Fix common/ includes.
13125         * location.c: Fix common/ includes.
13126         * linux-thread-db.c: Fix common/ includes.
13127         * linux-nat.c: Fix common/ includes.
13128         * linux-fork.c: Fix common/ includes.
13129         * inline-frame.c: Fix common/ includes.
13130         * infrun.c: Fix common/ includes.
13131         * inflow.c: Fix common/ includes.
13132         * inferior.h: Fix common/ includes.
13133         * inferior.c: Fix common/ includes.
13134         * infcmd.c: Fix common/ includes.
13135         * inf-ptrace.c: Fix common/ includes.
13136         * inf-child.c: Fix common/ includes.
13137         * ia64-linux-nat.c: Fix common/ includes.
13138         * i387-tdep.c: Fix common/ includes.
13139         * i386-tdep.c: Fix common/ includes.
13140         * i386-linux-tdep.c: Fix common/ includes.
13141         * i386-linux-nat.c: Fix common/ includes.
13142         * i386-go32-tdep.c: Fix common/ includes.
13143         * i386-fbsd-tdep.c: Fix common/ includes.
13144         * i386-fbsd-nat.c: Fix common/ includes.
13145         * guile/scm-type.c: Fix common/ includes.
13146         * guile/guile.c: Fix common/ includes.
13147         * go32-nat.c: Fix common/ includes.
13148         * gnu-nat.c: Fix common/ includes.
13149         * gdbthread.h: Fix common/ includes.
13150         * gdbarch-selftests.c: Fix common/ includes.
13151         * gdb_usleep.c: Fix common/ includes.
13152         * gdb_select.h: Fix common/ includes.
13153         * gdb_bfd.c: Fix common/ includes.
13154         * gcore.c: Fix common/ includes.
13155         * fork-child.c: Fix common/ includes.
13156         * findvar.c: Fix common/ includes.
13157         * fbsd-nat.c: Fix common/ includes.
13158         * event-top.c: Fix common/ includes.
13159         * event-loop.c: Fix common/ includes.
13160         * dwarf2read.c: Fix common/ includes.
13161         * dwarf2loc.c: Fix common/ includes.
13162         * dwarf2-frame.c: Fix common/ includes.
13163         * dwarf-index-cache.c: Fix common/ includes.
13164         * dtrace-probe.c: Fix common/ includes.
13165         * disasm-selftests.c: Fix common/ includes.
13166         * defs.h: Fix common/ includes.
13167         * csky-tdep.c: Fix common/ includes.
13168         * cp-valprint.c: Fix common/ includes.
13169         * cp-support.h: Fix common/ includes.
13170         * cp-support.c: Fix common/ includes.
13171         * corelow.c: Fix common/ includes.
13172         * completer.h: Fix common/ includes.
13173         * completer.c: Fix common/ includes.
13174         * compile/compile.c: Fix common/ includes.
13175         * compile/compile-loc2c.c: Fix common/ includes.
13176         * compile/compile-cplus-types.c: Fix common/ includes.
13177         * compile/compile-cplus-symbols.c: Fix common/ includes.
13178         * command.h: Fix common/ includes.
13179         * cli/cli-dump.c: Fix common/ includes.
13180         * cli/cli-cmds.c: Fix common/ includes.
13181         * charset.c: Fix common/ includes.
13182         * build-id.c: Fix common/ includes.
13183         * btrace.h: Fix common/ includes.
13184         * btrace.c: Fix common/ includes.
13185         * breakpoint.h: Fix common/ includes.
13186         * breakpoint.c: Fix common/ includes.
13187         * ax.h:
13188         (enum agent_op): Fix common/ includes.
13189         * ax-general.c (struct aop_map): Fix common/ includes.
13190         * ax-gdb.c: Fix common/ includes.
13191         * auxv.c: Fix common/ includes.
13192         * auto-load.c: Fix common/ includes.
13193         * arm-tdep.c: Fix common/ includes.
13194         * arch/riscv.c: Fix common/ includes.
13195         * arch/ppc-linux-common.c: Fix common/ includes.
13196         * arch/i386.c: Fix common/ includes.
13197         * arch/arm.c: Fix common/ includes.
13198         * arch/arm-linux.c: Fix common/ includes.
13199         * arch/arm-get-next-pcs.c: Fix common/ includes.
13200         * arch/amd64.c: Fix common/ includes.
13201         * arch/aarch64.c: Fix common/ includes.
13202         * arch/aarch64-insn.c: Fix common/ includes.
13203         * arch-utils.c: Fix common/ includes.
13204         * amd64-windows-tdep.c: Fix common/ includes.
13205         * amd64-tdep.c: Fix common/ includes.
13206         * amd64-sol2-tdep.c: Fix common/ includes.
13207         * amd64-obsd-tdep.c: Fix common/ includes.
13208         * amd64-nbsd-tdep.c: Fix common/ includes.
13209         * amd64-linux-tdep.c: Fix common/ includes.
13210         * amd64-linux-nat.c: Fix common/ includes.
13211         * amd64-fbsd-tdep.c: Fix common/ includes.
13212         * amd64-fbsd-nat.c: Fix common/ includes.
13213         * amd64-dicos-tdep.c: Fix common/ includes.
13214         * amd64-darwin-tdep.c: Fix common/ includes.
13215         * agent.c: Fix common/ includes.
13216         * ada-lang.h: Fix common/ includes.
13217         * ada-lang.c: Fix common/ includes.
13218         * aarch64-tdep.c: Fix common/ includes.
13219
13220 2019-01-25  Tom Tromey  <tom@tromey.com>
13221
13222         * common/create-version.sh: Use common/version.h.
13223
13224 2019-01-24  Pedro Alves  <palves@redhat.com>
13225
13226         * infrun.c (signal_stop, signal_print, signal_program)
13227         (signal_catch, signal_pass): Now arrays instead of pointers.
13228         (update_signals_program_target, do_target_resume)
13229         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13230         * linux-nat.c (linux_nat_target::pass_signals)
13231         (linux_nat_target::create_inferior, linux_nat_target::attach):
13232         Adjust.
13233         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13234         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13235         * procfs.c (procfs_target::pass_signals): Adjust.
13236         * record-full.c (record_full_target::resume): Adjust.
13237         * remote.c (remote_target::pass_signals)
13238         (remote_target::program_signals): Adjust.
13239         * target-debug.h (target_debug_print_signals): Now takes a
13240         gdb::array_view as parameter.  Adjust.
13241         * target.h (target_ops) <pass_signals, program_signals>: Replace
13242         pointer and length parameters with gdb::array_view.
13243         (target_pass_signals, target_program_signals): Likewise.
13244         * target-delegates.c: Regenerate.
13245
13246 2019-01-24  Pedro Alves  <palves@redhat.com>
13247
13248         * common/forward-scope-exit.h
13249         (forward_scope_exit::forward_scope_exit): Pass arguments to
13250         m_bind_function directly, instead of creating a std::bind and
13251         copying that.
13252
13253 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13254
13255         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13256         for static members.
13257         (pass_in_v_vfp_candidate): Likewise.
13258
13259 2019-01-23  Tom Tromey  <tom@tromey.com>
13260             Pedro Alves  <palves@redhat.com>
13261
13262         * regcache.c (class regcache_invalidator): Remove.
13263         (regcache::raw_write): Use make_scope_exit.
13264
13265 2019-01-23  Tom Tromey  <tom@tromey.com>
13266
13267         * ui-out.h (class ui_out_emit_type): Update comment.
13268
13269 2019-01-23  Tom Tromey  <tom@tromey.com>
13270
13271         * infrun.c (fetch_inferior_event): Update comment.
13272
13273 2019-01-23  Tom Tromey  <tom@tromey.com>
13274             Pedro Alves  <palves@redhat.com>
13275
13276         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13277         parameter.
13278         (fetch_inferior_event): Use SCOPE_EXIT.
13279
13280
13281 2019-01-23  Tom Tromey  <tom@tromey.com>
13282             Pedro Alves  <palves@redhat.com>
13283
13284         * infrun.c (disable_thread_events): Delete.
13285         (stop_all_threads): Use SCOPE_EXIT.
13286
13287 2019-01-23  Tom Tromey  <tom@tromey.com>
13288             Pedro Alves  <palves@redhat.com>
13289
13290         * symfile.c: Include forward-scope-exit.h.
13291         (clear_symtab_users_cleanup): Replace forward declaration with
13292         a FORWARD_SCOPE_EXIT.
13293         (syms_from_objfile_1): Use the forward_scope_exit and
13294         gdb::optional instead of cleanup_function.
13295         (reread_symbols): Use the forward_scope_exit instead of
13296         cleanup_function.
13297         (clear_symtab_users_cleanup): Remove function.
13298
13299 2019-01-23  Tom Tromey  <tom@tromey.com>
13300             Pedro Alves  <palves@redhat.com>
13301
13302         * linux-nat.c: Include scope-exit.h.
13303         (cleanup_target_stop): Remove.
13304         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13305         SCOPE_EXIT.
13306
13307 2019-01-23  Tom Tromey  <tom@tromey.com>
13308             Pedro Alves  <palves@redhat.com>
13309
13310         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13311         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13312
13313 2019-01-23  Tom Tromey  <tom@tromey.com>
13314             Andrew Burgess  <andrew.burgess@embecosm.com>
13315             Pedro Alves  <palves@redhat.com>
13316
13317         * infrun.c (fetch_inferior_event): Use scope_exit.
13318         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13319         * top.c (execute_command): Use scope_exit.
13320         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13321         * utils.c (do_bpstat_clear_actions_cleanup)
13322         (make_bpstat_clear_actions_cleanup): Remove.
13323
13324 2019-01-23  Tom Tromey  <tom@tromey.com>
13325             Pedro Alves  <palves@redhat.com>
13326
13327         * infrun.c: Include "common/scope-exit.h"
13328         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13329         (wait_for_inferior): Use SCOPE_EXIT.
13330         (fetch_inferior_event): Use scope_exit.
13331
13332 2019-01-23  Tom Tromey  <tom@tromey.com>
13333             Pedro Alves  <palves@redhat.com>
13334
13335         * breakpoint.c (create_breakpoint): Remove cleanup.
13336
13337 2019-01-23  Tom Tromey  <tom@tromey.com>
13338             Andrew Burgess  <andrew.burgess@embecosm.com>
13339             Pedro Alves  <palves@redhat.com>
13340
13341 2019-01-23  Pedro Alves  <palves@redhat.com>
13342
13343         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13344
13345 2019-01-23  Pedro Alves  <palves@redhat.com>
13346             Andrew Burgess  <andrew.burgess@embecosm.com>
13347
13348         * gdbthread.h: Include "common/forward-scope-exit.h".
13349         (scoped_finish_thread_state): Redefine custom class in terms of
13350         forward_scope_exit.
13351
13352 2019-01-23  Pedro Alves  <palves@redhat.com>
13353             Andrew Burgess  <andrew.burgess@embecosm.com>
13354
13355         * common/forward-scope-exit.h: New file.
13356
13357 2019-01-23  Pedro Alves  <palves@redhat.com>
13358             Andrew Burgess  <andrew.burgess@embecosm.com>
13359             Tom Tromey  <tom@tromey.com>
13360
13361         * common/scope-exit.h: New file.
13362
13363 2019-01-23  Pedro Alves  <palves@redhat.com>
13364
13365         * common/preprocessor.h (ESC): Rename to ...
13366         (ESC_PARENS): ... this.
13367         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13368         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13369
13370 2019-01-23  Tom Tromey  <tom@tromey.com>
13371
13372         * language.h (class scoped_switch_to_sym_language_if_auto):
13373         Initialize m_lang in both cases.
13374
13375 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13376
13377         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13378         with XCNEW.
13379
13380 2019-01-22  Tom Tromey  <tom@tromey.com>
13381
13382         * corelow.c: Do not include sys/file.h.
13383
13384 2019-01-22  Tom Tromey  <tom@tromey.com>
13385
13386         * tui/tui-wingeneral.h: Include gdb_curses.h.
13387
13388 2019-01-22  Tom Tromey  <tom@tromey.com>
13389
13390         * source-cache.h (class source_cache) <get_source_lines,
13391         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13392
13393 2019-01-22  Tom Tromey  <tom@tromey.com>
13394
13395         * remote-fileio.h (struct remote_target): Declare.
13396
13397 2019-01-22  Tom Tromey  <tom@tromey.com>
13398
13399         * python/py-arch.c: Do not include py-ref.h.
13400         * python/py-bpevent.c: Do not include py-ref.h.
13401         * python/py-cmd.c: Do not include py-ref.h.
13402         * python/py-continueevent.c: Do not include py-ref.h.
13403         * python/py-event.h: Do not include py-ref.h.
13404         * python/py-evtregistry.c: Do not include py-ref.h.
13405         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13406         * python/py-frame.c: Do not include py-ref.h.
13407         * python/py-framefilter.c: Do not include py-ref.h.
13408         * python/py-function.c: Do not include py-ref.h.
13409         * python/py-infevents.c: Do not include py-ref.h.
13410         * python/py-linetable.c: Do not include py-ref.h.
13411         * python/py-objfile.c: Do not include py-ref.h.
13412         * python/py-param.c: Do not include py-ref.h.
13413         * python/py-prettyprint.c: Do not include py-ref.h.
13414         * python/py-progspace.c: Do not include py-ref.h.
13415         * python/py-symbol.c: Do not include py-ref.h.
13416         * python/py-symtab.c: Do not include py-ref.h.
13417         * python/py-type.c: Do not include py-ref.h.
13418         * python/py-unwind.c: Do not include py-ref.h.
13419         * python/py-utils.c: Do not include py-ref.h.
13420         * python/py-value.c: Do not include py-ref.h.
13421         * python/py-varobj.c: Do not include py-ref.h.
13422         * python/py-xmethods.c: Do not include py-ref.h.
13423         * python/python.c: Do not include py-ref.h.
13424         * varobj.c: Do not include py-ref.h.
13425
13426 2019-01-22  Tom Tromey  <tom@tromey.com>
13427
13428         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13429         keyword for bcache.
13430
13431 2019-01-22  Tom Tromey  <tom@tromey.com>
13432
13433         * compile/compile-cplus-types.c: Remove a comment by #include.
13434
13435 2019-01-22  Tom Tromey  <tom@tromey.com>
13436
13437         * compile/gcc-c-plugin.h: Include compile-internal.h.
13438
13439 2019-01-22  Tom Tromey  <tom@tromey.com>
13440
13441         * stabsread.c (EXTERN): Do not define.
13442         (symnum, next_symbol_text_func, processing_gcc_compilation)
13443         (within_function, global_sym_chain, global_stabs)
13444         (previous_stab_code, this_object_header_files)
13445         (n_this_object_header_files)
13446         (n_allocated_this_object_header_files): Define.
13447         * stabsread.h (EXTERN): Never define.  Use "extern".
13448
13449 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13450
13451         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13452         history_value.
13453
13454 2019-01-21  Tom Tromey  <tom@tromey.com>
13455
13456         * ui-out.c: Fix includes.
13457         * tui/tui-source.c: Fix includes.
13458         * target.c: Fix includes.
13459         * remote.c: Fix includes.
13460         * regcache.c: Fix includes.
13461         * python/py-block.c: Fix includes.
13462         * printcmd.c: Fix includes.
13463         * or1k-tdep.c: Fix includes.
13464         * mi/mi-main.c: Fix includes.
13465         * m32r-tdep.c: Fix includes.
13466         * csky-tdep.c: Fix includes.
13467         * compile/compile-cplus-types.c: Fix includes.
13468         * cli/cli-interp.c: Fix includes.
13469
13470 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13471
13472         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13473         for padding.
13474
13475 2019-01-16  Tom Tromey  <tom@tromey.com>
13476
13477         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13478         earlier.
13479         (struct objfile) <msymbols_range>: Move from top level.
13480         <msymbols>: New method.
13481         (class objfile_msymbols): Remove.
13482         * symtab.c (default_collect_symbol_completion_matches_break_on):
13483         Update.
13484         * symmisc.c (dump_msymbols): Update.
13485         * stabsread.c (scan_file_globals): Update.
13486         * objc-lang.c (info_selectors_command, info_classes_command)
13487         (find_methods): Update.
13488         * minsyms.c (find_solib_trampoline_target): Update.
13489         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13490         * coffread.c (coff_symfile_read): Update.
13491         * ada-lang.c (ada_lookup_simple_minsym)
13492         (ada_collect_symbol_completion_matches): Update.
13493
13494 2019-01-16  Tom Tromey  <tom@tromey.com>
13495
13496         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13497         type.  Remove no-argument constructor.
13498         <iterator::operator++>: Simplify.
13499         <begin>: Update.
13500         <end>: Use minimal_symbol_count.
13501
13502 2019-01-16  Tom Tromey  <tom@tromey.com>
13503
13504         * objfiles.h (struct objfile) <psymtabs>: New method.
13505         (class objfile_psymtabs): Remove.
13506         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13507         typedef.
13508         <range>: New method.
13509         (require_partial_symbols): Change return type.
13510         * psymtab.c (require_partial_symbols)
13511         (psym_expand_symtabs_matching): Update.
13512         * mdebugread.c (parse_partial_symbols): Update.
13513         * dbxread.c (dbx_end_psymtab): Update.
13514
13515 2019-01-15  Tom Tromey  <tom@tromey.com>
13516
13517         * symtab.c (lookup_objfile_from_block)
13518         (lookup_symbol_in_objfile_symtabs)
13519         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13520         (find_line_symtab, info_sources_command)
13521         (default_collect_symbol_completion_matches_break_on)
13522         (make_source_files_completion_list): Update.
13523         * symmisc.c (print_objfile_statistics, dump_objfile)
13524         (maintenance_print_symbols, maintenance_info_symtabs)
13525         (maintenance_check_symtabs, maintenance_info_line_tables):
13526         Update.
13527         * source.c (select_source_symtab)
13528         (forget_cached_source_info_for_objfile): Update.
13529         * objfiles.h (class objfile_compunits): Remove.
13530         (struct objfile) <compunits_range>: New typedef.
13531         (compunits): New method.
13532         * objfiles.c (objfile_relocate1): Update.
13533         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13534         * maint.c (count_symtabs_and_blocks): Update.
13535         * linespec.c (iterate_over_all_matching_symtabs): Update.
13536         * cp-support.c (add_symbol_overload_list_qualified): Update.
13537         * coffread.c (coff_symtab_read): Update.
13538         * ada-lang.c (add_nonlocal_symbols)
13539         (ada_collect_symbol_completion_matches)
13540         (ada_add_global_exceptions): Update.
13541
13542 2019-01-15  Tom Tromey  <tom@tromey.com>
13543
13544         * progspace.h (program_space) <objfiles_safe_range>: New
13545         typedef.
13546         <objfiles_safe>: New method.
13547         * objfiles.h (class all_objfiles_safe): Remove.
13548         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13549         * jit.c (jit_inferior_exit_hook): Update.
13550
13551 2019-01-17  Tom Tromey  <tom@tromey.com>
13552
13553         * progspace.h (program_space) <objfiles_range>: New typedef.
13554         <objfiles>: New method.
13555         <objfiles_head>: Rename from objfiles.
13556         (object_files): Update.
13557         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13558         * guile/scm-pretty-print.c
13559         (ppscm_find_pretty_printer_from_objfiles): Update.
13560         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13561         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13562         Update.
13563         * python/py-progspace.c (pspy_get_objfiles): Update.
13564         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13565         Update.
13566         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13567         (objfpy_lookup_objfile_by_build_id): Update.
13568         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13569         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13570         Update.
13571         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13572         (expand_symtab_containing_pc, lookup_objfile_from_block)
13573         (lookup_static_symbol, basic_lookup_transparent_type)
13574         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13575         (find_line_symtab, info_sources_command)
13576         (default_collect_symbol_completion_matches_break_on)
13577         (make_source_files_completion_list, find_main_name): Update.
13578         * symmisc.c (print_symbol_bcache_statistics)
13579         (print_objfile_statistics, maintenance_print_symbols)
13580         (maintenance_print_msymbols, maintenance_print_objfiles)
13581         (maintenance_info_symtabs, maintenance_check_symtabs)
13582         (maintenance_expand_symtabs, maintenance_info_line_tables):
13583         Update.
13584         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13585         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13586         (map_overlay_command, unmap_overlay_command)
13587         (simple_overlay_update, expand_symtabs_matching)
13588         (map_symbol_filenames): Update.
13589         * symfile-debug.c (set_debug_symfile): Update.
13590         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13591         Update.
13592         * source.c (select_source_symtab, forget_cached_source_info):
13593         Update.
13594         * solib.c (solib_read_symbols): Update.
13595         * solib-spu.c (append_ocl_sos): Update.
13596         * psymtab.c (maintenance_print_psymbols)
13597         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13598         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13599         * printcmd.c (info_symbol_command): Update.
13600         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13601         Update.
13602         * objfiles.h (class all_objfiles): Remove.
13603         * objfiles.c (have_partial_symbols, have_full_symbols)
13604         (have_minimal_symbols, qsort_cmp, update_section_map)
13605         (shared_objfile_contains_address_p)
13606         (default_iterate_over_objfiles_in_search_order): Update.
13607         * objc-lang.c (info_selectors_command, info_classes_command)
13608         (find_methods): Update.
13609         * minsyms.c (find_solib_trampoline_target): Update.
13610         * maint.c (maintenance_info_sections)
13611         (maintenance_translate_address, count_symtabs_and_blocks):
13612         Update.
13613         * main.c (captured_main_1): Update.
13614         * linux-thread-db.c (try_thread_db_load_from_pdir)
13615         (has_libpthread): Update.
13616         * linespec.c (iterate_over_all_matching_symtabs)
13617         (search_minsyms_for_name): Update.
13618         * jit.c (jit_find_objf_with_entry_addr): Update.
13619         * hppa-tdep.c (find_unwind_entry)
13620         (hppa_lookup_stub_minimal_symbol): Update.
13621         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13622         Update.
13623         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13624         (elf_gnu_ifunc_resolve_by_got): Update.
13625         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13626         * dwarf-index-write.c (save_gdb_index_command): Update.
13627         * cp-support.c (add_symbol_overload_list_qualified): Update.
13628         * breakpoint.c (create_overlay_event_breakpoint)
13629         (create_longjmp_master_breakpoint)
13630         (create_std_terminate_master_breakpoint)
13631         (create_exception_master_breakpoint): Update.
13632         * blockframe.c (find_pc_partial_function): Update.
13633         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13634         (ada_collect_symbol_completion_matches)
13635         (ada_add_global_exceptions): Update.
13636
13637 2019-01-17  Tom Tromey  <tom@tromey.com>
13638
13639         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13640         declare VEC.
13641         (solib_target_parse_libraries): Change return type.
13642         (library_list_start_segment, library_list_start_section)
13643         (library_list_end_library, library_list_start_library); Update.
13644         (solib_target_free_library_list): Remove.
13645         (solib_target_parse_libraries): Remove cleanup.  Change return
13646         type.
13647         (solib_target_current_sos): Update.
13648
13649 2019-01-17  Tom Tromey  <tromey@bapiya>
13650
13651         * valprint.c: Replace "the the" with "the".
13652         * symtab.c: Replace "the the" with "the".
13653         * solib.c: Replace "the the" with "the".
13654         * solib-dsbt.c: Replace "the the" with "the".
13655         * linespec.c: Replace "the the" with "the".
13656         * dwarf2loc.h: Replace "the the" with "the".
13657         * amd64-windows-tdep.c: Replace "the the" with "the".
13658         * aarch64-tdep.c: Replace "the the" with "the".
13659
13660 2019-01-16  Keith Seitz  <keiths@redhat.com>
13661
13662         PR gdb/23773
13663         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13664         <builder>: Rename to ..
13665         <m_builder>: ... this and make private.
13666         (dwarf2_cu::get_builder): New method.  Change all users of
13667         `builder' to use this method.
13668         (dwarf2_start_symtab): Move to ...
13669         (dwarf2_cu::start_symtab): ... here.  Update all callers
13670         (setup_type_unit_groups): Move to ...
13671         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13672         callers.
13673         (dwarf2_cu::reset_builder): New method.
13674         (process_full_compunit, process_full_type_unit): Use
13675         dwarf2_cu::reset_builder.
13676         (follow_die_offset): Record the ancestor CU if it is different
13677         from the followed DIE's CU.
13678         (follow_die_sig_1): Likewise.
13679
13680 2019-01-15  Tom Tromey  <tom@tromey.com>
13681
13682         * remote.c (class remote_state) <buf>: Now a char_vector.
13683         <buf_size>: Remove.
13684         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13685         parameter.
13686         (remote_target::getpkt_or_notif_sane_1)
13687         (remote_target::getpkt_sane)
13688         (remote_target::getpkt_or_notif_sane): Likewise.
13689         (class remote_target) <putpkt>: New overload.
13690         (remote_target::read_frame): Change type of "buf_p".  Remove
13691         sizeof_p parameter.
13692         (packet_ok): New overload.
13693         (packet_check_result): New overload.
13694         Update all uses.
13695
13696 2019-01-14  Tom Tromey  <tom@tromey.com>
13697
13698         * remote-notif.c (handle_notification, remote_notif_ack)
13699         (remote_notif_parse): Make "buf" const.
13700         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13701         const.
13702         (remote_notif_parse, remote_notif_ack, handle_notification):
13703         Likewise.
13704         * remote.c (remote_notif_stop_parse): Make "buf" const.
13705         (remote_target::remote_parse_stop_reply): Make "buf" const.
13706         (remote_notif_stop_ack): Make "buf" const.
13707
13708 2019-01-14  Tom Tromey  <tom@tromey.com>
13709
13710         * remote.c (remote_console_output): Make parameter const.
13711
13712 2019-01-14  Tom Tromey  <tom@tromey.com>
13713
13714         * target-debug.h (target_debug_print_signals): Constify.
13715         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13716         * procfs.c (procfs_target::pass_signals): Update.
13717         * linux-nat.c (linux_nat_target::pass_signals): Update.
13718         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13719         * target-delegates.c: Rebuild.
13720         * remote.c (remote_target::program_signals): Update.
13721         (remote_target::pass_signals): Update.
13722         * target.c (target_pass_signals): Constify argument.
13723         (target_program_signals): Likewise.
13724         * target.h (struct target_ops) <pass_signals, program_signals>:
13725         Constify argument.
13726         (target_pass_signals, target_program_signals): Constify argument.
13727
13728 2019-01-14  Tom Tromey  <tom@tromey.com>
13729
13730         PR tui/28819:
13731         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13732
13733 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13734
13735         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13736         field.
13737         * rs6000-tdep.c: Include reggroups.h.
13738         (IS_V_ALIAS_PSEUDOREG): Define.
13739         (rs6000_register_name): Return names for the "vX" aliases.
13740         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13741         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13742         aliases.  Call default_register_reggroup_p for all other
13743         pseudo-registers.
13744         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13745         New functions.
13746         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13747         Handle "vX" aliases.
13748         (v_alias_pseudo_register_collect): New function.
13749         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13750         (rs6000_gdbarch_init): Initialize "vX" aliases as
13751         pseudo-registers.  Restore registration of
13752         rs6000_pseudo_register_reggroup_p with
13753         set_tdesc_pseudo_register_reggroup_p.
13754
13755 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13756
13757         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13758         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13759         set_gdbarch_num_pseudo_regs.
13760
13761 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13762
13763         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13764         Remove arg prefixname, add do_set and do_show.
13765         Add member functions set_list and show_list.
13766         * cli/cli-style.c (class cli_style_option): Update accordingly.
13767         (style_set_list): Move to file scope.
13768         (style_show_list): Likewise.
13769         (set_style): Call help_list.
13770         (show_style): Call cmd_show_list.
13771         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13772         Update to use the new macro.
13773
13774 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13775
13776         * ada-lang.c (_initialize_ada_language): Expand the help text
13777         for the "catch exception" command.
13778
13779 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13780
13781         * symtab.c (matching_obj_sections): Initialize obj,
13782         declare it closer to its usage.
13783
13784 2019-01-10  Tom Tromey  <tom@tromey.com>
13785
13786         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13787         (basic_inf_threads_range): Remove.
13788         (inf_threads_range, inf_non_exited_threads_range)
13789         (safe_inf_threads_range): Use next_adapter.
13790
13791 2019-01-10  Keith Seitz  <keiths@redhat.com>
13792
13793         PR gdb/23712
13794         PR symtab/23010
13795         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13796         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13797
13798 2019-01-10  Keith Seitz  <keiths@redhat.com>
13799
13800         PR gdb/23712
13801         PR symtab/23010
13802         * dictionary.c (pending_to_vector): Remove.
13803         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13804         Remove _1 suffix, replacing functions of the same name.  Update
13805         all callers.
13806         (dict_create_hashed, dict_create_hashed_expandable)
13807         (dict_create_linear, dict_create_linear_expandable, dict_free)
13808         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13809         Make functions static.
13810
13811 2019-01-10  Keith Seitz  <keiths@redhat.com>
13812
13813         PR gdb/23712
13814         PR symtab/23010
13815         * dictionary.h (struct dictionary): Replace declaration with
13816         multidictionary.
13817         (dict_create_hashed, dict_create_hashed_expandable)
13818         (dict_create_linear, dict_create_linear_expandable)
13819         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13820         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13821         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13822         taking multidictionary argument.
13823         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13824         * block.h (struct block) <dict>: Change to multidictionary
13825         and rename `multidict'.
13826         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13827         symmisc.c: Update all dictionary references to multidictionary.
13828
13829 2019-01-10  Keith Seitz  <keiths@redhat.com>
13830
13831         PR gdb/23712
13832         PR symtab/23010
13833         * dictionary.c: Include unordered_map.
13834         (pending_to_vector): New function.
13835         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13836         Rewrite the non-"_1" functions to take vector instead
13837         of linked list.
13838         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13839         "new" _1 versions of the same name.
13840         (multidictionary): Define.
13841         (std::hash<enum language): New definition.
13842         (collate_pending_symbols_by_language, mdict_create_hashed)
13843         (mdict_create_hashed_expandable, mdict_create_linear)
13844         (mdict_create_linear_expandable, mdict_free)
13845         (find_language_dictionary, create_new_language_dictionary)
13846         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13847         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13848         (mdict_size, mdict_empty): New functions.
13849         * dictionary.h (mdict_iterator): Define.
13850
13851 2019-01-10  Pedro Alves  <palves@redhat.com>
13852
13853         * breakpoint.c (read_uploaded_action)
13854         (create_tracepoint_from_upload): Adjust to use
13855         gdb::unique_xmalloc_ptr.
13856         * ctf.c (ctf_write_uploaded_tp):
13857         (SET_ARRAY_FIELD): Use emplace_back.
13858         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13859         * tracefile-tfile.c (tfile_write_uploaded_tp):
13860         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13861         gdb::unique_xmalloc_ptr.
13862         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13863         at_string, cond_string, cmd_strings>: Replace char pointers
13864         with gdb::unique_xmalloc_ptr.
13865
13866 2019-01-10  Pedro Alves  <palves@redhat.com>
13867
13868         * solib-target.c (library_list_start_library): Don't xstrdup name.
13869
13870 2019-01-10  Pedro Alves  <palves@redhat.com>
13871
13872         * mdebugread.c (parse_partial_symbols): Use
13873         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13874
13875 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13876
13877         * linux-fork.c (scoped_switch_fork_info)
13878         <~scoped_switch_fork_info>: Fix incorrect variable name.
13879
13880 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13881
13882         * linux-fork.c (scoped_switch_fork_info)
13883         <scoped_switch_fork_info>: Make explicit.
13884         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13885
13886 2019-01-10  Tom Tromey  <tom@tromey.com>
13887
13888         * objfiles.h (objfile::reset_psymtabs): Update.
13889         * objfiles.c (objfile::objfile): Update.
13890         * psymtab.h (psymtab_storage::obstack): Update.
13891         (psymtab_storage::m_obstack): Use gdb::optional.
13892         (class psymtab_storage): Update comment.  Remove objfile
13893         parameter.
13894         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13895
13896 2019-01-10  Tom Tromey  <tom@tromey.com>
13897
13898         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13899         <free_psymtabs>: Now private.
13900         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13901         (allocate_psymtab): Use new method.
13902
13903 2019-01-10  Tom Tromey  <tom@tromey.com>
13904
13905         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13906         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13907         * mdebugread.c (parse_partial_symbols): Use
13908         allocate_dependencies.
13909         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13910         allocate_dependencies.
13911         (process_psymtab_comp_unit_reader)
13912         (build_type_psymtab_dependencies): Likewise.
13913         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13914
13915 2019-01-10  Tom Tromey  <tom@tromey.com>
13916
13917         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13918         PSYMBOL_SET_LANGUAGE.
13919         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13920
13921 2019-01-10  Tom Tromey  <tom@tromey.com>
13922
13923         * psymtab.h (psymtab_storage::obstack): New method.
13924         <m_obstack>: Rename from obstack; now private.
13925         * psymtab.c (psymtab_storage): Update.
13926         * dwarf2read.c (create_addrmap_from_index)
13927         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13928         Update.
13929
13930 2019-01-10  Tom Tromey  <tom@tromey.com>
13931
13932         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13933         * objfiles.h (objfile::reset_psymtabs): New method.
13934
13935 2019-01-10  Tom Tromey  <tom@tromey.com>
13936
13937         * symmisc.c (print_symbol_bcache_statistics): Update.
13938         (print_objfile_statistics): Update.
13939         * symfile.c (reread_symbols): Update.
13940         * psymtab.h (class psymtab_storage): New.
13941         * psymtab.c (psymtab_storage): New constructor.
13942         (~psymtab_storage): New destructor.
13943         (require_partial_symbols): Update.
13944         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13945         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13946         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13947         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13948         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13949         (start_psymtab_common, end_psymtab_common)
13950         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13951         (allocate_psymtab): Update.
13952         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13953         Update.
13954         (dump_psymtab_addrmap, maintenance_print_psymbols)
13955         (maintenance_check_psymtabs): Update.
13956         (class objfile_psymtabs): Move to objfiles.h.
13957         * psympriv.h (discard_psymtab): Now inline.
13958         (psymtab_discarder::psymtab_discarder): Update.
13959         (psymtab_discarder::~psymtab_discarder): Update.
13960         (ALL_OBJFILE_PSYMTABS): Rewrite.
13961         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13962         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13963         Remove fields.
13964         <partial_symtabs>: New field.
13965         (class objfile_psymtabs): Move from psymtab.h.  Update.
13966         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13967         psymbol_cache.
13968         (objfile::~objfile): Don't destroy psymbol_cache.
13969         * mdebugread.c (parse_partial_symbols): Update.
13970         * dwarf2read.c (create_addrmap_from_index)
13971         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13972         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13973         (add_partial_subprogram, dwarf2_ranges_read): Update.
13974         * dwarf-index-write.c (write_address_map)
13975         (write_one_signatured_type, recursively_write_psymbols)
13976         (class debug_names, class debug_names, write_psymtabs_to_index):
13977         Update.
13978
13979 2019-01-10  Tom Tromey  <tom@tromey.com>
13980
13981         * symtab.h (SYMBOL_SET_NAMES): Update.
13982         (symbol_set_names): Update.
13983         (MSYMBOL_SET_NAMES): Update.
13984         * symtab.c (symbol_set_names): Change argument to be an
13985         objfile_per_bfd_storage.
13986         * psymtab.c (add_psymbol_to_bcache): Update.
13987         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13988
13989 2019-01-10  Tom Tromey  <tom@tromey.com>
13990
13991         * symtab.c (create_demangled_names_hash): Change argument to be an
13992         objfile_per_bfd_storage.
13993         (symbol_set_names): Update.
13994
13995 2019-01-10  Tom Tromey  <tom@tromey.com>
13996
13997         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13998         init_psymbol_list.
13999         * psymtab.c (init_psymbol_list): Do nothing if already called.
14000         * psympriv.h (init_psymbol_list): Add comment.
14001         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14002         init_psymbol_list.
14003         * dbxread.c (dbx_symfile_read): Unconditionally call
14004         init_psymbol_list.
14005
14006 2019-01-10  Tom Tromey  <tom@tromey.com>
14007
14008         * xcoffread.c (scan_xcoff_symtab): Update.
14009         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14010         "where".
14011         * mdebugread.c (parse_partial_symbols)
14012         (handle_psymbol_enumerators): Update.
14013         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14014         * dbxread.c (read_dbx_symtab): Update.
14015         * psympriv.h (psymbol_placement): New enum.
14016         (add_psymbol_to_list): Update.
14017
14018 2019-01-10  Tom Tromey  <tom@tromey.com>
14019
14020         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14021         static_psymbols parameters.
14022         (scan_xcoff_symtab): Update.
14023         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14024         static_psymbols parameters.
14025         * psympriv.h (start_psymtab_common): Update.
14026         * mdebugread.c (parse_partial_symbols): Update.
14027         * dwarf2read.c (create_partial_symtab): Update.
14028         * dbxread.c (read_dbx_symtab): Update.
14029         (start_psymtab): Remove global_psymbols and static_psymbols
14030         parameters.
14031
14032 2019-01-10  Tom Tromey  <tom@tromey.com>
14033
14034         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14035         * psymtab.c (allocate_psymtab): Add comment.
14036         * psympriv.h (allocate_psymtab): Add comment.
14037         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14038         initializations.
14039         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14040
14041 2019-01-10  Tom Tromey  <tom@tromey.com>
14042
14043         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14044         Don't declare.
14045         * mipsread.c: Include mdebugread.h.
14046         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14047         Declare.
14048         * elfread.c: Include mdebugread.h.
14049
14050 2019-01-09  Tom Tromey  <tom@tromey.com>
14051
14052         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14053         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14054         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14055         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14056         (psym_lookup_symbol, psym_find_last_source_symtab)
14057         (psym_forget_cached_source_info, psym_print_stats)
14058         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14059         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14060         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14061         (psym_find_compunit_symtab_by_address)
14062         (maintenance_print_psymbols, maintenance_info_psymtabs)
14063         (maintenance_check_psymtabs): Use ranged for.
14064         * psymtab.h (class objfile_psymtabs): New.
14065         (require_partial_symbols): Return objfile_psymtabs.
14066         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14067
14068 2019-01-09  Tom Tromey  <tom@tromey.com>
14069
14070         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14071         (find_pc_mapped_section, list_overlays_command)
14072         (map_overlay_command, unmap_overlay_command)
14073         (simple_overlay_update): Use all_objfiles.
14074         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14075         * printcmd.c (info_symbol_command): Use all_objfiles.
14076         * objfiles.h (ALL_OBJSECTIONS): Remove.
14077         * maint.c (maintenance_translate_address): Use all_objfiles.
14078         * gcore.c (gcore_create_callback): Use all_objfiles.
14079         (objfile_find_memory_regions): Likewise.
14080
14081 2019-01-09  Tom Tromey  <tom@tromey.com>
14082
14083         * symtab.c (find_line_symtab, info_sources_command)
14084         (make_source_files_completion_list): Use objfile_compunits.
14085         * source.c (select_source_symtab): Use objfile_compunits.
14086         * objfiles.h (struct objfile): Update comment.
14087         (ALL_OBJFILES): Remove.
14088         (ALL_FILETABS): Remove.
14089         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14090         objfile_compunits.
14091
14092 2019-01-09  Tom Tromey  <tom@tromey.com>
14093
14094         * symmisc.c (print_objfile_statistics, dump_objfile)
14095         (maintenance_print_symbols): Use compunit_filetabs.
14096         * source.c (forget_cached_source_info_for_objfile): Use
14097         compunit_filetabs.
14098         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14099         (ALL_FILETABS): Use compunit_filetabs.
14100         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14101         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14102
14103 2019-01-09  Tom Tromey  <tom@tromey.com>
14104
14105         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14106         (compunit_filetabs): New.
14107         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14108         compunit_filetabs.
14109         (info_sources_command, make_source_files_completion_list): Remove
14110         declaration.
14111         * symmisc.c (print_objfile_statistics, dump_objfile)
14112         (maintenance_print_symbols): Remove declaration.
14113         (maintenance_info_symtabs): Use compunit_filetabs.
14114         (maintenance_info_line_tables): Likewise.
14115         * source.c (select_source_symtab): Change local variable name.
14116         (forget_cached_source_info_for_objfile): Remove declaration.
14117         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14118         * objfiles.c (objfile_relocate1): Remove declaration.
14119         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14120         declaration.
14121         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14122         * coffread.c (coff_symtab_read): Remove declaration.
14123         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14124         compunit_filetabs.
14125
14126 2019-01-09  Tom Tromey  <tom@tromey.com>
14127
14128         * symtab.c (lookup_objfile_from_block)
14129         (find_pc_sect_compunit_symtab, search_symbols)
14130         (default_collect_symbol_completion_matches_break_on): Use
14131         objfile_compunits.
14132         * objfiles.h (ALL_COMPUNITS): Remove.
14133         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14134         * cp-support.c (add_symbol_overload_list_qualified): Use
14135         objfile_compunits.
14136         * ada-lang.c (ada_collect_symbol_completion_matches)
14137         (ada_add_global_exceptions): Use objfile_compunits.
14138
14139 2019-01-09  Tom Tromey  <tom@tromey.com>
14140
14141         * source.c (select_source_symtab)
14142         (forget_cached_source_info_for_objfile): Remove declaration.
14143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14144         declaration.
14145         * maint.c (count_symtabs_and_blocks): Remove declaration.
14146         * cp-support.c (add_symbol_overload_list_qualified): Remove
14147         declaration.
14148         * coffread.c (coff_symtab_read): Remove declaration.
14149         * symtab.c (lookup_symbol_in_objfile_symtabs)
14150         (basic_lookup_transparent_type_1): Use objfile_compunits.
14151         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14152         (info_sources_command, search_symbols)
14153         (default_collect_symbol_completion_matches_break_on)
14154         (make_source_files_completion_list): Remove declaration.
14155         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14156         (ada_collect_symbol_completion_matches)
14157         (ada_add_global_exceptions): Remove declaration.
14158         * linespec.c (iterate_over_all_matching_symtabs): Use
14159         objfile_compunits.
14160         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14161         (class objfile_compunits): New.
14162         (ALL_COMPUNITS): Use objfile_compunits.
14163         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14164         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14165         objfile_compunits.
14166         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14167
14168 2019-01-09  Tom Tromey  <tom@tromey.com>
14169
14170         * symtab.c (search_symbols)
14171         (default_collect_symbol_completion_matches_break_on): Use
14172         objfile_msymbols.
14173         * ada-lang.c (ada_lookup_simple_minsym)
14174         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14175         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14176         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14177         objfile_msymbols.
14178         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14179         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14180         * objc-lang.c (find_methods): Use objfile_msymbols.
14181         (info_selectors_command, info_classes_command): Likewise.
14182         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14183         * objfiles.h (class objfile_msymbols): New.
14184         (ALL_OBJFILE_MSYMBOLS): Remove.
14185         (ALL_MSYMBOLS): Remove.
14186
14187 2019-01-09  Tom Tromey  <tom@tromey.com>
14188
14189         * common/next-iterator.h (next_adapter): Add Iterator template
14190         parameter.
14191         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14192         (class all_objfiles_safe): New.
14193         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14194         * objfiles.c (put_objfile_before): Update comment.
14195         (add_separate_debug_objfile): Likewise.
14196         (free_all_objfiles): Use all_objfiles_safe.
14197         (objfile_purge_solibs): Likewise.
14198
14199 2019-01-09  Tom Tromey  <tom@tromey.com>
14200
14201         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14202         (expand_symtab_containing_pc, lookup_static_symbol)
14203         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14204         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14205         all_objfiles.
14206         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14207         * breakpoint.c (create_overlay_event_breakpoint)
14208         (create_longjmp_master_breakpoint)
14209         (create_std_terminate_master_breakpoint)
14210         (create_exception_master_breakpoint): Use all_objfiles.
14211         * linux-thread-db.c (try_thread_db_load_from_pdir)
14212         (has_libpthread): Use all_objfiles.
14213         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14214         * linespec.c (iterate_over_all_matching_symtabs)
14215         (search_minsyms_for_name): Use all_objfiles.
14216         * maint.c (maintenance_info_sections): Use all_objfiles.
14217         * main.c (captured_main_1): Use all_objfiles.
14218         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14219         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14220         * guile/scm-pretty-print.c
14221         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14222         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14223         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14224         (maintenance_print_msymbols): Use all_objfiles.
14225         * source.c (select_source_symtab): Use all_objfiles.
14226         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14227         * symfile.c (remove_symbol_file_command)
14228         (expand_symtabs_matching, map_symbol_filenames): Use
14229         all_objfiles.
14230         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14231         all_objfiles.
14232         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14233         * objc-lang.c (find_methods): Use all_objfiles.
14234         * objfiles.c (have_partial_symbols, have_full_symbols)
14235         (have_minimal_symbols, qsort_cmp)
14236         (default_iterate_over_objfiles_in_search_order): Use
14237         all_objfiles.
14238         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14239         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14240         (maintenance_check_psymtabs): Use all_objfiles.
14241         (ALL_PSYMTABS): Remove.
14242         * compile/compile-object-run.c (do_module_cleanup): Use
14243         all_objfiles.
14244         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14245         * cp-support.c (add_symbol_overload_list_qualified): Use
14246         all_objfiles.
14247         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14248         Use all_objfiles.
14249         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14250         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14251         all_objfiles.
14252         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14253         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14254         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14255         Uses all_objfiles.
14256         * solib.c (solib_read_symbols): Use all_objfiles
14257
14258 2019-01-09  Tom Tromey  <tom@tromey.com>
14259
14260         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14261         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14262         all_objfiles.
14263         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14264         * symmisc.c (print_symbol_bcache_statistics)
14265         (print_objfile_statistics, maintenance_print_objfiles)
14266         (maintenance_info_symtabs, maintenance_check_symtabs)
14267         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14268         all_objfiles.
14269         * source.c (forget_cached_source_info): Use all_objfiles.
14270         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14271         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14272         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14273         * objfiles.c (update_section_map): Use all_objfiles.
14274         (shared_objfile_contains_address_p): Likewise.
14275         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14276         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14277
14278 2019-01-09  Tom Tromey  <tom@tromey.com>
14279
14280         * common/next-iterator.h: New file.
14281         * objfiles.h (class all_objfiles): New.
14282         (struct objfile_iterator): New.
14283
14284 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14285
14286         * NEWS: Move the description of the changed "frame", "select-frame",
14287          and "info frame" commands to the Changed commands section.
14288
14289 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14290
14291         * gdbtypes.c (check_stub_method_group): Remove handling of old
14292         mangling schemes.
14293         * linespec.c (find_methods): Likewise.
14294         * stabsread.c (read_member_functions): Likewise.
14295         * valops.c (search_struct_method): Likewise.
14296         (value_struct_elt_for_reference): Likewise.
14297         * NEWS: Mention this change.
14298
14299 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14300
14301         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14302         print_source_lines.
14303         * source.c (print_source_lines_base): Update line number check.
14304         (print_source_lines): New function.
14305         (source_lines_range::source_lines_range): New function.
14306         * source.h (class source_lines_range): New class.
14307         (print_source_lines): New declaration.
14308
14309 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14310
14311         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14312
14313 2019-01-08  Tom Tromey  <tom@tromey.com>
14314             Simon Marchi  <simon.marchi@ericsson.com>
14315
14316         PR gdb/24060
14317         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14318         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14319         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14320         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14321         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14322         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14323
14324 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14325
14326         * source.c (select_source_symtab): Move header comment to
14327         declaration in source.h.
14328         (forget_cached_source_info_for_objfile): Likewise.
14329         (forget_cached_source_info): Likewise.
14330         (identify_source_line): Likewise.
14331         * source.h (identify_source_line): Move declaration from symtab.h
14332         and add comment from source.c
14333         (print_source_lines): Likewise.
14334         (forget_cached_source_info_for_objfile): Likewise.
14335         (forget_cached_source_info): Likewise.
14336         (select_source_symtab): Likewise.
14337         (enum print_source_lines_flag): Move definition from symtab.h.
14338         * symtab.h (identify_source_line): Move declaration to source.h.
14339         (print_source_lines): Likewise.
14340         (forget_cached_source_info_for_objfile): Likewise.
14341         (forget_cached_source_info): Likewise.
14342         (select_source_symtab): Likewise.
14343         (enum print_source_lines_flag): Move definition to source.h.
14344         * tui/tui-hooks.c: Add 'source.h' include.
14345
14346 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14347
14348         * source.c (print_source_lines_base): Handle requests to print
14349         reverse line number sequences, and guard against empty lines
14350         string.
14351
14352 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14353
14354         * source.c (print_source_lines_base): Fix skip of '\r' if next
14355         character is '\n'.
14356
14357 2019-01-06  Tom Tromey  <tom@tromey.com>
14358
14359         * c-exp.y (struct c_parse_state) <macro_original_text,
14360         expansion_obstack>: New member.
14361         (macro_original_text, expansion_obstack): Remove globals.
14362         (scan_macro_expansion, scanning_macro_expansion)
14363         (finished_macro_expansion): Update.
14364         (scan_macro_cleanup): Remove.
14365         (yylex, c_parse): Update.
14366
14367 2019-01-06  Tom Tromey  <tom@tromey.com>
14368
14369         * c-exp.y (struct c_parse_state) <strings>: New member.
14370         (operator_stoken): Update.
14371
14372 2019-01-06  Tom Tromey  <tom@tromey.com>
14373
14374         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14375         (union type_stack_elt) <typelist_val>: Now a pointer to
14376         std::vector.
14377         (type_stack_cleanup): Don't declare.
14378         (push_typelist): Update.
14379         * parse.c (pop_typelist): Return a std::vector.
14380         (push_typelist): Take a std::vector.
14381         (follow_types): Update.  Do not free args.
14382         (type_stack_cleanup): Remove.
14383         * c-exp.y (struct c_parse_state): New.
14384         (cpstate): New global.
14385         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14386         (nonempty_typelist): Update.
14387         (func_mod): Create a new vector.
14388         (c_parse): Create a c_parse_state.
14389         (check_parameter_typelist): Do not delete params.
14390         (function_method): Update.  Do not delete type_list.
14391
14392 2019-01-06  Tom Tromey  <tom@tromey.com>
14393
14394         PR gdb/28155:
14395         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14396         check_typedef.
14397         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14398         (print_return_value): Likewise.
14399
14400 2019-01-05  Tom Tromey  <tom@tromey.com>
14401
14402         * contrib/cleanup_check.py: Remove.
14403         * contrib/gcc-with-excheck: Remove.
14404         * contrib/exsummary.py: Remove.
14405         * contrib/excheck.py: Remove.
14406
14407 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14408
14409         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14410         NULL. Initialize tpprev to NULL instead of assigning it
14411         to NULL on the next statement.
14412         * windows-nat.c (windows_delete_thread): Remove check for
14413         main_thread_id before printing thread exit notifications.
14414         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14415         Remove thread ID check against main_thread_id.
14416         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14417         windows_delete_thread.
14418         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14419
14420 2019-01-04  Tom Tromey  <tom@tromey.com>
14421
14422         * compile/compile.c (_initialize_compile): Use upper case for
14423         metasyntactic variables.
14424         * symmisc.c (_initialize_symmisc): Use upper case for
14425         metasyntactic variables.
14426         * psymtab.c (_initialize_psymtab): Use upper case for
14427         metasyntactic variables.
14428         * demangle.c (demangle_command): Use upper case for metasyntactic
14429         variables.
14430         (_initialize_demangler): Likewise.
14431         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14432         variables.
14433
14434 2019-01-03  Tom Tromey  <tom@tromey.com>
14435
14436         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14437
14438 2019-01-03  Tom Tromey  <tom@tromey.com>
14439
14440         * python/py-symtab.c (salpy_str): Update.
14441         (struct salpy_sal_object) <symtab>: Now a PyObject.
14442         (salpy_dealloc): Update.
14443         (del_objfile_sal): Use gdbpy_ref.
14444
14445 2019-01-03  Tom Tromey  <tom@tromey.com>
14446
14447         * python/py-type.c (convert_field): Use new_reference.  Return
14448         gdbpy_ref.
14449         (make_fielditem): Return gdbpy_ref.
14450         (typy_fields): Update.
14451         (typy_getitem): Update.
14452         (field_name): Return gdbpy_ref.  Use new_reference.
14453         (typy_iterator_iternext): Update.
14454
14455 2019-01-03  Tom Tromey  <tom@tromey.com>
14456
14457         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14458
14459 2019-01-03  Tom Tromey  <tom@tromey.com>
14460
14461         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14462         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14463         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14464         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14465         (pspy_set_type_printers): Likewise.
14466         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14467         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14468         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14469         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14470         (objfpy_set_type_printers): Likewise.
14471
14472 2019-01-03  Tom Tromey  <tom@tromey.com>
14473
14474         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14475         (gdbpy_print_stack): Use gdbpy_err_fetch.
14476         * python/python-internal.h (class gdbpy_err_fetch): New class.
14477         (class gdbpy_enter) <m_error_type, m_error_value,
14478         m_error_traceback>: Remove.
14479         <m_error>: New member.
14480         (gdbpy_exception_to_string): Don't declare.
14481         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14482         * python/py-value.c (convert_value_from_python): Use
14483         gdbpy_err_fetch.
14484         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14485         gdbpy_exception_to_string.
14486         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14487         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14488         gdbpy_err_fetch.
14489
14490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14491
14492         * linux-nat.c (delete_lwp_cleanup): Delete.
14493         (struct lwp_deleter): New struct.
14494         (lwp_info_up): New typedef.
14495         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14496         lwp_info_up.
14497
14498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14499
14500         * linux-fork.c (class scoped_switch_fork_info): New class.
14501         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14502
14503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14504
14505         * valops.c (find_overload_match): Remove use of null_cleanup, and
14506         calls to do_cleanups.
14507
14508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14509
14510         * compile/compile-cplus-types.c
14511         (compile_cplus_instance::decl_name): Handle changes to
14512         cp_func_name.
14513         * cp-support.c (cp_func_name): Update header comment, update
14514         return type.
14515         * cp-support.h (cp_func_name): Update return type in declaration.
14516         * valops.c (find_overload_match): Move temp_func local to top
14517         level of function and change its type.  Use temp_func to hold and
14518         delete temporary string obtained from cp_func_name.
14519
14520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14521
14522         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14523         gdb::char_vector, remove cleanup, and update uses of `msg`.
14524
14525 2019-01-03  Jim Wilson  <jimw@sifive.com>
14526
14527         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14528
14529 2019-01-02  Tom Tromey  <tom@tromey.com>
14530
14531         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14532         (tdesc_parse_xml): Remove cleanups.
14533         * target-descriptions.h (make_cleanup_free_target_description):
14534         Don't declare.
14535         (target_desc_deleter): New struct.
14536         (target_desc_up): New typedef.
14537         * target-descriptions.c (target_desc_deleter::operator()): Rename
14538         from free_target_description.
14539         (make_cleanup_free_target_description): Remove.
14540
14541 2019-01-02  Tom Tromey  <tom@tromey.com>
14542
14543         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14544         constructor, destructor.
14545         (linespec_parser): Remove typedef.
14546         (~linespec_parser): Rename from linespec_parser_delete.
14547         (linespec_lex_to_end, linespec_complete_label)
14548         (linespec_complete): Update.
14549         (decode_line_full): Remove cleanups.
14550         (decode_line_1): Update.
14551
14552 2019-01-02  Tom Tromey  <tom@tromey.com>
14553
14554         * python/python-internal.h (inferior_to_inferior_object): Change
14555         return type.
14556         * python/py-exitedevent.c (create_exited_event_object): Update.
14557         * python/py-inferior.c (inferior_to_inferior_object): Return
14558         gdbpy_ref.
14559         (python_new_inferior, python_inferior_deleted)
14560         (thread_to_thread_object, delete_thread_object)
14561         (build_inferior_list, gdbpy_selected_inferior): Update.
14562         * python/py-infthread.c (create_thread_object): Update.  Also fail
14563         if inferior_to_inferior_object fails.
14564
14565 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14566
14567         * inferior.h (class inferior) <displaced_step_state>: New field.
14568         * infrun.h (struct displaced_step_state): Move here from
14569         infrun.c.  Initialize fields, add constructor.
14570         <inf>: Remove field.
14571         <reset>: New method.
14572         * infrun.c (struct displaced_step_inferior_state): Move to
14573         infrun.h.
14574         (displaced_step_inferior_states): Remove.
14575         (get_displaced_stepping_state): Adust.
14576         (displaced_step_in_progress_any_inferior): Adjust.
14577         (displaced_step_in_progress_thread): Adjust.
14578         (displaced_step_in_progress): Adjust.
14579         (add_displaced_stepping_state): Remove.
14580         (get_displaced_step_closure_by_addr): Adjust.
14581         (remove_displaced_stepping_state): Remove.
14582         (infrun_inferior_exit): Call displaced_step_state.reset.
14583         (use_displaced_stepping): Don't check for NULL.
14584         (displaced_step_prepare_throw): Call
14585         get_displaced_stepping_state.
14586         (displaced_step_fixup): Don't check for NULL.
14587         (prepare_for_detach): Don't check for NULL.
14588
14589 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14590
14591         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14592          in case of call that did not complete.
14593
14594 2019-01-02  Andrey Utkin  <autkin@undo.io>
14595
14596         * symfile.c (find_separate_debug_file): Fix search of debug files for
14597         remote debuggee.
14598
14599 2019-01-02  Tom Tromey  <tom@tromey.com>
14600
14601         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14602         indentation.
14603         * python/py-frame.c (frapy_older): Remove cast.
14604         (frapy_newer): Likewise.
14605         * python/py-breakpoint.c (local_setattro): Remove cast.
14606         * python/py-arch.c (archpy_name): Remove local variable.
14607         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14608
14609 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14610
14611         * unittests/basic_string_view/element_access/char/empty.cc:
14612         Fix year range in copyright header.
14613
14614 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14615
14616         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14617         Delete.
14618         <operator==>: Update with for removed field.
14619         <hash>: Likewise.
14620         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14621         <isa_features>: ...this.
14622         <abi_features>: New field.
14623         (riscv_isa_flen): Update comment.
14624         (riscv_abi_xlen): New declaration.
14625         (riscv_abi_flen): New declaration.
14626         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14627         isa_features.
14628         (riscv_abi_xlen): New function.
14629         (riscv_isa_flen): Update to get answer from isa_features.
14630         (riscv_abi_flen): New function.
14631         (riscv_has_fp_abi): Update to get answer from abi_features.
14632         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14633         xlen and flen.
14634         (riscv_call_info) <xlen, flen>: Update comment.
14635         (riscv_call_arg_struct): Remove invalid assertions
14636         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14637         is removed.
14638         (riscv_gdbarch_init): Gather isa features and abi features
14639         separately, ensure both match on the gdbarch when reusing an old
14640         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14641         a target with 64-bit float hardware.
14642
14643 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14644
14645         * source.c (search_command_helper): Stop reverse search
14646         when line 1 has been searched.
14647
14648 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14649
14650         * record-full.c (record_full_base_target::close): Rewrite
14651         record_full_core_buf_list free logic.
14652
14653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14654
14655         * break-catch-syscall.c (print_one_catch_syscall): xfree
14656         the last text.
14657
14658 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14659
14660         * top.c (print_gdb_version): Update Copyright year in version
14661         message.
14662
14663 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14664
14665         Update copyright year range in all GDB files.
14666
14667 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14668
14669         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14670
14671 For older changes see ChangeLog-2018.
14672 \f
14673 Local Variables:
14674 mode: change-log
14675 left-margin: 8
14676 fill-column: 74
14677 version-control: never
14678 coding: utf-8
14679 End:
14680