1 2019-08-06 Tom Tromey <tom@tromey.com>
3 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5 * typeprint.c (typedef_hash_table::find_global_typedef): Use
7 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
8 * stabsread.c (common_block_start): Use obstack_strdup.
9 * objfiles.c (set_objfile_main_name, objfile): Use
11 * namespace.c (add_using_directive): Use obstack_strdup.
12 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
13 * jit.c (finalize_symtab): Use obstack_strdup.
14 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
15 (guess_partial_die_structure_name, partial_die_info::fixup)
16 (dwarf2_name): Use obstack_strdup.
17 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
19 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
20 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
22 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
24 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
26 * unittests/help-doc-selftests.c: New file.
27 * Makefile.in: Add the new file.
29 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
31 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
32 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
33 the full first line, except when FOR_VALUE_PREFIX. In this case,
34 the trailing '.' is not output, and the first character is uppercased.
35 (print_help_for_command): Update call to print_doc_line.
36 (print_doc_of_command): Likewise.
37 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
38 * cli/cli-option.c (append_indented_doc): Do not append newline.
39 (build_help_option): Append newline after first appended_indented_doc
40 only if a second call is done.
41 (build_help): Append 2 new lines before each option, except the first
43 * compile/compile.c (_initialize_compile): Add new lines after
44 %OPTIONS%, when not at the end of the help.
45 Change help doc or code
46 producing the help doc to respect the invariants.
47 * maint-test-options.c (_initialize_maint_test_options): Likewise.
48 Also removed the new line after 'Options:', as all other commands
49 do not put an empty line between 'Options:' and the first option.
50 * printcmd.c (_initialize_printcmd): Likewise.
51 * stack.c (_initialize_stack): Likewise.
52 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
53 incorrectly telling COMMAND is optional.
54 * ada-lang.c (_initialize_ada_language): Change help doc or code
55 producing the help doc to respect the invariants.
56 * ada-tasks.c (_initialize_ada_tasks): Likewise.
57 * breakpoint.c (_initialize_breakpoint): Likewise.
58 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
59 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
60 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
61 * cli/cli-style.c (cli_style_option::add_setshow_commands,
62 _initialize_cli_style): Likewise.
63 * corelow.c (core_target_info): Likewise.
64 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
65 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
66 * filesystem.c (_initialize_filesystem): Likewise.
67 * frame.c (_initialize_frame): Likewise.
68 * gnu-nat.c (add_task_commands): Likewise.
69 * infcall.c (_initialize_infcall): Likewise.
70 * infcmd.c (_initialize_infcmd): Likewise.
71 * interps.c (_initialize_interpreter): Likewise.
72 * language.c (_initialize_language): Likewise.
73 * linux-fork.c (_initialize_linux_fork): Likewise.
74 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
75 * maint.c (_initialize_maint_cmds): Likewise.
76 * memattr.c (_initialize_mem): Likewise.
77 * printcmd.c (_initialize_printcmd): Likewise.
78 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
80 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
81 * record-btrace.c (_initialize_record_btrace): Likewise.
82 * record-full.c (_initialize_record_full): Likewise.
83 * record.c (_initialize_record): Likewise.
84 * regcache-dump.c (_initialize_regcache_dump): Likewise.
85 * regcache.c (_initialize_regcache): Likewise.
86 * remote.c (add_packet_config_cmd, init_remote_threadtests,
87 _initialize_remote): Likewise.
88 * ser-tcp.c (_initialize_ser_tcp): Likewise.
89 * serial.c (_initialize_serial): Likewise.
90 * skip.c (_initialize_step_skip): Likewise.
91 * source.c (_initialize_source): Likewise.
92 * stack.c (_initialize_stack): Likewise.
93 * symfile.c (_initialize_symfile): Likewise.
94 * symtab.c (_initialize_symtab): Likewise.
95 * target-descriptions.c (_initialize_target_descriptions): Likewise.
96 * top.c (init_main): Likewise.
97 * tracefile-tfile.c (tfile_target_info): Likewise.
98 * tracepoint.c (_initialize_tracepoint): Likewise.
99 * tui/tui-win.c (_initialize_tui_win): Likewise.
100 * utils.c (add_internal_problem_command): Likewise.
101 * valprint.c (value_print_option_defs): Likewise.
103 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
106 * configure.ac: Drop enable-libmcheck support.
107 * configure, config.in: Rebuild.
108 * libmcheck.m4: Remove.
109 * acinclude.m4: Don't include it.
110 * Makefile.in: Don't distribute it.
111 * top.c (print_gdb_configuration): Don't mention it.
113 2019-08-06 Tom Tromey <tom@tromey.com>
115 * utils.c (set_output_style): Sometimes pass stream to
117 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
118 * record-btrace.c (btrace_insn_history): Update.
119 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
121 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
123 <m_uiout>: New field.
125 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
126 Remove "uiout" parameter.
127 (dump_insns): Update.
128 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
129 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
131 2019-08-06 Christian Biesinger <cbiesinger@google.com>
133 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
134 (error_in_psymtab_expansion): Likewise.
135 (lookup_symbol_via_quick_fns): Likewise.
136 (basic_lookup_transparent_type_quick): Likewise.
137 (basic_lookup_transparent_type_1): Likewise.
139 2019-08-06 Tom Tromey <tromey@adacore.com>
141 * source.c (last_source_error): Now bool.
142 (print_source_lines_base): Make "noprint" bool. Only open
143 source file when last_source_visited changes.
145 2019-08-06 Tom Tromey <tromey@adacore.com>
147 * annotate.c (annotate_source_line): Use g_source_cache.
148 * source-cache.c (source_cache::get_plain_source_lines): Change
149 parameters. Populate m_offset_cache.
150 (source_cache::ensure): New method.
151 (source_cache::get_line_charpos): New method.
152 (extract_lines): Move lower. Change parameters.
153 (source_cache::get_source_lines): Move lower.
154 * source-cache.h (class source_cache): Update comment.
155 <get_line_charpos>: New method.
156 <get_source_lines>: Update comment.
157 <clear>: Clear m_offset_cache.
158 <get_plain_source_lines>: Change parameters.
160 <m_offset_cache>: New member.
161 * source.c (forget_cached_source_info_for_objfile): Update.
162 (info_source_command): Use g_source_cache.
163 (find_source_lines, open_source_file_with_line_charpos): Remove.
164 (print_source_lines_base, search_command_helper): Use g_source_cache.
165 * source.h (open_source_file_with_line_charpos): Don't declare.
166 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
167 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
170 2019-08-06 Tom Tromey <tromey@adacore.com>
172 * source-cache.c (source_cache::get_plain_source_lines):
173 Remove "first_line" and "last_line" parameters.
174 (source_cache::get_source_lines): Cache plain text.
175 * source-cache.h (class source_cache)
176 <get_plain_source_lines>: Update.
178 2019-08-06 Tom Tromey <tromey@adacore.com>
180 * source-cache.c (extract_lines): No longer a method.
181 Changed type of parameter. Include final newline.
182 (selftests::extract_lines_test): New function.
183 (_initialize_source_cache): Likewise.
184 * source-cache.h (class source_cache)
185 <extract_lines>: Don't declare.
187 2019-08-06 Tom Tromey <tromey@adacore.com>
189 * breakpoint.c (init_breakpoint_sal): Update.
190 (breakpoint): Update.
191 * breakpoint.h (struct breakpoint) <filter>: Now a
194 2019-08-05 Christian Biesinger <cbiesinger@google.com>
196 * NEWS: Mention dictionary access on blocks.
197 * python/py-block.c (blpy_getitem): New function.
198 (block_object_as_mapping): New struct.
199 (block_object_type): Use new struct for tp_as_mapping field.
201 2019-08-05 Christian Biesinger <cbiesinger@google.com>
203 * objfiles.h (objfile): Add a comment describing partial symbols.
205 2019-08-05 Tom Tromey <tromey@adacore.com>
207 * compile/compile.c (_initialize_compile): Use _(), not N_().
208 * thread.c (_initialize_thread): Use _(), not N_().
209 * stack.c (_initialize_stack): Use _(), not N_().
210 * printcmd.c (_initialize_printcmd): Use _(), not N_().
212 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
214 * dwarf2read.c (struct dw2_symtab_iterator):
215 <want_specific_block>: Remove.
216 <block_index>: Change type to gdb::optional.
217 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
218 change type of BLOCK_INDEX parameter to gdb::optional.
219 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
220 (dw2_lookup_symbol): Don't pass argument for
222 (dw2_expand_symtabs_for_function): Don't pass argument for
223 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
224 (class dw2_debug_names_iterator)
225 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
226 parameter, change BLOCK_INDEX type to gdb::optional.
227 <m_want_specific_block>: Remove.
228 <m_block_index>: Change type to gdb::optional.
229 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
230 gdb::optional. Re-write in function of gdb::optional.
231 (dw2_debug_names_lookup_symbol): Don't pass argument for
233 (dw2_debug_names_expand_symtabs_for_function): Don't pass
234 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
237 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
239 * NEWS: Mention changes to "info sources" command.
241 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
243 * symtab.c (filename_partial_match_opts): New struct type.
244 (struct output_source_filename_data): New members
245 regexp, c_regexp, partial_match.
246 (output_source_filename): Use new members to decide to print file.
247 (info_sources_option_defs): New variable.
248 (make_info_sources_options_def_group, print_info_sources_header,
249 info_sources_command_completer):
251 (info_sources_command): Read new optional arguments.
252 (_initialize_symtab): Update info sources help.
254 2019-08-02 Alexandre Oliva <oliva@adacore.com>
256 * ada-lang.c (exception_support_info_v0): Renamed from...
257 (default_exception_support_info): ... this. Create new
259 (ada_has_this_exception_support): Look up catch_handlers_sym.
260 (ada_exception_support_info_sniffer): Try v0 after default.
262 2019-08-01 Tom Tromey <tromey@adacore.com>
264 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
267 2019-08-01 Christian Biesinger <cbiesinger@google.com>
269 * s12z-tdep.c: Fix include path for s12z-opc.h.
271 2019-08-01 Alan Hayward <alan.hayward@arm.com>
273 * NEWS: Require GNU make 3.82.
275 2019-07-16 Tom Tromey <tom@tromey.com>
277 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
280 2019-07-30 Tom Tromey <tromey@adacore.com>
282 * block.c (contained_in): Remove BLOCK_FUNCTION check.
284 2019-07-30 Kevin Buettner <kevinb@redhat.com>
286 * printcmd.c (print_address_symbolic): Print negative offsets.
287 (build_address_symbolic): Force signed arithmetic when computing
290 2019-07-30 Christian Biesinger <cbiesinger@google.com>
292 PR/24474: Add a function to lookup static variables.
293 * NEWS: Mention this new function.
294 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
295 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
296 * python/python.c (python_GdbMethods): Add new function.
298 2019-07-29 Christian Biesinger <cbiesinger@google.com>
300 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
301 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
302 (objfpy_lookup_static_symbol): New function.
303 (objfile_object_methods): Add new functions.
305 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
307 * NEWS: Mention 'set|show print frame-info'. Mention new
308 'presence' value for 'frame-arguments'. Mention new '-frame-info'
309 backtrace argument. Mention that python frame filtering code
310 is now consistent with what 'backtrace' command prints.
312 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
314 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
316 (print_frame_info_auto, print_frame_info_source_line,
317 print_frame_info_location, print_frame_info_source_and_location,
318 print_frame_info_location_and_address, print_frame_info_short_location):
320 (struct frame_print_options): New member print_frame_info.
321 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
322 * stack.h (get_user_print_what_frame_info): New declaration.
323 (frame_show_address): New declaration.
324 * stack.c (print_frame_arguments_choices): New value 'presence'.
325 (print_frame_info_auto, print_frame_info_source_line,
326 print_frame_info_location, print_frame_info_source_and_location,
327 print_frame_info_location_and_address, print_frame_info_short_location,
328 print_frame_info_choices, print_frame_info_print_what): New definitions.
329 (print_frame_args): Only print dots for args if print frame-arguments
331 (frame_print_option_defs): New element for "frame-info".
332 (get_user_print_what_frame_info): New function.
333 (frame_show_address): Make non static. Move comment to stack.h.
334 (print_frame_info_to_print_what): New function.
335 (print_frame_info): Update comment. Use fp_opts.print_frame_info
336 to decide what to print.
337 (backtrace_command_1): Handle the new print_frame_arguments_presence
339 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
340 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
341 (py_print_frame): In non-mi mode, use LOCATION as default for
342 print_what, similarly to frame information printed directly by
343 backtrace command. Handle frame-info user option in non MI mode.
345 2019-07-27 Kevin Buettner <kevinb@redhat.com>
347 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
348 Add case for debugging 32-bit target on 64-bit host. Revise
351 2019-07-27 Kevin Buettner <kevinb@redhat.com>
353 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
354 instead of find_function_entry_range_from_pc.
356 2019-07-27 Kevin Buettner <kevinb@redhat.com>
358 * stack.c (find_frame_funname): Remove code which preferred
359 minsym over symtab sym in "certain pathological cases".
361 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
362 parameter. Change type of "do_demangle" to bool.
363 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
364 Pass suitable "prefer_sym_over_minsym" flag to
365 build_address_symbolic(). Don't output "+" for negative offsets.
366 * printcmd.c (print_address_symbolic): Update invocation of
367 build_address_symbolic to include a "prefer_sym_over_minsym"
369 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
370 Restrict cases in which use of minimal symbol is preferred to that
371 of a found symbol. Update comments.
373 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
374 for entry pc when entry pc is out of range for that FDE.
376 2019-07-26 Brian Callahan <bcallah@openbsd.org>
379 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
382 2019-07-25 Christian Biesinger <cbiesinger@google.com>
384 * python/py-objfile.c (add_separate_debug_file): Fix comment about
385 this function's Python signature.
388 2019-07-24 Christian Biesinger <cbiesinger@google.com>
390 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
391 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
392 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
393 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
394 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
397 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
399 * h8300-tdep.c (h8300_register_name_common): New.
400 h8300_register_name): Use h8300_register_name_common.
401 (h8300s_register_name): Likewise.
402 (h8300sx_register_name): Likewise.
403 (h8300h_register_nam): New.
404 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
407 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
409 * arm-tdep.c (arm_skip_cmse_entry): New function.
410 (arm_is_sgstubs_section): New function.
411 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
413 2019-07-22 Tom Tromey <tom@tromey.com>
415 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
418 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
420 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
423 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
425 * symtab.c (search_symbols): Adjust msymbol matching type arrays
426 so that GDB doesn't match any msymbols when searching in the
428 (print_symbol_info): Print using typedef_print or type_print based
429 on the type of the symbol. Add updated FIXME comment moved from...
430 (_initialize_symtab): ... move and update FIXME comment to above.
432 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
434 * NEWS: Mention adding -q option to "info types".
435 * symtab.c (struct info_types_options): New struct.
436 (info_types_options_defs): New variable.
437 (make_info_types_options_def_group): New function.
438 (info_types_command): Use gdb::option framework to parse options.
439 (info_types_command_completer): New function.
440 (_initialize_symtab): Extend the help text on "info types" and
441 register command completer.
443 2019-07-21 Christian Biesinger <cbiesinger@google.com>
445 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
446 (lookup_symbol_in_objfile): Change int to block_enum and add a
447 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
449 2019-07-20 Christian Biesinger <cbiesinger@google.com>
451 * MAINTAINERS (Write After Approval): Add self.
453 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
455 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
456 instruction to the dummy code region.
458 2019-07-19 Tom Tromey <tromey@adacore.com>
460 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
461 (ARGSUSED, PARAMS, __func__): Remove rules.
463 2019-07-19 Alan Hayward <alan.hayward@arm.com>
465 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
466 * features/arm/arm-with-iwmmxt.c: Remove.
467 * features/arm/arm-with-iwmmxt.xml: Remove.
468 * features/arm/arm-with-m-fpa-layout.c: Remove.
469 * features/arm/arm-with-m-fpa-layout.xml: Remove.
470 * features/arm/arm-with-m-vfp-d16.c: Remove.
471 * features/arm/arm-with-m-vfp-d16.xml: Remove.
472 * features/arm/arm-with-m.c: Remove.
473 * features/arm/arm-with-m.xml: Remove.
474 * features/arm/arm-with-neon.c: Remove.
475 * features/arm/arm-with-neon.xml: Remove.
476 * features/arm/arm-with-vfpv2.c: Remove.
477 * features/arm/arm-with-vfpv2.xml: Remove.
478 * features/arm/arm-with-vfpv3.c: Remove.
479 * features/arm/arm-with-vfpv3.xml: Remove.
481 2019-07-19 Alan Hayward <alan.hayward@arm.com>
483 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
485 2019-07-19 Alan Hayward <alan.hayward@arm.com>
487 * arch/aarch32.c (aarch32_create_target_description): Create
488 target descriptions using features.
489 * arch/arm.c (arm_create_target_description)
490 (arm_create_mprofile_target_description): Likewise.
491 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
493 2019-07-19 Alan Hayward <alan.hayward@arm.com>
495 * Makefile.in: Add new files.
496 * aarch32-tdep.c: New file.
497 * aarch32-tdep.h: New file.
498 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
499 Call aarch32_read_description.
500 * arch/aarch32.c: New file.
501 * arch/aarch32.h: New file.
502 * arch/arm.c (arm_create_target_description)
503 (arm_create_mprofile_target_description): New function.
504 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
505 (arm_create_target_description)
506 (arm_create_mprofile_target_description): New declaration.
507 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
508 read_description functions.
509 * arm-linux-nat.c (arm_linux_nat_target::read_description):
511 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
512 * arm-tdep.c (tdesc_arm_list): New variable.
513 (arm_register_g_packet_guesses): Call create description functions.
514 (arm_read_description) (arm_read_mprofile_description): New
516 * arm-tdep.h (arm_read_description)
517 (arm_read_mprofile_description): Add declaration.
518 * configure.tgt: Add new files.
520 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
522 * top.c (new_ui_command): Open specified terminal just once.
524 2019-07-18 Tom Tromey <tromey@adacore.com>
526 * symtab.c (main_name): Constify return type.
527 * symfile.c (set_initial_language): Update.
528 * symtab.h (main_name): Constify return type.
530 2019-07-17 Tom Tromey <tom@tromey.com>
532 * tui/tui-winsource.c (tui_update_source_window)
533 (tui_update_source_window_as_is)
534 (tui_update_source_windows_with_line): Remove return.
535 * tui/tui-disasm.c (tui_show_disassem)
536 (tui_show_disassem_and_update_source): Remove return.
537 * tui/tui.c (tui_reset): Remove return.
538 * tui/tui-wingeneral.c
539 (tui_check_and_display_highlight_if_needed): Remove return.
541 2019-07-17 Tom Tromey <tom@tromey.com>
543 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
545 2019-07-17 Tom Tromey <tom@tromey.com>
547 * tui/tui-winsource.h (struct tui_exec_info_window)
548 (struct tui_source_window_base): Move from tui-data.h.
549 * tui/tui-winsource.c: Move many method definitions from
550 elsewhere. Remove "structuring" comments.
551 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
552 (tui_source_window_base::refresh_window): Move to
554 * tui/tui-win.c (tui_source_window_base::refresh_all)
555 (tui_source_window_base::update_tab_width)
556 (tui_source_window_base::set_new_height)
557 (tui_source_window_base::do_make_visible_with_new_height): Move to
559 * tui/tui-source.h: Update.
560 * tui/tui-source.c (tui_source_window_base::reset): Move to
562 * tui/tui-disasm.h: Update.
563 * tui/tui-data.h (struct tui_exec_info_window): Move to
565 (struct tui_source_window_base): Likewise.
566 * tui/tui-data.c (tui_source_window_base::clear_detail)
567 (tui_source_window_base, ~tui_source_window_base): Move to
570 2019-07-17 Tom Tromey <tom@tromey.com>
572 * tui/tui-win.c (tui_resize_all)
573 (tui_source_window_base::update_tab_width)
574 (tui_adjust_win_heights): Update.
575 (tui_win_info::make_invisible_and_set_new_height): Rename from
576 make_invisible_and_set_new_height.
577 * tui/tui-data.h (struct tui_win_info)
578 <make_invisible_and_set_new_height>: New method.
580 2019-07-17 Tom Tromey <tom@tromey.com>
583 * tui/tui-source.h (struct tui_source_window): Move from
585 * tui/tui-layout.c: Update.
586 * tui/tui-disasm.c: Update.
587 * tui/tui-data.h (struct tui_source_window): Move to
590 2019-07-17 Tom Tromey <tom@tromey.com>
592 * tui/tui-disasm.h (struct tui_disasm_window): Move from
594 * tui/tui-data.h (struct tui_disasm_window): Move to
597 2019-07-17 Tom Tromey <tom@tromey.com>
599 * tui/tui-regs.h (struct tui_data_item_window): Move from
601 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
602 * tui/tui-data.h (struct tui_data_item_window): Move to
604 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
606 2019-07-17 Tom Tromey <tom@tromey.com>
609 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
610 (tui_cmd_window::max_height): Move to tui-command.c.
611 * tui/tui-layout.c: Update.
612 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
613 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
615 * tui/tui-command.h (struct tui_cmd_window): Move from
617 * tui/tui-command.c: Remove "structuring" comments.
618 (tui_cmd_window::clear_detail)
619 (tui_cmd_window::do_make_visible_with_new_height)
620 (tui_cmd_window::max_height): Move from elsewhere.
622 2019-07-17 Tom Tromey <tom@tromey.com>
624 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
626 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
627 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
629 2019-07-17 Tom Tromey <tom@tromey.com>
632 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
634 * tui/tui-windata.h: Remove file.
635 * tui/tui-windata.c: Remove file.
636 * tui/tui-win.c (tui_data_window::set_new_height)
637 (tui_data_window::do_make_visible_with_new_height): Move to
639 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
640 * tui/tui-regs.c: Remove "structuring" comments.
641 (tui_data_window::first_data_item_displayed)
642 (tui_data_window::delete_data_content_windows)
643 (tui_data_window::erase_data_content)
644 (tui_data_window::display_all_data)
645 (tui_data_window::refresh_all)
646 (tui_data_window::do_scroll_vertical)
647 (tui_data_window::clear_detail, tui_data_window::set_new_height)
648 (tui_data_window::do_make_visible_with_new_height)
649 (tui_data_window::refresh_window): Move from elsewhere.
650 (_initialize_tui_regs): Move to end of file.
651 * tui/tui-layout.c: Update.
652 * tui/tui-hooks.c: Update.
653 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
654 * tui/tui-data.c (tui_data_window::clear_detail): Move to
656 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
658 2019-07-17 Tom Tromey <tom@tromey.com>
660 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
663 2019-07-17 Tom Tromey <tom@tromey.com>
665 * tui/tui-win.c (tui_source_window_base::set_new_height)
666 (tui_source_window_base::do_make_visible_with_new_height): Use
667 m_has_locator field directly.
668 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
670 (struct tui_source_window_base) <has_locator>: Likewise.
672 2019-07-17 Tom Tromey <tom@tromey.com>
674 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
676 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
678 * tui/tui-win.c (tui_source_window_base::set_new_height)
679 (tui_source_window_base::set_new_height)
680 (make_invisible_and_set_new_height)
681 (tui_source_window_base::do_make_visible_with_new_height)
682 (tui_source_window_base::do_make_visible_with_new_height):
684 * tui/tui-layout.c (show_source_disasm_command, show_data)
685 (show_source_or_disasm_and_command): Update.
686 * tui/tui-layout.c (show_layout): Update.
688 2019-07-17 Tom Tromey <tom@tromey.com>
690 * tui/tui-layout.c (make_data_window): Remove.
691 (show_data): Unify creation and re-initialization cases.
693 2019-07-17 Tom Tromey <tom@tromey.com>
695 * tui/tui-layout.c (make_source_window, make_disasm_window):
697 (show_data): Unify creation and re-initialization cases.
699 2019-07-17 Tom Tromey <tom@tromey.com>
701 * tui/tui-layout.c (make_command_window): Remove.
702 (show_source_disasm_command, show_source_or_disasm_and_command):
703 Unify creation and re-initialization cases.
705 2019-07-17 Tom Tromey <tom@tromey.com>
707 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
708 creation and re-initialization cases.
710 2019-07-17 Tom Tromey <tom@tromey.com>
712 * tui/tui-regs.c (tui_get_register): Return void.
714 2019-07-17 Tom Tromey <tom@tromey.com>
716 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
719 2019-07-17 Tom Tromey <tom@tromey.com>
721 * tui/tui-layout.c (show_source_disasm_command): Simplify window
724 2019-07-17 Tom Tromey <tom@tromey.com>
726 * tui/tui.h (tui_set_layout_by_name): Don't declare.
727 * tui/tui-regs.c (tui_reg_layout): New function.
728 (tui_show_registers, tui_reg_command): Use it.
729 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
730 (tui_layout_command): Rename from tui_set_layout_by_name. Change
732 (tui_layout_command): Remove.
734 2019-07-17 Tom Tromey <tom@tromey.com>
736 * tui/tui-layout.h (tui/tui-layout): Return void.
737 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
739 2019-07-17 Tom Tromey <tom@tromey.com>
741 * tui/tui-layout.c (show_source_disasm_command, show_data):
743 (reset_locator): Remove.
744 (show_source_or_disasm_and_command): Update.
746 2019-07-17 Tom Tromey <tom@tromey.com>
748 * tui/tui-source.c (tui_source_window_base::reset): Remove
750 * tui/tui-layout.c (make_command_window, make_source_window)
751 (make_disasm_window, make_data_window)
752 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
753 (reset_locator, show_source_or_disasm_and_command): Update.
754 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
756 (struct tui_source_window_base) <reset>: Likewise.
758 2019-07-17 Tom Tromey <tom@tromey.com>
760 * tui/tui-layout.c (show_source_disasm_command): Use
762 (reset_locator): New function.
763 (init_and_make_win): Remove.
764 (show_source_or_disasm_and_command): Use reset_locator.
766 2019-07-17 Tom Tromey <tom@tromey.com>
768 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
770 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
772 * tui/tui-source.c (tui_source_window_base::reset): New method.
773 * tui/tui-layout.c (make_command_window): Don't call
775 (make_source_window, make_disasm_window): Don't call
776 make_source_or_disasm_window.
777 (make_data_window): Don't call init_and_make_win. Change calling
779 (show_source_disasm_command, show_data): Simplify.
780 (make_source_or_disasm_window): Remove.
781 (show_source_or_disasm_and_command): Simplify.
782 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
783 (struct tui_source_window_base) <reset>: Likewise.
784 <execution_info>: Remove initializer.
785 * tui/tui-data.c (tui_source_window_base): Initialize
788 2019-07-17 Tom Tromey <tom@tromey.com>
790 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
793 2019-07-17 Tom Tromey <tom@tromey.com>
795 * tui/tui.c (tui_rl_other_window): Update.
796 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
797 superclass method first. Always iterate over regs_content.
798 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
800 * tui/tui-win.c (tui_set_focus_command): Update.
802 2019-07-17 Tom Tromey <tom@tromey.com>
804 * tui/tui-win.c (tui_set_focus_command): Rename from
805 tui_set_focus. Call tui_enable.
806 (tui_set_focus_command): Remove.
808 2019-07-17 Tom Tromey <tom@tromey.com>
810 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
812 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
814 (tui_data_window::refresh_window): Call refresh_window on data
815 items. Always call superclass refresh_window.
816 (tui_win_info::refresh): Remove.
817 (tui_source_window_base::refresh_window): Update.
818 (tui_refresh_all): Update.
819 * tui/tui-layout.c (show_source_disasm_command): Remove call to
821 (show_source_or_disasm_and_command): Likewise.
822 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
823 (struct tui_source_window_base) <refresh>: Likewise.
825 2019-07-17 Tom Tromey <tom@tromey.com>
827 * tui/tui-winsource.c (tui_clear_source_content)
828 (tui_show_source_content): Update.
829 * tui/tui-source.c (tui_source_window::showing_source_p): Check
830 whether content is empty.
831 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
834 2019-07-17 Tom Tromey <tom@tromey.com>
836 * tui/tui-winsource.c (tui_erase_source_content): Clear the
838 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
839 * tui/tui-source.c (tui_set_source_content_nil): Remove.
841 2019-07-17 Tom Tromey <tom@tromey.com>
843 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
844 (struct tui_data_item_window): Update.
846 2019-07-17 Tom Tromey <tom@tromey.com>
848 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
849 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
852 2019-07-17 Tom Tromey <tom@tromey.com>
854 * tui/tui-winsource.h (tui_erase_source_content)
855 (tui_clear_source_content): Remove "display_prompt" parameter.
856 * tui/tui-winsource.c (tui_update_source_window_as_is)
857 (tui_update_source_windows_with_addr): Update.
858 (tui_clear_source_content): Remove "display_prompt" parameter.
859 (tui_erase_source_content): Likewise. Simplify.
860 (tui_show_source_content): Update.
861 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
862 * tui/tui-stack.c (tui_show_frame_info): Update.
863 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
866 2019-07-17 Tom Tromey <tom@tromey.com>
868 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
869 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
871 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
874 2019-07-17 Tom Tromey <tom@tromey.com>
876 * tui/tui-winsource.c (tui_clear_source_content)
877 (tui_show_source_content, tui_show_exec_info_content)
878 (tui_clear_exec_info_content): Update.
879 * tui/tui-stack.c (tui_show_locator_content): Update.
880 (tui_show_frame_info): Update.
881 * tui/tui-source.h (tui_source_window): Don't declare.
882 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
883 from tui_source_is_displayed.
884 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
886 (struct tui_source_window_base) <content_in_use>: New field. Now
888 (struct tui_source_window) <showing_source_p>: New method.
889 (TUI_SRC_WIN): Change cast.
890 * tui/tui-data.c (tui_initialize_static_data): Update.
892 2019-07-17 Tom Tromey <tom@tromey.com>
894 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
896 * tui/tui-source.c (tui_source_window::location_matches_p): New
898 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
900 * tui/tui-data.h (struct tui_source_window_base)
901 <location_matches_p>: New method.
902 (struct tui_source_window, struct tui_disasm_window)
903 <location_matches_p>: Likewise.
905 2019-07-17 Tom Tromey <tom@tromey.com>
907 * tui/tui-win.c (tui_set_win_height_command): Rename from
909 (tui_set_win_height_command): Remove.
911 2019-07-17 Tom Tromey <tom@tromey.com>
913 * tui/tui-source.c (tui_source_window): New constructor. Add
915 (~tui_source_window): New destructor.
916 (tui_source_window::style_changed): New method.
917 * tui/tui-hooks.c (tui_redisplay_source): Remove.
918 (tui_attach_detach_observers): Update.
919 * tui/tui-data.h (struct tui_source_window): Make constructor not
920 inline. Add destructor.
921 (struct tui_source_window) <style_changed>: New method.
922 <m_observable>: New member.
924 2019-07-17 Tom Tromey <tom@tromey.com>
926 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
927 * tui/tui-win.c (tui_resize_all): Fix typo.
929 2019-07-17 Tom Tromey <tom@tromey.com>
931 * tui/tui-wingeneral.h (tui_refresh_all): Update.
932 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
933 (tui_refresh_all): Remove "list" parameter. Use foreach.
934 * tui/tui-win.c (window_name_completer): Use foreach.
935 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
936 (update_tab_width): Likewise.
937 * tui/tui-layout.c (show_layout): Update.
938 * tui/tui-data.h (class tui_window_iterator): New.
939 (struct all_tui_windows): New.
940 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
942 2019-07-17 Tom Tromey <tom@tromey.com>
944 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
945 parameter. Don't reference globals.
946 (tui_reg_command): Update.
948 2019-07-17 Tom Tromey <tom@tromey.com>
950 * tui/tui-regs.c (tui_show_registers): Simplify.
952 2019-07-17 Tom Tromey <tom@tromey.com>
954 * tui/tui-regs.c (tui_show_registers): Update.
955 (tui_show_register_group): Add win_info parameter.
957 2019-07-17 Tom Tromey <tom@tromey.com>
959 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
960 Rename from tui_display_reg_element_at_line.
961 (tui_data_window::display_registers_from_line): Update.
962 * tui/tui-data.h (struct tui_data_window)
963 <display_reg_element_at_line>: New method.
965 2019-07-17 Tom Tromey <tom@tromey.com>
967 * tui/tui-regs.h (tui_display_registers_from)
968 (tui_display_registers_from_line): Don't declare.
969 * tui/tui-windata.c (tui_data_window::display_all_data)
970 (tui_data_window::refresh_all)
971 (tui_data_window::do_scroll_vertical): Update.
972 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
973 from tui_display_registers_from.
974 (tui_display_reg_element_at_line): Update.
975 (tui_data_window::display_registers_from_line): Rename from
976 tui_display_registers_from_line.
977 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
978 display_registers_from_line>: New methods.
980 2019-07-17 Tom Tromey <tom@tromey.com>
982 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
983 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
984 from tui_erase_data_content.
985 (tui_data_window::display_all_data)
986 (tui_data_window::refresh_all)
987 (tui_data_window::do_scroll_vertical): Update.
988 * tui/tui-regs.c (tui_show_registers): Update.
989 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
992 2019-07-17 Tom Tromey <tom@tromey.com>
994 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
997 (tui_data_window::delete_data_content_windows): Rename from
998 tui_delete_data_content_windows.
999 (tui_data_window::display_all_data)
1000 (tui_data_window::do_scroll_vertical): Update.
1001 * tui/tui-data.h (struct tui_data_window)
1002 <delete_data_content_windows>: New method.
1004 2019-07-17 Tom Tromey <tom@tromey.com>
1006 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1007 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1009 2019-07-17 Tom Tromey <tom@tromey.com>
1011 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1012 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1013 from tui_display_all_data.
1015 (tui_data_window::do_make_visible_with_new_height): Update.
1016 * tui/tui-regs.c (tui_show_registers): Update.
1017 * tui/tui-layout.c (tui_set_layout): Update.
1018 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1021 2019-07-17 Tom Tromey <tom@tromey.com>
1023 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1024 * tui/tui-windata.c (tui_display_data_from): Remove.
1025 (tui_data_window::refresh_all): Update.
1027 2019-07-17 Tom Tromey <tom@tromey.com>
1029 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1030 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1031 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1032 tui_display_registers_from_line.
1033 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1034 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1035 "force_display" parameter.
1037 2019-07-17 Tom Tromey <tom@tromey.com>
1039 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1041 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1042 Rename from tui_first_reg_element_no_inline.
1043 (tui_display_reg_element_at_line)
1044 (tui_display_registers_from_line): Update.
1045 * tui/tui-data.h (struct tui_data_window)
1046 <first_reg_element_no_inline>: New method.
1048 2019-07-17 Tom Tromey <tom@tromey.com>
1050 * tui/tui-windata.c (tui_display_data_from)
1051 (tui_data_window::do_scroll_vertical): Update.
1052 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1053 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1054 Rename from tui_line_from_reg_element_no.
1055 (tui_display_registers_from_line): Update.
1056 * tui/tui-data.h (struct tui_data_window)
1057 <line_from_reg_element_no>: New method.
1059 2019-07-17 Tom Tromey <tom@tromey.com>
1061 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1062 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1063 tui_last_regs_line_no.
1064 (tui_display_reg_element_at_line)
1065 (tui_display_registers_from_line): Update.
1066 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1069 2019-07-17 Tom Tromey <tom@tromey.com>
1072 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1073 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1074 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1075 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1076 (tui_update_breakpoint_info): Likewise.
1077 * tui/tui-hooks.c (tui_event_create_breakpoint)
1078 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1081 2019-07-17 Tom Tromey <tom@tromey.com>
1083 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1085 2019-07-17 Tom Tromey <tom@tromey.com>
1087 * tui/tui-winsource.c (tui_update_source_window_as_is)
1088 (tui_update_source_windows_with_addr): Update.
1089 * tui/tui-source.h (tui_set_source_content)
1090 (tui_show_symtab_source): Add "win_info" parameter.
1091 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1093 (tui_show_symtab_source): Likewise.
1095 2019-07-17 Tom Tromey <tom@tromey.com>
1097 * tui/tui-wingeneral.c
1098 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1100 2019-07-17 Tom Tromey <tom@tromey.com>
1102 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1103 (struct tui_cmd_window) <can_scroll>: New method.
1104 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1107 2019-07-17 Tom Tromey <tromey@adacore.com>
1109 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1110 do_field_signed>: Rename. Change type of "value".
1111 * ui-out.c (ui_out::field_signed): Rename from field_int.
1112 Change type of "value".
1113 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1115 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1116 do_field_int. Change type of "value".
1117 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1118 do_field_int. Change type of "value".
1119 * tracepoint.c (trace_status_mi, tfind_1)
1120 (print_one_static_tracepoint_marker): Update.
1121 * thread.c (print_thread_info_1, print_selected_thread_frame):
1123 * stack.c (print_frame, print_frame_info): Update.
1124 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1126 * source.c (print_source_lines_base): Update.
1127 * skip.c (info_skip_command): Update.
1128 * record-btrace.c (btrace_ui_out_decode_error)
1129 (btrace_call_history_src_line): Update.
1130 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1132 * progspace.c (print_program_space): Update.
1133 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1134 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1135 do_field_int. Change type of "value".
1136 * mi/mi-out.c (mi_ui_out::do_table_begin)
1137 (mi_ui_out::do_table_header): Update.
1138 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1140 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1141 (mi_cmd_data_list_changed_registers, output_register)
1142 (mi_cmd_data_read_memory, mi_load_progress)
1143 (mi_cmd_trace_frame_collected): Update.
1144 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1146 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1147 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1148 (mi_cmd_var_list_children, varobj_update_one): Update.
1149 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1150 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1151 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1152 * inferior.c (print_inferior): Update.
1153 * gdb_bfd.c (print_one_bfd): Update.
1154 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1156 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1157 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1158 do_field_int. Change type of "value".
1159 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1160 do_field_int. Change type of "value".
1161 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1162 (print_one_breakpoint_location, print_it_catch_fork)
1163 (print_one_catch_fork, print_it_catch_vfork)
1164 (print_one_catch_vfork, print_it_catch_solib)
1165 (print_it_catch_exec, print_it_ranged_breakpoint)
1166 (print_mention_watchpoint, print_mention_masked_watchpoint)
1167 (bkpt_print_it, update_static_tracepoint): Update.
1168 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1169 * break-catch-syscall.c (print_it_catch_syscall): Update.
1170 * ada-tasks.c (print_ada_task_info): Update.
1171 * ada-lang.c (print_it_exception, print_mention_exception):
1174 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1176 PR breakpoints/24541
1177 * gdbarch.c: Regenerate.
1178 * gdbarch.h: Regenerate.
1179 * gdbarch.sh: Adjust return type and parameter types for
1180 'stap_adjust_register'.
1181 (i386_stap_adjust_register): Adjust signature and return new
1183 * stap-probe.c (stap_parse_register_operand): Adjust use of
1184 'gdbarch_stap_adjust_register'.
1186 2019-07-17 Tom Tromey <tromey@adacore.com>
1188 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1190 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1192 (struct s390_process_info): Add initializers.
1193 (s390_add_process): Use new.
1194 (s390_linux_nat_target::low_forget_process): Use delete.
1195 (s390_linux_nat_target::low_new_fork)
1196 (s390_linux_nat_target::stopped_by_watchpoint)
1197 (s390_linux_nat_target::low_prepare_to_resume)
1198 (s390_linux_nat_target::insert_watchpoint)
1199 (s390_linux_nat_target::insert_hw_breakpoint)
1200 (s390_linux_nat_target::remove_watchpoint)
1201 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1203 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1205 * aarch64-fbsd-nat.c: Include regcache.h.
1206 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1208 (aarch64_fbsd_nat_target::fetch_registers)
1209 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1211 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1213 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1215 * fbsd-nat.c: Include gdbarch.h.
1217 2019-07-15 Tom Tromey <tromey@adacore.com>
1219 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1221 2019-07-15 Tom Tromey <tromey@adacore.com>
1223 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1224 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1225 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1226 * cli-out.c (cli_ui_out::do_field_int): New method.
1227 * ui-out.c (ui_out::field_unsigned): New method.
1228 * symfile.c (generic_load): Use field_unsigned.
1229 (print_transfer_performance): Likewise.
1230 * record-btrace.c (ui_out_field_uint): Remove.
1231 (btrace_call_history_insn_range, btrace_call_history): Use
1233 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1235 * ui-out.h (class ui_out) <field_unsigned>: New method.
1236 <do_field_unsigned>: Likewise.
1238 2019-07-15 Tom Tromey <tromey@adacore.com>
1240 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1241 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1242 * target.c (flash_erase_command): Use field_string.
1243 * infrun.c (print_signal_received_reason): Use field_string.
1244 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1245 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1247 * ada-tasks.c (print_ada_task_info): Use field_string.
1249 2019-07-15 Tom Tromey <tromey@adacore.com>
1251 * target.c (flash_erase_command): Use field_core_addr.
1252 * symfile.c (generic_load): Use field_core_addr.
1253 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1254 Use field_core_addr.
1255 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1258 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1260 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1261 value if its desired type is smaller than a CORE_ADDR and signed.
1263 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1265 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1266 of changes to field names, and use new is_reference field to
1267 decide if a property is a reference or not.
1268 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1270 (struct dwarf2_property_baton): Update header comment, rename
1271 'referenced_type' to 'property_type' and update comments.
1272 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1273 default property type, store in property baton, update to take
1274 accound of renamed field.
1275 (read_func_scope): Update call to attr_to_dynamic_prop.
1276 (read_array_type): Likewise.
1277 (dwarf2_per_cu_addr_sized_int_type): New function.
1278 (read_subrange_index_type): Move type finding code to
1279 dwarf2_per_cu_addr_sized_int_type.
1280 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1281 (dwarf2_per_cu_addr_type): New function.
1282 (set_die_type): Update calls to attr_to_dynamic_prop.
1284 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1286 * dwarf2read.c (read_subrange_index_type): New function.
1287 (read_subrange_type): Move code into new function and call it.
1288 * gdbtypes.c (create_range_type): Add some asserts.
1290 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1292 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1293 update return statements.
1294 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1295 declaration, and update comment to match.
1296 * gdbtypes.c (resolve_dynamic_array): Update call to
1297 dwarf2_evaluate_property to match new return type.
1299 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1301 * valarith.c (value_subscripted_rvalue): Change lowerbound
1302 parameter type from int to LONGEST.
1303 * value.h (value_subscripted_rvalue): Likewise in declaration.
1305 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1307 * cli/cli-utils.c (info_print_command_completer): New function.
1308 * cli/cli-utils.h: Add 'completer.h' include, and forward
1309 declaration for 'struct cmd_list_element'.
1310 (info_print_command_completer): Declare.
1311 * stack.c (_initialize_stack): Add completer for 'info locals' and
1313 * symtab.c (_initialize_symtab): Add completer for 'info
1314 variables' and 'info functions'.
1315 * NEWS: Mention completion for additional info commands.
1317 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1319 * cli/cli-utils.c (extract_info_print_args): Delete.
1320 (extract_arg_maybe_quoted): Delete.
1321 (info_print_options_defs): New variable.
1322 (make_info_print_options_def_group): New function.
1323 (extract_info_print_options): Define new function.
1324 * cli/cli-utils.h (extract_info_print_args): Delete.
1325 (struct info_print_options): New structure.
1326 (extract_info_print_options): Declare new function.
1327 * stack.c (info_locals_command): Update to use new
1328 extract_info_print_options, also add a header comment.
1329 (info_args_command): Likewise.
1330 * symtab.c (info_variables_command): Likewise.
1331 (info_functions_command): Likewise.
1333 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1335 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1336 to extract string arguments.
1337 * common/common-utils.c (extract_string_maybe_quoted): New function.
1338 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1340 2019-07-11 Tom Tromey <tromey@adacore.com>
1342 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1343 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1344 * top.h (gdbinit): Don't declare.
1345 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1347 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1348 * top.c (gdb_init): Don't call init_cli_cmds.
1350 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1352 2019-07-11 Tom Tromey <tromey@adacore.com>
1354 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1355 after it has been moved.
1357 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1359 * valops.c (value_must_coerce_to_target): Change return type to
1361 * value.h (value_must_coerce_to_target): Likewise.
1363 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
1365 * breakpoint.c (is_hardware_watchpoint): Remove
1366 forward-declaration.
1367 (is_masked_watchpoint): Change return type to bool.
1368 (is_tracepoint): Likewise.
1369 (is_breakpoint): Likewise.
1370 (is_hardware_watchpoint): Likewise.
1371 (is_watchpoint): Likewise.
1372 (is_no_memory_software_watchpoint): Likewise.
1373 (is_catchpoint): Likewise.
1374 (breakpoint_1): Make FILTER parameter's return type bool.
1375 is_masked_watchpoint): Change return type to bool.
1376 (save_breakpoints): Make FILTER parameter's return type bool.
1377 * breakpoint.h (is_breakpoint): Change return type to bool.
1378 (is_watchpoint): Likewise.
1379 (is_catchpoint): Likewise.
1380 (is_tracepoint): Likewise.
1382 2019-07-10 Tom Tromey <tom@tromey.com>
1384 * defs.h: Don't include gdbarch.h.
1385 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1386 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1387 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1388 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1389 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1390 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1391 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1392 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1393 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1394 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1395 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1396 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1397 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1398 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1399 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1400 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1401 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1402 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1403 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1404 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1405 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1406 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1407 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1408 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1409 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1410 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1411 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1413 2019-07-10 Tom Tromey <tromey@adacore.com>
1415 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1416 * breakpoint.c (init_ada_exception_breakpoint): Register as
1418 (print_one_breakpoint_location, print_one_breakpoint): Use
1419 is_ada_exception_catchpoint.
1420 * ada-lang.c (class ada_catchpoint_location): Pass
1421 bp_loc_software_breakpoint to bp_location constructor.
1422 (is_ada_exception_catchpoint): New function.
1424 2019-07-10 Tom Tromey <tromey@adacore.com>
1426 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1428 (struct arm_exidx_entry): New method operator<.
1429 (struct arm_exidx_data) <section_maps>: Change type.
1430 (arm_exidx_data_free): Remove.
1431 (arm_exidx_data_key): Change type. Move lower.
1432 (arm_exidx_new_objfile): Update.
1433 (arm_compare_exidx_entries): Remove.
1434 (arm_find_exidx_entry, _initialize_arm_tdep)
1436 2019-07-10 Tom Tromey <tromey@adacore.com>
1438 * solib-spu.c (ocl_program_data_key): Change type.
1439 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1442 2019-07-10 Tom Tromey <tromey@adacore.com>
1444 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1445 (struct solib_aix_inferior_data) <library_list>: Change type.
1446 (solib_aix_inferior_data_handle): Change type.
1447 (get_solib_aix_inferior_data): Update.
1448 (solib_aix_free_library_list): Remove.
1449 (library_list_start_library): Update.
1450 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1452 (solib_aix_get_library_list)
1453 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1454 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1456 2019-07-10 Tom Tromey <tromey@adacore.com>
1458 * solib-dsbt.c (struct dsbt_info): Add initializers.
1459 (solib_dsbt_pspace_data): Change type.
1460 (dsbt_pspace_data_cleanup): Remove.
1461 (get_dsbt_info, _initialize_dsbt_solib): Update.
1463 2019-07-10 Tom Tromey <tromey@adacore.com>
1465 * spu-tdep.c (spu_overlay_data): Change type.
1466 (spu_get_overlay_table, spu_overlay_new_objfile)
1467 (_initialize_spu_tdep): Update.
1469 2019-07-10 Tom Tromey <tromey@adacore.com>
1471 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1473 (dbx_objfile_data_key): Change type and declare later.
1474 (DBX_SYMFILE_INFO): Rewrite.
1475 * dbxread.c (dbx_objfile_data_key): Change type.
1476 (dbx_symfile_init): Update.
1477 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
1478 (coffstab_build_psymtabs, elfstab_build_psymtabs)
1479 (stabsect_build_psymtabs, _initialize_dbxread): Update.
1481 2019-07-10 Tom Tromey <tromey@adacore.com>
1483 * jit.c (jit_program_space_key): Change type. Move lower.
1484 (get_jit_program_space_data): Update.
1485 (jit_program_space_data_cleanup): Remove.
1486 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1488 (struct jit_program_space_data): Add initializers.
1490 2019-07-10 Tom Tromey <tromey@adacore.com>
1492 * solib-darwin.c (struct darwin_info): Add initializers.
1493 (solib_darwin_pspace_data): Change type.
1494 (darwin_pspace_data_cleanup): Remove.
1495 (get_darwin_info, _initialize_darwin_solib): Update.
1497 2019-07-10 Tom Tromey <tromey@adacore.com>
1499 * remote-sim.c (struct sim_inferior_data): Add initializers,
1500 constructor, and destructor.
1501 (sim_inferior_data_key): Change type. Move lower.
1502 (check_for_duplicate_sim_descriptor): Update.
1503 (get_sim_inferior_data): Use new. Update.
1504 (~sim_inferior_data_cleanup): Rename from
1505 sim_inferior_data_cleanup. Simplify.
1506 (gdbsim_close_inferior, simulator_command)
1507 (sim_command_completer, _initialize_remote_sim): Update.
1508 (next_pid, INITIAL_PID): Move earlier.
1510 2019-07-10 Tom Tromey <tromey@adacore.com>
1512 * python/python-internal.h (create_thread_object): Return
1514 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1515 * python/py-inferior.c (struct threadlist_entry): Add
1517 <thread_obj>: Now a gdbpy_ref.
1518 (thread_to_thread_object): Update.
1519 (add_thread_object): Use new.
1520 (delete_thread_object): Use delete.
1521 (infpy_threads): Update.
1522 (py_free_inferior): Update. Construct "inf_obj" after acquiring
1525 2019-07-10 Tom Tromey <tromey@adacore.com>
1527 * valops.c (value_cast): Specialize error message for Ada.
1529 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1531 * breakpoint.c (breakpoint_1): Update doc and parameter names.
1533 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1535 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1536 bpstat_should_step): Return bool, adjust comments.
1537 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1538 bpstat_should_step): Likewise.
1540 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1542 * features/Makefile: Use feature target descriptions for Arm.
1543 * features/arm/arm-core.c: Generate new file.
1544 * features/arm/arm-fpa.c: Likewise.
1545 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1546 * features/arm/arm-m-profile.c: Likewise.
1547 * features/arm/arm-vfpv2.c: Likewise.
1548 * features/arm/arm-vfpv3.c: Likewise.
1549 * features/arm/xscale-iwmmxt.c: Likewise.
1550 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1552 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1554 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1557 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1559 * features/aarch64-pauth.c: Regenerate.
1561 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
1563 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1565 (bpstat_what): Use false instead of 0.
1567 2019-07-09 Pedro Alves <palves@redhat.com>
1569 * break-catch-throw.c (is_exception_catchpoint): New.
1570 * breakpoint.c (print_one_breakpoint_location): New parameter
1571 'raw_loc'. Handle it. Use
1572 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1573 looking at the breakpoint's type.
1574 (print_one_breakpoint): If handling "maint info breakpoints", also
1575 print locations of exception catchpoints.
1576 * breakpoint.h (is_exception_catchpoint): Declare.
1578 2019-07-09 Pedro Alves <palves@redhat.com>
1580 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1582 (allocate_location_exception_catchpoint): New.
1583 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1584 (initialize_throw_catchpoint_ops): Install
1585 allocate_location_exception_catchpoint as allocate_location
1587 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1588 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1590 (breakpoint_address_is_meaningful): Delete.
1591 (bl_address_is_meaningful): New.
1592 (breakpoint_locations_match): Adjust comment.
1593 (bp_location_from_bp_type): New, factored out of...
1594 (bp_location::bp_location(breakpoint *)): ... this.
1595 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1597 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
1598 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1599 breakpoint_address_is_meaningful.
1600 (bp_locations_compare): Adjust comment.
1601 (update_global_location_list): Use bl_address_is_meaningful
1602 instead of breakpoint_address_is_meaningful.
1603 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1605 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1606 * python/py-breakpoint.c (bppy_get_location): No longer check
1607 whether location is null.
1609 2019-07-09 Pedro Alves <palves@redhat.com>
1612 * breakpoint.c (print_one_breakpoint_location): Remove
1613 single-location assert.
1615 2019-07-09 Tom Tromey <tom@tromey.com>
1617 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1618 * configure: Rebuild.
1619 * configure.ac: Change common to gdbsupport.
1620 * gdbsupport: Rename from common.
1621 * acinclude.m4: Change common to gdbsupport.
1622 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1623 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1625 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1626 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1627 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1628 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1629 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1630 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1631 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1632 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1633 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1634 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1635 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1636 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1637 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1638 coff-pe-read.c, command.h, compile/compile-c-support.c,
1639 compile/compile-c.h, compile/compile-cplus-symbols.c,
1640 compile/compile-cplus-types.c, compile/compile-cplus.h,
1641 compile/compile-loc2c.c, compile/compile.c, completer.c,
1642 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1643 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1644 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1645 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1646 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1647 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1648 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1649 features/aarch64-core.c, features/aarch64-fpu.c,
1650 features/aarch64-pauth.c, features/aarch64-sve.c,
1651 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1652 features/i386/32bit-core.c, features/i386/32bit-linux.c,
1653 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1654 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1655 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1656 features/i386/64bit-core.c, features/i386/64bit-linux.c,
1657 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1658 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1659 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1660 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1661 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1662 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1663 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1664 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1665 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1666 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1667 go32-nat.c, guile/guile.c, guile/scm-ports.c,
1668 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1669 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1670 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1671 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1672 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1673 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1674 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1675 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1676 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1677 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1678 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1679 minsyms.c, mips-linux-tdep.c, namespace.h,
1680 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1681 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1682 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1683 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1684 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1685 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1686 nat/linux-waitpid.c, nat/mips-linux-watch.c,
1687 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1688 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1689 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1690 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1691 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1692 procfs.c, producer.c, progspace.h, psymtab.h,
1693 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1694 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1695 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1696 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1697 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1698 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1699 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1700 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1701 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1702 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1703 target-memory.c, target.c, target.h, target/waitstatus.c,
1704 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1705 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1706 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1707 unittests/array-view-selftests.c,
1708 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1709 unittests/common-utils-selftests.c,
1710 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1711 unittests/format_pieces-selftests.c,
1712 unittests/function-view-selftests.c,
1713 unittests/lookup_name_info-selftests.c,
1714 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1715 unittests/mkdir-recursive-selftests.c,
1716 unittests/observable-selftests.c,
1717 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1718 unittests/parse-connection-spec-selftests.c,
1719 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1720 unittests/scoped_fd-selftests.c,
1721 unittests/scoped_mmap-selftests.c,
1722 unittests/scoped_restore-selftests.c,
1723 unittests/string_view-selftests.c, unittests/style-selftests.c,
1724 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1725 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1726 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1727 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1728 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1729 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1731 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1733 * linespec.c (decode_digits_list_mode): Set explicit_line to a
1735 (decode_digits_ordinary): Set explicit_line field in sal.
1736 * symtab.c (skip_prologue_sal): Don't skip prologue for a
1737 symtab_and_line that was set on an explicit line number in
1738 assembler code. Do always update the recorded symtab and line if
1739 we do skip the prologue.
1741 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1743 * breakpoint.c (set_breakpoint_location_function): Remove
1744 explicit_loc parameter.
1745 (momentary_breakpoint_from_master): Update call to
1746 set_breakpoint_location_function.
1747 (add_location_to_breakpoint): Likewise.
1749 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1751 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1752 required features based on default bfd type when no specific bfd
1755 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1757 * NEWS: Mention that GDB printf and eval commands can now print
1758 C-style and Ada-style convenience var strings without
1759 calling the inferior.
1760 * printcmd.c (printf_c_string): Locally print GDB internal var
1761 instead of transiting via the inferior.
1762 (printf_wide_c_string): Likewise.
1764 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1766 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1768 2019-07-04 Tom Tromey <tom@tromey.com>
1771 * tui/tui-winsource.c (tui_clear_source_content): Update.
1772 (tui_source_window_base::set_is_exec_point_at): Fix comment.
1773 (tui_update_breakpoint_info): Update.
1774 (tui_set_exec_info_content): Update.
1775 * tui/tui-source.c (tui_set_source_content_nil): Update.
1776 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1778 * tui/tui-data.h (enum tui_bp_flag): New.
1779 (tui_bp_flags): New enum flags type.
1780 (struct tui_source_element) <break_mode>: Change type. Rename
1782 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1783 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
1785 * tui/tui-winsource.h: Fix comment.
1787 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1789 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1790 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1791 (store_fpregs_to_thread)
1792 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1793 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1794 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1795 (IWMMXT_REGS_SIZE): Add define.
1796 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1797 (fetch_vfp_regs, store_vfp_regs)
1798 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1799 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1801 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1803 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1805 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1806 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1807 (ARM_INT_REGISTER_SIZE): ...to this.
1808 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1809 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1810 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1811 (arm_linux_collect_gregset, supply_nwfpe_register)
1812 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1814 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1815 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1816 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1817 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1818 (arm_return_in_memory, arm_store_return_value)
1819 (arm_get_longjmp_target, arm_register_g_packet_guesses)
1820 (arm_record_ld_st_multiple): Likewise.
1821 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1822 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1824 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1826 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1827 AARCH64_DISPLACED_MODIFIED_INSNS.
1828 * aarch64-tdep.c (struct aarch64_displaced_step_data)
1829 (aarch64_displaced_step_copy_insn): Likewise.
1830 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1831 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1832 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1833 ARM_DISPLACED_MODIFIED_INSNS.
1834 * arm-tdep.c (arm_gdbarch_init): Likewise.
1835 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1836 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1837 (struct arm_displaced_step_closure): Use
1838 ARM_DISPLACED_MODIFIED_INSNS.
1840 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1842 * features/Makefile: Remove unused xml files.
1843 * features/aarch64.xml: Remove.
1844 * features/i386/amd64-avx-avx512-linux.xml: Remove.
1845 * features/i386/amd64-avx-avx512.xml: Remove.
1846 * features/i386/amd64-avx-linux.xml: Remove.
1847 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1848 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1849 * features/i386/amd64-avx-mpx-linux.xml: Remove.
1850 * features/i386/amd64-avx-mpx.xml: Remove.
1851 * features/i386/amd64-avx.xml: Remove.
1852 * features/i386/amd64-linux.xml: Remove.
1853 * features/i386/amd64-mpx-linux.xml: Remove.
1854 * features/i386/amd64-mpx.xml: Remove.
1855 * features/i386/amd64.xml: Remove.
1856 * features/i386/i386-avx-avx512-linux.xml: Remove.
1857 * features/i386/i386-avx-avx512.xml: Remove.
1858 * features/i386/i386-avx-linux.xml: Remove.
1859 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1860 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1861 * features/i386/i386-avx-mpx-linux.xml: Remove.
1862 * features/i386/i386-avx-mpx.xml: Remove.
1863 * features/i386/i386-avx.xml: Remove.
1864 * features/i386/i386-linux.xml: Remove.
1865 * features/i386/i386-mmx-linux.xml: Remove.
1866 * features/i386/i386-mmx.xml: Remove.
1867 * features/i386/i386-mpx-linux.xml: Remove.
1868 * features/i386/i386-mpx.xml: Remove.
1869 * features/i386/i386.xml: Remove.
1870 * features/i386/x32-avx-avx512-linux.xml: Remove.
1871 * features/i386/x32-avx-linux.xml: Remove.
1872 * features/i386/x32-linux.xml: Remove.
1874 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1876 * regformats/aarch64.dat: Remove.
1877 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1878 * regformats/i386/amd64-avx-linux.dat: Remove.
1879 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1880 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1881 * regformats/i386/amd64-linux.dat: Remove.
1882 * regformats/i386/amd64-mpx-linux.dat: Remove.
1883 * regformats/i386/amd64.dat: Remove.
1884 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1885 * regformats/i386/i386-avx-linux.dat: Remove.
1886 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1887 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1888 * regformats/i386/i386-linux.dat: Remove.
1889 * regformats/i386/i386-mmx-linux.dat: Remove.
1890 * regformats/i386/i386-mpx-linux.dat: Remove.
1891 * regformats/i386/i386.dat: Remove.
1892 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1893 * regformats/i386/x32-avx-linux.dat: Remove.
1894 * regformats/i386/x32-linux.dat: Remove.
1896 2019-07-04 Alan Hayward <alan.hayward@arm.com>
1898 * aarch64-tdep.c: Remove xml self tests.
1899 * amd64-linux-tdep.c: Likewise.
1900 * amd64-tdep.c: Likewise.
1901 * i386-linux-tdep.c: Likewise.
1902 * i386-tdep.c: Likewise.
1904 2019-07-03 Pedro Alves <palves@redhat.com>
1907 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1908 (pipe_cmd_option_defs): New.
1909 (make_pipe_cmd_options_def_group): New.
1910 (pipe_command): Use gdb::option::process_options.
1911 (pipe_command_completer): New function.
1912 (_initialize_cli_cmds): Install completer for "pipe" command.
1914 2019-07-03 Pedro Alves <palves@redhat.com>
1916 * cli/cli-option.c (union option_value) <string>: New field.
1917 (struct option_def_and_value): Add ctor, move ctor, dtor and
1918 use DISABLE_COPY_AND_ASSIGN.
1919 (option_def_and_value::clear_value): New.
1920 (parse_option, save_option_value_in_ctx, get_val_type_str)
1921 (add_setshow_cmds_for_options): Handle var_string.
1922 * cli-option.h (union option_def::var_address) <string>: New
1924 (struct string_option_def): New.
1925 * maint-test-options.c (struct test_options_opts): Add default
1926 ctor and use DISABLE_COPY_AND_ASSIGN.
1927 <string_opt>: New field.
1928 (test_options_opts::~test_options_opts): New.
1929 (test_options_opts::dump): Also dump "-string".
1930 (test_options_option_defs): Install "string.
1932 2019-07-03 Pedro Alves <palves@redhat.com>
1934 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1935 option_value with a null enumeration.
1936 (complete_options): Save the option values in the context.
1937 (save_option_value_in_ctx): New, factored out from ...
1938 (process_options): ... here.
1939 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1941 * maint-test-options.c (test_options_opts::dump): New, factored
1943 (maintenance_test_options_command_mode): ... here.
1944 (maintenance_test_options_command_completion_result): Delete.
1945 (maintenance_test_options_command_completion_text): Update
1947 (maintenance_show_test_options_completion_result): Change
1948 prototype. Just print
1949 maintenance_test_options_command_completion_text.
1950 (save_completion_result): New.
1951 (maintenance_test_options_completer_mode): Pass options context to
1952 complete_options, and then save a dump.
1953 (_initialize_maint_test_options): Use add_cmd to install "maint
1954 show test-options-completion-result".
1956 2019-07-03 Pedro Alves <palves@redhat.com>
1958 * NEWS (New commands): Mention "with" and "maint with".
1959 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1960 (with_command, with_command_completer): New.
1961 (pipe_command): Adjust to new repeat_previous
1963 (_initialize_cli_cmds): Install the "with" command and its "w"
1965 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1967 * cli/cli-setshow.c (parse_cli_var_uinteger)
1968 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1969 argument strings for all var_types.
1970 (get_setshow_command_value_string): New, factored out from ...
1971 (do_show_command): ... this.
1972 * cli/cli-setshow.h: Include <string>.
1973 (get_setshow_command_value_string): Declare.
1974 * command.h (repeat_previous): Now returns const char *. Adjust
1976 * maint.c: Include "cli/cli-cmds.h".
1977 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1978 (_initialize_maint_cmds): Register the "maintenance with" command.
1979 * top.c (repeat_previous): Move bits from pipe_command here:
1980 Return the saved command line, if any; error out if there's no
1981 command to relaunch.
1983 2019-07-03 Pedro Alves <palves@redhat.com>
1985 * NEWS (New commands): Mention "maint set/show test-settings"
1986 instead of "maint test-settings".
1987 * maint-test-settings.c (maintenance_test_settings_list): Delete.
1988 (maintenance_test_settings_set_list): Rename to ...
1989 (maintenance_set_test_settings_list): ... this.
1990 (maintenance_test_settings_show_list): Rename to ...
1991 (maintenance_show_test_settings_list): ... this.
1992 (maintenance_test_settings_cmd): Delete.
1993 (maintenance_test_settings_set_cmd): ...
1994 (maintenance_set_test_settings_cmd): ... this.
1995 (maintenance_test_settings_show_cmd): ...
1996 (maintenance_show_test_settings_cmd): ... this.
1997 (maintenance_test_settings_show_value_cmd):
1998 (maintenance_show_test_settings_value_cmd): ... this.
1999 (_initialize_maint_test_settings): No longer install the "maint
2000 test-settings" prefix command. Rename "maint test-settings set"
2001 to "maint set test-settings", and "maint test-settings show" to
2002 "maint show test-settings". Adjust all subcommands.
2004 2019-07-03 Pedro Alves <palves@redhat.com>
2006 * maint-test-settings.c: Fix file's intro comment. Replace all
2007 references to "test-options" with references to "test-settings",
2010 2019-07-03 Pedro Alves <palves@redhat.com>
2012 * maint-test-settings.c (maintenance_test_settings_xxx)
2013 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2015 (maintenance_test_settings_enums): Use them.
2016 (maintenance_test_settings_enum): Default to
2017 maintenance_test_settings_xxx.
2018 (_initialize_maint_test_settings): Initialize
2019 MAINTENANCE_TEST_SETTINGS_FILENAME.
2021 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2023 * breakpoint.h (remove_breakpoints_inf): Change return type to
2024 void, move function documentation here.
2025 * breakpoint.c (remove_breakpoints_inf): Change return type to
2026 void, move function documentation to header.
2028 2019-07-02 Pedro Alves <palves@redhat.com>
2030 * NEWS (Completion improvements): Mention "info threads".
2031 * thread.c (struct info_threads_opts, info_threads_option_defs)
2032 (make_info_threads_options_def_group): New.
2033 (info_threads_command): Use gdb::option::process_options.
2034 (info_threads_command_completer): New.
2035 (_initialize_thread): Use gdb::option::build_help to build the
2036 help text for "info threads".
2038 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2040 * defs.h (generic_load): Move from here...
2041 * symfile.h (generic_load): ... to here. Rename name parameter
2043 * symfile.c (generic_load): Add comment.
2045 2019-07-01 Tom Tromey <tromey@adacore.com>
2048 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2049 declaration of without_params. Fix formatting.
2051 2019-07-01 Tom Tromey <tromey@adacore.com>
2053 * ada-exp.y (find_primitive_type): Update.
2054 * ada-lang.h (ada_lookup_symbol): Update.
2055 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2057 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2059 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2061 PR breakpoints/24541
2062 * gdbarch.c: Regenerate.
2063 * gdbarch.h: Regenerate.
2064 * gdbarch.sh: Add 'stap_adjust_register'.
2065 * i386-tdep.c: Include '<unordered_set>'.
2066 (i386_stap_adjust_register): New function.
2067 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2068 * stap-probe.c (stap_parse_register_operand): Call
2069 'gdbarch_stap_adjust_register'.
2071 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2074 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2075 * python/python.c (do_start_initialization): Use 'xmalloc'
2076 instead of 'PyMem_Malloc'.
2078 2019-06-28 Tom Tromey <tromey@adacore.com>
2080 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2083 2019-06-27 Tom Tromey <tromey@adacore.com>
2085 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2087 (arm_find_mapping_symbol, arm_record_special_symbol)
2088 (_initialize_arm_tdep): Update.
2089 (arm_objfile_data_free): Remove.
2091 2019-06-27 Tom Tromey <tromey@adacore.com>
2093 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2094 to cp_print_static_field.
2096 2019-06-26 Tom Tromey <tromey@adacore.com>
2098 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2099 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2102 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2104 * features/aarch64-core.c (create_feature_aarch64_core):
2106 * features/aarch64-core.xml: Add cpsr flags.
2108 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2110 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2111 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2113 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2115 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2117 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2119 (arm_record_special_symbol): Don't insert new symbol in sorted
2120 position, push it at the end.
2122 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2124 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2125 (arm_mapping_symbol_s): Remove.
2126 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2127 (arm_mapping_symbol_vec): New typedef.
2128 (struct arm_per_objfile): Add constructor.
2129 <section_maps>: Change type to
2130 std::unique_ptr<arm_mapping_symbol_vec[]>.
2131 (arm_compare_mapping_symbols): Remove.
2132 (arm_find_mapping_symbol): Adjust to section_maps type change.
2133 (arm_objfile_data_free): Call delete on arm_per_objfile.
2134 (arm_record_special_symbol): Adjust to section_maps type change.
2135 Allocate arm_per_objfile with new.
2137 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2139 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2140 with the command prefix.
2142 2019-06-25 Tom Tromey <tom@tromey.com>
2144 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2145 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2147 2019-06-25 Tom Tromey <tom@tromey.com>
2149 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2151 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2154 2019-06-25 Tom Tromey <tom@tromey.com>
2156 * tui/tui-winsource.c
2157 (tui_source_window_base::set_is_exec_point_at): Add check against
2160 2019-06-25 Tom Tromey <tom@tromey.com>
2162 * tui/tui-source.c (tui_set_source_content): Don't check before
2164 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2166 2019-06-25 Tom Tromey <tom@tromey.com>
2168 * tui/tui-winsource.h (tui_update_source_window_as_is)
2169 (tui_alloc_source_buffer, tui_line_is_displayed)
2170 (tui_addr_is_displayed): Change type of win_info.
2171 * tui/tui-winsource.c (tui_update_source_window_as_is)
2172 (tui_clear_source_content, tui_show_source_line)
2173 (tui_show_source_content, tui_source_window_base::refill)
2174 (tui_source_window_base::set_is_exec_point_at)
2175 (tui_source_window_base::set_is_exec_point_at)
2176 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2177 (tui_alloc_source_buffer, tui_line_is_displayed)
2178 (tui_addr_is_displayed): Change type of win_info. Update.
2179 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2180 (tui_source_window_base::do_make_visible_with_new_height):
2182 * tui/tui-source.c (tui_set_source_content)
2183 (tui_set_source_content_nil)
2184 (tui_source_window::do_scroll_vertical): Update.
2185 * tui/tui-layout.c (show_layout): Update.
2186 * tui/tui-disasm.c (tui_set_disassem_content)
2187 (tui_disasm_window::do_scroll_vertical): Update.
2188 * tui/tui-data.h (tui_win_content): Remove.
2189 (struct tui_gen_win_info) <content, content_size>: Remove.
2190 (struct tui_source_element): Add initializers and destructor.
2191 (union tui_which_element, struct tui_win_element): Remove.
2192 (struct tui_source_window_base) <content>: New field.
2193 (struct tui_data_window): Remove destructor.
2194 (tui_alloc_content, tui_free_win_content)
2195 (tui_free_all_source_wins_content): Don't declare.
2196 * tui/tui-data.c (tui_initialize_static_data): Update.
2197 (init_content_element, tui_alloc_content): Remove.
2198 (~tui_gen_win_info): Update.
2199 (~tui_data_window, tui_free_all_source_wins_content)
2200 (tui_free_win_content, free_content, free_content_elements):
2203 2019-06-25 Tom Tromey <tom@tromey.com>
2205 * tui/tui-winsource.h (tui_clear_source_content)
2206 (tui_erase_source_content, tui_show_source_content): Change type
2208 * tui/tui-winsource.c (tui_clear_source_content)
2209 (tui_erase_source_content, tui_show_source_content): Change type
2211 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2212 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2214 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2216 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2218 2019-06-25 Tom Tromey <tom@tromey.com>
2220 * tui/tui-winsource.c (tui_clear_source_content)
2221 (tui_source_window_base::set_is_exec_point_at): Update.
2222 * tui/tui-source.c (tui_set_source_content_nil): Update.
2223 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2225 * tui/tui-data.c (init_content_element): Update.
2227 2019-06-25 Tom Tromey <tom@tromey.com>
2229 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2230 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2231 * tui/tui-layout.c (init_and_make_win): Update.
2232 * tui/tui.h (enum tui_win_type): Update.
2233 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2234 tui_win_is_auxillary.
2235 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2236 tui_win_is_auxillary.
2238 2019-06-25 Tom Tromey <tom@tromey.com>
2240 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2241 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2242 (tui_delete_data_content_windows, tui_display_all_data)
2243 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2245 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2246 * tui/tui-regs.c (tui_last_regs_line_no)
2247 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2248 (tui_show_registers): Update.
2249 (tui_show_register_group): Return void. Update.
2250 (tui_display_registers_from, tui_display_reg_element_at_line)
2251 (tui_display_registers_from_line, tui_check_register_values):
2253 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2255 (struct tui_data_window) <regs_content>: Now a std::vector.
2256 <regs_content_count>: Remove.
2257 (tui_add_content_elements, tui_free_data_content): Don't declare.
2258 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2259 (init_content_element): Remove DATA_WIN case. Add assert.
2260 (tui_add_content_elements): Remove.
2261 (tui_data_window): Update.
2262 (tui_free_data_content): Remove.
2263 (free_content_elements): Remove DATA_WIN case.
2265 2019-06-25 Tom Tromey <tom@tromey.com>
2267 * tui/tui-data.c (tui_data_item_window): Update.
2268 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2269 * tui/tui-windata.c (tui_display_all_data)
2270 (tui_display_data_from_line): Update.
2271 (tui_check_data_values): Remove.
2272 * tui/tui-regs.c (tui_show_register_group)
2273 (tui_display_reg_element_at_line): Update.
2274 * tui/tui-hooks.c (tui_register_changed)
2275 (tui_refresh_frame_and_register_information): Call
2276 tui_check_register_values.
2277 * tui/tui-data.h (struct tui_data_window) <data_content,
2278 data_content_count, data_type>: Remove.
2279 (enum tui_data_type): Remove.
2281 * tui/tui-data.c (tui_data_window::clear_detail)
2282 (~tui_data_window): Update.
2284 2019-06-25 Tom Tromey <tom@tromey.com>
2286 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2288 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2289 Rename from tui_first_data_item_displayed. Update.
2290 (tui_data_window::refresh_all)
2291 (tui_data_window::do_scroll_vertical): Update.
2292 * tui/tui-data.h (struct tui_data_window)
2293 <first_data_item_displayed>: Declare new method.
2295 2019-06-25 Tom Tromey <tom@tromey.com>
2297 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2298 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2300 (tui_initialize_static_data): ...here.
2302 2019-06-25 Tom Tromey <tom@tromey.com>
2304 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2305 (tui_display_registers_from, tui_check_register_values): Update.
2306 (tui_display_register): Remove win_info parameter; update.
2307 (tui_get_register): Change type of parameters.
2308 * tui/tui-data.h (struct tui_data_element): Remove.
2309 (union tui_which_element) <data>: Remove.
2310 <data_window>: Change type.
2311 (struct tui_data_item_window): New.
2312 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2314 (~tui_data_item_window): New destructor.
2315 (free_content_elements): Remove DATA_ITEM_WIN case.
2317 2019-06-25 Tom Tromey <tom@tromey.com>
2319 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2322 2019-06-25 Tom Tromey <tom@tromey.com>
2324 * tui/tui-data.h (struct tui_command_element): Remove.
2325 (union tui_which_element) <command>: Remove.
2326 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2328 (free_content_elements): Remove CMD_WIN case.
2330 2019-06-25 Tom Tromey <tom@tromey.com>
2332 * tui/tui-layout.c (tui_set_layout): Update.
2333 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2334 * tui/tui-data.c (layout_def): Update.
2336 2019-06-25 Tom Tromey <tom@tromey.com>
2338 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2339 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2340 (tui_source_window_base::set_new_height): Update.
2341 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2343 (tui_set_locator_fullname, tui_set_locator_info)
2344 (tui_show_frame_info): Update.
2345 * tui/tui-source.c (tui_set_source_content)
2346 (tui_source_is_displayed): Update.
2347 * tui/tui-layout.c (show_source_disasm_command, show_data)
2348 (show_source_or_disasm_and_command): Update.
2349 * tui/tui-disasm.c (tui_set_disassem_content)
2350 (tui_get_begin_asm_address): Update.
2351 * tui/tui-data.h (struct tui_locator_element): Remove.
2352 (union tui_which_element) <locator>: Remove.
2353 (struct tui_locator_window): New.
2354 (tui_locator_win_info_ptr): Change return type.
2355 * tui/tui-data.c (_locator): Change type.
2356 (tui_locator_win_info_ptr): Change return type.
2357 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2358 (tui_alloc_content): Add assert.
2360 2019-06-25 Tom Tromey <tom@tromey.com>
2362 * tui/tui-winsource.c
2363 (tui_exec_info_window::maybe_allocate_content): New method.
2364 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2365 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2366 (make_source_or_disasm_window): Add cast.
2367 * tui/tui-data.h (union tui_which_element) <simple_string>:
2369 (struct tui_source_info): New.
2370 (struct tui_source_window_base) <execution_info>: Change type.
2371 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2372 case, and add assert.
2373 (tui_alloc_content): Add assert.
2375 2019-06-25 Tom Tromey <tom@tromey.com>
2377 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2378 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2379 * tui/tui-data.c (tui_alloc_win_info): Remove.
2381 2019-06-25 Tom Tromey <tom@tromey.com>
2383 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2384 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2387 2019-06-25 Tom Tromey <tom@tromey.com>
2389 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2390 make_visible_with_new_height method.
2391 (tui_win_info::make_visible_with_new_height): New method.
2392 (tui_source_window_base::do_make_visible_with_new_height)
2393 (tui_data_window::do_make_visible_with_new_height)
2394 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2395 (make_visible_with_new_height): Remove.
2396 (tui_resize_all, tui_adjust_win_heights): Use
2397 make_visible_with_new_height method.
2398 * tui/tui-data.h (struct tui_win_info)
2399 <do_make_visible_with_new_height, make_visible_with_new_height>:
2401 (struct tui_source_window_base, struct tui_data_window)
2402 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2405 2019-06-25 Tom Tromey <tom@tromey.com>
2407 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2409 (update_tab_width): Call update_tab_width method.
2410 * tui/tui-data.h (struct tui_win_info)
2411 (struct tui_source_window_base) <update_tab_width>: New methods.
2413 2019-06-25 Tom Tromey <tom@tromey.com>
2415 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2417 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2419 (tui_gen_win_info::make_visible): Update.
2420 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2422 * tui/tui-data.h (enum tui_box): New enum.
2423 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2425 2019-06-25 Tom Tromey <tom@tromey.com>
2427 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2428 init_and_make_win for EXEC_INFO_WIN.
2429 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2431 (struct tui_win_info) <~tui_win_info>: Inline.
2432 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2434 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2435 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2437 (tui_initialize_static_data): Update.
2438 (~tui_gen_win_info): Handle more cleanup here.
2439 (~tui_source_window_base): Delete "execution_info".
2440 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2442 2019-06-25 Tom Tromey <tom@tromey.com>
2444 * tui/tui-layout.c (make_command_window): Don't set
2446 (show_source_disasm_command): Call the reset method.
2447 (show_data): Don't set can_highlight. Call the reset method.
2448 (tui_gen_win_info::reset): Rename from init_gen_win_info
2449 (init_and_make_win): Simplify. Return tui_gen_win_info.
2450 (show_source_or_disasm_and_command): Call the reset method.
2451 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2452 (struct tui_cmd_window): Set can_highlight.
2454 2019-06-25 Tom Tromey <tom@tromey.com>
2456 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2458 (tui_make_visible, tui_make_invisible): Rewrite.
2459 (tui_win_info::make_visible): Remove.
2460 (tui_source_window_base::make_visible): Update.
2461 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2462 method. Moved from...
2463 (struct tui_win_info) <make_visible>: ...here.
2465 2019-06-25 Tom Tromey <tom@tromey.com>
2467 * tui/tui-winsource.c
2468 (tui_source_window_base::do_scroll_horizontal): Remove direction
2470 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2471 direction parameter.
2472 * tui/tui-win.c (tui_win_info::forward_scroll)
2473 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2474 (tui_win_info::right_scroll): Update.
2475 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2476 direction parameter.
2477 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2478 direction parameter.
2479 * tui/tui-data.h (enum tui_scroll_direction): Remove.
2480 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2481 Remove direction parameter.
2482 (struct tui_source_window_base, struct tui_source_window)
2483 (struct tui_disasm_window, struct tui_data_window)
2484 (struct tui_cmd_window): Update.
2486 2019-06-25 Tom Tromey <tom@tromey.com>
2488 * tui/tui-winsource.h (tui_set_exec_info_content)
2489 (tui_show_exec_info_content, tui_erase_exec_info_content)
2490 (tui_clear_exec_info_content, tui_update_exec_info): Change
2491 argument to tui_source_window_base.
2492 * tui/tui-winsource.c (tui_set_exec_info_content)
2493 (tui_show_exec_info_content, tui_erase_exec_info_content)
2494 (tui_clear_exec_info_content, tui_update_exec_info): Change
2495 argument to tui_source_window_base.
2497 2019-06-25 Tom Tromey <tom@tromey.com>
2499 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2500 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2502 2019-06-25 Tom Tromey <tom@tromey.com>
2504 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2507 2019-06-25 Tom Tromey <tom@tromey.com>
2509 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2511 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2513 * tui/tui-source.c (tui_set_source_content): Update.
2514 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2516 2019-06-25 Tom Tromey <tom@tromey.com>
2518 * tui/tui-win.c (window_name_completer, tui_set_focus)
2519 (tui_all_windows_info): Use name method.
2520 * tui/tui-data.h (struct tui_gen_win_info)
2521 (struct tui_source_window, struct tui_disasm_window)
2522 (struct tui_data_window, struct tui_cmd_window) <name>: New
2524 (tui_win_name): Don't declare.
2525 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2526 (tui_win_name): Remove.
2528 2019-06-25 Tom Tromey <tom@tromey.com>
2530 * tui/tui-winsource.h (tui_update_source_window)
2531 (tui_update_source_window_as_is): Change parameter type.
2532 * tui/tui-winsource.c (tui_update_source_window): Change win_info
2533 to be a tui_source_window_base.
2534 (tui_update_source_window_as_is): Likewise.
2535 * tui/tui-win.c (make_visible_with_new_height): Update.
2537 2019-06-25 Tom Tromey <tom@tromey.com>
2539 * tui/tui-winsource.c (tui_erase_source_content)
2540 (tui_show_source_content, tui_show_exec_info_content)
2541 (tui_erase_exec_info_content): Use refresh_window method.
2542 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2543 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2544 from tui_refresh_win.
2545 (tui_data_window::refresh_window): New method.
2546 (tui_win_info::refresh, tui_source_window_base::refresh)
2547 (tui_refresh_all): Use refresh_window method.
2548 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2550 * tui/tui-regs.c (tui_display_register): Call refresh_window
2552 * tui/tui-layout.c (show_source_disasm_command)
2553 (show_source_or_disasm_and_command): Call refresh_window method.
2554 * tui/tui-data.h (struct tui_gen_win_info)
2555 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2558 2019-06-25 Tom Tromey <tom@tromey.com>
2560 * tui/tui.c (tui_rl_other_window, tui_enable)
2561 (tui_is_window_visible, tui_get_command_dimension): Update.
2562 * tui/tui-winsource.c (tui_update_source_window_as_is)
2563 (tui_clear_source_content, tui_erase_source_content)
2564 (tui_show_source_line, tui_source_window_base::refill)
2565 (tui_source_window_base::do_scroll_horizontal)
2566 (tui_source_window_base::set_is_exec_point_at)
2567 (tui_update_breakpoint_info, tui_set_exec_info_content)
2568 (tui_alloc_source_buffer, tui_line_is_displayed)
2569 (tui_addr_is_displayed): Update.
2570 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2571 (tui_check_and_display_highlight_if_needed)
2572 (tui_win_info::make_visible, tui_win_info::refresh)
2573 (tui_refresh_all): Update.
2574 * tui/tui-windata.c (tui_first_data_item_displayed)
2575 (tui_delete_data_content_windows, tui_erase_data_content)
2576 (tui_display_all_data, tui_data_window::refresh_all)
2577 (tui_check_data_values): Update.
2578 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2579 (tui_set_win_focus_to, tui_win_info::forward_scroll)
2580 (tui_win_info::backward_scroll, tui_refresh_all_win)
2581 (tui_resize_all, tui_set_focus, tui_all_windows_info)
2582 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2583 (tui_source_window_base::set_new_height)
2584 (tui_data_window::set_new_height)
2585 (make_invisible_and_set_new_height)
2586 (make_visible_with_new_height, new_height_ok)
2587 (parse_scrolling_args): Update.
2588 * tui/tui-stack.c (tui_show_frame_info): Update.
2589 * tui/tui-source.c (tui_set_source_content)
2590 (tui_set_source_content_nil, tui_source_is_displayed)
2591 (tui_source_window::do_scroll_vertical): Update.
2592 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2593 (tui_display_registers_from, tui_display_reg_element_at_line)
2594 (tui_check_register_values, tui_reg_command): Update.
2595 * tui/tui-layout.c (tui_default_win_height)
2596 (show_source_disasm_command, show_data, init_and_make_win)
2597 (show_source_or_disasm_and_command): Update.
2598 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2599 (tui_redisplay_readline, tui_mld_flush)
2600 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2602 * tui/tui-disasm.c (tui_set_disassem_content)
2603 (tui_disasm_window::do_scroll_vertical): Update.
2604 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2606 (struct tui_win_info): Derive from tui_gen_win_info.
2607 <~tui_win_info>: Mark as override.
2608 <generic>: Remove member.
2609 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2610 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2611 (~tui_data_window, ~tui_win_info)
2612 (tui_free_all_source_wins_content): Update.
2613 * tui/tui-command.c (tui_refresh_cmd_win): Update.
2615 2019-06-25 Tom Tromey <tom@tromey.com>
2617 * tui/tui-layout.c (init_and_make_win): Use new.
2618 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2619 destructor, initializers.
2620 (tui_alloc_generic_win_info): Don't declare.
2621 * tui/tui-data.c (_locator): Add argument to constructor.
2622 (source_win, disasm_win): New globals.
2623 (exec_info): Remove.
2624 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2626 (tui_alloc_generic_win_info): Remove.
2627 (init_content_element): Use new.
2628 (tui_win_info::tui_win_info): Update.
2629 (free_content_elements) <case DATA_WIN>: Use delete.
2631 2019-06-25 Tom Tromey <tom@tromey.com>
2633 * tui/tui-wingeneral.c (tui_refresh_win): Update.
2634 * tui/tui-windata.c (tui_first_data_item_displayed)
2635 (tui_delete_data_content_windows): Update.
2636 * tui/tui-win.c (tui_data_window::set_new_height): Update.
2637 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2638 (tui_display_registers_from, tui_check_register_values): Update.
2639 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2641 * tui/tui-data.c (init_content_element): Update. Allocate the new
2643 (tui_free_data_content): Update.
2644 (free_content_elements) <case DATA_WIN>: Free the window.
2646 2019-06-25 Tom Tromey <tom@tromey.com>
2648 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2650 * tui/tui-layout.c (make_command_window)
2651 (show_source_disasm_command, show_data, init_and_make_win)
2652 (show_source_or_disasm_and_command): Update.
2653 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2655 <can_highight, is_highlighted>: Now bool.
2656 (tui_set_win_highlight): Don't declare.
2657 * tui/tui-data.c (tui_set_win_highlight): Remove.
2659 2019-06-25 Tom Tromey <tom@tromey.com>
2661 * tui/tui-wingeneral.c (make_visible): Remove check of window
2664 2019-06-25 Tom Tromey <tom@tromey.com>
2666 * tui/tui-win.c (tui_win_info::max_height)
2667 (tui_cmd_window::max_height): New methods.
2668 (new_height_ok): Call max_height.
2669 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2670 <max_height>: New method.
2672 2019-06-25 Tom Tromey <tom@tromey.com>
2674 * tui/tui-win.c (tui_source_window_base::set_new_height)
2675 (tui_data_window::set_new_height): New methods.
2676 (make_invisible_and_set_new_height): Call set_new_height method.
2677 * tui/tui-data.h (struct tui_win_info)
2678 (struct tui_source_window_base, struct tui_data_window)
2679 <set_new_height>: New method.
2681 2019-06-25 Tom Tromey <tom@tromey.com>
2683 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2684 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2685 tui_refresh_data_win.
2686 * tui/tui-win.c (tui_source_window_base::refresh_all): New
2688 (tui_refresh_all_win): Call the refresh_all method.
2689 (tui_set_focus): Likewise.
2690 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2691 (struct tui_source_window_base, struct tui_data_window) <refresh>:
2694 2019-06-25 Tom Tromey <tom@tromey.com>
2696 * tui/tui-winsource.h (tui_refill_source_window)
2697 (tui_set_is_exec_point_at): Don't declare.
2698 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2699 (tui_source_window_base::refill): Rename from
2700 tui_refill_source_window.
2701 (tui_source_window_base::do_scroll_horizontal): Update.
2702 (tui_source_window_base::set_is_exec_point_at): Rename from
2703 tui_set_is_exec_point_at.
2704 (tui_update_all_breakpoint_info): Update.
2705 * tui/tui-stack.c (tui_show_frame_info): Update.
2706 * tui/tui-layout.c (show_data): Add cast.
2707 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2708 * tui/tui-data.h (struct tui_source_window_base) <refill,
2709 set_is_exec_point_at>: New methods.
2710 (tui_source_windows, tui_add_to_source_windows): Update types.
2711 (tui_add_to_source_windows): Remove redundant declaration.
2712 * tui/tui-data.c (source_windows): Store tui_source_window_base.
2713 (tui_source_windows): Change return type.
2714 (tui_clear_source_windows_detail): Update.
2715 (tui_add_to_source_windows): Change type of parameter.
2716 (tui_free_all_source_wins_content): Update.
2718 2019-06-25 Tom Tromey <tom@tromey.com>
2720 * tui/tui-wingeneral.c (tui_win_info::refresh)
2721 (tui_source_window_base::refresh): New methods.
2722 (tui_refresh_all): Call the refresh method.
2723 * tui/tui-data.h (struct tui_win_info)
2724 (struct tui_source_window_base) <refresh>: New method.
2726 2019-06-25 Tom Tromey <tom@tromey.com>
2728 * tui/tui.h (tui_is_window_visible): Return bool.
2729 * tui/tui.c (tui_is_window_visible): Return bool.
2730 * tui/tui-wingeneral.c (tui_make_window, make_visible)
2731 (tui_make_visible, tui_make_invisible)
2732 (tui_win_info::make_visible)
2733 (tui_source_window_base::make_visible, make_all_visible)
2734 (tui_make_all_visible, tui_make_all_invisible): Update.
2735 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2736 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2738 (struct tui_win_info, struct tui_source_window_base)
2739 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2740 * tui/tui-data.c (tui_init_generic_part): Update.
2742 2019-06-25 Tom Tromey <tom@tromey.com>
2744 * tui/tui-wingeneral.c (tui_win_info::make_visible)
2745 (tui_source_window_base::make_visible): New methods.
2746 (make_all_visible): Make method call.
2747 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2748 (struct tui_source_window_base, struct tui_cmd_window): Override
2750 (tui_win_is_source_type): Don't declare.
2751 * tui/tui-data.c (tui_win_is_source_type): Remove.
2753 2019-06-25 Tom Tromey <tom@tromey.com>
2755 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2758 2019-06-25 Tom Tromey <tom@tromey.com>
2760 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2761 Inline constructor. Add initializers for members.
2762 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2763 constructors; now inline in class.
2765 2019-06-25 Tom Tromey <tom@tromey.com>
2767 * tui/tui-regs.c (tui_show_registers): Update.
2768 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2770 * tui/tui-data.c (tui_data_window::clear_detail)
2771 (tui_data_window): Update.
2773 2019-06-25 Tom Tromey <tom@tromey.com>
2775 * tui/tui-windata.c (tui_display_all_data)
2776 (tui_display_data_from_line, tui_display_data_from)
2777 (tui_check_data_values, tui_data_window::do_scroll_vertical):
2779 * tui/tui-regs.c (tui_last_regs_line_no)
2780 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2781 (tui_show_registers, tui_show_register_group)
2782 (tui_display_registers_from, tui_display_reg_element_at_line)
2783 (tui_display_registers_from_line, tui_check_register_values)
2784 (tui_reg_next, tui_reg_prev): Update.
2785 * tui/tui-layout.c (tui_set_layout, show_data): Update.
2786 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
2788 (struct tui_win_info) <detail>: Remove. Add new fields from
2790 (TUI_DATA_WIN): Add cast.
2791 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2792 (~tui_data_window): Simplify.
2794 2019-06-25 Tom Tromey <tom@tromey.com>
2796 * tui/tui-layout.c (show_source_disasm_command)
2797 (show_source_or_disasm_and_command): Update.
2798 * tui/tui-io.c (update_cmdwin_start_line)
2799 (tui_redisplay_readline): Update.
2800 * tui/tui-data.h (struct tui_command_info): Remove.
2801 (struct tui_win_info) <detail>: Remove command_info member.
2802 (struct tui_data_window) <start_line>: New member, from
2804 (TUI_CMD_WIN): Add casts.
2806 2019-06-25 Tom Tromey <tom@tromey.com>
2808 * tui/tui-winsource.c (tui_update_source_window)
2809 (tui_refill_source_window)
2810 (tui_source_window_base::do_scroll_horizontal)
2811 (tui_update_breakpoint_info, tui_set_exec_info_content)
2812 (tui_show_exec_info_content, tui_erase_exec_info_content)
2813 (tui_clear_exec_info_content): Update.
2814 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2816 * tui/tui-win.c (make_invisible_and_set_new_height)
2817 (make_visible_with_new_height): Update.
2818 * tui/tui-source.c (tui_set_source_content)
2819 (tui_show_symtab_source): Update.
2820 * tui/tui-layout.c (extract_display_start_addr)
2821 (show_source_disasm_command, show_data)
2822 (make_source_or_disasm_window)
2823 (show_source_or_disasm_and_command): Update.
2824 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2825 (tui_disasm_window::do_scroll_vertical): Remove shadowing
2827 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
2828 to tui_source_window_base.
2829 (struct tui_win_info) <detail>: Remove source_info member.
2830 (struct tui_source_window_base) <has_locator>: Inline.
2831 Move contents from tui_source_info; rename has_locator member to
2833 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2834 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2836 (tui_source_window_base::clear_detail, ~tui_source_window_base):
2838 (tui_free_all_source_wins_content): Cast to
2839 tui_source_window_base.
2841 2019-06-25 Tom Tromey <tom@tromey.com>
2843 * tui/tui-win.c (make_invisible_and_set_new_height)
2844 (make_visible_with_new_height): Call has_locator method.
2845 * tui/tui-layout.c (show_source_disasm_command, show_data)
2846 (show_source_or_disasm_and_command): Update for bool change.
2847 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2848 (tui_win_info) <has_locator>: New method.
2849 (struct tui_source_window_base) <has_locator>: New method.
2850 (tui_win_has_locator): Don't declare.
2851 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2852 from tui_win_has_locator.
2853 (tui_source_window_base): Use false, not FALSE.
2855 2019-06-25 Tom Tromey <tom@tromey.com>
2857 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2858 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2859 clear_detail method directly.
2860 (tui_clear_win_detail): Remove.
2862 2019-06-25 Tom Tromey <tom@tromey.com>
2864 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2865 "this", not TUI_DISASM_WIN.
2867 2019-06-25 Tom Tromey <tom@tromey.com>
2869 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
2871 * tui/tui-winsource.c
2872 (tui_source_window_base::do_scroll_horizontal): Rename from
2873 tui_horizontal_source_scroll.
2874 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2875 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2876 from tui_vertical_data_scroll.
2877 * tui/tui-win.h (tui_scroll): Don't declare.
2878 * tui/tui-win.c (tui_win_info::forward_scroll)
2879 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2880 (tui_win_info::right_scroll): Rename and update.
2881 (tui_scroll_forward_command, tui_scroll_backward_command)
2882 (tui_scroll_left_command, tui_scroll_right_command): Update.
2883 (tui_scroll): Remove.
2884 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2885 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2886 from tui_vertical_source_scroll.
2887 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2888 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2889 from tui_vertical_disassem_scroll.
2890 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2891 do_scroll_horizontal>: New methods.
2892 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2894 (struct tui_source_window_base): Add do_scroll_horizontal.
2895 (struct tui_source_window, struct tui_disasm_window): Add
2897 (struct tui_data_window, struct tui_cmd_window): Add
2898 do_scroll_horizontal and do_scroll_vertical.
2899 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2901 2019-06-25 Tom Tromey <tom@tromey.com>
2903 * tui/tui-data.h (struct tui_source_window_base): New struct.
2904 (struct tui_source_window): Derive from tui_source_window_base.
2905 (struct tui_disasm_window): New struct.
2906 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2907 from tui_source_window::clear_detail.
2908 (tui_source_window_base): Rename from tui_source_window.
2909 (~tui_source_window_base): Rename from ~tui_source_window.
2910 (tui_alloc_win_info): Create a tui_disasm_window.
2912 2019-06-25 Tom Tromey <tom@tromey.com>
2914 * tui/tui-data.h (struct tui_source_window)
2915 (struct tui_data_window): Declare destructors.
2916 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2918 (tui_win_info): Simplify.
2920 2019-06-25 Tom Tromey <tom@tromey.com>
2922 * tui/tui-winsource.c (tui_display_main)
2923 (tui_update_source_windows_with_addr)
2924 (tui_update_all_breakpoint_info): Update.
2925 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2926 (new_height_ok, parse_scrolling_args): Update.
2927 * tui/tui-stack.c (tui_show_frame_info): Update.
2928 * tui/tui-data.h (struct tui_list): Remove.
2929 (tui_source_windows): Return a reference to a std::vector.
2930 * tui/tui-data.c (source_windows): Now a std::vector.
2931 (tui_source_windows): Change return type.
2932 (tui_clear_source_windows): Rewrite.
2933 (tui_clear_source_windows_detail, tui_add_to_source_windows)
2934 (tui_free_all_source_wins_content): Rewrite.
2936 2019-06-25 Tom Tromey <tom@tromey.com>
2938 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2939 (struct tui_data_window, struct tui_cmd_window): Declare
2940 clear_detail method.
2941 * tui/tui-data.c (tui_source_window::clear_detail)
2942 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2944 (tui_clear_win_detail): Simplify.
2946 2019-06-25 Tom Tromey <tom@tromey.com>
2948 * tui/tui-layout.c (make_source_window, make_disasm_window)
2949 (make_source_or_disasm_window): Remove win_info_ptr parameter.
2950 Return the new window.
2951 (show_source_disasm_command, show_data)
2952 (show_source_or_disasm_and_command): Update.
2954 2019-06-25 Tom Tromey <tom@tromey.com>
2956 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2957 parameter. Return the new window.
2958 (show_source_disasm_command): Update and remove NULL check.
2959 (show_source_or_disasm_and_command): Update.
2961 2019-06-25 Tom Tromey <tom@tromey.com>
2963 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2965 2019-06-25 Tom Tromey <tom@tromey.com>
2967 * tui/tui-data.h (struct tui_win_info): Make constructor
2968 protected. Make destructor virtual. Add initializers.
2969 (tui_source_window, tui_data_window, tui_cmd_window): New
2971 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
2972 constructor. Add "type" parameter.
2973 (tui_source_window, tui_data_window, tui_cmd_window): New
2975 (tui_alloc_win_info): Instantiate the appropriate subclass.
2977 2019-06-25 Tom Tromey <tom@tromey.com>
2979 * tui/tui-win.c (tui_resize_all): Use delete.
2980 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2982 (tui_free_window): Don't declare.
2983 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2986 2019-06-25 Tom Tromey <tom@tromey.com>
2988 * tui/tui-data.h (struct tui_win_info): Add constructor.
2989 * tui/tui-data.c (tui_alloc_win_info): Use new.
2990 (tui_free_window): Use delete.
2992 2019-06-22 Tom Tromey <tom@tromey.com>
2994 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2996 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2998 2019-06-22 Tom Tromey <tom@tromey.com>
3000 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3002 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3004 2019-06-22 Tom de Vries <tdevries@suse.de>
3006 * dwarf2read.c (create_addrmap_from_aranges)
3007 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3010 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
3012 * dwarf2read.h (dwarf2_section_info_def): Remove.
3013 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3014 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3015 std::vector<dwarf2_section_info>.
3016 (struct dwo_file) <~dwo_file>: Remove.
3017 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3019 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3020 (dwarf2_read_debug_names): Likewise.
3021 (create_debug_types_hash_table): Change parameter type to
3022 array_view, adjust code accordingly.
3023 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3024 (partial_die_info::fixup): Likewise.
3025 (determine_prefix): Likewise.
3026 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3028 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3030 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3032 <~dwo_file>: Remove call to gdb_bfd_unref.
3033 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3034 gdb_bfd_ref_ptr::get.
3036 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3038 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3040 * dwarf2read.c (struct dwo_file): Initialize fields.
3042 (free_dwo_file): Remove, move content to ~dwo_file.
3043 (struct dwo_file_deleter): Remove.
3044 (dwo_file_up>: Remove custom deleter.
3045 (free_dwo_files): Remove.
3046 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3048 (process_skeletonless_type_units): Call unique_ptr::get.
3049 (allocate_dwo_file_hash_table): Add deleter to created hash
3050 table. Change return type to htab_up.
3051 (lookup_dwo_file_slot): Don't memset dwo_file, call
3053 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3054 (create_dwo_unit_in_dwp_v2): Likewise.
3055 (open_and_init_dwo_file): Likewise.
3056 (free_dwo_file_from_slot): Remove.
3058 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3060 * dwarf2read.h (struct dwarf2_section_info) <readin,
3061 is_virtual>: Change type to bool.
3062 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3065 2019-06-19 Tom Tromey <tom@tromey.com>
3067 * tui/tui-data.h (tui_init_content_element): Don't declare.
3069 2019-06-19 Tom Tromey <tom@tromey.com>
3071 * tui/tui-data.h (tui_init_win_info): Don't declare.
3073 2019-06-19 Tom de Vries <tdevries@suse.de>
3075 * dwarf2read.h (abstract_to_concrete): Change type to
3076 std::unordered_map<sect_offset, std::vector<sect_offset>,
3077 gdb::hash_enum<sect_offset>>.
3079 2019-06-19 Tom Tromey <tromey@adacore.com>
3081 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3082 EVAL_AVOID_SIDE_EFFECTS specially.
3084 2019-06-19 Tom Tromey <tromey@adacore.com>
3086 * source-cache.c (highlighter): New global.
3087 (source_cache::get_source_lines): Create a highlighter on demand.
3089 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3091 * defs.h (deprecated_interactive_hook): Delete declaration.
3092 * interps.c (clear_interpreter_hooks): Remove use of
3093 deprecated_interactive_hook.
3094 * top.c (deprecated_interactive_hook): Delete definition.
3095 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3097 2019-06-18 Tom de Vries <tdevries@suse.de>
3100 * dwarf2read.h (abstract_to_concrete): Change type from
3101 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3102 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3103 * dwarf2read.c (read_variable): Update.
3104 (dwarf2_fetch_die_loc_sect_off): Update.
3106 2019-06-17 Tom de Vries <tdevries@suse.de>
3109 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3110 accessing parent[parent_len - 1].
3112 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3115 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3116 call dtrace_process_dof with NULL dof.
3118 2019-06-16 Tom de Vries <tdevries@suse.de>
3121 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3123 2019-06-16 Tom Tromey <tom@tromey.com>
3125 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3126 (make_all_visible): Use address of member.
3128 2019-06-16 Tom Tromey <tom@tromey.com>
3130 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3131 (tui_free_window, free_content, free_content_elements): Remove
3133 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3135 * tui/tui-regs.c (tui_show_register_group)
3136 (tui_display_registers_from, tui_display_reg_element_at_line):
3137 Remove unnecessary cast.
3139 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3141 * linux-nat.c (normal_mask): Delete.
3142 (_initialize_linux_nat): Don't initialise normal_mask.
3144 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3147 * dwarf-index-write.h (write_psymtabs_to_index): Add
3148 dwz_basename parameter.
3149 * dwarf-index-write.c (write_gdbindex): Move file writing to
3150 write_gdbindex_1. Change return type void.
3151 (assert_file_size): Move up, remove filename parameter.
3152 (write_gdbindex_1): New function.
3153 (write_debug_names): Change return type to void, call
3155 (struct index_wip_file): New struct.
3156 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3157 file logic to index_wip_file. Write index for dwz file if
3159 (save_gdb_index_command): Pass basename of dwz file, if present.
3160 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3161 build-id of dwz file, if present.
3162 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3163 (dwarf2_get_dwz_file): Likewise.
3164 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3165 (dwarf2_get_dwz_file): Likewise.
3167 2019-06-16 Tom Tromey <tom@tromey.com>
3169 * coffread.c (process_coff_symbol): Use xstrdup.
3170 * value.c (create_internalvar): Use xstrdup.
3172 2019-06-16 Tom Tromey <tom@tromey.com>
3174 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3175 * breakpoint.c (stopin_command, stopat_command)
3176 (until_break_command, decode_location_default): Remove unnecessary
3178 * utils.c (subset_compare): Remove unnecessary cast.
3179 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3181 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3183 * infcmd.c (path_command): Remove unnecessary cast.
3184 * coffread.c (decode_type): Remove unnecessary cast.
3185 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3186 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3187 * tui/tui-stack.c (tui_show_locator_content)
3188 (tui_show_frame_info): Remove unnecessary cast.
3189 * tui/tui-win.c (tui_scroll_forward_command)
3190 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3191 (parse_scrolling_args): Remove unnecessary cast.
3192 * tui/tui-data.c (init_win_info, tui_del_window)
3193 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3194 (free_content_elements): Remove unnecessary cast.
3195 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3197 * tui/tui-source.c (tui_set_source_content)
3198 (tui_vertical_source_scroll): Remove unnecessary cast.
3199 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3201 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3202 * tui/tui-regs.c (tui_display_registers_from)
3203 (tui_display_register): Remove unnecessary cast.
3204 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3205 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3206 (make_visible): Remove unnecessary cast.
3207 * tui/tui-winsource.c (tui_erase_source_content)
3208 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3210 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3211 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3212 * stabsread.c (read_type, read_array_type, read_range_type):
3213 Remove unnecessary cast.
3214 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3215 (parse_symbol, parse_type, upgrade_type, parse_external)
3216 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3218 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3220 2019-06-16 Tom Tromey <tom@tromey.com>
3222 * tui/tui-data.c (tui_alloc_generic_win_info)
3223 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3226 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3227 Andrew Burgess <andrew.burgess@embecosm.com>
3229 * f-typeprint.c (f_print_type): Don't return early for not
3230 associated or not allocated types.
3231 (f_type_print_varspec_suffix): Add print_rank parameter and print
3232 ranks of array types in case they dangling.
3233 (f_type_print_base): Add print_rank parameter.
3235 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3237 * NEWS: Mention new MI commands.
3238 * break-catch-throw.c (enum exception_event_kind): Move to
3240 (print_mention_exception_catchpoint): Output text as a single
3242 (catch_exception_command_1): Rename to...
3243 (catch_exception_event): ...this, make non-static, update header
3244 command, and change some parameter types.
3245 (catch_catch_command): Update for changes to
3246 catch_exception_command_1.
3247 (catch_throw_command): Likewise.
3248 (catch_rethrow_command): Likewise.
3249 * breakpoint.c (enum exception_event_kind): Delete.
3250 * breakpoint.h (enum exception_event_kind): Moved here from
3251 break-catch-throw.c.
3252 (catch_exception_event): Declare.
3253 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3254 (mi_cmd_catch_throw): New function.
3255 (mi_cmd_catch_rethrow): New function.
3256 (mi_cmd_catch_catch): New function.
3257 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3258 'catch-catch' entries.
3259 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3260 (mi_cmd_catch_rethrow): Declare.
3261 (mi_cmd_catch_catch): Declare.
3263 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3265 * annotate.c (annotate_source_line): Change return type to void,
3266 update implementation to match.
3267 * annotate.h (annotate_source_line): Change return type to void,
3268 update header comment.
3269 * stack.c (print_frame_info): Don't change what frame information
3270 is printed based on whether annotations are on or not.
3272 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3274 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3275 (annotate_source): Make static.
3276 (annotate_source_line): Moved from source.c and renamed from
3277 identify_source_line. Update the return type.
3278 * annotate.h (annotate_source): Delete declaration.
3279 (annotate_source_line): Declaration moved from source.h, and
3280 renamed from identify_source_line. Return type updated.
3281 * source.c (identify_source_line): Moved to annotate.c and renamed
3282 to annotate_source_line.
3283 (info_line_command): Remove check of annotation_level.
3284 * source.h (identify_source_line): Move declaration to annotate.h
3285 and rename to annotate_source_line.
3286 * stack.c: Add 'annotate.h' include.
3287 (print_frame_info): Remove check of annotation_level before
3288 calling annotate_source_line.
3290 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3292 * source-cache.c (source_cache::get_plain_source_lines): Use
3293 open_source_file_with_line_charpos instead of just
3294 open_source_file, remove call to find_source_lines.
3295 (source_cache::get_source_lines): Likewise.
3296 * source.c (find_source_lines): Make static.
3297 (get_filename_and_charpos): Renamed into...
3298 (open_source_file_with_line_charpos): ..this along with changes to
3299 return a scoped_fd, and some other minor clean ups.
3300 (identify_source_line): Use open_source_file_with_line_charpos.
3301 (search_command_helper): Use open_source_file_with_line_charpos
3302 instead of just open_source_file, remove call to
3304 * source.h (open_source_file_with_line_charpos): Declare new
3306 (find_source_lines): Delete declaration.
3308 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3310 * source.c (get_filename_and_charpos): Remove fullname
3312 (identify_source_line): Update call to get_filename_and_charpos.
3314 2019-06-14 Tom Tromey <tromey@adacore.com>
3317 * ui-style.h (skip_ansi_escape): Update comment.
3318 * ui-file.h (class no_terminal_escape_file): New class.
3319 * ui-file.c (no_terminal_escape_file::write)
3320 (no_terminal_escape_file::puts): New methods.
3321 * cli/cli-logging.c (handle_redirections): Use
3322 no_terminal_escape_file.
3324 2019-06-14 Tom Tromey <tromey@adacore.com>
3326 * NEWS: Move convenience variable news above Python news.
3328 2019-06-14 Tom Tromey <tom@tromey.com>
3330 * gnulib: Move directory to top-level.
3331 * configure.ac: Don't configure gnulib.
3332 * configure: Rebuild.
3333 * common/common-defs.h: Use new path to gnulib.
3334 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3336 (INCGNU): Look in new gnulib location.
3337 (HFILES_NO_SRCDIR): Remove gnulib files.
3338 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3339 (generated_files): Remove GNULIB_H.
3340 ($(LIBGNU), all-lib): Remove targets.
3341 (distclean): Don't mention GNULIB_BUILDDIR.
3342 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3344 2019-06-14 Tom Tromey <tromey@adacore.com>
3346 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3347 Warn if symbol file does not provide any symbols.
3349 2019-06-14 Tom Tromey <tromey@adacore.com>
3351 * source.c (find_and_open_source): Respect basenames_may_differ.
3353 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3355 * annotate.c (annotate_breakpoints_invalid): Make use of
3356 scoped_restore_terminal_state.
3357 (annotate_frames_invalid): Likewise.
3359 2019-06-14 Tom Tromey <tromey@adacore.com>
3361 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3362 allow assignment to an internalvar.
3364 2019-06-14 Tom Tromey <tromey@adacore.com>
3366 * ada-lex.l: Allow "_" in attribute names.
3368 2019-06-14 Tom Tromey <tromey@adacore.com>
3371 * regcache.c (registers_changed): Don't call alloca.
3372 * top.c (execute_command): Don't call alloca.
3374 2019-06-13 Pedro Alves <palves@redhat.com>
3376 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3377 'expression'. When parsing an expression, error out if there's
3378 junk after "unlimited".
3379 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3380 (do_set_command): Adjust calls to is_unlimited_literal.
3382 2019-06-13 Pedro Alves <palves@redhat.com>
3384 * compile/compile.c (make_compile_options_def_group): Add braces
3385 around array_view initializer.
3386 * thread.c (make_thread_apply_all_options_def_group)
3387 (make_thread_apply_all_options_def_group): Likewise.
3389 2019-06-13 Pedro Alves <palves@redhat.com>
3391 * NEWS (New commands): Mention "maint test-options
3392 require-delimiter", "maint test-options unknown-is-error", "maint
3393 test-options unknown-is-operand" and "maint show
3394 test-options-completion-result".
3395 (New command options, command completion): New section.
3396 (Completion improvements): New section.
3397 Mention that you can abbreviate "unlimited".
3399 2019-06-13 Pedro Alves <palves@redhat.com>
3401 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3402 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3403 * unittests/cli-utils-selftests.c (test_parse_flags)
3404 (test_parse_flags_qcs): Delete.
3405 (test_cli_utils): Don't call deleted functions.
3407 2019-06-13 Pedro Alves <palves@redhat.com>
3409 * thread.c: Include "cli/cli-option.h".
3410 (tp_array_compar_ascending): Global.
3411 (tp_array_compar): Delete function.
3412 (tp_array_compar_ascending, tp_array_compar_descending): New
3414 (ascending_option_def, qcs_flag_option_def)
3415 (thr_qcs_flags_option_defs)
3416 (make_thread_apply_all_options_def_group)
3417 (make_thread_apply_options_def_group): New.
3418 (thread_apply_all_command): Use gdb::option::process_options.
3419 (thread_apply_command_completer)
3420 (thread_apply_all_command_completer): New.
3421 (thread_apply_command): Use gdb::option::process_options.
3422 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3423 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3424 to generate help text of "thread apply". Adjust "taas"'s help.
3425 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3426 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3428 2019-06-13 Pedro Alves <palves@redhat.com>
3430 * thread.c (thread_apply_command): Check for invalid TID with
3431 isdigit instead of !isalpha.
3433 2019-06-13 Pedro Alves <palves@redhat.com>
3435 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3436 (validate_flags_qcs): New.
3437 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3438 (validate_flags_qcs): Declare.
3439 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3440 (make_frame_apply_options_def_group): New.
3441 (frame_apply_command_count): Process options with
3442 gdb::option::process_options.
3443 (frame_apply_completer): New.
3444 (frame_apply_level_completer, frame_apply_all_completer)
3445 (frame_apply_completer): New.
3446 (_initialize_stack): Update help of "frame apply", "frame apply
3447 level", "frame apply all" and "faas" to mention supported options
3448 and install command completers.
3449 * stack.h (frame_apply_all_completer): Declare.
3450 * thread.c: Include "stack.h".
3451 (tfaas_command): Add "--".
3452 (_initialize_thread): Update help "tfaas" to mention supported
3453 options and install command completer.
3455 2019-06-13 Pedro Alves <palves@redhat.com>
3457 * completer.c (complete_nested_command_line): New.
3458 (gdb_completion_word_break_characters_throw): Add assertion.
3459 * completer.h (complete_nested_command_line): Declare.
3461 2019-06-13 Pedro Alves <palves@redhat.com>
3463 * stack.c (parse_backtrace_qualifiers): New.
3464 (backtrace_command): Use it.
3465 (backtrace_command_completer): Complete on qualifiers.
3467 2019-06-13 Pedro Alves <palves@redhat.com>
3469 * frame.c: Include "cli/cli-option.h.
3470 (user_set_backtrace_options): New.
3471 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3473 (get_prev_frame): Adjust.
3474 (boolean_option_def, uinteger_option_def)
3475 (set_backtrace_option_defs): New.
3476 (_initialize_frame): Adjust and use
3477 gdb::option::add_setshow_cmds_for_options to install "set
3478 backtrace past-main" and "set backtrace past-entry".
3479 * frame.h: Include "cli/cli-option.h".
3480 (struct frame_print_options): Forward declare.
3481 (print_frame_arguments_all, print_frame_arguments_scalars)
3482 (print_frame_arguments_none): Declare.
3483 (print_entry_values): Delete declaration.
3484 (struct frame_print_options, user_frame_print_options): New.
3485 (struct set_backtrace_options): New.
3486 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3487 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3488 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3489 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3490 (list_args_or_locals): Add frame_print_options parameter.
3491 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3492 * python/py-framefilter.c (enumerate_args): Pass down
3493 USER_FRAME_PRINT_OPTIONS.
3494 * stack.c: Include "cli/cli-option.h".
3495 (print_frame_arguments_all, print_frame_arguments_scalars)
3496 (print_frame_arguments_none): Declare.
3497 (print_raw_frame_arguments, print_entry_values): Delete.
3498 (user_frame_print_options): New.
3499 (boolean_option_def, enum_option_def, frame_print_option_defs):
3501 (struct backtrace_cmd_options): New.
3502 (bt_flag_option_def): New.
3503 (backtrace_command_option_defs): New.
3504 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3505 (print_frame_arg, read_frame_arg, print_frame_args)
3506 (print_frame_info, print_frame): Add frame_print_options parameter
3508 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3509 (backtrace_command_1): Add frame_print_options and
3510 backtrace_cmd_options parameters and use them.
3511 (make_backtrace_options_def_group): New.
3512 (backtrace_command): Process command options with
3513 gdb::option::process_options.
3514 (backtrace_command_completer): New.
3515 (_initialize_stack): Extend "backtrace"'s help to mention
3516 supported options. Install completer for "backtrace".
3517 Install some settings commands with add_setshow_cmds_for_options.
3519 2019-06-13 Pedro Alves <palves@redhat.com>
3521 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3522 and that "set/show print raw frame-arguments" are now deprecated.
3524 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3526 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3527 * stack.c (_initialize_stack): Install "set/show print
3528 raw-frame-arguments", and deprecate "set/show print raw
3530 * valprint.c (_initialize_valprint): Deprecate "set/show print
3533 2019-06-13 Pedro Alves <palves@redhat.com>
3535 * compile/compile.c (struct compile_options): New.
3536 (compile_flag_option_def, compile_command_option_defs)
3537 (make_compile_options_def_group): New.
3538 (compile_file_command): Handle options with
3539 gdb::option::process_options.
3540 (compile_file_command_completer): New function.
3541 (compile_code_command): Handle options with
3542 gdb::option::process_options.
3543 (compile_code_command_completer): New function.
3544 (_initialize_compiler): Install completers for "compile code" and
3545 "compile file". Mention available options in "compile code" and
3546 "compile code"'s help.
3547 * completer.c (advance_to_completion_word): New, factored out from
3549 (advance_to_expression_complete_word_point): ... this.
3550 (advance_to_filename_complete_word_point): New.
3551 * completer.h (advance_to_filename_complete_word_point): New
3554 2019-06-13 Pedro Alves <palves@redhat.com>
3556 * compile/compile.c: Include "cli/cli-option.h".
3557 (compile_print_value): Scope data pointer is now a
3558 value_print_options pointer; adjust.
3559 (compile_print_command): Process options. Scope data pointer is
3560 now a value_print_options pointer; adjust.
3561 (_initialize_compile): Update "compile print"'s help to include
3562 supported options. Install a completer for "compile print".
3563 * cp-valprint.c (show_vtblprint, show_objectprint)
3564 (show_static_field_print): Delete.
3565 (_initialize_cp_valprint): Don't install "set print
3566 static-members", "set print vtbl", "set print object" here.
3567 * printcmd.c: Include "cli/cli-option.h" and
3568 "common/gdb_optional.h".
3569 (print_command_parse_format): Rework to fill in a
3570 value_print_options instead of a format_data.
3571 (print_value): Change parameter type from format_data pointer to
3572 value_print_options reference. Adjust.
3573 (print_command_1): Process options. Adjust to pass down a
3574 value_print_options.
3575 (print_command_completer): New.
3576 (_initialize_printcmd): Install print_command_completer as
3577 handle_brkchars completer for the "print" command. Update
3578 "print"'s help to include supported options.
3579 * valprint.c: Include "cli/cli-option.h".
3580 (show_vtblprint, show_objectprint, show_static_field_print): Moved
3581 here from cp-valprint.c.
3582 (boolean_option_def, uinteger_option_def)
3583 (value_print_option_defs, make_value_print_options_def_group):
3584 New. Use gdb::option::add_setshow_cmds_for_options to install
3585 "set print elements", "set print null-stop", "set print repeats",
3586 "set print pretty", "set print union", "set print array", "set
3587 print address", "set print symbol", "set print array-indexes".
3588 * valprint.h: Include <string> and "cli/cli-option.h".
3589 (make_value_print_options_def_group): Declare.
3590 (print_value): Change parameter type from format_data pointer to
3591 value_print_options reference.
3592 (print_command_completer): Declare.
3594 2019-06-13 Pedro Alves <palves@redhat.com>
3596 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3597 (COMMON_SFILES): Add maint-test-settings.c.
3598 * cli/cli-decode.c (boolean_enums): New global, factored out from
3600 (add_setshow_boolean_cmd): ... here.
3601 * cli/cli-decode.h (boolean_enums): Declare.
3602 * cli/cli-option.c: New file.
3603 * cli/cli-option.h: New file.
3604 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3605 factored out from ...
3606 (parse_cli_boolean_value(const char *)): ... this.
3607 (is_unlimited_literal): Change parameter type to pointer to
3608 pointer. Adjust and advance ARG pointer.
3609 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3610 (parse_cli_var_enum): New, factored out from ...
3611 (do_set_command): ... this. Adjust.
3612 * cli/cli-setshow.h (parse_cli_boolean_value)
3613 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3614 (parse_cli_var_enum): Declare.
3615 * cli/cli-utils.c: Include "cli/cli-option.h".
3616 (get_ulongest): New.
3617 * cli/cli-utils.h (get_ulongest): Declare.
3618 (check_for_argument): New overloads.
3619 * maint-test-options.c: New file.
3621 2019-06-13 Pedro Alves <palves@redhat.com>
3623 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3624 parse a range if "-" is at the end of the string.
3626 2019-06-13 Pedro Alves <palves@redhat.com>
3628 * cli/cli-setshow.c (parse_auto_binary_operation)
3629 (parse_cli_boolean_value): Don't allow "o".
3631 2019-06-13 Pedro Alves <palves@redhat.com>
3633 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3634 * NEWS: Mention maint test-settings KIND.
3635 * maint-test-settings.c: New file.
3637 2019-06-13 Pedro Alves <palves@redhat.com>
3639 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3641 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3644 2019-06-13 Pedro Alves <palves@redhat.com>
3646 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3649 2019-06-13 Pedro Alves <palves@redhat.com>
3651 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3653 2019-06-13 Pedro Alves <palves@redhat.com>
3655 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3656 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3658 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3659 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3661 (check_for_argument): Skip spaces after argument.
3663 2019-06-13 Pedro Alves <palves@redhat.com>
3665 * thread.c (thread_apply_command): Adjust TID parsing.
3666 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3667 detected before end of string.
3668 (tid_is_in_list): Error out if LIST is invalid.
3670 2019-06-13 Pedro Alves <palves@redhat.com>
3672 * completer.c (complete_line_internal_1): Rewind completion word
3674 (completion_tracker::advance_custom_word_point_by): Change
3675 parameter type to int.
3676 * completer.h (completion_tracker::advance_custom_word_point_by):
3679 2019-06-13 Pedro Alves <palves@redhat.com>
3681 * completer.c (advance_to_completion_word): Handle delimiters.
3683 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
3685 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3687 2019-06-11 Tom Tromey <tom@tromey.com>
3689 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3690 (xmalloc_failed): Move to alloc.c.
3691 * alloc.c: New file.
3692 * Makefile.in (COMMON_SFILES): Add alloc.c.
3694 2019-06-11 Tom Tromey <tom@tromey.com>
3696 * nat/linux-waitpid.c: Don't include server.h.
3697 (linux_debug): Remove.
3698 (my_waitpid): Update.
3700 2019-06-11 Tom Tromey <tromey@adacore.com>
3702 * infcall.c (_initialize_infcall): Remove trailing newline from
3704 * user-regs.c (_initialize_user_regs): Remove trailing newline
3706 * typeprint.c (_initialize_typeprint): Remove trailing newline
3708 * reverse.c (_initialize_reverse): Remove trailing newlines from
3710 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3712 * language.c (add_set_language_command): Remove trailing newline
3714 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3716 * disasm.c (_initialize_disasm): Remove trailing newline from
3718 * top.c (init_main): Remove trailing newline from help.
3719 * interps.c (_initialize_interpreter): Remove trailing newline
3721 * btrace.c (_initialize_btrace): Remove trailing newlines from
3723 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3725 * python/python.c (_initialize_python): Remove trailing newline
3727 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3729 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3730 from help. Reformat some text.
3731 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3733 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3736 2019-06-11 Tom Tromey <tromey@adacore.com>
3738 * darwin-nat.c (darwin_decode_exception_message)
3739 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3741 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
3743 * valops.c (value_slice): Check for not allocated or not
3746 2019-06-10 Tom de Vries <tdevries@suse.de>
3749 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3750 sure an empty slot (defined by a 32-bit zero pair) is recognized as
3753 2019-06-10 Tom de Vries <tdevries@suse.de>
3756 * linespec.c (linespec_lexer_lex_string): Remove incorrect
3757 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
3759 2019-06-10 Tom de Vries <tdevries@suse.de>
3762 * symtab.c (struct demangled_name_entry): Add language field.
3763 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
3764 static minimal symbol". Set and use language field.
3766 2019-06-10 Tom Tromey <tromey@adacore.com>
3768 * ada-lang.c (_initialize_ada_language): Update help text.
3770 2019-06-10 Tom Tromey <tromey@adacore.com>
3772 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3774 * guile/guile.c (handle_boot_error): Don't end warning with a
3776 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3777 warning with a newline.
3778 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3780 (s12z_frame_cache): Likewise.
3781 * dwarf-index-cache.c (index_cache::store): Don't end warning with
3783 * solib-svr4.c (disable_probes_interface): Don't end warning with
3785 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3787 * python/python.c (do_finish_initialization): Don't end warning
3790 2019-06-10 Tom Tromey <tom@tromey.com>
3792 * python/py-breakpoint.c (gdbpy_breakpoint_created)
3793 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3796 2019-06-10 Tom Tromey <tromey@adacore.com>
3798 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3800 (elf_new_init): Don't call stabsread_new_init.
3801 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3802 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
3803 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3805 2019-06-10 Tom de Vries <tdevries@suse.de>
3809 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3811 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
3813 * source.c (find_and_open_source): Also rewrite relative file
3816 2019-04-26 Amos Bird <amosbird@gmail.com>
3818 * annotate.c (annotate_thread_exited): Add "thread-exited"
3821 2019-06-06 Tom Tromey <tromey@adacore.com>
3823 * maint.h (class scoped_command_stats): Use
3824 DISABLE_COPY_AND_ASSIGN.
3825 <print_time>: New method.
3826 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3828 (scoped_command_stats::print_time): New method.
3830 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
3832 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3833 instructions of lengths 6 or 8 bytes.
3835 2019-06-04 Pedro Alves <palves@redhat.com>
3837 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3839 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3840 * breakpoint.c (condition_completer): Likewise.
3841 * cli/cli-dump.c (scan_expression): Likewise.
3842 * common/filestuff.c (mkdir_recursive): Likewise.
3843 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3844 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3845 (gdb_abspath): Likewise.
3846 * compile/compile-cplus-types.c
3847 (compile_cplus_instance::decl_name): Likewise.
3848 * completer.c (complete_explicit_location):
3849 (signal_completer, reg_or_group_completer_1): Likewise.
3850 * cp-support.c (cp_remove_params_if_any): Likewise.
3851 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3852 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3853 * infcmd.c (strip_bg_char): Likewise.
3854 * linespec.c (copy_token_string): Likewise.
3855 * mi/mi-main.c (output_cores): Likewise.
3856 * psymtab.c (psymtab_search_name):
3857 * symfile.c (test_set_ext_lang_command): Likewise.
3858 * target.c (target_fileio_read_stralloc): Likewise.
3859 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3860 * value.c (complete_internalvar): Likewise.
3862 2019-06-04 Christian Biesinger <cbiesinger@google.com>
3864 Add objfile property to gdb.Type.
3865 * NEWS: Mention Python API addition.
3866 * python/py-type.c (typy_get_objfile): New method.
3868 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3870 * NEWS: Mention the new set|show style [title|highlight].
3871 Mention changes to "show style", "help" and "apropos".
3873 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3875 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3876 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
3877 instead of print_help_for_command.
3878 (print_doc_of_command): New function.
3879 (help_list): Add 'apropos -v word' suggestion.
3880 (print_help_for_command): Style the command name using title style.
3881 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3882 (_initialize_cli_cmds): Describe -v in apropos_command help.
3884 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3886 * cli/cli-style.h (cli_style_option): Add name in constructor,
3887 add m_name class member, add constructor with intensity,
3888 add name class function.
3889 (cli_style_option::add_setshow_commands): Remove name argument.
3890 (highlight_style, title_style): New styles.
3891 * cli/cli-style.c (do_show): New function that shows a style
3892 characteristic styling the style name with itself.
3893 (set_style_name): New function.
3894 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3895 Update all callers according to the changes in cli/cli-style.h.
3896 * utils.h (fputs_highlighted): New function.
3897 * utils.c (fputs_highlighted): Likewise.
3899 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3901 * NEWS: Mention new pipe command and new convenience variables.
3903 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3905 * cli/cli-cmds.c (pipe_command): New function.
3906 (_initialize_cli_cmds): Call add_com for pipe_command.
3907 Define | as an alias for pipe.
3908 (exit_status_set_internal_vars): New function.
3909 (shell_escape): Call exit_status_set_internal_vars.
3910 cli/cli-decode.c (find_command_name_length): Recognize | as
3911 a single character command.
3913 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3915 * gdbcmd.h (execute_command_to_ui_file): New declaration.
3916 top.c (execute_command_to_ui_file): New function, mostly a copy
3917 of execute_command_to_string.
3918 (execute_command_to_string): Implement by calling
3919 execute_command_to_ui_file.
3921 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3923 * top.h (saved_command_line): Remove declaration.
3924 * top.c (previous_saved_command_line, previous_repeat_arguments):
3926 (saved_command_line): Make static, define together with other
3928 (dont_repeat): Clear repeat_arguments.
3929 (repeat_previous, get_saved_command_line, save_command_line):
3931 (gdb_init): Initialize saved_command_line
3932 and previous_saved_command_line.
3933 * main.c (captured_main_1): Remove saved_command_line initialization.
3934 * event-top.c (handle_line_of_input): Update to use
3935 the new 'repeat' related functions instead of direct access to
3937 * command.h (repeat_previous, get_saved_command_line,
3938 save_command_line): New declarations.
3939 (dont_repeat): Add comment.
3941 2019-05-30 Tom Tromey <tromey@adacore.com>
3943 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3945 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3947 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
3950 * completer.c (complete): Initialize variable word.
3952 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
3954 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3955 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3956 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3957 'body' is NULL to the outter 'if', protecting the '!is_define'
3960 2019-05-29 Tom Tromey <tromey@adacore.com>
3962 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3963 (dwarf_unknown): New function.
3964 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3965 (dwarf_type_encoding_name): Use dwarf_unknown.
3967 2019-05-29 Tom Tromey <tromey@adacore.com>
3970 * cp-valprint.c (cp_print_value_fields): Call
3971 cp_print_static_field inside "try".
3973 2019-05-29 Tom Tromey <tromey@adacore.com>
3975 * inflow.c (struct terminal_info): Add default operator=.
3976 * configure: Rebuild.
3977 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3978 -Wdeprecated-copy-dtor, -Wredundant-move.
3980 2019-05-29 Tom Tromey <tromey@adacore.com>
3983 * infcmd.c (print_return_value_1): Handle finish_print
3985 (show_print_finish): New function.
3986 (_initialize_infcmd): Add "set/show print finish" commands.
3987 * valprint.c (user_print_options): Initialize new member.
3988 * valprint.h (struct value_print_options) <finish_print>: New
3991 2019-05-28 Tom Tromey <tromey@adacore.com>
3993 * ada-lang.c (ada_remove_Xbn_suffix)
3994 (find_old_style_renaming_symbol)
3995 (parse_old_style_renaming): Remove.
3996 (ada_find_renaming_symbol): Don't call
3997 find_old_style_renaming_symbol.
3998 (ada_is_renaming_symbol): Rename from
3999 ada_find_renaming_symbol. Remove "block" parameter. Return
4001 (ada_read_var_value): Update and simplify.
4002 * ada-exp.y (write_var_or_type): Remove old code.
4004 2019-05-28 Alan Hayward <alan.hayward@arm.com>
4006 * event-top.c: Remove include comment.
4007 * inflow.c (class scoped_ignore_sigttou): Move from here...
4008 * inflow.h (class scoped_ignore_sigttou): ...to here.
4009 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4010 * top.c: Remove include comment.
4012 2019-05-27 Tom Tromey <tom@tromey.com>
4016 2019-05-22 Tom Tromey <tromey@adacore.com>
4018 * target.c (target_follow_exec): Constify parameter.
4019 * target-delegates.c: Rebuild.
4020 * remote.c (remote_target::follow_exec): Constify parameter.
4021 * infrun.c (follow_exec): Constify parameter.
4022 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4023 (target_follow_exec): Likewise.
4025 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4027 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4028 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4030 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4032 * NEWS: Add debugredirect and testsuite sections.
4034 2019-05-22 Simon Cook <simon.cook@embecosm.com>
4036 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4037 target descriptions using exclusively floating point register name
4040 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4043 * f-lang.c (build_fortran_types): Handle the case where
4044 gdbarch_floatformat_for_type returns a nullptr.
4046 2019-05-21 Tom de Vries <tdevries@suse.de>
4049 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4051 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4054 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4056 * i386-tdep.c (i386_floatformat_for_type): Use
4057 floatformats_ia64_quad for the 16-byte floating point component
4058 within a fortran 32-byte complex number.
4060 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4062 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4063 delete default constructor.
4064 (find_partial_die): Update to return const struct.
4065 (partial_die_parent_scope): Move variable declaration into scope
4066 of its use and change its type to auto.
4067 (guess_partial_die_structure_name): Likewise.
4068 (partial_die_info::fixup): Likewise.
4070 2019-05-17 Tom Tromey <tromey@adacore.com>
4072 * source.c (find_and_open_source): Remove cast.
4074 2019-05-17 Tom Tromey <tromey@adacore.com>
4076 * annotate.c (annotate_source): Make "filename" const.
4077 * annotate.h (annotate_source): Use const.
4079 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4081 * disasm.c (set_disassembler_options): Send errors to stderr.
4083 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4085 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4086 (cli_interp_base::set_logging): Check debug_redirect.
4087 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4088 * cli/cli-logging.c (debug_redirect): Add static variable.
4089 (pop_output_files): Add default param.
4090 (handle_redirections): Print debug setting.
4091 (show_logging_command): Likewise.
4092 (_initialize_cli_logging): Add debugredirect command.
4093 * interps.c (current_interp_set_logging): Add debug_redirect
4095 * interps.h (set_logging): Add debug_redirect parameter.
4096 (current_interp_set_logging): Likewise.
4097 * mi/mi-common.h: Likewise.
4098 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4100 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4101 Tom Tromey <tromey@adacore.com>
4103 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4105 * cli/cli-interp.h (make_logging_output): Remove declaration.
4106 * cli/cli-logging.c (make_logging_output): Remove function.
4107 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4109 * ui-file.c (tee_file::tee_file): Remove bools.
4110 (tee_file::~tee_file): Remove deletes.
4111 * ui-file.h (tee_file): Remove bools.
4113 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4115 * mi/mi-cmds.h (mi_cmd_complete): New function.
4116 * mi/mi-main.c (mi_cmd_complete): Likewise.
4117 * mi/mi-cmds.c: Define new MI command -complete.
4118 * NEWS: Mention new -complete command.
4120 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4122 * completer.h (complete): New function.
4123 * completer.c (complete): Likewise.
4124 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4125 function defined in completer.h.
4127 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4129 * MAINTAINERS (Write After Approval): Add myself.
4131 2019-05-17 Tom de Vries <tdevries@suse.de>
4134 * dwarf2read.c (struct cu_partial_die_info): New struct.
4135 (find_partial_die): Return cu_partial_die_info.
4136 (partial_die_parent_scope, guess_partial_die_structure_name)
4137 (partial_die_info::fixup): Handle new return type of find_partial_die.
4139 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4141 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4142 "std::string", simplifying the algorithm.
4144 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4146 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4147 (stap_static_probe_ops::get_probes): Likewise.
4149 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4151 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4152 '-')" and "else if".
4153 (stap_parse_single_operand): Join checks for
4154 "gdbarch_stap_parse_special_token_p" and
4155 "gdbarch_stap_parse_special_token" in the same "if" statement.
4156 Invert check when verifying for operation on register
4159 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4161 * stap-probe.c (stap_get_opcode): Update comment.
4162 (stap_get_expected_argument_type): Likewise.
4163 (handle_stap_probe): Likewise.
4165 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4167 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4168 return type to 'bool'. Adjust comment. Use 'bool' when
4170 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4171 * stap-probe.c (stap_parse_argument_1): Likewise.
4172 (stap_is_operator): Likewise.
4173 (stap_is_generic_prefix): Likewise.
4174 (stap_is_register_prefix): Likewise.
4175 (stap_is_register_indirection_prefix): Likewise.
4176 (stap_is_integer_prefix): Likewise.
4177 (stap_generic_check_suffix): Likewise.
4178 (stap_check_integer_suffix): Likewise.
4179 (stap_check_register_suffix): Likewise.
4180 (stap_check_register_indirection_suffix): Likewise.
4181 (stap_parse_register_operand): Likewise.
4182 (stap_parse_single_operand): Likewise.
4183 (stap_parse_argument_1): Likewise.
4184 (stap_probe::get_argument_count): Likewise.
4185 (stap_is_operator): Likewise.
4187 2019-05-16 Tom Tromey <tromey@adacore.com>
4189 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4192 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
4194 * linux-thread-db.c (try_thread_db_load_1): Change return type
4196 (try_thread_db_load): Likewise.
4197 (try_thread_db_load_from_pdir_1): Likewise.
4198 (try_thread_db_load_from_pdir): Likewise.
4199 (try_thread_db_load_from_sdir): Likewise.
4200 (try_thread_db_load_from_dir): Likewise.
4201 (thread_db_load_search): Likewise.
4202 (has_libpthread): Likewise.
4203 (thread_db_load): Likewise.
4205 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4207 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4208 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4209 NULL, and complain/return if that's the case.
4211 2019-05-15 John Darrington <john@darrington.wattle.id.au>
4213 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4214 (advance, posn, abstract_read_memory): New functions.
4215 [struct mem_read_abstraction]: New struct.
4216 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4218 2019-05-14 Tom Tromey <tromey@adacore.com>
4220 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4221 value is not lval_memory.
4223 2019-05-14 Tom Tromey <tromey@adacore.com>
4225 * solib.c (info_sharedlibrary_command): Style the file name.
4227 2019-05-14 Alan Hayward <alan.hayward@arm.com>
4229 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4230 (aarch64_vnv_type): Likewise.
4231 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4232 * common/tdesc.c: Likewise.
4233 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4234 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4235 * features/aarch64-fpu.xml: Add ieee half view.
4236 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4237 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4238 * gdbtypes.h (struct builtin_type): Likewise.
4239 (struct objfile_type): Likewise.
4241 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
4243 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4245 * location.h (string_to_event_location): Likewise.
4247 2019-05-11 Joel Brobecker <brobecker@adacore.com>
4251 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4253 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4254 New variable declaration.
4255 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4257 (print_one_breakpoint): Use ui_out::test_flags and new global
4258 variable to compute use_fixed_output.
4259 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4261 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4262 (mi_multi_location_breakpoint_output_fixed): Remove.
4263 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4265 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4266 fix_multi_location_breakpoint_output flag if version >= 3.
4267 * ui-out.h (enum ui_out_flag)
4268 <fix_multi_location_breakpoint_output>: New enumerator.
4270 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4272 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4274 2019-05-10 Tom Tromey <tromey@adacore.com>
4276 * ada-lang.c (catch_ada_completer): New function.
4277 (_initialize_ada_language): Use it.
4279 2019-05-10 Tom Tromey <tromey@adacore.com>
4281 * thread.c (print_thread_info): Make "requested_threads" const.
4282 * gdbthread.h (print_thread_info): Make "requested_threads"
4284 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4285 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4287 2019-05-08 Tom Tromey <tom@tromey.com>
4289 * gdbtypes.c (objfile_type_data): Change type.
4290 (objfile_type, _initialize_gdbtypes): Update.
4292 2019-05-08 Tom Tromey <tom@tromey.com>
4294 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4295 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4296 (_initialize_dwarf2_frame): Update.
4298 2019-05-08 Tom Tromey <tom@tromey.com>
4300 * objc-lang.c (objc_objfile_data): Change type.
4301 (find_methods): Update.
4302 (_initialize_objc_lang): Remove.
4304 2019-05-08 Tom Tromey <tom@tromey.com>
4306 * stabsread.c (rs6000_builtin_type_data): Change type.
4307 (rs6000_builtin_type, _initialize_stabsread): Update.
4309 2019-05-08 Tom Tromey <tom@tromey.com>
4311 * mips-tdep.c (mips_pdr_data): Remove.
4312 (_initialize_mips_tdep): Update.
4314 2019-05-08 Tom Tromey <tom@tromey.com>
4316 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4317 (hppa_init_objfile_priv_data, read_unwind_info)
4318 (find_unwind_entry, _initialize_hppa_tdep): Update.
4320 2019-05-08 Tom Tromey <tom@tromey.com>
4322 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4323 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4325 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4327 2019-05-08 Tom Tromey <tom@tromey.com>
4329 * mdebugread.c (basic_type_data): Change type.
4330 (basic_type, _initialize_mdebugread): Update.
4332 2019-05-08 Tom Tromey <tom@tromey.com>
4334 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4336 2019-05-08 Tom Tromey <tom@tromey.com>
4338 * nto-tdep.c (nto_inferior_data_reg): Change type.
4339 (nto_inferior_data): Update.
4340 (nto_inferior_data_cleanup, nto_new_inferior_data)
4341 (_initialize_nto_tdep): Remove.
4342 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4344 2019-05-08 Tom Tromey <tom@tromey.com>
4346 * ada-lang.c (struct ada_inferior_data): Add initializers.
4347 (ada_inferior_data): Change type.
4348 (ada_inferior_data_cleanup): Remove.
4349 (get_ada_inferior_data, ada_inferior_exit)
4350 (struct ada_pspace_data): Add initializers, destructor.
4351 (ada_pspace_data_handle): Change type.
4352 (get_ada_pspace_data): Update.
4353 (ada_pspace_data_cleanup): Remove.
4355 2019-05-08 Tom Tromey <tom@tromey.com>
4357 * coffread.c (struct coff_symfile_info): Add initializers.
4358 (coff_objfile_data_key): Move lower. Change type.
4359 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4361 (coff_free_info): Remove.
4363 2019-05-08 Tom Tromey <tom@tromey.com>
4365 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4366 (fbsd_pspace_data_handle): Move lower. Change type.
4367 (get_fbsd_pspace_data): Update.
4368 (fbsd_pspace_data_cleanup): Remove.
4369 (_initialize_fbsd_tdep): Update.
4371 2019-05-08 Tom Tromey <tom@tromey.com>
4373 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4374 (get_ada_tasks_pspace_data): Update.
4375 (ada_tasks_pspace_data_cleanup): Remove.
4376 (_initialize_tasks): Update.
4377 (ada_tasks_inferior_data_handle): Change type.
4378 (get_ada_tasks_inferior_data): Update.
4379 (ada_tasks_inferior_data_cleanup): Remove.
4380 (struct ada_tasks_pspace_data): Add initializers.
4382 2019-05-08 Tom Tromey <tom@tromey.com>
4384 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4385 * symfile-debug.c (debug_sym_get_probes): Change type.
4386 * stap-probe.c (handle_stap_probe):
4387 (stap_static_probe_ops::get_probes): Change type.
4388 * probe.h (class static_probe_ops) <get_probes>: Change type.
4389 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4390 (parse_probes_in_pspace): Update.
4391 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4393 (any_static_probe_ops::get_probes): Change type.
4394 * elfread.c (elfread_data): New typedef.
4395 (probe_key): Change type.
4396 (elf_get_probes): Likewise. Update.
4397 (probe_key_free): Remove.
4398 (_initialize_elfread): Update.
4399 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4401 (dtrace_process_dof_probe, dtrace_process_dof)
4402 (dtrace_static_probe_ops::get_probe): Change type.
4404 2019-05-08 Tom Tromey <tom@tromey.com>
4406 * xcoffread.c (struct xcoff_symfile_info): Rename from
4407 coff_symfile_info. Add initializers.
4408 (xcoff_objfile_data_key): Move lower. Change type.
4409 (XCOFF_DATA): Rewrite.
4410 (xcoff_free_info): Remove.
4411 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4412 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4413 (xcoff_initial_scan): Update.
4415 2019-05-08 Tom Tromey <tom@tromey.com>
4417 * solib-svr4.c (struct svr4_info): Add initializers and
4419 <probes_table>: Now an htab_up.
4420 (solib_svr4_pspace_data): Change type.
4421 (free_probes_table): Simplify.
4422 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4423 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4424 (probes_table_remove_objfile_probes, register_solib_event_probe)
4425 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4426 (_initialize_svr4_solib): Update.
4428 2019-05-08 Tom Tromey <tom@tromey.com>
4430 * remote.c (remote_pspace_data): Change type.
4431 (remote_pspace_data_cleanup): Remove.
4432 (get_remote_exec_file, set_pspace_remote_exec_file)
4433 (_initialize_remote): Update.
4435 2019-05-08 Tom Tromey <tom@tromey.com>
4437 * breakpoint.c (breakpoint_objfile_key): Change type.
4438 (get_breakpoint_objfile_data): Update.
4439 (free_breakpoint_objfile_data): Remove.
4440 (_initialize_breakpoint): Update.
4442 2019-05-08 Tom Tromey <tom@tromey.com>
4444 * linux-tdep.c (struct linux_info): Add initializers.
4445 (linux_inferior_data): Move. Change type.
4446 (invalidate_linux_cache_inf): Update.
4447 (linux_inferior_data_cleanup): Remove.
4448 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4450 2019-05-08 Tom Tromey <tom@tromey.com>
4452 * auxv.c (auxv_inferior_data): Move. Change type.
4453 (auxv_inferior_data_cleanup): Remove.
4454 (invalidate_auxv_cache_inf): Rewrite.
4455 (get_auxv_inferior_data, _initialize_auxv): Update.
4457 2019-05-08 Tom Tromey <tom@tromey.com>
4459 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4460 (symfile_debug_objfile_data_key): Change type.
4461 (symfile_debug_installed, debug_qf_has_symbols)
4462 (debug_qf_find_last_source_symtab)
4463 (debug_qf_forget_cached_source_info)
4464 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4465 (debug_qf_print_stats, debug_qf_dump)
4466 (debug_qf_expand_symtabs_for_function)
4467 (debug_qf_expand_all_symtabs)
4468 (debug_qf_expand_symtabs_with_fullname)
4469 (debug_qf_map_matching_symbols)
4470 (debug_qf_expand_symtabs_matching)
4471 (debug_qf_find_pc_sect_compunit_symtab)
4472 (debug_qf_map_symbol_filenames)
4473 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4474 (debug_sym_new_init, debug_sym_init, debug_sym_read)
4475 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4476 (debug_sym_read_linetable, debug_sym_relocate): Update.
4477 (symfile_debug_free_objfile): Remove.
4478 (install_symfile_debug_logging, _initialize_symfile_debug):
4481 2019-05-08 Tom Tromey <tom@tromey.com>
4483 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4484 allocate_on_obstack.
4485 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4486 (get_dwarf2_per_objfile): Update.
4487 (set_dwarf2_per_objfile): Remove.
4488 (dwarf2_has_info, dwarf2_get_section_info): Update.
4489 (dwarf2_free_objfile): Remove.
4490 (_initialize_dwarf2_read): Update.
4492 2019-05-08 Tom Tromey <tom@tromey.com>
4494 * auto-load.c (struct auto_load_pspace_info): Add destructor and
4496 <unsupported_script_warning_printed,
4497 script_not_found_warning_printed>: Now bool.
4498 (auto_load_pspace_data): Change type.
4499 (~auto_load_pspace_info): Rename from
4500 auto_load_pspace_data_cleanup.
4501 (get_auto_load_pspace_data, init_loaded_scripts_info)
4502 (clear_section_scripts, maybe_print_unsupported_script_warning)
4503 (maybe_print_script_not_found_warning, _initialize_auto_load):
4506 2019-05-08 Tom Tromey <tom@tromey.com>
4508 * objfiles.c (objfile_pspace_info): Add destructor and
4510 (objfiles_pspace_data): Change type.
4511 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4512 (get_objfile_pspace_data): Update.
4513 (objfiles_bfd_data): Change type.
4514 (get_objfile_bfd_data): Update.
4515 (objfile_bfd_data_free, _initialize_objfiles): Remove.
4517 2019-05-08 Tom Tromey <tom@tromey.com>
4519 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4521 (get_catch_syscall_inferior_data): Update.
4522 (catch_syscall_inferior_data_cleanup): Remove.
4523 (_initialize_break_catch_syscall): Update.
4525 2019-05-08 Tom Tromey <tom@tromey.com>
4527 * inflow.c (struct terminal_info): Add destructor and
4529 (inflow_inferior_data): Change type.
4530 (~terminal_info): Rename from inflow_inferior_data_cleanup.
4531 (get_inflow_inferior_data, inflow_inferior_exit)
4532 (swap_terminal_info, _initialize_inflow): Update.
4534 2019-05-08 Tom Tromey <tom@tromey.com>
4536 * target-dcache.c (target_dcache_cleanup): Remove.
4537 (target_dcache_aspace_key): Change type.
4538 (target_dcache_init_p, target_dcache_invalidate)
4539 (target_dcache_get, target_dcache_get_or_init)
4540 (_initialize_target_dcache): Update.
4541 * dcache.h (struct dcache_deleter): New.
4543 2019-05-08 Tom Tromey <tom@tromey.com>
4545 * symtab.c (struct symbol_cache): Add destructor and
4547 (symbol_cache_key): Move. Change type.
4548 (make_symbol_cache, free_symbol_cache): Remove.
4549 (get_symbol_cache): Update.
4550 (symbol_cache_cleanup): Remove.
4551 (ALL_PSPACES, symbol_cache_flush)
4552 (maintenance_print_symbol_cache)
4553 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4556 2019-05-08 Tom Tromey <tom@tromey.com>
4558 * symtab.c (struct main_info): Add destructor and initializers.
4559 (main_progspace_key): Move. Change type.
4560 (get_main_info): Update.
4561 (main_info_cleanup): Remove.
4562 (_initialize_symtab): Update.
4564 2019-05-08 Tom Tromey <tom@tromey.com>
4566 * registry.h (DECLARE_REGISTRY): Define the _key class.
4568 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
4570 * NEWS: Merge two 'New commands' sections.
4572 2019-05-08 Joel Brobecker <brobecker@adacore.com>
4574 * ada-valprint.c (ada_val_print_gnat_array): Remove language
4575 parameter and use Ada language definition instead.
4576 (ada_val_print_ptr): Remove unused language parameter.
4577 (ada_val_print_num): Remove language parameter and use Ada language
4579 (ada_val_print_enum, ada_val_print_flt): Remove unused language
4581 (ada_val_print_struct_union, ada_val_print_ref): Remove language
4582 parameter and use Ada language definition instead.
4583 (ada_val_print_1): Update all ada_val_print_xxx calls.
4584 Remove language parameter.
4585 (ada_val_print): Update ada_val_print_1 call.
4587 2019-05-08 Tom Tromey <tromey@adacore.com>
4589 * remote.c (remote_hw_watchpoint_limit)
4590 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4593 2019-05-08 Tom Tromey <tromey@adacore.com>
4595 * maint.c (_initialize_maint_cmds): Move initialization code to
4597 (watchdog, show_watchdog): Move to remote.c.
4598 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
4600 (_initialize_remote): Move initialization code from maint.c.
4601 * defs.h (watchdog): Don't declare.
4603 2019-05-08 Tom Tromey <tromey@adacore.com>
4605 * tui/tui-interp.c: Include main.h.
4606 * interps.c: Include main.h.
4607 * main.h (interpreter_p): Declare.
4608 * defs.h (interpreter_p): Don't declare.
4610 2019-05-08 Tom Tromey <tromey@adacore.com>
4612 * dwarf2loc.c: Include dwarf2read.h.
4613 * defs.h (read_unsigned_leb128): Don't declare.
4614 * dwarf2read.h (read_unsigned_leb128): Declare.
4616 2019-05-08 Tom Tromey <tromey@adacore.com>
4618 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4621 2019-05-08 Tom Tromey <tromey@adacore.com>
4623 * utils.c (fputs_maybe_filtered): Reset style after paging, even
4624 when no wrap column is set.
4626 2019-05-08 Tom Tromey <tromey@adacore.com>
4628 * c-lang.c (c_get_string): Handle non-C-style arrays.
4630 2019-05-08 Tom Tromey <tromey@adacore.com>
4632 * typeprint.c (print_offset_data::update): Print the bit offset,
4633 not the number of bits remaining.
4635 2019-05-08 Tom Tromey <tromey@adacore.com>
4637 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4638 padding at end of comment.
4640 2019-05-08 Tom Tromey <tromey@adacore.com>
4642 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4645 2019-05-06 Tom Tromey <tom@tromey.com>
4647 * common/scoped_mmap.c: Include common-defs.h.
4648 * common/scoped_mmap.h: Don't include config.h.
4650 2019-05-04 Tom Tromey <tom@tromey.com>
4652 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4653 (struct aarch64_call_info): Add initializers.
4654 <si>: Now a std::vector.
4655 (pass_on_stack, aarch64_push_dummy_call): Update.
4657 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
4658 Tom Tromey <tom@tromey.com>
4660 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4661 (ppc_threads): Now a std::vector. Now static.
4662 (hwdebug_find_thread_points_by_tid)
4663 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4666 2019-05-04 Tom Tromey <tom@tromey.com>
4668 * arc-tdep.c (arc_tdesc_init): Return bool.
4670 2019-05-04 Tom Tromey <tom@tromey.com>
4672 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4673 Use gdb_assert_not_reached.
4675 2019-05-04 Tom Tromey <tom@tromey.com>
4677 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4680 2019-05-04 Tom Tromey <tom@tromey.com>
4682 * arc-tdep.c (arc_tdesc_init): Use bool.
4684 2019-05-04 Tom Tromey <tom@tromey.com>
4686 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4688 2019-05-04 Tom Tromey <tom@tromey.com>
4690 * cli/cli-cmds.c (valid_command_p): Return bool.
4692 2019-05-04 Tom Tromey <tom@tromey.com>
4694 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4695 * command.h (valid_user_defined_cmd_name_p): Channge return type.
4697 2019-05-04 Raul Tambre <raul@tambre.ee>
4699 * python/lib/gdb/prompt.py (_ExtendedPrompt)
4700 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4701 operator for comparison.
4703 2019-05-04 Tom Tromey <tom@tromey.com>
4705 * psymtab.c (psymbol_name_matches, match_partial_symbol)
4706 (lookup_partial_symbol, print_partial_symbols)
4707 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4708 (psymbol_compare): Update.
4709 (add_psymbol_to_bcache): Clear the entire psymbol.
4710 (maintenance_check_psymtabs): Update.
4711 * psympriv.h (struct partial_symbol): Don't derive from
4712 general_symbol_info.
4713 <obj_section, unrelocated_address, address,
4714 set_unrelocated_address>: Update.
4715 <ginfo>: New member.
4716 * dwarf-index-write.c (write_psymbols, debug_names::insert)
4717 (debug_names::write_psymbols): Update.
4719 2019-05-04 Tom de Vries <tdevries@suse.de>
4721 * contrib/cc-with-tweaks.sh: Support -n arg.
4723 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4725 * corelow.c (core_target::detach): Ensure frame cache and
4726 register caches are cleared.
4727 inferior.c (exit_inferior_1): Likewise.
4729 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
4730 Tom Tromey <tom@tromey.com>
4732 * dictionary.c (collate_pending_symbols_by_language): Remove
4733 "struct" from foreach.
4734 * symtab.c (lookup_global_symbol_from_objfile)
4735 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4737 * ser-tcp.c (net_open): Remove "struct" from foreach.
4738 * objfiles.c (objfile_relocate, objfile_rebase)
4739 (objfile_has_symbols): Remove "struct" from foreach.
4740 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4742 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4744 * darwin-nat.c (thread_info_from_private_thread_info): Remove
4745 "struct" from foreach.
4746 * ada-lang.c (create_excep_cond_exprs)
4747 (ada_exception_catchpoint_cond_string): Remove "struct" from
4750 2019-05-03 Tom Tromey <tromey@adacore.com>
4752 * ada-exp.y (convert_char_literal): Check suffix of each
4755 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
4758 * ada-exp.y (yywrap): Don't define.
4759 * ada-lex.l (%option): Add noyywrap
4762 2019-05-03 Eli Zaretskii <eliz@gnu.org>
4764 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4765 _WIN32_WINNT to the XP level, unless already defined to a higher
4768 * unittests/parse-connection-spec-selftests.c:
4770 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
4773 * symfile.c (find_separate_debug_file): Remove colon from the
4774 drive spec of DOS/Windows file names of the target, so that the
4775 file name produced from DEBUGDIR and the target's directory will
4776 be valid on DOS/Windows systems.
4778 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
4780 * rust-lang.c (val_print_struct): Handle printing structures
4783 2019-05-02 Tom Tromey <tromey@adacore.com>
4785 * valarith.c (_initialize_valarith): Remove.
4787 2019-05-01 Tom Tromey <tromey@adacore.com>
4789 * ada-lang.c (ada_value_primitive_field): Treat more fields as
4792 2019-05-01 Tom Tromey <tromey@adacore.com>
4794 * ada-lang.c (ada_value_assign): Correctly compute starting offset
4795 for big-endian copies.
4797 2019-04-30 Ali Tamur <tamur@google.com>
4798 * gdb/dwarf2read.c (read_3_bytes): New declaration.
4799 (read_attribute_value): Added DW_FORM_strx1-4 cases.
4800 (read_3_bytes): New function.
4802 2019-04-30 Joel Brobecker <brobecker@adacore.com>
4804 * windows-nat.c (main_thread_id): Delete.
4805 (handle_output_debug_string): Replace main_thread_id by
4806 current_event.dwThreadId.
4807 (fake_create_process): Likewise.
4808 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4809 Do not set main_thread_id.
4810 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4811 current_event.dwThreadId.
4812 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4814 2019-04-30 Joel Brobecker <brobecker@adacore.com>
4816 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4817 Use current_event.dwThreadId instead of main_thread_id.
4819 2019-04-30 Tom Tromey <tromey@adacore.com>
4821 * ada-lang.c (ada_lookup_simple_minsyms): New function.
4822 (create_excep_cond_exprs): Iterate over program spaces.
4823 (ada_exception_catchpoint_cond_string): Examine all minimal
4824 symbols for exception types.
4826 2019-04-30 Tom Tromey <tromey@adacore.com>
4829 * dwarf2read.c (process_structure_scope): Handle case where type
4830 has template parameters but no symbol was created.
4832 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4833 Chris January <chris.january@arm.com>
4835 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4837 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4839 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4841 * f-typeprint.c (f_print_type): Update rules for printing
4843 (f_type_print_varspec_suffix): Likewise.
4845 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4846 Chris January <chris.january@arm.com>
4848 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4851 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4853 * f-lang.c (build_fortran_types): Change name of void type to
4855 * f-typeprint.c (f_type_print_base): Print the name of the void
4856 type, rather than a fixed string.
4857 * f-valprint.c (f_decorations): Use lower case void string.
4859 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4860 Chris January <chris.january@arm.com>
4862 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4865 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4866 Chris January <chris.january@arm.com>
4867 David Lecomber <david.lecomber@arm.com>
4869 * f-exp.y (BINOP_INTRINSIC): New token.
4870 (exp): New parser rule handling BINOP_INTRINSIC.
4871 (f77_keywords): Add new builtin procedures.
4872 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4873 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4874 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4875 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4876 (print_unop_subexp_f): New function.
4877 (print_binop_subexp_f): New function.
4878 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4879 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4880 (dump_subexp_body_f): Likewise.
4881 (operator_check_f): Likewise.
4882 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4883 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4885 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4887 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4889 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4890 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4891 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4892 (operator_length_f): New fuction.
4893 (print_subexp_f): New function.
4894 (op_name_f): New function.
4895 (dump_subexp_body_f): New function.
4896 (operator_check_f): New function.
4897 (exp_descriptor_f): Replace standard expression handling functions
4899 * gdb/fortran-operator.def: New file.
4900 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4901 * gdb/std-operator.def: Remove UNOP_KIND.
4903 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4905 * std-operator.def: Remove unbalanced, stray double quote
4908 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4909 Chris January <chris.january@arm.com>
4910 Daniel Everett <daniel.everett@arm.com>
4911 Nick Forrington <nick.forrington@arm.com>
4912 Richard Bunt <richard.bunt@arm.com>
4914 * cp-valprint.c (cp_print_value_fields): Allow an additional level
4915 of depth when printing anonymous structs or unions.
4916 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4917 Don't print either the top-level value, or the children if the
4918 max-depth is exceeded.
4919 (ppscm_print_children): When printing the key of a map, allow one
4920 extra level of depth.
4921 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4922 print either the top-level value, or the children if the max-depth
4924 (print_children): When printing the key of a map, allow one extra
4926 * python/py-value.c (valpy_format_string): Add max_depth keyword.
4927 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4928 (user_print_options): Initialise max_depth field.
4929 (val_print_scalar_or_string_type_p): New function.
4930 (val_print): Check to see if the max depth has been reached.
4931 (val_print_check_max_depth): Define new function.
4932 (show_print_max_depth): New function.
4933 (_initialize_valprint): Add 'print max-depth' option.
4934 * valprint.h (struct value_print_options) <max_depth>: New field.
4935 (val_print_check_max_depth): Declare new function.
4936 * NEWS: Document new feature.
4938 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4940 * ada-lang.c (ada_language_defn): Initialise new field.
4941 * c-lang.c (c_is_string_type_p): New function.
4942 (c_language_defn): Initialise new field.
4943 (cplus_language_defn): Initialise new field.
4944 (asm_language_defn): Initialise new field.
4945 (minimal_language_defn): Initialise new field.
4946 * c-lang.h (c_is_string_type_p): Declare new function.
4947 * d-lang.c (d_language_defn): Initialise new field.
4948 * f-lang.c (f_is_string_type_p): New function.
4949 (f_language_defn): Initialise new field.
4950 * go-lang.c (go_is_string_type_p): New function.
4951 (go_language_defn): Initialise new field.
4952 * language.c (default_is_string_type_p): New function.
4953 (unknown_language_defn): Initialise new field.
4954 (auto_language_defn): Initialise new field.
4955 * language.h (struct language_defn) <la_is_string_type_p>: New
4957 (default_is_string_type_p): Declare new function.
4958 * m2-lang.c (m2_language_defn): Initialise new field.
4959 * objc-lang.c (objc_language_defn): Initialise new field.
4960 * opencl-lang.c (opencl_language_defn): Initialise new field.
4961 * p-lang.c (pascal_is_string_type_p): New function.
4962 (pascal_language_defn): Initialise new field.
4963 * rust-lang.c (rust_is_string_type_p): New function.
4964 (rust_language_defn): Initialise new field.
4966 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4968 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4970 * ada-lang.c (ada_language_defn): Initialise new field.
4971 * c-lang.c (c_language_defn): Likewise.
4972 (cplus_language_defn): Likewise.
4973 (asm_language_defn): Likewise.
4974 (minimal_language_defn): Likewise.
4975 * d-lang.c (d_language_defn): Likewise.
4976 * f-lang.c (f_language_defn): Likewise.
4977 * go-lang.c (go_language_defn): Likewise.
4978 * language.c (unknown_language_defn): Likewise.
4979 (auto_language_defn): Likewise.
4980 * m2-lang.c (m2_language_defn): Likewise.
4981 * objc-lang.c (objc_language_defn): Likewise.
4982 * opencl-lang.c (opencl_language_defn): Likewise.
4983 * p-lang.c (pascal_language_defn): Likewise.
4984 * rust-lang.c (rust_language_defn): Likewise.
4986 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4988 * ada-lang.c (ada_is_character_type): Change return type to bool.
4989 (ada_is_string_type): Likewise.
4990 * ada-lang.h (ada_is_character_type): Update declaration
4991 (ada_is_string_type): Likewise.
4993 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4995 Support style in 'frame|thread apply'
4997 * gdbcmd.h (execute_command_to_string): New term_out parameter.
4998 * record.c (record_start, record_stop): Update callers of
4999 execute_command_to_string with false.
5000 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5001 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5003 (class string_file): New constructor with term_out parameter.
5004 Override methods term_out and can_emit_style_escape. New member
5006 (class stdio_file): Override can_emit_style_escape.
5007 (class tee_file): Override term_out and can_emit_style_escape.
5008 * utils.h (can_emit_style_escape): Remove.
5009 * utils.c (can_emit_style_escape): Likewise.
5010 Update all callers of can_emit_style_escape (SOMESTREAM) to
5011 SOMESTREAM->can_emit_style_escape.
5012 * source-cache.c (source_cache::get_source_lines): Likewise.
5013 * stack.c (frame_apply_command_count): Call execute_command_to_string
5014 passing the term_out characteristic of the current gdb_stdout.
5015 * thread.c (thr_try_catch_cmd): Likewise.
5016 * top.c (execute_command_to_string): pass term_out parameter
5017 to construct the string_file for the command output.
5018 * ui-file.c (term_cli_styling): New function (most code moved
5019 from utils.c can_emit_style_escape).
5020 (string_file::string_file, string_file::can_emit_style_escape,
5021 stdio_file::can_emit_style_escape, tee_file::term_out,
5022 tee_file::can_emit_style_escape): New functions.
5024 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5026 * NEWS: Mention the new set|show may-call-functions.
5027 * infcall.c (may_call_functions_p): New variable.
5028 (show_may_call_functions_p): New function.
5029 (call_function_by_hand_dummy): Throws an error if not
5031 (_initialize_infcall): Call add_setshow_boolean_cmd for
5034 2019-04-25 Keith Seitz <keiths@redhat.com>
5037 * cp-support.c (inspect_type): Don't attempt substitutions
5038 of symbol with the same name.
5040 2019-04-25 Tom Tromey <tromey@adacore.com>
5043 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5046 2019-04-25 Tom Tromey <tromey@adacore.com>
5048 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5050 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5051 (gdb_xml_parser::parse): Use std::move.
5052 * python/python-internal.h (gdbpy_convert_exception): Take a const
5054 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5056 * python/py-utils.c (gdbpy_convert_exception): Take a const
5058 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5060 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5062 * mi/mi-main.c (mi_print_exception): Take a const reference.
5063 * main.c (handle_command_errors): Take a const reference.
5064 * linespec.c (parse_linespec): Use std::move.
5065 * infcall.c (run_inferior_call): Use std::move.
5066 (call_function_by_hand_dummy): Use std::move.
5067 * exec.c (try_open_exec_file): Use std::move.
5068 * exceptions.h (exception_print, exception_fprintf)
5069 (exception_print_same): Update.
5070 * exceptions.c (print_exception, exception_print)
5071 (exception_fprintf, exception_print_same): Change parameters to
5073 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5074 * common/new-op.c: Use std::move.
5075 * common/common-exceptions.h (struct gdb_exception): Add move
5077 (struct gdb_exception_error, struct gdb_exception_quit, struct
5078 gdb_quit_bad_alloc): Change constructor to move constructor.
5079 (throw_exception): Change parameter to rvalue reference.
5080 * common/common-exceptions.c (throw_exception): Take rvalue
5082 * cli/cli-interp.c (safe_execute_command): Use std::move.
5083 * breakpoint.c (insert_bp_location, location_to_sals): Use
5086 2019-04-25 Tom Tromey <tromey@adacore.com>
5088 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5089 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5090 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5091 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5092 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5093 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5094 guile/scm-value.c: Use unpack.
5095 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5096 gdbscm_gdb_exception.
5097 (gdbscm_throw_gdb_exception): Likewise.
5098 (struct gdbscm_gdb_exception): New.
5099 (unpack): New function.
5100 (gdbscm_wrap): Use unpack.
5102 2019-04-25 Tom Tromey <tromey@adacore.com>
5104 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5105 (gdb_rl_callback_handler): Use std::move.
5106 * common/common-exceptions.h (struct gdb_exception): Add move
5107 assignment operator.
5108 (throw_exception_sjlj): Change "exception" to const reference.
5109 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5110 (throw_exception_sjlj): Change "exception" to const reference.
5112 2019-04-25 Tom Tromey <tromey@adacore.com>
5114 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5115 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5116 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5118 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5120 * mi/mi-interp.c (mi_interp::exec): Update.
5121 * linespec.c (parse_linespec): Update.
5122 * infcall.c (run_inferior_call): Update.
5123 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5124 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5125 (gdbscm_lookup_global_symbol): Update.
5126 * guile/scm-param.c (gdbscm_parameter_value): Update.
5127 * guile/scm-frame.c (gdbscm_frame_read_register)
5128 (gdbscm_frame_read_var): Update.
5129 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5130 * exec.c (try_open_exec_file): Update.
5131 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5132 (gdb_rl_callback_handler): Update.
5133 * common/common-exceptions.h (exception_none): Don't declare.
5134 * common/common-exceptions.c (exception_none): Don't define.
5135 (struct catcher) <exception>: Update.
5136 * cli/cli-interp.c (safe_execute_command): Update.
5137 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5139 2019-04-25 Ali Tamur <tamur@google.com>
5141 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5142 (read_attribute_value): Likewise.
5143 (dwarf2_read_addr_index): Update comment.
5144 (read_str_index): Add DW_FORM_strx.
5145 (dwarf2_string_attr): Likewise.
5146 (dwarf2_const_value_attr): Likewise.
5147 (dump_die_shallow): Likewise.
5148 (dwarf2_fetch_constant_bytes): Likewise.
5149 (skip_form_bytes): Likewise.
5150 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5152 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5156 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5157 OFFSET. Verify if current mapping contains an ELF header.
5158 (linux_find_memory_regions_full): Adjust call to
5161 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5162 Kang Li <kanglictf@gmail.com>
5166 * dwarf2-frame.c (read_initial_length): Be consistent about using
5167 unsigned representation of length.
5168 (decode_frame_entry_1): Likewise. Check for wraparound of
5169 end pointer as well as buffer overflow.
5171 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5173 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5176 2019-04-24 Tom Tromey <tromey@adacore.com>
5178 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5180 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5182 * s12z-tdep.c (s12z_unwind_pc): Delete.
5183 (s12z_unwind_sp): Delete.
5184 (s12z_gdbarch_init): Don't register deleted functions with
5187 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5189 * rl78-tdep.c (rl78_unwind_sp): Delete.
5190 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5192 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5194 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5195 (xstormy16_unwind_pc): Delete.
5196 (xstormy16_dummy_id): Delete.
5197 (xstormy16_gdbarch_init): Don't register deleted functions with
5200 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5202 * vax-tdep.c (vax_unwind_pc): Delete.
5203 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5205 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5207 * v850-tdep.c (v850_unwind_sp): Delete.
5208 (v850_unwind_pc): Delete.
5209 (v850_dummy_id): Delete.
5210 (v850_gdbarch_init): Don't register deleted functions with
5213 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5215 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5216 (tilegx_unwind_pc): Delete.
5217 (tilegx_unwind_dummy_id): Delete.
5218 (tilegx_gdbarch_init): Don't register deleted functions with
5221 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5223 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5224 (tic6x_dummy_id): Delete.
5225 (tic6x_gdbarch_init): Don't register deleted functions with
5228 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5230 * sparc-tdep.c (sparc_unwind_pc): Delete.
5231 (sparc32_gdbarch_init): Don't register deleted function with
5234 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5236 * sh-tdep.c (sh_unwind_sp): Delete.
5237 (sh_unwind_pc): Delete.
5238 (sh_dummy_id): Delete.
5239 (sh_gdbarch_init): Don't register deleted functions with
5242 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5244 * score-tdep.c (score_unwind_sp): Delete.
5245 (score_unwind_pc): Delete.
5246 (score_dummy_id): Delete.
5247 (score_gdbarch_init): Don't register deleted functions with
5250 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5252 * rx-tdep.c (rx_unwind_pc): Delete.
5253 (rx_unwind_sp): Delete.
5254 (rx_dummy_id): Delete.
5255 (rx_gdbarch_init): Don't register deleted functions with
5256 gdbarch. Update comment.
5258 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5260 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5261 (rs6000_dummy_id): Delete.
5262 (rs6000_gdbarch_init): Don't register deleted functions with
5265 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5267 * or1k-tdep.c (or1k_dummy_id): Delete.
5268 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5270 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5272 * nios2-tdep.c (nios2_dummy_id): Delete.
5273 (nios2_unwind_sp): Delete.
5274 (nios2_gdbarch_init): Don't register deleted functions with
5277 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5279 * nds32-tdep.c (nds32_dummy_id): Delete.
5280 (nds32_unwind_pc): Delete.
5281 (nds32_unwind_sp): Delete.
5282 (nds32_gdbarch_init): Don't register deleted functions with
5285 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5287 * msp430-tdep.c (msp430_unwind_pc): Delete.
5288 (msp430_unwind_sp): Delete.
5289 (msp430_dummy_id): Delete.
5290 (msp430_gdbarch_init): Don't register deleted functions with
5293 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5295 * moxie-tdep.c (moxie_unwind_sp): Delete.
5296 (moxie_unwind_pc): Delete.
5297 (moxie_dummy_id): Delete.
5298 (moxie_gdbarch_init): Don't register deleted functions with
5301 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5303 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5304 (mn10300_unwind_pc): Delete.
5305 (mn10300_unwind_sp): Delete.
5306 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5308 (mn10300_frame_unwind_init): Don't register deleted functions with
5311 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5313 * mep-tdep.c (mep_unwind_pc): Delete.
5314 (mep_unwind_sp): Delete.
5315 (mep_dummy_id): Delete.
5316 (mep_gdbarch_init): Don't register deleted functions with
5319 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5321 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5322 (m68hc11_unwind_sp): Delete.
5323 (m68hc11_gdbarch_init): Don't register deleted functions with
5326 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5328 * m32r-tdep.c (m32r_unwind_sp): Delete.
5329 (m32r_unwind_pc): Delete.
5330 (m32r_dummy_id): Delete.
5331 (m32r_gdbarch_init): Don't register deleted functions with
5334 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5336 * m32c-tdep.c (m32c_unwind_pc): Delete.
5337 (m32c_unwind_sp): Delete.
5338 (m32c_dummy_id): Delete.
5339 (m32c_gdbarch_init): Don't register deleted functions with
5342 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5344 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5345 (lm32_unwind_pc): Delete.
5346 (lm32_dummy_id): Delete.
5347 (lm32_gdbarch_init): Don't register deleted functions with
5350 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5352 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5353 (iq2000_unwind_pc): Delete.
5354 (iq2000_dummy_id): Delete.
5355 (iq2000_gdbarch_init): Don't register deleted functions with
5358 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5360 * nds32-tdep.c (nds32_type_align): Delete.
5361 (nds32_push_dummy_call): Use type_align instead.
5363 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5365 * arm-tdep.c (arm_type_align): Only handle vector override case.
5366 (arm_push_dummy_call): Use type_align.
5367 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5369 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5371 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5373 (pass_on_stack): Use type_align.
5374 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5377 2019-04-23 Tom Tromey <tromey@adacore.com>
5379 * dwarf2read.c (line_header::file_name_at): Remove unused
5382 2019-04-23 Tom de Vries <tdevries@suse.de>
5385 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5389 2019-03-27 Ali Tamur <tamur@google.com>
5391 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5392 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5393 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5394 (dwarf_expr_context::get_addr_index): Likewise
5395 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5396 (symbol_needs_eval_context::get_addr_index): Likewise
5397 (disassemble_dwarf_expression): Add DW_OP_addrx
5398 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5399 (read_cutu_die_from_dwo): Update comment
5400 (skip_one_die): Add DW_FORM_addrx
5401 (read_attribute_value): Likewise
5402 (var_decode_location): Add DW_OP_addrx
5403 (dwarf2_const_value_attr): Add DW_FORM_addrx
5404 (dump_die_shallow): Likewise
5405 (dwarf2_fetch_constant_bytes): Likewise
5406 (decode_locdesc): Add DW_OP_addrx
5407 (skip_form_bytes): Add DW_FORM_addrx
5409 2019-04-22 Ali Tamur <tamur@google.com>
5411 * MAINTAINERS (Write After Approval): Add self.
5413 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
5415 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5416 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5417 (open_symbol_file_object): Likewise.
5418 (svr4_default_sos): Add info parameter.
5419 (svr4_read_so_list): Likewise.
5420 (svr4_current_sos_direct): Adjust functions calls to pass down
5422 (svr4_current_sos_1): Add info parameter.
5423 (svr4_current_sos): Call get_svr4_info, pass info down to
5425 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5427 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5429 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5431 (probes_table_remove_objfile_probes): Likewise.
5432 (register_solib_event_probe): Add info parameter.
5433 (solist_update_incremental): Pass info parameter down to
5435 (disable_probes_interface): Add info parameter.
5436 (svr4_handle_solib_event): Pass current_program_space to
5437 get_svr4_info. Adjust disable_probes_interface cleanup.
5438 (svr4_create_probe_breakpoints): Add info parameter, pass it
5439 down to register_solib_event_probe.
5440 (svr4_create_solib_event_breakpoints): Add info parameter,
5441 pass it down to svr4_create_probe_breakpoints.
5442 (enable_break): Pass info down to
5443 svr4_create_solib_event_breakpoints.
5444 (svr4_solib_create_inferior_hook): Pass current_program_space to
5446 (svr4_clear_solib): Likewise.
5448 2019-04-22 Pedro Alves <palves@redhat.com>
5450 * solib-svr4.c (svr4_free_objfile_observer): New.
5451 (probe_and_action::objfile): New field.
5452 (probes_table_htab_remove_objfile_probes)
5453 (probes_table_remove_objfile_probes): New functions.
5454 (register_solib_event_probe): Add 'objfile' parameter. Store it
5455 in the new probe_and_action. Don't store the probe in 'lookup'.
5456 (svr4_create_probe_breakpoints): Pass objfile to
5457 register_solib_event_probe.
5458 (_initialize_svr4_solib): Register a free_objfile observer.
5460 2019-04-19 Tom Tromey <tom@tromey.com>
5462 * common/queue.h: Remove.
5464 2019-04-19 Tom Tromey <tom@tromey.com>
5466 * event-loop.c: Don't include "common/queue.h".
5468 2019-04-19 Tom Tromey <tom@tromey.com>
5470 * remote.c (remote_target): Use delete.
5471 * remote-notif.h: Include <list>, not "common/queue.h".
5472 (notif_client_p): Remove typedef.
5473 (remote_notif_state): Add constructor, destructor, initializer.
5474 <notif_queue>: Now a std::list.
5475 (remote_notif_state_xfree): Don't declare.
5476 * remote-notif.c (remote_notif_process, handle_notification)
5477 (remote_notif_state_allocate): Update.
5478 (~remote_notif_state): Rename from remote_notif_state_xfree.
5480 2019-04-19 Tom Tromey <tom@tromey.com>
5482 * symfile.c (reread_symbols): Update.
5483 * objfiles.c (objfile_register_static_link)
5484 (objfile_lookup_static_link): Update
5485 (~objfile) Don't delete static_links.
5486 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5488 2019-04-19 Tom Tromey <tom@tromey.com>
5490 * type-stack.h (struct type_stack) <insert>: Constify string.
5491 * type-stack.c (type_stack::insert): Constify string.
5492 * gdbtypes.h (lookup_template_type): Update.
5493 (address_space_name_to_int): Update.
5494 * gdbtypes.c (address_space_name_to_int): Make space_identifier
5496 (lookup_template_type): Make name const.
5497 * c-exp.y: Update rules.
5498 (lex_one_token, classify_name, classify_inner_name)
5499 (c_print_token): Update.
5500 * p-exp.y: Update rules.
5502 * f-exp.y: Update rules.
5504 * d-exp.y: Update rules.
5505 (lex_one_token, classify_name, classify_inner_name): Update.
5506 * parse.c (write_dollar_variable, copy_name): Return std::string.
5507 * parser-defs.h (copy_name): Change return type.
5508 * m2-exp.y: Update rules.
5510 * go-exp.y (lex_one_token): Update.
5512 (classify_unsafe_function, classify_packaged_name)
5513 (classify_name, yylex): Update.
5515 2019-04-19 Sergei Trofimovich <siarheit@google.com>
5517 * configure.ac: add --enable-source-highlight switch.
5518 * configure: Regenerate.
5519 * top.c (print_gdb_version): plumb --enable-source-highlight
5520 status to "show configuration".
5522 2019-04-19 Tom Tromey <tromey@adacore.com>
5524 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5526 (empty_record, ada_template_to_fixed_record_type_1)
5527 (template_to_static_fixed_type)
5528 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5529 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5530 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5533 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
5536 * source.c (print_source_lines_base): Advance "iter" when a
5537 control character is seen.
5539 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5541 * inferior.h (struct infcall_suspend_state_deleter):
5542 Catch exception in destructor to avoid crash.
5544 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5546 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5547 close to the add_com "shell".
5549 2019-04-18 Tom Tromey <tromey@adacore.com>
5551 * process-stratum-target.h (class process_stratum_target)
5552 <stratum>: Add "final".
5554 2019-04-17 Tom Tromey <tromey@adacore.com>
5556 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5557 against nullptr before use.
5559 2019-04-17 Alan Hayward <alan.hayward@arm.com>
5561 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5563 2019-04-17 Jim Wilson <jimw@sifive.com>
5564 Andrew Burgess <andrew.burgess@embecosm.com>
5566 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5567 code read might fail, assume 4-byte breakpoint in that case.
5569 2019-04-15 Leszek Swirski <leszeks@google.com>
5571 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5572 rather than a hand-rolled POD check when checking for forced MEMORY
5575 2019-04-15 Alan Hayward <alan.hayward@arm.com>
5577 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5578 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5580 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5581 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5582 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5585 2019-04-15 Alan Hayward <alan.hayward@arm.com>
5587 * aarch64-linux-nat.c
5588 (aarch64_linux_nat_target::thread_architecture): Add override.
5589 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5592 2019-04-15 Alan Hayward <alan.hayward@arm.com>
5594 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5596 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
5598 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5599 target types of size 96-bits, add some additional comments, and
5600 check that the builtin type we found was the correct size.
5602 2019-04-12 Eli Zaretskii <eliz@gnu.org>
5604 * utils.c (prompt_for_continue): Don't restore the styling at the
5605 end, as applied_style has the wrong value. This fixes styling in
5606 long lists of file names that are interrupted by the "Continue?"
5609 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
5611 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5612 * c-lang.c (c_language_defn): Likewise.
5613 (cplus_language_defn): Likewise.
5614 (asm_language_defn): Likewise.
5615 (minimal_language_defn): Likewise.
5616 * d-lang.c (d_language_defn): Likewise.
5617 * f-lang.c (f_language_defn): Likewise.
5618 * go-lang.c (go_language_defn): Likewise.
5619 * language.c (unknown_language_defn): Likewise.
5620 (auto_language_defn): Likewise.
5621 * language.h (struct language_defn): Remove la_magic field.
5622 (LANG_MAGIC): Delete.
5623 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5624 * objc-lang.c (objc_language_defn): Likewise.
5625 * opencl-lang.c (opencl_language_defn): Likewise.
5626 * p-lang.c (pascal_language_defn): Likewise.
5627 * rust-lang.c (rust_language_defn): Likewise.
5629 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5631 * riscv-tdep.c (riscv_type_align): New function.
5632 (riscv_type_alignment): Delete.
5633 (riscv_arg_location): Use 'type_align'.
5634 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5636 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5638 * gdbtypes.c (type_align): A struct with no non-static fields also
5641 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5643 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5645 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5647 (riscv_struct_info::analyse): New implementation using new
5648 analyse_inner member function.
5649 (riscv_struct_info::field_offset): New member function.
5650 (riscv_struct_info::m_offsets): New member variable.
5651 (riscv_struct_info::analyse_inner): New private member function,
5652 takes the old implementation of riscv_struct_info::analyse but
5653 extended to track field offsets.
5654 (riscv_call_arg_struct): Update the struct folding special cases
5655 to handle cases where empty C++ structs, which are non-zero
5657 (riscv_arg_location): Initialise the length of each location, a
5658 non-zero length now indicates the location is in use.
5659 (riscv_push_dummy_call): Allow for the first location having a
5660 non-zero offset when setting up arguments.
5661 (riscv_return_value): Likewise, but for return values.
5663 2019-04-11 Tom Tromey <tromey@adacore.com>
5665 * utils.c (internal_vproblem): Make "msg" const.
5667 2019-04-11 Alan Hayward <alan.hayward@arm.com>
5669 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5670 * trad-frame.c (trad_frame_reset_saved_regs): New function.
5671 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5672 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5674 2019-04-10 Kevin Buettner <kevinb@redhat.com>
5676 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5678 (fill_gregset): Call amd64_linux_collect_native_gregset instead
5679 of amd64_collect_native_gregset.
5680 (amd64_linux_nat_target::store_registers): Likewise.
5682 2019-04-10 Tom Tromey <tom@tromey.com>
5684 * symtab.c (lookup_global_symbol_from_objfile)
5685 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5686 * objfiles.h (class separate_debug_iterator): New.
5687 (class separate_debug_range): New.
5688 (struct objfile) <separate_debug_objfiles>: New method.
5689 (objfile_separate_debug_iterate): Don't declare.
5690 * objfiles.c (separate_debug_iterator::operator++): Rename from
5691 objfile_separate_debug_iterate.
5692 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5694 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5697 2019-04-10 Tom Tromey <tom@tromey.com>
5699 * symfile.c (reread_symbols): Remove old comment.
5700 * objfiles.c (free_all_objfiles): Fix a typo.
5702 2019-04-10 Tom Tromey <tom@tromey.com>
5704 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5705 * minsyms.c (lookup_minimal_symbol): Use foreach.
5706 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5707 (lookup_minimal_symbol_solib_trampoline): Likewise.
5708 * symfile.c (reread_symbols): Use foreach.
5710 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
5711 Tom Tromey <tromey@adacore.com>
5714 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5715 (rust_lex_int_test): Change "value" to be LONGEST.
5716 (rust_lex_tests): Add test for long integer literal.
5718 2019-04-09 Tom Tromey <tromey@adacore.com>
5720 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5722 (extended_remote_target::attach): Update.
5723 (remote_target::remote_notice_new_inferior): Update.
5724 (remote_target::add_current_inferior_and_thread): Update.
5725 * inferior.c (exit_inferior_1): Use "false".
5726 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5728 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
5730 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5731 the "start" command.
5733 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5735 * python/py-inferior.c (infpy_thread_from_thread_handle):
5736 Adjust comments to reflect renaming of thread_from_thread_handle
5737 to thread_from_handle. Adjust keywords. Fix type error message.
5738 (inferior_object_methods): Add thread_from_handle. Retain
5739 thread_from_thread_handle, but mark it as deprecated.
5741 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5743 * gdbthread.h (find_thread_by_handle): Revise declaration.
5744 * thread.c (find_thread_by_handle): Likewise. Adjust
5746 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5747 support for buffer objects as handles.
5749 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5751 * python/py-infthread.c (thpy_thread_handle): New function.
5752 (thread_object_methods): Register thpy_thread_handle.
5754 2019-04-08 Kevin Buettner <kevinb@redhat.com>
5756 * gdbthread.h (thread_to_thread_handle): Declare.
5757 * thread.c (gdbtypes.h): Include.
5758 (thread_to_thread_handle): New function.
5760 * target.h (struct target_ops): Add thread_info_to_thread_handle.
5761 (target_thread_info_to_thread_handle): Declare.
5762 * target.c (target_thread_info_to_thread_handle): New function.
5763 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5764 * target-delegates.c: Regenerate.
5766 * linux-thread-db.c (class thread_db_target): Add method
5767 thread_info_to_thread_handle.
5768 (thread_db_target::thread_info_to_thread_handle): Define.
5769 * remote.c (class remote_target): Add new method
5770 thread_info_to_thread_handle.
5771 (remote_target::thread_info_to_thread_handle): Define.
5773 2019-04-08 Pedro Alves <palves@redhat.com>
5775 * common/common-exceptions.c (throw_exception): Don't create
5776 named object to throw; throw directly.
5777 (throw_it): Likewise. Don't initialize gdb_exception::message
5778 here, with new; pass FMT and AP to the ctor instead.
5779 * common/common-exceptions.h: Include <string>.
5780 (gdb_exception::gdb_exception(enum return_reason, enum errors,
5781 const char *, va_list)): New ctor. Use std::make_shared.
5782 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5784 (gdb_exception_error::gdb_exception_error(enum errors, const char
5786 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5788 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5790 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5791 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5794 2019-04-08 Tom Tromey <tom@tromey.com>
5796 * valops.c (value_rtti_indirect_type): Replace throw_exception
5798 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5800 * thread.c (thr_try_catch_cmd): Replace throw_exception with
5802 * target.c (target_translate_tls_address): Replace throw_exception
5804 * stack.c (frame_apply_command_count): Replace throw_exception
5806 * solib-spu.c (append_ocl_sos): Replace throw_exception with
5808 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5810 * rs6000-tdep.c (rs6000_frame_cache)
5811 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5812 * remote.c: Replace throw_exception with throw.
5813 * record-full.c (record_full_message, record_full_wait_1)
5814 (record_full_restore): Replace throw_exception with throw.
5816 (get_thread_current_frame_id, record_btrace_start_replaying)
5817 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5818 (cmd_record_btrace_start): Replace throw_exception with throw.
5819 * parse.c (parse_exp_in_context_1): Replace throw_exception with
5821 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5822 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5824 (find_linespec_symbols): Replace throw_exception with throw.
5825 * infrun.c (displaced_step_prepare, resume): Replace
5826 throw_exception with throw.
5827 * infcmd.c (post_create_inferior): Replace throw_exception with
5829 * inf-loop.c (inferior_event_handler): Replace throw_exception
5831 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5832 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5833 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5834 (get_prev_frame_always, get_frame_pc_if_available)
5835 (get_frame_address_in_block_if_available, get_frame_language):
5836 Replace throw_exception with throw.
5837 * frame-unwind.c (frame_unwind_try_unwinder): Replace
5838 throw_exception with throw.
5839 * eval.c (fetch_subexp_value, evaluate_var_value)
5840 (evaluate_funcall, evaluate_subexp_standard): Replace
5841 throw_exception with throw.
5842 * dwarf2loc.c (call_site_find_chain)
5843 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5844 Replace throw_exception with throw.
5845 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5847 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5849 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5850 * completer.c (complete_line_internal): Replace throw_exception
5852 * compile/compile-object-run.c (compile_object_run): Replace
5853 throw_exception with throw.
5854 * cli/cli-script.c (process_next_line): Replace throw_exception
5856 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5857 (btrace_enable, btrace_maint_update_pt_packets): Replace
5858 throw_exception with throw.
5859 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5860 throw_exception with throw.
5861 * break-catch-throw.c (re_set_exception_catchpoint): Replace
5862 throw_exception with throw.
5863 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5864 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5865 * aarch64-tdep.c (aarch64_make_prologue_cache)
5866 (aarch64_make_stub_cache): Replace throw_exception with throw.
5868 2019-04-08 Tom Tromey <tom@tromey.com>
5870 * common/common-exceptions.c (throw_exception): Rename from
5871 throw_exception_cxx. Remove old copy. Make argument const.
5872 (throw_it): Create and throw exception objects directly.
5873 * common/common-exceptions.h (throw_exception): Make argument
5875 (struct gdb_exception_error): Add constructor.
5876 (struct gdb_exception_quit): Add constructor.
5878 2019-04-08 Tom Tromey <tom@tromey.com>
5880 * common/common-exceptions.h (exception_rethrow): Don't declare.
5881 (TRY_SJLJ): Update comment.
5882 (TRY, CATCH, END_CATCH): Remove.
5883 * common/common-exceptions.c (exception_rethrow): Remove.
5885 2019-04-08 Tom Tromey <tom@tromey.com>
5887 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5889 (gdb_exception_error): Rename from
5890 gdb_exception_RETURN_MASK_ERROR.
5891 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5892 (gdb_quit_bad_alloc): Update.
5893 * aarch64-tdep.c: Update.
5894 * ada-lang.c: Update.
5895 * ada-typeprint.c: Update.
5896 * ada-valprint.c: Update.
5897 * amd64-tdep.c: Update.
5898 * arch-utils.c: Update.
5899 * break-catch-throw.c: Update.
5900 * breakpoint.c: Update.
5902 * c-varobj.c: Update.
5903 * cli/cli-cmds.c: Update.
5904 * cli/cli-interp.c: Update.
5905 * cli/cli-script.c: Update.
5906 * common/common-exceptions.c: Update.
5907 * common/new-op.c: Update.
5908 * common/selftest.c: Update.
5909 * compile/compile-c-symbols.c: Update.
5910 * compile/compile-cplus-symbols.c: Update.
5911 * compile/compile-object-load.c: Update.
5912 * compile/compile-object-run.c: Update.
5913 * completer.c: Update.
5914 * corelow.c: Update.
5916 * cp-support.c: Update.
5917 * cp-valprint.c: Update.
5918 * darwin-nat.c: Update.
5919 * disasm-selftests.c: Update.
5920 * dtrace-probe.c: Update.
5921 * dwarf-index-cache.c: Update.
5922 * dwarf-index-write.c: Update.
5923 * dwarf2-frame-tailcall.c: Update.
5924 * dwarf2-frame.c: Update.
5925 * dwarf2loc.c: Update.
5926 * dwarf2read.c: Update.
5928 * event-loop.c: Update.
5929 * event-top.c: Update.
5931 * f-valprint.c: Update.
5932 * fbsd-tdep.c: Update.
5933 * frame-unwind.c: Update.
5935 * gdbtypes.c: Update.
5936 * gnu-v3-abi.c: Update.
5937 * guile/guile-internal.h: Update.
5938 * guile/scm-block.c: Update.
5939 * guile/scm-breakpoint.c: Update.
5940 * guile/scm-cmd.c: Update.
5941 * guile/scm-disasm.c: Update.
5942 * guile/scm-frame.c: Update.
5943 * guile/scm-lazy-string.c: Update.
5944 * guile/scm-math.c: Update.
5945 * guile/scm-param.c: Update.
5946 * guile/scm-ports.c: Update.
5947 * guile/scm-pretty-print.c: Update.
5948 * guile/scm-symbol.c: Update.
5949 * guile/scm-symtab.c: Update.
5950 * guile/scm-type.c: Update.
5951 * guile/scm-value.c: Update.
5952 * i386-linux-tdep.c: Update.
5953 * i386-tdep.c: Update.
5954 * inf-loop.c: Update.
5955 * infcall.c: Update.
5959 * language.c: Update.
5960 * linespec.c: Update.
5961 * linux-fork.c: Update.
5962 * linux-nat.c: Update.
5963 * linux-tdep.c: Update.
5964 * linux-thread-db.c: Update.
5966 * mi/mi-cmd-break.c: Update.
5967 * mi/mi-cmd-stack.c: Update.
5968 * mi/mi-interp.c: Update.
5969 * mi/mi-main.c: Update.
5970 * objc-lang.c: Update.
5971 * p-valprint.c: Update.
5973 * ppc-linux-tdep.c: Update.
5974 * printcmd.c: Update.
5975 * python/py-arch.c: Update.
5976 * python/py-breakpoint.c: Update.
5977 * python/py-cmd.c: Update.
5978 * python/py-finishbreakpoint.c: Update.
5979 * python/py-frame.c: Update.
5980 * python/py-framefilter.c: Update.
5981 * python/py-gdb-readline.c: Update.
5982 * python/py-inferior.c: Update.
5983 * python/py-infthread.c: Update.
5984 * python/py-lazy-string.c: Update.
5985 * python/py-linetable.c: Update.
5986 * python/py-objfile.c: Update.
5987 * python/py-param.c: Update.
5988 * python/py-prettyprint.c: Update.
5989 * python/py-progspace.c: Update.
5990 * python/py-record-btrace.c: Update.
5991 * python/py-record.c: Update.
5992 * python/py-symbol.c: Update.
5993 * python/py-type.c: Update.
5994 * python/py-unwind.c: Update.
5995 * python/py-utils.c: Update.
5996 * python/py-value.c: Update.
5997 * python/python.c: Update.
5998 * record-btrace.c: Update.
5999 * record-full.c: Update.
6000 * remote-fileio.c: Update.
6002 * riscv-tdep.c: Update.
6003 * rs6000-aix-tdep.c: Update.
6004 * rs6000-tdep.c: Update.
6005 * rust-exp.y: Update.
6006 * rust-lang.c: Update.
6007 * s390-tdep.c: Update.
6008 * selftest-arch.c: Update.
6009 * solib-dsbt.c: Update.
6010 * solib-frv.c: Update.
6011 * solib-spu.c: Update.
6012 * solib-svr4.c: Update.
6014 * sparc64-linux-tdep.c: Update.
6016 * symfile-mem.c: Update.
6017 * symmisc.c: Update.
6021 * tracefile-tfile.c: Update.
6022 * tui/tui.c: Update.
6023 * typeprint.c: Update.
6024 * unittests/cli-utils-selftests.c: Update.
6025 * unittests/parse-connection-spec-selftests.c: Update.
6027 * valprint.c: Update.
6030 * windows-nat.c: Update.
6031 * x86-linux-nat.c: Update.
6032 * xml-support.c: Update.
6034 2019-04-08 Tom Tromey <tom@tromey.com>
6036 * xml-support.c: Use C++ exception handling.
6037 * x86-linux-nat.c: Use C++ exception handling.
6038 * windows-nat.c: Use C++ exception handling.
6039 * varobj.c: Use C++ exception handling.
6040 * value.c: Use C++ exception handling.
6041 * valprint.c: Use C++ exception handling.
6042 * valops.c: Use C++ exception handling.
6043 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6045 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6046 * typeprint.c: Use C++ exception handling.
6047 * tui/tui.c: Use C++ exception handling.
6048 * tracefile-tfile.c: Use C++ exception handling.
6049 * top.c: Use C++ exception handling.
6050 * thread.c: Use C++ exception handling.
6051 * target.c: Use C++ exception handling.
6052 * symmisc.c: Use C++ exception handling.
6053 * symfile-mem.c: Use C++ exception handling.
6054 * stack.c: Use C++ exception handling.
6055 * sparc64-linux-tdep.c: Use C++ exception handling.
6056 * solib.c: Use C++ exception handling.
6057 * solib-svr4.c: Use C++ exception handling.
6058 * solib-spu.c: Use C++ exception handling.
6059 * solib-frv.c: Use C++ exception handling.
6060 * solib-dsbt.c: Use C++ exception handling.
6061 * selftest-arch.c: Use C++ exception handling.
6062 * s390-tdep.c: Use C++ exception handling.
6063 * rust-lang.c: Use C++ exception handling.
6064 * rust-exp.y: Use C++ exception handling.
6065 * rs6000-tdep.c: Use C++ exception handling.
6066 * rs6000-aix-tdep.c: Use C++ exception handling.
6067 * riscv-tdep.c: Use C++ exception handling.
6068 * remote.c: Use C++ exception handling.
6069 * remote-fileio.c: Use C++ exception handling.
6070 * record-full.c: Use C++ exception handling.
6071 * record-btrace.c: Use C++ exception handling.
6072 * python/python.c: Use C++ exception handling.
6073 * python/py-value.c: Use C++ exception handling.
6074 * python/py-utils.c: Use C++ exception handling.
6075 * python/py-unwind.c: Use C++ exception handling.
6076 * python/py-type.c: Use C++ exception handling.
6077 * python/py-symbol.c: Use C++ exception handling.
6078 * python/py-record.c: Use C++ exception handling.
6079 * python/py-record-btrace.c: Use C++ exception handling.
6080 * python/py-progspace.c: Use C++ exception handling.
6081 * python/py-prettyprint.c: Use C++ exception handling.
6082 * python/py-param.c: Use C++ exception handling.
6083 * python/py-objfile.c: Use C++ exception handling.
6084 * python/py-linetable.c: Use C++ exception handling.
6085 * python/py-lazy-string.c: Use C++ exception handling.
6086 * python/py-infthread.c: Use C++ exception handling.
6087 * python/py-inferior.c: Use C++ exception handling.
6088 * python/py-gdb-readline.c: Use C++ exception handling.
6089 * python/py-framefilter.c: Use C++ exception handling.
6090 * python/py-frame.c: Use C++ exception handling.
6091 * python/py-finishbreakpoint.c: Use C++ exception handling.
6092 * python/py-cmd.c: Use C++ exception handling.
6093 * python/py-breakpoint.c: Use C++ exception handling.
6094 * python/py-arch.c: Use C++ exception handling.
6095 * printcmd.c: Use C++ exception handling.
6096 * ppc-linux-tdep.c: Use C++ exception handling.
6097 * parse.c: Use C++ exception handling.
6098 * p-valprint.c: Use C++ exception handling.
6099 * objc-lang.c: Use C++ exception handling.
6100 * mi/mi-main.c: Use C++ exception handling.
6101 * mi/mi-interp.c: Use C++ exception handling.
6102 * mi/mi-cmd-stack.c: Use C++ exception handling.
6103 * mi/mi-cmd-break.c: Use C++ exception handling.
6104 * main.c: Use C++ exception handling.
6105 * linux-thread-db.c: Use C++ exception handling.
6106 * linux-tdep.c: Use C++ exception handling.
6107 * linux-nat.c: Use C++ exception handling.
6108 * linux-fork.c: Use C++ exception handling.
6109 * linespec.c: Use C++ exception handling.
6110 * language.c: Use C++ exception handling.
6111 * jit.c: Use C++ exception handling.
6112 * infrun.c: Use C++ exception handling.
6113 * infcmd.c: Use C++ exception handling.
6114 * infcall.c: Use C++ exception handling.
6115 * inf-loop.c: Use C++ exception handling.
6116 * i386-tdep.c: Use C++ exception handling.
6117 * i386-linux-tdep.c: Use C++ exception handling.
6118 * guile/scm-value.c: Use C++ exception handling.
6119 * guile/scm-type.c: Use C++ exception handling.
6120 * guile/scm-symtab.c: Use C++ exception handling.
6121 * guile/scm-symbol.c: Use C++ exception handling.
6122 * guile/scm-pretty-print.c: Use C++ exception handling.
6123 * guile/scm-ports.c: Use C++ exception handling.
6124 * guile/scm-param.c: Use C++ exception handling.
6125 * guile/scm-math.c: Use C++ exception handling.
6126 * guile/scm-lazy-string.c: Use C++ exception handling.
6127 * guile/scm-frame.c: Use C++ exception handling.
6128 * guile/scm-disasm.c: Use C++ exception handling.
6129 * guile/scm-cmd.c: Use C++ exception handling.
6130 * guile/scm-breakpoint.c: Use C++ exception handling.
6131 * guile/scm-block.c: Use C++ exception handling.
6132 * guile/guile-internal.h: Use C++ exception handling.
6133 * gnu-v3-abi.c: Use C++ exception handling.
6134 * gdbtypes.c: Use C++ exception handling.
6135 * frame.c: Use C++ exception handling.
6136 * frame-unwind.c: Use C++ exception handling.
6137 * fbsd-tdep.c: Use C++ exception handling.
6138 * f-valprint.c: Use C++ exception handling.
6139 * exec.c: Use C++ exception handling.
6140 * event-top.c: Use C++ exception handling.
6141 * event-loop.c: Use C++ exception handling.
6142 * eval.c: Use C++ exception handling.
6143 * dwarf2read.c: Use C++ exception handling.
6144 * dwarf2loc.c: Use C++ exception handling.
6145 * dwarf2-frame.c: Use C++ exception handling.
6146 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6147 * dwarf-index-write.c: Use C++ exception handling.
6148 * dwarf-index-cache.c: Use C++ exception handling.
6149 * dtrace-probe.c: Use C++ exception handling.
6150 * disasm-selftests.c: Use C++ exception handling.
6151 * darwin-nat.c: Use C++ exception handling.
6152 * cp-valprint.c: Use C++ exception handling.
6153 * cp-support.c: Use C++ exception handling.
6154 * cp-abi.c: Use C++ exception handling.
6155 * corelow.c: Use C++ exception handling.
6156 * completer.c: Use C++ exception handling.
6157 * compile/compile-object-run.c: Use C++ exception handling.
6158 * compile/compile-object-load.c: Use C++ exception handling.
6159 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6160 * compile/compile-c-symbols.c: Use C++ exception handling.
6161 * common/selftest.c: Use C++ exception handling.
6162 * common/new-op.c: Use C++ exception handling.
6163 * cli/cli-script.c: Use C++ exception handling.
6164 * cli/cli-interp.c: Use C++ exception handling.
6165 * cli/cli-cmds.c: Use C++ exception handling.
6166 * c-varobj.c: Use C++ exception handling.
6167 * btrace.c: Use C++ exception handling.
6168 * breakpoint.c: Use C++ exception handling.
6169 * break-catch-throw.c: Use C++ exception handling.
6170 * arch-utils.c: Use C++ exception handling.
6171 * amd64-tdep.c: Use C++ exception handling.
6172 * ada-valprint.c: Use C++ exception handling.
6173 * ada-typeprint.c: Use C++ exception handling.
6174 * ada-lang.c: Use C++ exception handling.
6175 * aarch64-tdep.c: Use C++ exception handling.
6177 2019-04-08 Tom Tromey <tom@tromey.com>
6179 * xml-support.c (gdb_xml_parser::parse): Update.
6180 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6181 * value.c (show_convenience): Update.
6182 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6183 (test_parse_flags_qcs): Update.
6184 * thread.c (thr_try_catch_cmd): Update.
6185 * target.c (target_translate_tls_address): Update.
6186 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6187 (info_frame_command_core, frame_apply_command_count): Update.
6188 * rust-exp.y (rust_lex_exception_test): Update.
6189 * riscv-tdep.c (riscv_print_one_register_info): Update.
6190 * remote.c (remote_target::enable_btrace): Update.
6191 * record-btrace.c (record_btrace_enable_warn): Update.
6192 * python/py-utils.c (gdbpy_convert_exception): Update.
6193 * printcmd.c (do_one_display, print_variable_and_value): Update.
6194 * mi/mi-main.c (mi_print_exception): Update.
6195 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6196 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6197 * linux-nat.c (linux_nat_target::attach): Update.
6198 * linux-fork.c (class scoped_switch_fork_info): Update.
6199 * infrun.c (displaced_step_prepare): Update.
6200 * infcall.c (call_function_by_hand_dummy): Update.
6201 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6202 * gnu-v3-abi.c (print_one_vtable): Update.
6203 * frame.c (get_prev_frame_always): Update.
6204 * f-valprint.c (info_common_command_for_block): Update.
6205 * exec.c (try_open_exec_file): Update.
6206 * exceptions.c (print_exception, exception_print)
6207 (exception_fprintf, exception_print_same): Update.
6208 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6209 * dwarf-index-cache.c (index_cache::store)
6210 (index_cache::lookup_gdb_index): Update.
6211 * darwin-nat.c (maybe_cache_shell): Update.
6212 * cp-valprint.c (cp_print_value_fields): Update.
6213 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6214 (gcc_cplus_symbol_address): Update.
6215 * compile/compile-c-symbols.c (gcc_convert_symbol)
6216 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6217 * common/selftest.c: Update.
6218 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6220 (exception_try_scope_entry, exception_try_scope_exit): Don't
6222 (struct exception_try_scope): Remove.
6223 (TRY): Don't use exception_try_scope.
6224 (struct gdb_exception): Add constructor, operator=.
6226 (struct gdb_exception_RETURN_MASK_ALL)
6227 (struct gdb_exception_RETURN_MASK_ERROR)
6228 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6229 (struct gdb_quit_bad_alloc): Update.
6230 * common/common-exceptions.c (exception_none): Change
6232 (struct catcher) <state, exception>: Initialize inline.
6233 <prev>: Remove member.
6234 (current_catcher): Remove.
6235 (catchers): New global.
6236 (exceptions_state_mc_init): Simplify.
6237 (catcher_pop): Remove.
6238 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6239 (try_scope_depth, exception_try_scope_entry)
6240 (exception_try_scope_exit): Remove.
6241 (throw_exception_sjlj): Update.
6242 (exception_messages, exception_messages_size): Remove.
6243 (throw_it): Simplify.
6244 (gdb_exception_sliced_copy): Remove.
6245 (throw_exception_cxx): Update.
6246 * cli/cli-script.c (script_from_file): Update.
6247 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6249 * ada-valprint.c (ada_val_print): Update.
6250 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6251 (create_excep_cond_exprs): Update.
6253 2019-04-08 Tom Tromey <tom@tromey.com>
6255 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6256 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6257 (TRY, CATCH, END_CATCH): Remove some definitions.
6258 * common/common-exceptions.c: Don't use GDB_XCPT.
6259 (catcher_list_size): Remove.
6260 (throw_exception, throw_it): Simplify.
6262 2019-04-05 Tom Tromey <tom@tromey.com>
6264 Revert the header-sorting patch.
6265 * ft32-tdep.c: Revert.
6266 * frv-tdep.c: Revert.
6267 * frv-linux-tdep.c: Revert.
6269 * frame-unwind.c: Revert.
6270 * frame-base.c: Revert.
6271 * fork-child.c: Revert.
6272 * findvar.c: Revert.
6273 * findcmd.c: Revert.
6274 * filesystem.c: Revert.
6275 * filename-seen-cache.h: Revert.
6276 * filename-seen-cache.c: Revert.
6277 * fbsd-tdep.c: Revert.
6278 * fbsd-nat.h: Revert.
6279 * fbsd-nat.c: Revert.
6280 * f-valprint.c: Revert.
6281 * f-typeprint.c: Revert.
6283 * extension.h: Revert.
6284 * extension.c: Revert.
6285 * extension-priv.h: Revert.
6286 * expprint.c: Revert.
6289 * exceptions.c: Revert.
6290 * event-top.c: Revert.
6291 * event-loop.c: Revert.
6293 * elfread.c: Revert.
6294 * dwarf2read.h: Revert.
6295 * dwarf2read.c: Revert.
6296 * dwarf2loc.c: Revert.
6297 * dwarf2expr.h: Revert.
6298 * dwarf2expr.c: Revert.
6299 * dwarf2-frame.c: Revert.
6300 * dwarf2-frame-tailcall.c: Revert.
6301 * dwarf-index-write.h: Revert.
6302 * dwarf-index-write.c: Revert.
6303 * dwarf-index-common.c: Revert.
6304 * dwarf-index-cache.h: Revert.
6305 * dwarf-index-cache.c: Revert.
6306 * dummy-frame.c: Revert.
6307 * dtrace-probe.c: Revert.
6310 * disasm-selftests.c: Revert.
6311 * dictionary.c: Revert.
6312 * dicos-tdep.c: Revert.
6313 * demangle.c: Revert.
6316 * darwin-nat.h: Revert.
6317 * darwin-nat.c: Revert.
6318 * darwin-nat-info.c: Revert.
6319 * d-valprint.c: Revert.
6320 * d-namespace.c: Revert.
6323 * csky-tdep.c: Revert.
6324 * csky-linux-tdep.c: Revert.
6325 * cris-tdep.c: Revert.
6326 * cris-linux-tdep.c: Revert.
6327 * cp-valprint.c: Revert.
6328 * cp-support.c: Revert.
6329 * cp-namespace.c: Revert.
6331 * corelow.c: Revert.
6332 * corefile.c: Revert.
6333 * continuations.c: Revert.
6334 * completer.h: Revert.
6335 * completer.c: Revert.
6336 * complaints.c: Revert.
6337 * coffread.c: Revert.
6338 * coff-pe-read.c: Revert.
6339 * cli-out.h: Revert.
6340 * cli-out.c: Revert.
6341 * charset.c: Revert.
6342 * c-varobj.c: Revert.
6343 * c-valprint.c: Revert.
6344 * c-typeprint.c: Revert.
6346 * buildsym.c: Revert.
6347 * buildsym-legacy.c: Revert.
6348 * build-id.h: Revert.
6349 * build-id.c: Revert.
6351 * bsd-uthread.c: Revert.
6352 * breakpoint.h: Revert.
6353 * breakpoint.c: Revert.
6354 * break-catch-throw.c: Revert.
6355 * break-catch-syscall.c: Revert.
6356 * break-catch-sig.c: Revert.
6357 * blockframe.c: Revert.
6359 * bfin-tdep.c: Revert.
6360 * bfin-linux-tdep.c: Revert.
6361 * bfd-target.c: Revert.
6363 * ax-general.c: Revert.
6366 * avr-tdep.c: Revert.
6368 * auto-load.c: Revert.
6369 * arm-wince-tdep.c: Revert.
6370 * arm-tdep.c: Revert.
6371 * arm-symbian-tdep.c: Revert.
6372 * arm-pikeos-tdep.c: Revert.
6373 * arm-obsd-tdep.c: Revert.
6374 * arm-nbsd-tdep.c: Revert.
6375 * arm-nbsd-nat.c: Revert.
6376 * arm-linux-tdep.c: Revert.
6377 * arm-linux-nat.c: Revert.
6378 * arm-fbsd-tdep.c: Revert.
6379 * arm-fbsd-nat.c: Revert.
6380 * arm-bsd-tdep.c: Revert.
6381 * arch-utils.c: Revert.
6382 * arc-tdep.c: Revert.
6383 * arc-newlib-tdep.c: Revert.
6384 * annotate.h: Revert.
6385 * annotate.c: Revert.
6386 * amd64-windows-tdep.c: Revert.
6387 * amd64-windows-nat.c: Revert.
6388 * amd64-tdep.c: Revert.
6389 * amd64-sol2-tdep.c: Revert.
6390 * amd64-obsd-tdep.c: Revert.
6391 * amd64-obsd-nat.c: Revert.
6392 * amd64-nbsd-tdep.c: Revert.
6393 * amd64-nbsd-nat.c: Revert.
6394 * amd64-nat.c: Revert.
6395 * amd64-linux-tdep.c: Revert.
6396 * amd64-linux-nat.c: Revert.
6397 * amd64-fbsd-tdep.c: Revert.
6398 * amd64-fbsd-nat.c: Revert.
6399 * amd64-dicos-tdep.c: Revert.
6400 * amd64-darwin-tdep.c: Revert.
6401 * amd64-bsd-nat.c: Revert.
6402 * alpha-tdep.c: Revert.
6403 * alpha-obsd-tdep.c: Revert.
6404 * alpha-nbsd-tdep.c: Revert.
6405 * alpha-mdebug-tdep.c: Revert.
6406 * alpha-linux-tdep.c: Revert.
6407 * alpha-linux-nat.c: Revert.
6408 * alpha-bsd-tdep.c: Revert.
6409 * alpha-bsd-nat.c: Revert.
6410 * aix-thread.c: Revert.
6412 * addrmap.c: Revert.
6413 * ada-varobj.c: Revert.
6414 * ada-valprint.c: Revert.
6415 * ada-typeprint.c: Revert.
6416 * ada-tasks.c: Revert.
6417 * ada-lang.c: Revert.
6418 * aarch64-tdep.c: Revert.
6419 * aarch64-ravenscar-thread.c: Revert.
6420 * aarch64-newlib-tdep.c: Revert.
6421 * aarch64-linux-tdep.c: Revert.
6422 * aarch64-linux-nat.c: Revert.
6423 * aarch64-fbsd-tdep.c: Revert.
6424 * aarch64-fbsd-nat.c: Revert.
6425 * aarch32-linux-nat.c: Revert.
6427 2019-04-05 Tom Tromey <tom@tromey.com>
6429 * ft32-tdep.c: Sort headers.
6430 * frv-tdep.c: Sort headers.
6431 * frv-linux-tdep.c: Sort headers.
6432 * frame.c: Sort headers.
6433 * frame-unwind.c: Sort headers.
6434 * frame-base.c: Sort headers.
6435 * fork-child.c: Sort headers.
6436 * findvar.c: Sort headers.
6437 * findcmd.c: Sort headers.
6438 * filesystem.c: Sort headers.
6439 * filename-seen-cache.h: Sort headers.
6440 * filename-seen-cache.c: Sort headers.
6441 * fbsd-tdep.c: Sort headers.
6442 * fbsd-nat.h: Sort headers.
6443 * fbsd-nat.c: Sort headers.
6444 * f-valprint.c: Sort headers.
6445 * f-typeprint.c: Sort headers.
6446 * f-lang.c: Sort headers.
6447 * extension.h: Sort headers.
6448 * extension.c: Sort headers.
6449 * extension-priv.h: Sort headers.
6450 * expprint.c: Sort headers.
6451 * exec.h: Sort headers.
6452 * exec.c: Sort headers.
6453 * exceptions.c: Sort headers.
6454 * event-top.c: Sort headers.
6455 * event-loop.c: Sort headers.
6456 * eval.c: Sort headers.
6457 * elfread.c: Sort headers.
6458 * dwarf2read.h: Sort headers.
6459 * dwarf2read.c: Sort headers.
6460 * dwarf2loc.c: Sort headers.
6461 * dwarf2expr.h: Sort headers.
6462 * dwarf2expr.c: Sort headers.
6463 * dwarf2-frame.c: Sort headers.
6464 * dwarf2-frame-tailcall.c: Sort headers.
6465 * dwarf-index-write.h: Sort headers.
6466 * dwarf-index-write.c: Sort headers.
6467 * dwarf-index-common.c: Sort headers.
6468 * dwarf-index-cache.h: Sort headers.
6469 * dwarf-index-cache.c: Sort headers.
6470 * dummy-frame.c: Sort headers.
6471 * dtrace-probe.c: Sort headers.
6472 * disasm.h: Sort headers.
6473 * disasm.c: Sort headers.
6474 * disasm-selftests.c: Sort headers.
6475 * dictionary.c: Sort headers.
6476 * dicos-tdep.c: Sort headers.
6477 * demangle.c: Sort headers.
6478 * dcache.h: Sort headers.
6479 * dcache.c: Sort headers.
6480 * darwin-nat.h: Sort headers.
6481 * darwin-nat.c: Sort headers.
6482 * darwin-nat-info.c: Sort headers.
6483 * d-valprint.c: Sort headers.
6484 * d-namespace.c: Sort headers.
6485 * d-lang.c: Sort headers.
6486 * ctf.c: Sort headers.
6487 * csky-tdep.c: Sort headers.
6488 * csky-linux-tdep.c: Sort headers.
6489 * cris-tdep.c: Sort headers.
6490 * cris-linux-tdep.c: Sort headers.
6491 * cp-valprint.c: Sort headers.
6492 * cp-support.c: Sort headers.
6493 * cp-namespace.c: Sort headers.
6494 * cp-abi.c: Sort headers.
6495 * corelow.c: Sort headers.
6496 * corefile.c: Sort headers.
6497 * continuations.c: Sort headers.
6498 * completer.h: Sort headers.
6499 * completer.c: Sort headers.
6500 * complaints.c: Sort headers.
6501 * coffread.c: Sort headers.
6502 * coff-pe-read.c: Sort headers.
6503 * cli-out.h: Sort headers.
6504 * cli-out.c: Sort headers.
6505 * charset.c: Sort headers.
6506 * c-varobj.c: Sort headers.
6507 * c-valprint.c: Sort headers.
6508 * c-typeprint.c: Sort headers.
6509 * c-lang.c: Sort headers.
6510 * buildsym.c: Sort headers.
6511 * buildsym-legacy.c: Sort headers.
6512 * build-id.h: Sort headers.
6513 * build-id.c: Sort headers.
6514 * btrace.c: Sort headers.
6515 * bsd-uthread.c: Sort headers.
6516 * breakpoint.h: Sort headers.
6517 * breakpoint.c: Sort headers.
6518 * break-catch-throw.c: Sort headers.
6519 * break-catch-syscall.c: Sort headers.
6520 * break-catch-sig.c: Sort headers.
6521 * blockframe.c: Sort headers.
6522 * block.c: Sort headers.
6523 * bfin-tdep.c: Sort headers.
6524 * bfin-linux-tdep.c: Sort headers.
6525 * bfd-target.c: Sort headers.
6526 * bcache.c: Sort headers.
6527 * ax-general.c: Sort headers.
6528 * ax-gdb.h: Sort headers.
6529 * ax-gdb.c: Sort headers.
6530 * avr-tdep.c: Sort headers.
6531 * auxv.c: Sort headers.
6532 * auto-load.c: Sort headers.
6533 * arm-wince-tdep.c: Sort headers.
6534 * arm-tdep.c: Sort headers.
6535 * arm-symbian-tdep.c: Sort headers.
6536 * arm-pikeos-tdep.c: Sort headers.
6537 * arm-obsd-tdep.c: Sort headers.
6538 * arm-nbsd-tdep.c: Sort headers.
6539 * arm-nbsd-nat.c: Sort headers.
6540 * arm-linux-tdep.c: Sort headers.
6541 * arm-linux-nat.c: Sort headers.
6542 * arm-fbsd-tdep.c: Sort headers.
6543 * arm-fbsd-nat.c: Sort headers.
6544 * arm-bsd-tdep.c: Sort headers.
6545 * arch-utils.c: Sort headers.
6546 * arc-tdep.c: Sort headers.
6547 * arc-newlib-tdep.c: Sort headers.
6548 * annotate.h: Sort headers.
6549 * annotate.c: Sort headers.
6550 * amd64-windows-tdep.c: Sort headers.
6551 * amd64-windows-nat.c: Sort headers.
6552 * amd64-tdep.c: Sort headers.
6553 * amd64-sol2-tdep.c: Sort headers.
6554 * amd64-obsd-tdep.c: Sort headers.
6555 * amd64-obsd-nat.c: Sort headers.
6556 * amd64-nbsd-tdep.c: Sort headers.
6557 * amd64-nbsd-nat.c: Sort headers.
6558 * amd64-nat.c: Sort headers.
6559 * amd64-linux-tdep.c: Sort headers.
6560 * amd64-linux-nat.c: Sort headers.
6561 * amd64-fbsd-tdep.c: Sort headers.
6562 * amd64-fbsd-nat.c: Sort headers.
6563 * amd64-dicos-tdep.c: Sort headers.
6564 * amd64-darwin-tdep.c: Sort headers.
6565 * amd64-bsd-nat.c: Sort headers.
6566 * alpha-tdep.c: Sort headers.
6567 * alpha-obsd-tdep.c: Sort headers.
6568 * alpha-nbsd-tdep.c: Sort headers.
6569 * alpha-mdebug-tdep.c: Sort headers.
6570 * alpha-linux-tdep.c: Sort headers.
6571 * alpha-linux-nat.c: Sort headers.
6572 * alpha-bsd-tdep.c: Sort headers.
6573 * alpha-bsd-nat.c: Sort headers.
6574 * aix-thread.c: Sort headers.
6575 * agent.c: Sort headers.
6576 * addrmap.c: Sort headers.
6577 * ada-varobj.c: Sort headers.
6578 * ada-valprint.c: Sort headers.
6579 * ada-typeprint.c: Sort headers.
6580 * ada-tasks.c: Sort headers.
6581 * ada-lang.c: Sort headers.
6582 * aarch64-tdep.c: Sort headers.
6583 * aarch64-ravenscar-thread.c: Sort headers.
6584 * aarch64-newlib-tdep.c: Sort headers.
6585 * aarch64-linux-tdep.c: Sort headers.
6586 * aarch64-linux-nat.c: Sort headers.
6587 * aarch64-fbsd-tdep.c: Sort headers.
6588 * aarch64-fbsd-nat.c: Sort headers.
6589 * aarch32-linux-nat.c: Sort headers.
6591 2019-04-04 Tom Tromey <tom@tromey.com>
6593 * varobj.c (varobj_create): Update.
6594 * rust-exp.y (struct rust_parser) <update_innermost_block,
6595 lookup_symbol>: New methods.
6596 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6598 (rust_parser::rust_lookup_type)
6599 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6600 * printcmd.c (display_command, do_one_display): Update.
6601 * parser-defs.h (struct parser_state) <parser_state>: Add
6602 "tracker" parameter.
6603 (block_tracker): New member.
6604 (class innermost_block_tracker) <innermost_block_tracker>: Add
6606 <reset>: Remove method.
6607 (innermost_block): Don't declare.
6608 (null_post_parser): Update.
6609 * parse.c (innermost_block): Remove global.
6610 (write_dollar_variable): Update.
6611 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6612 Remove "tracker_types" parameter.
6613 (parse_expression): Add "tracker" parameter.
6614 (parse_expression_for_completion): Update.
6615 (null_post_parser): Add "tracker" parameter.
6616 * p-exp.y: Update rules.
6617 * m2-exp.y: Update rules.
6618 * language.h (struct language_defn) <la_post_parser>: Add
6619 "tracker" parameter.
6620 * go-exp.y: Update rules.
6621 * f-exp.y: Update rules.
6622 * expression.h (parse_expression, parse_exp_1): Add "tracker"
6624 * d-exp.y: Update rules.
6625 * c-exp.y: Update rules.
6626 * breakpoint.c (set_breakpoint_condition): Create an
6627 innermost_block_tracker.
6628 (watch_command_1): Likewise.
6629 * ada-lang.c (resolve): Add "tracker" parameter.
6630 (resolve_subexp): Likewise.
6631 * ada-exp.y (write_var_from_sym): Update.
6633 2019-04-04 Tom Tromey <tom@tromey.com>
6635 * type-stack.h: New file.
6636 * type-stack.c: New file.
6637 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6639 (insert_into_type_stack, insert_type, push_type, push_type_int)
6640 (insert_type_address_space, pop_type, pop_type_int)
6641 (pop_typelist, pop_type_stack, append_type_stack)
6642 (push_type_stack, get_type_stack, push_typelist)
6643 (follow_type_instance_flags, follow_types): Don't declare.
6644 * parse.c (type_stack): Remove global.
6645 (parse_exp_in_context): Update.
6646 (insert_into_type_stack, insert_type, push_type, push_type_int)
6647 (insert_type_address_space, pop_type, pop_type_int)
6648 (pop_typelist, pop_type_stack, append_type_stack)
6649 (push_type_stack, get_type_stack, push_typelist)
6650 (follow_type_instance_flags, follow_types): Remove (moved to
6652 * f-exp.y (type_stack): New global.
6654 (push_kind_type, f_parse): Update.
6655 * d-exp.y (type_stack): New global.
6658 * c-exp.y (struct c_parse_state) <type_stack>: New member.
6660 * Makefile.in (COMMON_SFILES): Add type-stack.c.
6661 (HFILES_NO_SRCDIR): Add type-stack.h.
6663 2019-04-04 Tom Tromey <tom@tromey.com>
6665 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6666 (rust_parser::convert_ast_to_expression, rust_parse)
6667 (rust_lex_test_completion, rust_lex_tests): Update.
6668 * parser-defs.h (struct expr_completion_state): New.
6669 (struct parser_state) <parser_state>: Add completion parameter.
6670 <mark_struct_expression, mark_completion_tag>: New methods.
6671 <parse_completion, m_completion_state>: New members.
6672 (prefixify_expression, null_post_parser): Update.
6673 (mark_struct_expression, mark_completion_tag): Don't declare.
6674 * parse.c (parse_completion, expout_last_struct)
6675 (expout_tag_completion_type, expout_completion_name): Remove
6677 (parser_state::mark_struct_expression)
6678 (parser_state::mark_completion_tag): Now methods.
6679 (prefixify_expression): Add last_struct parameter.
6680 (prefixify_subexp): Likewise.
6681 (parse_exp_1): Update.
6682 (parse_exp_in_context): Add cstate parameter. Update.
6683 (parse_expression_for_completion): Create an
6684 expr_completion_state.
6685 (null_post_parser): Add "completion" parameter.
6686 * p-exp.y: Update rules.
6688 * language.h (struct language_defn) <la_post_parser>: Add
6689 "completing" parameter.
6690 * go-exp.y: Update rules.
6691 (lex_one_token): Update.
6692 * expression.h (parse_completion): Don't declare.
6693 * d-exp.y: Update rules.
6694 (lex_one_token): Update rules.
6695 * c-exp.y: Update rules.
6696 (lex_one_token): Update.
6697 * ada-lang.c (resolve): Add "parse_completion" parameter.
6698 (resolve_subexp): Likewise.
6699 (ada_resolve_function): Likewise.
6701 2019-04-04 Tom Tromey <tom@tromey.com>
6703 * parser-defs.h (struct parser_state) <start_arglist,
6704 end_arglist>: New methods.
6705 <arglist_len, m_funcall_chain>: New members.
6706 (arglist_len, start_arglist, end_arglist): Don't declare.
6707 * parse.c (arglist_len, funcall_chain): Remove global.
6708 (start_arglist, end_arglist): Remove functions.
6709 (parse_exp_in_context): Update.
6710 * p-exp.y: Update rules.
6711 * m2-exp.y: Update rules.
6712 * go-exp.y: Update rules.
6713 * f-exp.y: Update rules.
6714 * d-exp.y: Update rules.
6715 * c-exp.y: Update rules.
6717 2019-04-04 Tom Tromey <tom@tromey.com>
6719 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6720 lex_operator, push_back>: New methods.
6722 (rust_parser::lex_hex, lex_escape): Rename and update.
6723 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6724 (rust_parser::lex_operator): Rename and update.
6725 (rust_parser::lex_number, rustyylex, rustyyerror)
6726 (rust_lex_test_init, rust_lex_test_sequence)
6727 (rust_lex_test_push_back, rust_lex_tests): Update.
6728 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6730 <lexptr, prev_lexptr>: New members.
6731 (lexptr, prev_lexptr): Don't declare.
6732 * parse.c (lexptr, prev_lexptr): Remove globals.
6733 (parse_exp_in_context): Update.
6734 * p-exp.y (yylex, yyerror): Update.
6735 * m2-exp.y (parse_number, yylex, yyerror): Update.
6736 * go-exp.y (lex_one_token, yyerror): Update.
6737 * f-exp.y (match_string_literal, yylex, yyerror): Update.
6738 * d-exp.y (lex_one_token, yyerror): Update.
6739 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6740 (lex_one_token, yyerror): Update.
6741 * ada-lex.l (YY_INPUT): Update.
6742 (rewind_to_char): Update.
6743 * ada-exp.y (yyerror): Update.
6745 2019-04-04 Tom Tromey <tom@tromey.com>
6747 * rust-exp.y (rustyylex, rust_lex_tests): Update.
6748 * parser-defs.h (struct parser_state) <parser_state>: Add new
6750 <comma_terminates>: New member.
6751 (comma_terminates): Don't declare global.
6752 * parse.c (comma_terminates): Remove global.
6753 (parse_exp_in_context): Update.
6754 * p-exp.y (yylex): Update.
6755 * m2-exp.y (yylex): Update.
6756 * go-exp.y (lex_one_token): Update.
6757 * f-exp.y (yylex): Update.
6758 * d-exp.y (lex_one_token): Update.
6759 * c-exp.y (lex_one_token): Update.
6760 * ada-lex.l: Update.
6762 2019-04-04 Tom Tromey <tom@tromey.com>
6764 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6765 (rustyylex, rust_lex_test_init, rust_lex_test_one)
6766 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6767 * parser-defs.h (paren_depth): Don't declare.
6768 * parse.c (paren_depth): Remove global.
6769 (parse_exp_in_context): Update.
6770 * p-exp.y (paren_depth): New global.
6771 (pascal_parse): Initialize it.
6772 * m2-exp.y (paren_depth): New global.
6773 (m2_parse): Initialize it.
6774 * go-exp.y (paren_depth): New global.
6775 (go_parse): Initialize it.
6776 * f-exp.y (paren_depth): New global.
6777 (f_parse): Initialize it.
6778 * d-exp.y (paren_depth): New global.
6779 (d_parse): Initialize it.
6780 * c-exp.y (paren_depth): New global.
6781 (c_parse): Initialize it.
6782 * ada-lex.l (paren_depth): New global.
6783 (lexer_init): Initialize it.
6785 2019-04-04 Tom Tromey <tom@tromey.com>
6787 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6788 (rust_parser::convert_ast_to_type)
6789 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6790 * parser-defs.h (struct parser_state) <parser_state>: Add
6791 parameters. Initialize new members.
6792 <expression_context_block, expression_context_pc>: New members.
6793 * parse.c (expression_context_block, expression_context_pc):
6795 (parse_exp_in_context): Update.
6796 * p-exp.y: Update all rules.
6798 * m2-exp.y: Update all rules.
6800 * go-exp.y (yylex): Update.
6801 * f-exp.y (yylex): Update.
6802 * d-exp.y: Update all rules.
6804 * c-exp.y: Update all rules.
6805 (lex_one_token, classify_name, yylex, c_parse): Update.
6806 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6808 2019-04-04 Tom Tromey <tom@tromey.com>
6810 * gdbarch.h, gdbarch.c: Rebuild.
6811 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6813 (struct stap_parse_info): Replace "parser_state" with
6815 * parser-defs.h (struct expr_builder): Rename from "parser_state".
6816 (parser_state): New class.
6817 * parse.c (expr_builder): Rename.
6818 (expr_builder::release): Rename.
6819 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6820 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6821 (write_exp_elt_longcst, write_exp_elt_floatcst)
6822 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6823 (write_exp_string_vector, write_exp_bitstring)
6824 (write_exp_msymbol, mark_struct_expression)
6825 (write_dollar_variable)
6826 (insert_type_address_space, increase_expout_size): Replace
6827 "parser_state" with "expr_builder".
6828 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6829 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6830 "parser_state" with "expr_builder".
6832 2019-04-04 Tom Tromey <tom@tromey.com>
6834 * rust-exp.y: Replace "parse_language" with method call.
6836 (yylex): Replace "parse_language" with method call.
6838 (yylex): Replace "parse_language" with method call.
6839 * go-exp.y (classify_name): Replace "parse_language" with method
6841 * f-exp.y (yylex): Replace "parse_language" with method call.
6842 * d-exp.y (lex_one_token): Replace "parse_language" with method
6845 (lex_one_token, classify_name, yylex): Replace "parse_language"
6847 * ada-exp.y (find_primitive_type, type_char)
6848 (type_system_address): Replace "parse_language" with method call.
6850 2019-04-04 Tom Tromey <tom@tromey.com>
6852 * rust-exp.y: Replace "parse_gdbarch" with method call.
6853 * parse.c (write_dollar_variable, insert_type_address_space):
6854 Replace "parse_gdbarch" with method call.
6855 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6857 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6859 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6860 "parse_gdbarch" with method call.
6861 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6863 * f-exp.y (parse_type, parse_f_type, yylex): Replace
6864 "parse_gdbarch" with method call.
6865 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6866 "parse_gdbarch" with method call.
6867 * c-exp.y (parse_type, parse_number, classify_name): Replace
6868 "parse_gdbarch" with method call.
6869 * ada-lex.l: Replace "parse_gdbarch" with method call.
6870 * ada-exp.y (parse_type, find_primitive_type, type_char)
6871 (type_system_address): Replace "parse_gdbarch" with method call.
6873 2019-04-04 Tom Tromey <tom@tromey.com>
6875 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6876 * stap-probe.c (stap_parse_argument): Update.
6877 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6878 initial_size parameter.
6879 * rust-exp.y (rust_lex_tests): Update.
6880 * parse.c (parser_state): Update.
6881 (parse_exp_in_context): Update.
6882 * parser-defs.h (struct parser_state) <parser_state>: Remove
6883 "initial_size" parameter.
6885 2019-04-04 Tom Tromey <tom@tromey.com>
6887 * parser-defs.h (increase_expout_size): Don't declare.
6888 * parse.c (increase_expout_size): Now static.
6890 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
6892 * gnu-nat.c (gnu_nat_target::wait): Fix
6893 target_waitstatus_to_string call.
6895 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6897 * eval.c (evaluate_subexp_standard): Handle internal functions
6898 during Fortran function call handling.
6900 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6902 * NEWS: Mention new internal functions.
6903 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6904 (read_base_type): Use dwarf2_init_complex_target_type.
6905 * value.c (creal_internal_fn): New function.
6906 (cimag_internal_fn): New function.
6907 (_initialize_values): Register new internal functions.
6909 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6911 * infrun.c (stop_all_threads): If debug_infrun, always
6912 trace the wait status after wait_one, using
6913 target_waitstatus_to_string and target_pid_to_str.
6914 (handle_inferior_event): Replace various trace of
6915 wait status kind by a single trace.
6916 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6917 wait status kind image by target_waitstatus_to_string.
6918 * target/waitstatus.c (target_waitstatus_to_string): Fix
6921 2019-04-01 Tom Tromey <tromey@adacore.com>
6924 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6926 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
6927 Pedro Alves <palves@redhat.com>
6929 * top.c (quit_force): Call 'finalize_values'.
6930 * value.c (finalize_values): New function.
6931 * value.h (finalize_values): Declare.
6933 2019-03-30 Eli Zaretskii <eliz@gnu.org>
6935 * NEWS: Announce $_gdb_major and $_gdb_minor.
6937 * top.c (init_gdb_version_vars): New function.
6938 (gdb_init): Call init_gdb_version_vars.
6940 2019-03-29 Tom Tromey <tromey@adacore.com>
6942 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
6943 help text. Remove dead code.
6945 2019-03-29 Keith Seitz <keiths@redhat.com>
6947 From Siddhesh Poyarekar:
6948 * f-lang.h (f77_get_upperbound): Return LONGEST.
6949 (f77_get_lowerbound): Likewise.
6950 * f-typeprint.c (f_type_print_varspec_suffix): Expand
6951 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
6953 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
6954 plongest to format print it.
6955 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6956 (f77_get_upperbound): Likewise.
6957 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6958 LOWER_BOUND to LONGEST.
6959 (f77_create_arrayprint_offset_tbl): Likewise.
6961 2019-03-29 Keith Seitz <keiths@redhat.com>
6963 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6964 %s/pulongest for TYPE_LENGTH instead of %d in format
6966 * ada-typerint.c (ada_print_type): Likewise.
6967 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6968 * compile/compile-c-support.c (generate_register_struct): Likewise.
6969 * gdbtypes.c (recursive_dump_type): Likewise.
6970 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6971 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
6972 instead of %d in format strings.
6973 * riscv-tdep.c (riscv_type_alignment): Cast second argument
6974 to std::min to ULONGEST.
6975 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6976 instead of %d in format strings.
6977 * tracepoint.c (info_scope_command): Likewise.
6978 * typeprint.c (print_offset_data::update)
6979 (print_offset_data::finish): Likewise.
6980 * xtensa-tdep.c (xtensa_store_return_value)
6981 (xtensa_push_dummy_call): Likewise.
6983 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
6985 * windows-nat.c (display_selector): Fixed format specifications
6988 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6990 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6992 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
6994 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6995 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6996 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6997 (nios2_linux_init_abi): Install it.
6999 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7001 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7003 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7005 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7007 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7008 Tom Tromey <tromey@adacore.com>
7010 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7012 2019-03-26 Joel Brobecker <brobecker@adacore.com>
7014 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7015 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7016 method to compute the bounds of range types. Also print "[evaluated]"
7017 if the bounds' values come from a dynamic evaluation.
7019 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7021 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7022 whitespace when pretty printing is on.
7024 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7026 * ppc-linux-nat.c: Add include.
7028 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7030 * NEWS: Mention AArch64 Pointer Authentication.
7032 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7034 * arm-linux-nat.c: Add include.
7036 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7038 * source-cache.c (source_cache::get_source_lines): Re-read
7039 fullname after calling open_source_file.
7041 2019-03-25 John Baldwin <jhb@FreeBSD.org>
7043 * NEWS: Mention TLS support for FreeBSD.
7045 2019-03-25 Tom Tromey <tromey@adacore.com>
7047 * minsyms.c (BUNCH_SIZE): Update comment.
7048 (~minimal_symbol_reader): Remove old comment.
7049 (compact_minimal_symbols): Update comment.
7050 (minimal_symbol_reader::install): Remove old comment. Update
7053 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7055 * s390-linux-nat.c: Add include.
7057 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7059 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7060 Call linux_get_hwcap.
7061 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7063 (aarch64_linux_get_hwcap): Remove function.
7064 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7066 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7068 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7069 * linux-tdep.c (linux_get_hwcap): Add function.
7070 (linux_get_hwcap2): Likewise.
7071 * linux-tdep.h (linux_get_hwcap): Add declaration.
7072 (linux_get_hwcap2): Likewise.
7073 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7074 (ppc_linux_get_hwcap2): Likewise.
7075 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7077 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7078 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7079 (ppc_linux_nat_target::read_description): Likewise.
7080 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7081 * s390-linux-nat.c: Likewise.
7082 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7084 2019-03-24 Tom Tromey <tom@tromey.com>
7086 * ada-lang.c (standard_lookup): Simplify initialization.
7087 (ada_lookup_symbol_nonlocal): Simplify return.
7088 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7089 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7090 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7091 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7093 * solib.c (solib_global_lookup): Simplify.
7094 * symtab.c (null_block_symbol): Remove.
7095 (symbol_cache_lookup): Simplify returns.
7096 (lookup_language_this): Simplify returns.
7097 (lookup_symbol_aux): Simplify return.
7098 (lookup_local_symbol): Simplify returns.
7099 (lookup_global_symbol_from_objfile): Simplify return.
7100 (lookup_symbol_in_objfile_symtabs)
7101 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7102 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7103 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7104 * cp-namespace.c (cp_lookup_bare_symbol)
7105 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7106 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7107 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7108 (cp_lookup_symbol_via_imports): Simplify initialization.
7109 (find_symbol_in_baseclass): Likewise.
7110 * symtab.h (null_block_symbol): Remove.
7111 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7112 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7113 (d_lookup_symbol_module): Likewise.
7114 (find_symbol_in_baseclass): Simplify initialization.
7116 2019-03-24 Tom Tromey <tom@tromey.com>
7118 * expression.h: Don't include symtab.h.
7119 (struct block): Forward declare.
7121 2019-03-24 Tom Tromey <tom@tromey.com>
7123 * c-exp.y (typebase): Remove casts.
7124 * gdbtypes.c (lookup_unsigned_typename, )
7125 (lookup_signed_typename): Remove cast.
7126 * eval.c (parse_to_comma_and_eval): Remove cast.
7127 * parse.c (write_dollar_variable): Remove cast.
7128 * block.h (struct block) <superblock>: Now const.
7129 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7130 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7131 (map_block): Make "block" const.
7132 * symfile.h (struct quick_symbol_functions)
7133 <map_matching_symbols>: Constify block argument to "callback".
7134 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7136 (find_pc_sect_compunit_symtab): Make "b" const.
7137 (find_symbol_at_address): Likewise.
7138 (search_symbols): Likewise.
7139 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7140 (dw2_debug_names_lookup_symbol): Likewise.
7141 (dw2_map_matching_symbols): Update.
7142 * p-valprint.c (pascal_val_print): Remove "block".
7143 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7144 (aux_add_nonlocal_symbols): Make "block" const.
7145 (resolve_subexp): Remove cast.
7146 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7148 (iterate_over_file_blocks): Likewise.
7149 * f-exp.y (%union) <bval>: Remove.
7150 * coffread.c (patch_opaque_types): Make "b" const.
7151 * spu-tdep.c (spu_catch_start): Make "block" const.
7152 * c-valprint.c (print_unpacked_pointer): Remove "block".
7153 * symmisc.c (dump_symtab_1): Make "b" const.
7154 (block_depth): Make "block" const.
7155 * d-exp.y (%union) <bval>: Remove.
7156 * cp-support.h (cp_lookup_rtti_type): Update.
7157 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7158 * psymtab.c (psym_lookup_symbol): Make "block" const.
7159 (maintenance_check_psymtabs): Make "b" const.
7160 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7161 (enumerate_locals, enumerate_args): Update.
7162 * python/py-symtab.c (stpy_global_block): Make "block" const.
7163 (stpy_static_block): Likewise.
7164 * inline-frame.c (block_starting_point_at): Make "new_block"
7166 * block.c (find_block_in_blockvector): Make return type const.
7167 (blockvector_for_pc_sect): Make "b" const.
7168 (find_block_in_blockvector): Make "b" const.
7170 2019-03-23 Tom Tromey <tom@tromey.com>
7172 * varobj.c (varobj_create): Update.
7173 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7174 * printcmd.c (display_command, do_one_display): Don't reset
7176 * parser-defs.h (enum innermost_block_tracker_type): Move to
7178 (innermost_block): Update comment.
7179 * parse.c (parse_exp_1): Add tracker_types parameter.
7180 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7181 tracker_types parameter. Reset innermost_block.
7182 (parse_exp_in_context): Remove.
7183 (parse_expression_for_completion): Update.
7184 * objfiles.c (~objfile): Don't reset expression_context_block or
7186 * expression.h (enum innermost_block_tracker_type): Move from
7188 (parse_exp_1): Add tracker_types parameter.
7189 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7190 reset innermost_block.
7192 2019-03-23 Tom Tromey <tom@tromey.com>
7194 * objfiles.h: Include bcache.h.
7196 2019-03-23 Tom Tromey <tom@tromey.com>
7198 * linespec.c (get_current_search_block): Use
7199 scoped_restore_current_language.
7200 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7202 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7203 Jiong Wang <jiong.wang@arm.com>
7205 * aarch64-linux-tdep.c
7206 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7208 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7210 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7211 Jiong Wang <jiong.wang@arm.com>
7213 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7215 (aarch64_analyze_prologue_test): Add PACIASP test.
7216 (aarch64_prologue_prev_register): Unmask PC value.
7218 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7219 Jiong Wang <jiong.wang@arm.com>
7221 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7222 (aarch64_dwarf2_prev_register): Unmask PC value.
7223 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7224 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7225 DW_CFA_AARCH64_negate_ra_state.
7226 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7228 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7229 Jiong Wang <jiong.wang@arm.com>
7231 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7233 (aarch64_pseudo_register_name): Likewise.
7234 (aarch64_pseudo_register_type): Likewise.
7235 (aarch64_pseudo_register_reggroup_p): Likewise.
7236 (aarch64_gdbarch_init): Add pauth registers.
7237 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7238 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7239 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7240 (struct gdbarch_tdep): Add regnum for ra_state.
7242 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7243 Jiong Wang <jiong.wang@arm.com>
7245 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7247 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7248 Jiong Wang <jiong.wang@arm.com>
7250 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7252 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7253 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7254 (aarch64_gdbarch_init): Add puth registers.
7255 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7256 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7257 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7259 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7260 Jiong Wang <jiong.wang@arm.com>
7262 * aarch64-linux-nat.c
7263 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7264 * aarch64-linux-tdep.c
7265 (aarch64_linux_core_read_description): Likewise.
7266 (aarch64_linux_get_hwcap): New function.
7267 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7268 (aarch64_linux_get_hwcap): New declaration.
7270 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7271 Jiong Wang <jiong.wang@arm.com>
7273 * aarch64-linux-nat.c
7274 (aarch64_linux_nat_target::read_description): Add pauth param.
7275 * aarch64-linux-tdep.c
7276 (aarch64_linux_core_read_description): Likewise.
7277 * aarch64-tdep.c (struct target_desc): Add in pauth.
7278 (aarch64_read_description): Add pauth param.
7279 (aarch64_gdbarch_init): Likewise.
7280 * aarch64-tdep.h (aarch64_read_description): Likewise.
7281 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7282 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7283 * features/Makefile: Add new files.
7284 * features/aarch64-pauth.c: New file.
7285 * features/aarch64-pauth.xml: New file.
7287 2019-03-20 Tom Tromey <tromey@adacore.com>
7289 * infrun.c (handle_inferior_event): Rename from
7290 handle_inferior_event_1. Create a scoped_value_mark.
7291 (handle_inferior_event): Remove.
7293 2019-03-19 Tom Tromey <tromey@adacore.com>
7295 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7296 * infrun.h (print_stop_event): Add "displays" parameter.
7297 * infrun.c (print_stop_event): Add "displays" parameter.
7299 2019-03-19 Pedro Alves <palves@redhat.com>
7301 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7302 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7303 to -1. Fix TABs vs spaces.
7304 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7305 * tui/tui-out.h (tui_ui_out) Add intro comments.
7306 <m_line, m_start_of_line>: In-class initialize, and add describing
7309 2019-03-18 Alan Hayward <alan.hayward@arm.com>
7311 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7313 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7315 2019-03-18 Pedro Alves <palves@redhat.com>
7316 Eli Zaretskii <eliz@gnu.org>
7318 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7319 m_line and m_start_of_line.
7321 2019-03-18 Eli Zaretskii <eliz@gnu.org>
7323 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7324 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7325 it returns a newline. This fixes a regression in TU mode, whereby
7326 the next line is output on the same screen line as the user input.
7328 2019-03-18 Tom Tromey <tromey@adacore.com>
7330 * minsyms.c (minimal_symbol_reader::install): Remove call to
7333 2019-03-18 Pedro Alves <palves@redhat.com>
7335 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7337 (apply_style): New, factored out from ...
7338 (apply_ansi_escape): ... this. Handle reverse video mode.
7339 (tui_set_reverse_mode): New function.
7340 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7341 * tui/tui-winsource.c (tui_show_source_line): Use
7342 tui_set_reverse_mode instead of setting A_STANDOUT.
7343 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7346 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
7348 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7351 2019-03-18 Tom Tromey <tromey@adacore.com>
7353 * ada-lang.c (empty_array): Add "high" parameter.
7354 (ada_evaluate_subexp): Update.
7356 2019-03-17 Sergei Trofimovich <siarheit@google.com>
7358 * unittests/string_view-selftests.c: Define
7359 _initialize_string_view_selftests unconditionally.
7361 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7364 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7366 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7369 * windows-nat.c (display_selector): Fix format specifiers.
7371 2019-03-17 Eli Zaretskii <eliz@gnu.org>
7373 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7374 tui_refill_source_window instead of tui_refresh_win, to update the
7375 current execution line. This fixes redisplay of the current line
7376 when stepping through the code with "next" or "step".
7378 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7380 * source-cache.c (source_cache::get_source_lines): Call
7381 find_source_lines to initialize s->nlines. This fixes vertical
7382 scrolling of TUI source window when the DOWN arrow is pressed.
7384 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7386 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7387 linux-thread-db.c (_initialize_thread_db): Likewise.
7389 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7391 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7392 wclrtoeol in tui_show_source_line". This reverts changes made in
7393 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7395 2019-03-15 Tom Tromey <tom@tromey.com>
7397 * symtab.h (struct minimal_symbol): Derive from
7398 general_symbol_info.
7399 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7400 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7401 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7402 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7403 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7404 (MSYMBOL_SEARCH_NAME): Update.
7405 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7406 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7407 * minsyms.c (minimal_symbol_reader::record_full): Update.
7409 2019-03-15 Tom Tromey <tom@tromey.com>
7411 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7413 2019-03-15 Tom Tromey <tom@tromey.com>
7415 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7417 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7419 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7420 (build_minimal_symbol_hash_tables)
7421 (minimal_symbol_reader::install): Update.
7423 2019-03-15 Tom Tromey <tom@tromey.com>
7425 * symtab.c (create_demangled_names_hash): Update.
7426 (symbol_set_names): Update.
7427 * objfiles.h (struct objfile_per_bfd_storage)
7428 <demangled_names_hash>: Now an htab_up.
7429 * objfiles.c (objfile_per_bfd_storage): Simplify.
7431 2019-03-15 Tom Tromey <tom@tromey.com>
7433 * objfiles.h (struct objfile_per_bfd_storage): Declare
7435 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7437 (get_objfile_bfd_data): Use new. Don't initialize
7439 (free_objfile_per_bfd_storage): Remove.
7440 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7442 2019-03-15 Tom Tromey <tom@tromey.com>
7444 * symfile.c (reread_symbols): Update.
7445 * objfiles.c (objfile::objfile): Update.
7446 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7447 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7449 (minimal_symbol_reader::install): Update.
7450 (terminate_minimal_symbol_table): Remove.
7451 * jit.c (jit_object_close_impl): Update.
7453 2019-03-15 Tom Tromey <tom@tromey.com>
7455 * minsyms.c (minimal_symbol_reader::record_full): Remove some
7458 2019-03-15 Tom Tromey <tom@tromey.com>
7460 * objfiles.h (struct objfile_per_bfd_storage)
7461 <demangled_hash_languages>: Now a bitset.
7462 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7463 (lookup_minimal_symbol): Update.
7465 2019-03-15 Tom Tromey <tom@tromey.com>
7467 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7468 Don't return the symbol.
7469 * coffread.c (record_minimal_symbol): Use record_full.
7471 2019-03-14 Eli Zaretskii <eliz@gnu.org>
7473 The MS-Windows port of ncurses fails to switch to a color pair if
7474 one or both of the colors are the implicit default colors. This
7475 change records the default colors when TUI is initialized, and
7476 then specifies them explicitly when a color pair uses the default
7477 colors. This allows color styling in TUI mode on MS-Windows.
7479 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
7481 (tui_initialize_io) [__MINGW32__]: Record the default terminal
7482 colors in ncurses_norm_attr.
7483 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7484 "none", replace it with the default color recorded in
7487 2019-03-14 Tom Tromey <tromey@adacore.com>
7489 * source-cache.h (class source_cache) <get_source_lines>: Return
7491 * source-cache.c (source_cache::extract_lines): Handle case where
7492 first_pos==npos. Return std::string.
7493 (source_cache::get_source_lines): Update.
7495 2019-03-14 Tom Tromey <tromey@adacore.com>
7497 * NEWS: Add item for "style sources" commands.
7498 * source-cache.c (source_cache::get_source_lines): Check
7500 * cli/cli-style.c (source_styling): New global.
7501 (_initialize_cli_style): Add "style sources" commands.
7502 (show_style_sources): New function.
7503 * cli/cli-style.h (source_styling): Declare.
7505 2019-03-14 Pedro Alves <palves@redhat.com>
7506 Tom Tromey <tromey@adacore.com>
7508 * tui/tui-winsource.h (tui_refill_source_window): Declare.
7509 * tui/tui-winsource.c (tui_refill_source_window): New function,
7511 (tui_horizontal_source_scroll): ... here. Move some logic.
7512 * cli/cli-style.c (set_style_enabled): Notify new observable.
7513 * tui/tui-hooks.c (tui_redisplay_source): New function.
7514 (tui_attach_detach_observers): Attach or detach
7515 tui_redisplay_source.
7516 * observable.h (source_styling_changed): New observable.
7517 * observable.c: Define source_styling_changed observable.
7519 2019-03-13 Tom Tromey <tromey@adacore.com>
7521 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7522 (i386_gnu_nat_target::store_registers): Update.
7523 * target-debug.h (target_debug_print_std_string): New macro.
7524 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7525 * windows-tdep.c (display_one_tib): Update.
7526 * tui/tui-stack.c (tui_make_status_line): Update.
7527 * top.c (print_inferior_quit_action): Update.
7528 * thread.c (thr_try_catch_cmd): Update.
7529 (add_thread_with_info): Update.
7530 (thread_target_id_str): Update.
7531 (thr_try_catch_cmd): Update.
7532 (thread_command): Update.
7533 (thread_find_command): Update.
7534 * record-btrace.c (record_btrace_target::info_record)
7535 (record_btrace_resume_thread, record_btrace_target::resume)
7536 (record_btrace_cancel_resume, record_btrace_step_thread)
7537 (record_btrace_target::wait, record_btrace_target::wait)
7538 (record_btrace_target::wait, record_btrace_target::stop): Update.
7539 * progspace.c (print_program_space): Update.
7540 * process-stratum-target.c
7541 (process_stratum_target::thread_address_space): Update.
7542 * linux-fork.c (linux_fork_mourn_inferior)
7543 (detach_checkpoint_command, info_checkpoints_command)
7544 (linux_fork_context): Update.
7545 (linux_fork_detach): Update.
7546 (class scoped_switch_fork_info): Update.
7547 (delete_checkpoint_command): Update.
7548 * infrun.c (follow_fork_inferior): Update.
7549 (follow_fork_inferior): Update.
7550 (proceed_after_vfork_done): Update.
7551 (handle_vfork_child_exec_or_exit): Update.
7552 (follow_exec): Update.
7553 (displaced_step_prepare_throw): Update.
7554 (displaced_step_restore): Update.
7555 (start_step_over): Update.
7557 (clear_proceed_status_thread): Update.
7559 (print_target_wait_results): Update.
7560 (do_target_wait): Update.
7561 (context_switch): Update.
7562 (stop_all_threads): Update.
7563 (restart_threads): Update.
7564 (finish_step_over): Update.
7565 (handle_signal_stop): Update.
7566 (switch_back_to_stepped_thread): Update.
7567 (keep_going_pass_signal): Update.
7568 (print_exited_reason): Update.
7569 (normal_stop): Update.
7570 * inferior.c (inferior_pid_to_str): Change return type.
7571 (print_selected_inferior): Update.
7572 (add_inferior): Update.
7573 (detach_inferior): Update.
7574 * dummy-frame.c (fprint_dummy_frames): Update.
7575 * dcache.c (dcache_info_1): Update.
7576 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7577 (btrace_fetch, btrace_clear): Update.
7578 * linux-tdep.c (linux_core_pid_to_str): Change return type.
7579 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7581 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7582 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7583 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7584 * gdbarch.c, gdbarch.h: Rebuild.
7585 * gdbarch.sh (core_pid_to_str): Change return type.
7586 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7588 (windows_nat_target::pid_to_str): Change return type.
7589 (windows_delete_thread): Update.
7590 (windows_nat_target::attach): Update.
7591 (windows_nat_target::files_info): Update.
7592 * target-delegates.c: Rebuild.
7593 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7595 (sol_thread_target::pid_to_str): Change return type.
7596 * remote.c (class remote_target) <pid_to_str>: Change return
7598 (remote_target::pid_to_str): Change return type.
7599 (extended_remote_target::attach, remote_target::remote_stop_ns)
7600 (remote_target::remote_notif_remove_queued_reply)
7601 (remote_target::push_stop_reply, remote_target::disable_btrace):
7603 (extended_remote_target::attach): Update.
7604 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7606 (gdbsim_target::pid_to_str): Change return type.
7607 * ravenscar-thread.c (struct ravenscar_thread_target)
7608 <pid_to_str>: Change return type.
7609 (ravenscar_thread_target::pid_to_str): Change return type.
7610 * procfs.c (class procfs_target) <pid_to_str>: Change return
7612 (procfs_target::pid_to_str): Change return type.
7613 (procfs_target::attach): Update.
7614 (procfs_target::detach): Update.
7615 (procfs_target::fetch_registers): Update.
7616 (procfs_target::store_registers): Update.
7617 (procfs_target::wait): Update.
7618 (procfs_target::files_info): Update.
7619 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7620 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7622 (nto_procfs_target::pid_to_str): Change return type.
7623 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7624 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7626 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7628 (attach_proc_task_lwp_callback, get_detach_signal)
7629 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7630 (linux_nat_target::resume, wait_lwp, stop_callback)
7631 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7632 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7633 (linux_nat_wait_1, resume_stopped_resumed_lwps)
7634 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7635 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7637 (inf_ptrace_target::attach): Update.
7638 (inf_ptrace_target::files_info): Update.
7639 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7641 (go32_nat_target::pid_to_str): Change return type.
7642 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7643 (gnu_nat_target::wait): Update.
7644 (gnu_nat_target::wait): Update.
7645 (gnu_nat_target::resume): Update.
7646 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7647 (fbsd_nat_target::wait): Update.
7648 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7650 (darwin_nat_target::attach): Update.
7651 * corelow.c (class core_target) <pid_to_str>: Change return type.
7652 (core_target::pid_to_str): Change return type.
7653 * target.c (normal_pid_to_str): Change return type.
7654 (default_pid_to_str): Likewise.
7655 (target_pid_to_str): Change return type.
7656 (target_translate_tls_address): Update.
7657 (target_announce_detach): Update.
7658 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7660 (bsd_uthread_target::pid_to_str): Change return type.
7661 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7663 (bsd_kvm_target::pid_to_str): Change return type.
7664 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7666 (aix_thread_target::pid_to_str): Change return type.
7667 * target.h (struct target_ops) <pid_to_str>: Change return type.
7668 (target_pid_to_str, normal_pid_to_str): Likewise.
7669 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7671 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7673 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7675 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7677 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7679 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7682 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
7684 * NEWS: Mention that the new default MI version is 3. Mention
7685 changes to the output of commands and events that deal with
7686 multi-location breakpoints.
7687 * breakpoint.c: Include "mi/mi-out.h".
7688 (print_one_breakpoint): Change output syntax if using MI version
7690 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7692 (mi_multi_location_breakpoint_output_fixed): New.
7693 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7694 (mi_cmd_fix_multi_location_breakpoint_output): New.
7695 (mi_multi_location_breakpoint_output_fixed): New.
7696 * mi/mi-cmds.c (mi_cmds): Register command
7697 -fix-multi-location-breakpoint-output.
7698 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7701 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
7703 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7704 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7705 instantiate mi_ui_out based on interpreter name.
7706 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7707 * mi/mi-main.c (mi_load_progress): Likewise.
7709 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7711 * NEWS: Combine separate "New targets" sections for 8.3.
7713 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7715 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7716 (ppcfbsd_init_abi): Install gdbarch
7717 "fetch_tls_load_module_address" and "get_thread_local_address"
7720 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7722 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7723 (riscv_fbsd_init_abi): Install gdbarch
7724 "fetch_tls_load_module_address" and "get_thread_local_address"
7727 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7729 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7730 (i386fbsd_init_abi): Install gdbarch
7731 "fetch_tls_load_module_address" and "get_thread_local_address"
7734 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7736 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7737 (amd64fbsd_init_abi): Install gdbarch
7738 "fetch_tls_load_module_address" and "get_thread_local_address"
7741 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7743 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7744 (struct fbsd_pspace_data): New type.
7745 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7746 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7747 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7748 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7749 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7751 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7753 * gdbtypes.c (lookup_struct_elt): New function.
7754 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7755 * gdbtypes.h (struct struct_elt): New type.
7756 (lookup_struct_elt): New prototype.
7758 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7760 * gdbtypes.c (lookup_struct_elt_type): Update comment and
7761 remove disabled code block.
7763 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7765 * gdbarch.sh (get_thread_local_address): New method.
7766 * gdbarch.h, gdbarch.c: Regenerate.
7767 * target.c (target_translate_tls_address): Use
7768 gdbarch_get_thread_local_address if present instead of
7769 target::get_thread_local_address.
7771 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7773 * target.h (target::get_thread_local_address): Update comment.
7775 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7777 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7778 objfile->separate_debug_objfile_backlink if not NULL.
7780 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7782 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7783 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7784 (amd64bsd_store_inferior_registers): Likewise.
7785 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7786 Enable segment base registers.
7787 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7788 PT_GETFSBASE and PT_GETGSBASE.
7789 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7791 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7792 segment base registers.
7793 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7795 2019-03-12 John Baldwin <jhb@FreeBSD.org>
7797 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7798 Update calls to i386_target_description to add 'segments'
7800 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
7801 add segment base registers.
7802 * arch/i386.c (i386_create_target_description): Add 'segments'
7803 parameter to enable segment base registers.
7804 * arch/i386.h (i386_create_target_description): Likewise.
7805 * features/i386/32bit-segments.xml: New file.
7806 * features/i386/32bit-segments.c: Generate.
7807 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7808 call to i386_target_description to add 'segments' parameter.
7809 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7810 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7811 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7812 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7813 if feature is present.
7814 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7815 Add 'segments' parameter to call to i386_target_description.
7816 (i386_target_description): Add 'segments' parameter to enable
7817 segment base registers.
7818 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7819 to call to i386_target_description.
7820 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7821 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7822 Define I386_NUM_REGS.
7823 (i386_target_description): Add 'segments' parameter to enable
7824 segment base registers.
7826 2019-03-12 Eli Zaretskii <eliz@gnu.org>
7829 * source-cache.c: #undef open and close, to avoid unresolved
7830 externals during linking.
7832 2019-03-12 Tom Tromey <tromey@adacore.com>
7834 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7835 const. Add initializers.
7836 (_initialize_remote): Don't initialize ptid globals.
7838 2019-03-12 Pedro Alves <palves@redhat.com>
7840 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7842 2019-03-12 Pedro Alves <palves@redhat.com>
7844 * cp-name-parser.y (main): Remove unused 'len' variable.
7846 2019-03-12 Tom Tromey <tromey@adacore.com>
7848 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7849 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7851 2019-03-12 Tom Tromey <tromey@adacore.com>
7853 * linux-nat.c (iterate_over_lwps): Update.
7854 (stop_callback): Remove parameter.
7855 (stop_wait_callback, detach_callback, resume_set_callback)
7856 (select_singlestep_lwp_callback, set_ignore_sigint)
7857 (status_callback, resumed_callback, resume_clear_callback)
7858 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7860 (linux_nat_target::detach, linux_nat_target::resume)
7861 (linux_stop_and_wait_all_lwps, select_event_lwp)
7862 (linux_nat_filter_event, linux_nat_wait_1)
7863 (linux_nat_target::kill, linux_nat_target::stop)
7864 (linux_nat_target::stop): Update.
7865 (linux_nat_resume_callback): Change type.
7866 (resume_stopped_resumed_lwps, count_events_callback)
7867 (select_event_lwp_callback): Likewise.
7868 (linux_stop_lwp, linux_nat_stop_lwp): Update.
7869 * arm-linux-nat.c (struct update_registers_data): Remove.
7870 (update_registers_callback): Change type.
7871 (arm_linux_insert_hw_breakpoint1): Update.
7872 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7874 (x86_linux_dr_set_addr): Update.
7875 (x86_linux_dr_set_control): Update.
7876 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7877 (iterate_over_lwps): Use gdb::function_view.
7878 * nat/aarch64-linux-hw-point.c (struct
7879 aarch64_dr_update_callback_param): Remove.
7880 (debug_reg_change_callback): Change type.
7881 (aarch64_notify_debug_reg_change): Update.
7882 * s390-linux-nat.c (s390_refresh_per_info): Update.
7884 2019-03-11 Tom Tromey <tromey@adacore.com>
7886 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7887 redundant assignment to "this_cu".
7889 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7891 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7893 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7895 * gdbtypes.c (rank_one_type_parm_set): New function extracted
7897 (rank_one_type): ... this.
7899 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7901 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7903 (rank_one_type): ... this.
7905 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7907 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7909 (rank_one_type): ... this.
7911 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7913 * gdbtypes.c (rank_one_type_parm_float): New function extracted
7915 (rank_one_type): ... this.
7917 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7919 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7921 (rank_one_type): ... this.
7923 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7925 * gdbtypes.c (rank_one_type_parm_range): New function extracted
7927 (rank_one_type): ... this.
7929 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7931 * gdbtypes.c (rank_one_type_parm_char): New function extracted
7933 (rank_one_type): ... this.
7935 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7937 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7939 (rank_one_type): ... this.
7941 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7943 * gdbtypes.c (rank_one_type_parm_int): New function extracted
7945 (rank_one_type): ... this.
7947 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7949 * gdbtypes.c (rank_one_type_parm_func): New function extracted
7951 (rank_one_type): ... this.
7953 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7955 * gdbtypes.c (rank_one_type_parm_array): New function extracted
7957 (rank_one_type): ... this.
7959 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
7961 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7963 (rank_one_type): ... this.
7965 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7967 * inferior.c (initialize_inferiors): Ensure 'help set/show print
7968 inferior-events' shows the example events.
7970 2019-03-08 Eli Zaretskii <eliz@gnu.org>
7972 Support styling on native MS-Windows console
7975 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7976 on MS-Windows if $TERM is not defined.
7978 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7980 * posix-hdep.c (gdb_console_fputs):
7981 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7983 * ui-file.h (gdb_console_fputs): Add prototype.
7985 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7986 back to fputs only if the former returns zero.
7988 2019-03-07 Tom Tromey <tom@tromey.com>
7990 * symmisc.c (print_symbol_bcache_statistics): Update.
7991 (print_objfile_statistics): Update.
7992 * symfile.c (allocate_symtab): Update.
7993 * stabsread.c: Don't include bcache.h.
7994 * psymtab.h (struct psymbol_bcache): Don't declare.
7995 (class psymtab_storage) <psymbol_cache>: Now a bcache.
7996 (psymbol_bcache_init, psymbol_bcache_free)
7997 (psymbol_bcache_get_bcache): Don't declare.
7998 * psymtab.c (struct psymbol_bcache): Remove.
7999 (psymtab_storage::psymtab_storage): Update.
8000 (psymtab_storage::~psymtab_storage): Update.
8001 (psymbol_bcache_init, psymbol_bcache_free)
8002 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8003 (add_psymbol_to_bcache): Update.
8004 (allocate_psymtab): Update.
8005 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8006 macro_cache>: No longer pointers.
8007 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8008 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8009 * macrotab.c (macro_bcache): Update.
8010 * macroexp.c: Don't include bcache.h.
8011 * gdbtypes.c (check_types_worklist): Update.
8012 (types_deeply_equal): Remove TRY/CATCH. Update.
8013 * elfread.c (elf_symtab_read): Update.
8014 * dwarf2read.c: Don't include bcache.h.
8015 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8016 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8017 (print_bcache_statistics, bcache_memory_used): Don't declare.
8018 (struct bcache): Move from bcache.c. Add constructor, destructor,
8019 methods. Rename all data members.
8020 * bcache.c (struct bcache): Move to bcache.h.
8021 (bcache::expand_hash_table): Rename from expand_hash_table.
8023 (bcache::insert): Rename from bcache_full.
8024 (bcache::compare): Rename from bcache_compare.
8025 (bcache_xmalloc): Remove.
8026 (bcache::~bcache): Rename from bcache_xfree.
8027 (bcache::print_statistics): Rename from print_bcache_statistics.
8028 (bcache::memory_used): Rename from bcache_memory_used.
8030 2019-03-07 Pedro Alves <palves@redhat.com>
8032 * infrun.c (normal_stop): Also check for
8033 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8035 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8037 * f-lang.c (value_from_host_double): Moved to...
8038 * value.c (value_from_host_double): ...here.
8039 * value.h (value_from_host_double): Declare.
8040 * guile/scm-math.c (vlscm_convert_typed_number): Use
8041 value_from_host_double.
8042 (vlscm_convert_number): Likewise.
8043 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8044 * python/py-value.c (convert_value_from_python): Likewise.
8046 2019-03-06 Tom Tromey <tom@tromey.com>
8048 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8050 2019-03-06 Tom Tromey <tom@tromey.com>
8052 * utils.h (free_current_contents): Don't declare.
8053 * utils.c (free_current_contents): Remove.
8055 2019-03-06 Tom Tromey <tom@tromey.com>
8057 * top.c (quit_force): Update.
8058 * main.c (captured_command_loop): Update.
8059 * common/new-op.c (operator new): Update.
8060 * common/common-exceptions.c (struct catcher)
8061 <save_cleanup_chain>: Remove member.
8062 (exceptions_state_mc_init): Update.
8063 (exception_try_scope_entry): Return nullptr.
8064 (exception_try_scope_exit, exception_rethrow)
8065 (throw_exception_sjlj, throw_exception_cxx): Update.
8066 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8067 (all_cleanups, do_cleanups, discard_cleanups)
8068 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8069 (restore_cleanups, restore_final_cleanups): Don't declare.
8070 (do_final_cleanups): Remove parameter.
8071 * common/cleanups.c (cleanup_chain, make_cleanup)
8072 (make_cleanup_dtor, all_cleanups, do_cleanups)
8073 (discard_my_cleanups, discard_cleanups)
8074 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8075 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8076 (null_cleanup): Remove.
8077 (do_final_cleanups): Remove parameter.
8079 2019-03-06 Tom Tromey <tom@tromey.com>
8081 * remote.c (remote_target::remote_parse_stop_reply): Use
8084 2019-03-06 Tom Tromey <tom@tromey.com>
8086 * stabsread.c (struct stabs_field_info): Rename from field_info.
8087 <list, fnlist>: Add initializers.
8088 <obstack>: New member.
8089 (read_member_functions, read_struct_fields, read_baseclasses):
8090 Allocate on obstack. Don't use cleanups.
8091 (read_one_struct_field, read_member_functions, read_struct_fields)
8092 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8093 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8094 (read_struct_type): Update.
8096 2019-03-06 Tom Tromey <tom@tromey.com>
8098 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8099 * common/filestuff.h (make_cleanup_close): Don't declare.
8100 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8103 2019-03-06 Tom Tromey <tom@tromey.com>
8105 * solib-aix.c: Use make_scope_exit.
8107 2019-03-06 Tom Tromey <tom@tromey.com>
8109 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8110 Use make_scope_exit.
8112 2019-03-06 Tom Tromey <tom@tromey.com>
8114 * solib-svr4.c (disable_probes_interface): Remove parameter.
8115 (svr4_handle_solib_event): Use make_scope_exit.
8117 2019-03-06 Tom Tromey <tom@tromey.com>
8119 * remote.c (struct stop_reply_deleter): Remove.
8120 (stop_reply_up): Update.
8121 (struct stop_reply): Derive from notif_event. Don't typedef.
8122 <regcache>: Now a std::vector.
8123 (stop_reply_xfree): Remove.
8124 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8125 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8126 (remote_target::discard_pending_stop_replies): Use delete.
8127 (remote_target::remote_parse_stop_reply): Update.
8128 (remote_target::process_stop_reply): Update.
8129 * remote-notif.h (struct notif_event): Add virtual destructor.
8130 Remove "dtr" member.
8131 (struct notif_client) <alloc_event>: Return a unique_ptr.
8132 (notif_event_xfree): Don't declare.
8133 (notif_event_up): New typedef.
8134 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8135 (notif_event_xfree, do_notif_event_xfree): Remove.
8136 (remote_notif_state_xfree): Update.
8138 2019-03-06 Tom Tromey <tom@tromey.com>
8140 * infrun.c (displaced_step_clear_cleanup): Now a
8141 forward_scope_exit type.
8142 (displaced_step_prepare_throw): Update.
8143 (displaced_step_fixup): Update.
8145 2019-03-06 Tom Tromey <tom@tromey.com>
8147 * inferior.h (class inferior): Update comment.
8148 * gdbthread.h (class thread_info): Update comment.
8150 2019-03-06 Joel Brobecker <brobecker@adacore.com>
8151 Tom Tromey <tom@tromey.com>
8153 * stabsread.h (struct stab_section_list): Remove.
8154 (coffstab_build_psymtabs): Update.
8155 * dbxread.c (symbuf_sections): Now a std::vector.
8156 (sect_idx): New global.
8157 (fill_symbuf): Update.
8158 (coffstab_build_psymtabs): Change type of stabsects parameter.
8160 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8162 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8163 (coff_locate_sections): Update.
8164 (coff_symfile_read): Remove cleanups. Update.
8165 (init_stringtab): Add storage parameter.
8166 (free_stringtab, free_stringtab_cleanup): Remove.
8167 (init_lineno): Add storage parameter.
8168 (free_linetab, free_linetab_cleanup): Remove.
8170 2019-03-06 Pedro Alves <palves@redhat.com>
8172 * linux-fork.c (fork_info::clobber_regs): Delete.
8173 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8174 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8176 (scoped_switch_fork_info::scoped_switch_fork_info)
8177 (checkpoint_command, linux_fork_context): Adjust
8178 fork_save_infrun_state calls.
8180 2019-03-06 Pedro Alves <palves@redhat.com>
8182 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8183 (inf_has_multiple_threads): Return 'bool' and rewrite using
8184 inferior_info::threads().
8186 2019-03-06 Pedro Alves <palves@redhat.com>
8188 * linux-fork.c: Include <list>.
8189 (fork_list): Now a std::list instance.
8190 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8191 (forks_exist_p, find_last_fork): Adjust.
8195 (free_fork): Delete, folded into fork_info::~fork_info().
8196 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8198 (init_fork_list): Delete.
8199 (linux_fork_killall, linux_fork_mourn_inferior)
8200 (linux_fork_detach, info_checkpoints_command): Adjust.
8201 (_initialize_linux_fork): No longer call init_fork_list.
8203 2019-03-06 Pedro Alves <palves@redhat.com>
8205 * linux-fork.c (new_fork): New, split out of ...
8206 (add_fork): ... this. Return void. Move "first fork" special
8207 case from here, to ...
8208 (checkpoint_command): ... here.
8209 * linux-linux.h (add_fork): Return void.
8211 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8213 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8215 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8216 Chris January <chris.january@arm.com>
8217 David Lecomber <david.lecomber@arm.com>
8219 * f-exp.y: New token, UNOP_INTRINSIC.
8220 (exp): New pattern using UNOP_INTRINSIC token.
8221 (f77_keywords): Add 'abs' keyword.
8222 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8223 (value_from_host_double): New function.
8224 (evaluate_subexp_f): Support UNOP_ABS.
8226 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8228 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8231 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8233 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8234 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8235 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8237 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8239 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8241 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8242 Chris January <chris.january@arm.com>
8244 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8245 * f-exp.y: Define 'KIND' token.
8246 (exp): New pattern for KIND expressions.
8247 (ptype): Handle types with a kind extension.
8248 (direct_abs_decl): Extend to spot kind extensions.
8249 (f77_keywords): Add 'kind' to the list.
8250 (push_kind_type): New function.
8251 (convert_to_kind_type): New function.
8252 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8253 * parse.c (operator_length_standard): Likewise.
8254 * parser-defs.h (enum type_pieces): Add tp_kind.
8255 * std-operator.def: Add UNOP_KIND.
8257 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8259 * f-exp.y (f_parse): Set yydebug.
8261 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8263 * f-lang.c (evaluate_subexp_f): New function.
8264 (exp_descriptor_f): New global.
8265 (f_language_defn): Use exp_descriptor_f instead of
8266 exp_descriptor_standard.
8268 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8270 * f-exp.y (struct token): Add comments.
8271 (dot_ops): Remove uppercase versions and the end marker.
8272 (f77_keywords): Likewise.
8273 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8274 entries in the dot_ops array are case insensitive, and use
8275 strncasecmp to compare strings. Also some whitespace cleanup in
8276 this area. Similar for the f77_keywords array, except entries in
8277 this list might be case sensitive.
8279 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8281 * f-exp.y (struct f77_boolean_val): Add comments.
8282 (boolean_values): Remove uppercase versions, and end marker.
8283 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8284 and use strncasecmp to achieve case insensitivity. Additionally,
8285 perform whitespace cleanup around this code.
8287 2019-03-06 Tom Tromey <tromey@adacore.com>
8289 * remote-sim.c (gdbsim_target_open): Use result of
8292 2019-03-06 Richard Bunt <richard.bunt@arm.com>
8293 Dirk Schubert <dirk.schubert@arm.com>
8294 Chris January <chris.january@arm.com>
8296 * eval.c (evaluate_subexp_standard): Call Fortran argument
8298 * f-lang.c (struct value): A value which can be passed into a
8299 Fortran function call.
8300 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8302 (struct type): Value ready for a Fortran function call.
8303 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8305 * f-lang.h (fortran_argument_convert): Declaration.
8306 (fortran_preserve_arg_pointer): Declaration.
8307 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8309 2019-03-05 Tom Tromey <tromey@adacore.com>
8311 * python/py-prettyprint.c (print_string_repr): Remove #if.
8312 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8314 2019-03-05 Tom Tromey <tromey@adacore.com>
8316 * target.c (the_dummy_target): Move later. Change type to
8318 (initialize_targets): Don't initialize the_dummy_target.
8320 2019-03-05 Tom Tromey <tromey@adacore.com>
8322 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8323 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8325 2019-03-05 Tom Tromey <tromey@adacore.com>
8327 * windows-nat.c (windows_nat_target::attach)
8328 (windows_nat_target::detach): Don't call gdb_flush.
8329 * valprint.c (generic_val_print, val_print, val_print_string):
8330 Don't call gdb_flush.
8331 * utils.c (defaulted_query): Don't call gdb_flush.
8332 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8333 * target.c (target_announce_detach): Don't call gdb_flush.
8334 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8335 * remote.c (extended_remote_target::attach): Don't call
8337 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8338 * printcmd.c (do_examine): Don't call gdb_flush.
8339 (info_display_command): Don't call gdb_flush.
8340 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8341 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8342 * memattr.c (info_mem_command): Don't call gdb_flush.
8343 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8344 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8345 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8346 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8347 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8348 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8349 (gnu_nat_target::detach): Don't call gdb_flush.
8350 * f-valprint.c (f_val_print): Don't call gdb_flush.
8351 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8352 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8353 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8355 * c-valprint.c (c_val_print): Don't call gdb_flush.
8356 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8358 2019-03-05 Tom Tromey <tromey@adacore.com>
8360 * varobj.c (update_dynamic_varobj_children): Update.
8361 (install_default_visualizer): Use reset, not release.
8362 * value.c (set_internalvar): Update.
8363 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8364 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8365 ATTRIBUTE_UNUSED_RESULT.
8367 2019-03-05 Tom Tromey <tromey@adacore.com>
8369 * remote.c (class scoped_remote_fd) <release>: Add
8370 ATTRIBUTE_UNUSED_RESULT.
8372 2019-03-05 Tom Tromey <tromey@adacore.com>
8374 * macroexp.c (struct macro_buffer) <release>: Add
8375 ATTRIBUTE_UNUSED_RESULT.
8377 2019-03-05 Tom Tromey <tromey@adacore.com>
8379 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8380 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8381 ATTRIBUTE_UNUSED_RESULT.
8383 2019-03-05 Tom Tromey <tromey@adacore.com>
8385 * common/scoped_fd.h (class scoped_fd) <release>: Add
8386 ATTRIBUTE_UNUSED_RESULT.
8388 2019-03-05 Tom Tromey <tromey@adacore.com>
8390 * parser-defs.h (struct parser_state) <release>: Add
8391 ATTRIBUTE_UNUSED_RESULT.
8393 2019-03-05 Tom Tromey <tromey@adacore.com>
8395 * utils.h (class gdb_argv) <release>: Add
8396 ATTRIBUTE_UNUSED_RESULT.
8397 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8399 2019-03-02 Eli Zaretskii <eliz@gnu.org>
8401 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8402 for-loop range, to avoid compiler warnings.
8404 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8405 avoid compiler warnings about unused variables.
8407 * NEWS: Mention end of support for native debugging on MS-Windows
8411 * common/netstuff.c:
8412 * gdbserver/gdbreplay.c
8413 * gdbserver/remote-utils.c:
8415 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8416 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8417 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8418 'getaddrinfo' and 'freeaddrinfo' were not available before
8419 Windows XP, and mingw.org's MinGW headers by default define
8420 _WIN32_WINNT to 0x500.
8422 2019-03-01 Gary Benson <gbenson@redhat.com>
8424 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8426 2019-02-28 Brian Vandenberg <phantall@gmail.com>
8427 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8430 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8431 set_sigint_trap, clear_sigint_trap.
8433 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8435 * target.c (target_detach): Clear the regcache and the
8438 2019-02-27 Pedro Alves <palves@redhat.com>
8440 * utils.c (set_screen_size): When we cap the height/width sizes,
8441 tweak the corresponding command variable to show "unlimited":
8443 2019-02-27 Saagar Jha <saagar@saagarjha.com>
8444 Pedro Alves <palves@redhat.com>
8446 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8447 before calling rl_set_screen_size.
8449 2019-02-27 Tom Tromey <tromey@adacore.com>
8451 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8453 * python/py-value.c: Remove Python 2.4 workaround.
8454 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8456 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8457 Python 2.4 workaround.
8458 * python/python-internal.h: Remove Python 2.4 comment.
8459 (Py_ssize_t): Don't define.
8460 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8461 (gdb_Py_DECREF): Remove Python 2.4 workaround.
8462 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8463 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8464 * python/python.c (do_start_initialization): Remove Python 2.4
8466 * python/py-prettyprint.c (class dummy_python_frame): Remove.
8467 (print_children): Remove Python 2.4 workaround.
8468 * python/py-inferior.c (buffer_procs): Remove Python 2.4
8470 (CHARBUFFERPROC_NAME): Remove.
8471 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8472 Python 2.4 workaround.
8474 2019-02-27 Kevin Buettner <kevinb@redhat.com>
8476 * NEWS: Note minimum Python version.
8478 2019-02-27 Kevin Buettner <kevinb@redhat.com>
8480 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8481 code from these functions. Remove corresponding ifdefs. Use
8482 Py_buffer_up instead of explicit calls to PyBuffer_Release.
8483 Remove gotos and target of gotos.
8484 (infpy_search_memory): Likewise.
8486 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8488 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8489 (hppa_gdbarch_init): Don't register deleted functions with
8492 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8494 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8495 (h8300_unwind_sp): Delete.
8496 (h8300_dummy_id): Delete.
8497 (h8300_gdbarch_init): Don't register deleted functions with
8500 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8502 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8503 (ft32_unwind_pc): Delete.
8504 (ft32_unwind_sp): Delete.
8505 (ft32_gdbarch_init): Don't register deleted functions with
8508 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8510 * gdb/frv-tdep.c (frv_dummy_id): Delete.
8511 (frv_unwind_pc): Delete.
8512 (frv_unwind_sp): Delete.
8513 (frv_gdbarch_init): Don't register deleted functions with
8516 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8518 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8519 (riscv_unwind_pc): Delete.
8520 (riscv_unwind_sp): Delete.
8521 (riscv_gdbarch_init): Don't register deleted functions with
8524 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8526 * gdb/csky-tdep.c (csky_dummy_id): Delete.
8527 (csky_unwind_pc): Delete.
8528 (csky_unwind_sp): Delete.
8529 (csky_gdbarch_init): Don't register deleted functions with
8532 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8534 * gdb/cris-tdep.c (cris_dummy_id): Delete.
8535 (cris_unwind_pc): Delete.
8536 (cris_unwind_sp): Delete.
8537 (cris_gdbarch_init): Don't register deleted functions with
8540 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8542 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8543 (bfin_unwind_pc): Delete.
8544 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8546 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8548 * gdb/arm-tdep.c (arm_dummy_id): Delete.
8549 (arm_unwind_pc): Delete.
8550 (arm_unwind_sp): Delete.
8551 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8553 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8555 * gdb/arc-tdep.c (arc_dummy_id): Delete.
8556 (arc_unwind_pc): Delete.
8557 (arc_unwind_sp): Delete.
8558 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8560 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8562 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8563 (alpha_unwind_pc): Delete.
8564 (alpha_gdbarch_init): Don't register deleted functions with
8567 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8569 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8570 (aarch64_unwind_pc): Delete.
8571 (aarch64_unwind_sp): Delete.
8572 (aarch64_gdbarch_init): Don't register deleted functions with
8575 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8577 * gdbtypes.c (type_align): Don't consider static members when
8578 computing structure alignment.
8580 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8582 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8583 return 0 for other types.
8584 * arch-utils.c (default_type_align): Always return 0.
8585 * gdbarch.h: Regenerate.
8586 * gdbarch.sh (type_align): Extend comment.
8587 * gdbtypes.c (type_align): Add additional comments, always call
8588 gdbarch_type_align before applying the default rules.
8589 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8590 generic code will then apply a suitable default.
8591 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8592 types, return 0 for other types.
8594 2019-02-27 Joel Brobecker <brobecker@adacore.com>
8596 * NEWS: Create a new section for the next release branch.
8597 Rename the section of the current branch, now that it has
8600 2019-02-27 Joel Brobecker <brobecker@adacore.com>
8602 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8603 * version.in: Bump version to 8.3.50.DATE-git.
8605 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
8607 * aix-thread.c (ptid_cmp): Remove unused variable.
8608 (get_signaled_thread): Likewise.
8609 (store_regs_user_thread): Likewise.
8610 (store_regs_kernel_thread): Likewise.
8611 (fetch_regs_kernel_thread): Remove shadowed variable.
8613 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
8615 * features/riscv/32bit-cpu.xml: Add register numbers.
8616 * features/riscv/32bit-fpu.c: Regenerate.
8617 * features/riscv/32bit-fpu.xml: Add register numbers.
8618 * features/riscv/64bit-cpu.xml: Add register numbers.
8619 * features/riscv/64bit-fpu.c: Regenerate.
8620 * features/riscv/64bit-fpu.xml: Add register numbers.
8622 2019-02-26 Kevin Buettner <kevinb@redhat.com>
8624 * NEWS: Mention two argument form of gdb.Value constructor.
8625 * python/py-value.c (convert_buffer_and_type_to_value): New
8627 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8628 Add support for handling an optional second argument. Call
8629 convert_buffer_and_type_to_value as appropriate.
8630 * python/python-internal.h (Py_buffer_deleter): New struct.
8631 (Py_buffer_up): New typedef.
8633 2019-02-25 John Baldwin <jhb@FreeBSD.org>
8635 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8636 instead of releasing ownership.
8638 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
8640 * dwarf2read.c (open_and_init_dwp_file): Call
8641 elf_numsections instead of bfd_count_sections to initialize
8642 dwp_file->num_sections.
8644 2019-02-25 Tom Tromey <tromey@adacore.com>
8646 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8648 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
8650 * gcore.in: Add '--readnever' option when invoking GDB.
8652 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8654 * MAINTAINERS: Update my email address.
8656 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8658 * build-id.c (build_id_to_debug_bfd_1): New function.
8659 (build_id_to_debug_bfd): Look for separate debug file in
8662 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
8664 * gdbarch.sh: Update the copyright year range that is placed into
8667 2019-02-22 Keith Seitz <keiths@redhat.com>
8670 * linespec.c (create_sals_line_offset): Search for the default
8671 symtab's filename instead of its fullname.
8673 2019-02-21 Alan Hayward <alan.hayward@arm.com>
8675 * NEWS: Update style defaults.
8677 2019-02-21 Alan Hayward <alan.hayward@arm.com>
8679 * main.c (captured_main_1): Disable styling in batch mode.
8681 2019-02-20 Tom Tromey <tom@tromey.com>
8683 * symtab.c (symtab_symbol_info): Fix typos.
8685 2019-02-20 Tom Tromey <tromey@adacore.com>
8687 * findcmd.c (_initialize_mem_search): Use upper case for
8688 metasyntactic variables.
8690 2019-02-20 Alan Hayward <alan.hayward@arm.com>
8692 * aarch64-tdep.c (aarch64_add_reggroups): New function.
8693 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8695 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
8697 * top.h (source_file_name): Change to std::string.
8698 * top.c (source_file_name): Likewise.
8699 (command_line_input): Adjust.
8700 * cli/cli-script.c (script_from_file): Adjust.
8702 2019-02-19 Tom Tromey <tromey@adacore.com>
8704 * ravenscar-thread.c
8705 (ravenscar_thread_target::update_thread_list): Don't call
8706 ada_build_task_list.
8707 * ada-lang.h (ada_build_task_list): Don't declare.
8708 * ada-tasks.c (struct ada_tasks_inferior_data)
8709 <task_list_valid_p>: Now bool.
8710 (read_known_tasks, ada_task_list_changed)
8711 (ada_tasks_invalidate_inferior_data): Update.
8712 (read_known_tasks_array): Return bool.
8713 (read_known_tasks_list): Likewise.
8714 (read_known_tasks): Return void.
8715 (ada_build_task_list): Now static.
8717 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
8719 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8720 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8722 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8724 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8725 variant for ada_tasks_pspace_data_handle and
8726 ada_tasks_inferior_data_handle.
8727 (ada_tasks_pspace_data_cleanup): New function.
8728 (ada_tasks_inferior_data_cleanup): New function.
8730 2019-02-17 Tom Tromey <tom@tromey.com>
8732 * macrotab.h (macro_source_fullname): Return a std::string.
8733 * macrotab.c (macro_include, check_for_redefinition)
8734 (macro_undef, macro_lookup_definition, foreach_macro)
8735 (foreach_macro_in_scope): Update.
8736 (macro_source_fullname): Return a std::string.
8737 * macrocmd.c (show_pp_source_pos): Update.
8739 2019-02-17 Tom Tromey <tom@tromey.com>
8741 * macrocmd.c (show_pp_source_pos): Style the file names.
8743 2019-02-17 Tom Tromey <tom@tromey.com>
8746 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8748 2019-02-17 Tom Tromey <tom@tromey.com>
8750 * ada-lang.c (user_select_syms): Use filtered printing.
8751 * utils.c (wrap_style): New global.
8752 (desired_style): Remove.
8753 (emit_style_escape): Add stream parameter.
8754 (set_output_style, reset_terminal_style, prompt_for_continue):
8756 (flush_wrap_buffer): Only flush gdb_stdout.
8757 (wrap_here): Set wrap_style.
8758 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
8759 treat escape sequences as a character. Change when wrap buffer is
8761 (fputs_styled): Do not set the output style when the default is
8763 * ui-style.h (struct ui_file_style) <is_default>: New method.
8764 * source.c (print_source_lines_base): Emit escape sequences in one
8767 2019-02-17 Joel Brobecker <brobecker@adacore.com>
8769 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8770 integers and enumeration types.
8772 2019-02-17 Joel Brobecker <brobecker@adacore.com>
8774 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8775 instead of lookup_symbol_in_language
8776 (do_exact_match): New function.
8777 (ada_get_symbol_name_matcher): Return do_exact_match when
8778 doing a verbatim match.
8780 2019-02-15 Tom Tromey <tromey@adacore.com>
8782 * ravenscar-thread.c (ravenscar_thread_target::resume)
8783 (ravenscar_thread_target::wait): Special case wildcard requests.
8785 2019-02-15 Tom Tromey <tromey@adacore.com>
8787 * ravenscar-thread.c (base_ptid): Remove.
8788 (struct ravenscar_thread_target) <close>: New method.
8789 <m_base_ptid>: New member.
8790 <update_inferior_ptid, active_task, task_is_currently_active,
8791 runtime_initialized>: Declare methods.
8792 <ravenscar_thread_target>: Add constructor.
8793 (ravenscar_thread_target::task_is_currently_active)
8794 (ravenscar_thread_target::update_inferior_ptid)
8795 (ravenscar_runtime_initialized): Rename. Now methods.
8796 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8797 (ravenscar_thread_target::update_thread_list): Update.
8798 (ravenscar_thread_target::active_task): Now method.
8799 (ravenscar_thread_target::store_registers)
8800 (ravenscar_thread_target::prepare_to_store)
8801 (ravenscar_thread_target::prepare_to_store)
8802 (ravenscar_thread_target::mourn_inferior): Update.
8803 (ravenscar_inferior_created): Use "new" to create target.
8804 (ravenscar_thread_target::get_ada_task_ptid): Update.
8805 (_initialize_ravenscar): Don't initialize base_ptid.
8806 (ravenscar_ops): Remove global.
8808 2019-02-15 Tom Tromey <tromey@adacore.com>
8810 * target.h (push_target): Declare new overload.
8811 * target.c (push_target): New overload, taking an rvalue reference.
8812 * remote.c (remote_target::open_1): Use push_target overload.
8813 * corelow.c (core_target_open): Use push_target overload.
8815 2019-02-15 Tom Tromey <tromey@adacore.com>
8817 * ravenscar-thread.c (is_ravenscar_task)
8818 (ravenscar_task_is_currently_active): Return bool.
8819 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8820 (_initialize_ravenscar): Remove "(void)".
8821 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8824 2019-02-15 Tom Tromey <tromey@adacore.com>
8826 * ravenscar-thread.c (ravenscar_runtime_initializer)
8827 (has_ravenscar_runtime, get_running_thread_id)
8828 (ravenscar_thread_target::resume): Fix indentation.
8830 2019-02-15 Tom Tromey <tromey@adacore.com>
8832 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8833 from ravenscar_arch_ops.
8834 (sparc_ravenscar_ops::fetch_registers)
8835 (sparc_ravenscar_ops::store_registers): Now methods.
8836 (sparc_ravenscar_prepare_to_store): Remove.
8837 (sparc_ravenscar_ops): Redefine.
8838 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8839 methods and destructor. Remove members.
8840 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8841 (ravenscar_thread_target::store_registers)
8842 (ravenscar_thread_target::prepare_to_store): Update.
8843 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8845 (struct ppc_ravenscar_powerpc_ops): Derive from
8847 (ppc_ravenscar_powerpc_ops::fetch_registers)
8848 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8849 (ppc_ravenscar_powerpc_ops): Redefine.
8850 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8851 (ppc_ravenscar_e500_ops::fetch_registers)
8852 (ppc_ravenscar_e500_ops::store_registers): Now methods.
8853 (ppc_ravenscar_e500_ops): Redefine.
8854 * aarch64-ravenscar-thread.c
8855 (aarch64_ravenscar_generic_prepare_to_store): Remove.
8856 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8857 (aarch64_ravenscar_fetch_registers)
8858 (aarch64_ravenscar_store_registers): Now methods.
8859 (aarch64_ravenscar_ops): Redefine.
8861 2019-02-15 Tom Tromey <tromey@adacore.com>
8863 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8864 (ravenscar_thread_target::stopped_by_hw_breakpoint)
8865 (ravenscar_thread_target::stopped_by_watchpoint)
8866 (ravenscar_thread_target::stopped_data_address)
8867 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8869 2019-02-15 Tom Tromey <tromey@adacore.com>
8871 * ravenscar-thread.c: Fix some typos.
8873 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8874 Tom Tromey <tromey@adacore.com>
8876 * ada-lang.c (ada_exception_sal): Change addr_string to a
8878 (create_ada_exception_catchpoint): Update.
8880 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8881 Tom Tromey <tromey@adacore.com>
8883 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8884 (bp_location_ops): Remove.
8885 (base_breakpoint_allocate_location): Update.
8886 (free_bp_location): Update.
8887 * ada-lang.c (class ada_catchpoint_location)
8888 <ada_catchpoint_location>: Remove ops parameter.
8889 (ada_catchpoint_location_dtor): Remove.
8890 (ada_catchpoint_location_ops): Remove.
8891 (allocate_location_exception): Update.
8892 * breakpoint.h (struct bp_location_ops): Remove.
8893 (class bp_location) <bp_location>: Remove bp_location_ops
8895 <~bp_location>: Add destructor.
8898 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8899 Pedro Alves <palves@redhat.com>
8901 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8904 2019-02-14 David Michael <fedora.dm0@gmail.com>
8905 Samuel Thibault <samuel.thibault@gnu.org>
8906 Thomas Schwinge <thomas@codesourcery.com>
8908 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8909 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8911 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8913 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8914 (check_empty): Use "const char *".
8916 * gnu-nat.c (gnu_nat_target::detach): Instead of
8917 'detach_inferior (pid)' call
8918 'detach_inferior (find_inferior_pid (pid))'.
8920 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8921 'nat/fork-inferior.o'.
8922 * gnu-nat.c: #include "nat/fork-inferior.h".
8924 * gnu-nat.c (gnu_nat_target::detach): Instead of
8925 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8926 * gnu-nat.h: #include "inf-child.h".
8927 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8928 'i386_gnu_nat_target::fetch_registers'.
8929 (gnu_store_registers): Rename/move to
8930 'i386_gnu_nat_target::store_registers'.
8932 * config/i386/nm-i386gnu.h: Don't "#include" any files.
8933 * gnu-nat.h (mach_thread_info): New function.
8934 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8936 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8938 2019-02-14 Frederic Konrad <konrad@adacore.com>
8940 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8942 2019-02-14 Joel Brobecker <brobecker@adacore.com>
8944 * windows-nat.c (windows_add_thread): Add new parameter
8945 "main_thread_p" with default value set to false. Update
8946 function documentation as well as all callers.
8947 (windows_delete_thread): Likewise.
8948 (fake_create_process): Update call to windows_add_thread.
8949 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8950 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8951 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8952 call to windows_delete_thread.
8954 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
8956 * MAINTAINERS: Add Andrew Burgess as global maintainer.
8958 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8960 * symfile.c (find_separate_debug_file): Use canonical path of
8961 sysroot with child_path instead of gdb_sysroot if it is valid.
8963 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8965 * symfile.c (find_separate_debug_file): Use child_path to
8966 determine if an object file is under a sysroot.
8968 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8970 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8971 unittests/child-path-selftests.c.
8972 * common/pathstuff.c (child_path): New function.
8973 * common/pathstuff.h (child_path): New prototype.
8974 * unittests/child-path-selftests.c: New file.
8976 2019-02-12 John Baldwin <jhb@FreeBSD.org>
8978 * symfile.c (find_separate_debug_file): Look for separate debug
8979 files in debug directories under the sysroot.
8981 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8983 * symtab.h (struct minimal_symbol data_p): New const method.
8984 (struct minimal_symbol text_p): Likewise.
8985 * symtab.c (output_source_filename): Use file name style
8987 (print_symbol_info): Likewise.
8988 (print_msymbol_info): Use address style to print addresses.
8989 Use function name style to print executable text symbols.
8990 (expand_symtab_containing_pc): Use data_p.
8991 (find_pc_sect_compunit_symtab): Likewise.
8993 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8995 * breakpoint.c (describe_other_breakpoints): Use address style
8997 (say_where): Likewise.
8999 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9001 * ada-typeprint.c (print_func_type): Print function name
9002 style to print function name.
9003 * c-typeprint.c (c_print_type_1): Likewise.
9005 2019-02-11 Alan Hayward <alan.hayward@arm.com>
9007 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9010 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9012 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9015 2019-02-10 Joel Brobecker <brobecker@adacore.com>
9017 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9018 TYPE_CODE_REF types.
9020 2019-02-08 Jim Wilson <jimw@sifive.com>
9022 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9023 (riscv_linux_fregset): New.
9024 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9026 2019-02-07 Tom Tromey <tom@tromey.com>
9028 * thread.c (thread_cancel_execution_command): Update.
9029 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9031 (struct thread_fsm_ops): Remove.
9032 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9033 (thread_fsm_should_stop, thread_fsm_return_value)
9034 (thread_fsm_set_finished, thread_fsm_finished_p)
9035 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9037 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9038 * infrun.c (clear_proceed_status_thread)
9039 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9040 (print_stop_event): Update.
9041 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9043 (step_command_fsm_ops): Remove.
9044 (new_step_command_fsm): Remove.
9046 (step_command_fsm::should_stop): Rename from
9047 step_command_fsm_should_stop.
9048 (step_command_fsm::clean_up): Rename from
9049 step_command_fsm_clean_up.
9050 (step_command_fsm::do_async_reply_reason): Rename from
9051 step_command_fsm_async_reply_reason.
9052 (struct until_next_fsm): Inherit from thread_fsm. Add
9054 (until_next_fsm_ops): Remove.
9055 (new_until_next_fsm): Remove.
9056 (until_next_fsm::should_stop): Rename from
9057 until_next_fsm_should_stop.
9058 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9059 (until_next_fsm::do_async_reply_reason): Rename from
9060 until_next_fsm_async_reply_reason.
9061 (struct finish_command_fsm): Inherit from thread_fsm. Add
9062 constructor. Change type of breakpoint.
9063 (finish_command_fsm_ops): Remove.
9064 (new_finish_command_fsm): Remove.
9065 (finish_command_fsm::should_stop): Rename from
9066 finish_command_fsm_should_stop.
9067 (finish_command_fsm::clean_up): Rename from
9068 finish_command_fsm_clean_up.
9069 (finish_command_fsm::return_value): Rename from
9070 finish_command_fsm_return_value.
9071 (finish_command_fsm::do_async_reply_reason): Rename from
9072 finish_command_fsm_async_reply_reason.
9073 (finish_command): Update.
9074 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9076 (call_thread_fsm_ops): Remove.
9077 (call_thread_fsm::call_thread_fsm): Rename from
9078 new_call_thread_fsm.
9079 (call_thread_fsm::should_stop): Rename from
9080 call_thread_fsm_should_stop.
9081 (call_thread_fsm::should_notify_stop): Rename from
9082 call_thread_fsm_should_notify_stop.
9083 (run_inferior_call, call_function_by_hand_dummy): Update.
9084 * cli/cli-interp.c (should_print_stop_to_console): Update.
9085 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9086 Add constructor. Change type of location_breakpoint,
9088 (until_break_fsm_ops): Remove.
9089 (new_until_break_fsm): Remove.
9090 (until_break_fsm::should_stop): Rename from
9091 until_break_fsm_should_stop.
9092 (until_break_fsm::clean_up): Rename from
9093 until_break_fsm_clean_up.
9094 (until_break_fsm::do_async_reply_reason): Rename from
9095 until_break_fsm_async_reply_reason.
9096 (until_break_command): Update.
9097 * thread-fsm.c: Remove.
9098 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9100 2019-02-07 Tom Tromey <tom@tromey.com>
9102 * yy-remap.h: Add include guard.
9103 * xtensa-tdep.h: Add include guard.
9104 * xcoffread.h: Rename include guard.
9105 * varobj-iter.h: Add include guard.
9106 * tui/tui.h: Rename include guard.
9107 * tui/tui-winsource.h: Rename include guard.
9108 * tui/tui-wingeneral.h: Rename include guard.
9109 * tui/tui-windata.h: Rename include guard.
9110 * tui/tui-win.h: Rename include guard.
9111 * tui/tui-stack.h: Rename include guard.
9112 * tui/tui-source.h: Rename include guard.
9113 * tui/tui-regs.h: Rename include guard.
9114 * tui/tui-out.h: Rename include guard.
9115 * tui/tui-layout.h: Rename include guard.
9116 * tui/tui-io.h: Rename include guard.
9117 * tui/tui-hooks.h: Rename include guard.
9118 * tui/tui-file.h: Rename include guard.
9119 * tui/tui-disasm.h: Rename include guard.
9120 * tui/tui-data.h: Rename include guard.
9121 * tui/tui-command.h: Rename include guard.
9122 * tic6x-tdep.h: Add include guard.
9123 * target/waitstatus.h: Rename include guard.
9124 * target/wait.h: Rename include guard.
9125 * target/target.h: Rename include guard.
9126 * target/resume.h: Rename include guard.
9127 * target-float.h: Rename include guard.
9128 * stabsread.h: Add include guard.
9129 * rs6000-tdep.h: Add include guard.
9130 * riscv-fbsd-tdep.h: Add include guard.
9131 * regformats/regdef.h: Rename include guard.
9132 * record.h: Rename include guard.
9133 * python/python.h: Rename include guard.
9134 * python/python-internal.h: Rename include guard.
9135 * python/py-stopevent.h: Rename include guard.
9136 * python/py-ref.h: Rename include guard.
9137 * python/py-record.h: Rename include guard.
9138 * python/py-record-full.h: Rename include guard.
9139 * python/py-record-btrace.h: Rename include guard.
9140 * python/py-instruction.h: Rename include guard.
9141 * python/py-events.h: Rename include guard.
9142 * python/py-event.h: Rename include guard.
9143 * procfs.h: Add include guard.
9144 * proc-utils.h: Add include guard.
9145 * p-lang.h: Add include guard.
9146 * or1k-tdep.h: Rename include guard.
9147 * observable.h: Rename include guard.
9148 * nto-tdep.h: Rename include guard.
9149 * nat/x86-linux.h: Rename include guard.
9150 * nat/x86-linux-dregs.h: Rename include guard.
9151 * nat/x86-gcc-cpuid.h: Add include guard.
9152 * nat/x86-dregs.h: Rename include guard.
9153 * nat/x86-cpuid.h: Rename include guard.
9154 * nat/ppc-linux.h: Rename include guard.
9155 * nat/mips-linux-watch.h: Rename include guard.
9156 * nat/linux-waitpid.h: Rename include guard.
9157 * nat/linux-ptrace.h: Rename include guard.
9158 * nat/linux-procfs.h: Rename include guard.
9159 * nat/linux-osdata.h: Rename include guard.
9160 * nat/linux-nat.h: Rename include guard.
9161 * nat/linux-namespaces.h: Rename include guard.
9162 * nat/linux-btrace.h: Rename include guard.
9163 * nat/glibc_thread_db.h: Rename include guard.
9164 * nat/gdb_thread_db.h: Rename include guard.
9165 * nat/gdb_ptrace.h: Rename include guard.
9166 * nat/fork-inferior.h: Rename include guard.
9167 * nat/amd64-linux-siginfo.h: Rename include guard.
9168 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9169 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9170 * nat/aarch64-linux.h: Rename include guard.
9171 * nat/aarch64-linux-hw-point.h: Rename include guard.
9172 * mn10300-tdep.h: Add include guard.
9173 * mips-linux-tdep.h: Add include guard.
9174 * mi/mi-parse.h: Rename include guard.
9175 * mi/mi-out.h: Rename include guard.
9176 * mi/mi-main.h: Rename include guard.
9177 * mi/mi-interp.h: Rename include guard.
9178 * mi/mi-getopt.h: Rename include guard.
9179 * mi/mi-console.h: Rename include guard.
9180 * mi/mi-common.h: Rename include guard.
9181 * mi/mi-cmds.h: Rename include guard.
9182 * mi/mi-cmd-break.h: Rename include guard.
9183 * m2-lang.h: Add include guard.
9184 * location.h: Rename include guard.
9185 * linux-record.h: Rename include guard.
9186 * linux-nat.h: Add include guard.
9187 * linux-fork.h: Add include guard.
9188 * i386-darwin-tdep.h: Rename include guard.
9189 * hppa-linux-offsets.h: Add include guard.
9190 * guile/guile.h: Rename include guard.
9191 * guile/guile-internal.h: Rename include guard.
9192 * gnu-nat.h: Rename include guard.
9193 * gdb-stabs.h: Rename include guard.
9194 * frv-tdep.h: Add include guard.
9195 * f-lang.h: Add include guard.
9196 * event-loop.h: Add include guard.
9197 * darwin-nat.h: Rename include guard.
9198 * cp-abi.h: Rename include guard.
9199 * config/sparc/nm-sol2.h: Rename include guard.
9200 * config/nm-nto.h: Rename include guard.
9201 * config/nm-linux.h: Add include guard.
9202 * config/i386/nm-i386gnu.h: Rename include guard.
9203 * config/djgpp/nl_types.h: Rename include guard.
9204 * config/djgpp/langinfo.h: Rename include guard.
9205 * compile/gcc-cp-plugin.h: Add include guard.
9206 * compile/gcc-c-plugin.h: Add include guard.
9207 * compile/compile.h: Rename include guard.
9208 * compile/compile-object-run.h: Rename include guard.
9209 * compile/compile-object-load.h: Rename include guard.
9210 * compile/compile-internal.h: Rename include guard.
9211 * compile/compile-cplus.h: Rename include guard.
9212 * compile/compile-c.h: Rename include guard.
9213 * common/xml-utils.h: Rename include guard.
9214 * common/x86-xstate.h: Rename include guard.
9215 * common/version.h: Rename include guard.
9216 * common/vec.h: Rename include guard.
9217 * common/tdesc.h: Rename include guard.
9218 * common/selftest.h: Rename include guard.
9219 * common/scoped_restore.h: Rename include guard.
9220 * common/scoped_mmap.h: Rename include guard.
9221 * common/scoped_fd.h: Rename include guard.
9222 * common/safe-iterator.h: Rename include guard.
9223 * common/run-time-clock.h: Rename include guard.
9224 * common/refcounted-object.h: Rename include guard.
9225 * common/queue.h: Rename include guard.
9226 * common/ptid.h: Rename include guard.
9227 * common/print-utils.h: Rename include guard.
9228 * common/preprocessor.h: Rename include guard.
9229 * common/pathstuff.h: Rename include guard.
9230 * common/observable.h: Rename include guard.
9231 * common/netstuff.h: Rename include guard.
9232 * common/job-control.h: Rename include guard.
9233 * common/host-defs.h: Rename include guard.
9234 * common/gdb_wait.h: Rename include guard.
9235 * common/gdb_vecs.h: Rename include guard.
9236 * common/gdb_unlinker.h: Rename include guard.
9237 * common/gdb_unique_ptr.h: Rename include guard.
9238 * common/gdb_tilde_expand.h: Rename include guard.
9239 * common/gdb_sys_time.h: Rename include guard.
9240 * common/gdb_string_view.h: Rename include guard.
9241 * common/gdb_splay_tree.h: Rename include guard.
9242 * common/gdb_setjmp.h: Rename include guard.
9243 * common/gdb_ref_ptr.h: Rename include guard.
9244 * common/gdb_optional.h: Rename include guard.
9245 * common/gdb_locale.h: Rename include guard.
9246 * common/gdb_assert.h: Rename include guard.
9247 * common/filtered-iterator.h: Rename include guard.
9248 * common/filestuff.h: Rename include guard.
9249 * common/fileio.h: Rename include guard.
9250 * common/environ.h: Rename include guard.
9251 * common/common-utils.h: Rename include guard.
9252 * common/common-types.h: Rename include guard.
9253 * common/common-regcache.h: Rename include guard.
9254 * common/common-inferior.h: Rename include guard.
9255 * common/common-gdbthread.h: Rename include guard.
9256 * common/common-exceptions.h: Rename include guard.
9257 * common/common-defs.h: Rename include guard.
9258 * common/common-debug.h: Rename include guard.
9259 * common/cleanups.h: Rename include guard.
9260 * common/buffer.h: Rename include guard.
9261 * common/btrace-common.h: Rename include guard.
9262 * common/break-common.h: Rename include guard.
9263 * cli/cli-utils.h: Rename include guard.
9264 * cli/cli-style.h: Rename include guard.
9265 * cli/cli-setshow.h: Rename include guard.
9266 * cli/cli-script.h: Rename include guard.
9267 * cli/cli-interp.h: Rename include guard.
9268 * cli/cli-decode.h: Rename include guard.
9269 * cli/cli-cmds.h: Rename include guard.
9270 * charset-list.h: Add include guard.
9271 * buildsym-legacy.h: Rename include guard.
9272 * bfin-tdep.h: Add include guard.
9273 * ax.h: Rename include guard.
9274 * arm-linux-tdep.h: Add include guard.
9275 * arm-fbsd-tdep.h: Add include guard.
9276 * arch/xtensa.h: Rename include guard.
9277 * arch/tic6x.h: Add include guard.
9278 * arch/i386.h: Add include guard.
9279 * arch/arm.h: Rename include guard.
9280 * arch/arm-linux.h: Rename include guard.
9281 * arch/arm-get-next-pcs.h: Rename include guard.
9282 * arch/amd64.h: Add include guard.
9283 * arch/aarch64-insn.h: Rename include guard.
9284 * arch-utils.h: Rename include guard.
9285 * annotate.h: Add include guard.
9286 * amd64-darwin-tdep.h: Rename include guard.
9287 * aarch64-linux-tdep.h: Add include guard.
9288 * aarch64-fbsd-tdep.h: Add include guard.
9289 * aarch32-linux-nat.h: Add include guard.
9291 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9293 * macrotab.c (macro_define_internal): New function that
9294 factorizes macro_define_object_internal and macro_define_function
9296 (macro_define_object_internal): Use macro_define_internal.
9297 (macro_define_function): Likewise.
9299 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9301 * macrocmd.c (extract_identifier): Return
9302 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9305 2019-02-06 John Baldwin <jhb@FreeBSD.org>
9307 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9309 2019-02-05 Tom Tromey <tom@tromey.com>
9311 * target.c (target_stack::unpush): Move assertion earlier.
9313 2019-01-30 Tom Tromey <tom@tromey.com>
9316 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9317 (gdbpy_parse_and_eval): Likewise.
9318 * python/python-internal.h (gdbpy_allow_threads): New class.
9320 2019-01-28 John Baldwin <jhb@FreeBSD.org>
9322 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9323 (aarch64_fbsd_fpregmap): Move earlier.
9324 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9325 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9326 instead of individual calls to trad_frame_set_reg_addr.
9327 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9329 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9330 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9331 instead of individual calls to trad_frame_set_reg_addr.
9333 2019-01-28 Alan Hayward <alan.hayward@arm.com>
9335 * CONTRIBUTE: Replace contribution list with wiki link.
9337 2019-01-25 Tom Tromey <tom@tromey.com>
9339 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9341 2019-01-25 Tom Tromey <tom@tromey.com>
9343 * xtensa-linux-nat.c: Fix common/ includes.
9344 * xml-support.h: Fix common/ includes.
9345 * xml-support.c: Fix common/ includes.
9346 * x86-linux-nat.c: Fix common/ includes.
9347 * windows-nat.c: Fix common/ includes.
9348 * varobj.h: Fix common/ includes.
9349 * varobj.c: Fix common/ includes.
9350 * value.c: Fix common/ includes.
9351 * valops.c: Fix common/ includes.
9352 * utils.c: Fix common/ includes.
9353 * unittests/xml-utils-selftests.c: Fix common/ includes.
9354 * unittests/utils-selftests.c: Fix common/ includes.
9355 * unittests/unpack-selftests.c: Fix common/ includes.
9356 * unittests/tracepoint-selftests.c: Fix common/ includes.
9357 * unittests/style-selftests.c: Fix common/ includes.
9358 * unittests/string_view-selftests.c: Fix common/ includes.
9359 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9360 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9361 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9362 * unittests/rsp-low-selftests.c: Fix common/ includes.
9363 * unittests/parse-connection-spec-selftests.c: Fix common/
9365 * unittests/optional-selftests.c: Fix common/ includes.
9366 * unittests/offset-type-selftests.c: Fix common/ includes.
9367 * unittests/observable-selftests.c: Fix common/ includes.
9368 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9369 * unittests/memrange-selftests.c: Fix common/ includes.
9370 * unittests/memory-map-selftests.c: Fix common/ includes.
9371 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9372 * unittests/function-view-selftests.c: Fix common/ includes.
9373 * unittests/environ-selftests.c: Fix common/ includes.
9374 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9375 * unittests/common-utils-selftests.c: Fix common/ includes.
9376 * unittests/cli-utils-selftests.c: Fix common/ includes.
9377 * unittests/array-view-selftests.c: Fix common/ includes.
9378 * ui-file.c: Fix common/ includes.
9379 * tui/tui-io.c: Fix common/ includes.
9380 * tracepoint.h: Fix common/ includes.
9381 * tracepoint.c: Fix common/ includes.
9382 * tracefile-tfile.c: Fix common/ includes.
9383 * top.h: Fix common/ includes.
9384 * top.c: Fix common/ includes.
9385 * thread.c: Fix common/ includes.
9386 * target/waitstatus.h: Fix common/ includes.
9387 * target/waitstatus.c: Fix common/ includes.
9388 * target.h: Fix common/ includes.
9389 * target.c: Fix common/ includes.
9390 * target-memory.c: Fix common/ includes.
9391 * target-descriptions.c: Fix common/ includes.
9392 * symtab.h: Fix common/ includes.
9393 * symfile.c: Fix common/ includes.
9394 * stap-probe.c: Fix common/ includes.
9395 * spu-linux-nat.c: Fix common/ includes.
9396 * sparc-nat.c: Fix common/ includes.
9397 * source.c: Fix common/ includes.
9398 * solib.c: Fix common/ includes.
9399 * solib-target.c: Fix common/ includes.
9400 * ser-unix.c: Fix common/ includes.
9401 * ser-tcp.c: Fix common/ includes.
9402 * ser-pipe.c: Fix common/ includes.
9403 * ser-base.c: Fix common/ includes.
9404 * selftest-arch.c: Fix common/ includes.
9405 * s12z-tdep.c: Fix common/ includes.
9406 * rust-exp.y: Fix common/ includes.
9407 * rs6000-aix-tdep.c: Fix common/ includes.
9408 * riscv-tdep.c: Fix common/ includes.
9409 * remote.c: Fix common/ includes.
9410 * remote-notif.h: Fix common/ includes.
9411 * remote-fileio.h: Fix common/ includes.
9412 * remote-fileio.c: Fix common/ includes.
9413 * regcache.h: Fix common/ includes.
9414 * regcache.c: Fix common/ includes.
9415 * record-btrace.c: Fix common/ includes.
9416 * python/python.c: Fix common/ includes.
9417 * python/py-type.c: Fix common/ includes.
9418 * python/py-inferior.c: Fix common/ includes.
9419 * progspace.h: Fix common/ includes.
9420 * producer.c: Fix common/ includes.
9421 * procfs.c: Fix common/ includes.
9422 * proc-api.c: Fix common/ includes.
9423 * printcmd.c: Fix common/ includes.
9424 * ppc-linux-nat.c: Fix common/ includes.
9425 * parser-defs.h: Fix common/ includes.
9426 * osdata.c: Fix common/ includes.
9427 * obsd-nat.c: Fix common/ includes.
9428 * nat/x86-linux.c: Fix common/ includes.
9429 * nat/x86-linux-dregs.c: Fix common/ includes.
9430 * nat/x86-dregs.h: Fix common/ includes.
9431 * nat/x86-dregs.c: Fix common/ includes.
9432 * nat/ppc-linux.c: Fix common/ includes.
9433 * nat/mips-linux-watch.h: Fix common/ includes.
9434 * nat/mips-linux-watch.c: Fix common/ includes.
9435 * nat/linux-waitpid.c: Fix common/ includes.
9436 * nat/linux-ptrace.h: Fix common/ includes.
9437 * nat/linux-ptrace.c: Fix common/ includes.
9438 * nat/linux-procfs.c: Fix common/ includes.
9439 * nat/linux-personality.c: Fix common/ includes.
9440 * nat/linux-osdata.c: Fix common/ includes.
9441 * nat/linux-namespaces.c: Fix common/ includes.
9442 * nat/linux-btrace.h: Fix common/ includes.
9443 * nat/linux-btrace.c: Fix common/ includes.
9444 * nat/fork-inferior.c: Fix common/ includes.
9445 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9446 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9447 * nat/aarch64-linux.c: Fix common/ includes.
9448 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9449 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9450 * namespace.h: Fix common/ includes.
9451 * mips-linux-tdep.c: Fix common/ includes.
9452 * minsyms.c: Fix common/ includes.
9453 * mi/mi-parse.h: Fix common/ includes.
9454 * mi/mi-main.c: Fix common/ includes.
9455 * mi/mi-cmd-env.c: Fix common/ includes.
9456 * memrange.h: Fix common/ includes.
9457 * memattr.c: Fix common/ includes.
9458 * maint.h: Fix common/ includes.
9459 * maint.c: Fix common/ includes.
9460 * main.c: Fix common/ includes.
9461 * machoread.c: Fix common/ includes.
9462 * location.c: Fix common/ includes.
9463 * linux-thread-db.c: Fix common/ includes.
9464 * linux-nat.c: Fix common/ includes.
9465 * linux-fork.c: Fix common/ includes.
9466 * inline-frame.c: Fix common/ includes.
9467 * infrun.c: Fix common/ includes.
9468 * inflow.c: Fix common/ includes.
9469 * inferior.h: Fix common/ includes.
9470 * inferior.c: Fix common/ includes.
9471 * infcmd.c: Fix common/ includes.
9472 * inf-ptrace.c: Fix common/ includes.
9473 * inf-child.c: Fix common/ includes.
9474 * ia64-linux-nat.c: Fix common/ includes.
9475 * i387-tdep.c: Fix common/ includes.
9476 * i386-tdep.c: Fix common/ includes.
9477 * i386-linux-tdep.c: Fix common/ includes.
9478 * i386-linux-nat.c: Fix common/ includes.
9479 * i386-go32-tdep.c: Fix common/ includes.
9480 * i386-fbsd-tdep.c: Fix common/ includes.
9481 * i386-fbsd-nat.c: Fix common/ includes.
9482 * guile/scm-type.c: Fix common/ includes.
9483 * guile/guile.c: Fix common/ includes.
9484 * go32-nat.c: Fix common/ includes.
9485 * gnu-nat.c: Fix common/ includes.
9486 * gdbthread.h: Fix common/ includes.
9487 * gdbarch-selftests.c: Fix common/ includes.
9488 * gdb_usleep.c: Fix common/ includes.
9489 * gdb_select.h: Fix common/ includes.
9490 * gdb_bfd.c: Fix common/ includes.
9491 * gcore.c: Fix common/ includes.
9492 * fork-child.c: Fix common/ includes.
9493 * findvar.c: Fix common/ includes.
9494 * fbsd-nat.c: Fix common/ includes.
9495 * event-top.c: Fix common/ includes.
9496 * event-loop.c: Fix common/ includes.
9497 * dwarf2read.c: Fix common/ includes.
9498 * dwarf2loc.c: Fix common/ includes.
9499 * dwarf2-frame.c: Fix common/ includes.
9500 * dwarf-index-cache.c: Fix common/ includes.
9501 * dtrace-probe.c: Fix common/ includes.
9502 * disasm-selftests.c: Fix common/ includes.
9503 * defs.h: Fix common/ includes.
9504 * csky-tdep.c: Fix common/ includes.
9505 * cp-valprint.c: Fix common/ includes.
9506 * cp-support.h: Fix common/ includes.
9507 * cp-support.c: Fix common/ includes.
9508 * corelow.c: Fix common/ includes.
9509 * completer.h: Fix common/ includes.
9510 * completer.c: Fix common/ includes.
9511 * compile/compile.c: Fix common/ includes.
9512 * compile/compile-loc2c.c: Fix common/ includes.
9513 * compile/compile-cplus-types.c: Fix common/ includes.
9514 * compile/compile-cplus-symbols.c: Fix common/ includes.
9515 * command.h: Fix common/ includes.
9516 * cli/cli-dump.c: Fix common/ includes.
9517 * cli/cli-cmds.c: Fix common/ includes.
9518 * charset.c: Fix common/ includes.
9519 * build-id.c: Fix common/ includes.
9520 * btrace.h: Fix common/ includes.
9521 * btrace.c: Fix common/ includes.
9522 * breakpoint.h: Fix common/ includes.
9523 * breakpoint.c: Fix common/ includes.
9525 (enum agent_op): Fix common/ includes.
9526 * ax-general.c (struct aop_map): Fix common/ includes.
9527 * ax-gdb.c: Fix common/ includes.
9528 * auxv.c: Fix common/ includes.
9529 * auto-load.c: Fix common/ includes.
9530 * arm-tdep.c: Fix common/ includes.
9531 * arch/riscv.c: Fix common/ includes.
9532 * arch/ppc-linux-common.c: Fix common/ includes.
9533 * arch/i386.c: Fix common/ includes.
9534 * arch/arm.c: Fix common/ includes.
9535 * arch/arm-linux.c: Fix common/ includes.
9536 * arch/arm-get-next-pcs.c: Fix common/ includes.
9537 * arch/amd64.c: Fix common/ includes.
9538 * arch/aarch64.c: Fix common/ includes.
9539 * arch/aarch64-insn.c: Fix common/ includes.
9540 * arch-utils.c: Fix common/ includes.
9541 * amd64-windows-tdep.c: Fix common/ includes.
9542 * amd64-tdep.c: Fix common/ includes.
9543 * amd64-sol2-tdep.c: Fix common/ includes.
9544 * amd64-obsd-tdep.c: Fix common/ includes.
9545 * amd64-nbsd-tdep.c: Fix common/ includes.
9546 * amd64-linux-tdep.c: Fix common/ includes.
9547 * amd64-linux-nat.c: Fix common/ includes.
9548 * amd64-fbsd-tdep.c: Fix common/ includes.
9549 * amd64-fbsd-nat.c: Fix common/ includes.
9550 * amd64-dicos-tdep.c: Fix common/ includes.
9551 * amd64-darwin-tdep.c: Fix common/ includes.
9552 * agent.c: Fix common/ includes.
9553 * ada-lang.h: Fix common/ includes.
9554 * ada-lang.c: Fix common/ includes.
9555 * aarch64-tdep.c: Fix common/ includes.
9557 2019-01-25 Tom Tromey <tom@tromey.com>
9559 * common/create-version.sh: Use common/version.h.
9561 2019-01-24 Pedro Alves <palves@redhat.com>
9563 * infrun.c (signal_stop, signal_print, signal_program)
9564 (signal_catch, signal_pass): Now arrays instead of pointers.
9565 (update_signals_program_target, do_target_resume)
9566 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9567 * linux-nat.c (linux_nat_target::pass_signals)
9568 (linux_nat_target::create_inferior, linux_nat_target::attach):
9570 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9571 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9572 * procfs.c (procfs_target::pass_signals): Adjust.
9573 * record-full.c (record_full_target::resume): Adjust.
9574 * remote.c (remote_target::pass_signals)
9575 (remote_target::program_signals): Adjust.
9576 * target-debug.h (target_debug_print_signals): Now takes a
9577 gdb::array_view as parameter. Adjust.
9578 * target.h (target_ops) <pass_signals, program_signals>: Replace
9579 pointer and length parameters with gdb::array_view.
9580 (target_pass_signals, target_program_signals): Likewise.
9581 * target-delegates.c: Regenerate.
9583 2019-01-24 Pedro Alves <palves@redhat.com>
9585 * common/forward-scope-exit.h
9586 (forward_scope_exit::forward_scope_exit): Pass arguments to
9587 m_bind_function directly, instead of creating a std::bind and
9590 2019-01-24 Alan Hayward <alan.hayward@arm.com>
9592 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9594 (pass_in_v_vfp_candidate): Likewise.
9596 2019-01-23 Tom Tromey <tom@tromey.com>
9597 Pedro Alves <palves@redhat.com>
9599 * regcache.c (class regcache_invalidator): Remove.
9600 (regcache::raw_write): Use make_scope_exit.
9602 2019-01-23 Tom Tromey <tom@tromey.com>
9604 * ui-out.h (class ui_out_emit_type): Update comment.
9606 2019-01-23 Tom Tromey <tom@tromey.com>
9608 * infrun.c (fetch_inferior_event): Update comment.
9610 2019-01-23 Tom Tromey <tom@tromey.com>
9611 Pedro Alves <palves@redhat.com>
9613 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9615 (fetch_inferior_event): Use SCOPE_EXIT.
9618 2019-01-23 Tom Tromey <tom@tromey.com>
9619 Pedro Alves <palves@redhat.com>
9621 * infrun.c (disable_thread_events): Delete.
9622 (stop_all_threads): Use SCOPE_EXIT.
9624 2019-01-23 Tom Tromey <tom@tromey.com>
9625 Pedro Alves <palves@redhat.com>
9627 * symfile.c: Include forward-scope-exit.h.
9628 (clear_symtab_users_cleanup): Replace forward declaration with
9629 a FORWARD_SCOPE_EXIT.
9630 (syms_from_objfile_1): Use the forward_scope_exit and
9631 gdb::optional instead of cleanup_function.
9632 (reread_symbols): Use the forward_scope_exit instead of
9634 (clear_symtab_users_cleanup): Remove function.
9636 2019-01-23 Tom Tromey <tom@tromey.com>
9637 Pedro Alves <palves@redhat.com>
9639 * linux-nat.c: Include scope-exit.h.
9640 (cleanup_target_stop): Remove.
9641 (linux_nat_target::static_tracepoint_markers_by_strid): Use
9644 2019-01-23 Tom Tromey <tom@tromey.com>
9645 Pedro Alves <palves@redhat.com>
9647 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9648 (call_function_by_hand_dummy): Use SCOPE_EXIT.
9650 2019-01-23 Tom Tromey <tom@tromey.com>
9651 Andrew Burgess <andrew.burgess@embecosm.com>
9652 Pedro Alves <palves@redhat.com>
9654 * infrun.c (fetch_inferior_event): Use scope_exit.
9655 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9656 * top.c (execute_command): Use scope_exit.
9657 * breakpoint.c (bpstat_do_actions): Use scope_exit.
9658 * utils.c (do_bpstat_clear_actions_cleanup)
9659 (make_bpstat_clear_actions_cleanup): Remove.
9661 2019-01-23 Tom Tromey <tom@tromey.com>
9662 Pedro Alves <palves@redhat.com>
9664 * infrun.c: Include "common/scope-exit.h"
9665 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9666 (wait_for_inferior): Use SCOPE_EXIT.
9667 (fetch_inferior_event): Use scope_exit.
9669 2019-01-23 Tom Tromey <tom@tromey.com>
9670 Pedro Alves <palves@redhat.com>
9672 * breakpoint.c (create_breakpoint): Remove cleanup.
9674 2019-01-23 Tom Tromey <tom@tromey.com>
9675 Andrew Burgess <andrew.burgess@embecosm.com>
9676 Pedro Alves <palves@redhat.com>
9678 2019-01-23 Pedro Alves <palves@redhat.com>
9680 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9682 2019-01-23 Pedro Alves <palves@redhat.com>
9683 Andrew Burgess <andrew.burgess@embecosm.com>
9685 * gdbthread.h: Include "common/forward-scope-exit.h".
9686 (scoped_finish_thread_state): Redefine custom class in terms of
9689 2019-01-23 Pedro Alves <palves@redhat.com>
9690 Andrew Burgess <andrew.burgess@embecosm.com>
9692 * common/forward-scope-exit.h: New file.
9694 2019-01-23 Pedro Alves <palves@redhat.com>
9695 Andrew Burgess <andrew.burgess@embecosm.com>
9696 Tom Tromey <tom@tromey.com>
9698 * common/scope-exit.h: New file.
9700 2019-01-23 Pedro Alves <palves@redhat.com>
9702 * common/preprocessor.h (ESC): Rename to ...
9703 (ESC_PARENS): ... this.
9704 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9705 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9707 2019-01-23 Tom Tromey <tom@tromey.com>
9709 * language.h (class scoped_switch_to_sym_language_if_auto):
9710 Initialize m_lang in both cases.
9712 2019-01-23 Alan Hayward <alan.hayward@arm.com>
9714 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9717 2019-01-22 Tom Tromey <tom@tromey.com>
9719 * corelow.c: Do not include sys/file.h.
9721 2019-01-22 Tom Tromey <tom@tromey.com>
9723 * tui/tui-wingeneral.h: Include gdb_curses.h.
9725 2019-01-22 Tom Tromey <tom@tromey.com>
9727 * source-cache.h (class source_cache) <get_source_lines,
9728 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9730 2019-01-22 Tom Tromey <tom@tromey.com>
9732 * remote-fileio.h (struct remote_target): Declare.
9734 2019-01-22 Tom Tromey <tom@tromey.com>
9736 * python/py-arch.c: Do not include py-ref.h.
9737 * python/py-bpevent.c: Do not include py-ref.h.
9738 * python/py-cmd.c: Do not include py-ref.h.
9739 * python/py-continueevent.c: Do not include py-ref.h.
9740 * python/py-event.h: Do not include py-ref.h.
9741 * python/py-evtregistry.c: Do not include py-ref.h.
9742 * python/py-finishbreakpoint.c: Do not include py-ref.h.
9743 * python/py-frame.c: Do not include py-ref.h.
9744 * python/py-framefilter.c: Do not include py-ref.h.
9745 * python/py-function.c: Do not include py-ref.h.
9746 * python/py-infevents.c: Do not include py-ref.h.
9747 * python/py-linetable.c: Do not include py-ref.h.
9748 * python/py-objfile.c: Do not include py-ref.h.
9749 * python/py-param.c: Do not include py-ref.h.
9750 * python/py-prettyprint.c: Do not include py-ref.h.
9751 * python/py-progspace.c: Do not include py-ref.h.
9752 * python/py-symbol.c: Do not include py-ref.h.
9753 * python/py-symtab.c: Do not include py-ref.h.
9754 * python/py-type.c: Do not include py-ref.h.
9755 * python/py-unwind.c: Do not include py-ref.h.
9756 * python/py-utils.c: Do not include py-ref.h.
9757 * python/py-value.c: Do not include py-ref.h.
9758 * python/py-varobj.c: Do not include py-ref.h.
9759 * python/py-xmethods.c: Do not include py-ref.h.
9760 * python/python.c: Do not include py-ref.h.
9761 * varobj.c: Do not include py-ref.h.
9763 2019-01-22 Tom Tromey <tom@tromey.com>
9765 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9768 2019-01-22 Tom Tromey <tom@tromey.com>
9770 * compile/compile-cplus-types.c: Remove a comment by #include.
9772 2019-01-22 Tom Tromey <tom@tromey.com>
9774 * compile/gcc-c-plugin.h: Include compile-internal.h.
9776 2019-01-22 Tom Tromey <tom@tromey.com>
9778 * stabsread.c (EXTERN): Do not define.
9779 (symnum, next_symbol_text_func, processing_gcc_compilation)
9780 (within_function, global_sym_chain, global_stabs)
9781 (previous_stab_code, this_object_header_files)
9782 (n_this_object_header_files)
9783 (n_allocated_this_object_header_files): Define.
9784 * stabsread.h (EXTERN): Never define. Use "extern".
9786 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9788 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9791 2019-01-21 Tom Tromey <tom@tromey.com>
9793 * ui-out.c: Fix includes.
9794 * tui/tui-source.c: Fix includes.
9795 * target.c: Fix includes.
9796 * remote.c: Fix includes.
9797 * regcache.c: Fix includes.
9798 * python/py-block.c: Fix includes.
9799 * printcmd.c: Fix includes.
9800 * or1k-tdep.c: Fix includes.
9801 * mi/mi-main.c: Fix includes.
9802 * m32r-tdep.c: Fix includes.
9803 * csky-tdep.c: Fix includes.
9804 * compile/compile-cplus-types.c: Fix includes.
9805 * cli/cli-interp.c: Fix includes.
9807 2019-01-21 Alan Hayward <alan.hayward@arm.com>
9809 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9812 2019-01-16 Tom Tromey <tom@tromey.com>
9814 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
9816 (struct objfile) <msymbols_range>: Move from top level.
9817 <msymbols>: New method.
9818 (class objfile_msymbols): Remove.
9819 * symtab.c (default_collect_symbol_completion_matches_break_on):
9821 * symmisc.c (dump_msymbols): Update.
9822 * stabsread.c (scan_file_globals): Update.
9823 * objc-lang.c (info_selectors_command, info_classes_command)
9824 (find_methods): Update.
9825 * minsyms.c (find_solib_trampoline_target): Update.
9826 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9827 * coffread.c (coff_symfile_read): Update.
9828 * ada-lang.c (ada_lookup_simple_minsym)
9829 (ada_collect_symbol_completion_matches): Update.
9831 2019-01-16 Tom Tromey <tom@tromey.com>
9833 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9834 type. Remove no-argument constructor.
9835 <iterator::operator++>: Simplify.
9837 <end>: Use minimal_symbol_count.
9839 2019-01-16 Tom Tromey <tom@tromey.com>
9841 * objfiles.h (struct objfile) <psymtabs>: New method.
9842 (class objfile_psymtabs): Remove.
9843 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9845 <range>: New method.
9846 (require_partial_symbols): Change return type.
9847 * psymtab.c (require_partial_symbols)
9848 (psym_expand_symtabs_matching): Update.
9849 * mdebugread.c (parse_partial_symbols): Update.
9850 * dbxread.c (dbx_end_psymtab): Update.
9852 2019-01-15 Tom Tromey <tom@tromey.com>
9854 * symtab.c (lookup_objfile_from_block)
9855 (lookup_symbol_in_objfile_symtabs)
9856 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9857 (find_line_symtab, info_sources_command)
9858 (default_collect_symbol_completion_matches_break_on)
9859 (make_source_files_completion_list): Update.
9860 * symmisc.c (print_objfile_statistics, dump_objfile)
9861 (maintenance_print_symbols, maintenance_info_symtabs)
9862 (maintenance_check_symtabs, maintenance_info_line_tables):
9864 * source.c (select_source_symtab)
9865 (forget_cached_source_info_for_objfile): Update.
9866 * objfiles.h (class objfile_compunits): Remove.
9867 (struct objfile) <compunits_range>: New typedef.
9868 (compunits): New method.
9869 * objfiles.c (objfile_relocate1): Update.
9870 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9871 * maint.c (count_symtabs_and_blocks): Update.
9872 * linespec.c (iterate_over_all_matching_symtabs): Update.
9873 * cp-support.c (add_symbol_overload_list_qualified): Update.
9874 * coffread.c (coff_symtab_read): Update.
9875 * ada-lang.c (add_nonlocal_symbols)
9876 (ada_collect_symbol_completion_matches)
9877 (ada_add_global_exceptions): Update.
9879 2019-01-15 Tom Tromey <tom@tromey.com>
9881 * progspace.h (program_space) <objfiles_safe_range>: New
9883 <objfiles_safe>: New method.
9884 * objfiles.h (class all_objfiles_safe): Remove.
9885 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9886 * jit.c (jit_inferior_exit_hook): Update.
9888 2019-01-17 Tom Tromey <tom@tromey.com>
9890 * progspace.h (program_space) <objfiles_range>: New typedef.
9891 <objfiles>: New method.
9892 <objfiles_head>: Rename from objfiles.
9893 (object_files): Update.
9894 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9895 * guile/scm-pretty-print.c
9896 (ppscm_find_pretty_printer_from_objfiles): Update.
9897 * guile/scm-objfile.c (gdbscm_objfiles): Update.
9898 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9900 * python/py-progspace.c (pspy_get_objfiles): Update.
9901 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9903 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9904 (objfpy_lookup_objfile_by_build_id): Update.
9905 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9906 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9908 * symtab.c (iterate_over_symtabs, matching_obj_sections)
9909 (expand_symtab_containing_pc, lookup_objfile_from_block)
9910 (lookup_static_symbol, basic_lookup_transparent_type)
9911 (find_pc_sect_compunit_symtab, find_symbol_at_address)
9912 (find_line_symtab, info_sources_command)
9913 (default_collect_symbol_completion_matches_break_on)
9914 (make_source_files_completion_list, find_main_name): Update.
9915 * symmisc.c (print_symbol_bcache_statistics)
9916 (print_objfile_statistics, maintenance_print_symbols)
9917 (maintenance_print_msymbols, maintenance_print_objfiles)
9918 (maintenance_info_symtabs, maintenance_check_symtabs)
9919 (maintenance_expand_symtabs, maintenance_info_line_tables):
9921 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9922 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9923 (map_overlay_command, unmap_overlay_command)
9924 (simple_overlay_update, expand_symtabs_matching)
9925 (map_symbol_filenames): Update.
9926 * symfile-debug.c (set_debug_symfile): Update.
9927 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9929 * source.c (select_source_symtab, forget_cached_source_info):
9931 * solib.c (solib_read_symbols): Update.
9932 * solib-spu.c (append_ocl_sos): Update.
9933 * psymtab.c (maintenance_print_psymbols)
9934 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9935 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9936 * printcmd.c (info_symbol_command): Update.
9937 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9939 * objfiles.h (class all_objfiles): Remove.
9940 * objfiles.c (have_partial_symbols, have_full_symbols)
9941 (have_minimal_symbols, qsort_cmp, update_section_map)
9942 (shared_objfile_contains_address_p)
9943 (default_iterate_over_objfiles_in_search_order): Update.
9944 * objc-lang.c (info_selectors_command, info_classes_command)
9945 (find_methods): Update.
9946 * minsyms.c (find_solib_trampoline_target): Update.
9947 * maint.c (maintenance_info_sections)
9948 (maintenance_translate_address, count_symtabs_and_blocks):
9950 * main.c (captured_main_1): Update.
9951 * linux-thread-db.c (try_thread_db_load_from_pdir)
9952 (has_libpthread): Update.
9953 * linespec.c (iterate_over_all_matching_symtabs)
9954 (search_minsyms_for_name): Update.
9955 * jit.c (jit_find_objf_with_entry_addr): Update.
9956 * hppa-tdep.c (find_unwind_entry)
9957 (hppa_lookup_stub_minimal_symbol): Update.
9958 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9960 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9961 (elf_gnu_ifunc_resolve_by_got): Update.
9962 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9963 * dwarf-index-write.c (save_gdb_index_command): Update.
9964 * cp-support.c (add_symbol_overload_list_qualified): Update.
9965 * breakpoint.c (create_overlay_event_breakpoint)
9966 (create_longjmp_master_breakpoint)
9967 (create_std_terminate_master_breakpoint)
9968 (create_exception_master_breakpoint): Update.
9969 * blockframe.c (find_pc_partial_function): Update.
9970 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9971 (ada_collect_symbol_completion_matches)
9972 (ada_add_global_exceptions): Update.
9974 2019-01-17 Tom Tromey <tom@tromey.com>
9976 * solib-target.c (lm_info_target_p): Remove typedef. Don't
9978 (solib_target_parse_libraries): Change return type.
9979 (library_list_start_segment, library_list_start_section)
9980 (library_list_end_library, library_list_start_library); Update.
9981 (solib_target_free_library_list): Remove.
9982 (solib_target_parse_libraries): Remove cleanup. Change return
9984 (solib_target_current_sos): Update.
9986 2019-01-17 Tom Tromey <tromey@bapiya>
9988 * valprint.c: Replace "the the" with "the".
9989 * symtab.c: Replace "the the" with "the".
9990 * solib.c: Replace "the the" with "the".
9991 * solib-dsbt.c: Replace "the the" with "the".
9992 * linespec.c: Replace "the the" with "the".
9993 * dwarf2loc.h: Replace "the the" with "the".
9994 * amd64-windows-tdep.c: Replace "the the" with "the".
9995 * aarch64-tdep.c: Replace "the the" with "the".
9997 2019-01-16 Keith Seitz <keiths@redhat.com>
10000 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10001 <builder>: Rename to ..
10002 <m_builder>: ... this and make private.
10003 (dwarf2_cu::get_builder): New method. Change all users of
10004 `builder' to use this method.
10005 (dwarf2_start_symtab): Move to ...
10006 (dwarf2_cu::start_symtab): ... here. Update all callers
10007 (setup_type_unit_groups): Move to ...
10008 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10010 (dwarf2_cu::reset_builder): New method.
10011 (process_full_compunit, process_full_type_unit): Use
10012 dwarf2_cu::reset_builder.
10013 (follow_die_offset): Record the ancestor CU if it is different
10014 from the followed DIE's CU.
10015 (follow_die_sig_1): Likewise.
10017 2019-01-15 Tom Tromey <tom@tromey.com>
10019 * remote.c (class remote_state) <buf>: Now a char_vector.
10020 <buf_size>: Remove.
10021 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10023 (remote_target::getpkt_or_notif_sane_1)
10024 (remote_target::getpkt_sane)
10025 (remote_target::getpkt_or_notif_sane): Likewise.
10026 (class remote_target) <putpkt>: New overload.
10027 (remote_target::read_frame): Change type of "buf_p". Remove
10028 sizeof_p parameter.
10029 (packet_ok): New overload.
10030 (packet_check_result): New overload.
10033 2019-01-14 Tom Tromey <tom@tromey.com>
10035 * remote-notif.c (handle_notification, remote_notif_ack)
10036 (remote_notif_parse): Make "buf" const.
10037 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10039 (remote_notif_parse, remote_notif_ack, handle_notification):
10041 * remote.c (remote_notif_stop_parse): Make "buf" const.
10042 (remote_target::remote_parse_stop_reply): Make "buf" const.
10043 (remote_notif_stop_ack): Make "buf" const.
10045 2019-01-14 Tom Tromey <tom@tromey.com>
10047 * remote.c (remote_console_output): Make parameter const.
10049 2019-01-14 Tom Tromey <tom@tromey.com>
10051 * target-debug.h (target_debug_print_signals): Constify.
10052 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10053 * procfs.c (procfs_target::pass_signals): Update.
10054 * linux-nat.c (linux_nat_target::pass_signals): Update.
10055 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10056 * target-delegates.c: Rebuild.
10057 * remote.c (remote_target::program_signals): Update.
10058 (remote_target::pass_signals): Update.
10059 * target.c (target_pass_signals): Constify argument.
10060 (target_program_signals): Likewise.
10061 * target.h (struct target_ops) <pass_signals, program_signals>:
10063 (target_pass_signals, target_program_signals): Constify argument.
10065 2019-01-14 Tom Tromey <tom@tromey.com>
10068 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10070 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10072 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10074 * rs6000-tdep.c: Include reggroups.h.
10075 (IS_V_ALIAS_PSEUDOREG): Define.
10076 (rs6000_register_name): Return names for the "vX" aliases.
10077 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10078 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10079 aliases. Call default_register_reggroup_p for all other
10081 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10083 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10084 Handle "vX" aliases.
10085 (v_alias_pseudo_register_collect): New function.
10086 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10087 (rs6000_gdbarch_init): Initialize "vX" aliases as
10088 pseudo-registers. Restore registration of
10089 rs6000_pseudo_register_reggroup_p with
10090 set_tdesc_pseudo_register_reggroup_p.
10092 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10094 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10095 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10096 set_gdbarch_num_pseudo_regs.
10098 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10100 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10101 Remove arg prefixname, add do_set and do_show.
10102 Add member functions set_list and show_list.
10103 * cli/cli-style.c (class cli_style_option): Update accordingly.
10104 (style_set_list): Move to file scope.
10105 (style_show_list): Likewise.
10106 (set_style): Call help_list.
10107 (show_style): Call cmd_show_list.
10108 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10109 Update to use the new macro.
10111 2019-10-12 Joel Brobecker <brobecker@adacore.com>
10113 * ada-lang.c (_initialize_ada_language): Expand the help text
10114 for the "catch exception" command.
10116 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10118 * symtab.c (matching_obj_sections): Initialize obj,
10119 declare it closer to its usage.
10121 2019-01-10 Tom Tromey <tom@tromey.com>
10123 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10124 (basic_inf_threads_range): Remove.
10125 (inf_threads_range, inf_non_exited_threads_range)
10126 (safe_inf_threads_range): Use next_adapter.
10128 2019-01-10 Keith Seitz <keiths@redhat.com>
10132 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10133 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10135 2019-01-10 Keith Seitz <keiths@redhat.com>
10139 * dictionary.c (pending_to_vector): Remove.
10140 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10141 Remove _1 suffix, replacing functions of the same name. Update
10143 (dict_create_hashed, dict_create_hashed_expandable)
10144 (dict_create_linear, dict_create_linear_expandable, dict_free)
10145 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10146 Make functions static.
10148 2019-01-10 Keith Seitz <keiths@redhat.com>
10152 * dictionary.h (struct dictionary): Replace declaration with
10154 (dict_create_hashed, dict_create_hashed_expandable)
10155 (dict_create_linear, dict_create_linear_expandable)
10156 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10157 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10158 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10159 taking multidictionary argument.
10160 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10161 * block.h (struct block) <dict>: Change to multidictionary
10162 and rename `multidict'.
10163 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10164 symmisc.c: Update all dictionary references to multidictionary.
10166 2019-01-10 Keith Seitz <keiths@redhat.com>
10170 * dictionary.c: Include unordered_map.
10171 (pending_to_vector): New function.
10172 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10173 Rewrite the non-"_1" functions to take vector instead
10175 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10176 "new" _1 versions of the same name.
10177 (multidictionary): Define.
10178 (std::hash<enum language): New definition.
10179 (collate_pending_symbols_by_language, mdict_create_hashed)
10180 (mdict_create_hashed_expandable, mdict_create_linear)
10181 (mdict_create_linear_expandable, mdict_free)
10182 (find_language_dictionary, create_new_language_dictionary)
10183 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10184 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10185 (mdict_size, mdict_empty): New functions.
10186 * dictionary.h (mdict_iterator): Define.
10188 2019-01-10 Pedro Alves <palves@redhat.com>
10190 * breakpoint.c (read_uploaded_action)
10191 (create_tracepoint_from_upload): Adjust to use
10192 gdb::unique_xmalloc_ptr.
10193 * ctf.c (ctf_write_uploaded_tp):
10194 (SET_ARRAY_FIELD): Use emplace_back.
10195 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10196 * tracefile-tfile.c (tfile_write_uploaded_tp):
10197 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10198 gdb::unique_xmalloc_ptr.
10199 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10200 at_string, cond_string, cmd_strings>: Replace char pointers
10201 with gdb::unique_xmalloc_ptr.
10203 2019-01-10 Pedro Alves <palves@redhat.com>
10205 * solib-target.c (library_list_start_library): Don't xstrdup name.
10207 2019-01-10 Pedro Alves <palves@redhat.com>
10209 * mdebugread.c (parse_partial_symbols): Use
10210 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10212 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10214 * linux-fork.c (scoped_switch_fork_info)
10215 <~scoped_switch_fork_info>: Fix incorrect variable name.
10217 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10219 * linux-fork.c (scoped_switch_fork_info)
10220 <scoped_switch_fork_info>: Make explicit.
10221 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10223 2019-01-10 Tom Tromey <tom@tromey.com>
10225 * objfiles.h (objfile::reset_psymtabs): Update.
10226 * objfiles.c (objfile::objfile): Update.
10227 * psymtab.h (psymtab_storage::obstack): Update.
10228 (psymtab_storage::m_obstack): Use gdb::optional.
10229 (class psymtab_storage): Update comment. Remove objfile
10231 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10233 2019-01-10 Tom Tromey <tom@tromey.com>
10235 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10236 <free_psymtabs>: Now private.
10237 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10238 (allocate_psymtab): Use new method.
10240 2019-01-10 Tom Tromey <tom@tromey.com>
10242 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10243 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10244 * mdebugread.c (parse_partial_symbols): Use
10245 allocate_dependencies.
10246 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10247 allocate_dependencies.
10248 (process_psymtab_comp_unit_reader)
10249 (build_type_psymtab_dependencies): Likewise.
10250 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10252 2019-01-10 Tom Tromey <tom@tromey.com>
10254 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10255 PSYMBOL_SET_LANGUAGE.
10256 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10258 2019-01-10 Tom Tromey <tom@tromey.com>
10260 * psymtab.h (psymtab_storage::obstack): New method.
10261 <m_obstack>: Rename from obstack; now private.
10262 * psymtab.c (psymtab_storage): Update.
10263 * dwarf2read.c (create_addrmap_from_index)
10264 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10267 2019-01-10 Tom Tromey <tom@tromey.com>
10269 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10270 * objfiles.h (objfile::reset_psymtabs): New method.
10272 2019-01-10 Tom Tromey <tom@tromey.com>
10274 * symmisc.c (print_symbol_bcache_statistics): Update.
10275 (print_objfile_statistics): Update.
10276 * symfile.c (reread_symbols): Update.
10277 * psymtab.h (class psymtab_storage): New.
10278 * psymtab.c (psymtab_storage): New constructor.
10279 (~psymtab_storage): New destructor.
10280 (require_partial_symbols): Update.
10281 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10282 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10283 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10284 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10285 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10286 (start_psymtab_common, end_psymtab_common)
10287 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10288 (allocate_psymtab): Update.
10289 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10291 (dump_psymtab_addrmap, maintenance_print_psymbols)
10292 (maintenance_check_psymtabs): Update.
10293 (class objfile_psymtabs): Move to objfiles.h.
10294 * psympriv.h (discard_psymtab): Now inline.
10295 (psymtab_discarder::psymtab_discarder): Update.
10296 (psymtab_discarder::~psymtab_discarder): Update.
10297 (ALL_OBJFILE_PSYMTABS): Rewrite.
10298 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10299 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10301 <partial_symtabs>: New field.
10302 (class objfile_psymtabs): Move from psymtab.h. Update.
10303 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10305 (objfile::~objfile): Don't destroy psymbol_cache.
10306 * mdebugread.c (parse_partial_symbols): Update.
10307 * dwarf2read.c (create_addrmap_from_index)
10308 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10309 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10310 (add_partial_subprogram, dwarf2_ranges_read): Update.
10311 * dwarf-index-write.c (write_address_map)
10312 (write_one_signatured_type, recursively_write_psymbols)
10313 (class debug_names, class debug_names, write_psymtabs_to_index):
10316 2019-01-10 Tom Tromey <tom@tromey.com>
10318 * symtab.h (SYMBOL_SET_NAMES): Update.
10319 (symbol_set_names): Update.
10320 (MSYMBOL_SET_NAMES): Update.
10321 * symtab.c (symbol_set_names): Change argument to be an
10322 objfile_per_bfd_storage.
10323 * psymtab.c (add_psymbol_to_bcache): Update.
10324 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10326 2019-01-10 Tom Tromey <tom@tromey.com>
10328 * symtab.c (create_demangled_names_hash): Change argument to be an
10329 objfile_per_bfd_storage.
10330 (symbol_set_names): Update.
10332 2019-01-10 Tom Tromey <tom@tromey.com>
10334 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10336 * psymtab.c (init_psymbol_list): Do nothing if already called.
10337 * psympriv.h (init_psymbol_list): Add comment.
10338 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10340 * dbxread.c (dbx_symfile_read): Unconditionally call
10343 2019-01-10 Tom Tromey <tom@tromey.com>
10345 * xcoffread.c (scan_xcoff_symtab): Update.
10346 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10348 * mdebugread.c (parse_partial_symbols)
10349 (handle_psymbol_enumerators): Update.
10350 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10351 * dbxread.c (read_dbx_symtab): Update.
10352 * psympriv.h (psymbol_placement): New enum.
10353 (add_psymbol_to_list): Update.
10355 2019-01-10 Tom Tromey <tom@tromey.com>
10357 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10358 static_psymbols parameters.
10359 (scan_xcoff_symtab): Update.
10360 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10361 static_psymbols parameters.
10362 * psympriv.h (start_psymtab_common): Update.
10363 * mdebugread.c (parse_partial_symbols): Update.
10364 * dwarf2read.c (create_partial_symtab): Update.
10365 * dbxread.c (read_dbx_symtab): Update.
10366 (start_psymtab): Remove global_psymbols and static_psymbols
10369 2019-01-10 Tom Tromey <tom@tromey.com>
10371 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10372 * psymtab.c (allocate_psymtab): Add comment.
10373 * psympriv.h (allocate_psymtab): Add comment.
10374 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10376 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10378 2019-01-10 Tom Tromey <tom@tromey.com>
10380 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10382 * mipsread.c: Include mdebugread.h.
10383 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10385 * elfread.c: Include mdebugread.h.
10387 2019-01-09 Tom Tromey <tom@tromey.com>
10389 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10390 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10391 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10392 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10393 (psym_lookup_symbol, psym_find_last_source_symtab)
10394 (psym_forget_cached_source_info, psym_print_stats)
10395 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10396 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10397 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10398 (psym_find_compunit_symtab_by_address)
10399 (maintenance_print_psymbols, maintenance_info_psymtabs)
10400 (maintenance_check_psymtabs): Use ranged for.
10401 * psymtab.h (class objfile_psymtabs): New.
10402 (require_partial_symbols): Return objfile_psymtabs.
10403 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10405 2019-01-09 Tom Tromey <tom@tromey.com>
10407 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10408 (find_pc_mapped_section, list_overlays_command)
10409 (map_overlay_command, unmap_overlay_command)
10410 (simple_overlay_update): Use all_objfiles.
10411 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10412 * printcmd.c (info_symbol_command): Use all_objfiles.
10413 * objfiles.h (ALL_OBJSECTIONS): Remove.
10414 * maint.c (maintenance_translate_address): Use all_objfiles.
10415 * gcore.c (gcore_create_callback): Use all_objfiles.
10416 (objfile_find_memory_regions): Likewise.
10418 2019-01-09 Tom Tromey <tom@tromey.com>
10420 * symtab.c (find_line_symtab, info_sources_command)
10421 (make_source_files_completion_list): Use objfile_compunits.
10422 * source.c (select_source_symtab): Use objfile_compunits.
10423 * objfiles.h (struct objfile): Update comment.
10424 (ALL_OBJFILES): Remove.
10425 (ALL_FILETABS): Remove.
10426 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10429 2019-01-09 Tom Tromey <tom@tromey.com>
10431 * symmisc.c (print_objfile_statistics, dump_objfile)
10432 (maintenance_print_symbols): Use compunit_filetabs.
10433 * source.c (forget_cached_source_info_for_objfile): Use
10435 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10436 (ALL_FILETABS): Use compunit_filetabs.
10437 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10438 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10440 2019-01-09 Tom Tromey <tom@tromey.com>
10442 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10443 (compunit_filetabs): New.
10444 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10446 (info_sources_command, make_source_files_completion_list): Remove
10448 * symmisc.c (print_objfile_statistics, dump_objfile)
10449 (maintenance_print_symbols): Remove declaration.
10450 (maintenance_info_symtabs): Use compunit_filetabs.
10451 (maintenance_info_line_tables): Likewise.
10452 * source.c (select_source_symtab): Change local variable name.
10453 (forget_cached_source_info_for_objfile): Remove declaration.
10454 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10455 * objfiles.c (objfile_relocate1): Remove declaration.
10456 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10458 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10459 * coffread.c (coff_symtab_read): Remove declaration.
10460 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10463 2019-01-09 Tom Tromey <tom@tromey.com>
10465 * symtab.c (lookup_objfile_from_block)
10466 (find_pc_sect_compunit_symtab, search_symbols)
10467 (default_collect_symbol_completion_matches_break_on): Use
10469 * objfiles.h (ALL_COMPUNITS): Remove.
10470 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10471 * cp-support.c (add_symbol_overload_list_qualified): Use
10473 * ada-lang.c (ada_collect_symbol_completion_matches)
10474 (ada_add_global_exceptions): Use objfile_compunits.
10476 2019-01-09 Tom Tromey <tom@tromey.com>
10478 * source.c (select_source_symtab)
10479 (forget_cached_source_info_for_objfile): Remove declaration.
10480 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10482 * maint.c (count_symtabs_and_blocks): Remove declaration.
10483 * cp-support.c (add_symbol_overload_list_qualified): Remove
10485 * coffread.c (coff_symtab_read): Remove declaration.
10486 * symtab.c (lookup_symbol_in_objfile_symtabs)
10487 (basic_lookup_transparent_type_1): Use objfile_compunits.
10488 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10489 (info_sources_command, search_symbols)
10490 (default_collect_symbol_completion_matches_break_on)
10491 (make_source_files_completion_list): Remove declaration.
10492 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10493 (ada_collect_symbol_completion_matches)
10494 (ada_add_global_exceptions): Remove declaration.
10495 * linespec.c (iterate_over_all_matching_symtabs): Use
10497 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10498 (class objfile_compunits): New.
10499 (ALL_COMPUNITS): Use objfile_compunits.
10500 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10501 (maintenance_check_symtabs, maintenance_info_line_tables): Use
10503 * objfiles.c (objfile_relocate1): Use objfile_compunits.
10505 2019-01-09 Tom Tromey <tom@tromey.com>
10507 * symtab.c (search_symbols)
10508 (default_collect_symbol_completion_matches_break_on): Use
10510 * ada-lang.c (ada_lookup_simple_minsym)
10511 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10512 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10513 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10515 * coffread.c (coff_symfile_read): Use objfile_msymbols.
10516 * symmisc.c (dump_msymbols): Use objfile_msymbols.
10517 * objc-lang.c (find_methods): Use objfile_msymbols.
10518 (info_selectors_command, info_classes_command): Likewise.
10519 * stabsread.c (scan_file_globals): Use objfile_msymbols.
10520 * objfiles.h (class objfile_msymbols): New.
10521 (ALL_OBJFILE_MSYMBOLS): Remove.
10522 (ALL_MSYMBOLS): Remove.
10524 2019-01-09 Tom Tromey <tom@tromey.com>
10526 * common/next-iterator.h (next_adapter): Add Iterator template
10528 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10529 (class all_objfiles_safe): New.
10530 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10531 * objfiles.c (put_objfile_before): Update comment.
10532 (add_separate_debug_objfile): Likewise.
10533 (free_all_objfiles): Use all_objfiles_safe.
10534 (objfile_purge_solibs): Likewise.
10536 2019-01-09 Tom Tromey <tom@tromey.com>
10538 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10539 (expand_symtab_containing_pc, lookup_static_symbol)
10540 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10541 (find_symbol_at_address, find_line_symtab, find_main_name): Use
10543 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10544 * breakpoint.c (create_overlay_event_breakpoint)
10545 (create_longjmp_master_breakpoint)
10546 (create_std_terminate_master_breakpoint)
10547 (create_exception_master_breakpoint): Use all_objfiles.
10548 * linux-thread-db.c (try_thread_db_load_from_pdir)
10549 (has_libpthread): Use all_objfiles.
10550 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10551 * linespec.c (iterate_over_all_matching_symtabs)
10552 (search_minsyms_for_name): Use all_objfiles.
10553 * maint.c (maintenance_info_sections): Use all_objfiles.
10554 * main.c (captured_main_1): Use all_objfiles.
10555 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10556 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10557 * guile/scm-pretty-print.c
10558 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10559 * solib-spu.c (append_ocl_sos): Use all_objfiles.
10560 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10561 (maintenance_print_msymbols): Use all_objfiles.
10562 * source.c (select_source_symtab): Use all_objfiles.
10563 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10564 * symfile.c (remove_symbol_file_command)
10565 (expand_symtabs_matching, map_symbol_filenames): Use
10567 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10569 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10570 * objc-lang.c (find_methods): Use all_objfiles.
10571 * objfiles.c (have_partial_symbols, have_full_symbols)
10572 (have_minimal_symbols, qsort_cmp)
10573 (default_iterate_over_objfiles_in_search_order): Use
10575 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10576 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10577 (maintenance_check_psymtabs): Use all_objfiles.
10578 (ALL_PSYMTABS): Remove.
10579 * compile/compile-object-run.c (do_module_cleanup): Use
10581 * blockframe.c (find_pc_partial_function): Use all_objfiles.
10582 * cp-support.c (add_symbol_overload_list_qualified): Use
10584 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10586 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10587 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10589 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10590 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10591 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10593 * solib.c (solib_read_symbols): Use all_objfiles
10595 2019-01-09 Tom Tromey <tom@tromey.com>
10597 * probe.c (parse_probes_in_pspace): Use all_objfiles.
10598 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10600 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10601 * symmisc.c (print_symbol_bcache_statistics)
10602 (print_objfile_statistics, maintenance_print_objfiles)
10603 (maintenance_info_symtabs, maintenance_check_symtabs)
10604 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10606 * source.c (forget_cached_source_info): Use all_objfiles.
10607 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10608 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10609 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10610 * objfiles.c (update_section_map): Use all_objfiles.
10611 (shared_objfile_contains_address_p): Likewise.
10612 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10613 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10615 2019-01-09 Tom Tromey <tom@tromey.com>
10617 * common/next-iterator.h: New file.
10618 * objfiles.h (class all_objfiles): New.
10619 (struct objfile_iterator): New.
10621 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10623 * NEWS: Move the description of the changed "frame", "select-frame",
10624 and "info frame" commands to the Changed commands section.
10626 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
10628 * gdbtypes.c (check_stub_method_group): Remove handling of old
10630 * linespec.c (find_methods): Likewise.
10631 * stabsread.c (read_member_functions): Likewise.
10632 * valops.c (search_struct_method): Likewise.
10633 (value_struct_elt_for_reference): Likewise.
10634 * NEWS: Mention this change.
10636 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
10638 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10639 print_source_lines.
10640 * source.c (print_source_lines_base): Update line number check.
10641 (print_source_lines): New function.
10642 (source_lines_range::source_lines_range): New function.
10643 * source.h (class source_lines_range): New class.
10644 (print_source_lines): New declaration.
10646 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10648 * linespec.c (linespec_state_destructor): Free self->canonical_names.
10650 2019-01-08 Tom Tromey <tom@tromey.com>
10651 Simon Marchi <simon.marchi@ericsson.com>
10654 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10655 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10656 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10657 * f-exp.y (DOLLAR_VARIABLE): Likewise.
10658 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10659 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10661 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10663 * source.c (select_source_symtab): Move header comment to
10664 declaration in source.h.
10665 (forget_cached_source_info_for_objfile): Likewise.
10666 (forget_cached_source_info): Likewise.
10667 (identify_source_line): Likewise.
10668 * source.h (identify_source_line): Move declaration from symtab.h
10669 and add comment from source.c
10670 (print_source_lines): Likewise.
10671 (forget_cached_source_info_for_objfile): Likewise.
10672 (forget_cached_source_info): Likewise.
10673 (select_source_symtab): Likewise.
10674 (enum print_source_lines_flag): Move definition from symtab.h.
10675 * symtab.h (identify_source_line): Move declaration to source.h.
10676 (print_source_lines): Likewise.
10677 (forget_cached_source_info_for_objfile): Likewise.
10678 (forget_cached_source_info): Likewise.
10679 (select_source_symtab): Likewise.
10680 (enum print_source_lines_flag): Move definition to source.h.
10681 * tui/tui-hooks.c: Add 'source.h' include.
10683 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10685 * source.c (print_source_lines_base): Handle requests to print
10686 reverse line number sequences, and guard against empty lines
10689 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10691 * source.c (print_source_lines_base): Fix skip of '\r' if next
10694 2019-01-06 Tom Tromey <tom@tromey.com>
10696 * c-exp.y (struct c_parse_state) <macro_original_text,
10697 expansion_obstack>: New member.
10698 (macro_original_text, expansion_obstack): Remove globals.
10699 (scan_macro_expansion, scanning_macro_expansion)
10700 (finished_macro_expansion): Update.
10701 (scan_macro_cleanup): Remove.
10702 (yylex, c_parse): Update.
10704 2019-01-06 Tom Tromey <tom@tromey.com>
10706 * c-exp.y (struct c_parse_state) <strings>: New member.
10707 (operator_stoken): Update.
10709 2019-01-06 Tom Tromey <tom@tromey.com>
10711 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
10712 (union type_stack_elt) <typelist_val>: Now a pointer to
10714 (type_stack_cleanup): Don't declare.
10715 (push_typelist): Update.
10716 * parse.c (pop_typelist): Return a std::vector.
10717 (push_typelist): Take a std::vector.
10718 (follow_types): Update. Do not free args.
10719 (type_stack_cleanup): Remove.
10720 * c-exp.y (struct c_parse_state): New.
10721 (cpstate): New global.
10722 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10723 (nonempty_typelist): Update.
10724 (func_mod): Create a new vector.
10725 (c_parse): Create a c_parse_state.
10726 (check_parameter_typelist): Do not delete params.
10727 (function_method): Update. Do not delete type_list.
10729 2019-01-06 Tom Tromey <tom@tromey.com>
10732 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10734 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10735 (print_return_value): Likewise.
10737 2019-01-05 Tom Tromey <tom@tromey.com>
10739 * contrib/cleanup_check.py: Remove.
10740 * contrib/gcc-with-excheck: Remove.
10741 * contrib/exsummary.py: Remove.
10742 * contrib/excheck.py: Remove.
10744 2019-01-05 Joel Brobecker <brobecker@adacore.com>
10746 * thread.c (delete_thread_1): Add gdb_assert that THR is not
10747 NULL. Initialize tpprev to NULL instead of assigning it
10748 to NULL on the next statement.
10749 * windows-nat.c (windows_delete_thread): Remove check for
10750 main_thread_id before printing thread exit notifications.
10751 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10752 Remove thread ID check against main_thread_id.
10753 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10754 windows_delete_thread.
10755 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10757 2019-01-04 Tom Tromey <tom@tromey.com>
10759 * compile/compile.c (_initialize_compile): Use upper case for
10760 metasyntactic variables.
10761 * symmisc.c (_initialize_symmisc): Use upper case for
10762 metasyntactic variables.
10763 * psymtab.c (_initialize_psymtab): Use upper case for
10764 metasyntactic variables.
10765 * demangle.c (demangle_command): Use upper case for metasyntactic
10767 (_initialize_demangler): Likewise.
10768 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10771 2019-01-03 Tom Tromey <tom@tromey.com>
10773 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10775 2019-01-03 Tom Tromey <tom@tromey.com>
10777 * python/py-symtab.c (salpy_str): Update.
10778 (struct salpy_sal_object) <symtab>: Now a PyObject.
10779 (salpy_dealloc): Update.
10780 (del_objfile_sal): Use gdbpy_ref.
10782 2019-01-03 Tom Tromey <tom@tromey.com>
10784 * python/py-type.c (convert_field): Use new_reference. Return
10786 (make_fielditem): Return gdbpy_ref.
10787 (typy_fields): Update.
10788 (typy_getitem): Update.
10789 (field_name): Return gdbpy_ref. Use new_reference.
10790 (typy_iterator_iternext): Update.
10792 2019-01-03 Tom Tromey <tom@tromey.com>
10794 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10796 2019-01-03 Tom Tromey <tom@tromey.com>
10798 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10799 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10800 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10801 (pspy_set_frame_filters, pspy_set_frame_unwinders)
10802 (pspy_set_type_printers): Likewise.
10803 * python/py-function.c (fnpy_init): Use gdbpy_ref.
10804 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10805 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10806 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10807 (objfpy_set_type_printers): Likewise.
10809 2019-01-03 Tom Tromey <tom@tromey.com>
10811 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10812 (gdbpy_print_stack): Use gdbpy_err_fetch.
10813 * python/python-internal.h (class gdbpy_err_fetch): New class.
10814 (class gdbpy_enter) <m_error_type, m_error_value,
10815 m_error_traceback>: Remove.
10816 <m_error>: New member.
10817 (gdbpy_exception_to_string): Don't declare.
10818 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10819 * python/py-value.c (convert_value_from_python): Use
10821 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10822 gdbpy_exception_to_string.
10823 (gdbpy_handle_exception): Use gdbpy_err_fetch.
10824 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10827 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10829 * linux-nat.c (delete_lwp_cleanup): Delete.
10830 (struct lwp_deleter): New struct.
10831 (lwp_info_up): New typedef.
10832 (linux_nat_target::follow_fork): Delete cleanup, and make use of
10835 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10837 * linux-fork.c (class scoped_switch_fork_info): New class.
10838 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10840 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10842 * valops.c (find_overload_match): Remove use of null_cleanup, and
10843 calls to do_cleanups.
10845 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10847 * compile/compile-cplus-types.c
10848 (compile_cplus_instance::decl_name): Handle changes to
10850 * cp-support.c (cp_func_name): Update header comment, update
10852 * cp-support.h (cp_func_name): Update return type in declaration.
10853 * valops.c (find_overload_match): Move temp_func local to top
10854 level of function and change its type. Use temp_func to hold and
10855 delete temporary string obtained from cp_func_name.
10857 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10859 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10860 gdb::char_vector, remove cleanup, and update uses of `msg`.
10862 2019-01-03 Jim Wilson <jimw@sifive.com>
10864 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10866 2019-01-02 Tom Tromey <tom@tromey.com>
10868 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10869 (tdesc_parse_xml): Remove cleanups.
10870 * target-descriptions.h (make_cleanup_free_target_description):
10872 (target_desc_deleter): New struct.
10873 (target_desc_up): New typedef.
10874 * target-descriptions.c (target_desc_deleter::operator()): Rename
10875 from free_target_description.
10876 (make_cleanup_free_target_description): Remove.
10878 2019-01-02 Tom Tromey <tom@tromey.com>
10880 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
10881 constructor, destructor.
10882 (linespec_parser): Remove typedef.
10883 (~linespec_parser): Rename from linespec_parser_delete.
10884 (linespec_lex_to_end, linespec_complete_label)
10885 (linespec_complete): Update.
10886 (decode_line_full): Remove cleanups.
10887 (decode_line_1): Update.
10889 2019-01-02 Tom Tromey <tom@tromey.com>
10891 * python/python-internal.h (inferior_to_inferior_object): Change
10893 * python/py-exitedevent.c (create_exited_event_object): Update.
10894 * python/py-inferior.c (inferior_to_inferior_object): Return
10896 (python_new_inferior, python_inferior_deleted)
10897 (thread_to_thread_object, delete_thread_object)
10898 (build_inferior_list, gdbpy_selected_inferior): Update.
10899 * python/py-infthread.c (create_thread_object): Update. Also fail
10900 if inferior_to_inferior_object fails.
10902 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
10904 * inferior.h (class inferior) <displaced_step_state>: New field.
10905 * infrun.h (struct displaced_step_state): Move here from
10906 infrun.c. Initialize fields, add constructor.
10907 <inf>: Remove field.
10908 <reset>: New method.
10909 * infrun.c (struct displaced_step_inferior_state): Move to
10911 (displaced_step_inferior_states): Remove.
10912 (get_displaced_stepping_state): Adust.
10913 (displaced_step_in_progress_any_inferior): Adjust.
10914 (displaced_step_in_progress_thread): Adjust.
10915 (displaced_step_in_progress): Adjust.
10916 (add_displaced_stepping_state): Remove.
10917 (get_displaced_step_closure_by_addr): Adjust.
10918 (remove_displaced_stepping_state): Remove.
10919 (infrun_inferior_exit): Call displaced_step_state.reset.
10920 (use_displaced_stepping): Don't check for NULL.
10921 (displaced_step_prepare_throw): Call
10922 get_displaced_stepping_state.
10923 (displaced_step_fixup): Don't check for NULL.
10924 (prepare_for_detach): Don't check for NULL.
10926 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10928 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10929 in case of call that did not complete.
10931 2019-01-02 Andrey Utkin <autkin@undo.io>
10933 * symfile.c (find_separate_debug_file): Fix search of debug files for
10936 2019-01-02 Tom Tromey <tom@tromey.com>
10938 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10940 * python/py-frame.c (frapy_older): Remove cast.
10941 (frapy_newer): Likewise.
10942 * python/py-breakpoint.c (local_setattro): Remove cast.
10943 * python/py-arch.c (archpy_name): Remove local variable.
10944 * python/py-type.c (gdbpy_lookup_type): Remove cast.
10946 2019-01-02 Joel Brobecker <brobecker@adacore.com>
10948 * unittests/basic_string_view/element_access/char/empty.cc:
10949 Fix year range in copyright header.
10951 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
10953 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10955 <operator==>: Update with for removed field.
10957 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10958 <isa_features>: ...this.
10959 <abi_features>: New field.
10960 (riscv_isa_flen): Update comment.
10961 (riscv_abi_xlen): New declaration.
10962 (riscv_abi_flen): New declaration.
10963 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10965 (riscv_abi_xlen): New function.
10966 (riscv_isa_flen): Update to get answer from isa_features.
10967 (riscv_abi_flen): New function.
10968 (riscv_has_fp_abi): Update to get answer from abi_features.
10969 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10971 (riscv_call_info) <xlen, flen>: Update comment.
10972 (riscv_call_arg_struct): Remove invalid assertions
10973 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10975 (riscv_gdbarch_init): Gather isa features and abi features
10976 separately, ensure both match on the gdbarch when reusing an old
10977 gdbarch. Relax an error check to allow 32-bit abi float to run on
10978 a target with 64-bit float hardware.
10980 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10982 * source.c (search_command_helper): Stop reverse search
10983 when line 1 has been searched.
10985 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10987 * record-full.c (record_full_base_target::close): Rewrite
10988 record_full_core_buf_list free logic.
10990 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10992 * break-catch-syscall.c (print_one_catch_syscall): xfree
10995 2019-01-01 Joel Brobecker <brobecker@adacore.com>
10997 * top.c (print_gdb_version): Update Copyright year in version
11000 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11002 Update copyright year range in all GDB files.
11004 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
11006 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11008 For older changes see ChangeLog-2018.
11014 version-control: never
projects / deliverable / binutils-gdb.git / blob