gdb/ChangeLog

   1 2019-12-01  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
   4         specially.
   5
   6 2019-12-01  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
   9         \0.
  10         * unittests/tui-selftests.c: New file.
  11         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
  12
  13 2019-12-01  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
  16
  17 2019-12-01  Tom Tromey  <tom@tromey.com>
  18
  19         * NEWS: Document new settings.
  20         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
  21         * tui/tui-win.c (_initialize_tui_win): Add border style
  22         observers.
  23         * tui/tui-io.h (tui_apply_style): Declare.
  24         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
  25         longer static.
  26         (apply_ansi_escape, tui_set_reverse_mode): Update.
  27         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
  28         Add "skip_intensity" parameter.
  29         <changed>: New member.
  30         <do_set_value>: Declare.
  31         (tui_border_style, tui_active_border_style): Declare.
  32         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
  33         globals.
  34         (cli_style_option): Initialize "changed".
  35         (cli_style_option::do_set_value): New function.
  36         (cli_style_option::add_setshow_commands): Add "skip_intensity"
  37         parameter.  Update.
  38         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
  39         (_initialize_cli_style): Update.  Create TUI border style
  40         commands.
  41
  42 2019-12-01  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
  45         parameter.
  46         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
  47         parameter.
  48         * tui/tui-win.h (compact_source): Declare.
  49         * tui/tui-win.c (compact_source): New global.
  50         (tui_set_compact_source, tui_show_compact_source): New functions.
  51         (_initialize_tui_win): Add "compact-source" setting.
  52         * tui/tui-source.c (tui_source_window::set_contents): Handle
  53         compact_source setting.
  54         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  55         * NEWS: Document new setting.
  56
  57 2019-11-30  Tom Tromey  <tom@tromey.com>
  58
  59         * dwarf2read.c (dwarf2_add_field): Include field offset when
  60         computing variant part length.
  61
  62 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  63         * NEWS:  Mention define-prefix.  Tell that command names can now
  64         contain a . character.
  65
  66 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  67
  68         * command.h (valid_cmd_char_p): Declare.
  69         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
  70         the check of valid command char.
  71         (find_command_name_length, valid_user_defined_cmd_name_p): Use
  72         valid_cmd_char_p.
  73         * cli/cli-script.c (validate_comname): Likewise.
  74         * completer.c (gdb_completer_command_word_break_characters):
  75         Do not remove . from the word break char, update comments.
  76         (complete_line_internal_1): Use valid_cmd_char_p.
  77         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
  78         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
  79
  80 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  81
  82         * cli/cli-script.c (do_define_command): Ensure a redefined
  83         prefix command is kept as a prefix command.
  84         (define_prefix_command): New function.
  85         (show_user_1): Report user defined prefixes.
  86         (_initialize_cli_script):  Create the new 'define-prefix' command.
  87         Add completers for 'define' and 'document'.
  88         * top.c (execute_command):  If command is a user-defined prefix only
  89         command, report the list of commands for this prefix command.
  90
  91 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  92
  93         * valops.c (find_oload_champ): Improve debug output.
  94
  95 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  96
  97         * valops.c (find_oload_champ): Print part of debug messages
  98         before the badness vector is std::move'd.
  99
 100 2019-11-28  Tom Tromey  <tom@tromey.com>
 101
 102         * value.c (creal_internal_fn): Fix comment.
 103
 104 2019-11-28  Tom Tromey  <tom@tromey.com>
 105
 106         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 107         flag_bound_evaluated>: Now unsigned.
 108
 109 2019-11-28  Tom Tromey  <tom@tromey.com>
 110
 111         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 112         declare.
 113
 114 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 115
 116         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 117         debug output.
 118         * jit.c (jit_unregister_code): Add debug print to match
 119         `jit_register_code`.
 120
 121 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 122
 123         * NEWS: Mention the new multithreaded symbol loading.
 124
 125 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 126
 127         * maint.c (n_worker_threads): Default to 0.
 128         (worker_threads_disabled): New function.
 129         * maint.h (worker_threads_disabled): New function.
 130         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 131         here if worker_threads_disabled () is true.
 132         (minimal_symbol_reader::install): Skip all threading if
 133         worker_threads_disabled () is true.
 134
 135 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 136
 137         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 138         hash code if possible.
 139         (add_minsym_to_demangled_hash_table): Likewise.
 140         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 141         on the background thread.
 142         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 143         Add these fields.
 144
 145 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 146
 147         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 148         of the mangled name on the background thread.
 149         * symtab.c (symbol_set_names): Allow passing in the hash of the
 150         linkage_name.
 151         * symtab.h (symbol_set_names): Likewise.
 152
 153 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 154
 155         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 156         physnames are computed for inherited DIEs.
 157
 158 2019-11-27  Tom Tromey  <tromey@adacore.com>
 159
 160         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 161         backslashes.
 162         * cp-support.c: Remove unnecessary backslashes.
 163
 164 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 165
 166         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 167         with sym->set_linkage_name.
 168         * coffread.c (coff_read_enum_type): Likewise.
 169         * mdebugread.c (parse_symbol): Likewise.
 170         * stabsread.c (patch_block_stabs): Likewise.
 171         (define_symbol): Likewise.
 172         (read_enum_type): Likewise.
 173         (common_block_end): Likewise.
 174         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 175         function.
 176         (SYMBOL_SET_LINKAGE_NAME): Remove.
 177         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 178         with sym->set_linkage_name.
 179
 180 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 181
 182         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 183         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 184         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 185         * NEWS: Mention new MI command.
 186
 187 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 188
 189         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 190         '-symbol-info-types', and '-symbol-info-variables'.
 191         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 192         (mi_cmd_symbol_info_types): Declare.
 193         (mi_cmd_symbol_info_variables): Declare.
 194         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 195         (output_debug_symbol): New function.
 196         (output_nondebug_symbol): New function.
 197         (mi_symbol_info): New function.
 198         (mi_info_functions_or_variables): New function.
 199         (mi_cmd_symbol_info_functions): New function.
 200         (mi_cmd_symbol_info_types): New function.
 201         (mi_cmd_symbol_info_variables): New function.
 202         * NEWS: Mention new commands.
 203
 204 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 205
 206         * symtab.c (symbol_to_info_string): New function, most content
 207         moved from print_symbol_info, but updated to return a std::string.
 208         (print_symbol_info): Update to use symbol_to_info_string and print
 209         returned string.
 210         * symtab.h (symbol_to_info_string): Declare new function.
 211
 212 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * python/python.c (gdbpy_rbreak): Convert to using
 215         global_symbol_searcher.
 216         * symtab.c (file_matches): Convert return type to bool, change
 217         file list to std::vector, update header comment.
 218         (search_symbols): Rename to...
 219         (global_symbol_searcher::search): ...this and update now its
 220         a member function of global_symbol_searcher.  Take account of the
 221         changes to file_matches.
 222         (symtab_symbol_info): Convert to using global_symbol_searcher.
 223         (rbreak_command): Likewise.
 224         (search_module_symbols): Likewise.
 225         * symtab.h (enum symbol_search): Update comment.
 226         (search_symbols): Remove declaration.
 227         (class global_symbol_searcher): New class.
 228
 229 2019-11-26  Tom Tromey  <tromey@adacore.com>
 230
 231         * cp-support.c (_initialize_cp_support): Conditionally initialize
 232         gdb_demangle_attempt_core_dump.
 233
 234 2019-11-26  Tom Tromey  <tom@tromey.com>
 235
 236         * python/py-function.c (fnpy_init): Update.
 237         * value.h (add_internal_function): Adjust declaration.
 238         * value.c (function_destroyer): Remove.
 239         (do_add_internal_function): Don't set destroyer or copy name.
 240         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 241         Set name_allocated.
 242         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 243         (cmdpy_init): Set name_allocated.
 244         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 245         member.
 246         (~cmd_list_element): Free "name" if needed.
 247
 248 2019-11-26  Tom Tromey  <tom@tromey.com>
 249
 250         * value.h (add_internal_function): Add new overload.  Move
 251         documentation from value.h.
 252         * value.c (do_add_internal_function): New function.
 253         (add_internal_function): Use it.  Add new overload.
 254         (function_destroyer): Don't free doc.
 255         * python/py-function.c (fnpy_init): Update.
 256
 257 2019-11-26  Tom Tromey  <tom@tromey.com>
 258
 259         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 260         (cmdpy_init): Set "doc_allocated".
 261
 262 2019-11-26  Tom Tromey  <tom@tromey.com>
 263
 264         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 265         name of worker thread.
 266         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 267         pthread_setname_np.
 268         * configure, config.in: Rebuild.
 269
 270 2019-11-26  Tom Tromey  <tom@tromey.com>
 271
 272         * python/python.c (class gdbpy_gil): New.
 273         (struct gdbpy_event): Add constructor, destructor, operator().
 274         (gdbpy_post_event): Use run_on_main_thread.
 275         (gdbpy_initialize_events): Remove.
 276         (do_start_initialization): Update.
 277
 278 2019-11-26  Tom Tromey  <tom@tromey.com>
 279
 280         * NEWS: Add entry.
 281         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 282         commands.  Call update_thread_pool_size.
 283         (update_thread_pool_size, maintenance_set_worker_threads): New
 284         functions.
 285         (n_worker_threads): New global.
 286
 287 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 288             Tom Tromey  <tom@tromey.com>
 289
 290         * minsyms.c (minimal_symbol_reader::install): Use
 291         parallel_for_each.
 292         * gdbsupport/parallel-for.h: New file.
 293         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 294
 295 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 296             Tom Tromey  <tom@tromey.com>
 297
 298         * gdbsupport/thread-pool.h: New file.
 299         * gdbsupport/thread-pool.c: New file.
 300         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 301         (HFILES_NO_SRCDIR): Add thread-pool.h.
 302
 303 2019-11-26  Tom Tromey  <tom@tromey.com>
 304
 305         * event-top.h (thread_local_segv_handler): Declare.
 306         * event-top.c (thread_local_segv_handler): New global.
 307         (install_handle_sigsegv, handle_sigsegv): New functions.
 308         (async_init_signals): Install SIGSEGV handler.
 309         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 310         thread-local.
 311         (report_failed_demangle): New function.
 312         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 313         handler-setting code, instead use segv_handler.  Run warning code
 314         on main thread.
 315
 316 2019-11-26  Tom Tromey  <tom@tromey.com>
 317
 318         * run-on-main-thread.c: New file.
 319         * run-on-main-thread.h: New file.
 320         * unittests/main-thread-selftests.c: New file.
 321         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 322         main-thread-selftests.c.
 323         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 324         (COMMON_SFILES): Add run-on-main-thread.c.
 325
 326 2019-11-26  Tom Tromey  <tom@tromey.com>
 327
 328         * main.c (setup_alternate_signal_stack): Remove.
 329         (captured_main_1): Use gdb::alternate_signal_stack.
 330         * gdbsupport/alt-stack.h: New file.
 331
 332 2019-11-26  Tom Tromey  <tom@tromey.com>
 333
 334         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 335         Remove comment.
 336         (save_original_signals_state, restore_original_signals_state): Use
 337         gdb_sigmask.
 338         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 339         (_initialize_linux_nat): Use gdb_sigmask.
 340         * guile/guile.c (_initialize_guile): Use block_signals.
 341         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 342         * gdbsupport/gdb-sigmask.h: New file.
 343         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 344         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 345         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 346         pthread_sigmask.
 347         * configure, config.in: Rebuild.
 348         * gdbsupport/block-signals.h: New file.
 349
 350 2019-11-26  Tom Tromey  <tom@tromey.com>
 351
 352         * acinclude.m4: Include ax_pthread.m4.
 353         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 354         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 355         (CLIBS): Use PTHREAD_LIBS.
 356         (aclocal_m4_deps): Add ax_pthread.m4.
 357         * config.in, configure: Rebuild.
 358         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 359
 360 2019-11-26  Tom Tromey  <tom@tromey.com>
 361
 362         * symtab.h (struct minimal_symbol) <name_set>: New member.
 363         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 364         Don't call symbol_set_names.
 365         (minimal_symbol_reader::install): Call symbol_set_names.
 366
 367 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 368
 369         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 370         restore_active_ext_lang, as GIL is needed for (indirectly)
 371         called PyOS_InterruptOccurred.
 372
 373 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 374
 375         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 376         definition.
 377
 378 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 379
 380         * remote-sim.c (simulator_command): Make static, remove
 381         declaration.
 382
 383 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 384
 385         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 386         static.
 387         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 388         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 389         (main): Likewise.
 390         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 391         (main): Likewise.
 392         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 393         (main): Likewise.
 394         * unittests/basic_string_view/element_access/char/1.cc (test01):
 395         Likewise.
 396         (main): Likewise.
 397         * unittests/basic_string_view/element_access/char/empty.cc (main):
 398         Likewise.
 399         * unittests/basic_string_view/element_access/char/front_back.cc
 400         (test01): Likewise.
 401         (main): Likewise.
 402         * unittests/basic_string_view/inserters/char/2.cc (test05):
 403         Likewise.
 404         (main): Likewise.
 405         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 406         (test01): Likewise.
 407         (main): Likewise.
 408         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 409         (test01): Likewise.
 410         (main): Likewise.
 411         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 412         Likewise.
 413         * unittests/basic_string_view/operations/compare/char/1.cc
 414         (test01): Likewise.
 415         (main): Likewise.
 416         * unittests/basic_string_view/operations/compare/char/13650.cc
 417         (test01): Likewise.
 418         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 419         Likewise.
 420         (main): Likewise.
 421         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 422         Likewise.
 423         (main): Likewise.
 424         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 425         Likewise.
 426         (main): Likewise.
 427         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 428         Likewise.
 429         (main): Likewise.
 430         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 431         Likewise.
 432         (main): Likewise.
 433         * unittests/basic_string_view/operations/find/char/4.cc (main):
 434         Likewise.
 435         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 436         Likewise.
 437         (main): Likewise.
 438         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 439         Likewise.
 440         (main): Likewise.
 441         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 442         Likewise.
 443         (main): Likewise.
 444         * unittests/basic_string_view/operations/substr/char/1.cc
 445         (test01): Likewise.
 446         (main): Likewise.
 447         * unittests/basic_string_view/operators/char/2.cc (main):
 448         Likewise.
 449         * unittests/optional/assignment/1.cc (test): Likewise.
 450         * unittests/optional/assignment/2.cc (test): Likewise.
 451         * unittests/optional/assignment/3.cc (test): Likewise.
 452         * unittests/optional/assignment/4.cc (test): Likewise.
 453         * unittests/optional/assignment/5.cc (test): Likewise.
 454         * unittests/optional/assignment/6.cc (test): Likewise.
 455         * unittests/optional/assignment/7.cc (test): Likewise.
 456         * unittests/optional/cons/copy.cc (test): Likewise.
 457         * unittests/optional/cons/default.cc (test): Likewise.
 458         * unittests/optional/cons/move.cc (test): Likewise.
 459         * unittests/optional/cons/value.cc (test): Likewise.
 460         * unittests/optional/in_place.cc (test): Likewise.
 461         * unittests/optional/observers/1.cc (test): Likewise.
 462         * unittests/optional/observers/2.cc (test): Likewise.
 463
 464 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 465
 466         * tui-win.h (tui_set_var_cmd): Remove.
 467         * tui-win.c (tui_set_var_cmd): Make static.
 468
 469 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 470
 471         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 472         rbreak_command_wrapper): Remove.
 473         * symtab.c (rbreak_command_wrapper): Remove.
 474
 475 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 476
 477         * inferior.h (info_terminal_command): Remove declaration.
 478         * inflow.c (info_terminal_command): Make static.
 479
 480 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 481
 482         * inferior.c (exit_inferior_silent): Remove.
 483
 484 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 485
 486         * dictionary.c (dict_empty, mdict_empty): Remove.
 487         * dictionary.c (mdict_empty): Remove.
 488
 489 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 490
 491          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 492          (arc_insn_get_memory_offset): Likewise.
 493          (arc_insn_dump): Likewise.
 494          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 495          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 496          * dictionary.c (dict_iterator_next): Likewise.
 497          (dict_iter_match_first): Likewise.
 498          (dict_iter_match_next): Likewise.
 499          * f-lang.c (evaluate_subexp_f): Likewise.
 500          * hppa-tdep.c (hppa_read_pc): Likewise.
 501          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 502          * parse.c (write_exp_elt_msym): Likewise.
 503          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 504          * remote.c (remote_packet_size): Likewise.
 505          (remote_notif_stop_parse): Likewise.
 506          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 507          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 508          * source.c (prepare_path_for_appending): Likewise.
 509          * sparc64-linux-tdep.c
 510          (sparc64_linux_handle_segmentation_fault); Likewise.
 511          * stack.c (frame_selection_by_function_completer): Likewise.
 512
 513 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 514
 515         * completer.c (set_gdb_completion_word_break_characters):
 516         Remove.
 517
 518 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 519
 520         * dwarf-index-write.c: Include dwarf-index-write.h.
 521         * mi/mi-interp.c: Include mi/mi-interp.h.
 522
 523 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 524
 525         * aarch32-tdep.c: Include aarch32-tdep.h.
 526         * aarch32-tdep.h: Forward-declare struct target_desc.
 527
 528 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 529
 530         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 531         strerror.
 532         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 533         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 534
 535 2019-11-25  Tom de Vries  <tdevries@suse.de>
 536
 537         * contrib/words.sh: Add -c option.
 538
 539 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 540
 541         * solib.c (solib_find_1): Change int to bool.
 542         (exec_file_find): Change int to bool.
 543         (solib_find): Change int to bool.
 544         (solib_read_symbols): Change int to bool.
 545         (solib_used): Change int to bool.
 546         (solib_add): Change int to bool.
 547         (info_sharedlibrary_command): Change int to bool.
 548         (solib_contains_address_p): Change int to bool.
 549         (solib_keep_data_in_core): Change int to bool.
 550         (in_solib_dynsym_resolve_code): Change int to bool.
 551         (reload_shared_libraries_1): Change int to bool.
 552         (gdb_sysroot_changed): Change int to bool.
 553         * solib.h (solib_read_symbols): Change int to bool.
 554         (solib_contains_address_p): Change int to bool.
 555         (solib_keep_data_in_core): Change int to bool.
 556         (in_solib_dynsym_resolve_code): Change int to bool.
 557         (libpthread_name_p): Change int to bool.
 558
 559 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 560
 561         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 562         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 563         (remote_packet_max_chars): New static global.
 564         (show_remote_packet_max_chars): New function.
 565         (remote_target::putpkt_binary): Adjust to use new
 566         remote_packet_max_chars option.
 567         (remote_target::getpkt_or_notif_sane_1): Likewise.
 568         (_initialize_remote): Register new remote-packet-max-chars option.
 569
 570 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 571
 572         * m68k-linux-nat.c: Include gdbarch.h.
 573
 574 2019-11-24  Tom Tromey  <tom@tromey.com>
 575
 576         * symfile.c (read_symbols): Update.
 577         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 578         bool.
 579         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 580         (psym_lookup_symbol, psym_find_last_source_symtab)
 581         (psym_forget_cached_source_info, psym_print_stats)
 582         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 583         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 584         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 585         (psym_find_compunit_symtab_by_address)
 586         (maintenance_print_psymbols, maintenance_info_psymtabs)
 587         (maintenance_check_psymtabs): Update.
 588         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 589         bool.
 590
 591 2019-11-22  Tom Tromey  <tom@tromey.com>
 592
 593         * observable.h: Update comments.
 594
 595 2019-11-22  Tom Tromey  <tromey@adacore.com>
 596
 597         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 598         (print_ada_task_info): Don't try to fetch thread id if task is not
 599         alive.
 600
 601 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 602
 603         * ada-exp.y: Update.
 604         * ada-lang.c (sort_choices): Update.
 605         (ada_print_symbol_signature): Update.
 606         (resolve_subexp): Update.
 607         (ada_parse_renaming): Update.
 608         (ada_read_renaming_var_value): Update.
 609         (lesseq_defined_than): Update.
 610         (remove_extra_symbols): Update.
 611         (remove_irrelevant_renamings): Update.
 612         (ada_add_block_symbols): Update.
 613         (ada_collect_symbol_completion_matches): Update.
 614         (ada_is_renaming_symbol): Update.
 615         (aggregate_assign_from_choices): Update.
 616         (ada_evaluate_subexp): Update.
 617         (ada_has_this_exception_support): Update.
 618         (ada_is_non_standard_exception_sym): Update.
 619         (ada_add_exceptions_from_frame): Update.
 620         (ada_add_global_exceptions): Update.
 621         (ada_print_subexp): Update.
 622         * ax-gdb.c (gen_var_ref): Update.
 623         (gen_maybe_namespace_elt): Update.
 624         (gen_expr_for_cast): Update.
 625         (gen_expr): Update.
 626         * block.h: Update.
 627         * blockframe.c (find_pc_partial_function): Update.
 628         * breakpoint.c (print_breakpoint_location): Update.
 629         (update_static_tracepoint): Update.
 630         * btrace.c (ftrace_print_function_name): Update.
 631         (ftrace_function_switched): Update.
 632         * buildsym.c (find_symbol_in_list): Update.
 633         * c-exp.y: Update.
 634         * c-typeprint.c (c_print_typedef): Update.
 635         (c_type_print_template_args): Update.
 636         * cli/cli-cmds.c (edit_command): Update.
 637         (list_command): Update.
 638         (print_sal_location): Update.
 639         * coffread.c (patch_opaque_types): Update.
 640         (process_coff_symbol): Update.
 641         (coff_read_enum_type): Update.
 642         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 643         (convert_one_symbol): Update.
 644         (hash_symname): Update.
 645         (eq_symname): Update.
 646         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 647         * compile/compile-cplus-types.c (debug_print_scope): Update.
 648         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 649         * compile/compile-object-load.c (get_out_value_type): Update.
 650         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 651         (search_symbol_list): Update.
 652         (cp_lookup_symbol_imports_or_template): Update.
 653         * cp-support.c (overload_list_add_symbol): Update.
 654         * ctfread.c (psymtab_to_symtab): Update.
 655         * dbxread.c (cp_set_block_scope): Update.
 656         * dictionary.c (iter_match_first_hashed): Update.
 657         (iter_match_next_hashed): Update.
 658         (insert_symbol_hashed): Update.
 659         (iter_match_next_linear): Update.
 660         * dictionary.h: Update.
 661         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 662         (locexpr_describe_location_piece): Update.
 663         (locexpr_describe_location_1): Update.
 664         (locexpr_generate_c_location): Update.
 665         (loclist_describe_location): Update.
 666         (loclist_generate_c_location): Update.
 667         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 668         (read_func_scope): Update.
 669         (process_enumeration_scope): Update.
 670         (new_symbol): Update.
 671         (dwarf2_const_value): Update.
 672         (dwarf2_symbol_mark_computed): Update.
 673         * eval.c (evaluate_funcall): Update.
 674         (evaluate_subexp_standard): Update.
 675         * expprint.c (print_subexp_standard): Update.
 676         (dump_subexp_body_standard): Update.
 677         * f-valprint.c (info_common_command_for_block): Update.
 678         * findvar.c (get_hosting_frame): Update.
 679         (default_read_var_value): Update.
 680         * go-lang.c (go_symbol_package_name): Update.
 681         * guile/scm-block.c (bkscm_print_block_smob): Update.
 682         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 683         (gdbscm_symbol_name): Update.
 684         (gdbscm_symbol_linkage_name): Update.
 685         (gdbscm_symbol_print_name): Update.
 686         * infcall.c (get_function_name): Update.
 687         * infcmd.c (jump_command): Update.
 688         (finish_command): Update.
 689         * infrun.c (insert_exception_resume_breakpoint): Update.
 690         * linespec.c (canonicalize_linespec): Update.
 691         (create_sals_line_offset): Update.
 692         (convert_linespec_to_sals): Update.
 693         (complete_label): Update.
 694         (find_label_symbols_in_block): Update.
 695         * m2-typeprint.c (m2_print_typedef): Update.
 696         * mdebugread.c (mdebug_reg_to_regnum): Update.
 697         (parse_symbol): Update.
 698         (mylookup_symbol): Update.
 699         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 700         (list_args_or_locals): Update.
 701         * objc-lang.c (compare_selectors): Update.
 702         (info_selectors_command): Update.
 703         (compare_classes): Update.
 704         (info_classes_command): Update.
 705         (find_imps): Update.
 706         * p-typeprint.c (pascal_print_typedef): Update.
 707         * printcmd.c (build_address_symbolic): Update.
 708         (info_address_command): Update.
 709         (print_variable_and_value): Update.
 710         * python/py-framefilter.c (extract_sym): Update.
 711         (py_print_single_arg): Update.
 712         * python/py-symbol.c (sympy_str): Update.
 713         (sympy_get_name): Update.
 714         (sympy_get_linkage_name): Update.
 715         * python/python.c (gdbpy_rbreak): Update.
 716         * record-btrace.c (btrace_get_bfun_name): Update.
 717         (btrace_call_history): Update.
 718         * rust-lang.c (rust_print_typedef): Update.
 719         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 720         * stabsread.c (stab_reg_to_regnum): Update.
 721         (define_symbol): Update.
 722         (read_enum_type): Update.
 723         (common_block_end): Update.
 724         (cleanup_undefined_types_1): Update.
 725         (scan_file_globals): Update.
 726         * stack.c (print_frame_arg): Update.
 727         (print_frame_args): Update.
 728         (find_frame_funname): Update.
 729         (info_frame_command_core): Update.
 730         (iterate_over_block_locals): Update.
 731         (print_block_frame_labels): Update.
 732         (do_print_variable_and_value): Update.
 733         (iterate_over_block_arg_vars): Update.
 734         (return_command): Update.
 735         * symmisc.c (dump_symtab_1): Update.
 736         (print_symbol): Update.
 737         * symtab.c (eq_symbol_entry): Update.
 738         (symbol_cache_dump): Update.
 739         (lookup_language_this): Update.
 740         (find_pc_sect_line): Update.
 741         (skip_prologue_sal): Update.
 742         (symbol_search::compare_search_syms): Update.
 743         (treg_matches_sym_type_name): Update.
 744         (search_symbols): Update.
 745         (print_symbol_info): Update.
 746         (rbreak_command): Update.
 747         (completion_list_add_symbol): Update.
 748         (find_gnu_ifunc): Update.
 749         (get_symbol_address): Update.
 750         (search_module_symbols): Update.
 751         (info_module_subcommand): Update.
 752         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 753         (SYMBOL_LINKAGE_NAME): Remove.
 754         (SYMBOL_DEMANGLED_NAME): Remove.
 755         (SYMBOL_PRINT_NAME): Remove.
 756         (SYMBOL_SEARCH_NAME): Remove.
 757         * tracepoint.c (set_traceframe_context): Update.
 758         (validate_actionline): Update.
 759         (collection_list::collect_symbol): Update.
 760         (encode_actions_1): Update.
 761         (info_scope_command): Update.
 762         (print_one_static_tracepoint_marker): Update.
 763         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 764         * valops.c (address_of_variable): Update.
 765         (find_overload_match): Update.
 766         (find_oload_champ): Update.
 767
 768 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 769
 770         * ada-lang.c (ada_lookup_simple_minsym): Update.
 771         (ada_collect_symbol_completion_matches): Update.
 772         * ada-tasks.c (read_atcb): Update.
 773         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 774         (amd64_windows_skip_trampoline_code): Update.
 775         * arm-tdep.c (skip_prologue_function): Update.
 776         (arm_skip_stack_protector): Update.
 777         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 778         (arm_wince_skip_main_prologue): Update.
 779         * ax-gdb.c (gen_expr): Update.
 780         * block.c (call_site_for_pc): Update.
 781         * blockframe.c (find_pc_partial_function): Update.
 782         * breakpoint.c (set_breakpoint_location_function): Update.
 783         * btrace.c (ftrace_print_function_name): Update.
 784         (ftrace_function_switched): Update.
 785         * c-valprint.c (print_unpacked_pointer): Update.
 786         * coffread.c (coff_symfile_read): Update.
 787         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 788         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 789         * dwarf-index-write.c (write_psymbols): Update.
 790         * dwarf2loc.c (call_site_to_target_addr): Update.
 791         (func_verify_no_selftailcall): Update.
 792         (tailcall_dump): Update.
 793         (call_site_find_chain_1): Update.
 794         (dwarf_expr_reg_to_entry_parameter): Update.
 795         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 796         * eval.c (evaluate_funcall): Update.
 797         (evaluate_subexp_standard): Update.
 798         (evaluate_subexp_for_sizeof): Update.
 799         * expprint.c (print_subexp_standard): Update.
 800         (dump_subexp_body_standard): Update.
 801         * frame.c (get_prev_frame_always_1): Update.
 802         * frv-tdep.c (frv_skip_main_prologue): Update.
 803         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 804         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 805         (gnuv3_get_typename_from_type_info): Update.
 806         (gnuv3_skip_trampoline): Update.
 807         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 808         * i386-tdep.c (i386_skip_main_prologue): Update.
 809         (i386_pe_skip_trampoline_code): Update.
 810         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 811         * infcall.c (get_function_name): Update.
 812         * linespec.c (minsym_found): Update.
 813         * linux-fork.c (info_checkpoints_command): Update.
 814         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 815         (m32c_m16c_pointer_to_address): Update.
 816         * maint.c (maintenance_translate_address): Update.
 817         * minsyms.c (add_minsym_to_hash_table): Update.
 818         (add_minsym_to_demangled_hash_table): Update.
 819         (lookup_minimal_symbol_mangled): Update.
 820         (lookup_minimal_symbol_demangled): Update.
 821         (lookup_minimal_symbol_linkage): Update.
 822         (lookup_minimal_symbol_text): Update.
 823         (lookup_minimal_symbol_by_pc_name): Update.
 824         (minimal_symbol_is_less_than): Update.
 825         (compact_minimal_symbols): Update.
 826         (build_minimal_symbol_hash_tables): Update.
 827         (find_solib_trampoline_target): Update.
 828         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 829         (mips_skip_pic_trampoline_code): Update.
 830         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 831         * objc-lang.c (info_selectors_command): Update.
 832         (info_classes_command): Update.
 833         (find_methods): Update.
 834         (find_imps): Update.
 835         * p-valprint.c (pascal_val_print): Update.
 836         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 837         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 838         * printcmd.c (build_address_symbolic): Update.
 839         (info_symbol_command): Update.
 840         * psymtab.c (psymbol_name_matches): Update.
 841         (match_partial_symbol): Update.
 842         (lookup_partial_symbol): Update.
 843         (print_partial_symbols): Update.
 844         (sort_pst_symbols): Update.
 845         (maintenance_check_psymtabs): Update.
 846         * python/py-framefilter.c (py_print_frame): Update.
 847         * python/python.c (gdbpy_rbreak): Update.
 848         * record-btrace.c (btrace_get_bfun_name): Update.
 849         (btrace_call_history): Update.
 850         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 851         (rs6000_skip_trampoline_code): Update.
 852         * sol-thread.c (info_cb): Update.
 853         * stabsread.c (scan_file_globals): Update.
 854         * stack.c (find_frame_funname): Update.
 855         (info_frame_command_core): Update.
 856         * symmisc.c (dump_msymbols): Update.
 857         * symtab.c (symbol_natural_name): Rename to..,
 858         (general_symbol_info::natural_name): ...this.
 859         (symbol_demangled_name): Rename to...
 860         (general_symbol_info::demangled_name): ...this.
 861         (symbol_search_name): Rename to...
 862         (general_symbol_info::search_name): ...this.
 863         (symbol_matches_search_name): Update.
 864         (find_pc_sect_line): Update.
 865         (skip_prologue_sal): Update.
 866         (search_symbols): Update.
 867         (print_msymbol_info): Update.
 868         (rbreak_command): Update.
 869         (completion_list_add_msymbol): Update.
 870         (completion_list_objc_symbol): Update.
 871         (get_msymbol_address): Update.
 872         * symtab.h (struct general_symbol_info): Add member functions
 873         natural_name (), linkage_name (), print_name (), demangled_name (),
 874         and search_name ().
 875         (SYMBOL_NATURAL_NAME): Update.
 876         (symbol_natural_name): Move to a member function on general_symbol_info.
 877         (SYMBOL_DEMANGLED_NAME): Update.
 878         (symbol_demangled_name): Move to a member function on
 879         general_symbol_info.
 880         (SYMBOL_SEARCH_NAME): Update.
 881         (symbol_search_name): Move to a member function on general_symbol_info.
 882         (MSYMBOL_NATURAL_NAME): Remove.
 883         (MSYMBOL_LINKAGE_NAME): Remove.
 884         (MSYMBOL_PRINT_NAME): Remove.
 885         (MSYMBOL_DEMANGLED_NAME): Remove.
 886         (MSYMBOL_SEARCH_NAME): Remove.
 887         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 888
 889 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 890
 891         * symtab.c (create_demangled_names_hash): Use per_bfd->
 892         minimal_symbol_count for computing the initial size, if greater
 893         than our default size.
 894
 895 2019-11-22  Tom de Vries  <tdevries@suse.de>
 896
 897         * contrib/words.sh: Improve words extraction.
 898
 899 2019-11-22  Tom de Vries  <tdevries@suse.de>
 900
 901         * contrib/words.sh: Combine sed invocations.
 902
 903 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * Makefile.in: Update.
 906         * demangle.c: Rename to...
 907         * gdb-demangle.c: ..this.
 908         (is_cplus_marker): Change return type to bool.
 909         (_initialize_demangler): Rename to...
 910         (_initialize_gdb_demangle): ...this.
 911         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 912         * symtab.h (demangle): Remove declaration; instead include
 913         gdb-demangle.h.
 914
 915 2019-11-21  Tom Tromey  <tromey@adacore.com>
 916
 917         * gdbsupport/format.c (format_pieces): Parse %I64d.
 918         * unittests/format_pieces-selftests.c (test_windows_formats): New
 919         function.
 920         (run_tests): Call it.
 921
 922 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 923
 924         Byte reverse display of variables with DW_END_big, DW_END_little
 925         (DW_AT_endianity) dwarf attributes if different than the native
 926         byte order.
 927         * ada-lang.c (ada_value_binop):
 928         Use type_byte_order instead of gdbarch_byte_order.
 929         * ada-valprint.c (printstr):
 930         (ada_val_print_string):
 931         * ada-lang.c (value_pointer):
 932         (ada_value_binop):
 933         Use type_byte_order instead of gdbarch_byte_order.
 934         * c-lang.c (c_get_string):
 935         Use type_byte_order instead of gdbarch_byte_order.
 936         * c-valprint.c (c_val_print_array):
 937         Use type_byte_order instead of gdbarch_byte_order.
 938         * cp-valprint.c (cp_print_class_member):
 939         Use type_byte_order instead of gdbarch_byte_order.
 940         * dwarf2loc.c (rw_pieced_value):
 941         Use type_byte_order instead of gdbarch_byte_order.
 942         * dwarf2read.c (read_base_type): Handle DW_END_big,
 943         DW_END_little
 944         * f-lang.c (f_get_encoding):
 945         Use type_byte_order instead of gdbarch_byte_order.
 946         * findvar.c (default_read_var_value):
 947         Use type_byte_order instead of gdbarch_byte_order.
 948         * gdbtypes.c (check_types_equal):
 949         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 950         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 951         and TYPE_ENDIANITY_LITTLE if set.
 952         (type_byte_order): new function.
 953         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 954         (struct main_type) <flag_endianity_not_default>:
 955         New field.
 956         (type_byte_order): New function.
 957         * infcmd.c (default_print_one_register_info):
 958         Use type_byte_order instead of gdbarch_byte_order.
 959         * p-lang.c (pascal_printstr):
 960         Use type_byte_order instead of gdbarch_byte_order.
 961         * p-valprint.c (pascal_val_print):
 962         Use type_byte_order instead of gdbarch_byte_order.
 963         * printcmd.c (print_scalar_formatted):
 964         Use type_byte_order instead of gdbarch_byte_order.
 965         * solib-darwin.c (darwin_current_sos):
 966         Use type_byte_order instead of gdbarch_byte_order.
 967         * solib-svr4.c (solib_svr4_r_ldsomap):
 968         Use type_byte_order instead of gdbarch_byte_order.
 969         * stap-probe.c (stap_modify_semaphore):
 970         Use type_byte_order instead of gdbarch_byte_order.
 971         * target-float.c (target_float_same_format_p):
 972         Use type_byte_order instead of gdbarch_byte_order.
 973         * valarith.c (scalar_binop):
 974         (value_bit_index):
 975         Use type_byte_order instead of gdbarch_byte_order.
 976         * valops.c (value_cast):
 977         Use type_byte_order instead of gdbarch_byte_order.
 978         * valprint.c (generic_emit_char):
 979         (generic_printstr):
 980         (val_print_string):
 981         Use type_byte_order instead of gdbarch_byte_order.
 982         * value.c (unpack_long):
 983         (unpack_bits_as_long):
 984         (unpack_value_bitfield):
 985         (modify_field):
 986         (pack_long):
 987         (pack_unsigned_long):
 988         Use type_byte_order instead of gdbarch_byte_order.
 989         * findvar.c (unsigned_pointer_to_address):
 990         (signed_pointer_to_address):
 991         (unsigned_address_to_pointer):
 992         (address_to_signed_pointer):
 993         (default_read_var_value):
 994         (default_value_from_register):
 995         Use type_byte_order instead of gdbarch_byte_order.
 996         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 997         Use type_byte_order instead of gdbarch_byte_order.
 998         * riscv-tdep.c (riscv_print_one_register_info):
 999         Use type_byte_order instead of gdbarch_byte_order.
1000
1001 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1002
1003         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1004         (current_ui_gdb_stdin_ptr): Likewise.
1005         (current_ui_gdb_stderr_ptr): Likewise.
1006         (current_ui_gdb_stdlog_ptr): Likewise.
1007         (current_ui_current_uiout_ptr): Likewise.
1008         (gen_ret_current_ui_field_ptr): Remove.
1009
1010 2019-11-21  Tom de Vries  <tdevries@suse.de>
1011
1012         PR gdb/24956
1013         * cli/cli-script.c (execute_control_command): Only switch to
1014         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1015
1016 2019-11-19  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1019         Now static.  Change type of "name".
1020         (tui_set_win_height_command): Don't copy "arg".
1021         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1022         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1023
1024 2019-11-19  Ali Tamur <tamur@google.com>
1025
1026         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1027         "if (attr != nullptr)".
1028         (dwarf2_find_base_address): Likewise.
1029         (dwarf2_build_include_psymtabs): Likewise.
1030         (read_cutu_die_from_dwo): Likewise.
1031         (read_func_scope): Likewise.
1032         (read_call_site_scope): Likewise.
1033         (dwarf2_get_pc_bounds): Likewise.
1034         (dwarf2_record_block_ranges): Likewise.
1035         (dwarf2_add_field): Likewise.
1036         (dwarf2_add_member_fn): Likewise.
1037         (read_structure_type): Likewise.
1038         (read_enumeration_type): Likewise.
1039         (read_array_type): Likewise.
1040         (read_array_order): Likewise.
1041         (read_set_type): Likewise.
1042         (read_common_block): Likewise.
1043         (read_tag_reference_type): Likewise.
1044         (read_tag_string_type): Likewise.
1045         (read_subroutine_type): Likewise.
1046         (read_base_type): Likewise.
1047         (read_subrange_type): Likewise.
1048         (new_symbol): Likewise.
1049         (prepare_one_comp_unit): Likewise.
1050
1051 2019-11-19  Tom Tromey  <tromey@adacore.com>
1052
1053         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1054         result in error when DebugActiveProcess fails.
1055
1056 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1057             Pedro Alves  <palves@redhat.com>
1058
1059         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1060         * target.c (target_stack::push): Call 'unpush' if there's a
1061         target on top of the stack.
1062
1063 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1064
1065         * python/py-block.c (blpy_dealloc): Call tp_free.
1066         (blpy_block_syms_dealloc): Likewise.
1067         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1068         * python/py-inferior.c (infpy_dealloc): Likewise.
1069         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1070         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1071         * python/py-symbol.c (sympy_dealloc): Likewise.
1072         * python/py-symtab.c (stpy_dealloc): Likewise.
1073         * python/py-type.c (typy_iterator_dealloc): Likewise.
1074
1075 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1076
1077         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1078         constructor instead of using a class initializer.
1079
1080 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1081
1082         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1083         * configure: Regenerate.
1084         * configure.ac: Don't source common.host.
1085         * gdbsupport/common.host: Remove.
1086         * gdbsupport/mingw-strerror.c: Remove.
1087         * gdbsupport/posix-strerror.c: Rename to...
1088         * gdbsupport/safe-strerror.c: ...this.
1089
1090 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1091
1092         * maint.c (scoped_command_stats::print_time): Use localtime_r
1093         instead of localtime (provided through gnulib if necessary).
1094         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1095         of ctime.
1096
1097 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1098
1099         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1100         avoid compile errors.
1101
1102 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1103
1104         * config.in: Regenerate.
1105         * configure: Regenerate.
1106         * gdbsupport/common.m4: No longer check for strerror_r.
1107         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1108         POSIX version of strerror_r, now that gnulib provides it if
1109         necessary.
1110
1111 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1112
1113         * README (`configure' options): Update.
1114
1115 2019-11-14  Tom Tromey  <tromey@adacore.com>
1116
1117         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1118         expected type for the RHS if the LHS is a convenience variable.
1119
1120 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1121
1122         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1123         Provide explicit default and copy constructor.
1124
1125 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1126
1127         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1128         only call Py_INCREF (newbp) in the bppy_pending_object case.
1129
1130 2019-11-13  Tom Tromey  <tromey@adacore.com>
1131
1132         PR build/25182:
1133         * psympriv.h (partial_symbol): Remove static assert.
1134         * symtab.h (general_symbol_info, symbol): Remove static assert.
1135
1136 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * gdbsupport/format.c (format_pieces::format_pieces): Support
1139         printf 'z' size modifier.
1140         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1141         * printcmd.c (ui_printf):  Handle size_t_arg.
1142         * ui-out.c (ui_out::vmessage): Likewise.
1143         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1144         function.
1145         (run_tests): Call test_format_int_sizes.
1146
1147 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1148
1149         * ada-exp.y (write_ambiguous_var): Update.
1150         * buildsym.c (add_symbol_to_list): Update.
1151         * dwarf2read.c (read_variable): Update.
1152         (new_symbol): Update.
1153         * jit.c (finalize_symtab): Update.
1154         * language.c (language_alloc_type_symbol): Update.
1155         * symtab.c (fixup_symbol_section): Update.
1156         (initialize_objfile_symbol_1): Move code to...
1157         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1158         (allocate_symbol): Update.
1159         (allocate_template_symbol): Update.
1160         (get_symbol_address): Update.
1161         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1162         of having as a field, and add a constructor.
1163         (SYMBOL_VALUE): Update.
1164         (SYMBOL_VALUE_ADDRESS): Update.
1165         (SET_SYMBOL_VALUE_ADDRESS): Update.
1166         (SYMBOL_VALUE_BYTES): Update.
1167         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1168         (SYMBOL_BLOCK_VALUE): Update.
1169         (SYMBOL_VALUE_CHAIN): Update.
1170         (SYMBOL_LANGUAGE): Update.
1171         (SYMBOL_SECTION): Update.
1172         (SYMBOL_OBJ_SECTION): Update.
1173         (SYMBOL_SET_LANGUAGE): Update.
1174         (SYMBOL_SET_LINKAGE_NAME): Update.
1175         (SYMBOL_SET_NAMES): Update.
1176         (SYMBOL_NATURAL_NAME): Update.
1177         (SYMBOL_LINKAGE_NAME): Update.
1178         (SYMBOL_DEMANGLED_NAME): Update.
1179         (SYMBOL_SEARCH_NAME): Update.
1180         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1181         (struct symbol): Update.
1182         (struct template_symbol): Update.
1183         (struct rust_vtable_symbol): Update.
1184         * xcoffread.c (SYMBOL_DUP): Update.
1185
1186 2019-11-12  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-layout.c (show_layout): Set current_layout.
1189         (show_source_disasm_command, show_data)
1190         (show_source_or_disasm_and_command): Don't set current_layout.
1191
1192 2019-11-12  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1195
1196 2019-11-12  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-win.c (resize_message): New global.
1199         (show_tui_resize_message): New function.
1200         (tui_async_resize_screen): Print message if requested.
1201         (_initialize_tui_win): Add tui-resize-message setting.
1202         * NEWS: Add entry for new commands.
1203
1204 2019-11-11  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1207         functions.
1208
1209 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1210
1211         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1212
1213 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1216         function.
1217         * python/python-internal.h (gdbpy_lookup_static_symbols):
1218         Declare new function.
1219         * python/python.c (python_GdbMethods): Add
1220         gdb.lookup_static_symbols method.
1221         * NEWS: Mention gdb.lookup_static_symbols.
1222
1223 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1224
1225         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1226         static block of current object file first.  Also fix typo in
1227         header comment.
1228
1229 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * stack.c (set_last_displayed_sal): Delete.
1232         (last_displayed_sal_valid): Delete.
1233         (last_displayed_pspace): Delete.
1234         (last_displayed_addr): Delete.
1235         (last_displayed_symtab): Delete.
1236         (last_displayed_line): Delete.
1237         (class last_displayed_symtab_info_type): New.
1238         (last_displayed_symtab_info): New static global variable.
1239         (print_frame_info): Call methods on last_displayed_symtab_info.
1240         (clear_last_displayed_sal): Update header comment, and make use of
1241         last_displayed_symtab_info.
1242         (last_displayed_sal_is_valid): Likewise.
1243         (get_last_displayed_pspace): Likewise.
1244         (get_last_displayed_addr): Likewise.
1245         (get_last_displayed_symtab): Likewise.
1246         (get_last_displayed_line): Likewise.
1247         (get_last_displayed_sal): Likewise.
1248         * stack.h (clear_last_displayed_sal): Update header comment.
1249         (last_displayed_sal_is_valid): Likewise.
1250         (get_last_displayed_pspace): Likewise.
1251         (get_last_displayed_addr): Likewise.
1252         (get_last_displayed_symtab): Likewise.
1253         (get_last_displayed_line): Likewise.
1254         (get_last_displayed_sal): Likewise.
1255
1256 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * stack.c (frame_show_address): Convert return type to bool.
1259         * stack.h (frame_show_address): Likewise, and update header
1260         comment.
1261
1262 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1265         * unittests/vec-utils-selftests.c: New file.
1266         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1267
1268 2019-11-10  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1271         (tui_highlight_win): Likewise.
1272         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1273         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1274         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1275         Don't set can_highlight.
1276
1277 2019-11-10  Tom Tromey  <tom@tromey.com>
1278
1279         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1280         Remove unused declaration.
1281
1282 2019-11-08  Tom Tromey  <tromey@adacore.com>
1283
1284         * top.c (read_command_file): Update.
1285         (command_line_input): Make return type const.
1286         * python/py-gdb-readline.c: Update.
1287         * linespec.c (decode_line_2): Update.
1288         * defs.h (command_line_input): Make return type const.
1289         * cli/cli-script.c (read_next_line): Make return type const.
1290         * ada-lang.c (get_selections): Update.
1291
1292 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1293
1294         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1295         * mi/mi-main.c (output_cores): Likewise.
1296         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1297         (linux_xfer_osdata_modules): Likewise.
1298         * remote.c (register_remote_support_xml): Likewise.
1299         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1300         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1301
1302 2019-11-06  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-interp.c: Don't include readline.h.
1305         * tui/tui-hooks.c: Don't include readline.h.
1306         * symmisc.c: Include tilde.h, not readline.h.
1307         * symfile.c: Include tilde.h, not readline.h.
1308         * source.c: Include tilde.h, not readline.h.
1309         * solib.c: Include tilde.h, not readline.h.
1310         * psymtab.c: Include tilde.h, not readline.h.
1311         * exec.c: Include tilde.h, not readline.h.
1312         * corelow.c: Include tilde.h, not readline.h.
1313         * cli/cli-dump.c: Include tilde.h, not readline.h.
1314         * cli/cli-cmds.c: Don't include readline.h.
1315
1316 2019-11-05  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1319         (tui_disassemble): Set addr_size.
1320         (tui_disasm_window::set_contents): Use addr_size.
1321
1322 2019-11-05  Tom Tromey  <tom@tromey.com>
1323
1324         * rust-lang.c (rust_language_defn): Update.
1325         * python/py-value.c (valpy_string): Call c_get_string.
1326         * p-lang.c (pascal_language_defn): Update.
1327         * opencl-lang.c (opencl_language_defn): Update.
1328         * objc-lang.c (objc_language_defn): Update.
1329         * m2-lang.c (m2_language_defn): Update.
1330         * language.c (unknown_language_defn, auto_language_defn): Update.
1331         (default_get_string): Remove.
1332         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1333         * go-lang.c (go_language_defn): Update.
1334         * f-lang.c (f_language_defn): Update.
1335         * d-lang.c (d_language_defn): Update.
1336         * c-lang.c (c_language_defn, cplus_language_defn)
1337         (asm_language_defn, minimal_language_defn): Update.
1338         * ada-lang.c (ada_language_defn): Update.
1339         * language.h (struct language_defn) <la_get_string>: Remove.
1340         (LA_GET_STRING): Remove.
1341         (default_get_string): Don't declare.
1342
1343 2019-11-05  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-source.h (struct tui_source_window): Inline
1346         constructor.  Remove destructor.
1347         <style_changed, m_observable>: Move to superclass.
1348         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1349         (struct tui_source_window_base): Move private members to end.
1350         <style_changed, m_observable>: Move from tui_source_window.
1351         * tui/tui-winsource.c (tui_copy_source_line): Move from
1352         tui-source.c.  Rename from copy_source_line.  Add special handling
1353         for negative line number.
1354         (tui_source_window_base::style_changed): Move from
1355         tui_source_window.
1356         (tui_source_window_base): Register observer.
1357         (~tui_source_window_base): New.
1358         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1359         rename.
1360         (tui_source_window::set_contents): Use tui_copy_source_line.
1361         (tui_source_window::tui_source_window): Move to tui-source.h.
1362         (tui_source_window::~tui_source_window): Remove.
1363         (tui_source_window::style_changed): Move to superclass.
1364         * tui/tui-disasm.c (tui_disassemble): Create string file with
1365         styling, when possible.  Add "addr_size" parameter.
1366         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1367         Don't compute maximum size.
1368         (len_without_escapes): New function
1369
1370 2019-11-05  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1373         std::string.
1374         * tui/tui-winsource.c (tui_show_source_line): Update.
1375         * tui/tui-source.c (tui_source_window::set_contents): Update.
1376         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1377
1378 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1379
1380         * symtab.h (gdb_static_assert): Put && operator at the beginning
1381         of the line instead of the end.
1382
1383 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1384
1385         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1386         and sizeof (symbol).
1387         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1388
1389 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1390
1391         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1392         * configure.host: Mark *-*-solaris2.10* obsolete.
1393         * configure.tgt: Mark Solaris < 11 obsolete.
1394         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1395         Update target triplet.
1396
1397 2019-11-01  Tom Tromey  <tromey@adacore.com>
1398
1399         * utils.c (print_sys_errmsg): Simplify.
1400
1401 2019-11-01  Tom Tromey  <tromey@adacore.com>
1402
1403         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1404
1405 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1406
1407         * configure: Regenerate.
1408         * configure.ac: Remove check for strerror_r.
1409         * gdbsupport/common.m4: Check for strerror_r.
1410
1411 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1412
1413         PR gdb/25124
1414
1415         * arm-tdep.c (arm_per_objfile): Rename to ...
1416         (arm_per_bfd): ... this.
1417         (arm_objfile_data_key): Rename to ...
1418         (arm_bfd_data_key): ... this.
1419         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1420         data.
1421         (arm_record_special_symbol): Likewise.
1422
1423 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1424
1425         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1426         end.
1427         * c-typeprint.c (c_print_typedef): Likewise.
1428         * f-typeprint.c (f_print_typedef): Likewise.
1429         * m2-typeprint.c (m2_print_typedef): Likewise.
1430         * p-typeprint.c (pascal_print_typedef): Likewise.
1431         * rust-lang.c (rust_print_typedef): Likewise.
1432         * symtab.c (print_symbol_info): Print a newline after calling
1433         typedef_print.
1434
1435 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1436
1437         * symtab.c (info_module_cmdlist): New variable.
1438         (info_module_command): New function.
1439         (search_module_symbols): New function.
1440         (info_module_subcommand): New function.
1441         (struct info_modules_var_func_options): New struct.
1442         (info_modules_var_func_options_defs): New variable.
1443         (make_info_modules_var_func_options_def_group): New function.
1444         (info_module_functions_command): New function.
1445         (info_module_variables_command): New function.
1446         (info_module_var_func_command_completer): New function.
1447         (_initialize_symtab): Register new 'info module functions' and
1448         'info module variables' commands.
1449         * symtab.h (typedef symbol_search_in_module): New typedef.
1450         (search_module_symbols): Declare new function.
1451         * NEWS: Mention new commands.
1452
1453 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1456         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1457         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1458         MODULES_DOMAIN.
1459         (scan_partial_symbols): Only create partial module symbols for non
1460         declarations.
1461         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1462         and MODULES_DOMAIN.
1463         * symtab.c (search_domain_name): Likewise.
1464         (search_symbols): Likewise.
1465         (print_symbol_info): Likewise.
1466         (symtab_symbol_info): Likewise.
1467         (info_modules_command): New function.
1468         (_initialize_symtab): Register 'info modules' command.
1469         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1470         * NEWS: Mention new 'info modules' command.
1471
1472 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1473
1474         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1475         and $_gdb_maint_setting_str.
1476
1477 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1478
1479         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1480         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1481         (str_value_from_setting, gdb_setting_str_internal_fn)
1482         (gdb_maint_setting_str_internal_fn): New functions.
1483         (_initialize_cli_cmds): Define the new convenience functions.
1484         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1485         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1486
1487 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1488
1489         * agent.c (set_can_use_agent): When the setting is turned on,
1490         look up agent symbols if we don't have them yet.
1491         (agent_new_objfile): Don't look up agent symbols when the agent
1492         setting is off.
1493
1494 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1495
1496         * config.in: Regenerate.
1497
1498 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1499
1500         * configure: Regenerate.
1501         * configure.ac: Check for strerror_r.
1502         * gdbsupport/common-utils.h (safe_strerror): Change return value
1503         to const char * and document that this function is now threadsafe.
1504         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1505         thread_local and call strerror_r, if available.
1506         * utils.c (perror_string): Update.
1507         (print_sys_errmsg): Update.
1508
1509 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1510
1511         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1512         objfile_key.
1513         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1514         objfile to fetch per-bfd data.
1515         (arm_find_exidx_entry): Likewise.
1516
1517 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1518
1519         * gdbsupport/agent.c (debug_agent): Change type to bool.
1520         (use_agent): Likewise.
1521         (all_agent_symbols_look_up): Likewise.
1522         (agent_loaded_p): Change return value to bool.
1523         (agent_look_up_symbols): Update.
1524         (agent_capability_check): Change return value to bool.
1525         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1526         (debug_agent): Change type to bool.
1527         (use_agent): Likewise.
1528         (agent_capability_check): Change return value to bool.
1529
1530 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1531
1532         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1533         (build_minimal_symbol_hash_tables): Code to clear the table moved
1534         to clear_minimal_symbol_hash_tables.
1535         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1536         when needed.
1537
1538 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1539
1540         * infcmd.c: Remove includes.
1541         * infrun.c: Remove includes.
1542
1543 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1544
1545         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1546         (grow_vect): Remove declaration.
1547         (ada_type_of_array): Remove declaration.
1548         (ada_update_initial_language): Remove declaration.
1549         (ada_fold_name): Remove declaration.
1550         (ada_fill_in_ada_prototype): Remove declaration.
1551         (user_select_syms): Remove declaration.
1552         (get_selections): Remove declaration.
1553         (ada_tag_type): Remove declaration.
1554         (ada_value_tag): Remove declaration.
1555         (ada_is_others_clause): Remove declaration.
1556         (ada_in_variant): Remove declaration.
1557         (ada_value_struct_elt): Remove declaration.
1558         (ada_attribute_name): Remove declaration.
1559         (ada_system_address_type): Remove declaration.
1560         * ada-lang.c (ada_watch_location_expression): Make static.
1561         (GROW_VECT): Move here from ada-lang.h.
1562         (grow_vect): Make static.
1563         (ada_update_initial_language): Make static.
1564         (ada_fold_name): Make static.
1565         (ada_type_of_array): Make static.
1566         (encoded_ordered_before): Move up.
1567         (sort_choices): Move up.
1568         (print_signatures): Move up.
1569         (ada_print_symbol_signature): Move up.
1570         (get_selections): Move up and make static.
1571         (user_select_syms): Move up and make static.
1572         (ada_value_struct_elt): Move up and make static.
1573         (ada_tag_type): Make static.
1574         (ada_value_tag): Make static.
1575         (ada_is_others_clause): Make static.
1576         (ada_in_variant): Make static.
1577         (ada_attribute_name): Make static.
1578
1579 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1580
1581         * ada-lang.c: Remove includes.
1582         * ada-typeprint.c: Remove includes.
1583         * ada-valprint.c: Remove includes.
1584
1585 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1586
1587         * addrmap.c: Add static assertions of type size, moved from
1588         _initialize_addrmap.
1589         (_initialize_addrmap): Remove.
1590
1591 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1592
1593         * coffread.c (record_minimal_symbol): Update.
1594         (process_coff_symbol): Update.
1595         * dbxread.c (read_dbx_symtab): Update.
1596         * dwarf2read.c (add_partial_symbol): Update.
1597         (fixup_go_packaging): Update.
1598         (load_partial_dies): Update.
1599         (new_symbol): Update.
1600         * elfread.c (record_minimal_symbol): Change signature to use
1601         gdb::string_view instead of name+len.
1602         (elf_symtab_read): Update.
1603         (elf_rel_plt_read): Update.
1604         * mdebugread.c (parse_partial_symbols): Update.
1605         (handle_psymbol_enumerators): Update.
1606         (new_symbol): Update.
1607         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1608         to use gdb::string_view instead of name+len.
1609         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1610         * psympriv.h (add_psymbol_to_list): Likewise.
1611         * psymtab.c (add_psymbol_to_bcache): Likewise.
1612         (add_psymbol_to_list): Likewise.
1613         * stabsread.c (define_symbol): Update.
1614         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1615         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1616         (symbol_set_names): Likewise.
1617         * xcoffread.c (scan_xcoff_symtab): Update.
1618
1619 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1620
1621         * symtab.h (symbol_set_names): Document that copy_name must be
1622         set to true for non-nullterminated strings.
1623         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1624         linkage_name if the entry was not found and we need to demangle.
1625
1626 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1627
1628         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1629         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1630         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1631         * gdbsupport/gdb_binary_search.h: New file.
1632
1633 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1634
1635         * NEWS: Mention new --with-system-gdbinit-dir option.
1636         * config.in: Regenerate.
1637         * configure: Regenerate.
1638         * configure.ac: Add new option --with-system-gdbinit-dir.
1639         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1640         for a ".gdb" suffix.
1641         * main.c (get_init_files): Change system_gdbinit argument to
1642         a vector and return the files in SYSTEM_GDBINIT_DIR in
1643         addition to SYSTEM_GDBINIT.
1644         (captured_main_1): Update.
1645         (print_gdb_help): Update.
1646         * top.c (print_gdb_configuration): Also print the value of
1647         SYSTEM_GDBINIT_DIR.
1648
1649 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1650
1651         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1652         that takes gdb::string_view arguments.
1653
1654 2019-10-26  Tom de Vries  <tdevries@suse.de>
1655
1656         * aarch64-linux-tdep.c: Fix typos in comments.
1657         * aarch64-tdep.c: Same.
1658         * ada-lang.c: Same.
1659         * amd64-nat.c: Same.
1660         * arc-tdep.c: Same.
1661         * arch/aarch64-insn.c: Same.
1662         * block.c: Same.
1663         * breakpoint.h: Same.
1664         * btrace.h: Same.
1665         * c-varobj.c: Same.
1666         * cli/cli-decode.c: Same.
1667         * cli/cli-script.c: Same.
1668         * cli/cli-utils.h: Same.
1669         * coff-pe-read.c: Same.
1670         * coffread.c: Same.
1671         * compile/compile-cplus-symbols.c: Same.
1672         * compile/compile-object-run.c: Same.
1673         * completer.c: Same.
1674         * corelow.c: Same.
1675         * cp-support.c: Same.
1676         * demangle.c: Same.
1677         * dwarf-index-write.c: Same.
1678         * dwarf2-frame.c: Same.
1679         * dwarf2-frame.h: Same.
1680         * eval.c: Same.
1681         * frame-base.h: Same.
1682         * frame.h: Same.
1683         * gdbcmd.h: Same.
1684         * gdbtypes.h: Same.
1685         * gnu-nat.c: Same.
1686         * guile/scm-objfile.c: Same.
1687         * i386-tdep.c: Same.
1688         * i386-tdep.h: Same.
1689         * infcall.c: Same.
1690         * infcall.h: Same.
1691         * linux-nat.c: Same.
1692         * m68k-tdep.c: Same.
1693         * macroexp.c: Same.
1694         * memattr.c: Same.
1695         * mi/mi-cmd-disas.c: Same.
1696         * mi/mi-getopt.h: Same.
1697         * mi/mi-main.c: Same.
1698         * minsyms.c: Same.
1699         * nat/aarch64-sve-linux-sigcontext.h: Same.
1700         * objfiles.h: Same.
1701         * ppc-linux-nat.c: Same.
1702         * ppc-linux-tdep.c: Same.
1703         * ppc-tdep.h: Same.
1704         * progspace.h: Same.
1705         * prologue-value.h: Same.
1706         * python/py-evtregistry.c: Same.
1707         * python/py-instruction.h: Same.
1708         * record-btrace.c: Same.
1709         * record-full.c: Same.
1710         * remote.c: Same.
1711         * rs6000-tdep.c: Same.
1712         * ser-tcp.c: Same.
1713         * sol-thread.c: Same.
1714         * sparc-sol2-tdep.c: Same.
1715         * sparc64-tdep.c: Same.
1716         * stabsread.c: Same.
1717         * symfile.c: Same.
1718         * symtab.h: Same.
1719         * target.c: Same.
1720         * tracepoint.c: Same.
1721         * tui/tui-data.h: Same.
1722         * tui/tui-io.c: Same.
1723         * tui/tui-win.c: Same.
1724         * tui/tui.c: Same.
1725         * unittests/rsp-low-selftests.c: Same.
1726         * user-regs.h: Same.
1727         * utils.c: Same.
1728         * utils.h: Same.
1729         * valarith.c: Same.
1730         * valops.c: Same.
1731         * valprint.c: Same.
1732         * valprint.h: Same.
1733         * value.c: Same.
1734         * value.h: Same.
1735         * varobj.c: Same.
1736         * x86-nat.h: Same.
1737         * xtensa-tdep.c: Same.
1738
1739 2019-10-25  Ali Tamur <tamur@google.com>
1740
1741         * charset.c (find_charset_names): Reflect API change.
1742
1743 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1744
1745         * symtab.c (struct demangled_name_entry): Change demangled name
1746         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1747         part of the struct anymore.
1748         (symbol_set_names): No longer obstack allocate + copy the demangled
1749         name, just store the allocated name from bfd.
1750
1751 2019-10-25  Tom Tromey  <tromey@adacore.com>
1752
1753         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1754         (bsearch_cie_cmp, add_cie): Remove.
1755         (find_cie): Reimplement.
1756         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1757         (dwarf2_build_frame_info): Update.
1758
1759 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1760
1761         PR gdb/25126
1762         * symfile.c (reread_symbols): Call forget_cached_source_info to
1763         clear the stale source cache.
1764
1765 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1766
1767         * configure: Regenerate.
1768         * configure.ac: Remove code that sets python_has_threads.
1769
1770 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1771
1772         * config.in: Regenerate.
1773         * configure: Regenerate.
1774         * configure.ac: Remove the code that uses sed to get the python
1775         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1776
1777 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1778
1779         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1780         error paths.
1781
1782 2019-10-23  Tom Tromey  <tom@tromey.com>
1783
1784         * arc-tdep.c: Remove ".." from include.
1785         * frv-tdep.c: Remove ".." from include.
1786         * lm32-tdep.c: Remove ".." from include.
1787         * microblaze-tdep.c: Remove ".." from include.
1788         * or1k-tdep.h: Remove ".." from include.
1789         * s12z-tdep.c: Remove ".." from include.
1790         * Makefile.in (OPCODES_CFLAGS): Add comment.
1791         (TOP_CFLAGS): New variable.
1792         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1793
1794 2019-10-23  Tom Tromey  <tom@tromey.com>
1795
1796         * Makefile.in (READLINE_DIR): Update.
1797
1798 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1799
1800         * infcall.c (call_function_by_hand_dummy): Fix the function
1801         comment.  And extract out a code section into...
1802         (reserve_stack_space): ...this new function.
1803
1804 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1805
1806         * infcall.c (value_arg_coerce): Remove an unused parameter.
1807         (call_function_by_hand_dummy): Update the call to
1808         'value_arg_coerce'.
1809
1810 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1811
1812         * infcall.c (call_function_by_hand_dummy): Refactor.
1813
1814 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1815
1816         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1817
1818 2019-10-23  Tom Tromey  <tom@tromey.com>
1819
1820         * configure: Rebuild.
1821         * configure.ac: Don't check for sigprocmask.
1822         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1823
1824 2019-10-23  Tom Tromey  <tom@tromey.com>
1825
1826         * configure: Rebuild.
1827         * acinclude.m4: Use m4_include, not sinclude.
1828
1829 2019-10-23  Tom de Vries  <tdevries@suse.de>
1830
1831         PR breakpoints/24687
1832         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1833
1834 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1835
1836         * symtab.c (struct demangled_name_entry) <language>: Change from
1837         bitfield to regular variable.
1838
1839 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1840
1841         * symtab.c (struct demangled_name_entry): Add a constructor.
1842         (free_demangled_name_entry): New function to call the destructor
1843         for demangled_name_entry.
1844         (create_demangled_names_hash): Pass free_demangled_name_entry to
1845         htab_create_alloc.
1846         (symbol_set_names): Call placement new for demangled_name_entry.
1847         * utils.c: No longer include xxhash.h here, now that fast_hash
1848         is inlined in the header.
1849         * utils.h: Instead, include it here.
1850
1851 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1852
1853         * Makefile.in: Link with libxxhash.
1854         * config.in: Regenerate.
1855         * configure: Regenerate.
1856         * configure.ac: Search for libxxhash.
1857         * utils.c (fast_hash): Use xxhash if present.
1858
1859 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1860
1861         * utils.h (fast_hash): New function.
1862         * symtab.c (hash_demangled_name_entry): Call new function
1863         fast_hash.
1864
1865 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1866
1867         * symtab.c (struct demangled_name_entry): Change type of mangled
1868         to gdb::string_view. Also adds a constructor that takes the
1869         mangled name.
1870         (hash_demangled_name_entry): Update.
1871         (eq_demangled_name_entry): Update.
1872         (free_demangled_name_entry): New function to call the destructor
1873         now that this is not a POD anymore.
1874         (create_demangled_names_hash): Pass free_demangled_name_entry to
1875         htab_create_alloc.
1876         (symbol_set_names): Update.
1877
1878 2019-10-21  Ali Tamur  <tamu@google.com>
1879
1880         * dwarf2read.c (dir_index): Change type.
1881         (file_name_index): Likewise.
1882         (line_header::include_dir_at): Change comment and implementation on
1883         whether it is DWARF 5.
1884         (line_header::is_valid_file_index): New function.
1885         (line_header::file_name_at): Change comment and implementation on
1886         whether it is DWARF 5.
1887         (line_header::file_names): Change to private field renamed as
1888         m_file_names and introduce a new accessor method.
1889         (line_header::file_names_size): New method.
1890         (line_header::include_dirs): Change to private field and rename as
1891         m_include_dirs.
1892         (dw2_get_file_names_reader): Define local var at a smaller scope and
1893         reflect API change.
1894         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1895         (process_structure_scope): Likewise.
1896         (line_header::add_include_dir): Change message and reflect renaming.
1897         (line_header::add_file_name): Likewise.
1898         (read_formatted_entries): Handle DW_FORM_data16.
1899         (dwarf_decode_line_header): Fix line header length calculation.
1900         (psymtab_include_file_name): Change comment and API.
1901         (lnp_state_machine::m_file): Update comment and reflect type change.
1902         (lnp_state_machine::record_line): Reflect type change.
1903         (dwarf_decode_lines): Reflect API change.
1904         (file_file_name): Likewise.
1905         (file_full_name): Likewise.
1906
1907 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1910
1911 2019-10-21  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1914
1915 2019-10-21  Tom Tromey  <tom@tromey.com>
1916
1917         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1918         NM_H.   Use AC_CONFIG_LINKS.
1919         * configure: Rebuild.
1920         * Makefile.in (NM_H): New variable.
1921         (generated_files): Add NM_H.  Remove gcore.
1922         (nm.h, stamp-nmh): New targets.
1923
1924 2019-10-20  Tom Tromey  <tom@tromey.com>
1925
1926         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1927         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1928         obsolete comment.
1929         (put_objfile_before): Now static.
1930
1931 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1932
1933         * gdbsupport/common-utils.h (startswith): Change return type to
1934         bool.
1935
1936 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1937
1938         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1939         * breakpoint.c (bp_locations_compare): Rename to...
1940         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1941         (update_global_location_list): Use std::sort instead of qsort.
1942         * buildsym.c (compare_line_numbers): Rename to...
1943         (lte_is_less_than): ...this, and change to std::sort semantics.
1944         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1945         instead of qsort.
1946         * disasm.c (compare_lines): Rename to...
1947         (line_is_less_than): ...this, and change to std::sort semantics.
1948         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1949         of qsort.
1950         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1951         (fde_is_less_than): ...this, and change to std::sort semantics.
1952         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1953         * mdebugread.c (compare_blocks):
1954         (block_is_less_than): ...this, and change to std::sort semantics.
1955         (sort_blocks): Call std::sort instead of qsort.
1956         * objfiles.c (qsort_cmp): Rename to...
1957         (sort_cmp): ...this, and change to std::sort semantics.
1958         (update_section_map): Call std::sort instead of qsort.
1959         * remote.c (compare_pnums): Remove.
1960         (map_regcache_remote_table): Call std::sort instead of qsort.
1961         * utils.c (compare_positive_ints): Remove.
1962         * utils.h (compare_positive_ints): Remove.
1963         * xcoffread.c (compare_lte): Remove.
1964         (arrange_linetable): Call std::sort instead of qsort.
1965
1966 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1967
1968         * symfile.c (init_entry_point_info): Fix typo.
1969         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1970
1971 2019-10-18  Tom de Vries  <tdevries@suse.de>
1972
1973         * aarch64-tdep.c: Fix typos in comments.
1974         * ada-lang.c: Same.
1975         * ada-tasks.c: Same.
1976         * alpha-tdep.c: Same.
1977         * alpha-tdep.h: Same.
1978         * amd64-nat.c: Same.
1979         * amd64-windows-tdep.c: Same.
1980         * arc-tdep.c: Same.
1981         * arc-tdep.h: Same.
1982         * arch-utils.c: Same.
1983         * arm-nbsd-tdep.c: Same.
1984         * arm-tdep.c: Same.
1985         * ax-gdb.c: Same.
1986         * blockframe.c: Same.
1987         * btrace.c: Same.
1988         * c-varobj.c: Same.
1989         * coff-pe-read.c: Same.
1990         * coffread.c: Same.
1991         * cris-tdep.c: Same.
1992         * darwin-nat.c: Same.
1993         * dbxread.c: Same.
1994         * dcache.c: Same.
1995         * disasm.c: Same.
1996         * dtrace-probe.c: Same.
1997         * dwarf-index-write.c: Same.
1998         * dwarf2-frame-tailcall.c: Same.
1999         * dwarf2-frame.c: Same.
2000         * dwarf2read.c: Same.
2001         * eval.c: Same.
2002         * exceptions.c: Same.
2003         * fbsd-tdep.c: Same.
2004         * findvar.c: Same.
2005         * frame.c: Same.
2006         * frv-tdep.c: Same.
2007         * gnu-v3-abi.c: Same.
2008         * go32-nat.c: Same.
2009         * h8300-tdep.c: Same.
2010         * hppa-tdep.c: Same.
2011         * i386-linux-tdep.c: Same.
2012         * i386-tdep.c: Same.
2013         * ia64-libunwind-tdep.c: Same.
2014         * ia64-tdep.c: Same.
2015         * infcmd.c: Same.
2016         * infrun.c: Same.
2017         * linespec.c: Same.
2018         * linux-nat.c: Same.
2019         * linux-thread-db.c: Same.
2020         * machoread.c: Same.
2021         * mdebugread.c: Same.
2022         * mep-tdep.c: Same.
2023         * mn10300-tdep.c: Same.
2024         * namespace.c: Same.
2025         * objfiles.c: Same.
2026         * opencl-lang.c: Same.
2027         * or1k-tdep.c: Same.
2028         * osabi.c: Same.
2029         * ppc-linux-nat.c: Same.
2030         * ppc-linux-tdep.c: Same.
2031         * ppc-sysv-tdep.c: Same.
2032         * printcmd.c: Same.
2033         * procfs.c: Same.
2034         * record-btrace.c: Same.
2035         * record-full.c: Same.
2036         * remote-fileio.c: Same.
2037         * remote.c: Same.
2038         * rs6000-tdep.c: Same.
2039         * s12z-tdep.c: Same.
2040         * score-tdep.c: Same.
2041         * ser-base.c: Same.
2042         * ser-go32.c: Same.
2043         * skip.c: Same.
2044         * sol-thread.c: Same.
2045         * solib-svr4.c: Same.
2046         * solib.c: Same.
2047         * source.c: Same.
2048         * sparc-nat.c: Same.
2049         * sparc-sol2-tdep.c: Same.
2050         * sparc-tdep.c: Same.
2051         * sparc64-tdep.c: Same.
2052         * stabsread.c: Same.
2053         * stack.c: Same.
2054         * symfile.c: Same.
2055         * symtab.c: Same.
2056         * target-descriptions.c: Same.
2057         * target-float.c: Same.
2058         * thread.c: Same.
2059         * utils.c: Same.
2060         * valops.c: Same.
2061         * valprint.c: Same.
2062         * value.c: Same.
2063         * varobj.c: Same.
2064         * windows-nat.c: Same.
2065         * xcoffread.c: Same.
2066         * xstormy16-tdep.c: Same.
2067         * xtensa-tdep.c: Same.
2068
2069 2019-10-17  Tom Tromey  <tromey@adacore.com>
2070
2071         * configure: Rebuild.
2072         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2073         in AC_CONFIG_FILES invocation.
2074         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2075         new-style config.status invocation.
2076
2077 2019-10-17  Tom de Vries  <tdevries@suse.de>
2078
2079         * arm-nbsd-nat.c: Fix typos in comments.
2080         * arm-tdep.c: Same.
2081         * darwin-nat-info.c: Same.
2082         * dwarf2read.c: Same.
2083         * elfread.c: Same.
2084         * event-top.c: Same.
2085         * findvar.c: Same.
2086         * gdbtypes.c: Same.
2087         * hppa-tdep.c: Same.
2088         * i386-tdep.c: Same.
2089         * jit.c: Same.
2090         * main.c: Same.
2091         * mdebugread.c: Same.
2092         * moxie-tdep.c: Same.
2093         * nto-procfs.c: Same.
2094         * osabi.c: Same.
2095         * ppc-linux-tdep.c: Same.
2096         * remote.c: Same.
2097         * riscv-tdep.c: Same.
2098         * s390-tdep.c: Same.
2099         * sh-tdep.c: Same.
2100         * sparc-linux-tdep.c: Same.
2101         * sparc-nat.c: Same.
2102         * stack.c: Same.
2103         * target-descriptions.c: Same.
2104         * top.c: Same.
2105         * varobj.c: Same.
2106
2107 2019-10-16  Tom Tromey  <tom@tromey.com>
2108
2109         * objfiles.h (struct objfile) <original_name>: Now const.
2110
2111 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2112
2113         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2114         pass on to sigsetjmp's second argument.
2115         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2116
2117 2019-10-16  Keith Seitz  <keiths@redhat.com>
2118
2119         PR gdb/23567
2120         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2121         sections whose size is greater than the file size.
2122
2123 2019-10-16  Jim Wilson  <jimw@sifive.com>
2124
2125         * riscv-tdep.c (riscv_gcc_target_options): New.
2126         (riscv_gnu_triplet_regexp): New.
2127         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2128         set_gdbarch_gnu_triplet_regexp.
2129
2130 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2131
2132         * Makefile.in: Add xml-builtin.h.
2133         * features/feature_to_c.sh: Add an include for xml-builtin.h
2134         to ensure that the compiler checks that the types match.
2135         * xml-builtin.h: New file.
2136         * xml-support.c (fetch_xml_builtin): Add missing const.
2137         * xml-support.h: Remove declaration of xml_builtins.
2138
2139 2019-10-16  Tom de Vries  <tdevries@suse.de>
2140
2141         PR tdep/25096
2142         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2143         (amd64_classify_aggregate): ... here.
2144         (amd64_classify_aggregate_field): Handled fiels of nested structs
2145         recursively.
2146
2147 2019-10-16  Tom de Vries  <tdevries@suse.de>
2148
2149         PR tdep/24104
2150         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2151         that handles 'theclass'.
2152
2153 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2154
2155         * linespec.c (decode_digits_ordinary): Update comment.
2156         * make-target-delegates: No longer need to handle VEC case.
2157         * memrange.c (normalize_mem_ranges): Update comment.
2158         * namespace.c (add_using_directive): Update comment.
2159         * objc-lang.c (uniquify_strings): Update comment.
2160         * ppc-linux-nat.c (struct thread_points): Update comment.
2161         * probe.h (find_probes_in_objfile): Update comment.
2162         * target.h (enum flash_preserve_mode): Update comment.
2163         * varobj.c (varobj_restrict_range): Update comment.
2164         * varobj.h (varobj_list_children): Update comment.
2165
2166 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * Makefile.in: Remove references to vec.h and vec.c.
2169         * aarch64-tdep.c: No longer include vec.h.
2170         * ada-lang.c: Likewise.
2171         * ada-lang.h: Likewise.
2172         * arm-tdep.c: Likewise.
2173         * ax.h: Likewise.
2174         * breakpoint.h: Likewise.
2175         * charset.c: Likewise.
2176         * cp-support.h: Likewise.
2177         * dtrace-probe.c: Likewise.
2178         * dwarf2read.c: Likewise.
2179         * extension.h: Likewise.
2180         * gdb_bfd.c: Likewise.
2181         * gdbsupport/gdb_vecs.h: Likewise.
2182         * gdbsupport/vec.c: Remove.
2183         * gdbsupport/vec.h: Remove.
2184         * gdbthread.h: Likewise.
2185         * guile/scm-type.c: Likewise.
2186         * inline-frame.c: Likewise.
2187         * machoread.c: Likewise.
2188         * memattr.c: Likewise.
2189         * memrange.h: Likewise.
2190         * namespace.h: Likewise.
2191         * nat/linux-btrace.h: Likewise.
2192         * osdata.c: Likewise.
2193         * parser-defs.h: Likewise.
2194         * progspace.h: Likewise.
2195         * python/py-type.c: Likewise.
2196         * record-btrace.c: Likewise.
2197         * rust-exp.y: Likewise.
2198         * solib-target.c: Likewise.
2199         * stap-probe.c: Likewise.
2200         * target-descriptions.c: Likewise.
2201         * target-memory.c: Likewise.
2202         * target.h: Likewise.
2203         * varobj.c: Likewise.
2204         * varobj.h: Likewise.
2205         * xml-support.h: Likewise.
2206
2207 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2210         Update for new std::vector based implementation.
2211         (process_psymtab_comp_unit_reader): Likewise.
2212         (scan_partial_symbols): Likewise.
2213         (recursively_compute_inclusions): Likewise.
2214         (compute_compunit_symtab_includes): Likewise.
2215         (process_imported_unit_die): Likewise.
2216         (queue_and_load_dwo_tu): Likewise.
2217         (follow_die_sig_1): Likewise.
2218         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2219         (typedef dwarf2_per_cu_ptr): Remove.
2220         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2221         function.
2222         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2223         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2224         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2225         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2226         std::vector.
2227
2228 2019-10-15  Tom Tromey  <tromey@adacore.com>
2229
2230         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2231         TID.
2232
2233 2019-10-15  Tom Tromey  <tromey@adacore.com>
2234
2235         * windows-nat.c (windows_nat_target::fetch_registers)
2236         (windows_nat_target::store_registers): Rename "pid" to "tid".
2237
2238 2019-10-15  Tom Tromey  <tromey@adacore.com>
2239
2240         * gdbarch.h, gdbarch.c: Rebuild.
2241         * gdbarch.sh (gcc_target_options): Change return type to
2242         std::string.
2243         * compile/compile.c (get_args): Update.
2244         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2245         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2246         std::string.
2247         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2248         std::string.
2249         * arch-utils.c (default_gcc_target_options): Return std::string.
2250         * arch-utils.h (default_gcc_target_options): Return std::string.
2251         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2252
2253 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2254
2255         * breakpoint.c (breakpoint_chain): Make static.
2256         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2257         of accessing breakpoint_chain.
2258
2259 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2260
2261         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2262         to a gdb::function_view and return value to bool.
2263         * breakpoint.h (iterate_over_breakpoints): Likewise.
2264         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2265         (pop_dummy_frame): Update.
2266         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2267         (gdbscm_breakpoints): Update.
2268         * python/py-breakpoint.c (build_bp_list): Update.
2269         (gdbpy_breakpoints): Update.
2270         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2271         Update.
2272         (bpfinishpy_handle_stop): Update.
2273         (bpfinishpy_handle_exit): Update.
2274         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2275         (svr4_update_solib_event_breakpoints): Update.
2276
2277 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2278
2279         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2280         when unwrapping single-field structs.
2281
2282 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2283
2284         * dwarf2read.c: Remove includes.
2285
2286 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2287
2288         * ui-out.c (ui_out::call_do_message): Silence
2289         -Wformat-nonliteral warning.
2290
2291 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2292
2293         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2294         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2295         include: readline/tilde.h.
2296
2297 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2298
2299         * remote.c (remote_target::get_trace_status): Remove declaration of
2300         trace_regblock_size.
2301
2302 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2303
2304         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2305         (show_user): Remove declaration of cmdlist.
2306         * cli/cli-cmds.h (max_user_call_depth): Declare.
2307         * cli/cli-script.c (execute_user_command): Remove declaration
2308         of max_user_call_depth.
2309
2310 2019-10-11  Jim Wilson  <jimw@sifive.com>
2311
2312         * gdbsupport/print-utils.h (pulongest): Fix comment.
2313         (plongest): Likewise.
2314         (phex): Add missing comment, mention leading zeros.
2315         (phex_nz): Add mention of no leading zeros to comment.
2316
2317         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2318         plongest instead of unsigned long long cast.
2319
2320 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2323         for external_editor_command and gdbtk_test.
2324
2325 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2326
2327         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2328         * varobj.c (varobjdebug): Move comment to...
2329         * varobj.h (varobjdebug): ...here, and declare.
2330
2331 2019-10-09  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2334         erase_data_content.
2335
2336 2019-10-09  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2339         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2340         * tui/tui-command.c (tui_cmd_window::resize)
2341         (tui_refresh_cmd_win): Update.
2342         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2343         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2344         * tui/tui-data.c (~tui_gen_win_info): Remove.
2345         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2346         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2347         (tui_redisplay_readline, tui_mld_flush)
2348         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2349         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2350         (tui_data_window::erase_data_content)
2351         (tui_data_item_window::rerender)
2352         (tui_data_item_window::refresh_window): Update.
2353         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2354         (box_win, tui_gen_win_info::make_window)
2355         (tui_gen_win_info::make_visible): Update.
2356         (tui_delete_win): Remove.
2357         * tui/tui-winsource.c
2358         (tui_source_window_base::do_erase_source_content): Update.
2359         (tui_show_source_line, tui_source_window_base::update_tab_width)
2360         (tui_source_window_base::update_exec_info): Update.
2361         * tui/tui-data.h (struct curses_deleter): New.
2362         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2363         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2364
2365 2019-10-09  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2368
2369 2019-10-09  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2372         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2373
2374 2019-10-09  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2377         window height directly.
2378         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2379         declare.
2380         * tui/tui-layout.c (tui_default_win_height): Remove.
2381         (tui_default_win_viewport_height): Remove.
2382
2383 2019-10-09  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui.h: Remove comments.
2386
2387 2019-10-09  Tom de Vries  <tdevries@suse.de>
2388
2389         * python/lib/gdb/printer/bound_registers.py: Use
2390         '^builtin_type_bound128' as regexp argument for
2391         add_builtin_pretty_printer.
2392
2393 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2394
2395         * guile/guile.c (guile_extension_script_ops): Remove forward
2396         declaration and mark as static.
2397         (guile_script_ops): Likewise.
2398         (extension_language_guile): Move further down in the file so
2399         it can reference the definitions for guile_{extension_,}script_ops.
2400
2401 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2402
2403         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2404         except SORTL, DFLTCC, and KDSA.
2405
2406 2019-10-08  Tom Tromey  <tromey@adacore.com>
2407
2408         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2409         (struct safe_symbol_file_add_args): Remove.
2410
2411 2019-10-08  Tom Tromey  <tromey@adacore.com>
2412
2413         * windows-nat.c: Don't include buildsym-legacy.h.
2414
2415 2019-10-08  Tom Tromey  <tromey@adacore.com>
2416
2417         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2418
2419 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2420
2421         * gdbtypes.c (overload_debug): Move comment to header.
2422         * gdbtypes.h (overload_debug): Declare.
2423         * valops.c: Remove declaration of overload_debug, instead
2424         include gdbtypes.h.
2425
2426 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2427
2428         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2429         through _().
2430         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2431         move comment...
2432         * language.h (lang_frame_mismatch_warn): ... here. Also add
2433         declaration.
2434         * top.c (lang_frame_mismatch_warn): Remove declaration.
2435         (check_frame_language_change): Pass lang_frame_mismatch_warn
2436         through _().
2437
2438 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * c-lang.h (vtbl_ptr_name): Declare.
2441         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2442         it from the header.
2443         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2444
2445 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2446
2447         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2448         gdb_static_assert.
2449
2450 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2451
2452         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2453         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2454         * ctfread.c: New file.
2455         * ctfread.h: New file.
2456         * elfread.c: Include ctfread.h.
2457         (struct elfinfo text_p): New member ctfsect.
2458         (elf_locate_sections): Mark CTF section.
2459         (elf_symfile_read): Call elfctf_build_psymtabs.
2460         * Makefile.in (LIBCTF): Add.
2461         (CLIBS): Use it.
2462         (CDEPS): Likewise.
2463         (DIST): Add ctfread.c.
2464
2465 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * ctfread.c (struct nextfield): Renamed to ...
2468         (struct ctf_nextfield): ... this.
2469         (struct field_info): Renamed to ...
2470         (strut ctf_field_info): ... this.
2471         (attach_fields_to_type): Update for renamed structures.
2472         (ctf_add_member_cb): Likewise.
2473         (ctf_add_enum_member_cb): Likewise.
2474         (process_struct_members): Likewise.
2475         (process_enum_type): Likewise.
2476
2477 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2478
2479         * tracectf.h: Rename, was ctf.h.
2480         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2481         * tracefile.c: Likewise.
2482         * tracepoint.c: Remove unused include ctf.h.
2483         * mi/mi-main.c: Likewise.
2484         * Makefile.in Replace ctf.c with tracectf.c.
2485
2486 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2487
2488         * version.in: Change version number to "9.0.50.DATE-git".
2489
2490 2019-10-03  Tom Tromey  <tom@tromey.com>
2491
2492         PR rust/24976:
2493         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2494
2495 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2496
2497         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2498         cp_search_name_hash.
2499         * NEWS: Add entry about nested function support.
2500
2501 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2502             Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2505         for nested static variables when searchin VAR_DOMAIN.
2506         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2507         global scope, update comment.
2508         (add_partial_subprogram): Call add_partial_subprogram recursively
2509         for nested subroutines when processinng Fortran.
2510         (load_partial_dies): Process the child entities of a subprogram
2511         when processing Fortran.
2512         (partial_die_parent_scope): Handle building scope
2513         for Fortran nested functions.
2514         (process_die): Record that nested functions have a scope.
2515         (new_symbol): Always record Fortran subprograms on the global
2516         symbol list.
2517         (determine_prefix): How to build the prefix for Fortran
2518         subprograms.
2519
2520 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2523         have just sent the thread a SIGSTOP and are waiting for it to
2524         arrive.
2525
2526 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * btrace.c (btrace_add_pc): Remove whitespace before the template
2529         parameter in 'std::vector <...>'.
2530         (parse_xml_btrace_block): Likewise.
2531         (btrace_maint_decode_pt): Likewise.
2532         (btrace_maint_update_packets): Likewise.
2533         (btrace_maint_print_packets): Likewise.
2534         * btrace.h (struct btrace_maint_info): Likewise.
2535         * dwarf2read.c (struct type_unit_group): Likewise.
2536         (build_type_psymtabs_reader): Likewise.
2537         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2538         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2539         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2540
2541 2019-10-03  Tom de Vries  <tdevries@suse.de>
2542
2543         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2544         the first line of the help text for set/show style metadata.
2545
2546 2019-10-02  Tom Tromey  <tromey@adacore.com>
2547
2548         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2549         * gdbsupport/common-inferior.c: New file.
2550         * infcmd.c (startup_with_shell): Don't define.
2551         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2552         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2553         * inferior.h (startup_with_shell): Don't declare.
2554
2555 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2556
2557         * gdbsupport/gdb_assert.h: Include errors.h.
2558         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2559
2560 2019-10-02  Tom Tromey  <tromey@adacore.com>
2561
2562         * NEWS: Add $_ada_exception entry.
2563         * ada-lang.c (struct ada_catchpoint): Add constructor.
2564         <m_kind>: New member.
2565         (allocate_location_exception, re_set_exception): Remove
2566         "ex" parameter.
2567         (should_stop_exception): Compute $_ada_exception.
2568         (check_status_exception, print_it_exception)
2569         (print_one_exception, print_mention_exception): Remove
2570         "ex" parameter.
2571         (allocate_location_catch_exception, re_set_catch_exception)
2572         (check_status_exception, print_it_catch_exception)
2573         (print_one_catch_exception, print_mention_catch_exception)
2574         (print_recreate_catch_exception)
2575         (allocate_location_catch_exception_unhandled)
2576         (re_set_catch_exception_unhandled)
2577         (check_status_exception, print_it_catch_exception_unhandled)
2578         (print_one_catch_exception_unhandled)
2579         (print_mention_catch_exception_unhandled)
2580         (print_recreate_catch_exception_unhandled)
2581         (allocate_location_catch_assert, re_set_catch_assert)
2582         (check_status_assert, print_it_catch_assert)
2583         (print_one_catch_assert, print_mention_catch_assert)
2584         (print_recreate_catch_assert)
2585         (allocate_location_catch_handlers, re_set_catch_handlers)
2586         (check_status_handlers, print_it_catch_handlers)
2587         (print_one_catch_handlers, print_mention_catch_handlers)
2588         (print_recreate_catch_handlers): Remove.
2589         (create_ada_exception_catchpoint): Update.
2590         (initialize_ada_catchpoint_ops): Update.
2591
2592 2019-10-02  Tom Tromey  <tromey@adacore.com>
2593
2594         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2595         (create_excep_cond_exprs): Simplify exception string computation.
2596         (ada_exception_catchpoint_cond_string): Likewise.
2597
2598 2019-10-02  Tom Tromey  <tromey@adacore.com>
2599
2600         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2601         * ada-lang.c (lesseq_defined_than): Handle
2602         LOC_STATIC.
2603         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2604         parameter.
2605         (dwarf2_has_info): Likewise.
2606         (new_symbol): Set maybe_copied on symbol when
2607         appropriate.
2608         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2609         parameter.
2610         <can_copy>: New member.
2611         * elfread.c (record_minimal_symbol): Set maybe_copied
2612         on symbol when appropriate.
2613         (elf_symfile_read): Update call to dwarf2_has_info.
2614         * minsyms.c (lookup_minimal_symbol_linkage): New
2615         function.
2616         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2617         * symtab.c (get_symbol_address, get_msymbol_address):
2618         New functions.
2619         * symtab.h (get_symbol_address, get_msymbol_address):
2620         Declare.
2621         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2622         maybe_copied.
2623         (struct symbol, struct minimal_symbol) <maybe_copied>:
2624         New member.
2625
2626 2019-10-02  Tom Tromey  <tromey@adacore.com>
2627
2628         * source.c (struct current_source_location): New.
2629         (current_source_key): New global.
2630         (current_source_symtab, current_source_line)
2631         (current_source_pspace): Remove.
2632         (get_source_location): New function.
2633         (get_current_source_symtab_and_line)
2634         (set_default_source_symtab_and_line)
2635         (set_current_source_symtab_and_line)
2636         (clear_current_source_symtab_and_line, select_source_symtab)
2637         (info_source_command, print_source_lines_base)
2638         (info_line_command, search_command_helper, _initialize_source):
2639         Update.
2640
2641 2019-10-02  Tom Tromey  <tromey@adacore.com>
2642
2643         * source.c (select_source_symtab): Don't call
2644         decode_line_with_current_source.
2645
2646 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * symtab.c (lookup_global_symbol): Search global block.
2649
2650 2019-10-02  Tom Tromey  <tromey@adacore.com>
2651
2652         * coffread.c (process_coff_symbol): Update.
2653         * dwarf2read.c (var_decode_location, new_symbol): Update.
2654         * mdebugread.c (parse_symbol): Update.
2655         * objfiles.c (relocate_one_symbol): Update.
2656         * stabsread.c (define_symbol, fix_common_block)
2657         (scan_file_globals): Update.
2658         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2659         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2660         * xcoffread.c (process_xcoff_symbol): Update.
2661
2662 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2663
2664         * MAINTAINERS: Update my email address.
2665
2666 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2669         std::vector.
2670         (build_type_psymtabs_reader): Update for std::vector.
2671         (build_type_psymtab_dependencies): Likewise.
2672         * dwarf2read.h: Remove use of DEF_VEC_P.
2673         (typedef sig_type_ptr): Delete.
2674
2675 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2676
2677         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2678         to std::vector.
2679         (btrace_maint_decode_pt): Likewise, and move allocation of the
2680         vector outside of the loop.
2681         (btrace_maint_update_packets): Update to handle change from VEC to
2682         std::vector.
2683         (btrace_maint_print_packets): Likewise.
2684         (maint_info_btrace_cmd): Likewise.
2685         * btrace.h: Remove use of DEF_VEC_O.
2686         (typedef btrace_pt_packet_s): Delete.
2687         (struct btrace_maint_info) <packets>: Change fromm VEC to
2688         std::vector.
2689         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2690
2691 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2694         make accesses into the vector constant references.
2695         (btrace_add_pc): Update for std::vector.
2696         (btrace_stitch_bts): Likewise.
2697         (parse_xml_btrace_block): Likewise.
2698         (btrace_maint_update_packets): Likewise.
2699         (btrace_maint_print_packets): Likewise.
2700         (maint_info_btrace_cmd): Likewise.
2701         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2702         std::vector.
2703         (btrace_data::empty): Likewise.
2704         (btrace_data_append): Likewise.
2705         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2706         (typedef btrace_block_s): Delete.
2707         (struct btrace_block): Add constructor.
2708         (struct btrace_data_bts) <blocks>: Change to std::vector.
2709         * nat/linux-btrace.c (perf_event_read_bts): Update for
2710         std::vector.
2711         (linux_read_bts): Likewise.
2712
2713 2019-10-01  Tom Tromey  <tom@tromey.com>
2714
2715         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2716
2717 2019-10-01  Tom Tromey  <tom@tromey.com>
2718
2719         * stack.c (print_frame, info_frame_command_core): Use
2720         styled_string.
2721         * linux-thread-db.c (try_thread_db_load_1)
2722         (try_thread_db_load_from_pdir_1): Use styled_string.
2723         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2724         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2725         (maybe_print_unsupported_script_warning)
2726         (maybe_print_script_not_found_warning): Use styled_string.
2727         * ada-lang.c (user_select_syms): Use styled_string.
2728
2729 2019-10-01  Tom Tromey  <tom@tromey.com>
2730
2731         * p-lang.c (pascal_printstr): Use metadata style.
2732         * value.c (show_convenience): Use metadata style.
2733         * valprint.c (valprint_check_validity, val_print_optimized_out)
2734         (val_print_not_saved, val_print_unavailable)
2735         (val_print_invalid_address, generic_val_print, val_print)
2736         (value_check_printable, val_print_array_elements): Use metadata
2737         style.
2738         * ui-out.h (class ui_out) <field_fmt>: New overload.
2739         <do_field_fmt>: Add style parameter.
2740         * ui-out.c (ui_out::field_fmt): New overload.
2741         * typeprint.c (type_print_unknown_return_type)
2742         (val_print_not_allocated, val_print_not_associated): Use metadata
2743         style.
2744         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2745         parameter.
2746         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2747         * tracepoint.c (tvariables_info_1): Use metadata style.
2748         * stack.c (print_frame_arg, print_frame_info, print_frame)
2749         (info_frame_command_core): Use metadata style.
2750         * skip.c (info_skip_command): Use metadata style.
2751         * rust-lang.c (rust_print_enum): Use metadata style.
2752         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2753         metadata style.
2754         * python/py-framefilter.c (py_print_single_arg): Use metadata
2755         style.
2756         * printcmd.c (do_one_display, print_variable_and_value): Use
2757         metadata style.
2758         * p-valprint.c (pascal_val_print)
2759         (pascal_object_print_value_fields): Use metadata style.
2760         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2761         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2762         parameter.
2763         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2764         * m2-valprint.c (m2_print_long_set): Use metadata style.
2765         * m2-typeprint.c (m2_print_type): Use metadata style.
2766         * infcmd.c (print_return_value_1): Use metadata style.
2767         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2768         * f-valprint.c (info_common_command_for_block): Use metadata
2769         style.
2770         * f-typeprint.c (f_type_print_base): Use metadata style.
2771         * expprint.c (print_subexp_standard): Use metadata style.
2772         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2773         * cli/cli-style.h (class cli_style_option): Add constructor.
2774         (metadata_style): Declare.
2775         * cli/cli-style.c (metadata_style): New global.
2776         (_initialize_cli_style): Register metadata style.
2777         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2778         parameter.
2779         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2780         * c-typeprint.c (c_type_print_base_struct_union)
2781         (c_type_print_base_1): Use metadata style.
2782         * breakpoint.c (watchpoint_value_print)
2783         (print_one_breakpoint_location): Use metadata style.
2784         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2785         style.
2786         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2787         style.
2788         * ada-valprint.c (val_print_packed_array_elements, printstr)
2789         (print_field_values, ada_val_print_ref, ada_val_print): Use
2790         metadata style.
2791         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2792         style.
2793         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2794         style.
2795         * ada-lang.c (user_select_syms): Use metadata style.
2796
2797 2019-10-01  Tom Tromey  <tom@tromey.com>
2798
2799         * cli/cli-cmds.c (pwd_command): Style output.
2800
2801 2019-10-01  Pedro Alves  <palves@redhat.com>
2802             Tom Tromey  <tom@tromey.com>
2803
2804         * symtab.c (print_symbol_info): Use %ps.
2805         (print_msymbol_info): Use %ps.
2806         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2807         * printcmd.c (print_variable_and_value): Use %ps.
2808         * macrocmd.c (show_pp_source_pos): Use %ps.
2809         * infrun.c (print_exited_reason): Use ui_out::message.
2810         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2811         (describe_other_breakpoints): Use ui_out::message and new
2812         formats.
2813         (say_where): Use new formats.
2814         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2815         and new formats.
2816
2817 2019-10-01  Pedro Alves  <palves@redhat.com>
2818             Tom Tromey  <tom@tromey.com>
2819
2820         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2821         (test_gdb_formats): New function.
2822         (run_tests): Call it.
2823         (test_format_specifier): Update.
2824         * utils.h (fputs_filtered): Update comment.
2825         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2826         (fputs_styled_unfiltered): Declare.
2827         * utils.c (fputs_styled_unfiltered): New function.
2828         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2829         (vfprintf_filtered): Update.
2830         (vfprintf_unfiltered, vprintf_filtered): Update.
2831         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2832         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2833         disallow_ui_out_field>: New constants.
2834         (enum class field_kind): New.
2835         (struct base_field_s, struct signed_field_s): New.
2836         (signed_field): New function.
2837         (struct string_field_s): New.
2838         (string_field): New function.
2839         (struct styled_string_s): New.
2840         (styled_string): New function.
2841         (class ui_out) <message>: Add comment.
2842         <vmessage, call_do_message>: New methods.
2843         <do_message>: Add style parameter.
2844         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2845         methods.
2846         (ui_out::message): Rewrite.
2847         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2848         parameter.
2849         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2850         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2851         gdb_extensions parameter.
2852         (class format_piece): Add parameter to constructor.
2853         (n_int_args): New field.
2854         * gdbsupport/format.c (format_pieces::format_pieces): Add
2855         gdb_extensions parameter.  Handle '*'.
2856         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2857         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2858         vfprintf_styled_no_gdbfmt.
2859         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2860         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2861         unfiltered output.
2862         * ui-style.h (struct ui_file_style) <ptr>: New method.
2863
2864 2019-10-01  Tom Tromey  <tom@tromey.com>
2865
2866         * unittests/format_pieces-selftests.c: Update.  Add final format.
2867         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2868         empty literal pieces.
2869
2870 2019-10-01  Tom Tromey  <tom@tromey.com>
2871
2872         * ui-out.h (enum class ui_out_style_kind): Remove.
2873         (class ui_out) <field_string, field_stsream, do_field_string>:
2874         Change type of "style".
2875         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2876         (ui_out::field_string): Update.
2877         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2878         of "style".
2879         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2880         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2881         * stack.c (print_frame_arg, print_frame_info, print_frame):
2882         Update.
2883         * source.c (print_source_lines_base): Update.
2884         * solib.c (info_sharedlibrary_command): Update.
2885         * skip.c (info_skip_command): Update.
2886         * record-btrace.c (btrace_call_history_src_line)
2887         (btrace_call_history): Update.
2888         * python/py-framefilter.c (py_print_frame): Update.
2889         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2890         "style".
2891         * mi/mi-out.c (mi_ui_out::do_table_header)
2892         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2893         (mi_ui_out::do_field_string): Update.
2894         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2895         Update.
2896         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2897         "style".
2898         * cli-out.c (cli_ui_out::do_table_header)
2899         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2900         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2901         (cli_ui_out::do_field_fmt): Update.
2902         * breakpoint.c (print_breakpoint_location): Update.
2903         (update_static_tracepoint): Update.
2904
2905 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2906
2907         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2908         conversion of gdb_datadir.
2909         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2910         remove not needed c_str ().
2911
2912 2019-09-30  Ali Tamur <tamur@google.com>
2913
2914         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2915         (dwarf2_string_attr): Likewise.
2916
2917 2019-09-30  Ali Tamur <tamur@google.com>
2918
2919         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2920         (process_full_type_unit): Likewise.
2921         (dump_die_shallow): Likewise.
2922         (cu_debug_loc_section): Likewise.
2923
2924 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2925
2926         * minsyms.c (compare_minimal_symbols): Rename to...
2927         (minimal_symbol_is_less_than): ...this, and adjust to STL
2928         conventions (return bool, take arguments as references)
2929         (minimal_symbol_reader::install): Call std::sort instead
2930         of qsort.
2931
2932 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2933
2934         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2935         hash and why.
2936         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2937         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2938
2939 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2940
2941         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2942         * psympriv.h (add_psymbol_to_list): Move comment here and update
2943         it.
2944
2945 2019-09-29  Tom de Vries  <tdevries@suse.de>
2946
2947         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2948         Use $tmpdir/$(basename "$output_file").dwz instead of
2949         "${output_file}.dwz".
2950
2951 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2952
2953         PR gdb/25045
2954         * hppa-linux-nat.c: Include gdbarch.h.
2955
2956 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2957
2958         * blockframe.c (find_pc_partial_function): Change return type to bool.
2959         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2960         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2961         (stub_gnu_ifunc_resolve_name): Likewise.
2962         * symtab.c (compare_filenames_for_search): Likewise.
2963         (compare_glob_filenames_for_search): Likewise.
2964         (matching_obj_sections): Likewise.
2965         (symbol_matches_domain): Likewise.
2966         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2967         (find_line_pc): Change return type to bool.
2968         (find_line_pc_range): Likewise.
2969         (producer_is_realview): Likewise.
2970         * symtab.h (symbol_matches_domain): Likewise.
2971         (find_pc_partial_function): Likewise.
2972         (find_pc_line_pc_range): Likewise.
2973         (in_gnu_ifunc_stub): Likewise.
2974         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2975         (find_line_pc): Likewise.
2976         (find_line_pc_range): Likewise.
2977         (matching_obj_sections): Likewise.
2978         (find_line_symtab): Change out parameter to bool.
2979         (producer_is_realview): Change return type to bool.
2980         (compare_filenames_for_search): Likewise.
2981         (compare_glob_filenames_for_search): Likewise.
2982
2983 2019-09-26  Tom Tromey  <tom@tromey.com>
2984
2985         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2986         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2987         * gdb_usleep.h: Remove.
2988         * gdb_usleep.c: Remove.
2989         * utils.c: Don't include gdb_usleep.h.
2990
2991 2019-09-26  Tom Tromey  <tromey@adacore.com>
2992
2993         * python/py-type.c (type_to_type_object): Call check_typedef
2994         for stub types.
2995
2996 2019-09-26  Tom Tromey  <tom@tromey.com>
2997
2998         * utils.h (initialize_utils): Don't declare.
2999         * top.c (gdb_init): Don't call initialize_utils.
3000         * utils.c (initialize_utils): Remove.  Move contents...
3001         (_initialize_utils): ... here.
3002
3003 2019-09-25  Tom Tromey  <tom@tromey.com>
3004
3005         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3006         * utils.h (make_hex_string): Don't declare.
3007         * utils.c (make_hex_string): Remove.
3008
3009 2019-09-24  Tom de Vries  <tdevries@suse.de>
3010
3011         PR gdb/23815
3012         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3013         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3014
3015 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3016
3017         * NEWS: Mention new simulator port for PRU.
3018
3019 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3020
3021         * ada-exp.y (write_object_remaining): Update.
3022         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3023         and eliminate the static buffer.
3024         (ada_decode_symbol): Update.
3025         (ada_la_decode): Update.
3026         (ada_sniff_from_mangled_name): Update.
3027         (is_valid_name_for_wild_match): Update.
3028         (ada_lookup_name_info::matches): Update and simplify.
3029         (name_matches_regex): Update.
3030         (ada_add_global_exceptions): Update.
3031         * ada-lang.h (ada_decode): Update signature.
3032         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3033         * dwarf-index-write.c (debug_names::insert): Update.
3034
3035 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3036
3037         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3038         formatting.
3039
3040 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3041
3042         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3043         Change "nonzero" to "true" in documentation.
3044
3045 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3046
3047         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3048         (_initialize_darwin_solib): Don't set
3049         darwin_so_ops.lookup_lib_global_symbol.
3050         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3051         set_gdbarch_iterate_over_objfiles_in_search_order.
3052         (elf_lookup_lib_symbol): Rename to...
3053         (svr4_iterate_over_objfiles_in_search_order): this, and update
3054         to iterate semantics.
3055         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3056         * solib.c (solib_global_lookup): Remove.
3057         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3058         (solib_global_lookup): Remove.
3059         * symtab.c (lookup_global_or_static_symbol): Remove call to
3060         solib_global_lookup.
3061
3062 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3063
3064         * NEWS: Move entries about default MI version now being
3065         version 3, and about the GDB/MI fix for multi-location
3066         breakpoints to the "since GDB 8.3" section.
3067
3068 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3069
3070         GDB 8.3.1 released.
3071
3072 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3073
3074         * NEWS: Mention that Cell/B.E. debugging support was removed.
3075         * MAINTAINERS: Remove spu target.
3076
3077         * config/djgpp/fnchange.lst: Remove entries for removed files.
3078
3079         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3080         spu-multiarch.o, and spu-tdep.o.
3081         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3082         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3083         spu-multiarch.c, and spu-tdep.c.
3084         * spu-linux-nat.c: Remove file.
3085         * spu-multiarch.c: Remove file.
3086         * spu-tdep.c: Remove file.
3087         * spu-tdep.h: Remove file.
3088         * solib-spu.c: Remove file.
3089         * solib-spu.h: Remove file.
3090
3091         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3092         * configure.nat (spu-linux): Remove.
3093         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3094         solib-multiarch.o from gdb_target_obs.
3095         (spu*-*-*): Remove.
3096
3097         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3098         feature flag.
3099         (ppc_linux_no_features): Update.
3100         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3101         Cell/B.E. support.
3102         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3103         (tdesc_powerpc_cell64l): Likewise.
3104         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3105         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3106         Cell/B.E. support.
3107         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3108         Do not include "features/rs6000/powerpc-cell32l.c" or
3109         "features/rs6000/powerpc-cell64l.c".
3110         (ppc_linux_spu_section): Remove.
3111         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3112         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3113         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3114         (ppc_linux_spe_context_lookup): Remove.
3115         (ppc_linux_spe_context_inferior_created): Remove.
3116         (ppc_linux_spe_context_solib_loaded): Remove.
3117         (ppc_linux_spe_context_solib_unloaded): Remove.
3118         (ppc_linux_spe_context): Remove.
3119         (struct ppu2spu_cache): Remove.
3120         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3121         (struct ppu2spu_data): Remove.
3122         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3123         ppu2spu_unwind): Remove.
3124         (ppc_linux_init_abi): Remove Cell/B.E. support.
3125         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3126
3127         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3128         (rs6000/powerpc-cell64l-expedite): Likewise
3129         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3130         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3131         rs6000/powerpc-cell64l.xml.
3132         * features/rs6000/powerpc-cell32l.xml: Remove.
3133         * features/rs6000/powerpc-cell64l.xml: Likewise.
3134         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3135         * features/rs6000/powerpc-cell64l.c: Likewise.
3136         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3137         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3138         * regformats/reg-spu.dat: Remove.
3139
3140         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3141         * corelow.c (struct spuid_list): Remove.
3142         (add_to_spuid_list): Remove.
3143         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3144         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3145         (remote_protocol_features): Remove associated entries.
3146         (_initialize_remote): No longer initialize them.
3147         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3148         * linux-nat.c (SPUFS_MAGIC): Remove.
3149         (linux_proc_xfer_spu): Remove.
3150         (spu_enumerate_spu_ids): Remove.
3151         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3152         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3153         (linux_make_corefile_notes): No longer call it.
3154
3155         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3156         (cooked_write_test): Likewise.
3157
3158 2019-09-20  Tom Tromey  <tom@tromey.com>
3159
3160         * NEWS: Mention case-sensitivity of TUI commands.
3161         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3162         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3163         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3164
3165 2019-09-20  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-source.c (tui_source_window::set_contents): Use
3168         make_unique_xstrdup.
3169         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3170         make_unique_xstrdup.
3171
3172 2019-09-20  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-data.c: Remove separator comments.
3175         * tui/tui-layout.c: Remove separator comments.
3176         * tui/tui-win.c: Remove separator comments.
3177         * tui/tui-wingeneral.c: Remove separator comments.
3178
3179 2019-09-20  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui.h (strcat_to_buf): Don't declare.
3182         * tui/tui.c (strcat_to_buf): Remove.
3183
3184 2019-09-20  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3187         from "fullname".
3188         * tui/tui-source.c (tui_source_window::set_contents)
3189         (tui_source_window::location_matches_p)
3190         (tui_source_window::maybe_update): Update.
3191
3192 2019-09-20  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3195         Update.
3196         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3197         prefix.
3198         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3199         (tui_data_window::line_from_reg_element_no)
3200         (tui_data_window::first_reg_element_no_inline)
3201         (tui_data_window::show_registers)
3202         (tui_data_window::show_register_group)
3203         (tui_data_window::display_registers_from)
3204         (tui_data_window::display_registers_from_line)
3205         (tui_data_window::first_data_item_displayed)
3206         (tui_data_window::delete_data_content_windows)
3207         (tui_data_window::erase_data_content)
3208         (tui_data_window::do_scroll_vertical)
3209         (tui_data_window::refresh_window)
3210         (tui_data_window::check_register_values): Update.
3211
3212 2019-09-20  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3215         (struct tui_locator_window) <full_name, proc_name>: Now
3216         std::string.
3217         * tui/tui-stack.c (tui_locator_window::make_status_line)
3218         (tui_locator_window::set_locator_fullname)
3219         (tui_locator_window::set_locator_info): Update.
3220         * tui/tui-source.c (tui_source_window::set_contents)
3221         (tui_source_window::showing_source_p): Update.
3222
3223 2019-09-20  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3226         Don't call tui_locator_win_info_ptr.
3227
3228 2019-09-20  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3231
3232 2019-09-20  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3235         height for locator.
3236         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3237         * tui/tui-layout.c (show_source_disasm_command, show_data)
3238         (show_source_or_disasm_and_command): Use 1 as height for locator.
3239
3240 2019-09-20  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui.c (tui_enable): Update.
3243         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3244         Update.
3245         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3246         Update.
3247         * tui/tui-data.c (win_resized): Now bool.
3248         (tui_win_resized): Return bool.
3249         (tui_set_win_resized_to): Accept a bool.
3250
3251 2019-09-20  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3254         Change type of "refresh_values_only".
3255         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3256         type of "refresh_values_only".
3257
3258 2019-09-20  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3261         std::string.
3262         (tui_disassemble): Add "pos" parameter.
3263         (tui_disasm_window::set_contents): Simplify.
3264
3265 2019-09-20  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-winsource.h (struct tui_source_window_base)
3268         <show_source_content>: Now private.
3269         * tui/tui-winsource.c
3270         (tui_source_window_base::show_source_content): Don't handle empty
3271         content case.
3272
3273 2019-09-20  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-layout.c (show_source_disasm_command)
3276         (show_source_or_disasm_and_command): Don't call
3277         show_source_content.
3278
3279 2019-09-20  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3282         Declare.
3283         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3284         from tui_make_status_line.
3285         (tui_locator_window::rerender): Update.
3286
3287 2019-09-20  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3290         (tui_locator_window::rerender): Update.
3291
3292 2019-09-20  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-winsource.h (struct tui_source_window_base)
3295         <~tui_source_window_base>: Don't declare.
3296         <fullname>: Remove.
3297         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3298         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3299         member.
3300         * tui/tui-source.c (tui_source_window::set_contents): Update.
3301         (tui_source_window::location_matches_p)
3302         (tui_source_window::maybe_update): Update.
3303
3304 2019-09-20  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-winsource.h (~tui_source_element): Remove.
3307         (tui_source_element): Update.
3308         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3309         * tui/tui-winsource.c (tui_show_source_line): Update.
3310         * tui/tui-source.c (tui_source_window::set_contents): Update.
3311         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3312
3313 2019-09-20  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3316         declare.
3317         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3318         tui_clear_source_windows_detail.
3319         * tui/tui-winsource.h (struct tui_source_window_base)
3320         <clear_detail>: Don't declare.
3321         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3322         Remove.
3323         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3324
3325 2019-09-20  Tom Tromey  <tromey@adacore.com>
3326
3327         PR ada/24919:
3328         * block.c (contained_in): Fix final return value.
3329
3330 2019-09-20  Alan Modra  <amodra@gmail.com>
3331
3332         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3333         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3334         (read_indirect_string_from_dwz): Use bfd accessor.
3335         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3336         * machoread.c (macho_symfile_read_all_oso): Likewise.
3337         * solib.c (solib_bfd_open): Likewise.
3338
3339 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3340
3341         * eval.c: Move declaration of overload_resolution to...
3342         * value.h: ...here.
3343
3344 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3345
3346         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3347         * arm-linux-tdep.c: Likewise.
3348         * arm-nbsd-nat.c: Likewise.
3349         * arm-tdep.h: Declare arm_apcs_32.
3350         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3351
3352 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3353
3354         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3355         * dwarf2read.h: Declare dwarf_always_disassemble.
3356
3357 2019-09-19  Tom de Vries  <tdevries@suse.de>
3358
3359         PR gdb/25009
3360         * source-cache.c (source_cache::ensure): Catch exception thrown during
3361         construction of the highlighter.
3362
3363 2019-09-18  Alan Modra  <amodra@gmail.com>
3364
3365         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3366         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3367         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3368         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3369         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3370         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3371         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3372         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3373         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3374         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3375         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3376         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3377         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3378         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3379         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3380         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3381         * mi/mi-interp.c: Update throughout for bfd section macro and
3382         function changes.
3383         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3384         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3385
3386 2019-09-18  Tom Tromey  <tom@tromey.com>
3387
3388         * NEWS: Add entry.
3389         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3390         call rl_initialize.
3391         (tui_enable): Do not call rl_initialize.
3392
3393 2019-09-18  Christian Groessler  <chris@groessler.org>
3394
3395         * alpha-linux-nat.c: Include gdbarch.h.
3396
3397 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3398
3399         * ui-file.c: Include cli/cli-style.h.
3400         (term_cli_styling): Remove cli_styling declaration.
3401
3402 2019-09-18  Alan Modra  <amodra@gmail.com>
3403
3404         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3405         to bfd_asymbol_section.
3406
3407 2019-09-18  Alan Modra  <amodra@gmail.com>
3408
3409         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3410         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3411         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3412
3413 2019-09-18  Alan Modra  <amodra@gmail.com>
3414
3415         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3416         * spu-linux-nat.c (spu_bfd_open): Likewise.
3417
3418 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3419
3420         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3421         to bool to match definition in dwarf2read.c.
3422
3423 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3424
3425         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3426         (print_signatures): Likewise.
3427         (trust_pad_over_xvs): Likewise.
3428         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3429         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3430         * arm-linux-nat.c (arm_apcs_32): Likewise.
3431         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3432         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3433         * arm-tdep.c (arm_debug): Likewise.
3434         (arm_apcs_32): Likewise.
3435         * auto-load.c (debug_auto_load): Likewise.
3436         (auto_load_gdb_scripts): Likewise.
3437         (global_auto_load): Likewise.
3438         (auto_load_local_gdbinit): Likewise.
3439         (auto_load_local_gdbinit_loaded): Likewise.
3440         * auto-load.h (global_auto_load): Likewise.
3441         (auto_load_local_gdbinit): Likewise.
3442         (auto_load_local_gdbinit_loaded): Likewise.
3443         * breakpoint.c (disconnected_dprintf): Likewise.
3444         (breakpoint_proceeded): Likewise.
3445         (automatic_hardware_breakpoints): Likewise.
3446         (always_inserted_mode): Likewise.
3447         (target_exact_watchpoints): Likewise.
3448         (_initialize_breakpoint): Update.
3449         * breakpoint.h (target_exact_watchpoints): Change to bool.
3450         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3451         * cli/cli-cmds.c (trace_commands): Likewise.
3452         * cli/cli-cmds.h (trace_commands): Likewise.
3453         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3454         to bool*.
3455         * cli/cli-logging.c (logging_overwrite): Change to bool.
3456         (logging_redirect): Likewise.
3457         (debug_redirect): Likewise.
3458         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3459         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3460         to bool.
3461         <boolean_option_def>: Update.
3462         (struct flag_option_def): Change default type of Context to bool
3463         from int.
3464         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3465         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3466         (get_setshow_command_value_string): Likewise.
3467         * cli/cli-style.c (cli_styling): Change to bool.
3468         (source_styling): Likewise.
3469         * cli/cli-style.h (source_styling): Likewise.
3470         (cli_styling): Likewise.
3471         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3472         to bool.
3473         * command.h (var_types): Update comment.
3474         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3475         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3476         bool.
3477         (debug_compile_cplus_scopes): Likewise.
3478         * compile/compile-internal.h (compile_debug): Likewise.
3479         * compile/compile.c (compile_debug): Likewise.
3480         (struct compile_options) <raw>: Likewise.
3481         * cp-support.c (catch_demangler_crashes): Likewise.
3482         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3483         (usr_cmd_cris_dwarf2_cfi): Likewise.
3484         * csky-tdep.c (csky_debug): Likewise.
3485         * darwin-nat.c (enable_mach_exceptions): Likewise.
3486         * dcache.c (dcache_enabled_p): Likewise.
3487         * defs.h (info_verbose): Likewise.
3488         * demangle.c (demangle): Likewise.
3489         (asm_demangle): Likewise.
3490         * dwarf-index-cache.c (debug_index_cache): Likewise.
3491         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3492         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3493         * dwarf2read.c (check_physname): Likewise.
3494         (use_deprecated_index_sections): Likewise.
3495         (dwarf_always_disassemble): Likewise.
3496         * eval.c (overload_resolution): Likewise.
3497         * event-top.c (set_editing_cmd_var): Likewise.
3498         (exec_done_display_p): Likewise.
3499         * event-top.h (set_editing_cmd_var): Likewise.
3500         (exec_done_display_p): Likewise.
3501         * exec.c (write_files): Likewise.
3502         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3503         (debug_fbsd_nat): Likewise.
3504         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3505         Likewise.
3506         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3507         <backtrace_past_entry> Likewise.
3508         * gdb-demangle.h (demangle): Likewise.
3509         (asm_demangle): Likewise.
3510         * gdb_bfd.c (bfd_sharing): Likewise.
3511         * gdbcore.h (write_files): Likewise.
3512         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3513         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3514         * gdbthread.h (print_thread_events): Likewise.
3515         * gdbtypes.c (opaque_type_resolution): Likewise.
3516         (strict_type_checking): Likewise.
3517         * gnu-nat.c (gnu_debug_flag): Likewise.
3518         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3519         * guile/scm-param.c (pascm_variable): Add boolval.
3520         (add_setshow_generic): Update.
3521         (pascm_param_value): Update.
3522         (pascm_set_param_value_x): Update.
3523         * hppa-tdep.c (hppa_debug): Change to bool..
3524         * infcall.c (may_call_functions_p): Likewise.
3525         (coerce_float_to_double_p): Likewise.
3526         (unwind_on_signal_p): Likewise.
3527         (unwind_on_terminating_exception_p): Likewise.
3528         * infcmd.c (startup_with_shell): Likewise.
3529         * inferior.c (print_inferior_events): Likewise.
3530         * inferior.h (startup_with_shell): Likewise.
3531         (print_inferior_events): Likewise.
3532         * infrun.c (step_stop_if_no_debug): Likewise.
3533         (detach_fork): Likewise.
3534         (debug_displaced): Likewise.
3535         (disable_randomization): Likewise.
3536         (non_stop): Likewise.
3537         (non_stop_1): Likewise.
3538         (observer_mode): Likewise.
3539         (observer_mode_1): Likewise.
3540         (set_observer_mode): Update.
3541         (sched_multi): Change to bool.
3542         * infrun.h (debug_displaced): Likewise.
3543         (sched_multi): Likewise.
3544         (step_stop_if_no_debug): Likewise.
3545         (non_stop): Likewise.
3546         (disable_randomization): Likewise.
3547         * linux-tdep.c (use_coredump_filter): Likewise.
3548         (dump_excluded_mappings): Likewise.
3549         * linux-thread-db.c (auto_load_thread_db): Likewise.
3550         (check_thread_db_on_load): Likewise.
3551         * main.c (captured_main_1): Update.
3552         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3553         xx2_opt, boolean_opt>: Change to bool.
3554         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3555         * maint.c (maintenance_profile_p): Likewise.
3556         (per_command_time): Likewise.
3557         (per_command_space): Likewise.
3558         (per_command_symtab): Likewise.
3559         * memattr.c (inaccessible_by_default): Likewise.
3560         * mi/mi-main.c (mi_async): Likewise.
3561         (mi_async_1): Likewise.
3562         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3563         * nat/fork-inferior.h (startup_with_shell): Likewise.
3564         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3565         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3566         * nios2-tdep.c (nios2_debug): Likewise.
3567         * or1k-tdep.c (or1k_debug): Likewise.
3568         * parse.c (parser_debug): Likewise.
3569         * parser-defs.h (parser_debug): Likewise.
3570         * printcmd.c (print_symbol_filename): Likewise.
3571         * proc-api.c (procfs_trace): Likewise.
3572         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3573         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3574         (set_parameter_value): Update.
3575         (add_setshow_generic): Update.
3576         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3577         to bool*.
3578         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3579         int*.
3580         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3581         * record-btrace.c (record_btrace_target::store_registers): Update.
3582         * record-full.c (record_full_memory_query): Change to bool.
3583         (record_full_stop_at_limit): Likewise.
3584         * record-full.h (record_full_memory_query): Likewise.
3585         * remote-notif.c (notif_debug): Likewise.
3586         * remote-notif.h (notif_debug): Likewise.
3587         * remote.c (use_range_stepping): Likewise.
3588         (interrupt_on_connect): Likewise.
3589         (remote_break): Likewise.
3590         * ser-tcp.c (tcp_auto_retry): Likewise.
3591         * ser-unix.c (serial_hwflow): Likewise.
3592         * skip.c (debug_skip): Likewise.
3593         * solib-aix.c (solib_aix_debug): Likewise.
3594         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3595         (spu_auto_flush_cache_p): Likewise.
3596         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3597         Likewise.
3598         (struct info_print_options) <quiet>: Likewise.
3599         * symfile-debug.c (debug_symfile): Likewise.
3600         * symfile.c (auto_solib_add): Likewise.
3601         (separate_debug_file_debug): Likewise.
3602         * symfile.h (auto_solib_add): Likewise.
3603         (separate_debug_file_debug): Likewise.
3604         * symtab.c (basenames_may_differ): Likewise.
3605         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3606         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3607         (struct info_types_options) <quiet>: Likewise.
3608         * symtab.h (demangle): Likewise.
3609         (basenames_may_differ): Likewise.
3610         * target-dcache.c (stack_cache_enabled_1): Likewise.
3611         (code_cache_enabled_1): Likewise.
3612         * target.c (trust_readonly): Likewise.
3613         (may_write_registers): Likewise.
3614         (may_write_memory): Likewise.
3615         (may_insert_breakpoints): Likewise.
3616         (may_insert_tracepoints): Likewise.
3617         (may_insert_fast_tracepoints): Likewise.
3618         (may_stop): Likewise.
3619         (auto_connect_native_target): Likewise.
3620         (target_stop_and_wait): Update.
3621         (target_async_permitted): Change to bool.
3622         (target_async_permitted_1): Likewise.
3623         (may_write_registers_1): Likewise.
3624         (may_write_memory_1): Likewise.
3625         (may_insert_breakpoints_1): Likewise.
3626         (may_insert_tracepoints_1): Likewise.
3627         (may_insert_fast_tracepoints_1): Likewise.
3628         (may_stop_1): Likewise.
3629         * target.h (target_async_permitted): Likewise.
3630         (may_write_registers): Likewise.
3631         (may_write_memory): Likewise.
3632         (may_insert_breakpoints): Likewise.
3633         (may_insert_tracepoints): Likewise.
3634         (may_insert_fast_tracepoints): Likewise.
3635         (may_stop): Likewise.
3636         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3637         (make_thread_apply_all_options_def_group): Change argument from int*
3638         to bool*.
3639         (thread_apply_all_command): Update.
3640         (print_thread_events): Change to bool.
3641         * top.c (confirm): Likewise.
3642         (command_editing_p): Likewise.
3643         (history_expansion_p): Likewise.
3644         (write_history_p): Likewise.
3645         (info_verbose): Likewise.
3646         * top.h (confirm): Likewise.
3647         (history_expansion_p): Likewise.
3648         * tracepoint.c (disconnected_tracing): Likewise.
3649         (circular_trace_buffer): Likewise.
3650         * typeprint.c (print_methods): Likewise.
3651         (print_typedefs): Likewise.
3652         * utils.c (debug_timestamp): Likewise.
3653         (sevenbit_strings): Likewise.
3654         (pagination_enabled): Likewise.
3655         * utils.h (sevenbit_strings): Likewise.
3656         (pagination_enabled): Likewise.
3657         * valops.c (overload_resolution): Likewise.
3658         * valprint.h (struct value_print_options) <prettyformat_arrays,
3659         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3660         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3661         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3662         Likewise.
3663         * windows-nat.c (new_console): Likewise.
3664         (cygwin_exceptions): Likewise.
3665         (new_group): Likewise.
3666         (debug_exec): Likewise.
3667         (debug_events): Likewise.
3668         (debug_memory): Likewise.
3669         (debug_exceptions): Likewise.
3670         (useshell): Likewise.
3671         * windows-tdep.c (maint_display_all_tib): Likewise.
3672         * xml-support.c (debug_xml): Likewise.
3673
3674 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3675
3676         * source.c (prepare_path_for_appending): New function.
3677         (openp): Make use of new function.
3678         (find_and_open_source): Search for the compilation directory and
3679         source file as a relative path beneath the directory search path.
3680
3681 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * source-cache.c (source_cache::get_line_charpos): Catch
3684         exceptions and return false, this matches the behaviour documented
3685         in the header file.
3686
3687 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3688
3689         * ada-tasks.c (info_task): Remove quoting of the task's name.
3690
3691 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3692
3693         * symfile.c (auto_solib_add): Replace comment with a reference
3694         to the header file.
3695
3696 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3697
3698         * NEWS: Mention that gdb can now be compiled with Python 3
3699         on Windows.
3700
3701 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * maint.c (maint_print_section_data::maint_print_section_data):
3704         Force use of 'float log10 (float)' by casting the argument to
3705         float.
3706
3707 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3708
3709         * maint.c: Add 'cmath' include.
3710         (struct maint_print_section_data): New structure.
3711         (print_section_index): New function.
3712         (print_bfd_section_info): Add header comment, small whitespace
3713         cleanup, and update to call new print_section_index function.
3714         (print_objfile_section_info): Likewise.
3715         (maint_obj_section_from_bfd_section): New function.
3716         (print_bfd_section_info_maybe_relocated): New function.
3717         (maintenance_info_sections): Add header comment, always use
3718         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3719
3720 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3723         inner scope, add check that the objfile has psymtabs before
3724         checking psymtabs_addrmap.
3725         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3726
3727 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3728
3729         * NEWS: Announce that Ada task names are now shown at more places,
3730         and between quotes (except in info task output).
3731         * gdb/ada-tasks.c (task_to_str): New function.
3732         (display_current_task_id): Call task_to_str.
3733         (task_command_1): Likewise.
3734         (print_ada_task_info): In non-mi mode, Properly align headers and data
3735         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3736
3737 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3738
3739         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3740         prstatus.pr_lwp.pr_info instead of making it up.
3741
3742 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3743
3744         * auto-load.c (auto_load_expand_dir_vars): Update.
3745         * defs.h (gdb_datadir): Change to std::string.
3746         (python_libdir): Likewise.
3747         (relocate_gdb_directory): Change return type to std::string.
3748         * guile/guile.c (gdbscm_data_directory): Update.
3749         (initialize_scheme_side): Update.
3750         * jit.c (jit_reader_dir): Change to std::string.
3751         (jit_reader_load_command): Update.
3752         * main.c (gdb_datadir): Change to std::string.
3753         (python_libdir): Likewise.
3754         (set_gdb_data_directory): Update.
3755         (relocate_path): Change to return std::string.
3756         (relocate_gdb_directory): Change to return std::string.
3757         (relocate_gdbinit_path_maybe_in_datadir): Update.
3758         (captured_main_1): Update.
3759         * python/python.c (do_start_initialization): Update.
3760         * top.c (show_gdb_datadir): Update.
3761         * xml-syscall.c (xml_init_syscalls_info): Update.
3762         (init_syscalls_info): Update.
3763
3764 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3765
3766         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3767         out of get_init_files.
3768         (get_init_files): Update.
3769
3770 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3771
3772         * main.c (get_init_files): Change to use std::string.
3773         (captured_main_1): Update.
3774         (print_gdb_help): Update.
3775
3776 2019-09-11  Ali Tamur  <tamur@google.com>
3777
3778         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3779         implementation.
3780
3781 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3782
3783         * dbxread.c (read_dbx_symtab): Update.
3784         * dwarf2read.c (load_partial_dies): Update.
3785         * mdebugread.c (parse_partial_symbols): Update.
3786         (handle_psymbol_enumerators): Update.
3787         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3788         * psymtab.c (add_psymbol_to_bcache): Likewise.
3789         (add_psymbol_to_list): Likewise.
3790         * symtab.c (symbol_set_names): Likewise.
3791         * symtab.h (symbol_set_names): Likewise.
3792         * xcoffread.c (scan_xcoff_symtab): Update.
3793
3794 2019-09-11  Tom Tromey  <tom@tromey.com>
3795
3796         * symfile-mem.c (symbol_file_add_from_memory): Use
3797         bfd_set_filename.
3798         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3799         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3800
3801 2019-09-10  Tom Tromey  <tromey@adacore.com>
3802
3803         * dwarf-index-write.c (write_psymbols): Extend error message.
3804         (debug_names::insert): Add Ada code.
3805         (debug_names::write_psymbols): Remove Ada check.
3806         (debug_names) <m_string_obstack>: New member.
3807         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3808         (gdb_index_symbol_name_matcher::matches): Remove.
3809         (mapped_index_base::find_name_components_bounds): Add "lang"
3810         parameter.
3811         (mapped_index_base::build_name_components): Also split names
3812         according to Ada syntax.
3813         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3814         type of "match_callback".
3815         (check_match, check_find_bounds_finds)
3816         (dw2_expand_symtabs_matching): Update.
3817         (dw2_debug_names_iterator): Add new constructor.
3818         (dw2_debug_names_map_matching_symbols): New function.
3819         (dw2_debug_names_expand_symtabs_matching): Update.
3820         (dwarf2_debug_names_functions): Use
3821         dw2_debug_names_map_matching_symbols.
3822
3823 2019-09-10  Tom Tromey  <tromey@adacore.com>
3824
3825         * dwarf2read.c (dw2_get_file_names_reader): Add the
3826         CU's file name to the results.
3827
3828 2019-09-10  Tom Tromey  <tromey@adacore.com>
3829
3830         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3831         map_matching_symbols.  Update.
3832         * dwarf2read.c (dw2_map_matching_symbols): Update.
3833         * psymtab.c (match_partial_symbol): Change type; update.
3834         (psym_map_matching_symbols): Likewise.
3835         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3836         type; update.
3837         * symfile.h (struct quick_symbol_functions)
3838         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3839         Remove "match".
3840
3841 2019-09-10  Tom Tromey  <tromey@adacore.com>
3842
3843         * psymtab.c (map_block): Remove.
3844         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3845         * symtab.c (iterate_over_symbols_terminated): New function.
3846         * symtab.c (iterate_over_symbols_terminated): Declare.
3847
3848 2019-09-10  Tom Tromey  <tromey@adacore.com>
3849
3850         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3851         * language.h (struct language_defn) <la_iterate_over_symbols>:
3852         Return bool.
3853         * symtab.c (iterate_over_symbols): Return bool.
3854         * symtab.h (iterate_over_symbols): Return bool.
3855
3856 2019-09-10  Tom Tromey  <tromey@adacore.com>
3857
3858         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3859         (add_nonlocal_symbols): Update.
3860         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3861         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3862         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3863         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3864         Change type of "callback".  Remove "data".
3865
3866
3867 2019-09-09  Ali Tamur  <tamur@google.com>
3868
3869         * dwarf2read.c (comp_unit_head): Update comment.
3870         (dwarf2_dwo_name): New function declaration.
3871         (dwarf_unit_type_name): New function declaration.
3872         (read_comp_unit_head): Add support for new compilation units,
3873         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3874         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3875         (currently named as "signature") in their header. Also clarify error
3876         messages.
3877         (lookup_dwo_id): New function. Returns the dwo id of the given
3878         compile unit.
3879         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3880         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3881         functions.
3882         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3883         (dwarf2_dwo_name): Get the dwo name if present.
3884         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3885         purposes.
3886
3887 2019-09-09  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3890
3891 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3892
3893         * python/python.c (do_start_initialization): Make progname_copy static,
3894         to avoid a leak report.
3895
3896 2019-09-08  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3899
3900 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3901
3902         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3903         Change type to gdb::optional<block_enum>.
3904         (dw2_symtab_iter_init): Change block_index parameter type
3905         to gdb::optional<block_enum>.
3906         (dw2_lookup_symbol): Change block_index parameter
3907         type to block_enum.c
3908         (dw2_debug_names_lookup_symbol): Likewise.
3909         * psymtab.c (psym_lookup_symbol): Likewise.
3910         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3911         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3912         Likewise.
3913
3914 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3915
3916         * defs.h (relocate_gdb_directory): Change int to bool in
3917         signature and rename flag to relocatable.
3918         * main.c (relocate_path): Likewise.
3919         (relocate_gdb_directory): Likewise.
3920
3921 2019-09-06  Alan Modra  <amodra@gmail.com>
3922
3923         * coffread.c (coff_symfile_read): Constify filename variable.
3924         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3925         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3926         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3927         * solib.c (reload_shared_libraries_1): Likewise.
3928         * symfile.c (reread_symbols): Likewise.
3929         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3930         * solib-darwin.c (darwin_bfd_open): Likewise.
3931         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3932
3933 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3936         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3937
3938 2019-09-03  Tom Tromey  <tromey@adacore.com>
3939
3940         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3941         types.
3942         (has_negatives): Unbias a range type bound.
3943         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3944         * gdbtypes.c (operator==): Handle new field.
3945         (create_range_type): Add "bias" parameter.
3946         (create_static_range_type, resolve_dynamic_range): Update.
3947         * gdbtypes.h (struct range_bounds) <bias>: New member.
3948         (create_range_type): Add bias parameter.
3949         * printcmd.c (print_scalar_formatted): Unbias range types.
3950         * value.c (unpack_long): Unbias range types.
3951         (pack_long): Bias range types.
3952
3953 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3954
3955         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3956         probe arguments.
3957
3958 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3959
3960         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3961         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3962         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3963         (compile_probe_arg): Likewise.
3964         * probe.h (get_argument_count): Likewise.
3965         * solib-svr4.c (solib_event_probe_action): Likewise.
3966         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3967
3968 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3969
3970         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3971         code to here...
3972         (svr4_create_solib_event_breakpoints): ...from here.
3973
3974 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3975
3976         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3977         suffix from warning message.
3978
3979 2019-08-30  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-winsource.h (struct tui_source_window_base)
3982         <refresh_all>: Don't declare.
3983         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3984         Remove.
3985         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3986         tui_show_locator_content.
3987         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3988         declare.
3989         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3990         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3991         declare.
3992
3993 2019-08-30  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3996
3997 2019-08-30  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4000         Remove unnecessary forward declarations.
4001
4002 2019-08-30  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4005         rerender.
4006         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4007         tui_show_locator_content.
4008
4009 2019-08-30  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4012         (tui_locator_window::rerender): Rewrite using body of previous
4013         tui_show_locator_content.
4014
4015 2019-08-30  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4018         set_locator_fullname>: New methods.
4019         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4020         Rename from tui_set_locator_fullname.
4021         (tui_locator_window::set_locator_info): Rename from
4022         tui_set_locator_info.  Return bool.
4023         (tui_update_locator_fullname, tui_show_frame_info): Update.
4024
4025 2019-08-30  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4028
4029 2019-08-30  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4032         call touchwin.
4033
4034 2019-08-30  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-wingeneral.c (box_win): Assume win_info and
4037         win_info->handle cannot be NULL.
4038
4039 2019-08-30  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4042         refresh_window>: Declare.
4043         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4044         resize.
4045         (tui_data_item_window::rerender): Rename from
4046         tui_display_register.
4047         (tui_data_item_window::refresh_window): New method.
4048         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4049         no-op.
4050
4051 2019-08-30  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4054         regs_column_count, current_group>: Move later.  Now private.
4055         <get_current_group>: New method.
4056         * tui/tui-regs.c (tui_reg_command): Update.
4057         * tui/tui-layout.c (tui_set_layout): Update.
4058
4059 2019-08-30  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4062         (tui_data_window::rerender): Don't call
4063         check_and_display_highlight_if_needed.
4064         (tui_data_window::refresh_all): Remove call to
4065         erase_data_content.
4066
4067 2019-08-30  Tom Tromey  <tom@tromey.com>
4068
4069         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4070         (tui_data_window::display_registers_from)
4071         (tui_data_window::display_reg_element_at_line)
4072         (tui_data_window::display_registers_from_line): Remove checks of
4073         "empty".
4074
4075 2019-08-30  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4078         Don't declare.
4079         * tui/tui-regs.c (tui_data_window::show_registers): Call
4080         rerender.
4081         (tui_data_window::rerender): Rename from display_all_data.
4082         (tui_data_window::rerender): Remove old implementation.
4083
4084 2019-08-30  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4087         text.
4088         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4089
4090 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4091             Sergio Durigan Junior  <sergiodj@redhat.com>
4092
4093         PR win32/24284
4094         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4095
4096 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4099         when searching for types.
4100
4101 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * f-lang.c (f_language_defn): Use f_print_typedef.
4104         * f-lang.h (f_print_typedef): Declare.
4105         * f-typeprint.c (f_print_typedef): Define.
4106
4107 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4108
4109         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4110
4111 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * cli/cli-utils.c (info_print_options_defs): Delete.
4114         (make_info_print_options_def_group): Delete.
4115         (extract_info_print_options): Delete.
4116         (info_print_command_completer): Delete.
4117         (info_print_args_help): Add extra parameter, and optionally
4118         include text about -n flag.
4119         * cli/cli-utils.h (struct info_print_options): Delete.
4120         (extract_info_print_options): Delete declaration.
4121         (info_print_command_completer): Delete declaration.
4122         (info_print_args_help): Add extra parameter, extend header
4123         comment.
4124         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4125         search_symbols.
4126         * stack.c (struct info_print_options): New type.
4127         (info_print_options_defs): New file scoped variable.
4128         (make_info_print_options_def_group): New static function.
4129         (info_print_command_completer): New static function.
4130         (info_locals_command): Update to use new local functions.
4131         (info_args_command): Likewise.
4132         (_initialize_stack): Add extra parameter to calls to
4133         info_print_args_help.
4134         * symtab.c (search_symbols): Add extra parameter, use this to
4135         possibly excluse non-debug symbols.
4136         (symtab_symbol_info): Add extra parameter, which is passed on to
4137         search_symbols.
4138         (struct info_print_options): New type.
4139         (info_print_options_defs): New file scoped variable.
4140         (make_info_print_options_def_group): New static function.
4141         (info_print_command_completer): New static function.
4142         (info_variables_command): Update to use local functions, and pass
4143         extra parameter through to symtab_symbol_info.
4144         (info_functions_command): Likewise.
4145         (info_types_command): Pass additional argument through to
4146         symtab_symbol_info.
4147         (rbreak_command): Pass extra argument to search_symbols.
4148         (_initialize_symtab): Add extra arguments for calls to
4149         info_print_args_help, and update help text for 'info variables',
4150         'whereis', and 'info functions' commands.
4151         * symtab.h (search_symbols): Add extra argument to declaration.
4152         * NEWS: Mention new flags.
4153
4154 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4155
4156         * symtab.c (lookup_static_symbol): Call the new function (and move
4157         it down to be next to lookup_global_symbol).
4158         (struct global_sym_lookup_data): Add block_enum member and rename to...
4159         (struct global_or_static_sym_lookup_data): ...this.
4160         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4161         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4162         (lookup_symbol_global_or_static_iterator_cb): ...this.
4163         (lookup_global_or_static_symbol): New function.
4164         (lookup_global_symbol): Call new function.
4165
4166 2019-08-26  Tom de Vries  <tdevries@suse.de>
4167
4168         PR c++/24852
4169         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4170         when pc_probe.prob == NULL.
4171
4172 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4173
4174         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4175         variable symbol_linkage to symbol_linkage_.
4176
4177 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4178
4179         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4180         represent whether the symbol is static, dynamic, or we don't
4181         know.
4182
4183 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4184
4185         * gdb/rx-tdep.c (rx_register_names): New.
4186         (rx_register_name): Delete.
4187         (rx_psw_type): Delete.
4188         (rx_fpsw_type): Delete.
4189         (rx_register_type): Delete.
4190         (rx_gdbarch_init): Convert target-descriptions.
4191         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4192         * gdb/features/Makefile: Add rx.xml.
4193         * gdb/features/rx.xml: New.
4194         * gdb/features/rx.c: Generated.
4195         * gdb/NEWS: Mention target description support.
4196
4197 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4198
4199         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4200         *slot_ptr.
4201
4202 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4203
4204         * configure.ac: Don't check for 'dlfcn.h' (moved to
4205         gdbsupport/common.m4).
4206         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4207         'gdbsupport/'.
4208         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4209         * compile/compile-c-support.c: Include
4210         'gdbsupport/gdb-dlfcn.h'.
4211         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4212         * gdb-dlfcn.c: Move to...
4213         * gdbsupport/gdb-dlfcn.c: ... here.
4214         * gdb-dlfcn.h: Move to...
4215         * gdbsupport/gdb-dlfcn.h: ... here.
4216
4217 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4218
4219         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4220         the offset field signed.
4221
4222 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4223
4224         * python/lib/gdb/__init__.py (_execute_file): New function.
4225         * python/python.c (python_run_simple_file): Call gdb._execute_file
4226         on Windows.
4227
4228 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4231         all uses as this was never set to anything but a zero value.
4232
4233 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4234
4235         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4236
4237 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4238
4239         * tui/tui-data.h (tui_gen_win_info): Add an =default
4240         move constructor, required by some GCC versions.
4241
4242 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4243
4244         * go32-nat.c (go32_sysinfo): Add hygon_p.
4245
4246 2019-08-20  Tom Tromey  <tom@tromey.com>
4247
4248         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4249         line_from_reg_element_no, first_reg_element_no_inline,
4250         display_all_data, delete_data_content_windows,
4251         erase_data_content>: Now private.
4252
4253 2019-08-20  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4256         (tui_unhighlight_win, tui_highlight_win)
4257         (tui_win_info::make_window): Update.
4258         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4259
4260 2019-08-20  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4263         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4264         (MAX_PID_WIDTH): Move to tui-stack.c.
4265         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4266         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4267         (MAX_PID_WIDTH): Move from tui-data.h.
4268
4269 2019-08-20  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4272         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4273         (box_win): Update.
4274         (tui_gen_win_info::make_window): Rename from tui_make_window.
4275         (tui_win_info::make_window): New method.
4276         (tui_gen_win_info::make_visible): Update.
4277         * tui/tui-source.c (tui_source_window::set_contents): Update.
4278         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4279         (tui_data_window::display_registers_from): Update.
4280         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4281         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4282         Declare.
4283         <can_box>: Remove.
4284         <title>: Remove.
4285         (struct tui_win_info) <make_window>: Declare.
4286         <can_box>: Now virtual.
4287         <title>: New member.
4288         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4289         * tui/tui-command.c (tui_cmd_window::resize): Update.
4290
4291 2019-08-20  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4294         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4295         (tui_data_window::check_register_values): Update.
4296
4297 2019-08-20  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-regs.h (struct tui_data_window): Use
4300         DISABLE_COPY_AND_ASSIGN.
4301         <regs_content>: Change type, removing unique_ptr.
4302         <tui_data_window>: Add move constructor.
4303         * tui/tui-regs.c (tui_data_window::show_registers)
4304         (tui_data_window::show_register_group)
4305         (tui_data_window::display_registers_from)
4306         (tui_data_window::display_registers_from)
4307         (tui_data_window::first_data_item_displayed)
4308         (tui_data_window::delete_data_content_windows)
4309         (tui_data_window::rerender, tui_data_window::refresh_window)
4310         (tui_data_window::check_register_values): Update.
4311
4312 2019-08-20  Tom Tromey  <tom@tromey.com>
4313
4314         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4315         show_register_group>: Declare.
4316         (tui_show_register_group): Don't declare.
4317         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4318         tui_show_registers.
4319         (tui_data_window::show_register_group): Rename from
4320         tui_show_register_group.
4321         (tui_data_window::check_register_values, tui_reg_command):
4322         Update.
4323         * tui/tui-layout.c (tui_set_layout): Update.
4324
4325 2019-08-20  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4328         Declare.
4329         (tui_check_register_values): Don't declare.
4330         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4331         from tui_check_register_values.
4332         * tui/tui-hooks.c (tui_register_changed): Update.
4333
4334 2019-08-20  Tom Tromey  <tom@tromey.com>
4335
4336         * tui/tui-regs.c (tui_reg_layout): Move later.
4337         (tui_show_registers): Don't enable TUI mode or change layout.
4338
4339 2019-08-20  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-regs.h (struct tui_data_item_window)
4342         <~tui_data_item_window>: Remove.
4343         <content>: Now a unique_xmalloc_ptr.
4344         * tui/tui-regs.c (tui_register_format): Return a
4345         unique_xmalloc_ptr.
4346         (tui_get_register): Update.
4347         (~tui_data_item_window): Remove.
4348         (tui_data_window::display_registers_from, tui_display_register):
4349         Update.
4350         * tui/tui-io.h (tui_expand_tabs): Update.
4351         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4352         Remove "col" parameter.
4353
4354 2019-08-20  Tom Tromey  <tom@tromey.com>
4355
4356         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4357         field.
4358         * tui/tui-regs.c (~tui_data_item_window): Update.
4359
4360 2019-08-20  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4363         earlier.
4364
4365 2019-08-20  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4368
4369 2019-08-20  Tom Tromey  <tom@tromey.com>
4370
4371         * tui/tui-source.h (struct tui_source_window): Update.
4372         * tui/tui-regs.c (tui_show_registers): Update.
4373         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4374         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4375         (NO_REGS_STRING): Remove defines.
4376
4377 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4378
4379         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4380         unnecessary thread walk if remote doesn't support the packet.
4381
4382 2019-08-19  Tom Tromey  <tromey@adacore.com>
4383
4384         * python/py-value.c (value_has_field): Fix indentation.
4385
4386 2019-08-19  Tom Tromey  <tromey@adacore.com>
4387
4388         * printcmd.c (do_one_display, info_display_command): Update.
4389         * block.h (contained_in): Return bool.  Add allow_nested
4390         parameter.
4391         * block.c (contained_in): Return bool.  Add allow_nested
4392         parameter.
4393
4394 2019-08-19  Tom Tromey  <tom@tromey.com>
4395
4396         * configure: Rebuild.
4397         * configure.ac: Disallow the combination of -static-libstdc++ and
4398         source highlight.
4399         * source-cache.c (get_language_name): Handle rust.
4400         (source_cache::get_source_lines): Ignore highlighting exceptions.
4401
4402 2019-08-16  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4405         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4406         (struct tui_source_window_base) <make_visible, refresh_window,
4407         resize>: Remove methods.
4408         <execution_info>: Remove field.
4409         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4410         (tui_show_source_line, tui_source_window_base)
4411         (~tui_source_window_base): Update.
4412         (tui_source_window_base::resize)
4413         (tui_source_window_base::make_visible)
4414         (tui_source_window_base::refresh_window): Remove.
4415         (tui_source_window_base::update_exec_info): Update.
4416         * tui/tui-source.c (tui_source_window::set_contents): Update.
4417         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4418
4419 2019-08-16  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4422         deprecated_query_hook.
4423
4424 2019-08-16  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4427         (tui_update_source_windows_with_line): Update.
4428         * tui/tui-source.h (struct tui_source_window)
4429         <show_symtab_source>: Declare.
4430         (tui_show_symtab_source): Don't declare.
4431         * tui/tui-source.c (tui_show_symtab_source): Rename from
4432         tui_show_symtab_source.
4433
4434 2019-08-16  Tom Tromey  <tom@tromey.com>
4435
4436         * tui/tui-winsource.h (struct tui_source_window_base)
4437         <set_contents>: Declare.
4438         * tui/tui-winsource.c
4439         (tui_source_window_base::update_source_window_as_is): Update.
4440         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4441         Declare.
4442         (tui_set_source_content): Don't declare.
4443         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4444         tui_set_source_content.
4445         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4446         Declare.
4447         (tui_set_disassem_content): Don't declare.
4448         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4449         tui_set_disassem_content.
4450
4451 2019-08-16  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-winsource.h (struct tui_source_window_base)
4454         <update_breakpoint_info>: Declare.
4455         (tui_update_breakpoint_info): Don't declare.
4456         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4457         (tui_update_all_breakpoint_info): Update.
4458         (tui_source_window_base::update_breakpoint_info): Rename from
4459         tui_update_breakpoint_info.
4460         (tui_source_window_base::update_exec_info): Update.
4461
4462 2019-08-16  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-winsource.h (struct tui_source_window_base)
4465         <update_source_window>: Declare.
4466         (tui_update_source_window): Don't declare.
4467         * tui/tui-winsource.c
4468         (tui_source_window_base::update_source_window): Rename from
4469         tui_update_source_window.
4470         (tui_source_window_base::rerender): Update.
4471         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4472         * tui/tui-disasm.c (tui_show_disassem)
4473         (tui_show_disassem_and_update_source)
4474         (tui_disasm_window::maybe_update): Update.
4475
4476 2019-08-16  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-winsource.h (struct tui_source_window_base)
4479         <update_source_window_as_is>: Declare.
4480         (tui_update_source_window_as_is): Don't declare.
4481         * tui/tui-winsource.c (tui_update_source_window): Update
4482         (tui_source_window_base::update_source_window_as_is): Rename from
4483         tui_update_source_window_as_is.
4484         (tui_source_window_base::refill): Update.
4485         * tui/tui-source.c (tui_show_symtab_source): Update.
4486         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4487         Update.
4488
4489 2019-08-16  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-winsource.h (tui_update_source_window)
4492         (tui_update_source_window_as_is): Remove "noerror" parameter.
4493         * tui/tui-winsource.c (tui_update_source_window)
4494         (tui_update_source_window_as_is): Remove "noerror" parameter.
4495         (tui_update_source_windows_with_addr)
4496         (tui_update_source_windows_with_line)
4497         (tui_source_window_base::rerender)
4498         (tui_source_window_base::refill): Update.
4499         * tui/tui-source.h (tui_set_source_content)
4500         (tui_show_symtab_source): Remove "noerror" parameter.
4501         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4502         parameter.
4503         (tui_show_symtab_source): Likewise.
4504         (tui_source_window::maybe_update): Update.
4505         * tui/tui-disasm.c (tui_show_disassem)
4506         (tui_show_disassem_and_update_source)
4507         (tui_disasm_window::do_scroll_vertical)
4508         (tui_disasm_window::maybe_update): Update.
4509
4510 2019-08-16  Tom Tromey  <tom@tromey.com>
4511
4512         * tui/tui.c (tui_is_window_visible): Update.
4513         * tui/tui-wingeneral.c (tui_make_window)
4514         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4515         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4516         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4517         (tui_set_win_height_command, parse_scrolling_args): Update.
4518         * tui/tui-source.c (tui_source_window::style_changed): Update.
4519         * tui/tui-regs.c (tui_show_registers)
4520         (tui_data_window::first_data_item_displayed)
4521         (tui_data_window::delete_data_content_windows)
4522         (tui_check_register_values, tui_reg_command): Update.
4523         * tui/tui-disasm.c (tui_show_disassem): Update.
4524         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4525         method.
4526         <is_visible>: Remove field.
4527         * tui/tui-data.c (tui_next_win, tui_prev_win)
4528         (tui_delete_invisible_windows): Update.
4529
4530 2019-08-16  Tom Tromey  <tom@tromey.com>
4531
4532         * tui/tui-winsource.h (struct tui_source_window_base)
4533         <m_has_locator>: Remove.
4534         * tui/tui-layout.c (show_source_disasm_command, show_data)
4535         (show_source_or_disasm_and_command): Update.
4536
4537 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4538
4539         * NEWS (Other MI changes): New subsection.
4540         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4541         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4542         * arch-utils.c (default_get_pc_address_flags): New function.
4543         * arch-utils.h (default_get_pc_address_flags): New declaration.
4544         * gdbarch.sh: Add get_pc_address_flags.
4545         * gdbarch.c: Regenerate.
4546         * gdbarch.h: Likewise.
4547         * stack.c (print_pc): New function.
4548         (print_frame_info) (print_frame): Call print_pc.
4549
4550 2019-08-16  Tom de Vries  <tdevries@suse.de>
4551
4552         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4553         print_objfile_section_info.
4554
4555 2019-08-15  Tom Tromey  <tom@tromey.com>
4556
4557         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4558         calling update_cmdwin_start_line.
4559         * tui/tui-winsource.h (struct tui_source_window_base)
4560         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4561         <rerender>: Declare.
4562         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4563         Call rerender.
4564         (tui_source_window_base::set_new_height): Remove.
4565         (tui_source_window_base::rerender): Rename from
4566         do_make_visible_with_new_height.
4567         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4568         resize method.
4569         (tui_win_info::make_invisible_and_set_new_height)
4570         (tui_win_info::make_visible_with_new_height): Remove.
4571         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4572         Declare.
4573         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4574         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4575         do_make_visible_with_new_height>: Don't declare.
4576         <rerender>: Declare.
4577         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4578         set_new_height.
4579         (tui_data_window::do_make_visible_with_new_height): Remove.
4580         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4581         call tui_show_locator_content.
4582         (tui_gen_win_info::resize): Call rerender.
4583         (show_source_or_disasm_and_command): Don't call
4584         tui_show_locator_content.
4585         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4586         method.
4587         (struct tui_win_info) <rerender>: Declare.
4588         <set_new_height, make_invisible_and_set_new_height,
4589         make_visible_with_new_height>: Don't declare.
4590         * tui/tui-data.c (tui_win_list::rerender): New method.
4591         * tui/tui-command.h (struct tui_cmd_window)
4592         <do_make_visible_with_new_height>: Don't declare.
4593         * tui/tui-command.c
4594         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4595
4596 2019-08-15  Tom Tromey  <tromey@adacore.com>
4597
4598         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4599         * ada-lang.c (ada_enum_name): Likewise.
4600
4601 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4602
4603         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4604         leading underscore.
4605         (GdbOutputErrorFile): Likewise.
4606         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4607         accordingly.
4608         (execute_unwinders): Rename to have a leading underscore.
4609         (auto_load_packages): Likewise.
4610         (global scope): Adjust call to auto_load_packages accordingly.
4611         (GdbSetPythonDirectory): Likewise.
4612         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4613         instead of execute_unwinders.
4614
4615 2019-08-15  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4618         (show_data): Don't change window visibility.
4619         (tui_gen_win_info::resize): Remove special case for command
4620         window.  Use wresize, when available.
4621         (show_source_or_disasm_and_command): Don't change window
4622         visibility.
4623         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4624         <make_visible>: New method.
4625         * tui/tui-command.c (tui_cmd_window::resize): New method.
4626
4627 2019-08-15  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4630         (struct tui_source_windows): New.
4631         * tui/tui-winsource.c (tui_display_main): Update.
4632         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4633         (new_height_ok, parse_scrolling_args): Update.
4634         * tui/tui-layout.c (show_layout, show_data): Update.
4635         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4636         (tui_add_to_source_windows): Don't declare.
4637         * tui/tui-data.c (source_windows, tui_source_windows)
4638         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4639
4640 2019-08-15  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4643         Rename from reset.
4644         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4645         * tui/tui-layout.c (show_source_disasm_command, show_data):
4646         Update.
4647         (tui_gen_win_info::resize): Rename.
4648         (show_source_or_disasm_and_command): Update.
4649         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4650         reset.
4651
4652 2019-08-15  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4655         * tui/tui-interp.c (tui_interp::init): Don't call
4656         tui_initialize_static_data.
4657         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4658
4659 2019-08-15  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4662         examine tui_win_list.
4663
4664 2019-08-15  Tom Tromey  <tom@tromey.com>
4665
4666         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4667         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4668         tui_clear_source_content.
4669         (tui_clear_source_content): Remove.
4670         (tui_source_window_base::do_erase_source_content): Hoist call to
4671         content.clear().
4672         * tui/tui-stack.c (tui_show_frame_info): Don't call
4673         tui_clear_source_content.
4674
4675 2019-08-15  Tom Tromey  <tom@tromey.com>
4676
4677         * tui/tui-winsource.h (struct tui_source_window_base)
4678         <do_erase_source_content>: New method.
4679         <erase_source_content>: New method.
4680         (tui_erase_source_content): Don't declare.
4681         * tui/tui-winsource.c (tui_clear_source_content): Update.
4682         (tui_source_window_base::do_erase_source_content): Rename from
4683         tui_erase_source_content.
4684         (tui_source_window_base::show_source_content): Update.
4685         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4686         * tui/tui-source.h (struct tui_source_window)
4687         <erase_source_content>: New method.
4688         * tui/tui-disasm.h (struct tui_disasm_window)
4689         <erase_source_content>: New method.
4690
4691 2019-08-15  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4694         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4695         constructor.
4696         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4697         * tui/tui-source.c (tui_set_source_content): Update.
4698         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4699
4700 2019-08-15  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4703         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4704         tui-source.c.
4705         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4706         Declare.
4707         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4708         method.
4709         (tui_source_window::maybe_update): Update.
4710
4711 2019-08-15  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4714         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4715         tui-disasm.c.
4716         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4717         Declare.
4718         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4719         method.
4720         (tui_disasm_window::maybe_update): Update.
4721
4722 2019-08-15  Tom Tromey  <tom@tromey.com>
4723
4724         * tui/tui-winsource.h (struct tui_source_window_base)
4725         <maybe_update>: Declare.
4726         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4727         method.
4728         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4729         Declare.
4730         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4731         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4732         Declare.
4733         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4734
4735 2019-08-15  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4738
4739 2019-08-15  Tom Tromey  <tom@tromey.com>
4740
4741         * tui/tui-wingeneral.c: Include tui-stack.h.
4742         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4743         (struct tui_locator_window): Move from tui-data.h.
4744         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4745         (tui_initialize_static_data): Move from tui-data.c.
4746         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4747         (struct tui_locator_window): Move to tui-stack.c.
4748         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4749         (tui_initialize_static_data): Move to tui-stack.c.
4750
4751 2019-08-15  Tom Tromey  <tom@tromey.com>
4752
4753         * tui/tui-layout.c (show_source_disasm_command)
4754         (show_source_or_disasm_and_command): Use make_visible method, not
4755         tui_make_window.
4756         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4757         Remove.
4758
4759 2019-08-15  Tom Tromey  <tom@tromey.com>
4760
4761         * tui/tui-wingeneral.h (tui_make_window): Update.
4762         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4763         parameter.
4764         (tui_gen_win_info::make_visible): Update.
4765         * tui/tui-regs.c (tui_data_window::display_registers_from):
4766         Update.
4767         * tui/tui-layout.c (show_source_disasm_command)
4768         (show_source_or_disasm_and_command): Update.
4769         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4770         (enum tui_box): Remove.
4771         (struct tui_win_info) <can_box>: New method.
4772         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4773         method.
4774
4775 2019-08-15  Tom de Vries  <tdevries@suse.de>
4776
4777         * linux-nat-trad.c: Include gdbarch.h.
4778
4779 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4780
4781         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4782         register sizes.
4783
4784 2019-08-14  Tom Tromey  <tromey@adacore.com>
4785
4786         * darwin-nat.c: Include gdbarch.h.
4787         * darwin-nat-info.c: Include gdbarch.h.
4788
4789 2019-08-13  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4792         Remove.
4793         * tui/tui-data.c (tui_initialize_static_data): Update.
4794
4795 2019-08-13  Tom Tromey  <tom@tromey.com>
4796
4797         * tui/tui-winsource.h (struct tui_exec_info_window)
4798         <~tui_exec_info_window, maybe_allocate_content, get_content,
4799         m_content>: Remove.
4800         (struct tui_source_window_base) <set_exec_info_content,
4801         show_exec_info_content>: Don't declare.
4802         * tui/tui-winsource.c
4803         (tui_exec_info_window::maybe_allocate_content): Remove.
4804         (tui_source_window_base::update_exec_info): Rename from
4805         set_exec_info_content.
4806         (tui_source_window_base::show_exec_info_content)
4807         (tui_source_window_base::update_exec_info): Remove.
4808
4809 2019-08-13  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4812         declare.
4813         * tui/tui-winsource.c (tui_update_source_window_as_is)
4814         (tui_update_source_windows_with_addr, tui_erase_source_content):
4815         Update.
4816         (tui_clear_exec_info_content): Remove.
4817
4818 2019-08-13  Tom Tromey  <tom@tromey.com>
4819
4820         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4821         declare.
4822         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4823         call tui_erase_exec_info_content.
4824         (tui_clear_exec_info_content): Rename from
4825         tui_erase_exec_info_content.
4826         (tui_clear_exec_info_content): Delete.
4827
4828 2019-08-13  Tom Tromey  <tom@tromey.com>
4829
4830         * tui/tui-winsource.h (struct tui_source_window_base)
4831         <show_exec_info_content>: Declare.
4832         (tui_show_exec_info_content): Don't declare.
4833         * tui/tui-winsource.c
4834         (tui_source_window_base::show_exec_info_content): Rename from
4835         tui_show_exec_info_content.
4836         (tui_source_window_base::update_exec_info): Update.
4837
4838 2019-08-13  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4841         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4842         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4843         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4844         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4845         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4846         ... here.
4847
4848 2019-08-13  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui-winsource.h (struct tui_source_window_base)
4851         <update_exec_info>: Declare.
4852         (tui_update_exec_info): Don't declare.
4853         * tui/tui-winsource.c (tui_update_source_window_as_is)
4854         (tui_source_window_base::refresh_all)
4855         (tui_update_all_breakpoint_info): Update.
4856         (tui_source_window_base::update_exec_info): Rename from
4857         tui_update_exec_info.
4858         * tui/tui-stack.c (tui_show_frame_info): Update.
4859
4860 2019-08-13  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-winsource.h (struct tui_source_window_base)
4863         <set_exec_info_content>: Declare.
4864         (tui_set_exec_info_content): Don't declare.
4865         * tui/tui-winsource.c
4866         (tui_source_window_base::set_exec_info_content): Rename from
4867         tui_set_exec_info_content.
4868         (tui_update_exec_info): Update.
4869
4870 2019-08-13  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-winsource.h (struct tui_source_window_base)
4873         <show_source_content>: Declare.
4874         (tui_show_source_content): Don't declare.
4875         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4876         (tui_source_window_base::show_source_content): Rename from
4877         tui_show_source_content.
4878         (tui_source_window_base::refresh_all): Update.
4879         * tui/tui-layout.c (show_source_disasm_command)
4880         (show_source_or_disasm_and_command): Update.
4881
4882 2019-08-13  Tom Tromey  <tom@tromey.com>
4883
4884         * tui/tui-winsource.c (tui_erase_source_content)
4885         (tui_show_source_content, tui_source_window_base::refresh_all):
4886         Update.
4887         * tui/tui-wingeneral.h
4888         (tui_check_and_display_highlight_if_needed): Don't declare.
4889         * tui/tui-wingeneral.c
4890         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4891         check_and_display_highlight_if_needed.
4892         * tui/tui-win.c (tui_rehighlight_all)
4893         (tui_win_info::make_visible_with_new_height): Update.
4894         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4895         (tui_data_window::erase_data_content)
4896         (tui_data_window::display_all_data): Update.
4897         * tui/tui-data.h (struct tui_win_info)
4898         <check_and_display_highlight_if_needed>: Declare.
4899
4900 2019-08-13  Tom Tromey  <tom@tromey.com>
4901
4902         * tui/tui-win.c (tui_resize_all): Call
4903         tui_delete_invisible_windows.
4904         * tui/tui-layout.c (show_layout): Call
4905         tui_delete_invisible_windows.
4906         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4907         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4908
4909 2019-08-13  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4912         tui_add_win_to_layout.
4913
4914 2019-08-13  Tom Tromey  <tom@tromey.com>
4915
4916         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4917         * tui/tui-layout.c (tui_default_win_height): Now static.
4918
4919 2019-08-13  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4922         single switch.
4923         (show_source_disasm_command, show_source_or_disasm_and_command):
4924         Don't check current layout.
4925
4926 2019-08-13  Tom Tromey  <tom@tromey.com>
4927
4928         * tui/tui-wingeneral.c (make_all_visible): Remove.
4929         (tui_make_all_invisible): Simplify.
4930         * tui/tui-layout.c (tui_make_all_invisible): Move from
4931         tui-wingeneral.c; simplify.
4932         (show_layout): Hoist call to tui_make_all_invisible.
4933         (show_data): Don't call tui_make_all_invisible.
4934
4935 2019-08-13  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4938         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4939
4940 2019-08-13  Tom Tromey  <tom@tromey.com>
4941
4942         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4943         tui-data.c.
4944         (show_source_disasm_command, show_data)
4945         (show_source_or_disasm_and_command): Don't use
4946         tui_set_current_layout_to.
4947         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4948         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4949         tui-layout.c.
4950         (tui_set_current_layout_to): Remove.
4951
4952 2019-08-13  Tom Tromey  <tom@tromey.com>
4953
4954         * tui/tui-layout.c (tui_set_layout): Update.
4955         * tui/tui-data.h (struct tui_layout_def): Remove.
4956         (tui_layout_def): Don't declare.
4957         * tui/tui-data.c (layout_def): Remove.
4958         (tui_layout_def): Remove.
4959
4960 2019-08-13  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-winsource.h (struct tui_source_window_base)
4963         <clear_detail>: No longer "override".
4964         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4965         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4966         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4967         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4968         Remove.
4969         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4970
4971 2019-08-13  Tom Tromey  <tromey@adacore.com>
4972
4973         * tracepoint.c: Don't include readline.h or history.h.
4974
4975 2019-08-12  Tom Tromey  <tom@tromey.com>
4976
4977         * configure: Rebuild.
4978         * configure.ac: Check for readline 7.
4979         * NEWS: Mention readline 7 requirement.
4980         * README: Update.
4981
4982 2019-08-12  Tom Tromey  <tom@tromey.com>
4983
4984         * mingw-hdep.c (gdb_select): Remove readline hack.
4985
4986 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4987
4988         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4989         when the function fails.
4990
4991 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4992
4993         * s390-tdep.c (s390_type_align): New function.
4994         (s390_gdbarch_init): Set it as type_align gdbarch method.
4995
4996 2019-08-09  Tom de Vries  <tdevries@suse.de>
4997
4998         PR gdb/24591
4999         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5000         pc_low with relocation offset.
5001
5002 2019-08-07  Tom Tromey  <tromey@adacore.com>
5003
5004         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5005         (print_frame_args): Update.
5006         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5007         Update.
5008         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5009         * frame.h (struct frame_arg): Add initializers.
5010         <error>: Now a unique_xmalloc_ptr.
5011
5012 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5013
5014         * NEWS: Expand the Pointer Authentication entry.
5015         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5016         (aarch64_frame_unmask_lr): ... to this.
5017         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5018         Call aarch64_frame_unmask_lr.
5019         * frame.c (struct frame_info): Add "masked" variable.
5020         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5021         (fprint_frame): Check for masked pc.
5022         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5023         declarations.
5024         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5025         * stack.c (print_frame): Check for masked pc.
5026
5027 2019-08-06  Tom Tromey  <tom@tromey.com>
5028
5029         * stabsread.c (patch_block_stabs, read_one_struct_field)
5030         (read_enum_type): Use obstack_strndup.
5031         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5032         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5033         * dwarf2read.c (guess_full_die_structure_name)
5034         (anonymous_struct_prefix): Use obstack_strndup.
5035         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5036         * c-exp.y (yylex): Use obstack_strndup.
5037         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5038         (write_var_or_type): Use obstack_strndup.
5039
5040 2019-08-06  Tom Tromey  <tom@tromey.com>
5041
5042         * symfile.c (reread_symbols): Use obstack_strdup.
5043         * stabsread.c (read_type): Use obstack_strdup.
5044         * gdb_obstack.h (obstack_strdup): New overload.
5045         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5046         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5047         (dwarf2_canonicalize_name): Use obstack_strdup.
5048         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5049         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5050         Use obstack_strdup.
5051
5052 2019-08-06  Tom Tromey  <tom@tromey.com>
5053
5054         * gdb_obstack.h (obstack_strdup): Define.
5055         * gdb_obstack.c (obstack_strdup): Don't define.
5056
5057 2019-08-06  Tom Tromey  <tom@tromey.com>
5058
5059         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5060         obstack_strdup.
5061         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5062         obstack_strdup.
5063         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5064         * stabsread.c (common_block_start): Use obstack_strdup.
5065         * objfiles.c (set_objfile_main_name, objfile): Use
5066         obstack_strdup.
5067         * namespace.c (add_using_directive): Use obstack_strdup.
5068         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5069         * jit.c (finalize_symtab): Use obstack_strdup.
5070         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5071         (guess_partial_die_structure_name, partial_die_info::fixup)
5072         (dwarf2_name): Use obstack_strdup.
5073         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5074         obstack_strdup.
5075         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5076         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5077         obstack_strdup.
5078         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5079
5080 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5081
5082         * unittests/help-doc-selftests.c: New file.
5083         * Makefile.in: Add the new file.
5084
5085 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5086
5087         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5088         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5089         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5090         the trailing '.' is not output, and the first character is uppercased.
5091         (print_help_for_command): Update call to print_doc_line.
5092         (print_doc_of_command): Likewise.
5093         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5094         * cli/cli-option.c (append_indented_doc): Do not append newline.
5095         (build_help_option): Append newline after first appended_indented_doc
5096         only if a second call is done.
5097         (build_help): Append 2 new lines before each option, except the first
5098         one.
5099         * compile/compile.c (_initialize_compile): Add new lines after
5100         %OPTIONS%, when not at the end of the help.
5101         Change help doc or code
5102         producing the help doc to respect the invariants.
5103         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5104         Also removed the new line after 'Options:', as all other commands
5105         do not put an empty line between 'Options:' and the first option.
5106         * printcmd.c (_initialize_printcmd): Likewise.
5107         * stack.c (_initialize_stack): Likewise.
5108         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5109         incorrectly telling COMMAND is optional.
5110         * ada-lang.c (_initialize_ada_language): Change help doc or code
5111         producing the help doc to respect the invariants.
5112         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5113         * breakpoint.c (_initialize_breakpoint): Likewise.
5114         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5115         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5116         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5117         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5118         _initialize_cli_style): Likewise.
5119         * corelow.c (core_target_info): Likewise.
5120         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5121         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5122         * filesystem.c (_initialize_filesystem): Likewise.
5123         * frame.c (_initialize_frame): Likewise.
5124         * gnu-nat.c (add_task_commands): Likewise.
5125         * infcall.c (_initialize_infcall): Likewise.
5126         * infcmd.c (_initialize_infcmd): Likewise.
5127         * interps.c (_initialize_interpreter): Likewise.
5128         * language.c (_initialize_language): Likewise.
5129         * linux-fork.c (_initialize_linux_fork): Likewise.
5130         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5131         * maint.c (_initialize_maint_cmds): Likewise.
5132         * memattr.c (_initialize_mem): Likewise.
5133         * printcmd.c (_initialize_printcmd): Likewise.
5134         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5135         _RegEx): Likewise.
5136         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5137         * record-btrace.c (_initialize_record_btrace): Likewise.
5138         * record-full.c (_initialize_record_full): Likewise.
5139         * record.c (_initialize_record): Likewise.
5140         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5141         * regcache.c (_initialize_regcache): Likewise.
5142         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5143         _initialize_remote): Likewise.
5144         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5145         * serial.c (_initialize_serial): Likewise.
5146         * skip.c (_initialize_step_skip): Likewise.
5147         * source.c (_initialize_source): Likewise.
5148         * stack.c (_initialize_stack): Likewise.
5149         * symfile.c (_initialize_symfile): Likewise.
5150         * symtab.c (_initialize_symtab): Likewise.
5151         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5152         * top.c (init_main): Likewise.
5153         * tracefile-tfile.c (tfile_target_info): Likewise.
5154         * tracepoint.c (_initialize_tracepoint): Likewise.
5155         * tui/tui-win.c (_initialize_tui_win): Likewise.
5156         * utils.c (add_internal_problem_command): Likewise.
5157         * valprint.c (value_print_option_defs): Likewise.
5158
5159 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5160
5161         PR build/24886
5162         * configure.ac: Drop enable-libmcheck support.
5163         * configure, config.in: Rebuild.
5164         * libmcheck.m4: Remove.
5165         * acinclude.m4: Don't include it.
5166         * Makefile.in: Don't distribute it.
5167         * top.c (print_gdb_configuration): Don't mention it.
5168
5169 2019-08-06  Tom Tromey  <tom@tromey.com>
5170
5171         * utils.c (set_output_style): Sometimes pass stream to
5172         emit_style_escape.
5173         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5174         * record-btrace.c (btrace_insn_history): Update.
5175         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5176         method.
5177         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5178         Update initializers.
5179         <m_uiout>: New field.
5180         <m_di>: Move lower.
5181         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5182         Remove "uiout" parameter.
5183         (dump_insns): Update.
5184         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5185         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5186
5187 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5188
5189         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5190         (error_in_psymtab_expansion): Likewise.
5191         (lookup_symbol_via_quick_fns): Likewise.
5192         (basic_lookup_transparent_type_quick): Likewise.
5193         (basic_lookup_transparent_type_1): Likewise.
5194
5195 2019-08-06  Tom Tromey  <tromey@adacore.com>
5196
5197         * source.c (last_source_error): Now bool.
5198         (print_source_lines_base): Make "noprint" bool.  Only open
5199         source file when last_source_visited changes.
5200
5201 2019-08-06  Tom Tromey  <tromey@adacore.com>
5202
5203         * annotate.c (annotate_source_line): Use g_source_cache.
5204         * source-cache.c (source_cache::get_plain_source_lines): Change
5205         parameters.  Populate m_offset_cache.
5206         (source_cache::ensure): New method.
5207         (source_cache::get_line_charpos): New method.
5208         (extract_lines): Move lower.  Change parameters.
5209         (source_cache::get_source_lines): Move lower.
5210         * source-cache.h (class source_cache): Update comment.
5211         <get_line_charpos>: New method.
5212         <get_source_lines>: Update comment.
5213         <clear>: Clear m_offset_cache.
5214         <get_plain_source_lines>: Change parameters.
5215         <ensure>: New method
5216         <m_offset_cache>: New member.
5217         * source.c (forget_cached_source_info_for_objfile): Update.
5218         (info_source_command): Use g_source_cache.
5219         (find_source_lines, open_source_file_with_line_charpos): Remove.
5220         (print_source_lines_base, search_command_helper): Use g_source_cache.
5221         * source.h (open_source_file_with_line_charpos): Don't declare.
5222         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5223         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5224         Use g_source_cache.
5225
5226 2019-08-06  Tom Tromey  <tromey@adacore.com>
5227
5228         * source-cache.c (source_cache::get_plain_source_lines):
5229         Remove "first_line" and "last_line" parameters.
5230         (source_cache::get_source_lines): Cache plain text.
5231         * source-cache.h (class source_cache)
5232         <get_plain_source_lines>: Update.
5233
5234 2019-08-06  Tom Tromey  <tromey@adacore.com>
5235
5236         * source-cache.c (extract_lines): No longer a method.
5237         Changed type of parameter.  Include final newline.
5238         (selftests::extract_lines_test): New function.
5239         (_initialize_source_cache): Likewise.
5240         * source-cache.h (class source_cache)
5241         <extract_lines>: Don't declare.
5242
5243 2019-08-06  Tom Tromey  <tromey@adacore.com>
5244
5245         * breakpoint.c (init_breakpoint_sal): Update.
5246         (breakpoint): Update.
5247         * breakpoint.h (struct breakpoint) <filter>: Now a
5248         unique_xmalloc_ptr.
5249
5250 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5251
5252         * NEWS: Mention dictionary access on blocks.
5253         * python/py-block.c (blpy_getitem): New function.
5254         (block_object_as_mapping): New struct.
5255         (block_object_type): Use new struct for tp_as_mapping field.
5256
5257 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5258
5259         * objfiles.h (objfile): Add a comment describing partial symbols.
5260
5261 2019-08-05  Tom Tromey  <tromey@adacore.com>
5262
5263         * compile/compile.c (_initialize_compile): Use _(), not N_().
5264         * thread.c (_initialize_thread): Use _(), not N_().
5265         * stack.c (_initialize_stack): Use _(), not N_().
5266         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5267
5268 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5269
5270         * dwarf2read.c (struct dw2_symtab_iterator):
5271         <want_specific_block>: Remove.
5272         <block_index>: Change type to gdb::optional.
5273         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5274         change type of BLOCK_INDEX parameter to gdb::optional.
5275         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5276         (dw2_lookup_symbol): Don't pass argument for
5277         WANT_SPECIFIC_BLOCK.
5278         (dw2_expand_symtabs_for_function): Don't pass argument for
5279         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5280         (class dw2_debug_names_iterator)
5281         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5282         parameter, change BLOCK_INDEX type to gdb::optional.
5283         <m_want_specific_block>: Remove.
5284         <m_block_index>: Change type to gdb::optional.
5285         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5286         gdb::optional.  Re-write in function of gdb::optional.
5287         (dw2_debug_names_lookup_symbol): Don't pass argument for
5288         WANT_SPECIFIC_BLOCK.
5289         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5290         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5291         BLOCK_INDEX.
5292
5293 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5294
5295         * NEWS: Mention changes to "info sources" command.
5296
5297 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5298
5299         * symtab.c (filename_partial_match_opts): New struct type.
5300         (struct output_source_filename_data): New members
5301         regexp, c_regexp, partial_match.
5302         (output_source_filename): Use new members to decide to print file.
5303         (info_sources_option_defs): New variable.
5304         (make_info_sources_options_def_group, print_info_sources_header,
5305         info_sources_command_completer):
5306         New functions.
5307         (info_sources_command): Read new optional arguments.
5308         (_initialize_symtab): Update info sources help.
5309
5310 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5311
5312         * ada-lang.c (exception_support_info_v0): Renamed from...
5313         (default_exception_support_info): ... this.  Create new
5314         definition for v1.
5315         (ada_has_this_exception_support): Look up catch_handlers_sym.
5316         (ada_exception_support_info_sniffer): Try v0 after default.
5317
5318 2019-08-01  Tom Tromey  <tromey@adacore.com>
5319
5320         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5321         gdbarch.h.
5322
5323 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5324
5325         * s12z-tdep.c: Fix include path for s12z-opc.h.
5326
5327 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * NEWS: Require GNU make 3.82.
5330
5331 2019-07-16  Tom Tromey  <tom@tromey.com>
5332
5333         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5334         declare.
5335
5336 2019-07-30  Tom Tromey  <tromey@adacore.com>
5337
5338         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5339
5340 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5341
5342         * printcmd.c (print_address_symbolic): Print negative offsets.
5343         (build_address_symbolic): Force signed arithmetic when computing
5344         offset.
5345
5346 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5347
5348         PR/24474: Add a function to lookup static variables.
5349         * NEWS: Mention this new function.
5350         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5351         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5352         * python/python.c (python_GdbMethods): Add new function.
5353
5354 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5355
5356         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5357         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5358         (objfpy_lookup_static_symbol): New function.
5359         (objfile_object_methods): Add new functions.
5360
5361 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5362
5363         * NEWS: Mention 'set|show print frame-info'.  Mention new
5364         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5365         backtrace argument.  Mention that python frame filtering code
5366         is now consistent with what 'backtrace' command prints.
5367
5368 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5369
5370         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5371         comments.
5372         (print_frame_info_auto, print_frame_info_source_line,
5373         print_frame_info_location, print_frame_info_source_and_location,
5374         print_frame_info_location_and_address, print_frame_info_short_location):
5375         New declarations.
5376         (struct frame_print_options): New member print_frame_info.
5377         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5378         * stack.h (get_user_print_what_frame_info): New declaration.
5379         (frame_show_address): New declaration.
5380         * stack.c (print_frame_arguments_choices): New value 'presence'.
5381         (print_frame_info_auto, print_frame_info_source_line,
5382         print_frame_info_location, print_frame_info_source_and_location,
5383         print_frame_info_location_and_address, print_frame_info_short_location,
5384         print_frame_info_choices, print_frame_info_print_what): New definitions.
5385         (print_frame_args): Only print dots for args if print frame-arguments
5386         is 'presence'.
5387         (frame_print_option_defs): New element for "frame-info".
5388         (get_user_print_what_frame_info): New function.
5389         (frame_show_address): Make non static.  Move comment to stack.h.
5390         (print_frame_info_to_print_what): New function.
5391         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5392         to decide what to print.
5393         (backtrace_command_1): Handle the new print_frame_arguments_presence
5394         value.
5395         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5396         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5397         (py_print_frame): In non-mi mode, use LOCATION as default for
5398         print_what, similarly to frame information printed directly by
5399         backtrace command. Handle frame-info user option in non MI mode.
5400
5401 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5402
5403         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5404         Add case for debugging 32-bit target on 64-bit host.  Revise
5405         comment.
5406
5407 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5408
5409         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5410         instead of find_function_entry_range_from_pc.
5411
5412 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5413
5414         * stack.c (find_frame_funname): Remove code which preferred
5415         minsym over symtab sym in "certain pathological cases".
5416
5417         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5418         parameter.  Change type of "do_demangle" to bool.
5419         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5420         Pass suitable "prefer_sym_over_minsym" flag to
5421         build_address_symbolic().  Don't output "+" for negative offsets.
5422         * printcmd.c (print_address_symbolic): Update invocation of
5423         build_address_symbolic to include a "prefer_sym_over_minsym"
5424         flag.
5425         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5426         Restrict cases in which use of minimal symbol is preferred to that
5427         of a found symbol.  Update comments.
5428
5429         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5430         for entry pc when entry pc is out of range for that FDE.
5431
5432 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5433
5434         PR gdb/24839:
5435         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5436         type.
5437
5438 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5439
5440         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5441         this function's Python signature.
5442
5443
5444 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5445
5446         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5447         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5448         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5449         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5450         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5451
5452
5453 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5454
5455         * h8300-tdep.c (h8300_register_name_common): New.
5456         h8300_register_name): Use h8300_register_name_common.
5457         (h8300s_register_name): Likewise.
5458         (h8300sx_register_name): Likewise.
5459         (h8300h_register_nam): New.
5460         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5461
5462
5463 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5464
5465         * arm-tdep.c (arm_skip_cmse_entry): New function.
5466         (arm_is_sgstubs_section): New function.
5467         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5468
5469 2019-07-22  Tom Tromey  <tom@tromey.com>
5470
5471         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5472         Don't self-assign.
5473
5474 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5477         type_print.
5478
5479 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5482         so that GDB doesn't match any msymbols when searching in the
5483         TYPES_DOMAIN.
5484         (print_symbol_info): Print using typedef_print or type_print based
5485         on the type of the symbol.  Add updated FIXME comment moved from...
5486         (_initialize_symtab): ... move and update FIXME comment to above.
5487
5488 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5489
5490         * NEWS: Mention adding -q option to "info types".
5491         * symtab.c (struct info_types_options): New struct.
5492         (info_types_options_defs): New variable.
5493         (make_info_types_options_def_group): New function.
5494         (info_types_command): Use gdb::option framework to parse options.
5495         (info_types_command_completer): New function.
5496         (_initialize_symtab): Extend the help text on "info types" and
5497         register command completer.
5498
5499 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5500
5501         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5502         (lookup_symbol_in_objfile): Change int to block_enum and add a
5503         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5504
5505 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5506
5507         * MAINTAINERS (Write After Approval): Add self.
5508
5509 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5510
5511         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5512         instruction to the dummy code region.
5513
5514 2019-07-19  Tom Tromey  <tromey@adacore.com>
5515
5516         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5517         (ARGSUSED, PARAMS, __func__): Remove rules.
5518
5519 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5520
5521         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5522         * features/arm/arm-with-iwmmxt.c: Remove.
5523         * features/arm/arm-with-iwmmxt.xml: Remove.
5524         * features/arm/arm-with-m-fpa-layout.c: Remove.
5525         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5526         * features/arm/arm-with-m-vfp-d16.c: Remove.
5527         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5528         * features/arm/arm-with-m.c: Remove.
5529         * features/arm/arm-with-m.xml: Remove.
5530         * features/arm/arm-with-neon.c: Remove.
5531         * features/arm/arm-with-neon.xml: Remove.
5532         * features/arm/arm-with-vfpv2.c: Remove.
5533         * features/arm/arm-with-vfpv2.xml: Remove.
5534         * features/arm/arm-with-vfpv3.c: Remove.
5535         * features/arm/arm-with-vfpv3.xml: Remove.
5536
5537 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5538
5539         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5540
5541 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5542
5543         * arch/aarch32.c (aarch32_create_target_description): Create
5544         target descriptions using features.
5545         * arch/arm.c (arm_create_target_description)
5546         (arm_create_mprofile_target_description): Likewise.
5547         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5548
5549 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5550
5551         * Makefile.in: Add new files.
5552         * aarch32-tdep.c: New file.
5553         * aarch32-tdep.h: New file.
5554         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5555         Call aarch32_read_description.
5556         * arch/aarch32.c: New file.
5557         * arch/aarch32.h: New file.
5558         * arch/arm.c (arm_create_target_description)
5559         (arm_create_mprofile_target_description): New function.
5560         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5561         (arm_create_target_description)
5562         (arm_create_mprofile_target_description): New declaration.
5563         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5564         read_description functions.
5565         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5566         Likewise.
5567         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5568         * arm-tdep.c (tdesc_arm_list): New variable.
5569         (arm_register_g_packet_guesses): Call create description functions.
5570         (arm_read_description) (arm_read_mprofile_description): New
5571         function.
5572         * arm-tdep.h (arm_read_description)
5573         (arm_read_mprofile_description): Add declaration.
5574         * configure.tgt: Add new files.
5575
5576 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5577
5578         * top.c (new_ui_command): Open specified terminal just once.
5579
5580 2019-07-18  Tom Tromey  <tromey@adacore.com>
5581
5582         * symtab.c (main_name): Constify return type.
5583         * symfile.c (set_initial_language): Update.
5584         * symtab.h (main_name): Constify return type.
5585
5586 2019-07-17  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-winsource.c (tui_update_source_window)
5589         (tui_update_source_window_as_is)
5590         (tui_update_source_windows_with_line): Remove return.
5591         * tui/tui-disasm.c (tui_show_disassem)
5592         (tui_show_disassem_and_update_source): Remove return.
5593         * tui/tui.c (tui_reset): Remove return.
5594         * tui/tui-wingeneral.c
5595         (tui_check_and_display_highlight_if_needed): Remove return.
5596
5597 2019-07-17  Tom Tromey  <tom@tromey.com>
5598
5599         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5600
5601 2019-07-17  Tom Tromey  <tom@tromey.com>
5602
5603         * tui/tui-winsource.h (struct tui_exec_info_window)
5604         (struct tui_source_window_base): Move from tui-data.h.
5605         * tui/tui-winsource.c: Move many method definitions from
5606         elsewhere.  Remove "structuring" comments.
5607         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5608         (tui_source_window_base::refresh_window): Move to
5609         tui-winsource.c.
5610         * tui/tui-win.c (tui_source_window_base::refresh_all)
5611         (tui_source_window_base::update_tab_width)
5612         (tui_source_window_base::set_new_height)
5613         (tui_source_window_base::do_make_visible_with_new_height): Move to
5614         tui-winsource.c.
5615         * tui/tui-source.h: Update.
5616         * tui/tui-source.c (tui_source_window_base::reset): Move to
5617         tui-winsource.c.
5618         * tui/tui-disasm.h: Update.
5619         * tui/tui-data.h (struct tui_exec_info_window): Move to
5620         tui-winsource.h.
5621         (struct tui_source_window_base): Likewise.
5622         * tui/tui-data.c (tui_source_window_base::clear_detail)
5623         (tui_source_window_base, ~tui_source_window_base): Move to
5624         tui-winsource.c.
5625
5626 2019-07-17  Tom Tromey  <tom@tromey.com>
5627
5628         * tui/tui-win.c (tui_resize_all)
5629         (tui_source_window_base::update_tab_width)
5630         (tui_adjust_win_heights): Update.
5631         (tui_win_info::make_invisible_and_set_new_height): Rename from
5632         make_invisible_and_set_new_height.
5633         * tui/tui-data.h (struct tui_win_info)
5634         <make_invisible_and_set_new_height>: New method.
5635
5636 2019-07-17  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui.c: Update.
5639         * tui/tui-source.h (struct tui_source_window): Move from
5640         tui-data.h.
5641         * tui/tui-layout.c: Update.
5642         * tui/tui-disasm.c: Update.
5643         * tui/tui-data.h (struct tui_source_window): Move to
5644         tui-source.h.
5645
5646 2019-07-17  Tom Tromey  <tom@tromey.com>
5647
5648         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5649         tui-data.h.
5650         * tui/tui-data.h (struct tui_disasm_window): Move to
5651         tui-disasm.h.
5652
5653 2019-07-17  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-regs.h (struct tui_data_item_window): Move from
5656         tui-data.h.
5657         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5658         * tui/tui-data.h (struct tui_data_item_window): Move to
5659         tui-regs.h.
5660         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5661
5662 2019-07-17  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui.c: Update.
5665         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5666         (tui_cmd_window::max_height): Move to tui-command.c.
5667         * tui/tui-layout.c: Update.
5668         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5669         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5670         tui-command.c.
5671         * tui/tui-command.h (struct tui_cmd_window): Move from
5672         tui-data.h.
5673         * tui/tui-command.c: Remove "structuring" comments.
5674         (tui_cmd_window::clear_detail)
5675         (tui_cmd_window::do_make_visible_with_new_height)
5676         (tui_cmd_window::max_height): Move from elsewhere.
5677
5678 2019-07-17  Tom Tromey  <tom@tromey.com>
5679
5680         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5681         Now static.
5682         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5683         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5684
5685 2019-07-17  Tom Tromey  <tom@tromey.com>
5686
5687         * tui/tui.c: Update.
5688         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5689         tui-regs.c.
5690         * tui/tui-windata.h: Remove file.
5691         * tui/tui-windata.c: Remove file.
5692         * tui/tui-win.c (tui_data_window::set_new_height)
5693         (tui_data_window::do_make_visible_with_new_height): Move to
5694         tui-regs.c.
5695         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5696         * tui/tui-regs.c: Remove "structuring" comments.
5697         (tui_data_window::first_data_item_displayed)
5698         (tui_data_window::delete_data_content_windows)
5699         (tui_data_window::erase_data_content)
5700         (tui_data_window::display_all_data)
5701         (tui_data_window::refresh_all)
5702         (tui_data_window::do_scroll_vertical)
5703         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5704         (tui_data_window::do_make_visible_with_new_height)
5705         (tui_data_window::refresh_window): Move from elsewhere.
5706         (_initialize_tui_regs): Move to end of file.
5707         * tui/tui-layout.c: Update.
5708         * tui/tui-hooks.c: Update.
5709         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5710         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5711         tui-regs.c.
5712         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5713
5714 2019-07-17  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5717         seen.
5718
5719 2019-07-17  Tom Tromey  <tom@tromey.com>
5720
5721         * tui/tui-win.c (tui_source_window_base::set_new_height)
5722         (tui_source_window_base::do_make_visible_with_new_height): Use
5723         m_has_locator field directly.
5724         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5725         method.
5726         (struct tui_source_window_base) <has_locator>: Likewise.
5727
5728 2019-07-17  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5731         Don't declare.
5732         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5733         Remove.
5734         * tui/tui-win.c (tui_source_window_base::set_new_height)
5735         (tui_source_window_base::set_new_height)
5736         (make_invisible_and_set_new_height)
5737         (tui_source_window_base::do_make_visible_with_new_height)
5738         (tui_source_window_base::do_make_visible_with_new_height):
5739         Update.
5740         * tui/tui-layout.c (show_source_disasm_command, show_data)
5741         (show_source_or_disasm_and_command): Update.
5742         * tui/tui-layout.c (show_layout): Update.
5743
5744 2019-07-17  Tom Tromey  <tom@tromey.com>
5745
5746         * tui/tui-layout.c (make_data_window): Remove.
5747         (show_data): Unify creation and re-initialization cases.
5748
5749 2019-07-17  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-layout.c (make_source_window, make_disasm_window):
5752         Remove.
5753         (show_data): Unify creation and re-initialization cases.
5754
5755 2019-07-17  Tom Tromey  <tom@tromey.com>
5756
5757         * tui/tui-layout.c (make_command_window): Remove.
5758         (show_source_disasm_command, show_source_or_disasm_and_command):
5759         Unify creation and re-initialization cases.
5760
5761 2019-07-17  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5764         creation and re-initialization cases.
5765
5766 2019-07-17  Tom Tromey  <tom@tromey.com>
5767
5768         * tui/tui-regs.c (tui_get_register): Return void.
5769
5770 2019-07-17  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5773         Simplify.
5774
5775 2019-07-17  Tom Tromey  <tom@tromey.com>
5776
5777         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5778         resetting.
5779
5780 2019-07-17  Tom Tromey  <tom@tromey.com>
5781
5782         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5783         * tui/tui-regs.c (tui_reg_layout): New function.
5784         (tui_show_registers, tui_reg_command): Use it.
5785         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5786         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5787         parameters.
5788         (tui_layout_command): Remove.
5789
5790 2019-07-17  Tom Tromey  <tom@tromey.com>
5791
5792         * tui/tui-layout.h (tui/tui-layout): Return void.
5793         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5794
5795 2019-07-17  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-layout.c (show_source_disasm_command, show_data):
5798         Update.
5799         (reset_locator): Remove.
5800         (show_source_or_disasm_and_command): Update.
5801
5802 2019-07-17  Tom Tromey  <tom@tromey.com>
5803
5804         * tui/tui-source.c (tui_source_window_base::reset): Remove
5805         win_type parameter.
5806         * tui/tui-layout.c (make_command_window, make_source_window)
5807         (make_disasm_window, make_data_window)
5808         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5809         (reset_locator, show_source_or_disasm_and_command): Update.
5810         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5811         win_type parameter.
5812         (struct tui_source_window_base) <reset>: Likewise.
5813
5814 2019-07-17  Tom Tromey  <tom@tromey.com>
5815
5816         * tui/tui-layout.c (show_source_disasm_command): Use
5817         reset_locator.
5818         (reset_locator): New function.
5819         (init_and_make_win): Remove.
5820         (show_source_or_disasm_and_command): Use reset_locator.
5821
5822 2019-07-17  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5825         condition.
5826         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5827         Remove condition.
5828         * tui/tui-source.c (tui_source_window_base::reset): New method.
5829         * tui/tui-layout.c (make_command_window): Don't call
5830         init_and_make_win.
5831         (make_source_window, make_disasm_window): Don't call
5832         make_source_or_disasm_window.
5833         (make_data_window): Don't call init_and_make_win.  Change calling
5834         convention.
5835         (show_source_disasm_command, show_data): Simplify.
5836         (make_source_or_disasm_window): Remove.
5837         (show_source_or_disasm_and_command): Simplify.
5838         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5839         (struct tui_source_window_base) <reset>: Likewise.
5840         <execution_info>: Remove initializer.
5841         * tui/tui-data.c (tui_source_window_base): Initialize
5842         execution_info.
5843
5844 2019-07-17  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5847         variable.
5848
5849 2019-07-17  Tom Tromey  <tom@tromey.com>
5850
5851         * tui/tui.c (tui_rl_other_window): Update.
5852         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5853         superclass method first.  Always iterate over regs_content.
5854         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5855         method.
5856         * tui/tui-win.c (tui_set_focus_command): Update.
5857
5858 2019-07-17  Tom Tromey  <tom@tromey.com>
5859
5860         * tui/tui-win.c (tui_set_focus_command): Rename from
5861         tui_set_focus.  Call tui_enable.
5862         (tui_set_focus_command): Remove.
5863
5864 2019-07-17  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5867         refresh_window.
5868         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5869         touchwin.
5870         (tui_data_window::refresh_window): Call refresh_window on data
5871         items.  Always call superclass refresh_window.
5872         (tui_win_info::refresh): Remove.
5873         (tui_source_window_base::refresh_window): Update.
5874         (tui_refresh_all): Update.
5875         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5876         refresh_window.
5877         (show_source_or_disasm_and_command): Likewise.
5878         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5879         (struct tui_source_window_base) <refresh>: Likewise.
5880
5881 2019-07-17  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-winsource.c (tui_clear_source_content)
5884         (tui_show_source_content): Update.
5885         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5886         whether content is empty.
5887         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5888         Remove.
5889
5890 2019-07-17  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5893         window's contents.
5894         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5895         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5896
5897 2019-07-17  Tom Tromey  <tom@tromey.com>
5898
5899         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5900         (struct tui_data_item_window): Update.
5901
5902 2019-07-17  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5905         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5906         defines.
5907
5908 2019-07-17  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-winsource.h (tui_erase_source_content)
5911         (tui_clear_source_content): Remove "display_prompt" parameter.
5912         * tui/tui-winsource.c (tui_update_source_window_as_is)
5913         (tui_update_source_windows_with_addr): Update.
5914         (tui_clear_source_content): Remove "display_prompt" parameter.
5915         (tui_erase_source_content): Likewise.  Simplify.
5916         (tui_show_source_content): Update.
5917         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5918         * tui/tui-stack.c (tui_show_frame_info): Update.
5919         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5920         Remove defines.
5921
5922 2019-07-17  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5925         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5926         parameter.
5927         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5928         parameter.
5929
5930 2019-07-17  Tom Tromey  <tom@tromey.com>
5931
5932         * tui/tui-winsource.c (tui_clear_source_content)
5933         (tui_show_source_content, tui_show_exec_info_content)
5934         (tui_clear_exec_info_content): Update.
5935         * tui/tui-stack.c (tui_show_locator_content): Update.
5936         (tui_show_frame_info): Update.
5937         * tui/tui-source.h (tui_source_window): Don't declare.
5938         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5939         from tui_source_is_displayed.
5940         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5941         Remove field.
5942         (struct tui_source_window_base) <content_in_use>: New field.  Now
5943         bool.
5944         (struct tui_source_window) <showing_source_p>: New method.
5945         (TUI_SRC_WIN): Change cast.
5946         * tui/tui-data.c (tui_initialize_static_data): Update.
5947
5948 2019-07-17  Tom Tromey  <tom@tromey.com>
5949
5950         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5951         location_matches_p.
5952         * tui/tui-source.c (tui_source_window::location_matches_p): New
5953         method.
5954         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5955         method.
5956         * tui/tui-data.h (struct tui_source_window_base)
5957         <location_matches_p>: New method.
5958         (struct tui_source_window, struct tui_disasm_window)
5959         <location_matches_p>: Likewise.
5960
5961 2019-07-17  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-win.c (tui_set_win_height_command): Rename from
5964         tui_set_win_height.
5965         (tui_set_win_height_command): Remove.
5966
5967 2019-07-17  Tom Tromey  <tom@tromey.com>
5968
5969         * tui/tui-source.c (tui_source_window): New constructor.  Add
5970         observer.
5971         (~tui_source_window): New destructor.
5972         (tui_source_window::style_changed): New method.
5973         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5974         (tui_attach_detach_observers): Update.
5975         * tui/tui-data.h (struct tui_source_window): Make constructor not
5976         inline.  Add destructor.
5977         (struct tui_source_window) <style_changed>: New method.
5978         <m_observable>: New member.
5979
5980 2019-07-17  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5983         * tui/tui-win.c (tui_resize_all): Fix typo.
5984
5985 2019-07-17  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5988         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5989         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5990         * tui/tui-win.c (window_name_completer): Use foreach.
5991         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5992         (update_tab_width): Likewise.
5993         * tui/tui-layout.c (show_layout): Update.
5994         * tui/tui-data.h (class tui_window_iterator): New.
5995         (struct all_tui_windows): New.
5996         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5997
5998 2019-07-17  Tom Tromey  <tom@tromey.com>
5999
6000         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6001         parameter.  Don't reference globals.
6002         (tui_reg_command): Update.
6003
6004 2019-07-17  Tom Tromey  <tom@tromey.com>
6005
6006         * tui/tui-regs.c (tui_show_registers): Simplify.
6007
6008 2019-07-17  Tom Tromey  <tom@tromey.com>
6009
6010         * tui/tui-regs.c (tui_show_registers): Update.
6011         (tui_show_register_group): Add win_info parameter.
6012
6013 2019-07-17  Tom Tromey  <tom@tromey.com>
6014
6015         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6016         Rename from tui_display_reg_element_at_line.
6017         (tui_data_window::display_registers_from_line): Update.
6018         * tui/tui-data.h (struct tui_data_window)
6019         <display_reg_element_at_line>: New method.
6020
6021 2019-07-17  Tom Tromey  <tom@tromey.com>
6022
6023         * tui/tui-regs.h (tui_display_registers_from)
6024         (tui_display_registers_from_line): Don't declare.
6025         * tui/tui-windata.c (tui_data_window::display_all_data)
6026         (tui_data_window::refresh_all)
6027         (tui_data_window::do_scroll_vertical): Update.
6028         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6029         from tui_display_registers_from.
6030         (tui_display_reg_element_at_line): Update.
6031         (tui_data_window::display_registers_from_line): Rename from
6032         tui_display_registers_from_line.
6033         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6034         display_registers_from_line>: New methods.
6035
6036 2019-07-17  Tom Tromey  <tom@tromey.com>
6037
6038         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6039         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6040         from tui_erase_data_content.
6041         (tui_data_window::display_all_data)
6042         (tui_data_window::refresh_all)
6043         (tui_data_window::do_scroll_vertical): Update.
6044         * tui/tui-regs.c (tui_show_registers): Update.
6045         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6046         New method.
6047
6048 2019-07-17  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6051         declare.
6052         * tui/tui-windata.c
6053         (tui_data_window::delete_data_content_windows): Rename from
6054         tui_delete_data_content_windows.
6055         (tui_data_window::display_all_data)
6056         (tui_data_window::do_scroll_vertical): Update.
6057         * tui/tui-data.h (struct tui_data_window)
6058         <delete_data_content_windows>: New method.
6059
6060 2019-07-17  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6063         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6064
6065 2019-07-17  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6068         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6069         from tui_display_all_data.
6070         * tui/tui-win.c
6071         (tui_data_window::do_make_visible_with_new_height): Update.
6072         * tui/tui-regs.c (tui_show_registers): Update.
6073         * tui/tui-layout.c (tui_set_layout): Update.
6074         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6075         method.
6076
6077 2019-07-17  Tom Tromey  <tom@tromey.com>
6078
6079         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6080         * tui/tui-windata.c (tui_display_data_from): Remove.
6081         (tui_data_window::refresh_all): Update.
6082
6083 2019-07-17  Tom Tromey  <tom@tromey.com>
6084
6085         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6086         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6087         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6088         tui_display_registers_from_line.
6089         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6090         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6091         "force_display" parameter.
6092
6093 2019-07-17  Tom Tromey  <tom@tromey.com>
6094
6095         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6096         declare.
6097         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6098         Rename from tui_first_reg_element_no_inline.
6099         (tui_display_reg_element_at_line)
6100         (tui_display_registers_from_line): Update.
6101         * tui/tui-data.h (struct tui_data_window)
6102         <first_reg_element_no_inline>: New method.
6103
6104 2019-07-17  Tom Tromey  <tom@tromey.com>
6105
6106         * tui/tui-windata.c (tui_display_data_from)
6107         (tui_data_window::do_scroll_vertical): Update.
6108         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6109         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6110         Rename from tui_line_from_reg_element_no.
6111         (tui_display_registers_from_line): Update.
6112         * tui/tui-data.h (struct tui_data_window)
6113         <line_from_reg_element_no>: New method.
6114
6115 2019-07-17  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6118         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6119         tui_last_regs_line_no.
6120         (tui_display_reg_element_at_line)
6121         (tui_display_registers_from_line): Update.
6122         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6123         method.
6124
6125 2019-07-17  Tom Tromey  <tom@tromey.com>
6126
6127         PR tui/24722:
6128         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6129         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6130         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6131         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6132         (tui_update_breakpoint_info): Likewise.
6133         * tui/tui-hooks.c (tui_event_create_breakpoint)
6134         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6135         Update.
6136
6137 2019-07-17  Tom Tromey  <tom@tromey.com>
6138
6139         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6140
6141 2019-07-17  Tom Tromey  <tom@tromey.com>
6142
6143         * tui/tui-winsource.c (tui_update_source_window_as_is)
6144         (tui_update_source_windows_with_addr): Update.
6145         * tui/tui-source.h (tui_set_source_content)
6146         (tui_show_symtab_source): Add "win_info" parameter.
6147         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6148         parameter.
6149         (tui_show_symtab_source): Likewise.
6150
6151 2019-07-17  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-wingeneral.c
6154         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6155
6156 2019-07-17  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6159         (struct tui_cmd_window) <can_scroll>: New method.
6160         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6161         method.
6162
6163 2019-07-17  Tom Tromey  <tromey@adacore.com>
6164
6165         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6166         do_field_signed>: Rename.  Change type of "value".
6167         * ui-out.c (ui_out::field_signed): Rename from field_int.
6168         Change type of "value".
6169         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6170         type of "value".
6171         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6172         do_field_int.  Change type of "value".
6173         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6174         do_field_int.  Change type of "value".
6175         * tracepoint.c (trace_status_mi, tfind_1)
6176         (print_one_static_tracepoint_marker): Update.
6177         * thread.c (print_thread_info_1, print_selected_thread_frame):
6178         Update.
6179         * stack.c (print_frame, print_frame_info): Update.
6180         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6181         Update.
6182         * source.c (print_source_lines_base): Update.
6183         * skip.c (info_skip_command): Update.
6184         * record-btrace.c (btrace_ui_out_decode_error)
6185         (btrace_call_history_src_line): Update.
6186         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6187         Update.
6188         * progspace.c (print_program_space): Update.
6189         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6190         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6191         do_field_int.  Change type of "value".
6192         * mi/mi-out.c (mi_ui_out::do_table_begin)
6193         (mi_ui_out::do_table_header): Update.
6194         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6195         type of "value".
6196         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6197         (mi_cmd_data_list_changed_registers, output_register)
6198         (mi_cmd_data_read_memory, mi_load_progress)
6199         (mi_cmd_trace_frame_collected): Update.
6200         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6201         Update.
6202         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6203         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6204         (mi_cmd_var_list_children, varobj_update_one): Update.
6205         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6206         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6207         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6208         * inferior.c (print_inferior): Update.
6209         * gdb_bfd.c (print_one_bfd): Update.
6210         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6211         Update.
6212         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6213         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6214         do_field_int.  Change type of "value".
6215         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6216         do_field_int.  Change type of "value".
6217         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6218         (print_one_breakpoint_location, print_it_catch_fork)
6219         (print_one_catch_fork, print_it_catch_vfork)
6220         (print_one_catch_vfork, print_it_catch_solib)
6221         (print_it_catch_exec, print_it_ranged_breakpoint)
6222         (print_mention_watchpoint, print_mention_masked_watchpoint)
6223         (bkpt_print_it, update_static_tracepoint): Update.
6224         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6225         * break-catch-syscall.c (print_it_catch_syscall): Update.
6226         * ada-tasks.c (print_ada_task_info): Update.
6227         * ada-lang.c (print_it_exception, print_mention_exception):
6228         Update.
6229
6230 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6231
6232         PR breakpoints/24541
6233         * gdbarch.c: Regenerate.
6234         * gdbarch.h: Regenerate.
6235         * gdbarch.sh: Adjust return type and parameter types for
6236         'stap_adjust_register'.
6237         (i386_stap_adjust_register): Adjust signature and return new
6238         register name.
6239         * stap-probe.c (stap_parse_register_operand): Adjust use of
6240         'gdbarch_stap_adjust_register'.
6241
6242 2019-07-17  Tom Tromey  <tromey@adacore.com>
6243
6244         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6245         declare VEC.
6246         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6247         std::vector.
6248         (struct s390_process_info): Add initializers.
6249         (s390_add_process): Use new.
6250         (s390_linux_nat_target::low_forget_process): Use delete.
6251         (s390_linux_nat_target::low_new_fork)
6252         (s390_linux_nat_target::stopped_by_watchpoint)
6253         (s390_linux_nat_target::low_prepare_to_resume)
6254         (s390_linux_nat_target::insert_watchpoint)
6255         (s390_linux_nat_target::insert_hw_breakpoint)
6256         (s390_linux_nat_target::remove_watchpoint)
6257         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6258
6259 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6260
6261         * aarch64-fbsd-nat.c: Include regcache.h.
6262         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6263         argument.
6264         (aarch64_fbsd_nat_target::fetch_registers)
6265         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6266         variable.
6267         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6268
6269 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6270
6271         * fbsd-nat.c: Include gdbarch.h.
6272
6273 2019-07-15  Tom Tromey  <tromey@adacore.com>
6274
6275         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6276
6277 2019-07-15  Tom Tromey  <tromey@adacore.com>
6278
6279         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6280         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6281         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6282         * cli-out.c (cli_ui_out::do_field_int): New method.
6283         * ui-out.c (ui_out::field_unsigned): New method.
6284         * symfile.c (generic_load): Use field_unsigned.
6285         (print_transfer_performance): Likewise.
6286         * record-btrace.c (ui_out_field_uint): Remove.
6287         (btrace_call_history_insn_range, btrace_call_history): Use
6288         field_unsigned.
6289         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6290         field_unsigned.
6291         * ui-out.h (class ui_out) <field_unsigned>: New method.
6292         <do_field_unsigned>: Likewise.
6293
6294 2019-07-15  Tom Tromey  <tromey@adacore.com>
6295
6296         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6297         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6298         * target.c (flash_erase_command): Use field_string.
6299         * infrun.c (print_signal_received_reason): Use field_string.
6300         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6301         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6302         field_string.
6303         * ada-tasks.c (print_ada_task_info): Use field_string.
6304
6305 2019-07-15  Tom Tromey  <tromey@adacore.com>
6306
6307         * target.c (flash_erase_command): Use field_core_addr.
6308         * symfile.c (generic_load): Use field_core_addr.
6309         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6310         Use field_core_addr.
6311         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6312         field_core_addr.
6313
6314 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6317         value if its desired type is smaller than a CORE_ADDR and signed.
6318
6319 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6322         of changes to field names, and use new is_reference field to
6323         decide if a property is a reference or not.
6324         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6325         field.
6326         (struct dwarf2_property_baton): Update header comment, rename
6327         'referenced_type' to 'property_type' and update comments.
6328         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6329         default property type, store in property baton, update to take
6330         accound of renamed field.
6331         (read_func_scope): Update call to attr_to_dynamic_prop.
6332         (read_array_type): Likewise.
6333         (dwarf2_per_cu_addr_sized_int_type): New function.
6334         (read_subrange_index_type): Move type finding code to
6335         dwarf2_per_cu_addr_sized_int_type.
6336         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6337         (dwarf2_per_cu_addr_type): New function.
6338         (set_die_type): Update calls to attr_to_dynamic_prop.
6339
6340 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * dwarf2read.c (read_subrange_index_type): New function.
6343         (read_subrange_type): Move code into new function and call it.
6344         * gdbtypes.c (create_range_type): Add some asserts.
6345
6346 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6347
6348         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6349         update return statements.
6350         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6351         declaration, and update comment to match.
6352         * gdbtypes.c (resolve_dynamic_array): Update call to
6353         dwarf2_evaluate_property to match new return type.
6354
6355 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6356
6357         * valarith.c (value_subscripted_rvalue): Change lowerbound
6358         parameter type from int to LONGEST.
6359         * value.h (value_subscripted_rvalue): Likewise in declaration.
6360
6361 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * cli/cli-utils.c (info_print_command_completer): New function.
6364         * cli/cli-utils.h: Add 'completer.h' include, and forward
6365         declaration for 'struct cmd_list_element'.
6366         (info_print_command_completer): Declare.
6367         * stack.c (_initialize_stack): Add completer for 'info locals' and
6368         'info args'.
6369         * symtab.c (_initialize_symtab): Add completer for 'info
6370         variables' and 'info functions'.
6371         * NEWS: Mention completion for additional info commands.
6372
6373 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6374
6375         * cli/cli-utils.c (extract_info_print_args): Delete.
6376         (extract_arg_maybe_quoted): Delete.
6377         (info_print_options_defs): New variable.
6378         (make_info_print_options_def_group): New function.
6379         (extract_info_print_options): Define new function.
6380         * cli/cli-utils.h (extract_info_print_args): Delete.
6381         (struct info_print_options): New structure.
6382         (extract_info_print_options): Declare new function.
6383         * stack.c (info_locals_command): Update to use new
6384         extract_info_print_options, also add a header comment.
6385         (info_args_command): Likewise.
6386         * symtab.c (info_variables_command): Likewise.
6387         (info_functions_command): Likewise.
6388
6389 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6392         to extract string arguments.
6393         * common/common-utils.c (extract_string_maybe_quoted): New function.
6394         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6395
6396 2019-07-11  Tom Tromey  <tromey@adacore.com>
6397
6398         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6399         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6400         * top.h (gdbinit): Don't declare.
6401         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6402         into...
6403         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6404         * top.c (gdb_init): Don't call init_cli_cmds.
6405         (gdbinit): Remove.
6406         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6407
6408 2019-07-11  Tom Tromey  <tromey@adacore.com>
6409
6410         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6411         after it has been moved.
6412
6413 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6414
6415         * valops.c (value_must_coerce_to_target): Change return type to
6416         bool.
6417         * value.h (value_must_coerce_to_target): Likewise.
6418
6419 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6420
6421         * breakpoint.c (is_hardware_watchpoint): Remove
6422         forward-declaration.
6423         (is_masked_watchpoint): Change return type to bool.
6424         (is_tracepoint): Likewise.
6425         (is_breakpoint): Likewise.
6426         (is_hardware_watchpoint): Likewise.
6427         (is_watchpoint): Likewise.
6428         (is_no_memory_software_watchpoint): Likewise.
6429         (is_catchpoint): Likewise.
6430         (breakpoint_1): Make FILTER parameter's return type bool.
6431         is_masked_watchpoint): Change return type to bool.
6432         (save_breakpoints): Make FILTER parameter's return type bool.
6433         * breakpoint.h (is_breakpoint): Change return type to bool.
6434         (is_watchpoint): Likewise.
6435         (is_catchpoint): Likewise.
6436         (is_tracepoint): Likewise.
6437
6438 2019-07-10  Tom Tromey  <tom@tromey.com>
6439
6440         * defs.h: Don't include gdbarch.h.
6441         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6442         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6443         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6444         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6445         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6446         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6447         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6448         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6449         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6450         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6451         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6452         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6453         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6454         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6455         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6456         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6457         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6458         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6459         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6460         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6461         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6462         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6463         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6464         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6465         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6466         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6467         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6468
6469 2019-07-10  Tom Tromey  <tromey@adacore.com>
6470
6471         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6472         * breakpoint.c (init_ada_exception_breakpoint): Register as
6473         bp_catchpoint.
6474         (print_one_breakpoint_location, print_one_breakpoint): Use
6475         is_ada_exception_catchpoint.
6476         * ada-lang.c (class ada_catchpoint_location): Pass
6477         bp_loc_software_breakpoint to bp_location constructor.
6478         (is_ada_exception_catchpoint): New function.
6479
6480 2019-07-10  Tom Tromey  <tromey@adacore.com>
6481
6482         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6483         VEC.
6484         (struct arm_exidx_entry): New method operator<.
6485         (struct arm_exidx_data) <section_maps>: Change type.
6486         (arm_exidx_data_free): Remove.
6487         (arm_exidx_data_key): Change type.  Move lower.
6488         (arm_exidx_new_objfile): Update.
6489         (arm_compare_exidx_entries): Remove.
6490         (arm_find_exidx_entry, _initialize_arm_tdep)
6491
6492 2019-07-10  Tom Tromey  <tromey@adacore.com>
6493
6494         * solib-spu.c (ocl_program_data_key): Change type.
6495         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6496         Update.
6497
6498 2019-07-10  Tom Tromey  <tromey@adacore.com>
6499
6500         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6501         (struct solib_aix_inferior_data) <library_list>: Change type.
6502         (solib_aix_inferior_data_handle): Change type.
6503         (get_solib_aix_inferior_data): Update.
6504         (solib_aix_free_library_list): Remove.
6505         (library_list_start_library): Update.
6506         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6507         return type.
6508         (solib_aix_get_library_list)
6509         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6510         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6511
6512 2019-07-10  Tom Tromey  <tromey@adacore.com>
6513
6514         * solib-dsbt.c (struct dsbt_info): Add initializers.
6515         (solib_dsbt_pspace_data): Change type.
6516         (dsbt_pspace_data_cleanup): Remove.
6517         (get_dsbt_info, _initialize_dsbt_solib): Update.
6518
6519 2019-07-10  Tom Tromey  <tromey@adacore.com>
6520
6521         * spu-tdep.c (spu_overlay_data): Change type.
6522         (spu_get_overlay_table, spu_overlay_new_objfile)
6523         (_initialize_spu_tdep): Update.
6524
6525 2019-07-10  Tom Tromey  <tromey@adacore.com>
6526
6527         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6528         destructor.
6529         (dbx_objfile_data_key): Change type and declare later.
6530         (DBX_SYMFILE_INFO): Rewrite.
6531         * dbxread.c (dbx_objfile_data_key): Change type.
6532         (dbx_symfile_init): Update.
6533         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6534         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6535         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6536
6537 2019-07-10  Tom Tromey  <tromey@adacore.com>
6538
6539         * jit.c (jit_program_space_key): Change type.  Move lower.
6540         (get_jit_program_space_data): Update.
6541         (jit_program_space_data_cleanup): Remove.
6542         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6543         Update.
6544         (struct jit_program_space_data): Add initializers.
6545
6546 2019-07-10  Tom Tromey  <tromey@adacore.com>
6547
6548         * solib-darwin.c (struct darwin_info): Add initializers.
6549         (solib_darwin_pspace_data): Change type.
6550         (darwin_pspace_data_cleanup): Remove.
6551         (get_darwin_info, _initialize_darwin_solib): Update.
6552
6553 2019-07-10  Tom Tromey  <tromey@adacore.com>
6554
6555         * remote-sim.c (struct sim_inferior_data): Add initializers,
6556         constructor, and destructor.
6557         (sim_inferior_data_key): Change type.  Move lower.
6558         (check_for_duplicate_sim_descriptor): Update.
6559         (get_sim_inferior_data): Use new.  Update.
6560         (~sim_inferior_data_cleanup): Rename from
6561         sim_inferior_data_cleanup.  Simplify.
6562         (gdbsim_close_inferior, simulator_command)
6563         (sim_command_completer, _initialize_remote_sim): Update.
6564         (next_pid, INITIAL_PID): Move earlier.
6565
6566 2019-07-10  Tom Tromey  <tromey@adacore.com>
6567
6568         * python/python-internal.h (create_thread_object): Return
6569         gdbpy_ref.
6570         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6571         * python/py-inferior.c (struct threadlist_entry): Add
6572         constructor.
6573         <thread_obj>: Now a gdbpy_ref.
6574         (thread_to_thread_object): Update.
6575         (add_thread_object): Use new.
6576         (delete_thread_object): Use delete.
6577         (infpy_threads): Update.
6578         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6579         GIL.
6580
6581 2019-07-10  Tom Tromey  <tromey@adacore.com>
6582
6583         * valops.c (value_cast): Specialize error message for Ada.
6584
6585 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6586
6587         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6588
6589 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6590
6591         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6592         bpstat_should_step): Return bool, adjust comments.
6593         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6594         bpstat_should_step): Likewise.
6595
6596 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6597
6598         * features/Makefile: Use feature target descriptions for Arm.
6599         * features/arm/arm-core.c: Generate new file.
6600         * features/arm/arm-fpa.c: Likewise.
6601         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6602         * features/arm/arm-m-profile.c: Likewise.
6603         * features/arm/arm-vfpv2.c: Likewise.
6604         * features/arm/arm-vfpv3.c: Likewise.
6605         * features/arm/xscale-iwmmxt.c: Likewise.
6606         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6607
6608 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6609
6610         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6611         ptrace earlier.
6612
6613 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6614
6615         * features/aarch64-pauth.c: Regenerate.
6616
6617 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6618
6619         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6620         bool.
6621         (bpstat_what): Use false instead of 0.
6622
6623 2019-07-09  Pedro Alves  <palves@redhat.com>
6624
6625         * break-catch-throw.c (is_exception_catchpoint): New.
6626         * breakpoint.c (print_one_breakpoint_location): New parameter
6627         'raw_loc'.  Handle it.  Use
6628         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6629         looking at the breakpoint's type.
6630         (print_one_breakpoint): If handling "maint info breakpoints", also
6631         print locations of exception catchpoints.
6632         * breakpoint.h (is_exception_catchpoint): Declare.
6633
6634 2019-07-09  Pedro Alves  <palves@redhat.com>
6635
6636         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6637         "addr" field.
6638         (allocate_location_exception_catchpoint): New.
6639         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6640         (initialize_throw_catchpoint_ops): Install
6641         allocate_location_exception_catchpoint as allocate_location
6642         method.
6643         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6644         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6645         bp_loc_other.
6646         (breakpoint_address_is_meaningful): Delete.
6647         (bl_address_is_meaningful): New.
6648         (breakpoint_locations_match): Adjust comment.
6649         (bp_location_from_bp_type): New, factored out of...
6650         (bp_location::bp_location(breakpoint *)): ... this.
6651         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6652         factored out of...
6653         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6654         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6655         breakpoint_address_is_meaningful.
6656         (bp_locations_compare): Adjust comment.
6657         (update_global_location_list): Use bl_address_is_meaningful
6658         instead of breakpoint_address_is_meaningful.
6659         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6660         explicit.
6661         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6662         * python/py-breakpoint.c (bppy_get_location): No longer check
6663         whether location is null.
6664
6665 2019-07-09  Pedro Alves  <palves@redhat.com>
6666
6667         PR c++/15468
6668         * breakpoint.c (print_one_breakpoint_location): Remove
6669         single-location assert.
6670
6671 2019-07-09  Tom Tromey  <tom@tromey.com>
6672
6673         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6674         * configure: Rebuild.
6675         * configure.ac: Change common to gdbsupport.
6676         * gdbsupport: Rename from common.
6677         * acinclude.m4: Change common to gdbsupport.
6678         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6679         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6680         gdbsupport.
6681         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6682         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6683         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6684         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6685         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6686         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6687         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6688         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6689         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6690         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6691         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6692         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6693         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6694         coff-pe-read.c, command.h, compile/compile-c-support.c,
6695         compile/compile-c.h, compile/compile-cplus-symbols.c,
6696         compile/compile-cplus-types.c, compile/compile-cplus.h,
6697         compile/compile-loc2c.c, compile/compile.c, completer.c,
6698         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6699         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6700         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6701         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6702         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6703         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6704         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6705         features/aarch64-core.c, features/aarch64-fpu.c,
6706         features/aarch64-pauth.c, features/aarch64-sve.c,
6707         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6708         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6709         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6710         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6711         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6712         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6713         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6714         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6715         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6716         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6717         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6718         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6719         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6720         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6721         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6722         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6723         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6724         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6725         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6726         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6727         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6728         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6729         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6730         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6731         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6732         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6733         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6734         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6735         minsyms.c, mips-linux-tdep.c, namespace.h,
6736         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6737         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6738         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6739         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6740         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6741         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6742         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6743         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6744         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6745         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6746         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6747         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6748         procfs.c, producer.c, progspace.h, psymtab.h,
6749         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6750         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6751         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6752         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6753         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6754         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6755         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6756         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6757         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6758         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6759         target-memory.c, target.c, target.h, target/waitstatus.c,
6760         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6761         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6762         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6763         unittests/array-view-selftests.c,
6764         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6765         unittests/common-utils-selftests.c,
6766         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6767         unittests/format_pieces-selftests.c,
6768         unittests/function-view-selftests.c,
6769         unittests/lookup_name_info-selftests.c,
6770         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6771         unittests/mkdir-recursive-selftests.c,
6772         unittests/observable-selftests.c,
6773         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6774         unittests/parse-connection-spec-selftests.c,
6775         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6776         unittests/scoped_fd-selftests.c,
6777         unittests/scoped_mmap-selftests.c,
6778         unittests/scoped_restore-selftests.c,
6779         unittests/string_view-selftests.c, unittests/style-selftests.c,
6780         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6781         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6782         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6783         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6784         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6785         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6786
6787 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6788
6789         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6790         bool value.
6791         (decode_digits_ordinary): Set explicit_line field in sal.
6792         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6793         symtab_and_line that was set on an explicit line number in
6794         assembler code.  Do always update the recorded symtab and line if
6795         we do skip the prologue.
6796
6797 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6798
6799         * breakpoint.c (set_breakpoint_location_function): Remove
6800         explicit_loc parameter.
6801         (momentary_breakpoint_from_master): Update call to
6802         set_breakpoint_location_function.
6803         (add_location_to_breakpoint): Likewise.
6804
6805 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6806
6807         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6808         required features based on default bfd type when no specific bfd
6809         is present.
6810
6811 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6812
6813         * NEWS: Mention that GDB printf and eval commands can now print
6814         C-style and Ada-style convenience var strings without
6815         calling the inferior.
6816         * printcmd.c (printf_c_string): Locally print GDB internal var
6817         instead of transiting via the inferior.
6818         (printf_wide_c_string): Likewise.
6819
6820 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6821
6822         PR breakpoints/25011
6823         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6824
6825 2019-07-04  Tom Tromey  <tom@tromey.com>
6826
6827         PR tui/24724:
6828         * tui/tui-winsource.c (tui_clear_source_content): Update.
6829         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6830         (tui_update_breakpoint_info): Update.
6831         (tui_set_exec_info_content): Update.
6832         * tui/tui-source.c (tui_set_source_content_nil): Update.
6833         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6834         has_break.
6835         * tui/tui-data.h (enum tui_bp_flag): New.
6836         (tui_bp_flags): New enum flags type.
6837         (struct tui_source_element) <break_mode>: Change type.  Rename
6838         from has_break.
6839         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6840         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6841         constants.
6842         * tui/tui-winsource.h: Fix comment.
6843
6844 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6845
6846         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6847         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6848         (store_fpregs_to_thread)
6849         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6850         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6851         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6852         (IWMMXT_REGS_SIZE): Add define.
6853         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6854         (fetch_vfp_regs, store_vfp_regs)
6855         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6856         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6857
6858 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6859
6860         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6861         defines.
6862         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6863         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6864         (ARM_INT_REGISTER_SIZE): ...to this.
6865         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6866         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6867         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6868         (arm_linux_collect_gregset, supply_nwfpe_register)
6869         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6870         defines.
6871         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6872         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6873         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6874         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6875         (arm_return_in_memory, arm_store_return_value)
6876         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6877         (arm_record_ld_st_multiple): Likewise.
6878         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6879         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6880
6881 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6882
6883         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6884         AARCH64_DISPLACED_MODIFIED_INSNS.
6885         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6886         (aarch64_displaced_step_copy_insn): Likewise.
6887         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6888         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6889         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6890         ARM_DISPLACED_MODIFIED_INSNS.
6891         * arm-tdep.c (arm_gdbarch_init): Likewise.
6892         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6893         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6894         (struct arm_displaced_step_closure): Use
6895         ARM_DISPLACED_MODIFIED_INSNS.
6896
6897 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6898
6899         * features/Makefile: Remove unused xml files.
6900         * features/aarch64.xml: Remove.
6901         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6902         * features/i386/amd64-avx-avx512.xml: Remove.
6903         * features/i386/amd64-avx-linux.xml: Remove.
6904         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6905         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6906         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6907         * features/i386/amd64-avx-mpx.xml: Remove.
6908         * features/i386/amd64-avx.xml: Remove.
6909         * features/i386/amd64-linux.xml: Remove.
6910         * features/i386/amd64-mpx-linux.xml: Remove.
6911         * features/i386/amd64-mpx.xml: Remove.
6912         * features/i386/amd64.xml: Remove.
6913         * features/i386/i386-avx-avx512-linux.xml: Remove.
6914         * features/i386/i386-avx-avx512.xml: Remove.
6915         * features/i386/i386-avx-linux.xml: Remove.
6916         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6917         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6918         * features/i386/i386-avx-mpx-linux.xml: Remove.
6919         * features/i386/i386-avx-mpx.xml: Remove.
6920         * features/i386/i386-avx.xml: Remove.
6921         * features/i386/i386-linux.xml: Remove.
6922         * features/i386/i386-mmx-linux.xml: Remove.
6923         * features/i386/i386-mmx.xml: Remove.
6924         * features/i386/i386-mpx-linux.xml: Remove.
6925         * features/i386/i386-mpx.xml: Remove.
6926         * features/i386/i386.xml: Remove.
6927         * features/i386/x32-avx-avx512-linux.xml: Remove.
6928         * features/i386/x32-avx-linux.xml: Remove.
6929         * features/i386/x32-linux.xml: Remove.
6930
6931 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6932
6933         * regformats/aarch64.dat: Remove.
6934         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6935         * regformats/i386/amd64-avx-linux.dat: Remove.
6936         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6937         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6938         * regformats/i386/amd64-linux.dat: Remove.
6939         * regformats/i386/amd64-mpx-linux.dat: Remove.
6940         * regformats/i386/amd64.dat: Remove.
6941         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6942         * regformats/i386/i386-avx-linux.dat: Remove.
6943         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6944         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6945         * regformats/i386/i386-linux.dat: Remove.
6946         * regformats/i386/i386-mmx-linux.dat: Remove.
6947         * regformats/i386/i386-mpx-linux.dat: Remove.
6948         * regformats/i386/i386.dat: Remove.
6949         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6950         * regformats/i386/x32-avx-linux.dat: Remove.
6951         * regformats/i386/x32-linux.dat: Remove.
6952
6953 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6954
6955         * aarch64-tdep.c: Remove xml self tests.
6956         * amd64-linux-tdep.c: Likewise.
6957         * amd64-tdep.c: Likewise.
6958         * i386-linux-tdep.c: Likewise.
6959         * i386-tdep.c: Likewise.
6960
6961 2019-07-03  Pedro Alves  <palves@redhat.com>
6962
6963         PR cli/24732
6964         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6965         (pipe_cmd_option_defs): New.
6966         (make_pipe_cmd_options_def_group): New.
6967         (pipe_command): Use gdb::option::process_options.
6968         (pipe_command_completer): New function.
6969         (_initialize_cli_cmds): Install completer for "pipe" command.
6970
6971 2019-07-03  Pedro Alves  <palves@redhat.com>
6972
6973         * cli/cli-option.c (union option_value) <string>: New field.
6974         (struct option_def_and_value): Add ctor, move ctor, dtor and
6975         use DISABLE_COPY_AND_ASSIGN.
6976         (option_def_and_value::clear_value): New.
6977         (parse_option, save_option_value_in_ctx, get_val_type_str)
6978         (add_setshow_cmds_for_options): Handle var_string.
6979         * cli-option.h (union option_def::var_address) <string>: New
6980         field.
6981         (struct string_option_def): New.
6982         * maint-test-options.c (struct test_options_opts): Add default
6983         ctor and use DISABLE_COPY_AND_ASSIGN.
6984         <string_opt>: New field.
6985         (test_options_opts::~test_options_opts): New.
6986         (test_options_opts::dump): Also dump "-string".
6987         (test_options_option_defs): Install "string.
6988
6989 2019-07-03  Pedro Alves  <palves@redhat.com>
6990
6991         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6992         option_value with a null enumeration.
6993         (complete_options): Save the option values in the context.
6994         (save_option_value_in_ctx): New, factored out from ...
6995         (process_options): ... here.
6996         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6997         of the function.
6998         * maint-test-options.c (test_options_opts::dump): New, factored
6999         out from ...
7000         (maintenance_test_options_command_mode): ... here.
7001         (maintenance_test_options_command_completion_result): Delete.
7002         (maintenance_test_options_command_completion_text): Update
7003         comment.
7004         (maintenance_show_test_options_completion_result): Change
7005         prototype.  Just print
7006         maintenance_test_options_command_completion_text.
7007         (save_completion_result): New.
7008         (maintenance_test_options_completer_mode): Pass options context to
7009         complete_options, and then save a dump.
7010         (_initialize_maint_test_options): Use add_cmd to install "maint
7011         show test-options-completion-result".
7012
7013 2019-07-03  Pedro Alves  <palves@redhat.com>
7014
7015         * NEWS (New commands): Mention "with" and "maint with".
7016         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7017         (with_command, with_command_completer): New.
7018         (pipe_command): Adjust to new repeat_previous
7019         interface.
7020         (_initialize_cli_cmds): Install the "with" command and its "w"
7021         alias.
7022         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7023         declarations.
7024         * cli/cli-setshow.c (parse_cli_var_uinteger)
7025         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7026         argument strings for all var_types.
7027         (get_setshow_command_value_string): New, factored out from ...
7028         (do_show_command): ... this.
7029         * cli/cli-setshow.h: Include <string>.
7030         (get_setshow_command_value_string): Declare.
7031         * command.h (repeat_previous): Now returns const char *.  Adjust
7032         comment.
7033         * maint.c: Include "cli/cli-cmds.h".
7034         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7035         (_initialize_maint_cmds): Register the "maintenance with" command.
7036         * top.c (repeat_previous): Move bits from pipe_command here:
7037         Return the saved command line, if any; error out if there's no
7038         command to relaunch.
7039
7040 2019-07-03  Pedro Alves  <palves@redhat.com>
7041
7042         * NEWS (New commands): Mention "maint set/show test-settings"
7043         instead of "maint test-settings".
7044         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7045         (maintenance_test_settings_set_list): Rename to ...
7046         (maintenance_set_test_settings_list): ... this.
7047         (maintenance_test_settings_show_list): Rename to  ...
7048         (maintenance_show_test_settings_list): ... this.
7049         (maintenance_test_settings_cmd): Delete.
7050         (maintenance_test_settings_set_cmd): ...
7051         (maintenance_set_test_settings_cmd): ... this.
7052         (maintenance_test_settings_show_cmd): ...
7053         (maintenance_show_test_settings_cmd): ... this.
7054         (maintenance_test_settings_show_value_cmd):
7055         (maintenance_show_test_settings_value_cmd): ... this.
7056         (_initialize_maint_test_settings): No longer install the "maint
7057         test-settings" prefix command.  Rename "maint test-settings set"
7058         to "maint set test-settings", and "maint test-settings show" to
7059         "maint show test-settings".  Adjust all subcommands.
7060
7061 2019-07-03  Pedro Alves  <palves@redhat.com>
7062
7063         * maint-test-settings.c: Fix file's intro comment.  Replace all
7064         references to "test-options" with references to "test-settings",
7065         in comments.
7066
7067 2019-07-03  Pedro Alves  <palves@redhat.com>
7068
7069         * maint-test-settings.c (maintenance_test_settings_xxx)
7070         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7071         New.
7072         (maintenance_test_settings_enums): Use them.
7073         (maintenance_test_settings_enum): Default to
7074         maintenance_test_settings_xxx.
7075         (_initialize_maint_test_settings): Initialize
7076         MAINTENANCE_TEST_SETTINGS_FILENAME.
7077
7078 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7079
7080         * breakpoint.h (remove_breakpoints_inf): Change return type to
7081         void, move function documentation here.
7082         * breakpoint.c (remove_breakpoints_inf): Change return type to
7083         void, move function documentation to header.
7084
7085 2019-07-02  Pedro Alves  <palves@redhat.com>
7086
7087         * NEWS (Completion improvements): Mention "info threads".
7088         * thread.c (struct info_threads_opts, info_threads_option_defs)
7089         (make_info_threads_options_def_group): New.
7090         (info_threads_command): Use gdb::option::process_options.
7091         (info_threads_command_completer): New.
7092         (_initialize_thread): Use gdb::option::build_help to build the
7093         help text for "info threads".
7094
7095 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7096
7097         * defs.h (generic_load): Move from here...
7098         * symfile.h (generic_load): ... to here.  Rename name parameter
7099         to args.
7100         * symfile.c (generic_load): Add comment.
7101
7102 2019-07-01  Tom Tromey  <tromey@adacore.com>
7103
7104         * dwarf2read.c
7105         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7106         declaration of without_params.  Fix formatting.
7107
7108 2019-07-01  Tom Tromey  <tromey@adacore.com>
7109
7110         * ada-exp.y (find_primitive_type): Update.
7111         * ada-lang.h (ada_lookup_symbol): Update.
7112         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7113         parameter.
7114         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7115
7116 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7117
7118         PR breakpoints/24541
7119         * gdbarch.c: Regenerate.
7120         * gdbarch.h: Regenerate.
7121         * gdbarch.sh: Add 'stap_adjust_register'.
7122         * i386-tdep.c: Include '<unordered_set>'.
7123         (i386_stap_adjust_register): New function.
7124         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7125         * stap-probe.c (stap_parse_register_operand): Call
7126         'gdbarch_stap_adjust_register'.
7127
7128 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7129
7130         PR python/24742
7131         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7132         * python/python.c (do_start_initialization): Use 'xmalloc'
7133         instead of 'PyMem_Malloc'.
7134
7135 2019-06-28  Tom Tromey  <tromey@adacore.com>
7136
7137         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7138         for Ada.
7139
7140 2019-06-27  Tom Tromey  <tromey@adacore.com>
7141
7142         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7143         objfile_key.
7144         (arm_find_mapping_symbol, arm_record_special_symbol)
7145         (_initialize_arm_tdep): Update.
7146         (arm_objfile_data_free): Remove.
7147
7148 2019-06-27  Tom Tromey  <tromey@adacore.com>
7149
7150         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7151         to cp_print_static_field.
7152
7153 2019-06-26  Tom Tromey  <tromey@adacore.com>
7154
7155         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7156         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7157         declare.
7158
7159 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7160
7161         * features/aarch64-core.c (create_feature_aarch64_core):
7162         Regenerate.
7163         * features/aarch64-core.xml: Add cpsr flags.
7164
7165 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7166
7167         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7168         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7169
7170 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7171
7172         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7173         field.
7174         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7175         use.
7176         (arm_record_special_symbol): Don't insert new symbol in sorted
7177         position, push it at the end.
7178
7179 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7180
7181         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7182         (arm_mapping_symbol_s): Remove.
7183         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7184         (arm_mapping_symbol_vec): New typedef.
7185         (struct arm_per_objfile): Add constructor.
7186         <section_maps>: Change type to
7187         std::unique_ptr<arm_mapping_symbol_vec[]>.
7188         (arm_compare_mapping_symbols): Remove.
7189         (arm_find_mapping_symbol): Adjust to section_maps type change.
7190         (arm_objfile_data_free): Call delete on arm_per_objfile.
7191         (arm_record_special_symbol): Adjust to section_maps type change.
7192         Allocate arm_per_objfile with new.
7193
7194 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7195
7196         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7197         with the command prefix.
7198
7199 2019-06-25  Tom Tromey  <tom@tromey.com>
7200
7201         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7202         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7203
7204 2019-06-25  Tom Tromey  <tom@tromey.com>
7205
7206         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7207         type.
7208         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7209         protected.
7210
7211 2019-06-25  Tom Tromey  <tom@tromey.com>
7212
7213         * tui/tui-winsource.c
7214         (tui_source_window_base::set_is_exec_point_at): Add check against
7215         LOA_ADDRESS.
7216
7217 2019-06-25  Tom Tromey  <tom@tromey.com>
7218
7219         * tui/tui-source.c (tui_set_source_content): Don't check before
7220         xfree.
7221         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7222
7223 2019-06-25  Tom Tromey  <tom@tromey.com>
7224
7225         * tui/tui-winsource.h (tui_update_source_window_as_is)
7226         (tui_alloc_source_buffer, tui_line_is_displayed)
7227         (tui_addr_is_displayed): Change type of win_info.
7228         * tui/tui-winsource.c (tui_update_source_window_as_is)
7229         (tui_clear_source_content, tui_show_source_line)
7230         (tui_show_source_content, tui_source_window_base::refill)
7231         (tui_source_window_base::set_is_exec_point_at)
7232         (tui_source_window_base::set_is_exec_point_at)
7233         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7234         (tui_alloc_source_buffer, tui_line_is_displayed)
7235         (tui_addr_is_displayed): Change type of win_info.  Update.
7236         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7237         (tui_source_window_base::do_make_visible_with_new_height):
7238         Update.
7239         * tui/tui-source.c (tui_set_source_content)
7240         (tui_set_source_content_nil)
7241         (tui_source_window::do_scroll_vertical): Update.
7242         * tui/tui-layout.c (show_layout): Update.
7243         * tui/tui-disasm.c (tui_set_disassem_content)
7244         (tui_disasm_window::do_scroll_vertical): Update.
7245         * tui/tui-data.h (tui_win_content): Remove.
7246         (struct tui_gen_win_info) <content, content_size>: Remove.
7247         (struct tui_source_element): Add initializers and destructor.
7248         (union tui_which_element, struct tui_win_element): Remove.
7249         (struct tui_source_window_base) <content>: New field.
7250         (struct tui_data_window): Remove destructor.
7251         (tui_alloc_content, tui_free_win_content)
7252         (tui_free_all_source_wins_content): Don't declare.
7253         * tui/tui-data.c (tui_initialize_static_data): Update.
7254         (init_content_element, tui_alloc_content): Remove.
7255         (~tui_gen_win_info): Update.
7256         (~tui_data_window, tui_free_all_source_wins_content)
7257         (tui_free_win_content, free_content, free_content_elements):
7258         Remove.
7259
7260 2019-06-25  Tom Tromey  <tom@tromey.com>
7261
7262         * tui/tui-winsource.h (tui_clear_source_content)
7263         (tui_erase_source_content, tui_show_source_content): Change type
7264         of win_info.
7265         * tui/tui-winsource.c (tui_clear_source_content)
7266         (tui_erase_source_content, tui_show_source_content): Change type
7267         of win_info.
7268         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7269         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7270         win_info.
7271         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7272         win_info.
7273         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7274
7275 2019-06-25  Tom Tromey  <tom@tromey.com>
7276
7277         * tui/tui-winsource.c (tui_clear_source_content)
7278         (tui_source_window_base::set_is_exec_point_at): Update.
7279         * tui/tui-source.c (tui_set_source_content_nil): Update.
7280         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7281         a bool.
7282         * tui/tui-data.c (init_content_element): Update.
7283
7284 2019-06-25  Tom Tromey  <tom@tromey.com>
7285
7286         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7287         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7288         * tui/tui-layout.c (init_and_make_win): Update.
7289         * tui/tui.h (enum tui_win_type): Update.
7290         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7291         tui_win_is_auxillary.
7292         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7293         tui_win_is_auxillary.
7294
7295 2019-06-25  Tom Tromey  <tom@tromey.com>
7296
7297         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7298         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7299         (tui_delete_data_content_windows, tui_display_all_data)
7300         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7301         Update.
7302         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7303         * tui/tui-regs.c (tui_last_regs_line_no)
7304         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7305         (tui_show_registers): Update.
7306         (tui_show_register_group): Return void.  Update.
7307         (tui_display_registers_from, tui_display_reg_element_at_line)
7308         (tui_display_registers_from_line, tui_check_register_values):
7309         Update.
7310         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7311         member.
7312         (struct tui_data_window) <regs_content>: Now a std::vector.
7313         <regs_content_count>: Remove.
7314         (tui_add_content_elements, tui_free_data_content): Don't declare.
7315         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7316         (init_content_element): Remove DATA_WIN case.  Add assert.
7317         (tui_add_content_elements): Remove.
7318         (tui_data_window): Update.
7319         (tui_free_data_content): Remove.
7320         (free_content_elements): Remove DATA_WIN case.
7321
7322 2019-06-25  Tom Tromey  <tom@tromey.com>
7323
7324         * tui/tui-data.c (tui_data_item_window): Update.
7325         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7326         * tui/tui-windata.c (tui_display_all_data)
7327         (tui_display_data_from_line): Update.
7328         (tui_check_data_values): Remove.
7329         * tui/tui-regs.c (tui_show_register_group)
7330         (tui_display_reg_element_at_line): Update.
7331         * tui/tui-hooks.c (tui_register_changed)
7332         (tui_refresh_frame_and_register_information): Call
7333         tui_check_register_values.
7334         * tui/tui-data.h (struct tui_data_window) <data_content,
7335         data_content_count, data_type>: Remove.
7336         (enum tui_data_type): Remove.
7337
7338         * tui/tui-data.c (tui_data_window::clear_detail)
7339         (~tui_data_window): Update.
7340
7341 2019-06-25  Tom Tromey  <tom@tromey.com>
7342
7343         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7344         declare.
7345         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7346         Rename from tui_first_data_item_displayed.  Update.
7347         (tui_data_window::refresh_all)
7348         (tui_data_window::do_scroll_vertical): Update.
7349         * tui/tui-data.h (struct tui_data_window)
7350         <first_data_item_displayed>: Declare new method.
7351
7352 2019-06-25  Tom Tromey  <tom@tromey.com>
7353
7354         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7355         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7356         contents...
7357         (tui_initialize_static_data): ...here.
7358
7359 2019-06-25  Tom Tromey  <tom@tromey.com>
7360
7361         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7362         (tui_display_registers_from, tui_check_register_values): Update.
7363         (tui_display_register): Remove win_info parameter; update.
7364         (tui_get_register): Change type of parameters.
7365         * tui/tui-data.h (struct tui_data_element): Remove.
7366         (union tui_which_element) <data>: Remove.
7367         <data_window>: Change type.
7368         (struct tui_data_item_window): New.
7369         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7370         case.  Add assert.
7371         (~tui_data_item_window): New destructor.
7372         (free_content_elements): Remove DATA_ITEM_WIN case.
7373
7374 2019-06-25  Tom Tromey  <tom@tromey.com>
7375
7376         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7377         Remove.
7378
7379 2019-06-25  Tom Tromey  <tom@tromey.com>
7380
7381         * tui/tui-data.h (struct tui_command_element): Remove.
7382         (union tui_which_element) <command>: Remove.
7383         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7384         assert.
7385         (free_content_elements): Remove CMD_WIN case.
7386
7387 2019-06-25  Tom Tromey  <tom@tromey.com>
7388
7389         * tui/tui-layout.c (tui_set_layout): Update.
7390         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7391         * tui/tui-data.c (layout_def): Update.
7392
7393 2019-06-25  Tom Tromey  <tom@tromey.com>
7394
7395         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7396         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7397         (tui_source_window_base::set_new_height): Update.
7398         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7399         Update.
7400         (tui_set_locator_fullname, tui_set_locator_info)
7401         (tui_show_frame_info): Update.
7402         * tui/tui-source.c (tui_set_source_content)
7403         (tui_source_is_displayed): Update.
7404         * tui/tui-layout.c (show_source_disasm_command, show_data)
7405         (show_source_or_disasm_and_command): Update.
7406         * tui/tui-disasm.c (tui_set_disassem_content)
7407         (tui_get_begin_asm_address): Update.
7408         * tui/tui-data.h (struct tui_locator_element): Remove.
7409         (union tui_which_element) <locator>: Remove.
7410         (struct tui_locator_window): New.
7411         (tui_locator_win_info_ptr): Change return type.
7412         * tui/tui-data.c (_locator): Change type.
7413         (tui_locator_win_info_ptr): Change return type.
7414         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7415         (tui_alloc_content): Add assert.
7416
7417 2019-06-25  Tom Tromey  <tom@tromey.com>
7418
7419         * tui/tui-winsource.c
7420         (tui_exec_info_window::maybe_allocate_content): New method.
7421         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7422         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7423         (make_source_or_disasm_window): Add cast.
7424         * tui/tui-data.h (union tui_which_element) <simple_string>:
7425         Remove.
7426         (struct tui_source_info): New.
7427         (struct tui_source_window_base) <execution_info>: Change type.
7428         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7429         case, and add assert.
7430         (tui_alloc_content): Add assert.
7431
7432 2019-06-25  Tom Tromey  <tom@tromey.com>
7433
7434         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7435         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7436         * tui/tui-data.c (tui_alloc_win_info): Remove.
7437
7438 2019-06-25  Tom Tromey  <tom@tromey.com>
7439
7440         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7441         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7442         can_highlight.
7443
7444 2019-06-25  Tom Tromey  <tom@tromey.com>
7445
7446         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7447         make_visible_with_new_height method.
7448         (tui_win_info::make_visible_with_new_height): New method.
7449         (tui_source_window_base::do_make_visible_with_new_height)
7450         (tui_data_window::do_make_visible_with_new_height)
7451         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7452         (make_visible_with_new_height): Remove.
7453         (tui_resize_all, tui_adjust_win_heights): Use
7454         make_visible_with_new_height method.
7455         * tui/tui-data.h (struct tui_win_info)
7456         <do_make_visible_with_new_height, make_visible_with_new_height>:
7457         New methods.
7458         (struct tui_source_window_base, struct tui_data_window)
7459         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7460         methods.
7461
7462 2019-06-25  Tom Tromey  <tom@tromey.com>
7463
7464         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7465         method.
7466         (update_tab_width): Call update_tab_width method.
7467         * tui/tui-data.h (struct tui_win_info)
7468         (struct tui_source_window_base) <update_tab_width>: New methods.
7469
7470 2019-06-25  Tom Tromey  <tom@tromey.com>
7471
7472         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7473         parameter.
7474         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7475         parameter.
7476         (tui_gen_win_info::make_visible): Update.
7477         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7478         parameter.
7479         * tui/tui-data.h (enum tui_box): New enum.
7480         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7481
7482 2019-06-25  Tom Tromey  <tom@tromey.com>
7483
7484         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7485         init_and_make_win for EXEC_INFO_WIN.
7486         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7487         longer inline.
7488         (struct tui_win_info) <~tui_win_info>: Inline.
7489         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7490         Don't declare.
7491         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7492         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7493         Remove.
7494         (tui_initialize_static_data): Update.
7495         (~tui_gen_win_info): Handle more cleanup here.
7496         (~tui_source_window_base): Delete "execution_info".
7497         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7498
7499 2019-06-25  Tom Tromey  <tom@tromey.com>
7500
7501         * tui/tui-layout.c (make_command_window): Don't set
7502         can_highlight.
7503         (show_source_disasm_command): Call the reset method.
7504         (show_data): Don't set can_highlight.  Call the reset method.
7505         (tui_gen_win_info::reset): Rename from init_gen_win_info
7506         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7507         (show_source_or_disasm_and_command): Call the reset method.
7508         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7509         (struct tui_cmd_window): Set can_highlight.
7510
7511 2019-06-25  Tom Tromey  <tom@tromey.com>
7512
7513         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7514         from make_visible.
7515         (tui_make_visible, tui_make_invisible): Rewrite.
7516         (tui_win_info::make_visible): Remove.
7517         (tui_source_window_base::make_visible): Update.
7518         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7519         method.  Moved from...
7520         (struct tui_win_info) <make_visible>: ...here.
7521
7522 2019-06-25  Tom Tromey  <tom@tromey.com>
7523
7524         * tui/tui-winsource.c
7525         (tui_source_window_base::do_scroll_horizontal): Remove direction
7526         parameter.
7527         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7528         direction parameter.
7529         * tui/tui-win.c (tui_win_info::forward_scroll)
7530         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7531         (tui_win_info::right_scroll): Update.
7532         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7533         direction parameter.
7534         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7535         direction parameter.
7536         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7537         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7538         Remove direction parameter.
7539         (struct tui_source_window_base, struct tui_source_window)
7540         (struct tui_disasm_window, struct tui_data_window)
7541         (struct tui_cmd_window): Update.
7542
7543 2019-06-25  Tom Tromey  <tom@tromey.com>
7544
7545         * tui/tui-winsource.h (tui_set_exec_info_content)
7546         (tui_show_exec_info_content, tui_erase_exec_info_content)
7547         (tui_clear_exec_info_content, tui_update_exec_info): Change
7548         argument to tui_source_window_base.
7549         * tui/tui-winsource.c (tui_set_exec_info_content)
7550         (tui_show_exec_info_content, tui_erase_exec_info_content)
7551         (tui_clear_exec_info_content, tui_update_exec_info): Change
7552         argument to tui_source_window_base.
7553
7554 2019-06-25  Tom Tromey  <tom@tromey.com>
7555
7556         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7557         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7558
7559 2019-06-25  Tom Tromey  <tom@tromey.com>
7560
7561         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7562         check.
7563
7564 2019-06-25  Tom Tromey  <tom@tromey.com>
7565
7566         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7567         type to void.
7568         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7569         type to void.
7570         * tui/tui-source.c (tui_set_source_content): Update.
7571         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7572
7573 2019-06-25  Tom Tromey  <tom@tromey.com>
7574
7575         * tui/tui-win.c (window_name_completer, tui_set_focus)
7576         (tui_all_windows_info): Use name method.
7577         * tui/tui-data.h (struct tui_gen_win_info)
7578         (struct tui_source_window, struct tui_disasm_window)
7579         (struct tui_data_window, struct tui_cmd_window) <name>: New
7580         method.
7581         (tui_win_name): Don't declare.
7582         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7583         (tui_win_name): Remove.
7584
7585 2019-06-25  Tom Tromey  <tom@tromey.com>
7586
7587         * tui/tui-winsource.h (tui_update_source_window)
7588         (tui_update_source_window_as_is): Change parameter type.
7589         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7590         to be a tui_source_window_base.
7591         (tui_update_source_window_as_is): Likewise.
7592         * tui/tui-win.c (make_visible_with_new_height): Update.
7593
7594 2019-06-25  Tom Tromey  <tom@tromey.com>
7595
7596         * tui/tui-winsource.c (tui_erase_source_content)
7597         (tui_show_source_content, tui_show_exec_info_content)
7598         (tui_erase_exec_info_content): Use refresh_window method.
7599         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7600         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7601         from tui_refresh_win.
7602         (tui_data_window::refresh_window): New method.
7603         (tui_win_info::refresh, tui_source_window_base::refresh)
7604         (tui_refresh_all): Use refresh_window method.
7605         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7606         method.
7607         * tui/tui-regs.c (tui_display_register): Call refresh_window
7608         method.
7609         * tui/tui-layout.c (show_source_disasm_command)
7610         (show_source_or_disasm_and_command): Call refresh_window method.
7611         * tui/tui-data.h (struct tui_gen_win_info)
7612         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7613         New method.
7614
7615 2019-06-25  Tom Tromey  <tom@tromey.com>
7616
7617         * tui/tui.c (tui_rl_other_window, tui_enable)
7618         (tui_is_window_visible, tui_get_command_dimension): Update.
7619         * tui/tui-winsource.c (tui_update_source_window_as_is)
7620         (tui_clear_source_content, tui_erase_source_content)
7621         (tui_show_source_line, tui_source_window_base::refill)
7622         (tui_source_window_base::do_scroll_horizontal)
7623         (tui_source_window_base::set_is_exec_point_at)
7624         (tui_update_breakpoint_info, tui_set_exec_info_content)
7625         (tui_alloc_source_buffer, tui_line_is_displayed)
7626         (tui_addr_is_displayed): Update.
7627         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7628         (tui_check_and_display_highlight_if_needed)
7629         (tui_win_info::make_visible, tui_win_info::refresh)
7630         (tui_refresh_all): Update.
7631         * tui/tui-windata.c (tui_first_data_item_displayed)
7632         (tui_delete_data_content_windows, tui_erase_data_content)
7633         (tui_display_all_data, tui_data_window::refresh_all)
7634         (tui_check_data_values): Update.
7635         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7636         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7637         (tui_win_info::backward_scroll, tui_refresh_all_win)
7638         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7639         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7640         (tui_source_window_base::set_new_height)
7641         (tui_data_window::set_new_height)
7642         (make_invisible_and_set_new_height)
7643         (make_visible_with_new_height, new_height_ok)
7644         (parse_scrolling_args): Update.
7645         * tui/tui-stack.c (tui_show_frame_info): Update.
7646         * tui/tui-source.c (tui_set_source_content)
7647         (tui_set_source_content_nil, tui_source_is_displayed)
7648         (tui_source_window::do_scroll_vertical): Update.
7649         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7650         (tui_display_registers_from, tui_display_reg_element_at_line)
7651         (tui_check_register_values, tui_reg_command): Update.
7652         * tui/tui-layout.c (tui_default_win_height)
7653         (show_source_disasm_command, show_data, init_and_make_win)
7654         (show_source_or_disasm_and_command): Update.
7655         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7656         (tui_redisplay_readline, tui_mld_flush)
7657         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7658         (tui_getc): Update.
7659         * tui/tui-disasm.c (tui_set_disassem_content)
7660         (tui_disasm_window::do_scroll_vertical): Update.
7661         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7662         Now virtual.
7663         (struct tui_win_info): Derive from tui_gen_win_info.
7664         <~tui_win_info>: Mark as override.
7665         <generic>: Remove member.
7666         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7667         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7668         (~tui_data_window, ~tui_win_info)
7669         (tui_free_all_source_wins_content): Update.
7670         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7671
7672 2019-06-25  Tom Tromey  <tom@tromey.com>
7673
7674         * tui/tui-layout.c (init_and_make_win): Use new.
7675         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7676         destructor, initializers.
7677         (tui_alloc_generic_win_info): Don't declare.
7678         * tui/tui-data.c (_locator): Add argument to constructor.
7679         (source_win, disasm_win): New globals.
7680         (exec_info): Remove.
7681         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7682         Update.
7683         (tui_alloc_generic_win_info): Remove.
7684         (init_content_element): Use new.
7685         (tui_win_info::tui_win_info): Update.
7686         (free_content_elements) <case DATA_WIN>: Use delete.
7687
7688 2019-06-25  Tom Tromey  <tom@tromey.com>
7689
7690         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7691         * tui/tui-windata.c (tui_first_data_item_displayed)
7692         (tui_delete_data_content_windows): Update.
7693         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7694         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7695         (tui_display_registers_from, tui_check_register_values): Update.
7696         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7697         pointer.
7698         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7699         window.
7700         (tui_free_data_content): Update.
7701         (free_content_elements) <case DATA_WIN>: Free the window.
7702
7703 2019-06-25  Tom Tromey  <tom@tromey.com>
7704
7705         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7706         Update.
7707         * tui/tui-layout.c (make_command_window)
7708         (show_source_disasm_command, show_data, init_and_make_win)
7709         (show_source_or_disasm_and_command): Update.
7710         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7711         method.
7712         <can_highight, is_highlighted>: Now bool.
7713         (tui_set_win_highlight): Don't declare.
7714         * tui/tui-data.c (tui_set_win_highlight): Remove.
7715
7716 2019-06-25  Tom Tromey  <tom@tromey.com>
7717
7718         * tui/tui-wingeneral.c (make_visible): Remove check of window
7719         type.
7720
7721 2019-06-25  Tom Tromey  <tom@tromey.com>
7722
7723         * tui/tui-win.c (tui_win_info::max_height)
7724         (tui_cmd_window::max_height): New methods.
7725         (new_height_ok): Call max_height.
7726         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7727         <max_height>: New method.
7728
7729 2019-06-25  Tom Tromey  <tom@tromey.com>
7730
7731         * tui/tui-win.c (tui_source_window_base::set_new_height)
7732         (tui_data_window::set_new_height): New methods.
7733         (make_invisible_and_set_new_height): Call set_new_height method.
7734         * tui/tui-data.h (struct tui_win_info)
7735         (struct tui_source_window_base, struct tui_data_window)
7736         <set_new_height>: New method.
7737
7738 2019-06-25  Tom Tromey  <tom@tromey.com>
7739
7740         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7741         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7742         tui_refresh_data_win.
7743         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7744         method.
7745         (tui_refresh_all_win): Call the refresh_all method.
7746         (tui_set_focus): Likewise.
7747         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7748         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7749         Likewise.
7750
7751 2019-06-25  Tom Tromey  <tom@tromey.com>
7752
7753         * tui/tui-winsource.h (tui_refill_source_window)
7754         (tui_set_is_exec_point_at): Don't declare.
7755         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7756         (tui_source_window_base::refill): Rename from
7757         tui_refill_source_window.
7758         (tui_source_window_base::do_scroll_horizontal): Update.
7759         (tui_source_window_base::set_is_exec_point_at): Rename from
7760         tui_set_is_exec_point_at.
7761         (tui_update_all_breakpoint_info): Update.
7762         * tui/tui-stack.c (tui_show_frame_info): Update.
7763         * tui/tui-layout.c (show_data): Add cast.
7764         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7765         * tui/tui-data.h (struct tui_source_window_base) <refill,
7766         set_is_exec_point_at>: New methods.
7767         (tui_source_windows, tui_add_to_source_windows): Update types.
7768         (tui_add_to_source_windows): Remove redundant declaration.
7769         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7770         (tui_source_windows): Change return type.
7771         (tui_clear_source_windows_detail): Update.
7772         (tui_add_to_source_windows): Change type of parameter.
7773         (tui_free_all_source_wins_content): Update.
7774
7775 2019-06-25  Tom Tromey  <tom@tromey.com>
7776
7777         * tui/tui-wingeneral.c (tui_win_info::refresh)
7778         (tui_source_window_base::refresh): New methods.
7779         (tui_refresh_all): Call the refresh method.
7780         * tui/tui-data.h (struct tui_win_info)
7781         (struct tui_source_window_base) <refresh>: New method.
7782
7783 2019-06-25  Tom Tromey  <tom@tromey.com>
7784
7785         * tui/tui.h (tui_is_window_visible): Return bool.
7786         * tui/tui.c (tui_is_window_visible): Return bool.
7787         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7788         (tui_make_visible, tui_make_invisible)
7789         (tui_win_info::make_visible)
7790         (tui_source_window_base::make_visible, make_all_visible)
7791         (tui_make_all_visible, tui_make_all_invisible): Update.
7792         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7793         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7794         bool.
7795         (struct tui_win_info, struct tui_source_window_base)
7796         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7797         * tui/tui-data.c (tui_init_generic_part): Update.
7798
7799 2019-06-25  Tom Tromey  <tom@tromey.com>
7800
7801         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7802         (tui_source_window_base::make_visible): New methods.
7803         (make_all_visible): Make method call.
7804         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7805         (struct tui_source_window_base, struct tui_cmd_window): Override
7806         make_visible.
7807         (tui_win_is_source_type): Don't declare.
7808         * tui/tui-data.c (tui_win_is_source_type): Remove.
7809
7810 2019-06-25  Tom Tromey  <tom@tromey.com>
7811
7812         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7813         NULL check.
7814
7815 2019-06-25  Tom Tromey  <tom@tromey.com>
7816
7817         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7818         Inline constructor.  Add initializers for members.
7819         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7820         constructors; now inline in class.
7821
7822 2019-06-25  Tom Tromey  <tom@tromey.com>
7823
7824         * tui/tui-regs.c (tui_show_registers): Update.
7825         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7826         bool.
7827         * tui/tui-data.c (tui_data_window::clear_detail)
7828         (tui_data_window): Update.
7829
7830 2019-06-25  Tom Tromey  <tom@tromey.com>
7831
7832         * tui/tui-windata.c (tui_display_all_data)
7833         (tui_display_data_from_line, tui_display_data_from)
7834         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7835         Update.
7836         * tui/tui-regs.c (tui_last_regs_line_no)
7837         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7838         (tui_show_registers, tui_show_register_group)
7839         (tui_display_registers_from, tui_display_reg_element_at_line)
7840         (tui_display_registers_from_line, tui_check_register_values)
7841         (tui_reg_next, tui_reg_prev): Update.
7842         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7843         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7844         tui_data_window.
7845         (struct tui_win_info) <detail>: Remove.  Add new fields from
7846         tui_data_info.
7847         (TUI_DATA_WIN): Add cast.
7848         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7849         (~tui_data_window): Simplify.
7850
7851 2019-06-25  Tom Tromey  <tom@tromey.com>
7852
7853         * tui/tui-layout.c (show_source_disasm_command)
7854         (show_source_or_disasm_and_command): Update.
7855         * tui/tui-io.c (update_cmdwin_start_line)
7856         (tui_redisplay_readline): Update.
7857         * tui/tui-data.h (struct tui_command_info): Remove.
7858         (struct tui_win_info) <detail>: Remove command_info member.
7859         (struct tui_data_window) <start_line>: New member, from
7860         tui_command_info.
7861         (TUI_CMD_WIN): Add casts.
7862
7863 2019-06-25  Tom Tromey  <tom@tromey.com>
7864
7865         * tui/tui-winsource.c (tui_update_source_window)
7866         (tui_refill_source_window)
7867         (tui_source_window_base::do_scroll_horizontal)
7868         (tui_update_breakpoint_info, tui_set_exec_info_content)
7869         (tui_show_exec_info_content, tui_erase_exec_info_content)
7870         (tui_clear_exec_info_content): Update.
7871         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7872         Update.
7873         * tui/tui-win.c (make_invisible_and_set_new_height)
7874         (make_visible_with_new_height): Update.
7875         * tui/tui-source.c (tui_set_source_content)
7876         (tui_show_symtab_source): Update.
7877         * tui/tui-layout.c (extract_display_start_addr)
7878         (show_source_disasm_command, show_data)
7879         (make_source_or_disasm_window)
7880         (show_source_or_disasm_and_command): Update.
7881         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7882         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7883         "gdbarch".
7884         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7885         to tui_source_window_base.
7886         (struct tui_win_info) <detail>: Remove source_info member.
7887         (struct tui_source_window_base) <has_locator>: Inline.
7888         Move contents from tui_source_info; rename has_locator member to
7889         m_has_locator.
7890         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7891         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7892         header file.
7893         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7894         Simplify.
7895         (tui_free_all_source_wins_content): Cast to
7896         tui_source_window_base.
7897
7898 2019-06-25  Tom Tromey  <tom@tromey.com>
7899
7900         * tui/tui-win.c (make_invisible_and_set_new_height)
7901         (make_visible_with_new_height): Call has_locator method.
7902         * tui/tui-layout.c (show_source_disasm_command, show_data)
7903         (show_source_or_disasm_and_command): Update for bool change.
7904         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7905         (tui_win_info) <has_locator>: New method.
7906         (struct tui_source_window_base) <has_locator>: New method.
7907         (tui_win_has_locator): Don't declare.
7908         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7909         from tui_win_has_locator.
7910         (tui_source_window_base): Use false, not FALSE.
7911
7912 2019-06-25  Tom Tromey  <tom@tromey.com>
7913
7914         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7915         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7916         clear_detail method directly.
7917         (tui_clear_win_detail): Remove.
7918
7919 2019-06-25  Tom Tromey  <tom@tromey.com>
7920
7921         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7922         "this", not TUI_DISASM_WIN.
7923
7924 2019-06-25  Tom Tromey  <tom@tromey.com>
7925
7926         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7927         declare.
7928         * tui/tui-winsource.c
7929         (tui_source_window_base::do_scroll_horizontal): Rename from
7930         tui_horizontal_source_scroll.
7931         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7932         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7933         from tui_vertical_data_scroll.
7934         * tui/tui-win.h (tui_scroll): Don't declare.
7935         * tui/tui-win.c (tui_win_info::forward_scroll)
7936         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7937         (tui_win_info::right_scroll): Rename and update.
7938         (tui_scroll_forward_command, tui_scroll_backward_command)
7939         (tui_scroll_left_command, tui_scroll_right_command): Update.
7940         (tui_scroll): Remove.
7941         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7942         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7943         from tui_vertical_source_scroll.
7944         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7945         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7946         from tui_vertical_disassem_scroll.
7947         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7948         do_scroll_horizontal>: New methods.
7949         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7950         Likewise.
7951         (struct tui_source_window_base): Add do_scroll_horizontal.
7952         (struct tui_source_window, struct tui_disasm_window): Add
7953         do_scroll_vertical.
7954         (struct tui_data_window, struct tui_cmd_window): Add
7955         do_scroll_horizontal and do_scroll_vertical.
7956         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7957
7958 2019-06-25  Tom Tromey  <tom@tromey.com>
7959
7960         * tui/tui-data.h (struct tui_source_window_base): New struct.
7961         (struct tui_source_window): Derive from tui_source_window_base.
7962         (struct tui_disasm_window): New struct.
7963         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7964         from tui_source_window::clear_detail.
7965         (tui_source_window_base): Rename from tui_source_window.
7966         (~tui_source_window_base): Rename from ~tui_source_window.
7967         (tui_alloc_win_info): Create a tui_disasm_window.
7968
7969 2019-06-25  Tom Tromey  <tom@tromey.com>
7970
7971         * tui/tui-data.h (struct tui_source_window)
7972         (struct tui_data_window): Declare destructors.
7973         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7974         destructors.
7975         (tui_win_info): Simplify.
7976
7977 2019-06-25  Tom Tromey  <tom@tromey.com>
7978
7979         * tui/tui-winsource.c (tui_display_main)
7980         (tui_update_source_windows_with_addr)
7981         (tui_update_all_breakpoint_info): Update.
7982         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7983         (new_height_ok, parse_scrolling_args): Update.
7984         * tui/tui-stack.c (tui_show_frame_info): Update.
7985         * tui/tui-data.h (struct tui_list): Remove.
7986         (tui_source_windows): Return a reference to a std::vector.
7987         * tui/tui-data.c (source_windows): Now a std::vector.
7988         (tui_source_windows): Change return type.
7989         (tui_clear_source_windows): Rewrite.
7990         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7991         (tui_free_all_source_wins_content): Rewrite.
7992
7993 2019-06-25  Tom Tromey  <tom@tromey.com>
7994
7995         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7996         (struct tui_data_window, struct tui_cmd_window): Declare
7997         clear_detail method.
7998         * tui/tui-data.c (tui_source_window::clear_detail)
7999         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8000         methods.
8001         (tui_clear_win_detail): Simplify.
8002
8003 2019-06-25  Tom Tromey  <tom@tromey.com>
8004
8005         * tui/tui-layout.c (make_source_window, make_disasm_window)
8006         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8007         Return the new window.
8008         (show_source_disasm_command, show_data)
8009         (show_source_or_disasm_and_command): Update.
8010
8011 2019-06-25  Tom Tromey  <tom@tromey.com>
8012
8013         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8014         parameter.  Return the new window.
8015         (show_source_disasm_command): Update and remove NULL check.
8016         (show_source_or_disasm_and_command): Update.
8017
8018 2019-06-25  Tom Tromey  <tom@tromey.com>
8019
8020         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8021
8022 2019-06-25  Tom Tromey  <tom@tromey.com>
8023
8024         * tui/tui-data.h (struct tui_win_info): Make constructor
8025         protected.  Make destructor virtual.  Add initializers.
8026         (tui_source_window, tui_data_window, tui_cmd_window): New
8027         classes.
8028         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8029         constructor.  Add "type" parameter.
8030         (tui_source_window, tui_data_window, tui_cmd_window): New
8031         constructors.
8032         (tui_alloc_win_info): Instantiate the appropriate subclass.
8033
8034 2019-06-25  Tom Tromey  <tom@tromey.com>
8035
8036         * tui/tui-win.c (tui_resize_all): Use delete.
8037         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8038         destructor.
8039         (tui_free_window): Don't declare.
8040         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8041         Update.
8042
8043 2019-06-25  Tom Tromey  <tom@tromey.com>
8044
8045         * tui/tui-data.h (struct tui_win_info): Add constructor.
8046         * tui/tui-data.c (tui_alloc_win_info): Use new.
8047         (tui_free_window): Use delete.
8048
8049 2019-06-22  Tom Tromey  <tom@tromey.com>
8050
8051         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8052         declare.
8053         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8054
8055 2019-06-22  Tom Tromey  <tom@tromey.com>
8056
8057         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8058         declare.
8059         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8060
8061 2019-06-22  Tom de Vries  <tdevries@suse.de>
8062
8063         * dwarf2read.c (create_addrmap_from_aranges)
8064         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8065         instead of '%zu'.
8066
8067 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8068
8069         * dwarf2read.h (dwarf2_section_info_def): Remove.
8070         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8071         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8072         std::vector<dwarf2_section_info>.
8073         (struct dwo_file) <~dwo_file>: Remove.
8074         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8075         types field.
8076         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8077         (dwarf2_read_debug_names): Likewise.
8078         (create_debug_types_hash_table): Change parameter type to
8079         array_view, adjust code accordingly.
8080         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8081         (partial_die_info::fixup): Likewise.
8082         (determine_prefix): Likewise.
8083         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8084
8085 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8086
8087         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8088         gdb_bfd_ref_ptr.
8089         <~dwo_file>: Remove call to gdb_bfd_unref.
8090         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8091         gdb_bfd_ref_ptr::get.
8092
8093 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8094
8095         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8096         type to htab_up.
8097         * dwarf2read.c (struct dwo_file): Initialize fields.
8098         <~dwo_file>: New.
8099         (free_dwo_file): Remove, move content to ~dwo_file.
8100         (struct dwo_file_deleter): Remove.
8101         (dwo_file_up>: Remove custom deleter.
8102         (free_dwo_files): Remove.
8103         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8104         dwo_files.
8105         (process_skeletonless_type_units): Call unique_ptr::get.
8106         (allocate_dwo_file_hash_table): Add deleter to created hash
8107         table.  Change return type to htab_up.
8108         (lookup_dwo_file_slot): Don't memset dwo_file, call
8109         unique_ptr::get.
8110         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8111         (create_dwo_unit_in_dwp_v2): Likewise.
8112         (open_and_init_dwo_file): Likewise.
8113         (free_dwo_file_from_slot): Remove.
8114
8115 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8116
8117         * dwarf2read.h (struct dwarf2_section_info) <readin,
8118         is_virtual>: Change type to bool.
8119         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8120         true instead of 1.
8121
8122 2019-06-19  Tom Tromey  <tom@tromey.com>
8123
8124         * tui/tui-data.h (tui_init_content_element): Don't declare.
8125
8126 2019-06-19  Tom Tromey  <tom@tromey.com>
8127
8128         * tui/tui-data.h (tui_init_win_info): Don't declare.
8129
8130 2019-06-19  Tom de Vries  <tdevries@suse.de>
8131
8132         * dwarf2read.h (abstract_to_concrete): Change type to
8133         std::unordered_map<sect_offset, std::vector<sect_offset>,
8134         gdb::hash_enum<sect_offset>>.
8135
8136 2019-06-19  Tom Tromey  <tromey@adacore.com>
8137
8138         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8139         EVAL_AVOID_SIDE_EFFECTS specially.
8140
8141 2019-06-19  Tom Tromey  <tromey@adacore.com>
8142
8143         * source-cache.c (highlighter): New global.
8144         (source_cache::get_source_lines): Create a highlighter on demand.
8145
8146 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * defs.h (deprecated_interactive_hook): Delete declaration.
8149         * interps.c (clear_interpreter_hooks): Remove use of
8150         deprecated_interactive_hook.
8151         * top.c (deprecated_interactive_hook): Delete definition.
8152         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8153
8154 2019-06-18  Tom de Vries  <tdevries@suse.de>
8155
8156         PR gdb/24515
8157         * dwarf2read.h (abstract_to_concrete): Change type from
8158         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8159         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8160         * dwarf2read.c (read_variable): Update.
8161         (dwarf2_fetch_die_loc_sect_off): Update.
8162
8163 2019-06-17  Tom de Vries  <tdevries@suse.de>
8164
8165         PR gdb/24617
8166         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8167         accessing parent[parent_len - 1].
8168
8169 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8170
8171         PR gdb/24364
8172         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8173         call dtrace_process_dof with NULL dof.
8174
8175 2019-06-16  Tom de Vries  <tdevries@suse.de>
8176
8177         PR gdb/24445
8178         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8179
8180 2019-06-16  Tom Tromey  <tom@tromey.com>
8181
8182         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8183         (make_all_visible): Use address of member.
8184
8185 2019-06-16  Tom Tromey  <tom@tromey.com>
8186
8187         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8188         (tui_free_window, free_content, free_content_elements): Remove
8189         unnecessary cast.
8190         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8191         cast.
8192         * tui/tui-regs.c (tui_show_register_group)
8193         (tui_display_registers_from, tui_display_reg_element_at_line):
8194         Remove unnecessary cast.
8195
8196 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8197
8198         * linux-nat.c (normal_mask): Delete.
8199         (_initialize_linux_nat): Don't initialise normal_mask.
8200
8201 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8202
8203         PR gdb/24445
8204         * dwarf-index-write.h (write_psymtabs_to_index): Add
8205         dwz_basename parameter.
8206         * dwarf-index-write.c (write_gdbindex): Move file writing to
8207         write_gdbindex_1.  Change return type void.
8208         (assert_file_size): Move up, remove filename parameter.
8209         (write_gdbindex_1): New function.
8210         (write_debug_names): Change return type to void, call
8211         assert_file_size.
8212         (struct index_wip_file): New struct.
8213         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8214         file logic to index_wip_file.  Write index for dwz file if
8215         needed.
8216         (save_gdb_index_command): Pass basename of dwz file, if present.
8217         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8218         build-id of dwz file, if present.
8219         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8220         (dwarf2_get_dwz_file): Likewise.
8221         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8222         (dwarf2_get_dwz_file): Likewise.
8223
8224 2019-06-16  Tom Tromey  <tom@tromey.com>
8225
8226         * coffread.c (process_coff_symbol): Use xstrdup.
8227         * value.c (create_internalvar): Use xstrdup.
8228
8229 2019-06-16  Tom Tromey  <tom@tromey.com>
8230
8231         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8232         * breakpoint.c (stopin_command, stopat_command)
8233         (until_break_command, decode_location_default): Remove unnecessary
8234         cast.
8235         * utils.c (subset_compare): Remove unnecessary cast.
8236         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8237         cast.
8238         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8239         cast.
8240         * infcmd.c (path_command): Remove unnecessary cast.
8241         * coffread.c (decode_type): Remove unnecessary cast.
8242         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8243         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8244         * tui/tui-stack.c (tui_show_locator_content)
8245         (tui_show_frame_info): Remove unnecessary cast.
8246         * tui/tui-win.c (tui_scroll_forward_command)
8247         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8248         (parse_scrolling_args): Remove unnecessary cast.
8249         * tui/tui-data.c (init_win_info, tui_del_window)
8250         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8251         (free_content_elements): Remove unnecessary cast.
8252         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8253         unnecessary cast.
8254         * tui/tui-source.c (tui_set_source_content)
8255         (tui_vertical_source_scroll): Remove unnecessary cast.
8256         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8257         cast.
8258         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8259         * tui/tui-regs.c (tui_display_registers_from)
8260         (tui_display_register): Remove unnecessary cast.
8261         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8262         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8263         (make_visible): Remove unnecessary cast.
8264         * tui/tui-winsource.c (tui_erase_source_content)
8265         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8266         unnecessary cast.
8267         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8268         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8269         * stabsread.c (read_type, read_array_type, read_range_type):
8270         Remove unnecessary cast.
8271         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8272         (parse_symbol, parse_type, upgrade_type, parse_external)
8273         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8274         unnecessary cast.
8275         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8276
8277 2019-06-16  Tom Tromey  <tom@tromey.com>
8278
8279         * tui/tui-data.c (tui_alloc_generic_win_info)
8280         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8281         checks.
8282
8283 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8284             Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * f-typeprint.c (f_print_type): Don't return early for not
8287         associated or not allocated types.
8288         (f_type_print_varspec_suffix): Add print_rank parameter and print
8289         ranks of array types in case they dangling.
8290         (f_type_print_base): Add print_rank parameter.
8291
8292 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * NEWS: Mention new MI commands.
8295         * break-catch-throw.c (enum exception_event_kind): Move to
8296         breakpoint.h.
8297         (print_mention_exception_catchpoint): Output text as a single
8298         message.
8299         (catch_exception_command_1): Rename to...
8300         (catch_exception_event): ...this, make non-static, update header
8301         command, and change some parameter types.
8302         (catch_catch_command): Update for changes to
8303         catch_exception_command_1.
8304         (catch_throw_command): Likewise.
8305         (catch_rethrow_command): Likewise.
8306         * breakpoint.c (enum exception_event_kind): Delete.
8307         * breakpoint.h (enum exception_event_kind): Moved here from
8308         break-catch-throw.c.
8309         (catch_exception_event): Declare.
8310         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8311         (mi_cmd_catch_throw): New function.
8312         (mi_cmd_catch_rethrow): New function.
8313         (mi_cmd_catch_catch): New function.
8314         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8315         'catch-catch' entries.
8316         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8317         (mi_cmd_catch_rethrow): Declare.
8318         (mi_cmd_catch_catch): Declare.
8319
8320 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8321
8322         * annotate.c (annotate_source_line): Change return type to void,
8323         update implementation to match.
8324         * annotate.h (annotate_source_line): Change return type to void,
8325         update header comment.
8326         * stack.c (print_frame_info): Don't change what frame information
8327         is printed based on whether annotations are on or not.
8328
8329 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8330
8331         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8332         (annotate_source): Make static.
8333         (annotate_source_line): Moved from source.c and renamed from
8334         identify_source_line.  Update the return type.
8335         * annotate.h (annotate_source): Delete declaration.
8336         (annotate_source_line): Declaration moved from source.h, and
8337         renamed from identify_source_line.  Return type updated.
8338         * source.c (identify_source_line): Moved to annotate.c and renamed
8339         to annotate_source_line.
8340         (info_line_command): Remove check of annotation_level.
8341         * source.h (identify_source_line): Move declaration to annotate.h
8342         and rename to annotate_source_line.
8343         * stack.c: Add 'annotate.h' include.
8344         (print_frame_info): Remove check of annotation_level before
8345         calling annotate_source_line.
8346
8347 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * source-cache.c (source_cache::get_plain_source_lines): Use
8350         open_source_file_with_line_charpos instead of just
8351         open_source_file, remove call to find_source_lines.
8352         (source_cache::get_source_lines): Likewise.
8353         * source.c (find_source_lines): Make static.
8354         (get_filename_and_charpos): Renamed into...
8355         (open_source_file_with_line_charpos): ..this along with changes to
8356         return a scoped_fd, and some other minor clean ups.
8357         (identify_source_line): Use open_source_file_with_line_charpos.
8358         (search_command_helper): Use open_source_file_with_line_charpos
8359         instead of just open_source_file, remove call to
8360         find_source_lines.
8361         * source.h (open_source_file_with_line_charpos): Declare new
8362         function.
8363         (find_source_lines): Delete declaration.
8364
8365 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8366
8367         * source.c (get_filename_and_charpos): Remove fullname
8368         parameter.
8369         (identify_source_line): Update call to get_filename_and_charpos.
8370
8371 2019-06-14  Tom Tromey  <tromey@adacore.com>
8372
8373         PR gdb/24502:
8374         * ui-style.h (skip_ansi_escape): Update comment.
8375         * ui-file.h (class no_terminal_escape_file): New class.
8376         * ui-file.c (no_terminal_escape_file::write)
8377         (no_terminal_escape_file::puts): New methods.
8378         * cli/cli-logging.c (handle_redirections): Use
8379         no_terminal_escape_file.
8380
8381 2019-06-14  Tom Tromey  <tromey@adacore.com>
8382
8383         * NEWS: Move convenience variable news above Python news.
8384
8385 2019-06-14  Tom Tromey  <tom@tromey.com>
8386
8387         * gnulib: Move directory to top-level.
8388         * configure.ac: Don't configure gnulib.
8389         * configure: Rebuild.
8390         * common/common-defs.h: Use new path to gnulib.
8391         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8392         (GNULIB_H): Remove.
8393         (INCGNU): Look in new gnulib location.
8394         (HFILES_NO_SRCDIR): Remove gnulib files.
8395         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8396         (generated_files): Remove GNULIB_H.
8397         ($(LIBGNU), all-lib): Remove targets.
8398         (distclean): Don't mention GNULIB_BUILDDIR.
8399         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8400
8401 2019-06-14  Tom Tromey  <tromey@adacore.com>
8402
8403         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8404         Warn if symbol file does not provide any symbols.
8405
8406 2019-06-14  Tom Tromey  <tromey@adacore.com>
8407
8408         * source.c (find_and_open_source): Respect basenames_may_differ.
8409
8410 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * annotate.c (annotate_breakpoints_invalid): Make use of
8413         scoped_restore_terminal_state.
8414         (annotate_frames_invalid): Likewise.
8415
8416 2019-06-14  Tom Tromey  <tromey@adacore.com>
8417
8418         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8419         allow assignment to an internalvar.
8420
8421 2019-06-14  Tom Tromey  <tromey@adacore.com>
8422
8423         * ada-lex.l: Allow "_" in attribute names.
8424
8425 2019-06-14  Tom Tromey  <tromey@adacore.com>
8426
8427         PR gdb/24653:
8428         * regcache.c (registers_changed): Don't call alloca.
8429         * top.c (execute_command): Don't call alloca.
8430
8431 2019-06-13  Pedro Alves  <palves@redhat.com>
8432
8433         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8434         'expression'.  When parsing an expression, error out if there's
8435         junk after "unlimited".
8436         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8437         (do_set_command): Adjust calls to is_unlimited_literal.
8438
8439 2019-06-13  Pedro Alves  <palves@redhat.com>
8440
8441         * compile/compile.c (make_compile_options_def_group): Add braces
8442         around array_view initializer.
8443         * thread.c (make_thread_apply_all_options_def_group)
8444         (make_thread_apply_all_options_def_group): Likewise.
8445
8446 2019-06-13  Pedro Alves  <palves@redhat.com>
8447
8448         * NEWS (New commands): Mention "maint test-options
8449         require-delimiter", "maint test-options unknown-is-error", "maint
8450         test-options unknown-is-operand" and "maint show
8451         test-options-completion-result".
8452         (New command options, command completion): New section.
8453         (Completion improvements): New section.
8454         Mention that you can abbreviate "unlimited".
8455
8456 2019-06-13  Pedro Alves  <palves@redhat.com>
8457
8458         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8459         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8460         * unittests/cli-utils-selftests.c (test_parse_flags)
8461         (test_parse_flags_qcs): Delete.
8462         (test_cli_utils): Don't call deleted functions.
8463
8464 2019-06-13  Pedro Alves  <palves@redhat.com>
8465
8466         * thread.c: Include "cli/cli-option.h".
8467         (tp_array_compar_ascending): Global.
8468         (tp_array_compar): Delete function.
8469         (tp_array_compar_ascending, tp_array_compar_descending): New
8470         functions.
8471         (ascending_option_def, qcs_flag_option_def)
8472         (thr_qcs_flags_option_defs)
8473         (make_thread_apply_all_options_def_group)
8474         (make_thread_apply_options_def_group): New.
8475         (thread_apply_all_command): Use gdb::option::process_options.
8476         (thread_apply_command_completer)
8477         (thread_apply_all_command_completer): New.
8478         (thread_apply_command): Use gdb::option::process_options.
8479         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8480         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8481         to generate help text of "thread apply".  Adjust "taas"'s help.
8482         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8483         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8484
8485 2019-06-13  Pedro Alves  <palves@redhat.com>
8486
8487         * thread.c (thread_apply_command): Check for invalid TID with
8488         isdigit instead of !isalpha.
8489
8490 2019-06-13  Pedro Alves  <palves@redhat.com>
8491
8492         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8493         (validate_flags_qcs): New.
8494         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8495         (validate_flags_qcs): Declare.
8496         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8497         (make_frame_apply_options_def_group): New.
8498         (frame_apply_command_count): Process options with
8499         gdb::option::process_options.
8500         (frame_apply_completer): New.
8501         (frame_apply_level_completer, frame_apply_all_completer)
8502         (frame_apply_completer): New.
8503         (_initialize_stack): Update help of "frame apply", "frame apply
8504         level", "frame apply all" and "faas" to mention supported options
8505         and install command completers.
8506         * stack.h (frame_apply_all_completer): Declare.
8507         * thread.c: Include "stack.h".
8508         (tfaas_command): Add "--".
8509         (_initialize_thread): Update help "tfaas" to mention supported
8510         options and install command completer.
8511
8512 2019-06-13  Pedro Alves  <palves@redhat.com>
8513
8514         * completer.c (complete_nested_command_line): New.
8515         (gdb_completion_word_break_characters_throw): Add assertion.
8516         * completer.h (complete_nested_command_line): Declare.
8517
8518 2019-06-13  Pedro Alves  <palves@redhat.com>
8519
8520         * stack.c (parse_backtrace_qualifiers): New.
8521         (backtrace_command): Use it.
8522         (backtrace_command_completer): Complete on qualifiers.
8523
8524 2019-06-13  Pedro Alves  <palves@redhat.com>
8525
8526         * frame.c: Include "cli/cli-option.h.
8527         (user_set_backtrace_options): New.
8528         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8529         Delete.
8530         (get_prev_frame): Adjust.
8531         (boolean_option_def, uinteger_option_def)
8532         (set_backtrace_option_defs): New.
8533         (_initialize_frame): Adjust and use
8534         gdb::option::add_setshow_cmds_for_options to install "set
8535         backtrace past-main" and "set backtrace past-entry".
8536         * frame.h: Include "cli/cli-option.h".
8537         (struct frame_print_options): Forward declare.
8538         (print_frame_arguments_all, print_frame_arguments_scalars)
8539         (print_frame_arguments_none): Declare.
8540         (print_entry_values): Delete declaration.
8541         (struct frame_print_options, user_frame_print_options): New.
8542         (struct set_backtrace_options): New.
8543         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8544         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8545         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8546         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8547         (list_args_or_locals): Add frame_print_options parameter.
8548         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8549         * python/py-framefilter.c (enumerate_args): Pass down
8550         USER_FRAME_PRINT_OPTIONS.
8551         * stack.c: Include "cli/cli-option.h".
8552         (print_frame_arguments_all, print_frame_arguments_scalars)
8553         (print_frame_arguments_none): Declare.
8554         (print_raw_frame_arguments, print_entry_values): Delete.
8555         (user_frame_print_options): New.
8556         (boolean_option_def, enum_option_def, frame_print_option_defs):
8557         New.
8558         (struct backtrace_cmd_options): New.
8559         (bt_flag_option_def): New.
8560         (backtrace_command_option_defs): New.
8561         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8562         (print_frame_arg, read_frame_arg, print_frame_args)
8563         (print_frame_info, print_frame): Add frame_print_options parameter
8564         and use it.
8565         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8566         (backtrace_command_1): Add frame_print_options and
8567         backtrace_cmd_options parameters and use them.
8568         (make_backtrace_options_def_group): New.
8569         (backtrace_command): Process command options with
8570         gdb::option::process_options.
8571         (backtrace_command_completer): New.
8572         (_initialize_stack): Extend "backtrace"'s help to mention
8573         supported options.  Install completer for "backtrace".
8574         Install some settings commands with add_setshow_cmds_for_options.
8575
8576 2019-06-13  Pedro Alves  <palves@redhat.com>
8577
8578         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8579         and that "set/show print raw frame-arguments" are now deprecated.
8580
8581         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8582         command.
8583         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8584         * stack.c (_initialize_stack): Install "set/show print
8585         raw-frame-arguments", and deprecate "set/show print raw
8586         frame-arguments".
8587         * valprint.c (_initialize_valprint): Deprecate "set/show print
8588         raw".
8589
8590 2019-06-13  Pedro Alves  <palves@redhat.com>
8591
8592         * compile/compile.c (struct compile_options): New.
8593         (compile_flag_option_def, compile_command_option_defs)
8594         (make_compile_options_def_group): New.
8595         (compile_file_command): Handle options with
8596         gdb::option::process_options.
8597         (compile_file_command_completer): New function.
8598         (compile_code_command): Handle options with
8599         gdb::option::process_options.
8600         (compile_code_command_completer): New function.
8601         (_initialize_compiler): Install completers for "compile code" and
8602         "compile file".  Mention available options in "compile code" and
8603         "compile code"'s help.
8604         * completer.c (advance_to_completion_word): New, factored out from
8605         ...
8606         (advance_to_expression_complete_word_point): ... this.
8607         (advance_to_filename_complete_word_point): New.
8608         * completer.h (advance_to_filename_complete_word_point): New
8609         declaration.
8610
8611 2019-06-13  Pedro Alves  <palves@redhat.com>
8612
8613         * compile/compile.c: Include "cli/cli-option.h".
8614         (compile_print_value): Scope data pointer is now a
8615         value_print_options pointer; adjust.
8616         (compile_print_command): Process options.  Scope data pointer is
8617         now a value_print_options pointer; adjust.
8618         (_initialize_compile): Update "compile print"'s help to include
8619         supported options.  Install a completer for "compile print".
8620         * cp-valprint.c (show_vtblprint, show_objectprint)
8621         (show_static_field_print): Delete.
8622         (_initialize_cp_valprint): Don't install "set print
8623         static-members", "set print vtbl", "set print object" here.
8624         * printcmd.c: Include "cli/cli-option.h" and
8625         "common/gdb_optional.h".
8626         (print_command_parse_format): Rework to fill in a
8627         value_print_options instead of a format_data.
8628         (print_value): Change parameter type from format_data pointer to
8629         value_print_options reference.  Adjust.
8630         (print_command_1): Process options.  Adjust to pass down a
8631         value_print_options.
8632         (print_command_completer): New.
8633         (_initialize_printcmd): Install print_command_completer as
8634         handle_brkchars completer for the "print" command.  Update
8635         "print"'s help to include supported options.
8636         * valprint.c: Include "cli/cli-option.h".
8637         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8638         here from cp-valprint.c.
8639         (boolean_option_def, uinteger_option_def)
8640         (value_print_option_defs, make_value_print_options_def_group):
8641         New.  Use gdb::option::add_setshow_cmds_for_options to install
8642         "set print elements", "set print null-stop", "set print repeats",
8643         "set print pretty", "set print union", "set print array", "set
8644         print address", "set print symbol", "set print array-indexes".
8645         * valprint.h: Include <string> and "cli/cli-option.h".
8646         (make_value_print_options_def_group): Declare.
8647         (print_value): Change parameter type from format_data pointer to
8648         value_print_options reference.
8649         (print_command_completer): Declare.
8650
8651 2019-06-13  Pedro Alves  <palves@redhat.com>
8652
8653         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8654         (COMMON_SFILES): Add maint-test-settings.c.
8655         * cli/cli-decode.c (boolean_enums): New global, factored out from
8656         ...
8657         (add_setshow_boolean_cmd): ... here.
8658         * cli/cli-decode.h (boolean_enums): Declare.
8659         * cli/cli-option.c: New file.
8660         * cli/cli-option.h: New file.
8661         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8662         factored out from ...
8663         (parse_cli_boolean_value(const char *)): ... this.
8664         (is_unlimited_literal): Change parameter type to pointer to
8665         pointer.  Adjust and advance ARG pointer.
8666         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8667         (parse_cli_var_enum): New, factored out from ...
8668         (do_set_command): ... this.  Adjust.
8669         * cli/cli-setshow.h (parse_cli_boolean_value)
8670         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8671         (parse_cli_var_enum): Declare.
8672         * cli/cli-utils.c: Include "cli/cli-option.h".
8673         (get_ulongest): New.
8674         * cli/cli-utils.h (get_ulongest): Declare.
8675         (check_for_argument): New overloads.
8676         * maint-test-options.c: New file.
8677
8678 2019-06-13  Pedro Alves  <palves@redhat.com>
8679
8680         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8681         parse a range if "-" is at the end of the string.
8682
8683 2019-06-13  Pedro Alves  <palves@redhat.com>
8684
8685         * cli/cli-setshow.c (parse_auto_binary_operation)
8686         (parse_cli_boolean_value): Don't allow "o".
8687
8688 2019-06-13  Pedro Alves  <palves@redhat.com>
8689
8690         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8691         * NEWS: Mention maint test-settings KIND.
8692         * maint-test-settings.c: New file.
8693
8694 2019-06-13  Pedro Alves  <palves@redhat.com>
8695
8696         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8697         completer.
8698         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8699         "set" completers.
8700
8701 2019-06-13  Pedro Alves  <palves@redhat.com>
8702
8703         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8704         after item.
8705
8706 2019-06-13  Pedro Alves  <palves@redhat.com>
8707
8708         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8709
8710 2019-06-13  Pedro Alves <palves@redhat.com>
8711
8712         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8713         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8714         call.
8715         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8716         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8717         calls.
8718         (check_for_argument): Skip spaces after argument.
8719
8720 2019-06-13  Pedro Alves  <palves@redhat.com>
8721
8722         * thread.c (thread_apply_command): Adjust TID parsing.
8723         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8724         detected before end of string.
8725         (tid_is_in_list): Error out if LIST is invalid.
8726
8727 2019-06-13  Pedro Alves  <palves@redhat.com>
8728
8729         * completer.c (complete_line_internal_1): Rewind completion word
8730         point.
8731         (completion_tracker::advance_custom_word_point_by): Change
8732         parameter type to int.
8733         * completer.h (completion_tracker::advance_custom_word_point_by):
8734         Likewise.
8735
8736 2019-06-13  Pedro Alves  <palves@redhat.com>
8737
8738         * completer.c (advance_to_completion_word): Handle delimiters.
8739
8740 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8741
8742         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8743
8744 2019-06-11  Tom Tromey  <tom@tromey.com>
8745
8746         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8747         (xmalloc_failed): Move to alloc.c.
8748         * alloc.c: New file.
8749         * Makefile.in (COMMON_SFILES): Add alloc.c.
8750
8751 2019-06-11  Tom Tromey  <tom@tromey.com>
8752
8753         * nat/linux-waitpid.c: Don't include server.h.
8754         (linux_debug): Remove.
8755         (my_waitpid): Update.
8756
8757 2019-06-11  Tom Tromey  <tromey@adacore.com>
8758
8759         * infcall.c (_initialize_infcall): Remove trailing newline from
8760         help.
8761         * user-regs.c (_initialize_user_regs): Remove trailing newline
8762         from help.
8763         * typeprint.c (_initialize_typeprint): Remove trailing newline
8764         from help.
8765         * reverse.c (_initialize_reverse): Remove trailing newlines from
8766         help.
8767         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8768         from help.
8769         * language.c (add_set_language_command): Remove trailing newline
8770         from help.
8771         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8772         help.
8773         * disasm.c (_initialize_disasm): Remove trailing newline from
8774         help.
8775         * top.c (init_main): Remove trailing newline from help.
8776         * interps.c (_initialize_interpreter): Remove trailing newline
8777         from help.
8778         * btrace.c (_initialize_btrace): Remove trailing newlines from
8779         help.
8780         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8781         from help.
8782         * python/python.c (_initialize_python): Remove trailing newline
8783         from help.
8784         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8785         help.
8786         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8787         from help.  Reformat some text.
8788         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8789         from help.
8790         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8791         newline from help.
8792
8793 2019-06-11  Tom Tromey  <tromey@adacore.com>
8794
8795         * darwin-nat.c (darwin_decode_exception_message)
8796         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8797
8798 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8799
8800         * valops.c (value_slice): Check for not allocated or not
8801         associated values.
8802
8803 2019-06-10  Tom de Vries  <tdevries@suse.de>
8804
8805         PR gdb/24618
8806         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8807         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8808         invalid.
8809
8810 2019-06-10  Tom de Vries  <tdevries@suse.de>
8811
8812         PR gdb/24611
8813         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8814         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8815
8816 2019-06-10  Tom de Vries  <tdevries@suse.de>
8817
8818         PR symtab/24545
8819         * symtab.c (struct demangled_name_entry): Add language field.
8820         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8821         static minimal symbol".  Set and use language field.
8822
8823 2019-06-10  Tom Tromey  <tromey@adacore.com>
8824
8825         * ada-lang.c (_initialize_ada_language): Update help text.
8826
8827 2019-06-10  Tom Tromey  <tromey@adacore.com>
8828
8829         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8830         with a newline.
8831         * guile/guile.c (handle_boot_error): Don't end warning with a
8832         newline.
8833         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8834         warning with a newline.
8835         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8836         newline.
8837         (s12z_frame_cache): Likewise.
8838         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8839         a newline.
8840         * solib-svr4.c (disable_probes_interface): Don't end warning with
8841         a newline.
8842         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8843         newline.
8844         * python/python.c (do_finish_initialization): Don't end warning
8845         with a newline.
8846
8847 2019-06-10  Tom Tromey  <tom@tromey.com>
8848
8849         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8850         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8851         gdbpy_enter.
8852
8853 2019-06-10  Tom Tromey  <tromey@adacore.com>
8854
8855         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8856         data.
8857         (elf_new_init): Don't call stabsread_new_init.
8858         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8859         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8860         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8861
8862 2019-06-10  Tom de Vries  <tdevries@suse.de>
8863
8864         PR symtab/16264
8865         PR symtab/24517
8866         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8867
8868 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8869
8870         * source.c (find_and_open_source): Also rewrite relative file
8871         names.
8872
8873 2019-04-26  Amos Bird  <amosbird@gmail.com>
8874
8875         * annotate.c (annotate_thread_exited): Add "thread-exited"
8876         annotation.
8877
8878 2019-06-06  Tom Tromey  <tromey@adacore.com>
8879
8880         * maint.h (class scoped_command_stats): Use
8881         DISABLE_COPY_AND_ASSIGN.
8882         <print_time>: New method.
8883         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8884         print_time.
8885         (scoped_command_stats::print_time): New method.
8886
8887 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8888
8889         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8890         instructions of lengths 6 or 8 bytes.
8891
8892 2019-06-04  Pedro Alves  <palves@redhat.com>
8893
8894         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8895
8896         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8897         * breakpoint.c (condition_completer): Likewise.
8898         * cli/cli-dump.c (scan_expression): Likewise.
8899         * common/filestuff.c (mkdir_recursive): Likewise.
8900         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8901         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8902         (gdb_abspath): Likewise.
8903         * compile/compile-cplus-types.c
8904         (compile_cplus_instance::decl_name): Likewise.
8905         * completer.c (complete_explicit_location):
8906         (signal_completer, reg_or_group_completer_1): Likewise.
8907         * cp-support.c (cp_remove_params_if_any): Likewise.
8908         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8909         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8910         * infcmd.c (strip_bg_char): Likewise.
8911         * linespec.c (copy_token_string): Likewise.
8912         * mi/mi-main.c (output_cores): Likewise.
8913         * psymtab.c (psymtab_search_name):
8914         * symfile.c (test_set_ext_lang_command): Likewise.
8915         * target.c (target_fileio_read_stralloc): Likewise.
8916         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8917         * value.c (complete_internalvar): Likewise.
8918
8919 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8920
8921         Add objfile property to gdb.Type.
8922         * NEWS: Mention Python API addition.
8923         * python/py-type.c (typy_get_objfile): New method.
8924
8925 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8926
8927         * NEWS: Mention the new set|show style [title|highlight].
8928         Mention changes to "show style", "help" and "apropos".
8929
8930 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8931
8932         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8933         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8934         instead of print_help_for_command.
8935         (print_doc_of_command): New function.
8936         (help_list): Add 'apropos -v word' suggestion.
8937         (print_help_for_command): Style the command name using title style.
8938         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8939         (_initialize_cli_cmds): Describe -v in apropos_command help.
8940
8941 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8942
8943         * cli/cli-style.h (cli_style_option): Add name in constructor,
8944         add m_name class member, add constructor with intensity,
8945         add name class function.
8946         (cli_style_option::add_setshow_commands): Remove name argument.
8947         (highlight_style, title_style): New styles.
8948         * cli/cli-style.c (do_show): New function that shows a style
8949         characteristic styling the style name with itself.
8950         (set_style_name): New function.
8951         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8952         Update all callers according to the changes in cli/cli-style.h.
8953         * utils.h (fputs_highlighted): New function.
8954         * utils.c (fputs_highlighted): Likewise.
8955
8956 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8957
8958         * NEWS: Mention new pipe command and new convenience variables.
8959
8960 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8961
8962         * cli/cli-cmds.c (pipe_command): New function.
8963         (_initialize_cli_cmds): Call add_com for pipe_command.
8964         Define | as an alias for pipe.
8965         (exit_status_set_internal_vars): New function.
8966         (shell_escape): Call exit_status_set_internal_vars.
8967         cli/cli-decode.c (find_command_name_length): Recognize | as
8968         a single character command.
8969
8970 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8971
8972         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8973         top.c (execute_command_to_ui_file): New function, mostly a copy
8974         of execute_command_to_string.
8975         (execute_command_to_string): Implement by calling
8976         execute_command_to_ui_file.
8977
8978 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8979
8980         * top.h (saved_command_line): Remove declaration.
8981         * top.c (previous_saved_command_line, previous_repeat_arguments):
8982         New variables.
8983         (saved_command_line): Make static, define together with other
8984         'repeat variables'.
8985         (dont_repeat): Clear repeat_arguments.
8986         (repeat_previous, get_saved_command_line, save_command_line):
8987         New functions.
8988         (gdb_init): Initialize saved_command_line
8989         and previous_saved_command_line.
8990         * main.c (captured_main_1): Remove saved_command_line initialization.
8991         * event-top.c (handle_line_of_input): Update to use
8992         the new 'repeat' related functions instead of direct access to
8993         saved_command_line.
8994         * command.h (repeat_previous, get_saved_command_line,
8995         save_command_line): New declarations.
8996         (dont_repeat): Add comment.
8997
8998 2019-05-30  Tom Tromey  <tromey@adacore.com>
8999
9000         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9001         Fix comment.
9002         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9003
9004 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9005
9006         PR cli/24587
9007         * completer.c (complete): Initialize variable word.
9008
9009 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9010
9011         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9012         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9013         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9014         'body' is NULL to the outter 'if', protecting the '!is_define'
9015         situation as well.
9016
9017 2019-05-29  Tom Tromey  <tromey@adacore.com>
9018
9019         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9020         (dwarf_unknown): New function.
9021         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9022         (dwarf_type_encoding_name): Use dwarf_unknown.
9023
9024 2019-05-29  Tom Tromey  <tromey@adacore.com>
9025
9026         PR c++/20020:
9027         * cp-valprint.c (cp_print_value_fields): Call
9028         cp_print_static_field inside "try".
9029
9030 2019-05-29  Tom Tromey  <tromey@adacore.com>
9031
9032         * inflow.c (struct terminal_info): Add default operator=.
9033         * configure: Rebuild.
9034         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9035         -Wdeprecated-copy-dtor, -Wredundant-move.
9036
9037 2019-05-29  Tom Tromey  <tromey@adacore.com>
9038
9039         * NEWS: Add entry.
9040         * infcmd.c (print_return_value_1): Handle finish_print
9041         option.
9042         (show_print_finish): New function.
9043         (_initialize_infcmd): Add "set/show print finish" commands.
9044         * valprint.c (user_print_options): Initialize new member.
9045         * valprint.h (struct value_print_options) <finish_print>: New
9046         member.
9047
9048 2019-05-28  Tom Tromey  <tromey@adacore.com>
9049
9050         * ada-lang.c (ada_remove_Xbn_suffix)
9051         (find_old_style_renaming_symbol)
9052         (parse_old_style_renaming): Remove.
9053         (ada_find_renaming_symbol): Don't call
9054         find_old_style_renaming_symbol.
9055         (ada_is_renaming_symbol): Rename from
9056         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9057         bool.  Now static.
9058         (ada_read_var_value): Update and simplify.
9059         * ada-exp.y (write_var_or_type): Remove old code.
9060
9061 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9062
9063         PR gdb/25010
9064         * event-top.c: Remove include comment.
9065         * inflow.c (class scoped_ignore_sigttou): Move from here...
9066         * inflow.h (class scoped_ignore_sigttou): ...to here.
9067         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9068         * top.c:  Remove include comment.
9069
9070 2019-05-27  Tom Tromey  <tom@tromey.com>
9071
9072         * NEWS: Fix typo.
9073
9074 2019-05-22  Tom Tromey  <tromey@adacore.com>
9075
9076         * target.c (target_follow_exec): Constify parameter.
9077         * target-delegates.c: Rebuild.
9078         * remote.c (remote_target::follow_exec): Constify parameter.
9079         * infrun.c (follow_exec): Constify parameter.
9080         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9081         (target_follow_exec): Likewise.
9082
9083 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9084
9085         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9086         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9087
9088 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9089
9090         * NEWS: Add debugredirect and testsuite sections.
9091
9092 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9093
9094         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9095         target descriptions using exclusively floating point register name
9096         aliases.
9097
9098 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9099
9100         PR gdb/18644:
9101         * f-lang.c (build_fortran_types): Handle the case where
9102         gdbarch_floatformat_for_type returns a nullptr.
9103
9104 2019-05-21  Tom de Vries  <tdevries@suse.de>
9105
9106         PR cli/24587
9107         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9108
9109 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9110
9111         PR gdb/18644:
9112         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9113         16-byte floats.
9114         * i386-tdep.c (i386_floatformat_for_type): Use
9115         floatformats_ia64_quad for the 16-byte floating point component
9116         within a fortran 32-byte complex number.
9117
9118 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9119
9120         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9121         delete default constructor.
9122         (find_partial_die): Update to return const struct.
9123         (partial_die_parent_scope): Move variable declaration into scope
9124         of its use and change its type to auto.
9125         (guess_partial_die_structure_name): Likewise.
9126         (partial_die_info::fixup): Likewise.
9127
9128 2019-05-17  Tom Tromey  <tromey@adacore.com>
9129
9130         * source.c (find_and_open_source): Remove cast.
9131
9132 2019-05-17  Tom Tromey  <tromey@adacore.com>
9133
9134         * annotate.c (annotate_source): Make "filename" const.
9135         * annotate.h (annotate_source): Use const.
9136
9137 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9138
9139         * disasm.c (set_disassembler_options): Send errors to stderr.
9140
9141 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9142
9143         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9144         (cli_interp_base::set_logging): Check debug_redirect.
9145         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9146         * cli/cli-logging.c (debug_redirect): Add static variable.
9147         (pop_output_files): Add default param.
9148         (handle_redirections): Print debug setting.
9149         (show_logging_command): Likewise.
9150         (_initialize_cli_logging): Add debugredirect command.
9151         * interps.c (current_interp_set_logging): Add debug_redirect
9152         parameter.
9153         * interps.h (set_logging): Add debug_redirect parameter.
9154         (current_interp_set_logging): Likewise.
9155         * mi/mi-common.h: Likewise.
9156         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9157
9158 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9159             Tom Tromey  <tromey@adacore.com>
9160
9161         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9162         directly.
9163         * cli/cli-interp.h (make_logging_output): Remove declaration.
9164         * cli/cli-logging.c (make_logging_output): Remove function.
9165         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9166         directly.
9167         * ui-file.c (tee_file::tee_file): Remove bools.
9168         (tee_file::~tee_file): Remove deletes.
9169         * ui-file.h (tee_file): Remove bools.
9170
9171 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9172
9173         * mi/mi-cmds.h (mi_cmd_complete): New function.
9174         * mi/mi-main.c (mi_cmd_complete): Likewise.
9175         * mi/mi-cmds.c: Define new MI command -complete.
9176         * NEWS: Mention new -complete command.
9177
9178 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9179
9180         * completer.h (complete): New function.
9181         * completer.c (complete): Likewise.
9182         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9183         function defined in completer.h.
9184
9185 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9186
9187         * MAINTAINERS (Write After Approval): Add myself.
9188
9189 2019-05-17  Tom de Vries  <tdevries@suse.de>
9190
9191         PR gdb/24094
9192         * dwarf2read.c (struct cu_partial_die_info): New struct.
9193         (find_partial_die): Return cu_partial_die_info.
9194         (partial_die_parent_scope, guess_partial_die_structure_name)
9195         (partial_die_info::fixup): Handle new return type of find_partial_die.
9196
9197 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9198
9199         PR breakpoints/24541
9200         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9201         "std::string", simplifying the algorithm.
9202
9203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9204
9205         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9206         (stap_static_probe_ops::get_probes): Likewise.
9207
9208 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9209
9210         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9211         '-')" and "else if".
9212         (stap_parse_single_operand): Join checks for
9213         "gdbarch_stap_parse_special_token_p" and
9214         "gdbarch_stap_parse_special_token" in the same "if" statement.
9215         Invert check when verifying for operation on register
9216         displacement.
9217
9218 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9219
9220         * stap-probe.c (stap_get_opcode): Update comment.
9221         (stap_get_expected_argument_type): Likewise.
9222         (handle_stap_probe): Likewise.
9223
9224 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9225
9226         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9227         return type to 'bool'.  Adjust comment.  Use 'bool' when
9228         appropriate.
9229         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9230         * stap-probe.c (stap_parse_argument_1): Likewise.
9231         (stap_is_operator): Likewise.
9232         (stap_is_generic_prefix): Likewise.
9233         (stap_is_register_prefix): Likewise.
9234         (stap_is_register_indirection_prefix): Likewise.
9235         (stap_is_integer_prefix): Likewise.
9236         (stap_generic_check_suffix): Likewise.
9237         (stap_check_integer_suffix): Likewise.
9238         (stap_check_register_suffix): Likewise.
9239         (stap_check_register_indirection_suffix): Likewise.
9240         (stap_parse_register_operand): Likewise.
9241         (stap_parse_single_operand): Likewise.
9242         (stap_parse_argument_1): Likewise.
9243         (stap_probe::get_argument_count): Likewise.
9244         (stap_is_operator): Likewise.
9245
9246 2019-05-16  Tom Tromey  <tromey@adacore.com>
9247
9248         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9249         keyword to foreach.
9250
9251 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9252
9253         * linux-thread-db.c (try_thread_db_load_1): Change return type
9254         to bool.
9255         (try_thread_db_load): Likewise.
9256         (try_thread_db_load_from_pdir_1): Likewise.
9257         (try_thread_db_load_from_pdir): Likewise.
9258         (try_thread_db_load_from_sdir): Likewise.
9259         (try_thread_db_load_from_dir): Likewise.
9260         (thread_db_load_search): Likewise.
9261         (has_libpthread): Likewise.
9262         (thread_db_load): Likewise.
9263
9264 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9265
9266         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9267         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9268         NULL, and complain/return if that's the case.
9269
9270 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9271
9272         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9273         (advance, posn, abstract_read_memory): New functions.
9274         [struct mem_read_abstraction]: New struct.
9275         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9276
9277 2019-05-14  Tom Tromey  <tromey@adacore.com>
9278
9279         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9280         value is not lval_memory.
9281
9282 2019-05-14  Tom Tromey  <tromey@adacore.com>
9283
9284         * solib.c (info_sharedlibrary_command): Style the file name.
9285
9286 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9287
9288         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9289         (aarch64_vnv_type): Likewise.
9290         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9291         * common/tdesc.c: Likewise.
9292         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9293         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9294         * features/aarch64-fpu.xml: Add ieee half view.
9295         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9296         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9297         * gdbtypes.h (struct builtin_type): Likewise.
9298         (struct objfile_type): Likewise.
9299
9300 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9301
9302         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9303         typo.
9304         * location.h (string_to_event_location): Likewise.
9305
9306 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9307
9308         GDB 8.3 released.
9309
9310 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9311
9312         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9313         New variable declaration.
9314         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9315         New variable.
9316         (print_one_breakpoint): Use ui_out::test_flags and new global
9317         variable to compute use_fixed_output.
9318         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9319         Remove.
9320         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9321         (mi_multi_location_breakpoint_output_fixed): Remove.
9322         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9323         new variable.
9324         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9325         fix_multi_location_breakpoint_output flag if version >= 3.
9326         * ui-out.h (enum ui_out_flag)
9327         <fix_multi_location_breakpoint_output>: New enumerator.
9328
9329 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9330
9331         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9332
9333 2019-05-10  Tom Tromey  <tromey@adacore.com>
9334
9335         * ada-lang.c (catch_ada_completer): New function.
9336         (_initialize_ada_language): Use it.
9337
9338 2019-05-10  Tom Tromey  <tromey@adacore.com>
9339
9340         * thread.c (print_thread_info): Make "requested_threads" const.
9341         * gdbthread.h (print_thread_info): Make "requested_threads"
9342         const.
9343         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9344         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9345
9346 2019-05-08  Tom Tromey  <tom@tromey.com>
9347
9348         * gdbtypes.c (objfile_type_data): Change type.
9349         (objfile_type, _initialize_gdbtypes): Update.
9350
9351 2019-05-08  Tom Tromey  <tom@tromey.com>
9352
9353         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9354         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9355         (_initialize_dwarf2_frame): Update.
9356
9357 2019-05-08  Tom Tromey  <tom@tromey.com>
9358
9359         * objc-lang.c (objc_objfile_data): Change type.
9360         (find_methods): Update.
9361         (_initialize_objc_lang): Remove.
9362
9363 2019-05-08  Tom Tromey  <tom@tromey.com>
9364
9365         * stabsread.c (rs6000_builtin_type_data): Change type.
9366         (rs6000_builtin_type, _initialize_stabsread): Update.
9367
9368 2019-05-08  Tom Tromey  <tom@tromey.com>
9369
9370         * mips-tdep.c (mips_pdr_data): Remove.
9371         (_initialize_mips_tdep): Update.
9372
9373 2019-05-08  Tom Tromey  <tom@tromey.com>
9374
9375         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9376         (hppa_init_objfile_priv_data, read_unwind_info)
9377         (find_unwind_entry, _initialize_hppa_tdep): Update.
9378
9379 2019-05-08  Tom Tromey  <tom@tromey.com>
9380
9381         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9382         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9383         on obstack.
9384         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9385
9386 2019-05-08  Tom Tromey  <tom@tromey.com>
9387
9388         * mdebugread.c (basic_type_data): Change type.
9389         (basic_type, _initialize_mdebugread): Update.
9390
9391 2019-05-08  Tom Tromey  <tom@tromey.com>
9392
9393         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9394
9395 2019-05-08  Tom Tromey  <tom@tromey.com>
9396
9397         * nto-tdep.c (nto_inferior_data_reg): Change type.
9398         (nto_inferior_data): Update.
9399         (nto_inferior_data_cleanup, nto_new_inferior_data)
9400         (_initialize_nto_tdep): Remove.
9401         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9402
9403 2019-05-08  Tom Tromey  <tom@tromey.com>
9404
9405         * ada-lang.c (struct ada_inferior_data): Add initializers.
9406         (ada_inferior_data): Change type.
9407         (ada_inferior_data_cleanup): Remove.
9408         (get_ada_inferior_data, ada_inferior_exit)
9409         (struct ada_pspace_data): Add initializers, destructor.
9410         (ada_pspace_data_handle): Change type.
9411         (get_ada_pspace_data): Update.
9412         (ada_pspace_data_cleanup): Remove.
9413
9414 2019-05-08  Tom Tromey  <tom@tromey.com>
9415
9416         * coffread.c (struct coff_symfile_info): Add initializers.
9417         (coff_objfile_data_key): Move lower.  Change type.
9418         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9419         Update.
9420         (coff_free_info): Remove.
9421
9422 2019-05-08  Tom Tromey  <tom@tromey.com>
9423
9424         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9425         (fbsd_pspace_data_handle): Move lower.  Change type.
9426         (get_fbsd_pspace_data): Update.
9427         (fbsd_pspace_data_cleanup): Remove.
9428         (_initialize_fbsd_tdep): Update.
9429
9430 2019-05-08  Tom Tromey  <tom@tromey.com>
9431
9432         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9433         (get_ada_tasks_pspace_data): Update.
9434         (ada_tasks_pspace_data_cleanup): Remove.
9435         (_initialize_tasks): Update.
9436         (ada_tasks_inferior_data_handle): Change type.
9437         (get_ada_tasks_inferior_data): Update.
9438         (ada_tasks_inferior_data_cleanup): Remove.
9439         (struct ada_tasks_pspace_data): Add initializers.
9440
9441 2019-05-08  Tom Tromey  <tom@tromey.com>
9442
9443         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9444         * symfile-debug.c (debug_sym_get_probes): Change type.
9445         * stap-probe.c (handle_stap_probe):
9446         (stap_static_probe_ops::get_probes): Change type.
9447         * probe.h (class static_probe_ops) <get_probes>: Change type.
9448         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9449         (parse_probes_in_pspace): Update.
9450         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9451         Update.
9452         (any_static_probe_ops::get_probes): Change type.
9453         * elfread.c (elfread_data): New typedef.
9454         (probe_key): Change type.
9455         (elf_get_probes): Likewise.  Update.
9456         (probe_key_free): Remove.
9457         (_initialize_elfread): Update.
9458         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9459         Change type.
9460         (dtrace_process_dof_probe, dtrace_process_dof)
9461         (dtrace_static_probe_ops::get_probe): Change type.
9462
9463 2019-05-08  Tom Tromey  <tom@tromey.com>
9464
9465         * xcoffread.c (struct xcoff_symfile_info): Rename from
9466         coff_symfile_info.  Add initializers.
9467         (xcoff_objfile_data_key): Move lower.  Change type.
9468         (XCOFF_DATA): Rewrite.
9469         (xcoff_free_info): Remove.
9470         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9471         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9472         (xcoff_initial_scan): Update.
9473
9474 2019-05-08  Tom Tromey  <tom@tromey.com>
9475
9476         * solib-svr4.c (struct svr4_info): Add initializers and
9477         destructor.
9478         <probes_table>: Now an htab_up.
9479         (solib_svr4_pspace_data): Change type.
9480         (free_probes_table): Simplify.
9481         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9482         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9483         (probes_table_remove_objfile_probes, register_solib_event_probe)
9484         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9485         (_initialize_svr4_solib): Update.
9486
9487 2019-05-08  Tom Tromey  <tom@tromey.com>
9488
9489         * remote.c (remote_pspace_data): Change type.
9490         (remote_pspace_data_cleanup): Remove.
9491         (get_remote_exec_file, set_pspace_remote_exec_file)
9492         (_initialize_remote): Update.
9493
9494 2019-05-08  Tom Tromey  <tom@tromey.com>
9495
9496         * breakpoint.c (breakpoint_objfile_key): Change type.
9497         (get_breakpoint_objfile_data): Update.
9498         (free_breakpoint_objfile_data): Remove.
9499         (_initialize_breakpoint): Update.
9500
9501 2019-05-08  Tom Tromey  <tom@tromey.com>
9502
9503         * linux-tdep.c (struct linux_info): Add initializers.
9504         (linux_inferior_data): Move.  Change type.
9505         (invalidate_linux_cache_inf): Update.
9506         (linux_inferior_data_cleanup): Remove.
9507         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9508
9509 2019-05-08  Tom Tromey  <tom@tromey.com>
9510
9511         * auxv.c (auxv_inferior_data): Move.  Change type.
9512         (auxv_inferior_data_cleanup): Remove.
9513         (invalidate_auxv_cache_inf): Rewrite.
9514         (get_auxv_inferior_data, _initialize_auxv): Update.
9515
9516 2019-05-08  Tom Tromey  <tom@tromey.com>
9517
9518         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9519         (symfile_debug_objfile_data_key): Change type.
9520         (symfile_debug_installed, debug_qf_has_symbols)
9521         (debug_qf_find_last_source_symtab)
9522         (debug_qf_forget_cached_source_info)
9523         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9524         (debug_qf_print_stats, debug_qf_dump)
9525         (debug_qf_expand_symtabs_for_function)
9526         (debug_qf_expand_all_symtabs)
9527         (debug_qf_expand_symtabs_with_fullname)
9528         (debug_qf_map_matching_symbols)
9529         (debug_qf_expand_symtabs_matching)
9530         (debug_qf_find_pc_sect_compunit_symtab)
9531         (debug_qf_map_symbol_filenames)
9532         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9533         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9534         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9535         (debug_sym_read_linetable, debug_sym_relocate): Update.
9536         (symfile_debug_free_objfile): Remove.
9537         (install_symfile_debug_logging, _initialize_symfile_debug):
9538         Update.
9539
9540 2019-05-08  Tom Tromey  <tom@tromey.com>
9541
9542         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9543         allocate_on_obstack.
9544         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9545         (get_dwarf2_per_objfile): Update.
9546         (set_dwarf2_per_objfile): Remove.
9547         (dwarf2_has_info, dwarf2_get_section_info): Update.
9548         (dwarf2_free_objfile): Remove.
9549         (_initialize_dwarf2_read): Update.
9550
9551 2019-05-08  Tom Tromey  <tom@tromey.com>
9552
9553         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9554         initializers.
9555         <unsupported_script_warning_printed,
9556         script_not_found_warning_printed>: Now bool.
9557         (auto_load_pspace_data): Change type.
9558         (~auto_load_pspace_info): Rename from
9559         auto_load_pspace_data_cleanup.
9560         (get_auto_load_pspace_data, init_loaded_scripts_info)
9561         (clear_section_scripts, maybe_print_unsupported_script_warning)
9562         (maybe_print_script_not_found_warning, _initialize_auto_load):
9563         Update.
9564
9565 2019-05-08  Tom Tromey  <tom@tromey.com>
9566
9567         * objfiles.c (objfile_pspace_info): Add destructor and
9568         initializers.
9569         (objfiles_pspace_data): Change type.
9570         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9571         (get_objfile_pspace_data): Update.
9572         (objfiles_bfd_data): Change type.
9573         (get_objfile_bfd_data): Update.
9574         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9575
9576 2019-05-08  Tom Tromey  <tom@tromey.com>
9577
9578         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9579         Change type.
9580         (get_catch_syscall_inferior_data): Update.
9581         (catch_syscall_inferior_data_cleanup): Remove.
9582         (_initialize_break_catch_syscall): Update.
9583
9584 2019-05-08  Tom Tromey  <tom@tromey.com>
9585
9586         * inflow.c (struct terminal_info): Add destructor and
9587         initializers.
9588         (inflow_inferior_data): Change type.
9589         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9590         (get_inflow_inferior_data, inflow_inferior_exit)
9591         (swap_terminal_info, _initialize_inflow): Update.
9592
9593 2019-05-08  Tom Tromey  <tom@tromey.com>
9594
9595         * target-dcache.c (target_dcache_cleanup): Remove.
9596         (target_dcache_aspace_key): Change type.
9597         (target_dcache_init_p, target_dcache_invalidate)
9598         (target_dcache_get, target_dcache_get_or_init)
9599         (_initialize_target_dcache): Update.
9600         * dcache.h (struct dcache_deleter): New.
9601
9602 2019-05-08  Tom Tromey  <tom@tromey.com>
9603
9604         * symtab.c (struct symbol_cache): Add destructor and
9605         initializers.
9606         (symbol_cache_key): Move.  Change type.
9607         (make_symbol_cache, free_symbol_cache): Remove.
9608         (get_symbol_cache): Update.
9609         (symbol_cache_cleanup): Remove.
9610         (ALL_PSPACES, symbol_cache_flush)
9611         (maintenance_print_symbol_cache)
9612         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9613         Update.
9614
9615 2019-05-08  Tom Tromey  <tom@tromey.com>
9616
9617         * symtab.c (struct main_info): Add destructor and initializers.
9618         (main_progspace_key): Move.  Change type.
9619         (get_main_info): Update.
9620         (main_info_cleanup): Remove.
9621         (_initialize_symtab): Update.
9622
9623 2019-05-08  Tom Tromey  <tom@tromey.com>
9624
9625         * registry.h (DECLARE_REGISTRY): Define the _key class.
9626
9627 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9628
9629         * NEWS: Merge two 'New commands' sections.
9630
9631 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9632
9633         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9634         parameter and use Ada language definition instead.
9635         (ada_val_print_ptr): Remove unused language parameter.
9636         (ada_val_print_num): Remove language parameter and use Ada language
9637         definition instead.
9638         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9639         parameter.
9640         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9641         parameter and use Ada language definition instead.
9642         (ada_val_print_1): Update all ada_val_print_xxx calls.
9643         Remove language parameter.
9644         (ada_val_print): Update ada_val_print_1 call.
9645
9646 2019-05-08  Tom Tromey  <tromey@adacore.com>
9647
9648         * remote.c (remote_hw_watchpoint_limit)
9649         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9650         Now static.
9651
9652 2019-05-08  Tom Tromey  <tromey@adacore.com>
9653
9654         * maint.c (_initialize_maint_cmds): Move initialization code to
9655         remote.c.
9656         (watchdog, show_watchdog): Move to remote.c.
9657         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9658         "watchdog" static.
9659         (_initialize_remote): Move initialization code from maint.c.
9660         * defs.h (watchdog): Don't declare.
9661
9662 2019-05-08  Tom Tromey  <tromey@adacore.com>
9663
9664         * tui/tui-interp.c: Include main.h.
9665         * interps.c: Include main.h.
9666         * main.h (interpreter_p): Declare.
9667         * defs.h (interpreter_p): Don't declare.
9668
9669 2019-05-08  Tom Tromey  <tromey@adacore.com>
9670
9671         * dwarf2loc.c: Include dwarf2read.h.
9672         * defs.h (read_unsigned_leb128): Don't declare.
9673         * dwarf2read.h (read_unsigned_leb128): Declare.
9674
9675 2019-05-08  Tom Tromey  <tromey@adacore.com>
9676
9677         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9678         method.
9679
9680 2019-05-08  Tom Tromey  <tromey@adacore.com>
9681
9682         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9683         when no wrap column is set.
9684
9685 2019-05-08  Tom Tromey  <tromey@adacore.com>
9686
9687         * c-lang.c (c_get_string): Handle non-C-style arrays.
9688
9689 2019-05-08  Tom Tromey  <tromey@adacore.com>
9690
9691         * typeprint.c (print_offset_data::update): Print the bit offset,
9692         not the number of bits remaining.
9693
9694 2019-05-08  Tom Tromey  <tromey@adacore.com>
9695
9696         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9697         padding at end of comment.
9698
9699 2019-05-08  Tom Tromey  <tromey@adacore.com>
9700
9701         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9702         Compare main types.
9703
9704 2019-05-06  Tom Tromey  <tom@tromey.com>
9705
9706         * common/scoped_mmap.c: Include common-defs.h.
9707         * common/scoped_mmap.h: Don't include config.h.
9708
9709 2019-05-04  Tom Tromey  <tom@tromey.com>
9710
9711         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9712         (struct aarch64_call_info): Add initializers.
9713         <si>: Now a std::vector.
9714         (pass_on_stack, aarch64_push_dummy_call): Update.
9715
9716 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9717             Tom Tromey  <tom@tromey.com>
9718
9719         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9720         (ppc_threads): Now a std::vector.  Now static.
9721         (hwdebug_find_thread_points_by_tid)
9722         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9723         Update.
9724
9725 2019-05-04  Tom Tromey  <tom@tromey.com>
9726
9727         * arc-tdep.c (arc_tdesc_init): Return bool.
9728
9729 2019-05-04  Tom Tromey  <tom@tromey.com>
9730
9731         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9732         Use gdb_assert_not_reached.
9733
9734 2019-05-04  Tom Tromey  <tom@tromey.com>
9735
9736         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9737         "false".
9738
9739 2019-05-04  Tom Tromey  <tom@tromey.com>
9740
9741         * arc-tdep.c (arc_tdesc_init): Use bool.
9742
9743 2019-05-04  Tom Tromey  <tom@tromey.com>
9744
9745         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9746
9747 2019-05-04  Tom Tromey  <tom@tromey.com>
9748
9749         * cli/cli-cmds.c (valid_command_p): Return bool.
9750
9751 2019-05-04  Tom Tromey  <tom@tromey.com>
9752
9753         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9754         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9755
9756 2019-05-04  Raul Tambre  <raul@tambre.ee>
9757
9758         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9759         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9760         operator for comparison.
9761
9762 2019-05-04  Tom Tromey  <tom@tromey.com>
9763
9764         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9765         (lookup_partial_symbol, print_partial_symbols)
9766         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9767         (psymbol_compare): Update.
9768         (add_psymbol_to_bcache): Clear the entire psymbol.
9769         (maintenance_check_psymtabs): Update.
9770         * psympriv.h (struct partial_symbol): Don't derive from
9771         general_symbol_info.
9772         <obj_section, unrelocated_address, address,
9773         set_unrelocated_address>: Update.
9774         <ginfo>: New member.
9775         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9776         (debug_names::write_psymbols): Update.
9777
9778 2019-05-04  Tom de Vries  <tdevries@suse.de>
9779
9780         * contrib/cc-with-tweaks.sh: Support -n arg.
9781
9782 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9783
9784         * corelow.c (core_target::detach): Ensure frame cache and
9785         register caches are cleared.
9786         inferior.c (exit_inferior_1): Likewise.
9787
9788 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9789             Tom Tromey  <tom@tromey.com>
9790
9791         * dictionary.c (collate_pending_symbols_by_language): Remove
9792         "struct" from foreach.
9793         * symtab.c (lookup_global_symbol_from_objfile)
9794         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9795         foreach.
9796         * ser-tcp.c (net_open): Remove "struct" from foreach.
9797         * objfiles.c (objfile_relocate, objfile_rebase)
9798         (objfile_has_symbols): Remove "struct" from foreach.
9799         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9800         from foreach.
9801         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9802         foreach.
9803         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9804         "struct" from foreach.
9805         * ada-lang.c (create_excep_cond_exprs)
9806         (ada_exception_catchpoint_cond_string): Remove "struct" from
9807         foreach.
9808
9809 2019-05-03  Tom Tromey  <tromey@adacore.com>
9810
9811         * ada-exp.y (convert_char_literal): Check suffix of each
9812         enumerator.
9813
9814 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9815
9816         PR ada/21406:
9817         * ada-exp.y (yywrap): Don't define.
9818         * ada-lex.l (%option): Add noyywrap
9819         (yywrap): Remove.
9820
9821 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9822
9823         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9824         _WIN32_WINNT to the XP level, unless already defined to a higher
9825         level.
9826
9827         * unittests/parse-connection-spec-selftests.c:
9828         * ser-tcp.c:
9829         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9830         override.
9831
9832         * symfile.c (find_separate_debug_file): Remove colon from the
9833         drive spec of DOS/Windows file names of the target, so that the
9834         file name produced from DEBUGDIR and the target's directory will
9835         be valid on DOS/Windows systems.
9836
9837 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * rust-lang.c (val_print_struct): Handle printing structures
9840         containing strings.
9841
9842 2019-05-02  Tom Tromey  <tromey@adacore.com>
9843
9844         * valarith.c (_initialize_valarith): Remove.
9845
9846 2019-05-01  Tom Tromey  <tromey@adacore.com>
9847
9848         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9849         bitfields.
9850
9851 2019-05-01  Tom Tromey  <tromey@adacore.com>
9852
9853         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9854         for big-endian copies.
9855
9856 2019-04-30  Ali Tamur  <tamur@google.com>
9857         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9858         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9859         (read_3_bytes): New function.
9860
9861 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9862
9863         * windows-nat.c (main_thread_id): Delete.
9864         (handle_output_debug_string): Replace main_thread_id by
9865         current_event.dwThreadId.
9866         (fake_create_process): Likewise.
9867         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9868         Do not set main_thread_id.
9869         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9870         current_event.dwThreadId.
9871         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9872
9873 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9874
9875         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9876         Use current_event.dwThreadId instead of main_thread_id.
9877
9878 2019-04-30  Tom Tromey  <tromey@adacore.com>
9879
9880         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9881         (create_excep_cond_exprs): Iterate over program spaces.
9882         (ada_exception_catchpoint_cond_string): Examine all minimal
9883         symbols for exception types.
9884
9885 2019-04-30  Tom Tromey  <tromey@adacore.com>
9886
9887         PR c++/24470:
9888         * dwarf2read.c (process_structure_scope): Handle case where type
9889         has template parameters but no symbol was created.
9890
9891 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9892             Chris January  <chris.january@arm.com>
9893
9894         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9895         qualifier.
9896         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9897
9898 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9899
9900         * f-typeprint.c (f_print_type): Update rules for printing
9901         whitespace.
9902         (f_type_print_varspec_suffix): Likewise.
9903
9904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9905             Chris January  <chris.january@arm.com>
9906
9907         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9908         function arguments.
9909
9910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * f-lang.c (build_fortran_types): Change name of void type to
9913         lower case.
9914         * f-typeprint.c (f_type_print_base): Print the name of the void
9915         type, rather than a fixed string.
9916         * f-valprint.c (f_decorations): Use lower case void string.
9917
9918 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9919             Chris January  <chris.january@arm.com>
9920
9921         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9922         types for Fortran.
9923
9924 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9925             Chris January  <chris.january@arm.com>
9926             David Lecomber  <david.lecomber@arm.com>
9927
9928         * f-exp.y (BINOP_INTRINSIC): New token.
9929         (exp): New parser rule handling BINOP_INTRINSIC.
9930         (f77_keywords): Add new builtin procedures.
9931         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9932         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9933         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9934         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9935         (print_unop_subexp_f): New function.
9936         (print_binop_subexp_f): New function.
9937         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9938         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9939         (dump_subexp_body_f): Likewise.
9940         (operator_check_f): Likewise.
9941         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9942         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9943
9944 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9945
9946         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9947         UNOP_KIND.
9948         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9949         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9950         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9951         (operator_length_f): New fuction.
9952         (print_subexp_f): New function.
9953         (op_name_f): New function.
9954         (dump_subexp_body_f): New function.
9955         (operator_check_f): New function.
9956         (exp_descriptor_f): Replace standard expression handling functions
9957         with new functions.
9958         * gdb/fortran-operator.def: New file.
9959         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9960         * gdb/std-operator.def: Remove UNOP_KIND.
9961
9962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9963
9964         * std-operator.def: Remove unbalanced, stray double quote
9965         character.
9966
9967 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9968             Chris January  <chris.january@arm.com>
9969             Daniel Everett  <daniel.everett@arm.com>
9970             Nick Forrington  <nick.forrington@arm.com>
9971             Richard Bunt  <richard.bunt@arm.com>
9972
9973         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9974         of depth when printing anonymous structs or unions.
9975         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9976         Don't print either the top-level value, or the children if the
9977         max-depth is exceeded.
9978         (ppscm_print_children): When printing the key of a map, allow one
9979         extra level of depth.
9980         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9981         print either the top-level value, or the children if the max-depth
9982         is exceeded.
9983         (print_children): When printing the key of a map, allow one extra
9984         level of depth.
9985         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9986         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9987         (user_print_options): Initialise max_depth field.
9988         (val_print_scalar_or_string_type_p): New function.
9989         (val_print): Check to see if the max depth has been reached.
9990         (val_print_check_max_depth): Define new function.
9991         (show_print_max_depth): New function.
9992         (_initialize_valprint): Add 'print max-depth' option.
9993         * valprint.h (struct value_print_options) <max_depth>: New field.
9994         (val_print_check_max_depth): Declare new function.
9995         * NEWS: Document new feature.
9996
9997 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9998
9999         * ada-lang.c (ada_language_defn): Initialise new field.
10000         * c-lang.c (c_is_string_type_p): New function.
10001         (c_language_defn): Initialise new field.
10002         (cplus_language_defn): Initialise new field.
10003         (asm_language_defn): Initialise new field.
10004         (minimal_language_defn): Initialise new field.
10005         * c-lang.h (c_is_string_type_p): Declare new function.
10006         * d-lang.c (d_language_defn): Initialise new field.
10007         * f-lang.c (f_is_string_type_p): New function.
10008         (f_language_defn): Initialise new field.
10009         * go-lang.c (go_is_string_type_p): New function.
10010         (go_language_defn): Initialise new field.
10011         * language.c (default_is_string_type_p): New function.
10012         (unknown_language_defn): Initialise new field.
10013         (auto_language_defn): Initialise new field.
10014         * language.h (struct language_defn) <la_is_string_type_p>: New
10015         member variable.
10016         (default_is_string_type_p): Declare new function.
10017         * m2-lang.c (m2_language_defn): Initialise new field.
10018         * objc-lang.c (objc_language_defn): Initialise new field.
10019         * opencl-lang.c (opencl_language_defn): Initialise new field.
10020         * p-lang.c (pascal_is_string_type_p): New function.
10021         (pascal_language_defn): Initialise new field.
10022         * rust-lang.c (rust_is_string_type_p): New function.
10023         (rust_language_defn): Initialise new field.
10024
10025 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10026
10027         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10028         New field.
10029         * ada-lang.c (ada_language_defn): Initialise new field.
10030         * c-lang.c (c_language_defn): Likewise.
10031         (cplus_language_defn): Likewise.
10032         (asm_language_defn): Likewise.
10033         (minimal_language_defn): Likewise.
10034         * d-lang.c (d_language_defn): Likewise.
10035         * f-lang.c (f_language_defn): Likewise.
10036         * go-lang.c (go_language_defn): Likewise.
10037         * language.c (unknown_language_defn): Likewise.
10038         (auto_language_defn): Likewise.
10039         * m2-lang.c (m2_language_defn): Likewise.
10040         * objc-lang.c (objc_language_defn): Likewise.
10041         * opencl-lang.c (opencl_language_defn): Likewise.
10042         * p-lang.c (pascal_language_defn): Likewise.
10043         * rust-lang.c (rust_language_defn): Likewise.
10044
10045 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10046
10047         * ada-lang.c (ada_is_character_type): Change return type to bool.
10048         (ada_is_string_type): Likewise.
10049         * ada-lang.h (ada_is_character_type): Update declaration
10050         (ada_is_string_type): Likewise.
10051
10052 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10053
10054         Support style in 'frame|thread apply'
10055
10056         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10057         * record.c (record_start, record_stop): Update callers of
10058         execute_command_to_string with false.
10059         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10060         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10061         methods.
10062         (class string_file): New constructor with term_out parameter.
10063         Override methods term_out and can_emit_style_escape.  New member
10064         term_out.
10065         (class stdio_file): Override can_emit_style_escape.
10066         (class tee_file): Override term_out and can_emit_style_escape.
10067         * utils.h (can_emit_style_escape): Remove.
10068         * utils.c (can_emit_style_escape): Likewise.
10069         Update all callers of can_emit_style_escape (SOMESTREAM) to
10070         SOMESTREAM->can_emit_style_escape.
10071         * source-cache.c (source_cache::get_source_lines): Likewise.
10072         * stack.c (frame_apply_command_count): Call execute_command_to_string
10073         passing the term_out characteristic of the current gdb_stdout.
10074         * thread.c (thr_try_catch_cmd): Likewise.
10075         * top.c (execute_command_to_string): pass term_out parameter
10076         to construct the string_file for the command output.
10077         * ui-file.c (term_cli_styling): New function (most code moved
10078         from utils.c can_emit_style_escape).
10079         (string_file::string_file, string_file::can_emit_style_escape,
10080         stdio_file::can_emit_style_escape, tee_file::term_out,
10081         tee_file::can_emit_style_escape): New functions.
10082
10083 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10084
10085         * NEWS: Mention the new set|show may-call-functions.
10086         * infcall.c (may_call_functions_p): New variable.
10087         (show_may_call_functions_p): New function.
10088         (call_function_by_hand_dummy): Throws an error if not
10089         may-call-functions.
10090         (_initialize_infcall): Call add_setshow_boolean_cmd for
10091         may-call-functions.
10092
10093 2019-04-25  Keith Seitz  <keiths@redhat.com>
10094
10095         PR c++/24367
10096         * cp-support.c (inspect_type): Don't attempt substitutions
10097         of symbol with the same name.
10098
10099 2019-04-25  Tom Tromey  <tromey@adacore.com>
10100
10101         PR gdb/24475:
10102         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10103         static.
10104
10105 2019-04-25  Tom Tromey  <tromey@adacore.com>
10106
10107         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10108         rvalue reference.
10109         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10110         (gdb_xml_parser::parse): Use std::move.
10111         * python/python-internal.h (gdbpy_convert_exception): Take a const
10112         reference.
10113         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10114         std::move.
10115         * python/py-utils.c (gdbpy_convert_exception): Take a const
10116         reference.
10117         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10118         Use std::move.
10119         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10120         Use std::move.
10121         * mi/mi-main.c (mi_print_exception): Take a const reference.
10122         * main.c (handle_command_errors): Take a const reference.
10123         * linespec.c (parse_linespec): Use std::move.
10124         * infcall.c (run_inferior_call): Use std::move.
10125         (call_function_by_hand_dummy): Use std::move.
10126         * exec.c (try_open_exec_file): Use std::move.
10127         * exceptions.h (exception_print, exception_fprintf)
10128         (exception_print_same): Update.
10129         * exceptions.c (print_exception, exception_print)
10130         (exception_fprintf, exception_print_same): Change parameters to
10131         const reference.
10132         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10133         * common/new-op.c: Use std::move.
10134         * common/common-exceptions.h (struct gdb_exception): Add move
10135         constructor.
10136         (struct gdb_exception_error, struct gdb_exception_quit, struct
10137         gdb_quit_bad_alloc): Change constructor to move constructor.
10138         (throw_exception): Change parameter to rvalue reference.
10139         * common/common-exceptions.c (throw_exception): Take rvalue
10140         reference.
10141         * cli/cli-interp.c (safe_execute_command): Use std::move.
10142         * breakpoint.c (insert_bp_location, location_to_sals): Use
10143         std::move.
10144
10145 2019-04-25  Tom Tromey  <tromey@adacore.com>
10146
10147         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10148         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10149         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10150         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10151         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10152         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10153         guile/scm-value.c: Use unpack.
10154         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10155         gdbscm_gdb_exception.
10156         (gdbscm_throw_gdb_exception): Likewise.
10157         (struct gdbscm_gdb_exception): New.
10158         (unpack): New function.
10159         (gdbscm_wrap): Use unpack.
10160
10161 2019-04-25  Tom Tromey  <tromey@adacore.com>
10162
10163         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10164         (gdb_rl_callback_handler): Use std::move.
10165         * common/common-exceptions.h (struct gdb_exception): Add move
10166         assignment operator.
10167         (throw_exception_sjlj): Change "exception" to const reference.
10168         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10169         (throw_exception_sjlj): Change "exception" to const reference.
10170
10171 2019-04-25  Tom Tromey  <tromey@adacore.com>
10172
10173         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10174         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10175         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10176         Update.
10177         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10178         Update.
10179         * mi/mi-interp.c (mi_interp::exec): Update.
10180         * linespec.c (parse_linespec): Update.
10181         * infcall.c (run_inferior_call): Update.
10182         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10183         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10184         (gdbscm_lookup_global_symbol): Update.
10185         * guile/scm-param.c (gdbscm_parameter_value): Update.
10186         * guile/scm-frame.c (gdbscm_frame_read_register)
10187         (gdbscm_frame_read_var): Update.
10188         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10189         * exec.c (try_open_exec_file): Update.
10190         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10191         (gdb_rl_callback_handler): Update.
10192         * common/common-exceptions.h (exception_none): Don't declare.
10193         * common/common-exceptions.c (exception_none): Don't define.
10194         (struct catcher) <exception>: Update.
10195         * cli/cli-interp.c (safe_execute_command): Update.
10196         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10197
10198 2019-04-25  Ali Tamur  <tamur@google.com>
10199
10200         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10201         (read_attribute_value): Likewise.
10202         (dwarf2_read_addr_index): Update comment.
10203         (read_str_index): Add DW_FORM_strx.
10204         (dwarf2_string_attr): Likewise.
10205         (dwarf2_const_value_attr): Likewise.
10206         (dump_die_shallow): Likewise.
10207         (dwarf2_fetch_constant_bytes): Likewise.
10208         (skip_form_bytes): Likewise.
10209         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10210
10211 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10212
10213         PR corefiles/11608
10214         PR corefiles/18187
10215         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10216         OFFSET.  Verify if current mapping contains an ELF header.
10217         (linux_find_memory_regions_full): Adjust call to
10218         dump_mapping_p.
10219
10220 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10221             Kang Li <kanglictf@gmail.com>
10222
10223         PR gdb/21600
10224
10225         * dwarf2-frame.c (read_initial_length): Be consistent about using
10226         unsigned representation of length.
10227         (decode_frame_entry_1): Likewise.  Check for wraparound of
10228         end pointer as well as buffer overflow.
10229
10230 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10231
10232         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10233         "vq".
10234
10235 2019-04-24  Tom Tromey  <tromey@adacore.com>
10236
10237         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10238
10239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10240
10241         * s12z-tdep.c (s12z_unwind_pc): Delete.
10242         (s12z_unwind_sp): Delete.
10243         (s12z_gdbarch_init): Don't register deleted functions with
10244         gdbarch.
10245
10246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10247
10248         * rl78-tdep.c (rl78_unwind_sp): Delete.
10249         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10250
10251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10252
10253         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10254         (xstormy16_unwind_pc): Delete.
10255         (xstormy16_dummy_id): Delete.
10256         (xstormy16_gdbarch_init): Don't register deleted functions with
10257         gdbarch.
10258
10259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10260
10261         * vax-tdep.c (vax_unwind_pc): Delete.
10262         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10263
10264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10265
10266         * v850-tdep.c (v850_unwind_sp): Delete.
10267         (v850_unwind_pc): Delete.
10268         (v850_dummy_id): Delete.
10269         (v850_gdbarch_init): Don't register deleted functions with
10270         gdbarch.
10271
10272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10273
10274         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10275         (tilegx_unwind_pc): Delete.
10276         (tilegx_unwind_dummy_id): Delete.
10277         (tilegx_gdbarch_init): Don't register deleted functions with
10278         gdbarch.
10279
10280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10281
10282         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10283         (tic6x_dummy_id): Delete.
10284         (tic6x_gdbarch_init): Don't register deleted functions with
10285         gdbarch.
10286
10287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10288
10289         * sparc-tdep.c (sparc_unwind_pc): Delete.
10290         (sparc32_gdbarch_init): Don't register deleted function with
10291         gdbarch.
10292
10293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10294
10295         * sh-tdep.c (sh_unwind_sp): Delete.
10296         (sh_unwind_pc): Delete.
10297         (sh_dummy_id): Delete.
10298         (sh_gdbarch_init): Don't register deleted functions with
10299         gdbarch.
10300
10301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10302
10303         * score-tdep.c (score_unwind_sp): Delete.
10304         (score_unwind_pc): Delete.
10305         (score_dummy_id): Delete.
10306         (score_gdbarch_init): Don't register deleted functions with
10307         gdbarch.
10308
10309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10310
10311         * rx-tdep.c (rx_unwind_pc): Delete.
10312         (rx_unwind_sp): Delete.
10313         (rx_dummy_id): Delete.
10314         (rx_gdbarch_init): Don't register deleted functions with
10315         gdbarch.  Update comment.
10316
10317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10318
10319         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10320         (rs6000_dummy_id): Delete.
10321         (rs6000_gdbarch_init): Don't register deleted functions with
10322         gdbarch.
10323
10324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10325
10326         * or1k-tdep.c (or1k_dummy_id): Delete.
10327         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10328
10329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10330
10331         * nios2-tdep.c (nios2_dummy_id): Delete.
10332         (nios2_unwind_sp): Delete.
10333         (nios2_gdbarch_init): Don't register deleted functions with
10334         gdbarch.
10335
10336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * nds32-tdep.c (nds32_dummy_id): Delete.
10339         (nds32_unwind_pc): Delete.
10340         (nds32_unwind_sp): Delete.
10341         (nds32_gdbarch_init): Don't register deleted functions with
10342         gdbarch.
10343
10344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10345
10346         * msp430-tdep.c (msp430_unwind_pc): Delete.
10347         (msp430_unwind_sp): Delete.
10348         (msp430_dummy_id): Delete.
10349         (msp430_gdbarch_init): Don't register deleted functions with
10350         gdbarch.
10351
10352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10353
10354         * moxie-tdep.c (moxie_unwind_sp): Delete.
10355         (moxie_unwind_pc): Delete.
10356         (moxie_dummy_id): Delete.
10357         (moxie_gdbarch_init): Don't register deleted functions with
10358         gdbarch.
10359
10360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10363         (mn10300_unwind_pc): Delete.
10364         (mn10300_unwind_sp): Delete.
10365         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10366         mn10300_unwind_sp.
10367         (mn10300_frame_unwind_init): Don't register deleted functions with
10368         gdbarch.
10369
10370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10371
10372         * mep-tdep.c (mep_unwind_pc): Delete.
10373         (mep_unwind_sp): Delete.
10374         (mep_dummy_id): Delete.
10375         (mep_gdbarch_init): Don't register deleted functions with
10376         gdbarch.
10377
10378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10381         (m68hc11_unwind_sp): Delete.
10382         (m68hc11_gdbarch_init): Don't register deleted functions with
10383         gdbarch.
10384
10385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10386
10387         * m32r-tdep.c (m32r_unwind_sp): Delete.
10388         (m32r_unwind_pc): Delete.
10389         (m32r_dummy_id): Delete.
10390         (m32r_gdbarch_init): Don't register deleted functions with
10391         gdbarch.
10392
10393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10394
10395         * m32c-tdep.c (m32c_unwind_pc): Delete.
10396         (m32c_unwind_sp): Delete.
10397         (m32c_dummy_id): Delete.
10398         (m32c_gdbarch_init): Don't register deleted functions with
10399         gdbarch.
10400
10401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10402
10403         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10404         (lm32_unwind_pc): Delete.
10405         (lm32_dummy_id): Delete.
10406         (lm32_gdbarch_init): Don't register deleted functions with
10407         gdbarch.
10408
10409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10412         (iq2000_unwind_pc): Delete.
10413         (iq2000_dummy_id): Delete.
10414         (iq2000_gdbarch_init): Don't register deleted functions with
10415         gdbarch.
10416
10417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * nds32-tdep.c (nds32_type_align): Delete.
10420         (nds32_push_dummy_call): Use type_align instead.
10421
10422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10423
10424         * arm-tdep.c (arm_type_align): Only handle vector override case.
10425         (arm_push_dummy_call): Use type_align.
10426         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10427
10428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10431         case.
10432         (pass_on_stack): Use type_align.
10433         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10434         function.
10435
10436 2019-04-23  Tom Tromey  <tromey@adacore.com>
10437
10438         * dwarf2read.c (line_header::file_name_at): Remove unused
10439         overload.
10440
10441 2019-04-23  Tom de Vries  <tdevries@suse.de>
10442
10443         PR gdb/24438
10444         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10445         invocation.
10446
10447
10448 2019-03-27  Ali Tamur  <tamur@google.com>
10449
10450         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10451         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10452         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10453         (dwarf_expr_context::get_addr_index): Likewise
10454         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10455         (symbol_needs_eval_context::get_addr_index): Likewise
10456         (disassemble_dwarf_expression): Add DW_OP_addrx
10457         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10458         (read_cutu_die_from_dwo): Update comment
10459         (skip_one_die): Add DW_FORM_addrx
10460         (read_attribute_value): Likewise
10461         (var_decode_location): Add DW_OP_addrx
10462         (dwarf2_const_value_attr): Add DW_FORM_addrx
10463         (dump_die_shallow): Likewise
10464         (dwarf2_fetch_constant_bytes): Likewise
10465         (decode_locdesc): Add DW_OP_addrx
10466         (skip_form_bytes): Add DW_FORM_addrx
10467
10468 2019-04-22  Ali Tamur  <tamur@google.com>
10469
10470         * MAINTAINERS (Write After Approval): Add self.
10471
10472 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10473
10474         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10475         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10476         (open_symbol_file_object): Likewise.
10477         (svr4_default_sos): Add info parameter.
10478         (svr4_read_so_list): Likewise.
10479         (svr4_current_sos_direct): Adjust functions calls to pass down
10480         info.
10481         (svr4_current_sos_1): Add info parameter.
10482         (svr4_current_sos): Call get_svr4_info, pass info down to
10483         svr4_current_sos_1.
10484         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10485         get_svr4_info.
10486         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10487         get_svr4_info.
10488         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10489         to get_svr4_info.
10490         (probes_table_remove_objfile_probes): Likewise.
10491         (register_solib_event_probe): Add info parameter.
10492         (solist_update_incremental): Pass info parameter down to
10493         svr4_read_so_list.
10494         (disable_probes_interface): Add info parameter.
10495         (svr4_handle_solib_event): Pass current_program_space to
10496         get_svr4_info.  Adjust disable_probes_interface cleanup.
10497         (svr4_create_probe_breakpoints): Add info parameter, pass it
10498         down to register_solib_event_probe.
10499         (svr4_create_solib_event_breakpoints): Add info parameter,
10500         pass it down to svr4_create_probe_breakpoints.
10501         (enable_break): Pass info down to
10502         svr4_create_solib_event_breakpoints.
10503         (svr4_solib_create_inferior_hook): Pass current_program_space to
10504         get_svr4_info.
10505         (svr4_clear_solib): Likewise.
10506
10507 2019-04-22  Pedro Alves  <palves@redhat.com>
10508
10509         * solib-svr4.c (svr4_free_objfile_observer): New.
10510         (probe_and_action::objfile): New field.
10511         (probes_table_htab_remove_objfile_probes)
10512         (probes_table_remove_objfile_probes): New functions.
10513         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10514         in the new probe_and_action.  Don't store the probe in 'lookup'.
10515         (svr4_create_probe_breakpoints): Pass objfile to
10516         register_solib_event_probe.
10517         (_initialize_svr4_solib): Register a free_objfile observer.
10518
10519 2019-04-19  Tom Tromey  <tom@tromey.com>
10520
10521         * common/queue.h: Remove.
10522
10523 2019-04-19  Tom Tromey  <tom@tromey.com>
10524
10525         * event-loop.c: Don't include "common/queue.h".
10526
10527 2019-04-19  Tom Tromey  <tom@tromey.com>
10528
10529         * remote.c (remote_target): Use delete.
10530         * remote-notif.h: Include <list>, not "common/queue.h".
10531         (notif_client_p): Remove typedef.
10532         (remote_notif_state): Add constructor, destructor, initializer.
10533         <notif_queue>: Now a std::list.
10534         (remote_notif_state_xfree): Don't declare.
10535         * remote-notif.c (remote_notif_process, handle_notification)
10536         (remote_notif_state_allocate): Update.
10537         (~remote_notif_state): Rename from remote_notif_state_xfree.
10538
10539 2019-04-19  Tom Tromey  <tom@tromey.com>
10540
10541         * symfile.c (reread_symbols): Update.
10542         * objfiles.c (objfile_register_static_link)
10543         (objfile_lookup_static_link): Update
10544         (~objfile) Don't delete static_links.
10545         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10546
10547 2019-04-19  Tom Tromey  <tom@tromey.com>
10548
10549         * type-stack.h (struct type_stack) <insert>: Constify string.
10550         * type-stack.c (type_stack::insert): Constify string.
10551         * gdbtypes.h (lookup_template_type): Update.
10552         (address_space_name_to_int): Update.
10553         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10554         const.
10555         (lookup_template_type): Make name const.
10556         * c-exp.y: Update rules.
10557         (lex_one_token, classify_name, classify_inner_name)
10558         (c_print_token): Update.
10559         * p-exp.y: Update rules.
10560         (yylex): Update.
10561         * f-exp.y: Update rules.
10562         (yylex): Update.
10563         * d-exp.y: Update rules.
10564         (lex_one_token, classify_name, classify_inner_name): Update.
10565         * parse.c (write_dollar_variable, copy_name): Return std::string.
10566         * parser-defs.h (copy_name): Change return type.
10567         * m2-exp.y: Update rules.
10568         (yylex): Update.
10569         * go-exp.y (lex_one_token): Update.
10570         Update rules.
10571         (classify_unsafe_function, classify_packaged_name)
10572         (classify_name, yylex): Update.
10573
10574 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10575
10576         * configure.ac: add --enable-source-highlight switch.
10577         * configure: Regenerate.
10578         * top.c (print_gdb_version): plumb --enable-source-highlight
10579         status to "show configuration".
10580
10581 2019-04-19  Tom Tromey  <tromey@adacore.com>
10582
10583         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10584         Check ADA_TYPE_P.
10585         (empty_record, ada_template_to_fixed_record_type_1)
10586         (template_to_static_fixed_type)
10587         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10588         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10589         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10590         macros.
10591
10592 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10593
10594         PR symtab/24423:
10595         * source.c (print_source_lines_base): Advance "iter" when a
10596         control character is seen.
10597
10598 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10599
10600         * inferior.h (struct infcall_suspend_state_deleter):
10601         Catch exception in destructor to avoid crash.
10602
10603 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10604
10605         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10606         close to the add_com "shell".
10607
10608 2019-04-18  Tom Tromey  <tromey@adacore.com>
10609
10610         * process-stratum-target.h (class process_stratum_target)
10611         <stratum>: Add "final".
10612
10613 2019-04-17  Tom Tromey  <tromey@adacore.com>
10614
10615         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10616         against nullptr before use.
10617
10618 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10619
10620         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10621
10622 2019-04-17  Jim Wilson  <jimw@sifive.com>
10623             Andrew Burgess  <andrew.burgess@embecosm.com>
10624
10625         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10626         code read might fail, assume 4-byte breakpoint in that case.
10627
10628 2019-04-15  Leszek Swirski  <leszeks@google.com>
10629
10630         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10631         rather than a hand-rolled POD check when checking for forced MEMORY
10632         classification.
10633
10634 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10635
10636         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10637         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10638         function.
10639         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10640         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10641         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10642         declaration.
10643
10644 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10645
10646         * aarch64-linux-nat.c
10647         (aarch64_linux_nat_target::thread_architecture): Add override.
10648         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10649         each VQ.
10650
10651 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10652
10653         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10654
10655 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10656
10657         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10658         target types of size 96-bits, add some additional comments, and
10659         check that the builtin type we found was the correct size.
10660
10661 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10662
10663         * utils.c (prompt_for_continue): Don't restore the styling at the
10664         end, as applied_style has the wrong value.  This fixes styling in
10665         long lists of file names that are interrupted by the "Continue?"
10666         prompt.
10667
10668 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10669
10670         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10671         * c-lang.c (c_language_defn): Likewise.
10672         (cplus_language_defn): Likewise.
10673         (asm_language_defn): Likewise.
10674         (minimal_language_defn): Likewise.
10675         * d-lang.c (d_language_defn): Likewise.
10676         * f-lang.c (f_language_defn): Likewise.
10677         * go-lang.c (go_language_defn): Likewise.
10678         * language.c (unknown_language_defn): Likewise.
10679         (auto_language_defn): Likewise.
10680         * language.h (struct language_defn): Remove la_magic field.
10681         (LANG_MAGIC): Delete.
10682         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10683         * objc-lang.c (objc_language_defn): Likewise.
10684         * opencl-lang.c (opencl_language_defn): Likewise.
10685         * p-lang.c (pascal_language_defn): Likewise.
10686         * rust-lang.c (rust_language_defn): Likewise.
10687
10688 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10689
10690         * riscv-tdep.c (riscv_type_align): New function.
10691         (riscv_type_alignment): Delete.
10692         (riscv_arg_location): Use 'type_align'.
10693         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10694
10695 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10696
10697         * gdbtypes.c (type_align): A struct with no non-static fields also
10698         has alignment of 1.
10699
10700 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10701
10702         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10703         component to 0.
10704         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10705         member.
10706         (riscv_struct_info::analyse): New implementation using new
10707         analyse_inner member function.
10708         (riscv_struct_info::field_offset): New member function.
10709         (riscv_struct_info::m_offsets): New member variable.
10710         (riscv_struct_info::analyse_inner): New private member function,
10711         takes the old implementation of riscv_struct_info::analyse but
10712         extended to track field offsets.
10713         (riscv_call_arg_struct): Update the struct folding special cases
10714         to handle cases where empty C++ structs, which are non-zero
10715         length, are found.
10716         (riscv_arg_location): Initialise the length of each location, a
10717         non-zero length now indicates the location is in use.
10718         (riscv_push_dummy_call): Allow for the first location having a
10719         non-zero offset when setting up arguments.
10720         (riscv_return_value): Likewise, but for return values.
10721
10722 2019-04-11  Tom Tromey  <tromey@adacore.com>
10723
10724         * utils.c (internal_vproblem): Make "msg" const.
10725
10726 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10727
10728         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10729         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10730         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10731         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10732
10733 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10734
10735         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10736         function.
10737         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10738         of amd64_collect_native_gregset.
10739         (amd64_linux_nat_target::store_registers): Likewise.
10740
10741 2019-04-10  Tom Tromey  <tom@tromey.com>
10742
10743         * symtab.c (lookup_global_symbol_from_objfile)
10744         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10745         * objfiles.h (class separate_debug_iterator): New.
10746         (class separate_debug_range): New.
10747         (struct objfile) <separate_debug_objfiles>: New method.
10748         (objfile_separate_debug_iterate): Don't declare.
10749         * objfiles.c (separate_debug_iterator::operator++): Rename from
10750         objfile_separate_debug_iterate.
10751         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10752         iterator.
10753         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10754         iterator.
10755
10756 2019-04-10  Tom Tromey  <tom@tromey.com>
10757
10758         * symfile.c (reread_symbols): Remove old comment.
10759         * objfiles.c (free_all_objfiles): Fix a typo.
10760
10761 2019-04-10  Tom Tromey  <tom@tromey.com>
10762
10763         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10764         * minsyms.c (lookup_minimal_symbol): Use foreach.
10765         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10766         (lookup_minimal_symbol_solib_trampoline): Likewise.
10767         * symfile.c (reread_symbols): Use foreach.
10768
10769 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10770             Tom Tromey  <tromey@adacore.com>
10771
10772         PR rust/24414:
10773         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10774         (rust_lex_int_test): Change "value" to be LONGEST.
10775         (rust_lex_tests): Add test for long integer literal.
10776
10777 2019-04-09  Tom Tromey  <tromey@adacore.com>
10778
10779         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10780         to bool.
10781         (extended_remote_target::attach): Update.
10782         (remote_target::remote_notice_new_inferior): Update.
10783         (remote_target::add_current_inferior_and_thread): Update.
10784         * inferior.c (exit_inferior_1): Use "false".
10785         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10786
10787 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10788
10789         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10790         the "start" command.
10791
10792 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10793
10794         * python/py-inferior.c (infpy_thread_from_thread_handle):
10795         Adjust comments to reflect renaming of thread_from_thread_handle
10796         to thread_from_handle.  Adjust keywords.  Fix type error message.
10797         (inferior_object_methods): Add thread_from_handle.  Retain
10798         thread_from_thread_handle, but mark it as deprecated.
10799
10800 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10801
10802         * gdbthread.h (find_thread_by_handle): Revise declaration.
10803         * thread.c (find_thread_by_handle): Likewise.  Adjust
10804         implementation too.
10805         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10806         support for buffer objects as handles.
10807
10808 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10809
10810         * python/py-infthread.c (thpy_thread_handle): New function.
10811         (thread_object_methods): Register thpy_thread_handle.
10812
10813 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10814
10815         * gdbthread.h (thread_to_thread_handle): Declare.
10816         * thread.c (gdbtypes.h): Include.
10817         (thread_to_thread_handle): New function.
10818
10819         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10820         (target_thread_info_to_thread_handle): Declare.
10821         * target.c (target_thread_info_to_thread_handle): New function.
10822         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10823         * target-delegates.c: Regenerate.
10824
10825         * linux-thread-db.c (class thread_db_target): Add method
10826         thread_info_to_thread_handle.
10827         (thread_db_target::thread_info_to_thread_handle): Define.
10828         * remote.c (class remote_target): Add new method
10829         thread_info_to_thread_handle.
10830         (remote_target::thread_info_to_thread_handle): Define.
10831
10832 2019-04-08  Pedro Alves  <palves@redhat.com>
10833
10834         * common/common-exceptions.c (throw_exception): Don't create
10835         named object to throw; throw directly.
10836         (throw_it): Likewise.  Don't initialize gdb_exception::message
10837         here, with new; pass FMT and AP to the ctor instead.
10838         * common/common-exceptions.h: Include <string>.
10839         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10840         const char *, va_list)): New ctor.  Use std::make_shared.
10841         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10842         errors)): Delete.
10843         (gdb_exception_error::gdb_exception_error(enum errors, const char
10844         *, va_list)): New.
10845         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10846         Add assertion.
10847         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10848         errors)): Delete.
10849         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10850         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10851         Add assertion.
10852
10853 2019-04-08  Tom Tromey  <tom@tromey.com>
10854
10855         * valops.c (value_rtti_indirect_type): Replace throw_exception
10856         with throw.
10857         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10858         with throw.
10859         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10860         throw.
10861         * target.c (target_translate_tls_address): Replace throw_exception
10862         with throw.
10863         * stack.c (frame_apply_command_count): Replace throw_exception
10864         with throw.
10865         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10866         throw.
10867         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10868         with throw.
10869         * rs6000-tdep.c (rs6000_frame_cache)
10870         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10871         * remote.c: Replace throw_exception with throw.
10872         * record-full.c (record_full_message, record_full_wait_1)
10873         (record_full_restore): Replace throw_exception with throw.
10874         * record-btrace.c:
10875         (get_thread_current_frame_id, record_btrace_start_replaying)
10876         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10877         (cmd_record_btrace_start): Replace throw_exception with throw.
10878         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10879         throw.
10880         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10881         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10882         * linespec.c:
10883         (find_linespec_symbols): Replace throw_exception with throw.
10884         * infrun.c (displaced_step_prepare, resume): Replace
10885         throw_exception with throw.
10886         * infcmd.c (post_create_inferior): Replace throw_exception with
10887         throw.
10888         * inf-loop.c (inferior_event_handler): Replace throw_exception
10889         with throw.
10890         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10891         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10892         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10893         (get_prev_frame_always, get_frame_pc_if_available)
10894         (get_frame_address_in_block_if_available, get_frame_language):
10895         Replace throw_exception with throw.
10896         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10897         throw_exception with throw.
10898         * eval.c (fetch_subexp_value, evaluate_var_value)
10899         (evaluate_funcall, evaluate_subexp_standard): Replace
10900         throw_exception with throw.
10901         * dwarf2loc.c (call_site_find_chain)
10902         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10903         Replace throw_exception with throw.
10904         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10905         with throw.
10906         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10907         throw.
10908         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10909         * completer.c (complete_line_internal): Replace throw_exception
10910         with throw.
10911         * compile/compile-object-run.c (compile_object_run): Replace
10912         throw_exception with throw.
10913         * cli/cli-script.c (process_next_line): Replace throw_exception
10914         with throw.
10915         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10916         (btrace_enable, btrace_maint_update_pt_packets): Replace
10917         throw_exception with throw.
10918         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10919         throw_exception with throw.
10920         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10921         throw_exception with throw.
10922         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10923         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10924         * aarch64-tdep.c (aarch64_make_prologue_cache)
10925         (aarch64_make_stub_cache): Replace throw_exception with throw.
10926
10927 2019-04-08  Tom Tromey  <tom@tromey.com>
10928
10929         * common/common-exceptions.c (throw_exception): Rename from
10930         throw_exception_cxx.  Remove old copy.  Make argument const.
10931         (throw_it): Create and throw exception objects directly.
10932         * common/common-exceptions.h (throw_exception): Make argument
10933         const.
10934         (struct gdb_exception_error): Add constructor.
10935         (struct gdb_exception_quit): Add constructor.
10936
10937 2019-04-08  Tom Tromey  <tom@tromey.com>
10938
10939         * common/common-exceptions.h (exception_rethrow): Don't declare.
10940         (TRY_SJLJ): Update comment.
10941         (TRY, CATCH, END_CATCH): Remove.
10942         * common/common-exceptions.c (exception_rethrow): Remove.
10943
10944 2019-04-08  Tom Tromey  <tom@tromey.com>
10945
10946         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10947         Remove.
10948         (gdb_exception_error): Rename from
10949         gdb_exception_RETURN_MASK_ERROR.
10950         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10951         (gdb_quit_bad_alloc): Update.
10952         * aarch64-tdep.c: Update.
10953         * ada-lang.c: Update.
10954         * ada-typeprint.c: Update.
10955         * ada-valprint.c: Update.
10956         * amd64-tdep.c: Update.
10957         * arch-utils.c: Update.
10958         * break-catch-throw.c: Update.
10959         * breakpoint.c: Update.
10960         * btrace.c: Update.
10961         * c-varobj.c: Update.
10962         * cli/cli-cmds.c: Update.
10963         * cli/cli-interp.c: Update.
10964         * cli/cli-script.c: Update.
10965         * common/common-exceptions.c: Update.
10966         * common/new-op.c: Update.
10967         * common/selftest.c: Update.
10968         * compile/compile-c-symbols.c: Update.
10969         * compile/compile-cplus-symbols.c: Update.
10970         * compile/compile-object-load.c: Update.
10971         * compile/compile-object-run.c: Update.
10972         * completer.c: Update.
10973         * corelow.c: Update.
10974         * cp-abi.c: Update.
10975         * cp-support.c: Update.
10976         * cp-valprint.c: Update.
10977         * darwin-nat.c: Update.
10978         * disasm-selftests.c: Update.
10979         * dtrace-probe.c: Update.
10980         * dwarf-index-cache.c: Update.
10981         * dwarf-index-write.c: Update.
10982         * dwarf2-frame-tailcall.c: Update.
10983         * dwarf2-frame.c: Update.
10984         * dwarf2loc.c: Update.
10985         * dwarf2read.c: Update.
10986         * eval.c: Update.
10987         * event-loop.c: Update.
10988         * event-top.c: Update.
10989         * exec.c: Update.
10990         * f-valprint.c: Update.
10991         * fbsd-tdep.c: Update.
10992         * frame-unwind.c: Update.
10993         * frame.c: Update.
10994         * gdbtypes.c: Update.
10995         * gnu-v3-abi.c: Update.
10996         * guile/guile-internal.h: Update.
10997         * guile/scm-block.c: Update.
10998         * guile/scm-breakpoint.c: Update.
10999         * guile/scm-cmd.c: Update.
11000         * guile/scm-disasm.c: Update.
11001         * guile/scm-frame.c: Update.
11002         * guile/scm-lazy-string.c: Update.
11003         * guile/scm-math.c: Update.
11004         * guile/scm-param.c: Update.
11005         * guile/scm-ports.c: Update.
11006         * guile/scm-pretty-print.c: Update.
11007         * guile/scm-symbol.c: Update.
11008         * guile/scm-symtab.c: Update.
11009         * guile/scm-type.c: Update.
11010         * guile/scm-value.c: Update.
11011         * i386-linux-tdep.c: Update.
11012         * i386-tdep.c: Update.
11013         * inf-loop.c: Update.
11014         * infcall.c: Update.
11015         * infcmd.c: Update.
11016         * infrun.c: Update.
11017         * jit.c: Update.
11018         * language.c: Update.
11019         * linespec.c: Update.
11020         * linux-fork.c: Update.
11021         * linux-nat.c: Update.
11022         * linux-tdep.c: Update.
11023         * linux-thread-db.c: Update.
11024         * main.c: Update.
11025         * mi/mi-cmd-break.c: Update.
11026         * mi/mi-cmd-stack.c: Update.
11027         * mi/mi-interp.c: Update.
11028         * mi/mi-main.c: Update.
11029         * objc-lang.c: Update.
11030         * p-valprint.c: Update.
11031         * parse.c: Update.
11032         * ppc-linux-tdep.c: Update.
11033         * printcmd.c: Update.
11034         * python/py-arch.c: Update.
11035         * python/py-breakpoint.c: Update.
11036         * python/py-cmd.c: Update.
11037         * python/py-finishbreakpoint.c: Update.
11038         * python/py-frame.c: Update.
11039         * python/py-framefilter.c: Update.
11040         * python/py-gdb-readline.c: Update.
11041         * python/py-inferior.c: Update.
11042         * python/py-infthread.c: Update.
11043         * python/py-lazy-string.c: Update.
11044         * python/py-linetable.c: Update.
11045         * python/py-objfile.c: Update.
11046         * python/py-param.c: Update.
11047         * python/py-prettyprint.c: Update.
11048         * python/py-progspace.c: Update.
11049         * python/py-record-btrace.c: Update.
11050         * python/py-record.c: Update.
11051         * python/py-symbol.c: Update.
11052         * python/py-type.c: Update.
11053         * python/py-unwind.c: Update.
11054         * python/py-utils.c: Update.
11055         * python/py-value.c: Update.
11056         * python/python.c: Update.
11057         * record-btrace.c: Update.
11058         * record-full.c: Update.
11059         * remote-fileio.c: Update.
11060         * remote.c: Update.
11061         * riscv-tdep.c: Update.
11062         * rs6000-aix-tdep.c: Update.
11063         * rs6000-tdep.c: Update.
11064         * rust-exp.y: Update.
11065         * rust-lang.c: Update.
11066         * s390-tdep.c: Update.
11067         * selftest-arch.c: Update.
11068         * solib-dsbt.c: Update.
11069         * solib-frv.c: Update.
11070         * solib-spu.c: Update.
11071         * solib-svr4.c: Update.
11072         * solib.c: Update.
11073         * sparc64-linux-tdep.c: Update.
11074         * stack.c: Update.
11075         * symfile-mem.c: Update.
11076         * symmisc.c: Update.
11077         * target.c: Update.
11078         * thread.c: Update.
11079         * top.c: Update.
11080         * tracefile-tfile.c: Update.
11081         * tui/tui.c: Update.
11082         * typeprint.c: Update.
11083         * unittests/cli-utils-selftests.c: Update.
11084         * unittests/parse-connection-spec-selftests.c: Update.
11085         * valops.c: Update.
11086         * valprint.c: Update.
11087         * value.c: Update.
11088         * varobj.c: Update.
11089         * windows-nat.c: Update.
11090         * x86-linux-nat.c: Update.
11091         * xml-support.c: Update.
11092
11093 2019-04-08  Tom Tromey  <tom@tromey.com>
11094
11095         * xml-support.c: Use C++ exception handling.
11096         * x86-linux-nat.c: Use C++ exception handling.
11097         * windows-nat.c: Use C++ exception handling.
11098         * varobj.c: Use C++ exception handling.
11099         * value.c: Use C++ exception handling.
11100         * valprint.c: Use C++ exception handling.
11101         * valops.c: Use C++ exception handling.
11102         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11103         handling.
11104         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11105         * typeprint.c: Use C++ exception handling.
11106         * tui/tui.c: Use C++ exception handling.
11107         * tracefile-tfile.c: Use C++ exception handling.
11108         * top.c: Use C++ exception handling.
11109         * thread.c: Use C++ exception handling.
11110         * target.c: Use C++ exception handling.
11111         * symmisc.c: Use C++ exception handling.
11112         * symfile-mem.c: Use C++ exception handling.
11113         * stack.c: Use C++ exception handling.
11114         * sparc64-linux-tdep.c: Use C++ exception handling.
11115         * solib.c: Use C++ exception handling.
11116         * solib-svr4.c: Use C++ exception handling.
11117         * solib-spu.c: Use C++ exception handling.
11118         * solib-frv.c: Use C++ exception handling.
11119         * solib-dsbt.c: Use C++ exception handling.
11120         * selftest-arch.c: Use C++ exception handling.
11121         * s390-tdep.c: Use C++ exception handling.
11122         * rust-lang.c: Use C++ exception handling.
11123         * rust-exp.y: Use C++ exception handling.
11124         * rs6000-tdep.c: Use C++ exception handling.
11125         * rs6000-aix-tdep.c: Use C++ exception handling.
11126         * riscv-tdep.c: Use C++ exception handling.
11127         * remote.c: Use C++ exception handling.
11128         * remote-fileio.c: Use C++ exception handling.
11129         * record-full.c: Use C++ exception handling.
11130         * record-btrace.c: Use C++ exception handling.
11131         * python/python.c: Use C++ exception handling.
11132         * python/py-value.c: Use C++ exception handling.
11133         * python/py-utils.c: Use C++ exception handling.
11134         * python/py-unwind.c: Use C++ exception handling.
11135         * python/py-type.c: Use C++ exception handling.
11136         * python/py-symbol.c: Use C++ exception handling.
11137         * python/py-record.c: Use C++ exception handling.
11138         * python/py-record-btrace.c: Use C++ exception handling.
11139         * python/py-progspace.c: Use C++ exception handling.
11140         * python/py-prettyprint.c: Use C++ exception handling.
11141         * python/py-param.c: Use C++ exception handling.
11142         * python/py-objfile.c: Use C++ exception handling.
11143         * python/py-linetable.c: Use C++ exception handling.
11144         * python/py-lazy-string.c: Use C++ exception handling.
11145         * python/py-infthread.c: Use C++ exception handling.
11146         * python/py-inferior.c: Use C++ exception handling.
11147         * python/py-gdb-readline.c: Use C++ exception handling.
11148         * python/py-framefilter.c: Use C++ exception handling.
11149         * python/py-frame.c: Use C++ exception handling.
11150         * python/py-finishbreakpoint.c: Use C++ exception handling.
11151         * python/py-cmd.c: Use C++ exception handling.
11152         * python/py-breakpoint.c: Use C++ exception handling.
11153         * python/py-arch.c: Use C++ exception handling.
11154         * printcmd.c: Use C++ exception handling.
11155         * ppc-linux-tdep.c: Use C++ exception handling.
11156         * parse.c: Use C++ exception handling.
11157         * p-valprint.c: Use C++ exception handling.
11158         * objc-lang.c: Use C++ exception handling.
11159         * mi/mi-main.c: Use C++ exception handling.
11160         * mi/mi-interp.c: Use C++ exception handling.
11161         * mi/mi-cmd-stack.c: Use C++ exception handling.
11162         * mi/mi-cmd-break.c: Use C++ exception handling.
11163         * main.c: Use C++ exception handling.
11164         * linux-thread-db.c: Use C++ exception handling.
11165         * linux-tdep.c: Use C++ exception handling.
11166         * linux-nat.c: Use C++ exception handling.
11167         * linux-fork.c: Use C++ exception handling.
11168         * linespec.c: Use C++ exception handling.
11169         * language.c: Use C++ exception handling.
11170         * jit.c: Use C++ exception handling.
11171         * infrun.c: Use C++ exception handling.
11172         * infcmd.c: Use C++ exception handling.
11173         * infcall.c: Use C++ exception handling.
11174         * inf-loop.c: Use C++ exception handling.
11175         * i386-tdep.c: Use C++ exception handling.
11176         * i386-linux-tdep.c: Use C++ exception handling.
11177         * guile/scm-value.c: Use C++ exception handling.
11178         * guile/scm-type.c: Use C++ exception handling.
11179         * guile/scm-symtab.c: Use C++ exception handling.
11180         * guile/scm-symbol.c: Use C++ exception handling.
11181         * guile/scm-pretty-print.c: Use C++ exception handling.
11182         * guile/scm-ports.c: Use C++ exception handling.
11183         * guile/scm-param.c: Use C++ exception handling.
11184         * guile/scm-math.c: Use C++ exception handling.
11185         * guile/scm-lazy-string.c: Use C++ exception handling.
11186         * guile/scm-frame.c: Use C++ exception handling.
11187         * guile/scm-disasm.c: Use C++ exception handling.
11188         * guile/scm-cmd.c: Use C++ exception handling.
11189         * guile/scm-breakpoint.c: Use C++ exception handling.
11190         * guile/scm-block.c: Use C++ exception handling.
11191         * guile/guile-internal.h: Use C++ exception handling.
11192         * gnu-v3-abi.c: Use C++ exception handling.
11193         * gdbtypes.c: Use C++ exception handling.
11194         * frame.c: Use C++ exception handling.
11195         * frame-unwind.c: Use C++ exception handling.
11196         * fbsd-tdep.c: Use C++ exception handling.
11197         * f-valprint.c: Use C++ exception handling.
11198         * exec.c: Use C++ exception handling.
11199         * event-top.c: Use C++ exception handling.
11200         * event-loop.c: Use C++ exception handling.
11201         * eval.c: Use C++ exception handling.
11202         * dwarf2read.c: Use C++ exception handling.
11203         * dwarf2loc.c: Use C++ exception handling.
11204         * dwarf2-frame.c: Use C++ exception handling.
11205         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11206         * dwarf-index-write.c: Use C++ exception handling.
11207         * dwarf-index-cache.c: Use C++ exception handling.
11208         * dtrace-probe.c: Use C++ exception handling.
11209         * disasm-selftests.c: Use C++ exception handling.
11210         * darwin-nat.c: Use C++ exception handling.
11211         * cp-valprint.c: Use C++ exception handling.
11212         * cp-support.c: Use C++ exception handling.
11213         * cp-abi.c: Use C++ exception handling.
11214         * corelow.c: Use C++ exception handling.
11215         * completer.c: Use C++ exception handling.
11216         * compile/compile-object-run.c: Use C++ exception handling.
11217         * compile/compile-object-load.c: Use C++ exception handling.
11218         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11219         * compile/compile-c-symbols.c: Use C++ exception handling.
11220         * common/selftest.c: Use C++ exception handling.
11221         * common/new-op.c: Use C++ exception handling.
11222         * cli/cli-script.c: Use C++ exception handling.
11223         * cli/cli-interp.c: Use C++ exception handling.
11224         * cli/cli-cmds.c: Use C++ exception handling.
11225         * c-varobj.c: Use C++ exception handling.
11226         * btrace.c: Use C++ exception handling.
11227         * breakpoint.c: Use C++ exception handling.
11228         * break-catch-throw.c: Use C++ exception handling.
11229         * arch-utils.c: Use C++ exception handling.
11230         * amd64-tdep.c: Use C++ exception handling.
11231         * ada-valprint.c: Use C++ exception handling.
11232         * ada-typeprint.c: Use C++ exception handling.
11233         * ada-lang.c: Use C++ exception handling.
11234         * aarch64-tdep.c: Use C++ exception handling.
11235
11236 2019-04-08  Tom Tromey  <tom@tromey.com>
11237
11238         * xml-support.c (gdb_xml_parser::parse): Update.
11239         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11240         * value.c (show_convenience): Update.
11241         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11242         (test_parse_flags_qcs): Update.
11243         * thread.c (thr_try_catch_cmd): Update.
11244         * target.c (target_translate_tls_address): Update.
11245         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11246         (info_frame_command_core, frame_apply_command_count): Update.
11247         * rust-exp.y (rust_lex_exception_test): Update.
11248         * riscv-tdep.c (riscv_print_one_register_info): Update.
11249         * remote.c (remote_target::enable_btrace): Update.
11250         * record-btrace.c (record_btrace_enable_warn): Update.
11251         * python/py-utils.c (gdbpy_convert_exception): Update.
11252         * printcmd.c (do_one_display, print_variable_and_value): Update.
11253         * mi/mi-main.c (mi_print_exception): Update.
11254         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11255         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11256         * linux-nat.c (linux_nat_target::attach): Update.
11257         * linux-fork.c (class scoped_switch_fork_info): Update.
11258         * infrun.c (displaced_step_prepare): Update.
11259         * infcall.c (call_function_by_hand_dummy): Update.
11260         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11261         * gnu-v3-abi.c (print_one_vtable): Update.
11262         * frame.c (get_prev_frame_always): Update.
11263         * f-valprint.c (info_common_command_for_block): Update.
11264         * exec.c (try_open_exec_file): Update.
11265         * exceptions.c (print_exception, exception_print)
11266         (exception_fprintf, exception_print_same): Update.
11267         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11268         * dwarf-index-cache.c (index_cache::store)
11269         (index_cache::lookup_gdb_index): Update.
11270         * darwin-nat.c (maybe_cache_shell): Update.
11271         * cp-valprint.c (cp_print_value_fields): Update.
11272         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11273         (gcc_cplus_symbol_address): Update.
11274         * compile/compile-c-symbols.c (gcc_convert_symbol)
11275         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11276         * common/selftest.c: Update.
11277         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11278         a std::string.
11279         (exception_try_scope_entry, exception_try_scope_exit): Don't
11280         declare.
11281         (struct exception_try_scope): Remove.
11282         (TRY): Don't use exception_try_scope.
11283         (struct gdb_exception): Add constructor, operator=.
11284         <what>: New method.
11285         (struct gdb_exception_RETURN_MASK_ALL)
11286         (struct gdb_exception_RETURN_MASK_ERROR)
11287         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11288         (struct gdb_quit_bad_alloc): Update.
11289         * common/common-exceptions.c (exception_none): Change
11290         initializer.
11291         (struct catcher) <state, exception>: Initialize inline.
11292         <prev>: Remove member.
11293         (current_catcher): Remove.
11294         (catchers): New global.
11295         (exceptions_state_mc_init): Simplify.
11296         (catcher_pop): Remove.
11297         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11298         (try_scope_depth, exception_try_scope_entry)
11299         (exception_try_scope_exit): Remove.
11300         (throw_exception_sjlj): Update.
11301         (exception_messages, exception_messages_size): Remove.
11302         (throw_it): Simplify.
11303         (gdb_exception_sliced_copy): Remove.
11304         (throw_exception_cxx): Update.
11305         * cli/cli-script.c (script_from_file): Update.
11306         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11307         Update.
11308         * ada-valprint.c (ada_val_print): Update.
11309         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11310         (create_excep_cond_exprs): Update.
11311
11312 2019-04-08  Tom Tromey  <tom@tromey.com>
11313
11314         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11315         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11316         (TRY, CATCH, END_CATCH): Remove some definitions.
11317         * common/common-exceptions.c: Don't use GDB_XCPT.
11318         (catcher_list_size): Remove.
11319         (throw_exception, throw_it): Simplify.
11320
11321 2019-04-05  Tom Tromey  <tom@tromey.com>
11322
11323         Revert the header-sorting patch.
11324         * ft32-tdep.c: Revert.
11325         * frv-tdep.c: Revert.
11326         * frv-linux-tdep.c: Revert.
11327         * frame.c: Revert.
11328         * frame-unwind.c: Revert.
11329         * frame-base.c: Revert.
11330         * fork-child.c: Revert.
11331         * findvar.c: Revert.
11332         * findcmd.c: Revert.
11333         * filesystem.c: Revert.
11334         * filename-seen-cache.h: Revert.
11335         * filename-seen-cache.c: Revert.
11336         * fbsd-tdep.c: Revert.
11337         * fbsd-nat.h: Revert.
11338         * fbsd-nat.c: Revert.
11339         * f-valprint.c: Revert.
11340         * f-typeprint.c: Revert.
11341         * f-lang.c: Revert.
11342         * extension.h: Revert.
11343         * extension.c: Revert.
11344         * extension-priv.h: Revert.
11345         * expprint.c: Revert.
11346         * exec.h: Revert.
11347         * exec.c: Revert.
11348         * exceptions.c: Revert.
11349         * event-top.c: Revert.
11350         * event-loop.c: Revert.
11351         * eval.c: Revert.
11352         * elfread.c: Revert.
11353         * dwarf2read.h: Revert.
11354         * dwarf2read.c: Revert.
11355         * dwarf2loc.c: Revert.
11356         * dwarf2expr.h: Revert.
11357         * dwarf2expr.c: Revert.
11358         * dwarf2-frame.c: Revert.
11359         * dwarf2-frame-tailcall.c: Revert.
11360         * dwarf-index-write.h: Revert.
11361         * dwarf-index-write.c: Revert.
11362         * dwarf-index-common.c: Revert.
11363         * dwarf-index-cache.h: Revert.
11364         * dwarf-index-cache.c: Revert.
11365         * dummy-frame.c: Revert.
11366         * dtrace-probe.c: Revert.
11367         * disasm.h: Revert.
11368         * disasm.c: Revert.
11369         * disasm-selftests.c: Revert.
11370         * dictionary.c: Revert.
11371         * dicos-tdep.c: Revert.
11372         * demangle.c: Revert.
11373         * dcache.h: Revert.
11374         * dcache.c: Revert.
11375         * darwin-nat.h: Revert.
11376         * darwin-nat.c: Revert.
11377         * darwin-nat-info.c: Revert.
11378         * d-valprint.c: Revert.
11379         * d-namespace.c: Revert.
11380         * d-lang.c: Revert.
11381         * ctf.c: Revert.
11382         * csky-tdep.c: Revert.
11383         * csky-linux-tdep.c: Revert.
11384         * cris-tdep.c: Revert.
11385         * cris-linux-tdep.c: Revert.
11386         * cp-valprint.c: Revert.
11387         * cp-support.c: Revert.
11388         * cp-namespace.c: Revert.
11389         * cp-abi.c: Revert.
11390         * corelow.c: Revert.
11391         * corefile.c: Revert.
11392         * continuations.c: Revert.
11393         * completer.h: Revert.
11394         * completer.c: Revert.
11395         * complaints.c: Revert.
11396         * coffread.c: Revert.
11397         * coff-pe-read.c: Revert.
11398         * cli-out.h: Revert.
11399         * cli-out.c: Revert.
11400         * charset.c: Revert.
11401         * c-varobj.c: Revert.
11402         * c-valprint.c: Revert.
11403         * c-typeprint.c: Revert.
11404         * c-lang.c: Revert.
11405         * buildsym.c: Revert.
11406         * buildsym-legacy.c: Revert.
11407         * build-id.h: Revert.
11408         * build-id.c: Revert.
11409         * btrace.c: Revert.
11410         * bsd-uthread.c: Revert.
11411         * breakpoint.h: Revert.
11412         * breakpoint.c: Revert.
11413         * break-catch-throw.c: Revert.
11414         * break-catch-syscall.c: Revert.
11415         * break-catch-sig.c: Revert.
11416         * blockframe.c: Revert.
11417         * block.c: Revert.
11418         * bfin-tdep.c: Revert.
11419         * bfin-linux-tdep.c: Revert.
11420         * bfd-target.c: Revert.
11421         * bcache.c: Revert.
11422         * ax-general.c: Revert.
11423         * ax-gdb.h: Revert.
11424         * ax-gdb.c: Revert.
11425         * avr-tdep.c: Revert.
11426         * auxv.c: Revert.
11427         * auto-load.c: Revert.
11428         * arm-wince-tdep.c: Revert.
11429         * arm-tdep.c: Revert.
11430         * arm-symbian-tdep.c: Revert.
11431         * arm-pikeos-tdep.c: Revert.
11432         * arm-obsd-tdep.c: Revert.
11433         * arm-nbsd-tdep.c: Revert.
11434         * arm-nbsd-nat.c: Revert.
11435         * arm-linux-tdep.c: Revert.
11436         * arm-linux-nat.c: Revert.
11437         * arm-fbsd-tdep.c: Revert.
11438         * arm-fbsd-nat.c: Revert.
11439         * arm-bsd-tdep.c: Revert.
11440         * arch-utils.c: Revert.
11441         * arc-tdep.c: Revert.
11442         * arc-newlib-tdep.c: Revert.
11443         * annotate.h: Revert.
11444         * annotate.c: Revert.
11445         * amd64-windows-tdep.c: Revert.
11446         * amd64-windows-nat.c: Revert.
11447         * amd64-tdep.c: Revert.
11448         * amd64-sol2-tdep.c: Revert.
11449         * amd64-obsd-tdep.c: Revert.
11450         * amd64-obsd-nat.c: Revert.
11451         * amd64-nbsd-tdep.c: Revert.
11452         * amd64-nbsd-nat.c: Revert.
11453         * amd64-nat.c: Revert.
11454         * amd64-linux-tdep.c: Revert.
11455         * amd64-linux-nat.c: Revert.
11456         * amd64-fbsd-tdep.c: Revert.
11457         * amd64-fbsd-nat.c: Revert.
11458         * amd64-dicos-tdep.c: Revert.
11459         * amd64-darwin-tdep.c: Revert.
11460         * amd64-bsd-nat.c: Revert.
11461         * alpha-tdep.c: Revert.
11462         * alpha-obsd-tdep.c: Revert.
11463         * alpha-nbsd-tdep.c: Revert.
11464         * alpha-mdebug-tdep.c: Revert.
11465         * alpha-linux-tdep.c: Revert.
11466         * alpha-linux-nat.c: Revert.
11467         * alpha-bsd-tdep.c: Revert.
11468         * alpha-bsd-nat.c: Revert.
11469         * aix-thread.c: Revert.
11470         * agent.c: Revert.
11471         * addrmap.c: Revert.
11472         * ada-varobj.c: Revert.
11473         * ada-valprint.c: Revert.
11474         * ada-typeprint.c: Revert.
11475         * ada-tasks.c: Revert.
11476         * ada-lang.c: Revert.
11477         * aarch64-tdep.c: Revert.
11478         * aarch64-ravenscar-thread.c: Revert.
11479         * aarch64-newlib-tdep.c: Revert.
11480         * aarch64-linux-tdep.c: Revert.
11481         * aarch64-linux-nat.c: Revert.
11482         * aarch64-fbsd-tdep.c: Revert.
11483         * aarch64-fbsd-nat.c: Revert.
11484         * aarch32-linux-nat.c: Revert.
11485
11486 2019-04-05  Tom Tromey  <tom@tromey.com>
11487
11488         * ft32-tdep.c: Sort headers.
11489         * frv-tdep.c: Sort headers.
11490         * frv-linux-tdep.c: Sort headers.
11491         * frame.c: Sort headers.
11492         * frame-unwind.c: Sort headers.
11493         * frame-base.c: Sort headers.
11494         * fork-child.c: Sort headers.
11495         * findvar.c: Sort headers.
11496         * findcmd.c: Sort headers.
11497         * filesystem.c: Sort headers.
11498         * filename-seen-cache.h: Sort headers.
11499         * filename-seen-cache.c: Sort headers.
11500         * fbsd-tdep.c: Sort headers.
11501         * fbsd-nat.h: Sort headers.
11502         * fbsd-nat.c: Sort headers.
11503         * f-valprint.c: Sort headers.
11504         * f-typeprint.c: Sort headers.
11505         * f-lang.c: Sort headers.
11506         * extension.h: Sort headers.
11507         * extension.c: Sort headers.
11508         * extension-priv.h: Sort headers.
11509         * expprint.c: Sort headers.
11510         * exec.h: Sort headers.
11511         * exec.c: Sort headers.
11512         * exceptions.c: Sort headers.
11513         * event-top.c: Sort headers.
11514         * event-loop.c: Sort headers.
11515         * eval.c: Sort headers.
11516         * elfread.c: Sort headers.
11517         * dwarf2read.h: Sort headers.
11518         * dwarf2read.c: Sort headers.
11519         * dwarf2loc.c: Sort headers.
11520         * dwarf2expr.h: Sort headers.
11521         * dwarf2expr.c: Sort headers.
11522         * dwarf2-frame.c: Sort headers.
11523         * dwarf2-frame-tailcall.c: Sort headers.
11524         * dwarf-index-write.h: Sort headers.
11525         * dwarf-index-write.c: Sort headers.
11526         * dwarf-index-common.c: Sort headers.
11527         * dwarf-index-cache.h: Sort headers.
11528         * dwarf-index-cache.c: Sort headers.
11529         * dummy-frame.c: Sort headers.
11530         * dtrace-probe.c: Sort headers.
11531         * disasm.h: Sort headers.
11532         * disasm.c: Sort headers.
11533         * disasm-selftests.c: Sort headers.
11534         * dictionary.c: Sort headers.
11535         * dicos-tdep.c: Sort headers.
11536         * demangle.c: Sort headers.
11537         * dcache.h: Sort headers.
11538         * dcache.c: Sort headers.
11539         * darwin-nat.h: Sort headers.
11540         * darwin-nat.c: Sort headers.
11541         * darwin-nat-info.c: Sort headers.
11542         * d-valprint.c: Sort headers.
11543         * d-namespace.c: Sort headers.
11544         * d-lang.c: Sort headers.
11545         * ctf.c: Sort headers.
11546         * csky-tdep.c: Sort headers.
11547         * csky-linux-tdep.c: Sort headers.
11548         * cris-tdep.c: Sort headers.
11549         * cris-linux-tdep.c: Sort headers.
11550         * cp-valprint.c: Sort headers.
11551         * cp-support.c: Sort headers.
11552         * cp-namespace.c: Sort headers.
11553         * cp-abi.c: Sort headers.
11554         * corelow.c: Sort headers.
11555         * corefile.c: Sort headers.
11556         * continuations.c: Sort headers.
11557         * completer.h: Sort headers.
11558         * completer.c: Sort headers.
11559         * complaints.c: Sort headers.
11560         * coffread.c: Sort headers.
11561         * coff-pe-read.c: Sort headers.
11562         * cli-out.h: Sort headers.
11563         * cli-out.c: Sort headers.
11564         * charset.c: Sort headers.
11565         * c-varobj.c: Sort headers.
11566         * c-valprint.c: Sort headers.
11567         * c-typeprint.c: Sort headers.
11568         * c-lang.c: Sort headers.
11569         * buildsym.c: Sort headers.
11570         * buildsym-legacy.c: Sort headers.
11571         * build-id.h: Sort headers.
11572         * build-id.c: Sort headers.
11573         * btrace.c: Sort headers.
11574         * bsd-uthread.c: Sort headers.
11575         * breakpoint.h: Sort headers.
11576         * breakpoint.c: Sort headers.
11577         * break-catch-throw.c: Sort headers.
11578         * break-catch-syscall.c: Sort headers.
11579         * break-catch-sig.c: Sort headers.
11580         * blockframe.c: Sort headers.
11581         * block.c: Sort headers.
11582         * bfin-tdep.c: Sort headers.
11583         * bfin-linux-tdep.c: Sort headers.
11584         * bfd-target.c: Sort headers.
11585         * bcache.c: Sort headers.
11586         * ax-general.c: Sort headers.
11587         * ax-gdb.h: Sort headers.
11588         * ax-gdb.c: Sort headers.
11589         * avr-tdep.c: Sort headers.
11590         * auxv.c: Sort headers.
11591         * auto-load.c: Sort headers.
11592         * arm-wince-tdep.c: Sort headers.
11593         * arm-tdep.c: Sort headers.
11594         * arm-symbian-tdep.c: Sort headers.
11595         * arm-pikeos-tdep.c: Sort headers.
11596         * arm-obsd-tdep.c: Sort headers.
11597         * arm-nbsd-tdep.c: Sort headers.
11598         * arm-nbsd-nat.c: Sort headers.
11599         * arm-linux-tdep.c: Sort headers.
11600         * arm-linux-nat.c: Sort headers.
11601         * arm-fbsd-tdep.c: Sort headers.
11602         * arm-fbsd-nat.c: Sort headers.
11603         * arm-bsd-tdep.c: Sort headers.
11604         * arch-utils.c: Sort headers.
11605         * arc-tdep.c: Sort headers.
11606         * arc-newlib-tdep.c: Sort headers.
11607         * annotate.h: Sort headers.
11608         * annotate.c: Sort headers.
11609         * amd64-windows-tdep.c: Sort headers.
11610         * amd64-windows-nat.c: Sort headers.
11611         * amd64-tdep.c: Sort headers.
11612         * amd64-sol2-tdep.c: Sort headers.
11613         * amd64-obsd-tdep.c: Sort headers.
11614         * amd64-obsd-nat.c: Sort headers.
11615         * amd64-nbsd-tdep.c: Sort headers.
11616         * amd64-nbsd-nat.c: Sort headers.
11617         * amd64-nat.c: Sort headers.
11618         * amd64-linux-tdep.c: Sort headers.
11619         * amd64-linux-nat.c: Sort headers.
11620         * amd64-fbsd-tdep.c: Sort headers.
11621         * amd64-fbsd-nat.c: Sort headers.
11622         * amd64-dicos-tdep.c: Sort headers.
11623         * amd64-darwin-tdep.c: Sort headers.
11624         * amd64-bsd-nat.c: Sort headers.
11625         * alpha-tdep.c: Sort headers.
11626         * alpha-obsd-tdep.c: Sort headers.
11627         * alpha-nbsd-tdep.c: Sort headers.
11628         * alpha-mdebug-tdep.c: Sort headers.
11629         * alpha-linux-tdep.c: Sort headers.
11630         * alpha-linux-nat.c: Sort headers.
11631         * alpha-bsd-tdep.c: Sort headers.
11632         * alpha-bsd-nat.c: Sort headers.
11633         * aix-thread.c: Sort headers.
11634         * agent.c: Sort headers.
11635         * addrmap.c: Sort headers.
11636         * ada-varobj.c: Sort headers.
11637         * ada-valprint.c: Sort headers.
11638         * ada-typeprint.c: Sort headers.
11639         * ada-tasks.c: Sort headers.
11640         * ada-lang.c: Sort headers.
11641         * aarch64-tdep.c: Sort headers.
11642         * aarch64-ravenscar-thread.c: Sort headers.
11643         * aarch64-newlib-tdep.c: Sort headers.
11644         * aarch64-linux-tdep.c: Sort headers.
11645         * aarch64-linux-nat.c: Sort headers.
11646         * aarch64-fbsd-tdep.c: Sort headers.
11647         * aarch64-fbsd-nat.c: Sort headers.
11648         * aarch32-linux-nat.c: Sort headers.
11649
11650 2019-04-04  Tom Tromey  <tom@tromey.com>
11651
11652         * varobj.c (varobj_create): Update.
11653         * rust-exp.y (struct rust_parser) <update_innermost_block,
11654         lookup_symbol>: New methods.
11655         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11656         Rename.
11657         (rust_parser::rust_lookup_type)
11658         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11659         * printcmd.c (display_command, do_one_display): Update.
11660         * parser-defs.h (struct parser_state) <parser_state>: Add
11661         "tracker" parameter.
11662         (block_tracker): New member.
11663         (class innermost_block_tracker) <innermost_block_tracker>: Add
11664         "types" parameter.
11665         <reset>: Remove method.
11666         (innermost_block): Don't declare.
11667         (null_post_parser): Update.
11668         * parse.c (innermost_block): Remove global.
11669         (write_dollar_variable): Update.
11670         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11671         Remove "tracker_types" parameter.
11672         (parse_expression): Add "tracker" parameter.
11673         (parse_expression_for_completion): Update.
11674         (null_post_parser): Add "tracker" parameter.
11675         * p-exp.y: Update rules.
11676         * m2-exp.y: Update rules.
11677         * language.h (struct language_defn) <la_post_parser>: Add
11678         "tracker" parameter.
11679         * go-exp.y: Update rules.
11680         * f-exp.y: Update rules.
11681         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11682         parameter.
11683         * d-exp.y: Update rules.
11684         * c-exp.y: Update rules.
11685         * breakpoint.c (set_breakpoint_condition): Create an
11686         innermost_block_tracker.
11687         (watch_command_1): Likewise.
11688         * ada-lang.c (resolve): Add "tracker" parameter.
11689         (resolve_subexp): Likewise.
11690         * ada-exp.y (write_var_from_sym): Update.
11691
11692 2019-04-04  Tom Tromey  <tom@tromey.com>
11693
11694         * type-stack.h: New file.
11695         * type-stack.c: New file.
11696         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11697         type-stack.h.
11698         (insert_into_type_stack, insert_type, push_type, push_type_int)
11699         (insert_type_address_space, pop_type, pop_type_int)
11700         (pop_typelist, pop_type_stack, append_type_stack)
11701         (push_type_stack, get_type_stack, push_typelist)
11702         (follow_type_instance_flags, follow_types): Don't declare.
11703         * parse.c (type_stack): Remove global.
11704         (parse_exp_in_context): Update.
11705         (insert_into_type_stack, insert_type, push_type, push_type_int)
11706         (insert_type_address_space, pop_type, pop_type_int)
11707         (pop_typelist, pop_type_stack, append_type_stack)
11708         (push_type_stack, get_type_stack, push_typelist)
11709         (follow_type_instance_flags, follow_types): Remove (moved to
11710         type-stack.c).
11711         * f-exp.y (type_stack): New global.
11712         Update rules.
11713         (push_kind_type, f_parse): Update.
11714         * d-exp.y (type_stack): New global.
11715         Update rules.
11716         (d_parse): Update.
11717         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11718         Update rules.
11719         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11720         (HFILES_NO_SRCDIR): Add type-stack.h.
11721
11722 2019-04-04  Tom Tromey  <tom@tromey.com>
11723
11724         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11725         (rust_parser::convert_ast_to_expression, rust_parse)
11726         (rust_lex_test_completion, rust_lex_tests): Update.
11727         * parser-defs.h (struct expr_completion_state): New.
11728         (struct parser_state) <parser_state>: Add completion parameter.
11729         <mark_struct_expression, mark_completion_tag>: New methods.
11730         <parse_completion, m_completion_state>: New members.
11731         (prefixify_expression, null_post_parser): Update.
11732         (mark_struct_expression, mark_completion_tag): Don't declare.
11733         * parse.c (parse_completion, expout_last_struct)
11734         (expout_tag_completion_type, expout_completion_name): Remove
11735         globals.
11736         (parser_state::mark_struct_expression)
11737         (parser_state::mark_completion_tag): Now methods.
11738         (prefixify_expression): Add last_struct parameter.
11739         (prefixify_subexp): Likewise.
11740         (parse_exp_1): Update.
11741         (parse_exp_in_context): Add cstate parameter.  Update.
11742         (parse_expression_for_completion): Create an
11743         expr_completion_state.
11744         (null_post_parser): Add "completion" parameter.
11745         * p-exp.y: Update rules.
11746         (yylex): Update.
11747         * language.h (struct language_defn) <la_post_parser>: Add
11748         "completing" parameter.
11749         * go-exp.y: Update rules.
11750         (lex_one_token): Update.
11751         * expression.h (parse_completion): Don't declare.
11752         * d-exp.y: Update rules.
11753         (lex_one_token): Update rules.
11754         * c-exp.y: Update rules.
11755         (lex_one_token): Update.
11756         * ada-lang.c (resolve): Add "parse_completion" parameter.
11757         (resolve_subexp): Likewise.
11758         (ada_resolve_function): Likewise.
11759
11760 2019-04-04  Tom Tromey  <tom@tromey.com>
11761
11762         * parser-defs.h (struct parser_state) <start_arglist,
11763         end_arglist>: New methods.
11764         <arglist_len, m_funcall_chain>: New members.
11765         (arglist_len, start_arglist, end_arglist): Don't declare.
11766         * parse.c (arglist_len, funcall_chain): Remove global.
11767         (start_arglist, end_arglist): Remove functions.
11768         (parse_exp_in_context): Update.
11769         * p-exp.y: Update rules.
11770         * m2-exp.y: Update rules.
11771         * go-exp.y: Update rules.
11772         * f-exp.y: Update rules.
11773         * d-exp.y: Update rules.
11774         * c-exp.y: Update rules.
11775
11776 2019-04-04  Tom Tromey  <tom@tromey.com>
11777
11778         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11779         lex_operator, push_back>: New methods.
11780         Update all rules.
11781         (rust_parser::lex_hex, lex_escape): Rename and update.
11782         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11783         (rust_parser::lex_operator): Rename and update.
11784         (rust_parser::lex_number, rustyylex, rustyyerror)
11785         (rust_lex_test_init, rust_lex_test_sequence)
11786         (rust_lex_test_push_back, rust_lex_tests): Update.
11787         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11788         parameter.
11789         <lexptr, prev_lexptr>: New members.
11790         (lexptr, prev_lexptr): Don't declare.
11791         * parse.c (lexptr, prev_lexptr): Remove globals.
11792         (parse_exp_in_context): Update.
11793         * p-exp.y (yylex, yyerror): Update.
11794         * m2-exp.y (parse_number, yylex, yyerror): Update.
11795         * go-exp.y (lex_one_token, yyerror): Update.
11796         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11797         * d-exp.y (lex_one_token, yyerror): Update.
11798         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11799         (lex_one_token, yyerror): Update.
11800         * ada-lex.l (YY_INPUT): Update.
11801         (rewind_to_char): Update.
11802         * ada-exp.y (yyerror): Update.
11803
11804 2019-04-04  Tom Tromey  <tom@tromey.com>
11805
11806         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11807         * parser-defs.h (struct parser_state) <parser_state>: Add new
11808         parameter.
11809         <comma_terminates>: New member.
11810         (comma_terminates): Don't declare global.
11811         * parse.c (comma_terminates): Remove global.
11812         (parse_exp_in_context): Update.
11813         * p-exp.y (yylex): Update.
11814         * m2-exp.y (yylex): Update.
11815         * go-exp.y (lex_one_token): Update.
11816         * f-exp.y (yylex): Update.
11817         * d-exp.y (lex_one_token): Update.
11818         * c-exp.y (lex_one_token): Update.
11819         * ada-lex.l: Update.
11820
11821 2019-04-04  Tom Tromey  <tom@tromey.com>
11822
11823         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11824         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11825         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11826         * parser-defs.h (paren_depth): Don't declare.
11827         * parse.c (paren_depth): Remove global.
11828         (parse_exp_in_context): Update.
11829         * p-exp.y (paren_depth): New global.
11830         (pascal_parse): Initialize it.
11831         * m2-exp.y (paren_depth): New global.
11832         (m2_parse): Initialize it.
11833         * go-exp.y (paren_depth): New global.
11834         (go_parse): Initialize it.
11835         * f-exp.y (paren_depth): New global.
11836         (f_parse): Initialize it.
11837         * d-exp.y (paren_depth): New global.
11838         (d_parse): Initialize it.
11839         * c-exp.y (paren_depth): New global.
11840         (c_parse): Initialize it.
11841         * ada-lex.l (paren_depth): New global.
11842         (lexer_init): Initialize it.
11843
11844 2019-04-04  Tom Tromey  <tom@tromey.com>
11845
11846         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11847         (rust_parser::convert_ast_to_type)
11848         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11849         * parser-defs.h (struct parser_state) <parser_state>: Add
11850         parameters.  Initialize new members.
11851         <expression_context_block, expression_context_pc>: New members.
11852         * parse.c (expression_context_block, expression_context_pc):
11853         Remove globals.
11854         (parse_exp_in_context): Update.
11855         * p-exp.y: Update all rules.
11856         (yylex): Update.
11857         * m2-exp.y: Update all rules.
11858         (yylex): Update.
11859         * go-exp.y (yylex): Update.
11860         * f-exp.y (yylex): Update.
11861         * d-exp.y: Update all rules.
11862         (yylex): Update.
11863         * c-exp.y: Update all rules.
11864         (lex_one_token, classify_name, yylex, c_parse): Update.
11865         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11866
11867 2019-04-04  Tom Tromey  <tom@tromey.com>
11868
11869         * gdbarch.h, gdbarch.c: Rebuild.
11870         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11871         * stap-probe.h:
11872         (struct stap_parse_info): Replace "parser_state" with
11873         "expr_builder".
11874         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11875         (parser_state): New class.
11876         * parse.c (expr_builder): Rename.
11877         (expr_builder::release): Rename.
11878         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11879         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11880         (write_exp_elt_longcst, write_exp_elt_floatcst)
11881         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11882         (write_exp_string_vector, write_exp_bitstring)
11883         (write_exp_msymbol, mark_struct_expression)
11884         (write_dollar_variable)
11885         (insert_type_address_space, increase_expout_size): Replace
11886         "parser_state" with "expr_builder".
11887         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11888         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11889         "parser_state" with "expr_builder".
11890
11891 2019-04-04  Tom Tromey  <tom@tromey.com>
11892
11893         * rust-exp.y: Replace "parse_language" with method call.
11894         * p-exp.y:
11895         (yylex): Replace "parse_language" with method call.
11896         * m2-exp.y:
11897         (yylex): Replace "parse_language" with method call.
11898         * go-exp.y (classify_name): Replace "parse_language" with method
11899         call.
11900         * f-exp.y (yylex): Replace "parse_language" with method call.
11901         * d-exp.y (lex_one_token): Replace "parse_language" with method
11902         call.
11903         * c-exp.y:
11904         (lex_one_token, classify_name, yylex): Replace "parse_language"
11905         with method call.
11906         * ada-exp.y (find_primitive_type, type_char)
11907         (type_system_address): Replace "parse_language" with method call.
11908
11909 2019-04-04  Tom Tromey  <tom@tromey.com>
11910
11911         * rust-exp.y: Replace "parse_gdbarch" with method call.
11912         * parse.c (write_dollar_variable, insert_type_address_space):
11913         Replace "parse_gdbarch" with method call.
11914         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11915         call.
11916         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11917         call.
11918         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11919         "parse_gdbarch" with method call.
11920         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11921         with method call.
11922         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11923         "parse_gdbarch" with method call.
11924         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11925         "parse_gdbarch" with method call.
11926         * c-exp.y (parse_type, parse_number, classify_name): Replace
11927         "parse_gdbarch" with method call.
11928         * ada-lex.l: Replace "parse_gdbarch" with method call.
11929         * ada-exp.y (parse_type, find_primitive_type, type_char)
11930         (type_system_address): Replace "parse_gdbarch" with method call.
11931
11932 2019-04-04  Tom Tromey  <tom@tromey.com>
11933
11934         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11935         * stap-probe.c (stap_parse_argument): Update.
11936         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11937         initial_size parameter.
11938         * rust-exp.y (rust_lex_tests): Update.
11939         * parse.c (parser_state): Update.
11940         (parse_exp_in_context): Update.
11941         * parser-defs.h (struct parser_state) <parser_state>: Remove
11942         "initial_size" parameter.
11943
11944 2019-04-04  Tom Tromey  <tom@tromey.com>
11945
11946         * parser-defs.h (increase_expout_size): Don't declare.
11947         * parse.c (increase_expout_size): Now static.
11948
11949 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11950
11951         * gnu-nat.c (gnu_nat_target::wait): Fix
11952         target_waitstatus_to_string call.
11953
11954 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11955
11956         * eval.c (evaluate_subexp_standard): Handle internal functions
11957         during Fortran function call handling.
11958
11959 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * NEWS: Mention new internal functions.
11962         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11963         (read_base_type): Use dwarf2_init_complex_target_type.
11964         * value.c (creal_internal_fn): New function.
11965         (cimag_internal_fn): New function.
11966         (_initialize_values): Register new internal functions.
11967
11968 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11969
11970         * infrun.c (stop_all_threads): If debug_infrun, always
11971         trace the wait status after wait_one, using
11972         target_waitstatus_to_string and target_pid_to_str.
11973         (handle_inferior_event): Replace various trace of
11974         wait status kind by a single trace.
11975         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11976         wait status kind image by target_waitstatus_to_string.
11977         * target/waitstatus.c (target_waitstatus_to_string): Fix
11978         obsolete comment.
11979
11980 2019-04-01  Tom Tromey  <tromey@adacore.com>
11981
11982         PR symtab/23331:
11983         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11984
11985 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11986             Pedro Alves  <palves@redhat.com>
11987
11988         * top.c (quit_force): Call 'finalize_values'.
11989         * value.c (finalize_values): New function.
11990         * value.h (finalize_values): Declare.
11991
11992 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11993
11994         * NEWS: Announce $_gdb_major and $_gdb_minor.
11995
11996         * top.c (init_gdb_version_vars): New function.
11997         (gdb_init): Call init_gdb_version_vars.
11998
11999 2019-03-29  Tom Tromey  <tromey@adacore.com>
12000
12001         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12002         help text.  Remove dead code.
12003
12004 2019-03-29  Keith Seitz  <keiths@redhat.com>
12005
12006         From Siddhesh Poyarekar:
12007         * f-lang.h (f77_get_upperbound): Return LONGEST.
12008         (f77_get_lowerbound): Likewise.
12009         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12010         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12011         print them.
12012         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12013         plongest to format print it.
12014         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12015         (f77_get_upperbound): Likewise.
12016         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12017         LOWER_BOUND to LONGEST.
12018         (f77_create_arrayprint_offset_tbl): Likewise.
12019
12020 2019-03-29  Keith Seitz  <keiths@redhat.com>
12021
12022         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12023         %s/pulongest for TYPE_LENGTH instead of %d in format
12024         strings.
12025         * ada-typerint.c (ada_print_type): Likewise.
12026         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12027         * compile/compile-c-support.c (generate_register_struct): Likewise.
12028         * gdbtypes.c (recursive_dump_type): Likewise.
12029         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12030         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12031         instead of %d in format strings.
12032         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12033         to std::min to ULONGEST.
12034         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12035         instead of %d in format strings.
12036         * tracepoint.c (info_scope_command): Likewise.
12037         * typeprint.c (print_offset_data::update)
12038         (print_offset_data::finish): Likewise.
12039         * xtensa-tdep.c (xtensa_store_return_value)
12040         (xtensa_push_dummy_call): Likewise.
12041
12042 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12043
12044         * windows-nat.c (display_selector): Fixed format specifications
12045         for 64-bit Cygwin.
12046
12047 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12048
12049         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12050
12051 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12052
12053         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12054         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12055         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12056         (nios2_linux_init_abi): Install it.
12057
12058 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12059
12060         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12061
12062 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12063
12064         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12065
12066 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12067             Tom Tromey  <tromey@adacore.com>
12068
12069         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12070
12071 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12072
12073         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12074         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12075         method to compute the bounds of range types. Also print "[evaluated]"
12076         if the bounds' values come from a dynamic evaluation.
12077
12078 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12079
12080         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12081         whitespace when pretty printing is on.
12082
12083 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12084
12085         * ppc-linux-nat.c: Add include.
12086
12087 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12088
12089         * NEWS: Mention AArch64 Pointer Authentication.
12090
12091 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12092
12093         * arm-linux-nat.c: Add include.
12094
12095 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12096
12097         * source-cache.c (source_cache::get_source_lines): Re-read
12098         fullname after calling open_source_file.
12099
12100 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12101
12102         * NEWS: Mention TLS support for FreeBSD.
12103
12104 2019-03-25  Tom Tromey  <tromey@adacore.com>
12105
12106         * minsyms.c (BUNCH_SIZE): Update comment.
12107         (~minimal_symbol_reader): Remove old comment.
12108         (compact_minimal_symbols): Update comment.
12109         (minimal_symbol_reader::install): Remove old comment.  Update
12110         other comments.
12111
12112 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12113
12114         * s390-linux-nat.c: Add include.
12115
12116 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12117
12118         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12119         Call linux_get_hwcap.
12120         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12121         Likewise.
12122         (aarch64_linux_get_hwcap): Remove function.
12123         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12124         declaration.
12125         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12126         linux_get_hwcap.
12127         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12128         * linux-tdep.c (linux_get_hwcap): Add function.
12129         (linux_get_hwcap2): Likewise.
12130         * linux-tdep.h (linux_get_hwcap): Add declaration.
12131         (linux_get_hwcap2): Likewise.
12132         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12133         (ppc_linux_get_hwcap2): Likewise.
12134         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12135         linux_get_hwcap.
12136         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12137         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12138         (ppc_linux_nat_target::read_description): Likewise.
12139         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12140         * s390-linux-nat.c: Likewise.
12141         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12142
12143 2019-03-24  Tom Tromey  <tom@tromey.com>
12144
12145         * ada-lang.c (standard_lookup): Simplify initialization.
12146         (ada_lookup_symbol_nonlocal): Simplify return.
12147         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12148         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12149         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12150         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12151         initialization.
12152         * solib.c (solib_global_lookup): Simplify.
12153         * symtab.c (null_block_symbol): Remove.
12154         (symbol_cache_lookup): Simplify returns.
12155         (lookup_language_this): Simplify returns.
12156         (lookup_symbol_aux): Simplify return.
12157         (lookup_local_symbol): Simplify returns.
12158         (lookup_global_symbol_from_objfile): Simplify return.
12159         (lookup_symbol_in_objfile_symtabs)
12160         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12161         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12162         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12163         * cp-namespace.c (cp_lookup_bare_symbol)
12164         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12165         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12166         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12167         (cp_lookup_symbol_via_imports): Simplify initialization.
12168         (find_symbol_in_baseclass): Likewise.
12169         * symtab.h (null_block_symbol): Remove.
12170         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12171         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12172         (d_lookup_symbol_module): Likewise.
12173         (find_symbol_in_baseclass): Simplify initialization.
12174
12175 2019-03-24  Tom Tromey  <tom@tromey.com>
12176
12177         * expression.h: Don't include symtab.h.
12178         (struct block): Forward declare.
12179
12180 2019-03-24  Tom Tromey  <tom@tromey.com>
12181
12182         * c-exp.y (typebase): Remove casts.
12183         * gdbtypes.c (lookup_unsigned_typename, )
12184         (lookup_signed_typename): Remove cast.
12185         * eval.c (parse_to_comma_and_eval): Remove cast.
12186         * parse.c (write_dollar_variable): Remove cast.
12187         * block.h (struct block) <superblock>: Now const.
12188         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12189         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12190         (map_block): Make "block" const.
12191         * symfile.h (struct quick_symbol_functions)
12192         <map_matching_symbols>: Constify block argument to "callback".
12193         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12194         const.
12195         (find_pc_sect_compunit_symtab): Make "b" const.
12196         (find_symbol_at_address): Likewise.
12197         (search_symbols): Likewise.
12198         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12199         (dw2_debug_names_lookup_symbol): Likewise.
12200         (dw2_map_matching_symbols): Update.
12201         * p-valprint.c (pascal_val_print): Remove "block".
12202         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12203         (aux_add_nonlocal_symbols): Make "block" const.
12204         (resolve_subexp): Remove cast.
12205         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12206         const.
12207         (iterate_over_file_blocks): Likewise.
12208         * f-exp.y (%union) <bval>: Remove.
12209         * coffread.c (patch_opaque_types): Make "b" const.
12210         * spu-tdep.c (spu_catch_start): Make "block" const.
12211         * c-valprint.c (print_unpacked_pointer): Remove "block".
12212         * symmisc.c (dump_symtab_1): Make "b" const.
12213         (block_depth): Make "block" const.
12214         * d-exp.y (%union) <bval>: Remove.
12215         * cp-support.h (cp_lookup_rtti_type): Update.
12216         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12217         * psymtab.c (psym_lookup_symbol): Make "block" const.
12218         (maintenance_check_psymtabs): Make "b" const.
12219         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12220         (enumerate_locals, enumerate_args): Update.
12221         * python/py-symtab.c (stpy_global_block): Make "block" const.
12222         (stpy_static_block): Likewise.
12223         * inline-frame.c (block_starting_point_at): Make "new_block"
12224         const.
12225         * block.c (find_block_in_blockvector): Make return type const.
12226         (blockvector_for_pc_sect): Make "b" const.
12227         (find_block_in_blockvector): Make "b" const.
12228
12229 2019-03-23  Tom Tromey  <tom@tromey.com>
12230
12231         * varobj.c (varobj_create): Update.
12232         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12233         * printcmd.c (display_command, do_one_display): Don't reset
12234         innermost_block.
12235         * parser-defs.h (enum innermost_block_tracker_type): Move to
12236         expression.h.
12237         (innermost_block): Update comment.
12238         * parse.c (parse_exp_1): Add tracker_types parameter.
12239         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12240         tracker_types parameter.  Reset innermost_block.
12241         (parse_exp_in_context): Remove.
12242         (parse_expression_for_completion): Update.
12243         * objfiles.c (~objfile): Don't reset expression_context_block or
12244         innermost_block.
12245         * expression.h (enum innermost_block_tracker_type): Move from
12246         parser-defs.h.
12247         (parse_exp_1): Add tracker_types parameter.
12248         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12249         reset innermost_block.
12250
12251 2019-03-23  Tom Tromey  <tom@tromey.com>
12252
12253         * objfiles.h: Include bcache.h.
12254
12255 2019-03-23  Tom Tromey  <tom@tromey.com>
12256
12257         * linespec.c (get_current_search_block): Use
12258         scoped_restore_current_language.
12259         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12260
12261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12262             Jiong Wang  <jiong.wang@arm.com>
12263
12264         * aarch64-linux-tdep.c
12265         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12266         section.
12267         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12268
12269 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12270             Jiong Wang  <jiong.wang@arm.com>
12271
12272         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12273         instructions.
12274         (aarch64_analyze_prologue_test): Add PACIASP test.
12275         (aarch64_prologue_prev_register): Unmask PC value.
12276
12277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12278             Jiong Wang  <jiong.wang@arm.com>
12279
12280         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12281         (aarch64_dwarf2_prev_register): Unmask PC value.
12282         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12283         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12284         DW_CFA_AARCH64_negate_ra_state.
12285         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12286
12287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12288             Jiong Wang  <jiong.wang@arm.com>
12289
12290         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12291         registers.
12292         (aarch64_pseudo_register_name): Likewise.
12293         (aarch64_pseudo_register_type): Likewise.
12294         (aarch64_pseudo_register_reggroup_p): Likewise.
12295         (aarch64_gdbarch_init): Add pauth registers.
12296         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12297         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12298         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12299         (struct gdbarch_tdep): Add regnum for ra_state.
12300
12301 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12302             Jiong Wang  <jiong.wang@arm.com>
12303
12304         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12305
12306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12307             Jiong Wang  <jiong.wang@arm.com>
12308
12309         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12310         function.
12311         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12312         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12313         (aarch64_gdbarch_init): Add puth registers.
12314         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12315         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12316         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12317
12318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12319             Jiong Wang  <jiong.wang@arm.com>
12320
12321         * aarch64-linux-nat.c
12322         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12323         * aarch64-linux-tdep.c
12324         (aarch64_linux_core_read_description): Likewise.
12325         (aarch64_linux_get_hwcap): New function.
12326         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12327         (aarch64_linux_get_hwcap): New declaration.
12328
12329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12330             Jiong Wang  <jiong.wang@arm.com>
12331
12332         * aarch64-linux-nat.c
12333         (aarch64_linux_nat_target::read_description): Add pauth param.
12334         * aarch64-linux-tdep.c
12335         (aarch64_linux_core_read_description): Likewise.
12336         * aarch64-tdep.c (struct target_desc): Add in pauth.
12337         (aarch64_read_description): Add pauth param.
12338         (aarch64_gdbarch_init): Likewise.
12339         * aarch64-tdep.h (aarch64_read_description): Likewise.
12340         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12341         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12342         * features/Makefile: Add new files.
12343         * features/aarch64-pauth.c: New file.
12344         * features/aarch64-pauth.xml: New file.
12345
12346 2019-03-20  Tom Tromey  <tromey@adacore.com>
12347
12348         * infrun.c (handle_inferior_event): Rename from
12349         handle_inferior_event_1.  Create a scoped_value_mark.
12350         (handle_inferior_event): Remove.
12351
12352 2019-03-19  Tom Tromey  <tromey@adacore.com>
12353
12354         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12355         * infrun.h (print_stop_event): Add "displays" parameter.
12356         * infrun.c (print_stop_event): Add "displays" parameter.
12357
12358 2019-03-19  Pedro Alves  <palves@redhat.com>
12359
12360         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12361         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12362         to -1.  Fix TABs vs spaces.
12363         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12364         * tui/tui-out.h (tui_ui_out) Add intro comments.
12365         <m_line, m_start_of_line>: In-class initialize, and add describing
12366         comment.
12367
12368 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12369
12370         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12371         variable names.
12372         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12373
12374 2019-03-18  Pedro Alves  <palves@redhat.com>
12375             Eli Zaretskii <eliz@gnu.org>
12376
12377         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12378         m_line and m_start_of_line.
12379
12380 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12381
12382         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12383         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12384         it returns a newline.  This fixes a regression in TU mode, whereby
12385         the next line is output on the same screen line as the user input.
12386
12387 2019-03-18  Tom Tromey  <tromey@adacore.com>
12388
12389         * minsyms.c (minimal_symbol_reader::install): Remove call to
12390         obstack_blank.
12391
12392 2019-03-18  Pedro Alves  <palves@redhat.com>
12393
12394         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12395         New globals.
12396         (apply_style): New, factored out from ...
12397         (apply_ansi_escape): ... this.  Handle reverse video mode.
12398         (tui_set_reverse_mode): New function.
12399         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12400         * tui/tui-winsource.c (tui_show_source_line): Use
12401         tui_set_reverse_mode instead of setting A_STANDOUT.
12402         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12403         New setter methods.
12404
12405 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12406
12407         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12408         Handle tabs.
12409
12410 2019-03-18  Tom Tromey  <tromey@adacore.com>
12411
12412         * ada-lang.c (empty_array): Add "high" parameter.
12413         (ada_evaluate_subexp): Update.
12414
12415 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12416
12417         * unittests/string_view-selftests.c: Define
12418         _initialize_string_view_selftests unconditionally.
12419
12420 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12421
12422         PR gdb/24350
12423         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12424
12425 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12426
12427         PR gdb/24351
12428         * windows-nat.c (display_selector): Fix format specifiers.
12429
12430 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12431
12432         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12433         tui_refill_source_window instead of tui_refresh_win, to update the
12434         current execution line.  This fixes redisplay of the current line
12435         when stepping through the code with "next" or "step".
12436
12437 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12438
12439         * source-cache.c (source_cache::get_source_lines): Call
12440         find_source_lines to initialize s->nlines.  This fixes vertical
12441         scrolling of TUI source window when the DOWN arrow is pressed.
12442
12443 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12444
12445         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12446         linux-thread-db.c (_initialize_thread_db): Likewise.
12447
12448 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12449
12450         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12451         wclrtoeol in tui_show_source_line".  This reverts changes made in
12452         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12453
12454 2019-03-15  Tom Tromey  <tom@tromey.com>
12455
12456         * symtab.h (struct minimal_symbol): Derive from
12457         general_symbol_info.
12458         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12459         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12460         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12461         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12462         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12463         (MSYMBOL_SEARCH_NAME): Update.
12464         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12465         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12466         * minsyms.c (minimal_symbol_reader::record_full): Update.
12467
12468 2019-03-15  Tom Tromey  <tom@tromey.com>
12469
12470         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12471
12472 2019-03-15  Tom Tromey  <tom@tromey.com>
12473
12474         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12475         unique_xmalloc_ptr.
12476         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12477         Update.
12478         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12479         (build_minimal_symbol_hash_tables)
12480         (minimal_symbol_reader::install): Update.
12481
12482 2019-03-15  Tom Tromey  <tom@tromey.com>
12483
12484         * symtab.c (create_demangled_names_hash): Update.
12485         (symbol_set_names): Update.
12486         * objfiles.h (struct objfile_per_bfd_storage)
12487         <demangled_names_hash>: Now an htab_up.
12488         * objfiles.c (objfile_per_bfd_storage): Simplify.
12489
12490 2019-03-15  Tom Tromey  <tom@tromey.com>
12491
12492         * objfiles.h (struct objfile_per_bfd_storage): Declare
12493         destructor.
12494         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12495         New.
12496         (get_objfile_bfd_data): Use new.  Don't initialize
12497         language_of_main.
12498         (free_objfile_per_bfd_storage): Remove.
12499         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12500
12501 2019-03-15  Tom Tromey  <tom@tromey.com>
12502
12503         * symfile.c (reread_symbols): Update.
12504         * objfiles.c (objfile::objfile): Update.
12505         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12506         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12507         comment.
12508         (minimal_symbol_reader::install): Update.
12509         (terminate_minimal_symbol_table): Remove.
12510         * jit.c (jit_object_close_impl): Update.
12511
12512 2019-03-15  Tom Tromey  <tom@tromey.com>
12513
12514         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12515         initializations.
12516
12517 2019-03-15  Tom Tromey  <tom@tromey.com>
12518
12519         * objfiles.h (struct objfile_per_bfd_storage)
12520         <demangled_hash_languages>: Now a bitset.
12521         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12522         (lookup_minimal_symbol): Update.
12523
12524 2019-03-15  Tom Tromey  <tom@tromey.com>
12525
12526         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12527         Don't return the symbol.
12528         * coffread.c (record_minimal_symbol): Use record_full.
12529
12530 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12531
12532         The MS-Windows port of ncurses fails to switch to a color pair if
12533         one or both of the colors are the implicit default colors.  This
12534         change records the default colors when TUI is initialized, and
12535         then specifies them explicitly when a color pair uses the default
12536         colors.  This allows color styling in TUI mode on MS-Windows.
12537
12538         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12539         ncurses_norm_attr.
12540         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12541         colors in ncurses_norm_attr.
12542         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12543         "none", replace it with the default color recorded in
12544         ncurses_norm_attr.
12545
12546 2019-03-14  Tom Tromey  <tromey@adacore.com>
12547
12548         * source-cache.h (class source_cache) <get_source_lines>: Return
12549         std::string.
12550         * source-cache.c (source_cache::extract_lines): Handle case where
12551         first_pos==npos.  Return std::string.
12552         (source_cache::get_source_lines): Update.
12553
12554 2019-03-14  Tom Tromey  <tromey@adacore.com>
12555
12556         * NEWS: Add item for "style sources" commands.
12557         * source-cache.c (source_cache::get_source_lines): Check
12558         source_styling.
12559         * cli/cli-style.c (source_styling): New global.
12560         (_initialize_cli_style): Add "style sources" commands.
12561         (show_style_sources): New function.
12562         * cli/cli-style.h (source_styling): Declare.
12563
12564 2019-03-14  Pedro Alves  <palves@redhat.com>
12565             Tom Tromey  <tromey@adacore.com>
12566
12567         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12568         * tui/tui-winsource.c (tui_refill_source_window): New function,
12569         from...
12570         (tui_horizontal_source_scroll): ... here.  Move some logic.
12571         * cli/cli-style.c (set_style_enabled): Notify new observable.
12572         * tui/tui-hooks.c (tui_redisplay_source): New function.
12573         (tui_attach_detach_observers): Attach or detach
12574         tui_redisplay_source.
12575         * observable.h (source_styling_changed): New observable.
12576         * observable.c: Define source_styling_changed observable.
12577
12578 2019-03-13  Tom Tromey  <tromey@adacore.com>
12579
12580         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12581         (i386_gnu_nat_target::store_registers): Update.
12582         * target-debug.h (target_debug_print_std_string): New macro.
12583         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12584         * windows-tdep.c (display_one_tib): Update.
12585         * tui/tui-stack.c (tui_make_status_line): Update.
12586         * top.c (print_inferior_quit_action): Update.
12587         * thread.c (thr_try_catch_cmd): Update.
12588         (add_thread_with_info): Update.
12589         (thread_target_id_str): Update.
12590         (thr_try_catch_cmd): Update.
12591         (thread_command): Update.
12592         (thread_find_command): Update.
12593         * record-btrace.c (record_btrace_target::info_record)
12594         (record_btrace_resume_thread, record_btrace_target::resume)
12595         (record_btrace_cancel_resume, record_btrace_step_thread)
12596         (record_btrace_target::wait, record_btrace_target::wait)
12597         (record_btrace_target::wait, record_btrace_target::stop): Update.
12598         * progspace.c (print_program_space): Update.
12599         * process-stratum-target.c
12600         (process_stratum_target::thread_address_space): Update.
12601         * linux-fork.c (linux_fork_mourn_inferior)
12602         (detach_checkpoint_command, info_checkpoints_command)
12603         (linux_fork_context): Update.
12604         (linux_fork_detach): Update.
12605         (class scoped_switch_fork_info): Update.
12606         (delete_checkpoint_command): Update.
12607         * infrun.c (follow_fork_inferior): Update.
12608         (follow_fork_inferior): Update.
12609         (proceed_after_vfork_done): Update.
12610         (handle_vfork_child_exec_or_exit): Update.
12611         (follow_exec): Update.
12612         (displaced_step_prepare_throw): Update.
12613         (displaced_step_restore): Update.
12614         (start_step_over): Update.
12615         (resume_1): Update.
12616         (clear_proceed_status_thread): Update.
12617         (proceed): Update.
12618         (print_target_wait_results): Update.
12619         (do_target_wait): Update.
12620         (context_switch): Update.
12621         (stop_all_threads): Update.
12622         (restart_threads): Update.
12623         (finish_step_over): Update.
12624         (handle_signal_stop): Update.
12625         (switch_back_to_stepped_thread): Update.
12626         (keep_going_pass_signal): Update.
12627         (print_exited_reason): Update.
12628         (normal_stop): Update.
12629         * inferior.c (inferior_pid_to_str): Change return type.
12630         (print_selected_inferior): Update.
12631         (add_inferior): Update.
12632         (detach_inferior): Update.
12633         * dummy-frame.c (fprint_dummy_frames): Update.
12634         * dcache.c (dcache_info_1): Update.
12635         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12636         (btrace_fetch, btrace_clear): Update.
12637         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12638         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12639         type.
12640         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12641         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12642         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12643         * gdbarch.c, gdbarch.h: Rebuild.
12644         * gdbarch.sh (core_pid_to_str): Change return type.
12645         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12646         return type.
12647         (windows_nat_target::pid_to_str): Change return type.
12648         (windows_delete_thread): Update.
12649         (windows_nat_target::attach): Update.
12650         (windows_nat_target::files_info): Update.
12651         * target-delegates.c: Rebuild.
12652         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12653         return type.
12654         (sol_thread_target::pid_to_str): Change return type.
12655         * remote.c (class remote_target) <pid_to_str>: Change return
12656         type.
12657         (remote_target::pid_to_str): Change return type.
12658         (extended_remote_target::attach, remote_target::remote_stop_ns)
12659         (remote_target::remote_notif_remove_queued_reply)
12660         (remote_target::push_stop_reply, remote_target::disable_btrace):
12661         Update.
12662         (extended_remote_target::attach): Update.
12663         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12664         type.
12665         (gdbsim_target::pid_to_str): Change return type.
12666         * ravenscar-thread.c (struct ravenscar_thread_target)
12667         <pid_to_str>: Change return type.
12668         (ravenscar_thread_target::pid_to_str): Change return type.
12669         * procfs.c (class procfs_target) <pid_to_str>: Change return
12670         type.
12671         (procfs_target::pid_to_str): Change return type.
12672         (procfs_target::attach): Update.
12673         (procfs_target::detach): Update.
12674         (procfs_target::fetch_registers): Update.
12675         (procfs_target::store_registers): Update.
12676         (procfs_target::wait): Update.
12677         (procfs_target::files_info): Update.
12678         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12679         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12680         return type.
12681         (nto_procfs_target::pid_to_str): Change return type.
12682         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12683         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12684         return type.
12685         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12686         (exit_lwp): Update.
12687         (attach_proc_task_lwp_callback, get_detach_signal)
12688         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12689         (linux_nat_target::resume, wait_lwp, stop_callback)
12690         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12691         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12692         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12693         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12694         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12695         type.
12696         (inf_ptrace_target::attach): Update.
12697         (inf_ptrace_target::files_info): Update.
12698         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12699         type.
12700         (go32_nat_target::pid_to_str): Change return type.
12701         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12702         (gnu_nat_target::wait): Update.
12703         (gnu_nat_target::wait): Update.
12704         (gnu_nat_target::resume): Update.
12705         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12706         (fbsd_nat_target::wait): Update.
12707         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12708         type.
12709         (darwin_nat_target::attach): Update.
12710         * corelow.c (class core_target) <pid_to_str>: Change return type.
12711         (core_target::pid_to_str): Change return type.
12712         * target.c (normal_pid_to_str): Change return type.
12713         (default_pid_to_str): Likewise.
12714         (target_pid_to_str): Change return type.
12715         (target_translate_tls_address): Update.
12716         (target_announce_detach): Update.
12717         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12718         return type.
12719         (bsd_uthread_target::pid_to_str): Change return type.
12720         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12721         type.
12722         (bsd_kvm_target::pid_to_str): Change return type.
12723         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12724         return type.
12725         (aix_thread_target::pid_to_str): Change return type.
12726         * target.h (struct target_ops) <pid_to_str>: Change return type.
12727         (target_pid_to_str, normal_pid_to_str): Likewise.
12728         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12729         type.
12730         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12731         type.
12732         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12733         return type.
12734         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12735         type.
12736         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12737         type.
12738         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12739         return type.
12740
12741 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12742
12743         * NEWS: Mention that the new default MI version is 3.  Mention
12744         changes to the output of commands and events that deal with
12745         multi-location breakpoints.
12746         * breakpoint.c: Include "mi/mi-out.h".
12747         (print_one_breakpoint): Change output syntax if using MI version
12748         >= 3.
12749         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12750         New.
12751         (mi_multi_location_breakpoint_output_fixed): New.
12752         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12753         (mi_cmd_fix_multi_location_breakpoint_output): New.
12754         (mi_multi_location_breakpoint_output_fixed): New.
12755         * mi/mi-cmds.c (mi_cmds): Register command
12756         -fix-multi-location-breakpoint-output.
12757         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12758         interpreter "mi".
12759
12760 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12761
12762         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12763         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12764         instantiate mi_ui_out based on interpreter name.
12765         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12766         * mi/mi-main.c (mi_load_progress): Likewise.
12767
12768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12769
12770         * NEWS: Combine separate "New targets" sections for 8.3.
12771
12772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12773
12774         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12775         (ppcfbsd_init_abi): Install gdbarch
12776         "fetch_tls_load_module_address" and "get_thread_local_address"
12777         methods.
12778
12779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12780
12781         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12782         (riscv_fbsd_init_abi): Install gdbarch
12783         "fetch_tls_load_module_address" and "get_thread_local_address"
12784         methods.
12785
12786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12787
12788         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12789         (i386fbsd_init_abi): Install gdbarch
12790         "fetch_tls_load_module_address" and "get_thread_local_address"
12791         methods.
12792
12793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12794
12795         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12796         (amd64fbsd_init_abi): Install gdbarch
12797         "fetch_tls_load_module_address" and "get_thread_local_address"
12798         methods.
12799
12800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12801
12802         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12803         (struct fbsd_pspace_data): New type.
12804         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12805         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12806         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12807         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12808         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12809
12810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12811
12812         * gdbtypes.c (lookup_struct_elt): New function.
12813         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12814         * gdbtypes.h (struct struct_elt): New type.
12815         (lookup_struct_elt): New prototype.
12816
12817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12818
12819         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12820         remove disabled code block.
12821
12822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12823
12824         * gdbarch.sh (get_thread_local_address): New method.
12825         * gdbarch.h, gdbarch.c: Regenerate.
12826         * target.c (target_translate_tls_address): Use
12827         gdbarch_get_thread_local_address if present instead of
12828         target::get_thread_local_address.
12829
12830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12831
12832         * target.h (target::get_thread_local_address): Update comment.
12833
12834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12835
12836         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12837         objfile->separate_debug_objfile_backlink if not NULL.
12838
12839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12840
12841         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12842         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12843         (amd64bsd_store_inferior_registers): Likewise.
12844         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12845         Enable segment base registers.
12846         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12847         PT_GETFSBASE and PT_GETGSBASE.
12848         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12849         PT_SETGSBASE.
12850         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12851         segment base registers.
12852         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12853
12854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12855
12856         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12857         Update calls to i386_target_description to add 'segments'
12858         parameter.
12859         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12860         add segment base registers.
12861         * arch/i386.c (i386_create_target_description): Add 'segments'
12862         parameter to enable segment base registers.
12863         * arch/i386.h (i386_create_target_description): Likewise.
12864         * features/i386/32bit-segments.xml: New file.
12865         * features/i386/32bit-segments.c: Generate.
12866         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12867         call to i386_target_description to add 'segments' parameter.
12868         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12869         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12870         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12871         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12872         if feature is present.
12873         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12874         Add 'segments' parameter to call to i386_target_description.
12875         (i386_target_description): Add 'segments' parameter to enable
12876         segment base registers.
12877         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12878         to call to i386_target_description.
12879         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12880         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12881         Define I386_NUM_REGS.
12882         (i386_target_description): Add 'segments' parameter to enable
12883         segment base registers.
12884
12885 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12886
12887         PR/24325
12888         * source-cache.c: #undef open and close, to avoid unresolved
12889         externals during linking.
12890
12891 2019-03-12  Tom Tromey  <tromey@adacore.com>
12892
12893         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12894         const.  Add initializers.
12895         (_initialize_remote): Don't initialize ptid globals.
12896
12897 2019-03-12  Pedro Alves  <palves@redhat.com>
12898
12899         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12900
12901 2019-03-12  Pedro Alves  <palves@redhat.com>
12902
12903         * cp-name-parser.y (main): Remove unused 'len' variable.
12904
12905 2019-03-12  Tom Tromey  <tromey@adacore.com>
12906
12907         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12908         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12909
12910 2019-03-12  Tom Tromey  <tromey@adacore.com>
12911
12912         * linux-nat.c (iterate_over_lwps): Update.
12913         (stop_callback): Remove parameter.
12914         (stop_wait_callback, detach_callback, resume_set_callback)
12915         (select_singlestep_lwp_callback, set_ignore_sigint)
12916         (status_callback, resumed_callback, resume_clear_callback)
12917         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12918         data parameter.
12919         (linux_nat_target::detach, linux_nat_target::resume)
12920         (linux_stop_and_wait_all_lwps, select_event_lwp)
12921         (linux_nat_filter_event, linux_nat_wait_1)
12922         (linux_nat_target::kill, linux_nat_target::stop)
12923         (linux_nat_target::stop): Update.
12924         (linux_nat_resume_callback): Change type.
12925         (resume_stopped_resumed_lwps, count_events_callback)
12926         (select_event_lwp_callback): Likewise.
12927         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12928         * arm-linux-nat.c (struct update_registers_data): Remove.
12929         (update_registers_callback): Change type.
12930         (arm_linux_insert_hw_breakpoint1): Update.
12931         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12932         parameter.
12933         (x86_linux_dr_set_addr): Update.
12934         (x86_linux_dr_set_control): Update.
12935         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12936         (iterate_over_lwps): Use gdb::function_view.
12937         * nat/aarch64-linux-hw-point.c (struct
12938         aarch64_dr_update_callback_param): Remove.
12939         (debug_reg_change_callback): Change type.
12940         (aarch64_notify_debug_reg_change): Update.
12941         * s390-linux-nat.c (s390_refresh_per_info): Update.
12942
12943 2019-03-11  Tom Tromey  <tromey@adacore.com>
12944
12945         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12946         redundant assignment to "this_cu".
12947
12948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12949
12950         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12951
12952 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12953
12954         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12955         from...
12956         (rank_one_type): ... this.
12957
12958 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12959
12960         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12961         from...
12962         (rank_one_type): ... this.
12963
12964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12965
12966         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12967         from...
12968         (rank_one_type): ... this.
12969
12970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12971
12972         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12973         from...
12974         (rank_one_type): ... this.
12975
12976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12977
12978         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12979         from...
12980         (rank_one_type): ... this.
12981
12982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12983
12984         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12985         from...
12986         (rank_one_type): ... this.
12987
12988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12989
12990         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12991         from...
12992         (rank_one_type): ... this.
12993
12994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12995
12996         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12997         from...
12998         (rank_one_type): ... this.
12999
13000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13001
13002         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13003         from...
13004         (rank_one_type): ... this.
13005
13006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13007
13008         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13009         from...
13010         (rank_one_type): ... this.
13011
13012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13013
13014         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13015         from...
13016         (rank_one_type): ... this.
13017
13018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13019
13020         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13021         from...
13022         (rank_one_type): ... this.
13023
13024 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13025
13026         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13027         inferior-events' shows the example events.
13028
13029 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13030
13031         Support styling on native MS-Windows console
13032
13033         PR/24315
13034         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13035         on MS-Windows if $TERM is not defined.
13036
13037         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13038
13039         * posix-hdep.c (gdb_console_fputs):
13040         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13041         functions.
13042         * ui-file.h (gdb_console_fputs): Add prototype.
13043
13044         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13045         back to fputs only if the former returns zero.
13046
13047 2019-03-07  Tom Tromey  <tom@tromey.com>
13048
13049         * symmisc.c (print_symbol_bcache_statistics): Update.
13050         (print_objfile_statistics): Update.
13051         * symfile.c (allocate_symtab): Update.
13052         * stabsread.c: Don't include bcache.h.
13053         * psymtab.h (struct psymbol_bcache): Don't declare.
13054         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13055         (psymbol_bcache_init, psymbol_bcache_free)
13056         (psymbol_bcache_get_bcache): Don't declare.
13057         * psymtab.c (struct psymbol_bcache): Remove.
13058         (psymtab_storage::psymtab_storage): Update.
13059         (psymtab_storage::~psymtab_storage): Update.
13060         (psymbol_bcache_init, psymbol_bcache_free)
13061         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13062         (add_psymbol_to_bcache): Update.
13063         (allocate_psymtab): Update.
13064         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13065         macro_cache>: No longer pointers.
13066         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13067         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13068         * macrotab.c (macro_bcache): Update.
13069         * macroexp.c: Don't include bcache.h.
13070         * gdbtypes.c (check_types_worklist): Update.
13071         (types_deeply_equal): Remove TRY/CATCH.  Update.
13072         * elfread.c (elf_symtab_read): Update.
13073         * dwarf2read.c: Don't include bcache.h.
13074         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13075         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13076         (print_bcache_statistics, bcache_memory_used): Don't declare.
13077         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13078         methods.  Rename all data members.
13079         * bcache.c (struct bcache): Move to bcache.h.
13080         (bcache::expand_hash_table): Rename from expand_hash_table.
13081         (bcache): Remove.
13082         (bcache::insert): Rename from bcache_full.
13083         (bcache::compare): Rename from bcache_compare.
13084         (bcache_xmalloc): Remove.
13085         (bcache::~bcache): Rename from bcache_xfree.
13086         (bcache::print_statistics): Rename from print_bcache_statistics.
13087         (bcache::memory_used): Rename from bcache_memory_used.
13088
13089 2019-03-07  Pedro Alves  <palves@redhat.com>
13090
13091         * infrun.c (normal_stop): Also check for
13092         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13093
13094 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13095
13096         * f-lang.c (value_from_host_double): Moved to...
13097         * value.c (value_from_host_double): ...here.
13098         * value.h (value_from_host_double): Declare.
13099         * guile/scm-math.c (vlscm_convert_typed_number): Use
13100         value_from_host_double.
13101         (vlscm_convert_number): Likewise.
13102         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13103         * python/py-value.c (convert_value_from_python): Likewise.
13104
13105 2019-03-06  Tom Tromey  <tom@tromey.com>
13106
13107         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13108
13109 2019-03-06  Tom Tromey  <tom@tromey.com>
13110
13111         * utils.h (free_current_contents): Don't declare.
13112         * utils.c (free_current_contents): Remove.
13113
13114 2019-03-06  Tom Tromey  <tom@tromey.com>
13115
13116         * top.c (quit_force): Update.
13117         * main.c (captured_command_loop): Update.
13118         * common/new-op.c (operator new): Update.
13119         * common/common-exceptions.c (struct catcher)
13120         <save_cleanup_chain>: Remove member.
13121         (exceptions_state_mc_init): Update.
13122         (exception_try_scope_entry): Return nullptr.
13123         (exception_try_scope_exit, exception_rethrow)
13124         (throw_exception_sjlj, throw_exception_cxx): Update.
13125         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13126         (all_cleanups, do_cleanups, discard_cleanups)
13127         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13128         (restore_cleanups, restore_final_cleanups): Don't declare.
13129         (do_final_cleanups): Remove parameter.
13130         * common/cleanups.c (cleanup_chain, make_cleanup)
13131         (make_cleanup_dtor, all_cleanups, do_cleanups)
13132         (discard_my_cleanups, discard_cleanups)
13133         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13134         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13135         (null_cleanup): Remove.
13136         (do_final_cleanups): Remove parameter.
13137
13138 2019-03-06  Tom Tromey  <tom@tromey.com>
13139
13140         * remote.c (remote_target::remote_parse_stop_reply): Use
13141         unique_xmalloc_ptr.
13142
13143 2019-03-06  Tom Tromey  <tom@tromey.com>
13144
13145         * stabsread.c (struct stabs_field_info): Rename from field_info.
13146         <list, fnlist>: Add initializers.
13147         <obstack>: New member.
13148         (read_member_functions, read_struct_fields, read_baseclasses):
13149         Allocate on obstack.  Don't use cleanups.
13150         (read_one_struct_field, read_member_functions, read_struct_fields)
13151         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13152         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13153         (read_struct_type): Update.
13154
13155 2019-03-06  Tom Tromey  <tom@tromey.com>
13156
13157         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13158         * common/filestuff.h (make_cleanup_close): Don't declare.
13159         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13160         Remove.
13161
13162 2019-03-06  Tom Tromey  <tom@tromey.com>
13163
13164         * solib-aix.c: Use make_scope_exit.
13165
13166 2019-03-06  Tom Tromey  <tom@tromey.com>
13167
13168         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13169         Use make_scope_exit.
13170
13171 2019-03-06  Tom Tromey  <tom@tromey.com>
13172
13173         * solib-svr4.c (disable_probes_interface): Remove parameter.
13174         (svr4_handle_solib_event): Use make_scope_exit.
13175
13176 2019-03-06  Tom Tromey  <tom@tromey.com>
13177
13178         * remote.c (struct stop_reply_deleter): Remove.
13179         (stop_reply_up): Update.
13180         (struct stop_reply): Derive from notif_event.  Don't typedef.
13181         <regcache>: Now a std::vector.
13182         (stop_reply_xfree): Remove.
13183         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13184         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13185         (remote_target::discard_pending_stop_replies): Use delete.
13186         (remote_target::remote_parse_stop_reply): Update.
13187         (remote_target::process_stop_reply): Update.
13188         * remote-notif.h (struct notif_event): Add virtual destructor.
13189         Remove "dtr" member.
13190         (struct notif_client) <alloc_event>: Return a unique_ptr.
13191         (notif_event_xfree): Don't declare.
13192         (notif_event_up): New typedef.
13193         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13194         (notif_event_xfree, do_notif_event_xfree): Remove.
13195         (remote_notif_state_xfree): Update.
13196
13197 2019-03-06  Tom Tromey  <tom@tromey.com>
13198
13199         * infrun.c (displaced_step_clear_cleanup): Now a
13200         forward_scope_exit type.
13201         (displaced_step_prepare_throw): Update.
13202         (displaced_step_fixup): Update.
13203
13204 2019-03-06  Tom Tromey  <tom@tromey.com>
13205
13206         * inferior.h (class inferior): Update comment.
13207         * gdbthread.h (class thread_info): Update comment.
13208
13209 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13210             Tom Tromey  <tom@tromey.com>
13211
13212         * stabsread.h (struct stab_section_list): Remove.
13213         (coffstab_build_psymtabs): Update.
13214         * dbxread.c (symbuf_sections): Now a std::vector.
13215         (sect_idx): New global.
13216         (fill_symbuf): Update.
13217         (coffstab_build_psymtabs): Change type of stabsects parameter.
13218         Update.
13219         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13220         std::vector.
13221         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13222         (coff_locate_sections): Update.
13223         (coff_symfile_read): Remove cleanups.  Update.
13224         (init_stringtab): Add storage parameter.
13225         (free_stringtab, free_stringtab_cleanup): Remove.
13226         (init_lineno): Add storage parameter.
13227         (free_linetab, free_linetab_cleanup): Remove.
13228
13229 2019-03-06  Pedro Alves  <palves@redhat.com>
13230
13231         * linux-fork.c (fork_info::clobber_regs): Delete.
13232         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13233         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13234         comment.  Adjust.
13235         (scoped_switch_fork_info::scoped_switch_fork_info)
13236         (checkpoint_command, linux_fork_context): Adjust
13237         fork_save_infrun_state calls.
13238
13239 2019-03-06  Pedro Alves  <palves@redhat.com>
13240
13241         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13242         (inf_has_multiple_threads): Return 'bool' and rewrite using
13243         inferior_info::threads().
13244
13245 2019-03-06  Pedro Alves  <palves@redhat.com>
13246
13247         * linux-fork.c: Include <list>.
13248         (fork_list): Now a std::list instance.
13249         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13250         (forks_exist_p, find_last_fork): Adjust.
13251         (new_fork): Delete.
13252         (one_fork_p): New.
13253         (add_fork): Adjust.
13254         (free_fork): Delete, folded into fork_info::~fork_info().
13255         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13256         Adjust.
13257         (init_fork_list): Delete.
13258         (linux_fork_killall, linux_fork_mourn_inferior)
13259         (linux_fork_detach, info_checkpoints_command): Adjust.
13260         (_initialize_linux_fork): No longer call init_fork_list.
13261
13262 2019-03-06  Pedro Alves  <palves@redhat.com>
13263
13264         * linux-fork.c (new_fork): New, split out of ...
13265         (add_fork): ... this.  Return void.  Move "first fork" special
13266         case from here, to ...
13267         (checkpoint_command): ... here.
13268         * linux-linux.h (add_fork): Return void.
13269
13270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13271
13272         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13273
13274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13275             Chris January  <chris.january@arm.com>
13276             David Lecomber  <david.lecomber@arm.com>
13277
13278         * f-exp.y: New token, UNOP_INTRINSIC.
13279         (exp): New pattern using UNOP_INTRINSIC token.
13280         (f77_keywords): Add 'abs' keyword.
13281         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13282         (value_from_host_double): New function.
13283         (evaluate_subexp_f): Support UNOP_ABS.
13284
13285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13286
13287         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13288         types.
13289
13290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13291
13292         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13293         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13294         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13295
13296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13297
13298         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13299
13300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13301             Chris January  <chris.january@arm.com>
13302
13303         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13304         * f-exp.y: Define 'KIND' token.
13305         (exp): New pattern for KIND expressions.
13306         (ptype): Handle types with a kind extension.
13307         (direct_abs_decl): Extend to spot kind extensions.
13308         (f77_keywords): Add 'kind' to the list.
13309         (push_kind_type): New function.
13310         (convert_to_kind_type): New function.
13311         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13312         * parse.c (operator_length_standard): Likewise.
13313         * parser-defs.h (enum type_pieces): Add tp_kind.
13314         * std-operator.def: Add UNOP_KIND.
13315
13316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13317
13318         * f-exp.y (f_parse): Set yydebug.
13319
13320 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13321
13322         * f-lang.c (evaluate_subexp_f): New function.
13323         (exp_descriptor_f): New global.
13324         (f_language_defn): Use exp_descriptor_f instead of
13325         exp_descriptor_standard.
13326
13327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13328
13329         * f-exp.y (struct token): Add comments.
13330         (dot_ops): Remove uppercase versions and the end marker.
13331         (f77_keywords): Likewise.
13332         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13333         entries in the dot_ops array are case insensitive, and use
13334         strncasecmp to compare strings.  Also some whitespace cleanup in
13335         this area.  Similar for the f77_keywords array, except entries in
13336         this list might be case sensitive.
13337
13338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13339
13340         * f-exp.y (struct f77_boolean_val): Add comments.
13341         (boolean_values): Remove uppercase versions, and end marker.
13342         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13343         and use strncasecmp to achieve case insensitivity.  Additionally,
13344         perform whitespace cleanup around this code.
13345
13346 2019-03-06  Tom Tromey  <tromey@adacore.com>
13347
13348         * remote-sim.c (gdbsim_target_open): Use result of
13349         gdb_argv::release.
13350
13351 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13352         Dirk Schubert  <dirk.schubert@arm.com>
13353         Chris January  <chris.january@arm.com>
13354
13355         * eval.c (evaluate_subexp_standard): Call Fortran argument
13356         wrapping logic.
13357         * f-lang.c (struct value): A value which can be passed into a
13358         Fortran function call.
13359         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13360         where appropriate.
13361         (struct type): Value ready for a Fortran function call.
13362         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13363         is needed.
13364         * f-lang.h (fortran_argument_convert): Declaration.
13365         (fortran_preserve_arg_pointer): Declaration.
13366         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13367
13368 2019-03-05  Tom Tromey  <tromey@adacore.com>
13369
13370         * python/py-prettyprint.c (print_string_repr): Remove #if.
13371         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13372
13373 2019-03-05  Tom Tromey  <tromey@adacore.com>
13374
13375         * target.c (the_dummy_target): Move later.  Change type to
13376         "dummy_target".
13377         (initialize_targets): Don't initialize the_dummy_target.
13378
13379 2019-03-05  Tom Tromey  <tromey@adacore.com>
13380
13381         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13382         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13383
13384 2019-03-05  Tom Tromey  <tromey@adacore.com>
13385
13386         * windows-nat.c (windows_nat_target::attach)
13387         (windows_nat_target::detach): Don't call gdb_flush.
13388         * valprint.c (generic_val_print, val_print, val_print_string):
13389         Don't call gdb_flush.
13390         * utils.c (defaulted_query): Don't call gdb_flush.
13391         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13392         * target.c (target_announce_detach): Don't call gdb_flush.
13393         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13394         * remote.c (extended_remote_target::attach): Don't call
13395         gdb_flush.
13396         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13397         * printcmd.c (do_examine): Don't call gdb_flush.
13398         (info_display_command): Don't call gdb_flush.
13399         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13400         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13401         * memattr.c (info_mem_command): Don't call gdb_flush.
13402         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13403         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13404         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13405         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13406         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13407         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13408         (gnu_nat_target::detach): Don't call gdb_flush.
13409         * f-valprint.c (f_val_print): Don't call gdb_flush.
13410         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13411         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13412         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13413         gdb_flush.
13414         * c-valprint.c (c_val_print): Don't call gdb_flush.
13415         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13416
13417 2019-03-05  Tom Tromey  <tromey@adacore.com>
13418
13419         * varobj.c (update_dynamic_varobj_children): Update.
13420         (install_default_visualizer): Use reset, not release.
13421         * value.c (set_internalvar): Update.
13422         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13423         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13424         ATTRIBUTE_UNUSED_RESULT.
13425
13426 2019-03-05  Tom Tromey  <tromey@adacore.com>
13427
13428         * remote.c (class scoped_remote_fd) <release>: Add
13429         ATTRIBUTE_UNUSED_RESULT.
13430
13431 2019-03-05  Tom Tromey  <tromey@adacore.com>
13432
13433         * macroexp.c (struct macro_buffer) <release>: Add
13434         ATTRIBUTE_UNUSED_RESULT.
13435
13436 2019-03-05  Tom Tromey  <tromey@adacore.com>
13437
13438         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13439         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13440         ATTRIBUTE_UNUSED_RESULT.
13441
13442 2019-03-05  Tom Tromey  <tromey@adacore.com>
13443
13444         * common/scoped_fd.h (class scoped_fd) <release>: Add
13445         ATTRIBUTE_UNUSED_RESULT.
13446
13447 2019-03-05  Tom Tromey  <tromey@adacore.com>
13448
13449         * parser-defs.h (struct parser_state) <release>: Add
13450         ATTRIBUTE_UNUSED_RESULT.
13451
13452 2019-03-05  Tom Tromey  <tromey@adacore.com>
13453
13454         * utils.h (class gdb_argv) <release>: Add
13455         ATTRIBUTE_UNUSED_RESULT.
13456         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13457
13458 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13459
13460         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13461         for-loop range, to avoid compiler warnings.
13462
13463         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13464         avoid compiler warnings about unused variables.
13465
13466         * NEWS: Mention end of support for native debugging on MS-Windows
13467         before XP.
13468
13469         PR gdb/24292
13470         * common/netstuff.c:
13471         * gdbserver/gdbreplay.c
13472         * gdbserver/remote-utils.c:
13473         * ser-tcp.c:
13474         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13475         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13476         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13477         'getaddrinfo' and 'freeaddrinfo' were not available before
13478         Windows XP, and mingw.org's MinGW headers by default define
13479         _WIN32_WINNT to 0x500.
13480
13481 2019-03-01  Gary Benson <gbenson@redhat.com>
13482
13483         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13484
13485 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13486             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13487
13488         PR gdb/8527
13489         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13490         set_sigint_trap, clear_sigint_trap.
13491
13492 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13493
13494         * target.c (target_detach): Clear the regcache and the
13495         frame cache.
13496
13497 2019-02-27  Pedro Alves  <palves@redhat.com>
13498
13499         * utils.c (set_screen_size): When we cap the height/width sizes,
13500         tweak the corresponding command variable to show "unlimited":
13501
13502 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13503             Pedro Alves  <palves@redhat.com>
13504
13505         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13506         before calling rl_set_screen_size.
13507
13508 2019-02-27  Tom Tromey  <tromey@adacore.com>
13509
13510         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13511         define.
13512         * python/py-value.c: Remove Python 2.4 workaround.
13513         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13514         workaround.
13515         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13516         Python 2.4 workaround.
13517         * python/python-internal.h: Remove Python 2.4 comment.
13518         (Py_ssize_t): Don't define.
13519         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13520         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13521         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13522         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13523         * python/python.c (do_start_initialization): Remove Python 2.4
13524         workaround.
13525         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13526         (print_children): Remove Python 2.4 workaround.
13527         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13528         workaround.
13529         (CHARBUFFERPROC_NAME): Remove.
13530         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13531         Python 2.4 workaround.
13532
13533 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13534
13535         * NEWS: Note minimum Python version.
13536
13537 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13538
13539         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13540         code from these functions.  Remove corresponding ifdefs.  Use
13541         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13542         Remove gotos and target of gotos.
13543         (infpy_search_memory): Likewise.
13544
13545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13546
13547         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13548         (hppa_gdbarch_init): Don't register deleted functions with
13549         gdbarch.
13550
13551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13552
13553         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13554         (h8300_unwind_sp): Delete.
13555         (h8300_dummy_id): Delete.
13556         (h8300_gdbarch_init): Don't register deleted functions with
13557         gdbarch.
13558
13559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13560
13561         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13562         (ft32_unwind_pc): Delete.
13563         (ft32_unwind_sp): Delete.
13564         (ft32_gdbarch_init): Don't register deleted functions with
13565         gdbarch.
13566
13567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13568
13569         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13570         (frv_unwind_pc): Delete.
13571         (frv_unwind_sp): Delete.
13572         (frv_gdbarch_init): Don't register deleted functions with
13573         gdbarch.
13574
13575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13576
13577         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13578         (riscv_unwind_pc): Delete.
13579         (riscv_unwind_sp): Delete.
13580         (riscv_gdbarch_init): Don't register deleted functions with
13581         gdbarch.
13582
13583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13584
13585         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13586         (csky_unwind_pc): Delete.
13587         (csky_unwind_sp): Delete.
13588         (csky_gdbarch_init): Don't register deleted functions with
13589         gdbarch.
13590
13591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13592
13593         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13594         (cris_unwind_pc): Delete.
13595         (cris_unwind_sp): Delete.
13596         (cris_gdbarch_init): Don't register deleted functions with
13597         gdbarch.
13598
13599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13600
13601         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13602         (bfin_unwind_pc): Delete.
13603         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13604
13605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13606
13607         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13608         (arm_unwind_pc): Delete.
13609         (arm_unwind_sp): Delete.
13610         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13611
13612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13613
13614         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13615         (arc_unwind_pc): Delete.
13616         (arc_unwind_sp): Delete.
13617         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13618
13619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13620
13621         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13622         (alpha_unwind_pc): Delete.
13623         (alpha_gdbarch_init): Don't register deleted functions with
13624         gdbarch.
13625
13626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13627
13628         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13629         (aarch64_unwind_pc): Delete.
13630         (aarch64_unwind_sp): Delete.
13631         (aarch64_gdbarch_init): Don't register deleted functions with
13632         gdbarch.
13633
13634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13635
13636         * gdbtypes.c (type_align): Don't consider static members when
13637         computing structure alignment.
13638
13639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13640
13641         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13642         return 0 for other types.
13643         * arch-utils.c (default_type_align): Always return 0.
13644         * gdbarch.h: Regenerate.
13645         * gdbarch.sh (type_align): Extend comment.
13646         * gdbtypes.c (type_align): Add additional comments, always call
13647         gdbarch_type_align before applying the default rules.
13648         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13649         generic code will then apply a suitable default.
13650         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13651         types, return 0 for other types.
13652
13653 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13654
13655         * NEWS: Create a new section for the next release branch.
13656         Rename the section of the current branch, now that it has
13657         been cut.
13658
13659 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13660
13661         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13662         * version.in: Bump version to 8.3.50.DATE-git.
13663
13664 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13665
13666         * aix-thread.c (ptid_cmp): Remove unused variable.
13667         (get_signaled_thread): Likewise.
13668         (store_regs_user_thread): Likewise.
13669         (store_regs_kernel_thread): Likewise.
13670         (fetch_regs_kernel_thread): Remove shadowed variable.
13671
13672 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13673
13674         * features/riscv/32bit-cpu.xml: Add register numbers.
13675         * features/riscv/32bit-fpu.c: Regenerate.
13676         * features/riscv/32bit-fpu.xml: Add register numbers.
13677         * features/riscv/64bit-cpu.xml: Add register numbers.
13678         * features/riscv/64bit-fpu.c: Regenerate.
13679         * features/riscv/64bit-fpu.xml: Add register numbers.
13680
13681 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13682
13683         * NEWS: Mention two argument form of gdb.Value constructor.
13684         * python/py-value.c (convert_buffer_and_type_to_value): New
13685         function.
13686         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13687         Add support for handling an optional second argument.  Call
13688         convert_buffer_and_type_to_value as appropriate.
13689         * python/python-internal.h (Py_buffer_deleter): New struct.
13690         (Py_buffer_up): New typedef.
13691
13692 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13693
13694         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13695         instead of releasing ownership.
13696
13697 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13698
13699         * dwarf2read.c (open_and_init_dwp_file): Call
13700         elf_numsections instead of bfd_count_sections to initialize
13701         dwp_file->num_sections.
13702
13703 2019-02-25  Tom Tromey  <tromey@adacore.com>
13704
13705         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13706
13707 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13708
13709         * gcore.in: Add '--readnever' option when invoking GDB.
13710
13711 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13712
13713         * MAINTAINERS: Update my email address.
13714
13715 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13716
13717         * build-id.c (build_id_to_debug_bfd_1): New function.
13718         (build_id_to_debug_bfd): Look for separate debug file in
13719         sysroot.
13720
13721 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13722
13723         * gdbarch.sh: Update the copyright year range that is placed into
13724         generated files.
13725
13726 2019-02-22  Keith Seitz  <keiths@redhat.com>
13727
13728         PR symtab/23853
13729         * linespec.c (create_sals_line_offset): Search for the default
13730         symtab's filename instead of its fullname.
13731
13732 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13733
13734         * NEWS: Update style defaults.
13735
13736 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13737
13738         * main.c (captured_main_1): Disable styling in batch mode.
13739
13740 2019-02-20  Tom Tromey  <tom@tromey.com>
13741
13742         * symtab.c (symtab_symbol_info): Fix typos.
13743
13744 2019-02-20  Tom Tromey  <tromey@adacore.com>
13745
13746         * findcmd.c (_initialize_mem_search): Use upper case for
13747         metasyntactic variables.
13748
13749 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13750
13751         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13752         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13753
13754 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13755
13756         * top.h (source_file_name): Change to std::string.
13757         * top.c (source_file_name): Likewise.
13758         (command_line_input): Adjust.
13759         * cli/cli-script.c (script_from_file): Adjust.
13760
13761 2019-02-19  Tom Tromey  <tromey@adacore.com>
13762
13763         * ravenscar-thread.c
13764         (ravenscar_thread_target::update_thread_list): Don't call
13765         ada_build_task_list.
13766         * ada-lang.h (ada_build_task_list): Don't declare.
13767         * ada-tasks.c (struct ada_tasks_inferior_data)
13768         <task_list_valid_p>: Now bool.
13769         (read_known_tasks, ada_task_list_changed)
13770         (ada_tasks_invalidate_inferior_data): Update.
13771         (read_known_tasks_array): Return bool.
13772         (read_known_tasks_list): Likewise.
13773         (read_known_tasks): Return void.
13774         (ada_build_task_list): Now static.
13775
13776 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13777
13778         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13779         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13780
13781 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13782
13783         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13784         variant for ada_tasks_pspace_data_handle and
13785         ada_tasks_inferior_data_handle.
13786         (ada_tasks_pspace_data_cleanup): New function.
13787         (ada_tasks_inferior_data_cleanup): New function.
13788
13789 2019-02-17  Tom Tromey  <tom@tromey.com>
13790
13791         * macrotab.h (macro_source_fullname): Return a std::string.
13792         * macrotab.c (macro_include, check_for_redefinition)
13793         (macro_undef, macro_lookup_definition, foreach_macro)
13794         (foreach_macro_in_scope): Update.
13795         (macro_source_fullname): Return a std::string.
13796         * macrocmd.c (show_pp_source_pos): Update.
13797
13798 2019-02-17  Tom Tromey  <tom@tromey.com>
13799
13800         * macrocmd.c (show_pp_source_pos): Style the file names.
13801
13802 2019-02-17  Tom Tromey  <tom@tromey.com>
13803
13804         PR tui/24197:
13805         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13806
13807 2019-02-17  Tom Tromey  <tom@tromey.com>
13808
13809         * ada-lang.c (user_select_syms): Use filtered printing.
13810         * utils.c (wrap_style): New global.
13811         (desired_style): Remove.
13812         (emit_style_escape): Add stream parameter.
13813         (set_output_style, reset_terminal_style, prompt_for_continue):
13814         Update.
13815         (flush_wrap_buffer): Only flush gdb_stdout.
13816         (wrap_here): Set wrap_style.
13817         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13818         treat escape sequences as a character.  Change when wrap buffer is
13819         flushed.
13820         (fputs_styled): Do not set the output style when the default is
13821         requested.
13822         * ui-style.h (struct ui_file_style) <is_default>: New method.
13823         * source.c (print_source_lines_base): Emit escape sequences in one
13824         piece.
13825
13826 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13827
13828         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13829         integers and enumeration types.
13830
13831 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13832
13833         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13834         instead of lookup_symbol_in_language
13835         (do_exact_match): New function.
13836         (ada_get_symbol_name_matcher): Return do_exact_match when
13837         doing a verbatim match.
13838
13839 2019-02-15  Tom Tromey  <tromey@adacore.com>
13840
13841         * ravenscar-thread.c (ravenscar_thread_target::resume)
13842         (ravenscar_thread_target::wait): Special case wildcard requests.
13843
13844 2019-02-15  Tom Tromey  <tromey@adacore.com>
13845
13846         * ravenscar-thread.c (base_ptid): Remove.
13847         (struct ravenscar_thread_target) <close>: New method.
13848         <m_base_ptid>: New member.
13849         <update_inferior_ptid, active_task, task_is_currently_active,
13850         runtime_initialized>: Declare methods.
13851         <ravenscar_thread_target>: Add constructor.
13852         (ravenscar_thread_target::task_is_currently_active)
13853         (ravenscar_thread_target::update_inferior_ptid)
13854         (ravenscar_runtime_initialized): Rename.  Now methods.
13855         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13856         (ravenscar_thread_target::update_thread_list): Update.
13857         (ravenscar_thread_target::active_task): Now method.
13858         (ravenscar_thread_target::store_registers)
13859         (ravenscar_thread_target::prepare_to_store)
13860         (ravenscar_thread_target::prepare_to_store)
13861         (ravenscar_thread_target::mourn_inferior): Update.
13862         (ravenscar_inferior_created): Use "new" to create target.
13863         (ravenscar_thread_target::get_ada_task_ptid): Update.
13864         (_initialize_ravenscar): Don't initialize base_ptid.
13865         (ravenscar_ops): Remove global.
13866
13867 2019-02-15  Tom Tromey  <tromey@adacore.com>
13868
13869         * target.h (push_target): Declare new overload.
13870         * target.c (push_target): New overload, taking an rvalue reference.
13871         * remote.c (remote_target::open_1): Use push_target overload.
13872         * corelow.c (core_target_open): Use push_target overload.
13873
13874 2019-02-15  Tom Tromey  <tromey@adacore.com>
13875
13876         * ravenscar-thread.c (is_ravenscar_task)
13877         (ravenscar_task_is_currently_active): Return bool.
13878         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13879         (_initialize_ravenscar): Remove "(void)".
13880         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13881         Return bool.
13882
13883 2019-02-15  Tom Tromey  <tromey@adacore.com>
13884
13885         * ravenscar-thread.c (ravenscar_runtime_initializer)
13886         (has_ravenscar_runtime, get_running_thread_id)
13887         (ravenscar_thread_target::resume): Fix indentation.
13888
13889 2019-02-15  Tom Tromey  <tromey@adacore.com>
13890
13891         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13892         from ravenscar_arch_ops.
13893         (sparc_ravenscar_ops::fetch_registers)
13894         (sparc_ravenscar_ops::store_registers): Now methods.
13895         (sparc_ravenscar_prepare_to_store): Remove.
13896         (sparc_ravenscar_ops): Redefine.
13897         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13898         methods and destructor.  Remove members.
13899         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13900         (ravenscar_thread_target::store_registers)
13901         (ravenscar_thread_target::prepare_to_store): Update.
13902         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13903         Remove.
13904         (struct ppc_ravenscar_powerpc_ops): Derive from
13905         ravenscar_arch_ops.
13906         (ppc_ravenscar_powerpc_ops::fetch_registers)
13907         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13908         (ppc_ravenscar_powerpc_ops): Redefine.
13909         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13910         (ppc_ravenscar_e500_ops::fetch_registers)
13911         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13912         (ppc_ravenscar_e500_ops): Redefine.
13913         * aarch64-ravenscar-thread.c
13914         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13915         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13916         (aarch64_ravenscar_fetch_registers)
13917         (aarch64_ravenscar_store_registers): Now methods.
13918         (aarch64_ravenscar_ops): Redefine.
13919
13920 2019-02-15  Tom Tromey  <tromey@adacore.com>
13921
13922         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13923         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13924         (ravenscar_thread_target::stopped_by_watchpoint)
13925         (ravenscar_thread_target::stopped_data_address)
13926         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13927
13928 2019-02-15  Tom Tromey  <tromey@adacore.com>
13929
13930         * ravenscar-thread.c: Fix some typos.
13931
13932 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13933             Tom Tromey  <tromey@adacore.com>
13934
13935         * ada-lang.c (ada_exception_sal): Change addr_string to a
13936         std::string.
13937         (create_ada_exception_catchpoint): Update.
13938
13939 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13940             Tom Tromey  <tromey@adacore.com>
13941
13942         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13943         (bp_location_ops): Remove.
13944         (base_breakpoint_allocate_location): Update.
13945         (free_bp_location): Update.
13946         * ada-lang.c (class ada_catchpoint_location)
13947         <ada_catchpoint_location>: Remove ops parameter.
13948         (ada_catchpoint_location_dtor): Remove.
13949         (ada_catchpoint_location_ops): Remove.
13950         (allocate_location_exception): Update.
13951         * breakpoint.h (struct bp_location_ops): Remove.
13952         (class bp_location) <bp_location>: Remove bp_location_ops
13953         parameter.
13954         <~bp_location>: Add destructor.
13955         <ops>: Remove.
13956
13957 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13958             Pedro Alves  <palves@redhat.com>
13959
13960         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13961         'PATH_MAX'.
13962
13963 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13964             Samuel Thibault  <samuel.thibault@gnu.org>
13965             Thomas Schwinge  <thomas@codesourcery.com>
13966
13967         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13968         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13969
13970 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13971
13972         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13973         (check_empty): Use "const char *".
13974
13975         * gnu-nat.c (gnu_nat_target::detach): Instead of
13976         'detach_inferior (pid)' call
13977         'detach_inferior (find_inferior_pid (pid))'.
13978
13979         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13980         'nat/fork-inferior.o'.
13981         * gnu-nat.c: #include "nat/fork-inferior.h".
13982
13983         * gnu-nat.c (gnu_nat_target::detach): Instead of
13984         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13985         * gnu-nat.h: #include "inf-child.h".
13986         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13987         'i386_gnu_nat_target::fetch_registers'.
13988         (gnu_store_registers): Rename/move to
13989         'i386_gnu_nat_target::store_registers'.
13990
13991         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13992         * gnu-nat.h (mach_thread_info): New function.
13993         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13994
13995         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13996
13997 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13998
13999         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14000
14001 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14002
14003         * windows-nat.c (windows_add_thread): Add new parameter
14004         "main_thread_p" with default value set to false.  Update
14005         function documentation as well as all callers.
14006         (windows_delete_thread): Likewise.
14007         (fake_create_process): Update call to windows_add_thread.
14008         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14009         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14010         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14011         call to windows_delete_thread.
14012
14013 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14014
14015         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14016
14017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14018
14019         * symfile.c (find_separate_debug_file): Use canonical path of
14020         sysroot with child_path instead of gdb_sysroot if it is valid.
14021
14022 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14023
14024         * symfile.c (find_separate_debug_file): Use child_path to
14025         determine if an object file is under a sysroot.
14026
14027 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14028
14029         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14030         unittests/child-path-selftests.c.
14031         * common/pathstuff.c (child_path): New function.
14032         * common/pathstuff.h (child_path): New prototype.
14033         * unittests/child-path-selftests.c: New file.
14034
14035 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14036
14037         * symfile.c (find_separate_debug_file): Look for separate debug
14038         files in debug directories under the sysroot.
14039
14040 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14041
14042         * symtab.h (struct minimal_symbol data_p): New const method.
14043         (struct minimal_symbol text_p): Likewise.
14044         * symtab.c (output_source_filename): Use file name style
14045         to print file name.
14046         (print_symbol_info): Likewise.
14047         (print_msymbol_info): Use address style to print addresses.
14048         Use function name style to print executable text symbols.
14049         (expand_symtab_containing_pc): Use data_p.
14050         (find_pc_sect_compunit_symtab): Likewise.
14051
14052 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14053
14054         * breakpoint.c (describe_other_breakpoints): Use address style
14055         to print addresses.
14056         (say_where): Likewise.
14057
14058 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14059
14060         * ada-typeprint.c (print_func_type): Print function name
14061         style to print function name.
14062         * c-typeprint.c (c_print_type_1): Likewise.
14063
14064 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14065
14066         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14067         for execve.
14068
14069 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14070
14071         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14072         type_stack.
14073
14074 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14075
14076         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14077         TYPE_CODE_REF types.
14078
14079 2019-02-08  Jim Wilson  <jimw@sifive.com>
14080
14081         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14082         (riscv_linux_fregset): New.
14083         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14084
14085 2019-02-07  Tom Tromey  <tom@tromey.com>
14086
14087         * thread.c (thread_cancel_execution_command): Update.
14088         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14089         methods.
14090         (struct thread_fsm_ops): Remove.
14091         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14092         (thread_fsm_should_stop, thread_fsm_return_value)
14093         (thread_fsm_set_finished, thread_fsm_finished_p)
14094         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14095         Don't declare.
14096         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14097         * infrun.c (clear_proceed_status_thread)
14098         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14099         (print_stop_event): Update.
14100         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14101         Add constructor.
14102         (step_command_fsm_ops): Remove.
14103         (new_step_command_fsm): Remove.
14104         (step_1): Update.
14105         (step_command_fsm::should_stop): Rename from
14106         step_command_fsm_should_stop.
14107         (step_command_fsm::clean_up): Rename from
14108         step_command_fsm_clean_up.
14109         (step_command_fsm::do_async_reply_reason): Rename from
14110         step_command_fsm_async_reply_reason.
14111         (struct until_next_fsm): Inherit from thread_fsm.  Add
14112         constructor.
14113         (until_next_fsm_ops): Remove.
14114         (new_until_next_fsm): Remove.
14115         (until_next_fsm::should_stop): Rename from
14116         until_next_fsm_should_stop.
14117         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14118         (until_next_fsm::do_async_reply_reason): Rename from
14119         until_next_fsm_async_reply_reason.
14120         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14121         constructor.  Change type of breakpoint.
14122         (finish_command_fsm_ops): Remove.
14123         (new_finish_command_fsm): Remove.
14124         (finish_command_fsm::should_stop): Rename from
14125         finish_command_fsm_should_stop.
14126         (finish_command_fsm::clean_up): Rename from
14127         finish_command_fsm_clean_up.
14128         (finish_command_fsm::return_value): Rename from
14129         finish_command_fsm_return_value.
14130         (finish_command_fsm::do_async_reply_reason): Rename from
14131         finish_command_fsm_async_reply_reason.
14132         (finish_command): Update.
14133         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14134         Add constructor.
14135         (call_thread_fsm_ops): Remove.
14136         (call_thread_fsm::call_thread_fsm): Rename from
14137         new_call_thread_fsm.
14138         (call_thread_fsm::should_stop): Rename from
14139         call_thread_fsm_should_stop.
14140         (call_thread_fsm::should_notify_stop): Rename from
14141         call_thread_fsm_should_notify_stop.
14142         (run_inferior_call, call_function_by_hand_dummy): Update.
14143         * cli/cli-interp.c (should_print_stop_to_console): Update.
14144         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14145         Add constructor.  Change type of location_breakpoint,
14146         caller_breakpoint.
14147         (until_break_fsm_ops): Remove.
14148         (new_until_break_fsm): Remove.
14149         (until_break_fsm::should_stop): Rename from
14150         until_break_fsm_should_stop.
14151         (until_break_fsm::clean_up): Rename from
14152         until_break_fsm_clean_up.
14153         (until_break_fsm::do_async_reply_reason): Rename from
14154         until_break_fsm_async_reply_reason.
14155         (until_break_command): Update.
14156         * thread-fsm.c: Remove.
14157         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14158
14159 2019-02-07  Tom Tromey  <tom@tromey.com>
14160
14161         * yy-remap.h: Add include guard.
14162         * xtensa-tdep.h: Add include guard.
14163         * xcoffread.h: Rename include guard.
14164         * varobj-iter.h: Add include guard.
14165         * tui/tui.h: Rename include guard.
14166         * tui/tui-winsource.h: Rename include guard.
14167         * tui/tui-wingeneral.h: Rename include guard.
14168         * tui/tui-windata.h: Rename include guard.
14169         * tui/tui-win.h: Rename include guard.
14170         * tui/tui-stack.h: Rename include guard.
14171         * tui/tui-source.h: Rename include guard.
14172         * tui/tui-regs.h: Rename include guard.
14173         * tui/tui-out.h: Rename include guard.
14174         * tui/tui-layout.h: Rename include guard.
14175         * tui/tui-io.h: Rename include guard.
14176         * tui/tui-hooks.h: Rename include guard.
14177         * tui/tui-file.h: Rename include guard.
14178         * tui/tui-disasm.h: Rename include guard.
14179         * tui/tui-data.h: Rename include guard.
14180         * tui/tui-command.h: Rename include guard.
14181         * tic6x-tdep.h: Add include guard.
14182         * target/waitstatus.h: Rename include guard.
14183         * target/wait.h: Rename include guard.
14184         * target/target.h: Rename include guard.
14185         * target/resume.h: Rename include guard.
14186         * target-float.h: Rename include guard.
14187         * stabsread.h: Add include guard.
14188         * rs6000-tdep.h: Add include guard.
14189         * riscv-fbsd-tdep.h: Add include guard.
14190         * regformats/regdef.h: Rename include guard.
14191         * record.h: Rename include guard.
14192         * python/python.h: Rename include guard.
14193         * python/python-internal.h: Rename include guard.
14194         * python/py-stopevent.h: Rename include guard.
14195         * python/py-ref.h: Rename include guard.
14196         * python/py-record.h: Rename include guard.
14197         * python/py-record-full.h: Rename include guard.
14198         * python/py-record-btrace.h: Rename include guard.
14199         * python/py-instruction.h: Rename include guard.
14200         * python/py-events.h: Rename include guard.
14201         * python/py-event.h: Rename include guard.
14202         * procfs.h: Add include guard.
14203         * proc-utils.h: Add include guard.
14204         * p-lang.h: Add include guard.
14205         * or1k-tdep.h: Rename include guard.
14206         * observable.h: Rename include guard.
14207         * nto-tdep.h: Rename include guard.
14208         * nat/x86-linux.h: Rename include guard.
14209         * nat/x86-linux-dregs.h: Rename include guard.
14210         * nat/x86-gcc-cpuid.h: Add include guard.
14211         * nat/x86-dregs.h: Rename include guard.
14212         * nat/x86-cpuid.h: Rename include guard.
14213         * nat/ppc-linux.h: Rename include guard.
14214         * nat/mips-linux-watch.h: Rename include guard.
14215         * nat/linux-waitpid.h: Rename include guard.
14216         * nat/linux-ptrace.h: Rename include guard.
14217         * nat/linux-procfs.h: Rename include guard.
14218         * nat/linux-osdata.h: Rename include guard.
14219         * nat/linux-nat.h: Rename include guard.
14220         * nat/linux-namespaces.h: Rename include guard.
14221         * nat/linux-btrace.h: Rename include guard.
14222         * nat/glibc_thread_db.h: Rename include guard.
14223         * nat/gdb_thread_db.h: Rename include guard.
14224         * nat/gdb_ptrace.h: Rename include guard.
14225         * nat/fork-inferior.h: Rename include guard.
14226         * nat/amd64-linux-siginfo.h: Rename include guard.
14227         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14228         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14229         * nat/aarch64-linux.h: Rename include guard.
14230         * nat/aarch64-linux-hw-point.h: Rename include guard.
14231         * mn10300-tdep.h: Add include guard.
14232         * mips-linux-tdep.h: Add include guard.
14233         * mi/mi-parse.h: Rename include guard.
14234         * mi/mi-out.h: Rename include guard.
14235         * mi/mi-main.h: Rename include guard.
14236         * mi/mi-interp.h: Rename include guard.
14237         * mi/mi-getopt.h: Rename include guard.
14238         * mi/mi-console.h: Rename include guard.
14239         * mi/mi-common.h: Rename include guard.
14240         * mi/mi-cmds.h: Rename include guard.
14241         * mi/mi-cmd-break.h: Rename include guard.
14242         * m2-lang.h: Add include guard.
14243         * location.h: Rename include guard.
14244         * linux-record.h: Rename include guard.
14245         * linux-nat.h: Add include guard.
14246         * linux-fork.h: Add include guard.
14247         * i386-darwin-tdep.h: Rename include guard.
14248         * hppa-linux-offsets.h: Add include guard.
14249         * guile/guile.h: Rename include guard.
14250         * guile/guile-internal.h: Rename include guard.
14251         * gnu-nat.h: Rename include guard.
14252         * gdb-stabs.h: Rename include guard.
14253         * frv-tdep.h: Add include guard.
14254         * f-lang.h: Add include guard.
14255         * event-loop.h: Add include guard.
14256         * darwin-nat.h: Rename include guard.
14257         * cp-abi.h: Rename include guard.
14258         * config/sparc/nm-sol2.h: Rename include guard.
14259         * config/nm-nto.h: Rename include guard.
14260         * config/nm-linux.h: Add include guard.
14261         * config/i386/nm-i386gnu.h: Rename include guard.
14262         * config/djgpp/nl_types.h: Rename include guard.
14263         * config/djgpp/langinfo.h: Rename include guard.
14264         * compile/gcc-cp-plugin.h: Add include guard.
14265         * compile/gcc-c-plugin.h: Add include guard.
14266         * compile/compile.h: Rename include guard.
14267         * compile/compile-object-run.h: Rename include guard.
14268         * compile/compile-object-load.h: Rename include guard.
14269         * compile/compile-internal.h: Rename include guard.
14270         * compile/compile-cplus.h: Rename include guard.
14271         * compile/compile-c.h: Rename include guard.
14272         * common/xml-utils.h: Rename include guard.
14273         * common/x86-xstate.h: Rename include guard.
14274         * common/version.h: Rename include guard.
14275         * common/vec.h: Rename include guard.
14276         * common/tdesc.h: Rename include guard.
14277         * common/selftest.h: Rename include guard.
14278         * common/scoped_restore.h: Rename include guard.
14279         * common/scoped_mmap.h: Rename include guard.
14280         * common/scoped_fd.h: Rename include guard.
14281         * common/safe-iterator.h: Rename include guard.
14282         * common/run-time-clock.h: Rename include guard.
14283         * common/refcounted-object.h: Rename include guard.
14284         * common/queue.h: Rename include guard.
14285         * common/ptid.h: Rename include guard.
14286         * common/print-utils.h: Rename include guard.
14287         * common/preprocessor.h: Rename include guard.
14288         * common/pathstuff.h: Rename include guard.
14289         * common/observable.h: Rename include guard.
14290         * common/netstuff.h: Rename include guard.
14291         * common/job-control.h: Rename include guard.
14292         * common/host-defs.h: Rename include guard.
14293         * common/gdb_wait.h: Rename include guard.
14294         * common/gdb_vecs.h: Rename include guard.
14295         * common/gdb_unlinker.h: Rename include guard.
14296         * common/gdb_unique_ptr.h: Rename include guard.
14297         * common/gdb_tilde_expand.h: Rename include guard.
14298         * common/gdb_sys_time.h: Rename include guard.
14299         * common/gdb_string_view.h: Rename include guard.
14300         * common/gdb_splay_tree.h: Rename include guard.
14301         * common/gdb_setjmp.h: Rename include guard.
14302         * common/gdb_ref_ptr.h: Rename include guard.
14303         * common/gdb_optional.h: Rename include guard.
14304         * common/gdb_locale.h: Rename include guard.
14305         * common/gdb_assert.h: Rename include guard.
14306         * common/filtered-iterator.h: Rename include guard.
14307         * common/filestuff.h: Rename include guard.
14308         * common/fileio.h: Rename include guard.
14309         * common/environ.h: Rename include guard.
14310         * common/common-utils.h: Rename include guard.
14311         * common/common-types.h: Rename include guard.
14312         * common/common-regcache.h: Rename include guard.
14313         * common/common-inferior.h: Rename include guard.
14314         * common/common-gdbthread.h: Rename include guard.
14315         * common/common-exceptions.h: Rename include guard.
14316         * common/common-defs.h: Rename include guard.
14317         * common/common-debug.h: Rename include guard.
14318         * common/cleanups.h: Rename include guard.
14319         * common/buffer.h: Rename include guard.
14320         * common/btrace-common.h: Rename include guard.
14321         * common/break-common.h: Rename include guard.
14322         * cli/cli-utils.h: Rename include guard.
14323         * cli/cli-style.h: Rename include guard.
14324         * cli/cli-setshow.h: Rename include guard.
14325         * cli/cli-script.h: Rename include guard.
14326         * cli/cli-interp.h: Rename include guard.
14327         * cli/cli-decode.h: Rename include guard.
14328         * cli/cli-cmds.h: Rename include guard.
14329         * charset-list.h: Add include guard.
14330         * buildsym-legacy.h: Rename include guard.
14331         * bfin-tdep.h: Add include guard.
14332         * ax.h: Rename include guard.
14333         * arm-linux-tdep.h: Add include guard.
14334         * arm-fbsd-tdep.h: Add include guard.
14335         * arch/xtensa.h: Rename include guard.
14336         * arch/tic6x.h: Add include guard.
14337         * arch/i386.h: Add include guard.
14338         * arch/arm.h: Rename include guard.
14339         * arch/arm-linux.h: Rename include guard.
14340         * arch/arm-get-next-pcs.h: Rename include guard.
14341         * arch/amd64.h: Add include guard.
14342         * arch/aarch64-insn.h: Rename include guard.
14343         * arch-utils.h: Rename include guard.
14344         * annotate.h: Add include guard.
14345         * amd64-darwin-tdep.h: Rename include guard.
14346         * aarch64-linux-tdep.h: Add include guard.
14347         * aarch64-fbsd-tdep.h: Add include guard.
14348         * aarch32-linux-nat.h: Add include guard.
14349
14350 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14351
14352         * macrotab.c (macro_define_internal): New function that
14353         factorizes macro_define_object_internal and macro_define_function
14354         code.
14355         (macro_define_object_internal): Use macro_define_internal.
14356         (macro_define_function): Likewise.
14357
14358 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14359
14360         * macrocmd.c (extract_identifier): Return
14361         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14362         callers.
14363
14364 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14365
14366         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14367
14368 2019-02-05  Tom Tromey  <tom@tromey.com>
14369
14370         * target.c (target_stack::unpush): Move assertion earlier.
14371
14372 2019-01-30  Tom Tromey  <tom@tromey.com>
14373
14374         PR python/23615:
14375         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14376         (gdbpy_parse_and_eval): Likewise.
14377         * python/python-internal.h (gdbpy_allow_threads): New class.
14378
14379 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14380
14381         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14382         (aarch64_fbsd_fpregmap): Move earlier.
14383         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14384         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14385         instead of individual calls to trad_frame_set_reg_addr.
14386         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14387         earlier.
14388         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14389         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14390         instead of individual calls to trad_frame_set_reg_addr.
14391
14392 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14393
14394         * CONTRIBUTE: Replace contribution list with wiki link.
14395
14396 2019-01-25  Tom Tromey  <tom@tromey.com>
14397
14398         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14399
14400 2019-01-25  Tom Tromey  <tom@tromey.com>
14401
14402         * xtensa-linux-nat.c: Fix common/ includes.
14403         * xml-support.h: Fix common/ includes.
14404         * xml-support.c: Fix common/ includes.
14405         * x86-linux-nat.c: Fix common/ includes.
14406         * windows-nat.c: Fix common/ includes.
14407         * varobj.h: Fix common/ includes.
14408         * varobj.c: Fix common/ includes.
14409         * value.c: Fix common/ includes.
14410         * valops.c: Fix common/ includes.
14411         * utils.c: Fix common/ includes.
14412         * unittests/xml-utils-selftests.c: Fix common/ includes.
14413         * unittests/utils-selftests.c: Fix common/ includes.
14414         * unittests/unpack-selftests.c: Fix common/ includes.
14415         * unittests/tracepoint-selftests.c: Fix common/ includes.
14416         * unittests/style-selftests.c: Fix common/ includes.
14417         * unittests/string_view-selftests.c: Fix common/ includes.
14418         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14419         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14420         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14421         * unittests/rsp-low-selftests.c: Fix common/ includes.
14422         * unittests/parse-connection-spec-selftests.c: Fix common/
14423         includes.
14424         * unittests/optional-selftests.c: Fix common/ includes.
14425         * unittests/offset-type-selftests.c: Fix common/ includes.
14426         * unittests/observable-selftests.c: Fix common/ includes.
14427         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14428         * unittests/memrange-selftests.c: Fix common/ includes.
14429         * unittests/memory-map-selftests.c: Fix common/ includes.
14430         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14431         * unittests/function-view-selftests.c: Fix common/ includes.
14432         * unittests/environ-selftests.c: Fix common/ includes.
14433         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14434         * unittests/common-utils-selftests.c: Fix common/ includes.
14435         * unittests/cli-utils-selftests.c: Fix common/ includes.
14436         * unittests/array-view-selftests.c: Fix common/ includes.
14437         * ui-file.c: Fix common/ includes.
14438         * tui/tui-io.c: Fix common/ includes.
14439         * tracepoint.h: Fix common/ includes.
14440         * tracepoint.c: Fix common/ includes.
14441         * tracefile-tfile.c: Fix common/ includes.
14442         * top.h: Fix common/ includes.
14443         * top.c: Fix common/ includes.
14444         * thread.c: Fix common/ includes.
14445         * target/waitstatus.h: Fix common/ includes.
14446         * target/waitstatus.c: Fix common/ includes.
14447         * target.h: Fix common/ includes.
14448         * target.c: Fix common/ includes.
14449         * target-memory.c: Fix common/ includes.
14450         * target-descriptions.c: Fix common/ includes.
14451         * symtab.h: Fix common/ includes.
14452         * symfile.c: Fix common/ includes.
14453         * stap-probe.c: Fix common/ includes.
14454         * spu-linux-nat.c: Fix common/ includes.
14455         * sparc-nat.c: Fix common/ includes.
14456         * source.c: Fix common/ includes.
14457         * solib.c: Fix common/ includes.
14458         * solib-target.c: Fix common/ includes.
14459         * ser-unix.c: Fix common/ includes.
14460         * ser-tcp.c: Fix common/ includes.
14461         * ser-pipe.c: Fix common/ includes.
14462         * ser-base.c: Fix common/ includes.
14463         * selftest-arch.c: Fix common/ includes.
14464         * s12z-tdep.c: Fix common/ includes.
14465         * rust-exp.y: Fix common/ includes.
14466         * rs6000-aix-tdep.c: Fix common/ includes.
14467         * riscv-tdep.c: Fix common/ includes.
14468         * remote.c: Fix common/ includes.
14469         * remote-notif.h: Fix common/ includes.
14470         * remote-fileio.h: Fix common/ includes.
14471         * remote-fileio.c: Fix common/ includes.
14472         * regcache.h: Fix common/ includes.
14473         * regcache.c: Fix common/ includes.
14474         * record-btrace.c: Fix common/ includes.
14475         * python/python.c: Fix common/ includes.
14476         * python/py-type.c: Fix common/ includes.
14477         * python/py-inferior.c: Fix common/ includes.
14478         * progspace.h: Fix common/ includes.
14479         * producer.c: Fix common/ includes.
14480         * procfs.c: Fix common/ includes.
14481         * proc-api.c: Fix common/ includes.
14482         * printcmd.c: Fix common/ includes.
14483         * ppc-linux-nat.c: Fix common/ includes.
14484         * parser-defs.h: Fix common/ includes.
14485         * osdata.c: Fix common/ includes.
14486         * obsd-nat.c: Fix common/ includes.
14487         * nat/x86-linux.c: Fix common/ includes.
14488         * nat/x86-linux-dregs.c: Fix common/ includes.
14489         * nat/x86-dregs.h: Fix common/ includes.
14490         * nat/x86-dregs.c: Fix common/ includes.
14491         * nat/ppc-linux.c: Fix common/ includes.
14492         * nat/mips-linux-watch.h: Fix common/ includes.
14493         * nat/mips-linux-watch.c: Fix common/ includes.
14494         * nat/linux-waitpid.c: Fix common/ includes.
14495         * nat/linux-ptrace.h: Fix common/ includes.
14496         * nat/linux-ptrace.c: Fix common/ includes.
14497         * nat/linux-procfs.c: Fix common/ includes.
14498         * nat/linux-personality.c: Fix common/ includes.
14499         * nat/linux-osdata.c: Fix common/ includes.
14500         * nat/linux-namespaces.c: Fix common/ includes.
14501         * nat/linux-btrace.h: Fix common/ includes.
14502         * nat/linux-btrace.c: Fix common/ includes.
14503         * nat/fork-inferior.c: Fix common/ includes.
14504         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14505         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14506         * nat/aarch64-linux.c: Fix common/ includes.
14507         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14508         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14509         * namespace.h: Fix common/ includes.
14510         * mips-linux-tdep.c: Fix common/ includes.
14511         * minsyms.c: Fix common/ includes.
14512         * mi/mi-parse.h: Fix common/ includes.
14513         * mi/mi-main.c: Fix common/ includes.
14514         * mi/mi-cmd-env.c: Fix common/ includes.
14515         * memrange.h: Fix common/ includes.
14516         * memattr.c: Fix common/ includes.
14517         * maint.h: Fix common/ includes.
14518         * maint.c: Fix common/ includes.
14519         * main.c: Fix common/ includes.
14520         * machoread.c: Fix common/ includes.
14521         * location.c: Fix common/ includes.
14522         * linux-thread-db.c: Fix common/ includes.
14523         * linux-nat.c: Fix common/ includes.
14524         * linux-fork.c: Fix common/ includes.
14525         * inline-frame.c: Fix common/ includes.
14526         * infrun.c: Fix common/ includes.
14527         * inflow.c: Fix common/ includes.
14528         * inferior.h: Fix common/ includes.
14529         * inferior.c: Fix common/ includes.
14530         * infcmd.c: Fix common/ includes.
14531         * inf-ptrace.c: Fix common/ includes.
14532         * inf-child.c: Fix common/ includes.
14533         * ia64-linux-nat.c: Fix common/ includes.
14534         * i387-tdep.c: Fix common/ includes.
14535         * i386-tdep.c: Fix common/ includes.
14536         * i386-linux-tdep.c: Fix common/ includes.
14537         * i386-linux-nat.c: Fix common/ includes.
14538         * i386-go32-tdep.c: Fix common/ includes.
14539         * i386-fbsd-tdep.c: Fix common/ includes.
14540         * i386-fbsd-nat.c: Fix common/ includes.
14541         * guile/scm-type.c: Fix common/ includes.
14542         * guile/guile.c: Fix common/ includes.
14543         * go32-nat.c: Fix common/ includes.
14544         * gnu-nat.c: Fix common/ includes.
14545         * gdbthread.h: Fix common/ includes.
14546         * gdbarch-selftests.c: Fix common/ includes.
14547         * gdb_usleep.c: Fix common/ includes.
14548         * gdb_select.h: Fix common/ includes.
14549         * gdb_bfd.c: Fix common/ includes.
14550         * gcore.c: Fix common/ includes.
14551         * fork-child.c: Fix common/ includes.
14552         * findvar.c: Fix common/ includes.
14553         * fbsd-nat.c: Fix common/ includes.
14554         * event-top.c: Fix common/ includes.
14555         * event-loop.c: Fix common/ includes.
14556         * dwarf2read.c: Fix common/ includes.
14557         * dwarf2loc.c: Fix common/ includes.
14558         * dwarf2-frame.c: Fix common/ includes.
14559         * dwarf-index-cache.c: Fix common/ includes.
14560         * dtrace-probe.c: Fix common/ includes.
14561         * disasm-selftests.c: Fix common/ includes.
14562         * defs.h: Fix common/ includes.
14563         * csky-tdep.c: Fix common/ includes.
14564         * cp-valprint.c: Fix common/ includes.
14565         * cp-support.h: Fix common/ includes.
14566         * cp-support.c: Fix common/ includes.
14567         * corelow.c: Fix common/ includes.
14568         * completer.h: Fix common/ includes.
14569         * completer.c: Fix common/ includes.
14570         * compile/compile.c: Fix common/ includes.
14571         * compile/compile-loc2c.c: Fix common/ includes.
14572         * compile/compile-cplus-types.c: Fix common/ includes.
14573         * compile/compile-cplus-symbols.c: Fix common/ includes.
14574         * command.h: Fix common/ includes.
14575         * cli/cli-dump.c: Fix common/ includes.
14576         * cli/cli-cmds.c: Fix common/ includes.
14577         * charset.c: Fix common/ includes.
14578         * build-id.c: Fix common/ includes.
14579         * btrace.h: Fix common/ includes.
14580         * btrace.c: Fix common/ includes.
14581         * breakpoint.h: Fix common/ includes.
14582         * breakpoint.c: Fix common/ includes.
14583         * ax.h:
14584         (enum agent_op): Fix common/ includes.
14585         * ax-general.c (struct aop_map): Fix common/ includes.
14586         * ax-gdb.c: Fix common/ includes.
14587         * auxv.c: Fix common/ includes.
14588         * auto-load.c: Fix common/ includes.
14589         * arm-tdep.c: Fix common/ includes.
14590         * arch/riscv.c: Fix common/ includes.
14591         * arch/ppc-linux-common.c: Fix common/ includes.
14592         * arch/i386.c: Fix common/ includes.
14593         * arch/arm.c: Fix common/ includes.
14594         * arch/arm-linux.c: Fix common/ includes.
14595         * arch/arm-get-next-pcs.c: Fix common/ includes.
14596         * arch/amd64.c: Fix common/ includes.
14597         * arch/aarch64.c: Fix common/ includes.
14598         * arch/aarch64-insn.c: Fix common/ includes.
14599         * arch-utils.c: Fix common/ includes.
14600         * amd64-windows-tdep.c: Fix common/ includes.
14601         * amd64-tdep.c: Fix common/ includes.
14602         * amd64-sol2-tdep.c: Fix common/ includes.
14603         * amd64-obsd-tdep.c: Fix common/ includes.
14604         * amd64-nbsd-tdep.c: Fix common/ includes.
14605         * amd64-linux-tdep.c: Fix common/ includes.
14606         * amd64-linux-nat.c: Fix common/ includes.
14607         * amd64-fbsd-tdep.c: Fix common/ includes.
14608         * amd64-fbsd-nat.c: Fix common/ includes.
14609         * amd64-dicos-tdep.c: Fix common/ includes.
14610         * amd64-darwin-tdep.c: Fix common/ includes.
14611         * agent.c: Fix common/ includes.
14612         * ada-lang.h: Fix common/ includes.
14613         * ada-lang.c: Fix common/ includes.
14614         * aarch64-tdep.c: Fix common/ includes.
14615
14616 2019-01-25  Tom Tromey  <tom@tromey.com>
14617
14618         * common/create-version.sh: Use common/version.h.
14619
14620 2019-01-24  Pedro Alves  <palves@redhat.com>
14621
14622         * infrun.c (signal_stop, signal_print, signal_program)
14623         (signal_catch, signal_pass): Now arrays instead of pointers.
14624         (update_signals_program_target, do_target_resume)
14625         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14626         * linux-nat.c (linux_nat_target::pass_signals)
14627         (linux_nat_target::create_inferior, linux_nat_target::attach):
14628         Adjust.
14629         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14630         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14631         * procfs.c (procfs_target::pass_signals): Adjust.
14632         * record-full.c (record_full_target::resume): Adjust.
14633         * remote.c (remote_target::pass_signals)
14634         (remote_target::program_signals): Adjust.
14635         * target-debug.h (target_debug_print_signals): Now takes a
14636         gdb::array_view as parameter.  Adjust.
14637         * target.h (target_ops) <pass_signals, program_signals>: Replace
14638         pointer and length parameters with gdb::array_view.
14639         (target_pass_signals, target_program_signals): Likewise.
14640         * target-delegates.c: Regenerate.
14641
14642 2019-01-24  Pedro Alves  <palves@redhat.com>
14643
14644         * common/forward-scope-exit.h
14645         (forward_scope_exit::forward_scope_exit): Pass arguments to
14646         m_bind_function directly, instead of creating a std::bind and
14647         copying that.
14648
14649 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14650
14651         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14652         for static members.
14653         (pass_in_v_vfp_candidate): Likewise.
14654
14655 2019-01-23  Tom Tromey  <tom@tromey.com>
14656             Pedro Alves  <palves@redhat.com>
14657
14658         * regcache.c (class regcache_invalidator): Remove.
14659         (regcache::raw_write): Use make_scope_exit.
14660
14661 2019-01-23  Tom Tromey  <tom@tromey.com>
14662
14663         * ui-out.h (class ui_out_emit_type): Update comment.
14664
14665 2019-01-23  Tom Tromey  <tom@tromey.com>
14666
14667         * infrun.c (fetch_inferior_event): Update comment.
14668
14669 2019-01-23  Tom Tromey  <tom@tromey.com>
14670             Pedro Alves  <palves@redhat.com>
14671
14672         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14673         parameter.
14674         (fetch_inferior_event): Use SCOPE_EXIT.
14675
14676
14677 2019-01-23  Tom Tromey  <tom@tromey.com>
14678             Pedro Alves  <palves@redhat.com>
14679
14680         * infrun.c (disable_thread_events): Delete.
14681         (stop_all_threads): Use SCOPE_EXIT.
14682
14683 2019-01-23  Tom Tromey  <tom@tromey.com>
14684             Pedro Alves  <palves@redhat.com>
14685
14686         * symfile.c: Include forward-scope-exit.h.
14687         (clear_symtab_users_cleanup): Replace forward declaration with
14688         a FORWARD_SCOPE_EXIT.
14689         (syms_from_objfile_1): Use the forward_scope_exit and
14690         gdb::optional instead of cleanup_function.
14691         (reread_symbols): Use the forward_scope_exit instead of
14692         cleanup_function.
14693         (clear_symtab_users_cleanup): Remove function.
14694
14695 2019-01-23  Tom Tromey  <tom@tromey.com>
14696             Pedro Alves  <palves@redhat.com>
14697
14698         * linux-nat.c: Include scope-exit.h.
14699         (cleanup_target_stop): Remove.
14700         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14701         SCOPE_EXIT.
14702
14703 2019-01-23  Tom Tromey  <tom@tromey.com>
14704             Pedro Alves  <palves@redhat.com>
14705
14706         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14707         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14708
14709 2019-01-23  Tom Tromey  <tom@tromey.com>
14710             Andrew Burgess  <andrew.burgess@embecosm.com>
14711             Pedro Alves  <palves@redhat.com>
14712
14713         * infrun.c (fetch_inferior_event): Use scope_exit.
14714         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14715         * top.c (execute_command): Use scope_exit.
14716         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14717         * utils.c (do_bpstat_clear_actions_cleanup)
14718         (make_bpstat_clear_actions_cleanup): Remove.
14719
14720 2019-01-23  Tom Tromey  <tom@tromey.com>
14721             Pedro Alves  <palves@redhat.com>
14722
14723         * infrun.c: Include "common/scope-exit.h"
14724         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14725         (wait_for_inferior): Use SCOPE_EXIT.
14726         (fetch_inferior_event): Use scope_exit.
14727
14728 2019-01-23  Tom Tromey  <tom@tromey.com>
14729             Pedro Alves  <palves@redhat.com>
14730
14731         * breakpoint.c (create_breakpoint): Remove cleanup.
14732
14733 2019-01-23  Tom Tromey  <tom@tromey.com>
14734             Andrew Burgess  <andrew.burgess@embecosm.com>
14735             Pedro Alves  <palves@redhat.com>
14736
14737 2019-01-23  Pedro Alves  <palves@redhat.com>
14738
14739         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14740
14741 2019-01-23  Pedro Alves  <palves@redhat.com>
14742             Andrew Burgess  <andrew.burgess@embecosm.com>
14743
14744         * gdbthread.h: Include "common/forward-scope-exit.h".
14745         (scoped_finish_thread_state): Redefine custom class in terms of
14746         forward_scope_exit.
14747
14748 2019-01-23  Pedro Alves  <palves@redhat.com>
14749             Andrew Burgess  <andrew.burgess@embecosm.com>
14750
14751         * common/forward-scope-exit.h: New file.
14752
14753 2019-01-23  Pedro Alves  <palves@redhat.com>
14754             Andrew Burgess  <andrew.burgess@embecosm.com>
14755             Tom Tromey  <tom@tromey.com>
14756
14757         * common/scope-exit.h: New file.
14758
14759 2019-01-23  Pedro Alves  <palves@redhat.com>
14760
14761         * common/preprocessor.h (ESC): Rename to ...
14762         (ESC_PARENS): ... this.
14763         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14764         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14765
14766 2019-01-23  Tom Tromey  <tom@tromey.com>
14767
14768         * language.h (class scoped_switch_to_sym_language_if_auto):
14769         Initialize m_lang in both cases.
14770
14771 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14772
14773         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14774         with XCNEW.
14775
14776 2019-01-22  Tom Tromey  <tom@tromey.com>
14777
14778         * corelow.c: Do not include sys/file.h.
14779
14780 2019-01-22  Tom Tromey  <tom@tromey.com>
14781
14782         * tui/tui-wingeneral.h: Include gdb_curses.h.
14783
14784 2019-01-22  Tom Tromey  <tom@tromey.com>
14785
14786         * source-cache.h (class source_cache) <get_source_lines,
14787         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14788
14789 2019-01-22  Tom Tromey  <tom@tromey.com>
14790
14791         * remote-fileio.h (struct remote_target): Declare.
14792
14793 2019-01-22  Tom Tromey  <tom@tromey.com>
14794
14795         * python/py-arch.c: Do not include py-ref.h.
14796         * python/py-bpevent.c: Do not include py-ref.h.
14797         * python/py-cmd.c: Do not include py-ref.h.
14798         * python/py-continueevent.c: Do not include py-ref.h.
14799         * python/py-event.h: Do not include py-ref.h.
14800         * python/py-evtregistry.c: Do not include py-ref.h.
14801         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14802         * python/py-frame.c: Do not include py-ref.h.
14803         * python/py-framefilter.c: Do not include py-ref.h.
14804         * python/py-function.c: Do not include py-ref.h.
14805         * python/py-infevents.c: Do not include py-ref.h.
14806         * python/py-linetable.c: Do not include py-ref.h.
14807         * python/py-objfile.c: Do not include py-ref.h.
14808         * python/py-param.c: Do not include py-ref.h.
14809         * python/py-prettyprint.c: Do not include py-ref.h.
14810         * python/py-progspace.c: Do not include py-ref.h.
14811         * python/py-symbol.c: Do not include py-ref.h.
14812         * python/py-symtab.c: Do not include py-ref.h.
14813         * python/py-type.c: Do not include py-ref.h.
14814         * python/py-unwind.c: Do not include py-ref.h.
14815         * python/py-utils.c: Do not include py-ref.h.
14816         * python/py-value.c: Do not include py-ref.h.
14817         * python/py-varobj.c: Do not include py-ref.h.
14818         * python/py-xmethods.c: Do not include py-ref.h.
14819         * python/python.c: Do not include py-ref.h.
14820         * varobj.c: Do not include py-ref.h.
14821
14822 2019-01-22  Tom Tromey  <tom@tromey.com>
14823
14824         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14825         keyword for bcache.
14826
14827 2019-01-22  Tom Tromey  <tom@tromey.com>
14828
14829         * compile/compile-cplus-types.c: Remove a comment by #include.
14830
14831 2019-01-22  Tom Tromey  <tom@tromey.com>
14832
14833         * compile/gcc-c-plugin.h: Include compile-internal.h.
14834
14835 2019-01-22  Tom Tromey  <tom@tromey.com>
14836
14837         * stabsread.c (EXTERN): Do not define.
14838         (symnum, next_symbol_text_func, processing_gcc_compilation)
14839         (within_function, global_sym_chain, global_stabs)
14840         (previous_stab_code, this_object_header_files)
14841         (n_this_object_header_files)
14842         (n_allocated_this_object_header_files): Define.
14843         * stabsread.h (EXTERN): Never define.  Use "extern".
14844
14845 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14846
14847         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14848         history_value.
14849
14850 2019-01-21  Tom Tromey  <tom@tromey.com>
14851
14852         * ui-out.c: Fix includes.
14853         * tui/tui-source.c: Fix includes.
14854         * target.c: Fix includes.
14855         * remote.c: Fix includes.
14856         * regcache.c: Fix includes.
14857         * python/py-block.c: Fix includes.
14858         * printcmd.c: Fix includes.
14859         * or1k-tdep.c: Fix includes.
14860         * mi/mi-main.c: Fix includes.
14861         * m32r-tdep.c: Fix includes.
14862         * csky-tdep.c: Fix includes.
14863         * compile/compile-cplus-types.c: Fix includes.
14864         * cli/cli-interp.c: Fix includes.
14865
14866 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14867
14868         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14869         for padding.
14870
14871 2019-01-16  Tom Tromey  <tom@tromey.com>
14872
14873         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14874         earlier.
14875         (struct objfile) <msymbols_range>: Move from top level.
14876         <msymbols>: New method.
14877         (class objfile_msymbols): Remove.
14878         * symtab.c (default_collect_symbol_completion_matches_break_on):
14879         Update.
14880         * symmisc.c (dump_msymbols): Update.
14881         * stabsread.c (scan_file_globals): Update.
14882         * objc-lang.c (info_selectors_command, info_classes_command)
14883         (find_methods): Update.
14884         * minsyms.c (find_solib_trampoline_target): Update.
14885         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14886         * coffread.c (coff_symfile_read): Update.
14887         * ada-lang.c (ada_lookup_simple_minsym)
14888         (ada_collect_symbol_completion_matches): Update.
14889
14890 2019-01-16  Tom Tromey  <tom@tromey.com>
14891
14892         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14893         type.  Remove no-argument constructor.
14894         <iterator::operator++>: Simplify.
14895         <begin>: Update.
14896         <end>: Use minimal_symbol_count.
14897
14898 2019-01-16  Tom Tromey  <tom@tromey.com>
14899
14900         * objfiles.h (struct objfile) <psymtabs>: New method.
14901         (class objfile_psymtabs): Remove.
14902         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14903         typedef.
14904         <range>: New method.
14905         (require_partial_symbols): Change return type.
14906         * psymtab.c (require_partial_symbols)
14907         (psym_expand_symtabs_matching): Update.
14908         * mdebugread.c (parse_partial_symbols): Update.
14909         * dbxread.c (dbx_end_psymtab): Update.
14910
14911 2019-01-15  Tom Tromey  <tom@tromey.com>
14912
14913         * symtab.c (lookup_objfile_from_block)
14914         (lookup_symbol_in_objfile_symtabs)
14915         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14916         (find_line_symtab, info_sources_command)
14917         (default_collect_symbol_completion_matches_break_on)
14918         (make_source_files_completion_list): Update.
14919         * symmisc.c (print_objfile_statistics, dump_objfile)
14920         (maintenance_print_symbols, maintenance_info_symtabs)
14921         (maintenance_check_symtabs, maintenance_info_line_tables):
14922         Update.
14923         * source.c (select_source_symtab)
14924         (forget_cached_source_info_for_objfile): Update.
14925         * objfiles.h (class objfile_compunits): Remove.
14926         (struct objfile) <compunits_range>: New typedef.
14927         (compunits): New method.
14928         * objfiles.c (objfile_relocate1): Update.
14929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14930         * maint.c (count_symtabs_and_blocks): Update.
14931         * linespec.c (iterate_over_all_matching_symtabs): Update.
14932         * cp-support.c (add_symbol_overload_list_qualified): Update.
14933         * coffread.c (coff_symtab_read): Update.
14934         * ada-lang.c (add_nonlocal_symbols)
14935         (ada_collect_symbol_completion_matches)
14936         (ada_add_global_exceptions): Update.
14937
14938 2019-01-15  Tom Tromey  <tom@tromey.com>
14939
14940         * progspace.h (program_space) <objfiles_safe_range>: New
14941         typedef.
14942         <objfiles_safe>: New method.
14943         * objfiles.h (class all_objfiles_safe): Remove.
14944         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14945         * jit.c (jit_inferior_exit_hook): Update.
14946
14947 2019-01-17  Tom Tromey  <tom@tromey.com>
14948
14949         * progspace.h (program_space) <objfiles_range>: New typedef.
14950         <objfiles>: New method.
14951         <objfiles_head>: Rename from objfiles.
14952         (object_files): Update.
14953         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14954         * guile/scm-pretty-print.c
14955         (ppscm_find_pretty_printer_from_objfiles): Update.
14956         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14957         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14958         Update.
14959         * python/py-progspace.c (pspy_get_objfiles): Update.
14960         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14961         Update.
14962         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14963         (objfpy_lookup_objfile_by_build_id): Update.
14964         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14965         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14966         Update.
14967         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14968         (expand_symtab_containing_pc, lookup_objfile_from_block)
14969         (lookup_static_symbol, basic_lookup_transparent_type)
14970         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14971         (find_line_symtab, info_sources_command)
14972         (default_collect_symbol_completion_matches_break_on)
14973         (make_source_files_completion_list, find_main_name): Update.
14974         * symmisc.c (print_symbol_bcache_statistics)
14975         (print_objfile_statistics, maintenance_print_symbols)
14976         (maintenance_print_msymbols, maintenance_print_objfiles)
14977         (maintenance_info_symtabs, maintenance_check_symtabs)
14978         (maintenance_expand_symtabs, maintenance_info_line_tables):
14979         Update.
14980         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14981         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14982         (map_overlay_command, unmap_overlay_command)
14983         (simple_overlay_update, expand_symtabs_matching)
14984         (map_symbol_filenames): Update.
14985         * symfile-debug.c (set_debug_symfile): Update.
14986         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14987         Update.
14988         * source.c (select_source_symtab, forget_cached_source_info):
14989         Update.
14990         * solib.c (solib_read_symbols): Update.
14991         * solib-spu.c (append_ocl_sos): Update.
14992         * psymtab.c (maintenance_print_psymbols)
14993         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14994         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14995         * printcmd.c (info_symbol_command): Update.
14996         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14997         Update.
14998         * objfiles.h (class all_objfiles): Remove.
14999         * objfiles.c (have_partial_symbols, have_full_symbols)
15000         (have_minimal_symbols, qsort_cmp, update_section_map)
15001         (shared_objfile_contains_address_p)
15002         (default_iterate_over_objfiles_in_search_order): Update.
15003         * objc-lang.c (info_selectors_command, info_classes_command)
15004         (find_methods): Update.
15005         * minsyms.c (find_solib_trampoline_target): Update.
15006         * maint.c (maintenance_info_sections)
15007         (maintenance_translate_address, count_symtabs_and_blocks):
15008         Update.
15009         * main.c (captured_main_1): Update.
15010         * linux-thread-db.c (try_thread_db_load_from_pdir)
15011         (has_libpthread): Update.
15012         * linespec.c (iterate_over_all_matching_symtabs)
15013         (search_minsyms_for_name): Update.
15014         * jit.c (jit_find_objf_with_entry_addr): Update.
15015         * hppa-tdep.c (find_unwind_entry)
15016         (hppa_lookup_stub_minimal_symbol): Update.
15017         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15018         Update.
15019         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15020         (elf_gnu_ifunc_resolve_by_got): Update.
15021         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15022         * dwarf-index-write.c (save_gdb_index_command): Update.
15023         * cp-support.c (add_symbol_overload_list_qualified): Update.
15024         * breakpoint.c (create_overlay_event_breakpoint)
15025         (create_longjmp_master_breakpoint)
15026         (create_std_terminate_master_breakpoint)
15027         (create_exception_master_breakpoint): Update.
15028         * blockframe.c (find_pc_partial_function): Update.
15029         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15030         (ada_collect_symbol_completion_matches)
15031         (ada_add_global_exceptions): Update.
15032
15033 2019-01-17  Tom Tromey  <tom@tromey.com>
15034
15035         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15036         declare VEC.
15037         (solib_target_parse_libraries): Change return type.
15038         (library_list_start_segment, library_list_start_section)
15039         (library_list_end_library, library_list_start_library); Update.
15040         (solib_target_free_library_list): Remove.
15041         (solib_target_parse_libraries): Remove cleanup.  Change return
15042         type.
15043         (solib_target_current_sos): Update.
15044
15045 2019-01-17  Tom Tromey  <tromey@bapiya>
15046
15047         * valprint.c: Replace "the the" with "the".
15048         * symtab.c: Replace "the the" with "the".
15049         * solib.c: Replace "the the" with "the".
15050         * solib-dsbt.c: Replace "the the" with "the".
15051         * linespec.c: Replace "the the" with "the".
15052         * dwarf2loc.h: Replace "the the" with "the".
15053         * amd64-windows-tdep.c: Replace "the the" with "the".
15054         * aarch64-tdep.c: Replace "the the" with "the".
15055
15056 2019-01-16  Keith Seitz  <keiths@redhat.com>
15057
15058         PR gdb/23773
15059         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15060         <builder>: Rename to ..
15061         <m_builder>: ... this and make private.
15062         (dwarf2_cu::get_builder): New method.  Change all users of
15063         `builder' to use this method.
15064         (dwarf2_start_symtab): Move to ...
15065         (dwarf2_cu::start_symtab): ... here.  Update all callers
15066         (setup_type_unit_groups): Move to ...
15067         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15068         callers.
15069         (dwarf2_cu::reset_builder): New method.
15070         (process_full_compunit, process_full_type_unit): Use
15071         dwarf2_cu::reset_builder.
15072         (follow_die_offset): Record the ancestor CU if it is different
15073         from the followed DIE's CU.
15074         (follow_die_sig_1): Likewise.
15075
15076 2019-01-15  Tom Tromey  <tom@tromey.com>
15077
15078         * remote.c (class remote_state) <buf>: Now a char_vector.
15079         <buf_size>: Remove.
15080         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15081         parameter.
15082         (remote_target::getpkt_or_notif_sane_1)
15083         (remote_target::getpkt_sane)
15084         (remote_target::getpkt_or_notif_sane): Likewise.
15085         (class remote_target) <putpkt>: New overload.
15086         (remote_target::read_frame): Change type of "buf_p".  Remove
15087         sizeof_p parameter.
15088         (packet_ok): New overload.
15089         (packet_check_result): New overload.
15090         Update all uses.
15091
15092 2019-01-14  Tom Tromey  <tom@tromey.com>
15093
15094         * remote-notif.c (handle_notification, remote_notif_ack)
15095         (remote_notif_parse): Make "buf" const.
15096         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15097         const.
15098         (remote_notif_parse, remote_notif_ack, handle_notification):
15099         Likewise.
15100         * remote.c (remote_notif_stop_parse): Make "buf" const.
15101         (remote_target::remote_parse_stop_reply): Make "buf" const.
15102         (remote_notif_stop_ack): Make "buf" const.
15103
15104 2019-01-14  Tom Tromey  <tom@tromey.com>
15105
15106         * remote.c (remote_console_output): Make parameter const.
15107
15108 2019-01-14  Tom Tromey  <tom@tromey.com>
15109
15110         * target-debug.h (target_debug_print_signals): Constify.
15111         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15112         * procfs.c (procfs_target::pass_signals): Update.
15113         * linux-nat.c (linux_nat_target::pass_signals): Update.
15114         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15115         * target-delegates.c: Rebuild.
15116         * remote.c (remote_target::program_signals): Update.
15117         (remote_target::pass_signals): Update.
15118         * target.c (target_pass_signals): Constify argument.
15119         (target_program_signals): Likewise.
15120         * target.h (struct target_ops) <pass_signals, program_signals>:
15121         Constify argument.
15122         (target_pass_signals, target_program_signals): Constify argument.
15123
15124 2019-01-14  Tom Tromey  <tom@tromey.com>
15125
15126         PR tui/28819:
15127         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15128
15129 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15130
15131         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15132         field.
15133         * rs6000-tdep.c: Include reggroups.h.
15134         (IS_V_ALIAS_PSEUDOREG): Define.
15135         (rs6000_register_name): Return names for the "vX" aliases.
15136         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15137         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15138         aliases.  Call default_register_reggroup_p for all other
15139         pseudo-registers.
15140         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15141         New functions.
15142         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15143         Handle "vX" aliases.
15144         (v_alias_pseudo_register_collect): New function.
15145         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15146         (rs6000_gdbarch_init): Initialize "vX" aliases as
15147         pseudo-registers.  Restore registration of
15148         rs6000_pseudo_register_reggroup_p with
15149         set_tdesc_pseudo_register_reggroup_p.
15150
15151 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15152
15153         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15154         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15155         set_gdbarch_num_pseudo_regs.
15156
15157 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15158
15159         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15160         Remove arg prefixname, add do_set and do_show.
15161         Add member functions set_list and show_list.
15162         * cli/cli-style.c (class cli_style_option): Update accordingly.
15163         (style_set_list): Move to file scope.
15164         (style_show_list): Likewise.
15165         (set_style): Call help_list.
15166         (show_style): Call cmd_show_list.
15167         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15168         Update to use the new macro.
15169
15170 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15171
15172         * ada-lang.c (_initialize_ada_language): Expand the help text
15173         for the "catch exception" command.
15174
15175 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15176
15177         * symtab.c (matching_obj_sections): Initialize obj,
15178         declare it closer to its usage.
15179
15180 2019-01-10  Tom Tromey  <tom@tromey.com>
15181
15182         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15183         (basic_inf_threads_range): Remove.
15184         (inf_threads_range, inf_non_exited_threads_range)
15185         (safe_inf_threads_range): Use next_adapter.
15186
15187 2019-01-10  Keith Seitz  <keiths@redhat.com>
15188
15189         PR gdb/23712
15190         PR symtab/23010
15191         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15192         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15193
15194 2019-01-10  Keith Seitz  <keiths@redhat.com>
15195
15196         PR gdb/23712
15197         PR symtab/23010
15198         * dictionary.c (pending_to_vector): Remove.
15199         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15200         Remove _1 suffix, replacing functions of the same name.  Update
15201         all callers.
15202         (dict_create_hashed, dict_create_hashed_expandable)
15203         (dict_create_linear, dict_create_linear_expandable, dict_free)
15204         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15205         Make functions static.
15206
15207 2019-01-10  Keith Seitz  <keiths@redhat.com>
15208
15209         PR gdb/23712
15210         PR symtab/23010
15211         * dictionary.h (struct dictionary): Replace declaration with
15212         multidictionary.
15213         (dict_create_hashed, dict_create_hashed_expandable)
15214         (dict_create_linear, dict_create_linear_expandable)
15215         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15216         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15217         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15218         taking multidictionary argument.
15219         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15220         * block.h (struct block) <dict>: Change to multidictionary
15221         and rename `multidict'.
15222         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15223         symmisc.c: Update all dictionary references to multidictionary.
15224
15225 2019-01-10  Keith Seitz  <keiths@redhat.com>
15226
15227         PR gdb/23712
15228         PR symtab/23010
15229         * dictionary.c: Include unordered_map.
15230         (pending_to_vector): New function.
15231         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15232         Rewrite the non-"_1" functions to take vector instead
15233         of linked list.
15234         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15235         "new" _1 versions of the same name.
15236         (multidictionary): Define.
15237         (std::hash<enum language): New definition.
15238         (collate_pending_symbols_by_language, mdict_create_hashed)
15239         (mdict_create_hashed_expandable, mdict_create_linear)
15240         (mdict_create_linear_expandable, mdict_free)
15241         (find_language_dictionary, create_new_language_dictionary)
15242         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15243         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15244         (mdict_size, mdict_empty): New functions.
15245         * dictionary.h (mdict_iterator): Define.
15246
15247 2019-01-10  Pedro Alves  <palves@redhat.com>
15248
15249         * breakpoint.c (read_uploaded_action)
15250         (create_tracepoint_from_upload): Adjust to use
15251         gdb::unique_xmalloc_ptr.
15252         * ctf.c (ctf_write_uploaded_tp):
15253         (SET_ARRAY_FIELD): Use emplace_back.
15254         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15255         * tracefile-tfile.c (tfile_write_uploaded_tp):
15256         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15257         gdb::unique_xmalloc_ptr.
15258         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15259         at_string, cond_string, cmd_strings>: Replace char pointers
15260         with gdb::unique_xmalloc_ptr.
15261
15262 2019-01-10  Pedro Alves  <palves@redhat.com>
15263
15264         * solib-target.c (library_list_start_library): Don't xstrdup name.
15265
15266 2019-01-10  Pedro Alves  <palves@redhat.com>
15267
15268         * mdebugread.c (parse_partial_symbols): Use
15269         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15270
15271 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15272
15273         * linux-fork.c (scoped_switch_fork_info)
15274         <~scoped_switch_fork_info>: Fix incorrect variable name.
15275
15276 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15277
15278         * linux-fork.c (scoped_switch_fork_info)
15279         <scoped_switch_fork_info>: Make explicit.
15280         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15281
15282 2019-01-10  Tom Tromey  <tom@tromey.com>
15283
15284         * objfiles.h (objfile::reset_psymtabs): Update.
15285         * objfiles.c (objfile::objfile): Update.
15286         * psymtab.h (psymtab_storage::obstack): Update.
15287         (psymtab_storage::m_obstack): Use gdb::optional.
15288         (class psymtab_storage): Update comment.  Remove objfile
15289         parameter.
15290         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15291
15292 2019-01-10  Tom Tromey  <tom@tromey.com>
15293
15294         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15295         <free_psymtabs>: Now private.
15296         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15297         (allocate_psymtab): Use new method.
15298
15299 2019-01-10  Tom Tromey  <tom@tromey.com>
15300
15301         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15302         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15303         * mdebugread.c (parse_partial_symbols): Use
15304         allocate_dependencies.
15305         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15306         allocate_dependencies.
15307         (process_psymtab_comp_unit_reader)
15308         (build_type_psymtab_dependencies): Likewise.
15309         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15310
15311 2019-01-10  Tom Tromey  <tom@tromey.com>
15312
15313         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15314         PSYMBOL_SET_LANGUAGE.
15315         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15316
15317 2019-01-10  Tom Tromey  <tom@tromey.com>
15318
15319         * psymtab.h (psymtab_storage::obstack): New method.
15320         <m_obstack>: Rename from obstack; now private.
15321         * psymtab.c (psymtab_storage): Update.
15322         * dwarf2read.c (create_addrmap_from_index)
15323         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15324         Update.
15325
15326 2019-01-10  Tom Tromey  <tom@tromey.com>
15327
15328         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15329         * objfiles.h (objfile::reset_psymtabs): New method.
15330
15331 2019-01-10  Tom Tromey  <tom@tromey.com>
15332
15333         * symmisc.c (print_symbol_bcache_statistics): Update.
15334         (print_objfile_statistics): Update.
15335         * symfile.c (reread_symbols): Update.
15336         * psymtab.h (class psymtab_storage): New.
15337         * psymtab.c (psymtab_storage): New constructor.
15338         (~psymtab_storage): New destructor.
15339         (require_partial_symbols): Update.
15340         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15341         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15342         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15343         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15344         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15345         (start_psymtab_common, end_psymtab_common)
15346         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15347         (allocate_psymtab): Update.
15348         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15349         Update.
15350         (dump_psymtab_addrmap, maintenance_print_psymbols)
15351         (maintenance_check_psymtabs): Update.
15352         (class objfile_psymtabs): Move to objfiles.h.
15353         * psympriv.h (discard_psymtab): Now inline.
15354         (psymtab_discarder::psymtab_discarder): Update.
15355         (psymtab_discarder::~psymtab_discarder): Update.
15356         (ALL_OBJFILE_PSYMTABS): Rewrite.
15357         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15358         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15359         Remove fields.
15360         <partial_symtabs>: New field.
15361         (class objfile_psymtabs): Move from psymtab.h.  Update.
15362         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15363         psymbol_cache.
15364         (objfile::~objfile): Don't destroy psymbol_cache.
15365         * mdebugread.c (parse_partial_symbols): Update.
15366         * dwarf2read.c (create_addrmap_from_index)
15367         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15368         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15369         (add_partial_subprogram, dwarf2_ranges_read): Update.
15370         * dwarf-index-write.c (write_address_map)
15371         (write_one_signatured_type, recursively_write_psymbols)
15372         (class debug_names, class debug_names, write_psymtabs_to_index):
15373         Update.
15374
15375 2019-01-10  Tom Tromey  <tom@tromey.com>
15376
15377         * symtab.h (SYMBOL_SET_NAMES): Update.
15378         (symbol_set_names): Update.
15379         (MSYMBOL_SET_NAMES): Update.
15380         * symtab.c (symbol_set_names): Change argument to be an
15381         objfile_per_bfd_storage.
15382         * psymtab.c (add_psymbol_to_bcache): Update.
15383         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15384
15385 2019-01-10  Tom Tromey  <tom@tromey.com>
15386
15387         * symtab.c (create_demangled_names_hash): Change argument to be an
15388         objfile_per_bfd_storage.
15389         (symbol_set_names): Update.
15390
15391 2019-01-10  Tom Tromey  <tom@tromey.com>
15392
15393         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15394         init_psymbol_list.
15395         * psymtab.c (init_psymbol_list): Do nothing if already called.
15396         * psympriv.h (init_psymbol_list): Add comment.
15397         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15398         init_psymbol_list.
15399         * dbxread.c (dbx_symfile_read): Unconditionally call
15400         init_psymbol_list.
15401
15402 2019-01-10  Tom Tromey  <tom@tromey.com>
15403
15404         * xcoffread.c (scan_xcoff_symtab): Update.
15405         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15406         "where".
15407         * mdebugread.c (parse_partial_symbols)
15408         (handle_psymbol_enumerators): Update.
15409         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15410         * dbxread.c (read_dbx_symtab): Update.
15411         * psympriv.h (psymbol_placement): New enum.
15412         (add_psymbol_to_list): Update.
15413
15414 2019-01-10  Tom Tromey  <tom@tromey.com>
15415
15416         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15417         static_psymbols parameters.
15418         (scan_xcoff_symtab): Update.
15419         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15420         static_psymbols parameters.
15421         * psympriv.h (start_psymtab_common): Update.
15422         * mdebugread.c (parse_partial_symbols): Update.
15423         * dwarf2read.c (create_partial_symtab): Update.
15424         * dbxread.c (read_dbx_symtab): Update.
15425         (start_psymtab): Remove global_psymbols and static_psymbols
15426         parameters.
15427
15428 2019-01-10  Tom Tromey  <tom@tromey.com>
15429
15430         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15431         * psymtab.c (allocate_psymtab): Add comment.
15432         * psympriv.h (allocate_psymtab): Add comment.
15433         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15434         initializations.
15435         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15436
15437 2019-01-10  Tom Tromey  <tom@tromey.com>
15438
15439         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15440         Don't declare.
15441         * mipsread.c: Include mdebugread.h.
15442         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15443         Declare.
15444         * elfread.c: Include mdebugread.h.
15445
15446 2019-01-09  Tom Tromey  <tom@tromey.com>
15447
15448         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15449         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15450         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15451         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15452         (psym_lookup_symbol, psym_find_last_source_symtab)
15453         (psym_forget_cached_source_info, psym_print_stats)
15454         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15455         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15456         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15457         (psym_find_compunit_symtab_by_address)
15458         (maintenance_print_psymbols, maintenance_info_psymtabs)
15459         (maintenance_check_psymtabs): Use ranged for.
15460         * psymtab.h (class objfile_psymtabs): New.
15461         (require_partial_symbols): Return objfile_psymtabs.
15462         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15463
15464 2019-01-09  Tom Tromey  <tom@tromey.com>
15465
15466         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15467         (find_pc_mapped_section, list_overlays_command)
15468         (map_overlay_command, unmap_overlay_command)
15469         (simple_overlay_update): Use all_objfiles.
15470         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15471         * printcmd.c (info_symbol_command): Use all_objfiles.
15472         * objfiles.h (ALL_OBJSECTIONS): Remove.
15473         * maint.c (maintenance_translate_address): Use all_objfiles.
15474         * gcore.c (gcore_create_callback): Use all_objfiles.
15475         (objfile_find_memory_regions): Likewise.
15476
15477 2019-01-09  Tom Tromey  <tom@tromey.com>
15478
15479         * symtab.c (find_line_symtab, info_sources_command)
15480         (make_source_files_completion_list): Use objfile_compunits.
15481         * source.c (select_source_symtab): Use objfile_compunits.
15482         * objfiles.h (struct objfile): Update comment.
15483         (ALL_OBJFILES): Remove.
15484         (ALL_FILETABS): Remove.
15485         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15486         objfile_compunits.
15487
15488 2019-01-09  Tom Tromey  <tom@tromey.com>
15489
15490         * symmisc.c (print_objfile_statistics, dump_objfile)
15491         (maintenance_print_symbols): Use compunit_filetabs.
15492         * source.c (forget_cached_source_info_for_objfile): Use
15493         compunit_filetabs.
15494         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15495         (ALL_FILETABS): Use compunit_filetabs.
15496         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15497         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15498
15499 2019-01-09  Tom Tromey  <tom@tromey.com>
15500
15501         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15502         (compunit_filetabs): New.
15503         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15504         compunit_filetabs.
15505         (info_sources_command, make_source_files_completion_list): Remove
15506         declaration.
15507         * symmisc.c (print_objfile_statistics, dump_objfile)
15508         (maintenance_print_symbols): Remove declaration.
15509         (maintenance_info_symtabs): Use compunit_filetabs.
15510         (maintenance_info_line_tables): Likewise.
15511         * source.c (select_source_symtab): Change local variable name.
15512         (forget_cached_source_info_for_objfile): Remove declaration.
15513         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15514         * objfiles.c (objfile_relocate1): Remove declaration.
15515         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15516         declaration.
15517         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15518         * coffread.c (coff_symtab_read): Remove declaration.
15519         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15520         compunit_filetabs.
15521
15522 2019-01-09  Tom Tromey  <tom@tromey.com>
15523
15524         * symtab.c (lookup_objfile_from_block)
15525         (find_pc_sect_compunit_symtab, search_symbols)
15526         (default_collect_symbol_completion_matches_break_on): Use
15527         objfile_compunits.
15528         * objfiles.h (ALL_COMPUNITS): Remove.
15529         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15530         * cp-support.c (add_symbol_overload_list_qualified): Use
15531         objfile_compunits.
15532         * ada-lang.c (ada_collect_symbol_completion_matches)
15533         (ada_add_global_exceptions): Use objfile_compunits.
15534
15535 2019-01-09  Tom Tromey  <tom@tromey.com>
15536
15537         * source.c (select_source_symtab)
15538         (forget_cached_source_info_for_objfile): Remove declaration.
15539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15540         declaration.
15541         * maint.c (count_symtabs_and_blocks): Remove declaration.
15542         * cp-support.c (add_symbol_overload_list_qualified): Remove
15543         declaration.
15544         * coffread.c (coff_symtab_read): Remove declaration.
15545         * symtab.c (lookup_symbol_in_objfile_symtabs)
15546         (basic_lookup_transparent_type_1): Use objfile_compunits.
15547         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15548         (info_sources_command, search_symbols)
15549         (default_collect_symbol_completion_matches_break_on)
15550         (make_source_files_completion_list): Remove declaration.
15551         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15552         (ada_collect_symbol_completion_matches)
15553         (ada_add_global_exceptions): Remove declaration.
15554         * linespec.c (iterate_over_all_matching_symtabs): Use
15555         objfile_compunits.
15556         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15557         (class objfile_compunits): New.
15558         (ALL_COMPUNITS): Use objfile_compunits.
15559         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15560         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15561         objfile_compunits.
15562         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15563
15564 2019-01-09  Tom Tromey  <tom@tromey.com>
15565
15566         * symtab.c (search_symbols)
15567         (default_collect_symbol_completion_matches_break_on): Use
15568         objfile_msymbols.
15569         * ada-lang.c (ada_lookup_simple_minsym)
15570         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15571         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15572         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15573         objfile_msymbols.
15574         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15575         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15576         * objc-lang.c (find_methods): Use objfile_msymbols.
15577         (info_selectors_command, info_classes_command): Likewise.
15578         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15579         * objfiles.h (class objfile_msymbols): New.
15580         (ALL_OBJFILE_MSYMBOLS): Remove.
15581         (ALL_MSYMBOLS): Remove.
15582
15583 2019-01-09  Tom Tromey  <tom@tromey.com>
15584
15585         * common/next-iterator.h (next_adapter): Add Iterator template
15586         parameter.
15587         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15588         (class all_objfiles_safe): New.
15589         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15590         * objfiles.c (put_objfile_before): Update comment.
15591         (add_separate_debug_objfile): Likewise.
15592         (free_all_objfiles): Use all_objfiles_safe.
15593         (objfile_purge_solibs): Likewise.
15594
15595 2019-01-09  Tom Tromey  <tom@tromey.com>
15596
15597         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15598         (expand_symtab_containing_pc, lookup_static_symbol)
15599         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15600         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15601         all_objfiles.
15602         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15603         * breakpoint.c (create_overlay_event_breakpoint)
15604         (create_longjmp_master_breakpoint)
15605         (create_std_terminate_master_breakpoint)
15606         (create_exception_master_breakpoint): Use all_objfiles.
15607         * linux-thread-db.c (try_thread_db_load_from_pdir)
15608         (has_libpthread): Use all_objfiles.
15609         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15610         * linespec.c (iterate_over_all_matching_symtabs)
15611         (search_minsyms_for_name): Use all_objfiles.
15612         * maint.c (maintenance_info_sections): Use all_objfiles.
15613         * main.c (captured_main_1): Use all_objfiles.
15614         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15615         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15616         * guile/scm-pretty-print.c
15617         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15618         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15619         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15620         (maintenance_print_msymbols): Use all_objfiles.
15621         * source.c (select_source_symtab): Use all_objfiles.
15622         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15623         * symfile.c (remove_symbol_file_command)
15624         (expand_symtabs_matching, map_symbol_filenames): Use
15625         all_objfiles.
15626         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15627         all_objfiles.
15628         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15629         * objc-lang.c (find_methods): Use all_objfiles.
15630         * objfiles.c (have_partial_symbols, have_full_symbols)
15631         (have_minimal_symbols, qsort_cmp)
15632         (default_iterate_over_objfiles_in_search_order): Use
15633         all_objfiles.
15634         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15635         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15636         (maintenance_check_psymtabs): Use all_objfiles.
15637         (ALL_PSYMTABS): Remove.
15638         * compile/compile-object-run.c (do_module_cleanup): Use
15639         all_objfiles.
15640         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15641         * cp-support.c (add_symbol_overload_list_qualified): Use
15642         all_objfiles.
15643         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15644         Use all_objfiles.
15645         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15646         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15647         all_objfiles.
15648         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15649         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15650         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15651         Uses all_objfiles.
15652         * solib.c (solib_read_symbols): Use all_objfiles
15653
15654 2019-01-09  Tom Tromey  <tom@tromey.com>
15655
15656         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15657         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15658         all_objfiles.
15659         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15660         * symmisc.c (print_symbol_bcache_statistics)
15661         (print_objfile_statistics, maintenance_print_objfiles)
15662         (maintenance_info_symtabs, maintenance_check_symtabs)
15663         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15664         all_objfiles.
15665         * source.c (forget_cached_source_info): Use all_objfiles.
15666         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15667         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15668         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15669         * objfiles.c (update_section_map): Use all_objfiles.
15670         (shared_objfile_contains_address_p): Likewise.
15671         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15672         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15673
15674 2019-01-09  Tom Tromey  <tom@tromey.com>
15675
15676         * common/next-iterator.h: New file.
15677         * objfiles.h (class all_objfiles): New.
15678         (struct objfile_iterator): New.
15679
15680 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15681
15682         * NEWS: Move the description of the changed "frame", "select-frame",
15683          and "info frame" commands to the Changed commands section.
15684
15685 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15686
15687         * gdbtypes.c (check_stub_method_group): Remove handling of old
15688         mangling schemes.
15689         * linespec.c (find_methods): Likewise.
15690         * stabsread.c (read_member_functions): Likewise.
15691         * valops.c (search_struct_method): Likewise.
15692         (value_struct_elt_for_reference): Likewise.
15693         * NEWS: Mention this change.
15694
15695 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15696
15697         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15698         print_source_lines.
15699         * source.c (print_source_lines_base): Update line number check.
15700         (print_source_lines): New function.
15701         (source_lines_range::source_lines_range): New function.
15702         * source.h (class source_lines_range): New class.
15703         (print_source_lines): New declaration.
15704
15705 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15706
15707         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15708
15709 2019-01-08  Tom Tromey  <tom@tromey.com>
15710             Simon Marchi  <simon.marchi@ericsson.com>
15711
15712         PR gdb/24060
15713         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15714         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15715         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15716         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15717         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15718         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15719
15720 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15721
15722         * source.c (select_source_symtab): Move header comment to
15723         declaration in source.h.
15724         (forget_cached_source_info_for_objfile): Likewise.
15725         (forget_cached_source_info): Likewise.
15726         (identify_source_line): Likewise.
15727         * source.h (identify_source_line): Move declaration from symtab.h
15728         and add comment from source.c
15729         (print_source_lines): Likewise.
15730         (forget_cached_source_info_for_objfile): Likewise.
15731         (forget_cached_source_info): Likewise.
15732         (select_source_symtab): Likewise.
15733         (enum print_source_lines_flag): Move definition from symtab.h.
15734         * symtab.h (identify_source_line): Move declaration to source.h.
15735         (print_source_lines): Likewise.
15736         (forget_cached_source_info_for_objfile): Likewise.
15737         (forget_cached_source_info): Likewise.
15738         (select_source_symtab): Likewise.
15739         (enum print_source_lines_flag): Move definition to source.h.
15740         * tui/tui-hooks.c: Add 'source.h' include.
15741
15742 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15743
15744         * source.c (print_source_lines_base): Handle requests to print
15745         reverse line number sequences, and guard against empty lines
15746         string.
15747
15748 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15749
15750         * source.c (print_source_lines_base): Fix skip of '\r' if next
15751         character is '\n'.
15752
15753 2019-01-06  Tom Tromey  <tom@tromey.com>
15754
15755         * c-exp.y (struct c_parse_state) <macro_original_text,
15756         expansion_obstack>: New member.
15757         (macro_original_text, expansion_obstack): Remove globals.
15758         (scan_macro_expansion, scanning_macro_expansion)
15759         (finished_macro_expansion): Update.
15760         (scan_macro_cleanup): Remove.
15761         (yylex, c_parse): Update.
15762
15763 2019-01-06  Tom Tromey  <tom@tromey.com>
15764
15765         * c-exp.y (struct c_parse_state) <strings>: New member.
15766         (operator_stoken): Update.
15767
15768 2019-01-06  Tom Tromey  <tom@tromey.com>
15769
15770         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15771         (union type_stack_elt) <typelist_val>: Now a pointer to
15772         std::vector.
15773         (type_stack_cleanup): Don't declare.
15774         (push_typelist): Update.
15775         * parse.c (pop_typelist): Return a std::vector.
15776         (push_typelist): Take a std::vector.
15777         (follow_types): Update.  Do not free args.
15778         (type_stack_cleanup): Remove.
15779         * c-exp.y (struct c_parse_state): New.
15780         (cpstate): New global.
15781         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15782         (nonempty_typelist): Update.
15783         (func_mod): Create a new vector.
15784         (c_parse): Create a c_parse_state.
15785         (check_parameter_typelist): Do not delete params.
15786         (function_method): Update.  Do not delete type_list.
15787
15788 2019-01-06  Tom Tromey  <tom@tromey.com>
15789
15790         PR gdb/28155:
15791         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15792         check_typedef.
15793         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15794         (print_return_value): Likewise.
15795
15796 2019-01-05  Tom Tromey  <tom@tromey.com>
15797
15798         * contrib/cleanup_check.py: Remove.
15799         * contrib/gcc-with-excheck: Remove.
15800         * contrib/exsummary.py: Remove.
15801         * contrib/excheck.py: Remove.
15802
15803 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15804
15805         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15806         NULL. Initialize tpprev to NULL instead of assigning it
15807         to NULL on the next statement.
15808         * windows-nat.c (windows_delete_thread): Remove check for
15809         main_thread_id before printing thread exit notifications.
15810         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15811         Remove thread ID check against main_thread_id.
15812         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15813         windows_delete_thread.
15814         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15815
15816 2019-01-04  Tom Tromey  <tom@tromey.com>
15817
15818         * compile/compile.c (_initialize_compile): Use upper case for
15819         metasyntactic variables.
15820         * symmisc.c (_initialize_symmisc): Use upper case for
15821         metasyntactic variables.
15822         * psymtab.c (_initialize_psymtab): Use upper case for
15823         metasyntactic variables.
15824         * demangle.c (demangle_command): Use upper case for metasyntactic
15825         variables.
15826         (_initialize_demangler): Likewise.
15827         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15828         variables.
15829
15830 2019-01-03  Tom Tromey  <tom@tromey.com>
15831
15832         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15833
15834 2019-01-03  Tom Tromey  <tom@tromey.com>
15835
15836         * python/py-symtab.c (salpy_str): Update.
15837         (struct salpy_sal_object) <symtab>: Now a PyObject.
15838         (salpy_dealloc): Update.
15839         (del_objfile_sal): Use gdbpy_ref.
15840
15841 2019-01-03  Tom Tromey  <tom@tromey.com>
15842
15843         * python/py-type.c (convert_field): Use new_reference.  Return
15844         gdbpy_ref.
15845         (make_fielditem): Return gdbpy_ref.
15846         (typy_fields): Update.
15847         (typy_getitem): Update.
15848         (field_name): Return gdbpy_ref.  Use new_reference.
15849         (typy_iterator_iternext): Update.
15850
15851 2019-01-03  Tom Tromey  <tom@tromey.com>
15852
15853         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15854
15855 2019-01-03  Tom Tromey  <tom@tromey.com>
15856
15857         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15858         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15859         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15860         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15861         (pspy_set_type_printers): Likewise.
15862         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15863         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15864         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15865         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15866         (objfpy_set_type_printers): Likewise.
15867
15868 2019-01-03  Tom Tromey  <tom@tromey.com>
15869
15870         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15871         (gdbpy_print_stack): Use gdbpy_err_fetch.
15872         * python/python-internal.h (class gdbpy_err_fetch): New class.
15873         (class gdbpy_enter) <m_error_type, m_error_value,
15874         m_error_traceback>: Remove.
15875         <m_error>: New member.
15876         (gdbpy_exception_to_string): Don't declare.
15877         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15878         * python/py-value.c (convert_value_from_python): Use
15879         gdbpy_err_fetch.
15880         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15881         gdbpy_exception_to_string.
15882         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15883         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15884         gdbpy_err_fetch.
15885
15886 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15887
15888         * linux-nat.c (delete_lwp_cleanup): Delete.
15889         (struct lwp_deleter): New struct.
15890         (lwp_info_up): New typedef.
15891         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15892         lwp_info_up.
15893
15894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15895
15896         * linux-fork.c (class scoped_switch_fork_info): New class.
15897         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15898
15899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15900
15901         * valops.c (find_overload_match): Remove use of null_cleanup, and
15902         calls to do_cleanups.
15903
15904 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15905
15906         * compile/compile-cplus-types.c
15907         (compile_cplus_instance::decl_name): Handle changes to
15908         cp_func_name.
15909         * cp-support.c (cp_func_name): Update header comment, update
15910         return type.
15911         * cp-support.h (cp_func_name): Update return type in declaration.
15912         * valops.c (find_overload_match): Move temp_func local to top
15913         level of function and change its type.  Use temp_func to hold and
15914         delete temporary string obtained from cp_func_name.
15915
15916 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15917
15918         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15919         gdb::char_vector, remove cleanup, and update uses of `msg`.
15920
15921 2019-01-03  Jim Wilson  <jimw@sifive.com>
15922
15923         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15924
15925 2019-01-02  Tom Tromey  <tom@tromey.com>
15926
15927         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15928         (tdesc_parse_xml): Remove cleanups.
15929         * target-descriptions.h (make_cleanup_free_target_description):
15930         Don't declare.
15931         (target_desc_deleter): New struct.
15932         (target_desc_up): New typedef.
15933         * target-descriptions.c (target_desc_deleter::operator()): Rename
15934         from free_target_description.
15935         (make_cleanup_free_target_description): Remove.
15936
15937 2019-01-02  Tom Tromey  <tom@tromey.com>
15938
15939         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15940         constructor, destructor.
15941         (linespec_parser): Remove typedef.
15942         (~linespec_parser): Rename from linespec_parser_delete.
15943         (linespec_lex_to_end, linespec_complete_label)
15944         (linespec_complete): Update.
15945         (decode_line_full): Remove cleanups.
15946         (decode_line_1): Update.
15947
15948 2019-01-02  Tom Tromey  <tom@tromey.com>
15949
15950         * python/python-internal.h (inferior_to_inferior_object): Change
15951         return type.
15952         * python/py-exitedevent.c (create_exited_event_object): Update.
15953         * python/py-inferior.c (inferior_to_inferior_object): Return
15954         gdbpy_ref.
15955         (python_new_inferior, python_inferior_deleted)
15956         (thread_to_thread_object, delete_thread_object)
15957         (build_inferior_list, gdbpy_selected_inferior): Update.
15958         * python/py-infthread.c (create_thread_object): Update.  Also fail
15959         if inferior_to_inferior_object fails.
15960
15961 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15962
15963         * inferior.h (class inferior) <displaced_step_state>: New field.
15964         * infrun.h (struct displaced_step_state): Move here from
15965         infrun.c.  Initialize fields, add constructor.
15966         <inf>: Remove field.
15967         <reset>: New method.
15968         * infrun.c (struct displaced_step_inferior_state): Move to
15969         infrun.h.
15970         (displaced_step_inferior_states): Remove.
15971         (get_displaced_stepping_state): Adust.
15972         (displaced_step_in_progress_any_inferior): Adjust.
15973         (displaced_step_in_progress_thread): Adjust.
15974         (displaced_step_in_progress): Adjust.
15975         (add_displaced_stepping_state): Remove.
15976         (get_displaced_step_closure_by_addr): Adjust.
15977         (remove_displaced_stepping_state): Remove.
15978         (infrun_inferior_exit): Call displaced_step_state.reset.
15979         (use_displaced_stepping): Don't check for NULL.
15980         (displaced_step_prepare_throw): Call
15981         get_displaced_stepping_state.
15982         (displaced_step_fixup): Don't check for NULL.
15983         (prepare_for_detach): Don't check for NULL.
15984
15985 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15986
15987         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15988          in case of call that did not complete.
15989
15990 2019-01-02  Andrey Utkin  <autkin@undo.io>
15991
15992         * symfile.c (find_separate_debug_file): Fix search of debug files for
15993         remote debuggee.
15994
15995 2019-01-02  Tom Tromey  <tom@tromey.com>
15996
15997         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15998         indentation.
15999         * python/py-frame.c (frapy_older): Remove cast.
16000         (frapy_newer): Likewise.
16001         * python/py-breakpoint.c (local_setattro): Remove cast.
16002         * python/py-arch.c (archpy_name): Remove local variable.
16003         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16004
16005 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16006
16007         * unittests/basic_string_view/element_access/char/empty.cc:
16008         Fix year range in copyright header.
16009
16010 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16011
16012         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16013         Delete.
16014         <operator==>: Update with for removed field.
16015         <hash>: Likewise.
16016         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16017         <isa_features>: ...this.
16018         <abi_features>: New field.
16019         (riscv_isa_flen): Update comment.
16020         (riscv_abi_xlen): New declaration.
16021         (riscv_abi_flen): New declaration.
16022         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16023         isa_features.
16024         (riscv_abi_xlen): New function.
16025         (riscv_isa_flen): Update to get answer from isa_features.
16026         (riscv_abi_flen): New function.
16027         (riscv_has_fp_abi): Update to get answer from abi_features.
16028         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16029         xlen and flen.
16030         (riscv_call_info) <xlen, flen>: Update comment.
16031         (riscv_call_arg_struct): Remove invalid assertions
16032         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16033         is removed.
16034         (riscv_gdbarch_init): Gather isa features and abi features
16035         separately, ensure both match on the gdbarch when reusing an old
16036         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16037         a target with 64-bit float hardware.
16038
16039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16040
16041         * source.c (search_command_helper): Stop reverse search
16042         when line 1 has been searched.
16043
16044 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16045
16046         * record-full.c (record_full_base_target::close): Rewrite
16047         record_full_core_buf_list free logic.
16048
16049 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16050
16051         * break-catch-syscall.c (print_one_catch_syscall): xfree
16052         the last text.
16053
16054 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16055
16056         * top.c (print_gdb_version): Update Copyright year in version
16057         message.
16058
16059 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16060
16061         Update copyright year range in all GDB files.
16062
16063 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16064
16065         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16066
16067 For older changes see ChangeLog-2018.
16068 \f
16069 Local Variables:
16070 mode: change-log
16071 left-margin: 8
16072 fill-column: 74
16073 version-control: never
16074 coding: utf-8
16075 End:
16076