gdb/ChangeLog

   1 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
   2
   3         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
   4         debug output.
   5         * jit.c (jit_unregister_code): Add debug print to match
   6         `jit_register_code`.
   7
   8 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * NEWS: Mention the new multithreaded symbol loading.
  11
  12 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * maint.c (n_worker_threads): Default to 0.
  15         (worker_threads_disabled): New function.
  16         * maint.h (worker_threads_disabled): New function.
  17         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
  18         here if worker_threads_disabled () is true.
  19         (minimal_symbol_reader::install): Skip all threading if
  20         worker_threads_disabled () is true.
  21
  22 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
  25         hash code if possible.
  26         (add_minsym_to_demangled_hash_table): Likewise.
  27         (minimal_symbol_reader::install): Compute the hash codes for msymbol
  28         on the background thread.
  29         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
  30         Add these fields.
  31
  32 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
  35         of the mangled name on the background thread.
  36         * symtab.c (symbol_set_names): Allow passing in the hash of the
  37         linkage_name.
  38         * symtab.h (symbol_set_names): Likewise.
  39
  40 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
  41
  42         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
  43         physnames are computed for inherited DIEs.
  44
  45 2019-11-27  Tom Tromey  <tromey@adacore.com>
  46
  47         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
  48         backslashes.
  49         * cp-support.c: Remove unnecessary backslashes.
  50
  51 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  52
  53         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
  54         with sym->set_linkage_name.
  55         * coffread.c (coff_read_enum_type): Likewise.
  56         * mdebugread.c (parse_symbol): Likewise.
  57         * stabsread.c (patch_block_stabs): Likewise.
  58         (define_symbol): Likewise.
  59         (read_enum_type): Likewise.
  60         (common_block_end): Likewise.
  61         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
  62         function.
  63         (SYMBOL_SET_LINKAGE_NAME): Remove.
  64         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
  65         with sym->set_linkage_name.
  66
  67 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  68
  69         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
  70         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
  71         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
  72         * NEWS: Mention new MI command.
  73
  74 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
  77         '-symbol-info-types', and '-symbol-info-variables'.
  78         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
  79         (mi_cmd_symbol_info_types): Declare.
  80         (mi_cmd_symbol_info_variables): Declare.
  81         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
  82         (output_debug_symbol): New function.
  83         (output_nondebug_symbol): New function.
  84         (mi_symbol_info): New function.
  85         (mi_info_functions_or_variables): New function.
  86         (mi_cmd_symbol_info_functions): New function.
  87         (mi_cmd_symbol_info_types): New function.
  88         (mi_cmd_symbol_info_variables): New function.
  89         * NEWS: Mention new commands.
  90
  91 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  92
  93         * symtab.c (symbol_to_info_string): New function, most content
  94         moved from print_symbol_info, but updated to return a std::string.
  95         (print_symbol_info): Update to use symbol_to_info_string and print
  96         returned string.
  97         * symtab.h (symbol_to_info_string): Declare new function.
  98
  99 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 100
 101         * python/python.c (gdbpy_rbreak): Convert to using
 102         global_symbol_searcher.
 103         * symtab.c (file_matches): Convert return type to bool, change
 104         file list to std::vector, update header comment.
 105         (search_symbols): Rename to...
 106         (global_symbol_searcher::search): ...this and update now its
 107         a member function of global_symbol_searcher.  Take account of the
 108         changes to file_matches.
 109         (symtab_symbol_info): Convert to using global_symbol_searcher.
 110         (rbreak_command): Likewise.
 111         (search_module_symbols): Likewise.
 112         * symtab.h (enum symbol_search): Update comment.
 113         (search_symbols): Remove declaration.
 114         (class global_symbol_searcher): New class.
 115
 116 2019-11-26  Tom Tromey  <tromey@adacore.com>
 117
 118         * cp-support.c (_initialize_cp_support): Conditionally initialize
 119         gdb_demangle_attempt_core_dump.
 120
 121 2019-11-26  Tom Tromey  <tom@tromey.com>
 122
 123         * python/py-function.c (fnpy_init): Update.
 124         * value.h (add_internal_function): Adjust declaration.
 125         * value.c (function_destroyer): Remove.
 126         (do_add_internal_function): Don't set destroyer or copy name.
 127         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 128         Set name_allocated.
 129         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 130         (cmdpy_init): Set name_allocated.
 131         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 132         member.
 133         (~cmd_list_element): Free "name" if needed.
 134
 135 2019-11-26  Tom Tromey  <tom@tromey.com>
 136
 137         * value.h (add_internal_function): Add new overload.  Move
 138         documentation from value.h.
 139         * value.c (do_add_internal_function): New function.
 140         (add_internal_function): Use it.  Add new overload.
 141         (function_destroyer): Don't free doc.
 142         * python/py-function.c (fnpy_init): Update.
 143
 144 2019-11-26  Tom Tromey  <tom@tromey.com>
 145
 146         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 147         (cmdpy_init): Set "doc_allocated".
 148
 149 2019-11-26  Tom Tromey  <tom@tromey.com>
 150
 151         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 152         name of worker thread.
 153         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 154         pthread_setname_np.
 155         * configure, config.in: Rebuild.
 156
 157 2019-11-26  Tom Tromey  <tom@tromey.com>
 158
 159         * python/python.c (class gdbpy_gil): New.
 160         (struct gdbpy_event): Add constructor, destructor, operator().
 161         (gdbpy_post_event): Use run_on_main_thread.
 162         (gdbpy_initialize_events): Remove.
 163         (do_start_initialization): Update.
 164
 165 2019-11-26  Tom Tromey  <tom@tromey.com>
 166
 167         * NEWS: Add entry.
 168         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 169         commands.  Call update_thread_pool_size.
 170         (update_thread_pool_size, maintenance_set_worker_threads): New
 171         functions.
 172         (n_worker_threads): New global.
 173
 174 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 175             Tom Tromey  <tom@tromey.com>
 176
 177         * minsyms.c (minimal_symbol_reader::install): Use
 178         parallel_for_each.
 179         * gdbsupport/parallel-for.h: New file.
 180         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 181
 182 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 183             Tom Tromey  <tom@tromey.com>
 184
 185         * gdbsupport/thread-pool.h: New file.
 186         * gdbsupport/thread-pool.c: New file.
 187         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 188         (HFILES_NO_SRCDIR): Add thread-pool.h.
 189
 190 2019-11-26  Tom Tromey  <tom@tromey.com>
 191
 192         * event-top.h (thread_local_segv_handler): Declare.
 193         * event-top.c (thread_local_segv_handler): New global.
 194         (install_handle_sigsegv, handle_sigsegv): New functions.
 195         (async_init_signals): Install SIGSEGV handler.
 196         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 197         thread-local.
 198         (report_failed_demangle): New function.
 199         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 200         handler-setting code, instead use segv_handler.  Run warning code
 201         on main thread.
 202
 203 2019-11-26  Tom Tromey  <tom@tromey.com>
 204
 205         * run-on-main-thread.c: New file.
 206         * run-on-main-thread.h: New file.
 207         * unittests/main-thread-selftests.c: New file.
 208         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 209         main-thread-selftests.c.
 210         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 211         (COMMON_SFILES): Add run-on-main-thread.c.
 212
 213 2019-11-26  Tom Tromey  <tom@tromey.com>
 214
 215         * main.c (setup_alternate_signal_stack): Remove.
 216         (captured_main_1): Use gdb::alternate_signal_stack.
 217         * gdbsupport/alt-stack.h: New file.
 218
 219 2019-11-26  Tom Tromey  <tom@tromey.com>
 220
 221         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 222         Remove comment.
 223         (save_original_signals_state, restore_original_signals_state): Use
 224         gdb_sigmask.
 225         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 226         (_initialize_linux_nat): Use gdb_sigmask.
 227         * guile/guile.c (_initialize_guile): Use block_signals.
 228         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 229         * gdbsupport/gdb-sigmask.h: New file.
 230         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 231         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 232         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 233         pthread_sigmask.
 234         * configure, config.in: Rebuild.
 235         * gdbsupport/block-signals.h: New file.
 236
 237 2019-11-26  Tom Tromey  <tom@tromey.com>
 238
 239         * acinclude.m4: Include ax_pthread.m4.
 240         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 241         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 242         (CLIBS): Use PTHREAD_LIBS.
 243         (aclocal_m4_deps): Add ax_pthread.m4.
 244         * config.in, configure: Rebuild.
 245         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 246
 247 2019-11-26  Tom Tromey  <tom@tromey.com>
 248
 249         * symtab.h (struct minimal_symbol) <name_set>: New member.
 250         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 251         Don't call symbol_set_names.
 252         (minimal_symbol_reader::install): Call symbol_set_names.
 253
 254 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 255
 256         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 257         restore_active_ext_lang, as GIL is needed for (indirectly)
 258         called PyOS_InterruptOccurred.
 259
 260 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 261
 262         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 263         definition.
 264
 265 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 266
 267         * remote-sim.c (simulator_command): Make static, remove
 268         declaration.
 269
 270 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 271
 272         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 273         static.
 274         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 275         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 276         (main): Likewise.
 277         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 278         (main): Likewise.
 279         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 280         (main): Likewise.
 281         * unittests/basic_string_view/element_access/char/1.cc (test01):
 282         Likewise.
 283         (main): Likewise.
 284         * unittests/basic_string_view/element_access/char/empty.cc (main):
 285         Likewise.
 286         * unittests/basic_string_view/element_access/char/front_back.cc
 287         (test01): Likewise.
 288         (main): Likewise.
 289         * unittests/basic_string_view/inserters/char/2.cc (test05):
 290         Likewise.
 291         (main): Likewise.
 292         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 293         (test01): Likewise.
 294         (main): Likewise.
 295         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 296         (test01): Likewise.
 297         (main): Likewise.
 298         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 299         Likewise.
 300         * unittests/basic_string_view/operations/compare/char/1.cc
 301         (test01): Likewise.
 302         (main): Likewise.
 303         * unittests/basic_string_view/operations/compare/char/13650.cc
 304         (test01): Likewise.
 305         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 306         Likewise.
 307         (main): Likewise.
 308         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 309         Likewise.
 310         (main): Likewise.
 311         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 312         Likewise.
 313         (main): Likewise.
 314         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 315         Likewise.
 316         (main): Likewise.
 317         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 318         Likewise.
 319         (main): Likewise.
 320         * unittests/basic_string_view/operations/find/char/4.cc (main):
 321         Likewise.
 322         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 323         Likewise.
 324         (main): Likewise.
 325         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 326         Likewise.
 327         (main): Likewise.
 328         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 329         Likewise.
 330         (main): Likewise.
 331         * unittests/basic_string_view/operations/substr/char/1.cc
 332         (test01): Likewise.
 333         (main): Likewise.
 334         * unittests/basic_string_view/operators/char/2.cc (main):
 335         Likewise.
 336         * unittests/optional/assignment/1.cc (test): Likewise.
 337         * unittests/optional/assignment/2.cc (test): Likewise.
 338         * unittests/optional/assignment/3.cc (test): Likewise.
 339         * unittests/optional/assignment/4.cc (test): Likewise.
 340         * unittests/optional/assignment/5.cc (test): Likewise.
 341         * unittests/optional/assignment/6.cc (test): Likewise.
 342         * unittests/optional/assignment/7.cc (test): Likewise.
 343         * unittests/optional/cons/copy.cc (test): Likewise.
 344         * unittests/optional/cons/default.cc (test): Likewise.
 345         * unittests/optional/cons/move.cc (test): Likewise.
 346         * unittests/optional/cons/value.cc (test): Likewise.
 347         * unittests/optional/in_place.cc (test): Likewise.
 348         * unittests/optional/observers/1.cc (test): Likewise.
 349         * unittests/optional/observers/2.cc (test): Likewise.
 350
 351 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 352
 353         * tui-win.h (tui_set_var_cmd): Remove.
 354         * tui-win.c (tui_set_var_cmd): Make static.
 355
 356 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 357
 358         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 359         rbreak_command_wrapper): Remove.
 360         * symtab.c (rbreak_command_wrapper): Remove.
 361
 362 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 363
 364         * inferior.h (info_terminal_command): Remove declaration.
 365         * inflow.c (info_terminal_command): Make static.
 366
 367 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 368
 369         * inferior.c (exit_inferior_silent): Remove.
 370
 371 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 372
 373         * dictionary.c (dict_empty, mdict_empty): Remove.
 374         * dictionary.c (mdict_empty): Remove.
 375
 376 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 377
 378          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 379          (arc_insn_get_memory_offset): Likewise.
 380          (arc_insn_dump): Likewise.
 381          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 382          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 383          * dictionary.c (dict_iterator_next): Likewise.
 384          (dict_iter_match_first): Likewise.
 385          (dict_iter_match_next): Likewise.
 386          * f-lang.c (evaluate_subexp_f): Likewise.
 387          * hppa-tdep.c (hppa_read_pc): Likewise.
 388          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 389          * parse.c (write_exp_elt_msym): Likewise.
 390          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 391          * remote.c (remote_packet_size): Likewise.
 392          (remote_notif_stop_parse): Likewise.
 393          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 394          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 395          * source.c (prepare_path_for_appending): Likewise.
 396          * sparc64-linux-tdep.c
 397          (sparc64_linux_handle_segmentation_fault); Likewise.
 398          * stack.c (frame_selection_by_function_completer): Likewise.
 399
 400 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 401
 402         * completer.c (set_gdb_completion_word_break_characters):
 403         Remove.
 404
 405 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 406
 407         * dwarf-index-write.c: Include dwarf-index-write.h.
 408         * mi/mi-interp.c: Include mi/mi-interp.h.
 409
 410 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 411
 412         * aarch32-tdep.c: Include aarch32-tdep.h.
 413         * aarch32-tdep.h: Forward-declare struct target_desc.
 414
 415 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 416
 417         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 418         strerror.
 419         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 420         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 421
 422 2019-11-25  Tom de Vries  <tdevries@suse.de>
 423
 424         * contrib/words.sh: Add -c option.
 425
 426 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 427
 428         * solib.c (solib_find_1): Change int to bool.
 429         (exec_file_find): Change int to bool.
 430         (solib_find): Change int to bool.
 431         (solib_read_symbols): Change int to bool.
 432         (solib_used): Change int to bool.
 433         (solib_add): Change int to bool.
 434         (info_sharedlibrary_command): Change int to bool.
 435         (solib_contains_address_p): Change int to bool.
 436         (solib_keep_data_in_core): Change int to bool.
 437         (in_solib_dynsym_resolve_code): Change int to bool.
 438         (reload_shared_libraries_1): Change int to bool.
 439         (gdb_sysroot_changed): Change int to bool.
 440         * solib.h (solib_read_symbols): Change int to bool.
 441         (solib_contains_address_p): Change int to bool.
 442         (solib_keep_data_in_core): Change int to bool.
 443         (in_solib_dynsym_resolve_code): Change int to bool.
 444         (libpthread_name_p): Change int to bool.
 445
 446 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 447
 448         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 449         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 450         (remote_packet_max_chars): New static global.
 451         (show_remote_packet_max_chars): New function.
 452         (remote_target::putpkt_binary): Adjust to use new
 453         remote_packet_max_chars option.
 454         (remote_target::getpkt_or_notif_sane_1): Likewise.
 455         (_initialize_remote): Register new remote-packet-max-chars option.
 456
 457 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 458
 459         * m68k-linux-nat.c: Include gdbarch.h.
 460
 461 2019-11-24  Tom Tromey  <tom@tromey.com>
 462
 463         * symfile.c (read_symbols): Update.
 464         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 465         bool.
 466         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 467         (psym_lookup_symbol, psym_find_last_source_symtab)
 468         (psym_forget_cached_source_info, psym_print_stats)
 469         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 470         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 471         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 472         (psym_find_compunit_symtab_by_address)
 473         (maintenance_print_psymbols, maintenance_info_psymtabs)
 474         (maintenance_check_psymtabs): Update.
 475         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 476         bool.
 477
 478 2019-11-22  Tom Tromey  <tom@tromey.com>
 479
 480         * observable.h: Update comments.
 481
 482 2019-11-22  Tom Tromey  <tromey@adacore.com>
 483
 484         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 485         (print_ada_task_info): Don't try to fetch thread id if task is not
 486         alive.
 487
 488 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 489
 490         * ada-exp.y: Update.
 491         * ada-lang.c (sort_choices): Update.
 492         (ada_print_symbol_signature): Update.
 493         (resolve_subexp): Update.
 494         (ada_parse_renaming): Update.
 495         (ada_read_renaming_var_value): Update.
 496         (lesseq_defined_than): Update.
 497         (remove_extra_symbols): Update.
 498         (remove_irrelevant_renamings): Update.
 499         (ada_add_block_symbols): Update.
 500         (ada_collect_symbol_completion_matches): Update.
 501         (ada_is_renaming_symbol): Update.
 502         (aggregate_assign_from_choices): Update.
 503         (ada_evaluate_subexp): Update.
 504         (ada_has_this_exception_support): Update.
 505         (ada_is_non_standard_exception_sym): Update.
 506         (ada_add_exceptions_from_frame): Update.
 507         (ada_add_global_exceptions): Update.
 508         (ada_print_subexp): Update.
 509         * ax-gdb.c (gen_var_ref): Update.
 510         (gen_maybe_namespace_elt): Update.
 511         (gen_expr_for_cast): Update.
 512         (gen_expr): Update.
 513         * block.h: Update.
 514         * blockframe.c (find_pc_partial_function): Update.
 515         * breakpoint.c (print_breakpoint_location): Update.
 516         (update_static_tracepoint): Update.
 517         * btrace.c (ftrace_print_function_name): Update.
 518         (ftrace_function_switched): Update.
 519         * buildsym.c (find_symbol_in_list): Update.
 520         * c-exp.y: Update.
 521         * c-typeprint.c (c_print_typedef): Update.
 522         (c_type_print_template_args): Update.
 523         * cli/cli-cmds.c (edit_command): Update.
 524         (list_command): Update.
 525         (print_sal_location): Update.
 526         * coffread.c (patch_opaque_types): Update.
 527         (process_coff_symbol): Update.
 528         (coff_read_enum_type): Update.
 529         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 530         (convert_one_symbol): Update.
 531         (hash_symname): Update.
 532         (eq_symname): Update.
 533         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 534         * compile/compile-cplus-types.c (debug_print_scope): Update.
 535         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 536         * compile/compile-object-load.c (get_out_value_type): Update.
 537         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 538         (search_symbol_list): Update.
 539         (cp_lookup_symbol_imports_or_template): Update.
 540         * cp-support.c (overload_list_add_symbol): Update.
 541         * ctfread.c (psymtab_to_symtab): Update.
 542         * dbxread.c (cp_set_block_scope): Update.
 543         * dictionary.c (iter_match_first_hashed): Update.
 544         (iter_match_next_hashed): Update.
 545         (insert_symbol_hashed): Update.
 546         (iter_match_next_linear): Update.
 547         * dictionary.h: Update.
 548         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 549         (locexpr_describe_location_piece): Update.
 550         (locexpr_describe_location_1): Update.
 551         (locexpr_generate_c_location): Update.
 552         (loclist_describe_location): Update.
 553         (loclist_generate_c_location): Update.
 554         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 555         (read_func_scope): Update.
 556         (process_enumeration_scope): Update.
 557         (new_symbol): Update.
 558         (dwarf2_const_value): Update.
 559         (dwarf2_symbol_mark_computed): Update.
 560         * eval.c (evaluate_funcall): Update.
 561         (evaluate_subexp_standard): Update.
 562         * expprint.c (print_subexp_standard): Update.
 563         (dump_subexp_body_standard): Update.
 564         * f-valprint.c (info_common_command_for_block): Update.
 565         * findvar.c (get_hosting_frame): Update.
 566         (default_read_var_value): Update.
 567         * go-lang.c (go_symbol_package_name): Update.
 568         * guile/scm-block.c (bkscm_print_block_smob): Update.
 569         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 570         (gdbscm_symbol_name): Update.
 571         (gdbscm_symbol_linkage_name): Update.
 572         (gdbscm_symbol_print_name): Update.
 573         * infcall.c (get_function_name): Update.
 574         * infcmd.c (jump_command): Update.
 575         (finish_command): Update.
 576         * infrun.c (insert_exception_resume_breakpoint): Update.
 577         * linespec.c (canonicalize_linespec): Update.
 578         (create_sals_line_offset): Update.
 579         (convert_linespec_to_sals): Update.
 580         (complete_label): Update.
 581         (find_label_symbols_in_block): Update.
 582         * m2-typeprint.c (m2_print_typedef): Update.
 583         * mdebugread.c (mdebug_reg_to_regnum): Update.
 584         (parse_symbol): Update.
 585         (mylookup_symbol): Update.
 586         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 587         (list_args_or_locals): Update.
 588         * objc-lang.c (compare_selectors): Update.
 589         (info_selectors_command): Update.
 590         (compare_classes): Update.
 591         (info_classes_command): Update.
 592         (find_imps): Update.
 593         * p-typeprint.c (pascal_print_typedef): Update.
 594         * printcmd.c (build_address_symbolic): Update.
 595         (info_address_command): Update.
 596         (print_variable_and_value): Update.
 597         * python/py-framefilter.c (extract_sym): Update.
 598         (py_print_single_arg): Update.
 599         * python/py-symbol.c (sympy_str): Update.
 600         (sympy_get_name): Update.
 601         (sympy_get_linkage_name): Update.
 602         * python/python.c (gdbpy_rbreak): Update.
 603         * record-btrace.c (btrace_get_bfun_name): Update.
 604         (btrace_call_history): Update.
 605         * rust-lang.c (rust_print_typedef): Update.
 606         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 607         * stabsread.c (stab_reg_to_regnum): Update.
 608         (define_symbol): Update.
 609         (read_enum_type): Update.
 610         (common_block_end): Update.
 611         (cleanup_undefined_types_1): Update.
 612         (scan_file_globals): Update.
 613         * stack.c (print_frame_arg): Update.
 614         (print_frame_args): Update.
 615         (find_frame_funname): Update.
 616         (info_frame_command_core): Update.
 617         (iterate_over_block_locals): Update.
 618         (print_block_frame_labels): Update.
 619         (do_print_variable_and_value): Update.
 620         (iterate_over_block_arg_vars): Update.
 621         (return_command): Update.
 622         * symmisc.c (dump_symtab_1): Update.
 623         (print_symbol): Update.
 624         * symtab.c (eq_symbol_entry): Update.
 625         (symbol_cache_dump): Update.
 626         (lookup_language_this): Update.
 627         (find_pc_sect_line): Update.
 628         (skip_prologue_sal): Update.
 629         (symbol_search::compare_search_syms): Update.
 630         (treg_matches_sym_type_name): Update.
 631         (search_symbols): Update.
 632         (print_symbol_info): Update.
 633         (rbreak_command): Update.
 634         (completion_list_add_symbol): Update.
 635         (find_gnu_ifunc): Update.
 636         (get_symbol_address): Update.
 637         (search_module_symbols): Update.
 638         (info_module_subcommand): Update.
 639         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 640         (SYMBOL_LINKAGE_NAME): Remove.
 641         (SYMBOL_DEMANGLED_NAME): Remove.
 642         (SYMBOL_PRINT_NAME): Remove.
 643         (SYMBOL_SEARCH_NAME): Remove.
 644         * tracepoint.c (set_traceframe_context): Update.
 645         (validate_actionline): Update.
 646         (collection_list::collect_symbol): Update.
 647         (encode_actions_1): Update.
 648         (info_scope_command): Update.
 649         (print_one_static_tracepoint_marker): Update.
 650         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 651         * valops.c (address_of_variable): Update.
 652         (find_overload_match): Update.
 653         (find_oload_champ): Update.
 654
 655 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 656
 657         * ada-lang.c (ada_lookup_simple_minsym): Update.
 658         (ada_collect_symbol_completion_matches): Update.
 659         * ada-tasks.c (read_atcb): Update.
 660         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 661         (amd64_windows_skip_trampoline_code): Update.
 662         * arm-tdep.c (skip_prologue_function): Update.
 663         (arm_skip_stack_protector): Update.
 664         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 665         (arm_wince_skip_main_prologue): Update.
 666         * ax-gdb.c (gen_expr): Update.
 667         * block.c (call_site_for_pc): Update.
 668         * blockframe.c (find_pc_partial_function): Update.
 669         * breakpoint.c (set_breakpoint_location_function): Update.
 670         * btrace.c (ftrace_print_function_name): Update.
 671         (ftrace_function_switched): Update.
 672         * c-valprint.c (print_unpacked_pointer): Update.
 673         * coffread.c (coff_symfile_read): Update.
 674         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 675         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 676         * dwarf-index-write.c (write_psymbols): Update.
 677         * dwarf2loc.c (call_site_to_target_addr): Update.
 678         (func_verify_no_selftailcall): Update.
 679         (tailcall_dump): Update.
 680         (call_site_find_chain_1): Update.
 681         (dwarf_expr_reg_to_entry_parameter): Update.
 682         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 683         * eval.c (evaluate_funcall): Update.
 684         (evaluate_subexp_standard): Update.
 685         (evaluate_subexp_for_sizeof): Update.
 686         * expprint.c (print_subexp_standard): Update.
 687         (dump_subexp_body_standard): Update.
 688         * frame.c (get_prev_frame_always_1): Update.
 689         * frv-tdep.c (frv_skip_main_prologue): Update.
 690         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 691         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 692         (gnuv3_get_typename_from_type_info): Update.
 693         (gnuv3_skip_trampoline): Update.
 694         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 695         * i386-tdep.c (i386_skip_main_prologue): Update.
 696         (i386_pe_skip_trampoline_code): Update.
 697         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 698         * infcall.c (get_function_name): Update.
 699         * linespec.c (minsym_found): Update.
 700         * linux-fork.c (info_checkpoints_command): Update.
 701         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 702         (m32c_m16c_pointer_to_address): Update.
 703         * maint.c (maintenance_translate_address): Update.
 704         * minsyms.c (add_minsym_to_hash_table): Update.
 705         (add_minsym_to_demangled_hash_table): Update.
 706         (lookup_minimal_symbol_mangled): Update.
 707         (lookup_minimal_symbol_demangled): Update.
 708         (lookup_minimal_symbol_linkage): Update.
 709         (lookup_minimal_symbol_text): Update.
 710         (lookup_minimal_symbol_by_pc_name): Update.
 711         (minimal_symbol_is_less_than): Update.
 712         (compact_minimal_symbols): Update.
 713         (build_minimal_symbol_hash_tables): Update.
 714         (find_solib_trampoline_target): Update.
 715         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 716         (mips_skip_pic_trampoline_code): Update.
 717         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 718         * objc-lang.c (info_selectors_command): Update.
 719         (info_classes_command): Update.
 720         (find_methods): Update.
 721         (find_imps): Update.
 722         * p-valprint.c (pascal_val_print): Update.
 723         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 724         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 725         * printcmd.c (build_address_symbolic): Update.
 726         (info_symbol_command): Update.
 727         * psymtab.c (psymbol_name_matches): Update.
 728         (match_partial_symbol): Update.
 729         (lookup_partial_symbol): Update.
 730         (print_partial_symbols): Update.
 731         (sort_pst_symbols): Update.
 732         (maintenance_check_psymtabs): Update.
 733         * python/py-framefilter.c (py_print_frame): Update.
 734         * python/python.c (gdbpy_rbreak): Update.
 735         * record-btrace.c (btrace_get_bfun_name): Update.
 736         (btrace_call_history): Update.
 737         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 738         (rs6000_skip_trampoline_code): Update.
 739         * sol-thread.c (info_cb): Update.
 740         * stabsread.c (scan_file_globals): Update.
 741         * stack.c (find_frame_funname): Update.
 742         (info_frame_command_core): Update.
 743         * symmisc.c (dump_msymbols): Update.
 744         * symtab.c (symbol_natural_name): Rename to..,
 745         (general_symbol_info::natural_name): ...this.
 746         (symbol_demangled_name): Rename to...
 747         (general_symbol_info::demangled_name): ...this.
 748         (symbol_search_name): Rename to...
 749         (general_symbol_info::search_name): ...this.
 750         (symbol_matches_search_name): Update.
 751         (find_pc_sect_line): Update.
 752         (skip_prologue_sal): Update.
 753         (search_symbols): Update.
 754         (print_msymbol_info): Update.
 755         (rbreak_command): Update.
 756         (completion_list_add_msymbol): Update.
 757         (completion_list_objc_symbol): Update.
 758         (get_msymbol_address): Update.
 759         * symtab.h (struct general_symbol_info): Add member functions
 760         natural_name (), linkage_name (), print_name (), demangled_name (),
 761         and search_name ().
 762         (SYMBOL_NATURAL_NAME): Update.
 763         (symbol_natural_name): Move to a member function on general_symbol_info.
 764         (SYMBOL_DEMANGLED_NAME): Update.
 765         (symbol_demangled_name): Move to a member function on
 766         general_symbol_info.
 767         (SYMBOL_SEARCH_NAME): Update.
 768         (symbol_search_name): Move to a member function on general_symbol_info.
 769         (MSYMBOL_NATURAL_NAME): Remove.
 770         (MSYMBOL_LINKAGE_NAME): Remove.
 771         (MSYMBOL_PRINT_NAME): Remove.
 772         (MSYMBOL_DEMANGLED_NAME): Remove.
 773         (MSYMBOL_SEARCH_NAME): Remove.
 774         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 775
 776 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 777
 778         * symtab.c (create_demangled_names_hash): Use per_bfd->
 779         minimal_symbol_count for computing the initial size, if greater
 780         than our default size.
 781
 782 2019-11-22  Tom de Vries  <tdevries@suse.de>
 783
 784         * contrib/words.sh: Improve words extraction.
 785
 786 2019-11-22  Tom de Vries  <tdevries@suse.de>
 787
 788         * contrib/words.sh: Combine sed invocations.
 789
 790 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 791
 792         * Makefile.in: Update.
 793         * demangle.c: Rename to...
 794         * gdb-demangle.c: ..this.
 795         (is_cplus_marker): Change return type to bool.
 796         (_initialize_demangler): Rename to...
 797         (_initialize_gdb_demangle): ...this.
 798         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 799         * symtab.h (demangle): Remove declaration; instead include
 800         gdb-demangle.h.
 801
 802 2019-11-21  Tom Tromey  <tromey@adacore.com>
 803
 804         * gdbsupport/format.c (format_pieces): Parse %I64d.
 805         * unittests/format_pieces-selftests.c (test_windows_formats): New
 806         function.
 807         (run_tests): Call it.
 808
 809 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 810
 811         Byte reverse display of variables with DW_END_big, DW_END_little
 812         (DW_AT_endianity) dwarf attributes if different than the native
 813         byte order.
 814         * ada-lang.c (ada_value_binop):
 815         Use type_byte_order instead of gdbarch_byte_order.
 816         * ada-valprint.c (printstr):
 817         (ada_val_print_string):
 818         * ada-lang.c (value_pointer):
 819         (ada_value_binop):
 820         Use type_byte_order instead of gdbarch_byte_order.
 821         * c-lang.c (c_get_string):
 822         Use type_byte_order instead of gdbarch_byte_order.
 823         * c-valprint.c (c_val_print_array):
 824         Use type_byte_order instead of gdbarch_byte_order.
 825         * cp-valprint.c (cp_print_class_member):
 826         Use type_byte_order instead of gdbarch_byte_order.
 827         * dwarf2loc.c (rw_pieced_value):
 828         Use type_byte_order instead of gdbarch_byte_order.
 829         * dwarf2read.c (read_base_type): Handle DW_END_big,
 830         DW_END_little
 831         * f-lang.c (f_get_encoding):
 832         Use type_byte_order instead of gdbarch_byte_order.
 833         * findvar.c (default_read_var_value):
 834         Use type_byte_order instead of gdbarch_byte_order.
 835         * gdbtypes.c (check_types_equal):
 836         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 837         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 838         and TYPE_ENDIANITY_LITTLE if set.
 839         (type_byte_order): new function.
 840         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 841         (struct main_type) <flag_endianity_not_default>:
 842         New field.
 843         (type_byte_order): New function.
 844         * infcmd.c (default_print_one_register_info):
 845         Use type_byte_order instead of gdbarch_byte_order.
 846         * p-lang.c (pascal_printstr):
 847         Use type_byte_order instead of gdbarch_byte_order.
 848         * p-valprint.c (pascal_val_print):
 849         Use type_byte_order instead of gdbarch_byte_order.
 850         * printcmd.c (print_scalar_formatted):
 851         Use type_byte_order instead of gdbarch_byte_order.
 852         * solib-darwin.c (darwin_current_sos):
 853         Use type_byte_order instead of gdbarch_byte_order.
 854         * solib-svr4.c (solib_svr4_r_ldsomap):
 855         Use type_byte_order instead of gdbarch_byte_order.
 856         * stap-probe.c (stap_modify_semaphore):
 857         Use type_byte_order instead of gdbarch_byte_order.
 858         * target-float.c (target_float_same_format_p):
 859         Use type_byte_order instead of gdbarch_byte_order.
 860         * valarith.c (scalar_binop):
 861         (value_bit_index):
 862         Use type_byte_order instead of gdbarch_byte_order.
 863         * valops.c (value_cast):
 864         Use type_byte_order instead of gdbarch_byte_order.
 865         * valprint.c (generic_emit_char):
 866         (generic_printstr):
 867         (val_print_string):
 868         Use type_byte_order instead of gdbarch_byte_order.
 869         * value.c (unpack_long):
 870         (unpack_bits_as_long):
 871         (unpack_value_bitfield):
 872         (modify_field):
 873         (pack_long):
 874         (pack_unsigned_long):
 875         Use type_byte_order instead of gdbarch_byte_order.
 876         * findvar.c (unsigned_pointer_to_address):
 877         (signed_pointer_to_address):
 878         (unsigned_address_to_pointer):
 879         (address_to_signed_pointer):
 880         (default_read_var_value):
 881         (default_value_from_register):
 882         Use type_byte_order instead of gdbarch_byte_order.
 883         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 884         Use type_byte_order instead of gdbarch_byte_order.
 885         * riscv-tdep.c (riscv_print_one_register_info):
 886         Use type_byte_order instead of gdbarch_byte_order.
 887
 888 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 889
 890         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 891         (current_ui_gdb_stdin_ptr): Likewise.
 892         (current_ui_gdb_stderr_ptr): Likewise.
 893         (current_ui_gdb_stdlog_ptr): Likewise.
 894         (current_ui_current_uiout_ptr): Likewise.
 895         (gen_ret_current_ui_field_ptr): Remove.
 896
 897 2019-11-21  Tom de Vries  <tdevries@suse.de>
 898
 899         PR gdb/24956
 900         * cli/cli-script.c (execute_control_command): Only switch to
 901         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 902
 903 2019-11-19  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 906         Now static.  Change type of "name".
 907         (tui_set_win_height_command): Don't copy "arg".
 908         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 909         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 910
 911 2019-11-19  Ali Tamur <tamur@google.com>
 912
 913         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 914         "if (attr != nullptr)".
 915         (dwarf2_find_base_address): Likewise.
 916         (dwarf2_build_include_psymtabs): Likewise.
 917         (read_cutu_die_from_dwo): Likewise.
 918         (read_func_scope): Likewise.
 919         (read_call_site_scope): Likewise.
 920         (dwarf2_get_pc_bounds): Likewise.
 921         (dwarf2_record_block_ranges): Likewise.
 922         (dwarf2_add_field): Likewise.
 923         (dwarf2_add_member_fn): Likewise.
 924         (read_structure_type): Likewise.
 925         (read_enumeration_type): Likewise.
 926         (read_array_type): Likewise.
 927         (read_array_order): Likewise.
 928         (read_set_type): Likewise.
 929         (read_common_block): Likewise.
 930         (read_tag_reference_type): Likewise.
 931         (read_tag_string_type): Likewise.
 932         (read_subroutine_type): Likewise.
 933         (read_base_type): Likewise.
 934         (read_subrange_type): Likewise.
 935         (new_symbol): Likewise.
 936         (prepare_one_comp_unit): Likewise.
 937
 938 2019-11-19  Tom Tromey  <tromey@adacore.com>
 939
 940         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 941         result in error when DebugActiveProcess fails.
 942
 943 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 944             Pedro Alves  <palves@redhat.com>
 945
 946         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 947         * target.c (target_stack::push): Call 'unpush' if there's a
 948         target on top of the stack.
 949
 950 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 951
 952         * python/py-block.c (blpy_dealloc): Call tp_free.
 953         (blpy_block_syms_dealloc): Likewise.
 954         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
 955         * python/py-inferior.c (infpy_dealloc): Likewise.
 956         * python/py-lazy-string.c (stpy_dealloc): Likewise.
 957         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
 958         * python/py-symbol.c (sympy_dealloc): Likewise.
 959         * python/py-symtab.c (stpy_dealloc): Likewise.
 960         * python/py-type.c (typy_iterator_dealloc): Likewise.
 961
 962 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
 963
 964         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
 965         constructor instead of using a class initializer.
 966
 967 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 968
 969         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
 970         * configure: Regenerate.
 971         * configure.ac: Don't source common.host.
 972         * gdbsupport/common.host: Remove.
 973         * gdbsupport/mingw-strerror.c: Remove.
 974         * gdbsupport/posix-strerror.c: Rename to...
 975         * gdbsupport/safe-strerror.c: ...this.
 976
 977 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 978
 979         * maint.c (scoped_command_stats::print_time): Use localtime_r
 980         instead of localtime (provided through gnulib if necessary).
 981         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
 982         of ctime.
 983
 984 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 985
 986         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
 987         avoid compile errors.
 988
 989 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 990
 991         * config.in: Regenerate.
 992         * configure: Regenerate.
 993         * gdbsupport/common.m4: No longer check for strerror_r.
 994         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
 995         POSIX version of strerror_r, now that gnulib provides it if
 996         necessary.
 997
 998 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
 999
1000         * README (`configure' options): Update.
1001
1002 2019-11-14  Tom Tromey  <tromey@adacore.com>
1003
1004         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1005         expected type for the RHS if the LHS is a convenience variable.
1006
1007 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1008
1009         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1010         Provide explicit default and copy constructor.
1011
1012 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1013
1014         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1015         only call Py_INCREF (newbp) in the bppy_pending_object case.
1016
1017 2019-11-13  Tom Tromey  <tromey@adacore.com>
1018
1019         PR build/25182:
1020         * psympriv.h (partial_symbol): Remove static assert.
1021         * symtab.h (general_symbol_info, symbol): Remove static assert.
1022
1023 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * gdbsupport/format.c (format_pieces::format_pieces): Support
1026         printf 'z' size modifier.
1027         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1028         * printcmd.c (ui_printf):  Handle size_t_arg.
1029         * ui-out.c (ui_out::vmessage): Likewise.
1030         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1031         function.
1032         (run_tests): Call test_format_int_sizes.
1033
1034 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * ada-exp.y (write_ambiguous_var): Update.
1037         * buildsym.c (add_symbol_to_list): Update.
1038         * dwarf2read.c (read_variable): Update.
1039         (new_symbol): Update.
1040         * jit.c (finalize_symtab): Update.
1041         * language.c (language_alloc_type_symbol): Update.
1042         * symtab.c (fixup_symbol_section): Update.
1043         (initialize_objfile_symbol_1): Move code to...
1044         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1045         (allocate_symbol): Update.
1046         (allocate_template_symbol): Update.
1047         (get_symbol_address): Update.
1048         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1049         of having as a field, and add a constructor.
1050         (SYMBOL_VALUE): Update.
1051         (SYMBOL_VALUE_ADDRESS): Update.
1052         (SET_SYMBOL_VALUE_ADDRESS): Update.
1053         (SYMBOL_VALUE_BYTES): Update.
1054         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1055         (SYMBOL_BLOCK_VALUE): Update.
1056         (SYMBOL_VALUE_CHAIN): Update.
1057         (SYMBOL_LANGUAGE): Update.
1058         (SYMBOL_SECTION): Update.
1059         (SYMBOL_OBJ_SECTION): Update.
1060         (SYMBOL_SET_LANGUAGE): Update.
1061         (SYMBOL_SET_LINKAGE_NAME): Update.
1062         (SYMBOL_SET_NAMES): Update.
1063         (SYMBOL_NATURAL_NAME): Update.
1064         (SYMBOL_LINKAGE_NAME): Update.
1065         (SYMBOL_DEMANGLED_NAME): Update.
1066         (SYMBOL_SEARCH_NAME): Update.
1067         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1068         (struct symbol): Update.
1069         (struct template_symbol): Update.
1070         (struct rust_vtable_symbol): Update.
1071         * xcoffread.c (SYMBOL_DUP): Update.
1072
1073 2019-11-12  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-layout.c (show_layout): Set current_layout.
1076         (show_source_disasm_command, show_data)
1077         (show_source_or_disasm_and_command): Don't set current_layout.
1078
1079 2019-11-12  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1082
1083 2019-11-12  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-win.c (resize_message): New global.
1086         (show_tui_resize_message): New function.
1087         (tui_async_resize_screen): Print message if requested.
1088         (_initialize_tui_win): Add tui-resize-message setting.
1089         * NEWS: Add entry for new commands.
1090
1091 2019-11-11  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1094         functions.
1095
1096 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1097
1098         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1099
1100 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1101
1102         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1103         function.
1104         * python/python-internal.h (gdbpy_lookup_static_symbols):
1105         Declare new function.
1106         * python/python.c (python_GdbMethods): Add
1107         gdb.lookup_static_symbols method.
1108         * NEWS: Mention gdb.lookup_static_symbols.
1109
1110 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1113         static block of current object file first.  Also fix typo in
1114         header comment.
1115
1116 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * stack.c (set_last_displayed_sal): Delete.
1119         (last_displayed_sal_valid): Delete.
1120         (last_displayed_pspace): Delete.
1121         (last_displayed_addr): Delete.
1122         (last_displayed_symtab): Delete.
1123         (last_displayed_line): Delete.
1124         (class last_displayed_symtab_info_type): New.
1125         (last_displayed_symtab_info): New static global variable.
1126         (print_frame_info): Call methods on last_displayed_symtab_info.
1127         (clear_last_displayed_sal): Update header comment, and make use of
1128         last_displayed_symtab_info.
1129         (last_displayed_sal_is_valid): Likewise.
1130         (get_last_displayed_pspace): Likewise.
1131         (get_last_displayed_addr): Likewise.
1132         (get_last_displayed_symtab): Likewise.
1133         (get_last_displayed_line): Likewise.
1134         (get_last_displayed_sal): Likewise.
1135         * stack.h (clear_last_displayed_sal): Update header comment.
1136         (last_displayed_sal_is_valid): Likewise.
1137         (get_last_displayed_pspace): Likewise.
1138         (get_last_displayed_addr): Likewise.
1139         (get_last_displayed_symtab): Likewise.
1140         (get_last_displayed_line): Likewise.
1141         (get_last_displayed_sal): Likewise.
1142
1143 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * stack.c (frame_show_address): Convert return type to bool.
1146         * stack.h (frame_show_address): Likewise, and update header
1147         comment.
1148
1149 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1152         * unittests/vec-utils-selftests.c: New file.
1153         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1154
1155 2019-11-10  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1158         (tui_highlight_win): Likewise.
1159         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1160         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1161         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1162         Don't set can_highlight.
1163
1164 2019-11-10  Tom Tromey  <tom@tromey.com>
1165
1166         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1167         Remove unused declaration.
1168
1169 2019-11-08  Tom Tromey  <tromey@adacore.com>
1170
1171         * top.c (read_command_file): Update.
1172         (command_line_input): Make return type const.
1173         * python/py-gdb-readline.c: Update.
1174         * linespec.c (decode_line_2): Update.
1175         * defs.h (command_line_input): Make return type const.
1176         * cli/cli-script.c (read_next_line): Make return type const.
1177         * ada-lang.c (get_selections): Update.
1178
1179 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1182         * mi/mi-main.c (output_cores): Likewise.
1183         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1184         (linux_xfer_osdata_modules): Likewise.
1185         * remote.c (register_remote_support_xml): Likewise.
1186         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1187         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1188
1189 2019-11-06  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-interp.c: Don't include readline.h.
1192         * tui/tui-hooks.c: Don't include readline.h.
1193         * symmisc.c: Include tilde.h, not readline.h.
1194         * symfile.c: Include tilde.h, not readline.h.
1195         * source.c: Include tilde.h, not readline.h.
1196         * solib.c: Include tilde.h, not readline.h.
1197         * psymtab.c: Include tilde.h, not readline.h.
1198         * exec.c: Include tilde.h, not readline.h.
1199         * corelow.c: Include tilde.h, not readline.h.
1200         * cli/cli-dump.c: Include tilde.h, not readline.h.
1201         * cli/cli-cmds.c: Don't include readline.h.
1202
1203 2019-11-05  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1206         (tui_disassemble): Set addr_size.
1207         (tui_disasm_window::set_contents): Use addr_size.
1208
1209 2019-11-05  Tom Tromey  <tom@tromey.com>
1210
1211         * rust-lang.c (rust_language_defn): Update.
1212         * python/py-value.c (valpy_string): Call c_get_string.
1213         * p-lang.c (pascal_language_defn): Update.
1214         * opencl-lang.c (opencl_language_defn): Update.
1215         * objc-lang.c (objc_language_defn): Update.
1216         * m2-lang.c (m2_language_defn): Update.
1217         * language.c (unknown_language_defn, auto_language_defn): Update.
1218         (default_get_string): Remove.
1219         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1220         * go-lang.c (go_language_defn): Update.
1221         * f-lang.c (f_language_defn): Update.
1222         * d-lang.c (d_language_defn): Update.
1223         * c-lang.c (c_language_defn, cplus_language_defn)
1224         (asm_language_defn, minimal_language_defn): Update.
1225         * ada-lang.c (ada_language_defn): Update.
1226         * language.h (struct language_defn) <la_get_string>: Remove.
1227         (LA_GET_STRING): Remove.
1228         (default_get_string): Don't declare.
1229
1230 2019-11-05  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-source.h (struct tui_source_window): Inline
1233         constructor.  Remove destructor.
1234         <style_changed, m_observable>: Move to superclass.
1235         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1236         (struct tui_source_window_base): Move private members to end.
1237         <style_changed, m_observable>: Move from tui_source_window.
1238         * tui/tui-winsource.c (tui_copy_source_line): Move from
1239         tui-source.c.  Rename from copy_source_line.  Add special handling
1240         for negative line number.
1241         (tui_source_window_base::style_changed): Move from
1242         tui_source_window.
1243         (tui_source_window_base): Register observer.
1244         (~tui_source_window_base): New.
1245         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1246         rename.
1247         (tui_source_window::set_contents): Use tui_copy_source_line.
1248         (tui_source_window::tui_source_window): Move to tui-source.h.
1249         (tui_source_window::~tui_source_window): Remove.
1250         (tui_source_window::style_changed): Move to superclass.
1251         * tui/tui-disasm.c (tui_disassemble): Create string file with
1252         styling, when possible.  Add "addr_size" parameter.
1253         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1254         Don't compute maximum size.
1255         (len_without_escapes): New function
1256
1257 2019-11-05  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1260         std::string.
1261         * tui/tui-winsource.c (tui_show_source_line): Update.
1262         * tui/tui-source.c (tui_source_window::set_contents): Update.
1263         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1264
1265 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * symtab.h (gdb_static_assert): Put && operator at the beginning
1268         of the line instead of the end.
1269
1270 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1273         and sizeof (symbol).
1274         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1275
1276 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1277
1278         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1279         * configure.host: Mark *-*-solaris2.10* obsolete.
1280         * configure.tgt: Mark Solaris < 11 obsolete.
1281         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1282         Update target triplet.
1283
1284 2019-11-01  Tom Tromey  <tromey@adacore.com>
1285
1286         * utils.c (print_sys_errmsg): Simplify.
1287
1288 2019-11-01  Tom Tromey  <tromey@adacore.com>
1289
1290         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1291
1292 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1293
1294         * configure: Regenerate.
1295         * configure.ac: Remove check for strerror_r.
1296         * gdbsupport/common.m4: Check for strerror_r.
1297
1298 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1299
1300         PR gdb/25124
1301
1302         * arm-tdep.c (arm_per_objfile): Rename to ...
1303         (arm_per_bfd): ... this.
1304         (arm_objfile_data_key): Rename to ...
1305         (arm_bfd_data_key): ... this.
1306         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1307         data.
1308         (arm_record_special_symbol): Likewise.
1309
1310 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1313         end.
1314         * c-typeprint.c (c_print_typedef): Likewise.
1315         * f-typeprint.c (f_print_typedef): Likewise.
1316         * m2-typeprint.c (m2_print_typedef): Likewise.
1317         * p-typeprint.c (pascal_print_typedef): Likewise.
1318         * rust-lang.c (rust_print_typedef): Likewise.
1319         * symtab.c (print_symbol_info): Print a newline after calling
1320         typedef_print.
1321
1322 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * symtab.c (info_module_cmdlist): New variable.
1325         (info_module_command): New function.
1326         (search_module_symbols): New function.
1327         (info_module_subcommand): New function.
1328         (struct info_modules_var_func_options): New struct.
1329         (info_modules_var_func_options_defs): New variable.
1330         (make_info_modules_var_func_options_def_group): New function.
1331         (info_module_functions_command): New function.
1332         (info_module_variables_command): New function.
1333         (info_module_var_func_command_completer): New function.
1334         (_initialize_symtab): Register new 'info module functions' and
1335         'info module variables' commands.
1336         * symtab.h (typedef symbol_search_in_module): New typedef.
1337         (search_module_symbols): Declare new function.
1338         * NEWS: Mention new commands.
1339
1340 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1343         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1344         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1345         MODULES_DOMAIN.
1346         (scan_partial_symbols): Only create partial module symbols for non
1347         declarations.
1348         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1349         and MODULES_DOMAIN.
1350         * symtab.c (search_domain_name): Likewise.
1351         (search_symbols): Likewise.
1352         (print_symbol_info): Likewise.
1353         (symtab_symbol_info): Likewise.
1354         (info_modules_command): New function.
1355         (_initialize_symtab): Register 'info modules' command.
1356         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1357         * NEWS: Mention new 'info modules' command.
1358
1359 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1360
1361         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1362         and $_gdb_maint_setting_str.
1363
1364 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1365
1366         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1367         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1368         (str_value_from_setting, gdb_setting_str_internal_fn)
1369         (gdb_maint_setting_str_internal_fn): New functions.
1370         (_initialize_cli_cmds): Define the new convenience functions.
1371         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1372         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1373
1374 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1375
1376         * agent.c (set_can_use_agent): When the setting is turned on,
1377         look up agent symbols if we don't have them yet.
1378         (agent_new_objfile): Don't look up agent symbols when the agent
1379         setting is off.
1380
1381 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1382
1383         * config.in: Regenerate.
1384
1385 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1386
1387         * configure: Regenerate.
1388         * configure.ac: Check for strerror_r.
1389         * gdbsupport/common-utils.h (safe_strerror): Change return value
1390         to const char * and document that this function is now threadsafe.
1391         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1392         thread_local and call strerror_r, if available.
1393         * utils.c (perror_string): Update.
1394         (print_sys_errmsg): Update.
1395
1396 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1397
1398         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1399         objfile_key.
1400         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1401         objfile to fetch per-bfd data.
1402         (arm_find_exidx_entry): Likewise.
1403
1404 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1405
1406         * gdbsupport/agent.c (debug_agent): Change type to bool.
1407         (use_agent): Likewise.
1408         (all_agent_symbols_look_up): Likewise.
1409         (agent_loaded_p): Change return value to bool.
1410         (agent_look_up_symbols): Update.
1411         (agent_capability_check): Change return value to bool.
1412         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1413         (debug_agent): Change type to bool.
1414         (use_agent): Likewise.
1415         (agent_capability_check): Change return value to bool.
1416
1417 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1418
1419         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1420         (build_minimal_symbol_hash_tables): Code to clear the table moved
1421         to clear_minimal_symbol_hash_tables.
1422         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1423         when needed.
1424
1425 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1426
1427         * infcmd.c: Remove includes.
1428         * infrun.c: Remove includes.
1429
1430 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1431
1432         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1433         (grow_vect): Remove declaration.
1434         (ada_type_of_array): Remove declaration.
1435         (ada_update_initial_language): Remove declaration.
1436         (ada_fold_name): Remove declaration.
1437         (ada_fill_in_ada_prototype): Remove declaration.
1438         (user_select_syms): Remove declaration.
1439         (get_selections): Remove declaration.
1440         (ada_tag_type): Remove declaration.
1441         (ada_value_tag): Remove declaration.
1442         (ada_is_others_clause): Remove declaration.
1443         (ada_in_variant): Remove declaration.
1444         (ada_value_struct_elt): Remove declaration.
1445         (ada_attribute_name): Remove declaration.
1446         (ada_system_address_type): Remove declaration.
1447         * ada-lang.c (ada_watch_location_expression): Make static.
1448         (GROW_VECT): Move here from ada-lang.h.
1449         (grow_vect): Make static.
1450         (ada_update_initial_language): Make static.
1451         (ada_fold_name): Make static.
1452         (ada_type_of_array): Make static.
1453         (encoded_ordered_before): Move up.
1454         (sort_choices): Move up.
1455         (print_signatures): Move up.
1456         (ada_print_symbol_signature): Move up.
1457         (get_selections): Move up and make static.
1458         (user_select_syms): Move up and make static.
1459         (ada_value_struct_elt): Move up and make static.
1460         (ada_tag_type): Make static.
1461         (ada_value_tag): Make static.
1462         (ada_is_others_clause): Make static.
1463         (ada_in_variant): Make static.
1464         (ada_attribute_name): Make static.
1465
1466 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1467
1468         * ada-lang.c: Remove includes.
1469         * ada-typeprint.c: Remove includes.
1470         * ada-valprint.c: Remove includes.
1471
1472 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1473
1474         * addrmap.c: Add static assertions of type size, moved from
1475         _initialize_addrmap.
1476         (_initialize_addrmap): Remove.
1477
1478 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1479
1480         * coffread.c (record_minimal_symbol): Update.
1481         (process_coff_symbol): Update.
1482         * dbxread.c (read_dbx_symtab): Update.
1483         * dwarf2read.c (add_partial_symbol): Update.
1484         (fixup_go_packaging): Update.
1485         (load_partial_dies): Update.
1486         (new_symbol): Update.
1487         * elfread.c (record_minimal_symbol): Change signature to use
1488         gdb::string_view instead of name+len.
1489         (elf_symtab_read): Update.
1490         (elf_rel_plt_read): Update.
1491         * mdebugread.c (parse_partial_symbols): Update.
1492         (handle_psymbol_enumerators): Update.
1493         (new_symbol): Update.
1494         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1495         to use gdb::string_view instead of name+len.
1496         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1497         * psympriv.h (add_psymbol_to_list): Likewise.
1498         * psymtab.c (add_psymbol_to_bcache): Likewise.
1499         (add_psymbol_to_list): Likewise.
1500         * stabsread.c (define_symbol): Update.
1501         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1502         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1503         (symbol_set_names): Likewise.
1504         * xcoffread.c (scan_xcoff_symtab): Update.
1505
1506 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1507
1508         * symtab.h (symbol_set_names): Document that copy_name must be
1509         set to true for non-nullterminated strings.
1510         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1511         linkage_name if the entry was not found and we need to demangle.
1512
1513 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1514
1515         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1516         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1517         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1518         * gdbsupport/gdb_binary_search.h: New file.
1519
1520 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1521
1522         * NEWS: Mention new --with-system-gdbinit-dir option.
1523         * config.in: Regenerate.
1524         * configure: Regenerate.
1525         * configure.ac: Add new option --with-system-gdbinit-dir.
1526         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1527         for a ".gdb" suffix.
1528         * main.c (get_init_files): Change system_gdbinit argument to
1529         a vector and return the files in SYSTEM_GDBINIT_DIR in
1530         addition to SYSTEM_GDBINIT.
1531         (captured_main_1): Update.
1532         (print_gdb_help): Update.
1533         * top.c (print_gdb_configuration): Also print the value of
1534         SYSTEM_GDBINIT_DIR.
1535
1536 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1537
1538         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1539         that takes gdb::string_view arguments.
1540
1541 2019-10-26  Tom de Vries  <tdevries@suse.de>
1542
1543         * aarch64-linux-tdep.c: Fix typos in comments.
1544         * aarch64-tdep.c: Same.
1545         * ada-lang.c: Same.
1546         * amd64-nat.c: Same.
1547         * arc-tdep.c: Same.
1548         * arch/aarch64-insn.c: Same.
1549         * block.c: Same.
1550         * breakpoint.h: Same.
1551         * btrace.h: Same.
1552         * c-varobj.c: Same.
1553         * cli/cli-decode.c: Same.
1554         * cli/cli-script.c: Same.
1555         * cli/cli-utils.h: Same.
1556         * coff-pe-read.c: Same.
1557         * coffread.c: Same.
1558         * compile/compile-cplus-symbols.c: Same.
1559         * compile/compile-object-run.c: Same.
1560         * completer.c: Same.
1561         * corelow.c: Same.
1562         * cp-support.c: Same.
1563         * demangle.c: Same.
1564         * dwarf-index-write.c: Same.
1565         * dwarf2-frame.c: Same.
1566         * dwarf2-frame.h: Same.
1567         * eval.c: Same.
1568         * frame-base.h: Same.
1569         * frame.h: Same.
1570         * gdbcmd.h: Same.
1571         * gdbtypes.h: Same.
1572         * gnu-nat.c: Same.
1573         * guile/scm-objfile.c: Same.
1574         * i386-tdep.c: Same.
1575         * i386-tdep.h: Same.
1576         * infcall.c: Same.
1577         * infcall.h: Same.
1578         * linux-nat.c: Same.
1579         * m68k-tdep.c: Same.
1580         * macroexp.c: Same.
1581         * memattr.c: Same.
1582         * mi/mi-cmd-disas.c: Same.
1583         * mi/mi-getopt.h: Same.
1584         * mi/mi-main.c: Same.
1585         * minsyms.c: Same.
1586         * nat/aarch64-sve-linux-sigcontext.h: Same.
1587         * objfiles.h: Same.
1588         * ppc-linux-nat.c: Same.
1589         * ppc-linux-tdep.c: Same.
1590         * ppc-tdep.h: Same.
1591         * progspace.h: Same.
1592         * prologue-value.h: Same.
1593         * python/py-evtregistry.c: Same.
1594         * python/py-instruction.h: Same.
1595         * record-btrace.c: Same.
1596         * record-full.c: Same.
1597         * remote.c: Same.
1598         * rs6000-tdep.c: Same.
1599         * ser-tcp.c: Same.
1600         * sol-thread.c: Same.
1601         * sparc-sol2-tdep.c: Same.
1602         * sparc64-tdep.c: Same.
1603         * stabsread.c: Same.
1604         * symfile.c: Same.
1605         * symtab.h: Same.
1606         * target.c: Same.
1607         * tracepoint.c: Same.
1608         * tui/tui-data.h: Same.
1609         * tui/tui-io.c: Same.
1610         * tui/tui-win.c: Same.
1611         * tui/tui.c: Same.
1612         * unittests/rsp-low-selftests.c: Same.
1613         * user-regs.h: Same.
1614         * utils.c: Same.
1615         * utils.h: Same.
1616         * valarith.c: Same.
1617         * valops.c: Same.
1618         * valprint.c: Same.
1619         * valprint.h: Same.
1620         * value.c: Same.
1621         * value.h: Same.
1622         * varobj.c: Same.
1623         * x86-nat.h: Same.
1624         * xtensa-tdep.c: Same.
1625
1626 2019-10-25  Ali Tamur <tamur@google.com>
1627
1628         * charset.c (find_charset_names): Reflect API change.
1629
1630 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1631
1632         * symtab.c (struct demangled_name_entry): Change demangled name
1633         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1634         part of the struct anymore.
1635         (symbol_set_names): No longer obstack allocate + copy the demangled
1636         name, just store the allocated name from bfd.
1637
1638 2019-10-25  Tom Tromey  <tromey@adacore.com>
1639
1640         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1641         (bsearch_cie_cmp, add_cie): Remove.
1642         (find_cie): Reimplement.
1643         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1644         (dwarf2_build_frame_info): Update.
1645
1646 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1647
1648         PR gdb/25126
1649         * symfile.c (reread_symbols): Call forget_cached_source_info to
1650         clear the stale source cache.
1651
1652 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1653
1654         * configure: Regenerate.
1655         * configure.ac: Remove code that sets python_has_threads.
1656
1657 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1658
1659         * config.in: Regenerate.
1660         * configure: Regenerate.
1661         * configure.ac: Remove the code that uses sed to get the python
1662         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1663
1664 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1667         error paths.
1668
1669 2019-10-23  Tom Tromey  <tom@tromey.com>
1670
1671         * arc-tdep.c: Remove ".." from include.
1672         * frv-tdep.c: Remove ".." from include.
1673         * lm32-tdep.c: Remove ".." from include.
1674         * microblaze-tdep.c: Remove ".." from include.
1675         * or1k-tdep.h: Remove ".." from include.
1676         * s12z-tdep.c: Remove ".." from include.
1677         * Makefile.in (OPCODES_CFLAGS): Add comment.
1678         (TOP_CFLAGS): New variable.
1679         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1680
1681 2019-10-23  Tom Tromey  <tom@tromey.com>
1682
1683         * Makefile.in (READLINE_DIR): Update.
1684
1685 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1686
1687         * infcall.c (call_function_by_hand_dummy): Fix the function
1688         comment.  And extract out a code section into...
1689         (reserve_stack_space): ...this new function.
1690
1691 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1692
1693         * infcall.c (value_arg_coerce): Remove an unused parameter.
1694         (call_function_by_hand_dummy): Update the call to
1695         'value_arg_coerce'.
1696
1697 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1698
1699         * infcall.c (call_function_by_hand_dummy): Refactor.
1700
1701 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1702
1703         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1704
1705 2019-10-23  Tom Tromey  <tom@tromey.com>
1706
1707         * configure: Rebuild.
1708         * configure.ac: Don't check for sigprocmask.
1709         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1710
1711 2019-10-23  Tom Tromey  <tom@tromey.com>
1712
1713         * configure: Rebuild.
1714         * acinclude.m4: Use m4_include, not sinclude.
1715
1716 2019-10-23  Tom de Vries  <tdevries@suse.de>
1717
1718         PR breakpoints/24687
1719         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1720
1721 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1722
1723         * symtab.c (struct demangled_name_entry) <language>: Change from
1724         bitfield to regular variable.
1725
1726 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1727
1728         * symtab.c (struct demangled_name_entry): Add a constructor.
1729         (free_demangled_name_entry): New function to call the destructor
1730         for demangled_name_entry.
1731         (create_demangled_names_hash): Pass free_demangled_name_entry to
1732         htab_create_alloc.
1733         (symbol_set_names): Call placement new for demangled_name_entry.
1734         * utils.c: No longer include xxhash.h here, now that fast_hash
1735         is inlined in the header.
1736         * utils.h: Instead, include it here.
1737
1738 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1739
1740         * Makefile.in: Link with libxxhash.
1741         * config.in: Regenerate.
1742         * configure: Regenerate.
1743         * configure.ac: Search for libxxhash.
1744         * utils.c (fast_hash): Use xxhash if present.
1745
1746 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1747
1748         * utils.h (fast_hash): New function.
1749         * symtab.c (hash_demangled_name_entry): Call new function
1750         fast_hash.
1751
1752 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1753
1754         * symtab.c (struct demangled_name_entry): Change type of mangled
1755         to gdb::string_view. Also adds a constructor that takes the
1756         mangled name.
1757         (hash_demangled_name_entry): Update.
1758         (eq_demangled_name_entry): Update.
1759         (free_demangled_name_entry): New function to call the destructor
1760         now that this is not a POD anymore.
1761         (create_demangled_names_hash): Pass free_demangled_name_entry to
1762         htab_create_alloc.
1763         (symbol_set_names): Update.
1764
1765 2019-10-21  Ali Tamur  <tamu@google.com>
1766
1767         * dwarf2read.c (dir_index): Change type.
1768         (file_name_index): Likewise.
1769         (line_header::include_dir_at): Change comment and implementation on
1770         whether it is DWARF 5.
1771         (line_header::is_valid_file_index): New function.
1772         (line_header::file_name_at): Change comment and implementation on
1773         whether it is DWARF 5.
1774         (line_header::file_names): Change to private field renamed as
1775         m_file_names and introduce a new accessor method.
1776         (line_header::file_names_size): New method.
1777         (line_header::include_dirs): Change to private field and rename as
1778         m_include_dirs.
1779         (dw2_get_file_names_reader): Define local var at a smaller scope and
1780         reflect API change.
1781         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1782         (process_structure_scope): Likewise.
1783         (line_header::add_include_dir): Change message and reflect renaming.
1784         (line_header::add_file_name): Likewise.
1785         (read_formatted_entries): Handle DW_FORM_data16.
1786         (dwarf_decode_line_header): Fix line header length calculation.
1787         (psymtab_include_file_name): Change comment and API.
1788         (lnp_state_machine::m_file): Update comment and reflect type change.
1789         (lnp_state_machine::record_line): Reflect type change.
1790         (dwarf_decode_lines): Reflect API change.
1791         (file_file_name): Likewise.
1792         (file_full_name): Likewise.
1793
1794 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1797
1798 2019-10-21  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1801
1802 2019-10-21  Tom Tromey  <tom@tromey.com>
1803
1804         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1805         NM_H.   Use AC_CONFIG_LINKS.
1806         * configure: Rebuild.
1807         * Makefile.in (NM_H): New variable.
1808         (generated_files): Add NM_H.  Remove gcore.
1809         (nm.h, stamp-nmh): New targets.
1810
1811 2019-10-20  Tom Tromey  <tom@tromey.com>
1812
1813         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1814         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1815         obsolete comment.
1816         (put_objfile_before): Now static.
1817
1818 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1819
1820         * gdbsupport/common-utils.h (startswith): Change return type to
1821         bool.
1822
1823 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1824
1825         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1826         * breakpoint.c (bp_locations_compare): Rename to...
1827         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1828         (update_global_location_list): Use std::sort instead of qsort.
1829         * buildsym.c (compare_line_numbers): Rename to...
1830         (lte_is_less_than): ...this, and change to std::sort semantics.
1831         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1832         instead of qsort.
1833         * disasm.c (compare_lines): Rename to...
1834         (line_is_less_than): ...this, and change to std::sort semantics.
1835         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1836         of qsort.
1837         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1838         (fde_is_less_than): ...this, and change to std::sort semantics.
1839         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1840         * mdebugread.c (compare_blocks):
1841         (block_is_less_than): ...this, and change to std::sort semantics.
1842         (sort_blocks): Call std::sort instead of qsort.
1843         * objfiles.c (qsort_cmp): Rename to...
1844         (sort_cmp): ...this, and change to std::sort semantics.
1845         (update_section_map): Call std::sort instead of qsort.
1846         * remote.c (compare_pnums): Remove.
1847         (map_regcache_remote_table): Call std::sort instead of qsort.
1848         * utils.c (compare_positive_ints): Remove.
1849         * utils.h (compare_positive_ints): Remove.
1850         * xcoffread.c (compare_lte): Remove.
1851         (arrange_linetable): Call std::sort instead of qsort.
1852
1853 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1854
1855         * symfile.c (init_entry_point_info): Fix typo.
1856         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1857
1858 2019-10-18  Tom de Vries  <tdevries@suse.de>
1859
1860         * aarch64-tdep.c: Fix typos in comments.
1861         * ada-lang.c: Same.
1862         * ada-tasks.c: Same.
1863         * alpha-tdep.c: Same.
1864         * alpha-tdep.h: Same.
1865         * amd64-nat.c: Same.
1866         * amd64-windows-tdep.c: Same.
1867         * arc-tdep.c: Same.
1868         * arc-tdep.h: Same.
1869         * arch-utils.c: Same.
1870         * arm-nbsd-tdep.c: Same.
1871         * arm-tdep.c: Same.
1872         * ax-gdb.c: Same.
1873         * blockframe.c: Same.
1874         * btrace.c: Same.
1875         * c-varobj.c: Same.
1876         * coff-pe-read.c: Same.
1877         * coffread.c: Same.
1878         * cris-tdep.c: Same.
1879         * darwin-nat.c: Same.
1880         * dbxread.c: Same.
1881         * dcache.c: Same.
1882         * disasm.c: Same.
1883         * dtrace-probe.c: Same.
1884         * dwarf-index-write.c: Same.
1885         * dwarf2-frame-tailcall.c: Same.
1886         * dwarf2-frame.c: Same.
1887         * dwarf2read.c: Same.
1888         * eval.c: Same.
1889         * exceptions.c: Same.
1890         * fbsd-tdep.c: Same.
1891         * findvar.c: Same.
1892         * frame.c: Same.
1893         * frv-tdep.c: Same.
1894         * gnu-v3-abi.c: Same.
1895         * go32-nat.c: Same.
1896         * h8300-tdep.c: Same.
1897         * hppa-tdep.c: Same.
1898         * i386-linux-tdep.c: Same.
1899         * i386-tdep.c: Same.
1900         * ia64-libunwind-tdep.c: Same.
1901         * ia64-tdep.c: Same.
1902         * infcmd.c: Same.
1903         * infrun.c: Same.
1904         * linespec.c: Same.
1905         * linux-nat.c: Same.
1906         * linux-thread-db.c: Same.
1907         * machoread.c: Same.
1908         * mdebugread.c: Same.
1909         * mep-tdep.c: Same.
1910         * mn10300-tdep.c: Same.
1911         * namespace.c: Same.
1912         * objfiles.c: Same.
1913         * opencl-lang.c: Same.
1914         * or1k-tdep.c: Same.
1915         * osabi.c: Same.
1916         * ppc-linux-nat.c: Same.
1917         * ppc-linux-tdep.c: Same.
1918         * ppc-sysv-tdep.c: Same.
1919         * printcmd.c: Same.
1920         * procfs.c: Same.
1921         * record-btrace.c: Same.
1922         * record-full.c: Same.
1923         * remote-fileio.c: Same.
1924         * remote.c: Same.
1925         * rs6000-tdep.c: Same.
1926         * s12z-tdep.c: Same.
1927         * score-tdep.c: Same.
1928         * ser-base.c: Same.
1929         * ser-go32.c: Same.
1930         * skip.c: Same.
1931         * sol-thread.c: Same.
1932         * solib-svr4.c: Same.
1933         * solib.c: Same.
1934         * source.c: Same.
1935         * sparc-nat.c: Same.
1936         * sparc-sol2-tdep.c: Same.
1937         * sparc-tdep.c: Same.
1938         * sparc64-tdep.c: Same.
1939         * stabsread.c: Same.
1940         * stack.c: Same.
1941         * symfile.c: Same.
1942         * symtab.c: Same.
1943         * target-descriptions.c: Same.
1944         * target-float.c: Same.
1945         * thread.c: Same.
1946         * utils.c: Same.
1947         * valops.c: Same.
1948         * valprint.c: Same.
1949         * value.c: Same.
1950         * varobj.c: Same.
1951         * windows-nat.c: Same.
1952         * xcoffread.c: Same.
1953         * xstormy16-tdep.c: Same.
1954         * xtensa-tdep.c: Same.
1955
1956 2019-10-17  Tom Tromey  <tromey@adacore.com>
1957
1958         * configure: Rebuild.
1959         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1960         in AC_CONFIG_FILES invocation.
1961         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1962         new-style config.status invocation.
1963
1964 2019-10-17  Tom de Vries  <tdevries@suse.de>
1965
1966         * arm-nbsd-nat.c: Fix typos in comments.
1967         * arm-tdep.c: Same.
1968         * darwin-nat-info.c: Same.
1969         * dwarf2read.c: Same.
1970         * elfread.c: Same.
1971         * event-top.c: Same.
1972         * findvar.c: Same.
1973         * gdbtypes.c: Same.
1974         * hppa-tdep.c: Same.
1975         * i386-tdep.c: Same.
1976         * jit.c: Same.
1977         * main.c: Same.
1978         * mdebugread.c: Same.
1979         * moxie-tdep.c: Same.
1980         * nto-procfs.c: Same.
1981         * osabi.c: Same.
1982         * ppc-linux-tdep.c: Same.
1983         * remote.c: Same.
1984         * riscv-tdep.c: Same.
1985         * s390-tdep.c: Same.
1986         * sh-tdep.c: Same.
1987         * sparc-linux-tdep.c: Same.
1988         * sparc-nat.c: Same.
1989         * stack.c: Same.
1990         * target-descriptions.c: Same.
1991         * top.c: Same.
1992         * varobj.c: Same.
1993
1994 2019-10-16  Tom Tromey  <tom@tromey.com>
1995
1996         * objfiles.h (struct objfile) <original_name>: Now const.
1997
1998 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1999
2000         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2001         pass on to sigsetjmp's second argument.
2002         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2003
2004 2019-10-16  Keith Seitz  <keiths@redhat.com>
2005
2006         PR gdb/23567
2007         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2008         sections whose size is greater than the file size.
2009
2010 2019-10-16  Jim Wilson  <jimw@sifive.com>
2011
2012         * riscv-tdep.c (riscv_gcc_target_options): New.
2013         (riscv_gnu_triplet_regexp): New.
2014         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2015         set_gdbarch_gnu_triplet_regexp.
2016
2017 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2018
2019         * Makefile.in: Add xml-builtin.h.
2020         * features/feature_to_c.sh: Add an include for xml-builtin.h
2021         to ensure that the compiler checks that the types match.
2022         * xml-builtin.h: New file.
2023         * xml-support.c (fetch_xml_builtin): Add missing const.
2024         * xml-support.h: Remove declaration of xml_builtins.
2025
2026 2019-10-16  Tom de Vries  <tdevries@suse.de>
2027
2028         PR tdep/25096
2029         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2030         (amd64_classify_aggregate): ... here.
2031         (amd64_classify_aggregate_field): Handled fiels of nested structs
2032         recursively.
2033
2034 2019-10-16  Tom de Vries  <tdevries@suse.de>
2035
2036         PR tdep/24104
2037         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2038         that handles 'theclass'.
2039
2040 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * linespec.c (decode_digits_ordinary): Update comment.
2043         * make-target-delegates: No longer need to handle VEC case.
2044         * memrange.c (normalize_mem_ranges): Update comment.
2045         * namespace.c (add_using_directive): Update comment.
2046         * objc-lang.c (uniquify_strings): Update comment.
2047         * ppc-linux-nat.c (struct thread_points): Update comment.
2048         * probe.h (find_probes_in_objfile): Update comment.
2049         * target.h (enum flash_preserve_mode): Update comment.
2050         * varobj.c (varobj_restrict_range): Update comment.
2051         * varobj.h (varobj_list_children): Update comment.
2052
2053 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2054
2055         * Makefile.in: Remove references to vec.h and vec.c.
2056         * aarch64-tdep.c: No longer include vec.h.
2057         * ada-lang.c: Likewise.
2058         * ada-lang.h: Likewise.
2059         * arm-tdep.c: Likewise.
2060         * ax.h: Likewise.
2061         * breakpoint.h: Likewise.
2062         * charset.c: Likewise.
2063         * cp-support.h: Likewise.
2064         * dtrace-probe.c: Likewise.
2065         * dwarf2read.c: Likewise.
2066         * extension.h: Likewise.
2067         * gdb_bfd.c: Likewise.
2068         * gdbsupport/gdb_vecs.h: Likewise.
2069         * gdbsupport/vec.c: Remove.
2070         * gdbsupport/vec.h: Remove.
2071         * gdbthread.h: Likewise.
2072         * guile/scm-type.c: Likewise.
2073         * inline-frame.c: Likewise.
2074         * machoread.c: Likewise.
2075         * memattr.c: Likewise.
2076         * memrange.h: Likewise.
2077         * namespace.h: Likewise.
2078         * nat/linux-btrace.h: Likewise.
2079         * osdata.c: Likewise.
2080         * parser-defs.h: Likewise.
2081         * progspace.h: Likewise.
2082         * python/py-type.c: Likewise.
2083         * record-btrace.c: Likewise.
2084         * rust-exp.y: Likewise.
2085         * solib-target.c: Likewise.
2086         * stap-probe.c: Likewise.
2087         * target-descriptions.c: Likewise.
2088         * target-memory.c: Likewise.
2089         * target.h: Likewise.
2090         * varobj.c: Likewise.
2091         * varobj.h: Likewise.
2092         * xml-support.h: Likewise.
2093
2094 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2097         Update for new std::vector based implementation.
2098         (process_psymtab_comp_unit_reader): Likewise.
2099         (scan_partial_symbols): Likewise.
2100         (recursively_compute_inclusions): Likewise.
2101         (compute_compunit_symtab_includes): Likewise.
2102         (process_imported_unit_die): Likewise.
2103         (queue_and_load_dwo_tu): Likewise.
2104         (follow_die_sig_1): Likewise.
2105         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2106         (typedef dwarf2_per_cu_ptr): Remove.
2107         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2108         function.
2109         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2110         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2111         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2112         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2113         std::vector.
2114
2115 2019-10-15  Tom Tromey  <tromey@adacore.com>
2116
2117         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2118         TID.
2119
2120 2019-10-15  Tom Tromey  <tromey@adacore.com>
2121
2122         * windows-nat.c (windows_nat_target::fetch_registers)
2123         (windows_nat_target::store_registers): Rename "pid" to "tid".
2124
2125 2019-10-15  Tom Tromey  <tromey@adacore.com>
2126
2127         * gdbarch.h, gdbarch.c: Rebuild.
2128         * gdbarch.sh (gcc_target_options): Change return type to
2129         std::string.
2130         * compile/compile.c (get_args): Update.
2131         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2132         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2133         std::string.
2134         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2135         std::string.
2136         * arch-utils.c (default_gcc_target_options): Return std::string.
2137         * arch-utils.h (default_gcc_target_options): Return std::string.
2138         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2139
2140 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2141
2142         * breakpoint.c (breakpoint_chain): Make static.
2143         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2144         of accessing breakpoint_chain.
2145
2146 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2147
2148         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2149         to a gdb::function_view and return value to bool.
2150         * breakpoint.h (iterate_over_breakpoints): Likewise.
2151         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2152         (pop_dummy_frame): Update.
2153         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2154         (gdbscm_breakpoints): Update.
2155         * python/py-breakpoint.c (build_bp_list): Update.
2156         (gdbpy_breakpoints): Update.
2157         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2158         Update.
2159         (bpfinishpy_handle_stop): Update.
2160         (bpfinishpy_handle_exit): Update.
2161         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2162         (svr4_update_solib_event_breakpoints): Update.
2163
2164 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2165
2166         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2167         when unwrapping single-field structs.
2168
2169 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2170
2171         * dwarf2read.c: Remove includes.
2172
2173 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2174
2175         * ui-out.c (ui_out::call_do_message): Silence
2176         -Wformat-nonliteral warning.
2177
2178 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2179
2180         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2181         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2182         include: readline/tilde.h.
2183
2184 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2185
2186         * remote.c (remote_target::get_trace_status): Remove declaration of
2187         trace_regblock_size.
2188
2189 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2190
2191         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2192         (show_user): Remove declaration of cmdlist.
2193         * cli/cli-cmds.h (max_user_call_depth): Declare.
2194         * cli/cli-script.c (execute_user_command): Remove declaration
2195         of max_user_call_depth.
2196
2197 2019-10-11  Jim Wilson  <jimw@sifive.com>
2198
2199         * gdbsupport/print-utils.h (pulongest): Fix comment.
2200         (plongest): Likewise.
2201         (phex): Add missing comment, mention leading zeros.
2202         (phex_nz): Add mention of no leading zeros to comment.
2203
2204         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2205         plongest instead of unsigned long long cast.
2206
2207 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2208
2209         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2210         for external_editor_command and gdbtk_test.
2211
2212 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2213
2214         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2215         * varobj.c (varobjdebug): Move comment to...
2216         * varobj.h (varobjdebug): ...here, and declare.
2217
2218 2019-10-09  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2221         erase_data_content.
2222
2223 2019-10-09  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2226         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2227         * tui/tui-command.c (tui_cmd_window::resize)
2228         (tui_refresh_cmd_win): Update.
2229         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2230         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2231         * tui/tui-data.c (~tui_gen_win_info): Remove.
2232         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2233         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2234         (tui_redisplay_readline, tui_mld_flush)
2235         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2236         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2237         (tui_data_window::erase_data_content)
2238         (tui_data_item_window::rerender)
2239         (tui_data_item_window::refresh_window): Update.
2240         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2241         (box_win, tui_gen_win_info::make_window)
2242         (tui_gen_win_info::make_visible): Update.
2243         (tui_delete_win): Remove.
2244         * tui/tui-winsource.c
2245         (tui_source_window_base::do_erase_source_content): Update.
2246         (tui_show_source_line, tui_source_window_base::update_tab_width)
2247         (tui_source_window_base::update_exec_info): Update.
2248         * tui/tui-data.h (struct curses_deleter): New.
2249         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2250         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2251
2252 2019-10-09  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2255
2256 2019-10-09  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2259         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2260
2261 2019-10-09  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2264         window height directly.
2265         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2266         declare.
2267         * tui/tui-layout.c (tui_default_win_height): Remove.
2268         (tui_default_win_viewport_height): Remove.
2269
2270 2019-10-09  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui.h: Remove comments.
2273
2274 2019-10-09  Tom de Vries  <tdevries@suse.de>
2275
2276         * python/lib/gdb/printer/bound_registers.py: Use
2277         '^builtin_type_bound128' as regexp argument for
2278         add_builtin_pretty_printer.
2279
2280 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2281
2282         * guile/guile.c (guile_extension_script_ops): Remove forward
2283         declaration and mark as static.
2284         (guile_script_ops): Likewise.
2285         (extension_language_guile): Move further down in the file so
2286         it can reference the definitions for guile_{extension_,}script_ops.
2287
2288 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2289
2290         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2291         except SORTL, DFLTCC, and KDSA.
2292
2293 2019-10-08  Tom Tromey  <tromey@adacore.com>
2294
2295         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2296         (struct safe_symbol_file_add_args): Remove.
2297
2298 2019-10-08  Tom Tromey  <tromey@adacore.com>
2299
2300         * windows-nat.c: Don't include buildsym-legacy.h.
2301
2302 2019-10-08  Tom Tromey  <tromey@adacore.com>
2303
2304         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2305
2306 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2307
2308         * gdbtypes.c (overload_debug): Move comment to header.
2309         * gdbtypes.h (overload_debug): Declare.
2310         * valops.c: Remove declaration of overload_debug, instead
2311         include gdbtypes.h.
2312
2313 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2314
2315         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2316         through _().
2317         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2318         move comment...
2319         * language.h (lang_frame_mismatch_warn): ... here. Also add
2320         declaration.
2321         * top.c (lang_frame_mismatch_warn): Remove declaration.
2322         (check_frame_language_change): Pass lang_frame_mismatch_warn
2323         through _().
2324
2325 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2326
2327         * c-lang.h (vtbl_ptr_name): Declare.
2328         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2329         it from the header.
2330         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2331
2332 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2333
2334         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2335         gdb_static_assert.
2336
2337 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2338
2339         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2340         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2341         * ctfread.c: New file.
2342         * ctfread.h: New file.
2343         * elfread.c: Include ctfread.h.
2344         (struct elfinfo text_p): New member ctfsect.
2345         (elf_locate_sections): Mark CTF section.
2346         (elf_symfile_read): Call elfctf_build_psymtabs.
2347         * Makefile.in (LIBCTF): Add.
2348         (CLIBS): Use it.
2349         (CDEPS): Likewise.
2350         (DIST): Add ctfread.c.
2351
2352 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * ctfread.c (struct nextfield): Renamed to ...
2355         (struct ctf_nextfield): ... this.
2356         (struct field_info): Renamed to ...
2357         (strut ctf_field_info): ... this.
2358         (attach_fields_to_type): Update for renamed structures.
2359         (ctf_add_member_cb): Likewise.
2360         (ctf_add_enum_member_cb): Likewise.
2361         (process_struct_members): Likewise.
2362         (process_enum_type): Likewise.
2363
2364 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2365
2366         * tracectf.h: Rename, was ctf.h.
2367         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2368         * tracefile.c: Likewise.
2369         * tracepoint.c: Remove unused include ctf.h.
2370         * mi/mi-main.c: Likewise.
2371         * Makefile.in Replace ctf.c with tracectf.c.
2372
2373 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2374
2375         * version.in: Change version number to "9.0.50.DATE-git".
2376
2377 2019-10-03  Tom Tromey  <tom@tromey.com>
2378
2379         PR rust/24976:
2380         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2381
2382 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2385         cp_search_name_hash.
2386         * NEWS: Add entry about nested function support.
2387
2388 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2389             Andrew Burgess  <andrew.burgess@embecosm.com>
2390
2391         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2392         for nested static variables when searchin VAR_DOMAIN.
2393         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2394         global scope, update comment.
2395         (add_partial_subprogram): Call add_partial_subprogram recursively
2396         for nested subroutines when processinng Fortran.
2397         (load_partial_dies): Process the child entities of a subprogram
2398         when processing Fortran.
2399         (partial_die_parent_scope): Handle building scope
2400         for Fortran nested functions.
2401         (process_die): Record that nested functions have a scope.
2402         (new_symbol): Always record Fortran subprograms on the global
2403         symbol list.
2404         (determine_prefix): How to build the prefix for Fortran
2405         subprograms.
2406
2407 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2410         have just sent the thread a SIGSTOP and are waiting for it to
2411         arrive.
2412
2413 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * btrace.c (btrace_add_pc): Remove whitespace before the template
2416         parameter in 'std::vector <...>'.
2417         (parse_xml_btrace_block): Likewise.
2418         (btrace_maint_decode_pt): Likewise.
2419         (btrace_maint_update_packets): Likewise.
2420         (btrace_maint_print_packets): Likewise.
2421         * btrace.h (struct btrace_maint_info): Likewise.
2422         * dwarf2read.c (struct type_unit_group): Likewise.
2423         (build_type_psymtabs_reader): Likewise.
2424         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2425         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2426         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2427
2428 2019-10-03  Tom de Vries  <tdevries@suse.de>
2429
2430         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2431         the first line of the help text for set/show style metadata.
2432
2433 2019-10-02  Tom Tromey  <tromey@adacore.com>
2434
2435         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2436         * gdbsupport/common-inferior.c: New file.
2437         * infcmd.c (startup_with_shell): Don't define.
2438         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2439         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2440         * inferior.h (startup_with_shell): Don't declare.
2441
2442 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2443
2444         * gdbsupport/gdb_assert.h: Include errors.h.
2445         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2446
2447 2019-10-02  Tom Tromey  <tromey@adacore.com>
2448
2449         * NEWS: Add $_ada_exception entry.
2450         * ada-lang.c (struct ada_catchpoint): Add constructor.
2451         <m_kind>: New member.
2452         (allocate_location_exception, re_set_exception): Remove
2453         "ex" parameter.
2454         (should_stop_exception): Compute $_ada_exception.
2455         (check_status_exception, print_it_exception)
2456         (print_one_exception, print_mention_exception): Remove
2457         "ex" parameter.
2458         (allocate_location_catch_exception, re_set_catch_exception)
2459         (check_status_exception, print_it_catch_exception)
2460         (print_one_catch_exception, print_mention_catch_exception)
2461         (print_recreate_catch_exception)
2462         (allocate_location_catch_exception_unhandled)
2463         (re_set_catch_exception_unhandled)
2464         (check_status_exception, print_it_catch_exception_unhandled)
2465         (print_one_catch_exception_unhandled)
2466         (print_mention_catch_exception_unhandled)
2467         (print_recreate_catch_exception_unhandled)
2468         (allocate_location_catch_assert, re_set_catch_assert)
2469         (check_status_assert, print_it_catch_assert)
2470         (print_one_catch_assert, print_mention_catch_assert)
2471         (print_recreate_catch_assert)
2472         (allocate_location_catch_handlers, re_set_catch_handlers)
2473         (check_status_handlers, print_it_catch_handlers)
2474         (print_one_catch_handlers, print_mention_catch_handlers)
2475         (print_recreate_catch_handlers): Remove.
2476         (create_ada_exception_catchpoint): Update.
2477         (initialize_ada_catchpoint_ops): Update.
2478
2479 2019-10-02  Tom Tromey  <tromey@adacore.com>
2480
2481         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2482         (create_excep_cond_exprs): Simplify exception string computation.
2483         (ada_exception_catchpoint_cond_string): Likewise.
2484
2485 2019-10-02  Tom Tromey  <tromey@adacore.com>
2486
2487         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2488         * ada-lang.c (lesseq_defined_than): Handle
2489         LOC_STATIC.
2490         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2491         parameter.
2492         (dwarf2_has_info): Likewise.
2493         (new_symbol): Set maybe_copied on symbol when
2494         appropriate.
2495         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2496         parameter.
2497         <can_copy>: New member.
2498         * elfread.c (record_minimal_symbol): Set maybe_copied
2499         on symbol when appropriate.
2500         (elf_symfile_read): Update call to dwarf2_has_info.
2501         * minsyms.c (lookup_minimal_symbol_linkage): New
2502         function.
2503         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2504         * symtab.c (get_symbol_address, get_msymbol_address):
2505         New functions.
2506         * symtab.h (get_symbol_address, get_msymbol_address):
2507         Declare.
2508         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2509         maybe_copied.
2510         (struct symbol, struct minimal_symbol) <maybe_copied>:
2511         New member.
2512
2513 2019-10-02  Tom Tromey  <tromey@adacore.com>
2514
2515         * source.c (struct current_source_location): New.
2516         (current_source_key): New global.
2517         (current_source_symtab, current_source_line)
2518         (current_source_pspace): Remove.
2519         (get_source_location): New function.
2520         (get_current_source_symtab_and_line)
2521         (set_default_source_symtab_and_line)
2522         (set_current_source_symtab_and_line)
2523         (clear_current_source_symtab_and_line, select_source_symtab)
2524         (info_source_command, print_source_lines_base)
2525         (info_line_command, search_command_helper, _initialize_source):
2526         Update.
2527
2528 2019-10-02  Tom Tromey  <tromey@adacore.com>
2529
2530         * source.c (select_source_symtab): Don't call
2531         decode_line_with_current_source.
2532
2533 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * symtab.c (lookup_global_symbol): Search global block.
2536
2537 2019-10-02  Tom Tromey  <tromey@adacore.com>
2538
2539         * coffread.c (process_coff_symbol): Update.
2540         * dwarf2read.c (var_decode_location, new_symbol): Update.
2541         * mdebugread.c (parse_symbol): Update.
2542         * objfiles.c (relocate_one_symbol): Update.
2543         * stabsread.c (define_symbol, fix_common_block)
2544         (scan_file_globals): Update.
2545         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2546         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2547         * xcoffread.c (process_xcoff_symbol): Update.
2548
2549 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2550
2551         * MAINTAINERS: Update my email address.
2552
2553 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2554
2555         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2556         std::vector.
2557         (build_type_psymtabs_reader): Update for std::vector.
2558         (build_type_psymtab_dependencies): Likewise.
2559         * dwarf2read.h: Remove use of DEF_VEC_P.
2560         (typedef sig_type_ptr): Delete.
2561
2562 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2565         to std::vector.
2566         (btrace_maint_decode_pt): Likewise, and move allocation of the
2567         vector outside of the loop.
2568         (btrace_maint_update_packets): Update to handle change from VEC to
2569         std::vector.
2570         (btrace_maint_print_packets): Likewise.
2571         (maint_info_btrace_cmd): Likewise.
2572         * btrace.h: Remove use of DEF_VEC_O.
2573         (typedef btrace_pt_packet_s): Delete.
2574         (struct btrace_maint_info) <packets>: Change fromm VEC to
2575         std::vector.
2576         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2577
2578 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2581         make accesses into the vector constant references.
2582         (btrace_add_pc): Update for std::vector.
2583         (btrace_stitch_bts): Likewise.
2584         (parse_xml_btrace_block): Likewise.
2585         (btrace_maint_update_packets): Likewise.
2586         (btrace_maint_print_packets): Likewise.
2587         (maint_info_btrace_cmd): Likewise.
2588         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2589         std::vector.
2590         (btrace_data::empty): Likewise.
2591         (btrace_data_append): Likewise.
2592         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2593         (typedef btrace_block_s): Delete.
2594         (struct btrace_block): Add constructor.
2595         (struct btrace_data_bts) <blocks>: Change to std::vector.
2596         * nat/linux-btrace.c (perf_event_read_bts): Update for
2597         std::vector.
2598         (linux_read_bts): Likewise.
2599
2600 2019-10-01  Tom Tromey  <tom@tromey.com>
2601
2602         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2603
2604 2019-10-01  Tom Tromey  <tom@tromey.com>
2605
2606         * stack.c (print_frame, info_frame_command_core): Use
2607         styled_string.
2608         * linux-thread-db.c (try_thread_db_load_1)
2609         (try_thread_db_load_from_pdir_1): Use styled_string.
2610         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2611         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2612         (maybe_print_unsupported_script_warning)
2613         (maybe_print_script_not_found_warning): Use styled_string.
2614         * ada-lang.c (user_select_syms): Use styled_string.
2615
2616 2019-10-01  Tom Tromey  <tom@tromey.com>
2617
2618         * p-lang.c (pascal_printstr): Use metadata style.
2619         * value.c (show_convenience): Use metadata style.
2620         * valprint.c (valprint_check_validity, val_print_optimized_out)
2621         (val_print_not_saved, val_print_unavailable)
2622         (val_print_invalid_address, generic_val_print, val_print)
2623         (value_check_printable, val_print_array_elements): Use metadata
2624         style.
2625         * ui-out.h (class ui_out) <field_fmt>: New overload.
2626         <do_field_fmt>: Add style parameter.
2627         * ui-out.c (ui_out::field_fmt): New overload.
2628         * typeprint.c (type_print_unknown_return_type)
2629         (val_print_not_allocated, val_print_not_associated): Use metadata
2630         style.
2631         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2632         parameter.
2633         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2634         * tracepoint.c (tvariables_info_1): Use metadata style.
2635         * stack.c (print_frame_arg, print_frame_info, print_frame)
2636         (info_frame_command_core): Use metadata style.
2637         * skip.c (info_skip_command): Use metadata style.
2638         * rust-lang.c (rust_print_enum): Use metadata style.
2639         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2640         metadata style.
2641         * python/py-framefilter.c (py_print_single_arg): Use metadata
2642         style.
2643         * printcmd.c (do_one_display, print_variable_and_value): Use
2644         metadata style.
2645         * p-valprint.c (pascal_val_print)
2646         (pascal_object_print_value_fields): Use metadata style.
2647         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2648         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2649         parameter.
2650         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2651         * m2-valprint.c (m2_print_long_set): Use metadata style.
2652         * m2-typeprint.c (m2_print_type): Use metadata style.
2653         * infcmd.c (print_return_value_1): Use metadata style.
2654         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2655         * f-valprint.c (info_common_command_for_block): Use metadata
2656         style.
2657         * f-typeprint.c (f_type_print_base): Use metadata style.
2658         * expprint.c (print_subexp_standard): Use metadata style.
2659         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2660         * cli/cli-style.h (class cli_style_option): Add constructor.
2661         (metadata_style): Declare.
2662         * cli/cli-style.c (metadata_style): New global.
2663         (_initialize_cli_style): Register metadata style.
2664         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2665         parameter.
2666         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2667         * c-typeprint.c (c_type_print_base_struct_union)
2668         (c_type_print_base_1): Use metadata style.
2669         * breakpoint.c (watchpoint_value_print)
2670         (print_one_breakpoint_location): Use metadata style.
2671         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2672         style.
2673         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2674         style.
2675         * ada-valprint.c (val_print_packed_array_elements, printstr)
2676         (print_field_values, ada_val_print_ref, ada_val_print): Use
2677         metadata style.
2678         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2679         style.
2680         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2681         style.
2682         * ada-lang.c (user_select_syms): Use metadata style.
2683
2684 2019-10-01  Tom Tromey  <tom@tromey.com>
2685
2686         * cli/cli-cmds.c (pwd_command): Style output.
2687
2688 2019-10-01  Pedro Alves  <palves@redhat.com>
2689             Tom Tromey  <tom@tromey.com>
2690
2691         * symtab.c (print_symbol_info): Use %ps.
2692         (print_msymbol_info): Use %ps.
2693         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2694         * printcmd.c (print_variable_and_value): Use %ps.
2695         * macrocmd.c (show_pp_source_pos): Use %ps.
2696         * infrun.c (print_exited_reason): Use ui_out::message.
2697         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2698         (describe_other_breakpoints): Use ui_out::message and new
2699         formats.
2700         (say_where): Use new formats.
2701         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2702         and new formats.
2703
2704 2019-10-01  Pedro Alves  <palves@redhat.com>
2705             Tom Tromey  <tom@tromey.com>
2706
2707         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2708         (test_gdb_formats): New function.
2709         (run_tests): Call it.
2710         (test_format_specifier): Update.
2711         * utils.h (fputs_filtered): Update comment.
2712         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2713         (fputs_styled_unfiltered): Declare.
2714         * utils.c (fputs_styled_unfiltered): New function.
2715         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2716         (vfprintf_filtered): Update.
2717         (vfprintf_unfiltered, vprintf_filtered): Update.
2718         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2719         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2720         disallow_ui_out_field>: New constants.
2721         (enum class field_kind): New.
2722         (struct base_field_s, struct signed_field_s): New.
2723         (signed_field): New function.
2724         (struct string_field_s): New.
2725         (string_field): New function.
2726         (struct styled_string_s): New.
2727         (styled_string): New function.
2728         (class ui_out) <message>: Add comment.
2729         <vmessage, call_do_message>: New methods.
2730         <do_message>: Add style parameter.
2731         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2732         methods.
2733         (ui_out::message): Rewrite.
2734         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2735         parameter.
2736         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2737         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2738         gdb_extensions parameter.
2739         (class format_piece): Add parameter to constructor.
2740         (n_int_args): New field.
2741         * gdbsupport/format.c (format_pieces::format_pieces): Add
2742         gdb_extensions parameter.  Handle '*'.
2743         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2744         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2745         vfprintf_styled_no_gdbfmt.
2746         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2747         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2748         unfiltered output.
2749         * ui-style.h (struct ui_file_style) <ptr>: New method.
2750
2751 2019-10-01  Tom Tromey  <tom@tromey.com>
2752
2753         * unittests/format_pieces-selftests.c: Update.  Add final format.
2754         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2755         empty literal pieces.
2756
2757 2019-10-01  Tom Tromey  <tom@tromey.com>
2758
2759         * ui-out.h (enum class ui_out_style_kind): Remove.
2760         (class ui_out) <field_string, field_stsream, do_field_string>:
2761         Change type of "style".
2762         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2763         (ui_out::field_string): Update.
2764         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2765         of "style".
2766         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2767         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2768         * stack.c (print_frame_arg, print_frame_info, print_frame):
2769         Update.
2770         * source.c (print_source_lines_base): Update.
2771         * solib.c (info_sharedlibrary_command): Update.
2772         * skip.c (info_skip_command): Update.
2773         * record-btrace.c (btrace_call_history_src_line)
2774         (btrace_call_history): Update.
2775         * python/py-framefilter.c (py_print_frame): Update.
2776         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2777         "style".
2778         * mi/mi-out.c (mi_ui_out::do_table_header)
2779         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2780         (mi_ui_out::do_field_string): Update.
2781         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2782         Update.
2783         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2784         "style".
2785         * cli-out.c (cli_ui_out::do_table_header)
2786         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2787         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2788         (cli_ui_out::do_field_fmt): Update.
2789         * breakpoint.c (print_breakpoint_location): Update.
2790         (update_static_tracepoint): Update.
2791
2792 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2793
2794         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2795         conversion of gdb_datadir.
2796         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2797         remove not needed c_str ().
2798
2799 2019-09-30  Ali Tamur <tamur@google.com>
2800
2801         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2802         (dwarf2_string_attr): Likewise.
2803
2804 2019-09-30  Ali Tamur <tamur@google.com>
2805
2806         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2807         (process_full_type_unit): Likewise.
2808         (dump_die_shallow): Likewise.
2809         (cu_debug_loc_section): Likewise.
2810
2811 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2812
2813         * minsyms.c (compare_minimal_symbols): Rename to...
2814         (minimal_symbol_is_less_than): ...this, and adjust to STL
2815         conventions (return bool, take arguments as references)
2816         (minimal_symbol_reader::install): Call std::sort instead
2817         of qsort.
2818
2819 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2820
2821         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2822         hash and why.
2823         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2824         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2825
2826 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2827
2828         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2829         * psympriv.h (add_psymbol_to_list): Move comment here and update
2830         it.
2831
2832 2019-09-29  Tom de Vries  <tdevries@suse.de>
2833
2834         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2835         Use $tmpdir/$(basename "$output_file").dwz instead of
2836         "${output_file}.dwz".
2837
2838 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2839
2840         PR gdb/25045
2841         * hppa-linux-nat.c: Include gdbarch.h.
2842
2843 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2844
2845         * blockframe.c (find_pc_partial_function): Change return type to bool.
2846         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2847         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2848         (stub_gnu_ifunc_resolve_name): Likewise.
2849         * symtab.c (compare_filenames_for_search): Likewise.
2850         (compare_glob_filenames_for_search): Likewise.
2851         (matching_obj_sections): Likewise.
2852         (symbol_matches_domain): Likewise.
2853         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2854         (find_line_pc): Change return type to bool.
2855         (find_line_pc_range): Likewise.
2856         (producer_is_realview): Likewise.
2857         * symtab.h (symbol_matches_domain): Likewise.
2858         (find_pc_partial_function): Likewise.
2859         (find_pc_line_pc_range): Likewise.
2860         (in_gnu_ifunc_stub): Likewise.
2861         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2862         (find_line_pc): Likewise.
2863         (find_line_pc_range): Likewise.
2864         (matching_obj_sections): Likewise.
2865         (find_line_symtab): Change out parameter to bool.
2866         (producer_is_realview): Change return type to bool.
2867         (compare_filenames_for_search): Likewise.
2868         (compare_glob_filenames_for_search): Likewise.
2869
2870 2019-09-26  Tom Tromey  <tom@tromey.com>
2871
2872         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2873         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2874         * gdb_usleep.h: Remove.
2875         * gdb_usleep.c: Remove.
2876         * utils.c: Don't include gdb_usleep.h.
2877
2878 2019-09-26  Tom Tromey  <tromey@adacore.com>
2879
2880         * python/py-type.c (type_to_type_object): Call check_typedef
2881         for stub types.
2882
2883 2019-09-26  Tom Tromey  <tom@tromey.com>
2884
2885         * utils.h (initialize_utils): Don't declare.
2886         * top.c (gdb_init): Don't call initialize_utils.
2887         * utils.c (initialize_utils): Remove.  Move contents...
2888         (_initialize_utils): ... here.
2889
2890 2019-09-25  Tom Tromey  <tom@tromey.com>
2891
2892         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2893         * utils.h (make_hex_string): Don't declare.
2894         * utils.c (make_hex_string): Remove.
2895
2896 2019-09-24  Tom de Vries  <tdevries@suse.de>
2897
2898         PR gdb/23815
2899         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2900         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2901
2902 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2903
2904         * NEWS: Mention new simulator port for PRU.
2905
2906 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2907
2908         * ada-exp.y (write_object_remaining): Update.
2909         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2910         and eliminate the static buffer.
2911         (ada_decode_symbol): Update.
2912         (ada_la_decode): Update.
2913         (ada_sniff_from_mangled_name): Update.
2914         (is_valid_name_for_wild_match): Update.
2915         (ada_lookup_name_info::matches): Update and simplify.
2916         (name_matches_regex): Update.
2917         (ada_add_global_exceptions): Update.
2918         * ada-lang.h (ada_decode): Update signature.
2919         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2920         * dwarf-index-write.c (debug_names::insert): Update.
2921
2922 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2923
2924         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2925         formatting.
2926
2927 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2928
2929         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2930         Change "nonzero" to "true" in documentation.
2931
2932 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2933
2934         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2935         (_initialize_darwin_solib): Don't set
2936         darwin_so_ops.lookup_lib_global_symbol.
2937         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2938         set_gdbarch_iterate_over_objfiles_in_search_order.
2939         (elf_lookup_lib_symbol): Rename to...
2940         (svr4_iterate_over_objfiles_in_search_order): this, and update
2941         to iterate semantics.
2942         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2943         * solib.c (solib_global_lookup): Remove.
2944         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2945         (solib_global_lookup): Remove.
2946         * symtab.c (lookup_global_or_static_symbol): Remove call to
2947         solib_global_lookup.
2948
2949 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2950
2951         * NEWS: Move entries about default MI version now being
2952         version 3, and about the GDB/MI fix for multi-location
2953         breakpoints to the "since GDB 8.3" section.
2954
2955 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2956
2957         GDB 8.3.1 released.
2958
2959 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2960
2961         * NEWS: Mention that Cell/B.E. debugging support was removed.
2962         * MAINTAINERS: Remove spu target.
2963
2964         * config/djgpp/fnchange.lst: Remove entries for removed files.
2965
2966         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2967         spu-multiarch.o, and spu-tdep.o.
2968         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2969         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2970         spu-multiarch.c, and spu-tdep.c.
2971         * spu-linux-nat.c: Remove file.
2972         * spu-multiarch.c: Remove file.
2973         * spu-tdep.c: Remove file.
2974         * spu-tdep.h: Remove file.
2975         * solib-spu.c: Remove file.
2976         * solib-spu.h: Remove file.
2977
2978         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2979         * configure.nat (spu-linux): Remove.
2980         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2981         solib-multiarch.o from gdb_target_obs.
2982         (spu*-*-*): Remove.
2983
2984         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2985         feature flag.
2986         (ppc_linux_no_features): Update.
2987         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2988         Cell/B.E. support.
2989         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2990         (tdesc_powerpc_cell64l): Likewise.
2991         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2992         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2993         Cell/B.E. support.
2994         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2995         Do not include "features/rs6000/powerpc-cell32l.c" or
2996         "features/rs6000/powerpc-cell64l.c".
2997         (ppc_linux_spu_section): Remove.
2998         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2999         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3000         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3001         (ppc_linux_spe_context_lookup): Remove.
3002         (ppc_linux_spe_context_inferior_created): Remove.
3003         (ppc_linux_spe_context_solib_loaded): Remove.
3004         (ppc_linux_spe_context_solib_unloaded): Remove.
3005         (ppc_linux_spe_context): Remove.
3006         (struct ppu2spu_cache): Remove.
3007         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3008         (struct ppu2spu_data): Remove.
3009         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3010         ppu2spu_unwind): Remove.
3011         (ppc_linux_init_abi): Remove Cell/B.E. support.
3012         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3013
3014         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3015         (rs6000/powerpc-cell64l-expedite): Likewise
3016         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3017         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3018         rs6000/powerpc-cell64l.xml.
3019         * features/rs6000/powerpc-cell32l.xml: Remove.
3020         * features/rs6000/powerpc-cell64l.xml: Likewise.
3021         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3022         * features/rs6000/powerpc-cell64l.c: Likewise.
3023         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3024         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3025         * regformats/reg-spu.dat: Remove.
3026
3027         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3028         * corelow.c (struct spuid_list): Remove.
3029         (add_to_spuid_list): Remove.
3030         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3031         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3032         (remote_protocol_features): Remove associated entries.
3033         (_initialize_remote): No longer initialize them.
3034         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3035         * linux-nat.c (SPUFS_MAGIC): Remove.
3036         (linux_proc_xfer_spu): Remove.
3037         (spu_enumerate_spu_ids): Remove.
3038         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3039         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3040         (linux_make_corefile_notes): No longer call it.
3041
3042         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3043         (cooked_write_test): Likewise.
3044
3045 2019-09-20  Tom Tromey  <tom@tromey.com>
3046
3047         * NEWS: Mention case-sensitivity of TUI commands.
3048         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3049         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3050         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3051
3052 2019-09-20  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-source.c (tui_source_window::set_contents): Use
3055         make_unique_xstrdup.
3056         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3057         make_unique_xstrdup.
3058
3059 2019-09-20  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-data.c: Remove separator comments.
3062         * tui/tui-layout.c: Remove separator comments.
3063         * tui/tui-win.c: Remove separator comments.
3064         * tui/tui-wingeneral.c: Remove separator comments.
3065
3066 2019-09-20  Tom Tromey  <tom@tromey.com>
3067
3068         * tui/tui.h (strcat_to_buf): Don't declare.
3069         * tui/tui.c (strcat_to_buf): Remove.
3070
3071 2019-09-20  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3074         from "fullname".
3075         * tui/tui-source.c (tui_source_window::set_contents)
3076         (tui_source_window::location_matches_p)
3077         (tui_source_window::maybe_update): Update.
3078
3079 2019-09-20  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3082         Update.
3083         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3084         prefix.
3085         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3086         (tui_data_window::line_from_reg_element_no)
3087         (tui_data_window::first_reg_element_no_inline)
3088         (tui_data_window::show_registers)
3089         (tui_data_window::show_register_group)
3090         (tui_data_window::display_registers_from)
3091         (tui_data_window::display_registers_from_line)
3092         (tui_data_window::first_data_item_displayed)
3093         (tui_data_window::delete_data_content_windows)
3094         (tui_data_window::erase_data_content)
3095         (tui_data_window::do_scroll_vertical)
3096         (tui_data_window::refresh_window)
3097         (tui_data_window::check_register_values): Update.
3098
3099 2019-09-20  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3102         (struct tui_locator_window) <full_name, proc_name>: Now
3103         std::string.
3104         * tui/tui-stack.c (tui_locator_window::make_status_line)
3105         (tui_locator_window::set_locator_fullname)
3106         (tui_locator_window::set_locator_info): Update.
3107         * tui/tui-source.c (tui_source_window::set_contents)
3108         (tui_source_window::showing_source_p): Update.
3109
3110 2019-09-20  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3113         Don't call tui_locator_win_info_ptr.
3114
3115 2019-09-20  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3118
3119 2019-09-20  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3122         height for locator.
3123         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3124         * tui/tui-layout.c (show_source_disasm_command, show_data)
3125         (show_source_or_disasm_and_command): Use 1 as height for locator.
3126
3127 2019-09-20  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui.c (tui_enable): Update.
3130         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3131         Update.
3132         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3133         Update.
3134         * tui/tui-data.c (win_resized): Now bool.
3135         (tui_win_resized): Return bool.
3136         (tui_set_win_resized_to): Accept a bool.
3137
3138 2019-09-20  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3141         Change type of "refresh_values_only".
3142         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3143         type of "refresh_values_only".
3144
3145 2019-09-20  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3148         std::string.
3149         (tui_disassemble): Add "pos" parameter.
3150         (tui_disasm_window::set_contents): Simplify.
3151
3152 2019-09-20  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-winsource.h (struct tui_source_window_base)
3155         <show_source_content>: Now private.
3156         * tui/tui-winsource.c
3157         (tui_source_window_base::show_source_content): Don't handle empty
3158         content case.
3159
3160 2019-09-20  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-layout.c (show_source_disasm_command)
3163         (show_source_or_disasm_and_command): Don't call
3164         show_source_content.
3165
3166 2019-09-20  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3169         Declare.
3170         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3171         from tui_make_status_line.
3172         (tui_locator_window::rerender): Update.
3173
3174 2019-09-20  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3177         (tui_locator_window::rerender): Update.
3178
3179 2019-09-20  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-winsource.h (struct tui_source_window_base)
3182         <~tui_source_window_base>: Don't declare.
3183         <fullname>: Remove.
3184         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3185         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3186         member.
3187         * tui/tui-source.c (tui_source_window::set_contents): Update.
3188         (tui_source_window::location_matches_p)
3189         (tui_source_window::maybe_update): Update.
3190
3191 2019-09-20  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-winsource.h (~tui_source_element): Remove.
3194         (tui_source_element): Update.
3195         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3196         * tui/tui-winsource.c (tui_show_source_line): Update.
3197         * tui/tui-source.c (tui_source_window::set_contents): Update.
3198         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3199
3200 2019-09-20  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3203         declare.
3204         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3205         tui_clear_source_windows_detail.
3206         * tui/tui-winsource.h (struct tui_source_window_base)
3207         <clear_detail>: Don't declare.
3208         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3209         Remove.
3210         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3211
3212 2019-09-20  Tom Tromey  <tromey@adacore.com>
3213
3214         PR ada/24919:
3215         * block.c (contained_in): Fix final return value.
3216
3217 2019-09-20  Alan Modra  <amodra@gmail.com>
3218
3219         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3220         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3221         (read_indirect_string_from_dwz): Use bfd accessor.
3222         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3223         * machoread.c (macho_symfile_read_all_oso): Likewise.
3224         * solib.c (solib_bfd_open): Likewise.
3225
3226 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3227
3228         * eval.c: Move declaration of overload_resolution to...
3229         * value.h: ...here.
3230
3231 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3232
3233         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3234         * arm-linux-tdep.c: Likewise.
3235         * arm-nbsd-nat.c: Likewise.
3236         * arm-tdep.h: Declare arm_apcs_32.
3237         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3238
3239 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3240
3241         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3242         * dwarf2read.h: Declare dwarf_always_disassemble.
3243
3244 2019-09-19  Tom de Vries  <tdevries@suse.de>
3245
3246         PR gdb/25009
3247         * source-cache.c (source_cache::ensure): Catch exception thrown during
3248         construction of the highlighter.
3249
3250 2019-09-18  Alan Modra  <amodra@gmail.com>
3251
3252         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3253         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3254         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3255         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3256         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3257         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3258         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3259         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3260         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3261         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3262         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3263         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3264         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3265         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3266         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3267         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3268         * mi/mi-interp.c: Update throughout for bfd section macro and
3269         function changes.
3270         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3271         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3272
3273 2019-09-18  Tom Tromey  <tom@tromey.com>
3274
3275         * NEWS: Add entry.
3276         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3277         call rl_initialize.
3278         (tui_enable): Do not call rl_initialize.
3279
3280 2019-09-18  Christian Groessler  <chris@groessler.org>
3281
3282         * alpha-linux-nat.c: Include gdbarch.h.
3283
3284 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3285
3286         * ui-file.c: Include cli/cli-style.h.
3287         (term_cli_styling): Remove cli_styling declaration.
3288
3289 2019-09-18  Alan Modra  <amodra@gmail.com>
3290
3291         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3292         to bfd_asymbol_section.
3293
3294 2019-09-18  Alan Modra  <amodra@gmail.com>
3295
3296         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3297         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3298         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3299
3300 2019-09-18  Alan Modra  <amodra@gmail.com>
3301
3302         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3303         * spu-linux-nat.c (spu_bfd_open): Likewise.
3304
3305 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3306
3307         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3308         to bool to match definition in dwarf2read.c.
3309
3310 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3311
3312         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3313         (print_signatures): Likewise.
3314         (trust_pad_over_xvs): Likewise.
3315         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3316         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3317         * arm-linux-nat.c (arm_apcs_32): Likewise.
3318         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3319         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3320         * arm-tdep.c (arm_debug): Likewise.
3321         (arm_apcs_32): Likewise.
3322         * auto-load.c (debug_auto_load): Likewise.
3323         (auto_load_gdb_scripts): Likewise.
3324         (global_auto_load): Likewise.
3325         (auto_load_local_gdbinit): Likewise.
3326         (auto_load_local_gdbinit_loaded): Likewise.
3327         * auto-load.h (global_auto_load): Likewise.
3328         (auto_load_local_gdbinit): Likewise.
3329         (auto_load_local_gdbinit_loaded): Likewise.
3330         * breakpoint.c (disconnected_dprintf): Likewise.
3331         (breakpoint_proceeded): Likewise.
3332         (automatic_hardware_breakpoints): Likewise.
3333         (always_inserted_mode): Likewise.
3334         (target_exact_watchpoints): Likewise.
3335         (_initialize_breakpoint): Update.
3336         * breakpoint.h (target_exact_watchpoints): Change to bool.
3337         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3338         * cli/cli-cmds.c (trace_commands): Likewise.
3339         * cli/cli-cmds.h (trace_commands): Likewise.
3340         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3341         to bool*.
3342         * cli/cli-logging.c (logging_overwrite): Change to bool.
3343         (logging_redirect): Likewise.
3344         (debug_redirect): Likewise.
3345         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3346         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3347         to bool.
3348         <boolean_option_def>: Update.
3349         (struct flag_option_def): Change default type of Context to bool
3350         from int.
3351         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3352         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3353         (get_setshow_command_value_string): Likewise.
3354         * cli/cli-style.c (cli_styling): Change to bool.
3355         (source_styling): Likewise.
3356         * cli/cli-style.h (source_styling): Likewise.
3357         (cli_styling): Likewise.
3358         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3359         to bool.
3360         * command.h (var_types): Update comment.
3361         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3362         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3363         bool.
3364         (debug_compile_cplus_scopes): Likewise.
3365         * compile/compile-internal.h (compile_debug): Likewise.
3366         * compile/compile.c (compile_debug): Likewise.
3367         (struct compile_options) <raw>: Likewise.
3368         * cp-support.c (catch_demangler_crashes): Likewise.
3369         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3370         (usr_cmd_cris_dwarf2_cfi): Likewise.
3371         * csky-tdep.c (csky_debug): Likewise.
3372         * darwin-nat.c (enable_mach_exceptions): Likewise.
3373         * dcache.c (dcache_enabled_p): Likewise.
3374         * defs.h (info_verbose): Likewise.
3375         * demangle.c (demangle): Likewise.
3376         (asm_demangle): Likewise.
3377         * dwarf-index-cache.c (debug_index_cache): Likewise.
3378         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3379         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3380         * dwarf2read.c (check_physname): Likewise.
3381         (use_deprecated_index_sections): Likewise.
3382         (dwarf_always_disassemble): Likewise.
3383         * eval.c (overload_resolution): Likewise.
3384         * event-top.c (set_editing_cmd_var): Likewise.
3385         (exec_done_display_p): Likewise.
3386         * event-top.h (set_editing_cmd_var): Likewise.
3387         (exec_done_display_p): Likewise.
3388         * exec.c (write_files): Likewise.
3389         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3390         (debug_fbsd_nat): Likewise.
3391         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3392         Likewise.
3393         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3394         <backtrace_past_entry> Likewise.
3395         * gdb-demangle.h (demangle): Likewise.
3396         (asm_demangle): Likewise.
3397         * gdb_bfd.c (bfd_sharing): Likewise.
3398         * gdbcore.h (write_files): Likewise.
3399         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3400         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3401         * gdbthread.h (print_thread_events): Likewise.
3402         * gdbtypes.c (opaque_type_resolution): Likewise.
3403         (strict_type_checking): Likewise.
3404         * gnu-nat.c (gnu_debug_flag): Likewise.
3405         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3406         * guile/scm-param.c (pascm_variable): Add boolval.
3407         (add_setshow_generic): Update.
3408         (pascm_param_value): Update.
3409         (pascm_set_param_value_x): Update.
3410         * hppa-tdep.c (hppa_debug): Change to bool..
3411         * infcall.c (may_call_functions_p): Likewise.
3412         (coerce_float_to_double_p): Likewise.
3413         (unwind_on_signal_p): Likewise.
3414         (unwind_on_terminating_exception_p): Likewise.
3415         * infcmd.c (startup_with_shell): Likewise.
3416         * inferior.c (print_inferior_events): Likewise.
3417         * inferior.h (startup_with_shell): Likewise.
3418         (print_inferior_events): Likewise.
3419         * infrun.c (step_stop_if_no_debug): Likewise.
3420         (detach_fork): Likewise.
3421         (debug_displaced): Likewise.
3422         (disable_randomization): Likewise.
3423         (non_stop): Likewise.
3424         (non_stop_1): Likewise.
3425         (observer_mode): Likewise.
3426         (observer_mode_1): Likewise.
3427         (set_observer_mode): Update.
3428         (sched_multi): Change to bool.
3429         * infrun.h (debug_displaced): Likewise.
3430         (sched_multi): Likewise.
3431         (step_stop_if_no_debug): Likewise.
3432         (non_stop): Likewise.
3433         (disable_randomization): Likewise.
3434         * linux-tdep.c (use_coredump_filter): Likewise.
3435         (dump_excluded_mappings): Likewise.
3436         * linux-thread-db.c (auto_load_thread_db): Likewise.
3437         (check_thread_db_on_load): Likewise.
3438         * main.c (captured_main_1): Update.
3439         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3440         xx2_opt, boolean_opt>: Change to bool.
3441         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3442         * maint.c (maintenance_profile_p): Likewise.
3443         (per_command_time): Likewise.
3444         (per_command_space): Likewise.
3445         (per_command_symtab): Likewise.
3446         * memattr.c (inaccessible_by_default): Likewise.
3447         * mi/mi-main.c (mi_async): Likewise.
3448         (mi_async_1): Likewise.
3449         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3450         * nat/fork-inferior.h (startup_with_shell): Likewise.
3451         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3452         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3453         * nios2-tdep.c (nios2_debug): Likewise.
3454         * or1k-tdep.c (or1k_debug): Likewise.
3455         * parse.c (parser_debug): Likewise.
3456         * parser-defs.h (parser_debug): Likewise.
3457         * printcmd.c (print_symbol_filename): Likewise.
3458         * proc-api.c (procfs_trace): Likewise.
3459         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3460         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3461         (set_parameter_value): Update.
3462         (add_setshow_generic): Update.
3463         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3464         to bool*.
3465         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3466         int*.
3467         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3468         * record-btrace.c (record_btrace_target::store_registers): Update.
3469         * record-full.c (record_full_memory_query): Change to bool.
3470         (record_full_stop_at_limit): Likewise.
3471         * record-full.h (record_full_memory_query): Likewise.
3472         * remote-notif.c (notif_debug): Likewise.
3473         * remote-notif.h (notif_debug): Likewise.
3474         * remote.c (use_range_stepping): Likewise.
3475         (interrupt_on_connect): Likewise.
3476         (remote_break): Likewise.
3477         * ser-tcp.c (tcp_auto_retry): Likewise.
3478         * ser-unix.c (serial_hwflow): Likewise.
3479         * skip.c (debug_skip): Likewise.
3480         * solib-aix.c (solib_aix_debug): Likewise.
3481         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3482         (spu_auto_flush_cache_p): Likewise.
3483         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3484         Likewise.
3485         (struct info_print_options) <quiet>: Likewise.
3486         * symfile-debug.c (debug_symfile): Likewise.
3487         * symfile.c (auto_solib_add): Likewise.
3488         (separate_debug_file_debug): Likewise.
3489         * symfile.h (auto_solib_add): Likewise.
3490         (separate_debug_file_debug): Likewise.
3491         * symtab.c (basenames_may_differ): Likewise.
3492         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3493         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3494         (struct info_types_options) <quiet>: Likewise.
3495         * symtab.h (demangle): Likewise.
3496         (basenames_may_differ): Likewise.
3497         * target-dcache.c (stack_cache_enabled_1): Likewise.
3498         (code_cache_enabled_1): Likewise.
3499         * target.c (trust_readonly): Likewise.
3500         (may_write_registers): Likewise.
3501         (may_write_memory): Likewise.
3502         (may_insert_breakpoints): Likewise.
3503         (may_insert_tracepoints): Likewise.
3504         (may_insert_fast_tracepoints): Likewise.
3505         (may_stop): Likewise.
3506         (auto_connect_native_target): Likewise.
3507         (target_stop_and_wait): Update.
3508         (target_async_permitted): Change to bool.
3509         (target_async_permitted_1): Likewise.
3510         (may_write_registers_1): Likewise.
3511         (may_write_memory_1): Likewise.
3512         (may_insert_breakpoints_1): Likewise.
3513         (may_insert_tracepoints_1): Likewise.
3514         (may_insert_fast_tracepoints_1): Likewise.
3515         (may_stop_1): Likewise.
3516         * target.h (target_async_permitted): Likewise.
3517         (may_write_registers): Likewise.
3518         (may_write_memory): Likewise.
3519         (may_insert_breakpoints): Likewise.
3520         (may_insert_tracepoints): Likewise.
3521         (may_insert_fast_tracepoints): Likewise.
3522         (may_stop): Likewise.
3523         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3524         (make_thread_apply_all_options_def_group): Change argument from int*
3525         to bool*.
3526         (thread_apply_all_command): Update.
3527         (print_thread_events): Change to bool.
3528         * top.c (confirm): Likewise.
3529         (command_editing_p): Likewise.
3530         (history_expansion_p): Likewise.
3531         (write_history_p): Likewise.
3532         (info_verbose): Likewise.
3533         * top.h (confirm): Likewise.
3534         (history_expansion_p): Likewise.
3535         * tracepoint.c (disconnected_tracing): Likewise.
3536         (circular_trace_buffer): Likewise.
3537         * typeprint.c (print_methods): Likewise.
3538         (print_typedefs): Likewise.
3539         * utils.c (debug_timestamp): Likewise.
3540         (sevenbit_strings): Likewise.
3541         (pagination_enabled): Likewise.
3542         * utils.h (sevenbit_strings): Likewise.
3543         (pagination_enabled): Likewise.
3544         * valops.c (overload_resolution): Likewise.
3545         * valprint.h (struct value_print_options) <prettyformat_arrays,
3546         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3547         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3548         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3549         Likewise.
3550         * windows-nat.c (new_console): Likewise.
3551         (cygwin_exceptions): Likewise.
3552         (new_group): Likewise.
3553         (debug_exec): Likewise.
3554         (debug_events): Likewise.
3555         (debug_memory): Likewise.
3556         (debug_exceptions): Likewise.
3557         (useshell): Likewise.
3558         * windows-tdep.c (maint_display_all_tib): Likewise.
3559         * xml-support.c (debug_xml): Likewise.
3560
3561 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3562
3563         * source.c (prepare_path_for_appending): New function.
3564         (openp): Make use of new function.
3565         (find_and_open_source): Search for the compilation directory and
3566         source file as a relative path beneath the directory search path.
3567
3568 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * source-cache.c (source_cache::get_line_charpos): Catch
3571         exceptions and return false, this matches the behaviour documented
3572         in the header file.
3573
3574 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3575
3576         * ada-tasks.c (info_task): Remove quoting of the task's name.
3577
3578 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3579
3580         * symfile.c (auto_solib_add): Replace comment with a reference
3581         to the header file.
3582
3583 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3584
3585         * NEWS: Mention that gdb can now be compiled with Python 3
3586         on Windows.
3587
3588 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * maint.c (maint_print_section_data::maint_print_section_data):
3591         Force use of 'float log10 (float)' by casting the argument to
3592         float.
3593
3594 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         * maint.c: Add 'cmath' include.
3597         (struct maint_print_section_data): New structure.
3598         (print_section_index): New function.
3599         (print_bfd_section_info): Add header comment, small whitespace
3600         cleanup, and update to call new print_section_index function.
3601         (print_objfile_section_info): Likewise.
3602         (maint_obj_section_from_bfd_section): New function.
3603         (print_bfd_section_info_maybe_relocated): New function.
3604         (maintenance_info_sections): Add header comment, always use
3605         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3606
3607 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3608
3609         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3610         inner scope, add check that the objfile has psymtabs before
3611         checking psymtabs_addrmap.
3612         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3613
3614 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3615
3616         * NEWS: Announce that Ada task names are now shown at more places,
3617         and between quotes (except in info task output).
3618         * gdb/ada-tasks.c (task_to_str): New function.
3619         (display_current_task_id): Call task_to_str.
3620         (task_command_1): Likewise.
3621         (print_ada_task_info): In non-mi mode, Properly align headers and data
3622         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3623
3624 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3625
3626         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3627         prstatus.pr_lwp.pr_info instead of making it up.
3628
3629 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3630
3631         * auto-load.c (auto_load_expand_dir_vars): Update.
3632         * defs.h (gdb_datadir): Change to std::string.
3633         (python_libdir): Likewise.
3634         (relocate_gdb_directory): Change return type to std::string.
3635         * guile/guile.c (gdbscm_data_directory): Update.
3636         (initialize_scheme_side): Update.
3637         * jit.c (jit_reader_dir): Change to std::string.
3638         (jit_reader_load_command): Update.
3639         * main.c (gdb_datadir): Change to std::string.
3640         (python_libdir): Likewise.
3641         (set_gdb_data_directory): Update.
3642         (relocate_path): Change to return std::string.
3643         (relocate_gdb_directory): Change to return std::string.
3644         (relocate_gdbinit_path_maybe_in_datadir): Update.
3645         (captured_main_1): Update.
3646         * python/python.c (do_start_initialization): Update.
3647         * top.c (show_gdb_datadir): Update.
3648         * xml-syscall.c (xml_init_syscalls_info): Update.
3649         (init_syscalls_info): Update.
3650
3651 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3652
3653         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3654         out of get_init_files.
3655         (get_init_files): Update.
3656
3657 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3658
3659         * main.c (get_init_files): Change to use std::string.
3660         (captured_main_1): Update.
3661         (print_gdb_help): Update.
3662
3663 2019-09-11  Ali Tamur  <tamur@google.com>
3664
3665         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3666         implementation.
3667
3668 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3669
3670         * dbxread.c (read_dbx_symtab): Update.
3671         * dwarf2read.c (load_partial_dies): Update.
3672         * mdebugread.c (parse_partial_symbols): Update.
3673         (handle_psymbol_enumerators): Update.
3674         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3675         * psymtab.c (add_psymbol_to_bcache): Likewise.
3676         (add_psymbol_to_list): Likewise.
3677         * symtab.c (symbol_set_names): Likewise.
3678         * symtab.h (symbol_set_names): Likewise.
3679         * xcoffread.c (scan_xcoff_symtab): Update.
3680
3681 2019-09-11  Tom Tromey  <tom@tromey.com>
3682
3683         * symfile-mem.c (symbol_file_add_from_memory): Use
3684         bfd_set_filename.
3685         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3686         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3687
3688 2019-09-10  Tom Tromey  <tromey@adacore.com>
3689
3690         * dwarf-index-write.c (write_psymbols): Extend error message.
3691         (debug_names::insert): Add Ada code.
3692         (debug_names::write_psymbols): Remove Ada check.
3693         (debug_names) <m_string_obstack>: New member.
3694         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3695         (gdb_index_symbol_name_matcher::matches): Remove.
3696         (mapped_index_base::find_name_components_bounds): Add "lang"
3697         parameter.
3698         (mapped_index_base::build_name_components): Also split names
3699         according to Ada syntax.
3700         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3701         type of "match_callback".
3702         (check_match, check_find_bounds_finds)
3703         (dw2_expand_symtabs_matching): Update.
3704         (dw2_debug_names_iterator): Add new constructor.
3705         (dw2_debug_names_map_matching_symbols): New function.
3706         (dw2_debug_names_expand_symtabs_matching): Update.
3707         (dwarf2_debug_names_functions): Use
3708         dw2_debug_names_map_matching_symbols.
3709
3710 2019-09-10  Tom Tromey  <tromey@adacore.com>
3711
3712         * dwarf2read.c (dw2_get_file_names_reader): Add the
3713         CU's file name to the results.
3714
3715 2019-09-10  Tom Tromey  <tromey@adacore.com>
3716
3717         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3718         map_matching_symbols.  Update.
3719         * dwarf2read.c (dw2_map_matching_symbols): Update.
3720         * psymtab.c (match_partial_symbol): Change type; update.
3721         (psym_map_matching_symbols): Likewise.
3722         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3723         type; update.
3724         * symfile.h (struct quick_symbol_functions)
3725         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3726         Remove "match".
3727
3728 2019-09-10  Tom Tromey  <tromey@adacore.com>
3729
3730         * psymtab.c (map_block): Remove.
3731         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3732         * symtab.c (iterate_over_symbols_terminated): New function.
3733         * symtab.c (iterate_over_symbols_terminated): Declare.
3734
3735 2019-09-10  Tom Tromey  <tromey@adacore.com>
3736
3737         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3738         * language.h (struct language_defn) <la_iterate_over_symbols>:
3739         Return bool.
3740         * symtab.c (iterate_over_symbols): Return bool.
3741         * symtab.h (iterate_over_symbols): Return bool.
3742
3743 2019-09-10  Tom Tromey  <tromey@adacore.com>
3744
3745         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3746         (add_nonlocal_symbols): Update.
3747         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3748         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3749         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3750         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3751         Change type of "callback".  Remove "data".
3752
3753
3754 2019-09-09  Ali Tamur  <tamur@google.com>
3755
3756         * dwarf2read.c (comp_unit_head): Update comment.
3757         (dwarf2_dwo_name): New function declaration.
3758         (dwarf_unit_type_name): New function declaration.
3759         (read_comp_unit_head): Add support for new compilation units,
3760         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3761         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3762         (currently named as "signature") in their header. Also clarify error
3763         messages.
3764         (lookup_dwo_id): New function. Returns the dwo id of the given
3765         compile unit.
3766         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3767         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3768         functions.
3769         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3770         (dwarf2_dwo_name): Get the dwo name if present.
3771         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3772         purposes.
3773
3774 2019-09-09  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3777
3778 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3779
3780         * python/python.c (do_start_initialization): Make progname_copy static,
3781         to avoid a leak report.
3782
3783 2019-09-08  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3786
3787 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3788
3789         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3790         Change type to gdb::optional<block_enum>.
3791         (dw2_symtab_iter_init): Change block_index parameter type
3792         to gdb::optional<block_enum>.
3793         (dw2_lookup_symbol): Change block_index parameter
3794         type to block_enum.c
3795         (dw2_debug_names_lookup_symbol): Likewise.
3796         * psymtab.c (psym_lookup_symbol): Likewise.
3797         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3798         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3799         Likewise.
3800
3801 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3802
3803         * defs.h (relocate_gdb_directory): Change int to bool in
3804         signature and rename flag to relocatable.
3805         * main.c (relocate_path): Likewise.
3806         (relocate_gdb_directory): Likewise.
3807
3808 2019-09-06  Alan Modra  <amodra@gmail.com>
3809
3810         * coffread.c (coff_symfile_read): Constify filename variable.
3811         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3812         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3813         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3814         * solib.c (reload_shared_libraries_1): Likewise.
3815         * symfile.c (reread_symbols): Likewise.
3816         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3817         * solib-darwin.c (darwin_bfd_open): Likewise.
3818         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3819
3820 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3821
3822         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3823         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3824
3825 2019-09-03  Tom Tromey  <tromey@adacore.com>
3826
3827         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3828         types.
3829         (has_negatives): Unbias a range type bound.
3830         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3831         * gdbtypes.c (operator==): Handle new field.
3832         (create_range_type): Add "bias" parameter.
3833         (create_static_range_type, resolve_dynamic_range): Update.
3834         * gdbtypes.h (struct range_bounds) <bias>: New member.
3835         (create_range_type): Add bias parameter.
3836         * printcmd.c (print_scalar_formatted): Unbias range types.
3837         * value.c (unpack_long): Unbias range types.
3838         (pack_long): Bias range types.
3839
3840 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3841
3842         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3843         probe arguments.
3844
3845 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3846
3847         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3848         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3849         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3850         (compile_probe_arg): Likewise.
3851         * probe.h (get_argument_count): Likewise.
3852         * solib-svr4.c (solib_event_probe_action): Likewise.
3853         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3854
3855 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3856
3857         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3858         code to here...
3859         (svr4_create_solib_event_breakpoints): ...from here.
3860
3861 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3862
3863         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3864         suffix from warning message.
3865
3866 2019-08-30  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-winsource.h (struct tui_source_window_base)
3869         <refresh_all>: Don't declare.
3870         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3871         Remove.
3872         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3873         tui_show_locator_content.
3874         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3875         declare.
3876         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3877         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3878         declare.
3879
3880 2019-08-30  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3883
3884 2019-08-30  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3887         Remove unnecessary forward declarations.
3888
3889 2019-08-30  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3892         rerender.
3893         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3894         tui_show_locator_content.
3895
3896 2019-08-30  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3899         (tui_locator_window::rerender): Rewrite using body of previous
3900         tui_show_locator_content.
3901
3902 2019-08-30  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3905         set_locator_fullname>: New methods.
3906         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3907         Rename from tui_set_locator_fullname.
3908         (tui_locator_window::set_locator_info): Rename from
3909         tui_set_locator_info.  Return bool.
3910         (tui_update_locator_fullname, tui_show_frame_info): Update.
3911
3912 2019-08-30  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3915
3916 2019-08-30  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3919         call touchwin.
3920
3921 2019-08-30  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-wingeneral.c (box_win): Assume win_info and
3924         win_info->handle cannot be NULL.
3925
3926 2019-08-30  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3929         refresh_window>: Declare.
3930         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3931         resize.
3932         (tui_data_item_window::rerender): Rename from
3933         tui_display_register.
3934         (tui_data_item_window::refresh_window): New method.
3935         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3936         no-op.
3937
3938 2019-08-30  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3941         regs_column_count, current_group>: Move later.  Now private.
3942         <get_current_group>: New method.
3943         * tui/tui-regs.c (tui_reg_command): Update.
3944         * tui/tui-layout.c (tui_set_layout): Update.
3945
3946 2019-08-30  Tom Tromey  <tom@tromey.com>
3947
3948         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3949         (tui_data_window::rerender): Don't call
3950         check_and_display_highlight_if_needed.
3951         (tui_data_window::refresh_all): Remove call to
3952         erase_data_content.
3953
3954 2019-08-30  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3957         (tui_data_window::display_registers_from)
3958         (tui_data_window::display_reg_element_at_line)
3959         (tui_data_window::display_registers_from_line): Remove checks of
3960         "empty".
3961
3962 2019-08-30  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3965         Don't declare.
3966         * tui/tui-regs.c (tui_data_window::show_registers): Call
3967         rerender.
3968         (tui_data_window::rerender): Rename from display_all_data.
3969         (tui_data_window::rerender): Remove old implementation.
3970
3971 2019-08-30  Tom Tromey  <tom@tromey.com>
3972
3973         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3974         text.
3975         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3976
3977 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3978             Sergio Durigan Junior  <sergiodj@redhat.com>
3979
3980         PR win32/24284
3981         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3982
3983 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3986         when searching for types.
3987
3988 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * f-lang.c (f_language_defn): Use f_print_typedef.
3991         * f-lang.h (f_print_typedef): Declare.
3992         * f-typeprint.c (f_print_typedef): Define.
3993
3994 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3995
3996         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3997
3998 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3999
4000         * cli/cli-utils.c (info_print_options_defs): Delete.
4001         (make_info_print_options_def_group): Delete.
4002         (extract_info_print_options): Delete.
4003         (info_print_command_completer): Delete.
4004         (info_print_args_help): Add extra parameter, and optionally
4005         include text about -n flag.
4006         * cli/cli-utils.h (struct info_print_options): Delete.
4007         (extract_info_print_options): Delete declaration.
4008         (info_print_command_completer): Delete declaration.
4009         (info_print_args_help): Add extra parameter, extend header
4010         comment.
4011         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4012         search_symbols.
4013         * stack.c (struct info_print_options): New type.
4014         (info_print_options_defs): New file scoped variable.
4015         (make_info_print_options_def_group): New static function.
4016         (info_print_command_completer): New static function.
4017         (info_locals_command): Update to use new local functions.
4018         (info_args_command): Likewise.
4019         (_initialize_stack): Add extra parameter to calls to
4020         info_print_args_help.
4021         * symtab.c (search_symbols): Add extra parameter, use this to
4022         possibly excluse non-debug symbols.
4023         (symtab_symbol_info): Add extra parameter, which is passed on to
4024         search_symbols.
4025         (struct info_print_options): New type.
4026         (info_print_options_defs): New file scoped variable.
4027         (make_info_print_options_def_group): New static function.
4028         (info_print_command_completer): New static function.
4029         (info_variables_command): Update to use local functions, and pass
4030         extra parameter through to symtab_symbol_info.
4031         (info_functions_command): Likewise.
4032         (info_types_command): Pass additional argument through to
4033         symtab_symbol_info.
4034         (rbreak_command): Pass extra argument to search_symbols.
4035         (_initialize_symtab): Add extra arguments for calls to
4036         info_print_args_help, and update help text for 'info variables',
4037         'whereis', and 'info functions' commands.
4038         * symtab.h (search_symbols): Add extra argument to declaration.
4039         * NEWS: Mention new flags.
4040
4041 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4042
4043         * symtab.c (lookup_static_symbol): Call the new function (and move
4044         it down to be next to lookup_global_symbol).
4045         (struct global_sym_lookup_data): Add block_enum member and rename to...
4046         (struct global_or_static_sym_lookup_data): ...this.
4047         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4048         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4049         (lookup_symbol_global_or_static_iterator_cb): ...this.
4050         (lookup_global_or_static_symbol): New function.
4051         (lookup_global_symbol): Call new function.
4052
4053 2019-08-26  Tom de Vries  <tdevries@suse.de>
4054
4055         PR c++/24852
4056         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4057         when pc_probe.prob == NULL.
4058
4059 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4060
4061         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4062         variable symbol_linkage to symbol_linkage_.
4063
4064 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4065
4066         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4067         represent whether the symbol is static, dynamic, or we don't
4068         know.
4069
4070 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4071
4072         * gdb/rx-tdep.c (rx_register_names): New.
4073         (rx_register_name): Delete.
4074         (rx_psw_type): Delete.
4075         (rx_fpsw_type): Delete.
4076         (rx_register_type): Delete.
4077         (rx_gdbarch_init): Convert target-descriptions.
4078         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4079         * gdb/features/Makefile: Add rx.xml.
4080         * gdb/features/rx.xml: New.
4081         * gdb/features/rx.c: Generated.
4082         * gdb/NEWS: Mention target description support.
4083
4084 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4085
4086         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4087         *slot_ptr.
4088
4089 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4090
4091         * configure.ac: Don't check for 'dlfcn.h' (moved to
4092         gdbsupport/common.m4).
4093         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4094         'gdbsupport/'.
4095         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4096         * compile/compile-c-support.c: Include
4097         'gdbsupport/gdb-dlfcn.h'.
4098         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4099         * gdb-dlfcn.c: Move to...
4100         * gdbsupport/gdb-dlfcn.c: ... here.
4101         * gdb-dlfcn.h: Move to...
4102         * gdbsupport/gdb-dlfcn.h: ... here.
4103
4104 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4105
4106         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4107         the offset field signed.
4108
4109 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4110
4111         * python/lib/gdb/__init__.py (_execute_file): New function.
4112         * python/python.c (python_run_simple_file): Call gdb._execute_file
4113         on Windows.
4114
4115 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4118         all uses as this was never set to anything but a zero value.
4119
4120 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4121
4122         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4123
4124 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4125
4126         * tui/tui-data.h (tui_gen_win_info): Add an =default
4127         move constructor, required by some GCC versions.
4128
4129 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4130
4131         * go32-nat.c (go32_sysinfo): Add hygon_p.
4132
4133 2019-08-20  Tom Tromey  <tom@tromey.com>
4134
4135         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4136         line_from_reg_element_no, first_reg_element_no_inline,
4137         display_all_data, delete_data_content_windows,
4138         erase_data_content>: Now private.
4139
4140 2019-08-20  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4143         (tui_unhighlight_win, tui_highlight_win)
4144         (tui_win_info::make_window): Update.
4145         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4146
4147 2019-08-20  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4150         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4151         (MAX_PID_WIDTH): Move to tui-stack.c.
4152         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4153         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4154         (MAX_PID_WIDTH): Move from tui-data.h.
4155
4156 2019-08-20  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4159         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4160         (box_win): Update.
4161         (tui_gen_win_info::make_window): Rename from tui_make_window.
4162         (tui_win_info::make_window): New method.
4163         (tui_gen_win_info::make_visible): Update.
4164         * tui/tui-source.c (tui_source_window::set_contents): Update.
4165         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4166         (tui_data_window::display_registers_from): Update.
4167         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4168         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4169         Declare.
4170         <can_box>: Remove.
4171         <title>: Remove.
4172         (struct tui_win_info) <make_window>: Declare.
4173         <can_box>: Now virtual.
4174         <title>: New member.
4175         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4176         * tui/tui-command.c (tui_cmd_window::resize): Update.
4177
4178 2019-08-20  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4181         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4182         (tui_data_window::check_register_values): Update.
4183
4184 2019-08-20  Tom Tromey  <tom@tromey.com>
4185
4186         * tui/tui-regs.h (struct tui_data_window): Use
4187         DISABLE_COPY_AND_ASSIGN.
4188         <regs_content>: Change type, removing unique_ptr.
4189         <tui_data_window>: Add move constructor.
4190         * tui/tui-regs.c (tui_data_window::show_registers)
4191         (tui_data_window::show_register_group)
4192         (tui_data_window::display_registers_from)
4193         (tui_data_window::display_registers_from)
4194         (tui_data_window::first_data_item_displayed)
4195         (tui_data_window::delete_data_content_windows)
4196         (tui_data_window::rerender, tui_data_window::refresh_window)
4197         (tui_data_window::check_register_values): Update.
4198
4199 2019-08-20  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4202         show_register_group>: Declare.
4203         (tui_show_register_group): Don't declare.
4204         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4205         tui_show_registers.
4206         (tui_data_window::show_register_group): Rename from
4207         tui_show_register_group.
4208         (tui_data_window::check_register_values, tui_reg_command):
4209         Update.
4210         * tui/tui-layout.c (tui_set_layout): Update.
4211
4212 2019-08-20  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4215         Declare.
4216         (tui_check_register_values): Don't declare.
4217         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4218         from tui_check_register_values.
4219         * tui/tui-hooks.c (tui_register_changed): Update.
4220
4221 2019-08-20  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-regs.c (tui_reg_layout): Move later.
4224         (tui_show_registers): Don't enable TUI mode or change layout.
4225
4226 2019-08-20  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-regs.h (struct tui_data_item_window)
4229         <~tui_data_item_window>: Remove.
4230         <content>: Now a unique_xmalloc_ptr.
4231         * tui/tui-regs.c (tui_register_format): Return a
4232         unique_xmalloc_ptr.
4233         (tui_get_register): Update.
4234         (~tui_data_item_window): Remove.
4235         (tui_data_window::display_registers_from, tui_display_register):
4236         Update.
4237         * tui/tui-io.h (tui_expand_tabs): Update.
4238         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4239         Remove "col" parameter.
4240
4241 2019-08-20  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4244         field.
4245         * tui/tui-regs.c (~tui_data_item_window): Update.
4246
4247 2019-08-20  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4250         earlier.
4251
4252 2019-08-20  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4255
4256 2019-08-20  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-source.h (struct tui_source_window): Update.
4259         * tui/tui-regs.c (tui_show_registers): Update.
4260         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4261         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4262         (NO_REGS_STRING): Remove defines.
4263
4264 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4265
4266         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4267         unnecessary thread walk if remote doesn't support the packet.
4268
4269 2019-08-19  Tom Tromey  <tromey@adacore.com>
4270
4271         * python/py-value.c (value_has_field): Fix indentation.
4272
4273 2019-08-19  Tom Tromey  <tromey@adacore.com>
4274
4275         * printcmd.c (do_one_display, info_display_command): Update.
4276         * block.h (contained_in): Return bool.  Add allow_nested
4277         parameter.
4278         * block.c (contained_in): Return bool.  Add allow_nested
4279         parameter.
4280
4281 2019-08-19  Tom Tromey  <tom@tromey.com>
4282
4283         * configure: Rebuild.
4284         * configure.ac: Disallow the combination of -static-libstdc++ and
4285         source highlight.
4286         * source-cache.c (get_language_name): Handle rust.
4287         (source_cache::get_source_lines): Ignore highlighting exceptions.
4288
4289 2019-08-16  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4292         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4293         (struct tui_source_window_base) <make_visible, refresh_window,
4294         resize>: Remove methods.
4295         <execution_info>: Remove field.
4296         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4297         (tui_show_source_line, tui_source_window_base)
4298         (~tui_source_window_base): Update.
4299         (tui_source_window_base::resize)
4300         (tui_source_window_base::make_visible)
4301         (tui_source_window_base::refresh_window): Remove.
4302         (tui_source_window_base::update_exec_info): Update.
4303         * tui/tui-source.c (tui_source_window::set_contents): Update.
4304         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4305
4306 2019-08-16  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4309         deprecated_query_hook.
4310
4311 2019-08-16  Tom Tromey  <tom@tromey.com>
4312
4313         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4314         (tui_update_source_windows_with_line): Update.
4315         * tui/tui-source.h (struct tui_source_window)
4316         <show_symtab_source>: Declare.
4317         (tui_show_symtab_source): Don't declare.
4318         * tui/tui-source.c (tui_show_symtab_source): Rename from
4319         tui_show_symtab_source.
4320
4321 2019-08-16  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-winsource.h (struct tui_source_window_base)
4324         <set_contents>: Declare.
4325         * tui/tui-winsource.c
4326         (tui_source_window_base::update_source_window_as_is): Update.
4327         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4328         Declare.
4329         (tui_set_source_content): Don't declare.
4330         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4331         tui_set_source_content.
4332         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4333         Declare.
4334         (tui_set_disassem_content): Don't declare.
4335         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4336         tui_set_disassem_content.
4337
4338 2019-08-16  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-winsource.h (struct tui_source_window_base)
4341         <update_breakpoint_info>: Declare.
4342         (tui_update_breakpoint_info): Don't declare.
4343         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4344         (tui_update_all_breakpoint_info): Update.
4345         (tui_source_window_base::update_breakpoint_info): Rename from
4346         tui_update_breakpoint_info.
4347         (tui_source_window_base::update_exec_info): Update.
4348
4349 2019-08-16  Tom Tromey  <tom@tromey.com>
4350
4351         * tui/tui-winsource.h (struct tui_source_window_base)
4352         <update_source_window>: Declare.
4353         (tui_update_source_window): Don't declare.
4354         * tui/tui-winsource.c
4355         (tui_source_window_base::update_source_window): Rename from
4356         tui_update_source_window.
4357         (tui_source_window_base::rerender): Update.
4358         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4359         * tui/tui-disasm.c (tui_show_disassem)
4360         (tui_show_disassem_and_update_source)
4361         (tui_disasm_window::maybe_update): Update.
4362
4363 2019-08-16  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-winsource.h (struct tui_source_window_base)
4366         <update_source_window_as_is>: Declare.
4367         (tui_update_source_window_as_is): Don't declare.
4368         * tui/tui-winsource.c (tui_update_source_window): Update
4369         (tui_source_window_base::update_source_window_as_is): Rename from
4370         tui_update_source_window_as_is.
4371         (tui_source_window_base::refill): Update.
4372         * tui/tui-source.c (tui_show_symtab_source): Update.
4373         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4374         Update.
4375
4376 2019-08-16  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui-winsource.h (tui_update_source_window)
4379         (tui_update_source_window_as_is): Remove "noerror" parameter.
4380         * tui/tui-winsource.c (tui_update_source_window)
4381         (tui_update_source_window_as_is): Remove "noerror" parameter.
4382         (tui_update_source_windows_with_addr)
4383         (tui_update_source_windows_with_line)
4384         (tui_source_window_base::rerender)
4385         (tui_source_window_base::refill): Update.
4386         * tui/tui-source.h (tui_set_source_content)
4387         (tui_show_symtab_source): Remove "noerror" parameter.
4388         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4389         parameter.
4390         (tui_show_symtab_source): Likewise.
4391         (tui_source_window::maybe_update): Update.
4392         * tui/tui-disasm.c (tui_show_disassem)
4393         (tui_show_disassem_and_update_source)
4394         (tui_disasm_window::do_scroll_vertical)
4395         (tui_disasm_window::maybe_update): Update.
4396
4397 2019-08-16  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui.c (tui_is_window_visible): Update.
4400         * tui/tui-wingeneral.c (tui_make_window)
4401         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4402         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4403         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4404         (tui_set_win_height_command, parse_scrolling_args): Update.
4405         * tui/tui-source.c (tui_source_window::style_changed): Update.
4406         * tui/tui-regs.c (tui_show_registers)
4407         (tui_data_window::first_data_item_displayed)
4408         (tui_data_window::delete_data_content_windows)
4409         (tui_check_register_values, tui_reg_command): Update.
4410         * tui/tui-disasm.c (tui_show_disassem): Update.
4411         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4412         method.
4413         <is_visible>: Remove field.
4414         * tui/tui-data.c (tui_next_win, tui_prev_win)
4415         (tui_delete_invisible_windows): Update.
4416
4417 2019-08-16  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-winsource.h (struct tui_source_window_base)
4420         <m_has_locator>: Remove.
4421         * tui/tui-layout.c (show_source_disasm_command, show_data)
4422         (show_source_or_disasm_and_command): Update.
4423
4424 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4425
4426         * NEWS (Other MI changes): New subsection.
4427         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4428         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4429         * arch-utils.c (default_get_pc_address_flags): New function.
4430         * arch-utils.h (default_get_pc_address_flags): New declaration.
4431         * gdbarch.sh: Add get_pc_address_flags.
4432         * gdbarch.c: Regenerate.
4433         * gdbarch.h: Likewise.
4434         * stack.c (print_pc): New function.
4435         (print_frame_info) (print_frame): Call print_pc.
4436
4437 2019-08-16  Tom de Vries  <tdevries@suse.de>
4438
4439         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4440         print_objfile_section_info.
4441
4442 2019-08-15  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4445         calling update_cmdwin_start_line.
4446         * tui/tui-winsource.h (struct tui_source_window_base)
4447         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4448         <rerender>: Declare.
4449         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4450         Call rerender.
4451         (tui_source_window_base::set_new_height): Remove.
4452         (tui_source_window_base::rerender): Rename from
4453         do_make_visible_with_new_height.
4454         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4455         resize method.
4456         (tui_win_info::make_invisible_and_set_new_height)
4457         (tui_win_info::make_visible_with_new_height): Remove.
4458         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4459         Declare.
4460         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4461         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4462         do_make_visible_with_new_height>: Don't declare.
4463         <rerender>: Declare.
4464         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4465         set_new_height.
4466         (tui_data_window::do_make_visible_with_new_height): Remove.
4467         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4468         call tui_show_locator_content.
4469         (tui_gen_win_info::resize): Call rerender.
4470         (show_source_or_disasm_and_command): Don't call
4471         tui_show_locator_content.
4472         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4473         method.
4474         (struct tui_win_info) <rerender>: Declare.
4475         <set_new_height, make_invisible_and_set_new_height,
4476         make_visible_with_new_height>: Don't declare.
4477         * tui/tui-data.c (tui_win_list::rerender): New method.
4478         * tui/tui-command.h (struct tui_cmd_window)
4479         <do_make_visible_with_new_height>: Don't declare.
4480         * tui/tui-command.c
4481         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4482
4483 2019-08-15  Tom Tromey  <tromey@adacore.com>
4484
4485         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4486         * ada-lang.c (ada_enum_name): Likewise.
4487
4488 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4489
4490         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4491         leading underscore.
4492         (GdbOutputErrorFile): Likewise.
4493         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4494         accordingly.
4495         (execute_unwinders): Rename to have a leading underscore.
4496         (auto_load_packages): Likewise.
4497         (global scope): Adjust call to auto_load_packages accordingly.
4498         (GdbSetPythonDirectory): Likewise.
4499         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4500         instead of execute_unwinders.
4501
4502 2019-08-15  Tom Tromey  <tom@tromey.com>
4503
4504         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4505         (show_data): Don't change window visibility.
4506         (tui_gen_win_info::resize): Remove special case for command
4507         window.  Use wresize, when available.
4508         (show_source_or_disasm_and_command): Don't change window
4509         visibility.
4510         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4511         <make_visible>: New method.
4512         * tui/tui-command.c (tui_cmd_window::resize): New method.
4513
4514 2019-08-15  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4517         (struct tui_source_windows): New.
4518         * tui/tui-winsource.c (tui_display_main): Update.
4519         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4520         (new_height_ok, parse_scrolling_args): Update.
4521         * tui/tui-layout.c (show_layout, show_data): Update.
4522         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4523         (tui_add_to_source_windows): Don't declare.
4524         * tui/tui-data.c (source_windows, tui_source_windows)
4525         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4526
4527 2019-08-15  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4530         Rename from reset.
4531         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4532         * tui/tui-layout.c (show_source_disasm_command, show_data):
4533         Update.
4534         (tui_gen_win_info::resize): Rename.
4535         (show_source_or_disasm_and_command): Update.
4536         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4537         reset.
4538
4539 2019-08-15  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4542         * tui/tui-interp.c (tui_interp::init): Don't call
4543         tui_initialize_static_data.
4544         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4545
4546 2019-08-15  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4549         examine tui_win_list.
4550
4551 2019-08-15  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4554         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4555         tui_clear_source_content.
4556         (tui_clear_source_content): Remove.
4557         (tui_source_window_base::do_erase_source_content): Hoist call to
4558         content.clear().
4559         * tui/tui-stack.c (tui_show_frame_info): Don't call
4560         tui_clear_source_content.
4561
4562 2019-08-15  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-winsource.h (struct tui_source_window_base)
4565         <do_erase_source_content>: New method.
4566         <erase_source_content>: New method.
4567         (tui_erase_source_content): Don't declare.
4568         * tui/tui-winsource.c (tui_clear_source_content): Update.
4569         (tui_source_window_base::do_erase_source_content): Rename from
4570         tui_erase_source_content.
4571         (tui_source_window_base::show_source_content): Update.
4572         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4573         * tui/tui-source.h (struct tui_source_window)
4574         <erase_source_content>: New method.
4575         * tui/tui-disasm.h (struct tui_disasm_window)
4576         <erase_source_content>: New method.
4577
4578 2019-08-15  Tom Tromey  <tom@tromey.com>
4579
4580         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4581         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4582         constructor.
4583         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4584         * tui/tui-source.c (tui_set_source_content): Update.
4585         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4586
4587 2019-08-15  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4590         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4591         tui-source.c.
4592         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4593         Declare.
4594         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4595         method.
4596         (tui_source_window::maybe_update): Update.
4597
4598 2019-08-15  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4601         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4602         tui-disasm.c.
4603         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4604         Declare.
4605         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4606         method.
4607         (tui_disasm_window::maybe_update): Update.
4608
4609 2019-08-15  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-winsource.h (struct tui_source_window_base)
4612         <maybe_update>: Declare.
4613         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4614         method.
4615         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4616         Declare.
4617         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4618         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4619         Declare.
4620         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4621
4622 2019-08-15  Tom Tromey  <tom@tromey.com>
4623
4624         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4625
4626 2019-08-15  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-wingeneral.c: Include tui-stack.h.
4629         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4630         (struct tui_locator_window): Move from tui-data.h.
4631         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4632         (tui_initialize_static_data): Move from tui-data.c.
4633         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4634         (struct tui_locator_window): Move to tui-stack.c.
4635         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4636         (tui_initialize_static_data): Move to tui-stack.c.
4637
4638 2019-08-15  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-layout.c (show_source_disasm_command)
4641         (show_source_or_disasm_and_command): Use make_visible method, not
4642         tui_make_window.
4643         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4644         Remove.
4645
4646 2019-08-15  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-wingeneral.h (tui_make_window): Update.
4649         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4650         parameter.
4651         (tui_gen_win_info::make_visible): Update.
4652         * tui/tui-regs.c (tui_data_window::display_registers_from):
4653         Update.
4654         * tui/tui-layout.c (show_source_disasm_command)
4655         (show_source_or_disasm_and_command): Update.
4656         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4657         (enum tui_box): Remove.
4658         (struct tui_win_info) <can_box>: New method.
4659         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4660         method.
4661
4662 2019-08-15  Tom de Vries  <tdevries@suse.de>
4663
4664         * linux-nat-trad.c: Include gdbarch.h.
4665
4666 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4667
4668         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4669         register sizes.
4670
4671 2019-08-14  Tom Tromey  <tromey@adacore.com>
4672
4673         * darwin-nat.c: Include gdbarch.h.
4674         * darwin-nat-info.c: Include gdbarch.h.
4675
4676 2019-08-13  Tom Tromey  <tom@tromey.com>
4677
4678         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4679         Remove.
4680         * tui/tui-data.c (tui_initialize_static_data): Update.
4681
4682 2019-08-13  Tom Tromey  <tom@tromey.com>
4683
4684         * tui/tui-winsource.h (struct tui_exec_info_window)
4685         <~tui_exec_info_window, maybe_allocate_content, get_content,
4686         m_content>: Remove.
4687         (struct tui_source_window_base) <set_exec_info_content,
4688         show_exec_info_content>: Don't declare.
4689         * tui/tui-winsource.c
4690         (tui_exec_info_window::maybe_allocate_content): Remove.
4691         (tui_source_window_base::update_exec_info): Rename from
4692         set_exec_info_content.
4693         (tui_source_window_base::show_exec_info_content)
4694         (tui_source_window_base::update_exec_info): Remove.
4695
4696 2019-08-13  Tom Tromey  <tom@tromey.com>
4697
4698         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4699         declare.
4700         * tui/tui-winsource.c (tui_update_source_window_as_is)
4701         (tui_update_source_windows_with_addr, tui_erase_source_content):
4702         Update.
4703         (tui_clear_exec_info_content): Remove.
4704
4705 2019-08-13  Tom Tromey  <tom@tromey.com>
4706
4707         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4708         declare.
4709         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4710         call tui_erase_exec_info_content.
4711         (tui_clear_exec_info_content): Rename from
4712         tui_erase_exec_info_content.
4713         (tui_clear_exec_info_content): Delete.
4714
4715 2019-08-13  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-winsource.h (struct tui_source_window_base)
4718         <show_exec_info_content>: Declare.
4719         (tui_show_exec_info_content): Don't declare.
4720         * tui/tui-winsource.c
4721         (tui_source_window_base::show_exec_info_content): Rename from
4722         tui_show_exec_info_content.
4723         (tui_source_window_base::update_exec_info): Update.
4724
4725 2019-08-13  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4728         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4729         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4730         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4731         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4732         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4733         ... here.
4734
4735 2019-08-13  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-winsource.h (struct tui_source_window_base)
4738         <update_exec_info>: Declare.
4739         (tui_update_exec_info): Don't declare.
4740         * tui/tui-winsource.c (tui_update_source_window_as_is)
4741         (tui_source_window_base::refresh_all)
4742         (tui_update_all_breakpoint_info): Update.
4743         (tui_source_window_base::update_exec_info): Rename from
4744         tui_update_exec_info.
4745         * tui/tui-stack.c (tui_show_frame_info): Update.
4746
4747 2019-08-13  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-winsource.h (struct tui_source_window_base)
4750         <set_exec_info_content>: Declare.
4751         (tui_set_exec_info_content): Don't declare.
4752         * tui/tui-winsource.c
4753         (tui_source_window_base::set_exec_info_content): Rename from
4754         tui_set_exec_info_content.
4755         (tui_update_exec_info): Update.
4756
4757 2019-08-13  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-winsource.h (struct tui_source_window_base)
4760         <show_source_content>: Declare.
4761         (tui_show_source_content): Don't declare.
4762         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4763         (tui_source_window_base::show_source_content): Rename from
4764         tui_show_source_content.
4765         (tui_source_window_base::refresh_all): Update.
4766         * tui/tui-layout.c (show_source_disasm_command)
4767         (show_source_or_disasm_and_command): Update.
4768
4769 2019-08-13  Tom Tromey  <tom@tromey.com>
4770
4771         * tui/tui-winsource.c (tui_erase_source_content)
4772         (tui_show_source_content, tui_source_window_base::refresh_all):
4773         Update.
4774         * tui/tui-wingeneral.h
4775         (tui_check_and_display_highlight_if_needed): Don't declare.
4776         * tui/tui-wingeneral.c
4777         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4778         check_and_display_highlight_if_needed.
4779         * tui/tui-win.c (tui_rehighlight_all)
4780         (tui_win_info::make_visible_with_new_height): Update.
4781         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4782         (tui_data_window::erase_data_content)
4783         (tui_data_window::display_all_data): Update.
4784         * tui/tui-data.h (struct tui_win_info)
4785         <check_and_display_highlight_if_needed>: Declare.
4786
4787 2019-08-13  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-win.c (tui_resize_all): Call
4790         tui_delete_invisible_windows.
4791         * tui/tui-layout.c (show_layout): Call
4792         tui_delete_invisible_windows.
4793         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4794         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4795
4796 2019-08-13  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4799         tui_add_win_to_layout.
4800
4801 2019-08-13  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4804         * tui/tui-layout.c (tui_default_win_height): Now static.
4805
4806 2019-08-13  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4809         single switch.
4810         (show_source_disasm_command, show_source_or_disasm_and_command):
4811         Don't check current layout.
4812
4813 2019-08-13  Tom Tromey  <tom@tromey.com>
4814
4815         * tui/tui-wingeneral.c (make_all_visible): Remove.
4816         (tui_make_all_invisible): Simplify.
4817         * tui/tui-layout.c (tui_make_all_invisible): Move from
4818         tui-wingeneral.c; simplify.
4819         (show_layout): Hoist call to tui_make_all_invisible.
4820         (show_data): Don't call tui_make_all_invisible.
4821
4822 2019-08-13  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4825         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4826
4827 2019-08-13  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4830         tui-data.c.
4831         (show_source_disasm_command, show_data)
4832         (show_source_or_disasm_and_command): Don't use
4833         tui_set_current_layout_to.
4834         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4835         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4836         tui-layout.c.
4837         (tui_set_current_layout_to): Remove.
4838
4839 2019-08-13  Tom Tromey  <tom@tromey.com>
4840
4841         * tui/tui-layout.c (tui_set_layout): Update.
4842         * tui/tui-data.h (struct tui_layout_def): Remove.
4843         (tui_layout_def): Don't declare.
4844         * tui/tui-data.c (layout_def): Remove.
4845         (tui_layout_def): Remove.
4846
4847 2019-08-13  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-winsource.h (struct tui_source_window_base)
4850         <clear_detail>: No longer "override".
4851         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4852         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4853         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4854         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4855         Remove.
4856         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4857
4858 2019-08-13  Tom Tromey  <tromey@adacore.com>
4859
4860         * tracepoint.c: Don't include readline.h or history.h.
4861
4862 2019-08-12  Tom Tromey  <tom@tromey.com>
4863
4864         * configure: Rebuild.
4865         * configure.ac: Check for readline 7.
4866         * NEWS: Mention readline 7 requirement.
4867         * README: Update.
4868
4869 2019-08-12  Tom Tromey  <tom@tromey.com>
4870
4871         * mingw-hdep.c (gdb_select): Remove readline hack.
4872
4873 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4874
4875         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4876         when the function fails.
4877
4878 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4879
4880         * s390-tdep.c (s390_type_align): New function.
4881         (s390_gdbarch_init): Set it as type_align gdbarch method.
4882
4883 2019-08-09  Tom de Vries  <tdevries@suse.de>
4884
4885         PR gdb/24591
4886         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4887         pc_low with relocation offset.
4888
4889 2019-08-07  Tom Tromey  <tromey@adacore.com>
4890
4891         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4892         (print_frame_args): Update.
4893         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4894         Update.
4895         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4896         * frame.h (struct frame_arg): Add initializers.
4897         <error>: Now a unique_xmalloc_ptr.
4898
4899 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4900
4901         * NEWS: Expand the Pointer Authentication entry.
4902         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4903         (aarch64_frame_unmask_lr): ... to this.
4904         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4905         Call aarch64_frame_unmask_lr.
4906         * frame.c (struct frame_info): Add "masked" variable.
4907         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4908         (fprint_frame): Check for masked pc.
4909         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4910         declarations.
4911         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4912         * stack.c (print_frame): Check for masked pc.
4913
4914 2019-08-06  Tom Tromey  <tom@tromey.com>
4915
4916         * stabsread.c (patch_block_stabs, read_one_struct_field)
4917         (read_enum_type): Use obstack_strndup.
4918         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4919         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4920         * dwarf2read.c (guess_full_die_structure_name)
4921         (anonymous_struct_prefix): Use obstack_strndup.
4922         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4923         * c-exp.y (yylex): Use obstack_strndup.
4924         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4925         (write_var_or_type): Use obstack_strndup.
4926
4927 2019-08-06  Tom Tromey  <tom@tromey.com>
4928
4929         * symfile.c (reread_symbols): Use obstack_strdup.
4930         * stabsread.c (read_type): Use obstack_strdup.
4931         * gdb_obstack.h (obstack_strdup): New overload.
4932         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4933         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4934         (dwarf2_canonicalize_name): Use obstack_strdup.
4935         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4936         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4937         Use obstack_strdup.
4938
4939 2019-08-06  Tom Tromey  <tom@tromey.com>
4940
4941         * gdb_obstack.h (obstack_strdup): Define.
4942         * gdb_obstack.c (obstack_strdup): Don't define.
4943
4944 2019-08-06  Tom Tromey  <tom@tromey.com>
4945
4946         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4947         obstack_strdup.
4948         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4949         obstack_strdup.
4950         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4951         * stabsread.c (common_block_start): Use obstack_strdup.
4952         * objfiles.c (set_objfile_main_name, objfile): Use
4953         obstack_strdup.
4954         * namespace.c (add_using_directive): Use obstack_strdup.
4955         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4956         * jit.c (finalize_symtab): Use obstack_strdup.
4957         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4958         (guess_partial_die_structure_name, partial_die_info::fixup)
4959         (dwarf2_name): Use obstack_strdup.
4960         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4961         obstack_strdup.
4962         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4963         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4964         obstack_strdup.
4965         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4966
4967 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4968
4969         * unittests/help-doc-selftests.c: New file.
4970         * Makefile.in: Add the new file.
4971
4972 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4973
4974         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4975         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4976         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4977         the trailing '.' is not output, and the first character is uppercased.
4978         (print_help_for_command): Update call to print_doc_line.
4979         (print_doc_of_command): Likewise.
4980         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4981         * cli/cli-option.c (append_indented_doc): Do not append newline.
4982         (build_help_option): Append newline after first appended_indented_doc
4983         only if a second call is done.
4984         (build_help): Append 2 new lines before each option, except the first
4985         one.
4986         * compile/compile.c (_initialize_compile): Add new lines after
4987         %OPTIONS%, when not at the end of the help.
4988         Change help doc or code
4989         producing the help doc to respect the invariants.
4990         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4991         Also removed the new line after 'Options:', as all other commands
4992         do not put an empty line between 'Options:' and the first option.
4993         * printcmd.c (_initialize_printcmd): Likewise.
4994         * stack.c (_initialize_stack): Likewise.
4995         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4996         incorrectly telling COMMAND is optional.
4997         * ada-lang.c (_initialize_ada_language): Change help doc or code
4998         producing the help doc to respect the invariants.
4999         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5000         * breakpoint.c (_initialize_breakpoint): Likewise.
5001         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5002         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5003         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5004         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5005         _initialize_cli_style): Likewise.
5006         * corelow.c (core_target_info): Likewise.
5007         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5008         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5009         * filesystem.c (_initialize_filesystem): Likewise.
5010         * frame.c (_initialize_frame): Likewise.
5011         * gnu-nat.c (add_task_commands): Likewise.
5012         * infcall.c (_initialize_infcall): Likewise.
5013         * infcmd.c (_initialize_infcmd): Likewise.
5014         * interps.c (_initialize_interpreter): Likewise.
5015         * language.c (_initialize_language): Likewise.
5016         * linux-fork.c (_initialize_linux_fork): Likewise.
5017         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5018         * maint.c (_initialize_maint_cmds): Likewise.
5019         * memattr.c (_initialize_mem): Likewise.
5020         * printcmd.c (_initialize_printcmd): Likewise.
5021         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5022         _RegEx): Likewise.
5023         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5024         * record-btrace.c (_initialize_record_btrace): Likewise.
5025         * record-full.c (_initialize_record_full): Likewise.
5026         * record.c (_initialize_record): Likewise.
5027         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5028         * regcache.c (_initialize_regcache): Likewise.
5029         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5030         _initialize_remote): Likewise.
5031         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5032         * serial.c (_initialize_serial): Likewise.
5033         * skip.c (_initialize_step_skip): Likewise.
5034         * source.c (_initialize_source): Likewise.
5035         * stack.c (_initialize_stack): Likewise.
5036         * symfile.c (_initialize_symfile): Likewise.
5037         * symtab.c (_initialize_symtab): Likewise.
5038         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5039         * top.c (init_main): Likewise.
5040         * tracefile-tfile.c (tfile_target_info): Likewise.
5041         * tracepoint.c (_initialize_tracepoint): Likewise.
5042         * tui/tui-win.c (_initialize_tui_win): Likewise.
5043         * utils.c (add_internal_problem_command): Likewise.
5044         * valprint.c (value_print_option_defs): Likewise.
5045
5046 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5047
5048         PR build/24886
5049         * configure.ac: Drop enable-libmcheck support.
5050         * configure, config.in: Rebuild.
5051         * libmcheck.m4: Remove.
5052         * acinclude.m4: Don't include it.
5053         * Makefile.in: Don't distribute it.
5054         * top.c (print_gdb_configuration): Don't mention it.
5055
5056 2019-08-06  Tom Tromey  <tom@tromey.com>
5057
5058         * utils.c (set_output_style): Sometimes pass stream to
5059         emit_style_escape.
5060         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5061         * record-btrace.c (btrace_insn_history): Update.
5062         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5063         method.
5064         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5065         Update initializers.
5066         <m_uiout>: New field.
5067         <m_di>: Move lower.
5068         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5069         Remove "uiout" parameter.
5070         (dump_insns): Update.
5071         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5072         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5073
5074 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5075
5076         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5077         (error_in_psymtab_expansion): Likewise.
5078         (lookup_symbol_via_quick_fns): Likewise.
5079         (basic_lookup_transparent_type_quick): Likewise.
5080         (basic_lookup_transparent_type_1): Likewise.
5081
5082 2019-08-06  Tom Tromey  <tromey@adacore.com>
5083
5084         * source.c (last_source_error): Now bool.
5085         (print_source_lines_base): Make "noprint" bool.  Only open
5086         source file when last_source_visited changes.
5087
5088 2019-08-06  Tom Tromey  <tromey@adacore.com>
5089
5090         * annotate.c (annotate_source_line): Use g_source_cache.
5091         * source-cache.c (source_cache::get_plain_source_lines): Change
5092         parameters.  Populate m_offset_cache.
5093         (source_cache::ensure): New method.
5094         (source_cache::get_line_charpos): New method.
5095         (extract_lines): Move lower.  Change parameters.
5096         (source_cache::get_source_lines): Move lower.
5097         * source-cache.h (class source_cache): Update comment.
5098         <get_line_charpos>: New method.
5099         <get_source_lines>: Update comment.
5100         <clear>: Clear m_offset_cache.
5101         <get_plain_source_lines>: Change parameters.
5102         <ensure>: New method
5103         <m_offset_cache>: New member.
5104         * source.c (forget_cached_source_info_for_objfile): Update.
5105         (info_source_command): Use g_source_cache.
5106         (find_source_lines, open_source_file_with_line_charpos): Remove.
5107         (print_source_lines_base, search_command_helper): Use g_source_cache.
5108         * source.h (open_source_file_with_line_charpos): Don't declare.
5109         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5110         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5111         Use g_source_cache.
5112
5113 2019-08-06  Tom Tromey  <tromey@adacore.com>
5114
5115         * source-cache.c (source_cache::get_plain_source_lines):
5116         Remove "first_line" and "last_line" parameters.
5117         (source_cache::get_source_lines): Cache plain text.
5118         * source-cache.h (class source_cache)
5119         <get_plain_source_lines>: Update.
5120
5121 2019-08-06  Tom Tromey  <tromey@adacore.com>
5122
5123         * source-cache.c (extract_lines): No longer a method.
5124         Changed type of parameter.  Include final newline.
5125         (selftests::extract_lines_test): New function.
5126         (_initialize_source_cache): Likewise.
5127         * source-cache.h (class source_cache)
5128         <extract_lines>: Don't declare.
5129
5130 2019-08-06  Tom Tromey  <tromey@adacore.com>
5131
5132         * breakpoint.c (init_breakpoint_sal): Update.
5133         (breakpoint): Update.
5134         * breakpoint.h (struct breakpoint) <filter>: Now a
5135         unique_xmalloc_ptr.
5136
5137 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5138
5139         * NEWS: Mention dictionary access on blocks.
5140         * python/py-block.c (blpy_getitem): New function.
5141         (block_object_as_mapping): New struct.
5142         (block_object_type): Use new struct for tp_as_mapping field.
5143
5144 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5145
5146         * objfiles.h (objfile): Add a comment describing partial symbols.
5147
5148 2019-08-05  Tom Tromey  <tromey@adacore.com>
5149
5150         * compile/compile.c (_initialize_compile): Use _(), not N_().
5151         * thread.c (_initialize_thread): Use _(), not N_().
5152         * stack.c (_initialize_stack): Use _(), not N_().
5153         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5154
5155 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5156
5157         * dwarf2read.c (struct dw2_symtab_iterator):
5158         <want_specific_block>: Remove.
5159         <block_index>: Change type to gdb::optional.
5160         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5161         change type of BLOCK_INDEX parameter to gdb::optional.
5162         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5163         (dw2_lookup_symbol): Don't pass argument for
5164         WANT_SPECIFIC_BLOCK.
5165         (dw2_expand_symtabs_for_function): Don't pass argument for
5166         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5167         (class dw2_debug_names_iterator)
5168         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5169         parameter, change BLOCK_INDEX type to gdb::optional.
5170         <m_want_specific_block>: Remove.
5171         <m_block_index>: Change type to gdb::optional.
5172         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5173         gdb::optional.  Re-write in function of gdb::optional.
5174         (dw2_debug_names_lookup_symbol): Don't pass argument for
5175         WANT_SPECIFIC_BLOCK.
5176         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5177         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5178         BLOCK_INDEX.
5179
5180 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5181
5182         * NEWS: Mention changes to "info sources" command.
5183
5184 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5185
5186         * symtab.c (filename_partial_match_opts): New struct type.
5187         (struct output_source_filename_data): New members
5188         regexp, c_regexp, partial_match.
5189         (output_source_filename): Use new members to decide to print file.
5190         (info_sources_option_defs): New variable.
5191         (make_info_sources_options_def_group, print_info_sources_header,
5192         info_sources_command_completer):
5193         New functions.
5194         (info_sources_command): Read new optional arguments.
5195         (_initialize_symtab): Update info sources help.
5196
5197 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5198
5199         * ada-lang.c (exception_support_info_v0): Renamed from...
5200         (default_exception_support_info): ... this.  Create new
5201         definition for v1.
5202         (ada_has_this_exception_support): Look up catch_handlers_sym.
5203         (ada_exception_support_info_sniffer): Try v0 after default.
5204
5205 2019-08-01  Tom Tromey  <tromey@adacore.com>
5206
5207         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5208         gdbarch.h.
5209
5210 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5211
5212         * s12z-tdep.c: Fix include path for s12z-opc.h.
5213
5214 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5215
5216         * NEWS: Require GNU make 3.82.
5217
5218 2019-07-16  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5221         declare.
5222
5223 2019-07-30  Tom Tromey  <tromey@adacore.com>
5224
5225         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5226
5227 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5228
5229         * printcmd.c (print_address_symbolic): Print negative offsets.
5230         (build_address_symbolic): Force signed arithmetic when computing
5231         offset.
5232
5233 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5234
5235         PR/24474: Add a function to lookup static variables.
5236         * NEWS: Mention this new function.
5237         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5238         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5239         * python/python.c (python_GdbMethods): Add new function.
5240
5241 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5242
5243         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5244         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5245         (objfpy_lookup_static_symbol): New function.
5246         (objfile_object_methods): Add new functions.
5247
5248 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5249
5250         * NEWS: Mention 'set|show print frame-info'.  Mention new
5251         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5252         backtrace argument.  Mention that python frame filtering code
5253         is now consistent with what 'backtrace' command prints.
5254
5255 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5256
5257         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5258         comments.
5259         (print_frame_info_auto, print_frame_info_source_line,
5260         print_frame_info_location, print_frame_info_source_and_location,
5261         print_frame_info_location_and_address, print_frame_info_short_location):
5262         New declarations.
5263         (struct frame_print_options): New member print_frame_info.
5264         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5265         * stack.h (get_user_print_what_frame_info): New declaration.
5266         (frame_show_address): New declaration.
5267         * stack.c (print_frame_arguments_choices): New value 'presence'.
5268         (print_frame_info_auto, print_frame_info_source_line,
5269         print_frame_info_location, print_frame_info_source_and_location,
5270         print_frame_info_location_and_address, print_frame_info_short_location,
5271         print_frame_info_choices, print_frame_info_print_what): New definitions.
5272         (print_frame_args): Only print dots for args if print frame-arguments
5273         is 'presence'.
5274         (frame_print_option_defs): New element for "frame-info".
5275         (get_user_print_what_frame_info): New function.
5276         (frame_show_address): Make non static.  Move comment to stack.h.
5277         (print_frame_info_to_print_what): New function.
5278         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5279         to decide what to print.
5280         (backtrace_command_1): Handle the new print_frame_arguments_presence
5281         value.
5282         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5283         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5284         (py_print_frame): In non-mi mode, use LOCATION as default for
5285         print_what, similarly to frame information printed directly by
5286         backtrace command. Handle frame-info user option in non MI mode.
5287
5288 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5289
5290         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5291         Add case for debugging 32-bit target on 64-bit host.  Revise
5292         comment.
5293
5294 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5295
5296         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5297         instead of find_function_entry_range_from_pc.
5298
5299 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5300
5301         * stack.c (find_frame_funname): Remove code which preferred
5302         minsym over symtab sym in "certain pathological cases".
5303
5304         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5305         parameter.  Change type of "do_demangle" to bool.
5306         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5307         Pass suitable "prefer_sym_over_minsym" flag to
5308         build_address_symbolic().  Don't output "+" for negative offsets.
5309         * printcmd.c (print_address_symbolic): Update invocation of
5310         build_address_symbolic to include a "prefer_sym_over_minsym"
5311         flag.
5312         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5313         Restrict cases in which use of minimal symbol is preferred to that
5314         of a found symbol.  Update comments.
5315
5316         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5317         for entry pc when entry pc is out of range for that FDE.
5318
5319 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5320
5321         PR gdb/24839:
5322         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5323         type.
5324
5325 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5326
5327         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5328         this function's Python signature.
5329
5330
5331 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5332
5333         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5334         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5335         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5336         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5337         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5338
5339
5340 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5341
5342         * h8300-tdep.c (h8300_register_name_common): New.
5343         h8300_register_name): Use h8300_register_name_common.
5344         (h8300s_register_name): Likewise.
5345         (h8300sx_register_name): Likewise.
5346         (h8300h_register_nam): New.
5347         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5348
5349
5350 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5351
5352         * arm-tdep.c (arm_skip_cmse_entry): New function.
5353         (arm_is_sgstubs_section): New function.
5354         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5355
5356 2019-07-22  Tom Tromey  <tom@tromey.com>
5357
5358         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5359         Don't self-assign.
5360
5361 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5362
5363         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5364         type_print.
5365
5366 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5367
5368         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5369         so that GDB doesn't match any msymbols when searching in the
5370         TYPES_DOMAIN.
5371         (print_symbol_info): Print using typedef_print or type_print based
5372         on the type of the symbol.  Add updated FIXME comment moved from...
5373         (_initialize_symtab): ... move and update FIXME comment to above.
5374
5375 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * NEWS: Mention adding -q option to "info types".
5378         * symtab.c (struct info_types_options): New struct.
5379         (info_types_options_defs): New variable.
5380         (make_info_types_options_def_group): New function.
5381         (info_types_command): Use gdb::option framework to parse options.
5382         (info_types_command_completer): New function.
5383         (_initialize_symtab): Extend the help text on "info types" and
5384         register command completer.
5385
5386 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5387
5388         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5389         (lookup_symbol_in_objfile): Change int to block_enum and add a
5390         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5391
5392 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5393
5394         * MAINTAINERS (Write After Approval): Add self.
5395
5396 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5399         instruction to the dummy code region.
5400
5401 2019-07-19  Tom Tromey  <tromey@adacore.com>
5402
5403         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5404         (ARGSUSED, PARAMS, __func__): Remove rules.
5405
5406 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5407
5408         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5409         * features/arm/arm-with-iwmmxt.c: Remove.
5410         * features/arm/arm-with-iwmmxt.xml: Remove.
5411         * features/arm/arm-with-m-fpa-layout.c: Remove.
5412         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5413         * features/arm/arm-with-m-vfp-d16.c: Remove.
5414         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5415         * features/arm/arm-with-m.c: Remove.
5416         * features/arm/arm-with-m.xml: Remove.
5417         * features/arm/arm-with-neon.c: Remove.
5418         * features/arm/arm-with-neon.xml: Remove.
5419         * features/arm/arm-with-vfpv2.c: Remove.
5420         * features/arm/arm-with-vfpv2.xml: Remove.
5421         * features/arm/arm-with-vfpv3.c: Remove.
5422         * features/arm/arm-with-vfpv3.xml: Remove.
5423
5424 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5425
5426         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5427
5428 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5429
5430         * arch/aarch32.c (aarch32_create_target_description): Create
5431         target descriptions using features.
5432         * arch/arm.c (arm_create_target_description)
5433         (arm_create_mprofile_target_description): Likewise.
5434         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5435
5436 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5437
5438         * Makefile.in: Add new files.
5439         * aarch32-tdep.c: New file.
5440         * aarch32-tdep.h: New file.
5441         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5442         Call aarch32_read_description.
5443         * arch/aarch32.c: New file.
5444         * arch/aarch32.h: New file.
5445         * arch/arm.c (arm_create_target_description)
5446         (arm_create_mprofile_target_description): New function.
5447         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5448         (arm_create_target_description)
5449         (arm_create_mprofile_target_description): New declaration.
5450         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5451         read_description functions.
5452         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5453         Likewise.
5454         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5455         * arm-tdep.c (tdesc_arm_list): New variable.
5456         (arm_register_g_packet_guesses): Call create description functions.
5457         (arm_read_description) (arm_read_mprofile_description): New
5458         function.
5459         * arm-tdep.h (arm_read_description)
5460         (arm_read_mprofile_description): Add declaration.
5461         * configure.tgt: Add new files.
5462
5463 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5464
5465         * top.c (new_ui_command): Open specified terminal just once.
5466
5467 2019-07-18  Tom Tromey  <tromey@adacore.com>
5468
5469         * symtab.c (main_name): Constify return type.
5470         * symfile.c (set_initial_language): Update.
5471         * symtab.h (main_name): Constify return type.
5472
5473 2019-07-17  Tom Tromey  <tom@tromey.com>
5474
5475         * tui/tui-winsource.c (tui_update_source_window)
5476         (tui_update_source_window_as_is)
5477         (tui_update_source_windows_with_line): Remove return.
5478         * tui/tui-disasm.c (tui_show_disassem)
5479         (tui_show_disassem_and_update_source): Remove return.
5480         * tui/tui.c (tui_reset): Remove return.
5481         * tui/tui-wingeneral.c
5482         (tui_check_and_display_highlight_if_needed): Remove return.
5483
5484 2019-07-17  Tom Tromey  <tom@tromey.com>
5485
5486         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5487
5488 2019-07-17  Tom Tromey  <tom@tromey.com>
5489
5490         * tui/tui-winsource.h (struct tui_exec_info_window)
5491         (struct tui_source_window_base): Move from tui-data.h.
5492         * tui/tui-winsource.c: Move many method definitions from
5493         elsewhere.  Remove "structuring" comments.
5494         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5495         (tui_source_window_base::refresh_window): Move to
5496         tui-winsource.c.
5497         * tui/tui-win.c (tui_source_window_base::refresh_all)
5498         (tui_source_window_base::update_tab_width)
5499         (tui_source_window_base::set_new_height)
5500         (tui_source_window_base::do_make_visible_with_new_height): Move to
5501         tui-winsource.c.
5502         * tui/tui-source.h: Update.
5503         * tui/tui-source.c (tui_source_window_base::reset): Move to
5504         tui-winsource.c.
5505         * tui/tui-disasm.h: Update.
5506         * tui/tui-data.h (struct tui_exec_info_window): Move to
5507         tui-winsource.h.
5508         (struct tui_source_window_base): Likewise.
5509         * tui/tui-data.c (tui_source_window_base::clear_detail)
5510         (tui_source_window_base, ~tui_source_window_base): Move to
5511         tui-winsource.c.
5512
5513 2019-07-17  Tom Tromey  <tom@tromey.com>
5514
5515         * tui/tui-win.c (tui_resize_all)
5516         (tui_source_window_base::update_tab_width)
5517         (tui_adjust_win_heights): Update.
5518         (tui_win_info::make_invisible_and_set_new_height): Rename from
5519         make_invisible_and_set_new_height.
5520         * tui/tui-data.h (struct tui_win_info)
5521         <make_invisible_and_set_new_height>: New method.
5522
5523 2019-07-17  Tom Tromey  <tom@tromey.com>
5524
5525         * tui/tui.c: Update.
5526         * tui/tui-source.h (struct tui_source_window): Move from
5527         tui-data.h.
5528         * tui/tui-layout.c: Update.
5529         * tui/tui-disasm.c: Update.
5530         * tui/tui-data.h (struct tui_source_window): Move to
5531         tui-source.h.
5532
5533 2019-07-17  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5536         tui-data.h.
5537         * tui/tui-data.h (struct tui_disasm_window): Move to
5538         tui-disasm.h.
5539
5540 2019-07-17  Tom Tromey  <tom@tromey.com>
5541
5542         * tui/tui-regs.h (struct tui_data_item_window): Move from
5543         tui-data.h.
5544         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5545         * tui/tui-data.h (struct tui_data_item_window): Move to
5546         tui-regs.h.
5547         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5548
5549 2019-07-17  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui.c: Update.
5552         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5553         (tui_cmd_window::max_height): Move to tui-command.c.
5554         * tui/tui-layout.c: Update.
5555         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5556         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5557         tui-command.c.
5558         * tui/tui-command.h (struct tui_cmd_window): Move from
5559         tui-data.h.
5560         * tui/tui-command.c: Remove "structuring" comments.
5561         (tui_cmd_window::clear_detail)
5562         (tui_cmd_window::do_make_visible_with_new_height)
5563         (tui_cmd_window::max_height): Move from elsewhere.
5564
5565 2019-07-17  Tom Tromey  <tom@tromey.com>
5566
5567         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5568         Now static.
5569         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5570         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5571
5572 2019-07-17  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui.c: Update.
5575         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5576         tui-regs.c.
5577         * tui/tui-windata.h: Remove file.
5578         * tui/tui-windata.c: Remove file.
5579         * tui/tui-win.c (tui_data_window::set_new_height)
5580         (tui_data_window::do_make_visible_with_new_height): Move to
5581         tui-regs.c.
5582         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5583         * tui/tui-regs.c: Remove "structuring" comments.
5584         (tui_data_window::first_data_item_displayed)
5585         (tui_data_window::delete_data_content_windows)
5586         (tui_data_window::erase_data_content)
5587         (tui_data_window::display_all_data)
5588         (tui_data_window::refresh_all)
5589         (tui_data_window::do_scroll_vertical)
5590         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5591         (tui_data_window::do_make_visible_with_new_height)
5592         (tui_data_window::refresh_window): Move from elsewhere.
5593         (_initialize_tui_regs): Move to end of file.
5594         * tui/tui-layout.c: Update.
5595         * tui/tui-hooks.c: Update.
5596         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5597         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5598         tui-regs.c.
5599         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5600
5601 2019-07-17  Tom Tromey  <tom@tromey.com>
5602
5603         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5604         seen.
5605
5606 2019-07-17  Tom Tromey  <tom@tromey.com>
5607
5608         * tui/tui-win.c (tui_source_window_base::set_new_height)
5609         (tui_source_window_base::do_make_visible_with_new_height): Use
5610         m_has_locator field directly.
5611         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5612         method.
5613         (struct tui_source_window_base) <has_locator>: Likewise.
5614
5615 2019-07-17  Tom Tromey  <tom@tromey.com>
5616
5617         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5618         Don't declare.
5619         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5620         Remove.
5621         * tui/tui-win.c (tui_source_window_base::set_new_height)
5622         (tui_source_window_base::set_new_height)
5623         (make_invisible_and_set_new_height)
5624         (tui_source_window_base::do_make_visible_with_new_height)
5625         (tui_source_window_base::do_make_visible_with_new_height):
5626         Update.
5627         * tui/tui-layout.c (show_source_disasm_command, show_data)
5628         (show_source_or_disasm_and_command): Update.
5629         * tui/tui-layout.c (show_layout): Update.
5630
5631 2019-07-17  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui-layout.c (make_data_window): Remove.
5634         (show_data): Unify creation and re-initialization cases.
5635
5636 2019-07-17  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-layout.c (make_source_window, make_disasm_window):
5639         Remove.
5640         (show_data): Unify creation and re-initialization cases.
5641
5642 2019-07-17  Tom Tromey  <tom@tromey.com>
5643
5644         * tui/tui-layout.c (make_command_window): Remove.
5645         (show_source_disasm_command, show_source_or_disasm_and_command):
5646         Unify creation and re-initialization cases.
5647
5648 2019-07-17  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5651         creation and re-initialization cases.
5652
5653 2019-07-17  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-regs.c (tui_get_register): Return void.
5656
5657 2019-07-17  Tom Tromey  <tom@tromey.com>
5658
5659         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5660         Simplify.
5661
5662 2019-07-17  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5665         resetting.
5666
5667 2019-07-17  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5670         * tui/tui-regs.c (tui_reg_layout): New function.
5671         (tui_show_registers, tui_reg_command): Use it.
5672         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5673         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5674         parameters.
5675         (tui_layout_command): Remove.
5676
5677 2019-07-17  Tom Tromey  <tom@tromey.com>
5678
5679         * tui/tui-layout.h (tui/tui-layout): Return void.
5680         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5681
5682 2019-07-17  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-layout.c (show_source_disasm_command, show_data):
5685         Update.
5686         (reset_locator): Remove.
5687         (show_source_or_disasm_and_command): Update.
5688
5689 2019-07-17  Tom Tromey  <tom@tromey.com>
5690
5691         * tui/tui-source.c (tui_source_window_base::reset): Remove
5692         win_type parameter.
5693         * tui/tui-layout.c (make_command_window, make_source_window)
5694         (make_disasm_window, make_data_window)
5695         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5696         (reset_locator, show_source_or_disasm_and_command): Update.
5697         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5698         win_type parameter.
5699         (struct tui_source_window_base) <reset>: Likewise.
5700
5701 2019-07-17  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui-layout.c (show_source_disasm_command): Use
5704         reset_locator.
5705         (reset_locator): New function.
5706         (init_and_make_win): Remove.
5707         (show_source_or_disasm_and_command): Use reset_locator.
5708
5709 2019-07-17  Tom Tromey  <tom@tromey.com>
5710
5711         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5712         condition.
5713         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5714         Remove condition.
5715         * tui/tui-source.c (tui_source_window_base::reset): New method.
5716         * tui/tui-layout.c (make_command_window): Don't call
5717         init_and_make_win.
5718         (make_source_window, make_disasm_window): Don't call
5719         make_source_or_disasm_window.
5720         (make_data_window): Don't call init_and_make_win.  Change calling
5721         convention.
5722         (show_source_disasm_command, show_data): Simplify.
5723         (make_source_or_disasm_window): Remove.
5724         (show_source_or_disasm_and_command): Simplify.
5725         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5726         (struct tui_source_window_base) <reset>: Likewise.
5727         <execution_info>: Remove initializer.
5728         * tui/tui-data.c (tui_source_window_base): Initialize
5729         execution_info.
5730
5731 2019-07-17  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5734         variable.
5735
5736 2019-07-17  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui.c (tui_rl_other_window): Update.
5739         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5740         superclass method first.  Always iterate over regs_content.
5741         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5742         method.
5743         * tui/tui-win.c (tui_set_focus_command): Update.
5744
5745 2019-07-17  Tom Tromey  <tom@tromey.com>
5746
5747         * tui/tui-win.c (tui_set_focus_command): Rename from
5748         tui_set_focus.  Call tui_enable.
5749         (tui_set_focus_command): Remove.
5750
5751 2019-07-17  Tom Tromey  <tom@tromey.com>
5752
5753         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5754         refresh_window.
5755         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5756         touchwin.
5757         (tui_data_window::refresh_window): Call refresh_window on data
5758         items.  Always call superclass refresh_window.
5759         (tui_win_info::refresh): Remove.
5760         (tui_source_window_base::refresh_window): Update.
5761         (tui_refresh_all): Update.
5762         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5763         refresh_window.
5764         (show_source_or_disasm_and_command): Likewise.
5765         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5766         (struct tui_source_window_base) <refresh>: Likewise.
5767
5768 2019-07-17  Tom Tromey  <tom@tromey.com>
5769
5770         * tui/tui-winsource.c (tui_clear_source_content)
5771         (tui_show_source_content): Update.
5772         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5773         whether content is empty.
5774         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5775         Remove.
5776
5777 2019-07-17  Tom Tromey  <tom@tromey.com>
5778
5779         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5780         window's contents.
5781         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5782         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5783
5784 2019-07-17  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5787         (struct tui_data_item_window): Update.
5788
5789 2019-07-17  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5792         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5793         defines.
5794
5795 2019-07-17  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-winsource.h (tui_erase_source_content)
5798         (tui_clear_source_content): Remove "display_prompt" parameter.
5799         * tui/tui-winsource.c (tui_update_source_window_as_is)
5800         (tui_update_source_windows_with_addr): Update.
5801         (tui_clear_source_content): Remove "display_prompt" parameter.
5802         (tui_erase_source_content): Likewise.  Simplify.
5803         (tui_show_source_content): Update.
5804         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5805         * tui/tui-stack.c (tui_show_frame_info): Update.
5806         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5807         Remove defines.
5808
5809 2019-07-17  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5812         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5813         parameter.
5814         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5815         parameter.
5816
5817 2019-07-17  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-winsource.c (tui_clear_source_content)
5820         (tui_show_source_content, tui_show_exec_info_content)
5821         (tui_clear_exec_info_content): Update.
5822         * tui/tui-stack.c (tui_show_locator_content): Update.
5823         (tui_show_frame_info): Update.
5824         * tui/tui-source.h (tui_source_window): Don't declare.
5825         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5826         from tui_source_is_displayed.
5827         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5828         Remove field.
5829         (struct tui_source_window_base) <content_in_use>: New field.  Now
5830         bool.
5831         (struct tui_source_window) <showing_source_p>: New method.
5832         (TUI_SRC_WIN): Change cast.
5833         * tui/tui-data.c (tui_initialize_static_data): Update.
5834
5835 2019-07-17  Tom Tromey  <tom@tromey.com>
5836
5837         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5838         location_matches_p.
5839         * tui/tui-source.c (tui_source_window::location_matches_p): New
5840         method.
5841         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5842         method.
5843         * tui/tui-data.h (struct tui_source_window_base)
5844         <location_matches_p>: New method.
5845         (struct tui_source_window, struct tui_disasm_window)
5846         <location_matches_p>: Likewise.
5847
5848 2019-07-17  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-win.c (tui_set_win_height_command): Rename from
5851         tui_set_win_height.
5852         (tui_set_win_height_command): Remove.
5853
5854 2019-07-17  Tom Tromey  <tom@tromey.com>
5855
5856         * tui/tui-source.c (tui_source_window): New constructor.  Add
5857         observer.
5858         (~tui_source_window): New destructor.
5859         (tui_source_window::style_changed): New method.
5860         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5861         (tui_attach_detach_observers): Update.
5862         * tui/tui-data.h (struct tui_source_window): Make constructor not
5863         inline.  Add destructor.
5864         (struct tui_source_window) <style_changed>: New method.
5865         <m_observable>: New member.
5866
5867 2019-07-17  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5870         * tui/tui-win.c (tui_resize_all): Fix typo.
5871
5872 2019-07-17  Tom Tromey  <tom@tromey.com>
5873
5874         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5875         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5876         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5877         * tui/tui-win.c (window_name_completer): Use foreach.
5878         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5879         (update_tab_width): Likewise.
5880         * tui/tui-layout.c (show_layout): Update.
5881         * tui/tui-data.h (class tui_window_iterator): New.
5882         (struct all_tui_windows): New.
5883         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5884
5885 2019-07-17  Tom Tromey  <tom@tromey.com>
5886
5887         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5888         parameter.  Don't reference globals.
5889         (tui_reg_command): Update.
5890
5891 2019-07-17  Tom Tromey  <tom@tromey.com>
5892
5893         * tui/tui-regs.c (tui_show_registers): Simplify.
5894
5895 2019-07-17  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-regs.c (tui_show_registers): Update.
5898         (tui_show_register_group): Add win_info parameter.
5899
5900 2019-07-17  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5903         Rename from tui_display_reg_element_at_line.
5904         (tui_data_window::display_registers_from_line): Update.
5905         * tui/tui-data.h (struct tui_data_window)
5906         <display_reg_element_at_line>: New method.
5907
5908 2019-07-17  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-regs.h (tui_display_registers_from)
5911         (tui_display_registers_from_line): Don't declare.
5912         * tui/tui-windata.c (tui_data_window::display_all_data)
5913         (tui_data_window::refresh_all)
5914         (tui_data_window::do_scroll_vertical): Update.
5915         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5916         from tui_display_registers_from.
5917         (tui_display_reg_element_at_line): Update.
5918         (tui_data_window::display_registers_from_line): Rename from
5919         tui_display_registers_from_line.
5920         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5921         display_registers_from_line>: New methods.
5922
5923 2019-07-17  Tom Tromey  <tom@tromey.com>
5924
5925         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5926         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5927         from tui_erase_data_content.
5928         (tui_data_window::display_all_data)
5929         (tui_data_window::refresh_all)
5930         (tui_data_window::do_scroll_vertical): Update.
5931         * tui/tui-regs.c (tui_show_registers): Update.
5932         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5933         New method.
5934
5935 2019-07-17  Tom Tromey  <tom@tromey.com>
5936
5937         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5938         declare.
5939         * tui/tui-windata.c
5940         (tui_data_window::delete_data_content_windows): Rename from
5941         tui_delete_data_content_windows.
5942         (tui_data_window::display_all_data)
5943         (tui_data_window::do_scroll_vertical): Update.
5944         * tui/tui-data.h (struct tui_data_window)
5945         <delete_data_content_windows>: New method.
5946
5947 2019-07-17  Tom Tromey  <tom@tromey.com>
5948
5949         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5950         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5951
5952 2019-07-17  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5955         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5956         from tui_display_all_data.
5957         * tui/tui-win.c
5958         (tui_data_window::do_make_visible_with_new_height): Update.
5959         * tui/tui-regs.c (tui_show_registers): Update.
5960         * tui/tui-layout.c (tui_set_layout): Update.
5961         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5962         method.
5963
5964 2019-07-17  Tom Tromey  <tom@tromey.com>
5965
5966         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5967         * tui/tui-windata.c (tui_display_data_from): Remove.
5968         (tui_data_window::refresh_all): Update.
5969
5970 2019-07-17  Tom Tromey  <tom@tromey.com>
5971
5972         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5973         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5974         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5975         tui_display_registers_from_line.
5976         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5977         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5978         "force_display" parameter.
5979
5980 2019-07-17  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5983         declare.
5984         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5985         Rename from tui_first_reg_element_no_inline.
5986         (tui_display_reg_element_at_line)
5987         (tui_display_registers_from_line): Update.
5988         * tui/tui-data.h (struct tui_data_window)
5989         <first_reg_element_no_inline>: New method.
5990
5991 2019-07-17  Tom Tromey  <tom@tromey.com>
5992
5993         * tui/tui-windata.c (tui_display_data_from)
5994         (tui_data_window::do_scroll_vertical): Update.
5995         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5996         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5997         Rename from tui_line_from_reg_element_no.
5998         (tui_display_registers_from_line): Update.
5999         * tui/tui-data.h (struct tui_data_window)
6000         <line_from_reg_element_no>: New method.
6001
6002 2019-07-17  Tom Tromey  <tom@tromey.com>
6003
6004         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6005         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6006         tui_last_regs_line_no.
6007         (tui_display_reg_element_at_line)
6008         (tui_display_registers_from_line): Update.
6009         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6010         method.
6011
6012 2019-07-17  Tom Tromey  <tom@tromey.com>
6013
6014         PR tui/24722:
6015         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6016         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6017         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6018         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6019         (tui_update_breakpoint_info): Likewise.
6020         * tui/tui-hooks.c (tui_event_create_breakpoint)
6021         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6022         Update.
6023
6024 2019-07-17  Tom Tromey  <tom@tromey.com>
6025
6026         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6027
6028 2019-07-17  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-winsource.c (tui_update_source_window_as_is)
6031         (tui_update_source_windows_with_addr): Update.
6032         * tui/tui-source.h (tui_set_source_content)
6033         (tui_show_symtab_source): Add "win_info" parameter.
6034         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6035         parameter.
6036         (tui_show_symtab_source): Likewise.
6037
6038 2019-07-17  Tom Tromey  <tom@tromey.com>
6039
6040         * tui/tui-wingeneral.c
6041         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6042
6043 2019-07-17  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6046         (struct tui_cmd_window) <can_scroll>: New method.
6047         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6048         method.
6049
6050 2019-07-17  Tom Tromey  <tromey@adacore.com>
6051
6052         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6053         do_field_signed>: Rename.  Change type of "value".
6054         * ui-out.c (ui_out::field_signed): Rename from field_int.
6055         Change type of "value".
6056         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6057         type of "value".
6058         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6059         do_field_int.  Change type of "value".
6060         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6061         do_field_int.  Change type of "value".
6062         * tracepoint.c (trace_status_mi, tfind_1)
6063         (print_one_static_tracepoint_marker): Update.
6064         * thread.c (print_thread_info_1, print_selected_thread_frame):
6065         Update.
6066         * stack.c (print_frame, print_frame_info): Update.
6067         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6068         Update.
6069         * source.c (print_source_lines_base): Update.
6070         * skip.c (info_skip_command): Update.
6071         * record-btrace.c (btrace_ui_out_decode_error)
6072         (btrace_call_history_src_line): Update.
6073         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6074         Update.
6075         * progspace.c (print_program_space): Update.
6076         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6077         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6078         do_field_int.  Change type of "value".
6079         * mi/mi-out.c (mi_ui_out::do_table_begin)
6080         (mi_ui_out::do_table_header): Update.
6081         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6082         type of "value".
6083         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6084         (mi_cmd_data_list_changed_registers, output_register)
6085         (mi_cmd_data_read_memory, mi_load_progress)
6086         (mi_cmd_trace_frame_collected): Update.
6087         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6088         Update.
6089         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6090         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6091         (mi_cmd_var_list_children, varobj_update_one): Update.
6092         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6093         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6095         * inferior.c (print_inferior): Update.
6096         * gdb_bfd.c (print_one_bfd): Update.
6097         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6098         Update.
6099         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6100         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6101         do_field_int.  Change type of "value".
6102         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6103         do_field_int.  Change type of "value".
6104         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6105         (print_one_breakpoint_location, print_it_catch_fork)
6106         (print_one_catch_fork, print_it_catch_vfork)
6107         (print_one_catch_vfork, print_it_catch_solib)
6108         (print_it_catch_exec, print_it_ranged_breakpoint)
6109         (print_mention_watchpoint, print_mention_masked_watchpoint)
6110         (bkpt_print_it, update_static_tracepoint): Update.
6111         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6112         * break-catch-syscall.c (print_it_catch_syscall): Update.
6113         * ada-tasks.c (print_ada_task_info): Update.
6114         * ada-lang.c (print_it_exception, print_mention_exception):
6115         Update.
6116
6117 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6118
6119         PR breakpoints/24541
6120         * gdbarch.c: Regenerate.
6121         * gdbarch.h: Regenerate.
6122         * gdbarch.sh: Adjust return type and parameter types for
6123         'stap_adjust_register'.
6124         (i386_stap_adjust_register): Adjust signature and return new
6125         register name.
6126         * stap-probe.c (stap_parse_register_operand): Adjust use of
6127         'gdbarch_stap_adjust_register'.
6128
6129 2019-07-17  Tom Tromey  <tromey@adacore.com>
6130
6131         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6132         declare VEC.
6133         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6134         std::vector.
6135         (struct s390_process_info): Add initializers.
6136         (s390_add_process): Use new.
6137         (s390_linux_nat_target::low_forget_process): Use delete.
6138         (s390_linux_nat_target::low_new_fork)
6139         (s390_linux_nat_target::stopped_by_watchpoint)
6140         (s390_linux_nat_target::low_prepare_to_resume)
6141         (s390_linux_nat_target::insert_watchpoint)
6142         (s390_linux_nat_target::insert_hw_breakpoint)
6143         (s390_linux_nat_target::remove_watchpoint)
6144         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6145
6146 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6147
6148         * aarch64-fbsd-nat.c: Include regcache.h.
6149         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6150         argument.
6151         (aarch64_fbsd_nat_target::fetch_registers)
6152         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6153         variable.
6154         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6155
6156 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6157
6158         * fbsd-nat.c: Include gdbarch.h.
6159
6160 2019-07-15  Tom Tromey  <tromey@adacore.com>
6161
6162         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6163
6164 2019-07-15  Tom Tromey  <tromey@adacore.com>
6165
6166         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6167         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6168         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6169         * cli-out.c (cli_ui_out::do_field_int): New method.
6170         * ui-out.c (ui_out::field_unsigned): New method.
6171         * symfile.c (generic_load): Use field_unsigned.
6172         (print_transfer_performance): Likewise.
6173         * record-btrace.c (ui_out_field_uint): Remove.
6174         (btrace_call_history_insn_range, btrace_call_history): Use
6175         field_unsigned.
6176         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6177         field_unsigned.
6178         * ui-out.h (class ui_out) <field_unsigned>: New method.
6179         <do_field_unsigned>: Likewise.
6180
6181 2019-07-15  Tom Tromey  <tromey@adacore.com>
6182
6183         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6184         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6185         * target.c (flash_erase_command): Use field_string.
6186         * infrun.c (print_signal_received_reason): Use field_string.
6187         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6188         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6189         field_string.
6190         * ada-tasks.c (print_ada_task_info): Use field_string.
6191
6192 2019-07-15  Tom Tromey  <tromey@adacore.com>
6193
6194         * target.c (flash_erase_command): Use field_core_addr.
6195         * symfile.c (generic_load): Use field_core_addr.
6196         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6197         Use field_core_addr.
6198         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6199         field_core_addr.
6200
6201 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6204         value if its desired type is smaller than a CORE_ADDR and signed.
6205
6206 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6209         of changes to field names, and use new is_reference field to
6210         decide if a property is a reference or not.
6211         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6212         field.
6213         (struct dwarf2_property_baton): Update header comment, rename
6214         'referenced_type' to 'property_type' and update comments.
6215         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6216         default property type, store in property baton, update to take
6217         accound of renamed field.
6218         (read_func_scope): Update call to attr_to_dynamic_prop.
6219         (read_array_type): Likewise.
6220         (dwarf2_per_cu_addr_sized_int_type): New function.
6221         (read_subrange_index_type): Move type finding code to
6222         dwarf2_per_cu_addr_sized_int_type.
6223         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6224         (dwarf2_per_cu_addr_type): New function.
6225         (set_die_type): Update calls to attr_to_dynamic_prop.
6226
6227 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * dwarf2read.c (read_subrange_index_type): New function.
6230         (read_subrange_type): Move code into new function and call it.
6231         * gdbtypes.c (create_range_type): Add some asserts.
6232
6233 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6236         update return statements.
6237         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6238         declaration, and update comment to match.
6239         * gdbtypes.c (resolve_dynamic_array): Update call to
6240         dwarf2_evaluate_property to match new return type.
6241
6242 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * valarith.c (value_subscripted_rvalue): Change lowerbound
6245         parameter type from int to LONGEST.
6246         * value.h (value_subscripted_rvalue): Likewise in declaration.
6247
6248 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * cli/cli-utils.c (info_print_command_completer): New function.
6251         * cli/cli-utils.h: Add 'completer.h' include, and forward
6252         declaration for 'struct cmd_list_element'.
6253         (info_print_command_completer): Declare.
6254         * stack.c (_initialize_stack): Add completer for 'info locals' and
6255         'info args'.
6256         * symtab.c (_initialize_symtab): Add completer for 'info
6257         variables' and 'info functions'.
6258         * NEWS: Mention completion for additional info commands.
6259
6260 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * cli/cli-utils.c (extract_info_print_args): Delete.
6263         (extract_arg_maybe_quoted): Delete.
6264         (info_print_options_defs): New variable.
6265         (make_info_print_options_def_group): New function.
6266         (extract_info_print_options): Define new function.
6267         * cli/cli-utils.h (extract_info_print_args): Delete.
6268         (struct info_print_options): New structure.
6269         (extract_info_print_options): Declare new function.
6270         * stack.c (info_locals_command): Update to use new
6271         extract_info_print_options, also add a header comment.
6272         (info_args_command): Likewise.
6273         * symtab.c (info_variables_command): Likewise.
6274         (info_functions_command): Likewise.
6275
6276 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6279         to extract string arguments.
6280         * common/common-utils.c (extract_string_maybe_quoted): New function.
6281         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6282
6283 2019-07-11  Tom Tromey  <tromey@adacore.com>
6284
6285         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6286         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6287         * top.h (gdbinit): Don't declare.
6288         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6289         into...
6290         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6291         * top.c (gdb_init): Don't call init_cli_cmds.
6292         (gdbinit): Remove.
6293         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6294
6295 2019-07-11  Tom Tromey  <tromey@adacore.com>
6296
6297         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6298         after it has been moved.
6299
6300 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6301
6302         * valops.c (value_must_coerce_to_target): Change return type to
6303         bool.
6304         * value.h (value_must_coerce_to_target): Likewise.
6305
6306 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6307
6308         * breakpoint.c (is_hardware_watchpoint): Remove
6309         forward-declaration.
6310         (is_masked_watchpoint): Change return type to bool.
6311         (is_tracepoint): Likewise.
6312         (is_breakpoint): Likewise.
6313         (is_hardware_watchpoint): Likewise.
6314         (is_watchpoint): Likewise.
6315         (is_no_memory_software_watchpoint): Likewise.
6316         (is_catchpoint): Likewise.
6317         (breakpoint_1): Make FILTER parameter's return type bool.
6318         is_masked_watchpoint): Change return type to bool.
6319         (save_breakpoints): Make FILTER parameter's return type bool.
6320         * breakpoint.h (is_breakpoint): Change return type to bool.
6321         (is_watchpoint): Likewise.
6322         (is_catchpoint): Likewise.
6323         (is_tracepoint): Likewise.
6324
6325 2019-07-10  Tom Tromey  <tom@tromey.com>
6326
6327         * defs.h: Don't include gdbarch.h.
6328         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6329         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6330         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6331         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6332         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6333         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6334         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6335         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6336         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6337         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6338         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6339         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6340         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6341         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6342         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6343         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6344         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6345         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6346         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6347         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6348         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6349         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6350         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6351         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6352         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6353         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6354         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6355
6356 2019-07-10  Tom Tromey  <tromey@adacore.com>
6357
6358         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6359         * breakpoint.c (init_ada_exception_breakpoint): Register as
6360         bp_catchpoint.
6361         (print_one_breakpoint_location, print_one_breakpoint): Use
6362         is_ada_exception_catchpoint.
6363         * ada-lang.c (class ada_catchpoint_location): Pass
6364         bp_loc_software_breakpoint to bp_location constructor.
6365         (is_ada_exception_catchpoint): New function.
6366
6367 2019-07-10  Tom Tromey  <tromey@adacore.com>
6368
6369         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6370         VEC.
6371         (struct arm_exidx_entry): New method operator<.
6372         (struct arm_exidx_data) <section_maps>: Change type.
6373         (arm_exidx_data_free): Remove.
6374         (arm_exidx_data_key): Change type.  Move lower.
6375         (arm_exidx_new_objfile): Update.
6376         (arm_compare_exidx_entries): Remove.
6377         (arm_find_exidx_entry, _initialize_arm_tdep)
6378
6379 2019-07-10  Tom Tromey  <tromey@adacore.com>
6380
6381         * solib-spu.c (ocl_program_data_key): Change type.
6382         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6383         Update.
6384
6385 2019-07-10  Tom Tromey  <tromey@adacore.com>
6386
6387         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6388         (struct solib_aix_inferior_data) <library_list>: Change type.
6389         (solib_aix_inferior_data_handle): Change type.
6390         (get_solib_aix_inferior_data): Update.
6391         (solib_aix_free_library_list): Remove.
6392         (library_list_start_library): Update.
6393         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6394         return type.
6395         (solib_aix_get_library_list)
6396         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6397         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6398
6399 2019-07-10  Tom Tromey  <tromey@adacore.com>
6400
6401         * solib-dsbt.c (struct dsbt_info): Add initializers.
6402         (solib_dsbt_pspace_data): Change type.
6403         (dsbt_pspace_data_cleanup): Remove.
6404         (get_dsbt_info, _initialize_dsbt_solib): Update.
6405
6406 2019-07-10  Tom Tromey  <tromey@adacore.com>
6407
6408         * spu-tdep.c (spu_overlay_data): Change type.
6409         (spu_get_overlay_table, spu_overlay_new_objfile)
6410         (_initialize_spu_tdep): Update.
6411
6412 2019-07-10  Tom Tromey  <tromey@adacore.com>
6413
6414         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6415         destructor.
6416         (dbx_objfile_data_key): Change type and declare later.
6417         (DBX_SYMFILE_INFO): Rewrite.
6418         * dbxread.c (dbx_objfile_data_key): Change type.
6419         (dbx_symfile_init): Update.
6420         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6421         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6422         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6423
6424 2019-07-10  Tom Tromey  <tromey@adacore.com>
6425
6426         * jit.c (jit_program_space_key): Change type.  Move lower.
6427         (get_jit_program_space_data): Update.
6428         (jit_program_space_data_cleanup): Remove.
6429         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6430         Update.
6431         (struct jit_program_space_data): Add initializers.
6432
6433 2019-07-10  Tom Tromey  <tromey@adacore.com>
6434
6435         * solib-darwin.c (struct darwin_info): Add initializers.
6436         (solib_darwin_pspace_data): Change type.
6437         (darwin_pspace_data_cleanup): Remove.
6438         (get_darwin_info, _initialize_darwin_solib): Update.
6439
6440 2019-07-10  Tom Tromey  <tromey@adacore.com>
6441
6442         * remote-sim.c (struct sim_inferior_data): Add initializers,
6443         constructor, and destructor.
6444         (sim_inferior_data_key): Change type.  Move lower.
6445         (check_for_duplicate_sim_descriptor): Update.
6446         (get_sim_inferior_data): Use new.  Update.
6447         (~sim_inferior_data_cleanup): Rename from
6448         sim_inferior_data_cleanup.  Simplify.
6449         (gdbsim_close_inferior, simulator_command)
6450         (sim_command_completer, _initialize_remote_sim): Update.
6451         (next_pid, INITIAL_PID): Move earlier.
6452
6453 2019-07-10  Tom Tromey  <tromey@adacore.com>
6454
6455         * python/python-internal.h (create_thread_object): Return
6456         gdbpy_ref.
6457         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6458         * python/py-inferior.c (struct threadlist_entry): Add
6459         constructor.
6460         <thread_obj>: Now a gdbpy_ref.
6461         (thread_to_thread_object): Update.
6462         (add_thread_object): Use new.
6463         (delete_thread_object): Use delete.
6464         (infpy_threads): Update.
6465         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6466         GIL.
6467
6468 2019-07-10  Tom Tromey  <tromey@adacore.com>
6469
6470         * valops.c (value_cast): Specialize error message for Ada.
6471
6472 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6473
6474         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6475
6476 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6477
6478         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6479         bpstat_should_step): Return bool, adjust comments.
6480         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6481         bpstat_should_step): Likewise.
6482
6483 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6484
6485         * features/Makefile: Use feature target descriptions for Arm.
6486         * features/arm/arm-core.c: Generate new file.
6487         * features/arm/arm-fpa.c: Likewise.
6488         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6489         * features/arm/arm-m-profile.c: Likewise.
6490         * features/arm/arm-vfpv2.c: Likewise.
6491         * features/arm/arm-vfpv3.c: Likewise.
6492         * features/arm/xscale-iwmmxt.c: Likewise.
6493         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6494
6495 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6496
6497         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6498         ptrace earlier.
6499
6500 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6501
6502         * features/aarch64-pauth.c: Regenerate.
6503
6504 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6505
6506         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6507         bool.
6508         (bpstat_what): Use false instead of 0.
6509
6510 2019-07-09  Pedro Alves  <palves@redhat.com>
6511
6512         * break-catch-throw.c (is_exception_catchpoint): New.
6513         * breakpoint.c (print_one_breakpoint_location): New parameter
6514         'raw_loc'.  Handle it.  Use
6515         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6516         looking at the breakpoint's type.
6517         (print_one_breakpoint): If handling "maint info breakpoints", also
6518         print locations of exception catchpoints.
6519         * breakpoint.h (is_exception_catchpoint): Declare.
6520
6521 2019-07-09  Pedro Alves  <palves@redhat.com>
6522
6523         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6524         "addr" field.
6525         (allocate_location_exception_catchpoint): New.
6526         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6527         (initialize_throw_catchpoint_ops): Install
6528         allocate_location_exception_catchpoint as allocate_location
6529         method.
6530         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6531         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6532         bp_loc_other.
6533         (breakpoint_address_is_meaningful): Delete.
6534         (bl_address_is_meaningful): New.
6535         (breakpoint_locations_match): Adjust comment.
6536         (bp_location_from_bp_type): New, factored out of...
6537         (bp_location::bp_location(breakpoint *)): ... this.
6538         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6539         factored out of...
6540         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6541         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6542         breakpoint_address_is_meaningful.
6543         (bp_locations_compare): Adjust comment.
6544         (update_global_location_list): Use bl_address_is_meaningful
6545         instead of breakpoint_address_is_meaningful.
6546         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6547         explicit.
6548         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6549         * python/py-breakpoint.c (bppy_get_location): No longer check
6550         whether location is null.
6551
6552 2019-07-09  Pedro Alves  <palves@redhat.com>
6553
6554         PR c++/15468
6555         * breakpoint.c (print_one_breakpoint_location): Remove
6556         single-location assert.
6557
6558 2019-07-09  Tom Tromey  <tom@tromey.com>
6559
6560         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6561         * configure: Rebuild.
6562         * configure.ac: Change common to gdbsupport.
6563         * gdbsupport: Rename from common.
6564         * acinclude.m4: Change common to gdbsupport.
6565         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6566         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6567         gdbsupport.
6568         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6569         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6570         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6571         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6572         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6573         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6574         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6575         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6576         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6577         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6578         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6579         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6580         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6581         coff-pe-read.c, command.h, compile/compile-c-support.c,
6582         compile/compile-c.h, compile/compile-cplus-symbols.c,
6583         compile/compile-cplus-types.c, compile/compile-cplus.h,
6584         compile/compile-loc2c.c, compile/compile.c, completer.c,
6585         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6586         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6587         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6588         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6589         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6590         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6591         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6592         features/aarch64-core.c, features/aarch64-fpu.c,
6593         features/aarch64-pauth.c, features/aarch64-sve.c,
6594         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6595         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6596         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6597         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6598         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6599         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6600         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6601         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6602         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6603         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6604         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6605         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6606         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6607         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6608         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6609         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6610         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6611         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6612         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6613         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6614         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6615         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6616         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6617         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6618         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6619         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6620         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6621         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6622         minsyms.c, mips-linux-tdep.c, namespace.h,
6623         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6624         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6625         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6626         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6627         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6628         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6629         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6630         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6631         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6632         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6633         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6634         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6635         procfs.c, producer.c, progspace.h, psymtab.h,
6636         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6637         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6638         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6639         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6640         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6641         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6642         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6643         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6644         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6645         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6646         target-memory.c, target.c, target.h, target/waitstatus.c,
6647         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6648         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6649         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6650         unittests/array-view-selftests.c,
6651         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6652         unittests/common-utils-selftests.c,
6653         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6654         unittests/format_pieces-selftests.c,
6655         unittests/function-view-selftests.c,
6656         unittests/lookup_name_info-selftests.c,
6657         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6658         unittests/mkdir-recursive-selftests.c,
6659         unittests/observable-selftests.c,
6660         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6661         unittests/parse-connection-spec-selftests.c,
6662         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6663         unittests/scoped_fd-selftests.c,
6664         unittests/scoped_mmap-selftests.c,
6665         unittests/scoped_restore-selftests.c,
6666         unittests/string_view-selftests.c, unittests/style-selftests.c,
6667         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6668         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6669         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6670         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6671         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6672         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6673
6674 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6675
6676         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6677         bool value.
6678         (decode_digits_ordinary): Set explicit_line field in sal.
6679         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6680         symtab_and_line that was set on an explicit line number in
6681         assembler code.  Do always update the recorded symtab and line if
6682         we do skip the prologue.
6683
6684 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * breakpoint.c (set_breakpoint_location_function): Remove
6687         explicit_loc parameter.
6688         (momentary_breakpoint_from_master): Update call to
6689         set_breakpoint_location_function.
6690         (add_location_to_breakpoint): Likewise.
6691
6692 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6695         required features based on default bfd type when no specific bfd
6696         is present.
6697
6698 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6699
6700         * NEWS: Mention that GDB printf and eval commands can now print
6701         C-style and Ada-style convenience var strings without
6702         calling the inferior.
6703         * printcmd.c (printf_c_string): Locally print GDB internal var
6704         instead of transiting via the inferior.
6705         (printf_wide_c_string): Likewise.
6706
6707 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6708
6709         PR breakpoints/25011
6710         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6711
6712 2019-07-04  Tom Tromey  <tom@tromey.com>
6713
6714         PR tui/24724:
6715         * tui/tui-winsource.c (tui_clear_source_content): Update.
6716         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6717         (tui_update_breakpoint_info): Update.
6718         (tui_set_exec_info_content): Update.
6719         * tui/tui-source.c (tui_set_source_content_nil): Update.
6720         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6721         has_break.
6722         * tui/tui-data.h (enum tui_bp_flag): New.
6723         (tui_bp_flags): New enum flags type.
6724         (struct tui_source_element) <break_mode>: Change type.  Rename
6725         from has_break.
6726         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6727         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6728         constants.
6729         * tui/tui-winsource.h: Fix comment.
6730
6731 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6732
6733         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6734         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6735         (store_fpregs_to_thread)
6736         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6737         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6738         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6739         (IWMMXT_REGS_SIZE): Add define.
6740         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6741         (fetch_vfp_regs, store_vfp_regs)
6742         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6743         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6744
6745 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6746
6747         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6748         defines.
6749         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6750         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6751         (ARM_INT_REGISTER_SIZE): ...to this.
6752         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6753         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6754         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6755         (arm_linux_collect_gregset, supply_nwfpe_register)
6756         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6757         defines.
6758         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6759         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6760         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6761         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6762         (arm_return_in_memory, arm_store_return_value)
6763         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6764         (arm_record_ld_st_multiple): Likewise.
6765         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6766         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6767
6768 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6769
6770         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6771         AARCH64_DISPLACED_MODIFIED_INSNS.
6772         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6773         (aarch64_displaced_step_copy_insn): Likewise.
6774         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6775         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6776         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6777         ARM_DISPLACED_MODIFIED_INSNS.
6778         * arm-tdep.c (arm_gdbarch_init): Likewise.
6779         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6780         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6781         (struct arm_displaced_step_closure): Use
6782         ARM_DISPLACED_MODIFIED_INSNS.
6783
6784 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6785
6786         * features/Makefile: Remove unused xml files.
6787         * features/aarch64.xml: Remove.
6788         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6789         * features/i386/amd64-avx-avx512.xml: Remove.
6790         * features/i386/amd64-avx-linux.xml: Remove.
6791         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6792         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6793         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6794         * features/i386/amd64-avx-mpx.xml: Remove.
6795         * features/i386/amd64-avx.xml: Remove.
6796         * features/i386/amd64-linux.xml: Remove.
6797         * features/i386/amd64-mpx-linux.xml: Remove.
6798         * features/i386/amd64-mpx.xml: Remove.
6799         * features/i386/amd64.xml: Remove.
6800         * features/i386/i386-avx-avx512-linux.xml: Remove.
6801         * features/i386/i386-avx-avx512.xml: Remove.
6802         * features/i386/i386-avx-linux.xml: Remove.
6803         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6804         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6805         * features/i386/i386-avx-mpx-linux.xml: Remove.
6806         * features/i386/i386-avx-mpx.xml: Remove.
6807         * features/i386/i386-avx.xml: Remove.
6808         * features/i386/i386-linux.xml: Remove.
6809         * features/i386/i386-mmx-linux.xml: Remove.
6810         * features/i386/i386-mmx.xml: Remove.
6811         * features/i386/i386-mpx-linux.xml: Remove.
6812         * features/i386/i386-mpx.xml: Remove.
6813         * features/i386/i386.xml: Remove.
6814         * features/i386/x32-avx-avx512-linux.xml: Remove.
6815         * features/i386/x32-avx-linux.xml: Remove.
6816         * features/i386/x32-linux.xml: Remove.
6817
6818 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6819
6820         * regformats/aarch64.dat: Remove.
6821         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6822         * regformats/i386/amd64-avx-linux.dat: Remove.
6823         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6824         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6825         * regformats/i386/amd64-linux.dat: Remove.
6826         * regformats/i386/amd64-mpx-linux.dat: Remove.
6827         * regformats/i386/amd64.dat: Remove.
6828         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6829         * regformats/i386/i386-avx-linux.dat: Remove.
6830         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6831         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6832         * regformats/i386/i386-linux.dat: Remove.
6833         * regformats/i386/i386-mmx-linux.dat: Remove.
6834         * regformats/i386/i386-mpx-linux.dat: Remove.
6835         * regformats/i386/i386.dat: Remove.
6836         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6837         * regformats/i386/x32-avx-linux.dat: Remove.
6838         * regformats/i386/x32-linux.dat: Remove.
6839
6840 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6841
6842         * aarch64-tdep.c: Remove xml self tests.
6843         * amd64-linux-tdep.c: Likewise.
6844         * amd64-tdep.c: Likewise.
6845         * i386-linux-tdep.c: Likewise.
6846         * i386-tdep.c: Likewise.
6847
6848 2019-07-03  Pedro Alves  <palves@redhat.com>
6849
6850         PR cli/24732
6851         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6852         (pipe_cmd_option_defs): New.
6853         (make_pipe_cmd_options_def_group): New.
6854         (pipe_command): Use gdb::option::process_options.
6855         (pipe_command_completer): New function.
6856         (_initialize_cli_cmds): Install completer for "pipe" command.
6857
6858 2019-07-03  Pedro Alves  <palves@redhat.com>
6859
6860         * cli/cli-option.c (union option_value) <string>: New field.
6861         (struct option_def_and_value): Add ctor, move ctor, dtor and
6862         use DISABLE_COPY_AND_ASSIGN.
6863         (option_def_and_value::clear_value): New.
6864         (parse_option, save_option_value_in_ctx, get_val_type_str)
6865         (add_setshow_cmds_for_options): Handle var_string.
6866         * cli-option.h (union option_def::var_address) <string>: New
6867         field.
6868         (struct string_option_def): New.
6869         * maint-test-options.c (struct test_options_opts): Add default
6870         ctor and use DISABLE_COPY_AND_ASSIGN.
6871         <string_opt>: New field.
6872         (test_options_opts::~test_options_opts): New.
6873         (test_options_opts::dump): Also dump "-string".
6874         (test_options_option_defs): Install "string.
6875
6876 2019-07-03  Pedro Alves  <palves@redhat.com>
6877
6878         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6879         option_value with a null enumeration.
6880         (complete_options): Save the option values in the context.
6881         (save_option_value_in_ctx): New, factored out from ...
6882         (process_options): ... here.
6883         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6884         of the function.
6885         * maint-test-options.c (test_options_opts::dump): New, factored
6886         out from ...
6887         (maintenance_test_options_command_mode): ... here.
6888         (maintenance_test_options_command_completion_result): Delete.
6889         (maintenance_test_options_command_completion_text): Update
6890         comment.
6891         (maintenance_show_test_options_completion_result): Change
6892         prototype.  Just print
6893         maintenance_test_options_command_completion_text.
6894         (save_completion_result): New.
6895         (maintenance_test_options_completer_mode): Pass options context to
6896         complete_options, and then save a dump.
6897         (_initialize_maint_test_options): Use add_cmd to install "maint
6898         show test-options-completion-result".
6899
6900 2019-07-03  Pedro Alves  <palves@redhat.com>
6901
6902         * NEWS (New commands): Mention "with" and "maint with".
6903         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6904         (with_command, with_command_completer): New.
6905         (pipe_command): Adjust to new repeat_previous
6906         interface.
6907         (_initialize_cli_cmds): Install the "with" command and its "w"
6908         alias.
6909         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6910         declarations.
6911         * cli/cli-setshow.c (parse_cli_var_uinteger)
6912         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6913         argument strings for all var_types.
6914         (get_setshow_command_value_string): New, factored out from ...
6915         (do_show_command): ... this.
6916         * cli/cli-setshow.h: Include <string>.
6917         (get_setshow_command_value_string): Declare.
6918         * command.h (repeat_previous): Now returns const char *.  Adjust
6919         comment.
6920         * maint.c: Include "cli/cli-cmds.h".
6921         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6922         (_initialize_maint_cmds): Register the "maintenance with" command.
6923         * top.c (repeat_previous): Move bits from pipe_command here:
6924         Return the saved command line, if any; error out if there's no
6925         command to relaunch.
6926
6927 2019-07-03  Pedro Alves  <palves@redhat.com>
6928
6929         * NEWS (New commands): Mention "maint set/show test-settings"
6930         instead of "maint test-settings".
6931         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6932         (maintenance_test_settings_set_list): Rename to ...
6933         (maintenance_set_test_settings_list): ... this.
6934         (maintenance_test_settings_show_list): Rename to  ...
6935         (maintenance_show_test_settings_list): ... this.
6936         (maintenance_test_settings_cmd): Delete.
6937         (maintenance_test_settings_set_cmd): ...
6938         (maintenance_set_test_settings_cmd): ... this.
6939         (maintenance_test_settings_show_cmd): ...
6940         (maintenance_show_test_settings_cmd): ... this.
6941         (maintenance_test_settings_show_value_cmd):
6942         (maintenance_show_test_settings_value_cmd): ... this.
6943         (_initialize_maint_test_settings): No longer install the "maint
6944         test-settings" prefix command.  Rename "maint test-settings set"
6945         to "maint set test-settings", and "maint test-settings show" to
6946         "maint show test-settings".  Adjust all subcommands.
6947
6948 2019-07-03  Pedro Alves  <palves@redhat.com>
6949
6950         * maint-test-settings.c: Fix file's intro comment.  Replace all
6951         references to "test-options" with references to "test-settings",
6952         in comments.
6953
6954 2019-07-03  Pedro Alves  <palves@redhat.com>
6955
6956         * maint-test-settings.c (maintenance_test_settings_xxx)
6957         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6958         New.
6959         (maintenance_test_settings_enums): Use them.
6960         (maintenance_test_settings_enum): Default to
6961         maintenance_test_settings_xxx.
6962         (_initialize_maint_test_settings): Initialize
6963         MAINTENANCE_TEST_SETTINGS_FILENAME.
6964
6965 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6966
6967         * breakpoint.h (remove_breakpoints_inf): Change return type to
6968         void, move function documentation here.
6969         * breakpoint.c (remove_breakpoints_inf): Change return type to
6970         void, move function documentation to header.
6971
6972 2019-07-02  Pedro Alves  <palves@redhat.com>
6973
6974         * NEWS (Completion improvements): Mention "info threads".
6975         * thread.c (struct info_threads_opts, info_threads_option_defs)
6976         (make_info_threads_options_def_group): New.
6977         (info_threads_command): Use gdb::option::process_options.
6978         (info_threads_command_completer): New.
6979         (_initialize_thread): Use gdb::option::build_help to build the
6980         help text for "info threads".
6981
6982 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6983
6984         * defs.h (generic_load): Move from here...
6985         * symfile.h (generic_load): ... to here.  Rename name parameter
6986         to args.
6987         * symfile.c (generic_load): Add comment.
6988
6989 2019-07-01  Tom Tromey  <tromey@adacore.com>
6990
6991         * dwarf2read.c
6992         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6993         declaration of without_params.  Fix formatting.
6994
6995 2019-07-01  Tom Tromey  <tromey@adacore.com>
6996
6997         * ada-exp.y (find_primitive_type): Update.
6998         * ada-lang.h (ada_lookup_symbol): Update.
6999         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7000         parameter.
7001         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7002
7003 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7004
7005         PR breakpoints/24541
7006         * gdbarch.c: Regenerate.
7007         * gdbarch.h: Regenerate.
7008         * gdbarch.sh: Add 'stap_adjust_register'.
7009         * i386-tdep.c: Include '<unordered_set>'.
7010         (i386_stap_adjust_register): New function.
7011         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7012         * stap-probe.c (stap_parse_register_operand): Call
7013         'gdbarch_stap_adjust_register'.
7014
7015 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7016
7017         PR python/24742
7018         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7019         * python/python.c (do_start_initialization): Use 'xmalloc'
7020         instead of 'PyMem_Malloc'.
7021
7022 2019-06-28  Tom Tromey  <tromey@adacore.com>
7023
7024         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7025         for Ada.
7026
7027 2019-06-27  Tom Tromey  <tromey@adacore.com>
7028
7029         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7030         objfile_key.
7031         (arm_find_mapping_symbol, arm_record_special_symbol)
7032         (_initialize_arm_tdep): Update.
7033         (arm_objfile_data_free): Remove.
7034
7035 2019-06-27  Tom Tromey  <tromey@adacore.com>
7036
7037         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7038         to cp_print_static_field.
7039
7040 2019-06-26  Tom Tromey  <tromey@adacore.com>
7041
7042         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7043         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7044         declare.
7045
7046 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7047
7048         * features/aarch64-core.c (create_feature_aarch64_core):
7049         Regenerate.
7050         * features/aarch64-core.xml: Add cpsr flags.
7051
7052 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7053
7054         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7055         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7056
7057 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7058
7059         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7060         field.
7061         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7062         use.
7063         (arm_record_special_symbol): Don't insert new symbol in sorted
7064         position, push it at the end.
7065
7066 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7067
7068         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7069         (arm_mapping_symbol_s): Remove.
7070         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7071         (arm_mapping_symbol_vec): New typedef.
7072         (struct arm_per_objfile): Add constructor.
7073         <section_maps>: Change type to
7074         std::unique_ptr<arm_mapping_symbol_vec[]>.
7075         (arm_compare_mapping_symbols): Remove.
7076         (arm_find_mapping_symbol): Adjust to section_maps type change.
7077         (arm_objfile_data_free): Call delete on arm_per_objfile.
7078         (arm_record_special_symbol): Adjust to section_maps type change.
7079         Allocate arm_per_objfile with new.
7080
7081 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7082
7083         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7084         with the command prefix.
7085
7086 2019-06-25  Tom Tromey  <tom@tromey.com>
7087
7088         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7089         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7090
7091 2019-06-25  Tom Tromey  <tom@tromey.com>
7092
7093         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7094         type.
7095         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7096         protected.
7097
7098 2019-06-25  Tom Tromey  <tom@tromey.com>
7099
7100         * tui/tui-winsource.c
7101         (tui_source_window_base::set_is_exec_point_at): Add check against
7102         LOA_ADDRESS.
7103
7104 2019-06-25  Tom Tromey  <tom@tromey.com>
7105
7106         * tui/tui-source.c (tui_set_source_content): Don't check before
7107         xfree.
7108         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7109
7110 2019-06-25  Tom Tromey  <tom@tromey.com>
7111
7112         * tui/tui-winsource.h (tui_update_source_window_as_is)
7113         (tui_alloc_source_buffer, tui_line_is_displayed)
7114         (tui_addr_is_displayed): Change type of win_info.
7115         * tui/tui-winsource.c (tui_update_source_window_as_is)
7116         (tui_clear_source_content, tui_show_source_line)
7117         (tui_show_source_content, tui_source_window_base::refill)
7118         (tui_source_window_base::set_is_exec_point_at)
7119         (tui_source_window_base::set_is_exec_point_at)
7120         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7121         (tui_alloc_source_buffer, tui_line_is_displayed)
7122         (tui_addr_is_displayed): Change type of win_info.  Update.
7123         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7124         (tui_source_window_base::do_make_visible_with_new_height):
7125         Update.
7126         * tui/tui-source.c (tui_set_source_content)
7127         (tui_set_source_content_nil)
7128         (tui_source_window::do_scroll_vertical): Update.
7129         * tui/tui-layout.c (show_layout): Update.
7130         * tui/tui-disasm.c (tui_set_disassem_content)
7131         (tui_disasm_window::do_scroll_vertical): Update.
7132         * tui/tui-data.h (tui_win_content): Remove.
7133         (struct tui_gen_win_info) <content, content_size>: Remove.
7134         (struct tui_source_element): Add initializers and destructor.
7135         (union tui_which_element, struct tui_win_element): Remove.
7136         (struct tui_source_window_base) <content>: New field.
7137         (struct tui_data_window): Remove destructor.
7138         (tui_alloc_content, tui_free_win_content)
7139         (tui_free_all_source_wins_content): Don't declare.
7140         * tui/tui-data.c (tui_initialize_static_data): Update.
7141         (init_content_element, tui_alloc_content): Remove.
7142         (~tui_gen_win_info): Update.
7143         (~tui_data_window, tui_free_all_source_wins_content)
7144         (tui_free_win_content, free_content, free_content_elements):
7145         Remove.
7146
7147 2019-06-25  Tom Tromey  <tom@tromey.com>
7148
7149         * tui/tui-winsource.h (tui_clear_source_content)
7150         (tui_erase_source_content, tui_show_source_content): Change type
7151         of win_info.
7152         * tui/tui-winsource.c (tui_clear_source_content)
7153         (tui_erase_source_content, tui_show_source_content): Change type
7154         of win_info.
7155         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7156         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7157         win_info.
7158         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7159         win_info.
7160         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7161
7162 2019-06-25  Tom Tromey  <tom@tromey.com>
7163
7164         * tui/tui-winsource.c (tui_clear_source_content)
7165         (tui_source_window_base::set_is_exec_point_at): Update.
7166         * tui/tui-source.c (tui_set_source_content_nil): Update.
7167         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7168         a bool.
7169         * tui/tui-data.c (init_content_element): Update.
7170
7171 2019-06-25  Tom Tromey  <tom@tromey.com>
7172
7173         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7174         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7175         * tui/tui-layout.c (init_and_make_win): Update.
7176         * tui/tui.h (enum tui_win_type): Update.
7177         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7178         tui_win_is_auxillary.
7179         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7180         tui_win_is_auxillary.
7181
7182 2019-06-25  Tom Tromey  <tom@tromey.com>
7183
7184         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7185         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7186         (tui_delete_data_content_windows, tui_display_all_data)
7187         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7188         Update.
7189         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7190         * tui/tui-regs.c (tui_last_regs_line_no)
7191         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7192         (tui_show_registers): Update.
7193         (tui_show_register_group): Return void.  Update.
7194         (tui_display_registers_from, tui_display_reg_element_at_line)
7195         (tui_display_registers_from_line, tui_check_register_values):
7196         Update.
7197         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7198         member.
7199         (struct tui_data_window) <regs_content>: Now a std::vector.
7200         <regs_content_count>: Remove.
7201         (tui_add_content_elements, tui_free_data_content): Don't declare.
7202         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7203         (init_content_element): Remove DATA_WIN case.  Add assert.
7204         (tui_add_content_elements): Remove.
7205         (tui_data_window): Update.
7206         (tui_free_data_content): Remove.
7207         (free_content_elements): Remove DATA_WIN case.
7208
7209 2019-06-25  Tom Tromey  <tom@tromey.com>
7210
7211         * tui/tui-data.c (tui_data_item_window): Update.
7212         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7213         * tui/tui-windata.c (tui_display_all_data)
7214         (tui_display_data_from_line): Update.
7215         (tui_check_data_values): Remove.
7216         * tui/tui-regs.c (tui_show_register_group)
7217         (tui_display_reg_element_at_line): Update.
7218         * tui/tui-hooks.c (tui_register_changed)
7219         (tui_refresh_frame_and_register_information): Call
7220         tui_check_register_values.
7221         * tui/tui-data.h (struct tui_data_window) <data_content,
7222         data_content_count, data_type>: Remove.
7223         (enum tui_data_type): Remove.
7224
7225         * tui/tui-data.c (tui_data_window::clear_detail)
7226         (~tui_data_window): Update.
7227
7228 2019-06-25  Tom Tromey  <tom@tromey.com>
7229
7230         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7231         declare.
7232         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7233         Rename from tui_first_data_item_displayed.  Update.
7234         (tui_data_window::refresh_all)
7235         (tui_data_window::do_scroll_vertical): Update.
7236         * tui/tui-data.h (struct tui_data_window)
7237         <first_data_item_displayed>: Declare new method.
7238
7239 2019-06-25  Tom Tromey  <tom@tromey.com>
7240
7241         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7242         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7243         contents...
7244         (tui_initialize_static_data): ...here.
7245
7246 2019-06-25  Tom Tromey  <tom@tromey.com>
7247
7248         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7249         (tui_display_registers_from, tui_check_register_values): Update.
7250         (tui_display_register): Remove win_info parameter; update.
7251         (tui_get_register): Change type of parameters.
7252         * tui/tui-data.h (struct tui_data_element): Remove.
7253         (union tui_which_element) <data>: Remove.
7254         <data_window>: Change type.
7255         (struct tui_data_item_window): New.
7256         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7257         case.  Add assert.
7258         (~tui_data_item_window): New destructor.
7259         (free_content_elements): Remove DATA_ITEM_WIN case.
7260
7261 2019-06-25  Tom Tromey  <tom@tromey.com>
7262
7263         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7264         Remove.
7265
7266 2019-06-25  Tom Tromey  <tom@tromey.com>
7267
7268         * tui/tui-data.h (struct tui_command_element): Remove.
7269         (union tui_which_element) <command>: Remove.
7270         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7271         assert.
7272         (free_content_elements): Remove CMD_WIN case.
7273
7274 2019-06-25  Tom Tromey  <tom@tromey.com>
7275
7276         * tui/tui-layout.c (tui_set_layout): Update.
7277         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7278         * tui/tui-data.c (layout_def): Update.
7279
7280 2019-06-25  Tom Tromey  <tom@tromey.com>
7281
7282         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7283         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7284         (tui_source_window_base::set_new_height): Update.
7285         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7286         Update.
7287         (tui_set_locator_fullname, tui_set_locator_info)
7288         (tui_show_frame_info): Update.
7289         * tui/tui-source.c (tui_set_source_content)
7290         (tui_source_is_displayed): Update.
7291         * tui/tui-layout.c (show_source_disasm_command, show_data)
7292         (show_source_or_disasm_and_command): Update.
7293         * tui/tui-disasm.c (tui_set_disassem_content)
7294         (tui_get_begin_asm_address): Update.
7295         * tui/tui-data.h (struct tui_locator_element): Remove.
7296         (union tui_which_element) <locator>: Remove.
7297         (struct tui_locator_window): New.
7298         (tui_locator_win_info_ptr): Change return type.
7299         * tui/tui-data.c (_locator): Change type.
7300         (tui_locator_win_info_ptr): Change return type.
7301         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7302         (tui_alloc_content): Add assert.
7303
7304 2019-06-25  Tom Tromey  <tom@tromey.com>
7305
7306         * tui/tui-winsource.c
7307         (tui_exec_info_window::maybe_allocate_content): New method.
7308         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7309         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7310         (make_source_or_disasm_window): Add cast.
7311         * tui/tui-data.h (union tui_which_element) <simple_string>:
7312         Remove.
7313         (struct tui_source_info): New.
7314         (struct tui_source_window_base) <execution_info>: Change type.
7315         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7316         case, and add assert.
7317         (tui_alloc_content): Add assert.
7318
7319 2019-06-25  Tom Tromey  <tom@tromey.com>
7320
7321         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7322         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7323         * tui/tui-data.c (tui_alloc_win_info): Remove.
7324
7325 2019-06-25  Tom Tromey  <tom@tromey.com>
7326
7327         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7328         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7329         can_highlight.
7330
7331 2019-06-25  Tom Tromey  <tom@tromey.com>
7332
7333         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7334         make_visible_with_new_height method.
7335         (tui_win_info::make_visible_with_new_height): New method.
7336         (tui_source_window_base::do_make_visible_with_new_height)
7337         (tui_data_window::do_make_visible_with_new_height)
7338         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7339         (make_visible_with_new_height): Remove.
7340         (tui_resize_all, tui_adjust_win_heights): Use
7341         make_visible_with_new_height method.
7342         * tui/tui-data.h (struct tui_win_info)
7343         <do_make_visible_with_new_height, make_visible_with_new_height>:
7344         New methods.
7345         (struct tui_source_window_base, struct tui_data_window)
7346         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7347         methods.
7348
7349 2019-06-25  Tom Tromey  <tom@tromey.com>
7350
7351         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7352         method.
7353         (update_tab_width): Call update_tab_width method.
7354         * tui/tui-data.h (struct tui_win_info)
7355         (struct tui_source_window_base) <update_tab_width>: New methods.
7356
7357 2019-06-25  Tom Tromey  <tom@tromey.com>
7358
7359         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7360         parameter.
7361         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7362         parameter.
7363         (tui_gen_win_info::make_visible): Update.
7364         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7365         parameter.
7366         * tui/tui-data.h (enum tui_box): New enum.
7367         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7368
7369 2019-06-25  Tom Tromey  <tom@tromey.com>
7370
7371         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7372         init_and_make_win for EXEC_INFO_WIN.
7373         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7374         longer inline.
7375         (struct tui_win_info) <~tui_win_info>: Inline.
7376         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7377         Don't declare.
7378         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7379         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7380         Remove.
7381         (tui_initialize_static_data): Update.
7382         (~tui_gen_win_info): Handle more cleanup here.
7383         (~tui_source_window_base): Delete "execution_info".
7384         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7385
7386 2019-06-25  Tom Tromey  <tom@tromey.com>
7387
7388         * tui/tui-layout.c (make_command_window): Don't set
7389         can_highlight.
7390         (show_source_disasm_command): Call the reset method.
7391         (show_data): Don't set can_highlight.  Call the reset method.
7392         (tui_gen_win_info::reset): Rename from init_gen_win_info
7393         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7394         (show_source_or_disasm_and_command): Call the reset method.
7395         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7396         (struct tui_cmd_window): Set can_highlight.
7397
7398 2019-06-25  Tom Tromey  <tom@tromey.com>
7399
7400         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7401         from make_visible.
7402         (tui_make_visible, tui_make_invisible): Rewrite.
7403         (tui_win_info::make_visible): Remove.
7404         (tui_source_window_base::make_visible): Update.
7405         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7406         method.  Moved from...
7407         (struct tui_win_info) <make_visible>: ...here.
7408
7409 2019-06-25  Tom Tromey  <tom@tromey.com>
7410
7411         * tui/tui-winsource.c
7412         (tui_source_window_base::do_scroll_horizontal): Remove direction
7413         parameter.
7414         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7415         direction parameter.
7416         * tui/tui-win.c (tui_win_info::forward_scroll)
7417         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7418         (tui_win_info::right_scroll): Update.
7419         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7420         direction parameter.
7421         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7422         direction parameter.
7423         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7424         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7425         Remove direction parameter.
7426         (struct tui_source_window_base, struct tui_source_window)
7427         (struct tui_disasm_window, struct tui_data_window)
7428         (struct tui_cmd_window): Update.
7429
7430 2019-06-25  Tom Tromey  <tom@tromey.com>
7431
7432         * tui/tui-winsource.h (tui_set_exec_info_content)
7433         (tui_show_exec_info_content, tui_erase_exec_info_content)
7434         (tui_clear_exec_info_content, tui_update_exec_info): Change
7435         argument to tui_source_window_base.
7436         * tui/tui-winsource.c (tui_set_exec_info_content)
7437         (tui_show_exec_info_content, tui_erase_exec_info_content)
7438         (tui_clear_exec_info_content, tui_update_exec_info): Change
7439         argument to tui_source_window_base.
7440
7441 2019-06-25  Tom Tromey  <tom@tromey.com>
7442
7443         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7444         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7445
7446 2019-06-25  Tom Tromey  <tom@tromey.com>
7447
7448         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7449         check.
7450
7451 2019-06-25  Tom Tromey  <tom@tromey.com>
7452
7453         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7454         type to void.
7455         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7456         type to void.
7457         * tui/tui-source.c (tui_set_source_content): Update.
7458         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7459
7460 2019-06-25  Tom Tromey  <tom@tromey.com>
7461
7462         * tui/tui-win.c (window_name_completer, tui_set_focus)
7463         (tui_all_windows_info): Use name method.
7464         * tui/tui-data.h (struct tui_gen_win_info)
7465         (struct tui_source_window, struct tui_disasm_window)
7466         (struct tui_data_window, struct tui_cmd_window) <name>: New
7467         method.
7468         (tui_win_name): Don't declare.
7469         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7470         (tui_win_name): Remove.
7471
7472 2019-06-25  Tom Tromey  <tom@tromey.com>
7473
7474         * tui/tui-winsource.h (tui_update_source_window)
7475         (tui_update_source_window_as_is): Change parameter type.
7476         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7477         to be a tui_source_window_base.
7478         (tui_update_source_window_as_is): Likewise.
7479         * tui/tui-win.c (make_visible_with_new_height): Update.
7480
7481 2019-06-25  Tom Tromey  <tom@tromey.com>
7482
7483         * tui/tui-winsource.c (tui_erase_source_content)
7484         (tui_show_source_content, tui_show_exec_info_content)
7485         (tui_erase_exec_info_content): Use refresh_window method.
7486         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7487         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7488         from tui_refresh_win.
7489         (tui_data_window::refresh_window): New method.
7490         (tui_win_info::refresh, tui_source_window_base::refresh)
7491         (tui_refresh_all): Use refresh_window method.
7492         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7493         method.
7494         * tui/tui-regs.c (tui_display_register): Call refresh_window
7495         method.
7496         * tui/tui-layout.c (show_source_disasm_command)
7497         (show_source_or_disasm_and_command): Call refresh_window method.
7498         * tui/tui-data.h (struct tui_gen_win_info)
7499         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7500         New method.
7501
7502 2019-06-25  Tom Tromey  <tom@tromey.com>
7503
7504         * tui/tui.c (tui_rl_other_window, tui_enable)
7505         (tui_is_window_visible, tui_get_command_dimension): Update.
7506         * tui/tui-winsource.c (tui_update_source_window_as_is)
7507         (tui_clear_source_content, tui_erase_source_content)
7508         (tui_show_source_line, tui_source_window_base::refill)
7509         (tui_source_window_base::do_scroll_horizontal)
7510         (tui_source_window_base::set_is_exec_point_at)
7511         (tui_update_breakpoint_info, tui_set_exec_info_content)
7512         (tui_alloc_source_buffer, tui_line_is_displayed)
7513         (tui_addr_is_displayed): Update.
7514         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7515         (tui_check_and_display_highlight_if_needed)
7516         (tui_win_info::make_visible, tui_win_info::refresh)
7517         (tui_refresh_all): Update.
7518         * tui/tui-windata.c (tui_first_data_item_displayed)
7519         (tui_delete_data_content_windows, tui_erase_data_content)
7520         (tui_display_all_data, tui_data_window::refresh_all)
7521         (tui_check_data_values): Update.
7522         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7523         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7524         (tui_win_info::backward_scroll, tui_refresh_all_win)
7525         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7526         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7527         (tui_source_window_base::set_new_height)
7528         (tui_data_window::set_new_height)
7529         (make_invisible_and_set_new_height)
7530         (make_visible_with_new_height, new_height_ok)
7531         (parse_scrolling_args): Update.
7532         * tui/tui-stack.c (tui_show_frame_info): Update.
7533         * tui/tui-source.c (tui_set_source_content)
7534         (tui_set_source_content_nil, tui_source_is_displayed)
7535         (tui_source_window::do_scroll_vertical): Update.
7536         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7537         (tui_display_registers_from, tui_display_reg_element_at_line)
7538         (tui_check_register_values, tui_reg_command): Update.
7539         * tui/tui-layout.c (tui_default_win_height)
7540         (show_source_disasm_command, show_data, init_and_make_win)
7541         (show_source_or_disasm_and_command): Update.
7542         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7543         (tui_redisplay_readline, tui_mld_flush)
7544         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7545         (tui_getc): Update.
7546         * tui/tui-disasm.c (tui_set_disassem_content)
7547         (tui_disasm_window::do_scroll_vertical): Update.
7548         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7549         Now virtual.
7550         (struct tui_win_info): Derive from tui_gen_win_info.
7551         <~tui_win_info>: Mark as override.
7552         <generic>: Remove member.
7553         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7554         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7555         (~tui_data_window, ~tui_win_info)
7556         (tui_free_all_source_wins_content): Update.
7557         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7558
7559 2019-06-25  Tom Tromey  <tom@tromey.com>
7560
7561         * tui/tui-layout.c (init_and_make_win): Use new.
7562         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7563         destructor, initializers.
7564         (tui_alloc_generic_win_info): Don't declare.
7565         * tui/tui-data.c (_locator): Add argument to constructor.
7566         (source_win, disasm_win): New globals.
7567         (exec_info): Remove.
7568         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7569         Update.
7570         (tui_alloc_generic_win_info): Remove.
7571         (init_content_element): Use new.
7572         (tui_win_info::tui_win_info): Update.
7573         (free_content_elements) <case DATA_WIN>: Use delete.
7574
7575 2019-06-25  Tom Tromey  <tom@tromey.com>
7576
7577         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7578         * tui/tui-windata.c (tui_first_data_item_displayed)
7579         (tui_delete_data_content_windows): Update.
7580         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7581         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7582         (tui_display_registers_from, tui_check_register_values): Update.
7583         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7584         pointer.
7585         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7586         window.
7587         (tui_free_data_content): Update.
7588         (free_content_elements) <case DATA_WIN>: Free the window.
7589
7590 2019-06-25  Tom Tromey  <tom@tromey.com>
7591
7592         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7593         Update.
7594         * tui/tui-layout.c (make_command_window)
7595         (show_source_disasm_command, show_data, init_and_make_win)
7596         (show_source_or_disasm_and_command): Update.
7597         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7598         method.
7599         <can_highight, is_highlighted>: Now bool.
7600         (tui_set_win_highlight): Don't declare.
7601         * tui/tui-data.c (tui_set_win_highlight): Remove.
7602
7603 2019-06-25  Tom Tromey  <tom@tromey.com>
7604
7605         * tui/tui-wingeneral.c (make_visible): Remove check of window
7606         type.
7607
7608 2019-06-25  Tom Tromey  <tom@tromey.com>
7609
7610         * tui/tui-win.c (tui_win_info::max_height)
7611         (tui_cmd_window::max_height): New methods.
7612         (new_height_ok): Call max_height.
7613         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7614         <max_height>: New method.
7615
7616 2019-06-25  Tom Tromey  <tom@tromey.com>
7617
7618         * tui/tui-win.c (tui_source_window_base::set_new_height)
7619         (tui_data_window::set_new_height): New methods.
7620         (make_invisible_and_set_new_height): Call set_new_height method.
7621         * tui/tui-data.h (struct tui_win_info)
7622         (struct tui_source_window_base, struct tui_data_window)
7623         <set_new_height>: New method.
7624
7625 2019-06-25  Tom Tromey  <tom@tromey.com>
7626
7627         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7628         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7629         tui_refresh_data_win.
7630         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7631         method.
7632         (tui_refresh_all_win): Call the refresh_all method.
7633         (tui_set_focus): Likewise.
7634         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7635         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7636         Likewise.
7637
7638 2019-06-25  Tom Tromey  <tom@tromey.com>
7639
7640         * tui/tui-winsource.h (tui_refill_source_window)
7641         (tui_set_is_exec_point_at): Don't declare.
7642         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7643         (tui_source_window_base::refill): Rename from
7644         tui_refill_source_window.
7645         (tui_source_window_base::do_scroll_horizontal): Update.
7646         (tui_source_window_base::set_is_exec_point_at): Rename from
7647         tui_set_is_exec_point_at.
7648         (tui_update_all_breakpoint_info): Update.
7649         * tui/tui-stack.c (tui_show_frame_info): Update.
7650         * tui/tui-layout.c (show_data): Add cast.
7651         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7652         * tui/tui-data.h (struct tui_source_window_base) <refill,
7653         set_is_exec_point_at>: New methods.
7654         (tui_source_windows, tui_add_to_source_windows): Update types.
7655         (tui_add_to_source_windows): Remove redundant declaration.
7656         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7657         (tui_source_windows): Change return type.
7658         (tui_clear_source_windows_detail): Update.
7659         (tui_add_to_source_windows): Change type of parameter.
7660         (tui_free_all_source_wins_content): Update.
7661
7662 2019-06-25  Tom Tromey  <tom@tromey.com>
7663
7664         * tui/tui-wingeneral.c (tui_win_info::refresh)
7665         (tui_source_window_base::refresh): New methods.
7666         (tui_refresh_all): Call the refresh method.
7667         * tui/tui-data.h (struct tui_win_info)
7668         (struct tui_source_window_base) <refresh>: New method.
7669
7670 2019-06-25  Tom Tromey  <tom@tromey.com>
7671
7672         * tui/tui.h (tui_is_window_visible): Return bool.
7673         * tui/tui.c (tui_is_window_visible): Return bool.
7674         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7675         (tui_make_visible, tui_make_invisible)
7676         (tui_win_info::make_visible)
7677         (tui_source_window_base::make_visible, make_all_visible)
7678         (tui_make_all_visible, tui_make_all_invisible): Update.
7679         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7680         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7681         bool.
7682         (struct tui_win_info, struct tui_source_window_base)
7683         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7684         * tui/tui-data.c (tui_init_generic_part): Update.
7685
7686 2019-06-25  Tom Tromey  <tom@tromey.com>
7687
7688         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7689         (tui_source_window_base::make_visible): New methods.
7690         (make_all_visible): Make method call.
7691         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7692         (struct tui_source_window_base, struct tui_cmd_window): Override
7693         make_visible.
7694         (tui_win_is_source_type): Don't declare.
7695         * tui/tui-data.c (tui_win_is_source_type): Remove.
7696
7697 2019-06-25  Tom Tromey  <tom@tromey.com>
7698
7699         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7700         NULL check.
7701
7702 2019-06-25  Tom Tromey  <tom@tromey.com>
7703
7704         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7705         Inline constructor.  Add initializers for members.
7706         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7707         constructors; now inline in class.
7708
7709 2019-06-25  Tom Tromey  <tom@tromey.com>
7710
7711         * tui/tui-regs.c (tui_show_registers): Update.
7712         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7713         bool.
7714         * tui/tui-data.c (tui_data_window::clear_detail)
7715         (tui_data_window): Update.
7716
7717 2019-06-25  Tom Tromey  <tom@tromey.com>
7718
7719         * tui/tui-windata.c (tui_display_all_data)
7720         (tui_display_data_from_line, tui_display_data_from)
7721         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7722         Update.
7723         * tui/tui-regs.c (tui_last_regs_line_no)
7724         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7725         (tui_show_registers, tui_show_register_group)
7726         (tui_display_registers_from, tui_display_reg_element_at_line)
7727         (tui_display_registers_from_line, tui_check_register_values)
7728         (tui_reg_next, tui_reg_prev): Update.
7729         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7730         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7731         tui_data_window.
7732         (struct tui_win_info) <detail>: Remove.  Add new fields from
7733         tui_data_info.
7734         (TUI_DATA_WIN): Add cast.
7735         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7736         (~tui_data_window): Simplify.
7737
7738 2019-06-25  Tom Tromey  <tom@tromey.com>
7739
7740         * tui/tui-layout.c (show_source_disasm_command)
7741         (show_source_or_disasm_and_command): Update.
7742         * tui/tui-io.c (update_cmdwin_start_line)
7743         (tui_redisplay_readline): Update.
7744         * tui/tui-data.h (struct tui_command_info): Remove.
7745         (struct tui_win_info) <detail>: Remove command_info member.
7746         (struct tui_data_window) <start_line>: New member, from
7747         tui_command_info.
7748         (TUI_CMD_WIN): Add casts.
7749
7750 2019-06-25  Tom Tromey  <tom@tromey.com>
7751
7752         * tui/tui-winsource.c (tui_update_source_window)
7753         (tui_refill_source_window)
7754         (tui_source_window_base::do_scroll_horizontal)
7755         (tui_update_breakpoint_info, tui_set_exec_info_content)
7756         (tui_show_exec_info_content, tui_erase_exec_info_content)
7757         (tui_clear_exec_info_content): Update.
7758         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7759         Update.
7760         * tui/tui-win.c (make_invisible_and_set_new_height)
7761         (make_visible_with_new_height): Update.
7762         * tui/tui-source.c (tui_set_source_content)
7763         (tui_show_symtab_source): Update.
7764         * tui/tui-layout.c (extract_display_start_addr)
7765         (show_source_disasm_command, show_data)
7766         (make_source_or_disasm_window)
7767         (show_source_or_disasm_and_command): Update.
7768         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7769         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7770         "gdbarch".
7771         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7772         to tui_source_window_base.
7773         (struct tui_win_info) <detail>: Remove source_info member.
7774         (struct tui_source_window_base) <has_locator>: Inline.
7775         Move contents from tui_source_info; rename has_locator member to
7776         m_has_locator.
7777         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7778         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7779         header file.
7780         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7781         Simplify.
7782         (tui_free_all_source_wins_content): Cast to
7783         tui_source_window_base.
7784
7785 2019-06-25  Tom Tromey  <tom@tromey.com>
7786
7787         * tui/tui-win.c (make_invisible_and_set_new_height)
7788         (make_visible_with_new_height): Call has_locator method.
7789         * tui/tui-layout.c (show_source_disasm_command, show_data)
7790         (show_source_or_disasm_and_command): Update for bool change.
7791         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7792         (tui_win_info) <has_locator>: New method.
7793         (struct tui_source_window_base) <has_locator>: New method.
7794         (tui_win_has_locator): Don't declare.
7795         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7796         from tui_win_has_locator.
7797         (tui_source_window_base): Use false, not FALSE.
7798
7799 2019-06-25  Tom Tromey  <tom@tromey.com>
7800
7801         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7802         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7803         clear_detail method directly.
7804         (tui_clear_win_detail): Remove.
7805
7806 2019-06-25  Tom Tromey  <tom@tromey.com>
7807
7808         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7809         "this", not TUI_DISASM_WIN.
7810
7811 2019-06-25  Tom Tromey  <tom@tromey.com>
7812
7813         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7814         declare.
7815         * tui/tui-winsource.c
7816         (tui_source_window_base::do_scroll_horizontal): Rename from
7817         tui_horizontal_source_scroll.
7818         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7819         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7820         from tui_vertical_data_scroll.
7821         * tui/tui-win.h (tui_scroll): Don't declare.
7822         * tui/tui-win.c (tui_win_info::forward_scroll)
7823         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7824         (tui_win_info::right_scroll): Rename and update.
7825         (tui_scroll_forward_command, tui_scroll_backward_command)
7826         (tui_scroll_left_command, tui_scroll_right_command): Update.
7827         (tui_scroll): Remove.
7828         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7829         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7830         from tui_vertical_source_scroll.
7831         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7832         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7833         from tui_vertical_disassem_scroll.
7834         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7835         do_scroll_horizontal>: New methods.
7836         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7837         Likewise.
7838         (struct tui_source_window_base): Add do_scroll_horizontal.
7839         (struct tui_source_window, struct tui_disasm_window): Add
7840         do_scroll_vertical.
7841         (struct tui_data_window, struct tui_cmd_window): Add
7842         do_scroll_horizontal and do_scroll_vertical.
7843         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7844
7845 2019-06-25  Tom Tromey  <tom@tromey.com>
7846
7847         * tui/tui-data.h (struct tui_source_window_base): New struct.
7848         (struct tui_source_window): Derive from tui_source_window_base.
7849         (struct tui_disasm_window): New struct.
7850         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7851         from tui_source_window::clear_detail.
7852         (tui_source_window_base): Rename from tui_source_window.
7853         (~tui_source_window_base): Rename from ~tui_source_window.
7854         (tui_alloc_win_info): Create a tui_disasm_window.
7855
7856 2019-06-25  Tom Tromey  <tom@tromey.com>
7857
7858         * tui/tui-data.h (struct tui_source_window)
7859         (struct tui_data_window): Declare destructors.
7860         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7861         destructors.
7862         (tui_win_info): Simplify.
7863
7864 2019-06-25  Tom Tromey  <tom@tromey.com>
7865
7866         * tui/tui-winsource.c (tui_display_main)
7867         (tui_update_source_windows_with_addr)
7868         (tui_update_all_breakpoint_info): Update.
7869         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7870         (new_height_ok, parse_scrolling_args): Update.
7871         * tui/tui-stack.c (tui_show_frame_info): Update.
7872         * tui/tui-data.h (struct tui_list): Remove.
7873         (tui_source_windows): Return a reference to a std::vector.
7874         * tui/tui-data.c (source_windows): Now a std::vector.
7875         (tui_source_windows): Change return type.
7876         (tui_clear_source_windows): Rewrite.
7877         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7878         (tui_free_all_source_wins_content): Rewrite.
7879
7880 2019-06-25  Tom Tromey  <tom@tromey.com>
7881
7882         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7883         (struct tui_data_window, struct tui_cmd_window): Declare
7884         clear_detail method.
7885         * tui/tui-data.c (tui_source_window::clear_detail)
7886         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7887         methods.
7888         (tui_clear_win_detail): Simplify.
7889
7890 2019-06-25  Tom Tromey  <tom@tromey.com>
7891
7892         * tui/tui-layout.c (make_source_window, make_disasm_window)
7893         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7894         Return the new window.
7895         (show_source_disasm_command, show_data)
7896         (show_source_or_disasm_and_command): Update.
7897
7898 2019-06-25  Tom Tromey  <tom@tromey.com>
7899
7900         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7901         parameter.  Return the new window.
7902         (show_source_disasm_command): Update and remove NULL check.
7903         (show_source_or_disasm_and_command): Update.
7904
7905 2019-06-25  Tom Tromey  <tom@tromey.com>
7906
7907         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7908
7909 2019-06-25  Tom Tromey  <tom@tromey.com>
7910
7911         * tui/tui-data.h (struct tui_win_info): Make constructor
7912         protected.  Make destructor virtual.  Add initializers.
7913         (tui_source_window, tui_data_window, tui_cmd_window): New
7914         classes.
7915         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7916         constructor.  Add "type" parameter.
7917         (tui_source_window, tui_data_window, tui_cmd_window): New
7918         constructors.
7919         (tui_alloc_win_info): Instantiate the appropriate subclass.
7920
7921 2019-06-25  Tom Tromey  <tom@tromey.com>
7922
7923         * tui/tui-win.c (tui_resize_all): Use delete.
7924         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7925         destructor.
7926         (tui_free_window): Don't declare.
7927         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7928         Update.
7929
7930 2019-06-25  Tom Tromey  <tom@tromey.com>
7931
7932         * tui/tui-data.h (struct tui_win_info): Add constructor.
7933         * tui/tui-data.c (tui_alloc_win_info): Use new.
7934         (tui_free_window): Use delete.
7935
7936 2019-06-22  Tom Tromey  <tom@tromey.com>
7937
7938         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7939         declare.
7940         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7941
7942 2019-06-22  Tom Tromey  <tom@tromey.com>
7943
7944         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7945         declare.
7946         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7947
7948 2019-06-22  Tom de Vries  <tdevries@suse.de>
7949
7950         * dwarf2read.c (create_addrmap_from_aranges)
7951         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7952         instead of '%zu'.
7953
7954 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7955
7956         * dwarf2read.h (dwarf2_section_info_def): Remove.
7957         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7958         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7959         std::vector<dwarf2_section_info>.
7960         (struct dwo_file) <~dwo_file>: Remove.
7961         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7962         types field.
7963         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7964         (dwarf2_read_debug_names): Likewise.
7965         (create_debug_types_hash_table): Change parameter type to
7966         array_view, adjust code accordingly.
7967         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7968         (partial_die_info::fixup): Likewise.
7969         (determine_prefix): Likewise.
7970         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7971
7972 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7973
7974         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7975         gdb_bfd_ref_ptr.
7976         <~dwo_file>: Remove call to gdb_bfd_unref.
7977         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7978         gdb_bfd_ref_ptr::get.
7979
7980 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7981
7982         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7983         type to htab_up.
7984         * dwarf2read.c (struct dwo_file): Initialize fields.
7985         <~dwo_file>: New.
7986         (free_dwo_file): Remove, move content to ~dwo_file.
7987         (struct dwo_file_deleter): Remove.
7988         (dwo_file_up>: Remove custom deleter.
7989         (free_dwo_files): Remove.
7990         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7991         dwo_files.
7992         (process_skeletonless_type_units): Call unique_ptr::get.
7993         (allocate_dwo_file_hash_table): Add deleter to created hash
7994         table.  Change return type to htab_up.
7995         (lookup_dwo_file_slot): Don't memset dwo_file, call
7996         unique_ptr::get.
7997         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7998         (create_dwo_unit_in_dwp_v2): Likewise.
7999         (open_and_init_dwo_file): Likewise.
8000         (free_dwo_file_from_slot): Remove.
8001
8002 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8003
8004         * dwarf2read.h (struct dwarf2_section_info) <readin,
8005         is_virtual>: Change type to bool.
8006         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8007         true instead of 1.
8008
8009 2019-06-19  Tom Tromey  <tom@tromey.com>
8010
8011         * tui/tui-data.h (tui_init_content_element): Don't declare.
8012
8013 2019-06-19  Tom Tromey  <tom@tromey.com>
8014
8015         * tui/tui-data.h (tui_init_win_info): Don't declare.
8016
8017 2019-06-19  Tom de Vries  <tdevries@suse.de>
8018
8019         * dwarf2read.h (abstract_to_concrete): Change type to
8020         std::unordered_map<sect_offset, std::vector<sect_offset>,
8021         gdb::hash_enum<sect_offset>>.
8022
8023 2019-06-19  Tom Tromey  <tromey@adacore.com>
8024
8025         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8026         EVAL_AVOID_SIDE_EFFECTS specially.
8027
8028 2019-06-19  Tom Tromey  <tromey@adacore.com>
8029
8030         * source-cache.c (highlighter): New global.
8031         (source_cache::get_source_lines): Create a highlighter on demand.
8032
8033 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8034
8035         * defs.h (deprecated_interactive_hook): Delete declaration.
8036         * interps.c (clear_interpreter_hooks): Remove use of
8037         deprecated_interactive_hook.
8038         * top.c (deprecated_interactive_hook): Delete definition.
8039         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8040
8041 2019-06-18  Tom de Vries  <tdevries@suse.de>
8042
8043         PR gdb/24515
8044         * dwarf2read.h (abstract_to_concrete): Change type from
8045         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8046         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8047         * dwarf2read.c (read_variable): Update.
8048         (dwarf2_fetch_die_loc_sect_off): Update.
8049
8050 2019-06-17  Tom de Vries  <tdevries@suse.de>
8051
8052         PR gdb/24617
8053         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8054         accessing parent[parent_len - 1].
8055
8056 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8057
8058         PR gdb/24364
8059         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8060         call dtrace_process_dof with NULL dof.
8061
8062 2019-06-16  Tom de Vries  <tdevries@suse.de>
8063
8064         PR gdb/24445
8065         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8066
8067 2019-06-16  Tom Tromey  <tom@tromey.com>
8068
8069         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8070         (make_all_visible): Use address of member.
8071
8072 2019-06-16  Tom Tromey  <tom@tromey.com>
8073
8074         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8075         (tui_free_window, free_content, free_content_elements): Remove
8076         unnecessary cast.
8077         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8078         cast.
8079         * tui/tui-regs.c (tui_show_register_group)
8080         (tui_display_registers_from, tui_display_reg_element_at_line):
8081         Remove unnecessary cast.
8082
8083 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * linux-nat.c (normal_mask): Delete.
8086         (_initialize_linux_nat): Don't initialise normal_mask.
8087
8088 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8089
8090         PR gdb/24445
8091         * dwarf-index-write.h (write_psymtabs_to_index): Add
8092         dwz_basename parameter.
8093         * dwarf-index-write.c (write_gdbindex): Move file writing to
8094         write_gdbindex_1.  Change return type void.
8095         (assert_file_size): Move up, remove filename parameter.
8096         (write_gdbindex_1): New function.
8097         (write_debug_names): Change return type to void, call
8098         assert_file_size.
8099         (struct index_wip_file): New struct.
8100         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8101         file logic to index_wip_file.  Write index for dwz file if
8102         needed.
8103         (save_gdb_index_command): Pass basename of dwz file, if present.
8104         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8105         build-id of dwz file, if present.
8106         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8107         (dwarf2_get_dwz_file): Likewise.
8108         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8109         (dwarf2_get_dwz_file): Likewise.
8110
8111 2019-06-16  Tom Tromey  <tom@tromey.com>
8112
8113         * coffread.c (process_coff_symbol): Use xstrdup.
8114         * value.c (create_internalvar): Use xstrdup.
8115
8116 2019-06-16  Tom Tromey  <tom@tromey.com>
8117
8118         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8119         * breakpoint.c (stopin_command, stopat_command)
8120         (until_break_command, decode_location_default): Remove unnecessary
8121         cast.
8122         * utils.c (subset_compare): Remove unnecessary cast.
8123         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8124         cast.
8125         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8126         cast.
8127         * infcmd.c (path_command): Remove unnecessary cast.
8128         * coffread.c (decode_type): Remove unnecessary cast.
8129         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8130         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8131         * tui/tui-stack.c (tui_show_locator_content)
8132         (tui_show_frame_info): Remove unnecessary cast.
8133         * tui/tui-win.c (tui_scroll_forward_command)
8134         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8135         (parse_scrolling_args): Remove unnecessary cast.
8136         * tui/tui-data.c (init_win_info, tui_del_window)
8137         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8138         (free_content_elements): Remove unnecessary cast.
8139         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8140         unnecessary cast.
8141         * tui/tui-source.c (tui_set_source_content)
8142         (tui_vertical_source_scroll): Remove unnecessary cast.
8143         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8144         cast.
8145         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8146         * tui/tui-regs.c (tui_display_registers_from)
8147         (tui_display_register): Remove unnecessary cast.
8148         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8149         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8150         (make_visible): Remove unnecessary cast.
8151         * tui/tui-winsource.c (tui_erase_source_content)
8152         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8153         unnecessary cast.
8154         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8155         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8156         * stabsread.c (read_type, read_array_type, read_range_type):
8157         Remove unnecessary cast.
8158         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8159         (parse_symbol, parse_type, upgrade_type, parse_external)
8160         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8161         unnecessary cast.
8162         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8163
8164 2019-06-16  Tom Tromey  <tom@tromey.com>
8165
8166         * tui/tui-data.c (tui_alloc_generic_win_info)
8167         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8168         checks.
8169
8170 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8171             Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * f-typeprint.c (f_print_type): Don't return early for not
8174         associated or not allocated types.
8175         (f_type_print_varspec_suffix): Add print_rank parameter and print
8176         ranks of array types in case they dangling.
8177         (f_type_print_base): Add print_rank parameter.
8178
8179 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8180
8181         * NEWS: Mention new MI commands.
8182         * break-catch-throw.c (enum exception_event_kind): Move to
8183         breakpoint.h.
8184         (print_mention_exception_catchpoint): Output text as a single
8185         message.
8186         (catch_exception_command_1): Rename to...
8187         (catch_exception_event): ...this, make non-static, update header
8188         command, and change some parameter types.
8189         (catch_catch_command): Update for changes to
8190         catch_exception_command_1.
8191         (catch_throw_command): Likewise.
8192         (catch_rethrow_command): Likewise.
8193         * breakpoint.c (enum exception_event_kind): Delete.
8194         * breakpoint.h (enum exception_event_kind): Moved here from
8195         break-catch-throw.c.
8196         (catch_exception_event): Declare.
8197         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8198         (mi_cmd_catch_throw): New function.
8199         (mi_cmd_catch_rethrow): New function.
8200         (mi_cmd_catch_catch): New function.
8201         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8202         'catch-catch' entries.
8203         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8204         (mi_cmd_catch_rethrow): Declare.
8205         (mi_cmd_catch_catch): Declare.
8206
8207 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * annotate.c (annotate_source_line): Change return type to void,
8210         update implementation to match.
8211         * annotate.h (annotate_source_line): Change return type to void,
8212         update header comment.
8213         * stack.c (print_frame_info): Don't change what frame information
8214         is printed based on whether annotations are on or not.
8215
8216 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8217
8218         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8219         (annotate_source): Make static.
8220         (annotate_source_line): Moved from source.c and renamed from
8221         identify_source_line.  Update the return type.
8222         * annotate.h (annotate_source): Delete declaration.
8223         (annotate_source_line): Declaration moved from source.h, and
8224         renamed from identify_source_line.  Return type updated.
8225         * source.c (identify_source_line): Moved to annotate.c and renamed
8226         to annotate_source_line.
8227         (info_line_command): Remove check of annotation_level.
8228         * source.h (identify_source_line): Move declaration to annotate.h
8229         and rename to annotate_source_line.
8230         * stack.c: Add 'annotate.h' include.
8231         (print_frame_info): Remove check of annotation_level before
8232         calling annotate_source_line.
8233
8234 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8235
8236         * source-cache.c (source_cache::get_plain_source_lines): Use
8237         open_source_file_with_line_charpos instead of just
8238         open_source_file, remove call to find_source_lines.
8239         (source_cache::get_source_lines): Likewise.
8240         * source.c (find_source_lines): Make static.
8241         (get_filename_and_charpos): Renamed into...
8242         (open_source_file_with_line_charpos): ..this along with changes to
8243         return a scoped_fd, and some other minor clean ups.
8244         (identify_source_line): Use open_source_file_with_line_charpos.
8245         (search_command_helper): Use open_source_file_with_line_charpos
8246         instead of just open_source_file, remove call to
8247         find_source_lines.
8248         * source.h (open_source_file_with_line_charpos): Declare new
8249         function.
8250         (find_source_lines): Delete declaration.
8251
8252 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8253
8254         * source.c (get_filename_and_charpos): Remove fullname
8255         parameter.
8256         (identify_source_line): Update call to get_filename_and_charpos.
8257
8258 2019-06-14  Tom Tromey  <tromey@adacore.com>
8259
8260         PR gdb/24502:
8261         * ui-style.h (skip_ansi_escape): Update comment.
8262         * ui-file.h (class no_terminal_escape_file): New class.
8263         * ui-file.c (no_terminal_escape_file::write)
8264         (no_terminal_escape_file::puts): New methods.
8265         * cli/cli-logging.c (handle_redirections): Use
8266         no_terminal_escape_file.
8267
8268 2019-06-14  Tom Tromey  <tromey@adacore.com>
8269
8270         * NEWS: Move convenience variable news above Python news.
8271
8272 2019-06-14  Tom Tromey  <tom@tromey.com>
8273
8274         * gnulib: Move directory to top-level.
8275         * configure.ac: Don't configure gnulib.
8276         * configure: Rebuild.
8277         * common/common-defs.h: Use new path to gnulib.
8278         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8279         (GNULIB_H): Remove.
8280         (INCGNU): Look in new gnulib location.
8281         (HFILES_NO_SRCDIR): Remove gnulib files.
8282         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8283         (generated_files): Remove GNULIB_H.
8284         ($(LIBGNU), all-lib): Remove targets.
8285         (distclean): Don't mention GNULIB_BUILDDIR.
8286         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8287
8288 2019-06-14  Tom Tromey  <tromey@adacore.com>
8289
8290         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8291         Warn if symbol file does not provide any symbols.
8292
8293 2019-06-14  Tom Tromey  <tromey@adacore.com>
8294
8295         * source.c (find_and_open_source): Respect basenames_may_differ.
8296
8297 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * annotate.c (annotate_breakpoints_invalid): Make use of
8300         scoped_restore_terminal_state.
8301         (annotate_frames_invalid): Likewise.
8302
8303 2019-06-14  Tom Tromey  <tromey@adacore.com>
8304
8305         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8306         allow assignment to an internalvar.
8307
8308 2019-06-14  Tom Tromey  <tromey@adacore.com>
8309
8310         * ada-lex.l: Allow "_" in attribute names.
8311
8312 2019-06-14  Tom Tromey  <tromey@adacore.com>
8313
8314         PR gdb/24653:
8315         * regcache.c (registers_changed): Don't call alloca.
8316         * top.c (execute_command): Don't call alloca.
8317
8318 2019-06-13  Pedro Alves  <palves@redhat.com>
8319
8320         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8321         'expression'.  When parsing an expression, error out if there's
8322         junk after "unlimited".
8323         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8324         (do_set_command): Adjust calls to is_unlimited_literal.
8325
8326 2019-06-13  Pedro Alves  <palves@redhat.com>
8327
8328         * compile/compile.c (make_compile_options_def_group): Add braces
8329         around array_view initializer.
8330         * thread.c (make_thread_apply_all_options_def_group)
8331         (make_thread_apply_all_options_def_group): Likewise.
8332
8333 2019-06-13  Pedro Alves  <palves@redhat.com>
8334
8335         * NEWS (New commands): Mention "maint test-options
8336         require-delimiter", "maint test-options unknown-is-error", "maint
8337         test-options unknown-is-operand" and "maint show
8338         test-options-completion-result".
8339         (New command options, command completion): New section.
8340         (Completion improvements): New section.
8341         Mention that you can abbreviate "unlimited".
8342
8343 2019-06-13  Pedro Alves  <palves@redhat.com>
8344
8345         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8346         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8347         * unittests/cli-utils-selftests.c (test_parse_flags)
8348         (test_parse_flags_qcs): Delete.
8349         (test_cli_utils): Don't call deleted functions.
8350
8351 2019-06-13  Pedro Alves  <palves@redhat.com>
8352
8353         * thread.c: Include "cli/cli-option.h".
8354         (tp_array_compar_ascending): Global.
8355         (tp_array_compar): Delete function.
8356         (tp_array_compar_ascending, tp_array_compar_descending): New
8357         functions.
8358         (ascending_option_def, qcs_flag_option_def)
8359         (thr_qcs_flags_option_defs)
8360         (make_thread_apply_all_options_def_group)
8361         (make_thread_apply_options_def_group): New.
8362         (thread_apply_all_command): Use gdb::option::process_options.
8363         (thread_apply_command_completer)
8364         (thread_apply_all_command_completer): New.
8365         (thread_apply_command): Use gdb::option::process_options.
8366         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8367         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8368         to generate help text of "thread apply".  Adjust "taas"'s help.
8369         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8370         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8371
8372 2019-06-13  Pedro Alves  <palves@redhat.com>
8373
8374         * thread.c (thread_apply_command): Check for invalid TID with
8375         isdigit instead of !isalpha.
8376
8377 2019-06-13  Pedro Alves  <palves@redhat.com>
8378
8379         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8380         (validate_flags_qcs): New.
8381         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8382         (validate_flags_qcs): Declare.
8383         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8384         (make_frame_apply_options_def_group): New.
8385         (frame_apply_command_count): Process options with
8386         gdb::option::process_options.
8387         (frame_apply_completer): New.
8388         (frame_apply_level_completer, frame_apply_all_completer)
8389         (frame_apply_completer): New.
8390         (_initialize_stack): Update help of "frame apply", "frame apply
8391         level", "frame apply all" and "faas" to mention supported options
8392         and install command completers.
8393         * stack.h (frame_apply_all_completer): Declare.
8394         * thread.c: Include "stack.h".
8395         (tfaas_command): Add "--".
8396         (_initialize_thread): Update help "tfaas" to mention supported
8397         options and install command completer.
8398
8399 2019-06-13  Pedro Alves  <palves@redhat.com>
8400
8401         * completer.c (complete_nested_command_line): New.
8402         (gdb_completion_word_break_characters_throw): Add assertion.
8403         * completer.h (complete_nested_command_line): Declare.
8404
8405 2019-06-13  Pedro Alves  <palves@redhat.com>
8406
8407         * stack.c (parse_backtrace_qualifiers): New.
8408         (backtrace_command): Use it.
8409         (backtrace_command_completer): Complete on qualifiers.
8410
8411 2019-06-13  Pedro Alves  <palves@redhat.com>
8412
8413         * frame.c: Include "cli/cli-option.h.
8414         (user_set_backtrace_options): New.
8415         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8416         Delete.
8417         (get_prev_frame): Adjust.
8418         (boolean_option_def, uinteger_option_def)
8419         (set_backtrace_option_defs): New.
8420         (_initialize_frame): Adjust and use
8421         gdb::option::add_setshow_cmds_for_options to install "set
8422         backtrace past-main" and "set backtrace past-entry".
8423         * frame.h: Include "cli/cli-option.h".
8424         (struct frame_print_options): Forward declare.
8425         (print_frame_arguments_all, print_frame_arguments_scalars)
8426         (print_frame_arguments_none): Declare.
8427         (print_entry_values): Delete declaration.
8428         (struct frame_print_options, user_frame_print_options): New.
8429         (struct set_backtrace_options): New.
8430         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8431         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8432         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8433         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8434         (list_args_or_locals): Add frame_print_options parameter.
8435         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8436         * python/py-framefilter.c (enumerate_args): Pass down
8437         USER_FRAME_PRINT_OPTIONS.
8438         * stack.c: Include "cli/cli-option.h".
8439         (print_frame_arguments_all, print_frame_arguments_scalars)
8440         (print_frame_arguments_none): Declare.
8441         (print_raw_frame_arguments, print_entry_values): Delete.
8442         (user_frame_print_options): New.
8443         (boolean_option_def, enum_option_def, frame_print_option_defs):
8444         New.
8445         (struct backtrace_cmd_options): New.
8446         (bt_flag_option_def): New.
8447         (backtrace_command_option_defs): New.
8448         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8449         (print_frame_arg, read_frame_arg, print_frame_args)
8450         (print_frame_info, print_frame): Add frame_print_options parameter
8451         and use it.
8452         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8453         (backtrace_command_1): Add frame_print_options and
8454         backtrace_cmd_options parameters and use them.
8455         (make_backtrace_options_def_group): New.
8456         (backtrace_command): Process command options with
8457         gdb::option::process_options.
8458         (backtrace_command_completer): New.
8459         (_initialize_stack): Extend "backtrace"'s help to mention
8460         supported options.  Install completer for "backtrace".
8461         Install some settings commands with add_setshow_cmds_for_options.
8462
8463 2019-06-13  Pedro Alves  <palves@redhat.com>
8464
8465         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8466         and that "set/show print raw frame-arguments" are now deprecated.
8467
8468         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8469         command.
8470         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8471         * stack.c (_initialize_stack): Install "set/show print
8472         raw-frame-arguments", and deprecate "set/show print raw
8473         frame-arguments".
8474         * valprint.c (_initialize_valprint): Deprecate "set/show print
8475         raw".
8476
8477 2019-06-13  Pedro Alves  <palves@redhat.com>
8478
8479         * compile/compile.c (struct compile_options): New.
8480         (compile_flag_option_def, compile_command_option_defs)
8481         (make_compile_options_def_group): New.
8482         (compile_file_command): Handle options with
8483         gdb::option::process_options.
8484         (compile_file_command_completer): New function.
8485         (compile_code_command): Handle options with
8486         gdb::option::process_options.
8487         (compile_code_command_completer): New function.
8488         (_initialize_compiler): Install completers for "compile code" and
8489         "compile file".  Mention available options in "compile code" and
8490         "compile code"'s help.
8491         * completer.c (advance_to_completion_word): New, factored out from
8492         ...
8493         (advance_to_expression_complete_word_point): ... this.
8494         (advance_to_filename_complete_word_point): New.
8495         * completer.h (advance_to_filename_complete_word_point): New
8496         declaration.
8497
8498 2019-06-13  Pedro Alves  <palves@redhat.com>
8499
8500         * compile/compile.c: Include "cli/cli-option.h".
8501         (compile_print_value): Scope data pointer is now a
8502         value_print_options pointer; adjust.
8503         (compile_print_command): Process options.  Scope data pointer is
8504         now a value_print_options pointer; adjust.
8505         (_initialize_compile): Update "compile print"'s help to include
8506         supported options.  Install a completer for "compile print".
8507         * cp-valprint.c (show_vtblprint, show_objectprint)
8508         (show_static_field_print): Delete.
8509         (_initialize_cp_valprint): Don't install "set print
8510         static-members", "set print vtbl", "set print object" here.
8511         * printcmd.c: Include "cli/cli-option.h" and
8512         "common/gdb_optional.h".
8513         (print_command_parse_format): Rework to fill in a
8514         value_print_options instead of a format_data.
8515         (print_value): Change parameter type from format_data pointer to
8516         value_print_options reference.  Adjust.
8517         (print_command_1): Process options.  Adjust to pass down a
8518         value_print_options.
8519         (print_command_completer): New.
8520         (_initialize_printcmd): Install print_command_completer as
8521         handle_brkchars completer for the "print" command.  Update
8522         "print"'s help to include supported options.
8523         * valprint.c: Include "cli/cli-option.h".
8524         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8525         here from cp-valprint.c.
8526         (boolean_option_def, uinteger_option_def)
8527         (value_print_option_defs, make_value_print_options_def_group):
8528         New.  Use gdb::option::add_setshow_cmds_for_options to install
8529         "set print elements", "set print null-stop", "set print repeats",
8530         "set print pretty", "set print union", "set print array", "set
8531         print address", "set print symbol", "set print array-indexes".
8532         * valprint.h: Include <string> and "cli/cli-option.h".
8533         (make_value_print_options_def_group): Declare.
8534         (print_value): Change parameter type from format_data pointer to
8535         value_print_options reference.
8536         (print_command_completer): Declare.
8537
8538 2019-06-13  Pedro Alves  <palves@redhat.com>
8539
8540         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8541         (COMMON_SFILES): Add maint-test-settings.c.
8542         * cli/cli-decode.c (boolean_enums): New global, factored out from
8543         ...
8544         (add_setshow_boolean_cmd): ... here.
8545         * cli/cli-decode.h (boolean_enums): Declare.
8546         * cli/cli-option.c: New file.
8547         * cli/cli-option.h: New file.
8548         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8549         factored out from ...
8550         (parse_cli_boolean_value(const char *)): ... this.
8551         (is_unlimited_literal): Change parameter type to pointer to
8552         pointer.  Adjust and advance ARG pointer.
8553         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8554         (parse_cli_var_enum): New, factored out from ...
8555         (do_set_command): ... this.  Adjust.
8556         * cli/cli-setshow.h (parse_cli_boolean_value)
8557         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8558         (parse_cli_var_enum): Declare.
8559         * cli/cli-utils.c: Include "cli/cli-option.h".
8560         (get_ulongest): New.
8561         * cli/cli-utils.h (get_ulongest): Declare.
8562         (check_for_argument): New overloads.
8563         * maint-test-options.c: New file.
8564
8565 2019-06-13  Pedro Alves  <palves@redhat.com>
8566
8567         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8568         parse a range if "-" is at the end of the string.
8569
8570 2019-06-13  Pedro Alves  <palves@redhat.com>
8571
8572         * cli/cli-setshow.c (parse_auto_binary_operation)
8573         (parse_cli_boolean_value): Don't allow "o".
8574
8575 2019-06-13  Pedro Alves  <palves@redhat.com>
8576
8577         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8578         * NEWS: Mention maint test-settings KIND.
8579         * maint-test-settings.c: New file.
8580
8581 2019-06-13  Pedro Alves  <palves@redhat.com>
8582
8583         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8584         completer.
8585         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8586         "set" completers.
8587
8588 2019-06-13  Pedro Alves  <palves@redhat.com>
8589
8590         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8591         after item.
8592
8593 2019-06-13  Pedro Alves  <palves@redhat.com>
8594
8595         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8596
8597 2019-06-13  Pedro Alves <palves@redhat.com>
8598
8599         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8600         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8601         call.
8602         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8603         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8604         calls.
8605         (check_for_argument): Skip spaces after argument.
8606
8607 2019-06-13  Pedro Alves  <palves@redhat.com>
8608
8609         * thread.c (thread_apply_command): Adjust TID parsing.
8610         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8611         detected before end of string.
8612         (tid_is_in_list): Error out if LIST is invalid.
8613
8614 2019-06-13  Pedro Alves  <palves@redhat.com>
8615
8616         * completer.c (complete_line_internal_1): Rewind completion word
8617         point.
8618         (completion_tracker::advance_custom_word_point_by): Change
8619         parameter type to int.
8620         * completer.h (completion_tracker::advance_custom_word_point_by):
8621         Likewise.
8622
8623 2019-06-13  Pedro Alves  <palves@redhat.com>
8624
8625         * completer.c (advance_to_completion_word): Handle delimiters.
8626
8627 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8628
8629         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8630
8631 2019-06-11  Tom Tromey  <tom@tromey.com>
8632
8633         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8634         (xmalloc_failed): Move to alloc.c.
8635         * alloc.c: New file.
8636         * Makefile.in (COMMON_SFILES): Add alloc.c.
8637
8638 2019-06-11  Tom Tromey  <tom@tromey.com>
8639
8640         * nat/linux-waitpid.c: Don't include server.h.
8641         (linux_debug): Remove.
8642         (my_waitpid): Update.
8643
8644 2019-06-11  Tom Tromey  <tromey@adacore.com>
8645
8646         * infcall.c (_initialize_infcall): Remove trailing newline from
8647         help.
8648         * user-regs.c (_initialize_user_regs): Remove trailing newline
8649         from help.
8650         * typeprint.c (_initialize_typeprint): Remove trailing newline
8651         from help.
8652         * reverse.c (_initialize_reverse): Remove trailing newlines from
8653         help.
8654         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8655         from help.
8656         * language.c (add_set_language_command): Remove trailing newline
8657         from help.
8658         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8659         help.
8660         * disasm.c (_initialize_disasm): Remove trailing newline from
8661         help.
8662         * top.c (init_main): Remove trailing newline from help.
8663         * interps.c (_initialize_interpreter): Remove trailing newline
8664         from help.
8665         * btrace.c (_initialize_btrace): Remove trailing newlines from
8666         help.
8667         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8668         from help.
8669         * python/python.c (_initialize_python): Remove trailing newline
8670         from help.
8671         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8672         help.
8673         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8674         from help.  Reformat some text.
8675         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8676         from help.
8677         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8678         newline from help.
8679
8680 2019-06-11  Tom Tromey  <tromey@adacore.com>
8681
8682         * darwin-nat.c (darwin_decode_exception_message)
8683         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8684
8685 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8686
8687         * valops.c (value_slice): Check for not allocated or not
8688         associated values.
8689
8690 2019-06-10  Tom de Vries  <tdevries@suse.de>
8691
8692         PR gdb/24618
8693         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8694         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8695         invalid.
8696
8697 2019-06-10  Tom de Vries  <tdevries@suse.de>
8698
8699         PR gdb/24611
8700         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8701         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8702
8703 2019-06-10  Tom de Vries  <tdevries@suse.de>
8704
8705         PR symtab/24545
8706         * symtab.c (struct demangled_name_entry): Add language field.
8707         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8708         static minimal symbol".  Set and use language field.
8709
8710 2019-06-10  Tom Tromey  <tromey@adacore.com>
8711
8712         * ada-lang.c (_initialize_ada_language): Update help text.
8713
8714 2019-06-10  Tom Tromey  <tromey@adacore.com>
8715
8716         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8717         with a newline.
8718         * guile/guile.c (handle_boot_error): Don't end warning with a
8719         newline.
8720         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8721         warning with a newline.
8722         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8723         newline.
8724         (s12z_frame_cache): Likewise.
8725         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8726         a newline.
8727         * solib-svr4.c (disable_probes_interface): Don't end warning with
8728         a newline.
8729         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8730         newline.
8731         * python/python.c (do_finish_initialization): Don't end warning
8732         with a newline.
8733
8734 2019-06-10  Tom Tromey  <tom@tromey.com>
8735
8736         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8737         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8738         gdbpy_enter.
8739
8740 2019-06-10  Tom Tromey  <tromey@adacore.com>
8741
8742         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8743         data.
8744         (elf_new_init): Don't call stabsread_new_init.
8745         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8746         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8747         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8748
8749 2019-06-10  Tom de Vries  <tdevries@suse.de>
8750
8751         PR symtab/16264
8752         PR symtab/24517
8753         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8754
8755 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8756
8757         * source.c (find_and_open_source): Also rewrite relative file
8758         names.
8759
8760 2019-04-26  Amos Bird  <amosbird@gmail.com>
8761
8762         * annotate.c (annotate_thread_exited): Add "thread-exited"
8763         annotation.
8764
8765 2019-06-06  Tom Tromey  <tromey@adacore.com>
8766
8767         * maint.h (class scoped_command_stats): Use
8768         DISABLE_COPY_AND_ASSIGN.
8769         <print_time>: New method.
8770         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8771         print_time.
8772         (scoped_command_stats::print_time): New method.
8773
8774 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8775
8776         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8777         instructions of lengths 6 or 8 bytes.
8778
8779 2019-06-04  Pedro Alves  <palves@redhat.com>
8780
8781         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8782
8783         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8784         * breakpoint.c (condition_completer): Likewise.
8785         * cli/cli-dump.c (scan_expression): Likewise.
8786         * common/filestuff.c (mkdir_recursive): Likewise.
8787         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8788         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8789         (gdb_abspath): Likewise.
8790         * compile/compile-cplus-types.c
8791         (compile_cplus_instance::decl_name): Likewise.
8792         * completer.c (complete_explicit_location):
8793         (signal_completer, reg_or_group_completer_1): Likewise.
8794         * cp-support.c (cp_remove_params_if_any): Likewise.
8795         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8796         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8797         * infcmd.c (strip_bg_char): Likewise.
8798         * linespec.c (copy_token_string): Likewise.
8799         * mi/mi-main.c (output_cores): Likewise.
8800         * psymtab.c (psymtab_search_name):
8801         * symfile.c (test_set_ext_lang_command): Likewise.
8802         * target.c (target_fileio_read_stralloc): Likewise.
8803         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8804         * value.c (complete_internalvar): Likewise.
8805
8806 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8807
8808         Add objfile property to gdb.Type.
8809         * NEWS: Mention Python API addition.
8810         * python/py-type.c (typy_get_objfile): New method.
8811
8812 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8813
8814         * NEWS: Mention the new set|show style [title|highlight].
8815         Mention changes to "show style", "help" and "apropos".
8816
8817 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8818
8819         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8820         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8821         instead of print_help_for_command.
8822         (print_doc_of_command): New function.
8823         (help_list): Add 'apropos -v word' suggestion.
8824         (print_help_for_command): Style the command name using title style.
8825         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8826         (_initialize_cli_cmds): Describe -v in apropos_command help.
8827
8828 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8829
8830         * cli/cli-style.h (cli_style_option): Add name in constructor,
8831         add m_name class member, add constructor with intensity,
8832         add name class function.
8833         (cli_style_option::add_setshow_commands): Remove name argument.
8834         (highlight_style, title_style): New styles.
8835         * cli/cli-style.c (do_show): New function that shows a style
8836         characteristic styling the style name with itself.
8837         (set_style_name): New function.
8838         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8839         Update all callers according to the changes in cli/cli-style.h.
8840         * utils.h (fputs_highlighted): New function.
8841         * utils.c (fputs_highlighted): Likewise.
8842
8843 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8844
8845         * NEWS: Mention new pipe command and new convenience variables.
8846
8847 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8848
8849         * cli/cli-cmds.c (pipe_command): New function.
8850         (_initialize_cli_cmds): Call add_com for pipe_command.
8851         Define | as an alias for pipe.
8852         (exit_status_set_internal_vars): New function.
8853         (shell_escape): Call exit_status_set_internal_vars.
8854         cli/cli-decode.c (find_command_name_length): Recognize | as
8855         a single character command.
8856
8857 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8858
8859         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8860         top.c (execute_command_to_ui_file): New function, mostly a copy
8861         of execute_command_to_string.
8862         (execute_command_to_string): Implement by calling
8863         execute_command_to_ui_file.
8864
8865 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8866
8867         * top.h (saved_command_line): Remove declaration.
8868         * top.c (previous_saved_command_line, previous_repeat_arguments):
8869         New variables.
8870         (saved_command_line): Make static, define together with other
8871         'repeat variables'.
8872         (dont_repeat): Clear repeat_arguments.
8873         (repeat_previous, get_saved_command_line, save_command_line):
8874         New functions.
8875         (gdb_init): Initialize saved_command_line
8876         and previous_saved_command_line.
8877         * main.c (captured_main_1): Remove saved_command_line initialization.
8878         * event-top.c (handle_line_of_input): Update to use
8879         the new 'repeat' related functions instead of direct access to
8880         saved_command_line.
8881         * command.h (repeat_previous, get_saved_command_line,
8882         save_command_line): New declarations.
8883         (dont_repeat): Add comment.
8884
8885 2019-05-30  Tom Tromey  <tromey@adacore.com>
8886
8887         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8888         Fix comment.
8889         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8890
8891 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8892
8893         PR cli/24587
8894         * completer.c (complete): Initialize variable word.
8895
8896 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8897
8898         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8899         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8900         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8901         'body' is NULL to the outter 'if', protecting the '!is_define'
8902         situation as well.
8903
8904 2019-05-29  Tom Tromey  <tromey@adacore.com>
8905
8906         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8907         (dwarf_unknown): New function.
8908         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8909         (dwarf_type_encoding_name): Use dwarf_unknown.
8910
8911 2019-05-29  Tom Tromey  <tromey@adacore.com>
8912
8913         PR c++/20020:
8914         * cp-valprint.c (cp_print_value_fields): Call
8915         cp_print_static_field inside "try".
8916
8917 2019-05-29  Tom Tromey  <tromey@adacore.com>
8918
8919         * inflow.c (struct terminal_info): Add default operator=.
8920         * configure: Rebuild.
8921         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8922         -Wdeprecated-copy-dtor, -Wredundant-move.
8923
8924 2019-05-29  Tom Tromey  <tromey@adacore.com>
8925
8926         * NEWS: Add entry.
8927         * infcmd.c (print_return_value_1): Handle finish_print
8928         option.
8929         (show_print_finish): New function.
8930         (_initialize_infcmd): Add "set/show print finish" commands.
8931         * valprint.c (user_print_options): Initialize new member.
8932         * valprint.h (struct value_print_options) <finish_print>: New
8933         member.
8934
8935 2019-05-28  Tom Tromey  <tromey@adacore.com>
8936
8937         * ada-lang.c (ada_remove_Xbn_suffix)
8938         (find_old_style_renaming_symbol)
8939         (parse_old_style_renaming): Remove.
8940         (ada_find_renaming_symbol): Don't call
8941         find_old_style_renaming_symbol.
8942         (ada_is_renaming_symbol): Rename from
8943         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8944         bool.  Now static.
8945         (ada_read_var_value): Update and simplify.
8946         * ada-exp.y (write_var_or_type): Remove old code.
8947
8948 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8949
8950         PR gdb/25010
8951         * event-top.c: Remove include comment.
8952         * inflow.c (class scoped_ignore_sigttou): Move from here...
8953         * inflow.h (class scoped_ignore_sigttou): ...to here.
8954         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8955         * top.c:  Remove include comment.
8956
8957 2019-05-27  Tom Tromey  <tom@tromey.com>
8958
8959         * NEWS: Fix typo.
8960
8961 2019-05-22  Tom Tromey  <tromey@adacore.com>
8962
8963         * target.c (target_follow_exec): Constify parameter.
8964         * target-delegates.c: Rebuild.
8965         * remote.c (remote_target::follow_exec): Constify parameter.
8966         * infrun.c (follow_exec): Constify parameter.
8967         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8968         (target_follow_exec): Likewise.
8969
8970 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8971
8972         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8973         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8974
8975 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8976
8977         * NEWS: Add debugredirect and testsuite sections.
8978
8979 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8980
8981         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8982         target descriptions using exclusively floating point register name
8983         aliases.
8984
8985 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8986
8987         PR gdb/18644:
8988         * f-lang.c (build_fortran_types): Handle the case where
8989         gdbarch_floatformat_for_type returns a nullptr.
8990
8991 2019-05-21  Tom de Vries  <tdevries@suse.de>
8992
8993         PR cli/24587
8994         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8995
8996 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8997
8998         PR gdb/18644:
8999         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9000         16-byte floats.
9001         * i386-tdep.c (i386_floatformat_for_type): Use
9002         floatformats_ia64_quad for the 16-byte floating point component
9003         within a fortran 32-byte complex number.
9004
9005 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9008         delete default constructor.
9009         (find_partial_die): Update to return const struct.
9010         (partial_die_parent_scope): Move variable declaration into scope
9011         of its use and change its type to auto.
9012         (guess_partial_die_structure_name): Likewise.
9013         (partial_die_info::fixup): Likewise.
9014
9015 2019-05-17  Tom Tromey  <tromey@adacore.com>
9016
9017         * source.c (find_and_open_source): Remove cast.
9018
9019 2019-05-17  Tom Tromey  <tromey@adacore.com>
9020
9021         * annotate.c (annotate_source): Make "filename" const.
9022         * annotate.h (annotate_source): Use const.
9023
9024 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9025
9026         * disasm.c (set_disassembler_options): Send errors to stderr.
9027
9028 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9029
9030         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9031         (cli_interp_base::set_logging): Check debug_redirect.
9032         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9033         * cli/cli-logging.c (debug_redirect): Add static variable.
9034         (pop_output_files): Add default param.
9035         (handle_redirections): Print debug setting.
9036         (show_logging_command): Likewise.
9037         (_initialize_cli_logging): Add debugredirect command.
9038         * interps.c (current_interp_set_logging): Add debug_redirect
9039         parameter.
9040         * interps.h (set_logging): Add debug_redirect parameter.
9041         (current_interp_set_logging): Likewise.
9042         * mi/mi-common.h: Likewise.
9043         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9044
9045 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9046             Tom Tromey  <tromey@adacore.com>
9047
9048         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9049         directly.
9050         * cli/cli-interp.h (make_logging_output): Remove declaration.
9051         * cli/cli-logging.c (make_logging_output): Remove function.
9052         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9053         directly.
9054         * ui-file.c (tee_file::tee_file): Remove bools.
9055         (tee_file::~tee_file): Remove deletes.
9056         * ui-file.h (tee_file): Remove bools.
9057
9058 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9059
9060         * mi/mi-cmds.h (mi_cmd_complete): New function.
9061         * mi/mi-main.c (mi_cmd_complete): Likewise.
9062         * mi/mi-cmds.c: Define new MI command -complete.
9063         * NEWS: Mention new -complete command.
9064
9065 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9066
9067         * completer.h (complete): New function.
9068         * completer.c (complete): Likewise.
9069         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9070         function defined in completer.h.
9071
9072 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9073
9074         * MAINTAINERS (Write After Approval): Add myself.
9075
9076 2019-05-17  Tom de Vries  <tdevries@suse.de>
9077
9078         PR gdb/24094
9079         * dwarf2read.c (struct cu_partial_die_info): New struct.
9080         (find_partial_die): Return cu_partial_die_info.
9081         (partial_die_parent_scope, guess_partial_die_structure_name)
9082         (partial_die_info::fixup): Handle new return type of find_partial_die.
9083
9084 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9085
9086         PR breakpoints/24541
9087         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9088         "std::string", simplifying the algorithm.
9089
9090 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9091
9092         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9093         (stap_static_probe_ops::get_probes): Likewise.
9094
9095 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9096
9097         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9098         '-')" and "else if".
9099         (stap_parse_single_operand): Join checks for
9100         "gdbarch_stap_parse_special_token_p" and
9101         "gdbarch_stap_parse_special_token" in the same "if" statement.
9102         Invert check when verifying for operation on register
9103         displacement.
9104
9105 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9106
9107         * stap-probe.c (stap_get_opcode): Update comment.
9108         (stap_get_expected_argument_type): Likewise.
9109         (handle_stap_probe): Likewise.
9110
9111 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9112
9113         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9114         return type to 'bool'.  Adjust comment.  Use 'bool' when
9115         appropriate.
9116         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9117         * stap-probe.c (stap_parse_argument_1): Likewise.
9118         (stap_is_operator): Likewise.
9119         (stap_is_generic_prefix): Likewise.
9120         (stap_is_register_prefix): Likewise.
9121         (stap_is_register_indirection_prefix): Likewise.
9122         (stap_is_integer_prefix): Likewise.
9123         (stap_generic_check_suffix): Likewise.
9124         (stap_check_integer_suffix): Likewise.
9125         (stap_check_register_suffix): Likewise.
9126         (stap_check_register_indirection_suffix): Likewise.
9127         (stap_parse_register_operand): Likewise.
9128         (stap_parse_single_operand): Likewise.
9129         (stap_parse_argument_1): Likewise.
9130         (stap_probe::get_argument_count): Likewise.
9131         (stap_is_operator): Likewise.
9132
9133 2019-05-16  Tom Tromey  <tromey@adacore.com>
9134
9135         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9136         keyword to foreach.
9137
9138 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9139
9140         * linux-thread-db.c (try_thread_db_load_1): Change return type
9141         to bool.
9142         (try_thread_db_load): Likewise.
9143         (try_thread_db_load_from_pdir_1): Likewise.
9144         (try_thread_db_load_from_pdir): Likewise.
9145         (try_thread_db_load_from_sdir): Likewise.
9146         (try_thread_db_load_from_dir): Likewise.
9147         (thread_db_load_search): Likewise.
9148         (has_libpthread): Likewise.
9149         (thread_db_load): Likewise.
9150
9151 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9152
9153         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9154         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9155         NULL, and complain/return if that's the case.
9156
9157 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9158
9159         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9160         (advance, posn, abstract_read_memory): New functions.
9161         [struct mem_read_abstraction]: New struct.
9162         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9163
9164 2019-05-14  Tom Tromey  <tromey@adacore.com>
9165
9166         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9167         value is not lval_memory.
9168
9169 2019-05-14  Tom Tromey  <tromey@adacore.com>
9170
9171         * solib.c (info_sharedlibrary_command): Style the file name.
9172
9173 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9174
9175         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9176         (aarch64_vnv_type): Likewise.
9177         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9178         * common/tdesc.c: Likewise.
9179         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9180         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9181         * features/aarch64-fpu.xml: Add ieee half view.
9182         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9183         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9184         * gdbtypes.h (struct builtin_type): Likewise.
9185         (struct objfile_type): Likewise.
9186
9187 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9188
9189         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9190         typo.
9191         * location.h (string_to_event_location): Likewise.
9192
9193 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9194
9195         GDB 8.3 released.
9196
9197 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9198
9199         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9200         New variable declaration.
9201         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9202         New variable.
9203         (print_one_breakpoint): Use ui_out::test_flags and new global
9204         variable to compute use_fixed_output.
9205         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9206         Remove.
9207         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9208         (mi_multi_location_breakpoint_output_fixed): Remove.
9209         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9210         new variable.
9211         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9212         fix_multi_location_breakpoint_output flag if version >= 3.
9213         * ui-out.h (enum ui_out_flag)
9214         <fix_multi_location_breakpoint_output>: New enumerator.
9215
9216 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9217
9218         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9219
9220 2019-05-10  Tom Tromey  <tromey@adacore.com>
9221
9222         * ada-lang.c (catch_ada_completer): New function.
9223         (_initialize_ada_language): Use it.
9224
9225 2019-05-10  Tom Tromey  <tromey@adacore.com>
9226
9227         * thread.c (print_thread_info): Make "requested_threads" const.
9228         * gdbthread.h (print_thread_info): Make "requested_threads"
9229         const.
9230         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9231         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9232
9233 2019-05-08  Tom Tromey  <tom@tromey.com>
9234
9235         * gdbtypes.c (objfile_type_data): Change type.
9236         (objfile_type, _initialize_gdbtypes): Update.
9237
9238 2019-05-08  Tom Tromey  <tom@tromey.com>
9239
9240         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9241         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9242         (_initialize_dwarf2_frame): Update.
9243
9244 2019-05-08  Tom Tromey  <tom@tromey.com>
9245
9246         * objc-lang.c (objc_objfile_data): Change type.
9247         (find_methods): Update.
9248         (_initialize_objc_lang): Remove.
9249
9250 2019-05-08  Tom Tromey  <tom@tromey.com>
9251
9252         * stabsread.c (rs6000_builtin_type_data): Change type.
9253         (rs6000_builtin_type, _initialize_stabsread): Update.
9254
9255 2019-05-08  Tom Tromey  <tom@tromey.com>
9256
9257         * mips-tdep.c (mips_pdr_data): Remove.
9258         (_initialize_mips_tdep): Update.
9259
9260 2019-05-08  Tom Tromey  <tom@tromey.com>
9261
9262         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9263         (hppa_init_objfile_priv_data, read_unwind_info)
9264         (find_unwind_entry, _initialize_hppa_tdep): Update.
9265
9266 2019-05-08  Tom Tromey  <tom@tromey.com>
9267
9268         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9269         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9270         on obstack.
9271         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9272
9273 2019-05-08  Tom Tromey  <tom@tromey.com>
9274
9275         * mdebugread.c (basic_type_data): Change type.
9276         (basic_type, _initialize_mdebugread): Update.
9277
9278 2019-05-08  Tom Tromey  <tom@tromey.com>
9279
9280         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9281
9282 2019-05-08  Tom Tromey  <tom@tromey.com>
9283
9284         * nto-tdep.c (nto_inferior_data_reg): Change type.
9285         (nto_inferior_data): Update.
9286         (nto_inferior_data_cleanup, nto_new_inferior_data)
9287         (_initialize_nto_tdep): Remove.
9288         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9289
9290 2019-05-08  Tom Tromey  <tom@tromey.com>
9291
9292         * ada-lang.c (struct ada_inferior_data): Add initializers.
9293         (ada_inferior_data): Change type.
9294         (ada_inferior_data_cleanup): Remove.
9295         (get_ada_inferior_data, ada_inferior_exit)
9296         (struct ada_pspace_data): Add initializers, destructor.
9297         (ada_pspace_data_handle): Change type.
9298         (get_ada_pspace_data): Update.
9299         (ada_pspace_data_cleanup): Remove.
9300
9301 2019-05-08  Tom Tromey  <tom@tromey.com>
9302
9303         * coffread.c (struct coff_symfile_info): Add initializers.
9304         (coff_objfile_data_key): Move lower.  Change type.
9305         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9306         Update.
9307         (coff_free_info): Remove.
9308
9309 2019-05-08  Tom Tromey  <tom@tromey.com>
9310
9311         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9312         (fbsd_pspace_data_handle): Move lower.  Change type.
9313         (get_fbsd_pspace_data): Update.
9314         (fbsd_pspace_data_cleanup): Remove.
9315         (_initialize_fbsd_tdep): Update.
9316
9317 2019-05-08  Tom Tromey  <tom@tromey.com>
9318
9319         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9320         (get_ada_tasks_pspace_data): Update.
9321         (ada_tasks_pspace_data_cleanup): Remove.
9322         (_initialize_tasks): Update.
9323         (ada_tasks_inferior_data_handle): Change type.
9324         (get_ada_tasks_inferior_data): Update.
9325         (ada_tasks_inferior_data_cleanup): Remove.
9326         (struct ada_tasks_pspace_data): Add initializers.
9327
9328 2019-05-08  Tom Tromey  <tom@tromey.com>
9329
9330         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9331         * symfile-debug.c (debug_sym_get_probes): Change type.
9332         * stap-probe.c (handle_stap_probe):
9333         (stap_static_probe_ops::get_probes): Change type.
9334         * probe.h (class static_probe_ops) <get_probes>: Change type.
9335         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9336         (parse_probes_in_pspace): Update.
9337         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9338         Update.
9339         (any_static_probe_ops::get_probes): Change type.
9340         * elfread.c (elfread_data): New typedef.
9341         (probe_key): Change type.
9342         (elf_get_probes): Likewise.  Update.
9343         (probe_key_free): Remove.
9344         (_initialize_elfread): Update.
9345         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9346         Change type.
9347         (dtrace_process_dof_probe, dtrace_process_dof)
9348         (dtrace_static_probe_ops::get_probe): Change type.
9349
9350 2019-05-08  Tom Tromey  <tom@tromey.com>
9351
9352         * xcoffread.c (struct xcoff_symfile_info): Rename from
9353         coff_symfile_info.  Add initializers.
9354         (xcoff_objfile_data_key): Move lower.  Change type.
9355         (XCOFF_DATA): Rewrite.
9356         (xcoff_free_info): Remove.
9357         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9358         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9359         (xcoff_initial_scan): Update.
9360
9361 2019-05-08  Tom Tromey  <tom@tromey.com>
9362
9363         * solib-svr4.c (struct svr4_info): Add initializers and
9364         destructor.
9365         <probes_table>: Now an htab_up.
9366         (solib_svr4_pspace_data): Change type.
9367         (free_probes_table): Simplify.
9368         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9369         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9370         (probes_table_remove_objfile_probes, register_solib_event_probe)
9371         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9372         (_initialize_svr4_solib): Update.
9373
9374 2019-05-08  Tom Tromey  <tom@tromey.com>
9375
9376         * remote.c (remote_pspace_data): Change type.
9377         (remote_pspace_data_cleanup): Remove.
9378         (get_remote_exec_file, set_pspace_remote_exec_file)
9379         (_initialize_remote): Update.
9380
9381 2019-05-08  Tom Tromey  <tom@tromey.com>
9382
9383         * breakpoint.c (breakpoint_objfile_key): Change type.
9384         (get_breakpoint_objfile_data): Update.
9385         (free_breakpoint_objfile_data): Remove.
9386         (_initialize_breakpoint): Update.
9387
9388 2019-05-08  Tom Tromey  <tom@tromey.com>
9389
9390         * linux-tdep.c (struct linux_info): Add initializers.
9391         (linux_inferior_data): Move.  Change type.
9392         (invalidate_linux_cache_inf): Update.
9393         (linux_inferior_data_cleanup): Remove.
9394         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9395
9396 2019-05-08  Tom Tromey  <tom@tromey.com>
9397
9398         * auxv.c (auxv_inferior_data): Move.  Change type.
9399         (auxv_inferior_data_cleanup): Remove.
9400         (invalidate_auxv_cache_inf): Rewrite.
9401         (get_auxv_inferior_data, _initialize_auxv): Update.
9402
9403 2019-05-08  Tom Tromey  <tom@tromey.com>
9404
9405         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9406         (symfile_debug_objfile_data_key): Change type.
9407         (symfile_debug_installed, debug_qf_has_symbols)
9408         (debug_qf_find_last_source_symtab)
9409         (debug_qf_forget_cached_source_info)
9410         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9411         (debug_qf_print_stats, debug_qf_dump)
9412         (debug_qf_expand_symtabs_for_function)
9413         (debug_qf_expand_all_symtabs)
9414         (debug_qf_expand_symtabs_with_fullname)
9415         (debug_qf_map_matching_symbols)
9416         (debug_qf_expand_symtabs_matching)
9417         (debug_qf_find_pc_sect_compunit_symtab)
9418         (debug_qf_map_symbol_filenames)
9419         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9420         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9421         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9422         (debug_sym_read_linetable, debug_sym_relocate): Update.
9423         (symfile_debug_free_objfile): Remove.
9424         (install_symfile_debug_logging, _initialize_symfile_debug):
9425         Update.
9426
9427 2019-05-08  Tom Tromey  <tom@tromey.com>
9428
9429         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9430         allocate_on_obstack.
9431         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9432         (get_dwarf2_per_objfile): Update.
9433         (set_dwarf2_per_objfile): Remove.
9434         (dwarf2_has_info, dwarf2_get_section_info): Update.
9435         (dwarf2_free_objfile): Remove.
9436         (_initialize_dwarf2_read): Update.
9437
9438 2019-05-08  Tom Tromey  <tom@tromey.com>
9439
9440         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9441         initializers.
9442         <unsupported_script_warning_printed,
9443         script_not_found_warning_printed>: Now bool.
9444         (auto_load_pspace_data): Change type.
9445         (~auto_load_pspace_info): Rename from
9446         auto_load_pspace_data_cleanup.
9447         (get_auto_load_pspace_data, init_loaded_scripts_info)
9448         (clear_section_scripts, maybe_print_unsupported_script_warning)
9449         (maybe_print_script_not_found_warning, _initialize_auto_load):
9450         Update.
9451
9452 2019-05-08  Tom Tromey  <tom@tromey.com>
9453
9454         * objfiles.c (objfile_pspace_info): Add destructor and
9455         initializers.
9456         (objfiles_pspace_data): Change type.
9457         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9458         (get_objfile_pspace_data): Update.
9459         (objfiles_bfd_data): Change type.
9460         (get_objfile_bfd_data): Update.
9461         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9462
9463 2019-05-08  Tom Tromey  <tom@tromey.com>
9464
9465         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9466         Change type.
9467         (get_catch_syscall_inferior_data): Update.
9468         (catch_syscall_inferior_data_cleanup): Remove.
9469         (_initialize_break_catch_syscall): Update.
9470
9471 2019-05-08  Tom Tromey  <tom@tromey.com>
9472
9473         * inflow.c (struct terminal_info): Add destructor and
9474         initializers.
9475         (inflow_inferior_data): Change type.
9476         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9477         (get_inflow_inferior_data, inflow_inferior_exit)
9478         (swap_terminal_info, _initialize_inflow): Update.
9479
9480 2019-05-08  Tom Tromey  <tom@tromey.com>
9481
9482         * target-dcache.c (target_dcache_cleanup): Remove.
9483         (target_dcache_aspace_key): Change type.
9484         (target_dcache_init_p, target_dcache_invalidate)
9485         (target_dcache_get, target_dcache_get_or_init)
9486         (_initialize_target_dcache): Update.
9487         * dcache.h (struct dcache_deleter): New.
9488
9489 2019-05-08  Tom Tromey  <tom@tromey.com>
9490
9491         * symtab.c (struct symbol_cache): Add destructor and
9492         initializers.
9493         (symbol_cache_key): Move.  Change type.
9494         (make_symbol_cache, free_symbol_cache): Remove.
9495         (get_symbol_cache): Update.
9496         (symbol_cache_cleanup): Remove.
9497         (ALL_PSPACES, symbol_cache_flush)
9498         (maintenance_print_symbol_cache)
9499         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9500         Update.
9501
9502 2019-05-08  Tom Tromey  <tom@tromey.com>
9503
9504         * symtab.c (struct main_info): Add destructor and initializers.
9505         (main_progspace_key): Move.  Change type.
9506         (get_main_info): Update.
9507         (main_info_cleanup): Remove.
9508         (_initialize_symtab): Update.
9509
9510 2019-05-08  Tom Tromey  <tom@tromey.com>
9511
9512         * registry.h (DECLARE_REGISTRY): Define the _key class.
9513
9514 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * NEWS: Merge two 'New commands' sections.
9517
9518 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9519
9520         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9521         parameter and use Ada language definition instead.
9522         (ada_val_print_ptr): Remove unused language parameter.
9523         (ada_val_print_num): Remove language parameter and use Ada language
9524         definition instead.
9525         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9526         parameter.
9527         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9528         parameter and use Ada language definition instead.
9529         (ada_val_print_1): Update all ada_val_print_xxx calls.
9530         Remove language parameter.
9531         (ada_val_print): Update ada_val_print_1 call.
9532
9533 2019-05-08  Tom Tromey  <tromey@adacore.com>
9534
9535         * remote.c (remote_hw_watchpoint_limit)
9536         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9537         Now static.
9538
9539 2019-05-08  Tom Tromey  <tromey@adacore.com>
9540
9541         * maint.c (_initialize_maint_cmds): Move initialization code to
9542         remote.c.
9543         (watchdog, show_watchdog): Move to remote.c.
9544         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9545         "watchdog" static.
9546         (_initialize_remote): Move initialization code from maint.c.
9547         * defs.h (watchdog): Don't declare.
9548
9549 2019-05-08  Tom Tromey  <tromey@adacore.com>
9550
9551         * tui/tui-interp.c: Include main.h.
9552         * interps.c: Include main.h.
9553         * main.h (interpreter_p): Declare.
9554         * defs.h (interpreter_p): Don't declare.
9555
9556 2019-05-08  Tom Tromey  <tromey@adacore.com>
9557
9558         * dwarf2loc.c: Include dwarf2read.h.
9559         * defs.h (read_unsigned_leb128): Don't declare.
9560         * dwarf2read.h (read_unsigned_leb128): Declare.
9561
9562 2019-05-08  Tom Tromey  <tromey@adacore.com>
9563
9564         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9565         method.
9566
9567 2019-05-08  Tom Tromey  <tromey@adacore.com>
9568
9569         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9570         when no wrap column is set.
9571
9572 2019-05-08  Tom Tromey  <tromey@adacore.com>
9573
9574         * c-lang.c (c_get_string): Handle non-C-style arrays.
9575
9576 2019-05-08  Tom Tromey  <tromey@adacore.com>
9577
9578         * typeprint.c (print_offset_data::update): Print the bit offset,
9579         not the number of bits remaining.
9580
9581 2019-05-08  Tom Tromey  <tromey@adacore.com>
9582
9583         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9584         padding at end of comment.
9585
9586 2019-05-08  Tom Tromey  <tromey@adacore.com>
9587
9588         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9589         Compare main types.
9590
9591 2019-05-06  Tom Tromey  <tom@tromey.com>
9592
9593         * common/scoped_mmap.c: Include common-defs.h.
9594         * common/scoped_mmap.h: Don't include config.h.
9595
9596 2019-05-04  Tom Tromey  <tom@tromey.com>
9597
9598         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9599         (struct aarch64_call_info): Add initializers.
9600         <si>: Now a std::vector.
9601         (pass_on_stack, aarch64_push_dummy_call): Update.
9602
9603 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9604             Tom Tromey  <tom@tromey.com>
9605
9606         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9607         (ppc_threads): Now a std::vector.  Now static.
9608         (hwdebug_find_thread_points_by_tid)
9609         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9610         Update.
9611
9612 2019-05-04  Tom Tromey  <tom@tromey.com>
9613
9614         * arc-tdep.c (arc_tdesc_init): Return bool.
9615
9616 2019-05-04  Tom Tromey  <tom@tromey.com>
9617
9618         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9619         Use gdb_assert_not_reached.
9620
9621 2019-05-04  Tom Tromey  <tom@tromey.com>
9622
9623         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9624         "false".
9625
9626 2019-05-04  Tom Tromey  <tom@tromey.com>
9627
9628         * arc-tdep.c (arc_tdesc_init): Use bool.
9629
9630 2019-05-04  Tom Tromey  <tom@tromey.com>
9631
9632         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9633
9634 2019-05-04  Tom Tromey  <tom@tromey.com>
9635
9636         * cli/cli-cmds.c (valid_command_p): Return bool.
9637
9638 2019-05-04  Tom Tromey  <tom@tromey.com>
9639
9640         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9641         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9642
9643 2019-05-04  Raul Tambre  <raul@tambre.ee>
9644
9645         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9646         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9647         operator for comparison.
9648
9649 2019-05-04  Tom Tromey  <tom@tromey.com>
9650
9651         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9652         (lookup_partial_symbol, print_partial_symbols)
9653         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9654         (psymbol_compare): Update.
9655         (add_psymbol_to_bcache): Clear the entire psymbol.
9656         (maintenance_check_psymtabs): Update.
9657         * psympriv.h (struct partial_symbol): Don't derive from
9658         general_symbol_info.
9659         <obj_section, unrelocated_address, address,
9660         set_unrelocated_address>: Update.
9661         <ginfo>: New member.
9662         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9663         (debug_names::write_psymbols): Update.
9664
9665 2019-05-04  Tom de Vries  <tdevries@suse.de>
9666
9667         * contrib/cc-with-tweaks.sh: Support -n arg.
9668
9669 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9670
9671         * corelow.c (core_target::detach): Ensure frame cache and
9672         register caches are cleared.
9673         inferior.c (exit_inferior_1): Likewise.
9674
9675 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9676             Tom Tromey  <tom@tromey.com>
9677
9678         * dictionary.c (collate_pending_symbols_by_language): Remove
9679         "struct" from foreach.
9680         * symtab.c (lookup_global_symbol_from_objfile)
9681         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9682         foreach.
9683         * ser-tcp.c (net_open): Remove "struct" from foreach.
9684         * objfiles.c (objfile_relocate, objfile_rebase)
9685         (objfile_has_symbols): Remove "struct" from foreach.
9686         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9687         from foreach.
9688         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9689         foreach.
9690         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9691         "struct" from foreach.
9692         * ada-lang.c (create_excep_cond_exprs)
9693         (ada_exception_catchpoint_cond_string): Remove "struct" from
9694         foreach.
9695
9696 2019-05-03  Tom Tromey  <tromey@adacore.com>
9697
9698         * ada-exp.y (convert_char_literal): Check suffix of each
9699         enumerator.
9700
9701 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9702
9703         PR ada/21406:
9704         * ada-exp.y (yywrap): Don't define.
9705         * ada-lex.l (%option): Add noyywrap
9706         (yywrap): Remove.
9707
9708 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9709
9710         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9711         _WIN32_WINNT to the XP level, unless already defined to a higher
9712         level.
9713
9714         * unittests/parse-connection-spec-selftests.c:
9715         * ser-tcp.c:
9716         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9717         override.
9718
9719         * symfile.c (find_separate_debug_file): Remove colon from the
9720         drive spec of DOS/Windows file names of the target, so that the
9721         file name produced from DEBUGDIR and the target's directory will
9722         be valid on DOS/Windows systems.
9723
9724 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9725
9726         * rust-lang.c (val_print_struct): Handle printing structures
9727         containing strings.
9728
9729 2019-05-02  Tom Tromey  <tromey@adacore.com>
9730
9731         * valarith.c (_initialize_valarith): Remove.
9732
9733 2019-05-01  Tom Tromey  <tromey@adacore.com>
9734
9735         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9736         bitfields.
9737
9738 2019-05-01  Tom Tromey  <tromey@adacore.com>
9739
9740         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9741         for big-endian copies.
9742
9743 2019-04-30  Ali Tamur  <tamur@google.com>
9744         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9745         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9746         (read_3_bytes): New function.
9747
9748 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9749
9750         * windows-nat.c (main_thread_id): Delete.
9751         (handle_output_debug_string): Replace main_thread_id by
9752         current_event.dwThreadId.
9753         (fake_create_process): Likewise.
9754         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9755         Do not set main_thread_id.
9756         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9757         current_event.dwThreadId.
9758         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9759
9760 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9761
9762         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9763         Use current_event.dwThreadId instead of main_thread_id.
9764
9765 2019-04-30  Tom Tromey  <tromey@adacore.com>
9766
9767         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9768         (create_excep_cond_exprs): Iterate over program spaces.
9769         (ada_exception_catchpoint_cond_string): Examine all minimal
9770         symbols for exception types.
9771
9772 2019-04-30  Tom Tromey  <tromey@adacore.com>
9773
9774         PR c++/24470:
9775         * dwarf2read.c (process_structure_scope): Handle case where type
9776         has template parameters but no symbol was created.
9777
9778 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9779             Chris January  <chris.january@arm.com>
9780
9781         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9782         qualifier.
9783         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9784
9785 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9786
9787         * f-typeprint.c (f_print_type): Update rules for printing
9788         whitespace.
9789         (f_type_print_varspec_suffix): Likewise.
9790
9791 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9792             Chris January  <chris.january@arm.com>
9793
9794         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9795         function arguments.
9796
9797 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9798
9799         * f-lang.c (build_fortran_types): Change name of void type to
9800         lower case.
9801         * f-typeprint.c (f_type_print_base): Print the name of the void
9802         type, rather than a fixed string.
9803         * f-valprint.c (f_decorations): Use lower case void string.
9804
9805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9806             Chris January  <chris.january@arm.com>
9807
9808         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9809         types for Fortran.
9810
9811 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9812             Chris January  <chris.january@arm.com>
9813             David Lecomber  <david.lecomber@arm.com>
9814
9815         * f-exp.y (BINOP_INTRINSIC): New token.
9816         (exp): New parser rule handling BINOP_INTRINSIC.
9817         (f77_keywords): Add new builtin procedures.
9818         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9819         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9820         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9821         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9822         (print_unop_subexp_f): New function.
9823         (print_binop_subexp_f): New function.
9824         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9825         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9826         (dump_subexp_body_f): Likewise.
9827         (operator_check_f): Likewise.
9828         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9829         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9830
9831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9832
9833         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9834         UNOP_KIND.
9835         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9836         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9837         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9838         (operator_length_f): New fuction.
9839         (print_subexp_f): New function.
9840         (op_name_f): New function.
9841         (dump_subexp_body_f): New function.
9842         (operator_check_f): New function.
9843         (exp_descriptor_f): Replace standard expression handling functions
9844         with new functions.
9845         * gdb/fortran-operator.def: New file.
9846         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9847         * gdb/std-operator.def: Remove UNOP_KIND.
9848
9849 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9850
9851         * std-operator.def: Remove unbalanced, stray double quote
9852         character.
9853
9854 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9855             Chris January  <chris.january@arm.com>
9856             Daniel Everett  <daniel.everett@arm.com>
9857             Nick Forrington  <nick.forrington@arm.com>
9858             Richard Bunt  <richard.bunt@arm.com>
9859
9860         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9861         of depth when printing anonymous structs or unions.
9862         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9863         Don't print either the top-level value, or the children if the
9864         max-depth is exceeded.
9865         (ppscm_print_children): When printing the key of a map, allow one
9866         extra level of depth.
9867         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9868         print either the top-level value, or the children if the max-depth
9869         is exceeded.
9870         (print_children): When printing the key of a map, allow one extra
9871         level of depth.
9872         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9873         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9874         (user_print_options): Initialise max_depth field.
9875         (val_print_scalar_or_string_type_p): New function.
9876         (val_print): Check to see if the max depth has been reached.
9877         (val_print_check_max_depth): Define new function.
9878         (show_print_max_depth): New function.
9879         (_initialize_valprint): Add 'print max-depth' option.
9880         * valprint.h (struct value_print_options) <max_depth>: New field.
9881         (val_print_check_max_depth): Declare new function.
9882         * NEWS: Document new feature.
9883
9884 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9885
9886         * ada-lang.c (ada_language_defn): Initialise new field.
9887         * c-lang.c (c_is_string_type_p): New function.
9888         (c_language_defn): Initialise new field.
9889         (cplus_language_defn): Initialise new field.
9890         (asm_language_defn): Initialise new field.
9891         (minimal_language_defn): Initialise new field.
9892         * c-lang.h (c_is_string_type_p): Declare new function.
9893         * d-lang.c (d_language_defn): Initialise new field.
9894         * f-lang.c (f_is_string_type_p): New function.
9895         (f_language_defn): Initialise new field.
9896         * go-lang.c (go_is_string_type_p): New function.
9897         (go_language_defn): Initialise new field.
9898         * language.c (default_is_string_type_p): New function.
9899         (unknown_language_defn): Initialise new field.
9900         (auto_language_defn): Initialise new field.
9901         * language.h (struct language_defn) <la_is_string_type_p>: New
9902         member variable.
9903         (default_is_string_type_p): Declare new function.
9904         * m2-lang.c (m2_language_defn): Initialise new field.
9905         * objc-lang.c (objc_language_defn): Initialise new field.
9906         * opencl-lang.c (opencl_language_defn): Initialise new field.
9907         * p-lang.c (pascal_is_string_type_p): New function.
9908         (pascal_language_defn): Initialise new field.
9909         * rust-lang.c (rust_is_string_type_p): New function.
9910         (rust_language_defn): Initialise new field.
9911
9912 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9913
9914         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9915         New field.
9916         * ada-lang.c (ada_language_defn): Initialise new field.
9917         * c-lang.c (c_language_defn): Likewise.
9918         (cplus_language_defn): Likewise.
9919         (asm_language_defn): Likewise.
9920         (minimal_language_defn): Likewise.
9921         * d-lang.c (d_language_defn): Likewise.
9922         * f-lang.c (f_language_defn): Likewise.
9923         * go-lang.c (go_language_defn): Likewise.
9924         * language.c (unknown_language_defn): Likewise.
9925         (auto_language_defn): Likewise.
9926         * m2-lang.c (m2_language_defn): Likewise.
9927         * objc-lang.c (objc_language_defn): Likewise.
9928         * opencl-lang.c (opencl_language_defn): Likewise.
9929         * p-lang.c (pascal_language_defn): Likewise.
9930         * rust-lang.c (rust_language_defn): Likewise.
9931
9932 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * ada-lang.c (ada_is_character_type): Change return type to bool.
9935         (ada_is_string_type): Likewise.
9936         * ada-lang.h (ada_is_character_type): Update declaration
9937         (ada_is_string_type): Likewise.
9938
9939 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9940
9941         Support style in 'frame|thread apply'
9942
9943         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9944         * record.c (record_start, record_stop): Update callers of
9945         execute_command_to_string with false.
9946         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9947         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9948         methods.
9949         (class string_file): New constructor with term_out parameter.
9950         Override methods term_out and can_emit_style_escape.  New member
9951         term_out.
9952         (class stdio_file): Override can_emit_style_escape.
9953         (class tee_file): Override term_out and can_emit_style_escape.
9954         * utils.h (can_emit_style_escape): Remove.
9955         * utils.c (can_emit_style_escape): Likewise.
9956         Update all callers of can_emit_style_escape (SOMESTREAM) to
9957         SOMESTREAM->can_emit_style_escape.
9958         * source-cache.c (source_cache::get_source_lines): Likewise.
9959         * stack.c (frame_apply_command_count): Call execute_command_to_string
9960         passing the term_out characteristic of the current gdb_stdout.
9961         * thread.c (thr_try_catch_cmd): Likewise.
9962         * top.c (execute_command_to_string): pass term_out parameter
9963         to construct the string_file for the command output.
9964         * ui-file.c (term_cli_styling): New function (most code moved
9965         from utils.c can_emit_style_escape).
9966         (string_file::string_file, string_file::can_emit_style_escape,
9967         stdio_file::can_emit_style_escape, tee_file::term_out,
9968         tee_file::can_emit_style_escape): New functions.
9969
9970 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9971
9972         * NEWS: Mention the new set|show may-call-functions.
9973         * infcall.c (may_call_functions_p): New variable.
9974         (show_may_call_functions_p): New function.
9975         (call_function_by_hand_dummy): Throws an error if not
9976         may-call-functions.
9977         (_initialize_infcall): Call add_setshow_boolean_cmd for
9978         may-call-functions.
9979
9980 2019-04-25  Keith Seitz  <keiths@redhat.com>
9981
9982         PR c++/24367
9983         * cp-support.c (inspect_type): Don't attempt substitutions
9984         of symbol with the same name.
9985
9986 2019-04-25  Tom Tromey  <tromey@adacore.com>
9987
9988         PR gdb/24475:
9989         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9990         static.
9991
9992 2019-04-25  Tom Tromey  <tromey@adacore.com>
9993
9994         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9995         rvalue reference.
9996         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9997         (gdb_xml_parser::parse): Use std::move.
9998         * python/python-internal.h (gdbpy_convert_exception): Take a const
9999         reference.
10000         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10001         std::move.
10002         * python/py-utils.c (gdbpy_convert_exception): Take a const
10003         reference.
10004         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10005         Use std::move.
10006         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10007         Use std::move.
10008         * mi/mi-main.c (mi_print_exception): Take a const reference.
10009         * main.c (handle_command_errors): Take a const reference.
10010         * linespec.c (parse_linespec): Use std::move.
10011         * infcall.c (run_inferior_call): Use std::move.
10012         (call_function_by_hand_dummy): Use std::move.
10013         * exec.c (try_open_exec_file): Use std::move.
10014         * exceptions.h (exception_print, exception_fprintf)
10015         (exception_print_same): Update.
10016         * exceptions.c (print_exception, exception_print)
10017         (exception_fprintf, exception_print_same): Change parameters to
10018         const reference.
10019         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10020         * common/new-op.c: Use std::move.
10021         * common/common-exceptions.h (struct gdb_exception): Add move
10022         constructor.
10023         (struct gdb_exception_error, struct gdb_exception_quit, struct
10024         gdb_quit_bad_alloc): Change constructor to move constructor.
10025         (throw_exception): Change parameter to rvalue reference.
10026         * common/common-exceptions.c (throw_exception): Take rvalue
10027         reference.
10028         * cli/cli-interp.c (safe_execute_command): Use std::move.
10029         * breakpoint.c (insert_bp_location, location_to_sals): Use
10030         std::move.
10031
10032 2019-04-25  Tom Tromey  <tromey@adacore.com>
10033
10034         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10035         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10036         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10037         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10038         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10039         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10040         guile/scm-value.c: Use unpack.
10041         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10042         gdbscm_gdb_exception.
10043         (gdbscm_throw_gdb_exception): Likewise.
10044         (struct gdbscm_gdb_exception): New.
10045         (unpack): New function.
10046         (gdbscm_wrap): Use unpack.
10047
10048 2019-04-25  Tom Tromey  <tromey@adacore.com>
10049
10050         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10051         (gdb_rl_callback_handler): Use std::move.
10052         * common/common-exceptions.h (struct gdb_exception): Add move
10053         assignment operator.
10054         (throw_exception_sjlj): Change "exception" to const reference.
10055         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10056         (throw_exception_sjlj): Change "exception" to const reference.
10057
10058 2019-04-25  Tom Tromey  <tromey@adacore.com>
10059
10060         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10061         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10062         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10063         Update.
10064         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10065         Update.
10066         * mi/mi-interp.c (mi_interp::exec): Update.
10067         * linespec.c (parse_linespec): Update.
10068         * infcall.c (run_inferior_call): Update.
10069         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10070         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10071         (gdbscm_lookup_global_symbol): Update.
10072         * guile/scm-param.c (gdbscm_parameter_value): Update.
10073         * guile/scm-frame.c (gdbscm_frame_read_register)
10074         (gdbscm_frame_read_var): Update.
10075         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10076         * exec.c (try_open_exec_file): Update.
10077         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10078         (gdb_rl_callback_handler): Update.
10079         * common/common-exceptions.h (exception_none): Don't declare.
10080         * common/common-exceptions.c (exception_none): Don't define.
10081         (struct catcher) <exception>: Update.
10082         * cli/cli-interp.c (safe_execute_command): Update.
10083         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10084
10085 2019-04-25  Ali Tamur  <tamur@google.com>
10086
10087         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10088         (read_attribute_value): Likewise.
10089         (dwarf2_read_addr_index): Update comment.
10090         (read_str_index): Add DW_FORM_strx.
10091         (dwarf2_string_attr): Likewise.
10092         (dwarf2_const_value_attr): Likewise.
10093         (dump_die_shallow): Likewise.
10094         (dwarf2_fetch_constant_bytes): Likewise.
10095         (skip_form_bytes): Likewise.
10096         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10097
10098 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10099
10100         PR corefiles/11608
10101         PR corefiles/18187
10102         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10103         OFFSET.  Verify if current mapping contains an ELF header.
10104         (linux_find_memory_regions_full): Adjust call to
10105         dump_mapping_p.
10106
10107 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10108             Kang Li <kanglictf@gmail.com>
10109
10110         PR gdb/21600
10111
10112         * dwarf2-frame.c (read_initial_length): Be consistent about using
10113         unsigned representation of length.
10114         (decode_frame_entry_1): Likewise.  Check for wraparound of
10115         end pointer as well as buffer overflow.
10116
10117 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10118
10119         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10120         "vq".
10121
10122 2019-04-24  Tom Tromey  <tromey@adacore.com>
10123
10124         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10125
10126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10127
10128         * s12z-tdep.c (s12z_unwind_pc): Delete.
10129         (s12z_unwind_sp): Delete.
10130         (s12z_gdbarch_init): Don't register deleted functions with
10131         gdbarch.
10132
10133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10134
10135         * rl78-tdep.c (rl78_unwind_sp): Delete.
10136         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10137
10138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10139
10140         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10141         (xstormy16_unwind_pc): Delete.
10142         (xstormy16_dummy_id): Delete.
10143         (xstormy16_gdbarch_init): Don't register deleted functions with
10144         gdbarch.
10145
10146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10147
10148         * vax-tdep.c (vax_unwind_pc): Delete.
10149         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10150
10151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10152
10153         * v850-tdep.c (v850_unwind_sp): Delete.
10154         (v850_unwind_pc): Delete.
10155         (v850_dummy_id): Delete.
10156         (v850_gdbarch_init): Don't register deleted functions with
10157         gdbarch.
10158
10159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10160
10161         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10162         (tilegx_unwind_pc): Delete.
10163         (tilegx_unwind_dummy_id): Delete.
10164         (tilegx_gdbarch_init): Don't register deleted functions with
10165         gdbarch.
10166
10167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10168
10169         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10170         (tic6x_dummy_id): Delete.
10171         (tic6x_gdbarch_init): Don't register deleted functions with
10172         gdbarch.
10173
10174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * sparc-tdep.c (sparc_unwind_pc): Delete.
10177         (sparc32_gdbarch_init): Don't register deleted function with
10178         gdbarch.
10179
10180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10181
10182         * sh-tdep.c (sh_unwind_sp): Delete.
10183         (sh_unwind_pc): Delete.
10184         (sh_dummy_id): Delete.
10185         (sh_gdbarch_init): Don't register deleted functions with
10186         gdbarch.
10187
10188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10189
10190         * score-tdep.c (score_unwind_sp): Delete.
10191         (score_unwind_pc): Delete.
10192         (score_dummy_id): Delete.
10193         (score_gdbarch_init): Don't register deleted functions with
10194         gdbarch.
10195
10196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10197
10198         * rx-tdep.c (rx_unwind_pc): Delete.
10199         (rx_unwind_sp): Delete.
10200         (rx_dummy_id): Delete.
10201         (rx_gdbarch_init): Don't register deleted functions with
10202         gdbarch.  Update comment.
10203
10204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10205
10206         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10207         (rs6000_dummy_id): Delete.
10208         (rs6000_gdbarch_init): Don't register deleted functions with
10209         gdbarch.
10210
10211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10212
10213         * or1k-tdep.c (or1k_dummy_id): Delete.
10214         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10215
10216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10217
10218         * nios2-tdep.c (nios2_dummy_id): Delete.
10219         (nios2_unwind_sp): Delete.
10220         (nios2_gdbarch_init): Don't register deleted functions with
10221         gdbarch.
10222
10223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10224
10225         * nds32-tdep.c (nds32_dummy_id): Delete.
10226         (nds32_unwind_pc): Delete.
10227         (nds32_unwind_sp): Delete.
10228         (nds32_gdbarch_init): Don't register deleted functions with
10229         gdbarch.
10230
10231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10232
10233         * msp430-tdep.c (msp430_unwind_pc): Delete.
10234         (msp430_unwind_sp): Delete.
10235         (msp430_dummy_id): Delete.
10236         (msp430_gdbarch_init): Don't register deleted functions with
10237         gdbarch.
10238
10239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10240
10241         * moxie-tdep.c (moxie_unwind_sp): Delete.
10242         (moxie_unwind_pc): Delete.
10243         (moxie_dummy_id): Delete.
10244         (moxie_gdbarch_init): Don't register deleted functions with
10245         gdbarch.
10246
10247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10250         (mn10300_unwind_pc): Delete.
10251         (mn10300_unwind_sp): Delete.
10252         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10253         mn10300_unwind_sp.
10254         (mn10300_frame_unwind_init): Don't register deleted functions with
10255         gdbarch.
10256
10257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10258
10259         * mep-tdep.c (mep_unwind_pc): Delete.
10260         (mep_unwind_sp): Delete.
10261         (mep_dummy_id): Delete.
10262         (mep_gdbarch_init): Don't register deleted functions with
10263         gdbarch.
10264
10265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10266
10267         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10268         (m68hc11_unwind_sp): Delete.
10269         (m68hc11_gdbarch_init): Don't register deleted functions with
10270         gdbarch.
10271
10272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10273
10274         * m32r-tdep.c (m32r_unwind_sp): Delete.
10275         (m32r_unwind_pc): Delete.
10276         (m32r_dummy_id): Delete.
10277         (m32r_gdbarch_init): Don't register deleted functions with
10278         gdbarch.
10279
10280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10281
10282         * m32c-tdep.c (m32c_unwind_pc): Delete.
10283         (m32c_unwind_sp): Delete.
10284         (m32c_dummy_id): Delete.
10285         (m32c_gdbarch_init): Don't register deleted functions with
10286         gdbarch.
10287
10288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10289
10290         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10291         (lm32_unwind_pc): Delete.
10292         (lm32_dummy_id): Delete.
10293         (lm32_gdbarch_init): Don't register deleted functions with
10294         gdbarch.
10295
10296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10299         (iq2000_unwind_pc): Delete.
10300         (iq2000_dummy_id): Delete.
10301         (iq2000_gdbarch_init): Don't register deleted functions with
10302         gdbarch.
10303
10304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10305
10306         * nds32-tdep.c (nds32_type_align): Delete.
10307         (nds32_push_dummy_call): Use type_align instead.
10308
10309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10310
10311         * arm-tdep.c (arm_type_align): Only handle vector override case.
10312         (arm_push_dummy_call): Use type_align.
10313         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10314
10315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10316
10317         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10318         case.
10319         (pass_on_stack): Use type_align.
10320         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10321         function.
10322
10323 2019-04-23  Tom Tromey  <tromey@adacore.com>
10324
10325         * dwarf2read.c (line_header::file_name_at): Remove unused
10326         overload.
10327
10328 2019-04-23  Tom de Vries  <tdevries@suse.de>
10329
10330         PR gdb/24438
10331         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10332         invocation.
10333
10334
10335 2019-03-27  Ali Tamur  <tamur@google.com>
10336
10337         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10338         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10339         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10340         (dwarf_expr_context::get_addr_index): Likewise
10341         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10342         (symbol_needs_eval_context::get_addr_index): Likewise
10343         (disassemble_dwarf_expression): Add DW_OP_addrx
10344         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10345         (read_cutu_die_from_dwo): Update comment
10346         (skip_one_die): Add DW_FORM_addrx
10347         (read_attribute_value): Likewise
10348         (var_decode_location): Add DW_OP_addrx
10349         (dwarf2_const_value_attr): Add DW_FORM_addrx
10350         (dump_die_shallow): Likewise
10351         (dwarf2_fetch_constant_bytes): Likewise
10352         (decode_locdesc): Add DW_OP_addrx
10353         (skip_form_bytes): Add DW_FORM_addrx
10354
10355 2019-04-22  Ali Tamur  <tamur@google.com>
10356
10357         * MAINTAINERS (Write After Approval): Add self.
10358
10359 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10360
10361         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10362         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10363         (open_symbol_file_object): Likewise.
10364         (svr4_default_sos): Add info parameter.
10365         (svr4_read_so_list): Likewise.
10366         (svr4_current_sos_direct): Adjust functions calls to pass down
10367         info.
10368         (svr4_current_sos_1): Add info parameter.
10369         (svr4_current_sos): Call get_svr4_info, pass info down to
10370         svr4_current_sos_1.
10371         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10372         get_svr4_info.
10373         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10374         get_svr4_info.
10375         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10376         to get_svr4_info.
10377         (probes_table_remove_objfile_probes): Likewise.
10378         (register_solib_event_probe): Add info parameter.
10379         (solist_update_incremental): Pass info parameter down to
10380         svr4_read_so_list.
10381         (disable_probes_interface): Add info parameter.
10382         (svr4_handle_solib_event): Pass current_program_space to
10383         get_svr4_info.  Adjust disable_probes_interface cleanup.
10384         (svr4_create_probe_breakpoints): Add info parameter, pass it
10385         down to register_solib_event_probe.
10386         (svr4_create_solib_event_breakpoints): Add info parameter,
10387         pass it down to svr4_create_probe_breakpoints.
10388         (enable_break): Pass info down to
10389         svr4_create_solib_event_breakpoints.
10390         (svr4_solib_create_inferior_hook): Pass current_program_space to
10391         get_svr4_info.
10392         (svr4_clear_solib): Likewise.
10393
10394 2019-04-22  Pedro Alves  <palves@redhat.com>
10395
10396         * solib-svr4.c (svr4_free_objfile_observer): New.
10397         (probe_and_action::objfile): New field.
10398         (probes_table_htab_remove_objfile_probes)
10399         (probes_table_remove_objfile_probes): New functions.
10400         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10401         in the new probe_and_action.  Don't store the probe in 'lookup'.
10402         (svr4_create_probe_breakpoints): Pass objfile to
10403         register_solib_event_probe.
10404         (_initialize_svr4_solib): Register a free_objfile observer.
10405
10406 2019-04-19  Tom Tromey  <tom@tromey.com>
10407
10408         * common/queue.h: Remove.
10409
10410 2019-04-19  Tom Tromey  <tom@tromey.com>
10411
10412         * event-loop.c: Don't include "common/queue.h".
10413
10414 2019-04-19  Tom Tromey  <tom@tromey.com>
10415
10416         * remote.c (remote_target): Use delete.
10417         * remote-notif.h: Include <list>, not "common/queue.h".
10418         (notif_client_p): Remove typedef.
10419         (remote_notif_state): Add constructor, destructor, initializer.
10420         <notif_queue>: Now a std::list.
10421         (remote_notif_state_xfree): Don't declare.
10422         * remote-notif.c (remote_notif_process, handle_notification)
10423         (remote_notif_state_allocate): Update.
10424         (~remote_notif_state): Rename from remote_notif_state_xfree.
10425
10426 2019-04-19  Tom Tromey  <tom@tromey.com>
10427
10428         * symfile.c (reread_symbols): Update.
10429         * objfiles.c (objfile_register_static_link)
10430         (objfile_lookup_static_link): Update
10431         (~objfile) Don't delete static_links.
10432         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10433
10434 2019-04-19  Tom Tromey  <tom@tromey.com>
10435
10436         * type-stack.h (struct type_stack) <insert>: Constify string.
10437         * type-stack.c (type_stack::insert): Constify string.
10438         * gdbtypes.h (lookup_template_type): Update.
10439         (address_space_name_to_int): Update.
10440         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10441         const.
10442         (lookup_template_type): Make name const.
10443         * c-exp.y: Update rules.
10444         (lex_one_token, classify_name, classify_inner_name)
10445         (c_print_token): Update.
10446         * p-exp.y: Update rules.
10447         (yylex): Update.
10448         * f-exp.y: Update rules.
10449         (yylex): Update.
10450         * d-exp.y: Update rules.
10451         (lex_one_token, classify_name, classify_inner_name): Update.
10452         * parse.c (write_dollar_variable, copy_name): Return std::string.
10453         * parser-defs.h (copy_name): Change return type.
10454         * m2-exp.y: Update rules.
10455         (yylex): Update.
10456         * go-exp.y (lex_one_token): Update.
10457         Update rules.
10458         (classify_unsafe_function, classify_packaged_name)
10459         (classify_name, yylex): Update.
10460
10461 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10462
10463         * configure.ac: add --enable-source-highlight switch.
10464         * configure: Regenerate.
10465         * top.c (print_gdb_version): plumb --enable-source-highlight
10466         status to "show configuration".
10467
10468 2019-04-19  Tom Tromey  <tromey@adacore.com>
10469
10470         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10471         Check ADA_TYPE_P.
10472         (empty_record, ada_template_to_fixed_record_type_1)
10473         (template_to_static_fixed_type)
10474         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10475         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10476         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10477         macros.
10478
10479 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10480
10481         PR symtab/24423:
10482         * source.c (print_source_lines_base): Advance "iter" when a
10483         control character is seen.
10484
10485 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10486
10487         * inferior.h (struct infcall_suspend_state_deleter):
10488         Catch exception in destructor to avoid crash.
10489
10490 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10491
10492         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10493         close to the add_com "shell".
10494
10495 2019-04-18  Tom Tromey  <tromey@adacore.com>
10496
10497         * process-stratum-target.h (class process_stratum_target)
10498         <stratum>: Add "final".
10499
10500 2019-04-17  Tom Tromey  <tromey@adacore.com>
10501
10502         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10503         against nullptr before use.
10504
10505 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10506
10507         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10508
10509 2019-04-17  Jim Wilson  <jimw@sifive.com>
10510             Andrew Burgess  <andrew.burgess@embecosm.com>
10511
10512         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10513         code read might fail, assume 4-byte breakpoint in that case.
10514
10515 2019-04-15  Leszek Swirski  <leszeks@google.com>
10516
10517         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10518         rather than a hand-rolled POD check when checking for forced MEMORY
10519         classification.
10520
10521 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10522
10523         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10524         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10525         function.
10526         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10527         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10528         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10529         declaration.
10530
10531 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10532
10533         * aarch64-linux-nat.c
10534         (aarch64_linux_nat_target::thread_architecture): Add override.
10535         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10536         each VQ.
10537
10538 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10539
10540         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10541
10542 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10543
10544         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10545         target types of size 96-bits, add some additional comments, and
10546         check that the builtin type we found was the correct size.
10547
10548 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10549
10550         * utils.c (prompt_for_continue): Don't restore the styling at the
10551         end, as applied_style has the wrong value.  This fixes styling in
10552         long lists of file names that are interrupted by the "Continue?"
10553         prompt.
10554
10555 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10558         * c-lang.c (c_language_defn): Likewise.
10559         (cplus_language_defn): Likewise.
10560         (asm_language_defn): Likewise.
10561         (minimal_language_defn): Likewise.
10562         * d-lang.c (d_language_defn): Likewise.
10563         * f-lang.c (f_language_defn): Likewise.
10564         * go-lang.c (go_language_defn): Likewise.
10565         * language.c (unknown_language_defn): Likewise.
10566         (auto_language_defn): Likewise.
10567         * language.h (struct language_defn): Remove la_magic field.
10568         (LANG_MAGIC): Delete.
10569         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10570         * objc-lang.c (objc_language_defn): Likewise.
10571         * opencl-lang.c (opencl_language_defn): Likewise.
10572         * p-lang.c (pascal_language_defn): Likewise.
10573         * rust-lang.c (rust_language_defn): Likewise.
10574
10575 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10576
10577         * riscv-tdep.c (riscv_type_align): New function.
10578         (riscv_type_alignment): Delete.
10579         (riscv_arg_location): Use 'type_align'.
10580         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10581
10582 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10583
10584         * gdbtypes.c (type_align): A struct with no non-static fields also
10585         has alignment of 1.
10586
10587 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10588
10589         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10590         component to 0.
10591         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10592         member.
10593         (riscv_struct_info::analyse): New implementation using new
10594         analyse_inner member function.
10595         (riscv_struct_info::field_offset): New member function.
10596         (riscv_struct_info::m_offsets): New member variable.
10597         (riscv_struct_info::analyse_inner): New private member function,
10598         takes the old implementation of riscv_struct_info::analyse but
10599         extended to track field offsets.
10600         (riscv_call_arg_struct): Update the struct folding special cases
10601         to handle cases where empty C++ structs, which are non-zero
10602         length, are found.
10603         (riscv_arg_location): Initialise the length of each location, a
10604         non-zero length now indicates the location is in use.
10605         (riscv_push_dummy_call): Allow for the first location having a
10606         non-zero offset when setting up arguments.
10607         (riscv_return_value): Likewise, but for return values.
10608
10609 2019-04-11  Tom Tromey  <tromey@adacore.com>
10610
10611         * utils.c (internal_vproblem): Make "msg" const.
10612
10613 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10614
10615         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10616         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10617         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10618         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10619
10620 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10621
10622         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10623         function.
10624         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10625         of amd64_collect_native_gregset.
10626         (amd64_linux_nat_target::store_registers): Likewise.
10627
10628 2019-04-10  Tom Tromey  <tom@tromey.com>
10629
10630         * symtab.c (lookup_global_symbol_from_objfile)
10631         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10632         * objfiles.h (class separate_debug_iterator): New.
10633         (class separate_debug_range): New.
10634         (struct objfile) <separate_debug_objfiles>: New method.
10635         (objfile_separate_debug_iterate): Don't declare.
10636         * objfiles.c (separate_debug_iterator::operator++): Rename from
10637         objfile_separate_debug_iterate.
10638         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10639         iterator.
10640         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10641         iterator.
10642
10643 2019-04-10  Tom Tromey  <tom@tromey.com>
10644
10645         * symfile.c (reread_symbols): Remove old comment.
10646         * objfiles.c (free_all_objfiles): Fix a typo.
10647
10648 2019-04-10  Tom Tromey  <tom@tromey.com>
10649
10650         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10651         * minsyms.c (lookup_minimal_symbol): Use foreach.
10652         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10653         (lookup_minimal_symbol_solib_trampoline): Likewise.
10654         * symfile.c (reread_symbols): Use foreach.
10655
10656 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10657             Tom Tromey  <tromey@adacore.com>
10658
10659         PR rust/24414:
10660         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10661         (rust_lex_int_test): Change "value" to be LONGEST.
10662         (rust_lex_tests): Add test for long integer literal.
10663
10664 2019-04-09  Tom Tromey  <tromey@adacore.com>
10665
10666         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10667         to bool.
10668         (extended_remote_target::attach): Update.
10669         (remote_target::remote_notice_new_inferior): Update.
10670         (remote_target::add_current_inferior_and_thread): Update.
10671         * inferior.c (exit_inferior_1): Use "false".
10672         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10673
10674 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10675
10676         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10677         the "start" command.
10678
10679 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10680
10681         * python/py-inferior.c (infpy_thread_from_thread_handle):
10682         Adjust comments to reflect renaming of thread_from_thread_handle
10683         to thread_from_handle.  Adjust keywords.  Fix type error message.
10684         (inferior_object_methods): Add thread_from_handle.  Retain
10685         thread_from_thread_handle, but mark it as deprecated.
10686
10687 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10688
10689         * gdbthread.h (find_thread_by_handle): Revise declaration.
10690         * thread.c (find_thread_by_handle): Likewise.  Adjust
10691         implementation too.
10692         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10693         support for buffer objects as handles.
10694
10695 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10696
10697         * python/py-infthread.c (thpy_thread_handle): New function.
10698         (thread_object_methods): Register thpy_thread_handle.
10699
10700 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10701
10702         * gdbthread.h (thread_to_thread_handle): Declare.
10703         * thread.c (gdbtypes.h): Include.
10704         (thread_to_thread_handle): New function.
10705
10706         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10707         (target_thread_info_to_thread_handle): Declare.
10708         * target.c (target_thread_info_to_thread_handle): New function.
10709         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10710         * target-delegates.c: Regenerate.
10711
10712         * linux-thread-db.c (class thread_db_target): Add method
10713         thread_info_to_thread_handle.
10714         (thread_db_target::thread_info_to_thread_handle): Define.
10715         * remote.c (class remote_target): Add new method
10716         thread_info_to_thread_handle.
10717         (remote_target::thread_info_to_thread_handle): Define.
10718
10719 2019-04-08  Pedro Alves  <palves@redhat.com>
10720
10721         * common/common-exceptions.c (throw_exception): Don't create
10722         named object to throw; throw directly.
10723         (throw_it): Likewise.  Don't initialize gdb_exception::message
10724         here, with new; pass FMT and AP to the ctor instead.
10725         * common/common-exceptions.h: Include <string>.
10726         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10727         const char *, va_list)): New ctor.  Use std::make_shared.
10728         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10729         errors)): Delete.
10730         (gdb_exception_error::gdb_exception_error(enum errors, const char
10731         *, va_list)): New.
10732         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10733         Add assertion.
10734         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10735         errors)): Delete.
10736         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10737         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10738         Add assertion.
10739
10740 2019-04-08  Tom Tromey  <tom@tromey.com>
10741
10742         * valops.c (value_rtti_indirect_type): Replace throw_exception
10743         with throw.
10744         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10745         with throw.
10746         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10747         throw.
10748         * target.c (target_translate_tls_address): Replace throw_exception
10749         with throw.
10750         * stack.c (frame_apply_command_count): Replace throw_exception
10751         with throw.
10752         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10753         throw.
10754         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10755         with throw.
10756         * rs6000-tdep.c (rs6000_frame_cache)
10757         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10758         * remote.c: Replace throw_exception with throw.
10759         * record-full.c (record_full_message, record_full_wait_1)
10760         (record_full_restore): Replace throw_exception with throw.
10761         * record-btrace.c:
10762         (get_thread_current_frame_id, record_btrace_start_replaying)
10763         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10764         (cmd_record_btrace_start): Replace throw_exception with throw.
10765         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10766         throw.
10767         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10768         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10769         * linespec.c:
10770         (find_linespec_symbols): Replace throw_exception with throw.
10771         * infrun.c (displaced_step_prepare, resume): Replace
10772         throw_exception with throw.
10773         * infcmd.c (post_create_inferior): Replace throw_exception with
10774         throw.
10775         * inf-loop.c (inferior_event_handler): Replace throw_exception
10776         with throw.
10777         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10778         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10779         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10780         (get_prev_frame_always, get_frame_pc_if_available)
10781         (get_frame_address_in_block_if_available, get_frame_language):
10782         Replace throw_exception with throw.
10783         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10784         throw_exception with throw.
10785         * eval.c (fetch_subexp_value, evaluate_var_value)
10786         (evaluate_funcall, evaluate_subexp_standard): Replace
10787         throw_exception with throw.
10788         * dwarf2loc.c (call_site_find_chain)
10789         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10790         Replace throw_exception with throw.
10791         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10792         with throw.
10793         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10794         throw.
10795         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10796         * completer.c (complete_line_internal): Replace throw_exception
10797         with throw.
10798         * compile/compile-object-run.c (compile_object_run): Replace
10799         throw_exception with throw.
10800         * cli/cli-script.c (process_next_line): Replace throw_exception
10801         with throw.
10802         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10803         (btrace_enable, btrace_maint_update_pt_packets): Replace
10804         throw_exception with throw.
10805         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10806         throw_exception with throw.
10807         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10808         throw_exception with throw.
10809         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10810         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10811         * aarch64-tdep.c (aarch64_make_prologue_cache)
10812         (aarch64_make_stub_cache): Replace throw_exception with throw.
10813
10814 2019-04-08  Tom Tromey  <tom@tromey.com>
10815
10816         * common/common-exceptions.c (throw_exception): Rename from
10817         throw_exception_cxx.  Remove old copy.  Make argument const.
10818         (throw_it): Create and throw exception objects directly.
10819         * common/common-exceptions.h (throw_exception): Make argument
10820         const.
10821         (struct gdb_exception_error): Add constructor.
10822         (struct gdb_exception_quit): Add constructor.
10823
10824 2019-04-08  Tom Tromey  <tom@tromey.com>
10825
10826         * common/common-exceptions.h (exception_rethrow): Don't declare.
10827         (TRY_SJLJ): Update comment.
10828         (TRY, CATCH, END_CATCH): Remove.
10829         * common/common-exceptions.c (exception_rethrow): Remove.
10830
10831 2019-04-08  Tom Tromey  <tom@tromey.com>
10832
10833         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10834         Remove.
10835         (gdb_exception_error): Rename from
10836         gdb_exception_RETURN_MASK_ERROR.
10837         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10838         (gdb_quit_bad_alloc): Update.
10839         * aarch64-tdep.c: Update.
10840         * ada-lang.c: Update.
10841         * ada-typeprint.c: Update.
10842         * ada-valprint.c: Update.
10843         * amd64-tdep.c: Update.
10844         * arch-utils.c: Update.
10845         * break-catch-throw.c: Update.
10846         * breakpoint.c: Update.
10847         * btrace.c: Update.
10848         * c-varobj.c: Update.
10849         * cli/cli-cmds.c: Update.
10850         * cli/cli-interp.c: Update.
10851         * cli/cli-script.c: Update.
10852         * common/common-exceptions.c: Update.
10853         * common/new-op.c: Update.
10854         * common/selftest.c: Update.
10855         * compile/compile-c-symbols.c: Update.
10856         * compile/compile-cplus-symbols.c: Update.
10857         * compile/compile-object-load.c: Update.
10858         * compile/compile-object-run.c: Update.
10859         * completer.c: Update.
10860         * corelow.c: Update.
10861         * cp-abi.c: Update.
10862         * cp-support.c: Update.
10863         * cp-valprint.c: Update.
10864         * darwin-nat.c: Update.
10865         * disasm-selftests.c: Update.
10866         * dtrace-probe.c: Update.
10867         * dwarf-index-cache.c: Update.
10868         * dwarf-index-write.c: Update.
10869         * dwarf2-frame-tailcall.c: Update.
10870         * dwarf2-frame.c: Update.
10871         * dwarf2loc.c: Update.
10872         * dwarf2read.c: Update.
10873         * eval.c: Update.
10874         * event-loop.c: Update.
10875         * event-top.c: Update.
10876         * exec.c: Update.
10877         * f-valprint.c: Update.
10878         * fbsd-tdep.c: Update.
10879         * frame-unwind.c: Update.
10880         * frame.c: Update.
10881         * gdbtypes.c: Update.
10882         * gnu-v3-abi.c: Update.
10883         * guile/guile-internal.h: Update.
10884         * guile/scm-block.c: Update.
10885         * guile/scm-breakpoint.c: Update.
10886         * guile/scm-cmd.c: Update.
10887         * guile/scm-disasm.c: Update.
10888         * guile/scm-frame.c: Update.
10889         * guile/scm-lazy-string.c: Update.
10890         * guile/scm-math.c: Update.
10891         * guile/scm-param.c: Update.
10892         * guile/scm-ports.c: Update.
10893         * guile/scm-pretty-print.c: Update.
10894         * guile/scm-symbol.c: Update.
10895         * guile/scm-symtab.c: Update.
10896         * guile/scm-type.c: Update.
10897         * guile/scm-value.c: Update.
10898         * i386-linux-tdep.c: Update.
10899         * i386-tdep.c: Update.
10900         * inf-loop.c: Update.
10901         * infcall.c: Update.
10902         * infcmd.c: Update.
10903         * infrun.c: Update.
10904         * jit.c: Update.
10905         * language.c: Update.
10906         * linespec.c: Update.
10907         * linux-fork.c: Update.
10908         * linux-nat.c: Update.
10909         * linux-tdep.c: Update.
10910         * linux-thread-db.c: Update.
10911         * main.c: Update.
10912         * mi/mi-cmd-break.c: Update.
10913         * mi/mi-cmd-stack.c: Update.
10914         * mi/mi-interp.c: Update.
10915         * mi/mi-main.c: Update.
10916         * objc-lang.c: Update.
10917         * p-valprint.c: Update.
10918         * parse.c: Update.
10919         * ppc-linux-tdep.c: Update.
10920         * printcmd.c: Update.
10921         * python/py-arch.c: Update.
10922         * python/py-breakpoint.c: Update.
10923         * python/py-cmd.c: Update.
10924         * python/py-finishbreakpoint.c: Update.
10925         * python/py-frame.c: Update.
10926         * python/py-framefilter.c: Update.
10927         * python/py-gdb-readline.c: Update.
10928         * python/py-inferior.c: Update.
10929         * python/py-infthread.c: Update.
10930         * python/py-lazy-string.c: Update.
10931         * python/py-linetable.c: Update.
10932         * python/py-objfile.c: Update.
10933         * python/py-param.c: Update.
10934         * python/py-prettyprint.c: Update.
10935         * python/py-progspace.c: Update.
10936         * python/py-record-btrace.c: Update.
10937         * python/py-record.c: Update.
10938         * python/py-symbol.c: Update.
10939         * python/py-type.c: Update.
10940         * python/py-unwind.c: Update.
10941         * python/py-utils.c: Update.
10942         * python/py-value.c: Update.
10943         * python/python.c: Update.
10944         * record-btrace.c: Update.
10945         * record-full.c: Update.
10946         * remote-fileio.c: Update.
10947         * remote.c: Update.
10948         * riscv-tdep.c: Update.
10949         * rs6000-aix-tdep.c: Update.
10950         * rs6000-tdep.c: Update.
10951         * rust-exp.y: Update.
10952         * rust-lang.c: Update.
10953         * s390-tdep.c: Update.
10954         * selftest-arch.c: Update.
10955         * solib-dsbt.c: Update.
10956         * solib-frv.c: Update.
10957         * solib-spu.c: Update.
10958         * solib-svr4.c: Update.
10959         * solib.c: Update.
10960         * sparc64-linux-tdep.c: Update.
10961         * stack.c: Update.
10962         * symfile-mem.c: Update.
10963         * symmisc.c: Update.
10964         * target.c: Update.
10965         * thread.c: Update.
10966         * top.c: Update.
10967         * tracefile-tfile.c: Update.
10968         * tui/tui.c: Update.
10969         * typeprint.c: Update.
10970         * unittests/cli-utils-selftests.c: Update.
10971         * unittests/parse-connection-spec-selftests.c: Update.
10972         * valops.c: Update.
10973         * valprint.c: Update.
10974         * value.c: Update.
10975         * varobj.c: Update.
10976         * windows-nat.c: Update.
10977         * x86-linux-nat.c: Update.
10978         * xml-support.c: Update.
10979
10980 2019-04-08  Tom Tromey  <tom@tromey.com>
10981
10982         * xml-support.c: Use C++ exception handling.
10983         * x86-linux-nat.c: Use C++ exception handling.
10984         * windows-nat.c: Use C++ exception handling.
10985         * varobj.c: Use C++ exception handling.
10986         * value.c: Use C++ exception handling.
10987         * valprint.c: Use C++ exception handling.
10988         * valops.c: Use C++ exception handling.
10989         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10990         handling.
10991         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10992         * typeprint.c: Use C++ exception handling.
10993         * tui/tui.c: Use C++ exception handling.
10994         * tracefile-tfile.c: Use C++ exception handling.
10995         * top.c: Use C++ exception handling.
10996         * thread.c: Use C++ exception handling.
10997         * target.c: Use C++ exception handling.
10998         * symmisc.c: Use C++ exception handling.
10999         * symfile-mem.c: Use C++ exception handling.
11000         * stack.c: Use C++ exception handling.
11001         * sparc64-linux-tdep.c: Use C++ exception handling.
11002         * solib.c: Use C++ exception handling.
11003         * solib-svr4.c: Use C++ exception handling.
11004         * solib-spu.c: Use C++ exception handling.
11005         * solib-frv.c: Use C++ exception handling.
11006         * solib-dsbt.c: Use C++ exception handling.
11007         * selftest-arch.c: Use C++ exception handling.
11008         * s390-tdep.c: Use C++ exception handling.
11009         * rust-lang.c: Use C++ exception handling.
11010         * rust-exp.y: Use C++ exception handling.
11011         * rs6000-tdep.c: Use C++ exception handling.
11012         * rs6000-aix-tdep.c: Use C++ exception handling.
11013         * riscv-tdep.c: Use C++ exception handling.
11014         * remote.c: Use C++ exception handling.
11015         * remote-fileio.c: Use C++ exception handling.
11016         * record-full.c: Use C++ exception handling.
11017         * record-btrace.c: Use C++ exception handling.
11018         * python/python.c: Use C++ exception handling.
11019         * python/py-value.c: Use C++ exception handling.
11020         * python/py-utils.c: Use C++ exception handling.
11021         * python/py-unwind.c: Use C++ exception handling.
11022         * python/py-type.c: Use C++ exception handling.
11023         * python/py-symbol.c: Use C++ exception handling.
11024         * python/py-record.c: Use C++ exception handling.
11025         * python/py-record-btrace.c: Use C++ exception handling.
11026         * python/py-progspace.c: Use C++ exception handling.
11027         * python/py-prettyprint.c: Use C++ exception handling.
11028         * python/py-param.c: Use C++ exception handling.
11029         * python/py-objfile.c: Use C++ exception handling.
11030         * python/py-linetable.c: Use C++ exception handling.
11031         * python/py-lazy-string.c: Use C++ exception handling.
11032         * python/py-infthread.c: Use C++ exception handling.
11033         * python/py-inferior.c: Use C++ exception handling.
11034         * python/py-gdb-readline.c: Use C++ exception handling.
11035         * python/py-framefilter.c: Use C++ exception handling.
11036         * python/py-frame.c: Use C++ exception handling.
11037         * python/py-finishbreakpoint.c: Use C++ exception handling.
11038         * python/py-cmd.c: Use C++ exception handling.
11039         * python/py-breakpoint.c: Use C++ exception handling.
11040         * python/py-arch.c: Use C++ exception handling.
11041         * printcmd.c: Use C++ exception handling.
11042         * ppc-linux-tdep.c: Use C++ exception handling.
11043         * parse.c: Use C++ exception handling.
11044         * p-valprint.c: Use C++ exception handling.
11045         * objc-lang.c: Use C++ exception handling.
11046         * mi/mi-main.c: Use C++ exception handling.
11047         * mi/mi-interp.c: Use C++ exception handling.
11048         * mi/mi-cmd-stack.c: Use C++ exception handling.
11049         * mi/mi-cmd-break.c: Use C++ exception handling.
11050         * main.c: Use C++ exception handling.
11051         * linux-thread-db.c: Use C++ exception handling.
11052         * linux-tdep.c: Use C++ exception handling.
11053         * linux-nat.c: Use C++ exception handling.
11054         * linux-fork.c: Use C++ exception handling.
11055         * linespec.c: Use C++ exception handling.
11056         * language.c: Use C++ exception handling.
11057         * jit.c: Use C++ exception handling.
11058         * infrun.c: Use C++ exception handling.
11059         * infcmd.c: Use C++ exception handling.
11060         * infcall.c: Use C++ exception handling.
11061         * inf-loop.c: Use C++ exception handling.
11062         * i386-tdep.c: Use C++ exception handling.
11063         * i386-linux-tdep.c: Use C++ exception handling.
11064         * guile/scm-value.c: Use C++ exception handling.
11065         * guile/scm-type.c: Use C++ exception handling.
11066         * guile/scm-symtab.c: Use C++ exception handling.
11067         * guile/scm-symbol.c: Use C++ exception handling.
11068         * guile/scm-pretty-print.c: Use C++ exception handling.
11069         * guile/scm-ports.c: Use C++ exception handling.
11070         * guile/scm-param.c: Use C++ exception handling.
11071         * guile/scm-math.c: Use C++ exception handling.
11072         * guile/scm-lazy-string.c: Use C++ exception handling.
11073         * guile/scm-frame.c: Use C++ exception handling.
11074         * guile/scm-disasm.c: Use C++ exception handling.
11075         * guile/scm-cmd.c: Use C++ exception handling.
11076         * guile/scm-breakpoint.c: Use C++ exception handling.
11077         * guile/scm-block.c: Use C++ exception handling.
11078         * guile/guile-internal.h: Use C++ exception handling.
11079         * gnu-v3-abi.c: Use C++ exception handling.
11080         * gdbtypes.c: Use C++ exception handling.
11081         * frame.c: Use C++ exception handling.
11082         * frame-unwind.c: Use C++ exception handling.
11083         * fbsd-tdep.c: Use C++ exception handling.
11084         * f-valprint.c: Use C++ exception handling.
11085         * exec.c: Use C++ exception handling.
11086         * event-top.c: Use C++ exception handling.
11087         * event-loop.c: Use C++ exception handling.
11088         * eval.c: Use C++ exception handling.
11089         * dwarf2read.c: Use C++ exception handling.
11090         * dwarf2loc.c: Use C++ exception handling.
11091         * dwarf2-frame.c: Use C++ exception handling.
11092         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11093         * dwarf-index-write.c: Use C++ exception handling.
11094         * dwarf-index-cache.c: Use C++ exception handling.
11095         * dtrace-probe.c: Use C++ exception handling.
11096         * disasm-selftests.c: Use C++ exception handling.
11097         * darwin-nat.c: Use C++ exception handling.
11098         * cp-valprint.c: Use C++ exception handling.
11099         * cp-support.c: Use C++ exception handling.
11100         * cp-abi.c: Use C++ exception handling.
11101         * corelow.c: Use C++ exception handling.
11102         * completer.c: Use C++ exception handling.
11103         * compile/compile-object-run.c: Use C++ exception handling.
11104         * compile/compile-object-load.c: Use C++ exception handling.
11105         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11106         * compile/compile-c-symbols.c: Use C++ exception handling.
11107         * common/selftest.c: Use C++ exception handling.
11108         * common/new-op.c: Use C++ exception handling.
11109         * cli/cli-script.c: Use C++ exception handling.
11110         * cli/cli-interp.c: Use C++ exception handling.
11111         * cli/cli-cmds.c: Use C++ exception handling.
11112         * c-varobj.c: Use C++ exception handling.
11113         * btrace.c: Use C++ exception handling.
11114         * breakpoint.c: Use C++ exception handling.
11115         * break-catch-throw.c: Use C++ exception handling.
11116         * arch-utils.c: Use C++ exception handling.
11117         * amd64-tdep.c: Use C++ exception handling.
11118         * ada-valprint.c: Use C++ exception handling.
11119         * ada-typeprint.c: Use C++ exception handling.
11120         * ada-lang.c: Use C++ exception handling.
11121         * aarch64-tdep.c: Use C++ exception handling.
11122
11123 2019-04-08  Tom Tromey  <tom@tromey.com>
11124
11125         * xml-support.c (gdb_xml_parser::parse): Update.
11126         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11127         * value.c (show_convenience): Update.
11128         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11129         (test_parse_flags_qcs): Update.
11130         * thread.c (thr_try_catch_cmd): Update.
11131         * target.c (target_translate_tls_address): Update.
11132         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11133         (info_frame_command_core, frame_apply_command_count): Update.
11134         * rust-exp.y (rust_lex_exception_test): Update.
11135         * riscv-tdep.c (riscv_print_one_register_info): Update.
11136         * remote.c (remote_target::enable_btrace): Update.
11137         * record-btrace.c (record_btrace_enable_warn): Update.
11138         * python/py-utils.c (gdbpy_convert_exception): Update.
11139         * printcmd.c (do_one_display, print_variable_and_value): Update.
11140         * mi/mi-main.c (mi_print_exception): Update.
11141         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11142         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11143         * linux-nat.c (linux_nat_target::attach): Update.
11144         * linux-fork.c (class scoped_switch_fork_info): Update.
11145         * infrun.c (displaced_step_prepare): Update.
11146         * infcall.c (call_function_by_hand_dummy): Update.
11147         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11148         * gnu-v3-abi.c (print_one_vtable): Update.
11149         * frame.c (get_prev_frame_always): Update.
11150         * f-valprint.c (info_common_command_for_block): Update.
11151         * exec.c (try_open_exec_file): Update.
11152         * exceptions.c (print_exception, exception_print)
11153         (exception_fprintf, exception_print_same): Update.
11154         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11155         * dwarf-index-cache.c (index_cache::store)
11156         (index_cache::lookup_gdb_index): Update.
11157         * darwin-nat.c (maybe_cache_shell): Update.
11158         * cp-valprint.c (cp_print_value_fields): Update.
11159         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11160         (gcc_cplus_symbol_address): Update.
11161         * compile/compile-c-symbols.c (gcc_convert_symbol)
11162         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11163         * common/selftest.c: Update.
11164         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11165         a std::string.
11166         (exception_try_scope_entry, exception_try_scope_exit): Don't
11167         declare.
11168         (struct exception_try_scope): Remove.
11169         (TRY): Don't use exception_try_scope.
11170         (struct gdb_exception): Add constructor, operator=.
11171         <what>: New method.
11172         (struct gdb_exception_RETURN_MASK_ALL)
11173         (struct gdb_exception_RETURN_MASK_ERROR)
11174         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11175         (struct gdb_quit_bad_alloc): Update.
11176         * common/common-exceptions.c (exception_none): Change
11177         initializer.
11178         (struct catcher) <state, exception>: Initialize inline.
11179         <prev>: Remove member.
11180         (current_catcher): Remove.
11181         (catchers): New global.
11182         (exceptions_state_mc_init): Simplify.
11183         (catcher_pop): Remove.
11184         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11185         (try_scope_depth, exception_try_scope_entry)
11186         (exception_try_scope_exit): Remove.
11187         (throw_exception_sjlj): Update.
11188         (exception_messages, exception_messages_size): Remove.
11189         (throw_it): Simplify.
11190         (gdb_exception_sliced_copy): Remove.
11191         (throw_exception_cxx): Update.
11192         * cli/cli-script.c (script_from_file): Update.
11193         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11194         Update.
11195         * ada-valprint.c (ada_val_print): Update.
11196         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11197         (create_excep_cond_exprs): Update.
11198
11199 2019-04-08  Tom Tromey  <tom@tromey.com>
11200
11201         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11202         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11203         (TRY, CATCH, END_CATCH): Remove some definitions.
11204         * common/common-exceptions.c: Don't use GDB_XCPT.
11205         (catcher_list_size): Remove.
11206         (throw_exception, throw_it): Simplify.
11207
11208 2019-04-05  Tom Tromey  <tom@tromey.com>
11209
11210         Revert the header-sorting patch.
11211         * ft32-tdep.c: Revert.
11212         * frv-tdep.c: Revert.
11213         * frv-linux-tdep.c: Revert.
11214         * frame.c: Revert.
11215         * frame-unwind.c: Revert.
11216         * frame-base.c: Revert.
11217         * fork-child.c: Revert.
11218         * findvar.c: Revert.
11219         * findcmd.c: Revert.
11220         * filesystem.c: Revert.
11221         * filename-seen-cache.h: Revert.
11222         * filename-seen-cache.c: Revert.
11223         * fbsd-tdep.c: Revert.
11224         * fbsd-nat.h: Revert.
11225         * fbsd-nat.c: Revert.
11226         * f-valprint.c: Revert.
11227         * f-typeprint.c: Revert.
11228         * f-lang.c: Revert.
11229         * extension.h: Revert.
11230         * extension.c: Revert.
11231         * extension-priv.h: Revert.
11232         * expprint.c: Revert.
11233         * exec.h: Revert.
11234         * exec.c: Revert.
11235         * exceptions.c: Revert.
11236         * event-top.c: Revert.
11237         * event-loop.c: Revert.
11238         * eval.c: Revert.
11239         * elfread.c: Revert.
11240         * dwarf2read.h: Revert.
11241         * dwarf2read.c: Revert.
11242         * dwarf2loc.c: Revert.
11243         * dwarf2expr.h: Revert.
11244         * dwarf2expr.c: Revert.
11245         * dwarf2-frame.c: Revert.
11246         * dwarf2-frame-tailcall.c: Revert.
11247         * dwarf-index-write.h: Revert.
11248         * dwarf-index-write.c: Revert.
11249         * dwarf-index-common.c: Revert.
11250         * dwarf-index-cache.h: Revert.
11251         * dwarf-index-cache.c: Revert.
11252         * dummy-frame.c: Revert.
11253         * dtrace-probe.c: Revert.
11254         * disasm.h: Revert.
11255         * disasm.c: Revert.
11256         * disasm-selftests.c: Revert.
11257         * dictionary.c: Revert.
11258         * dicos-tdep.c: Revert.
11259         * demangle.c: Revert.
11260         * dcache.h: Revert.
11261         * dcache.c: Revert.
11262         * darwin-nat.h: Revert.
11263         * darwin-nat.c: Revert.
11264         * darwin-nat-info.c: Revert.
11265         * d-valprint.c: Revert.
11266         * d-namespace.c: Revert.
11267         * d-lang.c: Revert.
11268         * ctf.c: Revert.
11269         * csky-tdep.c: Revert.
11270         * csky-linux-tdep.c: Revert.
11271         * cris-tdep.c: Revert.
11272         * cris-linux-tdep.c: Revert.
11273         * cp-valprint.c: Revert.
11274         * cp-support.c: Revert.
11275         * cp-namespace.c: Revert.
11276         * cp-abi.c: Revert.
11277         * corelow.c: Revert.
11278         * corefile.c: Revert.
11279         * continuations.c: Revert.
11280         * completer.h: Revert.
11281         * completer.c: Revert.
11282         * complaints.c: Revert.
11283         * coffread.c: Revert.
11284         * coff-pe-read.c: Revert.
11285         * cli-out.h: Revert.
11286         * cli-out.c: Revert.
11287         * charset.c: Revert.
11288         * c-varobj.c: Revert.
11289         * c-valprint.c: Revert.
11290         * c-typeprint.c: Revert.
11291         * c-lang.c: Revert.
11292         * buildsym.c: Revert.
11293         * buildsym-legacy.c: Revert.
11294         * build-id.h: Revert.
11295         * build-id.c: Revert.
11296         * btrace.c: Revert.
11297         * bsd-uthread.c: Revert.
11298         * breakpoint.h: Revert.
11299         * breakpoint.c: Revert.
11300         * break-catch-throw.c: Revert.
11301         * break-catch-syscall.c: Revert.
11302         * break-catch-sig.c: Revert.
11303         * blockframe.c: Revert.
11304         * block.c: Revert.
11305         * bfin-tdep.c: Revert.
11306         * bfin-linux-tdep.c: Revert.
11307         * bfd-target.c: Revert.
11308         * bcache.c: Revert.
11309         * ax-general.c: Revert.
11310         * ax-gdb.h: Revert.
11311         * ax-gdb.c: Revert.
11312         * avr-tdep.c: Revert.
11313         * auxv.c: Revert.
11314         * auto-load.c: Revert.
11315         * arm-wince-tdep.c: Revert.
11316         * arm-tdep.c: Revert.
11317         * arm-symbian-tdep.c: Revert.
11318         * arm-pikeos-tdep.c: Revert.
11319         * arm-obsd-tdep.c: Revert.
11320         * arm-nbsd-tdep.c: Revert.
11321         * arm-nbsd-nat.c: Revert.
11322         * arm-linux-tdep.c: Revert.
11323         * arm-linux-nat.c: Revert.
11324         * arm-fbsd-tdep.c: Revert.
11325         * arm-fbsd-nat.c: Revert.
11326         * arm-bsd-tdep.c: Revert.
11327         * arch-utils.c: Revert.
11328         * arc-tdep.c: Revert.
11329         * arc-newlib-tdep.c: Revert.
11330         * annotate.h: Revert.
11331         * annotate.c: Revert.
11332         * amd64-windows-tdep.c: Revert.
11333         * amd64-windows-nat.c: Revert.
11334         * amd64-tdep.c: Revert.
11335         * amd64-sol2-tdep.c: Revert.
11336         * amd64-obsd-tdep.c: Revert.
11337         * amd64-obsd-nat.c: Revert.
11338         * amd64-nbsd-tdep.c: Revert.
11339         * amd64-nbsd-nat.c: Revert.
11340         * amd64-nat.c: Revert.
11341         * amd64-linux-tdep.c: Revert.
11342         * amd64-linux-nat.c: Revert.
11343         * amd64-fbsd-tdep.c: Revert.
11344         * amd64-fbsd-nat.c: Revert.
11345         * amd64-dicos-tdep.c: Revert.
11346         * amd64-darwin-tdep.c: Revert.
11347         * amd64-bsd-nat.c: Revert.
11348         * alpha-tdep.c: Revert.
11349         * alpha-obsd-tdep.c: Revert.
11350         * alpha-nbsd-tdep.c: Revert.
11351         * alpha-mdebug-tdep.c: Revert.
11352         * alpha-linux-tdep.c: Revert.
11353         * alpha-linux-nat.c: Revert.
11354         * alpha-bsd-tdep.c: Revert.
11355         * alpha-bsd-nat.c: Revert.
11356         * aix-thread.c: Revert.
11357         * agent.c: Revert.
11358         * addrmap.c: Revert.
11359         * ada-varobj.c: Revert.
11360         * ada-valprint.c: Revert.
11361         * ada-typeprint.c: Revert.
11362         * ada-tasks.c: Revert.
11363         * ada-lang.c: Revert.
11364         * aarch64-tdep.c: Revert.
11365         * aarch64-ravenscar-thread.c: Revert.
11366         * aarch64-newlib-tdep.c: Revert.
11367         * aarch64-linux-tdep.c: Revert.
11368         * aarch64-linux-nat.c: Revert.
11369         * aarch64-fbsd-tdep.c: Revert.
11370         * aarch64-fbsd-nat.c: Revert.
11371         * aarch32-linux-nat.c: Revert.
11372
11373 2019-04-05  Tom Tromey  <tom@tromey.com>
11374
11375         * ft32-tdep.c: Sort headers.
11376         * frv-tdep.c: Sort headers.
11377         * frv-linux-tdep.c: Sort headers.
11378         * frame.c: Sort headers.
11379         * frame-unwind.c: Sort headers.
11380         * frame-base.c: Sort headers.
11381         * fork-child.c: Sort headers.
11382         * findvar.c: Sort headers.
11383         * findcmd.c: Sort headers.
11384         * filesystem.c: Sort headers.
11385         * filename-seen-cache.h: Sort headers.
11386         * filename-seen-cache.c: Sort headers.
11387         * fbsd-tdep.c: Sort headers.
11388         * fbsd-nat.h: Sort headers.
11389         * fbsd-nat.c: Sort headers.
11390         * f-valprint.c: Sort headers.
11391         * f-typeprint.c: Sort headers.
11392         * f-lang.c: Sort headers.
11393         * extension.h: Sort headers.
11394         * extension.c: Sort headers.
11395         * extension-priv.h: Sort headers.
11396         * expprint.c: Sort headers.
11397         * exec.h: Sort headers.
11398         * exec.c: Sort headers.
11399         * exceptions.c: Sort headers.
11400         * event-top.c: Sort headers.
11401         * event-loop.c: Sort headers.
11402         * eval.c: Sort headers.
11403         * elfread.c: Sort headers.
11404         * dwarf2read.h: Sort headers.
11405         * dwarf2read.c: Sort headers.
11406         * dwarf2loc.c: Sort headers.
11407         * dwarf2expr.h: Sort headers.
11408         * dwarf2expr.c: Sort headers.
11409         * dwarf2-frame.c: Sort headers.
11410         * dwarf2-frame-tailcall.c: Sort headers.
11411         * dwarf-index-write.h: Sort headers.
11412         * dwarf-index-write.c: Sort headers.
11413         * dwarf-index-common.c: Sort headers.
11414         * dwarf-index-cache.h: Sort headers.
11415         * dwarf-index-cache.c: Sort headers.
11416         * dummy-frame.c: Sort headers.
11417         * dtrace-probe.c: Sort headers.
11418         * disasm.h: Sort headers.
11419         * disasm.c: Sort headers.
11420         * disasm-selftests.c: Sort headers.
11421         * dictionary.c: Sort headers.
11422         * dicos-tdep.c: Sort headers.
11423         * demangle.c: Sort headers.
11424         * dcache.h: Sort headers.
11425         * dcache.c: Sort headers.
11426         * darwin-nat.h: Sort headers.
11427         * darwin-nat.c: Sort headers.
11428         * darwin-nat-info.c: Sort headers.
11429         * d-valprint.c: Sort headers.
11430         * d-namespace.c: Sort headers.
11431         * d-lang.c: Sort headers.
11432         * ctf.c: Sort headers.
11433         * csky-tdep.c: Sort headers.
11434         * csky-linux-tdep.c: Sort headers.
11435         * cris-tdep.c: Sort headers.
11436         * cris-linux-tdep.c: Sort headers.
11437         * cp-valprint.c: Sort headers.
11438         * cp-support.c: Sort headers.
11439         * cp-namespace.c: Sort headers.
11440         * cp-abi.c: Sort headers.
11441         * corelow.c: Sort headers.
11442         * corefile.c: Sort headers.
11443         * continuations.c: Sort headers.
11444         * completer.h: Sort headers.
11445         * completer.c: Sort headers.
11446         * complaints.c: Sort headers.
11447         * coffread.c: Sort headers.
11448         * coff-pe-read.c: Sort headers.
11449         * cli-out.h: Sort headers.
11450         * cli-out.c: Sort headers.
11451         * charset.c: Sort headers.
11452         * c-varobj.c: Sort headers.
11453         * c-valprint.c: Sort headers.
11454         * c-typeprint.c: Sort headers.
11455         * c-lang.c: Sort headers.
11456         * buildsym.c: Sort headers.
11457         * buildsym-legacy.c: Sort headers.
11458         * build-id.h: Sort headers.
11459         * build-id.c: Sort headers.
11460         * btrace.c: Sort headers.
11461         * bsd-uthread.c: Sort headers.
11462         * breakpoint.h: Sort headers.
11463         * breakpoint.c: Sort headers.
11464         * break-catch-throw.c: Sort headers.
11465         * break-catch-syscall.c: Sort headers.
11466         * break-catch-sig.c: Sort headers.
11467         * blockframe.c: Sort headers.
11468         * block.c: Sort headers.
11469         * bfin-tdep.c: Sort headers.
11470         * bfin-linux-tdep.c: Sort headers.
11471         * bfd-target.c: Sort headers.
11472         * bcache.c: Sort headers.
11473         * ax-general.c: Sort headers.
11474         * ax-gdb.h: Sort headers.
11475         * ax-gdb.c: Sort headers.
11476         * avr-tdep.c: Sort headers.
11477         * auxv.c: Sort headers.
11478         * auto-load.c: Sort headers.
11479         * arm-wince-tdep.c: Sort headers.
11480         * arm-tdep.c: Sort headers.
11481         * arm-symbian-tdep.c: Sort headers.
11482         * arm-pikeos-tdep.c: Sort headers.
11483         * arm-obsd-tdep.c: Sort headers.
11484         * arm-nbsd-tdep.c: Sort headers.
11485         * arm-nbsd-nat.c: Sort headers.
11486         * arm-linux-tdep.c: Sort headers.
11487         * arm-linux-nat.c: Sort headers.
11488         * arm-fbsd-tdep.c: Sort headers.
11489         * arm-fbsd-nat.c: Sort headers.
11490         * arm-bsd-tdep.c: Sort headers.
11491         * arch-utils.c: Sort headers.
11492         * arc-tdep.c: Sort headers.
11493         * arc-newlib-tdep.c: Sort headers.
11494         * annotate.h: Sort headers.
11495         * annotate.c: Sort headers.
11496         * amd64-windows-tdep.c: Sort headers.
11497         * amd64-windows-nat.c: Sort headers.
11498         * amd64-tdep.c: Sort headers.
11499         * amd64-sol2-tdep.c: Sort headers.
11500         * amd64-obsd-tdep.c: Sort headers.
11501         * amd64-obsd-nat.c: Sort headers.
11502         * amd64-nbsd-tdep.c: Sort headers.
11503         * amd64-nbsd-nat.c: Sort headers.
11504         * amd64-nat.c: Sort headers.
11505         * amd64-linux-tdep.c: Sort headers.
11506         * amd64-linux-nat.c: Sort headers.
11507         * amd64-fbsd-tdep.c: Sort headers.
11508         * amd64-fbsd-nat.c: Sort headers.
11509         * amd64-dicos-tdep.c: Sort headers.
11510         * amd64-darwin-tdep.c: Sort headers.
11511         * amd64-bsd-nat.c: Sort headers.
11512         * alpha-tdep.c: Sort headers.
11513         * alpha-obsd-tdep.c: Sort headers.
11514         * alpha-nbsd-tdep.c: Sort headers.
11515         * alpha-mdebug-tdep.c: Sort headers.
11516         * alpha-linux-tdep.c: Sort headers.
11517         * alpha-linux-nat.c: Sort headers.
11518         * alpha-bsd-tdep.c: Sort headers.
11519         * alpha-bsd-nat.c: Sort headers.
11520         * aix-thread.c: Sort headers.
11521         * agent.c: Sort headers.
11522         * addrmap.c: Sort headers.
11523         * ada-varobj.c: Sort headers.
11524         * ada-valprint.c: Sort headers.
11525         * ada-typeprint.c: Sort headers.
11526         * ada-tasks.c: Sort headers.
11527         * ada-lang.c: Sort headers.
11528         * aarch64-tdep.c: Sort headers.
11529         * aarch64-ravenscar-thread.c: Sort headers.
11530         * aarch64-newlib-tdep.c: Sort headers.
11531         * aarch64-linux-tdep.c: Sort headers.
11532         * aarch64-linux-nat.c: Sort headers.
11533         * aarch64-fbsd-tdep.c: Sort headers.
11534         * aarch64-fbsd-nat.c: Sort headers.
11535         * aarch32-linux-nat.c: Sort headers.
11536
11537 2019-04-04  Tom Tromey  <tom@tromey.com>
11538
11539         * varobj.c (varobj_create): Update.
11540         * rust-exp.y (struct rust_parser) <update_innermost_block,
11541         lookup_symbol>: New methods.
11542         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11543         Rename.
11544         (rust_parser::rust_lookup_type)
11545         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11546         * printcmd.c (display_command, do_one_display): Update.
11547         * parser-defs.h (struct parser_state) <parser_state>: Add
11548         "tracker" parameter.
11549         (block_tracker): New member.
11550         (class innermost_block_tracker) <innermost_block_tracker>: Add
11551         "types" parameter.
11552         <reset>: Remove method.
11553         (innermost_block): Don't declare.
11554         (null_post_parser): Update.
11555         * parse.c (innermost_block): Remove global.
11556         (write_dollar_variable): Update.
11557         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11558         Remove "tracker_types" parameter.
11559         (parse_expression): Add "tracker" parameter.
11560         (parse_expression_for_completion): Update.
11561         (null_post_parser): Add "tracker" parameter.
11562         * p-exp.y: Update rules.
11563         * m2-exp.y: Update rules.
11564         * language.h (struct language_defn) <la_post_parser>: Add
11565         "tracker" parameter.
11566         * go-exp.y: Update rules.
11567         * f-exp.y: Update rules.
11568         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11569         parameter.
11570         * d-exp.y: Update rules.
11571         * c-exp.y: Update rules.
11572         * breakpoint.c (set_breakpoint_condition): Create an
11573         innermost_block_tracker.
11574         (watch_command_1): Likewise.
11575         * ada-lang.c (resolve): Add "tracker" parameter.
11576         (resolve_subexp): Likewise.
11577         * ada-exp.y (write_var_from_sym): Update.
11578
11579 2019-04-04  Tom Tromey  <tom@tromey.com>
11580
11581         * type-stack.h: New file.
11582         * type-stack.c: New file.
11583         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11584         type-stack.h.
11585         (insert_into_type_stack, insert_type, push_type, push_type_int)
11586         (insert_type_address_space, pop_type, pop_type_int)
11587         (pop_typelist, pop_type_stack, append_type_stack)
11588         (push_type_stack, get_type_stack, push_typelist)
11589         (follow_type_instance_flags, follow_types): Don't declare.
11590         * parse.c (type_stack): Remove global.
11591         (parse_exp_in_context): Update.
11592         (insert_into_type_stack, insert_type, push_type, push_type_int)
11593         (insert_type_address_space, pop_type, pop_type_int)
11594         (pop_typelist, pop_type_stack, append_type_stack)
11595         (push_type_stack, get_type_stack, push_typelist)
11596         (follow_type_instance_flags, follow_types): Remove (moved to
11597         type-stack.c).
11598         * f-exp.y (type_stack): New global.
11599         Update rules.
11600         (push_kind_type, f_parse): Update.
11601         * d-exp.y (type_stack): New global.
11602         Update rules.
11603         (d_parse): Update.
11604         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11605         Update rules.
11606         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11607         (HFILES_NO_SRCDIR): Add type-stack.h.
11608
11609 2019-04-04  Tom Tromey  <tom@tromey.com>
11610
11611         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11612         (rust_parser::convert_ast_to_expression, rust_parse)
11613         (rust_lex_test_completion, rust_lex_tests): Update.
11614         * parser-defs.h (struct expr_completion_state): New.
11615         (struct parser_state) <parser_state>: Add completion parameter.
11616         <mark_struct_expression, mark_completion_tag>: New methods.
11617         <parse_completion, m_completion_state>: New members.
11618         (prefixify_expression, null_post_parser): Update.
11619         (mark_struct_expression, mark_completion_tag): Don't declare.
11620         * parse.c (parse_completion, expout_last_struct)
11621         (expout_tag_completion_type, expout_completion_name): Remove
11622         globals.
11623         (parser_state::mark_struct_expression)
11624         (parser_state::mark_completion_tag): Now methods.
11625         (prefixify_expression): Add last_struct parameter.
11626         (prefixify_subexp): Likewise.
11627         (parse_exp_1): Update.
11628         (parse_exp_in_context): Add cstate parameter.  Update.
11629         (parse_expression_for_completion): Create an
11630         expr_completion_state.
11631         (null_post_parser): Add "completion" parameter.
11632         * p-exp.y: Update rules.
11633         (yylex): Update.
11634         * language.h (struct language_defn) <la_post_parser>: Add
11635         "completing" parameter.
11636         * go-exp.y: Update rules.
11637         (lex_one_token): Update.
11638         * expression.h (parse_completion): Don't declare.
11639         * d-exp.y: Update rules.
11640         (lex_one_token): Update rules.
11641         * c-exp.y: Update rules.
11642         (lex_one_token): Update.
11643         * ada-lang.c (resolve): Add "parse_completion" parameter.
11644         (resolve_subexp): Likewise.
11645         (ada_resolve_function): Likewise.
11646
11647 2019-04-04  Tom Tromey  <tom@tromey.com>
11648
11649         * parser-defs.h (struct parser_state) <start_arglist,
11650         end_arglist>: New methods.
11651         <arglist_len, m_funcall_chain>: New members.
11652         (arglist_len, start_arglist, end_arglist): Don't declare.
11653         * parse.c (arglist_len, funcall_chain): Remove global.
11654         (start_arglist, end_arglist): Remove functions.
11655         (parse_exp_in_context): Update.
11656         * p-exp.y: Update rules.
11657         * m2-exp.y: Update rules.
11658         * go-exp.y: Update rules.
11659         * f-exp.y: Update rules.
11660         * d-exp.y: Update rules.
11661         * c-exp.y: Update rules.
11662
11663 2019-04-04  Tom Tromey  <tom@tromey.com>
11664
11665         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11666         lex_operator, push_back>: New methods.
11667         Update all rules.
11668         (rust_parser::lex_hex, lex_escape): Rename and update.
11669         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11670         (rust_parser::lex_operator): Rename and update.
11671         (rust_parser::lex_number, rustyylex, rustyyerror)
11672         (rust_lex_test_init, rust_lex_test_sequence)
11673         (rust_lex_test_push_back, rust_lex_tests): Update.
11674         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11675         parameter.
11676         <lexptr, prev_lexptr>: New members.
11677         (lexptr, prev_lexptr): Don't declare.
11678         * parse.c (lexptr, prev_lexptr): Remove globals.
11679         (parse_exp_in_context): Update.
11680         * p-exp.y (yylex, yyerror): Update.
11681         * m2-exp.y (parse_number, yylex, yyerror): Update.
11682         * go-exp.y (lex_one_token, yyerror): Update.
11683         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11684         * d-exp.y (lex_one_token, yyerror): Update.
11685         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11686         (lex_one_token, yyerror): Update.
11687         * ada-lex.l (YY_INPUT): Update.
11688         (rewind_to_char): Update.
11689         * ada-exp.y (yyerror): Update.
11690
11691 2019-04-04  Tom Tromey  <tom@tromey.com>
11692
11693         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11694         * parser-defs.h (struct parser_state) <parser_state>: Add new
11695         parameter.
11696         <comma_terminates>: New member.
11697         (comma_terminates): Don't declare global.
11698         * parse.c (comma_terminates): Remove global.
11699         (parse_exp_in_context): Update.
11700         * p-exp.y (yylex): Update.
11701         * m2-exp.y (yylex): Update.
11702         * go-exp.y (lex_one_token): Update.
11703         * f-exp.y (yylex): Update.
11704         * d-exp.y (lex_one_token): Update.
11705         * c-exp.y (lex_one_token): Update.
11706         * ada-lex.l: Update.
11707
11708 2019-04-04  Tom Tromey  <tom@tromey.com>
11709
11710         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11711         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11712         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11713         * parser-defs.h (paren_depth): Don't declare.
11714         * parse.c (paren_depth): Remove global.
11715         (parse_exp_in_context): Update.
11716         * p-exp.y (paren_depth): New global.
11717         (pascal_parse): Initialize it.
11718         * m2-exp.y (paren_depth): New global.
11719         (m2_parse): Initialize it.
11720         * go-exp.y (paren_depth): New global.
11721         (go_parse): Initialize it.
11722         * f-exp.y (paren_depth): New global.
11723         (f_parse): Initialize it.
11724         * d-exp.y (paren_depth): New global.
11725         (d_parse): Initialize it.
11726         * c-exp.y (paren_depth): New global.
11727         (c_parse): Initialize it.
11728         * ada-lex.l (paren_depth): New global.
11729         (lexer_init): Initialize it.
11730
11731 2019-04-04  Tom Tromey  <tom@tromey.com>
11732
11733         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11734         (rust_parser::convert_ast_to_type)
11735         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11736         * parser-defs.h (struct parser_state) <parser_state>: Add
11737         parameters.  Initialize new members.
11738         <expression_context_block, expression_context_pc>: New members.
11739         * parse.c (expression_context_block, expression_context_pc):
11740         Remove globals.
11741         (parse_exp_in_context): Update.
11742         * p-exp.y: Update all rules.
11743         (yylex): Update.
11744         * m2-exp.y: Update all rules.
11745         (yylex): Update.
11746         * go-exp.y (yylex): Update.
11747         * f-exp.y (yylex): Update.
11748         * d-exp.y: Update all rules.
11749         (yylex): Update.
11750         * c-exp.y: Update all rules.
11751         (lex_one_token, classify_name, yylex, c_parse): Update.
11752         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11753
11754 2019-04-04  Tom Tromey  <tom@tromey.com>
11755
11756         * gdbarch.h, gdbarch.c: Rebuild.
11757         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11758         * stap-probe.h:
11759         (struct stap_parse_info): Replace "parser_state" with
11760         "expr_builder".
11761         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11762         (parser_state): New class.
11763         * parse.c (expr_builder): Rename.
11764         (expr_builder::release): Rename.
11765         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11766         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11767         (write_exp_elt_longcst, write_exp_elt_floatcst)
11768         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11769         (write_exp_string_vector, write_exp_bitstring)
11770         (write_exp_msymbol, mark_struct_expression)
11771         (write_dollar_variable)
11772         (insert_type_address_space, increase_expout_size): Replace
11773         "parser_state" with "expr_builder".
11774         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11775         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11776         "parser_state" with "expr_builder".
11777
11778 2019-04-04  Tom Tromey  <tom@tromey.com>
11779
11780         * rust-exp.y: Replace "parse_language" with method call.
11781         * p-exp.y:
11782         (yylex): Replace "parse_language" with method call.
11783         * m2-exp.y:
11784         (yylex): Replace "parse_language" with method call.
11785         * go-exp.y (classify_name): Replace "parse_language" with method
11786         call.
11787         * f-exp.y (yylex): Replace "parse_language" with method call.
11788         * d-exp.y (lex_one_token): Replace "parse_language" with method
11789         call.
11790         * c-exp.y:
11791         (lex_one_token, classify_name, yylex): Replace "parse_language"
11792         with method call.
11793         * ada-exp.y (find_primitive_type, type_char)
11794         (type_system_address): Replace "parse_language" with method call.
11795
11796 2019-04-04  Tom Tromey  <tom@tromey.com>
11797
11798         * rust-exp.y: Replace "parse_gdbarch" with method call.
11799         * parse.c (write_dollar_variable, insert_type_address_space):
11800         Replace "parse_gdbarch" with method call.
11801         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11802         call.
11803         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11804         call.
11805         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11806         "parse_gdbarch" with method call.
11807         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11808         with method call.
11809         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11810         "parse_gdbarch" with method call.
11811         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11812         "parse_gdbarch" with method call.
11813         * c-exp.y (parse_type, parse_number, classify_name): Replace
11814         "parse_gdbarch" with method call.
11815         * ada-lex.l: Replace "parse_gdbarch" with method call.
11816         * ada-exp.y (parse_type, find_primitive_type, type_char)
11817         (type_system_address): Replace "parse_gdbarch" with method call.
11818
11819 2019-04-04  Tom Tromey  <tom@tromey.com>
11820
11821         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11822         * stap-probe.c (stap_parse_argument): Update.
11823         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11824         initial_size parameter.
11825         * rust-exp.y (rust_lex_tests): Update.
11826         * parse.c (parser_state): Update.
11827         (parse_exp_in_context): Update.
11828         * parser-defs.h (struct parser_state) <parser_state>: Remove
11829         "initial_size" parameter.
11830
11831 2019-04-04  Tom Tromey  <tom@tromey.com>
11832
11833         * parser-defs.h (increase_expout_size): Don't declare.
11834         * parse.c (increase_expout_size): Now static.
11835
11836 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11837
11838         * gnu-nat.c (gnu_nat_target::wait): Fix
11839         target_waitstatus_to_string call.
11840
11841 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * eval.c (evaluate_subexp_standard): Handle internal functions
11844         during Fortran function call handling.
11845
11846 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11847
11848         * NEWS: Mention new internal functions.
11849         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11850         (read_base_type): Use dwarf2_init_complex_target_type.
11851         * value.c (creal_internal_fn): New function.
11852         (cimag_internal_fn): New function.
11853         (_initialize_values): Register new internal functions.
11854
11855 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11856
11857         * infrun.c (stop_all_threads): If debug_infrun, always
11858         trace the wait status after wait_one, using
11859         target_waitstatus_to_string and target_pid_to_str.
11860         (handle_inferior_event): Replace various trace of
11861         wait status kind by a single trace.
11862         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11863         wait status kind image by target_waitstatus_to_string.
11864         * target/waitstatus.c (target_waitstatus_to_string): Fix
11865         obsolete comment.
11866
11867 2019-04-01  Tom Tromey  <tromey@adacore.com>
11868
11869         PR symtab/23331:
11870         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11871
11872 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11873             Pedro Alves  <palves@redhat.com>
11874
11875         * top.c (quit_force): Call 'finalize_values'.
11876         * value.c (finalize_values): New function.
11877         * value.h (finalize_values): Declare.
11878
11879 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11880
11881         * NEWS: Announce $_gdb_major and $_gdb_minor.
11882
11883         * top.c (init_gdb_version_vars): New function.
11884         (gdb_init): Call init_gdb_version_vars.
11885
11886 2019-03-29  Tom Tromey  <tromey@adacore.com>
11887
11888         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11889         help text.  Remove dead code.
11890
11891 2019-03-29  Keith Seitz  <keiths@redhat.com>
11892
11893         From Siddhesh Poyarekar:
11894         * f-lang.h (f77_get_upperbound): Return LONGEST.
11895         (f77_get_lowerbound): Likewise.
11896         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11897         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11898         print them.
11899         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11900         plongest to format print it.
11901         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11902         (f77_get_upperbound): Likewise.
11903         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11904         LOWER_BOUND to LONGEST.
11905         (f77_create_arrayprint_offset_tbl): Likewise.
11906
11907 2019-03-29  Keith Seitz  <keiths@redhat.com>
11908
11909         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11910         %s/pulongest for TYPE_LENGTH instead of %d in format
11911         strings.
11912         * ada-typerint.c (ada_print_type): Likewise.
11913         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11914         * compile/compile-c-support.c (generate_register_struct): Likewise.
11915         * gdbtypes.c (recursive_dump_type): Likewise.
11916         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11917         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11918         instead of %d in format strings.
11919         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11920         to std::min to ULONGEST.
11921         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11922         instead of %d in format strings.
11923         * tracepoint.c (info_scope_command): Likewise.
11924         * typeprint.c (print_offset_data::update)
11925         (print_offset_data::finish): Likewise.
11926         * xtensa-tdep.c (xtensa_store_return_value)
11927         (xtensa_push_dummy_call): Likewise.
11928
11929 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11930
11931         * windows-nat.c (display_selector): Fixed format specifications
11932         for 64-bit Cygwin.
11933
11934 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11935
11936         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11937
11938 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11939
11940         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11941         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11942         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11943         (nios2_linux_init_abi): Install it.
11944
11945 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11946
11947         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11948
11949 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11950
11951         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11952
11953 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11954             Tom Tromey  <tromey@adacore.com>
11955
11956         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11957
11958 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11959
11960         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11961         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11962         method to compute the bounds of range types. Also print "[evaluated]"
11963         if the bounds' values come from a dynamic evaluation.
11964
11965 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11966
11967         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11968         whitespace when pretty printing is on.
11969
11970 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11971
11972         * ppc-linux-nat.c: Add include.
11973
11974 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11975
11976         * NEWS: Mention AArch64 Pointer Authentication.
11977
11978 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11979
11980         * arm-linux-nat.c: Add include.
11981
11982 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11983
11984         * source-cache.c (source_cache::get_source_lines): Re-read
11985         fullname after calling open_source_file.
11986
11987 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11988
11989         * NEWS: Mention TLS support for FreeBSD.
11990
11991 2019-03-25  Tom Tromey  <tromey@adacore.com>
11992
11993         * minsyms.c (BUNCH_SIZE): Update comment.
11994         (~minimal_symbol_reader): Remove old comment.
11995         (compact_minimal_symbols): Update comment.
11996         (minimal_symbol_reader::install): Remove old comment.  Update
11997         other comments.
11998
11999 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12000
12001         * s390-linux-nat.c: Add include.
12002
12003 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12004
12005         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12006         Call linux_get_hwcap.
12007         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12008         Likewise.
12009         (aarch64_linux_get_hwcap): Remove function.
12010         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12011         declaration.
12012         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12013         linux_get_hwcap.
12014         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12015         * linux-tdep.c (linux_get_hwcap): Add function.
12016         (linux_get_hwcap2): Likewise.
12017         * linux-tdep.h (linux_get_hwcap): Add declaration.
12018         (linux_get_hwcap2): Likewise.
12019         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12020         (ppc_linux_get_hwcap2): Likewise.
12021         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12022         linux_get_hwcap.
12023         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12024         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12025         (ppc_linux_nat_target::read_description): Likewise.
12026         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12027         * s390-linux-nat.c: Likewise.
12028         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12029
12030 2019-03-24  Tom Tromey  <tom@tromey.com>
12031
12032         * ada-lang.c (standard_lookup): Simplify initialization.
12033         (ada_lookup_symbol_nonlocal): Simplify return.
12034         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12035         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12036         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12037         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12038         initialization.
12039         * solib.c (solib_global_lookup): Simplify.
12040         * symtab.c (null_block_symbol): Remove.
12041         (symbol_cache_lookup): Simplify returns.
12042         (lookup_language_this): Simplify returns.
12043         (lookup_symbol_aux): Simplify return.
12044         (lookup_local_symbol): Simplify returns.
12045         (lookup_global_symbol_from_objfile): Simplify return.
12046         (lookup_symbol_in_objfile_symtabs)
12047         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12048         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12049         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12050         * cp-namespace.c (cp_lookup_bare_symbol)
12051         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12052         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12053         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12054         (cp_lookup_symbol_via_imports): Simplify initialization.
12055         (find_symbol_in_baseclass): Likewise.
12056         * symtab.h (null_block_symbol): Remove.
12057         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12058         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12059         (d_lookup_symbol_module): Likewise.
12060         (find_symbol_in_baseclass): Simplify initialization.
12061
12062 2019-03-24  Tom Tromey  <tom@tromey.com>
12063
12064         * expression.h: Don't include symtab.h.
12065         (struct block): Forward declare.
12066
12067 2019-03-24  Tom Tromey  <tom@tromey.com>
12068
12069         * c-exp.y (typebase): Remove casts.
12070         * gdbtypes.c (lookup_unsigned_typename, )
12071         (lookup_signed_typename): Remove cast.
12072         * eval.c (parse_to_comma_and_eval): Remove cast.
12073         * parse.c (write_dollar_variable): Remove cast.
12074         * block.h (struct block) <superblock>: Now const.
12075         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12076         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12077         (map_block): Make "block" const.
12078         * symfile.h (struct quick_symbol_functions)
12079         <map_matching_symbols>: Constify block argument to "callback".
12080         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12081         const.
12082         (find_pc_sect_compunit_symtab): Make "b" const.
12083         (find_symbol_at_address): Likewise.
12084         (search_symbols): Likewise.
12085         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12086         (dw2_debug_names_lookup_symbol): Likewise.
12087         (dw2_map_matching_symbols): Update.
12088         * p-valprint.c (pascal_val_print): Remove "block".
12089         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12090         (aux_add_nonlocal_symbols): Make "block" const.
12091         (resolve_subexp): Remove cast.
12092         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12093         const.
12094         (iterate_over_file_blocks): Likewise.
12095         * f-exp.y (%union) <bval>: Remove.
12096         * coffread.c (patch_opaque_types): Make "b" const.
12097         * spu-tdep.c (spu_catch_start): Make "block" const.
12098         * c-valprint.c (print_unpacked_pointer): Remove "block".
12099         * symmisc.c (dump_symtab_1): Make "b" const.
12100         (block_depth): Make "block" const.
12101         * d-exp.y (%union) <bval>: Remove.
12102         * cp-support.h (cp_lookup_rtti_type): Update.
12103         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12104         * psymtab.c (psym_lookup_symbol): Make "block" const.
12105         (maintenance_check_psymtabs): Make "b" const.
12106         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12107         (enumerate_locals, enumerate_args): Update.
12108         * python/py-symtab.c (stpy_global_block): Make "block" const.
12109         (stpy_static_block): Likewise.
12110         * inline-frame.c (block_starting_point_at): Make "new_block"
12111         const.
12112         * block.c (find_block_in_blockvector): Make return type const.
12113         (blockvector_for_pc_sect): Make "b" const.
12114         (find_block_in_blockvector): Make "b" const.
12115
12116 2019-03-23  Tom Tromey  <tom@tromey.com>
12117
12118         * varobj.c (varobj_create): Update.
12119         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12120         * printcmd.c (display_command, do_one_display): Don't reset
12121         innermost_block.
12122         * parser-defs.h (enum innermost_block_tracker_type): Move to
12123         expression.h.
12124         (innermost_block): Update comment.
12125         * parse.c (parse_exp_1): Add tracker_types parameter.
12126         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12127         tracker_types parameter.  Reset innermost_block.
12128         (parse_exp_in_context): Remove.
12129         (parse_expression_for_completion): Update.
12130         * objfiles.c (~objfile): Don't reset expression_context_block or
12131         innermost_block.
12132         * expression.h (enum innermost_block_tracker_type): Move from
12133         parser-defs.h.
12134         (parse_exp_1): Add tracker_types parameter.
12135         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12136         reset innermost_block.
12137
12138 2019-03-23  Tom Tromey  <tom@tromey.com>
12139
12140         * objfiles.h: Include bcache.h.
12141
12142 2019-03-23  Tom Tromey  <tom@tromey.com>
12143
12144         * linespec.c (get_current_search_block): Use
12145         scoped_restore_current_language.
12146         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12147
12148 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12149             Jiong Wang  <jiong.wang@arm.com>
12150
12151         * aarch64-linux-tdep.c
12152         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12153         section.
12154         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12155
12156 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12157             Jiong Wang  <jiong.wang@arm.com>
12158
12159         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12160         instructions.
12161         (aarch64_analyze_prologue_test): Add PACIASP test.
12162         (aarch64_prologue_prev_register): Unmask PC value.
12163
12164 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12165             Jiong Wang  <jiong.wang@arm.com>
12166
12167         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12168         (aarch64_dwarf2_prev_register): Unmask PC value.
12169         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12170         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12171         DW_CFA_AARCH64_negate_ra_state.
12172         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12173
12174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12175             Jiong Wang  <jiong.wang@arm.com>
12176
12177         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12178         registers.
12179         (aarch64_pseudo_register_name): Likewise.
12180         (aarch64_pseudo_register_type): Likewise.
12181         (aarch64_pseudo_register_reggroup_p): Likewise.
12182         (aarch64_gdbarch_init): Add pauth registers.
12183         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12184         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12185         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12186         (struct gdbarch_tdep): Add regnum for ra_state.
12187
12188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12189             Jiong Wang  <jiong.wang@arm.com>
12190
12191         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12192
12193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12194             Jiong Wang  <jiong.wang@arm.com>
12195
12196         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12197         function.
12198         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12199         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12200         (aarch64_gdbarch_init): Add puth registers.
12201         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12202         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12203         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12204
12205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12206             Jiong Wang  <jiong.wang@arm.com>
12207
12208         * aarch64-linux-nat.c
12209         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12210         * aarch64-linux-tdep.c
12211         (aarch64_linux_core_read_description): Likewise.
12212         (aarch64_linux_get_hwcap): New function.
12213         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12214         (aarch64_linux_get_hwcap): New declaration.
12215
12216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12217             Jiong Wang  <jiong.wang@arm.com>
12218
12219         * aarch64-linux-nat.c
12220         (aarch64_linux_nat_target::read_description): Add pauth param.
12221         * aarch64-linux-tdep.c
12222         (aarch64_linux_core_read_description): Likewise.
12223         * aarch64-tdep.c (struct target_desc): Add in pauth.
12224         (aarch64_read_description): Add pauth param.
12225         (aarch64_gdbarch_init): Likewise.
12226         * aarch64-tdep.h (aarch64_read_description): Likewise.
12227         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12228         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12229         * features/Makefile: Add new files.
12230         * features/aarch64-pauth.c: New file.
12231         * features/aarch64-pauth.xml: New file.
12232
12233 2019-03-20  Tom Tromey  <tromey@adacore.com>
12234
12235         * infrun.c (handle_inferior_event): Rename from
12236         handle_inferior_event_1.  Create a scoped_value_mark.
12237         (handle_inferior_event): Remove.
12238
12239 2019-03-19  Tom Tromey  <tromey@adacore.com>
12240
12241         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12242         * infrun.h (print_stop_event): Add "displays" parameter.
12243         * infrun.c (print_stop_event): Add "displays" parameter.
12244
12245 2019-03-19  Pedro Alves  <palves@redhat.com>
12246
12247         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12248         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12249         to -1.  Fix TABs vs spaces.
12250         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12251         * tui/tui-out.h (tui_ui_out) Add intro comments.
12252         <m_line, m_start_of_line>: In-class initialize, and add describing
12253         comment.
12254
12255 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12256
12257         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12258         variable names.
12259         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12260
12261 2019-03-18  Pedro Alves  <palves@redhat.com>
12262             Eli Zaretskii <eliz@gnu.org>
12263
12264         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12265         m_line and m_start_of_line.
12266
12267 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12268
12269         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12270         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12271         it returns a newline.  This fixes a regression in TU mode, whereby
12272         the next line is output on the same screen line as the user input.
12273
12274 2019-03-18  Tom Tromey  <tromey@adacore.com>
12275
12276         * minsyms.c (minimal_symbol_reader::install): Remove call to
12277         obstack_blank.
12278
12279 2019-03-18  Pedro Alves  <palves@redhat.com>
12280
12281         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12282         New globals.
12283         (apply_style): New, factored out from ...
12284         (apply_ansi_escape): ... this.  Handle reverse video mode.
12285         (tui_set_reverse_mode): New function.
12286         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12287         * tui/tui-winsource.c (tui_show_source_line): Use
12288         tui_set_reverse_mode instead of setting A_STANDOUT.
12289         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12290         New setter methods.
12291
12292 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12293
12294         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12295         Handle tabs.
12296
12297 2019-03-18  Tom Tromey  <tromey@adacore.com>
12298
12299         * ada-lang.c (empty_array): Add "high" parameter.
12300         (ada_evaluate_subexp): Update.
12301
12302 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12303
12304         * unittests/string_view-selftests.c: Define
12305         _initialize_string_view_selftests unconditionally.
12306
12307 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12308
12309         PR gdb/24350
12310         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12311
12312 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12313
12314         PR gdb/24351
12315         * windows-nat.c (display_selector): Fix format specifiers.
12316
12317 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12318
12319         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12320         tui_refill_source_window instead of tui_refresh_win, to update the
12321         current execution line.  This fixes redisplay of the current line
12322         when stepping through the code with "next" or "step".
12323
12324 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12325
12326         * source-cache.c (source_cache::get_source_lines): Call
12327         find_source_lines to initialize s->nlines.  This fixes vertical
12328         scrolling of TUI source window when the DOWN arrow is pressed.
12329
12330 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12331
12332         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12333         linux-thread-db.c (_initialize_thread_db): Likewise.
12334
12335 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12336
12337         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12338         wclrtoeol in tui_show_source_line".  This reverts changes made in
12339         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12340
12341 2019-03-15  Tom Tromey  <tom@tromey.com>
12342
12343         * symtab.h (struct minimal_symbol): Derive from
12344         general_symbol_info.
12345         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12346         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12347         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12348         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12349         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12350         (MSYMBOL_SEARCH_NAME): Update.
12351         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12352         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12353         * minsyms.c (minimal_symbol_reader::record_full): Update.
12354
12355 2019-03-15  Tom Tromey  <tom@tromey.com>
12356
12357         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12358
12359 2019-03-15  Tom Tromey  <tom@tromey.com>
12360
12361         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12362         unique_xmalloc_ptr.
12363         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12364         Update.
12365         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12366         (build_minimal_symbol_hash_tables)
12367         (minimal_symbol_reader::install): Update.
12368
12369 2019-03-15  Tom Tromey  <tom@tromey.com>
12370
12371         * symtab.c (create_demangled_names_hash): Update.
12372         (symbol_set_names): Update.
12373         * objfiles.h (struct objfile_per_bfd_storage)
12374         <demangled_names_hash>: Now an htab_up.
12375         * objfiles.c (objfile_per_bfd_storage): Simplify.
12376
12377 2019-03-15  Tom Tromey  <tom@tromey.com>
12378
12379         * objfiles.h (struct objfile_per_bfd_storage): Declare
12380         destructor.
12381         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12382         New.
12383         (get_objfile_bfd_data): Use new.  Don't initialize
12384         language_of_main.
12385         (free_objfile_per_bfd_storage): Remove.
12386         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12387
12388 2019-03-15  Tom Tromey  <tom@tromey.com>
12389
12390         * symfile.c (reread_symbols): Update.
12391         * objfiles.c (objfile::objfile): Update.
12392         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12393         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12394         comment.
12395         (minimal_symbol_reader::install): Update.
12396         (terminate_minimal_symbol_table): Remove.
12397         * jit.c (jit_object_close_impl): Update.
12398
12399 2019-03-15  Tom Tromey  <tom@tromey.com>
12400
12401         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12402         initializations.
12403
12404 2019-03-15  Tom Tromey  <tom@tromey.com>
12405
12406         * objfiles.h (struct objfile_per_bfd_storage)
12407         <demangled_hash_languages>: Now a bitset.
12408         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12409         (lookup_minimal_symbol): Update.
12410
12411 2019-03-15  Tom Tromey  <tom@tromey.com>
12412
12413         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12414         Don't return the symbol.
12415         * coffread.c (record_minimal_symbol): Use record_full.
12416
12417 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12418
12419         The MS-Windows port of ncurses fails to switch to a color pair if
12420         one or both of the colors are the implicit default colors.  This
12421         change records the default colors when TUI is initialized, and
12422         then specifies them explicitly when a color pair uses the default
12423         colors.  This allows color styling in TUI mode on MS-Windows.
12424
12425         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12426         ncurses_norm_attr.
12427         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12428         colors in ncurses_norm_attr.
12429         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12430         "none", replace it with the default color recorded in
12431         ncurses_norm_attr.
12432
12433 2019-03-14  Tom Tromey  <tromey@adacore.com>
12434
12435         * source-cache.h (class source_cache) <get_source_lines>: Return
12436         std::string.
12437         * source-cache.c (source_cache::extract_lines): Handle case where
12438         first_pos==npos.  Return std::string.
12439         (source_cache::get_source_lines): Update.
12440
12441 2019-03-14  Tom Tromey  <tromey@adacore.com>
12442
12443         * NEWS: Add item for "style sources" commands.
12444         * source-cache.c (source_cache::get_source_lines): Check
12445         source_styling.
12446         * cli/cli-style.c (source_styling): New global.
12447         (_initialize_cli_style): Add "style sources" commands.
12448         (show_style_sources): New function.
12449         * cli/cli-style.h (source_styling): Declare.
12450
12451 2019-03-14  Pedro Alves  <palves@redhat.com>
12452             Tom Tromey  <tromey@adacore.com>
12453
12454         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12455         * tui/tui-winsource.c (tui_refill_source_window): New function,
12456         from...
12457         (tui_horizontal_source_scroll): ... here.  Move some logic.
12458         * cli/cli-style.c (set_style_enabled): Notify new observable.
12459         * tui/tui-hooks.c (tui_redisplay_source): New function.
12460         (tui_attach_detach_observers): Attach or detach
12461         tui_redisplay_source.
12462         * observable.h (source_styling_changed): New observable.
12463         * observable.c: Define source_styling_changed observable.
12464
12465 2019-03-13  Tom Tromey  <tromey@adacore.com>
12466
12467         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12468         (i386_gnu_nat_target::store_registers): Update.
12469         * target-debug.h (target_debug_print_std_string): New macro.
12470         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12471         * windows-tdep.c (display_one_tib): Update.
12472         * tui/tui-stack.c (tui_make_status_line): Update.
12473         * top.c (print_inferior_quit_action): Update.
12474         * thread.c (thr_try_catch_cmd): Update.
12475         (add_thread_with_info): Update.
12476         (thread_target_id_str): Update.
12477         (thr_try_catch_cmd): Update.
12478         (thread_command): Update.
12479         (thread_find_command): Update.
12480         * record-btrace.c (record_btrace_target::info_record)
12481         (record_btrace_resume_thread, record_btrace_target::resume)
12482         (record_btrace_cancel_resume, record_btrace_step_thread)
12483         (record_btrace_target::wait, record_btrace_target::wait)
12484         (record_btrace_target::wait, record_btrace_target::stop): Update.
12485         * progspace.c (print_program_space): Update.
12486         * process-stratum-target.c
12487         (process_stratum_target::thread_address_space): Update.
12488         * linux-fork.c (linux_fork_mourn_inferior)
12489         (detach_checkpoint_command, info_checkpoints_command)
12490         (linux_fork_context): Update.
12491         (linux_fork_detach): Update.
12492         (class scoped_switch_fork_info): Update.
12493         (delete_checkpoint_command): Update.
12494         * infrun.c (follow_fork_inferior): Update.
12495         (follow_fork_inferior): Update.
12496         (proceed_after_vfork_done): Update.
12497         (handle_vfork_child_exec_or_exit): Update.
12498         (follow_exec): Update.
12499         (displaced_step_prepare_throw): Update.
12500         (displaced_step_restore): Update.
12501         (start_step_over): Update.
12502         (resume_1): Update.
12503         (clear_proceed_status_thread): Update.
12504         (proceed): Update.
12505         (print_target_wait_results): Update.
12506         (do_target_wait): Update.
12507         (context_switch): Update.
12508         (stop_all_threads): Update.
12509         (restart_threads): Update.
12510         (finish_step_over): Update.
12511         (handle_signal_stop): Update.
12512         (switch_back_to_stepped_thread): Update.
12513         (keep_going_pass_signal): Update.
12514         (print_exited_reason): Update.
12515         (normal_stop): Update.
12516         * inferior.c (inferior_pid_to_str): Change return type.
12517         (print_selected_inferior): Update.
12518         (add_inferior): Update.
12519         (detach_inferior): Update.
12520         * dummy-frame.c (fprint_dummy_frames): Update.
12521         * dcache.c (dcache_info_1): Update.
12522         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12523         (btrace_fetch, btrace_clear): Update.
12524         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12525         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12526         type.
12527         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12528         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12529         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12530         * gdbarch.c, gdbarch.h: Rebuild.
12531         * gdbarch.sh (core_pid_to_str): Change return type.
12532         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12533         return type.
12534         (windows_nat_target::pid_to_str): Change return type.
12535         (windows_delete_thread): Update.
12536         (windows_nat_target::attach): Update.
12537         (windows_nat_target::files_info): Update.
12538         * target-delegates.c: Rebuild.
12539         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12540         return type.
12541         (sol_thread_target::pid_to_str): Change return type.
12542         * remote.c (class remote_target) <pid_to_str>: Change return
12543         type.
12544         (remote_target::pid_to_str): Change return type.
12545         (extended_remote_target::attach, remote_target::remote_stop_ns)
12546         (remote_target::remote_notif_remove_queued_reply)
12547         (remote_target::push_stop_reply, remote_target::disable_btrace):
12548         Update.
12549         (extended_remote_target::attach): Update.
12550         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12551         type.
12552         (gdbsim_target::pid_to_str): Change return type.
12553         * ravenscar-thread.c (struct ravenscar_thread_target)
12554         <pid_to_str>: Change return type.
12555         (ravenscar_thread_target::pid_to_str): Change return type.
12556         * procfs.c (class procfs_target) <pid_to_str>: Change return
12557         type.
12558         (procfs_target::pid_to_str): Change return type.
12559         (procfs_target::attach): Update.
12560         (procfs_target::detach): Update.
12561         (procfs_target::fetch_registers): Update.
12562         (procfs_target::store_registers): Update.
12563         (procfs_target::wait): Update.
12564         (procfs_target::files_info): Update.
12565         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12566         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12567         return type.
12568         (nto_procfs_target::pid_to_str): Change return type.
12569         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12570         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12571         return type.
12572         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12573         (exit_lwp): Update.
12574         (attach_proc_task_lwp_callback, get_detach_signal)
12575         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12576         (linux_nat_target::resume, wait_lwp, stop_callback)
12577         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12578         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12579         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12580         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12581         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12582         type.
12583         (inf_ptrace_target::attach): Update.
12584         (inf_ptrace_target::files_info): Update.
12585         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12586         type.
12587         (go32_nat_target::pid_to_str): Change return type.
12588         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12589         (gnu_nat_target::wait): Update.
12590         (gnu_nat_target::wait): Update.
12591         (gnu_nat_target::resume): Update.
12592         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12593         (fbsd_nat_target::wait): Update.
12594         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12595         type.
12596         (darwin_nat_target::attach): Update.
12597         * corelow.c (class core_target) <pid_to_str>: Change return type.
12598         (core_target::pid_to_str): Change return type.
12599         * target.c (normal_pid_to_str): Change return type.
12600         (default_pid_to_str): Likewise.
12601         (target_pid_to_str): Change return type.
12602         (target_translate_tls_address): Update.
12603         (target_announce_detach): Update.
12604         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12605         return type.
12606         (bsd_uthread_target::pid_to_str): Change return type.
12607         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12608         type.
12609         (bsd_kvm_target::pid_to_str): Change return type.
12610         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12611         return type.
12612         (aix_thread_target::pid_to_str): Change return type.
12613         * target.h (struct target_ops) <pid_to_str>: Change return type.
12614         (target_pid_to_str, normal_pid_to_str): Likewise.
12615         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12616         type.
12617         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12618         type.
12619         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12620         return type.
12621         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12622         type.
12623         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12624         type.
12625         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12626         return type.
12627
12628 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12629
12630         * NEWS: Mention that the new default MI version is 3.  Mention
12631         changes to the output of commands and events that deal with
12632         multi-location breakpoints.
12633         * breakpoint.c: Include "mi/mi-out.h".
12634         (print_one_breakpoint): Change output syntax if using MI version
12635         >= 3.
12636         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12637         New.
12638         (mi_multi_location_breakpoint_output_fixed): New.
12639         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12640         (mi_cmd_fix_multi_location_breakpoint_output): New.
12641         (mi_multi_location_breakpoint_output_fixed): New.
12642         * mi/mi-cmds.c (mi_cmds): Register command
12643         -fix-multi-location-breakpoint-output.
12644         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12645         interpreter "mi".
12646
12647 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12648
12649         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12650         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12651         instantiate mi_ui_out based on interpreter name.
12652         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12653         * mi/mi-main.c (mi_load_progress): Likewise.
12654
12655 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12656
12657         * NEWS: Combine separate "New targets" sections for 8.3.
12658
12659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12660
12661         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12662         (ppcfbsd_init_abi): Install gdbarch
12663         "fetch_tls_load_module_address" and "get_thread_local_address"
12664         methods.
12665
12666 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12667
12668         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12669         (riscv_fbsd_init_abi): Install gdbarch
12670         "fetch_tls_load_module_address" and "get_thread_local_address"
12671         methods.
12672
12673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12674
12675         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12676         (i386fbsd_init_abi): Install gdbarch
12677         "fetch_tls_load_module_address" and "get_thread_local_address"
12678         methods.
12679
12680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12681
12682         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12683         (amd64fbsd_init_abi): Install gdbarch
12684         "fetch_tls_load_module_address" and "get_thread_local_address"
12685         methods.
12686
12687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12688
12689         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12690         (struct fbsd_pspace_data): New type.
12691         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12692         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12693         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12694         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12695         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12696
12697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12698
12699         * gdbtypes.c (lookup_struct_elt): New function.
12700         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12701         * gdbtypes.h (struct struct_elt): New type.
12702         (lookup_struct_elt): New prototype.
12703
12704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12705
12706         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12707         remove disabled code block.
12708
12709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12710
12711         * gdbarch.sh (get_thread_local_address): New method.
12712         * gdbarch.h, gdbarch.c: Regenerate.
12713         * target.c (target_translate_tls_address): Use
12714         gdbarch_get_thread_local_address if present instead of
12715         target::get_thread_local_address.
12716
12717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12718
12719         * target.h (target::get_thread_local_address): Update comment.
12720
12721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12722
12723         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12724         objfile->separate_debug_objfile_backlink if not NULL.
12725
12726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12727
12728         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12729         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12730         (amd64bsd_store_inferior_registers): Likewise.
12731         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12732         Enable segment base registers.
12733         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12734         PT_GETFSBASE and PT_GETGSBASE.
12735         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12736         PT_SETGSBASE.
12737         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12738         segment base registers.
12739         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12740
12741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12742
12743         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12744         Update calls to i386_target_description to add 'segments'
12745         parameter.
12746         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12747         add segment base registers.
12748         * arch/i386.c (i386_create_target_description): Add 'segments'
12749         parameter to enable segment base registers.
12750         * arch/i386.h (i386_create_target_description): Likewise.
12751         * features/i386/32bit-segments.xml: New file.
12752         * features/i386/32bit-segments.c: Generate.
12753         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12754         call to i386_target_description to add 'segments' parameter.
12755         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12756         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12757         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12758         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12759         if feature is present.
12760         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12761         Add 'segments' parameter to call to i386_target_description.
12762         (i386_target_description): Add 'segments' parameter to enable
12763         segment base registers.
12764         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12765         to call to i386_target_description.
12766         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12767         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12768         Define I386_NUM_REGS.
12769         (i386_target_description): Add 'segments' parameter to enable
12770         segment base registers.
12771
12772 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12773
12774         PR/24325
12775         * source-cache.c: #undef open and close, to avoid unresolved
12776         externals during linking.
12777
12778 2019-03-12  Tom Tromey  <tromey@adacore.com>
12779
12780         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12781         const.  Add initializers.
12782         (_initialize_remote): Don't initialize ptid globals.
12783
12784 2019-03-12  Pedro Alves  <palves@redhat.com>
12785
12786         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12787
12788 2019-03-12  Pedro Alves  <palves@redhat.com>
12789
12790         * cp-name-parser.y (main): Remove unused 'len' variable.
12791
12792 2019-03-12  Tom Tromey  <tromey@adacore.com>
12793
12794         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12795         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12796
12797 2019-03-12  Tom Tromey  <tromey@adacore.com>
12798
12799         * linux-nat.c (iterate_over_lwps): Update.
12800         (stop_callback): Remove parameter.
12801         (stop_wait_callback, detach_callback, resume_set_callback)
12802         (select_singlestep_lwp_callback, set_ignore_sigint)
12803         (status_callback, resumed_callback, resume_clear_callback)
12804         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12805         data parameter.
12806         (linux_nat_target::detach, linux_nat_target::resume)
12807         (linux_stop_and_wait_all_lwps, select_event_lwp)
12808         (linux_nat_filter_event, linux_nat_wait_1)
12809         (linux_nat_target::kill, linux_nat_target::stop)
12810         (linux_nat_target::stop): Update.
12811         (linux_nat_resume_callback): Change type.
12812         (resume_stopped_resumed_lwps, count_events_callback)
12813         (select_event_lwp_callback): Likewise.
12814         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12815         * arm-linux-nat.c (struct update_registers_data): Remove.
12816         (update_registers_callback): Change type.
12817         (arm_linux_insert_hw_breakpoint1): Update.
12818         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12819         parameter.
12820         (x86_linux_dr_set_addr): Update.
12821         (x86_linux_dr_set_control): Update.
12822         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12823         (iterate_over_lwps): Use gdb::function_view.
12824         * nat/aarch64-linux-hw-point.c (struct
12825         aarch64_dr_update_callback_param): Remove.
12826         (debug_reg_change_callback): Change type.
12827         (aarch64_notify_debug_reg_change): Update.
12828         * s390-linux-nat.c (s390_refresh_per_info): Update.
12829
12830 2019-03-11  Tom Tromey  <tromey@adacore.com>
12831
12832         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12833         redundant assignment to "this_cu".
12834
12835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12836
12837         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12838
12839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12840
12841         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12842         from...
12843         (rank_one_type): ... this.
12844
12845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12846
12847         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12848         from...
12849         (rank_one_type): ... this.
12850
12851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12852
12853         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12854         from...
12855         (rank_one_type): ... this.
12856
12857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12858
12859         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12860         from...
12861         (rank_one_type): ... this.
12862
12863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12864
12865         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12866         from...
12867         (rank_one_type): ... this.
12868
12869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12870
12871         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12872         from...
12873         (rank_one_type): ... this.
12874
12875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12876
12877         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12878         from...
12879         (rank_one_type): ... this.
12880
12881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12882
12883         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12884         from...
12885         (rank_one_type): ... this.
12886
12887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12888
12889         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12890         from...
12891         (rank_one_type): ... this.
12892
12893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12894
12895         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12896         from...
12897         (rank_one_type): ... this.
12898
12899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12900
12901         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12902         from...
12903         (rank_one_type): ... this.
12904
12905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12906
12907         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12908         from...
12909         (rank_one_type): ... this.
12910
12911 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12912
12913         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12914         inferior-events' shows the example events.
12915
12916 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12917
12918         Support styling on native MS-Windows console
12919
12920         PR/24315
12921         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12922         on MS-Windows if $TERM is not defined.
12923
12924         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12925
12926         * posix-hdep.c (gdb_console_fputs):
12927         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12928         functions.
12929         * ui-file.h (gdb_console_fputs): Add prototype.
12930
12931         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12932         back to fputs only if the former returns zero.
12933
12934 2019-03-07  Tom Tromey  <tom@tromey.com>
12935
12936         * symmisc.c (print_symbol_bcache_statistics): Update.
12937         (print_objfile_statistics): Update.
12938         * symfile.c (allocate_symtab): Update.
12939         * stabsread.c: Don't include bcache.h.
12940         * psymtab.h (struct psymbol_bcache): Don't declare.
12941         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12942         (psymbol_bcache_init, psymbol_bcache_free)
12943         (psymbol_bcache_get_bcache): Don't declare.
12944         * psymtab.c (struct psymbol_bcache): Remove.
12945         (psymtab_storage::psymtab_storage): Update.
12946         (psymtab_storage::~psymtab_storage): Update.
12947         (psymbol_bcache_init, psymbol_bcache_free)
12948         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12949         (add_psymbol_to_bcache): Update.
12950         (allocate_psymtab): Update.
12951         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12952         macro_cache>: No longer pointers.
12953         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12954         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12955         * macrotab.c (macro_bcache): Update.
12956         * macroexp.c: Don't include bcache.h.
12957         * gdbtypes.c (check_types_worklist): Update.
12958         (types_deeply_equal): Remove TRY/CATCH.  Update.
12959         * elfread.c (elf_symtab_read): Update.
12960         * dwarf2read.c: Don't include bcache.h.
12961         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12962         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12963         (print_bcache_statistics, bcache_memory_used): Don't declare.
12964         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12965         methods.  Rename all data members.
12966         * bcache.c (struct bcache): Move to bcache.h.
12967         (bcache::expand_hash_table): Rename from expand_hash_table.
12968         (bcache): Remove.
12969         (bcache::insert): Rename from bcache_full.
12970         (bcache::compare): Rename from bcache_compare.
12971         (bcache_xmalloc): Remove.
12972         (bcache::~bcache): Rename from bcache_xfree.
12973         (bcache::print_statistics): Rename from print_bcache_statistics.
12974         (bcache::memory_used): Rename from bcache_memory_used.
12975
12976 2019-03-07  Pedro Alves  <palves@redhat.com>
12977
12978         * infrun.c (normal_stop): Also check for
12979         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12980
12981 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12982
12983         * f-lang.c (value_from_host_double): Moved to...
12984         * value.c (value_from_host_double): ...here.
12985         * value.h (value_from_host_double): Declare.
12986         * guile/scm-math.c (vlscm_convert_typed_number): Use
12987         value_from_host_double.
12988         (vlscm_convert_number): Likewise.
12989         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12990         * python/py-value.c (convert_value_from_python): Likewise.
12991
12992 2019-03-06  Tom Tromey  <tom@tromey.com>
12993
12994         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12995
12996 2019-03-06  Tom Tromey  <tom@tromey.com>
12997
12998         * utils.h (free_current_contents): Don't declare.
12999         * utils.c (free_current_contents): Remove.
13000
13001 2019-03-06  Tom Tromey  <tom@tromey.com>
13002
13003         * top.c (quit_force): Update.
13004         * main.c (captured_command_loop): Update.
13005         * common/new-op.c (operator new): Update.
13006         * common/common-exceptions.c (struct catcher)
13007         <save_cleanup_chain>: Remove member.
13008         (exceptions_state_mc_init): Update.
13009         (exception_try_scope_entry): Return nullptr.
13010         (exception_try_scope_exit, exception_rethrow)
13011         (throw_exception_sjlj, throw_exception_cxx): Update.
13012         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13013         (all_cleanups, do_cleanups, discard_cleanups)
13014         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13015         (restore_cleanups, restore_final_cleanups): Don't declare.
13016         (do_final_cleanups): Remove parameter.
13017         * common/cleanups.c (cleanup_chain, make_cleanup)
13018         (make_cleanup_dtor, all_cleanups, do_cleanups)
13019         (discard_my_cleanups, discard_cleanups)
13020         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13021         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13022         (null_cleanup): Remove.
13023         (do_final_cleanups): Remove parameter.
13024
13025 2019-03-06  Tom Tromey  <tom@tromey.com>
13026
13027         * remote.c (remote_target::remote_parse_stop_reply): Use
13028         unique_xmalloc_ptr.
13029
13030 2019-03-06  Tom Tromey  <tom@tromey.com>
13031
13032         * stabsread.c (struct stabs_field_info): Rename from field_info.
13033         <list, fnlist>: Add initializers.
13034         <obstack>: New member.
13035         (read_member_functions, read_struct_fields, read_baseclasses):
13036         Allocate on obstack.  Don't use cleanups.
13037         (read_one_struct_field, read_member_functions, read_struct_fields)
13038         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13039         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13040         (read_struct_type): Update.
13041
13042 2019-03-06  Tom Tromey  <tom@tromey.com>
13043
13044         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13045         * common/filestuff.h (make_cleanup_close): Don't declare.
13046         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13047         Remove.
13048
13049 2019-03-06  Tom Tromey  <tom@tromey.com>
13050
13051         * solib-aix.c: Use make_scope_exit.
13052
13053 2019-03-06  Tom Tromey  <tom@tromey.com>
13054
13055         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13056         Use make_scope_exit.
13057
13058 2019-03-06  Tom Tromey  <tom@tromey.com>
13059
13060         * solib-svr4.c (disable_probes_interface): Remove parameter.
13061         (svr4_handle_solib_event): Use make_scope_exit.
13062
13063 2019-03-06  Tom Tromey  <tom@tromey.com>
13064
13065         * remote.c (struct stop_reply_deleter): Remove.
13066         (stop_reply_up): Update.
13067         (struct stop_reply): Derive from notif_event.  Don't typedef.
13068         <regcache>: Now a std::vector.
13069         (stop_reply_xfree): Remove.
13070         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13071         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13072         (remote_target::discard_pending_stop_replies): Use delete.
13073         (remote_target::remote_parse_stop_reply): Update.
13074         (remote_target::process_stop_reply): Update.
13075         * remote-notif.h (struct notif_event): Add virtual destructor.
13076         Remove "dtr" member.
13077         (struct notif_client) <alloc_event>: Return a unique_ptr.
13078         (notif_event_xfree): Don't declare.
13079         (notif_event_up): New typedef.
13080         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13081         (notif_event_xfree, do_notif_event_xfree): Remove.
13082         (remote_notif_state_xfree): Update.
13083
13084 2019-03-06  Tom Tromey  <tom@tromey.com>
13085
13086         * infrun.c (displaced_step_clear_cleanup): Now a
13087         forward_scope_exit type.
13088         (displaced_step_prepare_throw): Update.
13089         (displaced_step_fixup): Update.
13090
13091 2019-03-06  Tom Tromey  <tom@tromey.com>
13092
13093         * inferior.h (class inferior): Update comment.
13094         * gdbthread.h (class thread_info): Update comment.
13095
13096 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13097             Tom Tromey  <tom@tromey.com>
13098
13099         * stabsread.h (struct stab_section_list): Remove.
13100         (coffstab_build_psymtabs): Update.
13101         * dbxread.c (symbuf_sections): Now a std::vector.
13102         (sect_idx): New global.
13103         (fill_symbuf): Update.
13104         (coffstab_build_psymtabs): Change type of stabsects parameter.
13105         Update.
13106         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13107         std::vector.
13108         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13109         (coff_locate_sections): Update.
13110         (coff_symfile_read): Remove cleanups.  Update.
13111         (init_stringtab): Add storage parameter.
13112         (free_stringtab, free_stringtab_cleanup): Remove.
13113         (init_lineno): Add storage parameter.
13114         (free_linetab, free_linetab_cleanup): Remove.
13115
13116 2019-03-06  Pedro Alves  <palves@redhat.com>
13117
13118         * linux-fork.c (fork_info::clobber_regs): Delete.
13119         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13120         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13121         comment.  Adjust.
13122         (scoped_switch_fork_info::scoped_switch_fork_info)
13123         (checkpoint_command, linux_fork_context): Adjust
13124         fork_save_infrun_state calls.
13125
13126 2019-03-06  Pedro Alves  <palves@redhat.com>
13127
13128         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13129         (inf_has_multiple_threads): Return 'bool' and rewrite using
13130         inferior_info::threads().
13131
13132 2019-03-06  Pedro Alves  <palves@redhat.com>
13133
13134         * linux-fork.c: Include <list>.
13135         (fork_list): Now a std::list instance.
13136         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13137         (forks_exist_p, find_last_fork): Adjust.
13138         (new_fork): Delete.
13139         (one_fork_p): New.
13140         (add_fork): Adjust.
13141         (free_fork): Delete, folded into fork_info::~fork_info().
13142         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13143         Adjust.
13144         (init_fork_list): Delete.
13145         (linux_fork_killall, linux_fork_mourn_inferior)
13146         (linux_fork_detach, info_checkpoints_command): Adjust.
13147         (_initialize_linux_fork): No longer call init_fork_list.
13148
13149 2019-03-06  Pedro Alves  <palves@redhat.com>
13150
13151         * linux-fork.c (new_fork): New, split out of ...
13152         (add_fork): ... this.  Return void.  Move "first fork" special
13153         case from here, to ...
13154         (checkpoint_command): ... here.
13155         * linux-linux.h (add_fork): Return void.
13156
13157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13158
13159         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13160
13161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13162             Chris January  <chris.january@arm.com>
13163             David Lecomber  <david.lecomber@arm.com>
13164
13165         * f-exp.y: New token, UNOP_INTRINSIC.
13166         (exp): New pattern using UNOP_INTRINSIC token.
13167         (f77_keywords): Add 'abs' keyword.
13168         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13169         (value_from_host_double): New function.
13170         (evaluate_subexp_f): Support UNOP_ABS.
13171
13172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13173
13174         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13175         types.
13176
13177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13178
13179         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13180         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13181         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13182
13183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13184
13185         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13186
13187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13188             Chris January  <chris.january@arm.com>
13189
13190         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13191         * f-exp.y: Define 'KIND' token.
13192         (exp): New pattern for KIND expressions.
13193         (ptype): Handle types with a kind extension.
13194         (direct_abs_decl): Extend to spot kind extensions.
13195         (f77_keywords): Add 'kind' to the list.
13196         (push_kind_type): New function.
13197         (convert_to_kind_type): New function.
13198         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13199         * parse.c (operator_length_standard): Likewise.
13200         * parser-defs.h (enum type_pieces): Add tp_kind.
13201         * std-operator.def: Add UNOP_KIND.
13202
13203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13204
13205         * f-exp.y (f_parse): Set yydebug.
13206
13207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13208
13209         * f-lang.c (evaluate_subexp_f): New function.
13210         (exp_descriptor_f): New global.
13211         (f_language_defn): Use exp_descriptor_f instead of
13212         exp_descriptor_standard.
13213
13214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13215
13216         * f-exp.y (struct token): Add comments.
13217         (dot_ops): Remove uppercase versions and the end marker.
13218         (f77_keywords): Likewise.
13219         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13220         entries in the dot_ops array are case insensitive, and use
13221         strncasecmp to compare strings.  Also some whitespace cleanup in
13222         this area.  Similar for the f77_keywords array, except entries in
13223         this list might be case sensitive.
13224
13225 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13226
13227         * f-exp.y (struct f77_boolean_val): Add comments.
13228         (boolean_values): Remove uppercase versions, and end marker.
13229         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13230         and use strncasecmp to achieve case insensitivity.  Additionally,
13231         perform whitespace cleanup around this code.
13232
13233 2019-03-06  Tom Tromey  <tromey@adacore.com>
13234
13235         * remote-sim.c (gdbsim_target_open): Use result of
13236         gdb_argv::release.
13237
13238 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13239         Dirk Schubert  <dirk.schubert@arm.com>
13240         Chris January  <chris.january@arm.com>
13241
13242         * eval.c (evaluate_subexp_standard): Call Fortran argument
13243         wrapping logic.
13244         * f-lang.c (struct value): A value which can be passed into a
13245         Fortran function call.
13246         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13247         where appropriate.
13248         (struct type): Value ready for a Fortran function call.
13249         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13250         is needed.
13251         * f-lang.h (fortran_argument_convert): Declaration.
13252         (fortran_preserve_arg_pointer): Declaration.
13253         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13254
13255 2019-03-05  Tom Tromey  <tromey@adacore.com>
13256
13257         * python/py-prettyprint.c (print_string_repr): Remove #if.
13258         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13259
13260 2019-03-05  Tom Tromey  <tromey@adacore.com>
13261
13262         * target.c (the_dummy_target): Move later.  Change type to
13263         "dummy_target".
13264         (initialize_targets): Don't initialize the_dummy_target.
13265
13266 2019-03-05  Tom Tromey  <tromey@adacore.com>
13267
13268         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13269         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13270
13271 2019-03-05  Tom Tromey  <tromey@adacore.com>
13272
13273         * windows-nat.c (windows_nat_target::attach)
13274         (windows_nat_target::detach): Don't call gdb_flush.
13275         * valprint.c (generic_val_print, val_print, val_print_string):
13276         Don't call gdb_flush.
13277         * utils.c (defaulted_query): Don't call gdb_flush.
13278         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13279         * target.c (target_announce_detach): Don't call gdb_flush.
13280         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13281         * remote.c (extended_remote_target::attach): Don't call
13282         gdb_flush.
13283         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13284         * printcmd.c (do_examine): Don't call gdb_flush.
13285         (info_display_command): Don't call gdb_flush.
13286         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13287         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13288         * memattr.c (info_mem_command): Don't call gdb_flush.
13289         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13290         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13291         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13292         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13293         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13294         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13295         (gnu_nat_target::detach): Don't call gdb_flush.
13296         * f-valprint.c (f_val_print): Don't call gdb_flush.
13297         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13298         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13299         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13300         gdb_flush.
13301         * c-valprint.c (c_val_print): Don't call gdb_flush.
13302         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13303
13304 2019-03-05  Tom Tromey  <tromey@adacore.com>
13305
13306         * varobj.c (update_dynamic_varobj_children): Update.
13307         (install_default_visualizer): Use reset, not release.
13308         * value.c (set_internalvar): Update.
13309         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13310         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13311         ATTRIBUTE_UNUSED_RESULT.
13312
13313 2019-03-05  Tom Tromey  <tromey@adacore.com>
13314
13315         * remote.c (class scoped_remote_fd) <release>: Add
13316         ATTRIBUTE_UNUSED_RESULT.
13317
13318 2019-03-05  Tom Tromey  <tromey@adacore.com>
13319
13320         * macroexp.c (struct macro_buffer) <release>: Add
13321         ATTRIBUTE_UNUSED_RESULT.
13322
13323 2019-03-05  Tom Tromey  <tromey@adacore.com>
13324
13325         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13326         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13327         ATTRIBUTE_UNUSED_RESULT.
13328
13329 2019-03-05  Tom Tromey  <tromey@adacore.com>
13330
13331         * common/scoped_fd.h (class scoped_fd) <release>: Add
13332         ATTRIBUTE_UNUSED_RESULT.
13333
13334 2019-03-05  Tom Tromey  <tromey@adacore.com>
13335
13336         * parser-defs.h (struct parser_state) <release>: Add
13337         ATTRIBUTE_UNUSED_RESULT.
13338
13339 2019-03-05  Tom Tromey  <tromey@adacore.com>
13340
13341         * utils.h (class gdb_argv) <release>: Add
13342         ATTRIBUTE_UNUSED_RESULT.
13343         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13344
13345 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13346
13347         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13348         for-loop range, to avoid compiler warnings.
13349
13350         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13351         avoid compiler warnings about unused variables.
13352
13353         * NEWS: Mention end of support for native debugging on MS-Windows
13354         before XP.
13355
13356         PR gdb/24292
13357         * common/netstuff.c:
13358         * gdbserver/gdbreplay.c
13359         * gdbserver/remote-utils.c:
13360         * ser-tcp.c:
13361         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13362         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13363         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13364         'getaddrinfo' and 'freeaddrinfo' were not available before
13365         Windows XP, and mingw.org's MinGW headers by default define
13366         _WIN32_WINNT to 0x500.
13367
13368 2019-03-01  Gary Benson <gbenson@redhat.com>
13369
13370         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13371
13372 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13373             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13374
13375         PR gdb/8527
13376         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13377         set_sigint_trap, clear_sigint_trap.
13378
13379 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13380
13381         * target.c (target_detach): Clear the regcache and the
13382         frame cache.
13383
13384 2019-02-27  Pedro Alves  <palves@redhat.com>
13385
13386         * utils.c (set_screen_size): When we cap the height/width sizes,
13387         tweak the corresponding command variable to show "unlimited":
13388
13389 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13390             Pedro Alves  <palves@redhat.com>
13391
13392         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13393         before calling rl_set_screen_size.
13394
13395 2019-02-27  Tom Tromey  <tromey@adacore.com>
13396
13397         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13398         define.
13399         * python/py-value.c: Remove Python 2.4 workaround.
13400         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13401         workaround.
13402         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13403         Python 2.4 workaround.
13404         * python/python-internal.h: Remove Python 2.4 comment.
13405         (Py_ssize_t): Don't define.
13406         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13407         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13408         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13409         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13410         * python/python.c (do_start_initialization): Remove Python 2.4
13411         workaround.
13412         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13413         (print_children): Remove Python 2.4 workaround.
13414         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13415         workaround.
13416         (CHARBUFFERPROC_NAME): Remove.
13417         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13418         Python 2.4 workaround.
13419
13420 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13421
13422         * NEWS: Note minimum Python version.
13423
13424 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13425
13426         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13427         code from these functions.  Remove corresponding ifdefs.  Use
13428         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13429         Remove gotos and target of gotos.
13430         (infpy_search_memory): Likewise.
13431
13432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13433
13434         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13435         (hppa_gdbarch_init): Don't register deleted functions with
13436         gdbarch.
13437
13438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13439
13440         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13441         (h8300_unwind_sp): Delete.
13442         (h8300_dummy_id): Delete.
13443         (h8300_gdbarch_init): Don't register deleted functions with
13444         gdbarch.
13445
13446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13447
13448         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13449         (ft32_unwind_pc): Delete.
13450         (ft32_unwind_sp): Delete.
13451         (ft32_gdbarch_init): Don't register deleted functions with
13452         gdbarch.
13453
13454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13455
13456         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13457         (frv_unwind_pc): Delete.
13458         (frv_unwind_sp): Delete.
13459         (frv_gdbarch_init): Don't register deleted functions with
13460         gdbarch.
13461
13462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13463
13464         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13465         (riscv_unwind_pc): Delete.
13466         (riscv_unwind_sp): Delete.
13467         (riscv_gdbarch_init): Don't register deleted functions with
13468         gdbarch.
13469
13470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13471
13472         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13473         (csky_unwind_pc): Delete.
13474         (csky_unwind_sp): Delete.
13475         (csky_gdbarch_init): Don't register deleted functions with
13476         gdbarch.
13477
13478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13479
13480         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13481         (cris_unwind_pc): Delete.
13482         (cris_unwind_sp): Delete.
13483         (cris_gdbarch_init): Don't register deleted functions with
13484         gdbarch.
13485
13486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13487
13488         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13489         (bfin_unwind_pc): Delete.
13490         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13491
13492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13493
13494         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13495         (arm_unwind_pc): Delete.
13496         (arm_unwind_sp): Delete.
13497         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13498
13499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13500
13501         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13502         (arc_unwind_pc): Delete.
13503         (arc_unwind_sp): Delete.
13504         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13505
13506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13507
13508         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13509         (alpha_unwind_pc): Delete.
13510         (alpha_gdbarch_init): Don't register deleted functions with
13511         gdbarch.
13512
13513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13514
13515         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13516         (aarch64_unwind_pc): Delete.
13517         (aarch64_unwind_sp): Delete.
13518         (aarch64_gdbarch_init): Don't register deleted functions with
13519         gdbarch.
13520
13521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13522
13523         * gdbtypes.c (type_align): Don't consider static members when
13524         computing structure alignment.
13525
13526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13527
13528         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13529         return 0 for other types.
13530         * arch-utils.c (default_type_align): Always return 0.
13531         * gdbarch.h: Regenerate.
13532         * gdbarch.sh (type_align): Extend comment.
13533         * gdbtypes.c (type_align): Add additional comments, always call
13534         gdbarch_type_align before applying the default rules.
13535         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13536         generic code will then apply a suitable default.
13537         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13538         types, return 0 for other types.
13539
13540 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13541
13542         * NEWS: Create a new section for the next release branch.
13543         Rename the section of the current branch, now that it has
13544         been cut.
13545
13546 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13547
13548         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13549         * version.in: Bump version to 8.3.50.DATE-git.
13550
13551 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13552
13553         * aix-thread.c (ptid_cmp): Remove unused variable.
13554         (get_signaled_thread): Likewise.
13555         (store_regs_user_thread): Likewise.
13556         (store_regs_kernel_thread): Likewise.
13557         (fetch_regs_kernel_thread): Remove shadowed variable.
13558
13559 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13560
13561         * features/riscv/32bit-cpu.xml: Add register numbers.
13562         * features/riscv/32bit-fpu.c: Regenerate.
13563         * features/riscv/32bit-fpu.xml: Add register numbers.
13564         * features/riscv/64bit-cpu.xml: Add register numbers.
13565         * features/riscv/64bit-fpu.c: Regenerate.
13566         * features/riscv/64bit-fpu.xml: Add register numbers.
13567
13568 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13569
13570         * NEWS: Mention two argument form of gdb.Value constructor.
13571         * python/py-value.c (convert_buffer_and_type_to_value): New
13572         function.
13573         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13574         Add support for handling an optional second argument.  Call
13575         convert_buffer_and_type_to_value as appropriate.
13576         * python/python-internal.h (Py_buffer_deleter): New struct.
13577         (Py_buffer_up): New typedef.
13578
13579 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13580
13581         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13582         instead of releasing ownership.
13583
13584 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13585
13586         * dwarf2read.c (open_and_init_dwp_file): Call
13587         elf_numsections instead of bfd_count_sections to initialize
13588         dwp_file->num_sections.
13589
13590 2019-02-25  Tom Tromey  <tromey@adacore.com>
13591
13592         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13593
13594 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13595
13596         * gcore.in: Add '--readnever' option when invoking GDB.
13597
13598 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13599
13600         * MAINTAINERS: Update my email address.
13601
13602 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13603
13604         * build-id.c (build_id_to_debug_bfd_1): New function.
13605         (build_id_to_debug_bfd): Look for separate debug file in
13606         sysroot.
13607
13608 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13609
13610         * gdbarch.sh: Update the copyright year range that is placed into
13611         generated files.
13612
13613 2019-02-22  Keith Seitz  <keiths@redhat.com>
13614
13615         PR symtab/23853
13616         * linespec.c (create_sals_line_offset): Search for the default
13617         symtab's filename instead of its fullname.
13618
13619 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13620
13621         * NEWS: Update style defaults.
13622
13623 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13624
13625         * main.c (captured_main_1): Disable styling in batch mode.
13626
13627 2019-02-20  Tom Tromey  <tom@tromey.com>
13628
13629         * symtab.c (symtab_symbol_info): Fix typos.
13630
13631 2019-02-20  Tom Tromey  <tromey@adacore.com>
13632
13633         * findcmd.c (_initialize_mem_search): Use upper case for
13634         metasyntactic variables.
13635
13636 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13637
13638         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13639         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13640
13641 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13642
13643         * top.h (source_file_name): Change to std::string.
13644         * top.c (source_file_name): Likewise.
13645         (command_line_input): Adjust.
13646         * cli/cli-script.c (script_from_file): Adjust.
13647
13648 2019-02-19  Tom Tromey  <tromey@adacore.com>
13649
13650         * ravenscar-thread.c
13651         (ravenscar_thread_target::update_thread_list): Don't call
13652         ada_build_task_list.
13653         * ada-lang.h (ada_build_task_list): Don't declare.
13654         * ada-tasks.c (struct ada_tasks_inferior_data)
13655         <task_list_valid_p>: Now bool.
13656         (read_known_tasks, ada_task_list_changed)
13657         (ada_tasks_invalidate_inferior_data): Update.
13658         (read_known_tasks_array): Return bool.
13659         (read_known_tasks_list): Likewise.
13660         (read_known_tasks): Return void.
13661         (ada_build_task_list): Now static.
13662
13663 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13664
13665         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13666         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13667
13668 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13669
13670         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13671         variant for ada_tasks_pspace_data_handle and
13672         ada_tasks_inferior_data_handle.
13673         (ada_tasks_pspace_data_cleanup): New function.
13674         (ada_tasks_inferior_data_cleanup): New function.
13675
13676 2019-02-17  Tom Tromey  <tom@tromey.com>
13677
13678         * macrotab.h (macro_source_fullname): Return a std::string.
13679         * macrotab.c (macro_include, check_for_redefinition)
13680         (macro_undef, macro_lookup_definition, foreach_macro)
13681         (foreach_macro_in_scope): Update.
13682         (macro_source_fullname): Return a std::string.
13683         * macrocmd.c (show_pp_source_pos): Update.
13684
13685 2019-02-17  Tom Tromey  <tom@tromey.com>
13686
13687         * macrocmd.c (show_pp_source_pos): Style the file names.
13688
13689 2019-02-17  Tom Tromey  <tom@tromey.com>
13690
13691         PR tui/24197:
13692         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13693
13694 2019-02-17  Tom Tromey  <tom@tromey.com>
13695
13696         * ada-lang.c (user_select_syms): Use filtered printing.
13697         * utils.c (wrap_style): New global.
13698         (desired_style): Remove.
13699         (emit_style_escape): Add stream parameter.
13700         (set_output_style, reset_terminal_style, prompt_for_continue):
13701         Update.
13702         (flush_wrap_buffer): Only flush gdb_stdout.
13703         (wrap_here): Set wrap_style.
13704         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13705         treat escape sequences as a character.  Change when wrap buffer is
13706         flushed.
13707         (fputs_styled): Do not set the output style when the default is
13708         requested.
13709         * ui-style.h (struct ui_file_style) <is_default>: New method.
13710         * source.c (print_source_lines_base): Emit escape sequences in one
13711         piece.
13712
13713 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13714
13715         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13716         integers and enumeration types.
13717
13718 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13719
13720         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13721         instead of lookup_symbol_in_language
13722         (do_exact_match): New function.
13723         (ada_get_symbol_name_matcher): Return do_exact_match when
13724         doing a verbatim match.
13725
13726 2019-02-15  Tom Tromey  <tromey@adacore.com>
13727
13728         * ravenscar-thread.c (ravenscar_thread_target::resume)
13729         (ravenscar_thread_target::wait): Special case wildcard requests.
13730
13731 2019-02-15  Tom Tromey  <tromey@adacore.com>
13732
13733         * ravenscar-thread.c (base_ptid): Remove.
13734         (struct ravenscar_thread_target) <close>: New method.
13735         <m_base_ptid>: New member.
13736         <update_inferior_ptid, active_task, task_is_currently_active,
13737         runtime_initialized>: Declare methods.
13738         <ravenscar_thread_target>: Add constructor.
13739         (ravenscar_thread_target::task_is_currently_active)
13740         (ravenscar_thread_target::update_inferior_ptid)
13741         (ravenscar_runtime_initialized): Rename.  Now methods.
13742         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13743         (ravenscar_thread_target::update_thread_list): Update.
13744         (ravenscar_thread_target::active_task): Now method.
13745         (ravenscar_thread_target::store_registers)
13746         (ravenscar_thread_target::prepare_to_store)
13747         (ravenscar_thread_target::prepare_to_store)
13748         (ravenscar_thread_target::mourn_inferior): Update.
13749         (ravenscar_inferior_created): Use "new" to create target.
13750         (ravenscar_thread_target::get_ada_task_ptid): Update.
13751         (_initialize_ravenscar): Don't initialize base_ptid.
13752         (ravenscar_ops): Remove global.
13753
13754 2019-02-15  Tom Tromey  <tromey@adacore.com>
13755
13756         * target.h (push_target): Declare new overload.
13757         * target.c (push_target): New overload, taking an rvalue reference.
13758         * remote.c (remote_target::open_1): Use push_target overload.
13759         * corelow.c (core_target_open): Use push_target overload.
13760
13761 2019-02-15  Tom Tromey  <tromey@adacore.com>
13762
13763         * ravenscar-thread.c (is_ravenscar_task)
13764         (ravenscar_task_is_currently_active): Return bool.
13765         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13766         (_initialize_ravenscar): Remove "(void)".
13767         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13768         Return bool.
13769
13770 2019-02-15  Tom Tromey  <tromey@adacore.com>
13771
13772         * ravenscar-thread.c (ravenscar_runtime_initializer)
13773         (has_ravenscar_runtime, get_running_thread_id)
13774         (ravenscar_thread_target::resume): Fix indentation.
13775
13776 2019-02-15  Tom Tromey  <tromey@adacore.com>
13777
13778         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13779         from ravenscar_arch_ops.
13780         (sparc_ravenscar_ops::fetch_registers)
13781         (sparc_ravenscar_ops::store_registers): Now methods.
13782         (sparc_ravenscar_prepare_to_store): Remove.
13783         (sparc_ravenscar_ops): Redefine.
13784         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13785         methods and destructor.  Remove members.
13786         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13787         (ravenscar_thread_target::store_registers)
13788         (ravenscar_thread_target::prepare_to_store): Update.
13789         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13790         Remove.
13791         (struct ppc_ravenscar_powerpc_ops): Derive from
13792         ravenscar_arch_ops.
13793         (ppc_ravenscar_powerpc_ops::fetch_registers)
13794         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13795         (ppc_ravenscar_powerpc_ops): Redefine.
13796         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13797         (ppc_ravenscar_e500_ops::fetch_registers)
13798         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13799         (ppc_ravenscar_e500_ops): Redefine.
13800         * aarch64-ravenscar-thread.c
13801         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13802         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13803         (aarch64_ravenscar_fetch_registers)
13804         (aarch64_ravenscar_store_registers): Now methods.
13805         (aarch64_ravenscar_ops): Redefine.
13806
13807 2019-02-15  Tom Tromey  <tromey@adacore.com>
13808
13809         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13810         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13811         (ravenscar_thread_target::stopped_by_watchpoint)
13812         (ravenscar_thread_target::stopped_data_address)
13813         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13814
13815 2019-02-15  Tom Tromey  <tromey@adacore.com>
13816
13817         * ravenscar-thread.c: Fix some typos.
13818
13819 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13820             Tom Tromey  <tromey@adacore.com>
13821
13822         * ada-lang.c (ada_exception_sal): Change addr_string to a
13823         std::string.
13824         (create_ada_exception_catchpoint): Update.
13825
13826 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13827             Tom Tromey  <tromey@adacore.com>
13828
13829         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13830         (bp_location_ops): Remove.
13831         (base_breakpoint_allocate_location): Update.
13832         (free_bp_location): Update.
13833         * ada-lang.c (class ada_catchpoint_location)
13834         <ada_catchpoint_location>: Remove ops parameter.
13835         (ada_catchpoint_location_dtor): Remove.
13836         (ada_catchpoint_location_ops): Remove.
13837         (allocate_location_exception): Update.
13838         * breakpoint.h (struct bp_location_ops): Remove.
13839         (class bp_location) <bp_location>: Remove bp_location_ops
13840         parameter.
13841         <~bp_location>: Add destructor.
13842         <ops>: Remove.
13843
13844 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13845             Pedro Alves  <palves@redhat.com>
13846
13847         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13848         'PATH_MAX'.
13849
13850 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13851             Samuel Thibault  <samuel.thibault@gnu.org>
13852             Thomas Schwinge  <thomas@codesourcery.com>
13853
13854         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13855         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13856
13857 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13858
13859         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13860         (check_empty): Use "const char *".
13861
13862         * gnu-nat.c (gnu_nat_target::detach): Instead of
13863         'detach_inferior (pid)' call
13864         'detach_inferior (find_inferior_pid (pid))'.
13865
13866         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13867         'nat/fork-inferior.o'.
13868         * gnu-nat.c: #include "nat/fork-inferior.h".
13869
13870         * gnu-nat.c (gnu_nat_target::detach): Instead of
13871         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13872         * gnu-nat.h: #include "inf-child.h".
13873         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13874         'i386_gnu_nat_target::fetch_registers'.
13875         (gnu_store_registers): Rename/move to
13876         'i386_gnu_nat_target::store_registers'.
13877
13878         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13879         * gnu-nat.h (mach_thread_info): New function.
13880         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13881
13882         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13883
13884 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13885
13886         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13887
13888 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13889
13890         * windows-nat.c (windows_add_thread): Add new parameter
13891         "main_thread_p" with default value set to false.  Update
13892         function documentation as well as all callers.
13893         (windows_delete_thread): Likewise.
13894         (fake_create_process): Update call to windows_add_thread.
13895         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13896         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13897         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13898         call to windows_delete_thread.
13899
13900 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13901
13902         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13903
13904 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13905
13906         * symfile.c (find_separate_debug_file): Use canonical path of
13907         sysroot with child_path instead of gdb_sysroot if it is valid.
13908
13909 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13910
13911         * symfile.c (find_separate_debug_file): Use child_path to
13912         determine if an object file is under a sysroot.
13913
13914 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13915
13916         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13917         unittests/child-path-selftests.c.
13918         * common/pathstuff.c (child_path): New function.
13919         * common/pathstuff.h (child_path): New prototype.
13920         * unittests/child-path-selftests.c: New file.
13921
13922 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13923
13924         * symfile.c (find_separate_debug_file): Look for separate debug
13925         files in debug directories under the sysroot.
13926
13927 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13928
13929         * symtab.h (struct minimal_symbol data_p): New const method.
13930         (struct minimal_symbol text_p): Likewise.
13931         * symtab.c (output_source_filename): Use file name style
13932         to print file name.
13933         (print_symbol_info): Likewise.
13934         (print_msymbol_info): Use address style to print addresses.
13935         Use function name style to print executable text symbols.
13936         (expand_symtab_containing_pc): Use data_p.
13937         (find_pc_sect_compunit_symtab): Likewise.
13938
13939 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13940
13941         * breakpoint.c (describe_other_breakpoints): Use address style
13942         to print addresses.
13943         (say_where): Likewise.
13944
13945 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13946
13947         * ada-typeprint.c (print_func_type): Print function name
13948         style to print function name.
13949         * c-typeprint.c (c_print_type_1): Likewise.
13950
13951 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13952
13953         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13954         for execve.
13955
13956 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13957
13958         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13959         type_stack.
13960
13961 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13962
13963         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13964         TYPE_CODE_REF types.
13965
13966 2019-02-08  Jim Wilson  <jimw@sifive.com>
13967
13968         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13969         (riscv_linux_fregset): New.
13970         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13971
13972 2019-02-07  Tom Tromey  <tom@tromey.com>
13973
13974         * thread.c (thread_cancel_execution_command): Update.
13975         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13976         methods.
13977         (struct thread_fsm_ops): Remove.
13978         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13979         (thread_fsm_should_stop, thread_fsm_return_value)
13980         (thread_fsm_set_finished, thread_fsm_finished_p)
13981         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13982         Don't declare.
13983         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13984         * infrun.c (clear_proceed_status_thread)
13985         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13986         (print_stop_event): Update.
13987         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13988         Add constructor.
13989         (step_command_fsm_ops): Remove.
13990         (new_step_command_fsm): Remove.
13991         (step_1): Update.
13992         (step_command_fsm::should_stop): Rename from
13993         step_command_fsm_should_stop.
13994         (step_command_fsm::clean_up): Rename from
13995         step_command_fsm_clean_up.
13996         (step_command_fsm::do_async_reply_reason): Rename from
13997         step_command_fsm_async_reply_reason.
13998         (struct until_next_fsm): Inherit from thread_fsm.  Add
13999         constructor.
14000         (until_next_fsm_ops): Remove.
14001         (new_until_next_fsm): Remove.
14002         (until_next_fsm::should_stop): Rename from
14003         until_next_fsm_should_stop.
14004         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14005         (until_next_fsm::do_async_reply_reason): Rename from
14006         until_next_fsm_async_reply_reason.
14007         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14008         constructor.  Change type of breakpoint.
14009         (finish_command_fsm_ops): Remove.
14010         (new_finish_command_fsm): Remove.
14011         (finish_command_fsm::should_stop): Rename from
14012         finish_command_fsm_should_stop.
14013         (finish_command_fsm::clean_up): Rename from
14014         finish_command_fsm_clean_up.
14015         (finish_command_fsm::return_value): Rename from
14016         finish_command_fsm_return_value.
14017         (finish_command_fsm::do_async_reply_reason): Rename from
14018         finish_command_fsm_async_reply_reason.
14019         (finish_command): Update.
14020         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14021         Add constructor.
14022         (call_thread_fsm_ops): Remove.
14023         (call_thread_fsm::call_thread_fsm): Rename from
14024         new_call_thread_fsm.
14025         (call_thread_fsm::should_stop): Rename from
14026         call_thread_fsm_should_stop.
14027         (call_thread_fsm::should_notify_stop): Rename from
14028         call_thread_fsm_should_notify_stop.
14029         (run_inferior_call, call_function_by_hand_dummy): Update.
14030         * cli/cli-interp.c (should_print_stop_to_console): Update.
14031         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14032         Add constructor.  Change type of location_breakpoint,
14033         caller_breakpoint.
14034         (until_break_fsm_ops): Remove.
14035         (new_until_break_fsm): Remove.
14036         (until_break_fsm::should_stop): Rename from
14037         until_break_fsm_should_stop.
14038         (until_break_fsm::clean_up): Rename from
14039         until_break_fsm_clean_up.
14040         (until_break_fsm::do_async_reply_reason): Rename from
14041         until_break_fsm_async_reply_reason.
14042         (until_break_command): Update.
14043         * thread-fsm.c: Remove.
14044         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14045
14046 2019-02-07  Tom Tromey  <tom@tromey.com>
14047
14048         * yy-remap.h: Add include guard.
14049         * xtensa-tdep.h: Add include guard.
14050         * xcoffread.h: Rename include guard.
14051         * varobj-iter.h: Add include guard.
14052         * tui/tui.h: Rename include guard.
14053         * tui/tui-winsource.h: Rename include guard.
14054         * tui/tui-wingeneral.h: Rename include guard.
14055         * tui/tui-windata.h: Rename include guard.
14056         * tui/tui-win.h: Rename include guard.
14057         * tui/tui-stack.h: Rename include guard.
14058         * tui/tui-source.h: Rename include guard.
14059         * tui/tui-regs.h: Rename include guard.
14060         * tui/tui-out.h: Rename include guard.
14061         * tui/tui-layout.h: Rename include guard.
14062         * tui/tui-io.h: Rename include guard.
14063         * tui/tui-hooks.h: Rename include guard.
14064         * tui/tui-file.h: Rename include guard.
14065         * tui/tui-disasm.h: Rename include guard.
14066         * tui/tui-data.h: Rename include guard.
14067         * tui/tui-command.h: Rename include guard.
14068         * tic6x-tdep.h: Add include guard.
14069         * target/waitstatus.h: Rename include guard.
14070         * target/wait.h: Rename include guard.
14071         * target/target.h: Rename include guard.
14072         * target/resume.h: Rename include guard.
14073         * target-float.h: Rename include guard.
14074         * stabsread.h: Add include guard.
14075         * rs6000-tdep.h: Add include guard.
14076         * riscv-fbsd-tdep.h: Add include guard.
14077         * regformats/regdef.h: Rename include guard.
14078         * record.h: Rename include guard.
14079         * python/python.h: Rename include guard.
14080         * python/python-internal.h: Rename include guard.
14081         * python/py-stopevent.h: Rename include guard.
14082         * python/py-ref.h: Rename include guard.
14083         * python/py-record.h: Rename include guard.
14084         * python/py-record-full.h: Rename include guard.
14085         * python/py-record-btrace.h: Rename include guard.
14086         * python/py-instruction.h: Rename include guard.
14087         * python/py-events.h: Rename include guard.
14088         * python/py-event.h: Rename include guard.
14089         * procfs.h: Add include guard.
14090         * proc-utils.h: Add include guard.
14091         * p-lang.h: Add include guard.
14092         * or1k-tdep.h: Rename include guard.
14093         * observable.h: Rename include guard.
14094         * nto-tdep.h: Rename include guard.
14095         * nat/x86-linux.h: Rename include guard.
14096         * nat/x86-linux-dregs.h: Rename include guard.
14097         * nat/x86-gcc-cpuid.h: Add include guard.
14098         * nat/x86-dregs.h: Rename include guard.
14099         * nat/x86-cpuid.h: Rename include guard.
14100         * nat/ppc-linux.h: Rename include guard.
14101         * nat/mips-linux-watch.h: Rename include guard.
14102         * nat/linux-waitpid.h: Rename include guard.
14103         * nat/linux-ptrace.h: Rename include guard.
14104         * nat/linux-procfs.h: Rename include guard.
14105         * nat/linux-osdata.h: Rename include guard.
14106         * nat/linux-nat.h: Rename include guard.
14107         * nat/linux-namespaces.h: Rename include guard.
14108         * nat/linux-btrace.h: Rename include guard.
14109         * nat/glibc_thread_db.h: Rename include guard.
14110         * nat/gdb_thread_db.h: Rename include guard.
14111         * nat/gdb_ptrace.h: Rename include guard.
14112         * nat/fork-inferior.h: Rename include guard.
14113         * nat/amd64-linux-siginfo.h: Rename include guard.
14114         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14115         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14116         * nat/aarch64-linux.h: Rename include guard.
14117         * nat/aarch64-linux-hw-point.h: Rename include guard.
14118         * mn10300-tdep.h: Add include guard.
14119         * mips-linux-tdep.h: Add include guard.
14120         * mi/mi-parse.h: Rename include guard.
14121         * mi/mi-out.h: Rename include guard.
14122         * mi/mi-main.h: Rename include guard.
14123         * mi/mi-interp.h: Rename include guard.
14124         * mi/mi-getopt.h: Rename include guard.
14125         * mi/mi-console.h: Rename include guard.
14126         * mi/mi-common.h: Rename include guard.
14127         * mi/mi-cmds.h: Rename include guard.
14128         * mi/mi-cmd-break.h: Rename include guard.
14129         * m2-lang.h: Add include guard.
14130         * location.h: Rename include guard.
14131         * linux-record.h: Rename include guard.
14132         * linux-nat.h: Add include guard.
14133         * linux-fork.h: Add include guard.
14134         * i386-darwin-tdep.h: Rename include guard.
14135         * hppa-linux-offsets.h: Add include guard.
14136         * guile/guile.h: Rename include guard.
14137         * guile/guile-internal.h: Rename include guard.
14138         * gnu-nat.h: Rename include guard.
14139         * gdb-stabs.h: Rename include guard.
14140         * frv-tdep.h: Add include guard.
14141         * f-lang.h: Add include guard.
14142         * event-loop.h: Add include guard.
14143         * darwin-nat.h: Rename include guard.
14144         * cp-abi.h: Rename include guard.
14145         * config/sparc/nm-sol2.h: Rename include guard.
14146         * config/nm-nto.h: Rename include guard.
14147         * config/nm-linux.h: Add include guard.
14148         * config/i386/nm-i386gnu.h: Rename include guard.
14149         * config/djgpp/nl_types.h: Rename include guard.
14150         * config/djgpp/langinfo.h: Rename include guard.
14151         * compile/gcc-cp-plugin.h: Add include guard.
14152         * compile/gcc-c-plugin.h: Add include guard.
14153         * compile/compile.h: Rename include guard.
14154         * compile/compile-object-run.h: Rename include guard.
14155         * compile/compile-object-load.h: Rename include guard.
14156         * compile/compile-internal.h: Rename include guard.
14157         * compile/compile-cplus.h: Rename include guard.
14158         * compile/compile-c.h: Rename include guard.
14159         * common/xml-utils.h: Rename include guard.
14160         * common/x86-xstate.h: Rename include guard.
14161         * common/version.h: Rename include guard.
14162         * common/vec.h: Rename include guard.
14163         * common/tdesc.h: Rename include guard.
14164         * common/selftest.h: Rename include guard.
14165         * common/scoped_restore.h: Rename include guard.
14166         * common/scoped_mmap.h: Rename include guard.
14167         * common/scoped_fd.h: Rename include guard.
14168         * common/safe-iterator.h: Rename include guard.
14169         * common/run-time-clock.h: Rename include guard.
14170         * common/refcounted-object.h: Rename include guard.
14171         * common/queue.h: Rename include guard.
14172         * common/ptid.h: Rename include guard.
14173         * common/print-utils.h: Rename include guard.
14174         * common/preprocessor.h: Rename include guard.
14175         * common/pathstuff.h: Rename include guard.
14176         * common/observable.h: Rename include guard.
14177         * common/netstuff.h: Rename include guard.
14178         * common/job-control.h: Rename include guard.
14179         * common/host-defs.h: Rename include guard.
14180         * common/gdb_wait.h: Rename include guard.
14181         * common/gdb_vecs.h: Rename include guard.
14182         * common/gdb_unlinker.h: Rename include guard.
14183         * common/gdb_unique_ptr.h: Rename include guard.
14184         * common/gdb_tilde_expand.h: Rename include guard.
14185         * common/gdb_sys_time.h: Rename include guard.
14186         * common/gdb_string_view.h: Rename include guard.
14187         * common/gdb_splay_tree.h: Rename include guard.
14188         * common/gdb_setjmp.h: Rename include guard.
14189         * common/gdb_ref_ptr.h: Rename include guard.
14190         * common/gdb_optional.h: Rename include guard.
14191         * common/gdb_locale.h: Rename include guard.
14192         * common/gdb_assert.h: Rename include guard.
14193         * common/filtered-iterator.h: Rename include guard.
14194         * common/filestuff.h: Rename include guard.
14195         * common/fileio.h: Rename include guard.
14196         * common/environ.h: Rename include guard.
14197         * common/common-utils.h: Rename include guard.
14198         * common/common-types.h: Rename include guard.
14199         * common/common-regcache.h: Rename include guard.
14200         * common/common-inferior.h: Rename include guard.
14201         * common/common-gdbthread.h: Rename include guard.
14202         * common/common-exceptions.h: Rename include guard.
14203         * common/common-defs.h: Rename include guard.
14204         * common/common-debug.h: Rename include guard.
14205         * common/cleanups.h: Rename include guard.
14206         * common/buffer.h: Rename include guard.
14207         * common/btrace-common.h: Rename include guard.
14208         * common/break-common.h: Rename include guard.
14209         * cli/cli-utils.h: Rename include guard.
14210         * cli/cli-style.h: Rename include guard.
14211         * cli/cli-setshow.h: Rename include guard.
14212         * cli/cli-script.h: Rename include guard.
14213         * cli/cli-interp.h: Rename include guard.
14214         * cli/cli-decode.h: Rename include guard.
14215         * cli/cli-cmds.h: Rename include guard.
14216         * charset-list.h: Add include guard.
14217         * buildsym-legacy.h: Rename include guard.
14218         * bfin-tdep.h: Add include guard.
14219         * ax.h: Rename include guard.
14220         * arm-linux-tdep.h: Add include guard.
14221         * arm-fbsd-tdep.h: Add include guard.
14222         * arch/xtensa.h: Rename include guard.
14223         * arch/tic6x.h: Add include guard.
14224         * arch/i386.h: Add include guard.
14225         * arch/arm.h: Rename include guard.
14226         * arch/arm-linux.h: Rename include guard.
14227         * arch/arm-get-next-pcs.h: Rename include guard.
14228         * arch/amd64.h: Add include guard.
14229         * arch/aarch64-insn.h: Rename include guard.
14230         * arch-utils.h: Rename include guard.
14231         * annotate.h: Add include guard.
14232         * amd64-darwin-tdep.h: Rename include guard.
14233         * aarch64-linux-tdep.h: Add include guard.
14234         * aarch64-fbsd-tdep.h: Add include guard.
14235         * aarch32-linux-nat.h: Add include guard.
14236
14237 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14238
14239         * macrotab.c (macro_define_internal): New function that
14240         factorizes macro_define_object_internal and macro_define_function
14241         code.
14242         (macro_define_object_internal): Use macro_define_internal.
14243         (macro_define_function): Likewise.
14244
14245 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14246
14247         * macrocmd.c (extract_identifier): Return
14248         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14249         callers.
14250
14251 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14252
14253         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14254
14255 2019-02-05  Tom Tromey  <tom@tromey.com>
14256
14257         * target.c (target_stack::unpush): Move assertion earlier.
14258
14259 2019-01-30  Tom Tromey  <tom@tromey.com>
14260
14261         PR python/23615:
14262         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14263         (gdbpy_parse_and_eval): Likewise.
14264         * python/python-internal.h (gdbpy_allow_threads): New class.
14265
14266 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14267
14268         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14269         (aarch64_fbsd_fpregmap): Move earlier.
14270         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14271         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14272         instead of individual calls to trad_frame_set_reg_addr.
14273         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14274         earlier.
14275         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14276         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14277         instead of individual calls to trad_frame_set_reg_addr.
14278
14279 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14280
14281         * CONTRIBUTE: Replace contribution list with wiki link.
14282
14283 2019-01-25  Tom Tromey  <tom@tromey.com>
14284
14285         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14286
14287 2019-01-25  Tom Tromey  <tom@tromey.com>
14288
14289         * xtensa-linux-nat.c: Fix common/ includes.
14290         * xml-support.h: Fix common/ includes.
14291         * xml-support.c: Fix common/ includes.
14292         * x86-linux-nat.c: Fix common/ includes.
14293         * windows-nat.c: Fix common/ includes.
14294         * varobj.h: Fix common/ includes.
14295         * varobj.c: Fix common/ includes.
14296         * value.c: Fix common/ includes.
14297         * valops.c: Fix common/ includes.
14298         * utils.c: Fix common/ includes.
14299         * unittests/xml-utils-selftests.c: Fix common/ includes.
14300         * unittests/utils-selftests.c: Fix common/ includes.
14301         * unittests/unpack-selftests.c: Fix common/ includes.
14302         * unittests/tracepoint-selftests.c: Fix common/ includes.
14303         * unittests/style-selftests.c: Fix common/ includes.
14304         * unittests/string_view-selftests.c: Fix common/ includes.
14305         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14306         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14307         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14308         * unittests/rsp-low-selftests.c: Fix common/ includes.
14309         * unittests/parse-connection-spec-selftests.c: Fix common/
14310         includes.
14311         * unittests/optional-selftests.c: Fix common/ includes.
14312         * unittests/offset-type-selftests.c: Fix common/ includes.
14313         * unittests/observable-selftests.c: Fix common/ includes.
14314         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14315         * unittests/memrange-selftests.c: Fix common/ includes.
14316         * unittests/memory-map-selftests.c: Fix common/ includes.
14317         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14318         * unittests/function-view-selftests.c: Fix common/ includes.
14319         * unittests/environ-selftests.c: Fix common/ includes.
14320         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14321         * unittests/common-utils-selftests.c: Fix common/ includes.
14322         * unittests/cli-utils-selftests.c: Fix common/ includes.
14323         * unittests/array-view-selftests.c: Fix common/ includes.
14324         * ui-file.c: Fix common/ includes.
14325         * tui/tui-io.c: Fix common/ includes.
14326         * tracepoint.h: Fix common/ includes.
14327         * tracepoint.c: Fix common/ includes.
14328         * tracefile-tfile.c: Fix common/ includes.
14329         * top.h: Fix common/ includes.
14330         * top.c: Fix common/ includes.
14331         * thread.c: Fix common/ includes.
14332         * target/waitstatus.h: Fix common/ includes.
14333         * target/waitstatus.c: Fix common/ includes.
14334         * target.h: Fix common/ includes.
14335         * target.c: Fix common/ includes.
14336         * target-memory.c: Fix common/ includes.
14337         * target-descriptions.c: Fix common/ includes.
14338         * symtab.h: Fix common/ includes.
14339         * symfile.c: Fix common/ includes.
14340         * stap-probe.c: Fix common/ includes.
14341         * spu-linux-nat.c: Fix common/ includes.
14342         * sparc-nat.c: Fix common/ includes.
14343         * source.c: Fix common/ includes.
14344         * solib.c: Fix common/ includes.
14345         * solib-target.c: Fix common/ includes.
14346         * ser-unix.c: Fix common/ includes.
14347         * ser-tcp.c: Fix common/ includes.
14348         * ser-pipe.c: Fix common/ includes.
14349         * ser-base.c: Fix common/ includes.
14350         * selftest-arch.c: Fix common/ includes.
14351         * s12z-tdep.c: Fix common/ includes.
14352         * rust-exp.y: Fix common/ includes.
14353         * rs6000-aix-tdep.c: Fix common/ includes.
14354         * riscv-tdep.c: Fix common/ includes.
14355         * remote.c: Fix common/ includes.
14356         * remote-notif.h: Fix common/ includes.
14357         * remote-fileio.h: Fix common/ includes.
14358         * remote-fileio.c: Fix common/ includes.
14359         * regcache.h: Fix common/ includes.
14360         * regcache.c: Fix common/ includes.
14361         * record-btrace.c: Fix common/ includes.
14362         * python/python.c: Fix common/ includes.
14363         * python/py-type.c: Fix common/ includes.
14364         * python/py-inferior.c: Fix common/ includes.
14365         * progspace.h: Fix common/ includes.
14366         * producer.c: Fix common/ includes.
14367         * procfs.c: Fix common/ includes.
14368         * proc-api.c: Fix common/ includes.
14369         * printcmd.c: Fix common/ includes.
14370         * ppc-linux-nat.c: Fix common/ includes.
14371         * parser-defs.h: Fix common/ includes.
14372         * osdata.c: Fix common/ includes.
14373         * obsd-nat.c: Fix common/ includes.
14374         * nat/x86-linux.c: Fix common/ includes.
14375         * nat/x86-linux-dregs.c: Fix common/ includes.
14376         * nat/x86-dregs.h: Fix common/ includes.
14377         * nat/x86-dregs.c: Fix common/ includes.
14378         * nat/ppc-linux.c: Fix common/ includes.
14379         * nat/mips-linux-watch.h: Fix common/ includes.
14380         * nat/mips-linux-watch.c: Fix common/ includes.
14381         * nat/linux-waitpid.c: Fix common/ includes.
14382         * nat/linux-ptrace.h: Fix common/ includes.
14383         * nat/linux-ptrace.c: Fix common/ includes.
14384         * nat/linux-procfs.c: Fix common/ includes.
14385         * nat/linux-personality.c: Fix common/ includes.
14386         * nat/linux-osdata.c: Fix common/ includes.
14387         * nat/linux-namespaces.c: Fix common/ includes.
14388         * nat/linux-btrace.h: Fix common/ includes.
14389         * nat/linux-btrace.c: Fix common/ includes.
14390         * nat/fork-inferior.c: Fix common/ includes.
14391         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14392         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14393         * nat/aarch64-linux.c: Fix common/ includes.
14394         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14395         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14396         * namespace.h: Fix common/ includes.
14397         * mips-linux-tdep.c: Fix common/ includes.
14398         * minsyms.c: Fix common/ includes.
14399         * mi/mi-parse.h: Fix common/ includes.
14400         * mi/mi-main.c: Fix common/ includes.
14401         * mi/mi-cmd-env.c: Fix common/ includes.
14402         * memrange.h: Fix common/ includes.
14403         * memattr.c: Fix common/ includes.
14404         * maint.h: Fix common/ includes.
14405         * maint.c: Fix common/ includes.
14406         * main.c: Fix common/ includes.
14407         * machoread.c: Fix common/ includes.
14408         * location.c: Fix common/ includes.
14409         * linux-thread-db.c: Fix common/ includes.
14410         * linux-nat.c: Fix common/ includes.
14411         * linux-fork.c: Fix common/ includes.
14412         * inline-frame.c: Fix common/ includes.
14413         * infrun.c: Fix common/ includes.
14414         * inflow.c: Fix common/ includes.
14415         * inferior.h: Fix common/ includes.
14416         * inferior.c: Fix common/ includes.
14417         * infcmd.c: Fix common/ includes.
14418         * inf-ptrace.c: Fix common/ includes.
14419         * inf-child.c: Fix common/ includes.
14420         * ia64-linux-nat.c: Fix common/ includes.
14421         * i387-tdep.c: Fix common/ includes.
14422         * i386-tdep.c: Fix common/ includes.
14423         * i386-linux-tdep.c: Fix common/ includes.
14424         * i386-linux-nat.c: Fix common/ includes.
14425         * i386-go32-tdep.c: Fix common/ includes.
14426         * i386-fbsd-tdep.c: Fix common/ includes.
14427         * i386-fbsd-nat.c: Fix common/ includes.
14428         * guile/scm-type.c: Fix common/ includes.
14429         * guile/guile.c: Fix common/ includes.
14430         * go32-nat.c: Fix common/ includes.
14431         * gnu-nat.c: Fix common/ includes.
14432         * gdbthread.h: Fix common/ includes.
14433         * gdbarch-selftests.c: Fix common/ includes.
14434         * gdb_usleep.c: Fix common/ includes.
14435         * gdb_select.h: Fix common/ includes.
14436         * gdb_bfd.c: Fix common/ includes.
14437         * gcore.c: Fix common/ includes.
14438         * fork-child.c: Fix common/ includes.
14439         * findvar.c: Fix common/ includes.
14440         * fbsd-nat.c: Fix common/ includes.
14441         * event-top.c: Fix common/ includes.
14442         * event-loop.c: Fix common/ includes.
14443         * dwarf2read.c: Fix common/ includes.
14444         * dwarf2loc.c: Fix common/ includes.
14445         * dwarf2-frame.c: Fix common/ includes.
14446         * dwarf-index-cache.c: Fix common/ includes.
14447         * dtrace-probe.c: Fix common/ includes.
14448         * disasm-selftests.c: Fix common/ includes.
14449         * defs.h: Fix common/ includes.
14450         * csky-tdep.c: Fix common/ includes.
14451         * cp-valprint.c: Fix common/ includes.
14452         * cp-support.h: Fix common/ includes.
14453         * cp-support.c: Fix common/ includes.
14454         * corelow.c: Fix common/ includes.
14455         * completer.h: Fix common/ includes.
14456         * completer.c: Fix common/ includes.
14457         * compile/compile.c: Fix common/ includes.
14458         * compile/compile-loc2c.c: Fix common/ includes.
14459         * compile/compile-cplus-types.c: Fix common/ includes.
14460         * compile/compile-cplus-symbols.c: Fix common/ includes.
14461         * command.h: Fix common/ includes.
14462         * cli/cli-dump.c: Fix common/ includes.
14463         * cli/cli-cmds.c: Fix common/ includes.
14464         * charset.c: Fix common/ includes.
14465         * build-id.c: Fix common/ includes.
14466         * btrace.h: Fix common/ includes.
14467         * btrace.c: Fix common/ includes.
14468         * breakpoint.h: Fix common/ includes.
14469         * breakpoint.c: Fix common/ includes.
14470         * ax.h:
14471         (enum agent_op): Fix common/ includes.
14472         * ax-general.c (struct aop_map): Fix common/ includes.
14473         * ax-gdb.c: Fix common/ includes.
14474         * auxv.c: Fix common/ includes.
14475         * auto-load.c: Fix common/ includes.
14476         * arm-tdep.c: Fix common/ includes.
14477         * arch/riscv.c: Fix common/ includes.
14478         * arch/ppc-linux-common.c: Fix common/ includes.
14479         * arch/i386.c: Fix common/ includes.
14480         * arch/arm.c: Fix common/ includes.
14481         * arch/arm-linux.c: Fix common/ includes.
14482         * arch/arm-get-next-pcs.c: Fix common/ includes.
14483         * arch/amd64.c: Fix common/ includes.
14484         * arch/aarch64.c: Fix common/ includes.
14485         * arch/aarch64-insn.c: Fix common/ includes.
14486         * arch-utils.c: Fix common/ includes.
14487         * amd64-windows-tdep.c: Fix common/ includes.
14488         * amd64-tdep.c: Fix common/ includes.
14489         * amd64-sol2-tdep.c: Fix common/ includes.
14490         * amd64-obsd-tdep.c: Fix common/ includes.
14491         * amd64-nbsd-tdep.c: Fix common/ includes.
14492         * amd64-linux-tdep.c: Fix common/ includes.
14493         * amd64-linux-nat.c: Fix common/ includes.
14494         * amd64-fbsd-tdep.c: Fix common/ includes.
14495         * amd64-fbsd-nat.c: Fix common/ includes.
14496         * amd64-dicos-tdep.c: Fix common/ includes.
14497         * amd64-darwin-tdep.c: Fix common/ includes.
14498         * agent.c: Fix common/ includes.
14499         * ada-lang.h: Fix common/ includes.
14500         * ada-lang.c: Fix common/ includes.
14501         * aarch64-tdep.c: Fix common/ includes.
14502
14503 2019-01-25  Tom Tromey  <tom@tromey.com>
14504
14505         * common/create-version.sh: Use common/version.h.
14506
14507 2019-01-24  Pedro Alves  <palves@redhat.com>
14508
14509         * infrun.c (signal_stop, signal_print, signal_program)
14510         (signal_catch, signal_pass): Now arrays instead of pointers.
14511         (update_signals_program_target, do_target_resume)
14512         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14513         * linux-nat.c (linux_nat_target::pass_signals)
14514         (linux_nat_target::create_inferior, linux_nat_target::attach):
14515         Adjust.
14516         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14517         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14518         * procfs.c (procfs_target::pass_signals): Adjust.
14519         * record-full.c (record_full_target::resume): Adjust.
14520         * remote.c (remote_target::pass_signals)
14521         (remote_target::program_signals): Adjust.
14522         * target-debug.h (target_debug_print_signals): Now takes a
14523         gdb::array_view as parameter.  Adjust.
14524         * target.h (target_ops) <pass_signals, program_signals>: Replace
14525         pointer and length parameters with gdb::array_view.
14526         (target_pass_signals, target_program_signals): Likewise.
14527         * target-delegates.c: Regenerate.
14528
14529 2019-01-24  Pedro Alves  <palves@redhat.com>
14530
14531         * common/forward-scope-exit.h
14532         (forward_scope_exit::forward_scope_exit): Pass arguments to
14533         m_bind_function directly, instead of creating a std::bind and
14534         copying that.
14535
14536 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14537
14538         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14539         for static members.
14540         (pass_in_v_vfp_candidate): Likewise.
14541
14542 2019-01-23  Tom Tromey  <tom@tromey.com>
14543             Pedro Alves  <palves@redhat.com>
14544
14545         * regcache.c (class regcache_invalidator): Remove.
14546         (regcache::raw_write): Use make_scope_exit.
14547
14548 2019-01-23  Tom Tromey  <tom@tromey.com>
14549
14550         * ui-out.h (class ui_out_emit_type): Update comment.
14551
14552 2019-01-23  Tom Tromey  <tom@tromey.com>
14553
14554         * infrun.c (fetch_inferior_event): Update comment.
14555
14556 2019-01-23  Tom Tromey  <tom@tromey.com>
14557             Pedro Alves  <palves@redhat.com>
14558
14559         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14560         parameter.
14561         (fetch_inferior_event): Use SCOPE_EXIT.
14562
14563
14564 2019-01-23  Tom Tromey  <tom@tromey.com>
14565             Pedro Alves  <palves@redhat.com>
14566
14567         * infrun.c (disable_thread_events): Delete.
14568         (stop_all_threads): Use SCOPE_EXIT.
14569
14570 2019-01-23  Tom Tromey  <tom@tromey.com>
14571             Pedro Alves  <palves@redhat.com>
14572
14573         * symfile.c: Include forward-scope-exit.h.
14574         (clear_symtab_users_cleanup): Replace forward declaration with
14575         a FORWARD_SCOPE_EXIT.
14576         (syms_from_objfile_1): Use the forward_scope_exit and
14577         gdb::optional instead of cleanup_function.
14578         (reread_symbols): Use the forward_scope_exit instead of
14579         cleanup_function.
14580         (clear_symtab_users_cleanup): Remove function.
14581
14582 2019-01-23  Tom Tromey  <tom@tromey.com>
14583             Pedro Alves  <palves@redhat.com>
14584
14585         * linux-nat.c: Include scope-exit.h.
14586         (cleanup_target_stop): Remove.
14587         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14588         SCOPE_EXIT.
14589
14590 2019-01-23  Tom Tromey  <tom@tromey.com>
14591             Pedro Alves  <palves@redhat.com>
14592
14593         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14594         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14595
14596 2019-01-23  Tom Tromey  <tom@tromey.com>
14597             Andrew Burgess  <andrew.burgess@embecosm.com>
14598             Pedro Alves  <palves@redhat.com>
14599
14600         * infrun.c (fetch_inferior_event): Use scope_exit.
14601         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14602         * top.c (execute_command): Use scope_exit.
14603         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14604         * utils.c (do_bpstat_clear_actions_cleanup)
14605         (make_bpstat_clear_actions_cleanup): Remove.
14606
14607 2019-01-23  Tom Tromey  <tom@tromey.com>
14608             Pedro Alves  <palves@redhat.com>
14609
14610         * infrun.c: Include "common/scope-exit.h"
14611         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14612         (wait_for_inferior): Use SCOPE_EXIT.
14613         (fetch_inferior_event): Use scope_exit.
14614
14615 2019-01-23  Tom Tromey  <tom@tromey.com>
14616             Pedro Alves  <palves@redhat.com>
14617
14618         * breakpoint.c (create_breakpoint): Remove cleanup.
14619
14620 2019-01-23  Tom Tromey  <tom@tromey.com>
14621             Andrew Burgess  <andrew.burgess@embecosm.com>
14622             Pedro Alves  <palves@redhat.com>
14623
14624 2019-01-23  Pedro Alves  <palves@redhat.com>
14625
14626         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14627
14628 2019-01-23  Pedro Alves  <palves@redhat.com>
14629             Andrew Burgess  <andrew.burgess@embecosm.com>
14630
14631         * gdbthread.h: Include "common/forward-scope-exit.h".
14632         (scoped_finish_thread_state): Redefine custom class in terms of
14633         forward_scope_exit.
14634
14635 2019-01-23  Pedro Alves  <palves@redhat.com>
14636             Andrew Burgess  <andrew.burgess@embecosm.com>
14637
14638         * common/forward-scope-exit.h: New file.
14639
14640 2019-01-23  Pedro Alves  <palves@redhat.com>
14641             Andrew Burgess  <andrew.burgess@embecosm.com>
14642             Tom Tromey  <tom@tromey.com>
14643
14644         * common/scope-exit.h: New file.
14645
14646 2019-01-23  Pedro Alves  <palves@redhat.com>
14647
14648         * common/preprocessor.h (ESC): Rename to ...
14649         (ESC_PARENS): ... this.
14650         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14651         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14652
14653 2019-01-23  Tom Tromey  <tom@tromey.com>
14654
14655         * language.h (class scoped_switch_to_sym_language_if_auto):
14656         Initialize m_lang in both cases.
14657
14658 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14659
14660         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14661         with XCNEW.
14662
14663 2019-01-22  Tom Tromey  <tom@tromey.com>
14664
14665         * corelow.c: Do not include sys/file.h.
14666
14667 2019-01-22  Tom Tromey  <tom@tromey.com>
14668
14669         * tui/tui-wingeneral.h: Include gdb_curses.h.
14670
14671 2019-01-22  Tom Tromey  <tom@tromey.com>
14672
14673         * source-cache.h (class source_cache) <get_source_lines,
14674         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14675
14676 2019-01-22  Tom Tromey  <tom@tromey.com>
14677
14678         * remote-fileio.h (struct remote_target): Declare.
14679
14680 2019-01-22  Tom Tromey  <tom@tromey.com>
14681
14682         * python/py-arch.c: Do not include py-ref.h.
14683         * python/py-bpevent.c: Do not include py-ref.h.
14684         * python/py-cmd.c: Do not include py-ref.h.
14685         * python/py-continueevent.c: Do not include py-ref.h.
14686         * python/py-event.h: Do not include py-ref.h.
14687         * python/py-evtregistry.c: Do not include py-ref.h.
14688         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14689         * python/py-frame.c: Do not include py-ref.h.
14690         * python/py-framefilter.c: Do not include py-ref.h.
14691         * python/py-function.c: Do not include py-ref.h.
14692         * python/py-infevents.c: Do not include py-ref.h.
14693         * python/py-linetable.c: Do not include py-ref.h.
14694         * python/py-objfile.c: Do not include py-ref.h.
14695         * python/py-param.c: Do not include py-ref.h.
14696         * python/py-prettyprint.c: Do not include py-ref.h.
14697         * python/py-progspace.c: Do not include py-ref.h.
14698         * python/py-symbol.c: Do not include py-ref.h.
14699         * python/py-symtab.c: Do not include py-ref.h.
14700         * python/py-type.c: Do not include py-ref.h.
14701         * python/py-unwind.c: Do not include py-ref.h.
14702         * python/py-utils.c: Do not include py-ref.h.
14703         * python/py-value.c: Do not include py-ref.h.
14704         * python/py-varobj.c: Do not include py-ref.h.
14705         * python/py-xmethods.c: Do not include py-ref.h.
14706         * python/python.c: Do not include py-ref.h.
14707         * varobj.c: Do not include py-ref.h.
14708
14709 2019-01-22  Tom Tromey  <tom@tromey.com>
14710
14711         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14712         keyword for bcache.
14713
14714 2019-01-22  Tom Tromey  <tom@tromey.com>
14715
14716         * compile/compile-cplus-types.c: Remove a comment by #include.
14717
14718 2019-01-22  Tom Tromey  <tom@tromey.com>
14719
14720         * compile/gcc-c-plugin.h: Include compile-internal.h.
14721
14722 2019-01-22  Tom Tromey  <tom@tromey.com>
14723
14724         * stabsread.c (EXTERN): Do not define.
14725         (symnum, next_symbol_text_func, processing_gcc_compilation)
14726         (within_function, global_sym_chain, global_stabs)
14727         (previous_stab_code, this_object_header_files)
14728         (n_this_object_header_files)
14729         (n_allocated_this_object_header_files): Define.
14730         * stabsread.h (EXTERN): Never define.  Use "extern".
14731
14732 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14733
14734         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14735         history_value.
14736
14737 2019-01-21  Tom Tromey  <tom@tromey.com>
14738
14739         * ui-out.c: Fix includes.
14740         * tui/tui-source.c: Fix includes.
14741         * target.c: Fix includes.
14742         * remote.c: Fix includes.
14743         * regcache.c: Fix includes.
14744         * python/py-block.c: Fix includes.
14745         * printcmd.c: Fix includes.
14746         * or1k-tdep.c: Fix includes.
14747         * mi/mi-main.c: Fix includes.
14748         * m32r-tdep.c: Fix includes.
14749         * csky-tdep.c: Fix includes.
14750         * compile/compile-cplus-types.c: Fix includes.
14751         * cli/cli-interp.c: Fix includes.
14752
14753 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14754
14755         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14756         for padding.
14757
14758 2019-01-16  Tom Tromey  <tom@tromey.com>
14759
14760         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14761         earlier.
14762         (struct objfile) <msymbols_range>: Move from top level.
14763         <msymbols>: New method.
14764         (class objfile_msymbols): Remove.
14765         * symtab.c (default_collect_symbol_completion_matches_break_on):
14766         Update.
14767         * symmisc.c (dump_msymbols): Update.
14768         * stabsread.c (scan_file_globals): Update.
14769         * objc-lang.c (info_selectors_command, info_classes_command)
14770         (find_methods): Update.
14771         * minsyms.c (find_solib_trampoline_target): Update.
14772         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14773         * coffread.c (coff_symfile_read): Update.
14774         * ada-lang.c (ada_lookup_simple_minsym)
14775         (ada_collect_symbol_completion_matches): Update.
14776
14777 2019-01-16  Tom Tromey  <tom@tromey.com>
14778
14779         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14780         type.  Remove no-argument constructor.
14781         <iterator::operator++>: Simplify.
14782         <begin>: Update.
14783         <end>: Use minimal_symbol_count.
14784
14785 2019-01-16  Tom Tromey  <tom@tromey.com>
14786
14787         * objfiles.h (struct objfile) <psymtabs>: New method.
14788         (class objfile_psymtabs): Remove.
14789         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14790         typedef.
14791         <range>: New method.
14792         (require_partial_symbols): Change return type.
14793         * psymtab.c (require_partial_symbols)
14794         (psym_expand_symtabs_matching): Update.
14795         * mdebugread.c (parse_partial_symbols): Update.
14796         * dbxread.c (dbx_end_psymtab): Update.
14797
14798 2019-01-15  Tom Tromey  <tom@tromey.com>
14799
14800         * symtab.c (lookup_objfile_from_block)
14801         (lookup_symbol_in_objfile_symtabs)
14802         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14803         (find_line_symtab, info_sources_command)
14804         (default_collect_symbol_completion_matches_break_on)
14805         (make_source_files_completion_list): Update.
14806         * symmisc.c (print_objfile_statistics, dump_objfile)
14807         (maintenance_print_symbols, maintenance_info_symtabs)
14808         (maintenance_check_symtabs, maintenance_info_line_tables):
14809         Update.
14810         * source.c (select_source_symtab)
14811         (forget_cached_source_info_for_objfile): Update.
14812         * objfiles.h (class objfile_compunits): Remove.
14813         (struct objfile) <compunits_range>: New typedef.
14814         (compunits): New method.
14815         * objfiles.c (objfile_relocate1): Update.
14816         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14817         * maint.c (count_symtabs_and_blocks): Update.
14818         * linespec.c (iterate_over_all_matching_symtabs): Update.
14819         * cp-support.c (add_symbol_overload_list_qualified): Update.
14820         * coffread.c (coff_symtab_read): Update.
14821         * ada-lang.c (add_nonlocal_symbols)
14822         (ada_collect_symbol_completion_matches)
14823         (ada_add_global_exceptions): Update.
14824
14825 2019-01-15  Tom Tromey  <tom@tromey.com>
14826
14827         * progspace.h (program_space) <objfiles_safe_range>: New
14828         typedef.
14829         <objfiles_safe>: New method.
14830         * objfiles.h (class all_objfiles_safe): Remove.
14831         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14832         * jit.c (jit_inferior_exit_hook): Update.
14833
14834 2019-01-17  Tom Tromey  <tom@tromey.com>
14835
14836         * progspace.h (program_space) <objfiles_range>: New typedef.
14837         <objfiles>: New method.
14838         <objfiles_head>: Rename from objfiles.
14839         (object_files): Update.
14840         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14841         * guile/scm-pretty-print.c
14842         (ppscm_find_pretty_printer_from_objfiles): Update.
14843         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14844         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14845         Update.
14846         * python/py-progspace.c (pspy_get_objfiles): Update.
14847         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14848         Update.
14849         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14850         (objfpy_lookup_objfile_by_build_id): Update.
14851         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14852         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14853         Update.
14854         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14855         (expand_symtab_containing_pc, lookup_objfile_from_block)
14856         (lookup_static_symbol, basic_lookup_transparent_type)
14857         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14858         (find_line_symtab, info_sources_command)
14859         (default_collect_symbol_completion_matches_break_on)
14860         (make_source_files_completion_list, find_main_name): Update.
14861         * symmisc.c (print_symbol_bcache_statistics)
14862         (print_objfile_statistics, maintenance_print_symbols)
14863         (maintenance_print_msymbols, maintenance_print_objfiles)
14864         (maintenance_info_symtabs, maintenance_check_symtabs)
14865         (maintenance_expand_symtabs, maintenance_info_line_tables):
14866         Update.
14867         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14868         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14869         (map_overlay_command, unmap_overlay_command)
14870         (simple_overlay_update, expand_symtabs_matching)
14871         (map_symbol_filenames): Update.
14872         * symfile-debug.c (set_debug_symfile): Update.
14873         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14874         Update.
14875         * source.c (select_source_symtab, forget_cached_source_info):
14876         Update.
14877         * solib.c (solib_read_symbols): Update.
14878         * solib-spu.c (append_ocl_sos): Update.
14879         * psymtab.c (maintenance_print_psymbols)
14880         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14881         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14882         * printcmd.c (info_symbol_command): Update.
14883         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14884         Update.
14885         * objfiles.h (class all_objfiles): Remove.
14886         * objfiles.c (have_partial_symbols, have_full_symbols)
14887         (have_minimal_symbols, qsort_cmp, update_section_map)
14888         (shared_objfile_contains_address_p)
14889         (default_iterate_over_objfiles_in_search_order): Update.
14890         * objc-lang.c (info_selectors_command, info_classes_command)
14891         (find_methods): Update.
14892         * minsyms.c (find_solib_trampoline_target): Update.
14893         * maint.c (maintenance_info_sections)
14894         (maintenance_translate_address, count_symtabs_and_blocks):
14895         Update.
14896         * main.c (captured_main_1): Update.
14897         * linux-thread-db.c (try_thread_db_load_from_pdir)
14898         (has_libpthread): Update.
14899         * linespec.c (iterate_over_all_matching_symtabs)
14900         (search_minsyms_for_name): Update.
14901         * jit.c (jit_find_objf_with_entry_addr): Update.
14902         * hppa-tdep.c (find_unwind_entry)
14903         (hppa_lookup_stub_minimal_symbol): Update.
14904         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14905         Update.
14906         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14907         (elf_gnu_ifunc_resolve_by_got): Update.
14908         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14909         * dwarf-index-write.c (save_gdb_index_command): Update.
14910         * cp-support.c (add_symbol_overload_list_qualified): Update.
14911         * breakpoint.c (create_overlay_event_breakpoint)
14912         (create_longjmp_master_breakpoint)
14913         (create_std_terminate_master_breakpoint)
14914         (create_exception_master_breakpoint): Update.
14915         * blockframe.c (find_pc_partial_function): Update.
14916         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14917         (ada_collect_symbol_completion_matches)
14918         (ada_add_global_exceptions): Update.
14919
14920 2019-01-17  Tom Tromey  <tom@tromey.com>
14921
14922         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14923         declare VEC.
14924         (solib_target_parse_libraries): Change return type.
14925         (library_list_start_segment, library_list_start_section)
14926         (library_list_end_library, library_list_start_library); Update.
14927         (solib_target_free_library_list): Remove.
14928         (solib_target_parse_libraries): Remove cleanup.  Change return
14929         type.
14930         (solib_target_current_sos): Update.
14931
14932 2019-01-17  Tom Tromey  <tromey@bapiya>
14933
14934         * valprint.c: Replace "the the" with "the".
14935         * symtab.c: Replace "the the" with "the".
14936         * solib.c: Replace "the the" with "the".
14937         * solib-dsbt.c: Replace "the the" with "the".
14938         * linespec.c: Replace "the the" with "the".
14939         * dwarf2loc.h: Replace "the the" with "the".
14940         * amd64-windows-tdep.c: Replace "the the" with "the".
14941         * aarch64-tdep.c: Replace "the the" with "the".
14942
14943 2019-01-16  Keith Seitz  <keiths@redhat.com>
14944
14945         PR gdb/23773
14946         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14947         <builder>: Rename to ..
14948         <m_builder>: ... this and make private.
14949         (dwarf2_cu::get_builder): New method.  Change all users of
14950         `builder' to use this method.
14951         (dwarf2_start_symtab): Move to ...
14952         (dwarf2_cu::start_symtab): ... here.  Update all callers
14953         (setup_type_unit_groups): Move to ...
14954         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14955         callers.
14956         (dwarf2_cu::reset_builder): New method.
14957         (process_full_compunit, process_full_type_unit): Use
14958         dwarf2_cu::reset_builder.
14959         (follow_die_offset): Record the ancestor CU if it is different
14960         from the followed DIE's CU.
14961         (follow_die_sig_1): Likewise.
14962
14963 2019-01-15  Tom Tromey  <tom@tromey.com>
14964
14965         * remote.c (class remote_state) <buf>: Now a char_vector.
14966         <buf_size>: Remove.
14967         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14968         parameter.
14969         (remote_target::getpkt_or_notif_sane_1)
14970         (remote_target::getpkt_sane)
14971         (remote_target::getpkt_or_notif_sane): Likewise.
14972         (class remote_target) <putpkt>: New overload.
14973         (remote_target::read_frame): Change type of "buf_p".  Remove
14974         sizeof_p parameter.
14975         (packet_ok): New overload.
14976         (packet_check_result): New overload.
14977         Update all uses.
14978
14979 2019-01-14  Tom Tromey  <tom@tromey.com>
14980
14981         * remote-notif.c (handle_notification, remote_notif_ack)
14982         (remote_notif_parse): Make "buf" const.
14983         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14984         const.
14985         (remote_notif_parse, remote_notif_ack, handle_notification):
14986         Likewise.
14987         * remote.c (remote_notif_stop_parse): Make "buf" const.
14988         (remote_target::remote_parse_stop_reply): Make "buf" const.
14989         (remote_notif_stop_ack): Make "buf" const.
14990
14991 2019-01-14  Tom Tromey  <tom@tromey.com>
14992
14993         * remote.c (remote_console_output): Make parameter const.
14994
14995 2019-01-14  Tom Tromey  <tom@tromey.com>
14996
14997         * target-debug.h (target_debug_print_signals): Constify.
14998         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14999         * procfs.c (procfs_target::pass_signals): Update.
15000         * linux-nat.c (linux_nat_target::pass_signals): Update.
15001         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15002         * target-delegates.c: Rebuild.
15003         * remote.c (remote_target::program_signals): Update.
15004         (remote_target::pass_signals): Update.
15005         * target.c (target_pass_signals): Constify argument.
15006         (target_program_signals): Likewise.
15007         * target.h (struct target_ops) <pass_signals, program_signals>:
15008         Constify argument.
15009         (target_pass_signals, target_program_signals): Constify argument.
15010
15011 2019-01-14  Tom Tromey  <tom@tromey.com>
15012
15013         PR tui/28819:
15014         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15015
15016 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15017
15018         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15019         field.
15020         * rs6000-tdep.c: Include reggroups.h.
15021         (IS_V_ALIAS_PSEUDOREG): Define.
15022         (rs6000_register_name): Return names for the "vX" aliases.
15023         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15024         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15025         aliases.  Call default_register_reggroup_p for all other
15026         pseudo-registers.
15027         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15028         New functions.
15029         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15030         Handle "vX" aliases.
15031         (v_alias_pseudo_register_collect): New function.
15032         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15033         (rs6000_gdbarch_init): Initialize "vX" aliases as
15034         pseudo-registers.  Restore registration of
15035         rs6000_pseudo_register_reggroup_p with
15036         set_tdesc_pseudo_register_reggroup_p.
15037
15038 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15039
15040         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15041         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15042         set_gdbarch_num_pseudo_regs.
15043
15044 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15045
15046         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15047         Remove arg prefixname, add do_set and do_show.
15048         Add member functions set_list and show_list.
15049         * cli/cli-style.c (class cli_style_option): Update accordingly.
15050         (style_set_list): Move to file scope.
15051         (style_show_list): Likewise.
15052         (set_style): Call help_list.
15053         (show_style): Call cmd_show_list.
15054         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15055         Update to use the new macro.
15056
15057 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15058
15059         * ada-lang.c (_initialize_ada_language): Expand the help text
15060         for the "catch exception" command.
15061
15062 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15063
15064         * symtab.c (matching_obj_sections): Initialize obj,
15065         declare it closer to its usage.
15066
15067 2019-01-10  Tom Tromey  <tom@tromey.com>
15068
15069         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15070         (basic_inf_threads_range): Remove.
15071         (inf_threads_range, inf_non_exited_threads_range)
15072         (safe_inf_threads_range): Use next_adapter.
15073
15074 2019-01-10  Keith Seitz  <keiths@redhat.com>
15075
15076         PR gdb/23712
15077         PR symtab/23010
15078         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15079         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15080
15081 2019-01-10  Keith Seitz  <keiths@redhat.com>
15082
15083         PR gdb/23712
15084         PR symtab/23010
15085         * dictionary.c (pending_to_vector): Remove.
15086         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15087         Remove _1 suffix, replacing functions of the same name.  Update
15088         all callers.
15089         (dict_create_hashed, dict_create_hashed_expandable)
15090         (dict_create_linear, dict_create_linear_expandable, dict_free)
15091         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15092         Make functions static.
15093
15094 2019-01-10  Keith Seitz  <keiths@redhat.com>
15095
15096         PR gdb/23712
15097         PR symtab/23010
15098         * dictionary.h (struct dictionary): Replace declaration with
15099         multidictionary.
15100         (dict_create_hashed, dict_create_hashed_expandable)
15101         (dict_create_linear, dict_create_linear_expandable)
15102         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15103         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15104         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15105         taking multidictionary argument.
15106         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15107         * block.h (struct block) <dict>: Change to multidictionary
15108         and rename `multidict'.
15109         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15110         symmisc.c: Update all dictionary references to multidictionary.
15111
15112 2019-01-10  Keith Seitz  <keiths@redhat.com>
15113
15114         PR gdb/23712
15115         PR symtab/23010
15116         * dictionary.c: Include unordered_map.
15117         (pending_to_vector): New function.
15118         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15119         Rewrite the non-"_1" functions to take vector instead
15120         of linked list.
15121         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15122         "new" _1 versions of the same name.
15123         (multidictionary): Define.
15124         (std::hash<enum language): New definition.
15125         (collate_pending_symbols_by_language, mdict_create_hashed)
15126         (mdict_create_hashed_expandable, mdict_create_linear)
15127         (mdict_create_linear_expandable, mdict_free)
15128         (find_language_dictionary, create_new_language_dictionary)
15129         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15130         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15131         (mdict_size, mdict_empty): New functions.
15132         * dictionary.h (mdict_iterator): Define.
15133
15134 2019-01-10  Pedro Alves  <palves@redhat.com>
15135
15136         * breakpoint.c (read_uploaded_action)
15137         (create_tracepoint_from_upload): Adjust to use
15138         gdb::unique_xmalloc_ptr.
15139         * ctf.c (ctf_write_uploaded_tp):
15140         (SET_ARRAY_FIELD): Use emplace_back.
15141         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15142         * tracefile-tfile.c (tfile_write_uploaded_tp):
15143         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15144         gdb::unique_xmalloc_ptr.
15145         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15146         at_string, cond_string, cmd_strings>: Replace char pointers
15147         with gdb::unique_xmalloc_ptr.
15148
15149 2019-01-10  Pedro Alves  <palves@redhat.com>
15150
15151         * solib-target.c (library_list_start_library): Don't xstrdup name.
15152
15153 2019-01-10  Pedro Alves  <palves@redhat.com>
15154
15155         * mdebugread.c (parse_partial_symbols): Use
15156         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15157
15158 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15159
15160         * linux-fork.c (scoped_switch_fork_info)
15161         <~scoped_switch_fork_info>: Fix incorrect variable name.
15162
15163 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15164
15165         * linux-fork.c (scoped_switch_fork_info)
15166         <scoped_switch_fork_info>: Make explicit.
15167         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15168
15169 2019-01-10  Tom Tromey  <tom@tromey.com>
15170
15171         * objfiles.h (objfile::reset_psymtabs): Update.
15172         * objfiles.c (objfile::objfile): Update.
15173         * psymtab.h (psymtab_storage::obstack): Update.
15174         (psymtab_storage::m_obstack): Use gdb::optional.
15175         (class psymtab_storage): Update comment.  Remove objfile
15176         parameter.
15177         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15178
15179 2019-01-10  Tom Tromey  <tom@tromey.com>
15180
15181         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15182         <free_psymtabs>: Now private.
15183         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15184         (allocate_psymtab): Use new method.
15185
15186 2019-01-10  Tom Tromey  <tom@tromey.com>
15187
15188         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15189         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15190         * mdebugread.c (parse_partial_symbols): Use
15191         allocate_dependencies.
15192         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15193         allocate_dependencies.
15194         (process_psymtab_comp_unit_reader)
15195         (build_type_psymtab_dependencies): Likewise.
15196         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15197
15198 2019-01-10  Tom Tromey  <tom@tromey.com>
15199
15200         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15201         PSYMBOL_SET_LANGUAGE.
15202         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15203
15204 2019-01-10  Tom Tromey  <tom@tromey.com>
15205
15206         * psymtab.h (psymtab_storage::obstack): New method.
15207         <m_obstack>: Rename from obstack; now private.
15208         * psymtab.c (psymtab_storage): Update.
15209         * dwarf2read.c (create_addrmap_from_index)
15210         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15211         Update.
15212
15213 2019-01-10  Tom Tromey  <tom@tromey.com>
15214
15215         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15216         * objfiles.h (objfile::reset_psymtabs): New method.
15217
15218 2019-01-10  Tom Tromey  <tom@tromey.com>
15219
15220         * symmisc.c (print_symbol_bcache_statistics): Update.
15221         (print_objfile_statistics): Update.
15222         * symfile.c (reread_symbols): Update.
15223         * psymtab.h (class psymtab_storage): New.
15224         * psymtab.c (psymtab_storage): New constructor.
15225         (~psymtab_storage): New destructor.
15226         (require_partial_symbols): Update.
15227         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15228         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15229         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15230         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15231         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15232         (start_psymtab_common, end_psymtab_common)
15233         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15234         (allocate_psymtab): Update.
15235         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15236         Update.
15237         (dump_psymtab_addrmap, maintenance_print_psymbols)
15238         (maintenance_check_psymtabs): Update.
15239         (class objfile_psymtabs): Move to objfiles.h.
15240         * psympriv.h (discard_psymtab): Now inline.
15241         (psymtab_discarder::psymtab_discarder): Update.
15242         (psymtab_discarder::~psymtab_discarder): Update.
15243         (ALL_OBJFILE_PSYMTABS): Rewrite.
15244         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15245         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15246         Remove fields.
15247         <partial_symtabs>: New field.
15248         (class objfile_psymtabs): Move from psymtab.h.  Update.
15249         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15250         psymbol_cache.
15251         (objfile::~objfile): Don't destroy psymbol_cache.
15252         * mdebugread.c (parse_partial_symbols): Update.
15253         * dwarf2read.c (create_addrmap_from_index)
15254         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15255         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15256         (add_partial_subprogram, dwarf2_ranges_read): Update.
15257         * dwarf-index-write.c (write_address_map)
15258         (write_one_signatured_type, recursively_write_psymbols)
15259         (class debug_names, class debug_names, write_psymtabs_to_index):
15260         Update.
15261
15262 2019-01-10  Tom Tromey  <tom@tromey.com>
15263
15264         * symtab.h (SYMBOL_SET_NAMES): Update.
15265         (symbol_set_names): Update.
15266         (MSYMBOL_SET_NAMES): Update.
15267         * symtab.c (symbol_set_names): Change argument to be an
15268         objfile_per_bfd_storage.
15269         * psymtab.c (add_psymbol_to_bcache): Update.
15270         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15271
15272 2019-01-10  Tom Tromey  <tom@tromey.com>
15273
15274         * symtab.c (create_demangled_names_hash): Change argument to be an
15275         objfile_per_bfd_storage.
15276         (symbol_set_names): Update.
15277
15278 2019-01-10  Tom Tromey  <tom@tromey.com>
15279
15280         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15281         init_psymbol_list.
15282         * psymtab.c (init_psymbol_list): Do nothing if already called.
15283         * psympriv.h (init_psymbol_list): Add comment.
15284         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15285         init_psymbol_list.
15286         * dbxread.c (dbx_symfile_read): Unconditionally call
15287         init_psymbol_list.
15288
15289 2019-01-10  Tom Tromey  <tom@tromey.com>
15290
15291         * xcoffread.c (scan_xcoff_symtab): Update.
15292         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15293         "where".
15294         * mdebugread.c (parse_partial_symbols)
15295         (handle_psymbol_enumerators): Update.
15296         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15297         * dbxread.c (read_dbx_symtab): Update.
15298         * psympriv.h (psymbol_placement): New enum.
15299         (add_psymbol_to_list): Update.
15300
15301 2019-01-10  Tom Tromey  <tom@tromey.com>
15302
15303         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15304         static_psymbols parameters.
15305         (scan_xcoff_symtab): Update.
15306         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15307         static_psymbols parameters.
15308         * psympriv.h (start_psymtab_common): Update.
15309         * mdebugread.c (parse_partial_symbols): Update.
15310         * dwarf2read.c (create_partial_symtab): Update.
15311         * dbxread.c (read_dbx_symtab): Update.
15312         (start_psymtab): Remove global_psymbols and static_psymbols
15313         parameters.
15314
15315 2019-01-10  Tom Tromey  <tom@tromey.com>
15316
15317         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15318         * psymtab.c (allocate_psymtab): Add comment.
15319         * psympriv.h (allocate_psymtab): Add comment.
15320         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15321         initializations.
15322         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15323
15324 2019-01-10  Tom Tromey  <tom@tromey.com>
15325
15326         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15327         Don't declare.
15328         * mipsread.c: Include mdebugread.h.
15329         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15330         Declare.
15331         * elfread.c: Include mdebugread.h.
15332
15333 2019-01-09  Tom Tromey  <tom@tromey.com>
15334
15335         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15336         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15337         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15338         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15339         (psym_lookup_symbol, psym_find_last_source_symtab)
15340         (psym_forget_cached_source_info, psym_print_stats)
15341         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15342         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15343         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15344         (psym_find_compunit_symtab_by_address)
15345         (maintenance_print_psymbols, maintenance_info_psymtabs)
15346         (maintenance_check_psymtabs): Use ranged for.
15347         * psymtab.h (class objfile_psymtabs): New.
15348         (require_partial_symbols): Return objfile_psymtabs.
15349         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15350
15351 2019-01-09  Tom Tromey  <tom@tromey.com>
15352
15353         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15354         (find_pc_mapped_section, list_overlays_command)
15355         (map_overlay_command, unmap_overlay_command)
15356         (simple_overlay_update): Use all_objfiles.
15357         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15358         * printcmd.c (info_symbol_command): Use all_objfiles.
15359         * objfiles.h (ALL_OBJSECTIONS): Remove.
15360         * maint.c (maintenance_translate_address): Use all_objfiles.
15361         * gcore.c (gcore_create_callback): Use all_objfiles.
15362         (objfile_find_memory_regions): Likewise.
15363
15364 2019-01-09  Tom Tromey  <tom@tromey.com>
15365
15366         * symtab.c (find_line_symtab, info_sources_command)
15367         (make_source_files_completion_list): Use objfile_compunits.
15368         * source.c (select_source_symtab): Use objfile_compunits.
15369         * objfiles.h (struct objfile): Update comment.
15370         (ALL_OBJFILES): Remove.
15371         (ALL_FILETABS): Remove.
15372         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15373         objfile_compunits.
15374
15375 2019-01-09  Tom Tromey  <tom@tromey.com>
15376
15377         * symmisc.c (print_objfile_statistics, dump_objfile)
15378         (maintenance_print_symbols): Use compunit_filetabs.
15379         * source.c (forget_cached_source_info_for_objfile): Use
15380         compunit_filetabs.
15381         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15382         (ALL_FILETABS): Use compunit_filetabs.
15383         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15384         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15385
15386 2019-01-09  Tom Tromey  <tom@tromey.com>
15387
15388         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15389         (compunit_filetabs): New.
15390         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15391         compunit_filetabs.
15392         (info_sources_command, make_source_files_completion_list): Remove
15393         declaration.
15394         * symmisc.c (print_objfile_statistics, dump_objfile)
15395         (maintenance_print_symbols): Remove declaration.
15396         (maintenance_info_symtabs): Use compunit_filetabs.
15397         (maintenance_info_line_tables): Likewise.
15398         * source.c (select_source_symtab): Change local variable name.
15399         (forget_cached_source_info_for_objfile): Remove declaration.
15400         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15401         * objfiles.c (objfile_relocate1): Remove declaration.
15402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15403         declaration.
15404         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15405         * coffread.c (coff_symtab_read): Remove declaration.
15406         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15407         compunit_filetabs.
15408
15409 2019-01-09  Tom Tromey  <tom@tromey.com>
15410
15411         * symtab.c (lookup_objfile_from_block)
15412         (find_pc_sect_compunit_symtab, search_symbols)
15413         (default_collect_symbol_completion_matches_break_on): Use
15414         objfile_compunits.
15415         * objfiles.h (ALL_COMPUNITS): Remove.
15416         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15417         * cp-support.c (add_symbol_overload_list_qualified): Use
15418         objfile_compunits.
15419         * ada-lang.c (ada_collect_symbol_completion_matches)
15420         (ada_add_global_exceptions): Use objfile_compunits.
15421
15422 2019-01-09  Tom Tromey  <tom@tromey.com>
15423
15424         * source.c (select_source_symtab)
15425         (forget_cached_source_info_for_objfile): Remove declaration.
15426         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15427         declaration.
15428         * maint.c (count_symtabs_and_blocks): Remove declaration.
15429         * cp-support.c (add_symbol_overload_list_qualified): Remove
15430         declaration.
15431         * coffread.c (coff_symtab_read): Remove declaration.
15432         * symtab.c (lookup_symbol_in_objfile_symtabs)
15433         (basic_lookup_transparent_type_1): Use objfile_compunits.
15434         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15435         (info_sources_command, search_symbols)
15436         (default_collect_symbol_completion_matches_break_on)
15437         (make_source_files_completion_list): Remove declaration.
15438         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15439         (ada_collect_symbol_completion_matches)
15440         (ada_add_global_exceptions): Remove declaration.
15441         * linespec.c (iterate_over_all_matching_symtabs): Use
15442         objfile_compunits.
15443         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15444         (class objfile_compunits): New.
15445         (ALL_COMPUNITS): Use objfile_compunits.
15446         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15447         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15448         objfile_compunits.
15449         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15450
15451 2019-01-09  Tom Tromey  <tom@tromey.com>
15452
15453         * symtab.c (search_symbols)
15454         (default_collect_symbol_completion_matches_break_on): Use
15455         objfile_msymbols.
15456         * ada-lang.c (ada_lookup_simple_minsym)
15457         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15458         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15459         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15460         objfile_msymbols.
15461         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15462         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15463         * objc-lang.c (find_methods): Use objfile_msymbols.
15464         (info_selectors_command, info_classes_command): Likewise.
15465         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15466         * objfiles.h (class objfile_msymbols): New.
15467         (ALL_OBJFILE_MSYMBOLS): Remove.
15468         (ALL_MSYMBOLS): Remove.
15469
15470 2019-01-09  Tom Tromey  <tom@tromey.com>
15471
15472         * common/next-iterator.h (next_adapter): Add Iterator template
15473         parameter.
15474         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15475         (class all_objfiles_safe): New.
15476         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15477         * objfiles.c (put_objfile_before): Update comment.
15478         (add_separate_debug_objfile): Likewise.
15479         (free_all_objfiles): Use all_objfiles_safe.
15480         (objfile_purge_solibs): Likewise.
15481
15482 2019-01-09  Tom Tromey  <tom@tromey.com>
15483
15484         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15485         (expand_symtab_containing_pc, lookup_static_symbol)
15486         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15487         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15488         all_objfiles.
15489         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15490         * breakpoint.c (create_overlay_event_breakpoint)
15491         (create_longjmp_master_breakpoint)
15492         (create_std_terminate_master_breakpoint)
15493         (create_exception_master_breakpoint): Use all_objfiles.
15494         * linux-thread-db.c (try_thread_db_load_from_pdir)
15495         (has_libpthread): Use all_objfiles.
15496         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15497         * linespec.c (iterate_over_all_matching_symtabs)
15498         (search_minsyms_for_name): Use all_objfiles.
15499         * maint.c (maintenance_info_sections): Use all_objfiles.
15500         * main.c (captured_main_1): Use all_objfiles.
15501         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15502         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15503         * guile/scm-pretty-print.c
15504         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15505         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15506         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15507         (maintenance_print_msymbols): Use all_objfiles.
15508         * source.c (select_source_symtab): Use all_objfiles.
15509         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15510         * symfile.c (remove_symbol_file_command)
15511         (expand_symtabs_matching, map_symbol_filenames): Use
15512         all_objfiles.
15513         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15514         all_objfiles.
15515         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15516         * objc-lang.c (find_methods): Use all_objfiles.
15517         * objfiles.c (have_partial_symbols, have_full_symbols)
15518         (have_minimal_symbols, qsort_cmp)
15519         (default_iterate_over_objfiles_in_search_order): Use
15520         all_objfiles.
15521         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15522         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15523         (maintenance_check_psymtabs): Use all_objfiles.
15524         (ALL_PSYMTABS): Remove.
15525         * compile/compile-object-run.c (do_module_cleanup): Use
15526         all_objfiles.
15527         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15528         * cp-support.c (add_symbol_overload_list_qualified): Use
15529         all_objfiles.
15530         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15531         Use all_objfiles.
15532         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15533         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15534         all_objfiles.
15535         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15536         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15537         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15538         Uses all_objfiles.
15539         * solib.c (solib_read_symbols): Use all_objfiles
15540
15541 2019-01-09  Tom Tromey  <tom@tromey.com>
15542
15543         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15544         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15545         all_objfiles.
15546         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15547         * symmisc.c (print_symbol_bcache_statistics)
15548         (print_objfile_statistics, maintenance_print_objfiles)
15549         (maintenance_info_symtabs, maintenance_check_symtabs)
15550         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15551         all_objfiles.
15552         * source.c (forget_cached_source_info): Use all_objfiles.
15553         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15554         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15555         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15556         * objfiles.c (update_section_map): Use all_objfiles.
15557         (shared_objfile_contains_address_p): Likewise.
15558         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15559         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15560
15561 2019-01-09  Tom Tromey  <tom@tromey.com>
15562
15563         * common/next-iterator.h: New file.
15564         * objfiles.h (class all_objfiles): New.
15565         (struct objfile_iterator): New.
15566
15567 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15568
15569         * NEWS: Move the description of the changed "frame", "select-frame",
15570          and "info frame" commands to the Changed commands section.
15571
15572 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15573
15574         * gdbtypes.c (check_stub_method_group): Remove handling of old
15575         mangling schemes.
15576         * linespec.c (find_methods): Likewise.
15577         * stabsread.c (read_member_functions): Likewise.
15578         * valops.c (search_struct_method): Likewise.
15579         (value_struct_elt_for_reference): Likewise.
15580         * NEWS: Mention this change.
15581
15582 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15583
15584         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15585         print_source_lines.
15586         * source.c (print_source_lines_base): Update line number check.
15587         (print_source_lines): New function.
15588         (source_lines_range::source_lines_range): New function.
15589         * source.h (class source_lines_range): New class.
15590         (print_source_lines): New declaration.
15591
15592 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15593
15594         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15595
15596 2019-01-08  Tom Tromey  <tom@tromey.com>
15597             Simon Marchi  <simon.marchi@ericsson.com>
15598
15599         PR gdb/24060
15600         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15601         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15602         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15603         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15604         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15605         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15606
15607 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15608
15609         * source.c (select_source_symtab): Move header comment to
15610         declaration in source.h.
15611         (forget_cached_source_info_for_objfile): Likewise.
15612         (forget_cached_source_info): Likewise.
15613         (identify_source_line): Likewise.
15614         * source.h (identify_source_line): Move declaration from symtab.h
15615         and add comment from source.c
15616         (print_source_lines): Likewise.
15617         (forget_cached_source_info_for_objfile): Likewise.
15618         (forget_cached_source_info): Likewise.
15619         (select_source_symtab): Likewise.
15620         (enum print_source_lines_flag): Move definition from symtab.h.
15621         * symtab.h (identify_source_line): Move declaration to source.h.
15622         (print_source_lines): Likewise.
15623         (forget_cached_source_info_for_objfile): Likewise.
15624         (forget_cached_source_info): Likewise.
15625         (select_source_symtab): Likewise.
15626         (enum print_source_lines_flag): Move definition to source.h.
15627         * tui/tui-hooks.c: Add 'source.h' include.
15628
15629 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15630
15631         * source.c (print_source_lines_base): Handle requests to print
15632         reverse line number sequences, and guard against empty lines
15633         string.
15634
15635 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15636
15637         * source.c (print_source_lines_base): Fix skip of '\r' if next
15638         character is '\n'.
15639
15640 2019-01-06  Tom Tromey  <tom@tromey.com>
15641
15642         * c-exp.y (struct c_parse_state) <macro_original_text,
15643         expansion_obstack>: New member.
15644         (macro_original_text, expansion_obstack): Remove globals.
15645         (scan_macro_expansion, scanning_macro_expansion)
15646         (finished_macro_expansion): Update.
15647         (scan_macro_cleanup): Remove.
15648         (yylex, c_parse): Update.
15649
15650 2019-01-06  Tom Tromey  <tom@tromey.com>
15651
15652         * c-exp.y (struct c_parse_state) <strings>: New member.
15653         (operator_stoken): Update.
15654
15655 2019-01-06  Tom Tromey  <tom@tromey.com>
15656
15657         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15658         (union type_stack_elt) <typelist_val>: Now a pointer to
15659         std::vector.
15660         (type_stack_cleanup): Don't declare.
15661         (push_typelist): Update.
15662         * parse.c (pop_typelist): Return a std::vector.
15663         (push_typelist): Take a std::vector.
15664         (follow_types): Update.  Do not free args.
15665         (type_stack_cleanup): Remove.
15666         * c-exp.y (struct c_parse_state): New.
15667         (cpstate): New global.
15668         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15669         (nonempty_typelist): Update.
15670         (func_mod): Create a new vector.
15671         (c_parse): Create a c_parse_state.
15672         (check_parameter_typelist): Do not delete params.
15673         (function_method): Update.  Do not delete type_list.
15674
15675 2019-01-06  Tom Tromey  <tom@tromey.com>
15676
15677         PR gdb/28155:
15678         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15679         check_typedef.
15680         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15681         (print_return_value): Likewise.
15682
15683 2019-01-05  Tom Tromey  <tom@tromey.com>
15684
15685         * contrib/cleanup_check.py: Remove.
15686         * contrib/gcc-with-excheck: Remove.
15687         * contrib/exsummary.py: Remove.
15688         * contrib/excheck.py: Remove.
15689
15690 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15691
15692         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15693         NULL. Initialize tpprev to NULL instead of assigning it
15694         to NULL on the next statement.
15695         * windows-nat.c (windows_delete_thread): Remove check for
15696         main_thread_id before printing thread exit notifications.
15697         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15698         Remove thread ID check against main_thread_id.
15699         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15700         windows_delete_thread.
15701         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15702
15703 2019-01-04  Tom Tromey  <tom@tromey.com>
15704
15705         * compile/compile.c (_initialize_compile): Use upper case for
15706         metasyntactic variables.
15707         * symmisc.c (_initialize_symmisc): Use upper case for
15708         metasyntactic variables.
15709         * psymtab.c (_initialize_psymtab): Use upper case for
15710         metasyntactic variables.
15711         * demangle.c (demangle_command): Use upper case for metasyntactic
15712         variables.
15713         (_initialize_demangler): Likewise.
15714         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15715         variables.
15716
15717 2019-01-03  Tom Tromey  <tom@tromey.com>
15718
15719         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15720
15721 2019-01-03  Tom Tromey  <tom@tromey.com>
15722
15723         * python/py-symtab.c (salpy_str): Update.
15724         (struct salpy_sal_object) <symtab>: Now a PyObject.
15725         (salpy_dealloc): Update.
15726         (del_objfile_sal): Use gdbpy_ref.
15727
15728 2019-01-03  Tom Tromey  <tom@tromey.com>
15729
15730         * python/py-type.c (convert_field): Use new_reference.  Return
15731         gdbpy_ref.
15732         (make_fielditem): Return gdbpy_ref.
15733         (typy_fields): Update.
15734         (typy_getitem): Update.
15735         (field_name): Return gdbpy_ref.  Use new_reference.
15736         (typy_iterator_iternext): Update.
15737
15738 2019-01-03  Tom Tromey  <tom@tromey.com>
15739
15740         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15741
15742 2019-01-03  Tom Tromey  <tom@tromey.com>
15743
15744         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15745         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15746         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15747         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15748         (pspy_set_type_printers): Likewise.
15749         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15750         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15751         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15752         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15753         (objfpy_set_type_printers): Likewise.
15754
15755 2019-01-03  Tom Tromey  <tom@tromey.com>
15756
15757         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15758         (gdbpy_print_stack): Use gdbpy_err_fetch.
15759         * python/python-internal.h (class gdbpy_err_fetch): New class.
15760         (class gdbpy_enter) <m_error_type, m_error_value,
15761         m_error_traceback>: Remove.
15762         <m_error>: New member.
15763         (gdbpy_exception_to_string): Don't declare.
15764         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15765         * python/py-value.c (convert_value_from_python): Use
15766         gdbpy_err_fetch.
15767         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15768         gdbpy_exception_to_string.
15769         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15770         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15771         gdbpy_err_fetch.
15772
15773 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15774
15775         * linux-nat.c (delete_lwp_cleanup): Delete.
15776         (struct lwp_deleter): New struct.
15777         (lwp_info_up): New typedef.
15778         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15779         lwp_info_up.
15780
15781 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15782
15783         * linux-fork.c (class scoped_switch_fork_info): New class.
15784         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15785
15786 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15787
15788         * valops.c (find_overload_match): Remove use of null_cleanup, and
15789         calls to do_cleanups.
15790
15791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15792
15793         * compile/compile-cplus-types.c
15794         (compile_cplus_instance::decl_name): Handle changes to
15795         cp_func_name.
15796         * cp-support.c (cp_func_name): Update header comment, update
15797         return type.
15798         * cp-support.h (cp_func_name): Update return type in declaration.
15799         * valops.c (find_overload_match): Move temp_func local to top
15800         level of function and change its type.  Use temp_func to hold and
15801         delete temporary string obtained from cp_func_name.
15802
15803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15804
15805         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15806         gdb::char_vector, remove cleanup, and update uses of `msg`.
15807
15808 2019-01-03  Jim Wilson  <jimw@sifive.com>
15809
15810         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15811
15812 2019-01-02  Tom Tromey  <tom@tromey.com>
15813
15814         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15815         (tdesc_parse_xml): Remove cleanups.
15816         * target-descriptions.h (make_cleanup_free_target_description):
15817         Don't declare.
15818         (target_desc_deleter): New struct.
15819         (target_desc_up): New typedef.
15820         * target-descriptions.c (target_desc_deleter::operator()): Rename
15821         from free_target_description.
15822         (make_cleanup_free_target_description): Remove.
15823
15824 2019-01-02  Tom Tromey  <tom@tromey.com>
15825
15826         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15827         constructor, destructor.
15828         (linespec_parser): Remove typedef.
15829         (~linespec_parser): Rename from linespec_parser_delete.
15830         (linespec_lex_to_end, linespec_complete_label)
15831         (linespec_complete): Update.
15832         (decode_line_full): Remove cleanups.
15833         (decode_line_1): Update.
15834
15835 2019-01-02  Tom Tromey  <tom@tromey.com>
15836
15837         * python/python-internal.h (inferior_to_inferior_object): Change
15838         return type.
15839         * python/py-exitedevent.c (create_exited_event_object): Update.
15840         * python/py-inferior.c (inferior_to_inferior_object): Return
15841         gdbpy_ref.
15842         (python_new_inferior, python_inferior_deleted)
15843         (thread_to_thread_object, delete_thread_object)
15844         (build_inferior_list, gdbpy_selected_inferior): Update.
15845         * python/py-infthread.c (create_thread_object): Update.  Also fail
15846         if inferior_to_inferior_object fails.
15847
15848 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15849
15850         * inferior.h (class inferior) <displaced_step_state>: New field.
15851         * infrun.h (struct displaced_step_state): Move here from
15852         infrun.c.  Initialize fields, add constructor.
15853         <inf>: Remove field.
15854         <reset>: New method.
15855         * infrun.c (struct displaced_step_inferior_state): Move to
15856         infrun.h.
15857         (displaced_step_inferior_states): Remove.
15858         (get_displaced_stepping_state): Adust.
15859         (displaced_step_in_progress_any_inferior): Adjust.
15860         (displaced_step_in_progress_thread): Adjust.
15861         (displaced_step_in_progress): Adjust.
15862         (add_displaced_stepping_state): Remove.
15863         (get_displaced_step_closure_by_addr): Adjust.
15864         (remove_displaced_stepping_state): Remove.
15865         (infrun_inferior_exit): Call displaced_step_state.reset.
15866         (use_displaced_stepping): Don't check for NULL.
15867         (displaced_step_prepare_throw): Call
15868         get_displaced_stepping_state.
15869         (displaced_step_fixup): Don't check for NULL.
15870         (prepare_for_detach): Don't check for NULL.
15871
15872 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15873
15874         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15875          in case of call that did not complete.
15876
15877 2019-01-02  Andrey Utkin  <autkin@undo.io>
15878
15879         * symfile.c (find_separate_debug_file): Fix search of debug files for
15880         remote debuggee.
15881
15882 2019-01-02  Tom Tromey  <tom@tromey.com>
15883
15884         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15885         indentation.
15886         * python/py-frame.c (frapy_older): Remove cast.
15887         (frapy_newer): Likewise.
15888         * python/py-breakpoint.c (local_setattro): Remove cast.
15889         * python/py-arch.c (archpy_name): Remove local variable.
15890         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15891
15892 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15893
15894         * unittests/basic_string_view/element_access/char/empty.cc:
15895         Fix year range in copyright header.
15896
15897 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15898
15899         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15900         Delete.
15901         <operator==>: Update with for removed field.
15902         <hash>: Likewise.
15903         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15904         <isa_features>: ...this.
15905         <abi_features>: New field.
15906         (riscv_isa_flen): Update comment.
15907         (riscv_abi_xlen): New declaration.
15908         (riscv_abi_flen): New declaration.
15909         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15910         isa_features.
15911         (riscv_abi_xlen): New function.
15912         (riscv_isa_flen): Update to get answer from isa_features.
15913         (riscv_abi_flen): New function.
15914         (riscv_has_fp_abi): Update to get answer from abi_features.
15915         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15916         xlen and flen.
15917         (riscv_call_info) <xlen, flen>: Update comment.
15918         (riscv_call_arg_struct): Remove invalid assertions
15919         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15920         is removed.
15921         (riscv_gdbarch_init): Gather isa features and abi features
15922         separately, ensure both match on the gdbarch when reusing an old
15923         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15924         a target with 64-bit float hardware.
15925
15926 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15927
15928         * source.c (search_command_helper): Stop reverse search
15929         when line 1 has been searched.
15930
15931 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15932
15933         * record-full.c (record_full_base_target::close): Rewrite
15934         record_full_core_buf_list free logic.
15935
15936 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15937
15938         * break-catch-syscall.c (print_one_catch_syscall): xfree
15939         the last text.
15940
15941 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15942
15943         * top.c (print_gdb_version): Update Copyright year in version
15944         message.
15945
15946 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15947
15948         Update copyright year range in all GDB files.
15949
15950 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15951
15952         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15953
15954 For older changes see ChangeLog-2018.
15955 \f
15956 Local Variables:
15957 mode: change-log
15958 left-margin: 8
15959 fill-column: 74
15960 version-control: never
15961 coding: utf-8
15962 End:
15963