gdb/ChangeLog

   1 2019-07-03  Pedro Alves  <palves@redhat.com>
   2
   3         * NEWS (New commands): Mention "maint set/show test-settings"
   4         instead of "maint test-settings".
   5         * maint-test-settings.c (maintenance_test_settings_list): Delete.
   6         (maintenance_test_settings_set_list): Rename to ...
   7         (maintenance_set_test_settings_list): ... this.
   8         (maintenance_test_settings_show_list): Rename to  ...
   9         (maintenance_show_test_settings_list): ... this.
  10         (maintenance_test_settings_cmd): Delete.
  11         (maintenance_test_settings_set_cmd): ...
  12         (maintenance_set_test_settings_cmd): ... this.
  13         (maintenance_test_settings_show_cmd): ...
  14         (maintenance_show_test_settings_cmd): ... this.
  15         (maintenance_test_settings_show_value_cmd):
  16         (maintenance_show_test_settings_value_cmd): ... this.
  17         (_initialize_maint_test_settings): No longer install the "maint
  18         test-settings" prefix command.  Rename "maint test-settings set"
  19         to "maint set test-settings", and "maint test-settings show" to
  20         "maint show test-settings".  Adjust all subcommands.
  21
  22 2019-07-03  Pedro Alves  <palves@redhat.com>
  23
  24         * maint-test-settings.c: Fix file's intro comment.  Replace all
  25         references to "test-options" with references to "test-settings",
  26         in comments.
  27
  28 2019-07-03  Pedro Alves  <palves@redhat.com>
  29
  30         * maint-test-settings.c (maintenance_test_settings_xxx)
  31         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
  32         New.
  33         (maintenance_test_settings_enums): Use them.
  34         (maintenance_test_settings_enum): Default to
  35         maintenance_test_settings_xxx.
  36         (_initialize_maint_test_settings): Initialize
  37         MAINTENANCE_TEST_SETTINGS_FILENAME.
  38
  39 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  40
  41         * breakpoint.h (remove_breakpoints_inf): Change return type to
  42         void, move function documentation here.
  43         * breakpoint.c (remove_breakpoints_inf): Change return type to
  44         void, move function documentation to header.
  45
  46 2019-07-02  Pedro Alves  <palves@redhat.com>
  47
  48         * NEWS (Completion improvements): Mention "info threads".
  49         * thread.c (struct info_threads_opts, info_threads_option_defs)
  50         (make_info_threads_options_def_group): New.
  51         (info_threads_command): Use gdb::option::process_options.
  52         (info_threads_command_completer): New.
  53         (_initialize_thread): Use gdb::option::build_help to build the
  54         help text for "info threads".
  55
  56 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  57
  58         * defs.h (generic_load): Move from here...
  59         * symfile.h (generic_load): ... to here.  Rename name parameter
  60         to args.
  61         * symfile.c (generic_load): Add comment.
  62
  63 2019-07-01  Tom Tromey  <tromey@adacore.com>
  64
  65         * dwarf2read.c
  66         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  67         declaration of without_params.  Fix formatting.
  68
  69 2019-07-01  Tom Tromey  <tromey@adacore.com>
  70
  71         * ada-exp.y (find_primitive_type): Update.
  72         * ada-lang.h (ada_lookup_symbol): Update.
  73         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
  74         parameter.
  75         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
  76
  77 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  78
  79         PR breakpoints/24541
  80         * gdbarch.c: Regenerate.
  81         * gdbarch.h: Regenerate.
  82         * gdbarch.sh: Add 'stap_adjust_register'.
  83         * i386-tdep.c: Include '<unordered_set>'.
  84         (i386_stap_adjust_register): New function.
  85         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  86         * stap-probe.c (stap_parse_register_operand): Call
  87         'gdbarch_stap_adjust_register'.
  88
  89 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  90
  91         PR python/24742
  92         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  93         * python/python.c (do_start_initialization): Use 'xmalloc'
  94         instead of 'PyMem_Malloc'.
  95
  96 2019-06-28  Tom Tromey  <tromey@adacore.com>
  97
  98         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  99         for Ada.
 100
 101 2019-06-27  Tom Tromey  <tromey@adacore.com>
 102
 103         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 104         objfile_key.
 105         (arm_find_mapping_symbol, arm_record_special_symbol)
 106         (_initialize_arm_tdep): Update.
 107         (arm_objfile_data_free): Remove.
 108
 109 2019-06-27  Tom Tromey  <tromey@adacore.com>
 110
 111         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 112         to cp_print_static_field.
 113
 114 2019-06-26  Tom Tromey  <tromey@adacore.com>
 115
 116         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 117         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 118         declare.
 119
 120 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 121
 122         * features/aarch64-core.c (create_feature_aarch64_core):
 123         Regenerate.
 124         * features/aarch64-core.xml: Add cpsr flags.
 125
 126 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 127
 128         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 129         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 130
 131 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 132
 133         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 134         field.
 135         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 136         use.
 137         (arm_record_special_symbol): Don't insert new symbol in sorted
 138         position, push it at the end.
 139
 140 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 141
 142         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 143         (arm_mapping_symbol_s): Remove.
 144         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 145         (arm_mapping_symbol_vec): New typedef.
 146         (struct arm_per_objfile): Add constructor.
 147         <section_maps>: Change type to
 148         std::unique_ptr<arm_mapping_symbol_vec[]>.
 149         (arm_compare_mapping_symbols): Remove.
 150         (arm_find_mapping_symbol): Adjust to section_maps type change.
 151         (arm_objfile_data_free): Call delete on arm_per_objfile.
 152         (arm_record_special_symbol): Adjust to section_maps type change.
 153         Allocate arm_per_objfile with new.
 154
 155 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 156
 157         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 158         with the command prefix.
 159
 160 2019-06-25  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 163         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 164
 165 2019-06-25  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 168         type.
 169         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 170         protected.
 171
 172 2019-06-25  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-winsource.c
 175         (tui_source_window_base::set_is_exec_point_at): Add check against
 176         LOA_ADDRESS.
 177
 178 2019-06-25  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-source.c (tui_set_source_content): Don't check before
 181         xfree.
 182         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 183
 184 2019-06-25  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-winsource.h (tui_update_source_window_as_is)
 187         (tui_alloc_source_buffer, tui_line_is_displayed)
 188         (tui_addr_is_displayed): Change type of win_info.
 189         * tui/tui-winsource.c (tui_update_source_window_as_is)
 190         (tui_clear_source_content, tui_show_source_line)
 191         (tui_show_source_content, tui_source_window_base::refill)
 192         (tui_source_window_base::set_is_exec_point_at)
 193         (tui_source_window_base::set_is_exec_point_at)
 194         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 195         (tui_alloc_source_buffer, tui_line_is_displayed)
 196         (tui_addr_is_displayed): Change type of win_info.  Update.
 197         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 198         (tui_source_window_base::do_make_visible_with_new_height):
 199         Update.
 200         * tui/tui-source.c (tui_set_source_content)
 201         (tui_set_source_content_nil)
 202         (tui_source_window::do_scroll_vertical): Update.
 203         * tui/tui-layout.c (show_layout): Update.
 204         * tui/tui-disasm.c (tui_set_disassem_content)
 205         (tui_disasm_window::do_scroll_vertical): Update.
 206         * tui/tui-data.h (tui_win_content): Remove.
 207         (struct tui_gen_win_info) <content, content_size>: Remove.
 208         (struct tui_source_element): Add initializers and destructor.
 209         (union tui_which_element, struct tui_win_element): Remove.
 210         (struct tui_source_window_base) <content>: New field.
 211         (struct tui_data_window): Remove destructor.
 212         (tui_alloc_content, tui_free_win_content)
 213         (tui_free_all_source_wins_content): Don't declare.
 214         * tui/tui-data.c (tui_initialize_static_data): Update.
 215         (init_content_element, tui_alloc_content): Remove.
 216         (~tui_gen_win_info): Update.
 217         (~tui_data_window, tui_free_all_source_wins_content)
 218         (tui_free_win_content, free_content, free_content_elements):
 219         Remove.
 220
 221 2019-06-25  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-winsource.h (tui_clear_source_content)
 224         (tui_erase_source_content, tui_show_source_content): Change type
 225         of win_info.
 226         * tui/tui-winsource.c (tui_clear_source_content)
 227         (tui_erase_source_content, tui_show_source_content): Change type
 228         of win_info.
 229         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 230         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 231         win_info.
 232         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 233         win_info.
 234         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 235
 236 2019-06-25  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-winsource.c (tui_clear_source_content)
 239         (tui_source_window_base::set_is_exec_point_at): Update.
 240         * tui/tui-source.c (tui_set_source_content_nil): Update.
 241         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 242         a bool.
 243         * tui/tui-data.c (init_content_element): Update.
 244
 245 2019-06-25  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 248         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 249         * tui/tui-layout.c (init_and_make_win): Update.
 250         * tui/tui.h (enum tui_win_type): Update.
 251         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 252         tui_win_is_auxillary.
 253         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 254         tui_win_is_auxillary.
 255
 256 2019-06-25  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 259         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 260         (tui_delete_data_content_windows, tui_display_all_data)
 261         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 262         Update.
 263         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 264         * tui/tui-regs.c (tui_last_regs_line_no)
 265         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 266         (tui_show_registers): Update.
 267         (tui_show_register_group): Return void.  Update.
 268         (tui_display_registers_from, tui_display_reg_element_at_line)
 269         (tui_display_registers_from_line, tui_check_register_values):
 270         Update.
 271         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 272         member.
 273         (struct tui_data_window) <regs_content>: Now a std::vector.
 274         <regs_content_count>: Remove.
 275         (tui_add_content_elements, tui_free_data_content): Don't declare.
 276         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 277         (init_content_element): Remove DATA_WIN case.  Add assert.
 278         (tui_add_content_elements): Remove.
 279         (tui_data_window): Update.
 280         (tui_free_data_content): Remove.
 281         (free_content_elements): Remove DATA_WIN case.
 282
 283 2019-06-25  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-data.c (tui_data_item_window): Update.
 286         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 287         * tui/tui-windata.c (tui_display_all_data)
 288         (tui_display_data_from_line): Update.
 289         (tui_check_data_values): Remove.
 290         * tui/tui-regs.c (tui_show_register_group)
 291         (tui_display_reg_element_at_line): Update.
 292         * tui/tui-hooks.c (tui_register_changed)
 293         (tui_refresh_frame_and_register_information): Call
 294         tui_check_register_values.
 295         * tui/tui-data.h (struct tui_data_window) <data_content,
 296         data_content_count, data_type>: Remove.
 297         (enum tui_data_type): Remove.
 298
 299         * tui/tui-data.c (tui_data_window::clear_detail)
 300         (~tui_data_window): Update.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 305         declare.
 306         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 307         Rename from tui_first_data_item_displayed.  Update.
 308         (tui_data_window::refresh_all)
 309         (tui_data_window::do_scroll_vertical): Update.
 310         * tui/tui-data.h (struct tui_data_window)
 311         <first_data_item_displayed>: Declare new method.
 312
 313 2019-06-25  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 316         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 317         contents...
 318         (tui_initialize_static_data): ...here.
 319
 320 2019-06-25  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 323         (tui_display_registers_from, tui_check_register_values): Update.
 324         (tui_display_register): Remove win_info parameter; update.
 325         (tui_get_register): Change type of parameters.
 326         * tui/tui-data.h (struct tui_data_element): Remove.
 327         (union tui_which_element) <data>: Remove.
 328         <data_window>: Change type.
 329         (struct tui_data_item_window): New.
 330         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 331         case.  Add assert.
 332         (~tui_data_item_window): New destructor.
 333         (free_content_elements): Remove DATA_ITEM_WIN case.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 338         Remove.
 339
 340 2019-06-25  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-data.h (struct tui_command_element): Remove.
 343         (union tui_which_element) <command>: Remove.
 344         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 345         assert.
 346         (free_content_elements): Remove CMD_WIN case.
 347
 348 2019-06-25  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-layout.c (tui_set_layout): Update.
 351         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 352         * tui/tui-data.c (layout_def): Update.
 353
 354 2019-06-25  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 357         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 358         (tui_source_window_base::set_new_height): Update.
 359         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 360         Update.
 361         (tui_set_locator_fullname, tui_set_locator_info)
 362         (tui_show_frame_info): Update.
 363         * tui/tui-source.c (tui_set_source_content)
 364         (tui_source_is_displayed): Update.
 365         * tui/tui-layout.c (show_source_disasm_command, show_data)
 366         (show_source_or_disasm_and_command): Update.
 367         * tui/tui-disasm.c (tui_set_disassem_content)
 368         (tui_get_begin_asm_address): Update.
 369         * tui/tui-data.h (struct tui_locator_element): Remove.
 370         (union tui_which_element) <locator>: Remove.
 371         (struct tui_locator_window): New.
 372         (tui_locator_win_info_ptr): Change return type.
 373         * tui/tui-data.c (_locator): Change type.
 374         (tui_locator_win_info_ptr): Change return type.
 375         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 376         (tui_alloc_content): Add assert.
 377
 378 2019-06-25  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-winsource.c
 381         (tui_exec_info_window::maybe_allocate_content): New method.
 382         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 383         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 384         (make_source_or_disasm_window): Add cast.
 385         * tui/tui-data.h (union tui_which_element) <simple_string>:
 386         Remove.
 387         (struct tui_source_info): New.
 388         (struct tui_source_window_base) <execution_info>: Change type.
 389         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 390         case, and add assert.
 391         (tui_alloc_content): Add assert.
 392
 393 2019-06-25  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 396         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 397         * tui/tui-data.c (tui_alloc_win_info): Remove.
 398
 399 2019-06-25  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 402         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 403         can_highlight.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 408         make_visible_with_new_height method.
 409         (tui_win_info::make_visible_with_new_height): New method.
 410         (tui_source_window_base::do_make_visible_with_new_height)
 411         (tui_data_window::do_make_visible_with_new_height)
 412         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 413         (make_visible_with_new_height): Remove.
 414         (tui_resize_all, tui_adjust_win_heights): Use
 415         make_visible_with_new_height method.
 416         * tui/tui-data.h (struct tui_win_info)
 417         <do_make_visible_with_new_height, make_visible_with_new_height>:
 418         New methods.
 419         (struct tui_source_window_base, struct tui_data_window)
 420         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 421         methods.
 422
 423 2019-06-25  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 426         method.
 427         (update_tab_width): Call update_tab_width method.
 428         * tui/tui-data.h (struct tui_win_info)
 429         (struct tui_source_window_base) <update_tab_width>: New methods.
 430
 431 2019-06-25  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 434         parameter.
 435         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 436         parameter.
 437         (tui_gen_win_info::make_visible): Update.
 438         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 439         parameter.
 440         * tui/tui-data.h (enum tui_box): New enum.
 441         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 442
 443 2019-06-25  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 446         init_and_make_win for EXEC_INFO_WIN.
 447         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 448         longer inline.
 449         (struct tui_win_info) <~tui_win_info>: Inline.
 450         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 451         Don't declare.
 452         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 453         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 454         Remove.
 455         (tui_initialize_static_data): Update.
 456         (~tui_gen_win_info): Handle more cleanup here.
 457         (~tui_source_window_base): Delete "execution_info".
 458         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 459
 460 2019-06-25  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-layout.c (make_command_window): Don't set
 463         can_highlight.
 464         (show_source_disasm_command): Call the reset method.
 465         (show_data): Don't set can_highlight.  Call the reset method.
 466         (tui_gen_win_info::reset): Rename from init_gen_win_info
 467         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 468         (show_source_or_disasm_and_command): Call the reset method.
 469         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 470         (struct tui_cmd_window): Set can_highlight.
 471
 472 2019-06-25  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 475         from make_visible.
 476         (tui_make_visible, tui_make_invisible): Rewrite.
 477         (tui_win_info::make_visible): Remove.
 478         (tui_source_window_base::make_visible): Update.
 479         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 480         method.  Moved from...
 481         (struct tui_win_info) <make_visible>: ...here.
 482
 483 2019-06-25  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-winsource.c
 486         (tui_source_window_base::do_scroll_horizontal): Remove direction
 487         parameter.
 488         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 489         direction parameter.
 490         * tui/tui-win.c (tui_win_info::forward_scroll)
 491         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 492         (tui_win_info::right_scroll): Update.
 493         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 494         direction parameter.
 495         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 496         direction parameter.
 497         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 498         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 499         Remove direction parameter.
 500         (struct tui_source_window_base, struct tui_source_window)
 501         (struct tui_disasm_window, struct tui_data_window)
 502         (struct tui_cmd_window): Update.
 503
 504 2019-06-25  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.h (tui_set_exec_info_content)
 507         (tui_show_exec_info_content, tui_erase_exec_info_content)
 508         (tui_clear_exec_info_content, tui_update_exec_info): Change
 509         argument to tui_source_window_base.
 510         * tui/tui-winsource.c (tui_set_exec_info_content)
 511         (tui_show_exec_info_content, tui_erase_exec_info_content)
 512         (tui_clear_exec_info_content, tui_update_exec_info): Change
 513         argument to tui_source_window_base.
 514
 515 2019-06-25  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 518         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 519
 520 2019-06-25  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 523         check.
 524
 525 2019-06-25  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 528         type to void.
 529         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 530         type to void.
 531         * tui/tui-source.c (tui_set_source_content): Update.
 532         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 533
 534 2019-06-25  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-win.c (window_name_completer, tui_set_focus)
 537         (tui_all_windows_info): Use name method.
 538         * tui/tui-data.h (struct tui_gen_win_info)
 539         (struct tui_source_window, struct tui_disasm_window)
 540         (struct tui_data_window, struct tui_cmd_window) <name>: New
 541         method.
 542         (tui_win_name): Don't declare.
 543         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 544         (tui_win_name): Remove.
 545
 546 2019-06-25  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-winsource.h (tui_update_source_window)
 549         (tui_update_source_window_as_is): Change parameter type.
 550         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 551         to be a tui_source_window_base.
 552         (tui_update_source_window_as_is): Likewise.
 553         * tui/tui-win.c (make_visible_with_new_height): Update.
 554
 555 2019-06-25  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-winsource.c (tui_erase_source_content)
 558         (tui_show_source_content, tui_show_exec_info_content)
 559         (tui_erase_exec_info_content): Use refresh_window method.
 560         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 561         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 562         from tui_refresh_win.
 563         (tui_data_window::refresh_window): New method.
 564         (tui_win_info::refresh, tui_source_window_base::refresh)
 565         (tui_refresh_all): Use refresh_window method.
 566         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 567         method.
 568         * tui/tui-regs.c (tui_display_register): Call refresh_window
 569         method.
 570         * tui/tui-layout.c (show_source_disasm_command)
 571         (show_source_or_disasm_and_command): Call refresh_window method.
 572         * tui/tui-data.h (struct tui_gen_win_info)
 573         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 574         New method.
 575
 576 2019-06-25  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui.c (tui_rl_other_window, tui_enable)
 579         (tui_is_window_visible, tui_get_command_dimension): Update.
 580         * tui/tui-winsource.c (tui_update_source_window_as_is)
 581         (tui_clear_source_content, tui_erase_source_content)
 582         (tui_show_source_line, tui_source_window_base::refill)
 583         (tui_source_window_base::do_scroll_horizontal)
 584         (tui_source_window_base::set_is_exec_point_at)
 585         (tui_update_breakpoint_info, tui_set_exec_info_content)
 586         (tui_alloc_source_buffer, tui_line_is_displayed)
 587         (tui_addr_is_displayed): Update.
 588         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 589         (tui_check_and_display_highlight_if_needed)
 590         (tui_win_info::make_visible, tui_win_info::refresh)
 591         (tui_refresh_all): Update.
 592         * tui/tui-windata.c (tui_first_data_item_displayed)
 593         (tui_delete_data_content_windows, tui_erase_data_content)
 594         (tui_display_all_data, tui_data_window::refresh_all)
 595         (tui_check_data_values): Update.
 596         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 597         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 598         (tui_win_info::backward_scroll, tui_refresh_all_win)
 599         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 600         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 601         (tui_source_window_base::set_new_height)
 602         (tui_data_window::set_new_height)
 603         (make_invisible_and_set_new_height)
 604         (make_visible_with_new_height, new_height_ok)
 605         (parse_scrolling_args): Update.
 606         * tui/tui-stack.c (tui_show_frame_info): Update.
 607         * tui/tui-source.c (tui_set_source_content)
 608         (tui_set_source_content_nil, tui_source_is_displayed)
 609         (tui_source_window::do_scroll_vertical): Update.
 610         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 611         (tui_display_registers_from, tui_display_reg_element_at_line)
 612         (tui_check_register_values, tui_reg_command): Update.
 613         * tui/tui-layout.c (tui_default_win_height)
 614         (show_source_disasm_command, show_data, init_and_make_win)
 615         (show_source_or_disasm_and_command): Update.
 616         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 617         (tui_redisplay_readline, tui_mld_flush)
 618         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 619         (tui_getc): Update.
 620         * tui/tui-disasm.c (tui_set_disassem_content)
 621         (tui_disasm_window::do_scroll_vertical): Update.
 622         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 623         Now virtual.
 624         (struct tui_win_info): Derive from tui_gen_win_info.
 625         <~tui_win_info>: Mark as override.
 626         <generic>: Remove member.
 627         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 628         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 629         (~tui_data_window, ~tui_win_info)
 630         (tui_free_all_source_wins_content): Update.
 631         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 632
 633 2019-06-25  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-layout.c (init_and_make_win): Use new.
 636         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 637         destructor, initializers.
 638         (tui_alloc_generic_win_info): Don't declare.
 639         * tui/tui-data.c (_locator): Add argument to constructor.
 640         (source_win, disasm_win): New globals.
 641         (exec_info): Remove.
 642         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 643         Update.
 644         (tui_alloc_generic_win_info): Remove.
 645         (init_content_element): Use new.
 646         (tui_win_info::tui_win_info): Update.
 647         (free_content_elements) <case DATA_WIN>: Use delete.
 648
 649 2019-06-25  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 652         * tui/tui-windata.c (tui_first_data_item_displayed)
 653         (tui_delete_data_content_windows): Update.
 654         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 655         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 656         (tui_display_registers_from, tui_check_register_values): Update.
 657         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 658         pointer.
 659         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 660         window.
 661         (tui_free_data_content): Update.
 662         (free_content_elements) <case DATA_WIN>: Free the window.
 663
 664 2019-06-25  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 667         Update.
 668         * tui/tui-layout.c (make_command_window)
 669         (show_source_disasm_command, show_data, init_and_make_win)
 670         (show_source_or_disasm_and_command): Update.
 671         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 672         method.
 673         <can_highight, is_highlighted>: Now bool.
 674         (tui_set_win_highlight): Don't declare.
 675         * tui/tui-data.c (tui_set_win_highlight): Remove.
 676
 677 2019-06-25  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-wingeneral.c (make_visible): Remove check of window
 680         type.
 681
 682 2019-06-25  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-win.c (tui_win_info::max_height)
 685         (tui_cmd_window::max_height): New methods.
 686         (new_height_ok): Call max_height.
 687         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 688         <max_height>: New method.
 689
 690 2019-06-25  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-win.c (tui_source_window_base::set_new_height)
 693         (tui_data_window::set_new_height): New methods.
 694         (make_invisible_and_set_new_height): Call set_new_height method.
 695         * tui/tui-data.h (struct tui_win_info)
 696         (struct tui_source_window_base, struct tui_data_window)
 697         <set_new_height>: New method.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 702         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 703         tui_refresh_data_win.
 704         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 705         method.
 706         (tui_refresh_all_win): Call the refresh_all method.
 707         (tui_set_focus): Likewise.
 708         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 709         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 710         Likewise.
 711
 712 2019-06-25  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-winsource.h (tui_refill_source_window)
 715         (tui_set_is_exec_point_at): Don't declare.
 716         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 717         (tui_source_window_base::refill): Rename from
 718         tui_refill_source_window.
 719         (tui_source_window_base::do_scroll_horizontal): Update.
 720         (tui_source_window_base::set_is_exec_point_at): Rename from
 721         tui_set_is_exec_point_at.
 722         (tui_update_all_breakpoint_info): Update.
 723         * tui/tui-stack.c (tui_show_frame_info): Update.
 724         * tui/tui-layout.c (show_data): Add cast.
 725         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 726         * tui/tui-data.h (struct tui_source_window_base) <refill,
 727         set_is_exec_point_at>: New methods.
 728         (tui_source_windows, tui_add_to_source_windows): Update types.
 729         (tui_add_to_source_windows): Remove redundant declaration.
 730         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 731         (tui_source_windows): Change return type.
 732         (tui_clear_source_windows_detail): Update.
 733         (tui_add_to_source_windows): Change type of parameter.
 734         (tui_free_all_source_wins_content): Update.
 735
 736 2019-06-25  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-wingeneral.c (tui_win_info::refresh)
 739         (tui_source_window_base::refresh): New methods.
 740         (tui_refresh_all): Call the refresh method.
 741         * tui/tui-data.h (struct tui_win_info)
 742         (struct tui_source_window_base) <refresh>: New method.
 743
 744 2019-06-25  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui.h (tui_is_window_visible): Return bool.
 747         * tui/tui.c (tui_is_window_visible): Return bool.
 748         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 749         (tui_make_visible, tui_make_invisible)
 750         (tui_win_info::make_visible)
 751         (tui_source_window_base::make_visible, make_all_visible)
 752         (tui_make_all_visible, tui_make_all_invisible): Update.
 753         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 754         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 755         bool.
 756         (struct tui_win_info, struct tui_source_window_base)
 757         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 758         * tui/tui-data.c (tui_init_generic_part): Update.
 759
 760 2019-06-25  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 763         (tui_source_window_base::make_visible): New methods.
 764         (make_all_visible): Make method call.
 765         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 766         (struct tui_source_window_base, struct tui_cmd_window): Override
 767         make_visible.
 768         (tui_win_is_source_type): Don't declare.
 769         * tui/tui-data.c (tui_win_is_source_type): Remove.
 770
 771 2019-06-25  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 774         NULL check.
 775
 776 2019-06-25  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 779         Inline constructor.  Add initializers for members.
 780         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 781         constructors; now inline in class.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-regs.c (tui_show_registers): Update.
 786         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 787         bool.
 788         * tui/tui-data.c (tui_data_window::clear_detail)
 789         (tui_data_window): Update.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-windata.c (tui_display_all_data)
 794         (tui_display_data_from_line, tui_display_data_from)
 795         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 796         Update.
 797         * tui/tui-regs.c (tui_last_regs_line_no)
 798         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 799         (tui_show_registers, tui_show_register_group)
 800         (tui_display_registers_from, tui_display_reg_element_at_line)
 801         (tui_display_registers_from_line, tui_check_register_values)
 802         (tui_reg_next, tui_reg_prev): Update.
 803         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 804         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 805         tui_data_window.
 806         (struct tui_win_info) <detail>: Remove.  Add new fields from
 807         tui_data_info.
 808         (TUI_DATA_WIN): Add cast.
 809         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 810         (~tui_data_window): Simplify.
 811
 812 2019-06-25  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-layout.c (show_source_disasm_command)
 815         (show_source_or_disasm_and_command): Update.
 816         * tui/tui-io.c (update_cmdwin_start_line)
 817         (tui_redisplay_readline): Update.
 818         * tui/tui-data.h (struct tui_command_info): Remove.
 819         (struct tui_win_info) <detail>: Remove command_info member.
 820         (struct tui_data_window) <start_line>: New member, from
 821         tui_command_info.
 822         (TUI_CMD_WIN): Add casts.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-winsource.c (tui_update_source_window)
 827         (tui_refill_source_window)
 828         (tui_source_window_base::do_scroll_horizontal)
 829         (tui_update_breakpoint_info, tui_set_exec_info_content)
 830         (tui_show_exec_info_content, tui_erase_exec_info_content)
 831         (tui_clear_exec_info_content): Update.
 832         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 833         Update.
 834         * tui/tui-win.c (make_invisible_and_set_new_height)
 835         (make_visible_with_new_height): Update.
 836         * tui/tui-source.c (tui_set_source_content)
 837         (tui_show_symtab_source): Update.
 838         * tui/tui-layout.c (extract_display_start_addr)
 839         (show_source_disasm_command, show_data)
 840         (make_source_or_disasm_window)
 841         (show_source_or_disasm_and_command): Update.
 842         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 843         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 844         "gdbarch".
 845         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 846         to tui_source_window_base.
 847         (struct tui_win_info) <detail>: Remove source_info member.
 848         (struct tui_source_window_base) <has_locator>: Inline.
 849         Move contents from tui_source_info; rename has_locator member to
 850         m_has_locator.
 851         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 852         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 853         header file.
 854         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 855         Simplify.
 856         (tui_free_all_source_wins_content): Cast to
 857         tui_source_window_base.
 858
 859 2019-06-25  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-win.c (make_invisible_and_set_new_height)
 862         (make_visible_with_new_height): Call has_locator method.
 863         * tui/tui-layout.c (show_source_disasm_command, show_data)
 864         (show_source_or_disasm_and_command): Update for bool change.
 865         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 866         (tui_win_info) <has_locator>: New method.
 867         (struct tui_source_window_base) <has_locator>: New method.
 868         (tui_win_has_locator): Don't declare.
 869         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 870         from tui_win_has_locator.
 871         (tui_source_window_base): Use false, not FALSE.
 872
 873 2019-06-25  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 876         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 877         clear_detail method directly.
 878         (tui_clear_win_detail): Remove.
 879
 880 2019-06-25  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 883         "this", not TUI_DISASM_WIN.
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 888         declare.
 889         * tui/tui-winsource.c
 890         (tui_source_window_base::do_scroll_horizontal): Rename from
 891         tui_horizontal_source_scroll.
 892         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 893         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 894         from tui_vertical_data_scroll.
 895         * tui/tui-win.h (tui_scroll): Don't declare.
 896         * tui/tui-win.c (tui_win_info::forward_scroll)
 897         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 898         (tui_win_info::right_scroll): Rename and update.
 899         (tui_scroll_forward_command, tui_scroll_backward_command)
 900         (tui_scroll_left_command, tui_scroll_right_command): Update.
 901         (tui_scroll): Remove.
 902         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 903         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 904         from tui_vertical_source_scroll.
 905         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 906         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 907         from tui_vertical_disassem_scroll.
 908         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 909         do_scroll_horizontal>: New methods.
 910         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 911         Likewise.
 912         (struct tui_source_window_base): Add do_scroll_horizontal.
 913         (struct tui_source_window, struct tui_disasm_window): Add
 914         do_scroll_vertical.
 915         (struct tui_data_window, struct tui_cmd_window): Add
 916         do_scroll_horizontal and do_scroll_vertical.
 917         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-data.h (struct tui_source_window_base): New struct.
 922         (struct tui_source_window): Derive from tui_source_window_base.
 923         (struct tui_disasm_window): New struct.
 924         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 925         from tui_source_window::clear_detail.
 926         (tui_source_window_base): Rename from tui_source_window.
 927         (~tui_source_window_base): Rename from ~tui_source_window.
 928         (tui_alloc_win_info): Create a tui_disasm_window.
 929
 930 2019-06-25  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-data.h (struct tui_source_window)
 933         (struct tui_data_window): Declare destructors.
 934         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 935         destructors.
 936         (tui_win_info): Simplify.
 937
 938 2019-06-25  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-winsource.c (tui_display_main)
 941         (tui_update_source_windows_with_addr)
 942         (tui_update_all_breakpoint_info): Update.
 943         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 944         (new_height_ok, parse_scrolling_args): Update.
 945         * tui/tui-stack.c (tui_show_frame_info): Update.
 946         * tui/tui-data.h (struct tui_list): Remove.
 947         (tui_source_windows): Return a reference to a std::vector.
 948         * tui/tui-data.c (source_windows): Now a std::vector.
 949         (tui_source_windows): Change return type.
 950         (tui_clear_source_windows): Rewrite.
 951         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 952         (tui_free_all_source_wins_content): Rewrite.
 953
 954 2019-06-25  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 957         (struct tui_data_window, struct tui_cmd_window): Declare
 958         clear_detail method.
 959         * tui/tui-data.c (tui_source_window::clear_detail)
 960         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 961         methods.
 962         (tui_clear_win_detail): Simplify.
 963
 964 2019-06-25  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-layout.c (make_source_window, make_disasm_window)
 967         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 968         Return the new window.
 969         (show_source_disasm_command, show_data)
 970         (show_source_or_disasm_and_command): Update.
 971
 972 2019-06-25  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 975         parameter.  Return the new window.
 976         (show_source_disasm_command): Update and remove NULL check.
 977         (show_source_or_disasm_and_command): Update.
 978
 979 2019-06-25  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 982
 983 2019-06-25  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-data.h (struct tui_win_info): Make constructor
 986         protected.  Make destructor virtual.  Add initializers.
 987         (tui_source_window, tui_data_window, tui_cmd_window): New
 988         classes.
 989         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 990         constructor.  Add "type" parameter.
 991         (tui_source_window, tui_data_window, tui_cmd_window): New
 992         constructors.
 993         (tui_alloc_win_info): Instantiate the appropriate subclass.
 994
 995 2019-06-25  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-win.c (tui_resize_all): Use delete.
 998         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 999         destructor.
1000         (tui_free_window): Don't declare.
1001         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1002         Update.
1003
1004 2019-06-25  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-data.h (struct tui_win_info): Add constructor.
1007         * tui/tui-data.c (tui_alloc_win_info): Use new.
1008         (tui_free_window): Use delete.
1009
1010 2019-06-22  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1013         declare.
1014         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1015
1016 2019-06-22  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1019         declare.
1020         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1021
1022 2019-06-22  Tom de Vries  <tdevries@suse.de>
1023
1024         * dwarf2read.c (create_addrmap_from_aranges)
1025         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1026         instead of '%zu'.
1027
1028 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1029
1030         * dwarf2read.h (dwarf2_section_info_def): Remove.
1031         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1032         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1033         std::vector<dwarf2_section_info>.
1034         (struct dwo_file) <~dwo_file>: Remove.
1035         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1036         types field.
1037         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1038         (dwarf2_read_debug_names): Likewise.
1039         (create_debug_types_hash_table): Change parameter type to
1040         array_view, adjust code accordingly.
1041         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1042         (partial_die_info::fixup): Likewise.
1043         (determine_prefix): Likewise.
1044         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1045
1046 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1047
1048         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1049         gdb_bfd_ref_ptr.
1050         <~dwo_file>: Remove call to gdb_bfd_unref.
1051         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1052         gdb_bfd_ref_ptr::get.
1053
1054 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1055
1056         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1057         type to htab_up.
1058         * dwarf2read.c (struct dwo_file): Initialize fields.
1059         <~dwo_file>: New.
1060         (free_dwo_file): Remove, move content to ~dwo_file.
1061         (struct dwo_file_deleter): Remove.
1062         (dwo_file_up>: Remove custom deleter.
1063         (free_dwo_files): Remove.
1064         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1065         dwo_files.
1066         (process_skeletonless_type_units): Call unique_ptr::get.
1067         (allocate_dwo_file_hash_table): Add deleter to created hash
1068         table.  Change return type to htab_up.
1069         (lookup_dwo_file_slot): Don't memset dwo_file, call
1070         unique_ptr::get.
1071         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1072         (create_dwo_unit_in_dwp_v2): Likewise.
1073         (open_and_init_dwo_file): Likewise.
1074         (free_dwo_file_from_slot): Remove.
1075
1076 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1077
1078         * dwarf2read.h (struct dwarf2_section_info) <readin,
1079         is_virtual>: Change type to bool.
1080         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1081         true instead of 1.
1082
1083 2019-06-19  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-data.h (tui_init_content_element): Don't declare.
1086
1087 2019-06-19  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-data.h (tui_init_win_info): Don't declare.
1090
1091 2019-06-19  Tom de Vries  <tdevries@suse.de>
1092
1093         * dwarf2read.h (abstract_to_concrete): Change type to
1094         std::unordered_map<sect_offset, std::vector<sect_offset>,
1095         gdb::hash_enum<sect_offset>>.
1096
1097 2019-06-19  Tom Tromey  <tromey@adacore.com>
1098
1099         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1100         EVAL_AVOID_SIDE_EFFECTS specially.
1101
1102 2019-06-19  Tom Tromey  <tromey@adacore.com>
1103
1104         * source-cache.c (highlighter): New global.
1105         (source_cache::get_source_lines): Create a highlighter on demand.
1106
1107 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * defs.h (deprecated_interactive_hook): Delete declaration.
1110         * interps.c (clear_interpreter_hooks): Remove use of
1111         deprecated_interactive_hook.
1112         * top.c (deprecated_interactive_hook): Delete definition.
1113         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1114
1115 2019-06-18  Tom de Vries  <tdevries@suse.de>
1116
1117         PR gdb/24515
1118         * dwarf2read.h (abstract_to_concrete): Change type from
1119         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1120         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1121         * dwarf2read.c (read_variable): Update.
1122         (dwarf2_fetch_die_loc_sect_off): Update.
1123
1124 2019-06-17  Tom de Vries  <tdevries@suse.de>
1125
1126         PR gdb/24617
1127         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1128         accessing parent[parent_len - 1].
1129
1130 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1131
1132         PR gdb/24364
1133         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1134         call dtrace_process_dof with NULL dof.
1135
1136 2019-06-16  Tom de Vries  <tdevries@suse.de>
1137
1138         PR gdb/24445
1139         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1140
1141 2019-06-16  Tom Tromey  <tom@tromey.com>
1142
1143         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1144         (make_all_visible): Use address of member.
1145
1146 2019-06-16  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1149         (tui_free_window, free_content, free_content_elements): Remove
1150         unnecessary cast.
1151         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1152         cast.
1153         * tui/tui-regs.c (tui_show_register_group)
1154         (tui_display_registers_from, tui_display_reg_element_at_line):
1155         Remove unnecessary cast.
1156
1157 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * linux-nat.c (normal_mask): Delete.
1160         (_initialize_linux_nat): Don't initialise normal_mask.
1161
1162 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1163
1164         PR gdb/24445
1165         * dwarf-index-write.h (write_psymtabs_to_index): Add
1166         dwz_basename parameter.
1167         * dwarf-index-write.c (write_gdbindex): Move file writing to
1168         write_gdbindex_1.  Change return type void.
1169         (assert_file_size): Move up, remove filename parameter.
1170         (write_gdbindex_1): New function.
1171         (write_debug_names): Change return type to void, call
1172         assert_file_size.
1173         (struct index_wip_file): New struct.
1174         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1175         file logic to index_wip_file.  Write index for dwz file if
1176         needed.
1177         (save_gdb_index_command): Pass basename of dwz file, if present.
1178         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1179         build-id of dwz file, if present.
1180         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1181         (dwarf2_get_dwz_file): Likewise.
1182         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1183         (dwarf2_get_dwz_file): Likewise.
1184
1185 2019-06-16  Tom Tromey  <tom@tromey.com>
1186
1187         * coffread.c (process_coff_symbol): Use xstrdup.
1188         * value.c (create_internalvar): Use xstrdup.
1189
1190 2019-06-16  Tom Tromey  <tom@tromey.com>
1191
1192         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1193         * breakpoint.c (stopin_command, stopat_command)
1194         (until_break_command, decode_location_default): Remove unnecessary
1195         cast.
1196         * utils.c (subset_compare): Remove unnecessary cast.
1197         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1198         cast.
1199         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1200         cast.
1201         * infcmd.c (path_command): Remove unnecessary cast.
1202         * coffread.c (decode_type): Remove unnecessary cast.
1203         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1204         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1205         * tui/tui-stack.c (tui_show_locator_content)
1206         (tui_show_frame_info): Remove unnecessary cast.
1207         * tui/tui-win.c (tui_scroll_forward_command)
1208         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1209         (parse_scrolling_args): Remove unnecessary cast.
1210         * tui/tui-data.c (init_win_info, tui_del_window)
1211         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1212         (free_content_elements): Remove unnecessary cast.
1213         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1214         unnecessary cast.
1215         * tui/tui-source.c (tui_set_source_content)
1216         (tui_vertical_source_scroll): Remove unnecessary cast.
1217         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1218         cast.
1219         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1220         * tui/tui-regs.c (tui_display_registers_from)
1221         (tui_display_register): Remove unnecessary cast.
1222         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1223         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1224         (make_visible): Remove unnecessary cast.
1225         * tui/tui-winsource.c (tui_erase_source_content)
1226         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1227         unnecessary cast.
1228         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1229         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1230         * stabsread.c (read_type, read_array_type, read_range_type):
1231         Remove unnecessary cast.
1232         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1233         (parse_symbol, parse_type, upgrade_type, parse_external)
1234         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1235         unnecessary cast.
1236         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1237
1238 2019-06-16  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-data.c (tui_alloc_generic_win_info)
1241         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1242         checks.
1243
1244 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1245             Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * f-typeprint.c (f_print_type): Don't return early for not
1248         associated or not allocated types.
1249         (f_type_print_varspec_suffix): Add print_rank parameter and print
1250         ranks of array types in case they dangling.
1251         (f_type_print_base): Add print_rank parameter.
1252
1253 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * NEWS: Mention new MI commands.
1256         * break-catch-throw.c (enum exception_event_kind): Move to
1257         breakpoint.h.
1258         (print_mention_exception_catchpoint): Output text as a single
1259         message.
1260         (catch_exception_command_1): Rename to...
1261         (catch_exception_event): ...this, make non-static, update header
1262         command, and change some parameter types.
1263         (catch_catch_command): Update for changes to
1264         catch_exception_command_1.
1265         (catch_throw_command): Likewise.
1266         (catch_rethrow_command): Likewise.
1267         * breakpoint.c (enum exception_event_kind): Delete.
1268         * breakpoint.h (enum exception_event_kind): Moved here from
1269         break-catch-throw.c.
1270         (catch_exception_event): Declare.
1271         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1272         (mi_cmd_catch_throw): New function.
1273         (mi_cmd_catch_rethrow): New function.
1274         (mi_cmd_catch_catch): New function.
1275         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1276         'catch-catch' entries.
1277         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1278         (mi_cmd_catch_rethrow): Declare.
1279         (mi_cmd_catch_catch): Declare.
1280
1281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * annotate.c (annotate_source_line): Change return type to void,
1284         update implementation to match.
1285         * annotate.h (annotate_source_line): Change return type to void,
1286         update header comment.
1287         * stack.c (print_frame_info): Don't change what frame information
1288         is printed based on whether annotations are on or not.
1289
1290 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1293         (annotate_source): Make static.
1294         (annotate_source_line): Moved from source.c and renamed from
1295         identify_source_line.  Update the return type.
1296         * annotate.h (annotate_source): Delete declaration.
1297         (annotate_source_line): Declaration moved from source.h, and
1298         renamed from identify_source_line.  Return type updated.
1299         * source.c (identify_source_line): Moved to annotate.c and renamed
1300         to annotate_source_line.
1301         (info_line_command): Remove check of annotation_level.
1302         * source.h (identify_source_line): Move declaration to annotate.h
1303         and rename to annotate_source_line.
1304         * stack.c: Add 'annotate.h' include.
1305         (print_frame_info): Remove check of annotation_level before
1306         calling annotate_source_line.
1307
1308 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * source-cache.c (source_cache::get_plain_source_lines): Use
1311         open_source_file_with_line_charpos instead of just
1312         open_source_file, remove call to find_source_lines.
1313         (source_cache::get_source_lines): Likewise.
1314         * source.c (find_source_lines): Make static.
1315         (get_filename_and_charpos): Renamed into...
1316         (open_source_file_with_line_charpos): ..this along with changes to
1317         return a scoped_fd, and some other minor clean ups.
1318         (identify_source_line): Use open_source_file_with_line_charpos.
1319         (search_command_helper): Use open_source_file_with_line_charpos
1320         instead of just open_source_file, remove call to
1321         find_source_lines.
1322         * source.h (open_source_file_with_line_charpos): Declare new
1323         function.
1324         (find_source_lines): Delete declaration.
1325
1326 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * source.c (get_filename_and_charpos): Remove fullname
1329         parameter.
1330         (identify_source_line): Update call to get_filename_and_charpos.
1331
1332 2019-06-14  Tom Tromey  <tromey@adacore.com>
1333
1334         PR gdb/24502:
1335         * ui-style.h (skip_ansi_escape): Update comment.
1336         * ui-file.h (class no_terminal_escape_file): New class.
1337         * ui-file.c (no_terminal_escape_file::write)
1338         (no_terminal_escape_file::puts): New methods.
1339         * cli/cli-logging.c (handle_redirections): Use
1340         no_terminal_escape_file.
1341
1342 2019-06-14  Tom Tromey  <tromey@adacore.com>
1343
1344         * NEWS: Move convenience variable news above Python news.
1345
1346 2019-06-14  Tom Tromey  <tom@tromey.com>
1347
1348         * gnulib: Move directory to top-level.
1349         * configure.ac: Don't configure gnulib.
1350         * configure: Rebuild.
1351         * common/common-defs.h: Use new path to gnulib.
1352         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1353         (GNULIB_H): Remove.
1354         (INCGNU): Look in new gnulib location.
1355         (HFILES_NO_SRCDIR): Remove gnulib files.
1356         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1357         (generated_files): Remove GNULIB_H.
1358         ($(LIBGNU), all-lib): Remove targets.
1359         (distclean): Don't mention GNULIB_BUILDDIR.
1360         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1361
1362 2019-06-14  Tom Tromey  <tromey@adacore.com>
1363
1364         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1365         Warn if symbol file does not provide any symbols.
1366
1367 2019-06-14  Tom Tromey  <tromey@adacore.com>
1368
1369         * source.c (find_and_open_source): Respect basenames_may_differ.
1370
1371 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * annotate.c (annotate_breakpoints_invalid): Make use of
1374         scoped_restore_terminal_state.
1375         (annotate_frames_invalid): Likewise.
1376
1377 2019-06-14  Tom Tromey  <tromey@adacore.com>
1378
1379         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1380         allow assignment to an internalvar.
1381
1382 2019-06-14  Tom Tromey  <tromey@adacore.com>
1383
1384         * ada-lex.l: Allow "_" in attribute names.
1385
1386 2019-06-14  Tom Tromey  <tromey@adacore.com>
1387
1388         PR gdb/24653:
1389         * regcache.c (registers_changed): Don't call alloca.
1390         * top.c (execute_command): Don't call alloca.
1391
1392 2019-06-13  Pedro Alves  <palves@redhat.com>
1393
1394         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1395         'expression'.  When parsing an expression, error out if there's
1396         junk after "unlimited".
1397         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1398         (do_set_command): Adjust calls to is_unlimited_literal.
1399
1400 2019-06-13  Pedro Alves  <palves@redhat.com>
1401
1402         * compile/compile.c (make_compile_options_def_group): Add braces
1403         around array_view initializer.
1404         * thread.c (make_thread_apply_all_options_def_group)
1405         (make_thread_apply_all_options_def_group): Likewise.
1406
1407 2019-06-13  Pedro Alves  <palves@redhat.com>
1408
1409         * NEWS (New commands): Mention "maint test-options
1410         require-delimiter", "maint test-options unknown-is-error", "maint
1411         test-options unknown-is-operand" and "maint show
1412         test-options-completion-result".
1413         (New command options, command completion): New section.
1414         (Completion improvements): New section.
1415         Mention that you can abbreviate "unlimited".
1416
1417 2019-06-13  Pedro Alves  <palves@redhat.com>
1418
1419         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1420         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1421         * unittests/cli-utils-selftests.c (test_parse_flags)
1422         (test_parse_flags_qcs): Delete.
1423         (test_cli_utils): Don't call deleted functions.
1424
1425 2019-06-13  Pedro Alves  <palves@redhat.com>
1426
1427         * thread.c: Include "cli/cli-option.h".
1428         (tp_array_compar_ascending): Global.
1429         (tp_array_compar): Delete function.
1430         (tp_array_compar_ascending, tp_array_compar_descending): New
1431         functions.
1432         (ascending_option_def, qcs_flag_option_def)
1433         (thr_qcs_flags_option_defs)
1434         (make_thread_apply_all_options_def_group)
1435         (make_thread_apply_options_def_group): New.
1436         (thread_apply_all_command): Use gdb::option::process_options.
1437         (thread_apply_command_completer)
1438         (thread_apply_all_command_completer): New.
1439         (thread_apply_command): Use gdb::option::process_options.
1440         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1441         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1442         to generate help text of "thread apply".  Adjust "taas"'s help.
1443         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1444         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1445
1446 2019-06-13  Pedro Alves  <palves@redhat.com>
1447
1448         * thread.c (thread_apply_command): Check for invalid TID with
1449         isdigit instead of !isalpha.
1450
1451 2019-06-13  Pedro Alves  <palves@redhat.com>
1452
1453         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1454         (validate_flags_qcs): New.
1455         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1456         (validate_flags_qcs): Declare.
1457         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1458         (make_frame_apply_options_def_group): New.
1459         (frame_apply_command_count): Process options with
1460         gdb::option::process_options.
1461         (frame_apply_completer): New.
1462         (frame_apply_level_completer, frame_apply_all_completer)
1463         (frame_apply_completer): New.
1464         (_initialize_stack): Update help of "frame apply", "frame apply
1465         level", "frame apply all" and "faas" to mention supported options
1466         and install command completers.
1467         * stack.h (frame_apply_all_completer): Declare.
1468         * thread.c: Include "stack.h".
1469         (tfaas_command): Add "--".
1470         (_initialize_thread): Update help "tfaas" to mention supported
1471         options and install command completer.
1472
1473 2019-06-13  Pedro Alves  <palves@redhat.com>
1474
1475         * completer.c (complete_nested_command_line): New.
1476         (gdb_completion_word_break_characters_throw): Add assertion.
1477         * completer.h (complete_nested_command_line): Declare.
1478
1479 2019-06-13  Pedro Alves  <palves@redhat.com>
1480
1481         * stack.c (parse_backtrace_qualifiers): New.
1482         (backtrace_command): Use it.
1483         (backtrace_command_completer): Complete on qualifiers.
1484
1485 2019-06-13  Pedro Alves  <palves@redhat.com>
1486
1487         * frame.c: Include "cli/cli-option.h.
1488         (user_set_backtrace_options): New.
1489         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1490         Delete.
1491         (get_prev_frame): Adjust.
1492         (boolean_option_def, uinteger_option_def)
1493         (set_backtrace_option_defs): New.
1494         (_initialize_frame): Adjust and use
1495         gdb::option::add_setshow_cmds_for_options to install "set
1496         backtrace past-main" and "set backtrace past-entry".
1497         * frame.h: Include "cli/cli-option.h".
1498         (struct frame_print_options): Forward declare.
1499         (print_frame_arguments_all, print_frame_arguments_scalars)
1500         (print_frame_arguments_none): Declare.
1501         (print_entry_values): Delete declaration.
1502         (struct frame_print_options, user_frame_print_options): New.
1503         (struct set_backtrace_options): New.
1504         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1505         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1506         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1507         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1508         (list_args_or_locals): Add frame_print_options parameter.
1509         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1510         * python/py-framefilter.c (enumerate_args): Pass down
1511         USER_FRAME_PRINT_OPTIONS.
1512         * stack.c: Include "cli/cli-option.h".
1513         (print_frame_arguments_all, print_frame_arguments_scalars)
1514         (print_frame_arguments_none): Declare.
1515         (print_raw_frame_arguments, print_entry_values): Delete.
1516         (user_frame_print_options): New.
1517         (boolean_option_def, enum_option_def, frame_print_option_defs):
1518         New.
1519         (struct backtrace_cmd_options): New.
1520         (bt_flag_option_def): New.
1521         (backtrace_command_option_defs): New.
1522         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1523         (print_frame_arg, read_frame_arg, print_frame_args)
1524         (print_frame_info, print_frame): Add frame_print_options parameter
1525         and use it.
1526         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1527         (backtrace_command_1): Add frame_print_options and
1528         backtrace_cmd_options parameters and use them.
1529         (make_backtrace_options_def_group): New.
1530         (backtrace_command): Process command options with
1531         gdb::option::process_options.
1532         (backtrace_command_completer): New.
1533         (_initialize_stack): Extend "backtrace"'s help to mention
1534         supported options.  Install completer for "backtrace".
1535         Install some settings commands with add_setshow_cmds_for_options.
1536
1537 2019-06-13  Pedro Alves  <palves@redhat.com>
1538
1539         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1540         and that "set/show print raw frame-arguments" are now deprecated.
1541
1542         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1543         command.
1544         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1545         * stack.c (_initialize_stack): Install "set/show print
1546         raw-frame-arguments", and deprecate "set/show print raw
1547         frame-arguments".
1548         * valprint.c (_initialize_valprint): Deprecate "set/show print
1549         raw".
1550
1551 2019-06-13  Pedro Alves  <palves@redhat.com>
1552
1553         * compile/compile.c (struct compile_options): New.
1554         (compile_flag_option_def, compile_command_option_defs)
1555         (make_compile_options_def_group): New.
1556         (compile_file_command): Handle options with
1557         gdb::option::process_options.
1558         (compile_file_command_completer): New function.
1559         (compile_code_command): Handle options with
1560         gdb::option::process_options.
1561         (compile_code_command_completer): New function.
1562         (_initialize_compiler): Install completers for "compile code" and
1563         "compile file".  Mention available options in "compile code" and
1564         "compile code"'s help.
1565         * completer.c (advance_to_completion_word): New, factored out from
1566         ...
1567         (advance_to_expression_complete_word_point): ... this.
1568         (advance_to_filename_complete_word_point): New.
1569         * completer.h (advance_to_filename_complete_word_point): New
1570         declaration.
1571
1572 2019-06-13  Pedro Alves  <palves@redhat.com>
1573
1574         * compile/compile.c: Include "cli/cli-option.h".
1575         (compile_print_value): Scope data pointer is now a
1576         value_print_options pointer; adjust.
1577         (compile_print_command): Process options.  Scope data pointer is
1578         now a value_print_options pointer; adjust.
1579         (_initialize_compile): Update "compile print"'s help to include
1580         supported options.  Install a completer for "compile print".
1581         * cp-valprint.c (show_vtblprint, show_objectprint)
1582         (show_static_field_print): Delete.
1583         (_initialize_cp_valprint): Don't install "set print
1584         static-members", "set print vtbl", "set print object" here.
1585         * printcmd.c: Include "cli/cli-option.h" and
1586         "common/gdb_optional.h".
1587         (print_command_parse_format): Rework to fill in a
1588         value_print_options instead of a format_data.
1589         (print_value): Change parameter type from format_data pointer to
1590         value_print_options reference.  Adjust.
1591         (print_command_1): Process options.  Adjust to pass down a
1592         value_print_options.
1593         (print_command_completer): New.
1594         (_initialize_printcmd): Install print_command_completer as
1595         handle_brkchars completer for the "print" command.  Update
1596         "print"'s help to include supported options.
1597         * valprint.c: Include "cli/cli-option.h".
1598         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1599         here from cp-valprint.c.
1600         (boolean_option_def, uinteger_option_def)
1601         (value_print_option_defs, make_value_print_options_def_group):
1602         New.  Use gdb::option::add_setshow_cmds_for_options to install
1603         "set print elements", "set print null-stop", "set print repeats",
1604         "set print pretty", "set print union", "set print array", "set
1605         print address", "set print symbol", "set print array-indexes".
1606         * valprint.h: Include <string> and "cli/cli-option.h".
1607         (make_value_print_options_def_group): Declare.
1608         (print_value): Change parameter type from format_data pointer to
1609         value_print_options reference.
1610         (print_command_completer): Declare.
1611
1612 2019-06-13  Pedro Alves  <palves@redhat.com>
1613
1614         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1615         (COMMON_SFILES): Add maint-test-settings.c.
1616         * cli/cli-decode.c (boolean_enums): New global, factored out from
1617         ...
1618         (add_setshow_boolean_cmd): ... here.
1619         * cli/cli-decode.h (boolean_enums): Declare.
1620         * cli/cli-option.c: New file.
1621         * cli/cli-option.h: New file.
1622         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1623         factored out from ...
1624         (parse_cli_boolean_value(const char *)): ... this.
1625         (is_unlimited_literal): Change parameter type to pointer to
1626         pointer.  Adjust and advance ARG pointer.
1627         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1628         (parse_cli_var_enum): New, factored out from ...
1629         (do_set_command): ... this.  Adjust.
1630         * cli/cli-setshow.h (parse_cli_boolean_value)
1631         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1632         (parse_cli_var_enum): Declare.
1633         * cli/cli-utils.c: Include "cli/cli-option.h".
1634         (get_ulongest): New.
1635         * cli/cli-utils.h (get_ulongest): Declare.
1636         (check_for_argument): New overloads.
1637         * maint-test-options.c: New file.
1638
1639 2019-06-13  Pedro Alves  <palves@redhat.com>
1640
1641         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1642         parse a range if "-" is at the end of the string.
1643
1644 2019-06-13  Pedro Alves  <palves@redhat.com>
1645
1646         * cli/cli-setshow.c (parse_auto_binary_operation)
1647         (parse_cli_boolean_value): Don't allow "o".
1648
1649 2019-06-13  Pedro Alves  <palves@redhat.com>
1650
1651         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1652         * NEWS: Mention maint test-settings KIND.
1653         * maint-test-settings.c: New file.
1654
1655 2019-06-13  Pedro Alves  <palves@redhat.com>
1656
1657         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1658         completer.
1659         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1660         "set" completers.
1661
1662 2019-06-13  Pedro Alves  <palves@redhat.com>
1663
1664         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1665         after item.
1666
1667 2019-06-13  Pedro Alves  <palves@redhat.com>
1668
1669         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1670
1671 2019-06-13  Pedro Alves <palves@redhat.com>
1672
1673         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1674         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1675         call.
1676         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1677         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1678         calls.
1679         (check_for_argument): Skip spaces after argument.
1680
1681 2019-06-13  Pedro Alves  <palves@redhat.com>
1682
1683         * thread.c (thread_apply_command): Adjust TID parsing.
1684         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1685         detected before end of string.
1686         (tid_is_in_list): Error out if LIST is invalid.
1687
1688 2019-06-13  Pedro Alves  <palves@redhat.com>
1689
1690         * completer.c (complete_line_internal_1): Rewind completion word
1691         point.
1692         (completion_tracker::advance_custom_word_point_by): Change
1693         parameter type to int.
1694         * completer.h (completion_tracker::advance_custom_word_point_by):
1695         Likewise.
1696
1697 2019-06-13  Pedro Alves  <palves@redhat.com>
1698
1699         * completer.c (advance_to_completion_word): Handle delimiters.
1700
1701 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1702
1703         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1704
1705 2019-06-11  Tom Tromey  <tom@tromey.com>
1706
1707         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1708         (xmalloc_failed): Move to alloc.c.
1709         * alloc.c: New file.
1710         * Makefile.in (COMMON_SFILES): Add alloc.c.
1711
1712 2019-06-11  Tom Tromey  <tom@tromey.com>
1713
1714         * nat/linux-waitpid.c: Don't include server.h.
1715         (linux_debug): Remove.
1716         (my_waitpid): Update.
1717
1718 2019-06-11  Tom Tromey  <tromey@adacore.com>
1719
1720         * infcall.c (_initialize_infcall): Remove trailing newline from
1721         help.
1722         * user-regs.c (_initialize_user_regs): Remove trailing newline
1723         from help.
1724         * typeprint.c (_initialize_typeprint): Remove trailing newline
1725         from help.
1726         * reverse.c (_initialize_reverse): Remove trailing newlines from
1727         help.
1728         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1729         from help.
1730         * language.c (add_set_language_command): Remove trailing newline
1731         from help.
1732         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1733         help.
1734         * disasm.c (_initialize_disasm): Remove trailing newline from
1735         help.
1736         * top.c (init_main): Remove trailing newline from help.
1737         * interps.c (_initialize_interpreter): Remove trailing newline
1738         from help.
1739         * btrace.c (_initialize_btrace): Remove trailing newlines from
1740         help.
1741         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1742         from help.
1743         * python/python.c (_initialize_python): Remove trailing newline
1744         from help.
1745         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1746         help.
1747         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1748         from help.  Reformat some text.
1749         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1750         from help.
1751         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1752         newline from help.
1753
1754 2019-06-11  Tom Tromey  <tromey@adacore.com>
1755
1756         * darwin-nat.c (darwin_decode_exception_message)
1757         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1758
1759 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1760
1761         * valops.c (value_slice): Check for not allocated or not
1762         associated values.
1763
1764 2019-06-10  Tom de Vries  <tdevries@suse.de>
1765
1766         PR gdb/24618
1767         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1768         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1769         invalid.
1770
1771 2019-06-10  Tom de Vries  <tdevries@suse.de>
1772
1773         PR gdb/24611
1774         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1775         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1776
1777 2019-06-10  Tom de Vries  <tdevries@suse.de>
1778
1779         PR symtab/24545
1780         * symtab.c (struct demangled_name_entry): Add language field.
1781         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1782         static minimal symbol".  Set and use language field.
1783
1784 2019-06-10  Tom Tromey  <tromey@adacore.com>
1785
1786         * ada-lang.c (_initialize_ada_language): Update help text.
1787
1788 2019-06-10  Tom Tromey  <tromey@adacore.com>
1789
1790         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1791         with a newline.
1792         * guile/guile.c (handle_boot_error): Don't end warning with a
1793         newline.
1794         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1795         warning with a newline.
1796         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1797         newline.
1798         (s12z_frame_cache): Likewise.
1799         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1800         a newline.
1801         * solib-svr4.c (disable_probes_interface): Don't end warning with
1802         a newline.
1803         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1804         newline.
1805         * python/python.c (do_finish_initialization): Don't end warning
1806         with a newline.
1807
1808 2019-06-10  Tom Tromey  <tom@tromey.com>
1809
1810         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1811         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1812         gdbpy_enter.
1813
1814 2019-06-10  Tom Tromey  <tromey@adacore.com>
1815
1816         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1817         data.
1818         (elf_new_init): Don't call stabsread_new_init.
1819         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1820         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1821         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1822
1823 2019-06-10  Tom de Vries  <tdevries@suse.de>
1824
1825         PR symtab/16264
1826         PR symtab/24517
1827         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1828
1829 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1830
1831         * source.c (find_and_open_source): Also rewrite relative file
1832         names.
1833
1834 2019-04-26  Amos Bird  <amosbird@gmail.com>
1835
1836         * annotate.c (annotate_thread_exited): Add "thread-exited"
1837         annotation.
1838
1839 2019-06-06  Tom Tromey  <tromey@adacore.com>
1840
1841         * maint.h (class scoped_command_stats): Use
1842         DISABLE_COPY_AND_ASSIGN.
1843         <print_time>: New method.
1844         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1845         print_time.
1846         (scoped_command_stats::print_time): New method.
1847
1848 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1849
1850         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1851         instructions of lengths 6 or 8 bytes.
1852
1853 2019-06-04  Pedro Alves  <palves@redhat.com>
1854
1855         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1856
1857         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1858         * breakpoint.c (condition_completer): Likewise.
1859         * cli/cli-dump.c (scan_expression): Likewise.
1860         * common/filestuff.c (mkdir_recursive): Likewise.
1861         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1862         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1863         (gdb_abspath): Likewise.
1864         * compile/compile-cplus-types.c
1865         (compile_cplus_instance::decl_name): Likewise.
1866         * completer.c (complete_explicit_location):
1867         (signal_completer, reg_or_group_completer_1): Likewise.
1868         * cp-support.c (cp_remove_params_if_any): Likewise.
1869         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1870         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1871         * infcmd.c (strip_bg_char): Likewise.
1872         * linespec.c (copy_token_string): Likewise.
1873         * mi/mi-main.c (output_cores): Likewise.
1874         * psymtab.c (psymtab_search_name):
1875         * symfile.c (test_set_ext_lang_command): Likewise.
1876         * target.c (target_fileio_read_stralloc): Likewise.
1877         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1878         * value.c (complete_internalvar): Likewise.
1879
1880 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1881
1882         Add objfile property to gdb.Type.
1883         * NEWS: Mention Python API addition.
1884         * python/py-type.c (typy_get_objfile): New method.
1885
1886 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1887
1888         * NEWS: Mention the new set|show style [title|highlight].
1889         Mention changes to "show style", "help" and "apropos".
1890
1891 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1892
1893         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1894         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1895         instead of print_help_for_command.
1896         (print_doc_of_command): New function.
1897         (help_list): Add 'apropos -v word' suggestion.
1898         (print_help_for_command): Style the command name using title style.
1899         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1900         (_initialize_cli_cmds): Describe -v in apropos_command help.
1901
1902 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1903
1904         * cli/cli-style.h (cli_style_option): Add name in constructor,
1905         add m_name class member, add constructor with intensity,
1906         add name class function.
1907         (cli_style_option::add_setshow_commands): Remove name argument.
1908         (highlight_style, title_style): New styles.
1909         * cli/cli-style.c (do_show): New function that shows a style
1910         characteristic styling the style name with itself.
1911         (set_style_name): New function.
1912         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1913         Update all callers according to the changes in cli/cli-style.h.
1914         * utils.h (fputs_highlighted): New function.
1915         * utils.c (fputs_highlighted): Likewise.
1916
1917 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1918
1919         * NEWS: Mention new pipe command and new convenience variables.
1920
1921 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1922
1923         * cli/cli-cmds.c (pipe_command): New function.
1924         (_initialize_cli_cmds): Call add_com for pipe_command.
1925         Define | as an alias for pipe.
1926         (exit_status_set_internal_vars): New function.
1927         (shell_escape): Call exit_status_set_internal_vars.
1928         cli/cli-decode.c (find_command_name_length): Recognize | as
1929         a single character command.
1930
1931 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1932
1933         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1934         top.c (execute_command_to_ui_file): New function, mostly a copy
1935         of execute_command_to_string.
1936         (execute_command_to_string): Implement by calling
1937         execute_command_to_ui_file.
1938
1939 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1940
1941         * top.h (saved_command_line): Remove declaration.
1942         * top.c (previous_saved_command_line, previous_repeat_arguments):
1943         New variables.
1944         (saved_command_line): Make static, define together with other
1945         'repeat variables'.
1946         (dont_repeat): Clear repeat_arguments.
1947         (repeat_previous, get_saved_command_line, save_command_line):
1948         New functions.
1949         (gdb_init): Initialize saved_command_line
1950         and previous_saved_command_line.
1951         * main.c (captured_main_1): Remove saved_command_line initialization.
1952         * event-top.c (handle_line_of_input): Update to use
1953         the new 'repeat' related functions instead of direct access to
1954         saved_command_line.
1955         * command.h (repeat_previous, get_saved_command_line,
1956         save_command_line): New declarations.
1957         (dont_repeat): Add comment.
1958
1959 2019-05-30  Tom Tromey  <tromey@adacore.com>
1960
1961         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1962         Fix comment.
1963         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1964
1965 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1966
1967         PR cli/24587
1968         * completer.c (complete): Initialize variable word.
1969
1970 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1971
1972         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1973         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1974         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1975         'body' is NULL to the outter 'if', protecting the '!is_define'
1976         situation as well.
1977
1978 2019-05-29  Tom Tromey  <tromey@adacore.com>
1979
1980         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1981         (dwarf_unknown): New function.
1982         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1983         (dwarf_type_encoding_name): Use dwarf_unknown.
1984
1985 2019-05-29  Tom Tromey  <tromey@adacore.com>
1986
1987         PR c++/20020:
1988         * cp-valprint.c (cp_print_value_fields): Call
1989         cp_print_static_field inside "try".
1990
1991 2019-05-29  Tom Tromey  <tromey@adacore.com>
1992
1993         * inflow.c (struct terminal_info): Add default operator=.
1994         * configure: Rebuild.
1995         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1996         -Wdeprecated-copy-dtor, -Wredundant-move.
1997
1998 2019-05-29  Tom Tromey  <tromey@adacore.com>
1999
2000         * NEWS: Add entry.
2001         * infcmd.c (print_return_value_1): Handle finish_print
2002         option.
2003         (show_print_finish): New function.
2004         (_initialize_infcmd): Add "set/show print finish" commands.
2005         * valprint.c (user_print_options): Initialize new member.
2006         * valprint.h (struct value_print_options) <finish_print>: New
2007         member.
2008
2009 2019-05-28  Tom Tromey  <tromey@adacore.com>
2010
2011         * ada-lang.c (ada_remove_Xbn_suffix)
2012         (find_old_style_renaming_symbol)
2013         (parse_old_style_renaming): Remove.
2014         (ada_find_renaming_symbol): Don't call
2015         find_old_style_renaming_symbol.
2016         (ada_is_renaming_symbol): Rename from
2017         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2018         bool.  Now static.
2019         (ada_read_var_value): Update and simplify.
2020         * ada-exp.y (write_var_or_type): Remove old code.
2021
2022 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2023
2024         * event-top.c: Remove include comment.
2025         * inflow.c (class scoped_ignore_sigttou): Move from here...
2026         * inflow.h (class scoped_ignore_sigttou): ...to here.
2027         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2028         * top.c:  Remove include comment.
2029
2030 2019-05-27  Tom Tromey  <tom@tromey.com>
2031
2032         * NEWS: Fix typo.
2033
2034 2019-05-22  Tom Tromey  <tromey@adacore.com>
2035
2036         * target.c (target_follow_exec): Constify parameter.
2037         * target-delegates.c: Rebuild.
2038         * remote.c (remote_target::follow_exec): Constify parameter.
2039         * infrun.c (follow_exec): Constify parameter.
2040         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2041         (target_follow_exec): Likewise.
2042
2043 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2044
2045         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2046         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2047
2048 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2049
2050         * NEWS: Add debugredirect and testsuite sections.
2051
2052 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2053
2054         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2055         target descriptions using exclusively floating point register name
2056         aliases.
2057
2058 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2059
2060         PR gdb/18644:
2061         * f-lang.c (build_fortran_types): Handle the case where
2062         gdbarch_floatformat_for_type returns a nullptr.
2063
2064 2019-05-21  Tom de Vries  <tdevries@suse.de>
2065
2066         PR cli/24587
2067         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2068
2069 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         PR gdb/18644:
2072         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2073         16-byte floats.
2074         * i386-tdep.c (i386_floatformat_for_type): Use
2075         floatformats_ia64_quad for the 16-byte floating point component
2076         within a fortran 32-byte complex number.
2077
2078 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2081         delete default constructor.
2082         (find_partial_die): Update to return const struct.
2083         (partial_die_parent_scope): Move variable declaration into scope
2084         of its use and change its type to auto.
2085         (guess_partial_die_structure_name): Likewise.
2086         (partial_die_info::fixup): Likewise.
2087
2088 2019-05-17  Tom Tromey  <tromey@adacore.com>
2089
2090         * source.c (find_and_open_source): Remove cast.
2091
2092 2019-05-17  Tom Tromey  <tromey@adacore.com>
2093
2094         * annotate.c (annotate_source): Make "filename" const.
2095         * annotate.h (annotate_source): Use const.
2096
2097 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2098
2099         * disasm.c (set_disassembler_options): Send errors to stderr.
2100
2101 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2102
2103         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2104         (cli_interp_base::set_logging): Check debug_redirect.
2105         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2106         * cli/cli-logging.c (debug_redirect): Add static variable.
2107         (pop_output_files): Add default param.
2108         (handle_redirections): Print debug setting.
2109         (show_logging_command): Likewise.
2110         (_initialize_cli_logging): Add debugredirect command.
2111         * interps.c (current_interp_set_logging): Add debug_redirect
2112         parameter.
2113         * interps.h (set_logging): Add debug_redirect parameter.
2114         (current_interp_set_logging): Likewise.
2115         * mi/mi-common.h: Likewise.
2116         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2117
2118 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2119             Tom Tromey  <tromey@adacore.com>
2120
2121         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2122         directly.
2123         * cli/cli-interp.h (make_logging_output): Remove declaration.
2124         * cli/cli-logging.c (make_logging_output): Remove function.
2125         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2126         directly.
2127         * ui-file.c (tee_file::tee_file): Remove bools.
2128         (tee_file::~tee_file): Remove deletes.
2129         * ui-file.h (tee_file): Remove bools.
2130
2131 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2132
2133         * mi/mi-cmds.h (mi_cmd_complete): New function.
2134         * mi/mi-main.c (mi_cmd_complete): Likewise.
2135         * mi/mi-cmds.c: Define new MI command -complete.
2136         * NEWS: Mention new -complete command.
2137
2138 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2139
2140         * completer.h (complete): New function.
2141         * completer.c (complete): Likewise.
2142         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2143         function defined in completer.h.
2144
2145 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2146
2147         * MAINTAINERS (Write After Approval): Add myself.
2148
2149 2019-05-17  Tom de Vries  <tdevries@suse.de>
2150
2151         PR gdb/24094
2152         * dwarf2read.c (struct cu_partial_die_info): New struct.
2153         (find_partial_die): Return cu_partial_die_info.
2154         (partial_die_parent_scope, guess_partial_die_structure_name)
2155         (partial_die_info::fixup): Handle new return type of find_partial_die.
2156
2157 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2158
2159         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2160         "std::string", simplifying the algorithm.
2161
2162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2163
2164         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2165         (stap_static_probe_ops::get_probes): Likewise.
2166
2167 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2168
2169         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2170         '-')" and "else if".
2171         (stap_parse_single_operand): Join checks for
2172         "gdbarch_stap_parse_special_token_p" and
2173         "gdbarch_stap_parse_special_token" in the same "if" statement.
2174         Invert check when verifying for operation on register
2175         displacement.
2176
2177 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2178
2179         * stap-probe.c (stap_get_opcode): Update comment.
2180         (stap_get_expected_argument_type): Likewise.
2181         (handle_stap_probe): Likewise.
2182
2183 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2184
2185         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2186         return type to 'bool'.  Adjust comment.  Use 'bool' when
2187         appropriate.
2188         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2189         * stap-probe.c (stap_parse_argument_1): Likewise.
2190         (stap_is_operator): Likewise.
2191         (stap_is_generic_prefix): Likewise.
2192         (stap_is_register_prefix): Likewise.
2193         (stap_is_register_indirection_prefix): Likewise.
2194         (stap_is_integer_prefix): Likewise.
2195         (stap_generic_check_suffix): Likewise.
2196         (stap_check_integer_suffix): Likewise.
2197         (stap_check_register_suffix): Likewise.
2198         (stap_check_register_indirection_suffix): Likewise.
2199         (stap_parse_register_operand): Likewise.
2200         (stap_parse_single_operand): Likewise.
2201         (stap_parse_argument_1): Likewise.
2202         (stap_probe::get_argument_count): Likewise.
2203         (stap_is_operator): Likewise.
2204
2205 2019-05-16  Tom Tromey  <tromey@adacore.com>
2206
2207         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2208         keyword to foreach.
2209
2210 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2211
2212         * linux-thread-db.c (try_thread_db_load_1): Change return type
2213         to bool.
2214         (try_thread_db_load): Likewise.
2215         (try_thread_db_load_from_pdir_1): Likewise.
2216         (try_thread_db_load_from_pdir): Likewise.
2217         (try_thread_db_load_from_sdir): Likewise.
2218         (try_thread_db_load_from_dir): Likewise.
2219         (thread_db_load_search): Likewise.
2220         (has_libpthread): Likewise.
2221         (thread_db_load): Likewise.
2222
2223 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2224
2225         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2226         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2227         NULL, and complain/return if that's the case.
2228
2229 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2230
2231         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2232         (advance, posn, abstract_read_memory): New functions.
2233         [struct mem_read_abstraction]: New struct.
2234         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2235
2236 2019-05-14  Tom Tromey  <tromey@adacore.com>
2237
2238         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2239         value is not lval_memory.
2240
2241 2019-05-14  Tom Tromey  <tromey@adacore.com>
2242
2243         * solib.c (info_sharedlibrary_command): Style the file name.
2244
2245 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2246
2247         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2248         (aarch64_vnv_type): Likewise.
2249         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2250         * common/tdesc.c: Likewise.
2251         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2252         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2253         * features/aarch64-fpu.xml: Add ieee half view.
2254         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2255         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2256         * gdbtypes.h (struct builtin_type): Likewise.
2257         (struct objfile_type): Likewise.
2258
2259 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2260
2261         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2262         typo.
2263         * location.h (string_to_event_location): Likewise.
2264
2265 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2266
2267         GDB 8.3 released.
2268
2269 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2270
2271         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2272         New variable declaration.
2273         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2274         New variable.
2275         (print_one_breakpoint): Use ui_out::test_flags and new global
2276         variable to compute use_fixed_output.
2277         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2278         Remove.
2279         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2280         (mi_multi_location_breakpoint_output_fixed): Remove.
2281         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2282         new variable.
2283         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2284         fix_multi_location_breakpoint_output flag if version >= 3.
2285         * ui-out.h (enum ui_out_flag)
2286         <fix_multi_location_breakpoint_output>: New enumerator.
2287
2288 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2289
2290         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2291
2292 2019-05-10  Tom Tromey  <tromey@adacore.com>
2293
2294         * ada-lang.c (catch_ada_completer): New function.
2295         (_initialize_ada_language): Use it.
2296
2297 2019-05-10  Tom Tromey  <tromey@adacore.com>
2298
2299         * thread.c (print_thread_info): Make "requested_threads" const.
2300         * gdbthread.h (print_thread_info): Make "requested_threads"
2301         const.
2302         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2303         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2304
2305 2019-05-08  Tom Tromey  <tom@tromey.com>
2306
2307         * gdbtypes.c (objfile_type_data): Change type.
2308         (objfile_type, _initialize_gdbtypes): Update.
2309
2310 2019-05-08  Tom Tromey  <tom@tromey.com>
2311
2312         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2313         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2314         (_initialize_dwarf2_frame): Update.
2315
2316 2019-05-08  Tom Tromey  <tom@tromey.com>
2317
2318         * objc-lang.c (objc_objfile_data): Change type.
2319         (find_methods): Update.
2320         (_initialize_objc_lang): Remove.
2321
2322 2019-05-08  Tom Tromey  <tom@tromey.com>
2323
2324         * stabsread.c (rs6000_builtin_type_data): Change type.
2325         (rs6000_builtin_type, _initialize_stabsread): Update.
2326
2327 2019-05-08  Tom Tromey  <tom@tromey.com>
2328
2329         * mips-tdep.c (mips_pdr_data): Remove.
2330         (_initialize_mips_tdep): Update.
2331
2332 2019-05-08  Tom Tromey  <tom@tromey.com>
2333
2334         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2335         (hppa_init_objfile_priv_data, read_unwind_info)
2336         (find_unwind_entry, _initialize_hppa_tdep): Update.
2337
2338 2019-05-08  Tom Tromey  <tom@tromey.com>
2339
2340         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2341         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2342         on obstack.
2343         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2344
2345 2019-05-08  Tom Tromey  <tom@tromey.com>
2346
2347         * mdebugread.c (basic_type_data): Change type.
2348         (basic_type, _initialize_mdebugread): Update.
2349
2350 2019-05-08  Tom Tromey  <tom@tromey.com>
2351
2352         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2353
2354 2019-05-08  Tom Tromey  <tom@tromey.com>
2355
2356         * nto-tdep.c (nto_inferior_data_reg): Change type.
2357         (nto_inferior_data): Update.
2358         (nto_inferior_data_cleanup, nto_new_inferior_data)
2359         (_initialize_nto_tdep): Remove.
2360         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2361
2362 2019-05-08  Tom Tromey  <tom@tromey.com>
2363
2364         * ada-lang.c (struct ada_inferior_data): Add initializers.
2365         (ada_inferior_data): Change type.
2366         (ada_inferior_data_cleanup): Remove.
2367         (get_ada_inferior_data, ada_inferior_exit)
2368         (struct ada_pspace_data): Add initializers, destructor.
2369         (ada_pspace_data_handle): Change type.
2370         (get_ada_pspace_data): Update.
2371         (ada_pspace_data_cleanup): Remove.
2372
2373 2019-05-08  Tom Tromey  <tom@tromey.com>
2374
2375         * coffread.c (struct coff_symfile_info): Add initializers.
2376         (coff_objfile_data_key): Move lower.  Change type.
2377         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2378         Update.
2379         (coff_free_info): Remove.
2380
2381 2019-05-08  Tom Tromey  <tom@tromey.com>
2382
2383         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2384         (fbsd_pspace_data_handle): Move lower.  Change type.
2385         (get_fbsd_pspace_data): Update.
2386         (fbsd_pspace_data_cleanup): Remove.
2387         (_initialize_fbsd_tdep): Update.
2388
2389 2019-05-08  Tom Tromey  <tom@tromey.com>
2390
2391         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2392         (get_ada_tasks_pspace_data): Update.
2393         (ada_tasks_pspace_data_cleanup): Remove.
2394         (_initialize_tasks): Update.
2395         (ada_tasks_inferior_data_handle): Change type.
2396         (get_ada_tasks_inferior_data): Update.
2397         (ada_tasks_inferior_data_cleanup): Remove.
2398         (struct ada_tasks_pspace_data): Add initializers.
2399
2400 2019-05-08  Tom Tromey  <tom@tromey.com>
2401
2402         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2403         * symfile-debug.c (debug_sym_get_probes): Change type.
2404         * stap-probe.c (handle_stap_probe):
2405         (stap_static_probe_ops::get_probes): Change type.
2406         * probe.h (class static_probe_ops) <get_probes>: Change type.
2407         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2408         (parse_probes_in_pspace): Update.
2409         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2410         Update.
2411         (any_static_probe_ops::get_probes): Change type.
2412         * elfread.c (elfread_data): New typedef.
2413         (probe_key): Change type.
2414         (elf_get_probes): Likewise.  Update.
2415         (probe_key_free): Remove.
2416         (_initialize_elfread): Update.
2417         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2418         Change type.
2419         (dtrace_process_dof_probe, dtrace_process_dof)
2420         (dtrace_static_probe_ops::get_probe): Change type.
2421
2422 2019-05-08  Tom Tromey  <tom@tromey.com>
2423
2424         * xcoffread.c (struct xcoff_symfile_info): Rename from
2425         coff_symfile_info.  Add initializers.
2426         (xcoff_objfile_data_key): Move lower.  Change type.
2427         (XCOFF_DATA): Rewrite.
2428         (xcoff_free_info): Remove.
2429         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2430         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2431         (xcoff_initial_scan): Update.
2432
2433 2019-05-08  Tom Tromey  <tom@tromey.com>
2434
2435         * solib-svr4.c (struct svr4_info): Add initializers and
2436         destructor.
2437         <probes_table>: Now an htab_up.
2438         (solib_svr4_pspace_data): Change type.
2439         (free_probes_table): Simplify.
2440         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2441         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2442         (probes_table_remove_objfile_probes, register_solib_event_probe)
2443         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2444         (_initialize_svr4_solib): Update.
2445
2446 2019-05-08  Tom Tromey  <tom@tromey.com>
2447
2448         * remote.c (remote_pspace_data): Change type.
2449         (remote_pspace_data_cleanup): Remove.
2450         (get_remote_exec_file, set_pspace_remote_exec_file)
2451         (_initialize_remote): Update.
2452
2453 2019-05-08  Tom Tromey  <tom@tromey.com>
2454
2455         * breakpoint.c (breakpoint_objfile_key): Change type.
2456         (get_breakpoint_objfile_data): Update.
2457         (free_breakpoint_objfile_data): Remove.
2458         (_initialize_breakpoint): Update.
2459
2460 2019-05-08  Tom Tromey  <tom@tromey.com>
2461
2462         * linux-tdep.c (struct linux_info): Add initializers.
2463         (linux_inferior_data): Move.  Change type.
2464         (invalidate_linux_cache_inf): Update.
2465         (linux_inferior_data_cleanup): Remove.
2466         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2467
2468 2019-05-08  Tom Tromey  <tom@tromey.com>
2469
2470         * auxv.c (auxv_inferior_data): Move.  Change type.
2471         (auxv_inferior_data_cleanup): Remove.
2472         (invalidate_auxv_cache_inf): Rewrite.
2473         (get_auxv_inferior_data, _initialize_auxv): Update.
2474
2475 2019-05-08  Tom Tromey  <tom@tromey.com>
2476
2477         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2478         (symfile_debug_objfile_data_key): Change type.
2479         (symfile_debug_installed, debug_qf_has_symbols)
2480         (debug_qf_find_last_source_symtab)
2481         (debug_qf_forget_cached_source_info)
2482         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2483         (debug_qf_print_stats, debug_qf_dump)
2484         (debug_qf_expand_symtabs_for_function)
2485         (debug_qf_expand_all_symtabs)
2486         (debug_qf_expand_symtabs_with_fullname)
2487         (debug_qf_map_matching_symbols)
2488         (debug_qf_expand_symtabs_matching)
2489         (debug_qf_find_pc_sect_compunit_symtab)
2490         (debug_qf_map_symbol_filenames)
2491         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2492         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2493         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2494         (debug_sym_read_linetable, debug_sym_relocate): Update.
2495         (symfile_debug_free_objfile): Remove.
2496         (install_symfile_debug_logging, _initialize_symfile_debug):
2497         Update.
2498
2499 2019-05-08  Tom Tromey  <tom@tromey.com>
2500
2501         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2502         allocate_on_obstack.
2503         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2504         (get_dwarf2_per_objfile): Update.
2505         (set_dwarf2_per_objfile): Remove.
2506         (dwarf2_has_info, dwarf2_get_section_info): Update.
2507         (dwarf2_free_objfile): Remove.
2508         (_initialize_dwarf2_read): Update.
2509
2510 2019-05-08  Tom Tromey  <tom@tromey.com>
2511
2512         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2513         initializers.
2514         <unsupported_script_warning_printed,
2515         script_not_found_warning_printed>: Now bool.
2516         (auto_load_pspace_data): Change type.
2517         (~auto_load_pspace_info): Rename from
2518         auto_load_pspace_data_cleanup.
2519         (get_auto_load_pspace_data, init_loaded_scripts_info)
2520         (clear_section_scripts, maybe_print_unsupported_script_warning)
2521         (maybe_print_script_not_found_warning, _initialize_auto_load):
2522         Update.
2523
2524 2019-05-08  Tom Tromey  <tom@tromey.com>
2525
2526         * objfiles.c (objfile_pspace_info): Add destructor and
2527         initializers.
2528         (objfiles_pspace_data): Change type.
2529         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2530         (get_objfile_pspace_data): Update.
2531         (objfiles_bfd_data): Change type.
2532         (get_objfile_bfd_data): Update.
2533         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2534
2535 2019-05-08  Tom Tromey  <tom@tromey.com>
2536
2537         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2538         Change type.
2539         (get_catch_syscall_inferior_data): Update.
2540         (catch_syscall_inferior_data_cleanup): Remove.
2541         (_initialize_break_catch_syscall): Update.
2542
2543 2019-05-08  Tom Tromey  <tom@tromey.com>
2544
2545         * inflow.c (struct terminal_info): Add destructor and
2546         initializers.
2547         (inflow_inferior_data): Change type.
2548         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2549         (get_inflow_inferior_data, inflow_inferior_exit)
2550         (swap_terminal_info, _initialize_inflow): Update.
2551
2552 2019-05-08  Tom Tromey  <tom@tromey.com>
2553
2554         * target-dcache.c (target_dcache_cleanup): Remove.
2555         (target_dcache_aspace_key): Change type.
2556         (target_dcache_init_p, target_dcache_invalidate)
2557         (target_dcache_get, target_dcache_get_or_init)
2558         (_initialize_target_dcache): Update.
2559         * dcache.h (struct dcache_deleter): New.
2560
2561 2019-05-08  Tom Tromey  <tom@tromey.com>
2562
2563         * symtab.c (struct symbol_cache): Add destructor and
2564         initializers.
2565         (symbol_cache_key): Move.  Change type.
2566         (make_symbol_cache, free_symbol_cache): Remove.
2567         (get_symbol_cache): Update.
2568         (symbol_cache_cleanup): Remove.
2569         (ALL_PSPACES, symbol_cache_flush)
2570         (maintenance_print_symbol_cache)
2571         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2572         Update.
2573
2574 2019-05-08  Tom Tromey  <tom@tromey.com>
2575
2576         * symtab.c (struct main_info): Add destructor and initializers.
2577         (main_progspace_key): Move.  Change type.
2578         (get_main_info): Update.
2579         (main_info_cleanup): Remove.
2580         (_initialize_symtab): Update.
2581
2582 2019-05-08  Tom Tromey  <tom@tromey.com>
2583
2584         * registry.h (DECLARE_REGISTRY): Define the _key class.
2585
2586 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * NEWS: Merge two 'New commands' sections.
2589
2590 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2591
2592         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2593         parameter and use Ada language definition instead.
2594         (ada_val_print_ptr): Remove unused language parameter.
2595         (ada_val_print_num): Remove language parameter and use Ada language
2596         definition instead.
2597         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2598         parameter.
2599         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2600         parameter and use Ada language definition instead.
2601         (ada_val_print_1): Update all ada_val_print_xxx calls.
2602         Remove language parameter.
2603         (ada_val_print): Update ada_val_print_1 call.
2604
2605 2019-05-08  Tom Tromey  <tromey@adacore.com>
2606
2607         * remote.c (remote_hw_watchpoint_limit)
2608         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2609         Now static.
2610
2611 2019-05-08  Tom Tromey  <tromey@adacore.com>
2612
2613         * maint.c (_initialize_maint_cmds): Move initialization code to
2614         remote.c.
2615         (watchdog, show_watchdog): Move to remote.c.
2616         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2617         "watchdog" static.
2618         (_initialize_remote): Move initialization code from maint.c.
2619         * defs.h (watchdog): Don't declare.
2620
2621 2019-05-08  Tom Tromey  <tromey@adacore.com>
2622
2623         * tui/tui-interp.c: Include main.h.
2624         * interps.c: Include main.h.
2625         * main.h (interpreter_p): Declare.
2626         * defs.h (interpreter_p): Don't declare.
2627
2628 2019-05-08  Tom Tromey  <tromey@adacore.com>
2629
2630         * dwarf2loc.c: Include dwarf2read.h.
2631         * defs.h (read_unsigned_leb128): Don't declare.
2632         * dwarf2read.h (read_unsigned_leb128): Declare.
2633
2634 2019-05-08  Tom Tromey  <tromey@adacore.com>
2635
2636         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2637         method.
2638
2639 2019-05-08  Tom Tromey  <tromey@adacore.com>
2640
2641         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2642         when no wrap column is set.
2643
2644 2019-05-08  Tom Tromey  <tromey@adacore.com>
2645
2646         * c-lang.c (c_get_string): Handle non-C-style arrays.
2647
2648 2019-05-08  Tom Tromey  <tromey@adacore.com>
2649
2650         * typeprint.c (print_offset_data::update): Print the bit offset,
2651         not the number of bits remaining.
2652
2653 2019-05-08  Tom Tromey  <tromey@adacore.com>
2654
2655         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2656         padding at end of comment.
2657
2658 2019-05-08  Tom Tromey  <tromey@adacore.com>
2659
2660         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2661         Compare main types.
2662
2663 2019-05-06  Tom Tromey  <tom@tromey.com>
2664
2665         * common/scoped_mmap.c: Include common-defs.h.
2666         * common/scoped_mmap.h: Don't include config.h.
2667
2668 2019-05-04  Tom Tromey  <tom@tromey.com>
2669
2670         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2671         (struct aarch64_call_info): Add initializers.
2672         <si>: Now a std::vector.
2673         (pass_on_stack, aarch64_push_dummy_call): Update.
2674
2675 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2676             Tom Tromey  <tom@tromey.com>
2677
2678         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2679         (ppc_threads): Now a std::vector.  Now static.
2680         (hwdebug_find_thread_points_by_tid)
2681         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2682         Update.
2683
2684 2019-05-04  Tom Tromey  <tom@tromey.com>
2685
2686         * arc-tdep.c (arc_tdesc_init): Return bool.
2687
2688 2019-05-04  Tom Tromey  <tom@tromey.com>
2689
2690         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2691         Use gdb_assert_not_reached.
2692
2693 2019-05-04  Tom Tromey  <tom@tromey.com>
2694
2695         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2696         "false".
2697
2698 2019-05-04  Tom Tromey  <tom@tromey.com>
2699
2700         * arc-tdep.c (arc_tdesc_init): Use bool.
2701
2702 2019-05-04  Tom Tromey  <tom@tromey.com>
2703
2704         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2705
2706 2019-05-04  Tom Tromey  <tom@tromey.com>
2707
2708         * cli/cli-cmds.c (valid_command_p): Return bool.
2709
2710 2019-05-04  Tom Tromey  <tom@tromey.com>
2711
2712         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2713         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2714
2715 2019-05-04  Raul Tambre  <raul@tambre.ee>
2716
2717         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2718         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2719         operator for comparison.
2720
2721 2019-05-04  Tom Tromey  <tom@tromey.com>
2722
2723         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2724         (lookup_partial_symbol, print_partial_symbols)
2725         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2726         (psymbol_compare): Update.
2727         (add_psymbol_to_bcache): Clear the entire psymbol.
2728         (maintenance_check_psymtabs): Update.
2729         * psympriv.h (struct partial_symbol): Don't derive from
2730         general_symbol_info.
2731         <obj_section, unrelocated_address, address,
2732         set_unrelocated_address>: Update.
2733         <ginfo>: New member.
2734         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2735         (debug_names::write_psymbols): Update.
2736
2737 2019-05-04  Tom de Vries  <tdevries@suse.de>
2738
2739         * contrib/cc-with-tweaks.sh: Support -n arg.
2740
2741 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2742
2743         * corelow.c (core_target::detach): Ensure frame cache and
2744         register caches are cleared.
2745         inferior.c (exit_inferior_1): Likewise.
2746
2747 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2748             Tom Tromey  <tom@tromey.com>
2749
2750         * dictionary.c (collate_pending_symbols_by_language): Remove
2751         "struct" from foreach.
2752         * symtab.c (lookup_global_symbol_from_objfile)
2753         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2754         foreach.
2755         * ser-tcp.c (net_open): Remove "struct" from foreach.
2756         * objfiles.c (objfile_relocate, objfile_rebase)
2757         (objfile_has_symbols): Remove "struct" from foreach.
2758         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2759         from foreach.
2760         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2761         foreach.
2762         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2763         "struct" from foreach.
2764         * ada-lang.c (create_excep_cond_exprs)
2765         (ada_exception_catchpoint_cond_string): Remove "struct" from
2766         foreach.
2767
2768 2019-05-03  Tom Tromey  <tromey@adacore.com>
2769
2770         * ada-exp.y (convert_char_literal): Check suffix of each
2771         enumerator.
2772
2773 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2774
2775         PR ada/21406:
2776         * ada-exp.y (yywrap): Don't define.
2777         * ada-lex.l (%option): Add noyywrap
2778         (yywrap): Remove.
2779
2780 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2781
2782         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2783         _WIN32_WINNT to the XP level, unless already defined to a higher
2784         level.
2785
2786         * unittests/parse-connection-spec-selftests.c:
2787         * ser-tcp.c:
2788         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2789         override.
2790
2791         * symfile.c (find_separate_debug_file): Remove colon from the
2792         drive spec of DOS/Windows file names of the target, so that the
2793         file name produced from DEBUGDIR and the target's directory will
2794         be valid on DOS/Windows systems.
2795
2796 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * rust-lang.c (val_print_struct): Handle printing structures
2799         containing strings.
2800
2801 2019-05-02  Tom Tromey  <tromey@adacore.com>
2802
2803         * valarith.c (_initialize_valarith): Remove.
2804
2805 2019-05-01  Tom Tromey  <tromey@adacore.com>
2806
2807         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2808         bitfields.
2809
2810 2019-05-01  Tom Tromey  <tromey@adacore.com>
2811
2812         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2813         for big-endian copies.
2814
2815 2019-04-30  Ali Tamur  <tamur@google.com>
2816         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2817         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2818         (read_3_bytes): New function.
2819
2820 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2821
2822         * windows-nat.c (main_thread_id): Delete.
2823         (handle_output_debug_string): Replace main_thread_id by
2824         current_event.dwThreadId.
2825         (fake_create_process): Likewise.
2826         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2827         Do not set main_thread_id.
2828         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2829         current_event.dwThreadId.
2830         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2831
2832 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2833
2834         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2835         Use current_event.dwThreadId instead of main_thread_id.
2836
2837 2019-04-30  Tom Tromey  <tromey@adacore.com>
2838
2839         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2840         (create_excep_cond_exprs): Iterate over program spaces.
2841         (ada_exception_catchpoint_cond_string): Examine all minimal
2842         symbols for exception types.
2843
2844 2019-04-30  Tom Tromey  <tromey@adacore.com>
2845
2846         PR c++/24470:
2847         * dwarf2read.c (process_structure_scope): Handle case where type
2848         has template parameters but no symbol was created.
2849
2850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2851             Chris January  <chris.january@arm.com>
2852
2853         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2854         qualifier.
2855         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2856
2857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * f-typeprint.c (f_print_type): Update rules for printing
2860         whitespace.
2861         (f_type_print_varspec_suffix): Likewise.
2862
2863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2864             Chris January  <chris.january@arm.com>
2865
2866         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2867         function arguments.
2868
2869 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * f-lang.c (build_fortran_types): Change name of void type to
2872         lower case.
2873         * f-typeprint.c (f_type_print_base): Print the name of the void
2874         type, rather than a fixed string.
2875         * f-valprint.c (f_decorations): Use lower case void string.
2876
2877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2878             Chris January  <chris.january@arm.com>
2879
2880         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2881         types for Fortran.
2882
2883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2884             Chris January  <chris.january@arm.com>
2885             David Lecomber  <david.lecomber@arm.com>
2886
2887         * f-exp.y (BINOP_INTRINSIC): New token.
2888         (exp): New parser rule handling BINOP_INTRINSIC.
2889         (f77_keywords): Add new builtin procedures.
2890         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2891         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2892         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2893         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2894         (print_unop_subexp_f): New function.
2895         (print_binop_subexp_f): New function.
2896         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2897         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2898         (dump_subexp_body_f): Likewise.
2899         (operator_check_f): Likewise.
2900         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2901         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2902
2903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2904
2905         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2906         UNOP_KIND.
2907         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2908         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2909         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2910         (operator_length_f): New fuction.
2911         (print_subexp_f): New function.
2912         (op_name_f): New function.
2913         (dump_subexp_body_f): New function.
2914         (operator_check_f): New function.
2915         (exp_descriptor_f): Replace standard expression handling functions
2916         with new functions.
2917         * gdb/fortran-operator.def: New file.
2918         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2919         * gdb/std-operator.def: Remove UNOP_KIND.
2920
2921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * std-operator.def: Remove unbalanced, stray double quote
2924         character.
2925
2926 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2927             Chris January  <chris.january@arm.com>
2928             Daniel Everett  <daniel.everett@arm.com>
2929             Nick Forrington  <nick.forrington@arm.com>
2930             Richard Bunt  <richard.bunt@arm.com>
2931
2932         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2933         of depth when printing anonymous structs or unions.
2934         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2935         Don't print either the top-level value, or the children if the
2936         max-depth is exceeded.
2937         (ppscm_print_children): When printing the key of a map, allow one
2938         extra level of depth.
2939         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2940         print either the top-level value, or the children if the max-depth
2941         is exceeded.
2942         (print_children): When printing the key of a map, allow one extra
2943         level of depth.
2944         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2945         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2946         (user_print_options): Initialise max_depth field.
2947         (val_print_scalar_or_string_type_p): New function.
2948         (val_print): Check to see if the max depth has been reached.
2949         (val_print_check_max_depth): Define new function.
2950         (show_print_max_depth): New function.
2951         (_initialize_valprint): Add 'print max-depth' option.
2952         * valprint.h (struct value_print_options) <max_depth>: New field.
2953         (val_print_check_max_depth): Declare new function.
2954         * NEWS: Document new feature.
2955
2956 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2957
2958         * ada-lang.c (ada_language_defn): Initialise new field.
2959         * c-lang.c (c_is_string_type_p): New function.
2960         (c_language_defn): Initialise new field.
2961         (cplus_language_defn): Initialise new field.
2962         (asm_language_defn): Initialise new field.
2963         (minimal_language_defn): Initialise new field.
2964         * c-lang.h (c_is_string_type_p): Declare new function.
2965         * d-lang.c (d_language_defn): Initialise new field.
2966         * f-lang.c (f_is_string_type_p): New function.
2967         (f_language_defn): Initialise new field.
2968         * go-lang.c (go_is_string_type_p): New function.
2969         (go_language_defn): Initialise new field.
2970         * language.c (default_is_string_type_p): New function.
2971         (unknown_language_defn): Initialise new field.
2972         (auto_language_defn): Initialise new field.
2973         * language.h (struct language_defn) <la_is_string_type_p>: New
2974         member variable.
2975         (default_is_string_type_p): Declare new function.
2976         * m2-lang.c (m2_language_defn): Initialise new field.
2977         * objc-lang.c (objc_language_defn): Initialise new field.
2978         * opencl-lang.c (opencl_language_defn): Initialise new field.
2979         * p-lang.c (pascal_is_string_type_p): New function.
2980         (pascal_language_defn): Initialise new field.
2981         * rust-lang.c (rust_is_string_type_p): New function.
2982         (rust_language_defn): Initialise new field.
2983
2984 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2987         New field.
2988         * ada-lang.c (ada_language_defn): Initialise new field.
2989         * c-lang.c (c_language_defn): Likewise.
2990         (cplus_language_defn): Likewise.
2991         (asm_language_defn): Likewise.
2992         (minimal_language_defn): Likewise.
2993         * d-lang.c (d_language_defn): Likewise.
2994         * f-lang.c (f_language_defn): Likewise.
2995         * go-lang.c (go_language_defn): Likewise.
2996         * language.c (unknown_language_defn): Likewise.
2997         (auto_language_defn): Likewise.
2998         * m2-lang.c (m2_language_defn): Likewise.
2999         * objc-lang.c (objc_language_defn): Likewise.
3000         * opencl-lang.c (opencl_language_defn): Likewise.
3001         * p-lang.c (pascal_language_defn): Likewise.
3002         * rust-lang.c (rust_language_defn): Likewise.
3003
3004 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * ada-lang.c (ada_is_character_type): Change return type to bool.
3007         (ada_is_string_type): Likewise.
3008         * ada-lang.h (ada_is_character_type): Update declaration
3009         (ada_is_string_type): Likewise.
3010
3011 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3012
3013         Support style in 'frame|thread apply'
3014
3015         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3016         * record.c (record_start, record_stop): Update callers of
3017         execute_command_to_string with false.
3018         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3019         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3020         methods.
3021         (class string_file): New constructor with term_out parameter.
3022         Override methods term_out and can_emit_style_escape.  New member
3023         term_out.
3024         (class stdio_file): Override can_emit_style_escape.
3025         (class tee_file): Override term_out and can_emit_style_escape.
3026         * utils.h (can_emit_style_escape): Remove.
3027         * utils.c (can_emit_style_escape): Likewise.
3028         Update all callers of can_emit_style_escape (SOMESTREAM) to
3029         SOMESTREAM->can_emit_style_escape.
3030         * source-cache.c (source_cache::get_source_lines): Likewise.
3031         * stack.c (frame_apply_command_count): Call execute_command_to_string
3032         passing the term_out characteristic of the current gdb_stdout.
3033         * thread.c (thr_try_catch_cmd): Likewise.
3034         * top.c (execute_command_to_string): pass term_out parameter
3035         to construct the string_file for the command output.
3036         * ui-file.c (term_cli_styling): New function (most code moved
3037         from utils.c can_emit_style_escape).
3038         (string_file::string_file, string_file::can_emit_style_escape,
3039         stdio_file::can_emit_style_escape, tee_file::term_out,
3040         tee_file::can_emit_style_escape): New functions.
3041
3042 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3043
3044         * NEWS: Mention the new set|show may-call-functions.
3045         * infcall.c (may_call_functions_p): New variable.
3046         (show_may_call_functions_p): New function.
3047         (call_function_by_hand_dummy): Throws an error if not
3048         may-call-functions.
3049         (_initialize_infcall): Call add_setshow_boolean_cmd for
3050         may-call-functions.
3051
3052 2019-04-25  Keith Seitz  <keiths@redhat.com>
3053
3054         PR c++/24367
3055         * cp-support.c (inspect_type): Don't attempt substitutions
3056         of symbol with the same name.
3057
3058 2019-04-25  Tom Tromey  <tromey@adacore.com>
3059
3060         PR gdb/24475:
3061         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3062         static.
3063
3064 2019-04-25  Tom Tromey  <tromey@adacore.com>
3065
3066         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3067         rvalue reference.
3068         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3069         (gdb_xml_parser::parse): Use std::move.
3070         * python/python-internal.h (gdbpy_convert_exception): Take a const
3071         reference.
3072         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3073         std::move.
3074         * python/py-utils.c (gdbpy_convert_exception): Take a const
3075         reference.
3076         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3077         Use std::move.
3078         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3079         Use std::move.
3080         * mi/mi-main.c (mi_print_exception): Take a const reference.
3081         * main.c (handle_command_errors): Take a const reference.
3082         * linespec.c (parse_linespec): Use std::move.
3083         * infcall.c (run_inferior_call): Use std::move.
3084         (call_function_by_hand_dummy): Use std::move.
3085         * exec.c (try_open_exec_file): Use std::move.
3086         * exceptions.h (exception_print, exception_fprintf)
3087         (exception_print_same): Update.
3088         * exceptions.c (print_exception, exception_print)
3089         (exception_fprintf, exception_print_same): Change parameters to
3090         const reference.
3091         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3092         * common/new-op.c: Use std::move.
3093         * common/common-exceptions.h (struct gdb_exception): Add move
3094         constructor.
3095         (struct gdb_exception_error, struct gdb_exception_quit, struct
3096         gdb_quit_bad_alloc): Change constructor to move constructor.
3097         (throw_exception): Change parameter to rvalue reference.
3098         * common/common-exceptions.c (throw_exception): Take rvalue
3099         reference.
3100         * cli/cli-interp.c (safe_execute_command): Use std::move.
3101         * breakpoint.c (insert_bp_location, location_to_sals): Use
3102         std::move.
3103
3104 2019-04-25  Tom Tromey  <tromey@adacore.com>
3105
3106         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3107         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3108         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3109         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3110         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3111         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3112         guile/scm-value.c: Use unpack.
3113         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3114         gdbscm_gdb_exception.
3115         (gdbscm_throw_gdb_exception): Likewise.
3116         (struct gdbscm_gdb_exception): New.
3117         (unpack): New function.
3118         (gdbscm_wrap): Use unpack.
3119
3120 2019-04-25  Tom Tromey  <tromey@adacore.com>
3121
3122         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3123         (gdb_rl_callback_handler): Use std::move.
3124         * common/common-exceptions.h (struct gdb_exception): Add move
3125         assignment operator.
3126         (throw_exception_sjlj): Change "exception" to const reference.
3127         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3128         (throw_exception_sjlj): Change "exception" to const reference.
3129
3130 2019-04-25  Tom Tromey  <tromey@adacore.com>
3131
3132         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3133         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3134         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3135         Update.
3136         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3137         Update.
3138         * mi/mi-interp.c (mi_interp::exec): Update.
3139         * linespec.c (parse_linespec): Update.
3140         * infcall.c (run_inferior_call): Update.
3141         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3142         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3143         (gdbscm_lookup_global_symbol): Update.
3144         * guile/scm-param.c (gdbscm_parameter_value): Update.
3145         * guile/scm-frame.c (gdbscm_frame_read_register)
3146         (gdbscm_frame_read_var): Update.
3147         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3148         * exec.c (try_open_exec_file): Update.
3149         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3150         (gdb_rl_callback_handler): Update.
3151         * common/common-exceptions.h (exception_none): Don't declare.
3152         * common/common-exceptions.c (exception_none): Don't define.
3153         (struct catcher) <exception>: Update.
3154         * cli/cli-interp.c (safe_execute_command): Update.
3155         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3156
3157 2019-04-25  Ali Tamur  <tamur@google.com>
3158
3159         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3160         (read_attribute_value): Likewise.
3161         (dwarf2_read_addr_index): Update comment.
3162         (read_str_index): Add DW_FORM_strx.
3163         (dwarf2_string_attr): Likewise.
3164         (dwarf2_const_value_attr): Likewise.
3165         (dump_die_shallow): Likewise.
3166         (dwarf2_fetch_constant_bytes): Likewise.
3167         (skip_form_bytes): Likewise.
3168         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3169
3170 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3171
3172         PR corefiles/11608
3173         PR corefiles/18187
3174         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3175         OFFSET.  Verify if current mapping contains an ELF header.
3176         (linux_find_memory_regions_full): Adjust call to
3177         dump_mapping_p.
3178
3179 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3180             Kang Li <kanglictf@gmail.com>
3181
3182         PR gdb/21600
3183
3184         * dwarf2-frame.c (read_initial_length): Be consistent about using
3185         unsigned representation of length.
3186         (decode_frame_entry_1): Likewise.  Check for wraparound of
3187         end pointer as well as buffer overflow.
3188
3189 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3190
3191         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3192         "vq".
3193
3194 2019-04-24  Tom Tromey  <tromey@adacore.com>
3195
3196         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3197
3198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * s12z-tdep.c (s12z_unwind_pc): Delete.
3201         (s12z_unwind_sp): Delete.
3202         (s12z_gdbarch_init): Don't register deleted functions with
3203         gdbarch.
3204
3205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * rl78-tdep.c (rl78_unwind_sp): Delete.
3208         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3209
3210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3213         (xstormy16_unwind_pc): Delete.
3214         (xstormy16_dummy_id): Delete.
3215         (xstormy16_gdbarch_init): Don't register deleted functions with
3216         gdbarch.
3217
3218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * vax-tdep.c (vax_unwind_pc): Delete.
3221         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3222
3223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3224
3225         * v850-tdep.c (v850_unwind_sp): Delete.
3226         (v850_unwind_pc): Delete.
3227         (v850_dummy_id): Delete.
3228         (v850_gdbarch_init): Don't register deleted functions with
3229         gdbarch.
3230
3231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3232
3233         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3234         (tilegx_unwind_pc): Delete.
3235         (tilegx_unwind_dummy_id): Delete.
3236         (tilegx_gdbarch_init): Don't register deleted functions with
3237         gdbarch.
3238
3239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3242         (tic6x_dummy_id): Delete.
3243         (tic6x_gdbarch_init): Don't register deleted functions with
3244         gdbarch.
3245
3246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * sparc-tdep.c (sparc_unwind_pc): Delete.
3249         (sparc32_gdbarch_init): Don't register deleted function with
3250         gdbarch.
3251
3252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * sh-tdep.c (sh_unwind_sp): Delete.
3255         (sh_unwind_pc): Delete.
3256         (sh_dummy_id): Delete.
3257         (sh_gdbarch_init): Don't register deleted functions with
3258         gdbarch.
3259
3260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3261
3262         * score-tdep.c (score_unwind_sp): Delete.
3263         (score_unwind_pc): Delete.
3264         (score_dummy_id): Delete.
3265         (score_gdbarch_init): Don't register deleted functions with
3266         gdbarch.
3267
3268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * rx-tdep.c (rx_unwind_pc): Delete.
3271         (rx_unwind_sp): Delete.
3272         (rx_dummy_id): Delete.
3273         (rx_gdbarch_init): Don't register deleted functions with
3274         gdbarch.  Update comment.
3275
3276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3277
3278         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3279         (rs6000_dummy_id): Delete.
3280         (rs6000_gdbarch_init): Don't register deleted functions with
3281         gdbarch.
3282
3283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3284
3285         * or1k-tdep.c (or1k_dummy_id): Delete.
3286         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3287
3288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3289
3290         * nios2-tdep.c (nios2_dummy_id): Delete.
3291         (nios2_unwind_sp): Delete.
3292         (nios2_gdbarch_init): Don't register deleted functions with
3293         gdbarch.
3294
3295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         * nds32-tdep.c (nds32_dummy_id): Delete.
3298         (nds32_unwind_pc): Delete.
3299         (nds32_unwind_sp): Delete.
3300         (nds32_gdbarch_init): Don't register deleted functions with
3301         gdbarch.
3302
3303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3304
3305         * msp430-tdep.c (msp430_unwind_pc): Delete.
3306         (msp430_unwind_sp): Delete.
3307         (msp430_dummy_id): Delete.
3308         (msp430_gdbarch_init): Don't register deleted functions with
3309         gdbarch.
3310
3311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3312
3313         * moxie-tdep.c (moxie_unwind_sp): Delete.
3314         (moxie_unwind_pc): Delete.
3315         (moxie_dummy_id): Delete.
3316         (moxie_gdbarch_init): Don't register deleted functions with
3317         gdbarch.
3318
3319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3322         (mn10300_unwind_pc): Delete.
3323         (mn10300_unwind_sp): Delete.
3324         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3325         mn10300_unwind_sp.
3326         (mn10300_frame_unwind_init): Don't register deleted functions with
3327         gdbarch.
3328
3329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * mep-tdep.c (mep_unwind_pc): Delete.
3332         (mep_unwind_sp): Delete.
3333         (mep_dummy_id): Delete.
3334         (mep_gdbarch_init): Don't register deleted functions with
3335         gdbarch.
3336
3337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3340         (m68hc11_unwind_sp): Delete.
3341         (m68hc11_gdbarch_init): Don't register deleted functions with
3342         gdbarch.
3343
3344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3345
3346         * m32r-tdep.c (m32r_unwind_sp): Delete.
3347         (m32r_unwind_pc): Delete.
3348         (m32r_dummy_id): Delete.
3349         (m32r_gdbarch_init): Don't register deleted functions with
3350         gdbarch.
3351
3352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3353
3354         * m32c-tdep.c (m32c_unwind_pc): Delete.
3355         (m32c_unwind_sp): Delete.
3356         (m32c_dummy_id): Delete.
3357         (m32c_gdbarch_init): Don't register deleted functions with
3358         gdbarch.
3359
3360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3361
3362         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3363         (lm32_unwind_pc): Delete.
3364         (lm32_dummy_id): Delete.
3365         (lm32_gdbarch_init): Don't register deleted functions with
3366         gdbarch.
3367
3368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3371         (iq2000_unwind_pc): Delete.
3372         (iq2000_dummy_id): Delete.
3373         (iq2000_gdbarch_init): Don't register deleted functions with
3374         gdbarch.
3375
3376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * nds32-tdep.c (nds32_type_align): Delete.
3379         (nds32_push_dummy_call): Use type_align instead.
3380
3381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * arm-tdep.c (arm_type_align): Only handle vector override case.
3384         (arm_push_dummy_call): Use type_align.
3385         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3386
3387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3390         case.
3391         (pass_on_stack): Use type_align.
3392         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3393         function.
3394
3395 2019-04-23  Tom Tromey  <tromey@adacore.com>
3396
3397         * dwarf2read.c (line_header::file_name_at): Remove unused
3398         overload.
3399
3400 2019-04-23  Tom de Vries  <tdevries@suse.de>
3401
3402         PR gdb/24438
3403         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3404         invocation.
3405
3406
3407 2019-03-27  Ali Tamur  <tamur@google.com>
3408
3409         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3410         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3411         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3412         (dwarf_expr_context::get_addr_index): Likewise
3413         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3414         (symbol_needs_eval_context::get_addr_index): Likewise
3415         (disassemble_dwarf_expression): Add DW_OP_addrx
3416         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3417         (read_cutu_die_from_dwo): Update comment
3418         (skip_one_die): Add DW_FORM_addrx
3419         (read_attribute_value): Likewise
3420         (var_decode_location): Add DW_OP_addrx
3421         (dwarf2_const_value_attr): Add DW_FORM_addrx
3422         (dump_die_shallow): Likewise
3423         (dwarf2_fetch_constant_bytes): Likewise
3424         (decode_locdesc): Add DW_OP_addrx
3425         (skip_form_bytes): Add DW_FORM_addrx
3426
3427 2019-04-22  Ali Tamur  <tamur@google.com>
3428
3429         * MAINTAINERS (Write After Approval): Add self.
3430
3431 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3432
3433         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3434         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3435         (open_symbol_file_object): Likewise.
3436         (svr4_default_sos): Add info parameter.
3437         (svr4_read_so_list): Likewise.
3438         (svr4_current_sos_direct): Adjust functions calls to pass down
3439         info.
3440         (svr4_current_sos_1): Add info parameter.
3441         (svr4_current_sos): Call get_svr4_info, pass info down to
3442         svr4_current_sos_1.
3443         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3444         get_svr4_info.
3445         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3446         get_svr4_info.
3447         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3448         to get_svr4_info.
3449         (probes_table_remove_objfile_probes): Likewise.
3450         (register_solib_event_probe): Add info parameter.
3451         (solist_update_incremental): Pass info parameter down to
3452         svr4_read_so_list.
3453         (disable_probes_interface): Add info parameter.
3454         (svr4_handle_solib_event): Pass current_program_space to
3455         get_svr4_info.  Adjust disable_probes_interface cleanup.
3456         (svr4_create_probe_breakpoints): Add info parameter, pass it
3457         down to register_solib_event_probe.
3458         (svr4_create_solib_event_breakpoints): Add info parameter,
3459         pass it down to svr4_create_probe_breakpoints.
3460         (enable_break): Pass info down to
3461         svr4_create_solib_event_breakpoints.
3462         (svr4_solib_create_inferior_hook): Pass current_program_space to
3463         get_svr4_info.
3464         (svr4_clear_solib): Likewise.
3465
3466 2019-04-22  Pedro Alves  <palves@redhat.com>
3467
3468         * solib-svr4.c (svr4_free_objfile_observer): New.
3469         (probe_and_action::objfile): New field.
3470         (probes_table_htab_remove_objfile_probes)
3471         (probes_table_remove_objfile_probes): New functions.
3472         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3473         in the new probe_and_action.  Don't store the probe in 'lookup'.
3474         (svr4_create_probe_breakpoints): Pass objfile to
3475         register_solib_event_probe.
3476         (_initialize_svr4_solib): Register a free_objfile observer.
3477
3478 2019-04-19  Tom Tromey  <tom@tromey.com>
3479
3480         * common/queue.h: Remove.
3481
3482 2019-04-19  Tom Tromey  <tom@tromey.com>
3483
3484         * event-loop.c: Don't include "common/queue.h".
3485
3486 2019-04-19  Tom Tromey  <tom@tromey.com>
3487
3488         * remote.c (remote_target): Use delete.
3489         * remote-notif.h: Include <list>, not "common/queue.h".
3490         (notif_client_p): Remove typedef.
3491         (remote_notif_state): Add constructor, destructor, initializer.
3492         <notif_queue>: Now a std::list.
3493         (remote_notif_state_xfree): Don't declare.
3494         * remote-notif.c (remote_notif_process, handle_notification)
3495         (remote_notif_state_allocate): Update.
3496         (~remote_notif_state): Rename from remote_notif_state_xfree.
3497
3498 2019-04-19  Tom Tromey  <tom@tromey.com>
3499
3500         * symfile.c (reread_symbols): Update.
3501         * objfiles.c (objfile_register_static_link)
3502         (objfile_lookup_static_link): Update
3503         (~objfile) Don't delete static_links.
3504         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3505
3506 2019-04-19  Tom Tromey  <tom@tromey.com>
3507
3508         * type-stack.h (struct type_stack) <insert>: Constify string.
3509         * type-stack.c (type_stack::insert): Constify string.
3510         * gdbtypes.h (lookup_template_type): Update.
3511         (address_space_name_to_int): Update.
3512         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3513         const.
3514         (lookup_template_type): Make name const.
3515         * c-exp.y: Update rules.
3516         (lex_one_token, classify_name, classify_inner_name)
3517         (c_print_token): Update.
3518         * p-exp.y: Update rules.
3519         (yylex): Update.
3520         * f-exp.y: Update rules.
3521         (yylex): Update.
3522         * d-exp.y: Update rules.
3523         (lex_one_token, classify_name, classify_inner_name): Update.
3524         * parse.c (write_dollar_variable, copy_name): Return std::string.
3525         * parser-defs.h (copy_name): Change return type.
3526         * m2-exp.y: Update rules.
3527         (yylex): Update.
3528         * go-exp.y (lex_one_token): Update.
3529         Update rules.
3530         (classify_unsafe_function, classify_packaged_name)
3531         (classify_name, yylex): Update.
3532
3533 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3534
3535         * configure.ac: add --enable-source-highlight switch.
3536         * configure: Regenerate.
3537         * top.c (print_gdb_version): plumb --enable-source-highlight
3538         status to "show configuration".
3539
3540 2019-04-19  Tom Tromey  <tromey@adacore.com>
3541
3542         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3543         Check ADA_TYPE_P.
3544         (empty_record, ada_template_to_fixed_record_type_1)
3545         (template_to_static_fixed_type)
3546         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3547         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3548         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3549         macros.
3550
3551 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3552
3553         PR symtab/24423:
3554         * source.c (print_source_lines_base): Advance "iter" when a
3555         control character is seen.
3556
3557 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3558
3559         * inferior.h (struct infcall_suspend_state_deleter):
3560         Catch exception in destructor to avoid crash.
3561
3562 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3563
3564         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3565         close to the add_com "shell".
3566
3567 2019-04-18  Tom Tromey  <tromey@adacore.com>
3568
3569         * process-stratum-target.h (class process_stratum_target)
3570         <stratum>: Add "final".
3571
3572 2019-04-17  Tom Tromey  <tromey@adacore.com>
3573
3574         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3575         against nullptr before use.
3576
3577 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3578
3579         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3580
3581 2019-04-17  Jim Wilson  <jimw@sifive.com>
3582             Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3585         code read might fail, assume 4-byte breakpoint in that case.
3586
3587 2019-04-15  Leszek Swirski  <leszeks@google.com>
3588
3589         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3590         rather than a hand-rolled POD check when checking for forced MEMORY
3591         classification.
3592
3593 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3594
3595         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3596         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3597         function.
3598         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3599         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3600         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3601         declaration.
3602
3603 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3604
3605         * aarch64-linux-nat.c
3606         (aarch64_linux_nat_target::thread_architecture): Add override.
3607         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3608         each VQ.
3609
3610 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3611
3612         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3613
3614 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3617         target types of size 96-bits, add some additional comments, and
3618         check that the builtin type we found was the correct size.
3619
3620 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3621
3622         * utils.c (prompt_for_continue): Don't restore the styling at the
3623         end, as applied_style has the wrong value.  This fixes styling in
3624         long lists of file names that are interrupted by the "Continue?"
3625         prompt.
3626
3627 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3630         * c-lang.c (c_language_defn): Likewise.
3631         (cplus_language_defn): Likewise.
3632         (asm_language_defn): Likewise.
3633         (minimal_language_defn): Likewise.
3634         * d-lang.c (d_language_defn): Likewise.
3635         * f-lang.c (f_language_defn): Likewise.
3636         * go-lang.c (go_language_defn): Likewise.
3637         * language.c (unknown_language_defn): Likewise.
3638         (auto_language_defn): Likewise.
3639         * language.h (struct language_defn): Remove la_magic field.
3640         (LANG_MAGIC): Delete.
3641         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3642         * objc-lang.c (objc_language_defn): Likewise.
3643         * opencl-lang.c (opencl_language_defn): Likewise.
3644         * p-lang.c (pascal_language_defn): Likewise.
3645         * rust-lang.c (rust_language_defn): Likewise.
3646
3647 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3648
3649         * riscv-tdep.c (riscv_type_align): New function.
3650         (riscv_type_alignment): Delete.
3651         (riscv_arg_location): Use 'type_align'.
3652         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3653
3654 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * gdbtypes.c (type_align): A struct with no non-static fields also
3657         has alignment of 1.
3658
3659 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3660
3661         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3662         component to 0.
3663         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3664         member.
3665         (riscv_struct_info::analyse): New implementation using new
3666         analyse_inner member function.
3667         (riscv_struct_info::field_offset): New member function.
3668         (riscv_struct_info::m_offsets): New member variable.
3669         (riscv_struct_info::analyse_inner): New private member function,
3670         takes the old implementation of riscv_struct_info::analyse but
3671         extended to track field offsets.
3672         (riscv_call_arg_struct): Update the struct folding special cases
3673         to handle cases where empty C++ structs, which are non-zero
3674         length, are found.
3675         (riscv_arg_location): Initialise the length of each location, a
3676         non-zero length now indicates the location is in use.
3677         (riscv_push_dummy_call): Allow for the first location having a
3678         non-zero offset when setting up arguments.
3679         (riscv_return_value): Likewise, but for return values.
3680
3681 2019-04-11  Tom Tromey  <tromey@adacore.com>
3682
3683         * utils.c (internal_vproblem): Make "msg" const.
3684
3685 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3686
3687         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3688         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3689         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3690         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3691
3692 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3693
3694         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3695         function.
3696         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3697         of amd64_collect_native_gregset.
3698         (amd64_linux_nat_target::store_registers): Likewise.
3699
3700 2019-04-10  Tom Tromey  <tom@tromey.com>
3701
3702         * symtab.c (lookup_global_symbol_from_objfile)
3703         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3704         * objfiles.h (class separate_debug_iterator): New.
3705         (class separate_debug_range): New.
3706         (struct objfile) <separate_debug_objfiles>: New method.
3707         (objfile_separate_debug_iterate): Don't declare.
3708         * objfiles.c (separate_debug_iterator::operator++): Rename from
3709         objfile_separate_debug_iterate.
3710         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3711         iterator.
3712         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3713         iterator.
3714
3715 2019-04-10  Tom Tromey  <tom@tromey.com>
3716
3717         * symfile.c (reread_symbols): Remove old comment.
3718         * objfiles.c (free_all_objfiles): Fix a typo.
3719
3720 2019-04-10  Tom Tromey  <tom@tromey.com>
3721
3722         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3723         * minsyms.c (lookup_minimal_symbol): Use foreach.
3724         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3725         (lookup_minimal_symbol_solib_trampoline): Likewise.
3726         * symfile.c (reread_symbols): Use foreach.
3727
3728 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3729             Tom Tromey  <tromey@adacore.com>
3730
3731         PR rust/24414:
3732         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3733         (rust_lex_int_test): Change "value" to be LONGEST.
3734         (rust_lex_tests): Add test for long integer literal.
3735
3736 2019-04-09  Tom Tromey  <tromey@adacore.com>
3737
3738         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3739         to bool.
3740         (extended_remote_target::attach): Update.
3741         (remote_target::remote_notice_new_inferior): Update.
3742         (remote_target::add_current_inferior_and_thread): Update.
3743         * inferior.c (exit_inferior_1): Use "false".
3744         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3745
3746 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3747
3748         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3749         the "start" command.
3750
3751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3752
3753         * python/py-inferior.c (infpy_thread_from_thread_handle):
3754         Adjust comments to reflect renaming of thread_from_thread_handle
3755         to thread_from_handle.  Adjust keywords.  Fix type error message.
3756         (inferior_object_methods): Add thread_from_handle.  Retain
3757         thread_from_thread_handle, but mark it as deprecated.
3758
3759 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3760
3761         * gdbthread.h (find_thread_by_handle): Revise declaration.
3762         * thread.c (find_thread_by_handle): Likewise.  Adjust
3763         implementation too.
3764         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3765         support for buffer objects as handles.
3766
3767 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3768
3769         * python/py-infthread.c (thpy_thread_handle): New function.
3770         (thread_object_methods): Register thpy_thread_handle.
3771
3772 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3773
3774         * gdbthread.h (thread_to_thread_handle): Declare.
3775         * thread.c (gdbtypes.h): Include.
3776         (thread_to_thread_handle): New function.
3777
3778         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3779         (target_thread_info_to_thread_handle): Declare.
3780         * target.c (target_thread_info_to_thread_handle): New function.
3781         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3782         * target-delegates.c: Regenerate.
3783
3784         * linux-thread-db.c (class thread_db_target): Add method
3785         thread_info_to_thread_handle.
3786         (thread_db_target::thread_info_to_thread_handle): Define.
3787         * remote.c (class remote_target): Add new method
3788         thread_info_to_thread_handle.
3789         (remote_target::thread_info_to_thread_handle): Define.
3790
3791 2019-04-08  Pedro Alves  <palves@redhat.com>
3792
3793         * common/common-exceptions.c (throw_exception): Don't create
3794         named object to throw; throw directly.
3795         (throw_it): Likewise.  Don't initialize gdb_exception::message
3796         here, with new; pass FMT and AP to the ctor instead.
3797         * common/common-exceptions.h: Include <string>.
3798         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3799         const char *, va_list)): New ctor.  Use std::make_shared.
3800         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3801         errors)): Delete.
3802         (gdb_exception_error::gdb_exception_error(enum errors, const char
3803         *, va_list)): New.
3804         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3805         Add assertion.
3806         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3807         errors)): Delete.
3808         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3809         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3810         Add assertion.
3811
3812 2019-04-08  Tom Tromey  <tom@tromey.com>
3813
3814         * valops.c (value_rtti_indirect_type): Replace throw_exception
3815         with throw.
3816         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3817         with throw.
3818         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3819         throw.
3820         * target.c (target_translate_tls_address): Replace throw_exception
3821         with throw.
3822         * stack.c (frame_apply_command_count): Replace throw_exception
3823         with throw.
3824         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3825         throw.
3826         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3827         with throw.
3828         * rs6000-tdep.c (rs6000_frame_cache)
3829         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3830         * remote.c: Replace throw_exception with throw.
3831         * record-full.c (record_full_message, record_full_wait_1)
3832         (record_full_restore): Replace throw_exception with throw.
3833         * record-btrace.c:
3834         (get_thread_current_frame_id, record_btrace_start_replaying)
3835         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3836         (cmd_record_btrace_start): Replace throw_exception with throw.
3837         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3838         throw.
3839         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3840         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3841         * linespec.c:
3842         (find_linespec_symbols): Replace throw_exception with throw.
3843         * infrun.c (displaced_step_prepare, resume): Replace
3844         throw_exception with throw.
3845         * infcmd.c (post_create_inferior): Replace throw_exception with
3846         throw.
3847         * inf-loop.c (inferior_event_handler): Replace throw_exception
3848         with throw.
3849         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3850         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3851         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3852         (get_prev_frame_always, get_frame_pc_if_available)
3853         (get_frame_address_in_block_if_available, get_frame_language):
3854         Replace throw_exception with throw.
3855         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3856         throw_exception with throw.
3857         * eval.c (fetch_subexp_value, evaluate_var_value)
3858         (evaluate_funcall, evaluate_subexp_standard): Replace
3859         throw_exception with throw.
3860         * dwarf2loc.c (call_site_find_chain)
3861         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3862         Replace throw_exception with throw.
3863         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3864         with throw.
3865         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3866         throw.
3867         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3868         * completer.c (complete_line_internal): Replace throw_exception
3869         with throw.
3870         * compile/compile-object-run.c (compile_object_run): Replace
3871         throw_exception with throw.
3872         * cli/cli-script.c (process_next_line): Replace throw_exception
3873         with throw.
3874         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3875         (btrace_enable, btrace_maint_update_pt_packets): Replace
3876         throw_exception with throw.
3877         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3878         throw_exception with throw.
3879         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3880         throw_exception with throw.
3881         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3882         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3883         * aarch64-tdep.c (aarch64_make_prologue_cache)
3884         (aarch64_make_stub_cache): Replace throw_exception with throw.
3885
3886 2019-04-08  Tom Tromey  <tom@tromey.com>
3887
3888         * common/common-exceptions.c (throw_exception): Rename from
3889         throw_exception_cxx.  Remove old copy.  Make argument const.
3890         (throw_it): Create and throw exception objects directly.
3891         * common/common-exceptions.h (throw_exception): Make argument
3892         const.
3893         (struct gdb_exception_error): Add constructor.
3894         (struct gdb_exception_quit): Add constructor.
3895
3896 2019-04-08  Tom Tromey  <tom@tromey.com>
3897
3898         * common/common-exceptions.h (exception_rethrow): Don't declare.
3899         (TRY_SJLJ): Update comment.
3900         (TRY, CATCH, END_CATCH): Remove.
3901         * common/common-exceptions.c (exception_rethrow): Remove.
3902
3903 2019-04-08  Tom Tromey  <tom@tromey.com>
3904
3905         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3906         Remove.
3907         (gdb_exception_error): Rename from
3908         gdb_exception_RETURN_MASK_ERROR.
3909         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3910         (gdb_quit_bad_alloc): Update.
3911         * aarch64-tdep.c: Update.
3912         * ada-lang.c: Update.
3913         * ada-typeprint.c: Update.
3914         * ada-valprint.c: Update.
3915         * amd64-tdep.c: Update.
3916         * arch-utils.c: Update.
3917         * break-catch-throw.c: Update.
3918         * breakpoint.c: Update.
3919         * btrace.c: Update.
3920         * c-varobj.c: Update.
3921         * cli/cli-cmds.c: Update.
3922         * cli/cli-interp.c: Update.
3923         * cli/cli-script.c: Update.
3924         * common/common-exceptions.c: Update.
3925         * common/new-op.c: Update.
3926         * common/selftest.c: Update.
3927         * compile/compile-c-symbols.c: Update.
3928         * compile/compile-cplus-symbols.c: Update.
3929         * compile/compile-object-load.c: Update.
3930         * compile/compile-object-run.c: Update.
3931         * completer.c: Update.
3932         * corelow.c: Update.
3933         * cp-abi.c: Update.
3934         * cp-support.c: Update.
3935         * cp-valprint.c: Update.
3936         * darwin-nat.c: Update.
3937         * disasm-selftests.c: Update.
3938         * dtrace-probe.c: Update.
3939         * dwarf-index-cache.c: Update.
3940         * dwarf-index-write.c: Update.
3941         * dwarf2-frame-tailcall.c: Update.
3942         * dwarf2-frame.c: Update.
3943         * dwarf2loc.c: Update.
3944         * dwarf2read.c: Update.
3945         * eval.c: Update.
3946         * event-loop.c: Update.
3947         * event-top.c: Update.
3948         * exec.c: Update.
3949         * f-valprint.c: Update.
3950         * fbsd-tdep.c: Update.
3951         * frame-unwind.c: Update.
3952         * frame.c: Update.
3953         * gdbtypes.c: Update.
3954         * gnu-v3-abi.c: Update.
3955         * guile/guile-internal.h: Update.
3956         * guile/scm-block.c: Update.
3957         * guile/scm-breakpoint.c: Update.
3958         * guile/scm-cmd.c: Update.
3959         * guile/scm-disasm.c: Update.
3960         * guile/scm-frame.c: Update.
3961         * guile/scm-lazy-string.c: Update.
3962         * guile/scm-math.c: Update.
3963         * guile/scm-param.c: Update.
3964         * guile/scm-ports.c: Update.
3965         * guile/scm-pretty-print.c: Update.
3966         * guile/scm-symbol.c: Update.
3967         * guile/scm-symtab.c: Update.
3968         * guile/scm-type.c: Update.
3969         * guile/scm-value.c: Update.
3970         * i386-linux-tdep.c: Update.
3971         * i386-tdep.c: Update.
3972         * inf-loop.c: Update.
3973         * infcall.c: Update.
3974         * infcmd.c: Update.
3975         * infrun.c: Update.
3976         * jit.c: Update.
3977         * language.c: Update.
3978         * linespec.c: Update.
3979         * linux-fork.c: Update.
3980         * linux-nat.c: Update.
3981         * linux-tdep.c: Update.
3982         * linux-thread-db.c: Update.
3983         * main.c: Update.
3984         * mi/mi-cmd-break.c: Update.
3985         * mi/mi-cmd-stack.c: Update.
3986         * mi/mi-interp.c: Update.
3987         * mi/mi-main.c: Update.
3988         * objc-lang.c: Update.
3989         * p-valprint.c: Update.
3990         * parse.c: Update.
3991         * ppc-linux-tdep.c: Update.
3992         * printcmd.c: Update.
3993         * python/py-arch.c: Update.
3994         * python/py-breakpoint.c: Update.
3995         * python/py-cmd.c: Update.
3996         * python/py-finishbreakpoint.c: Update.
3997         * python/py-frame.c: Update.
3998         * python/py-framefilter.c: Update.
3999         * python/py-gdb-readline.c: Update.
4000         * python/py-inferior.c: Update.
4001         * python/py-infthread.c: Update.
4002         * python/py-lazy-string.c: Update.
4003         * python/py-linetable.c: Update.
4004         * python/py-objfile.c: Update.
4005         * python/py-param.c: Update.
4006         * python/py-prettyprint.c: Update.
4007         * python/py-progspace.c: Update.
4008         * python/py-record-btrace.c: Update.
4009         * python/py-record.c: Update.
4010         * python/py-symbol.c: Update.
4011         * python/py-type.c: Update.
4012         * python/py-unwind.c: Update.
4013         * python/py-utils.c: Update.
4014         * python/py-value.c: Update.
4015         * python/python.c: Update.
4016         * record-btrace.c: Update.
4017         * record-full.c: Update.
4018         * remote-fileio.c: Update.
4019         * remote.c: Update.
4020         * riscv-tdep.c: Update.
4021         * rs6000-aix-tdep.c: Update.
4022         * rs6000-tdep.c: Update.
4023         * rust-exp.y: Update.
4024         * rust-lang.c: Update.
4025         * s390-tdep.c: Update.
4026         * selftest-arch.c: Update.
4027         * solib-dsbt.c: Update.
4028         * solib-frv.c: Update.
4029         * solib-spu.c: Update.
4030         * solib-svr4.c: Update.
4031         * solib.c: Update.
4032         * sparc64-linux-tdep.c: Update.
4033         * stack.c: Update.
4034         * symfile-mem.c: Update.
4035         * symmisc.c: Update.
4036         * target.c: Update.
4037         * thread.c: Update.
4038         * top.c: Update.
4039         * tracefile-tfile.c: Update.
4040         * tui/tui.c: Update.
4041         * typeprint.c: Update.
4042         * unittests/cli-utils-selftests.c: Update.
4043         * unittests/parse-connection-spec-selftests.c: Update.
4044         * valops.c: Update.
4045         * valprint.c: Update.
4046         * value.c: Update.
4047         * varobj.c: Update.
4048         * windows-nat.c: Update.
4049         * x86-linux-nat.c: Update.
4050         * xml-support.c: Update.
4051
4052 2019-04-08  Tom Tromey  <tom@tromey.com>
4053
4054         * xml-support.c: Use C++ exception handling.
4055         * x86-linux-nat.c: Use C++ exception handling.
4056         * windows-nat.c: Use C++ exception handling.
4057         * varobj.c: Use C++ exception handling.
4058         * value.c: Use C++ exception handling.
4059         * valprint.c: Use C++ exception handling.
4060         * valops.c: Use C++ exception handling.
4061         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4062         handling.
4063         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4064         * typeprint.c: Use C++ exception handling.
4065         * tui/tui.c: Use C++ exception handling.
4066         * tracefile-tfile.c: Use C++ exception handling.
4067         * top.c: Use C++ exception handling.
4068         * thread.c: Use C++ exception handling.
4069         * target.c: Use C++ exception handling.
4070         * symmisc.c: Use C++ exception handling.
4071         * symfile-mem.c: Use C++ exception handling.
4072         * stack.c: Use C++ exception handling.
4073         * sparc64-linux-tdep.c: Use C++ exception handling.
4074         * solib.c: Use C++ exception handling.
4075         * solib-svr4.c: Use C++ exception handling.
4076         * solib-spu.c: Use C++ exception handling.
4077         * solib-frv.c: Use C++ exception handling.
4078         * solib-dsbt.c: Use C++ exception handling.
4079         * selftest-arch.c: Use C++ exception handling.
4080         * s390-tdep.c: Use C++ exception handling.
4081         * rust-lang.c: Use C++ exception handling.
4082         * rust-exp.y: Use C++ exception handling.
4083         * rs6000-tdep.c: Use C++ exception handling.
4084         * rs6000-aix-tdep.c: Use C++ exception handling.
4085         * riscv-tdep.c: Use C++ exception handling.
4086         * remote.c: Use C++ exception handling.
4087         * remote-fileio.c: Use C++ exception handling.
4088         * record-full.c: Use C++ exception handling.
4089         * record-btrace.c: Use C++ exception handling.
4090         * python/python.c: Use C++ exception handling.
4091         * python/py-value.c: Use C++ exception handling.
4092         * python/py-utils.c: Use C++ exception handling.
4093         * python/py-unwind.c: Use C++ exception handling.
4094         * python/py-type.c: Use C++ exception handling.
4095         * python/py-symbol.c: Use C++ exception handling.
4096         * python/py-record.c: Use C++ exception handling.
4097         * python/py-record-btrace.c: Use C++ exception handling.
4098         * python/py-progspace.c: Use C++ exception handling.
4099         * python/py-prettyprint.c: Use C++ exception handling.
4100         * python/py-param.c: Use C++ exception handling.
4101         * python/py-objfile.c: Use C++ exception handling.
4102         * python/py-linetable.c: Use C++ exception handling.
4103         * python/py-lazy-string.c: Use C++ exception handling.
4104         * python/py-infthread.c: Use C++ exception handling.
4105         * python/py-inferior.c: Use C++ exception handling.
4106         * python/py-gdb-readline.c: Use C++ exception handling.
4107         * python/py-framefilter.c: Use C++ exception handling.
4108         * python/py-frame.c: Use C++ exception handling.
4109         * python/py-finishbreakpoint.c: Use C++ exception handling.
4110         * python/py-cmd.c: Use C++ exception handling.
4111         * python/py-breakpoint.c: Use C++ exception handling.
4112         * python/py-arch.c: Use C++ exception handling.
4113         * printcmd.c: Use C++ exception handling.
4114         * ppc-linux-tdep.c: Use C++ exception handling.
4115         * parse.c: Use C++ exception handling.
4116         * p-valprint.c: Use C++ exception handling.
4117         * objc-lang.c: Use C++ exception handling.
4118         * mi/mi-main.c: Use C++ exception handling.
4119         * mi/mi-interp.c: Use C++ exception handling.
4120         * mi/mi-cmd-stack.c: Use C++ exception handling.
4121         * mi/mi-cmd-break.c: Use C++ exception handling.
4122         * main.c: Use C++ exception handling.
4123         * linux-thread-db.c: Use C++ exception handling.
4124         * linux-tdep.c: Use C++ exception handling.
4125         * linux-nat.c: Use C++ exception handling.
4126         * linux-fork.c: Use C++ exception handling.
4127         * linespec.c: Use C++ exception handling.
4128         * language.c: Use C++ exception handling.
4129         * jit.c: Use C++ exception handling.
4130         * infrun.c: Use C++ exception handling.
4131         * infcmd.c: Use C++ exception handling.
4132         * infcall.c: Use C++ exception handling.
4133         * inf-loop.c: Use C++ exception handling.
4134         * i386-tdep.c: Use C++ exception handling.
4135         * i386-linux-tdep.c: Use C++ exception handling.
4136         * guile/scm-value.c: Use C++ exception handling.
4137         * guile/scm-type.c: Use C++ exception handling.
4138         * guile/scm-symtab.c: Use C++ exception handling.
4139         * guile/scm-symbol.c: Use C++ exception handling.
4140         * guile/scm-pretty-print.c: Use C++ exception handling.
4141         * guile/scm-ports.c: Use C++ exception handling.
4142         * guile/scm-param.c: Use C++ exception handling.
4143         * guile/scm-math.c: Use C++ exception handling.
4144         * guile/scm-lazy-string.c: Use C++ exception handling.
4145         * guile/scm-frame.c: Use C++ exception handling.
4146         * guile/scm-disasm.c: Use C++ exception handling.
4147         * guile/scm-cmd.c: Use C++ exception handling.
4148         * guile/scm-breakpoint.c: Use C++ exception handling.
4149         * guile/scm-block.c: Use C++ exception handling.
4150         * guile/guile-internal.h: Use C++ exception handling.
4151         * gnu-v3-abi.c: Use C++ exception handling.
4152         * gdbtypes.c: Use C++ exception handling.
4153         * frame.c: Use C++ exception handling.
4154         * frame-unwind.c: Use C++ exception handling.
4155         * fbsd-tdep.c: Use C++ exception handling.
4156         * f-valprint.c: Use C++ exception handling.
4157         * exec.c: Use C++ exception handling.
4158         * event-top.c: Use C++ exception handling.
4159         * event-loop.c: Use C++ exception handling.
4160         * eval.c: Use C++ exception handling.
4161         * dwarf2read.c: Use C++ exception handling.
4162         * dwarf2loc.c: Use C++ exception handling.
4163         * dwarf2-frame.c: Use C++ exception handling.
4164         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4165         * dwarf-index-write.c: Use C++ exception handling.
4166         * dwarf-index-cache.c: Use C++ exception handling.
4167         * dtrace-probe.c: Use C++ exception handling.
4168         * disasm-selftests.c: Use C++ exception handling.
4169         * darwin-nat.c: Use C++ exception handling.
4170         * cp-valprint.c: Use C++ exception handling.
4171         * cp-support.c: Use C++ exception handling.
4172         * cp-abi.c: Use C++ exception handling.
4173         * corelow.c: Use C++ exception handling.
4174         * completer.c: Use C++ exception handling.
4175         * compile/compile-object-run.c: Use C++ exception handling.
4176         * compile/compile-object-load.c: Use C++ exception handling.
4177         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4178         * compile/compile-c-symbols.c: Use C++ exception handling.
4179         * common/selftest.c: Use C++ exception handling.
4180         * common/new-op.c: Use C++ exception handling.
4181         * cli/cli-script.c: Use C++ exception handling.
4182         * cli/cli-interp.c: Use C++ exception handling.
4183         * cli/cli-cmds.c: Use C++ exception handling.
4184         * c-varobj.c: Use C++ exception handling.
4185         * btrace.c: Use C++ exception handling.
4186         * breakpoint.c: Use C++ exception handling.
4187         * break-catch-throw.c: Use C++ exception handling.
4188         * arch-utils.c: Use C++ exception handling.
4189         * amd64-tdep.c: Use C++ exception handling.
4190         * ada-valprint.c: Use C++ exception handling.
4191         * ada-typeprint.c: Use C++ exception handling.
4192         * ada-lang.c: Use C++ exception handling.
4193         * aarch64-tdep.c: Use C++ exception handling.
4194
4195 2019-04-08  Tom Tromey  <tom@tromey.com>
4196
4197         * xml-support.c (gdb_xml_parser::parse): Update.
4198         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4199         * value.c (show_convenience): Update.
4200         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4201         (test_parse_flags_qcs): Update.
4202         * thread.c (thr_try_catch_cmd): Update.
4203         * target.c (target_translate_tls_address): Update.
4204         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4205         (info_frame_command_core, frame_apply_command_count): Update.
4206         * rust-exp.y (rust_lex_exception_test): Update.
4207         * riscv-tdep.c (riscv_print_one_register_info): Update.
4208         * remote.c (remote_target::enable_btrace): Update.
4209         * record-btrace.c (record_btrace_enable_warn): Update.
4210         * python/py-utils.c (gdbpy_convert_exception): Update.
4211         * printcmd.c (do_one_display, print_variable_and_value): Update.
4212         * mi/mi-main.c (mi_print_exception): Update.
4213         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4214         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4215         * linux-nat.c (linux_nat_target::attach): Update.
4216         * linux-fork.c (class scoped_switch_fork_info): Update.
4217         * infrun.c (displaced_step_prepare): Update.
4218         * infcall.c (call_function_by_hand_dummy): Update.
4219         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4220         * gnu-v3-abi.c (print_one_vtable): Update.
4221         * frame.c (get_prev_frame_always): Update.
4222         * f-valprint.c (info_common_command_for_block): Update.
4223         * exec.c (try_open_exec_file): Update.
4224         * exceptions.c (print_exception, exception_print)
4225         (exception_fprintf, exception_print_same): Update.
4226         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4227         * dwarf-index-cache.c (index_cache::store)
4228         (index_cache::lookup_gdb_index): Update.
4229         * darwin-nat.c (maybe_cache_shell): Update.
4230         * cp-valprint.c (cp_print_value_fields): Update.
4231         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4232         (gcc_cplus_symbol_address): Update.
4233         * compile/compile-c-symbols.c (gcc_convert_symbol)
4234         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4235         * common/selftest.c: Update.
4236         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4237         a std::string.
4238         (exception_try_scope_entry, exception_try_scope_exit): Don't
4239         declare.
4240         (struct exception_try_scope): Remove.
4241         (TRY): Don't use exception_try_scope.
4242         (struct gdb_exception): Add constructor, operator=.
4243         <what>: New method.
4244         (struct gdb_exception_RETURN_MASK_ALL)
4245         (struct gdb_exception_RETURN_MASK_ERROR)
4246         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4247         (struct gdb_quit_bad_alloc): Update.
4248         * common/common-exceptions.c (exception_none): Change
4249         initializer.
4250         (struct catcher) <state, exception>: Initialize inline.
4251         <prev>: Remove member.
4252         (current_catcher): Remove.
4253         (catchers): New global.
4254         (exceptions_state_mc_init): Simplify.
4255         (catcher_pop): Remove.
4256         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4257         (try_scope_depth, exception_try_scope_entry)
4258         (exception_try_scope_exit): Remove.
4259         (throw_exception_sjlj): Update.
4260         (exception_messages, exception_messages_size): Remove.
4261         (throw_it): Simplify.
4262         (gdb_exception_sliced_copy): Remove.
4263         (throw_exception_cxx): Update.
4264         * cli/cli-script.c (script_from_file): Update.
4265         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4266         Update.
4267         * ada-valprint.c (ada_val_print): Update.
4268         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4269         (create_excep_cond_exprs): Update.
4270
4271 2019-04-08  Tom Tromey  <tom@tromey.com>
4272
4273         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4274         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4275         (TRY, CATCH, END_CATCH): Remove some definitions.
4276         * common/common-exceptions.c: Don't use GDB_XCPT.
4277         (catcher_list_size): Remove.
4278         (throw_exception, throw_it): Simplify.
4279
4280 2019-04-05  Tom Tromey  <tom@tromey.com>
4281
4282         Revert the header-sorting patch.
4283         * ft32-tdep.c: Revert.
4284         * frv-tdep.c: Revert.
4285         * frv-linux-tdep.c: Revert.
4286         * frame.c: Revert.
4287         * frame-unwind.c: Revert.
4288         * frame-base.c: Revert.
4289         * fork-child.c: Revert.
4290         * findvar.c: Revert.
4291         * findcmd.c: Revert.
4292         * filesystem.c: Revert.
4293         * filename-seen-cache.h: Revert.
4294         * filename-seen-cache.c: Revert.
4295         * fbsd-tdep.c: Revert.
4296         * fbsd-nat.h: Revert.
4297         * fbsd-nat.c: Revert.
4298         * f-valprint.c: Revert.
4299         * f-typeprint.c: Revert.
4300         * f-lang.c: Revert.
4301         * extension.h: Revert.
4302         * extension.c: Revert.
4303         * extension-priv.h: Revert.
4304         * expprint.c: Revert.
4305         * exec.h: Revert.
4306         * exec.c: Revert.
4307         * exceptions.c: Revert.
4308         * event-top.c: Revert.
4309         * event-loop.c: Revert.
4310         * eval.c: Revert.
4311         * elfread.c: Revert.
4312         * dwarf2read.h: Revert.
4313         * dwarf2read.c: Revert.
4314         * dwarf2loc.c: Revert.
4315         * dwarf2expr.h: Revert.
4316         * dwarf2expr.c: Revert.
4317         * dwarf2-frame.c: Revert.
4318         * dwarf2-frame-tailcall.c: Revert.
4319         * dwarf-index-write.h: Revert.
4320         * dwarf-index-write.c: Revert.
4321         * dwarf-index-common.c: Revert.
4322         * dwarf-index-cache.h: Revert.
4323         * dwarf-index-cache.c: Revert.
4324         * dummy-frame.c: Revert.
4325         * dtrace-probe.c: Revert.
4326         * disasm.h: Revert.
4327         * disasm.c: Revert.
4328         * disasm-selftests.c: Revert.
4329         * dictionary.c: Revert.
4330         * dicos-tdep.c: Revert.
4331         * demangle.c: Revert.
4332         * dcache.h: Revert.
4333         * dcache.c: Revert.
4334         * darwin-nat.h: Revert.
4335         * darwin-nat.c: Revert.
4336         * darwin-nat-info.c: Revert.
4337         * d-valprint.c: Revert.
4338         * d-namespace.c: Revert.
4339         * d-lang.c: Revert.
4340         * ctf.c: Revert.
4341         * csky-tdep.c: Revert.
4342         * csky-linux-tdep.c: Revert.
4343         * cris-tdep.c: Revert.
4344         * cris-linux-tdep.c: Revert.
4345         * cp-valprint.c: Revert.
4346         * cp-support.c: Revert.
4347         * cp-namespace.c: Revert.
4348         * cp-abi.c: Revert.
4349         * corelow.c: Revert.
4350         * corefile.c: Revert.
4351         * continuations.c: Revert.
4352         * completer.h: Revert.
4353         * completer.c: Revert.
4354         * complaints.c: Revert.
4355         * coffread.c: Revert.
4356         * coff-pe-read.c: Revert.
4357         * cli-out.h: Revert.
4358         * cli-out.c: Revert.
4359         * charset.c: Revert.
4360         * c-varobj.c: Revert.
4361         * c-valprint.c: Revert.
4362         * c-typeprint.c: Revert.
4363         * c-lang.c: Revert.
4364         * buildsym.c: Revert.
4365         * buildsym-legacy.c: Revert.
4366         * build-id.h: Revert.
4367         * build-id.c: Revert.
4368         * btrace.c: Revert.
4369         * bsd-uthread.c: Revert.
4370         * breakpoint.h: Revert.
4371         * breakpoint.c: Revert.
4372         * break-catch-throw.c: Revert.
4373         * break-catch-syscall.c: Revert.
4374         * break-catch-sig.c: Revert.
4375         * blockframe.c: Revert.
4376         * block.c: Revert.
4377         * bfin-tdep.c: Revert.
4378         * bfin-linux-tdep.c: Revert.
4379         * bfd-target.c: Revert.
4380         * bcache.c: Revert.
4381         * ax-general.c: Revert.
4382         * ax-gdb.h: Revert.
4383         * ax-gdb.c: Revert.
4384         * avr-tdep.c: Revert.
4385         * auxv.c: Revert.
4386         * auto-load.c: Revert.
4387         * arm-wince-tdep.c: Revert.
4388         * arm-tdep.c: Revert.
4389         * arm-symbian-tdep.c: Revert.
4390         * arm-pikeos-tdep.c: Revert.
4391         * arm-obsd-tdep.c: Revert.
4392         * arm-nbsd-tdep.c: Revert.
4393         * arm-nbsd-nat.c: Revert.
4394         * arm-linux-tdep.c: Revert.
4395         * arm-linux-nat.c: Revert.
4396         * arm-fbsd-tdep.c: Revert.
4397         * arm-fbsd-nat.c: Revert.
4398         * arm-bsd-tdep.c: Revert.
4399         * arch-utils.c: Revert.
4400         * arc-tdep.c: Revert.
4401         * arc-newlib-tdep.c: Revert.
4402         * annotate.h: Revert.
4403         * annotate.c: Revert.
4404         * amd64-windows-tdep.c: Revert.
4405         * amd64-windows-nat.c: Revert.
4406         * amd64-tdep.c: Revert.
4407         * amd64-sol2-tdep.c: Revert.
4408         * amd64-obsd-tdep.c: Revert.
4409         * amd64-obsd-nat.c: Revert.
4410         * amd64-nbsd-tdep.c: Revert.
4411         * amd64-nbsd-nat.c: Revert.
4412         * amd64-nat.c: Revert.
4413         * amd64-linux-tdep.c: Revert.
4414         * amd64-linux-nat.c: Revert.
4415         * amd64-fbsd-tdep.c: Revert.
4416         * amd64-fbsd-nat.c: Revert.
4417         * amd64-dicos-tdep.c: Revert.
4418         * amd64-darwin-tdep.c: Revert.
4419         * amd64-bsd-nat.c: Revert.
4420         * alpha-tdep.c: Revert.
4421         * alpha-obsd-tdep.c: Revert.
4422         * alpha-nbsd-tdep.c: Revert.
4423         * alpha-mdebug-tdep.c: Revert.
4424         * alpha-linux-tdep.c: Revert.
4425         * alpha-linux-nat.c: Revert.
4426         * alpha-bsd-tdep.c: Revert.
4427         * alpha-bsd-nat.c: Revert.
4428         * aix-thread.c: Revert.
4429         * agent.c: Revert.
4430         * addrmap.c: Revert.
4431         * ada-varobj.c: Revert.
4432         * ada-valprint.c: Revert.
4433         * ada-typeprint.c: Revert.
4434         * ada-tasks.c: Revert.
4435         * ada-lang.c: Revert.
4436         * aarch64-tdep.c: Revert.
4437         * aarch64-ravenscar-thread.c: Revert.
4438         * aarch64-newlib-tdep.c: Revert.
4439         * aarch64-linux-tdep.c: Revert.
4440         * aarch64-linux-nat.c: Revert.
4441         * aarch64-fbsd-tdep.c: Revert.
4442         * aarch64-fbsd-nat.c: Revert.
4443         * aarch32-linux-nat.c: Revert.
4444
4445 2019-04-05  Tom Tromey  <tom@tromey.com>
4446
4447         * ft32-tdep.c: Sort headers.
4448         * frv-tdep.c: Sort headers.
4449         * frv-linux-tdep.c: Sort headers.
4450         * frame.c: Sort headers.
4451         * frame-unwind.c: Sort headers.
4452         * frame-base.c: Sort headers.
4453         * fork-child.c: Sort headers.
4454         * findvar.c: Sort headers.
4455         * findcmd.c: Sort headers.
4456         * filesystem.c: Sort headers.
4457         * filename-seen-cache.h: Sort headers.
4458         * filename-seen-cache.c: Sort headers.
4459         * fbsd-tdep.c: Sort headers.
4460         * fbsd-nat.h: Sort headers.
4461         * fbsd-nat.c: Sort headers.
4462         * f-valprint.c: Sort headers.
4463         * f-typeprint.c: Sort headers.
4464         * f-lang.c: Sort headers.
4465         * extension.h: Sort headers.
4466         * extension.c: Sort headers.
4467         * extension-priv.h: Sort headers.
4468         * expprint.c: Sort headers.
4469         * exec.h: Sort headers.
4470         * exec.c: Sort headers.
4471         * exceptions.c: Sort headers.
4472         * event-top.c: Sort headers.
4473         * event-loop.c: Sort headers.
4474         * eval.c: Sort headers.
4475         * elfread.c: Sort headers.
4476         * dwarf2read.h: Sort headers.
4477         * dwarf2read.c: Sort headers.
4478         * dwarf2loc.c: Sort headers.
4479         * dwarf2expr.h: Sort headers.
4480         * dwarf2expr.c: Sort headers.
4481         * dwarf2-frame.c: Sort headers.
4482         * dwarf2-frame-tailcall.c: Sort headers.
4483         * dwarf-index-write.h: Sort headers.
4484         * dwarf-index-write.c: Sort headers.
4485         * dwarf-index-common.c: Sort headers.
4486         * dwarf-index-cache.h: Sort headers.
4487         * dwarf-index-cache.c: Sort headers.
4488         * dummy-frame.c: Sort headers.
4489         * dtrace-probe.c: Sort headers.
4490         * disasm.h: Sort headers.
4491         * disasm.c: Sort headers.
4492         * disasm-selftests.c: Sort headers.
4493         * dictionary.c: Sort headers.
4494         * dicos-tdep.c: Sort headers.
4495         * demangle.c: Sort headers.
4496         * dcache.h: Sort headers.
4497         * dcache.c: Sort headers.
4498         * darwin-nat.h: Sort headers.
4499         * darwin-nat.c: Sort headers.
4500         * darwin-nat-info.c: Sort headers.
4501         * d-valprint.c: Sort headers.
4502         * d-namespace.c: Sort headers.
4503         * d-lang.c: Sort headers.
4504         * ctf.c: Sort headers.
4505         * csky-tdep.c: Sort headers.
4506         * csky-linux-tdep.c: Sort headers.
4507         * cris-tdep.c: Sort headers.
4508         * cris-linux-tdep.c: Sort headers.
4509         * cp-valprint.c: Sort headers.
4510         * cp-support.c: Sort headers.
4511         * cp-namespace.c: Sort headers.
4512         * cp-abi.c: Sort headers.
4513         * corelow.c: Sort headers.
4514         * corefile.c: Sort headers.
4515         * continuations.c: Sort headers.
4516         * completer.h: Sort headers.
4517         * completer.c: Sort headers.
4518         * complaints.c: Sort headers.
4519         * coffread.c: Sort headers.
4520         * coff-pe-read.c: Sort headers.
4521         * cli-out.h: Sort headers.
4522         * cli-out.c: Sort headers.
4523         * charset.c: Sort headers.
4524         * c-varobj.c: Sort headers.
4525         * c-valprint.c: Sort headers.
4526         * c-typeprint.c: Sort headers.
4527         * c-lang.c: Sort headers.
4528         * buildsym.c: Sort headers.
4529         * buildsym-legacy.c: Sort headers.
4530         * build-id.h: Sort headers.
4531         * build-id.c: Sort headers.
4532         * btrace.c: Sort headers.
4533         * bsd-uthread.c: Sort headers.
4534         * breakpoint.h: Sort headers.
4535         * breakpoint.c: Sort headers.
4536         * break-catch-throw.c: Sort headers.
4537         * break-catch-syscall.c: Sort headers.
4538         * break-catch-sig.c: Sort headers.
4539         * blockframe.c: Sort headers.
4540         * block.c: Sort headers.
4541         * bfin-tdep.c: Sort headers.
4542         * bfin-linux-tdep.c: Sort headers.
4543         * bfd-target.c: Sort headers.
4544         * bcache.c: Sort headers.
4545         * ax-general.c: Sort headers.
4546         * ax-gdb.h: Sort headers.
4547         * ax-gdb.c: Sort headers.
4548         * avr-tdep.c: Sort headers.
4549         * auxv.c: Sort headers.
4550         * auto-load.c: Sort headers.
4551         * arm-wince-tdep.c: Sort headers.
4552         * arm-tdep.c: Sort headers.
4553         * arm-symbian-tdep.c: Sort headers.
4554         * arm-pikeos-tdep.c: Sort headers.
4555         * arm-obsd-tdep.c: Sort headers.
4556         * arm-nbsd-tdep.c: Sort headers.
4557         * arm-nbsd-nat.c: Sort headers.
4558         * arm-linux-tdep.c: Sort headers.
4559         * arm-linux-nat.c: Sort headers.
4560         * arm-fbsd-tdep.c: Sort headers.
4561         * arm-fbsd-nat.c: Sort headers.
4562         * arm-bsd-tdep.c: Sort headers.
4563         * arch-utils.c: Sort headers.
4564         * arc-tdep.c: Sort headers.
4565         * arc-newlib-tdep.c: Sort headers.
4566         * annotate.h: Sort headers.
4567         * annotate.c: Sort headers.
4568         * amd64-windows-tdep.c: Sort headers.
4569         * amd64-windows-nat.c: Sort headers.
4570         * amd64-tdep.c: Sort headers.
4571         * amd64-sol2-tdep.c: Sort headers.
4572         * amd64-obsd-tdep.c: Sort headers.
4573         * amd64-obsd-nat.c: Sort headers.
4574         * amd64-nbsd-tdep.c: Sort headers.
4575         * amd64-nbsd-nat.c: Sort headers.
4576         * amd64-nat.c: Sort headers.
4577         * amd64-linux-tdep.c: Sort headers.
4578         * amd64-linux-nat.c: Sort headers.
4579         * amd64-fbsd-tdep.c: Sort headers.
4580         * amd64-fbsd-nat.c: Sort headers.
4581         * amd64-dicos-tdep.c: Sort headers.
4582         * amd64-darwin-tdep.c: Sort headers.
4583         * amd64-bsd-nat.c: Sort headers.
4584         * alpha-tdep.c: Sort headers.
4585         * alpha-obsd-tdep.c: Sort headers.
4586         * alpha-nbsd-tdep.c: Sort headers.
4587         * alpha-mdebug-tdep.c: Sort headers.
4588         * alpha-linux-tdep.c: Sort headers.
4589         * alpha-linux-nat.c: Sort headers.
4590         * alpha-bsd-tdep.c: Sort headers.
4591         * alpha-bsd-nat.c: Sort headers.
4592         * aix-thread.c: Sort headers.
4593         * agent.c: Sort headers.
4594         * addrmap.c: Sort headers.
4595         * ada-varobj.c: Sort headers.
4596         * ada-valprint.c: Sort headers.
4597         * ada-typeprint.c: Sort headers.
4598         * ada-tasks.c: Sort headers.
4599         * ada-lang.c: Sort headers.
4600         * aarch64-tdep.c: Sort headers.
4601         * aarch64-ravenscar-thread.c: Sort headers.
4602         * aarch64-newlib-tdep.c: Sort headers.
4603         * aarch64-linux-tdep.c: Sort headers.
4604         * aarch64-linux-nat.c: Sort headers.
4605         * aarch64-fbsd-tdep.c: Sort headers.
4606         * aarch64-fbsd-nat.c: Sort headers.
4607         * aarch32-linux-nat.c: Sort headers.
4608
4609 2019-04-04  Tom Tromey  <tom@tromey.com>
4610
4611         * varobj.c (varobj_create): Update.
4612         * rust-exp.y (struct rust_parser) <update_innermost_block,
4613         lookup_symbol>: New methods.
4614         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4615         Rename.
4616         (rust_parser::rust_lookup_type)
4617         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4618         * printcmd.c (display_command, do_one_display): Update.
4619         * parser-defs.h (struct parser_state) <parser_state>: Add
4620         "tracker" parameter.
4621         (block_tracker): New member.
4622         (class innermost_block_tracker) <innermost_block_tracker>: Add
4623         "types" parameter.
4624         <reset>: Remove method.
4625         (innermost_block): Don't declare.
4626         (null_post_parser): Update.
4627         * parse.c (innermost_block): Remove global.
4628         (write_dollar_variable): Update.
4629         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4630         Remove "tracker_types" parameter.
4631         (parse_expression): Add "tracker" parameter.
4632         (parse_expression_for_completion): Update.
4633         (null_post_parser): Add "tracker" parameter.
4634         * p-exp.y: Update rules.
4635         * m2-exp.y: Update rules.
4636         * language.h (struct language_defn) <la_post_parser>: Add
4637         "tracker" parameter.
4638         * go-exp.y: Update rules.
4639         * f-exp.y: Update rules.
4640         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4641         parameter.
4642         * d-exp.y: Update rules.
4643         * c-exp.y: Update rules.
4644         * breakpoint.c (set_breakpoint_condition): Create an
4645         innermost_block_tracker.
4646         (watch_command_1): Likewise.
4647         * ada-lang.c (resolve): Add "tracker" parameter.
4648         (resolve_subexp): Likewise.
4649         * ada-exp.y (write_var_from_sym): Update.
4650
4651 2019-04-04  Tom Tromey  <tom@tromey.com>
4652
4653         * type-stack.h: New file.
4654         * type-stack.c: New file.
4655         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4656         type-stack.h.
4657         (insert_into_type_stack, insert_type, push_type, push_type_int)
4658         (insert_type_address_space, pop_type, pop_type_int)
4659         (pop_typelist, pop_type_stack, append_type_stack)
4660         (push_type_stack, get_type_stack, push_typelist)
4661         (follow_type_instance_flags, follow_types): Don't declare.
4662         * parse.c (type_stack): Remove global.
4663         (parse_exp_in_context): Update.
4664         (insert_into_type_stack, insert_type, push_type, push_type_int)
4665         (insert_type_address_space, pop_type, pop_type_int)
4666         (pop_typelist, pop_type_stack, append_type_stack)
4667         (push_type_stack, get_type_stack, push_typelist)
4668         (follow_type_instance_flags, follow_types): Remove (moved to
4669         type-stack.c).
4670         * f-exp.y (type_stack): New global.
4671         Update rules.
4672         (push_kind_type, f_parse): Update.
4673         * d-exp.y (type_stack): New global.
4674         Update rules.
4675         (d_parse): Update.
4676         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4677         Update rules.
4678         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4679         (HFILES_NO_SRCDIR): Add type-stack.h.
4680
4681 2019-04-04  Tom Tromey  <tom@tromey.com>
4682
4683         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4684         (rust_parser::convert_ast_to_expression, rust_parse)
4685         (rust_lex_test_completion, rust_lex_tests): Update.
4686         * parser-defs.h (struct expr_completion_state): New.
4687         (struct parser_state) <parser_state>: Add completion parameter.
4688         <mark_struct_expression, mark_completion_tag>: New methods.
4689         <parse_completion, m_completion_state>: New members.
4690         (prefixify_expression, null_post_parser): Update.
4691         (mark_struct_expression, mark_completion_tag): Don't declare.
4692         * parse.c (parse_completion, expout_last_struct)
4693         (expout_tag_completion_type, expout_completion_name): Remove
4694         globals.
4695         (parser_state::mark_struct_expression)
4696         (parser_state::mark_completion_tag): Now methods.
4697         (prefixify_expression): Add last_struct parameter.
4698         (prefixify_subexp): Likewise.
4699         (parse_exp_1): Update.
4700         (parse_exp_in_context): Add cstate parameter.  Update.
4701         (parse_expression_for_completion): Create an
4702         expr_completion_state.
4703         (null_post_parser): Add "completion" parameter.
4704         * p-exp.y: Update rules.
4705         (yylex): Update.
4706         * language.h (struct language_defn) <la_post_parser>: Add
4707         "completing" parameter.
4708         * go-exp.y: Update rules.
4709         (lex_one_token): Update.
4710         * expression.h (parse_completion): Don't declare.
4711         * d-exp.y: Update rules.
4712         (lex_one_token): Update rules.
4713         * c-exp.y: Update rules.
4714         (lex_one_token): Update.
4715         * ada-lang.c (resolve): Add "parse_completion" parameter.
4716         (resolve_subexp): Likewise.
4717         (ada_resolve_function): Likewise.
4718
4719 2019-04-04  Tom Tromey  <tom@tromey.com>
4720
4721         * parser-defs.h (struct parser_state) <start_arglist,
4722         end_arglist>: New methods.
4723         <arglist_len, m_funcall_chain>: New members.
4724         (arglist_len, start_arglist, end_arglist): Don't declare.
4725         * parse.c (arglist_len, funcall_chain): Remove global.
4726         (start_arglist, end_arglist): Remove functions.
4727         (parse_exp_in_context): Update.
4728         * p-exp.y: Update rules.
4729         * m2-exp.y: Update rules.
4730         * go-exp.y: Update rules.
4731         * f-exp.y: Update rules.
4732         * d-exp.y: Update rules.
4733         * c-exp.y: Update rules.
4734
4735 2019-04-04  Tom Tromey  <tom@tromey.com>
4736
4737         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4738         lex_operator, push_back>: New methods.
4739         Update all rules.
4740         (rust_parser::lex_hex, lex_escape): Rename and update.
4741         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4742         (rust_parser::lex_operator): Rename and update.
4743         (rust_parser::lex_number, rustyylex, rustyyerror)
4744         (rust_lex_test_init, rust_lex_test_sequence)
4745         (rust_lex_test_push_back, rust_lex_tests): Update.
4746         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4747         parameter.
4748         <lexptr, prev_lexptr>: New members.
4749         (lexptr, prev_lexptr): Don't declare.
4750         * parse.c (lexptr, prev_lexptr): Remove globals.
4751         (parse_exp_in_context): Update.
4752         * p-exp.y (yylex, yyerror): Update.
4753         * m2-exp.y (parse_number, yylex, yyerror): Update.
4754         * go-exp.y (lex_one_token, yyerror): Update.
4755         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4756         * d-exp.y (lex_one_token, yyerror): Update.
4757         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4758         (lex_one_token, yyerror): Update.
4759         * ada-lex.l (YY_INPUT): Update.
4760         (rewind_to_char): Update.
4761         * ada-exp.y (yyerror): Update.
4762
4763 2019-04-04  Tom Tromey  <tom@tromey.com>
4764
4765         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4766         * parser-defs.h (struct parser_state) <parser_state>: Add new
4767         parameter.
4768         <comma_terminates>: New member.
4769         (comma_terminates): Don't declare global.
4770         * parse.c (comma_terminates): Remove global.
4771         (parse_exp_in_context): Update.
4772         * p-exp.y (yylex): Update.
4773         * m2-exp.y (yylex): Update.
4774         * go-exp.y (lex_one_token): Update.
4775         * f-exp.y (yylex): Update.
4776         * d-exp.y (lex_one_token): Update.
4777         * c-exp.y (lex_one_token): Update.
4778         * ada-lex.l: Update.
4779
4780 2019-04-04  Tom Tromey  <tom@tromey.com>
4781
4782         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4783         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4784         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4785         * parser-defs.h (paren_depth): Don't declare.
4786         * parse.c (paren_depth): Remove global.
4787         (parse_exp_in_context): Update.
4788         * p-exp.y (paren_depth): New global.
4789         (pascal_parse): Initialize it.
4790         * m2-exp.y (paren_depth): New global.
4791         (m2_parse): Initialize it.
4792         * go-exp.y (paren_depth): New global.
4793         (go_parse): Initialize it.
4794         * f-exp.y (paren_depth): New global.
4795         (f_parse): Initialize it.
4796         * d-exp.y (paren_depth): New global.
4797         (d_parse): Initialize it.
4798         * c-exp.y (paren_depth): New global.
4799         (c_parse): Initialize it.
4800         * ada-lex.l (paren_depth): New global.
4801         (lexer_init): Initialize it.
4802
4803 2019-04-04  Tom Tromey  <tom@tromey.com>
4804
4805         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4806         (rust_parser::convert_ast_to_type)
4807         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4808         * parser-defs.h (struct parser_state) <parser_state>: Add
4809         parameters.  Initialize new members.
4810         <expression_context_block, expression_context_pc>: New members.
4811         * parse.c (expression_context_block, expression_context_pc):
4812         Remove globals.
4813         (parse_exp_in_context): Update.
4814         * p-exp.y: Update all rules.
4815         (yylex): Update.
4816         * m2-exp.y: Update all rules.
4817         (yylex): Update.
4818         * go-exp.y (yylex): Update.
4819         * f-exp.y (yylex): Update.
4820         * d-exp.y: Update all rules.
4821         (yylex): Update.
4822         * c-exp.y: Update all rules.
4823         (lex_one_token, classify_name, yylex, c_parse): Update.
4824         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4825
4826 2019-04-04  Tom Tromey  <tom@tromey.com>
4827
4828         * gdbarch.h, gdbarch.c: Rebuild.
4829         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4830         * stap-probe.h:
4831         (struct stap_parse_info): Replace "parser_state" with
4832         "expr_builder".
4833         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4834         (parser_state): New class.
4835         * parse.c (expr_builder): Rename.
4836         (expr_builder::release): Rename.
4837         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4838         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4839         (write_exp_elt_longcst, write_exp_elt_floatcst)
4840         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4841         (write_exp_string_vector, write_exp_bitstring)
4842         (write_exp_msymbol, mark_struct_expression)
4843         (write_dollar_variable)
4844         (insert_type_address_space, increase_expout_size): Replace
4845         "parser_state" with "expr_builder".
4846         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4847         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4848         "parser_state" with "expr_builder".
4849
4850 2019-04-04  Tom Tromey  <tom@tromey.com>
4851
4852         * rust-exp.y: Replace "parse_language" with method call.
4853         * p-exp.y:
4854         (yylex): Replace "parse_language" with method call.
4855         * m2-exp.y:
4856         (yylex): Replace "parse_language" with method call.
4857         * go-exp.y (classify_name): Replace "parse_language" with method
4858         call.
4859         * f-exp.y (yylex): Replace "parse_language" with method call.
4860         * d-exp.y (lex_one_token): Replace "parse_language" with method
4861         call.
4862         * c-exp.y:
4863         (lex_one_token, classify_name, yylex): Replace "parse_language"
4864         with method call.
4865         * ada-exp.y (find_primitive_type, type_char)
4866         (type_system_address): Replace "parse_language" with method call.
4867
4868 2019-04-04  Tom Tromey  <tom@tromey.com>
4869
4870         * rust-exp.y: Replace "parse_gdbarch" with method call.
4871         * parse.c (write_dollar_variable, insert_type_address_space):
4872         Replace "parse_gdbarch" with method call.
4873         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4874         call.
4875         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4876         call.
4877         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4878         "parse_gdbarch" with method call.
4879         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4880         with method call.
4881         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4882         "parse_gdbarch" with method call.
4883         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4884         "parse_gdbarch" with method call.
4885         * c-exp.y (parse_type, parse_number, classify_name): Replace
4886         "parse_gdbarch" with method call.
4887         * ada-lex.l: Replace "parse_gdbarch" with method call.
4888         * ada-exp.y (parse_type, find_primitive_type, type_char)
4889         (type_system_address): Replace "parse_gdbarch" with method call.
4890
4891 2019-04-04  Tom Tromey  <tom@tromey.com>
4892
4893         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4894         * stap-probe.c (stap_parse_argument): Update.
4895         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4896         initial_size parameter.
4897         * rust-exp.y (rust_lex_tests): Update.
4898         * parse.c (parser_state): Update.
4899         (parse_exp_in_context): Update.
4900         * parser-defs.h (struct parser_state) <parser_state>: Remove
4901         "initial_size" parameter.
4902
4903 2019-04-04  Tom Tromey  <tom@tromey.com>
4904
4905         * parser-defs.h (increase_expout_size): Don't declare.
4906         * parse.c (increase_expout_size): Now static.
4907
4908 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4909
4910         * gnu-nat.c (gnu_nat_target::wait): Fix
4911         target_waitstatus_to_string call.
4912
4913 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * eval.c (evaluate_subexp_standard): Handle internal functions
4916         during Fortran function call handling.
4917
4918 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * NEWS: Mention new internal functions.
4921         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4922         (read_base_type): Use dwarf2_init_complex_target_type.
4923         * value.c (creal_internal_fn): New function.
4924         (cimag_internal_fn): New function.
4925         (_initialize_values): Register new internal functions.
4926
4927 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4928
4929         * infrun.c (stop_all_threads): If debug_infrun, always
4930         trace the wait status after wait_one, using
4931         target_waitstatus_to_string and target_pid_to_str.
4932         (handle_inferior_event): Replace various trace of
4933         wait status kind by a single trace.
4934         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4935         wait status kind image by target_waitstatus_to_string.
4936         * target/waitstatus.c (target_waitstatus_to_string): Fix
4937         obsolete comment.
4938
4939 2019-04-01  Tom Tromey  <tromey@adacore.com>
4940
4941         PR symtab/23331:
4942         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4943
4944 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4945             Pedro Alves  <palves@redhat.com>
4946
4947         * top.c (quit_force): Call 'finalize_values'.
4948         * value.c (finalize_values): New function.
4949         * value.h (finalize_values): Declare.
4950
4951 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4952
4953         * NEWS: Announce $_gdb_major and $_gdb_minor.
4954
4955         * top.c (init_gdb_version_vars): New function.
4956         (gdb_init): Call init_gdb_version_vars.
4957
4958 2019-03-29  Tom Tromey  <tromey@adacore.com>
4959
4960         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4961         help text.  Remove dead code.
4962
4963 2019-03-29  Keith Seitz  <keiths@redhat.com>
4964
4965         From Siddhesh Poyarekar:
4966         * f-lang.h (f77_get_upperbound): Return LONGEST.
4967         (f77_get_lowerbound): Likewise.
4968         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4969         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4970         print them.
4971         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4972         plongest to format print it.
4973         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4974         (f77_get_upperbound): Likewise.
4975         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4976         LOWER_BOUND to LONGEST.
4977         (f77_create_arrayprint_offset_tbl): Likewise.
4978
4979 2019-03-29  Keith Seitz  <keiths@redhat.com>
4980
4981         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4982         %s/pulongest for TYPE_LENGTH instead of %d in format
4983         strings.
4984         * ada-typerint.c (ada_print_type): Likewise.
4985         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4986         * compile/compile-c-support.c (generate_register_struct): Likewise.
4987         * gdbtypes.c (recursive_dump_type): Likewise.
4988         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4989         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4990         instead of %d in format strings.
4991         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4992         to std::min to ULONGEST.
4993         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4994         instead of %d in format strings.
4995         * tracepoint.c (info_scope_command): Likewise.
4996         * typeprint.c (print_offset_data::update)
4997         (print_offset_data::finish): Likewise.
4998         * xtensa-tdep.c (xtensa_store_return_value)
4999         (xtensa_push_dummy_call): Likewise.
5000
5001 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5002
5003         * windows-nat.c (display_selector): Fixed format specifications
5004         for 64-bit Cygwin.
5005
5006 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5007
5008         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5009
5010 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5011
5012         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5013         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5014         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5015         (nios2_linux_init_abi): Install it.
5016
5017 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5018
5019         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5020
5021 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5022
5023         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5024
5025 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5026             Tom Tromey  <tromey@adacore.com>
5027
5028         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5029
5030 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5031
5032         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5033         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5034         method to compute the bounds of range types. Also print "[evaluated]"
5035         if the bounds' values come from a dynamic evaluation.
5036
5037 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5038
5039         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5040         whitespace when pretty printing is on.
5041
5042 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5043
5044         * ppc-linux-nat.c: Add include.
5045
5046 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5047
5048         * NEWS: Mention AArch64 Pointer Authentication.
5049
5050 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5051
5052         * arm-linux-nat.c: Add include.
5053
5054 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5055
5056         * source-cache.c (source_cache::get_source_lines): Re-read
5057         fullname after calling open_source_file.
5058
5059 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5060
5061         * NEWS: Mention TLS support for FreeBSD.
5062
5063 2019-03-25  Tom Tromey  <tromey@adacore.com>
5064
5065         * minsyms.c (BUNCH_SIZE): Update comment.
5066         (~minimal_symbol_reader): Remove old comment.
5067         (compact_minimal_symbols): Update comment.
5068         (minimal_symbol_reader::install): Remove old comment.  Update
5069         other comments.
5070
5071 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5072
5073         * s390-linux-nat.c: Add include.
5074
5075 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5076
5077         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5078         Call linux_get_hwcap.
5079         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5080         Likewise.
5081         (aarch64_linux_get_hwcap): Remove function.
5082         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5083         declaration.
5084         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5085         linux_get_hwcap.
5086         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5087         * linux-tdep.c (linux_get_hwcap): Add function.
5088         (linux_get_hwcap2): Likewise.
5089         * linux-tdep.h (linux_get_hwcap): Add declaration.
5090         (linux_get_hwcap2): Likewise.
5091         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5092         (ppc_linux_get_hwcap2): Likewise.
5093         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5094         linux_get_hwcap.
5095         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5096         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5097         (ppc_linux_nat_target::read_description): Likewise.
5098         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5099         * s390-linux-nat.c: Likewise.
5100         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5101
5102 2019-03-24  Tom Tromey  <tom@tromey.com>
5103
5104         * ada-lang.c (standard_lookup): Simplify initialization.
5105         (ada_lookup_symbol_nonlocal): Simplify return.
5106         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5107         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5108         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5109         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5110         initialization.
5111         * solib.c (solib_global_lookup): Simplify.
5112         * symtab.c (null_block_symbol): Remove.
5113         (symbol_cache_lookup): Simplify returns.
5114         (lookup_language_this): Simplify returns.
5115         (lookup_symbol_aux): Simplify return.
5116         (lookup_local_symbol): Simplify returns.
5117         (lookup_global_symbol_from_objfile): Simplify return.
5118         (lookup_symbol_in_objfile_symtabs)
5119         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5120         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5121         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5122         * cp-namespace.c (cp_lookup_bare_symbol)
5123         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5124         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5125         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5126         (cp_lookup_symbol_via_imports): Simplify initialization.
5127         (find_symbol_in_baseclass): Likewise.
5128         * symtab.h (null_block_symbol): Remove.
5129         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5130         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5131         (d_lookup_symbol_module): Likewise.
5132         (find_symbol_in_baseclass): Simplify initialization.
5133
5134 2019-03-24  Tom Tromey  <tom@tromey.com>
5135
5136         * expression.h: Don't include symtab.h.
5137         (struct block): Forward declare.
5138
5139 2019-03-24  Tom Tromey  <tom@tromey.com>
5140
5141         * c-exp.y (typebase): Remove casts.
5142         * gdbtypes.c (lookup_unsigned_typename, )
5143         (lookup_signed_typename): Remove cast.
5144         * eval.c (parse_to_comma_and_eval): Remove cast.
5145         * parse.c (write_dollar_variable): Remove cast.
5146         * block.h (struct block) <superblock>: Now const.
5147         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5148         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5149         (map_block): Make "block" const.
5150         * symfile.h (struct quick_symbol_functions)
5151         <map_matching_symbols>: Constify block argument to "callback".
5152         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5153         const.
5154         (find_pc_sect_compunit_symtab): Make "b" const.
5155         (find_symbol_at_address): Likewise.
5156         (search_symbols): Likewise.
5157         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5158         (dw2_debug_names_lookup_symbol): Likewise.
5159         (dw2_map_matching_symbols): Update.
5160         * p-valprint.c (pascal_val_print): Remove "block".
5161         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5162         (aux_add_nonlocal_symbols): Make "block" const.
5163         (resolve_subexp): Remove cast.
5164         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5165         const.
5166         (iterate_over_file_blocks): Likewise.
5167         * f-exp.y (%union) <bval>: Remove.
5168         * coffread.c (patch_opaque_types): Make "b" const.
5169         * spu-tdep.c (spu_catch_start): Make "block" const.
5170         * c-valprint.c (print_unpacked_pointer): Remove "block".
5171         * symmisc.c (dump_symtab_1): Make "b" const.
5172         (block_depth): Make "block" const.
5173         * d-exp.y (%union) <bval>: Remove.
5174         * cp-support.h (cp_lookup_rtti_type): Update.
5175         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5176         * psymtab.c (psym_lookup_symbol): Make "block" const.
5177         (maintenance_check_psymtabs): Make "b" const.
5178         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5179         (enumerate_locals, enumerate_args): Update.
5180         * python/py-symtab.c (stpy_global_block): Make "block" const.
5181         (stpy_static_block): Likewise.
5182         * inline-frame.c (block_starting_point_at): Make "new_block"
5183         const.
5184         * block.c (find_block_in_blockvector): Make return type const.
5185         (blockvector_for_pc_sect): Make "b" const.
5186         (find_block_in_blockvector): Make "b" const.
5187
5188 2019-03-23  Tom Tromey  <tom@tromey.com>
5189
5190         * varobj.c (varobj_create): Update.
5191         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5192         * printcmd.c (display_command, do_one_display): Don't reset
5193         innermost_block.
5194         * parser-defs.h (enum innermost_block_tracker_type): Move to
5195         expression.h.
5196         (innermost_block): Update comment.
5197         * parse.c (parse_exp_1): Add tracker_types parameter.
5198         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5199         tracker_types parameter.  Reset innermost_block.
5200         (parse_exp_in_context): Remove.
5201         (parse_expression_for_completion): Update.
5202         * objfiles.c (~objfile): Don't reset expression_context_block or
5203         innermost_block.
5204         * expression.h (enum innermost_block_tracker_type): Move from
5205         parser-defs.h.
5206         (parse_exp_1): Add tracker_types parameter.
5207         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5208         reset innermost_block.
5209
5210 2019-03-23  Tom Tromey  <tom@tromey.com>
5211
5212         * objfiles.h: Include bcache.h.
5213
5214 2019-03-23  Tom Tromey  <tom@tromey.com>
5215
5216         * linespec.c (get_current_search_block): Use
5217         scoped_restore_current_language.
5218         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5219
5220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5221             Jiong Wang  <jiong.wang@arm.com>
5222
5223         * aarch64-linux-tdep.c
5224         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5225         section.
5226         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5227
5228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5229             Jiong Wang  <jiong.wang@arm.com>
5230
5231         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5232         instructions.
5233         (aarch64_analyze_prologue_test): Add PACIASP test.
5234         (aarch64_prologue_prev_register): Unmask PC value.
5235
5236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5237             Jiong Wang  <jiong.wang@arm.com>
5238
5239         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5240         (aarch64_dwarf2_prev_register): Unmask PC value.
5241         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5242         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5243         DW_CFA_AARCH64_negate_ra_state.
5244         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5245
5246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5247             Jiong Wang  <jiong.wang@arm.com>
5248
5249         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5250         registers.
5251         (aarch64_pseudo_register_name): Likewise.
5252         (aarch64_pseudo_register_type): Likewise.
5253         (aarch64_pseudo_register_reggroup_p): Likewise.
5254         (aarch64_gdbarch_init): Add pauth registers.
5255         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5256         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5257         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5258         (struct gdbarch_tdep): Add regnum for ra_state.
5259
5260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5261             Jiong Wang  <jiong.wang@arm.com>
5262
5263         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5264
5265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5266             Jiong Wang  <jiong.wang@arm.com>
5267
5268         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5269         function.
5270         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5271         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5272         (aarch64_gdbarch_init): Add puth registers.
5273         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5274         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5275         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5276
5277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5278             Jiong Wang  <jiong.wang@arm.com>
5279
5280         * aarch64-linux-nat.c
5281         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5282         * aarch64-linux-tdep.c
5283         (aarch64_linux_core_read_description): Likewise.
5284         (aarch64_linux_get_hwcap): New function.
5285         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5286         (aarch64_linux_get_hwcap): New declaration.
5287
5288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5289             Jiong Wang  <jiong.wang@arm.com>
5290
5291         * aarch64-linux-nat.c
5292         (aarch64_linux_nat_target::read_description): Add pauth param.
5293         * aarch64-linux-tdep.c
5294         (aarch64_linux_core_read_description): Likewise.
5295         * aarch64-tdep.c (struct target_desc): Add in pauth.
5296         (aarch64_read_description): Add pauth param.
5297         (aarch64_gdbarch_init): Likewise.
5298         * aarch64-tdep.h (aarch64_read_description): Likewise.
5299         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5300         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5301         * features/Makefile: Add new files.
5302         * features/aarch64-pauth.c: New file.
5303         * features/aarch64-pauth.xml: New file.
5304
5305 2019-03-20  Tom Tromey  <tromey@adacore.com>
5306
5307         * infrun.c (handle_inferior_event): Rename from
5308         handle_inferior_event_1.  Create a scoped_value_mark.
5309         (handle_inferior_event): Remove.
5310
5311 2019-03-19  Tom Tromey  <tromey@adacore.com>
5312
5313         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5314         * infrun.h (print_stop_event): Add "displays" parameter.
5315         * infrun.c (print_stop_event): Add "displays" parameter.
5316
5317 2019-03-19  Pedro Alves  <palves@redhat.com>
5318
5319         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5320         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5321         to -1.  Fix TABs vs spaces.
5322         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5323         * tui/tui-out.h (tui_ui_out) Add intro comments.
5324         <m_line, m_start_of_line>: In-class initialize, and add describing
5325         comment.
5326
5327 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5330         variable names.
5331         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5332
5333 2019-03-18  Pedro Alves  <palves@redhat.com>
5334             Eli Zaretskii <eliz@gnu.org>
5335
5336         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5337         m_line and m_start_of_line.
5338
5339 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5340
5341         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5342         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5343         it returns a newline.  This fixes a regression in TU mode, whereby
5344         the next line is output on the same screen line as the user input.
5345
5346 2019-03-18  Tom Tromey  <tromey@adacore.com>
5347
5348         * minsyms.c (minimal_symbol_reader::install): Remove call to
5349         obstack_blank.
5350
5351 2019-03-18  Pedro Alves  <palves@redhat.com>
5352
5353         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5354         New globals.
5355         (apply_style): New, factored out from ...
5356         (apply_ansi_escape): ... this.  Handle reverse video mode.
5357         (tui_set_reverse_mode): New function.
5358         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5359         * tui/tui-winsource.c (tui_show_source_line): Use
5360         tui_set_reverse_mode instead of setting A_STANDOUT.
5361         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5362         New setter methods.
5363
5364 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5365
5366         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5367         Handle tabs.
5368
5369 2019-03-18  Tom Tromey  <tromey@adacore.com>
5370
5371         * ada-lang.c (empty_array): Add "high" parameter.
5372         (ada_evaluate_subexp): Update.
5373
5374 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5375
5376         * unittests/string_view-selftests.c: Define
5377         _initialize_string_view_selftests unconditionally.
5378
5379 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5380
5381         PR gdb/24350
5382         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5383
5384 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5385
5386         PR gdb/24351
5387         * windows-nat.c (display_selector): Fix format specifiers.
5388
5389 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5390
5391         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5392         tui_refill_source_window instead of tui_refresh_win, to update the
5393         current execution line.  This fixes redisplay of the current line
5394         when stepping through the code with "next" or "step".
5395
5396 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5397
5398         * source-cache.c (source_cache::get_source_lines): Call
5399         find_source_lines to initialize s->nlines.  This fixes vertical
5400         scrolling of TUI source window when the DOWN arrow is pressed.
5401
5402 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5403
5404         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5405         linux-thread-db.c (_initialize_thread_db): Likewise.
5406
5407 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5408
5409         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5410         wclrtoeol in tui_show_source_line".  This reverts changes made in
5411         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5412
5413 2019-03-15  Tom Tromey  <tom@tromey.com>
5414
5415         * symtab.h (struct minimal_symbol): Derive from
5416         general_symbol_info.
5417         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5418         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5419         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5420         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5421         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5422         (MSYMBOL_SEARCH_NAME): Update.
5423         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5424         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5425         * minsyms.c (minimal_symbol_reader::record_full): Update.
5426
5427 2019-03-15  Tom Tromey  <tom@tromey.com>
5428
5429         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5430
5431 2019-03-15  Tom Tromey  <tom@tromey.com>
5432
5433         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5434         unique_xmalloc_ptr.
5435         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5436         Update.
5437         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5438         (build_minimal_symbol_hash_tables)
5439         (minimal_symbol_reader::install): Update.
5440
5441 2019-03-15  Tom Tromey  <tom@tromey.com>
5442
5443         * symtab.c (create_demangled_names_hash): Update.
5444         (symbol_set_names): Update.
5445         * objfiles.h (struct objfile_per_bfd_storage)
5446         <demangled_names_hash>: Now an htab_up.
5447         * objfiles.c (objfile_per_bfd_storage): Simplify.
5448
5449 2019-03-15  Tom Tromey  <tom@tromey.com>
5450
5451         * objfiles.h (struct objfile_per_bfd_storage): Declare
5452         destructor.
5453         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5454         New.
5455         (get_objfile_bfd_data): Use new.  Don't initialize
5456         language_of_main.
5457         (free_objfile_per_bfd_storage): Remove.
5458         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5459
5460 2019-03-15  Tom Tromey  <tom@tromey.com>
5461
5462         * symfile.c (reread_symbols): Update.
5463         * objfiles.c (objfile::objfile): Update.
5464         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5465         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5466         comment.
5467         (minimal_symbol_reader::install): Update.
5468         (terminate_minimal_symbol_table): Remove.
5469         * jit.c (jit_object_close_impl): Update.
5470
5471 2019-03-15  Tom Tromey  <tom@tromey.com>
5472
5473         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5474         initializations.
5475
5476 2019-03-15  Tom Tromey  <tom@tromey.com>
5477
5478         * objfiles.h (struct objfile_per_bfd_storage)
5479         <demangled_hash_languages>: Now a bitset.
5480         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5481         (lookup_minimal_symbol): Update.
5482
5483 2019-03-15  Tom Tromey  <tom@tromey.com>
5484
5485         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5486         Don't return the symbol.
5487         * coffread.c (record_minimal_symbol): Use record_full.
5488
5489 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5490
5491         The MS-Windows port of ncurses fails to switch to a color pair if
5492         one or both of the colors are the implicit default colors.  This
5493         change records the default colors when TUI is initialized, and
5494         then specifies them explicitly when a color pair uses the default
5495         colors.  This allows color styling in TUI mode on MS-Windows.
5496
5497         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5498         ncurses_norm_attr.
5499         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5500         colors in ncurses_norm_attr.
5501         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5502         "none", replace it with the default color recorded in
5503         ncurses_norm_attr.
5504
5505 2019-03-14  Tom Tromey  <tromey@adacore.com>
5506
5507         * source-cache.h (class source_cache) <get_source_lines>: Return
5508         std::string.
5509         * source-cache.c (source_cache::extract_lines): Handle case where
5510         first_pos==npos.  Return std::string.
5511         (source_cache::get_source_lines): Update.
5512
5513 2019-03-14  Tom Tromey  <tromey@adacore.com>
5514
5515         * NEWS: Add item for "style sources" commands.
5516         * source-cache.c (source_cache::get_source_lines): Check
5517         source_styling.
5518         * cli/cli-style.c (source_styling): New global.
5519         (_initialize_cli_style): Add "style sources" commands.
5520         (show_style_sources): New function.
5521         * cli/cli-style.h (source_styling): Declare.
5522
5523 2019-03-14  Pedro Alves  <palves@redhat.com>
5524             Tom Tromey  <tromey@adacore.com>
5525
5526         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5527         * tui/tui-winsource.c (tui_refill_source_window): New function,
5528         from...
5529         (tui_horizontal_source_scroll): ... here.  Move some logic.
5530         * cli/cli-style.c (set_style_enabled): Notify new observable.
5531         * tui/tui-hooks.c (tui_redisplay_source): New function.
5532         (tui_attach_detach_observers): Attach or detach
5533         tui_redisplay_source.
5534         * observable.h (source_styling_changed): New observable.
5535         * observable.c: Define source_styling_changed observable.
5536
5537 2019-03-13  Tom Tromey  <tromey@adacore.com>
5538
5539         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5540         (i386_gnu_nat_target::store_registers): Update.
5541         * target-debug.h (target_debug_print_std_string): New macro.
5542         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5543         * windows-tdep.c (display_one_tib): Update.
5544         * tui/tui-stack.c (tui_make_status_line): Update.
5545         * top.c (print_inferior_quit_action): Update.
5546         * thread.c (thr_try_catch_cmd): Update.
5547         (add_thread_with_info): Update.
5548         (thread_target_id_str): Update.
5549         (thr_try_catch_cmd): Update.
5550         (thread_command): Update.
5551         (thread_find_command): Update.
5552         * record-btrace.c (record_btrace_target::info_record)
5553         (record_btrace_resume_thread, record_btrace_target::resume)
5554         (record_btrace_cancel_resume, record_btrace_step_thread)
5555         (record_btrace_target::wait, record_btrace_target::wait)
5556         (record_btrace_target::wait, record_btrace_target::stop): Update.
5557         * progspace.c (print_program_space): Update.
5558         * process-stratum-target.c
5559         (process_stratum_target::thread_address_space): Update.
5560         * linux-fork.c (linux_fork_mourn_inferior)
5561         (detach_checkpoint_command, info_checkpoints_command)
5562         (linux_fork_context): Update.
5563         (linux_fork_detach): Update.
5564         (class scoped_switch_fork_info): Update.
5565         (delete_checkpoint_command): Update.
5566         * infrun.c (follow_fork_inferior): Update.
5567         (follow_fork_inferior): Update.
5568         (proceed_after_vfork_done): Update.
5569         (handle_vfork_child_exec_or_exit): Update.
5570         (follow_exec): Update.
5571         (displaced_step_prepare_throw): Update.
5572         (displaced_step_restore): Update.
5573         (start_step_over): Update.
5574         (resume_1): Update.
5575         (clear_proceed_status_thread): Update.
5576         (proceed): Update.
5577         (print_target_wait_results): Update.
5578         (do_target_wait): Update.
5579         (context_switch): Update.
5580         (stop_all_threads): Update.
5581         (restart_threads): Update.
5582         (finish_step_over): Update.
5583         (handle_signal_stop): Update.
5584         (switch_back_to_stepped_thread): Update.
5585         (keep_going_pass_signal): Update.
5586         (print_exited_reason): Update.
5587         (normal_stop): Update.
5588         * inferior.c (inferior_pid_to_str): Change return type.
5589         (print_selected_inferior): Update.
5590         (add_inferior): Update.
5591         (detach_inferior): Update.
5592         * dummy-frame.c (fprint_dummy_frames): Update.
5593         * dcache.c (dcache_info_1): Update.
5594         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5595         (btrace_fetch, btrace_clear): Update.
5596         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5597         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5598         type.
5599         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5600         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5601         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5602         * gdbarch.c, gdbarch.h: Rebuild.
5603         * gdbarch.sh (core_pid_to_str): Change return type.
5604         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5605         return type.
5606         (windows_nat_target::pid_to_str): Change return type.
5607         (windows_delete_thread): Update.
5608         (windows_nat_target::attach): Update.
5609         (windows_nat_target::files_info): Update.
5610         * target-delegates.c: Rebuild.
5611         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5612         return type.
5613         (sol_thread_target::pid_to_str): Change return type.
5614         * remote.c (class remote_target) <pid_to_str>: Change return
5615         type.
5616         (remote_target::pid_to_str): Change return type.
5617         (extended_remote_target::attach, remote_target::remote_stop_ns)
5618         (remote_target::remote_notif_remove_queued_reply)
5619         (remote_target::push_stop_reply, remote_target::disable_btrace):
5620         Update.
5621         (extended_remote_target::attach): Update.
5622         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5623         type.
5624         (gdbsim_target::pid_to_str): Change return type.
5625         * ravenscar-thread.c (struct ravenscar_thread_target)
5626         <pid_to_str>: Change return type.
5627         (ravenscar_thread_target::pid_to_str): Change return type.
5628         * procfs.c (class procfs_target) <pid_to_str>: Change return
5629         type.
5630         (procfs_target::pid_to_str): Change return type.
5631         (procfs_target::attach): Update.
5632         (procfs_target::detach): Update.
5633         (procfs_target::fetch_registers): Update.
5634         (procfs_target::store_registers): Update.
5635         (procfs_target::wait): Update.
5636         (procfs_target::files_info): Update.
5637         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5638         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5639         return type.
5640         (nto_procfs_target::pid_to_str): Change return type.
5641         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5642         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5643         return type.
5644         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5645         (exit_lwp): Update.
5646         (attach_proc_task_lwp_callback, get_detach_signal)
5647         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5648         (linux_nat_target::resume, wait_lwp, stop_callback)
5649         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5650         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5651         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5652         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5653         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5654         type.
5655         (inf_ptrace_target::attach): Update.
5656         (inf_ptrace_target::files_info): Update.
5657         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5658         type.
5659         (go32_nat_target::pid_to_str): Change return type.
5660         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5661         (gnu_nat_target::wait): Update.
5662         (gnu_nat_target::wait): Update.
5663         (gnu_nat_target::resume): Update.
5664         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5665         (fbsd_nat_target::wait): Update.
5666         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5667         type.
5668         (darwin_nat_target::attach): Update.
5669         * corelow.c (class core_target) <pid_to_str>: Change return type.
5670         (core_target::pid_to_str): Change return type.
5671         * target.c (normal_pid_to_str): Change return type.
5672         (default_pid_to_str): Likewise.
5673         (target_pid_to_str): Change return type.
5674         (target_translate_tls_address): Update.
5675         (target_announce_detach): Update.
5676         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5677         return type.
5678         (bsd_uthread_target::pid_to_str): Change return type.
5679         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5680         type.
5681         (bsd_kvm_target::pid_to_str): Change return type.
5682         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5683         return type.
5684         (aix_thread_target::pid_to_str): Change return type.
5685         * target.h (struct target_ops) <pid_to_str>: Change return type.
5686         (target_pid_to_str, normal_pid_to_str): Likewise.
5687         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5688         type.
5689         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5690         type.
5691         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5692         return type.
5693         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5694         type.
5695         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5696         type.
5697         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5698         return type.
5699
5700 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5701
5702         * NEWS: Mention that the new default MI version is 3.  Mention
5703         changes to the output of commands and events that deal with
5704         multi-location breakpoints.
5705         * breakpoint.c: Include "mi/mi-out.h".
5706         (print_one_breakpoint): Change output syntax if using MI version
5707         >= 3.
5708         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5709         New.
5710         (mi_multi_location_breakpoint_output_fixed): New.
5711         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5712         (mi_cmd_fix_multi_location_breakpoint_output): New.
5713         (mi_multi_location_breakpoint_output_fixed): New.
5714         * mi/mi-cmds.c (mi_cmds): Register command
5715         -fix-multi-location-breakpoint-output.
5716         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5717         interpreter "mi".
5718
5719 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5720
5721         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5722         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5723         instantiate mi_ui_out based on interpreter name.
5724         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5725         * mi/mi-main.c (mi_load_progress): Likewise.
5726
5727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5728
5729         * NEWS: Combine separate "New targets" sections for 8.3.
5730
5731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5732
5733         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5734         (ppcfbsd_init_abi): Install gdbarch
5735         "fetch_tls_load_module_address" and "get_thread_local_address"
5736         methods.
5737
5738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5739
5740         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5741         (riscv_fbsd_init_abi): Install gdbarch
5742         "fetch_tls_load_module_address" and "get_thread_local_address"
5743         methods.
5744
5745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5746
5747         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5748         (i386fbsd_init_abi): Install gdbarch
5749         "fetch_tls_load_module_address" and "get_thread_local_address"
5750         methods.
5751
5752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5753
5754         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5755         (amd64fbsd_init_abi): Install gdbarch
5756         "fetch_tls_load_module_address" and "get_thread_local_address"
5757         methods.
5758
5759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5760
5761         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5762         (struct fbsd_pspace_data): New type.
5763         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5764         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5765         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5766         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5767         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5768
5769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5770
5771         * gdbtypes.c (lookup_struct_elt): New function.
5772         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5773         * gdbtypes.h (struct struct_elt): New type.
5774         (lookup_struct_elt): New prototype.
5775
5776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5777
5778         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5779         remove disabled code block.
5780
5781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5782
5783         * gdbarch.sh (get_thread_local_address): New method.
5784         * gdbarch.h, gdbarch.c: Regenerate.
5785         * target.c (target_translate_tls_address): Use
5786         gdbarch_get_thread_local_address if present instead of
5787         target::get_thread_local_address.
5788
5789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5790
5791         * target.h (target::get_thread_local_address): Update comment.
5792
5793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5794
5795         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5796         objfile->separate_debug_objfile_backlink if not NULL.
5797
5798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5799
5800         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5801         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5802         (amd64bsd_store_inferior_registers): Likewise.
5803         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5804         Enable segment base registers.
5805         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5806         PT_GETFSBASE and PT_GETGSBASE.
5807         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5808         PT_SETGSBASE.
5809         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5810         segment base registers.
5811         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5812
5813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5814
5815         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5816         Update calls to i386_target_description to add 'segments'
5817         parameter.
5818         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5819         add segment base registers.
5820         * arch/i386.c (i386_create_target_description): Add 'segments'
5821         parameter to enable segment base registers.
5822         * arch/i386.h (i386_create_target_description): Likewise.
5823         * features/i386/32bit-segments.xml: New file.
5824         * features/i386/32bit-segments.c: Generate.
5825         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5826         call to i386_target_description to add 'segments' parameter.
5827         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5828         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5829         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5830         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5831         if feature is present.
5832         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5833         Add 'segments' parameter to call to i386_target_description.
5834         (i386_target_description): Add 'segments' parameter to enable
5835         segment base registers.
5836         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5837         to call to i386_target_description.
5838         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5839         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5840         Define I386_NUM_REGS.
5841         (i386_target_description): Add 'segments' parameter to enable
5842         segment base registers.
5843
5844 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5845
5846         PR/24325
5847         * source-cache.c: #undef open and close, to avoid unresolved
5848         externals during linking.
5849
5850 2019-03-12  Tom Tromey  <tromey@adacore.com>
5851
5852         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5853         const.  Add initializers.
5854         (_initialize_remote): Don't initialize ptid globals.
5855
5856 2019-03-12  Pedro Alves  <palves@redhat.com>
5857
5858         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5859
5860 2019-03-12  Pedro Alves  <palves@redhat.com>
5861
5862         * cp-name-parser.y (main): Remove unused 'len' variable.
5863
5864 2019-03-12  Tom Tromey  <tromey@adacore.com>
5865
5866         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5867         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5868
5869 2019-03-12  Tom Tromey  <tromey@adacore.com>
5870
5871         * linux-nat.c (iterate_over_lwps): Update.
5872         (stop_callback): Remove parameter.
5873         (stop_wait_callback, detach_callback, resume_set_callback)
5874         (select_singlestep_lwp_callback, set_ignore_sigint)
5875         (status_callback, resumed_callback, resume_clear_callback)
5876         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5877         data parameter.
5878         (linux_nat_target::detach, linux_nat_target::resume)
5879         (linux_stop_and_wait_all_lwps, select_event_lwp)
5880         (linux_nat_filter_event, linux_nat_wait_1)
5881         (linux_nat_target::kill, linux_nat_target::stop)
5882         (linux_nat_target::stop): Update.
5883         (linux_nat_resume_callback): Change type.
5884         (resume_stopped_resumed_lwps, count_events_callback)
5885         (select_event_lwp_callback): Likewise.
5886         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5887         * arm-linux-nat.c (struct update_registers_data): Remove.
5888         (update_registers_callback): Change type.
5889         (arm_linux_insert_hw_breakpoint1): Update.
5890         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5891         parameter.
5892         (x86_linux_dr_set_addr): Update.
5893         (x86_linux_dr_set_control): Update.
5894         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5895         (iterate_over_lwps): Use gdb::function_view.
5896         * nat/aarch64-linux-hw-point.c (struct
5897         aarch64_dr_update_callback_param): Remove.
5898         (debug_reg_change_callback): Change type.
5899         (aarch64_notify_debug_reg_change): Update.
5900         * s390-linux-nat.c (s390_refresh_per_info): Update.
5901
5902 2019-03-11  Tom Tromey  <tromey@adacore.com>
5903
5904         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5905         redundant assignment to "this_cu".
5906
5907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5908
5909         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5910
5911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5912
5913         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5914         from...
5915         (rank_one_type): ... this.
5916
5917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5918
5919         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5920         from...
5921         (rank_one_type): ... this.
5922
5923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5924
5925         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5926         from...
5927         (rank_one_type): ... this.
5928
5929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5930
5931         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5932         from...
5933         (rank_one_type): ... this.
5934
5935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5936
5937         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5938         from...
5939         (rank_one_type): ... this.
5940
5941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5942
5943         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5944         from...
5945         (rank_one_type): ... this.
5946
5947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5948
5949         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5950         from...
5951         (rank_one_type): ... this.
5952
5953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5954
5955         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5956         from...
5957         (rank_one_type): ... this.
5958
5959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5960
5961         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5962         from...
5963         (rank_one_type): ... this.
5964
5965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5966
5967         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5968         from...
5969         (rank_one_type): ... this.
5970
5971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5972
5973         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5974         from...
5975         (rank_one_type): ... this.
5976
5977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5978
5979         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5980         from...
5981         (rank_one_type): ... this.
5982
5983 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5984
5985         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5986         inferior-events' shows the example events.
5987
5988 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5989
5990         Support styling on native MS-Windows console
5991
5992         PR/24315
5993         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5994         on MS-Windows if $TERM is not defined.
5995
5996         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5997
5998         * posix-hdep.c (gdb_console_fputs):
5999         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6000         functions.
6001         * ui-file.h (gdb_console_fputs): Add prototype.
6002
6003         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6004         back to fputs only if the former returns zero.
6005
6006 2019-03-07  Tom Tromey  <tom@tromey.com>
6007
6008         * symmisc.c (print_symbol_bcache_statistics): Update.
6009         (print_objfile_statistics): Update.
6010         * symfile.c (allocate_symtab): Update.
6011         * stabsread.c: Don't include bcache.h.
6012         * psymtab.h (struct psymbol_bcache): Don't declare.
6013         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6014         (psymbol_bcache_init, psymbol_bcache_free)
6015         (psymbol_bcache_get_bcache): Don't declare.
6016         * psymtab.c (struct psymbol_bcache): Remove.
6017         (psymtab_storage::psymtab_storage): Update.
6018         (psymtab_storage::~psymtab_storage): Update.
6019         (psymbol_bcache_init, psymbol_bcache_free)
6020         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6021         (add_psymbol_to_bcache): Update.
6022         (allocate_psymtab): Update.
6023         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6024         macro_cache>: No longer pointers.
6025         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6026         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6027         * macrotab.c (macro_bcache): Update.
6028         * macroexp.c: Don't include bcache.h.
6029         * gdbtypes.c (check_types_worklist): Update.
6030         (types_deeply_equal): Remove TRY/CATCH.  Update.
6031         * elfread.c (elf_symtab_read): Update.
6032         * dwarf2read.c: Don't include bcache.h.
6033         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6034         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6035         (print_bcache_statistics, bcache_memory_used): Don't declare.
6036         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6037         methods.  Rename all data members.
6038         * bcache.c (struct bcache): Move to bcache.h.
6039         (bcache::expand_hash_table): Rename from expand_hash_table.
6040         (bcache): Remove.
6041         (bcache::insert): Rename from bcache_full.
6042         (bcache::compare): Rename from bcache_compare.
6043         (bcache_xmalloc): Remove.
6044         (bcache::~bcache): Rename from bcache_xfree.
6045         (bcache::print_statistics): Rename from print_bcache_statistics.
6046         (bcache::memory_used): Rename from bcache_memory_used.
6047
6048 2019-03-07  Pedro Alves  <palves@redhat.com>
6049
6050         * infrun.c (normal_stop): Also check for
6051         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6052
6053 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * f-lang.c (value_from_host_double): Moved to...
6056         * value.c (value_from_host_double): ...here.
6057         * value.h (value_from_host_double): Declare.
6058         * guile/scm-math.c (vlscm_convert_typed_number): Use
6059         value_from_host_double.
6060         (vlscm_convert_number): Likewise.
6061         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6062         * python/py-value.c (convert_value_from_python): Likewise.
6063
6064 2019-03-06  Tom Tromey  <tom@tromey.com>
6065
6066         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6067
6068 2019-03-06  Tom Tromey  <tom@tromey.com>
6069
6070         * utils.h (free_current_contents): Don't declare.
6071         * utils.c (free_current_contents): Remove.
6072
6073 2019-03-06  Tom Tromey  <tom@tromey.com>
6074
6075         * top.c (quit_force): Update.
6076         * main.c (captured_command_loop): Update.
6077         * common/new-op.c (operator new): Update.
6078         * common/common-exceptions.c (struct catcher)
6079         <save_cleanup_chain>: Remove member.
6080         (exceptions_state_mc_init): Update.
6081         (exception_try_scope_entry): Return nullptr.
6082         (exception_try_scope_exit, exception_rethrow)
6083         (throw_exception_sjlj, throw_exception_cxx): Update.
6084         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6085         (all_cleanups, do_cleanups, discard_cleanups)
6086         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6087         (restore_cleanups, restore_final_cleanups): Don't declare.
6088         (do_final_cleanups): Remove parameter.
6089         * common/cleanups.c (cleanup_chain, make_cleanup)
6090         (make_cleanup_dtor, all_cleanups, do_cleanups)
6091         (discard_my_cleanups, discard_cleanups)
6092         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6093         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6094         (null_cleanup): Remove.
6095         (do_final_cleanups): Remove parameter.
6096
6097 2019-03-06  Tom Tromey  <tom@tromey.com>
6098
6099         * remote.c (remote_target::remote_parse_stop_reply): Use
6100         unique_xmalloc_ptr.
6101
6102 2019-03-06  Tom Tromey  <tom@tromey.com>
6103
6104         * stabsread.c (struct stabs_field_info): Rename from field_info.
6105         <list, fnlist>: Add initializers.
6106         <obstack>: New member.
6107         (read_member_functions, read_struct_fields, read_baseclasses):
6108         Allocate on obstack.  Don't use cleanups.
6109         (read_one_struct_field, read_member_functions, read_struct_fields)
6110         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6111         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6112         (read_struct_type): Update.
6113
6114 2019-03-06  Tom Tromey  <tom@tromey.com>
6115
6116         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6117         * common/filestuff.h (make_cleanup_close): Don't declare.
6118         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6119         Remove.
6120
6121 2019-03-06  Tom Tromey  <tom@tromey.com>
6122
6123         * solib-aix.c: Use make_scope_exit.
6124
6125 2019-03-06  Tom Tromey  <tom@tromey.com>
6126
6127         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6128         Use make_scope_exit.
6129
6130 2019-03-06  Tom Tromey  <tom@tromey.com>
6131
6132         * solib-svr4.c (disable_probes_interface): Remove parameter.
6133         (svr4_handle_solib_event): Use make_scope_exit.
6134
6135 2019-03-06  Tom Tromey  <tom@tromey.com>
6136
6137         * remote.c (struct stop_reply_deleter): Remove.
6138         (stop_reply_up): Update.
6139         (struct stop_reply): Derive from notif_event.  Don't typedef.
6140         <regcache>: Now a std::vector.
6141         (stop_reply_xfree): Remove.
6142         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6143         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6144         (remote_target::discard_pending_stop_replies): Use delete.
6145         (remote_target::remote_parse_stop_reply): Update.
6146         (remote_target::process_stop_reply): Update.
6147         * remote-notif.h (struct notif_event): Add virtual destructor.
6148         Remove "dtr" member.
6149         (struct notif_client) <alloc_event>: Return a unique_ptr.
6150         (notif_event_xfree): Don't declare.
6151         (notif_event_up): New typedef.
6152         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6153         (notif_event_xfree, do_notif_event_xfree): Remove.
6154         (remote_notif_state_xfree): Update.
6155
6156 2019-03-06  Tom Tromey  <tom@tromey.com>
6157
6158         * infrun.c (displaced_step_clear_cleanup): Now a
6159         forward_scope_exit type.
6160         (displaced_step_prepare_throw): Update.
6161         (displaced_step_fixup): Update.
6162
6163 2019-03-06  Tom Tromey  <tom@tromey.com>
6164
6165         * inferior.h (class inferior): Update comment.
6166         * gdbthread.h (class thread_info): Update comment.
6167
6168 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6169             Tom Tromey  <tom@tromey.com>
6170
6171         * stabsread.h (struct stab_section_list): Remove.
6172         (coffstab_build_psymtabs): Update.
6173         * dbxread.c (symbuf_sections): Now a std::vector.
6174         (sect_idx): New global.
6175         (fill_symbuf): Update.
6176         (coffstab_build_psymtabs): Change type of stabsects parameter.
6177         Update.
6178         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6179         std::vector.
6180         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6181         (coff_locate_sections): Update.
6182         (coff_symfile_read): Remove cleanups.  Update.
6183         (init_stringtab): Add storage parameter.
6184         (free_stringtab, free_stringtab_cleanup): Remove.
6185         (init_lineno): Add storage parameter.
6186         (free_linetab, free_linetab_cleanup): Remove.
6187
6188 2019-03-06  Pedro Alves  <palves@redhat.com>
6189
6190         * linux-fork.c (fork_info::clobber_regs): Delete.
6191         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6192         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6193         comment.  Adjust.
6194         (scoped_switch_fork_info::scoped_switch_fork_info)
6195         (checkpoint_command, linux_fork_context): Adjust
6196         fork_save_infrun_state calls.
6197
6198 2019-03-06  Pedro Alves  <palves@redhat.com>
6199
6200         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6201         (inf_has_multiple_threads): Return 'bool' and rewrite using
6202         inferior_info::threads().
6203
6204 2019-03-06  Pedro Alves  <palves@redhat.com>
6205
6206         * linux-fork.c: Include <list>.
6207         (fork_list): Now a std::list instance.
6208         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6209         (forks_exist_p, find_last_fork): Adjust.
6210         (new_fork): Delete.
6211         (one_fork_p): New.
6212         (add_fork): Adjust.
6213         (free_fork): Delete, folded into fork_info::~fork_info().
6214         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6215         Adjust.
6216         (init_fork_list): Delete.
6217         (linux_fork_killall, linux_fork_mourn_inferior)
6218         (linux_fork_detach, info_checkpoints_command): Adjust.
6219         (_initialize_linux_fork): No longer call init_fork_list.
6220
6221 2019-03-06  Pedro Alves  <palves@redhat.com>
6222
6223         * linux-fork.c (new_fork): New, split out of ...
6224         (add_fork): ... this.  Return void.  Move "first fork" special
6225         case from here, to ...
6226         (checkpoint_command): ... here.
6227         * linux-linux.h (add_fork): Return void.
6228
6229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6232
6233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6234             Chris January  <chris.january@arm.com>
6235             David Lecomber  <david.lecomber@arm.com>
6236
6237         * f-exp.y: New token, UNOP_INTRINSIC.
6238         (exp): New pattern using UNOP_INTRINSIC token.
6239         (f77_keywords): Add 'abs' keyword.
6240         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6241         (value_from_host_double): New function.
6242         (evaluate_subexp_f): Support UNOP_ABS.
6243
6244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6247         types.
6248
6249 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6252         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6253         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6254
6255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6256
6257         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6258
6259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6260             Chris January  <chris.january@arm.com>
6261
6262         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6263         * f-exp.y: Define 'KIND' token.
6264         (exp): New pattern for KIND expressions.
6265         (ptype): Handle types with a kind extension.
6266         (direct_abs_decl): Extend to spot kind extensions.
6267         (f77_keywords): Add 'kind' to the list.
6268         (push_kind_type): New function.
6269         (convert_to_kind_type): New function.
6270         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6271         * parse.c (operator_length_standard): Likewise.
6272         * parser-defs.h (enum type_pieces): Add tp_kind.
6273         * std-operator.def: Add UNOP_KIND.
6274
6275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * f-exp.y (f_parse): Set yydebug.
6278
6279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         * f-lang.c (evaluate_subexp_f): New function.
6282         (exp_descriptor_f): New global.
6283         (f_language_defn): Use exp_descriptor_f instead of
6284         exp_descriptor_standard.
6285
6286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * f-exp.y (struct token): Add comments.
6289         (dot_ops): Remove uppercase versions and the end marker.
6290         (f77_keywords): Likewise.
6291         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6292         entries in the dot_ops array are case insensitive, and use
6293         strncasecmp to compare strings.  Also some whitespace cleanup in
6294         this area.  Similar for the f77_keywords array, except entries in
6295         this list might be case sensitive.
6296
6297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * f-exp.y (struct f77_boolean_val): Add comments.
6300         (boolean_values): Remove uppercase versions, and end marker.
6301         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6302         and use strncasecmp to achieve case insensitivity.  Additionally,
6303         perform whitespace cleanup around this code.
6304
6305 2019-03-06  Tom Tromey  <tromey@adacore.com>
6306
6307         * remote-sim.c (gdbsim_target_open): Use result of
6308         gdb_argv::release.
6309
6310 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6311         Dirk Schubert  <dirk.schubert@arm.com>
6312         Chris January  <chris.january@arm.com>
6313
6314         * eval.c (evaluate_subexp_standard): Call Fortran argument
6315         wrapping logic.
6316         * f-lang.c (struct value): A value which can be passed into a
6317         Fortran function call.
6318         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6319         where appropriate.
6320         (struct type): Value ready for a Fortran function call.
6321         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6322         is needed.
6323         * f-lang.h (fortran_argument_convert): Declaration.
6324         (fortran_preserve_arg_pointer): Declaration.
6325         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6326
6327 2019-03-05  Tom Tromey  <tromey@adacore.com>
6328
6329         * python/py-prettyprint.c (print_string_repr): Remove #if.
6330         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6331
6332 2019-03-05  Tom Tromey  <tromey@adacore.com>
6333
6334         * target.c (the_dummy_target): Move later.  Change type to
6335         "dummy_target".
6336         (initialize_targets): Don't initialize the_dummy_target.
6337
6338 2019-03-05  Tom Tromey  <tromey@adacore.com>
6339
6340         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6341         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6342
6343 2019-03-05  Tom Tromey  <tromey@adacore.com>
6344
6345         * windows-nat.c (windows_nat_target::attach)
6346         (windows_nat_target::detach): Don't call gdb_flush.
6347         * valprint.c (generic_val_print, val_print, val_print_string):
6348         Don't call gdb_flush.
6349         * utils.c (defaulted_query): Don't call gdb_flush.
6350         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6351         * target.c (target_announce_detach): Don't call gdb_flush.
6352         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6353         * remote.c (extended_remote_target::attach): Don't call
6354         gdb_flush.
6355         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6356         * printcmd.c (do_examine): Don't call gdb_flush.
6357         (info_display_command): Don't call gdb_flush.
6358         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6359         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6360         * memattr.c (info_mem_command): Don't call gdb_flush.
6361         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6362         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6363         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6364         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6365         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6366         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6367         (gnu_nat_target::detach): Don't call gdb_flush.
6368         * f-valprint.c (f_val_print): Don't call gdb_flush.
6369         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6370         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6371         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6372         gdb_flush.
6373         * c-valprint.c (c_val_print): Don't call gdb_flush.
6374         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6375
6376 2019-03-05  Tom Tromey  <tromey@adacore.com>
6377
6378         * varobj.c (update_dynamic_varobj_children): Update.
6379         (install_default_visualizer): Use reset, not release.
6380         * value.c (set_internalvar): Update.
6381         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6382         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6383         ATTRIBUTE_UNUSED_RESULT.
6384
6385 2019-03-05  Tom Tromey  <tromey@adacore.com>
6386
6387         * remote.c (class scoped_remote_fd) <release>: Add
6388         ATTRIBUTE_UNUSED_RESULT.
6389
6390 2019-03-05  Tom Tromey  <tromey@adacore.com>
6391
6392         * macroexp.c (struct macro_buffer) <release>: Add
6393         ATTRIBUTE_UNUSED_RESULT.
6394
6395 2019-03-05  Tom Tromey  <tromey@adacore.com>
6396
6397         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6398         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6399         ATTRIBUTE_UNUSED_RESULT.
6400
6401 2019-03-05  Tom Tromey  <tromey@adacore.com>
6402
6403         * common/scoped_fd.h (class scoped_fd) <release>: Add
6404         ATTRIBUTE_UNUSED_RESULT.
6405
6406 2019-03-05  Tom Tromey  <tromey@adacore.com>
6407
6408         * parser-defs.h (struct parser_state) <release>: Add
6409         ATTRIBUTE_UNUSED_RESULT.
6410
6411 2019-03-05  Tom Tromey  <tromey@adacore.com>
6412
6413         * utils.h (class gdb_argv) <release>: Add
6414         ATTRIBUTE_UNUSED_RESULT.
6415         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6416
6417 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6418
6419         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6420         for-loop range, to avoid compiler warnings.
6421
6422         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6423         avoid compiler warnings about unused variables.
6424
6425         * NEWS: Mention end of support for native debugging on MS-Windows
6426         before XP.
6427
6428         PR gdb/24292
6429         * common/netstuff.c:
6430         * gdbserver/gdbreplay.c
6431         * gdbserver/remote-utils.c:
6432         * ser-tcp.c:
6433         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6434         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6435         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6436         'getaddrinfo' and 'freeaddrinfo' were not available before
6437         Windows XP, and mingw.org's MinGW headers by default define
6438         _WIN32_WINNT to 0x500.
6439
6440 2019-03-01  Gary Benson <gbenson@redhat.com>
6441
6442         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6443
6444 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6445             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6446
6447         PR gdb/8527
6448         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6449         set_sigint_trap, clear_sigint_trap.
6450
6451 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6452
6453         * target.c (target_detach): Clear the regcache and the
6454         frame cache.
6455
6456 2019-02-27  Pedro Alves  <palves@redhat.com>
6457
6458         * utils.c (set_screen_size): When we cap the height/width sizes,
6459         tweak the corresponding command variable to show "unlimited":
6460
6461 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6462             Pedro Alves  <palves@redhat.com>
6463
6464         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6465         before calling rl_set_screen_size.
6466
6467 2019-02-27  Tom Tromey  <tromey@adacore.com>
6468
6469         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6470         define.
6471         * python/py-value.c: Remove Python 2.4 workaround.
6472         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6473         workaround.
6474         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6475         Python 2.4 workaround.
6476         * python/python-internal.h: Remove Python 2.4 comment.
6477         (Py_ssize_t): Don't define.
6478         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6479         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6480         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6481         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6482         * python/python.c (do_start_initialization): Remove Python 2.4
6483         workaround.
6484         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6485         (print_children): Remove Python 2.4 workaround.
6486         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6487         workaround.
6488         (CHARBUFFERPROC_NAME): Remove.
6489         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6490         Python 2.4 workaround.
6491
6492 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6493
6494         * NEWS: Note minimum Python version.
6495
6496 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6497
6498         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6499         code from these functions.  Remove corresponding ifdefs.  Use
6500         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6501         Remove gotos and target of gotos.
6502         (infpy_search_memory): Likewise.
6503
6504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6505
6506         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6507         (hppa_gdbarch_init): Don't register deleted functions with
6508         gdbarch.
6509
6510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6513         (h8300_unwind_sp): Delete.
6514         (h8300_dummy_id): Delete.
6515         (h8300_gdbarch_init): Don't register deleted functions with
6516         gdbarch.
6517
6518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6519
6520         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6521         (ft32_unwind_pc): Delete.
6522         (ft32_unwind_sp): Delete.
6523         (ft32_gdbarch_init): Don't register deleted functions with
6524         gdbarch.
6525
6526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6529         (frv_unwind_pc): Delete.
6530         (frv_unwind_sp): Delete.
6531         (frv_gdbarch_init): Don't register deleted functions with
6532         gdbarch.
6533
6534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6535
6536         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6537         (riscv_unwind_pc): Delete.
6538         (riscv_unwind_sp): Delete.
6539         (riscv_gdbarch_init): Don't register deleted functions with
6540         gdbarch.
6541
6542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6545         (csky_unwind_pc): Delete.
6546         (csky_unwind_sp): Delete.
6547         (csky_gdbarch_init): Don't register deleted functions with
6548         gdbarch.
6549
6550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6553         (cris_unwind_pc): Delete.
6554         (cris_unwind_sp): Delete.
6555         (cris_gdbarch_init): Don't register deleted functions with
6556         gdbarch.
6557
6558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6559
6560         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6561         (bfin_unwind_pc): Delete.
6562         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6563
6564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6567         (arm_unwind_pc): Delete.
6568         (arm_unwind_sp): Delete.
6569         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6570
6571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6574         (arc_unwind_pc): Delete.
6575         (arc_unwind_sp): Delete.
6576         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6577
6578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6579
6580         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6581         (alpha_unwind_pc): Delete.
6582         (alpha_gdbarch_init): Don't register deleted functions with
6583         gdbarch.
6584
6585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6588         (aarch64_unwind_pc): Delete.
6589         (aarch64_unwind_sp): Delete.
6590         (aarch64_gdbarch_init): Don't register deleted functions with
6591         gdbarch.
6592
6593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6594
6595         * gdbtypes.c (type_align): Don't consider static members when
6596         computing structure alignment.
6597
6598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6599
6600         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6601         return 0 for other types.
6602         * arch-utils.c (default_type_align): Always return 0.
6603         * gdbarch.h: Regenerate.
6604         * gdbarch.sh (type_align): Extend comment.
6605         * gdbtypes.c (type_align): Add additional comments, always call
6606         gdbarch_type_align before applying the default rules.
6607         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6608         generic code will then apply a suitable default.
6609         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6610         types, return 0 for other types.
6611
6612 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6613
6614         * NEWS: Create a new section for the next release branch.
6615         Rename the section of the current branch, now that it has
6616         been cut.
6617
6618 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6619
6620         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6621         * version.in: Bump version to 8.3.50.DATE-git.
6622
6623 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6624
6625         * aix-thread.c (ptid_cmp): Remove unused variable.
6626         (get_signaled_thread): Likewise.
6627         (store_regs_user_thread): Likewise.
6628         (store_regs_kernel_thread): Likewise.
6629         (fetch_regs_kernel_thread): Remove shadowed variable.
6630
6631 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * features/riscv/32bit-cpu.xml: Add register numbers.
6634         * features/riscv/32bit-fpu.c: Regenerate.
6635         * features/riscv/32bit-fpu.xml: Add register numbers.
6636         * features/riscv/64bit-cpu.xml: Add register numbers.
6637         * features/riscv/64bit-fpu.c: Regenerate.
6638         * features/riscv/64bit-fpu.xml: Add register numbers.
6639
6640 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6641
6642         * NEWS: Mention two argument form of gdb.Value constructor.
6643         * python/py-value.c (convert_buffer_and_type_to_value): New
6644         function.
6645         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6646         Add support for handling an optional second argument.  Call
6647         convert_buffer_and_type_to_value as appropriate.
6648         * python/python-internal.h (Py_buffer_deleter): New struct.
6649         (Py_buffer_up): New typedef.
6650
6651 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6652
6653         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6654         instead of releasing ownership.
6655
6656 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6657
6658         * dwarf2read.c (open_and_init_dwp_file): Call
6659         elf_numsections instead of bfd_count_sections to initialize
6660         dwp_file->num_sections.
6661
6662 2019-02-25  Tom Tromey  <tromey@adacore.com>
6663
6664         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6665
6666 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6667
6668         * gcore.in: Add '--readnever' option when invoking GDB.
6669
6670 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6671
6672         * MAINTAINERS: Update my email address.
6673
6674 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6675
6676         * build-id.c (build_id_to_debug_bfd_1): New function.
6677         (build_id_to_debug_bfd): Look for separate debug file in
6678         sysroot.
6679
6680 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * gdbarch.sh: Update the copyright year range that is placed into
6683         generated files.
6684
6685 2019-02-22  Keith Seitz  <keiths@redhat.com>
6686
6687         PR symtab/23853
6688         * linespec.c (create_sals_line_offset): Search for the default
6689         symtab's filename instead of its fullname.
6690
6691 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6692
6693         * NEWS: Update style defaults.
6694
6695 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6696
6697         * main.c (captured_main_1): Disable styling in batch mode.
6698
6699 2019-02-20  Tom Tromey  <tom@tromey.com>
6700
6701         * symtab.c (symtab_symbol_info): Fix typos.
6702
6703 2019-02-20  Tom Tromey  <tromey@adacore.com>
6704
6705         * findcmd.c (_initialize_mem_search): Use upper case for
6706         metasyntactic variables.
6707
6708 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6709
6710         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6711         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6712
6713 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6714
6715         * top.h (source_file_name): Change to std::string.
6716         * top.c (source_file_name): Likewise.
6717         (command_line_input): Adjust.
6718         * cli/cli-script.c (script_from_file): Adjust.
6719
6720 2019-02-19  Tom Tromey  <tromey@adacore.com>
6721
6722         * ravenscar-thread.c
6723         (ravenscar_thread_target::update_thread_list): Don't call
6724         ada_build_task_list.
6725         * ada-lang.h (ada_build_task_list): Don't declare.
6726         * ada-tasks.c (struct ada_tasks_inferior_data)
6727         <task_list_valid_p>: Now bool.
6728         (read_known_tasks, ada_task_list_changed)
6729         (ada_tasks_invalidate_inferior_data): Update.
6730         (read_known_tasks_array): Return bool.
6731         (read_known_tasks_list): Likewise.
6732         (read_known_tasks): Return void.
6733         (ada_build_task_list): Now static.
6734
6735 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6736
6737         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6738         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6739
6740 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6741
6742         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6743         variant for ada_tasks_pspace_data_handle and
6744         ada_tasks_inferior_data_handle.
6745         (ada_tasks_pspace_data_cleanup): New function.
6746         (ada_tasks_inferior_data_cleanup): New function.
6747
6748 2019-02-17  Tom Tromey  <tom@tromey.com>
6749
6750         * macrotab.h (macro_source_fullname): Return a std::string.
6751         * macrotab.c (macro_include, check_for_redefinition)
6752         (macro_undef, macro_lookup_definition, foreach_macro)
6753         (foreach_macro_in_scope): Update.
6754         (macro_source_fullname): Return a std::string.
6755         * macrocmd.c (show_pp_source_pos): Update.
6756
6757 2019-02-17  Tom Tromey  <tom@tromey.com>
6758
6759         * macrocmd.c (show_pp_source_pos): Style the file names.
6760
6761 2019-02-17  Tom Tromey  <tom@tromey.com>
6762
6763         PR tui/24197:
6764         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6765
6766 2019-02-17  Tom Tromey  <tom@tromey.com>
6767
6768         * ada-lang.c (user_select_syms): Use filtered printing.
6769         * utils.c (wrap_style): New global.
6770         (desired_style): Remove.
6771         (emit_style_escape): Add stream parameter.
6772         (set_output_style, reset_terminal_style, prompt_for_continue):
6773         Update.
6774         (flush_wrap_buffer): Only flush gdb_stdout.
6775         (wrap_here): Set wrap_style.
6776         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6777         treat escape sequences as a character.  Change when wrap buffer is
6778         flushed.
6779         (fputs_styled): Do not set the output style when the default is
6780         requested.
6781         * ui-style.h (struct ui_file_style) <is_default>: New method.
6782         * source.c (print_source_lines_base): Emit escape sequences in one
6783         piece.
6784
6785 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6786
6787         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6788         integers and enumeration types.
6789
6790 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6791
6792         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6793         instead of lookup_symbol_in_language
6794         (do_exact_match): New function.
6795         (ada_get_symbol_name_matcher): Return do_exact_match when
6796         doing a verbatim match.
6797
6798 2019-02-15  Tom Tromey  <tromey@adacore.com>
6799
6800         * ravenscar-thread.c (ravenscar_thread_target::resume)
6801         (ravenscar_thread_target::wait): Special case wildcard requests.
6802
6803 2019-02-15  Tom Tromey  <tromey@adacore.com>
6804
6805         * ravenscar-thread.c (base_ptid): Remove.
6806         (struct ravenscar_thread_target) <close>: New method.
6807         <m_base_ptid>: New member.
6808         <update_inferior_ptid, active_task, task_is_currently_active,
6809         runtime_initialized>: Declare methods.
6810         <ravenscar_thread_target>: Add constructor.
6811         (ravenscar_thread_target::task_is_currently_active)
6812         (ravenscar_thread_target::update_inferior_ptid)
6813         (ravenscar_runtime_initialized): Rename.  Now methods.
6814         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6815         (ravenscar_thread_target::update_thread_list): Update.
6816         (ravenscar_thread_target::active_task): Now method.
6817         (ravenscar_thread_target::store_registers)
6818         (ravenscar_thread_target::prepare_to_store)
6819         (ravenscar_thread_target::prepare_to_store)
6820         (ravenscar_thread_target::mourn_inferior): Update.
6821         (ravenscar_inferior_created): Use "new" to create target.
6822         (ravenscar_thread_target::get_ada_task_ptid): Update.
6823         (_initialize_ravenscar): Don't initialize base_ptid.
6824         (ravenscar_ops): Remove global.
6825
6826 2019-02-15  Tom Tromey  <tromey@adacore.com>
6827
6828         * target.h (push_target): Declare new overload.
6829         * target.c (push_target): New overload, taking an rvalue reference.
6830         * remote.c (remote_target::open_1): Use push_target overload.
6831         * corelow.c (core_target_open): Use push_target overload.
6832
6833 2019-02-15  Tom Tromey  <tromey@adacore.com>
6834
6835         * ravenscar-thread.c (is_ravenscar_task)
6836         (ravenscar_task_is_currently_active): Return bool.
6837         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6838         (_initialize_ravenscar): Remove "(void)".
6839         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6840         Return bool.
6841
6842 2019-02-15  Tom Tromey  <tromey@adacore.com>
6843
6844         * ravenscar-thread.c (ravenscar_runtime_initializer)
6845         (has_ravenscar_runtime, get_running_thread_id)
6846         (ravenscar_thread_target::resume): Fix indentation.
6847
6848 2019-02-15  Tom Tromey  <tromey@adacore.com>
6849
6850         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6851         from ravenscar_arch_ops.
6852         (sparc_ravenscar_ops::fetch_registers)
6853         (sparc_ravenscar_ops::store_registers): Now methods.
6854         (sparc_ravenscar_prepare_to_store): Remove.
6855         (sparc_ravenscar_ops): Redefine.
6856         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6857         methods and destructor.  Remove members.
6858         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6859         (ravenscar_thread_target::store_registers)
6860         (ravenscar_thread_target::prepare_to_store): Update.
6861         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6862         Remove.
6863         (struct ppc_ravenscar_powerpc_ops): Derive from
6864         ravenscar_arch_ops.
6865         (ppc_ravenscar_powerpc_ops::fetch_registers)
6866         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6867         (ppc_ravenscar_powerpc_ops): Redefine.
6868         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6869         (ppc_ravenscar_e500_ops::fetch_registers)
6870         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6871         (ppc_ravenscar_e500_ops): Redefine.
6872         * aarch64-ravenscar-thread.c
6873         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6874         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6875         (aarch64_ravenscar_fetch_registers)
6876         (aarch64_ravenscar_store_registers): Now methods.
6877         (aarch64_ravenscar_ops): Redefine.
6878
6879 2019-02-15  Tom Tromey  <tromey@adacore.com>
6880
6881         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6882         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6883         (ravenscar_thread_target::stopped_by_watchpoint)
6884         (ravenscar_thread_target::stopped_data_address)
6885         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6886
6887 2019-02-15  Tom Tromey  <tromey@adacore.com>
6888
6889         * ravenscar-thread.c: Fix some typos.
6890
6891 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6892             Tom Tromey  <tromey@adacore.com>
6893
6894         * ada-lang.c (ada_exception_sal): Change addr_string to a
6895         std::string.
6896         (create_ada_exception_catchpoint): Update.
6897
6898 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6899             Tom Tromey  <tromey@adacore.com>
6900
6901         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6902         (bp_location_ops): Remove.
6903         (base_breakpoint_allocate_location): Update.
6904         (free_bp_location): Update.
6905         * ada-lang.c (class ada_catchpoint_location)
6906         <ada_catchpoint_location>: Remove ops parameter.
6907         (ada_catchpoint_location_dtor): Remove.
6908         (ada_catchpoint_location_ops): Remove.
6909         (allocate_location_exception): Update.
6910         * breakpoint.h (struct bp_location_ops): Remove.
6911         (class bp_location) <bp_location>: Remove bp_location_ops
6912         parameter.
6913         <~bp_location>: Add destructor.
6914         <ops>: Remove.
6915
6916 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6917             Pedro Alves  <palves@redhat.com>
6918
6919         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6920         'PATH_MAX'.
6921
6922 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6923             Samuel Thibault  <samuel.thibault@gnu.org>
6924             Thomas Schwinge  <thomas@codesourcery.com>
6925
6926         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6927         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6928
6929 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6930
6931         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6932         (check_empty): Use "const char *".
6933
6934         * gnu-nat.c (gnu_nat_target::detach): Instead of
6935         'detach_inferior (pid)' call
6936         'detach_inferior (find_inferior_pid (pid))'.
6937
6938         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6939         'nat/fork-inferior.o'.
6940         * gnu-nat.c: #include "nat/fork-inferior.h".
6941
6942         * gnu-nat.c (gnu_nat_target::detach): Instead of
6943         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6944         * gnu-nat.h: #include "inf-child.h".
6945         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6946         'i386_gnu_nat_target::fetch_registers'.
6947         (gnu_store_registers): Rename/move to
6948         'i386_gnu_nat_target::store_registers'.
6949
6950         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6951         * gnu-nat.h (mach_thread_info): New function.
6952         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6953
6954         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6955
6956 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6957
6958         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6959
6960 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6961
6962         * windows-nat.c (windows_add_thread): Add new parameter
6963         "main_thread_p" with default value set to false.  Update
6964         function documentation as well as all callers.
6965         (windows_delete_thread): Likewise.
6966         (fake_create_process): Update call to windows_add_thread.
6967         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6968         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6969         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6970         call to windows_delete_thread.
6971
6972 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6973
6974         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6975
6976 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6977
6978         * symfile.c (find_separate_debug_file): Use canonical path of
6979         sysroot with child_path instead of gdb_sysroot if it is valid.
6980
6981 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6982
6983         * symfile.c (find_separate_debug_file): Use child_path to
6984         determine if an object file is under a sysroot.
6985
6986 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6987
6988         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6989         unittests/child-path-selftests.c.
6990         * common/pathstuff.c (child_path): New function.
6991         * common/pathstuff.h (child_path): New prototype.
6992         * unittests/child-path-selftests.c: New file.
6993
6994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6995
6996         * symfile.c (find_separate_debug_file): Look for separate debug
6997         files in debug directories under the sysroot.
6998
6999 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7000
7001         * symtab.h (struct minimal_symbol data_p): New const method.
7002         (struct minimal_symbol text_p): Likewise.
7003         * symtab.c (output_source_filename): Use file name style
7004         to print file name.
7005         (print_symbol_info): Likewise.
7006         (print_msymbol_info): Use address style to print addresses.
7007         Use function name style to print executable text symbols.
7008         (expand_symtab_containing_pc): Use data_p.
7009         (find_pc_sect_compunit_symtab): Likewise.
7010
7011 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7012
7013         * breakpoint.c (describe_other_breakpoints): Use address style
7014         to print addresses.
7015         (say_where): Likewise.
7016
7017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7018
7019         * ada-typeprint.c (print_func_type): Print function name
7020         style to print function name.
7021         * c-typeprint.c (c_print_type_1): Likewise.
7022
7023 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7024
7025         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7026         for execve.
7027
7028 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7029
7030         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7031         type_stack.
7032
7033 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7034
7035         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7036         TYPE_CODE_REF types.
7037
7038 2019-02-08  Jim Wilson  <jimw@sifive.com>
7039
7040         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7041         (riscv_linux_fregset): New.
7042         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7043
7044 2019-02-07  Tom Tromey  <tom@tromey.com>
7045
7046         * thread.c (thread_cancel_execution_command): Update.
7047         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7048         methods.
7049         (struct thread_fsm_ops): Remove.
7050         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7051         (thread_fsm_should_stop, thread_fsm_return_value)
7052         (thread_fsm_set_finished, thread_fsm_finished_p)
7053         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7054         Don't declare.
7055         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7056         * infrun.c (clear_proceed_status_thread)
7057         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7058         (print_stop_event): Update.
7059         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7060         Add constructor.
7061         (step_command_fsm_ops): Remove.
7062         (new_step_command_fsm): Remove.
7063         (step_1): Update.
7064         (step_command_fsm::should_stop): Rename from
7065         step_command_fsm_should_stop.
7066         (step_command_fsm::clean_up): Rename from
7067         step_command_fsm_clean_up.
7068         (step_command_fsm::do_async_reply_reason): Rename from
7069         step_command_fsm_async_reply_reason.
7070         (struct until_next_fsm): Inherit from thread_fsm.  Add
7071         constructor.
7072         (until_next_fsm_ops): Remove.
7073         (new_until_next_fsm): Remove.
7074         (until_next_fsm::should_stop): Rename from
7075         until_next_fsm_should_stop.
7076         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7077         (until_next_fsm::do_async_reply_reason): Rename from
7078         until_next_fsm_async_reply_reason.
7079         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7080         constructor.  Change type of breakpoint.
7081         (finish_command_fsm_ops): Remove.
7082         (new_finish_command_fsm): Remove.
7083         (finish_command_fsm::should_stop): Rename from
7084         finish_command_fsm_should_stop.
7085         (finish_command_fsm::clean_up): Rename from
7086         finish_command_fsm_clean_up.
7087         (finish_command_fsm::return_value): Rename from
7088         finish_command_fsm_return_value.
7089         (finish_command_fsm::do_async_reply_reason): Rename from
7090         finish_command_fsm_async_reply_reason.
7091         (finish_command): Update.
7092         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7093         Add constructor.
7094         (call_thread_fsm_ops): Remove.
7095         (call_thread_fsm::call_thread_fsm): Rename from
7096         new_call_thread_fsm.
7097         (call_thread_fsm::should_stop): Rename from
7098         call_thread_fsm_should_stop.
7099         (call_thread_fsm::should_notify_stop): Rename from
7100         call_thread_fsm_should_notify_stop.
7101         (run_inferior_call, call_function_by_hand_dummy): Update.
7102         * cli/cli-interp.c (should_print_stop_to_console): Update.
7103         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7104         Add constructor.  Change type of location_breakpoint,
7105         caller_breakpoint.
7106         (until_break_fsm_ops): Remove.
7107         (new_until_break_fsm): Remove.
7108         (until_break_fsm::should_stop): Rename from
7109         until_break_fsm_should_stop.
7110         (until_break_fsm::clean_up): Rename from
7111         until_break_fsm_clean_up.
7112         (until_break_fsm::do_async_reply_reason): Rename from
7113         until_break_fsm_async_reply_reason.
7114         (until_break_command): Update.
7115         * thread-fsm.c: Remove.
7116         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7117
7118 2019-02-07  Tom Tromey  <tom@tromey.com>
7119
7120         * yy-remap.h: Add include guard.
7121         * xtensa-tdep.h: Add include guard.
7122         * xcoffread.h: Rename include guard.
7123         * varobj-iter.h: Add include guard.
7124         * tui/tui.h: Rename include guard.
7125         * tui/tui-winsource.h: Rename include guard.
7126         * tui/tui-wingeneral.h: Rename include guard.
7127         * tui/tui-windata.h: Rename include guard.
7128         * tui/tui-win.h: Rename include guard.
7129         * tui/tui-stack.h: Rename include guard.
7130         * tui/tui-source.h: Rename include guard.
7131         * tui/tui-regs.h: Rename include guard.
7132         * tui/tui-out.h: Rename include guard.
7133         * tui/tui-layout.h: Rename include guard.
7134         * tui/tui-io.h: Rename include guard.
7135         * tui/tui-hooks.h: Rename include guard.
7136         * tui/tui-file.h: Rename include guard.
7137         * tui/tui-disasm.h: Rename include guard.
7138         * tui/tui-data.h: Rename include guard.
7139         * tui/tui-command.h: Rename include guard.
7140         * tic6x-tdep.h: Add include guard.
7141         * target/waitstatus.h: Rename include guard.
7142         * target/wait.h: Rename include guard.
7143         * target/target.h: Rename include guard.
7144         * target/resume.h: Rename include guard.
7145         * target-float.h: Rename include guard.
7146         * stabsread.h: Add include guard.
7147         * rs6000-tdep.h: Add include guard.
7148         * riscv-fbsd-tdep.h: Add include guard.
7149         * regformats/regdef.h: Rename include guard.
7150         * record.h: Rename include guard.
7151         * python/python.h: Rename include guard.
7152         * python/python-internal.h: Rename include guard.
7153         * python/py-stopevent.h: Rename include guard.
7154         * python/py-ref.h: Rename include guard.
7155         * python/py-record.h: Rename include guard.
7156         * python/py-record-full.h: Rename include guard.
7157         * python/py-record-btrace.h: Rename include guard.
7158         * python/py-instruction.h: Rename include guard.
7159         * python/py-events.h: Rename include guard.
7160         * python/py-event.h: Rename include guard.
7161         * procfs.h: Add include guard.
7162         * proc-utils.h: Add include guard.
7163         * p-lang.h: Add include guard.
7164         * or1k-tdep.h: Rename include guard.
7165         * observable.h: Rename include guard.
7166         * nto-tdep.h: Rename include guard.
7167         * nat/x86-linux.h: Rename include guard.
7168         * nat/x86-linux-dregs.h: Rename include guard.
7169         * nat/x86-gcc-cpuid.h: Add include guard.
7170         * nat/x86-dregs.h: Rename include guard.
7171         * nat/x86-cpuid.h: Rename include guard.
7172         * nat/ppc-linux.h: Rename include guard.
7173         * nat/mips-linux-watch.h: Rename include guard.
7174         * nat/linux-waitpid.h: Rename include guard.
7175         * nat/linux-ptrace.h: Rename include guard.
7176         * nat/linux-procfs.h: Rename include guard.
7177         * nat/linux-osdata.h: Rename include guard.
7178         * nat/linux-nat.h: Rename include guard.
7179         * nat/linux-namespaces.h: Rename include guard.
7180         * nat/linux-btrace.h: Rename include guard.
7181         * nat/glibc_thread_db.h: Rename include guard.
7182         * nat/gdb_thread_db.h: Rename include guard.
7183         * nat/gdb_ptrace.h: Rename include guard.
7184         * nat/fork-inferior.h: Rename include guard.
7185         * nat/amd64-linux-siginfo.h: Rename include guard.
7186         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7187         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7188         * nat/aarch64-linux.h: Rename include guard.
7189         * nat/aarch64-linux-hw-point.h: Rename include guard.
7190         * mn10300-tdep.h: Add include guard.
7191         * mips-linux-tdep.h: Add include guard.
7192         * mi/mi-parse.h: Rename include guard.
7193         * mi/mi-out.h: Rename include guard.
7194         * mi/mi-main.h: Rename include guard.
7195         * mi/mi-interp.h: Rename include guard.
7196         * mi/mi-getopt.h: Rename include guard.
7197         * mi/mi-console.h: Rename include guard.
7198         * mi/mi-common.h: Rename include guard.
7199         * mi/mi-cmds.h: Rename include guard.
7200         * mi/mi-cmd-break.h: Rename include guard.
7201         * m2-lang.h: Add include guard.
7202         * location.h: Rename include guard.
7203         * linux-record.h: Rename include guard.
7204         * linux-nat.h: Add include guard.
7205         * linux-fork.h: Add include guard.
7206         * i386-darwin-tdep.h: Rename include guard.
7207         * hppa-linux-offsets.h: Add include guard.
7208         * guile/guile.h: Rename include guard.
7209         * guile/guile-internal.h: Rename include guard.
7210         * gnu-nat.h: Rename include guard.
7211         * gdb-stabs.h: Rename include guard.
7212         * frv-tdep.h: Add include guard.
7213         * f-lang.h: Add include guard.
7214         * event-loop.h: Add include guard.
7215         * darwin-nat.h: Rename include guard.
7216         * cp-abi.h: Rename include guard.
7217         * config/sparc/nm-sol2.h: Rename include guard.
7218         * config/nm-nto.h: Rename include guard.
7219         * config/nm-linux.h: Add include guard.
7220         * config/i386/nm-i386gnu.h: Rename include guard.
7221         * config/djgpp/nl_types.h: Rename include guard.
7222         * config/djgpp/langinfo.h: Rename include guard.
7223         * compile/gcc-cp-plugin.h: Add include guard.
7224         * compile/gcc-c-plugin.h: Add include guard.
7225         * compile/compile.h: Rename include guard.
7226         * compile/compile-object-run.h: Rename include guard.
7227         * compile/compile-object-load.h: Rename include guard.
7228         * compile/compile-internal.h: Rename include guard.
7229         * compile/compile-cplus.h: Rename include guard.
7230         * compile/compile-c.h: Rename include guard.
7231         * common/xml-utils.h: Rename include guard.
7232         * common/x86-xstate.h: Rename include guard.
7233         * common/version.h: Rename include guard.
7234         * common/vec.h: Rename include guard.
7235         * common/tdesc.h: Rename include guard.
7236         * common/selftest.h: Rename include guard.
7237         * common/scoped_restore.h: Rename include guard.
7238         * common/scoped_mmap.h: Rename include guard.
7239         * common/scoped_fd.h: Rename include guard.
7240         * common/safe-iterator.h: Rename include guard.
7241         * common/run-time-clock.h: Rename include guard.
7242         * common/refcounted-object.h: Rename include guard.
7243         * common/queue.h: Rename include guard.
7244         * common/ptid.h: Rename include guard.
7245         * common/print-utils.h: Rename include guard.
7246         * common/preprocessor.h: Rename include guard.
7247         * common/pathstuff.h: Rename include guard.
7248         * common/observable.h: Rename include guard.
7249         * common/netstuff.h: Rename include guard.
7250         * common/job-control.h: Rename include guard.
7251         * common/host-defs.h: Rename include guard.
7252         * common/gdb_wait.h: Rename include guard.
7253         * common/gdb_vecs.h: Rename include guard.
7254         * common/gdb_unlinker.h: Rename include guard.
7255         * common/gdb_unique_ptr.h: Rename include guard.
7256         * common/gdb_tilde_expand.h: Rename include guard.
7257         * common/gdb_sys_time.h: Rename include guard.
7258         * common/gdb_string_view.h: Rename include guard.
7259         * common/gdb_splay_tree.h: Rename include guard.
7260         * common/gdb_setjmp.h: Rename include guard.
7261         * common/gdb_ref_ptr.h: Rename include guard.
7262         * common/gdb_optional.h: Rename include guard.
7263         * common/gdb_locale.h: Rename include guard.
7264         * common/gdb_assert.h: Rename include guard.
7265         * common/filtered-iterator.h: Rename include guard.
7266         * common/filestuff.h: Rename include guard.
7267         * common/fileio.h: Rename include guard.
7268         * common/environ.h: Rename include guard.
7269         * common/common-utils.h: Rename include guard.
7270         * common/common-types.h: Rename include guard.
7271         * common/common-regcache.h: Rename include guard.
7272         * common/common-inferior.h: Rename include guard.
7273         * common/common-gdbthread.h: Rename include guard.
7274         * common/common-exceptions.h: Rename include guard.
7275         * common/common-defs.h: Rename include guard.
7276         * common/common-debug.h: Rename include guard.
7277         * common/cleanups.h: Rename include guard.
7278         * common/buffer.h: Rename include guard.
7279         * common/btrace-common.h: Rename include guard.
7280         * common/break-common.h: Rename include guard.
7281         * cli/cli-utils.h: Rename include guard.
7282         * cli/cli-style.h: Rename include guard.
7283         * cli/cli-setshow.h: Rename include guard.
7284         * cli/cli-script.h: Rename include guard.
7285         * cli/cli-interp.h: Rename include guard.
7286         * cli/cli-decode.h: Rename include guard.
7287         * cli/cli-cmds.h: Rename include guard.
7288         * charset-list.h: Add include guard.
7289         * buildsym-legacy.h: Rename include guard.
7290         * bfin-tdep.h: Add include guard.
7291         * ax.h: Rename include guard.
7292         * arm-linux-tdep.h: Add include guard.
7293         * arm-fbsd-tdep.h: Add include guard.
7294         * arch/xtensa.h: Rename include guard.
7295         * arch/tic6x.h: Add include guard.
7296         * arch/i386.h: Add include guard.
7297         * arch/arm.h: Rename include guard.
7298         * arch/arm-linux.h: Rename include guard.
7299         * arch/arm-get-next-pcs.h: Rename include guard.
7300         * arch/amd64.h: Add include guard.
7301         * arch/aarch64-insn.h: Rename include guard.
7302         * arch-utils.h: Rename include guard.
7303         * annotate.h: Add include guard.
7304         * amd64-darwin-tdep.h: Rename include guard.
7305         * aarch64-linux-tdep.h: Add include guard.
7306         * aarch64-fbsd-tdep.h: Add include guard.
7307         * aarch32-linux-nat.h: Add include guard.
7308
7309 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7310
7311         * macrotab.c (macro_define_internal): New function that
7312         factorizes macro_define_object_internal and macro_define_function
7313         code.
7314         (macro_define_object_internal): Use macro_define_internal.
7315         (macro_define_function): Likewise.
7316
7317 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7318
7319         * macrocmd.c (extract_identifier): Return
7320         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7321         callers.
7322
7323 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7324
7325         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7326
7327 2019-02-05  Tom Tromey  <tom@tromey.com>
7328
7329         * target.c (target_stack::unpush): Move assertion earlier.
7330
7331 2019-01-30  Tom Tromey  <tom@tromey.com>
7332
7333         PR python/23615:
7334         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7335         (gdbpy_parse_and_eval): Likewise.
7336         * python/python-internal.h (gdbpy_allow_threads): New class.
7337
7338 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7339
7340         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7341         (aarch64_fbsd_fpregmap): Move earlier.
7342         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7343         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7344         instead of individual calls to trad_frame_set_reg_addr.
7345         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7346         earlier.
7347         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7348         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7349         instead of individual calls to trad_frame_set_reg_addr.
7350
7351 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7352
7353         * CONTRIBUTE: Replace contribution list with wiki link.
7354
7355 2019-01-25  Tom Tromey  <tom@tromey.com>
7356
7357         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7358
7359 2019-01-25  Tom Tromey  <tom@tromey.com>
7360
7361         * xtensa-linux-nat.c: Fix common/ includes.
7362         * xml-support.h: Fix common/ includes.
7363         * xml-support.c: Fix common/ includes.
7364         * x86-linux-nat.c: Fix common/ includes.
7365         * windows-nat.c: Fix common/ includes.
7366         * varobj.h: Fix common/ includes.
7367         * varobj.c: Fix common/ includes.
7368         * value.c: Fix common/ includes.
7369         * valops.c: Fix common/ includes.
7370         * utils.c: Fix common/ includes.
7371         * unittests/xml-utils-selftests.c: Fix common/ includes.
7372         * unittests/utils-selftests.c: Fix common/ includes.
7373         * unittests/unpack-selftests.c: Fix common/ includes.
7374         * unittests/tracepoint-selftests.c: Fix common/ includes.
7375         * unittests/style-selftests.c: Fix common/ includes.
7376         * unittests/string_view-selftests.c: Fix common/ includes.
7377         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7378         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7379         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7380         * unittests/rsp-low-selftests.c: Fix common/ includes.
7381         * unittests/parse-connection-spec-selftests.c: Fix common/
7382         includes.
7383         * unittests/optional-selftests.c: Fix common/ includes.
7384         * unittests/offset-type-selftests.c: Fix common/ includes.
7385         * unittests/observable-selftests.c: Fix common/ includes.
7386         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7387         * unittests/memrange-selftests.c: Fix common/ includes.
7388         * unittests/memory-map-selftests.c: Fix common/ includes.
7389         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7390         * unittests/function-view-selftests.c: Fix common/ includes.
7391         * unittests/environ-selftests.c: Fix common/ includes.
7392         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7393         * unittests/common-utils-selftests.c: Fix common/ includes.
7394         * unittests/cli-utils-selftests.c: Fix common/ includes.
7395         * unittests/array-view-selftests.c: Fix common/ includes.
7396         * ui-file.c: Fix common/ includes.
7397         * tui/tui-io.c: Fix common/ includes.
7398         * tracepoint.h: Fix common/ includes.
7399         * tracepoint.c: Fix common/ includes.
7400         * tracefile-tfile.c: Fix common/ includes.
7401         * top.h: Fix common/ includes.
7402         * top.c: Fix common/ includes.
7403         * thread.c: Fix common/ includes.
7404         * target/waitstatus.h: Fix common/ includes.
7405         * target/waitstatus.c: Fix common/ includes.
7406         * target.h: Fix common/ includes.
7407         * target.c: Fix common/ includes.
7408         * target-memory.c: Fix common/ includes.
7409         * target-descriptions.c: Fix common/ includes.
7410         * symtab.h: Fix common/ includes.
7411         * symfile.c: Fix common/ includes.
7412         * stap-probe.c: Fix common/ includes.
7413         * spu-linux-nat.c: Fix common/ includes.
7414         * sparc-nat.c: Fix common/ includes.
7415         * source.c: Fix common/ includes.
7416         * solib.c: Fix common/ includes.
7417         * solib-target.c: Fix common/ includes.
7418         * ser-unix.c: Fix common/ includes.
7419         * ser-tcp.c: Fix common/ includes.
7420         * ser-pipe.c: Fix common/ includes.
7421         * ser-base.c: Fix common/ includes.
7422         * selftest-arch.c: Fix common/ includes.
7423         * s12z-tdep.c: Fix common/ includes.
7424         * rust-exp.y: Fix common/ includes.
7425         * rs6000-aix-tdep.c: Fix common/ includes.
7426         * riscv-tdep.c: Fix common/ includes.
7427         * remote.c: Fix common/ includes.
7428         * remote-notif.h: Fix common/ includes.
7429         * remote-fileio.h: Fix common/ includes.
7430         * remote-fileio.c: Fix common/ includes.
7431         * regcache.h: Fix common/ includes.
7432         * regcache.c: Fix common/ includes.
7433         * record-btrace.c: Fix common/ includes.
7434         * python/python.c: Fix common/ includes.
7435         * python/py-type.c: Fix common/ includes.
7436         * python/py-inferior.c: Fix common/ includes.
7437         * progspace.h: Fix common/ includes.
7438         * producer.c: Fix common/ includes.
7439         * procfs.c: Fix common/ includes.
7440         * proc-api.c: Fix common/ includes.
7441         * printcmd.c: Fix common/ includes.
7442         * ppc-linux-nat.c: Fix common/ includes.
7443         * parser-defs.h: Fix common/ includes.
7444         * osdata.c: Fix common/ includes.
7445         * obsd-nat.c: Fix common/ includes.
7446         * nat/x86-linux.c: Fix common/ includes.
7447         * nat/x86-linux-dregs.c: Fix common/ includes.
7448         * nat/x86-dregs.h: Fix common/ includes.
7449         * nat/x86-dregs.c: Fix common/ includes.
7450         * nat/ppc-linux.c: Fix common/ includes.
7451         * nat/mips-linux-watch.h: Fix common/ includes.
7452         * nat/mips-linux-watch.c: Fix common/ includes.
7453         * nat/linux-waitpid.c: Fix common/ includes.
7454         * nat/linux-ptrace.h: Fix common/ includes.
7455         * nat/linux-ptrace.c: Fix common/ includes.
7456         * nat/linux-procfs.c: Fix common/ includes.
7457         * nat/linux-personality.c: Fix common/ includes.
7458         * nat/linux-osdata.c: Fix common/ includes.
7459         * nat/linux-namespaces.c: Fix common/ includes.
7460         * nat/linux-btrace.h: Fix common/ includes.
7461         * nat/linux-btrace.c: Fix common/ includes.
7462         * nat/fork-inferior.c: Fix common/ includes.
7463         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7464         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7465         * nat/aarch64-linux.c: Fix common/ includes.
7466         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7467         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7468         * namespace.h: Fix common/ includes.
7469         * mips-linux-tdep.c: Fix common/ includes.
7470         * minsyms.c: Fix common/ includes.
7471         * mi/mi-parse.h: Fix common/ includes.
7472         * mi/mi-main.c: Fix common/ includes.
7473         * mi/mi-cmd-env.c: Fix common/ includes.
7474         * memrange.h: Fix common/ includes.
7475         * memattr.c: Fix common/ includes.
7476         * maint.h: Fix common/ includes.
7477         * maint.c: Fix common/ includes.
7478         * main.c: Fix common/ includes.
7479         * machoread.c: Fix common/ includes.
7480         * location.c: Fix common/ includes.
7481         * linux-thread-db.c: Fix common/ includes.
7482         * linux-nat.c: Fix common/ includes.
7483         * linux-fork.c: Fix common/ includes.
7484         * inline-frame.c: Fix common/ includes.
7485         * infrun.c: Fix common/ includes.
7486         * inflow.c: Fix common/ includes.
7487         * inferior.h: Fix common/ includes.
7488         * inferior.c: Fix common/ includes.
7489         * infcmd.c: Fix common/ includes.
7490         * inf-ptrace.c: Fix common/ includes.
7491         * inf-child.c: Fix common/ includes.
7492         * ia64-linux-nat.c: Fix common/ includes.
7493         * i387-tdep.c: Fix common/ includes.
7494         * i386-tdep.c: Fix common/ includes.
7495         * i386-linux-tdep.c: Fix common/ includes.
7496         * i386-linux-nat.c: Fix common/ includes.
7497         * i386-go32-tdep.c: Fix common/ includes.
7498         * i386-fbsd-tdep.c: Fix common/ includes.
7499         * i386-fbsd-nat.c: Fix common/ includes.
7500         * guile/scm-type.c: Fix common/ includes.
7501         * guile/guile.c: Fix common/ includes.
7502         * go32-nat.c: Fix common/ includes.
7503         * gnu-nat.c: Fix common/ includes.
7504         * gdbthread.h: Fix common/ includes.
7505         * gdbarch-selftests.c: Fix common/ includes.
7506         * gdb_usleep.c: Fix common/ includes.
7507         * gdb_select.h: Fix common/ includes.
7508         * gdb_bfd.c: Fix common/ includes.
7509         * gcore.c: Fix common/ includes.
7510         * fork-child.c: Fix common/ includes.
7511         * findvar.c: Fix common/ includes.
7512         * fbsd-nat.c: Fix common/ includes.
7513         * event-top.c: Fix common/ includes.
7514         * event-loop.c: Fix common/ includes.
7515         * dwarf2read.c: Fix common/ includes.
7516         * dwarf2loc.c: Fix common/ includes.
7517         * dwarf2-frame.c: Fix common/ includes.
7518         * dwarf-index-cache.c: Fix common/ includes.
7519         * dtrace-probe.c: Fix common/ includes.
7520         * disasm-selftests.c: Fix common/ includes.
7521         * defs.h: Fix common/ includes.
7522         * csky-tdep.c: Fix common/ includes.
7523         * cp-valprint.c: Fix common/ includes.
7524         * cp-support.h: Fix common/ includes.
7525         * cp-support.c: Fix common/ includes.
7526         * corelow.c: Fix common/ includes.
7527         * completer.h: Fix common/ includes.
7528         * completer.c: Fix common/ includes.
7529         * compile/compile.c: Fix common/ includes.
7530         * compile/compile-loc2c.c: Fix common/ includes.
7531         * compile/compile-cplus-types.c: Fix common/ includes.
7532         * compile/compile-cplus-symbols.c: Fix common/ includes.
7533         * command.h: Fix common/ includes.
7534         * cli/cli-dump.c: Fix common/ includes.
7535         * cli/cli-cmds.c: Fix common/ includes.
7536         * charset.c: Fix common/ includes.
7537         * build-id.c: Fix common/ includes.
7538         * btrace.h: Fix common/ includes.
7539         * btrace.c: Fix common/ includes.
7540         * breakpoint.h: Fix common/ includes.
7541         * breakpoint.c: Fix common/ includes.
7542         * ax.h:
7543         (enum agent_op): Fix common/ includes.
7544         * ax-general.c (struct aop_map): Fix common/ includes.
7545         * ax-gdb.c: Fix common/ includes.
7546         * auxv.c: Fix common/ includes.
7547         * auto-load.c: Fix common/ includes.
7548         * arm-tdep.c: Fix common/ includes.
7549         * arch/riscv.c: Fix common/ includes.
7550         * arch/ppc-linux-common.c: Fix common/ includes.
7551         * arch/i386.c: Fix common/ includes.
7552         * arch/arm.c: Fix common/ includes.
7553         * arch/arm-linux.c: Fix common/ includes.
7554         * arch/arm-get-next-pcs.c: Fix common/ includes.
7555         * arch/amd64.c: Fix common/ includes.
7556         * arch/aarch64.c: Fix common/ includes.
7557         * arch/aarch64-insn.c: Fix common/ includes.
7558         * arch-utils.c: Fix common/ includes.
7559         * amd64-windows-tdep.c: Fix common/ includes.
7560         * amd64-tdep.c: Fix common/ includes.
7561         * amd64-sol2-tdep.c: Fix common/ includes.
7562         * amd64-obsd-tdep.c: Fix common/ includes.
7563         * amd64-nbsd-tdep.c: Fix common/ includes.
7564         * amd64-linux-tdep.c: Fix common/ includes.
7565         * amd64-linux-nat.c: Fix common/ includes.
7566         * amd64-fbsd-tdep.c: Fix common/ includes.
7567         * amd64-fbsd-nat.c: Fix common/ includes.
7568         * amd64-dicos-tdep.c: Fix common/ includes.
7569         * amd64-darwin-tdep.c: Fix common/ includes.
7570         * agent.c: Fix common/ includes.
7571         * ada-lang.h: Fix common/ includes.
7572         * ada-lang.c: Fix common/ includes.
7573         * aarch64-tdep.c: Fix common/ includes.
7574
7575 2019-01-25  Tom Tromey  <tom@tromey.com>
7576
7577         * common/create-version.sh: Use common/version.h.
7578
7579 2019-01-24  Pedro Alves  <palves@redhat.com>
7580
7581         * infrun.c (signal_stop, signal_print, signal_program)
7582         (signal_catch, signal_pass): Now arrays instead of pointers.
7583         (update_signals_program_target, do_target_resume)
7584         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7585         * linux-nat.c (linux_nat_target::pass_signals)
7586         (linux_nat_target::create_inferior, linux_nat_target::attach):
7587         Adjust.
7588         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7589         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7590         * procfs.c (procfs_target::pass_signals): Adjust.
7591         * record-full.c (record_full_target::resume): Adjust.
7592         * remote.c (remote_target::pass_signals)
7593         (remote_target::program_signals): Adjust.
7594         * target-debug.h (target_debug_print_signals): Now takes a
7595         gdb::array_view as parameter.  Adjust.
7596         * target.h (target_ops) <pass_signals, program_signals>: Replace
7597         pointer and length parameters with gdb::array_view.
7598         (target_pass_signals, target_program_signals): Likewise.
7599         * target-delegates.c: Regenerate.
7600
7601 2019-01-24  Pedro Alves  <palves@redhat.com>
7602
7603         * common/forward-scope-exit.h
7604         (forward_scope_exit::forward_scope_exit): Pass arguments to
7605         m_bind_function directly, instead of creating a std::bind and
7606         copying that.
7607
7608 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7609
7610         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7611         for static members.
7612         (pass_in_v_vfp_candidate): Likewise.
7613
7614 2019-01-23  Tom Tromey  <tom@tromey.com>
7615             Pedro Alves  <palves@redhat.com>
7616
7617         * regcache.c (class regcache_invalidator): Remove.
7618         (regcache::raw_write): Use make_scope_exit.
7619
7620 2019-01-23  Tom Tromey  <tom@tromey.com>
7621
7622         * ui-out.h (class ui_out_emit_type): Update comment.
7623
7624 2019-01-23  Tom Tromey  <tom@tromey.com>
7625
7626         * infrun.c (fetch_inferior_event): Update comment.
7627
7628 2019-01-23  Tom Tromey  <tom@tromey.com>
7629             Pedro Alves  <palves@redhat.com>
7630
7631         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7632         parameter.
7633         (fetch_inferior_event): Use SCOPE_EXIT.
7634
7635
7636 2019-01-23  Tom Tromey  <tom@tromey.com>
7637             Pedro Alves  <palves@redhat.com>
7638
7639         * infrun.c (disable_thread_events): Delete.
7640         (stop_all_threads): Use SCOPE_EXIT.
7641
7642 2019-01-23  Tom Tromey  <tom@tromey.com>
7643             Pedro Alves  <palves@redhat.com>
7644
7645         * symfile.c: Include forward-scope-exit.h.
7646         (clear_symtab_users_cleanup): Replace forward declaration with
7647         a FORWARD_SCOPE_EXIT.
7648         (syms_from_objfile_1): Use the forward_scope_exit and
7649         gdb::optional instead of cleanup_function.
7650         (reread_symbols): Use the forward_scope_exit instead of
7651         cleanup_function.
7652         (clear_symtab_users_cleanup): Remove function.
7653
7654 2019-01-23  Tom Tromey  <tom@tromey.com>
7655             Pedro Alves  <palves@redhat.com>
7656
7657         * linux-nat.c: Include scope-exit.h.
7658         (cleanup_target_stop): Remove.
7659         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7660         SCOPE_EXIT.
7661
7662 2019-01-23  Tom Tromey  <tom@tromey.com>
7663             Pedro Alves  <palves@redhat.com>
7664
7665         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7666         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7667
7668 2019-01-23  Tom Tromey  <tom@tromey.com>
7669             Andrew Burgess  <andrew.burgess@embecosm.com>
7670             Pedro Alves  <palves@redhat.com>
7671
7672         * infrun.c (fetch_inferior_event): Use scope_exit.
7673         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7674         * top.c (execute_command): Use scope_exit.
7675         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7676         * utils.c (do_bpstat_clear_actions_cleanup)
7677         (make_bpstat_clear_actions_cleanup): Remove.
7678
7679 2019-01-23  Tom Tromey  <tom@tromey.com>
7680             Pedro Alves  <palves@redhat.com>
7681
7682         * infrun.c: Include "common/scope-exit.h"
7683         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7684         (wait_for_inferior): Use SCOPE_EXIT.
7685         (fetch_inferior_event): Use scope_exit.
7686
7687 2019-01-23  Tom Tromey  <tom@tromey.com>
7688             Pedro Alves  <palves@redhat.com>
7689
7690         * breakpoint.c (create_breakpoint): Remove cleanup.
7691
7692 2019-01-23  Tom Tromey  <tom@tromey.com>
7693             Andrew Burgess  <andrew.burgess@embecosm.com>
7694             Pedro Alves  <palves@redhat.com>
7695
7696 2019-01-23  Pedro Alves  <palves@redhat.com>
7697
7698         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7699
7700 2019-01-23  Pedro Alves  <palves@redhat.com>
7701             Andrew Burgess  <andrew.burgess@embecosm.com>
7702
7703         * gdbthread.h: Include "common/forward-scope-exit.h".
7704         (scoped_finish_thread_state): Redefine custom class in terms of
7705         forward_scope_exit.
7706
7707 2019-01-23  Pedro Alves  <palves@redhat.com>
7708             Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * common/forward-scope-exit.h: New file.
7711
7712 2019-01-23  Pedro Alves  <palves@redhat.com>
7713             Andrew Burgess  <andrew.burgess@embecosm.com>
7714             Tom Tromey  <tom@tromey.com>
7715
7716         * common/scope-exit.h: New file.
7717
7718 2019-01-23  Pedro Alves  <palves@redhat.com>
7719
7720         * common/preprocessor.h (ESC): Rename to ...
7721         (ESC_PARENS): ... this.
7722         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7723         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7724
7725 2019-01-23  Tom Tromey  <tom@tromey.com>
7726
7727         * language.h (class scoped_switch_to_sym_language_if_auto):
7728         Initialize m_lang in both cases.
7729
7730 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7731
7732         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7733         with XCNEW.
7734
7735 2019-01-22  Tom Tromey  <tom@tromey.com>
7736
7737         * corelow.c: Do not include sys/file.h.
7738
7739 2019-01-22  Tom Tromey  <tom@tromey.com>
7740
7741         * tui/tui-wingeneral.h: Include gdb_curses.h.
7742
7743 2019-01-22  Tom Tromey  <tom@tromey.com>
7744
7745         * source-cache.h (class source_cache) <get_source_lines,
7746         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7747
7748 2019-01-22  Tom Tromey  <tom@tromey.com>
7749
7750         * remote-fileio.h (struct remote_target): Declare.
7751
7752 2019-01-22  Tom Tromey  <tom@tromey.com>
7753
7754         * python/py-arch.c: Do not include py-ref.h.
7755         * python/py-bpevent.c: Do not include py-ref.h.
7756         * python/py-cmd.c: Do not include py-ref.h.
7757         * python/py-continueevent.c: Do not include py-ref.h.
7758         * python/py-event.h: Do not include py-ref.h.
7759         * python/py-evtregistry.c: Do not include py-ref.h.
7760         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7761         * python/py-frame.c: Do not include py-ref.h.
7762         * python/py-framefilter.c: Do not include py-ref.h.
7763         * python/py-function.c: Do not include py-ref.h.
7764         * python/py-infevents.c: Do not include py-ref.h.
7765         * python/py-linetable.c: Do not include py-ref.h.
7766         * python/py-objfile.c: Do not include py-ref.h.
7767         * python/py-param.c: Do not include py-ref.h.
7768         * python/py-prettyprint.c: Do not include py-ref.h.
7769         * python/py-progspace.c: Do not include py-ref.h.
7770         * python/py-symbol.c: Do not include py-ref.h.
7771         * python/py-symtab.c: Do not include py-ref.h.
7772         * python/py-type.c: Do not include py-ref.h.
7773         * python/py-unwind.c: Do not include py-ref.h.
7774         * python/py-utils.c: Do not include py-ref.h.
7775         * python/py-value.c: Do not include py-ref.h.
7776         * python/py-varobj.c: Do not include py-ref.h.
7777         * python/py-xmethods.c: Do not include py-ref.h.
7778         * python/python.c: Do not include py-ref.h.
7779         * varobj.c: Do not include py-ref.h.
7780
7781 2019-01-22  Tom Tromey  <tom@tromey.com>
7782
7783         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7784         keyword for bcache.
7785
7786 2019-01-22  Tom Tromey  <tom@tromey.com>
7787
7788         * compile/compile-cplus-types.c: Remove a comment by #include.
7789
7790 2019-01-22  Tom Tromey  <tom@tromey.com>
7791
7792         * compile/gcc-c-plugin.h: Include compile-internal.h.
7793
7794 2019-01-22  Tom Tromey  <tom@tromey.com>
7795
7796         * stabsread.c (EXTERN): Do not define.
7797         (symnum, next_symbol_text_func, processing_gcc_compilation)
7798         (within_function, global_sym_chain, global_stabs)
7799         (previous_stab_code, this_object_header_files)
7800         (n_this_object_header_files)
7801         (n_allocated_this_object_header_files): Define.
7802         * stabsread.h (EXTERN): Never define.  Use "extern".
7803
7804 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7805
7806         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7807         history_value.
7808
7809 2019-01-21  Tom Tromey  <tom@tromey.com>
7810
7811         * ui-out.c: Fix includes.
7812         * tui/tui-source.c: Fix includes.
7813         * target.c: Fix includes.
7814         * remote.c: Fix includes.
7815         * regcache.c: Fix includes.
7816         * python/py-block.c: Fix includes.
7817         * printcmd.c: Fix includes.
7818         * or1k-tdep.c: Fix includes.
7819         * mi/mi-main.c: Fix includes.
7820         * m32r-tdep.c: Fix includes.
7821         * csky-tdep.c: Fix includes.
7822         * compile/compile-cplus-types.c: Fix includes.
7823         * cli/cli-interp.c: Fix includes.
7824
7825 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7826
7827         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7828         for padding.
7829
7830 2019-01-16  Tom Tromey  <tom@tromey.com>
7831
7832         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7833         earlier.
7834         (struct objfile) <msymbols_range>: Move from top level.
7835         <msymbols>: New method.
7836         (class objfile_msymbols): Remove.
7837         * symtab.c (default_collect_symbol_completion_matches_break_on):
7838         Update.
7839         * symmisc.c (dump_msymbols): Update.
7840         * stabsread.c (scan_file_globals): Update.
7841         * objc-lang.c (info_selectors_command, info_classes_command)
7842         (find_methods): Update.
7843         * minsyms.c (find_solib_trampoline_target): Update.
7844         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7845         * coffread.c (coff_symfile_read): Update.
7846         * ada-lang.c (ada_lookup_simple_minsym)
7847         (ada_collect_symbol_completion_matches): Update.
7848
7849 2019-01-16  Tom Tromey  <tom@tromey.com>
7850
7851         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7852         type.  Remove no-argument constructor.
7853         <iterator::operator++>: Simplify.
7854         <begin>: Update.
7855         <end>: Use minimal_symbol_count.
7856
7857 2019-01-16  Tom Tromey  <tom@tromey.com>
7858
7859         * objfiles.h (struct objfile) <psymtabs>: New method.
7860         (class objfile_psymtabs): Remove.
7861         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7862         typedef.
7863         <range>: New method.
7864         (require_partial_symbols): Change return type.
7865         * psymtab.c (require_partial_symbols)
7866         (psym_expand_symtabs_matching): Update.
7867         * mdebugread.c (parse_partial_symbols): Update.
7868         * dbxread.c (dbx_end_psymtab): Update.
7869
7870 2019-01-15  Tom Tromey  <tom@tromey.com>
7871
7872         * symtab.c (lookup_objfile_from_block)
7873         (lookup_symbol_in_objfile_symtabs)
7874         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7875         (find_line_symtab, info_sources_command)
7876         (default_collect_symbol_completion_matches_break_on)
7877         (make_source_files_completion_list): Update.
7878         * symmisc.c (print_objfile_statistics, dump_objfile)
7879         (maintenance_print_symbols, maintenance_info_symtabs)
7880         (maintenance_check_symtabs, maintenance_info_line_tables):
7881         Update.
7882         * source.c (select_source_symtab)
7883         (forget_cached_source_info_for_objfile): Update.
7884         * objfiles.h (class objfile_compunits): Remove.
7885         (struct objfile) <compunits_range>: New typedef.
7886         (compunits): New method.
7887         * objfiles.c (objfile_relocate1): Update.
7888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7889         * maint.c (count_symtabs_and_blocks): Update.
7890         * linespec.c (iterate_over_all_matching_symtabs): Update.
7891         * cp-support.c (add_symbol_overload_list_qualified): Update.
7892         * coffread.c (coff_symtab_read): Update.
7893         * ada-lang.c (add_nonlocal_symbols)
7894         (ada_collect_symbol_completion_matches)
7895         (ada_add_global_exceptions): Update.
7896
7897 2019-01-15  Tom Tromey  <tom@tromey.com>
7898
7899         * progspace.h (program_space) <objfiles_safe_range>: New
7900         typedef.
7901         <objfiles_safe>: New method.
7902         * objfiles.h (class all_objfiles_safe): Remove.
7903         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7904         * jit.c (jit_inferior_exit_hook): Update.
7905
7906 2019-01-17  Tom Tromey  <tom@tromey.com>
7907
7908         * progspace.h (program_space) <objfiles_range>: New typedef.
7909         <objfiles>: New method.
7910         <objfiles_head>: Rename from objfiles.
7911         (object_files): Update.
7912         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7913         * guile/scm-pretty-print.c
7914         (ppscm_find_pretty_printer_from_objfiles): Update.
7915         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7916         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7917         Update.
7918         * python/py-progspace.c (pspy_get_objfiles): Update.
7919         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7920         Update.
7921         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7922         (objfpy_lookup_objfile_by_build_id): Update.
7923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7924         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7925         Update.
7926         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7927         (expand_symtab_containing_pc, lookup_objfile_from_block)
7928         (lookup_static_symbol, basic_lookup_transparent_type)
7929         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7930         (find_line_symtab, info_sources_command)
7931         (default_collect_symbol_completion_matches_break_on)
7932         (make_source_files_completion_list, find_main_name): Update.
7933         * symmisc.c (print_symbol_bcache_statistics)
7934         (print_objfile_statistics, maintenance_print_symbols)
7935         (maintenance_print_msymbols, maintenance_print_objfiles)
7936         (maintenance_info_symtabs, maintenance_check_symtabs)
7937         (maintenance_expand_symtabs, maintenance_info_line_tables):
7938         Update.
7939         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7940         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7941         (map_overlay_command, unmap_overlay_command)
7942         (simple_overlay_update, expand_symtabs_matching)
7943         (map_symbol_filenames): Update.
7944         * symfile-debug.c (set_debug_symfile): Update.
7945         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7946         Update.
7947         * source.c (select_source_symtab, forget_cached_source_info):
7948         Update.
7949         * solib.c (solib_read_symbols): Update.
7950         * solib-spu.c (append_ocl_sos): Update.
7951         * psymtab.c (maintenance_print_psymbols)
7952         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7953         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7954         * printcmd.c (info_symbol_command): Update.
7955         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7956         Update.
7957         * objfiles.h (class all_objfiles): Remove.
7958         * objfiles.c (have_partial_symbols, have_full_symbols)
7959         (have_minimal_symbols, qsort_cmp, update_section_map)
7960         (shared_objfile_contains_address_p)
7961         (default_iterate_over_objfiles_in_search_order): Update.
7962         * objc-lang.c (info_selectors_command, info_classes_command)
7963         (find_methods): Update.
7964         * minsyms.c (find_solib_trampoline_target): Update.
7965         * maint.c (maintenance_info_sections)
7966         (maintenance_translate_address, count_symtabs_and_blocks):
7967         Update.
7968         * main.c (captured_main_1): Update.
7969         * linux-thread-db.c (try_thread_db_load_from_pdir)
7970         (has_libpthread): Update.
7971         * linespec.c (iterate_over_all_matching_symtabs)
7972         (search_minsyms_for_name): Update.
7973         * jit.c (jit_find_objf_with_entry_addr): Update.
7974         * hppa-tdep.c (find_unwind_entry)
7975         (hppa_lookup_stub_minimal_symbol): Update.
7976         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7977         Update.
7978         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7979         (elf_gnu_ifunc_resolve_by_got): Update.
7980         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7981         * dwarf-index-write.c (save_gdb_index_command): Update.
7982         * cp-support.c (add_symbol_overload_list_qualified): Update.
7983         * breakpoint.c (create_overlay_event_breakpoint)
7984         (create_longjmp_master_breakpoint)
7985         (create_std_terminate_master_breakpoint)
7986         (create_exception_master_breakpoint): Update.
7987         * blockframe.c (find_pc_partial_function): Update.
7988         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7989         (ada_collect_symbol_completion_matches)
7990         (ada_add_global_exceptions): Update.
7991
7992 2019-01-17  Tom Tromey  <tom@tromey.com>
7993
7994         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7995         declare VEC.
7996         (solib_target_parse_libraries): Change return type.
7997         (library_list_start_segment, library_list_start_section)
7998         (library_list_end_library, library_list_start_library); Update.
7999         (solib_target_free_library_list): Remove.
8000         (solib_target_parse_libraries): Remove cleanup.  Change return
8001         type.
8002         (solib_target_current_sos): Update.
8003
8004 2019-01-17  Tom Tromey  <tromey@bapiya>
8005
8006         * valprint.c: Replace "the the" with "the".
8007         * symtab.c: Replace "the the" with "the".
8008         * solib.c: Replace "the the" with "the".
8009         * solib-dsbt.c: Replace "the the" with "the".
8010         * linespec.c: Replace "the the" with "the".
8011         * dwarf2loc.h: Replace "the the" with "the".
8012         * amd64-windows-tdep.c: Replace "the the" with "the".
8013         * aarch64-tdep.c: Replace "the the" with "the".
8014
8015 2019-01-16  Keith Seitz  <keiths@redhat.com>
8016
8017         PR gdb/23773
8018         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8019         <builder>: Rename to ..
8020         <m_builder>: ... this and make private.
8021         (dwarf2_cu::get_builder): New method.  Change all users of
8022         `builder' to use this method.
8023         (dwarf2_start_symtab): Move to ...
8024         (dwarf2_cu::start_symtab): ... here.  Update all callers
8025         (setup_type_unit_groups): Move to ...
8026         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8027         callers.
8028         (dwarf2_cu::reset_builder): New method.
8029         (process_full_compunit, process_full_type_unit): Use
8030         dwarf2_cu::reset_builder.
8031         (follow_die_offset): Record the ancestor CU if it is different
8032         from the followed DIE's CU.
8033         (follow_die_sig_1): Likewise.
8034
8035 2019-01-15  Tom Tromey  <tom@tromey.com>
8036
8037         * remote.c (class remote_state) <buf>: Now a char_vector.
8038         <buf_size>: Remove.
8039         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8040         parameter.
8041         (remote_target::getpkt_or_notif_sane_1)
8042         (remote_target::getpkt_sane)
8043         (remote_target::getpkt_or_notif_sane): Likewise.
8044         (class remote_target) <putpkt>: New overload.
8045         (remote_target::read_frame): Change type of "buf_p".  Remove
8046         sizeof_p parameter.
8047         (packet_ok): New overload.
8048         (packet_check_result): New overload.
8049         Update all uses.
8050
8051 2019-01-14  Tom Tromey  <tom@tromey.com>
8052
8053         * remote-notif.c (handle_notification, remote_notif_ack)
8054         (remote_notif_parse): Make "buf" const.
8055         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8056         const.
8057         (remote_notif_parse, remote_notif_ack, handle_notification):
8058         Likewise.
8059         * remote.c (remote_notif_stop_parse): Make "buf" const.
8060         (remote_target::remote_parse_stop_reply): Make "buf" const.
8061         (remote_notif_stop_ack): Make "buf" const.
8062
8063 2019-01-14  Tom Tromey  <tom@tromey.com>
8064
8065         * remote.c (remote_console_output): Make parameter const.
8066
8067 2019-01-14  Tom Tromey  <tom@tromey.com>
8068
8069         * target-debug.h (target_debug_print_signals): Constify.
8070         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8071         * procfs.c (procfs_target::pass_signals): Update.
8072         * linux-nat.c (linux_nat_target::pass_signals): Update.
8073         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8074         * target-delegates.c: Rebuild.
8075         * remote.c (remote_target::program_signals): Update.
8076         (remote_target::pass_signals): Update.
8077         * target.c (target_pass_signals): Constify argument.
8078         (target_program_signals): Likewise.
8079         * target.h (struct target_ops) <pass_signals, program_signals>:
8080         Constify argument.
8081         (target_pass_signals, target_program_signals): Constify argument.
8082
8083 2019-01-14  Tom Tromey  <tom@tromey.com>
8084
8085         PR tui/28819:
8086         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8087
8088 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8089
8090         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8091         field.
8092         * rs6000-tdep.c: Include reggroups.h.
8093         (IS_V_ALIAS_PSEUDOREG): Define.
8094         (rs6000_register_name): Return names for the "vX" aliases.
8095         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8096         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8097         aliases.  Call default_register_reggroup_p for all other
8098         pseudo-registers.
8099         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8100         New functions.
8101         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8102         Handle "vX" aliases.
8103         (v_alias_pseudo_register_collect): New function.
8104         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8105         (rs6000_gdbarch_init): Initialize "vX" aliases as
8106         pseudo-registers.  Restore registration of
8107         rs6000_pseudo_register_reggroup_p with
8108         set_tdesc_pseudo_register_reggroup_p.
8109
8110 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8111
8112         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8113         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8114         set_gdbarch_num_pseudo_regs.
8115
8116 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8117
8118         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8119         Remove arg prefixname, add do_set and do_show.
8120         Add member functions set_list and show_list.
8121         * cli/cli-style.c (class cli_style_option): Update accordingly.
8122         (style_set_list): Move to file scope.
8123         (style_show_list): Likewise.
8124         (set_style): Call help_list.
8125         (show_style): Call cmd_show_list.
8126         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8127         Update to use the new macro.
8128
8129 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8130
8131         * ada-lang.c (_initialize_ada_language): Expand the help text
8132         for the "catch exception" command.
8133
8134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8135
8136         * symtab.c (matching_obj_sections): Initialize obj,
8137         declare it closer to its usage.
8138
8139 2019-01-10  Tom Tromey  <tom@tromey.com>
8140
8141         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8142         (basic_inf_threads_range): Remove.
8143         (inf_threads_range, inf_non_exited_threads_range)
8144         (safe_inf_threads_range): Use next_adapter.
8145
8146 2019-01-10  Keith Seitz  <keiths@redhat.com>
8147
8148         PR gdb/23712
8149         PR symtab/23010
8150         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8151         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8152
8153 2019-01-10  Keith Seitz  <keiths@redhat.com>
8154
8155         PR gdb/23712
8156         PR symtab/23010
8157         * dictionary.c (pending_to_vector): Remove.
8158         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8159         Remove _1 suffix, replacing functions of the same name.  Update
8160         all callers.
8161         (dict_create_hashed, dict_create_hashed_expandable)
8162         (dict_create_linear, dict_create_linear_expandable, dict_free)
8163         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8164         Make functions static.
8165
8166 2019-01-10  Keith Seitz  <keiths@redhat.com>
8167
8168         PR gdb/23712
8169         PR symtab/23010
8170         * dictionary.h (struct dictionary): Replace declaration with
8171         multidictionary.
8172         (dict_create_hashed, dict_create_hashed_expandable)
8173         (dict_create_linear, dict_create_linear_expandable)
8174         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8175         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8176         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8177         taking multidictionary argument.
8178         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8179         * block.h (struct block) <dict>: Change to multidictionary
8180         and rename `multidict'.
8181         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8182         symmisc.c: Update all dictionary references to multidictionary.
8183
8184 2019-01-10  Keith Seitz  <keiths@redhat.com>
8185
8186         PR gdb/23712
8187         PR symtab/23010
8188         * dictionary.c: Include unordered_map.
8189         (pending_to_vector): New function.
8190         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8191         Rewrite the non-"_1" functions to take vector instead
8192         of linked list.
8193         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8194         "new" _1 versions of the same name.
8195         (multidictionary): Define.
8196         (std::hash<enum language): New definition.
8197         (collate_pending_symbols_by_language, mdict_create_hashed)
8198         (mdict_create_hashed_expandable, mdict_create_linear)
8199         (mdict_create_linear_expandable, mdict_free)
8200         (find_language_dictionary, create_new_language_dictionary)
8201         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8202         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8203         (mdict_size, mdict_empty): New functions.
8204         * dictionary.h (mdict_iterator): Define.
8205
8206 2019-01-10  Pedro Alves  <palves@redhat.com>
8207
8208         * breakpoint.c (read_uploaded_action)
8209         (create_tracepoint_from_upload): Adjust to use
8210         gdb::unique_xmalloc_ptr.
8211         * ctf.c (ctf_write_uploaded_tp):
8212         (SET_ARRAY_FIELD): Use emplace_back.
8213         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8214         * tracefile-tfile.c (tfile_write_uploaded_tp):
8215         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8216         gdb::unique_xmalloc_ptr.
8217         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8218         at_string, cond_string, cmd_strings>: Replace char pointers
8219         with gdb::unique_xmalloc_ptr.
8220
8221 2019-01-10  Pedro Alves  <palves@redhat.com>
8222
8223         * solib-target.c (library_list_start_library): Don't xstrdup name.
8224
8225 2019-01-10  Pedro Alves  <palves@redhat.com>
8226
8227         * mdebugread.c (parse_partial_symbols): Use
8228         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8229
8230 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8231
8232         * linux-fork.c (scoped_switch_fork_info)
8233         <~scoped_switch_fork_info>: Fix incorrect variable name.
8234
8235 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8236
8237         * linux-fork.c (scoped_switch_fork_info)
8238         <scoped_switch_fork_info>: Make explicit.
8239         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8240
8241 2019-01-10  Tom Tromey  <tom@tromey.com>
8242
8243         * objfiles.h (objfile::reset_psymtabs): Update.
8244         * objfiles.c (objfile::objfile): Update.
8245         * psymtab.h (psymtab_storage::obstack): Update.
8246         (psymtab_storage::m_obstack): Use gdb::optional.
8247         (class psymtab_storage): Update comment.  Remove objfile
8248         parameter.
8249         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8250
8251 2019-01-10  Tom Tromey  <tom@tromey.com>
8252
8253         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8254         <free_psymtabs>: Now private.
8255         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8256         (allocate_psymtab): Use new method.
8257
8258 2019-01-10  Tom Tromey  <tom@tromey.com>
8259
8260         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8261         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8262         * mdebugread.c (parse_partial_symbols): Use
8263         allocate_dependencies.
8264         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8265         allocate_dependencies.
8266         (process_psymtab_comp_unit_reader)
8267         (build_type_psymtab_dependencies): Likewise.
8268         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8269
8270 2019-01-10  Tom Tromey  <tom@tromey.com>
8271
8272         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8273         PSYMBOL_SET_LANGUAGE.
8274         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8275
8276 2019-01-10  Tom Tromey  <tom@tromey.com>
8277
8278         * psymtab.h (psymtab_storage::obstack): New method.
8279         <m_obstack>: Rename from obstack; now private.
8280         * psymtab.c (psymtab_storage): Update.
8281         * dwarf2read.c (create_addrmap_from_index)
8282         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8283         Update.
8284
8285 2019-01-10  Tom Tromey  <tom@tromey.com>
8286
8287         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8288         * objfiles.h (objfile::reset_psymtabs): New method.
8289
8290 2019-01-10  Tom Tromey  <tom@tromey.com>
8291
8292         * symmisc.c (print_symbol_bcache_statistics): Update.
8293         (print_objfile_statistics): Update.
8294         * symfile.c (reread_symbols): Update.
8295         * psymtab.h (class psymtab_storage): New.
8296         * psymtab.c (psymtab_storage): New constructor.
8297         (~psymtab_storage): New destructor.
8298         (require_partial_symbols): Update.
8299         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8300         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8301         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8302         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8303         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8304         (start_psymtab_common, end_psymtab_common)
8305         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8306         (allocate_psymtab): Update.
8307         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8308         Update.
8309         (dump_psymtab_addrmap, maintenance_print_psymbols)
8310         (maintenance_check_psymtabs): Update.
8311         (class objfile_psymtabs): Move to objfiles.h.
8312         * psympriv.h (discard_psymtab): Now inline.
8313         (psymtab_discarder::psymtab_discarder): Update.
8314         (psymtab_discarder::~psymtab_discarder): Update.
8315         (ALL_OBJFILE_PSYMTABS): Rewrite.
8316         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8317         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8318         Remove fields.
8319         <partial_symtabs>: New field.
8320         (class objfile_psymtabs): Move from psymtab.h.  Update.
8321         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8322         psymbol_cache.
8323         (objfile::~objfile): Don't destroy psymbol_cache.
8324         * mdebugread.c (parse_partial_symbols): Update.
8325         * dwarf2read.c (create_addrmap_from_index)
8326         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8327         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8328         (add_partial_subprogram, dwarf2_ranges_read): Update.
8329         * dwarf-index-write.c (write_address_map)
8330         (write_one_signatured_type, recursively_write_psymbols)
8331         (class debug_names, class debug_names, write_psymtabs_to_index):
8332         Update.
8333
8334 2019-01-10  Tom Tromey  <tom@tromey.com>
8335
8336         * symtab.h (SYMBOL_SET_NAMES): Update.
8337         (symbol_set_names): Update.
8338         (MSYMBOL_SET_NAMES): Update.
8339         * symtab.c (symbol_set_names): Change argument to be an
8340         objfile_per_bfd_storage.
8341         * psymtab.c (add_psymbol_to_bcache): Update.
8342         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8343
8344 2019-01-10  Tom Tromey  <tom@tromey.com>
8345
8346         * symtab.c (create_demangled_names_hash): Change argument to be an
8347         objfile_per_bfd_storage.
8348         (symbol_set_names): Update.
8349
8350 2019-01-10  Tom Tromey  <tom@tromey.com>
8351
8352         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8353         init_psymbol_list.
8354         * psymtab.c (init_psymbol_list): Do nothing if already called.
8355         * psympriv.h (init_psymbol_list): Add comment.
8356         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8357         init_psymbol_list.
8358         * dbxread.c (dbx_symfile_read): Unconditionally call
8359         init_psymbol_list.
8360
8361 2019-01-10  Tom Tromey  <tom@tromey.com>
8362
8363         * xcoffread.c (scan_xcoff_symtab): Update.
8364         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8365         "where".
8366         * mdebugread.c (parse_partial_symbols)
8367         (handle_psymbol_enumerators): Update.
8368         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8369         * dbxread.c (read_dbx_symtab): Update.
8370         * psympriv.h (psymbol_placement): New enum.
8371         (add_psymbol_to_list): Update.
8372
8373 2019-01-10  Tom Tromey  <tom@tromey.com>
8374
8375         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8376         static_psymbols parameters.
8377         (scan_xcoff_symtab): Update.
8378         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8379         static_psymbols parameters.
8380         * psympriv.h (start_psymtab_common): Update.
8381         * mdebugread.c (parse_partial_symbols): Update.
8382         * dwarf2read.c (create_partial_symtab): Update.
8383         * dbxread.c (read_dbx_symtab): Update.
8384         (start_psymtab): Remove global_psymbols and static_psymbols
8385         parameters.
8386
8387 2019-01-10  Tom Tromey  <tom@tromey.com>
8388
8389         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8390         * psymtab.c (allocate_psymtab): Add comment.
8391         * psympriv.h (allocate_psymtab): Add comment.
8392         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8393         initializations.
8394         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8395
8396 2019-01-10  Tom Tromey  <tom@tromey.com>
8397
8398         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8399         Don't declare.
8400         * mipsread.c: Include mdebugread.h.
8401         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8402         Declare.
8403         * elfread.c: Include mdebugread.h.
8404
8405 2019-01-09  Tom Tromey  <tom@tromey.com>
8406
8407         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8408         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8409         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8410         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8411         (psym_lookup_symbol, psym_find_last_source_symtab)
8412         (psym_forget_cached_source_info, psym_print_stats)
8413         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8414         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8415         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8416         (psym_find_compunit_symtab_by_address)
8417         (maintenance_print_psymbols, maintenance_info_psymtabs)
8418         (maintenance_check_psymtabs): Use ranged for.
8419         * psymtab.h (class objfile_psymtabs): New.
8420         (require_partial_symbols): Return objfile_psymtabs.
8421         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8422
8423 2019-01-09  Tom Tromey  <tom@tromey.com>
8424
8425         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8426         (find_pc_mapped_section, list_overlays_command)
8427         (map_overlay_command, unmap_overlay_command)
8428         (simple_overlay_update): Use all_objfiles.
8429         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8430         * printcmd.c (info_symbol_command): Use all_objfiles.
8431         * objfiles.h (ALL_OBJSECTIONS): Remove.
8432         * maint.c (maintenance_translate_address): Use all_objfiles.
8433         * gcore.c (gcore_create_callback): Use all_objfiles.
8434         (objfile_find_memory_regions): Likewise.
8435
8436 2019-01-09  Tom Tromey  <tom@tromey.com>
8437
8438         * symtab.c (find_line_symtab, info_sources_command)
8439         (make_source_files_completion_list): Use objfile_compunits.
8440         * source.c (select_source_symtab): Use objfile_compunits.
8441         * objfiles.h (struct objfile): Update comment.
8442         (ALL_OBJFILES): Remove.
8443         (ALL_FILETABS): Remove.
8444         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8445         objfile_compunits.
8446
8447 2019-01-09  Tom Tromey  <tom@tromey.com>
8448
8449         * symmisc.c (print_objfile_statistics, dump_objfile)
8450         (maintenance_print_symbols): Use compunit_filetabs.
8451         * source.c (forget_cached_source_info_for_objfile): Use
8452         compunit_filetabs.
8453         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8454         (ALL_FILETABS): Use compunit_filetabs.
8455         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8456         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8457
8458 2019-01-09  Tom Tromey  <tom@tromey.com>
8459
8460         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8461         (compunit_filetabs): New.
8462         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8463         compunit_filetabs.
8464         (info_sources_command, make_source_files_completion_list): Remove
8465         declaration.
8466         * symmisc.c (print_objfile_statistics, dump_objfile)
8467         (maintenance_print_symbols): Remove declaration.
8468         (maintenance_info_symtabs): Use compunit_filetabs.
8469         (maintenance_info_line_tables): Likewise.
8470         * source.c (select_source_symtab): Change local variable name.
8471         (forget_cached_source_info_for_objfile): Remove declaration.
8472         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8473         * objfiles.c (objfile_relocate1): Remove declaration.
8474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8475         declaration.
8476         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8477         * coffread.c (coff_symtab_read): Remove declaration.
8478         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8479         compunit_filetabs.
8480
8481 2019-01-09  Tom Tromey  <tom@tromey.com>
8482
8483         * symtab.c (lookup_objfile_from_block)
8484         (find_pc_sect_compunit_symtab, search_symbols)
8485         (default_collect_symbol_completion_matches_break_on): Use
8486         objfile_compunits.
8487         * objfiles.h (ALL_COMPUNITS): Remove.
8488         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8489         * cp-support.c (add_symbol_overload_list_qualified): Use
8490         objfile_compunits.
8491         * ada-lang.c (ada_collect_symbol_completion_matches)
8492         (ada_add_global_exceptions): Use objfile_compunits.
8493
8494 2019-01-09  Tom Tromey  <tom@tromey.com>
8495
8496         * source.c (select_source_symtab)
8497         (forget_cached_source_info_for_objfile): Remove declaration.
8498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8499         declaration.
8500         * maint.c (count_symtabs_and_blocks): Remove declaration.
8501         * cp-support.c (add_symbol_overload_list_qualified): Remove
8502         declaration.
8503         * coffread.c (coff_symtab_read): Remove declaration.
8504         * symtab.c (lookup_symbol_in_objfile_symtabs)
8505         (basic_lookup_transparent_type_1): Use objfile_compunits.
8506         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8507         (info_sources_command, search_symbols)
8508         (default_collect_symbol_completion_matches_break_on)
8509         (make_source_files_completion_list): Remove declaration.
8510         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8511         (ada_collect_symbol_completion_matches)
8512         (ada_add_global_exceptions): Remove declaration.
8513         * linespec.c (iterate_over_all_matching_symtabs): Use
8514         objfile_compunits.
8515         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8516         (class objfile_compunits): New.
8517         (ALL_COMPUNITS): Use objfile_compunits.
8518         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8519         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8520         objfile_compunits.
8521         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8522
8523 2019-01-09  Tom Tromey  <tom@tromey.com>
8524
8525         * symtab.c (search_symbols)
8526         (default_collect_symbol_completion_matches_break_on): Use
8527         objfile_msymbols.
8528         * ada-lang.c (ada_lookup_simple_minsym)
8529         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8530         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8531         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8532         objfile_msymbols.
8533         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8534         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8535         * objc-lang.c (find_methods): Use objfile_msymbols.
8536         (info_selectors_command, info_classes_command): Likewise.
8537         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8538         * objfiles.h (class objfile_msymbols): New.
8539         (ALL_OBJFILE_MSYMBOLS): Remove.
8540         (ALL_MSYMBOLS): Remove.
8541
8542 2019-01-09  Tom Tromey  <tom@tromey.com>
8543
8544         * common/next-iterator.h (next_adapter): Add Iterator template
8545         parameter.
8546         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8547         (class all_objfiles_safe): New.
8548         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8549         * objfiles.c (put_objfile_before): Update comment.
8550         (add_separate_debug_objfile): Likewise.
8551         (free_all_objfiles): Use all_objfiles_safe.
8552         (objfile_purge_solibs): Likewise.
8553
8554 2019-01-09  Tom Tromey  <tom@tromey.com>
8555
8556         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8557         (expand_symtab_containing_pc, lookup_static_symbol)
8558         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8559         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8560         all_objfiles.
8561         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8562         * breakpoint.c (create_overlay_event_breakpoint)
8563         (create_longjmp_master_breakpoint)
8564         (create_std_terminate_master_breakpoint)
8565         (create_exception_master_breakpoint): Use all_objfiles.
8566         * linux-thread-db.c (try_thread_db_load_from_pdir)
8567         (has_libpthread): Use all_objfiles.
8568         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8569         * linespec.c (iterate_over_all_matching_symtabs)
8570         (search_minsyms_for_name): Use all_objfiles.
8571         * maint.c (maintenance_info_sections): Use all_objfiles.
8572         * main.c (captured_main_1): Use all_objfiles.
8573         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8574         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8575         * guile/scm-pretty-print.c
8576         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8577         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8578         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8579         (maintenance_print_msymbols): Use all_objfiles.
8580         * source.c (select_source_symtab): Use all_objfiles.
8581         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8582         * symfile.c (remove_symbol_file_command)
8583         (expand_symtabs_matching, map_symbol_filenames): Use
8584         all_objfiles.
8585         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8586         all_objfiles.
8587         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8588         * objc-lang.c (find_methods): Use all_objfiles.
8589         * objfiles.c (have_partial_symbols, have_full_symbols)
8590         (have_minimal_symbols, qsort_cmp)
8591         (default_iterate_over_objfiles_in_search_order): Use
8592         all_objfiles.
8593         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8594         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8595         (maintenance_check_psymtabs): Use all_objfiles.
8596         (ALL_PSYMTABS): Remove.
8597         * compile/compile-object-run.c (do_module_cleanup): Use
8598         all_objfiles.
8599         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8600         * cp-support.c (add_symbol_overload_list_qualified): Use
8601         all_objfiles.
8602         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8603         Use all_objfiles.
8604         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8605         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8606         all_objfiles.
8607         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8608         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8609         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8610         Uses all_objfiles.
8611         * solib.c (solib_read_symbols): Use all_objfiles
8612
8613 2019-01-09  Tom Tromey  <tom@tromey.com>
8614
8615         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8616         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8617         all_objfiles.
8618         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8619         * symmisc.c (print_symbol_bcache_statistics)
8620         (print_objfile_statistics, maintenance_print_objfiles)
8621         (maintenance_info_symtabs, maintenance_check_symtabs)
8622         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8623         all_objfiles.
8624         * source.c (forget_cached_source_info): Use all_objfiles.
8625         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8626         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8627         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8628         * objfiles.c (update_section_map): Use all_objfiles.
8629         (shared_objfile_contains_address_p): Likewise.
8630         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8631         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8632
8633 2019-01-09  Tom Tromey  <tom@tromey.com>
8634
8635         * common/next-iterator.h: New file.
8636         * objfiles.h (class all_objfiles): New.
8637         (struct objfile_iterator): New.
8638
8639 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8640
8641         * NEWS: Move the description of the changed "frame", "select-frame",
8642          and "info frame" commands to the Changed commands section.
8643
8644 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8645
8646         * gdbtypes.c (check_stub_method_group): Remove handling of old
8647         mangling schemes.
8648         * linespec.c (find_methods): Likewise.
8649         * stabsread.c (read_member_functions): Likewise.
8650         * valops.c (search_struct_method): Likewise.
8651         (value_struct_elt_for_reference): Likewise.
8652         * NEWS: Mention this change.
8653
8654 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8655
8656         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8657         print_source_lines.
8658         * source.c (print_source_lines_base): Update line number check.
8659         (print_source_lines): New function.
8660         (source_lines_range::source_lines_range): New function.
8661         * source.h (class source_lines_range): New class.
8662         (print_source_lines): New declaration.
8663
8664 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8665
8666         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8667
8668 2019-01-08  Tom Tromey  <tom@tromey.com>
8669             Simon Marchi  <simon.marchi@ericsson.com>
8670
8671         PR gdb/24060
8672         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8673         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8674         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8675         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8676         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8677         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8678
8679 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8680
8681         * source.c (select_source_symtab): Move header comment to
8682         declaration in source.h.
8683         (forget_cached_source_info_for_objfile): Likewise.
8684         (forget_cached_source_info): Likewise.
8685         (identify_source_line): Likewise.
8686         * source.h (identify_source_line): Move declaration from symtab.h
8687         and add comment from source.c
8688         (print_source_lines): Likewise.
8689         (forget_cached_source_info_for_objfile): Likewise.
8690         (forget_cached_source_info): Likewise.
8691         (select_source_symtab): Likewise.
8692         (enum print_source_lines_flag): Move definition from symtab.h.
8693         * symtab.h (identify_source_line): Move declaration to source.h.
8694         (print_source_lines): Likewise.
8695         (forget_cached_source_info_for_objfile): Likewise.
8696         (forget_cached_source_info): Likewise.
8697         (select_source_symtab): Likewise.
8698         (enum print_source_lines_flag): Move definition to source.h.
8699         * tui/tui-hooks.c: Add 'source.h' include.
8700
8701 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8702
8703         * source.c (print_source_lines_base): Handle requests to print
8704         reverse line number sequences, and guard against empty lines
8705         string.
8706
8707 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8708
8709         * source.c (print_source_lines_base): Fix skip of '\r' if next
8710         character is '\n'.
8711
8712 2019-01-06  Tom Tromey  <tom@tromey.com>
8713
8714         * c-exp.y (struct c_parse_state) <macro_original_text,
8715         expansion_obstack>: New member.
8716         (macro_original_text, expansion_obstack): Remove globals.
8717         (scan_macro_expansion, scanning_macro_expansion)
8718         (finished_macro_expansion): Update.
8719         (scan_macro_cleanup): Remove.
8720         (yylex, c_parse): Update.
8721
8722 2019-01-06  Tom Tromey  <tom@tromey.com>
8723
8724         * c-exp.y (struct c_parse_state) <strings>: New member.
8725         (operator_stoken): Update.
8726
8727 2019-01-06  Tom Tromey  <tom@tromey.com>
8728
8729         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8730         (union type_stack_elt) <typelist_val>: Now a pointer to
8731         std::vector.
8732         (type_stack_cleanup): Don't declare.
8733         (push_typelist): Update.
8734         * parse.c (pop_typelist): Return a std::vector.
8735         (push_typelist): Take a std::vector.
8736         (follow_types): Update.  Do not free args.
8737         (type_stack_cleanup): Remove.
8738         * c-exp.y (struct c_parse_state): New.
8739         (cpstate): New global.
8740         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8741         (nonempty_typelist): Update.
8742         (func_mod): Create a new vector.
8743         (c_parse): Create a c_parse_state.
8744         (check_parameter_typelist): Do not delete params.
8745         (function_method): Update.  Do not delete type_list.
8746
8747 2019-01-06  Tom Tromey  <tom@tromey.com>
8748
8749         PR gdb/28155:
8750         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8751         check_typedef.
8752         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8753         (print_return_value): Likewise.
8754
8755 2019-01-05  Tom Tromey  <tom@tromey.com>
8756
8757         * contrib/cleanup_check.py: Remove.
8758         * contrib/gcc-with-excheck: Remove.
8759         * contrib/exsummary.py: Remove.
8760         * contrib/excheck.py: Remove.
8761
8762 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8763
8764         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8765         NULL. Initialize tpprev to NULL instead of assigning it
8766         to NULL on the next statement.
8767         * windows-nat.c (windows_delete_thread): Remove check for
8768         main_thread_id before printing thread exit notifications.
8769         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8770         Remove thread ID check against main_thread_id.
8771         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8772         windows_delete_thread.
8773         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8774
8775 2019-01-04  Tom Tromey  <tom@tromey.com>
8776
8777         * compile/compile.c (_initialize_compile): Use upper case for
8778         metasyntactic variables.
8779         * symmisc.c (_initialize_symmisc): Use upper case for
8780         metasyntactic variables.
8781         * psymtab.c (_initialize_psymtab): Use upper case for
8782         metasyntactic variables.
8783         * demangle.c (demangle_command): Use upper case for metasyntactic
8784         variables.
8785         (_initialize_demangler): Likewise.
8786         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8787         variables.
8788
8789 2019-01-03  Tom Tromey  <tom@tromey.com>
8790
8791         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8792
8793 2019-01-03  Tom Tromey  <tom@tromey.com>
8794
8795         * python/py-symtab.c (salpy_str): Update.
8796         (struct salpy_sal_object) <symtab>: Now a PyObject.
8797         (salpy_dealloc): Update.
8798         (del_objfile_sal): Use gdbpy_ref.
8799
8800 2019-01-03  Tom Tromey  <tom@tromey.com>
8801
8802         * python/py-type.c (convert_field): Use new_reference.  Return
8803         gdbpy_ref.
8804         (make_fielditem): Return gdbpy_ref.
8805         (typy_fields): Update.
8806         (typy_getitem): Update.
8807         (field_name): Return gdbpy_ref.  Use new_reference.
8808         (typy_iterator_iternext): Update.
8809
8810 2019-01-03  Tom Tromey  <tom@tromey.com>
8811
8812         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8813
8814 2019-01-03  Tom Tromey  <tom@tromey.com>
8815
8816         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8817         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8818         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8819         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8820         (pspy_set_type_printers): Likewise.
8821         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8822         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8823         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8824         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8825         (objfpy_set_type_printers): Likewise.
8826
8827 2019-01-03  Tom Tromey  <tom@tromey.com>
8828
8829         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8830         (gdbpy_print_stack): Use gdbpy_err_fetch.
8831         * python/python-internal.h (class gdbpy_err_fetch): New class.
8832         (class gdbpy_enter) <m_error_type, m_error_value,
8833         m_error_traceback>: Remove.
8834         <m_error>: New member.
8835         (gdbpy_exception_to_string): Don't declare.
8836         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8837         * python/py-value.c (convert_value_from_python): Use
8838         gdbpy_err_fetch.
8839         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8840         gdbpy_exception_to_string.
8841         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8842         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8843         gdbpy_err_fetch.
8844
8845 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8846
8847         * linux-nat.c (delete_lwp_cleanup): Delete.
8848         (struct lwp_deleter): New struct.
8849         (lwp_info_up): New typedef.
8850         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8851         lwp_info_up.
8852
8853 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8854
8855         * linux-fork.c (class scoped_switch_fork_info): New class.
8856         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8857
8858 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * valops.c (find_overload_match): Remove use of null_cleanup, and
8861         calls to do_cleanups.
8862
8863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8864
8865         * compile/compile-cplus-types.c
8866         (compile_cplus_instance::decl_name): Handle changes to
8867         cp_func_name.
8868         * cp-support.c (cp_func_name): Update header comment, update
8869         return type.
8870         * cp-support.h (cp_func_name): Update return type in declaration.
8871         * valops.c (find_overload_match): Move temp_func local to top
8872         level of function and change its type.  Use temp_func to hold and
8873         delete temporary string obtained from cp_func_name.
8874
8875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8878         gdb::char_vector, remove cleanup, and update uses of `msg`.
8879
8880 2019-01-03  Jim Wilson  <jimw@sifive.com>
8881
8882         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8883
8884 2019-01-02  Tom Tromey  <tom@tromey.com>
8885
8886         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8887         (tdesc_parse_xml): Remove cleanups.
8888         * target-descriptions.h (make_cleanup_free_target_description):
8889         Don't declare.
8890         (target_desc_deleter): New struct.
8891         (target_desc_up): New typedef.
8892         * target-descriptions.c (target_desc_deleter::operator()): Rename
8893         from free_target_description.
8894         (make_cleanup_free_target_description): Remove.
8895
8896 2019-01-02  Tom Tromey  <tom@tromey.com>
8897
8898         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8899         constructor, destructor.
8900         (linespec_parser): Remove typedef.
8901         (~linespec_parser): Rename from linespec_parser_delete.
8902         (linespec_lex_to_end, linespec_complete_label)
8903         (linespec_complete): Update.
8904         (decode_line_full): Remove cleanups.
8905         (decode_line_1): Update.
8906
8907 2019-01-02  Tom Tromey  <tom@tromey.com>
8908
8909         * python/python-internal.h (inferior_to_inferior_object): Change
8910         return type.
8911         * python/py-exitedevent.c (create_exited_event_object): Update.
8912         * python/py-inferior.c (inferior_to_inferior_object): Return
8913         gdbpy_ref.
8914         (python_new_inferior, python_inferior_deleted)
8915         (thread_to_thread_object, delete_thread_object)
8916         (build_inferior_list, gdbpy_selected_inferior): Update.
8917         * python/py-infthread.c (create_thread_object): Update.  Also fail
8918         if inferior_to_inferior_object fails.
8919
8920 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8921
8922         * inferior.h (class inferior) <displaced_step_state>: New field.
8923         * infrun.h (struct displaced_step_state): Move here from
8924         infrun.c.  Initialize fields, add constructor.
8925         <inf>: Remove field.
8926         <reset>: New method.
8927         * infrun.c (struct displaced_step_inferior_state): Move to
8928         infrun.h.
8929         (displaced_step_inferior_states): Remove.
8930         (get_displaced_stepping_state): Adust.
8931         (displaced_step_in_progress_any_inferior): Adjust.
8932         (displaced_step_in_progress_thread): Adjust.
8933         (displaced_step_in_progress): Adjust.
8934         (add_displaced_stepping_state): Remove.
8935         (get_displaced_step_closure_by_addr): Adjust.
8936         (remove_displaced_stepping_state): Remove.
8937         (infrun_inferior_exit): Call displaced_step_state.reset.
8938         (use_displaced_stepping): Don't check for NULL.
8939         (displaced_step_prepare_throw): Call
8940         get_displaced_stepping_state.
8941         (displaced_step_fixup): Don't check for NULL.
8942         (prepare_for_detach): Don't check for NULL.
8943
8944 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8945
8946         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8947          in case of call that did not complete.
8948
8949 2019-01-02  Andrey Utkin  <autkin@undo.io>
8950
8951         * symfile.c (find_separate_debug_file): Fix search of debug files for
8952         remote debuggee.
8953
8954 2019-01-02  Tom Tromey  <tom@tromey.com>
8955
8956         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8957         indentation.
8958         * python/py-frame.c (frapy_older): Remove cast.
8959         (frapy_newer): Likewise.
8960         * python/py-breakpoint.c (local_setattro): Remove cast.
8961         * python/py-arch.c (archpy_name): Remove local variable.
8962         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8963
8964 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8965
8966         * unittests/basic_string_view/element_access/char/empty.cc:
8967         Fix year range in copyright header.
8968
8969 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8970
8971         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8972         Delete.
8973         <operator==>: Update with for removed field.
8974         <hash>: Likewise.
8975         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8976         <isa_features>: ...this.
8977         <abi_features>: New field.
8978         (riscv_isa_flen): Update comment.
8979         (riscv_abi_xlen): New declaration.
8980         (riscv_abi_flen): New declaration.
8981         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8982         isa_features.
8983         (riscv_abi_xlen): New function.
8984         (riscv_isa_flen): Update to get answer from isa_features.
8985         (riscv_abi_flen): New function.
8986         (riscv_has_fp_abi): Update to get answer from abi_features.
8987         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8988         xlen and flen.
8989         (riscv_call_info) <xlen, flen>: Update comment.
8990         (riscv_call_arg_struct): Remove invalid assertions
8991         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8992         is removed.
8993         (riscv_gdbarch_init): Gather isa features and abi features
8994         separately, ensure both match on the gdbarch when reusing an old
8995         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8996         a target with 64-bit float hardware.
8997
8998 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8999
9000         * source.c (search_command_helper): Stop reverse search
9001         when line 1 has been searched.
9002
9003 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9004
9005         * record-full.c (record_full_base_target::close): Rewrite
9006         record_full_core_buf_list free logic.
9007
9008 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9009
9010         * break-catch-syscall.c (print_one_catch_syscall): xfree
9011         the last text.
9012
9013 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9014
9015         * top.c (print_gdb_version): Update Copyright year in version
9016         message.
9017
9018 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9019
9020         Update copyright year range in all GDB files.
9021
9022 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9023
9024         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9025
9026 For older changes see ChangeLog-2018.
9027 \f
9028 Local Variables:
9029 mode: change-log
9030 left-margin: 8
9031 fill-column: 74
9032 version-control: never
9033 coding: utf-8
9034 End:
9035