1 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3 * infcall.c (value_arg_coerce): Remove an unused parameter.
4 (call_function_by_hand_dummy): Update the call to
7 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
9 * infcall.c (call_function_by_hand_dummy): Refactor.
11 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
13 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
15 2019-10-23 Tom Tromey <tom@tromey.com>
18 * configure.ac: Don't check for sigprocmask.
19 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
21 2019-10-23 Tom Tromey <tom@tromey.com>
24 * acinclude.m4: Use m4_include, not sinclude.
26 2019-10-23 Tom de Vries <tdevries@suse.de>
29 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
31 2019-10-22 Christian Biesinger <cbiesinger@google.com>
33 * symtab.c (struct demangled_name_entry) <language>: Change from
34 bitfield to regular variable.
36 2019-10-22 Christian Biesinger <cbiesinger@google.com>
38 * symtab.c (struct demangled_name_entry): Add a constructor.
39 (free_demangled_name_entry): New function to call the destructor
40 for demangled_name_entry.
41 (create_demangled_names_hash): Pass free_demangled_name_entry to
43 (symbol_set_names): Call placement new for demangled_name_entry.
44 * utils.c: No longer include xxhash.h here, now that fast_hash
45 is inlined in the header.
46 * utils.h: Instead, include it here.
48 2019-10-22 Christian Biesinger <cbiesinger@google.com>
50 * Makefile.in: Link with libxxhash.
51 * config.in: Regenerate.
52 * configure: Regenerate.
53 * configure.ac: Search for libxxhash.
54 * utils.c (fast_hash): Use xxhash if present.
56 2019-10-22 Christian Biesinger <cbiesinger@google.com>
58 * utils.h (fast_hash): New function.
59 * symtab.c (hash_demangled_name_entry): Call new function
62 2019-10-22 Christian Biesinger <cbiesinger@google.com>
64 * symtab.c (struct demangled_name_entry): Change type of mangled
65 to gdb::string_view. Also adds a constructor that takes the
67 (hash_demangled_name_entry): Update.
68 (eq_demangled_name_entry): Update.
69 (free_demangled_name_entry): New function to call the destructor
70 now that this is not a POD anymore.
71 (create_demangled_names_hash): Pass free_demangled_name_entry to
73 (symbol_set_names): Update.
75 2019-10-21 Ali Tamur <tamu@google.com>
77 * dwarf2read.c (dir_index): Change type.
78 (file_name_index): Likewise.
79 (line_header::include_dir_at): Change comment and implementation on
80 whether it is DWARF 5.
81 (line_header::is_valid_file_index): New function.
82 (line_header::file_name_at): Change comment and implementation on
83 whether it is DWARF 5.
84 (line_header::file_names): Change to private field renamed as
85 m_file_names and introduce a new accessor method.
86 (line_header::file_names_size): New method.
87 (line_header::include_dirs): Change to private field and rename as
89 (dw2_get_file_names_reader): Define local var at a smaller scope and
91 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
92 (process_structure_scope): Likewise.
93 (line_header::add_include_dir): Change message and reflect renaming.
94 (line_header::add_file_name): Likewise.
95 (read_formatted_entries): Handle DW_FORM_data16.
96 (dwarf_decode_line_header): Fix line header length calculation.
97 (psymtab_include_file_name): Change comment and API.
98 (lnp_state_machine::m_file): Update comment and reflect type change.
99 (lnp_state_machine::record_line): Reflect type change.
100 (dwarf_decode_lines): Reflect API change.
101 (file_file_name): Likewise.
102 (file_full_name): Likewise.
104 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
106 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
108 2019-10-21 Tom Tromey <tom@tromey.com>
110 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
112 2019-10-21 Tom Tromey <tom@tromey.com>
114 * configure.ac (nm.h): Conditionally create nm.h link. Subst
115 NM_H. Use AC_CONFIG_LINKS.
116 * configure: Rebuild.
117 * Makefile.in (NM_H): New variable.
118 (generated_files): Add NM_H. Remove gcore.
119 (nm.h, stamp-nmh): New targets.
121 2019-10-20 Tom Tromey <tom@tromey.com>
123 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
124 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
126 (put_objfile_before): Now static.
128 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
130 * gdbsupport/common-utils.h (startswith): Change return type to
133 2019-10-19 Christian Biesinger <cbiesinger@google.com>
135 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
136 * breakpoint.c (bp_locations_compare): Rename to...
137 (bp_location_is_less_than): ...this, and change to std::sort semantics.
138 (update_global_location_list): Use std::sort instead of qsort.
139 * buildsym.c (compare_line_numbers): Rename to...
140 (lte_is_less_than): ...this, and change to std::sort semantics.
141 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
143 * disasm.c (compare_lines): Rename to...
144 (line_is_less_than): ...this, and change to std::sort semantics.
145 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
147 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
148 (fde_is_less_than): ...this, and change to std::sort semantics.
149 (dwarf2_build_frame_info): Call std::sort instead of qsort.
150 * mdebugread.c (compare_blocks):
151 (block_is_less_than): ...this, and change to std::sort semantics.
152 (sort_blocks): Call std::sort instead of qsort.
153 * objfiles.c (qsort_cmp): Rename to...
154 (sort_cmp): ...this, and change to std::sort semantics.
155 (update_section_map): Call std::sort instead of qsort.
156 * remote.c (compare_pnums): Remove.
157 (map_regcache_remote_table): Call std::sort instead of qsort.
158 * utils.c (compare_positive_ints): Remove.
159 * utils.h (compare_positive_ints): Remove.
160 * xcoffread.c (compare_lte): Remove.
161 (arrange_linetable): Call std::sort instead of qsort.
163 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
165 * symfile.c (init_entry_point_info): Fix typo.
166 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
168 2019-10-18 Tom de Vries <tdevries@suse.de>
170 * aarch64-tdep.c: Fix typos in comments.
173 * alpha-tdep.c: Same.
174 * alpha-tdep.h: Same.
176 * amd64-windows-tdep.c: Same.
179 * arch-utils.c: Same.
180 * arm-nbsd-tdep.c: Same.
183 * blockframe.c: Same.
186 * coff-pe-read.c: Same.
189 * darwin-nat.c: Same.
193 * dtrace-probe.c: Same.
194 * dwarf-index-write.c: Same.
195 * dwarf2-frame-tailcall.c: Same.
196 * dwarf2-frame.c: Same.
197 * dwarf2read.c: Same.
199 * exceptions.c: Same.
204 * gnu-v3-abi.c: Same.
206 * h8300-tdep.c: Same.
208 * i386-linux-tdep.c: Same.
210 * ia64-libunwind-tdep.c: Same.
216 * linux-thread-db.c: Same.
218 * mdebugread.c: Same.
220 * mn10300-tdep.c: Same.
223 * opencl-lang.c: Same.
226 * ppc-linux-nat.c: Same.
227 * ppc-linux-tdep.c: Same.
228 * ppc-sysv-tdep.c: Same.
231 * record-btrace.c: Same.
232 * record-full.c: Same.
233 * remote-fileio.c: Same.
235 * rs6000-tdep.c: Same.
237 * score-tdep.c: Same.
241 * sol-thread.c: Same.
242 * solib-svr4.c: Same.
246 * sparc-sol2-tdep.c: Same.
247 * sparc-tdep.c: Same.
248 * sparc64-tdep.c: Same.
253 * target-descriptions.c: Same.
254 * target-float.c: Same.
261 * windows-nat.c: Same.
263 * xstormy16-tdep.c: Same.
264 * xtensa-tdep.c: Same.
266 2019-10-17 Tom Tromey <tromey@adacore.com>
268 * configure: Rebuild.
269 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
270 in AC_CONFIG_FILES invocation.
271 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
272 new-style config.status invocation.
274 2019-10-17 Tom de Vries <tdevries@suse.de>
276 * arm-nbsd-nat.c: Fix typos in comments.
278 * darwin-nat-info.c: Same.
279 * dwarf2read.c: Same.
288 * mdebugread.c: Same.
289 * moxie-tdep.c: Same.
290 * nto-procfs.c: Same.
292 * ppc-linux-tdep.c: Same.
294 * riscv-tdep.c: Same.
297 * sparc-linux-tdep.c: Same.
300 * target-descriptions.c: Same.
304 2019-10-16 Tom Tromey <tom@tromey.com>
306 * objfiles.h (struct objfile) <original_name>: Now const.
308 2019-10-16 Christian Biesinger <cbiesinger@google.com>
310 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
311 pass on to sigsetjmp's second argument.
312 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
314 2019-10-16 Keith Seitz <keiths@redhat.com>
317 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
318 sections whose size is greater than the file size.
320 2019-10-16 Jim Wilson <jimw@sifive.com>
322 * riscv-tdep.c (riscv_gcc_target_options): New.
323 (riscv_gnu_triplet_regexp): New.
324 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
325 set_gdbarch_gnu_triplet_regexp.
327 2019-10-16 Christian Biesinger <cbiesinger@google.com>
329 * Makefile.in: Add xml-builtin.h.
330 * features/feature_to_c.sh: Add an include for xml-builtin.h
331 to ensure that the compiler checks that the types match.
332 * xml-builtin.h: New file.
333 * xml-support.c (fetch_xml_builtin): Add missing const.
334 * xml-support.h: Remove declaration of xml_builtins.
336 2019-10-16 Tom de Vries <tdevries@suse.de>
339 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
340 (amd64_classify_aggregate): ... here.
341 (amd64_classify_aggregate_field): Handled fiels of nested structs
344 2019-10-16 Tom de Vries <tdevries@suse.de>
347 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
348 that handles 'theclass'.
350 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
352 * linespec.c (decode_digits_ordinary): Update comment.
353 * make-target-delegates: No longer need to handle VEC case.
354 * memrange.c (normalize_mem_ranges): Update comment.
355 * namespace.c (add_using_directive): Update comment.
356 * objc-lang.c (uniquify_strings): Update comment.
357 * ppc-linux-nat.c (struct thread_points): Update comment.
358 * probe.h (find_probes_in_objfile): Update comment.
359 * target.h (enum flash_preserve_mode): Update comment.
360 * varobj.c (varobj_restrict_range): Update comment.
361 * varobj.h (varobj_list_children): Update comment.
363 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
365 * Makefile.in: Remove references to vec.h and vec.c.
366 * aarch64-tdep.c: No longer include vec.h.
367 * ada-lang.c: Likewise.
368 * ada-lang.h: Likewise.
369 * arm-tdep.c: Likewise.
371 * breakpoint.h: Likewise.
372 * charset.c: Likewise.
373 * cp-support.h: Likewise.
374 * dtrace-probe.c: Likewise.
375 * dwarf2read.c: Likewise.
376 * extension.h: Likewise.
377 * gdb_bfd.c: Likewise.
378 * gdbsupport/gdb_vecs.h: Likewise.
379 * gdbsupport/vec.c: Remove.
380 * gdbsupport/vec.h: Remove.
381 * gdbthread.h: Likewise.
382 * guile/scm-type.c: Likewise.
383 * inline-frame.c: Likewise.
384 * machoread.c: Likewise.
385 * memattr.c: Likewise.
386 * memrange.h: Likewise.
387 * namespace.h: Likewise.
388 * nat/linux-btrace.h: Likewise.
389 * osdata.c: Likewise.
390 * parser-defs.h: Likewise.
391 * progspace.h: Likewise.
392 * python/py-type.c: Likewise.
393 * record-btrace.c: Likewise.
394 * rust-exp.y: Likewise.
395 * solib-target.c: Likewise.
396 * stap-probe.c: Likewise.
397 * target-descriptions.c: Likewise.
398 * target-memory.c: Likewise.
399 * target.h: Likewise.
400 * varobj.c: Likewise.
401 * varobj.h: Likewise.
402 * xml-support.h: Likewise.
404 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
406 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
407 Update for new std::vector based implementation.
408 (process_psymtab_comp_unit_reader): Likewise.
409 (scan_partial_symbols): Likewise.
410 (recursively_compute_inclusions): Likewise.
411 (compute_compunit_symtab_includes): Likewise.
412 (process_imported_unit_die): Likewise.
413 (queue_and_load_dwo_tu): Likewise.
414 (follow_die_sig_1): Likewise.
415 * gdb/dwarf2read.h: Remove DEF_VEC_P.
416 (typedef dwarf2_per_cu_ptr): Remove.
417 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
419 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
420 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
421 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
422 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
425 2019-10-15 Tom Tromey <tromey@adacore.com>
427 * windows-nat.c (windows_nat_target::resume): Use %x when logging
430 2019-10-15 Tom Tromey <tromey@adacore.com>
432 * windows-nat.c (windows_nat_target::fetch_registers)
433 (windows_nat_target::store_registers): Rename "pid" to "tid".
435 2019-10-15 Tom Tromey <tromey@adacore.com>
437 * gdbarch.h, gdbarch.c: Rebuild.
438 * gdbarch.sh (gcc_target_options): Change return type to
440 * compile/compile.c (get_args): Update.
441 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
442 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
444 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
446 * arch-utils.c (default_gcc_target_options): Return std::string.
447 * arch-utils.h (default_gcc_target_options): Return std::string.
448 * s390-tdep.c (s390_gcc_target_options): Return std::string.
450 2019-10-15 Christian Biesinger <cbiesinger@google.com>
452 * breakpoint.c (breakpoint_chain): Make static.
453 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
454 of accessing breakpoint_chain.
456 2019-10-15 Christian Biesinger <cbiesinger@google.com>
458 * breakpoint.c (iterate_over_breakpoints): Change function pointer
459 to a gdb::function_view and return value to bool.
460 * breakpoint.h (iterate_over_breakpoints): Likewise.
461 * dummy-frame.c (pop_dummy_frame_bpt): Update.
462 (pop_dummy_frame): Update.
463 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
464 (gdbscm_breakpoints): Update.
465 * python/py-breakpoint.c (build_bp_list): Update.
466 (gdbpy_breakpoints): Update.
467 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
469 (bpfinishpy_handle_stop): Update.
470 (bpfinishpy_handle_exit): Update.
471 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
472 (svr4_update_solib_event_breakpoints): Update.
474 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
476 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
477 when unwrapping single-field structs.
479 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
481 * dwarf2read.c: Remove includes.
483 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
485 * ui-out.c (ui_out::call_do_message): Silence
486 -Wformat-nonliteral warning.
488 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
490 * breakpoint.c: Remove some includes: continuations.h, skip.h,
491 mi/mi-main.h, readline/readline.h, readline/history.h. Add
492 include: readline/tilde.h.
494 2019-10-12 Christian Biesinger <cbiesinger@google.com>
496 * remote.c (remote_target::get_trace_status): Remove declaration of
499 2019-10-12 Christian Biesinger <cbiesinger@google.com>
501 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
502 (show_user): Remove declaration of cmdlist.
503 * cli/cli-cmds.h (max_user_call_depth): Declare.
504 * cli/cli-script.c (execute_user_command): Remove declaration
505 of max_user_call_depth.
507 2019-10-11 Jim Wilson <jimw@sifive.com>
509 * gdbsupport/print-utils.h (pulongest): Fix comment.
510 (plongest): Likewise.
511 (phex): Add missing comment, mention leading zeros.
512 (phex_nz): Add mention of no leading zeros to comment.
514 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
515 plongest instead of unsigned long long cast.
517 2019-10-10 Christian Biesinger <cbiesinger@google.com>
519 * main.c (captured_main_1): Include gdbtk.h and remove declarations
520 for external_editor_command and gdbtk_test.
522 2019-10-10 Christian Biesinger <cbiesinger@google.com>
524 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
525 * varobj.c (varobjdebug): Move comment to...
526 * varobj.h (varobjdebug): ...here, and declare.
528 2019-10-09 Tom Tromey <tom@tromey.com>
530 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
533 2019-10-09 Tom Tromey <tom@tromey.com>
535 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
536 * tui/tui-stack.c (tui_locator_window::rerender): Update.
537 * tui/tui-command.c (tui_cmd_window::resize)
538 (tui_refresh_cmd_win): Update.
539 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
540 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
541 * tui/tui-data.c (~tui_gen_win_info): Remove.
542 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
543 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
544 (tui_redisplay_readline, tui_mld_flush)
545 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
546 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
547 (tui_data_window::erase_data_content)
548 (tui_data_item_window::rerender)
549 (tui_data_item_window::refresh_window): Update.
550 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
551 (box_win, tui_gen_win_info::make_window)
552 (tui_gen_win_info::make_visible): Update.
553 (tui_delete_win): Remove.
554 * tui/tui-winsource.c
555 (tui_source_window_base::do_erase_source_content): Update.
556 (tui_show_source_line, tui_source_window_base::update_tab_width)
557 (tui_source_window_base::update_exec_info): Update.
558 * tui/tui-data.h (struct curses_deleter): New.
559 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
560 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
562 2019-10-09 Tom Tromey <tom@tromey.com>
564 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
566 2019-10-09 Tom Tromey <tom@tromey.com>
568 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
569 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
571 2019-10-09 Tom Tromey <tom@tromey.com>
573 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
574 window height directly.
575 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
577 * tui/tui-layout.c (tui_default_win_height): Remove.
578 (tui_default_win_viewport_height): Remove.
580 2019-10-09 Tom Tromey <tom@tromey.com>
582 * tui/tui.h: Remove comments.
584 2019-10-09 Tom de Vries <tdevries@suse.de>
586 * python/lib/gdb/printer/bound_registers.py: Use
587 '^builtin_type_bound128' as regexp argument for
588 add_builtin_pretty_printer.
590 2019-10-09 Christian Biesinger <cbiesinger@google.com>
592 * guile/guile.c (guile_extension_script_ops): Remove forward
593 declaration and mark as static.
594 (guile_script_ops): Likewise.
595 (extension_language_guile): Move further down in the file so
596 it can reference the definitions for guile_{extension_,}script_ops.
598 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
600 * s390-tdep.c (390_process_record): Handle new arch13 instructions
601 except SORTL, DFLTCC, and KDSA.
603 2019-10-08 Tom Tromey <tromey@adacore.com>
605 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
606 (struct safe_symbol_file_add_args): Remove.
608 2019-10-08 Tom Tromey <tromey@adacore.com>
610 * windows-nat.c: Don't include buildsym-legacy.h.
612 2019-10-08 Tom Tromey <tromey@adacore.com>
614 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
616 2019-10-08 Christian Biesinger <cbiesinger@google.com>
618 * gdbtypes.c (overload_debug): Move comment to header.
619 * gdbtypes.h (overload_debug): Declare.
620 * valops.c: Remove declaration of overload_debug, instead
623 2019-10-08 Christian Biesinger <cbiesinger@google.com>
625 * language.c (show_language_command): Pass lang_frame_mismatch_warn
627 (lang_frame_mismatch_warn): Make const, mark with N_(), and
629 * language.h (lang_frame_mismatch_warn): ... here. Also add
631 * top.c (lang_frame_mismatch_warn): Remove declaration.
632 (check_frame_language_change): Pass lang_frame_mismatch_warn
635 2019-10-07 Christian Biesinger <cbiesinger@google.com>
637 * c-lang.h (vtbl_ptr_name): Declare.
638 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
640 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
642 2019-10-07 Christian Biesinger <cbiesinger@google.com>
644 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
647 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
649 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
650 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
651 * ctfread.c: New file.
652 * ctfread.h: New file.
653 * elfread.c: Include ctfread.h.
654 (struct elfinfo text_p): New member ctfsect.
655 (elf_locate_sections): Mark CTF section.
656 (elf_symfile_read): Call elfctf_build_psymtabs.
657 * Makefile.in (LIBCTF): Add.
660 (DIST): Add ctfread.c.
662 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
664 * ctfread.c (struct nextfield): Renamed to ...
665 (struct ctf_nextfield): ... this.
666 (struct field_info): Renamed to ...
667 (strut ctf_field_info): ... this.
668 (attach_fields_to_type): Update for renamed structures.
669 (ctf_add_member_cb): Likewise.
670 (ctf_add_enum_member_cb): Likewise.
671 (process_struct_members): Likewise.
672 (process_enum_type): Likewise.
674 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
676 * tracectf.h: Rename, was ctf.h.
677 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
678 * tracefile.c: Likewise.
679 * tracepoint.c: Remove unused include ctf.h.
680 * mi/mi-main.c: Likewise.
681 * Makefile.in Replace ctf.c with tracectf.c.
683 2019-10-06 Joel Brobecker <brobecker@adacore.com>
685 * version.in: Change version number to "9.0.50.DATE-git".
687 2019-10-03 Tom Tromey <tom@tromey.com>
690 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
692 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
694 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
696 * NEWS: Add entry about nested function support.
698 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
699 Andrew Burgess <andrew.burgess@embecosm.com>
701 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
702 for nested static variables when searchin VAR_DOMAIN.
703 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
704 global scope, update comment.
705 (add_partial_subprogram): Call add_partial_subprogram recursively
706 for nested subroutines when processinng Fortran.
707 (load_partial_dies): Process the child entities of a subprogram
708 when processing Fortran.
709 (partial_die_parent_scope): Handle building scope
710 for Fortran nested functions.
711 (process_die): Record that nested functions have a scope.
712 (new_symbol): Always record Fortran subprograms on the global
714 (determine_prefix): How to build the prefix for Fortran
717 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
719 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
720 have just sent the thread a SIGSTOP and are waiting for it to
723 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
725 * btrace.c (btrace_add_pc): Remove whitespace before the template
726 parameter in 'std::vector <...>'.
727 (parse_xml_btrace_block): Likewise.
728 (btrace_maint_decode_pt): Likewise.
729 (btrace_maint_update_packets): Likewise.
730 (btrace_maint_print_packets): Likewise.
731 * btrace.h (struct btrace_maint_info): Likewise.
732 * dwarf2read.c (struct type_unit_group): Likewise.
733 (build_type_psymtabs_reader): Likewise.
734 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
735 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
736 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
738 2019-10-03 Tom de Vries <tdevries@suse.de>
740 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
741 the first line of the help text for set/show style metadata.
743 2019-10-02 Tom Tromey <tromey@adacore.com>
745 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
746 * gdbsupport/common-inferior.c: New file.
747 * infcmd.c (startup_with_shell): Don't define.
748 * nat/fork-inferior.h (startup_with_shell): Don't declare.
749 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
750 * inferior.h (startup_with_shell): Don't declare.
752 2019-10-02 Christian Biesinger <cbiesinger@google.com>
754 * gdbsupport/gdb_assert.h: Include errors.h.
755 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
757 2019-10-02 Tom Tromey <tromey@adacore.com>
759 * NEWS: Add $_ada_exception entry.
760 * ada-lang.c (struct ada_catchpoint): Add constructor.
761 <m_kind>: New member.
762 (allocate_location_exception, re_set_exception): Remove
764 (should_stop_exception): Compute $_ada_exception.
765 (check_status_exception, print_it_exception)
766 (print_one_exception, print_mention_exception): Remove
768 (allocate_location_catch_exception, re_set_catch_exception)
769 (check_status_exception, print_it_catch_exception)
770 (print_one_catch_exception, print_mention_catch_exception)
771 (print_recreate_catch_exception)
772 (allocate_location_catch_exception_unhandled)
773 (re_set_catch_exception_unhandled)
774 (check_status_exception, print_it_catch_exception_unhandled)
775 (print_one_catch_exception_unhandled)
776 (print_mention_catch_exception_unhandled)
777 (print_recreate_catch_exception_unhandled)
778 (allocate_location_catch_assert, re_set_catch_assert)
779 (check_status_assert, print_it_catch_assert)
780 (print_one_catch_assert, print_mention_catch_assert)
781 (print_recreate_catch_assert)
782 (allocate_location_catch_handlers, re_set_catch_handlers)
783 (check_status_handlers, print_it_catch_handlers)
784 (print_one_catch_handlers, print_mention_catch_handlers)
785 (print_recreate_catch_handlers): Remove.
786 (create_ada_exception_catchpoint): Update.
787 (initialize_ada_catchpoint_ops): Update.
789 2019-10-02 Tom Tromey <tromey@adacore.com>
791 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
792 (create_excep_cond_exprs): Simplify exception string computation.
793 (ada_exception_catchpoint_cond_string): Likewise.
795 2019-10-02 Tom Tromey <tromey@adacore.com>
797 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
798 * ada-lang.c (lesseq_defined_than): Handle
800 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
802 (dwarf2_has_info): Likewise.
803 (new_symbol): Set maybe_copied on symbol when
805 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
807 <can_copy>: New member.
808 * elfread.c (record_minimal_symbol): Set maybe_copied
809 on symbol when appropriate.
810 (elf_symfile_read): Update call to dwarf2_has_info.
811 * minsyms.c (lookup_minimal_symbol_linkage): New
813 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
814 * symtab.c (get_symbol_address, get_msymbol_address):
816 * symtab.h (get_symbol_address, get_msymbol_address):
818 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
820 (struct symbol, struct minimal_symbol) <maybe_copied>:
823 2019-10-02 Tom Tromey <tromey@adacore.com>
825 * source.c (struct current_source_location): New.
826 (current_source_key): New global.
827 (current_source_symtab, current_source_line)
828 (current_source_pspace): Remove.
829 (get_source_location): New function.
830 (get_current_source_symtab_and_line)
831 (set_default_source_symtab_and_line)
832 (set_current_source_symtab_and_line)
833 (clear_current_source_symtab_and_line, select_source_symtab)
834 (info_source_command, print_source_lines_base)
835 (info_line_command, search_command_helper, _initialize_source):
838 2019-10-02 Tom Tromey <tromey@adacore.com>
840 * source.c (select_source_symtab): Don't call
841 decode_line_with_current_source.
843 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
845 * symtab.c (lookup_global_symbol): Search global block.
847 2019-10-02 Tom Tromey <tromey@adacore.com>
849 * coffread.c (process_coff_symbol): Update.
850 * dwarf2read.c (var_decode_location, new_symbol): Update.
851 * mdebugread.c (parse_symbol): Update.
852 * objfiles.c (relocate_one_symbol): Update.
853 * stabsread.c (define_symbol, fix_common_block)
854 (scan_file_globals): Update.
855 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
856 (SET_SYMBOL_VALUE_ADDRESS): New macro.
857 * xcoffread.c (process_xcoff_symbol): Update.
859 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
861 * MAINTAINERS: Update my email address.
863 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
865 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
867 (build_type_psymtabs_reader): Update for std::vector.
868 (build_type_psymtab_dependencies): Likewise.
869 * dwarf2read.h: Remove use of DEF_VEC_P.
870 (typedef sig_type_ptr): Delete.
872 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
874 * btrace.c (btrace_maint_clear): Update to handle change from VEC
876 (btrace_maint_decode_pt): Likewise, and move allocation of the
877 vector outside of the loop.
878 (btrace_maint_update_packets): Update to handle change from VEC to
880 (btrace_maint_print_packets): Likewise.
881 (maint_info_btrace_cmd): Likewise.
882 * btrace.h: Remove use of DEF_VEC_O.
883 (typedef btrace_pt_packet_s): Delete.
884 (struct btrace_maint_info) <packets>: Change fromm VEC to
886 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
888 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
890 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
891 make accesses into the vector constant references.
892 (btrace_add_pc): Update for std::vector.
893 (btrace_stitch_bts): Likewise.
894 (parse_xml_btrace_block): Likewise.
895 (btrace_maint_update_packets): Likewise.
896 (btrace_maint_print_packets): Likewise.
897 (maint_info_btrace_cmd): Likewise.
898 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
900 (btrace_data::empty): Likewise.
901 (btrace_data_append): Likewise.
902 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
903 (typedef btrace_block_s): Delete.
904 (struct btrace_block): Add constructor.
905 (struct btrace_data_bts) <blocks>: Change to std::vector.
906 * nat/linux-btrace.c (perf_event_read_bts): Update for
908 (linux_read_bts): Likewise.
910 2019-10-01 Tom Tromey <tom@tromey.com>
912 * cli/cli-logging.c (show_logging_filename): Use styled_string.
914 2019-10-01 Tom Tromey <tom@tromey.com>
916 * stack.c (print_frame, info_frame_command_core): Use
918 * linux-thread-db.c (try_thread_db_load_1)
919 (try_thread_db_load_from_pdir_1): Use styled_string.
920 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
921 (auto_load_section_scripts, info_auto_load_local_gdbinit)
922 (maybe_print_unsupported_script_warning)
923 (maybe_print_script_not_found_warning): Use styled_string.
924 * ada-lang.c (user_select_syms): Use styled_string.
926 2019-10-01 Tom Tromey <tom@tromey.com>
928 * p-lang.c (pascal_printstr): Use metadata style.
929 * value.c (show_convenience): Use metadata style.
930 * valprint.c (valprint_check_validity, val_print_optimized_out)
931 (val_print_not_saved, val_print_unavailable)
932 (val_print_invalid_address, generic_val_print, val_print)
933 (value_check_printable, val_print_array_elements): Use metadata
935 * ui-out.h (class ui_out) <field_fmt>: New overload.
936 <do_field_fmt>: Add style parameter.
937 * ui-out.c (ui_out::field_fmt): New overload.
938 * typeprint.c (type_print_unknown_return_type)
939 (val_print_not_allocated, val_print_not_associated): Use metadata
941 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
943 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
944 * tracepoint.c (tvariables_info_1): Use metadata style.
945 * stack.c (print_frame_arg, print_frame_info, print_frame)
946 (info_frame_command_core): Use metadata style.
947 * skip.c (info_skip_command): Use metadata style.
948 * rust-lang.c (rust_print_enum): Use metadata style.
949 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
951 * python/py-framefilter.c (py_print_single_arg): Use metadata
953 * printcmd.c (do_one_display, print_variable_and_value): Use
955 * p-valprint.c (pascal_val_print)
956 (pascal_object_print_value_fields): Use metadata style.
957 * p-typeprint.c (pascal_type_print_base): Use metadata style.
958 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
960 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
961 * m2-valprint.c (m2_print_long_set): Use metadata style.
962 * m2-typeprint.c (m2_print_type): Use metadata style.
963 * infcmd.c (print_return_value_1): Use metadata style.
964 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
965 * f-valprint.c (info_common_command_for_block): Use metadata
967 * f-typeprint.c (f_type_print_base): Use metadata style.
968 * expprint.c (print_subexp_standard): Use metadata style.
969 * cp-valprint.c (cp_print_value_fields): Use metadata style.
970 * cli/cli-style.h (class cli_style_option): Add constructor.
971 (metadata_style): Declare.
972 * cli/cli-style.c (metadata_style): New global.
973 (_initialize_cli_style): Register metadata style.
974 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
976 * cli-out.c (cli_ui_out::do_field_fmt): Update.
977 * c-typeprint.c (c_type_print_base_struct_union)
978 (c_type_print_base_1): Use metadata style.
979 * breakpoint.c (watchpoint_value_print)
980 (print_one_breakpoint_location): Use metadata style.
981 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
983 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
985 * ada-valprint.c (val_print_packed_array_elements, printstr)
986 (print_field_values, ada_val_print_ref, ada_val_print): Use
988 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
990 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
992 * ada-lang.c (user_select_syms): Use metadata style.
994 2019-10-01 Tom Tromey <tom@tromey.com>
996 * cli/cli-cmds.c (pwd_command): Style output.
998 2019-10-01 Pedro Alves <palves@redhat.com>
999 Tom Tromey <tom@tromey.com>
1001 * symtab.c (print_symbol_info): Use %ps.
1002 (print_msymbol_info): Use %ps.
1003 * symfile.c (symbol_file_add_with_addrs): Use %ps.
1004 * printcmd.c (print_variable_and_value): Use %ps.
1005 * macrocmd.c (show_pp_source_pos): Use %ps.
1006 * infrun.c (print_exited_reason): Use ui_out::message.
1007 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1008 (describe_other_breakpoints): Use ui_out::message and new
1010 (say_where): Use new formats.
1011 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1014 2019-10-01 Pedro Alves <palves@redhat.com>
1015 Tom Tromey <tom@tromey.com>
1017 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1018 (test_gdb_formats): New function.
1019 (run_tests): Call it.
1020 (test_format_specifier): Update.
1021 * utils.h (fputs_filtered): Update comment.
1022 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1023 (fputs_styled_unfiltered): Declare.
1024 * utils.c (fputs_styled_unfiltered): New function.
1025 (vfprintf_maybe_filtered): Add gdbfmt parameter.
1026 (vfprintf_filtered): Update.
1027 (vfprintf_unfiltered, vprintf_filtered): Update.
1028 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1029 * ui-out.h (enum ui_out_flag) <unfiltered_output,
1030 disallow_ui_out_field>: New constants.
1031 (enum class field_kind): New.
1032 (struct base_field_s, struct signed_field_s): New.
1033 (signed_field): New function.
1034 (struct string_field_s): New.
1035 (string_field): New function.
1036 (struct styled_string_s): New.
1037 (styled_string): New function.
1038 (class ui_out) <message>: Add comment.
1039 <vmessage, call_do_message>: New methods.
1040 <do_message>: Add style parameter.
1041 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1043 (ui_out::message): Rewrite.
1044 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1046 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1047 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1048 gdb_extensions parameter.
1049 (class format_piece): Add parameter to constructor.
1050 (n_int_args): New field.
1051 * gdbsupport/format.c (format_pieces::format_pieces): Add
1052 gdb_extensions parameter. Handle '*'.
1053 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1054 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
1055 vfprintf_styled_no_gdbfmt.
1056 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1057 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1059 * ui-style.h (struct ui_file_style) <ptr>: New method.
1061 2019-10-01 Tom Tromey <tom@tromey.com>
1063 * unittests/format_pieces-selftests.c: Update. Add final format.
1064 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1065 empty literal pieces.
1067 2019-10-01 Tom Tromey <tom@tromey.com>
1069 * ui-out.h (enum class ui_out_style_kind): Remove.
1070 (class ui_out) <field_string, field_stsream, do_field_string>:
1071 Change type of "style".
1072 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1073 (ui_out::field_string): Update.
1074 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1076 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1077 * tracepoint.c (print_one_static_tracepoint_marker): Update.
1078 * stack.c (print_frame_arg, print_frame_info, print_frame):
1080 * source.c (print_source_lines_base): Update.
1081 * solib.c (info_sharedlibrary_command): Update.
1082 * skip.c (info_skip_command): Update.
1083 * record-btrace.c (btrace_call_history_src_line)
1084 (btrace_call_history): Update.
1085 * python/py-framefilter.c (py_print_frame): Update.
1086 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1088 * mi/mi-out.c (mi_ui_out::do_table_header)
1089 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1090 (mi_ui_out::do_field_string): Update.
1091 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1093 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1095 * cli-out.c (cli_ui_out::do_table_header)
1096 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1097 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1098 (cli_ui_out::do_field_fmt): Update.
1099 * breakpoint.c (print_breakpoint_location): Update.
1100 (update_static_tracepoint): Update.
1102 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1104 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1105 conversion of gdb_datadir.
1106 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1107 remove not needed c_str ().
1109 2019-09-30 Ali Tamur <tamur@google.com>
1111 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1112 (dwarf2_string_attr): Likewise.
1114 2019-09-30 Ali Tamur <tamur@google.com>
1116 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1117 (process_full_type_unit): Likewise.
1118 (dump_die_shallow): Likewise.
1119 (cu_debug_loc_section): Likewise.
1121 2019-09-28 Christian Biesinger <cbiesinger@google.com>
1123 * minsyms.c (compare_minimal_symbols): Rename to...
1124 (minimal_symbol_is_less_than): ...this, and adjust to STL
1125 conventions (return bool, take arguments as references)
1126 (minimal_symbol_reader::install): Call std::sort instead
1129 2019-09-29 Christian Biesinger <cbiesinger@google.com>
1131 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1133 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1134 msymbol_hash, msymbol_demangled_hash>: Improve comments.
1136 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
1138 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1139 * psympriv.h (add_psymbol_to_list): Move comment here and update
1142 2019-09-29 Tom de Vries <tdevries@suse.de>
1144 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1145 Use $tmpdir/$(basename "$output_file").dwz instead of
1146 "${output_file}.dwz".
1148 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
1151 * hppa-linux-nat.c: Include gdbarch.h.
1153 2019-09-26 Christian Biesinger <cbiesinger@google.com>
1155 * blockframe.c (find_pc_partial_function): Change return type to bool.
1156 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1157 * minsyms.c (in_gnu_ifunc_stub): Likewise.
1158 (stub_gnu_ifunc_resolve_name): Likewise.
1159 * symtab.c (compare_filenames_for_search): Likewise.
1160 (compare_glob_filenames_for_search): Likewise.
1161 (matching_obj_sections): Likewise.
1162 (symbol_matches_domain): Likewise.
1163 (find_line_symtab): Change out param EXACT_MATCH to bool *.
1164 (find_line_pc): Change return type to bool.
1165 (find_line_pc_range): Likewise.
1166 (producer_is_realview): Likewise.
1167 * symtab.h (symbol_matches_domain): Likewise.
1168 (find_pc_partial_function): Likewise.
1169 (find_pc_line_pc_range): Likewise.
1170 (in_gnu_ifunc_stub): Likewise.
1171 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1172 (find_line_pc): Likewise.
1173 (find_line_pc_range): Likewise.
1174 (matching_obj_sections): Likewise.
1175 (find_line_symtab): Change out parameter to bool.
1176 (producer_is_realview): Change return type to bool.
1177 (compare_filenames_for_search): Likewise.
1178 (compare_glob_filenames_for_search): Likewise.
1180 2019-09-26 Tom Tromey <tom@tromey.com>
1182 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1183 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1184 * gdb_usleep.h: Remove.
1185 * gdb_usleep.c: Remove.
1186 * utils.c: Don't include gdb_usleep.h.
1188 2019-09-26 Tom Tromey <tromey@adacore.com>
1190 * python/py-type.c (type_to_type_object): Call check_typedef
1193 2019-09-26 Tom Tromey <tom@tromey.com>
1195 * utils.h (initialize_utils): Don't declare.
1196 * top.c (gdb_init): Don't call initialize_utils.
1197 * utils.c (initialize_utils): Remove. Move contents...
1198 (_initialize_utils): ... here.
1200 2019-09-25 Tom Tromey <tom@tromey.com>
1202 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1203 * utils.h (make_hex_string): Don't declare.
1204 * utils.c (make_hex_string): Remove.
1206 2019-09-24 Tom de Vries <tdevries@suse.de>
1209 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1210 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1212 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
1214 * NEWS: Mention new simulator port for PRU.
1216 2019-09-23 Christian Biesinger <cbiesinger@google.com>
1218 * ada-exp.y (write_object_remaining): Update.
1219 * ada-lang.c (ada_decode): Return a std::string instead of a char*
1220 and eliminate the static buffer.
1221 (ada_decode_symbol): Update.
1222 (ada_la_decode): Update.
1223 (ada_sniff_from_mangled_name): Update.
1224 (is_valid_name_for_wild_match): Update.
1225 (ada_lookup_name_info::matches): Update and simplify.
1226 (name_matches_regex): Update.
1227 (ada_add_global_exceptions): Update.
1228 * ada-lang.h (ada_decode): Update signature.
1229 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1230 * dwarf-index-write.c (debug_names::insert): Update.
1232 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1234 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1237 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1239 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1240 Change "nonzero" to "true" in documentation.
1242 2019-09-20 Christian Biesinger <cbiesinger@google.com>
1244 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1245 (_initialize_darwin_solib): Don't set
1246 darwin_so_ops.lookup_lib_global_symbol.
1247 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1248 set_gdbarch_iterate_over_objfiles_in_search_order.
1249 (elf_lookup_lib_symbol): Rename to...
1250 (svr4_iterate_over_objfiles_in_search_order): this, and update
1251 to iterate semantics.
1252 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1253 * solib.c (solib_global_lookup): Remove.
1254 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1255 (solib_global_lookup): Remove.
1256 * symtab.c (lookup_global_or_static_symbol): Remove call to
1257 solib_global_lookup.
1259 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1261 * NEWS: Move entries about default MI version now being
1262 version 3, and about the GDB/MI fix for multi-location
1263 breakpoints to the "since GDB 8.3" section.
1265 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1269 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
1271 * NEWS: Mention that Cell/B.E. debugging support was removed.
1272 * MAINTAINERS: Remove spu target.
1274 * config/djgpp/fnchange.lst: Remove entries for removed files.
1276 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1277 spu-multiarch.o, and spu-tdep.o.
1278 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1279 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1280 spu-multiarch.c, and spu-tdep.c.
1281 * spu-linux-nat.c: Remove file.
1282 * spu-multiarch.c: Remove file.
1283 * spu-tdep.c: Remove file.
1284 * spu-tdep.h: Remove file.
1285 * solib-spu.c: Remove file.
1286 * solib-spu.h: Remove file.
1288 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1289 * configure.nat (spu-linux): Remove.
1290 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1291 solib-multiarch.o from gdb_target_obs.
1294 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1296 (ppc_linux_no_features): Update.
1297 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1299 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1300 (tdesc_powerpc_cell64l): Likewise.
1301 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1302 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1304 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1305 Do not include "features/rs6000/powerpc-cell32l.c" or
1306 "features/rs6000/powerpc-cell64l.c".
1307 (ppc_linux_spu_section): Remove.
1308 (ppc_linux_core_read_description): Remove Cell/B.E. support.
1309 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1310 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1311 (ppc_linux_spe_context_lookup): Remove.
1312 (ppc_linux_spe_context_inferior_created): Remove.
1313 (ppc_linux_spe_context_solib_loaded): Remove.
1314 (ppc_linux_spe_context_solib_unloaded): Remove.
1315 (ppc_linux_spe_context): Remove.
1316 (struct ppu2spu_cache): Remove.
1317 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1318 (struct ppu2spu_data): Remove.
1319 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1320 ppu2spu_unwind): Remove.
1321 (ppc_linux_init_abi): Remove Cell/B.E. support.
1322 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1324 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1325 (rs6000/powerpc-cell64l-expedite): Likewise
1326 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1327 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1328 rs6000/powerpc-cell64l.xml.
1329 * features/rs6000/powerpc-cell32l.xml: Remove.
1330 * features/rs6000/powerpc-cell64l.xml: Likewise.
1331 * features/rs6000/powerpc-cell32l.c: Remove generated file.
1332 * features/rs6000/powerpc-cell64l.c: Likewise.
1333 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1334 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1335 * regformats/reg-spu.dat: Remove.
1337 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1338 * corelow.c (struct spuid_list): Remove.
1339 (add_to_spuid_list): Remove.
1340 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1341 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1342 (remote_protocol_features): Remove associated entries.
1343 (_initialize_remote): No longer initialize them.
1344 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1345 * linux-nat.c (SPUFS_MAGIC): Remove.
1346 (linux_proc_xfer_spu): Remove.
1347 (spu_enumerate_spu_ids): Remove.
1348 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1349 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1350 (linux_make_corefile_notes): No longer call it.
1352 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1353 (cooked_write_test): Likewise.
1355 2019-09-20 Tom Tromey <tom@tromey.com>
1357 * NEWS: Mention case-sensitivity of TUI commands.
1358 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1359 (tui_set_win_height_command, parse_scrolling_args): Likewise.
1360 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1362 2019-09-20 Tom Tromey <tom@tromey.com>
1364 * tui/tui-source.c (tui_source_window::set_contents): Use
1365 make_unique_xstrdup.
1366 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1367 make_unique_xstrdup.
1369 2019-09-20 Tom Tromey <tom@tromey.com>
1371 * tui/tui-data.c: Remove separator comments.
1372 * tui/tui-layout.c: Remove separator comments.
1373 * tui/tui-win.c: Remove separator comments.
1374 * tui/tui-wingeneral.c: Remove separator comments.
1376 2019-09-20 Tom Tromey <tom@tromey.com>
1378 * tui/tui.h (strcat_to_buf): Don't declare.
1379 * tui/tui.c (strcat_to_buf): Remove.
1381 2019-09-20 Tom Tromey <tom@tromey.com>
1383 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1385 * tui/tui-source.c (tui_source_window::set_contents)
1386 (tui_source_window::location_matches_p)
1387 (tui_source_window::maybe_update): Update.
1389 2019-09-20 Tom Tromey <tom@tromey.com>
1391 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1393 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1395 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1396 (tui_data_window::line_from_reg_element_no)
1397 (tui_data_window::first_reg_element_no_inline)
1398 (tui_data_window::show_registers)
1399 (tui_data_window::show_register_group)
1400 (tui_data_window::display_registers_from)
1401 (tui_data_window::display_registers_from_line)
1402 (tui_data_window::first_data_item_displayed)
1403 (tui_data_window::delete_data_content_windows)
1404 (tui_data_window::erase_data_content)
1405 (tui_data_window::do_scroll_vertical)
1406 (tui_data_window::refresh_window)
1407 (tui_data_window::check_register_values): Update.
1409 2019-09-20 Tom Tromey <tom@tromey.com>
1411 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1412 (struct tui_locator_window) <full_name, proc_name>: Now
1414 * tui/tui-stack.c (tui_locator_window::make_status_line)
1415 (tui_locator_window::set_locator_fullname)
1416 (tui_locator_window::set_locator_info): Update.
1417 * tui/tui-source.c (tui_source_window::set_contents)
1418 (tui_source_window::showing_source_p): Update.
1420 2019-09-20 Tom Tromey <tom@tromey.com>
1422 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1423 Don't call tui_locator_win_info_ptr.
1425 2019-09-20 Tom Tromey <tom@tromey.com>
1427 * tui/tui-win.c (tui_resize_all): Don't call refresh.
1429 2019-09-20 Tom Tromey <tom@tromey.com>
1431 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1433 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1434 * tui/tui-layout.c (show_source_disasm_command, show_data)
1435 (show_source_or_disasm_and_command): Use 1 as height for locator.
1437 2019-09-20 Tom Tromey <tom@tromey.com>
1439 * tui/tui.c (tui_enable): Update.
1440 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1442 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1444 * tui/tui-data.c (win_resized): Now bool.
1445 (tui_win_resized): Return bool.
1446 (tui_set_win_resized_to): Accept a bool.
1448 2019-09-20 Tom Tromey <tom@tromey.com>
1450 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1451 Change type of "refresh_values_only".
1452 * tui/tui-regs.c (tui_data_window::show_register_group): Change
1453 type of "refresh_values_only".
1455 2019-09-20 Tom Tromey <tom@tromey.com>
1457 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1459 (tui_disassemble): Add "pos" parameter.
1460 (tui_disasm_window::set_contents): Simplify.
1462 2019-09-20 Tom Tromey <tom@tromey.com>
1464 * tui/tui-winsource.h (struct tui_source_window_base)
1465 <show_source_content>: Now private.
1466 * tui/tui-winsource.c
1467 (tui_source_window_base::show_source_content): Don't handle empty
1470 2019-09-20 Tom Tromey <tom@tromey.com>
1472 * tui/tui-layout.c (show_source_disasm_command)
1473 (show_source_or_disasm_and_command): Don't call
1474 show_source_content.
1476 2019-09-20 Tom Tromey <tom@tromey.com>
1478 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1480 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1481 from tui_make_status_line.
1482 (tui_locator_window::rerender): Update.
1484 2019-09-20 Tom Tromey <tom@tromey.com>
1486 * tui/tui-stack.c (tui_make_status_line): Return std::string.
1487 (tui_locator_window::rerender): Update.
1489 2019-09-20 Tom Tromey <tom@tromey.com>
1491 * tui/tui-winsource.h (struct tui_source_window_base)
1492 <~tui_source_window_base>: Don't declare.
1494 * tui/tui-winsource.c (~tui_source_window_base): Remove.
1495 * tui/tui-source.h (struct tui_source_window) <fullname>: New
1497 * tui/tui-source.c (tui_source_window::set_contents): Update.
1498 (tui_source_window::location_matches_p)
1499 (tui_source_window::maybe_update): Update.
1501 2019-09-20 Tom Tromey <tom@tromey.com>
1503 * tui/tui-winsource.h (~tui_source_element): Remove.
1504 (tui_source_element): Update.
1505 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1506 * tui/tui-winsource.c (tui_show_source_line): Update.
1507 * tui/tui-source.c (tui_source_window::set_contents): Update.
1508 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1510 2019-09-20 Tom Tromey <tom@tromey.com>
1512 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1514 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1515 tui_clear_source_windows_detail.
1516 * tui/tui-winsource.h (struct tui_source_window_base)
1517 <clear_detail>: Don't declare.
1518 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1520 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1522 2019-09-20 Tom Tromey <tromey@adacore.com>
1525 * block.c (contained_in): Fix final return value.
1527 2019-09-20 Alan Modra <amodra@gmail.com>
1529 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1530 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1531 (read_indirect_string_from_dwz): Use bfd accessor.
1532 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1533 * machoread.c (macho_symfile_read_all_oso): Likewise.
1534 * solib.c (solib_bfd_open): Likewise.
1536 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1538 * eval.c: Move declaration of overload_resolution to...
1541 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1543 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1544 * arm-linux-tdep.c: Likewise.
1545 * arm-nbsd-nat.c: Likewise.
1546 * arm-tdep.h: Declare arm_apcs_32.
1547 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1549 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1551 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1552 * dwarf2read.h: Declare dwarf_always_disassemble.
1554 2019-09-19 Tom de Vries <tdevries@suse.de>
1557 * source-cache.c (source_cache::ensure): Catch exception thrown during
1558 construction of the highlighter.
1560 2019-09-18 Alan Modra <amodra@gmail.com>
1562 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1563 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1564 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1565 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1566 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1567 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1568 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1569 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1570 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1571 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1572 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1573 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1574 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1575 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1576 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1577 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1578 * mi/mi-interp.c: Update throughout for bfd section macro and
1580 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1581 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1583 2019-09-18 Tom Tromey <tom@tromey.com>
1586 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1588 (tui_enable): Do not call rl_initialize.
1590 2019-09-18 Christian Groessler <chris@groessler.org>
1592 * alpha-linux-nat.c: Include gdbarch.h.
1594 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1596 * ui-file.c: Include cli/cli-style.h.
1597 (term_cli_styling): Remove cli_styling declaration.
1599 2019-09-18 Alan Modra <amodra@gmail.com>
1601 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1602 to bfd_asymbol_section.
1604 2019-09-18 Alan Modra <amodra@gmail.com>
1606 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1607 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1608 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1610 2019-09-18 Alan Modra <amodra@gmail.com>
1612 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1613 * spu-linux-nat.c (spu_bfd_open): Likewise.
1615 2019-09-18 Christian Biesinger <cbiesinger@google.com>
1617 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1618 to bool to match definition in dwarf2read.c.
1620 2019-09-17 Christian Biesinger <cbiesinger@google.com>
1622 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1623 (print_signatures): Likewise.
1624 (trust_pad_over_xvs): Likewise.
1625 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1626 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1627 * arm-linux-nat.c (arm_apcs_32): Likewise.
1628 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1629 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1630 * arm-tdep.c (arm_debug): Likewise.
1631 (arm_apcs_32): Likewise.
1632 * auto-load.c (debug_auto_load): Likewise.
1633 (auto_load_gdb_scripts): Likewise.
1634 (global_auto_load): Likewise.
1635 (auto_load_local_gdbinit): Likewise.
1636 (auto_load_local_gdbinit_loaded): Likewise.
1637 * auto-load.h (global_auto_load): Likewise.
1638 (auto_load_local_gdbinit): Likewise.
1639 (auto_load_local_gdbinit_loaded): Likewise.
1640 * breakpoint.c (disconnected_dprintf): Likewise.
1641 (breakpoint_proceeded): Likewise.
1642 (automatic_hardware_breakpoints): Likewise.
1643 (always_inserted_mode): Likewise.
1644 (target_exact_watchpoints): Likewise.
1645 (_initialize_breakpoint): Update.
1646 * breakpoint.h (target_exact_watchpoints): Change to bool.
1647 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1648 * cli/cli-cmds.c (trace_commands): Likewise.
1649 * cli/cli-cmds.h (trace_commands): Likewise.
1650 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1652 * cli/cli-logging.c (logging_overwrite): Change to bool.
1653 (logging_redirect): Likewise.
1654 (debug_redirect): Likewise.
1655 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1656 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1658 <boolean_option_def>: Update.
1659 (struct flag_option_def): Change default type of Context to bool
1661 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1662 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1663 (get_setshow_command_value_string): Likewise.
1664 * cli/cli-style.c (cli_styling): Change to bool.
1665 (source_styling): Likewise.
1666 * cli/cli-style.h (source_styling): Likewise.
1667 (cli_styling): Likewise.
1668 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1670 * command.h (var_types): Update comment.
1671 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1672 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1674 (debug_compile_cplus_scopes): Likewise.
1675 * compile/compile-internal.h (compile_debug): Likewise.
1676 * compile/compile.c (compile_debug): Likewise.
1677 (struct compile_options) <raw>: Likewise.
1678 * cp-support.c (catch_demangler_crashes): Likewise.
1679 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1680 (usr_cmd_cris_dwarf2_cfi): Likewise.
1681 * csky-tdep.c (csky_debug): Likewise.
1682 * darwin-nat.c (enable_mach_exceptions): Likewise.
1683 * dcache.c (dcache_enabled_p): Likewise.
1684 * defs.h (info_verbose): Likewise.
1685 * demangle.c (demangle): Likewise.
1686 (asm_demangle): Likewise.
1687 * dwarf-index-cache.c (debug_index_cache): Likewise.
1688 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1689 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1690 * dwarf2read.c (check_physname): Likewise.
1691 (use_deprecated_index_sections): Likewise.
1692 (dwarf_always_disassemble): Likewise.
1693 * eval.c (overload_resolution): Likewise.
1694 * event-top.c (set_editing_cmd_var): Likewise.
1695 (exec_done_display_p): Likewise.
1696 * event-top.h (set_editing_cmd_var): Likewise.
1697 (exec_done_display_p): Likewise.
1698 * exec.c (write_files): Likewise.
1699 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1700 (debug_fbsd_nat): Likewise.
1701 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1703 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1704 <backtrace_past_entry> Likewise.
1705 * gdb-demangle.h (demangle): Likewise.
1706 (asm_demangle): Likewise.
1707 * gdb_bfd.c (bfd_sharing): Likewise.
1708 * gdbcore.h (write_files): Likewise.
1709 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1710 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1711 * gdbthread.h (print_thread_events): Likewise.
1712 * gdbtypes.c (opaque_type_resolution): Likewise.
1713 (strict_type_checking): Likewise.
1714 * gnu-nat.c (gnu_debug_flag): Likewise.
1715 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1716 * guile/scm-param.c (pascm_variable): Add boolval.
1717 (add_setshow_generic): Update.
1718 (pascm_param_value): Update.
1719 (pascm_set_param_value_x): Update.
1720 * hppa-tdep.c (hppa_debug): Change to bool..
1721 * infcall.c (may_call_functions_p): Likewise.
1722 (coerce_float_to_double_p): Likewise.
1723 (unwind_on_signal_p): Likewise.
1724 (unwind_on_terminating_exception_p): Likewise.
1725 * infcmd.c (startup_with_shell): Likewise.
1726 * inferior.c (print_inferior_events): Likewise.
1727 * inferior.h (startup_with_shell): Likewise.
1728 (print_inferior_events): Likewise.
1729 * infrun.c (step_stop_if_no_debug): Likewise.
1730 (detach_fork): Likewise.
1731 (debug_displaced): Likewise.
1732 (disable_randomization): Likewise.
1733 (non_stop): Likewise.
1734 (non_stop_1): Likewise.
1735 (observer_mode): Likewise.
1736 (observer_mode_1): Likewise.
1737 (set_observer_mode): Update.
1738 (sched_multi): Change to bool.
1739 * infrun.h (debug_displaced): Likewise.
1740 (sched_multi): Likewise.
1741 (step_stop_if_no_debug): Likewise.
1742 (non_stop): Likewise.
1743 (disable_randomization): Likewise.
1744 * linux-tdep.c (use_coredump_filter): Likewise.
1745 (dump_excluded_mappings): Likewise.
1746 * linux-thread-db.c (auto_load_thread_db): Likewise.
1747 (check_thread_db_on_load): Likewise.
1748 * main.c (captured_main_1): Update.
1749 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1750 xx2_opt, boolean_opt>: Change to bool.
1751 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1752 * maint.c (maintenance_profile_p): Likewise.
1753 (per_command_time): Likewise.
1754 (per_command_space): Likewise.
1755 (per_command_symtab): Likewise.
1756 * memattr.c (inaccessible_by_default): Likewise.
1757 * mi/mi-main.c (mi_async): Likewise.
1758 (mi_async_1): Likewise.
1759 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1760 * nat/fork-inferior.h (startup_with_shell): Likewise.
1761 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1762 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1763 * nios2-tdep.c (nios2_debug): Likewise.
1764 * or1k-tdep.c (or1k_debug): Likewise.
1765 * parse.c (parser_debug): Likewise.
1766 * parser-defs.h (parser_debug): Likewise.
1767 * printcmd.c (print_symbol_filename): Likewise.
1768 * proc-api.c (procfs_trace): Likewise.
1769 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1770 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1771 (set_parameter_value): Update.
1772 (add_setshow_generic): Update.
1773 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1775 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1777 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1778 * record-btrace.c (record_btrace_target::store_registers): Update.
1779 * record-full.c (record_full_memory_query): Change to bool.
1780 (record_full_stop_at_limit): Likewise.
1781 * record-full.h (record_full_memory_query): Likewise.
1782 * remote-notif.c (notif_debug): Likewise.
1783 * remote-notif.h (notif_debug): Likewise.
1784 * remote.c (use_range_stepping): Likewise.
1785 (interrupt_on_connect): Likewise.
1786 (remote_break): Likewise.
1787 * ser-tcp.c (tcp_auto_retry): Likewise.
1788 * ser-unix.c (serial_hwflow): Likewise.
1789 * skip.c (debug_skip): Likewise.
1790 * solib-aix.c (solib_aix_debug): Likewise.
1791 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1792 (spu_auto_flush_cache_p): Likewise.
1793 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1795 (struct info_print_options) <quiet>: Likewise.
1796 * symfile-debug.c (debug_symfile): Likewise.
1797 * symfile.c (auto_solib_add): Likewise.
1798 (separate_debug_file_debug): Likewise.
1799 * symfile.h (auto_solib_add): Likewise.
1800 (separate_debug_file_debug): Likewise.
1801 * symtab.c (basenames_may_differ): Likewise.
1802 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1803 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1804 (struct info_types_options) <quiet>: Likewise.
1805 * symtab.h (demangle): Likewise.
1806 (basenames_may_differ): Likewise.
1807 * target-dcache.c (stack_cache_enabled_1): Likewise.
1808 (code_cache_enabled_1): Likewise.
1809 * target.c (trust_readonly): Likewise.
1810 (may_write_registers): Likewise.
1811 (may_write_memory): Likewise.
1812 (may_insert_breakpoints): Likewise.
1813 (may_insert_tracepoints): Likewise.
1814 (may_insert_fast_tracepoints): Likewise.
1815 (may_stop): Likewise.
1816 (auto_connect_native_target): Likewise.
1817 (target_stop_and_wait): Update.
1818 (target_async_permitted): Change to bool.
1819 (target_async_permitted_1): Likewise.
1820 (may_write_registers_1): Likewise.
1821 (may_write_memory_1): Likewise.
1822 (may_insert_breakpoints_1): Likewise.
1823 (may_insert_tracepoints_1): Likewise.
1824 (may_insert_fast_tracepoints_1): Likewise.
1825 (may_stop_1): Likewise.
1826 * target.h (target_async_permitted): Likewise.
1827 (may_write_registers): Likewise.
1828 (may_write_memory): Likewise.
1829 (may_insert_breakpoints): Likewise.
1830 (may_insert_tracepoints): Likewise.
1831 (may_insert_fast_tracepoints): Likewise.
1832 (may_stop): Likewise.
1833 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1834 (make_thread_apply_all_options_def_group): Change argument from int*
1836 (thread_apply_all_command): Update.
1837 (print_thread_events): Change to bool.
1838 * top.c (confirm): Likewise.
1839 (command_editing_p): Likewise.
1840 (history_expansion_p): Likewise.
1841 (write_history_p): Likewise.
1842 (info_verbose): Likewise.
1843 * top.h (confirm): Likewise.
1844 (history_expansion_p): Likewise.
1845 * tracepoint.c (disconnected_tracing): Likewise.
1846 (circular_trace_buffer): Likewise.
1847 * typeprint.c (print_methods): Likewise.
1848 (print_typedefs): Likewise.
1849 * utils.c (debug_timestamp): Likewise.
1850 (sevenbit_strings): Likewise.
1851 (pagination_enabled): Likewise.
1852 * utils.h (sevenbit_strings): Likewise.
1853 (pagination_enabled): Likewise.
1854 * valops.c (overload_resolution): Likewise.
1855 * valprint.h (struct value_print_options) <prettyformat_arrays,
1856 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1857 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1858 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1860 * windows-nat.c (new_console): Likewise.
1861 (cygwin_exceptions): Likewise.
1862 (new_group): Likewise.
1863 (debug_exec): Likewise.
1864 (debug_events): Likewise.
1865 (debug_memory): Likewise.
1866 (debug_exceptions): Likewise.
1867 (useshell): Likewise.
1868 * windows-tdep.c (maint_display_all_tib): Likewise.
1869 * xml-support.c (debug_xml): Likewise.
1871 2019-09-17 Mike Gulick <mgulick@mathworks.com>
1873 * source.c (prepare_path_for_appending): New function.
1874 (openp): Make use of new function.
1875 (find_and_open_source): Search for the compilation directory and
1876 source file as a relative path beneath the directory search path.
1878 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1880 * source-cache.c (source_cache::get_line_charpos): Catch
1881 exceptions and return false, this matches the behaviour documented
1884 2019-09-17 Joel Brobecker <brobecker@adacore.com>
1886 * ada-tasks.c (info_task): Remove quoting of the task's name.
1888 2019-09-16 Christian Biesinger <cbiesinger@google.com>
1890 * symfile.c (auto_solib_add): Replace comment with a reference
1893 2019-09-14 Christian Biesinger <cbiesinger@google.com>
1895 * NEWS: Mention that gdb can now be compiled with Python 3
1898 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1900 * maint.c (maint_print_section_data::maint_print_section_data):
1901 Force use of 'float log10 (float)' by casting the argument to
1904 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1906 * maint.c: Add 'cmath' include.
1907 (struct maint_print_section_data): New structure.
1908 (print_section_index): New function.
1909 (print_bfd_section_info): Add header comment, small whitespace
1910 cleanup, and update to call new print_section_index function.
1911 (print_objfile_section_info): Likewise.
1912 (maint_obj_section_from_bfd_section): New function.
1913 (print_bfd_section_info_maybe_relocated): New function.
1914 (maintenance_info_sections): Add header comment, always use
1915 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1917 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1919 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1920 inner scope, add check that the objfile has psymtabs before
1921 checking psymtabs_addrmap.
1922 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1924 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1926 * NEWS: Announce that Ada task names are now shown at more places,
1927 and between quotes (except in info task output).
1928 * gdb/ada-tasks.c (task_to_str): New function.
1929 (display_current_task_id): Call task_to_str.
1930 (task_command_1): Likewise.
1931 (print_ada_task_info): In non-mi mode, Properly align headers and data
1932 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1934 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1936 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1937 prstatus.pr_lwp.pr_info instead of making it up.
1939 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1941 * auto-load.c (auto_load_expand_dir_vars): Update.
1942 * defs.h (gdb_datadir): Change to std::string.
1943 (python_libdir): Likewise.
1944 (relocate_gdb_directory): Change return type to std::string.
1945 * guile/guile.c (gdbscm_data_directory): Update.
1946 (initialize_scheme_side): Update.
1947 * jit.c (jit_reader_dir): Change to std::string.
1948 (jit_reader_load_command): Update.
1949 * main.c (gdb_datadir): Change to std::string.
1950 (python_libdir): Likewise.
1951 (set_gdb_data_directory): Update.
1952 (relocate_path): Change to return std::string.
1953 (relocate_gdb_directory): Change to return std::string.
1954 (relocate_gdbinit_path_maybe_in_datadir): Update.
1955 (captured_main_1): Update.
1956 * python/python.c (do_start_initialization): Update.
1957 * top.c (show_gdb_datadir): Update.
1958 * xml-syscall.c (xml_init_syscalls_info): Update.
1959 (init_syscalls_info): Update.
1961 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1963 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1964 out of get_init_files.
1965 (get_init_files): Update.
1967 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1969 * main.c (get_init_files): Change to use std::string.
1970 (captured_main_1): Update.
1971 (print_gdb_help): Update.
1973 2019-09-11 Ali Tamur <tamur@google.com>
1975 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1978 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1980 * dbxread.c (read_dbx_symtab): Update.
1981 * dwarf2read.c (load_partial_dies): Update.
1982 * mdebugread.c (parse_partial_symbols): Update.
1983 (handle_psymbol_enumerators): Update.
1984 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1985 * psymtab.c (add_psymbol_to_bcache): Likewise.
1986 (add_psymbol_to_list): Likewise.
1987 * symtab.c (symbol_set_names): Likewise.
1988 * symtab.h (symbol_set_names): Likewise.
1989 * xcoffread.c (scan_xcoff_symtab): Update.
1991 2019-09-11 Tom Tromey <tom@tromey.com>
1993 * symfile-mem.c (symbol_file_add_from_memory): Use
1995 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1996 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1998 2019-09-10 Tom Tromey <tromey@adacore.com>
2000 * dwarf-index-write.c (write_psymbols): Extend error message.
2001 (debug_names::insert): Add Ada code.
2002 (debug_names::write_psymbols): Remove Ada check.
2003 (debug_names) <m_string_obstack>: New member.
2004 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2005 (gdb_index_symbol_name_matcher::matches): Remove.
2006 (mapped_index_base::find_name_components_bounds): Add "lang"
2008 (mapped_index_base::build_name_components): Also split names
2009 according to Ada syntax.
2010 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
2011 type of "match_callback".
2012 (check_match, check_find_bounds_finds)
2013 (dw2_expand_symtabs_matching): Update.
2014 (dw2_debug_names_iterator): Add new constructor.
2015 (dw2_debug_names_map_matching_symbols): New function.
2016 (dw2_debug_names_expand_symtabs_matching): Update.
2017 (dwarf2_debug_names_functions): Use
2018 dw2_debug_names_map_matching_symbols.
2020 2019-09-10 Tom Tromey <tromey@adacore.com>
2022 * dwarf2read.c (dw2_get_file_names_reader): Add the
2023 CU's file name to the results.
2025 2019-09-10 Tom Tromey <tromey@adacore.com>
2027 * ada-lang.c (add_nonlocal_symbols): Combine calls to
2028 map_matching_symbols. Update.
2029 * dwarf2read.c (dw2_map_matching_symbols): Update.
2030 * psymtab.c (match_partial_symbol): Change type; update.
2031 (psym_map_matching_symbols): Likewise.
2032 * symfile-debug.c (debug_qf_map_matching_symbols): Change
2034 * symfile.h (struct quick_symbol_functions)
2035 <map_matching_symbols>: Change "name" to be a lookup_name_info.
2038 2019-09-10 Tom Tromey <tromey@adacore.com>
2040 * psymtab.c (map_block): Remove.
2041 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2042 * symtab.c (iterate_over_symbols_terminated): New function.
2043 * symtab.c (iterate_over_symbols_terminated): Declare.
2045 2019-09-10 Tom Tromey <tromey@adacore.com>
2047 * ada-lang.c (ada_iterate_over_symbols): Return bool.
2048 * language.h (struct language_defn) <la_iterate_over_symbols>:
2050 * symtab.c (iterate_over_symbols): Return bool.
2051 * symtab.h (iterate_over_symbols): Return bool.
2053 2019-09-10 Tom Tromey <tromey@adacore.com>
2055 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2056 (add_nonlocal_symbols): Update.
2057 * dwarf2read.c (dw2_map_matching_symbols): Change type.
2058 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2059 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2060 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2061 Change type of "callback". Remove "data".
2064 2019-09-09 Ali Tamur <tamur@google.com>
2066 * dwarf2read.c (comp_unit_head): Update comment.
2067 (dwarf2_dwo_name): New function declaration.
2068 (dwarf_unit_type_name): New function declaration.
2069 (read_comp_unit_head): Add support for new compilation units,
2070 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2071 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2072 (currently named as "signature") in their header. Also clarify error
2074 (lookup_dwo_id): New function. Returns the dwo id of the given
2076 (lookup_dwo_unit): Use the new lookup_dwo_id function.
2077 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2079 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2080 (dwarf2_dwo_name): Get the dwo name if present.
2081 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2084 2019-09-09 Tom Tromey <tom@tromey.com>
2086 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2088 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2090 * python/python.c (do_start_initialization): Make progname_copy static,
2091 to avoid a leak report.
2093 2019-09-08 Tom Tromey <tom@tromey.com>
2095 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2097 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
2099 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2100 Change type to gdb::optional<block_enum>.
2101 (dw2_symtab_iter_init): Change block_index parameter type
2102 to gdb::optional<block_enum>.
2103 (dw2_lookup_symbol): Change block_index parameter
2104 type to block_enum.c
2105 (dw2_debug_names_lookup_symbol): Likewise.
2106 * psymtab.c (psym_lookup_symbol): Likewise.
2107 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2108 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2111 2019-09-06 Christian Biesinger <cbiesinger@google.com>
2113 * defs.h (relocate_gdb_directory): Change int to bool in
2114 signature and rename flag to relocatable.
2115 * main.c (relocate_path): Likewise.
2116 (relocate_gdb_directory): Likewise.
2118 2019-09-06 Alan Modra <amodra@gmail.com>
2120 * coffread.c (coff_symfile_read): Constify filename variable.
2121 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2122 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2123 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2124 * solib.c (reload_shared_libraries_1): Likewise.
2125 * symfile.c (reread_symbols): Likewise.
2126 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2127 * solib-darwin.c (darwin_bfd_open): Likewise.
2128 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2130 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
2132 * psymtab.c (print_partial_symbols): Handle missing domain_enum
2133 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2135 2019-09-03 Tom Tromey <tromey@adacore.com>
2137 * ada-valprint.c (ada_val_print_num): Don't recurse for range
2139 (has_negatives): Unbias a range type bound.
2140 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2141 * gdbtypes.c (operator==): Handle new field.
2142 (create_range_type): Add "bias" parameter.
2143 (create_static_range_type, resolve_dynamic_range): Update.
2144 * gdbtypes.h (struct range_bounds) <bias>: New member.
2145 (create_range_type): Add bias parameter.
2146 * printcmd.c (print_scalar_formatted): Unbias range types.
2147 * value.c (unpack_long): Unbias range types.
2148 (pack_long): Bias range types.
2150 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2152 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2155 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2157 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2158 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2159 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2160 (compile_probe_arg): Likewise.
2161 * probe.h (get_argument_count): Likewise.
2162 * solib-svr4.c (solib_event_probe_action): Likewise.
2163 * stap-probe.c (stap_probe::get_argument_count): Likewise.
2165 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2167 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2169 (svr4_create_solib_event_breakpoints): ...from here.
2171 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
2173 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2174 suffix from warning message.
2176 2019-08-30 Tom Tromey <tom@tromey.com>
2178 * tui/tui-winsource.h (struct tui_source_window_base)
2179 <refresh_all>: Don't declare.
2180 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2182 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2183 tui_show_locator_content.
2184 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2186 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2187 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2190 2019-08-30 Tom Tromey <tom@tromey.com>
2192 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2194 2019-08-30 Tom Tromey <tom@tromey.com>
2196 * tui/tui-stack.c (_initialize_tui_stack): Move later.
2197 Remove unnecessary forward declarations.
2199 2019-08-30 Tom Tromey <tom@tromey.com>
2201 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2203 (tui_update_locator_fullname, tui_show_frame_info): Don't call
2204 tui_show_locator_content.
2206 2019-08-30 Tom Tromey <tom@tromey.com>
2208 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
2209 (tui_locator_window::rerender): Rewrite using body of previous
2210 tui_show_locator_content.
2212 2019-08-30 Tom Tromey <tom@tromey.com>
2214 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2215 set_locator_fullname>: New methods.
2216 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2217 Rename from tui_set_locator_fullname.
2218 (tui_locator_window::set_locator_info): Rename from
2219 tui_set_locator_info. Return bool.
2220 (tui_update_locator_fullname, tui_show_frame_info): Update.
2222 2019-08-30 Tom Tromey <tom@tromey.com>
2224 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2226 2019-08-30 Tom Tromey <tom@tromey.com>
2228 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2231 2019-08-30 Tom Tromey <tom@tromey.com>
2233 * tui/tui-wingeneral.c (box_win): Assume win_info and
2234 win_info->handle cannot be NULL.
2236 2019-08-30 Tom Tromey <tom@tromey.com>
2238 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2239 refresh_window>: Declare.
2240 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2242 (tui_data_item_window::rerender): Rename from
2243 tui_display_register.
2244 (tui_data_item_window::refresh_window): New method.
2245 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2248 2019-08-30 Tom Tromey <tom@tromey.com>
2250 * tui/tui-regs.h (struct tui_data_window) <regs_content,
2251 regs_column_count, current_group>: Move later. Now private.
2252 <get_current_group>: New method.
2253 * tui/tui-regs.c (tui_reg_command): Update.
2254 * tui/tui-layout.c (tui_set_layout): Update.
2256 2019-08-30 Tom Tromey <tom@tromey.com>
2258 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2259 (tui_data_window::rerender): Don't call
2260 check_and_display_highlight_if_needed.
2261 (tui_data_window::refresh_all): Remove call to
2264 2019-08-30 Tom Tromey <tom@tromey.com>
2266 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2267 (tui_data_window::display_registers_from)
2268 (tui_data_window::display_reg_element_at_line)
2269 (tui_data_window::display_registers_from_line): Remove checks of
2272 2019-08-30 Tom Tromey <tom@tromey.com>
2274 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2276 * tui/tui-regs.c (tui_data_window::show_registers): Call
2278 (tui_data_window::rerender): Rename from display_all_data.
2279 (tui_data_window::rerender): Remove old implementation.
2281 2019-08-30 Tom Tromey <tom@tromey.com>
2283 * tui/tui-regs.c (tui_data_window::display_all_data): Change
2285 * tui/tui-data.h (NO_DATA_STRING): Remove define.
2287 2019-08-29 Bernhard Wodok <barto@gmx.net>
2288 Sergio Durigan Junior <sergiodj@redhat.com>
2291 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2293 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2295 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2296 when searching for types.
2298 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2300 * f-lang.c (f_language_defn): Use f_print_typedef.
2301 * f-lang.h (f_print_typedef): Declare.
2302 * f-typeprint.c (f_print_typedef): Define.
2304 2019-08-27 Christian Biesinger <cbiesinger@google.com>
2306 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2308 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
2310 * cli/cli-utils.c (info_print_options_defs): Delete.
2311 (make_info_print_options_def_group): Delete.
2312 (extract_info_print_options): Delete.
2313 (info_print_command_completer): Delete.
2314 (info_print_args_help): Add extra parameter, and optionally
2315 include text about -n flag.
2316 * cli/cli-utils.h (struct info_print_options): Delete.
2317 (extract_info_print_options): Delete declaration.
2318 (info_print_command_completer): Delete declaration.
2319 (info_print_args_help): Add extra parameter, extend header
2321 * python/python.c (gdbpy_rbreak): Pass additional parameter to
2323 * stack.c (struct info_print_options): New type.
2324 (info_print_options_defs): New file scoped variable.
2325 (make_info_print_options_def_group): New static function.
2326 (info_print_command_completer): New static function.
2327 (info_locals_command): Update to use new local functions.
2328 (info_args_command): Likewise.
2329 (_initialize_stack): Add extra parameter to calls to
2330 info_print_args_help.
2331 * symtab.c (search_symbols): Add extra parameter, use this to
2332 possibly excluse non-debug symbols.
2333 (symtab_symbol_info): Add extra parameter, which is passed on to
2335 (struct info_print_options): New type.
2336 (info_print_options_defs): New file scoped variable.
2337 (make_info_print_options_def_group): New static function.
2338 (info_print_command_completer): New static function.
2339 (info_variables_command): Update to use local functions, and pass
2340 extra parameter through to symtab_symbol_info.
2341 (info_functions_command): Likewise.
2342 (info_types_command): Pass additional argument through to
2344 (rbreak_command): Pass extra argument to search_symbols.
2345 (_initialize_symtab): Add extra arguments for calls to
2346 info_print_args_help, and update help text for 'info variables',
2347 'whereis', and 'info functions' commands.
2348 * symtab.h (search_symbols): Add extra argument to declaration.
2349 * NEWS: Mention new flags.
2351 2019-08-26 Christian Biesinger <cbiesinger@google.com>
2353 * symtab.c (lookup_static_symbol): Call the new function (and move
2354 it down to be next to lookup_global_symbol).
2355 (struct global_sym_lookup_data): Add block_enum member and rename to...
2356 (struct global_or_static_sym_lookup_data): ...this.
2357 (lookup_symbol_global_iterator_cb): Pass block_index instead of
2358 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2359 (lookup_symbol_global_or_static_iterator_cb): ...this.
2360 (lookup_global_or_static_symbol): New function.
2361 (lookup_global_symbol): Call new function.
2363 2019-08-26 Tom de Vries <tdevries@suse.de>
2366 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2367 when pc_probe.prob == NULL.
2369 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2371 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2372 variable symbol_linkage to symbol_linkage_.
2374 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2376 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2377 represent whether the symbol is static, dynamic, or we don't
2380 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
2382 * gdb/rx-tdep.c (rx_register_names): New.
2383 (rx_register_name): Delete.
2384 (rx_psw_type): Delete.
2385 (rx_fpsw_type): Delete.
2386 (rx_register_type): Delete.
2387 (rx_gdbarch_init): Convert target-descriptions.
2388 (_initialize_rx_tdep): Add initialize_tdesc_rx.
2389 * gdb/features/Makefile: Add rx.xml.
2390 * gdb/features/rx.xml: New.
2391 * gdb/features/rx.c: Generated.
2392 * gdb/NEWS: Mention target description support.
2394 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2396 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2399 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
2401 * configure.ac: Don't check for 'dlfcn.h' (moved to
2402 gdbsupport/common.m4).
2403 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2405 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2406 * compile/compile-c-support.c: Include
2407 'gdbsupport/gdb-dlfcn.h'.
2408 * gdbsupport/common.m4: Check for 'dlfcn.h'.
2409 * gdb-dlfcn.c: Move to...
2410 * gdbsupport/gdb-dlfcn.c: ... here.
2411 * gdb-dlfcn.h: Move to...
2412 * gdbsupport/gdb-dlfcn.h: ... here.
2414 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
2416 * nios2-tdep.c (struct reg_value): Improve comments. Make
2417 the offset field signed.
2419 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2421 * python/lib/gdb/__init__.py (_execute_file): New function.
2422 * python/python.c (python_run_simple_file): Call gdb._execute_file
2425 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
2427 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2428 all uses as this was never set to anything but a zero value.
2430 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
2432 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2434 2019-08-21 Christian Biesinger <cbiesinger@google.com>
2436 * tui/tui-data.h (tui_gen_win_info): Add an =default
2437 move constructor, required by some GCC versions.
2439 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
2441 * go32-nat.c (go32_sysinfo): Add hygon_p.
2443 2019-08-20 Tom Tromey <tom@tromey.com>
2445 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2446 line_from_reg_element_no, first_reg_element_no_inline,
2447 display_all_data, delete_data_content_windows,
2448 erase_data_content>: Now private.
2450 2019-08-20 Tom Tromey <tom@tromey.com>
2452 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2453 (tui_unhighlight_win, tui_highlight_win)
2454 (tui_win_info::make_window): Update.
2455 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2457 2019-08-20 Tom Tromey <tom@tromey.com>
2459 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2460 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2461 (MAX_PID_WIDTH): Move to tui-stack.c.
2462 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2463 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2464 (MAX_PID_WIDTH): Move from tui-data.h.
2466 2019-08-20 Tom Tromey <tom@tromey.com>
2468 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2469 * tui/tui-wingeneral.c (box_win): Change type of win_info.
2471 (tui_gen_win_info::make_window): Rename from tui_make_window.
2472 (tui_win_info::make_window): New method.
2473 (tui_gen_win_info::make_visible): Update.
2474 * tui/tui-source.c (tui_source_window::set_contents): Update.
2475 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2476 (tui_data_window::display_registers_from): Update.
2477 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2478 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2482 (struct tui_win_info) <make_window>: Declare.
2483 <can_box>: Now virtual.
2484 <title>: New member.
2485 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2486 * tui/tui-command.c (tui_cmd_window::resize): Update.
2488 2019-08-20 Tom Tromey <tom@tromey.com>
2490 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2491 * tui/tui-regs.c (tui_data_window::show_registers): Update.
2492 (tui_data_window::check_register_values): Update.
2494 2019-08-20 Tom Tromey <tom@tromey.com>
2496 * tui/tui-regs.h (struct tui_data_window): Use
2497 DISABLE_COPY_AND_ASSIGN.
2498 <regs_content>: Change type, removing unique_ptr.
2499 <tui_data_window>: Add move constructor.
2500 * tui/tui-regs.c (tui_data_window::show_registers)
2501 (tui_data_window::show_register_group)
2502 (tui_data_window::display_registers_from)
2503 (tui_data_window::display_registers_from)
2504 (tui_data_window::first_data_item_displayed)
2505 (tui_data_window::delete_data_content_windows)
2506 (tui_data_window::rerender, tui_data_window::refresh_window)
2507 (tui_data_window::check_register_values): Update.
2509 2019-08-20 Tom Tromey <tom@tromey.com>
2511 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2512 show_register_group>: Declare.
2513 (tui_show_register_group): Don't declare.
2514 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2516 (tui_data_window::show_register_group): Rename from
2517 tui_show_register_group.
2518 (tui_data_window::check_register_values, tui_reg_command):
2520 * tui/tui-layout.c (tui_set_layout): Update.
2522 2019-08-20 Tom Tromey <tom@tromey.com>
2524 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2526 (tui_check_register_values): Don't declare.
2527 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2528 from tui_check_register_values.
2529 * tui/tui-hooks.c (tui_register_changed): Update.
2531 2019-08-20 Tom Tromey <tom@tromey.com>
2533 * tui/tui-regs.c (tui_reg_layout): Move later.
2534 (tui_show_registers): Don't enable TUI mode or change layout.
2536 2019-08-20 Tom Tromey <tom@tromey.com>
2538 * tui/tui-regs.h (struct tui_data_item_window)
2539 <~tui_data_item_window>: Remove.
2540 <content>: Now a unique_xmalloc_ptr.
2541 * tui/tui-regs.c (tui_register_format): Return a
2543 (tui_get_register): Update.
2544 (~tui_data_item_window): Remove.
2545 (tui_data_window::display_registers_from, tui_display_register):
2547 * tui/tui-io.h (tui_expand_tabs): Update.
2548 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2549 Remove "col" parameter.
2551 2019-08-20 Tom Tromey <tom@tromey.com>
2553 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2555 * tui/tui-regs.c (~tui_data_item_window): Update.
2557 2019-08-20 Tom Tromey <tom@tromey.com>
2559 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2562 2019-08-20 Tom Tromey <tom@tromey.com>
2564 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2566 2019-08-20 Tom Tromey <tom@tromey.com>
2568 * tui/tui-source.h (struct tui_source_window): Update.
2569 * tui/tui-regs.c (tui_show_registers): Update.
2570 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2571 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2572 (NO_REGS_STRING): Remove defines.
2574 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
2576 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2577 unnecessary thread walk if remote doesn't support the packet.
2579 2019-08-19 Tom Tromey <tromey@adacore.com>
2581 * python/py-value.c (value_has_field): Fix indentation.
2583 2019-08-19 Tom Tromey <tromey@adacore.com>
2585 * printcmd.c (do_one_display, info_display_command): Update.
2586 * block.h (contained_in): Return bool. Add allow_nested
2588 * block.c (contained_in): Return bool. Add allow_nested
2591 2019-08-19 Tom Tromey <tom@tromey.com>
2593 * configure: Rebuild.
2594 * configure.ac: Disallow the combination of -static-libstdc++ and
2596 * source-cache.c (get_language_name): Handle rust.
2597 (source_cache::get_source_lines): Ignore highlighting exceptions.
2599 2019-08-16 Tom Tromey <tom@tromey.com>
2601 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2602 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2603 (struct tui_source_window_base) <make_visible, refresh_window,
2604 resize>: Remove methods.
2605 <execution_info>: Remove field.
2606 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2607 (tui_show_source_line, tui_source_window_base)
2608 (~tui_source_window_base): Update.
2609 (tui_source_window_base::resize)
2610 (tui_source_window_base::make_visible)
2611 (tui_source_window_base::refresh_window): Remove.
2612 (tui_source_window_base::update_exec_info): Update.
2613 * tui/tui-source.c (tui_source_window::set_contents): Update.
2614 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2616 2019-08-16 Tom Tromey <tom@tromey.com>
2618 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2619 deprecated_query_hook.
2621 2019-08-16 Tom Tromey <tom@tromey.com>
2623 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2624 (tui_update_source_windows_with_line): Update.
2625 * tui/tui-source.h (struct tui_source_window)
2626 <show_symtab_source>: Declare.
2627 (tui_show_symtab_source): Don't declare.
2628 * tui/tui-source.c (tui_show_symtab_source): Rename from
2629 tui_show_symtab_source.
2631 2019-08-16 Tom Tromey <tom@tromey.com>
2633 * tui/tui-winsource.h (struct tui_source_window_base)
2634 <set_contents>: Declare.
2635 * tui/tui-winsource.c
2636 (tui_source_window_base::update_source_window_as_is): Update.
2637 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2639 (tui_set_source_content): Don't declare.
2640 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2641 tui_set_source_content.
2642 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2644 (tui_set_disassem_content): Don't declare.
2645 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2646 tui_set_disassem_content.
2648 2019-08-16 Tom Tromey <tom@tromey.com>
2650 * tui/tui-winsource.h (struct tui_source_window_base)
2651 <update_breakpoint_info>: Declare.
2652 (tui_update_breakpoint_info): Don't declare.
2653 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2654 (tui_update_all_breakpoint_info): Update.
2655 (tui_source_window_base::update_breakpoint_info): Rename from
2656 tui_update_breakpoint_info.
2657 (tui_source_window_base::update_exec_info): Update.
2659 2019-08-16 Tom Tromey <tom@tromey.com>
2661 * tui/tui-winsource.h (struct tui_source_window_base)
2662 <update_source_window>: Declare.
2663 (tui_update_source_window): Don't declare.
2664 * tui/tui-winsource.c
2665 (tui_source_window_base::update_source_window): Rename from
2666 tui_update_source_window.
2667 (tui_source_window_base::rerender): Update.
2668 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2669 * tui/tui-disasm.c (tui_show_disassem)
2670 (tui_show_disassem_and_update_source)
2671 (tui_disasm_window::maybe_update): Update.
2673 2019-08-16 Tom Tromey <tom@tromey.com>
2675 * tui/tui-winsource.h (struct tui_source_window_base)
2676 <update_source_window_as_is>: Declare.
2677 (tui_update_source_window_as_is): Don't declare.
2678 * tui/tui-winsource.c (tui_update_source_window): Update
2679 (tui_source_window_base::update_source_window_as_is): Rename from
2680 tui_update_source_window_as_is.
2681 (tui_source_window_base::refill): Update.
2682 * tui/tui-source.c (tui_show_symtab_source): Update.
2683 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2686 2019-08-16 Tom Tromey <tom@tromey.com>
2688 * tui/tui-winsource.h (tui_update_source_window)
2689 (tui_update_source_window_as_is): Remove "noerror" parameter.
2690 * tui/tui-winsource.c (tui_update_source_window)
2691 (tui_update_source_window_as_is): Remove "noerror" parameter.
2692 (tui_update_source_windows_with_addr)
2693 (tui_update_source_windows_with_line)
2694 (tui_source_window_base::rerender)
2695 (tui_source_window_base::refill): Update.
2696 * tui/tui-source.h (tui_set_source_content)
2697 (tui_show_symtab_source): Remove "noerror" parameter.
2698 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2700 (tui_show_symtab_source): Likewise.
2701 (tui_source_window::maybe_update): Update.
2702 * tui/tui-disasm.c (tui_show_disassem)
2703 (tui_show_disassem_and_update_source)
2704 (tui_disasm_window::do_scroll_vertical)
2705 (tui_disasm_window::maybe_update): Update.
2707 2019-08-16 Tom Tromey <tom@tromey.com>
2709 * tui/tui.c (tui_is_window_visible): Update.
2710 * tui/tui-wingeneral.c (tui_make_window)
2711 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2712 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2713 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2714 (tui_set_win_height_command, parse_scrolling_args): Update.
2715 * tui/tui-source.c (tui_source_window::style_changed): Update.
2716 * tui/tui-regs.c (tui_show_registers)
2717 (tui_data_window::first_data_item_displayed)
2718 (tui_data_window::delete_data_content_windows)
2719 (tui_check_register_values, tui_reg_command): Update.
2720 * tui/tui-disasm.c (tui_show_disassem): Update.
2721 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2723 <is_visible>: Remove field.
2724 * tui/tui-data.c (tui_next_win, tui_prev_win)
2725 (tui_delete_invisible_windows): Update.
2727 2019-08-16 Tom Tromey <tom@tromey.com>
2729 * tui/tui-winsource.h (struct tui_source_window_base)
2730 <m_has_locator>: Remove.
2731 * tui/tui-layout.c (show_source_disasm_command, show_data)
2732 (show_source_or_disasm_and_command): Update.
2734 2019-08-16 Alan Hayward <alan.hayward@arm.com>
2736 * NEWS (Other MI changes): New subsection.
2737 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2738 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2739 * arch-utils.c (default_get_pc_address_flags): New function.
2740 * arch-utils.h (default_get_pc_address_flags): New declaration.
2741 * gdbarch.sh: Add get_pc_address_flags.
2742 * gdbarch.c: Regenerate.
2743 * gdbarch.h: Likewise.
2744 * stack.c (print_pc): New function.
2745 (print_frame_info) (print_frame): Call print_pc.
2747 2019-08-16 Tom de Vries <tdevries@suse.de>
2749 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2750 print_objfile_section_info.
2752 2019-08-15 Tom Tromey <tom@tromey.com>
2754 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2755 calling update_cmdwin_start_line.
2756 * tui/tui-winsource.h (struct tui_source_window_base)
2757 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2758 <rerender>: Declare.
2759 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2761 (tui_source_window_base::set_new_height): Remove.
2762 (tui_source_window_base::rerender): Rename from
2763 do_make_visible_with_new_height.
2764 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2766 (tui_win_info::make_invisible_and_set_new_height)
2767 (tui_win_info::make_visible_with_new_height): Remove.
2768 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2770 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2771 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2772 do_make_visible_with_new_height>: Don't declare.
2773 <rerender>: Declare.
2774 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2776 (tui_data_window::do_make_visible_with_new_height): Remove.
2777 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2778 call tui_show_locator_content.
2779 (tui_gen_win_info::resize): Call rerender.
2780 (show_source_or_disasm_and_command): Don't call
2781 tui_show_locator_content.
2782 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2784 (struct tui_win_info) <rerender>: Declare.
2785 <set_new_height, make_invisible_and_set_new_height,
2786 make_visible_with_new_height>: Don't declare.
2787 * tui/tui-data.c (tui_win_list::rerender): New method.
2788 * tui/tui-command.h (struct tui_cmd_window)
2789 <do_make_visible_with_new_height>: Don't declare.
2791 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2793 2019-08-15 Tom Tromey <tromey@adacore.com>
2795 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2796 * ada-lang.c (ada_enum_name): Likewise.
2798 2019-08-15 Christian Biesinger <cbiesinger@google.com>
2800 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2802 (GdbOutputErrorFile): Likewise.
2803 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2805 (execute_unwinders): Rename to have a leading underscore.
2806 (auto_load_packages): Likewise.
2807 (global scope): Adjust call to auto_load_packages accordingly.
2808 (GdbSetPythonDirectory): Likewise.
2809 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2810 instead of execute_unwinders.
2812 2019-08-15 Tom Tromey <tom@tromey.com>
2814 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2815 (show_data): Don't change window visibility.
2816 (tui_gen_win_info::resize): Remove special case for command
2817 window. Use wresize, when available.
2818 (show_source_or_disasm_and_command): Don't change window
2820 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2821 <make_visible>: New method.
2822 * tui/tui-command.c (tui_cmd_window::resize): New method.
2824 2019-08-15 Tom Tromey <tom@tromey.com>
2826 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2827 (struct tui_source_windows): New.
2828 * tui/tui-winsource.c (tui_display_main): Update.
2829 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2830 (new_height_ok, parse_scrolling_args): Update.
2831 * tui/tui-layout.c (show_layout, show_data): Update.
2832 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2833 (tui_add_to_source_windows): Don't declare.
2834 * tui/tui-data.c (source_windows, tui_source_windows)
2835 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2837 2019-08-15 Tom Tromey <tom@tromey.com>
2839 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2841 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2842 * tui/tui-layout.c (show_source_disasm_command, show_data):
2844 (tui_gen_win_info::resize): Rename.
2845 (show_source_or_disasm_and_command): Update.
2846 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2849 2019-08-15 Tom Tromey <tom@tromey.com>
2851 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2852 * tui/tui-interp.c (tui_interp::init): Don't call
2853 tui_initialize_static_data.
2854 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2856 2019-08-15 Tom Tromey <tom@tromey.com>
2858 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2859 examine tui_win_list.
2861 2019-08-15 Tom Tromey <tom@tromey.com>
2863 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2864 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2865 tui_clear_source_content.
2866 (tui_clear_source_content): Remove.
2867 (tui_source_window_base::do_erase_source_content): Hoist call to
2869 * tui/tui-stack.c (tui_show_frame_info): Don't call
2870 tui_clear_source_content.
2872 2019-08-15 Tom Tromey <tom@tromey.com>
2874 * tui/tui-winsource.h (struct tui_source_window_base)
2875 <do_erase_source_content>: New method.
2876 <erase_source_content>: New method.
2877 (tui_erase_source_content): Don't declare.
2878 * tui/tui-winsource.c (tui_clear_source_content): Update.
2879 (tui_source_window_base::do_erase_source_content): Rename from
2880 tui_erase_source_content.
2881 (tui_source_window_base::show_source_content): Update.
2882 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2883 * tui/tui-source.h (struct tui_source_window)
2884 <erase_source_content>: New method.
2885 * tui/tui-disasm.h (struct tui_disasm_window)
2886 <erase_source_content>: New method.
2888 2019-08-15 Tom Tromey <tom@tromey.com>
2890 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2891 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2893 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2894 * tui/tui-source.c (tui_set_source_content): Update.
2895 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2897 2019-08-15 Tom Tromey <tom@tromey.com>
2899 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2900 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2902 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2904 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2906 (tui_source_window::maybe_update): Update.
2908 2019-08-15 Tom Tromey <tom@tromey.com>
2910 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2911 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2913 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2915 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2917 (tui_disasm_window::maybe_update): Update.
2919 2019-08-15 Tom Tromey <tom@tromey.com>
2921 * tui/tui-winsource.h (struct tui_source_window_base)
2922 <maybe_update>: Declare.
2923 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2925 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2927 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2928 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2930 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2932 2019-08-15 Tom Tromey <tom@tromey.com>
2934 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2936 2019-08-15 Tom Tromey <tom@tromey.com>
2938 * tui/tui-wingeneral.c: Include tui-stack.h.
2939 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2940 (struct tui_locator_window): Move from tui-data.h.
2941 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2942 (tui_initialize_static_data): Move from tui-data.c.
2943 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2944 (struct tui_locator_window): Move to tui-stack.c.
2945 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2946 (tui_initialize_static_data): Move to tui-stack.c.
2948 2019-08-15 Tom Tromey <tom@tromey.com>
2950 * tui/tui-layout.c (show_source_disasm_command)
2951 (show_source_or_disasm_and_command): Use make_visible method, not
2953 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2956 2019-08-15 Tom Tromey <tom@tromey.com>
2958 * tui/tui-wingeneral.h (tui_make_window): Update.
2959 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2961 (tui_gen_win_info::make_visible): Update.
2962 * tui/tui-regs.c (tui_data_window::display_registers_from):
2964 * tui/tui-layout.c (show_source_disasm_command)
2965 (show_source_or_disasm_and_command): Update.
2966 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2967 (enum tui_box): Remove.
2968 (struct tui_win_info) <can_box>: New method.
2969 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2972 2019-08-15 Tom de Vries <tdevries@suse.de>
2974 * linux-nat-trad.c: Include gdbarch.h.
2976 2019-08-14 Alan Hayward <alan.hayward@arm.com>
2978 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2981 2019-08-14 Tom Tromey <tromey@adacore.com>
2983 * darwin-nat.c: Include gdbarch.h.
2984 * darwin-nat-info.c: Include gdbarch.h.
2986 2019-08-13 Tom Tromey <tom@tromey.com>
2988 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2990 * tui/tui-data.c (tui_initialize_static_data): Update.
2992 2019-08-13 Tom Tromey <tom@tromey.com>
2994 * tui/tui-winsource.h (struct tui_exec_info_window)
2995 <~tui_exec_info_window, maybe_allocate_content, get_content,
2997 (struct tui_source_window_base) <set_exec_info_content,
2998 show_exec_info_content>: Don't declare.
2999 * tui/tui-winsource.c
3000 (tui_exec_info_window::maybe_allocate_content): Remove.
3001 (tui_source_window_base::update_exec_info): Rename from
3002 set_exec_info_content.
3003 (tui_source_window_base::show_exec_info_content)
3004 (tui_source_window_base::update_exec_info): Remove.
3006 2019-08-13 Tom Tromey <tom@tromey.com>
3008 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3010 * tui/tui-winsource.c (tui_update_source_window_as_is)
3011 (tui_update_source_windows_with_addr, tui_erase_source_content):
3013 (tui_clear_exec_info_content): Remove.
3015 2019-08-13 Tom Tromey <tom@tromey.com>
3017 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3019 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3020 call tui_erase_exec_info_content.
3021 (tui_clear_exec_info_content): Rename from
3022 tui_erase_exec_info_content.
3023 (tui_clear_exec_info_content): Delete.
3025 2019-08-13 Tom Tromey <tom@tromey.com>
3027 * tui/tui-winsource.h (struct tui_source_window_base)
3028 <show_exec_info_content>: Declare.
3029 (tui_show_exec_info_content): Don't declare.
3030 * tui/tui-winsource.c
3031 (tui_source_window_base::show_exec_info_content): Rename from
3032 tui_show_exec_info_content.
3033 (tui_source_window_base::update_exec_info): Update.
3035 2019-08-13 Tom Tromey <tom@tromey.com>
3037 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3038 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3039 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3040 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3041 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3042 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3045 2019-08-13 Tom Tromey <tom@tromey.com>
3047 * tui/tui-winsource.h (struct tui_source_window_base)
3048 <update_exec_info>: Declare.
3049 (tui_update_exec_info): Don't declare.
3050 * tui/tui-winsource.c (tui_update_source_window_as_is)
3051 (tui_source_window_base::refresh_all)
3052 (tui_update_all_breakpoint_info): Update.
3053 (tui_source_window_base::update_exec_info): Rename from
3054 tui_update_exec_info.
3055 * tui/tui-stack.c (tui_show_frame_info): Update.
3057 2019-08-13 Tom Tromey <tom@tromey.com>
3059 * tui/tui-winsource.h (struct tui_source_window_base)
3060 <set_exec_info_content>: Declare.
3061 (tui_set_exec_info_content): Don't declare.
3062 * tui/tui-winsource.c
3063 (tui_source_window_base::set_exec_info_content): Rename from
3064 tui_set_exec_info_content.
3065 (tui_update_exec_info): Update.
3067 2019-08-13 Tom Tromey <tom@tromey.com>
3069 * tui/tui-winsource.h (struct tui_source_window_base)
3070 <show_source_content>: Declare.
3071 (tui_show_source_content): Don't declare.
3072 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3073 (tui_source_window_base::show_source_content): Rename from
3074 tui_show_source_content.
3075 (tui_source_window_base::refresh_all): Update.
3076 * tui/tui-layout.c (show_source_disasm_command)
3077 (show_source_or_disasm_and_command): Update.
3079 2019-08-13 Tom Tromey <tom@tromey.com>
3081 * tui/tui-winsource.c (tui_erase_source_content)
3082 (tui_show_source_content, tui_source_window_base::refresh_all):
3084 * tui/tui-wingeneral.h
3085 (tui_check_and_display_highlight_if_needed): Don't declare.
3086 * tui/tui-wingeneral.c
3087 (tui_win_info::check_and_display_highlight_if_needed): Rename from
3088 check_and_display_highlight_if_needed.
3089 * tui/tui-win.c (tui_rehighlight_all)
3090 (tui_win_info::make_visible_with_new_height): Update.
3091 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3092 (tui_data_window::erase_data_content)
3093 (tui_data_window::display_all_data): Update.
3094 * tui/tui-data.h (struct tui_win_info)
3095 <check_and_display_highlight_if_needed>: Declare.
3097 2019-08-13 Tom Tromey <tom@tromey.com>
3099 * tui/tui-win.c (tui_resize_all): Call
3100 tui_delete_invisible_windows.
3101 * tui/tui-layout.c (show_layout): Call
3102 tui_delete_invisible_windows.
3103 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3104 * tui/tui-data.c (tui_delete_invisible_windows): New function.
3106 2019-08-13 Tom Tromey <tom@tromey.com>
3108 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
3109 tui_add_win_to_layout.
3111 2019-08-13 Tom Tromey <tom@tromey.com>
3113 * tui/tui-layout.h (tui_default_win_height): Don't declare.
3114 * tui/tui-layout.c (tui_default_win_height): Now static.
3116 2019-08-13 Tom Tromey <tom@tromey.com>
3118 * tui/tui-layout.c (show_layout): Unify all layout cases into a
3120 (show_source_disasm_command, show_source_or_disasm_and_command):
3121 Don't check current layout.
3123 2019-08-13 Tom Tromey <tom@tromey.com>
3125 * tui/tui-wingeneral.c (make_all_visible): Remove.
3126 (tui_make_all_invisible): Simplify.
3127 * tui/tui-layout.c (tui_make_all_invisible): Move from
3128 tui-wingeneral.c; simplify.
3129 (show_layout): Hoist call to tui_make_all_invisible.
3130 (show_data): Don't call tui_make_all_invisible.
3132 2019-08-13 Tom Tromey <tom@tromey.com>
3134 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3135 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3137 2019-08-13 Tom Tromey <tom@tromey.com>
3139 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3141 (show_source_disasm_command, show_data)
3142 (show_source_or_disasm_and_command): Don't use
3143 tui_set_current_layout_to.
3144 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3145 * tui/tui-data.c (current_layout, tui_current_layout): Move to
3147 (tui_set_current_layout_to): Remove.
3149 2019-08-13 Tom Tromey <tom@tromey.com>
3151 * tui/tui-layout.c (tui_set_layout): Update.
3152 * tui/tui-data.h (struct tui_layout_def): Remove.
3153 (tui_layout_def): Don't declare.
3154 * tui/tui-data.c (layout_def): Remove.
3155 (tui_layout_def): Remove.
3157 2019-08-13 Tom Tromey <tom@tromey.com>
3159 * tui/tui-winsource.h (struct tui_source_window_base)
3160 <clear_detail>: No longer "override".
3161 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3162 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3163 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3164 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3166 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3168 2019-08-13 Tom Tromey <tromey@adacore.com>
3170 * tracepoint.c: Don't include readline.h or history.h.
3172 2019-08-12 Tom Tromey <tom@tromey.com>
3174 * configure: Rebuild.
3175 * configure.ac: Check for readline 7.
3176 * NEWS: Mention readline 7 requirement.
3179 2019-08-12 Tom Tromey <tom@tromey.com>
3181 * mingw-hdep.c (gdb_select): Remove readline hack.
3183 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
3185 * blockframe.c (find_pc_partial_function): Set *block to nullptr
3186 when the function fails.
3188 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
3190 * s390-tdep.c (s390_type_align): New function.
3191 (s390_gdbarch_init): Set it as type_align gdbarch method.
3193 2019-08-09 Tom de Vries <tdevries@suse.de>
3196 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3197 pc_low with relocation offset.
3199 2019-08-07 Tom Tromey <tromey@adacore.com>
3201 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3202 (print_frame_args): Update.
3203 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3205 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3206 * frame.h (struct frame_arg): Add initializers.
3207 <error>: Now a unique_xmalloc_ptr.
3209 2019-08-07 Alan Hayward <alan.hayward@arm.com>
3211 * NEWS: Expand the Pointer Authentication entry.
3212 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3213 (aarch64_frame_unmask_lr): ... to this.
3214 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3215 Call aarch64_frame_unmask_lr.
3216 * frame.c (struct frame_info): Add "masked" variable.
3217 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3218 (fprint_frame): Check for masked pc.
3219 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3221 * python/py-framefilter.c (py_print_frame): Check for masked pc.
3222 * stack.c (print_frame): Check for masked pc.
3224 2019-08-06 Tom Tromey <tom@tromey.com>
3226 * stabsread.c (patch_block_stabs, read_one_struct_field)
3227 (read_enum_type): Use obstack_strndup.
3228 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3229 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3230 * dwarf2read.c (guess_full_die_structure_name)
3231 (anonymous_struct_prefix): Use obstack_strndup.
3232 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3233 * c-exp.y (yylex): Use obstack_strndup.
3234 * ada-exp.y (write_object_renaming, write_ambiguous_var)
3235 (write_var_or_type): Use obstack_strndup.
3237 2019-08-06 Tom Tromey <tom@tromey.com>
3239 * symfile.c (reread_symbols): Use obstack_strdup.
3240 * stabsread.c (read_type): Use obstack_strdup.
3241 * gdb_obstack.h (obstack_strdup): New overload.
3242 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3243 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3244 (dwarf2_canonicalize_name): Use obstack_strdup.
3245 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3246 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3249 2019-08-06 Tom Tromey <tom@tromey.com>
3251 * gdb_obstack.h (obstack_strdup): Define.
3252 * gdb_obstack.c (obstack_strdup): Don't define.
3254 2019-08-06 Tom Tromey <tom@tromey.com>
3256 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3258 * typeprint.c (typedef_hash_table::find_global_typedef): Use
3260 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3261 * stabsread.c (common_block_start): Use obstack_strdup.
3262 * objfiles.c (set_objfile_main_name, objfile): Use
3264 * namespace.c (add_using_directive): Use obstack_strdup.
3265 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3266 * jit.c (finalize_symtab): Use obstack_strdup.
3267 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3268 (guess_partial_die_structure_name, partial_die_info::fixup)
3269 (dwarf2_name): Use obstack_strdup.
3270 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3272 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3273 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3275 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3277 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3279 * unittests/help-doc-selftests.c: New file.
3280 * Makefile.in: Add the new file.
3282 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3284 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3285 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
3286 the full first line, except when FOR_VALUE_PREFIX. In this case,
3287 the trailing '.' is not output, and the first character is uppercased.
3288 (print_help_for_command): Update call to print_doc_line.
3289 (print_doc_of_command): Likewise.
3290 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3291 * cli/cli-option.c (append_indented_doc): Do not append newline.
3292 (build_help_option): Append newline after first appended_indented_doc
3293 only if a second call is done.
3294 (build_help): Append 2 new lines before each option, except the first
3296 * compile/compile.c (_initialize_compile): Add new lines after
3297 %OPTIONS%, when not at the end of the help.
3298 Change help doc or code
3299 producing the help doc to respect the invariants.
3300 * maint-test-options.c (_initialize_maint_test_options): Likewise.
3301 Also removed the new line after 'Options:', as all other commands
3302 do not put an empty line between 'Options:' and the first option.
3303 * printcmd.c (_initialize_printcmd): Likewise.
3304 * stack.c (_initialize_stack): Likewise.
3305 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3306 incorrectly telling COMMAND is optional.
3307 * ada-lang.c (_initialize_ada_language): Change help doc or code
3308 producing the help doc to respect the invariants.
3309 * ada-tasks.c (_initialize_ada_tasks): Likewise.
3310 * breakpoint.c (_initialize_breakpoint): Likewise.
3311 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3312 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3313 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3314 * cli/cli-style.c (cli_style_option::add_setshow_commands,
3315 _initialize_cli_style): Likewise.
3316 * corelow.c (core_target_info): Likewise.
3317 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3318 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3319 * filesystem.c (_initialize_filesystem): Likewise.
3320 * frame.c (_initialize_frame): Likewise.
3321 * gnu-nat.c (add_task_commands): Likewise.
3322 * infcall.c (_initialize_infcall): Likewise.
3323 * infcmd.c (_initialize_infcmd): Likewise.
3324 * interps.c (_initialize_interpreter): Likewise.
3325 * language.c (_initialize_language): Likewise.
3326 * linux-fork.c (_initialize_linux_fork): Likewise.
3327 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3328 * maint.c (_initialize_maint_cmds): Likewise.
3329 * memattr.c (_initialize_mem): Likewise.
3330 * printcmd.c (_initialize_printcmd): Likewise.
3331 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3333 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3334 * record-btrace.c (_initialize_record_btrace): Likewise.
3335 * record-full.c (_initialize_record_full): Likewise.
3336 * record.c (_initialize_record): Likewise.
3337 * regcache-dump.c (_initialize_regcache_dump): Likewise.
3338 * regcache.c (_initialize_regcache): Likewise.
3339 * remote.c (add_packet_config_cmd, init_remote_threadtests,
3340 _initialize_remote): Likewise.
3341 * ser-tcp.c (_initialize_ser_tcp): Likewise.
3342 * serial.c (_initialize_serial): Likewise.
3343 * skip.c (_initialize_step_skip): Likewise.
3344 * source.c (_initialize_source): Likewise.
3345 * stack.c (_initialize_stack): Likewise.
3346 * symfile.c (_initialize_symfile): Likewise.
3347 * symtab.c (_initialize_symtab): Likewise.
3348 * target-descriptions.c (_initialize_target_descriptions): Likewise.
3349 * top.c (init_main): Likewise.
3350 * tracefile-tfile.c (tfile_target_info): Likewise.
3351 * tracepoint.c (_initialize_tracepoint): Likewise.
3352 * tui/tui-win.c (_initialize_tui_win): Likewise.
3353 * utils.c (add_internal_problem_command): Likewise.
3354 * valprint.c (value_print_option_defs): Likewise.
3356 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
3359 * configure.ac: Drop enable-libmcheck support.
3360 * configure, config.in: Rebuild.
3361 * libmcheck.m4: Remove.
3362 * acinclude.m4: Don't include it.
3363 * Makefile.in: Don't distribute it.
3364 * top.c (print_gdb_configuration): Don't mention it.
3366 2019-08-06 Tom Tromey <tom@tromey.com>
3368 * utils.c (set_output_style): Sometimes pass stream to
3370 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3371 * record-btrace.c (btrace_insn_history): Update.
3372 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3374 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3375 Update initializers.
3376 <m_uiout>: New field.
3378 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3379 Remove "uiout" parameter.
3380 (dump_insns): Update.
3381 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3382 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3384 2019-08-06 Christian Biesinger <cbiesinger@google.com>
3386 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3387 (error_in_psymtab_expansion): Likewise.
3388 (lookup_symbol_via_quick_fns): Likewise.
3389 (basic_lookup_transparent_type_quick): Likewise.
3390 (basic_lookup_transparent_type_1): Likewise.
3392 2019-08-06 Tom Tromey <tromey@adacore.com>
3394 * source.c (last_source_error): Now bool.
3395 (print_source_lines_base): Make "noprint" bool. Only open
3396 source file when last_source_visited changes.
3398 2019-08-06 Tom Tromey <tromey@adacore.com>
3400 * annotate.c (annotate_source_line): Use g_source_cache.
3401 * source-cache.c (source_cache::get_plain_source_lines): Change
3402 parameters. Populate m_offset_cache.
3403 (source_cache::ensure): New method.
3404 (source_cache::get_line_charpos): New method.
3405 (extract_lines): Move lower. Change parameters.
3406 (source_cache::get_source_lines): Move lower.
3407 * source-cache.h (class source_cache): Update comment.
3408 <get_line_charpos>: New method.
3409 <get_source_lines>: Update comment.
3410 <clear>: Clear m_offset_cache.
3411 <get_plain_source_lines>: Change parameters.
3412 <ensure>: New method
3413 <m_offset_cache>: New member.
3414 * source.c (forget_cached_source_info_for_objfile): Update.
3415 (info_source_command): Use g_source_cache.
3416 (find_source_lines, open_source_file_with_line_charpos): Remove.
3417 (print_source_lines_base, search_command_helper): Use g_source_cache.
3418 * source.h (open_source_file_with_line_charpos): Don't declare.
3419 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3420 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3423 2019-08-06 Tom Tromey <tromey@adacore.com>
3425 * source-cache.c (source_cache::get_plain_source_lines):
3426 Remove "first_line" and "last_line" parameters.
3427 (source_cache::get_source_lines): Cache plain text.
3428 * source-cache.h (class source_cache)
3429 <get_plain_source_lines>: Update.
3431 2019-08-06 Tom Tromey <tromey@adacore.com>
3433 * source-cache.c (extract_lines): No longer a method.
3434 Changed type of parameter. Include final newline.
3435 (selftests::extract_lines_test): New function.
3436 (_initialize_source_cache): Likewise.
3437 * source-cache.h (class source_cache)
3438 <extract_lines>: Don't declare.
3440 2019-08-06 Tom Tromey <tromey@adacore.com>
3442 * breakpoint.c (init_breakpoint_sal): Update.
3443 (breakpoint): Update.
3444 * breakpoint.h (struct breakpoint) <filter>: Now a
3447 2019-08-05 Christian Biesinger <cbiesinger@google.com>
3449 * NEWS: Mention dictionary access on blocks.
3450 * python/py-block.c (blpy_getitem): New function.
3451 (block_object_as_mapping): New struct.
3452 (block_object_type): Use new struct for tp_as_mapping field.
3454 2019-08-05 Christian Biesinger <cbiesinger@google.com>
3456 * objfiles.h (objfile): Add a comment describing partial symbols.
3458 2019-08-05 Tom Tromey <tromey@adacore.com>
3460 * compile/compile.c (_initialize_compile): Use _(), not N_().
3461 * thread.c (_initialize_thread): Use _(), not N_().
3462 * stack.c (_initialize_stack): Use _(), not N_().
3463 * printcmd.c (_initialize_printcmd): Use _(), not N_().
3465 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
3467 * dwarf2read.c (struct dw2_symtab_iterator):
3468 <want_specific_block>: Remove.
3469 <block_index>: Change type to gdb::optional.
3470 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3471 change type of BLOCK_INDEX parameter to gdb::optional.
3472 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3473 (dw2_lookup_symbol): Don't pass argument for
3474 WANT_SPECIFIC_BLOCK.
3475 (dw2_expand_symtabs_for_function): Don't pass argument for
3476 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3477 (class dw2_debug_names_iterator)
3478 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3479 parameter, change BLOCK_INDEX type to gdb::optional.
3480 <m_want_specific_block>: Remove.
3481 <m_block_index>: Change type to gdb::optional.
3482 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3483 gdb::optional. Re-write in function of gdb::optional.
3484 (dw2_debug_names_lookup_symbol): Don't pass argument for
3485 WANT_SPECIFIC_BLOCK.
3486 (dw2_debug_names_expand_symtabs_for_function): Don't pass
3487 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3490 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3492 * NEWS: Mention changes to "info sources" command.
3494 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3496 * symtab.c (filename_partial_match_opts): New struct type.
3497 (struct output_source_filename_data): New members
3498 regexp, c_regexp, partial_match.
3499 (output_source_filename): Use new members to decide to print file.
3500 (info_sources_option_defs): New variable.
3501 (make_info_sources_options_def_group, print_info_sources_header,
3502 info_sources_command_completer):
3504 (info_sources_command): Read new optional arguments.
3505 (_initialize_symtab): Update info sources help.
3507 2019-08-02 Alexandre Oliva <oliva@adacore.com>
3509 * ada-lang.c (exception_support_info_v0): Renamed from...
3510 (default_exception_support_info): ... this. Create new
3512 (ada_has_this_exception_support): Look up catch_handlers_sym.
3513 (ada_exception_support_info_sniffer): Try v0 after default.
3515 2019-08-01 Tom Tromey <tromey@adacore.com>
3517 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3520 2019-08-01 Christian Biesinger <cbiesinger@google.com>
3522 * s12z-tdep.c: Fix include path for s12z-opc.h.
3524 2019-08-01 Alan Hayward <alan.hayward@arm.com>
3526 * NEWS: Require GNU make 3.82.
3528 2019-07-16 Tom Tromey <tom@tromey.com>
3530 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3533 2019-07-30 Tom Tromey <tromey@adacore.com>
3535 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3537 2019-07-30 Kevin Buettner <kevinb@redhat.com>
3539 * printcmd.c (print_address_symbolic): Print negative offsets.
3540 (build_address_symbolic): Force signed arithmetic when computing
3543 2019-07-30 Christian Biesinger <cbiesinger@google.com>
3545 PR/24474: Add a function to lookup static variables.
3546 * NEWS: Mention this new function.
3547 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3548 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3549 * python/python.c (python_GdbMethods): Add new function.
3551 2019-07-29 Christian Biesinger <cbiesinger@google.com>
3553 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3554 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3555 (objfpy_lookup_static_symbol): New function.
3556 (objfile_object_methods): Add new functions.
3558 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3560 * NEWS: Mention 'set|show print frame-info'. Mention new
3561 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3562 backtrace argument. Mention that python frame filtering code
3563 is now consistent with what 'backtrace' command prints.
3565 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3567 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3569 (print_frame_info_auto, print_frame_info_source_line,
3570 print_frame_info_location, print_frame_info_source_and_location,
3571 print_frame_info_location_and_address, print_frame_info_short_location):
3573 (struct frame_print_options): New member print_frame_info.
3574 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3575 * stack.h (get_user_print_what_frame_info): New declaration.
3576 (frame_show_address): New declaration.
3577 * stack.c (print_frame_arguments_choices): New value 'presence'.
3578 (print_frame_info_auto, print_frame_info_source_line,
3579 print_frame_info_location, print_frame_info_source_and_location,
3580 print_frame_info_location_and_address, print_frame_info_short_location,
3581 print_frame_info_choices, print_frame_info_print_what): New definitions.
3582 (print_frame_args): Only print dots for args if print frame-arguments
3584 (frame_print_option_defs): New element for "frame-info".
3585 (get_user_print_what_frame_info): New function.
3586 (frame_show_address): Make non static. Move comment to stack.h.
3587 (print_frame_info_to_print_what): New function.
3588 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3589 to decide what to print.
3590 (backtrace_command_1): Handle the new print_frame_arguments_presence
3592 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3593 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3594 (py_print_frame): In non-mi mode, use LOCATION as default for
3595 print_what, similarly to frame information printed directly by
3596 backtrace command. Handle frame-info user option in non MI mode.
3598 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3600 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3601 Add case for debugging 32-bit target on 64-bit host. Revise
3604 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3606 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3607 instead of find_function_entry_range_from_pc.
3609 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3611 * stack.c (find_frame_funname): Remove code which preferred
3612 minsym over symtab sym in "certain pathological cases".
3614 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3615 parameter. Change type of "do_demangle" to bool.
3616 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3617 Pass suitable "prefer_sym_over_minsym" flag to
3618 build_address_symbolic(). Don't output "+" for negative offsets.
3619 * printcmd.c (print_address_symbolic): Update invocation of
3620 build_address_symbolic to include a "prefer_sym_over_minsym"
3622 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3623 Restrict cases in which use of minimal symbol is preferred to that
3624 of a found symbol. Update comments.
3626 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3627 for entry pc when entry pc is out of range for that FDE.
3629 2019-07-26 Brian Callahan <bcallah@openbsd.org>
3632 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3635 2019-07-25 Christian Biesinger <cbiesinger@google.com>
3637 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3638 this function's Python signature.
3641 2019-07-24 Christian Biesinger <cbiesinger@google.com>
3643 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3644 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3645 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3646 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3647 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3650 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3652 * h8300-tdep.c (h8300_register_name_common): New.
3653 h8300_register_name): Use h8300_register_name_common.
3654 (h8300s_register_name): Likewise.
3655 (h8300sx_register_name): Likewise.
3656 (h8300h_register_nam): New.
3657 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3660 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3662 * arm-tdep.c (arm_skip_cmse_entry): New function.
3663 (arm_is_sgstubs_section): New function.
3664 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3666 2019-07-22 Tom Tromey <tom@tromey.com>
3668 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3671 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3673 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3676 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3678 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3679 so that GDB doesn't match any msymbols when searching in the
3681 (print_symbol_info): Print using typedef_print or type_print based
3682 on the type of the symbol. Add updated FIXME comment moved from...
3683 (_initialize_symtab): ... move and update FIXME comment to above.
3685 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3687 * NEWS: Mention adding -q option to "info types".
3688 * symtab.c (struct info_types_options): New struct.
3689 (info_types_options_defs): New variable.
3690 (make_info_types_options_def_group): New function.
3691 (info_types_command): Use gdb::option framework to parse options.
3692 (info_types_command_completer): New function.
3693 (_initialize_symtab): Extend the help text on "info types" and
3694 register command completer.
3696 2019-07-21 Christian Biesinger <cbiesinger@google.com>
3698 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3699 (lookup_symbol_in_objfile): Change int to block_enum and add a
3700 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3702 2019-07-20 Christian Biesinger <cbiesinger@google.com>
3704 * MAINTAINERS (Write After Approval): Add self.
3706 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3708 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3709 instruction to the dummy code region.
3711 2019-07-19 Tom Tromey <tromey@adacore.com>
3713 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3714 (ARGSUSED, PARAMS, __func__): Remove rules.
3716 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3718 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3719 * features/arm/arm-with-iwmmxt.c: Remove.
3720 * features/arm/arm-with-iwmmxt.xml: Remove.
3721 * features/arm/arm-with-m-fpa-layout.c: Remove.
3722 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3723 * features/arm/arm-with-m-vfp-d16.c: Remove.
3724 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3725 * features/arm/arm-with-m.c: Remove.
3726 * features/arm/arm-with-m.xml: Remove.
3727 * features/arm/arm-with-neon.c: Remove.
3728 * features/arm/arm-with-neon.xml: Remove.
3729 * features/arm/arm-with-vfpv2.c: Remove.
3730 * features/arm/arm-with-vfpv2.xml: Remove.
3731 * features/arm/arm-with-vfpv3.c: Remove.
3732 * features/arm/arm-with-vfpv3.xml: Remove.
3734 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3736 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3738 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3740 * arch/aarch32.c (aarch32_create_target_description): Create
3741 target descriptions using features.
3742 * arch/arm.c (arm_create_target_description)
3743 (arm_create_mprofile_target_description): Likewise.
3744 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3746 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3748 * Makefile.in: Add new files.
3749 * aarch32-tdep.c: New file.
3750 * aarch32-tdep.h: New file.
3751 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3752 Call aarch32_read_description.
3753 * arch/aarch32.c: New file.
3754 * arch/aarch32.h: New file.
3755 * arch/arm.c (arm_create_target_description)
3756 (arm_create_mprofile_target_description): New function.
3757 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3758 (arm_create_target_description)
3759 (arm_create_mprofile_target_description): New declaration.
3760 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3761 read_description functions.
3762 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3764 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3765 * arm-tdep.c (tdesc_arm_list): New variable.
3766 (arm_register_g_packet_guesses): Call create description functions.
3767 (arm_read_description) (arm_read_mprofile_description): New
3769 * arm-tdep.h (arm_read_description)
3770 (arm_read_mprofile_description): Add declaration.
3771 * configure.tgt: Add new files.
3773 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3775 * top.c (new_ui_command): Open specified terminal just once.
3777 2019-07-18 Tom Tromey <tromey@adacore.com>
3779 * symtab.c (main_name): Constify return type.
3780 * symfile.c (set_initial_language): Update.
3781 * symtab.h (main_name): Constify return type.
3783 2019-07-17 Tom Tromey <tom@tromey.com>
3785 * tui/tui-winsource.c (tui_update_source_window)
3786 (tui_update_source_window_as_is)
3787 (tui_update_source_windows_with_line): Remove return.
3788 * tui/tui-disasm.c (tui_show_disassem)
3789 (tui_show_disassem_and_update_source): Remove return.
3790 * tui/tui.c (tui_reset): Remove return.
3791 * tui/tui-wingeneral.c
3792 (tui_check_and_display_highlight_if_needed): Remove return.
3794 2019-07-17 Tom Tromey <tom@tromey.com>
3796 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3798 2019-07-17 Tom Tromey <tom@tromey.com>
3800 * tui/tui-winsource.h (struct tui_exec_info_window)
3801 (struct tui_source_window_base): Move from tui-data.h.
3802 * tui/tui-winsource.c: Move many method definitions from
3803 elsewhere. Remove "structuring" comments.
3804 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3805 (tui_source_window_base::refresh_window): Move to
3807 * tui/tui-win.c (tui_source_window_base::refresh_all)
3808 (tui_source_window_base::update_tab_width)
3809 (tui_source_window_base::set_new_height)
3810 (tui_source_window_base::do_make_visible_with_new_height): Move to
3812 * tui/tui-source.h: Update.
3813 * tui/tui-source.c (tui_source_window_base::reset): Move to
3815 * tui/tui-disasm.h: Update.
3816 * tui/tui-data.h (struct tui_exec_info_window): Move to
3818 (struct tui_source_window_base): Likewise.
3819 * tui/tui-data.c (tui_source_window_base::clear_detail)
3820 (tui_source_window_base, ~tui_source_window_base): Move to
3823 2019-07-17 Tom Tromey <tom@tromey.com>
3825 * tui/tui-win.c (tui_resize_all)
3826 (tui_source_window_base::update_tab_width)
3827 (tui_adjust_win_heights): Update.
3828 (tui_win_info::make_invisible_and_set_new_height): Rename from
3829 make_invisible_and_set_new_height.
3830 * tui/tui-data.h (struct tui_win_info)
3831 <make_invisible_and_set_new_height>: New method.
3833 2019-07-17 Tom Tromey <tom@tromey.com>
3835 * tui/tui.c: Update.
3836 * tui/tui-source.h (struct tui_source_window): Move from
3838 * tui/tui-layout.c: Update.
3839 * tui/tui-disasm.c: Update.
3840 * tui/tui-data.h (struct tui_source_window): Move to
3843 2019-07-17 Tom Tromey <tom@tromey.com>
3845 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3847 * tui/tui-data.h (struct tui_disasm_window): Move to
3850 2019-07-17 Tom Tromey <tom@tromey.com>
3852 * tui/tui-regs.h (struct tui_data_item_window): Move from
3854 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3855 * tui/tui-data.h (struct tui_data_item_window): Move to
3857 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3859 2019-07-17 Tom Tromey <tom@tromey.com>
3861 * tui/tui.c: Update.
3862 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3863 (tui_cmd_window::max_height): Move to tui-command.c.
3864 * tui/tui-layout.c: Update.
3865 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3866 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3868 * tui/tui-command.h (struct tui_cmd_window): Move from
3870 * tui/tui-command.c: Remove "structuring" comments.
3871 (tui_cmd_window::clear_detail)
3872 (tui_cmd_window::do_make_visible_with_new_height)
3873 (tui_cmd_window::max_height): Move from elsewhere.
3875 2019-07-17 Tom Tromey <tom@tromey.com>
3877 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3879 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3880 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3882 2019-07-17 Tom Tromey <tom@tromey.com>
3884 * tui/tui.c: Update.
3885 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3887 * tui/tui-windata.h: Remove file.
3888 * tui/tui-windata.c: Remove file.
3889 * tui/tui-win.c (tui_data_window::set_new_height)
3890 (tui_data_window::do_make_visible_with_new_height): Move to
3892 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3893 * tui/tui-regs.c: Remove "structuring" comments.
3894 (tui_data_window::first_data_item_displayed)
3895 (tui_data_window::delete_data_content_windows)
3896 (tui_data_window::erase_data_content)
3897 (tui_data_window::display_all_data)
3898 (tui_data_window::refresh_all)
3899 (tui_data_window::do_scroll_vertical)
3900 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3901 (tui_data_window::do_make_visible_with_new_height)
3902 (tui_data_window::refresh_window): Move from elsewhere.
3903 (_initialize_tui_regs): Move to end of file.
3904 * tui/tui-layout.c: Update.
3905 * tui/tui-hooks.c: Update.
3906 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3907 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3909 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3911 2019-07-17 Tom Tromey <tom@tromey.com>
3913 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3916 2019-07-17 Tom Tromey <tom@tromey.com>
3918 * tui/tui-win.c (tui_source_window_base::set_new_height)
3919 (tui_source_window_base::do_make_visible_with_new_height): Use
3920 m_has_locator field directly.
3921 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3923 (struct tui_source_window_base) <has_locator>: Likewise.
3925 2019-07-17 Tom Tromey <tom@tromey.com>
3927 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3929 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3931 * tui/tui-win.c (tui_source_window_base::set_new_height)
3932 (tui_source_window_base::set_new_height)
3933 (make_invisible_and_set_new_height)
3934 (tui_source_window_base::do_make_visible_with_new_height)
3935 (tui_source_window_base::do_make_visible_with_new_height):
3937 * tui/tui-layout.c (show_source_disasm_command, show_data)
3938 (show_source_or_disasm_and_command): Update.
3939 * tui/tui-layout.c (show_layout): Update.
3941 2019-07-17 Tom Tromey <tom@tromey.com>
3943 * tui/tui-layout.c (make_data_window): Remove.
3944 (show_data): Unify creation and re-initialization cases.
3946 2019-07-17 Tom Tromey <tom@tromey.com>
3948 * tui/tui-layout.c (make_source_window, make_disasm_window):
3950 (show_data): Unify creation and re-initialization cases.
3952 2019-07-17 Tom Tromey <tom@tromey.com>
3954 * tui/tui-layout.c (make_command_window): Remove.
3955 (show_source_disasm_command, show_source_or_disasm_and_command):
3956 Unify creation and re-initialization cases.
3958 2019-07-17 Tom Tromey <tom@tromey.com>
3960 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3961 creation and re-initialization cases.
3963 2019-07-17 Tom Tromey <tom@tromey.com>
3965 * tui/tui-regs.c (tui_get_register): Return void.
3967 2019-07-17 Tom Tromey <tom@tromey.com>
3969 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3972 2019-07-17 Tom Tromey <tom@tromey.com>
3974 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3977 2019-07-17 Tom Tromey <tom@tromey.com>
3979 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3980 * tui/tui-regs.c (tui_reg_layout): New function.
3981 (tui_show_registers, tui_reg_command): Use it.
3982 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3983 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3985 (tui_layout_command): Remove.
3987 2019-07-17 Tom Tromey <tom@tromey.com>
3989 * tui/tui-layout.h (tui/tui-layout): Return void.
3990 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3992 2019-07-17 Tom Tromey <tom@tromey.com>
3994 * tui/tui-layout.c (show_source_disasm_command, show_data):
3996 (reset_locator): Remove.
3997 (show_source_or_disasm_and_command): Update.
3999 2019-07-17 Tom Tromey <tom@tromey.com>
4001 * tui/tui-source.c (tui_source_window_base::reset): Remove
4003 * tui/tui-layout.c (make_command_window, make_source_window)
4004 (make_disasm_window, make_data_window)
4005 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4006 (reset_locator, show_source_or_disasm_and_command): Update.
4007 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4009 (struct tui_source_window_base) <reset>: Likewise.
4011 2019-07-17 Tom Tromey <tom@tromey.com>
4013 * tui/tui-layout.c (show_source_disasm_command): Use
4015 (reset_locator): New function.
4016 (init_and_make_win): Remove.
4017 (show_source_or_disasm_and_command): Use reset_locator.
4019 2019-07-17 Tom Tromey <tom@tromey.com>
4021 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4023 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4025 * tui/tui-source.c (tui_source_window_base::reset): New method.
4026 * tui/tui-layout.c (make_command_window): Don't call
4028 (make_source_window, make_disasm_window): Don't call
4029 make_source_or_disasm_window.
4030 (make_data_window): Don't call init_and_make_win. Change calling
4032 (show_source_disasm_command, show_data): Simplify.
4033 (make_source_or_disasm_window): Remove.
4034 (show_source_or_disasm_and_command): Simplify.
4035 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4036 (struct tui_source_window_base) <reset>: Likewise.
4037 <execution_info>: Remove initializer.
4038 * tui/tui-data.c (tui_source_window_base): Initialize
4041 2019-07-17 Tom Tromey <tom@tromey.com>
4043 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4046 2019-07-17 Tom Tromey <tom@tromey.com>
4048 * tui/tui.c (tui_rl_other_window): Update.
4049 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4050 superclass method first. Always iterate over regs_content.
4051 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4053 * tui/tui-win.c (tui_set_focus_command): Update.
4055 2019-07-17 Tom Tromey <tom@tromey.com>
4057 * tui/tui-win.c (tui_set_focus_command): Rename from
4058 tui_set_focus. Call tui_enable.
4059 (tui_set_focus_command): Remove.
4061 2019-07-17 Tom Tromey <tom@tromey.com>
4063 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4065 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4067 (tui_data_window::refresh_window): Call refresh_window on data
4068 items. Always call superclass refresh_window.
4069 (tui_win_info::refresh): Remove.
4070 (tui_source_window_base::refresh_window): Update.
4071 (tui_refresh_all): Update.
4072 * tui/tui-layout.c (show_source_disasm_command): Remove call to
4074 (show_source_or_disasm_and_command): Likewise.
4075 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4076 (struct tui_source_window_base) <refresh>: Likewise.
4078 2019-07-17 Tom Tromey <tom@tromey.com>
4080 * tui/tui-winsource.c (tui_clear_source_content)
4081 (tui_show_source_content): Update.
4082 * tui/tui-source.c (tui_source_window::showing_source_p): Check
4083 whether content is empty.
4084 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4087 2019-07-17 Tom Tromey <tom@tromey.com>
4089 * tui/tui-winsource.c (tui_erase_source_content): Clear the
4091 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4092 * tui/tui-source.c (tui_set_source_content_nil): Remove.
4094 2019-07-17 Tom Tromey <tom@tromey.com>
4096 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4097 (struct tui_data_item_window): Update.
4099 2019-07-17 Tom Tromey <tom@tromey.com>
4101 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4102 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4105 2019-07-17 Tom Tromey <tom@tromey.com>
4107 * tui/tui-winsource.h (tui_erase_source_content)
4108 (tui_clear_source_content): Remove "display_prompt" parameter.
4109 * tui/tui-winsource.c (tui_update_source_window_as_is)
4110 (tui_update_source_windows_with_addr): Update.
4111 (tui_clear_source_content): Remove "display_prompt" parameter.
4112 (tui_erase_source_content): Likewise. Simplify.
4113 (tui_show_source_content): Update.
4114 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4115 * tui/tui-stack.c (tui_show_frame_info): Update.
4116 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4119 2019-07-17 Tom Tromey <tom@tromey.com>
4121 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4122 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4124 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4127 2019-07-17 Tom Tromey <tom@tromey.com>
4129 * tui/tui-winsource.c (tui_clear_source_content)
4130 (tui_show_source_content, tui_show_exec_info_content)
4131 (tui_clear_exec_info_content): Update.
4132 * tui/tui-stack.c (tui_show_locator_content): Update.
4133 (tui_show_frame_info): Update.
4134 * tui/tui-source.h (tui_source_window): Don't declare.
4135 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4136 from tui_source_is_displayed.
4137 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4139 (struct tui_source_window_base) <content_in_use>: New field. Now
4141 (struct tui_source_window) <showing_source_p>: New method.
4142 (TUI_SRC_WIN): Change cast.
4143 * tui/tui-data.c (tui_initialize_static_data): Update.
4145 2019-07-17 Tom Tromey <tom@tromey.com>
4147 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4149 * tui/tui-source.c (tui_source_window::location_matches_p): New
4151 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4153 * tui/tui-data.h (struct tui_source_window_base)
4154 <location_matches_p>: New method.
4155 (struct tui_source_window, struct tui_disasm_window)
4156 <location_matches_p>: Likewise.
4158 2019-07-17 Tom Tromey <tom@tromey.com>
4160 * tui/tui-win.c (tui_set_win_height_command): Rename from
4162 (tui_set_win_height_command): Remove.
4164 2019-07-17 Tom Tromey <tom@tromey.com>
4166 * tui/tui-source.c (tui_source_window): New constructor. Add
4168 (~tui_source_window): New destructor.
4169 (tui_source_window::style_changed): New method.
4170 * tui/tui-hooks.c (tui_redisplay_source): Remove.
4171 (tui_attach_detach_observers): Update.
4172 * tui/tui-data.h (struct tui_source_window): Make constructor not
4173 inline. Add destructor.
4174 (struct tui_source_window) <style_changed>: New method.
4175 <m_observable>: New member.
4177 2019-07-17 Tom Tromey <tom@tromey.com>
4179 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4180 * tui/tui-win.c (tui_resize_all): Fix typo.
4182 2019-07-17 Tom Tromey <tom@tromey.com>
4184 * tui/tui-wingeneral.h (tui_refresh_all): Update.
4185 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4186 (tui_refresh_all): Remove "list" parameter. Use foreach.
4187 * tui/tui-win.c (window_name_completer): Use foreach.
4188 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4189 (update_tab_width): Likewise.
4190 * tui/tui-layout.c (show_layout): Update.
4191 * tui/tui-data.h (class tui_window_iterator): New.
4192 (struct all_tui_windows): New.
4193 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4195 2019-07-17 Tom Tromey <tom@tromey.com>
4197 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4198 parameter. Don't reference globals.
4199 (tui_reg_command): Update.
4201 2019-07-17 Tom Tromey <tom@tromey.com>
4203 * tui/tui-regs.c (tui_show_registers): Simplify.
4205 2019-07-17 Tom Tromey <tom@tromey.com>
4207 * tui/tui-regs.c (tui_show_registers): Update.
4208 (tui_show_register_group): Add win_info parameter.
4210 2019-07-17 Tom Tromey <tom@tromey.com>
4212 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4213 Rename from tui_display_reg_element_at_line.
4214 (tui_data_window::display_registers_from_line): Update.
4215 * tui/tui-data.h (struct tui_data_window)
4216 <display_reg_element_at_line>: New method.
4218 2019-07-17 Tom Tromey <tom@tromey.com>
4220 * tui/tui-regs.h (tui_display_registers_from)
4221 (tui_display_registers_from_line): Don't declare.
4222 * tui/tui-windata.c (tui_data_window::display_all_data)
4223 (tui_data_window::refresh_all)
4224 (tui_data_window::do_scroll_vertical): Update.
4225 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4226 from tui_display_registers_from.
4227 (tui_display_reg_element_at_line): Update.
4228 (tui_data_window::display_registers_from_line): Rename from
4229 tui_display_registers_from_line.
4230 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4231 display_registers_from_line>: New methods.
4233 2019-07-17 Tom Tromey <tom@tromey.com>
4235 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4236 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4237 from tui_erase_data_content.
4238 (tui_data_window::display_all_data)
4239 (tui_data_window::refresh_all)
4240 (tui_data_window::do_scroll_vertical): Update.
4241 * tui/tui-regs.c (tui_show_registers): Update.
4242 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4245 2019-07-17 Tom Tromey <tom@tromey.com>
4247 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4250 (tui_data_window::delete_data_content_windows): Rename from
4251 tui_delete_data_content_windows.
4252 (tui_data_window::display_all_data)
4253 (tui_data_window::do_scroll_vertical): Update.
4254 * tui/tui-data.h (struct tui_data_window)
4255 <delete_data_content_windows>: New method.
4257 2019-07-17 Tom Tromey <tom@tromey.com>
4259 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4260 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4262 2019-07-17 Tom Tromey <tom@tromey.com>
4264 * tui/tui-windata.h (tui_display_all_data): Don't declare.
4265 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4266 from tui_display_all_data.
4268 (tui_data_window::do_make_visible_with_new_height): Update.
4269 * tui/tui-regs.c (tui_show_registers): Update.
4270 * tui/tui-layout.c (tui_set_layout): Update.
4271 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4274 2019-07-17 Tom Tromey <tom@tromey.com>
4276 * tui/tui-windata.h (tui_display_data_from): Don't declare.
4277 * tui/tui-windata.c (tui_display_data_from): Remove.
4278 (tui_data_window::refresh_all): Update.
4280 2019-07-17 Tom Tromey <tom@tromey.com>
4282 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4283 * tui/tui-windata.c (tui_display_data_from_line): Remove.
4284 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4285 tui_display_registers_from_line.
4286 * tui/tui-regs.h (tui_display_registers_from_line): Update.
4287 * tui/tui-regs.c (tui_display_registers_from_line): Remove
4288 "force_display" parameter.
4290 2019-07-17 Tom Tromey <tom@tromey.com>
4292 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4294 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4295 Rename from tui_first_reg_element_no_inline.
4296 (tui_display_reg_element_at_line)
4297 (tui_display_registers_from_line): Update.
4298 * tui/tui-data.h (struct tui_data_window)
4299 <first_reg_element_no_inline>: New method.
4301 2019-07-17 Tom Tromey <tom@tromey.com>
4303 * tui/tui-windata.c (tui_display_data_from)
4304 (tui_data_window::do_scroll_vertical): Update.
4305 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4306 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4307 Rename from tui_line_from_reg_element_no.
4308 (tui_display_registers_from_line): Update.
4309 * tui/tui-data.h (struct tui_data_window)
4310 <line_from_reg_element_no>: New method.
4312 2019-07-17 Tom Tromey <tom@tromey.com>
4314 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4315 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4316 tui_last_regs_line_no.
4317 (tui_display_reg_element_at_line)
4318 (tui_display_registers_from_line): Update.
4319 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4322 2019-07-17 Tom Tromey <tom@tromey.com>
4325 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4326 (tui_update_breakpoint_info): Add "being_deleted" parameter.
4327 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4328 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4329 (tui_update_breakpoint_info): Likewise.
4330 * tui/tui-hooks.c (tui_event_create_breakpoint)
4331 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4334 2019-07-17 Tom Tromey <tom@tromey.com>
4336 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4338 2019-07-17 Tom Tromey <tom@tromey.com>
4340 * tui/tui-winsource.c (tui_update_source_window_as_is)
4341 (tui_update_source_windows_with_addr): Update.
4342 * tui/tui-source.h (tui_set_source_content)
4343 (tui_show_symtab_source): Add "win_info" parameter.
4344 * tui/tui-source.c (tui_set_source_content): Add "win_info"
4346 (tui_show_symtab_source): Likewise.
4348 2019-07-17 Tom Tromey <tom@tromey.com>
4350 * tui/tui-wingeneral.c
4351 (tui_check_and_display_highlight_if_needed): Check can_highlight.
4353 2019-07-17 Tom Tromey <tom@tromey.com>
4355 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4356 (struct tui_cmd_window) <can_scroll>: New method.
4357 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4360 2019-07-17 Tom Tromey <tromey@adacore.com>
4362 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4363 do_field_signed>: Rename. Change type of "value".
4364 * ui-out.c (ui_out::field_signed): Rename from field_int.
4365 Change type of "value".
4366 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
4368 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4369 do_field_int. Change type of "value".
4370 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4371 do_field_int. Change type of "value".
4372 * tracepoint.c (trace_status_mi, tfind_1)
4373 (print_one_static_tracepoint_marker): Update.
4374 * thread.c (print_thread_info_1, print_selected_thread_frame):
4376 * stack.c (print_frame, print_frame_info): Update.
4377 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4379 * source.c (print_source_lines_base): Update.
4380 * skip.c (info_skip_command): Update.
4381 * record-btrace.c (btrace_ui_out_decode_error)
4382 (btrace_call_history_src_line): Update.
4383 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4385 * progspace.c (print_program_space): Update.
4386 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4387 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4388 do_field_int. Change type of "value".
4389 * mi/mi-out.c (mi_ui_out::do_table_begin)
4390 (mi_ui_out::do_table_header): Update.
4391 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
4393 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4394 (mi_cmd_data_list_changed_registers, output_register)
4395 (mi_cmd_data_read_memory, mi_load_progress)
4396 (mi_cmd_trace_frame_collected): Update.
4397 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4399 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4400 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4401 (mi_cmd_var_list_children, varobj_update_one): Update.
4402 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4403 (mi_cmd_stack_list_args, list_arg_or_local): Update.
4404 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4405 * inferior.c (print_inferior): Update.
4406 * gdb_bfd.c (print_one_bfd): Update.
4407 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4409 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4410 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4411 do_field_int. Change type of "value".
4412 * cli-out.c (cli_ui_out::do_field_signed): Rename from
4413 do_field_int. Change type of "value".
4414 * breakpoint.c (watchpoint_check, print_breakpoint_location)
4415 (print_one_breakpoint_location, print_it_catch_fork)
4416 (print_one_catch_fork, print_it_catch_vfork)
4417 (print_one_catch_vfork, print_it_catch_solib)
4418 (print_it_catch_exec, print_it_ranged_breakpoint)
4419 (print_mention_watchpoint, print_mention_masked_watchpoint)
4420 (bkpt_print_it, update_static_tracepoint): Update.
4421 * break-catch-throw.c (print_it_exception_catchpoint): Update.
4422 * break-catch-syscall.c (print_it_catch_syscall): Update.
4423 * ada-tasks.c (print_ada_task_info): Update.
4424 * ada-lang.c (print_it_exception, print_mention_exception):
4427 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
4429 PR breakpoints/24541
4430 * gdbarch.c: Regenerate.
4431 * gdbarch.h: Regenerate.
4432 * gdbarch.sh: Adjust return type and parameter types for
4433 'stap_adjust_register'.
4434 (i386_stap_adjust_register): Adjust signature and return new
4436 * stap-probe.c (stap_parse_register_operand): Adjust use of
4437 'gdbarch_stap_adjust_register'.
4439 2019-07-17 Tom Tromey <tromey@adacore.com>
4441 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
4443 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4445 (struct s390_process_info): Add initializers.
4446 (s390_add_process): Use new.
4447 (s390_linux_nat_target::low_forget_process): Use delete.
4448 (s390_linux_nat_target::low_new_fork)
4449 (s390_linux_nat_target::stopped_by_watchpoint)
4450 (s390_linux_nat_target::low_prepare_to_resume)
4451 (s390_linux_nat_target::insert_watchpoint)
4452 (s390_linux_nat_target::insert_hw_breakpoint)
4453 (s390_linux_nat_target::remove_watchpoint)
4454 (s390_linux_nat_target::remove_hw_breakpoint): Update.
4456 2019-07-16 John Baldwin <jhb@FreeBSD.org>
4458 * aarch64-fbsd-nat.c: Include regcache.h.
4459 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4461 (aarch64_fbsd_nat_target::fetch_registers)
4462 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4464 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4466 2019-07-16 John Baldwin <jhb@FreeBSD.org>
4468 * fbsd-nat.c: Include gdbarch.h.
4470 2019-07-15 Tom Tromey <tromey@adacore.com>
4472 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4474 2019-07-15 Tom Tromey <tromey@adacore.com>
4476 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4477 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4478 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4479 * cli-out.c (cli_ui_out::do_field_int): New method.
4480 * ui-out.c (ui_out::field_unsigned): New method.
4481 * symfile.c (generic_load): Use field_unsigned.
4482 (print_transfer_performance): Likewise.
4483 * record-btrace.c (ui_out_field_uint): Remove.
4484 (btrace_call_history_insn_range, btrace_call_history): Use
4486 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4488 * ui-out.h (class ui_out) <field_unsigned>: New method.
4489 <do_field_unsigned>: Likewise.
4491 2019-07-15 Tom Tromey <tromey@adacore.com>
4493 * mi/mi-main.c (list_available_thread_groups): Use field_string.
4494 * mi/mi-interp.c (mi_memory_changed): Use field_string.
4495 * target.c (flash_erase_command): Use field_string.
4496 * infrun.c (print_signal_received_reason): Use field_string.
4497 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4498 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4500 * ada-tasks.c (print_ada_task_info): Use field_string.
4502 2019-07-15 Tom Tromey <tromey@adacore.com>
4504 * target.c (flash_erase_command): Use field_core_addr.
4505 * symfile.c (generic_load): Use field_core_addr.
4506 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4507 Use field_core_addr.
4508 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4511 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4513 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4514 value if its desired type is smaller than a CORE_ADDR and signed.
4516 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4518 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4519 of changes to field names, and use new is_reference field to
4520 decide if a property is a reference or not.
4521 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4523 (struct dwarf2_property_baton): Update header comment, rename
4524 'referenced_type' to 'property_type' and update comments.
4525 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4526 default property type, store in property baton, update to take
4527 accound of renamed field.
4528 (read_func_scope): Update call to attr_to_dynamic_prop.
4529 (read_array_type): Likewise.
4530 (dwarf2_per_cu_addr_sized_int_type): New function.
4531 (read_subrange_index_type): Move type finding code to
4532 dwarf2_per_cu_addr_sized_int_type.
4533 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4534 (dwarf2_per_cu_addr_type): New function.
4535 (set_die_type): Update calls to attr_to_dynamic_prop.
4537 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4539 * dwarf2read.c (read_subrange_index_type): New function.
4540 (read_subrange_type): Move code into new function and call it.
4541 * gdbtypes.c (create_range_type): Add some asserts.
4543 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4545 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4546 update return statements.
4547 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4548 declaration, and update comment to match.
4549 * gdbtypes.c (resolve_dynamic_array): Update call to
4550 dwarf2_evaluate_property to match new return type.
4552 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4554 * valarith.c (value_subscripted_rvalue): Change lowerbound
4555 parameter type from int to LONGEST.
4556 * value.h (value_subscripted_rvalue): Likewise in declaration.
4558 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4560 * cli/cli-utils.c (info_print_command_completer): New function.
4561 * cli/cli-utils.h: Add 'completer.h' include, and forward
4562 declaration for 'struct cmd_list_element'.
4563 (info_print_command_completer): Declare.
4564 * stack.c (_initialize_stack): Add completer for 'info locals' and
4566 * symtab.c (_initialize_symtab): Add completer for 'info
4567 variables' and 'info functions'.
4568 * NEWS: Mention completion for additional info commands.
4570 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4572 * cli/cli-utils.c (extract_info_print_args): Delete.
4573 (extract_arg_maybe_quoted): Delete.
4574 (info_print_options_defs): New variable.
4575 (make_info_print_options_def_group): New function.
4576 (extract_info_print_options): Define new function.
4577 * cli/cli-utils.h (extract_info_print_args): Delete.
4578 (struct info_print_options): New structure.
4579 (extract_info_print_options): Declare new function.
4580 * stack.c (info_locals_command): Update to use new
4581 extract_info_print_options, also add a header comment.
4582 (info_args_command): Likewise.
4583 * symtab.c (info_variables_command): Likewise.
4584 (info_functions_command): Likewise.
4586 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4588 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4589 to extract string arguments.
4590 * common/common-utils.c (extract_string_maybe_quoted): New function.
4591 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4593 2019-07-11 Tom Tromey <tromey@adacore.com>
4595 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4596 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4597 * top.h (gdbinit): Don't declare.
4598 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4600 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4601 * top.c (gdb_init): Don't call init_cli_cmds.
4603 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4605 2019-07-11 Tom Tromey <tromey@adacore.com>
4607 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4608 after it has been moved.
4610 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4612 * valops.c (value_must_coerce_to_target): Change return type to
4614 * value.h (value_must_coerce_to_target): Likewise.
4616 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
4618 * breakpoint.c (is_hardware_watchpoint): Remove
4619 forward-declaration.
4620 (is_masked_watchpoint): Change return type to bool.
4621 (is_tracepoint): Likewise.
4622 (is_breakpoint): Likewise.
4623 (is_hardware_watchpoint): Likewise.
4624 (is_watchpoint): Likewise.
4625 (is_no_memory_software_watchpoint): Likewise.
4626 (is_catchpoint): Likewise.
4627 (breakpoint_1): Make FILTER parameter's return type bool.
4628 is_masked_watchpoint): Change return type to bool.
4629 (save_breakpoints): Make FILTER parameter's return type bool.
4630 * breakpoint.h (is_breakpoint): Change return type to bool.
4631 (is_watchpoint): Likewise.
4632 (is_catchpoint): Likewise.
4633 (is_tracepoint): Likewise.
4635 2019-07-10 Tom Tromey <tom@tromey.com>
4637 * defs.h: Don't include gdbarch.h.
4638 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4639 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4640 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4641 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4642 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4643 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4644 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4645 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4646 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4647 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4648 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4649 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4650 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4651 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4652 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4653 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4654 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4655 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4656 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4657 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4658 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4659 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4660 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4661 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4662 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4663 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4664 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4666 2019-07-10 Tom Tromey <tromey@adacore.com>
4668 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4669 * breakpoint.c (init_ada_exception_breakpoint): Register as
4671 (print_one_breakpoint_location, print_one_breakpoint): Use
4672 is_ada_exception_catchpoint.
4673 * ada-lang.c (class ada_catchpoint_location): Pass
4674 bp_loc_software_breakpoint to bp_location constructor.
4675 (is_ada_exception_catchpoint): New function.
4677 2019-07-10 Tom Tromey <tromey@adacore.com>
4679 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4681 (struct arm_exidx_entry): New method operator<.
4682 (struct arm_exidx_data) <section_maps>: Change type.
4683 (arm_exidx_data_free): Remove.
4684 (arm_exidx_data_key): Change type. Move lower.
4685 (arm_exidx_new_objfile): Update.
4686 (arm_compare_exidx_entries): Remove.
4687 (arm_find_exidx_entry, _initialize_arm_tdep)
4689 2019-07-10 Tom Tromey <tromey@adacore.com>
4691 * solib-spu.c (ocl_program_data_key): Change type.
4692 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4695 2019-07-10 Tom Tromey <tromey@adacore.com>
4697 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4698 (struct solib_aix_inferior_data) <library_list>: Change type.
4699 (solib_aix_inferior_data_handle): Change type.
4700 (get_solib_aix_inferior_data): Update.
4701 (solib_aix_free_library_list): Remove.
4702 (library_list_start_library): Update.
4703 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4705 (solib_aix_get_library_list)
4706 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4707 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4709 2019-07-10 Tom Tromey <tromey@adacore.com>
4711 * solib-dsbt.c (struct dsbt_info): Add initializers.
4712 (solib_dsbt_pspace_data): Change type.
4713 (dsbt_pspace_data_cleanup): Remove.
4714 (get_dsbt_info, _initialize_dsbt_solib): Update.
4716 2019-07-10 Tom Tromey <tromey@adacore.com>
4718 * spu-tdep.c (spu_overlay_data): Change type.
4719 (spu_get_overlay_table, spu_overlay_new_objfile)
4720 (_initialize_spu_tdep): Update.
4722 2019-07-10 Tom Tromey <tromey@adacore.com>
4724 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4726 (dbx_objfile_data_key): Change type and declare later.
4727 (DBX_SYMFILE_INFO): Rewrite.
4728 * dbxread.c (dbx_objfile_data_key): Change type.
4729 (dbx_symfile_init): Update.
4730 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4731 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4732 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4734 2019-07-10 Tom Tromey <tromey@adacore.com>
4736 * jit.c (jit_program_space_key): Change type. Move lower.
4737 (get_jit_program_space_data): Update.
4738 (jit_program_space_data_cleanup): Remove.
4739 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4741 (struct jit_program_space_data): Add initializers.
4743 2019-07-10 Tom Tromey <tromey@adacore.com>
4745 * solib-darwin.c (struct darwin_info): Add initializers.
4746 (solib_darwin_pspace_data): Change type.
4747 (darwin_pspace_data_cleanup): Remove.
4748 (get_darwin_info, _initialize_darwin_solib): Update.
4750 2019-07-10 Tom Tromey <tromey@adacore.com>
4752 * remote-sim.c (struct sim_inferior_data): Add initializers,
4753 constructor, and destructor.
4754 (sim_inferior_data_key): Change type. Move lower.
4755 (check_for_duplicate_sim_descriptor): Update.
4756 (get_sim_inferior_data): Use new. Update.
4757 (~sim_inferior_data_cleanup): Rename from
4758 sim_inferior_data_cleanup. Simplify.
4759 (gdbsim_close_inferior, simulator_command)
4760 (sim_command_completer, _initialize_remote_sim): Update.
4761 (next_pid, INITIAL_PID): Move earlier.
4763 2019-07-10 Tom Tromey <tromey@adacore.com>
4765 * python/python-internal.h (create_thread_object): Return
4767 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4768 * python/py-inferior.c (struct threadlist_entry): Add
4770 <thread_obj>: Now a gdbpy_ref.
4771 (thread_to_thread_object): Update.
4772 (add_thread_object): Use new.
4773 (delete_thread_object): Use delete.
4774 (infpy_threads): Update.
4775 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4778 2019-07-10 Tom Tromey <tromey@adacore.com>
4780 * valops.c (value_cast): Specialize error message for Ada.
4782 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4784 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4786 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4788 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4789 bpstat_should_step): Return bool, adjust comments.
4790 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4791 bpstat_should_step): Likewise.
4793 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4795 * features/Makefile: Use feature target descriptions for Arm.
4796 * features/arm/arm-core.c: Generate new file.
4797 * features/arm/arm-fpa.c: Likewise.
4798 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4799 * features/arm/arm-m-profile.c: Likewise.
4800 * features/arm/arm-vfpv2.c: Likewise.
4801 * features/arm/arm-vfpv3.c: Likewise.
4802 * features/arm/xscale-iwmmxt.c: Likewise.
4803 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4805 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4807 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4810 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4812 * features/aarch64-pauth.c: Regenerate.
4814 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4816 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4818 (bpstat_what): Use false instead of 0.
4820 2019-07-09 Pedro Alves <palves@redhat.com>
4822 * break-catch-throw.c (is_exception_catchpoint): New.
4823 * breakpoint.c (print_one_breakpoint_location): New parameter
4824 'raw_loc'. Handle it. Use
4825 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4826 looking at the breakpoint's type.
4827 (print_one_breakpoint): If handling "maint info breakpoints", also
4828 print locations of exception catchpoints.
4829 * breakpoint.h (is_exception_catchpoint): Declare.
4831 2019-07-09 Pedro Alves <palves@redhat.com>
4833 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4835 (allocate_location_exception_catchpoint): New.
4836 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4837 (initialize_throw_catchpoint_ops): Install
4838 allocate_location_exception_catchpoint as allocate_location
4840 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4841 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4843 (breakpoint_address_is_meaningful): Delete.
4844 (bl_address_is_meaningful): New.
4845 (breakpoint_locations_match): Adjust comment.
4846 (bp_location_from_bp_type): New, factored out of...
4847 (bp_location::bp_location(breakpoint *)): ... this.
4848 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4850 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4851 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4852 breakpoint_address_is_meaningful.
4853 (bp_locations_compare): Adjust comment.
4854 (update_global_location_list): Use bl_address_is_meaningful
4855 instead of breakpoint_address_is_meaningful.
4856 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4858 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4859 * python/py-breakpoint.c (bppy_get_location): No longer check
4860 whether location is null.
4862 2019-07-09 Pedro Alves <palves@redhat.com>
4865 * breakpoint.c (print_one_breakpoint_location): Remove
4866 single-location assert.
4868 2019-07-09 Tom Tromey <tom@tromey.com>
4870 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4871 * configure: Rebuild.
4872 * configure.ac: Change common to gdbsupport.
4873 * gdbsupport: Rename from common.
4874 * acinclude.m4: Change common to gdbsupport.
4875 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4876 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4878 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4879 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4880 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4881 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4882 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4883 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4884 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4885 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4886 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4887 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4888 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4889 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4890 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4891 coff-pe-read.c, command.h, compile/compile-c-support.c,
4892 compile/compile-c.h, compile/compile-cplus-symbols.c,
4893 compile/compile-cplus-types.c, compile/compile-cplus.h,
4894 compile/compile-loc2c.c, compile/compile.c, completer.c,
4895 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4896 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4897 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4898 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4899 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4900 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4901 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4902 features/aarch64-core.c, features/aarch64-fpu.c,
4903 features/aarch64-pauth.c, features/aarch64-sve.c,
4904 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4905 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4906 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4907 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4908 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4909 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4910 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4911 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4912 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4913 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4914 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4915 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4916 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4917 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4918 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4919 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4920 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4921 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4922 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4923 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4924 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4925 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4926 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4927 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4928 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4929 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4930 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4931 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4932 minsyms.c, mips-linux-tdep.c, namespace.h,
4933 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4934 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4935 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4936 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4937 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4938 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4939 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4940 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4941 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4942 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4943 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4944 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4945 procfs.c, producer.c, progspace.h, psymtab.h,
4946 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4947 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4948 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4949 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4950 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4951 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4952 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4953 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4954 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4955 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4956 target-memory.c, target.c, target.h, target/waitstatus.c,
4957 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4958 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4959 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4960 unittests/array-view-selftests.c,
4961 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4962 unittests/common-utils-selftests.c,
4963 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4964 unittests/format_pieces-selftests.c,
4965 unittests/function-view-selftests.c,
4966 unittests/lookup_name_info-selftests.c,
4967 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4968 unittests/mkdir-recursive-selftests.c,
4969 unittests/observable-selftests.c,
4970 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4971 unittests/parse-connection-spec-selftests.c,
4972 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4973 unittests/scoped_fd-selftests.c,
4974 unittests/scoped_mmap-selftests.c,
4975 unittests/scoped_restore-selftests.c,
4976 unittests/string_view-selftests.c, unittests/style-selftests.c,
4977 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4978 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4979 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4980 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4981 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4982 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4984 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4986 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4988 (decode_digits_ordinary): Set explicit_line field in sal.
4989 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4990 symtab_and_line that was set on an explicit line number in
4991 assembler code. Do always update the recorded symtab and line if
4992 we do skip the prologue.
4994 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4996 * breakpoint.c (set_breakpoint_location_function): Remove
4997 explicit_loc parameter.
4998 (momentary_breakpoint_from_master): Update call to
4999 set_breakpoint_location_function.
5000 (add_location_to_breakpoint): Likewise.
5002 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
5004 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5005 required features based on default bfd type when no specific bfd
5008 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5010 * NEWS: Mention that GDB printf and eval commands can now print
5011 C-style and Ada-style convenience var strings without
5012 calling the inferior.
5013 * printcmd.c (printf_c_string): Locally print GDB internal var
5014 instead of transiting via the inferior.
5015 (printf_wide_c_string): Likewise.
5017 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5019 PR breakpoints/25011
5020 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5022 2019-07-04 Tom Tromey <tom@tromey.com>
5025 * tui/tui-winsource.c (tui_clear_source_content): Update.
5026 (tui_source_window_base::set_is_exec_point_at): Fix comment.
5027 (tui_update_breakpoint_info): Update.
5028 (tui_set_exec_info_content): Update.
5029 * tui/tui-source.c (tui_set_source_content_nil): Update.
5030 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5032 * tui/tui-data.h (enum tui_bp_flag): New.
5033 (tui_bp_flags): New enum flags type.
5034 (struct tui_source_element) <break_mode>: Change type. Rename
5036 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5037 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
5039 * tui/tui-winsource.h: Fix comment.
5041 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5043 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5044 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5045 (store_fpregs_to_thread)
5046 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5047 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5048 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5049 (IWMMXT_REGS_SIZE): Add define.
5050 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5051 (fetch_vfp_regs, store_vfp_regs)
5052 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5053 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5055 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5057 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5059 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5060 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5061 (ARM_INT_REGISTER_SIZE): ...to this.
5062 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5063 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5064 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5065 (arm_linux_collect_gregset, supply_nwfpe_register)
5066 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5068 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5069 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5070 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5071 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5072 (arm_return_in_memory, arm_store_return_value)
5073 (arm_get_longjmp_target, arm_register_g_packet_guesses)
5074 (arm_record_ld_st_multiple): Likewise.
5075 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5076 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5078 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5080 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5081 AARCH64_DISPLACED_MODIFIED_INSNS.
5082 * aarch64-tdep.c (struct aarch64_displaced_step_data)
5083 (aarch64_displaced_step_copy_insn): Likewise.
5084 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5085 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5086 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5087 ARM_DISPLACED_MODIFIED_INSNS.
5088 * arm-tdep.c (arm_gdbarch_init): Likewise.
5089 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5090 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5091 (struct arm_displaced_step_closure): Use
5092 ARM_DISPLACED_MODIFIED_INSNS.
5094 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5096 * features/Makefile: Remove unused xml files.
5097 * features/aarch64.xml: Remove.
5098 * features/i386/amd64-avx-avx512-linux.xml: Remove.
5099 * features/i386/amd64-avx-avx512.xml: Remove.
5100 * features/i386/amd64-avx-linux.xml: Remove.
5101 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5102 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5103 * features/i386/amd64-avx-mpx-linux.xml: Remove.
5104 * features/i386/amd64-avx-mpx.xml: Remove.
5105 * features/i386/amd64-avx.xml: Remove.
5106 * features/i386/amd64-linux.xml: Remove.
5107 * features/i386/amd64-mpx-linux.xml: Remove.
5108 * features/i386/amd64-mpx.xml: Remove.
5109 * features/i386/amd64.xml: Remove.
5110 * features/i386/i386-avx-avx512-linux.xml: Remove.
5111 * features/i386/i386-avx-avx512.xml: Remove.
5112 * features/i386/i386-avx-linux.xml: Remove.
5113 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5114 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5115 * features/i386/i386-avx-mpx-linux.xml: Remove.
5116 * features/i386/i386-avx-mpx.xml: Remove.
5117 * features/i386/i386-avx.xml: Remove.
5118 * features/i386/i386-linux.xml: Remove.
5119 * features/i386/i386-mmx-linux.xml: Remove.
5120 * features/i386/i386-mmx.xml: Remove.
5121 * features/i386/i386-mpx-linux.xml: Remove.
5122 * features/i386/i386-mpx.xml: Remove.
5123 * features/i386/i386.xml: Remove.
5124 * features/i386/x32-avx-avx512-linux.xml: Remove.
5125 * features/i386/x32-avx-linux.xml: Remove.
5126 * features/i386/x32-linux.xml: Remove.
5128 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5130 * regformats/aarch64.dat: Remove.
5131 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5132 * regformats/i386/amd64-avx-linux.dat: Remove.
5133 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5134 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5135 * regformats/i386/amd64-linux.dat: Remove.
5136 * regformats/i386/amd64-mpx-linux.dat: Remove.
5137 * regformats/i386/amd64.dat: Remove.
5138 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5139 * regformats/i386/i386-avx-linux.dat: Remove.
5140 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5141 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5142 * regformats/i386/i386-linux.dat: Remove.
5143 * regformats/i386/i386-mmx-linux.dat: Remove.
5144 * regformats/i386/i386-mpx-linux.dat: Remove.
5145 * regformats/i386/i386.dat: Remove.
5146 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5147 * regformats/i386/x32-avx-linux.dat: Remove.
5148 * regformats/i386/x32-linux.dat: Remove.
5150 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5152 * aarch64-tdep.c: Remove xml self tests.
5153 * amd64-linux-tdep.c: Likewise.
5154 * amd64-tdep.c: Likewise.
5155 * i386-linux-tdep.c: Likewise.
5156 * i386-tdep.c: Likewise.
5158 2019-07-03 Pedro Alves <palves@redhat.com>
5161 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5162 (pipe_cmd_option_defs): New.
5163 (make_pipe_cmd_options_def_group): New.
5164 (pipe_command): Use gdb::option::process_options.
5165 (pipe_command_completer): New function.
5166 (_initialize_cli_cmds): Install completer for "pipe" command.
5168 2019-07-03 Pedro Alves <palves@redhat.com>
5170 * cli/cli-option.c (union option_value) <string>: New field.
5171 (struct option_def_and_value): Add ctor, move ctor, dtor and
5172 use DISABLE_COPY_AND_ASSIGN.
5173 (option_def_and_value::clear_value): New.
5174 (parse_option, save_option_value_in_ctx, get_val_type_str)
5175 (add_setshow_cmds_for_options): Handle var_string.
5176 * cli-option.h (union option_def::var_address) <string>: New
5178 (struct string_option_def): New.
5179 * maint-test-options.c (struct test_options_opts): Add default
5180 ctor and use DISABLE_COPY_AND_ASSIGN.
5181 <string_opt>: New field.
5182 (test_options_opts::~test_options_opts): New.
5183 (test_options_opts::dump): Also dump "-string".
5184 (test_options_option_defs): Install "string.
5186 2019-07-03 Pedro Alves <palves@redhat.com>
5188 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5189 option_value with a null enumeration.
5190 (complete_options): Save the option values in the context.
5191 (save_option_value_in_ctx): New, factored out from ...
5192 (process_options): ... here.
5193 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5195 * maint-test-options.c (test_options_opts::dump): New, factored
5197 (maintenance_test_options_command_mode): ... here.
5198 (maintenance_test_options_command_completion_result): Delete.
5199 (maintenance_test_options_command_completion_text): Update
5201 (maintenance_show_test_options_completion_result): Change
5202 prototype. Just print
5203 maintenance_test_options_command_completion_text.
5204 (save_completion_result): New.
5205 (maintenance_test_options_completer_mode): Pass options context to
5206 complete_options, and then save a dump.
5207 (_initialize_maint_test_options): Use add_cmd to install "maint
5208 show test-options-completion-result".
5210 2019-07-03 Pedro Alves <palves@redhat.com>
5212 * NEWS (New commands): Mention "with" and "maint with".
5213 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5214 (with_command, with_command_completer): New.
5215 (pipe_command): Adjust to new repeat_previous
5217 (_initialize_cli_cmds): Install the "with" command and its "w"
5219 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5221 * cli/cli-setshow.c (parse_cli_var_uinteger)
5222 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5223 argument strings for all var_types.
5224 (get_setshow_command_value_string): New, factored out from ...
5225 (do_show_command): ... this.
5226 * cli/cli-setshow.h: Include <string>.
5227 (get_setshow_command_value_string): Declare.
5228 * command.h (repeat_previous): Now returns const char *. Adjust
5230 * maint.c: Include "cli/cli-cmds.h".
5231 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5232 (_initialize_maint_cmds): Register the "maintenance with" command.
5233 * top.c (repeat_previous): Move bits from pipe_command here:
5234 Return the saved command line, if any; error out if there's no
5235 command to relaunch.
5237 2019-07-03 Pedro Alves <palves@redhat.com>
5239 * NEWS (New commands): Mention "maint set/show test-settings"
5240 instead of "maint test-settings".
5241 * maint-test-settings.c (maintenance_test_settings_list): Delete.
5242 (maintenance_test_settings_set_list): Rename to ...
5243 (maintenance_set_test_settings_list): ... this.
5244 (maintenance_test_settings_show_list): Rename to ...
5245 (maintenance_show_test_settings_list): ... this.
5246 (maintenance_test_settings_cmd): Delete.
5247 (maintenance_test_settings_set_cmd): ...
5248 (maintenance_set_test_settings_cmd): ... this.
5249 (maintenance_test_settings_show_cmd): ...
5250 (maintenance_show_test_settings_cmd): ... this.
5251 (maintenance_test_settings_show_value_cmd):
5252 (maintenance_show_test_settings_value_cmd): ... this.
5253 (_initialize_maint_test_settings): No longer install the "maint
5254 test-settings" prefix command. Rename "maint test-settings set"
5255 to "maint set test-settings", and "maint test-settings show" to
5256 "maint show test-settings". Adjust all subcommands.
5258 2019-07-03 Pedro Alves <palves@redhat.com>
5260 * maint-test-settings.c: Fix file's intro comment. Replace all
5261 references to "test-options" with references to "test-settings",
5264 2019-07-03 Pedro Alves <palves@redhat.com>
5266 * maint-test-settings.c (maintenance_test_settings_xxx)
5267 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5269 (maintenance_test_settings_enums): Use them.
5270 (maintenance_test_settings_enum): Default to
5271 maintenance_test_settings_xxx.
5272 (_initialize_maint_test_settings): Initialize
5273 MAINTENANCE_TEST_SETTINGS_FILENAME.
5275 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5277 * breakpoint.h (remove_breakpoints_inf): Change return type to
5278 void, move function documentation here.
5279 * breakpoint.c (remove_breakpoints_inf): Change return type to
5280 void, move function documentation to header.
5282 2019-07-02 Pedro Alves <palves@redhat.com>
5284 * NEWS (Completion improvements): Mention "info threads".
5285 * thread.c (struct info_threads_opts, info_threads_option_defs)
5286 (make_info_threads_options_def_group): New.
5287 (info_threads_command): Use gdb::option::process_options.
5288 (info_threads_command_completer): New.
5289 (_initialize_thread): Use gdb::option::build_help to build the
5290 help text for "info threads".
5292 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5294 * defs.h (generic_load): Move from here...
5295 * symfile.h (generic_load): ... to here. Rename name parameter
5297 * symfile.c (generic_load): Add comment.
5299 2019-07-01 Tom Tromey <tromey@adacore.com>
5302 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5303 declaration of without_params. Fix formatting.
5305 2019-07-01 Tom Tromey <tromey@adacore.com>
5307 * ada-exp.y (find_primitive_type): Update.
5308 * ada-lang.h (ada_lookup_symbol): Update.
5309 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5311 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5313 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5315 PR breakpoints/24541
5316 * gdbarch.c: Regenerate.
5317 * gdbarch.h: Regenerate.
5318 * gdbarch.sh: Add 'stap_adjust_register'.
5319 * i386-tdep.c: Include '<unordered_set>'.
5320 (i386_stap_adjust_register): New function.
5321 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5322 * stap-probe.c (stap_parse_register_operand): Call
5323 'gdbarch_stap_adjust_register'.
5325 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5328 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5329 * python/python.c (do_start_initialization): Use 'xmalloc'
5330 instead of 'PyMem_Malloc'.
5332 2019-06-28 Tom Tromey <tromey@adacore.com>
5334 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5337 2019-06-27 Tom Tromey <tromey@adacore.com>
5339 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
5341 (arm_find_mapping_symbol, arm_record_special_symbol)
5342 (_initialize_arm_tdep): Update.
5343 (arm_objfile_data_free): Remove.
5345 2019-06-27 Tom Tromey <tromey@adacore.com>
5347 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5348 to cp_print_static_field.
5350 2019-06-26 Tom Tromey <tromey@adacore.com>
5352 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5353 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5356 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5358 * features/aarch64-core.c (create_feature_aarch64_core):
5360 * features/aarch64-core.xml: Add cpsr flags.
5362 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5364 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5365 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5367 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5369 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5371 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5373 (arm_record_special_symbol): Don't insert new symbol in sorted
5374 position, push it at the end.
5376 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5378 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5379 (arm_mapping_symbol_s): Remove.
5380 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5381 (arm_mapping_symbol_vec): New typedef.
5382 (struct arm_per_objfile): Add constructor.
5383 <section_maps>: Change type to
5384 std::unique_ptr<arm_mapping_symbol_vec[]>.
5385 (arm_compare_mapping_symbols): Remove.
5386 (arm_find_mapping_symbol): Adjust to section_maps type change.
5387 (arm_objfile_data_free): Call delete on arm_per_objfile.
5388 (arm_record_special_symbol): Adjust to section_maps type change.
5389 Allocate arm_per_objfile with new.
5391 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5393 * cli/cli-cmds.c (alias_command): Compare the alias prefix
5394 with the command prefix.
5396 2019-06-25 Tom Tromey <tom@tromey.com>
5398 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5399 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5401 2019-06-25 Tom Tromey <tom@tromey.com>
5403 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5405 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5408 2019-06-25 Tom Tromey <tom@tromey.com>
5410 * tui/tui-winsource.c
5411 (tui_source_window_base::set_is_exec_point_at): Add check against
5414 2019-06-25 Tom Tromey <tom@tromey.com>
5416 * tui/tui-source.c (tui_set_source_content): Don't check before
5418 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5420 2019-06-25 Tom Tromey <tom@tromey.com>
5422 * tui/tui-winsource.h (tui_update_source_window_as_is)
5423 (tui_alloc_source_buffer, tui_line_is_displayed)
5424 (tui_addr_is_displayed): Change type of win_info.
5425 * tui/tui-winsource.c (tui_update_source_window_as_is)
5426 (tui_clear_source_content, tui_show_source_line)
5427 (tui_show_source_content, tui_source_window_base::refill)
5428 (tui_source_window_base::set_is_exec_point_at)
5429 (tui_source_window_base::set_is_exec_point_at)
5430 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5431 (tui_alloc_source_buffer, tui_line_is_displayed)
5432 (tui_addr_is_displayed): Change type of win_info. Update.
5433 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5434 (tui_source_window_base::do_make_visible_with_new_height):
5436 * tui/tui-source.c (tui_set_source_content)
5437 (tui_set_source_content_nil)
5438 (tui_source_window::do_scroll_vertical): Update.
5439 * tui/tui-layout.c (show_layout): Update.
5440 * tui/tui-disasm.c (tui_set_disassem_content)
5441 (tui_disasm_window::do_scroll_vertical): Update.
5442 * tui/tui-data.h (tui_win_content): Remove.
5443 (struct tui_gen_win_info) <content, content_size>: Remove.
5444 (struct tui_source_element): Add initializers and destructor.
5445 (union tui_which_element, struct tui_win_element): Remove.
5446 (struct tui_source_window_base) <content>: New field.
5447 (struct tui_data_window): Remove destructor.
5448 (tui_alloc_content, tui_free_win_content)
5449 (tui_free_all_source_wins_content): Don't declare.
5450 * tui/tui-data.c (tui_initialize_static_data): Update.
5451 (init_content_element, tui_alloc_content): Remove.
5452 (~tui_gen_win_info): Update.
5453 (~tui_data_window, tui_free_all_source_wins_content)
5454 (tui_free_win_content, free_content, free_content_elements):
5457 2019-06-25 Tom Tromey <tom@tromey.com>
5459 * tui/tui-winsource.h (tui_clear_source_content)
5460 (tui_erase_source_content, tui_show_source_content): Change type
5462 * tui/tui-winsource.c (tui_clear_source_content)
5463 (tui_erase_source_content, tui_show_source_content): Change type
5465 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5466 * tui/tui-source.h (tui_set_source_content_nil): Change type of
5468 * tui/tui-source.c (tui_set_source_content_nil): Change type of
5470 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5472 2019-06-25 Tom Tromey <tom@tromey.com>
5474 * tui/tui-winsource.c (tui_clear_source_content)
5475 (tui_source_window_base::set_is_exec_point_at): Update.
5476 * tui/tui-source.c (tui_set_source_content_nil): Update.
5477 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5479 * tui/tui-data.c (init_content_element): Update.
5481 2019-06-25 Tom Tromey <tom@tromey.com>
5483 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5484 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5485 * tui/tui-layout.c (init_and_make_win): Update.
5486 * tui/tui.h (enum tui_win_type): Update.
5487 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5488 tui_win_is_auxillary.
5489 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5490 tui_win_is_auxillary.
5492 2019-06-25 Tom Tromey <tom@tromey.com>
5494 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5495 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5496 (tui_delete_data_content_windows, tui_display_all_data)
5497 (tui_data_window::do_scroll_vertical, tui_display_data_from):
5499 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5500 * tui/tui-regs.c (tui_last_regs_line_no)
5501 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5502 (tui_show_registers): Update.
5503 (tui_show_register_group): Return void. Update.
5504 (tui_display_registers_from, tui_display_reg_element_at_line)
5505 (tui_display_registers_from_line, tui_check_register_values):
5507 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5509 (struct tui_data_window) <regs_content>: Now a std::vector.
5510 <regs_content_count>: Remove.
5511 (tui_add_content_elements, tui_free_data_content): Don't declare.
5512 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5513 (init_content_element): Remove DATA_WIN case. Add assert.
5514 (tui_add_content_elements): Remove.
5515 (tui_data_window): Update.
5516 (tui_free_data_content): Remove.
5517 (free_content_elements): Remove DATA_WIN case.
5519 2019-06-25 Tom Tromey <tom@tromey.com>
5521 * tui/tui-data.c (tui_data_item_window): Update.
5522 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5523 * tui/tui-windata.c (tui_display_all_data)
5524 (tui_display_data_from_line): Update.
5525 (tui_check_data_values): Remove.
5526 * tui/tui-regs.c (tui_show_register_group)
5527 (tui_display_reg_element_at_line): Update.
5528 * tui/tui-hooks.c (tui_register_changed)
5529 (tui_refresh_frame_and_register_information): Call
5530 tui_check_register_values.
5531 * tui/tui-data.h (struct tui_data_window) <data_content,
5532 data_content_count, data_type>: Remove.
5533 (enum tui_data_type): Remove.
5535 * tui/tui-data.c (tui_data_window::clear_detail)
5536 (~tui_data_window): Update.
5538 2019-06-25 Tom Tromey <tom@tromey.com>
5540 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5542 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5543 Rename from tui_first_data_item_displayed. Update.
5544 (tui_data_window::refresh_all)
5545 (tui_data_window::do_scroll_vertical): Update.
5546 * tui/tui-data.h (struct tui_data_window)
5547 <first_data_item_displayed>: Declare new method.
5549 2019-06-25 Tom Tromey <tom@tromey.com>
5551 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5552 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5554 (tui_initialize_static_data): ...here.
5556 2019-06-25 Tom Tromey <tom@tromey.com>
5558 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5559 (tui_display_registers_from, tui_check_register_values): Update.
5560 (tui_display_register): Remove win_info parameter; update.
5561 (tui_get_register): Change type of parameters.
5562 * tui/tui-data.h (struct tui_data_element): Remove.
5563 (union tui_which_element) <data>: Remove.
5564 <data_window>: Change type.
5565 (struct tui_data_item_window): New.
5566 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5568 (~tui_data_item_window): New destructor.
5569 (free_content_elements): Remove DATA_ITEM_WIN case.
5571 2019-06-25 Tom Tromey <tom@tromey.com>
5573 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5576 2019-06-25 Tom Tromey <tom@tromey.com>
5578 * tui/tui-data.h (struct tui_command_element): Remove.
5579 (union tui_which_element) <command>: Remove.
5580 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5582 (free_content_elements): Remove CMD_WIN case.
5584 2019-06-25 Tom Tromey <tom@tromey.com>
5586 * tui/tui-layout.c (tui_set_layout): Update.
5587 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5588 * tui/tui-data.c (layout_def): Update.
5590 2019-06-25 Tom Tromey <tom@tromey.com>
5592 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5593 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5594 (tui_source_window_base::set_new_height): Update.
5595 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5597 (tui_set_locator_fullname, tui_set_locator_info)
5598 (tui_show_frame_info): Update.
5599 * tui/tui-source.c (tui_set_source_content)
5600 (tui_source_is_displayed): Update.
5601 * tui/tui-layout.c (show_source_disasm_command, show_data)
5602 (show_source_or_disasm_and_command): Update.
5603 * tui/tui-disasm.c (tui_set_disassem_content)
5604 (tui_get_begin_asm_address): Update.
5605 * tui/tui-data.h (struct tui_locator_element): Remove.
5606 (union tui_which_element) <locator>: Remove.
5607 (struct tui_locator_window): New.
5608 (tui_locator_win_info_ptr): Change return type.
5609 * tui/tui-data.c (_locator): Change type.
5610 (tui_locator_win_info_ptr): Change return type.
5611 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5612 (tui_alloc_content): Add assert.
5614 2019-06-25 Tom Tromey <tom@tromey.com>
5616 * tui/tui-winsource.c
5617 (tui_exec_info_window::maybe_allocate_content): New method.
5618 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5619 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5620 (make_source_or_disasm_window): Add cast.
5621 * tui/tui-data.h (union tui_which_element) <simple_string>:
5623 (struct tui_source_info): New.
5624 (struct tui_source_window_base) <execution_info>: Change type.
5625 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5626 case, and add assert.
5627 (tui_alloc_content): Add assert.
5629 2019-06-25 Tom Tromey <tom@tromey.com>
5631 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5632 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5633 * tui/tui-data.c (tui_alloc_win_info): Remove.
5635 2019-06-25 Tom Tromey <tom@tromey.com>
5637 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5638 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5641 2019-06-25 Tom Tromey <tom@tromey.com>
5643 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5644 make_visible_with_new_height method.
5645 (tui_win_info::make_visible_with_new_height): New method.
5646 (tui_source_window_base::do_make_visible_with_new_height)
5647 (tui_data_window::do_make_visible_with_new_height)
5648 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5649 (make_visible_with_new_height): Remove.
5650 (tui_resize_all, tui_adjust_win_heights): Use
5651 make_visible_with_new_height method.
5652 * tui/tui-data.h (struct tui_win_info)
5653 <do_make_visible_with_new_height, make_visible_with_new_height>:
5655 (struct tui_source_window_base, struct tui_data_window)
5656 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5659 2019-06-25 Tom Tromey <tom@tromey.com>
5661 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5663 (update_tab_width): Call update_tab_width method.
5664 * tui/tui-data.h (struct tui_win_info)
5665 (struct tui_source_window_base) <update_tab_width>: New methods.
5667 2019-06-25 Tom Tromey <tom@tromey.com>
5669 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5671 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5673 (tui_gen_win_info::make_visible): Update.
5674 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5676 * tui/tui-data.h (enum tui_box): New enum.
5677 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5679 2019-06-25 Tom Tromey <tom@tromey.com>
5681 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5682 init_and_make_win for EXEC_INFO_WIN.
5683 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5685 (struct tui_win_info) <~tui_win_info>: Inline.
5686 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5688 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5689 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5691 (tui_initialize_static_data): Update.
5692 (~tui_gen_win_info): Handle more cleanup here.
5693 (~tui_source_window_base): Delete "execution_info".
5694 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5696 2019-06-25 Tom Tromey <tom@tromey.com>
5698 * tui/tui-layout.c (make_command_window): Don't set
5700 (show_source_disasm_command): Call the reset method.
5701 (show_data): Don't set can_highlight. Call the reset method.
5702 (tui_gen_win_info::reset): Rename from init_gen_win_info
5703 (init_and_make_win): Simplify. Return tui_gen_win_info.
5704 (show_source_or_disasm_and_command): Call the reset method.
5705 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5706 (struct tui_cmd_window): Set can_highlight.
5708 2019-06-25 Tom Tromey <tom@tromey.com>
5710 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5712 (tui_make_visible, tui_make_invisible): Rewrite.
5713 (tui_win_info::make_visible): Remove.
5714 (tui_source_window_base::make_visible): Update.
5715 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5716 method. Moved from...
5717 (struct tui_win_info) <make_visible>: ...here.
5719 2019-06-25 Tom Tromey <tom@tromey.com>
5721 * tui/tui-winsource.c
5722 (tui_source_window_base::do_scroll_horizontal): Remove direction
5724 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5725 direction parameter.
5726 * tui/tui-win.c (tui_win_info::forward_scroll)
5727 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5728 (tui_win_info::right_scroll): Update.
5729 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5730 direction parameter.
5731 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5732 direction parameter.
5733 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5734 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5735 Remove direction parameter.
5736 (struct tui_source_window_base, struct tui_source_window)
5737 (struct tui_disasm_window, struct tui_data_window)
5738 (struct tui_cmd_window): Update.
5740 2019-06-25 Tom Tromey <tom@tromey.com>
5742 * tui/tui-winsource.h (tui_set_exec_info_content)
5743 (tui_show_exec_info_content, tui_erase_exec_info_content)
5744 (tui_clear_exec_info_content, tui_update_exec_info): Change
5745 argument to tui_source_window_base.
5746 * tui/tui-winsource.c (tui_set_exec_info_content)
5747 (tui_show_exec_info_content, tui_erase_exec_info_content)
5748 (tui_clear_exec_info_content, tui_update_exec_info): Change
5749 argument to tui_source_window_base.
5751 2019-06-25 Tom Tromey <tom@tromey.com>
5753 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5754 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5756 2019-06-25 Tom Tromey <tom@tromey.com>
5758 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5761 2019-06-25 Tom Tromey <tom@tromey.com>
5763 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5765 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5767 * tui/tui-source.c (tui_set_source_content): Update.
5768 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5770 2019-06-25 Tom Tromey <tom@tromey.com>
5772 * tui/tui-win.c (window_name_completer, tui_set_focus)
5773 (tui_all_windows_info): Use name method.
5774 * tui/tui-data.h (struct tui_gen_win_info)
5775 (struct tui_source_window, struct tui_disasm_window)
5776 (struct tui_data_window, struct tui_cmd_window) <name>: New
5778 (tui_win_name): Don't declare.
5779 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5780 (tui_win_name): Remove.
5782 2019-06-25 Tom Tromey <tom@tromey.com>
5784 * tui/tui-winsource.h (tui_update_source_window)
5785 (tui_update_source_window_as_is): Change parameter type.
5786 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5787 to be a tui_source_window_base.
5788 (tui_update_source_window_as_is): Likewise.
5789 * tui/tui-win.c (make_visible_with_new_height): Update.
5791 2019-06-25 Tom Tromey <tom@tromey.com>
5793 * tui/tui-winsource.c (tui_erase_source_content)
5794 (tui_show_source_content, tui_show_exec_info_content)
5795 (tui_erase_exec_info_content): Use refresh_window method.
5796 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5797 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5798 from tui_refresh_win.
5799 (tui_data_window::refresh_window): New method.
5800 (tui_win_info::refresh, tui_source_window_base::refresh)
5801 (tui_refresh_all): Use refresh_window method.
5802 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5804 * tui/tui-regs.c (tui_display_register): Call refresh_window
5806 * tui/tui-layout.c (show_source_disasm_command)
5807 (show_source_or_disasm_and_command): Call refresh_window method.
5808 * tui/tui-data.h (struct tui_gen_win_info)
5809 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5812 2019-06-25 Tom Tromey <tom@tromey.com>
5814 * tui/tui.c (tui_rl_other_window, tui_enable)
5815 (tui_is_window_visible, tui_get_command_dimension): Update.
5816 * tui/tui-winsource.c (tui_update_source_window_as_is)
5817 (tui_clear_source_content, tui_erase_source_content)
5818 (tui_show_source_line, tui_source_window_base::refill)
5819 (tui_source_window_base::do_scroll_horizontal)
5820 (tui_source_window_base::set_is_exec_point_at)
5821 (tui_update_breakpoint_info, tui_set_exec_info_content)
5822 (tui_alloc_source_buffer, tui_line_is_displayed)
5823 (tui_addr_is_displayed): Update.
5824 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5825 (tui_check_and_display_highlight_if_needed)
5826 (tui_win_info::make_visible, tui_win_info::refresh)
5827 (tui_refresh_all): Update.
5828 * tui/tui-windata.c (tui_first_data_item_displayed)
5829 (tui_delete_data_content_windows, tui_erase_data_content)
5830 (tui_display_all_data, tui_data_window::refresh_all)
5831 (tui_check_data_values): Update.
5832 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5833 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5834 (tui_win_info::backward_scroll, tui_refresh_all_win)
5835 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5836 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5837 (tui_source_window_base::set_new_height)
5838 (tui_data_window::set_new_height)
5839 (make_invisible_and_set_new_height)
5840 (make_visible_with_new_height, new_height_ok)
5841 (parse_scrolling_args): Update.
5842 * tui/tui-stack.c (tui_show_frame_info): Update.
5843 * tui/tui-source.c (tui_set_source_content)
5844 (tui_set_source_content_nil, tui_source_is_displayed)
5845 (tui_source_window::do_scroll_vertical): Update.
5846 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5847 (tui_display_registers_from, tui_display_reg_element_at_line)
5848 (tui_check_register_values, tui_reg_command): Update.
5849 * tui/tui-layout.c (tui_default_win_height)
5850 (show_source_disasm_command, show_data, init_and_make_win)
5851 (show_source_or_disasm_and_command): Update.
5852 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5853 (tui_redisplay_readline, tui_mld_flush)
5854 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5856 * tui/tui-disasm.c (tui_set_disassem_content)
5857 (tui_disasm_window::do_scroll_vertical): Update.
5858 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5860 (struct tui_win_info): Derive from tui_gen_win_info.
5861 <~tui_win_info>: Mark as override.
5862 <generic>: Remove member.
5863 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5864 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5865 (~tui_data_window, ~tui_win_info)
5866 (tui_free_all_source_wins_content): Update.
5867 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5869 2019-06-25 Tom Tromey <tom@tromey.com>
5871 * tui/tui-layout.c (init_and_make_win): Use new.
5872 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5873 destructor, initializers.
5874 (tui_alloc_generic_win_info): Don't declare.
5875 * tui/tui-data.c (_locator): Add argument to constructor.
5876 (source_win, disasm_win): New globals.
5877 (exec_info): Remove.
5878 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5880 (tui_alloc_generic_win_info): Remove.
5881 (init_content_element): Use new.
5882 (tui_win_info::tui_win_info): Update.
5883 (free_content_elements) <case DATA_WIN>: Use delete.
5885 2019-06-25 Tom Tromey <tom@tromey.com>
5887 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5888 * tui/tui-windata.c (tui_first_data_item_displayed)
5889 (tui_delete_data_content_windows): Update.
5890 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5891 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5892 (tui_display_registers_from, tui_check_register_values): Update.
5893 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5895 * tui/tui-data.c (init_content_element): Update. Allocate the new
5897 (tui_free_data_content): Update.
5898 (free_content_elements) <case DATA_WIN>: Free the window.
5900 2019-06-25 Tom Tromey <tom@tromey.com>
5902 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5904 * tui/tui-layout.c (make_command_window)
5905 (show_source_disasm_command, show_data, init_and_make_win)
5906 (show_source_or_disasm_and_command): Update.
5907 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5909 <can_highight, is_highlighted>: Now bool.
5910 (tui_set_win_highlight): Don't declare.
5911 * tui/tui-data.c (tui_set_win_highlight): Remove.
5913 2019-06-25 Tom Tromey <tom@tromey.com>
5915 * tui/tui-wingeneral.c (make_visible): Remove check of window
5918 2019-06-25 Tom Tromey <tom@tromey.com>
5920 * tui/tui-win.c (tui_win_info::max_height)
5921 (tui_cmd_window::max_height): New methods.
5922 (new_height_ok): Call max_height.
5923 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5924 <max_height>: New method.
5926 2019-06-25 Tom Tromey <tom@tromey.com>
5928 * tui/tui-win.c (tui_source_window_base::set_new_height)
5929 (tui_data_window::set_new_height): New methods.
5930 (make_invisible_and_set_new_height): Call set_new_height method.
5931 * tui/tui-data.h (struct tui_win_info)
5932 (struct tui_source_window_base, struct tui_data_window)
5933 <set_new_height>: New method.
5935 2019-06-25 Tom Tromey <tom@tromey.com>
5937 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5938 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5939 tui_refresh_data_win.
5940 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5942 (tui_refresh_all_win): Call the refresh_all method.
5943 (tui_set_focus): Likewise.
5944 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5945 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5948 2019-06-25 Tom Tromey <tom@tromey.com>
5950 * tui/tui-winsource.h (tui_refill_source_window)
5951 (tui_set_is_exec_point_at): Don't declare.
5952 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5953 (tui_source_window_base::refill): Rename from
5954 tui_refill_source_window.
5955 (tui_source_window_base::do_scroll_horizontal): Update.
5956 (tui_source_window_base::set_is_exec_point_at): Rename from
5957 tui_set_is_exec_point_at.
5958 (tui_update_all_breakpoint_info): Update.
5959 * tui/tui-stack.c (tui_show_frame_info): Update.
5960 * tui/tui-layout.c (show_data): Add cast.
5961 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5962 * tui/tui-data.h (struct tui_source_window_base) <refill,
5963 set_is_exec_point_at>: New methods.
5964 (tui_source_windows, tui_add_to_source_windows): Update types.
5965 (tui_add_to_source_windows): Remove redundant declaration.
5966 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5967 (tui_source_windows): Change return type.
5968 (tui_clear_source_windows_detail): Update.
5969 (tui_add_to_source_windows): Change type of parameter.
5970 (tui_free_all_source_wins_content): Update.
5972 2019-06-25 Tom Tromey <tom@tromey.com>
5974 * tui/tui-wingeneral.c (tui_win_info::refresh)
5975 (tui_source_window_base::refresh): New methods.
5976 (tui_refresh_all): Call the refresh method.
5977 * tui/tui-data.h (struct tui_win_info)
5978 (struct tui_source_window_base) <refresh>: New method.
5980 2019-06-25 Tom Tromey <tom@tromey.com>
5982 * tui/tui.h (tui_is_window_visible): Return bool.
5983 * tui/tui.c (tui_is_window_visible): Return bool.
5984 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5985 (tui_make_visible, tui_make_invisible)
5986 (tui_win_info::make_visible)
5987 (tui_source_window_base::make_visible, make_all_visible)
5988 (tui_make_all_visible, tui_make_all_invisible): Update.
5989 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5990 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5992 (struct tui_win_info, struct tui_source_window_base)
5993 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5994 * tui/tui-data.c (tui_init_generic_part): Update.
5996 2019-06-25 Tom Tromey <tom@tromey.com>
5998 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5999 (tui_source_window_base::make_visible): New methods.
6000 (make_all_visible): Make method call.
6001 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6002 (struct tui_source_window_base, struct tui_cmd_window): Override
6004 (tui_win_is_source_type): Don't declare.
6005 * tui/tui-data.c (tui_win_is_source_type): Remove.
6007 2019-06-25 Tom Tromey <tom@tromey.com>
6009 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6012 2019-06-25 Tom Tromey <tom@tromey.com>
6014 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6015 Inline constructor. Add initializers for members.
6016 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6017 constructors; now inline in class.
6019 2019-06-25 Tom Tromey <tom@tromey.com>
6021 * tui/tui-regs.c (tui_show_registers): Update.
6022 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6024 * tui/tui-data.c (tui_data_window::clear_detail)
6025 (tui_data_window): Update.
6027 2019-06-25 Tom Tromey <tom@tromey.com>
6029 * tui/tui-windata.c (tui_display_all_data)
6030 (tui_display_data_from_line, tui_display_data_from)
6031 (tui_check_data_values, tui_data_window::do_scroll_vertical):
6033 * tui/tui-regs.c (tui_last_regs_line_no)
6034 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6035 (tui_show_registers, tui_show_register_group)
6036 (tui_display_registers_from, tui_display_reg_element_at_line)
6037 (tui_display_registers_from_line, tui_check_register_values)
6038 (tui_reg_next, tui_reg_prev): Update.
6039 * tui/tui-layout.c (tui_set_layout, show_data): Update.
6040 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
6042 (struct tui_win_info) <detail>: Remove. Add new fields from
6044 (TUI_DATA_WIN): Add cast.
6045 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6046 (~tui_data_window): Simplify.
6048 2019-06-25 Tom Tromey <tom@tromey.com>
6050 * tui/tui-layout.c (show_source_disasm_command)
6051 (show_source_or_disasm_and_command): Update.
6052 * tui/tui-io.c (update_cmdwin_start_line)
6053 (tui_redisplay_readline): Update.
6054 * tui/tui-data.h (struct tui_command_info): Remove.
6055 (struct tui_win_info) <detail>: Remove command_info member.
6056 (struct tui_data_window) <start_line>: New member, from
6058 (TUI_CMD_WIN): Add casts.
6060 2019-06-25 Tom Tromey <tom@tromey.com>
6062 * tui/tui-winsource.c (tui_update_source_window)
6063 (tui_refill_source_window)
6064 (tui_source_window_base::do_scroll_horizontal)
6065 (tui_update_breakpoint_info, tui_set_exec_info_content)
6066 (tui_show_exec_info_content, tui_erase_exec_info_content)
6067 (tui_clear_exec_info_content): Update.
6068 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6070 * tui/tui-win.c (make_invisible_and_set_new_height)
6071 (make_visible_with_new_height): Update.
6072 * tui/tui-source.c (tui_set_source_content)
6073 (tui_show_symtab_source): Update.
6074 * tui/tui-layout.c (extract_display_start_addr)
6075 (show_source_disasm_command, show_data)
6076 (make_source_or_disasm_window)
6077 (show_source_or_disasm_and_command): Update.
6078 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6079 (tui_disasm_window::do_scroll_vertical): Remove shadowing
6081 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
6082 to tui_source_window_base.
6083 (struct tui_win_info) <detail>: Remove source_info member.
6084 (struct tui_source_window_base) <has_locator>: Inline.
6085 Move contents from tui_source_info; rename has_locator member to
6087 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6088 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6090 (tui_source_window_base::clear_detail, ~tui_source_window_base):
6092 (tui_free_all_source_wins_content): Cast to
6093 tui_source_window_base.
6095 2019-06-25 Tom Tromey <tom@tromey.com>
6097 * tui/tui-win.c (make_invisible_and_set_new_height)
6098 (make_visible_with_new_height): Call has_locator method.
6099 * tui/tui-layout.c (show_source_disasm_command, show_data)
6100 (show_source_or_disasm_and_command): Update for bool change.
6101 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6102 (tui_win_info) <has_locator>: New method.
6103 (struct tui_source_window_base) <has_locator>: New method.
6104 (tui_win_has_locator): Don't declare.
6105 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6106 from tui_win_has_locator.
6107 (tui_source_window_base): Use false, not FALSE.
6109 2019-06-25 Tom Tromey <tom@tromey.com>
6111 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6112 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6113 clear_detail method directly.
6114 (tui_clear_win_detail): Remove.
6116 2019-06-25 Tom Tromey <tom@tromey.com>
6118 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6119 "this", not TUI_DISASM_WIN.
6121 2019-06-25 Tom Tromey <tom@tromey.com>
6123 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
6125 * tui/tui-winsource.c
6126 (tui_source_window_base::do_scroll_horizontal): Rename from
6127 tui_horizontal_source_scroll.
6128 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6129 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6130 from tui_vertical_data_scroll.
6131 * tui/tui-win.h (tui_scroll): Don't declare.
6132 * tui/tui-win.c (tui_win_info::forward_scroll)
6133 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6134 (tui_win_info::right_scroll): Rename and update.
6135 (tui_scroll_forward_command, tui_scroll_backward_command)
6136 (tui_scroll_left_command, tui_scroll_right_command): Update.
6137 (tui_scroll): Remove.
6138 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6139 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6140 from tui_vertical_source_scroll.
6141 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6142 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6143 from tui_vertical_disassem_scroll.
6144 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6145 do_scroll_horizontal>: New methods.
6146 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6148 (struct tui_source_window_base): Add do_scroll_horizontal.
6149 (struct tui_source_window, struct tui_disasm_window): Add
6151 (struct tui_data_window, struct tui_cmd_window): Add
6152 do_scroll_horizontal and do_scroll_vertical.
6153 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6155 2019-06-25 Tom Tromey <tom@tromey.com>
6157 * tui/tui-data.h (struct tui_source_window_base): New struct.
6158 (struct tui_source_window): Derive from tui_source_window_base.
6159 (struct tui_disasm_window): New struct.
6160 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6161 from tui_source_window::clear_detail.
6162 (tui_source_window_base): Rename from tui_source_window.
6163 (~tui_source_window_base): Rename from ~tui_source_window.
6164 (tui_alloc_win_info): Create a tui_disasm_window.
6166 2019-06-25 Tom Tromey <tom@tromey.com>
6168 * tui/tui-data.h (struct tui_source_window)
6169 (struct tui_data_window): Declare destructors.
6170 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6172 (tui_win_info): Simplify.
6174 2019-06-25 Tom Tromey <tom@tromey.com>
6176 * tui/tui-winsource.c (tui_display_main)
6177 (tui_update_source_windows_with_addr)
6178 (tui_update_all_breakpoint_info): Update.
6179 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6180 (new_height_ok, parse_scrolling_args): Update.
6181 * tui/tui-stack.c (tui_show_frame_info): Update.
6182 * tui/tui-data.h (struct tui_list): Remove.
6183 (tui_source_windows): Return a reference to a std::vector.
6184 * tui/tui-data.c (source_windows): Now a std::vector.
6185 (tui_source_windows): Change return type.
6186 (tui_clear_source_windows): Rewrite.
6187 (tui_clear_source_windows_detail, tui_add_to_source_windows)
6188 (tui_free_all_source_wins_content): Rewrite.
6190 2019-06-25 Tom Tromey <tom@tromey.com>
6192 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6193 (struct tui_data_window, struct tui_cmd_window): Declare
6194 clear_detail method.
6195 * tui/tui-data.c (tui_source_window::clear_detail)
6196 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6198 (tui_clear_win_detail): Simplify.
6200 2019-06-25 Tom Tromey <tom@tromey.com>
6202 * tui/tui-layout.c (make_source_window, make_disasm_window)
6203 (make_source_or_disasm_window): Remove win_info_ptr parameter.
6204 Return the new window.
6205 (show_source_disasm_command, show_data)
6206 (show_source_or_disasm_and_command): Update.
6208 2019-06-25 Tom Tromey <tom@tromey.com>
6210 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6211 parameter. Return the new window.
6212 (show_source_disasm_command): Update and remove NULL check.
6213 (show_source_or_disasm_and_command): Update.
6215 2019-06-25 Tom Tromey <tom@tromey.com>
6217 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6219 2019-06-25 Tom Tromey <tom@tromey.com>
6221 * tui/tui-data.h (struct tui_win_info): Make constructor
6222 protected. Make destructor virtual. Add initializers.
6223 (tui_source_window, tui_data_window, tui_cmd_window): New
6225 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
6226 constructor. Add "type" parameter.
6227 (tui_source_window, tui_data_window, tui_cmd_window): New
6229 (tui_alloc_win_info): Instantiate the appropriate subclass.
6231 2019-06-25 Tom Tromey <tom@tromey.com>
6233 * tui/tui-win.c (tui_resize_all): Use delete.
6234 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6236 (tui_free_window): Don't declare.
6237 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6240 2019-06-25 Tom Tromey <tom@tromey.com>
6242 * tui/tui-data.h (struct tui_win_info): Add constructor.
6243 * tui/tui-data.c (tui_alloc_win_info): Use new.
6244 (tui_free_window): Use delete.
6246 2019-06-22 Tom Tromey <tom@tromey.com>
6248 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6250 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6252 2019-06-22 Tom Tromey <tom@tromey.com>
6254 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6256 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6258 2019-06-22 Tom de Vries <tdevries@suse.de>
6260 * dwarf2read.c (create_addrmap_from_aranges)
6261 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6264 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
6266 * dwarf2read.h (dwarf2_section_info_def): Remove.
6267 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6268 * dwarf2read.c (struct dwo_sections) <types>: Change type to
6269 std::vector<dwarf2_section_info>.
6270 (struct dwo_file) <~dwo_file>: Remove.
6271 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6273 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6274 (dwarf2_read_debug_names): Likewise.
6275 (create_debug_types_hash_table): Change parameter type to
6276 array_view, adjust code accordingly.
6277 (dwarf2_locate_dwo_sections): Adjust to std::vector.
6278 (partial_die_info::fixup): Likewise.
6279 (determine_prefix): Likewise.
6280 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6282 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6284 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6286 <~dwo_file>: Remove call to gdb_bfd_unref.
6287 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6288 gdb_bfd_ref_ptr::get.
6290 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6292 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6294 * dwarf2read.c (struct dwo_file): Initialize fields.
6296 (free_dwo_file): Remove, move content to ~dwo_file.
6297 (struct dwo_file_deleter): Remove.
6298 (dwo_file_up>: Remove custom deleter.
6299 (free_dwo_files): Remove.
6300 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6302 (process_skeletonless_type_units): Call unique_ptr::get.
6303 (allocate_dwo_file_hash_table): Add deleter to created hash
6304 table. Change return type to htab_up.
6305 (lookup_dwo_file_slot): Don't memset dwo_file, call
6307 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6308 (create_dwo_unit_in_dwp_v2): Likewise.
6309 (open_and_init_dwo_file): Likewise.
6310 (free_dwo_file_from_slot): Remove.
6312 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6314 * dwarf2read.h (struct dwarf2_section_info) <readin,
6315 is_virtual>: Change type to bool.
6316 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6319 2019-06-19 Tom Tromey <tom@tromey.com>
6321 * tui/tui-data.h (tui_init_content_element): Don't declare.
6323 2019-06-19 Tom Tromey <tom@tromey.com>
6325 * tui/tui-data.h (tui_init_win_info): Don't declare.
6327 2019-06-19 Tom de Vries <tdevries@suse.de>
6329 * dwarf2read.h (abstract_to_concrete): Change type to
6330 std::unordered_map<sect_offset, std::vector<sect_offset>,
6331 gdb::hash_enum<sect_offset>>.
6333 2019-06-19 Tom Tromey <tromey@adacore.com>
6335 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6336 EVAL_AVOID_SIDE_EFFECTS specially.
6338 2019-06-19 Tom Tromey <tromey@adacore.com>
6340 * source-cache.c (highlighter): New global.
6341 (source_cache::get_source_lines): Create a highlighter on demand.
6343 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
6345 * defs.h (deprecated_interactive_hook): Delete declaration.
6346 * interps.c (clear_interpreter_hooks): Remove use of
6347 deprecated_interactive_hook.
6348 * top.c (deprecated_interactive_hook): Delete definition.
6349 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6351 2019-06-18 Tom de Vries <tdevries@suse.de>
6354 * dwarf2read.h (abstract_to_concrete): Change type from
6355 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6356 std::unordered_map<sect_offset, std::vector<sect_offset>>.
6357 * dwarf2read.c (read_variable): Update.
6358 (dwarf2_fetch_die_loc_sect_off): Update.
6360 2019-06-17 Tom de Vries <tdevries@suse.de>
6363 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6364 accessing parent[parent_len - 1].
6366 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
6369 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6370 call dtrace_process_dof with NULL dof.
6372 2019-06-16 Tom de Vries <tdevries@suse.de>
6375 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6377 2019-06-16 Tom Tromey <tom@tromey.com>
6379 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6380 (make_all_visible): Use address of member.
6382 2019-06-16 Tom Tromey <tom@tromey.com>
6384 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6385 (tui_free_window, free_content, free_content_elements): Remove
6387 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6389 * tui/tui-regs.c (tui_show_register_group)
6390 (tui_display_registers_from, tui_display_reg_element_at_line):
6391 Remove unnecessary cast.
6393 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
6395 * linux-nat.c (normal_mask): Delete.
6396 (_initialize_linux_nat): Don't initialise normal_mask.
6398 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
6401 * dwarf-index-write.h (write_psymtabs_to_index): Add
6402 dwz_basename parameter.
6403 * dwarf-index-write.c (write_gdbindex): Move file writing to
6404 write_gdbindex_1. Change return type void.
6405 (assert_file_size): Move up, remove filename parameter.
6406 (write_gdbindex_1): New function.
6407 (write_debug_names): Change return type to void, call
6409 (struct index_wip_file): New struct.
6410 (write_psymtabs_to_index): Add dwz_basename parameter. Move
6411 file logic to index_wip_file. Write index for dwz file if
6413 (save_gdb_index_command): Pass basename of dwz file, if present.
6414 * dwarf-index-cache.c (index_cache::store): Obtain and pass
6415 build-id of dwz file, if present.
6416 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6417 (dwarf2_get_dwz_file): Likewise.
6418 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6419 (dwarf2_get_dwz_file): Likewise.
6421 2019-06-16 Tom Tromey <tom@tromey.com>
6423 * coffread.c (process_coff_symbol): Use xstrdup.
6424 * value.c (create_internalvar): Use xstrdup.
6426 2019-06-16 Tom Tromey <tom@tromey.com>
6428 * valops.c (value_cast, value_slice): Remove unnecessary cast.
6429 * breakpoint.c (stopin_command, stopat_command)
6430 (until_break_command, decode_location_default): Remove unnecessary
6432 * utils.c (subset_compare): Remove unnecessary cast.
6433 * ada-lang.c (ada_update_initial_language): Remove unnecessary
6435 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6437 * infcmd.c (path_command): Remove unnecessary cast.
6438 * coffread.c (decode_type): Remove unnecessary cast.
6439 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6440 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6441 * tui/tui-stack.c (tui_show_locator_content)
6442 (tui_show_frame_info): Remove unnecessary cast.
6443 * tui/tui-win.c (tui_scroll_forward_command)
6444 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6445 (parse_scrolling_args): Remove unnecessary cast.
6446 * tui/tui-data.c (init_win_info, tui_del_window)
6447 (tui_free_window, tui_del_data_windows, tui_free_data_content)
6448 (free_content_elements): Remove unnecessary cast.
6449 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6451 * tui/tui-source.c (tui_set_source_content)
6452 (tui_vertical_source_scroll): Remove unnecessary cast.
6453 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6455 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6456 * tui/tui-regs.c (tui_display_registers_from)
6457 (tui_display_register): Remove unnecessary cast.
6458 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6459 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6460 (make_visible): Remove unnecessary cast.
6461 * tui/tui-winsource.c (tui_erase_source_content)
6462 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6464 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6465 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6466 * stabsread.c (read_type, read_array_type, read_range_type):
6467 Remove unnecessary cast.
6468 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6469 (parse_symbol, parse_type, upgrade_type, parse_external)
6470 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6472 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6474 2019-06-16 Tom Tromey <tom@tromey.com>
6476 * tui/tui-data.c (tui_alloc_generic_win_info)
6477 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6480 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
6481 Andrew Burgess <andrew.burgess@embecosm.com>
6483 * f-typeprint.c (f_print_type): Don't return early for not
6484 associated or not allocated types.
6485 (f_type_print_varspec_suffix): Add print_rank parameter and print
6486 ranks of array types in case they dangling.
6487 (f_type_print_base): Add print_rank parameter.
6489 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6491 * NEWS: Mention new MI commands.
6492 * break-catch-throw.c (enum exception_event_kind): Move to
6494 (print_mention_exception_catchpoint): Output text as a single
6496 (catch_exception_command_1): Rename to...
6497 (catch_exception_event): ...this, make non-static, update header
6498 command, and change some parameter types.
6499 (catch_catch_command): Update for changes to
6500 catch_exception_command_1.
6501 (catch_throw_command): Likewise.
6502 (catch_rethrow_command): Likewise.
6503 * breakpoint.c (enum exception_event_kind): Delete.
6504 * breakpoint.h (enum exception_event_kind): Moved here from
6505 break-catch-throw.c.
6506 (catch_exception_event): Declare.
6507 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6508 (mi_cmd_catch_throw): New function.
6509 (mi_cmd_catch_rethrow): New function.
6510 (mi_cmd_catch_catch): New function.
6511 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6512 'catch-catch' entries.
6513 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6514 (mi_cmd_catch_rethrow): Declare.
6515 (mi_cmd_catch_catch): Declare.
6517 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6519 * annotate.c (annotate_source_line): Change return type to void,
6520 update implementation to match.
6521 * annotate.h (annotate_source_line): Change return type to void,
6522 update header comment.
6523 * stack.c (print_frame_info): Don't change what frame information
6524 is printed based on whether annotations are on or not.
6526 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6528 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6529 (annotate_source): Make static.
6530 (annotate_source_line): Moved from source.c and renamed from
6531 identify_source_line. Update the return type.
6532 * annotate.h (annotate_source): Delete declaration.
6533 (annotate_source_line): Declaration moved from source.h, and
6534 renamed from identify_source_line. Return type updated.
6535 * source.c (identify_source_line): Moved to annotate.c and renamed
6536 to annotate_source_line.
6537 (info_line_command): Remove check of annotation_level.
6538 * source.h (identify_source_line): Move declaration to annotate.h
6539 and rename to annotate_source_line.
6540 * stack.c: Add 'annotate.h' include.
6541 (print_frame_info): Remove check of annotation_level before
6542 calling annotate_source_line.
6544 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6546 * source-cache.c (source_cache::get_plain_source_lines): Use
6547 open_source_file_with_line_charpos instead of just
6548 open_source_file, remove call to find_source_lines.
6549 (source_cache::get_source_lines): Likewise.
6550 * source.c (find_source_lines): Make static.
6551 (get_filename_and_charpos): Renamed into...
6552 (open_source_file_with_line_charpos): ..this along with changes to
6553 return a scoped_fd, and some other minor clean ups.
6554 (identify_source_line): Use open_source_file_with_line_charpos.
6555 (search_command_helper): Use open_source_file_with_line_charpos
6556 instead of just open_source_file, remove call to
6558 * source.h (open_source_file_with_line_charpos): Declare new
6560 (find_source_lines): Delete declaration.
6562 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6564 * source.c (get_filename_and_charpos): Remove fullname
6566 (identify_source_line): Update call to get_filename_and_charpos.
6568 2019-06-14 Tom Tromey <tromey@adacore.com>
6571 * ui-style.h (skip_ansi_escape): Update comment.
6572 * ui-file.h (class no_terminal_escape_file): New class.
6573 * ui-file.c (no_terminal_escape_file::write)
6574 (no_terminal_escape_file::puts): New methods.
6575 * cli/cli-logging.c (handle_redirections): Use
6576 no_terminal_escape_file.
6578 2019-06-14 Tom Tromey <tromey@adacore.com>
6580 * NEWS: Move convenience variable news above Python news.
6582 2019-06-14 Tom Tromey <tom@tromey.com>
6584 * gnulib: Move directory to top-level.
6585 * configure.ac: Don't configure gnulib.
6586 * configure: Rebuild.
6587 * common/common-defs.h: Use new path to gnulib.
6588 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6590 (INCGNU): Look in new gnulib location.
6591 (HFILES_NO_SRCDIR): Remove gnulib files.
6592 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6593 (generated_files): Remove GNULIB_H.
6594 ($(LIBGNU), all-lib): Remove targets.
6595 (distclean): Don't mention GNULIB_BUILDDIR.
6596 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6598 2019-06-14 Tom Tromey <tromey@adacore.com>
6600 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6601 Warn if symbol file does not provide any symbols.
6603 2019-06-14 Tom Tromey <tromey@adacore.com>
6605 * source.c (find_and_open_source): Respect basenames_may_differ.
6607 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6609 * annotate.c (annotate_breakpoints_invalid): Make use of
6610 scoped_restore_terminal_state.
6611 (annotate_frames_invalid): Likewise.
6613 2019-06-14 Tom Tromey <tromey@adacore.com>
6615 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6616 allow assignment to an internalvar.
6618 2019-06-14 Tom Tromey <tromey@adacore.com>
6620 * ada-lex.l: Allow "_" in attribute names.
6622 2019-06-14 Tom Tromey <tromey@adacore.com>
6625 * regcache.c (registers_changed): Don't call alloca.
6626 * top.c (execute_command): Don't call alloca.
6628 2019-06-13 Pedro Alves <palves@redhat.com>
6630 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6631 'expression'. When parsing an expression, error out if there's
6632 junk after "unlimited".
6633 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6634 (do_set_command): Adjust calls to is_unlimited_literal.
6636 2019-06-13 Pedro Alves <palves@redhat.com>
6638 * compile/compile.c (make_compile_options_def_group): Add braces
6639 around array_view initializer.
6640 * thread.c (make_thread_apply_all_options_def_group)
6641 (make_thread_apply_all_options_def_group): Likewise.
6643 2019-06-13 Pedro Alves <palves@redhat.com>
6645 * NEWS (New commands): Mention "maint test-options
6646 require-delimiter", "maint test-options unknown-is-error", "maint
6647 test-options unknown-is-operand" and "maint show
6648 test-options-completion-result".
6649 (New command options, command completion): New section.
6650 (Completion improvements): New section.
6651 Mention that you can abbreviate "unlimited".
6653 2019-06-13 Pedro Alves <palves@redhat.com>
6655 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6656 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6657 * unittests/cli-utils-selftests.c (test_parse_flags)
6658 (test_parse_flags_qcs): Delete.
6659 (test_cli_utils): Don't call deleted functions.
6661 2019-06-13 Pedro Alves <palves@redhat.com>
6663 * thread.c: Include "cli/cli-option.h".
6664 (tp_array_compar_ascending): Global.
6665 (tp_array_compar): Delete function.
6666 (tp_array_compar_ascending, tp_array_compar_descending): New
6668 (ascending_option_def, qcs_flag_option_def)
6669 (thr_qcs_flags_option_defs)
6670 (make_thread_apply_all_options_def_group)
6671 (make_thread_apply_options_def_group): New.
6672 (thread_apply_all_command): Use gdb::option::process_options.
6673 (thread_apply_command_completer)
6674 (thread_apply_all_command_completer): New.
6675 (thread_apply_command): Use gdb::option::process_options.
6676 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6677 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6678 to generate help text of "thread apply". Adjust "taas"'s help.
6679 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6680 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6682 2019-06-13 Pedro Alves <palves@redhat.com>
6684 * thread.c (thread_apply_command): Check for invalid TID with
6685 isdigit instead of !isalpha.
6687 2019-06-13 Pedro Alves <palves@redhat.com>
6689 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6690 (validate_flags_qcs): New.
6691 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6692 (validate_flags_qcs): Declare.
6693 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6694 (make_frame_apply_options_def_group): New.
6695 (frame_apply_command_count): Process options with
6696 gdb::option::process_options.
6697 (frame_apply_completer): New.
6698 (frame_apply_level_completer, frame_apply_all_completer)
6699 (frame_apply_completer): New.
6700 (_initialize_stack): Update help of "frame apply", "frame apply
6701 level", "frame apply all" and "faas" to mention supported options
6702 and install command completers.
6703 * stack.h (frame_apply_all_completer): Declare.
6704 * thread.c: Include "stack.h".
6705 (tfaas_command): Add "--".
6706 (_initialize_thread): Update help "tfaas" to mention supported
6707 options and install command completer.
6709 2019-06-13 Pedro Alves <palves@redhat.com>
6711 * completer.c (complete_nested_command_line): New.
6712 (gdb_completion_word_break_characters_throw): Add assertion.
6713 * completer.h (complete_nested_command_line): Declare.
6715 2019-06-13 Pedro Alves <palves@redhat.com>
6717 * stack.c (parse_backtrace_qualifiers): New.
6718 (backtrace_command): Use it.
6719 (backtrace_command_completer): Complete on qualifiers.
6721 2019-06-13 Pedro Alves <palves@redhat.com>
6723 * frame.c: Include "cli/cli-option.h.
6724 (user_set_backtrace_options): New.
6725 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6727 (get_prev_frame): Adjust.
6728 (boolean_option_def, uinteger_option_def)
6729 (set_backtrace_option_defs): New.
6730 (_initialize_frame): Adjust and use
6731 gdb::option::add_setshow_cmds_for_options to install "set
6732 backtrace past-main" and "set backtrace past-entry".
6733 * frame.h: Include "cli/cli-option.h".
6734 (struct frame_print_options): Forward declare.
6735 (print_frame_arguments_all, print_frame_arguments_scalars)
6736 (print_frame_arguments_none): Declare.
6737 (print_entry_values): Delete declaration.
6738 (struct frame_print_options, user_frame_print_options): New.
6739 (struct set_backtrace_options): New.
6740 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6741 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6742 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6743 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6744 (list_args_or_locals): Add frame_print_options parameter.
6745 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6746 * python/py-framefilter.c (enumerate_args): Pass down
6747 USER_FRAME_PRINT_OPTIONS.
6748 * stack.c: Include "cli/cli-option.h".
6749 (print_frame_arguments_all, print_frame_arguments_scalars)
6750 (print_frame_arguments_none): Declare.
6751 (print_raw_frame_arguments, print_entry_values): Delete.
6752 (user_frame_print_options): New.
6753 (boolean_option_def, enum_option_def, frame_print_option_defs):
6755 (struct backtrace_cmd_options): New.
6756 (bt_flag_option_def): New.
6757 (backtrace_command_option_defs): New.
6758 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6759 (print_frame_arg, read_frame_arg, print_frame_args)
6760 (print_frame_info, print_frame): Add frame_print_options parameter
6762 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6763 (backtrace_command_1): Add frame_print_options and
6764 backtrace_cmd_options parameters and use them.
6765 (make_backtrace_options_def_group): New.
6766 (backtrace_command): Process command options with
6767 gdb::option::process_options.
6768 (backtrace_command_completer): New.
6769 (_initialize_stack): Extend "backtrace"'s help to mention
6770 supported options. Install completer for "backtrace".
6771 Install some settings commands with add_setshow_cmds_for_options.
6773 2019-06-13 Pedro Alves <palves@redhat.com>
6775 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6776 and that "set/show print raw frame-arguments" are now deprecated.
6778 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6780 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6781 * stack.c (_initialize_stack): Install "set/show print
6782 raw-frame-arguments", and deprecate "set/show print raw
6784 * valprint.c (_initialize_valprint): Deprecate "set/show print
6787 2019-06-13 Pedro Alves <palves@redhat.com>
6789 * compile/compile.c (struct compile_options): New.
6790 (compile_flag_option_def, compile_command_option_defs)
6791 (make_compile_options_def_group): New.
6792 (compile_file_command): Handle options with
6793 gdb::option::process_options.
6794 (compile_file_command_completer): New function.
6795 (compile_code_command): Handle options with
6796 gdb::option::process_options.
6797 (compile_code_command_completer): New function.
6798 (_initialize_compiler): Install completers for "compile code" and
6799 "compile file". Mention available options in "compile code" and
6800 "compile code"'s help.
6801 * completer.c (advance_to_completion_word): New, factored out from
6803 (advance_to_expression_complete_word_point): ... this.
6804 (advance_to_filename_complete_word_point): New.
6805 * completer.h (advance_to_filename_complete_word_point): New
6808 2019-06-13 Pedro Alves <palves@redhat.com>
6810 * compile/compile.c: Include "cli/cli-option.h".
6811 (compile_print_value): Scope data pointer is now a
6812 value_print_options pointer; adjust.
6813 (compile_print_command): Process options. Scope data pointer is
6814 now a value_print_options pointer; adjust.
6815 (_initialize_compile): Update "compile print"'s help to include
6816 supported options. Install a completer for "compile print".
6817 * cp-valprint.c (show_vtblprint, show_objectprint)
6818 (show_static_field_print): Delete.
6819 (_initialize_cp_valprint): Don't install "set print
6820 static-members", "set print vtbl", "set print object" here.
6821 * printcmd.c: Include "cli/cli-option.h" and
6822 "common/gdb_optional.h".
6823 (print_command_parse_format): Rework to fill in a
6824 value_print_options instead of a format_data.
6825 (print_value): Change parameter type from format_data pointer to
6826 value_print_options reference. Adjust.
6827 (print_command_1): Process options. Adjust to pass down a
6828 value_print_options.
6829 (print_command_completer): New.
6830 (_initialize_printcmd): Install print_command_completer as
6831 handle_brkchars completer for the "print" command. Update
6832 "print"'s help to include supported options.
6833 * valprint.c: Include "cli/cli-option.h".
6834 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6835 here from cp-valprint.c.
6836 (boolean_option_def, uinteger_option_def)
6837 (value_print_option_defs, make_value_print_options_def_group):
6838 New. Use gdb::option::add_setshow_cmds_for_options to install
6839 "set print elements", "set print null-stop", "set print repeats",
6840 "set print pretty", "set print union", "set print array", "set
6841 print address", "set print symbol", "set print array-indexes".
6842 * valprint.h: Include <string> and "cli/cli-option.h".
6843 (make_value_print_options_def_group): Declare.
6844 (print_value): Change parameter type from format_data pointer to
6845 value_print_options reference.
6846 (print_command_completer): Declare.
6848 2019-06-13 Pedro Alves <palves@redhat.com>
6850 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6851 (COMMON_SFILES): Add maint-test-settings.c.
6852 * cli/cli-decode.c (boolean_enums): New global, factored out from
6854 (add_setshow_boolean_cmd): ... here.
6855 * cli/cli-decode.h (boolean_enums): Declare.
6856 * cli/cli-option.c: New file.
6857 * cli/cli-option.h: New file.
6858 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6859 factored out from ...
6860 (parse_cli_boolean_value(const char *)): ... this.
6861 (is_unlimited_literal): Change parameter type to pointer to
6862 pointer. Adjust and advance ARG pointer.
6863 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6864 (parse_cli_var_enum): New, factored out from ...
6865 (do_set_command): ... this. Adjust.
6866 * cli/cli-setshow.h (parse_cli_boolean_value)
6867 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6868 (parse_cli_var_enum): Declare.
6869 * cli/cli-utils.c: Include "cli/cli-option.h".
6870 (get_ulongest): New.
6871 * cli/cli-utils.h (get_ulongest): Declare.
6872 (check_for_argument): New overloads.
6873 * maint-test-options.c: New file.
6875 2019-06-13 Pedro Alves <palves@redhat.com>
6877 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6878 parse a range if "-" is at the end of the string.
6880 2019-06-13 Pedro Alves <palves@redhat.com>
6882 * cli/cli-setshow.c (parse_auto_binary_operation)
6883 (parse_cli_boolean_value): Don't allow "o".
6885 2019-06-13 Pedro Alves <palves@redhat.com>
6887 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6888 * NEWS: Mention maint test-settings KIND.
6889 * maint-test-settings.c: New file.
6891 2019-06-13 Pedro Alves <palves@redhat.com>
6893 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6895 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6898 2019-06-13 Pedro Alves <palves@redhat.com>
6900 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6903 2019-06-13 Pedro Alves <palves@redhat.com>
6905 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6907 2019-06-13 Pedro Alves <palves@redhat.com>
6909 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6910 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6912 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6913 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6915 (check_for_argument): Skip spaces after argument.
6917 2019-06-13 Pedro Alves <palves@redhat.com>
6919 * thread.c (thread_apply_command): Adjust TID parsing.
6920 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6921 detected before end of string.
6922 (tid_is_in_list): Error out if LIST is invalid.
6924 2019-06-13 Pedro Alves <palves@redhat.com>
6926 * completer.c (complete_line_internal_1): Rewind completion word
6928 (completion_tracker::advance_custom_word_point_by): Change
6929 parameter type to int.
6930 * completer.h (completion_tracker::advance_custom_word_point_by):
6933 2019-06-13 Pedro Alves <palves@redhat.com>
6935 * completer.c (advance_to_completion_word): Handle delimiters.
6937 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6939 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6941 2019-06-11 Tom Tromey <tom@tromey.com>
6943 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6944 (xmalloc_failed): Move to alloc.c.
6945 * alloc.c: New file.
6946 * Makefile.in (COMMON_SFILES): Add alloc.c.
6948 2019-06-11 Tom Tromey <tom@tromey.com>
6950 * nat/linux-waitpid.c: Don't include server.h.
6951 (linux_debug): Remove.
6952 (my_waitpid): Update.
6954 2019-06-11 Tom Tromey <tromey@adacore.com>
6956 * infcall.c (_initialize_infcall): Remove trailing newline from
6958 * user-regs.c (_initialize_user_regs): Remove trailing newline
6960 * typeprint.c (_initialize_typeprint): Remove trailing newline
6962 * reverse.c (_initialize_reverse): Remove trailing newlines from
6964 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6966 * language.c (add_set_language_command): Remove trailing newline
6968 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6970 * disasm.c (_initialize_disasm): Remove trailing newline from
6972 * top.c (init_main): Remove trailing newline from help.
6973 * interps.c (_initialize_interpreter): Remove trailing newline
6975 * btrace.c (_initialize_btrace): Remove trailing newlines from
6977 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6979 * python/python.c (_initialize_python): Remove trailing newline
6981 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6983 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6984 from help. Reformat some text.
6985 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6987 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6990 2019-06-11 Tom Tromey <tromey@adacore.com>
6992 * darwin-nat.c (darwin_decode_exception_message)
6993 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6995 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6997 * valops.c (value_slice): Check for not allocated or not
7000 2019-06-10 Tom de Vries <tdevries@suse.de>
7003 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7004 sure an empty slot (defined by a 32-bit zero pair) is recognized as
7007 2019-06-10 Tom de Vries <tdevries@suse.de>
7010 * linespec.c (linespec_lexer_lex_string): Remove incorrect
7011 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
7013 2019-06-10 Tom de Vries <tdevries@suse.de>
7016 * symtab.c (struct demangled_name_entry): Add language field.
7017 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
7018 static minimal symbol". Set and use language field.
7020 2019-06-10 Tom Tromey <tromey@adacore.com>
7022 * ada-lang.c (_initialize_ada_language): Update help text.
7024 2019-06-10 Tom Tromey <tromey@adacore.com>
7026 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7028 * guile/guile.c (handle_boot_error): Don't end warning with a
7030 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7031 warning with a newline.
7032 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7034 (s12z_frame_cache): Likewise.
7035 * dwarf-index-cache.c (index_cache::store): Don't end warning with
7037 * solib-svr4.c (disable_probes_interface): Don't end warning with
7039 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7041 * python/python.c (do_finish_initialization): Don't end warning
7044 2019-06-10 Tom Tromey <tom@tromey.com>
7046 * python/py-breakpoint.c (gdbpy_breakpoint_created)
7047 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7050 2019-06-10 Tom Tromey <tromey@adacore.com>
7052 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7054 (elf_new_init): Don't call stabsread_new_init.
7055 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7056 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
7057 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7059 2019-06-10 Tom de Vries <tdevries@suse.de>
7063 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7065 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
7067 * source.c (find_and_open_source): Also rewrite relative file
7070 2019-04-26 Amos Bird <amosbird@gmail.com>
7072 * annotate.c (annotate_thread_exited): Add "thread-exited"
7075 2019-06-06 Tom Tromey <tromey@adacore.com>
7077 * maint.h (class scoped_command_stats): Use
7078 DISABLE_COPY_AND_ASSIGN.
7079 <print_time>: New method.
7080 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7082 (scoped_command_stats::print_time): New method.
7084 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
7086 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7087 instructions of lengths 6 or 8 bytes.
7089 2019-06-04 Pedro Alves <palves@redhat.com>
7091 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7093 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7094 * breakpoint.c (condition_completer): Likewise.
7095 * cli/cli-dump.c (scan_expression): Likewise.
7096 * common/filestuff.c (mkdir_recursive): Likewise.
7097 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7098 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7099 (gdb_abspath): Likewise.
7100 * compile/compile-cplus-types.c
7101 (compile_cplus_instance::decl_name): Likewise.
7102 * completer.c (complete_explicit_location):
7103 (signal_completer, reg_or_group_completer_1): Likewise.
7104 * cp-support.c (cp_remove_params_if_any): Likewise.
7105 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7106 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7107 * infcmd.c (strip_bg_char): Likewise.
7108 * linespec.c (copy_token_string): Likewise.
7109 * mi/mi-main.c (output_cores): Likewise.
7110 * psymtab.c (psymtab_search_name):
7111 * symfile.c (test_set_ext_lang_command): Likewise.
7112 * target.c (target_fileio_read_stralloc): Likewise.
7113 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7114 * value.c (complete_internalvar): Likewise.
7116 2019-06-04 Christian Biesinger <cbiesinger@google.com>
7118 Add objfile property to gdb.Type.
7119 * NEWS: Mention Python API addition.
7120 * python/py-type.c (typy_get_objfile): New method.
7122 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7124 * NEWS: Mention the new set|show style [title|highlight].
7125 Mention changes to "show style", "help" and "apropos".
7127 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7129 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7130 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
7131 instead of print_help_for_command.
7132 (print_doc_of_command): New function.
7133 (help_list): Add 'apropos -v word' suggestion.
7134 (print_help_for_command): Style the command name using title style.
7135 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7136 (_initialize_cli_cmds): Describe -v in apropos_command help.
7138 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7140 * cli/cli-style.h (cli_style_option): Add name in constructor,
7141 add m_name class member, add constructor with intensity,
7142 add name class function.
7143 (cli_style_option::add_setshow_commands): Remove name argument.
7144 (highlight_style, title_style): New styles.
7145 * cli/cli-style.c (do_show): New function that shows a style
7146 characteristic styling the style name with itself.
7147 (set_style_name): New function.
7148 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7149 Update all callers according to the changes in cli/cli-style.h.
7150 * utils.h (fputs_highlighted): New function.
7151 * utils.c (fputs_highlighted): Likewise.
7153 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7155 * NEWS: Mention new pipe command and new convenience variables.
7157 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7159 * cli/cli-cmds.c (pipe_command): New function.
7160 (_initialize_cli_cmds): Call add_com for pipe_command.
7161 Define | as an alias for pipe.
7162 (exit_status_set_internal_vars): New function.
7163 (shell_escape): Call exit_status_set_internal_vars.
7164 cli/cli-decode.c (find_command_name_length): Recognize | as
7165 a single character command.
7167 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7169 * gdbcmd.h (execute_command_to_ui_file): New declaration.
7170 top.c (execute_command_to_ui_file): New function, mostly a copy
7171 of execute_command_to_string.
7172 (execute_command_to_string): Implement by calling
7173 execute_command_to_ui_file.
7175 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7177 * top.h (saved_command_line): Remove declaration.
7178 * top.c (previous_saved_command_line, previous_repeat_arguments):
7180 (saved_command_line): Make static, define together with other
7182 (dont_repeat): Clear repeat_arguments.
7183 (repeat_previous, get_saved_command_line, save_command_line):
7185 (gdb_init): Initialize saved_command_line
7186 and previous_saved_command_line.
7187 * main.c (captured_main_1): Remove saved_command_line initialization.
7188 * event-top.c (handle_line_of_input): Update to use
7189 the new 'repeat' related functions instead of direct access to
7191 * command.h (repeat_previous, get_saved_command_line,
7192 save_command_line): New declarations.
7193 (dont_repeat): Add comment.
7195 2019-05-30 Tom Tromey <tromey@adacore.com>
7197 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7199 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7201 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
7204 * completer.c (complete): Initialize variable word.
7206 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
7208 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7209 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7210 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7211 'body' is NULL to the outter 'if', protecting the '!is_define'
7214 2019-05-29 Tom Tromey <tromey@adacore.com>
7216 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7217 (dwarf_unknown): New function.
7218 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7219 (dwarf_type_encoding_name): Use dwarf_unknown.
7221 2019-05-29 Tom Tromey <tromey@adacore.com>
7224 * cp-valprint.c (cp_print_value_fields): Call
7225 cp_print_static_field inside "try".
7227 2019-05-29 Tom Tromey <tromey@adacore.com>
7229 * inflow.c (struct terminal_info): Add default operator=.
7230 * configure: Rebuild.
7231 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7232 -Wdeprecated-copy-dtor, -Wredundant-move.
7234 2019-05-29 Tom Tromey <tromey@adacore.com>
7237 * infcmd.c (print_return_value_1): Handle finish_print
7239 (show_print_finish): New function.
7240 (_initialize_infcmd): Add "set/show print finish" commands.
7241 * valprint.c (user_print_options): Initialize new member.
7242 * valprint.h (struct value_print_options) <finish_print>: New
7245 2019-05-28 Tom Tromey <tromey@adacore.com>
7247 * ada-lang.c (ada_remove_Xbn_suffix)
7248 (find_old_style_renaming_symbol)
7249 (parse_old_style_renaming): Remove.
7250 (ada_find_renaming_symbol): Don't call
7251 find_old_style_renaming_symbol.
7252 (ada_is_renaming_symbol): Rename from
7253 ada_find_renaming_symbol. Remove "block" parameter. Return
7255 (ada_read_var_value): Update and simplify.
7256 * ada-exp.y (write_var_or_type): Remove old code.
7258 2019-05-28 Alan Hayward <alan.hayward@arm.com>
7261 * event-top.c: Remove include comment.
7262 * inflow.c (class scoped_ignore_sigttou): Move from here...
7263 * inflow.h (class scoped_ignore_sigttou): ...to here.
7264 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7265 * top.c: Remove include comment.
7267 2019-05-27 Tom Tromey <tom@tromey.com>
7271 2019-05-22 Tom Tromey <tromey@adacore.com>
7273 * target.c (target_follow_exec): Constify parameter.
7274 * target-delegates.c: Rebuild.
7275 * remote.c (remote_target::follow_exec): Constify parameter.
7276 * infrun.c (follow_exec): Constify parameter.
7277 * target.h (struct target_ops) <follow_exec>: Constify parameter.
7278 (target_follow_exec): Likewise.
7280 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7282 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7283 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7285 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7287 * NEWS: Add debugredirect and testsuite sections.
7289 2019-05-22 Simon Cook <simon.cook@embecosm.com>
7291 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7292 target descriptions using exclusively floating point register name
7295 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
7298 * f-lang.c (build_fortran_types): Handle the case where
7299 gdbarch_floatformat_for_type returns a nullptr.
7301 2019-05-21 Tom de Vries <tdevries@suse.de>
7304 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7306 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7309 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7311 * i386-tdep.c (i386_floatformat_for_type): Use
7312 floatformats_ia64_quad for the 16-byte floating point component
7313 within a fortran 32-byte complex number.
7315 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7317 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7318 delete default constructor.
7319 (find_partial_die): Update to return const struct.
7320 (partial_die_parent_scope): Move variable declaration into scope
7321 of its use and change its type to auto.
7322 (guess_partial_die_structure_name): Likewise.
7323 (partial_die_info::fixup): Likewise.
7325 2019-05-17 Tom Tromey <tromey@adacore.com>
7327 * source.c (find_and_open_source): Remove cast.
7329 2019-05-17 Tom Tromey <tromey@adacore.com>
7331 * annotate.c (annotate_source): Make "filename" const.
7332 * annotate.h (annotate_source): Use const.
7334 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7336 * disasm.c (set_disassembler_options): Send errors to stderr.
7338 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7340 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7341 (cli_interp_base::set_logging): Check debug_redirect.
7342 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7343 * cli/cli-logging.c (debug_redirect): Add static variable.
7344 (pop_output_files): Add default param.
7345 (handle_redirections): Print debug setting.
7346 (show_logging_command): Likewise.
7347 (_initialize_cli_logging): Add debugredirect command.
7348 * interps.c (current_interp_set_logging): Add debug_redirect
7350 * interps.h (set_logging): Add debug_redirect parameter.
7351 (current_interp_set_logging): Likewise.
7352 * mi/mi-common.h: Likewise.
7353 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7355 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7356 Tom Tromey <tromey@adacore.com>
7358 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7360 * cli/cli-interp.h (make_logging_output): Remove declaration.
7361 * cli/cli-logging.c (make_logging_output): Remove function.
7362 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7364 * ui-file.c (tee_file::tee_file): Remove bools.
7365 (tee_file::~tee_file): Remove deletes.
7366 * ui-file.h (tee_file): Remove bools.
7368 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
7370 * mi/mi-cmds.h (mi_cmd_complete): New function.
7371 * mi/mi-main.c (mi_cmd_complete): Likewise.
7372 * mi/mi-cmds.c: Define new MI command -complete.
7373 * NEWS: Mention new -complete command.
7375 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
7377 * completer.h (complete): New function.
7378 * completer.c (complete): Likewise.
7379 * cli/cli-cmds.c: (complete_command): Update to use new complete()
7380 function defined in completer.h.
7382 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
7384 * MAINTAINERS (Write After Approval): Add myself.
7386 2019-05-17 Tom de Vries <tdevries@suse.de>
7389 * dwarf2read.c (struct cu_partial_die_info): New struct.
7390 (find_partial_die): Return cu_partial_die_info.
7391 (partial_die_parent_scope, guess_partial_die_structure_name)
7392 (partial_die_info::fixup): Handle new return type of find_partial_die.
7394 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7396 PR breakpoints/24541
7397 * stap-probe.c (stap_parse_register_operand): Make "regname" an
7398 "std::string", simplifying the algorithm.
7400 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7402 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7403 (stap_static_probe_ops::get_probes): Likewise.
7405 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7407 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7408 '-')" and "else if".
7409 (stap_parse_single_operand): Join checks for
7410 "gdbarch_stap_parse_special_token_p" and
7411 "gdbarch_stap_parse_special_token" in the same "if" statement.
7412 Invert check when verifying for operation on register
7415 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7417 * stap-probe.c (stap_get_opcode): Update comment.
7418 (stap_get_expected_argument_type): Likewise.
7419 (handle_stap_probe): Likewise.
7421 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7423 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7424 return type to 'bool'. Adjust comment. Use 'bool' when
7426 (i386_stap_parse_special_token_three_arg_disp): Likewise.
7427 * stap-probe.c (stap_parse_argument_1): Likewise.
7428 (stap_is_operator): Likewise.
7429 (stap_is_generic_prefix): Likewise.
7430 (stap_is_register_prefix): Likewise.
7431 (stap_is_register_indirection_prefix): Likewise.
7432 (stap_is_integer_prefix): Likewise.
7433 (stap_generic_check_suffix): Likewise.
7434 (stap_check_integer_suffix): Likewise.
7435 (stap_check_register_suffix): Likewise.
7436 (stap_check_register_indirection_suffix): Likewise.
7437 (stap_parse_register_operand): Likewise.
7438 (stap_parse_single_operand): Likewise.
7439 (stap_parse_argument_1): Likewise.
7440 (stap_probe::get_argument_count): Likewise.
7441 (stap_is_operator): Likewise.
7443 2019-05-16 Tom Tromey <tromey@adacore.com>
7445 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7448 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
7450 * linux-thread-db.c (try_thread_db_load_1): Change return type
7452 (try_thread_db_load): Likewise.
7453 (try_thread_db_load_from_pdir_1): Likewise.
7454 (try_thread_db_load_from_pdir): Likewise.
7455 (try_thread_db_load_from_sdir): Likewise.
7456 (try_thread_db_load_from_dir): Likewise.
7457 (thread_db_load_search): Likewise.
7458 (has_libpthread): Likewise.
7459 (thread_db_load): Likewise.
7461 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
7463 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7464 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7465 NULL, and complain/return if that's the case.
7467 2019-05-15 John Darrington <john@darrington.wattle.id.au>
7469 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7470 (advance, posn, abstract_read_memory): New functions.
7471 [struct mem_read_abstraction]: New struct.
7472 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7474 2019-05-14 Tom Tromey <tromey@adacore.com>
7476 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7477 value is not lval_memory.
7479 2019-05-14 Tom Tromey <tromey@adacore.com>
7481 * solib.c (info_sharedlibrary_command): Style the file name.
7483 2019-05-14 Alan Hayward <alan.hayward@arm.com>
7485 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7486 (aarch64_vnv_type): Likewise.
7487 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7488 * common/tdesc.c: Likewise.
7489 * common/tdesc.h (enum tdesc_type_kind): Likewise.
7490 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7491 * features/aarch64-fpu.xml: Add ieee half view.
7492 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7493 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7494 * gdbtypes.h (struct builtin_type): Likewise.
7495 (struct objfile_type): Likewise.
7497 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
7499 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7501 * location.h (string_to_event_location): Likewise.
7503 2019-05-11 Joel Brobecker <brobecker@adacore.com>
7507 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
7509 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7510 New variable declaration.
7511 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7513 (print_one_breakpoint): Use ui_out::test_flags and new global
7514 variable to compute use_fixed_output.
7515 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7517 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7518 (mi_multi_location_breakpoint_output_fixed): Remove.
7519 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7521 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7522 fix_multi_location_breakpoint_output flag if version >= 3.
7523 * ui-out.h (enum ui_out_flag)
7524 <fix_multi_location_breakpoint_output>: New enumerator.
7526 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
7528 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7530 2019-05-10 Tom Tromey <tromey@adacore.com>
7532 * ada-lang.c (catch_ada_completer): New function.
7533 (_initialize_ada_language): Use it.
7535 2019-05-10 Tom Tromey <tromey@adacore.com>
7537 * thread.c (print_thread_info): Make "requested_threads" const.
7538 * gdbthread.h (print_thread_info): Make "requested_threads"
7540 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7541 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7543 2019-05-08 Tom Tromey <tom@tromey.com>
7545 * gdbtypes.c (objfile_type_data): Change type.
7546 (objfile_type, _initialize_gdbtypes): Update.
7548 2019-05-08 Tom Tromey <tom@tromey.com>
7550 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7551 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7552 (_initialize_dwarf2_frame): Update.
7554 2019-05-08 Tom Tromey <tom@tromey.com>
7556 * objc-lang.c (objc_objfile_data): Change type.
7557 (find_methods): Update.
7558 (_initialize_objc_lang): Remove.
7560 2019-05-08 Tom Tromey <tom@tromey.com>
7562 * stabsread.c (rs6000_builtin_type_data): Change type.
7563 (rs6000_builtin_type, _initialize_stabsread): Update.
7565 2019-05-08 Tom Tromey <tom@tromey.com>
7567 * mips-tdep.c (mips_pdr_data): Remove.
7568 (_initialize_mips_tdep): Update.
7570 2019-05-08 Tom Tromey <tom@tromey.com>
7572 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7573 (hppa_init_objfile_priv_data, read_unwind_info)
7574 (find_unwind_entry, _initialize_hppa_tdep): Update.
7576 2019-05-08 Tom Tromey <tom@tromey.com>
7578 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7579 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7581 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7583 2019-05-08 Tom Tromey <tom@tromey.com>
7585 * mdebugread.c (basic_type_data): Change type.
7586 (basic_type, _initialize_mdebugread): Update.
7588 2019-05-08 Tom Tromey <tom@tromey.com>
7590 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7592 2019-05-08 Tom Tromey <tom@tromey.com>
7594 * nto-tdep.c (nto_inferior_data_reg): Change type.
7595 (nto_inferior_data): Update.
7596 (nto_inferior_data_cleanup, nto_new_inferior_data)
7597 (_initialize_nto_tdep): Remove.
7598 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7600 2019-05-08 Tom Tromey <tom@tromey.com>
7602 * ada-lang.c (struct ada_inferior_data): Add initializers.
7603 (ada_inferior_data): Change type.
7604 (ada_inferior_data_cleanup): Remove.
7605 (get_ada_inferior_data, ada_inferior_exit)
7606 (struct ada_pspace_data): Add initializers, destructor.
7607 (ada_pspace_data_handle): Change type.
7608 (get_ada_pspace_data): Update.
7609 (ada_pspace_data_cleanup): Remove.
7611 2019-05-08 Tom Tromey <tom@tromey.com>
7613 * coffread.c (struct coff_symfile_info): Add initializers.
7614 (coff_objfile_data_key): Move lower. Change type.
7615 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7617 (coff_free_info): Remove.
7619 2019-05-08 Tom Tromey <tom@tromey.com>
7621 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7622 (fbsd_pspace_data_handle): Move lower. Change type.
7623 (get_fbsd_pspace_data): Update.
7624 (fbsd_pspace_data_cleanup): Remove.
7625 (_initialize_fbsd_tdep): Update.
7627 2019-05-08 Tom Tromey <tom@tromey.com>
7629 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7630 (get_ada_tasks_pspace_data): Update.
7631 (ada_tasks_pspace_data_cleanup): Remove.
7632 (_initialize_tasks): Update.
7633 (ada_tasks_inferior_data_handle): Change type.
7634 (get_ada_tasks_inferior_data): Update.
7635 (ada_tasks_inferior_data_cleanup): Remove.
7636 (struct ada_tasks_pspace_data): Add initializers.
7638 2019-05-08 Tom Tromey <tom@tromey.com>
7640 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7641 * symfile-debug.c (debug_sym_get_probes): Change type.
7642 * stap-probe.c (handle_stap_probe):
7643 (stap_static_probe_ops::get_probes): Change type.
7644 * probe.h (class static_probe_ops) <get_probes>: Change type.
7645 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7646 (parse_probes_in_pspace): Update.
7647 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7649 (any_static_probe_ops::get_probes): Change type.
7650 * elfread.c (elfread_data): New typedef.
7651 (probe_key): Change type.
7652 (elf_get_probes): Likewise. Update.
7653 (probe_key_free): Remove.
7654 (_initialize_elfread): Update.
7655 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7657 (dtrace_process_dof_probe, dtrace_process_dof)
7658 (dtrace_static_probe_ops::get_probe): Change type.
7660 2019-05-08 Tom Tromey <tom@tromey.com>
7662 * xcoffread.c (struct xcoff_symfile_info): Rename from
7663 coff_symfile_info. Add initializers.
7664 (xcoff_objfile_data_key): Move lower. Change type.
7665 (XCOFF_DATA): Rewrite.
7666 (xcoff_free_info): Remove.
7667 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7668 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7669 (xcoff_initial_scan): Update.
7671 2019-05-08 Tom Tromey <tom@tromey.com>
7673 * solib-svr4.c (struct svr4_info): Add initializers and
7675 <probes_table>: Now an htab_up.
7676 (solib_svr4_pspace_data): Change type.
7677 (free_probes_table): Simplify.
7678 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7679 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7680 (probes_table_remove_objfile_probes, register_solib_event_probe)
7681 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7682 (_initialize_svr4_solib): Update.
7684 2019-05-08 Tom Tromey <tom@tromey.com>
7686 * remote.c (remote_pspace_data): Change type.
7687 (remote_pspace_data_cleanup): Remove.
7688 (get_remote_exec_file, set_pspace_remote_exec_file)
7689 (_initialize_remote): Update.
7691 2019-05-08 Tom Tromey <tom@tromey.com>
7693 * breakpoint.c (breakpoint_objfile_key): Change type.
7694 (get_breakpoint_objfile_data): Update.
7695 (free_breakpoint_objfile_data): Remove.
7696 (_initialize_breakpoint): Update.
7698 2019-05-08 Tom Tromey <tom@tromey.com>
7700 * linux-tdep.c (struct linux_info): Add initializers.
7701 (linux_inferior_data): Move. Change type.
7702 (invalidate_linux_cache_inf): Update.
7703 (linux_inferior_data_cleanup): Remove.
7704 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7706 2019-05-08 Tom Tromey <tom@tromey.com>
7708 * auxv.c (auxv_inferior_data): Move. Change type.
7709 (auxv_inferior_data_cleanup): Remove.
7710 (invalidate_auxv_cache_inf): Rewrite.
7711 (get_auxv_inferior_data, _initialize_auxv): Update.
7713 2019-05-08 Tom Tromey <tom@tromey.com>
7715 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7716 (symfile_debug_objfile_data_key): Change type.
7717 (symfile_debug_installed, debug_qf_has_symbols)
7718 (debug_qf_find_last_source_symtab)
7719 (debug_qf_forget_cached_source_info)
7720 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7721 (debug_qf_print_stats, debug_qf_dump)
7722 (debug_qf_expand_symtabs_for_function)
7723 (debug_qf_expand_all_symtabs)
7724 (debug_qf_expand_symtabs_with_fullname)
7725 (debug_qf_map_matching_symbols)
7726 (debug_qf_expand_symtabs_matching)
7727 (debug_qf_find_pc_sect_compunit_symtab)
7728 (debug_qf_map_symbol_filenames)
7729 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7730 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7731 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7732 (debug_sym_read_linetable, debug_sym_relocate): Update.
7733 (symfile_debug_free_objfile): Remove.
7734 (install_symfile_debug_logging, _initialize_symfile_debug):
7737 2019-05-08 Tom Tromey <tom@tromey.com>
7739 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7740 allocate_on_obstack.
7741 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7742 (get_dwarf2_per_objfile): Update.
7743 (set_dwarf2_per_objfile): Remove.
7744 (dwarf2_has_info, dwarf2_get_section_info): Update.
7745 (dwarf2_free_objfile): Remove.
7746 (_initialize_dwarf2_read): Update.
7748 2019-05-08 Tom Tromey <tom@tromey.com>
7750 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7752 <unsupported_script_warning_printed,
7753 script_not_found_warning_printed>: Now bool.
7754 (auto_load_pspace_data): Change type.
7755 (~auto_load_pspace_info): Rename from
7756 auto_load_pspace_data_cleanup.
7757 (get_auto_load_pspace_data, init_loaded_scripts_info)
7758 (clear_section_scripts, maybe_print_unsupported_script_warning)
7759 (maybe_print_script_not_found_warning, _initialize_auto_load):
7762 2019-05-08 Tom Tromey <tom@tromey.com>
7764 * objfiles.c (objfile_pspace_info): Add destructor and
7766 (objfiles_pspace_data): Change type.
7767 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7768 (get_objfile_pspace_data): Update.
7769 (objfiles_bfd_data): Change type.
7770 (get_objfile_bfd_data): Update.
7771 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7773 2019-05-08 Tom Tromey <tom@tromey.com>
7775 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7777 (get_catch_syscall_inferior_data): Update.
7778 (catch_syscall_inferior_data_cleanup): Remove.
7779 (_initialize_break_catch_syscall): Update.
7781 2019-05-08 Tom Tromey <tom@tromey.com>
7783 * inflow.c (struct terminal_info): Add destructor and
7785 (inflow_inferior_data): Change type.
7786 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7787 (get_inflow_inferior_data, inflow_inferior_exit)
7788 (swap_terminal_info, _initialize_inflow): Update.
7790 2019-05-08 Tom Tromey <tom@tromey.com>
7792 * target-dcache.c (target_dcache_cleanup): Remove.
7793 (target_dcache_aspace_key): Change type.
7794 (target_dcache_init_p, target_dcache_invalidate)
7795 (target_dcache_get, target_dcache_get_or_init)
7796 (_initialize_target_dcache): Update.
7797 * dcache.h (struct dcache_deleter): New.
7799 2019-05-08 Tom Tromey <tom@tromey.com>
7801 * symtab.c (struct symbol_cache): Add destructor and
7803 (symbol_cache_key): Move. Change type.
7804 (make_symbol_cache, free_symbol_cache): Remove.
7805 (get_symbol_cache): Update.
7806 (symbol_cache_cleanup): Remove.
7807 (ALL_PSPACES, symbol_cache_flush)
7808 (maintenance_print_symbol_cache)
7809 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7812 2019-05-08 Tom Tromey <tom@tromey.com>
7814 * symtab.c (struct main_info): Add destructor and initializers.
7815 (main_progspace_key): Move. Change type.
7816 (get_main_info): Update.
7817 (main_info_cleanup): Remove.
7818 (_initialize_symtab): Update.
7820 2019-05-08 Tom Tromey <tom@tromey.com>
7822 * registry.h (DECLARE_REGISTRY): Define the _key class.
7824 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7826 * NEWS: Merge two 'New commands' sections.
7828 2019-05-08 Joel Brobecker <brobecker@adacore.com>
7830 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7831 parameter and use Ada language definition instead.
7832 (ada_val_print_ptr): Remove unused language parameter.
7833 (ada_val_print_num): Remove language parameter and use Ada language
7835 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7837 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7838 parameter and use Ada language definition instead.
7839 (ada_val_print_1): Update all ada_val_print_xxx calls.
7840 Remove language parameter.
7841 (ada_val_print): Update ada_val_print_1 call.
7843 2019-05-08 Tom Tromey <tromey@adacore.com>
7845 * remote.c (remote_hw_watchpoint_limit)
7846 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7849 2019-05-08 Tom Tromey <tromey@adacore.com>
7851 * maint.c (_initialize_maint_cmds): Move initialization code to
7853 (watchdog, show_watchdog): Move to remote.c.
7854 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7856 (_initialize_remote): Move initialization code from maint.c.
7857 * defs.h (watchdog): Don't declare.
7859 2019-05-08 Tom Tromey <tromey@adacore.com>
7861 * tui/tui-interp.c: Include main.h.
7862 * interps.c: Include main.h.
7863 * main.h (interpreter_p): Declare.
7864 * defs.h (interpreter_p): Don't declare.
7866 2019-05-08 Tom Tromey <tromey@adacore.com>
7868 * dwarf2loc.c: Include dwarf2read.h.
7869 * defs.h (read_unsigned_leb128): Don't declare.
7870 * dwarf2read.h (read_unsigned_leb128): Declare.
7872 2019-05-08 Tom Tromey <tromey@adacore.com>
7874 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7877 2019-05-08 Tom Tromey <tromey@adacore.com>
7879 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7880 when no wrap column is set.
7882 2019-05-08 Tom Tromey <tromey@adacore.com>
7884 * c-lang.c (c_get_string): Handle non-C-style arrays.
7886 2019-05-08 Tom Tromey <tromey@adacore.com>
7888 * typeprint.c (print_offset_data::update): Print the bit offset,
7889 not the number of bits remaining.
7891 2019-05-08 Tom Tromey <tromey@adacore.com>
7893 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7894 padding at end of comment.
7896 2019-05-08 Tom Tromey <tromey@adacore.com>
7898 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7901 2019-05-06 Tom Tromey <tom@tromey.com>
7903 * common/scoped_mmap.c: Include common-defs.h.
7904 * common/scoped_mmap.h: Don't include config.h.
7906 2019-05-04 Tom Tromey <tom@tromey.com>
7908 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7909 (struct aarch64_call_info): Add initializers.
7910 <si>: Now a std::vector.
7911 (pass_on_stack, aarch64_push_dummy_call): Update.
7913 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
7914 Tom Tromey <tom@tromey.com>
7916 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7917 (ppc_threads): Now a std::vector. Now static.
7918 (hwdebug_find_thread_points_by_tid)
7919 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7922 2019-05-04 Tom Tromey <tom@tromey.com>
7924 * arc-tdep.c (arc_tdesc_init): Return bool.
7926 2019-05-04 Tom Tromey <tom@tromey.com>
7928 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7929 Use gdb_assert_not_reached.
7931 2019-05-04 Tom Tromey <tom@tromey.com>
7933 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7936 2019-05-04 Tom Tromey <tom@tromey.com>
7938 * arc-tdep.c (arc_tdesc_init): Use bool.
7940 2019-05-04 Tom Tromey <tom@tromey.com>
7942 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7944 2019-05-04 Tom Tromey <tom@tromey.com>
7946 * cli/cli-cmds.c (valid_command_p): Return bool.
7948 2019-05-04 Tom Tromey <tom@tromey.com>
7950 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7951 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7953 2019-05-04 Raul Tambre <raul@tambre.ee>
7955 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7956 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7957 operator for comparison.
7959 2019-05-04 Tom Tromey <tom@tromey.com>
7961 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7962 (lookup_partial_symbol, print_partial_symbols)
7963 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7964 (psymbol_compare): Update.
7965 (add_psymbol_to_bcache): Clear the entire psymbol.
7966 (maintenance_check_psymtabs): Update.
7967 * psympriv.h (struct partial_symbol): Don't derive from
7968 general_symbol_info.
7969 <obj_section, unrelocated_address, address,
7970 set_unrelocated_address>: Update.
7971 <ginfo>: New member.
7972 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7973 (debug_names::write_psymbols): Update.
7975 2019-05-04 Tom de Vries <tdevries@suse.de>
7977 * contrib/cc-with-tweaks.sh: Support -n arg.
7979 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7981 * corelow.c (core_target::detach): Ensure frame cache and
7982 register caches are cleared.
7983 inferior.c (exit_inferior_1): Likewise.
7985 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7986 Tom Tromey <tom@tromey.com>
7988 * dictionary.c (collate_pending_symbols_by_language): Remove
7989 "struct" from foreach.
7990 * symtab.c (lookup_global_symbol_from_objfile)
7991 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7993 * ser-tcp.c (net_open): Remove "struct" from foreach.
7994 * objfiles.c (objfile_relocate, objfile_rebase)
7995 (objfile_has_symbols): Remove "struct" from foreach.
7996 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7998 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8000 * darwin-nat.c (thread_info_from_private_thread_info): Remove
8001 "struct" from foreach.
8002 * ada-lang.c (create_excep_cond_exprs)
8003 (ada_exception_catchpoint_cond_string): Remove "struct" from
8006 2019-05-03 Tom Tromey <tromey@adacore.com>
8008 * ada-exp.y (convert_char_literal): Check suffix of each
8011 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
8014 * ada-exp.y (yywrap): Don't define.
8015 * ada-lex.l (%option): Add noyywrap
8018 2019-05-03 Eli Zaretskii <eliz@gnu.org>
8020 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8021 _WIN32_WINNT to the XP level, unless already defined to a higher
8024 * unittests/parse-connection-spec-selftests.c:
8026 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
8029 * symfile.c (find_separate_debug_file): Remove colon from the
8030 drive spec of DOS/Windows file names of the target, so that the
8031 file name produced from DEBUGDIR and the target's directory will
8032 be valid on DOS/Windows systems.
8034 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
8036 * rust-lang.c (val_print_struct): Handle printing structures
8039 2019-05-02 Tom Tromey <tromey@adacore.com>
8041 * valarith.c (_initialize_valarith): Remove.
8043 2019-05-01 Tom Tromey <tromey@adacore.com>
8045 * ada-lang.c (ada_value_primitive_field): Treat more fields as
8048 2019-05-01 Tom Tromey <tromey@adacore.com>
8050 * ada-lang.c (ada_value_assign): Correctly compute starting offset
8051 for big-endian copies.
8053 2019-04-30 Ali Tamur <tamur@google.com>
8054 * gdb/dwarf2read.c (read_3_bytes): New declaration.
8055 (read_attribute_value): Added DW_FORM_strx1-4 cases.
8056 (read_3_bytes): New function.
8058 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8060 * windows-nat.c (main_thread_id): Delete.
8061 (handle_output_debug_string): Replace main_thread_id by
8062 current_event.dwThreadId.
8063 (fake_create_process): Likewise.
8064 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8065 Do not set main_thread_id.
8066 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8067 current_event.dwThreadId.
8068 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8070 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8072 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8073 Use current_event.dwThreadId instead of main_thread_id.
8075 2019-04-30 Tom Tromey <tromey@adacore.com>
8077 * ada-lang.c (ada_lookup_simple_minsyms): New function.
8078 (create_excep_cond_exprs): Iterate over program spaces.
8079 (ada_exception_catchpoint_cond_string): Examine all minimal
8080 symbols for exception types.
8082 2019-04-30 Tom Tromey <tromey@adacore.com>
8085 * dwarf2read.c (process_structure_scope): Handle case where type
8086 has template parameters but no symbol was created.
8088 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8089 Chris January <chris.january@arm.com>
8091 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8093 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8095 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8097 * f-typeprint.c (f_print_type): Update rules for printing
8099 (f_type_print_varspec_suffix): Likewise.
8101 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8102 Chris January <chris.january@arm.com>
8104 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8107 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8109 * f-lang.c (build_fortran_types): Change name of void type to
8111 * f-typeprint.c (f_type_print_base): Print the name of the void
8112 type, rather than a fixed string.
8113 * f-valprint.c (f_decorations): Use lower case void string.
8115 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8116 Chris January <chris.january@arm.com>
8118 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8121 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8122 Chris January <chris.january@arm.com>
8123 David Lecomber <david.lecomber@arm.com>
8125 * f-exp.y (BINOP_INTRINSIC): New token.
8126 (exp): New parser rule handling BINOP_INTRINSIC.
8127 (f77_keywords): Add new builtin procedures.
8128 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8129 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8130 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8131 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8132 (print_unop_subexp_f): New function.
8133 (print_binop_subexp_f): New function.
8134 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8135 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8136 (dump_subexp_body_f): Likewise.
8137 (operator_check_f): Likewise.
8138 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8139 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8141 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8143 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8145 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8146 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8147 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8148 (operator_length_f): New fuction.
8149 (print_subexp_f): New function.
8150 (op_name_f): New function.
8151 (dump_subexp_body_f): New function.
8152 (operator_check_f): New function.
8153 (exp_descriptor_f): Replace standard expression handling functions
8155 * gdb/fortran-operator.def: New file.
8156 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8157 * gdb/std-operator.def: Remove UNOP_KIND.
8159 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8161 * std-operator.def: Remove unbalanced, stray double quote
8164 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8165 Chris January <chris.january@arm.com>
8166 Daniel Everett <daniel.everett@arm.com>
8167 Nick Forrington <nick.forrington@arm.com>
8168 Richard Bunt <richard.bunt@arm.com>
8170 * cp-valprint.c (cp_print_value_fields): Allow an additional level
8171 of depth when printing anonymous structs or unions.
8172 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8173 Don't print either the top-level value, or the children if the
8174 max-depth is exceeded.
8175 (ppscm_print_children): When printing the key of a map, allow one
8176 extra level of depth.
8177 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8178 print either the top-level value, or the children if the max-depth
8180 (print_children): When printing the key of a map, allow one extra
8182 * python/py-value.c (valpy_format_string): Add max_depth keyword.
8183 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8184 (user_print_options): Initialise max_depth field.
8185 (val_print_scalar_or_string_type_p): New function.
8186 (val_print): Check to see if the max depth has been reached.
8187 (val_print_check_max_depth): Define new function.
8188 (show_print_max_depth): New function.
8189 (_initialize_valprint): Add 'print max-depth' option.
8190 * valprint.h (struct value_print_options) <max_depth>: New field.
8191 (val_print_check_max_depth): Declare new function.
8192 * NEWS: Document new feature.
8194 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8196 * ada-lang.c (ada_language_defn): Initialise new field.
8197 * c-lang.c (c_is_string_type_p): New function.
8198 (c_language_defn): Initialise new field.
8199 (cplus_language_defn): Initialise new field.
8200 (asm_language_defn): Initialise new field.
8201 (minimal_language_defn): Initialise new field.
8202 * c-lang.h (c_is_string_type_p): Declare new function.
8203 * d-lang.c (d_language_defn): Initialise new field.
8204 * f-lang.c (f_is_string_type_p): New function.
8205 (f_language_defn): Initialise new field.
8206 * go-lang.c (go_is_string_type_p): New function.
8207 (go_language_defn): Initialise new field.
8208 * language.c (default_is_string_type_p): New function.
8209 (unknown_language_defn): Initialise new field.
8210 (auto_language_defn): Initialise new field.
8211 * language.h (struct language_defn) <la_is_string_type_p>: New
8213 (default_is_string_type_p): Declare new function.
8214 * m2-lang.c (m2_language_defn): Initialise new field.
8215 * objc-lang.c (objc_language_defn): Initialise new field.
8216 * opencl-lang.c (opencl_language_defn): Initialise new field.
8217 * p-lang.c (pascal_is_string_type_p): New function.
8218 (pascal_language_defn): Initialise new field.
8219 * rust-lang.c (rust_is_string_type_p): New function.
8220 (rust_language_defn): Initialise new field.
8222 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8224 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8226 * ada-lang.c (ada_language_defn): Initialise new field.
8227 * c-lang.c (c_language_defn): Likewise.
8228 (cplus_language_defn): Likewise.
8229 (asm_language_defn): Likewise.
8230 (minimal_language_defn): Likewise.
8231 * d-lang.c (d_language_defn): Likewise.
8232 * f-lang.c (f_language_defn): Likewise.
8233 * go-lang.c (go_language_defn): Likewise.
8234 * language.c (unknown_language_defn): Likewise.
8235 (auto_language_defn): Likewise.
8236 * m2-lang.c (m2_language_defn): Likewise.
8237 * objc-lang.c (objc_language_defn): Likewise.
8238 * opencl-lang.c (opencl_language_defn): Likewise.
8239 * p-lang.c (pascal_language_defn): Likewise.
8240 * rust-lang.c (rust_language_defn): Likewise.
8242 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8244 * ada-lang.c (ada_is_character_type): Change return type to bool.
8245 (ada_is_string_type): Likewise.
8246 * ada-lang.h (ada_is_character_type): Update declaration
8247 (ada_is_string_type): Likewise.
8249 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8251 Support style in 'frame|thread apply'
8253 * gdbcmd.h (execute_command_to_string): New term_out parameter.
8254 * record.c (record_start, record_stop): Update callers of
8255 execute_command_to_string with false.
8256 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8257 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8259 (class string_file): New constructor with term_out parameter.
8260 Override methods term_out and can_emit_style_escape. New member
8262 (class stdio_file): Override can_emit_style_escape.
8263 (class tee_file): Override term_out and can_emit_style_escape.
8264 * utils.h (can_emit_style_escape): Remove.
8265 * utils.c (can_emit_style_escape): Likewise.
8266 Update all callers of can_emit_style_escape (SOMESTREAM) to
8267 SOMESTREAM->can_emit_style_escape.
8268 * source-cache.c (source_cache::get_source_lines): Likewise.
8269 * stack.c (frame_apply_command_count): Call execute_command_to_string
8270 passing the term_out characteristic of the current gdb_stdout.
8271 * thread.c (thr_try_catch_cmd): Likewise.
8272 * top.c (execute_command_to_string): pass term_out parameter
8273 to construct the string_file for the command output.
8274 * ui-file.c (term_cli_styling): New function (most code moved
8275 from utils.c can_emit_style_escape).
8276 (string_file::string_file, string_file::can_emit_style_escape,
8277 stdio_file::can_emit_style_escape, tee_file::term_out,
8278 tee_file::can_emit_style_escape): New functions.
8280 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8282 * NEWS: Mention the new set|show may-call-functions.
8283 * infcall.c (may_call_functions_p): New variable.
8284 (show_may_call_functions_p): New function.
8285 (call_function_by_hand_dummy): Throws an error if not
8287 (_initialize_infcall): Call add_setshow_boolean_cmd for
8290 2019-04-25 Keith Seitz <keiths@redhat.com>
8293 * cp-support.c (inspect_type): Don't attempt substitutions
8294 of symbol with the same name.
8296 2019-04-25 Tom Tromey <tromey@adacore.com>
8299 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8302 2019-04-25 Tom Tromey <tromey@adacore.com>
8304 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8306 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8307 (gdb_xml_parser::parse): Use std::move.
8308 * python/python-internal.h (gdbpy_convert_exception): Take a const
8310 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8312 * python/py-utils.c (gdbpy_convert_exception): Take a const
8314 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8316 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8318 * mi/mi-main.c (mi_print_exception): Take a const reference.
8319 * main.c (handle_command_errors): Take a const reference.
8320 * linespec.c (parse_linespec): Use std::move.
8321 * infcall.c (run_inferior_call): Use std::move.
8322 (call_function_by_hand_dummy): Use std::move.
8323 * exec.c (try_open_exec_file): Use std::move.
8324 * exceptions.h (exception_print, exception_fprintf)
8325 (exception_print_same): Update.
8326 * exceptions.c (print_exception, exception_print)
8327 (exception_fprintf, exception_print_same): Change parameters to
8329 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8330 * common/new-op.c: Use std::move.
8331 * common/common-exceptions.h (struct gdb_exception): Add move
8333 (struct gdb_exception_error, struct gdb_exception_quit, struct
8334 gdb_quit_bad_alloc): Change constructor to move constructor.
8335 (throw_exception): Change parameter to rvalue reference.
8336 * common/common-exceptions.c (throw_exception): Take rvalue
8338 * cli/cli-interp.c (safe_execute_command): Use std::move.
8339 * breakpoint.c (insert_bp_location, location_to_sals): Use
8342 2019-04-25 Tom Tromey <tromey@adacore.com>
8344 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8345 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8346 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8347 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8348 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8349 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8350 guile/scm-value.c: Use unpack.
8351 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8352 gdbscm_gdb_exception.
8353 (gdbscm_throw_gdb_exception): Likewise.
8354 (struct gdbscm_gdb_exception): New.
8355 (unpack): New function.
8356 (gdbscm_wrap): Use unpack.
8358 2019-04-25 Tom Tromey <tromey@adacore.com>
8360 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8361 (gdb_rl_callback_handler): Use std::move.
8362 * common/common-exceptions.h (struct gdb_exception): Add move
8363 assignment operator.
8364 (throw_exception_sjlj): Change "exception" to const reference.
8365 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8366 (throw_exception_sjlj): Change "exception" to const reference.
8368 2019-04-25 Tom Tromey <tromey@adacore.com>
8370 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8371 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8372 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8374 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8376 * mi/mi-interp.c (mi_interp::exec): Update.
8377 * linespec.c (parse_linespec): Update.
8378 * infcall.c (run_inferior_call): Update.
8379 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8380 * guile/scm-symbol.c (gdbscm_lookup_symbol)
8381 (gdbscm_lookup_global_symbol): Update.
8382 * guile/scm-param.c (gdbscm_parameter_value): Update.
8383 * guile/scm-frame.c (gdbscm_frame_read_register)
8384 (gdbscm_frame_read_var): Update.
8385 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8386 * exec.c (try_open_exec_file): Update.
8387 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8388 (gdb_rl_callback_handler): Update.
8389 * common/common-exceptions.h (exception_none): Don't declare.
8390 * common/common-exceptions.c (exception_none): Don't define.
8391 (struct catcher) <exception>: Update.
8392 * cli/cli-interp.c (safe_execute_command): Update.
8393 * breakpoint.c (insert_bp_location, location_to_sals): Update.
8395 2019-04-25 Ali Tamur <tamur@google.com>
8397 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8398 (read_attribute_value): Likewise.
8399 (dwarf2_read_addr_index): Update comment.
8400 (read_str_index): Add DW_FORM_strx.
8401 (dwarf2_string_attr): Likewise.
8402 (dwarf2_const_value_attr): Likewise.
8403 (dump_die_shallow): Likewise.
8404 (dwarf2_fetch_constant_bytes): Likewise.
8405 (skip_form_bytes): Likewise.
8406 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8408 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
8412 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8413 OFFSET. Verify if current mapping contains an ELF header.
8414 (linux_find_memory_regions_full): Adjust call to
8417 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
8418 Kang Li <kanglictf@gmail.com>
8422 * dwarf2-frame.c (read_initial_length): Be consistent about using
8423 unsigned representation of length.
8424 (decode_frame_entry_1): Likewise. Check for wraparound of
8425 end pointer as well as buffer overflow.
8427 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
8429 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8432 2019-04-24 Tom Tromey <tromey@adacore.com>
8434 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8436 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8438 * s12z-tdep.c (s12z_unwind_pc): Delete.
8439 (s12z_unwind_sp): Delete.
8440 (s12z_gdbarch_init): Don't register deleted functions with
8443 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8445 * rl78-tdep.c (rl78_unwind_sp): Delete.
8446 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8448 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8450 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8451 (xstormy16_unwind_pc): Delete.
8452 (xstormy16_dummy_id): Delete.
8453 (xstormy16_gdbarch_init): Don't register deleted functions with
8456 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8458 * vax-tdep.c (vax_unwind_pc): Delete.
8459 (vax_gdbarch_init): Don't register deleted function with gdbarch.
8461 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8463 * v850-tdep.c (v850_unwind_sp): Delete.
8464 (v850_unwind_pc): Delete.
8465 (v850_dummy_id): Delete.
8466 (v850_gdbarch_init): Don't register deleted functions with
8469 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8471 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8472 (tilegx_unwind_pc): Delete.
8473 (tilegx_unwind_dummy_id): Delete.
8474 (tilegx_gdbarch_init): Don't register deleted functions with
8477 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8479 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8480 (tic6x_dummy_id): Delete.
8481 (tic6x_gdbarch_init): Don't register deleted functions with
8484 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8486 * sparc-tdep.c (sparc_unwind_pc): Delete.
8487 (sparc32_gdbarch_init): Don't register deleted function with
8490 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8492 * sh-tdep.c (sh_unwind_sp): Delete.
8493 (sh_unwind_pc): Delete.
8494 (sh_dummy_id): Delete.
8495 (sh_gdbarch_init): Don't register deleted functions with
8498 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8500 * score-tdep.c (score_unwind_sp): Delete.
8501 (score_unwind_pc): Delete.
8502 (score_dummy_id): Delete.
8503 (score_gdbarch_init): Don't register deleted functions with
8506 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8508 * rx-tdep.c (rx_unwind_pc): Delete.
8509 (rx_unwind_sp): Delete.
8510 (rx_dummy_id): Delete.
8511 (rx_gdbarch_init): Don't register deleted functions with
8512 gdbarch. Update comment.
8514 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8516 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8517 (rs6000_dummy_id): Delete.
8518 (rs6000_gdbarch_init): Don't register deleted functions with
8521 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8523 * or1k-tdep.c (or1k_dummy_id): Delete.
8524 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8526 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8528 * nios2-tdep.c (nios2_dummy_id): Delete.
8529 (nios2_unwind_sp): Delete.
8530 (nios2_gdbarch_init): Don't register deleted functions with
8533 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8535 * nds32-tdep.c (nds32_dummy_id): Delete.
8536 (nds32_unwind_pc): Delete.
8537 (nds32_unwind_sp): Delete.
8538 (nds32_gdbarch_init): Don't register deleted functions with
8541 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8543 * msp430-tdep.c (msp430_unwind_pc): Delete.
8544 (msp430_unwind_sp): Delete.
8545 (msp430_dummy_id): Delete.
8546 (msp430_gdbarch_init): Don't register deleted functions with
8549 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8551 * moxie-tdep.c (moxie_unwind_sp): Delete.
8552 (moxie_unwind_pc): Delete.
8553 (moxie_dummy_id): Delete.
8554 (moxie_gdbarch_init): Don't register deleted functions with
8557 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8559 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8560 (mn10300_unwind_pc): Delete.
8561 (mn10300_unwind_sp): Delete.
8562 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8564 (mn10300_frame_unwind_init): Don't register deleted functions with
8567 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8569 * mep-tdep.c (mep_unwind_pc): Delete.
8570 (mep_unwind_sp): Delete.
8571 (mep_dummy_id): Delete.
8572 (mep_gdbarch_init): Don't register deleted functions with
8575 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8577 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8578 (m68hc11_unwind_sp): Delete.
8579 (m68hc11_gdbarch_init): Don't register deleted functions with
8582 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8584 * m32r-tdep.c (m32r_unwind_sp): Delete.
8585 (m32r_unwind_pc): Delete.
8586 (m32r_dummy_id): Delete.
8587 (m32r_gdbarch_init): Don't register deleted functions with
8590 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8592 * m32c-tdep.c (m32c_unwind_pc): Delete.
8593 (m32c_unwind_sp): Delete.
8594 (m32c_dummy_id): Delete.
8595 (m32c_gdbarch_init): Don't register deleted functions with
8598 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8600 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8601 (lm32_unwind_pc): Delete.
8602 (lm32_dummy_id): Delete.
8603 (lm32_gdbarch_init): Don't register deleted functions with
8606 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8608 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8609 (iq2000_unwind_pc): Delete.
8610 (iq2000_dummy_id): Delete.
8611 (iq2000_gdbarch_init): Don't register deleted functions with
8614 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8616 * nds32-tdep.c (nds32_type_align): Delete.
8617 (nds32_push_dummy_call): Use type_align instead.
8619 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8621 * arm-tdep.c (arm_type_align): Only handle vector override case.
8622 (arm_push_dummy_call): Use type_align.
8623 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8625 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8627 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8629 (pass_on_stack): Use type_align.
8630 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8633 2019-04-23 Tom Tromey <tromey@adacore.com>
8635 * dwarf2read.c (line_header::file_name_at): Remove unused
8638 2019-04-23 Tom de Vries <tdevries@suse.de>
8641 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8645 2019-03-27 Ali Tamur <tamur@google.com>
8647 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8648 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8649 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8650 (dwarf_expr_context::get_addr_index): Likewise
8651 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8652 (symbol_needs_eval_context::get_addr_index): Likewise
8653 (disassemble_dwarf_expression): Add DW_OP_addrx
8654 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8655 (read_cutu_die_from_dwo): Update comment
8656 (skip_one_die): Add DW_FORM_addrx
8657 (read_attribute_value): Likewise
8658 (var_decode_location): Add DW_OP_addrx
8659 (dwarf2_const_value_attr): Add DW_FORM_addrx
8660 (dump_die_shallow): Likewise
8661 (dwarf2_fetch_constant_bytes): Likewise
8662 (decode_locdesc): Add DW_OP_addrx
8663 (skip_form_bytes): Add DW_FORM_addrx
8665 2019-04-22 Ali Tamur <tamur@google.com>
8667 * MAINTAINERS (Write After Approval): Add self.
8669 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
8671 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8672 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8673 (open_symbol_file_object): Likewise.
8674 (svr4_default_sos): Add info parameter.
8675 (svr4_read_so_list): Likewise.
8676 (svr4_current_sos_direct): Adjust functions calls to pass down
8678 (svr4_current_sos_1): Add info parameter.
8679 (svr4_current_sos): Call get_svr4_info, pass info down to
8681 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8683 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8685 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8687 (probes_table_remove_objfile_probes): Likewise.
8688 (register_solib_event_probe): Add info parameter.
8689 (solist_update_incremental): Pass info parameter down to
8691 (disable_probes_interface): Add info parameter.
8692 (svr4_handle_solib_event): Pass current_program_space to
8693 get_svr4_info. Adjust disable_probes_interface cleanup.
8694 (svr4_create_probe_breakpoints): Add info parameter, pass it
8695 down to register_solib_event_probe.
8696 (svr4_create_solib_event_breakpoints): Add info parameter,
8697 pass it down to svr4_create_probe_breakpoints.
8698 (enable_break): Pass info down to
8699 svr4_create_solib_event_breakpoints.
8700 (svr4_solib_create_inferior_hook): Pass current_program_space to
8702 (svr4_clear_solib): Likewise.
8704 2019-04-22 Pedro Alves <palves@redhat.com>
8706 * solib-svr4.c (svr4_free_objfile_observer): New.
8707 (probe_and_action::objfile): New field.
8708 (probes_table_htab_remove_objfile_probes)
8709 (probes_table_remove_objfile_probes): New functions.
8710 (register_solib_event_probe): Add 'objfile' parameter. Store it
8711 in the new probe_and_action. Don't store the probe in 'lookup'.
8712 (svr4_create_probe_breakpoints): Pass objfile to
8713 register_solib_event_probe.
8714 (_initialize_svr4_solib): Register a free_objfile observer.
8716 2019-04-19 Tom Tromey <tom@tromey.com>
8718 * common/queue.h: Remove.
8720 2019-04-19 Tom Tromey <tom@tromey.com>
8722 * event-loop.c: Don't include "common/queue.h".
8724 2019-04-19 Tom Tromey <tom@tromey.com>
8726 * remote.c (remote_target): Use delete.
8727 * remote-notif.h: Include <list>, not "common/queue.h".
8728 (notif_client_p): Remove typedef.
8729 (remote_notif_state): Add constructor, destructor, initializer.
8730 <notif_queue>: Now a std::list.
8731 (remote_notif_state_xfree): Don't declare.
8732 * remote-notif.c (remote_notif_process, handle_notification)
8733 (remote_notif_state_allocate): Update.
8734 (~remote_notif_state): Rename from remote_notif_state_xfree.
8736 2019-04-19 Tom Tromey <tom@tromey.com>
8738 * symfile.c (reread_symbols): Update.
8739 * objfiles.c (objfile_register_static_link)
8740 (objfile_lookup_static_link): Update
8741 (~objfile) Don't delete static_links.
8742 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8744 2019-04-19 Tom Tromey <tom@tromey.com>
8746 * type-stack.h (struct type_stack) <insert>: Constify string.
8747 * type-stack.c (type_stack::insert): Constify string.
8748 * gdbtypes.h (lookup_template_type): Update.
8749 (address_space_name_to_int): Update.
8750 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8752 (lookup_template_type): Make name const.
8753 * c-exp.y: Update rules.
8754 (lex_one_token, classify_name, classify_inner_name)
8755 (c_print_token): Update.
8756 * p-exp.y: Update rules.
8758 * f-exp.y: Update rules.
8760 * d-exp.y: Update rules.
8761 (lex_one_token, classify_name, classify_inner_name): Update.
8762 * parse.c (write_dollar_variable, copy_name): Return std::string.
8763 * parser-defs.h (copy_name): Change return type.
8764 * m2-exp.y: Update rules.
8766 * go-exp.y (lex_one_token): Update.
8768 (classify_unsafe_function, classify_packaged_name)
8769 (classify_name, yylex): Update.
8771 2019-04-19 Sergei Trofimovich <siarheit@google.com>
8773 * configure.ac: add --enable-source-highlight switch.
8774 * configure: Regenerate.
8775 * top.c (print_gdb_version): plumb --enable-source-highlight
8776 status to "show configuration".
8778 2019-04-19 Tom Tromey <tromey@adacore.com>
8780 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8782 (empty_record, ada_template_to_fixed_record_type_1)
8783 (template_to_static_fixed_type)
8784 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8785 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8786 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8789 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8792 * source.c (print_source_lines_base): Advance "iter" when a
8793 control character is seen.
8795 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8797 * inferior.h (struct infcall_suspend_state_deleter):
8798 Catch exception in destructor to avoid crash.
8800 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8802 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8803 close to the add_com "shell".
8805 2019-04-18 Tom Tromey <tromey@adacore.com>
8807 * process-stratum-target.h (class process_stratum_target)
8808 <stratum>: Add "final".
8810 2019-04-17 Tom Tromey <tromey@adacore.com>
8812 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8813 against nullptr before use.
8815 2019-04-17 Alan Hayward <alan.hayward@arm.com>
8817 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8819 2019-04-17 Jim Wilson <jimw@sifive.com>
8820 Andrew Burgess <andrew.burgess@embecosm.com>
8822 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8823 code read might fail, assume 4-byte breakpoint in that case.
8825 2019-04-15 Leszek Swirski <leszeks@google.com>
8827 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8828 rather than a hand-rolled POD check when checking for forced MEMORY
8831 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8833 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8834 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8836 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8837 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8838 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8841 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8843 * aarch64-linux-nat.c
8844 (aarch64_linux_nat_target::thread_architecture): Add override.
8845 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8848 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8850 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8852 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8854 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8855 target types of size 96-bits, add some additional comments, and
8856 check that the builtin type we found was the correct size.
8858 2019-04-12 Eli Zaretskii <eliz@gnu.org>
8860 * utils.c (prompt_for_continue): Don't restore the styling at the
8861 end, as applied_style has the wrong value. This fixes styling in
8862 long lists of file names that are interrupted by the "Continue?"
8865 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8867 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8868 * c-lang.c (c_language_defn): Likewise.
8869 (cplus_language_defn): Likewise.
8870 (asm_language_defn): Likewise.
8871 (minimal_language_defn): Likewise.
8872 * d-lang.c (d_language_defn): Likewise.
8873 * f-lang.c (f_language_defn): Likewise.
8874 * go-lang.c (go_language_defn): Likewise.
8875 * language.c (unknown_language_defn): Likewise.
8876 (auto_language_defn): Likewise.
8877 * language.h (struct language_defn): Remove la_magic field.
8878 (LANG_MAGIC): Delete.
8879 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8880 * objc-lang.c (objc_language_defn): Likewise.
8881 * opencl-lang.c (opencl_language_defn): Likewise.
8882 * p-lang.c (pascal_language_defn): Likewise.
8883 * rust-lang.c (rust_language_defn): Likewise.
8885 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8887 * riscv-tdep.c (riscv_type_align): New function.
8888 (riscv_type_alignment): Delete.
8889 (riscv_arg_location): Use 'type_align'.
8890 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8892 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8894 * gdbtypes.c (type_align): A struct with no non-static fields also
8897 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8899 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8901 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8903 (riscv_struct_info::analyse): New implementation using new
8904 analyse_inner member function.
8905 (riscv_struct_info::field_offset): New member function.
8906 (riscv_struct_info::m_offsets): New member variable.
8907 (riscv_struct_info::analyse_inner): New private member function,
8908 takes the old implementation of riscv_struct_info::analyse but
8909 extended to track field offsets.
8910 (riscv_call_arg_struct): Update the struct folding special cases
8911 to handle cases where empty C++ structs, which are non-zero
8913 (riscv_arg_location): Initialise the length of each location, a
8914 non-zero length now indicates the location is in use.
8915 (riscv_push_dummy_call): Allow for the first location having a
8916 non-zero offset when setting up arguments.
8917 (riscv_return_value): Likewise, but for return values.
8919 2019-04-11 Tom Tromey <tromey@adacore.com>
8921 * utils.c (internal_vproblem): Make "msg" const.
8923 2019-04-11 Alan Hayward <alan.hayward@arm.com>
8925 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8926 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8927 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8928 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8930 2019-04-10 Kevin Buettner <kevinb@redhat.com>
8932 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8934 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8935 of amd64_collect_native_gregset.
8936 (amd64_linux_nat_target::store_registers): Likewise.
8938 2019-04-10 Tom Tromey <tom@tromey.com>
8940 * symtab.c (lookup_global_symbol_from_objfile)
8941 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8942 * objfiles.h (class separate_debug_iterator): New.
8943 (class separate_debug_range): New.
8944 (struct objfile) <separate_debug_objfiles>: New method.
8945 (objfile_separate_debug_iterate): Don't declare.
8946 * objfiles.c (separate_debug_iterator::operator++): Rename from
8947 objfile_separate_debug_iterate.
8948 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8950 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8953 2019-04-10 Tom Tromey <tom@tromey.com>
8955 * symfile.c (reread_symbols): Remove old comment.
8956 * objfiles.c (free_all_objfiles): Fix a typo.
8958 2019-04-10 Tom Tromey <tom@tromey.com>
8960 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8961 * minsyms.c (lookup_minimal_symbol): Use foreach.
8962 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8963 (lookup_minimal_symbol_solib_trampoline): Likewise.
8964 * symfile.c (reread_symbols): Use foreach.
8966 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
8967 Tom Tromey <tromey@adacore.com>
8970 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8971 (rust_lex_int_test): Change "value" to be LONGEST.
8972 (rust_lex_tests): Add test for long integer literal.
8974 2019-04-09 Tom Tromey <tromey@adacore.com>
8976 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8978 (extended_remote_target::attach): Update.
8979 (remote_target::remote_notice_new_inferior): Update.
8980 (remote_target::add_current_inferior_and_thread): Update.
8981 * inferior.c (exit_inferior_1): Use "false".
8982 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8984 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
8986 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8987 the "start" command.
8989 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8991 * python/py-inferior.c (infpy_thread_from_thread_handle):
8992 Adjust comments to reflect renaming of thread_from_thread_handle
8993 to thread_from_handle. Adjust keywords. Fix type error message.
8994 (inferior_object_methods): Add thread_from_handle. Retain
8995 thread_from_thread_handle, but mark it as deprecated.
8997 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8999 * gdbthread.h (find_thread_by_handle): Revise declaration.
9000 * thread.c (find_thread_by_handle): Likewise. Adjust
9002 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9003 support for buffer objects as handles.
9005 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9007 * python/py-infthread.c (thpy_thread_handle): New function.
9008 (thread_object_methods): Register thpy_thread_handle.
9010 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9012 * gdbthread.h (thread_to_thread_handle): Declare.
9013 * thread.c (gdbtypes.h): Include.
9014 (thread_to_thread_handle): New function.
9016 * target.h (struct target_ops): Add thread_info_to_thread_handle.
9017 (target_thread_info_to_thread_handle): Declare.
9018 * target.c (target_thread_info_to_thread_handle): New function.
9019 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9020 * target-delegates.c: Regenerate.
9022 * linux-thread-db.c (class thread_db_target): Add method
9023 thread_info_to_thread_handle.
9024 (thread_db_target::thread_info_to_thread_handle): Define.
9025 * remote.c (class remote_target): Add new method
9026 thread_info_to_thread_handle.
9027 (remote_target::thread_info_to_thread_handle): Define.
9029 2019-04-08 Pedro Alves <palves@redhat.com>
9031 * common/common-exceptions.c (throw_exception): Don't create
9032 named object to throw; throw directly.
9033 (throw_it): Likewise. Don't initialize gdb_exception::message
9034 here, with new; pass FMT and AP to the ctor instead.
9035 * common/common-exceptions.h: Include <string>.
9036 (gdb_exception::gdb_exception(enum return_reason, enum errors,
9037 const char *, va_list)): New ctor. Use std::make_shared.
9038 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9040 (gdb_exception_error::gdb_exception_error(enum errors, const char
9042 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9044 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9046 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9047 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9050 2019-04-08 Tom Tromey <tom@tromey.com>
9052 * valops.c (value_rtti_indirect_type): Replace throw_exception
9054 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9056 * thread.c (thr_try_catch_cmd): Replace throw_exception with
9058 * target.c (target_translate_tls_address): Replace throw_exception
9060 * stack.c (frame_apply_command_count): Replace throw_exception
9062 * solib-spu.c (append_ocl_sos): Replace throw_exception with
9064 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9066 * rs6000-tdep.c (rs6000_frame_cache)
9067 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9068 * remote.c: Replace throw_exception with throw.
9069 * record-full.c (record_full_message, record_full_wait_1)
9070 (record_full_restore): Replace throw_exception with throw.
9072 (get_thread_current_frame_id, record_btrace_start_replaying)
9073 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9074 (cmd_record_btrace_start): Replace throw_exception with throw.
9075 * parse.c (parse_exp_in_context_1): Replace throw_exception with
9077 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9078 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9080 (find_linespec_symbols): Replace throw_exception with throw.
9081 * infrun.c (displaced_step_prepare, resume): Replace
9082 throw_exception with throw.
9083 * infcmd.c (post_create_inferior): Replace throw_exception with
9085 * inf-loop.c (inferior_event_handler): Replace throw_exception
9087 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9088 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9089 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9090 (get_prev_frame_always, get_frame_pc_if_available)
9091 (get_frame_address_in_block_if_available, get_frame_language):
9092 Replace throw_exception with throw.
9093 * frame-unwind.c (frame_unwind_try_unwinder): Replace
9094 throw_exception with throw.
9095 * eval.c (fetch_subexp_value, evaluate_var_value)
9096 (evaluate_funcall, evaluate_subexp_standard): Replace
9097 throw_exception with throw.
9098 * dwarf2loc.c (call_site_find_chain)
9099 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9100 Replace throw_exception with throw.
9101 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9103 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9105 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9106 * completer.c (complete_line_internal): Replace throw_exception
9108 * compile/compile-object-run.c (compile_object_run): Replace
9109 throw_exception with throw.
9110 * cli/cli-script.c (process_next_line): Replace throw_exception
9112 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9113 (btrace_enable, btrace_maint_update_pt_packets): Replace
9114 throw_exception with throw.
9115 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9116 throw_exception with throw.
9117 * break-catch-throw.c (re_set_exception_catchpoint): Replace
9118 throw_exception with throw.
9119 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9120 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9121 * aarch64-tdep.c (aarch64_make_prologue_cache)
9122 (aarch64_make_stub_cache): Replace throw_exception with throw.
9124 2019-04-08 Tom Tromey <tom@tromey.com>
9126 * common/common-exceptions.c (throw_exception): Rename from
9127 throw_exception_cxx. Remove old copy. Make argument const.
9128 (throw_it): Create and throw exception objects directly.
9129 * common/common-exceptions.h (throw_exception): Make argument
9131 (struct gdb_exception_error): Add constructor.
9132 (struct gdb_exception_quit): Add constructor.
9134 2019-04-08 Tom Tromey <tom@tromey.com>
9136 * common/common-exceptions.h (exception_rethrow): Don't declare.
9137 (TRY_SJLJ): Update comment.
9138 (TRY, CATCH, END_CATCH): Remove.
9139 * common/common-exceptions.c (exception_rethrow): Remove.
9141 2019-04-08 Tom Tromey <tom@tromey.com>
9143 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9145 (gdb_exception_error): Rename from
9146 gdb_exception_RETURN_MASK_ERROR.
9147 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9148 (gdb_quit_bad_alloc): Update.
9149 * aarch64-tdep.c: Update.
9150 * ada-lang.c: Update.
9151 * ada-typeprint.c: Update.
9152 * ada-valprint.c: Update.
9153 * amd64-tdep.c: Update.
9154 * arch-utils.c: Update.
9155 * break-catch-throw.c: Update.
9156 * breakpoint.c: Update.
9158 * c-varobj.c: Update.
9159 * cli/cli-cmds.c: Update.
9160 * cli/cli-interp.c: Update.
9161 * cli/cli-script.c: Update.
9162 * common/common-exceptions.c: Update.
9163 * common/new-op.c: Update.
9164 * common/selftest.c: Update.
9165 * compile/compile-c-symbols.c: Update.
9166 * compile/compile-cplus-symbols.c: Update.
9167 * compile/compile-object-load.c: Update.
9168 * compile/compile-object-run.c: Update.
9169 * completer.c: Update.
9170 * corelow.c: Update.
9172 * cp-support.c: Update.
9173 * cp-valprint.c: Update.
9174 * darwin-nat.c: Update.
9175 * disasm-selftests.c: Update.
9176 * dtrace-probe.c: Update.
9177 * dwarf-index-cache.c: Update.
9178 * dwarf-index-write.c: Update.
9179 * dwarf2-frame-tailcall.c: Update.
9180 * dwarf2-frame.c: Update.
9181 * dwarf2loc.c: Update.
9182 * dwarf2read.c: Update.
9184 * event-loop.c: Update.
9185 * event-top.c: Update.
9187 * f-valprint.c: Update.
9188 * fbsd-tdep.c: Update.
9189 * frame-unwind.c: Update.
9191 * gdbtypes.c: Update.
9192 * gnu-v3-abi.c: Update.
9193 * guile/guile-internal.h: Update.
9194 * guile/scm-block.c: Update.
9195 * guile/scm-breakpoint.c: Update.
9196 * guile/scm-cmd.c: Update.
9197 * guile/scm-disasm.c: Update.
9198 * guile/scm-frame.c: Update.
9199 * guile/scm-lazy-string.c: Update.
9200 * guile/scm-math.c: Update.
9201 * guile/scm-param.c: Update.
9202 * guile/scm-ports.c: Update.
9203 * guile/scm-pretty-print.c: Update.
9204 * guile/scm-symbol.c: Update.
9205 * guile/scm-symtab.c: Update.
9206 * guile/scm-type.c: Update.
9207 * guile/scm-value.c: Update.
9208 * i386-linux-tdep.c: Update.
9209 * i386-tdep.c: Update.
9210 * inf-loop.c: Update.
9211 * infcall.c: Update.
9215 * language.c: Update.
9216 * linespec.c: Update.
9217 * linux-fork.c: Update.
9218 * linux-nat.c: Update.
9219 * linux-tdep.c: Update.
9220 * linux-thread-db.c: Update.
9222 * mi/mi-cmd-break.c: Update.
9223 * mi/mi-cmd-stack.c: Update.
9224 * mi/mi-interp.c: Update.
9225 * mi/mi-main.c: Update.
9226 * objc-lang.c: Update.
9227 * p-valprint.c: Update.
9229 * ppc-linux-tdep.c: Update.
9230 * printcmd.c: Update.
9231 * python/py-arch.c: Update.
9232 * python/py-breakpoint.c: Update.
9233 * python/py-cmd.c: Update.
9234 * python/py-finishbreakpoint.c: Update.
9235 * python/py-frame.c: Update.
9236 * python/py-framefilter.c: Update.
9237 * python/py-gdb-readline.c: Update.
9238 * python/py-inferior.c: Update.
9239 * python/py-infthread.c: Update.
9240 * python/py-lazy-string.c: Update.
9241 * python/py-linetable.c: Update.
9242 * python/py-objfile.c: Update.
9243 * python/py-param.c: Update.
9244 * python/py-prettyprint.c: Update.
9245 * python/py-progspace.c: Update.
9246 * python/py-record-btrace.c: Update.
9247 * python/py-record.c: Update.
9248 * python/py-symbol.c: Update.
9249 * python/py-type.c: Update.
9250 * python/py-unwind.c: Update.
9251 * python/py-utils.c: Update.
9252 * python/py-value.c: Update.
9253 * python/python.c: Update.
9254 * record-btrace.c: Update.
9255 * record-full.c: Update.
9256 * remote-fileio.c: Update.
9258 * riscv-tdep.c: Update.
9259 * rs6000-aix-tdep.c: Update.
9260 * rs6000-tdep.c: Update.
9261 * rust-exp.y: Update.
9262 * rust-lang.c: Update.
9263 * s390-tdep.c: Update.
9264 * selftest-arch.c: Update.
9265 * solib-dsbt.c: Update.
9266 * solib-frv.c: Update.
9267 * solib-spu.c: Update.
9268 * solib-svr4.c: Update.
9270 * sparc64-linux-tdep.c: Update.
9272 * symfile-mem.c: Update.
9273 * symmisc.c: Update.
9277 * tracefile-tfile.c: Update.
9278 * tui/tui.c: Update.
9279 * typeprint.c: Update.
9280 * unittests/cli-utils-selftests.c: Update.
9281 * unittests/parse-connection-spec-selftests.c: Update.
9283 * valprint.c: Update.
9286 * windows-nat.c: Update.
9287 * x86-linux-nat.c: Update.
9288 * xml-support.c: Update.
9290 2019-04-08 Tom Tromey <tom@tromey.com>
9292 * xml-support.c: Use C++ exception handling.
9293 * x86-linux-nat.c: Use C++ exception handling.
9294 * windows-nat.c: Use C++ exception handling.
9295 * varobj.c: Use C++ exception handling.
9296 * value.c: Use C++ exception handling.
9297 * valprint.c: Use C++ exception handling.
9298 * valops.c: Use C++ exception handling.
9299 * unittests/parse-connection-spec-selftests.c: Use C++ exception
9301 * unittests/cli-utils-selftests.c: Use C++ exception handling.
9302 * typeprint.c: Use C++ exception handling.
9303 * tui/tui.c: Use C++ exception handling.
9304 * tracefile-tfile.c: Use C++ exception handling.
9305 * top.c: Use C++ exception handling.
9306 * thread.c: Use C++ exception handling.
9307 * target.c: Use C++ exception handling.
9308 * symmisc.c: Use C++ exception handling.
9309 * symfile-mem.c: Use C++ exception handling.
9310 * stack.c: Use C++ exception handling.
9311 * sparc64-linux-tdep.c: Use C++ exception handling.
9312 * solib.c: Use C++ exception handling.
9313 * solib-svr4.c: Use C++ exception handling.
9314 * solib-spu.c: Use C++ exception handling.
9315 * solib-frv.c: Use C++ exception handling.
9316 * solib-dsbt.c: Use C++ exception handling.
9317 * selftest-arch.c: Use C++ exception handling.
9318 * s390-tdep.c: Use C++ exception handling.
9319 * rust-lang.c: Use C++ exception handling.
9320 * rust-exp.y: Use C++ exception handling.
9321 * rs6000-tdep.c: Use C++ exception handling.
9322 * rs6000-aix-tdep.c: Use C++ exception handling.
9323 * riscv-tdep.c: Use C++ exception handling.
9324 * remote.c: Use C++ exception handling.
9325 * remote-fileio.c: Use C++ exception handling.
9326 * record-full.c: Use C++ exception handling.
9327 * record-btrace.c: Use C++ exception handling.
9328 * python/python.c: Use C++ exception handling.
9329 * python/py-value.c: Use C++ exception handling.
9330 * python/py-utils.c: Use C++ exception handling.
9331 * python/py-unwind.c: Use C++ exception handling.
9332 * python/py-type.c: Use C++ exception handling.
9333 * python/py-symbol.c: Use C++ exception handling.
9334 * python/py-record.c: Use C++ exception handling.
9335 * python/py-record-btrace.c: Use C++ exception handling.
9336 * python/py-progspace.c: Use C++ exception handling.
9337 * python/py-prettyprint.c: Use C++ exception handling.
9338 * python/py-param.c: Use C++ exception handling.
9339 * python/py-objfile.c: Use C++ exception handling.
9340 * python/py-linetable.c: Use C++ exception handling.
9341 * python/py-lazy-string.c: Use C++ exception handling.
9342 * python/py-infthread.c: Use C++ exception handling.
9343 * python/py-inferior.c: Use C++ exception handling.
9344 * python/py-gdb-readline.c: Use C++ exception handling.
9345 * python/py-framefilter.c: Use C++ exception handling.
9346 * python/py-frame.c: Use C++ exception handling.
9347 * python/py-finishbreakpoint.c: Use C++ exception handling.
9348 * python/py-cmd.c: Use C++ exception handling.
9349 * python/py-breakpoint.c: Use C++ exception handling.
9350 * python/py-arch.c: Use C++ exception handling.
9351 * printcmd.c: Use C++ exception handling.
9352 * ppc-linux-tdep.c: Use C++ exception handling.
9353 * parse.c: Use C++ exception handling.
9354 * p-valprint.c: Use C++ exception handling.
9355 * objc-lang.c: Use C++ exception handling.
9356 * mi/mi-main.c: Use C++ exception handling.
9357 * mi/mi-interp.c: Use C++ exception handling.
9358 * mi/mi-cmd-stack.c: Use C++ exception handling.
9359 * mi/mi-cmd-break.c: Use C++ exception handling.
9360 * main.c: Use C++ exception handling.
9361 * linux-thread-db.c: Use C++ exception handling.
9362 * linux-tdep.c: Use C++ exception handling.
9363 * linux-nat.c: Use C++ exception handling.
9364 * linux-fork.c: Use C++ exception handling.
9365 * linespec.c: Use C++ exception handling.
9366 * language.c: Use C++ exception handling.
9367 * jit.c: Use C++ exception handling.
9368 * infrun.c: Use C++ exception handling.
9369 * infcmd.c: Use C++ exception handling.
9370 * infcall.c: Use C++ exception handling.
9371 * inf-loop.c: Use C++ exception handling.
9372 * i386-tdep.c: Use C++ exception handling.
9373 * i386-linux-tdep.c: Use C++ exception handling.
9374 * guile/scm-value.c: Use C++ exception handling.
9375 * guile/scm-type.c: Use C++ exception handling.
9376 * guile/scm-symtab.c: Use C++ exception handling.
9377 * guile/scm-symbol.c: Use C++ exception handling.
9378 * guile/scm-pretty-print.c: Use C++ exception handling.
9379 * guile/scm-ports.c: Use C++ exception handling.
9380 * guile/scm-param.c: Use C++ exception handling.
9381 * guile/scm-math.c: Use C++ exception handling.
9382 * guile/scm-lazy-string.c: Use C++ exception handling.
9383 * guile/scm-frame.c: Use C++ exception handling.
9384 * guile/scm-disasm.c: Use C++ exception handling.
9385 * guile/scm-cmd.c: Use C++ exception handling.
9386 * guile/scm-breakpoint.c: Use C++ exception handling.
9387 * guile/scm-block.c: Use C++ exception handling.
9388 * guile/guile-internal.h: Use C++ exception handling.
9389 * gnu-v3-abi.c: Use C++ exception handling.
9390 * gdbtypes.c: Use C++ exception handling.
9391 * frame.c: Use C++ exception handling.
9392 * frame-unwind.c: Use C++ exception handling.
9393 * fbsd-tdep.c: Use C++ exception handling.
9394 * f-valprint.c: Use C++ exception handling.
9395 * exec.c: Use C++ exception handling.
9396 * event-top.c: Use C++ exception handling.
9397 * event-loop.c: Use C++ exception handling.
9398 * eval.c: Use C++ exception handling.
9399 * dwarf2read.c: Use C++ exception handling.
9400 * dwarf2loc.c: Use C++ exception handling.
9401 * dwarf2-frame.c: Use C++ exception handling.
9402 * dwarf2-frame-tailcall.c: Use C++ exception handling.
9403 * dwarf-index-write.c: Use C++ exception handling.
9404 * dwarf-index-cache.c: Use C++ exception handling.
9405 * dtrace-probe.c: Use C++ exception handling.
9406 * disasm-selftests.c: Use C++ exception handling.
9407 * darwin-nat.c: Use C++ exception handling.
9408 * cp-valprint.c: Use C++ exception handling.
9409 * cp-support.c: Use C++ exception handling.
9410 * cp-abi.c: Use C++ exception handling.
9411 * corelow.c: Use C++ exception handling.
9412 * completer.c: Use C++ exception handling.
9413 * compile/compile-object-run.c: Use C++ exception handling.
9414 * compile/compile-object-load.c: Use C++ exception handling.
9415 * compile/compile-cplus-symbols.c: Use C++ exception handling.
9416 * compile/compile-c-symbols.c: Use C++ exception handling.
9417 * common/selftest.c: Use C++ exception handling.
9418 * common/new-op.c: Use C++ exception handling.
9419 * cli/cli-script.c: Use C++ exception handling.
9420 * cli/cli-interp.c: Use C++ exception handling.
9421 * cli/cli-cmds.c: Use C++ exception handling.
9422 * c-varobj.c: Use C++ exception handling.
9423 * btrace.c: Use C++ exception handling.
9424 * breakpoint.c: Use C++ exception handling.
9425 * break-catch-throw.c: Use C++ exception handling.
9426 * arch-utils.c: Use C++ exception handling.
9427 * amd64-tdep.c: Use C++ exception handling.
9428 * ada-valprint.c: Use C++ exception handling.
9429 * ada-typeprint.c: Use C++ exception handling.
9430 * ada-lang.c: Use C++ exception handling.
9431 * aarch64-tdep.c: Use C++ exception handling.
9433 2019-04-08 Tom Tromey <tom@tromey.com>
9435 * xml-support.c (gdb_xml_parser::parse): Update.
9436 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9437 * value.c (show_convenience): Update.
9438 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9439 (test_parse_flags_qcs): Update.
9440 * thread.c (thr_try_catch_cmd): Update.
9441 * target.c (target_translate_tls_address): Update.
9442 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9443 (info_frame_command_core, frame_apply_command_count): Update.
9444 * rust-exp.y (rust_lex_exception_test): Update.
9445 * riscv-tdep.c (riscv_print_one_register_info): Update.
9446 * remote.c (remote_target::enable_btrace): Update.
9447 * record-btrace.c (record_btrace_enable_warn): Update.
9448 * python/py-utils.c (gdbpy_convert_exception): Update.
9449 * printcmd.c (do_one_display, print_variable_and_value): Update.
9450 * mi/mi-main.c (mi_print_exception): Update.
9451 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9452 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9453 * linux-nat.c (linux_nat_target::attach): Update.
9454 * linux-fork.c (class scoped_switch_fork_info): Update.
9455 * infrun.c (displaced_step_prepare): Update.
9456 * infcall.c (call_function_by_hand_dummy): Update.
9457 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9458 * gnu-v3-abi.c (print_one_vtable): Update.
9459 * frame.c (get_prev_frame_always): Update.
9460 * f-valprint.c (info_common_command_for_block): Update.
9461 * exec.c (try_open_exec_file): Update.
9462 * exceptions.c (print_exception, exception_print)
9463 (exception_fprintf, exception_print_same): Update.
9464 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9465 * dwarf-index-cache.c (index_cache::store)
9466 (index_cache::lookup_gdb_index): Update.
9467 * darwin-nat.c (maybe_cache_shell): Update.
9468 * cp-valprint.c (cp_print_value_fields): Update.
9469 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9470 (gcc_cplus_symbol_address): Update.
9471 * compile/compile-c-symbols.c (gcc_convert_symbol)
9472 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9473 * common/selftest.c: Update.
9474 * common/common-exceptions.h (struct gdb_exception) <message>: Now
9476 (exception_try_scope_entry, exception_try_scope_exit): Don't
9478 (struct exception_try_scope): Remove.
9479 (TRY): Don't use exception_try_scope.
9480 (struct gdb_exception): Add constructor, operator=.
9482 (struct gdb_exception_RETURN_MASK_ALL)
9483 (struct gdb_exception_RETURN_MASK_ERROR)
9484 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9485 (struct gdb_quit_bad_alloc): Update.
9486 * common/common-exceptions.c (exception_none): Change
9488 (struct catcher) <state, exception>: Initialize inline.
9489 <prev>: Remove member.
9490 (current_catcher): Remove.
9491 (catchers): New global.
9492 (exceptions_state_mc_init): Simplify.
9493 (catcher_pop): Remove.
9494 (exceptions_state_mc, exceptions_state_mc_catch): Update.
9495 (try_scope_depth, exception_try_scope_entry)
9496 (exception_try_scope_exit): Remove.
9497 (throw_exception_sjlj): Update.
9498 (exception_messages, exception_messages_size): Remove.
9499 (throw_it): Simplify.
9500 (gdb_exception_sliced_copy): Remove.
9501 (throw_exception_cxx): Update.
9502 * cli/cli-script.c (script_from_file): Update.
9503 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9505 * ada-valprint.c (ada_val_print): Update.
9506 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9507 (create_excep_cond_exprs): Update.
9509 2019-04-08 Tom Tromey <tom@tromey.com>
9511 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9512 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9513 (TRY, CATCH, END_CATCH): Remove some definitions.
9514 * common/common-exceptions.c: Don't use GDB_XCPT.
9515 (catcher_list_size): Remove.
9516 (throw_exception, throw_it): Simplify.
9518 2019-04-05 Tom Tromey <tom@tromey.com>
9520 Revert the header-sorting patch.
9521 * ft32-tdep.c: Revert.
9522 * frv-tdep.c: Revert.
9523 * frv-linux-tdep.c: Revert.
9525 * frame-unwind.c: Revert.
9526 * frame-base.c: Revert.
9527 * fork-child.c: Revert.
9528 * findvar.c: Revert.
9529 * findcmd.c: Revert.
9530 * filesystem.c: Revert.
9531 * filename-seen-cache.h: Revert.
9532 * filename-seen-cache.c: Revert.
9533 * fbsd-tdep.c: Revert.
9534 * fbsd-nat.h: Revert.
9535 * fbsd-nat.c: Revert.
9536 * f-valprint.c: Revert.
9537 * f-typeprint.c: Revert.
9539 * extension.h: Revert.
9540 * extension.c: Revert.
9541 * extension-priv.h: Revert.
9542 * expprint.c: Revert.
9545 * exceptions.c: Revert.
9546 * event-top.c: Revert.
9547 * event-loop.c: Revert.
9549 * elfread.c: Revert.
9550 * dwarf2read.h: Revert.
9551 * dwarf2read.c: Revert.
9552 * dwarf2loc.c: Revert.
9553 * dwarf2expr.h: Revert.
9554 * dwarf2expr.c: Revert.
9555 * dwarf2-frame.c: Revert.
9556 * dwarf2-frame-tailcall.c: Revert.
9557 * dwarf-index-write.h: Revert.
9558 * dwarf-index-write.c: Revert.
9559 * dwarf-index-common.c: Revert.
9560 * dwarf-index-cache.h: Revert.
9561 * dwarf-index-cache.c: Revert.
9562 * dummy-frame.c: Revert.
9563 * dtrace-probe.c: Revert.
9566 * disasm-selftests.c: Revert.
9567 * dictionary.c: Revert.
9568 * dicos-tdep.c: Revert.
9569 * demangle.c: Revert.
9572 * darwin-nat.h: Revert.
9573 * darwin-nat.c: Revert.
9574 * darwin-nat-info.c: Revert.
9575 * d-valprint.c: Revert.
9576 * d-namespace.c: Revert.
9579 * csky-tdep.c: Revert.
9580 * csky-linux-tdep.c: Revert.
9581 * cris-tdep.c: Revert.
9582 * cris-linux-tdep.c: Revert.
9583 * cp-valprint.c: Revert.
9584 * cp-support.c: Revert.
9585 * cp-namespace.c: Revert.
9587 * corelow.c: Revert.
9588 * corefile.c: Revert.
9589 * continuations.c: Revert.
9590 * completer.h: Revert.
9591 * completer.c: Revert.
9592 * complaints.c: Revert.
9593 * coffread.c: Revert.
9594 * coff-pe-read.c: Revert.
9595 * cli-out.h: Revert.
9596 * cli-out.c: Revert.
9597 * charset.c: Revert.
9598 * c-varobj.c: Revert.
9599 * c-valprint.c: Revert.
9600 * c-typeprint.c: Revert.
9602 * buildsym.c: Revert.
9603 * buildsym-legacy.c: Revert.
9604 * build-id.h: Revert.
9605 * build-id.c: Revert.
9607 * bsd-uthread.c: Revert.
9608 * breakpoint.h: Revert.
9609 * breakpoint.c: Revert.
9610 * break-catch-throw.c: Revert.
9611 * break-catch-syscall.c: Revert.
9612 * break-catch-sig.c: Revert.
9613 * blockframe.c: Revert.
9615 * bfin-tdep.c: Revert.
9616 * bfin-linux-tdep.c: Revert.
9617 * bfd-target.c: Revert.
9619 * ax-general.c: Revert.
9622 * avr-tdep.c: Revert.
9624 * auto-load.c: Revert.
9625 * arm-wince-tdep.c: Revert.
9626 * arm-tdep.c: Revert.
9627 * arm-symbian-tdep.c: Revert.
9628 * arm-pikeos-tdep.c: Revert.
9629 * arm-obsd-tdep.c: Revert.
9630 * arm-nbsd-tdep.c: Revert.
9631 * arm-nbsd-nat.c: Revert.
9632 * arm-linux-tdep.c: Revert.
9633 * arm-linux-nat.c: Revert.
9634 * arm-fbsd-tdep.c: Revert.
9635 * arm-fbsd-nat.c: Revert.
9636 * arm-bsd-tdep.c: Revert.
9637 * arch-utils.c: Revert.
9638 * arc-tdep.c: Revert.
9639 * arc-newlib-tdep.c: Revert.
9640 * annotate.h: Revert.
9641 * annotate.c: Revert.
9642 * amd64-windows-tdep.c: Revert.
9643 * amd64-windows-nat.c: Revert.
9644 * amd64-tdep.c: Revert.
9645 * amd64-sol2-tdep.c: Revert.
9646 * amd64-obsd-tdep.c: Revert.
9647 * amd64-obsd-nat.c: Revert.
9648 * amd64-nbsd-tdep.c: Revert.
9649 * amd64-nbsd-nat.c: Revert.
9650 * amd64-nat.c: Revert.
9651 * amd64-linux-tdep.c: Revert.
9652 * amd64-linux-nat.c: Revert.
9653 * amd64-fbsd-tdep.c: Revert.
9654 * amd64-fbsd-nat.c: Revert.
9655 * amd64-dicos-tdep.c: Revert.
9656 * amd64-darwin-tdep.c: Revert.
9657 * amd64-bsd-nat.c: Revert.
9658 * alpha-tdep.c: Revert.
9659 * alpha-obsd-tdep.c: Revert.
9660 * alpha-nbsd-tdep.c: Revert.
9661 * alpha-mdebug-tdep.c: Revert.
9662 * alpha-linux-tdep.c: Revert.
9663 * alpha-linux-nat.c: Revert.
9664 * alpha-bsd-tdep.c: Revert.
9665 * alpha-bsd-nat.c: Revert.
9666 * aix-thread.c: Revert.
9668 * addrmap.c: Revert.
9669 * ada-varobj.c: Revert.
9670 * ada-valprint.c: Revert.
9671 * ada-typeprint.c: Revert.
9672 * ada-tasks.c: Revert.
9673 * ada-lang.c: Revert.
9674 * aarch64-tdep.c: Revert.
9675 * aarch64-ravenscar-thread.c: Revert.
9676 * aarch64-newlib-tdep.c: Revert.
9677 * aarch64-linux-tdep.c: Revert.
9678 * aarch64-linux-nat.c: Revert.
9679 * aarch64-fbsd-tdep.c: Revert.
9680 * aarch64-fbsd-nat.c: Revert.
9681 * aarch32-linux-nat.c: Revert.
9683 2019-04-05 Tom Tromey <tom@tromey.com>
9685 * ft32-tdep.c: Sort headers.
9686 * frv-tdep.c: Sort headers.
9687 * frv-linux-tdep.c: Sort headers.
9688 * frame.c: Sort headers.
9689 * frame-unwind.c: Sort headers.
9690 * frame-base.c: Sort headers.
9691 * fork-child.c: Sort headers.
9692 * findvar.c: Sort headers.
9693 * findcmd.c: Sort headers.
9694 * filesystem.c: Sort headers.
9695 * filename-seen-cache.h: Sort headers.
9696 * filename-seen-cache.c: Sort headers.
9697 * fbsd-tdep.c: Sort headers.
9698 * fbsd-nat.h: Sort headers.
9699 * fbsd-nat.c: Sort headers.
9700 * f-valprint.c: Sort headers.
9701 * f-typeprint.c: Sort headers.
9702 * f-lang.c: Sort headers.
9703 * extension.h: Sort headers.
9704 * extension.c: Sort headers.
9705 * extension-priv.h: Sort headers.
9706 * expprint.c: Sort headers.
9707 * exec.h: Sort headers.
9708 * exec.c: Sort headers.
9709 * exceptions.c: Sort headers.
9710 * event-top.c: Sort headers.
9711 * event-loop.c: Sort headers.
9712 * eval.c: Sort headers.
9713 * elfread.c: Sort headers.
9714 * dwarf2read.h: Sort headers.
9715 * dwarf2read.c: Sort headers.
9716 * dwarf2loc.c: Sort headers.
9717 * dwarf2expr.h: Sort headers.
9718 * dwarf2expr.c: Sort headers.
9719 * dwarf2-frame.c: Sort headers.
9720 * dwarf2-frame-tailcall.c: Sort headers.
9721 * dwarf-index-write.h: Sort headers.
9722 * dwarf-index-write.c: Sort headers.
9723 * dwarf-index-common.c: Sort headers.
9724 * dwarf-index-cache.h: Sort headers.
9725 * dwarf-index-cache.c: Sort headers.
9726 * dummy-frame.c: Sort headers.
9727 * dtrace-probe.c: Sort headers.
9728 * disasm.h: Sort headers.
9729 * disasm.c: Sort headers.
9730 * disasm-selftests.c: Sort headers.
9731 * dictionary.c: Sort headers.
9732 * dicos-tdep.c: Sort headers.
9733 * demangle.c: Sort headers.
9734 * dcache.h: Sort headers.
9735 * dcache.c: Sort headers.
9736 * darwin-nat.h: Sort headers.
9737 * darwin-nat.c: Sort headers.
9738 * darwin-nat-info.c: Sort headers.
9739 * d-valprint.c: Sort headers.
9740 * d-namespace.c: Sort headers.
9741 * d-lang.c: Sort headers.
9742 * ctf.c: Sort headers.
9743 * csky-tdep.c: Sort headers.
9744 * csky-linux-tdep.c: Sort headers.
9745 * cris-tdep.c: Sort headers.
9746 * cris-linux-tdep.c: Sort headers.
9747 * cp-valprint.c: Sort headers.
9748 * cp-support.c: Sort headers.
9749 * cp-namespace.c: Sort headers.
9750 * cp-abi.c: Sort headers.
9751 * corelow.c: Sort headers.
9752 * corefile.c: Sort headers.
9753 * continuations.c: Sort headers.
9754 * completer.h: Sort headers.
9755 * completer.c: Sort headers.
9756 * complaints.c: Sort headers.
9757 * coffread.c: Sort headers.
9758 * coff-pe-read.c: Sort headers.
9759 * cli-out.h: Sort headers.
9760 * cli-out.c: Sort headers.
9761 * charset.c: Sort headers.
9762 * c-varobj.c: Sort headers.
9763 * c-valprint.c: Sort headers.
9764 * c-typeprint.c: Sort headers.
9765 * c-lang.c: Sort headers.
9766 * buildsym.c: Sort headers.
9767 * buildsym-legacy.c: Sort headers.
9768 * build-id.h: Sort headers.
9769 * build-id.c: Sort headers.
9770 * btrace.c: Sort headers.
9771 * bsd-uthread.c: Sort headers.
9772 * breakpoint.h: Sort headers.
9773 * breakpoint.c: Sort headers.
9774 * break-catch-throw.c: Sort headers.
9775 * break-catch-syscall.c: Sort headers.
9776 * break-catch-sig.c: Sort headers.
9777 * blockframe.c: Sort headers.
9778 * block.c: Sort headers.
9779 * bfin-tdep.c: Sort headers.
9780 * bfin-linux-tdep.c: Sort headers.
9781 * bfd-target.c: Sort headers.
9782 * bcache.c: Sort headers.
9783 * ax-general.c: Sort headers.
9784 * ax-gdb.h: Sort headers.
9785 * ax-gdb.c: Sort headers.
9786 * avr-tdep.c: Sort headers.
9787 * auxv.c: Sort headers.
9788 * auto-load.c: Sort headers.
9789 * arm-wince-tdep.c: Sort headers.
9790 * arm-tdep.c: Sort headers.
9791 * arm-symbian-tdep.c: Sort headers.
9792 * arm-pikeos-tdep.c: Sort headers.
9793 * arm-obsd-tdep.c: Sort headers.
9794 * arm-nbsd-tdep.c: Sort headers.
9795 * arm-nbsd-nat.c: Sort headers.
9796 * arm-linux-tdep.c: Sort headers.
9797 * arm-linux-nat.c: Sort headers.
9798 * arm-fbsd-tdep.c: Sort headers.
9799 * arm-fbsd-nat.c: Sort headers.
9800 * arm-bsd-tdep.c: Sort headers.
9801 * arch-utils.c: Sort headers.
9802 * arc-tdep.c: Sort headers.
9803 * arc-newlib-tdep.c: Sort headers.
9804 * annotate.h: Sort headers.
9805 * annotate.c: Sort headers.
9806 * amd64-windows-tdep.c: Sort headers.
9807 * amd64-windows-nat.c: Sort headers.
9808 * amd64-tdep.c: Sort headers.
9809 * amd64-sol2-tdep.c: Sort headers.
9810 * amd64-obsd-tdep.c: Sort headers.
9811 * amd64-obsd-nat.c: Sort headers.
9812 * amd64-nbsd-tdep.c: Sort headers.
9813 * amd64-nbsd-nat.c: Sort headers.
9814 * amd64-nat.c: Sort headers.
9815 * amd64-linux-tdep.c: Sort headers.
9816 * amd64-linux-nat.c: Sort headers.
9817 * amd64-fbsd-tdep.c: Sort headers.
9818 * amd64-fbsd-nat.c: Sort headers.
9819 * amd64-dicos-tdep.c: Sort headers.
9820 * amd64-darwin-tdep.c: Sort headers.
9821 * amd64-bsd-nat.c: Sort headers.
9822 * alpha-tdep.c: Sort headers.
9823 * alpha-obsd-tdep.c: Sort headers.
9824 * alpha-nbsd-tdep.c: Sort headers.
9825 * alpha-mdebug-tdep.c: Sort headers.
9826 * alpha-linux-tdep.c: Sort headers.
9827 * alpha-linux-nat.c: Sort headers.
9828 * alpha-bsd-tdep.c: Sort headers.
9829 * alpha-bsd-nat.c: Sort headers.
9830 * aix-thread.c: Sort headers.
9831 * agent.c: Sort headers.
9832 * addrmap.c: Sort headers.
9833 * ada-varobj.c: Sort headers.
9834 * ada-valprint.c: Sort headers.
9835 * ada-typeprint.c: Sort headers.
9836 * ada-tasks.c: Sort headers.
9837 * ada-lang.c: Sort headers.
9838 * aarch64-tdep.c: Sort headers.
9839 * aarch64-ravenscar-thread.c: Sort headers.
9840 * aarch64-newlib-tdep.c: Sort headers.
9841 * aarch64-linux-tdep.c: Sort headers.
9842 * aarch64-linux-nat.c: Sort headers.
9843 * aarch64-fbsd-tdep.c: Sort headers.
9844 * aarch64-fbsd-nat.c: Sort headers.
9845 * aarch32-linux-nat.c: Sort headers.
9847 2019-04-04 Tom Tromey <tom@tromey.com>
9849 * varobj.c (varobj_create): Update.
9850 * rust-exp.y (struct rust_parser) <update_innermost_block,
9851 lookup_symbol>: New methods.
9852 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9854 (rust_parser::rust_lookup_type)
9855 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9856 * printcmd.c (display_command, do_one_display): Update.
9857 * parser-defs.h (struct parser_state) <parser_state>: Add
9858 "tracker" parameter.
9859 (block_tracker): New member.
9860 (class innermost_block_tracker) <innermost_block_tracker>: Add
9862 <reset>: Remove method.
9863 (innermost_block): Don't declare.
9864 (null_post_parser): Update.
9865 * parse.c (innermost_block): Remove global.
9866 (write_dollar_variable): Update.
9867 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9868 Remove "tracker_types" parameter.
9869 (parse_expression): Add "tracker" parameter.
9870 (parse_expression_for_completion): Update.
9871 (null_post_parser): Add "tracker" parameter.
9872 * p-exp.y: Update rules.
9873 * m2-exp.y: Update rules.
9874 * language.h (struct language_defn) <la_post_parser>: Add
9875 "tracker" parameter.
9876 * go-exp.y: Update rules.
9877 * f-exp.y: Update rules.
9878 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9880 * d-exp.y: Update rules.
9881 * c-exp.y: Update rules.
9882 * breakpoint.c (set_breakpoint_condition): Create an
9883 innermost_block_tracker.
9884 (watch_command_1): Likewise.
9885 * ada-lang.c (resolve): Add "tracker" parameter.
9886 (resolve_subexp): Likewise.
9887 * ada-exp.y (write_var_from_sym): Update.
9889 2019-04-04 Tom Tromey <tom@tromey.com>
9891 * type-stack.h: New file.
9892 * type-stack.c: New file.
9893 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9895 (insert_into_type_stack, insert_type, push_type, push_type_int)
9896 (insert_type_address_space, pop_type, pop_type_int)
9897 (pop_typelist, pop_type_stack, append_type_stack)
9898 (push_type_stack, get_type_stack, push_typelist)
9899 (follow_type_instance_flags, follow_types): Don't declare.
9900 * parse.c (type_stack): Remove global.
9901 (parse_exp_in_context): Update.
9902 (insert_into_type_stack, insert_type, push_type, push_type_int)
9903 (insert_type_address_space, pop_type, pop_type_int)
9904 (pop_typelist, pop_type_stack, append_type_stack)
9905 (push_type_stack, get_type_stack, push_typelist)
9906 (follow_type_instance_flags, follow_types): Remove (moved to
9908 * f-exp.y (type_stack): New global.
9910 (push_kind_type, f_parse): Update.
9911 * d-exp.y (type_stack): New global.
9914 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9916 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9917 (HFILES_NO_SRCDIR): Add type-stack.h.
9919 2019-04-04 Tom Tromey <tom@tromey.com>
9921 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9922 (rust_parser::convert_ast_to_expression, rust_parse)
9923 (rust_lex_test_completion, rust_lex_tests): Update.
9924 * parser-defs.h (struct expr_completion_state): New.
9925 (struct parser_state) <parser_state>: Add completion parameter.
9926 <mark_struct_expression, mark_completion_tag>: New methods.
9927 <parse_completion, m_completion_state>: New members.
9928 (prefixify_expression, null_post_parser): Update.
9929 (mark_struct_expression, mark_completion_tag): Don't declare.
9930 * parse.c (parse_completion, expout_last_struct)
9931 (expout_tag_completion_type, expout_completion_name): Remove
9933 (parser_state::mark_struct_expression)
9934 (parser_state::mark_completion_tag): Now methods.
9935 (prefixify_expression): Add last_struct parameter.
9936 (prefixify_subexp): Likewise.
9937 (parse_exp_1): Update.
9938 (parse_exp_in_context): Add cstate parameter. Update.
9939 (parse_expression_for_completion): Create an
9940 expr_completion_state.
9941 (null_post_parser): Add "completion" parameter.
9942 * p-exp.y: Update rules.
9944 * language.h (struct language_defn) <la_post_parser>: Add
9945 "completing" parameter.
9946 * go-exp.y: Update rules.
9947 (lex_one_token): Update.
9948 * expression.h (parse_completion): Don't declare.
9949 * d-exp.y: Update rules.
9950 (lex_one_token): Update rules.
9951 * c-exp.y: Update rules.
9952 (lex_one_token): Update.
9953 * ada-lang.c (resolve): Add "parse_completion" parameter.
9954 (resolve_subexp): Likewise.
9955 (ada_resolve_function): Likewise.
9957 2019-04-04 Tom Tromey <tom@tromey.com>
9959 * parser-defs.h (struct parser_state) <start_arglist,
9960 end_arglist>: New methods.
9961 <arglist_len, m_funcall_chain>: New members.
9962 (arglist_len, start_arglist, end_arglist): Don't declare.
9963 * parse.c (arglist_len, funcall_chain): Remove global.
9964 (start_arglist, end_arglist): Remove functions.
9965 (parse_exp_in_context): Update.
9966 * p-exp.y: Update rules.
9967 * m2-exp.y: Update rules.
9968 * go-exp.y: Update rules.
9969 * f-exp.y: Update rules.
9970 * d-exp.y: Update rules.
9971 * c-exp.y: Update rules.
9973 2019-04-04 Tom Tromey <tom@tromey.com>
9975 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9976 lex_operator, push_back>: New methods.
9978 (rust_parser::lex_hex, lex_escape): Rename and update.
9979 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9980 (rust_parser::lex_operator): Rename and update.
9981 (rust_parser::lex_number, rustyylex, rustyyerror)
9982 (rust_lex_test_init, rust_lex_test_sequence)
9983 (rust_lex_test_push_back, rust_lex_tests): Update.
9984 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9986 <lexptr, prev_lexptr>: New members.
9987 (lexptr, prev_lexptr): Don't declare.
9988 * parse.c (lexptr, prev_lexptr): Remove globals.
9989 (parse_exp_in_context): Update.
9990 * p-exp.y (yylex, yyerror): Update.
9991 * m2-exp.y (parse_number, yylex, yyerror): Update.
9992 * go-exp.y (lex_one_token, yyerror): Update.
9993 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9994 * d-exp.y (lex_one_token, yyerror): Update.
9995 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9996 (lex_one_token, yyerror): Update.
9997 * ada-lex.l (YY_INPUT): Update.
9998 (rewind_to_char): Update.
9999 * ada-exp.y (yyerror): Update.
10001 2019-04-04 Tom Tromey <tom@tromey.com>
10003 * rust-exp.y (rustyylex, rust_lex_tests): Update.
10004 * parser-defs.h (struct parser_state) <parser_state>: Add new
10006 <comma_terminates>: New member.
10007 (comma_terminates): Don't declare global.
10008 * parse.c (comma_terminates): Remove global.
10009 (parse_exp_in_context): Update.
10010 * p-exp.y (yylex): Update.
10011 * m2-exp.y (yylex): Update.
10012 * go-exp.y (lex_one_token): Update.
10013 * f-exp.y (yylex): Update.
10014 * d-exp.y (lex_one_token): Update.
10015 * c-exp.y (lex_one_token): Update.
10016 * ada-lex.l: Update.
10018 2019-04-04 Tom Tromey <tom@tromey.com>
10020 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10021 (rustyylex, rust_lex_test_init, rust_lex_test_one)
10022 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10023 * parser-defs.h (paren_depth): Don't declare.
10024 * parse.c (paren_depth): Remove global.
10025 (parse_exp_in_context): Update.
10026 * p-exp.y (paren_depth): New global.
10027 (pascal_parse): Initialize it.
10028 * m2-exp.y (paren_depth): New global.
10029 (m2_parse): Initialize it.
10030 * go-exp.y (paren_depth): New global.
10031 (go_parse): Initialize it.
10032 * f-exp.y (paren_depth): New global.
10033 (f_parse): Initialize it.
10034 * d-exp.y (paren_depth): New global.
10035 (d_parse): Initialize it.
10036 * c-exp.y (paren_depth): New global.
10037 (c_parse): Initialize it.
10038 * ada-lex.l (paren_depth): New global.
10039 (lexer_init): Initialize it.
10041 2019-04-04 Tom Tromey <tom@tromey.com>
10043 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10044 (rust_parser::convert_ast_to_type)
10045 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10046 * parser-defs.h (struct parser_state) <parser_state>: Add
10047 parameters. Initialize new members.
10048 <expression_context_block, expression_context_pc>: New members.
10049 * parse.c (expression_context_block, expression_context_pc):
10051 (parse_exp_in_context): Update.
10052 * p-exp.y: Update all rules.
10054 * m2-exp.y: Update all rules.
10056 * go-exp.y (yylex): Update.
10057 * f-exp.y (yylex): Update.
10058 * d-exp.y: Update all rules.
10060 * c-exp.y: Update all rules.
10061 (lex_one_token, classify_name, yylex, c_parse): Update.
10062 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10064 2019-04-04 Tom Tromey <tom@tromey.com>
10066 * gdbarch.h, gdbarch.c: Rebuild.
10067 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10069 (struct stap_parse_info): Replace "parser_state" with
10071 * parser-defs.h (struct expr_builder): Rename from "parser_state".
10072 (parser_state): New class.
10073 * parse.c (expr_builder): Rename.
10074 (expr_builder::release): Rename.
10075 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10076 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10077 (write_exp_elt_longcst, write_exp_elt_floatcst)
10078 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10079 (write_exp_string_vector, write_exp_bitstring)
10080 (write_exp_msymbol, mark_struct_expression)
10081 (write_dollar_variable)
10082 (insert_type_address_space, increase_expout_size): Replace
10083 "parser_state" with "expr_builder".
10084 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10085 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10086 "parser_state" with "expr_builder".
10088 2019-04-04 Tom Tromey <tom@tromey.com>
10090 * rust-exp.y: Replace "parse_language" with method call.
10092 (yylex): Replace "parse_language" with method call.
10094 (yylex): Replace "parse_language" with method call.
10095 * go-exp.y (classify_name): Replace "parse_language" with method
10097 * f-exp.y (yylex): Replace "parse_language" with method call.
10098 * d-exp.y (lex_one_token): Replace "parse_language" with method
10101 (lex_one_token, classify_name, yylex): Replace "parse_language"
10103 * ada-exp.y (find_primitive_type, type_char)
10104 (type_system_address): Replace "parse_language" with method call.
10106 2019-04-04 Tom Tromey <tom@tromey.com>
10108 * rust-exp.y: Replace "parse_gdbarch" with method call.
10109 * parse.c (write_dollar_variable, insert_type_address_space):
10110 Replace "parse_gdbarch" with method call.
10111 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10113 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10115 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10116 "parse_gdbarch" with method call.
10117 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10119 * f-exp.y (parse_type, parse_f_type, yylex): Replace
10120 "parse_gdbarch" with method call.
10121 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10122 "parse_gdbarch" with method call.
10123 * c-exp.y (parse_type, parse_number, classify_name): Replace
10124 "parse_gdbarch" with method call.
10125 * ada-lex.l: Replace "parse_gdbarch" with method call.
10126 * ada-exp.y (parse_type, find_primitive_type, type_char)
10127 (type_system_address): Replace "parse_gdbarch" with method call.
10129 2019-04-04 Tom Tromey <tom@tromey.com>
10131 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10132 * stap-probe.c (stap_parse_argument): Update.
10133 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10134 initial_size parameter.
10135 * rust-exp.y (rust_lex_tests): Update.
10136 * parse.c (parser_state): Update.
10137 (parse_exp_in_context): Update.
10138 * parser-defs.h (struct parser_state) <parser_state>: Remove
10139 "initial_size" parameter.
10141 2019-04-04 Tom Tromey <tom@tromey.com>
10143 * parser-defs.h (increase_expout_size): Don't declare.
10144 * parse.c (increase_expout_size): Now static.
10146 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
10148 * gnu-nat.c (gnu_nat_target::wait): Fix
10149 target_waitstatus_to_string call.
10151 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10153 * eval.c (evaluate_subexp_standard): Handle internal functions
10154 during Fortran function call handling.
10156 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10158 * NEWS: Mention new internal functions.
10159 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10160 (read_base_type): Use dwarf2_init_complex_target_type.
10161 * value.c (creal_internal_fn): New function.
10162 (cimag_internal_fn): New function.
10163 (_initialize_values): Register new internal functions.
10165 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10167 * infrun.c (stop_all_threads): If debug_infrun, always
10168 trace the wait status after wait_one, using
10169 target_waitstatus_to_string and target_pid_to_str.
10170 (handle_inferior_event): Replace various trace of
10171 wait status kind by a single trace.
10172 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10173 wait status kind image by target_waitstatus_to_string.
10174 * target/waitstatus.c (target_waitstatus_to_string): Fix
10177 2019-04-01 Tom Tromey <tromey@adacore.com>
10180 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10182 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
10183 Pedro Alves <palves@redhat.com>
10185 * top.c (quit_force): Call 'finalize_values'.
10186 * value.c (finalize_values): New function.
10187 * value.h (finalize_values): Declare.
10189 2019-03-30 Eli Zaretskii <eliz@gnu.org>
10191 * NEWS: Announce $_gdb_major and $_gdb_minor.
10193 * top.c (init_gdb_version_vars): New function.
10194 (gdb_init): Call init_gdb_version_vars.
10196 2019-03-29 Tom Tromey <tromey@adacore.com>
10198 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
10199 help text. Remove dead code.
10201 2019-03-29 Keith Seitz <keiths@redhat.com>
10203 From Siddhesh Poyarekar:
10204 * f-lang.h (f77_get_upperbound): Return LONGEST.
10205 (f77_get_lowerbound): Likewise.
10206 * f-typeprint.c (f_type_print_varspec_suffix): Expand
10207 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
10209 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
10210 plongest to format print it.
10211 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10212 (f77_get_upperbound): Likewise.
10213 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10214 LOWER_BOUND to LONGEST.
10215 (f77_create_arrayprint_offset_tbl): Likewise.
10217 2019-03-29 Keith Seitz <keiths@redhat.com>
10219 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10220 %s/pulongest for TYPE_LENGTH instead of %d in format
10222 * ada-typerint.c (ada_print_type): Likewise.
10223 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10224 * compile/compile-c-support.c (generate_register_struct): Likewise.
10225 * gdbtypes.c (recursive_dump_type): Likewise.
10226 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10227 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
10228 instead of %d in format strings.
10229 * riscv-tdep.c (riscv_type_alignment): Cast second argument
10230 to std::min to ULONGEST.
10231 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10232 instead of %d in format strings.
10233 * tracepoint.c (info_scope_command): Likewise.
10234 * typeprint.c (print_offset_data::update)
10235 (print_offset_data::finish): Likewise.
10236 * xtensa-tdep.c (xtensa_store_return_value)
10237 (xtensa_push_dummy_call): Likewise.
10239 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
10241 * windows-nat.c (display_selector): Fixed format specifications
10244 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10246 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10248 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
10250 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10251 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10252 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10253 (nios2_linux_init_abi): Install it.
10255 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10257 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10259 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10261 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10263 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10264 Tom Tromey <tromey@adacore.com>
10266 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10268 2019-03-26 Joel Brobecker <brobecker@adacore.com>
10270 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10271 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10272 method to compute the bounds of range types. Also print "[evaluated]"
10273 if the bounds' values come from a dynamic evaluation.
10275 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
10277 * cp-valprint.c (cp_print_value_fields): Don't print trailing
10278 whitespace when pretty printing is on.
10280 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10282 * ppc-linux-nat.c: Add include.
10284 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10286 * NEWS: Mention AArch64 Pointer Authentication.
10288 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10290 * arm-linux-nat.c: Add include.
10292 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
10294 * source-cache.c (source_cache::get_source_lines): Re-read
10295 fullname after calling open_source_file.
10297 2019-03-25 John Baldwin <jhb@FreeBSD.org>
10299 * NEWS: Mention TLS support for FreeBSD.
10301 2019-03-25 Tom Tromey <tromey@adacore.com>
10303 * minsyms.c (BUNCH_SIZE): Update comment.
10304 (~minimal_symbol_reader): Remove old comment.
10305 (compact_minimal_symbols): Update comment.
10306 (minimal_symbol_reader::install): Remove old comment. Update
10309 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10311 * s390-linux-nat.c: Add include.
10313 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10315 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10316 Call linux_get_hwcap.
10317 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10319 (aarch64_linux_get_hwcap): Remove function.
10320 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10322 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10324 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10325 * linux-tdep.c (linux_get_hwcap): Add function.
10326 (linux_get_hwcap2): Likewise.
10327 * linux-tdep.h (linux_get_hwcap): Add declaration.
10328 (linux_get_hwcap2): Likewise.
10329 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10330 (ppc_linux_get_hwcap2): Likewise.
10331 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10333 (ppc_linux_nat_target::insert_watchpoint): Likewise.
10334 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10335 (ppc_linux_nat_target::read_description): Likewise.
10336 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10337 * s390-linux-nat.c: Likewise.
10338 * s390-linux-tdep.c (s390_core_read_description): Likewise.
10340 2019-03-24 Tom Tromey <tom@tromey.com>
10342 * ada-lang.c (standard_lookup): Simplify initialization.
10343 (ada_lookup_symbol_nonlocal): Simplify return.
10344 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10345 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10346 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10347 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10349 * solib.c (solib_global_lookup): Simplify.
10350 * symtab.c (null_block_symbol): Remove.
10351 (symbol_cache_lookup): Simplify returns.
10352 (lookup_language_this): Simplify returns.
10353 (lookup_symbol_aux): Simplify return.
10354 (lookup_local_symbol): Simplify returns.
10355 (lookup_global_symbol_from_objfile): Simplify return.
10356 (lookup_symbol_in_objfile_symtabs)
10357 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10358 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10359 (lookup_static_symbol, lookup_global_symbol): Simplify return.
10360 * cp-namespace.c (cp_lookup_bare_symbol)
10361 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10362 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10363 (cp_lookup_nested_symbol): Don't use null_block_symbol.
10364 (cp_lookup_symbol_via_imports): Simplify initialization.
10365 (find_symbol_in_baseclass): Likewise.
10366 * symtab.h (null_block_symbol): Remove.
10367 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10368 (d_lookup_nested_symbol, d_lookup_symbol_imports)
10369 (d_lookup_symbol_module): Likewise.
10370 (find_symbol_in_baseclass): Simplify initialization.
10372 2019-03-24 Tom Tromey <tom@tromey.com>
10374 * expression.h: Don't include symtab.h.
10375 (struct block): Forward declare.
10377 2019-03-24 Tom Tromey <tom@tromey.com>
10379 * c-exp.y (typebase): Remove casts.
10380 * gdbtypes.c (lookup_unsigned_typename, )
10381 (lookup_signed_typename): Remove cast.
10382 * eval.c (parse_to_comma_and_eval): Remove cast.
10383 * parse.c (write_dollar_variable): Remove cast.
10384 * block.h (struct block) <superblock>: Now const.
10385 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10386 * psymtab.c (psym_map_matching_symbols): Make "block" const.
10387 (map_block): Make "block" const.
10388 * symfile.h (struct quick_symbol_functions)
10389 <map_matching_symbols>: Constify block argument to "callback".
10390 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10392 (find_pc_sect_compunit_symtab): Make "b" const.
10393 (find_symbol_at_address): Likewise.
10394 (search_symbols): Likewise.
10395 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10396 (dw2_debug_names_lookup_symbol): Likewise.
10397 (dw2_map_matching_symbols): Update.
10398 * p-valprint.c (pascal_val_print): Remove "block".
10399 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10400 (aux_add_nonlocal_symbols): Make "block" const.
10401 (resolve_subexp): Remove cast.
10402 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10404 (iterate_over_file_blocks): Likewise.
10405 * f-exp.y (%union) <bval>: Remove.
10406 * coffread.c (patch_opaque_types): Make "b" const.
10407 * spu-tdep.c (spu_catch_start): Make "block" const.
10408 * c-valprint.c (print_unpacked_pointer): Remove "block".
10409 * symmisc.c (dump_symtab_1): Make "b" const.
10410 (block_depth): Make "block" const.
10411 * d-exp.y (%union) <bval>: Remove.
10412 * cp-support.h (cp_lookup_rtti_type): Update.
10413 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10414 * psymtab.c (psym_lookup_symbol): Make "block" const.
10415 (maintenance_check_psymtabs): Make "b" const.
10416 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10417 (enumerate_locals, enumerate_args): Update.
10418 * python/py-symtab.c (stpy_global_block): Make "block" const.
10419 (stpy_static_block): Likewise.
10420 * inline-frame.c (block_starting_point_at): Make "new_block"
10422 * block.c (find_block_in_blockvector): Make return type const.
10423 (blockvector_for_pc_sect): Make "b" const.
10424 (find_block_in_blockvector): Make "b" const.
10426 2019-03-23 Tom Tromey <tom@tromey.com>
10428 * varobj.c (varobj_create): Update.
10429 * symfile.c (clear_symtab_users): Don't reset innermost_block.
10430 * printcmd.c (display_command, do_one_display): Don't reset
10432 * parser-defs.h (enum innermost_block_tracker_type): Move to
10434 (innermost_block): Update comment.
10435 * parse.c (parse_exp_1): Add tracker_types parameter.
10436 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
10437 tracker_types parameter. Reset innermost_block.
10438 (parse_exp_in_context): Remove.
10439 (parse_expression_for_completion): Update.
10440 * objfiles.c (~objfile): Don't reset expression_context_block or
10442 * expression.h (enum innermost_block_tracker_type): Move from
10444 (parse_exp_1): Add tracker_types parameter.
10445 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10446 reset innermost_block.
10448 2019-03-23 Tom Tromey <tom@tromey.com>
10450 * objfiles.h: Include bcache.h.
10452 2019-03-23 Tom Tromey <tom@tromey.com>
10454 * linespec.c (get_current_search_block): Use
10455 scoped_restore_current_language.
10456 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10458 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10459 Jiong Wang <jiong.wang@arm.com>
10461 * aarch64-linux-tdep.c
10462 (aarch64_linux_iterate_over_regset_sections): Check for pauth
10464 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10466 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10467 Jiong Wang <jiong.wang@arm.com>
10469 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10471 (aarch64_analyze_prologue_test): Add PACIASP test.
10472 (aarch64_prologue_prev_register): Unmask PC value.
10474 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10475 Jiong Wang <jiong.wang@arm.com>
10477 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10478 (aarch64_dwarf2_prev_register): Unmask PC value.
10479 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10480 (aarch64_execute_dwarf_cfa_vendor_op): Check for
10481 DW_CFA_AARCH64_negate_ra_state.
10482 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10484 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10485 Jiong Wang <jiong.wang@arm.com>
10487 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10489 (aarch64_pseudo_register_name): Likewise.
10490 (aarch64_pseudo_register_type): Likewise.
10491 (aarch64_pseudo_register_reggroup_p): Likewise.
10492 (aarch64_gdbarch_init): Add pauth registers.
10493 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10494 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10495 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10496 (struct gdbarch_tdep): Add regnum for ra_state.
10498 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10499 Jiong Wang <jiong.wang@arm.com>
10501 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10503 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10504 Jiong Wang <jiong.wang@arm.com>
10506 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10508 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10509 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10510 (aarch64_gdbarch_init): Add puth registers.
10511 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10512 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10513 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10515 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10516 Jiong Wang <jiong.wang@arm.com>
10518 * aarch64-linux-nat.c
10519 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10520 * aarch64-linux-tdep.c
10521 (aarch64_linux_core_read_description): Likewise.
10522 (aarch64_linux_get_hwcap): New function.
10523 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10524 (aarch64_linux_get_hwcap): New declaration.
10526 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10527 Jiong Wang <jiong.wang@arm.com>
10529 * aarch64-linux-nat.c
10530 (aarch64_linux_nat_target::read_description): Add pauth param.
10531 * aarch64-linux-tdep.c
10532 (aarch64_linux_core_read_description): Likewise.
10533 * aarch64-tdep.c (struct target_desc): Add in pauth.
10534 (aarch64_read_description): Add pauth param.
10535 (aarch64_gdbarch_init): Likewise.
10536 * aarch64-tdep.h (aarch64_read_description): Likewise.
10537 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10538 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10539 * features/Makefile: Add new files.
10540 * features/aarch64-pauth.c: New file.
10541 * features/aarch64-pauth.xml: New file.
10543 2019-03-20 Tom Tromey <tromey@adacore.com>
10545 * infrun.c (handle_inferior_event): Rename from
10546 handle_inferior_event_1. Create a scoped_value_mark.
10547 (handle_inferior_event): Remove.
10549 2019-03-19 Tom Tromey <tromey@adacore.com>
10551 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10552 * infrun.h (print_stop_event): Add "displays" parameter.
10553 * infrun.c (print_stop_event): Add "displays" parameter.
10555 2019-03-19 Pedro Alves <palves@redhat.com>
10557 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10558 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10559 to -1. Fix TABs vs spaces.
10560 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10561 * tui/tui-out.h (tui_ui_out) Add intro comments.
10562 <m_line, m_start_of_line>: In-class initialize, and add describing
10565 2019-03-18 Alan Hayward <alan.hayward@arm.com>
10567 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10569 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10571 2019-03-18 Pedro Alves <palves@redhat.com>
10572 Eli Zaretskii <eliz@gnu.org>
10574 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10575 m_line and m_start_of_line.
10577 2019-03-18 Eli Zaretskii <eliz@gnu.org>
10579 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10580 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10581 it returns a newline. This fixes a regression in TU mode, whereby
10582 the next line is output on the same screen line as the user input.
10584 2019-03-18 Tom Tromey <tromey@adacore.com>
10586 * minsyms.c (minimal_symbol_reader::install): Remove call to
10589 2019-03-18 Pedro Alves <palves@redhat.com>
10591 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10593 (apply_style): New, factored out from ...
10594 (apply_ansi_escape): ... this. Handle reverse video mode.
10595 (tui_set_reverse_mode): New function.
10596 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10597 * tui/tui-winsource.c (tui_show_source_line): Use
10598 tui_set_reverse_mode instead of setting A_STANDOUT.
10599 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10600 New setter methods.
10602 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
10604 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10607 2019-03-18 Tom Tromey <tromey@adacore.com>
10609 * ada-lang.c (empty_array): Add "high" parameter.
10610 (ada_evaluate_subexp): Update.
10612 2019-03-17 Sergei Trofimovich <siarheit@google.com>
10614 * unittests/string_view-selftests.c: Define
10615 _initialize_string_view_selftests unconditionally.
10617 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10620 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10622 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10625 * windows-nat.c (display_selector): Fix format specifiers.
10627 2019-03-17 Eli Zaretskii <eliz@gnu.org>
10629 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10630 tui_refill_source_window instead of tui_refresh_win, to update the
10631 current execution line. This fixes redisplay of the current line
10632 when stepping through the code with "next" or "step".
10634 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10636 * source-cache.c (source_cache::get_source_lines): Call
10637 find_source_lines to initialize s->nlines. This fixes vertical
10638 scrolling of TUI source window when the DOWN arrow is pressed.
10640 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10642 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10643 linux-thread-db.c (_initialize_thread_db): Likewise.
10645 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10647 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10648 wclrtoeol in tui_show_source_line". This reverts changes made in
10649 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10651 2019-03-15 Tom Tromey <tom@tromey.com>
10653 * symtab.h (struct minimal_symbol): Derive from
10654 general_symbol_info.
10655 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10656 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10657 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10658 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10659 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10660 (MSYMBOL_SEARCH_NAME): Update.
10661 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10662 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10663 * minsyms.c (minimal_symbol_reader::record_full): Update.
10665 2019-03-15 Tom Tromey <tom@tromey.com>
10667 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10669 2019-03-15 Tom Tromey <tom@tromey.com>
10671 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10672 unique_xmalloc_ptr.
10673 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10675 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10676 (build_minimal_symbol_hash_tables)
10677 (minimal_symbol_reader::install): Update.
10679 2019-03-15 Tom Tromey <tom@tromey.com>
10681 * symtab.c (create_demangled_names_hash): Update.
10682 (symbol_set_names): Update.
10683 * objfiles.h (struct objfile_per_bfd_storage)
10684 <demangled_names_hash>: Now an htab_up.
10685 * objfiles.c (objfile_per_bfd_storage): Simplify.
10687 2019-03-15 Tom Tromey <tom@tromey.com>
10689 * objfiles.h (struct objfile_per_bfd_storage): Declare
10691 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10693 (get_objfile_bfd_data): Use new. Don't initialize
10695 (free_objfile_per_bfd_storage): Remove.
10696 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10698 2019-03-15 Tom Tromey <tom@tromey.com>
10700 * symfile.c (reread_symbols): Update.
10701 * objfiles.c (objfile::objfile): Update.
10702 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10703 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10705 (minimal_symbol_reader::install): Update.
10706 (terminate_minimal_symbol_table): Remove.
10707 * jit.c (jit_object_close_impl): Update.
10709 2019-03-15 Tom Tromey <tom@tromey.com>
10711 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10714 2019-03-15 Tom Tromey <tom@tromey.com>
10716 * objfiles.h (struct objfile_per_bfd_storage)
10717 <demangled_hash_languages>: Now a bitset.
10718 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10719 (lookup_minimal_symbol): Update.
10721 2019-03-15 Tom Tromey <tom@tromey.com>
10723 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10724 Don't return the symbol.
10725 * coffread.c (record_minimal_symbol): Use record_full.
10727 2019-03-14 Eli Zaretskii <eliz@gnu.org>
10729 The MS-Windows port of ncurses fails to switch to a color pair if
10730 one or both of the colors are the implicit default colors. This
10731 change records the default colors when TUI is initialized, and
10732 then specifies them explicitly when a color pair uses the default
10733 colors. This allows color styling in TUI mode on MS-Windows.
10735 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10737 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10738 colors in ncurses_norm_attr.
10739 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10740 "none", replace it with the default color recorded in
10743 2019-03-14 Tom Tromey <tromey@adacore.com>
10745 * source-cache.h (class source_cache) <get_source_lines>: Return
10747 * source-cache.c (source_cache::extract_lines): Handle case where
10748 first_pos==npos. Return std::string.
10749 (source_cache::get_source_lines): Update.
10751 2019-03-14 Tom Tromey <tromey@adacore.com>
10753 * NEWS: Add item for "style sources" commands.
10754 * source-cache.c (source_cache::get_source_lines): Check
10756 * cli/cli-style.c (source_styling): New global.
10757 (_initialize_cli_style): Add "style sources" commands.
10758 (show_style_sources): New function.
10759 * cli/cli-style.h (source_styling): Declare.
10761 2019-03-14 Pedro Alves <palves@redhat.com>
10762 Tom Tromey <tromey@adacore.com>
10764 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10765 * tui/tui-winsource.c (tui_refill_source_window): New function,
10767 (tui_horizontal_source_scroll): ... here. Move some logic.
10768 * cli/cli-style.c (set_style_enabled): Notify new observable.
10769 * tui/tui-hooks.c (tui_redisplay_source): New function.
10770 (tui_attach_detach_observers): Attach or detach
10771 tui_redisplay_source.
10772 * observable.h (source_styling_changed): New observable.
10773 * observable.c: Define source_styling_changed observable.
10775 2019-03-13 Tom Tromey <tromey@adacore.com>
10777 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10778 (i386_gnu_nat_target::store_registers): Update.
10779 * target-debug.h (target_debug_print_std_string): New macro.
10780 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10781 * windows-tdep.c (display_one_tib): Update.
10782 * tui/tui-stack.c (tui_make_status_line): Update.
10783 * top.c (print_inferior_quit_action): Update.
10784 * thread.c (thr_try_catch_cmd): Update.
10785 (add_thread_with_info): Update.
10786 (thread_target_id_str): Update.
10787 (thr_try_catch_cmd): Update.
10788 (thread_command): Update.
10789 (thread_find_command): Update.
10790 * record-btrace.c (record_btrace_target::info_record)
10791 (record_btrace_resume_thread, record_btrace_target::resume)
10792 (record_btrace_cancel_resume, record_btrace_step_thread)
10793 (record_btrace_target::wait, record_btrace_target::wait)
10794 (record_btrace_target::wait, record_btrace_target::stop): Update.
10795 * progspace.c (print_program_space): Update.
10796 * process-stratum-target.c
10797 (process_stratum_target::thread_address_space): Update.
10798 * linux-fork.c (linux_fork_mourn_inferior)
10799 (detach_checkpoint_command, info_checkpoints_command)
10800 (linux_fork_context): Update.
10801 (linux_fork_detach): Update.
10802 (class scoped_switch_fork_info): Update.
10803 (delete_checkpoint_command): Update.
10804 * infrun.c (follow_fork_inferior): Update.
10805 (follow_fork_inferior): Update.
10806 (proceed_after_vfork_done): Update.
10807 (handle_vfork_child_exec_or_exit): Update.
10808 (follow_exec): Update.
10809 (displaced_step_prepare_throw): Update.
10810 (displaced_step_restore): Update.
10811 (start_step_over): Update.
10812 (resume_1): Update.
10813 (clear_proceed_status_thread): Update.
10815 (print_target_wait_results): Update.
10816 (do_target_wait): Update.
10817 (context_switch): Update.
10818 (stop_all_threads): Update.
10819 (restart_threads): Update.
10820 (finish_step_over): Update.
10821 (handle_signal_stop): Update.
10822 (switch_back_to_stepped_thread): Update.
10823 (keep_going_pass_signal): Update.
10824 (print_exited_reason): Update.
10825 (normal_stop): Update.
10826 * inferior.c (inferior_pid_to_str): Change return type.
10827 (print_selected_inferior): Update.
10828 (add_inferior): Update.
10829 (detach_inferior): Update.
10830 * dummy-frame.c (fprint_dummy_frames): Update.
10831 * dcache.c (dcache_info_1): Update.
10832 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10833 (btrace_fetch, btrace_clear): Update.
10834 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10835 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10837 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10838 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10839 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10840 * gdbarch.c, gdbarch.h: Rebuild.
10841 * gdbarch.sh (core_pid_to_str): Change return type.
10842 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10844 (windows_nat_target::pid_to_str): Change return type.
10845 (windows_delete_thread): Update.
10846 (windows_nat_target::attach): Update.
10847 (windows_nat_target::files_info): Update.
10848 * target-delegates.c: Rebuild.
10849 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10851 (sol_thread_target::pid_to_str): Change return type.
10852 * remote.c (class remote_target) <pid_to_str>: Change return
10854 (remote_target::pid_to_str): Change return type.
10855 (extended_remote_target::attach, remote_target::remote_stop_ns)
10856 (remote_target::remote_notif_remove_queued_reply)
10857 (remote_target::push_stop_reply, remote_target::disable_btrace):
10859 (extended_remote_target::attach): Update.
10860 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10862 (gdbsim_target::pid_to_str): Change return type.
10863 * ravenscar-thread.c (struct ravenscar_thread_target)
10864 <pid_to_str>: Change return type.
10865 (ravenscar_thread_target::pid_to_str): Change return type.
10866 * procfs.c (class procfs_target) <pid_to_str>: Change return
10868 (procfs_target::pid_to_str): Change return type.
10869 (procfs_target::attach): Update.
10870 (procfs_target::detach): Update.
10871 (procfs_target::fetch_registers): Update.
10872 (procfs_target::store_registers): Update.
10873 (procfs_target::wait): Update.
10874 (procfs_target::files_info): Update.
10875 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10876 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10878 (nto_procfs_target::pid_to_str): Change return type.
10879 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10880 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10882 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10883 (exit_lwp): Update.
10884 (attach_proc_task_lwp_callback, get_detach_signal)
10885 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10886 (linux_nat_target::resume, wait_lwp, stop_callback)
10887 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10888 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10889 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10890 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10891 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10893 (inf_ptrace_target::attach): Update.
10894 (inf_ptrace_target::files_info): Update.
10895 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10897 (go32_nat_target::pid_to_str): Change return type.
10898 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10899 (gnu_nat_target::wait): Update.
10900 (gnu_nat_target::wait): Update.
10901 (gnu_nat_target::resume): Update.
10902 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10903 (fbsd_nat_target::wait): Update.
10904 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10906 (darwin_nat_target::attach): Update.
10907 * corelow.c (class core_target) <pid_to_str>: Change return type.
10908 (core_target::pid_to_str): Change return type.
10909 * target.c (normal_pid_to_str): Change return type.
10910 (default_pid_to_str): Likewise.
10911 (target_pid_to_str): Change return type.
10912 (target_translate_tls_address): Update.
10913 (target_announce_detach): Update.
10914 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10916 (bsd_uthread_target::pid_to_str): Change return type.
10917 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10919 (bsd_kvm_target::pid_to_str): Change return type.
10920 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10922 (aix_thread_target::pid_to_str): Change return type.
10923 * target.h (struct target_ops) <pid_to_str>: Change return type.
10924 (target_pid_to_str, normal_pid_to_str): Likewise.
10925 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10927 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10929 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10931 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10933 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10935 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10938 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10940 * NEWS: Mention that the new default MI version is 3. Mention
10941 changes to the output of commands and events that deal with
10942 multi-location breakpoints.
10943 * breakpoint.c: Include "mi/mi-out.h".
10944 (print_one_breakpoint): Change output syntax if using MI version
10946 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10948 (mi_multi_location_breakpoint_output_fixed): New.
10949 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10950 (mi_cmd_fix_multi_location_breakpoint_output): New.
10951 (mi_multi_location_breakpoint_output_fixed): New.
10952 * mi/mi-cmds.c (mi_cmds): Register command
10953 -fix-multi-location-breakpoint-output.
10954 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10957 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10959 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10960 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10961 instantiate mi_ui_out based on interpreter name.
10962 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10963 * mi/mi-main.c (mi_load_progress): Likewise.
10965 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10967 * NEWS: Combine separate "New targets" sections for 8.3.
10969 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10971 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10972 (ppcfbsd_init_abi): Install gdbarch
10973 "fetch_tls_load_module_address" and "get_thread_local_address"
10976 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10978 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10979 (riscv_fbsd_init_abi): Install gdbarch
10980 "fetch_tls_load_module_address" and "get_thread_local_address"
10983 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10985 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10986 (i386fbsd_init_abi): Install gdbarch
10987 "fetch_tls_load_module_address" and "get_thread_local_address"
10990 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10992 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10993 (amd64fbsd_init_abi): Install gdbarch
10994 "fetch_tls_load_module_address" and "get_thread_local_address"
10997 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10999 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11000 (struct fbsd_pspace_data): New type.
11001 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11002 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11003 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11004 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11005 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11007 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11009 * gdbtypes.c (lookup_struct_elt): New function.
11010 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11011 * gdbtypes.h (struct struct_elt): New type.
11012 (lookup_struct_elt): New prototype.
11014 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11016 * gdbtypes.c (lookup_struct_elt_type): Update comment and
11017 remove disabled code block.
11019 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11021 * gdbarch.sh (get_thread_local_address): New method.
11022 * gdbarch.h, gdbarch.c: Regenerate.
11023 * target.c (target_translate_tls_address): Use
11024 gdbarch_get_thread_local_address if present instead of
11025 target::get_thread_local_address.
11027 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11029 * target.h (target::get_thread_local_address): Update comment.
11031 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11033 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11034 objfile->separate_debug_objfile_backlink if not NULL.
11036 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11038 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11039 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11040 (amd64bsd_store_inferior_registers): Likewise.
11041 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11042 Enable segment base registers.
11043 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11044 PT_GETFSBASE and PT_GETGSBASE.
11045 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11047 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11048 segment base registers.
11049 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11051 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11053 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11054 Update calls to i386_target_description to add 'segments'
11056 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
11057 add segment base registers.
11058 * arch/i386.c (i386_create_target_description): Add 'segments'
11059 parameter to enable segment base registers.
11060 * arch/i386.h (i386_create_target_description): Likewise.
11061 * features/i386/32bit-segments.xml: New file.
11062 * features/i386/32bit-segments.c: Generate.
11063 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11064 call to i386_target_description to add 'segments' parameter.
11065 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11066 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11067 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11068 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11069 if feature is present.
11070 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11071 Add 'segments' parameter to call to i386_target_description.
11072 (i386_target_description): Add 'segments' parameter to enable
11073 segment base registers.
11074 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11075 to call to i386_target_description.
11076 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11077 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11078 Define I386_NUM_REGS.
11079 (i386_target_description): Add 'segments' parameter to enable
11080 segment base registers.
11082 2019-03-12 Eli Zaretskii <eliz@gnu.org>
11085 * source-cache.c: #undef open and close, to avoid unresolved
11086 externals during linking.
11088 2019-03-12 Tom Tromey <tromey@adacore.com>
11090 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11091 const. Add initializers.
11092 (_initialize_remote): Don't initialize ptid globals.
11094 2019-03-12 Pedro Alves <palves@redhat.com>
11096 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11098 2019-03-12 Pedro Alves <palves@redhat.com>
11100 * cp-name-parser.y (main): Remove unused 'len' variable.
11102 2019-03-12 Tom Tromey <tromey@adacore.com>
11104 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11105 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11107 2019-03-12 Tom Tromey <tromey@adacore.com>
11109 * linux-nat.c (iterate_over_lwps): Update.
11110 (stop_callback): Remove parameter.
11111 (stop_wait_callback, detach_callback, resume_set_callback)
11112 (select_singlestep_lwp_callback, set_ignore_sigint)
11113 (status_callback, resumed_callback, resume_clear_callback)
11114 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11116 (linux_nat_target::detach, linux_nat_target::resume)
11117 (linux_stop_and_wait_all_lwps, select_event_lwp)
11118 (linux_nat_filter_event, linux_nat_wait_1)
11119 (linux_nat_target::kill, linux_nat_target::stop)
11120 (linux_nat_target::stop): Update.
11121 (linux_nat_resume_callback): Change type.
11122 (resume_stopped_resumed_lwps, count_events_callback)
11123 (select_event_lwp_callback): Likewise.
11124 (linux_stop_lwp, linux_nat_stop_lwp): Update.
11125 * arm-linux-nat.c (struct update_registers_data): Remove.
11126 (update_registers_callback): Change type.
11127 (arm_linux_insert_hw_breakpoint1): Update.
11128 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11130 (x86_linux_dr_set_addr): Update.
11131 (x86_linux_dr_set_control): Update.
11132 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11133 (iterate_over_lwps): Use gdb::function_view.
11134 * nat/aarch64-linux-hw-point.c (struct
11135 aarch64_dr_update_callback_param): Remove.
11136 (debug_reg_change_callback): Change type.
11137 (aarch64_notify_debug_reg_change): Update.
11138 * s390-linux-nat.c (s390_refresh_per_info): Update.
11140 2019-03-11 Tom Tromey <tromey@adacore.com>
11142 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11143 redundant assignment to "this_cu".
11145 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11147 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11149 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11151 * gdbtypes.c (rank_one_type_parm_set): New function extracted
11153 (rank_one_type): ... this.
11155 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11157 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11159 (rank_one_type): ... this.
11161 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11163 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11165 (rank_one_type): ... this.
11167 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11169 * gdbtypes.c (rank_one_type_parm_float): New function extracted
11171 (rank_one_type): ... this.
11173 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11175 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11177 (rank_one_type): ... this.
11179 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11181 * gdbtypes.c (rank_one_type_parm_range): New function extracted
11183 (rank_one_type): ... this.
11185 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11187 * gdbtypes.c (rank_one_type_parm_char): New function extracted
11189 (rank_one_type): ... this.
11191 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11193 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11195 (rank_one_type): ... this.
11197 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11199 * gdbtypes.c (rank_one_type_parm_int): New function extracted
11201 (rank_one_type): ... this.
11203 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11205 * gdbtypes.c (rank_one_type_parm_func): New function extracted
11207 (rank_one_type): ... this.
11209 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11211 * gdbtypes.c (rank_one_type_parm_array): New function extracted
11213 (rank_one_type): ... this.
11215 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11217 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11219 (rank_one_type): ... this.
11221 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11223 * inferior.c (initialize_inferiors): Ensure 'help set/show print
11224 inferior-events' shows the example events.
11226 2019-03-08 Eli Zaretskii <eliz@gnu.org>
11228 Support styling on native MS-Windows console
11231 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11232 on MS-Windows if $TERM is not defined.
11234 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11236 * posix-hdep.c (gdb_console_fputs):
11237 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11239 * ui-file.h (gdb_console_fputs): Add prototype.
11241 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11242 back to fputs only if the former returns zero.
11244 2019-03-07 Tom Tromey <tom@tromey.com>
11246 * symmisc.c (print_symbol_bcache_statistics): Update.
11247 (print_objfile_statistics): Update.
11248 * symfile.c (allocate_symtab): Update.
11249 * stabsread.c: Don't include bcache.h.
11250 * psymtab.h (struct psymbol_bcache): Don't declare.
11251 (class psymtab_storage) <psymbol_cache>: Now a bcache.
11252 (psymbol_bcache_init, psymbol_bcache_free)
11253 (psymbol_bcache_get_bcache): Don't declare.
11254 * psymtab.c (struct psymbol_bcache): Remove.
11255 (psymtab_storage::psymtab_storage): Update.
11256 (psymtab_storage::~psymtab_storage): Update.
11257 (psymbol_bcache_init, psymbol_bcache_free)
11258 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11259 (add_psymbol_to_bcache): Update.
11260 (allocate_psymtab): Update.
11261 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11262 macro_cache>: No longer pointers.
11263 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11264 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11265 * macrotab.c (macro_bcache): Update.
11266 * macroexp.c: Don't include bcache.h.
11267 * gdbtypes.c (check_types_worklist): Update.
11268 (types_deeply_equal): Remove TRY/CATCH. Update.
11269 * elfread.c (elf_symtab_read): Update.
11270 * dwarf2read.c: Don't include bcache.h.
11271 * buildsym.c (buildsym_compunit::get_macro_table): Update.
11272 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11273 (print_bcache_statistics, bcache_memory_used): Don't declare.
11274 (struct bcache): Move from bcache.c. Add constructor, destructor,
11275 methods. Rename all data members.
11276 * bcache.c (struct bcache): Move to bcache.h.
11277 (bcache::expand_hash_table): Rename from expand_hash_table.
11279 (bcache::insert): Rename from bcache_full.
11280 (bcache::compare): Rename from bcache_compare.
11281 (bcache_xmalloc): Remove.
11282 (bcache::~bcache): Rename from bcache_xfree.
11283 (bcache::print_statistics): Rename from print_bcache_statistics.
11284 (bcache::memory_used): Rename from bcache_memory_used.
11286 2019-03-07 Pedro Alves <palves@redhat.com>
11288 * infrun.c (normal_stop): Also check for
11289 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11291 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
11293 * f-lang.c (value_from_host_double): Moved to...
11294 * value.c (value_from_host_double): ...here.
11295 * value.h (value_from_host_double): Declare.
11296 * guile/scm-math.c (vlscm_convert_typed_number): Use
11297 value_from_host_double.
11298 (vlscm_convert_number): Likewise.
11299 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11300 * python/py-value.c (convert_value_from_python): Likewise.
11302 2019-03-06 Tom Tromey <tom@tromey.com>
11304 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11306 2019-03-06 Tom Tromey <tom@tromey.com>
11308 * utils.h (free_current_contents): Don't declare.
11309 * utils.c (free_current_contents): Remove.
11311 2019-03-06 Tom Tromey <tom@tromey.com>
11313 * top.c (quit_force): Update.
11314 * main.c (captured_command_loop): Update.
11315 * common/new-op.c (operator new): Update.
11316 * common/common-exceptions.c (struct catcher)
11317 <save_cleanup_chain>: Remove member.
11318 (exceptions_state_mc_init): Update.
11319 (exception_try_scope_entry): Return nullptr.
11320 (exception_try_scope_exit, exception_rethrow)
11321 (throw_exception_sjlj, throw_exception_cxx): Update.
11322 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11323 (all_cleanups, do_cleanups, discard_cleanups)
11324 (discard_final_cleanups, save_cleanups, save_final_cleanups)
11325 (restore_cleanups, restore_final_cleanups): Don't declare.
11326 (do_final_cleanups): Remove parameter.
11327 * common/cleanups.c (cleanup_chain, make_cleanup)
11328 (make_cleanup_dtor, all_cleanups, do_cleanups)
11329 (discard_my_cleanups, discard_cleanups)
11330 (discard_final_cleanups, save_my_cleanups, save_cleanups)
11331 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11332 (null_cleanup): Remove.
11333 (do_final_cleanups): Remove parameter.
11335 2019-03-06 Tom Tromey <tom@tromey.com>
11337 * remote.c (remote_target::remote_parse_stop_reply): Use
11338 unique_xmalloc_ptr.
11340 2019-03-06 Tom Tromey <tom@tromey.com>
11342 * stabsread.c (struct stabs_field_info): Rename from field_info.
11343 <list, fnlist>: Add initializers.
11344 <obstack>: New member.
11345 (read_member_functions, read_struct_fields, read_baseclasses):
11346 Allocate on obstack. Don't use cleanups.
11347 (read_one_struct_field, read_member_functions, read_struct_fields)
11348 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11349 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11350 (read_struct_type): Update.
11352 2019-03-06 Tom Tromey <tom@tromey.com>
11354 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11355 * common/filestuff.h (make_cleanup_close): Don't declare.
11356 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11359 2019-03-06 Tom Tromey <tom@tromey.com>
11361 * solib-aix.c: Use make_scope_exit.
11363 2019-03-06 Tom Tromey <tom@tromey.com>
11365 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11366 Use make_scope_exit.
11368 2019-03-06 Tom Tromey <tom@tromey.com>
11370 * solib-svr4.c (disable_probes_interface): Remove parameter.
11371 (svr4_handle_solib_event): Use make_scope_exit.
11373 2019-03-06 Tom Tromey <tom@tromey.com>
11375 * remote.c (struct stop_reply_deleter): Remove.
11376 (stop_reply_up): Update.
11377 (struct stop_reply): Derive from notif_event. Don't typedef.
11378 <regcache>: Now a std::vector.
11379 (stop_reply_xfree): Remove.
11380 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11381 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
11382 (remote_target::discard_pending_stop_replies): Use delete.
11383 (remote_target::remote_parse_stop_reply): Update.
11384 (remote_target::process_stop_reply): Update.
11385 * remote-notif.h (struct notif_event): Add virtual destructor.
11386 Remove "dtr" member.
11387 (struct notif_client) <alloc_event>: Return a unique_ptr.
11388 (notif_event_xfree): Don't declare.
11389 (notif_event_up): New typedef.
11390 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11391 (notif_event_xfree, do_notif_event_xfree): Remove.
11392 (remote_notif_state_xfree): Update.
11394 2019-03-06 Tom Tromey <tom@tromey.com>
11396 * infrun.c (displaced_step_clear_cleanup): Now a
11397 forward_scope_exit type.
11398 (displaced_step_prepare_throw): Update.
11399 (displaced_step_fixup): Update.
11401 2019-03-06 Tom Tromey <tom@tromey.com>
11403 * inferior.h (class inferior): Update comment.
11404 * gdbthread.h (class thread_info): Update comment.
11406 2019-03-06 Joel Brobecker <brobecker@adacore.com>
11407 Tom Tromey <tom@tromey.com>
11409 * stabsread.h (struct stab_section_list): Remove.
11410 (coffstab_build_psymtabs): Update.
11411 * dbxread.c (symbuf_sections): Now a std::vector.
11412 (sect_idx): New global.
11413 (fill_symbuf): Update.
11414 (coffstab_build_psymtabs): Change type of stabsects parameter.
11416 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11418 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11419 (coff_locate_sections): Update.
11420 (coff_symfile_read): Remove cleanups. Update.
11421 (init_stringtab): Add storage parameter.
11422 (free_stringtab, free_stringtab_cleanup): Remove.
11423 (init_lineno): Add storage parameter.
11424 (free_linetab, free_linetab_cleanup): Remove.
11426 2019-03-06 Pedro Alves <palves@redhat.com>
11428 * linux-fork.c (fork_info::clobber_regs): Delete.
11429 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11430 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
11432 (scoped_switch_fork_info::scoped_switch_fork_info)
11433 (checkpoint_command, linux_fork_context): Adjust
11434 fork_save_infrun_state calls.
11436 2019-03-06 Pedro Alves <palves@redhat.com>
11438 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11439 (inf_has_multiple_threads): Return 'bool' and rewrite using
11440 inferior_info::threads().
11442 2019-03-06 Pedro Alves <palves@redhat.com>
11444 * linux-fork.c: Include <list>.
11445 (fork_list): Now a std::list instance.
11446 (fork_info): Add ctor, dtor, and in-class initialize all fields.
11447 (forks_exist_p, find_last_fork): Adjust.
11448 (new_fork): Delete.
11450 (add_fork): Adjust.
11451 (free_fork): Delete, folded into fork_info::~fork_info().
11452 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11454 (init_fork_list): Delete.
11455 (linux_fork_killall, linux_fork_mourn_inferior)
11456 (linux_fork_detach, info_checkpoints_command): Adjust.
11457 (_initialize_linux_fork): No longer call init_fork_list.
11459 2019-03-06 Pedro Alves <palves@redhat.com>
11461 * linux-fork.c (new_fork): New, split out of ...
11462 (add_fork): ... this. Return void. Move "first fork" special
11463 case from here, to ...
11464 (checkpoint_command): ... here.
11465 * linux-linux.h (add_fork): Return void.
11467 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11469 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11471 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11472 Chris January <chris.january@arm.com>
11473 David Lecomber <david.lecomber@arm.com>
11475 * f-exp.y: New token, UNOP_INTRINSIC.
11476 (exp): New pattern using UNOP_INTRINSIC token.
11477 (f77_keywords): Add 'abs' keyword.
11478 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11479 (value_from_host_double): New function.
11480 (evaluate_subexp_f): Support UNOP_ABS.
11482 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11484 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11487 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11489 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11490 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11491 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11493 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11495 * f-exp.y (convert_to_kind_type): Handle more type kinds.
11497 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11498 Chris January <chris.january@arm.com>
11500 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11501 * f-exp.y: Define 'KIND' token.
11502 (exp): New pattern for KIND expressions.
11503 (ptype): Handle types with a kind extension.
11504 (direct_abs_decl): Extend to spot kind extensions.
11505 (f77_keywords): Add 'kind' to the list.
11506 (push_kind_type): New function.
11507 (convert_to_kind_type): New function.
11508 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11509 * parse.c (operator_length_standard): Likewise.
11510 * parser-defs.h (enum type_pieces): Add tp_kind.
11511 * std-operator.def: Add UNOP_KIND.
11513 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11515 * f-exp.y (f_parse): Set yydebug.
11517 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11519 * f-lang.c (evaluate_subexp_f): New function.
11520 (exp_descriptor_f): New global.
11521 (f_language_defn): Use exp_descriptor_f instead of
11522 exp_descriptor_standard.
11524 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11526 * f-exp.y (struct token): Add comments.
11527 (dot_ops): Remove uppercase versions and the end marker.
11528 (f77_keywords): Likewise.
11529 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11530 entries in the dot_ops array are case insensitive, and use
11531 strncasecmp to compare strings. Also some whitespace cleanup in
11532 this area. Similar for the f77_keywords array, except entries in
11533 this list might be case sensitive.
11535 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11537 * f-exp.y (struct f77_boolean_val): Add comments.
11538 (boolean_values): Remove uppercase versions, and end marker.
11539 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11540 and use strncasecmp to achieve case insensitivity. Additionally,
11541 perform whitespace cleanup around this code.
11543 2019-03-06 Tom Tromey <tromey@adacore.com>
11545 * remote-sim.c (gdbsim_target_open): Use result of
11548 2019-03-06 Richard Bunt <richard.bunt@arm.com>
11549 Dirk Schubert <dirk.schubert@arm.com>
11550 Chris January <chris.january@arm.com>
11552 * eval.c (evaluate_subexp_standard): Call Fortran argument
11554 * f-lang.c (struct value): A value which can be passed into a
11555 Fortran function call.
11556 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11558 (struct type): Value ready for a Fortran function call.
11559 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11561 * f-lang.h (fortran_argument_convert): Declaration.
11562 (fortran_preserve_arg_pointer): Declaration.
11563 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11565 2019-03-05 Tom Tromey <tromey@adacore.com>
11567 * python/py-prettyprint.c (print_string_repr): Remove #if.
11568 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11570 2019-03-05 Tom Tromey <tromey@adacore.com>
11572 * target.c (the_dummy_target): Move later. Change type to
11574 (initialize_targets): Don't initialize the_dummy_target.
11576 2019-03-05 Tom Tromey <tromey@adacore.com>
11578 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11579 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11581 2019-03-05 Tom Tromey <tromey@adacore.com>
11583 * windows-nat.c (windows_nat_target::attach)
11584 (windows_nat_target::detach): Don't call gdb_flush.
11585 * valprint.c (generic_val_print, val_print, val_print_string):
11586 Don't call gdb_flush.
11587 * utils.c (defaulted_query): Don't call gdb_flush.
11588 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11589 * target.c (target_announce_detach): Don't call gdb_flush.
11590 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11591 * remote.c (extended_remote_target::attach): Don't call
11593 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11594 * printcmd.c (do_examine): Don't call gdb_flush.
11595 (info_display_command): Don't call gdb_flush.
11596 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11597 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11598 * memattr.c (info_mem_command): Don't call gdb_flush.
11599 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11600 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11601 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11602 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11603 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11604 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11605 (gnu_nat_target::detach): Don't call gdb_flush.
11606 * f-valprint.c (f_val_print): Don't call gdb_flush.
11607 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11608 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11609 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11611 * c-valprint.c (c_val_print): Don't call gdb_flush.
11612 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11614 2019-03-05 Tom Tromey <tromey@adacore.com>
11616 * varobj.c (update_dynamic_varobj_children): Update.
11617 (install_default_visualizer): Use reset, not release.
11618 * value.c (set_internalvar): Update.
11619 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11620 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11621 ATTRIBUTE_UNUSED_RESULT.
11623 2019-03-05 Tom Tromey <tromey@adacore.com>
11625 * remote.c (class scoped_remote_fd) <release>: Add
11626 ATTRIBUTE_UNUSED_RESULT.
11628 2019-03-05 Tom Tromey <tromey@adacore.com>
11630 * macroexp.c (struct macro_buffer) <release>: Add
11631 ATTRIBUTE_UNUSED_RESULT.
11633 2019-03-05 Tom Tromey <tromey@adacore.com>
11635 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11636 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11637 ATTRIBUTE_UNUSED_RESULT.
11639 2019-03-05 Tom Tromey <tromey@adacore.com>
11641 * common/scoped_fd.h (class scoped_fd) <release>: Add
11642 ATTRIBUTE_UNUSED_RESULT.
11644 2019-03-05 Tom Tromey <tromey@adacore.com>
11646 * parser-defs.h (struct parser_state) <release>: Add
11647 ATTRIBUTE_UNUSED_RESULT.
11649 2019-03-05 Tom Tromey <tromey@adacore.com>
11651 * utils.h (class gdb_argv) <release>: Add
11652 ATTRIBUTE_UNUSED_RESULT.
11653 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11655 2019-03-02 Eli Zaretskii <eliz@gnu.org>
11657 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11658 for-loop range, to avoid compiler warnings.
11660 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11661 avoid compiler warnings about unused variables.
11663 * NEWS: Mention end of support for native debugging on MS-Windows
11667 * common/netstuff.c:
11668 * gdbserver/gdbreplay.c
11669 * gdbserver/remote-utils.c:
11671 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11672 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11673 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11674 'getaddrinfo' and 'freeaddrinfo' were not available before
11675 Windows XP, and mingw.org's MinGW headers by default define
11676 _WIN32_WINNT to 0x500.
11678 2019-03-01 Gary Benson <gbenson@redhat.com>
11680 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11682 2019-02-28 Brian Vandenberg <phantall@gmail.com>
11683 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11686 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11687 set_sigint_trap, clear_sigint_trap.
11689 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11691 * target.c (target_detach): Clear the regcache and the
11694 2019-02-27 Pedro Alves <palves@redhat.com>
11696 * utils.c (set_screen_size): When we cap the height/width sizes,
11697 tweak the corresponding command variable to show "unlimited":
11699 2019-02-27 Saagar Jha <saagar@saagarjha.com>
11700 Pedro Alves <palves@redhat.com>
11702 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11703 before calling rl_set_screen_size.
11705 2019-02-27 Tom Tromey <tromey@adacore.com>
11707 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11709 * python/py-value.c: Remove Python 2.4 workaround.
11710 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11712 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11713 Python 2.4 workaround.
11714 * python/python-internal.h: Remove Python 2.4 comment.
11715 (Py_ssize_t): Don't define.
11716 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11717 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11718 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11719 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11720 * python/python.c (do_start_initialization): Remove Python 2.4
11722 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11723 (print_children): Remove Python 2.4 workaround.
11724 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11726 (CHARBUFFERPROC_NAME): Remove.
11727 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11728 Python 2.4 workaround.
11730 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11732 * NEWS: Note minimum Python version.
11734 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11736 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11737 code from these functions. Remove corresponding ifdefs. Use
11738 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11739 Remove gotos and target of gotos.
11740 (infpy_search_memory): Likewise.
11742 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11744 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11745 (hppa_gdbarch_init): Don't register deleted functions with
11748 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11750 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11751 (h8300_unwind_sp): Delete.
11752 (h8300_dummy_id): Delete.
11753 (h8300_gdbarch_init): Don't register deleted functions with
11756 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11758 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11759 (ft32_unwind_pc): Delete.
11760 (ft32_unwind_sp): Delete.
11761 (ft32_gdbarch_init): Don't register deleted functions with
11764 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11766 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11767 (frv_unwind_pc): Delete.
11768 (frv_unwind_sp): Delete.
11769 (frv_gdbarch_init): Don't register deleted functions with
11772 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11774 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11775 (riscv_unwind_pc): Delete.
11776 (riscv_unwind_sp): Delete.
11777 (riscv_gdbarch_init): Don't register deleted functions with
11780 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11782 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11783 (csky_unwind_pc): Delete.
11784 (csky_unwind_sp): Delete.
11785 (csky_gdbarch_init): Don't register deleted functions with
11788 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11790 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11791 (cris_unwind_pc): Delete.
11792 (cris_unwind_sp): Delete.
11793 (cris_gdbarch_init): Don't register deleted functions with
11796 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11798 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11799 (bfin_unwind_pc): Delete.
11800 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11802 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11804 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11805 (arm_unwind_pc): Delete.
11806 (arm_unwind_sp): Delete.
11807 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11809 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11811 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11812 (arc_unwind_pc): Delete.
11813 (arc_unwind_sp): Delete.
11814 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11816 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11818 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11819 (alpha_unwind_pc): Delete.
11820 (alpha_gdbarch_init): Don't register deleted functions with
11823 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11825 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11826 (aarch64_unwind_pc): Delete.
11827 (aarch64_unwind_sp): Delete.
11828 (aarch64_gdbarch_init): Don't register deleted functions with
11831 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11833 * gdbtypes.c (type_align): Don't consider static members when
11834 computing structure alignment.
11836 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11838 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11839 return 0 for other types.
11840 * arch-utils.c (default_type_align): Always return 0.
11841 * gdbarch.h: Regenerate.
11842 * gdbarch.sh (type_align): Extend comment.
11843 * gdbtypes.c (type_align): Add additional comments, always call
11844 gdbarch_type_align before applying the default rules.
11845 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11846 generic code will then apply a suitable default.
11847 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11848 types, return 0 for other types.
11850 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11852 * NEWS: Create a new section for the next release branch.
11853 Rename the section of the current branch, now that it has
11856 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11858 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11859 * version.in: Bump version to 8.3.50.DATE-git.
11861 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
11863 * aix-thread.c (ptid_cmp): Remove unused variable.
11864 (get_signaled_thread): Likewise.
11865 (store_regs_user_thread): Likewise.
11866 (store_regs_kernel_thread): Likewise.
11867 (fetch_regs_kernel_thread): Remove shadowed variable.
11869 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11871 * features/riscv/32bit-cpu.xml: Add register numbers.
11872 * features/riscv/32bit-fpu.c: Regenerate.
11873 * features/riscv/32bit-fpu.xml: Add register numbers.
11874 * features/riscv/64bit-cpu.xml: Add register numbers.
11875 * features/riscv/64bit-fpu.c: Regenerate.
11876 * features/riscv/64bit-fpu.xml: Add register numbers.
11878 2019-02-26 Kevin Buettner <kevinb@redhat.com>
11880 * NEWS: Mention two argument form of gdb.Value constructor.
11881 * python/py-value.c (convert_buffer_and_type_to_value): New
11883 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11884 Add support for handling an optional second argument. Call
11885 convert_buffer_and_type_to_value as appropriate.
11886 * python/python-internal.h (Py_buffer_deleter): New struct.
11887 (Py_buffer_up): New typedef.
11889 2019-02-25 John Baldwin <jhb@FreeBSD.org>
11891 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11892 instead of releasing ownership.
11894 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
11896 * dwarf2read.c (open_and_init_dwp_file): Call
11897 elf_numsections instead of bfd_count_sections to initialize
11898 dwp_file->num_sections.
11900 2019-02-25 Tom Tromey <tromey@adacore.com>
11902 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11904 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11906 * gcore.in: Add '--readnever' option when invoking GDB.
11908 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11910 * MAINTAINERS: Update my email address.
11912 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11914 * build-id.c (build_id_to_debug_bfd_1): New function.
11915 (build_id_to_debug_bfd): Look for separate debug file in
11918 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11920 * gdbarch.sh: Update the copyright year range that is placed into
11923 2019-02-22 Keith Seitz <keiths@redhat.com>
11926 * linespec.c (create_sals_line_offset): Search for the default
11927 symtab's filename instead of its fullname.
11929 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11931 * NEWS: Update style defaults.
11933 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11935 * main.c (captured_main_1): Disable styling in batch mode.
11937 2019-02-20 Tom Tromey <tom@tromey.com>
11939 * symtab.c (symtab_symbol_info): Fix typos.
11941 2019-02-20 Tom Tromey <tromey@adacore.com>
11943 * findcmd.c (_initialize_mem_search): Use upper case for
11944 metasyntactic variables.
11946 2019-02-20 Alan Hayward <alan.hayward@arm.com>
11948 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11949 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11951 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11953 * top.h (source_file_name): Change to std::string.
11954 * top.c (source_file_name): Likewise.
11955 (command_line_input): Adjust.
11956 * cli/cli-script.c (script_from_file): Adjust.
11958 2019-02-19 Tom Tromey <tromey@adacore.com>
11960 * ravenscar-thread.c
11961 (ravenscar_thread_target::update_thread_list): Don't call
11962 ada_build_task_list.
11963 * ada-lang.h (ada_build_task_list): Don't declare.
11964 * ada-tasks.c (struct ada_tasks_inferior_data)
11965 <task_list_valid_p>: Now bool.
11966 (read_known_tasks, ada_task_list_changed)
11967 (ada_tasks_invalidate_inferior_data): Update.
11968 (read_known_tasks_array): Return bool.
11969 (read_known_tasks_list): Likewise.
11970 (read_known_tasks): Return void.
11971 (ada_build_task_list): Now static.
11973 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11975 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11976 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11978 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11980 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11981 variant for ada_tasks_pspace_data_handle and
11982 ada_tasks_inferior_data_handle.
11983 (ada_tasks_pspace_data_cleanup): New function.
11984 (ada_tasks_inferior_data_cleanup): New function.
11986 2019-02-17 Tom Tromey <tom@tromey.com>
11988 * macrotab.h (macro_source_fullname): Return a std::string.
11989 * macrotab.c (macro_include, check_for_redefinition)
11990 (macro_undef, macro_lookup_definition, foreach_macro)
11991 (foreach_macro_in_scope): Update.
11992 (macro_source_fullname): Return a std::string.
11993 * macrocmd.c (show_pp_source_pos): Update.
11995 2019-02-17 Tom Tromey <tom@tromey.com>
11997 * macrocmd.c (show_pp_source_pos): Style the file names.
11999 2019-02-17 Tom Tromey <tom@tromey.com>
12002 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12004 2019-02-17 Tom Tromey <tom@tromey.com>
12006 * ada-lang.c (user_select_syms): Use filtered printing.
12007 * utils.c (wrap_style): New global.
12008 (desired_style): Remove.
12009 (emit_style_escape): Add stream parameter.
12010 (set_output_style, reset_terminal_style, prompt_for_continue):
12012 (flush_wrap_buffer): Only flush gdb_stdout.
12013 (wrap_here): Set wrap_style.
12014 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
12015 treat escape sequences as a character. Change when wrap buffer is
12017 (fputs_styled): Do not set the output style when the default is
12019 * ui-style.h (struct ui_file_style) <is_default>: New method.
12020 * source.c (print_source_lines_base): Emit escape sequences in one
12023 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12025 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12026 integers and enumeration types.
12028 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12030 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12031 instead of lookup_symbol_in_language
12032 (do_exact_match): New function.
12033 (ada_get_symbol_name_matcher): Return do_exact_match when
12034 doing a verbatim match.
12036 2019-02-15 Tom Tromey <tromey@adacore.com>
12038 * ravenscar-thread.c (ravenscar_thread_target::resume)
12039 (ravenscar_thread_target::wait): Special case wildcard requests.
12041 2019-02-15 Tom Tromey <tromey@adacore.com>
12043 * ravenscar-thread.c (base_ptid): Remove.
12044 (struct ravenscar_thread_target) <close>: New method.
12045 <m_base_ptid>: New member.
12046 <update_inferior_ptid, active_task, task_is_currently_active,
12047 runtime_initialized>: Declare methods.
12048 <ravenscar_thread_target>: Add constructor.
12049 (ravenscar_thread_target::task_is_currently_active)
12050 (ravenscar_thread_target::update_inferior_ptid)
12051 (ravenscar_runtime_initialized): Rename. Now methods.
12052 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12053 (ravenscar_thread_target::update_thread_list): Update.
12054 (ravenscar_thread_target::active_task): Now method.
12055 (ravenscar_thread_target::store_registers)
12056 (ravenscar_thread_target::prepare_to_store)
12057 (ravenscar_thread_target::prepare_to_store)
12058 (ravenscar_thread_target::mourn_inferior): Update.
12059 (ravenscar_inferior_created): Use "new" to create target.
12060 (ravenscar_thread_target::get_ada_task_ptid): Update.
12061 (_initialize_ravenscar): Don't initialize base_ptid.
12062 (ravenscar_ops): Remove global.
12064 2019-02-15 Tom Tromey <tromey@adacore.com>
12066 * target.h (push_target): Declare new overload.
12067 * target.c (push_target): New overload, taking an rvalue reference.
12068 * remote.c (remote_target::open_1): Use push_target overload.
12069 * corelow.c (core_target_open): Use push_target overload.
12071 2019-02-15 Tom Tromey <tromey@adacore.com>
12073 * ravenscar-thread.c (is_ravenscar_task)
12074 (ravenscar_task_is_currently_active): Return bool.
12075 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12076 (_initialize_ravenscar): Remove "(void)".
12077 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12080 2019-02-15 Tom Tromey <tromey@adacore.com>
12082 * ravenscar-thread.c (ravenscar_runtime_initializer)
12083 (has_ravenscar_runtime, get_running_thread_id)
12084 (ravenscar_thread_target::resume): Fix indentation.
12086 2019-02-15 Tom Tromey <tromey@adacore.com>
12088 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12089 from ravenscar_arch_ops.
12090 (sparc_ravenscar_ops::fetch_registers)
12091 (sparc_ravenscar_ops::store_registers): Now methods.
12092 (sparc_ravenscar_prepare_to_store): Remove.
12093 (sparc_ravenscar_ops): Redefine.
12094 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12095 methods and destructor. Remove members.
12096 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12097 (ravenscar_thread_target::store_registers)
12098 (ravenscar_thread_target::prepare_to_store): Update.
12099 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12101 (struct ppc_ravenscar_powerpc_ops): Derive from
12102 ravenscar_arch_ops.
12103 (ppc_ravenscar_powerpc_ops::fetch_registers)
12104 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12105 (ppc_ravenscar_powerpc_ops): Redefine.
12106 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12107 (ppc_ravenscar_e500_ops::fetch_registers)
12108 (ppc_ravenscar_e500_ops::store_registers): Now methods.
12109 (ppc_ravenscar_e500_ops): Redefine.
12110 * aarch64-ravenscar-thread.c
12111 (aarch64_ravenscar_generic_prepare_to_store): Remove.
12112 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12113 (aarch64_ravenscar_fetch_registers)
12114 (aarch64_ravenscar_store_registers): Now methods.
12115 (aarch64_ravenscar_ops): Redefine.
12117 2019-02-15 Tom Tromey <tromey@adacore.com>
12119 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12120 (ravenscar_thread_target::stopped_by_hw_breakpoint)
12121 (ravenscar_thread_target::stopped_by_watchpoint)
12122 (ravenscar_thread_target::stopped_data_address)
12123 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12125 2019-02-15 Tom Tromey <tromey@adacore.com>
12127 * ravenscar-thread.c: Fix some typos.
12129 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12130 Tom Tromey <tromey@adacore.com>
12132 * ada-lang.c (ada_exception_sal): Change addr_string to a
12134 (create_ada_exception_catchpoint): Update.
12136 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12137 Tom Tromey <tromey@adacore.com>
12139 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12140 (bp_location_ops): Remove.
12141 (base_breakpoint_allocate_location): Update.
12142 (free_bp_location): Update.
12143 * ada-lang.c (class ada_catchpoint_location)
12144 <ada_catchpoint_location>: Remove ops parameter.
12145 (ada_catchpoint_location_dtor): Remove.
12146 (ada_catchpoint_location_ops): Remove.
12147 (allocate_location_exception): Update.
12148 * breakpoint.h (struct bp_location_ops): Remove.
12149 (class bp_location) <bp_location>: Remove bp_location_ops
12151 <~bp_location>: Add destructor.
12154 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12155 Pedro Alves <palves@redhat.com>
12157 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12160 2019-02-14 David Michael <fedora.dm0@gmail.com>
12161 Samuel Thibault <samuel.thibault@gnu.org>
12162 Thomas Schwinge <thomas@codesourcery.com>
12164 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12165 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12167 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12169 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12170 (check_empty): Use "const char *".
12172 * gnu-nat.c (gnu_nat_target::detach): Instead of
12173 'detach_inferior (pid)' call
12174 'detach_inferior (find_inferior_pid (pid))'.
12176 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12177 'nat/fork-inferior.o'.
12178 * gnu-nat.c: #include "nat/fork-inferior.h".
12180 * gnu-nat.c (gnu_nat_target::detach): Instead of
12181 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12182 * gnu-nat.h: #include "inf-child.h".
12183 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12184 'i386_gnu_nat_target::fetch_registers'.
12185 (gnu_store_registers): Rename/move to
12186 'i386_gnu_nat_target::store_registers'.
12188 * config/i386/nm-i386gnu.h: Don't "#include" any files.
12189 * gnu-nat.h (mach_thread_info): New function.
12190 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12192 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12194 2019-02-14 Frederic Konrad <konrad@adacore.com>
12196 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12198 2019-02-14 Joel Brobecker <brobecker@adacore.com>
12200 * windows-nat.c (windows_add_thread): Add new parameter
12201 "main_thread_p" with default value set to false. Update
12202 function documentation as well as all callers.
12203 (windows_delete_thread): Likewise.
12204 (fake_create_process): Update call to windows_add_thread.
12205 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12206 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12207 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12208 call to windows_delete_thread.
12210 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
12212 * MAINTAINERS: Add Andrew Burgess as global maintainer.
12214 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12216 * symfile.c (find_separate_debug_file): Use canonical path of
12217 sysroot with child_path instead of gdb_sysroot if it is valid.
12219 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12221 * symfile.c (find_separate_debug_file): Use child_path to
12222 determine if an object file is under a sysroot.
12224 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12226 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12227 unittests/child-path-selftests.c.
12228 * common/pathstuff.c (child_path): New function.
12229 * common/pathstuff.h (child_path): New prototype.
12230 * unittests/child-path-selftests.c: New file.
12232 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12234 * symfile.c (find_separate_debug_file): Look for separate debug
12235 files in debug directories under the sysroot.
12237 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12239 * symtab.h (struct minimal_symbol data_p): New const method.
12240 (struct minimal_symbol text_p): Likewise.
12241 * symtab.c (output_source_filename): Use file name style
12242 to print file name.
12243 (print_symbol_info): Likewise.
12244 (print_msymbol_info): Use address style to print addresses.
12245 Use function name style to print executable text symbols.
12246 (expand_symtab_containing_pc): Use data_p.
12247 (find_pc_sect_compunit_symtab): Likewise.
12249 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12251 * breakpoint.c (describe_other_breakpoints): Use address style
12252 to print addresses.
12253 (say_where): Likewise.
12255 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12257 * ada-typeprint.c (print_func_type): Print function name
12258 style to print function name.
12259 * c-typeprint.c (c_print_type_1): Likewise.
12261 2019-02-11 Alan Hayward <alan.hayward@arm.com>
12263 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12266 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12268 * c-exp.y (direct_abs_decl): Use emplace_back to record the
12271 2019-02-10 Joel Brobecker <brobecker@adacore.com>
12273 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12274 TYPE_CODE_REF types.
12276 2019-02-08 Jim Wilson <jimw@sifive.com>
12278 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12279 (riscv_linux_fregset): New.
12280 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12282 2019-02-07 Tom Tromey <tom@tromey.com>
12284 * thread.c (thread_cancel_execution_command): Update.
12285 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12287 (struct thread_fsm_ops): Remove.
12288 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12289 (thread_fsm_should_stop, thread_fsm_return_value)
12290 (thread_fsm_set_finished, thread_fsm_finished_p)
12291 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12293 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12294 * infrun.c (clear_proceed_status_thread)
12295 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12296 (print_stop_event): Update.
12297 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12299 (step_command_fsm_ops): Remove.
12300 (new_step_command_fsm): Remove.
12302 (step_command_fsm::should_stop): Rename from
12303 step_command_fsm_should_stop.
12304 (step_command_fsm::clean_up): Rename from
12305 step_command_fsm_clean_up.
12306 (step_command_fsm::do_async_reply_reason): Rename from
12307 step_command_fsm_async_reply_reason.
12308 (struct until_next_fsm): Inherit from thread_fsm. Add
12310 (until_next_fsm_ops): Remove.
12311 (new_until_next_fsm): Remove.
12312 (until_next_fsm::should_stop): Rename from
12313 until_next_fsm_should_stop.
12314 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12315 (until_next_fsm::do_async_reply_reason): Rename from
12316 until_next_fsm_async_reply_reason.
12317 (struct finish_command_fsm): Inherit from thread_fsm. Add
12318 constructor. Change type of breakpoint.
12319 (finish_command_fsm_ops): Remove.
12320 (new_finish_command_fsm): Remove.
12321 (finish_command_fsm::should_stop): Rename from
12322 finish_command_fsm_should_stop.
12323 (finish_command_fsm::clean_up): Rename from
12324 finish_command_fsm_clean_up.
12325 (finish_command_fsm::return_value): Rename from
12326 finish_command_fsm_return_value.
12327 (finish_command_fsm::do_async_reply_reason): Rename from
12328 finish_command_fsm_async_reply_reason.
12329 (finish_command): Update.
12330 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12332 (call_thread_fsm_ops): Remove.
12333 (call_thread_fsm::call_thread_fsm): Rename from
12334 new_call_thread_fsm.
12335 (call_thread_fsm::should_stop): Rename from
12336 call_thread_fsm_should_stop.
12337 (call_thread_fsm::should_notify_stop): Rename from
12338 call_thread_fsm_should_notify_stop.
12339 (run_inferior_call, call_function_by_hand_dummy): Update.
12340 * cli/cli-interp.c (should_print_stop_to_console): Update.
12341 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12342 Add constructor. Change type of location_breakpoint,
12344 (until_break_fsm_ops): Remove.
12345 (new_until_break_fsm): Remove.
12346 (until_break_fsm::should_stop): Rename from
12347 until_break_fsm_should_stop.
12348 (until_break_fsm::clean_up): Rename from
12349 until_break_fsm_clean_up.
12350 (until_break_fsm::do_async_reply_reason): Rename from
12351 until_break_fsm_async_reply_reason.
12352 (until_break_command): Update.
12353 * thread-fsm.c: Remove.
12354 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12356 2019-02-07 Tom Tromey <tom@tromey.com>
12358 * yy-remap.h: Add include guard.
12359 * xtensa-tdep.h: Add include guard.
12360 * xcoffread.h: Rename include guard.
12361 * varobj-iter.h: Add include guard.
12362 * tui/tui.h: Rename include guard.
12363 * tui/tui-winsource.h: Rename include guard.
12364 * tui/tui-wingeneral.h: Rename include guard.
12365 * tui/tui-windata.h: Rename include guard.
12366 * tui/tui-win.h: Rename include guard.
12367 * tui/tui-stack.h: Rename include guard.
12368 * tui/tui-source.h: Rename include guard.
12369 * tui/tui-regs.h: Rename include guard.
12370 * tui/tui-out.h: Rename include guard.
12371 * tui/tui-layout.h: Rename include guard.
12372 * tui/tui-io.h: Rename include guard.
12373 * tui/tui-hooks.h: Rename include guard.
12374 * tui/tui-file.h: Rename include guard.
12375 * tui/tui-disasm.h: Rename include guard.
12376 * tui/tui-data.h: Rename include guard.
12377 * tui/tui-command.h: Rename include guard.
12378 * tic6x-tdep.h: Add include guard.
12379 * target/waitstatus.h: Rename include guard.
12380 * target/wait.h: Rename include guard.
12381 * target/target.h: Rename include guard.
12382 * target/resume.h: Rename include guard.
12383 * target-float.h: Rename include guard.
12384 * stabsread.h: Add include guard.
12385 * rs6000-tdep.h: Add include guard.
12386 * riscv-fbsd-tdep.h: Add include guard.
12387 * regformats/regdef.h: Rename include guard.
12388 * record.h: Rename include guard.
12389 * python/python.h: Rename include guard.
12390 * python/python-internal.h: Rename include guard.
12391 * python/py-stopevent.h: Rename include guard.
12392 * python/py-ref.h: Rename include guard.
12393 * python/py-record.h: Rename include guard.
12394 * python/py-record-full.h: Rename include guard.
12395 * python/py-record-btrace.h: Rename include guard.
12396 * python/py-instruction.h: Rename include guard.
12397 * python/py-events.h: Rename include guard.
12398 * python/py-event.h: Rename include guard.
12399 * procfs.h: Add include guard.
12400 * proc-utils.h: Add include guard.
12401 * p-lang.h: Add include guard.
12402 * or1k-tdep.h: Rename include guard.
12403 * observable.h: Rename include guard.
12404 * nto-tdep.h: Rename include guard.
12405 * nat/x86-linux.h: Rename include guard.
12406 * nat/x86-linux-dregs.h: Rename include guard.
12407 * nat/x86-gcc-cpuid.h: Add include guard.
12408 * nat/x86-dregs.h: Rename include guard.
12409 * nat/x86-cpuid.h: Rename include guard.
12410 * nat/ppc-linux.h: Rename include guard.
12411 * nat/mips-linux-watch.h: Rename include guard.
12412 * nat/linux-waitpid.h: Rename include guard.
12413 * nat/linux-ptrace.h: Rename include guard.
12414 * nat/linux-procfs.h: Rename include guard.
12415 * nat/linux-osdata.h: Rename include guard.
12416 * nat/linux-nat.h: Rename include guard.
12417 * nat/linux-namespaces.h: Rename include guard.
12418 * nat/linux-btrace.h: Rename include guard.
12419 * nat/glibc_thread_db.h: Rename include guard.
12420 * nat/gdb_thread_db.h: Rename include guard.
12421 * nat/gdb_ptrace.h: Rename include guard.
12422 * nat/fork-inferior.h: Rename include guard.
12423 * nat/amd64-linux-siginfo.h: Rename include guard.
12424 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12425 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12426 * nat/aarch64-linux.h: Rename include guard.
12427 * nat/aarch64-linux-hw-point.h: Rename include guard.
12428 * mn10300-tdep.h: Add include guard.
12429 * mips-linux-tdep.h: Add include guard.
12430 * mi/mi-parse.h: Rename include guard.
12431 * mi/mi-out.h: Rename include guard.
12432 * mi/mi-main.h: Rename include guard.
12433 * mi/mi-interp.h: Rename include guard.
12434 * mi/mi-getopt.h: Rename include guard.
12435 * mi/mi-console.h: Rename include guard.
12436 * mi/mi-common.h: Rename include guard.
12437 * mi/mi-cmds.h: Rename include guard.
12438 * mi/mi-cmd-break.h: Rename include guard.
12439 * m2-lang.h: Add include guard.
12440 * location.h: Rename include guard.
12441 * linux-record.h: Rename include guard.
12442 * linux-nat.h: Add include guard.
12443 * linux-fork.h: Add include guard.
12444 * i386-darwin-tdep.h: Rename include guard.
12445 * hppa-linux-offsets.h: Add include guard.
12446 * guile/guile.h: Rename include guard.
12447 * guile/guile-internal.h: Rename include guard.
12448 * gnu-nat.h: Rename include guard.
12449 * gdb-stabs.h: Rename include guard.
12450 * frv-tdep.h: Add include guard.
12451 * f-lang.h: Add include guard.
12452 * event-loop.h: Add include guard.
12453 * darwin-nat.h: Rename include guard.
12454 * cp-abi.h: Rename include guard.
12455 * config/sparc/nm-sol2.h: Rename include guard.
12456 * config/nm-nto.h: Rename include guard.
12457 * config/nm-linux.h: Add include guard.
12458 * config/i386/nm-i386gnu.h: Rename include guard.
12459 * config/djgpp/nl_types.h: Rename include guard.
12460 * config/djgpp/langinfo.h: Rename include guard.
12461 * compile/gcc-cp-plugin.h: Add include guard.
12462 * compile/gcc-c-plugin.h: Add include guard.
12463 * compile/compile.h: Rename include guard.
12464 * compile/compile-object-run.h: Rename include guard.
12465 * compile/compile-object-load.h: Rename include guard.
12466 * compile/compile-internal.h: Rename include guard.
12467 * compile/compile-cplus.h: Rename include guard.
12468 * compile/compile-c.h: Rename include guard.
12469 * common/xml-utils.h: Rename include guard.
12470 * common/x86-xstate.h: Rename include guard.
12471 * common/version.h: Rename include guard.
12472 * common/vec.h: Rename include guard.
12473 * common/tdesc.h: Rename include guard.
12474 * common/selftest.h: Rename include guard.
12475 * common/scoped_restore.h: Rename include guard.
12476 * common/scoped_mmap.h: Rename include guard.
12477 * common/scoped_fd.h: Rename include guard.
12478 * common/safe-iterator.h: Rename include guard.
12479 * common/run-time-clock.h: Rename include guard.
12480 * common/refcounted-object.h: Rename include guard.
12481 * common/queue.h: Rename include guard.
12482 * common/ptid.h: Rename include guard.
12483 * common/print-utils.h: Rename include guard.
12484 * common/preprocessor.h: Rename include guard.
12485 * common/pathstuff.h: Rename include guard.
12486 * common/observable.h: Rename include guard.
12487 * common/netstuff.h: Rename include guard.
12488 * common/job-control.h: Rename include guard.
12489 * common/host-defs.h: Rename include guard.
12490 * common/gdb_wait.h: Rename include guard.
12491 * common/gdb_vecs.h: Rename include guard.
12492 * common/gdb_unlinker.h: Rename include guard.
12493 * common/gdb_unique_ptr.h: Rename include guard.
12494 * common/gdb_tilde_expand.h: Rename include guard.
12495 * common/gdb_sys_time.h: Rename include guard.
12496 * common/gdb_string_view.h: Rename include guard.
12497 * common/gdb_splay_tree.h: Rename include guard.
12498 * common/gdb_setjmp.h: Rename include guard.
12499 * common/gdb_ref_ptr.h: Rename include guard.
12500 * common/gdb_optional.h: Rename include guard.
12501 * common/gdb_locale.h: Rename include guard.
12502 * common/gdb_assert.h: Rename include guard.
12503 * common/filtered-iterator.h: Rename include guard.
12504 * common/filestuff.h: Rename include guard.
12505 * common/fileio.h: Rename include guard.
12506 * common/environ.h: Rename include guard.
12507 * common/common-utils.h: Rename include guard.
12508 * common/common-types.h: Rename include guard.
12509 * common/common-regcache.h: Rename include guard.
12510 * common/common-inferior.h: Rename include guard.
12511 * common/common-gdbthread.h: Rename include guard.
12512 * common/common-exceptions.h: Rename include guard.
12513 * common/common-defs.h: Rename include guard.
12514 * common/common-debug.h: Rename include guard.
12515 * common/cleanups.h: Rename include guard.
12516 * common/buffer.h: Rename include guard.
12517 * common/btrace-common.h: Rename include guard.
12518 * common/break-common.h: Rename include guard.
12519 * cli/cli-utils.h: Rename include guard.
12520 * cli/cli-style.h: Rename include guard.
12521 * cli/cli-setshow.h: Rename include guard.
12522 * cli/cli-script.h: Rename include guard.
12523 * cli/cli-interp.h: Rename include guard.
12524 * cli/cli-decode.h: Rename include guard.
12525 * cli/cli-cmds.h: Rename include guard.
12526 * charset-list.h: Add include guard.
12527 * buildsym-legacy.h: Rename include guard.
12528 * bfin-tdep.h: Add include guard.
12529 * ax.h: Rename include guard.
12530 * arm-linux-tdep.h: Add include guard.
12531 * arm-fbsd-tdep.h: Add include guard.
12532 * arch/xtensa.h: Rename include guard.
12533 * arch/tic6x.h: Add include guard.
12534 * arch/i386.h: Add include guard.
12535 * arch/arm.h: Rename include guard.
12536 * arch/arm-linux.h: Rename include guard.
12537 * arch/arm-get-next-pcs.h: Rename include guard.
12538 * arch/amd64.h: Add include guard.
12539 * arch/aarch64-insn.h: Rename include guard.
12540 * arch-utils.h: Rename include guard.
12541 * annotate.h: Add include guard.
12542 * amd64-darwin-tdep.h: Rename include guard.
12543 * aarch64-linux-tdep.h: Add include guard.
12544 * aarch64-fbsd-tdep.h: Add include guard.
12545 * aarch32-linux-nat.h: Add include guard.
12547 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12549 * macrotab.c (macro_define_internal): New function that
12550 factorizes macro_define_object_internal and macro_define_function
12552 (macro_define_object_internal): Use macro_define_internal.
12553 (macro_define_function): Likewise.
12555 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12557 * macrocmd.c (extract_identifier): Return
12558 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12561 2019-02-06 John Baldwin <jhb@FreeBSD.org>
12563 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12565 2019-02-05 Tom Tromey <tom@tromey.com>
12567 * target.c (target_stack::unpush): Move assertion earlier.
12569 2019-01-30 Tom Tromey <tom@tromey.com>
12572 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12573 (gdbpy_parse_and_eval): Likewise.
12574 * python/python-internal.h (gdbpy_allow_threads): New class.
12576 2019-01-28 John Baldwin <jhb@FreeBSD.org>
12578 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12579 (aarch64_fbsd_fpregmap): Move earlier.
12580 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12581 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12582 instead of individual calls to trad_frame_set_reg_addr.
12583 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12585 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12586 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12587 instead of individual calls to trad_frame_set_reg_addr.
12589 2019-01-28 Alan Hayward <alan.hayward@arm.com>
12591 * CONTRIBUTE: Replace contribution list with wiki link.
12593 2019-01-25 Tom Tromey <tom@tromey.com>
12595 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12597 2019-01-25 Tom Tromey <tom@tromey.com>
12599 * xtensa-linux-nat.c: Fix common/ includes.
12600 * xml-support.h: Fix common/ includes.
12601 * xml-support.c: Fix common/ includes.
12602 * x86-linux-nat.c: Fix common/ includes.
12603 * windows-nat.c: Fix common/ includes.
12604 * varobj.h: Fix common/ includes.
12605 * varobj.c: Fix common/ includes.
12606 * value.c: Fix common/ includes.
12607 * valops.c: Fix common/ includes.
12608 * utils.c: Fix common/ includes.
12609 * unittests/xml-utils-selftests.c: Fix common/ includes.
12610 * unittests/utils-selftests.c: Fix common/ includes.
12611 * unittests/unpack-selftests.c: Fix common/ includes.
12612 * unittests/tracepoint-selftests.c: Fix common/ includes.
12613 * unittests/style-selftests.c: Fix common/ includes.
12614 * unittests/string_view-selftests.c: Fix common/ includes.
12615 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12616 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12617 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12618 * unittests/rsp-low-selftests.c: Fix common/ includes.
12619 * unittests/parse-connection-spec-selftests.c: Fix common/
12621 * unittests/optional-selftests.c: Fix common/ includes.
12622 * unittests/offset-type-selftests.c: Fix common/ includes.
12623 * unittests/observable-selftests.c: Fix common/ includes.
12624 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12625 * unittests/memrange-selftests.c: Fix common/ includes.
12626 * unittests/memory-map-selftests.c: Fix common/ includes.
12627 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12628 * unittests/function-view-selftests.c: Fix common/ includes.
12629 * unittests/environ-selftests.c: Fix common/ includes.
12630 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12631 * unittests/common-utils-selftests.c: Fix common/ includes.
12632 * unittests/cli-utils-selftests.c: Fix common/ includes.
12633 * unittests/array-view-selftests.c: Fix common/ includes.
12634 * ui-file.c: Fix common/ includes.
12635 * tui/tui-io.c: Fix common/ includes.
12636 * tracepoint.h: Fix common/ includes.
12637 * tracepoint.c: Fix common/ includes.
12638 * tracefile-tfile.c: Fix common/ includes.
12639 * top.h: Fix common/ includes.
12640 * top.c: Fix common/ includes.
12641 * thread.c: Fix common/ includes.
12642 * target/waitstatus.h: Fix common/ includes.
12643 * target/waitstatus.c: Fix common/ includes.
12644 * target.h: Fix common/ includes.
12645 * target.c: Fix common/ includes.
12646 * target-memory.c: Fix common/ includes.
12647 * target-descriptions.c: Fix common/ includes.
12648 * symtab.h: Fix common/ includes.
12649 * symfile.c: Fix common/ includes.
12650 * stap-probe.c: Fix common/ includes.
12651 * spu-linux-nat.c: Fix common/ includes.
12652 * sparc-nat.c: Fix common/ includes.
12653 * source.c: Fix common/ includes.
12654 * solib.c: Fix common/ includes.
12655 * solib-target.c: Fix common/ includes.
12656 * ser-unix.c: Fix common/ includes.
12657 * ser-tcp.c: Fix common/ includes.
12658 * ser-pipe.c: Fix common/ includes.
12659 * ser-base.c: Fix common/ includes.
12660 * selftest-arch.c: Fix common/ includes.
12661 * s12z-tdep.c: Fix common/ includes.
12662 * rust-exp.y: Fix common/ includes.
12663 * rs6000-aix-tdep.c: Fix common/ includes.
12664 * riscv-tdep.c: Fix common/ includes.
12665 * remote.c: Fix common/ includes.
12666 * remote-notif.h: Fix common/ includes.
12667 * remote-fileio.h: Fix common/ includes.
12668 * remote-fileio.c: Fix common/ includes.
12669 * regcache.h: Fix common/ includes.
12670 * regcache.c: Fix common/ includes.
12671 * record-btrace.c: Fix common/ includes.
12672 * python/python.c: Fix common/ includes.
12673 * python/py-type.c: Fix common/ includes.
12674 * python/py-inferior.c: Fix common/ includes.
12675 * progspace.h: Fix common/ includes.
12676 * producer.c: Fix common/ includes.
12677 * procfs.c: Fix common/ includes.
12678 * proc-api.c: Fix common/ includes.
12679 * printcmd.c: Fix common/ includes.
12680 * ppc-linux-nat.c: Fix common/ includes.
12681 * parser-defs.h: Fix common/ includes.
12682 * osdata.c: Fix common/ includes.
12683 * obsd-nat.c: Fix common/ includes.
12684 * nat/x86-linux.c: Fix common/ includes.
12685 * nat/x86-linux-dregs.c: Fix common/ includes.
12686 * nat/x86-dregs.h: Fix common/ includes.
12687 * nat/x86-dregs.c: Fix common/ includes.
12688 * nat/ppc-linux.c: Fix common/ includes.
12689 * nat/mips-linux-watch.h: Fix common/ includes.
12690 * nat/mips-linux-watch.c: Fix common/ includes.
12691 * nat/linux-waitpid.c: Fix common/ includes.
12692 * nat/linux-ptrace.h: Fix common/ includes.
12693 * nat/linux-ptrace.c: Fix common/ includes.
12694 * nat/linux-procfs.c: Fix common/ includes.
12695 * nat/linux-personality.c: Fix common/ includes.
12696 * nat/linux-osdata.c: Fix common/ includes.
12697 * nat/linux-namespaces.c: Fix common/ includes.
12698 * nat/linux-btrace.h: Fix common/ includes.
12699 * nat/linux-btrace.c: Fix common/ includes.
12700 * nat/fork-inferior.c: Fix common/ includes.
12701 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12702 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12703 * nat/aarch64-linux.c: Fix common/ includes.
12704 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12705 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12706 * namespace.h: Fix common/ includes.
12707 * mips-linux-tdep.c: Fix common/ includes.
12708 * minsyms.c: Fix common/ includes.
12709 * mi/mi-parse.h: Fix common/ includes.
12710 * mi/mi-main.c: Fix common/ includes.
12711 * mi/mi-cmd-env.c: Fix common/ includes.
12712 * memrange.h: Fix common/ includes.
12713 * memattr.c: Fix common/ includes.
12714 * maint.h: Fix common/ includes.
12715 * maint.c: Fix common/ includes.
12716 * main.c: Fix common/ includes.
12717 * machoread.c: Fix common/ includes.
12718 * location.c: Fix common/ includes.
12719 * linux-thread-db.c: Fix common/ includes.
12720 * linux-nat.c: Fix common/ includes.
12721 * linux-fork.c: Fix common/ includes.
12722 * inline-frame.c: Fix common/ includes.
12723 * infrun.c: Fix common/ includes.
12724 * inflow.c: Fix common/ includes.
12725 * inferior.h: Fix common/ includes.
12726 * inferior.c: Fix common/ includes.
12727 * infcmd.c: Fix common/ includes.
12728 * inf-ptrace.c: Fix common/ includes.
12729 * inf-child.c: Fix common/ includes.
12730 * ia64-linux-nat.c: Fix common/ includes.
12731 * i387-tdep.c: Fix common/ includes.
12732 * i386-tdep.c: Fix common/ includes.
12733 * i386-linux-tdep.c: Fix common/ includes.
12734 * i386-linux-nat.c: Fix common/ includes.
12735 * i386-go32-tdep.c: Fix common/ includes.
12736 * i386-fbsd-tdep.c: Fix common/ includes.
12737 * i386-fbsd-nat.c: Fix common/ includes.
12738 * guile/scm-type.c: Fix common/ includes.
12739 * guile/guile.c: Fix common/ includes.
12740 * go32-nat.c: Fix common/ includes.
12741 * gnu-nat.c: Fix common/ includes.
12742 * gdbthread.h: Fix common/ includes.
12743 * gdbarch-selftests.c: Fix common/ includes.
12744 * gdb_usleep.c: Fix common/ includes.
12745 * gdb_select.h: Fix common/ includes.
12746 * gdb_bfd.c: Fix common/ includes.
12747 * gcore.c: Fix common/ includes.
12748 * fork-child.c: Fix common/ includes.
12749 * findvar.c: Fix common/ includes.
12750 * fbsd-nat.c: Fix common/ includes.
12751 * event-top.c: Fix common/ includes.
12752 * event-loop.c: Fix common/ includes.
12753 * dwarf2read.c: Fix common/ includes.
12754 * dwarf2loc.c: Fix common/ includes.
12755 * dwarf2-frame.c: Fix common/ includes.
12756 * dwarf-index-cache.c: Fix common/ includes.
12757 * dtrace-probe.c: Fix common/ includes.
12758 * disasm-selftests.c: Fix common/ includes.
12759 * defs.h: Fix common/ includes.
12760 * csky-tdep.c: Fix common/ includes.
12761 * cp-valprint.c: Fix common/ includes.
12762 * cp-support.h: Fix common/ includes.
12763 * cp-support.c: Fix common/ includes.
12764 * corelow.c: Fix common/ includes.
12765 * completer.h: Fix common/ includes.
12766 * completer.c: Fix common/ includes.
12767 * compile/compile.c: Fix common/ includes.
12768 * compile/compile-loc2c.c: Fix common/ includes.
12769 * compile/compile-cplus-types.c: Fix common/ includes.
12770 * compile/compile-cplus-symbols.c: Fix common/ includes.
12771 * command.h: Fix common/ includes.
12772 * cli/cli-dump.c: Fix common/ includes.
12773 * cli/cli-cmds.c: Fix common/ includes.
12774 * charset.c: Fix common/ includes.
12775 * build-id.c: Fix common/ includes.
12776 * btrace.h: Fix common/ includes.
12777 * btrace.c: Fix common/ includes.
12778 * breakpoint.h: Fix common/ includes.
12779 * breakpoint.c: Fix common/ includes.
12781 (enum agent_op): Fix common/ includes.
12782 * ax-general.c (struct aop_map): Fix common/ includes.
12783 * ax-gdb.c: Fix common/ includes.
12784 * auxv.c: Fix common/ includes.
12785 * auto-load.c: Fix common/ includes.
12786 * arm-tdep.c: Fix common/ includes.
12787 * arch/riscv.c: Fix common/ includes.
12788 * arch/ppc-linux-common.c: Fix common/ includes.
12789 * arch/i386.c: Fix common/ includes.
12790 * arch/arm.c: Fix common/ includes.
12791 * arch/arm-linux.c: Fix common/ includes.
12792 * arch/arm-get-next-pcs.c: Fix common/ includes.
12793 * arch/amd64.c: Fix common/ includes.
12794 * arch/aarch64.c: Fix common/ includes.
12795 * arch/aarch64-insn.c: Fix common/ includes.
12796 * arch-utils.c: Fix common/ includes.
12797 * amd64-windows-tdep.c: Fix common/ includes.
12798 * amd64-tdep.c: Fix common/ includes.
12799 * amd64-sol2-tdep.c: Fix common/ includes.
12800 * amd64-obsd-tdep.c: Fix common/ includes.
12801 * amd64-nbsd-tdep.c: Fix common/ includes.
12802 * amd64-linux-tdep.c: Fix common/ includes.
12803 * amd64-linux-nat.c: Fix common/ includes.
12804 * amd64-fbsd-tdep.c: Fix common/ includes.
12805 * amd64-fbsd-nat.c: Fix common/ includes.
12806 * amd64-dicos-tdep.c: Fix common/ includes.
12807 * amd64-darwin-tdep.c: Fix common/ includes.
12808 * agent.c: Fix common/ includes.
12809 * ada-lang.h: Fix common/ includes.
12810 * ada-lang.c: Fix common/ includes.
12811 * aarch64-tdep.c: Fix common/ includes.
12813 2019-01-25 Tom Tromey <tom@tromey.com>
12815 * common/create-version.sh: Use common/version.h.
12817 2019-01-24 Pedro Alves <palves@redhat.com>
12819 * infrun.c (signal_stop, signal_print, signal_program)
12820 (signal_catch, signal_pass): Now arrays instead of pointers.
12821 (update_signals_program_target, do_target_resume)
12822 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12823 * linux-nat.c (linux_nat_target::pass_signals)
12824 (linux_nat_target::create_inferior, linux_nat_target::attach):
12826 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12827 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12828 * procfs.c (procfs_target::pass_signals): Adjust.
12829 * record-full.c (record_full_target::resume): Adjust.
12830 * remote.c (remote_target::pass_signals)
12831 (remote_target::program_signals): Adjust.
12832 * target-debug.h (target_debug_print_signals): Now takes a
12833 gdb::array_view as parameter. Adjust.
12834 * target.h (target_ops) <pass_signals, program_signals>: Replace
12835 pointer and length parameters with gdb::array_view.
12836 (target_pass_signals, target_program_signals): Likewise.
12837 * target-delegates.c: Regenerate.
12839 2019-01-24 Pedro Alves <palves@redhat.com>
12841 * common/forward-scope-exit.h
12842 (forward_scope_exit::forward_scope_exit): Pass arguments to
12843 m_bind_function directly, instead of creating a std::bind and
12846 2019-01-24 Alan Hayward <alan.hayward@arm.com>
12848 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12849 for static members.
12850 (pass_in_v_vfp_candidate): Likewise.
12852 2019-01-23 Tom Tromey <tom@tromey.com>
12853 Pedro Alves <palves@redhat.com>
12855 * regcache.c (class regcache_invalidator): Remove.
12856 (regcache::raw_write): Use make_scope_exit.
12858 2019-01-23 Tom Tromey <tom@tromey.com>
12860 * ui-out.h (class ui_out_emit_type): Update comment.
12862 2019-01-23 Tom Tromey <tom@tromey.com>
12864 * infrun.c (fetch_inferior_event): Update comment.
12866 2019-01-23 Tom Tromey <tom@tromey.com>
12867 Pedro Alves <palves@redhat.com>
12869 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12871 (fetch_inferior_event): Use SCOPE_EXIT.
12874 2019-01-23 Tom Tromey <tom@tromey.com>
12875 Pedro Alves <palves@redhat.com>
12877 * infrun.c (disable_thread_events): Delete.
12878 (stop_all_threads): Use SCOPE_EXIT.
12880 2019-01-23 Tom Tromey <tom@tromey.com>
12881 Pedro Alves <palves@redhat.com>
12883 * symfile.c: Include forward-scope-exit.h.
12884 (clear_symtab_users_cleanup): Replace forward declaration with
12885 a FORWARD_SCOPE_EXIT.
12886 (syms_from_objfile_1): Use the forward_scope_exit and
12887 gdb::optional instead of cleanup_function.
12888 (reread_symbols): Use the forward_scope_exit instead of
12890 (clear_symtab_users_cleanup): Remove function.
12892 2019-01-23 Tom Tromey <tom@tromey.com>
12893 Pedro Alves <palves@redhat.com>
12895 * linux-nat.c: Include scope-exit.h.
12896 (cleanup_target_stop): Remove.
12897 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12900 2019-01-23 Tom Tromey <tom@tromey.com>
12901 Pedro Alves <palves@redhat.com>
12903 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12904 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12906 2019-01-23 Tom Tromey <tom@tromey.com>
12907 Andrew Burgess <andrew.burgess@embecosm.com>
12908 Pedro Alves <palves@redhat.com>
12910 * infrun.c (fetch_inferior_event): Use scope_exit.
12911 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12912 * top.c (execute_command): Use scope_exit.
12913 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12914 * utils.c (do_bpstat_clear_actions_cleanup)
12915 (make_bpstat_clear_actions_cleanup): Remove.
12917 2019-01-23 Tom Tromey <tom@tromey.com>
12918 Pedro Alves <palves@redhat.com>
12920 * infrun.c: Include "common/scope-exit.h"
12921 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12922 (wait_for_inferior): Use SCOPE_EXIT.
12923 (fetch_inferior_event): Use scope_exit.
12925 2019-01-23 Tom Tromey <tom@tromey.com>
12926 Pedro Alves <palves@redhat.com>
12928 * breakpoint.c (create_breakpoint): Remove cleanup.
12930 2019-01-23 Tom Tromey <tom@tromey.com>
12931 Andrew Burgess <andrew.burgess@embecosm.com>
12932 Pedro Alves <palves@redhat.com>
12934 2019-01-23 Pedro Alves <palves@redhat.com>
12936 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12938 2019-01-23 Pedro Alves <palves@redhat.com>
12939 Andrew Burgess <andrew.burgess@embecosm.com>
12941 * gdbthread.h: Include "common/forward-scope-exit.h".
12942 (scoped_finish_thread_state): Redefine custom class in terms of
12943 forward_scope_exit.
12945 2019-01-23 Pedro Alves <palves@redhat.com>
12946 Andrew Burgess <andrew.burgess@embecosm.com>
12948 * common/forward-scope-exit.h: New file.
12950 2019-01-23 Pedro Alves <palves@redhat.com>
12951 Andrew Burgess <andrew.burgess@embecosm.com>
12952 Tom Tromey <tom@tromey.com>
12954 * common/scope-exit.h: New file.
12956 2019-01-23 Pedro Alves <palves@redhat.com>
12958 * common/preprocessor.h (ESC): Rename to ...
12959 (ESC_PARENS): ... this.
12960 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12961 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12963 2019-01-23 Tom Tromey <tom@tromey.com>
12965 * language.h (class scoped_switch_to_sym_language_if_auto):
12966 Initialize m_lang in both cases.
12968 2019-01-23 Alan Hayward <alan.hayward@arm.com>
12970 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12973 2019-01-22 Tom Tromey <tom@tromey.com>
12975 * corelow.c: Do not include sys/file.h.
12977 2019-01-22 Tom Tromey <tom@tromey.com>
12979 * tui/tui-wingeneral.h: Include gdb_curses.h.
12981 2019-01-22 Tom Tromey <tom@tromey.com>
12983 * source-cache.h (class source_cache) <get_source_lines,
12984 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12986 2019-01-22 Tom Tromey <tom@tromey.com>
12988 * remote-fileio.h (struct remote_target): Declare.
12990 2019-01-22 Tom Tromey <tom@tromey.com>
12992 * python/py-arch.c: Do not include py-ref.h.
12993 * python/py-bpevent.c: Do not include py-ref.h.
12994 * python/py-cmd.c: Do not include py-ref.h.
12995 * python/py-continueevent.c: Do not include py-ref.h.
12996 * python/py-event.h: Do not include py-ref.h.
12997 * python/py-evtregistry.c: Do not include py-ref.h.
12998 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12999 * python/py-frame.c: Do not include py-ref.h.
13000 * python/py-framefilter.c: Do not include py-ref.h.
13001 * python/py-function.c: Do not include py-ref.h.
13002 * python/py-infevents.c: Do not include py-ref.h.
13003 * python/py-linetable.c: Do not include py-ref.h.
13004 * python/py-objfile.c: Do not include py-ref.h.
13005 * python/py-param.c: Do not include py-ref.h.
13006 * python/py-prettyprint.c: Do not include py-ref.h.
13007 * python/py-progspace.c: Do not include py-ref.h.
13008 * python/py-symbol.c: Do not include py-ref.h.
13009 * python/py-symtab.c: Do not include py-ref.h.
13010 * python/py-type.c: Do not include py-ref.h.
13011 * python/py-unwind.c: Do not include py-ref.h.
13012 * python/py-utils.c: Do not include py-ref.h.
13013 * python/py-value.c: Do not include py-ref.h.
13014 * python/py-varobj.c: Do not include py-ref.h.
13015 * python/py-xmethods.c: Do not include py-ref.h.
13016 * python/python.c: Do not include py-ref.h.
13017 * varobj.c: Do not include py-ref.h.
13019 2019-01-22 Tom Tromey <tom@tromey.com>
13021 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13022 keyword for bcache.
13024 2019-01-22 Tom Tromey <tom@tromey.com>
13026 * compile/compile-cplus-types.c: Remove a comment by #include.
13028 2019-01-22 Tom Tromey <tom@tromey.com>
13030 * compile/gcc-c-plugin.h: Include compile-internal.h.
13032 2019-01-22 Tom Tromey <tom@tromey.com>
13034 * stabsread.c (EXTERN): Do not define.
13035 (symnum, next_symbol_text_func, processing_gcc_compilation)
13036 (within_function, global_sym_chain, global_stabs)
13037 (previous_stab_code, this_object_header_files)
13038 (n_this_object_header_files)
13039 (n_allocated_this_object_header_files): Define.
13040 * stabsread.h (EXTERN): Never define. Use "extern".
13042 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13044 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13047 2019-01-21 Tom Tromey <tom@tromey.com>
13049 * ui-out.c: Fix includes.
13050 * tui/tui-source.c: Fix includes.
13051 * target.c: Fix includes.
13052 * remote.c: Fix includes.
13053 * regcache.c: Fix includes.
13054 * python/py-block.c: Fix includes.
13055 * printcmd.c: Fix includes.
13056 * or1k-tdep.c: Fix includes.
13057 * mi/mi-main.c: Fix includes.
13058 * m32r-tdep.c: Fix includes.
13059 * csky-tdep.c: Fix includes.
13060 * compile/compile-cplus-types.c: Fix includes.
13061 * cli/cli-interp.c: Fix includes.
13063 2019-01-21 Alan Hayward <alan.hayward@arm.com>
13065 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13068 2019-01-16 Tom Tromey <tom@tromey.com>
13070 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
13072 (struct objfile) <msymbols_range>: Move from top level.
13073 <msymbols>: New method.
13074 (class objfile_msymbols): Remove.
13075 * symtab.c (default_collect_symbol_completion_matches_break_on):
13077 * symmisc.c (dump_msymbols): Update.
13078 * stabsread.c (scan_file_globals): Update.
13079 * objc-lang.c (info_selectors_command, info_classes_command)
13080 (find_methods): Update.
13081 * minsyms.c (find_solib_trampoline_target): Update.
13082 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13083 * coffread.c (coff_symfile_read): Update.
13084 * ada-lang.c (ada_lookup_simple_minsym)
13085 (ada_collect_symbol_completion_matches): Update.
13087 2019-01-16 Tom Tromey <tom@tromey.com>
13089 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13090 type. Remove no-argument constructor.
13091 <iterator::operator++>: Simplify.
13093 <end>: Use minimal_symbol_count.
13095 2019-01-16 Tom Tromey <tom@tromey.com>
13097 * objfiles.h (struct objfile) <psymtabs>: New method.
13098 (class objfile_psymtabs): Remove.
13099 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13101 <range>: New method.
13102 (require_partial_symbols): Change return type.
13103 * psymtab.c (require_partial_symbols)
13104 (psym_expand_symtabs_matching): Update.
13105 * mdebugread.c (parse_partial_symbols): Update.
13106 * dbxread.c (dbx_end_psymtab): Update.
13108 2019-01-15 Tom Tromey <tom@tromey.com>
13110 * symtab.c (lookup_objfile_from_block)
13111 (lookup_symbol_in_objfile_symtabs)
13112 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13113 (find_line_symtab, info_sources_command)
13114 (default_collect_symbol_completion_matches_break_on)
13115 (make_source_files_completion_list): Update.
13116 * symmisc.c (print_objfile_statistics, dump_objfile)
13117 (maintenance_print_symbols, maintenance_info_symtabs)
13118 (maintenance_check_symtabs, maintenance_info_line_tables):
13120 * source.c (select_source_symtab)
13121 (forget_cached_source_info_for_objfile): Update.
13122 * objfiles.h (class objfile_compunits): Remove.
13123 (struct objfile) <compunits_range>: New typedef.
13124 (compunits): New method.
13125 * objfiles.c (objfile_relocate1): Update.
13126 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13127 * maint.c (count_symtabs_and_blocks): Update.
13128 * linespec.c (iterate_over_all_matching_symtabs): Update.
13129 * cp-support.c (add_symbol_overload_list_qualified): Update.
13130 * coffread.c (coff_symtab_read): Update.
13131 * ada-lang.c (add_nonlocal_symbols)
13132 (ada_collect_symbol_completion_matches)
13133 (ada_add_global_exceptions): Update.
13135 2019-01-15 Tom Tromey <tom@tromey.com>
13137 * progspace.h (program_space) <objfiles_safe_range>: New
13139 <objfiles_safe>: New method.
13140 * objfiles.h (class all_objfiles_safe): Remove.
13141 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13142 * jit.c (jit_inferior_exit_hook): Update.
13144 2019-01-17 Tom Tromey <tom@tromey.com>
13146 * progspace.h (program_space) <objfiles_range>: New typedef.
13147 <objfiles>: New method.
13148 <objfiles_head>: Rename from objfiles.
13149 (object_files): Update.
13150 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13151 * guile/scm-pretty-print.c
13152 (ppscm_find_pretty_printer_from_objfiles): Update.
13153 * guile/scm-objfile.c (gdbscm_objfiles): Update.
13154 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13156 * python/py-progspace.c (pspy_get_objfiles): Update.
13157 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13159 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13160 (objfpy_lookup_objfile_by_build_id): Update.
13161 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13162 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13164 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13165 (expand_symtab_containing_pc, lookup_objfile_from_block)
13166 (lookup_static_symbol, basic_lookup_transparent_type)
13167 (find_pc_sect_compunit_symtab, find_symbol_at_address)
13168 (find_line_symtab, info_sources_command)
13169 (default_collect_symbol_completion_matches_break_on)
13170 (make_source_files_completion_list, find_main_name): Update.
13171 * symmisc.c (print_symbol_bcache_statistics)
13172 (print_objfile_statistics, maintenance_print_symbols)
13173 (maintenance_print_msymbols, maintenance_print_objfiles)
13174 (maintenance_info_symtabs, maintenance_check_symtabs)
13175 (maintenance_expand_symtabs, maintenance_info_line_tables):
13177 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13178 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13179 (map_overlay_command, unmap_overlay_command)
13180 (simple_overlay_update, expand_symtabs_matching)
13181 (map_symbol_filenames): Update.
13182 * symfile-debug.c (set_debug_symfile): Update.
13183 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13185 * source.c (select_source_symtab, forget_cached_source_info):
13187 * solib.c (solib_read_symbols): Update.
13188 * solib-spu.c (append_ocl_sos): Update.
13189 * psymtab.c (maintenance_print_psymbols)
13190 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13191 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13192 * printcmd.c (info_symbol_command): Update.
13193 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13195 * objfiles.h (class all_objfiles): Remove.
13196 * objfiles.c (have_partial_symbols, have_full_symbols)
13197 (have_minimal_symbols, qsort_cmp, update_section_map)
13198 (shared_objfile_contains_address_p)
13199 (default_iterate_over_objfiles_in_search_order): Update.
13200 * objc-lang.c (info_selectors_command, info_classes_command)
13201 (find_methods): Update.
13202 * minsyms.c (find_solib_trampoline_target): Update.
13203 * maint.c (maintenance_info_sections)
13204 (maintenance_translate_address, count_symtabs_and_blocks):
13206 * main.c (captured_main_1): Update.
13207 * linux-thread-db.c (try_thread_db_load_from_pdir)
13208 (has_libpthread): Update.
13209 * linespec.c (iterate_over_all_matching_symtabs)
13210 (search_minsyms_for_name): Update.
13211 * jit.c (jit_find_objf_with_entry_addr): Update.
13212 * hppa-tdep.c (find_unwind_entry)
13213 (hppa_lookup_stub_minimal_symbol): Update.
13214 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13216 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13217 (elf_gnu_ifunc_resolve_by_got): Update.
13218 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13219 * dwarf-index-write.c (save_gdb_index_command): Update.
13220 * cp-support.c (add_symbol_overload_list_qualified): Update.
13221 * breakpoint.c (create_overlay_event_breakpoint)
13222 (create_longjmp_master_breakpoint)
13223 (create_std_terminate_master_breakpoint)
13224 (create_exception_master_breakpoint): Update.
13225 * blockframe.c (find_pc_partial_function): Update.
13226 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13227 (ada_collect_symbol_completion_matches)
13228 (ada_add_global_exceptions): Update.
13230 2019-01-17 Tom Tromey <tom@tromey.com>
13232 * solib-target.c (lm_info_target_p): Remove typedef. Don't
13234 (solib_target_parse_libraries): Change return type.
13235 (library_list_start_segment, library_list_start_section)
13236 (library_list_end_library, library_list_start_library); Update.
13237 (solib_target_free_library_list): Remove.
13238 (solib_target_parse_libraries): Remove cleanup. Change return
13240 (solib_target_current_sos): Update.
13242 2019-01-17 Tom Tromey <tromey@bapiya>
13244 * valprint.c: Replace "the the" with "the".
13245 * symtab.c: Replace "the the" with "the".
13246 * solib.c: Replace "the the" with "the".
13247 * solib-dsbt.c: Replace "the the" with "the".
13248 * linespec.c: Replace "the the" with "the".
13249 * dwarf2loc.h: Replace "the the" with "the".
13250 * amd64-windows-tdep.c: Replace "the the" with "the".
13251 * aarch64-tdep.c: Replace "the the" with "the".
13253 2019-01-16 Keith Seitz <keiths@redhat.com>
13256 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13257 <builder>: Rename to ..
13258 <m_builder>: ... this and make private.
13259 (dwarf2_cu::get_builder): New method. Change all users of
13260 `builder' to use this method.
13261 (dwarf2_start_symtab): Move to ...
13262 (dwarf2_cu::start_symtab): ... here. Update all callers
13263 (setup_type_unit_groups): Move to ...
13264 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
13266 (dwarf2_cu::reset_builder): New method.
13267 (process_full_compunit, process_full_type_unit): Use
13268 dwarf2_cu::reset_builder.
13269 (follow_die_offset): Record the ancestor CU if it is different
13270 from the followed DIE's CU.
13271 (follow_die_sig_1): Likewise.
13273 2019-01-15 Tom Tromey <tom@tromey.com>
13275 * remote.c (class remote_state) <buf>: Now a char_vector.
13276 <buf_size>: Remove.
13277 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
13279 (remote_target::getpkt_or_notif_sane_1)
13280 (remote_target::getpkt_sane)
13281 (remote_target::getpkt_or_notif_sane): Likewise.
13282 (class remote_target) <putpkt>: New overload.
13283 (remote_target::read_frame): Change type of "buf_p". Remove
13284 sizeof_p parameter.
13285 (packet_ok): New overload.
13286 (packet_check_result): New overload.
13289 2019-01-14 Tom Tromey <tom@tromey.com>
13291 * remote-notif.c (handle_notification, remote_notif_ack)
13292 (remote_notif_parse): Make "buf" const.
13293 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13295 (remote_notif_parse, remote_notif_ack, handle_notification):
13297 * remote.c (remote_notif_stop_parse): Make "buf" const.
13298 (remote_target::remote_parse_stop_reply): Make "buf" const.
13299 (remote_notif_stop_ack): Make "buf" const.
13301 2019-01-14 Tom Tromey <tom@tromey.com>
13303 * remote.c (remote_console_output): Make parameter const.
13305 2019-01-14 Tom Tromey <tom@tromey.com>
13307 * target-debug.h (target_debug_print_signals): Constify.
13308 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13309 * procfs.c (procfs_target::pass_signals): Update.
13310 * linux-nat.c (linux_nat_target::pass_signals): Update.
13311 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13312 * target-delegates.c: Rebuild.
13313 * remote.c (remote_target::program_signals): Update.
13314 (remote_target::pass_signals): Update.
13315 * target.c (target_pass_signals): Constify argument.
13316 (target_program_signals): Likewise.
13317 * target.h (struct target_ops) <pass_signals, program_signals>:
13319 (target_pass_signals, target_program_signals): Constify argument.
13321 2019-01-14 Tom Tromey <tom@tromey.com>
13324 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13326 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
13328 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13330 * rs6000-tdep.c: Include reggroups.h.
13331 (IS_V_ALIAS_PSEUDOREG): Define.
13332 (rs6000_register_name): Return names for the "vX" aliases.
13333 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13334 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
13335 aliases. Call default_register_reggroup_p for all other
13337 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13339 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13340 Handle "vX" aliases.
13341 (v_alias_pseudo_register_collect): New function.
13342 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13343 (rs6000_gdbarch_init): Initialize "vX" aliases as
13344 pseudo-registers. Restore registration of
13345 rs6000_pseudo_register_reggroup_p with
13346 set_tdesc_pseudo_register_reggroup_p.
13348 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
13350 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13351 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13352 set_gdbarch_num_pseudo_regs.
13354 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13356 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13357 Remove arg prefixname, add do_set and do_show.
13358 Add member functions set_list and show_list.
13359 * cli/cli-style.c (class cli_style_option): Update accordingly.
13360 (style_set_list): Move to file scope.
13361 (style_show_list): Likewise.
13362 (set_style): Call help_list.
13363 (show_style): Call cmd_show_list.
13364 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13365 Update to use the new macro.
13367 2019-10-12 Joel Brobecker <brobecker@adacore.com>
13369 * ada-lang.c (_initialize_ada_language): Expand the help text
13370 for the "catch exception" command.
13372 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13374 * symtab.c (matching_obj_sections): Initialize obj,
13375 declare it closer to its usage.
13377 2019-01-10 Tom Tromey <tom@tromey.com>
13379 * thread-iter.h (inf_threads_iterator): Use next_iterator.
13380 (basic_inf_threads_range): Remove.
13381 (inf_threads_range, inf_non_exited_threads_range)
13382 (safe_inf_threads_range): Use next_adapter.
13384 2019-01-10 Keith Seitz <keiths@redhat.com>
13388 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13389 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13391 2019-01-10 Keith Seitz <keiths@redhat.com>
13395 * dictionary.c (pending_to_vector): Remove.
13396 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13397 Remove _1 suffix, replacing functions of the same name. Update
13399 (dict_create_hashed, dict_create_hashed_expandable)
13400 (dict_create_linear, dict_create_linear_expandable, dict_free)
13401 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13402 Make functions static.
13404 2019-01-10 Keith Seitz <keiths@redhat.com>
13408 * dictionary.h (struct dictionary): Replace declaration with
13410 (dict_create_hashed, dict_create_hashed_expandable)
13411 (dict_create_linear, dict_create_linear_expandable)
13412 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13413 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13414 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13415 taking multidictionary argument.
13416 [ALL_DICT_SYMBOLS]: Update for multidictionary.
13417 * block.h (struct block) <dict>: Change to multidictionary
13418 and rename `multidict'.
13419 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13420 symmisc.c: Update all dictionary references to multidictionary.
13422 2019-01-10 Keith Seitz <keiths@redhat.com>
13426 * dictionary.c: Include unordered_map.
13427 (pending_to_vector): New function.
13428 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13429 Rewrite the non-"_1" functions to take vector instead
13431 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13432 "new" _1 versions of the same name.
13433 (multidictionary): Define.
13434 (std::hash<enum language): New definition.
13435 (collate_pending_symbols_by_language, mdict_create_hashed)
13436 (mdict_create_hashed_expandable, mdict_create_linear)
13437 (mdict_create_linear_expandable, mdict_free)
13438 (find_language_dictionary, create_new_language_dictionary)
13439 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13440 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13441 (mdict_size, mdict_empty): New functions.
13442 * dictionary.h (mdict_iterator): Define.
13444 2019-01-10 Pedro Alves <palves@redhat.com>
13446 * breakpoint.c (read_uploaded_action)
13447 (create_tracepoint_from_upload): Adjust to use
13448 gdb::unique_xmalloc_ptr.
13449 * ctf.c (ctf_write_uploaded_tp):
13450 (SET_ARRAY_FIELD): Use emplace_back.
13451 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13452 * tracefile-tfile.c (tfile_write_uploaded_tp):
13453 * tracepoint.c (parse_tracepoint_definition): Adjust to use
13454 gdb::unique_xmalloc_ptr.
13455 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13456 at_string, cond_string, cmd_strings>: Replace char pointers
13457 with gdb::unique_xmalloc_ptr.
13459 2019-01-10 Pedro Alves <palves@redhat.com>
13461 * solib-target.c (library_list_start_library): Don't xstrdup name.
13463 2019-01-10 Pedro Alves <palves@redhat.com>
13465 * mdebugread.c (parse_partial_symbols): Use
13466 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13468 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
13470 * linux-fork.c (scoped_switch_fork_info)
13471 <~scoped_switch_fork_info>: Fix incorrect variable name.
13473 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
13475 * linux-fork.c (scoped_switch_fork_info)
13476 <scoped_switch_fork_info>: Make explicit.
13477 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13479 2019-01-10 Tom Tromey <tom@tromey.com>
13481 * objfiles.h (objfile::reset_psymtabs): Update.
13482 * objfiles.c (objfile::objfile): Update.
13483 * psymtab.h (psymtab_storage::obstack): Update.
13484 (psymtab_storage::m_obstack): Use gdb::optional.
13485 (class psymtab_storage): Update comment. Remove objfile
13487 * psymtab.c (psymtab_storage::psymtab_storage): Update.
13489 2019-01-10 Tom Tromey <tom@tromey.com>
13491 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13492 <free_psymtabs>: Now private.
13493 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13494 (allocate_psymtab): Use new method.
13496 2019-01-10 Tom Tromey <tom@tromey.com>
13498 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13499 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13500 * mdebugread.c (parse_partial_symbols): Use
13501 allocate_dependencies.
13502 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13503 allocate_dependencies.
13504 (process_psymtab_comp_unit_reader)
13505 (build_type_psymtab_dependencies): Likewise.
13506 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13508 2019-01-10 Tom Tromey <tom@tromey.com>
13510 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13511 PSYMBOL_SET_LANGUAGE.
13512 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13514 2019-01-10 Tom Tromey <tom@tromey.com>
13516 * psymtab.h (psymtab_storage::obstack): New method.
13517 <m_obstack>: Rename from obstack; now private.
13518 * psymtab.c (psymtab_storage): Update.
13519 * dwarf2read.c (create_addrmap_from_index)
13520 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13523 2019-01-10 Tom Tromey <tom@tromey.com>
13525 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13526 * objfiles.h (objfile::reset_psymtabs): New method.
13528 2019-01-10 Tom Tromey <tom@tromey.com>
13530 * symmisc.c (print_symbol_bcache_statistics): Update.
13531 (print_objfile_statistics): Update.
13532 * symfile.c (reread_symbols): Update.
13533 * psymtab.h (class psymtab_storage): New.
13534 * psymtab.c (psymtab_storage): New constructor.
13535 (~psymtab_storage): New destructor.
13536 (require_partial_symbols): Update.
13537 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13538 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13539 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13540 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13541 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13542 (start_psymtab_common, end_psymtab_common)
13543 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13544 (allocate_psymtab): Update.
13545 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13547 (dump_psymtab_addrmap, maintenance_print_psymbols)
13548 (maintenance_check_psymtabs): Update.
13549 (class objfile_psymtabs): Move to objfiles.h.
13550 * psympriv.h (discard_psymtab): Now inline.
13551 (psymtab_discarder::psymtab_discarder): Update.
13552 (psymtab_discarder::~psymtab_discarder): Update.
13553 (ALL_OBJFILE_PSYMTABS): Rewrite.
13554 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13555 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13557 <partial_symtabs>: New field.
13558 (class objfile_psymtabs): Move from psymtab.h. Update.
13559 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13561 (objfile::~objfile): Don't destroy psymbol_cache.
13562 * mdebugread.c (parse_partial_symbols): Update.
13563 * dwarf2read.c (create_addrmap_from_index)
13564 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13565 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13566 (add_partial_subprogram, dwarf2_ranges_read): Update.
13567 * dwarf-index-write.c (write_address_map)
13568 (write_one_signatured_type, recursively_write_psymbols)
13569 (class debug_names, class debug_names, write_psymtabs_to_index):
13572 2019-01-10 Tom Tromey <tom@tromey.com>
13574 * symtab.h (SYMBOL_SET_NAMES): Update.
13575 (symbol_set_names): Update.
13576 (MSYMBOL_SET_NAMES): Update.
13577 * symtab.c (symbol_set_names): Change argument to be an
13578 objfile_per_bfd_storage.
13579 * psymtab.c (add_psymbol_to_bcache): Update.
13580 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13582 2019-01-10 Tom Tromey <tom@tromey.com>
13584 * symtab.c (create_demangled_names_hash): Change argument to be an
13585 objfile_per_bfd_storage.
13586 (symbol_set_names): Update.
13588 2019-01-10 Tom Tromey <tom@tromey.com>
13590 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13592 * psymtab.c (init_psymbol_list): Do nothing if already called.
13593 * psympriv.h (init_psymbol_list): Add comment.
13594 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13596 * dbxread.c (dbx_symfile_read): Unconditionally call
13599 2019-01-10 Tom Tromey <tom@tromey.com>
13601 * xcoffread.c (scan_xcoff_symtab): Update.
13602 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13604 * mdebugread.c (parse_partial_symbols)
13605 (handle_psymbol_enumerators): Update.
13606 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13607 * dbxread.c (read_dbx_symtab): Update.
13608 * psympriv.h (psymbol_placement): New enum.
13609 (add_psymbol_to_list): Update.
13611 2019-01-10 Tom Tromey <tom@tromey.com>
13613 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13614 static_psymbols parameters.
13615 (scan_xcoff_symtab): Update.
13616 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13617 static_psymbols parameters.
13618 * psympriv.h (start_psymtab_common): Update.
13619 * mdebugread.c (parse_partial_symbols): Update.
13620 * dwarf2read.c (create_partial_symtab): Update.
13621 * dbxread.c (read_dbx_symtab): Update.
13622 (start_psymtab): Remove global_psymbols and static_psymbols
13625 2019-01-10 Tom Tromey <tom@tromey.com>
13627 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13628 * psymtab.c (allocate_psymtab): Add comment.
13629 * psympriv.h (allocate_psymtab): Add comment.
13630 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13632 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13634 2019-01-10 Tom Tromey <tom@tromey.com>
13636 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13638 * mipsread.c: Include mdebugread.h.
13639 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13641 * elfread.c: Include mdebugread.h.
13643 2019-01-09 Tom Tromey <tom@tromey.com>
13645 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13646 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13647 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13648 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13649 (psym_lookup_symbol, psym_find_last_source_symtab)
13650 (psym_forget_cached_source_info, psym_print_stats)
13651 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13652 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13653 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13654 (psym_find_compunit_symtab_by_address)
13655 (maintenance_print_psymbols, maintenance_info_psymtabs)
13656 (maintenance_check_psymtabs): Use ranged for.
13657 * psymtab.h (class objfile_psymtabs): New.
13658 (require_partial_symbols): Return objfile_psymtabs.
13659 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13661 2019-01-09 Tom Tromey <tom@tromey.com>
13663 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13664 (find_pc_mapped_section, list_overlays_command)
13665 (map_overlay_command, unmap_overlay_command)
13666 (simple_overlay_update): Use all_objfiles.
13667 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13668 * printcmd.c (info_symbol_command): Use all_objfiles.
13669 * objfiles.h (ALL_OBJSECTIONS): Remove.
13670 * maint.c (maintenance_translate_address): Use all_objfiles.
13671 * gcore.c (gcore_create_callback): Use all_objfiles.
13672 (objfile_find_memory_regions): Likewise.
13674 2019-01-09 Tom Tromey <tom@tromey.com>
13676 * symtab.c (find_line_symtab, info_sources_command)
13677 (make_source_files_completion_list): Use objfile_compunits.
13678 * source.c (select_source_symtab): Use objfile_compunits.
13679 * objfiles.h (struct objfile): Update comment.
13680 (ALL_OBJFILES): Remove.
13681 (ALL_FILETABS): Remove.
13682 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13685 2019-01-09 Tom Tromey <tom@tromey.com>
13687 * symmisc.c (print_objfile_statistics, dump_objfile)
13688 (maintenance_print_symbols): Use compunit_filetabs.
13689 * source.c (forget_cached_source_info_for_objfile): Use
13691 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13692 (ALL_FILETABS): Use compunit_filetabs.
13693 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13694 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13696 2019-01-09 Tom Tromey <tom@tromey.com>
13698 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13699 (compunit_filetabs): New.
13700 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13702 (info_sources_command, make_source_files_completion_list): Remove
13704 * symmisc.c (print_objfile_statistics, dump_objfile)
13705 (maintenance_print_symbols): Remove declaration.
13706 (maintenance_info_symtabs): Use compunit_filetabs.
13707 (maintenance_info_line_tables): Likewise.
13708 * source.c (select_source_symtab): Change local variable name.
13709 (forget_cached_source_info_for_objfile): Remove declaration.
13710 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13711 * objfiles.c (objfile_relocate1): Remove declaration.
13712 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13714 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13715 * coffread.c (coff_symtab_read): Remove declaration.
13716 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13719 2019-01-09 Tom Tromey <tom@tromey.com>
13721 * symtab.c (lookup_objfile_from_block)
13722 (find_pc_sect_compunit_symtab, search_symbols)
13723 (default_collect_symbol_completion_matches_break_on): Use
13725 * objfiles.h (ALL_COMPUNITS): Remove.
13726 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13727 * cp-support.c (add_symbol_overload_list_qualified): Use
13729 * ada-lang.c (ada_collect_symbol_completion_matches)
13730 (ada_add_global_exceptions): Use objfile_compunits.
13732 2019-01-09 Tom Tromey <tom@tromey.com>
13734 * source.c (select_source_symtab)
13735 (forget_cached_source_info_for_objfile): Remove declaration.
13736 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13738 * maint.c (count_symtabs_and_blocks): Remove declaration.
13739 * cp-support.c (add_symbol_overload_list_qualified): Remove
13741 * coffread.c (coff_symtab_read): Remove declaration.
13742 * symtab.c (lookup_symbol_in_objfile_symtabs)
13743 (basic_lookup_transparent_type_1): Use objfile_compunits.
13744 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13745 (info_sources_command, search_symbols)
13746 (default_collect_symbol_completion_matches_break_on)
13747 (make_source_files_completion_list): Remove declaration.
13748 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13749 (ada_collect_symbol_completion_matches)
13750 (ada_add_global_exceptions): Remove declaration.
13751 * linespec.c (iterate_over_all_matching_symtabs): Use
13753 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13754 (class objfile_compunits): New.
13755 (ALL_COMPUNITS): Use objfile_compunits.
13756 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13757 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13759 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13761 2019-01-09 Tom Tromey <tom@tromey.com>
13763 * symtab.c (search_symbols)
13764 (default_collect_symbol_completion_matches_break_on): Use
13766 * ada-lang.c (ada_lookup_simple_minsym)
13767 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13768 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13769 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13771 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13772 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13773 * objc-lang.c (find_methods): Use objfile_msymbols.
13774 (info_selectors_command, info_classes_command): Likewise.
13775 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13776 * objfiles.h (class objfile_msymbols): New.
13777 (ALL_OBJFILE_MSYMBOLS): Remove.
13778 (ALL_MSYMBOLS): Remove.
13780 2019-01-09 Tom Tromey <tom@tromey.com>
13782 * common/next-iterator.h (next_adapter): Add Iterator template
13784 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13785 (class all_objfiles_safe): New.
13786 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13787 * objfiles.c (put_objfile_before): Update comment.
13788 (add_separate_debug_objfile): Likewise.
13789 (free_all_objfiles): Use all_objfiles_safe.
13790 (objfile_purge_solibs): Likewise.
13792 2019-01-09 Tom Tromey <tom@tromey.com>
13794 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13795 (expand_symtab_containing_pc, lookup_static_symbol)
13796 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13797 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13799 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13800 * breakpoint.c (create_overlay_event_breakpoint)
13801 (create_longjmp_master_breakpoint)
13802 (create_std_terminate_master_breakpoint)
13803 (create_exception_master_breakpoint): Use all_objfiles.
13804 * linux-thread-db.c (try_thread_db_load_from_pdir)
13805 (has_libpthread): Use all_objfiles.
13806 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13807 * linespec.c (iterate_over_all_matching_symtabs)
13808 (search_minsyms_for_name): Use all_objfiles.
13809 * maint.c (maintenance_info_sections): Use all_objfiles.
13810 * main.c (captured_main_1): Use all_objfiles.
13811 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13812 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13813 * guile/scm-pretty-print.c
13814 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13815 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13816 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13817 (maintenance_print_msymbols): Use all_objfiles.
13818 * source.c (select_source_symtab): Use all_objfiles.
13819 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13820 * symfile.c (remove_symbol_file_command)
13821 (expand_symtabs_matching, map_symbol_filenames): Use
13823 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13825 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13826 * objc-lang.c (find_methods): Use all_objfiles.
13827 * objfiles.c (have_partial_symbols, have_full_symbols)
13828 (have_minimal_symbols, qsort_cmp)
13829 (default_iterate_over_objfiles_in_search_order): Use
13831 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13832 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13833 (maintenance_check_psymtabs): Use all_objfiles.
13834 (ALL_PSYMTABS): Remove.
13835 * compile/compile-object-run.c (do_module_cleanup): Use
13837 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13838 * cp-support.c (add_symbol_overload_list_qualified): Use
13840 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13842 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13843 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13845 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13846 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13847 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13849 * solib.c (solib_read_symbols): Use all_objfiles
13851 2019-01-09 Tom Tromey <tom@tromey.com>
13853 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13854 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13856 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13857 * symmisc.c (print_symbol_bcache_statistics)
13858 (print_objfile_statistics, maintenance_print_objfiles)
13859 (maintenance_info_symtabs, maintenance_check_symtabs)
13860 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13862 * source.c (forget_cached_source_info): Use all_objfiles.
13863 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13864 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13865 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13866 * objfiles.c (update_section_map): Use all_objfiles.
13867 (shared_objfile_contains_address_p): Likewise.
13868 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13869 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13871 2019-01-09 Tom Tromey <tom@tromey.com>
13873 * common/next-iterator.h: New file.
13874 * objfiles.h (class all_objfiles): New.
13875 (struct objfile_iterator): New.
13877 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13879 * NEWS: Move the description of the changed "frame", "select-frame",
13880 and "info frame" commands to the Changed commands section.
13882 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13884 * gdbtypes.c (check_stub_method_group): Remove handling of old
13886 * linespec.c (find_methods): Likewise.
13887 * stabsread.c (read_member_functions): Likewise.
13888 * valops.c (search_struct_method): Likewise.
13889 (value_struct_elt_for_reference): Likewise.
13890 * NEWS: Mention this change.
13892 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13894 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13895 print_source_lines.
13896 * source.c (print_source_lines_base): Update line number check.
13897 (print_source_lines): New function.
13898 (source_lines_range::source_lines_range): New function.
13899 * source.h (class source_lines_range): New class.
13900 (print_source_lines): New declaration.
13902 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13904 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13906 2019-01-08 Tom Tromey <tom@tromey.com>
13907 Simon Marchi <simon.marchi@ericsson.com>
13910 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13911 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13912 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13913 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13914 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13915 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13917 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13919 * source.c (select_source_symtab): Move header comment to
13920 declaration in source.h.
13921 (forget_cached_source_info_for_objfile): Likewise.
13922 (forget_cached_source_info): Likewise.
13923 (identify_source_line): Likewise.
13924 * source.h (identify_source_line): Move declaration from symtab.h
13925 and add comment from source.c
13926 (print_source_lines): Likewise.
13927 (forget_cached_source_info_for_objfile): Likewise.
13928 (forget_cached_source_info): Likewise.
13929 (select_source_symtab): Likewise.
13930 (enum print_source_lines_flag): Move definition from symtab.h.
13931 * symtab.h (identify_source_line): Move declaration to source.h.
13932 (print_source_lines): Likewise.
13933 (forget_cached_source_info_for_objfile): Likewise.
13934 (forget_cached_source_info): Likewise.
13935 (select_source_symtab): Likewise.
13936 (enum print_source_lines_flag): Move definition to source.h.
13937 * tui/tui-hooks.c: Add 'source.h' include.
13939 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13941 * source.c (print_source_lines_base): Handle requests to print
13942 reverse line number sequences, and guard against empty lines
13945 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13947 * source.c (print_source_lines_base): Fix skip of '\r' if next
13950 2019-01-06 Tom Tromey <tom@tromey.com>
13952 * c-exp.y (struct c_parse_state) <macro_original_text,
13953 expansion_obstack>: New member.
13954 (macro_original_text, expansion_obstack): Remove globals.
13955 (scan_macro_expansion, scanning_macro_expansion)
13956 (finished_macro_expansion): Update.
13957 (scan_macro_cleanup): Remove.
13958 (yylex, c_parse): Update.
13960 2019-01-06 Tom Tromey <tom@tromey.com>
13962 * c-exp.y (struct c_parse_state) <strings>: New member.
13963 (operator_stoken): Update.
13965 2019-01-06 Tom Tromey <tom@tromey.com>
13967 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13968 (union type_stack_elt) <typelist_val>: Now a pointer to
13970 (type_stack_cleanup): Don't declare.
13971 (push_typelist): Update.
13972 * parse.c (pop_typelist): Return a std::vector.
13973 (push_typelist): Take a std::vector.
13974 (follow_types): Update. Do not free args.
13975 (type_stack_cleanup): Remove.
13976 * c-exp.y (struct c_parse_state): New.
13977 (cpstate): New global.
13978 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13979 (nonempty_typelist): Update.
13980 (func_mod): Create a new vector.
13981 (c_parse): Create a c_parse_state.
13982 (check_parameter_typelist): Do not delete params.
13983 (function_method): Update. Do not delete type_list.
13985 2019-01-06 Tom Tromey <tom@tromey.com>
13988 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13990 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13991 (print_return_value): Likewise.
13993 2019-01-05 Tom Tromey <tom@tromey.com>
13995 * contrib/cleanup_check.py: Remove.
13996 * contrib/gcc-with-excheck: Remove.
13997 * contrib/exsummary.py: Remove.
13998 * contrib/excheck.py: Remove.
14000 2019-01-05 Joel Brobecker <brobecker@adacore.com>
14002 * thread.c (delete_thread_1): Add gdb_assert that THR is not
14003 NULL. Initialize tpprev to NULL instead of assigning it
14004 to NULL on the next statement.
14005 * windows-nat.c (windows_delete_thread): Remove check for
14006 main_thread_id before printing thread exit notifications.
14007 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14008 Remove thread ID check against main_thread_id.
14009 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14010 windows_delete_thread.
14011 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14013 2019-01-04 Tom Tromey <tom@tromey.com>
14015 * compile/compile.c (_initialize_compile): Use upper case for
14016 metasyntactic variables.
14017 * symmisc.c (_initialize_symmisc): Use upper case for
14018 metasyntactic variables.
14019 * psymtab.c (_initialize_psymtab): Use upper case for
14020 metasyntactic variables.
14021 * demangle.c (demangle_command): Use upper case for metasyntactic
14023 (_initialize_demangler): Likewise.
14024 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14027 2019-01-03 Tom Tromey <tom@tromey.com>
14029 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14031 2019-01-03 Tom Tromey <tom@tromey.com>
14033 * python/py-symtab.c (salpy_str): Update.
14034 (struct salpy_sal_object) <symtab>: Now a PyObject.
14035 (salpy_dealloc): Update.
14036 (del_objfile_sal): Use gdbpy_ref.
14038 2019-01-03 Tom Tromey <tom@tromey.com>
14040 * python/py-type.c (convert_field): Use new_reference. Return
14042 (make_fielditem): Return gdbpy_ref.
14043 (typy_fields): Update.
14044 (typy_getitem): Update.
14045 (field_name): Return gdbpy_ref. Use new_reference.
14046 (typy_iterator_iternext): Update.
14048 2019-01-03 Tom Tromey <tom@tromey.com>
14050 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14052 2019-01-03 Tom Tromey <tom@tromey.com>
14054 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14055 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14056 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14057 (pspy_set_frame_filters, pspy_set_frame_unwinders)
14058 (pspy_set_type_printers): Likewise.
14059 * python/py-function.c (fnpy_init): Use gdbpy_ref.
14060 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14061 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14062 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14063 (objfpy_set_type_printers): Likewise.
14065 2019-01-03 Tom Tromey <tom@tromey.com>
14067 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14068 (gdbpy_print_stack): Use gdbpy_err_fetch.
14069 * python/python-internal.h (class gdbpy_err_fetch): New class.
14070 (class gdbpy_enter) <m_error_type, m_error_value,
14071 m_error_traceback>: Remove.
14072 <m_error>: New member.
14073 (gdbpy_exception_to_string): Don't declare.
14074 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14075 * python/py-value.c (convert_value_from_python): Use
14077 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14078 gdbpy_exception_to_string.
14079 (gdbpy_handle_exception): Use gdbpy_err_fetch.
14080 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14083 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14085 * linux-nat.c (delete_lwp_cleanup): Delete.
14086 (struct lwp_deleter): New struct.
14087 (lwp_info_up): New typedef.
14088 (linux_nat_target::follow_fork): Delete cleanup, and make use of
14091 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14093 * linux-fork.c (class scoped_switch_fork_info): New class.
14094 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14096 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14098 * valops.c (find_overload_match): Remove use of null_cleanup, and
14099 calls to do_cleanups.
14101 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14103 * compile/compile-cplus-types.c
14104 (compile_cplus_instance::decl_name): Handle changes to
14106 * cp-support.c (cp_func_name): Update header comment, update
14108 * cp-support.h (cp_func_name): Update return type in declaration.
14109 * valops.c (find_overload_match): Move temp_func local to top
14110 level of function and change its type. Use temp_func to hold and
14111 delete temporary string obtained from cp_func_name.
14113 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14115 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14116 gdb::char_vector, remove cleanup, and update uses of `msg`.
14118 2019-01-03 Jim Wilson <jimw@sifive.com>
14120 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14122 2019-01-02 Tom Tromey <tom@tromey.com>
14124 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14125 (tdesc_parse_xml): Remove cleanups.
14126 * target-descriptions.h (make_cleanup_free_target_description):
14128 (target_desc_deleter): New struct.
14129 (target_desc_up): New typedef.
14130 * target-descriptions.c (target_desc_deleter::operator()): Rename
14131 from free_target_description.
14132 (make_cleanup_free_target_description): Remove.
14134 2019-01-02 Tom Tromey <tom@tromey.com>
14136 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
14137 constructor, destructor.
14138 (linespec_parser): Remove typedef.
14139 (~linespec_parser): Rename from linespec_parser_delete.
14140 (linespec_lex_to_end, linespec_complete_label)
14141 (linespec_complete): Update.
14142 (decode_line_full): Remove cleanups.
14143 (decode_line_1): Update.
14145 2019-01-02 Tom Tromey <tom@tromey.com>
14147 * python/python-internal.h (inferior_to_inferior_object): Change
14149 * python/py-exitedevent.c (create_exited_event_object): Update.
14150 * python/py-inferior.c (inferior_to_inferior_object): Return
14152 (python_new_inferior, python_inferior_deleted)
14153 (thread_to_thread_object, delete_thread_object)
14154 (build_inferior_list, gdbpy_selected_inferior): Update.
14155 * python/py-infthread.c (create_thread_object): Update. Also fail
14156 if inferior_to_inferior_object fails.
14158 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
14160 * inferior.h (class inferior) <displaced_step_state>: New field.
14161 * infrun.h (struct displaced_step_state): Move here from
14162 infrun.c. Initialize fields, add constructor.
14163 <inf>: Remove field.
14164 <reset>: New method.
14165 * infrun.c (struct displaced_step_inferior_state): Move to
14167 (displaced_step_inferior_states): Remove.
14168 (get_displaced_stepping_state): Adust.
14169 (displaced_step_in_progress_any_inferior): Adjust.
14170 (displaced_step_in_progress_thread): Adjust.
14171 (displaced_step_in_progress): Adjust.
14172 (add_displaced_stepping_state): Remove.
14173 (get_displaced_step_closure_by_addr): Adjust.
14174 (remove_displaced_stepping_state): Remove.
14175 (infrun_inferior_exit): Call displaced_step_state.reset.
14176 (use_displaced_stepping): Don't check for NULL.
14177 (displaced_step_prepare_throw): Call
14178 get_displaced_stepping_state.
14179 (displaced_step_fixup): Don't check for NULL.
14180 (prepare_for_detach): Don't check for NULL.
14182 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14184 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14185 in case of call that did not complete.
14187 2019-01-02 Andrey Utkin <autkin@undo.io>
14189 * symfile.c (find_separate_debug_file): Fix search of debug files for
14192 2019-01-02 Tom Tromey <tom@tromey.com>
14194 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14196 * python/py-frame.c (frapy_older): Remove cast.
14197 (frapy_newer): Likewise.
14198 * python/py-breakpoint.c (local_setattro): Remove cast.
14199 * python/py-arch.c (archpy_name): Remove local variable.
14200 * python/py-type.c (gdbpy_lookup_type): Remove cast.
14202 2019-01-02 Joel Brobecker <brobecker@adacore.com>
14204 * unittests/basic_string_view/element_access/char/empty.cc:
14205 Fix year range in copyright header.
14207 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
14209 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14211 <operator==>: Update with for removed field.
14213 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14214 <isa_features>: ...this.
14215 <abi_features>: New field.
14216 (riscv_isa_flen): Update comment.
14217 (riscv_abi_xlen): New declaration.
14218 (riscv_abi_flen): New declaration.
14219 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14221 (riscv_abi_xlen): New function.
14222 (riscv_isa_flen): Update to get answer from isa_features.
14223 (riscv_abi_flen): New function.
14224 (riscv_has_fp_abi): Update to get answer from abi_features.
14225 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14227 (riscv_call_info) <xlen, flen>: Update comment.
14228 (riscv_call_arg_struct): Remove invalid assertions
14229 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14231 (riscv_gdbarch_init): Gather isa features and abi features
14232 separately, ensure both match on the gdbarch when reusing an old
14233 gdbarch. Relax an error check to allow 32-bit abi float to run on
14234 a target with 64-bit float hardware.
14236 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14238 * source.c (search_command_helper): Stop reverse search
14239 when line 1 has been searched.
14241 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14243 * record-full.c (record_full_base_target::close): Rewrite
14244 record_full_core_buf_list free logic.
14246 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14248 * break-catch-syscall.c (print_one_catch_syscall): xfree
14251 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14253 * top.c (print_gdb_version): Update Copyright year in version
14256 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14258 Update copyright year range in all GDB files.
14260 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
14262 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14264 For older changes see ChangeLog-2018.
14270 version-control: never