gdb/ChangeLog

   1 2019-12-27  Tom Tromey  <tom@tromey.com>
   2
   3         * cli/cli-cmds.c (print_disassembly): Reorder "if".
   4
   5 2019-12-27  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui.c (tui_active): Now bool.
   8         (tui_finish_init): Likewise.
   9         (tui_enable): Update.
  10         (tui_disable): Update.
  11         (tui_is_window_visible): Update.
  12         * tui/tui.h (tui_active): Now bool.
  13
  14 2019-12-27  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  17         * tui/tui-regs.c (tui_data_window::display_registers_from):
  18         Update.
  19         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  20         * tui/tui-data.h (struct tui_gen_win_info) <viewport_height>:
  21         Remove.
  22         * tui/tui-command.c (tui_cmd_window::resize): Update.
  23
  24 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * ada-lang.c (ada_decode_symbol): Update.
  27         * buildsym.c (add_symbol_to_list): Update.
  28         * coffread.c (process_coff_symbol): Update.
  29         * ctfread.c (ctf_add_enum_member_cb): Update.
  30         (new_symbol): Update.
  31         (ctf_add_var_cb): Update.
  32         * dwarf2read.c (fixup_go_packaging): Update.
  33         (dwarf2_compute_name): Update.
  34         (new_symbol): Update.
  35         * jit.c (finalize_symtab): Update.
  36         * language.c (language_alloc_type_symbol): Update.
  37         * mdebugread.c (new_symbol): Update.
  38         * minsyms.c (minimal_symbol_reader::record_full): Update.
  39         (minimal_symbol_reader::install): Update.
  40         * psymtab.c (print_partial_symbols): Update.
  41         (psymbol_hash): Update.
  42         (psymbol_compare): Update.
  43         (add_psymbol_to_bcache): Update.
  44         (maintenance_check_psymtabs): Update.
  45         * stabsread.c (define_symbol): Update.
  46         * symtab.c (symbol_set_names): Rename to...
  47         (general_symbol_info::compute_and_set_names): ...this.
  48         (general_symbol_info::natural_name): Update.
  49         (general_symbol_info::search_name): Update.
  50         (fixup_section): Update.
  51         * symtab.h (struct general_symbol_info) <name>: Rename to...
  52         <m_name>: ...this.
  53         <compute_and_set_names>: Rename from...
  54         (symbol_set_names): ...this.
  55         (SYMBOL_SET_NAMES): Remove.
  56         (struct symbol) <ctor>: Update.
  57
  58 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
  59
  60         * NEWS: Mention that multithreaded symbol loading is now on by
  61         default.
  62
  63 2019-12-26  Ruslan Kabatsayev  <b7.10110111@gmail.com>
  64
  65         * dwarf2read.c (is_valid_DW_AT_defaulted)
  66         (is_valid_DW_AT_calling_convention_for_type)
  67         (is_valid_DW_AT_calling_convention_for_subroutine): Fix printing
  68         ULONGEST variables on x86-32.
  69
  70 2019-12-21  George Barrett  <bob@bob131.so>
  71
  72         * solib-svr4.c (svr4_handle_solib_event): Add fallback link
  73         namespace test for when the debug struct isn't available.
  74
  75 2019-12-21  Eli Zaretskii  <eliz@gnu.org>
  76
  77         * top.c (print_gdb_configuration): Print "--with-xxhash" or
  78         "--without-xxhash" according to HAVE_LIBXXHASH.
  79
  80 2019-12-20  Weimin Pan  <weimin.pan@oracle.com>
  81         * ctfread.c (ctf_file_key): Change type to objfile_key.
  82         (struct ctf_context): Remove typedef.
  83         (get_objfile_text_range): Use ANOFFSET to get text base.
  84
  85 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  86
  87         * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
  88         New function.
  89         (read_subroutine_type): Validate the parsed
  90         DW_AT_calling_convention value before assigning it to a
  91         subroutine's calling_convention attribute.
  92         * gdbtypes.h (struct func_type) <calling_convention>: Use
  93         an enum bitfield as its type, instead of plain unsigned.
  94
  95 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  96
  97         PR gdb/25054
  98         * infcall.c (call_function_by_hand_dummy): Update the argument-
  99         passing section for call-by-value parameters.
 100         (struct destructor_info): New struct.
 101         (call_destructors): New auxiliary function.
 102
 103 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 104
 105         * gnu-v3-abi.c (enum definition_style): New enum type.
 106         (get_def_style): New function.
 107         (is_user_provided_def): New function.
 108         (is_implicit_def): New function.
 109         (is_copy_or_move_constructor_type): New function.
 110         (is_copy_constructor_type): New function.
 111         (is_move_constructor_type): New function.
 112         (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
 113         for a given type.
 114
 115 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 116
 117         * language.h (struct language_pass_by_ref_info): New struct.
 118         (struct language_defn)<la_pass_by_reference>: Change the signature
 119         to return a language_pass_by_ref_info instead of an int.
 120         (language_pass_by_reference): Ditto.
 121         (default_pass_by_reference): Ditto.
 122         Adjust the users listed below.
 123         * arch-utils.c (default_return_in_first_hidden_param_p):
 124         Update.
 125         * cp-abi.c (cp_pass_by_reference): Update.
 126         * cp-abi.h (cp_pass_by_reference): Update declaration.
 127         (struct cp_abi_ops)<pass_by_reference>: Update.
 128         * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
 129         * infcall.c (call_function_by_hand_dummy): Update.
 130         * language.c (language_pass_by_reference): Update.
 131         (default_pass_by_reference): Update.
 132         * tic6x-tdep.c (tic6x_return_value): Update.
 133
 134 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 135
 136         * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
 137         and DW_AT_deleted attributes of a function.
 138         (read_structure_type): Read the DW_AT_calling_convention attribute
 139         of a type.
 140         (is_valid_DW_AT_defaulted): New function.
 141         (is_valid_DW_AT_calling_convention_for_type): New function.
 142         * gdbtypes.h: Include dwarf2.h.
 143         (struct fn_field)<defaulted>: New field to store the
 144         DW_AT_defaulted attribute.
 145         (struct fn_field)<is_deleted>: New field to store the
 146         DW_AT_deleted attribute.
 147         (struct cplus_struct_type)<calling_convention>: New field to store
 148         the DW_AT_calling_convention attribute.
 149         (TYPE_FN_FIELD_DEFAULTED): New macro.
 150         (TYPE_FN_FIELD_DELETED): New macro.
 151         (TYPE_CPLUS_CALLING_CONVENTION): New macro.
 152         * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
 153         to the .h file.
 154         (print_cplus_stuff): Likewise.
 155
 156 2019-12-20  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui.c (tui_show_source): Remove.
 159         * tui/tui.h (tui_show_source): Don't declare.
 160         * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
 161         tui_show_source.
 162
 163 2019-12-20  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-stack.h (tui_show_frame_info): Return bool.
 166         * tui/tui-stack.c (tui_show_frame_info): Return bool.
 167         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
 168         Update.
 169
 170 2019-12-20  Tom Tromey  <tom@tromey.com>
 171
 172         PR tui/18932:
 173         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
 174         Rename parameters.  Handle the not-from-stack-frame case.
 175         (from_stack, from_source_symtab): New globals.
 176         (tui_before_prompt, tui_normal_stop): Update.
 177         (tui_context_changed, tui_symtab_changed): New functions.
 178         (tui_attach_detach_observers): Attach new observers.
 179
 180 2019-12-20  Tom Tromey  <tom@tromey.com>
 181
 182         * source.c (struct current_source_location) <set, symtab, line>:
 183         New methods.
 184         <m_symtab, m_line>: Rename.  Now private.
 185         (get_current_source_symtab_and_line)
 186         (set_default_source_symtab_and_line)
 187         (set_current_source_symtab_and_line)
 188         (clear_current_source_symtab_and_line, select_source_symtab)
 189         (info_source_command, print_source_lines_base)
 190         (info_line_command, search_command_helper): Update.
 191         * observable.h (current_source_symtab_and_line_changed): Declare
 192         observable.
 193         * observable.c (current_source_symtab_and_line_changed): Define
 194         observable.
 195
 196 2019-12-20  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
 199         (tui_before_prompt, tui_normal_stop): Update.
 200
 201 2019-12-20  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-winsource.c
 204         (tui_source_window_base::update_source_window_as_is): Don't call
 205         set_current_source_symtab_and_line.
 206
 207 2019-12-20  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
 210         Take a symtab_and_line.
 211         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
 212         symtab_and_line.
 213         (tui_show_frame_info): Update.
 214
 215 2019-12-20  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-stack.c (tui_show_frame_info): Don't call
 218         update_exec_info.
 219
 220 2019-12-20  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui.c (tui_enable): Call tui_display_main.
 223
 224 2019-12-20  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
 227         get_current_source_symtab_and_line, and main_name.
 228
 229 2019-12-20  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui.c (tui_show_source): Update.
 232         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
 233         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
 234         a symtab_symbol_info, not a separate symtab and line.  Simplify.
 235
 236 2019-12-20  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
 239         Simplify.
 240
 241 2019-12-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.h (struct tui_source_window_base)
 244         <set_contents, update_source_window_as_is, update_source_window>:
 245         Take a sal, not a separate symtab and tui_line_or_address.
 246         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 247         (tui_source_window_base::update_source_window_as_is): Take a sal,
 248         not a separate symtab and tui_line_or_address.
 249         (tui_update_source_windows_with_addr)
 250         (tui_update_source_windows_with_line)
 251         (tui_source_window_base::rerender)
 252         (tui_source_window_base::refill): Update.
 253         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
 254         a sal, not a separate symtab and tui_line_or_address.
 255         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
 256         not a separate symtab and tui_line_or_address.
 257         (tui_source_window::maybe_update): Update.
 258         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
 259         a sal, not a separate symtab and tui_line_or_address.
 260         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
 261         not a separate symtab and tui_line_or_address.
 262         (tui_disasm_window::do_scroll_vertical)
 263         (tui_disasm_window::maybe_update): Update.
 264
 265 2019-12-20  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-winsource.c (tui_source_window_base::refill): Use
 268         start_line_or_addr.
 269         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
 270         start_line_or_addr.
 271         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 272         start_line_or_addr.
 273
 274 2019-12-20  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-winsource.h (struct tui_source_window_base)
 277         <set_contents>: Return bool.
 278         * tui/tui-winsource.c
 279         (tui_source_window_base::update_source_window_as_is): Update.
 280         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 281         Return bool.
 282         * tui/tui-source.c (tui_source_window::set_contents): Return
 283         bool.  Simplify.
 284         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 285         Return bool.
 286         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 287         bool.
 288
 289 2019-12-20  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 292         (tui_update_source_windows_with_line): Call update_source_window.
 293         * tui/tui-source.h (struct tui_source_window)
 294         <show_symtab_source>: Don't declare.
 295         * tui/tui-source.c (tui_source_window::show_symtab_source):
 296         Remove.
 297
 298 2019-12-20  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 301         update_source_window directly.
 302         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 303         * tui/tui-disasm.c (tui_show_disassem): Remove.
 304
 305 2019-12-20  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.c
 308         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 309         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 310
 311 2019-12-20  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-winsource.h (struct tui_source_window_base)
 314         <maybe_update>: Remove line_no and addr parameters.
 315         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 316         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 317         Update.
 318         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 319         line_no and addr parameters.
 320         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 321         Update.
 322         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 323         line_no and addr parameters.
 324
 325 2019-12-20  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 328         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 329
 330 2019-12-20  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 333         tui_show_disassem.
 334         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 335         declare.
 336         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 337
 338 2019-12-20  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui.h (tui_show_source): Remove parameters.
 341         * tui/tui.c (tui_show_source): Remove parameters.
 342         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 343
 344 2019-12-20  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui.c (tui_show_source): Update.
 347         * tui/tui-winsource.c (tui_display_main): Update.
 348         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 349         to symtab.
 350         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 351         to symtab.
 352         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 353
 354 2019-12-20  Tom Tromey  <tom@tromey.com>
 355
 356         PR tui/23619:
 357         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 358         (tui_redisplay_readline): Use rl_display_prompt.
 359         (tui_prep_terminal): Update.
 360
 361 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 362
 363         * configure: Regenerate.
 364         * configure.ac: Quote variable arguments of test.
 365         * gdbsupport/common.m4: Likewise.
 366
 367 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 368
 369         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 370         2 to pow ().
 371
 372 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 373
 374         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 375         log10 to double to fix Solaris 11 with gcc 5.5.
 376
 377 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 378
 379         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 380         "sun" to "saddr_un".
 381
 382 2019-12-19  Tom Tromey  <tromey@adacore.com>
 383
 384         * ui-out.h (enum class field_kind): Fix comment.
 385
 386 2019-12-11  Tom Tromey  <tromey@adacore.com>
 387
 388         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 389
 390 2019-12-18  Tom Tromey  <tromey@adacore.com>
 391
 392         PR build/25268:
 393         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 394         type on macOS.  Add comment.
 395
 396 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 397
 398         * c-lang.c (c_get_string, asm_language_defn): Remove space
 399         before tab.
 400
 401 2019-12-18  Tom Tromey  <tromey@adacore.com>
 402
 403         PR build/25250:
 404         * ui-out.c (ui_out::vmessage): Update.
 405         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 406         Rename.
 407         (string_field): Update.
 408         (signed_field): Update.
 409
 410 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 411
 412         * top.c (print_gdb_configuration): Adjust indentation.
 413
 414 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 415
 416         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 417
 418 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 419
 420         * tui/tui-layout.h (class tui_layout_base): Add virtual
 421         destructor.
 422
 423 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 424
 425         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 426         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 427         (process_event_stop_test): Keep stepping over skipped inline functions.
 428
 429 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 430
 431         * jit.c (struct gdb_block) <next>: Remove field.
 432         (struct gdb_symtab) <~gdb_symtab>: Remove.
 433         <blocks>: Change type to std::forward_list<gdb_block>.
 434         (compare_block): Remove.
 435         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 436         block at the beginning, don't mind about sorting.
 437         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 438         before using it.
 439
 440 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 441
 442         * jit.c (struct gdb_block): Add constructor, initialize
 443         real_block and next fields.
 444         <name>: Change type to gdb::unique_xmalloc_ptr.
 445         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 446         (jit_block_open_impl): Allocate gdb_block with new.
 447         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 448
 449 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 450
 451         * jit.c: Include forward_list.
 452         (struct gdb_symtab) <next>: Remove field.
 453         (struct gdb_object) <symtabs>: Change type to
 454         std::forward_list<gdb_symtab>.
 455         (jit_object_open_impl): Allocate gdb_object with new.
 456         (jit_symtab_open_impl): Adjust to std::forward_list.
 457         (finalize_symtab): Don't delete symtab.
 458         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 459         gdb_object with delete.
 460
 461 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 462
 463         * jit.c (struct gdb_symtab): Add constructor, destructor,
 464         initialize fields.
 465         <linetable>: Change type to unique_xmalloc_ptr.
 466         <file_name>: Change type to std::string.
 467         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 468         (jit_symtab_line_mapping_add_impl): Adjust.
 469         (finalize_symtab): Adjust, call delete on stab.
 470
 471 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 472
 473         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 474
 475 2019-12-16  Tom Tromey  <tromey@adacore.com>
 476
 477         * windows-nat.c (windows_nat_target::attach): Update.
 478         * remote.c (extended_remote_target::attach): Update.
 479         * procfs.c (procfs_target::attach): Update.
 480         * nto-procfs.c (nto_procfs_target::attach): Update.
 481         (nto_procfs_target::create_inferior): Update.
 482         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 483         * gnu-nat.c (gnu_nat_target::attach): Update.
 484         (gnu_nat_target::detach): Update.
 485         * darwin-nat.c (darwin_nat_target::attach): Update.
 486         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 487         return.
 488         * bsd-kvm.c (bsd_kvm_target_open): Update.
 489         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 490
 491 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 492
 493         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 494         (we no longer need to include time.h before pathmax.h)
 495
 496 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 497
 498         * ada-exp.y (write_ambiguous_var): Update.
 499         * coffread.c (process_coff_symbol): Update.
 500         * ctfread.c (ctf_add_enum_member_cb): Update.
 501         (new_symbol): Update.
 502         * dwarf2read.c (fixup_go_packaging): Update.
 503         (new_symbol): Update.
 504         * language.c (language_alloc_type_symbol): Update.
 505         * mdebugread.c (new_symbol): Update.
 506         * minsyms.c (minimal_symbol_reader::record_full): Update.
 507         * psymtab.c (add_psymbol_to_bcache): Update.
 508         * stabsread.c (define_symbol): Update.
 509         (read_enum_type): Update.
 510         * symtab.c (symbol_set_language): Make this a member function...
 511         (general_symbol_info::set_language): ... here.
 512         * symtab.h (struct general_symbol_info) <set_language>: New function.
 513         (SYMBOL_SET_LANGUAGE): Remove.
 514         (symbol_set_language): Remove.
 515
 516 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 517
 518         * ada-lang.c (ada_add_block_symbols): Update.
 519         (ada_collect_symbol_completion_matches): Update.
 520         * ax-gdb.c (gen_expr): Update.
 521         * block.c (block_lookup_symbol): Update.
 522         (block_lookup_symbol_primary): Update.
 523         (block_find_symbol): Update.
 524         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 525         * dbxread.c (process_one_symbol): Update.
 526         * dictionary.c (insert_symbol_hashed): Update.
 527         (collate_pending_symbols_by_language): Update.
 528         (mdict_add_symbol): Update.
 529         * dwarf-index-write.c (write_psymbols): Update.
 530         * dwarf2read.c (fixup_go_packaging): Update.
 531         * findvar.c (read_var_value): Update.
 532         * ft32-tdep.c (ft32_skip_prologue): Update.
 533         * go-lang.c (go_symbol_package_name): Update.
 534         * language.h (scoped_switch_to_sym_language_if_auto::
 535         scoped_switch_to_sym_language_if_auto): Update.
 536         * linespec.c (find_method): Update.
 537         (find_label_symbols_in_block): Update.
 538         * mdebugread.c (parse_symbol): Update.
 539         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 540         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 541         (minimal_symbol_reader::install): Update.
 542         * moxie-tdep.c (moxie_skip_prologue): Update.
 543         * parse.c (parse_exp_in_context): Update.
 544         * psymtab.c (psymbol_name_matches): Update.
 545         (match_partial_symbol): Update.
 546         (lookup_partial_symbol): Update.
 547         (psymbol_hash): Update.
 548         (psymbol_compare): Update.
 549         * python/py-framefilter.c (extract_sym): Update.
 550         (py_print_single_arg): Update.
 551         * stabsread.c (define_symbol): Update.
 552         * stack.c (print_frame_arg): Update.
 553         (find_frame_funname): Update.
 554         (info_frame_command_core): Update.
 555         * symfile.c (set_initial_language): Update.
 556         * symtab.c (symbol_set_demangled_name): Update.
 557         (symbol_get_demangled_name): Update.
 558         (symbol_set_language): Update.
 559         (symbol_find_demangled_name): Update.
 560         (symbol_set_names): Update.
 561         (general_symbol_info::natural_name): Update.
 562         (general_symbol_info::demangled_name): Update.
 563         (general_symbol_info::search_name): Update.
 564         (symbol_matches_search_name): Update.
 565         (eq_symbol_entry): Update.
 566         (iterate_over_symbols): Update.
 567         (completion_list_add_symbol): Update.
 568         (completion_list_add_msymbol): Update.
 569         (completion_list_add_fields): Update.
 570         * symtab.h (struct general_symbol_info) <language>: New function.
 571         <language>: Rename to...
 572         <m_language>: ...this.
 573         (SYMBOL_LANGUAGE): Remove.
 574         (MSYMBOL_LANGUAGE): Remove.
 575         (struct symbol) <ctor>: Update.
 576         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 577
 578 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 579
 580         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 581         set the language of sym.
 582         * language.c (language_alloc_type_symbol): Likewise.
 583
 584 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 585
 586         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 587         PR gdb/23613
 588         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 589         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 590         (core_target_open): Use 'gdb_abspath'.
 591         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 592         'current_directory == NULL' case.
 593         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 594         explain what happens when 'current_directory' is NULL.
 595         * go32-nat.c (go32_nat_target::wait): Check if
 596         'current_directory' is NULL before call to 'chdir'.
 597         * source.c (add_path): Use 'gdb_abspath'.
 598         * top.c: Include 'gdbsupport/pathstuff.h'.
 599         (init_history): Use 'gdb_abspath'.
 600         (set_history_filename): Likewise.
 601         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 602         (tfile_target_open): Use 'gdb_abspath'.
 603
 604 2019-12-13  Tom Tromey  <tromey@adacore.com>
 605
 606         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 607         warning or error.
 608
 609 2019-12-13  Tom Tromey  <tromey@adacore.com>
 610
 611         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 612
 613 2019-12-13  Tom Tromey  <tromey@adacore.com>
 614
 615         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 616
 617 2019-12-13  Tom Tromey  <tromey@adacore.com>
 618
 619         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 620
 621 2019-12-13  Tom Tromey  <tromey@adacore.com>
 622
 623         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 624         (string_vappendf): Add ARI comment.
 625
 626 2019-12-13  Tom Tromey  <tromey@adacore.com>
 627
 628         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 629         floatformat_to_double.
 630         * target-float.c (host_float_ops<T>::from_target): Add ARI
 631         comment.
 632
 633 2019-12-13  Tom Tromey  <tromey@adacore.com>
 634
 635         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 636         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 637         ARI marker to abort.
 638         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 639
 640 2019-12-13  Tom Tromey  <tromey@adacore.com>
 641
 642         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 643
 644 2019-12-13  Tom Tromey  <tromey@adacore.com>
 645
 646         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 647
 648 2019-12-13  Tom Tromey  <tromey@adacore.com>
 649
 650         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 651         checks.
 652
 653 2019-12-13  Tom Tromey  <tromey@adacore.com>
 654
 655         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 656         end>: No longer "const".
 657
 658 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 659
 660         * jit.c: Fix indentation, replace spaces with tabs where
 661         applicable.
 662
 663 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 664
 665         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 666
 667 2019-12-12  Tom Tromey  <tom@tromey.com>
 668
 669         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 670         unique_ptr.
 671
 672 2019-12-12  Tom Tromey  <tom@tromey.com>
 673
 674         * progspace.h (objfile_list): New typedef.
 675         (class unwrapping_objfile_iterator)
 676         (struct unwrapping_objfile_range): Newl
 677         (struct program_space) <objfiles_range>: Change type.
 678         <objfiles>: Change return type.
 679         <add_objfile>: Change type of "objfile" parameter.
 680         <objfiles_list>: Now a list of shared_ptr.
 681         * progspace.c (program_space::add_objfile): Change type of
 682         "objfile".  Update.
 683         (program_space::remove_objfile): Update.
 684         * objfiles.h (struct objfile) <~objfile>: Make public.
 685         * objfiles.c (objfile::make): Update.
 686         (objfile::unlink): Don't call delete.
 687
 688 2019-12-12  Tom Tromey  <tom@tromey.com>
 689
 690         * symfile.c (symbol_file_clear): Update.
 691         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 692         method.
 693         * progspace.c (program_space::free_all_objfiles): New method.
 694         * objfiles.h (free_all_objfiles): Don't declare.
 695         * objfiles.c (free_all_objfiles): Move to program_space.
 696
 697 2019-12-12  Tom Tromey  <tom@tromey.com>
 698
 699         * progspace.c (program_space::add_objfile)
 700         (program_space::remove_objfile): Update.
 701         (program_space::multi_objfile_p): Remove.
 702         * objfiles.h (struct objfile) <next>: Remove.
 703         * objfiles.c (objfile::objfile): Update.
 704         (put_objfile_before): Update.
 705         (unlink_objfile): Update.
 706         * progspace.h (object_files): Remove.
 707         (struct program_space) <objfiles_head>: Remove.
 708         <objfiles_list>: New member.
 709         <objfiles_range, objfiles_safe_range>: Change type.
 710         (objfiles): Change return type.
 711         (objfiles_safe): Update.
 712         (multi_objfile_p): Rewrite and inline.
 713         (object_files): Remove macro.
 714
 715 2019-12-12  Tom Tromey  <tom@tromey.com>
 716
 717         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 718         second constructor.
 719         (basic_safe_range): New class.
 720
 721 2019-12-12  Tom Tromey  <tom@tromey.com>
 722
 723         * progspace.c (program_space::multi_objfile_p): New method.
 724         * printcmd.c (info_symbol_command): Update.
 725         * maint.c (maintenance_translate_address): Update.
 726         * objfiles.h (MULTI_OBJFILE_P): Remove.
 727         * progspace.h (struct program_space) <multi_objfile_p>: New
 728         method.
 729
 730 2019-12-12  Tom Tromey  <tom@tromey.com>
 731
 732         * progspace.h (struct program_space) <remove_objfile>: Declare.
 733         * progspace.c (program_space::remove_objfile): New method.
 734         * objfiles.c (unlink_objfile): Remove.
 735         (objfile::unlink): Call remove_objfile.
 736         (objfile): Don't call unlink_objfile.
 737
 738 2019-12-12  Tom Tromey  <tom@tromey.com>
 739
 740         * progspace.h (struct program_space) <add_objfile>: Declare
 741         method.
 742         * progspace.c (program_space::add_objfile): New method.
 743         * objfiles.c (~objfile): Don't unlink objfile.
 744         (put_objfile_before): Remove.
 745         (add_separate_debug_objfile): Don't call put_objfile_before.
 746         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 747         the per-program-space data.
 748
 749 2019-12-12  Tom Tromey  <tom@tromey.com>
 750
 751         * symfile.c (syms_from_objfile_1): Use objfile_up.
 752         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 753         method.
 754         (reread_symbols): Use objfile_up.
 755         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 756         unlink method.
 757         * objfiles.h (struct objfile) <~objfile>: Now private.
 758         <unlink>: New method.
 759         (struct objfile_deleter): New.
 760         (objfile_up): New typedef.
 761         * objfiles.c (objfile::unlink): New method.
 762         (free_objfile_separate_debug, free_all_objfiles)
 763         (objfile_purge_solibs): Use it.
 764         * jit.c (jit_unregister_code): Remove.
 765         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 766         objfile.
 767         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 768         objfile.
 769         * compile/compile-object-load.c (compile_object_load): Use
 770         objfile_up.
 771
 772 2019-12-12  Tom Tromey  <tom@tromey.com>
 773
 774         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 775         objfile::make.
 776         * objfiles.h (struct objjfile) <make>: No longer inline.
 777         (add_separate_debug_objfile): Don't declare.
 778         * objfiles.c (add_separate_debug_objfile): Now static.
 779         (objfile::make): Move from objfiles.h.  Call
 780         add_separate_debug_objfile.  Add "parent" parameter.
 781
 782 2019-12-12  Tom Tromey  <tom@tromey.com>
 783
 784         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 785         * objfiles.h (struct objfile): Make constructor private.
 786         <make>: New static method.
 787         * jit.c (jit_object_close_impl): Update.
 788
 789 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 790
 791         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 792         gdb::byte_vector.
 793
 794 2019-12-12  Tom Tromey  <tromey@adacore.com>
 795
 796         * xml-support.c (xml_fetch_content_from_file): Don't call
 797         malloc_failure.
 798         * utils.h (class gdb_argv): Remove malloc_failure comment.
 799         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 800
 801 2019-12-12  Tom Tromey  <tromey@adacore.com>
 802
 803         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 804         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 805         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 806         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 807         * riscv-ravenscar-thread.c: New file.
 808         * riscv-ravenscar-thread.h: New file.
 809         * riscv-tdep.c (riscv_gdbarch_init): Call
 810         register_riscv_ravenscar_ops.
 811
 812 2019-12-12  Tom Tromey  <tromey@adacore.com>
 813
 814         * gdbsupport/thread-pool.c (set_thread_name): Use
 815         ATTRIBUTE_UNUSED.
 816
 817 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 818
 819         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 820         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 821         macros.
 822
 823 2019-12-11  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-win.c (tui_set_win_height_command): Call
 826         tui_adjust_window_height.
 827         (tui_adjust_win_heights, new_height_ok): Remove.
 828         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 829         * tui/tui-layout.c (tui_adjust_window_height): New function.
 830
 831 2019-12-11  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-win.c (tui_resize_all): Remove code, call
 834         tui_apply_current_layout.
 835
 836 2019-12-11  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 839         * tui/tui-layout.c (standard_layouts, applied_layout): New
 840         globals.
 841         (tui_apply_current_layout): New function.
 842         (show_layout): Set applied_layout.  Call
 843         tui_apply_current_layout.
 844         (show_source_command, show_disasm_command)
 845         (show_source_disasm_command, show_data)
 846         (show_source_or_disasm_and_command): Remove.
 847         (initialize_layouts): New function.
 848         (_initialize_tui_layout): Call initialize_layouts.
 849
 850 2019-12-11  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-layout.h (class tui_layout_base)
 853         (class tui_layout_window, class tui_layout_split): New.
 854         * tui/tui-layout.c (tui_get_window_by_name)
 855         (tui_layout_window::clone, tui_layout_window::apply)
 856         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 857         (tui_layout_split::add_window, tui_layout_split::clone)
 858         (tui_layout_split::get_sizes)
 859         (tui_layout_split::set_weights_from_heights)
 860         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 861         functions.
 862         (tui_layout_split::add_split, tui_layout_split::add_split)
 863         (tui_layout_split::set_weights_from_heights)
 864         (tui_layout_split::set_weights_from_heights): New functions.
 865
 866 2019-12-11  Tom Tromey  <tom@tromey.com>
 867
 868         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 869         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 870         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 871         * tui/tui-data.h (struct tui_point): Remove.
 872         (struct tui_gen_win_info) <origin>: Remove.
 873         <x, y>: New fields.
 874         * tui/tui-command.c (tui_cmd_window::resize): Update.
 875
 876 2019-12-11  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 879         Implement.
 880         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 881         Implement.
 882         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 883         method.
 884         (struct tui_win_info) <min_height>: Implement.
 885
 886 2019-12-11  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 889         (struct tui_win_info) <can_box>: Update.
 890
 891 2019-12-11  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 894         method.
 895         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 896         method.
 897         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 898         method.
 899         (struct tui_win_info) <max_height>: Now override.
 900
 901 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 902
 903         * NEWS: Create a new section for the next release branch.
 904         Rename the section of the current branch, now that it has
 905         been cut.
 906
 907 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 908
 909         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 910         * version.in: Bump version to 10.0.50.DATE-git.
 911
 912 2019-12-11  Tom Tromey  <tromey@adacore.com>
 913
 914         PR build/25268:
 915         * gdbsupport/thread-pool.c (set_thread_name): New function.
 916         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 917         (thread_pool::thread_function): Call set_thread_name.
 918
 919 2019-12-11  Tom Tromey  <tromey@adacore.com>
 920
 921         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 922         bfd_get_signed_8.
 923
 924 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 925
 926         * NEWS: Document -raw-values option and the related setting commands.
 927         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 928         only set it on when /r is given.
 929         * valprint.c (value_print_option_defs): New element raw-values.
 930         * Makefile.in: Add the new file.
 931
 932 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 933
 934         * gdbsupport/safe-strerror.c: Supress the unused function warning
 935         for select_strerror_r.
 936
 937 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 938
 939         * config.in: Regenerate.
 940         * configure: Regenerate.
 941         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 942         safe_strerror instead of strerror.
 943         * gdbsupport/common.m4: Don't check for strerror.
 944         * gdbsupport/safe-strerror.c: Support both the glibc version
 945         of strerror_r and the XSI version.
 946
 947 2019-12-10  Tom Tromey  <tromey@adacore.com>
 948
 949         * ada-typeprint.c (print_choices): Use a single "?".
 950         (print_variant_part): Print "?" if the discriminant name
 951         is not known.
 952
 953 2019-12-10  George Barrett  <bob@bob131.so>
 954
 955         Fix scripted probe breakpoints.
 956         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 957         declaration forward.
 958         (breakpoint_ops_for_event_location_type)
 959         (breakpoint_ops_for_event_location): Add function definitions.
 960         (break_command_1, trace_command): Use
 961         breakpoint_ops_for_event_location.
 962         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 963         declarations.
 964         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 965         breakpoint_ops_for_event_location.
 966         * python/py-breakpoint.c (bppy_init): Use
 967         breakpoint_ops_for_event_location.
 968
 969 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 970
 971         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 972         when ranking an lvalue argument for an rvalue parameter.
 973
 974 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 975
 976         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 977         template argument for scoped_restore_tmpl from bool to int.
 978
 979 2019-12-07  Keith Seitz  <keiths@redhat.com>
 980
 981         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 982         (build_id_to_debug_bfd): Make static, rewriting to use
 983         build_id_to_bfd_suffix.
 984         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 985         adding `suffix' parameter. Append SUFFIX to file names
 986         when searching for matching files.
 987         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 988         (build_id_to_exec_bfd): Likewise.
 989         * build-id.h (build_id_to_debug_bfd): Clarify that function
 990         searches for BFD of debug info file.
 991         (build_id_to_exec_bfd): Declare.
 992         * corelow.c: Include build-id.h.
 993         (locate_exec_from_corefile_build_id): New function.
 994         (core_target_open): If no executable BFD is found,
 995         search for a core file BFD using build-id.
 996
 997 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 998
 999         * bcache.c: Put in namespace gdb.
1000         * bcache.h: Likewise.
1001         * gdbtypes.c (check_types_worklist): Update.
1002         (types_deeply_equal): Update.
1003         * macrotab.c (struct macro_table) <bcache>: Update.
1004         (new_macro_table): Update.
1005         * macrotab.h (struct bcache): Put this forward declaration
1006         inside namespace gdb.
1007         (new_macro_table): Update.
1008         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
1009         Update.
1010         <macro_cache>: Update.
1011         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
1012
1013 2019-12-06  Tom de Vries  <tdevries@suse.de>
1014
1015         PR symtab/24971
1016         * block.c (best_symbol, better_symbol): New function.
1017         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
1018         decl.
1019
1020 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1021
1022         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
1023         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
1024         for ranking see-through reference cases.
1025
1026 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1027         * stack.c (faas_command): Check a command is provided.
1028         * thread.c (taas_command, tfaas_command): Likewise.
1029
1030 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1031         * inferior.c (prune_inferiors):  Only call delete_inferior,
1032         Do not modify the inferior list.
1033
1034 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
1035
1036         * c-exp.y: Update calls to lookup_typename,
1037         lookup_signed_typename and lookup_unsigned_typename.
1038         * c-lang.c (evaluate_subexp_c): Likewise.
1039         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
1040         Likewise.
1041         * eval.c (binop_promote): Likewise.
1042         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
1043         (lookup_unsigned_typename): Likewise.
1044         (lookup_signed_typename): Likewise.
1045         * gdbtypes.h (lookup_unsigned_typename): Likewise.
1046         (lookup_signed_typename): Likewise.
1047         (lookup_typename): Likewise.
1048         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
1049         lookup_typename, lookup_signed_typename,
1050         lookup_unsigned_typename.
1051         * m2-exp.y: Likewise.
1052         * printcmd.c (printf_wide_c_string): Likewise.
1053         (ui_printf): Likewise.
1054         * python/py-type.c (typy_lookup_typename): Likewise.
1055         * python/py-xmethods.c (python_xmethod_worker::invoke):
1056         Likewise.
1057         * rust-exp.y: Likewise.
1058
1059 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
1060
1061         * configure.nat (obsd64): Add missing files x86-nat.o and
1062         nat/x86-dregs.o.
1063
1064 2019-12-04  Tom Tromey  <tom@tromey.com>
1065
1066         * valprint.c (val_print_string): Use metadata_style.
1067         * go-valprint.c (print_go_string): Use metadata style.
1068         * p-valprint.c (pascal_object_print_static_field): Use metadata
1069         style.
1070         * cp-valprint.c (cp_print_static_field): Use metadata style.
1071
1072 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1073             Chris January  <chris.january@arm.com>
1074
1075         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1076         tokens.
1077         (typebase): New patterns for complex, single/double precision, and
1078         single/double complex.
1079         (f77_keywords): Change token for complex keyword, and add single,
1080         double, and precision keywords.
1081
1082 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1083
1084         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1085         "info io_registers".
1086
1087 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1088
1089         * regcache.c (cooked_read_test): Initialize thread list of
1090         mock_inferior.
1091
1092 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1093
1094         * aarch64-linux-tdep.c: Remove includes.
1095
1096 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1097
1098         * aarch64-tdep.c: Remove includes.
1099
1100 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
1101
1102         * filtered-iterator.h (filtered_iterator) <operator==,
1103         operator!=>: Compare wrapped iterators, not wrapped pointers.
1104         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1105         unittests/filtered_iterator-selftests.c.
1106         * unittests/filtered_iterator-selftests.c: New file.
1107
1108 2019-12-04  Tom Tromey  <tromey@adacore.com>
1109
1110         * gdbtypes.c (create_range_type): Inherit endianity
1111         from base type.
1112
1113 2019-12-04  Tom Tromey  <tromey@adacore.com>
1114
1115         * ada-lang.c (decode_constrained_packed_array)
1116         (ada_value_assign, value_assign_to_component): Update.
1117         * dwarf2loc.c (rw_pieced_value, access_memory)
1118         (dwarf2_compile_expr_to_ax): Update.
1119         * dwarf2read.c (dwarf2_add_field): Update.
1120         * eval.c (evaluate_subexp_standard): Update.
1121         * gdbarch.c, gdbarch.h: Rebuild.
1122         * gdbarch.sh (bits_big_endian): Remove.
1123         * gdbtypes.h (union field_location): Update comment.
1124         * target-descriptions.c (make_gdb_type): Update.
1125         * valarith.c (value_bit_index): Update.
1126         * value.c (struct value) <bitpos>: Update comment.
1127         (unpack_bits_as_long, modify_field): Update.
1128         * value.h (value_bitpos): Update comment.
1129
1130 2019-12-04  Tom Tromey  <tromey@adacore.com>
1131
1132         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
1133         endian-ness.
1134
1135 2019-12-04  Tom Tromey  <tromey@adacore.com>
1136
1137         * dwarf2read.c (dwarf2_init_float_type)
1138         (dwarf2_init_complex_target_type): Add byte_order parameter.
1139         (read_base_type): Compute byte order earlier.
1140         * gdbtypes.c (init_float_type): Add byte_order parameter.
1141         * gdbtypes.h (init_float_type): Add byte_order parameter.
1142
1143 2019-12-04  Tom Tromey  <tromey@adacore.com>
1144
1145         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1146
1147 2019-12-04  Tom Tromey  <tromey@adacore.com>
1148
1149         * dwarf2read.c (process_structure_scope): Initialize
1150         "discr_offset".
1151
1152 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1155         add it into the search spec.
1156         (parse_max_results_option): New function.
1157         (mi_info_functions_or_variables): Parse -max-results flag and pass
1158         it to mi_symbol_info.
1159         (mi_cmd_symbol_info_modules): Likewise.
1160         (mi_cmd_symbol_info_types): Likewise.
1161         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1162         return type to bool, change result container into a set, and don't
1163         add new results if we have enough already.
1164         (global_symbol_searcher::add_matching_msymbols): Change return
1165         type to bool, and don't add new results if we have enough already.
1166         (sort_search_symbols_remove_dups): Delete.
1167         (global_symbol_searcher::search): Early exit from search loop when
1168         we have enough results.  Use a std::set to collect the results
1169         from calling add_matching_symbols.
1170         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1171         member function.
1172         (global_symbol_searcher) <m_max_search_results>: New member
1173         variable.
1174         (global_symbol_searcher) <add_matching_symbols>: Update header
1175         comment and change return type to bool.
1176         (global_symbol_searcher) <add_matching_msymbols>: Update header
1177         comment and change return type to bool.
1178
1179 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1180
1181         * symtab.c (symbol_search::compare_search_syms): Update header
1182         comment.
1183         (global_symbol_searcher::is_suitable_msymbol): New function.
1184         (global_symbol_searcher::expand_symtabs): New function.
1185         (global_symbol_searcher::add_matching_symbols): New function.
1186         (global_symbol_searcher::add_matching_msymbols): New function.
1187         (global_symbol_searcher::search): Move most of the content
1188         into the new functions above, and call them as needed.
1189         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1190         function.
1191         (global_symbol_searcher) <add_matching_symbols>: New member
1192         function.
1193         (global_symbol_searcher) <add_matching_msymbols>: New member
1194         function.
1195         (global_symbol_searcher) <is_suitable_msymbol>: New member
1196         function.
1197
1198 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1201         -symbol-info-module-variables entries.
1202         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1203         (mi_cmd_symbol_info_module_variables): Declare.
1204         * mi/mi-symbol-cmds.c
1205         (module_symbol_search_iterator): New typedef.
1206         (output_module_symbols_in_single_module_and_file): New function.
1207         (output_module_symbols_in_single_module): New function.
1208         (mi_info_module_functions_or_variables): New function.
1209         (mi_cmd_symbol_info_module_functions): New function.
1210         (mi_cmd_symbol_info_module_variables): New function.
1211         * NEWS: Mention new MI command.
1212
1213 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1214
1215         * bcache.c (hash): Remove.
1216         (hash_continue): Remove.
1217         * bcache.h (hash): Remove.
1218         (hash_continue): Remove.
1219         (struct bcache) <ctor>: Update.
1220         * psymtab.c (psymbol_hash): Update.
1221         * stabsread.c (hashname): Update.
1222         * utils.h (fast_hash): Add an argument for a start value,
1223         defaulting to zero.
1224
1225 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1226         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1227         (destroy_block_symbol_cache): New function.
1228         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1229         (resize_symbol_cache): Likewise.
1230
1231 2019-12-02  Tom Tromey  <tom@tromey.com>
1232
1233         * unittests/tui-selftests.c (run_tests): Make conditional.
1234         (_initialize_tui_selftest): Make conditional.
1235
1236 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1237
1238         * aix-thread.c (debug_aix_thread): Change type to bool.
1239
1240 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1241
1242         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1243
1244 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * dwarf2read.c (read_tag_string_type): Read the fields required to
1247         make a dynamic string, and possibly create a dynamic range for the
1248         string.
1249         (attr_to_dynamic_prop): Setup is_reference based on the type of
1250         attribute being processed.
1251         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1252         (resolve_dynamic_array): Rename to...
1253         (resolve_dynamic_array_or_string): ...this, update header comment,
1254         and accept TYPE_CODE_STRING.
1255         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1256
1257 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1260         of its implementation from...
1261         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1262         the new function.
1263
1264 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1265
1266         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1267         create a range with stride where appropriate.
1268         * f-valprint.c: Include 'gdbarch.h'.
1269         (f77_print_array_1): Take the stride into account when walking the
1270         array.  Also convert the stride into addressable units.
1271         * gdbtypes.c (create_range_type): Initialise the stride to
1272         constant zero.
1273         (create_range_type_with_stride): New function, initialise the
1274         range as normal, and then setup the stride.
1275         (has_static_range): Include the stride here.  Also change the
1276         return type to bool.
1277         (create_array_type_with_stride): Consider the range stride if the
1278         array isn't given its own stride.
1279         (resolve_dynamic_range): Resolve the stride if needed.
1280         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1281         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1282         (TYPE_BIT_STRIDE): Define.
1283         (TYPE_ARRAY_BIT_STRIDE): Define.
1284         (create_range_type_with_stride): Declare.
1285         * valarith.c (value_subscripted_rvalue): Take range stride into
1286         account when walking the array.
1287
1288 2019-12-01  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1291         specially.
1292
1293 2019-12-01  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1296         \0.
1297         * unittests/tui-selftests.c: New file.
1298         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1299
1300 2019-12-01  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1303
1304 2019-12-01  Tom Tromey  <tom@tromey.com>
1305
1306         * NEWS: Document new settings.
1307         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1308         * tui/tui-win.c (_initialize_tui_win): Add border style
1309         observers.
1310         * tui/tui-io.h (tui_apply_style): Declare.
1311         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1312         longer static.
1313         (apply_ansi_escape, tui_set_reverse_mode): Update.
1314         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1315         Add "skip_intensity" parameter.
1316         <changed>: New member.
1317         <do_set_value>: Declare.
1318         (tui_border_style, tui_active_border_style): Declare.
1319         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1320         globals.
1321         (cli_style_option): Initialize "changed".
1322         (cli_style_option::do_set_value): New function.
1323         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1324         parameter.  Update.
1325         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1326         (_initialize_cli_style): Update.  Create TUI border style
1327         commands.
1328
1329 2019-12-01  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1332         parameter.
1333         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1334         parameter.
1335         * tui/tui-win.h (compact_source): Declare.
1336         * tui/tui-win.c (compact_source): New global.
1337         (tui_set_compact_source, tui_show_compact_source): New functions.
1338         (_initialize_tui_win): Add "compact-source" setting.
1339         * tui/tui-source.c (tui_source_window::set_contents): Handle
1340         compact_source setting.
1341         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1342         * NEWS: Document new setting.
1343
1344 2019-11-30  Tom Tromey  <tom@tromey.com>
1345
1346         * dwarf2read.c (dwarf2_add_field): Include field offset when
1347         computing variant part length.
1348
1349 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1350         * NEWS:  Mention define-prefix.  Tell that command names can now
1351         contain a . character.
1352
1353 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1354
1355         * command.h (valid_cmd_char_p): Declare.
1356         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1357         the check of valid command char.
1358         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1359         valid_cmd_char_p.
1360         * cli/cli-script.c (validate_comname): Likewise.
1361         * completer.c (gdb_completer_command_word_break_characters):
1362         Do not remove . from the word break char, update comments.
1363         (complete_line_internal_1): Use valid_cmd_char_p.
1364         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1365         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1366
1367 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368
1369         * cli/cli-script.c (do_define_command): Ensure a redefined
1370         prefix command is kept as a prefix command.
1371         (define_prefix_command): New function.
1372         (show_user_1): Report user defined prefixes.
1373         (_initialize_cli_script):  Create the new 'define-prefix' command.
1374         Add completers for 'define' and 'document'.
1375         * top.c (execute_command):  If command is a user-defined prefix only
1376         command, report the list of commands for this prefix command.
1377
1378 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1379
1380         * valops.c (find_oload_champ): Improve debug output.
1381
1382 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1383
1384         * valops.c (find_oload_champ): Print part of debug messages
1385         before the badness vector is std::move'd.
1386
1387 2019-11-28  Tom Tromey  <tom@tromey.com>
1388
1389         * value.c (creal_internal_fn): Fix comment.
1390
1391 2019-11-28  Tom Tromey  <tom@tromey.com>
1392
1393         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1394         flag_bound_evaluated>: Now unsigned.
1395
1396 2019-11-28  Tom Tromey  <tom@tromey.com>
1397
1398         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1399         declare.
1400
1401 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1402
1403         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1404         debug output.
1405         * jit.c (jit_unregister_code): Add debug print to match
1406         `jit_register_code`.
1407
1408 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1409
1410         * NEWS: Mention the new multithreaded symbol loading.
1411
1412 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1413
1414         * maint.c (n_worker_threads): Default to 0.
1415         (worker_threads_disabled): New function.
1416         * maint.h (worker_threads_disabled): New function.
1417         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1418         here if worker_threads_disabled () is true.
1419         (minimal_symbol_reader::install): Skip all threading if
1420         worker_threads_disabled () is true.
1421
1422 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1425         hash code if possible.
1426         (add_minsym_to_demangled_hash_table): Likewise.
1427         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1428         on the background thread.
1429         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1430         Add these fields.
1431
1432 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1433
1434         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1435         of the mangled name on the background thread.
1436         * symtab.c (symbol_set_names): Allow passing in the hash of the
1437         linkage_name.
1438         * symtab.h (symbol_set_names): Likewise.
1439
1440 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1441
1442         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1443         physnames are computed for inherited DIEs.
1444
1445 2019-11-27  Tom Tromey  <tromey@adacore.com>
1446
1447         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1448         backslashes.
1449         * cp-support.c: Remove unnecessary backslashes.
1450
1451 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1452
1453         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1454         with sym->set_linkage_name.
1455         * coffread.c (coff_read_enum_type): Likewise.
1456         * mdebugread.c (parse_symbol): Likewise.
1457         * stabsread.c (patch_block_stabs): Likewise.
1458         (define_symbol): Likewise.
1459         (read_enum_type): Likewise.
1460         (common_block_end): Likewise.
1461         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1462         function.
1463         (SYMBOL_SET_LINKAGE_NAME): Remove.
1464         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1465         with sym->set_linkage_name.
1466
1467 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1470         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1471         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1472         * NEWS: Mention new MI command.
1473
1474 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1475
1476         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1477         '-symbol-info-types', and '-symbol-info-variables'.
1478         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1479         (mi_cmd_symbol_info_types): Declare.
1480         (mi_cmd_symbol_info_variables): Declare.
1481         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1482         (output_debug_symbol): New function.
1483         (output_nondebug_symbol): New function.
1484         (mi_symbol_info): New function.
1485         (mi_info_functions_or_variables): New function.
1486         (mi_cmd_symbol_info_functions): New function.
1487         (mi_cmd_symbol_info_types): New function.
1488         (mi_cmd_symbol_info_variables): New function.
1489         * NEWS: Mention new commands.
1490
1491 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * symtab.c (symbol_to_info_string): New function, most content
1494         moved from print_symbol_info, but updated to return a std::string.
1495         (print_symbol_info): Update to use symbol_to_info_string and print
1496         returned string.
1497         * symtab.h (symbol_to_info_string): Declare new function.
1498
1499 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * python/python.c (gdbpy_rbreak): Convert to using
1502         global_symbol_searcher.
1503         * symtab.c (file_matches): Convert return type to bool, change
1504         file list to std::vector, update header comment.
1505         (search_symbols): Rename to...
1506         (global_symbol_searcher::search): ...this and update now its
1507         a member function of global_symbol_searcher.  Take account of the
1508         changes to file_matches.
1509         (symtab_symbol_info): Convert to using global_symbol_searcher.
1510         (rbreak_command): Likewise.
1511         (search_module_symbols): Likewise.
1512         * symtab.h (enum symbol_search): Update comment.
1513         (search_symbols): Remove declaration.
1514         (class global_symbol_searcher): New class.
1515
1516 2019-11-26  Tom Tromey  <tromey@adacore.com>
1517
1518         * cp-support.c (_initialize_cp_support): Conditionally initialize
1519         gdb_demangle_attempt_core_dump.
1520
1521 2019-11-26  Tom Tromey  <tom@tromey.com>
1522
1523         * python/py-function.c (fnpy_init): Update.
1524         * value.h (add_internal_function): Adjust declaration.
1525         * value.c (function_destroyer): Remove.
1526         (do_add_internal_function): Don't set destroyer or copy name.
1527         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1528         Set name_allocated.
1529         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1530         (cmdpy_init): Set name_allocated.
1531         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1532         member.
1533         (~cmd_list_element): Free "name" if needed.
1534
1535 2019-11-26  Tom Tromey  <tom@tromey.com>
1536
1537         * value.h (add_internal_function): Add new overload.  Move
1538         documentation from value.h.
1539         * value.c (do_add_internal_function): New function.
1540         (add_internal_function): Use it.  Add new overload.
1541         (function_destroyer): Don't free doc.
1542         * python/py-function.c (fnpy_init): Update.
1543
1544 2019-11-26  Tom Tromey  <tom@tromey.com>
1545
1546         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1547         (cmdpy_init): Set "doc_allocated".
1548
1549 2019-11-26  Tom Tromey  <tom@tromey.com>
1550
1551         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1552         name of worker thread.
1553         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1554         pthread_setname_np.
1555         * configure, config.in: Rebuild.
1556
1557 2019-11-26  Tom Tromey  <tom@tromey.com>
1558
1559         * python/python.c (class gdbpy_gil): New.
1560         (struct gdbpy_event): Add constructor, destructor, operator().
1561         (gdbpy_post_event): Use run_on_main_thread.
1562         (gdbpy_initialize_events): Remove.
1563         (do_start_initialization): Update.
1564
1565 2019-11-26  Tom Tromey  <tom@tromey.com>
1566
1567         * NEWS: Add entry.
1568         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1569         commands.  Call update_thread_pool_size.
1570         (update_thread_pool_size, maintenance_set_worker_threads): New
1571         functions.
1572         (n_worker_threads): New global.
1573
1574 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1575             Tom Tromey  <tom@tromey.com>
1576
1577         * minsyms.c (minimal_symbol_reader::install): Use
1578         parallel_for_each.
1579         * gdbsupport/parallel-for.h: New file.
1580         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1581
1582 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1583             Tom Tromey  <tom@tromey.com>
1584
1585         * gdbsupport/thread-pool.h: New file.
1586         * gdbsupport/thread-pool.c: New file.
1587         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1588         (HFILES_NO_SRCDIR): Add thread-pool.h.
1589
1590 2019-11-26  Tom Tromey  <tom@tromey.com>
1591
1592         * event-top.h (thread_local_segv_handler): Declare.
1593         * event-top.c (thread_local_segv_handler): New global.
1594         (install_handle_sigsegv, handle_sigsegv): New functions.
1595         (async_init_signals): Install SIGSEGV handler.
1596         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1597         thread-local.
1598         (report_failed_demangle): New function.
1599         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1600         handler-setting code, instead use segv_handler.  Run warning code
1601         on main thread.
1602
1603 2019-11-26  Tom Tromey  <tom@tromey.com>
1604
1605         * run-on-main-thread.c: New file.
1606         * run-on-main-thread.h: New file.
1607         * unittests/main-thread-selftests.c: New file.
1608         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1609         main-thread-selftests.c.
1610         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1611         (COMMON_SFILES): Add run-on-main-thread.c.
1612
1613 2019-11-26  Tom Tromey  <tom@tromey.com>
1614
1615         * main.c (setup_alternate_signal_stack): Remove.
1616         (captured_main_1): Use gdb::alternate_signal_stack.
1617         * gdbsupport/alt-stack.h: New file.
1618
1619 2019-11-26  Tom Tromey  <tom@tromey.com>
1620
1621         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1622         Remove comment.
1623         (save_original_signals_state, restore_original_signals_state): Use
1624         gdb_sigmask.
1625         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1626         (_initialize_linux_nat): Use gdb_sigmask.
1627         * guile/guile.c (_initialize_guile): Use block_signals.
1628         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1629         * gdbsupport/gdb-sigmask.h: New file.
1630         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1631         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1632         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1633         pthread_sigmask.
1634         * configure, config.in: Rebuild.
1635         * gdbsupport/block-signals.h: New file.
1636
1637 2019-11-26  Tom Tromey  <tom@tromey.com>
1638
1639         * acinclude.m4: Include ax_pthread.m4.
1640         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1641         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1642         (CLIBS): Use PTHREAD_LIBS.
1643         (aclocal_m4_deps): Add ax_pthread.m4.
1644         * config.in, configure: Rebuild.
1645         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1646
1647 2019-11-26  Tom Tromey  <tom@tromey.com>
1648
1649         * symtab.h (struct minimal_symbol) <name_set>: New member.
1650         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1651         Don't call symbol_set_names.
1652         (minimal_symbol_reader::install): Call symbol_set_names.
1653
1654 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1655
1656         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1657         restore_active_ext_lang, as GIL is needed for (indirectly)
1658         called PyOS_InterruptOccurred.
1659
1660 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1661
1662         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1663         definition.
1664
1665 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1666
1667         * remote-sim.c (simulator_command): Make static, remove
1668         declaration.
1669
1670 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1671
1672         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1673         static.
1674         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1675         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1676         (main): Likewise.
1677         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1678         (main): Likewise.
1679         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1680         (main): Likewise.
1681         * unittests/basic_string_view/element_access/char/1.cc (test01):
1682         Likewise.
1683         (main): Likewise.
1684         * unittests/basic_string_view/element_access/char/empty.cc (main):
1685         Likewise.
1686         * unittests/basic_string_view/element_access/char/front_back.cc
1687         (test01): Likewise.
1688         (main): Likewise.
1689         * unittests/basic_string_view/inserters/char/2.cc (test05):
1690         Likewise.
1691         (main): Likewise.
1692         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1693         (test01): Likewise.
1694         (main): Likewise.
1695         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1696         (test01): Likewise.
1697         (main): Likewise.
1698         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1699         Likewise.
1700         * unittests/basic_string_view/operations/compare/char/1.cc
1701         (test01): Likewise.
1702         (main): Likewise.
1703         * unittests/basic_string_view/operations/compare/char/13650.cc
1704         (test01): Likewise.
1705         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1706         Likewise.
1707         (main): Likewise.
1708         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1709         Likewise.
1710         (main): Likewise.
1711         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1712         Likewise.
1713         (main): Likewise.
1714         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1715         Likewise.
1716         (main): Likewise.
1717         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1718         Likewise.
1719         (main): Likewise.
1720         * unittests/basic_string_view/operations/find/char/4.cc (main):
1721         Likewise.
1722         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1723         Likewise.
1724         (main): Likewise.
1725         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1726         Likewise.
1727         (main): Likewise.
1728         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1729         Likewise.
1730         (main): Likewise.
1731         * unittests/basic_string_view/operations/substr/char/1.cc
1732         (test01): Likewise.
1733         (main): Likewise.
1734         * unittests/basic_string_view/operators/char/2.cc (main):
1735         Likewise.
1736         * unittests/optional/assignment/1.cc (test): Likewise.
1737         * unittests/optional/assignment/2.cc (test): Likewise.
1738         * unittests/optional/assignment/3.cc (test): Likewise.
1739         * unittests/optional/assignment/4.cc (test): Likewise.
1740         * unittests/optional/assignment/5.cc (test): Likewise.
1741         * unittests/optional/assignment/6.cc (test): Likewise.
1742         * unittests/optional/assignment/7.cc (test): Likewise.
1743         * unittests/optional/cons/copy.cc (test): Likewise.
1744         * unittests/optional/cons/default.cc (test): Likewise.
1745         * unittests/optional/cons/move.cc (test): Likewise.
1746         * unittests/optional/cons/value.cc (test): Likewise.
1747         * unittests/optional/in_place.cc (test): Likewise.
1748         * unittests/optional/observers/1.cc (test): Likewise.
1749         * unittests/optional/observers/2.cc (test): Likewise.
1750
1751 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1752
1753         * tui-win.h (tui_set_var_cmd): Remove.
1754         * tui-win.c (tui_set_var_cmd): Make static.
1755
1756 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1757
1758         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1759         rbreak_command_wrapper): Remove.
1760         * symtab.c (rbreak_command_wrapper): Remove.
1761
1762 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1763
1764         * inferior.h (info_terminal_command): Remove declaration.
1765         * inflow.c (info_terminal_command): Make static.
1766
1767 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1768
1769         * inferior.c (exit_inferior_silent): Remove.
1770
1771 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1772
1773         * dictionary.c (dict_empty, mdict_empty): Remove.
1774         * dictionary.c (mdict_empty): Remove.
1775
1776 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1777
1778          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1779          (arc_insn_get_memory_offset): Likewise.
1780          (arc_insn_dump): Likewise.
1781          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1782          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1783          * dictionary.c (dict_iterator_next): Likewise.
1784          (dict_iter_match_first): Likewise.
1785          (dict_iter_match_next): Likewise.
1786          * f-lang.c (evaluate_subexp_f): Likewise.
1787          * hppa-tdep.c (hppa_read_pc): Likewise.
1788          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1789          * parse.c (write_exp_elt_msym): Likewise.
1790          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1791          * remote.c (remote_packet_size): Likewise.
1792          (remote_notif_stop_parse): Likewise.
1793          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1794          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1795          * source.c (prepare_path_for_appending): Likewise.
1796          * sparc64-linux-tdep.c
1797          (sparc64_linux_handle_segmentation_fault); Likewise.
1798          * stack.c (frame_selection_by_function_completer): Likewise.
1799
1800 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1801
1802         * completer.c (set_gdb_completion_word_break_characters):
1803         Remove.
1804
1805 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1806
1807         * dwarf-index-write.c: Include dwarf-index-write.h.
1808         * mi/mi-interp.c: Include mi/mi-interp.h.
1809
1810 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1811
1812         * aarch32-tdep.c: Include aarch32-tdep.h.
1813         * aarch32-tdep.h: Forward-declare struct target_desc.
1814
1815 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1816
1817         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1818         strerror.
1819         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1820         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1821
1822 2019-11-25  Tom de Vries  <tdevries@suse.de>
1823
1824         * contrib/words.sh: Add -c option.
1825
1826 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1827
1828         * solib.c (solib_find_1): Change int to bool.
1829         (exec_file_find): Change int to bool.
1830         (solib_find): Change int to bool.
1831         (solib_read_symbols): Change int to bool.
1832         (solib_used): Change int to bool.
1833         (solib_add): Change int to bool.
1834         (info_sharedlibrary_command): Change int to bool.
1835         (solib_contains_address_p): Change int to bool.
1836         (solib_keep_data_in_core): Change int to bool.
1837         (in_solib_dynsym_resolve_code): Change int to bool.
1838         (reload_shared_libraries_1): Change int to bool.
1839         (gdb_sysroot_changed): Change int to bool.
1840         * solib.h (solib_read_symbols): Change int to bool.
1841         (solib_contains_address_p): Change int to bool.
1842         (solib_keep_data_in_core): Change int to bool.
1843         (in_solib_dynsym_resolve_code): Change int to bool.
1844         (libpthread_name_p): Change int to bool.
1845
1846 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1847
1848         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1849         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1850         (remote_packet_max_chars): New static global.
1851         (show_remote_packet_max_chars): New function.
1852         (remote_target::putpkt_binary): Adjust to use new
1853         remote_packet_max_chars option.
1854         (remote_target::getpkt_or_notif_sane_1): Likewise.
1855         (_initialize_remote): Register new remote-packet-max-chars option.
1856
1857 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1858
1859         * m68k-linux-nat.c: Include gdbarch.h.
1860
1861 2019-11-24  Tom Tromey  <tom@tromey.com>
1862
1863         * symfile.c (read_symbols): Update.
1864         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1865         bool.
1866         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1867         (psym_lookup_symbol, psym_find_last_source_symtab)
1868         (psym_forget_cached_source_info, psym_print_stats)
1869         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1870         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1871         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1872         (psym_find_compunit_symtab_by_address)
1873         (maintenance_print_psymbols, maintenance_info_psymtabs)
1874         (maintenance_check_psymtabs): Update.
1875         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1876         bool.
1877
1878 2019-11-22  Tom Tromey  <tom@tromey.com>
1879
1880         * observable.h: Update comments.
1881
1882 2019-11-22  Tom Tromey  <tromey@adacore.com>
1883
1884         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1885         (print_ada_task_info): Don't try to fetch thread id if task is not
1886         alive.
1887
1888 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1889
1890         * ada-exp.y: Update.
1891         * ada-lang.c (sort_choices): Update.
1892         (ada_print_symbol_signature): Update.
1893         (resolve_subexp): Update.
1894         (ada_parse_renaming): Update.
1895         (ada_read_renaming_var_value): Update.
1896         (lesseq_defined_than): Update.
1897         (remove_extra_symbols): Update.
1898         (remove_irrelevant_renamings): Update.
1899         (ada_add_block_symbols): Update.
1900         (ada_collect_symbol_completion_matches): Update.
1901         (ada_is_renaming_symbol): Update.
1902         (aggregate_assign_from_choices): Update.
1903         (ada_evaluate_subexp): Update.
1904         (ada_has_this_exception_support): Update.
1905         (ada_is_non_standard_exception_sym): Update.
1906         (ada_add_exceptions_from_frame): Update.
1907         (ada_add_global_exceptions): Update.
1908         (ada_print_subexp): Update.
1909         * ax-gdb.c (gen_var_ref): Update.
1910         (gen_maybe_namespace_elt): Update.
1911         (gen_expr_for_cast): Update.
1912         (gen_expr): Update.
1913         * block.h: Update.
1914         * blockframe.c (find_pc_partial_function): Update.
1915         * breakpoint.c (print_breakpoint_location): Update.
1916         (update_static_tracepoint): Update.
1917         * btrace.c (ftrace_print_function_name): Update.
1918         (ftrace_function_switched): Update.
1919         * buildsym.c (find_symbol_in_list): Update.
1920         * c-exp.y: Update.
1921         * c-typeprint.c (c_print_typedef): Update.
1922         (c_type_print_template_args): Update.
1923         * cli/cli-cmds.c (edit_command): Update.
1924         (list_command): Update.
1925         (print_sal_location): Update.
1926         * coffread.c (patch_opaque_types): Update.
1927         (process_coff_symbol): Update.
1928         (coff_read_enum_type): Update.
1929         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1930         (convert_one_symbol): Update.
1931         (hash_symname): Update.
1932         (eq_symname): Update.
1933         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1934         * compile/compile-cplus-types.c (debug_print_scope): Update.
1935         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1936         * compile/compile-object-load.c (get_out_value_type): Update.
1937         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1938         (search_symbol_list): Update.
1939         (cp_lookup_symbol_imports_or_template): Update.
1940         * cp-support.c (overload_list_add_symbol): Update.
1941         * ctfread.c (psymtab_to_symtab): Update.
1942         * dbxread.c (cp_set_block_scope): Update.
1943         * dictionary.c (iter_match_first_hashed): Update.
1944         (iter_match_next_hashed): Update.
1945         (insert_symbol_hashed): Update.
1946         (iter_match_next_linear): Update.
1947         * dictionary.h: Update.
1948         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1949         (locexpr_describe_location_piece): Update.
1950         (locexpr_describe_location_1): Update.
1951         (locexpr_generate_c_location): Update.
1952         (loclist_describe_location): Update.
1953         (loclist_generate_c_location): Update.
1954         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1955         (read_func_scope): Update.
1956         (process_enumeration_scope): Update.
1957         (new_symbol): Update.
1958         (dwarf2_const_value): Update.
1959         (dwarf2_symbol_mark_computed): Update.
1960         * eval.c (evaluate_funcall): Update.
1961         (evaluate_subexp_standard): Update.
1962         * expprint.c (print_subexp_standard): Update.
1963         (dump_subexp_body_standard): Update.
1964         * f-valprint.c (info_common_command_for_block): Update.
1965         * findvar.c (get_hosting_frame): Update.
1966         (default_read_var_value): Update.
1967         * go-lang.c (go_symbol_package_name): Update.
1968         * guile/scm-block.c (bkscm_print_block_smob): Update.
1969         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1970         (gdbscm_symbol_name): Update.
1971         (gdbscm_symbol_linkage_name): Update.
1972         (gdbscm_symbol_print_name): Update.
1973         * infcall.c (get_function_name): Update.
1974         * infcmd.c (jump_command): Update.
1975         (finish_command): Update.
1976         * infrun.c (insert_exception_resume_breakpoint): Update.
1977         * linespec.c (canonicalize_linespec): Update.
1978         (create_sals_line_offset): Update.
1979         (convert_linespec_to_sals): Update.
1980         (complete_label): Update.
1981         (find_label_symbols_in_block): Update.
1982         * m2-typeprint.c (m2_print_typedef): Update.
1983         * mdebugread.c (mdebug_reg_to_regnum): Update.
1984         (parse_symbol): Update.
1985         (mylookup_symbol): Update.
1986         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1987         (list_args_or_locals): Update.
1988         * objc-lang.c (compare_selectors): Update.
1989         (info_selectors_command): Update.
1990         (compare_classes): Update.
1991         (info_classes_command): Update.
1992         (find_imps): Update.
1993         * p-typeprint.c (pascal_print_typedef): Update.
1994         * printcmd.c (build_address_symbolic): Update.
1995         (info_address_command): Update.
1996         (print_variable_and_value): Update.
1997         * python/py-framefilter.c (extract_sym): Update.
1998         (py_print_single_arg): Update.
1999         * python/py-symbol.c (sympy_str): Update.
2000         (sympy_get_name): Update.
2001         (sympy_get_linkage_name): Update.
2002         * python/python.c (gdbpy_rbreak): Update.
2003         * record-btrace.c (btrace_get_bfun_name): Update.
2004         (btrace_call_history): Update.
2005         * rust-lang.c (rust_print_typedef): Update.
2006         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
2007         * stabsread.c (stab_reg_to_regnum): Update.
2008         (define_symbol): Update.
2009         (read_enum_type): Update.
2010         (common_block_end): Update.
2011         (cleanup_undefined_types_1): Update.
2012         (scan_file_globals): Update.
2013         * stack.c (print_frame_arg): Update.
2014         (print_frame_args): Update.
2015         (find_frame_funname): Update.
2016         (info_frame_command_core): Update.
2017         (iterate_over_block_locals): Update.
2018         (print_block_frame_labels): Update.
2019         (do_print_variable_and_value): Update.
2020         (iterate_over_block_arg_vars): Update.
2021         (return_command): Update.
2022         * symmisc.c (dump_symtab_1): Update.
2023         (print_symbol): Update.
2024         * symtab.c (eq_symbol_entry): Update.
2025         (symbol_cache_dump): Update.
2026         (lookup_language_this): Update.
2027         (find_pc_sect_line): Update.
2028         (skip_prologue_sal): Update.
2029         (symbol_search::compare_search_syms): Update.
2030         (treg_matches_sym_type_name): Update.
2031         (search_symbols): Update.
2032         (print_symbol_info): Update.
2033         (rbreak_command): Update.
2034         (completion_list_add_symbol): Update.
2035         (find_gnu_ifunc): Update.
2036         (get_symbol_address): Update.
2037         (search_module_symbols): Update.
2038         (info_module_subcommand): Update.
2039         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
2040         (SYMBOL_LINKAGE_NAME): Remove.
2041         (SYMBOL_DEMANGLED_NAME): Remove.
2042         (SYMBOL_PRINT_NAME): Remove.
2043         (SYMBOL_SEARCH_NAME): Remove.
2044         * tracepoint.c (set_traceframe_context): Update.
2045         (validate_actionline): Update.
2046         (collection_list::collect_symbol): Update.
2047         (encode_actions_1): Update.
2048         (info_scope_command): Update.
2049         (print_one_static_tracepoint_marker): Update.
2050         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
2051         * valops.c (address_of_variable): Update.
2052         (find_overload_match): Update.
2053         (find_oload_champ): Update.
2054
2055 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2056
2057         * ada-lang.c (ada_lookup_simple_minsym): Update.
2058         (ada_collect_symbol_completion_matches): Update.
2059         * ada-tasks.c (read_atcb): Update.
2060         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
2061         (amd64_windows_skip_trampoline_code): Update.
2062         * arm-tdep.c (skip_prologue_function): Update.
2063         (arm_skip_stack_protector): Update.
2064         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
2065         (arm_wince_skip_main_prologue): Update.
2066         * ax-gdb.c (gen_expr): Update.
2067         * block.c (call_site_for_pc): Update.
2068         * blockframe.c (find_pc_partial_function): Update.
2069         * breakpoint.c (set_breakpoint_location_function): Update.
2070         * btrace.c (ftrace_print_function_name): Update.
2071         (ftrace_function_switched): Update.
2072         * c-valprint.c (print_unpacked_pointer): Update.
2073         * coffread.c (coff_symfile_read): Update.
2074         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2075         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2076         * dwarf-index-write.c (write_psymbols): Update.
2077         * dwarf2loc.c (call_site_to_target_addr): Update.
2078         (func_verify_no_selftailcall): Update.
2079         (tailcall_dump): Update.
2080         (call_site_find_chain_1): Update.
2081         (dwarf_expr_reg_to_entry_parameter): Update.
2082         * elfread.c (elf_gnu_ifunc_record_cache): Update.
2083         * eval.c (evaluate_funcall): Update.
2084         (evaluate_subexp_standard): Update.
2085         (evaluate_subexp_for_sizeof): Update.
2086         * expprint.c (print_subexp_standard): Update.
2087         (dump_subexp_body_standard): Update.
2088         * frame.c (get_prev_frame_always_1): Update.
2089         * frv-tdep.c (frv_skip_main_prologue): Update.
2090         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2091         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2092         (gnuv3_get_typename_from_type_info): Update.
2093         (gnuv3_skip_trampoline): Update.
2094         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2095         * i386-tdep.c (i386_skip_main_prologue): Update.
2096         (i386_pe_skip_trampoline_code): Update.
2097         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2098         * infcall.c (get_function_name): Update.
2099         * linespec.c (minsym_found): Update.
2100         * linux-fork.c (info_checkpoints_command): Update.
2101         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2102         (m32c_m16c_pointer_to_address): Update.
2103         * maint.c (maintenance_translate_address): Update.
2104         * minsyms.c (add_minsym_to_hash_table): Update.
2105         (add_minsym_to_demangled_hash_table): Update.
2106         (lookup_minimal_symbol_mangled): Update.
2107         (lookup_minimal_symbol_demangled): Update.
2108         (lookup_minimal_symbol_linkage): Update.
2109         (lookup_minimal_symbol_text): Update.
2110         (lookup_minimal_symbol_by_pc_name): Update.
2111         (minimal_symbol_is_less_than): Update.
2112         (compact_minimal_symbols): Update.
2113         (build_minimal_symbol_hash_tables): Update.
2114         (find_solib_trampoline_target): Update.
2115         * mips-tdep.c (mips_stub_frame_sniffer): Update.
2116         (mips_skip_pic_trampoline_code): Update.
2117         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2118         * objc-lang.c (info_selectors_command): Update.
2119         (info_classes_command): Update.
2120         (find_methods): Update.
2121         (find_imps): Update.
2122         * p-valprint.c (pascal_val_print): Update.
2123         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2124         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2125         * printcmd.c (build_address_symbolic): Update.
2126         (info_symbol_command): Update.
2127         * psymtab.c (psymbol_name_matches): Update.
2128         (match_partial_symbol): Update.
2129         (lookup_partial_symbol): Update.
2130         (print_partial_symbols): Update.
2131         (sort_pst_symbols): Update.
2132         (maintenance_check_psymtabs): Update.
2133         * python/py-framefilter.c (py_print_frame): Update.
2134         * python/python.c (gdbpy_rbreak): Update.
2135         * record-btrace.c (btrace_get_bfun_name): Update.
2136         (btrace_call_history): Update.
2137         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2138         (rs6000_skip_trampoline_code): Update.
2139         * sol-thread.c (info_cb): Update.
2140         * stabsread.c (scan_file_globals): Update.
2141         * stack.c (find_frame_funname): Update.
2142         (info_frame_command_core): Update.
2143         * symmisc.c (dump_msymbols): Update.
2144         * symtab.c (symbol_natural_name): Rename to..,
2145         (general_symbol_info::natural_name): ...this.
2146         (symbol_demangled_name): Rename to...
2147         (general_symbol_info::demangled_name): ...this.
2148         (symbol_search_name): Rename to...
2149         (general_symbol_info::search_name): ...this.
2150         (symbol_matches_search_name): Update.
2151         (find_pc_sect_line): Update.
2152         (skip_prologue_sal): Update.
2153         (search_symbols): Update.
2154         (print_msymbol_info): Update.
2155         (rbreak_command): Update.
2156         (completion_list_add_msymbol): Update.
2157         (completion_list_objc_symbol): Update.
2158         (get_msymbol_address): Update.
2159         * symtab.h (struct general_symbol_info): Add member functions
2160         natural_name (), linkage_name (), print_name (), demangled_name (),
2161         and search_name ().
2162         (SYMBOL_NATURAL_NAME): Update.
2163         (symbol_natural_name): Move to a member function on general_symbol_info.
2164         (SYMBOL_DEMANGLED_NAME): Update.
2165         (symbol_demangled_name): Move to a member function on
2166         general_symbol_info.
2167         (SYMBOL_SEARCH_NAME): Update.
2168         (symbol_search_name): Move to a member function on general_symbol_info.
2169         (MSYMBOL_NATURAL_NAME): Remove.
2170         (MSYMBOL_LINKAGE_NAME): Remove.
2171         (MSYMBOL_PRINT_NAME): Remove.
2172         (MSYMBOL_DEMANGLED_NAME): Remove.
2173         (MSYMBOL_SEARCH_NAME): Remove.
2174         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2175
2176 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2177
2178         * symtab.c (create_demangled_names_hash): Use per_bfd->
2179         minimal_symbol_count for computing the initial size, if greater
2180         than our default size.
2181
2182 2019-11-22  Tom de Vries  <tdevries@suse.de>
2183
2184         * contrib/words.sh: Improve words extraction.
2185
2186 2019-11-22  Tom de Vries  <tdevries@suse.de>
2187
2188         * contrib/words.sh: Combine sed invocations.
2189
2190 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2191
2192         * Makefile.in: Update.
2193         * demangle.c: Rename to...
2194         * gdb-demangle.c: ..this.
2195         (is_cplus_marker): Change return type to bool.
2196         (_initialize_demangler): Rename to...
2197         (_initialize_gdb_demangle): ...this.
2198         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2199         * symtab.h (demangle): Remove declaration; instead include
2200         gdb-demangle.h.
2201
2202 2019-11-21  Tom Tromey  <tromey@adacore.com>
2203
2204         * gdbsupport/format.c (format_pieces): Parse %I64d.
2205         * unittests/format_pieces-selftests.c (test_windows_formats): New
2206         function.
2207         (run_tests): Call it.
2208
2209 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2210
2211         Byte reverse display of variables with DW_END_big, DW_END_little
2212         (DW_AT_endianity) dwarf attributes if different than the native
2213         byte order.
2214         * ada-lang.c (ada_value_binop):
2215         Use type_byte_order instead of gdbarch_byte_order.
2216         * ada-valprint.c (printstr):
2217         (ada_val_print_string):
2218         * ada-lang.c (value_pointer):
2219         (ada_value_binop):
2220         Use type_byte_order instead of gdbarch_byte_order.
2221         * c-lang.c (c_get_string):
2222         Use type_byte_order instead of gdbarch_byte_order.
2223         * c-valprint.c (c_val_print_array):
2224         Use type_byte_order instead of gdbarch_byte_order.
2225         * cp-valprint.c (cp_print_class_member):
2226         Use type_byte_order instead of gdbarch_byte_order.
2227         * dwarf2loc.c (rw_pieced_value):
2228         Use type_byte_order instead of gdbarch_byte_order.
2229         * dwarf2read.c (read_base_type): Handle DW_END_big,
2230         DW_END_little
2231         * f-lang.c (f_get_encoding):
2232         Use type_byte_order instead of gdbarch_byte_order.
2233         * findvar.c (default_read_var_value):
2234         Use type_byte_order instead of gdbarch_byte_order.
2235         * gdbtypes.c (check_types_equal):
2236         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2237         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2238         and TYPE_ENDIANITY_LITTLE if set.
2239         (type_byte_order): new function.
2240         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2241         (struct main_type) <flag_endianity_not_default>:
2242         New field.
2243         (type_byte_order): New function.
2244         * infcmd.c (default_print_one_register_info):
2245         Use type_byte_order instead of gdbarch_byte_order.
2246         * p-lang.c (pascal_printstr):
2247         Use type_byte_order instead of gdbarch_byte_order.
2248         * p-valprint.c (pascal_val_print):
2249         Use type_byte_order instead of gdbarch_byte_order.
2250         * printcmd.c (print_scalar_formatted):
2251         Use type_byte_order instead of gdbarch_byte_order.
2252         * solib-darwin.c (darwin_current_sos):
2253         Use type_byte_order instead of gdbarch_byte_order.
2254         * solib-svr4.c (solib_svr4_r_ldsomap):
2255         Use type_byte_order instead of gdbarch_byte_order.
2256         * stap-probe.c (stap_modify_semaphore):
2257         Use type_byte_order instead of gdbarch_byte_order.
2258         * target-float.c (target_float_same_format_p):
2259         Use type_byte_order instead of gdbarch_byte_order.
2260         * valarith.c (scalar_binop):
2261         (value_bit_index):
2262         Use type_byte_order instead of gdbarch_byte_order.
2263         * valops.c (value_cast):
2264         Use type_byte_order instead of gdbarch_byte_order.
2265         * valprint.c (generic_emit_char):
2266         (generic_printstr):
2267         (val_print_string):
2268         Use type_byte_order instead of gdbarch_byte_order.
2269         * value.c (unpack_long):
2270         (unpack_bits_as_long):
2271         (unpack_value_bitfield):
2272         (modify_field):
2273         (pack_long):
2274         (pack_unsigned_long):
2275         Use type_byte_order instead of gdbarch_byte_order.
2276         * findvar.c (unsigned_pointer_to_address):
2277         (signed_pointer_to_address):
2278         (unsigned_address_to_pointer):
2279         (address_to_signed_pointer):
2280         (default_read_var_value):
2281         (default_value_from_register):
2282         Use type_byte_order instead of gdbarch_byte_order.
2283         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2284         Use type_byte_order instead of gdbarch_byte_order.
2285         * riscv-tdep.c (riscv_print_one_register_info):
2286         Use type_byte_order instead of gdbarch_byte_order.
2287
2288 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2289
2290         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2291         (current_ui_gdb_stdin_ptr): Likewise.
2292         (current_ui_gdb_stderr_ptr): Likewise.
2293         (current_ui_gdb_stdlog_ptr): Likewise.
2294         (current_ui_current_uiout_ptr): Likewise.
2295         (gen_ret_current_ui_field_ptr): Remove.
2296
2297 2019-11-21  Tom de Vries  <tdevries@suse.de>
2298
2299         PR gdb/24956
2300         * cli/cli-script.c (execute_control_command): Only switch to
2301         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2302
2303 2019-11-19  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2306         Now static.  Change type of "name".
2307         (tui_set_win_height_command): Don't copy "arg".
2308         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2309         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2310
2311 2019-11-19  Ali Tamur <tamur@google.com>
2312
2313         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2314         "if (attr != nullptr)".
2315         (dwarf2_find_base_address): Likewise.
2316         (dwarf2_build_include_psymtabs): Likewise.
2317         (read_cutu_die_from_dwo): Likewise.
2318         (read_func_scope): Likewise.
2319         (read_call_site_scope): Likewise.
2320         (dwarf2_get_pc_bounds): Likewise.
2321         (dwarf2_record_block_ranges): Likewise.
2322         (dwarf2_add_field): Likewise.
2323         (dwarf2_add_member_fn): Likewise.
2324         (read_structure_type): Likewise.
2325         (read_enumeration_type): Likewise.
2326         (read_array_type): Likewise.
2327         (read_array_order): Likewise.
2328         (read_set_type): Likewise.
2329         (read_common_block): Likewise.
2330         (read_tag_reference_type): Likewise.
2331         (read_tag_string_type): Likewise.
2332         (read_subroutine_type): Likewise.
2333         (read_base_type): Likewise.
2334         (read_subrange_type): Likewise.
2335         (new_symbol): Likewise.
2336         (prepare_one_comp_unit): Likewise.
2337
2338 2019-11-19  Tom Tromey  <tromey@adacore.com>
2339
2340         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2341         result in error when DebugActiveProcess fails.
2342
2343 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2344             Pedro Alves  <palves@redhat.com>
2345
2346         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2347         * target.c (target_stack::push): Call 'unpush' if there's a
2348         target on top of the stack.
2349
2350 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2351
2352         * python/py-block.c (blpy_dealloc): Call tp_free.
2353         (blpy_block_syms_dealloc): Likewise.
2354         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2355         * python/py-inferior.c (infpy_dealloc): Likewise.
2356         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2357         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2358         * python/py-symbol.c (sympy_dealloc): Likewise.
2359         * python/py-symtab.c (stpy_dealloc): Likewise.
2360         * python/py-type.c (typy_iterator_dealloc): Likewise.
2361
2362 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2363
2364         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2365         constructor instead of using a class initializer.
2366
2367 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2368
2369         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2370         * configure: Regenerate.
2371         * configure.ac: Don't source common.host.
2372         * gdbsupport/common.host: Remove.
2373         * gdbsupport/mingw-strerror.c: Remove.
2374         * gdbsupport/posix-strerror.c: Rename to...
2375         * gdbsupport/safe-strerror.c: ...this.
2376
2377 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * maint.c (scoped_command_stats::print_time): Use localtime_r
2380         instead of localtime (provided through gnulib if necessary).
2381         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2382         of ctime.
2383
2384 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2385
2386         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2387         avoid compile errors.
2388
2389 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2390
2391         * config.in: Regenerate.
2392         * configure: Regenerate.
2393         * gdbsupport/common.m4: No longer check for strerror_r.
2394         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2395         POSIX version of strerror_r, now that gnulib provides it if
2396         necessary.
2397
2398 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2399
2400         * README (`configure' options): Update.
2401
2402 2019-11-14  Tom Tromey  <tromey@adacore.com>
2403
2404         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2405         expected type for the RHS if the LHS is a convenience variable.
2406
2407 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2408
2409         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2410         Provide explicit default and copy constructor.
2411
2412 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2413
2414         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2415         only call Py_INCREF (newbp) in the bppy_pending_object case.
2416
2417 2019-11-13  Tom Tromey  <tromey@adacore.com>
2418
2419         PR build/25182:
2420         * psympriv.h (partial_symbol): Remove static assert.
2421         * symtab.h (general_symbol_info, symbol): Remove static assert.
2422
2423 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * gdbsupport/format.c (format_pieces::format_pieces): Support
2426         printf 'z' size modifier.
2427         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2428         * printcmd.c (ui_printf):  Handle size_t_arg.
2429         * ui-out.c (ui_out::vmessage): Likewise.
2430         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2431         function.
2432         (run_tests): Call test_format_int_sizes.
2433
2434 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2435
2436         * ada-exp.y (write_ambiguous_var): Update.
2437         * buildsym.c (add_symbol_to_list): Update.
2438         * dwarf2read.c (read_variable): Update.
2439         (new_symbol): Update.
2440         * jit.c (finalize_symtab): Update.
2441         * language.c (language_alloc_type_symbol): Update.
2442         * symtab.c (fixup_symbol_section): Update.
2443         (initialize_objfile_symbol_1): Move code to...
2444         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2445         (allocate_symbol): Update.
2446         (allocate_template_symbol): Update.
2447         (get_symbol_address): Update.
2448         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2449         of having as a field, and add a constructor.
2450         (SYMBOL_VALUE): Update.
2451         (SYMBOL_VALUE_ADDRESS): Update.
2452         (SET_SYMBOL_VALUE_ADDRESS): Update.
2453         (SYMBOL_VALUE_BYTES): Update.
2454         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2455         (SYMBOL_BLOCK_VALUE): Update.
2456         (SYMBOL_VALUE_CHAIN): Update.
2457         (SYMBOL_LANGUAGE): Update.
2458         (SYMBOL_SECTION): Update.
2459         (SYMBOL_OBJ_SECTION): Update.
2460         (SYMBOL_SET_LANGUAGE): Update.
2461         (SYMBOL_SET_LINKAGE_NAME): Update.
2462         (SYMBOL_SET_NAMES): Update.
2463         (SYMBOL_NATURAL_NAME): Update.
2464         (SYMBOL_LINKAGE_NAME): Update.
2465         (SYMBOL_DEMANGLED_NAME): Update.
2466         (SYMBOL_SEARCH_NAME): Update.
2467         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2468         (struct symbol): Update.
2469         (struct template_symbol): Update.
2470         (struct rust_vtable_symbol): Update.
2471         * xcoffread.c (SYMBOL_DUP): Update.
2472
2473 2019-11-12  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-layout.c (show_layout): Set current_layout.
2476         (show_source_disasm_command, show_data)
2477         (show_source_or_disasm_and_command): Don't set current_layout.
2478
2479 2019-11-12  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2482
2483 2019-11-12  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-win.c (resize_message): New global.
2486         (show_tui_resize_message): New function.
2487         (tui_async_resize_screen): Print message if requested.
2488         (_initialize_tui_win): Add tui-resize-message setting.
2489         * NEWS: Add entry for new commands.
2490
2491 2019-11-11  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2494         functions.
2495
2496 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2497
2498         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2499
2500 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2503         function.
2504         * python/python-internal.h (gdbpy_lookup_static_symbols):
2505         Declare new function.
2506         * python/python.c (python_GdbMethods): Add
2507         gdb.lookup_static_symbols method.
2508         * NEWS: Mention gdb.lookup_static_symbols.
2509
2510 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2513         static block of current object file first.  Also fix typo in
2514         header comment.
2515
2516 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2517
2518         * stack.c (set_last_displayed_sal): Delete.
2519         (last_displayed_sal_valid): Delete.
2520         (last_displayed_pspace): Delete.
2521         (last_displayed_addr): Delete.
2522         (last_displayed_symtab): Delete.
2523         (last_displayed_line): Delete.
2524         (class last_displayed_symtab_info_type): New.
2525         (last_displayed_symtab_info): New static global variable.
2526         (print_frame_info): Call methods on last_displayed_symtab_info.
2527         (clear_last_displayed_sal): Update header comment, and make use of
2528         last_displayed_symtab_info.
2529         (last_displayed_sal_is_valid): Likewise.
2530         (get_last_displayed_pspace): Likewise.
2531         (get_last_displayed_addr): Likewise.
2532         (get_last_displayed_symtab): Likewise.
2533         (get_last_displayed_line): Likewise.
2534         (get_last_displayed_sal): Likewise.
2535         * stack.h (clear_last_displayed_sal): Update header comment.
2536         (last_displayed_sal_is_valid): Likewise.
2537         (get_last_displayed_pspace): Likewise.
2538         (get_last_displayed_addr): Likewise.
2539         (get_last_displayed_symtab): Likewise.
2540         (get_last_displayed_line): Likewise.
2541         (get_last_displayed_sal): Likewise.
2542
2543 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * stack.c (frame_show_address): Convert return type to bool.
2546         * stack.h (frame_show_address): Likewise, and update header
2547         comment.
2548
2549 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2552         * unittests/vec-utils-selftests.c: New file.
2553         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2554
2555 2019-11-10  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2558         (tui_highlight_win): Likewise.
2559         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2560         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2561         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2562         Don't set can_highlight.
2563
2564 2019-11-10  Tom Tromey  <tom@tromey.com>
2565
2566         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2567         Remove unused declaration.
2568
2569 2019-11-08  Tom Tromey  <tromey@adacore.com>
2570
2571         * top.c (read_command_file): Update.
2572         (command_line_input): Make return type const.
2573         * python/py-gdb-readline.c: Update.
2574         * linespec.c (decode_line_2): Update.
2575         * defs.h (command_line_input): Make return type const.
2576         * cli/cli-script.c (read_next_line): Make return type const.
2577         * ada-lang.c (get_selections): Update.
2578
2579 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2580
2581         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2582         * mi/mi-main.c (output_cores): Likewise.
2583         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2584         (linux_xfer_osdata_modules): Likewise.
2585         * remote.c (register_remote_support_xml): Likewise.
2586         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2587         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2588
2589 2019-11-06  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-interp.c: Don't include readline.h.
2592         * tui/tui-hooks.c: Don't include readline.h.
2593         * symmisc.c: Include tilde.h, not readline.h.
2594         * symfile.c: Include tilde.h, not readline.h.
2595         * source.c: Include tilde.h, not readline.h.
2596         * solib.c: Include tilde.h, not readline.h.
2597         * psymtab.c: Include tilde.h, not readline.h.
2598         * exec.c: Include tilde.h, not readline.h.
2599         * corelow.c: Include tilde.h, not readline.h.
2600         * cli/cli-dump.c: Include tilde.h, not readline.h.
2601         * cli/cli-cmds.c: Don't include readline.h.
2602
2603 2019-11-05  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2606         (tui_disassemble): Set addr_size.
2607         (tui_disasm_window::set_contents): Use addr_size.
2608
2609 2019-11-05  Tom Tromey  <tom@tromey.com>
2610
2611         * rust-lang.c (rust_language_defn): Update.
2612         * python/py-value.c (valpy_string): Call c_get_string.
2613         * p-lang.c (pascal_language_defn): Update.
2614         * opencl-lang.c (opencl_language_defn): Update.
2615         * objc-lang.c (objc_language_defn): Update.
2616         * m2-lang.c (m2_language_defn): Update.
2617         * language.c (unknown_language_defn, auto_language_defn): Update.
2618         (default_get_string): Remove.
2619         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2620         * go-lang.c (go_language_defn): Update.
2621         * f-lang.c (f_language_defn): Update.
2622         * d-lang.c (d_language_defn): Update.
2623         * c-lang.c (c_language_defn, cplus_language_defn)
2624         (asm_language_defn, minimal_language_defn): Update.
2625         * ada-lang.c (ada_language_defn): Update.
2626         * language.h (struct language_defn) <la_get_string>: Remove.
2627         (LA_GET_STRING): Remove.
2628         (default_get_string): Don't declare.
2629
2630 2019-11-05  Tom Tromey  <tom@tromey.com>
2631
2632         * tui/tui-source.h (struct tui_source_window): Inline
2633         constructor.  Remove destructor.
2634         <style_changed, m_observable>: Move to superclass.
2635         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2636         (struct tui_source_window_base): Move private members to end.
2637         <style_changed, m_observable>: Move from tui_source_window.
2638         * tui/tui-winsource.c (tui_copy_source_line): Move from
2639         tui-source.c.  Rename from copy_source_line.  Add special handling
2640         for negative line number.
2641         (tui_source_window_base::style_changed): Move from
2642         tui_source_window.
2643         (tui_source_window_base): Register observer.
2644         (~tui_source_window_base): New.
2645         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2646         rename.
2647         (tui_source_window::set_contents): Use tui_copy_source_line.
2648         (tui_source_window::tui_source_window): Move to tui-source.h.
2649         (tui_source_window::~tui_source_window): Remove.
2650         (tui_source_window::style_changed): Move to superclass.
2651         * tui/tui-disasm.c (tui_disassemble): Create string file with
2652         styling, when possible.  Add "addr_size" parameter.
2653         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2654         Don't compute maximum size.
2655         (len_without_escapes): New function
2656
2657 2019-11-05  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2660         std::string.
2661         * tui/tui-winsource.c (tui_show_source_line): Update.
2662         * tui/tui-source.c (tui_source_window::set_contents): Update.
2663         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2664
2665 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2666
2667         * symtab.h (gdb_static_assert): Put && operator at the beginning
2668         of the line instead of the end.
2669
2670 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2671
2672         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2673         and sizeof (symbol).
2674         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2675
2676 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2677
2678         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2679         * configure.host: Mark *-*-solaris2.10* obsolete.
2680         * configure.tgt: Mark Solaris < 11 obsolete.
2681         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2682         Update target triplet.
2683
2684 2019-11-01  Tom Tromey  <tromey@adacore.com>
2685
2686         * utils.c (print_sys_errmsg): Simplify.
2687
2688 2019-11-01  Tom Tromey  <tromey@adacore.com>
2689
2690         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2691
2692 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * configure: Regenerate.
2695         * configure.ac: Remove check for strerror_r.
2696         * gdbsupport/common.m4: Check for strerror_r.
2697
2698 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2699
2700         PR gdb/25124
2701
2702         * arm-tdep.c (arm_per_objfile): Rename to ...
2703         (arm_per_bfd): ... this.
2704         (arm_objfile_data_key): Rename to ...
2705         (arm_bfd_data_key): ... this.
2706         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2707         data.
2708         (arm_record_special_symbol): Likewise.
2709
2710 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2711
2712         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2713         end.
2714         * c-typeprint.c (c_print_typedef): Likewise.
2715         * f-typeprint.c (f_print_typedef): Likewise.
2716         * m2-typeprint.c (m2_print_typedef): Likewise.
2717         * p-typeprint.c (pascal_print_typedef): Likewise.
2718         * rust-lang.c (rust_print_typedef): Likewise.
2719         * symtab.c (print_symbol_info): Print a newline after calling
2720         typedef_print.
2721
2722 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * symtab.c (info_module_cmdlist): New variable.
2725         (info_module_command): New function.
2726         (search_module_symbols): New function.
2727         (info_module_subcommand): New function.
2728         (struct info_modules_var_func_options): New struct.
2729         (info_modules_var_func_options_defs): New variable.
2730         (make_info_modules_var_func_options_def_group): New function.
2731         (info_module_functions_command): New function.
2732         (info_module_variables_command): New function.
2733         (info_module_var_func_command_completer): New function.
2734         (_initialize_symtab): Register new 'info module functions' and
2735         'info module variables' commands.
2736         * symtab.h (typedef symbol_search_in_module): New typedef.
2737         (search_module_symbols): Declare new function.
2738         * NEWS: Mention new commands.
2739
2740 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2741
2742         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2743         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2744         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2745         MODULES_DOMAIN.
2746         (scan_partial_symbols): Only create partial module symbols for non
2747         declarations.
2748         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2749         and MODULES_DOMAIN.
2750         * symtab.c (search_domain_name): Likewise.
2751         (search_symbols): Likewise.
2752         (print_symbol_info): Likewise.
2753         (symtab_symbol_info): Likewise.
2754         (info_modules_command): New function.
2755         (_initialize_symtab): Register 'info modules' command.
2756         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2757         * NEWS: Mention new 'info modules' command.
2758
2759 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2760
2761         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2762         and $_gdb_maint_setting_str.
2763
2764 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2765
2766         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2767         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2768         (str_value_from_setting, gdb_setting_str_internal_fn)
2769         (gdb_maint_setting_str_internal_fn): New functions.
2770         (_initialize_cli_cmds): Define the new convenience functions.
2771         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2772         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2773
2774 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2775
2776         * agent.c (set_can_use_agent): When the setting is turned on,
2777         look up agent symbols if we don't have them yet.
2778         (agent_new_objfile): Don't look up agent symbols when the agent
2779         setting is off.
2780
2781 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2782
2783         * config.in: Regenerate.
2784
2785 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2786
2787         * configure: Regenerate.
2788         * configure.ac: Check for strerror_r.
2789         * gdbsupport/common-utils.h (safe_strerror): Change return value
2790         to const char * and document that this function is now threadsafe.
2791         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2792         thread_local and call strerror_r, if available.
2793         * utils.c (perror_string): Update.
2794         (print_sys_errmsg): Update.
2795
2796 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2797
2798         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2799         objfile_key.
2800         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2801         objfile to fetch per-bfd data.
2802         (arm_find_exidx_entry): Likewise.
2803
2804 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2805
2806         * gdbsupport/agent.c (debug_agent): Change type to bool.
2807         (use_agent): Likewise.
2808         (all_agent_symbols_look_up): Likewise.
2809         (agent_loaded_p): Change return value to bool.
2810         (agent_look_up_symbols): Update.
2811         (agent_capability_check): Change return value to bool.
2812         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2813         (debug_agent): Change type to bool.
2814         (use_agent): Likewise.
2815         (agent_capability_check): Change return value to bool.
2816
2817 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2818
2819         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2820         (build_minimal_symbol_hash_tables): Code to clear the table moved
2821         to clear_minimal_symbol_hash_tables.
2822         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2823         when needed.
2824
2825 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2826
2827         * infcmd.c: Remove includes.
2828         * infrun.c: Remove includes.
2829
2830 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2831
2832         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2833         (grow_vect): Remove declaration.
2834         (ada_type_of_array): Remove declaration.
2835         (ada_update_initial_language): Remove declaration.
2836         (ada_fold_name): Remove declaration.
2837         (ada_fill_in_ada_prototype): Remove declaration.
2838         (user_select_syms): Remove declaration.
2839         (get_selections): Remove declaration.
2840         (ada_tag_type): Remove declaration.
2841         (ada_value_tag): Remove declaration.
2842         (ada_is_others_clause): Remove declaration.
2843         (ada_in_variant): Remove declaration.
2844         (ada_value_struct_elt): Remove declaration.
2845         (ada_attribute_name): Remove declaration.
2846         (ada_system_address_type): Remove declaration.
2847         * ada-lang.c (ada_watch_location_expression): Make static.
2848         (GROW_VECT): Move here from ada-lang.h.
2849         (grow_vect): Make static.
2850         (ada_update_initial_language): Make static.
2851         (ada_fold_name): Make static.
2852         (ada_type_of_array): Make static.
2853         (encoded_ordered_before): Move up.
2854         (sort_choices): Move up.
2855         (print_signatures): Move up.
2856         (ada_print_symbol_signature): Move up.
2857         (get_selections): Move up and make static.
2858         (user_select_syms): Move up and make static.
2859         (ada_value_struct_elt): Move up and make static.
2860         (ada_tag_type): Make static.
2861         (ada_value_tag): Make static.
2862         (ada_is_others_clause): Make static.
2863         (ada_in_variant): Make static.
2864         (ada_attribute_name): Make static.
2865
2866 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2867
2868         * ada-lang.c: Remove includes.
2869         * ada-typeprint.c: Remove includes.
2870         * ada-valprint.c: Remove includes.
2871
2872 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2873
2874         * addrmap.c: Add static assertions of type size, moved from
2875         _initialize_addrmap.
2876         (_initialize_addrmap): Remove.
2877
2878 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2879
2880         * coffread.c (record_minimal_symbol): Update.
2881         (process_coff_symbol): Update.
2882         * dbxread.c (read_dbx_symtab): Update.
2883         * dwarf2read.c (add_partial_symbol): Update.
2884         (fixup_go_packaging): Update.
2885         (load_partial_dies): Update.
2886         (new_symbol): Update.
2887         * elfread.c (record_minimal_symbol): Change signature to use
2888         gdb::string_view instead of name+len.
2889         (elf_symtab_read): Update.
2890         (elf_rel_plt_read): Update.
2891         * mdebugread.c (parse_partial_symbols): Update.
2892         (handle_psymbol_enumerators): Update.
2893         (new_symbol): Update.
2894         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2895         to use gdb::string_view instead of name+len.
2896         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2897         * psympriv.h (add_psymbol_to_list): Likewise.
2898         * psymtab.c (add_psymbol_to_bcache): Likewise.
2899         (add_psymbol_to_list): Likewise.
2900         * stabsread.c (define_symbol): Update.
2901         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2902         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2903         (symbol_set_names): Likewise.
2904         * xcoffread.c (scan_xcoff_symtab): Update.
2905
2906 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2907
2908         * symtab.h (symbol_set_names): Document that copy_name must be
2909         set to true for non-nullterminated strings.
2910         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2911         linkage_name if the entry was not found and we need to demangle.
2912
2913 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2914
2915         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2916         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2917         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2918         * gdbsupport/gdb_binary_search.h: New file.
2919
2920 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2921
2922         * NEWS: Mention new --with-system-gdbinit-dir option.
2923         * config.in: Regenerate.
2924         * configure: Regenerate.
2925         * configure.ac: Add new option --with-system-gdbinit-dir.
2926         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2927         for a ".gdb" suffix.
2928         * main.c (get_init_files): Change system_gdbinit argument to
2929         a vector and return the files in SYSTEM_GDBINIT_DIR in
2930         addition to SYSTEM_GDBINIT.
2931         (captured_main_1): Update.
2932         (print_gdb_help): Update.
2933         * top.c (print_gdb_configuration): Also print the value of
2934         SYSTEM_GDBINIT_DIR.
2935
2936 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2937
2938         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2939         that takes gdb::string_view arguments.
2940
2941 2019-10-26  Tom de Vries  <tdevries@suse.de>
2942
2943         * aarch64-linux-tdep.c: Fix typos in comments.
2944         * aarch64-tdep.c: Same.
2945         * ada-lang.c: Same.
2946         * amd64-nat.c: Same.
2947         * arc-tdep.c: Same.
2948         * arch/aarch64-insn.c: Same.
2949         * block.c: Same.
2950         * breakpoint.h: Same.
2951         * btrace.h: Same.
2952         * c-varobj.c: Same.
2953         * cli/cli-decode.c: Same.
2954         * cli/cli-script.c: Same.
2955         * cli/cli-utils.h: Same.
2956         * coff-pe-read.c: Same.
2957         * coffread.c: Same.
2958         * compile/compile-cplus-symbols.c: Same.
2959         * compile/compile-object-run.c: Same.
2960         * completer.c: Same.
2961         * corelow.c: Same.
2962         * cp-support.c: Same.
2963         * demangle.c: Same.
2964         * dwarf-index-write.c: Same.
2965         * dwarf2-frame.c: Same.
2966         * dwarf2-frame.h: Same.
2967         * eval.c: Same.
2968         * frame-base.h: Same.
2969         * frame.h: Same.
2970         * gdbcmd.h: Same.
2971         * gdbtypes.h: Same.
2972         * gnu-nat.c: Same.
2973         * guile/scm-objfile.c: Same.
2974         * i386-tdep.c: Same.
2975         * i386-tdep.h: Same.
2976         * infcall.c: Same.
2977         * infcall.h: Same.
2978         * linux-nat.c: Same.
2979         * m68k-tdep.c: Same.
2980         * macroexp.c: Same.
2981         * memattr.c: Same.
2982         * mi/mi-cmd-disas.c: Same.
2983         * mi/mi-getopt.h: Same.
2984         * mi/mi-main.c: Same.
2985         * minsyms.c: Same.
2986         * nat/aarch64-sve-linux-sigcontext.h: Same.
2987         * objfiles.h: Same.
2988         * ppc-linux-nat.c: Same.
2989         * ppc-linux-tdep.c: Same.
2990         * ppc-tdep.h: Same.
2991         * progspace.h: Same.
2992         * prologue-value.h: Same.
2993         * python/py-evtregistry.c: Same.
2994         * python/py-instruction.h: Same.
2995         * record-btrace.c: Same.
2996         * record-full.c: Same.
2997         * remote.c: Same.
2998         * rs6000-tdep.c: Same.
2999         * ser-tcp.c: Same.
3000         * sol-thread.c: Same.
3001         * sparc-sol2-tdep.c: Same.
3002         * sparc64-tdep.c: Same.
3003         * stabsread.c: Same.
3004         * symfile.c: Same.
3005         * symtab.h: Same.
3006         * target.c: Same.
3007         * tracepoint.c: Same.
3008         * tui/tui-data.h: Same.
3009         * tui/tui-io.c: Same.
3010         * tui/tui-win.c: Same.
3011         * tui/tui.c: Same.
3012         * unittests/rsp-low-selftests.c: Same.
3013         * user-regs.h: Same.
3014         * utils.c: Same.
3015         * utils.h: Same.
3016         * valarith.c: Same.
3017         * valops.c: Same.
3018         * valprint.c: Same.
3019         * valprint.h: Same.
3020         * value.c: Same.
3021         * value.h: Same.
3022         * varobj.c: Same.
3023         * x86-nat.h: Same.
3024         * xtensa-tdep.c: Same.
3025
3026 2019-10-25  Ali Tamur <tamur@google.com>
3027
3028         * charset.c (find_charset_names): Reflect API change.
3029
3030 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
3031
3032         * symtab.c (struct demangled_name_entry): Change demangled name
3033         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
3034         part of the struct anymore.
3035         (symbol_set_names): No longer obstack allocate + copy the demangled
3036         name, just store the allocated name from bfd.
3037
3038 2019-10-25  Tom Tromey  <tromey@adacore.com>
3039
3040         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
3041         (bsearch_cie_cmp, add_cie): Remove.
3042         (find_cie): Reimplement.
3043         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
3044         (dwarf2_build_frame_info): Update.
3045
3046 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
3047
3048         PR gdb/25126
3049         * symfile.c (reread_symbols): Call forget_cached_source_info to
3050         clear the stale source cache.
3051
3052 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
3053
3054         * configure: Regenerate.
3055         * configure.ac: Remove code that sets python_has_threads.
3056
3057 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
3058
3059         * config.in: Regenerate.
3060         * configure: Regenerate.
3061         * configure.ac: Remove the code that uses sed to get the python
3062         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
3063
3064 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * python/py-progspace.c (pspy_block_for_pc): Return None for all
3067         error paths.
3068
3069 2019-10-23  Tom Tromey  <tom@tromey.com>
3070
3071         * arc-tdep.c: Remove ".." from include.
3072         * frv-tdep.c: Remove ".." from include.
3073         * lm32-tdep.c: Remove ".." from include.
3074         * microblaze-tdep.c: Remove ".." from include.
3075         * or1k-tdep.h: Remove ".." from include.
3076         * s12z-tdep.c: Remove ".." from include.
3077         * Makefile.in (OPCODES_CFLAGS): Add comment.
3078         (TOP_CFLAGS): New variable.
3079         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3080
3081 2019-10-23  Tom Tromey  <tom@tromey.com>
3082
3083         * Makefile.in (READLINE_DIR): Update.
3084
3085 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3086
3087         * infcall.c (call_function_by_hand_dummy): Fix the function
3088         comment.  And extract out a code section into...
3089         (reserve_stack_space): ...this new function.
3090
3091 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3092
3093         * infcall.c (value_arg_coerce): Remove an unused parameter.
3094         (call_function_by_hand_dummy): Update the call to
3095         'value_arg_coerce'.
3096
3097 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3098
3099         * infcall.c (call_function_by_hand_dummy): Refactor.
3100
3101 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3102
3103         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3104
3105 2019-10-23  Tom Tromey  <tom@tromey.com>
3106
3107         * configure: Rebuild.
3108         * configure.ac: Don't check for sigprocmask.
3109         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3110
3111 2019-10-23  Tom Tromey  <tom@tromey.com>
3112
3113         * configure: Rebuild.
3114         * acinclude.m4: Use m4_include, not sinclude.
3115
3116 2019-10-23  Tom de Vries  <tdevries@suse.de>
3117
3118         PR breakpoints/24687
3119         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3120
3121 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3122
3123         * symtab.c (struct demangled_name_entry) <language>: Change from
3124         bitfield to regular variable.
3125
3126 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3127
3128         * symtab.c (struct demangled_name_entry): Add a constructor.
3129         (free_demangled_name_entry): New function to call the destructor
3130         for demangled_name_entry.
3131         (create_demangled_names_hash): Pass free_demangled_name_entry to
3132         htab_create_alloc.
3133         (symbol_set_names): Call placement new for demangled_name_entry.
3134         * utils.c: No longer include xxhash.h here, now that fast_hash
3135         is inlined in the header.
3136         * utils.h: Instead, include it here.
3137
3138 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3139
3140         * Makefile.in: Link with libxxhash.
3141         * config.in: Regenerate.
3142         * configure: Regenerate.
3143         * configure.ac: Search for libxxhash.
3144         * utils.c (fast_hash): Use xxhash if present.
3145
3146 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3147
3148         * utils.h (fast_hash): New function.
3149         * symtab.c (hash_demangled_name_entry): Call new function
3150         fast_hash.
3151
3152 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3153
3154         * symtab.c (struct demangled_name_entry): Change type of mangled
3155         to gdb::string_view. Also adds a constructor that takes the
3156         mangled name.
3157         (hash_demangled_name_entry): Update.
3158         (eq_demangled_name_entry): Update.
3159         (free_demangled_name_entry): New function to call the destructor
3160         now that this is not a POD anymore.
3161         (create_demangled_names_hash): Pass free_demangled_name_entry to
3162         htab_create_alloc.
3163         (symbol_set_names): Update.
3164
3165 2019-10-21  Ali Tamur  <tamu@google.com>
3166
3167         * dwarf2read.c (dir_index): Change type.
3168         (file_name_index): Likewise.
3169         (line_header::include_dir_at): Change comment and implementation on
3170         whether it is DWARF 5.
3171         (line_header::is_valid_file_index): New function.
3172         (line_header::file_name_at): Change comment and implementation on
3173         whether it is DWARF 5.
3174         (line_header::file_names): Change to private field renamed as
3175         m_file_names and introduce a new accessor method.
3176         (line_header::file_names_size): New method.
3177         (line_header::include_dirs): Change to private field and rename as
3178         m_include_dirs.
3179         (dw2_get_file_names_reader): Define local var at a smaller scope and
3180         reflect API change.
3181         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3182         (process_structure_scope): Likewise.
3183         (line_header::add_include_dir): Change message and reflect renaming.
3184         (line_header::add_file_name): Likewise.
3185         (read_formatted_entries): Handle DW_FORM_data16.
3186         (dwarf_decode_line_header): Fix line header length calculation.
3187         (psymtab_include_file_name): Change comment and API.
3188         (lnp_state_machine::m_file): Update comment and reflect type change.
3189         (lnp_state_machine::record_line): Reflect type change.
3190         (dwarf_decode_lines): Reflect API change.
3191         (file_file_name): Likewise.
3192         (file_full_name): Likewise.
3193
3194 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3195
3196         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3197
3198 2019-10-21  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3201
3202 2019-10-21  Tom Tromey  <tom@tromey.com>
3203
3204         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3205         NM_H.   Use AC_CONFIG_LINKS.
3206         * configure: Rebuild.
3207         * Makefile.in (NM_H): New variable.
3208         (generated_files): Add NM_H.  Remove gcore.
3209         (nm.h, stamp-nmh): New targets.
3210
3211 2019-10-20  Tom Tromey  <tom@tromey.com>
3212
3213         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3214         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3215         obsolete comment.
3216         (put_objfile_before): Now static.
3217
3218 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3219
3220         * gdbsupport/common-utils.h (startswith): Change return type to
3221         bool.
3222
3223 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3224
3225         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3226         * breakpoint.c (bp_locations_compare): Rename to...
3227         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3228         (update_global_location_list): Use std::sort instead of qsort.
3229         * buildsym.c (compare_line_numbers): Rename to...
3230         (lte_is_less_than): ...this, and change to std::sort semantics.
3231         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3232         instead of qsort.
3233         * disasm.c (compare_lines): Rename to...
3234         (line_is_less_than): ...this, and change to std::sort semantics.
3235         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3236         of qsort.
3237         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3238         (fde_is_less_than): ...this, and change to std::sort semantics.
3239         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3240         * mdebugread.c (compare_blocks):
3241         (block_is_less_than): ...this, and change to std::sort semantics.
3242         (sort_blocks): Call std::sort instead of qsort.
3243         * objfiles.c (qsort_cmp): Rename to...
3244         (sort_cmp): ...this, and change to std::sort semantics.
3245         (update_section_map): Call std::sort instead of qsort.
3246         * remote.c (compare_pnums): Remove.
3247         (map_regcache_remote_table): Call std::sort instead of qsort.
3248         * utils.c (compare_positive_ints): Remove.
3249         * utils.h (compare_positive_ints): Remove.
3250         * xcoffread.c (compare_lte): Remove.
3251         (arrange_linetable): Call std::sort instead of qsort.
3252
3253 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3254
3255         * symfile.c (init_entry_point_info): Fix typo.
3256         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3257
3258 2019-10-18  Tom de Vries  <tdevries@suse.de>
3259
3260         * aarch64-tdep.c: Fix typos in comments.
3261         * ada-lang.c: Same.
3262         * ada-tasks.c: Same.
3263         * alpha-tdep.c: Same.
3264         * alpha-tdep.h: Same.
3265         * amd64-nat.c: Same.
3266         * amd64-windows-tdep.c: Same.
3267         * arc-tdep.c: Same.
3268         * arc-tdep.h: Same.
3269         * arch-utils.c: Same.
3270         * arm-nbsd-tdep.c: Same.
3271         * arm-tdep.c: Same.
3272         * ax-gdb.c: Same.
3273         * blockframe.c: Same.
3274         * btrace.c: Same.
3275         * c-varobj.c: Same.
3276         * coff-pe-read.c: Same.
3277         * coffread.c: Same.
3278         * cris-tdep.c: Same.
3279         * darwin-nat.c: Same.
3280         * dbxread.c: Same.
3281         * dcache.c: Same.
3282         * disasm.c: Same.
3283         * dtrace-probe.c: Same.
3284         * dwarf-index-write.c: Same.
3285         * dwarf2-frame-tailcall.c: Same.
3286         * dwarf2-frame.c: Same.
3287         * dwarf2read.c: Same.
3288         * eval.c: Same.
3289         * exceptions.c: Same.
3290         * fbsd-tdep.c: Same.
3291         * findvar.c: Same.
3292         * frame.c: Same.
3293         * frv-tdep.c: Same.
3294         * gnu-v3-abi.c: Same.
3295         * go32-nat.c: Same.
3296         * h8300-tdep.c: Same.
3297         * hppa-tdep.c: Same.
3298         * i386-linux-tdep.c: Same.
3299         * i386-tdep.c: Same.
3300         * ia64-libunwind-tdep.c: Same.
3301         * ia64-tdep.c: Same.
3302         * infcmd.c: Same.
3303         * infrun.c: Same.
3304         * linespec.c: Same.
3305         * linux-nat.c: Same.
3306         * linux-thread-db.c: Same.
3307         * machoread.c: Same.
3308         * mdebugread.c: Same.
3309         * mep-tdep.c: Same.
3310         * mn10300-tdep.c: Same.
3311         * namespace.c: Same.
3312         * objfiles.c: Same.
3313         * opencl-lang.c: Same.
3314         * or1k-tdep.c: Same.
3315         * osabi.c: Same.
3316         * ppc-linux-nat.c: Same.
3317         * ppc-linux-tdep.c: Same.
3318         * ppc-sysv-tdep.c: Same.
3319         * printcmd.c: Same.
3320         * procfs.c: Same.
3321         * record-btrace.c: Same.
3322         * record-full.c: Same.
3323         * remote-fileio.c: Same.
3324         * remote.c: Same.
3325         * rs6000-tdep.c: Same.
3326         * s12z-tdep.c: Same.
3327         * score-tdep.c: Same.
3328         * ser-base.c: Same.
3329         * ser-go32.c: Same.
3330         * skip.c: Same.
3331         * sol-thread.c: Same.
3332         * solib-svr4.c: Same.
3333         * solib.c: Same.
3334         * source.c: Same.
3335         * sparc-nat.c: Same.
3336         * sparc-sol2-tdep.c: Same.
3337         * sparc-tdep.c: Same.
3338         * sparc64-tdep.c: Same.
3339         * stabsread.c: Same.
3340         * stack.c: Same.
3341         * symfile.c: Same.
3342         * symtab.c: Same.
3343         * target-descriptions.c: Same.
3344         * target-float.c: Same.
3345         * thread.c: Same.
3346         * utils.c: Same.
3347         * valops.c: Same.
3348         * valprint.c: Same.
3349         * value.c: Same.
3350         * varobj.c: Same.
3351         * windows-nat.c: Same.
3352         * xcoffread.c: Same.
3353         * xstormy16-tdep.c: Same.
3354         * xtensa-tdep.c: Same.
3355
3356 2019-10-17  Tom Tromey  <tromey@adacore.com>
3357
3358         * configure: Rebuild.
3359         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3360         in AC_CONFIG_FILES invocation.
3361         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3362         new-style config.status invocation.
3363
3364 2019-10-17  Tom de Vries  <tdevries@suse.de>
3365
3366         * arm-nbsd-nat.c: Fix typos in comments.
3367         * arm-tdep.c: Same.
3368         * darwin-nat-info.c: Same.
3369         * dwarf2read.c: Same.
3370         * elfread.c: Same.
3371         * event-top.c: Same.
3372         * findvar.c: Same.
3373         * gdbtypes.c: Same.
3374         * hppa-tdep.c: Same.
3375         * i386-tdep.c: Same.
3376         * jit.c: Same.
3377         * main.c: Same.
3378         * mdebugread.c: Same.
3379         * moxie-tdep.c: Same.
3380         * nto-procfs.c: Same.
3381         * osabi.c: Same.
3382         * ppc-linux-tdep.c: Same.
3383         * remote.c: Same.
3384         * riscv-tdep.c: Same.
3385         * s390-tdep.c: Same.
3386         * sh-tdep.c: Same.
3387         * sparc-linux-tdep.c: Same.
3388         * sparc-nat.c: Same.
3389         * stack.c: Same.
3390         * target-descriptions.c: Same.
3391         * top.c: Same.
3392         * varobj.c: Same.
3393
3394 2019-10-16  Tom Tromey  <tom@tromey.com>
3395
3396         * objfiles.h (struct objfile) <original_name>: Now const.
3397
3398 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3399
3400         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3401         pass on to sigsetjmp's second argument.
3402         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3403
3404 2019-10-16  Keith Seitz  <keiths@redhat.com>
3405
3406         PR gdb/23567
3407         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3408         sections whose size is greater than the file size.
3409
3410 2019-10-16  Jim Wilson  <jimw@sifive.com>
3411
3412         * riscv-tdep.c (riscv_gcc_target_options): New.
3413         (riscv_gnu_triplet_regexp): New.
3414         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3415         set_gdbarch_gnu_triplet_regexp.
3416
3417 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3418
3419         * Makefile.in: Add xml-builtin.h.
3420         * features/feature_to_c.sh: Add an include for xml-builtin.h
3421         to ensure that the compiler checks that the types match.
3422         * xml-builtin.h: New file.
3423         * xml-support.c (fetch_xml_builtin): Add missing const.
3424         * xml-support.h: Remove declaration of xml_builtins.
3425
3426 2019-10-16  Tom de Vries  <tdevries@suse.de>
3427
3428         PR tdep/25096
3429         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3430         (amd64_classify_aggregate): ... here.
3431         (amd64_classify_aggregate_field): Handled fiels of nested structs
3432         recursively.
3433
3434 2019-10-16  Tom de Vries  <tdevries@suse.de>
3435
3436         PR tdep/24104
3437         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3438         that handles 'theclass'.
3439
3440 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3441
3442         * linespec.c (decode_digits_ordinary): Update comment.
3443         * make-target-delegates: No longer need to handle VEC case.
3444         * memrange.c (normalize_mem_ranges): Update comment.
3445         * namespace.c (add_using_directive): Update comment.
3446         * objc-lang.c (uniquify_strings): Update comment.
3447         * ppc-linux-nat.c (struct thread_points): Update comment.
3448         * probe.h (find_probes_in_objfile): Update comment.
3449         * target.h (enum flash_preserve_mode): Update comment.
3450         * varobj.c (varobj_restrict_range): Update comment.
3451         * varobj.h (varobj_list_children): Update comment.
3452
3453 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3454
3455         * Makefile.in: Remove references to vec.h and vec.c.
3456         * aarch64-tdep.c: No longer include vec.h.
3457         * ada-lang.c: Likewise.
3458         * ada-lang.h: Likewise.
3459         * arm-tdep.c: Likewise.
3460         * ax.h: Likewise.
3461         * breakpoint.h: Likewise.
3462         * charset.c: Likewise.
3463         * cp-support.h: Likewise.
3464         * dtrace-probe.c: Likewise.
3465         * dwarf2read.c: Likewise.
3466         * extension.h: Likewise.
3467         * gdb_bfd.c: Likewise.
3468         * gdbsupport/gdb_vecs.h: Likewise.
3469         * gdbsupport/vec.c: Remove.
3470         * gdbsupport/vec.h: Remove.
3471         * gdbthread.h: Likewise.
3472         * guile/scm-type.c: Likewise.
3473         * inline-frame.c: Likewise.
3474         * machoread.c: Likewise.
3475         * memattr.c: Likewise.
3476         * memrange.h: Likewise.
3477         * namespace.h: Likewise.
3478         * nat/linux-btrace.h: Likewise.
3479         * osdata.c: Likewise.
3480         * parser-defs.h: Likewise.
3481         * progspace.h: Likewise.
3482         * python/py-type.c: Likewise.
3483         * record-btrace.c: Likewise.
3484         * rust-exp.y: Likewise.
3485         * solib-target.c: Likewise.
3486         * stap-probe.c: Likewise.
3487         * target-descriptions.c: Likewise.
3488         * target-memory.c: Likewise.
3489         * target.h: Likewise.
3490         * varobj.c: Likewise.
3491         * varobj.h: Likewise.
3492         * xml-support.h: Likewise.
3493
3494 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3495
3496         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3497         Update for new std::vector based implementation.
3498         (process_psymtab_comp_unit_reader): Likewise.
3499         (scan_partial_symbols): Likewise.
3500         (recursively_compute_inclusions): Likewise.
3501         (compute_compunit_symtab_includes): Likewise.
3502         (process_imported_unit_die): Likewise.
3503         (queue_and_load_dwo_tu): Likewise.
3504         (follow_die_sig_1): Likewise.
3505         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3506         (typedef dwarf2_per_cu_ptr): Remove.
3507         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3508         function.
3509         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3510         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3511         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3512         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3513         std::vector.
3514
3515 2019-10-15  Tom Tromey  <tromey@adacore.com>
3516
3517         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3518         TID.
3519
3520 2019-10-15  Tom Tromey  <tromey@adacore.com>
3521
3522         * windows-nat.c (windows_nat_target::fetch_registers)
3523         (windows_nat_target::store_registers): Rename "pid" to "tid".
3524
3525 2019-10-15  Tom Tromey  <tromey@adacore.com>
3526
3527         * gdbarch.h, gdbarch.c: Rebuild.
3528         * gdbarch.sh (gcc_target_options): Change return type to
3529         std::string.
3530         * compile/compile.c (get_args): Update.
3531         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3532         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3533         std::string.
3534         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3535         std::string.
3536         * arch-utils.c (default_gcc_target_options): Return std::string.
3537         * arch-utils.h (default_gcc_target_options): Return std::string.
3538         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3539
3540 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3541
3542         * breakpoint.c (breakpoint_chain): Make static.
3543         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3544         of accessing breakpoint_chain.
3545
3546 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3547
3548         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3549         to a gdb::function_view and return value to bool.
3550         * breakpoint.h (iterate_over_breakpoints): Likewise.
3551         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3552         (pop_dummy_frame): Update.
3553         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3554         (gdbscm_breakpoints): Update.
3555         * python/py-breakpoint.c (build_bp_list): Update.
3556         (gdbpy_breakpoints): Update.
3557         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3558         Update.
3559         (bpfinishpy_handle_stop): Update.
3560         (bpfinishpy_handle_exit): Update.
3561         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3562         (svr4_update_solib_event_breakpoints): Update.
3563
3564 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3565
3566         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3567         when unwrapping single-field structs.
3568
3569 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3570
3571         * dwarf2read.c: Remove includes.
3572
3573 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3574
3575         * ui-out.c (ui_out::call_do_message): Silence
3576         -Wformat-nonliteral warning.
3577
3578 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3579
3580         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3581         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3582         include: readline/tilde.h.
3583
3584 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3585
3586         * remote.c (remote_target::get_trace_status): Remove declaration of
3587         trace_regblock_size.
3588
3589 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3590
3591         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3592         (show_user): Remove declaration of cmdlist.
3593         * cli/cli-cmds.h (max_user_call_depth): Declare.
3594         * cli/cli-script.c (execute_user_command): Remove declaration
3595         of max_user_call_depth.
3596
3597 2019-10-11  Jim Wilson  <jimw@sifive.com>
3598
3599         * gdbsupport/print-utils.h (pulongest): Fix comment.
3600         (plongest): Likewise.
3601         (phex): Add missing comment, mention leading zeros.
3602         (phex_nz): Add mention of no leading zeros to comment.
3603
3604         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3605         plongest instead of unsigned long long cast.
3606
3607 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3608
3609         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3610         for external_editor_command and gdbtk_test.
3611
3612 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3613
3614         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3615         * varobj.c (varobjdebug): Move comment to...
3616         * varobj.h (varobjdebug): ...here, and declare.
3617
3618 2019-10-09  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3621         erase_data_content.
3622
3623 2019-10-09  Tom Tromey  <tom@tromey.com>
3624
3625         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3626         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3627         * tui/tui-command.c (tui_cmd_window::resize)
3628         (tui_refresh_cmd_win): Update.
3629         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3630         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3631         * tui/tui-data.c (~tui_gen_win_info): Remove.
3632         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3633         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3634         (tui_redisplay_readline, tui_mld_flush)
3635         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3636         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3637         (tui_data_window::erase_data_content)
3638         (tui_data_item_window::rerender)
3639         (tui_data_item_window::refresh_window): Update.
3640         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3641         (box_win, tui_gen_win_info::make_window)
3642         (tui_gen_win_info::make_visible): Update.
3643         (tui_delete_win): Remove.
3644         * tui/tui-winsource.c
3645         (tui_source_window_base::do_erase_source_content): Update.
3646         (tui_show_source_line, tui_source_window_base::update_tab_width)
3647         (tui_source_window_base::update_exec_info): Update.
3648         * tui/tui-data.h (struct curses_deleter): New.
3649         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3650         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3651
3652 2019-10-09  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3655
3656 2019-10-09  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3659         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3660
3661 2019-10-09  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3664         window height directly.
3665         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3666         declare.
3667         * tui/tui-layout.c (tui_default_win_height): Remove.
3668         (tui_default_win_viewport_height): Remove.
3669
3670 2019-10-09  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui.h: Remove comments.
3673
3674 2019-10-09  Tom de Vries  <tdevries@suse.de>
3675
3676         * python/lib/gdb/printer/bound_registers.py: Use
3677         '^builtin_type_bound128' as regexp argument for
3678         add_builtin_pretty_printer.
3679
3680 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3681
3682         * guile/guile.c (guile_extension_script_ops): Remove forward
3683         declaration and mark as static.
3684         (guile_script_ops): Likewise.
3685         (extension_language_guile): Move further down in the file so
3686         it can reference the definitions for guile_{extension_,}script_ops.
3687
3688 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3689
3690         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3691         except SORTL, DFLTCC, and KDSA.
3692
3693 2019-10-08  Tom Tromey  <tromey@adacore.com>
3694
3695         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3696         (struct safe_symbol_file_add_args): Remove.
3697
3698 2019-10-08  Tom Tromey  <tromey@adacore.com>
3699
3700         * windows-nat.c: Don't include buildsym-legacy.h.
3701
3702 2019-10-08  Tom Tromey  <tromey@adacore.com>
3703
3704         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3705
3706 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3707
3708         * gdbtypes.c (overload_debug): Move comment to header.
3709         * gdbtypes.h (overload_debug): Declare.
3710         * valops.c: Remove declaration of overload_debug, instead
3711         include gdbtypes.h.
3712
3713 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3714
3715         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3716         through _().
3717         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3718         move comment...
3719         * language.h (lang_frame_mismatch_warn): ... here. Also add
3720         declaration.
3721         * top.c (lang_frame_mismatch_warn): Remove declaration.
3722         (check_frame_language_change): Pass lang_frame_mismatch_warn
3723         through _().
3724
3725 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3726
3727         * c-lang.h (vtbl_ptr_name): Declare.
3728         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3729         it from the header.
3730         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3731
3732 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3733
3734         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3735         gdb_static_assert.
3736
3737 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3738
3739         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3740         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3741         * ctfread.c: New file.
3742         * ctfread.h: New file.
3743         * elfread.c: Include ctfread.h.
3744         (struct elfinfo text_p): New member ctfsect.
3745         (elf_locate_sections): Mark CTF section.
3746         (elf_symfile_read): Call elfctf_build_psymtabs.
3747         * Makefile.in (LIBCTF): Add.
3748         (CLIBS): Use it.
3749         (CDEPS): Likewise.
3750         (DIST): Add ctfread.c.
3751
3752 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * ctfread.c (struct nextfield): Renamed to ...
3755         (struct ctf_nextfield): ... this.
3756         (struct field_info): Renamed to ...
3757         (strut ctf_field_info): ... this.
3758         (attach_fields_to_type): Update for renamed structures.
3759         (ctf_add_member_cb): Likewise.
3760         (ctf_add_enum_member_cb): Likewise.
3761         (process_struct_members): Likewise.
3762         (process_enum_type): Likewise.
3763
3764 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3765
3766         * tracectf.h: Rename, was ctf.h.
3767         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3768         * tracefile.c: Likewise.
3769         * tracepoint.c: Remove unused include ctf.h.
3770         * mi/mi-main.c: Likewise.
3771         * Makefile.in Replace ctf.c with tracectf.c.
3772
3773 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3774
3775         * version.in: Change version number to "9.0.50.DATE-git".
3776
3777 2019-10-03  Tom Tromey  <tom@tromey.com>
3778
3779         PR rust/24976:
3780         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3781
3782 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3785         cp_search_name_hash.
3786         * NEWS: Add entry about nested function support.
3787
3788 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3789             Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3792         for nested static variables when searchin VAR_DOMAIN.
3793         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3794         global scope, update comment.
3795         (add_partial_subprogram): Call add_partial_subprogram recursively
3796         for nested subroutines when processinng Fortran.
3797         (load_partial_dies): Process the child entities of a subprogram
3798         when processing Fortran.
3799         (partial_die_parent_scope): Handle building scope
3800         for Fortran nested functions.
3801         (process_die): Record that nested functions have a scope.
3802         (new_symbol): Always record Fortran subprograms on the global
3803         symbol list.
3804         (determine_prefix): How to build the prefix for Fortran
3805         subprograms.
3806
3807 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3810         have just sent the thread a SIGSTOP and are waiting for it to
3811         arrive.
3812
3813 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * btrace.c (btrace_add_pc): Remove whitespace before the template
3816         parameter in 'std::vector <...>'.
3817         (parse_xml_btrace_block): Likewise.
3818         (btrace_maint_decode_pt): Likewise.
3819         (btrace_maint_update_packets): Likewise.
3820         (btrace_maint_print_packets): Likewise.
3821         * btrace.h (struct btrace_maint_info): Likewise.
3822         * dwarf2read.c (struct type_unit_group): Likewise.
3823         (build_type_psymtabs_reader): Likewise.
3824         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3825         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3826         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3827
3828 2019-10-03  Tom de Vries  <tdevries@suse.de>
3829
3830         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3831         the first line of the help text for set/show style metadata.
3832
3833 2019-10-02  Tom Tromey  <tromey@adacore.com>
3834
3835         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3836         * gdbsupport/common-inferior.c: New file.
3837         * infcmd.c (startup_with_shell): Don't define.
3838         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3839         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3840         * inferior.h (startup_with_shell): Don't declare.
3841
3842 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3843
3844         * gdbsupport/gdb_assert.h: Include errors.h.
3845         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3846
3847 2019-10-02  Tom Tromey  <tromey@adacore.com>
3848
3849         * NEWS: Add $_ada_exception entry.
3850         * ada-lang.c (struct ada_catchpoint): Add constructor.
3851         <m_kind>: New member.
3852         (allocate_location_exception, re_set_exception): Remove
3853         "ex" parameter.
3854         (should_stop_exception): Compute $_ada_exception.
3855         (check_status_exception, print_it_exception)
3856         (print_one_exception, print_mention_exception): Remove
3857         "ex" parameter.
3858         (allocate_location_catch_exception, re_set_catch_exception)
3859         (check_status_exception, print_it_catch_exception)
3860         (print_one_catch_exception, print_mention_catch_exception)
3861         (print_recreate_catch_exception)
3862         (allocate_location_catch_exception_unhandled)
3863         (re_set_catch_exception_unhandled)
3864         (check_status_exception, print_it_catch_exception_unhandled)
3865         (print_one_catch_exception_unhandled)
3866         (print_mention_catch_exception_unhandled)
3867         (print_recreate_catch_exception_unhandled)
3868         (allocate_location_catch_assert, re_set_catch_assert)
3869         (check_status_assert, print_it_catch_assert)
3870         (print_one_catch_assert, print_mention_catch_assert)
3871         (print_recreate_catch_assert)
3872         (allocate_location_catch_handlers, re_set_catch_handlers)
3873         (check_status_handlers, print_it_catch_handlers)
3874         (print_one_catch_handlers, print_mention_catch_handlers)
3875         (print_recreate_catch_handlers): Remove.
3876         (create_ada_exception_catchpoint): Update.
3877         (initialize_ada_catchpoint_ops): Update.
3878
3879 2019-10-02  Tom Tromey  <tromey@adacore.com>
3880
3881         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3882         (create_excep_cond_exprs): Simplify exception string computation.
3883         (ada_exception_catchpoint_cond_string): Likewise.
3884
3885 2019-10-02  Tom Tromey  <tromey@adacore.com>
3886
3887         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3888         * ada-lang.c (lesseq_defined_than): Handle
3889         LOC_STATIC.
3890         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3891         parameter.
3892         (dwarf2_has_info): Likewise.
3893         (new_symbol): Set maybe_copied on symbol when
3894         appropriate.
3895         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3896         parameter.
3897         <can_copy>: New member.
3898         * elfread.c (record_minimal_symbol): Set maybe_copied
3899         on symbol when appropriate.
3900         (elf_symfile_read): Update call to dwarf2_has_info.
3901         * minsyms.c (lookup_minimal_symbol_linkage): New
3902         function.
3903         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3904         * symtab.c (get_symbol_address, get_msymbol_address):
3905         New functions.
3906         * symtab.h (get_symbol_address, get_msymbol_address):
3907         Declare.
3908         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3909         maybe_copied.
3910         (struct symbol, struct minimal_symbol) <maybe_copied>:
3911         New member.
3912
3913 2019-10-02  Tom Tromey  <tromey@adacore.com>
3914
3915         * source.c (struct current_source_location): New.
3916         (current_source_key): New global.
3917         (current_source_symtab, current_source_line)
3918         (current_source_pspace): Remove.
3919         (get_source_location): New function.
3920         (get_current_source_symtab_and_line)
3921         (set_default_source_symtab_and_line)
3922         (set_current_source_symtab_and_line)
3923         (clear_current_source_symtab_and_line, select_source_symtab)
3924         (info_source_command, print_source_lines_base)
3925         (info_line_command, search_command_helper, _initialize_source):
3926         Update.
3927
3928 2019-10-02  Tom Tromey  <tromey@adacore.com>
3929
3930         * source.c (select_source_symtab): Don't call
3931         decode_line_with_current_source.
3932
3933 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * symtab.c (lookup_global_symbol): Search global block.
3936
3937 2019-10-02  Tom Tromey  <tromey@adacore.com>
3938
3939         * coffread.c (process_coff_symbol): Update.
3940         * dwarf2read.c (var_decode_location, new_symbol): Update.
3941         * mdebugread.c (parse_symbol): Update.
3942         * objfiles.c (relocate_one_symbol): Update.
3943         * stabsread.c (define_symbol, fix_common_block)
3944         (scan_file_globals): Update.
3945         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3946         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3947         * xcoffread.c (process_xcoff_symbol): Update.
3948
3949 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3950
3951         * MAINTAINERS: Update my email address.
3952
3953 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3956         std::vector.
3957         (build_type_psymtabs_reader): Update for std::vector.
3958         (build_type_psymtab_dependencies): Likewise.
3959         * dwarf2read.h: Remove use of DEF_VEC_P.
3960         (typedef sig_type_ptr): Delete.
3961
3962 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3965         to std::vector.
3966         (btrace_maint_decode_pt): Likewise, and move allocation of the
3967         vector outside of the loop.
3968         (btrace_maint_update_packets): Update to handle change from VEC to
3969         std::vector.
3970         (btrace_maint_print_packets): Likewise.
3971         (maint_info_btrace_cmd): Likewise.
3972         * btrace.h: Remove use of DEF_VEC_O.
3973         (typedef btrace_pt_packet_s): Delete.
3974         (struct btrace_maint_info) <packets>: Change fromm VEC to
3975         std::vector.
3976         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3977
3978 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3981         make accesses into the vector constant references.
3982         (btrace_add_pc): Update for std::vector.
3983         (btrace_stitch_bts): Likewise.
3984         (parse_xml_btrace_block): Likewise.
3985         (btrace_maint_update_packets): Likewise.
3986         (btrace_maint_print_packets): Likewise.
3987         (maint_info_btrace_cmd): Likewise.
3988         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3989         std::vector.
3990         (btrace_data::empty): Likewise.
3991         (btrace_data_append): Likewise.
3992         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3993         (typedef btrace_block_s): Delete.
3994         (struct btrace_block): Add constructor.
3995         (struct btrace_data_bts) <blocks>: Change to std::vector.
3996         * nat/linux-btrace.c (perf_event_read_bts): Update for
3997         std::vector.
3998         (linux_read_bts): Likewise.
3999
4000 2019-10-01  Tom Tromey  <tom@tromey.com>
4001
4002         * cli/cli-logging.c (show_logging_filename): Use styled_string.
4003
4004 2019-10-01  Tom Tromey  <tom@tromey.com>
4005
4006         * stack.c (print_frame, info_frame_command_core): Use
4007         styled_string.
4008         * linux-thread-db.c (try_thread_db_load_1)
4009         (try_thread_db_load_from_pdir_1): Use styled_string.
4010         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
4011         (auto_load_section_scripts, info_auto_load_local_gdbinit)
4012         (maybe_print_unsupported_script_warning)
4013         (maybe_print_script_not_found_warning): Use styled_string.
4014         * ada-lang.c (user_select_syms): Use styled_string.
4015
4016 2019-10-01  Tom Tromey  <tom@tromey.com>
4017
4018         * p-lang.c (pascal_printstr): Use metadata style.
4019         * value.c (show_convenience): Use metadata style.
4020         * valprint.c (valprint_check_validity, val_print_optimized_out)
4021         (val_print_not_saved, val_print_unavailable)
4022         (val_print_invalid_address, generic_val_print, val_print)
4023         (value_check_printable, val_print_array_elements): Use metadata
4024         style.
4025         * ui-out.h (class ui_out) <field_fmt>: New overload.
4026         <do_field_fmt>: Add style parameter.
4027         * ui-out.c (ui_out::field_fmt): New overload.
4028         * typeprint.c (type_print_unknown_return_type)
4029         (val_print_not_allocated, val_print_not_associated): Use metadata
4030         style.
4031         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
4032         parameter.
4033         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
4034         * tracepoint.c (tvariables_info_1): Use metadata style.
4035         * stack.c (print_frame_arg, print_frame_info, print_frame)
4036         (info_frame_command_core): Use metadata style.
4037         * skip.c (info_skip_command): Use metadata style.
4038         * rust-lang.c (rust_print_enum): Use metadata style.
4039         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4040         metadata style.
4041         * python/py-framefilter.c (py_print_single_arg): Use metadata
4042         style.
4043         * printcmd.c (do_one_display, print_variable_and_value): Use
4044         metadata style.
4045         * p-valprint.c (pascal_val_print)
4046         (pascal_object_print_value_fields): Use metadata style.
4047         * p-typeprint.c (pascal_type_print_base): Use metadata style.
4048         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
4049         parameter.
4050         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
4051         * m2-valprint.c (m2_print_long_set): Use metadata style.
4052         * m2-typeprint.c (m2_print_type): Use metadata style.
4053         * infcmd.c (print_return_value_1): Use metadata style.
4054         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
4055         * f-valprint.c (info_common_command_for_block): Use metadata
4056         style.
4057         * f-typeprint.c (f_type_print_base): Use metadata style.
4058         * expprint.c (print_subexp_standard): Use metadata style.
4059         * cp-valprint.c (cp_print_value_fields): Use metadata style.
4060         * cli/cli-style.h (class cli_style_option): Add constructor.
4061         (metadata_style): Declare.
4062         * cli/cli-style.c (metadata_style): New global.
4063         (_initialize_cli_style): Register metadata style.
4064         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
4065         parameter.
4066         * cli-out.c (cli_ui_out::do_field_fmt): Update.
4067         * c-typeprint.c (c_type_print_base_struct_union)
4068         (c_type_print_base_1): Use metadata style.
4069         * breakpoint.c (watchpoint_value_print)
4070         (print_one_breakpoint_location): Use metadata style.
4071         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
4072         style.
4073         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4074         style.
4075         * ada-valprint.c (val_print_packed_array_elements, printstr)
4076         (print_field_values, ada_val_print_ref, ada_val_print): Use
4077         metadata style.
4078         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4079         style.
4080         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4081         style.
4082         * ada-lang.c (user_select_syms): Use metadata style.
4083
4084 2019-10-01  Tom Tromey  <tom@tromey.com>
4085
4086         * cli/cli-cmds.c (pwd_command): Style output.
4087
4088 2019-10-01  Pedro Alves  <palves@redhat.com>
4089             Tom Tromey  <tom@tromey.com>
4090
4091         * symtab.c (print_symbol_info): Use %ps.
4092         (print_msymbol_info): Use %ps.
4093         * symfile.c (symbol_file_add_with_addrs): Use %ps.
4094         * printcmd.c (print_variable_and_value): Use %ps.
4095         * macrocmd.c (show_pp_source_pos): Use %ps.
4096         * infrun.c (print_exited_reason): Use ui_out::message.
4097         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4098         (describe_other_breakpoints): Use ui_out::message and new
4099         formats.
4100         (say_where): Use new formats.
4101         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4102         and new formats.
4103
4104 2019-10-01  Pedro Alves  <palves@redhat.com>
4105             Tom Tromey  <tom@tromey.com>
4106
4107         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4108         (test_gdb_formats): New function.
4109         (run_tests): Call it.
4110         (test_format_specifier): Update.
4111         * utils.h (fputs_filtered): Update comment.
4112         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4113         (fputs_styled_unfiltered): Declare.
4114         * utils.c (fputs_styled_unfiltered): New function.
4115         (vfprintf_maybe_filtered): Add gdbfmt parameter.
4116         (vfprintf_filtered): Update.
4117         (vfprintf_unfiltered, vprintf_filtered): Update.
4118         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4119         * ui-out.h (enum ui_out_flag) <unfiltered_output,
4120         disallow_ui_out_field>: New constants.
4121         (enum class field_kind): New.
4122         (struct base_field_s, struct signed_field_s): New.
4123         (signed_field): New function.
4124         (struct string_field_s): New.
4125         (string_field): New function.
4126         (struct styled_string_s): New.
4127         (styled_string): New function.
4128         (class ui_out) <message>: Add comment.
4129         <vmessage, call_do_message>: New methods.
4130         <do_message>: Add style parameter.
4131         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4132         methods.
4133         (ui_out::message): Rewrite.
4134         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4135         parameter.
4136         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4137         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4138         gdb_extensions parameter.
4139         (class format_piece): Add parameter to constructor.
4140         (n_int_args): New field.
4141         * gdbsupport/format.c (format_pieces::format_pieces): Add
4142         gdb_extensions parameter.  Handle '*'.
4143         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4144         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
4145         vfprintf_styled_no_gdbfmt.
4146         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4147         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4148         unfiltered output.
4149         * ui-style.h (struct ui_file_style) <ptr>: New method.
4150
4151 2019-10-01  Tom Tromey  <tom@tromey.com>
4152
4153         * unittests/format_pieces-selftests.c: Update.  Add final format.
4154         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4155         empty literal pieces.
4156
4157 2019-10-01  Tom Tromey  <tom@tromey.com>
4158
4159         * ui-out.h (enum class ui_out_style_kind): Remove.
4160         (class ui_out) <field_string, field_stsream, do_field_string>:
4161         Change type of "style".
4162         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4163         (ui_out::field_string): Update.
4164         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4165         of "style".
4166         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4167         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4168         * stack.c (print_frame_arg, print_frame_info, print_frame):
4169         Update.
4170         * source.c (print_source_lines_base): Update.
4171         * solib.c (info_sharedlibrary_command): Update.
4172         * skip.c (info_skip_command): Update.
4173         * record-btrace.c (btrace_call_history_src_line)
4174         (btrace_call_history): Update.
4175         * python/py-framefilter.c (py_print_frame): Update.
4176         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4177         "style".
4178         * mi/mi-out.c (mi_ui_out::do_table_header)
4179         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4180         (mi_ui_out::do_field_string): Update.
4181         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4182         Update.
4183         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4184         "style".
4185         * cli-out.c (cli_ui_out::do_table_header)
4186         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4187         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4188         (cli_ui_out::do_field_fmt): Update.
4189         * breakpoint.c (print_breakpoint_location): Update.
4190         (update_static_tracepoint): Update.
4191
4192 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4193
4194         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4195         conversion of gdb_datadir.
4196         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4197         remove not needed c_str ().
4198
4199 2019-09-30  Ali Tamur <tamur@google.com>
4200
4201         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4202         (dwarf2_string_attr): Likewise.
4203
4204 2019-09-30  Ali Tamur <tamur@google.com>
4205
4206         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4207         (process_full_type_unit): Likewise.
4208         (dump_die_shallow): Likewise.
4209         (cu_debug_loc_section): Likewise.
4210
4211 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4212
4213         * minsyms.c (compare_minimal_symbols): Rename to...
4214         (minimal_symbol_is_less_than): ...this, and adjust to STL
4215         conventions (return bool, take arguments as references)
4216         (minimal_symbol_reader::install): Call std::sort instead
4217         of qsort.
4218
4219 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4220
4221         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4222         hash and why.
4223         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4224         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4225
4226 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4227
4228         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4229         * psympriv.h (add_psymbol_to_list): Move comment here and update
4230         it.
4231
4232 2019-09-29  Tom de Vries  <tdevries@suse.de>
4233
4234         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4235         Use $tmpdir/$(basename "$output_file").dwz instead of
4236         "${output_file}.dwz".
4237
4238 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4239
4240         PR gdb/25045
4241         * hppa-linux-nat.c: Include gdbarch.h.
4242
4243 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4244
4245         * blockframe.c (find_pc_partial_function): Change return type to bool.
4246         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4247         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4248         (stub_gnu_ifunc_resolve_name): Likewise.
4249         * symtab.c (compare_filenames_for_search): Likewise.
4250         (compare_glob_filenames_for_search): Likewise.
4251         (matching_obj_sections): Likewise.
4252         (symbol_matches_domain): Likewise.
4253         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4254         (find_line_pc): Change return type to bool.
4255         (find_line_pc_range): Likewise.
4256         (producer_is_realview): Likewise.
4257         * symtab.h (symbol_matches_domain): Likewise.
4258         (find_pc_partial_function): Likewise.
4259         (find_pc_line_pc_range): Likewise.
4260         (in_gnu_ifunc_stub): Likewise.
4261         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4262         (find_line_pc): Likewise.
4263         (find_line_pc_range): Likewise.
4264         (matching_obj_sections): Likewise.
4265         (find_line_symtab): Change out parameter to bool.
4266         (producer_is_realview): Change return type to bool.
4267         (compare_filenames_for_search): Likewise.
4268         (compare_glob_filenames_for_search): Likewise.
4269
4270 2019-09-26  Tom Tromey  <tom@tromey.com>
4271
4272         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4273         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4274         * gdb_usleep.h: Remove.
4275         * gdb_usleep.c: Remove.
4276         * utils.c: Don't include gdb_usleep.h.
4277
4278 2019-09-26  Tom Tromey  <tromey@adacore.com>
4279
4280         * python/py-type.c (type_to_type_object): Call check_typedef
4281         for stub types.
4282
4283 2019-09-26  Tom Tromey  <tom@tromey.com>
4284
4285         * utils.h (initialize_utils): Don't declare.
4286         * top.c (gdb_init): Don't call initialize_utils.
4287         * utils.c (initialize_utils): Remove.  Move contents...
4288         (_initialize_utils): ... here.
4289
4290 2019-09-25  Tom Tromey  <tom@tromey.com>
4291
4292         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4293         * utils.h (make_hex_string): Don't declare.
4294         * utils.c (make_hex_string): Remove.
4295
4296 2019-09-24  Tom de Vries  <tdevries@suse.de>
4297
4298         PR gdb/23815
4299         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4300         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4301
4302 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4303
4304         * NEWS: Mention new simulator port for PRU.
4305
4306 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4307
4308         * ada-exp.y (write_object_remaining): Update.
4309         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4310         and eliminate the static buffer.
4311         (ada_decode_symbol): Update.
4312         (ada_la_decode): Update.
4313         (ada_sniff_from_mangled_name): Update.
4314         (is_valid_name_for_wild_match): Update.
4315         (ada_lookup_name_info::matches): Update and simplify.
4316         (name_matches_regex): Update.
4317         (ada_add_global_exceptions): Update.
4318         * ada-lang.h (ada_decode): Update signature.
4319         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4320         * dwarf-index-write.c (debug_names::insert): Update.
4321
4322 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4323
4324         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4325         formatting.
4326
4327 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4328
4329         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4330         Change "nonzero" to "true" in documentation.
4331
4332 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4333
4334         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4335         (_initialize_darwin_solib): Don't set
4336         darwin_so_ops.lookup_lib_global_symbol.
4337         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4338         set_gdbarch_iterate_over_objfiles_in_search_order.
4339         (elf_lookup_lib_symbol): Rename to...
4340         (svr4_iterate_over_objfiles_in_search_order): this, and update
4341         to iterate semantics.
4342         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4343         * solib.c (solib_global_lookup): Remove.
4344         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4345         (solib_global_lookup): Remove.
4346         * symtab.c (lookup_global_or_static_symbol): Remove call to
4347         solib_global_lookup.
4348
4349 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4350
4351         * NEWS: Move entries about default MI version now being
4352         version 3, and about the GDB/MI fix for multi-location
4353         breakpoints to the "since GDB 8.3" section.
4354
4355 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4356
4357         GDB 8.3.1 released.
4358
4359 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4360
4361         * NEWS: Mention that Cell/B.E. debugging support was removed.
4362         * MAINTAINERS: Remove spu target.
4363
4364         * config/djgpp/fnchange.lst: Remove entries for removed files.
4365
4366         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4367         spu-multiarch.o, and spu-tdep.o.
4368         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4369         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4370         spu-multiarch.c, and spu-tdep.c.
4371         * spu-linux-nat.c: Remove file.
4372         * spu-multiarch.c: Remove file.
4373         * spu-tdep.c: Remove file.
4374         * spu-tdep.h: Remove file.
4375         * solib-spu.c: Remove file.
4376         * solib-spu.h: Remove file.
4377
4378         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4379         * configure.nat (spu-linux): Remove.
4380         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4381         solib-multiarch.o from gdb_target_obs.
4382         (spu*-*-*): Remove.
4383
4384         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4385         feature flag.
4386         (ppc_linux_no_features): Update.
4387         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4388         Cell/B.E. support.
4389         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4390         (tdesc_powerpc_cell64l): Likewise.
4391         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4392         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4393         Cell/B.E. support.
4394         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4395         Do not include "features/rs6000/powerpc-cell32l.c" or
4396         "features/rs6000/powerpc-cell64l.c".
4397         (ppc_linux_spu_section): Remove.
4398         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4399         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4400         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4401         (ppc_linux_spe_context_lookup): Remove.
4402         (ppc_linux_spe_context_inferior_created): Remove.
4403         (ppc_linux_spe_context_solib_loaded): Remove.
4404         (ppc_linux_spe_context_solib_unloaded): Remove.
4405         (ppc_linux_spe_context): Remove.
4406         (struct ppu2spu_cache): Remove.
4407         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4408         (struct ppu2spu_data): Remove.
4409         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4410         ppu2spu_unwind): Remove.
4411         (ppc_linux_init_abi): Remove Cell/B.E. support.
4412         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4413
4414         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4415         (rs6000/powerpc-cell64l-expedite): Likewise
4416         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4417         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4418         rs6000/powerpc-cell64l.xml.
4419         * features/rs6000/powerpc-cell32l.xml: Remove.
4420         * features/rs6000/powerpc-cell64l.xml: Likewise.
4421         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4422         * features/rs6000/powerpc-cell64l.c: Likewise.
4423         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4424         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4425         * regformats/reg-spu.dat: Remove.
4426
4427         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4428         * corelow.c (struct spuid_list): Remove.
4429         (add_to_spuid_list): Remove.
4430         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4431         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4432         (remote_protocol_features): Remove associated entries.
4433         (_initialize_remote): No longer initialize them.
4434         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4435         * linux-nat.c (SPUFS_MAGIC): Remove.
4436         (linux_proc_xfer_spu): Remove.
4437         (spu_enumerate_spu_ids): Remove.
4438         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4439         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4440         (linux_make_corefile_notes): No longer call it.
4441
4442         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4443         (cooked_write_test): Likewise.
4444
4445 2019-09-20  Tom Tromey  <tom@tromey.com>
4446
4447         * NEWS: Mention case-sensitivity of TUI commands.
4448         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4449         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4450         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4451
4452 2019-09-20  Tom Tromey  <tom@tromey.com>
4453
4454         * tui/tui-source.c (tui_source_window::set_contents): Use
4455         make_unique_xstrdup.
4456         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4457         make_unique_xstrdup.
4458
4459 2019-09-20  Tom Tromey  <tom@tromey.com>
4460
4461         * tui/tui-data.c: Remove separator comments.
4462         * tui/tui-layout.c: Remove separator comments.
4463         * tui/tui-win.c: Remove separator comments.
4464         * tui/tui-wingeneral.c: Remove separator comments.
4465
4466 2019-09-20  Tom Tromey  <tom@tromey.com>
4467
4468         * tui/tui.h (strcat_to_buf): Don't declare.
4469         * tui/tui.c (strcat_to_buf): Remove.
4470
4471 2019-09-20  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4474         from "fullname".
4475         * tui/tui-source.c (tui_source_window::set_contents)
4476         (tui_source_window::location_matches_p)
4477         (tui_source_window::maybe_update): Update.
4478
4479 2019-09-20  Tom Tromey  <tom@tromey.com>
4480
4481         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4482         Update.
4483         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4484         prefix.
4485         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4486         (tui_data_window::line_from_reg_element_no)
4487         (tui_data_window::first_reg_element_no_inline)
4488         (tui_data_window::show_registers)
4489         (tui_data_window::show_register_group)
4490         (tui_data_window::display_registers_from)
4491         (tui_data_window::display_registers_from_line)
4492         (tui_data_window::first_data_item_displayed)
4493         (tui_data_window::delete_data_content_windows)
4494         (tui_data_window::erase_data_content)
4495         (tui_data_window::do_scroll_vertical)
4496         (tui_data_window::refresh_window)
4497         (tui_data_window::check_register_values): Update.
4498
4499 2019-09-20  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4502         (struct tui_locator_window) <full_name, proc_name>: Now
4503         std::string.
4504         * tui/tui-stack.c (tui_locator_window::make_status_line)
4505         (tui_locator_window::set_locator_fullname)
4506         (tui_locator_window::set_locator_info): Update.
4507         * tui/tui-source.c (tui_source_window::set_contents)
4508         (tui_source_window::showing_source_p): Update.
4509
4510 2019-09-20  Tom Tromey  <tom@tromey.com>
4511
4512         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4513         Don't call tui_locator_win_info_ptr.
4514
4515 2019-09-20  Tom Tromey  <tom@tromey.com>
4516
4517         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4518
4519 2019-09-20  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4522         height for locator.
4523         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4524         * tui/tui-layout.c (show_source_disasm_command, show_data)
4525         (show_source_or_disasm_and_command): Use 1 as height for locator.
4526
4527 2019-09-20  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui.c (tui_enable): Update.
4530         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4531         Update.
4532         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4533         Update.
4534         * tui/tui-data.c (win_resized): Now bool.
4535         (tui_win_resized): Return bool.
4536         (tui_set_win_resized_to): Accept a bool.
4537
4538 2019-09-20  Tom Tromey  <tom@tromey.com>
4539
4540         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4541         Change type of "refresh_values_only".
4542         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4543         type of "refresh_values_only".
4544
4545 2019-09-20  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4548         std::string.
4549         (tui_disassemble): Add "pos" parameter.
4550         (tui_disasm_window::set_contents): Simplify.
4551
4552 2019-09-20  Tom Tromey  <tom@tromey.com>
4553
4554         * tui/tui-winsource.h (struct tui_source_window_base)
4555         <show_source_content>: Now private.
4556         * tui/tui-winsource.c
4557         (tui_source_window_base::show_source_content): Don't handle empty
4558         content case.
4559
4560 2019-09-20  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui-layout.c (show_source_disasm_command)
4563         (show_source_or_disasm_and_command): Don't call
4564         show_source_content.
4565
4566 2019-09-20  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4569         Declare.
4570         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4571         from tui_make_status_line.
4572         (tui_locator_window::rerender): Update.
4573
4574 2019-09-20  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4577         (tui_locator_window::rerender): Update.
4578
4579 2019-09-20  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-winsource.h (struct tui_source_window_base)
4582         <~tui_source_window_base>: Don't declare.
4583         <fullname>: Remove.
4584         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4585         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4586         member.
4587         * tui/tui-source.c (tui_source_window::set_contents): Update.
4588         (tui_source_window::location_matches_p)
4589         (tui_source_window::maybe_update): Update.
4590
4591 2019-09-20  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-winsource.h (~tui_source_element): Remove.
4594         (tui_source_element): Update.
4595         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4596         * tui/tui-winsource.c (tui_show_source_line): Update.
4597         * tui/tui-source.c (tui_source_window::set_contents): Update.
4598         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4599
4600 2019-09-20  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4603         declare.
4604         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4605         tui_clear_source_windows_detail.
4606         * tui/tui-winsource.h (struct tui_source_window_base)
4607         <clear_detail>: Don't declare.
4608         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4609         Remove.
4610         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4611
4612 2019-09-20  Tom Tromey  <tromey@adacore.com>
4613
4614         PR ada/24919:
4615         * block.c (contained_in): Fix final return value.
4616
4617 2019-09-20  Alan Modra  <amodra@gmail.com>
4618
4619         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4620         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4621         (read_indirect_string_from_dwz): Use bfd accessor.
4622         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4623         * machoread.c (macho_symfile_read_all_oso): Likewise.
4624         * solib.c (solib_bfd_open): Likewise.
4625
4626 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4627
4628         * eval.c: Move declaration of overload_resolution to...
4629         * value.h: ...here.
4630
4631 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4632
4633         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4634         * arm-linux-tdep.c: Likewise.
4635         * arm-nbsd-nat.c: Likewise.
4636         * arm-tdep.h: Declare arm_apcs_32.
4637         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4638
4639 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4640
4641         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4642         * dwarf2read.h: Declare dwarf_always_disassemble.
4643
4644 2019-09-19  Tom de Vries  <tdevries@suse.de>
4645
4646         PR gdb/25009
4647         * source-cache.c (source_cache::ensure): Catch exception thrown during
4648         construction of the highlighter.
4649
4650 2019-09-18  Alan Modra  <amodra@gmail.com>
4651
4652         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4653         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4654         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4655         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4656         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4657         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4658         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4659         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4660         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4661         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4662         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4663         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4664         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4665         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4666         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4667         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4668         * mi/mi-interp.c: Update throughout for bfd section macro and
4669         function changes.
4670         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4671         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4672
4673 2019-09-18  Tom Tromey  <tom@tromey.com>
4674
4675         * NEWS: Add entry.
4676         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4677         call rl_initialize.
4678         (tui_enable): Do not call rl_initialize.
4679
4680 2019-09-18  Christian Groessler  <chris@groessler.org>
4681
4682         * alpha-linux-nat.c: Include gdbarch.h.
4683
4684 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4685
4686         * ui-file.c: Include cli/cli-style.h.
4687         (term_cli_styling): Remove cli_styling declaration.
4688
4689 2019-09-18  Alan Modra  <amodra@gmail.com>
4690
4691         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4692         to bfd_asymbol_section.
4693
4694 2019-09-18  Alan Modra  <amodra@gmail.com>
4695
4696         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4697         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4698         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4699
4700 2019-09-18  Alan Modra  <amodra@gmail.com>
4701
4702         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4703         * spu-linux-nat.c (spu_bfd_open): Likewise.
4704
4705 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4706
4707         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4708         to bool to match definition in dwarf2read.c.
4709
4710 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4711
4712         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4713         (print_signatures): Likewise.
4714         (trust_pad_over_xvs): Likewise.
4715         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4716         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4717         * arm-linux-nat.c (arm_apcs_32): Likewise.
4718         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4719         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4720         * arm-tdep.c (arm_debug): Likewise.
4721         (arm_apcs_32): Likewise.
4722         * auto-load.c (debug_auto_load): Likewise.
4723         (auto_load_gdb_scripts): Likewise.
4724         (global_auto_load): Likewise.
4725         (auto_load_local_gdbinit): Likewise.
4726         (auto_load_local_gdbinit_loaded): Likewise.
4727         * auto-load.h (global_auto_load): Likewise.
4728         (auto_load_local_gdbinit): Likewise.
4729         (auto_load_local_gdbinit_loaded): Likewise.
4730         * breakpoint.c (disconnected_dprintf): Likewise.
4731         (breakpoint_proceeded): Likewise.
4732         (automatic_hardware_breakpoints): Likewise.
4733         (always_inserted_mode): Likewise.
4734         (target_exact_watchpoints): Likewise.
4735         (_initialize_breakpoint): Update.
4736         * breakpoint.h (target_exact_watchpoints): Change to bool.
4737         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4738         * cli/cli-cmds.c (trace_commands): Likewise.
4739         * cli/cli-cmds.h (trace_commands): Likewise.
4740         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4741         to bool*.
4742         * cli/cli-logging.c (logging_overwrite): Change to bool.
4743         (logging_redirect): Likewise.
4744         (debug_redirect): Likewise.
4745         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4746         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4747         to bool.
4748         <boolean_option_def>: Update.
4749         (struct flag_option_def): Change default type of Context to bool
4750         from int.
4751         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4752         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4753         (get_setshow_command_value_string): Likewise.
4754         * cli/cli-style.c (cli_styling): Change to bool.
4755         (source_styling): Likewise.
4756         * cli/cli-style.h (source_styling): Likewise.
4757         (cli_styling): Likewise.
4758         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4759         to bool.
4760         * command.h (var_types): Update comment.
4761         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4762         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4763         bool.
4764         (debug_compile_cplus_scopes): Likewise.
4765         * compile/compile-internal.h (compile_debug): Likewise.
4766         * compile/compile.c (compile_debug): Likewise.
4767         (struct compile_options) <raw>: Likewise.
4768         * cp-support.c (catch_demangler_crashes): Likewise.
4769         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4770         (usr_cmd_cris_dwarf2_cfi): Likewise.
4771         * csky-tdep.c (csky_debug): Likewise.
4772         * darwin-nat.c (enable_mach_exceptions): Likewise.
4773         * dcache.c (dcache_enabled_p): Likewise.
4774         * defs.h (info_verbose): Likewise.
4775         * demangle.c (demangle): Likewise.
4776         (asm_demangle): Likewise.
4777         * dwarf-index-cache.c (debug_index_cache): Likewise.
4778         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4779         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4780         * dwarf2read.c (check_physname): Likewise.
4781         (use_deprecated_index_sections): Likewise.
4782         (dwarf_always_disassemble): Likewise.
4783         * eval.c (overload_resolution): Likewise.
4784         * event-top.c (set_editing_cmd_var): Likewise.
4785         (exec_done_display_p): Likewise.
4786         * event-top.h (set_editing_cmd_var): Likewise.
4787         (exec_done_display_p): Likewise.
4788         * exec.c (write_files): Likewise.
4789         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4790         (debug_fbsd_nat): Likewise.
4791         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4792         Likewise.
4793         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4794         <backtrace_past_entry> Likewise.
4795         * gdb-demangle.h (demangle): Likewise.
4796         (asm_demangle): Likewise.
4797         * gdb_bfd.c (bfd_sharing): Likewise.
4798         * gdbcore.h (write_files): Likewise.
4799         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4800         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4801         * gdbthread.h (print_thread_events): Likewise.
4802         * gdbtypes.c (opaque_type_resolution): Likewise.
4803         (strict_type_checking): Likewise.
4804         * gnu-nat.c (gnu_debug_flag): Likewise.
4805         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4806         * guile/scm-param.c (pascm_variable): Add boolval.
4807         (add_setshow_generic): Update.
4808         (pascm_param_value): Update.
4809         (pascm_set_param_value_x): Update.
4810         * hppa-tdep.c (hppa_debug): Change to bool..
4811         * infcall.c (may_call_functions_p): Likewise.
4812         (coerce_float_to_double_p): Likewise.
4813         (unwind_on_signal_p): Likewise.
4814         (unwind_on_terminating_exception_p): Likewise.
4815         * infcmd.c (startup_with_shell): Likewise.
4816         * inferior.c (print_inferior_events): Likewise.
4817         * inferior.h (startup_with_shell): Likewise.
4818         (print_inferior_events): Likewise.
4819         * infrun.c (step_stop_if_no_debug): Likewise.
4820         (detach_fork): Likewise.
4821         (debug_displaced): Likewise.
4822         (disable_randomization): Likewise.
4823         (non_stop): Likewise.
4824         (non_stop_1): Likewise.
4825         (observer_mode): Likewise.
4826         (observer_mode_1): Likewise.
4827         (set_observer_mode): Update.
4828         (sched_multi): Change to bool.
4829         * infrun.h (debug_displaced): Likewise.
4830         (sched_multi): Likewise.
4831         (step_stop_if_no_debug): Likewise.
4832         (non_stop): Likewise.
4833         (disable_randomization): Likewise.
4834         * linux-tdep.c (use_coredump_filter): Likewise.
4835         (dump_excluded_mappings): Likewise.
4836         * linux-thread-db.c (auto_load_thread_db): Likewise.
4837         (check_thread_db_on_load): Likewise.
4838         * main.c (captured_main_1): Update.
4839         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4840         xx2_opt, boolean_opt>: Change to bool.
4841         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4842         * maint.c (maintenance_profile_p): Likewise.
4843         (per_command_time): Likewise.
4844         (per_command_space): Likewise.
4845         (per_command_symtab): Likewise.
4846         * memattr.c (inaccessible_by_default): Likewise.
4847         * mi/mi-main.c (mi_async): Likewise.
4848         (mi_async_1): Likewise.
4849         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4850         * nat/fork-inferior.h (startup_with_shell): Likewise.
4851         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4852         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4853         * nios2-tdep.c (nios2_debug): Likewise.
4854         * or1k-tdep.c (or1k_debug): Likewise.
4855         * parse.c (parser_debug): Likewise.
4856         * parser-defs.h (parser_debug): Likewise.
4857         * printcmd.c (print_symbol_filename): Likewise.
4858         * proc-api.c (procfs_trace): Likewise.
4859         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4860         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4861         (set_parameter_value): Update.
4862         (add_setshow_generic): Update.
4863         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4864         to bool*.
4865         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4866         int*.
4867         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4868         * record-btrace.c (record_btrace_target::store_registers): Update.
4869         * record-full.c (record_full_memory_query): Change to bool.
4870         (record_full_stop_at_limit): Likewise.
4871         * record-full.h (record_full_memory_query): Likewise.
4872         * remote-notif.c (notif_debug): Likewise.
4873         * remote-notif.h (notif_debug): Likewise.
4874         * remote.c (use_range_stepping): Likewise.
4875         (interrupt_on_connect): Likewise.
4876         (remote_break): Likewise.
4877         * ser-tcp.c (tcp_auto_retry): Likewise.
4878         * ser-unix.c (serial_hwflow): Likewise.
4879         * skip.c (debug_skip): Likewise.
4880         * solib-aix.c (solib_aix_debug): Likewise.
4881         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4882         (spu_auto_flush_cache_p): Likewise.
4883         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4884         Likewise.
4885         (struct info_print_options) <quiet>: Likewise.
4886         * symfile-debug.c (debug_symfile): Likewise.
4887         * symfile.c (auto_solib_add): Likewise.
4888         (separate_debug_file_debug): Likewise.
4889         * symfile.h (auto_solib_add): Likewise.
4890         (separate_debug_file_debug): Likewise.
4891         * symtab.c (basenames_may_differ): Likewise.
4892         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4893         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4894         (struct info_types_options) <quiet>: Likewise.
4895         * symtab.h (demangle): Likewise.
4896         (basenames_may_differ): Likewise.
4897         * target-dcache.c (stack_cache_enabled_1): Likewise.
4898         (code_cache_enabled_1): Likewise.
4899         * target.c (trust_readonly): Likewise.
4900         (may_write_registers): Likewise.
4901         (may_write_memory): Likewise.
4902         (may_insert_breakpoints): Likewise.
4903         (may_insert_tracepoints): Likewise.
4904         (may_insert_fast_tracepoints): Likewise.
4905         (may_stop): Likewise.
4906         (auto_connect_native_target): Likewise.
4907         (target_stop_and_wait): Update.
4908         (target_async_permitted): Change to bool.
4909         (target_async_permitted_1): Likewise.
4910         (may_write_registers_1): Likewise.
4911         (may_write_memory_1): Likewise.
4912         (may_insert_breakpoints_1): Likewise.
4913         (may_insert_tracepoints_1): Likewise.
4914         (may_insert_fast_tracepoints_1): Likewise.
4915         (may_stop_1): Likewise.
4916         * target.h (target_async_permitted): Likewise.
4917         (may_write_registers): Likewise.
4918         (may_write_memory): Likewise.
4919         (may_insert_breakpoints): Likewise.
4920         (may_insert_tracepoints): Likewise.
4921         (may_insert_fast_tracepoints): Likewise.
4922         (may_stop): Likewise.
4923         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4924         (make_thread_apply_all_options_def_group): Change argument from int*
4925         to bool*.
4926         (thread_apply_all_command): Update.
4927         (print_thread_events): Change to bool.
4928         * top.c (confirm): Likewise.
4929         (command_editing_p): Likewise.
4930         (history_expansion_p): Likewise.
4931         (write_history_p): Likewise.
4932         (info_verbose): Likewise.
4933         * top.h (confirm): Likewise.
4934         (history_expansion_p): Likewise.
4935         * tracepoint.c (disconnected_tracing): Likewise.
4936         (circular_trace_buffer): Likewise.
4937         * typeprint.c (print_methods): Likewise.
4938         (print_typedefs): Likewise.
4939         * utils.c (debug_timestamp): Likewise.
4940         (sevenbit_strings): Likewise.
4941         (pagination_enabled): Likewise.
4942         * utils.h (sevenbit_strings): Likewise.
4943         (pagination_enabled): Likewise.
4944         * valops.c (overload_resolution): Likewise.
4945         * valprint.h (struct value_print_options) <prettyformat_arrays,
4946         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4947         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4948         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4949         Likewise.
4950         * windows-nat.c (new_console): Likewise.
4951         (cygwin_exceptions): Likewise.
4952         (new_group): Likewise.
4953         (debug_exec): Likewise.
4954         (debug_events): Likewise.
4955         (debug_memory): Likewise.
4956         (debug_exceptions): Likewise.
4957         (useshell): Likewise.
4958         * windows-tdep.c (maint_display_all_tib): Likewise.
4959         * xml-support.c (debug_xml): Likewise.
4960
4961 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4962
4963         * source.c (prepare_path_for_appending): New function.
4964         (openp): Make use of new function.
4965         (find_and_open_source): Search for the compilation directory and
4966         source file as a relative path beneath the directory search path.
4967
4968 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * source-cache.c (source_cache::get_line_charpos): Catch
4971         exceptions and return false, this matches the behaviour documented
4972         in the header file.
4973
4974 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4975
4976         * ada-tasks.c (info_task): Remove quoting of the task's name.
4977
4978 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4979
4980         * symfile.c (auto_solib_add): Replace comment with a reference
4981         to the header file.
4982
4983 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4984
4985         * NEWS: Mention that gdb can now be compiled with Python 3
4986         on Windows.
4987
4988 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * maint.c (maint_print_section_data::maint_print_section_data):
4991         Force use of 'float log10 (float)' by casting the argument to
4992         float.
4993
4994 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * maint.c: Add 'cmath' include.
4997         (struct maint_print_section_data): New structure.
4998         (print_section_index): New function.
4999         (print_bfd_section_info): Add header comment, small whitespace
5000         cleanup, and update to call new print_section_index function.
5001         (print_objfile_section_info): Likewise.
5002         (maint_obj_section_from_bfd_section): New function.
5003         (print_bfd_section_info_maybe_relocated): New function.
5004         (maintenance_info_sections): Add header comment, always use
5005         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
5006
5007 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
5010         inner scope, add check that the objfile has psymtabs before
5011         checking psymtabs_addrmap.
5012         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
5013
5014 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5015
5016         * NEWS: Announce that Ada task names are now shown at more places,
5017         and between quotes (except in info task output).
5018         * gdb/ada-tasks.c (task_to_str): New function.
5019         (display_current_task_id): Call task_to_str.
5020         (task_command_1): Likewise.
5021         (print_ada_task_info): In non-mi mode, Properly align headers and data
5022         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
5023
5024 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5025
5026         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
5027         prstatus.pr_lwp.pr_info instead of making it up.
5028
5029 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5030
5031         * auto-load.c (auto_load_expand_dir_vars): Update.
5032         * defs.h (gdb_datadir): Change to std::string.
5033         (python_libdir): Likewise.
5034         (relocate_gdb_directory): Change return type to std::string.
5035         * guile/guile.c (gdbscm_data_directory): Update.
5036         (initialize_scheme_side): Update.
5037         * jit.c (jit_reader_dir): Change to std::string.
5038         (jit_reader_load_command): Update.
5039         * main.c (gdb_datadir): Change to std::string.
5040         (python_libdir): Likewise.
5041         (set_gdb_data_directory): Update.
5042         (relocate_path): Change to return std::string.
5043         (relocate_gdb_directory): Change to return std::string.
5044         (relocate_gdbinit_path_maybe_in_datadir): Update.
5045         (captured_main_1): Update.
5046         * python/python.c (do_start_initialization): Update.
5047         * top.c (show_gdb_datadir): Update.
5048         * xml-syscall.c (xml_init_syscalls_info): Update.
5049         (init_syscalls_info): Update.
5050
5051 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5052
5053         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
5054         out of get_init_files.
5055         (get_init_files): Update.
5056
5057 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5058
5059         * main.c (get_init_files): Change to use std::string.
5060         (captured_main_1): Update.
5061         (print_gdb_help): Update.
5062
5063 2019-09-11  Ali Tamur  <tamur@google.com>
5064
5065         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
5066         implementation.
5067
5068 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5069
5070         * dbxread.c (read_dbx_symtab): Update.
5071         * dwarf2read.c (load_partial_dies): Update.
5072         * mdebugread.c (parse_partial_symbols): Update.
5073         (handle_psymbol_enumerators): Update.
5074         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5075         * psymtab.c (add_psymbol_to_bcache): Likewise.
5076         (add_psymbol_to_list): Likewise.
5077         * symtab.c (symbol_set_names): Likewise.
5078         * symtab.h (symbol_set_names): Likewise.
5079         * xcoffread.c (scan_xcoff_symtab): Update.
5080
5081 2019-09-11  Tom Tromey  <tom@tromey.com>
5082
5083         * symfile-mem.c (symbol_file_add_from_memory): Use
5084         bfd_set_filename.
5085         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5086         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5087
5088 2019-09-10  Tom Tromey  <tromey@adacore.com>
5089
5090         * dwarf-index-write.c (write_psymbols): Extend error message.
5091         (debug_names::insert): Add Ada code.
5092         (debug_names::write_psymbols): Remove Ada check.
5093         (debug_names) <m_string_obstack>: New member.
5094         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5095         (gdb_index_symbol_name_matcher::matches): Remove.
5096         (mapped_index_base::find_name_components_bounds): Add "lang"
5097         parameter.
5098         (mapped_index_base::build_name_components): Also split names
5099         according to Ada syntax.
5100         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
5101         type of "match_callback".
5102         (check_match, check_find_bounds_finds)
5103         (dw2_expand_symtabs_matching): Update.
5104         (dw2_debug_names_iterator): Add new constructor.
5105         (dw2_debug_names_map_matching_symbols): New function.
5106         (dw2_debug_names_expand_symtabs_matching): Update.
5107         (dwarf2_debug_names_functions): Use
5108         dw2_debug_names_map_matching_symbols.
5109
5110 2019-09-10  Tom Tromey  <tromey@adacore.com>
5111
5112         * dwarf2read.c (dw2_get_file_names_reader): Add the
5113         CU's file name to the results.
5114
5115 2019-09-10  Tom Tromey  <tromey@adacore.com>
5116
5117         * ada-lang.c (add_nonlocal_symbols): Combine calls to
5118         map_matching_symbols.  Update.
5119         * dwarf2read.c (dw2_map_matching_symbols): Update.
5120         * psymtab.c (match_partial_symbol): Change type; update.
5121         (psym_map_matching_symbols): Likewise.
5122         * symfile-debug.c (debug_qf_map_matching_symbols): Change
5123         type; update.
5124         * symfile.h (struct quick_symbol_functions)
5125         <map_matching_symbols>: Change "name" to be a lookup_name_info.
5126         Remove "match".
5127
5128 2019-09-10  Tom Tromey  <tromey@adacore.com>
5129
5130         * psymtab.c (map_block): Remove.
5131         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5132         * symtab.c (iterate_over_symbols_terminated): New function.
5133         * symtab.c (iterate_over_symbols_terminated): Declare.
5134
5135 2019-09-10  Tom Tromey  <tromey@adacore.com>
5136
5137         * ada-lang.c (ada_iterate_over_symbols): Return bool.
5138         * language.h (struct language_defn) <la_iterate_over_symbols>:
5139         Return bool.
5140         * symtab.c (iterate_over_symbols): Return bool.
5141         * symtab.h (iterate_over_symbols): Return bool.
5142
5143 2019-09-10  Tom Tromey  <tromey@adacore.com>
5144
5145         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5146         (add_nonlocal_symbols): Update.
5147         * dwarf2read.c (dw2_map_matching_symbols): Change type.
5148         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5149         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5150         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5151         Change type of "callback".  Remove "data".
5152
5153
5154 2019-09-09  Ali Tamur  <tamur@google.com>
5155
5156         * dwarf2read.c (comp_unit_head): Update comment.
5157         (dwarf2_dwo_name): New function declaration.
5158         (dwarf_unit_type_name): New function declaration.
5159         (read_comp_unit_head): Add support for new compilation units,
5160         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5161         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5162         (currently named as "signature") in their header. Also clarify error
5163         messages.
5164         (lookup_dwo_id): New function. Returns the dwo id of the given
5165         compile unit.
5166         (lookup_dwo_unit): Use the new lookup_dwo_id function.
5167         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5168         functions.
5169         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5170         (dwarf2_dwo_name): Get the dwo name if present.
5171         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5172         purposes.
5173
5174 2019-09-09  Tom Tromey  <tom@tromey.com>
5175
5176         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5177
5178 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5179
5180         * python/python.c (do_start_initialization): Make progname_copy static,
5181         to avoid a leak report.
5182
5183 2019-09-08  Tom Tromey  <tom@tromey.com>
5184
5185         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5186
5187 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5188
5189         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5190         Change type to gdb::optional<block_enum>.
5191         (dw2_symtab_iter_init): Change block_index parameter type
5192         to gdb::optional<block_enum>.
5193         (dw2_lookup_symbol): Change block_index parameter
5194         type to block_enum.c
5195         (dw2_debug_names_lookup_symbol): Likewise.
5196         * psymtab.c (psym_lookup_symbol): Likewise.
5197         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5198         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5199         Likewise.
5200
5201 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5202
5203         * defs.h (relocate_gdb_directory): Change int to bool in
5204         signature and rename flag to relocatable.
5205         * main.c (relocate_path): Likewise.
5206         (relocate_gdb_directory): Likewise.
5207
5208 2019-09-06  Alan Modra  <amodra@gmail.com>
5209
5210         * coffread.c (coff_symfile_read): Constify filename variable.
5211         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5212         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5213         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5214         * solib.c (reload_shared_libraries_1): Likewise.
5215         * symfile.c (reread_symbols): Likewise.
5216         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5217         * solib-darwin.c (darwin_bfd_open): Likewise.
5218         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5219
5220 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5221
5222         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5223         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5224
5225 2019-09-03  Tom Tromey  <tromey@adacore.com>
5226
5227         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5228         types.
5229         (has_negatives): Unbias a range type bound.
5230         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5231         * gdbtypes.c (operator==): Handle new field.
5232         (create_range_type): Add "bias" parameter.
5233         (create_static_range_type, resolve_dynamic_range): Update.
5234         * gdbtypes.h (struct range_bounds) <bias>: New member.
5235         (create_range_type): Add bias parameter.
5236         * printcmd.c (print_scalar_formatted): Unbias range types.
5237         * value.c (unpack_long): Unbias range types.
5238         (pack_long): Bias range types.
5239
5240 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5241
5242         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5243         probe arguments.
5244
5245 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5248         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5249         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5250         (compile_probe_arg): Likewise.
5251         * probe.h (get_argument_count): Likewise.
5252         * solib-svr4.c (solib_event_probe_action): Likewise.
5253         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5254
5255 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5256
5257         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5258         code to here...
5259         (svr4_create_solib_event_breakpoints): ...from here.
5260
5261 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5262
5263         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5264         suffix from warning message.
5265
5266 2019-08-30  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-winsource.h (struct tui_source_window_base)
5269         <refresh_all>: Don't declare.
5270         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5271         Remove.
5272         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5273         tui_show_locator_content.
5274         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5275         declare.
5276         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5277         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5278         declare.
5279
5280 2019-08-30  Tom Tromey  <tom@tromey.com>
5281
5282         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5283
5284 2019-08-30  Tom Tromey  <tom@tromey.com>
5285
5286         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5287         Remove unnecessary forward declarations.
5288
5289 2019-08-30  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5292         rerender.
5293         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5294         tui_show_locator_content.
5295
5296 2019-08-30  Tom Tromey  <tom@tromey.com>
5297
5298         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5299         (tui_locator_window::rerender): Rewrite using body of previous
5300         tui_show_locator_content.
5301
5302 2019-08-30  Tom Tromey  <tom@tromey.com>
5303
5304         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5305         set_locator_fullname>: New methods.
5306         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5307         Rename from tui_set_locator_fullname.
5308         (tui_locator_window::set_locator_info): Rename from
5309         tui_set_locator_info.  Return bool.
5310         (tui_update_locator_fullname, tui_show_frame_info): Update.
5311
5312 2019-08-30  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5315
5316 2019-08-30  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5319         call touchwin.
5320
5321 2019-08-30  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-wingeneral.c (box_win): Assume win_info and
5324         win_info->handle cannot be NULL.
5325
5326 2019-08-30  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5329         refresh_window>: Declare.
5330         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5331         resize.
5332         (tui_data_item_window::rerender): Rename from
5333         tui_display_register.
5334         (tui_data_item_window::refresh_window): New method.
5335         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5336         no-op.
5337
5338 2019-08-30  Tom Tromey  <tom@tromey.com>
5339
5340         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5341         regs_column_count, current_group>: Move later.  Now private.
5342         <get_current_group>: New method.
5343         * tui/tui-regs.c (tui_reg_command): Update.
5344         * tui/tui-layout.c (tui_set_layout): Update.
5345
5346 2019-08-30  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5349         (tui_data_window::rerender): Don't call
5350         check_and_display_highlight_if_needed.
5351         (tui_data_window::refresh_all): Remove call to
5352         erase_data_content.
5353
5354 2019-08-30  Tom Tromey  <tom@tromey.com>
5355
5356         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5357         (tui_data_window::display_registers_from)
5358         (tui_data_window::display_reg_element_at_line)
5359         (tui_data_window::display_registers_from_line): Remove checks of
5360         "empty".
5361
5362 2019-08-30  Tom Tromey  <tom@tromey.com>
5363
5364         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5365         Don't declare.
5366         * tui/tui-regs.c (tui_data_window::show_registers): Call
5367         rerender.
5368         (tui_data_window::rerender): Rename from display_all_data.
5369         (tui_data_window::rerender): Remove old implementation.
5370
5371 2019-08-30  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5374         text.
5375         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5376
5377 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5378             Sergio Durigan Junior  <sergiodj@redhat.com>
5379
5380         PR win32/24284
5381         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5382
5383 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5386         when searching for types.
5387
5388 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * f-lang.c (f_language_defn): Use f_print_typedef.
5391         * f-lang.h (f_print_typedef): Declare.
5392         * f-typeprint.c (f_print_typedef): Define.
5393
5394 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5395
5396         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5397
5398 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * cli/cli-utils.c (info_print_options_defs): Delete.
5401         (make_info_print_options_def_group): Delete.
5402         (extract_info_print_options): Delete.
5403         (info_print_command_completer): Delete.
5404         (info_print_args_help): Add extra parameter, and optionally
5405         include text about -n flag.
5406         * cli/cli-utils.h (struct info_print_options): Delete.
5407         (extract_info_print_options): Delete declaration.
5408         (info_print_command_completer): Delete declaration.
5409         (info_print_args_help): Add extra parameter, extend header
5410         comment.
5411         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5412         search_symbols.
5413         * stack.c (struct info_print_options): New type.
5414         (info_print_options_defs): New file scoped variable.
5415         (make_info_print_options_def_group): New static function.
5416         (info_print_command_completer): New static function.
5417         (info_locals_command): Update to use new local functions.
5418         (info_args_command): Likewise.
5419         (_initialize_stack): Add extra parameter to calls to
5420         info_print_args_help.
5421         * symtab.c (search_symbols): Add extra parameter, use this to
5422         possibly excluse non-debug symbols.
5423         (symtab_symbol_info): Add extra parameter, which is passed on to
5424         search_symbols.
5425         (struct info_print_options): New type.
5426         (info_print_options_defs): New file scoped variable.
5427         (make_info_print_options_def_group): New static function.
5428         (info_print_command_completer): New static function.
5429         (info_variables_command): Update to use local functions, and pass
5430         extra parameter through to symtab_symbol_info.
5431         (info_functions_command): Likewise.
5432         (info_types_command): Pass additional argument through to
5433         symtab_symbol_info.
5434         (rbreak_command): Pass extra argument to search_symbols.
5435         (_initialize_symtab): Add extra arguments for calls to
5436         info_print_args_help, and update help text for 'info variables',
5437         'whereis', and 'info functions' commands.
5438         * symtab.h (search_symbols): Add extra argument to declaration.
5439         * NEWS: Mention new flags.
5440
5441 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5442
5443         * symtab.c (lookup_static_symbol): Call the new function (and move
5444         it down to be next to lookup_global_symbol).
5445         (struct global_sym_lookup_data): Add block_enum member and rename to...
5446         (struct global_or_static_sym_lookup_data): ...this.
5447         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5448         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5449         (lookup_symbol_global_or_static_iterator_cb): ...this.
5450         (lookup_global_or_static_symbol): New function.
5451         (lookup_global_symbol): Call new function.
5452
5453 2019-08-26  Tom de Vries  <tdevries@suse.de>
5454
5455         PR c++/24852
5456         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5457         when pc_probe.prob == NULL.
5458
5459 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5460
5461         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5462         variable symbol_linkage to symbol_linkage_.
5463
5464 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5465
5466         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5467         represent whether the symbol is static, dynamic, or we don't
5468         know.
5469
5470 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5471
5472         * gdb/rx-tdep.c (rx_register_names): New.
5473         (rx_register_name): Delete.
5474         (rx_psw_type): Delete.
5475         (rx_fpsw_type): Delete.
5476         (rx_register_type): Delete.
5477         (rx_gdbarch_init): Convert target-descriptions.
5478         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5479         * gdb/features/Makefile: Add rx.xml.
5480         * gdb/features/rx.xml: New.
5481         * gdb/features/rx.c: Generated.
5482         * gdb/NEWS: Mention target description support.
5483
5484 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5485
5486         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5487         *slot_ptr.
5488
5489 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5490
5491         * configure.ac: Don't check for 'dlfcn.h' (moved to
5492         gdbsupport/common.m4).
5493         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5494         'gdbsupport/'.
5495         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5496         * compile/compile-c-support.c: Include
5497         'gdbsupport/gdb-dlfcn.h'.
5498         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5499         * gdb-dlfcn.c: Move to...
5500         * gdbsupport/gdb-dlfcn.c: ... here.
5501         * gdb-dlfcn.h: Move to...
5502         * gdbsupport/gdb-dlfcn.h: ... here.
5503
5504 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5505
5506         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5507         the offset field signed.
5508
5509 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5510
5511         * python/lib/gdb/__init__.py (_execute_file): New function.
5512         * python/python.c (python_run_simple_file): Call gdb._execute_file
5513         on Windows.
5514
5515 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5516
5517         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5518         all uses as this was never set to anything but a zero value.
5519
5520 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5521
5522         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5523
5524 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5525
5526         * tui/tui-data.h (tui_gen_win_info): Add an =default
5527         move constructor, required by some GCC versions.
5528
5529 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5530
5531         * go32-nat.c (go32_sysinfo): Add hygon_p.
5532
5533 2019-08-20  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5536         line_from_reg_element_no, first_reg_element_no_inline,
5537         display_all_data, delete_data_content_windows,
5538         erase_data_content>: Now private.
5539
5540 2019-08-20  Tom Tromey  <tom@tromey.com>
5541
5542         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5543         (tui_unhighlight_win, tui_highlight_win)
5544         (tui_win_info::make_window): Update.
5545         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5546
5547 2019-08-20  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5550         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5551         (MAX_PID_WIDTH): Move to tui-stack.c.
5552         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5553         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5554         (MAX_PID_WIDTH): Move from tui-data.h.
5555
5556 2019-08-20  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5559         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5560         (box_win): Update.
5561         (tui_gen_win_info::make_window): Rename from tui_make_window.
5562         (tui_win_info::make_window): New method.
5563         (tui_gen_win_info::make_visible): Update.
5564         * tui/tui-source.c (tui_source_window::set_contents): Update.
5565         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5566         (tui_data_window::display_registers_from): Update.
5567         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5568         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5569         Declare.
5570         <can_box>: Remove.
5571         <title>: Remove.
5572         (struct tui_win_info) <make_window>: Declare.
5573         <can_box>: Now virtual.
5574         <title>: New member.
5575         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5576         * tui/tui-command.c (tui_cmd_window::resize): Update.
5577
5578 2019-08-20  Tom Tromey  <tom@tromey.com>
5579
5580         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5581         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5582         (tui_data_window::check_register_values): Update.
5583
5584 2019-08-20  Tom Tromey  <tom@tromey.com>
5585
5586         * tui/tui-regs.h (struct tui_data_window): Use
5587         DISABLE_COPY_AND_ASSIGN.
5588         <regs_content>: Change type, removing unique_ptr.
5589         <tui_data_window>: Add move constructor.
5590         * tui/tui-regs.c (tui_data_window::show_registers)
5591         (tui_data_window::show_register_group)
5592         (tui_data_window::display_registers_from)
5593         (tui_data_window::display_registers_from)
5594         (tui_data_window::first_data_item_displayed)
5595         (tui_data_window::delete_data_content_windows)
5596         (tui_data_window::rerender, tui_data_window::refresh_window)
5597         (tui_data_window::check_register_values): Update.
5598
5599 2019-08-20  Tom Tromey  <tom@tromey.com>
5600
5601         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5602         show_register_group>: Declare.
5603         (tui_show_register_group): Don't declare.
5604         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5605         tui_show_registers.
5606         (tui_data_window::show_register_group): Rename from
5607         tui_show_register_group.
5608         (tui_data_window::check_register_values, tui_reg_command):
5609         Update.
5610         * tui/tui-layout.c (tui_set_layout): Update.
5611
5612 2019-08-20  Tom Tromey  <tom@tromey.com>
5613
5614         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5615         Declare.
5616         (tui_check_register_values): Don't declare.
5617         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5618         from tui_check_register_values.
5619         * tui/tui-hooks.c (tui_register_changed): Update.
5620
5621 2019-08-20  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-regs.c (tui_reg_layout): Move later.
5624         (tui_show_registers): Don't enable TUI mode or change layout.
5625
5626 2019-08-20  Tom Tromey  <tom@tromey.com>
5627
5628         * tui/tui-regs.h (struct tui_data_item_window)
5629         <~tui_data_item_window>: Remove.
5630         <content>: Now a unique_xmalloc_ptr.
5631         * tui/tui-regs.c (tui_register_format): Return a
5632         unique_xmalloc_ptr.
5633         (tui_get_register): Update.
5634         (~tui_data_item_window): Remove.
5635         (tui_data_window::display_registers_from, tui_display_register):
5636         Update.
5637         * tui/tui-io.h (tui_expand_tabs): Update.
5638         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5639         Remove "col" parameter.
5640
5641 2019-08-20  Tom Tromey  <tom@tromey.com>
5642
5643         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5644         field.
5645         * tui/tui-regs.c (~tui_data_item_window): Update.
5646
5647 2019-08-20  Tom Tromey  <tom@tromey.com>
5648
5649         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5650         earlier.
5651
5652 2019-08-20  Tom Tromey  <tom@tromey.com>
5653
5654         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5655
5656 2019-08-20  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui-source.h (struct tui_source_window): Update.
5659         * tui/tui-regs.c (tui_show_registers): Update.
5660         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5661         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5662         (NO_REGS_STRING): Remove defines.
5663
5664 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5665
5666         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5667         unnecessary thread walk if remote doesn't support the packet.
5668
5669 2019-08-19  Tom Tromey  <tromey@adacore.com>
5670
5671         * python/py-value.c (value_has_field): Fix indentation.
5672
5673 2019-08-19  Tom Tromey  <tromey@adacore.com>
5674
5675         * printcmd.c (do_one_display, info_display_command): Update.
5676         * block.h (contained_in): Return bool.  Add allow_nested
5677         parameter.
5678         * block.c (contained_in): Return bool.  Add allow_nested
5679         parameter.
5680
5681 2019-08-19  Tom Tromey  <tom@tromey.com>
5682
5683         * configure: Rebuild.
5684         * configure.ac: Disallow the combination of -static-libstdc++ and
5685         source highlight.
5686         * source-cache.c (get_language_name): Handle rust.
5687         (source_cache::get_source_lines): Ignore highlighting exceptions.
5688
5689 2019-08-16  Tom Tromey  <tom@tromey.com>
5690
5691         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5692         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5693         (struct tui_source_window_base) <make_visible, refresh_window,
5694         resize>: Remove methods.
5695         <execution_info>: Remove field.
5696         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5697         (tui_show_source_line, tui_source_window_base)
5698         (~tui_source_window_base): Update.
5699         (tui_source_window_base::resize)
5700         (tui_source_window_base::make_visible)
5701         (tui_source_window_base::refresh_window): Remove.
5702         (tui_source_window_base::update_exec_info): Update.
5703         * tui/tui-source.c (tui_source_window::set_contents): Update.
5704         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5705
5706 2019-08-16  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5709         deprecated_query_hook.
5710
5711 2019-08-16  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5714         (tui_update_source_windows_with_line): Update.
5715         * tui/tui-source.h (struct tui_source_window)
5716         <show_symtab_source>: Declare.
5717         (tui_show_symtab_source): Don't declare.
5718         * tui/tui-source.c (tui_show_symtab_source): Rename from
5719         tui_show_symtab_source.
5720
5721 2019-08-16  Tom Tromey  <tom@tromey.com>
5722
5723         * tui/tui-winsource.h (struct tui_source_window_base)
5724         <set_contents>: Declare.
5725         * tui/tui-winsource.c
5726         (tui_source_window_base::update_source_window_as_is): Update.
5727         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5728         Declare.
5729         (tui_set_source_content): Don't declare.
5730         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5731         tui_set_source_content.
5732         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5733         Declare.
5734         (tui_set_disassem_content): Don't declare.
5735         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5736         tui_set_disassem_content.
5737
5738 2019-08-16  Tom Tromey  <tom@tromey.com>
5739
5740         * tui/tui-winsource.h (struct tui_source_window_base)
5741         <update_breakpoint_info>: Declare.
5742         (tui_update_breakpoint_info): Don't declare.
5743         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5744         (tui_update_all_breakpoint_info): Update.
5745         (tui_source_window_base::update_breakpoint_info): Rename from
5746         tui_update_breakpoint_info.
5747         (tui_source_window_base::update_exec_info): Update.
5748
5749 2019-08-16  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-winsource.h (struct tui_source_window_base)
5752         <update_source_window>: Declare.
5753         (tui_update_source_window): Don't declare.
5754         * tui/tui-winsource.c
5755         (tui_source_window_base::update_source_window): Rename from
5756         tui_update_source_window.
5757         (tui_source_window_base::rerender): Update.
5758         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5759         * tui/tui-disasm.c (tui_show_disassem)
5760         (tui_show_disassem_and_update_source)
5761         (tui_disasm_window::maybe_update): Update.
5762
5763 2019-08-16  Tom Tromey  <tom@tromey.com>
5764
5765         * tui/tui-winsource.h (struct tui_source_window_base)
5766         <update_source_window_as_is>: Declare.
5767         (tui_update_source_window_as_is): Don't declare.
5768         * tui/tui-winsource.c (tui_update_source_window): Update
5769         (tui_source_window_base::update_source_window_as_is): Rename from
5770         tui_update_source_window_as_is.
5771         (tui_source_window_base::refill): Update.
5772         * tui/tui-source.c (tui_show_symtab_source): Update.
5773         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5774         Update.
5775
5776 2019-08-16  Tom Tromey  <tom@tromey.com>
5777
5778         * tui/tui-winsource.h (tui_update_source_window)
5779         (tui_update_source_window_as_is): Remove "noerror" parameter.
5780         * tui/tui-winsource.c (tui_update_source_window)
5781         (tui_update_source_window_as_is): Remove "noerror" parameter.
5782         (tui_update_source_windows_with_addr)
5783         (tui_update_source_windows_with_line)
5784         (tui_source_window_base::rerender)
5785         (tui_source_window_base::refill): Update.
5786         * tui/tui-source.h (tui_set_source_content)
5787         (tui_show_symtab_source): Remove "noerror" parameter.
5788         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5789         parameter.
5790         (tui_show_symtab_source): Likewise.
5791         (tui_source_window::maybe_update): Update.
5792         * tui/tui-disasm.c (tui_show_disassem)
5793         (tui_show_disassem_and_update_source)
5794         (tui_disasm_window::do_scroll_vertical)
5795         (tui_disasm_window::maybe_update): Update.
5796
5797 2019-08-16  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui.c (tui_is_window_visible): Update.
5800         * tui/tui-wingeneral.c (tui_make_window)
5801         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5802         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5803         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5804         (tui_set_win_height_command, parse_scrolling_args): Update.
5805         * tui/tui-source.c (tui_source_window::style_changed): Update.
5806         * tui/tui-regs.c (tui_show_registers)
5807         (tui_data_window::first_data_item_displayed)
5808         (tui_data_window::delete_data_content_windows)
5809         (tui_check_register_values, tui_reg_command): Update.
5810         * tui/tui-disasm.c (tui_show_disassem): Update.
5811         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5812         method.
5813         <is_visible>: Remove field.
5814         * tui/tui-data.c (tui_next_win, tui_prev_win)
5815         (tui_delete_invisible_windows): Update.
5816
5817 2019-08-16  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-winsource.h (struct tui_source_window_base)
5820         <m_has_locator>: Remove.
5821         * tui/tui-layout.c (show_source_disasm_command, show_data)
5822         (show_source_or_disasm_and_command): Update.
5823
5824 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5825
5826         * NEWS (Other MI changes): New subsection.
5827         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5828         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5829         * arch-utils.c (default_get_pc_address_flags): New function.
5830         * arch-utils.h (default_get_pc_address_flags): New declaration.
5831         * gdbarch.sh: Add get_pc_address_flags.
5832         * gdbarch.c: Regenerate.
5833         * gdbarch.h: Likewise.
5834         * stack.c (print_pc): New function.
5835         (print_frame_info) (print_frame): Call print_pc.
5836
5837 2019-08-16  Tom de Vries  <tdevries@suse.de>
5838
5839         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5840         print_objfile_section_info.
5841
5842 2019-08-15  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5845         calling update_cmdwin_start_line.
5846         * tui/tui-winsource.h (struct tui_source_window_base)
5847         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5848         <rerender>: Declare.
5849         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5850         Call rerender.
5851         (tui_source_window_base::set_new_height): Remove.
5852         (tui_source_window_base::rerender): Rename from
5853         do_make_visible_with_new_height.
5854         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5855         resize method.
5856         (tui_win_info::make_invisible_and_set_new_height)
5857         (tui_win_info::make_visible_with_new_height): Remove.
5858         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5859         Declare.
5860         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5861         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5862         do_make_visible_with_new_height>: Don't declare.
5863         <rerender>: Declare.
5864         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5865         set_new_height.
5866         (tui_data_window::do_make_visible_with_new_height): Remove.
5867         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5868         call tui_show_locator_content.
5869         (tui_gen_win_info::resize): Call rerender.
5870         (show_source_or_disasm_and_command): Don't call
5871         tui_show_locator_content.
5872         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5873         method.
5874         (struct tui_win_info) <rerender>: Declare.
5875         <set_new_height, make_invisible_and_set_new_height,
5876         make_visible_with_new_height>: Don't declare.
5877         * tui/tui-data.c (tui_win_list::rerender): New method.
5878         * tui/tui-command.h (struct tui_cmd_window)
5879         <do_make_visible_with_new_height>: Don't declare.
5880         * tui/tui-command.c
5881         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5882
5883 2019-08-15  Tom Tromey  <tromey@adacore.com>
5884
5885         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5886         * ada-lang.c (ada_enum_name): Likewise.
5887
5888 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5889
5890         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5891         leading underscore.
5892         (GdbOutputErrorFile): Likewise.
5893         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5894         accordingly.
5895         (execute_unwinders): Rename to have a leading underscore.
5896         (auto_load_packages): Likewise.
5897         (global scope): Adjust call to auto_load_packages accordingly.
5898         (GdbSetPythonDirectory): Likewise.
5899         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5900         instead of execute_unwinders.
5901
5902 2019-08-15  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5905         (show_data): Don't change window visibility.
5906         (tui_gen_win_info::resize): Remove special case for command
5907         window.  Use wresize, when available.
5908         (show_source_or_disasm_and_command): Don't change window
5909         visibility.
5910         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5911         <make_visible>: New method.
5912         * tui/tui-command.c (tui_cmd_window::resize): New method.
5913
5914 2019-08-15  Tom Tromey  <tom@tromey.com>
5915
5916         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5917         (struct tui_source_windows): New.
5918         * tui/tui-winsource.c (tui_display_main): Update.
5919         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5920         (new_height_ok, parse_scrolling_args): Update.
5921         * tui/tui-layout.c (show_layout, show_data): Update.
5922         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5923         (tui_add_to_source_windows): Don't declare.
5924         * tui/tui-data.c (source_windows, tui_source_windows)
5925         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5926
5927 2019-08-15  Tom Tromey  <tom@tromey.com>
5928
5929         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5930         Rename from reset.
5931         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5932         * tui/tui-layout.c (show_source_disasm_command, show_data):
5933         Update.
5934         (tui_gen_win_info::resize): Rename.
5935         (show_source_or_disasm_and_command): Update.
5936         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5937         reset.
5938
5939 2019-08-15  Tom Tromey  <tom@tromey.com>
5940
5941         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5942         * tui/tui-interp.c (tui_interp::init): Don't call
5943         tui_initialize_static_data.
5944         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5945
5946 2019-08-15  Tom Tromey  <tom@tromey.com>
5947
5948         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5949         examine tui_win_list.
5950
5951 2019-08-15  Tom Tromey  <tom@tromey.com>
5952
5953         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5954         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5955         tui_clear_source_content.
5956         (tui_clear_source_content): Remove.
5957         (tui_source_window_base::do_erase_source_content): Hoist call to
5958         content.clear().
5959         * tui/tui-stack.c (tui_show_frame_info): Don't call
5960         tui_clear_source_content.
5961
5962 2019-08-15  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-winsource.h (struct tui_source_window_base)
5965         <do_erase_source_content>: New method.
5966         <erase_source_content>: New method.
5967         (tui_erase_source_content): Don't declare.
5968         * tui/tui-winsource.c (tui_clear_source_content): Update.
5969         (tui_source_window_base::do_erase_source_content): Rename from
5970         tui_erase_source_content.
5971         (tui_source_window_base::show_source_content): Update.
5972         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5973         * tui/tui-source.h (struct tui_source_window)
5974         <erase_source_content>: New method.
5975         * tui/tui-disasm.h (struct tui_disasm_window)
5976         <erase_source_content>: New method.
5977
5978 2019-08-15  Tom Tromey  <tom@tromey.com>
5979
5980         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5981         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5982         constructor.
5983         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5984         * tui/tui-source.c (tui_set_source_content): Update.
5985         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5986
5987 2019-08-15  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5990         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5991         tui-source.c.
5992         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5993         Declare.
5994         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5995         method.
5996         (tui_source_window::maybe_update): Update.
5997
5998 2019-08-15  Tom Tromey  <tom@tromey.com>
5999
6000         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
6001         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
6002         tui-disasm.c.
6003         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
6004         Declare.
6005         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
6006         method.
6007         (tui_disasm_window::maybe_update): Update.
6008
6009 2019-08-15  Tom Tromey  <tom@tromey.com>
6010
6011         * tui/tui-winsource.h (struct tui_source_window_base)
6012         <maybe_update>: Declare.
6013         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
6014         method.
6015         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
6016         Declare.
6017         * tui/tui-source.c (tui_source_window::maybe_update): New method.
6018         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
6019         Declare.
6020         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
6021
6022 2019-08-15  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
6025
6026 2019-08-15  Tom Tromey  <tom@tromey.com>
6027
6028         * tui/tui-wingeneral.c: Include tui-stack.h.
6029         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
6030         (struct tui_locator_window): Move from tui-data.h.
6031         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
6032         (tui_initialize_static_data): Move from tui-data.c.
6033         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
6034         (struct tui_locator_window): Move to tui-stack.c.
6035         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
6036         (tui_initialize_static_data): Move to tui-stack.c.
6037
6038 2019-08-15  Tom Tromey  <tom@tromey.com>
6039
6040         * tui/tui-layout.c (show_source_disasm_command)
6041         (show_source_or_disasm_and_command): Use make_visible method, not
6042         tui_make_window.
6043         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
6044         Remove.
6045
6046 2019-08-15  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-wingeneral.h (tui_make_window): Update.
6049         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
6050         parameter.
6051         (tui_gen_win_info::make_visible): Update.
6052         * tui/tui-regs.c (tui_data_window::display_registers_from):
6053         Update.
6054         * tui/tui-layout.c (show_source_disasm_command)
6055         (show_source_or_disasm_and_command): Update.
6056         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
6057         (enum tui_box): Remove.
6058         (struct tui_win_info) <can_box>: New method.
6059         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
6060         method.
6061
6062 2019-08-15  Tom de Vries  <tdevries@suse.de>
6063
6064         * linux-nat-trad.c: Include gdbarch.h.
6065
6066 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
6067
6068         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
6069         register sizes.
6070
6071 2019-08-14  Tom Tromey  <tromey@adacore.com>
6072
6073         * darwin-nat.c: Include gdbarch.h.
6074         * darwin-nat-info.c: Include gdbarch.h.
6075
6076 2019-08-13  Tom Tromey  <tom@tromey.com>
6077
6078         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6079         Remove.
6080         * tui/tui-data.c (tui_initialize_static_data): Update.
6081
6082 2019-08-13  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-winsource.h (struct tui_exec_info_window)
6085         <~tui_exec_info_window, maybe_allocate_content, get_content,
6086         m_content>: Remove.
6087         (struct tui_source_window_base) <set_exec_info_content,
6088         show_exec_info_content>: Don't declare.
6089         * tui/tui-winsource.c
6090         (tui_exec_info_window::maybe_allocate_content): Remove.
6091         (tui_source_window_base::update_exec_info): Rename from
6092         set_exec_info_content.
6093         (tui_source_window_base::show_exec_info_content)
6094         (tui_source_window_base::update_exec_info): Remove.
6095
6096 2019-08-13  Tom Tromey  <tom@tromey.com>
6097
6098         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6099         declare.
6100         * tui/tui-winsource.c (tui_update_source_window_as_is)
6101         (tui_update_source_windows_with_addr, tui_erase_source_content):
6102         Update.
6103         (tui_clear_exec_info_content): Remove.
6104
6105 2019-08-13  Tom Tromey  <tom@tromey.com>
6106
6107         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6108         declare.
6109         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6110         call tui_erase_exec_info_content.
6111         (tui_clear_exec_info_content): Rename from
6112         tui_erase_exec_info_content.
6113         (tui_clear_exec_info_content): Delete.
6114
6115 2019-08-13  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-winsource.h (struct tui_source_window_base)
6118         <show_exec_info_content>: Declare.
6119         (tui_show_exec_info_content): Don't declare.
6120         * tui/tui-winsource.c
6121         (tui_source_window_base::show_exec_info_content): Rename from
6122         tui_show_exec_info_content.
6123         (tui_source_window_base::update_exec_info): Update.
6124
6125 2019-08-13  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6128         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6129         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6130         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6131         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6132         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6133         ... here.
6134
6135 2019-08-13  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui-winsource.h (struct tui_source_window_base)
6138         <update_exec_info>: Declare.
6139         (tui_update_exec_info): Don't declare.
6140         * tui/tui-winsource.c (tui_update_source_window_as_is)
6141         (tui_source_window_base::refresh_all)
6142         (tui_update_all_breakpoint_info): Update.
6143         (tui_source_window_base::update_exec_info): Rename from
6144         tui_update_exec_info.
6145         * tui/tui-stack.c (tui_show_frame_info): Update.
6146
6147 2019-08-13  Tom Tromey  <tom@tromey.com>
6148
6149         * tui/tui-winsource.h (struct tui_source_window_base)
6150         <set_exec_info_content>: Declare.
6151         (tui_set_exec_info_content): Don't declare.
6152         * tui/tui-winsource.c
6153         (tui_source_window_base::set_exec_info_content): Rename from
6154         tui_set_exec_info_content.
6155         (tui_update_exec_info): Update.
6156
6157 2019-08-13  Tom Tromey  <tom@tromey.com>
6158
6159         * tui/tui-winsource.h (struct tui_source_window_base)
6160         <show_source_content>: Declare.
6161         (tui_show_source_content): Don't declare.
6162         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6163         (tui_source_window_base::show_source_content): Rename from
6164         tui_show_source_content.
6165         (tui_source_window_base::refresh_all): Update.
6166         * tui/tui-layout.c (show_source_disasm_command)
6167         (show_source_or_disasm_and_command): Update.
6168
6169 2019-08-13  Tom Tromey  <tom@tromey.com>
6170
6171         * tui/tui-winsource.c (tui_erase_source_content)
6172         (tui_show_source_content, tui_source_window_base::refresh_all):
6173         Update.
6174         * tui/tui-wingeneral.h
6175         (tui_check_and_display_highlight_if_needed): Don't declare.
6176         * tui/tui-wingeneral.c
6177         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6178         check_and_display_highlight_if_needed.
6179         * tui/tui-win.c (tui_rehighlight_all)
6180         (tui_win_info::make_visible_with_new_height): Update.
6181         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6182         (tui_data_window::erase_data_content)
6183         (tui_data_window::display_all_data): Update.
6184         * tui/tui-data.h (struct tui_win_info)
6185         <check_and_display_highlight_if_needed>: Declare.
6186
6187 2019-08-13  Tom Tromey  <tom@tromey.com>
6188
6189         * tui/tui-win.c (tui_resize_all): Call
6190         tui_delete_invisible_windows.
6191         * tui/tui-layout.c (show_layout): Call
6192         tui_delete_invisible_windows.
6193         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6194         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6195
6196 2019-08-13  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6199         tui_add_win_to_layout.
6200
6201 2019-08-13  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6204         * tui/tui-layout.c (tui_default_win_height): Now static.
6205
6206 2019-08-13  Tom Tromey  <tom@tromey.com>
6207
6208         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6209         single switch.
6210         (show_source_disasm_command, show_source_or_disasm_and_command):
6211         Don't check current layout.
6212
6213 2019-08-13  Tom Tromey  <tom@tromey.com>
6214
6215         * tui/tui-wingeneral.c (make_all_visible): Remove.
6216         (tui_make_all_invisible): Simplify.
6217         * tui/tui-layout.c (tui_make_all_invisible): Move from
6218         tui-wingeneral.c; simplify.
6219         (show_layout): Hoist call to tui_make_all_invisible.
6220         (show_data): Don't call tui_make_all_invisible.
6221
6222 2019-08-13  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6225         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6226
6227 2019-08-13  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6230         tui-data.c.
6231         (show_source_disasm_command, show_data)
6232         (show_source_or_disasm_and_command): Don't use
6233         tui_set_current_layout_to.
6234         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6235         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6236         tui-layout.c.
6237         (tui_set_current_layout_to): Remove.
6238
6239 2019-08-13  Tom Tromey  <tom@tromey.com>
6240
6241         * tui/tui-layout.c (tui_set_layout): Update.
6242         * tui/tui-data.h (struct tui_layout_def): Remove.
6243         (tui_layout_def): Don't declare.
6244         * tui/tui-data.c (layout_def): Remove.
6245         (tui_layout_def): Remove.
6246
6247 2019-08-13  Tom Tromey  <tom@tromey.com>
6248
6249         * tui/tui-winsource.h (struct tui_source_window_base)
6250         <clear_detail>: No longer "override".
6251         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6252         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6253         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6254         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6255         Remove.
6256         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6257
6258 2019-08-13  Tom Tromey  <tromey@adacore.com>
6259
6260         * tracepoint.c: Don't include readline.h or history.h.
6261
6262 2019-08-12  Tom Tromey  <tom@tromey.com>
6263
6264         * configure: Rebuild.
6265         * configure.ac: Check for readline 7.
6266         * NEWS: Mention readline 7 requirement.
6267         * README: Update.
6268
6269 2019-08-12  Tom Tromey  <tom@tromey.com>
6270
6271         * mingw-hdep.c (gdb_select): Remove readline hack.
6272
6273 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6274
6275         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6276         when the function fails.
6277
6278 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6279
6280         * s390-tdep.c (s390_type_align): New function.
6281         (s390_gdbarch_init): Set it as type_align gdbarch method.
6282
6283 2019-08-09  Tom de Vries  <tdevries@suse.de>
6284
6285         PR gdb/24591
6286         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6287         pc_low with relocation offset.
6288
6289 2019-08-07  Tom Tromey  <tromey@adacore.com>
6290
6291         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6292         (print_frame_args): Update.
6293         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6294         Update.
6295         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6296         * frame.h (struct frame_arg): Add initializers.
6297         <error>: Now a unique_xmalloc_ptr.
6298
6299 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6300
6301         * NEWS: Expand the Pointer Authentication entry.
6302         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6303         (aarch64_frame_unmask_lr): ... to this.
6304         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6305         Call aarch64_frame_unmask_lr.
6306         * frame.c (struct frame_info): Add "masked" variable.
6307         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6308         (fprint_frame): Check for masked pc.
6309         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6310         declarations.
6311         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6312         * stack.c (print_frame): Check for masked pc.
6313
6314 2019-08-06  Tom Tromey  <tom@tromey.com>
6315
6316         * stabsread.c (patch_block_stabs, read_one_struct_field)
6317         (read_enum_type): Use obstack_strndup.
6318         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6319         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6320         * dwarf2read.c (guess_full_die_structure_name)
6321         (anonymous_struct_prefix): Use obstack_strndup.
6322         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6323         * c-exp.y (yylex): Use obstack_strndup.
6324         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6325         (write_var_or_type): Use obstack_strndup.
6326
6327 2019-08-06  Tom Tromey  <tom@tromey.com>
6328
6329         * symfile.c (reread_symbols): Use obstack_strdup.
6330         * stabsread.c (read_type): Use obstack_strdup.
6331         * gdb_obstack.h (obstack_strdup): New overload.
6332         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6333         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6334         (dwarf2_canonicalize_name): Use obstack_strdup.
6335         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6336         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6337         Use obstack_strdup.
6338
6339 2019-08-06  Tom Tromey  <tom@tromey.com>
6340
6341         * gdb_obstack.h (obstack_strdup): Define.
6342         * gdb_obstack.c (obstack_strdup): Don't define.
6343
6344 2019-08-06  Tom Tromey  <tom@tromey.com>
6345
6346         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6347         obstack_strdup.
6348         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6349         obstack_strdup.
6350         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6351         * stabsread.c (common_block_start): Use obstack_strdup.
6352         * objfiles.c (set_objfile_main_name, objfile): Use
6353         obstack_strdup.
6354         * namespace.c (add_using_directive): Use obstack_strdup.
6355         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6356         * jit.c (finalize_symtab): Use obstack_strdup.
6357         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6358         (guess_partial_die_structure_name, partial_die_info::fixup)
6359         (dwarf2_name): Use obstack_strdup.
6360         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6361         obstack_strdup.
6362         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6363         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6364         obstack_strdup.
6365         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6366
6367 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6368
6369         * unittests/help-doc-selftests.c: New file.
6370         * Makefile.in: Add the new file.
6371
6372 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6373
6374         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6375         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6376         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6377         the trailing '.' is not output, and the first character is uppercased.
6378         (print_help_for_command): Update call to print_doc_line.
6379         (print_doc_of_command): Likewise.
6380         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6381         * cli/cli-option.c (append_indented_doc): Do not append newline.
6382         (build_help_option): Append newline after first appended_indented_doc
6383         only if a second call is done.
6384         (build_help): Append 2 new lines before each option, except the first
6385         one.
6386         * compile/compile.c (_initialize_compile): Add new lines after
6387         %OPTIONS%, when not at the end of the help.
6388         Change help doc or code
6389         producing the help doc to respect the invariants.
6390         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6391         Also removed the new line after 'Options:', as all other commands
6392         do not put an empty line between 'Options:' and the first option.
6393         * printcmd.c (_initialize_printcmd): Likewise.
6394         * stack.c (_initialize_stack): Likewise.
6395         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6396         incorrectly telling COMMAND is optional.
6397         * ada-lang.c (_initialize_ada_language): Change help doc or code
6398         producing the help doc to respect the invariants.
6399         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6400         * breakpoint.c (_initialize_breakpoint): Likewise.
6401         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6402         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6403         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6404         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6405         _initialize_cli_style): Likewise.
6406         * corelow.c (core_target_info): Likewise.
6407         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6408         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6409         * filesystem.c (_initialize_filesystem): Likewise.
6410         * frame.c (_initialize_frame): Likewise.
6411         * gnu-nat.c (add_task_commands): Likewise.
6412         * infcall.c (_initialize_infcall): Likewise.
6413         * infcmd.c (_initialize_infcmd): Likewise.
6414         * interps.c (_initialize_interpreter): Likewise.
6415         * language.c (_initialize_language): Likewise.
6416         * linux-fork.c (_initialize_linux_fork): Likewise.
6417         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6418         * maint.c (_initialize_maint_cmds): Likewise.
6419         * memattr.c (_initialize_mem): Likewise.
6420         * printcmd.c (_initialize_printcmd): Likewise.
6421         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6422         _RegEx): Likewise.
6423         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6424         * record-btrace.c (_initialize_record_btrace): Likewise.
6425         * record-full.c (_initialize_record_full): Likewise.
6426         * record.c (_initialize_record): Likewise.
6427         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6428         * regcache.c (_initialize_regcache): Likewise.
6429         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6430         _initialize_remote): Likewise.
6431         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6432         * serial.c (_initialize_serial): Likewise.
6433         * skip.c (_initialize_step_skip): Likewise.
6434         * source.c (_initialize_source): Likewise.
6435         * stack.c (_initialize_stack): Likewise.
6436         * symfile.c (_initialize_symfile): Likewise.
6437         * symtab.c (_initialize_symtab): Likewise.
6438         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6439         * top.c (init_main): Likewise.
6440         * tracefile-tfile.c (tfile_target_info): Likewise.
6441         * tracepoint.c (_initialize_tracepoint): Likewise.
6442         * tui/tui-win.c (_initialize_tui_win): Likewise.
6443         * utils.c (add_internal_problem_command): Likewise.
6444         * valprint.c (value_print_option_defs): Likewise.
6445
6446 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6447
6448         PR build/24886
6449         * configure.ac: Drop enable-libmcheck support.
6450         * configure, config.in: Rebuild.
6451         * libmcheck.m4: Remove.
6452         * acinclude.m4: Don't include it.
6453         * Makefile.in: Don't distribute it.
6454         * top.c (print_gdb_configuration): Don't mention it.
6455
6456 2019-08-06  Tom Tromey  <tom@tromey.com>
6457
6458         * utils.c (set_output_style): Sometimes pass stream to
6459         emit_style_escape.
6460         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6461         * record-btrace.c (btrace_insn_history): Update.
6462         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6463         method.
6464         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6465         Update initializers.
6466         <m_uiout>: New field.
6467         <m_di>: Move lower.
6468         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6469         Remove "uiout" parameter.
6470         (dump_insns): Update.
6471         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6472         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6473
6474 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6475
6476         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6477         (error_in_psymtab_expansion): Likewise.
6478         (lookup_symbol_via_quick_fns): Likewise.
6479         (basic_lookup_transparent_type_quick): Likewise.
6480         (basic_lookup_transparent_type_1): Likewise.
6481
6482 2019-08-06  Tom Tromey  <tromey@adacore.com>
6483
6484         * source.c (last_source_error): Now bool.
6485         (print_source_lines_base): Make "noprint" bool.  Only open
6486         source file when last_source_visited changes.
6487
6488 2019-08-06  Tom Tromey  <tromey@adacore.com>
6489
6490         * annotate.c (annotate_source_line): Use g_source_cache.
6491         * source-cache.c (source_cache::get_plain_source_lines): Change
6492         parameters.  Populate m_offset_cache.
6493         (source_cache::ensure): New method.
6494         (source_cache::get_line_charpos): New method.
6495         (extract_lines): Move lower.  Change parameters.
6496         (source_cache::get_source_lines): Move lower.
6497         * source-cache.h (class source_cache): Update comment.
6498         <get_line_charpos>: New method.
6499         <get_source_lines>: Update comment.
6500         <clear>: Clear m_offset_cache.
6501         <get_plain_source_lines>: Change parameters.
6502         <ensure>: New method
6503         <m_offset_cache>: New member.
6504         * source.c (forget_cached_source_info_for_objfile): Update.
6505         (info_source_command): Use g_source_cache.
6506         (find_source_lines, open_source_file_with_line_charpos): Remove.
6507         (print_source_lines_base, search_command_helper): Use g_source_cache.
6508         * source.h (open_source_file_with_line_charpos): Don't declare.
6509         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6510         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6511         Use g_source_cache.
6512
6513 2019-08-06  Tom Tromey  <tromey@adacore.com>
6514
6515         * source-cache.c (source_cache::get_plain_source_lines):
6516         Remove "first_line" and "last_line" parameters.
6517         (source_cache::get_source_lines): Cache plain text.
6518         * source-cache.h (class source_cache)
6519         <get_plain_source_lines>: Update.
6520
6521 2019-08-06  Tom Tromey  <tromey@adacore.com>
6522
6523         * source-cache.c (extract_lines): No longer a method.
6524         Changed type of parameter.  Include final newline.
6525         (selftests::extract_lines_test): New function.
6526         (_initialize_source_cache): Likewise.
6527         * source-cache.h (class source_cache)
6528         <extract_lines>: Don't declare.
6529
6530 2019-08-06  Tom Tromey  <tromey@adacore.com>
6531
6532         * breakpoint.c (init_breakpoint_sal): Update.
6533         (breakpoint): Update.
6534         * breakpoint.h (struct breakpoint) <filter>: Now a
6535         unique_xmalloc_ptr.
6536
6537 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6538
6539         * NEWS: Mention dictionary access on blocks.
6540         * python/py-block.c (blpy_getitem): New function.
6541         (block_object_as_mapping): New struct.
6542         (block_object_type): Use new struct for tp_as_mapping field.
6543
6544 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6545
6546         * objfiles.h (objfile): Add a comment describing partial symbols.
6547
6548 2019-08-05  Tom Tromey  <tromey@adacore.com>
6549
6550         * compile/compile.c (_initialize_compile): Use _(), not N_().
6551         * thread.c (_initialize_thread): Use _(), not N_().
6552         * stack.c (_initialize_stack): Use _(), not N_().
6553         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6554
6555 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6556
6557         * dwarf2read.c (struct dw2_symtab_iterator):
6558         <want_specific_block>: Remove.
6559         <block_index>: Change type to gdb::optional.
6560         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6561         change type of BLOCK_INDEX parameter to gdb::optional.
6562         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6563         (dw2_lookup_symbol): Don't pass argument for
6564         WANT_SPECIFIC_BLOCK.
6565         (dw2_expand_symtabs_for_function): Don't pass argument for
6566         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6567         (class dw2_debug_names_iterator)
6568         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6569         parameter, change BLOCK_INDEX type to gdb::optional.
6570         <m_want_specific_block>: Remove.
6571         <m_block_index>: Change type to gdb::optional.
6572         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6573         gdb::optional.  Re-write in function of gdb::optional.
6574         (dw2_debug_names_lookup_symbol): Don't pass argument for
6575         WANT_SPECIFIC_BLOCK.
6576         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6577         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6578         BLOCK_INDEX.
6579
6580 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6581
6582         * NEWS: Mention changes to "info sources" command.
6583
6584 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6585
6586         * symtab.c (filename_partial_match_opts): New struct type.
6587         (struct output_source_filename_data): New members
6588         regexp, c_regexp, partial_match.
6589         (output_source_filename): Use new members to decide to print file.
6590         (info_sources_option_defs): New variable.
6591         (make_info_sources_options_def_group, print_info_sources_header,
6592         info_sources_command_completer):
6593         New functions.
6594         (info_sources_command): Read new optional arguments.
6595         (_initialize_symtab): Update info sources help.
6596
6597 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6598
6599         * ada-lang.c (exception_support_info_v0): Renamed from...
6600         (default_exception_support_info): ... this.  Create new
6601         definition for v1.
6602         (ada_has_this_exception_support): Look up catch_handlers_sym.
6603         (ada_exception_support_info_sniffer): Try v0 after default.
6604
6605 2019-08-01  Tom Tromey  <tromey@adacore.com>
6606
6607         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6608         gdbarch.h.
6609
6610 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6611
6612         * s12z-tdep.c: Fix include path for s12z-opc.h.
6613
6614 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6615
6616         * NEWS: Require GNU make 3.82.
6617
6618 2019-07-16  Tom Tromey  <tom@tromey.com>
6619
6620         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6621         declare.
6622
6623 2019-07-30  Tom Tromey  <tromey@adacore.com>
6624
6625         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6626
6627 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6628
6629         * printcmd.c (print_address_symbolic): Print negative offsets.
6630         (build_address_symbolic): Force signed arithmetic when computing
6631         offset.
6632
6633 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6634
6635         PR/24474: Add a function to lookup static variables.
6636         * NEWS: Mention this new function.
6637         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6638         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6639         * python/python.c (python_GdbMethods): Add new function.
6640
6641 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6642
6643         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6644         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6645         (objfpy_lookup_static_symbol): New function.
6646         (objfile_object_methods): Add new functions.
6647
6648 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6649
6650         * NEWS: Mention 'set|show print frame-info'.  Mention new
6651         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6652         backtrace argument.  Mention that python frame filtering code
6653         is now consistent with what 'backtrace' command prints.
6654
6655 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6656
6657         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6658         comments.
6659         (print_frame_info_auto, print_frame_info_source_line,
6660         print_frame_info_location, print_frame_info_source_and_location,
6661         print_frame_info_location_and_address, print_frame_info_short_location):
6662         New declarations.
6663         (struct frame_print_options): New member print_frame_info.
6664         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6665         * stack.h (get_user_print_what_frame_info): New declaration.
6666         (frame_show_address): New declaration.
6667         * stack.c (print_frame_arguments_choices): New value 'presence'.
6668         (print_frame_info_auto, print_frame_info_source_line,
6669         print_frame_info_location, print_frame_info_source_and_location,
6670         print_frame_info_location_and_address, print_frame_info_short_location,
6671         print_frame_info_choices, print_frame_info_print_what): New definitions.
6672         (print_frame_args): Only print dots for args if print frame-arguments
6673         is 'presence'.
6674         (frame_print_option_defs): New element for "frame-info".
6675         (get_user_print_what_frame_info): New function.
6676         (frame_show_address): Make non static.  Move comment to stack.h.
6677         (print_frame_info_to_print_what): New function.
6678         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6679         to decide what to print.
6680         (backtrace_command_1): Handle the new print_frame_arguments_presence
6681         value.
6682         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6683         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6684         (py_print_frame): In non-mi mode, use LOCATION as default for
6685         print_what, similarly to frame information printed directly by
6686         backtrace command. Handle frame-info user option in non MI mode.
6687
6688 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6689
6690         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6691         Add case for debugging 32-bit target on 64-bit host.  Revise
6692         comment.
6693
6694 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6695
6696         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6697         instead of find_function_entry_range_from_pc.
6698
6699 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6700
6701         * stack.c (find_frame_funname): Remove code which preferred
6702         minsym over symtab sym in "certain pathological cases".
6703
6704         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6705         parameter.  Change type of "do_demangle" to bool.
6706         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6707         Pass suitable "prefer_sym_over_minsym" flag to
6708         build_address_symbolic().  Don't output "+" for negative offsets.
6709         * printcmd.c (print_address_symbolic): Update invocation of
6710         build_address_symbolic to include a "prefer_sym_over_minsym"
6711         flag.
6712         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6713         Restrict cases in which use of minimal symbol is preferred to that
6714         of a found symbol.  Update comments.
6715
6716         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6717         for entry pc when entry pc is out of range for that FDE.
6718
6719 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6720
6721         PR gdb/24839:
6722         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6723         type.
6724
6725 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6726
6727         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6728         this function's Python signature.
6729
6730
6731 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6732
6733         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6734         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6735         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6736         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6737         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6738
6739
6740 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6741
6742         * h8300-tdep.c (h8300_register_name_common): New.
6743         h8300_register_name): Use h8300_register_name_common.
6744         (h8300s_register_name): Likewise.
6745         (h8300sx_register_name): Likewise.
6746         (h8300h_register_nam): New.
6747         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6748
6749
6750 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6751
6752         * arm-tdep.c (arm_skip_cmse_entry): New function.
6753         (arm_is_sgstubs_section): New function.
6754         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6755
6756 2019-07-22  Tom Tromey  <tom@tromey.com>
6757
6758         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6759         Don't self-assign.
6760
6761 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6762
6763         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6764         type_print.
6765
6766 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6767
6768         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6769         so that GDB doesn't match any msymbols when searching in the
6770         TYPES_DOMAIN.
6771         (print_symbol_info): Print using typedef_print or type_print based
6772         on the type of the symbol.  Add updated FIXME comment moved from...
6773         (_initialize_symtab): ... move and update FIXME comment to above.
6774
6775 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6776
6777         * NEWS: Mention adding -q option to "info types".
6778         * symtab.c (struct info_types_options): New struct.
6779         (info_types_options_defs): New variable.
6780         (make_info_types_options_def_group): New function.
6781         (info_types_command): Use gdb::option framework to parse options.
6782         (info_types_command_completer): New function.
6783         (_initialize_symtab): Extend the help text on "info types" and
6784         register command completer.
6785
6786 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6787
6788         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6789         (lookup_symbol_in_objfile): Change int to block_enum and add a
6790         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6791
6792 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6793
6794         * MAINTAINERS (Write After Approval): Add self.
6795
6796 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6797
6798         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6799         instruction to the dummy code region.
6800
6801 2019-07-19  Tom Tromey  <tromey@adacore.com>
6802
6803         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6804         (ARGSUSED, PARAMS, __func__): Remove rules.
6805
6806 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6807
6808         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6809         * features/arm/arm-with-iwmmxt.c: Remove.
6810         * features/arm/arm-with-iwmmxt.xml: Remove.
6811         * features/arm/arm-with-m-fpa-layout.c: Remove.
6812         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6813         * features/arm/arm-with-m-vfp-d16.c: Remove.
6814         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6815         * features/arm/arm-with-m.c: Remove.
6816         * features/arm/arm-with-m.xml: Remove.
6817         * features/arm/arm-with-neon.c: Remove.
6818         * features/arm/arm-with-neon.xml: Remove.
6819         * features/arm/arm-with-vfpv2.c: Remove.
6820         * features/arm/arm-with-vfpv2.xml: Remove.
6821         * features/arm/arm-with-vfpv3.c: Remove.
6822         * features/arm/arm-with-vfpv3.xml: Remove.
6823
6824 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6825
6826         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6827
6828 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6829
6830         * arch/aarch32.c (aarch32_create_target_description): Create
6831         target descriptions using features.
6832         * arch/arm.c (arm_create_target_description)
6833         (arm_create_mprofile_target_description): Likewise.
6834         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6835
6836 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6837
6838         * Makefile.in: Add new files.
6839         * aarch32-tdep.c: New file.
6840         * aarch32-tdep.h: New file.
6841         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6842         Call aarch32_read_description.
6843         * arch/aarch32.c: New file.
6844         * arch/aarch32.h: New file.
6845         * arch/arm.c (arm_create_target_description)
6846         (arm_create_mprofile_target_description): New function.
6847         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6848         (arm_create_target_description)
6849         (arm_create_mprofile_target_description): New declaration.
6850         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6851         read_description functions.
6852         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6853         Likewise.
6854         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6855         * arm-tdep.c (tdesc_arm_list): New variable.
6856         (arm_register_g_packet_guesses): Call create description functions.
6857         (arm_read_description) (arm_read_mprofile_description): New
6858         function.
6859         * arm-tdep.h (arm_read_description)
6860         (arm_read_mprofile_description): Add declaration.
6861         * configure.tgt: Add new files.
6862
6863 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6864
6865         * top.c (new_ui_command): Open specified terminal just once.
6866
6867 2019-07-18  Tom Tromey  <tromey@adacore.com>
6868
6869         * symtab.c (main_name): Constify return type.
6870         * symfile.c (set_initial_language): Update.
6871         * symtab.h (main_name): Constify return type.
6872
6873 2019-07-17  Tom Tromey  <tom@tromey.com>
6874
6875         * tui/tui-winsource.c (tui_update_source_window)
6876         (tui_update_source_window_as_is)
6877         (tui_update_source_windows_with_line): Remove return.
6878         * tui/tui-disasm.c (tui_show_disassem)
6879         (tui_show_disassem_and_update_source): Remove return.
6880         * tui/tui.c (tui_reset): Remove return.
6881         * tui/tui-wingeneral.c
6882         (tui_check_and_display_highlight_if_needed): Remove return.
6883
6884 2019-07-17  Tom Tromey  <tom@tromey.com>
6885
6886         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6887
6888 2019-07-17  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui-winsource.h (struct tui_exec_info_window)
6891         (struct tui_source_window_base): Move from tui-data.h.
6892         * tui/tui-winsource.c: Move many method definitions from
6893         elsewhere.  Remove "structuring" comments.
6894         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6895         (tui_source_window_base::refresh_window): Move to
6896         tui-winsource.c.
6897         * tui/tui-win.c (tui_source_window_base::refresh_all)
6898         (tui_source_window_base::update_tab_width)
6899         (tui_source_window_base::set_new_height)
6900         (tui_source_window_base::do_make_visible_with_new_height): Move to
6901         tui-winsource.c.
6902         * tui/tui-source.h: Update.
6903         * tui/tui-source.c (tui_source_window_base::reset): Move to
6904         tui-winsource.c.
6905         * tui/tui-disasm.h: Update.
6906         * tui/tui-data.h (struct tui_exec_info_window): Move to
6907         tui-winsource.h.
6908         (struct tui_source_window_base): Likewise.
6909         * tui/tui-data.c (tui_source_window_base::clear_detail)
6910         (tui_source_window_base, ~tui_source_window_base): Move to
6911         tui-winsource.c.
6912
6913 2019-07-17  Tom Tromey  <tom@tromey.com>
6914
6915         * tui/tui-win.c (tui_resize_all)
6916         (tui_source_window_base::update_tab_width)
6917         (tui_adjust_win_heights): Update.
6918         (tui_win_info::make_invisible_and_set_new_height): Rename from
6919         make_invisible_and_set_new_height.
6920         * tui/tui-data.h (struct tui_win_info)
6921         <make_invisible_and_set_new_height>: New method.
6922
6923 2019-07-17  Tom Tromey  <tom@tromey.com>
6924
6925         * tui/tui.c: Update.
6926         * tui/tui-source.h (struct tui_source_window): Move from
6927         tui-data.h.
6928         * tui/tui-layout.c: Update.
6929         * tui/tui-disasm.c: Update.
6930         * tui/tui-data.h (struct tui_source_window): Move to
6931         tui-source.h.
6932
6933 2019-07-17  Tom Tromey  <tom@tromey.com>
6934
6935         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6936         tui-data.h.
6937         * tui/tui-data.h (struct tui_disasm_window): Move to
6938         tui-disasm.h.
6939
6940 2019-07-17  Tom Tromey  <tom@tromey.com>
6941
6942         * tui/tui-regs.h (struct tui_data_item_window): Move from
6943         tui-data.h.
6944         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6945         * tui/tui-data.h (struct tui_data_item_window): Move to
6946         tui-regs.h.
6947         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6948
6949 2019-07-17  Tom Tromey  <tom@tromey.com>
6950
6951         * tui/tui.c: Update.
6952         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6953         (tui_cmd_window::max_height): Move to tui-command.c.
6954         * tui/tui-layout.c: Update.
6955         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6956         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6957         tui-command.c.
6958         * tui/tui-command.h (struct tui_cmd_window): Move from
6959         tui-data.h.
6960         * tui/tui-command.c: Remove "structuring" comments.
6961         (tui_cmd_window::clear_detail)
6962         (tui_cmd_window::do_make_visible_with_new_height)
6963         (tui_cmd_window::max_height): Move from elsewhere.
6964
6965 2019-07-17  Tom Tromey  <tom@tromey.com>
6966
6967         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6968         Now static.
6969         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6970         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6971
6972 2019-07-17  Tom Tromey  <tom@tromey.com>
6973
6974         * tui/tui.c: Update.
6975         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6976         tui-regs.c.
6977         * tui/tui-windata.h: Remove file.
6978         * tui/tui-windata.c: Remove file.
6979         * tui/tui-win.c (tui_data_window::set_new_height)
6980         (tui_data_window::do_make_visible_with_new_height): Move to
6981         tui-regs.c.
6982         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6983         * tui/tui-regs.c: Remove "structuring" comments.
6984         (tui_data_window::first_data_item_displayed)
6985         (tui_data_window::delete_data_content_windows)
6986         (tui_data_window::erase_data_content)
6987         (tui_data_window::display_all_data)
6988         (tui_data_window::refresh_all)
6989         (tui_data_window::do_scroll_vertical)
6990         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6991         (tui_data_window::do_make_visible_with_new_height)
6992         (tui_data_window::refresh_window): Move from elsewhere.
6993         (_initialize_tui_regs): Move to end of file.
6994         * tui/tui-layout.c: Update.
6995         * tui/tui-hooks.c: Update.
6996         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6997         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6998         tui-regs.c.
6999         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
7000
7001 2019-07-17  Tom Tromey  <tom@tromey.com>
7002
7003         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
7004         seen.
7005
7006 2019-07-17  Tom Tromey  <tom@tromey.com>
7007
7008         * tui/tui-win.c (tui_source_window_base::set_new_height)
7009         (tui_source_window_base::do_make_visible_with_new_height): Use
7010         m_has_locator field directly.
7011         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
7012         method.
7013         (struct tui_source_window_base) <has_locator>: Likewise.
7014
7015 2019-07-17  Tom Tromey  <tom@tromey.com>
7016
7017         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
7018         Don't declare.
7019         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
7020         Remove.
7021         * tui/tui-win.c (tui_source_window_base::set_new_height)
7022         (tui_source_window_base::set_new_height)
7023         (make_invisible_and_set_new_height)
7024         (tui_source_window_base::do_make_visible_with_new_height)
7025         (tui_source_window_base::do_make_visible_with_new_height):
7026         Update.
7027         * tui/tui-layout.c (show_source_disasm_command, show_data)
7028         (show_source_or_disasm_and_command): Update.
7029         * tui/tui-layout.c (show_layout): Update.
7030
7031 2019-07-17  Tom Tromey  <tom@tromey.com>
7032
7033         * tui/tui-layout.c (make_data_window): Remove.
7034         (show_data): Unify creation and re-initialization cases.
7035
7036 2019-07-17  Tom Tromey  <tom@tromey.com>
7037
7038         * tui/tui-layout.c (make_source_window, make_disasm_window):
7039         Remove.
7040         (show_data): Unify creation and re-initialization cases.
7041
7042 2019-07-17  Tom Tromey  <tom@tromey.com>
7043
7044         * tui/tui-layout.c (make_command_window): Remove.
7045         (show_source_disasm_command, show_source_or_disasm_and_command):
7046         Unify creation and re-initialization cases.
7047
7048 2019-07-17  Tom Tromey  <tom@tromey.com>
7049
7050         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
7051         creation and re-initialization cases.
7052
7053 2019-07-17  Tom Tromey  <tom@tromey.com>
7054
7055         * tui/tui-regs.c (tui_get_register): Return void.
7056
7057 2019-07-17  Tom Tromey  <tom@tromey.com>
7058
7059         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
7060         Simplify.
7061
7062 2019-07-17  Tom Tromey  <tom@tromey.com>
7063
7064         * tui/tui-layout.c (show_source_disasm_command): Simplify window
7065         resetting.
7066
7067 2019-07-17  Tom Tromey  <tom@tromey.com>
7068
7069         * tui/tui.h (tui_set_layout_by_name): Don't declare.
7070         * tui/tui-regs.c (tui_reg_layout): New function.
7071         (tui_show_registers, tui_reg_command): Use it.
7072         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
7073         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
7074         parameters.
7075         (tui_layout_command): Remove.
7076
7077 2019-07-17  Tom Tromey  <tom@tromey.com>
7078
7079         * tui/tui-layout.h (tui/tui-layout): Return void.
7080         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
7081
7082 2019-07-17  Tom Tromey  <tom@tromey.com>
7083
7084         * tui/tui-layout.c (show_source_disasm_command, show_data):
7085         Update.
7086         (reset_locator): Remove.
7087         (show_source_or_disasm_and_command): Update.
7088
7089 2019-07-17  Tom Tromey  <tom@tromey.com>
7090
7091         * tui/tui-source.c (tui_source_window_base::reset): Remove
7092         win_type parameter.
7093         * tui/tui-layout.c (make_command_window, make_source_window)
7094         (make_disasm_window, make_data_window)
7095         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7096         (reset_locator, show_source_or_disasm_and_command): Update.
7097         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7098         win_type parameter.
7099         (struct tui_source_window_base) <reset>: Likewise.
7100
7101 2019-07-17  Tom Tromey  <tom@tromey.com>
7102
7103         * tui/tui-layout.c (show_source_disasm_command): Use
7104         reset_locator.
7105         (reset_locator): New function.
7106         (init_and_make_win): Remove.
7107         (show_source_or_disasm_and_command): Use reset_locator.
7108
7109 2019-07-17  Tom Tromey  <tom@tromey.com>
7110
7111         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7112         condition.
7113         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7114         Remove condition.
7115         * tui/tui-source.c (tui_source_window_base::reset): New method.
7116         * tui/tui-layout.c (make_command_window): Don't call
7117         init_and_make_win.
7118         (make_source_window, make_disasm_window): Don't call
7119         make_source_or_disasm_window.
7120         (make_data_window): Don't call init_and_make_win.  Change calling
7121         convention.
7122         (show_source_disasm_command, show_data): Simplify.
7123         (make_source_or_disasm_window): Remove.
7124         (show_source_or_disasm_and_command): Simplify.
7125         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7126         (struct tui_source_window_base) <reset>: Likewise.
7127         <execution_info>: Remove initializer.
7128         * tui/tui-data.c (tui_source_window_base): Initialize
7129         execution_info.
7130
7131 2019-07-17  Tom Tromey  <tom@tromey.com>
7132
7133         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7134         variable.
7135
7136 2019-07-17  Tom Tromey  <tom@tromey.com>
7137
7138         * tui/tui.c (tui_rl_other_window): Update.
7139         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7140         superclass method first.  Always iterate over regs_content.
7141         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7142         method.
7143         * tui/tui-win.c (tui_set_focus_command): Update.
7144
7145 2019-07-17  Tom Tromey  <tom@tromey.com>
7146
7147         * tui/tui-win.c (tui_set_focus_command): Rename from
7148         tui_set_focus.  Call tui_enable.
7149         (tui_set_focus_command): Remove.
7150
7151 2019-07-17  Tom Tromey  <tom@tromey.com>
7152
7153         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7154         refresh_window.
7155         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7156         touchwin.
7157         (tui_data_window::refresh_window): Call refresh_window on data
7158         items.  Always call superclass refresh_window.
7159         (tui_win_info::refresh): Remove.
7160         (tui_source_window_base::refresh_window): Update.
7161         (tui_refresh_all): Update.
7162         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7163         refresh_window.
7164         (show_source_or_disasm_and_command): Likewise.
7165         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7166         (struct tui_source_window_base) <refresh>: Likewise.
7167
7168 2019-07-17  Tom Tromey  <tom@tromey.com>
7169
7170         * tui/tui-winsource.c (tui_clear_source_content)
7171         (tui_show_source_content): Update.
7172         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7173         whether content is empty.
7174         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7175         Remove.
7176
7177 2019-07-17  Tom Tromey  <tom@tromey.com>
7178
7179         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7180         window's contents.
7181         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7182         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7183
7184 2019-07-17  Tom Tromey  <tom@tromey.com>
7185
7186         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7187         (struct tui_data_item_window): Update.
7188
7189 2019-07-17  Tom Tromey  <tom@tromey.com>
7190
7191         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7192         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7193         defines.
7194
7195 2019-07-17  Tom Tromey  <tom@tromey.com>
7196
7197         * tui/tui-winsource.h (tui_erase_source_content)
7198         (tui_clear_source_content): Remove "display_prompt" parameter.
7199         * tui/tui-winsource.c (tui_update_source_window_as_is)
7200         (tui_update_source_windows_with_addr): Update.
7201         (tui_clear_source_content): Remove "display_prompt" parameter.
7202         (tui_erase_source_content): Likewise.  Simplify.
7203         (tui_show_source_content): Update.
7204         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7205         * tui/tui-stack.c (tui_show_frame_info): Update.
7206         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7207         Remove defines.
7208
7209 2019-07-17  Tom Tromey  <tom@tromey.com>
7210
7211         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7212         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7213         parameter.
7214         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7215         parameter.
7216
7217 2019-07-17  Tom Tromey  <tom@tromey.com>
7218
7219         * tui/tui-winsource.c (tui_clear_source_content)
7220         (tui_show_source_content, tui_show_exec_info_content)
7221         (tui_clear_exec_info_content): Update.
7222         * tui/tui-stack.c (tui_show_locator_content): Update.
7223         (tui_show_frame_info): Update.
7224         * tui/tui-source.h (tui_source_window): Don't declare.
7225         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7226         from tui_source_is_displayed.
7227         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7228         Remove field.
7229         (struct tui_source_window_base) <content_in_use>: New field.  Now
7230         bool.
7231         (struct tui_source_window) <showing_source_p>: New method.
7232         (TUI_SRC_WIN): Change cast.
7233         * tui/tui-data.c (tui_initialize_static_data): Update.
7234
7235 2019-07-17  Tom Tromey  <tom@tromey.com>
7236
7237         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7238         location_matches_p.
7239         * tui/tui-source.c (tui_source_window::location_matches_p): New
7240         method.
7241         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7242         method.
7243         * tui/tui-data.h (struct tui_source_window_base)
7244         <location_matches_p>: New method.
7245         (struct tui_source_window, struct tui_disasm_window)
7246         <location_matches_p>: Likewise.
7247
7248 2019-07-17  Tom Tromey  <tom@tromey.com>
7249
7250         * tui/tui-win.c (tui_set_win_height_command): Rename from
7251         tui_set_win_height.
7252         (tui_set_win_height_command): Remove.
7253
7254 2019-07-17  Tom Tromey  <tom@tromey.com>
7255
7256         * tui/tui-source.c (tui_source_window): New constructor.  Add
7257         observer.
7258         (~tui_source_window): New destructor.
7259         (tui_source_window::style_changed): New method.
7260         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7261         (tui_attach_detach_observers): Update.
7262         * tui/tui-data.h (struct tui_source_window): Make constructor not
7263         inline.  Add destructor.
7264         (struct tui_source_window) <style_changed>: New method.
7265         <m_observable>: New member.
7266
7267 2019-07-17  Tom Tromey  <tom@tromey.com>
7268
7269         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7270         * tui/tui-win.c (tui_resize_all): Fix typo.
7271
7272 2019-07-17  Tom Tromey  <tom@tromey.com>
7273
7274         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7275         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7276         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7277         * tui/tui-win.c (window_name_completer): Use foreach.
7278         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7279         (update_tab_width): Likewise.
7280         * tui/tui-layout.c (show_layout): Update.
7281         * tui/tui-data.h (class tui_window_iterator): New.
7282         (struct all_tui_windows): New.
7283         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7284
7285 2019-07-17  Tom Tromey  <tom@tromey.com>
7286
7287         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7288         parameter.  Don't reference globals.
7289         (tui_reg_command): Update.
7290
7291 2019-07-17  Tom Tromey  <tom@tromey.com>
7292
7293         * tui/tui-regs.c (tui_show_registers): Simplify.
7294
7295 2019-07-17  Tom Tromey  <tom@tromey.com>
7296
7297         * tui/tui-regs.c (tui_show_registers): Update.
7298         (tui_show_register_group): Add win_info parameter.
7299
7300 2019-07-17  Tom Tromey  <tom@tromey.com>
7301
7302         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7303         Rename from tui_display_reg_element_at_line.
7304         (tui_data_window::display_registers_from_line): Update.
7305         * tui/tui-data.h (struct tui_data_window)
7306         <display_reg_element_at_line>: New method.
7307
7308 2019-07-17  Tom Tromey  <tom@tromey.com>
7309
7310         * tui/tui-regs.h (tui_display_registers_from)
7311         (tui_display_registers_from_line): Don't declare.
7312         * tui/tui-windata.c (tui_data_window::display_all_data)
7313         (tui_data_window::refresh_all)
7314         (tui_data_window::do_scroll_vertical): Update.
7315         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7316         from tui_display_registers_from.
7317         (tui_display_reg_element_at_line): Update.
7318         (tui_data_window::display_registers_from_line): Rename from
7319         tui_display_registers_from_line.
7320         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7321         display_registers_from_line>: New methods.
7322
7323 2019-07-17  Tom Tromey  <tom@tromey.com>
7324
7325         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7326         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7327         from tui_erase_data_content.
7328         (tui_data_window::display_all_data)
7329         (tui_data_window::refresh_all)
7330         (tui_data_window::do_scroll_vertical): Update.
7331         * tui/tui-regs.c (tui_show_registers): Update.
7332         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7333         New method.
7334
7335 2019-07-17  Tom Tromey  <tom@tromey.com>
7336
7337         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7338         declare.
7339         * tui/tui-windata.c
7340         (tui_data_window::delete_data_content_windows): Rename from
7341         tui_delete_data_content_windows.
7342         (tui_data_window::display_all_data)
7343         (tui_data_window::do_scroll_vertical): Update.
7344         * tui/tui-data.h (struct tui_data_window)
7345         <delete_data_content_windows>: New method.
7346
7347 2019-07-17  Tom Tromey  <tom@tromey.com>
7348
7349         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7350         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7351
7352 2019-07-17  Tom Tromey  <tom@tromey.com>
7353
7354         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7355         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7356         from tui_display_all_data.
7357         * tui/tui-win.c
7358         (tui_data_window::do_make_visible_with_new_height): Update.
7359         * tui/tui-regs.c (tui_show_registers): Update.
7360         * tui/tui-layout.c (tui_set_layout): Update.
7361         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7362         method.
7363
7364 2019-07-17  Tom Tromey  <tom@tromey.com>
7365
7366         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7367         * tui/tui-windata.c (tui_display_data_from): Remove.
7368         (tui_data_window::refresh_all): Update.
7369
7370 2019-07-17  Tom Tromey  <tom@tromey.com>
7371
7372         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7373         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7374         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7375         tui_display_registers_from_line.
7376         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7377         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7378         "force_display" parameter.
7379
7380 2019-07-17  Tom Tromey  <tom@tromey.com>
7381
7382         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7383         declare.
7384         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7385         Rename from tui_first_reg_element_no_inline.
7386         (tui_display_reg_element_at_line)
7387         (tui_display_registers_from_line): Update.
7388         * tui/tui-data.h (struct tui_data_window)
7389         <first_reg_element_no_inline>: New method.
7390
7391 2019-07-17  Tom Tromey  <tom@tromey.com>
7392
7393         * tui/tui-windata.c (tui_display_data_from)
7394         (tui_data_window::do_scroll_vertical): Update.
7395         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7396         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7397         Rename from tui_line_from_reg_element_no.
7398         (tui_display_registers_from_line): Update.
7399         * tui/tui-data.h (struct tui_data_window)
7400         <line_from_reg_element_no>: New method.
7401
7402 2019-07-17  Tom Tromey  <tom@tromey.com>
7403
7404         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7405         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7406         tui_last_regs_line_no.
7407         (tui_display_reg_element_at_line)
7408         (tui_display_registers_from_line): Update.
7409         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7410         method.
7411
7412 2019-07-17  Tom Tromey  <tom@tromey.com>
7413
7414         PR tui/24722:
7415         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7416         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7417         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7418         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7419         (tui_update_breakpoint_info): Likewise.
7420         * tui/tui-hooks.c (tui_event_create_breakpoint)
7421         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7422         Update.
7423
7424 2019-07-17  Tom Tromey  <tom@tromey.com>
7425
7426         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7427
7428 2019-07-17  Tom Tromey  <tom@tromey.com>
7429
7430         * tui/tui-winsource.c (tui_update_source_window_as_is)
7431         (tui_update_source_windows_with_addr): Update.
7432         * tui/tui-source.h (tui_set_source_content)
7433         (tui_show_symtab_source): Add "win_info" parameter.
7434         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7435         parameter.
7436         (tui_show_symtab_source): Likewise.
7437
7438 2019-07-17  Tom Tromey  <tom@tromey.com>
7439
7440         * tui/tui-wingeneral.c
7441         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7442
7443 2019-07-17  Tom Tromey  <tom@tromey.com>
7444
7445         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7446         (struct tui_cmd_window) <can_scroll>: New method.
7447         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7448         method.
7449
7450 2019-07-17  Tom Tromey  <tromey@adacore.com>
7451
7452         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7453         do_field_signed>: Rename.  Change type of "value".
7454         * ui-out.c (ui_out::field_signed): Rename from field_int.
7455         Change type of "value".
7456         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7457         type of "value".
7458         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7459         do_field_int.  Change type of "value".
7460         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7461         do_field_int.  Change type of "value".
7462         * tracepoint.c (trace_status_mi, tfind_1)
7463         (print_one_static_tracepoint_marker): Update.
7464         * thread.c (print_thread_info_1, print_selected_thread_frame):
7465         Update.
7466         * stack.c (print_frame, print_frame_info): Update.
7467         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7468         Update.
7469         * source.c (print_source_lines_base): Update.
7470         * skip.c (info_skip_command): Update.
7471         * record-btrace.c (btrace_ui_out_decode_error)
7472         (btrace_call_history_src_line): Update.
7473         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7474         Update.
7475         * progspace.c (print_program_space): Update.
7476         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7477         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7478         do_field_int.  Change type of "value".
7479         * mi/mi-out.c (mi_ui_out::do_table_begin)
7480         (mi_ui_out::do_table_header): Update.
7481         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7482         type of "value".
7483         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7484         (mi_cmd_data_list_changed_registers, output_register)
7485         (mi_cmd_data_read_memory, mi_load_progress)
7486         (mi_cmd_trace_frame_collected): Update.
7487         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7488         Update.
7489         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7490         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7491         (mi_cmd_var_list_children, varobj_update_one): Update.
7492         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7493         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7494         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7495         * inferior.c (print_inferior): Update.
7496         * gdb_bfd.c (print_one_bfd): Update.
7497         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7498         Update.
7499         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7500         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7501         do_field_int.  Change type of "value".
7502         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7503         do_field_int.  Change type of "value".
7504         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7505         (print_one_breakpoint_location, print_it_catch_fork)
7506         (print_one_catch_fork, print_it_catch_vfork)
7507         (print_one_catch_vfork, print_it_catch_solib)
7508         (print_it_catch_exec, print_it_ranged_breakpoint)
7509         (print_mention_watchpoint, print_mention_masked_watchpoint)
7510         (bkpt_print_it, update_static_tracepoint): Update.
7511         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7512         * break-catch-syscall.c (print_it_catch_syscall): Update.
7513         * ada-tasks.c (print_ada_task_info): Update.
7514         * ada-lang.c (print_it_exception, print_mention_exception):
7515         Update.
7516
7517 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         PR breakpoints/24541
7520         * gdbarch.c: Regenerate.
7521         * gdbarch.h: Regenerate.
7522         * gdbarch.sh: Adjust return type and parameter types for
7523         'stap_adjust_register'.
7524         (i386_stap_adjust_register): Adjust signature and return new
7525         register name.
7526         * stap-probe.c (stap_parse_register_operand): Adjust use of
7527         'gdbarch_stap_adjust_register'.
7528
7529 2019-07-17  Tom Tromey  <tromey@adacore.com>
7530
7531         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7532         declare VEC.
7533         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7534         std::vector.
7535         (struct s390_process_info): Add initializers.
7536         (s390_add_process): Use new.
7537         (s390_linux_nat_target::low_forget_process): Use delete.
7538         (s390_linux_nat_target::low_new_fork)
7539         (s390_linux_nat_target::stopped_by_watchpoint)
7540         (s390_linux_nat_target::low_prepare_to_resume)
7541         (s390_linux_nat_target::insert_watchpoint)
7542         (s390_linux_nat_target::insert_hw_breakpoint)
7543         (s390_linux_nat_target::remove_watchpoint)
7544         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7545
7546 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7547
7548         * aarch64-fbsd-nat.c: Include regcache.h.
7549         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7550         argument.
7551         (aarch64_fbsd_nat_target::fetch_registers)
7552         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7553         variable.
7554         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7555
7556 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7557
7558         * fbsd-nat.c: Include gdbarch.h.
7559
7560 2019-07-15  Tom Tromey  <tromey@adacore.com>
7561
7562         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7563
7564 2019-07-15  Tom Tromey  <tromey@adacore.com>
7565
7566         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7567         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7568         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7569         * cli-out.c (cli_ui_out::do_field_int): New method.
7570         * ui-out.c (ui_out::field_unsigned): New method.
7571         * symfile.c (generic_load): Use field_unsigned.
7572         (print_transfer_performance): Likewise.
7573         * record-btrace.c (ui_out_field_uint): Remove.
7574         (btrace_call_history_insn_range, btrace_call_history): Use
7575         field_unsigned.
7576         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7577         field_unsigned.
7578         * ui-out.h (class ui_out) <field_unsigned>: New method.
7579         <do_field_unsigned>: Likewise.
7580
7581 2019-07-15  Tom Tromey  <tromey@adacore.com>
7582
7583         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7584         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7585         * target.c (flash_erase_command): Use field_string.
7586         * infrun.c (print_signal_received_reason): Use field_string.
7587         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7588         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7589         field_string.
7590         * ada-tasks.c (print_ada_task_info): Use field_string.
7591
7592 2019-07-15  Tom Tromey  <tromey@adacore.com>
7593
7594         * target.c (flash_erase_command): Use field_core_addr.
7595         * symfile.c (generic_load): Use field_core_addr.
7596         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7597         Use field_core_addr.
7598         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7599         field_core_addr.
7600
7601 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7604         value if its desired type is smaller than a CORE_ADDR and signed.
7605
7606 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7609         of changes to field names, and use new is_reference field to
7610         decide if a property is a reference or not.
7611         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7612         field.
7613         (struct dwarf2_property_baton): Update header comment, rename
7614         'referenced_type' to 'property_type' and update comments.
7615         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7616         default property type, store in property baton, update to take
7617         accound of renamed field.
7618         (read_func_scope): Update call to attr_to_dynamic_prop.
7619         (read_array_type): Likewise.
7620         (dwarf2_per_cu_addr_sized_int_type): New function.
7621         (read_subrange_index_type): Move type finding code to
7622         dwarf2_per_cu_addr_sized_int_type.
7623         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7624         (dwarf2_per_cu_addr_type): New function.
7625         (set_die_type): Update calls to attr_to_dynamic_prop.
7626
7627 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7628
7629         * dwarf2read.c (read_subrange_index_type): New function.
7630         (read_subrange_type): Move code into new function and call it.
7631         * gdbtypes.c (create_range_type): Add some asserts.
7632
7633 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7636         update return statements.
7637         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7638         declaration, and update comment to match.
7639         * gdbtypes.c (resolve_dynamic_array): Update call to
7640         dwarf2_evaluate_property to match new return type.
7641
7642 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * valarith.c (value_subscripted_rvalue): Change lowerbound
7645         parameter type from int to LONGEST.
7646         * value.h (value_subscripted_rvalue): Likewise in declaration.
7647
7648 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7649
7650         * cli/cli-utils.c (info_print_command_completer): New function.
7651         * cli/cli-utils.h: Add 'completer.h' include, and forward
7652         declaration for 'struct cmd_list_element'.
7653         (info_print_command_completer): Declare.
7654         * stack.c (_initialize_stack): Add completer for 'info locals' and
7655         'info args'.
7656         * symtab.c (_initialize_symtab): Add completer for 'info
7657         variables' and 'info functions'.
7658         * NEWS: Mention completion for additional info commands.
7659
7660 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * cli/cli-utils.c (extract_info_print_args): Delete.
7663         (extract_arg_maybe_quoted): Delete.
7664         (info_print_options_defs): New variable.
7665         (make_info_print_options_def_group): New function.
7666         (extract_info_print_options): Define new function.
7667         * cli/cli-utils.h (extract_info_print_args): Delete.
7668         (struct info_print_options): New structure.
7669         (extract_info_print_options): Declare new function.
7670         * stack.c (info_locals_command): Update to use new
7671         extract_info_print_options, also add a header comment.
7672         (info_args_command): Likewise.
7673         * symtab.c (info_variables_command): Likewise.
7674         (info_functions_command): Likewise.
7675
7676 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7679         to extract string arguments.
7680         * common/common-utils.c (extract_string_maybe_quoted): New function.
7681         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7682
7683 2019-07-11  Tom Tromey  <tromey@adacore.com>
7684
7685         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7686         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7687         * top.h (gdbinit): Don't declare.
7688         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7689         into...
7690         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7691         * top.c (gdb_init): Don't call init_cli_cmds.
7692         (gdbinit): Remove.
7693         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7694
7695 2019-07-11  Tom Tromey  <tromey@adacore.com>
7696
7697         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7698         after it has been moved.
7699
7700 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7701
7702         * valops.c (value_must_coerce_to_target): Change return type to
7703         bool.
7704         * value.h (value_must_coerce_to_target): Likewise.
7705
7706 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7707
7708         * breakpoint.c (is_hardware_watchpoint): Remove
7709         forward-declaration.
7710         (is_masked_watchpoint): Change return type to bool.
7711         (is_tracepoint): Likewise.
7712         (is_breakpoint): Likewise.
7713         (is_hardware_watchpoint): Likewise.
7714         (is_watchpoint): Likewise.
7715         (is_no_memory_software_watchpoint): Likewise.
7716         (is_catchpoint): Likewise.
7717         (breakpoint_1): Make FILTER parameter's return type bool.
7718         is_masked_watchpoint): Change return type to bool.
7719         (save_breakpoints): Make FILTER parameter's return type bool.
7720         * breakpoint.h (is_breakpoint): Change return type to bool.
7721         (is_watchpoint): Likewise.
7722         (is_catchpoint): Likewise.
7723         (is_tracepoint): Likewise.
7724
7725 2019-07-10  Tom Tromey  <tom@tromey.com>
7726
7727         * defs.h: Don't include gdbarch.h.
7728         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7729         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7730         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7731         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7732         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7733         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7734         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7735         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7736         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7737         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7738         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7739         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7740         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7741         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7742         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7743         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7744         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7745         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7746         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7747         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7748         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7749         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7750         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7751         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7752         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7753         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7754         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7755
7756 2019-07-10  Tom Tromey  <tromey@adacore.com>
7757
7758         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7759         * breakpoint.c (init_ada_exception_breakpoint): Register as
7760         bp_catchpoint.
7761         (print_one_breakpoint_location, print_one_breakpoint): Use
7762         is_ada_exception_catchpoint.
7763         * ada-lang.c (class ada_catchpoint_location): Pass
7764         bp_loc_software_breakpoint to bp_location constructor.
7765         (is_ada_exception_catchpoint): New function.
7766
7767 2019-07-10  Tom Tromey  <tromey@adacore.com>
7768
7769         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7770         VEC.
7771         (struct arm_exidx_entry): New method operator<.
7772         (struct arm_exidx_data) <section_maps>: Change type.
7773         (arm_exidx_data_free): Remove.
7774         (arm_exidx_data_key): Change type.  Move lower.
7775         (arm_exidx_new_objfile): Update.
7776         (arm_compare_exidx_entries): Remove.
7777         (arm_find_exidx_entry, _initialize_arm_tdep)
7778
7779 2019-07-10  Tom Tromey  <tromey@adacore.com>
7780
7781         * solib-spu.c (ocl_program_data_key): Change type.
7782         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7783         Update.
7784
7785 2019-07-10  Tom Tromey  <tromey@adacore.com>
7786
7787         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7788         (struct solib_aix_inferior_data) <library_list>: Change type.
7789         (solib_aix_inferior_data_handle): Change type.
7790         (get_solib_aix_inferior_data): Update.
7791         (solib_aix_free_library_list): Remove.
7792         (library_list_start_library): Update.
7793         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7794         return type.
7795         (solib_aix_get_library_list)
7796         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7797         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7798
7799 2019-07-10  Tom Tromey  <tromey@adacore.com>
7800
7801         * solib-dsbt.c (struct dsbt_info): Add initializers.
7802         (solib_dsbt_pspace_data): Change type.
7803         (dsbt_pspace_data_cleanup): Remove.
7804         (get_dsbt_info, _initialize_dsbt_solib): Update.
7805
7806 2019-07-10  Tom Tromey  <tromey@adacore.com>
7807
7808         * spu-tdep.c (spu_overlay_data): Change type.
7809         (spu_get_overlay_table, spu_overlay_new_objfile)
7810         (_initialize_spu_tdep): Update.
7811
7812 2019-07-10  Tom Tromey  <tromey@adacore.com>
7813
7814         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7815         destructor.
7816         (dbx_objfile_data_key): Change type and declare later.
7817         (DBX_SYMFILE_INFO): Rewrite.
7818         * dbxread.c (dbx_objfile_data_key): Change type.
7819         (dbx_symfile_init): Update.
7820         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7821         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7822         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7823
7824 2019-07-10  Tom Tromey  <tromey@adacore.com>
7825
7826         * jit.c (jit_program_space_key): Change type.  Move lower.
7827         (get_jit_program_space_data): Update.
7828         (jit_program_space_data_cleanup): Remove.
7829         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7830         Update.
7831         (struct jit_program_space_data): Add initializers.
7832
7833 2019-07-10  Tom Tromey  <tromey@adacore.com>
7834
7835         * solib-darwin.c (struct darwin_info): Add initializers.
7836         (solib_darwin_pspace_data): Change type.
7837         (darwin_pspace_data_cleanup): Remove.
7838         (get_darwin_info, _initialize_darwin_solib): Update.
7839
7840 2019-07-10  Tom Tromey  <tromey@adacore.com>
7841
7842         * remote-sim.c (struct sim_inferior_data): Add initializers,
7843         constructor, and destructor.
7844         (sim_inferior_data_key): Change type.  Move lower.
7845         (check_for_duplicate_sim_descriptor): Update.
7846         (get_sim_inferior_data): Use new.  Update.
7847         (~sim_inferior_data_cleanup): Rename from
7848         sim_inferior_data_cleanup.  Simplify.
7849         (gdbsim_close_inferior, simulator_command)
7850         (sim_command_completer, _initialize_remote_sim): Update.
7851         (next_pid, INITIAL_PID): Move earlier.
7852
7853 2019-07-10  Tom Tromey  <tromey@adacore.com>
7854
7855         * python/python-internal.h (create_thread_object): Return
7856         gdbpy_ref.
7857         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7858         * python/py-inferior.c (struct threadlist_entry): Add
7859         constructor.
7860         <thread_obj>: Now a gdbpy_ref.
7861         (thread_to_thread_object): Update.
7862         (add_thread_object): Use new.
7863         (delete_thread_object): Use delete.
7864         (infpy_threads): Update.
7865         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7866         GIL.
7867
7868 2019-07-10  Tom Tromey  <tromey@adacore.com>
7869
7870         * valops.c (value_cast): Specialize error message for Ada.
7871
7872 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7873
7874         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7875
7876 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7877
7878         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7879         bpstat_should_step): Return bool, adjust comments.
7880         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7881         bpstat_should_step): Likewise.
7882
7883 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7884
7885         * features/Makefile: Use feature target descriptions for Arm.
7886         * features/arm/arm-core.c: Generate new file.
7887         * features/arm/arm-fpa.c: Likewise.
7888         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7889         * features/arm/arm-m-profile.c: Likewise.
7890         * features/arm/arm-vfpv2.c: Likewise.
7891         * features/arm/arm-vfpv3.c: Likewise.
7892         * features/arm/xscale-iwmmxt.c: Likewise.
7893         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7894
7895 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7896
7897         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7898         ptrace earlier.
7899
7900 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7901
7902         * features/aarch64-pauth.c: Regenerate.
7903
7904 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7905
7906         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7907         bool.
7908         (bpstat_what): Use false instead of 0.
7909
7910 2019-07-09  Pedro Alves  <palves@redhat.com>
7911
7912         * break-catch-throw.c (is_exception_catchpoint): New.
7913         * breakpoint.c (print_one_breakpoint_location): New parameter
7914         'raw_loc'.  Handle it.  Use
7915         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7916         looking at the breakpoint's type.
7917         (print_one_breakpoint): If handling "maint info breakpoints", also
7918         print locations of exception catchpoints.
7919         * breakpoint.h (is_exception_catchpoint): Declare.
7920
7921 2019-07-09  Pedro Alves  <palves@redhat.com>
7922
7923         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7924         "addr" field.
7925         (allocate_location_exception_catchpoint): New.
7926         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7927         (initialize_throw_catchpoint_ops): Install
7928         allocate_location_exception_catchpoint as allocate_location
7929         method.
7930         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7931         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7932         bp_loc_other.
7933         (breakpoint_address_is_meaningful): Delete.
7934         (bl_address_is_meaningful): New.
7935         (breakpoint_locations_match): Adjust comment.
7936         (bp_location_from_bp_type): New, factored out of...
7937         (bp_location::bp_location(breakpoint *)): ... this.
7938         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7939         factored out of...
7940         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7941         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7942         breakpoint_address_is_meaningful.
7943         (bp_locations_compare): Adjust comment.
7944         (update_global_location_list): Use bl_address_is_meaningful
7945         instead of breakpoint_address_is_meaningful.
7946         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7947         explicit.
7948         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7949         * python/py-breakpoint.c (bppy_get_location): No longer check
7950         whether location is null.
7951
7952 2019-07-09  Pedro Alves  <palves@redhat.com>
7953
7954         PR c++/15468
7955         * breakpoint.c (print_one_breakpoint_location): Remove
7956         single-location assert.
7957
7958 2019-07-09  Tom Tromey  <tom@tromey.com>
7959
7960         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7961         * configure: Rebuild.
7962         * configure.ac: Change common to gdbsupport.
7963         * gdbsupport: Rename from common.
7964         * acinclude.m4: Change common to gdbsupport.
7965         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7966         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7967         gdbsupport.
7968         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7969         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7970         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7971         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7972         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7973         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7974         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7975         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7976         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7977         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7978         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7979         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7980         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7981         coff-pe-read.c, command.h, compile/compile-c-support.c,
7982         compile/compile-c.h, compile/compile-cplus-symbols.c,
7983         compile/compile-cplus-types.c, compile/compile-cplus.h,
7984         compile/compile-loc2c.c, compile/compile.c, completer.c,
7985         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7986         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7987         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7988         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7989         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7990         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7991         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7992         features/aarch64-core.c, features/aarch64-fpu.c,
7993         features/aarch64-pauth.c, features/aarch64-sve.c,
7994         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7995         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7996         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7997         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7998         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7999         features/i386/64bit-core.c, features/i386/64bit-linux.c,
8000         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
8001         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
8002         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
8003         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
8004         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
8005         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
8006         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
8007         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
8008         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
8009         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
8010         go32-nat.c, guile/guile.c, guile/scm-ports.c,
8011         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
8012         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
8013         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
8014         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
8015         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
8016         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
8017         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
8018         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
8019         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
8020         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
8021         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
8022         minsyms.c, mips-linux-tdep.c, namespace.h,
8023         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
8024         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
8025         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
8026         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
8027         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
8028         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
8029         nat/linux-waitpid.c, nat/mips-linux-watch.c,
8030         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
8031         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
8032         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
8033         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
8034         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
8035         procfs.c, producer.c, progspace.h, psymtab.h,
8036         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
8037         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
8038         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
8039         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
8040         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
8041         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
8042         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
8043         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
8044         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
8045         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
8046         target-memory.c, target.c, target.h, target/waitstatus.c,
8047         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
8048         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
8049         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
8050         unittests/array-view-selftests.c,
8051         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
8052         unittests/common-utils-selftests.c,
8053         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
8054         unittests/format_pieces-selftests.c,
8055         unittests/function-view-selftests.c,
8056         unittests/lookup_name_info-selftests.c,
8057         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
8058         unittests/mkdir-recursive-selftests.c,
8059         unittests/observable-selftests.c,
8060         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
8061         unittests/parse-connection-spec-selftests.c,
8062         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
8063         unittests/scoped_fd-selftests.c,
8064         unittests/scoped_mmap-selftests.c,
8065         unittests/scoped_restore-selftests.c,
8066         unittests/string_view-selftests.c, unittests/style-selftests.c,
8067         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
8068         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
8069         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
8070         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
8071         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
8072         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
8073
8074 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * linespec.c (decode_digits_list_mode): Set explicit_line to a
8077         bool value.
8078         (decode_digits_ordinary): Set explicit_line field in sal.
8079         * symtab.c (skip_prologue_sal): Don't skip prologue for a
8080         symtab_and_line that was set on an explicit line number in
8081         assembler code.  Do always update the recorded symtab and line if
8082         we do skip the prologue.
8083
8084 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8085
8086         * breakpoint.c (set_breakpoint_location_function): Remove
8087         explicit_loc parameter.
8088         (momentary_breakpoint_from_master): Update call to
8089         set_breakpoint_location_function.
8090         (add_location_to_breakpoint): Likewise.
8091
8092 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8093
8094         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8095         required features based on default bfd type when no specific bfd
8096         is present.
8097
8098 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8099
8100         * NEWS: Mention that GDB printf and eval commands can now print
8101         C-style and Ada-style convenience var strings without
8102         calling the inferior.
8103         * printcmd.c (printf_c_string): Locally print GDB internal var
8104         instead of transiting via the inferior.
8105         (printf_wide_c_string): Likewise.
8106
8107 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8108
8109         PR breakpoints/25011
8110         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8111
8112 2019-07-04  Tom Tromey  <tom@tromey.com>
8113
8114         PR tui/24724:
8115         * tui/tui-winsource.c (tui_clear_source_content): Update.
8116         (tui_source_window_base::set_is_exec_point_at): Fix comment.
8117         (tui_update_breakpoint_info): Update.
8118         (tui_set_exec_info_content): Update.
8119         * tui/tui-source.c (tui_set_source_content_nil): Update.
8120         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8121         has_break.
8122         * tui/tui-data.h (enum tui_bp_flag): New.
8123         (tui_bp_flags): New enum flags type.
8124         (struct tui_source_element) <break_mode>: Change type.  Rename
8125         from has_break.
8126         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8127         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
8128         constants.
8129         * tui/tui-winsource.h: Fix comment.
8130
8131 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8132
8133         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8134         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8135         (store_fpregs_to_thread)
8136         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8137         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8138         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8139         (IWMMXT_REGS_SIZE): Add define.
8140         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8141         (fetch_vfp_regs, store_vfp_regs)
8142         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8143         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8144
8145 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8146
8147         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8148         defines.
8149         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8150         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8151         (ARM_INT_REGISTER_SIZE): ...to this.
8152         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8153         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8154         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8155         (arm_linux_collect_gregset, supply_nwfpe_register)
8156         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8157         defines.
8158         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8159         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8160         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8161         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8162         (arm_return_in_memory, arm_store_return_value)
8163         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8164         (arm_record_ld_st_multiple): Likewise.
8165         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8166         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8167
8168 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8169
8170         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8171         AARCH64_DISPLACED_MODIFIED_INSNS.
8172         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8173         (aarch64_displaced_step_copy_insn): Likewise.
8174         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8175         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8176         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8177         ARM_DISPLACED_MODIFIED_INSNS.
8178         * arm-tdep.c (arm_gdbarch_init): Likewise.
8179         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8180         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8181         (struct arm_displaced_step_closure): Use
8182         ARM_DISPLACED_MODIFIED_INSNS.
8183
8184 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8185
8186         * features/Makefile: Remove unused xml files.
8187         * features/aarch64.xml: Remove.
8188         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8189         * features/i386/amd64-avx-avx512.xml: Remove.
8190         * features/i386/amd64-avx-linux.xml: Remove.
8191         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8192         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8193         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8194         * features/i386/amd64-avx-mpx.xml: Remove.
8195         * features/i386/amd64-avx.xml: Remove.
8196         * features/i386/amd64-linux.xml: Remove.
8197         * features/i386/amd64-mpx-linux.xml: Remove.
8198         * features/i386/amd64-mpx.xml: Remove.
8199         * features/i386/amd64.xml: Remove.
8200         * features/i386/i386-avx-avx512-linux.xml: Remove.
8201         * features/i386/i386-avx-avx512.xml: Remove.
8202         * features/i386/i386-avx-linux.xml: Remove.
8203         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8204         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8205         * features/i386/i386-avx-mpx-linux.xml: Remove.
8206         * features/i386/i386-avx-mpx.xml: Remove.
8207         * features/i386/i386-avx.xml: Remove.
8208         * features/i386/i386-linux.xml: Remove.
8209         * features/i386/i386-mmx-linux.xml: Remove.
8210         * features/i386/i386-mmx.xml: Remove.
8211         * features/i386/i386-mpx-linux.xml: Remove.
8212         * features/i386/i386-mpx.xml: Remove.
8213         * features/i386/i386.xml: Remove.
8214         * features/i386/x32-avx-avx512-linux.xml: Remove.
8215         * features/i386/x32-avx-linux.xml: Remove.
8216         * features/i386/x32-linux.xml: Remove.
8217
8218 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8219
8220         * regformats/aarch64.dat: Remove.
8221         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8222         * regformats/i386/amd64-avx-linux.dat: Remove.
8223         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8224         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8225         * regformats/i386/amd64-linux.dat: Remove.
8226         * regformats/i386/amd64-mpx-linux.dat: Remove.
8227         * regformats/i386/amd64.dat: Remove.
8228         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8229         * regformats/i386/i386-avx-linux.dat: Remove.
8230         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8231         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8232         * regformats/i386/i386-linux.dat: Remove.
8233         * regformats/i386/i386-mmx-linux.dat: Remove.
8234         * regformats/i386/i386-mpx-linux.dat: Remove.
8235         * regformats/i386/i386.dat: Remove.
8236         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8237         * regformats/i386/x32-avx-linux.dat: Remove.
8238         * regformats/i386/x32-linux.dat: Remove.
8239
8240 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8241
8242         * aarch64-tdep.c: Remove xml self tests.
8243         * amd64-linux-tdep.c: Likewise.
8244         * amd64-tdep.c: Likewise.
8245         * i386-linux-tdep.c: Likewise.
8246         * i386-tdep.c: Likewise.
8247
8248 2019-07-03  Pedro Alves  <palves@redhat.com>
8249
8250         PR cli/24732
8251         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8252         (pipe_cmd_option_defs): New.
8253         (make_pipe_cmd_options_def_group): New.
8254         (pipe_command): Use gdb::option::process_options.
8255         (pipe_command_completer): New function.
8256         (_initialize_cli_cmds): Install completer for "pipe" command.
8257
8258 2019-07-03  Pedro Alves  <palves@redhat.com>
8259
8260         * cli/cli-option.c (union option_value) <string>: New field.
8261         (struct option_def_and_value): Add ctor, move ctor, dtor and
8262         use DISABLE_COPY_AND_ASSIGN.
8263         (option_def_and_value::clear_value): New.
8264         (parse_option, save_option_value_in_ctx, get_val_type_str)
8265         (add_setshow_cmds_for_options): Handle var_string.
8266         * cli-option.h (union option_def::var_address) <string>: New
8267         field.
8268         (struct string_option_def): New.
8269         * maint-test-options.c (struct test_options_opts): Add default
8270         ctor and use DISABLE_COPY_AND_ASSIGN.
8271         <string_opt>: New field.
8272         (test_options_opts::~test_options_opts): New.
8273         (test_options_opts::dump): Also dump "-string".
8274         (test_options_option_defs): Install "string.
8275
8276 2019-07-03  Pedro Alves  <palves@redhat.com>
8277
8278         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8279         option_value with a null enumeration.
8280         (complete_options): Save the option values in the context.
8281         (save_option_value_in_ctx): New, factored out from ...
8282         (process_options): ... here.
8283         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8284         of the function.
8285         * maint-test-options.c (test_options_opts::dump): New, factored
8286         out from ...
8287         (maintenance_test_options_command_mode): ... here.
8288         (maintenance_test_options_command_completion_result): Delete.
8289         (maintenance_test_options_command_completion_text): Update
8290         comment.
8291         (maintenance_show_test_options_completion_result): Change
8292         prototype.  Just print
8293         maintenance_test_options_command_completion_text.
8294         (save_completion_result): New.
8295         (maintenance_test_options_completer_mode): Pass options context to
8296         complete_options, and then save a dump.
8297         (_initialize_maint_test_options): Use add_cmd to install "maint
8298         show test-options-completion-result".
8299
8300 2019-07-03  Pedro Alves  <palves@redhat.com>
8301
8302         * NEWS (New commands): Mention "with" and "maint with".
8303         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8304         (with_command, with_command_completer): New.
8305         (pipe_command): Adjust to new repeat_previous
8306         interface.
8307         (_initialize_cli_cmds): Install the "with" command and its "w"
8308         alias.
8309         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8310         declarations.
8311         * cli/cli-setshow.c (parse_cli_var_uinteger)
8312         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8313         argument strings for all var_types.
8314         (get_setshow_command_value_string): New, factored out from ...
8315         (do_show_command): ... this.
8316         * cli/cli-setshow.h: Include <string>.
8317         (get_setshow_command_value_string): Declare.
8318         * command.h (repeat_previous): Now returns const char *.  Adjust
8319         comment.
8320         * maint.c: Include "cli/cli-cmds.h".
8321         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8322         (_initialize_maint_cmds): Register the "maintenance with" command.
8323         * top.c (repeat_previous): Move bits from pipe_command here:
8324         Return the saved command line, if any; error out if there's no
8325         command to relaunch.
8326
8327 2019-07-03  Pedro Alves  <palves@redhat.com>
8328
8329         * NEWS (New commands): Mention "maint set/show test-settings"
8330         instead of "maint test-settings".
8331         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8332         (maintenance_test_settings_set_list): Rename to ...
8333         (maintenance_set_test_settings_list): ... this.
8334         (maintenance_test_settings_show_list): Rename to  ...
8335         (maintenance_show_test_settings_list): ... this.
8336         (maintenance_test_settings_cmd): Delete.
8337         (maintenance_test_settings_set_cmd): ...
8338         (maintenance_set_test_settings_cmd): ... this.
8339         (maintenance_test_settings_show_cmd): ...
8340         (maintenance_show_test_settings_cmd): ... this.
8341         (maintenance_test_settings_show_value_cmd):
8342         (maintenance_show_test_settings_value_cmd): ... this.
8343         (_initialize_maint_test_settings): No longer install the "maint
8344         test-settings" prefix command.  Rename "maint test-settings set"
8345         to "maint set test-settings", and "maint test-settings show" to
8346         "maint show test-settings".  Adjust all subcommands.
8347
8348 2019-07-03  Pedro Alves  <palves@redhat.com>
8349
8350         * maint-test-settings.c: Fix file's intro comment.  Replace all
8351         references to "test-options" with references to "test-settings",
8352         in comments.
8353
8354 2019-07-03  Pedro Alves  <palves@redhat.com>
8355
8356         * maint-test-settings.c (maintenance_test_settings_xxx)
8357         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8358         New.
8359         (maintenance_test_settings_enums): Use them.
8360         (maintenance_test_settings_enum): Default to
8361         maintenance_test_settings_xxx.
8362         (_initialize_maint_test_settings): Initialize
8363         MAINTENANCE_TEST_SETTINGS_FILENAME.
8364
8365 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8366
8367         * breakpoint.h (remove_breakpoints_inf): Change return type to
8368         void, move function documentation here.
8369         * breakpoint.c (remove_breakpoints_inf): Change return type to
8370         void, move function documentation to header.
8371
8372 2019-07-02  Pedro Alves  <palves@redhat.com>
8373
8374         * NEWS (Completion improvements): Mention "info threads".
8375         * thread.c (struct info_threads_opts, info_threads_option_defs)
8376         (make_info_threads_options_def_group): New.
8377         (info_threads_command): Use gdb::option::process_options.
8378         (info_threads_command_completer): New.
8379         (_initialize_thread): Use gdb::option::build_help to build the
8380         help text for "info threads".
8381
8382 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8383
8384         * defs.h (generic_load): Move from here...
8385         * symfile.h (generic_load): ... to here.  Rename name parameter
8386         to args.
8387         * symfile.c (generic_load): Add comment.
8388
8389 2019-07-01  Tom Tromey  <tromey@adacore.com>
8390
8391         * dwarf2read.c
8392         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8393         declaration of without_params.  Fix formatting.
8394
8395 2019-07-01  Tom Tromey  <tromey@adacore.com>
8396
8397         * ada-exp.y (find_primitive_type): Update.
8398         * ada-lang.h (ada_lookup_symbol): Update.
8399         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8400         parameter.
8401         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8402
8403 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8404
8405         PR breakpoints/24541
8406         * gdbarch.c: Regenerate.
8407         * gdbarch.h: Regenerate.
8408         * gdbarch.sh: Add 'stap_adjust_register'.
8409         * i386-tdep.c: Include '<unordered_set>'.
8410         (i386_stap_adjust_register): New function.
8411         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8412         * stap-probe.c (stap_parse_register_operand): Call
8413         'gdbarch_stap_adjust_register'.
8414
8415 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8416
8417         PR python/24742
8418         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8419         * python/python.c (do_start_initialization): Use 'xmalloc'
8420         instead of 'PyMem_Malloc'.
8421
8422 2019-06-28  Tom Tromey  <tromey@adacore.com>
8423
8424         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8425         for Ada.
8426
8427 2019-06-27  Tom Tromey  <tromey@adacore.com>
8428
8429         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8430         objfile_key.
8431         (arm_find_mapping_symbol, arm_record_special_symbol)
8432         (_initialize_arm_tdep): Update.
8433         (arm_objfile_data_free): Remove.
8434
8435 2019-06-27  Tom Tromey  <tromey@adacore.com>
8436
8437         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8438         to cp_print_static_field.
8439
8440 2019-06-26  Tom Tromey  <tromey@adacore.com>
8441
8442         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8443         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8444         declare.
8445
8446 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8447
8448         * features/aarch64-core.c (create_feature_aarch64_core):
8449         Regenerate.
8450         * features/aarch64-core.xml: Add cpsr flags.
8451
8452 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8453
8454         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8455         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8456
8457 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8458
8459         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8460         field.
8461         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8462         use.
8463         (arm_record_special_symbol): Don't insert new symbol in sorted
8464         position, push it at the end.
8465
8466 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8467
8468         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8469         (arm_mapping_symbol_s): Remove.
8470         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8471         (arm_mapping_symbol_vec): New typedef.
8472         (struct arm_per_objfile): Add constructor.
8473         <section_maps>: Change type to
8474         std::unique_ptr<arm_mapping_symbol_vec[]>.
8475         (arm_compare_mapping_symbols): Remove.
8476         (arm_find_mapping_symbol): Adjust to section_maps type change.
8477         (arm_objfile_data_free): Call delete on arm_per_objfile.
8478         (arm_record_special_symbol): Adjust to section_maps type change.
8479         Allocate arm_per_objfile with new.
8480
8481 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8482
8483         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8484         with the command prefix.
8485
8486 2019-06-25  Tom Tromey  <tom@tromey.com>
8487
8488         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8489         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8490
8491 2019-06-25  Tom Tromey  <tom@tromey.com>
8492
8493         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8494         type.
8495         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8496         protected.
8497
8498 2019-06-25  Tom Tromey  <tom@tromey.com>
8499
8500         * tui/tui-winsource.c
8501         (tui_source_window_base::set_is_exec_point_at): Add check against
8502         LOA_ADDRESS.
8503
8504 2019-06-25  Tom Tromey  <tom@tromey.com>
8505
8506         * tui/tui-source.c (tui_set_source_content): Don't check before
8507         xfree.
8508         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8509
8510 2019-06-25  Tom Tromey  <tom@tromey.com>
8511
8512         * tui/tui-winsource.h (tui_update_source_window_as_is)
8513         (tui_alloc_source_buffer, tui_line_is_displayed)
8514         (tui_addr_is_displayed): Change type of win_info.
8515         * tui/tui-winsource.c (tui_update_source_window_as_is)
8516         (tui_clear_source_content, tui_show_source_line)
8517         (tui_show_source_content, tui_source_window_base::refill)
8518         (tui_source_window_base::set_is_exec_point_at)
8519         (tui_source_window_base::set_is_exec_point_at)
8520         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8521         (tui_alloc_source_buffer, tui_line_is_displayed)
8522         (tui_addr_is_displayed): Change type of win_info.  Update.
8523         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8524         (tui_source_window_base::do_make_visible_with_new_height):
8525         Update.
8526         * tui/tui-source.c (tui_set_source_content)
8527         (tui_set_source_content_nil)
8528         (tui_source_window::do_scroll_vertical): Update.
8529         * tui/tui-layout.c (show_layout): Update.
8530         * tui/tui-disasm.c (tui_set_disassem_content)
8531         (tui_disasm_window::do_scroll_vertical): Update.
8532         * tui/tui-data.h (tui_win_content): Remove.
8533         (struct tui_gen_win_info) <content, content_size>: Remove.
8534         (struct tui_source_element): Add initializers and destructor.
8535         (union tui_which_element, struct tui_win_element): Remove.
8536         (struct tui_source_window_base) <content>: New field.
8537         (struct tui_data_window): Remove destructor.
8538         (tui_alloc_content, tui_free_win_content)
8539         (tui_free_all_source_wins_content): Don't declare.
8540         * tui/tui-data.c (tui_initialize_static_data): Update.
8541         (init_content_element, tui_alloc_content): Remove.
8542         (~tui_gen_win_info): Update.
8543         (~tui_data_window, tui_free_all_source_wins_content)
8544         (tui_free_win_content, free_content, free_content_elements):
8545         Remove.
8546
8547 2019-06-25  Tom Tromey  <tom@tromey.com>
8548
8549         * tui/tui-winsource.h (tui_clear_source_content)
8550         (tui_erase_source_content, tui_show_source_content): Change type
8551         of win_info.
8552         * tui/tui-winsource.c (tui_clear_source_content)
8553         (tui_erase_source_content, tui_show_source_content): Change type
8554         of win_info.
8555         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8556         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8557         win_info.
8558         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8559         win_info.
8560         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8561
8562 2019-06-25  Tom Tromey  <tom@tromey.com>
8563
8564         * tui/tui-winsource.c (tui_clear_source_content)
8565         (tui_source_window_base::set_is_exec_point_at): Update.
8566         * tui/tui-source.c (tui_set_source_content_nil): Update.
8567         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8568         a bool.
8569         * tui/tui-data.c (init_content_element): Update.
8570
8571 2019-06-25  Tom Tromey  <tom@tromey.com>
8572
8573         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8574         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8575         * tui/tui-layout.c (init_and_make_win): Update.
8576         * tui/tui.h (enum tui_win_type): Update.
8577         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8578         tui_win_is_auxillary.
8579         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8580         tui_win_is_auxillary.
8581
8582 2019-06-25  Tom Tromey  <tom@tromey.com>
8583
8584         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8585         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8586         (tui_delete_data_content_windows, tui_display_all_data)
8587         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8588         Update.
8589         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8590         * tui/tui-regs.c (tui_last_regs_line_no)
8591         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8592         (tui_show_registers): Update.
8593         (tui_show_register_group): Return void.  Update.
8594         (tui_display_registers_from, tui_display_reg_element_at_line)
8595         (tui_display_registers_from_line, tui_check_register_values):
8596         Update.
8597         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8598         member.
8599         (struct tui_data_window) <regs_content>: Now a std::vector.
8600         <regs_content_count>: Remove.
8601         (tui_add_content_elements, tui_free_data_content): Don't declare.
8602         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8603         (init_content_element): Remove DATA_WIN case.  Add assert.
8604         (tui_add_content_elements): Remove.
8605         (tui_data_window): Update.
8606         (tui_free_data_content): Remove.
8607         (free_content_elements): Remove DATA_WIN case.
8608
8609 2019-06-25  Tom Tromey  <tom@tromey.com>
8610
8611         * tui/tui-data.c (tui_data_item_window): Update.
8612         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8613         * tui/tui-windata.c (tui_display_all_data)
8614         (tui_display_data_from_line): Update.
8615         (tui_check_data_values): Remove.
8616         * tui/tui-regs.c (tui_show_register_group)
8617         (tui_display_reg_element_at_line): Update.
8618         * tui/tui-hooks.c (tui_register_changed)
8619         (tui_refresh_frame_and_register_information): Call
8620         tui_check_register_values.
8621         * tui/tui-data.h (struct tui_data_window) <data_content,
8622         data_content_count, data_type>: Remove.
8623         (enum tui_data_type): Remove.
8624
8625         * tui/tui-data.c (tui_data_window::clear_detail)
8626         (~tui_data_window): Update.
8627
8628 2019-06-25  Tom Tromey  <tom@tromey.com>
8629
8630         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8631         declare.
8632         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8633         Rename from tui_first_data_item_displayed.  Update.
8634         (tui_data_window::refresh_all)
8635         (tui_data_window::do_scroll_vertical): Update.
8636         * tui/tui-data.h (struct tui_data_window)
8637         <first_data_item_displayed>: Declare new method.
8638
8639 2019-06-25  Tom Tromey  <tom@tromey.com>
8640
8641         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8642         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8643         contents...
8644         (tui_initialize_static_data): ...here.
8645
8646 2019-06-25  Tom Tromey  <tom@tromey.com>
8647
8648         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8649         (tui_display_registers_from, tui_check_register_values): Update.
8650         (tui_display_register): Remove win_info parameter; update.
8651         (tui_get_register): Change type of parameters.
8652         * tui/tui-data.h (struct tui_data_element): Remove.
8653         (union tui_which_element) <data>: Remove.
8654         <data_window>: Change type.
8655         (struct tui_data_item_window): New.
8656         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8657         case.  Add assert.
8658         (~tui_data_item_window): New destructor.
8659         (free_content_elements): Remove DATA_ITEM_WIN case.
8660
8661 2019-06-25  Tom Tromey  <tom@tromey.com>
8662
8663         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8664         Remove.
8665
8666 2019-06-25  Tom Tromey  <tom@tromey.com>
8667
8668         * tui/tui-data.h (struct tui_command_element): Remove.
8669         (union tui_which_element) <command>: Remove.
8670         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8671         assert.
8672         (free_content_elements): Remove CMD_WIN case.
8673
8674 2019-06-25  Tom Tromey  <tom@tromey.com>
8675
8676         * tui/tui-layout.c (tui_set_layout): Update.
8677         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8678         * tui/tui-data.c (layout_def): Update.
8679
8680 2019-06-25  Tom Tromey  <tom@tromey.com>
8681
8682         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8683         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8684         (tui_source_window_base::set_new_height): Update.
8685         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8686         Update.
8687         (tui_set_locator_fullname, tui_set_locator_info)
8688         (tui_show_frame_info): Update.
8689         * tui/tui-source.c (tui_set_source_content)
8690         (tui_source_is_displayed): Update.
8691         * tui/tui-layout.c (show_source_disasm_command, show_data)
8692         (show_source_or_disasm_and_command): Update.
8693         * tui/tui-disasm.c (tui_set_disassem_content)
8694         (tui_get_begin_asm_address): Update.
8695         * tui/tui-data.h (struct tui_locator_element): Remove.
8696         (union tui_which_element) <locator>: Remove.
8697         (struct tui_locator_window): New.
8698         (tui_locator_win_info_ptr): Change return type.
8699         * tui/tui-data.c (_locator): Change type.
8700         (tui_locator_win_info_ptr): Change return type.
8701         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8702         (tui_alloc_content): Add assert.
8703
8704 2019-06-25  Tom Tromey  <tom@tromey.com>
8705
8706         * tui/tui-winsource.c
8707         (tui_exec_info_window::maybe_allocate_content): New method.
8708         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8709         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8710         (make_source_or_disasm_window): Add cast.
8711         * tui/tui-data.h (union tui_which_element) <simple_string>:
8712         Remove.
8713         (struct tui_source_info): New.
8714         (struct tui_source_window_base) <execution_info>: Change type.
8715         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8716         case, and add assert.
8717         (tui_alloc_content): Add assert.
8718
8719 2019-06-25  Tom Tromey  <tom@tromey.com>
8720
8721         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8722         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8723         * tui/tui-data.c (tui_alloc_win_info): Remove.
8724
8725 2019-06-25  Tom Tromey  <tom@tromey.com>
8726
8727         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8728         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8729         can_highlight.
8730
8731 2019-06-25  Tom Tromey  <tom@tromey.com>
8732
8733         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8734         make_visible_with_new_height method.
8735         (tui_win_info::make_visible_with_new_height): New method.
8736         (tui_source_window_base::do_make_visible_with_new_height)
8737         (tui_data_window::do_make_visible_with_new_height)
8738         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8739         (make_visible_with_new_height): Remove.
8740         (tui_resize_all, tui_adjust_win_heights): Use
8741         make_visible_with_new_height method.
8742         * tui/tui-data.h (struct tui_win_info)
8743         <do_make_visible_with_new_height, make_visible_with_new_height>:
8744         New methods.
8745         (struct tui_source_window_base, struct tui_data_window)
8746         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8747         methods.
8748
8749 2019-06-25  Tom Tromey  <tom@tromey.com>
8750
8751         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8752         method.
8753         (update_tab_width): Call update_tab_width method.
8754         * tui/tui-data.h (struct tui_win_info)
8755         (struct tui_source_window_base) <update_tab_width>: New methods.
8756
8757 2019-06-25  Tom Tromey  <tom@tromey.com>
8758
8759         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8760         parameter.
8761         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8762         parameter.
8763         (tui_gen_win_info::make_visible): Update.
8764         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8765         parameter.
8766         * tui/tui-data.h (enum tui_box): New enum.
8767         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8768
8769 2019-06-25  Tom Tromey  <tom@tromey.com>
8770
8771         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8772         init_and_make_win for EXEC_INFO_WIN.
8773         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8774         longer inline.
8775         (struct tui_win_info) <~tui_win_info>: Inline.
8776         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8777         Don't declare.
8778         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8779         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8780         Remove.
8781         (tui_initialize_static_data): Update.
8782         (~tui_gen_win_info): Handle more cleanup here.
8783         (~tui_source_window_base): Delete "execution_info".
8784         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8785
8786 2019-06-25  Tom Tromey  <tom@tromey.com>
8787
8788         * tui/tui-layout.c (make_command_window): Don't set
8789         can_highlight.
8790         (show_source_disasm_command): Call the reset method.
8791         (show_data): Don't set can_highlight.  Call the reset method.
8792         (tui_gen_win_info::reset): Rename from init_gen_win_info
8793         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8794         (show_source_or_disasm_and_command): Call the reset method.
8795         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8796         (struct tui_cmd_window): Set can_highlight.
8797
8798 2019-06-25  Tom Tromey  <tom@tromey.com>
8799
8800         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8801         from make_visible.
8802         (tui_make_visible, tui_make_invisible): Rewrite.
8803         (tui_win_info::make_visible): Remove.
8804         (tui_source_window_base::make_visible): Update.
8805         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8806         method.  Moved from...
8807         (struct tui_win_info) <make_visible>: ...here.
8808
8809 2019-06-25  Tom Tromey  <tom@tromey.com>
8810
8811         * tui/tui-winsource.c
8812         (tui_source_window_base::do_scroll_horizontal): Remove direction
8813         parameter.
8814         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8815         direction parameter.
8816         * tui/tui-win.c (tui_win_info::forward_scroll)
8817         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8818         (tui_win_info::right_scroll): Update.
8819         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8820         direction parameter.
8821         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8822         direction parameter.
8823         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8824         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8825         Remove direction parameter.
8826         (struct tui_source_window_base, struct tui_source_window)
8827         (struct tui_disasm_window, struct tui_data_window)
8828         (struct tui_cmd_window): Update.
8829
8830 2019-06-25  Tom Tromey  <tom@tromey.com>
8831
8832         * tui/tui-winsource.h (tui_set_exec_info_content)
8833         (tui_show_exec_info_content, tui_erase_exec_info_content)
8834         (tui_clear_exec_info_content, tui_update_exec_info): Change
8835         argument to tui_source_window_base.
8836         * tui/tui-winsource.c (tui_set_exec_info_content)
8837         (tui_show_exec_info_content, tui_erase_exec_info_content)
8838         (tui_clear_exec_info_content, tui_update_exec_info): Change
8839         argument to tui_source_window_base.
8840
8841 2019-06-25  Tom Tromey  <tom@tromey.com>
8842
8843         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8844         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8845
8846 2019-06-25  Tom Tromey  <tom@tromey.com>
8847
8848         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8849         check.
8850
8851 2019-06-25  Tom Tromey  <tom@tromey.com>
8852
8853         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8854         type to void.
8855         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8856         type to void.
8857         * tui/tui-source.c (tui_set_source_content): Update.
8858         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8859
8860 2019-06-25  Tom Tromey  <tom@tromey.com>
8861
8862         * tui/tui-win.c (window_name_completer, tui_set_focus)
8863         (tui_all_windows_info): Use name method.
8864         * tui/tui-data.h (struct tui_gen_win_info)
8865         (struct tui_source_window, struct tui_disasm_window)
8866         (struct tui_data_window, struct tui_cmd_window) <name>: New
8867         method.
8868         (tui_win_name): Don't declare.
8869         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8870         (tui_win_name): Remove.
8871
8872 2019-06-25  Tom Tromey  <tom@tromey.com>
8873
8874         * tui/tui-winsource.h (tui_update_source_window)
8875         (tui_update_source_window_as_is): Change parameter type.
8876         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8877         to be a tui_source_window_base.
8878         (tui_update_source_window_as_is): Likewise.
8879         * tui/tui-win.c (make_visible_with_new_height): Update.
8880
8881 2019-06-25  Tom Tromey  <tom@tromey.com>
8882
8883         * tui/tui-winsource.c (tui_erase_source_content)
8884         (tui_show_source_content, tui_show_exec_info_content)
8885         (tui_erase_exec_info_content): Use refresh_window method.
8886         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8887         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8888         from tui_refresh_win.
8889         (tui_data_window::refresh_window): New method.
8890         (tui_win_info::refresh, tui_source_window_base::refresh)
8891         (tui_refresh_all): Use refresh_window method.
8892         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8893         method.
8894         * tui/tui-regs.c (tui_display_register): Call refresh_window
8895         method.
8896         * tui/tui-layout.c (show_source_disasm_command)
8897         (show_source_or_disasm_and_command): Call refresh_window method.
8898         * tui/tui-data.h (struct tui_gen_win_info)
8899         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8900         New method.
8901
8902 2019-06-25  Tom Tromey  <tom@tromey.com>
8903
8904         * tui/tui.c (tui_rl_other_window, tui_enable)
8905         (tui_is_window_visible, tui_get_command_dimension): Update.
8906         * tui/tui-winsource.c (tui_update_source_window_as_is)
8907         (tui_clear_source_content, tui_erase_source_content)
8908         (tui_show_source_line, tui_source_window_base::refill)
8909         (tui_source_window_base::do_scroll_horizontal)
8910         (tui_source_window_base::set_is_exec_point_at)
8911         (tui_update_breakpoint_info, tui_set_exec_info_content)
8912         (tui_alloc_source_buffer, tui_line_is_displayed)
8913         (tui_addr_is_displayed): Update.
8914         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8915         (tui_check_and_display_highlight_if_needed)
8916         (tui_win_info::make_visible, tui_win_info::refresh)
8917         (tui_refresh_all): Update.
8918         * tui/tui-windata.c (tui_first_data_item_displayed)
8919         (tui_delete_data_content_windows, tui_erase_data_content)
8920         (tui_display_all_data, tui_data_window::refresh_all)
8921         (tui_check_data_values): Update.
8922         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8923         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8924         (tui_win_info::backward_scroll, tui_refresh_all_win)
8925         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8926         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8927         (tui_source_window_base::set_new_height)
8928         (tui_data_window::set_new_height)
8929         (make_invisible_and_set_new_height)
8930         (make_visible_with_new_height, new_height_ok)
8931         (parse_scrolling_args): Update.
8932         * tui/tui-stack.c (tui_show_frame_info): Update.
8933         * tui/tui-source.c (tui_set_source_content)
8934         (tui_set_source_content_nil, tui_source_is_displayed)
8935         (tui_source_window::do_scroll_vertical): Update.
8936         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8937         (tui_display_registers_from, tui_display_reg_element_at_line)
8938         (tui_check_register_values, tui_reg_command): Update.
8939         * tui/tui-layout.c (tui_default_win_height)
8940         (show_source_disasm_command, show_data, init_and_make_win)
8941         (show_source_or_disasm_and_command): Update.
8942         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8943         (tui_redisplay_readline, tui_mld_flush)
8944         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8945         (tui_getc): Update.
8946         * tui/tui-disasm.c (tui_set_disassem_content)
8947         (tui_disasm_window::do_scroll_vertical): Update.
8948         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8949         Now virtual.
8950         (struct tui_win_info): Derive from tui_gen_win_info.
8951         <~tui_win_info>: Mark as override.
8952         <generic>: Remove member.
8953         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8954         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8955         (~tui_data_window, ~tui_win_info)
8956         (tui_free_all_source_wins_content): Update.
8957         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8958
8959 2019-06-25  Tom Tromey  <tom@tromey.com>
8960
8961         * tui/tui-layout.c (init_and_make_win): Use new.
8962         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8963         destructor, initializers.
8964         (tui_alloc_generic_win_info): Don't declare.
8965         * tui/tui-data.c (_locator): Add argument to constructor.
8966         (source_win, disasm_win): New globals.
8967         (exec_info): Remove.
8968         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8969         Update.
8970         (tui_alloc_generic_win_info): Remove.
8971         (init_content_element): Use new.
8972         (tui_win_info::tui_win_info): Update.
8973         (free_content_elements) <case DATA_WIN>: Use delete.
8974
8975 2019-06-25  Tom Tromey  <tom@tromey.com>
8976
8977         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8978         * tui/tui-windata.c (tui_first_data_item_displayed)
8979         (tui_delete_data_content_windows): Update.
8980         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8981         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8982         (tui_display_registers_from, tui_check_register_values): Update.
8983         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8984         pointer.
8985         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8986         window.
8987         (tui_free_data_content): Update.
8988         (free_content_elements) <case DATA_WIN>: Free the window.
8989
8990 2019-06-25  Tom Tromey  <tom@tromey.com>
8991
8992         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8993         Update.
8994         * tui/tui-layout.c (make_command_window)
8995         (show_source_disasm_command, show_data, init_and_make_win)
8996         (show_source_or_disasm_and_command): Update.
8997         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8998         method.
8999         <can_highight, is_highlighted>: Now bool.
9000         (tui_set_win_highlight): Don't declare.
9001         * tui/tui-data.c (tui_set_win_highlight): Remove.
9002
9003 2019-06-25  Tom Tromey  <tom@tromey.com>
9004
9005         * tui/tui-wingeneral.c (make_visible): Remove check of window
9006         type.
9007
9008 2019-06-25  Tom Tromey  <tom@tromey.com>
9009
9010         * tui/tui-win.c (tui_win_info::max_height)
9011         (tui_cmd_window::max_height): New methods.
9012         (new_height_ok): Call max_height.
9013         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
9014         <max_height>: New method.
9015
9016 2019-06-25  Tom Tromey  <tom@tromey.com>
9017
9018         * tui/tui-win.c (tui_source_window_base::set_new_height)
9019         (tui_data_window::set_new_height): New methods.
9020         (make_invisible_and_set_new_height): Call set_new_height method.
9021         * tui/tui-data.h (struct tui_win_info)
9022         (struct tui_source_window_base, struct tui_data_window)
9023         <set_new_height>: New method.
9024
9025 2019-06-25  Tom Tromey  <tom@tromey.com>
9026
9027         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
9028         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
9029         tui_refresh_data_win.
9030         * tui/tui-win.c (tui_source_window_base::refresh_all): New
9031         method.
9032         (tui_refresh_all_win): Call the refresh_all method.
9033         (tui_set_focus): Likewise.
9034         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
9035         (struct tui_source_window_base, struct tui_data_window) <refresh>:
9036         Likewise.
9037
9038 2019-06-25  Tom Tromey  <tom@tromey.com>
9039
9040         * tui/tui-winsource.h (tui_refill_source_window)
9041         (tui_set_is_exec_point_at): Don't declare.
9042         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
9043         (tui_source_window_base::refill): Rename from
9044         tui_refill_source_window.
9045         (tui_source_window_base::do_scroll_horizontal): Update.
9046         (tui_source_window_base::set_is_exec_point_at): Rename from
9047         tui_set_is_exec_point_at.
9048         (tui_update_all_breakpoint_info): Update.
9049         * tui/tui-stack.c (tui_show_frame_info): Update.
9050         * tui/tui-layout.c (show_data): Add cast.
9051         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
9052         * tui/tui-data.h (struct tui_source_window_base) <refill,
9053         set_is_exec_point_at>: New methods.
9054         (tui_source_windows, tui_add_to_source_windows): Update types.
9055         (tui_add_to_source_windows): Remove redundant declaration.
9056         * tui/tui-data.c (source_windows): Store tui_source_window_base.
9057         (tui_source_windows): Change return type.
9058         (tui_clear_source_windows_detail): Update.
9059         (tui_add_to_source_windows): Change type of parameter.
9060         (tui_free_all_source_wins_content): Update.
9061
9062 2019-06-25  Tom Tromey  <tom@tromey.com>
9063
9064         * tui/tui-wingeneral.c (tui_win_info::refresh)
9065         (tui_source_window_base::refresh): New methods.
9066         (tui_refresh_all): Call the refresh method.
9067         * tui/tui-data.h (struct tui_win_info)
9068         (struct tui_source_window_base) <refresh>: New method.
9069
9070 2019-06-25  Tom Tromey  <tom@tromey.com>
9071
9072         * tui/tui.h (tui_is_window_visible): Return bool.
9073         * tui/tui.c (tui_is_window_visible): Return bool.
9074         * tui/tui-wingeneral.c (tui_make_window, make_visible)
9075         (tui_make_visible, tui_make_invisible)
9076         (tui_win_info::make_visible)
9077         (tui_source_window_base::make_visible, make_all_visible)
9078         (tui_make_all_visible, tui_make_all_invisible): Update.
9079         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9080         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9081         bool.
9082         (struct tui_win_info, struct tui_source_window_base)
9083         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9084         * tui/tui-data.c (tui_init_generic_part): Update.
9085
9086 2019-06-25  Tom Tromey  <tom@tromey.com>
9087
9088         * tui/tui-wingeneral.c (tui_win_info::make_visible)
9089         (tui_source_window_base::make_visible): New methods.
9090         (make_all_visible): Make method call.
9091         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9092         (struct tui_source_window_base, struct tui_cmd_window): Override
9093         make_visible.
9094         (tui_win_is_source_type): Don't declare.
9095         * tui/tui-data.c (tui_win_is_source_type): Remove.
9096
9097 2019-06-25  Tom Tromey  <tom@tromey.com>
9098
9099         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9100         NULL check.
9101
9102 2019-06-25  Tom Tromey  <tom@tromey.com>
9103
9104         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9105         Inline constructor.  Add initializers for members.
9106         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9107         constructors; now inline in class.
9108
9109 2019-06-25  Tom Tromey  <tom@tromey.com>
9110
9111         * tui/tui-regs.c (tui_show_registers): Update.
9112         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9113         bool.
9114         * tui/tui-data.c (tui_data_window::clear_detail)
9115         (tui_data_window): Update.
9116
9117 2019-06-25  Tom Tromey  <tom@tromey.com>
9118
9119         * tui/tui-windata.c (tui_display_all_data)
9120         (tui_display_data_from_line, tui_display_data_from)
9121         (tui_check_data_values, tui_data_window::do_scroll_vertical):
9122         Update.
9123         * tui/tui-regs.c (tui_last_regs_line_no)
9124         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9125         (tui_show_registers, tui_show_register_group)
9126         (tui_display_registers_from, tui_display_reg_element_at_line)
9127         (tui_display_registers_from_line, tui_check_register_values)
9128         (tui_reg_next, tui_reg_prev): Update.
9129         * tui/tui-layout.c (tui_set_layout, show_data): Update.
9130         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
9131         tui_data_window.
9132         (struct tui_win_info) <detail>: Remove.  Add new fields from
9133         tui_data_info.
9134         (TUI_DATA_WIN): Add cast.
9135         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9136         (~tui_data_window): Simplify.
9137
9138 2019-06-25  Tom Tromey  <tom@tromey.com>
9139
9140         * tui/tui-layout.c (show_source_disasm_command)
9141         (show_source_or_disasm_and_command): Update.
9142         * tui/tui-io.c (update_cmdwin_start_line)
9143         (tui_redisplay_readline): Update.
9144         * tui/tui-data.h (struct tui_command_info): Remove.
9145         (struct tui_win_info) <detail>: Remove command_info member.
9146         (struct tui_data_window) <start_line>: New member, from
9147         tui_command_info.
9148         (TUI_CMD_WIN): Add casts.
9149
9150 2019-06-25  Tom Tromey  <tom@tromey.com>
9151
9152         * tui/tui-winsource.c (tui_update_source_window)
9153         (tui_refill_source_window)
9154         (tui_source_window_base::do_scroll_horizontal)
9155         (tui_update_breakpoint_info, tui_set_exec_info_content)
9156         (tui_show_exec_info_content, tui_erase_exec_info_content)
9157         (tui_clear_exec_info_content): Update.
9158         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9159         Update.
9160         * tui/tui-win.c (make_invisible_and_set_new_height)
9161         (make_visible_with_new_height): Update.
9162         * tui/tui-source.c (tui_set_source_content)
9163         (tui_show_symtab_source): Update.
9164         * tui/tui-layout.c (extract_display_start_addr)
9165         (show_source_disasm_command, show_data)
9166         (make_source_or_disasm_window)
9167         (show_source_or_disasm_and_command): Update.
9168         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9169         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9170         "gdbarch".
9171         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9172         to tui_source_window_base.
9173         (struct tui_win_info) <detail>: Remove source_info member.
9174         (struct tui_source_window_base) <has_locator>: Inline.
9175         Move contents from tui_source_info; rename has_locator member to
9176         m_has_locator.
9177         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9178         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9179         header file.
9180         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9181         Simplify.
9182         (tui_free_all_source_wins_content): Cast to
9183         tui_source_window_base.
9184
9185 2019-06-25  Tom Tromey  <tom@tromey.com>
9186
9187         * tui/tui-win.c (make_invisible_and_set_new_height)
9188         (make_visible_with_new_height): Call has_locator method.
9189         * tui/tui-layout.c (show_source_disasm_command, show_data)
9190         (show_source_or_disasm_and_command): Update for bool change.
9191         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9192         (tui_win_info) <has_locator>: New method.
9193         (struct tui_source_window_base) <has_locator>: New method.
9194         (tui_win_has_locator): Don't declare.
9195         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9196         from tui_win_has_locator.
9197         (tui_source_window_base): Use false, not FALSE.
9198
9199 2019-06-25  Tom Tromey  <tom@tromey.com>
9200
9201         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9202         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9203         clear_detail method directly.
9204         (tui_clear_win_detail): Remove.
9205
9206 2019-06-25  Tom Tromey  <tom@tromey.com>
9207
9208         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9209         "this", not TUI_DISASM_WIN.
9210
9211 2019-06-25  Tom Tromey  <tom@tromey.com>
9212
9213         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9214         declare.
9215         * tui/tui-winsource.c
9216         (tui_source_window_base::do_scroll_horizontal): Rename from
9217         tui_horizontal_source_scroll.
9218         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9219         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9220         from tui_vertical_data_scroll.
9221         * tui/tui-win.h (tui_scroll): Don't declare.
9222         * tui/tui-win.c (tui_win_info::forward_scroll)
9223         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9224         (tui_win_info::right_scroll): Rename and update.
9225         (tui_scroll_forward_command, tui_scroll_backward_command)
9226         (tui_scroll_left_command, tui_scroll_right_command): Update.
9227         (tui_scroll): Remove.
9228         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9229         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9230         from tui_vertical_source_scroll.
9231         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9232         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9233         from tui_vertical_disassem_scroll.
9234         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9235         do_scroll_horizontal>: New methods.
9236         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9237         Likewise.
9238         (struct tui_source_window_base): Add do_scroll_horizontal.
9239         (struct tui_source_window, struct tui_disasm_window): Add
9240         do_scroll_vertical.
9241         (struct tui_data_window, struct tui_cmd_window): Add
9242         do_scroll_horizontal and do_scroll_vertical.
9243         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9244
9245 2019-06-25  Tom Tromey  <tom@tromey.com>
9246
9247         * tui/tui-data.h (struct tui_source_window_base): New struct.
9248         (struct tui_source_window): Derive from tui_source_window_base.
9249         (struct tui_disasm_window): New struct.
9250         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9251         from tui_source_window::clear_detail.
9252         (tui_source_window_base): Rename from tui_source_window.
9253         (~tui_source_window_base): Rename from ~tui_source_window.
9254         (tui_alloc_win_info): Create a tui_disasm_window.
9255
9256 2019-06-25  Tom Tromey  <tom@tromey.com>
9257
9258         * tui/tui-data.h (struct tui_source_window)
9259         (struct tui_data_window): Declare destructors.
9260         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9261         destructors.
9262         (tui_win_info): Simplify.
9263
9264 2019-06-25  Tom Tromey  <tom@tromey.com>
9265
9266         * tui/tui-winsource.c (tui_display_main)
9267         (tui_update_source_windows_with_addr)
9268         (tui_update_all_breakpoint_info): Update.
9269         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9270         (new_height_ok, parse_scrolling_args): Update.
9271         * tui/tui-stack.c (tui_show_frame_info): Update.
9272         * tui/tui-data.h (struct tui_list): Remove.
9273         (tui_source_windows): Return a reference to a std::vector.
9274         * tui/tui-data.c (source_windows): Now a std::vector.
9275         (tui_source_windows): Change return type.
9276         (tui_clear_source_windows): Rewrite.
9277         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9278         (tui_free_all_source_wins_content): Rewrite.
9279
9280 2019-06-25  Tom Tromey  <tom@tromey.com>
9281
9282         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9283         (struct tui_data_window, struct tui_cmd_window): Declare
9284         clear_detail method.
9285         * tui/tui-data.c (tui_source_window::clear_detail)
9286         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9287         methods.
9288         (tui_clear_win_detail): Simplify.
9289
9290 2019-06-25  Tom Tromey  <tom@tromey.com>
9291
9292         * tui/tui-layout.c (make_source_window, make_disasm_window)
9293         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9294         Return the new window.
9295         (show_source_disasm_command, show_data)
9296         (show_source_or_disasm_and_command): Update.
9297
9298 2019-06-25  Tom Tromey  <tom@tromey.com>
9299
9300         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9301         parameter.  Return the new window.
9302         (show_source_disasm_command): Update and remove NULL check.
9303         (show_source_or_disasm_and_command): Update.
9304
9305 2019-06-25  Tom Tromey  <tom@tromey.com>
9306
9307         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9308
9309 2019-06-25  Tom Tromey  <tom@tromey.com>
9310
9311         * tui/tui-data.h (struct tui_win_info): Make constructor
9312         protected.  Make destructor virtual.  Add initializers.
9313         (tui_source_window, tui_data_window, tui_cmd_window): New
9314         classes.
9315         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9316         constructor.  Add "type" parameter.
9317         (tui_source_window, tui_data_window, tui_cmd_window): New
9318         constructors.
9319         (tui_alloc_win_info): Instantiate the appropriate subclass.
9320
9321 2019-06-25  Tom Tromey  <tom@tromey.com>
9322
9323         * tui/tui-win.c (tui_resize_all): Use delete.
9324         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9325         destructor.
9326         (tui_free_window): Don't declare.
9327         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9328         Update.
9329
9330 2019-06-25  Tom Tromey  <tom@tromey.com>
9331
9332         * tui/tui-data.h (struct tui_win_info): Add constructor.
9333         * tui/tui-data.c (tui_alloc_win_info): Use new.
9334         (tui_free_window): Use delete.
9335
9336 2019-06-22  Tom Tromey  <tom@tromey.com>
9337
9338         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9339         declare.
9340         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9341
9342 2019-06-22  Tom Tromey  <tom@tromey.com>
9343
9344         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9345         declare.
9346         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9347
9348 2019-06-22  Tom de Vries  <tdevries@suse.de>
9349
9350         * dwarf2read.c (create_addrmap_from_aranges)
9351         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9352         instead of '%zu'.
9353
9354 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9355
9356         * dwarf2read.h (dwarf2_section_info_def): Remove.
9357         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9358         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9359         std::vector<dwarf2_section_info>.
9360         (struct dwo_file) <~dwo_file>: Remove.
9361         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9362         types field.
9363         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9364         (dwarf2_read_debug_names): Likewise.
9365         (create_debug_types_hash_table): Change parameter type to
9366         array_view, adjust code accordingly.
9367         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9368         (partial_die_info::fixup): Likewise.
9369         (determine_prefix): Likewise.
9370         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9371
9372 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9373
9374         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9375         gdb_bfd_ref_ptr.
9376         <~dwo_file>: Remove call to gdb_bfd_unref.
9377         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9378         gdb_bfd_ref_ptr::get.
9379
9380 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9381
9382         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9383         type to htab_up.
9384         * dwarf2read.c (struct dwo_file): Initialize fields.
9385         <~dwo_file>: New.
9386         (free_dwo_file): Remove, move content to ~dwo_file.
9387         (struct dwo_file_deleter): Remove.
9388         (dwo_file_up>: Remove custom deleter.
9389         (free_dwo_files): Remove.
9390         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9391         dwo_files.
9392         (process_skeletonless_type_units): Call unique_ptr::get.
9393         (allocate_dwo_file_hash_table): Add deleter to created hash
9394         table.  Change return type to htab_up.
9395         (lookup_dwo_file_slot): Don't memset dwo_file, call
9396         unique_ptr::get.
9397         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9398         (create_dwo_unit_in_dwp_v2): Likewise.
9399         (open_and_init_dwo_file): Likewise.
9400         (free_dwo_file_from_slot): Remove.
9401
9402 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9403
9404         * dwarf2read.h (struct dwarf2_section_info) <readin,
9405         is_virtual>: Change type to bool.
9406         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9407         true instead of 1.
9408
9409 2019-06-19  Tom Tromey  <tom@tromey.com>
9410
9411         * tui/tui-data.h (tui_init_content_element): Don't declare.
9412
9413 2019-06-19  Tom Tromey  <tom@tromey.com>
9414
9415         * tui/tui-data.h (tui_init_win_info): Don't declare.
9416
9417 2019-06-19  Tom de Vries  <tdevries@suse.de>
9418
9419         * dwarf2read.h (abstract_to_concrete): Change type to
9420         std::unordered_map<sect_offset, std::vector<sect_offset>,
9421         gdb::hash_enum<sect_offset>>.
9422
9423 2019-06-19  Tom Tromey  <tromey@adacore.com>
9424
9425         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9426         EVAL_AVOID_SIDE_EFFECTS specially.
9427
9428 2019-06-19  Tom Tromey  <tromey@adacore.com>
9429
9430         * source-cache.c (highlighter): New global.
9431         (source_cache::get_source_lines): Create a highlighter on demand.
9432
9433 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9434
9435         * defs.h (deprecated_interactive_hook): Delete declaration.
9436         * interps.c (clear_interpreter_hooks): Remove use of
9437         deprecated_interactive_hook.
9438         * top.c (deprecated_interactive_hook): Delete definition.
9439         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9440
9441 2019-06-18  Tom de Vries  <tdevries@suse.de>
9442
9443         PR gdb/24515
9444         * dwarf2read.h (abstract_to_concrete): Change type from
9445         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9446         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9447         * dwarf2read.c (read_variable): Update.
9448         (dwarf2_fetch_die_loc_sect_off): Update.
9449
9450 2019-06-17  Tom de Vries  <tdevries@suse.de>
9451
9452         PR gdb/24617
9453         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9454         accessing parent[parent_len - 1].
9455
9456 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9457
9458         PR gdb/24364
9459         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9460         call dtrace_process_dof with NULL dof.
9461
9462 2019-06-16  Tom de Vries  <tdevries@suse.de>
9463
9464         PR gdb/24445
9465         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9466
9467 2019-06-16  Tom Tromey  <tom@tromey.com>
9468
9469         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9470         (make_all_visible): Use address of member.
9471
9472 2019-06-16  Tom Tromey  <tom@tromey.com>
9473
9474         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9475         (tui_free_window, free_content, free_content_elements): Remove
9476         unnecessary cast.
9477         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9478         cast.
9479         * tui/tui-regs.c (tui_show_register_group)
9480         (tui_display_registers_from, tui_display_reg_element_at_line):
9481         Remove unnecessary cast.
9482
9483 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * linux-nat.c (normal_mask): Delete.
9486         (_initialize_linux_nat): Don't initialise normal_mask.
9487
9488 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9489
9490         PR gdb/24445
9491         * dwarf-index-write.h (write_psymtabs_to_index): Add
9492         dwz_basename parameter.
9493         * dwarf-index-write.c (write_gdbindex): Move file writing to
9494         write_gdbindex_1.  Change return type void.
9495         (assert_file_size): Move up, remove filename parameter.
9496         (write_gdbindex_1): New function.
9497         (write_debug_names): Change return type to void, call
9498         assert_file_size.
9499         (struct index_wip_file): New struct.
9500         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9501         file logic to index_wip_file.  Write index for dwz file if
9502         needed.
9503         (save_gdb_index_command): Pass basename of dwz file, if present.
9504         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9505         build-id of dwz file, if present.
9506         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9507         (dwarf2_get_dwz_file): Likewise.
9508         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9509         (dwarf2_get_dwz_file): Likewise.
9510
9511 2019-06-16  Tom Tromey  <tom@tromey.com>
9512
9513         * coffread.c (process_coff_symbol): Use xstrdup.
9514         * value.c (create_internalvar): Use xstrdup.
9515
9516 2019-06-16  Tom Tromey  <tom@tromey.com>
9517
9518         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9519         * breakpoint.c (stopin_command, stopat_command)
9520         (until_break_command, decode_location_default): Remove unnecessary
9521         cast.
9522         * utils.c (subset_compare): Remove unnecessary cast.
9523         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9524         cast.
9525         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9526         cast.
9527         * infcmd.c (path_command): Remove unnecessary cast.
9528         * coffread.c (decode_type): Remove unnecessary cast.
9529         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9530         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9531         * tui/tui-stack.c (tui_show_locator_content)
9532         (tui_show_frame_info): Remove unnecessary cast.
9533         * tui/tui-win.c (tui_scroll_forward_command)
9534         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9535         (parse_scrolling_args): Remove unnecessary cast.
9536         * tui/tui-data.c (init_win_info, tui_del_window)
9537         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9538         (free_content_elements): Remove unnecessary cast.
9539         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9540         unnecessary cast.
9541         * tui/tui-source.c (tui_set_source_content)
9542         (tui_vertical_source_scroll): Remove unnecessary cast.
9543         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9544         cast.
9545         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9546         * tui/tui-regs.c (tui_display_registers_from)
9547         (tui_display_register): Remove unnecessary cast.
9548         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9549         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9550         (make_visible): Remove unnecessary cast.
9551         * tui/tui-winsource.c (tui_erase_source_content)
9552         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9553         unnecessary cast.
9554         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9555         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9556         * stabsread.c (read_type, read_array_type, read_range_type):
9557         Remove unnecessary cast.
9558         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9559         (parse_symbol, parse_type, upgrade_type, parse_external)
9560         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9561         unnecessary cast.
9562         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9563
9564 2019-06-16  Tom Tromey  <tom@tromey.com>
9565
9566         * tui/tui-data.c (tui_alloc_generic_win_info)
9567         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9568         checks.
9569
9570 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9571             Andrew Burgess  <andrew.burgess@embecosm.com>
9572
9573         * f-typeprint.c (f_print_type): Don't return early for not
9574         associated or not allocated types.
9575         (f_type_print_varspec_suffix): Add print_rank parameter and print
9576         ranks of array types in case they dangling.
9577         (f_type_print_base): Add print_rank parameter.
9578
9579 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9580
9581         * NEWS: Mention new MI commands.
9582         * break-catch-throw.c (enum exception_event_kind): Move to
9583         breakpoint.h.
9584         (print_mention_exception_catchpoint): Output text as a single
9585         message.
9586         (catch_exception_command_1): Rename to...
9587         (catch_exception_event): ...this, make non-static, update header
9588         command, and change some parameter types.
9589         (catch_catch_command): Update for changes to
9590         catch_exception_command_1.
9591         (catch_throw_command): Likewise.
9592         (catch_rethrow_command): Likewise.
9593         * breakpoint.c (enum exception_event_kind): Delete.
9594         * breakpoint.h (enum exception_event_kind): Moved here from
9595         break-catch-throw.c.
9596         (catch_exception_event): Declare.
9597         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9598         (mi_cmd_catch_throw): New function.
9599         (mi_cmd_catch_rethrow): New function.
9600         (mi_cmd_catch_catch): New function.
9601         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9602         'catch-catch' entries.
9603         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9604         (mi_cmd_catch_rethrow): Declare.
9605         (mi_cmd_catch_catch): Declare.
9606
9607 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9608
9609         * annotate.c (annotate_source_line): Change return type to void,
9610         update implementation to match.
9611         * annotate.h (annotate_source_line): Change return type to void,
9612         update header comment.
9613         * stack.c (print_frame_info): Don't change what frame information
9614         is printed based on whether annotations are on or not.
9615
9616 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9617
9618         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9619         (annotate_source): Make static.
9620         (annotate_source_line): Moved from source.c and renamed from
9621         identify_source_line.  Update the return type.
9622         * annotate.h (annotate_source): Delete declaration.
9623         (annotate_source_line): Declaration moved from source.h, and
9624         renamed from identify_source_line.  Return type updated.
9625         * source.c (identify_source_line): Moved to annotate.c and renamed
9626         to annotate_source_line.
9627         (info_line_command): Remove check of annotation_level.
9628         * source.h (identify_source_line): Move declaration to annotate.h
9629         and rename to annotate_source_line.
9630         * stack.c: Add 'annotate.h' include.
9631         (print_frame_info): Remove check of annotation_level before
9632         calling annotate_source_line.
9633
9634 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9635
9636         * source-cache.c (source_cache::get_plain_source_lines): Use
9637         open_source_file_with_line_charpos instead of just
9638         open_source_file, remove call to find_source_lines.
9639         (source_cache::get_source_lines): Likewise.
9640         * source.c (find_source_lines): Make static.
9641         (get_filename_and_charpos): Renamed into...
9642         (open_source_file_with_line_charpos): ..this along with changes to
9643         return a scoped_fd, and some other minor clean ups.
9644         (identify_source_line): Use open_source_file_with_line_charpos.
9645         (search_command_helper): Use open_source_file_with_line_charpos
9646         instead of just open_source_file, remove call to
9647         find_source_lines.
9648         * source.h (open_source_file_with_line_charpos): Declare new
9649         function.
9650         (find_source_lines): Delete declaration.
9651
9652 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9653
9654         * source.c (get_filename_and_charpos): Remove fullname
9655         parameter.
9656         (identify_source_line): Update call to get_filename_and_charpos.
9657
9658 2019-06-14  Tom Tromey  <tromey@adacore.com>
9659
9660         PR gdb/24502:
9661         * ui-style.h (skip_ansi_escape): Update comment.
9662         * ui-file.h (class no_terminal_escape_file): New class.
9663         * ui-file.c (no_terminal_escape_file::write)
9664         (no_terminal_escape_file::puts): New methods.
9665         * cli/cli-logging.c (handle_redirections): Use
9666         no_terminal_escape_file.
9667
9668 2019-06-14  Tom Tromey  <tromey@adacore.com>
9669
9670         * NEWS: Move convenience variable news above Python news.
9671
9672 2019-06-14  Tom Tromey  <tom@tromey.com>
9673
9674         * gnulib: Move directory to top-level.
9675         * configure.ac: Don't configure gnulib.
9676         * configure: Rebuild.
9677         * common/common-defs.h: Use new path to gnulib.
9678         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9679         (GNULIB_H): Remove.
9680         (INCGNU): Look in new gnulib location.
9681         (HFILES_NO_SRCDIR): Remove gnulib files.
9682         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9683         (generated_files): Remove GNULIB_H.
9684         ($(LIBGNU), all-lib): Remove targets.
9685         (distclean): Don't mention GNULIB_BUILDDIR.
9686         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9687
9688 2019-06-14  Tom Tromey  <tromey@adacore.com>
9689
9690         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9691         Warn if symbol file does not provide any symbols.
9692
9693 2019-06-14  Tom Tromey  <tromey@adacore.com>
9694
9695         * source.c (find_and_open_source): Respect basenames_may_differ.
9696
9697 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9698
9699         * annotate.c (annotate_breakpoints_invalid): Make use of
9700         scoped_restore_terminal_state.
9701         (annotate_frames_invalid): Likewise.
9702
9703 2019-06-14  Tom Tromey  <tromey@adacore.com>
9704
9705         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9706         allow assignment to an internalvar.
9707
9708 2019-06-14  Tom Tromey  <tromey@adacore.com>
9709
9710         * ada-lex.l: Allow "_" in attribute names.
9711
9712 2019-06-14  Tom Tromey  <tromey@adacore.com>
9713
9714         PR gdb/24653:
9715         * regcache.c (registers_changed): Don't call alloca.
9716         * top.c (execute_command): Don't call alloca.
9717
9718 2019-06-13  Pedro Alves  <palves@redhat.com>
9719
9720         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9721         'expression'.  When parsing an expression, error out if there's
9722         junk after "unlimited".
9723         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9724         (do_set_command): Adjust calls to is_unlimited_literal.
9725
9726 2019-06-13  Pedro Alves  <palves@redhat.com>
9727
9728         * compile/compile.c (make_compile_options_def_group): Add braces
9729         around array_view initializer.
9730         * thread.c (make_thread_apply_all_options_def_group)
9731         (make_thread_apply_all_options_def_group): Likewise.
9732
9733 2019-06-13  Pedro Alves  <palves@redhat.com>
9734
9735         * NEWS (New commands): Mention "maint test-options
9736         require-delimiter", "maint test-options unknown-is-error", "maint
9737         test-options unknown-is-operand" and "maint show
9738         test-options-completion-result".
9739         (New command options, command completion): New section.
9740         (Completion improvements): New section.
9741         Mention that you can abbreviate "unlimited".
9742
9743 2019-06-13  Pedro Alves  <palves@redhat.com>
9744
9745         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9746         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9747         * unittests/cli-utils-selftests.c (test_parse_flags)
9748         (test_parse_flags_qcs): Delete.
9749         (test_cli_utils): Don't call deleted functions.
9750
9751 2019-06-13  Pedro Alves  <palves@redhat.com>
9752
9753         * thread.c: Include "cli/cli-option.h".
9754         (tp_array_compar_ascending): Global.
9755         (tp_array_compar): Delete function.
9756         (tp_array_compar_ascending, tp_array_compar_descending): New
9757         functions.
9758         (ascending_option_def, qcs_flag_option_def)
9759         (thr_qcs_flags_option_defs)
9760         (make_thread_apply_all_options_def_group)
9761         (make_thread_apply_options_def_group): New.
9762         (thread_apply_all_command): Use gdb::option::process_options.
9763         (thread_apply_command_completer)
9764         (thread_apply_all_command_completer): New.
9765         (thread_apply_command): Use gdb::option::process_options.
9766         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9767         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9768         to generate help text of "thread apply".  Adjust "taas"'s help.
9769         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9770         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9771
9772 2019-06-13  Pedro Alves  <palves@redhat.com>
9773
9774         * thread.c (thread_apply_command): Check for invalid TID with
9775         isdigit instead of !isalpha.
9776
9777 2019-06-13  Pedro Alves  <palves@redhat.com>
9778
9779         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9780         (validate_flags_qcs): New.
9781         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9782         (validate_flags_qcs): Declare.
9783         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9784         (make_frame_apply_options_def_group): New.
9785         (frame_apply_command_count): Process options with
9786         gdb::option::process_options.
9787         (frame_apply_completer): New.
9788         (frame_apply_level_completer, frame_apply_all_completer)
9789         (frame_apply_completer): New.
9790         (_initialize_stack): Update help of "frame apply", "frame apply
9791         level", "frame apply all" and "faas" to mention supported options
9792         and install command completers.
9793         * stack.h (frame_apply_all_completer): Declare.
9794         * thread.c: Include "stack.h".
9795         (tfaas_command): Add "--".
9796         (_initialize_thread): Update help "tfaas" to mention supported
9797         options and install command completer.
9798
9799 2019-06-13  Pedro Alves  <palves@redhat.com>
9800
9801         * completer.c (complete_nested_command_line): New.
9802         (gdb_completion_word_break_characters_throw): Add assertion.
9803         * completer.h (complete_nested_command_line): Declare.
9804
9805 2019-06-13  Pedro Alves  <palves@redhat.com>
9806
9807         * stack.c (parse_backtrace_qualifiers): New.
9808         (backtrace_command): Use it.
9809         (backtrace_command_completer): Complete on qualifiers.
9810
9811 2019-06-13  Pedro Alves  <palves@redhat.com>
9812
9813         * frame.c: Include "cli/cli-option.h.
9814         (user_set_backtrace_options): New.
9815         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9816         Delete.
9817         (get_prev_frame): Adjust.
9818         (boolean_option_def, uinteger_option_def)
9819         (set_backtrace_option_defs): New.
9820         (_initialize_frame): Adjust and use
9821         gdb::option::add_setshow_cmds_for_options to install "set
9822         backtrace past-main" and "set backtrace past-entry".
9823         * frame.h: Include "cli/cli-option.h".
9824         (struct frame_print_options): Forward declare.
9825         (print_frame_arguments_all, print_frame_arguments_scalars)
9826         (print_frame_arguments_none): Declare.
9827         (print_entry_values): Delete declaration.
9828         (struct frame_print_options, user_frame_print_options): New.
9829         (struct set_backtrace_options): New.
9830         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9831         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9832         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9833         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9834         (list_args_or_locals): Add frame_print_options parameter.
9835         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9836         * python/py-framefilter.c (enumerate_args): Pass down
9837         USER_FRAME_PRINT_OPTIONS.
9838         * stack.c: Include "cli/cli-option.h".
9839         (print_frame_arguments_all, print_frame_arguments_scalars)
9840         (print_frame_arguments_none): Declare.
9841         (print_raw_frame_arguments, print_entry_values): Delete.
9842         (user_frame_print_options): New.
9843         (boolean_option_def, enum_option_def, frame_print_option_defs):
9844         New.
9845         (struct backtrace_cmd_options): New.
9846         (bt_flag_option_def): New.
9847         (backtrace_command_option_defs): New.
9848         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9849         (print_frame_arg, read_frame_arg, print_frame_args)
9850         (print_frame_info, print_frame): Add frame_print_options parameter
9851         and use it.
9852         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9853         (backtrace_command_1): Add frame_print_options and
9854         backtrace_cmd_options parameters and use them.
9855         (make_backtrace_options_def_group): New.
9856         (backtrace_command): Process command options with
9857         gdb::option::process_options.
9858         (backtrace_command_completer): New.
9859         (_initialize_stack): Extend "backtrace"'s help to mention
9860         supported options.  Install completer for "backtrace".
9861         Install some settings commands with add_setshow_cmds_for_options.
9862
9863 2019-06-13  Pedro Alves  <palves@redhat.com>
9864
9865         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9866         and that "set/show print raw frame-arguments" are now deprecated.
9867
9868         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9869         command.
9870         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9871         * stack.c (_initialize_stack): Install "set/show print
9872         raw-frame-arguments", and deprecate "set/show print raw
9873         frame-arguments".
9874         * valprint.c (_initialize_valprint): Deprecate "set/show print
9875         raw".
9876
9877 2019-06-13  Pedro Alves  <palves@redhat.com>
9878
9879         * compile/compile.c (struct compile_options): New.
9880         (compile_flag_option_def, compile_command_option_defs)
9881         (make_compile_options_def_group): New.
9882         (compile_file_command): Handle options with
9883         gdb::option::process_options.
9884         (compile_file_command_completer): New function.
9885         (compile_code_command): Handle options with
9886         gdb::option::process_options.
9887         (compile_code_command_completer): New function.
9888         (_initialize_compiler): Install completers for "compile code" and
9889         "compile file".  Mention available options in "compile code" and
9890         "compile code"'s help.
9891         * completer.c (advance_to_completion_word): New, factored out from
9892         ...
9893         (advance_to_expression_complete_word_point): ... this.
9894         (advance_to_filename_complete_word_point): New.
9895         * completer.h (advance_to_filename_complete_word_point): New
9896         declaration.
9897
9898 2019-06-13  Pedro Alves  <palves@redhat.com>
9899
9900         * compile/compile.c: Include "cli/cli-option.h".
9901         (compile_print_value): Scope data pointer is now a
9902         value_print_options pointer; adjust.
9903         (compile_print_command): Process options.  Scope data pointer is
9904         now a value_print_options pointer; adjust.
9905         (_initialize_compile): Update "compile print"'s help to include
9906         supported options.  Install a completer for "compile print".
9907         * cp-valprint.c (show_vtblprint, show_objectprint)
9908         (show_static_field_print): Delete.
9909         (_initialize_cp_valprint): Don't install "set print
9910         static-members", "set print vtbl", "set print object" here.
9911         * printcmd.c: Include "cli/cli-option.h" and
9912         "common/gdb_optional.h".
9913         (print_command_parse_format): Rework to fill in a
9914         value_print_options instead of a format_data.
9915         (print_value): Change parameter type from format_data pointer to
9916         value_print_options reference.  Adjust.
9917         (print_command_1): Process options.  Adjust to pass down a
9918         value_print_options.
9919         (print_command_completer): New.
9920         (_initialize_printcmd): Install print_command_completer as
9921         handle_brkchars completer for the "print" command.  Update
9922         "print"'s help to include supported options.
9923         * valprint.c: Include "cli/cli-option.h".
9924         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9925         here from cp-valprint.c.
9926         (boolean_option_def, uinteger_option_def)
9927         (value_print_option_defs, make_value_print_options_def_group):
9928         New.  Use gdb::option::add_setshow_cmds_for_options to install
9929         "set print elements", "set print null-stop", "set print repeats",
9930         "set print pretty", "set print union", "set print array", "set
9931         print address", "set print symbol", "set print array-indexes".
9932         * valprint.h: Include <string> and "cli/cli-option.h".
9933         (make_value_print_options_def_group): Declare.
9934         (print_value): Change parameter type from format_data pointer to
9935         value_print_options reference.
9936         (print_command_completer): Declare.
9937
9938 2019-06-13  Pedro Alves  <palves@redhat.com>
9939
9940         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9941         (COMMON_SFILES): Add maint-test-settings.c.
9942         * cli/cli-decode.c (boolean_enums): New global, factored out from
9943         ...
9944         (add_setshow_boolean_cmd): ... here.
9945         * cli/cli-decode.h (boolean_enums): Declare.
9946         * cli/cli-option.c: New file.
9947         * cli/cli-option.h: New file.
9948         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9949         factored out from ...
9950         (parse_cli_boolean_value(const char *)): ... this.
9951         (is_unlimited_literal): Change parameter type to pointer to
9952         pointer.  Adjust and advance ARG pointer.
9953         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9954         (parse_cli_var_enum): New, factored out from ...
9955         (do_set_command): ... this.  Adjust.
9956         * cli/cli-setshow.h (parse_cli_boolean_value)
9957         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9958         (parse_cli_var_enum): Declare.
9959         * cli/cli-utils.c: Include "cli/cli-option.h".
9960         (get_ulongest): New.
9961         * cli/cli-utils.h (get_ulongest): Declare.
9962         (check_for_argument): New overloads.
9963         * maint-test-options.c: New file.
9964
9965 2019-06-13  Pedro Alves  <palves@redhat.com>
9966
9967         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9968         parse a range if "-" is at the end of the string.
9969
9970 2019-06-13  Pedro Alves  <palves@redhat.com>
9971
9972         * cli/cli-setshow.c (parse_auto_binary_operation)
9973         (parse_cli_boolean_value): Don't allow "o".
9974
9975 2019-06-13  Pedro Alves  <palves@redhat.com>
9976
9977         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9978         * NEWS: Mention maint test-settings KIND.
9979         * maint-test-settings.c: New file.
9980
9981 2019-06-13  Pedro Alves  <palves@redhat.com>
9982
9983         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9984         completer.
9985         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9986         "set" completers.
9987
9988 2019-06-13  Pedro Alves  <palves@redhat.com>
9989
9990         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9991         after item.
9992
9993 2019-06-13  Pedro Alves  <palves@redhat.com>
9994
9995         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9996
9997 2019-06-13  Pedro Alves <palves@redhat.com>
9998
9999         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
10000         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
10001         call.
10002         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
10003         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
10004         calls.
10005         (check_for_argument): Skip spaces after argument.
10006
10007 2019-06-13  Pedro Alves  <palves@redhat.com>
10008
10009         * thread.c (thread_apply_command): Adjust TID parsing.
10010         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
10011         detected before end of string.
10012         (tid_is_in_list): Error out if LIST is invalid.
10013
10014 2019-06-13  Pedro Alves  <palves@redhat.com>
10015
10016         * completer.c (complete_line_internal_1): Rewind completion word
10017         point.
10018         (completion_tracker::advance_custom_word_point_by): Change
10019         parameter type to int.
10020         * completer.h (completion_tracker::advance_custom_word_point_by):
10021         Likewise.
10022
10023 2019-06-13  Pedro Alves  <palves@redhat.com>
10024
10025         * completer.c (advance_to_completion_word): Handle delimiters.
10026
10027 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
10028
10029         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
10030
10031 2019-06-11  Tom Tromey  <tom@tromey.com>
10032
10033         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
10034         (xmalloc_failed): Move to alloc.c.
10035         * alloc.c: New file.
10036         * Makefile.in (COMMON_SFILES): Add alloc.c.
10037
10038 2019-06-11  Tom Tromey  <tom@tromey.com>
10039
10040         * nat/linux-waitpid.c: Don't include server.h.
10041         (linux_debug): Remove.
10042         (my_waitpid): Update.
10043
10044 2019-06-11  Tom Tromey  <tromey@adacore.com>
10045
10046         * infcall.c (_initialize_infcall): Remove trailing newline from
10047         help.
10048         * user-regs.c (_initialize_user_regs): Remove trailing newline
10049         from help.
10050         * typeprint.c (_initialize_typeprint): Remove trailing newline
10051         from help.
10052         * reverse.c (_initialize_reverse): Remove trailing newlines from
10053         help.
10054         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
10055         from help.
10056         * language.c (add_set_language_command): Remove trailing newline
10057         from help.
10058         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
10059         help.
10060         * disasm.c (_initialize_disasm): Remove trailing newline from
10061         help.
10062         * top.c (init_main): Remove trailing newline from help.
10063         * interps.c (_initialize_interpreter): Remove trailing newline
10064         from help.
10065         * btrace.c (_initialize_btrace): Remove trailing newlines from
10066         help.
10067         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
10068         from help.
10069         * python/python.c (_initialize_python): Remove trailing newline
10070         from help.
10071         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
10072         help.
10073         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10074         from help.  Reformat some text.
10075         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10076         from help.
10077         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10078         newline from help.
10079
10080 2019-06-11  Tom Tromey  <tromey@adacore.com>
10081
10082         * darwin-nat.c (darwin_decode_exception_message)
10083         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10084
10085 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10086
10087         * valops.c (value_slice): Check for not allocated or not
10088         associated values.
10089
10090 2019-06-10  Tom de Vries  <tdevries@suse.de>
10091
10092         PR gdb/24618
10093         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10094         sure an empty slot (defined by a 32-bit zero pair) is recognized as
10095         invalid.
10096
10097 2019-06-10  Tom de Vries  <tdevries@suse.de>
10098
10099         PR gdb/24611
10100         * linespec.c (linespec_lexer_lex_string): Remove incorrect
10101         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
10102
10103 2019-06-10  Tom de Vries  <tdevries@suse.de>
10104
10105         PR symtab/24545
10106         * symtab.c (struct demangled_name_entry): Add language field.
10107         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
10108         static minimal symbol".  Set and use language field.
10109
10110 2019-06-10  Tom Tromey  <tromey@adacore.com>
10111
10112         * ada-lang.c (_initialize_ada_language): Update help text.
10113
10114 2019-06-10  Tom Tromey  <tromey@adacore.com>
10115
10116         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10117         with a newline.
10118         * guile/guile.c (handle_boot_error): Don't end warning with a
10119         newline.
10120         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10121         warning with a newline.
10122         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10123         newline.
10124         (s12z_frame_cache): Likewise.
10125         * dwarf-index-cache.c (index_cache::store): Don't end warning with
10126         a newline.
10127         * solib-svr4.c (disable_probes_interface): Don't end warning with
10128         a newline.
10129         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10130         newline.
10131         * python/python.c (do_finish_initialization): Don't end warning
10132         with a newline.
10133
10134 2019-06-10  Tom Tromey  <tom@tromey.com>
10135
10136         * python/py-breakpoint.c (gdbpy_breakpoint_created)
10137         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10138         gdbpy_enter.
10139
10140 2019-06-10  Tom Tromey  <tromey@adacore.com>
10141
10142         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10143         data.
10144         (elf_new_init): Don't call stabsread_new_init.
10145         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10146         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
10147         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10148
10149 2019-06-10  Tom de Vries  <tdevries@suse.de>
10150
10151         PR symtab/16264
10152         PR symtab/24517
10153         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10154
10155 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
10156
10157         * source.c (find_and_open_source): Also rewrite relative file
10158         names.
10159
10160 2019-04-26  Amos Bird  <amosbird@gmail.com>
10161
10162         * annotate.c (annotate_thread_exited): Add "thread-exited"
10163         annotation.
10164
10165 2019-06-06  Tom Tromey  <tromey@adacore.com>
10166
10167         * maint.h (class scoped_command_stats): Use
10168         DISABLE_COPY_AND_ASSIGN.
10169         <print_time>: New method.
10170         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10171         print_time.
10172         (scoped_command_stats::print_time): New method.
10173
10174 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10177         instructions of lengths 6 or 8 bytes.
10178
10179 2019-06-04  Pedro Alves  <palves@redhat.com>
10180
10181         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10182
10183         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10184         * breakpoint.c (condition_completer): Likewise.
10185         * cli/cli-dump.c (scan_expression): Likewise.
10186         * common/filestuff.c (mkdir_recursive): Likewise.
10187         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10188         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10189         (gdb_abspath): Likewise.
10190         * compile/compile-cplus-types.c
10191         (compile_cplus_instance::decl_name): Likewise.
10192         * completer.c (complete_explicit_location):
10193         (signal_completer, reg_or_group_completer_1): Likewise.
10194         * cp-support.c (cp_remove_params_if_any): Likewise.
10195         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10196         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10197         * infcmd.c (strip_bg_char): Likewise.
10198         * linespec.c (copy_token_string): Likewise.
10199         * mi/mi-main.c (output_cores): Likewise.
10200         * psymtab.c (psymtab_search_name):
10201         * symfile.c (test_set_ext_lang_command): Likewise.
10202         * target.c (target_fileio_read_stralloc): Likewise.
10203         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10204         * value.c (complete_internalvar): Likewise.
10205
10206 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10207
10208         Add objfile property to gdb.Type.
10209         * NEWS: Mention Python API addition.
10210         * python/py-type.c (typy_get_objfile): New method.
10211
10212 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10213
10214         * NEWS: Mention the new set|show style [title|highlight].
10215         Mention changes to "show style", "help" and "apropos".
10216
10217 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10218
10219         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10220         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10221         instead of print_help_for_command.
10222         (print_doc_of_command): New function.
10223         (help_list): Add 'apropos -v word' suggestion.
10224         (print_help_for_command): Style the command name using title style.
10225         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10226         (_initialize_cli_cmds): Describe -v in apropos_command help.
10227
10228 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10229
10230         * cli/cli-style.h (cli_style_option): Add name in constructor,
10231         add m_name class member, add constructor with intensity,
10232         add name class function.
10233         (cli_style_option::add_setshow_commands): Remove name argument.
10234         (highlight_style, title_style): New styles.
10235         * cli/cli-style.c (do_show): New function that shows a style
10236         characteristic styling the style name with itself.
10237         (set_style_name): New function.
10238         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10239         Update all callers according to the changes in cli/cli-style.h.
10240         * utils.h (fputs_highlighted): New function.
10241         * utils.c (fputs_highlighted): Likewise.
10242
10243 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10244
10245         * NEWS: Mention new pipe command and new convenience variables.
10246
10247 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * cli/cli-cmds.c (pipe_command): New function.
10250         (_initialize_cli_cmds): Call add_com for pipe_command.
10251         Define | as an alias for pipe.
10252         (exit_status_set_internal_vars): New function.
10253         (shell_escape): Call exit_status_set_internal_vars.
10254         cli/cli-decode.c (find_command_name_length): Recognize | as
10255         a single character command.
10256
10257 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10258
10259         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10260         top.c (execute_command_to_ui_file): New function, mostly a copy
10261         of execute_command_to_string.
10262         (execute_command_to_string): Implement by calling
10263         execute_command_to_ui_file.
10264
10265 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10266
10267         * top.h (saved_command_line): Remove declaration.
10268         * top.c (previous_saved_command_line, previous_repeat_arguments):
10269         New variables.
10270         (saved_command_line): Make static, define together with other
10271         'repeat variables'.
10272         (dont_repeat): Clear repeat_arguments.
10273         (repeat_previous, get_saved_command_line, save_command_line):
10274         New functions.
10275         (gdb_init): Initialize saved_command_line
10276         and previous_saved_command_line.
10277         * main.c (captured_main_1): Remove saved_command_line initialization.
10278         * event-top.c (handle_line_of_input): Update to use
10279         the new 'repeat' related functions instead of direct access to
10280         saved_command_line.
10281         * command.h (repeat_previous, get_saved_command_line,
10282         save_command_line): New declarations.
10283         (dont_repeat): Add comment.
10284
10285 2019-05-30  Tom Tromey  <tromey@adacore.com>
10286
10287         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10288         Fix comment.
10289         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10290
10291 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10292
10293         PR cli/24587
10294         * completer.c (complete): Initialize variable word.
10295
10296 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10297
10298         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10299         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10300         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10301         'body' is NULL to the outter 'if', protecting the '!is_define'
10302         situation as well.
10303
10304 2019-05-29  Tom Tromey  <tromey@adacore.com>
10305
10306         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10307         (dwarf_unknown): New function.
10308         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10309         (dwarf_type_encoding_name): Use dwarf_unknown.
10310
10311 2019-05-29  Tom Tromey  <tromey@adacore.com>
10312
10313         PR c++/20020:
10314         * cp-valprint.c (cp_print_value_fields): Call
10315         cp_print_static_field inside "try".
10316
10317 2019-05-29  Tom Tromey  <tromey@adacore.com>
10318
10319         * inflow.c (struct terminal_info): Add default operator=.
10320         * configure: Rebuild.
10321         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10322         -Wdeprecated-copy-dtor, -Wredundant-move.
10323
10324 2019-05-29  Tom Tromey  <tromey@adacore.com>
10325
10326         * NEWS: Add entry.
10327         * infcmd.c (print_return_value_1): Handle finish_print
10328         option.
10329         (show_print_finish): New function.
10330         (_initialize_infcmd): Add "set/show print finish" commands.
10331         * valprint.c (user_print_options): Initialize new member.
10332         * valprint.h (struct value_print_options) <finish_print>: New
10333         member.
10334
10335 2019-05-28  Tom Tromey  <tromey@adacore.com>
10336
10337         * ada-lang.c (ada_remove_Xbn_suffix)
10338         (find_old_style_renaming_symbol)
10339         (parse_old_style_renaming): Remove.
10340         (ada_find_renaming_symbol): Don't call
10341         find_old_style_renaming_symbol.
10342         (ada_is_renaming_symbol): Rename from
10343         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10344         bool.  Now static.
10345         (ada_read_var_value): Update and simplify.
10346         * ada-exp.y (write_var_or_type): Remove old code.
10347
10348 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10349
10350         PR gdb/25010
10351         * event-top.c: Remove include comment.
10352         * inflow.c (class scoped_ignore_sigttou): Move from here...
10353         * inflow.h (class scoped_ignore_sigttou): ...to here.
10354         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10355         * top.c:  Remove include comment.
10356
10357 2019-05-27  Tom Tromey  <tom@tromey.com>
10358
10359         * NEWS: Fix typo.
10360
10361 2019-05-22  Tom Tromey  <tromey@adacore.com>
10362
10363         * target.c (target_follow_exec): Constify parameter.
10364         * target-delegates.c: Rebuild.
10365         * remote.c (remote_target::follow_exec): Constify parameter.
10366         * infrun.c (follow_exec): Constify parameter.
10367         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10368         (target_follow_exec): Likewise.
10369
10370 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10371
10372         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10373         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10374
10375 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10376
10377         * NEWS: Add debugredirect and testsuite sections.
10378
10379 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10380
10381         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10382         target descriptions using exclusively floating point register name
10383         aliases.
10384
10385 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10386
10387         PR gdb/18644:
10388         * f-lang.c (build_fortran_types): Handle the case where
10389         gdbarch_floatformat_for_type returns a nullptr.
10390
10391 2019-05-21  Tom de Vries  <tdevries@suse.de>
10392
10393         PR cli/24587
10394         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10395
10396 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10397
10398         PR gdb/18644:
10399         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10400         16-byte floats.
10401         * i386-tdep.c (i386_floatformat_for_type): Use
10402         floatformats_ia64_quad for the 16-byte floating point component
10403         within a fortran 32-byte complex number.
10404
10405 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10406
10407         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10408         delete default constructor.
10409         (find_partial_die): Update to return const struct.
10410         (partial_die_parent_scope): Move variable declaration into scope
10411         of its use and change its type to auto.
10412         (guess_partial_die_structure_name): Likewise.
10413         (partial_die_info::fixup): Likewise.
10414
10415 2019-05-17  Tom Tromey  <tromey@adacore.com>
10416
10417         * source.c (find_and_open_source): Remove cast.
10418
10419 2019-05-17  Tom Tromey  <tromey@adacore.com>
10420
10421         * annotate.c (annotate_source): Make "filename" const.
10422         * annotate.h (annotate_source): Use const.
10423
10424 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10425
10426         * disasm.c (set_disassembler_options): Send errors to stderr.
10427
10428 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10429
10430         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10431         (cli_interp_base::set_logging): Check debug_redirect.
10432         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10433         * cli/cli-logging.c (debug_redirect): Add static variable.
10434         (pop_output_files): Add default param.
10435         (handle_redirections): Print debug setting.
10436         (show_logging_command): Likewise.
10437         (_initialize_cli_logging): Add debugredirect command.
10438         * interps.c (current_interp_set_logging): Add debug_redirect
10439         parameter.
10440         * interps.h (set_logging): Add debug_redirect parameter.
10441         (current_interp_set_logging): Likewise.
10442         * mi/mi-common.h: Likewise.
10443         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10444
10445 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10446             Tom Tromey  <tromey@adacore.com>
10447
10448         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10449         directly.
10450         * cli/cli-interp.h (make_logging_output): Remove declaration.
10451         * cli/cli-logging.c (make_logging_output): Remove function.
10452         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10453         directly.
10454         * ui-file.c (tee_file::tee_file): Remove bools.
10455         (tee_file::~tee_file): Remove deletes.
10456         * ui-file.h (tee_file): Remove bools.
10457
10458 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10459
10460         * mi/mi-cmds.h (mi_cmd_complete): New function.
10461         * mi/mi-main.c (mi_cmd_complete): Likewise.
10462         * mi/mi-cmds.c: Define new MI command -complete.
10463         * NEWS: Mention new -complete command.
10464
10465 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10466
10467         * completer.h (complete): New function.
10468         * completer.c (complete): Likewise.
10469         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10470         function defined in completer.h.
10471
10472 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10473
10474         * MAINTAINERS (Write After Approval): Add myself.
10475
10476 2019-05-17  Tom de Vries  <tdevries@suse.de>
10477
10478         PR gdb/24094
10479         * dwarf2read.c (struct cu_partial_die_info): New struct.
10480         (find_partial_die): Return cu_partial_die_info.
10481         (partial_die_parent_scope, guess_partial_die_structure_name)
10482         (partial_die_info::fixup): Handle new return type of find_partial_die.
10483
10484 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10485
10486         PR breakpoints/24541
10487         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10488         "std::string", simplifying the algorithm.
10489
10490 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10491
10492         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10493         (stap_static_probe_ops::get_probes): Likewise.
10494
10495 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10496
10497         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10498         '-')" and "else if".
10499         (stap_parse_single_operand): Join checks for
10500         "gdbarch_stap_parse_special_token_p" and
10501         "gdbarch_stap_parse_special_token" in the same "if" statement.
10502         Invert check when verifying for operation on register
10503         displacement.
10504
10505 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10506
10507         * stap-probe.c (stap_get_opcode): Update comment.
10508         (stap_get_expected_argument_type): Likewise.
10509         (handle_stap_probe): Likewise.
10510
10511 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10512
10513         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10514         return type to 'bool'.  Adjust comment.  Use 'bool' when
10515         appropriate.
10516         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10517         * stap-probe.c (stap_parse_argument_1): Likewise.
10518         (stap_is_operator): Likewise.
10519         (stap_is_generic_prefix): Likewise.
10520         (stap_is_register_prefix): Likewise.
10521         (stap_is_register_indirection_prefix): Likewise.
10522         (stap_is_integer_prefix): Likewise.
10523         (stap_generic_check_suffix): Likewise.
10524         (stap_check_integer_suffix): Likewise.
10525         (stap_check_register_suffix): Likewise.
10526         (stap_check_register_indirection_suffix): Likewise.
10527         (stap_parse_register_operand): Likewise.
10528         (stap_parse_single_operand): Likewise.
10529         (stap_parse_argument_1): Likewise.
10530         (stap_probe::get_argument_count): Likewise.
10531         (stap_is_operator): Likewise.
10532
10533 2019-05-16  Tom Tromey  <tromey@adacore.com>
10534
10535         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10536         keyword to foreach.
10537
10538 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10539
10540         * linux-thread-db.c (try_thread_db_load_1): Change return type
10541         to bool.
10542         (try_thread_db_load): Likewise.
10543         (try_thread_db_load_from_pdir_1): Likewise.
10544         (try_thread_db_load_from_pdir): Likewise.
10545         (try_thread_db_load_from_sdir): Likewise.
10546         (try_thread_db_load_from_dir): Likewise.
10547         (thread_db_load_search): Likewise.
10548         (has_libpthread): Likewise.
10549         (thread_db_load): Likewise.
10550
10551 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10552
10553         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10554         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10555         NULL, and complain/return if that's the case.
10556
10557 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10558
10559         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10560         (advance, posn, abstract_read_memory): New functions.
10561         [struct mem_read_abstraction]: New struct.
10562         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10563
10564 2019-05-14  Tom Tromey  <tromey@adacore.com>
10565
10566         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10567         value is not lval_memory.
10568
10569 2019-05-14  Tom Tromey  <tromey@adacore.com>
10570
10571         * solib.c (info_sharedlibrary_command): Style the file name.
10572
10573 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10574
10575         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10576         (aarch64_vnv_type): Likewise.
10577         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10578         * common/tdesc.c: Likewise.
10579         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10580         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10581         * features/aarch64-fpu.xml: Add ieee half view.
10582         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10583         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10584         * gdbtypes.h (struct builtin_type): Likewise.
10585         (struct objfile_type): Likewise.
10586
10587 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10588
10589         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10590         typo.
10591         * location.h (string_to_event_location): Likewise.
10592
10593 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10594
10595         GDB 8.3 released.
10596
10597 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10598
10599         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10600         New variable declaration.
10601         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10602         New variable.
10603         (print_one_breakpoint): Use ui_out::test_flags and new global
10604         variable to compute use_fixed_output.
10605         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10606         Remove.
10607         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10608         (mi_multi_location_breakpoint_output_fixed): Remove.
10609         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10610         new variable.
10611         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10612         fix_multi_location_breakpoint_output flag if version >= 3.
10613         * ui-out.h (enum ui_out_flag)
10614         <fix_multi_location_breakpoint_output>: New enumerator.
10615
10616 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10617
10618         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10619
10620 2019-05-10  Tom Tromey  <tromey@adacore.com>
10621
10622         * ada-lang.c (catch_ada_completer): New function.
10623         (_initialize_ada_language): Use it.
10624
10625 2019-05-10  Tom Tromey  <tromey@adacore.com>
10626
10627         * thread.c (print_thread_info): Make "requested_threads" const.
10628         * gdbthread.h (print_thread_info): Make "requested_threads"
10629         const.
10630         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10631         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10632
10633 2019-05-08  Tom Tromey  <tom@tromey.com>
10634
10635         * gdbtypes.c (objfile_type_data): Change type.
10636         (objfile_type, _initialize_gdbtypes): Update.
10637
10638 2019-05-08  Tom Tromey  <tom@tromey.com>
10639
10640         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10641         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10642         (_initialize_dwarf2_frame): Update.
10643
10644 2019-05-08  Tom Tromey  <tom@tromey.com>
10645
10646         * objc-lang.c (objc_objfile_data): Change type.
10647         (find_methods): Update.
10648         (_initialize_objc_lang): Remove.
10649
10650 2019-05-08  Tom Tromey  <tom@tromey.com>
10651
10652         * stabsread.c (rs6000_builtin_type_data): Change type.
10653         (rs6000_builtin_type, _initialize_stabsread): Update.
10654
10655 2019-05-08  Tom Tromey  <tom@tromey.com>
10656
10657         * mips-tdep.c (mips_pdr_data): Remove.
10658         (_initialize_mips_tdep): Update.
10659
10660 2019-05-08  Tom Tromey  <tom@tromey.com>
10661
10662         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10663         (hppa_init_objfile_priv_data, read_unwind_info)
10664         (find_unwind_entry, _initialize_hppa_tdep): Update.
10665
10666 2019-05-08  Tom Tromey  <tom@tromey.com>
10667
10668         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10669         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10670         on obstack.
10671         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10672
10673 2019-05-08  Tom Tromey  <tom@tromey.com>
10674
10675         * mdebugread.c (basic_type_data): Change type.
10676         (basic_type, _initialize_mdebugread): Update.
10677
10678 2019-05-08  Tom Tromey  <tom@tromey.com>
10679
10680         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10681
10682 2019-05-08  Tom Tromey  <tom@tromey.com>
10683
10684         * nto-tdep.c (nto_inferior_data_reg): Change type.
10685         (nto_inferior_data): Update.
10686         (nto_inferior_data_cleanup, nto_new_inferior_data)
10687         (_initialize_nto_tdep): Remove.
10688         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10689
10690 2019-05-08  Tom Tromey  <tom@tromey.com>
10691
10692         * ada-lang.c (struct ada_inferior_data): Add initializers.
10693         (ada_inferior_data): Change type.
10694         (ada_inferior_data_cleanup): Remove.
10695         (get_ada_inferior_data, ada_inferior_exit)
10696         (struct ada_pspace_data): Add initializers, destructor.
10697         (ada_pspace_data_handle): Change type.
10698         (get_ada_pspace_data): Update.
10699         (ada_pspace_data_cleanup): Remove.
10700
10701 2019-05-08  Tom Tromey  <tom@tromey.com>
10702
10703         * coffread.c (struct coff_symfile_info): Add initializers.
10704         (coff_objfile_data_key): Move lower.  Change type.
10705         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10706         Update.
10707         (coff_free_info): Remove.
10708
10709 2019-05-08  Tom Tromey  <tom@tromey.com>
10710
10711         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10712         (fbsd_pspace_data_handle): Move lower.  Change type.
10713         (get_fbsd_pspace_data): Update.
10714         (fbsd_pspace_data_cleanup): Remove.
10715         (_initialize_fbsd_tdep): Update.
10716
10717 2019-05-08  Tom Tromey  <tom@tromey.com>
10718
10719         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10720         (get_ada_tasks_pspace_data): Update.
10721         (ada_tasks_pspace_data_cleanup): Remove.
10722         (_initialize_tasks): Update.
10723         (ada_tasks_inferior_data_handle): Change type.
10724         (get_ada_tasks_inferior_data): Update.
10725         (ada_tasks_inferior_data_cleanup): Remove.
10726         (struct ada_tasks_pspace_data): Add initializers.
10727
10728 2019-05-08  Tom Tromey  <tom@tromey.com>
10729
10730         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10731         * symfile-debug.c (debug_sym_get_probes): Change type.
10732         * stap-probe.c (handle_stap_probe):
10733         (stap_static_probe_ops::get_probes): Change type.
10734         * probe.h (class static_probe_ops) <get_probes>: Change type.
10735         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10736         (parse_probes_in_pspace): Update.
10737         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10738         Update.
10739         (any_static_probe_ops::get_probes): Change type.
10740         * elfread.c (elfread_data): New typedef.
10741         (probe_key): Change type.
10742         (elf_get_probes): Likewise.  Update.
10743         (probe_key_free): Remove.
10744         (_initialize_elfread): Update.
10745         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10746         Change type.
10747         (dtrace_process_dof_probe, dtrace_process_dof)
10748         (dtrace_static_probe_ops::get_probe): Change type.
10749
10750 2019-05-08  Tom Tromey  <tom@tromey.com>
10751
10752         * xcoffread.c (struct xcoff_symfile_info): Rename from
10753         coff_symfile_info.  Add initializers.
10754         (xcoff_objfile_data_key): Move lower.  Change type.
10755         (XCOFF_DATA): Rewrite.
10756         (xcoff_free_info): Remove.
10757         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10758         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10759         (xcoff_initial_scan): Update.
10760
10761 2019-05-08  Tom Tromey  <tom@tromey.com>
10762
10763         * solib-svr4.c (struct svr4_info): Add initializers and
10764         destructor.
10765         <probes_table>: Now an htab_up.
10766         (solib_svr4_pspace_data): Change type.
10767         (free_probes_table): Simplify.
10768         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10769         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10770         (probes_table_remove_objfile_probes, register_solib_event_probe)
10771         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10772         (_initialize_svr4_solib): Update.
10773
10774 2019-05-08  Tom Tromey  <tom@tromey.com>
10775
10776         * remote.c (remote_pspace_data): Change type.
10777         (remote_pspace_data_cleanup): Remove.
10778         (get_remote_exec_file, set_pspace_remote_exec_file)
10779         (_initialize_remote): Update.
10780
10781 2019-05-08  Tom Tromey  <tom@tromey.com>
10782
10783         * breakpoint.c (breakpoint_objfile_key): Change type.
10784         (get_breakpoint_objfile_data): Update.
10785         (free_breakpoint_objfile_data): Remove.
10786         (_initialize_breakpoint): Update.
10787
10788 2019-05-08  Tom Tromey  <tom@tromey.com>
10789
10790         * linux-tdep.c (struct linux_info): Add initializers.
10791         (linux_inferior_data): Move.  Change type.
10792         (invalidate_linux_cache_inf): Update.
10793         (linux_inferior_data_cleanup): Remove.
10794         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10795
10796 2019-05-08  Tom Tromey  <tom@tromey.com>
10797
10798         * auxv.c (auxv_inferior_data): Move.  Change type.
10799         (auxv_inferior_data_cleanup): Remove.
10800         (invalidate_auxv_cache_inf): Rewrite.
10801         (get_auxv_inferior_data, _initialize_auxv): Update.
10802
10803 2019-05-08  Tom Tromey  <tom@tromey.com>
10804
10805         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10806         (symfile_debug_objfile_data_key): Change type.
10807         (symfile_debug_installed, debug_qf_has_symbols)
10808         (debug_qf_find_last_source_symtab)
10809         (debug_qf_forget_cached_source_info)
10810         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10811         (debug_qf_print_stats, debug_qf_dump)
10812         (debug_qf_expand_symtabs_for_function)
10813         (debug_qf_expand_all_symtabs)
10814         (debug_qf_expand_symtabs_with_fullname)
10815         (debug_qf_map_matching_symbols)
10816         (debug_qf_expand_symtabs_matching)
10817         (debug_qf_find_pc_sect_compunit_symtab)
10818         (debug_qf_map_symbol_filenames)
10819         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10820         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10821         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10822         (debug_sym_read_linetable, debug_sym_relocate): Update.
10823         (symfile_debug_free_objfile): Remove.
10824         (install_symfile_debug_logging, _initialize_symfile_debug):
10825         Update.
10826
10827 2019-05-08  Tom Tromey  <tom@tromey.com>
10828
10829         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10830         allocate_on_obstack.
10831         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10832         (get_dwarf2_per_objfile): Update.
10833         (set_dwarf2_per_objfile): Remove.
10834         (dwarf2_has_info, dwarf2_get_section_info): Update.
10835         (dwarf2_free_objfile): Remove.
10836         (_initialize_dwarf2_read): Update.
10837
10838 2019-05-08  Tom Tromey  <tom@tromey.com>
10839
10840         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10841         initializers.
10842         <unsupported_script_warning_printed,
10843         script_not_found_warning_printed>: Now bool.
10844         (auto_load_pspace_data): Change type.
10845         (~auto_load_pspace_info): Rename from
10846         auto_load_pspace_data_cleanup.
10847         (get_auto_load_pspace_data, init_loaded_scripts_info)
10848         (clear_section_scripts, maybe_print_unsupported_script_warning)
10849         (maybe_print_script_not_found_warning, _initialize_auto_load):
10850         Update.
10851
10852 2019-05-08  Tom Tromey  <tom@tromey.com>
10853
10854         * objfiles.c (objfile_pspace_info): Add destructor and
10855         initializers.
10856         (objfiles_pspace_data): Change type.
10857         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10858         (get_objfile_pspace_data): Update.
10859         (objfiles_bfd_data): Change type.
10860         (get_objfile_bfd_data): Update.
10861         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10862
10863 2019-05-08  Tom Tromey  <tom@tromey.com>
10864
10865         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10866         Change type.
10867         (get_catch_syscall_inferior_data): Update.
10868         (catch_syscall_inferior_data_cleanup): Remove.
10869         (_initialize_break_catch_syscall): Update.
10870
10871 2019-05-08  Tom Tromey  <tom@tromey.com>
10872
10873         * inflow.c (struct terminal_info): Add destructor and
10874         initializers.
10875         (inflow_inferior_data): Change type.
10876         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10877         (get_inflow_inferior_data, inflow_inferior_exit)
10878         (swap_terminal_info, _initialize_inflow): Update.
10879
10880 2019-05-08  Tom Tromey  <tom@tromey.com>
10881
10882         * target-dcache.c (target_dcache_cleanup): Remove.
10883         (target_dcache_aspace_key): Change type.
10884         (target_dcache_init_p, target_dcache_invalidate)
10885         (target_dcache_get, target_dcache_get_or_init)
10886         (_initialize_target_dcache): Update.
10887         * dcache.h (struct dcache_deleter): New.
10888
10889 2019-05-08  Tom Tromey  <tom@tromey.com>
10890
10891         * symtab.c (struct symbol_cache): Add destructor and
10892         initializers.
10893         (symbol_cache_key): Move.  Change type.
10894         (make_symbol_cache, free_symbol_cache): Remove.
10895         (get_symbol_cache): Update.
10896         (symbol_cache_cleanup): Remove.
10897         (ALL_PSPACES, symbol_cache_flush)
10898         (maintenance_print_symbol_cache)
10899         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10900         Update.
10901
10902 2019-05-08  Tom Tromey  <tom@tromey.com>
10903
10904         * symtab.c (struct main_info): Add destructor and initializers.
10905         (main_progspace_key): Move.  Change type.
10906         (get_main_info): Update.
10907         (main_info_cleanup): Remove.
10908         (_initialize_symtab): Update.
10909
10910 2019-05-08  Tom Tromey  <tom@tromey.com>
10911
10912         * registry.h (DECLARE_REGISTRY): Define the _key class.
10913
10914 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10915
10916         * NEWS: Merge two 'New commands' sections.
10917
10918 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10919
10920         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10921         parameter and use Ada language definition instead.
10922         (ada_val_print_ptr): Remove unused language parameter.
10923         (ada_val_print_num): Remove language parameter and use Ada language
10924         definition instead.
10925         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10926         parameter.
10927         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10928         parameter and use Ada language definition instead.
10929         (ada_val_print_1): Update all ada_val_print_xxx calls.
10930         Remove language parameter.
10931         (ada_val_print): Update ada_val_print_1 call.
10932
10933 2019-05-08  Tom Tromey  <tromey@adacore.com>
10934
10935         * remote.c (remote_hw_watchpoint_limit)
10936         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10937         Now static.
10938
10939 2019-05-08  Tom Tromey  <tromey@adacore.com>
10940
10941         * maint.c (_initialize_maint_cmds): Move initialization code to
10942         remote.c.
10943         (watchdog, show_watchdog): Move to remote.c.
10944         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10945         "watchdog" static.
10946         (_initialize_remote): Move initialization code from maint.c.
10947         * defs.h (watchdog): Don't declare.
10948
10949 2019-05-08  Tom Tromey  <tromey@adacore.com>
10950
10951         * tui/tui-interp.c: Include main.h.
10952         * interps.c: Include main.h.
10953         * main.h (interpreter_p): Declare.
10954         * defs.h (interpreter_p): Don't declare.
10955
10956 2019-05-08  Tom Tromey  <tromey@adacore.com>
10957
10958         * dwarf2loc.c: Include dwarf2read.h.
10959         * defs.h (read_unsigned_leb128): Don't declare.
10960         * dwarf2read.h (read_unsigned_leb128): Declare.
10961
10962 2019-05-08  Tom Tromey  <tromey@adacore.com>
10963
10964         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10965         method.
10966
10967 2019-05-08  Tom Tromey  <tromey@adacore.com>
10968
10969         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10970         when no wrap column is set.
10971
10972 2019-05-08  Tom Tromey  <tromey@adacore.com>
10973
10974         * c-lang.c (c_get_string): Handle non-C-style arrays.
10975
10976 2019-05-08  Tom Tromey  <tromey@adacore.com>
10977
10978         * typeprint.c (print_offset_data::update): Print the bit offset,
10979         not the number of bits remaining.
10980
10981 2019-05-08  Tom Tromey  <tromey@adacore.com>
10982
10983         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10984         padding at end of comment.
10985
10986 2019-05-08  Tom Tromey  <tromey@adacore.com>
10987
10988         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10989         Compare main types.
10990
10991 2019-05-06  Tom Tromey  <tom@tromey.com>
10992
10993         * common/scoped_mmap.c: Include common-defs.h.
10994         * common/scoped_mmap.h: Don't include config.h.
10995
10996 2019-05-04  Tom Tromey  <tom@tromey.com>
10997
10998         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10999         (struct aarch64_call_info): Add initializers.
11000         <si>: Now a std::vector.
11001         (pass_on_stack, aarch64_push_dummy_call): Update.
11002
11003 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
11004             Tom Tromey  <tom@tromey.com>
11005
11006         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
11007         (ppc_threads): Now a std::vector.  Now static.
11008         (hwdebug_find_thread_points_by_tid)
11009         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
11010         Update.
11011
11012 2019-05-04  Tom Tromey  <tom@tromey.com>
11013
11014         * arc-tdep.c (arc_tdesc_init): Return bool.
11015
11016 2019-05-04  Tom Tromey  <tom@tromey.com>
11017
11018         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
11019         Use gdb_assert_not_reached.
11020
11021 2019-05-04  Tom Tromey  <tom@tromey.com>
11022
11023         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
11024         "false".
11025
11026 2019-05-04  Tom Tromey  <tom@tromey.com>
11027
11028         * arc-tdep.c (arc_tdesc_init): Use bool.
11029
11030 2019-05-04  Tom Tromey  <tom@tromey.com>
11031
11032         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
11033
11034 2019-05-04  Tom Tromey  <tom@tromey.com>
11035
11036         * cli/cli-cmds.c (valid_command_p): Return bool.
11037
11038 2019-05-04  Tom Tromey  <tom@tromey.com>
11039
11040         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
11041         * command.h (valid_user_defined_cmd_name_p): Channge return type.
11042
11043 2019-05-04  Raul Tambre  <raul@tambre.ee>
11044
11045         * python/lib/gdb/prompt.py (_ExtendedPrompt)
11046         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
11047         operator for comparison.
11048
11049 2019-05-04  Tom Tromey  <tom@tromey.com>
11050
11051         * psymtab.c (psymbol_name_matches, match_partial_symbol)
11052         (lookup_partial_symbol, print_partial_symbols)
11053         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
11054         (psymbol_compare): Update.
11055         (add_psymbol_to_bcache): Clear the entire psymbol.
11056         (maintenance_check_psymtabs): Update.
11057         * psympriv.h (struct partial_symbol): Don't derive from
11058         general_symbol_info.
11059         <obj_section, unrelocated_address, address,
11060         set_unrelocated_address>: Update.
11061         <ginfo>: New member.
11062         * dwarf-index-write.c (write_psymbols, debug_names::insert)
11063         (debug_names::write_psymbols): Update.
11064
11065 2019-05-04  Tom de Vries  <tdevries@suse.de>
11066
11067         * contrib/cc-with-tweaks.sh: Support -n arg.
11068
11069 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11070
11071         * corelow.c (core_target::detach): Ensure frame cache and
11072         register caches are cleared.
11073         inferior.c (exit_inferior_1): Likewise.
11074
11075 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
11076             Tom Tromey  <tom@tromey.com>
11077
11078         * dictionary.c (collate_pending_symbols_by_language): Remove
11079         "struct" from foreach.
11080         * symtab.c (lookup_global_symbol_from_objfile)
11081         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11082         foreach.
11083         * ser-tcp.c (net_open): Remove "struct" from foreach.
11084         * objfiles.c (objfile_relocate, objfile_rebase)
11085         (objfile_has_symbols): Remove "struct" from foreach.
11086         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11087         from foreach.
11088         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11089         foreach.
11090         * darwin-nat.c (thread_info_from_private_thread_info): Remove
11091         "struct" from foreach.
11092         * ada-lang.c (create_excep_cond_exprs)
11093         (ada_exception_catchpoint_cond_string): Remove "struct" from
11094         foreach.
11095
11096 2019-05-03  Tom Tromey  <tromey@adacore.com>
11097
11098         * ada-exp.y (convert_char_literal): Check suffix of each
11099         enumerator.
11100
11101 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
11102
11103         PR ada/21406:
11104         * ada-exp.y (yywrap): Don't define.
11105         * ada-lex.l (%option): Add noyywrap
11106         (yywrap): Remove.
11107
11108 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
11109
11110         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11111         _WIN32_WINNT to the XP level, unless already defined to a higher
11112         level.
11113
11114         * unittests/parse-connection-spec-selftests.c:
11115         * ser-tcp.c:
11116         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
11117         override.
11118
11119         * symfile.c (find_separate_debug_file): Remove colon from the
11120         drive spec of DOS/Windows file names of the target, so that the
11121         file name produced from DEBUGDIR and the target's directory will
11122         be valid on DOS/Windows systems.
11123
11124 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
11125
11126         * rust-lang.c (val_print_struct): Handle printing structures
11127         containing strings.
11128
11129 2019-05-02  Tom Tromey  <tromey@adacore.com>
11130
11131         * valarith.c (_initialize_valarith): Remove.
11132
11133 2019-05-01  Tom Tromey  <tromey@adacore.com>
11134
11135         * ada-lang.c (ada_value_primitive_field): Treat more fields as
11136         bitfields.
11137
11138 2019-05-01  Tom Tromey  <tromey@adacore.com>
11139
11140         * ada-lang.c (ada_value_assign): Correctly compute starting offset
11141         for big-endian copies.
11142
11143 2019-04-30  Ali Tamur  <tamur@google.com>
11144         * gdb/dwarf2read.c (read_3_bytes): New declaration.
11145         (read_attribute_value): Added DW_FORM_strx1-4 cases.
11146         (read_3_bytes): New function.
11147
11148 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11149
11150         * windows-nat.c (main_thread_id): Delete.
11151         (handle_output_debug_string): Replace main_thread_id by
11152         current_event.dwThreadId.
11153         (fake_create_process): Likewise.
11154         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11155         Do not set main_thread_id.
11156         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11157         current_event.dwThreadId.
11158         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11159
11160 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11161
11162         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11163         Use current_event.dwThreadId instead of main_thread_id.
11164
11165 2019-04-30  Tom Tromey  <tromey@adacore.com>
11166
11167         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11168         (create_excep_cond_exprs): Iterate over program spaces.
11169         (ada_exception_catchpoint_cond_string): Examine all minimal
11170         symbols for exception types.
11171
11172 2019-04-30  Tom Tromey  <tromey@adacore.com>
11173
11174         PR c++/24470:
11175         * dwarf2read.c (process_structure_scope): Handle case where type
11176         has template parameters but no symbol was created.
11177
11178 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11179             Chris January  <chris.january@arm.com>
11180
11181         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11182         qualifier.
11183         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11184
11185 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * f-typeprint.c (f_print_type): Update rules for printing
11188         whitespace.
11189         (f_type_print_varspec_suffix): Likewise.
11190
11191 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11192             Chris January  <chris.january@arm.com>
11193
11194         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11195         function arguments.
11196
11197 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11198
11199         * f-lang.c (build_fortran_types): Change name of void type to
11200         lower case.
11201         * f-typeprint.c (f_type_print_base): Print the name of the void
11202         type, rather than a fixed string.
11203         * f-valprint.c (f_decorations): Use lower case void string.
11204
11205 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11206             Chris January  <chris.january@arm.com>
11207
11208         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11209         types for Fortran.
11210
11211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11212             Chris January  <chris.january@arm.com>
11213             David Lecomber  <david.lecomber@arm.com>
11214
11215         * f-exp.y (BINOP_INTRINSIC): New token.
11216         (exp): New parser rule handling BINOP_INTRINSIC.
11217         (f77_keywords): Add new builtin procedures.
11218         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11219         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11220         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11221         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11222         (print_unop_subexp_f): New function.
11223         (print_binop_subexp_f): New function.
11224         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11225         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11226         (dump_subexp_body_f): Likewise.
11227         (operator_check_f): Likewise.
11228         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11229         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11230
11231 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11232
11233         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11234         UNOP_KIND.
11235         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11236         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11237         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11238         (operator_length_f): New fuction.
11239         (print_subexp_f): New function.
11240         (op_name_f): New function.
11241         (dump_subexp_body_f): New function.
11242         (operator_check_f): New function.
11243         (exp_descriptor_f): Replace standard expression handling functions
11244         with new functions.
11245         * gdb/fortran-operator.def: New file.
11246         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11247         * gdb/std-operator.def: Remove UNOP_KIND.
11248
11249 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11250
11251         * std-operator.def: Remove unbalanced, stray double quote
11252         character.
11253
11254 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11255             Chris January  <chris.january@arm.com>
11256             Daniel Everett  <daniel.everett@arm.com>
11257             Nick Forrington  <nick.forrington@arm.com>
11258             Richard Bunt  <richard.bunt@arm.com>
11259
11260         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11261         of depth when printing anonymous structs or unions.
11262         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11263         Don't print either the top-level value, or the children if the
11264         max-depth is exceeded.
11265         (ppscm_print_children): When printing the key of a map, allow one
11266         extra level of depth.
11267         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11268         print either the top-level value, or the children if the max-depth
11269         is exceeded.
11270         (print_children): When printing the key of a map, allow one extra
11271         level of depth.
11272         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11273         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11274         (user_print_options): Initialise max_depth field.
11275         (val_print_scalar_or_string_type_p): New function.
11276         (val_print): Check to see if the max depth has been reached.
11277         (val_print_check_max_depth): Define new function.
11278         (show_print_max_depth): New function.
11279         (_initialize_valprint): Add 'print max-depth' option.
11280         * valprint.h (struct value_print_options) <max_depth>: New field.
11281         (val_print_check_max_depth): Declare new function.
11282         * NEWS: Document new feature.
11283
11284 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11285
11286         * ada-lang.c (ada_language_defn): Initialise new field.
11287         * c-lang.c (c_is_string_type_p): New function.
11288         (c_language_defn): Initialise new field.
11289         (cplus_language_defn): Initialise new field.
11290         (asm_language_defn): Initialise new field.
11291         (minimal_language_defn): Initialise new field.
11292         * c-lang.h (c_is_string_type_p): Declare new function.
11293         * d-lang.c (d_language_defn): Initialise new field.
11294         * f-lang.c (f_is_string_type_p): New function.
11295         (f_language_defn): Initialise new field.
11296         * go-lang.c (go_is_string_type_p): New function.
11297         (go_language_defn): Initialise new field.
11298         * language.c (default_is_string_type_p): New function.
11299         (unknown_language_defn): Initialise new field.
11300         (auto_language_defn): Initialise new field.
11301         * language.h (struct language_defn) <la_is_string_type_p>: New
11302         member variable.
11303         (default_is_string_type_p): Declare new function.
11304         * m2-lang.c (m2_language_defn): Initialise new field.
11305         * objc-lang.c (objc_language_defn): Initialise new field.
11306         * opencl-lang.c (opencl_language_defn): Initialise new field.
11307         * p-lang.c (pascal_is_string_type_p): New function.
11308         (pascal_language_defn): Initialise new field.
11309         * rust-lang.c (rust_is_string_type_p): New function.
11310         (rust_language_defn): Initialise new field.
11311
11312 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11313
11314         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11315         New field.
11316         * ada-lang.c (ada_language_defn): Initialise new field.
11317         * c-lang.c (c_language_defn): Likewise.
11318         (cplus_language_defn): Likewise.
11319         (asm_language_defn): Likewise.
11320         (minimal_language_defn): Likewise.
11321         * d-lang.c (d_language_defn): Likewise.
11322         * f-lang.c (f_language_defn): Likewise.
11323         * go-lang.c (go_language_defn): Likewise.
11324         * language.c (unknown_language_defn): Likewise.
11325         (auto_language_defn): Likewise.
11326         * m2-lang.c (m2_language_defn): Likewise.
11327         * objc-lang.c (objc_language_defn): Likewise.
11328         * opencl-lang.c (opencl_language_defn): Likewise.
11329         * p-lang.c (pascal_language_defn): Likewise.
11330         * rust-lang.c (rust_language_defn): Likewise.
11331
11332 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11333
11334         * ada-lang.c (ada_is_character_type): Change return type to bool.
11335         (ada_is_string_type): Likewise.
11336         * ada-lang.h (ada_is_character_type): Update declaration
11337         (ada_is_string_type): Likewise.
11338
11339 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11340
11341         Support style in 'frame|thread apply'
11342
11343         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11344         * record.c (record_start, record_stop): Update callers of
11345         execute_command_to_string with false.
11346         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11347         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11348         methods.
11349         (class string_file): New constructor with term_out parameter.
11350         Override methods term_out and can_emit_style_escape.  New member
11351         term_out.
11352         (class stdio_file): Override can_emit_style_escape.
11353         (class tee_file): Override term_out and can_emit_style_escape.
11354         * utils.h (can_emit_style_escape): Remove.
11355         * utils.c (can_emit_style_escape): Likewise.
11356         Update all callers of can_emit_style_escape (SOMESTREAM) to
11357         SOMESTREAM->can_emit_style_escape.
11358         * source-cache.c (source_cache::get_source_lines): Likewise.
11359         * stack.c (frame_apply_command_count): Call execute_command_to_string
11360         passing the term_out characteristic of the current gdb_stdout.
11361         * thread.c (thr_try_catch_cmd): Likewise.
11362         * top.c (execute_command_to_string): pass term_out parameter
11363         to construct the string_file for the command output.
11364         * ui-file.c (term_cli_styling): New function (most code moved
11365         from utils.c can_emit_style_escape).
11366         (string_file::string_file, string_file::can_emit_style_escape,
11367         stdio_file::can_emit_style_escape, tee_file::term_out,
11368         tee_file::can_emit_style_escape): New functions.
11369
11370 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11371
11372         * NEWS: Mention the new set|show may-call-functions.
11373         * infcall.c (may_call_functions_p): New variable.
11374         (show_may_call_functions_p): New function.
11375         (call_function_by_hand_dummy): Throws an error if not
11376         may-call-functions.
11377         (_initialize_infcall): Call add_setshow_boolean_cmd for
11378         may-call-functions.
11379
11380 2019-04-25  Keith Seitz  <keiths@redhat.com>
11381
11382         PR c++/24367
11383         * cp-support.c (inspect_type): Don't attempt substitutions
11384         of symbol with the same name.
11385
11386 2019-04-25  Tom Tromey  <tromey@adacore.com>
11387
11388         PR gdb/24475:
11389         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11390         static.
11391
11392 2019-04-25  Tom Tromey  <tromey@adacore.com>
11393
11394         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11395         rvalue reference.
11396         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11397         (gdb_xml_parser::parse): Use std::move.
11398         * python/python-internal.h (gdbpy_convert_exception): Take a const
11399         reference.
11400         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11401         std::move.
11402         * python/py-utils.c (gdbpy_convert_exception): Take a const
11403         reference.
11404         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11405         Use std::move.
11406         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11407         Use std::move.
11408         * mi/mi-main.c (mi_print_exception): Take a const reference.
11409         * main.c (handle_command_errors): Take a const reference.
11410         * linespec.c (parse_linespec): Use std::move.
11411         * infcall.c (run_inferior_call): Use std::move.
11412         (call_function_by_hand_dummy): Use std::move.
11413         * exec.c (try_open_exec_file): Use std::move.
11414         * exceptions.h (exception_print, exception_fprintf)
11415         (exception_print_same): Update.
11416         * exceptions.c (print_exception, exception_print)
11417         (exception_fprintf, exception_print_same): Change parameters to
11418         const reference.
11419         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11420         * common/new-op.c: Use std::move.
11421         * common/common-exceptions.h (struct gdb_exception): Add move
11422         constructor.
11423         (struct gdb_exception_error, struct gdb_exception_quit, struct
11424         gdb_quit_bad_alloc): Change constructor to move constructor.
11425         (throw_exception): Change parameter to rvalue reference.
11426         * common/common-exceptions.c (throw_exception): Take rvalue
11427         reference.
11428         * cli/cli-interp.c (safe_execute_command): Use std::move.
11429         * breakpoint.c (insert_bp_location, location_to_sals): Use
11430         std::move.
11431
11432 2019-04-25  Tom Tromey  <tromey@adacore.com>
11433
11434         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11435         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11436         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11437         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11438         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11439         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11440         guile/scm-value.c: Use unpack.
11441         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11442         gdbscm_gdb_exception.
11443         (gdbscm_throw_gdb_exception): Likewise.
11444         (struct gdbscm_gdb_exception): New.
11445         (unpack): New function.
11446         (gdbscm_wrap): Use unpack.
11447
11448 2019-04-25  Tom Tromey  <tromey@adacore.com>
11449
11450         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11451         (gdb_rl_callback_handler): Use std::move.
11452         * common/common-exceptions.h (struct gdb_exception): Add move
11453         assignment operator.
11454         (throw_exception_sjlj): Change "exception" to const reference.
11455         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11456         (throw_exception_sjlj): Change "exception" to const reference.
11457
11458 2019-04-25  Tom Tromey  <tromey@adacore.com>
11459
11460         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11461         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11462         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11463         Update.
11464         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11465         Update.
11466         * mi/mi-interp.c (mi_interp::exec): Update.
11467         * linespec.c (parse_linespec): Update.
11468         * infcall.c (run_inferior_call): Update.
11469         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11470         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11471         (gdbscm_lookup_global_symbol): Update.
11472         * guile/scm-param.c (gdbscm_parameter_value): Update.
11473         * guile/scm-frame.c (gdbscm_frame_read_register)
11474         (gdbscm_frame_read_var): Update.
11475         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11476         * exec.c (try_open_exec_file): Update.
11477         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11478         (gdb_rl_callback_handler): Update.
11479         * common/common-exceptions.h (exception_none): Don't declare.
11480         * common/common-exceptions.c (exception_none): Don't define.
11481         (struct catcher) <exception>: Update.
11482         * cli/cli-interp.c (safe_execute_command): Update.
11483         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11484
11485 2019-04-25  Ali Tamur  <tamur@google.com>
11486
11487         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11488         (read_attribute_value): Likewise.
11489         (dwarf2_read_addr_index): Update comment.
11490         (read_str_index): Add DW_FORM_strx.
11491         (dwarf2_string_attr): Likewise.
11492         (dwarf2_const_value_attr): Likewise.
11493         (dump_die_shallow): Likewise.
11494         (dwarf2_fetch_constant_bytes): Likewise.
11495         (skip_form_bytes): Likewise.
11496         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11497
11498 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11499
11500         PR corefiles/11608
11501         PR corefiles/18187
11502         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11503         OFFSET.  Verify if current mapping contains an ELF header.
11504         (linux_find_memory_regions_full): Adjust call to
11505         dump_mapping_p.
11506
11507 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11508             Kang Li <kanglictf@gmail.com>
11509
11510         PR gdb/21600
11511
11512         * dwarf2-frame.c (read_initial_length): Be consistent about using
11513         unsigned representation of length.
11514         (decode_frame_entry_1): Likewise.  Check for wraparound of
11515         end pointer as well as buffer overflow.
11516
11517 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11518
11519         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11520         "vq".
11521
11522 2019-04-24  Tom Tromey  <tromey@adacore.com>
11523
11524         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11525
11526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11527
11528         * s12z-tdep.c (s12z_unwind_pc): Delete.
11529         (s12z_unwind_sp): Delete.
11530         (s12z_gdbarch_init): Don't register deleted functions with
11531         gdbarch.
11532
11533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11534
11535         * rl78-tdep.c (rl78_unwind_sp): Delete.
11536         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11537
11538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11539
11540         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11541         (xstormy16_unwind_pc): Delete.
11542         (xstormy16_dummy_id): Delete.
11543         (xstormy16_gdbarch_init): Don't register deleted functions with
11544         gdbarch.
11545
11546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11547
11548         * vax-tdep.c (vax_unwind_pc): Delete.
11549         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11550
11551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11552
11553         * v850-tdep.c (v850_unwind_sp): Delete.
11554         (v850_unwind_pc): Delete.
11555         (v850_dummy_id): Delete.
11556         (v850_gdbarch_init): Don't register deleted functions with
11557         gdbarch.
11558
11559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11560
11561         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11562         (tilegx_unwind_pc): Delete.
11563         (tilegx_unwind_dummy_id): Delete.
11564         (tilegx_gdbarch_init): Don't register deleted functions with
11565         gdbarch.
11566
11567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11568
11569         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11570         (tic6x_dummy_id): Delete.
11571         (tic6x_gdbarch_init): Don't register deleted functions with
11572         gdbarch.
11573
11574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * sparc-tdep.c (sparc_unwind_pc): Delete.
11577         (sparc32_gdbarch_init): Don't register deleted function with
11578         gdbarch.
11579
11580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11581
11582         * sh-tdep.c (sh_unwind_sp): Delete.
11583         (sh_unwind_pc): Delete.
11584         (sh_dummy_id): Delete.
11585         (sh_gdbarch_init): Don't register deleted functions with
11586         gdbarch.
11587
11588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11589
11590         * score-tdep.c (score_unwind_sp): Delete.
11591         (score_unwind_pc): Delete.
11592         (score_dummy_id): Delete.
11593         (score_gdbarch_init): Don't register deleted functions with
11594         gdbarch.
11595
11596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11597
11598         * rx-tdep.c (rx_unwind_pc): Delete.
11599         (rx_unwind_sp): Delete.
11600         (rx_dummy_id): Delete.
11601         (rx_gdbarch_init): Don't register deleted functions with
11602         gdbarch.  Update comment.
11603
11604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11605
11606         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11607         (rs6000_dummy_id): Delete.
11608         (rs6000_gdbarch_init): Don't register deleted functions with
11609         gdbarch.
11610
11611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11612
11613         * or1k-tdep.c (or1k_dummy_id): Delete.
11614         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11615
11616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11617
11618         * nios2-tdep.c (nios2_dummy_id): Delete.
11619         (nios2_unwind_sp): Delete.
11620         (nios2_gdbarch_init): Don't register deleted functions with
11621         gdbarch.
11622
11623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11624
11625         * nds32-tdep.c (nds32_dummy_id): Delete.
11626         (nds32_unwind_pc): Delete.
11627         (nds32_unwind_sp): Delete.
11628         (nds32_gdbarch_init): Don't register deleted functions with
11629         gdbarch.
11630
11631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11632
11633         * msp430-tdep.c (msp430_unwind_pc): Delete.
11634         (msp430_unwind_sp): Delete.
11635         (msp430_dummy_id): Delete.
11636         (msp430_gdbarch_init): Don't register deleted functions with
11637         gdbarch.
11638
11639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11640
11641         * moxie-tdep.c (moxie_unwind_sp): Delete.
11642         (moxie_unwind_pc): Delete.
11643         (moxie_dummy_id): Delete.
11644         (moxie_gdbarch_init): Don't register deleted functions with
11645         gdbarch.
11646
11647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11648
11649         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11650         (mn10300_unwind_pc): Delete.
11651         (mn10300_unwind_sp): Delete.
11652         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11653         mn10300_unwind_sp.
11654         (mn10300_frame_unwind_init): Don't register deleted functions with
11655         gdbarch.
11656
11657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11658
11659         * mep-tdep.c (mep_unwind_pc): Delete.
11660         (mep_unwind_sp): Delete.
11661         (mep_dummy_id): Delete.
11662         (mep_gdbarch_init): Don't register deleted functions with
11663         gdbarch.
11664
11665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11666
11667         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11668         (m68hc11_unwind_sp): Delete.
11669         (m68hc11_gdbarch_init): Don't register deleted functions with
11670         gdbarch.
11671
11672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11673
11674         * m32r-tdep.c (m32r_unwind_sp): Delete.
11675         (m32r_unwind_pc): Delete.
11676         (m32r_dummy_id): Delete.
11677         (m32r_gdbarch_init): Don't register deleted functions with
11678         gdbarch.
11679
11680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11681
11682         * m32c-tdep.c (m32c_unwind_pc): Delete.
11683         (m32c_unwind_sp): Delete.
11684         (m32c_dummy_id): Delete.
11685         (m32c_gdbarch_init): Don't register deleted functions with
11686         gdbarch.
11687
11688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11689
11690         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11691         (lm32_unwind_pc): Delete.
11692         (lm32_dummy_id): Delete.
11693         (lm32_gdbarch_init): Don't register deleted functions with
11694         gdbarch.
11695
11696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11697
11698         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11699         (iq2000_unwind_pc): Delete.
11700         (iq2000_dummy_id): Delete.
11701         (iq2000_gdbarch_init): Don't register deleted functions with
11702         gdbarch.
11703
11704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11705
11706         * nds32-tdep.c (nds32_type_align): Delete.
11707         (nds32_push_dummy_call): Use type_align instead.
11708
11709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11710
11711         * arm-tdep.c (arm_type_align): Only handle vector override case.
11712         (arm_push_dummy_call): Use type_align.
11713         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11714
11715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11716
11717         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11718         case.
11719         (pass_on_stack): Use type_align.
11720         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11721         function.
11722
11723 2019-04-23  Tom Tromey  <tromey@adacore.com>
11724
11725         * dwarf2read.c (line_header::file_name_at): Remove unused
11726         overload.
11727
11728 2019-04-23  Tom de Vries  <tdevries@suse.de>
11729
11730         PR gdb/24438
11731         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11732         invocation.
11733
11734
11735 2019-03-27  Ali Tamur  <tamur@google.com>
11736
11737         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11738         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11739         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11740         (dwarf_expr_context::get_addr_index): Likewise
11741         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11742         (symbol_needs_eval_context::get_addr_index): Likewise
11743         (disassemble_dwarf_expression): Add DW_OP_addrx
11744         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11745         (read_cutu_die_from_dwo): Update comment
11746         (skip_one_die): Add DW_FORM_addrx
11747         (read_attribute_value): Likewise
11748         (var_decode_location): Add DW_OP_addrx
11749         (dwarf2_const_value_attr): Add DW_FORM_addrx
11750         (dump_die_shallow): Likewise
11751         (dwarf2_fetch_constant_bytes): Likewise
11752         (decode_locdesc): Add DW_OP_addrx
11753         (skip_form_bytes): Add DW_FORM_addrx
11754
11755 2019-04-22  Ali Tamur  <tamur@google.com>
11756
11757         * MAINTAINERS (Write After Approval): Add self.
11758
11759 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11760
11761         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11762         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11763         (open_symbol_file_object): Likewise.
11764         (svr4_default_sos): Add info parameter.
11765         (svr4_read_so_list): Likewise.
11766         (svr4_current_sos_direct): Adjust functions calls to pass down
11767         info.
11768         (svr4_current_sos_1): Add info parameter.
11769         (svr4_current_sos): Call get_svr4_info, pass info down to
11770         svr4_current_sos_1.
11771         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11772         get_svr4_info.
11773         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11774         get_svr4_info.
11775         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11776         to get_svr4_info.
11777         (probes_table_remove_objfile_probes): Likewise.
11778         (register_solib_event_probe): Add info parameter.
11779         (solist_update_incremental): Pass info parameter down to
11780         svr4_read_so_list.
11781         (disable_probes_interface): Add info parameter.
11782         (svr4_handle_solib_event): Pass current_program_space to
11783         get_svr4_info.  Adjust disable_probes_interface cleanup.
11784         (svr4_create_probe_breakpoints): Add info parameter, pass it
11785         down to register_solib_event_probe.
11786         (svr4_create_solib_event_breakpoints): Add info parameter,
11787         pass it down to svr4_create_probe_breakpoints.
11788         (enable_break): Pass info down to
11789         svr4_create_solib_event_breakpoints.
11790         (svr4_solib_create_inferior_hook): Pass current_program_space to
11791         get_svr4_info.
11792         (svr4_clear_solib): Likewise.
11793
11794 2019-04-22  Pedro Alves  <palves@redhat.com>
11795
11796         * solib-svr4.c (svr4_free_objfile_observer): New.
11797         (probe_and_action::objfile): New field.
11798         (probes_table_htab_remove_objfile_probes)
11799         (probes_table_remove_objfile_probes): New functions.
11800         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11801         in the new probe_and_action.  Don't store the probe in 'lookup'.
11802         (svr4_create_probe_breakpoints): Pass objfile to
11803         register_solib_event_probe.
11804         (_initialize_svr4_solib): Register a free_objfile observer.
11805
11806 2019-04-19  Tom Tromey  <tom@tromey.com>
11807
11808         * common/queue.h: Remove.
11809
11810 2019-04-19  Tom Tromey  <tom@tromey.com>
11811
11812         * event-loop.c: Don't include "common/queue.h".
11813
11814 2019-04-19  Tom Tromey  <tom@tromey.com>
11815
11816         * remote.c (remote_target): Use delete.
11817         * remote-notif.h: Include <list>, not "common/queue.h".
11818         (notif_client_p): Remove typedef.
11819         (remote_notif_state): Add constructor, destructor, initializer.
11820         <notif_queue>: Now a std::list.
11821         (remote_notif_state_xfree): Don't declare.
11822         * remote-notif.c (remote_notif_process, handle_notification)
11823         (remote_notif_state_allocate): Update.
11824         (~remote_notif_state): Rename from remote_notif_state_xfree.
11825
11826 2019-04-19  Tom Tromey  <tom@tromey.com>
11827
11828         * symfile.c (reread_symbols): Update.
11829         * objfiles.c (objfile_register_static_link)
11830         (objfile_lookup_static_link): Update
11831         (~objfile) Don't delete static_links.
11832         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11833
11834 2019-04-19  Tom Tromey  <tom@tromey.com>
11835
11836         * type-stack.h (struct type_stack) <insert>: Constify string.
11837         * type-stack.c (type_stack::insert): Constify string.
11838         * gdbtypes.h (lookup_template_type): Update.
11839         (address_space_name_to_int): Update.
11840         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11841         const.
11842         (lookup_template_type): Make name const.
11843         * c-exp.y: Update rules.
11844         (lex_one_token, classify_name, classify_inner_name)
11845         (c_print_token): Update.
11846         * p-exp.y: Update rules.
11847         (yylex): Update.
11848         * f-exp.y: Update rules.
11849         (yylex): Update.
11850         * d-exp.y: Update rules.
11851         (lex_one_token, classify_name, classify_inner_name): Update.
11852         * parse.c (write_dollar_variable, copy_name): Return std::string.
11853         * parser-defs.h (copy_name): Change return type.
11854         * m2-exp.y: Update rules.
11855         (yylex): Update.
11856         * go-exp.y (lex_one_token): Update.
11857         Update rules.
11858         (classify_unsafe_function, classify_packaged_name)
11859         (classify_name, yylex): Update.
11860
11861 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11862
11863         * configure.ac: add --enable-source-highlight switch.
11864         * configure: Regenerate.
11865         * top.c (print_gdb_version): plumb --enable-source-highlight
11866         status to "show configuration".
11867
11868 2019-04-19  Tom Tromey  <tromey@adacore.com>
11869
11870         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11871         Check ADA_TYPE_P.
11872         (empty_record, ada_template_to_fixed_record_type_1)
11873         (template_to_static_fixed_type)
11874         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11875         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11876         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11877         macros.
11878
11879 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11880
11881         PR symtab/24423:
11882         * source.c (print_source_lines_base): Advance "iter" when a
11883         control character is seen.
11884
11885 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11886
11887         * inferior.h (struct infcall_suspend_state_deleter):
11888         Catch exception in destructor to avoid crash.
11889
11890 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11891
11892         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11893         close to the add_com "shell".
11894
11895 2019-04-18  Tom Tromey  <tromey@adacore.com>
11896
11897         * process-stratum-target.h (class process_stratum_target)
11898         <stratum>: Add "final".
11899
11900 2019-04-17  Tom Tromey  <tromey@adacore.com>
11901
11902         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11903         against nullptr before use.
11904
11905 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11906
11907         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11908
11909 2019-04-17  Jim Wilson  <jimw@sifive.com>
11910             Andrew Burgess  <andrew.burgess@embecosm.com>
11911
11912         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11913         code read might fail, assume 4-byte breakpoint in that case.
11914
11915 2019-04-15  Leszek Swirski  <leszeks@google.com>
11916
11917         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11918         rather than a hand-rolled POD check when checking for forced MEMORY
11919         classification.
11920
11921 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11922
11923         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11924         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11925         function.
11926         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11927         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11928         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11929         declaration.
11930
11931 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11932
11933         * aarch64-linux-nat.c
11934         (aarch64_linux_nat_target::thread_architecture): Add override.
11935         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11936         each VQ.
11937
11938 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11939
11940         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11941
11942 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11943
11944         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11945         target types of size 96-bits, add some additional comments, and
11946         check that the builtin type we found was the correct size.
11947
11948 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11949
11950         * utils.c (prompt_for_continue): Don't restore the styling at the
11951         end, as applied_style has the wrong value.  This fixes styling in
11952         long lists of file names that are interrupted by the "Continue?"
11953         prompt.
11954
11955 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11956
11957         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11958         * c-lang.c (c_language_defn): Likewise.
11959         (cplus_language_defn): Likewise.
11960         (asm_language_defn): Likewise.
11961         (minimal_language_defn): Likewise.
11962         * d-lang.c (d_language_defn): Likewise.
11963         * f-lang.c (f_language_defn): Likewise.
11964         * go-lang.c (go_language_defn): Likewise.
11965         * language.c (unknown_language_defn): Likewise.
11966         (auto_language_defn): Likewise.
11967         * language.h (struct language_defn): Remove la_magic field.
11968         (LANG_MAGIC): Delete.
11969         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11970         * objc-lang.c (objc_language_defn): Likewise.
11971         * opencl-lang.c (opencl_language_defn): Likewise.
11972         * p-lang.c (pascal_language_defn): Likewise.
11973         * rust-lang.c (rust_language_defn): Likewise.
11974
11975 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11976
11977         * riscv-tdep.c (riscv_type_align): New function.
11978         (riscv_type_alignment): Delete.
11979         (riscv_arg_location): Use 'type_align'.
11980         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11981
11982 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11983
11984         * gdbtypes.c (type_align): A struct with no non-static fields also
11985         has alignment of 1.
11986
11987 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11988
11989         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11990         component to 0.
11991         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11992         member.
11993         (riscv_struct_info::analyse): New implementation using new
11994         analyse_inner member function.
11995         (riscv_struct_info::field_offset): New member function.
11996         (riscv_struct_info::m_offsets): New member variable.
11997         (riscv_struct_info::analyse_inner): New private member function,
11998         takes the old implementation of riscv_struct_info::analyse but
11999         extended to track field offsets.
12000         (riscv_call_arg_struct): Update the struct folding special cases
12001         to handle cases where empty C++ structs, which are non-zero
12002         length, are found.
12003         (riscv_arg_location): Initialise the length of each location, a
12004         non-zero length now indicates the location is in use.
12005         (riscv_push_dummy_call): Allow for the first location having a
12006         non-zero offset when setting up arguments.
12007         (riscv_return_value): Likewise, but for return values.
12008
12009 2019-04-11  Tom Tromey  <tromey@adacore.com>
12010
12011         * utils.c (internal_vproblem): Make "msg" const.
12012
12013 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
12014
12015         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
12016         * trad-frame.c (trad_frame_reset_saved_regs): New function.
12017         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
12018         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
12019
12020 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
12021
12022         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
12023         function.
12024         (fill_gregset): Call amd64_linux_collect_native_gregset instead
12025         of amd64_collect_native_gregset.
12026         (amd64_linux_nat_target::store_registers): Likewise.
12027
12028 2019-04-10  Tom Tromey  <tom@tromey.com>
12029
12030         * symtab.c (lookup_global_symbol_from_objfile)
12031         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
12032         * objfiles.h (class separate_debug_iterator): New.
12033         (class separate_debug_range): New.
12034         (struct objfile) <separate_debug_objfiles>: New method.
12035         (objfile_separate_debug_iterate): Don't declare.
12036         * objfiles.c (separate_debug_iterator::operator++): Rename from
12037         objfile_separate_debug_iterate.
12038         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
12039         iterator.
12040         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
12041         iterator.
12042
12043 2019-04-10  Tom Tromey  <tom@tromey.com>
12044
12045         * symfile.c (reread_symbols): Remove old comment.
12046         * objfiles.c (free_all_objfiles): Fix a typo.
12047
12048 2019-04-10  Tom Tromey  <tom@tromey.com>
12049
12050         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
12051         * minsyms.c (lookup_minimal_symbol): Use foreach.
12052         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
12053         (lookup_minimal_symbol_solib_trampoline): Likewise.
12054         * symfile.c (reread_symbols): Use foreach.
12055
12056 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
12057             Tom Tromey  <tromey@adacore.com>
12058
12059         PR rust/24414:
12060         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
12061         (rust_lex_int_test): Change "value" to be LONGEST.
12062         (rust_lex_tests): Add test for long integer literal.
12063
12064 2019-04-09  Tom Tromey  <tromey@adacore.com>
12065
12066         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
12067         to bool.
12068         (extended_remote_target::attach): Update.
12069         (remote_target::remote_notice_new_inferior): Update.
12070         (remote_target::add_current_inferior_and_thread): Update.
12071         * inferior.c (exit_inferior_1): Use "false".
12072         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
12073
12074 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
12075
12076         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
12077         the "start" command.
12078
12079 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12080
12081         * python/py-inferior.c (infpy_thread_from_thread_handle):
12082         Adjust comments to reflect renaming of thread_from_thread_handle
12083         to thread_from_handle.  Adjust keywords.  Fix type error message.
12084         (inferior_object_methods): Add thread_from_handle.  Retain
12085         thread_from_thread_handle, but mark it as deprecated.
12086
12087 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12088
12089         * gdbthread.h (find_thread_by_handle): Revise declaration.
12090         * thread.c (find_thread_by_handle): Likewise.  Adjust
12091         implementation too.
12092         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12093         support for buffer objects as handles.
12094
12095 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12096
12097         * python/py-infthread.c (thpy_thread_handle): New function.
12098         (thread_object_methods): Register thpy_thread_handle.
12099
12100 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12101
12102         * gdbthread.h (thread_to_thread_handle): Declare.
12103         * thread.c (gdbtypes.h): Include.
12104         (thread_to_thread_handle): New function.
12105
12106         * target.h (struct target_ops): Add thread_info_to_thread_handle.
12107         (target_thread_info_to_thread_handle): Declare.
12108         * target.c (target_thread_info_to_thread_handle): New function.
12109         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12110         * target-delegates.c: Regenerate.
12111
12112         * linux-thread-db.c (class thread_db_target): Add method
12113         thread_info_to_thread_handle.
12114         (thread_db_target::thread_info_to_thread_handle): Define.
12115         * remote.c (class remote_target): Add new method
12116         thread_info_to_thread_handle.
12117         (remote_target::thread_info_to_thread_handle): Define.
12118
12119 2019-04-08  Pedro Alves  <palves@redhat.com>
12120
12121         * common/common-exceptions.c (throw_exception): Don't create
12122         named object to throw; throw directly.
12123         (throw_it): Likewise.  Don't initialize gdb_exception::message
12124         here, with new; pass FMT and AP to the ctor instead.
12125         * common/common-exceptions.h: Include <string>.
12126         (gdb_exception::gdb_exception(enum return_reason, enum errors,
12127         const char *, va_list)): New ctor.  Use std::make_shared.
12128         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12129         errors)): Delete.
12130         (gdb_exception_error::gdb_exception_error(enum errors, const char
12131         *, va_list)): New.
12132         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12133         Add assertion.
12134         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12135         errors)): Delete.
12136         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12137         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12138         Add assertion.
12139
12140 2019-04-08  Tom Tromey  <tom@tromey.com>
12141
12142         * valops.c (value_rtti_indirect_type): Replace throw_exception
12143         with throw.
12144         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12145         with throw.
12146         * thread.c (thr_try_catch_cmd): Replace throw_exception with
12147         throw.
12148         * target.c (target_translate_tls_address): Replace throw_exception
12149         with throw.
12150         * stack.c (frame_apply_command_count): Replace throw_exception
12151         with throw.
12152         * solib-spu.c (append_ocl_sos): Replace throw_exception with
12153         throw.
12154         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12155         with throw.
12156         * rs6000-tdep.c (rs6000_frame_cache)
12157         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12158         * remote.c: Replace throw_exception with throw.
12159         * record-full.c (record_full_message, record_full_wait_1)
12160         (record_full_restore): Replace throw_exception with throw.
12161         * record-btrace.c:
12162         (get_thread_current_frame_id, record_btrace_start_replaying)
12163         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12164         (cmd_record_btrace_start): Replace throw_exception with throw.
12165         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12166         throw.
12167         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12168         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12169         * linespec.c:
12170         (find_linespec_symbols): Replace throw_exception with throw.
12171         * infrun.c (displaced_step_prepare, resume): Replace
12172         throw_exception with throw.
12173         * infcmd.c (post_create_inferior): Replace throw_exception with
12174         throw.
12175         * inf-loop.c (inferior_event_handler): Replace throw_exception
12176         with throw.
12177         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12178         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12179         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12180         (get_prev_frame_always, get_frame_pc_if_available)
12181         (get_frame_address_in_block_if_available, get_frame_language):
12182         Replace throw_exception with throw.
12183         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12184         throw_exception with throw.
12185         * eval.c (fetch_subexp_value, evaluate_var_value)
12186         (evaluate_funcall, evaluate_subexp_standard): Replace
12187         throw_exception with throw.
12188         * dwarf2loc.c (call_site_find_chain)
12189         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12190         Replace throw_exception with throw.
12191         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12192         with throw.
12193         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12194         throw.
12195         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12196         * completer.c (complete_line_internal): Replace throw_exception
12197         with throw.
12198         * compile/compile-object-run.c (compile_object_run): Replace
12199         throw_exception with throw.
12200         * cli/cli-script.c (process_next_line): Replace throw_exception
12201         with throw.
12202         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12203         (btrace_enable, btrace_maint_update_pt_packets): Replace
12204         throw_exception with throw.
12205         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12206         throw_exception with throw.
12207         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12208         throw_exception with throw.
12209         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12210         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12211         * aarch64-tdep.c (aarch64_make_prologue_cache)
12212         (aarch64_make_stub_cache): Replace throw_exception with throw.
12213
12214 2019-04-08  Tom Tromey  <tom@tromey.com>
12215
12216         * common/common-exceptions.c (throw_exception): Rename from
12217         throw_exception_cxx.  Remove old copy.  Make argument const.
12218         (throw_it): Create and throw exception objects directly.
12219         * common/common-exceptions.h (throw_exception): Make argument
12220         const.
12221         (struct gdb_exception_error): Add constructor.
12222         (struct gdb_exception_quit): Add constructor.
12223
12224 2019-04-08  Tom Tromey  <tom@tromey.com>
12225
12226         * common/common-exceptions.h (exception_rethrow): Don't declare.
12227         (TRY_SJLJ): Update comment.
12228         (TRY, CATCH, END_CATCH): Remove.
12229         * common/common-exceptions.c (exception_rethrow): Remove.
12230
12231 2019-04-08  Tom Tromey  <tom@tromey.com>
12232
12233         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12234         Remove.
12235         (gdb_exception_error): Rename from
12236         gdb_exception_RETURN_MASK_ERROR.
12237         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12238         (gdb_quit_bad_alloc): Update.
12239         * aarch64-tdep.c: Update.
12240         * ada-lang.c: Update.
12241         * ada-typeprint.c: Update.
12242         * ada-valprint.c: Update.
12243         * amd64-tdep.c: Update.
12244         * arch-utils.c: Update.
12245         * break-catch-throw.c: Update.
12246         * breakpoint.c: Update.
12247         * btrace.c: Update.
12248         * c-varobj.c: Update.
12249         * cli/cli-cmds.c: Update.
12250         * cli/cli-interp.c: Update.
12251         * cli/cli-script.c: Update.
12252         * common/common-exceptions.c: Update.
12253         * common/new-op.c: Update.
12254         * common/selftest.c: Update.
12255         * compile/compile-c-symbols.c: Update.
12256         * compile/compile-cplus-symbols.c: Update.
12257         * compile/compile-object-load.c: Update.
12258         * compile/compile-object-run.c: Update.
12259         * completer.c: Update.
12260         * corelow.c: Update.
12261         * cp-abi.c: Update.
12262         * cp-support.c: Update.
12263         * cp-valprint.c: Update.
12264         * darwin-nat.c: Update.
12265         * disasm-selftests.c: Update.
12266         * dtrace-probe.c: Update.
12267         * dwarf-index-cache.c: Update.
12268         * dwarf-index-write.c: Update.
12269         * dwarf2-frame-tailcall.c: Update.
12270         * dwarf2-frame.c: Update.
12271         * dwarf2loc.c: Update.
12272         * dwarf2read.c: Update.
12273         * eval.c: Update.
12274         * event-loop.c: Update.
12275         * event-top.c: Update.
12276         * exec.c: Update.
12277         * f-valprint.c: Update.
12278         * fbsd-tdep.c: Update.
12279         * frame-unwind.c: Update.
12280         * frame.c: Update.
12281         * gdbtypes.c: Update.
12282         * gnu-v3-abi.c: Update.
12283         * guile/guile-internal.h: Update.
12284         * guile/scm-block.c: Update.
12285         * guile/scm-breakpoint.c: Update.
12286         * guile/scm-cmd.c: Update.
12287         * guile/scm-disasm.c: Update.
12288         * guile/scm-frame.c: Update.
12289         * guile/scm-lazy-string.c: Update.
12290         * guile/scm-math.c: Update.
12291         * guile/scm-param.c: Update.
12292         * guile/scm-ports.c: Update.
12293         * guile/scm-pretty-print.c: Update.
12294         * guile/scm-symbol.c: Update.
12295         * guile/scm-symtab.c: Update.
12296         * guile/scm-type.c: Update.
12297         * guile/scm-value.c: Update.
12298         * i386-linux-tdep.c: Update.
12299         * i386-tdep.c: Update.
12300         * inf-loop.c: Update.
12301         * infcall.c: Update.
12302         * infcmd.c: Update.
12303         * infrun.c: Update.
12304         * jit.c: Update.
12305         * language.c: Update.
12306         * linespec.c: Update.
12307         * linux-fork.c: Update.
12308         * linux-nat.c: Update.
12309         * linux-tdep.c: Update.
12310         * linux-thread-db.c: Update.
12311         * main.c: Update.
12312         * mi/mi-cmd-break.c: Update.
12313         * mi/mi-cmd-stack.c: Update.
12314         * mi/mi-interp.c: Update.
12315         * mi/mi-main.c: Update.
12316         * objc-lang.c: Update.
12317         * p-valprint.c: Update.
12318         * parse.c: Update.
12319         * ppc-linux-tdep.c: Update.
12320         * printcmd.c: Update.
12321         * python/py-arch.c: Update.
12322         * python/py-breakpoint.c: Update.
12323         * python/py-cmd.c: Update.
12324         * python/py-finishbreakpoint.c: Update.
12325         * python/py-frame.c: Update.
12326         * python/py-framefilter.c: Update.
12327         * python/py-gdb-readline.c: Update.
12328         * python/py-inferior.c: Update.
12329         * python/py-infthread.c: Update.
12330         * python/py-lazy-string.c: Update.
12331         * python/py-linetable.c: Update.
12332         * python/py-objfile.c: Update.
12333         * python/py-param.c: Update.
12334         * python/py-prettyprint.c: Update.
12335         * python/py-progspace.c: Update.
12336         * python/py-record-btrace.c: Update.
12337         * python/py-record.c: Update.
12338         * python/py-symbol.c: Update.
12339         * python/py-type.c: Update.
12340         * python/py-unwind.c: Update.
12341         * python/py-utils.c: Update.
12342         * python/py-value.c: Update.
12343         * python/python.c: Update.
12344         * record-btrace.c: Update.
12345         * record-full.c: Update.
12346         * remote-fileio.c: Update.
12347         * remote.c: Update.
12348         * riscv-tdep.c: Update.
12349         * rs6000-aix-tdep.c: Update.
12350         * rs6000-tdep.c: Update.
12351         * rust-exp.y: Update.
12352         * rust-lang.c: Update.
12353         * s390-tdep.c: Update.
12354         * selftest-arch.c: Update.
12355         * solib-dsbt.c: Update.
12356         * solib-frv.c: Update.
12357         * solib-spu.c: Update.
12358         * solib-svr4.c: Update.
12359         * solib.c: Update.
12360         * sparc64-linux-tdep.c: Update.
12361         * stack.c: Update.
12362         * symfile-mem.c: Update.
12363         * symmisc.c: Update.
12364         * target.c: Update.
12365         * thread.c: Update.
12366         * top.c: Update.
12367         * tracefile-tfile.c: Update.
12368         * tui/tui.c: Update.
12369         * typeprint.c: Update.
12370         * unittests/cli-utils-selftests.c: Update.
12371         * unittests/parse-connection-spec-selftests.c: Update.
12372         * valops.c: Update.
12373         * valprint.c: Update.
12374         * value.c: Update.
12375         * varobj.c: Update.
12376         * windows-nat.c: Update.
12377         * x86-linux-nat.c: Update.
12378         * xml-support.c: Update.
12379
12380 2019-04-08  Tom Tromey  <tom@tromey.com>
12381
12382         * xml-support.c: Use C++ exception handling.
12383         * x86-linux-nat.c: Use C++ exception handling.
12384         * windows-nat.c: Use C++ exception handling.
12385         * varobj.c: Use C++ exception handling.
12386         * value.c: Use C++ exception handling.
12387         * valprint.c: Use C++ exception handling.
12388         * valops.c: Use C++ exception handling.
12389         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12390         handling.
12391         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12392         * typeprint.c: Use C++ exception handling.
12393         * tui/tui.c: Use C++ exception handling.
12394         * tracefile-tfile.c: Use C++ exception handling.
12395         * top.c: Use C++ exception handling.
12396         * thread.c: Use C++ exception handling.
12397         * target.c: Use C++ exception handling.
12398         * symmisc.c: Use C++ exception handling.
12399         * symfile-mem.c: Use C++ exception handling.
12400         * stack.c: Use C++ exception handling.
12401         * sparc64-linux-tdep.c: Use C++ exception handling.
12402         * solib.c: Use C++ exception handling.
12403         * solib-svr4.c: Use C++ exception handling.
12404         * solib-spu.c: Use C++ exception handling.
12405         * solib-frv.c: Use C++ exception handling.
12406         * solib-dsbt.c: Use C++ exception handling.
12407         * selftest-arch.c: Use C++ exception handling.
12408         * s390-tdep.c: Use C++ exception handling.
12409         * rust-lang.c: Use C++ exception handling.
12410         * rust-exp.y: Use C++ exception handling.
12411         * rs6000-tdep.c: Use C++ exception handling.
12412         * rs6000-aix-tdep.c: Use C++ exception handling.
12413         * riscv-tdep.c: Use C++ exception handling.
12414         * remote.c: Use C++ exception handling.
12415         * remote-fileio.c: Use C++ exception handling.
12416         * record-full.c: Use C++ exception handling.
12417         * record-btrace.c: Use C++ exception handling.
12418         * python/python.c: Use C++ exception handling.
12419         * python/py-value.c: Use C++ exception handling.
12420         * python/py-utils.c: Use C++ exception handling.
12421         * python/py-unwind.c: Use C++ exception handling.
12422         * python/py-type.c: Use C++ exception handling.
12423         * python/py-symbol.c: Use C++ exception handling.
12424         * python/py-record.c: Use C++ exception handling.
12425         * python/py-record-btrace.c: Use C++ exception handling.
12426         * python/py-progspace.c: Use C++ exception handling.
12427         * python/py-prettyprint.c: Use C++ exception handling.
12428         * python/py-param.c: Use C++ exception handling.
12429         * python/py-objfile.c: Use C++ exception handling.
12430         * python/py-linetable.c: Use C++ exception handling.
12431         * python/py-lazy-string.c: Use C++ exception handling.
12432         * python/py-infthread.c: Use C++ exception handling.
12433         * python/py-inferior.c: Use C++ exception handling.
12434         * python/py-gdb-readline.c: Use C++ exception handling.
12435         * python/py-framefilter.c: Use C++ exception handling.
12436         * python/py-frame.c: Use C++ exception handling.
12437         * python/py-finishbreakpoint.c: Use C++ exception handling.
12438         * python/py-cmd.c: Use C++ exception handling.
12439         * python/py-breakpoint.c: Use C++ exception handling.
12440         * python/py-arch.c: Use C++ exception handling.
12441         * printcmd.c: Use C++ exception handling.
12442         * ppc-linux-tdep.c: Use C++ exception handling.
12443         * parse.c: Use C++ exception handling.
12444         * p-valprint.c: Use C++ exception handling.
12445         * objc-lang.c: Use C++ exception handling.
12446         * mi/mi-main.c: Use C++ exception handling.
12447         * mi/mi-interp.c: Use C++ exception handling.
12448         * mi/mi-cmd-stack.c: Use C++ exception handling.
12449         * mi/mi-cmd-break.c: Use C++ exception handling.
12450         * main.c: Use C++ exception handling.
12451         * linux-thread-db.c: Use C++ exception handling.
12452         * linux-tdep.c: Use C++ exception handling.
12453         * linux-nat.c: Use C++ exception handling.
12454         * linux-fork.c: Use C++ exception handling.
12455         * linespec.c: Use C++ exception handling.
12456         * language.c: Use C++ exception handling.
12457         * jit.c: Use C++ exception handling.
12458         * infrun.c: Use C++ exception handling.
12459         * infcmd.c: Use C++ exception handling.
12460         * infcall.c: Use C++ exception handling.
12461         * inf-loop.c: Use C++ exception handling.
12462         * i386-tdep.c: Use C++ exception handling.
12463         * i386-linux-tdep.c: Use C++ exception handling.
12464         * guile/scm-value.c: Use C++ exception handling.
12465         * guile/scm-type.c: Use C++ exception handling.
12466         * guile/scm-symtab.c: Use C++ exception handling.
12467         * guile/scm-symbol.c: Use C++ exception handling.
12468         * guile/scm-pretty-print.c: Use C++ exception handling.
12469         * guile/scm-ports.c: Use C++ exception handling.
12470         * guile/scm-param.c: Use C++ exception handling.
12471         * guile/scm-math.c: Use C++ exception handling.
12472         * guile/scm-lazy-string.c: Use C++ exception handling.
12473         * guile/scm-frame.c: Use C++ exception handling.
12474         * guile/scm-disasm.c: Use C++ exception handling.
12475         * guile/scm-cmd.c: Use C++ exception handling.
12476         * guile/scm-breakpoint.c: Use C++ exception handling.
12477         * guile/scm-block.c: Use C++ exception handling.
12478         * guile/guile-internal.h: Use C++ exception handling.
12479         * gnu-v3-abi.c: Use C++ exception handling.
12480         * gdbtypes.c: Use C++ exception handling.
12481         * frame.c: Use C++ exception handling.
12482         * frame-unwind.c: Use C++ exception handling.
12483         * fbsd-tdep.c: Use C++ exception handling.
12484         * f-valprint.c: Use C++ exception handling.
12485         * exec.c: Use C++ exception handling.
12486         * event-top.c: Use C++ exception handling.
12487         * event-loop.c: Use C++ exception handling.
12488         * eval.c: Use C++ exception handling.
12489         * dwarf2read.c: Use C++ exception handling.
12490         * dwarf2loc.c: Use C++ exception handling.
12491         * dwarf2-frame.c: Use C++ exception handling.
12492         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12493         * dwarf-index-write.c: Use C++ exception handling.
12494         * dwarf-index-cache.c: Use C++ exception handling.
12495         * dtrace-probe.c: Use C++ exception handling.
12496         * disasm-selftests.c: Use C++ exception handling.
12497         * darwin-nat.c: Use C++ exception handling.
12498         * cp-valprint.c: Use C++ exception handling.
12499         * cp-support.c: Use C++ exception handling.
12500         * cp-abi.c: Use C++ exception handling.
12501         * corelow.c: Use C++ exception handling.
12502         * completer.c: Use C++ exception handling.
12503         * compile/compile-object-run.c: Use C++ exception handling.
12504         * compile/compile-object-load.c: Use C++ exception handling.
12505         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12506         * compile/compile-c-symbols.c: Use C++ exception handling.
12507         * common/selftest.c: Use C++ exception handling.
12508         * common/new-op.c: Use C++ exception handling.
12509         * cli/cli-script.c: Use C++ exception handling.
12510         * cli/cli-interp.c: Use C++ exception handling.
12511         * cli/cli-cmds.c: Use C++ exception handling.
12512         * c-varobj.c: Use C++ exception handling.
12513         * btrace.c: Use C++ exception handling.
12514         * breakpoint.c: Use C++ exception handling.
12515         * break-catch-throw.c: Use C++ exception handling.
12516         * arch-utils.c: Use C++ exception handling.
12517         * amd64-tdep.c: Use C++ exception handling.
12518         * ada-valprint.c: Use C++ exception handling.
12519         * ada-typeprint.c: Use C++ exception handling.
12520         * ada-lang.c: Use C++ exception handling.
12521         * aarch64-tdep.c: Use C++ exception handling.
12522
12523 2019-04-08  Tom Tromey  <tom@tromey.com>
12524
12525         * xml-support.c (gdb_xml_parser::parse): Update.
12526         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12527         * value.c (show_convenience): Update.
12528         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12529         (test_parse_flags_qcs): Update.
12530         * thread.c (thr_try_catch_cmd): Update.
12531         * target.c (target_translate_tls_address): Update.
12532         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12533         (info_frame_command_core, frame_apply_command_count): Update.
12534         * rust-exp.y (rust_lex_exception_test): Update.
12535         * riscv-tdep.c (riscv_print_one_register_info): Update.
12536         * remote.c (remote_target::enable_btrace): Update.
12537         * record-btrace.c (record_btrace_enable_warn): Update.
12538         * python/py-utils.c (gdbpy_convert_exception): Update.
12539         * printcmd.c (do_one_display, print_variable_and_value): Update.
12540         * mi/mi-main.c (mi_print_exception): Update.
12541         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12542         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12543         * linux-nat.c (linux_nat_target::attach): Update.
12544         * linux-fork.c (class scoped_switch_fork_info): Update.
12545         * infrun.c (displaced_step_prepare): Update.
12546         * infcall.c (call_function_by_hand_dummy): Update.
12547         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12548         * gnu-v3-abi.c (print_one_vtable): Update.
12549         * frame.c (get_prev_frame_always): Update.
12550         * f-valprint.c (info_common_command_for_block): Update.
12551         * exec.c (try_open_exec_file): Update.
12552         * exceptions.c (print_exception, exception_print)
12553         (exception_fprintf, exception_print_same): Update.
12554         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12555         * dwarf-index-cache.c (index_cache::store)
12556         (index_cache::lookup_gdb_index): Update.
12557         * darwin-nat.c (maybe_cache_shell): Update.
12558         * cp-valprint.c (cp_print_value_fields): Update.
12559         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12560         (gcc_cplus_symbol_address): Update.
12561         * compile/compile-c-symbols.c (gcc_convert_symbol)
12562         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12563         * common/selftest.c: Update.
12564         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12565         a std::string.
12566         (exception_try_scope_entry, exception_try_scope_exit): Don't
12567         declare.
12568         (struct exception_try_scope): Remove.
12569         (TRY): Don't use exception_try_scope.
12570         (struct gdb_exception): Add constructor, operator=.
12571         <what>: New method.
12572         (struct gdb_exception_RETURN_MASK_ALL)
12573         (struct gdb_exception_RETURN_MASK_ERROR)
12574         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12575         (struct gdb_quit_bad_alloc): Update.
12576         * common/common-exceptions.c (exception_none): Change
12577         initializer.
12578         (struct catcher) <state, exception>: Initialize inline.
12579         <prev>: Remove member.
12580         (current_catcher): Remove.
12581         (catchers): New global.
12582         (exceptions_state_mc_init): Simplify.
12583         (catcher_pop): Remove.
12584         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12585         (try_scope_depth, exception_try_scope_entry)
12586         (exception_try_scope_exit): Remove.
12587         (throw_exception_sjlj): Update.
12588         (exception_messages, exception_messages_size): Remove.
12589         (throw_it): Simplify.
12590         (gdb_exception_sliced_copy): Remove.
12591         (throw_exception_cxx): Update.
12592         * cli/cli-script.c (script_from_file): Update.
12593         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12594         Update.
12595         * ada-valprint.c (ada_val_print): Update.
12596         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12597         (create_excep_cond_exprs): Update.
12598
12599 2019-04-08  Tom Tromey  <tom@tromey.com>
12600
12601         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12602         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12603         (TRY, CATCH, END_CATCH): Remove some definitions.
12604         * common/common-exceptions.c: Don't use GDB_XCPT.
12605         (catcher_list_size): Remove.
12606         (throw_exception, throw_it): Simplify.
12607
12608 2019-04-05  Tom Tromey  <tom@tromey.com>
12609
12610         Revert the header-sorting patch.
12611         * ft32-tdep.c: Revert.
12612         * frv-tdep.c: Revert.
12613         * frv-linux-tdep.c: Revert.
12614         * frame.c: Revert.
12615         * frame-unwind.c: Revert.
12616         * frame-base.c: Revert.
12617         * fork-child.c: Revert.
12618         * findvar.c: Revert.
12619         * findcmd.c: Revert.
12620         * filesystem.c: Revert.
12621         * filename-seen-cache.h: Revert.
12622         * filename-seen-cache.c: Revert.
12623         * fbsd-tdep.c: Revert.
12624         * fbsd-nat.h: Revert.
12625         * fbsd-nat.c: Revert.
12626         * f-valprint.c: Revert.
12627         * f-typeprint.c: Revert.
12628         * f-lang.c: Revert.
12629         * extension.h: Revert.
12630         * extension.c: Revert.
12631         * extension-priv.h: Revert.
12632         * expprint.c: Revert.
12633         * exec.h: Revert.
12634         * exec.c: Revert.
12635         * exceptions.c: Revert.
12636         * event-top.c: Revert.
12637         * event-loop.c: Revert.
12638         * eval.c: Revert.
12639         * elfread.c: Revert.
12640         * dwarf2read.h: Revert.
12641         * dwarf2read.c: Revert.
12642         * dwarf2loc.c: Revert.
12643         * dwarf2expr.h: Revert.
12644         * dwarf2expr.c: Revert.
12645         * dwarf2-frame.c: Revert.
12646         * dwarf2-frame-tailcall.c: Revert.
12647         * dwarf-index-write.h: Revert.
12648         * dwarf-index-write.c: Revert.
12649         * dwarf-index-common.c: Revert.
12650         * dwarf-index-cache.h: Revert.
12651         * dwarf-index-cache.c: Revert.
12652         * dummy-frame.c: Revert.
12653         * dtrace-probe.c: Revert.
12654         * disasm.h: Revert.
12655         * disasm.c: Revert.
12656         * disasm-selftests.c: Revert.
12657         * dictionary.c: Revert.
12658         * dicos-tdep.c: Revert.
12659         * demangle.c: Revert.
12660         * dcache.h: Revert.
12661         * dcache.c: Revert.
12662         * darwin-nat.h: Revert.
12663         * darwin-nat.c: Revert.
12664         * darwin-nat-info.c: Revert.
12665         * d-valprint.c: Revert.
12666         * d-namespace.c: Revert.
12667         * d-lang.c: Revert.
12668         * ctf.c: Revert.
12669         * csky-tdep.c: Revert.
12670         * csky-linux-tdep.c: Revert.
12671         * cris-tdep.c: Revert.
12672         * cris-linux-tdep.c: Revert.
12673         * cp-valprint.c: Revert.
12674         * cp-support.c: Revert.
12675         * cp-namespace.c: Revert.
12676         * cp-abi.c: Revert.
12677         * corelow.c: Revert.
12678         * corefile.c: Revert.
12679         * continuations.c: Revert.
12680         * completer.h: Revert.
12681         * completer.c: Revert.
12682         * complaints.c: Revert.
12683         * coffread.c: Revert.
12684         * coff-pe-read.c: Revert.
12685         * cli-out.h: Revert.
12686         * cli-out.c: Revert.
12687         * charset.c: Revert.
12688         * c-varobj.c: Revert.
12689         * c-valprint.c: Revert.
12690         * c-typeprint.c: Revert.
12691         * c-lang.c: Revert.
12692         * buildsym.c: Revert.
12693         * buildsym-legacy.c: Revert.
12694         * build-id.h: Revert.
12695         * build-id.c: Revert.
12696         * btrace.c: Revert.
12697         * bsd-uthread.c: Revert.
12698         * breakpoint.h: Revert.
12699         * breakpoint.c: Revert.
12700         * break-catch-throw.c: Revert.
12701         * break-catch-syscall.c: Revert.
12702         * break-catch-sig.c: Revert.
12703         * blockframe.c: Revert.
12704         * block.c: Revert.
12705         * bfin-tdep.c: Revert.
12706         * bfin-linux-tdep.c: Revert.
12707         * bfd-target.c: Revert.
12708         * bcache.c: Revert.
12709         * ax-general.c: Revert.
12710         * ax-gdb.h: Revert.
12711         * ax-gdb.c: Revert.
12712         * avr-tdep.c: Revert.
12713         * auxv.c: Revert.
12714         * auto-load.c: Revert.
12715         * arm-wince-tdep.c: Revert.
12716         * arm-tdep.c: Revert.
12717         * arm-symbian-tdep.c: Revert.
12718         * arm-pikeos-tdep.c: Revert.
12719         * arm-obsd-tdep.c: Revert.
12720         * arm-nbsd-tdep.c: Revert.
12721         * arm-nbsd-nat.c: Revert.
12722         * arm-linux-tdep.c: Revert.
12723         * arm-linux-nat.c: Revert.
12724         * arm-fbsd-tdep.c: Revert.
12725         * arm-fbsd-nat.c: Revert.
12726         * arm-bsd-tdep.c: Revert.
12727         * arch-utils.c: Revert.
12728         * arc-tdep.c: Revert.
12729         * arc-newlib-tdep.c: Revert.
12730         * annotate.h: Revert.
12731         * annotate.c: Revert.
12732         * amd64-windows-tdep.c: Revert.
12733         * amd64-windows-nat.c: Revert.
12734         * amd64-tdep.c: Revert.
12735         * amd64-sol2-tdep.c: Revert.
12736         * amd64-obsd-tdep.c: Revert.
12737         * amd64-obsd-nat.c: Revert.
12738         * amd64-nbsd-tdep.c: Revert.
12739         * amd64-nbsd-nat.c: Revert.
12740         * amd64-nat.c: Revert.
12741         * amd64-linux-tdep.c: Revert.
12742         * amd64-linux-nat.c: Revert.
12743         * amd64-fbsd-tdep.c: Revert.
12744         * amd64-fbsd-nat.c: Revert.
12745         * amd64-dicos-tdep.c: Revert.
12746         * amd64-darwin-tdep.c: Revert.
12747         * amd64-bsd-nat.c: Revert.
12748         * alpha-tdep.c: Revert.
12749         * alpha-obsd-tdep.c: Revert.
12750         * alpha-nbsd-tdep.c: Revert.
12751         * alpha-mdebug-tdep.c: Revert.
12752         * alpha-linux-tdep.c: Revert.
12753         * alpha-linux-nat.c: Revert.
12754         * alpha-bsd-tdep.c: Revert.
12755         * alpha-bsd-nat.c: Revert.
12756         * aix-thread.c: Revert.
12757         * agent.c: Revert.
12758         * addrmap.c: Revert.
12759         * ada-varobj.c: Revert.
12760         * ada-valprint.c: Revert.
12761         * ada-typeprint.c: Revert.
12762         * ada-tasks.c: Revert.
12763         * ada-lang.c: Revert.
12764         * aarch64-tdep.c: Revert.
12765         * aarch64-ravenscar-thread.c: Revert.
12766         * aarch64-newlib-tdep.c: Revert.
12767         * aarch64-linux-tdep.c: Revert.
12768         * aarch64-linux-nat.c: Revert.
12769         * aarch64-fbsd-tdep.c: Revert.
12770         * aarch64-fbsd-nat.c: Revert.
12771         * aarch32-linux-nat.c: Revert.
12772
12773 2019-04-05  Tom Tromey  <tom@tromey.com>
12774
12775         * ft32-tdep.c: Sort headers.
12776         * frv-tdep.c: Sort headers.
12777         * frv-linux-tdep.c: Sort headers.
12778         * frame.c: Sort headers.
12779         * frame-unwind.c: Sort headers.
12780         * frame-base.c: Sort headers.
12781         * fork-child.c: Sort headers.
12782         * findvar.c: Sort headers.
12783         * findcmd.c: Sort headers.
12784         * filesystem.c: Sort headers.
12785         * filename-seen-cache.h: Sort headers.
12786         * filename-seen-cache.c: Sort headers.
12787         * fbsd-tdep.c: Sort headers.
12788         * fbsd-nat.h: Sort headers.
12789         * fbsd-nat.c: Sort headers.
12790         * f-valprint.c: Sort headers.
12791         * f-typeprint.c: Sort headers.
12792         * f-lang.c: Sort headers.
12793         * extension.h: Sort headers.
12794         * extension.c: Sort headers.
12795         * extension-priv.h: Sort headers.
12796         * expprint.c: Sort headers.
12797         * exec.h: Sort headers.
12798         * exec.c: Sort headers.
12799         * exceptions.c: Sort headers.
12800         * event-top.c: Sort headers.
12801         * event-loop.c: Sort headers.
12802         * eval.c: Sort headers.
12803         * elfread.c: Sort headers.
12804         * dwarf2read.h: Sort headers.
12805         * dwarf2read.c: Sort headers.
12806         * dwarf2loc.c: Sort headers.
12807         * dwarf2expr.h: Sort headers.
12808         * dwarf2expr.c: Sort headers.
12809         * dwarf2-frame.c: Sort headers.
12810         * dwarf2-frame-tailcall.c: Sort headers.
12811         * dwarf-index-write.h: Sort headers.
12812         * dwarf-index-write.c: Sort headers.
12813         * dwarf-index-common.c: Sort headers.
12814         * dwarf-index-cache.h: Sort headers.
12815         * dwarf-index-cache.c: Sort headers.
12816         * dummy-frame.c: Sort headers.
12817         * dtrace-probe.c: Sort headers.
12818         * disasm.h: Sort headers.
12819         * disasm.c: Sort headers.
12820         * disasm-selftests.c: Sort headers.
12821         * dictionary.c: Sort headers.
12822         * dicos-tdep.c: Sort headers.
12823         * demangle.c: Sort headers.
12824         * dcache.h: Sort headers.
12825         * dcache.c: Sort headers.
12826         * darwin-nat.h: Sort headers.
12827         * darwin-nat.c: Sort headers.
12828         * darwin-nat-info.c: Sort headers.
12829         * d-valprint.c: Sort headers.
12830         * d-namespace.c: Sort headers.
12831         * d-lang.c: Sort headers.
12832         * ctf.c: Sort headers.
12833         * csky-tdep.c: Sort headers.
12834         * csky-linux-tdep.c: Sort headers.
12835         * cris-tdep.c: Sort headers.
12836         * cris-linux-tdep.c: Sort headers.
12837         * cp-valprint.c: Sort headers.
12838         * cp-support.c: Sort headers.
12839         * cp-namespace.c: Sort headers.
12840         * cp-abi.c: Sort headers.
12841         * corelow.c: Sort headers.
12842         * corefile.c: Sort headers.
12843         * continuations.c: Sort headers.
12844         * completer.h: Sort headers.
12845         * completer.c: Sort headers.
12846         * complaints.c: Sort headers.
12847         * coffread.c: Sort headers.
12848         * coff-pe-read.c: Sort headers.
12849         * cli-out.h: Sort headers.
12850         * cli-out.c: Sort headers.
12851         * charset.c: Sort headers.
12852         * c-varobj.c: Sort headers.
12853         * c-valprint.c: Sort headers.
12854         * c-typeprint.c: Sort headers.
12855         * c-lang.c: Sort headers.
12856         * buildsym.c: Sort headers.
12857         * buildsym-legacy.c: Sort headers.
12858         * build-id.h: Sort headers.
12859         * build-id.c: Sort headers.
12860         * btrace.c: Sort headers.
12861         * bsd-uthread.c: Sort headers.
12862         * breakpoint.h: Sort headers.
12863         * breakpoint.c: Sort headers.
12864         * break-catch-throw.c: Sort headers.
12865         * break-catch-syscall.c: Sort headers.
12866         * break-catch-sig.c: Sort headers.
12867         * blockframe.c: Sort headers.
12868         * block.c: Sort headers.
12869         * bfin-tdep.c: Sort headers.
12870         * bfin-linux-tdep.c: Sort headers.
12871         * bfd-target.c: Sort headers.
12872         * bcache.c: Sort headers.
12873         * ax-general.c: Sort headers.
12874         * ax-gdb.h: Sort headers.
12875         * ax-gdb.c: Sort headers.
12876         * avr-tdep.c: Sort headers.
12877         * auxv.c: Sort headers.
12878         * auto-load.c: Sort headers.
12879         * arm-wince-tdep.c: Sort headers.
12880         * arm-tdep.c: Sort headers.
12881         * arm-symbian-tdep.c: Sort headers.
12882         * arm-pikeos-tdep.c: Sort headers.
12883         * arm-obsd-tdep.c: Sort headers.
12884         * arm-nbsd-tdep.c: Sort headers.
12885         * arm-nbsd-nat.c: Sort headers.
12886         * arm-linux-tdep.c: Sort headers.
12887         * arm-linux-nat.c: Sort headers.
12888         * arm-fbsd-tdep.c: Sort headers.
12889         * arm-fbsd-nat.c: Sort headers.
12890         * arm-bsd-tdep.c: Sort headers.
12891         * arch-utils.c: Sort headers.
12892         * arc-tdep.c: Sort headers.
12893         * arc-newlib-tdep.c: Sort headers.
12894         * annotate.h: Sort headers.
12895         * annotate.c: Sort headers.
12896         * amd64-windows-tdep.c: Sort headers.
12897         * amd64-windows-nat.c: Sort headers.
12898         * amd64-tdep.c: Sort headers.
12899         * amd64-sol2-tdep.c: Sort headers.
12900         * amd64-obsd-tdep.c: Sort headers.
12901         * amd64-obsd-nat.c: Sort headers.
12902         * amd64-nbsd-tdep.c: Sort headers.
12903         * amd64-nbsd-nat.c: Sort headers.
12904         * amd64-nat.c: Sort headers.
12905         * amd64-linux-tdep.c: Sort headers.
12906         * amd64-linux-nat.c: Sort headers.
12907         * amd64-fbsd-tdep.c: Sort headers.
12908         * amd64-fbsd-nat.c: Sort headers.
12909         * amd64-dicos-tdep.c: Sort headers.
12910         * amd64-darwin-tdep.c: Sort headers.
12911         * amd64-bsd-nat.c: Sort headers.
12912         * alpha-tdep.c: Sort headers.
12913         * alpha-obsd-tdep.c: Sort headers.
12914         * alpha-nbsd-tdep.c: Sort headers.
12915         * alpha-mdebug-tdep.c: Sort headers.
12916         * alpha-linux-tdep.c: Sort headers.
12917         * alpha-linux-nat.c: Sort headers.
12918         * alpha-bsd-tdep.c: Sort headers.
12919         * alpha-bsd-nat.c: Sort headers.
12920         * aix-thread.c: Sort headers.
12921         * agent.c: Sort headers.
12922         * addrmap.c: Sort headers.
12923         * ada-varobj.c: Sort headers.
12924         * ada-valprint.c: Sort headers.
12925         * ada-typeprint.c: Sort headers.
12926         * ada-tasks.c: Sort headers.
12927         * ada-lang.c: Sort headers.
12928         * aarch64-tdep.c: Sort headers.
12929         * aarch64-ravenscar-thread.c: Sort headers.
12930         * aarch64-newlib-tdep.c: Sort headers.
12931         * aarch64-linux-tdep.c: Sort headers.
12932         * aarch64-linux-nat.c: Sort headers.
12933         * aarch64-fbsd-tdep.c: Sort headers.
12934         * aarch64-fbsd-nat.c: Sort headers.
12935         * aarch32-linux-nat.c: Sort headers.
12936
12937 2019-04-04  Tom Tromey  <tom@tromey.com>
12938
12939         * varobj.c (varobj_create): Update.
12940         * rust-exp.y (struct rust_parser) <update_innermost_block,
12941         lookup_symbol>: New methods.
12942         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12943         Rename.
12944         (rust_parser::rust_lookup_type)
12945         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12946         * printcmd.c (display_command, do_one_display): Update.
12947         * parser-defs.h (struct parser_state) <parser_state>: Add
12948         "tracker" parameter.
12949         (block_tracker): New member.
12950         (class innermost_block_tracker) <innermost_block_tracker>: Add
12951         "types" parameter.
12952         <reset>: Remove method.
12953         (innermost_block): Don't declare.
12954         (null_post_parser): Update.
12955         * parse.c (innermost_block): Remove global.
12956         (write_dollar_variable): Update.
12957         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12958         Remove "tracker_types" parameter.
12959         (parse_expression): Add "tracker" parameter.
12960         (parse_expression_for_completion): Update.
12961         (null_post_parser): Add "tracker" parameter.
12962         * p-exp.y: Update rules.
12963         * m2-exp.y: Update rules.
12964         * language.h (struct language_defn) <la_post_parser>: Add
12965         "tracker" parameter.
12966         * go-exp.y: Update rules.
12967         * f-exp.y: Update rules.
12968         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12969         parameter.
12970         * d-exp.y: Update rules.
12971         * c-exp.y: Update rules.
12972         * breakpoint.c (set_breakpoint_condition): Create an
12973         innermost_block_tracker.
12974         (watch_command_1): Likewise.
12975         * ada-lang.c (resolve): Add "tracker" parameter.
12976         (resolve_subexp): Likewise.
12977         * ada-exp.y (write_var_from_sym): Update.
12978
12979 2019-04-04  Tom Tromey  <tom@tromey.com>
12980
12981         * type-stack.h: New file.
12982         * type-stack.c: New file.
12983         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12984         type-stack.h.
12985         (insert_into_type_stack, insert_type, push_type, push_type_int)
12986         (insert_type_address_space, pop_type, pop_type_int)
12987         (pop_typelist, pop_type_stack, append_type_stack)
12988         (push_type_stack, get_type_stack, push_typelist)
12989         (follow_type_instance_flags, follow_types): Don't declare.
12990         * parse.c (type_stack): Remove global.
12991         (parse_exp_in_context): Update.
12992         (insert_into_type_stack, insert_type, push_type, push_type_int)
12993         (insert_type_address_space, pop_type, pop_type_int)
12994         (pop_typelist, pop_type_stack, append_type_stack)
12995         (push_type_stack, get_type_stack, push_typelist)
12996         (follow_type_instance_flags, follow_types): Remove (moved to
12997         type-stack.c).
12998         * f-exp.y (type_stack): New global.
12999         Update rules.
13000         (push_kind_type, f_parse): Update.
13001         * d-exp.y (type_stack): New global.
13002         Update rules.
13003         (d_parse): Update.
13004         * c-exp.y (struct c_parse_state) <type_stack>: New member.
13005         Update rules.
13006         * Makefile.in (COMMON_SFILES): Add type-stack.c.
13007         (HFILES_NO_SRCDIR): Add type-stack.h.
13008
13009 2019-04-04  Tom Tromey  <tom@tromey.com>
13010
13011         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
13012         (rust_parser::convert_ast_to_expression, rust_parse)
13013         (rust_lex_test_completion, rust_lex_tests): Update.
13014         * parser-defs.h (struct expr_completion_state): New.
13015         (struct parser_state) <parser_state>: Add completion parameter.
13016         <mark_struct_expression, mark_completion_tag>: New methods.
13017         <parse_completion, m_completion_state>: New members.
13018         (prefixify_expression, null_post_parser): Update.
13019         (mark_struct_expression, mark_completion_tag): Don't declare.
13020         * parse.c (parse_completion, expout_last_struct)
13021         (expout_tag_completion_type, expout_completion_name): Remove
13022         globals.
13023         (parser_state::mark_struct_expression)
13024         (parser_state::mark_completion_tag): Now methods.
13025         (prefixify_expression): Add last_struct parameter.
13026         (prefixify_subexp): Likewise.
13027         (parse_exp_1): Update.
13028         (parse_exp_in_context): Add cstate parameter.  Update.
13029         (parse_expression_for_completion): Create an
13030         expr_completion_state.
13031         (null_post_parser): Add "completion" parameter.
13032         * p-exp.y: Update rules.
13033         (yylex): Update.
13034         * language.h (struct language_defn) <la_post_parser>: Add
13035         "completing" parameter.
13036         * go-exp.y: Update rules.
13037         (lex_one_token): Update.
13038         * expression.h (parse_completion): Don't declare.
13039         * d-exp.y: Update rules.
13040         (lex_one_token): Update rules.
13041         * c-exp.y: Update rules.
13042         (lex_one_token): Update.
13043         * ada-lang.c (resolve): Add "parse_completion" parameter.
13044         (resolve_subexp): Likewise.
13045         (ada_resolve_function): Likewise.
13046
13047 2019-04-04  Tom Tromey  <tom@tromey.com>
13048
13049         * parser-defs.h (struct parser_state) <start_arglist,
13050         end_arglist>: New methods.
13051         <arglist_len, m_funcall_chain>: New members.
13052         (arglist_len, start_arglist, end_arglist): Don't declare.
13053         * parse.c (arglist_len, funcall_chain): Remove global.
13054         (start_arglist, end_arglist): Remove functions.
13055         (parse_exp_in_context): Update.
13056         * p-exp.y: Update rules.
13057         * m2-exp.y: Update rules.
13058         * go-exp.y: Update rules.
13059         * f-exp.y: Update rules.
13060         * d-exp.y: Update rules.
13061         * c-exp.y: Update rules.
13062
13063 2019-04-04  Tom Tromey  <tom@tromey.com>
13064
13065         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
13066         lex_operator, push_back>: New methods.
13067         Update all rules.
13068         (rust_parser::lex_hex, lex_escape): Rename and update.
13069         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
13070         (rust_parser::lex_operator): Rename and update.
13071         (rust_parser::lex_number, rustyylex, rustyyerror)
13072         (rust_lex_test_init, rust_lex_test_sequence)
13073         (rust_lex_test_push_back, rust_lex_tests): Update.
13074         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13075         parameter.
13076         <lexptr, prev_lexptr>: New members.
13077         (lexptr, prev_lexptr): Don't declare.
13078         * parse.c (lexptr, prev_lexptr): Remove globals.
13079         (parse_exp_in_context): Update.
13080         * p-exp.y (yylex, yyerror): Update.
13081         * m2-exp.y (parse_number, yylex, yyerror): Update.
13082         * go-exp.y (lex_one_token, yyerror): Update.
13083         * f-exp.y (match_string_literal, yylex, yyerror): Update.
13084         * d-exp.y (lex_one_token, yyerror): Update.
13085         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13086         (lex_one_token, yyerror): Update.
13087         * ada-lex.l (YY_INPUT): Update.
13088         (rewind_to_char): Update.
13089         * ada-exp.y (yyerror): Update.
13090
13091 2019-04-04  Tom Tromey  <tom@tromey.com>
13092
13093         * rust-exp.y (rustyylex, rust_lex_tests): Update.
13094         * parser-defs.h (struct parser_state) <parser_state>: Add new
13095         parameter.
13096         <comma_terminates>: New member.
13097         (comma_terminates): Don't declare global.
13098         * parse.c (comma_terminates): Remove global.
13099         (parse_exp_in_context): Update.
13100         * p-exp.y (yylex): Update.
13101         * m2-exp.y (yylex): Update.
13102         * go-exp.y (lex_one_token): Update.
13103         * f-exp.y (yylex): Update.
13104         * d-exp.y (lex_one_token): Update.
13105         * c-exp.y (lex_one_token): Update.
13106         * ada-lex.l: Update.
13107
13108 2019-04-04  Tom Tromey  <tom@tromey.com>
13109
13110         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13111         (rustyylex, rust_lex_test_init, rust_lex_test_one)
13112         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13113         * parser-defs.h (paren_depth): Don't declare.
13114         * parse.c (paren_depth): Remove global.
13115         (parse_exp_in_context): Update.
13116         * p-exp.y (paren_depth): New global.
13117         (pascal_parse): Initialize it.
13118         * m2-exp.y (paren_depth): New global.
13119         (m2_parse): Initialize it.
13120         * go-exp.y (paren_depth): New global.
13121         (go_parse): Initialize it.
13122         * f-exp.y (paren_depth): New global.
13123         (f_parse): Initialize it.
13124         * d-exp.y (paren_depth): New global.
13125         (d_parse): Initialize it.
13126         * c-exp.y (paren_depth): New global.
13127         (c_parse): Initialize it.
13128         * ada-lex.l (paren_depth): New global.
13129         (lexer_init): Initialize it.
13130
13131 2019-04-04  Tom Tromey  <tom@tromey.com>
13132
13133         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13134         (rust_parser::convert_ast_to_type)
13135         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13136         * parser-defs.h (struct parser_state) <parser_state>: Add
13137         parameters.  Initialize new members.
13138         <expression_context_block, expression_context_pc>: New members.
13139         * parse.c (expression_context_block, expression_context_pc):
13140         Remove globals.
13141         (parse_exp_in_context): Update.
13142         * p-exp.y: Update all rules.
13143         (yylex): Update.
13144         * m2-exp.y: Update all rules.
13145         (yylex): Update.
13146         * go-exp.y (yylex): Update.
13147         * f-exp.y (yylex): Update.
13148         * d-exp.y: Update all rules.
13149         (yylex): Update.
13150         * c-exp.y: Update all rules.
13151         (lex_one_token, classify_name, yylex, c_parse): Update.
13152         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13153
13154 2019-04-04  Tom Tromey  <tom@tromey.com>
13155
13156         * gdbarch.h, gdbarch.c: Rebuild.
13157         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13158         * stap-probe.h:
13159         (struct stap_parse_info): Replace "parser_state" with
13160         "expr_builder".
13161         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13162         (parser_state): New class.
13163         * parse.c (expr_builder): Rename.
13164         (expr_builder::release): Rename.
13165         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13166         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13167         (write_exp_elt_longcst, write_exp_elt_floatcst)
13168         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13169         (write_exp_string_vector, write_exp_bitstring)
13170         (write_exp_msymbol, mark_struct_expression)
13171         (write_dollar_variable)
13172         (insert_type_address_space, increase_expout_size): Replace
13173         "parser_state" with "expr_builder".
13174         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13175         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13176         "parser_state" with "expr_builder".
13177
13178 2019-04-04  Tom Tromey  <tom@tromey.com>
13179
13180         * rust-exp.y: Replace "parse_language" with method call.
13181         * p-exp.y:
13182         (yylex): Replace "parse_language" with method call.
13183         * m2-exp.y:
13184         (yylex): Replace "parse_language" with method call.
13185         * go-exp.y (classify_name): Replace "parse_language" with method
13186         call.
13187         * f-exp.y (yylex): Replace "parse_language" with method call.
13188         * d-exp.y (lex_one_token): Replace "parse_language" with method
13189         call.
13190         * c-exp.y:
13191         (lex_one_token, classify_name, yylex): Replace "parse_language"
13192         with method call.
13193         * ada-exp.y (find_primitive_type, type_char)
13194         (type_system_address): Replace "parse_language" with method call.
13195
13196 2019-04-04  Tom Tromey  <tom@tromey.com>
13197
13198         * rust-exp.y: Replace "parse_gdbarch" with method call.
13199         * parse.c (write_dollar_variable, insert_type_address_space):
13200         Replace "parse_gdbarch" with method call.
13201         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13202         call.
13203         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13204         call.
13205         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13206         "parse_gdbarch" with method call.
13207         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13208         with method call.
13209         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13210         "parse_gdbarch" with method call.
13211         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13212         "parse_gdbarch" with method call.
13213         * c-exp.y (parse_type, parse_number, classify_name): Replace
13214         "parse_gdbarch" with method call.
13215         * ada-lex.l: Replace "parse_gdbarch" with method call.
13216         * ada-exp.y (parse_type, find_primitive_type, type_char)
13217         (type_system_address): Replace "parse_gdbarch" with method call.
13218
13219 2019-04-04  Tom Tromey  <tom@tromey.com>
13220
13221         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13222         * stap-probe.c (stap_parse_argument): Update.
13223         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13224         initial_size parameter.
13225         * rust-exp.y (rust_lex_tests): Update.
13226         * parse.c (parser_state): Update.
13227         (parse_exp_in_context): Update.
13228         * parser-defs.h (struct parser_state) <parser_state>: Remove
13229         "initial_size" parameter.
13230
13231 2019-04-04  Tom Tromey  <tom@tromey.com>
13232
13233         * parser-defs.h (increase_expout_size): Don't declare.
13234         * parse.c (increase_expout_size): Now static.
13235
13236 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13237
13238         * gnu-nat.c (gnu_nat_target::wait): Fix
13239         target_waitstatus_to_string call.
13240
13241 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13242
13243         * eval.c (evaluate_subexp_standard): Handle internal functions
13244         during Fortran function call handling.
13245
13246 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13247
13248         * NEWS: Mention new internal functions.
13249         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13250         (read_base_type): Use dwarf2_init_complex_target_type.
13251         * value.c (creal_internal_fn): New function.
13252         (cimag_internal_fn): New function.
13253         (_initialize_values): Register new internal functions.
13254
13255 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13256
13257         * infrun.c (stop_all_threads): If debug_infrun, always
13258         trace the wait status after wait_one, using
13259         target_waitstatus_to_string and target_pid_to_str.
13260         (handle_inferior_event): Replace various trace of
13261         wait status kind by a single trace.
13262         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13263         wait status kind image by target_waitstatus_to_string.
13264         * target/waitstatus.c (target_waitstatus_to_string): Fix
13265         obsolete comment.
13266
13267 2019-04-01  Tom Tromey  <tromey@adacore.com>
13268
13269         PR symtab/23331:
13270         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13271
13272 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13273             Pedro Alves  <palves@redhat.com>
13274
13275         * top.c (quit_force): Call 'finalize_values'.
13276         * value.c (finalize_values): New function.
13277         * value.h (finalize_values): Declare.
13278
13279 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13280
13281         * NEWS: Announce $_gdb_major and $_gdb_minor.
13282
13283         * top.c (init_gdb_version_vars): New function.
13284         (gdb_init): Call init_gdb_version_vars.
13285
13286 2019-03-29  Tom Tromey  <tromey@adacore.com>
13287
13288         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13289         help text.  Remove dead code.
13290
13291 2019-03-29  Keith Seitz  <keiths@redhat.com>
13292
13293         From Siddhesh Poyarekar:
13294         * f-lang.h (f77_get_upperbound): Return LONGEST.
13295         (f77_get_lowerbound): Likewise.
13296         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13297         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13298         print them.
13299         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13300         plongest to format print it.
13301         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13302         (f77_get_upperbound): Likewise.
13303         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13304         LOWER_BOUND to LONGEST.
13305         (f77_create_arrayprint_offset_tbl): Likewise.
13306
13307 2019-03-29  Keith Seitz  <keiths@redhat.com>
13308
13309         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13310         %s/pulongest for TYPE_LENGTH instead of %d in format
13311         strings.
13312         * ada-typerint.c (ada_print_type): Likewise.
13313         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13314         * compile/compile-c-support.c (generate_register_struct): Likewise.
13315         * gdbtypes.c (recursive_dump_type): Likewise.
13316         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13317         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13318         instead of %d in format strings.
13319         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13320         to std::min to ULONGEST.
13321         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13322         instead of %d in format strings.
13323         * tracepoint.c (info_scope_command): Likewise.
13324         * typeprint.c (print_offset_data::update)
13325         (print_offset_data::finish): Likewise.
13326         * xtensa-tdep.c (xtensa_store_return_value)
13327         (xtensa_push_dummy_call): Likewise.
13328
13329 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13330
13331         * windows-nat.c (display_selector): Fixed format specifications
13332         for 64-bit Cygwin.
13333
13334 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13335
13336         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13337
13338 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13339
13340         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13341         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13342         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13343         (nios2_linux_init_abi): Install it.
13344
13345 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13346
13347         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13348
13349 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13350
13351         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13352
13353 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13354             Tom Tromey  <tromey@adacore.com>
13355
13356         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13357
13358 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13359
13360         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13361         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13362         method to compute the bounds of range types. Also print "[evaluated]"
13363         if the bounds' values come from a dynamic evaluation.
13364
13365 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13366
13367         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13368         whitespace when pretty printing is on.
13369
13370 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13371
13372         * ppc-linux-nat.c: Add include.
13373
13374 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13375
13376         * NEWS: Mention AArch64 Pointer Authentication.
13377
13378 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13379
13380         * arm-linux-nat.c: Add include.
13381
13382 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13383
13384         * source-cache.c (source_cache::get_source_lines): Re-read
13385         fullname after calling open_source_file.
13386
13387 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13388
13389         * NEWS: Mention TLS support for FreeBSD.
13390
13391 2019-03-25  Tom Tromey  <tromey@adacore.com>
13392
13393         * minsyms.c (BUNCH_SIZE): Update comment.
13394         (~minimal_symbol_reader): Remove old comment.
13395         (compact_minimal_symbols): Update comment.
13396         (minimal_symbol_reader::install): Remove old comment.  Update
13397         other comments.
13398
13399 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13400
13401         * s390-linux-nat.c: Add include.
13402
13403 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13404
13405         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13406         Call linux_get_hwcap.
13407         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13408         Likewise.
13409         (aarch64_linux_get_hwcap): Remove function.
13410         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13411         declaration.
13412         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13413         linux_get_hwcap.
13414         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13415         * linux-tdep.c (linux_get_hwcap): Add function.
13416         (linux_get_hwcap2): Likewise.
13417         * linux-tdep.h (linux_get_hwcap): Add declaration.
13418         (linux_get_hwcap2): Likewise.
13419         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13420         (ppc_linux_get_hwcap2): Likewise.
13421         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13422         linux_get_hwcap.
13423         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13424         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13425         (ppc_linux_nat_target::read_description): Likewise.
13426         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13427         * s390-linux-nat.c: Likewise.
13428         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13429
13430 2019-03-24  Tom Tromey  <tom@tromey.com>
13431
13432         * ada-lang.c (standard_lookup): Simplify initialization.
13433         (ada_lookup_symbol_nonlocal): Simplify return.
13434         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13435         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13436         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13437         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13438         initialization.
13439         * solib.c (solib_global_lookup): Simplify.
13440         * symtab.c (null_block_symbol): Remove.
13441         (symbol_cache_lookup): Simplify returns.
13442         (lookup_language_this): Simplify returns.
13443         (lookup_symbol_aux): Simplify return.
13444         (lookup_local_symbol): Simplify returns.
13445         (lookup_global_symbol_from_objfile): Simplify return.
13446         (lookup_symbol_in_objfile_symtabs)
13447         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13448         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13449         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13450         * cp-namespace.c (cp_lookup_bare_symbol)
13451         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13452         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13453         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13454         (cp_lookup_symbol_via_imports): Simplify initialization.
13455         (find_symbol_in_baseclass): Likewise.
13456         * symtab.h (null_block_symbol): Remove.
13457         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13458         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13459         (d_lookup_symbol_module): Likewise.
13460         (find_symbol_in_baseclass): Simplify initialization.
13461
13462 2019-03-24  Tom Tromey  <tom@tromey.com>
13463
13464         * expression.h: Don't include symtab.h.
13465         (struct block): Forward declare.
13466
13467 2019-03-24  Tom Tromey  <tom@tromey.com>
13468
13469         * c-exp.y (typebase): Remove casts.
13470         * gdbtypes.c (lookup_unsigned_typename, )
13471         (lookup_signed_typename): Remove cast.
13472         * eval.c (parse_to_comma_and_eval): Remove cast.
13473         * parse.c (write_dollar_variable): Remove cast.
13474         * block.h (struct block) <superblock>: Now const.
13475         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13476         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13477         (map_block): Make "block" const.
13478         * symfile.h (struct quick_symbol_functions)
13479         <map_matching_symbols>: Constify block argument to "callback".
13480         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13481         const.
13482         (find_pc_sect_compunit_symtab): Make "b" const.
13483         (find_symbol_at_address): Likewise.
13484         (search_symbols): Likewise.
13485         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13486         (dw2_debug_names_lookup_symbol): Likewise.
13487         (dw2_map_matching_symbols): Update.
13488         * p-valprint.c (pascal_val_print): Remove "block".
13489         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13490         (aux_add_nonlocal_symbols): Make "block" const.
13491         (resolve_subexp): Remove cast.
13492         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13493         const.
13494         (iterate_over_file_blocks): Likewise.
13495         * f-exp.y (%union) <bval>: Remove.
13496         * coffread.c (patch_opaque_types): Make "b" const.
13497         * spu-tdep.c (spu_catch_start): Make "block" const.
13498         * c-valprint.c (print_unpacked_pointer): Remove "block".
13499         * symmisc.c (dump_symtab_1): Make "b" const.
13500         (block_depth): Make "block" const.
13501         * d-exp.y (%union) <bval>: Remove.
13502         * cp-support.h (cp_lookup_rtti_type): Update.
13503         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13504         * psymtab.c (psym_lookup_symbol): Make "block" const.
13505         (maintenance_check_psymtabs): Make "b" const.
13506         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13507         (enumerate_locals, enumerate_args): Update.
13508         * python/py-symtab.c (stpy_global_block): Make "block" const.
13509         (stpy_static_block): Likewise.
13510         * inline-frame.c (block_starting_point_at): Make "new_block"
13511         const.
13512         * block.c (find_block_in_blockvector): Make return type const.
13513         (blockvector_for_pc_sect): Make "b" const.
13514         (find_block_in_blockvector): Make "b" const.
13515
13516 2019-03-23  Tom Tromey  <tom@tromey.com>
13517
13518         * varobj.c (varobj_create): Update.
13519         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13520         * printcmd.c (display_command, do_one_display): Don't reset
13521         innermost_block.
13522         * parser-defs.h (enum innermost_block_tracker_type): Move to
13523         expression.h.
13524         (innermost_block): Update comment.
13525         * parse.c (parse_exp_1): Add tracker_types parameter.
13526         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13527         tracker_types parameter.  Reset innermost_block.
13528         (parse_exp_in_context): Remove.
13529         (parse_expression_for_completion): Update.
13530         * objfiles.c (~objfile): Don't reset expression_context_block or
13531         innermost_block.
13532         * expression.h (enum innermost_block_tracker_type): Move from
13533         parser-defs.h.
13534         (parse_exp_1): Add tracker_types parameter.
13535         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13536         reset innermost_block.
13537
13538 2019-03-23  Tom Tromey  <tom@tromey.com>
13539
13540         * objfiles.h: Include bcache.h.
13541
13542 2019-03-23  Tom Tromey  <tom@tromey.com>
13543
13544         * linespec.c (get_current_search_block): Use
13545         scoped_restore_current_language.
13546         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13547
13548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13549             Jiong Wang  <jiong.wang@arm.com>
13550
13551         * aarch64-linux-tdep.c
13552         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13553         section.
13554         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13555
13556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13557             Jiong Wang  <jiong.wang@arm.com>
13558
13559         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13560         instructions.
13561         (aarch64_analyze_prologue_test): Add PACIASP test.
13562         (aarch64_prologue_prev_register): Unmask PC value.
13563
13564 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13565             Jiong Wang  <jiong.wang@arm.com>
13566
13567         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13568         (aarch64_dwarf2_prev_register): Unmask PC value.
13569         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13570         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13571         DW_CFA_AARCH64_negate_ra_state.
13572         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13573
13574 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13575             Jiong Wang  <jiong.wang@arm.com>
13576
13577         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13578         registers.
13579         (aarch64_pseudo_register_name): Likewise.
13580         (aarch64_pseudo_register_type): Likewise.
13581         (aarch64_pseudo_register_reggroup_p): Likewise.
13582         (aarch64_gdbarch_init): Add pauth registers.
13583         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13584         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13585         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13586         (struct gdbarch_tdep): Add regnum for ra_state.
13587
13588 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13589             Jiong Wang  <jiong.wang@arm.com>
13590
13591         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13592
13593 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13594             Jiong Wang  <jiong.wang@arm.com>
13595
13596         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13597         function.
13598         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13599         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13600         (aarch64_gdbarch_init): Add puth registers.
13601         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13602         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13603         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13604
13605 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13606             Jiong Wang  <jiong.wang@arm.com>
13607
13608         * aarch64-linux-nat.c
13609         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13610         * aarch64-linux-tdep.c
13611         (aarch64_linux_core_read_description): Likewise.
13612         (aarch64_linux_get_hwcap): New function.
13613         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13614         (aarch64_linux_get_hwcap): New declaration.
13615
13616 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13617             Jiong Wang  <jiong.wang@arm.com>
13618
13619         * aarch64-linux-nat.c
13620         (aarch64_linux_nat_target::read_description): Add pauth param.
13621         * aarch64-linux-tdep.c
13622         (aarch64_linux_core_read_description): Likewise.
13623         * aarch64-tdep.c (struct target_desc): Add in pauth.
13624         (aarch64_read_description): Add pauth param.
13625         (aarch64_gdbarch_init): Likewise.
13626         * aarch64-tdep.h (aarch64_read_description): Likewise.
13627         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13628         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13629         * features/Makefile: Add new files.
13630         * features/aarch64-pauth.c: New file.
13631         * features/aarch64-pauth.xml: New file.
13632
13633 2019-03-20  Tom Tromey  <tromey@adacore.com>
13634
13635         * infrun.c (handle_inferior_event): Rename from
13636         handle_inferior_event_1.  Create a scoped_value_mark.
13637         (handle_inferior_event): Remove.
13638
13639 2019-03-19  Tom Tromey  <tromey@adacore.com>
13640
13641         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13642         * infrun.h (print_stop_event): Add "displays" parameter.
13643         * infrun.c (print_stop_event): Add "displays" parameter.
13644
13645 2019-03-19  Pedro Alves  <palves@redhat.com>
13646
13647         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13648         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13649         to -1.  Fix TABs vs spaces.
13650         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13651         * tui/tui-out.h (tui_ui_out) Add intro comments.
13652         <m_line, m_start_of_line>: In-class initialize, and add describing
13653         comment.
13654
13655 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13656
13657         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13658         variable names.
13659         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13660
13661 2019-03-18  Pedro Alves  <palves@redhat.com>
13662             Eli Zaretskii <eliz@gnu.org>
13663
13664         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13665         m_line and m_start_of_line.
13666
13667 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13668
13669         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13670         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13671         it returns a newline.  This fixes a regression in TU mode, whereby
13672         the next line is output on the same screen line as the user input.
13673
13674 2019-03-18  Tom Tromey  <tromey@adacore.com>
13675
13676         * minsyms.c (minimal_symbol_reader::install): Remove call to
13677         obstack_blank.
13678
13679 2019-03-18  Pedro Alves  <palves@redhat.com>
13680
13681         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13682         New globals.
13683         (apply_style): New, factored out from ...
13684         (apply_ansi_escape): ... this.  Handle reverse video mode.
13685         (tui_set_reverse_mode): New function.
13686         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13687         * tui/tui-winsource.c (tui_show_source_line): Use
13688         tui_set_reverse_mode instead of setting A_STANDOUT.
13689         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13690         New setter methods.
13691
13692 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13693
13694         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13695         Handle tabs.
13696
13697 2019-03-18  Tom Tromey  <tromey@adacore.com>
13698
13699         * ada-lang.c (empty_array): Add "high" parameter.
13700         (ada_evaluate_subexp): Update.
13701
13702 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13703
13704         * unittests/string_view-selftests.c: Define
13705         _initialize_string_view_selftests unconditionally.
13706
13707 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13708
13709         PR gdb/24350
13710         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13711
13712 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13713
13714         PR gdb/24351
13715         * windows-nat.c (display_selector): Fix format specifiers.
13716
13717 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13718
13719         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13720         tui_refill_source_window instead of tui_refresh_win, to update the
13721         current execution line.  This fixes redisplay of the current line
13722         when stepping through the code with "next" or "step".
13723
13724 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13725
13726         * source-cache.c (source_cache::get_source_lines): Call
13727         find_source_lines to initialize s->nlines.  This fixes vertical
13728         scrolling of TUI source window when the DOWN arrow is pressed.
13729
13730 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13731
13732         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13733         linux-thread-db.c (_initialize_thread_db): Likewise.
13734
13735 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13736
13737         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13738         wclrtoeol in tui_show_source_line".  This reverts changes made in
13739         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13740
13741 2019-03-15  Tom Tromey  <tom@tromey.com>
13742
13743         * symtab.h (struct minimal_symbol): Derive from
13744         general_symbol_info.
13745         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13746         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13747         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13748         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13749         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13750         (MSYMBOL_SEARCH_NAME): Update.
13751         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13752         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13753         * minsyms.c (minimal_symbol_reader::record_full): Update.
13754
13755 2019-03-15  Tom Tromey  <tom@tromey.com>
13756
13757         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13758
13759 2019-03-15  Tom Tromey  <tom@tromey.com>
13760
13761         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13762         unique_xmalloc_ptr.
13763         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13764         Update.
13765         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13766         (build_minimal_symbol_hash_tables)
13767         (minimal_symbol_reader::install): Update.
13768
13769 2019-03-15  Tom Tromey  <tom@tromey.com>
13770
13771         * symtab.c (create_demangled_names_hash): Update.
13772         (symbol_set_names): Update.
13773         * objfiles.h (struct objfile_per_bfd_storage)
13774         <demangled_names_hash>: Now an htab_up.
13775         * objfiles.c (objfile_per_bfd_storage): Simplify.
13776
13777 2019-03-15  Tom Tromey  <tom@tromey.com>
13778
13779         * objfiles.h (struct objfile_per_bfd_storage): Declare
13780         destructor.
13781         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13782         New.
13783         (get_objfile_bfd_data): Use new.  Don't initialize
13784         language_of_main.
13785         (free_objfile_per_bfd_storage): Remove.
13786         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13787
13788 2019-03-15  Tom Tromey  <tom@tromey.com>
13789
13790         * symfile.c (reread_symbols): Update.
13791         * objfiles.c (objfile::objfile): Update.
13792         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13793         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13794         comment.
13795         (minimal_symbol_reader::install): Update.
13796         (terminate_minimal_symbol_table): Remove.
13797         * jit.c (jit_object_close_impl): Update.
13798
13799 2019-03-15  Tom Tromey  <tom@tromey.com>
13800
13801         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13802         initializations.
13803
13804 2019-03-15  Tom Tromey  <tom@tromey.com>
13805
13806         * objfiles.h (struct objfile_per_bfd_storage)
13807         <demangled_hash_languages>: Now a bitset.
13808         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13809         (lookup_minimal_symbol): Update.
13810
13811 2019-03-15  Tom Tromey  <tom@tromey.com>
13812
13813         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13814         Don't return the symbol.
13815         * coffread.c (record_minimal_symbol): Use record_full.
13816
13817 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13818
13819         The MS-Windows port of ncurses fails to switch to a color pair if
13820         one or both of the colors are the implicit default colors.  This
13821         change records the default colors when TUI is initialized, and
13822         then specifies them explicitly when a color pair uses the default
13823         colors.  This allows color styling in TUI mode on MS-Windows.
13824
13825         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13826         ncurses_norm_attr.
13827         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13828         colors in ncurses_norm_attr.
13829         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13830         "none", replace it with the default color recorded in
13831         ncurses_norm_attr.
13832
13833 2019-03-14  Tom Tromey  <tromey@adacore.com>
13834
13835         * source-cache.h (class source_cache) <get_source_lines>: Return
13836         std::string.
13837         * source-cache.c (source_cache::extract_lines): Handle case where
13838         first_pos==npos.  Return std::string.
13839         (source_cache::get_source_lines): Update.
13840
13841 2019-03-14  Tom Tromey  <tromey@adacore.com>
13842
13843         * NEWS: Add item for "style sources" commands.
13844         * source-cache.c (source_cache::get_source_lines): Check
13845         source_styling.
13846         * cli/cli-style.c (source_styling): New global.
13847         (_initialize_cli_style): Add "style sources" commands.
13848         (show_style_sources): New function.
13849         * cli/cli-style.h (source_styling): Declare.
13850
13851 2019-03-14  Pedro Alves  <palves@redhat.com>
13852             Tom Tromey  <tromey@adacore.com>
13853
13854         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13855         * tui/tui-winsource.c (tui_refill_source_window): New function,
13856         from...
13857         (tui_horizontal_source_scroll): ... here.  Move some logic.
13858         * cli/cli-style.c (set_style_enabled): Notify new observable.
13859         * tui/tui-hooks.c (tui_redisplay_source): New function.
13860         (tui_attach_detach_observers): Attach or detach
13861         tui_redisplay_source.
13862         * observable.h (source_styling_changed): New observable.
13863         * observable.c: Define source_styling_changed observable.
13864
13865 2019-03-13  Tom Tromey  <tromey@adacore.com>
13866
13867         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13868         (i386_gnu_nat_target::store_registers): Update.
13869         * target-debug.h (target_debug_print_std_string): New macro.
13870         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13871         * windows-tdep.c (display_one_tib): Update.
13872         * tui/tui-stack.c (tui_make_status_line): Update.
13873         * top.c (print_inferior_quit_action): Update.
13874         * thread.c (thr_try_catch_cmd): Update.
13875         (add_thread_with_info): Update.
13876         (thread_target_id_str): Update.
13877         (thr_try_catch_cmd): Update.
13878         (thread_command): Update.
13879         (thread_find_command): Update.
13880         * record-btrace.c (record_btrace_target::info_record)
13881         (record_btrace_resume_thread, record_btrace_target::resume)
13882         (record_btrace_cancel_resume, record_btrace_step_thread)
13883         (record_btrace_target::wait, record_btrace_target::wait)
13884         (record_btrace_target::wait, record_btrace_target::stop): Update.
13885         * progspace.c (print_program_space): Update.
13886         * process-stratum-target.c
13887         (process_stratum_target::thread_address_space): Update.
13888         * linux-fork.c (linux_fork_mourn_inferior)
13889         (detach_checkpoint_command, info_checkpoints_command)
13890         (linux_fork_context): Update.
13891         (linux_fork_detach): Update.
13892         (class scoped_switch_fork_info): Update.
13893         (delete_checkpoint_command): Update.
13894         * infrun.c (follow_fork_inferior): Update.
13895         (follow_fork_inferior): Update.
13896         (proceed_after_vfork_done): Update.
13897         (handle_vfork_child_exec_or_exit): Update.
13898         (follow_exec): Update.
13899         (displaced_step_prepare_throw): Update.
13900         (displaced_step_restore): Update.
13901         (start_step_over): Update.
13902         (resume_1): Update.
13903         (clear_proceed_status_thread): Update.
13904         (proceed): Update.
13905         (print_target_wait_results): Update.
13906         (do_target_wait): Update.
13907         (context_switch): Update.
13908         (stop_all_threads): Update.
13909         (restart_threads): Update.
13910         (finish_step_over): Update.
13911         (handle_signal_stop): Update.
13912         (switch_back_to_stepped_thread): Update.
13913         (keep_going_pass_signal): Update.
13914         (print_exited_reason): Update.
13915         (normal_stop): Update.
13916         * inferior.c (inferior_pid_to_str): Change return type.
13917         (print_selected_inferior): Update.
13918         (add_inferior): Update.
13919         (detach_inferior): Update.
13920         * dummy-frame.c (fprint_dummy_frames): Update.
13921         * dcache.c (dcache_info_1): Update.
13922         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13923         (btrace_fetch, btrace_clear): Update.
13924         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13925         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13926         type.
13927         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13928         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13929         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13930         * gdbarch.c, gdbarch.h: Rebuild.
13931         * gdbarch.sh (core_pid_to_str): Change return type.
13932         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13933         return type.
13934         (windows_nat_target::pid_to_str): Change return type.
13935         (windows_delete_thread): Update.
13936         (windows_nat_target::attach): Update.
13937         (windows_nat_target::files_info): Update.
13938         * target-delegates.c: Rebuild.
13939         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13940         return type.
13941         (sol_thread_target::pid_to_str): Change return type.
13942         * remote.c (class remote_target) <pid_to_str>: Change return
13943         type.
13944         (remote_target::pid_to_str): Change return type.
13945         (extended_remote_target::attach, remote_target::remote_stop_ns)
13946         (remote_target::remote_notif_remove_queued_reply)
13947         (remote_target::push_stop_reply, remote_target::disable_btrace):
13948         Update.
13949         (extended_remote_target::attach): Update.
13950         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13951         type.
13952         (gdbsim_target::pid_to_str): Change return type.
13953         * ravenscar-thread.c (struct ravenscar_thread_target)
13954         <pid_to_str>: Change return type.
13955         (ravenscar_thread_target::pid_to_str): Change return type.
13956         * procfs.c (class procfs_target) <pid_to_str>: Change return
13957         type.
13958         (procfs_target::pid_to_str): Change return type.
13959         (procfs_target::attach): Update.
13960         (procfs_target::detach): Update.
13961         (procfs_target::fetch_registers): Update.
13962         (procfs_target::store_registers): Update.
13963         (procfs_target::wait): Update.
13964         (procfs_target::files_info): Update.
13965         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13966         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13967         return type.
13968         (nto_procfs_target::pid_to_str): Change return type.
13969         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13970         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13971         return type.
13972         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13973         (exit_lwp): Update.
13974         (attach_proc_task_lwp_callback, get_detach_signal)
13975         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13976         (linux_nat_target::resume, wait_lwp, stop_callback)
13977         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13978         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13979         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13980         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13981         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13982         type.
13983         (inf_ptrace_target::attach): Update.
13984         (inf_ptrace_target::files_info): Update.
13985         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13986         type.
13987         (go32_nat_target::pid_to_str): Change return type.
13988         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13989         (gnu_nat_target::wait): Update.
13990         (gnu_nat_target::wait): Update.
13991         (gnu_nat_target::resume): Update.
13992         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13993         (fbsd_nat_target::wait): Update.
13994         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13995         type.
13996         (darwin_nat_target::attach): Update.
13997         * corelow.c (class core_target) <pid_to_str>: Change return type.
13998         (core_target::pid_to_str): Change return type.
13999         * target.c (normal_pid_to_str): Change return type.
14000         (default_pid_to_str): Likewise.
14001         (target_pid_to_str): Change return type.
14002         (target_translate_tls_address): Update.
14003         (target_announce_detach): Update.
14004         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
14005         return type.
14006         (bsd_uthread_target::pid_to_str): Change return type.
14007         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
14008         type.
14009         (bsd_kvm_target::pid_to_str): Change return type.
14010         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
14011         return type.
14012         (aix_thread_target::pid_to_str): Change return type.
14013         * target.h (struct target_ops) <pid_to_str>: Change return type.
14014         (target_pid_to_str, normal_pid_to_str): Likewise.
14015         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
14016         type.
14017         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
14018         type.
14019         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
14020         return type.
14021         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
14022         type.
14023         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
14024         type.
14025         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
14026         return type.
14027
14028 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
14029
14030         * NEWS: Mention that the new default MI version is 3.  Mention
14031         changes to the output of commands and events that deal with
14032         multi-location breakpoints.
14033         * breakpoint.c: Include "mi/mi-out.h".
14034         (print_one_breakpoint): Change output syntax if using MI version
14035         >= 3.
14036         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
14037         New.
14038         (mi_multi_location_breakpoint_output_fixed): New.
14039         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
14040         (mi_cmd_fix_multi_location_breakpoint_output): New.
14041         (mi_multi_location_breakpoint_output_fixed): New.
14042         * mi/mi-cmds.c (mi_cmds): Register command
14043         -fix-multi-location-breakpoint-output.
14044         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
14045         interpreter "mi".
14046
14047 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
14048
14049         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
14050         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
14051         instantiate mi_ui_out based on interpreter name.
14052         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
14053         * mi/mi-main.c (mi_load_progress): Likewise.
14054
14055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14056
14057         * NEWS: Combine separate "New targets" sections for 8.3.
14058
14059 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14060
14061         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
14062         (ppcfbsd_init_abi): Install gdbarch
14063         "fetch_tls_load_module_address" and "get_thread_local_address"
14064         methods.
14065
14066 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14067
14068         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
14069         (riscv_fbsd_init_abi): Install gdbarch
14070         "fetch_tls_load_module_address" and "get_thread_local_address"
14071         methods.
14072
14073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14074
14075         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14076         (i386fbsd_init_abi): Install gdbarch
14077         "fetch_tls_load_module_address" and "get_thread_local_address"
14078         methods.
14079
14080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14081
14082         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14083         (amd64fbsd_init_abi): Install gdbarch
14084         "fetch_tls_load_module_address" and "get_thread_local_address"
14085         methods.
14086
14087 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14088
14089         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14090         (struct fbsd_pspace_data): New type.
14091         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14092         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14093         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14094         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14095         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14096
14097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14098
14099         * gdbtypes.c (lookup_struct_elt): New function.
14100         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14101         * gdbtypes.h (struct struct_elt): New type.
14102         (lookup_struct_elt): New prototype.
14103
14104 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14105
14106         * gdbtypes.c (lookup_struct_elt_type): Update comment and
14107         remove disabled code block.
14108
14109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14110
14111         * gdbarch.sh (get_thread_local_address): New method.
14112         * gdbarch.h, gdbarch.c: Regenerate.
14113         * target.c (target_translate_tls_address): Use
14114         gdbarch_get_thread_local_address if present instead of
14115         target::get_thread_local_address.
14116
14117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14118
14119         * target.h (target::get_thread_local_address): Update comment.
14120
14121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14122
14123         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14124         objfile->separate_debug_objfile_backlink if not NULL.
14125
14126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14127
14128         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14129         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14130         (amd64bsd_store_inferior_registers): Likewise.
14131         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14132         Enable segment base registers.
14133         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14134         PT_GETFSBASE and PT_GETGSBASE.
14135         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14136         PT_SETGSBASE.
14137         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14138         segment base registers.
14139         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14140
14141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14142
14143         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14144         Update calls to i386_target_description to add 'segments'
14145         parameter.
14146         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
14147         add segment base registers.
14148         * arch/i386.c (i386_create_target_description): Add 'segments'
14149         parameter to enable segment base registers.
14150         * arch/i386.h (i386_create_target_description): Likewise.
14151         * features/i386/32bit-segments.xml: New file.
14152         * features/i386/32bit-segments.c: Generate.
14153         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14154         call to i386_target_description to add 'segments' parameter.
14155         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14156         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14157         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14158         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14159         if feature is present.
14160         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14161         Add 'segments' parameter to call to i386_target_description.
14162         (i386_target_description): Add 'segments' parameter to enable
14163         segment base registers.
14164         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14165         to call to i386_target_description.
14166         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14167         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14168         Define I386_NUM_REGS.
14169         (i386_target_description): Add 'segments' parameter to enable
14170         segment base registers.
14171
14172 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14173
14174         PR/24325
14175         * source-cache.c: #undef open and close, to avoid unresolved
14176         externals during linking.
14177
14178 2019-03-12  Tom Tromey  <tromey@adacore.com>
14179
14180         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14181         const.  Add initializers.
14182         (_initialize_remote): Don't initialize ptid globals.
14183
14184 2019-03-12  Pedro Alves  <palves@redhat.com>
14185
14186         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14187
14188 2019-03-12  Pedro Alves  <palves@redhat.com>
14189
14190         * cp-name-parser.y (main): Remove unused 'len' variable.
14191
14192 2019-03-12  Tom Tromey  <tromey@adacore.com>
14193
14194         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14195         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14196
14197 2019-03-12  Tom Tromey  <tromey@adacore.com>
14198
14199         * linux-nat.c (iterate_over_lwps): Update.
14200         (stop_callback): Remove parameter.
14201         (stop_wait_callback, detach_callback, resume_set_callback)
14202         (select_singlestep_lwp_callback, set_ignore_sigint)
14203         (status_callback, resumed_callback, resume_clear_callback)
14204         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14205         data parameter.
14206         (linux_nat_target::detach, linux_nat_target::resume)
14207         (linux_stop_and_wait_all_lwps, select_event_lwp)
14208         (linux_nat_filter_event, linux_nat_wait_1)
14209         (linux_nat_target::kill, linux_nat_target::stop)
14210         (linux_nat_target::stop): Update.
14211         (linux_nat_resume_callback): Change type.
14212         (resume_stopped_resumed_lwps, count_events_callback)
14213         (select_event_lwp_callback): Likewise.
14214         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14215         * arm-linux-nat.c (struct update_registers_data): Remove.
14216         (update_registers_callback): Change type.
14217         (arm_linux_insert_hw_breakpoint1): Update.
14218         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14219         parameter.
14220         (x86_linux_dr_set_addr): Update.
14221         (x86_linux_dr_set_control): Update.
14222         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14223         (iterate_over_lwps): Use gdb::function_view.
14224         * nat/aarch64-linux-hw-point.c (struct
14225         aarch64_dr_update_callback_param): Remove.
14226         (debug_reg_change_callback): Change type.
14227         (aarch64_notify_debug_reg_change): Update.
14228         * s390-linux-nat.c (s390_refresh_per_info): Update.
14229
14230 2019-03-11  Tom Tromey  <tromey@adacore.com>
14231
14232         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14233         redundant assignment to "this_cu".
14234
14235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14236
14237         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14238
14239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14240
14241         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14242         from...
14243         (rank_one_type): ... this.
14244
14245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14246
14247         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14248         from...
14249         (rank_one_type): ... this.
14250
14251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14252
14253         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14254         from...
14255         (rank_one_type): ... this.
14256
14257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14258
14259         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14260         from...
14261         (rank_one_type): ... this.
14262
14263 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14264
14265         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14266         from...
14267         (rank_one_type): ... this.
14268
14269 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14270
14271         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14272         from...
14273         (rank_one_type): ... this.
14274
14275 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14276
14277         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14278         from...
14279         (rank_one_type): ... this.
14280
14281 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14282
14283         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14284         from...
14285         (rank_one_type): ... this.
14286
14287 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14288
14289         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14290         from...
14291         (rank_one_type): ... this.
14292
14293 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14294
14295         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14296         from...
14297         (rank_one_type): ... this.
14298
14299 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14300
14301         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14302         from...
14303         (rank_one_type): ... this.
14304
14305 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14306
14307         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14308         from...
14309         (rank_one_type): ... this.
14310
14311 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14312
14313         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14314         inferior-events' shows the example events.
14315
14316 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14317
14318         Support styling on native MS-Windows console
14319
14320         PR/24315
14321         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14322         on MS-Windows if $TERM is not defined.
14323
14324         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14325
14326         * posix-hdep.c (gdb_console_fputs):
14327         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14328         functions.
14329         * ui-file.h (gdb_console_fputs): Add prototype.
14330
14331         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14332         back to fputs only if the former returns zero.
14333
14334 2019-03-07  Tom Tromey  <tom@tromey.com>
14335
14336         * symmisc.c (print_symbol_bcache_statistics): Update.
14337         (print_objfile_statistics): Update.
14338         * symfile.c (allocate_symtab): Update.
14339         * stabsread.c: Don't include bcache.h.
14340         * psymtab.h (struct psymbol_bcache): Don't declare.
14341         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14342         (psymbol_bcache_init, psymbol_bcache_free)
14343         (psymbol_bcache_get_bcache): Don't declare.
14344         * psymtab.c (struct psymbol_bcache): Remove.
14345         (psymtab_storage::psymtab_storage): Update.
14346         (psymtab_storage::~psymtab_storage): Update.
14347         (psymbol_bcache_init, psymbol_bcache_free)
14348         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14349         (add_psymbol_to_bcache): Update.
14350         (allocate_psymtab): Update.
14351         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14352         macro_cache>: No longer pointers.
14353         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14354         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14355         * macrotab.c (macro_bcache): Update.
14356         * macroexp.c: Don't include bcache.h.
14357         * gdbtypes.c (check_types_worklist): Update.
14358         (types_deeply_equal): Remove TRY/CATCH.  Update.
14359         * elfread.c (elf_symtab_read): Update.
14360         * dwarf2read.c: Don't include bcache.h.
14361         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14362         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14363         (print_bcache_statistics, bcache_memory_used): Don't declare.
14364         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14365         methods.  Rename all data members.
14366         * bcache.c (struct bcache): Move to bcache.h.
14367         (bcache::expand_hash_table): Rename from expand_hash_table.
14368         (bcache): Remove.
14369         (bcache::insert): Rename from bcache_full.
14370         (bcache::compare): Rename from bcache_compare.
14371         (bcache_xmalloc): Remove.
14372         (bcache::~bcache): Rename from bcache_xfree.
14373         (bcache::print_statistics): Rename from print_bcache_statistics.
14374         (bcache::memory_used): Rename from bcache_memory_used.
14375
14376 2019-03-07  Pedro Alves  <palves@redhat.com>
14377
14378         * infrun.c (normal_stop): Also check for
14379         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14380
14381 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14382
14383         * f-lang.c (value_from_host_double): Moved to...
14384         * value.c (value_from_host_double): ...here.
14385         * value.h (value_from_host_double): Declare.
14386         * guile/scm-math.c (vlscm_convert_typed_number): Use
14387         value_from_host_double.
14388         (vlscm_convert_number): Likewise.
14389         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14390         * python/py-value.c (convert_value_from_python): Likewise.
14391
14392 2019-03-06  Tom Tromey  <tom@tromey.com>
14393
14394         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14395
14396 2019-03-06  Tom Tromey  <tom@tromey.com>
14397
14398         * utils.h (free_current_contents): Don't declare.
14399         * utils.c (free_current_contents): Remove.
14400
14401 2019-03-06  Tom Tromey  <tom@tromey.com>
14402
14403         * top.c (quit_force): Update.
14404         * main.c (captured_command_loop): Update.
14405         * common/new-op.c (operator new): Update.
14406         * common/common-exceptions.c (struct catcher)
14407         <save_cleanup_chain>: Remove member.
14408         (exceptions_state_mc_init): Update.
14409         (exception_try_scope_entry): Return nullptr.
14410         (exception_try_scope_exit, exception_rethrow)
14411         (throw_exception_sjlj, throw_exception_cxx): Update.
14412         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14413         (all_cleanups, do_cleanups, discard_cleanups)
14414         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14415         (restore_cleanups, restore_final_cleanups): Don't declare.
14416         (do_final_cleanups): Remove parameter.
14417         * common/cleanups.c (cleanup_chain, make_cleanup)
14418         (make_cleanup_dtor, all_cleanups, do_cleanups)
14419         (discard_my_cleanups, discard_cleanups)
14420         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14421         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14422         (null_cleanup): Remove.
14423         (do_final_cleanups): Remove parameter.
14424
14425 2019-03-06  Tom Tromey  <tom@tromey.com>
14426
14427         * remote.c (remote_target::remote_parse_stop_reply): Use
14428         unique_xmalloc_ptr.
14429
14430 2019-03-06  Tom Tromey  <tom@tromey.com>
14431
14432         * stabsread.c (struct stabs_field_info): Rename from field_info.
14433         <list, fnlist>: Add initializers.
14434         <obstack>: New member.
14435         (read_member_functions, read_struct_fields, read_baseclasses):
14436         Allocate on obstack.  Don't use cleanups.
14437         (read_one_struct_field, read_member_functions, read_struct_fields)
14438         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14439         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14440         (read_struct_type): Update.
14441
14442 2019-03-06  Tom Tromey  <tom@tromey.com>
14443
14444         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14445         * common/filestuff.h (make_cleanup_close): Don't declare.
14446         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14447         Remove.
14448
14449 2019-03-06  Tom Tromey  <tom@tromey.com>
14450
14451         * solib-aix.c: Use make_scope_exit.
14452
14453 2019-03-06  Tom Tromey  <tom@tromey.com>
14454
14455         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14456         Use make_scope_exit.
14457
14458 2019-03-06  Tom Tromey  <tom@tromey.com>
14459
14460         * solib-svr4.c (disable_probes_interface): Remove parameter.
14461         (svr4_handle_solib_event): Use make_scope_exit.
14462
14463 2019-03-06  Tom Tromey  <tom@tromey.com>
14464
14465         * remote.c (struct stop_reply_deleter): Remove.
14466         (stop_reply_up): Update.
14467         (struct stop_reply): Derive from notif_event.  Don't typedef.
14468         <regcache>: Now a std::vector.
14469         (stop_reply_xfree): Remove.
14470         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14471         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14472         (remote_target::discard_pending_stop_replies): Use delete.
14473         (remote_target::remote_parse_stop_reply): Update.
14474         (remote_target::process_stop_reply): Update.
14475         * remote-notif.h (struct notif_event): Add virtual destructor.
14476         Remove "dtr" member.
14477         (struct notif_client) <alloc_event>: Return a unique_ptr.
14478         (notif_event_xfree): Don't declare.
14479         (notif_event_up): New typedef.
14480         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14481         (notif_event_xfree, do_notif_event_xfree): Remove.
14482         (remote_notif_state_xfree): Update.
14483
14484 2019-03-06  Tom Tromey  <tom@tromey.com>
14485
14486         * infrun.c (displaced_step_clear_cleanup): Now a
14487         forward_scope_exit type.
14488         (displaced_step_prepare_throw): Update.
14489         (displaced_step_fixup): Update.
14490
14491 2019-03-06  Tom Tromey  <tom@tromey.com>
14492
14493         * inferior.h (class inferior): Update comment.
14494         * gdbthread.h (class thread_info): Update comment.
14495
14496 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14497             Tom Tromey  <tom@tromey.com>
14498
14499         * stabsread.h (struct stab_section_list): Remove.
14500         (coffstab_build_psymtabs): Update.
14501         * dbxread.c (symbuf_sections): Now a std::vector.
14502         (sect_idx): New global.
14503         (fill_symbuf): Update.
14504         (coffstab_build_psymtabs): Change type of stabsects parameter.
14505         Update.
14506         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14507         std::vector.
14508         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14509         (coff_locate_sections): Update.
14510         (coff_symfile_read): Remove cleanups.  Update.
14511         (init_stringtab): Add storage parameter.
14512         (free_stringtab, free_stringtab_cleanup): Remove.
14513         (init_lineno): Add storage parameter.
14514         (free_linetab, free_linetab_cleanup): Remove.
14515
14516 2019-03-06  Pedro Alves  <palves@redhat.com>
14517
14518         * linux-fork.c (fork_info::clobber_regs): Delete.
14519         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14520         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14521         comment.  Adjust.
14522         (scoped_switch_fork_info::scoped_switch_fork_info)
14523         (checkpoint_command, linux_fork_context): Adjust
14524         fork_save_infrun_state calls.
14525
14526 2019-03-06  Pedro Alves  <palves@redhat.com>
14527
14528         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14529         (inf_has_multiple_threads): Return 'bool' and rewrite using
14530         inferior_info::threads().
14531
14532 2019-03-06  Pedro Alves  <palves@redhat.com>
14533
14534         * linux-fork.c: Include <list>.
14535         (fork_list): Now a std::list instance.
14536         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14537         (forks_exist_p, find_last_fork): Adjust.
14538         (new_fork): Delete.
14539         (one_fork_p): New.
14540         (add_fork): Adjust.
14541         (free_fork): Delete, folded into fork_info::~fork_info().
14542         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14543         Adjust.
14544         (init_fork_list): Delete.
14545         (linux_fork_killall, linux_fork_mourn_inferior)
14546         (linux_fork_detach, info_checkpoints_command): Adjust.
14547         (_initialize_linux_fork): No longer call init_fork_list.
14548
14549 2019-03-06  Pedro Alves  <palves@redhat.com>
14550
14551         * linux-fork.c (new_fork): New, split out of ...
14552         (add_fork): ... this.  Return void.  Move "first fork" special
14553         case from here, to ...
14554         (checkpoint_command): ... here.
14555         * linux-linux.h (add_fork): Return void.
14556
14557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14558
14559         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14560
14561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14562             Chris January  <chris.january@arm.com>
14563             David Lecomber  <david.lecomber@arm.com>
14564
14565         * f-exp.y: New token, UNOP_INTRINSIC.
14566         (exp): New pattern using UNOP_INTRINSIC token.
14567         (f77_keywords): Add 'abs' keyword.
14568         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14569         (value_from_host_double): New function.
14570         (evaluate_subexp_f): Support UNOP_ABS.
14571
14572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14573
14574         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14575         types.
14576
14577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14578
14579         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14580         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14581         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14582
14583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14584
14585         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14586
14587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14588             Chris January  <chris.january@arm.com>
14589
14590         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14591         * f-exp.y: Define 'KIND' token.
14592         (exp): New pattern for KIND expressions.
14593         (ptype): Handle types with a kind extension.
14594         (direct_abs_decl): Extend to spot kind extensions.
14595         (f77_keywords): Add 'kind' to the list.
14596         (push_kind_type): New function.
14597         (convert_to_kind_type): New function.
14598         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14599         * parse.c (operator_length_standard): Likewise.
14600         * parser-defs.h (enum type_pieces): Add tp_kind.
14601         * std-operator.def: Add UNOP_KIND.
14602
14603 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14604
14605         * f-exp.y (f_parse): Set yydebug.
14606
14607 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14608
14609         * f-lang.c (evaluate_subexp_f): New function.
14610         (exp_descriptor_f): New global.
14611         (f_language_defn): Use exp_descriptor_f instead of
14612         exp_descriptor_standard.
14613
14614 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14615
14616         * f-exp.y (struct token): Add comments.
14617         (dot_ops): Remove uppercase versions and the end marker.
14618         (f77_keywords): Likewise.
14619         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14620         entries in the dot_ops array are case insensitive, and use
14621         strncasecmp to compare strings.  Also some whitespace cleanup in
14622         this area.  Similar for the f77_keywords array, except entries in
14623         this list might be case sensitive.
14624
14625 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14626
14627         * f-exp.y (struct f77_boolean_val): Add comments.
14628         (boolean_values): Remove uppercase versions, and end marker.
14629         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14630         and use strncasecmp to achieve case insensitivity.  Additionally,
14631         perform whitespace cleanup around this code.
14632
14633 2019-03-06  Tom Tromey  <tromey@adacore.com>
14634
14635         * remote-sim.c (gdbsim_target_open): Use result of
14636         gdb_argv::release.
14637
14638 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14639         Dirk Schubert  <dirk.schubert@arm.com>
14640         Chris January  <chris.january@arm.com>
14641
14642         * eval.c (evaluate_subexp_standard): Call Fortran argument
14643         wrapping logic.
14644         * f-lang.c (struct value): A value which can be passed into a
14645         Fortran function call.
14646         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14647         where appropriate.
14648         (struct type): Value ready for a Fortran function call.
14649         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14650         is needed.
14651         * f-lang.h (fortran_argument_convert): Declaration.
14652         (fortran_preserve_arg_pointer): Declaration.
14653         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14654
14655 2019-03-05  Tom Tromey  <tromey@adacore.com>
14656
14657         * python/py-prettyprint.c (print_string_repr): Remove #if.
14658         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14659
14660 2019-03-05  Tom Tromey  <tromey@adacore.com>
14661
14662         * target.c (the_dummy_target): Move later.  Change type to
14663         "dummy_target".
14664         (initialize_targets): Don't initialize the_dummy_target.
14665
14666 2019-03-05  Tom Tromey  <tromey@adacore.com>
14667
14668         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14669         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14670
14671 2019-03-05  Tom Tromey  <tromey@adacore.com>
14672
14673         * windows-nat.c (windows_nat_target::attach)
14674         (windows_nat_target::detach): Don't call gdb_flush.
14675         * valprint.c (generic_val_print, val_print, val_print_string):
14676         Don't call gdb_flush.
14677         * utils.c (defaulted_query): Don't call gdb_flush.
14678         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14679         * target.c (target_announce_detach): Don't call gdb_flush.
14680         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14681         * remote.c (extended_remote_target::attach): Don't call
14682         gdb_flush.
14683         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14684         * printcmd.c (do_examine): Don't call gdb_flush.
14685         (info_display_command): Don't call gdb_flush.
14686         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14687         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14688         * memattr.c (info_mem_command): Don't call gdb_flush.
14689         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14690         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14691         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14692         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14693         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14694         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14695         (gnu_nat_target::detach): Don't call gdb_flush.
14696         * f-valprint.c (f_val_print): Don't call gdb_flush.
14697         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14698         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14699         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14700         gdb_flush.
14701         * c-valprint.c (c_val_print): Don't call gdb_flush.
14702         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14703
14704 2019-03-05  Tom Tromey  <tromey@adacore.com>
14705
14706         * varobj.c (update_dynamic_varobj_children): Update.
14707         (install_default_visualizer): Use reset, not release.
14708         * value.c (set_internalvar): Update.
14709         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14710         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14711         ATTRIBUTE_UNUSED_RESULT.
14712
14713 2019-03-05  Tom Tromey  <tromey@adacore.com>
14714
14715         * remote.c (class scoped_remote_fd) <release>: Add
14716         ATTRIBUTE_UNUSED_RESULT.
14717
14718 2019-03-05  Tom Tromey  <tromey@adacore.com>
14719
14720         * macroexp.c (struct macro_buffer) <release>: Add
14721         ATTRIBUTE_UNUSED_RESULT.
14722
14723 2019-03-05  Tom Tromey  <tromey@adacore.com>
14724
14725         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14726         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14727         ATTRIBUTE_UNUSED_RESULT.
14728
14729 2019-03-05  Tom Tromey  <tromey@adacore.com>
14730
14731         * common/scoped_fd.h (class scoped_fd) <release>: Add
14732         ATTRIBUTE_UNUSED_RESULT.
14733
14734 2019-03-05  Tom Tromey  <tromey@adacore.com>
14735
14736         * parser-defs.h (struct parser_state) <release>: Add
14737         ATTRIBUTE_UNUSED_RESULT.
14738
14739 2019-03-05  Tom Tromey  <tromey@adacore.com>
14740
14741         * utils.h (class gdb_argv) <release>: Add
14742         ATTRIBUTE_UNUSED_RESULT.
14743         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14744
14745 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14746
14747         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14748         for-loop range, to avoid compiler warnings.
14749
14750         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14751         avoid compiler warnings about unused variables.
14752
14753         * NEWS: Mention end of support for native debugging on MS-Windows
14754         before XP.
14755
14756         PR gdb/24292
14757         * common/netstuff.c:
14758         * gdbserver/gdbreplay.c
14759         * gdbserver/remote-utils.c:
14760         * ser-tcp.c:
14761         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14762         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14763         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14764         'getaddrinfo' and 'freeaddrinfo' were not available before
14765         Windows XP, and mingw.org's MinGW headers by default define
14766         _WIN32_WINNT to 0x500.
14767
14768 2019-03-01  Gary Benson <gbenson@redhat.com>
14769
14770         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14771
14772 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14773             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14774
14775         PR gdb/8527
14776         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14777         set_sigint_trap, clear_sigint_trap.
14778
14779 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14780
14781         * target.c (target_detach): Clear the regcache and the
14782         frame cache.
14783
14784 2019-02-27  Pedro Alves  <palves@redhat.com>
14785
14786         * utils.c (set_screen_size): When we cap the height/width sizes,
14787         tweak the corresponding command variable to show "unlimited":
14788
14789 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14790             Pedro Alves  <palves@redhat.com>
14791
14792         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14793         before calling rl_set_screen_size.
14794
14795 2019-02-27  Tom Tromey  <tromey@adacore.com>
14796
14797         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14798         define.
14799         * python/py-value.c: Remove Python 2.4 workaround.
14800         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14801         workaround.
14802         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14803         Python 2.4 workaround.
14804         * python/python-internal.h: Remove Python 2.4 comment.
14805         (Py_ssize_t): Don't define.
14806         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14807         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14808         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14809         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14810         * python/python.c (do_start_initialization): Remove Python 2.4
14811         workaround.
14812         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14813         (print_children): Remove Python 2.4 workaround.
14814         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14815         workaround.
14816         (CHARBUFFERPROC_NAME): Remove.
14817         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14818         Python 2.4 workaround.
14819
14820 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14821
14822         * NEWS: Note minimum Python version.
14823
14824 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14825
14826         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14827         code from these functions.  Remove corresponding ifdefs.  Use
14828         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14829         Remove gotos and target of gotos.
14830         (infpy_search_memory): Likewise.
14831
14832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14833
14834         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14835         (hppa_gdbarch_init): Don't register deleted functions with
14836         gdbarch.
14837
14838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14839
14840         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14841         (h8300_unwind_sp): Delete.
14842         (h8300_dummy_id): Delete.
14843         (h8300_gdbarch_init): Don't register deleted functions with
14844         gdbarch.
14845
14846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14847
14848         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14849         (ft32_unwind_pc): Delete.
14850         (ft32_unwind_sp): Delete.
14851         (ft32_gdbarch_init): Don't register deleted functions with
14852         gdbarch.
14853
14854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14855
14856         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14857         (frv_unwind_pc): Delete.
14858         (frv_unwind_sp): Delete.
14859         (frv_gdbarch_init): Don't register deleted functions with
14860         gdbarch.
14861
14862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14863
14864         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14865         (riscv_unwind_pc): Delete.
14866         (riscv_unwind_sp): Delete.
14867         (riscv_gdbarch_init): Don't register deleted functions with
14868         gdbarch.
14869
14870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14871
14872         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14873         (csky_unwind_pc): Delete.
14874         (csky_unwind_sp): Delete.
14875         (csky_gdbarch_init): Don't register deleted functions with
14876         gdbarch.
14877
14878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14879
14880         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14881         (cris_unwind_pc): Delete.
14882         (cris_unwind_sp): Delete.
14883         (cris_gdbarch_init): Don't register deleted functions with
14884         gdbarch.
14885
14886 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14887
14888         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14889         (bfin_unwind_pc): Delete.
14890         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14891
14892 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14893
14894         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14895         (arm_unwind_pc): Delete.
14896         (arm_unwind_sp): Delete.
14897         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14898
14899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14900
14901         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14902         (arc_unwind_pc): Delete.
14903         (arc_unwind_sp): Delete.
14904         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14905
14906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14907
14908         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14909         (alpha_unwind_pc): Delete.
14910         (alpha_gdbarch_init): Don't register deleted functions with
14911         gdbarch.
14912
14913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14914
14915         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14916         (aarch64_unwind_pc): Delete.
14917         (aarch64_unwind_sp): Delete.
14918         (aarch64_gdbarch_init): Don't register deleted functions with
14919         gdbarch.
14920
14921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14922
14923         * gdbtypes.c (type_align): Don't consider static members when
14924         computing structure alignment.
14925
14926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14927
14928         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14929         return 0 for other types.
14930         * arch-utils.c (default_type_align): Always return 0.
14931         * gdbarch.h: Regenerate.
14932         * gdbarch.sh (type_align): Extend comment.
14933         * gdbtypes.c (type_align): Add additional comments, always call
14934         gdbarch_type_align before applying the default rules.
14935         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14936         generic code will then apply a suitable default.
14937         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14938         types, return 0 for other types.
14939
14940 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14941
14942         * NEWS: Create a new section for the next release branch.
14943         Rename the section of the current branch, now that it has
14944         been cut.
14945
14946 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14947
14948         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14949         * version.in: Bump version to 8.3.50.DATE-git.
14950
14951 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14952
14953         * aix-thread.c (ptid_cmp): Remove unused variable.
14954         (get_signaled_thread): Likewise.
14955         (store_regs_user_thread): Likewise.
14956         (store_regs_kernel_thread): Likewise.
14957         (fetch_regs_kernel_thread): Remove shadowed variable.
14958
14959 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14960
14961         * features/riscv/32bit-cpu.xml: Add register numbers.
14962         * features/riscv/32bit-fpu.c: Regenerate.
14963         * features/riscv/32bit-fpu.xml: Add register numbers.
14964         * features/riscv/64bit-cpu.xml: Add register numbers.
14965         * features/riscv/64bit-fpu.c: Regenerate.
14966         * features/riscv/64bit-fpu.xml: Add register numbers.
14967
14968 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14969
14970         * NEWS: Mention two argument form of gdb.Value constructor.
14971         * python/py-value.c (convert_buffer_and_type_to_value): New
14972         function.
14973         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14974         Add support for handling an optional second argument.  Call
14975         convert_buffer_and_type_to_value as appropriate.
14976         * python/python-internal.h (Py_buffer_deleter): New struct.
14977         (Py_buffer_up): New typedef.
14978
14979 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14980
14981         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14982         instead of releasing ownership.
14983
14984 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14985
14986         * dwarf2read.c (open_and_init_dwp_file): Call
14987         elf_numsections instead of bfd_count_sections to initialize
14988         dwp_file->num_sections.
14989
14990 2019-02-25  Tom Tromey  <tromey@adacore.com>
14991
14992         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14993
14994 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14995
14996         * gcore.in: Add '--readnever' option when invoking GDB.
14997
14998 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14999
15000         * MAINTAINERS: Update my email address.
15001
15002 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
15003
15004         * build-id.c (build_id_to_debug_bfd_1): New function.
15005         (build_id_to_debug_bfd): Look for separate debug file in
15006         sysroot.
15007
15008 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
15009
15010         * gdbarch.sh: Update the copyright year range that is placed into
15011         generated files.
15012
15013 2019-02-22  Keith Seitz  <keiths@redhat.com>
15014
15015         PR symtab/23853
15016         * linespec.c (create_sals_line_offset): Search for the default
15017         symtab's filename instead of its fullname.
15018
15019 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
15020
15021         * NEWS: Update style defaults.
15022
15023 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
15024
15025         * main.c (captured_main_1): Disable styling in batch mode.
15026
15027 2019-02-20  Tom Tromey  <tom@tromey.com>
15028
15029         * symtab.c (symtab_symbol_info): Fix typos.
15030
15031 2019-02-20  Tom Tromey  <tromey@adacore.com>
15032
15033         * findcmd.c (_initialize_mem_search): Use upper case for
15034         metasyntactic variables.
15035
15036 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
15037
15038         * aarch64-tdep.c (aarch64_add_reggroups): New function.
15039         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
15040
15041 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
15042
15043         * top.h (source_file_name): Change to std::string.
15044         * top.c (source_file_name): Likewise.
15045         (command_line_input): Adjust.
15046         * cli/cli-script.c (script_from_file): Adjust.
15047
15048 2019-02-19  Tom Tromey  <tromey@adacore.com>
15049
15050         * ravenscar-thread.c
15051         (ravenscar_thread_target::update_thread_list): Don't call
15052         ada_build_task_list.
15053         * ada-lang.h (ada_build_task_list): Don't declare.
15054         * ada-tasks.c (struct ada_tasks_inferior_data)
15055         <task_list_valid_p>: Now bool.
15056         (read_known_tasks, ada_task_list_changed)
15057         (ada_tasks_invalidate_inferior_data): Update.
15058         (read_known_tasks_array): Return bool.
15059         (read_known_tasks_list): Likewise.
15060         (read_known_tasks): Return void.
15061         (ada_build_task_list): Now static.
15062
15063 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
15064
15065         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
15066         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
15067
15068 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15069
15070         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
15071         variant for ada_tasks_pspace_data_handle and
15072         ada_tasks_inferior_data_handle.
15073         (ada_tasks_pspace_data_cleanup): New function.
15074         (ada_tasks_inferior_data_cleanup): New function.
15075
15076 2019-02-17  Tom Tromey  <tom@tromey.com>
15077
15078         * macrotab.h (macro_source_fullname): Return a std::string.
15079         * macrotab.c (macro_include, check_for_redefinition)
15080         (macro_undef, macro_lookup_definition, foreach_macro)
15081         (foreach_macro_in_scope): Update.
15082         (macro_source_fullname): Return a std::string.
15083         * macrocmd.c (show_pp_source_pos): Update.
15084
15085 2019-02-17  Tom Tromey  <tom@tromey.com>
15086
15087         * macrocmd.c (show_pp_source_pos): Style the file names.
15088
15089 2019-02-17  Tom Tromey  <tom@tromey.com>
15090
15091         PR tui/24197:
15092         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15093
15094 2019-02-17  Tom Tromey  <tom@tromey.com>
15095
15096         * ada-lang.c (user_select_syms): Use filtered printing.
15097         * utils.c (wrap_style): New global.
15098         (desired_style): Remove.
15099         (emit_style_escape): Add stream parameter.
15100         (set_output_style, reset_terminal_style, prompt_for_continue):
15101         Update.
15102         (flush_wrap_buffer): Only flush gdb_stdout.
15103         (wrap_here): Set wrap_style.
15104         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
15105         treat escape sequences as a character.  Change when wrap buffer is
15106         flushed.
15107         (fputs_styled): Do not set the output style when the default is
15108         requested.
15109         * ui-style.h (struct ui_file_style) <is_default>: New method.
15110         * source.c (print_source_lines_base): Emit escape sequences in one
15111         piece.
15112
15113 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15114
15115         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15116         integers and enumeration types.
15117
15118 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15119
15120         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15121         instead of lookup_symbol_in_language
15122         (do_exact_match): New function.
15123         (ada_get_symbol_name_matcher): Return do_exact_match when
15124         doing a verbatim match.
15125
15126 2019-02-15  Tom Tromey  <tromey@adacore.com>
15127
15128         * ravenscar-thread.c (ravenscar_thread_target::resume)
15129         (ravenscar_thread_target::wait): Special case wildcard requests.
15130
15131 2019-02-15  Tom Tromey  <tromey@adacore.com>
15132
15133         * ravenscar-thread.c (base_ptid): Remove.
15134         (struct ravenscar_thread_target) <close>: New method.
15135         <m_base_ptid>: New member.
15136         <update_inferior_ptid, active_task, task_is_currently_active,
15137         runtime_initialized>: Declare methods.
15138         <ravenscar_thread_target>: Add constructor.
15139         (ravenscar_thread_target::task_is_currently_active)
15140         (ravenscar_thread_target::update_inferior_ptid)
15141         (ravenscar_runtime_initialized): Rename.  Now methods.
15142         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15143         (ravenscar_thread_target::update_thread_list): Update.
15144         (ravenscar_thread_target::active_task): Now method.
15145         (ravenscar_thread_target::store_registers)
15146         (ravenscar_thread_target::prepare_to_store)
15147         (ravenscar_thread_target::prepare_to_store)
15148         (ravenscar_thread_target::mourn_inferior): Update.
15149         (ravenscar_inferior_created): Use "new" to create target.
15150         (ravenscar_thread_target::get_ada_task_ptid): Update.
15151         (_initialize_ravenscar): Don't initialize base_ptid.
15152         (ravenscar_ops): Remove global.
15153
15154 2019-02-15  Tom Tromey  <tromey@adacore.com>
15155
15156         * target.h (push_target): Declare new overload.
15157         * target.c (push_target): New overload, taking an rvalue reference.
15158         * remote.c (remote_target::open_1): Use push_target overload.
15159         * corelow.c (core_target_open): Use push_target overload.
15160
15161 2019-02-15  Tom Tromey  <tromey@adacore.com>
15162
15163         * ravenscar-thread.c (is_ravenscar_task)
15164         (ravenscar_task_is_currently_active): Return bool.
15165         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15166         (_initialize_ravenscar): Remove "(void)".
15167         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15168         Return bool.
15169
15170 2019-02-15  Tom Tromey  <tromey@adacore.com>
15171
15172         * ravenscar-thread.c (ravenscar_runtime_initializer)
15173         (has_ravenscar_runtime, get_running_thread_id)
15174         (ravenscar_thread_target::resume): Fix indentation.
15175
15176 2019-02-15  Tom Tromey  <tromey@adacore.com>
15177
15178         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15179         from ravenscar_arch_ops.
15180         (sparc_ravenscar_ops::fetch_registers)
15181         (sparc_ravenscar_ops::store_registers): Now methods.
15182         (sparc_ravenscar_prepare_to_store): Remove.
15183         (sparc_ravenscar_ops): Redefine.
15184         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15185         methods and destructor.  Remove members.
15186         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15187         (ravenscar_thread_target::store_registers)
15188         (ravenscar_thread_target::prepare_to_store): Update.
15189         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15190         Remove.
15191         (struct ppc_ravenscar_powerpc_ops): Derive from
15192         ravenscar_arch_ops.
15193         (ppc_ravenscar_powerpc_ops::fetch_registers)
15194         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15195         (ppc_ravenscar_powerpc_ops): Redefine.
15196         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15197         (ppc_ravenscar_e500_ops::fetch_registers)
15198         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15199         (ppc_ravenscar_e500_ops): Redefine.
15200         * aarch64-ravenscar-thread.c
15201         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15202         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15203         (aarch64_ravenscar_fetch_registers)
15204         (aarch64_ravenscar_store_registers): Now methods.
15205         (aarch64_ravenscar_ops): Redefine.
15206
15207 2019-02-15  Tom Tromey  <tromey@adacore.com>
15208
15209         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15210         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15211         (ravenscar_thread_target::stopped_by_watchpoint)
15212         (ravenscar_thread_target::stopped_data_address)
15213         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15214
15215 2019-02-15  Tom Tromey  <tromey@adacore.com>
15216
15217         * ravenscar-thread.c: Fix some typos.
15218
15219 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15220             Tom Tromey  <tromey@adacore.com>
15221
15222         * ada-lang.c (ada_exception_sal): Change addr_string to a
15223         std::string.
15224         (create_ada_exception_catchpoint): Update.
15225
15226 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15227             Tom Tromey  <tromey@adacore.com>
15228
15229         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15230         (bp_location_ops): Remove.
15231         (base_breakpoint_allocate_location): Update.
15232         (free_bp_location): Update.
15233         * ada-lang.c (class ada_catchpoint_location)
15234         <ada_catchpoint_location>: Remove ops parameter.
15235         (ada_catchpoint_location_dtor): Remove.
15236         (ada_catchpoint_location_ops): Remove.
15237         (allocate_location_exception): Update.
15238         * breakpoint.h (struct bp_location_ops): Remove.
15239         (class bp_location) <bp_location>: Remove bp_location_ops
15240         parameter.
15241         <~bp_location>: Add destructor.
15242         <ops>: Remove.
15243
15244 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15245             Pedro Alves  <palves@redhat.com>
15246
15247         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15248         'PATH_MAX'.
15249
15250 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15251             Samuel Thibault  <samuel.thibault@gnu.org>
15252             Thomas Schwinge  <thomas@codesourcery.com>
15253
15254         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15255         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15256
15257 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15258
15259         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15260         (check_empty): Use "const char *".
15261
15262         * gnu-nat.c (gnu_nat_target::detach): Instead of
15263         'detach_inferior (pid)' call
15264         'detach_inferior (find_inferior_pid (pid))'.
15265
15266         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15267         'nat/fork-inferior.o'.
15268         * gnu-nat.c: #include "nat/fork-inferior.h".
15269
15270         * gnu-nat.c (gnu_nat_target::detach): Instead of
15271         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15272         * gnu-nat.h: #include "inf-child.h".
15273         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15274         'i386_gnu_nat_target::fetch_registers'.
15275         (gnu_store_registers): Rename/move to
15276         'i386_gnu_nat_target::store_registers'.
15277
15278         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15279         * gnu-nat.h (mach_thread_info): New function.
15280         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15281
15282         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15283
15284 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15285
15286         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15287
15288 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15289
15290         * windows-nat.c (windows_add_thread): Add new parameter
15291         "main_thread_p" with default value set to false.  Update
15292         function documentation as well as all callers.
15293         (windows_delete_thread): Likewise.
15294         (fake_create_process): Update call to windows_add_thread.
15295         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15296         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15297         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15298         call to windows_delete_thread.
15299
15300 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15301
15302         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15303
15304 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15305
15306         * symfile.c (find_separate_debug_file): Use canonical path of
15307         sysroot with child_path instead of gdb_sysroot if it is valid.
15308
15309 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15310
15311         * symfile.c (find_separate_debug_file): Use child_path to
15312         determine if an object file is under a sysroot.
15313
15314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15315
15316         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15317         unittests/child-path-selftests.c.
15318         * common/pathstuff.c (child_path): New function.
15319         * common/pathstuff.h (child_path): New prototype.
15320         * unittests/child-path-selftests.c: New file.
15321
15322 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15323
15324         * symfile.c (find_separate_debug_file): Look for separate debug
15325         files in debug directories under the sysroot.
15326
15327 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15328
15329         * symtab.h (struct minimal_symbol data_p): New const method.
15330         (struct minimal_symbol text_p): Likewise.
15331         * symtab.c (output_source_filename): Use file name style
15332         to print file name.
15333         (print_symbol_info): Likewise.
15334         (print_msymbol_info): Use address style to print addresses.
15335         Use function name style to print executable text symbols.
15336         (expand_symtab_containing_pc): Use data_p.
15337         (find_pc_sect_compunit_symtab): Likewise.
15338
15339 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15340
15341         * breakpoint.c (describe_other_breakpoints): Use address style
15342         to print addresses.
15343         (say_where): Likewise.
15344
15345 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15346
15347         * ada-typeprint.c (print_func_type): Print function name
15348         style to print function name.
15349         * c-typeprint.c (c_print_type_1): Likewise.
15350
15351 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15352
15353         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15354         for execve.
15355
15356 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15357
15358         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15359         type_stack.
15360
15361 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15362
15363         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15364         TYPE_CODE_REF types.
15365
15366 2019-02-08  Jim Wilson  <jimw@sifive.com>
15367
15368         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15369         (riscv_linux_fregset): New.
15370         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15371
15372 2019-02-07  Tom Tromey  <tom@tromey.com>
15373
15374         * thread.c (thread_cancel_execution_command): Update.
15375         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15376         methods.
15377         (struct thread_fsm_ops): Remove.
15378         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15379         (thread_fsm_should_stop, thread_fsm_return_value)
15380         (thread_fsm_set_finished, thread_fsm_finished_p)
15381         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15382         Don't declare.
15383         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15384         * infrun.c (clear_proceed_status_thread)
15385         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15386         (print_stop_event): Update.
15387         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15388         Add constructor.
15389         (step_command_fsm_ops): Remove.
15390         (new_step_command_fsm): Remove.
15391         (step_1): Update.
15392         (step_command_fsm::should_stop): Rename from
15393         step_command_fsm_should_stop.
15394         (step_command_fsm::clean_up): Rename from
15395         step_command_fsm_clean_up.
15396         (step_command_fsm::do_async_reply_reason): Rename from
15397         step_command_fsm_async_reply_reason.
15398         (struct until_next_fsm): Inherit from thread_fsm.  Add
15399         constructor.
15400         (until_next_fsm_ops): Remove.
15401         (new_until_next_fsm): Remove.
15402         (until_next_fsm::should_stop): Rename from
15403         until_next_fsm_should_stop.
15404         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15405         (until_next_fsm::do_async_reply_reason): Rename from
15406         until_next_fsm_async_reply_reason.
15407         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15408         constructor.  Change type of breakpoint.
15409         (finish_command_fsm_ops): Remove.
15410         (new_finish_command_fsm): Remove.
15411         (finish_command_fsm::should_stop): Rename from
15412         finish_command_fsm_should_stop.
15413         (finish_command_fsm::clean_up): Rename from
15414         finish_command_fsm_clean_up.
15415         (finish_command_fsm::return_value): Rename from
15416         finish_command_fsm_return_value.
15417         (finish_command_fsm::do_async_reply_reason): Rename from
15418         finish_command_fsm_async_reply_reason.
15419         (finish_command): Update.
15420         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15421         Add constructor.
15422         (call_thread_fsm_ops): Remove.
15423         (call_thread_fsm::call_thread_fsm): Rename from
15424         new_call_thread_fsm.
15425         (call_thread_fsm::should_stop): Rename from
15426         call_thread_fsm_should_stop.
15427         (call_thread_fsm::should_notify_stop): Rename from
15428         call_thread_fsm_should_notify_stop.
15429         (run_inferior_call, call_function_by_hand_dummy): Update.
15430         * cli/cli-interp.c (should_print_stop_to_console): Update.
15431         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15432         Add constructor.  Change type of location_breakpoint,
15433         caller_breakpoint.
15434         (until_break_fsm_ops): Remove.
15435         (new_until_break_fsm): Remove.
15436         (until_break_fsm::should_stop): Rename from
15437         until_break_fsm_should_stop.
15438         (until_break_fsm::clean_up): Rename from
15439         until_break_fsm_clean_up.
15440         (until_break_fsm::do_async_reply_reason): Rename from
15441         until_break_fsm_async_reply_reason.
15442         (until_break_command): Update.
15443         * thread-fsm.c: Remove.
15444         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15445
15446 2019-02-07  Tom Tromey  <tom@tromey.com>
15447
15448         * yy-remap.h: Add include guard.
15449         * xtensa-tdep.h: Add include guard.
15450         * xcoffread.h: Rename include guard.
15451         * varobj-iter.h: Add include guard.
15452         * tui/tui.h: Rename include guard.
15453         * tui/tui-winsource.h: Rename include guard.
15454         * tui/tui-wingeneral.h: Rename include guard.
15455         * tui/tui-windata.h: Rename include guard.
15456         * tui/tui-win.h: Rename include guard.
15457         * tui/tui-stack.h: Rename include guard.
15458         * tui/tui-source.h: Rename include guard.
15459         * tui/tui-regs.h: Rename include guard.
15460         * tui/tui-out.h: Rename include guard.
15461         * tui/tui-layout.h: Rename include guard.
15462         * tui/tui-io.h: Rename include guard.
15463         * tui/tui-hooks.h: Rename include guard.
15464         * tui/tui-file.h: Rename include guard.
15465         * tui/tui-disasm.h: Rename include guard.
15466         * tui/tui-data.h: Rename include guard.
15467         * tui/tui-command.h: Rename include guard.
15468         * tic6x-tdep.h: Add include guard.
15469         * target/waitstatus.h: Rename include guard.
15470         * target/wait.h: Rename include guard.
15471         * target/target.h: Rename include guard.
15472         * target/resume.h: Rename include guard.
15473         * target-float.h: Rename include guard.
15474         * stabsread.h: Add include guard.
15475         * rs6000-tdep.h: Add include guard.
15476         * riscv-fbsd-tdep.h: Add include guard.
15477         * regformats/regdef.h: Rename include guard.
15478         * record.h: Rename include guard.
15479         * python/python.h: Rename include guard.
15480         * python/python-internal.h: Rename include guard.
15481         * python/py-stopevent.h: Rename include guard.
15482         * python/py-ref.h: Rename include guard.
15483         * python/py-record.h: Rename include guard.
15484         * python/py-record-full.h: Rename include guard.
15485         * python/py-record-btrace.h: Rename include guard.
15486         * python/py-instruction.h: Rename include guard.
15487         * python/py-events.h: Rename include guard.
15488         * python/py-event.h: Rename include guard.
15489         * procfs.h: Add include guard.
15490         * proc-utils.h: Add include guard.
15491         * p-lang.h: Add include guard.
15492         * or1k-tdep.h: Rename include guard.
15493         * observable.h: Rename include guard.
15494         * nto-tdep.h: Rename include guard.
15495         * nat/x86-linux.h: Rename include guard.
15496         * nat/x86-linux-dregs.h: Rename include guard.
15497         * nat/x86-gcc-cpuid.h: Add include guard.
15498         * nat/x86-dregs.h: Rename include guard.
15499         * nat/x86-cpuid.h: Rename include guard.
15500         * nat/ppc-linux.h: Rename include guard.
15501         * nat/mips-linux-watch.h: Rename include guard.
15502         * nat/linux-waitpid.h: Rename include guard.
15503         * nat/linux-ptrace.h: Rename include guard.
15504         * nat/linux-procfs.h: Rename include guard.
15505         * nat/linux-osdata.h: Rename include guard.
15506         * nat/linux-nat.h: Rename include guard.
15507         * nat/linux-namespaces.h: Rename include guard.
15508         * nat/linux-btrace.h: Rename include guard.
15509         * nat/glibc_thread_db.h: Rename include guard.
15510         * nat/gdb_thread_db.h: Rename include guard.
15511         * nat/gdb_ptrace.h: Rename include guard.
15512         * nat/fork-inferior.h: Rename include guard.
15513         * nat/amd64-linux-siginfo.h: Rename include guard.
15514         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15515         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15516         * nat/aarch64-linux.h: Rename include guard.
15517         * nat/aarch64-linux-hw-point.h: Rename include guard.
15518         * mn10300-tdep.h: Add include guard.
15519         * mips-linux-tdep.h: Add include guard.
15520         * mi/mi-parse.h: Rename include guard.
15521         * mi/mi-out.h: Rename include guard.
15522         * mi/mi-main.h: Rename include guard.
15523         * mi/mi-interp.h: Rename include guard.
15524         * mi/mi-getopt.h: Rename include guard.
15525         * mi/mi-console.h: Rename include guard.
15526         * mi/mi-common.h: Rename include guard.
15527         * mi/mi-cmds.h: Rename include guard.
15528         * mi/mi-cmd-break.h: Rename include guard.
15529         * m2-lang.h: Add include guard.
15530         * location.h: Rename include guard.
15531         * linux-record.h: Rename include guard.
15532         * linux-nat.h: Add include guard.
15533         * linux-fork.h: Add include guard.
15534         * i386-darwin-tdep.h: Rename include guard.
15535         * hppa-linux-offsets.h: Add include guard.
15536         * guile/guile.h: Rename include guard.
15537         * guile/guile-internal.h: Rename include guard.
15538         * gnu-nat.h: Rename include guard.
15539         * gdb-stabs.h: Rename include guard.
15540         * frv-tdep.h: Add include guard.
15541         * f-lang.h: Add include guard.
15542         * event-loop.h: Add include guard.
15543         * darwin-nat.h: Rename include guard.
15544         * cp-abi.h: Rename include guard.
15545         * config/sparc/nm-sol2.h: Rename include guard.
15546         * config/nm-nto.h: Rename include guard.
15547         * config/nm-linux.h: Add include guard.
15548         * config/i386/nm-i386gnu.h: Rename include guard.
15549         * config/djgpp/nl_types.h: Rename include guard.
15550         * config/djgpp/langinfo.h: Rename include guard.
15551         * compile/gcc-cp-plugin.h: Add include guard.
15552         * compile/gcc-c-plugin.h: Add include guard.
15553         * compile/compile.h: Rename include guard.
15554         * compile/compile-object-run.h: Rename include guard.
15555         * compile/compile-object-load.h: Rename include guard.
15556         * compile/compile-internal.h: Rename include guard.
15557         * compile/compile-cplus.h: Rename include guard.
15558         * compile/compile-c.h: Rename include guard.
15559         * common/xml-utils.h: Rename include guard.
15560         * common/x86-xstate.h: Rename include guard.
15561         * common/version.h: Rename include guard.
15562         * common/vec.h: Rename include guard.
15563         * common/tdesc.h: Rename include guard.
15564         * common/selftest.h: Rename include guard.
15565         * common/scoped_restore.h: Rename include guard.
15566         * common/scoped_mmap.h: Rename include guard.
15567         * common/scoped_fd.h: Rename include guard.
15568         * common/safe-iterator.h: Rename include guard.
15569         * common/run-time-clock.h: Rename include guard.
15570         * common/refcounted-object.h: Rename include guard.
15571         * common/queue.h: Rename include guard.
15572         * common/ptid.h: Rename include guard.
15573         * common/print-utils.h: Rename include guard.
15574         * common/preprocessor.h: Rename include guard.
15575         * common/pathstuff.h: Rename include guard.
15576         * common/observable.h: Rename include guard.
15577         * common/netstuff.h: Rename include guard.
15578         * common/job-control.h: Rename include guard.
15579         * common/host-defs.h: Rename include guard.
15580         * common/gdb_wait.h: Rename include guard.
15581         * common/gdb_vecs.h: Rename include guard.
15582         * common/gdb_unlinker.h: Rename include guard.
15583         * common/gdb_unique_ptr.h: Rename include guard.
15584         * common/gdb_tilde_expand.h: Rename include guard.
15585         * common/gdb_sys_time.h: Rename include guard.
15586         * common/gdb_string_view.h: Rename include guard.
15587         * common/gdb_splay_tree.h: Rename include guard.
15588         * common/gdb_setjmp.h: Rename include guard.
15589         * common/gdb_ref_ptr.h: Rename include guard.
15590         * common/gdb_optional.h: Rename include guard.
15591         * common/gdb_locale.h: Rename include guard.
15592         * common/gdb_assert.h: Rename include guard.
15593         * common/filtered-iterator.h: Rename include guard.
15594         * common/filestuff.h: Rename include guard.
15595         * common/fileio.h: Rename include guard.
15596         * common/environ.h: Rename include guard.
15597         * common/common-utils.h: Rename include guard.
15598         * common/common-types.h: Rename include guard.
15599         * common/common-regcache.h: Rename include guard.
15600         * common/common-inferior.h: Rename include guard.
15601         * common/common-gdbthread.h: Rename include guard.
15602         * common/common-exceptions.h: Rename include guard.
15603         * common/common-defs.h: Rename include guard.
15604         * common/common-debug.h: Rename include guard.
15605         * common/cleanups.h: Rename include guard.
15606         * common/buffer.h: Rename include guard.
15607         * common/btrace-common.h: Rename include guard.
15608         * common/break-common.h: Rename include guard.
15609         * cli/cli-utils.h: Rename include guard.
15610         * cli/cli-style.h: Rename include guard.
15611         * cli/cli-setshow.h: Rename include guard.
15612         * cli/cli-script.h: Rename include guard.
15613         * cli/cli-interp.h: Rename include guard.
15614         * cli/cli-decode.h: Rename include guard.
15615         * cli/cli-cmds.h: Rename include guard.
15616         * charset-list.h: Add include guard.
15617         * buildsym-legacy.h: Rename include guard.
15618         * bfin-tdep.h: Add include guard.
15619         * ax.h: Rename include guard.
15620         * arm-linux-tdep.h: Add include guard.
15621         * arm-fbsd-tdep.h: Add include guard.
15622         * arch/xtensa.h: Rename include guard.
15623         * arch/tic6x.h: Add include guard.
15624         * arch/i386.h: Add include guard.
15625         * arch/arm.h: Rename include guard.
15626         * arch/arm-linux.h: Rename include guard.
15627         * arch/arm-get-next-pcs.h: Rename include guard.
15628         * arch/amd64.h: Add include guard.
15629         * arch/aarch64-insn.h: Rename include guard.
15630         * arch-utils.h: Rename include guard.
15631         * annotate.h: Add include guard.
15632         * amd64-darwin-tdep.h: Rename include guard.
15633         * aarch64-linux-tdep.h: Add include guard.
15634         * aarch64-fbsd-tdep.h: Add include guard.
15635         * aarch32-linux-nat.h: Add include guard.
15636
15637 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15638
15639         * macrotab.c (macro_define_internal): New function that
15640         factorizes macro_define_object_internal and macro_define_function
15641         code.
15642         (macro_define_object_internal): Use macro_define_internal.
15643         (macro_define_function): Likewise.
15644
15645 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15646
15647         * macrocmd.c (extract_identifier): Return
15648         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15649         callers.
15650
15651 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15652
15653         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15654
15655 2019-02-05  Tom Tromey  <tom@tromey.com>
15656
15657         * target.c (target_stack::unpush): Move assertion earlier.
15658
15659 2019-01-30  Tom Tromey  <tom@tromey.com>
15660
15661         PR python/23615:
15662         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15663         (gdbpy_parse_and_eval): Likewise.
15664         * python/python-internal.h (gdbpy_allow_threads): New class.
15665
15666 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15667
15668         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15669         (aarch64_fbsd_fpregmap): Move earlier.
15670         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15671         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15672         instead of individual calls to trad_frame_set_reg_addr.
15673         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15674         earlier.
15675         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15676         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15677         instead of individual calls to trad_frame_set_reg_addr.
15678
15679 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15680
15681         * CONTRIBUTE: Replace contribution list with wiki link.
15682
15683 2019-01-25  Tom Tromey  <tom@tromey.com>
15684
15685         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15686
15687 2019-01-25  Tom Tromey  <tom@tromey.com>
15688
15689         * xtensa-linux-nat.c: Fix common/ includes.
15690         * xml-support.h: Fix common/ includes.
15691         * xml-support.c: Fix common/ includes.
15692         * x86-linux-nat.c: Fix common/ includes.
15693         * windows-nat.c: Fix common/ includes.
15694         * varobj.h: Fix common/ includes.
15695         * varobj.c: Fix common/ includes.
15696         * value.c: Fix common/ includes.
15697         * valops.c: Fix common/ includes.
15698         * utils.c: Fix common/ includes.
15699         * unittests/xml-utils-selftests.c: Fix common/ includes.
15700         * unittests/utils-selftests.c: Fix common/ includes.
15701         * unittests/unpack-selftests.c: Fix common/ includes.
15702         * unittests/tracepoint-selftests.c: Fix common/ includes.
15703         * unittests/style-selftests.c: Fix common/ includes.
15704         * unittests/string_view-selftests.c: Fix common/ includes.
15705         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15706         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15707         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15708         * unittests/rsp-low-selftests.c: Fix common/ includes.
15709         * unittests/parse-connection-spec-selftests.c: Fix common/
15710         includes.
15711         * unittests/optional-selftests.c: Fix common/ includes.
15712         * unittests/offset-type-selftests.c: Fix common/ includes.
15713         * unittests/observable-selftests.c: Fix common/ includes.
15714         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15715         * unittests/memrange-selftests.c: Fix common/ includes.
15716         * unittests/memory-map-selftests.c: Fix common/ includes.
15717         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15718         * unittests/function-view-selftests.c: Fix common/ includes.
15719         * unittests/environ-selftests.c: Fix common/ includes.
15720         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15721         * unittests/common-utils-selftests.c: Fix common/ includes.
15722         * unittests/cli-utils-selftests.c: Fix common/ includes.
15723         * unittests/array-view-selftests.c: Fix common/ includes.
15724         * ui-file.c: Fix common/ includes.
15725         * tui/tui-io.c: Fix common/ includes.
15726         * tracepoint.h: Fix common/ includes.
15727         * tracepoint.c: Fix common/ includes.
15728         * tracefile-tfile.c: Fix common/ includes.
15729         * top.h: Fix common/ includes.
15730         * top.c: Fix common/ includes.
15731         * thread.c: Fix common/ includes.
15732         * target/waitstatus.h: Fix common/ includes.
15733         * target/waitstatus.c: Fix common/ includes.
15734         * target.h: Fix common/ includes.
15735         * target.c: Fix common/ includes.
15736         * target-memory.c: Fix common/ includes.
15737         * target-descriptions.c: Fix common/ includes.
15738         * symtab.h: Fix common/ includes.
15739         * symfile.c: Fix common/ includes.
15740         * stap-probe.c: Fix common/ includes.
15741         * spu-linux-nat.c: Fix common/ includes.
15742         * sparc-nat.c: Fix common/ includes.
15743         * source.c: Fix common/ includes.
15744         * solib.c: Fix common/ includes.
15745         * solib-target.c: Fix common/ includes.
15746         * ser-unix.c: Fix common/ includes.
15747         * ser-tcp.c: Fix common/ includes.
15748         * ser-pipe.c: Fix common/ includes.
15749         * ser-base.c: Fix common/ includes.
15750         * selftest-arch.c: Fix common/ includes.
15751         * s12z-tdep.c: Fix common/ includes.
15752         * rust-exp.y: Fix common/ includes.
15753         * rs6000-aix-tdep.c: Fix common/ includes.
15754         * riscv-tdep.c: Fix common/ includes.
15755         * remote.c: Fix common/ includes.
15756         * remote-notif.h: Fix common/ includes.
15757         * remote-fileio.h: Fix common/ includes.
15758         * remote-fileio.c: Fix common/ includes.
15759         * regcache.h: Fix common/ includes.
15760         * regcache.c: Fix common/ includes.
15761         * record-btrace.c: Fix common/ includes.
15762         * python/python.c: Fix common/ includes.
15763         * python/py-type.c: Fix common/ includes.
15764         * python/py-inferior.c: Fix common/ includes.
15765         * progspace.h: Fix common/ includes.
15766         * producer.c: Fix common/ includes.
15767         * procfs.c: Fix common/ includes.
15768         * proc-api.c: Fix common/ includes.
15769         * printcmd.c: Fix common/ includes.
15770         * ppc-linux-nat.c: Fix common/ includes.
15771         * parser-defs.h: Fix common/ includes.
15772         * osdata.c: Fix common/ includes.
15773         * obsd-nat.c: Fix common/ includes.
15774         * nat/x86-linux.c: Fix common/ includes.
15775         * nat/x86-linux-dregs.c: Fix common/ includes.
15776         * nat/x86-dregs.h: Fix common/ includes.
15777         * nat/x86-dregs.c: Fix common/ includes.
15778         * nat/ppc-linux.c: Fix common/ includes.
15779         * nat/mips-linux-watch.h: Fix common/ includes.
15780         * nat/mips-linux-watch.c: Fix common/ includes.
15781         * nat/linux-waitpid.c: Fix common/ includes.
15782         * nat/linux-ptrace.h: Fix common/ includes.
15783         * nat/linux-ptrace.c: Fix common/ includes.
15784         * nat/linux-procfs.c: Fix common/ includes.
15785         * nat/linux-personality.c: Fix common/ includes.
15786         * nat/linux-osdata.c: Fix common/ includes.
15787         * nat/linux-namespaces.c: Fix common/ includes.
15788         * nat/linux-btrace.h: Fix common/ includes.
15789         * nat/linux-btrace.c: Fix common/ includes.
15790         * nat/fork-inferior.c: Fix common/ includes.
15791         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15792         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15793         * nat/aarch64-linux.c: Fix common/ includes.
15794         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15795         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15796         * namespace.h: Fix common/ includes.
15797         * mips-linux-tdep.c: Fix common/ includes.
15798         * minsyms.c: Fix common/ includes.
15799         * mi/mi-parse.h: Fix common/ includes.
15800         * mi/mi-main.c: Fix common/ includes.
15801         * mi/mi-cmd-env.c: Fix common/ includes.
15802         * memrange.h: Fix common/ includes.
15803         * memattr.c: Fix common/ includes.
15804         * maint.h: Fix common/ includes.
15805         * maint.c: Fix common/ includes.
15806         * main.c: Fix common/ includes.
15807         * machoread.c: Fix common/ includes.
15808         * location.c: Fix common/ includes.
15809         * linux-thread-db.c: Fix common/ includes.
15810         * linux-nat.c: Fix common/ includes.
15811         * linux-fork.c: Fix common/ includes.
15812         * inline-frame.c: Fix common/ includes.
15813         * infrun.c: Fix common/ includes.
15814         * inflow.c: Fix common/ includes.
15815         * inferior.h: Fix common/ includes.
15816         * inferior.c: Fix common/ includes.
15817         * infcmd.c: Fix common/ includes.
15818         * inf-ptrace.c: Fix common/ includes.
15819         * inf-child.c: Fix common/ includes.
15820         * ia64-linux-nat.c: Fix common/ includes.
15821         * i387-tdep.c: Fix common/ includes.
15822         * i386-tdep.c: Fix common/ includes.
15823         * i386-linux-tdep.c: Fix common/ includes.
15824         * i386-linux-nat.c: Fix common/ includes.
15825         * i386-go32-tdep.c: Fix common/ includes.
15826         * i386-fbsd-tdep.c: Fix common/ includes.
15827         * i386-fbsd-nat.c: Fix common/ includes.
15828         * guile/scm-type.c: Fix common/ includes.
15829         * guile/guile.c: Fix common/ includes.
15830         * go32-nat.c: Fix common/ includes.
15831         * gnu-nat.c: Fix common/ includes.
15832         * gdbthread.h: Fix common/ includes.
15833         * gdbarch-selftests.c: Fix common/ includes.
15834         * gdb_usleep.c: Fix common/ includes.
15835         * gdb_select.h: Fix common/ includes.
15836         * gdb_bfd.c: Fix common/ includes.
15837         * gcore.c: Fix common/ includes.
15838         * fork-child.c: Fix common/ includes.
15839         * findvar.c: Fix common/ includes.
15840         * fbsd-nat.c: Fix common/ includes.
15841         * event-top.c: Fix common/ includes.
15842         * event-loop.c: Fix common/ includes.
15843         * dwarf2read.c: Fix common/ includes.
15844         * dwarf2loc.c: Fix common/ includes.
15845         * dwarf2-frame.c: Fix common/ includes.
15846         * dwarf-index-cache.c: Fix common/ includes.
15847         * dtrace-probe.c: Fix common/ includes.
15848         * disasm-selftests.c: Fix common/ includes.
15849         * defs.h: Fix common/ includes.
15850         * csky-tdep.c: Fix common/ includes.
15851         * cp-valprint.c: Fix common/ includes.
15852         * cp-support.h: Fix common/ includes.
15853         * cp-support.c: Fix common/ includes.
15854         * corelow.c: Fix common/ includes.
15855         * completer.h: Fix common/ includes.
15856         * completer.c: Fix common/ includes.
15857         * compile/compile.c: Fix common/ includes.
15858         * compile/compile-loc2c.c: Fix common/ includes.
15859         * compile/compile-cplus-types.c: Fix common/ includes.
15860         * compile/compile-cplus-symbols.c: Fix common/ includes.
15861         * command.h: Fix common/ includes.
15862         * cli/cli-dump.c: Fix common/ includes.
15863         * cli/cli-cmds.c: Fix common/ includes.
15864         * charset.c: Fix common/ includes.
15865         * build-id.c: Fix common/ includes.
15866         * btrace.h: Fix common/ includes.
15867         * btrace.c: Fix common/ includes.
15868         * breakpoint.h: Fix common/ includes.
15869         * breakpoint.c: Fix common/ includes.
15870         * ax.h:
15871         (enum agent_op): Fix common/ includes.
15872         * ax-general.c (struct aop_map): Fix common/ includes.
15873         * ax-gdb.c: Fix common/ includes.
15874         * auxv.c: Fix common/ includes.
15875         * auto-load.c: Fix common/ includes.
15876         * arm-tdep.c: Fix common/ includes.
15877         * arch/riscv.c: Fix common/ includes.
15878         * arch/ppc-linux-common.c: Fix common/ includes.
15879         * arch/i386.c: Fix common/ includes.
15880         * arch/arm.c: Fix common/ includes.
15881         * arch/arm-linux.c: Fix common/ includes.
15882         * arch/arm-get-next-pcs.c: Fix common/ includes.
15883         * arch/amd64.c: Fix common/ includes.
15884         * arch/aarch64.c: Fix common/ includes.
15885         * arch/aarch64-insn.c: Fix common/ includes.
15886         * arch-utils.c: Fix common/ includes.
15887         * amd64-windows-tdep.c: Fix common/ includes.
15888         * amd64-tdep.c: Fix common/ includes.
15889         * amd64-sol2-tdep.c: Fix common/ includes.
15890         * amd64-obsd-tdep.c: Fix common/ includes.
15891         * amd64-nbsd-tdep.c: Fix common/ includes.
15892         * amd64-linux-tdep.c: Fix common/ includes.
15893         * amd64-linux-nat.c: Fix common/ includes.
15894         * amd64-fbsd-tdep.c: Fix common/ includes.
15895         * amd64-fbsd-nat.c: Fix common/ includes.
15896         * amd64-dicos-tdep.c: Fix common/ includes.
15897         * amd64-darwin-tdep.c: Fix common/ includes.
15898         * agent.c: Fix common/ includes.
15899         * ada-lang.h: Fix common/ includes.
15900         * ada-lang.c: Fix common/ includes.
15901         * aarch64-tdep.c: Fix common/ includes.
15902
15903 2019-01-25  Tom Tromey  <tom@tromey.com>
15904
15905         * common/create-version.sh: Use common/version.h.
15906
15907 2019-01-24  Pedro Alves  <palves@redhat.com>
15908
15909         * infrun.c (signal_stop, signal_print, signal_program)
15910         (signal_catch, signal_pass): Now arrays instead of pointers.
15911         (update_signals_program_target, do_target_resume)
15912         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15913         * linux-nat.c (linux_nat_target::pass_signals)
15914         (linux_nat_target::create_inferior, linux_nat_target::attach):
15915         Adjust.
15916         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15917         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15918         * procfs.c (procfs_target::pass_signals): Adjust.
15919         * record-full.c (record_full_target::resume): Adjust.
15920         * remote.c (remote_target::pass_signals)
15921         (remote_target::program_signals): Adjust.
15922         * target-debug.h (target_debug_print_signals): Now takes a
15923         gdb::array_view as parameter.  Adjust.
15924         * target.h (target_ops) <pass_signals, program_signals>: Replace
15925         pointer and length parameters with gdb::array_view.
15926         (target_pass_signals, target_program_signals): Likewise.
15927         * target-delegates.c: Regenerate.
15928
15929 2019-01-24  Pedro Alves  <palves@redhat.com>
15930
15931         * common/forward-scope-exit.h
15932         (forward_scope_exit::forward_scope_exit): Pass arguments to
15933         m_bind_function directly, instead of creating a std::bind and
15934         copying that.
15935
15936 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15937
15938         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15939         for static members.
15940         (pass_in_v_vfp_candidate): Likewise.
15941
15942 2019-01-23  Tom Tromey  <tom@tromey.com>
15943             Pedro Alves  <palves@redhat.com>
15944
15945         * regcache.c (class regcache_invalidator): Remove.
15946         (regcache::raw_write): Use make_scope_exit.
15947
15948 2019-01-23  Tom Tromey  <tom@tromey.com>
15949
15950         * ui-out.h (class ui_out_emit_type): Update comment.
15951
15952 2019-01-23  Tom Tromey  <tom@tromey.com>
15953
15954         * infrun.c (fetch_inferior_event): Update comment.
15955
15956 2019-01-23  Tom Tromey  <tom@tromey.com>
15957             Pedro Alves  <palves@redhat.com>
15958
15959         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15960         parameter.
15961         (fetch_inferior_event): Use SCOPE_EXIT.
15962
15963
15964 2019-01-23  Tom Tromey  <tom@tromey.com>
15965             Pedro Alves  <palves@redhat.com>
15966
15967         * infrun.c (disable_thread_events): Delete.
15968         (stop_all_threads): Use SCOPE_EXIT.
15969
15970 2019-01-23  Tom Tromey  <tom@tromey.com>
15971             Pedro Alves  <palves@redhat.com>
15972
15973         * symfile.c: Include forward-scope-exit.h.
15974         (clear_symtab_users_cleanup): Replace forward declaration with
15975         a FORWARD_SCOPE_EXIT.
15976         (syms_from_objfile_1): Use the forward_scope_exit and
15977         gdb::optional instead of cleanup_function.
15978         (reread_symbols): Use the forward_scope_exit instead of
15979         cleanup_function.
15980         (clear_symtab_users_cleanup): Remove function.
15981
15982 2019-01-23  Tom Tromey  <tom@tromey.com>
15983             Pedro Alves  <palves@redhat.com>
15984
15985         * linux-nat.c: Include scope-exit.h.
15986         (cleanup_target_stop): Remove.
15987         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15988         SCOPE_EXIT.
15989
15990 2019-01-23  Tom Tromey  <tom@tromey.com>
15991             Pedro Alves  <palves@redhat.com>
15992
15993         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15994         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15995
15996 2019-01-23  Tom Tromey  <tom@tromey.com>
15997             Andrew Burgess  <andrew.burgess@embecosm.com>
15998             Pedro Alves  <palves@redhat.com>
15999
16000         * infrun.c (fetch_inferior_event): Use scope_exit.
16001         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
16002         * top.c (execute_command): Use scope_exit.
16003         * breakpoint.c (bpstat_do_actions): Use scope_exit.
16004         * utils.c (do_bpstat_clear_actions_cleanup)
16005         (make_bpstat_clear_actions_cleanup): Remove.
16006
16007 2019-01-23  Tom Tromey  <tom@tromey.com>
16008             Pedro Alves  <palves@redhat.com>
16009
16010         * infrun.c: Include "common/scope-exit.h"
16011         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
16012         (wait_for_inferior): Use SCOPE_EXIT.
16013         (fetch_inferior_event): Use scope_exit.
16014
16015 2019-01-23  Tom Tromey  <tom@tromey.com>
16016             Pedro Alves  <palves@redhat.com>
16017
16018         * breakpoint.c (create_breakpoint): Remove cleanup.
16019
16020 2019-01-23  Tom Tromey  <tom@tromey.com>
16021             Andrew Burgess  <andrew.burgess@embecosm.com>
16022             Pedro Alves  <palves@redhat.com>
16023
16024 2019-01-23  Pedro Alves  <palves@redhat.com>
16025
16026         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
16027
16028 2019-01-23  Pedro Alves  <palves@redhat.com>
16029             Andrew Burgess  <andrew.burgess@embecosm.com>
16030
16031         * gdbthread.h: Include "common/forward-scope-exit.h".
16032         (scoped_finish_thread_state): Redefine custom class in terms of
16033         forward_scope_exit.
16034
16035 2019-01-23  Pedro Alves  <palves@redhat.com>
16036             Andrew Burgess  <andrew.burgess@embecosm.com>
16037
16038         * common/forward-scope-exit.h: New file.
16039
16040 2019-01-23  Pedro Alves  <palves@redhat.com>
16041             Andrew Burgess  <andrew.burgess@embecosm.com>
16042             Tom Tromey  <tom@tromey.com>
16043
16044         * common/scope-exit.h: New file.
16045
16046 2019-01-23  Pedro Alves  <palves@redhat.com>
16047
16048         * common/preprocessor.h (ESC): Rename to ...
16049         (ESC_PARENS): ... this.
16050         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
16051         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
16052
16053 2019-01-23  Tom Tromey  <tom@tromey.com>
16054
16055         * language.h (class scoped_switch_to_sym_language_if_auto):
16056         Initialize m_lang in both cases.
16057
16058 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
16059
16060         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
16061         with XCNEW.
16062
16063 2019-01-22  Tom Tromey  <tom@tromey.com>
16064
16065         * corelow.c: Do not include sys/file.h.
16066
16067 2019-01-22  Tom Tromey  <tom@tromey.com>
16068
16069         * tui/tui-wingeneral.h: Include gdb_curses.h.
16070
16071 2019-01-22  Tom Tromey  <tom@tromey.com>
16072
16073         * source-cache.h (class source_cache) <get_source_lines,
16074         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16075
16076 2019-01-22  Tom Tromey  <tom@tromey.com>
16077
16078         * remote-fileio.h (struct remote_target): Declare.
16079
16080 2019-01-22  Tom Tromey  <tom@tromey.com>
16081
16082         * python/py-arch.c: Do not include py-ref.h.
16083         * python/py-bpevent.c: Do not include py-ref.h.
16084         * python/py-cmd.c: Do not include py-ref.h.
16085         * python/py-continueevent.c: Do not include py-ref.h.
16086         * python/py-event.h: Do not include py-ref.h.
16087         * python/py-evtregistry.c: Do not include py-ref.h.
16088         * python/py-finishbreakpoint.c: Do not include py-ref.h.
16089         * python/py-frame.c: Do not include py-ref.h.
16090         * python/py-framefilter.c: Do not include py-ref.h.
16091         * python/py-function.c: Do not include py-ref.h.
16092         * python/py-infevents.c: Do not include py-ref.h.
16093         * python/py-linetable.c: Do not include py-ref.h.
16094         * python/py-objfile.c: Do not include py-ref.h.
16095         * python/py-param.c: Do not include py-ref.h.
16096         * python/py-prettyprint.c: Do not include py-ref.h.
16097         * python/py-progspace.c: Do not include py-ref.h.
16098         * python/py-symbol.c: Do not include py-ref.h.
16099         * python/py-symtab.c: Do not include py-ref.h.
16100         * python/py-type.c: Do not include py-ref.h.
16101         * python/py-unwind.c: Do not include py-ref.h.
16102         * python/py-utils.c: Do not include py-ref.h.
16103         * python/py-value.c: Do not include py-ref.h.
16104         * python/py-varobj.c: Do not include py-ref.h.
16105         * python/py-xmethods.c: Do not include py-ref.h.
16106         * python/python.c: Do not include py-ref.h.
16107         * varobj.c: Do not include py-ref.h.
16108
16109 2019-01-22  Tom Tromey  <tom@tromey.com>
16110
16111         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16112         keyword for bcache.
16113
16114 2019-01-22  Tom Tromey  <tom@tromey.com>
16115
16116         * compile/compile-cplus-types.c: Remove a comment by #include.
16117
16118 2019-01-22  Tom Tromey  <tom@tromey.com>
16119
16120         * compile/gcc-c-plugin.h: Include compile-internal.h.
16121
16122 2019-01-22  Tom Tromey  <tom@tromey.com>
16123
16124         * stabsread.c (EXTERN): Do not define.
16125         (symnum, next_symbol_text_func, processing_gcc_compilation)
16126         (within_function, global_sym_chain, global_stabs)
16127         (previous_stab_code, this_object_header_files)
16128         (n_this_object_header_files)
16129         (n_allocated_this_object_header_files): Define.
16130         * stabsread.h (EXTERN): Never define.  Use "extern".
16131
16132 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16133
16134         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16135         history_value.
16136
16137 2019-01-21  Tom Tromey  <tom@tromey.com>
16138
16139         * ui-out.c: Fix includes.
16140         * tui/tui-source.c: Fix includes.
16141         * target.c: Fix includes.
16142         * remote.c: Fix includes.
16143         * regcache.c: Fix includes.
16144         * python/py-block.c: Fix includes.
16145         * printcmd.c: Fix includes.
16146         * or1k-tdep.c: Fix includes.
16147         * mi/mi-main.c: Fix includes.
16148         * m32r-tdep.c: Fix includes.
16149         * csky-tdep.c: Fix includes.
16150         * compile/compile-cplus-types.c: Fix includes.
16151         * cli/cli-interp.c: Fix includes.
16152
16153 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
16154
16155         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16156         for padding.
16157
16158 2019-01-16  Tom Tromey  <tom@tromey.com>
16159
16160         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
16161         earlier.
16162         (struct objfile) <msymbols_range>: Move from top level.
16163         <msymbols>: New method.
16164         (class objfile_msymbols): Remove.
16165         * symtab.c (default_collect_symbol_completion_matches_break_on):
16166         Update.
16167         * symmisc.c (dump_msymbols): Update.
16168         * stabsread.c (scan_file_globals): Update.
16169         * objc-lang.c (info_selectors_command, info_classes_command)
16170         (find_methods): Update.
16171         * minsyms.c (find_solib_trampoline_target): Update.
16172         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16173         * coffread.c (coff_symfile_read): Update.
16174         * ada-lang.c (ada_lookup_simple_minsym)
16175         (ada_collect_symbol_completion_matches): Update.
16176
16177 2019-01-16  Tom Tromey  <tom@tromey.com>
16178
16179         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16180         type.  Remove no-argument constructor.
16181         <iterator::operator++>: Simplify.
16182         <begin>: Update.
16183         <end>: Use minimal_symbol_count.
16184
16185 2019-01-16  Tom Tromey  <tom@tromey.com>
16186
16187         * objfiles.h (struct objfile) <psymtabs>: New method.
16188         (class objfile_psymtabs): Remove.
16189         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16190         typedef.
16191         <range>: New method.
16192         (require_partial_symbols): Change return type.
16193         * psymtab.c (require_partial_symbols)
16194         (psym_expand_symtabs_matching): Update.
16195         * mdebugread.c (parse_partial_symbols): Update.
16196         * dbxread.c (dbx_end_psymtab): Update.
16197
16198 2019-01-15  Tom Tromey  <tom@tromey.com>
16199
16200         * symtab.c (lookup_objfile_from_block)
16201         (lookup_symbol_in_objfile_symtabs)
16202         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16203         (find_line_symtab, info_sources_command)
16204         (default_collect_symbol_completion_matches_break_on)
16205         (make_source_files_completion_list): Update.
16206         * symmisc.c (print_objfile_statistics, dump_objfile)
16207         (maintenance_print_symbols, maintenance_info_symtabs)
16208         (maintenance_check_symtabs, maintenance_info_line_tables):
16209         Update.
16210         * source.c (select_source_symtab)
16211         (forget_cached_source_info_for_objfile): Update.
16212         * objfiles.h (class objfile_compunits): Remove.
16213         (struct objfile) <compunits_range>: New typedef.
16214         (compunits): New method.
16215         * objfiles.c (objfile_relocate1): Update.
16216         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16217         * maint.c (count_symtabs_and_blocks): Update.
16218         * linespec.c (iterate_over_all_matching_symtabs): Update.
16219         * cp-support.c (add_symbol_overload_list_qualified): Update.
16220         * coffread.c (coff_symtab_read): Update.
16221         * ada-lang.c (add_nonlocal_symbols)
16222         (ada_collect_symbol_completion_matches)
16223         (ada_add_global_exceptions): Update.
16224
16225 2019-01-15  Tom Tromey  <tom@tromey.com>
16226
16227         * progspace.h (program_space) <objfiles_safe_range>: New
16228         typedef.
16229         <objfiles_safe>: New method.
16230         * objfiles.h (class all_objfiles_safe): Remove.
16231         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16232         * jit.c (jit_inferior_exit_hook): Update.
16233
16234 2019-01-17  Tom Tromey  <tom@tromey.com>
16235
16236         * progspace.h (program_space) <objfiles_range>: New typedef.
16237         <objfiles>: New method.
16238         <objfiles_head>: Rename from objfiles.
16239         (object_files): Update.
16240         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16241         * guile/scm-pretty-print.c
16242         (ppscm_find_pretty_printer_from_objfiles): Update.
16243         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16244         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16245         Update.
16246         * python/py-progspace.c (pspy_get_objfiles): Update.
16247         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16248         Update.
16249         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16250         (objfpy_lookup_objfile_by_build_id): Update.
16251         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16252         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16253         Update.
16254         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16255         (expand_symtab_containing_pc, lookup_objfile_from_block)
16256         (lookup_static_symbol, basic_lookup_transparent_type)
16257         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16258         (find_line_symtab, info_sources_command)
16259         (default_collect_symbol_completion_matches_break_on)
16260         (make_source_files_completion_list, find_main_name): Update.
16261         * symmisc.c (print_symbol_bcache_statistics)
16262         (print_objfile_statistics, maintenance_print_symbols)
16263         (maintenance_print_msymbols, maintenance_print_objfiles)
16264         (maintenance_info_symtabs, maintenance_check_symtabs)
16265         (maintenance_expand_symtabs, maintenance_info_line_tables):
16266         Update.
16267         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16268         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16269         (map_overlay_command, unmap_overlay_command)
16270         (simple_overlay_update, expand_symtabs_matching)
16271         (map_symbol_filenames): Update.
16272         * symfile-debug.c (set_debug_symfile): Update.
16273         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16274         Update.
16275         * source.c (select_source_symtab, forget_cached_source_info):
16276         Update.
16277         * solib.c (solib_read_symbols): Update.
16278         * solib-spu.c (append_ocl_sos): Update.
16279         * psymtab.c (maintenance_print_psymbols)
16280         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16281         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16282         * printcmd.c (info_symbol_command): Update.
16283         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16284         Update.
16285         * objfiles.h (class all_objfiles): Remove.
16286         * objfiles.c (have_partial_symbols, have_full_symbols)
16287         (have_minimal_symbols, qsort_cmp, update_section_map)
16288         (shared_objfile_contains_address_p)
16289         (default_iterate_over_objfiles_in_search_order): Update.
16290         * objc-lang.c (info_selectors_command, info_classes_command)
16291         (find_methods): Update.
16292         * minsyms.c (find_solib_trampoline_target): Update.
16293         * maint.c (maintenance_info_sections)
16294         (maintenance_translate_address, count_symtabs_and_blocks):
16295         Update.
16296         * main.c (captured_main_1): Update.
16297         * linux-thread-db.c (try_thread_db_load_from_pdir)
16298         (has_libpthread): Update.
16299         * linespec.c (iterate_over_all_matching_symtabs)
16300         (search_minsyms_for_name): Update.
16301         * jit.c (jit_find_objf_with_entry_addr): Update.
16302         * hppa-tdep.c (find_unwind_entry)
16303         (hppa_lookup_stub_minimal_symbol): Update.
16304         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16305         Update.
16306         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16307         (elf_gnu_ifunc_resolve_by_got): Update.
16308         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16309         * dwarf-index-write.c (save_gdb_index_command): Update.
16310         * cp-support.c (add_symbol_overload_list_qualified): Update.
16311         * breakpoint.c (create_overlay_event_breakpoint)
16312         (create_longjmp_master_breakpoint)
16313         (create_std_terminate_master_breakpoint)
16314         (create_exception_master_breakpoint): Update.
16315         * blockframe.c (find_pc_partial_function): Update.
16316         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16317         (ada_collect_symbol_completion_matches)
16318         (ada_add_global_exceptions): Update.
16319
16320 2019-01-17  Tom Tromey  <tom@tromey.com>
16321
16322         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16323         declare VEC.
16324         (solib_target_parse_libraries): Change return type.
16325         (library_list_start_segment, library_list_start_section)
16326         (library_list_end_library, library_list_start_library); Update.
16327         (solib_target_free_library_list): Remove.
16328         (solib_target_parse_libraries): Remove cleanup.  Change return
16329         type.
16330         (solib_target_current_sos): Update.
16331
16332 2019-01-17  Tom Tromey  <tromey@bapiya>
16333
16334         * valprint.c: Replace "the the" with "the".
16335         * symtab.c: Replace "the the" with "the".
16336         * solib.c: Replace "the the" with "the".
16337         * solib-dsbt.c: Replace "the the" with "the".
16338         * linespec.c: Replace "the the" with "the".
16339         * dwarf2loc.h: Replace "the the" with "the".
16340         * amd64-windows-tdep.c: Replace "the the" with "the".
16341         * aarch64-tdep.c: Replace "the the" with "the".
16342
16343 2019-01-16  Keith Seitz  <keiths@redhat.com>
16344
16345         PR gdb/23773
16346         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16347         <builder>: Rename to ..
16348         <m_builder>: ... this and make private.
16349         (dwarf2_cu::get_builder): New method.  Change all users of
16350         `builder' to use this method.
16351         (dwarf2_start_symtab): Move to ...
16352         (dwarf2_cu::start_symtab): ... here.  Update all callers
16353         (setup_type_unit_groups): Move to ...
16354         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16355         callers.
16356         (dwarf2_cu::reset_builder): New method.
16357         (process_full_compunit, process_full_type_unit): Use
16358         dwarf2_cu::reset_builder.
16359         (follow_die_offset): Record the ancestor CU if it is different
16360         from the followed DIE's CU.
16361         (follow_die_sig_1): Likewise.
16362
16363 2019-01-15  Tom Tromey  <tom@tromey.com>
16364
16365         * remote.c (class remote_state) <buf>: Now a char_vector.
16366         <buf_size>: Remove.
16367         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16368         parameter.
16369         (remote_target::getpkt_or_notif_sane_1)
16370         (remote_target::getpkt_sane)
16371         (remote_target::getpkt_or_notif_sane): Likewise.
16372         (class remote_target) <putpkt>: New overload.
16373         (remote_target::read_frame): Change type of "buf_p".  Remove
16374         sizeof_p parameter.
16375         (packet_ok): New overload.
16376         (packet_check_result): New overload.
16377         Update all uses.
16378
16379 2019-01-14  Tom Tromey  <tom@tromey.com>
16380
16381         * remote-notif.c (handle_notification, remote_notif_ack)
16382         (remote_notif_parse): Make "buf" const.
16383         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16384         const.
16385         (remote_notif_parse, remote_notif_ack, handle_notification):
16386         Likewise.
16387         * remote.c (remote_notif_stop_parse): Make "buf" const.
16388         (remote_target::remote_parse_stop_reply): Make "buf" const.
16389         (remote_notif_stop_ack): Make "buf" const.
16390
16391 2019-01-14  Tom Tromey  <tom@tromey.com>
16392
16393         * remote.c (remote_console_output): Make parameter const.
16394
16395 2019-01-14  Tom Tromey  <tom@tromey.com>
16396
16397         * target-debug.h (target_debug_print_signals): Constify.
16398         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16399         * procfs.c (procfs_target::pass_signals): Update.
16400         * linux-nat.c (linux_nat_target::pass_signals): Update.
16401         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16402         * target-delegates.c: Rebuild.
16403         * remote.c (remote_target::program_signals): Update.
16404         (remote_target::pass_signals): Update.
16405         * target.c (target_pass_signals): Constify argument.
16406         (target_program_signals): Likewise.
16407         * target.h (struct target_ops) <pass_signals, program_signals>:
16408         Constify argument.
16409         (target_pass_signals, target_program_signals): Constify argument.
16410
16411 2019-01-14  Tom Tromey  <tom@tromey.com>
16412
16413         PR tui/28819:
16414         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16415
16416 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16417
16418         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16419         field.
16420         * rs6000-tdep.c: Include reggroups.h.
16421         (IS_V_ALIAS_PSEUDOREG): Define.
16422         (rs6000_register_name): Return names for the "vX" aliases.
16423         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16424         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16425         aliases.  Call default_register_reggroup_p for all other
16426         pseudo-registers.
16427         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16428         New functions.
16429         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16430         Handle "vX" aliases.
16431         (v_alias_pseudo_register_collect): New function.
16432         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16433         (rs6000_gdbarch_init): Initialize "vX" aliases as
16434         pseudo-registers.  Restore registration of
16435         rs6000_pseudo_register_reggroup_p with
16436         set_tdesc_pseudo_register_reggroup_p.
16437
16438 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16439
16440         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16441         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16442         set_gdbarch_num_pseudo_regs.
16443
16444 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16445
16446         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16447         Remove arg prefixname, add do_set and do_show.
16448         Add member functions set_list and show_list.
16449         * cli/cli-style.c (class cli_style_option): Update accordingly.
16450         (style_set_list): Move to file scope.
16451         (style_show_list): Likewise.
16452         (set_style): Call help_list.
16453         (show_style): Call cmd_show_list.
16454         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16455         Update to use the new macro.
16456
16457 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16458
16459         * ada-lang.c (_initialize_ada_language): Expand the help text
16460         for the "catch exception" command.
16461
16462 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16463
16464         * symtab.c (matching_obj_sections): Initialize obj,
16465         declare it closer to its usage.
16466
16467 2019-01-10  Tom Tromey  <tom@tromey.com>
16468
16469         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16470         (basic_inf_threads_range): Remove.
16471         (inf_threads_range, inf_non_exited_threads_range)
16472         (safe_inf_threads_range): Use next_adapter.
16473
16474 2019-01-10  Keith Seitz  <keiths@redhat.com>
16475
16476         PR gdb/23712
16477         PR symtab/23010
16478         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16479         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16480
16481 2019-01-10  Keith Seitz  <keiths@redhat.com>
16482
16483         PR gdb/23712
16484         PR symtab/23010
16485         * dictionary.c (pending_to_vector): Remove.
16486         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16487         Remove _1 suffix, replacing functions of the same name.  Update
16488         all callers.
16489         (dict_create_hashed, dict_create_hashed_expandable)
16490         (dict_create_linear, dict_create_linear_expandable, dict_free)
16491         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16492         Make functions static.
16493
16494 2019-01-10  Keith Seitz  <keiths@redhat.com>
16495
16496         PR gdb/23712
16497         PR symtab/23010
16498         * dictionary.h (struct dictionary): Replace declaration with
16499         multidictionary.
16500         (dict_create_hashed, dict_create_hashed_expandable)
16501         (dict_create_linear, dict_create_linear_expandable)
16502         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16503         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16504         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16505         taking multidictionary argument.
16506         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16507         * block.h (struct block) <dict>: Change to multidictionary
16508         and rename `multidict'.
16509         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16510         symmisc.c: Update all dictionary references to multidictionary.
16511
16512 2019-01-10  Keith Seitz  <keiths@redhat.com>
16513
16514         PR gdb/23712
16515         PR symtab/23010
16516         * dictionary.c: Include unordered_map.
16517         (pending_to_vector): New function.
16518         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16519         Rewrite the non-"_1" functions to take vector instead
16520         of linked list.
16521         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16522         "new" _1 versions of the same name.
16523         (multidictionary): Define.
16524         (std::hash<enum language): New definition.
16525         (collate_pending_symbols_by_language, mdict_create_hashed)
16526         (mdict_create_hashed_expandable, mdict_create_linear)
16527         (mdict_create_linear_expandable, mdict_free)
16528         (find_language_dictionary, create_new_language_dictionary)
16529         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16530         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16531         (mdict_size, mdict_empty): New functions.
16532         * dictionary.h (mdict_iterator): Define.
16533
16534 2019-01-10  Pedro Alves  <palves@redhat.com>
16535
16536         * breakpoint.c (read_uploaded_action)
16537         (create_tracepoint_from_upload): Adjust to use
16538         gdb::unique_xmalloc_ptr.
16539         * ctf.c (ctf_write_uploaded_tp):
16540         (SET_ARRAY_FIELD): Use emplace_back.
16541         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16542         * tracefile-tfile.c (tfile_write_uploaded_tp):
16543         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16544         gdb::unique_xmalloc_ptr.
16545         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16546         at_string, cond_string, cmd_strings>: Replace char pointers
16547         with gdb::unique_xmalloc_ptr.
16548
16549 2019-01-10  Pedro Alves  <palves@redhat.com>
16550
16551         * solib-target.c (library_list_start_library): Don't xstrdup name.
16552
16553 2019-01-10  Pedro Alves  <palves@redhat.com>
16554
16555         * mdebugread.c (parse_partial_symbols): Use
16556         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16557
16558 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16559
16560         * linux-fork.c (scoped_switch_fork_info)
16561         <~scoped_switch_fork_info>: Fix incorrect variable name.
16562
16563 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16564
16565         * linux-fork.c (scoped_switch_fork_info)
16566         <scoped_switch_fork_info>: Make explicit.
16567         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16568
16569 2019-01-10  Tom Tromey  <tom@tromey.com>
16570
16571         * objfiles.h (objfile::reset_psymtabs): Update.
16572         * objfiles.c (objfile::objfile): Update.
16573         * psymtab.h (psymtab_storage::obstack): Update.
16574         (psymtab_storage::m_obstack): Use gdb::optional.
16575         (class psymtab_storage): Update comment.  Remove objfile
16576         parameter.
16577         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16578
16579 2019-01-10  Tom Tromey  <tom@tromey.com>
16580
16581         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16582         <free_psymtabs>: Now private.
16583         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16584         (allocate_psymtab): Use new method.
16585
16586 2019-01-10  Tom Tromey  <tom@tromey.com>
16587
16588         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16589         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16590         * mdebugread.c (parse_partial_symbols): Use
16591         allocate_dependencies.
16592         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16593         allocate_dependencies.
16594         (process_psymtab_comp_unit_reader)
16595         (build_type_psymtab_dependencies): Likewise.
16596         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16597
16598 2019-01-10  Tom Tromey  <tom@tromey.com>
16599
16600         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16601         PSYMBOL_SET_LANGUAGE.
16602         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16603
16604 2019-01-10  Tom Tromey  <tom@tromey.com>
16605
16606         * psymtab.h (psymtab_storage::obstack): New method.
16607         <m_obstack>: Rename from obstack; now private.
16608         * psymtab.c (psymtab_storage): Update.
16609         * dwarf2read.c (create_addrmap_from_index)
16610         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16611         Update.
16612
16613 2019-01-10  Tom Tromey  <tom@tromey.com>
16614
16615         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16616         * objfiles.h (objfile::reset_psymtabs): New method.
16617
16618 2019-01-10  Tom Tromey  <tom@tromey.com>
16619
16620         * symmisc.c (print_symbol_bcache_statistics): Update.
16621         (print_objfile_statistics): Update.
16622         * symfile.c (reread_symbols): Update.
16623         * psymtab.h (class psymtab_storage): New.
16624         * psymtab.c (psymtab_storage): New constructor.
16625         (~psymtab_storage): New destructor.
16626         (require_partial_symbols): Update.
16627         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16628         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16629         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16630         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16631         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16632         (start_psymtab_common, end_psymtab_common)
16633         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16634         (allocate_psymtab): Update.
16635         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16636         Update.
16637         (dump_psymtab_addrmap, maintenance_print_psymbols)
16638         (maintenance_check_psymtabs): Update.
16639         (class objfile_psymtabs): Move to objfiles.h.
16640         * psympriv.h (discard_psymtab): Now inline.
16641         (psymtab_discarder::psymtab_discarder): Update.
16642         (psymtab_discarder::~psymtab_discarder): Update.
16643         (ALL_OBJFILE_PSYMTABS): Rewrite.
16644         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16645         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16646         Remove fields.
16647         <partial_symtabs>: New field.
16648         (class objfile_psymtabs): Move from psymtab.h.  Update.
16649         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16650         psymbol_cache.
16651         (objfile::~objfile): Don't destroy psymbol_cache.
16652         * mdebugread.c (parse_partial_symbols): Update.
16653         * dwarf2read.c (create_addrmap_from_index)
16654         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16655         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16656         (add_partial_subprogram, dwarf2_ranges_read): Update.
16657         * dwarf-index-write.c (write_address_map)
16658         (write_one_signatured_type, recursively_write_psymbols)
16659         (class debug_names, class debug_names, write_psymtabs_to_index):
16660         Update.
16661
16662 2019-01-10  Tom Tromey  <tom@tromey.com>
16663
16664         * symtab.h (SYMBOL_SET_NAMES): Update.
16665         (symbol_set_names): Update.
16666         (MSYMBOL_SET_NAMES): Update.
16667         * symtab.c (symbol_set_names): Change argument to be an
16668         objfile_per_bfd_storage.
16669         * psymtab.c (add_psymbol_to_bcache): Update.
16670         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16671
16672 2019-01-10  Tom Tromey  <tom@tromey.com>
16673
16674         * symtab.c (create_demangled_names_hash): Change argument to be an
16675         objfile_per_bfd_storage.
16676         (symbol_set_names): Update.
16677
16678 2019-01-10  Tom Tromey  <tom@tromey.com>
16679
16680         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16681         init_psymbol_list.
16682         * psymtab.c (init_psymbol_list): Do nothing if already called.
16683         * psympriv.h (init_psymbol_list): Add comment.
16684         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16685         init_psymbol_list.
16686         * dbxread.c (dbx_symfile_read): Unconditionally call
16687         init_psymbol_list.
16688
16689 2019-01-10  Tom Tromey  <tom@tromey.com>
16690
16691         * xcoffread.c (scan_xcoff_symtab): Update.
16692         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16693         "where".
16694         * mdebugread.c (parse_partial_symbols)
16695         (handle_psymbol_enumerators): Update.
16696         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16697         * dbxread.c (read_dbx_symtab): Update.
16698         * psympriv.h (psymbol_placement): New enum.
16699         (add_psymbol_to_list): Update.
16700
16701 2019-01-10  Tom Tromey  <tom@tromey.com>
16702
16703         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16704         static_psymbols parameters.
16705         (scan_xcoff_symtab): Update.
16706         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16707         static_psymbols parameters.
16708         * psympriv.h (start_psymtab_common): Update.
16709         * mdebugread.c (parse_partial_symbols): Update.
16710         * dwarf2read.c (create_partial_symtab): Update.
16711         * dbxread.c (read_dbx_symtab): Update.
16712         (start_psymtab): Remove global_psymbols and static_psymbols
16713         parameters.
16714
16715 2019-01-10  Tom Tromey  <tom@tromey.com>
16716
16717         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16718         * psymtab.c (allocate_psymtab): Add comment.
16719         * psympriv.h (allocate_psymtab): Add comment.
16720         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16721         initializations.
16722         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16723
16724 2019-01-10  Tom Tromey  <tom@tromey.com>
16725
16726         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16727         Don't declare.
16728         * mipsread.c: Include mdebugread.h.
16729         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16730         Declare.
16731         * elfread.c: Include mdebugread.h.
16732
16733 2019-01-09  Tom Tromey  <tom@tromey.com>
16734
16735         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16736         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16737         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16738         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16739         (psym_lookup_symbol, psym_find_last_source_symtab)
16740         (psym_forget_cached_source_info, psym_print_stats)
16741         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16742         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16743         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16744         (psym_find_compunit_symtab_by_address)
16745         (maintenance_print_psymbols, maintenance_info_psymtabs)
16746         (maintenance_check_psymtabs): Use ranged for.
16747         * psymtab.h (class objfile_psymtabs): New.
16748         (require_partial_symbols): Return objfile_psymtabs.
16749         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16750
16751 2019-01-09  Tom Tromey  <tom@tromey.com>
16752
16753         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16754         (find_pc_mapped_section, list_overlays_command)
16755         (map_overlay_command, unmap_overlay_command)
16756         (simple_overlay_update): Use all_objfiles.
16757         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16758         * printcmd.c (info_symbol_command): Use all_objfiles.
16759         * objfiles.h (ALL_OBJSECTIONS): Remove.
16760         * maint.c (maintenance_translate_address): Use all_objfiles.
16761         * gcore.c (gcore_create_callback): Use all_objfiles.
16762         (objfile_find_memory_regions): Likewise.
16763
16764 2019-01-09  Tom Tromey  <tom@tromey.com>
16765
16766         * symtab.c (find_line_symtab, info_sources_command)
16767         (make_source_files_completion_list): Use objfile_compunits.
16768         * source.c (select_source_symtab): Use objfile_compunits.
16769         * objfiles.h (struct objfile): Update comment.
16770         (ALL_OBJFILES): Remove.
16771         (ALL_FILETABS): Remove.
16772         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16773         objfile_compunits.
16774
16775 2019-01-09  Tom Tromey  <tom@tromey.com>
16776
16777         * symmisc.c (print_objfile_statistics, dump_objfile)
16778         (maintenance_print_symbols): Use compunit_filetabs.
16779         * source.c (forget_cached_source_info_for_objfile): Use
16780         compunit_filetabs.
16781         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16782         (ALL_FILETABS): Use compunit_filetabs.
16783         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16784         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16785
16786 2019-01-09  Tom Tromey  <tom@tromey.com>
16787
16788         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16789         (compunit_filetabs): New.
16790         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16791         compunit_filetabs.
16792         (info_sources_command, make_source_files_completion_list): Remove
16793         declaration.
16794         * symmisc.c (print_objfile_statistics, dump_objfile)
16795         (maintenance_print_symbols): Remove declaration.
16796         (maintenance_info_symtabs): Use compunit_filetabs.
16797         (maintenance_info_line_tables): Likewise.
16798         * source.c (select_source_symtab): Change local variable name.
16799         (forget_cached_source_info_for_objfile): Remove declaration.
16800         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16801         * objfiles.c (objfile_relocate1): Remove declaration.
16802         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16803         declaration.
16804         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16805         * coffread.c (coff_symtab_read): Remove declaration.
16806         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16807         compunit_filetabs.
16808
16809 2019-01-09  Tom Tromey  <tom@tromey.com>
16810
16811         * symtab.c (lookup_objfile_from_block)
16812         (find_pc_sect_compunit_symtab, search_symbols)
16813         (default_collect_symbol_completion_matches_break_on): Use
16814         objfile_compunits.
16815         * objfiles.h (ALL_COMPUNITS): Remove.
16816         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16817         * cp-support.c (add_symbol_overload_list_qualified): Use
16818         objfile_compunits.
16819         * ada-lang.c (ada_collect_symbol_completion_matches)
16820         (ada_add_global_exceptions): Use objfile_compunits.
16821
16822 2019-01-09  Tom Tromey  <tom@tromey.com>
16823
16824         * source.c (select_source_symtab)
16825         (forget_cached_source_info_for_objfile): Remove declaration.
16826         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16827         declaration.
16828         * maint.c (count_symtabs_and_blocks): Remove declaration.
16829         * cp-support.c (add_symbol_overload_list_qualified): Remove
16830         declaration.
16831         * coffread.c (coff_symtab_read): Remove declaration.
16832         * symtab.c (lookup_symbol_in_objfile_symtabs)
16833         (basic_lookup_transparent_type_1): Use objfile_compunits.
16834         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16835         (info_sources_command, search_symbols)
16836         (default_collect_symbol_completion_matches_break_on)
16837         (make_source_files_completion_list): Remove declaration.
16838         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16839         (ada_collect_symbol_completion_matches)
16840         (ada_add_global_exceptions): Remove declaration.
16841         * linespec.c (iterate_over_all_matching_symtabs): Use
16842         objfile_compunits.
16843         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16844         (class objfile_compunits): New.
16845         (ALL_COMPUNITS): Use objfile_compunits.
16846         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16847         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16848         objfile_compunits.
16849         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16850
16851 2019-01-09  Tom Tromey  <tom@tromey.com>
16852
16853         * symtab.c (search_symbols)
16854         (default_collect_symbol_completion_matches_break_on): Use
16855         objfile_msymbols.
16856         * ada-lang.c (ada_lookup_simple_minsym)
16857         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16858         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16859         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16860         objfile_msymbols.
16861         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16862         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16863         * objc-lang.c (find_methods): Use objfile_msymbols.
16864         (info_selectors_command, info_classes_command): Likewise.
16865         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16866         * objfiles.h (class objfile_msymbols): New.
16867         (ALL_OBJFILE_MSYMBOLS): Remove.
16868         (ALL_MSYMBOLS): Remove.
16869
16870 2019-01-09  Tom Tromey  <tom@tromey.com>
16871
16872         * common/next-iterator.h (next_adapter): Add Iterator template
16873         parameter.
16874         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16875         (class all_objfiles_safe): New.
16876         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16877         * objfiles.c (put_objfile_before): Update comment.
16878         (add_separate_debug_objfile): Likewise.
16879         (free_all_objfiles): Use all_objfiles_safe.
16880         (objfile_purge_solibs): Likewise.
16881
16882 2019-01-09  Tom Tromey  <tom@tromey.com>
16883
16884         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16885         (expand_symtab_containing_pc, lookup_static_symbol)
16886         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16887         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16888         all_objfiles.
16889         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16890         * breakpoint.c (create_overlay_event_breakpoint)
16891         (create_longjmp_master_breakpoint)
16892         (create_std_terminate_master_breakpoint)
16893         (create_exception_master_breakpoint): Use all_objfiles.
16894         * linux-thread-db.c (try_thread_db_load_from_pdir)
16895         (has_libpthread): Use all_objfiles.
16896         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16897         * linespec.c (iterate_over_all_matching_symtabs)
16898         (search_minsyms_for_name): Use all_objfiles.
16899         * maint.c (maintenance_info_sections): Use all_objfiles.
16900         * main.c (captured_main_1): Use all_objfiles.
16901         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16902         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16903         * guile/scm-pretty-print.c
16904         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16905         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16906         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16907         (maintenance_print_msymbols): Use all_objfiles.
16908         * source.c (select_source_symtab): Use all_objfiles.
16909         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16910         * symfile.c (remove_symbol_file_command)
16911         (expand_symtabs_matching, map_symbol_filenames): Use
16912         all_objfiles.
16913         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16914         all_objfiles.
16915         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16916         * objc-lang.c (find_methods): Use all_objfiles.
16917         * objfiles.c (have_partial_symbols, have_full_symbols)
16918         (have_minimal_symbols, qsort_cmp)
16919         (default_iterate_over_objfiles_in_search_order): Use
16920         all_objfiles.
16921         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16922         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16923         (maintenance_check_psymtabs): Use all_objfiles.
16924         (ALL_PSYMTABS): Remove.
16925         * compile/compile-object-run.c (do_module_cleanup): Use
16926         all_objfiles.
16927         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16928         * cp-support.c (add_symbol_overload_list_qualified): Use
16929         all_objfiles.
16930         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16931         Use all_objfiles.
16932         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16933         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16934         all_objfiles.
16935         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16936         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16937         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16938         Uses all_objfiles.
16939         * solib.c (solib_read_symbols): Use all_objfiles
16940
16941 2019-01-09  Tom Tromey  <tom@tromey.com>
16942
16943         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16944         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16945         all_objfiles.
16946         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16947         * symmisc.c (print_symbol_bcache_statistics)
16948         (print_objfile_statistics, maintenance_print_objfiles)
16949         (maintenance_info_symtabs, maintenance_check_symtabs)
16950         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16951         all_objfiles.
16952         * source.c (forget_cached_source_info): Use all_objfiles.
16953         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16954         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16955         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16956         * objfiles.c (update_section_map): Use all_objfiles.
16957         (shared_objfile_contains_address_p): Likewise.
16958         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16959         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16960
16961 2019-01-09  Tom Tromey  <tom@tromey.com>
16962
16963         * common/next-iterator.h: New file.
16964         * objfiles.h (class all_objfiles): New.
16965         (struct objfile_iterator): New.
16966
16967 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16968
16969         * NEWS: Move the description of the changed "frame", "select-frame",
16970          and "info frame" commands to the Changed commands section.
16971
16972 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16973
16974         * gdbtypes.c (check_stub_method_group): Remove handling of old
16975         mangling schemes.
16976         * linespec.c (find_methods): Likewise.
16977         * stabsread.c (read_member_functions): Likewise.
16978         * valops.c (search_struct_method): Likewise.
16979         (value_struct_elt_for_reference): Likewise.
16980         * NEWS: Mention this change.
16981
16982 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16983
16984         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16985         print_source_lines.
16986         * source.c (print_source_lines_base): Update line number check.
16987         (print_source_lines): New function.
16988         (source_lines_range::source_lines_range): New function.
16989         * source.h (class source_lines_range): New class.
16990         (print_source_lines): New declaration.
16991
16992 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16993
16994         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16995
16996 2019-01-08  Tom Tromey  <tom@tromey.com>
16997             Simon Marchi  <simon.marchi@ericsson.com>
16998
16999         PR gdb/24060
17000         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
17001         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
17002         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
17003         * f-exp.y (DOLLAR_VARIABLE): Likewise.
17004         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
17005         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
17006
17007 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
17008
17009         * source.c (select_source_symtab): Move header comment to
17010         declaration in source.h.
17011         (forget_cached_source_info_for_objfile): Likewise.
17012         (forget_cached_source_info): Likewise.
17013         (identify_source_line): Likewise.
17014         * source.h (identify_source_line): Move declaration from symtab.h
17015         and add comment from source.c
17016         (print_source_lines): Likewise.
17017         (forget_cached_source_info_for_objfile): Likewise.
17018         (forget_cached_source_info): Likewise.
17019         (select_source_symtab): Likewise.
17020         (enum print_source_lines_flag): Move definition from symtab.h.
17021         * symtab.h (identify_source_line): Move declaration to source.h.
17022         (print_source_lines): Likewise.
17023         (forget_cached_source_info_for_objfile): Likewise.
17024         (forget_cached_source_info): Likewise.
17025         (select_source_symtab): Likewise.
17026         (enum print_source_lines_flag): Move definition to source.h.
17027         * tui/tui-hooks.c: Add 'source.h' include.
17028
17029 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
17030
17031         * source.c (print_source_lines_base): Handle requests to print
17032         reverse line number sequences, and guard against empty lines
17033         string.
17034
17035 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
17036
17037         * source.c (print_source_lines_base): Fix skip of '\r' if next
17038         character is '\n'.
17039
17040 2019-01-06  Tom Tromey  <tom@tromey.com>
17041
17042         * c-exp.y (struct c_parse_state) <macro_original_text,
17043         expansion_obstack>: New member.
17044         (macro_original_text, expansion_obstack): Remove globals.
17045         (scan_macro_expansion, scanning_macro_expansion)
17046         (finished_macro_expansion): Update.
17047         (scan_macro_cleanup): Remove.
17048         (yylex, c_parse): Update.
17049
17050 2019-01-06  Tom Tromey  <tom@tromey.com>
17051
17052         * c-exp.y (struct c_parse_state) <strings>: New member.
17053         (operator_stoken): Update.
17054
17055 2019-01-06  Tom Tromey  <tom@tromey.com>
17056
17057         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
17058         (union type_stack_elt) <typelist_val>: Now a pointer to
17059         std::vector.
17060         (type_stack_cleanup): Don't declare.
17061         (push_typelist): Update.
17062         * parse.c (pop_typelist): Return a std::vector.
17063         (push_typelist): Take a std::vector.
17064         (follow_types): Update.  Do not free args.
17065         (type_stack_cleanup): Remove.
17066         * c-exp.y (struct c_parse_state): New.
17067         (cpstate): New global.
17068         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
17069         (nonempty_typelist): Update.
17070         (func_mod): Create a new vector.
17071         (c_parse): Create a c_parse_state.
17072         (check_parameter_typelist): Do not delete params.
17073         (function_method): Update.  Do not delete type_list.
17074
17075 2019-01-06  Tom Tromey  <tom@tromey.com>
17076
17077         PR gdb/28155:
17078         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17079         check_typedef.
17080         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17081         (print_return_value): Likewise.
17082
17083 2019-01-05  Tom Tromey  <tom@tromey.com>
17084
17085         * contrib/cleanup_check.py: Remove.
17086         * contrib/gcc-with-excheck: Remove.
17087         * contrib/exsummary.py: Remove.
17088         * contrib/excheck.py: Remove.
17089
17090 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
17091
17092         * thread.c (delete_thread_1): Add gdb_assert that THR is not
17093         NULL. Initialize tpprev to NULL instead of assigning it
17094         to NULL on the next statement.
17095         * windows-nat.c (windows_delete_thread): Remove check for
17096         main_thread_id before printing thread exit notifications.
17097         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17098         Remove thread ID check against main_thread_id.
17099         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17100         windows_delete_thread.
17101         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17102
17103 2019-01-04  Tom Tromey  <tom@tromey.com>
17104
17105         * compile/compile.c (_initialize_compile): Use upper case for
17106         metasyntactic variables.
17107         * symmisc.c (_initialize_symmisc): Use upper case for
17108         metasyntactic variables.
17109         * psymtab.c (_initialize_psymtab): Use upper case for
17110         metasyntactic variables.
17111         * demangle.c (demangle_command): Use upper case for metasyntactic
17112         variables.
17113         (_initialize_demangler): Likewise.
17114         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17115         variables.
17116
17117 2019-01-03  Tom Tromey  <tom@tromey.com>
17118
17119         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17120
17121 2019-01-03  Tom Tromey  <tom@tromey.com>
17122
17123         * python/py-symtab.c (salpy_str): Update.
17124         (struct salpy_sal_object) <symtab>: Now a PyObject.
17125         (salpy_dealloc): Update.
17126         (del_objfile_sal): Use gdbpy_ref.
17127
17128 2019-01-03  Tom Tromey  <tom@tromey.com>
17129
17130         * python/py-type.c (convert_field): Use new_reference.  Return
17131         gdbpy_ref.
17132         (make_fielditem): Return gdbpy_ref.
17133         (typy_fields): Update.
17134         (typy_getitem): Update.
17135         (field_name): Return gdbpy_ref.  Use new_reference.
17136         (typy_iterator_iternext): Update.
17137
17138 2019-01-03  Tom Tromey  <tom@tromey.com>
17139
17140         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17141
17142 2019-01-03  Tom Tromey  <tom@tromey.com>
17143
17144         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17145         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17146         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17147         (pspy_set_frame_filters, pspy_set_frame_unwinders)
17148         (pspy_set_type_printers): Likewise.
17149         * python/py-function.c (fnpy_init): Use gdbpy_ref.
17150         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17151         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17152         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17153         (objfpy_set_type_printers): Likewise.
17154
17155 2019-01-03  Tom Tromey  <tom@tromey.com>
17156
17157         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17158         (gdbpy_print_stack): Use gdbpy_err_fetch.
17159         * python/python-internal.h (class gdbpy_err_fetch): New class.
17160         (class gdbpy_enter) <m_error_type, m_error_value,
17161         m_error_traceback>: Remove.
17162         <m_error>: New member.
17163         (gdbpy_exception_to_string): Don't declare.
17164         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17165         * python/py-value.c (convert_value_from_python): Use
17166         gdbpy_err_fetch.
17167         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17168         gdbpy_exception_to_string.
17169         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17170         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17171         gdbpy_err_fetch.
17172
17173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17174
17175         * linux-nat.c (delete_lwp_cleanup): Delete.
17176         (struct lwp_deleter): New struct.
17177         (lwp_info_up): New typedef.
17178         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17179         lwp_info_up.
17180
17181 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17182
17183         * linux-fork.c (class scoped_switch_fork_info): New class.
17184         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17185
17186 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17187
17188         * valops.c (find_overload_match): Remove use of null_cleanup, and
17189         calls to do_cleanups.
17190
17191 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17192
17193         * compile/compile-cplus-types.c
17194         (compile_cplus_instance::decl_name): Handle changes to
17195         cp_func_name.
17196         * cp-support.c (cp_func_name): Update header comment, update
17197         return type.
17198         * cp-support.h (cp_func_name): Update return type in declaration.
17199         * valops.c (find_overload_match): Move temp_func local to top
17200         level of function and change its type.  Use temp_func to hold and
17201         delete temporary string obtained from cp_func_name.
17202
17203 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17204
17205         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17206         gdb::char_vector, remove cleanup, and update uses of `msg`.
17207
17208 2019-01-03  Jim Wilson  <jimw@sifive.com>
17209
17210         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17211
17212 2019-01-02  Tom Tromey  <tom@tromey.com>
17213
17214         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17215         (tdesc_parse_xml): Remove cleanups.
17216         * target-descriptions.h (make_cleanup_free_target_description):
17217         Don't declare.
17218         (target_desc_deleter): New struct.
17219         (target_desc_up): New typedef.
17220         * target-descriptions.c (target_desc_deleter::operator()): Rename
17221         from free_target_description.
17222         (make_cleanup_free_target_description): Remove.
17223
17224 2019-01-02  Tom Tromey  <tom@tromey.com>
17225
17226         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17227         constructor, destructor.
17228         (linespec_parser): Remove typedef.
17229         (~linespec_parser): Rename from linespec_parser_delete.
17230         (linespec_lex_to_end, linespec_complete_label)
17231         (linespec_complete): Update.
17232         (decode_line_full): Remove cleanups.
17233         (decode_line_1): Update.
17234
17235 2019-01-02  Tom Tromey  <tom@tromey.com>
17236
17237         * python/python-internal.h (inferior_to_inferior_object): Change
17238         return type.
17239         * python/py-exitedevent.c (create_exited_event_object): Update.
17240         * python/py-inferior.c (inferior_to_inferior_object): Return
17241         gdbpy_ref.
17242         (python_new_inferior, python_inferior_deleted)
17243         (thread_to_thread_object, delete_thread_object)
17244         (build_inferior_list, gdbpy_selected_inferior): Update.
17245         * python/py-infthread.c (create_thread_object): Update.  Also fail
17246         if inferior_to_inferior_object fails.
17247
17248 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17249
17250         * inferior.h (class inferior) <displaced_step_state>: New field.
17251         * infrun.h (struct displaced_step_state): Move here from
17252         infrun.c.  Initialize fields, add constructor.
17253         <inf>: Remove field.
17254         <reset>: New method.
17255         * infrun.c (struct displaced_step_inferior_state): Move to
17256         infrun.h.
17257         (displaced_step_inferior_states): Remove.
17258         (get_displaced_stepping_state): Adust.
17259         (displaced_step_in_progress_any_inferior): Adjust.
17260         (displaced_step_in_progress_thread): Adjust.
17261         (displaced_step_in_progress): Adjust.
17262         (add_displaced_stepping_state): Remove.
17263         (get_displaced_step_closure_by_addr): Adjust.
17264         (remove_displaced_stepping_state): Remove.
17265         (infrun_inferior_exit): Call displaced_step_state.reset.
17266         (use_displaced_stepping): Don't check for NULL.
17267         (displaced_step_prepare_throw): Call
17268         get_displaced_stepping_state.
17269         (displaced_step_fixup): Don't check for NULL.
17270         (prepare_for_detach): Don't check for NULL.
17271
17272 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17273
17274         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17275          in case of call that did not complete.
17276
17277 2019-01-02  Andrey Utkin  <autkin@undo.io>
17278
17279         * symfile.c (find_separate_debug_file): Fix search of debug files for
17280         remote debuggee.
17281
17282 2019-01-02  Tom Tromey  <tom@tromey.com>
17283
17284         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17285         indentation.
17286         * python/py-frame.c (frapy_older): Remove cast.
17287         (frapy_newer): Likewise.
17288         * python/py-breakpoint.c (local_setattro): Remove cast.
17289         * python/py-arch.c (archpy_name): Remove local variable.
17290         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17291
17292 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17293
17294         * unittests/basic_string_view/element_access/char/empty.cc:
17295         Fix year range in copyright header.
17296
17297 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17298
17299         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17300         Delete.
17301         <operator==>: Update with for removed field.
17302         <hash>: Likewise.
17303         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17304         <isa_features>: ...this.
17305         <abi_features>: New field.
17306         (riscv_isa_flen): Update comment.
17307         (riscv_abi_xlen): New declaration.
17308         (riscv_abi_flen): New declaration.
17309         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17310         isa_features.
17311         (riscv_abi_xlen): New function.
17312         (riscv_isa_flen): Update to get answer from isa_features.
17313         (riscv_abi_flen): New function.
17314         (riscv_has_fp_abi): Update to get answer from abi_features.
17315         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17316         xlen and flen.
17317         (riscv_call_info) <xlen, flen>: Update comment.
17318         (riscv_call_arg_struct): Remove invalid assertions
17319         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17320         is removed.
17321         (riscv_gdbarch_init): Gather isa features and abi features
17322         separately, ensure both match on the gdbarch when reusing an old
17323         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17324         a target with 64-bit float hardware.
17325
17326 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17327
17328         * source.c (search_command_helper): Stop reverse search
17329         when line 1 has been searched.
17330
17331 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17332
17333         * record-full.c (record_full_base_target::close): Rewrite
17334         record_full_core_buf_list free logic.
17335
17336 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17337
17338         * break-catch-syscall.c (print_one_catch_syscall): xfree
17339         the last text.
17340
17341 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17342
17343         * top.c (print_gdb_version): Update Copyright year in version
17344         message.
17345
17346 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17347
17348         Update copyright year range in all GDB files.
17349
17350 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17351
17352         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17353
17354 For older changes see ChangeLog-2018.
17355 \f
17356 Local Variables:
17357 mode: change-log
17358 left-margin: 8
17359 fill-column: 74
17360 version-control: never
17361 coding: utf-8
17362 End:
17363