gdb/ChangeLog

   1 2019-10-01  Tom Tromey  <tom@tromey.com>
   2
   3         * unittests/format_pieces-selftests.c: Update.  Add final format.
   4         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
   5         empty literal pieces.
   6
   7 2019-10-01  Tom Tromey  <tom@tromey.com>
   8
   9         * ui-out.h (enum class ui_out_style_kind): Remove.
  10         (class ui_out) <field_string, field_stsream, do_field_string>:
  11         Change type of "style".
  12         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
  13         (ui_out::field_string): Update.
  14         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
  15         of "style".
  16         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
  17         * tracepoint.c (print_one_static_tracepoint_marker): Update.
  18         * stack.c (print_frame_arg, print_frame_info, print_frame):
  19         Update.
  20         * source.c (print_source_lines_base): Update.
  21         * solib.c (info_sharedlibrary_command): Update.
  22         * skip.c (info_skip_command): Update.
  23         * record-btrace.c (btrace_call_history_src_line)
  24         (btrace_call_history): Update.
  25         * python/py-framefilter.c (py_print_frame): Update.
  26         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
  27         "style".
  28         * mi/mi-out.c (mi_ui_out::do_table_header)
  29         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
  30         (mi_ui_out::do_field_string): Update.
  31         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  32         Update.
  33         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
  34         "style".
  35         * cli-out.c (cli_ui_out::do_table_header)
  36         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
  37         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
  38         (cli_ui_out::do_field_fmt): Update.
  39         * breakpoint.c (print_breakpoint_location): Update.
  40         (update_static_tracepoint): Update.
  41
  42 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  43
  44         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
  45         conversion of gdb_datadir.
  46         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
  47         remove not needed c_str ().
  48
  49 2019-09-30  Ali Tamur <tamur@google.com>
  50
  51         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
  52         (dwarf2_string_attr): Likewise.
  53
  54 2019-09-30  Ali Tamur <tamur@google.com>
  55
  56         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
  57         (process_full_type_unit): Likewise.
  58         (dump_die_shallow): Likewise.
  59         (cu_debug_loc_section): Likewise.
  60
  61 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
  62
  63         * minsyms.c (compare_minimal_symbols): Rename to...
  64         (minimal_symbol_is_less_than): ...this, and adjust to STL
  65         conventions (return bool, take arguments as references)
  66         (minimal_symbol_reader::install): Call std::sort instead
  67         of qsort.
  68
  69 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
  70
  71         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
  72         hash and why.
  73         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
  74         msymbol_hash, msymbol_demangled_hash>: Improve comments.
  75
  76 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
  79         * psympriv.h (add_psymbol_to_list): Move comment here and update
  80         it.
  81
  82 2019-09-29  Tom de Vries  <tdevries@suse.de>
  83
  84         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  85         Use $tmpdir/$(basename "$output_file").dwz instead of
  86         "${output_file}.dwz".
  87
  88 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  89
  90         PR gdb/25045
  91         * hppa-linux-nat.c: Include gdbarch.h.
  92
  93 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  94
  95         * blockframe.c (find_pc_partial_function): Change return type to bool.
  96         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  97         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  98         (stub_gnu_ifunc_resolve_name): Likewise.
  99         * symtab.c (compare_filenames_for_search): Likewise.
 100         (compare_glob_filenames_for_search): Likewise.
 101         (matching_obj_sections): Likewise.
 102         (symbol_matches_domain): Likewise.
 103         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 104         (find_line_pc): Change return type to bool.
 105         (find_line_pc_range): Likewise.
 106         (producer_is_realview): Likewise.
 107         * symtab.h (symbol_matches_domain): Likewise.
 108         (find_pc_partial_function): Likewise.
 109         (find_pc_line_pc_range): Likewise.
 110         (in_gnu_ifunc_stub): Likewise.
 111         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 112         (find_line_pc): Likewise.
 113         (find_line_pc_range): Likewise.
 114         (matching_obj_sections): Likewise.
 115         (find_line_symtab): Change out parameter to bool.
 116         (producer_is_realview): Change return type to bool.
 117         (compare_filenames_for_search): Likewise.
 118         (compare_glob_filenames_for_search): Likewise.
 119
 120 2019-09-26  Tom Tromey  <tom@tromey.com>
 121
 122         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 123         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 124         * gdb_usleep.h: Remove.
 125         * gdb_usleep.c: Remove.
 126         * utils.c: Don't include gdb_usleep.h.
 127
 128 2019-09-26  Tom Tromey  <tromey@adacore.com>
 129
 130         * python/py-type.c (type_to_type_object): Call check_typedef
 131         for stub types.
 132
 133 2019-09-26  Tom Tromey  <tom@tromey.com>
 134
 135         * utils.h (initialize_utils): Don't declare.
 136         * top.c (gdb_init): Don't call initialize_utils.
 137         * utils.c (initialize_utils): Remove.  Move contents...
 138         (_initialize_utils): ... here.
 139
 140 2019-09-25  Tom Tromey  <tom@tromey.com>
 141
 142         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 143         * utils.h (make_hex_string): Don't declare.
 144         * utils.c (make_hex_string): Remove.
 145
 146 2019-09-24  Tom de Vries  <tdevries@suse.de>
 147
 148         PR gdb/23815
 149         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 150         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 151
 152 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 153
 154         * NEWS: Mention new simulator port for PRU.
 155
 156 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * ada-exp.y (write_object_remaining): Update.
 159         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 160         and eliminate the static buffer.
 161         (ada_decode_symbol): Update.
 162         (ada_la_decode): Update.
 163         (ada_sniff_from_mangled_name): Update.
 164         (is_valid_name_for_wild_match): Update.
 165         (ada_lookup_name_info::matches): Update and simplify.
 166         (name_matches_regex): Update.
 167         (ada_add_global_exceptions): Update.
 168         * ada-lang.h (ada_decode): Update signature.
 169         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 170         * dwarf-index-write.c (debug_names::insert): Update.
 171
 172 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 173
 174         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 175         formatting.
 176
 177 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 178
 179         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 180         Change "nonzero" to "true" in documentation.
 181
 182 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 183
 184         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 185         (_initialize_darwin_solib): Don't set
 186         darwin_so_ops.lookup_lib_global_symbol.
 187         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 188         set_gdbarch_iterate_over_objfiles_in_search_order.
 189         (elf_lookup_lib_symbol): Rename to...
 190         (svr4_iterate_over_objfiles_in_search_order): this, and update
 191         to iterate semantics.
 192         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 193         * solib.c (solib_global_lookup): Remove.
 194         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 195         (solib_global_lookup): Remove.
 196         * symtab.c (lookup_global_or_static_symbol): Remove call to
 197         solib_global_lookup.
 198
 199 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 200
 201         * NEWS: Move entries about default MI version now being
 202         version 3, and about the GDB/MI fix for multi-location
 203         breakpoints to the "since GDB 8.3" section.
 204
 205 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 206
 207         GDB 8.3.1 released.
 208
 209 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 210
 211         * NEWS: Mention that Cell/B.E. debugging support was removed.
 212         * MAINTAINERS: Remove spu target.
 213
 214         * config/djgpp/fnchange.lst: Remove entries for removed files.
 215
 216         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 217         spu-multiarch.o, and spu-tdep.o.
 218         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 219         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 220         spu-multiarch.c, and spu-tdep.c.
 221         * spu-linux-nat.c: Remove file.
 222         * spu-multiarch.c: Remove file.
 223         * spu-tdep.c: Remove file.
 224         * spu-tdep.h: Remove file.
 225         * solib-spu.c: Remove file.
 226         * solib-spu.h: Remove file.
 227
 228         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 229         * configure.nat (spu-linux): Remove.
 230         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 231         solib-multiarch.o from gdb_target_obs.
 232         (spu*-*-*): Remove.
 233
 234         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 235         feature flag.
 236         (ppc_linux_no_features): Update.
 237         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 238         Cell/B.E. support.
 239         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 240         (tdesc_powerpc_cell64l): Likewise.
 241         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 242         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 243         Cell/B.E. support.
 244         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 245         Do not include "features/rs6000/powerpc-cell32l.c" or
 246         "features/rs6000/powerpc-cell64l.c".
 247         (ppc_linux_spu_section): Remove.
 248         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 249         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 250         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 251         (ppc_linux_spe_context_lookup): Remove.
 252         (ppc_linux_spe_context_inferior_created): Remove.
 253         (ppc_linux_spe_context_solib_loaded): Remove.
 254         (ppc_linux_spe_context_solib_unloaded): Remove.
 255         (ppc_linux_spe_context): Remove.
 256         (struct ppu2spu_cache): Remove.
 257         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 258         (struct ppu2spu_data): Remove.
 259         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 260         ppu2spu_unwind): Remove.
 261         (ppc_linux_init_abi): Remove Cell/B.E. support.
 262         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 263
 264         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 265         (rs6000/powerpc-cell64l-expedite): Likewise
 266         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 267         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 268         rs6000/powerpc-cell64l.xml.
 269         * features/rs6000/powerpc-cell32l.xml: Remove.
 270         * features/rs6000/powerpc-cell64l.xml: Likewise.
 271         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 272         * features/rs6000/powerpc-cell64l.c: Likewise.
 273         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 274         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 275         * regformats/reg-spu.dat: Remove.
 276
 277         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 278         * corelow.c (struct spuid_list): Remove.
 279         (add_to_spuid_list): Remove.
 280         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 281         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 282         (remote_protocol_features): Remove associated entries.
 283         (_initialize_remote): No longer initialize them.
 284         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 285         * linux-nat.c (SPUFS_MAGIC): Remove.
 286         (linux_proc_xfer_spu): Remove.
 287         (spu_enumerate_spu_ids): Remove.
 288         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 289         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 290         (linux_make_corefile_notes): No longer call it.
 291
 292         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 293         (cooked_write_test): Likewise.
 294
 295 2019-09-20  Tom Tromey  <tom@tromey.com>
 296
 297         * NEWS: Mention case-sensitivity of TUI commands.
 298         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 299         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 300         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 301
 302 2019-09-20  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-source.c (tui_source_window::set_contents): Use
 305         make_unique_xstrdup.
 306         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 307         make_unique_xstrdup.
 308
 309 2019-09-20  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-data.c: Remove separator comments.
 312         * tui/tui-layout.c: Remove separator comments.
 313         * tui/tui-win.c: Remove separator comments.
 314         * tui/tui-wingeneral.c: Remove separator comments.
 315
 316 2019-09-20  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui.h (strcat_to_buf): Don't declare.
 319         * tui/tui.c (strcat_to_buf): Remove.
 320
 321 2019-09-20  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 324         from "fullname".
 325         * tui/tui-source.c (tui_source_window::set_contents)
 326         (tui_source_window::location_matches_p)
 327         (tui_source_window::maybe_update): Update.
 328
 329 2019-09-20  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 332         Update.
 333         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 334         prefix.
 335         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 336         (tui_data_window::line_from_reg_element_no)
 337         (tui_data_window::first_reg_element_no_inline)
 338         (tui_data_window::show_registers)
 339         (tui_data_window::show_register_group)
 340         (tui_data_window::display_registers_from)
 341         (tui_data_window::display_registers_from_line)
 342         (tui_data_window::first_data_item_displayed)
 343         (tui_data_window::delete_data_content_windows)
 344         (tui_data_window::erase_data_content)
 345         (tui_data_window::do_scroll_vertical)
 346         (tui_data_window::refresh_window)
 347         (tui_data_window::check_register_values): Update.
 348
 349 2019-09-20  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 352         (struct tui_locator_window) <full_name, proc_name>: Now
 353         std::string.
 354         * tui/tui-stack.c (tui_locator_window::make_status_line)
 355         (tui_locator_window::set_locator_fullname)
 356         (tui_locator_window::set_locator_info): Update.
 357         * tui/tui-source.c (tui_source_window::set_contents)
 358         (tui_source_window::showing_source_p): Update.
 359
 360 2019-09-20  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 363         Don't call tui_locator_win_info_ptr.
 364
 365 2019-09-20  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 368
 369 2019-09-20  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 372         height for locator.
 373         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 374         * tui/tui-layout.c (show_source_disasm_command, show_data)
 375         (show_source_or_disasm_and_command): Use 1 as height for locator.
 376
 377 2019-09-20  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui.c (tui_enable): Update.
 380         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 381         Update.
 382         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 383         Update.
 384         * tui/tui-data.c (win_resized): Now bool.
 385         (tui_win_resized): Return bool.
 386         (tui_set_win_resized_to): Accept a bool.
 387
 388 2019-09-20  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 391         Change type of "refresh_values_only".
 392         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 393         type of "refresh_values_only".
 394
 395 2019-09-20  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 398         std::string.
 399         (tui_disassemble): Add "pos" parameter.
 400         (tui_disasm_window::set_contents): Simplify.
 401
 402 2019-09-20  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-winsource.h (struct tui_source_window_base)
 405         <show_source_content>: Now private.
 406         * tui/tui-winsource.c
 407         (tui_source_window_base::show_source_content): Don't handle empty
 408         content case.
 409
 410 2019-09-20  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-layout.c (show_source_disasm_command)
 413         (show_source_or_disasm_and_command): Don't call
 414         show_source_content.
 415
 416 2019-09-20  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 419         Declare.
 420         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 421         from tui_make_status_line.
 422         (tui_locator_window::rerender): Update.
 423
 424 2019-09-20  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 427         (tui_locator_window::rerender): Update.
 428
 429 2019-09-20  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-winsource.h (struct tui_source_window_base)
 432         <~tui_source_window_base>: Don't declare.
 433         <fullname>: Remove.
 434         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 435         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 436         member.
 437         * tui/tui-source.c (tui_source_window::set_contents): Update.
 438         (tui_source_window::location_matches_p)
 439         (tui_source_window::maybe_update): Update.
 440
 441 2019-09-20  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-winsource.h (~tui_source_element): Remove.
 444         (tui_source_element): Update.
 445         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 446         * tui/tui-winsource.c (tui_show_source_line): Update.
 447         * tui/tui-source.c (tui_source_window::set_contents): Update.
 448         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 449
 450 2019-09-20  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 453         declare.
 454         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 455         tui_clear_source_windows_detail.
 456         * tui/tui-winsource.h (struct tui_source_window_base)
 457         <clear_detail>: Don't declare.
 458         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 459         Remove.
 460         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 461
 462 2019-09-20  Tom Tromey  <tromey@adacore.com>
 463
 464         PR ada/24919:
 465         * block.c (contained_in): Fix final return value.
 466
 467 2019-09-20  Alan Modra  <amodra@gmail.com>
 468
 469         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 470         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 471         (read_indirect_string_from_dwz): Use bfd accessor.
 472         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 473         * machoread.c (macho_symfile_read_all_oso): Likewise.
 474         * solib.c (solib_bfd_open): Likewise.
 475
 476 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 477
 478         * eval.c: Move declaration of overload_resolution to...
 479         * value.h: ...here.
 480
 481 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 482
 483         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 484         * arm-linux-tdep.c: Likewise.
 485         * arm-nbsd-nat.c: Likewise.
 486         * arm-tdep.h: Declare arm_apcs_32.
 487         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 488
 489 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 490
 491         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 492         * dwarf2read.h: Declare dwarf_always_disassemble.
 493
 494 2019-09-19  Tom de Vries  <tdevries@suse.de>
 495
 496         PR gdb/25009
 497         * source-cache.c (source_cache::ensure): Catch exception thrown during
 498         construction of the highlighter.
 499
 500 2019-09-18  Alan Modra  <amodra@gmail.com>
 501
 502         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 503         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 504         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 505         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 506         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 507         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 508         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 509         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 510         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 511         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 512         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 513         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 514         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 515         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 516         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 517         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 518         * mi/mi-interp.c: Update throughout for bfd section macro and
 519         function changes.
 520         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 521         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 522
 523 2019-09-18  Tom Tromey  <tom@tromey.com>
 524
 525         * NEWS: Add entry.
 526         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 527         call rl_initialize.
 528         (tui_enable): Do not call rl_initialize.
 529
 530 2019-09-18  Christian Groessler  <chris@groessler.org>
 531
 532         * alpha-linux-nat.c: Include gdbarch.h.
 533
 534 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 535
 536         * ui-file.c: Include cli/cli-style.h.
 537         (term_cli_styling): Remove cli_styling declaration.
 538
 539 2019-09-18  Alan Modra  <amodra@gmail.com>
 540
 541         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 542         to bfd_asymbol_section.
 543
 544 2019-09-18  Alan Modra  <amodra@gmail.com>
 545
 546         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 547         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 548         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 549
 550 2019-09-18  Alan Modra  <amodra@gmail.com>
 551
 552         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 553         * spu-linux-nat.c (spu_bfd_open): Likewise.
 554
 555 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 556
 557         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 558         to bool to match definition in dwarf2read.c.
 559
 560 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 563         (print_signatures): Likewise.
 564         (trust_pad_over_xvs): Likewise.
 565         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 566         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 567         * arm-linux-nat.c (arm_apcs_32): Likewise.
 568         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 569         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 570         * arm-tdep.c (arm_debug): Likewise.
 571         (arm_apcs_32): Likewise.
 572         * auto-load.c (debug_auto_load): Likewise.
 573         (auto_load_gdb_scripts): Likewise.
 574         (global_auto_load): Likewise.
 575         (auto_load_local_gdbinit): Likewise.
 576         (auto_load_local_gdbinit_loaded): Likewise.
 577         * auto-load.h (global_auto_load): Likewise.
 578         (auto_load_local_gdbinit): Likewise.
 579         (auto_load_local_gdbinit_loaded): Likewise.
 580         * breakpoint.c (disconnected_dprintf): Likewise.
 581         (breakpoint_proceeded): Likewise.
 582         (automatic_hardware_breakpoints): Likewise.
 583         (always_inserted_mode): Likewise.
 584         (target_exact_watchpoints): Likewise.
 585         (_initialize_breakpoint): Update.
 586         * breakpoint.h (target_exact_watchpoints): Change to bool.
 587         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 588         * cli/cli-cmds.c (trace_commands): Likewise.
 589         * cli/cli-cmds.h (trace_commands): Likewise.
 590         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 591         to bool*.
 592         * cli/cli-logging.c (logging_overwrite): Change to bool.
 593         (logging_redirect): Likewise.
 594         (debug_redirect): Likewise.
 595         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 596         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 597         to bool.
 598         <boolean_option_def>: Update.
 599         (struct flag_option_def): Change default type of Context to bool
 600         from int.
 601         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 602         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 603         (get_setshow_command_value_string): Likewise.
 604         * cli/cli-style.c (cli_styling): Change to bool.
 605         (source_styling): Likewise.
 606         * cli/cli-style.h (source_styling): Likewise.
 607         (cli_styling): Likewise.
 608         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 609         to bool.
 610         * command.h (var_types): Update comment.
 611         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 612         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 613         bool.
 614         (debug_compile_cplus_scopes): Likewise.
 615         * compile/compile-internal.h (compile_debug): Likewise.
 616         * compile/compile.c (compile_debug): Likewise.
 617         (struct compile_options) <raw>: Likewise.
 618         * cp-support.c (catch_demangler_crashes): Likewise.
 619         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 620         (usr_cmd_cris_dwarf2_cfi): Likewise.
 621         * csky-tdep.c (csky_debug): Likewise.
 622         * darwin-nat.c (enable_mach_exceptions): Likewise.
 623         * dcache.c (dcache_enabled_p): Likewise.
 624         * defs.h (info_verbose): Likewise.
 625         * demangle.c (demangle): Likewise.
 626         (asm_demangle): Likewise.
 627         * dwarf-index-cache.c (debug_index_cache): Likewise.
 628         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 629         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 630         * dwarf2read.c (check_physname): Likewise.
 631         (use_deprecated_index_sections): Likewise.
 632         (dwarf_always_disassemble): Likewise.
 633         * eval.c (overload_resolution): Likewise.
 634         * event-top.c (set_editing_cmd_var): Likewise.
 635         (exec_done_display_p): Likewise.
 636         * event-top.h (set_editing_cmd_var): Likewise.
 637         (exec_done_display_p): Likewise.
 638         * exec.c (write_files): Likewise.
 639         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 640         (debug_fbsd_nat): Likewise.
 641         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 642         Likewise.
 643         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 644         <backtrace_past_entry> Likewise.
 645         * gdb-demangle.h (demangle): Likewise.
 646         (asm_demangle): Likewise.
 647         * gdb_bfd.c (bfd_sharing): Likewise.
 648         * gdbcore.h (write_files): Likewise.
 649         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 650         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 651         * gdbthread.h (print_thread_events): Likewise.
 652         * gdbtypes.c (opaque_type_resolution): Likewise.
 653         (strict_type_checking): Likewise.
 654         * gnu-nat.c (gnu_debug_flag): Likewise.
 655         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 656         * guile/scm-param.c (pascm_variable): Add boolval.
 657         (add_setshow_generic): Update.
 658         (pascm_param_value): Update.
 659         (pascm_set_param_value_x): Update.
 660         * hppa-tdep.c (hppa_debug): Change to bool..
 661         * infcall.c (may_call_functions_p): Likewise.
 662         (coerce_float_to_double_p): Likewise.
 663         (unwind_on_signal_p): Likewise.
 664         (unwind_on_terminating_exception_p): Likewise.
 665         * infcmd.c (startup_with_shell): Likewise.
 666         * inferior.c (print_inferior_events): Likewise.
 667         * inferior.h (startup_with_shell): Likewise.
 668         (print_inferior_events): Likewise.
 669         * infrun.c (step_stop_if_no_debug): Likewise.
 670         (detach_fork): Likewise.
 671         (debug_displaced): Likewise.
 672         (disable_randomization): Likewise.
 673         (non_stop): Likewise.
 674         (non_stop_1): Likewise.
 675         (observer_mode): Likewise.
 676         (observer_mode_1): Likewise.
 677         (set_observer_mode): Update.
 678         (sched_multi): Change to bool.
 679         * infrun.h (debug_displaced): Likewise.
 680         (sched_multi): Likewise.
 681         (step_stop_if_no_debug): Likewise.
 682         (non_stop): Likewise.
 683         (disable_randomization): Likewise.
 684         * linux-tdep.c (use_coredump_filter): Likewise.
 685         (dump_excluded_mappings): Likewise.
 686         * linux-thread-db.c (auto_load_thread_db): Likewise.
 687         (check_thread_db_on_load): Likewise.
 688         * main.c (captured_main_1): Update.
 689         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 690         xx2_opt, boolean_opt>: Change to bool.
 691         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 692         * maint.c (maintenance_profile_p): Likewise.
 693         (per_command_time): Likewise.
 694         (per_command_space): Likewise.
 695         (per_command_symtab): Likewise.
 696         * memattr.c (inaccessible_by_default): Likewise.
 697         * mi/mi-main.c (mi_async): Likewise.
 698         (mi_async_1): Likewise.
 699         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 700         * nat/fork-inferior.h (startup_with_shell): Likewise.
 701         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 702         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 703         * nios2-tdep.c (nios2_debug): Likewise.
 704         * or1k-tdep.c (or1k_debug): Likewise.
 705         * parse.c (parser_debug): Likewise.
 706         * parser-defs.h (parser_debug): Likewise.
 707         * printcmd.c (print_symbol_filename): Likewise.
 708         * proc-api.c (procfs_trace): Likewise.
 709         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 710         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 711         (set_parameter_value): Update.
 712         (add_setshow_generic): Update.
 713         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 714         to bool*.
 715         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 716         int*.
 717         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 718         * record-btrace.c (record_btrace_target::store_registers): Update.
 719         * record-full.c (record_full_memory_query): Change to bool.
 720         (record_full_stop_at_limit): Likewise.
 721         * record-full.h (record_full_memory_query): Likewise.
 722         * remote-notif.c (notif_debug): Likewise.
 723         * remote-notif.h (notif_debug): Likewise.
 724         * remote.c (use_range_stepping): Likewise.
 725         (interrupt_on_connect): Likewise.
 726         (remote_break): Likewise.
 727         * ser-tcp.c (tcp_auto_retry): Likewise.
 728         * ser-unix.c (serial_hwflow): Likewise.
 729         * skip.c (debug_skip): Likewise.
 730         * solib-aix.c (solib_aix_debug): Likewise.
 731         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 732         (spu_auto_flush_cache_p): Likewise.
 733         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 734         Likewise.
 735         (struct info_print_options) <quiet>: Likewise.
 736         * symfile-debug.c (debug_symfile): Likewise.
 737         * symfile.c (auto_solib_add): Likewise.
 738         (separate_debug_file_debug): Likewise.
 739         * symfile.h (auto_solib_add): Likewise.
 740         (separate_debug_file_debug): Likewise.
 741         * symtab.c (basenames_may_differ): Likewise.
 742         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 743         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 744         (struct info_types_options) <quiet>: Likewise.
 745         * symtab.h (demangle): Likewise.
 746         (basenames_may_differ): Likewise.
 747         * target-dcache.c (stack_cache_enabled_1): Likewise.
 748         (code_cache_enabled_1): Likewise.
 749         * target.c (trust_readonly): Likewise.
 750         (may_write_registers): Likewise.
 751         (may_write_memory): Likewise.
 752         (may_insert_breakpoints): Likewise.
 753         (may_insert_tracepoints): Likewise.
 754         (may_insert_fast_tracepoints): Likewise.
 755         (may_stop): Likewise.
 756         (auto_connect_native_target): Likewise.
 757         (target_stop_and_wait): Update.
 758         (target_async_permitted): Change to bool.
 759         (target_async_permitted_1): Likewise.
 760         (may_write_registers_1): Likewise.
 761         (may_write_memory_1): Likewise.
 762         (may_insert_breakpoints_1): Likewise.
 763         (may_insert_tracepoints_1): Likewise.
 764         (may_insert_fast_tracepoints_1): Likewise.
 765         (may_stop_1): Likewise.
 766         * target.h (target_async_permitted): Likewise.
 767         (may_write_registers): Likewise.
 768         (may_write_memory): Likewise.
 769         (may_insert_breakpoints): Likewise.
 770         (may_insert_tracepoints): Likewise.
 771         (may_insert_fast_tracepoints): Likewise.
 772         (may_stop): Likewise.
 773         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 774         (make_thread_apply_all_options_def_group): Change argument from int*
 775         to bool*.
 776         (thread_apply_all_command): Update.
 777         (print_thread_events): Change to bool.
 778         * top.c (confirm): Likewise.
 779         (command_editing_p): Likewise.
 780         (history_expansion_p): Likewise.
 781         (write_history_p): Likewise.
 782         (info_verbose): Likewise.
 783         * top.h (confirm): Likewise.
 784         (history_expansion_p): Likewise.
 785         * tracepoint.c (disconnected_tracing): Likewise.
 786         (circular_trace_buffer): Likewise.
 787         * typeprint.c (print_methods): Likewise.
 788         (print_typedefs): Likewise.
 789         * utils.c (debug_timestamp): Likewise.
 790         (sevenbit_strings): Likewise.
 791         (pagination_enabled): Likewise.
 792         * utils.h (sevenbit_strings): Likewise.
 793         (pagination_enabled): Likewise.
 794         * valops.c (overload_resolution): Likewise.
 795         * valprint.h (struct value_print_options) <prettyformat_arrays,
 796         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 797         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 798         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 799         Likewise.
 800         * windows-nat.c (new_console): Likewise.
 801         (cygwin_exceptions): Likewise.
 802         (new_group): Likewise.
 803         (debug_exec): Likewise.
 804         (debug_events): Likewise.
 805         (debug_memory): Likewise.
 806         (debug_exceptions): Likewise.
 807         (useshell): Likewise.
 808         * windows-tdep.c (maint_display_all_tib): Likewise.
 809         * xml-support.c (debug_xml): Likewise.
 810
 811 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 812
 813         * source.c (prepare_path_for_appending): New function.
 814         (openp): Make use of new function.
 815         (find_and_open_source): Search for the compilation directory and
 816         source file as a relative path beneath the directory search path.
 817
 818 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * source-cache.c (source_cache::get_line_charpos): Catch
 821         exceptions and return false, this matches the behaviour documented
 822         in the header file.
 823
 824 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 825
 826         * ada-tasks.c (info_task): Remove quoting of the task's name.
 827
 828 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 829
 830         * symfile.c (auto_solib_add): Replace comment with a reference
 831         to the header file.
 832
 833 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 834
 835         * NEWS: Mention that gdb can now be compiled with Python 3
 836         on Windows.
 837
 838 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * maint.c (maint_print_section_data::maint_print_section_data):
 841         Force use of 'float log10 (float)' by casting the argument to
 842         float.
 843
 844 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 845
 846         * maint.c: Add 'cmath' include.
 847         (struct maint_print_section_data): New structure.
 848         (print_section_index): New function.
 849         (print_bfd_section_info): Add header comment, small whitespace
 850         cleanup, and update to call new print_section_index function.
 851         (print_objfile_section_info): Likewise.
 852         (maint_obj_section_from_bfd_section): New function.
 853         (print_bfd_section_info_maybe_relocated): New function.
 854         (maintenance_info_sections): Add header comment, always use
 855         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 856
 857 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 860         inner scope, add check that the objfile has psymtabs before
 861         checking psymtabs_addrmap.
 862         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 863
 864 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865
 866         * NEWS: Announce that Ada task names are now shown at more places,
 867         and between quotes (except in info task output).
 868         * gdb/ada-tasks.c (task_to_str): New function.
 869         (display_current_task_id): Call task_to_str.
 870         (task_command_1): Likewise.
 871         (print_ada_task_info): In non-mi mode, Properly align headers and data
 872         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 873
 874 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 875
 876         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 877         prstatus.pr_lwp.pr_info instead of making it up.
 878
 879 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 880
 881         * auto-load.c (auto_load_expand_dir_vars): Update.
 882         * defs.h (gdb_datadir): Change to std::string.
 883         (python_libdir): Likewise.
 884         (relocate_gdb_directory): Change return type to std::string.
 885         * guile/guile.c (gdbscm_data_directory): Update.
 886         (initialize_scheme_side): Update.
 887         * jit.c (jit_reader_dir): Change to std::string.
 888         (jit_reader_load_command): Update.
 889         * main.c (gdb_datadir): Change to std::string.
 890         (python_libdir): Likewise.
 891         (set_gdb_data_directory): Update.
 892         (relocate_path): Change to return std::string.
 893         (relocate_gdb_directory): Change to return std::string.
 894         (relocate_gdbinit_path_maybe_in_datadir): Update.
 895         (captured_main_1): Update.
 896         * python/python.c (do_start_initialization): Update.
 897         * top.c (show_gdb_datadir): Update.
 898         * xml-syscall.c (xml_init_syscalls_info): Update.
 899         (init_syscalls_info): Update.
 900
 901 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 902
 903         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 904         out of get_init_files.
 905         (get_init_files): Update.
 906
 907 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 908
 909         * main.c (get_init_files): Change to use std::string.
 910         (captured_main_1): Update.
 911         (print_gdb_help): Update.
 912
 913 2019-09-11  Ali Tamur  <tamur@google.com>
 914
 915         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 916         implementation.
 917
 918 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 919
 920         * dbxread.c (read_dbx_symtab): Update.
 921         * dwarf2read.c (load_partial_dies): Update.
 922         * mdebugread.c (parse_partial_symbols): Update.
 923         (handle_psymbol_enumerators): Update.
 924         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 925         * psymtab.c (add_psymbol_to_bcache): Likewise.
 926         (add_psymbol_to_list): Likewise.
 927         * symtab.c (symbol_set_names): Likewise.
 928         * symtab.h (symbol_set_names): Likewise.
 929         * xcoffread.c (scan_xcoff_symtab): Update.
 930
 931 2019-09-11  Tom Tromey  <tom@tromey.com>
 932
 933         * symfile-mem.c (symbol_file_add_from_memory): Use
 934         bfd_set_filename.
 935         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 936         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 937
 938 2019-09-10  Tom Tromey  <tromey@adacore.com>
 939
 940         * dwarf-index-write.c (write_psymbols): Extend error message.
 941         (debug_names::insert): Add Ada code.
 942         (debug_names::write_psymbols): Remove Ada check.
 943         (debug_names) <m_string_obstack>: New member.
 944         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 945         (gdb_index_symbol_name_matcher::matches): Remove.
 946         (mapped_index_base::find_name_components_bounds): Add "lang"
 947         parameter.
 948         (mapped_index_base::build_name_components): Also split names
 949         according to Ada syntax.
 950         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 951         type of "match_callback".
 952         (check_match, check_find_bounds_finds)
 953         (dw2_expand_symtabs_matching): Update.
 954         (dw2_debug_names_iterator): Add new constructor.
 955         (dw2_debug_names_map_matching_symbols): New function.
 956         (dw2_debug_names_expand_symtabs_matching): Update.
 957         (dwarf2_debug_names_functions): Use
 958         dw2_debug_names_map_matching_symbols.
 959
 960 2019-09-10  Tom Tromey  <tromey@adacore.com>
 961
 962         * dwarf2read.c (dw2_get_file_names_reader): Add the
 963         CU's file name to the results.
 964
 965 2019-09-10  Tom Tromey  <tromey@adacore.com>
 966
 967         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 968         map_matching_symbols.  Update.
 969         * dwarf2read.c (dw2_map_matching_symbols): Update.
 970         * psymtab.c (match_partial_symbol): Change type; update.
 971         (psym_map_matching_symbols): Likewise.
 972         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 973         type; update.
 974         * symfile.h (struct quick_symbol_functions)
 975         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 976         Remove "match".
 977
 978 2019-09-10  Tom Tromey  <tromey@adacore.com>
 979
 980         * psymtab.c (map_block): Remove.
 981         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 982         * symtab.c (iterate_over_symbols_terminated): New function.
 983         * symtab.c (iterate_over_symbols_terminated): Declare.
 984
 985 2019-09-10  Tom Tromey  <tromey@adacore.com>
 986
 987         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 988         * language.h (struct language_defn) <la_iterate_over_symbols>:
 989         Return bool.
 990         * symtab.c (iterate_over_symbols): Return bool.
 991         * symtab.h (iterate_over_symbols): Return bool.
 992
 993 2019-09-10  Tom Tromey  <tromey@adacore.com>
 994
 995         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 996         (add_nonlocal_symbols): Update.
 997         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 998         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 999         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1000         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1001         Change type of "callback".  Remove "data".
1002
1003
1004 2019-09-09  Ali Tamur  <tamur@google.com>
1005
1006         * dwarf2read.c (comp_unit_head): Update comment.
1007         (dwarf2_dwo_name): New function declaration.
1008         (dwarf_unit_type_name): New function declaration.
1009         (read_comp_unit_head): Add support for new compilation units,
1010         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1011         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1012         (currently named as "signature") in their header. Also clarify error
1013         messages.
1014         (lookup_dwo_id): New function. Returns the dwo id of the given
1015         compile unit.
1016         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1017         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1018         functions.
1019         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1020         (dwarf2_dwo_name): Get the dwo name if present.
1021         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1022         purposes.
1023
1024 2019-09-09  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1027
1028 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1029
1030         * python/python.c (do_start_initialization): Make progname_copy static,
1031         to avoid a leak report.
1032
1033 2019-09-08  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1036
1037 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1038
1039         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1040         Change type to gdb::optional<block_enum>.
1041         (dw2_symtab_iter_init): Change block_index parameter type
1042         to gdb::optional<block_enum>.
1043         (dw2_lookup_symbol): Change block_index parameter
1044         type to block_enum.c
1045         (dw2_debug_names_lookup_symbol): Likewise.
1046         * psymtab.c (psym_lookup_symbol): Likewise.
1047         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1048         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1049         Likewise.
1050
1051 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * defs.h (relocate_gdb_directory): Change int to bool in
1054         signature and rename flag to relocatable.
1055         * main.c (relocate_path): Likewise.
1056         (relocate_gdb_directory): Likewise.
1057
1058 2019-09-06  Alan Modra  <amodra@gmail.com>
1059
1060         * coffread.c (coff_symfile_read): Constify filename variable.
1061         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1062         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1063         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1064         * solib.c (reload_shared_libraries_1): Likewise.
1065         * symfile.c (reread_symbols): Likewise.
1066         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1067         * solib-darwin.c (darwin_bfd_open): Likewise.
1068         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1069
1070 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1073         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1074
1075 2019-09-03  Tom Tromey  <tromey@adacore.com>
1076
1077         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1078         types.
1079         (has_negatives): Unbias a range type bound.
1080         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1081         * gdbtypes.c (operator==): Handle new field.
1082         (create_range_type): Add "bias" parameter.
1083         (create_static_range_type, resolve_dynamic_range): Update.
1084         * gdbtypes.h (struct range_bounds) <bias>: New member.
1085         (create_range_type): Add bias parameter.
1086         * printcmd.c (print_scalar_formatted): Unbias range types.
1087         * value.c (unpack_long): Unbias range types.
1088         (pack_long): Bias range types.
1089
1090 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1091
1092         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1093         probe arguments.
1094
1095 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1098         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1099         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1100         (compile_probe_arg): Likewise.
1101         * probe.h (get_argument_count): Likewise.
1102         * solib-svr4.c (solib_event_probe_action): Likewise.
1103         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1104
1105 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1106
1107         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1108         code to here...
1109         (svr4_create_solib_event_breakpoints): ...from here.
1110
1111 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1112
1113         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1114         suffix from warning message.
1115
1116 2019-08-30  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-winsource.h (struct tui_source_window_base)
1119         <refresh_all>: Don't declare.
1120         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1121         Remove.
1122         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1123         tui_show_locator_content.
1124         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1125         declare.
1126         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1127         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1128         declare.
1129
1130 2019-08-30  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1133
1134 2019-08-30  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1137         Remove unnecessary forward declarations.
1138
1139 2019-08-30  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1142         rerender.
1143         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1144         tui_show_locator_content.
1145
1146 2019-08-30  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1149         (tui_locator_window::rerender): Rewrite using body of previous
1150         tui_show_locator_content.
1151
1152 2019-08-30  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1155         set_locator_fullname>: New methods.
1156         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1157         Rename from tui_set_locator_fullname.
1158         (tui_locator_window::set_locator_info): Rename from
1159         tui_set_locator_info.  Return bool.
1160         (tui_update_locator_fullname, tui_show_frame_info): Update.
1161
1162 2019-08-30  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1165
1166 2019-08-30  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1169         call touchwin.
1170
1171 2019-08-30  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-wingeneral.c (box_win): Assume win_info and
1174         win_info->handle cannot be NULL.
1175
1176 2019-08-30  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1179         refresh_window>: Declare.
1180         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1181         resize.
1182         (tui_data_item_window::rerender): Rename from
1183         tui_display_register.
1184         (tui_data_item_window::refresh_window): New method.
1185         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1186         no-op.
1187
1188 2019-08-30  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1191         regs_column_count, current_group>: Move later.  Now private.
1192         <get_current_group>: New method.
1193         * tui/tui-regs.c (tui_reg_command): Update.
1194         * tui/tui-layout.c (tui_set_layout): Update.
1195
1196 2019-08-30  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1199         (tui_data_window::rerender): Don't call
1200         check_and_display_highlight_if_needed.
1201         (tui_data_window::refresh_all): Remove call to
1202         erase_data_content.
1203
1204 2019-08-30  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1207         (tui_data_window::display_registers_from)
1208         (tui_data_window::display_reg_element_at_line)
1209         (tui_data_window::display_registers_from_line): Remove checks of
1210         "empty".
1211
1212 2019-08-30  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1215         Don't declare.
1216         * tui/tui-regs.c (tui_data_window::show_registers): Call
1217         rerender.
1218         (tui_data_window::rerender): Rename from display_all_data.
1219         (tui_data_window::rerender): Remove old implementation.
1220
1221 2019-08-30  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1224         text.
1225         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1226
1227 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1228             Sergio Durigan Junior  <sergiodj@redhat.com>
1229
1230         PR win32/24284
1231         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1232
1233 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1236         when searching for types.
1237
1238 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * f-lang.c (f_language_defn): Use f_print_typedef.
1241         * f-lang.h (f_print_typedef): Declare.
1242         * f-typeprint.c (f_print_typedef): Define.
1243
1244 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1245
1246         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1247
1248 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * cli/cli-utils.c (info_print_options_defs): Delete.
1251         (make_info_print_options_def_group): Delete.
1252         (extract_info_print_options): Delete.
1253         (info_print_command_completer): Delete.
1254         (info_print_args_help): Add extra parameter, and optionally
1255         include text about -n flag.
1256         * cli/cli-utils.h (struct info_print_options): Delete.
1257         (extract_info_print_options): Delete declaration.
1258         (info_print_command_completer): Delete declaration.
1259         (info_print_args_help): Add extra parameter, extend header
1260         comment.
1261         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1262         search_symbols.
1263         * stack.c (struct info_print_options): New type.
1264         (info_print_options_defs): New file scoped variable.
1265         (make_info_print_options_def_group): New static function.
1266         (info_print_command_completer): New static function.
1267         (info_locals_command): Update to use new local functions.
1268         (info_args_command): Likewise.
1269         (_initialize_stack): Add extra parameter to calls to
1270         info_print_args_help.
1271         * symtab.c (search_symbols): Add extra parameter, use this to
1272         possibly excluse non-debug symbols.
1273         (symtab_symbol_info): Add extra parameter, which is passed on to
1274         search_symbols.
1275         (struct info_print_options): New type.
1276         (info_print_options_defs): New file scoped variable.
1277         (make_info_print_options_def_group): New static function.
1278         (info_print_command_completer): New static function.
1279         (info_variables_command): Update to use local functions, and pass
1280         extra parameter through to symtab_symbol_info.
1281         (info_functions_command): Likewise.
1282         (info_types_command): Pass additional argument through to
1283         symtab_symbol_info.
1284         (rbreak_command): Pass extra argument to search_symbols.
1285         (_initialize_symtab): Add extra arguments for calls to
1286         info_print_args_help, and update help text for 'info variables',
1287         'whereis', and 'info functions' commands.
1288         * symtab.h (search_symbols): Add extra argument to declaration.
1289         * NEWS: Mention new flags.
1290
1291 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1292
1293         * symtab.c (lookup_static_symbol): Call the new function (and move
1294         it down to be next to lookup_global_symbol).
1295         (struct global_sym_lookup_data): Add block_enum member and rename to...
1296         (struct global_or_static_sym_lookup_data): ...this.
1297         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1298         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1299         (lookup_symbol_global_or_static_iterator_cb): ...this.
1300         (lookup_global_or_static_symbol): New function.
1301         (lookup_global_symbol): Call new function.
1302
1303 2019-08-26  Tom de Vries  <tdevries@suse.de>
1304
1305         PR c++/24852
1306         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1307         when pc_probe.prob == NULL.
1308
1309 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1310
1311         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1312         variable symbol_linkage to symbol_linkage_.
1313
1314 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1315
1316         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1317         represent whether the symbol is static, dynamic, or we don't
1318         know.
1319
1320 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1321
1322         * gdb/rx-tdep.c (rx_register_names): New.
1323         (rx_register_name): Delete.
1324         (rx_psw_type): Delete.
1325         (rx_fpsw_type): Delete.
1326         (rx_register_type): Delete.
1327         (rx_gdbarch_init): Convert target-descriptions.
1328         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1329         * gdb/features/Makefile: Add rx.xml.
1330         * gdb/features/rx.xml: New.
1331         * gdb/features/rx.c: Generated.
1332         * gdb/NEWS: Mention target description support.
1333
1334 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1335
1336         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1337         *slot_ptr.
1338
1339 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1340
1341         * configure.ac: Don't check for 'dlfcn.h' (moved to
1342         gdbsupport/common.m4).
1343         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1344         'gdbsupport/'.
1345         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1346         * compile/compile-c-support.c: Include
1347         'gdbsupport/gdb-dlfcn.h'.
1348         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1349         * gdb-dlfcn.c: Move to...
1350         * gdbsupport/gdb-dlfcn.c: ... here.
1351         * gdb-dlfcn.h: Move to...
1352         * gdbsupport/gdb-dlfcn.h: ... here.
1353
1354 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1355
1356         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1357         the offset field signed.
1358
1359 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1360
1361         * python/lib/gdb/__init__.py (_execute_file): New function.
1362         * python/python.c (python_run_simple_file): Call gdb._execute_file
1363         on Windows.
1364
1365 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1368         all uses as this was never set to anything but a zero value.
1369
1370 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1371
1372         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1373
1374 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1375
1376         * tui/tui-data.h (tui_gen_win_info): Add an =default
1377         move constructor, required by some GCC versions.
1378
1379 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1380
1381         * go32-nat.c (go32_sysinfo): Add hygon_p.
1382
1383 2019-08-20  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1386         line_from_reg_element_no, first_reg_element_no_inline,
1387         display_all_data, delete_data_content_windows,
1388         erase_data_content>: Now private.
1389
1390 2019-08-20  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1393         (tui_unhighlight_win, tui_highlight_win)
1394         (tui_win_info::make_window): Update.
1395         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1396
1397 2019-08-20  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1400         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1401         (MAX_PID_WIDTH): Move to tui-stack.c.
1402         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1403         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1404         (MAX_PID_WIDTH): Move from tui-data.h.
1405
1406 2019-08-20  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1409         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1410         (box_win): Update.
1411         (tui_gen_win_info::make_window): Rename from tui_make_window.
1412         (tui_win_info::make_window): New method.
1413         (tui_gen_win_info::make_visible): Update.
1414         * tui/tui-source.c (tui_source_window::set_contents): Update.
1415         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1416         (tui_data_window::display_registers_from): Update.
1417         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1418         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1419         Declare.
1420         <can_box>: Remove.
1421         <title>: Remove.
1422         (struct tui_win_info) <make_window>: Declare.
1423         <can_box>: Now virtual.
1424         <title>: New member.
1425         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1426         * tui/tui-command.c (tui_cmd_window::resize): Update.
1427
1428 2019-08-20  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1431         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1432         (tui_data_window::check_register_values): Update.
1433
1434 2019-08-20  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-regs.h (struct tui_data_window): Use
1437         DISABLE_COPY_AND_ASSIGN.
1438         <regs_content>: Change type, removing unique_ptr.
1439         <tui_data_window>: Add move constructor.
1440         * tui/tui-regs.c (tui_data_window::show_registers)
1441         (tui_data_window::show_register_group)
1442         (tui_data_window::display_registers_from)
1443         (tui_data_window::display_registers_from)
1444         (tui_data_window::first_data_item_displayed)
1445         (tui_data_window::delete_data_content_windows)
1446         (tui_data_window::rerender, tui_data_window::refresh_window)
1447         (tui_data_window::check_register_values): Update.
1448
1449 2019-08-20  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1452         show_register_group>: Declare.
1453         (tui_show_register_group): Don't declare.
1454         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1455         tui_show_registers.
1456         (tui_data_window::show_register_group): Rename from
1457         tui_show_register_group.
1458         (tui_data_window::check_register_values, tui_reg_command):
1459         Update.
1460         * tui/tui-layout.c (tui_set_layout): Update.
1461
1462 2019-08-20  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1465         Declare.
1466         (tui_check_register_values): Don't declare.
1467         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1468         from tui_check_register_values.
1469         * tui/tui-hooks.c (tui_register_changed): Update.
1470
1471 2019-08-20  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-regs.c (tui_reg_layout): Move later.
1474         (tui_show_registers): Don't enable TUI mode or change layout.
1475
1476 2019-08-20  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-regs.h (struct tui_data_item_window)
1479         <~tui_data_item_window>: Remove.
1480         <content>: Now a unique_xmalloc_ptr.
1481         * tui/tui-regs.c (tui_register_format): Return a
1482         unique_xmalloc_ptr.
1483         (tui_get_register): Update.
1484         (~tui_data_item_window): Remove.
1485         (tui_data_window::display_registers_from, tui_display_register):
1486         Update.
1487         * tui/tui-io.h (tui_expand_tabs): Update.
1488         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1489         Remove "col" parameter.
1490
1491 2019-08-20  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1494         field.
1495         * tui/tui-regs.c (~tui_data_item_window): Update.
1496
1497 2019-08-20  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1500         earlier.
1501
1502 2019-08-20  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1505
1506 2019-08-20  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-source.h (struct tui_source_window): Update.
1509         * tui/tui-regs.c (tui_show_registers): Update.
1510         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1511         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1512         (NO_REGS_STRING): Remove defines.
1513
1514 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1515
1516         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1517         unnecessary thread walk if remote doesn't support the packet.
1518
1519 2019-08-19  Tom Tromey  <tromey@adacore.com>
1520
1521         * python/py-value.c (value_has_field): Fix indentation.
1522
1523 2019-08-19  Tom Tromey  <tromey@adacore.com>
1524
1525         * printcmd.c (do_one_display, info_display_command): Update.
1526         * block.h (contained_in): Return bool.  Add allow_nested
1527         parameter.
1528         * block.c (contained_in): Return bool.  Add allow_nested
1529         parameter.
1530
1531 2019-08-19  Tom Tromey  <tom@tromey.com>
1532
1533         * configure: Rebuild.
1534         * configure.ac: Disallow the combination of -static-libstdc++ and
1535         source highlight.
1536         * source-cache.c (get_language_name): Handle rust.
1537         (source_cache::get_source_lines): Ignore highlighting exceptions.
1538
1539 2019-08-16  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1542         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1543         (struct tui_source_window_base) <make_visible, refresh_window,
1544         resize>: Remove methods.
1545         <execution_info>: Remove field.
1546         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1547         (tui_show_source_line, tui_source_window_base)
1548         (~tui_source_window_base): Update.
1549         (tui_source_window_base::resize)
1550         (tui_source_window_base::make_visible)
1551         (tui_source_window_base::refresh_window): Remove.
1552         (tui_source_window_base::update_exec_info): Update.
1553         * tui/tui-source.c (tui_source_window::set_contents): Update.
1554         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1555
1556 2019-08-16  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1559         deprecated_query_hook.
1560
1561 2019-08-16  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1564         (tui_update_source_windows_with_line): Update.
1565         * tui/tui-source.h (struct tui_source_window)
1566         <show_symtab_source>: Declare.
1567         (tui_show_symtab_source): Don't declare.
1568         * tui/tui-source.c (tui_show_symtab_source): Rename from
1569         tui_show_symtab_source.
1570
1571 2019-08-16  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-winsource.h (struct tui_source_window_base)
1574         <set_contents>: Declare.
1575         * tui/tui-winsource.c
1576         (tui_source_window_base::update_source_window_as_is): Update.
1577         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1578         Declare.
1579         (tui_set_source_content): Don't declare.
1580         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1581         tui_set_source_content.
1582         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1583         Declare.
1584         (tui_set_disassem_content): Don't declare.
1585         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1586         tui_set_disassem_content.
1587
1588 2019-08-16  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-winsource.h (struct tui_source_window_base)
1591         <update_breakpoint_info>: Declare.
1592         (tui_update_breakpoint_info): Don't declare.
1593         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1594         (tui_update_all_breakpoint_info): Update.
1595         (tui_source_window_base::update_breakpoint_info): Rename from
1596         tui_update_breakpoint_info.
1597         (tui_source_window_base::update_exec_info): Update.
1598
1599 2019-08-16  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-winsource.h (struct tui_source_window_base)
1602         <update_source_window>: Declare.
1603         (tui_update_source_window): Don't declare.
1604         * tui/tui-winsource.c
1605         (tui_source_window_base::update_source_window): Rename from
1606         tui_update_source_window.
1607         (tui_source_window_base::rerender): Update.
1608         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1609         * tui/tui-disasm.c (tui_show_disassem)
1610         (tui_show_disassem_and_update_source)
1611         (tui_disasm_window::maybe_update): Update.
1612
1613 2019-08-16  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-winsource.h (struct tui_source_window_base)
1616         <update_source_window_as_is>: Declare.
1617         (tui_update_source_window_as_is): Don't declare.
1618         * tui/tui-winsource.c (tui_update_source_window): Update
1619         (tui_source_window_base::update_source_window_as_is): Rename from
1620         tui_update_source_window_as_is.
1621         (tui_source_window_base::refill): Update.
1622         * tui/tui-source.c (tui_show_symtab_source): Update.
1623         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1624         Update.
1625
1626 2019-08-16  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.h (tui_update_source_window)
1629         (tui_update_source_window_as_is): Remove "noerror" parameter.
1630         * tui/tui-winsource.c (tui_update_source_window)
1631         (tui_update_source_window_as_is): Remove "noerror" parameter.
1632         (tui_update_source_windows_with_addr)
1633         (tui_update_source_windows_with_line)
1634         (tui_source_window_base::rerender)
1635         (tui_source_window_base::refill): Update.
1636         * tui/tui-source.h (tui_set_source_content)
1637         (tui_show_symtab_source): Remove "noerror" parameter.
1638         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1639         parameter.
1640         (tui_show_symtab_source): Likewise.
1641         (tui_source_window::maybe_update): Update.
1642         * tui/tui-disasm.c (tui_show_disassem)
1643         (tui_show_disassem_and_update_source)
1644         (tui_disasm_window::do_scroll_vertical)
1645         (tui_disasm_window::maybe_update): Update.
1646
1647 2019-08-16  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui.c (tui_is_window_visible): Update.
1650         * tui/tui-wingeneral.c (tui_make_window)
1651         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1652         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1653         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1654         (tui_set_win_height_command, parse_scrolling_args): Update.
1655         * tui/tui-source.c (tui_source_window::style_changed): Update.
1656         * tui/tui-regs.c (tui_show_registers)
1657         (tui_data_window::first_data_item_displayed)
1658         (tui_data_window::delete_data_content_windows)
1659         (tui_check_register_values, tui_reg_command): Update.
1660         * tui/tui-disasm.c (tui_show_disassem): Update.
1661         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1662         method.
1663         <is_visible>: Remove field.
1664         * tui/tui-data.c (tui_next_win, tui_prev_win)
1665         (tui_delete_invisible_windows): Update.
1666
1667 2019-08-16  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-winsource.h (struct tui_source_window_base)
1670         <m_has_locator>: Remove.
1671         * tui/tui-layout.c (show_source_disasm_command, show_data)
1672         (show_source_or_disasm_and_command): Update.
1673
1674 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1675
1676         * NEWS (Other MI changes): New subsection.
1677         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1678         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1679         * arch-utils.c (default_get_pc_address_flags): New function.
1680         * arch-utils.h (default_get_pc_address_flags): New declaration.
1681         * gdbarch.sh: Add get_pc_address_flags.
1682         * gdbarch.c: Regenerate.
1683         * gdbarch.h: Likewise.
1684         * stack.c (print_pc): New function.
1685         (print_frame_info) (print_frame): Call print_pc.
1686
1687 2019-08-16  Tom de Vries  <tdevries@suse.de>
1688
1689         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1690         print_objfile_section_info.
1691
1692 2019-08-15  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1695         calling update_cmdwin_start_line.
1696         * tui/tui-winsource.h (struct tui_source_window_base)
1697         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1698         <rerender>: Declare.
1699         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1700         Call rerender.
1701         (tui_source_window_base::set_new_height): Remove.
1702         (tui_source_window_base::rerender): Rename from
1703         do_make_visible_with_new_height.
1704         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1705         resize method.
1706         (tui_win_info::make_invisible_and_set_new_height)
1707         (tui_win_info::make_visible_with_new_height): Remove.
1708         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1709         Declare.
1710         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1711         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1712         do_make_visible_with_new_height>: Don't declare.
1713         <rerender>: Declare.
1714         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1715         set_new_height.
1716         (tui_data_window::do_make_visible_with_new_height): Remove.
1717         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1718         call tui_show_locator_content.
1719         (tui_gen_win_info::resize): Call rerender.
1720         (show_source_or_disasm_and_command): Don't call
1721         tui_show_locator_content.
1722         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1723         method.
1724         (struct tui_win_info) <rerender>: Declare.
1725         <set_new_height, make_invisible_and_set_new_height,
1726         make_visible_with_new_height>: Don't declare.
1727         * tui/tui-data.c (tui_win_list::rerender): New method.
1728         * tui/tui-command.h (struct tui_cmd_window)
1729         <do_make_visible_with_new_height>: Don't declare.
1730         * tui/tui-command.c
1731         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1732
1733 2019-08-15  Tom Tromey  <tromey@adacore.com>
1734
1735         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1736         * ada-lang.c (ada_enum_name): Likewise.
1737
1738 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1739
1740         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1741         leading underscore.
1742         (GdbOutputErrorFile): Likewise.
1743         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1744         accordingly.
1745         (execute_unwinders): Rename to have a leading underscore.
1746         (auto_load_packages): Likewise.
1747         (global scope): Adjust call to auto_load_packages accordingly.
1748         (GdbSetPythonDirectory): Likewise.
1749         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1750         instead of execute_unwinders.
1751
1752 2019-08-15  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1755         (show_data): Don't change window visibility.
1756         (tui_gen_win_info::resize): Remove special case for command
1757         window.  Use wresize, when available.
1758         (show_source_or_disasm_and_command): Don't change window
1759         visibility.
1760         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1761         <make_visible>: New method.
1762         * tui/tui-command.c (tui_cmd_window::resize): New method.
1763
1764 2019-08-15  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1767         (struct tui_source_windows): New.
1768         * tui/tui-winsource.c (tui_display_main): Update.
1769         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1770         (new_height_ok, parse_scrolling_args): Update.
1771         * tui/tui-layout.c (show_layout, show_data): Update.
1772         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1773         (tui_add_to_source_windows): Don't declare.
1774         * tui/tui-data.c (source_windows, tui_source_windows)
1775         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1776
1777 2019-08-15  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1780         Rename from reset.
1781         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1782         * tui/tui-layout.c (show_source_disasm_command, show_data):
1783         Update.
1784         (tui_gen_win_info::resize): Rename.
1785         (show_source_or_disasm_and_command): Update.
1786         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1787         reset.
1788
1789 2019-08-15  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1792         * tui/tui-interp.c (tui_interp::init): Don't call
1793         tui_initialize_static_data.
1794         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1795
1796 2019-08-15  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1799         examine tui_win_list.
1800
1801 2019-08-15  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1804         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1805         tui_clear_source_content.
1806         (tui_clear_source_content): Remove.
1807         (tui_source_window_base::do_erase_source_content): Hoist call to
1808         content.clear().
1809         * tui/tui-stack.c (tui_show_frame_info): Don't call
1810         tui_clear_source_content.
1811
1812 2019-08-15  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-winsource.h (struct tui_source_window_base)
1815         <do_erase_source_content>: New method.
1816         <erase_source_content>: New method.
1817         (tui_erase_source_content): Don't declare.
1818         * tui/tui-winsource.c (tui_clear_source_content): Update.
1819         (tui_source_window_base::do_erase_source_content): Rename from
1820         tui_erase_source_content.
1821         (tui_source_window_base::show_source_content): Update.
1822         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1823         * tui/tui-source.h (struct tui_source_window)
1824         <erase_source_content>: New method.
1825         * tui/tui-disasm.h (struct tui_disasm_window)
1826         <erase_source_content>: New method.
1827
1828 2019-08-15  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1831         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1832         constructor.
1833         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1834         * tui/tui-source.c (tui_set_source_content): Update.
1835         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1836
1837 2019-08-15  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1840         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1841         tui-source.c.
1842         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1843         Declare.
1844         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1845         method.
1846         (tui_source_window::maybe_update): Update.
1847
1848 2019-08-15  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1851         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1852         tui-disasm.c.
1853         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1854         Declare.
1855         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1856         method.
1857         (tui_disasm_window::maybe_update): Update.
1858
1859 2019-08-15  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-winsource.h (struct tui_source_window_base)
1862         <maybe_update>: Declare.
1863         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1864         method.
1865         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1866         Declare.
1867         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1868         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1869         Declare.
1870         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1871
1872 2019-08-15  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1875
1876 2019-08-15  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-wingeneral.c: Include tui-stack.h.
1879         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1880         (struct tui_locator_window): Move from tui-data.h.
1881         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1882         (tui_initialize_static_data): Move from tui-data.c.
1883         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1884         (struct tui_locator_window): Move to tui-stack.c.
1885         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1886         (tui_initialize_static_data): Move to tui-stack.c.
1887
1888 2019-08-15  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-layout.c (show_source_disasm_command)
1891         (show_source_or_disasm_and_command): Use make_visible method, not
1892         tui_make_window.
1893         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1894         Remove.
1895
1896 2019-08-15  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-wingeneral.h (tui_make_window): Update.
1899         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1900         parameter.
1901         (tui_gen_win_info::make_visible): Update.
1902         * tui/tui-regs.c (tui_data_window::display_registers_from):
1903         Update.
1904         * tui/tui-layout.c (show_source_disasm_command)
1905         (show_source_or_disasm_and_command): Update.
1906         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1907         (enum tui_box): Remove.
1908         (struct tui_win_info) <can_box>: New method.
1909         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1910         method.
1911
1912 2019-08-15  Tom de Vries  <tdevries@suse.de>
1913
1914         * linux-nat-trad.c: Include gdbarch.h.
1915
1916 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1917
1918         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1919         register sizes.
1920
1921 2019-08-14  Tom Tromey  <tromey@adacore.com>
1922
1923         * darwin-nat.c: Include gdbarch.h.
1924         * darwin-nat-info.c: Include gdbarch.h.
1925
1926 2019-08-13  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1929         Remove.
1930         * tui/tui-data.c (tui_initialize_static_data): Update.
1931
1932 2019-08-13  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.h (struct tui_exec_info_window)
1935         <~tui_exec_info_window, maybe_allocate_content, get_content,
1936         m_content>: Remove.
1937         (struct tui_source_window_base) <set_exec_info_content,
1938         show_exec_info_content>: Don't declare.
1939         * tui/tui-winsource.c
1940         (tui_exec_info_window::maybe_allocate_content): Remove.
1941         (tui_source_window_base::update_exec_info): Rename from
1942         set_exec_info_content.
1943         (tui_source_window_base::show_exec_info_content)
1944         (tui_source_window_base::update_exec_info): Remove.
1945
1946 2019-08-13  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1949         declare.
1950         * tui/tui-winsource.c (tui_update_source_window_as_is)
1951         (tui_update_source_windows_with_addr, tui_erase_source_content):
1952         Update.
1953         (tui_clear_exec_info_content): Remove.
1954
1955 2019-08-13  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1958         declare.
1959         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1960         call tui_erase_exec_info_content.
1961         (tui_clear_exec_info_content): Rename from
1962         tui_erase_exec_info_content.
1963         (tui_clear_exec_info_content): Delete.
1964
1965 2019-08-13  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-winsource.h (struct tui_source_window_base)
1968         <show_exec_info_content>: Declare.
1969         (tui_show_exec_info_content): Don't declare.
1970         * tui/tui-winsource.c
1971         (tui_source_window_base::show_exec_info_content): Rename from
1972         tui_show_exec_info_content.
1973         (tui_source_window_base::update_exec_info): Update.
1974
1975 2019-08-13  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1978         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1979         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1980         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1981         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1982         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1983         ... here.
1984
1985 2019-08-13  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.h (struct tui_source_window_base)
1988         <update_exec_info>: Declare.
1989         (tui_update_exec_info): Don't declare.
1990         * tui/tui-winsource.c (tui_update_source_window_as_is)
1991         (tui_source_window_base::refresh_all)
1992         (tui_update_all_breakpoint_info): Update.
1993         (tui_source_window_base::update_exec_info): Rename from
1994         tui_update_exec_info.
1995         * tui/tui-stack.c (tui_show_frame_info): Update.
1996
1997 2019-08-13  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-winsource.h (struct tui_source_window_base)
2000         <set_exec_info_content>: Declare.
2001         (tui_set_exec_info_content): Don't declare.
2002         * tui/tui-winsource.c
2003         (tui_source_window_base::set_exec_info_content): Rename from
2004         tui_set_exec_info_content.
2005         (tui_update_exec_info): Update.
2006
2007 2019-08-13  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-winsource.h (struct tui_source_window_base)
2010         <show_source_content>: Declare.
2011         (tui_show_source_content): Don't declare.
2012         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2013         (tui_source_window_base::show_source_content): Rename from
2014         tui_show_source_content.
2015         (tui_source_window_base::refresh_all): Update.
2016         * tui/tui-layout.c (show_source_disasm_command)
2017         (show_source_or_disasm_and_command): Update.
2018
2019 2019-08-13  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-winsource.c (tui_erase_source_content)
2022         (tui_show_source_content, tui_source_window_base::refresh_all):
2023         Update.
2024         * tui/tui-wingeneral.h
2025         (tui_check_and_display_highlight_if_needed): Don't declare.
2026         * tui/tui-wingeneral.c
2027         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2028         check_and_display_highlight_if_needed.
2029         * tui/tui-win.c (tui_rehighlight_all)
2030         (tui_win_info::make_visible_with_new_height): Update.
2031         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2032         (tui_data_window::erase_data_content)
2033         (tui_data_window::display_all_data): Update.
2034         * tui/tui-data.h (struct tui_win_info)
2035         <check_and_display_highlight_if_needed>: Declare.
2036
2037 2019-08-13  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-win.c (tui_resize_all): Call
2040         tui_delete_invisible_windows.
2041         * tui/tui-layout.c (show_layout): Call
2042         tui_delete_invisible_windows.
2043         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2044         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2045
2046 2019-08-13  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2049         tui_add_win_to_layout.
2050
2051 2019-08-13  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2054         * tui/tui-layout.c (tui_default_win_height): Now static.
2055
2056 2019-08-13  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2059         single switch.
2060         (show_source_disasm_command, show_source_or_disasm_and_command):
2061         Don't check current layout.
2062
2063 2019-08-13  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-wingeneral.c (make_all_visible): Remove.
2066         (tui_make_all_invisible): Simplify.
2067         * tui/tui-layout.c (tui_make_all_invisible): Move from
2068         tui-wingeneral.c; simplify.
2069         (show_layout): Hoist call to tui_make_all_invisible.
2070         (show_data): Don't call tui_make_all_invisible.
2071
2072 2019-08-13  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2075         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2076
2077 2019-08-13  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2080         tui-data.c.
2081         (show_source_disasm_command, show_data)
2082         (show_source_or_disasm_and_command): Don't use
2083         tui_set_current_layout_to.
2084         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2085         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2086         tui-layout.c.
2087         (tui_set_current_layout_to): Remove.
2088
2089 2019-08-13  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-layout.c (tui_set_layout): Update.
2092         * tui/tui-data.h (struct tui_layout_def): Remove.
2093         (tui_layout_def): Don't declare.
2094         * tui/tui-data.c (layout_def): Remove.
2095         (tui_layout_def): Remove.
2096
2097 2019-08-13  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-winsource.h (struct tui_source_window_base)
2100         <clear_detail>: No longer "override".
2101         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2102         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2103         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2104         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2105         Remove.
2106         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2107
2108 2019-08-13  Tom Tromey  <tromey@adacore.com>
2109
2110         * tracepoint.c: Don't include readline.h or history.h.
2111
2112 2019-08-12  Tom Tromey  <tom@tromey.com>
2113
2114         * configure: Rebuild.
2115         * configure.ac: Check for readline 7.
2116         * NEWS: Mention readline 7 requirement.
2117         * README: Update.
2118
2119 2019-08-12  Tom Tromey  <tom@tromey.com>
2120
2121         * mingw-hdep.c (gdb_select): Remove readline hack.
2122
2123 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2124
2125         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2126         when the function fails.
2127
2128 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2129
2130         * s390-tdep.c (s390_type_align): New function.
2131         (s390_gdbarch_init): Set it as type_align gdbarch method.
2132
2133 2019-08-09  Tom de Vries  <tdevries@suse.de>
2134
2135         PR gdb/24591
2136         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2137         pc_low with relocation offset.
2138
2139 2019-08-07  Tom Tromey  <tromey@adacore.com>
2140
2141         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2142         (print_frame_args): Update.
2143         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2144         Update.
2145         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2146         * frame.h (struct frame_arg): Add initializers.
2147         <error>: Now a unique_xmalloc_ptr.
2148
2149 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2150
2151         * NEWS: Expand the Pointer Authentication entry.
2152         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2153         (aarch64_frame_unmask_lr): ... to this.
2154         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2155         Call aarch64_frame_unmask_lr.
2156         * frame.c (struct frame_info): Add "masked" variable.
2157         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2158         (fprint_frame): Check for masked pc.
2159         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2160         declarations.
2161         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2162         * stack.c (print_frame): Check for masked pc.
2163
2164 2019-08-06  Tom Tromey  <tom@tromey.com>
2165
2166         * stabsread.c (patch_block_stabs, read_one_struct_field)
2167         (read_enum_type): Use obstack_strndup.
2168         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2169         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2170         * dwarf2read.c (guess_full_die_structure_name)
2171         (anonymous_struct_prefix): Use obstack_strndup.
2172         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2173         * c-exp.y (yylex): Use obstack_strndup.
2174         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2175         (write_var_or_type): Use obstack_strndup.
2176
2177 2019-08-06  Tom Tromey  <tom@tromey.com>
2178
2179         * symfile.c (reread_symbols): Use obstack_strdup.
2180         * stabsread.c (read_type): Use obstack_strdup.
2181         * gdb_obstack.h (obstack_strdup): New overload.
2182         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2183         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2184         (dwarf2_canonicalize_name): Use obstack_strdup.
2185         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2186         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2187         Use obstack_strdup.
2188
2189 2019-08-06  Tom Tromey  <tom@tromey.com>
2190
2191         * gdb_obstack.h (obstack_strdup): Define.
2192         * gdb_obstack.c (obstack_strdup): Don't define.
2193
2194 2019-08-06  Tom Tromey  <tom@tromey.com>
2195
2196         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2197         obstack_strdup.
2198         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2199         obstack_strdup.
2200         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2201         * stabsread.c (common_block_start): Use obstack_strdup.
2202         * objfiles.c (set_objfile_main_name, objfile): Use
2203         obstack_strdup.
2204         * namespace.c (add_using_directive): Use obstack_strdup.
2205         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2206         * jit.c (finalize_symtab): Use obstack_strdup.
2207         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2208         (guess_partial_die_structure_name, partial_die_info::fixup)
2209         (dwarf2_name): Use obstack_strdup.
2210         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2211         obstack_strdup.
2212         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2213         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2214         obstack_strdup.
2215         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2216
2217 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2218
2219         * unittests/help-doc-selftests.c: New file.
2220         * Makefile.in: Add the new file.
2221
2222 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2223
2224         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2225         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2226         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2227         the trailing '.' is not output, and the first character is uppercased.
2228         (print_help_for_command): Update call to print_doc_line.
2229         (print_doc_of_command): Likewise.
2230         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2231         * cli/cli-option.c (append_indented_doc): Do not append newline.
2232         (build_help_option): Append newline after first appended_indented_doc
2233         only if a second call is done.
2234         (build_help): Append 2 new lines before each option, except the first
2235         one.
2236         * compile/compile.c (_initialize_compile): Add new lines after
2237         %OPTIONS%, when not at the end of the help.
2238         Change help doc or code
2239         producing the help doc to respect the invariants.
2240         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2241         Also removed the new line after 'Options:', as all other commands
2242         do not put an empty line between 'Options:' and the first option.
2243         * printcmd.c (_initialize_printcmd): Likewise.
2244         * stack.c (_initialize_stack): Likewise.
2245         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2246         incorrectly telling COMMAND is optional.
2247         * ada-lang.c (_initialize_ada_language): Change help doc or code
2248         producing the help doc to respect the invariants.
2249         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2250         * breakpoint.c (_initialize_breakpoint): Likewise.
2251         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2252         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2253         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2254         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2255         _initialize_cli_style): Likewise.
2256         * corelow.c (core_target_info): Likewise.
2257         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2258         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2259         * filesystem.c (_initialize_filesystem): Likewise.
2260         * frame.c (_initialize_frame): Likewise.
2261         * gnu-nat.c (add_task_commands): Likewise.
2262         * infcall.c (_initialize_infcall): Likewise.
2263         * infcmd.c (_initialize_infcmd): Likewise.
2264         * interps.c (_initialize_interpreter): Likewise.
2265         * language.c (_initialize_language): Likewise.
2266         * linux-fork.c (_initialize_linux_fork): Likewise.
2267         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2268         * maint.c (_initialize_maint_cmds): Likewise.
2269         * memattr.c (_initialize_mem): Likewise.
2270         * printcmd.c (_initialize_printcmd): Likewise.
2271         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2272         _RegEx): Likewise.
2273         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2274         * record-btrace.c (_initialize_record_btrace): Likewise.
2275         * record-full.c (_initialize_record_full): Likewise.
2276         * record.c (_initialize_record): Likewise.
2277         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2278         * regcache.c (_initialize_regcache): Likewise.
2279         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2280         _initialize_remote): Likewise.
2281         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2282         * serial.c (_initialize_serial): Likewise.
2283         * skip.c (_initialize_step_skip): Likewise.
2284         * source.c (_initialize_source): Likewise.
2285         * stack.c (_initialize_stack): Likewise.
2286         * symfile.c (_initialize_symfile): Likewise.
2287         * symtab.c (_initialize_symtab): Likewise.
2288         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2289         * top.c (init_main): Likewise.
2290         * tracefile-tfile.c (tfile_target_info): Likewise.
2291         * tracepoint.c (_initialize_tracepoint): Likewise.
2292         * tui/tui-win.c (_initialize_tui_win): Likewise.
2293         * utils.c (add_internal_problem_command): Likewise.
2294         * valprint.c (value_print_option_defs): Likewise.
2295
2296 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2297
2298         PR build/24886
2299         * configure.ac: Drop enable-libmcheck support.
2300         * configure, config.in: Rebuild.
2301         * libmcheck.m4: Remove.
2302         * acinclude.m4: Don't include it.
2303         * Makefile.in: Don't distribute it.
2304         * top.c (print_gdb_configuration): Don't mention it.
2305
2306 2019-08-06  Tom Tromey  <tom@tromey.com>
2307
2308         * utils.c (set_output_style): Sometimes pass stream to
2309         emit_style_escape.
2310         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2311         * record-btrace.c (btrace_insn_history): Update.
2312         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2313         method.
2314         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2315         Update initializers.
2316         <m_uiout>: New field.
2317         <m_di>: Move lower.
2318         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2319         Remove "uiout" parameter.
2320         (dump_insns): Update.
2321         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2322         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2323
2324 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2325
2326         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2327         (error_in_psymtab_expansion): Likewise.
2328         (lookup_symbol_via_quick_fns): Likewise.
2329         (basic_lookup_transparent_type_quick): Likewise.
2330         (basic_lookup_transparent_type_1): Likewise.
2331
2332 2019-08-06  Tom Tromey  <tromey@adacore.com>
2333
2334         * source.c (last_source_error): Now bool.
2335         (print_source_lines_base): Make "noprint" bool.  Only open
2336         source file when last_source_visited changes.
2337
2338 2019-08-06  Tom Tromey  <tromey@adacore.com>
2339
2340         * annotate.c (annotate_source_line): Use g_source_cache.
2341         * source-cache.c (source_cache::get_plain_source_lines): Change
2342         parameters.  Populate m_offset_cache.
2343         (source_cache::ensure): New method.
2344         (source_cache::get_line_charpos): New method.
2345         (extract_lines): Move lower.  Change parameters.
2346         (source_cache::get_source_lines): Move lower.
2347         * source-cache.h (class source_cache): Update comment.
2348         <get_line_charpos>: New method.
2349         <get_source_lines>: Update comment.
2350         <clear>: Clear m_offset_cache.
2351         <get_plain_source_lines>: Change parameters.
2352         <ensure>: New method
2353         <m_offset_cache>: New member.
2354         * source.c (forget_cached_source_info_for_objfile): Update.
2355         (info_source_command): Use g_source_cache.
2356         (find_source_lines, open_source_file_with_line_charpos): Remove.
2357         (print_source_lines_base, search_command_helper): Use g_source_cache.
2358         * source.h (open_source_file_with_line_charpos): Don't declare.
2359         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2360         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2361         Use g_source_cache.
2362
2363 2019-08-06  Tom Tromey  <tromey@adacore.com>
2364
2365         * source-cache.c (source_cache::get_plain_source_lines):
2366         Remove "first_line" and "last_line" parameters.
2367         (source_cache::get_source_lines): Cache plain text.
2368         * source-cache.h (class source_cache)
2369         <get_plain_source_lines>: Update.
2370
2371 2019-08-06  Tom Tromey  <tromey@adacore.com>
2372
2373         * source-cache.c (extract_lines): No longer a method.
2374         Changed type of parameter.  Include final newline.
2375         (selftests::extract_lines_test): New function.
2376         (_initialize_source_cache): Likewise.
2377         * source-cache.h (class source_cache)
2378         <extract_lines>: Don't declare.
2379
2380 2019-08-06  Tom Tromey  <tromey@adacore.com>
2381
2382         * breakpoint.c (init_breakpoint_sal): Update.
2383         (breakpoint): Update.
2384         * breakpoint.h (struct breakpoint) <filter>: Now a
2385         unique_xmalloc_ptr.
2386
2387 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2388
2389         * NEWS: Mention dictionary access on blocks.
2390         * python/py-block.c (blpy_getitem): New function.
2391         (block_object_as_mapping): New struct.
2392         (block_object_type): Use new struct for tp_as_mapping field.
2393
2394 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2395
2396         * objfiles.h (objfile): Add a comment describing partial symbols.
2397
2398 2019-08-05  Tom Tromey  <tromey@adacore.com>
2399
2400         * compile/compile.c (_initialize_compile): Use _(), not N_().
2401         * thread.c (_initialize_thread): Use _(), not N_().
2402         * stack.c (_initialize_stack): Use _(), not N_().
2403         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2404
2405 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2406
2407         * dwarf2read.c (struct dw2_symtab_iterator):
2408         <want_specific_block>: Remove.
2409         <block_index>: Change type to gdb::optional.
2410         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2411         change type of BLOCK_INDEX parameter to gdb::optional.
2412         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2413         (dw2_lookup_symbol): Don't pass argument for
2414         WANT_SPECIFIC_BLOCK.
2415         (dw2_expand_symtabs_for_function): Don't pass argument for
2416         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2417         (class dw2_debug_names_iterator)
2418         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2419         parameter, change BLOCK_INDEX type to gdb::optional.
2420         <m_want_specific_block>: Remove.
2421         <m_block_index>: Change type to gdb::optional.
2422         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2423         gdb::optional.  Re-write in function of gdb::optional.
2424         (dw2_debug_names_lookup_symbol): Don't pass argument for
2425         WANT_SPECIFIC_BLOCK.
2426         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2427         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2428         BLOCK_INDEX.
2429
2430 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2431
2432         * NEWS: Mention changes to "info sources" command.
2433
2434 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2435
2436         * symtab.c (filename_partial_match_opts): New struct type.
2437         (struct output_source_filename_data): New members
2438         regexp, c_regexp, partial_match.
2439         (output_source_filename): Use new members to decide to print file.
2440         (info_sources_option_defs): New variable.
2441         (make_info_sources_options_def_group, print_info_sources_header,
2442         info_sources_command_completer):
2443         New functions.
2444         (info_sources_command): Read new optional arguments.
2445         (_initialize_symtab): Update info sources help.
2446
2447 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2448
2449         * ada-lang.c (exception_support_info_v0): Renamed from...
2450         (default_exception_support_info): ... this.  Create new
2451         definition for v1.
2452         (ada_has_this_exception_support): Look up catch_handlers_sym.
2453         (ada_exception_support_info_sniffer): Try v0 after default.
2454
2455 2019-08-01  Tom Tromey  <tromey@adacore.com>
2456
2457         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2458         gdbarch.h.
2459
2460 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2461
2462         * s12z-tdep.c: Fix include path for s12z-opc.h.
2463
2464 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2465
2466         * NEWS: Require GNU make 3.82.
2467
2468 2019-07-16  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2471         declare.
2472
2473 2019-07-30  Tom Tromey  <tromey@adacore.com>
2474
2475         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2476
2477 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2478
2479         * printcmd.c (print_address_symbolic): Print negative offsets.
2480         (build_address_symbolic): Force signed arithmetic when computing
2481         offset.
2482
2483 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2484
2485         PR/24474: Add a function to lookup static variables.
2486         * NEWS: Mention this new function.
2487         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2488         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2489         * python/python.c (python_GdbMethods): Add new function.
2490
2491 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2492
2493         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2494         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2495         (objfpy_lookup_static_symbol): New function.
2496         (objfile_object_methods): Add new functions.
2497
2498 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2499
2500         * NEWS: Mention 'set|show print frame-info'.  Mention new
2501         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2502         backtrace argument.  Mention that python frame filtering code
2503         is now consistent with what 'backtrace' command prints.
2504
2505 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2506
2507         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2508         comments.
2509         (print_frame_info_auto, print_frame_info_source_line,
2510         print_frame_info_location, print_frame_info_source_and_location,
2511         print_frame_info_location_and_address, print_frame_info_short_location):
2512         New declarations.
2513         (struct frame_print_options): New member print_frame_info.
2514         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2515         * stack.h (get_user_print_what_frame_info): New declaration.
2516         (frame_show_address): New declaration.
2517         * stack.c (print_frame_arguments_choices): New value 'presence'.
2518         (print_frame_info_auto, print_frame_info_source_line,
2519         print_frame_info_location, print_frame_info_source_and_location,
2520         print_frame_info_location_and_address, print_frame_info_short_location,
2521         print_frame_info_choices, print_frame_info_print_what): New definitions.
2522         (print_frame_args): Only print dots for args if print frame-arguments
2523         is 'presence'.
2524         (frame_print_option_defs): New element for "frame-info".
2525         (get_user_print_what_frame_info): New function.
2526         (frame_show_address): Make non static.  Move comment to stack.h.
2527         (print_frame_info_to_print_what): New function.
2528         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2529         to decide what to print.
2530         (backtrace_command_1): Handle the new print_frame_arguments_presence
2531         value.
2532         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2533         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2534         (py_print_frame): In non-mi mode, use LOCATION as default for
2535         print_what, similarly to frame information printed directly by
2536         backtrace command. Handle frame-info user option in non MI mode.
2537
2538 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2539
2540         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2541         Add case for debugging 32-bit target on 64-bit host.  Revise
2542         comment.
2543
2544 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2545
2546         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2547         instead of find_function_entry_range_from_pc.
2548
2549 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2550
2551         * stack.c (find_frame_funname): Remove code which preferred
2552         minsym over symtab sym in "certain pathological cases".
2553
2554         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2555         parameter.  Change type of "do_demangle" to bool.
2556         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2557         Pass suitable "prefer_sym_over_minsym" flag to
2558         build_address_symbolic().  Don't output "+" for negative offsets.
2559         * printcmd.c (print_address_symbolic): Update invocation of
2560         build_address_symbolic to include a "prefer_sym_over_minsym"
2561         flag.
2562         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2563         Restrict cases in which use of minimal symbol is preferred to that
2564         of a found symbol.  Update comments.
2565
2566         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2567         for entry pc when entry pc is out of range for that FDE.
2568
2569 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2570
2571         PR gdb/24839:
2572         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2573         type.
2574
2575 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2576
2577         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2578         this function's Python signature.
2579
2580
2581 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2582
2583         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2584         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2585         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2586         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2587         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2588
2589
2590 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2591
2592         * h8300-tdep.c (h8300_register_name_common): New.
2593         h8300_register_name): Use h8300_register_name_common.
2594         (h8300s_register_name): Likewise.
2595         (h8300sx_register_name): Likewise.
2596         (h8300h_register_nam): New.
2597         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2598
2599
2600 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2601
2602         * arm-tdep.c (arm_skip_cmse_entry): New function.
2603         (arm_is_sgstubs_section): New function.
2604         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2605
2606 2019-07-22  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2609         Don't self-assign.
2610
2611 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2612
2613         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2614         type_print.
2615
2616 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2619         so that GDB doesn't match any msymbols when searching in the
2620         TYPES_DOMAIN.
2621         (print_symbol_info): Print using typedef_print or type_print based
2622         on the type of the symbol.  Add updated FIXME comment moved from...
2623         (_initialize_symtab): ... move and update FIXME comment to above.
2624
2625 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * NEWS: Mention adding -q option to "info types".
2628         * symtab.c (struct info_types_options): New struct.
2629         (info_types_options_defs): New variable.
2630         (make_info_types_options_def_group): New function.
2631         (info_types_command): Use gdb::option framework to parse options.
2632         (info_types_command_completer): New function.
2633         (_initialize_symtab): Extend the help text on "info types" and
2634         register command completer.
2635
2636 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2637
2638         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2639         (lookup_symbol_in_objfile): Change int to block_enum and add a
2640         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2641
2642 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2643
2644         * MAINTAINERS (Write After Approval): Add self.
2645
2646 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2649         instruction to the dummy code region.
2650
2651 2019-07-19  Tom Tromey  <tromey@adacore.com>
2652
2653         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2654         (ARGSUSED, PARAMS, __func__): Remove rules.
2655
2656 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2659         * features/arm/arm-with-iwmmxt.c: Remove.
2660         * features/arm/arm-with-iwmmxt.xml: Remove.
2661         * features/arm/arm-with-m-fpa-layout.c: Remove.
2662         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2663         * features/arm/arm-with-m-vfp-d16.c: Remove.
2664         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2665         * features/arm/arm-with-m.c: Remove.
2666         * features/arm/arm-with-m.xml: Remove.
2667         * features/arm/arm-with-neon.c: Remove.
2668         * features/arm/arm-with-neon.xml: Remove.
2669         * features/arm/arm-with-vfpv2.c: Remove.
2670         * features/arm/arm-with-vfpv2.xml: Remove.
2671         * features/arm/arm-with-vfpv3.c: Remove.
2672         * features/arm/arm-with-vfpv3.xml: Remove.
2673
2674 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2675
2676         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2677
2678 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2679
2680         * arch/aarch32.c (aarch32_create_target_description): Create
2681         target descriptions using features.
2682         * arch/arm.c (arm_create_target_description)
2683         (arm_create_mprofile_target_description): Likewise.
2684         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2685
2686 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2687
2688         * Makefile.in: Add new files.
2689         * aarch32-tdep.c: New file.
2690         * aarch32-tdep.h: New file.
2691         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2692         Call aarch32_read_description.
2693         * arch/aarch32.c: New file.
2694         * arch/aarch32.h: New file.
2695         * arch/arm.c (arm_create_target_description)
2696         (arm_create_mprofile_target_description): New function.
2697         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2698         (arm_create_target_description)
2699         (arm_create_mprofile_target_description): New declaration.
2700         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2701         read_description functions.
2702         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2703         Likewise.
2704         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2705         * arm-tdep.c (tdesc_arm_list): New variable.
2706         (arm_register_g_packet_guesses): Call create description functions.
2707         (arm_read_description) (arm_read_mprofile_description): New
2708         function.
2709         * arm-tdep.h (arm_read_description)
2710         (arm_read_mprofile_description): Add declaration.
2711         * configure.tgt: Add new files.
2712
2713 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2714
2715         * top.c (new_ui_command): Open specified terminal just once.
2716
2717 2019-07-18  Tom Tromey  <tromey@adacore.com>
2718
2719         * symtab.c (main_name): Constify return type.
2720         * symfile.c (set_initial_language): Update.
2721         * symtab.h (main_name): Constify return type.
2722
2723 2019-07-17  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-winsource.c (tui_update_source_window)
2726         (tui_update_source_window_as_is)
2727         (tui_update_source_windows_with_line): Remove return.
2728         * tui/tui-disasm.c (tui_show_disassem)
2729         (tui_show_disassem_and_update_source): Remove return.
2730         * tui/tui.c (tui_reset): Remove return.
2731         * tui/tui-wingeneral.c
2732         (tui_check_and_display_highlight_if_needed): Remove return.
2733
2734 2019-07-17  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2737
2738 2019-07-17  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-winsource.h (struct tui_exec_info_window)
2741         (struct tui_source_window_base): Move from tui-data.h.
2742         * tui/tui-winsource.c: Move many method definitions from
2743         elsewhere.  Remove "structuring" comments.
2744         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2745         (tui_source_window_base::refresh_window): Move to
2746         tui-winsource.c.
2747         * tui/tui-win.c (tui_source_window_base::refresh_all)
2748         (tui_source_window_base::update_tab_width)
2749         (tui_source_window_base::set_new_height)
2750         (tui_source_window_base::do_make_visible_with_new_height): Move to
2751         tui-winsource.c.
2752         * tui/tui-source.h: Update.
2753         * tui/tui-source.c (tui_source_window_base::reset): Move to
2754         tui-winsource.c.
2755         * tui/tui-disasm.h: Update.
2756         * tui/tui-data.h (struct tui_exec_info_window): Move to
2757         tui-winsource.h.
2758         (struct tui_source_window_base): Likewise.
2759         * tui/tui-data.c (tui_source_window_base::clear_detail)
2760         (tui_source_window_base, ~tui_source_window_base): Move to
2761         tui-winsource.c.
2762
2763 2019-07-17  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-win.c (tui_resize_all)
2766         (tui_source_window_base::update_tab_width)
2767         (tui_adjust_win_heights): Update.
2768         (tui_win_info::make_invisible_and_set_new_height): Rename from
2769         make_invisible_and_set_new_height.
2770         * tui/tui-data.h (struct tui_win_info)
2771         <make_invisible_and_set_new_height>: New method.
2772
2773 2019-07-17  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui.c: Update.
2776         * tui/tui-source.h (struct tui_source_window): Move from
2777         tui-data.h.
2778         * tui/tui-layout.c: Update.
2779         * tui/tui-disasm.c: Update.
2780         * tui/tui-data.h (struct tui_source_window): Move to
2781         tui-source.h.
2782
2783 2019-07-17  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2786         tui-data.h.
2787         * tui/tui-data.h (struct tui_disasm_window): Move to
2788         tui-disasm.h.
2789
2790 2019-07-17  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-regs.h (struct tui_data_item_window): Move from
2793         tui-data.h.
2794         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2795         * tui/tui-data.h (struct tui_data_item_window): Move to
2796         tui-regs.h.
2797         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2798
2799 2019-07-17  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui.c: Update.
2802         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2803         (tui_cmd_window::max_height): Move to tui-command.c.
2804         * tui/tui-layout.c: Update.
2805         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2806         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2807         tui-command.c.
2808         * tui/tui-command.h (struct tui_cmd_window): Move from
2809         tui-data.h.
2810         * tui/tui-command.c: Remove "structuring" comments.
2811         (tui_cmd_window::clear_detail)
2812         (tui_cmd_window::do_make_visible_with_new_height)
2813         (tui_cmd_window::max_height): Move from elsewhere.
2814
2815 2019-07-17  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2818         Now static.
2819         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2820         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2821
2822 2019-07-17  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui.c: Update.
2825         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2826         tui-regs.c.
2827         * tui/tui-windata.h: Remove file.
2828         * tui/tui-windata.c: Remove file.
2829         * tui/tui-win.c (tui_data_window::set_new_height)
2830         (tui_data_window::do_make_visible_with_new_height): Move to
2831         tui-regs.c.
2832         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2833         * tui/tui-regs.c: Remove "structuring" comments.
2834         (tui_data_window::first_data_item_displayed)
2835         (tui_data_window::delete_data_content_windows)
2836         (tui_data_window::erase_data_content)
2837         (tui_data_window::display_all_data)
2838         (tui_data_window::refresh_all)
2839         (tui_data_window::do_scroll_vertical)
2840         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2841         (tui_data_window::do_make_visible_with_new_height)
2842         (tui_data_window::refresh_window): Move from elsewhere.
2843         (_initialize_tui_regs): Move to end of file.
2844         * tui/tui-layout.c: Update.
2845         * tui/tui-hooks.c: Update.
2846         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2847         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2848         tui-regs.c.
2849         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2850
2851 2019-07-17  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2854         seen.
2855
2856 2019-07-17  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui-win.c (tui_source_window_base::set_new_height)
2859         (tui_source_window_base::do_make_visible_with_new_height): Use
2860         m_has_locator field directly.
2861         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2862         method.
2863         (struct tui_source_window_base) <has_locator>: Likewise.
2864
2865 2019-07-17  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2868         Don't declare.
2869         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2870         Remove.
2871         * tui/tui-win.c (tui_source_window_base::set_new_height)
2872         (tui_source_window_base::set_new_height)
2873         (make_invisible_and_set_new_height)
2874         (tui_source_window_base::do_make_visible_with_new_height)
2875         (tui_source_window_base::do_make_visible_with_new_height):
2876         Update.
2877         * tui/tui-layout.c (show_source_disasm_command, show_data)
2878         (show_source_or_disasm_and_command): Update.
2879         * tui/tui-layout.c (show_layout): Update.
2880
2881 2019-07-17  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-layout.c (make_data_window): Remove.
2884         (show_data): Unify creation and re-initialization cases.
2885
2886 2019-07-17  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-layout.c (make_source_window, make_disasm_window):
2889         Remove.
2890         (show_data): Unify creation and re-initialization cases.
2891
2892 2019-07-17  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-layout.c (make_command_window): Remove.
2895         (show_source_disasm_command, show_source_or_disasm_and_command):
2896         Unify creation and re-initialization cases.
2897
2898 2019-07-17  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2901         creation and re-initialization cases.
2902
2903 2019-07-17  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-regs.c (tui_get_register): Return void.
2906
2907 2019-07-17  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2910         Simplify.
2911
2912 2019-07-17  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2915         resetting.
2916
2917 2019-07-17  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2920         * tui/tui-regs.c (tui_reg_layout): New function.
2921         (tui_show_registers, tui_reg_command): Use it.
2922         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2923         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2924         parameters.
2925         (tui_layout_command): Remove.
2926
2927 2019-07-17  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-layout.h (tui/tui-layout): Return void.
2930         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2931
2932 2019-07-17  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-layout.c (show_source_disasm_command, show_data):
2935         Update.
2936         (reset_locator): Remove.
2937         (show_source_or_disasm_and_command): Update.
2938
2939 2019-07-17  Tom Tromey  <tom@tromey.com>
2940
2941         * tui/tui-source.c (tui_source_window_base::reset): Remove
2942         win_type parameter.
2943         * tui/tui-layout.c (make_command_window, make_source_window)
2944         (make_disasm_window, make_data_window)
2945         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2946         (reset_locator, show_source_or_disasm_and_command): Update.
2947         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2948         win_type parameter.
2949         (struct tui_source_window_base) <reset>: Likewise.
2950
2951 2019-07-17  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-layout.c (show_source_disasm_command): Use
2954         reset_locator.
2955         (reset_locator): New function.
2956         (init_and_make_win): Remove.
2957         (show_source_or_disasm_and_command): Use reset_locator.
2958
2959 2019-07-17  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2962         condition.
2963         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2964         Remove condition.
2965         * tui/tui-source.c (tui_source_window_base::reset): New method.
2966         * tui/tui-layout.c (make_command_window): Don't call
2967         init_and_make_win.
2968         (make_source_window, make_disasm_window): Don't call
2969         make_source_or_disasm_window.
2970         (make_data_window): Don't call init_and_make_win.  Change calling
2971         convention.
2972         (show_source_disasm_command, show_data): Simplify.
2973         (make_source_or_disasm_window): Remove.
2974         (show_source_or_disasm_and_command): Simplify.
2975         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2976         (struct tui_source_window_base) <reset>: Likewise.
2977         <execution_info>: Remove initializer.
2978         * tui/tui-data.c (tui_source_window_base): Initialize
2979         execution_info.
2980
2981 2019-07-17  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2984         variable.
2985
2986 2019-07-17  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui.c (tui_rl_other_window): Update.
2989         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2990         superclass method first.  Always iterate over regs_content.
2991         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2992         method.
2993         * tui/tui-win.c (tui_set_focus_command): Update.
2994
2995 2019-07-17  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-win.c (tui_set_focus_command): Rename from
2998         tui_set_focus.  Call tui_enable.
2999         (tui_set_focus_command): Remove.
3000
3001 2019-07-17  Tom Tromey  <tom@tromey.com>
3002
3003         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3004         refresh_window.
3005         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3006         touchwin.
3007         (tui_data_window::refresh_window): Call refresh_window on data
3008         items.  Always call superclass refresh_window.
3009         (tui_win_info::refresh): Remove.
3010         (tui_source_window_base::refresh_window): Update.
3011         (tui_refresh_all): Update.
3012         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3013         refresh_window.
3014         (show_source_or_disasm_and_command): Likewise.
3015         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3016         (struct tui_source_window_base) <refresh>: Likewise.
3017
3018 2019-07-17  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-winsource.c (tui_clear_source_content)
3021         (tui_show_source_content): Update.
3022         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3023         whether content is empty.
3024         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3025         Remove.
3026
3027 2019-07-17  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3030         window's contents.
3031         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3032         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3033
3034 2019-07-17  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3037         (struct tui_data_item_window): Update.
3038
3039 2019-07-17  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3042         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3043         defines.
3044
3045 2019-07-17  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-winsource.h (tui_erase_source_content)
3048         (tui_clear_source_content): Remove "display_prompt" parameter.
3049         * tui/tui-winsource.c (tui_update_source_window_as_is)
3050         (tui_update_source_windows_with_addr): Update.
3051         (tui_clear_source_content): Remove "display_prompt" parameter.
3052         (tui_erase_source_content): Likewise.  Simplify.
3053         (tui_show_source_content): Update.
3054         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3055         * tui/tui-stack.c (tui_show_frame_info): Update.
3056         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3057         Remove defines.
3058
3059 2019-07-17  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3062         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3063         parameter.
3064         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3065         parameter.
3066
3067 2019-07-17  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-winsource.c (tui_clear_source_content)
3070         (tui_show_source_content, tui_show_exec_info_content)
3071         (tui_clear_exec_info_content): Update.
3072         * tui/tui-stack.c (tui_show_locator_content): Update.
3073         (tui_show_frame_info): Update.
3074         * tui/tui-source.h (tui_source_window): Don't declare.
3075         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3076         from tui_source_is_displayed.
3077         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3078         Remove field.
3079         (struct tui_source_window_base) <content_in_use>: New field.  Now
3080         bool.
3081         (struct tui_source_window) <showing_source_p>: New method.
3082         (TUI_SRC_WIN): Change cast.
3083         * tui/tui-data.c (tui_initialize_static_data): Update.
3084
3085 2019-07-17  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3088         location_matches_p.
3089         * tui/tui-source.c (tui_source_window::location_matches_p): New
3090         method.
3091         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3092         method.
3093         * tui/tui-data.h (struct tui_source_window_base)
3094         <location_matches_p>: New method.
3095         (struct tui_source_window, struct tui_disasm_window)
3096         <location_matches_p>: Likewise.
3097
3098 2019-07-17  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-win.c (tui_set_win_height_command): Rename from
3101         tui_set_win_height.
3102         (tui_set_win_height_command): Remove.
3103
3104 2019-07-17  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-source.c (tui_source_window): New constructor.  Add
3107         observer.
3108         (~tui_source_window): New destructor.
3109         (tui_source_window::style_changed): New method.
3110         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3111         (tui_attach_detach_observers): Update.
3112         * tui/tui-data.h (struct tui_source_window): Make constructor not
3113         inline.  Add destructor.
3114         (struct tui_source_window) <style_changed>: New method.
3115         <m_observable>: New member.
3116
3117 2019-07-17  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3120         * tui/tui-win.c (tui_resize_all): Fix typo.
3121
3122 2019-07-17  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3125         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3126         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3127         * tui/tui-win.c (window_name_completer): Use foreach.
3128         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3129         (update_tab_width): Likewise.
3130         * tui/tui-layout.c (show_layout): Update.
3131         * tui/tui-data.h (class tui_window_iterator): New.
3132         (struct all_tui_windows): New.
3133         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3134
3135 2019-07-17  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3138         parameter.  Don't reference globals.
3139         (tui_reg_command): Update.
3140
3141 2019-07-17  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-regs.c (tui_show_registers): Simplify.
3144
3145 2019-07-17  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-regs.c (tui_show_registers): Update.
3148         (tui_show_register_group): Add win_info parameter.
3149
3150 2019-07-17  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3153         Rename from tui_display_reg_element_at_line.
3154         (tui_data_window::display_registers_from_line): Update.
3155         * tui/tui-data.h (struct tui_data_window)
3156         <display_reg_element_at_line>: New method.
3157
3158 2019-07-17  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-regs.h (tui_display_registers_from)
3161         (tui_display_registers_from_line): Don't declare.
3162         * tui/tui-windata.c (tui_data_window::display_all_data)
3163         (tui_data_window::refresh_all)
3164         (tui_data_window::do_scroll_vertical): Update.
3165         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3166         from tui_display_registers_from.
3167         (tui_display_reg_element_at_line): Update.
3168         (tui_data_window::display_registers_from_line): Rename from
3169         tui_display_registers_from_line.
3170         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3171         display_registers_from_line>: New methods.
3172
3173 2019-07-17  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3176         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3177         from tui_erase_data_content.
3178         (tui_data_window::display_all_data)
3179         (tui_data_window::refresh_all)
3180         (tui_data_window::do_scroll_vertical): Update.
3181         * tui/tui-regs.c (tui_show_registers): Update.
3182         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3183         New method.
3184
3185 2019-07-17  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3188         declare.
3189         * tui/tui-windata.c
3190         (tui_data_window::delete_data_content_windows): Rename from
3191         tui_delete_data_content_windows.
3192         (tui_data_window::display_all_data)
3193         (tui_data_window::do_scroll_vertical): Update.
3194         * tui/tui-data.h (struct tui_data_window)
3195         <delete_data_content_windows>: New method.
3196
3197 2019-07-17  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3200         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3201
3202 2019-07-17  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3205         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3206         from tui_display_all_data.
3207         * tui/tui-win.c
3208         (tui_data_window::do_make_visible_with_new_height): Update.
3209         * tui/tui-regs.c (tui_show_registers): Update.
3210         * tui/tui-layout.c (tui_set_layout): Update.
3211         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3212         method.
3213
3214 2019-07-17  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3217         * tui/tui-windata.c (tui_display_data_from): Remove.
3218         (tui_data_window::refresh_all): Update.
3219
3220 2019-07-17  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3223         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3224         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3225         tui_display_registers_from_line.
3226         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3227         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3228         "force_display" parameter.
3229
3230 2019-07-17  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3233         declare.
3234         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3235         Rename from tui_first_reg_element_no_inline.
3236         (tui_display_reg_element_at_line)
3237         (tui_display_registers_from_line): Update.
3238         * tui/tui-data.h (struct tui_data_window)
3239         <first_reg_element_no_inline>: New method.
3240
3241 2019-07-17  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-windata.c (tui_display_data_from)
3244         (tui_data_window::do_scroll_vertical): Update.
3245         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3246         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3247         Rename from tui_line_from_reg_element_no.
3248         (tui_display_registers_from_line): Update.
3249         * tui/tui-data.h (struct tui_data_window)
3250         <line_from_reg_element_no>: New method.
3251
3252 2019-07-17  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3255         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3256         tui_last_regs_line_no.
3257         (tui_display_reg_element_at_line)
3258         (tui_display_registers_from_line): Update.
3259         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3260         method.
3261
3262 2019-07-17  Tom Tromey  <tom@tromey.com>
3263
3264         PR tui/24722:
3265         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3266         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3267         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3268         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3269         (tui_update_breakpoint_info): Likewise.
3270         * tui/tui-hooks.c (tui_event_create_breakpoint)
3271         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3272         Update.
3273
3274 2019-07-17  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3277
3278 2019-07-17  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-winsource.c (tui_update_source_window_as_is)
3281         (tui_update_source_windows_with_addr): Update.
3282         * tui/tui-source.h (tui_set_source_content)
3283         (tui_show_symtab_source): Add "win_info" parameter.
3284         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3285         parameter.
3286         (tui_show_symtab_source): Likewise.
3287
3288 2019-07-17  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-wingeneral.c
3291         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3292
3293 2019-07-17  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3296         (struct tui_cmd_window) <can_scroll>: New method.
3297         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3298         method.
3299
3300 2019-07-17  Tom Tromey  <tromey@adacore.com>
3301
3302         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3303         do_field_signed>: Rename.  Change type of "value".
3304         * ui-out.c (ui_out::field_signed): Rename from field_int.
3305         Change type of "value".
3306         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3307         type of "value".
3308         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3309         do_field_int.  Change type of "value".
3310         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3311         do_field_int.  Change type of "value".
3312         * tracepoint.c (trace_status_mi, tfind_1)
3313         (print_one_static_tracepoint_marker): Update.
3314         * thread.c (print_thread_info_1, print_selected_thread_frame):
3315         Update.
3316         * stack.c (print_frame, print_frame_info): Update.
3317         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3318         Update.
3319         * source.c (print_source_lines_base): Update.
3320         * skip.c (info_skip_command): Update.
3321         * record-btrace.c (btrace_ui_out_decode_error)
3322         (btrace_call_history_src_line): Update.
3323         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3324         Update.
3325         * progspace.c (print_program_space): Update.
3326         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3327         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3328         do_field_int.  Change type of "value".
3329         * mi/mi-out.c (mi_ui_out::do_table_begin)
3330         (mi_ui_out::do_table_header): Update.
3331         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3332         type of "value".
3333         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3334         (mi_cmd_data_list_changed_registers, output_register)
3335         (mi_cmd_data_read_memory, mi_load_progress)
3336         (mi_cmd_trace_frame_collected): Update.
3337         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3338         Update.
3339         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3340         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3341         (mi_cmd_var_list_children, varobj_update_one): Update.
3342         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3343         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3345         * inferior.c (print_inferior): Update.
3346         * gdb_bfd.c (print_one_bfd): Update.
3347         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3348         Update.
3349         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3350         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3351         do_field_int.  Change type of "value".
3352         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3353         do_field_int.  Change type of "value".
3354         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3355         (print_one_breakpoint_location, print_it_catch_fork)
3356         (print_one_catch_fork, print_it_catch_vfork)
3357         (print_one_catch_vfork, print_it_catch_solib)
3358         (print_it_catch_exec, print_it_ranged_breakpoint)
3359         (print_mention_watchpoint, print_mention_masked_watchpoint)
3360         (bkpt_print_it, update_static_tracepoint): Update.
3361         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3362         * break-catch-syscall.c (print_it_catch_syscall): Update.
3363         * ada-tasks.c (print_ada_task_info): Update.
3364         * ada-lang.c (print_it_exception, print_mention_exception):
3365         Update.
3366
3367 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3368
3369         PR breakpoints/24541
3370         * gdbarch.c: Regenerate.
3371         * gdbarch.h: Regenerate.
3372         * gdbarch.sh: Adjust return type and parameter types for
3373         'stap_adjust_register'.
3374         (i386_stap_adjust_register): Adjust signature and return new
3375         register name.
3376         * stap-probe.c (stap_parse_register_operand): Adjust use of
3377         'gdbarch_stap_adjust_register'.
3378
3379 2019-07-17  Tom Tromey  <tromey@adacore.com>
3380
3381         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3382         declare VEC.
3383         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3384         std::vector.
3385         (struct s390_process_info): Add initializers.
3386         (s390_add_process): Use new.
3387         (s390_linux_nat_target::low_forget_process): Use delete.
3388         (s390_linux_nat_target::low_new_fork)
3389         (s390_linux_nat_target::stopped_by_watchpoint)
3390         (s390_linux_nat_target::low_prepare_to_resume)
3391         (s390_linux_nat_target::insert_watchpoint)
3392         (s390_linux_nat_target::insert_hw_breakpoint)
3393         (s390_linux_nat_target::remove_watchpoint)
3394         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3395
3396 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3397
3398         * aarch64-fbsd-nat.c: Include regcache.h.
3399         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3400         argument.
3401         (aarch64_fbsd_nat_target::fetch_registers)
3402         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3403         variable.
3404         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3405
3406 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3407
3408         * fbsd-nat.c: Include gdbarch.h.
3409
3410 2019-07-15  Tom Tromey  <tromey@adacore.com>
3411
3412         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3413
3414 2019-07-15  Tom Tromey  <tromey@adacore.com>
3415
3416         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3417         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3418         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3419         * cli-out.c (cli_ui_out::do_field_int): New method.
3420         * ui-out.c (ui_out::field_unsigned): New method.
3421         * symfile.c (generic_load): Use field_unsigned.
3422         (print_transfer_performance): Likewise.
3423         * record-btrace.c (ui_out_field_uint): Remove.
3424         (btrace_call_history_insn_range, btrace_call_history): Use
3425         field_unsigned.
3426         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3427         field_unsigned.
3428         * ui-out.h (class ui_out) <field_unsigned>: New method.
3429         <do_field_unsigned>: Likewise.
3430
3431 2019-07-15  Tom Tromey  <tromey@adacore.com>
3432
3433         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3434         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3435         * target.c (flash_erase_command): Use field_string.
3436         * infrun.c (print_signal_received_reason): Use field_string.
3437         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3438         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3439         field_string.
3440         * ada-tasks.c (print_ada_task_info): Use field_string.
3441
3442 2019-07-15  Tom Tromey  <tromey@adacore.com>
3443
3444         * target.c (flash_erase_command): Use field_core_addr.
3445         * symfile.c (generic_load): Use field_core_addr.
3446         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3447         Use field_core_addr.
3448         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3449         field_core_addr.
3450
3451 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3454         value if its desired type is smaller than a CORE_ADDR and signed.
3455
3456 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3459         of changes to field names, and use new is_reference field to
3460         decide if a property is a reference or not.
3461         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3462         field.
3463         (struct dwarf2_property_baton): Update header comment, rename
3464         'referenced_type' to 'property_type' and update comments.
3465         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3466         default property type, store in property baton, update to take
3467         accound of renamed field.
3468         (read_func_scope): Update call to attr_to_dynamic_prop.
3469         (read_array_type): Likewise.
3470         (dwarf2_per_cu_addr_sized_int_type): New function.
3471         (read_subrange_index_type): Move type finding code to
3472         dwarf2_per_cu_addr_sized_int_type.
3473         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3474         (dwarf2_per_cu_addr_type): New function.
3475         (set_die_type): Update calls to attr_to_dynamic_prop.
3476
3477 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * dwarf2read.c (read_subrange_index_type): New function.
3480         (read_subrange_type): Move code into new function and call it.
3481         * gdbtypes.c (create_range_type): Add some asserts.
3482
3483 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3486         update return statements.
3487         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3488         declaration, and update comment to match.
3489         * gdbtypes.c (resolve_dynamic_array): Update call to
3490         dwarf2_evaluate_property to match new return type.
3491
3492 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3493
3494         * valarith.c (value_subscripted_rvalue): Change lowerbound
3495         parameter type from int to LONGEST.
3496         * value.h (value_subscripted_rvalue): Likewise in declaration.
3497
3498 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3499
3500         * cli/cli-utils.c (info_print_command_completer): New function.
3501         * cli/cli-utils.h: Add 'completer.h' include, and forward
3502         declaration for 'struct cmd_list_element'.
3503         (info_print_command_completer): Declare.
3504         * stack.c (_initialize_stack): Add completer for 'info locals' and
3505         'info args'.
3506         * symtab.c (_initialize_symtab): Add completer for 'info
3507         variables' and 'info functions'.
3508         * NEWS: Mention completion for additional info commands.
3509
3510 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3511
3512         * cli/cli-utils.c (extract_info_print_args): Delete.
3513         (extract_arg_maybe_quoted): Delete.
3514         (info_print_options_defs): New variable.
3515         (make_info_print_options_def_group): New function.
3516         (extract_info_print_options): Define new function.
3517         * cli/cli-utils.h (extract_info_print_args): Delete.
3518         (struct info_print_options): New structure.
3519         (extract_info_print_options): Declare new function.
3520         * stack.c (info_locals_command): Update to use new
3521         extract_info_print_options, also add a header comment.
3522         (info_args_command): Likewise.
3523         * symtab.c (info_variables_command): Likewise.
3524         (info_functions_command): Likewise.
3525
3526 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3527
3528         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3529         to extract string arguments.
3530         * common/common-utils.c (extract_string_maybe_quoted): New function.
3531         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3532
3533 2019-07-11  Tom Tromey  <tromey@adacore.com>
3534
3535         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3536         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3537         * top.h (gdbinit): Don't declare.
3538         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3539         into...
3540         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3541         * top.c (gdb_init): Don't call init_cli_cmds.
3542         (gdbinit): Remove.
3543         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3544
3545 2019-07-11  Tom Tromey  <tromey@adacore.com>
3546
3547         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3548         after it has been moved.
3549
3550 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3551
3552         * valops.c (value_must_coerce_to_target): Change return type to
3553         bool.
3554         * value.h (value_must_coerce_to_target): Likewise.
3555
3556 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3557
3558         * breakpoint.c (is_hardware_watchpoint): Remove
3559         forward-declaration.
3560         (is_masked_watchpoint): Change return type to bool.
3561         (is_tracepoint): Likewise.
3562         (is_breakpoint): Likewise.
3563         (is_hardware_watchpoint): Likewise.
3564         (is_watchpoint): Likewise.
3565         (is_no_memory_software_watchpoint): Likewise.
3566         (is_catchpoint): Likewise.
3567         (breakpoint_1): Make FILTER parameter's return type bool.
3568         is_masked_watchpoint): Change return type to bool.
3569         (save_breakpoints): Make FILTER parameter's return type bool.
3570         * breakpoint.h (is_breakpoint): Change return type to bool.
3571         (is_watchpoint): Likewise.
3572         (is_catchpoint): Likewise.
3573         (is_tracepoint): Likewise.
3574
3575 2019-07-10  Tom Tromey  <tom@tromey.com>
3576
3577         * defs.h: Don't include gdbarch.h.
3578         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3579         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3580         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3581         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3582         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3583         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3584         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3585         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3586         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3587         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3588         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3589         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3590         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3591         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3592         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3593         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3594         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3595         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3596         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3597         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3598         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3599         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3600         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3601         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3602         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3603         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3604         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3605
3606 2019-07-10  Tom Tromey  <tromey@adacore.com>
3607
3608         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3609         * breakpoint.c (init_ada_exception_breakpoint): Register as
3610         bp_catchpoint.
3611         (print_one_breakpoint_location, print_one_breakpoint): Use
3612         is_ada_exception_catchpoint.
3613         * ada-lang.c (class ada_catchpoint_location): Pass
3614         bp_loc_software_breakpoint to bp_location constructor.
3615         (is_ada_exception_catchpoint): New function.
3616
3617 2019-07-10  Tom Tromey  <tromey@adacore.com>
3618
3619         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3620         VEC.
3621         (struct arm_exidx_entry): New method operator<.
3622         (struct arm_exidx_data) <section_maps>: Change type.
3623         (arm_exidx_data_free): Remove.
3624         (arm_exidx_data_key): Change type.  Move lower.
3625         (arm_exidx_new_objfile): Update.
3626         (arm_compare_exidx_entries): Remove.
3627         (arm_find_exidx_entry, _initialize_arm_tdep)
3628
3629 2019-07-10  Tom Tromey  <tromey@adacore.com>
3630
3631         * solib-spu.c (ocl_program_data_key): Change type.
3632         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3633         Update.
3634
3635 2019-07-10  Tom Tromey  <tromey@adacore.com>
3636
3637         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3638         (struct solib_aix_inferior_data) <library_list>: Change type.
3639         (solib_aix_inferior_data_handle): Change type.
3640         (get_solib_aix_inferior_data): Update.
3641         (solib_aix_free_library_list): Remove.
3642         (library_list_start_library): Update.
3643         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3644         return type.
3645         (solib_aix_get_library_list)
3646         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3647         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3648
3649 2019-07-10  Tom Tromey  <tromey@adacore.com>
3650
3651         * solib-dsbt.c (struct dsbt_info): Add initializers.
3652         (solib_dsbt_pspace_data): Change type.
3653         (dsbt_pspace_data_cleanup): Remove.
3654         (get_dsbt_info, _initialize_dsbt_solib): Update.
3655
3656 2019-07-10  Tom Tromey  <tromey@adacore.com>
3657
3658         * spu-tdep.c (spu_overlay_data): Change type.
3659         (spu_get_overlay_table, spu_overlay_new_objfile)
3660         (_initialize_spu_tdep): Update.
3661
3662 2019-07-10  Tom Tromey  <tromey@adacore.com>
3663
3664         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3665         destructor.
3666         (dbx_objfile_data_key): Change type and declare later.
3667         (DBX_SYMFILE_INFO): Rewrite.
3668         * dbxread.c (dbx_objfile_data_key): Change type.
3669         (dbx_symfile_init): Update.
3670         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3671         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3672         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3673
3674 2019-07-10  Tom Tromey  <tromey@adacore.com>
3675
3676         * jit.c (jit_program_space_key): Change type.  Move lower.
3677         (get_jit_program_space_data): Update.
3678         (jit_program_space_data_cleanup): Remove.
3679         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3680         Update.
3681         (struct jit_program_space_data): Add initializers.
3682
3683 2019-07-10  Tom Tromey  <tromey@adacore.com>
3684
3685         * solib-darwin.c (struct darwin_info): Add initializers.
3686         (solib_darwin_pspace_data): Change type.
3687         (darwin_pspace_data_cleanup): Remove.
3688         (get_darwin_info, _initialize_darwin_solib): Update.
3689
3690 2019-07-10  Tom Tromey  <tromey@adacore.com>
3691
3692         * remote-sim.c (struct sim_inferior_data): Add initializers,
3693         constructor, and destructor.
3694         (sim_inferior_data_key): Change type.  Move lower.
3695         (check_for_duplicate_sim_descriptor): Update.
3696         (get_sim_inferior_data): Use new.  Update.
3697         (~sim_inferior_data_cleanup): Rename from
3698         sim_inferior_data_cleanup.  Simplify.
3699         (gdbsim_close_inferior, simulator_command)
3700         (sim_command_completer, _initialize_remote_sim): Update.
3701         (next_pid, INITIAL_PID): Move earlier.
3702
3703 2019-07-10  Tom Tromey  <tromey@adacore.com>
3704
3705         * python/python-internal.h (create_thread_object): Return
3706         gdbpy_ref.
3707         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3708         * python/py-inferior.c (struct threadlist_entry): Add
3709         constructor.
3710         <thread_obj>: Now a gdbpy_ref.
3711         (thread_to_thread_object): Update.
3712         (add_thread_object): Use new.
3713         (delete_thread_object): Use delete.
3714         (infpy_threads): Update.
3715         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3716         GIL.
3717
3718 2019-07-10  Tom Tromey  <tromey@adacore.com>
3719
3720         * valops.c (value_cast): Specialize error message for Ada.
3721
3722 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3723
3724         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3725
3726 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3727
3728         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3729         bpstat_should_step): Return bool, adjust comments.
3730         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3731         bpstat_should_step): Likewise.
3732
3733 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3734
3735         * features/Makefile: Use feature target descriptions for Arm.
3736         * features/arm/arm-core.c: Generate new file.
3737         * features/arm/arm-fpa.c: Likewise.
3738         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3739         * features/arm/arm-m-profile.c: Likewise.
3740         * features/arm/arm-vfpv2.c: Likewise.
3741         * features/arm/arm-vfpv3.c: Likewise.
3742         * features/arm/xscale-iwmmxt.c: Likewise.
3743         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3744
3745 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3746
3747         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3748         ptrace earlier.
3749
3750 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3751
3752         * features/aarch64-pauth.c: Regenerate.
3753
3754 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3755
3756         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3757         bool.
3758         (bpstat_what): Use false instead of 0.
3759
3760 2019-07-09  Pedro Alves  <palves@redhat.com>
3761
3762         * break-catch-throw.c (is_exception_catchpoint): New.
3763         * breakpoint.c (print_one_breakpoint_location): New parameter
3764         'raw_loc'.  Handle it.  Use
3765         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3766         looking at the breakpoint's type.
3767         (print_one_breakpoint): If handling "maint info breakpoints", also
3768         print locations of exception catchpoints.
3769         * breakpoint.h (is_exception_catchpoint): Declare.
3770
3771 2019-07-09  Pedro Alves  <palves@redhat.com>
3772
3773         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3774         "addr" field.
3775         (allocate_location_exception_catchpoint): New.
3776         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3777         (initialize_throw_catchpoint_ops): Install
3778         allocate_location_exception_catchpoint as allocate_location
3779         method.
3780         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3781         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3782         bp_loc_other.
3783         (breakpoint_address_is_meaningful): Delete.
3784         (bl_address_is_meaningful): New.
3785         (breakpoint_locations_match): Adjust comment.
3786         (bp_location_from_bp_type): New, factored out of...
3787         (bp_location::bp_location(breakpoint *)): ... this.
3788         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3789         factored out of...
3790         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3791         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3792         breakpoint_address_is_meaningful.
3793         (bp_locations_compare): Adjust comment.
3794         (update_global_location_list): Use bl_address_is_meaningful
3795         instead of breakpoint_address_is_meaningful.
3796         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3797         explicit.
3798         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3799         * python/py-breakpoint.c (bppy_get_location): No longer check
3800         whether location is null.
3801
3802 2019-07-09  Pedro Alves  <palves@redhat.com>
3803
3804         PR c++/15468
3805         * breakpoint.c (print_one_breakpoint_location): Remove
3806         single-location assert.
3807
3808 2019-07-09  Tom Tromey  <tom@tromey.com>
3809
3810         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3811         * configure: Rebuild.
3812         * configure.ac: Change common to gdbsupport.
3813         * gdbsupport: Rename from common.
3814         * acinclude.m4: Change common to gdbsupport.
3815         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3816         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3817         gdbsupport.
3818         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3819         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3820         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3821         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3822         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3823         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3824         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3825         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3826         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3827         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3828         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3829         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3830         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3831         coff-pe-read.c, command.h, compile/compile-c-support.c,
3832         compile/compile-c.h, compile/compile-cplus-symbols.c,
3833         compile/compile-cplus-types.c, compile/compile-cplus.h,
3834         compile/compile-loc2c.c, compile/compile.c, completer.c,
3835         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3836         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3837         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3838         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3839         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3840         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3841         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3842         features/aarch64-core.c, features/aarch64-fpu.c,
3843         features/aarch64-pauth.c, features/aarch64-sve.c,
3844         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3845         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3846         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3847         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3848         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3849         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3850         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3851         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3852         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3853         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3854         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3855         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3856         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3857         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3858         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3859         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3860         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3861         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3862         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3863         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3864         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3865         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3866         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3867         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3868         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3869         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3870         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3871         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3872         minsyms.c, mips-linux-tdep.c, namespace.h,
3873         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3874         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3875         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3876         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3877         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3878         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3879         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3880         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3881         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3882         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3883         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3884         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3885         procfs.c, producer.c, progspace.h, psymtab.h,
3886         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3887         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3888         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3889         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3890         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3891         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3892         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3893         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3894         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3895         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3896         target-memory.c, target.c, target.h, target/waitstatus.c,
3897         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3898         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3899         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3900         unittests/array-view-selftests.c,
3901         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3902         unittests/common-utils-selftests.c,
3903         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3904         unittests/format_pieces-selftests.c,
3905         unittests/function-view-selftests.c,
3906         unittests/lookup_name_info-selftests.c,
3907         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3908         unittests/mkdir-recursive-selftests.c,
3909         unittests/observable-selftests.c,
3910         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3911         unittests/parse-connection-spec-selftests.c,
3912         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3913         unittests/scoped_fd-selftests.c,
3914         unittests/scoped_mmap-selftests.c,
3915         unittests/scoped_restore-selftests.c,
3916         unittests/string_view-selftests.c, unittests/style-selftests.c,
3917         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3918         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3919         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3920         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3921         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3922         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3923
3924 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3927         bool value.
3928         (decode_digits_ordinary): Set explicit_line field in sal.
3929         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3930         symtab_and_line that was set on an explicit line number in
3931         assembler code.  Do always update the recorded symtab and line if
3932         we do skip the prologue.
3933
3934 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * breakpoint.c (set_breakpoint_location_function): Remove
3937         explicit_loc parameter.
3938         (momentary_breakpoint_from_master): Update call to
3939         set_breakpoint_location_function.
3940         (add_location_to_breakpoint): Likewise.
3941
3942 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3945         required features based on default bfd type when no specific bfd
3946         is present.
3947
3948 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3949
3950         * NEWS: Mention that GDB printf and eval commands can now print
3951         C-style and Ada-style convenience var strings without
3952         calling the inferior.
3953         * printcmd.c (printf_c_string): Locally print GDB internal var
3954         instead of transiting via the inferior.
3955         (printf_wide_c_string): Likewise.
3956
3957 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3958
3959         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3960
3961 2019-07-04  Tom Tromey  <tom@tromey.com>
3962
3963         PR tui/24724:
3964         * tui/tui-winsource.c (tui_clear_source_content): Update.
3965         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3966         (tui_update_breakpoint_info): Update.
3967         (tui_set_exec_info_content): Update.
3968         * tui/tui-source.c (tui_set_source_content_nil): Update.
3969         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3970         has_break.
3971         * tui/tui-data.h (enum tui_bp_flag): New.
3972         (tui_bp_flags): New enum flags type.
3973         (struct tui_source_element) <break_mode>: Change type.  Rename
3974         from has_break.
3975         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3976         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3977         constants.
3978         * tui/tui-winsource.h: Fix comment.
3979
3980 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3981
3982         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3983         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3984         (store_fpregs_to_thread)
3985         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3986         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3987         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3988         (IWMMXT_REGS_SIZE): Add define.
3989         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3990         (fetch_vfp_regs, store_vfp_regs)
3991         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3992         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3993
3994 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3995
3996         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3997         defines.
3998         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3999         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4000         (ARM_INT_REGISTER_SIZE): ...to this.
4001         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4002         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4003         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4004         (arm_linux_collect_gregset, supply_nwfpe_register)
4005         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4006         defines.
4007         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4008         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4009         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4010         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4011         (arm_return_in_memory, arm_store_return_value)
4012         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4013         (arm_record_ld_st_multiple): Likewise.
4014         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4015         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4016
4017 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4018
4019         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4020         AARCH64_DISPLACED_MODIFIED_INSNS.
4021         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4022         (aarch64_displaced_step_copy_insn): Likewise.
4023         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4024         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4025         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4026         ARM_DISPLACED_MODIFIED_INSNS.
4027         * arm-tdep.c (arm_gdbarch_init): Likewise.
4028         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4029         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4030         (struct arm_displaced_step_closure): Use
4031         ARM_DISPLACED_MODIFIED_INSNS.
4032
4033 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4034
4035         * features/Makefile: Remove unused xml files.
4036         * features/aarch64.xml: Remove.
4037         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4038         * features/i386/amd64-avx-avx512.xml: Remove.
4039         * features/i386/amd64-avx-linux.xml: Remove.
4040         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4041         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4042         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4043         * features/i386/amd64-avx-mpx.xml: Remove.
4044         * features/i386/amd64-avx.xml: Remove.
4045         * features/i386/amd64-linux.xml: Remove.
4046         * features/i386/amd64-mpx-linux.xml: Remove.
4047         * features/i386/amd64-mpx.xml: Remove.
4048         * features/i386/amd64.xml: Remove.
4049         * features/i386/i386-avx-avx512-linux.xml: Remove.
4050         * features/i386/i386-avx-avx512.xml: Remove.
4051         * features/i386/i386-avx-linux.xml: Remove.
4052         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4053         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4054         * features/i386/i386-avx-mpx-linux.xml: Remove.
4055         * features/i386/i386-avx-mpx.xml: Remove.
4056         * features/i386/i386-avx.xml: Remove.
4057         * features/i386/i386-linux.xml: Remove.
4058         * features/i386/i386-mmx-linux.xml: Remove.
4059         * features/i386/i386-mmx.xml: Remove.
4060         * features/i386/i386-mpx-linux.xml: Remove.
4061         * features/i386/i386-mpx.xml: Remove.
4062         * features/i386/i386.xml: Remove.
4063         * features/i386/x32-avx-avx512-linux.xml: Remove.
4064         * features/i386/x32-avx-linux.xml: Remove.
4065         * features/i386/x32-linux.xml: Remove.
4066
4067 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4068
4069         * regformats/aarch64.dat: Remove.
4070         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4071         * regformats/i386/amd64-avx-linux.dat: Remove.
4072         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4073         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4074         * regformats/i386/amd64-linux.dat: Remove.
4075         * regformats/i386/amd64-mpx-linux.dat: Remove.
4076         * regformats/i386/amd64.dat: Remove.
4077         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4078         * regformats/i386/i386-avx-linux.dat: Remove.
4079         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4080         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4081         * regformats/i386/i386-linux.dat: Remove.
4082         * regformats/i386/i386-mmx-linux.dat: Remove.
4083         * regformats/i386/i386-mpx-linux.dat: Remove.
4084         * regformats/i386/i386.dat: Remove.
4085         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4086         * regformats/i386/x32-avx-linux.dat: Remove.
4087         * regformats/i386/x32-linux.dat: Remove.
4088
4089 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4090
4091         * aarch64-tdep.c: Remove xml self tests.
4092         * amd64-linux-tdep.c: Likewise.
4093         * amd64-tdep.c: Likewise.
4094         * i386-linux-tdep.c: Likewise.
4095         * i386-tdep.c: Likewise.
4096
4097 2019-07-03  Pedro Alves  <palves@redhat.com>
4098
4099         PR cli/24732
4100         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4101         (pipe_cmd_option_defs): New.
4102         (make_pipe_cmd_options_def_group): New.
4103         (pipe_command): Use gdb::option::process_options.
4104         (pipe_command_completer): New function.
4105         (_initialize_cli_cmds): Install completer for "pipe" command.
4106
4107 2019-07-03  Pedro Alves  <palves@redhat.com>
4108
4109         * cli/cli-option.c (union option_value) <string>: New field.
4110         (struct option_def_and_value): Add ctor, move ctor, dtor and
4111         use DISABLE_COPY_AND_ASSIGN.
4112         (option_def_and_value::clear_value): New.
4113         (parse_option, save_option_value_in_ctx, get_val_type_str)
4114         (add_setshow_cmds_for_options): Handle var_string.
4115         * cli-option.h (union option_def::var_address) <string>: New
4116         field.
4117         (struct string_option_def): New.
4118         * maint-test-options.c (struct test_options_opts): Add default
4119         ctor and use DISABLE_COPY_AND_ASSIGN.
4120         <string_opt>: New field.
4121         (test_options_opts::~test_options_opts): New.
4122         (test_options_opts::dump): Also dump "-string".
4123         (test_options_option_defs): Install "string.
4124
4125 2019-07-03  Pedro Alves  <palves@redhat.com>
4126
4127         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4128         option_value with a null enumeration.
4129         (complete_options): Save the option values in the context.
4130         (save_option_value_in_ctx): New, factored out from ...
4131         (process_options): ... here.
4132         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4133         of the function.
4134         * maint-test-options.c (test_options_opts::dump): New, factored
4135         out from ...
4136         (maintenance_test_options_command_mode): ... here.
4137         (maintenance_test_options_command_completion_result): Delete.
4138         (maintenance_test_options_command_completion_text): Update
4139         comment.
4140         (maintenance_show_test_options_completion_result): Change
4141         prototype.  Just print
4142         maintenance_test_options_command_completion_text.
4143         (save_completion_result): New.
4144         (maintenance_test_options_completer_mode): Pass options context to
4145         complete_options, and then save a dump.
4146         (_initialize_maint_test_options): Use add_cmd to install "maint
4147         show test-options-completion-result".
4148
4149 2019-07-03  Pedro Alves  <palves@redhat.com>
4150
4151         * NEWS (New commands): Mention "with" and "maint with".
4152         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4153         (with_command, with_command_completer): New.
4154         (pipe_command): Adjust to new repeat_previous
4155         interface.
4156         (_initialize_cli_cmds): Install the "with" command and its "w"
4157         alias.
4158         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4159         declarations.
4160         * cli/cli-setshow.c (parse_cli_var_uinteger)
4161         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4162         argument strings for all var_types.
4163         (get_setshow_command_value_string): New, factored out from ...
4164         (do_show_command): ... this.
4165         * cli/cli-setshow.h: Include <string>.
4166         (get_setshow_command_value_string): Declare.
4167         * command.h (repeat_previous): Now returns const char *.  Adjust
4168         comment.
4169         * maint.c: Include "cli/cli-cmds.h".
4170         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4171         (_initialize_maint_cmds): Register the "maintenance with" command.
4172         * top.c (repeat_previous): Move bits from pipe_command here:
4173         Return the saved command line, if any; error out if there's no
4174         command to relaunch.
4175
4176 2019-07-03  Pedro Alves  <palves@redhat.com>
4177
4178         * NEWS (New commands): Mention "maint set/show test-settings"
4179         instead of "maint test-settings".
4180         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4181         (maintenance_test_settings_set_list): Rename to ...
4182         (maintenance_set_test_settings_list): ... this.
4183         (maintenance_test_settings_show_list): Rename to  ...
4184         (maintenance_show_test_settings_list): ... this.
4185         (maintenance_test_settings_cmd): Delete.
4186         (maintenance_test_settings_set_cmd): ...
4187         (maintenance_set_test_settings_cmd): ... this.
4188         (maintenance_test_settings_show_cmd): ...
4189         (maintenance_show_test_settings_cmd): ... this.
4190         (maintenance_test_settings_show_value_cmd):
4191         (maintenance_show_test_settings_value_cmd): ... this.
4192         (_initialize_maint_test_settings): No longer install the "maint
4193         test-settings" prefix command.  Rename "maint test-settings set"
4194         to "maint set test-settings", and "maint test-settings show" to
4195         "maint show test-settings".  Adjust all subcommands.
4196
4197 2019-07-03  Pedro Alves  <palves@redhat.com>
4198
4199         * maint-test-settings.c: Fix file's intro comment.  Replace all
4200         references to "test-options" with references to "test-settings",
4201         in comments.
4202
4203 2019-07-03  Pedro Alves  <palves@redhat.com>
4204
4205         * maint-test-settings.c (maintenance_test_settings_xxx)
4206         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4207         New.
4208         (maintenance_test_settings_enums): Use them.
4209         (maintenance_test_settings_enum): Default to
4210         maintenance_test_settings_xxx.
4211         (_initialize_maint_test_settings): Initialize
4212         MAINTENANCE_TEST_SETTINGS_FILENAME.
4213
4214 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4215
4216         * breakpoint.h (remove_breakpoints_inf): Change return type to
4217         void, move function documentation here.
4218         * breakpoint.c (remove_breakpoints_inf): Change return type to
4219         void, move function documentation to header.
4220
4221 2019-07-02  Pedro Alves  <palves@redhat.com>
4222
4223         * NEWS (Completion improvements): Mention "info threads".
4224         * thread.c (struct info_threads_opts, info_threads_option_defs)
4225         (make_info_threads_options_def_group): New.
4226         (info_threads_command): Use gdb::option::process_options.
4227         (info_threads_command_completer): New.
4228         (_initialize_thread): Use gdb::option::build_help to build the
4229         help text for "info threads".
4230
4231 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4232
4233         * defs.h (generic_load): Move from here...
4234         * symfile.h (generic_load): ... to here.  Rename name parameter
4235         to args.
4236         * symfile.c (generic_load): Add comment.
4237
4238 2019-07-01  Tom Tromey  <tromey@adacore.com>
4239
4240         * dwarf2read.c
4241         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4242         declaration of without_params.  Fix formatting.
4243
4244 2019-07-01  Tom Tromey  <tromey@adacore.com>
4245
4246         * ada-exp.y (find_primitive_type): Update.
4247         * ada-lang.h (ada_lookup_symbol): Update.
4248         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4249         parameter.
4250         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4251
4252 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4253
4254         PR breakpoints/24541
4255         * gdbarch.c: Regenerate.
4256         * gdbarch.h: Regenerate.
4257         * gdbarch.sh: Add 'stap_adjust_register'.
4258         * i386-tdep.c: Include '<unordered_set>'.
4259         (i386_stap_adjust_register): New function.
4260         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4261         * stap-probe.c (stap_parse_register_operand): Call
4262         'gdbarch_stap_adjust_register'.
4263
4264 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4265
4266         PR python/24742
4267         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4268         * python/python.c (do_start_initialization): Use 'xmalloc'
4269         instead of 'PyMem_Malloc'.
4270
4271 2019-06-28  Tom Tromey  <tromey@adacore.com>
4272
4273         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4274         for Ada.
4275
4276 2019-06-27  Tom Tromey  <tromey@adacore.com>
4277
4278         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4279         objfile_key.
4280         (arm_find_mapping_symbol, arm_record_special_symbol)
4281         (_initialize_arm_tdep): Update.
4282         (arm_objfile_data_free): Remove.
4283
4284 2019-06-27  Tom Tromey  <tromey@adacore.com>
4285
4286         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4287         to cp_print_static_field.
4288
4289 2019-06-26  Tom Tromey  <tromey@adacore.com>
4290
4291         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4292         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4293         declare.
4294
4295 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4296
4297         * features/aarch64-core.c (create_feature_aarch64_core):
4298         Regenerate.
4299         * features/aarch64-core.xml: Add cpsr flags.
4300
4301 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4302
4303         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4304         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4305
4306 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4307
4308         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4309         field.
4310         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4311         use.
4312         (arm_record_special_symbol): Don't insert new symbol in sorted
4313         position, push it at the end.
4314
4315 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4316
4317         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4318         (arm_mapping_symbol_s): Remove.
4319         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4320         (arm_mapping_symbol_vec): New typedef.
4321         (struct arm_per_objfile): Add constructor.
4322         <section_maps>: Change type to
4323         std::unique_ptr<arm_mapping_symbol_vec[]>.
4324         (arm_compare_mapping_symbols): Remove.
4325         (arm_find_mapping_symbol): Adjust to section_maps type change.
4326         (arm_objfile_data_free): Call delete on arm_per_objfile.
4327         (arm_record_special_symbol): Adjust to section_maps type change.
4328         Allocate arm_per_objfile with new.
4329
4330 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4331
4332         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4333         with the command prefix.
4334
4335 2019-06-25  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4338         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4339
4340 2019-06-25  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4343         type.
4344         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4345         protected.
4346
4347 2019-06-25  Tom Tromey  <tom@tromey.com>
4348
4349         * tui/tui-winsource.c
4350         (tui_source_window_base::set_is_exec_point_at): Add check against
4351         LOA_ADDRESS.
4352
4353 2019-06-25  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-source.c (tui_set_source_content): Don't check before
4356         xfree.
4357         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4358
4359 2019-06-25  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-winsource.h (tui_update_source_window_as_is)
4362         (tui_alloc_source_buffer, tui_line_is_displayed)
4363         (tui_addr_is_displayed): Change type of win_info.
4364         * tui/tui-winsource.c (tui_update_source_window_as_is)
4365         (tui_clear_source_content, tui_show_source_line)
4366         (tui_show_source_content, tui_source_window_base::refill)
4367         (tui_source_window_base::set_is_exec_point_at)
4368         (tui_source_window_base::set_is_exec_point_at)
4369         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4370         (tui_alloc_source_buffer, tui_line_is_displayed)
4371         (tui_addr_is_displayed): Change type of win_info.  Update.
4372         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4373         (tui_source_window_base::do_make_visible_with_new_height):
4374         Update.
4375         * tui/tui-source.c (tui_set_source_content)
4376         (tui_set_source_content_nil)
4377         (tui_source_window::do_scroll_vertical): Update.
4378         * tui/tui-layout.c (show_layout): Update.
4379         * tui/tui-disasm.c (tui_set_disassem_content)
4380         (tui_disasm_window::do_scroll_vertical): Update.
4381         * tui/tui-data.h (tui_win_content): Remove.
4382         (struct tui_gen_win_info) <content, content_size>: Remove.
4383         (struct tui_source_element): Add initializers and destructor.
4384         (union tui_which_element, struct tui_win_element): Remove.
4385         (struct tui_source_window_base) <content>: New field.
4386         (struct tui_data_window): Remove destructor.
4387         (tui_alloc_content, tui_free_win_content)
4388         (tui_free_all_source_wins_content): Don't declare.
4389         * tui/tui-data.c (tui_initialize_static_data): Update.
4390         (init_content_element, tui_alloc_content): Remove.
4391         (~tui_gen_win_info): Update.
4392         (~tui_data_window, tui_free_all_source_wins_content)
4393         (tui_free_win_content, free_content, free_content_elements):
4394         Remove.
4395
4396 2019-06-25  Tom Tromey  <tom@tromey.com>
4397
4398         * tui/tui-winsource.h (tui_clear_source_content)
4399         (tui_erase_source_content, tui_show_source_content): Change type
4400         of win_info.
4401         * tui/tui-winsource.c (tui_clear_source_content)
4402         (tui_erase_source_content, tui_show_source_content): Change type
4403         of win_info.
4404         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4405         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4406         win_info.
4407         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4408         win_info.
4409         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4410
4411 2019-06-25  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui-winsource.c (tui_clear_source_content)
4414         (tui_source_window_base::set_is_exec_point_at): Update.
4415         * tui/tui-source.c (tui_set_source_content_nil): Update.
4416         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4417         a bool.
4418         * tui/tui-data.c (init_content_element): Update.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4423         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4424         * tui/tui-layout.c (init_and_make_win): Update.
4425         * tui/tui.h (enum tui_win_type): Update.
4426         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4427         tui_win_is_auxillary.
4428         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4429         tui_win_is_auxillary.
4430
4431 2019-06-25  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4434         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4435         (tui_delete_data_content_windows, tui_display_all_data)
4436         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4437         Update.
4438         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4439         * tui/tui-regs.c (tui_last_regs_line_no)
4440         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4441         (tui_show_registers): Update.
4442         (tui_show_register_group): Return void.  Update.
4443         (tui_display_registers_from, tui_display_reg_element_at_line)
4444         (tui_display_registers_from_line, tui_check_register_values):
4445         Update.
4446         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4447         member.
4448         (struct tui_data_window) <regs_content>: Now a std::vector.
4449         <regs_content_count>: Remove.
4450         (tui_add_content_elements, tui_free_data_content): Don't declare.
4451         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4452         (init_content_element): Remove DATA_WIN case.  Add assert.
4453         (tui_add_content_elements): Remove.
4454         (tui_data_window): Update.
4455         (tui_free_data_content): Remove.
4456         (free_content_elements): Remove DATA_WIN case.
4457
4458 2019-06-25  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-data.c (tui_data_item_window): Update.
4461         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4462         * tui/tui-windata.c (tui_display_all_data)
4463         (tui_display_data_from_line): Update.
4464         (tui_check_data_values): Remove.
4465         * tui/tui-regs.c (tui_show_register_group)
4466         (tui_display_reg_element_at_line): Update.
4467         * tui/tui-hooks.c (tui_register_changed)
4468         (tui_refresh_frame_and_register_information): Call
4469         tui_check_register_values.
4470         * tui/tui-data.h (struct tui_data_window) <data_content,
4471         data_content_count, data_type>: Remove.
4472         (enum tui_data_type): Remove.
4473
4474         * tui/tui-data.c (tui_data_window::clear_detail)
4475         (~tui_data_window): Update.
4476
4477 2019-06-25  Tom Tromey  <tom@tromey.com>
4478
4479         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4480         declare.
4481         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4482         Rename from tui_first_data_item_displayed.  Update.
4483         (tui_data_window::refresh_all)
4484         (tui_data_window::do_scroll_vertical): Update.
4485         * tui/tui-data.h (struct tui_data_window)
4486         <first_data_item_displayed>: Declare new method.
4487
4488 2019-06-25  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4491         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4492         contents...
4493         (tui_initialize_static_data): ...here.
4494
4495 2019-06-25  Tom Tromey  <tom@tromey.com>
4496
4497         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4498         (tui_display_registers_from, tui_check_register_values): Update.
4499         (tui_display_register): Remove win_info parameter; update.
4500         (tui_get_register): Change type of parameters.
4501         * tui/tui-data.h (struct tui_data_element): Remove.
4502         (union tui_which_element) <data>: Remove.
4503         <data_window>: Change type.
4504         (struct tui_data_item_window): New.
4505         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4506         case.  Add assert.
4507         (~tui_data_item_window): New destructor.
4508         (free_content_elements): Remove DATA_ITEM_WIN case.
4509
4510 2019-06-25  Tom Tromey  <tom@tromey.com>
4511
4512         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4513         Remove.
4514
4515 2019-06-25  Tom Tromey  <tom@tromey.com>
4516
4517         * tui/tui-data.h (struct tui_command_element): Remove.
4518         (union tui_which_element) <command>: Remove.
4519         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4520         assert.
4521         (free_content_elements): Remove CMD_WIN case.
4522
4523 2019-06-25  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-layout.c (tui_set_layout): Update.
4526         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4527         * tui/tui-data.c (layout_def): Update.
4528
4529 2019-06-25  Tom Tromey  <tom@tromey.com>
4530
4531         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4532         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4533         (tui_source_window_base::set_new_height): Update.
4534         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4535         Update.
4536         (tui_set_locator_fullname, tui_set_locator_info)
4537         (tui_show_frame_info): Update.
4538         * tui/tui-source.c (tui_set_source_content)
4539         (tui_source_is_displayed): Update.
4540         * tui/tui-layout.c (show_source_disasm_command, show_data)
4541         (show_source_or_disasm_and_command): Update.
4542         * tui/tui-disasm.c (tui_set_disassem_content)
4543         (tui_get_begin_asm_address): Update.
4544         * tui/tui-data.h (struct tui_locator_element): Remove.
4545         (union tui_which_element) <locator>: Remove.
4546         (struct tui_locator_window): New.
4547         (tui_locator_win_info_ptr): Change return type.
4548         * tui/tui-data.c (_locator): Change type.
4549         (tui_locator_win_info_ptr): Change return type.
4550         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4551         (tui_alloc_content): Add assert.
4552
4553 2019-06-25  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-winsource.c
4556         (tui_exec_info_window::maybe_allocate_content): New method.
4557         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4558         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4559         (make_source_or_disasm_window): Add cast.
4560         * tui/tui-data.h (union tui_which_element) <simple_string>:
4561         Remove.
4562         (struct tui_source_info): New.
4563         (struct tui_source_window_base) <execution_info>: Change type.
4564         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4565         case, and add assert.
4566         (tui_alloc_content): Add assert.
4567
4568 2019-06-25  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4571         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4572         * tui/tui-data.c (tui_alloc_win_info): Remove.
4573
4574 2019-06-25  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4577         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4578         can_highlight.
4579
4580 2019-06-25  Tom Tromey  <tom@tromey.com>
4581
4582         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4583         make_visible_with_new_height method.
4584         (tui_win_info::make_visible_with_new_height): New method.
4585         (tui_source_window_base::do_make_visible_with_new_height)
4586         (tui_data_window::do_make_visible_with_new_height)
4587         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4588         (make_visible_with_new_height): Remove.
4589         (tui_resize_all, tui_adjust_win_heights): Use
4590         make_visible_with_new_height method.
4591         * tui/tui-data.h (struct tui_win_info)
4592         <do_make_visible_with_new_height, make_visible_with_new_height>:
4593         New methods.
4594         (struct tui_source_window_base, struct tui_data_window)
4595         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4596         methods.
4597
4598 2019-06-25  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4601         method.
4602         (update_tab_width): Call update_tab_width method.
4603         * tui/tui-data.h (struct tui_win_info)
4604         (struct tui_source_window_base) <update_tab_width>: New methods.
4605
4606 2019-06-25  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4609         parameter.
4610         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4611         parameter.
4612         (tui_gen_win_info::make_visible): Update.
4613         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4614         parameter.
4615         * tui/tui-data.h (enum tui_box): New enum.
4616         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4617
4618 2019-06-25  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4621         init_and_make_win for EXEC_INFO_WIN.
4622         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4623         longer inline.
4624         (struct tui_win_info) <~tui_win_info>: Inline.
4625         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4626         Don't declare.
4627         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4628         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4629         Remove.
4630         (tui_initialize_static_data): Update.
4631         (~tui_gen_win_info): Handle more cleanup here.
4632         (~tui_source_window_base): Delete "execution_info".
4633         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4634
4635 2019-06-25  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui-layout.c (make_command_window): Don't set
4638         can_highlight.
4639         (show_source_disasm_command): Call the reset method.
4640         (show_data): Don't set can_highlight.  Call the reset method.
4641         (tui_gen_win_info::reset): Rename from init_gen_win_info
4642         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4643         (show_source_or_disasm_and_command): Call the reset method.
4644         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4645         (struct tui_cmd_window): Set can_highlight.
4646
4647 2019-06-25  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4650         from make_visible.
4651         (tui_make_visible, tui_make_invisible): Rewrite.
4652         (tui_win_info::make_visible): Remove.
4653         (tui_source_window_base::make_visible): Update.
4654         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4655         method.  Moved from...
4656         (struct tui_win_info) <make_visible>: ...here.
4657
4658 2019-06-25  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-winsource.c
4661         (tui_source_window_base::do_scroll_horizontal): Remove direction
4662         parameter.
4663         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4664         direction parameter.
4665         * tui/tui-win.c (tui_win_info::forward_scroll)
4666         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4667         (tui_win_info::right_scroll): Update.
4668         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4669         direction parameter.
4670         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4671         direction parameter.
4672         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4673         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4674         Remove direction parameter.
4675         (struct tui_source_window_base, struct tui_source_window)
4676         (struct tui_disasm_window, struct tui_data_window)
4677         (struct tui_cmd_window): Update.
4678
4679 2019-06-25  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-winsource.h (tui_set_exec_info_content)
4682         (tui_show_exec_info_content, tui_erase_exec_info_content)
4683         (tui_clear_exec_info_content, tui_update_exec_info): Change
4684         argument to tui_source_window_base.
4685         * tui/tui-winsource.c (tui_set_exec_info_content)
4686         (tui_show_exec_info_content, tui_erase_exec_info_content)
4687         (tui_clear_exec_info_content, tui_update_exec_info): Change
4688         argument to tui_source_window_base.
4689
4690 2019-06-25  Tom Tromey  <tom@tromey.com>
4691
4692         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4693         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4694
4695 2019-06-25  Tom Tromey  <tom@tromey.com>
4696
4697         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4698         check.
4699
4700 2019-06-25  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4703         type to void.
4704         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4705         type to void.
4706         * tui/tui-source.c (tui_set_source_content): Update.
4707         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4708
4709 2019-06-25  Tom Tromey  <tom@tromey.com>
4710
4711         * tui/tui-win.c (window_name_completer, tui_set_focus)
4712         (tui_all_windows_info): Use name method.
4713         * tui/tui-data.h (struct tui_gen_win_info)
4714         (struct tui_source_window, struct tui_disasm_window)
4715         (struct tui_data_window, struct tui_cmd_window) <name>: New
4716         method.
4717         (tui_win_name): Don't declare.
4718         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4719         (tui_win_name): Remove.
4720
4721 2019-06-25  Tom Tromey  <tom@tromey.com>
4722
4723         * tui/tui-winsource.h (tui_update_source_window)
4724         (tui_update_source_window_as_is): Change parameter type.
4725         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4726         to be a tui_source_window_base.
4727         (tui_update_source_window_as_is): Likewise.
4728         * tui/tui-win.c (make_visible_with_new_height): Update.
4729
4730 2019-06-25  Tom Tromey  <tom@tromey.com>
4731
4732         * tui/tui-winsource.c (tui_erase_source_content)
4733         (tui_show_source_content, tui_show_exec_info_content)
4734         (tui_erase_exec_info_content): Use refresh_window method.
4735         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4736         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4737         from tui_refresh_win.
4738         (tui_data_window::refresh_window): New method.
4739         (tui_win_info::refresh, tui_source_window_base::refresh)
4740         (tui_refresh_all): Use refresh_window method.
4741         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4742         method.
4743         * tui/tui-regs.c (tui_display_register): Call refresh_window
4744         method.
4745         * tui/tui-layout.c (show_source_disasm_command)
4746         (show_source_or_disasm_and_command): Call refresh_window method.
4747         * tui/tui-data.h (struct tui_gen_win_info)
4748         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4749         New method.
4750
4751 2019-06-25  Tom Tromey  <tom@tromey.com>
4752
4753         * tui/tui.c (tui_rl_other_window, tui_enable)
4754         (tui_is_window_visible, tui_get_command_dimension): Update.
4755         * tui/tui-winsource.c (tui_update_source_window_as_is)
4756         (tui_clear_source_content, tui_erase_source_content)
4757         (tui_show_source_line, tui_source_window_base::refill)
4758         (tui_source_window_base::do_scroll_horizontal)
4759         (tui_source_window_base::set_is_exec_point_at)
4760         (tui_update_breakpoint_info, tui_set_exec_info_content)
4761         (tui_alloc_source_buffer, tui_line_is_displayed)
4762         (tui_addr_is_displayed): Update.
4763         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4764         (tui_check_and_display_highlight_if_needed)
4765         (tui_win_info::make_visible, tui_win_info::refresh)
4766         (tui_refresh_all): Update.
4767         * tui/tui-windata.c (tui_first_data_item_displayed)
4768         (tui_delete_data_content_windows, tui_erase_data_content)
4769         (tui_display_all_data, tui_data_window::refresh_all)
4770         (tui_check_data_values): Update.
4771         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4772         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4773         (tui_win_info::backward_scroll, tui_refresh_all_win)
4774         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4775         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4776         (tui_source_window_base::set_new_height)
4777         (tui_data_window::set_new_height)
4778         (make_invisible_and_set_new_height)
4779         (make_visible_with_new_height, new_height_ok)
4780         (parse_scrolling_args): Update.
4781         * tui/tui-stack.c (tui_show_frame_info): Update.
4782         * tui/tui-source.c (tui_set_source_content)
4783         (tui_set_source_content_nil, tui_source_is_displayed)
4784         (tui_source_window::do_scroll_vertical): Update.
4785         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4786         (tui_display_registers_from, tui_display_reg_element_at_line)
4787         (tui_check_register_values, tui_reg_command): Update.
4788         * tui/tui-layout.c (tui_default_win_height)
4789         (show_source_disasm_command, show_data, init_and_make_win)
4790         (show_source_or_disasm_and_command): Update.
4791         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4792         (tui_redisplay_readline, tui_mld_flush)
4793         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4794         (tui_getc): Update.
4795         * tui/tui-disasm.c (tui_set_disassem_content)
4796         (tui_disasm_window::do_scroll_vertical): Update.
4797         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4798         Now virtual.
4799         (struct tui_win_info): Derive from tui_gen_win_info.
4800         <~tui_win_info>: Mark as override.
4801         <generic>: Remove member.
4802         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4803         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4804         (~tui_data_window, ~tui_win_info)
4805         (tui_free_all_source_wins_content): Update.
4806         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4807
4808 2019-06-25  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-layout.c (init_and_make_win): Use new.
4811         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4812         destructor, initializers.
4813         (tui_alloc_generic_win_info): Don't declare.
4814         * tui/tui-data.c (_locator): Add argument to constructor.
4815         (source_win, disasm_win): New globals.
4816         (exec_info): Remove.
4817         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4818         Update.
4819         (tui_alloc_generic_win_info): Remove.
4820         (init_content_element): Use new.
4821         (tui_win_info::tui_win_info): Update.
4822         (free_content_elements) <case DATA_WIN>: Use delete.
4823
4824 2019-06-25  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4827         * tui/tui-windata.c (tui_first_data_item_displayed)
4828         (tui_delete_data_content_windows): Update.
4829         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4830         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4831         (tui_display_registers_from, tui_check_register_values): Update.
4832         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4833         pointer.
4834         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4835         window.
4836         (tui_free_data_content): Update.
4837         (free_content_elements) <case DATA_WIN>: Free the window.
4838
4839 2019-06-25  Tom Tromey  <tom@tromey.com>
4840
4841         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4842         Update.
4843         * tui/tui-layout.c (make_command_window)
4844         (show_source_disasm_command, show_data, init_and_make_win)
4845         (show_source_or_disasm_and_command): Update.
4846         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4847         method.
4848         <can_highight, is_highlighted>: Now bool.
4849         (tui_set_win_highlight): Don't declare.
4850         * tui/tui-data.c (tui_set_win_highlight): Remove.
4851
4852 2019-06-25  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-wingeneral.c (make_visible): Remove check of window
4855         type.
4856
4857 2019-06-25  Tom Tromey  <tom@tromey.com>
4858
4859         * tui/tui-win.c (tui_win_info::max_height)
4860         (tui_cmd_window::max_height): New methods.
4861         (new_height_ok): Call max_height.
4862         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4863         <max_height>: New method.
4864
4865 2019-06-25  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-win.c (tui_source_window_base::set_new_height)
4868         (tui_data_window::set_new_height): New methods.
4869         (make_invisible_and_set_new_height): Call set_new_height method.
4870         * tui/tui-data.h (struct tui_win_info)
4871         (struct tui_source_window_base, struct tui_data_window)
4872         <set_new_height>: New method.
4873
4874 2019-06-25  Tom Tromey  <tom@tromey.com>
4875
4876         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4877         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4878         tui_refresh_data_win.
4879         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4880         method.
4881         (tui_refresh_all_win): Call the refresh_all method.
4882         (tui_set_focus): Likewise.
4883         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4884         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4885         Likewise.
4886
4887 2019-06-25  Tom Tromey  <tom@tromey.com>
4888
4889         * tui/tui-winsource.h (tui_refill_source_window)
4890         (tui_set_is_exec_point_at): Don't declare.
4891         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4892         (tui_source_window_base::refill): Rename from
4893         tui_refill_source_window.
4894         (tui_source_window_base::do_scroll_horizontal): Update.
4895         (tui_source_window_base::set_is_exec_point_at): Rename from
4896         tui_set_is_exec_point_at.
4897         (tui_update_all_breakpoint_info): Update.
4898         * tui/tui-stack.c (tui_show_frame_info): Update.
4899         * tui/tui-layout.c (show_data): Add cast.
4900         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4901         * tui/tui-data.h (struct tui_source_window_base) <refill,
4902         set_is_exec_point_at>: New methods.
4903         (tui_source_windows, tui_add_to_source_windows): Update types.
4904         (tui_add_to_source_windows): Remove redundant declaration.
4905         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4906         (tui_source_windows): Change return type.
4907         (tui_clear_source_windows_detail): Update.
4908         (tui_add_to_source_windows): Change type of parameter.
4909         (tui_free_all_source_wins_content): Update.
4910
4911 2019-06-25  Tom Tromey  <tom@tromey.com>
4912
4913         * tui/tui-wingeneral.c (tui_win_info::refresh)
4914         (tui_source_window_base::refresh): New methods.
4915         (tui_refresh_all): Call the refresh method.
4916         * tui/tui-data.h (struct tui_win_info)
4917         (struct tui_source_window_base) <refresh>: New method.
4918
4919 2019-06-25  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui.h (tui_is_window_visible): Return bool.
4922         * tui/tui.c (tui_is_window_visible): Return bool.
4923         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4924         (tui_make_visible, tui_make_invisible)
4925         (tui_win_info::make_visible)
4926         (tui_source_window_base::make_visible, make_all_visible)
4927         (tui_make_all_visible, tui_make_all_invisible): Update.
4928         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4929         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4930         bool.
4931         (struct tui_win_info, struct tui_source_window_base)
4932         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4933         * tui/tui-data.c (tui_init_generic_part): Update.
4934
4935 2019-06-25  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4938         (tui_source_window_base::make_visible): New methods.
4939         (make_all_visible): Make method call.
4940         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4941         (struct tui_source_window_base, struct tui_cmd_window): Override
4942         make_visible.
4943         (tui_win_is_source_type): Don't declare.
4944         * tui/tui-data.c (tui_win_is_source_type): Remove.
4945
4946 2019-06-25  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4949         NULL check.
4950
4951 2019-06-25  Tom Tromey  <tom@tromey.com>
4952
4953         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4954         Inline constructor.  Add initializers for members.
4955         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4956         constructors; now inline in class.
4957
4958 2019-06-25  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-regs.c (tui_show_registers): Update.
4961         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4962         bool.
4963         * tui/tui-data.c (tui_data_window::clear_detail)
4964         (tui_data_window): Update.
4965
4966 2019-06-25  Tom Tromey  <tom@tromey.com>
4967
4968         * tui/tui-windata.c (tui_display_all_data)
4969         (tui_display_data_from_line, tui_display_data_from)
4970         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4971         Update.
4972         * tui/tui-regs.c (tui_last_regs_line_no)
4973         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4974         (tui_show_registers, tui_show_register_group)
4975         (tui_display_registers_from, tui_display_reg_element_at_line)
4976         (tui_display_registers_from_line, tui_check_register_values)
4977         (tui_reg_next, tui_reg_prev): Update.
4978         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4979         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4980         tui_data_window.
4981         (struct tui_win_info) <detail>: Remove.  Add new fields from
4982         tui_data_info.
4983         (TUI_DATA_WIN): Add cast.
4984         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4985         (~tui_data_window): Simplify.
4986
4987 2019-06-25  Tom Tromey  <tom@tromey.com>
4988
4989         * tui/tui-layout.c (show_source_disasm_command)
4990         (show_source_or_disasm_and_command): Update.
4991         * tui/tui-io.c (update_cmdwin_start_line)
4992         (tui_redisplay_readline): Update.
4993         * tui/tui-data.h (struct tui_command_info): Remove.
4994         (struct tui_win_info) <detail>: Remove command_info member.
4995         (struct tui_data_window) <start_line>: New member, from
4996         tui_command_info.
4997         (TUI_CMD_WIN): Add casts.
4998
4999 2019-06-25  Tom Tromey  <tom@tromey.com>
5000
5001         * tui/tui-winsource.c (tui_update_source_window)
5002         (tui_refill_source_window)
5003         (tui_source_window_base::do_scroll_horizontal)
5004         (tui_update_breakpoint_info, tui_set_exec_info_content)
5005         (tui_show_exec_info_content, tui_erase_exec_info_content)
5006         (tui_clear_exec_info_content): Update.
5007         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5008         Update.
5009         * tui/tui-win.c (make_invisible_and_set_new_height)
5010         (make_visible_with_new_height): Update.
5011         * tui/tui-source.c (tui_set_source_content)
5012         (tui_show_symtab_source): Update.
5013         * tui/tui-layout.c (extract_display_start_addr)
5014         (show_source_disasm_command, show_data)
5015         (make_source_or_disasm_window)
5016         (show_source_or_disasm_and_command): Update.
5017         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5018         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5019         "gdbarch".
5020         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5021         to tui_source_window_base.
5022         (struct tui_win_info) <detail>: Remove source_info member.
5023         (struct tui_source_window_base) <has_locator>: Inline.
5024         Move contents from tui_source_info; rename has_locator member to
5025         m_has_locator.
5026         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5027         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5028         header file.
5029         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5030         Simplify.
5031         (tui_free_all_source_wins_content): Cast to
5032         tui_source_window_base.
5033
5034 2019-06-25  Tom Tromey  <tom@tromey.com>
5035
5036         * tui/tui-win.c (make_invisible_and_set_new_height)
5037         (make_visible_with_new_height): Call has_locator method.
5038         * tui/tui-layout.c (show_source_disasm_command, show_data)
5039         (show_source_or_disasm_and_command): Update for bool change.
5040         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5041         (tui_win_info) <has_locator>: New method.
5042         (struct tui_source_window_base) <has_locator>: New method.
5043         (tui_win_has_locator): Don't declare.
5044         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5045         from tui_win_has_locator.
5046         (tui_source_window_base): Use false, not FALSE.
5047
5048 2019-06-25  Tom Tromey  <tom@tromey.com>
5049
5050         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5051         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5052         clear_detail method directly.
5053         (tui_clear_win_detail): Remove.
5054
5055 2019-06-25  Tom Tromey  <tom@tromey.com>
5056
5057         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5058         "this", not TUI_DISASM_WIN.
5059
5060 2019-06-25  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5063         declare.
5064         * tui/tui-winsource.c
5065         (tui_source_window_base::do_scroll_horizontal): Rename from
5066         tui_horizontal_source_scroll.
5067         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5068         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5069         from tui_vertical_data_scroll.
5070         * tui/tui-win.h (tui_scroll): Don't declare.
5071         * tui/tui-win.c (tui_win_info::forward_scroll)
5072         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5073         (tui_win_info::right_scroll): Rename and update.
5074         (tui_scroll_forward_command, tui_scroll_backward_command)
5075         (tui_scroll_left_command, tui_scroll_right_command): Update.
5076         (tui_scroll): Remove.
5077         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5078         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5079         from tui_vertical_source_scroll.
5080         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5081         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5082         from tui_vertical_disassem_scroll.
5083         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5084         do_scroll_horizontal>: New methods.
5085         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5086         Likewise.
5087         (struct tui_source_window_base): Add do_scroll_horizontal.
5088         (struct tui_source_window, struct tui_disasm_window): Add
5089         do_scroll_vertical.
5090         (struct tui_data_window, struct tui_cmd_window): Add
5091         do_scroll_horizontal and do_scroll_vertical.
5092         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5093
5094 2019-06-25  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-data.h (struct tui_source_window_base): New struct.
5097         (struct tui_source_window): Derive from tui_source_window_base.
5098         (struct tui_disasm_window): New struct.
5099         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5100         from tui_source_window::clear_detail.
5101         (tui_source_window_base): Rename from tui_source_window.
5102         (~tui_source_window_base): Rename from ~tui_source_window.
5103         (tui_alloc_win_info): Create a tui_disasm_window.
5104
5105 2019-06-25  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-data.h (struct tui_source_window)
5108         (struct tui_data_window): Declare destructors.
5109         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5110         destructors.
5111         (tui_win_info): Simplify.
5112
5113 2019-06-25  Tom Tromey  <tom@tromey.com>
5114
5115         * tui/tui-winsource.c (tui_display_main)
5116         (tui_update_source_windows_with_addr)
5117         (tui_update_all_breakpoint_info): Update.
5118         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5119         (new_height_ok, parse_scrolling_args): Update.
5120         * tui/tui-stack.c (tui_show_frame_info): Update.
5121         * tui/tui-data.h (struct tui_list): Remove.
5122         (tui_source_windows): Return a reference to a std::vector.
5123         * tui/tui-data.c (source_windows): Now a std::vector.
5124         (tui_source_windows): Change return type.
5125         (tui_clear_source_windows): Rewrite.
5126         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5127         (tui_free_all_source_wins_content): Rewrite.
5128
5129 2019-06-25  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5132         (struct tui_data_window, struct tui_cmd_window): Declare
5133         clear_detail method.
5134         * tui/tui-data.c (tui_source_window::clear_detail)
5135         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5136         methods.
5137         (tui_clear_win_detail): Simplify.
5138
5139 2019-06-25  Tom Tromey  <tom@tromey.com>
5140
5141         * tui/tui-layout.c (make_source_window, make_disasm_window)
5142         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5143         Return the new window.
5144         (show_source_disasm_command, show_data)
5145         (show_source_or_disasm_and_command): Update.
5146
5147 2019-06-25  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5150         parameter.  Return the new window.
5151         (show_source_disasm_command): Update and remove NULL check.
5152         (show_source_or_disasm_and_command): Update.
5153
5154 2019-06-25  Tom Tromey  <tom@tromey.com>
5155
5156         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5157
5158 2019-06-25  Tom Tromey  <tom@tromey.com>
5159
5160         * tui/tui-data.h (struct tui_win_info): Make constructor
5161         protected.  Make destructor virtual.  Add initializers.
5162         (tui_source_window, tui_data_window, tui_cmd_window): New
5163         classes.
5164         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5165         constructor.  Add "type" parameter.
5166         (tui_source_window, tui_data_window, tui_cmd_window): New
5167         constructors.
5168         (tui_alloc_win_info): Instantiate the appropriate subclass.
5169
5170 2019-06-25  Tom Tromey  <tom@tromey.com>
5171
5172         * tui/tui-win.c (tui_resize_all): Use delete.
5173         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5174         destructor.
5175         (tui_free_window): Don't declare.
5176         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5177         Update.
5178
5179 2019-06-25  Tom Tromey  <tom@tromey.com>
5180
5181         * tui/tui-data.h (struct tui_win_info): Add constructor.
5182         * tui/tui-data.c (tui_alloc_win_info): Use new.
5183         (tui_free_window): Use delete.
5184
5185 2019-06-22  Tom Tromey  <tom@tromey.com>
5186
5187         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5188         declare.
5189         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5190
5191 2019-06-22  Tom Tromey  <tom@tromey.com>
5192
5193         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5194         declare.
5195         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5196
5197 2019-06-22  Tom de Vries  <tdevries@suse.de>
5198
5199         * dwarf2read.c (create_addrmap_from_aranges)
5200         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5201         instead of '%zu'.
5202
5203 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5204
5205         * dwarf2read.h (dwarf2_section_info_def): Remove.
5206         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5207         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5208         std::vector<dwarf2_section_info>.
5209         (struct dwo_file) <~dwo_file>: Remove.
5210         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5211         types field.
5212         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5213         (dwarf2_read_debug_names): Likewise.
5214         (create_debug_types_hash_table): Change parameter type to
5215         array_view, adjust code accordingly.
5216         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5217         (partial_die_info::fixup): Likewise.
5218         (determine_prefix): Likewise.
5219         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5220
5221 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5222
5223         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5224         gdb_bfd_ref_ptr.
5225         <~dwo_file>: Remove call to gdb_bfd_unref.
5226         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5227         gdb_bfd_ref_ptr::get.
5228
5229 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5230
5231         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5232         type to htab_up.
5233         * dwarf2read.c (struct dwo_file): Initialize fields.
5234         <~dwo_file>: New.
5235         (free_dwo_file): Remove, move content to ~dwo_file.
5236         (struct dwo_file_deleter): Remove.
5237         (dwo_file_up>: Remove custom deleter.
5238         (free_dwo_files): Remove.
5239         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5240         dwo_files.
5241         (process_skeletonless_type_units): Call unique_ptr::get.
5242         (allocate_dwo_file_hash_table): Add deleter to created hash
5243         table.  Change return type to htab_up.
5244         (lookup_dwo_file_slot): Don't memset dwo_file, call
5245         unique_ptr::get.
5246         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5247         (create_dwo_unit_in_dwp_v2): Likewise.
5248         (open_and_init_dwo_file): Likewise.
5249         (free_dwo_file_from_slot): Remove.
5250
5251 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5252
5253         * dwarf2read.h (struct dwarf2_section_info) <readin,
5254         is_virtual>: Change type to bool.
5255         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5256         true instead of 1.
5257
5258 2019-06-19  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-data.h (tui_init_content_element): Don't declare.
5261
5262 2019-06-19  Tom Tromey  <tom@tromey.com>
5263
5264         * tui/tui-data.h (tui_init_win_info): Don't declare.
5265
5266 2019-06-19  Tom de Vries  <tdevries@suse.de>
5267
5268         * dwarf2read.h (abstract_to_concrete): Change type to
5269         std::unordered_map<sect_offset, std::vector<sect_offset>,
5270         gdb::hash_enum<sect_offset>>.
5271
5272 2019-06-19  Tom Tromey  <tromey@adacore.com>
5273
5274         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5275         EVAL_AVOID_SIDE_EFFECTS specially.
5276
5277 2019-06-19  Tom Tromey  <tromey@adacore.com>
5278
5279         * source-cache.c (highlighter): New global.
5280         (source_cache::get_source_lines): Create a highlighter on demand.
5281
5282 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5283
5284         * defs.h (deprecated_interactive_hook): Delete declaration.
5285         * interps.c (clear_interpreter_hooks): Remove use of
5286         deprecated_interactive_hook.
5287         * top.c (deprecated_interactive_hook): Delete definition.
5288         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5289
5290 2019-06-18  Tom de Vries  <tdevries@suse.de>
5291
5292         PR gdb/24515
5293         * dwarf2read.h (abstract_to_concrete): Change type from
5294         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5295         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5296         * dwarf2read.c (read_variable): Update.
5297         (dwarf2_fetch_die_loc_sect_off): Update.
5298
5299 2019-06-17  Tom de Vries  <tdevries@suse.de>
5300
5301         PR gdb/24617
5302         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5303         accessing parent[parent_len - 1].
5304
5305 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5306
5307         PR gdb/24364
5308         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5309         call dtrace_process_dof with NULL dof.
5310
5311 2019-06-16  Tom de Vries  <tdevries@suse.de>
5312
5313         PR gdb/24445
5314         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5315
5316 2019-06-16  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5319         (make_all_visible): Use address of member.
5320
5321 2019-06-16  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5324         (tui_free_window, free_content, free_content_elements): Remove
5325         unnecessary cast.
5326         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5327         cast.
5328         * tui/tui-regs.c (tui_show_register_group)
5329         (tui_display_registers_from, tui_display_reg_element_at_line):
5330         Remove unnecessary cast.
5331
5332 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5333
5334         * linux-nat.c (normal_mask): Delete.
5335         (_initialize_linux_nat): Don't initialise normal_mask.
5336
5337 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5338
5339         PR gdb/24445
5340         * dwarf-index-write.h (write_psymtabs_to_index): Add
5341         dwz_basename parameter.
5342         * dwarf-index-write.c (write_gdbindex): Move file writing to
5343         write_gdbindex_1.  Change return type void.
5344         (assert_file_size): Move up, remove filename parameter.
5345         (write_gdbindex_1): New function.
5346         (write_debug_names): Change return type to void, call
5347         assert_file_size.
5348         (struct index_wip_file): New struct.
5349         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5350         file logic to index_wip_file.  Write index for dwz file if
5351         needed.
5352         (save_gdb_index_command): Pass basename of dwz file, if present.
5353         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5354         build-id of dwz file, if present.
5355         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5356         (dwarf2_get_dwz_file): Likewise.
5357         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5358         (dwarf2_get_dwz_file): Likewise.
5359
5360 2019-06-16  Tom Tromey  <tom@tromey.com>
5361
5362         * coffread.c (process_coff_symbol): Use xstrdup.
5363         * value.c (create_internalvar): Use xstrdup.
5364
5365 2019-06-16  Tom Tromey  <tom@tromey.com>
5366
5367         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5368         * breakpoint.c (stopin_command, stopat_command)
5369         (until_break_command, decode_location_default): Remove unnecessary
5370         cast.
5371         * utils.c (subset_compare): Remove unnecessary cast.
5372         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5373         cast.
5374         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5375         cast.
5376         * infcmd.c (path_command): Remove unnecessary cast.
5377         * coffread.c (decode_type): Remove unnecessary cast.
5378         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5379         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5380         * tui/tui-stack.c (tui_show_locator_content)
5381         (tui_show_frame_info): Remove unnecessary cast.
5382         * tui/tui-win.c (tui_scroll_forward_command)
5383         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5384         (parse_scrolling_args): Remove unnecessary cast.
5385         * tui/tui-data.c (init_win_info, tui_del_window)
5386         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5387         (free_content_elements): Remove unnecessary cast.
5388         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5389         unnecessary cast.
5390         * tui/tui-source.c (tui_set_source_content)
5391         (tui_vertical_source_scroll): Remove unnecessary cast.
5392         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5393         cast.
5394         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5395         * tui/tui-regs.c (tui_display_registers_from)
5396         (tui_display_register): Remove unnecessary cast.
5397         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5398         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5399         (make_visible): Remove unnecessary cast.
5400         * tui/tui-winsource.c (tui_erase_source_content)
5401         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5402         unnecessary cast.
5403         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5404         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5405         * stabsread.c (read_type, read_array_type, read_range_type):
5406         Remove unnecessary cast.
5407         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5408         (parse_symbol, parse_type, upgrade_type, parse_external)
5409         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5410         unnecessary cast.
5411         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5412
5413 2019-06-16  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-data.c (tui_alloc_generic_win_info)
5416         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5417         checks.
5418
5419 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5420             Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * f-typeprint.c (f_print_type): Don't return early for not
5423         associated or not allocated types.
5424         (f_type_print_varspec_suffix): Add print_rank parameter and print
5425         ranks of array types in case they dangling.
5426         (f_type_print_base): Add print_rank parameter.
5427
5428 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * NEWS: Mention new MI commands.
5431         * break-catch-throw.c (enum exception_event_kind): Move to
5432         breakpoint.h.
5433         (print_mention_exception_catchpoint): Output text as a single
5434         message.
5435         (catch_exception_command_1): Rename to...
5436         (catch_exception_event): ...this, make non-static, update header
5437         command, and change some parameter types.
5438         (catch_catch_command): Update for changes to
5439         catch_exception_command_1.
5440         (catch_throw_command): Likewise.
5441         (catch_rethrow_command): Likewise.
5442         * breakpoint.c (enum exception_event_kind): Delete.
5443         * breakpoint.h (enum exception_event_kind): Moved here from
5444         break-catch-throw.c.
5445         (catch_exception_event): Declare.
5446         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5447         (mi_cmd_catch_throw): New function.
5448         (mi_cmd_catch_rethrow): New function.
5449         (mi_cmd_catch_catch): New function.
5450         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5451         'catch-catch' entries.
5452         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5453         (mi_cmd_catch_rethrow): Declare.
5454         (mi_cmd_catch_catch): Declare.
5455
5456 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5457
5458         * annotate.c (annotate_source_line): Change return type to void,
5459         update implementation to match.
5460         * annotate.h (annotate_source_line): Change return type to void,
5461         update header comment.
5462         * stack.c (print_frame_info): Don't change what frame information
5463         is printed based on whether annotations are on or not.
5464
5465 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5468         (annotate_source): Make static.
5469         (annotate_source_line): Moved from source.c and renamed from
5470         identify_source_line.  Update the return type.
5471         * annotate.h (annotate_source): Delete declaration.
5472         (annotate_source_line): Declaration moved from source.h, and
5473         renamed from identify_source_line.  Return type updated.
5474         * source.c (identify_source_line): Moved to annotate.c and renamed
5475         to annotate_source_line.
5476         (info_line_command): Remove check of annotation_level.
5477         * source.h (identify_source_line): Move declaration to annotate.h
5478         and rename to annotate_source_line.
5479         * stack.c: Add 'annotate.h' include.
5480         (print_frame_info): Remove check of annotation_level before
5481         calling annotate_source_line.
5482
5483 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * source-cache.c (source_cache::get_plain_source_lines): Use
5486         open_source_file_with_line_charpos instead of just
5487         open_source_file, remove call to find_source_lines.
5488         (source_cache::get_source_lines): Likewise.
5489         * source.c (find_source_lines): Make static.
5490         (get_filename_and_charpos): Renamed into...
5491         (open_source_file_with_line_charpos): ..this along with changes to
5492         return a scoped_fd, and some other minor clean ups.
5493         (identify_source_line): Use open_source_file_with_line_charpos.
5494         (search_command_helper): Use open_source_file_with_line_charpos
5495         instead of just open_source_file, remove call to
5496         find_source_lines.
5497         * source.h (open_source_file_with_line_charpos): Declare new
5498         function.
5499         (find_source_lines): Delete declaration.
5500
5501 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5502
5503         * source.c (get_filename_and_charpos): Remove fullname
5504         parameter.
5505         (identify_source_line): Update call to get_filename_and_charpos.
5506
5507 2019-06-14  Tom Tromey  <tromey@adacore.com>
5508
5509         PR gdb/24502:
5510         * ui-style.h (skip_ansi_escape): Update comment.
5511         * ui-file.h (class no_terminal_escape_file): New class.
5512         * ui-file.c (no_terminal_escape_file::write)
5513         (no_terminal_escape_file::puts): New methods.
5514         * cli/cli-logging.c (handle_redirections): Use
5515         no_terminal_escape_file.
5516
5517 2019-06-14  Tom Tromey  <tromey@adacore.com>
5518
5519         * NEWS: Move convenience variable news above Python news.
5520
5521 2019-06-14  Tom Tromey  <tom@tromey.com>
5522
5523         * gnulib: Move directory to top-level.
5524         * configure.ac: Don't configure gnulib.
5525         * configure: Rebuild.
5526         * common/common-defs.h: Use new path to gnulib.
5527         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5528         (GNULIB_H): Remove.
5529         (INCGNU): Look in new gnulib location.
5530         (HFILES_NO_SRCDIR): Remove gnulib files.
5531         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5532         (generated_files): Remove GNULIB_H.
5533         ($(LIBGNU), all-lib): Remove targets.
5534         (distclean): Don't mention GNULIB_BUILDDIR.
5535         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5536
5537 2019-06-14  Tom Tromey  <tromey@adacore.com>
5538
5539         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5540         Warn if symbol file does not provide any symbols.
5541
5542 2019-06-14  Tom Tromey  <tromey@adacore.com>
5543
5544         * source.c (find_and_open_source): Respect basenames_may_differ.
5545
5546 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5547
5548         * annotate.c (annotate_breakpoints_invalid): Make use of
5549         scoped_restore_terminal_state.
5550         (annotate_frames_invalid): Likewise.
5551
5552 2019-06-14  Tom Tromey  <tromey@adacore.com>
5553
5554         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5555         allow assignment to an internalvar.
5556
5557 2019-06-14  Tom Tromey  <tromey@adacore.com>
5558
5559         * ada-lex.l: Allow "_" in attribute names.
5560
5561 2019-06-14  Tom Tromey  <tromey@adacore.com>
5562
5563         PR gdb/24653:
5564         * regcache.c (registers_changed): Don't call alloca.
5565         * top.c (execute_command): Don't call alloca.
5566
5567 2019-06-13  Pedro Alves  <palves@redhat.com>
5568
5569         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5570         'expression'.  When parsing an expression, error out if there's
5571         junk after "unlimited".
5572         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5573         (do_set_command): Adjust calls to is_unlimited_literal.
5574
5575 2019-06-13  Pedro Alves  <palves@redhat.com>
5576
5577         * compile/compile.c (make_compile_options_def_group): Add braces
5578         around array_view initializer.
5579         * thread.c (make_thread_apply_all_options_def_group)
5580         (make_thread_apply_all_options_def_group): Likewise.
5581
5582 2019-06-13  Pedro Alves  <palves@redhat.com>
5583
5584         * NEWS (New commands): Mention "maint test-options
5585         require-delimiter", "maint test-options unknown-is-error", "maint
5586         test-options unknown-is-operand" and "maint show
5587         test-options-completion-result".
5588         (New command options, command completion): New section.
5589         (Completion improvements): New section.
5590         Mention that you can abbreviate "unlimited".
5591
5592 2019-06-13  Pedro Alves  <palves@redhat.com>
5593
5594         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5595         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5596         * unittests/cli-utils-selftests.c (test_parse_flags)
5597         (test_parse_flags_qcs): Delete.
5598         (test_cli_utils): Don't call deleted functions.
5599
5600 2019-06-13  Pedro Alves  <palves@redhat.com>
5601
5602         * thread.c: Include "cli/cli-option.h".
5603         (tp_array_compar_ascending): Global.
5604         (tp_array_compar): Delete function.
5605         (tp_array_compar_ascending, tp_array_compar_descending): New
5606         functions.
5607         (ascending_option_def, qcs_flag_option_def)
5608         (thr_qcs_flags_option_defs)
5609         (make_thread_apply_all_options_def_group)
5610         (make_thread_apply_options_def_group): New.
5611         (thread_apply_all_command): Use gdb::option::process_options.
5612         (thread_apply_command_completer)
5613         (thread_apply_all_command_completer): New.
5614         (thread_apply_command): Use gdb::option::process_options.
5615         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5616         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5617         to generate help text of "thread apply".  Adjust "taas"'s help.
5618         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5619         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5620
5621 2019-06-13  Pedro Alves  <palves@redhat.com>
5622
5623         * thread.c (thread_apply_command): Check for invalid TID with
5624         isdigit instead of !isalpha.
5625
5626 2019-06-13  Pedro Alves  <palves@redhat.com>
5627
5628         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5629         (validate_flags_qcs): New.
5630         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5631         (validate_flags_qcs): Declare.
5632         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5633         (make_frame_apply_options_def_group): New.
5634         (frame_apply_command_count): Process options with
5635         gdb::option::process_options.
5636         (frame_apply_completer): New.
5637         (frame_apply_level_completer, frame_apply_all_completer)
5638         (frame_apply_completer): New.
5639         (_initialize_stack): Update help of "frame apply", "frame apply
5640         level", "frame apply all" and "faas" to mention supported options
5641         and install command completers.
5642         * stack.h (frame_apply_all_completer): Declare.
5643         * thread.c: Include "stack.h".
5644         (tfaas_command): Add "--".
5645         (_initialize_thread): Update help "tfaas" to mention supported
5646         options and install command completer.
5647
5648 2019-06-13  Pedro Alves  <palves@redhat.com>
5649
5650         * completer.c (complete_nested_command_line): New.
5651         (gdb_completion_word_break_characters_throw): Add assertion.
5652         * completer.h (complete_nested_command_line): Declare.
5653
5654 2019-06-13  Pedro Alves  <palves@redhat.com>
5655
5656         * stack.c (parse_backtrace_qualifiers): New.
5657         (backtrace_command): Use it.
5658         (backtrace_command_completer): Complete on qualifiers.
5659
5660 2019-06-13  Pedro Alves  <palves@redhat.com>
5661
5662         * frame.c: Include "cli/cli-option.h.
5663         (user_set_backtrace_options): New.
5664         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5665         Delete.
5666         (get_prev_frame): Adjust.
5667         (boolean_option_def, uinteger_option_def)
5668         (set_backtrace_option_defs): New.
5669         (_initialize_frame): Adjust and use
5670         gdb::option::add_setshow_cmds_for_options to install "set
5671         backtrace past-main" and "set backtrace past-entry".
5672         * frame.h: Include "cli/cli-option.h".
5673         (struct frame_print_options): Forward declare.
5674         (print_frame_arguments_all, print_frame_arguments_scalars)
5675         (print_frame_arguments_none): Declare.
5676         (print_entry_values): Delete declaration.
5677         (struct frame_print_options, user_frame_print_options): New.
5678         (struct set_backtrace_options): New.
5679         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5680         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5681         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5682         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5683         (list_args_or_locals): Add frame_print_options parameter.
5684         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5685         * python/py-framefilter.c (enumerate_args): Pass down
5686         USER_FRAME_PRINT_OPTIONS.
5687         * stack.c: Include "cli/cli-option.h".
5688         (print_frame_arguments_all, print_frame_arguments_scalars)
5689         (print_frame_arguments_none): Declare.
5690         (print_raw_frame_arguments, print_entry_values): Delete.
5691         (user_frame_print_options): New.
5692         (boolean_option_def, enum_option_def, frame_print_option_defs):
5693         New.
5694         (struct backtrace_cmd_options): New.
5695         (bt_flag_option_def): New.
5696         (backtrace_command_option_defs): New.
5697         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5698         (print_frame_arg, read_frame_arg, print_frame_args)
5699         (print_frame_info, print_frame): Add frame_print_options parameter
5700         and use it.
5701         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5702         (backtrace_command_1): Add frame_print_options and
5703         backtrace_cmd_options parameters and use them.
5704         (make_backtrace_options_def_group): New.
5705         (backtrace_command): Process command options with
5706         gdb::option::process_options.
5707         (backtrace_command_completer): New.
5708         (_initialize_stack): Extend "backtrace"'s help to mention
5709         supported options.  Install completer for "backtrace".
5710         Install some settings commands with add_setshow_cmds_for_options.
5711
5712 2019-06-13  Pedro Alves  <palves@redhat.com>
5713
5714         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5715         and that "set/show print raw frame-arguments" are now deprecated.
5716
5717         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5718         command.
5719         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5720         * stack.c (_initialize_stack): Install "set/show print
5721         raw-frame-arguments", and deprecate "set/show print raw
5722         frame-arguments".
5723         * valprint.c (_initialize_valprint): Deprecate "set/show print
5724         raw".
5725
5726 2019-06-13  Pedro Alves  <palves@redhat.com>
5727
5728         * compile/compile.c (struct compile_options): New.
5729         (compile_flag_option_def, compile_command_option_defs)
5730         (make_compile_options_def_group): New.
5731         (compile_file_command): Handle options with
5732         gdb::option::process_options.
5733         (compile_file_command_completer): New function.
5734         (compile_code_command): Handle options with
5735         gdb::option::process_options.
5736         (compile_code_command_completer): New function.
5737         (_initialize_compiler): Install completers for "compile code" and
5738         "compile file".  Mention available options in "compile code" and
5739         "compile code"'s help.
5740         * completer.c (advance_to_completion_word): New, factored out from
5741         ...
5742         (advance_to_expression_complete_word_point): ... this.
5743         (advance_to_filename_complete_word_point): New.
5744         * completer.h (advance_to_filename_complete_word_point): New
5745         declaration.
5746
5747 2019-06-13  Pedro Alves  <palves@redhat.com>
5748
5749         * compile/compile.c: Include "cli/cli-option.h".
5750         (compile_print_value): Scope data pointer is now a
5751         value_print_options pointer; adjust.
5752         (compile_print_command): Process options.  Scope data pointer is
5753         now a value_print_options pointer; adjust.
5754         (_initialize_compile): Update "compile print"'s help to include
5755         supported options.  Install a completer for "compile print".
5756         * cp-valprint.c (show_vtblprint, show_objectprint)
5757         (show_static_field_print): Delete.
5758         (_initialize_cp_valprint): Don't install "set print
5759         static-members", "set print vtbl", "set print object" here.
5760         * printcmd.c: Include "cli/cli-option.h" and
5761         "common/gdb_optional.h".
5762         (print_command_parse_format): Rework to fill in a
5763         value_print_options instead of a format_data.
5764         (print_value): Change parameter type from format_data pointer to
5765         value_print_options reference.  Adjust.
5766         (print_command_1): Process options.  Adjust to pass down a
5767         value_print_options.
5768         (print_command_completer): New.
5769         (_initialize_printcmd): Install print_command_completer as
5770         handle_brkchars completer for the "print" command.  Update
5771         "print"'s help to include supported options.
5772         * valprint.c: Include "cli/cli-option.h".
5773         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5774         here from cp-valprint.c.
5775         (boolean_option_def, uinteger_option_def)
5776         (value_print_option_defs, make_value_print_options_def_group):
5777         New.  Use gdb::option::add_setshow_cmds_for_options to install
5778         "set print elements", "set print null-stop", "set print repeats",
5779         "set print pretty", "set print union", "set print array", "set
5780         print address", "set print symbol", "set print array-indexes".
5781         * valprint.h: Include <string> and "cli/cli-option.h".
5782         (make_value_print_options_def_group): Declare.
5783         (print_value): Change parameter type from format_data pointer to
5784         value_print_options reference.
5785         (print_command_completer): Declare.
5786
5787 2019-06-13  Pedro Alves  <palves@redhat.com>
5788
5789         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5790         (COMMON_SFILES): Add maint-test-settings.c.
5791         * cli/cli-decode.c (boolean_enums): New global, factored out from
5792         ...
5793         (add_setshow_boolean_cmd): ... here.
5794         * cli/cli-decode.h (boolean_enums): Declare.
5795         * cli/cli-option.c: New file.
5796         * cli/cli-option.h: New file.
5797         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5798         factored out from ...
5799         (parse_cli_boolean_value(const char *)): ... this.
5800         (is_unlimited_literal): Change parameter type to pointer to
5801         pointer.  Adjust and advance ARG pointer.
5802         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5803         (parse_cli_var_enum): New, factored out from ...
5804         (do_set_command): ... this.  Adjust.
5805         * cli/cli-setshow.h (parse_cli_boolean_value)
5806         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5807         (parse_cli_var_enum): Declare.
5808         * cli/cli-utils.c: Include "cli/cli-option.h".
5809         (get_ulongest): New.
5810         * cli/cli-utils.h (get_ulongest): Declare.
5811         (check_for_argument): New overloads.
5812         * maint-test-options.c: New file.
5813
5814 2019-06-13  Pedro Alves  <palves@redhat.com>
5815
5816         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5817         parse a range if "-" is at the end of the string.
5818
5819 2019-06-13  Pedro Alves  <palves@redhat.com>
5820
5821         * cli/cli-setshow.c (parse_auto_binary_operation)
5822         (parse_cli_boolean_value): Don't allow "o".
5823
5824 2019-06-13  Pedro Alves  <palves@redhat.com>
5825
5826         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5827         * NEWS: Mention maint test-settings KIND.
5828         * maint-test-settings.c: New file.
5829
5830 2019-06-13  Pedro Alves  <palves@redhat.com>
5831
5832         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5833         completer.
5834         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5835         "set" completers.
5836
5837 2019-06-13  Pedro Alves  <palves@redhat.com>
5838
5839         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5840         after item.
5841
5842 2019-06-13  Pedro Alves  <palves@redhat.com>
5843
5844         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5845
5846 2019-06-13  Pedro Alves <palves@redhat.com>
5847
5848         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5849         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5850         call.
5851         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5852         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5853         calls.
5854         (check_for_argument): Skip spaces after argument.
5855
5856 2019-06-13  Pedro Alves  <palves@redhat.com>
5857
5858         * thread.c (thread_apply_command): Adjust TID parsing.
5859         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5860         detected before end of string.
5861         (tid_is_in_list): Error out if LIST is invalid.
5862
5863 2019-06-13  Pedro Alves  <palves@redhat.com>
5864
5865         * completer.c (complete_line_internal_1): Rewind completion word
5866         point.
5867         (completion_tracker::advance_custom_word_point_by): Change
5868         parameter type to int.
5869         * completer.h (completion_tracker::advance_custom_word_point_by):
5870         Likewise.
5871
5872 2019-06-13  Pedro Alves  <palves@redhat.com>
5873
5874         * completer.c (advance_to_completion_word): Handle delimiters.
5875
5876 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5877
5878         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5879
5880 2019-06-11  Tom Tromey  <tom@tromey.com>
5881
5882         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5883         (xmalloc_failed): Move to alloc.c.
5884         * alloc.c: New file.
5885         * Makefile.in (COMMON_SFILES): Add alloc.c.
5886
5887 2019-06-11  Tom Tromey  <tom@tromey.com>
5888
5889         * nat/linux-waitpid.c: Don't include server.h.
5890         (linux_debug): Remove.
5891         (my_waitpid): Update.
5892
5893 2019-06-11  Tom Tromey  <tromey@adacore.com>
5894
5895         * infcall.c (_initialize_infcall): Remove trailing newline from
5896         help.
5897         * user-regs.c (_initialize_user_regs): Remove trailing newline
5898         from help.
5899         * typeprint.c (_initialize_typeprint): Remove trailing newline
5900         from help.
5901         * reverse.c (_initialize_reverse): Remove trailing newlines from
5902         help.
5903         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5904         from help.
5905         * language.c (add_set_language_command): Remove trailing newline
5906         from help.
5907         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5908         help.
5909         * disasm.c (_initialize_disasm): Remove trailing newline from
5910         help.
5911         * top.c (init_main): Remove trailing newline from help.
5912         * interps.c (_initialize_interpreter): Remove trailing newline
5913         from help.
5914         * btrace.c (_initialize_btrace): Remove trailing newlines from
5915         help.
5916         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5917         from help.
5918         * python/python.c (_initialize_python): Remove trailing newline
5919         from help.
5920         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5921         help.
5922         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5923         from help.  Reformat some text.
5924         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5925         from help.
5926         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5927         newline from help.
5928
5929 2019-06-11  Tom Tromey  <tromey@adacore.com>
5930
5931         * darwin-nat.c (darwin_decode_exception_message)
5932         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5933
5934 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * valops.c (value_slice): Check for not allocated or not
5937         associated values.
5938
5939 2019-06-10  Tom de Vries  <tdevries@suse.de>
5940
5941         PR gdb/24618
5942         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5943         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5944         invalid.
5945
5946 2019-06-10  Tom de Vries  <tdevries@suse.de>
5947
5948         PR gdb/24611
5949         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5950         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5951
5952 2019-06-10  Tom de Vries  <tdevries@suse.de>
5953
5954         PR symtab/24545
5955         * symtab.c (struct demangled_name_entry): Add language field.
5956         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5957         static minimal symbol".  Set and use language field.
5958
5959 2019-06-10  Tom Tromey  <tromey@adacore.com>
5960
5961         * ada-lang.c (_initialize_ada_language): Update help text.
5962
5963 2019-06-10  Tom Tromey  <tromey@adacore.com>
5964
5965         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5966         with a newline.
5967         * guile/guile.c (handle_boot_error): Don't end warning with a
5968         newline.
5969         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5970         warning with a newline.
5971         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5972         newline.
5973         (s12z_frame_cache): Likewise.
5974         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5975         a newline.
5976         * solib-svr4.c (disable_probes_interface): Don't end warning with
5977         a newline.
5978         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5979         newline.
5980         * python/python.c (do_finish_initialization): Don't end warning
5981         with a newline.
5982
5983 2019-06-10  Tom Tromey  <tom@tromey.com>
5984
5985         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5986         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5987         gdbpy_enter.
5988
5989 2019-06-10  Tom Tromey  <tromey@adacore.com>
5990
5991         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5992         data.
5993         (elf_new_init): Don't call stabsread_new_init.
5994         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5995         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5996         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5997
5998 2019-06-10  Tom de Vries  <tdevries@suse.de>
5999
6000         PR symtab/16264
6001         PR symtab/24517
6002         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6003
6004 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6005
6006         * source.c (find_and_open_source): Also rewrite relative file
6007         names.
6008
6009 2019-04-26  Amos Bird  <amosbird@gmail.com>
6010
6011         * annotate.c (annotate_thread_exited): Add "thread-exited"
6012         annotation.
6013
6014 2019-06-06  Tom Tromey  <tromey@adacore.com>
6015
6016         * maint.h (class scoped_command_stats): Use
6017         DISABLE_COPY_AND_ASSIGN.
6018         <print_time>: New method.
6019         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6020         print_time.
6021         (scoped_command_stats::print_time): New method.
6022
6023 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6024
6025         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6026         instructions of lengths 6 or 8 bytes.
6027
6028 2019-06-04  Pedro Alves  <palves@redhat.com>
6029
6030         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6031
6032         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6033         * breakpoint.c (condition_completer): Likewise.
6034         * cli/cli-dump.c (scan_expression): Likewise.
6035         * common/filestuff.c (mkdir_recursive): Likewise.
6036         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6037         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6038         (gdb_abspath): Likewise.
6039         * compile/compile-cplus-types.c
6040         (compile_cplus_instance::decl_name): Likewise.
6041         * completer.c (complete_explicit_location):
6042         (signal_completer, reg_or_group_completer_1): Likewise.
6043         * cp-support.c (cp_remove_params_if_any): Likewise.
6044         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6045         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6046         * infcmd.c (strip_bg_char): Likewise.
6047         * linespec.c (copy_token_string): Likewise.
6048         * mi/mi-main.c (output_cores): Likewise.
6049         * psymtab.c (psymtab_search_name):
6050         * symfile.c (test_set_ext_lang_command): Likewise.
6051         * target.c (target_fileio_read_stralloc): Likewise.
6052         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6053         * value.c (complete_internalvar): Likewise.
6054
6055 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6056
6057         Add objfile property to gdb.Type.
6058         * NEWS: Mention Python API addition.
6059         * python/py-type.c (typy_get_objfile): New method.
6060
6061 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6062
6063         * NEWS: Mention the new set|show style [title|highlight].
6064         Mention changes to "show style", "help" and "apropos".
6065
6066 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6067
6068         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6069         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6070         instead of print_help_for_command.
6071         (print_doc_of_command): New function.
6072         (help_list): Add 'apropos -v word' suggestion.
6073         (print_help_for_command): Style the command name using title style.
6074         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6075         (_initialize_cli_cmds): Describe -v in apropos_command help.
6076
6077 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6078
6079         * cli/cli-style.h (cli_style_option): Add name in constructor,
6080         add m_name class member, add constructor with intensity,
6081         add name class function.
6082         (cli_style_option::add_setshow_commands): Remove name argument.
6083         (highlight_style, title_style): New styles.
6084         * cli/cli-style.c (do_show): New function that shows a style
6085         characteristic styling the style name with itself.
6086         (set_style_name): New function.
6087         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6088         Update all callers according to the changes in cli/cli-style.h.
6089         * utils.h (fputs_highlighted): New function.
6090         * utils.c (fputs_highlighted): Likewise.
6091
6092 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6093
6094         * NEWS: Mention new pipe command and new convenience variables.
6095
6096 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6097
6098         * cli/cli-cmds.c (pipe_command): New function.
6099         (_initialize_cli_cmds): Call add_com for pipe_command.
6100         Define | as an alias for pipe.
6101         (exit_status_set_internal_vars): New function.
6102         (shell_escape): Call exit_status_set_internal_vars.
6103         cli/cli-decode.c (find_command_name_length): Recognize | as
6104         a single character command.
6105
6106 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6107
6108         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6109         top.c (execute_command_to_ui_file): New function, mostly a copy
6110         of execute_command_to_string.
6111         (execute_command_to_string): Implement by calling
6112         execute_command_to_ui_file.
6113
6114 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6115
6116         * top.h (saved_command_line): Remove declaration.
6117         * top.c (previous_saved_command_line, previous_repeat_arguments):
6118         New variables.
6119         (saved_command_line): Make static, define together with other
6120         'repeat variables'.
6121         (dont_repeat): Clear repeat_arguments.
6122         (repeat_previous, get_saved_command_line, save_command_line):
6123         New functions.
6124         (gdb_init): Initialize saved_command_line
6125         and previous_saved_command_line.
6126         * main.c (captured_main_1): Remove saved_command_line initialization.
6127         * event-top.c (handle_line_of_input): Update to use
6128         the new 'repeat' related functions instead of direct access to
6129         saved_command_line.
6130         * command.h (repeat_previous, get_saved_command_line,
6131         save_command_line): New declarations.
6132         (dont_repeat): Add comment.
6133
6134 2019-05-30  Tom Tromey  <tromey@adacore.com>
6135
6136         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6137         Fix comment.
6138         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6139
6140 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6141
6142         PR cli/24587
6143         * completer.c (complete): Initialize variable word.
6144
6145 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6146
6147         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6148         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6149         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6150         'body' is NULL to the outter 'if', protecting the '!is_define'
6151         situation as well.
6152
6153 2019-05-29  Tom Tromey  <tromey@adacore.com>
6154
6155         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6156         (dwarf_unknown): New function.
6157         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6158         (dwarf_type_encoding_name): Use dwarf_unknown.
6159
6160 2019-05-29  Tom Tromey  <tromey@adacore.com>
6161
6162         PR c++/20020:
6163         * cp-valprint.c (cp_print_value_fields): Call
6164         cp_print_static_field inside "try".
6165
6166 2019-05-29  Tom Tromey  <tromey@adacore.com>
6167
6168         * inflow.c (struct terminal_info): Add default operator=.
6169         * configure: Rebuild.
6170         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6171         -Wdeprecated-copy-dtor, -Wredundant-move.
6172
6173 2019-05-29  Tom Tromey  <tromey@adacore.com>
6174
6175         * NEWS: Add entry.
6176         * infcmd.c (print_return_value_1): Handle finish_print
6177         option.
6178         (show_print_finish): New function.
6179         (_initialize_infcmd): Add "set/show print finish" commands.
6180         * valprint.c (user_print_options): Initialize new member.
6181         * valprint.h (struct value_print_options) <finish_print>: New
6182         member.
6183
6184 2019-05-28  Tom Tromey  <tromey@adacore.com>
6185
6186         * ada-lang.c (ada_remove_Xbn_suffix)
6187         (find_old_style_renaming_symbol)
6188         (parse_old_style_renaming): Remove.
6189         (ada_find_renaming_symbol): Don't call
6190         find_old_style_renaming_symbol.
6191         (ada_is_renaming_symbol): Rename from
6192         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6193         bool.  Now static.
6194         (ada_read_var_value): Update and simplify.
6195         * ada-exp.y (write_var_or_type): Remove old code.
6196
6197 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6198
6199         * event-top.c: Remove include comment.
6200         * inflow.c (class scoped_ignore_sigttou): Move from here...
6201         * inflow.h (class scoped_ignore_sigttou): ...to here.
6202         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6203         * top.c:  Remove include comment.
6204
6205 2019-05-27  Tom Tromey  <tom@tromey.com>
6206
6207         * NEWS: Fix typo.
6208
6209 2019-05-22  Tom Tromey  <tromey@adacore.com>
6210
6211         * target.c (target_follow_exec): Constify parameter.
6212         * target-delegates.c: Rebuild.
6213         * remote.c (remote_target::follow_exec): Constify parameter.
6214         * infrun.c (follow_exec): Constify parameter.
6215         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6216         (target_follow_exec): Likewise.
6217
6218 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6219
6220         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6221         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6222
6223 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6224
6225         * NEWS: Add debugredirect and testsuite sections.
6226
6227 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6228
6229         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6230         target descriptions using exclusively floating point register name
6231         aliases.
6232
6233 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         PR gdb/18644:
6236         * f-lang.c (build_fortran_types): Handle the case where
6237         gdbarch_floatformat_for_type returns a nullptr.
6238
6239 2019-05-21  Tom de Vries  <tdevries@suse.de>
6240
6241         PR cli/24587
6242         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6243
6244 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         PR gdb/18644:
6247         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6248         16-byte floats.
6249         * i386-tdep.c (i386_floatformat_for_type): Use
6250         floatformats_ia64_quad for the 16-byte floating point component
6251         within a fortran 32-byte complex number.
6252
6253 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6256         delete default constructor.
6257         (find_partial_die): Update to return const struct.
6258         (partial_die_parent_scope): Move variable declaration into scope
6259         of its use and change its type to auto.
6260         (guess_partial_die_structure_name): Likewise.
6261         (partial_die_info::fixup): Likewise.
6262
6263 2019-05-17  Tom Tromey  <tromey@adacore.com>
6264
6265         * source.c (find_and_open_source): Remove cast.
6266
6267 2019-05-17  Tom Tromey  <tromey@adacore.com>
6268
6269         * annotate.c (annotate_source): Make "filename" const.
6270         * annotate.h (annotate_source): Use const.
6271
6272 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6273
6274         * disasm.c (set_disassembler_options): Send errors to stderr.
6275
6276 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6277
6278         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6279         (cli_interp_base::set_logging): Check debug_redirect.
6280         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6281         * cli/cli-logging.c (debug_redirect): Add static variable.
6282         (pop_output_files): Add default param.
6283         (handle_redirections): Print debug setting.
6284         (show_logging_command): Likewise.
6285         (_initialize_cli_logging): Add debugredirect command.
6286         * interps.c (current_interp_set_logging): Add debug_redirect
6287         parameter.
6288         * interps.h (set_logging): Add debug_redirect parameter.
6289         (current_interp_set_logging): Likewise.
6290         * mi/mi-common.h: Likewise.
6291         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6292
6293 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6294             Tom Tromey  <tromey@adacore.com>
6295
6296         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6297         directly.
6298         * cli/cli-interp.h (make_logging_output): Remove declaration.
6299         * cli/cli-logging.c (make_logging_output): Remove function.
6300         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6301         directly.
6302         * ui-file.c (tee_file::tee_file): Remove bools.
6303         (tee_file::~tee_file): Remove deletes.
6304         * ui-file.h (tee_file): Remove bools.
6305
6306 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6307
6308         * mi/mi-cmds.h (mi_cmd_complete): New function.
6309         * mi/mi-main.c (mi_cmd_complete): Likewise.
6310         * mi/mi-cmds.c: Define new MI command -complete.
6311         * NEWS: Mention new -complete command.
6312
6313 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6314
6315         * completer.h (complete): New function.
6316         * completer.c (complete): Likewise.
6317         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6318         function defined in completer.h.
6319
6320 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6321
6322         * MAINTAINERS (Write After Approval): Add myself.
6323
6324 2019-05-17  Tom de Vries  <tdevries@suse.de>
6325
6326         PR gdb/24094
6327         * dwarf2read.c (struct cu_partial_die_info): New struct.
6328         (find_partial_die): Return cu_partial_die_info.
6329         (partial_die_parent_scope, guess_partial_die_structure_name)
6330         (partial_die_info::fixup): Handle new return type of find_partial_die.
6331
6332 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6333
6334         PR breakpoints/24541
6335         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6336         "std::string", simplifying the algorithm.
6337
6338 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6339
6340         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6341         (stap_static_probe_ops::get_probes): Likewise.
6342
6343 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6344
6345         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6346         '-')" and "else if".
6347         (stap_parse_single_operand): Join checks for
6348         "gdbarch_stap_parse_special_token_p" and
6349         "gdbarch_stap_parse_special_token" in the same "if" statement.
6350         Invert check when verifying for operation on register
6351         displacement.
6352
6353 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6354
6355         * stap-probe.c (stap_get_opcode): Update comment.
6356         (stap_get_expected_argument_type): Likewise.
6357         (handle_stap_probe): Likewise.
6358
6359 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6360
6361         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6362         return type to 'bool'.  Adjust comment.  Use 'bool' when
6363         appropriate.
6364         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6365         * stap-probe.c (stap_parse_argument_1): Likewise.
6366         (stap_is_operator): Likewise.
6367         (stap_is_generic_prefix): Likewise.
6368         (stap_is_register_prefix): Likewise.
6369         (stap_is_register_indirection_prefix): Likewise.
6370         (stap_is_integer_prefix): Likewise.
6371         (stap_generic_check_suffix): Likewise.
6372         (stap_check_integer_suffix): Likewise.
6373         (stap_check_register_suffix): Likewise.
6374         (stap_check_register_indirection_suffix): Likewise.
6375         (stap_parse_register_operand): Likewise.
6376         (stap_parse_single_operand): Likewise.
6377         (stap_parse_argument_1): Likewise.
6378         (stap_probe::get_argument_count): Likewise.
6379         (stap_is_operator): Likewise.
6380
6381 2019-05-16  Tom Tromey  <tromey@adacore.com>
6382
6383         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6384         keyword to foreach.
6385
6386 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6387
6388         * linux-thread-db.c (try_thread_db_load_1): Change return type
6389         to bool.
6390         (try_thread_db_load): Likewise.
6391         (try_thread_db_load_from_pdir_1): Likewise.
6392         (try_thread_db_load_from_pdir): Likewise.
6393         (try_thread_db_load_from_sdir): Likewise.
6394         (try_thread_db_load_from_dir): Likewise.
6395         (thread_db_load_search): Likewise.
6396         (has_libpthread): Likewise.
6397         (thread_db_load): Likewise.
6398
6399 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6400
6401         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6402         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6403         NULL, and complain/return if that's the case.
6404
6405 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6406
6407         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6408         (advance, posn, abstract_read_memory): New functions.
6409         [struct mem_read_abstraction]: New struct.
6410         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6411
6412 2019-05-14  Tom Tromey  <tromey@adacore.com>
6413
6414         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6415         value is not lval_memory.
6416
6417 2019-05-14  Tom Tromey  <tromey@adacore.com>
6418
6419         * solib.c (info_sharedlibrary_command): Style the file name.
6420
6421 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6422
6423         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6424         (aarch64_vnv_type): Likewise.
6425         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6426         * common/tdesc.c: Likewise.
6427         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6428         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6429         * features/aarch64-fpu.xml: Add ieee half view.
6430         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6431         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6432         * gdbtypes.h (struct builtin_type): Likewise.
6433         (struct objfile_type): Likewise.
6434
6435 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6436
6437         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6438         typo.
6439         * location.h (string_to_event_location): Likewise.
6440
6441 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6442
6443         GDB 8.3 released.
6444
6445 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6446
6447         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6448         New variable declaration.
6449         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6450         New variable.
6451         (print_one_breakpoint): Use ui_out::test_flags and new global
6452         variable to compute use_fixed_output.
6453         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6454         Remove.
6455         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6456         (mi_multi_location_breakpoint_output_fixed): Remove.
6457         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6458         new variable.
6459         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6460         fix_multi_location_breakpoint_output flag if version >= 3.
6461         * ui-out.h (enum ui_out_flag)
6462         <fix_multi_location_breakpoint_output>: New enumerator.
6463
6464 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6465
6466         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6467
6468 2019-05-10  Tom Tromey  <tromey@adacore.com>
6469
6470         * ada-lang.c (catch_ada_completer): New function.
6471         (_initialize_ada_language): Use it.
6472
6473 2019-05-10  Tom Tromey  <tromey@adacore.com>
6474
6475         * thread.c (print_thread_info): Make "requested_threads" const.
6476         * gdbthread.h (print_thread_info): Make "requested_threads"
6477         const.
6478         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6479         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6480
6481 2019-05-08  Tom Tromey  <tom@tromey.com>
6482
6483         * gdbtypes.c (objfile_type_data): Change type.
6484         (objfile_type, _initialize_gdbtypes): Update.
6485
6486 2019-05-08  Tom Tromey  <tom@tromey.com>
6487
6488         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6489         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6490         (_initialize_dwarf2_frame): Update.
6491
6492 2019-05-08  Tom Tromey  <tom@tromey.com>
6493
6494         * objc-lang.c (objc_objfile_data): Change type.
6495         (find_methods): Update.
6496         (_initialize_objc_lang): Remove.
6497
6498 2019-05-08  Tom Tromey  <tom@tromey.com>
6499
6500         * stabsread.c (rs6000_builtin_type_data): Change type.
6501         (rs6000_builtin_type, _initialize_stabsread): Update.
6502
6503 2019-05-08  Tom Tromey  <tom@tromey.com>
6504
6505         * mips-tdep.c (mips_pdr_data): Remove.
6506         (_initialize_mips_tdep): Update.
6507
6508 2019-05-08  Tom Tromey  <tom@tromey.com>
6509
6510         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6511         (hppa_init_objfile_priv_data, read_unwind_info)
6512         (find_unwind_entry, _initialize_hppa_tdep): Update.
6513
6514 2019-05-08  Tom Tromey  <tom@tromey.com>
6515
6516         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6517         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6518         on obstack.
6519         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6520
6521 2019-05-08  Tom Tromey  <tom@tromey.com>
6522
6523         * mdebugread.c (basic_type_data): Change type.
6524         (basic_type, _initialize_mdebugread): Update.
6525
6526 2019-05-08  Tom Tromey  <tom@tromey.com>
6527
6528         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6529
6530 2019-05-08  Tom Tromey  <tom@tromey.com>
6531
6532         * nto-tdep.c (nto_inferior_data_reg): Change type.
6533         (nto_inferior_data): Update.
6534         (nto_inferior_data_cleanup, nto_new_inferior_data)
6535         (_initialize_nto_tdep): Remove.
6536         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6537
6538 2019-05-08  Tom Tromey  <tom@tromey.com>
6539
6540         * ada-lang.c (struct ada_inferior_data): Add initializers.
6541         (ada_inferior_data): Change type.
6542         (ada_inferior_data_cleanup): Remove.
6543         (get_ada_inferior_data, ada_inferior_exit)
6544         (struct ada_pspace_data): Add initializers, destructor.
6545         (ada_pspace_data_handle): Change type.
6546         (get_ada_pspace_data): Update.
6547         (ada_pspace_data_cleanup): Remove.
6548
6549 2019-05-08  Tom Tromey  <tom@tromey.com>
6550
6551         * coffread.c (struct coff_symfile_info): Add initializers.
6552         (coff_objfile_data_key): Move lower.  Change type.
6553         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6554         Update.
6555         (coff_free_info): Remove.
6556
6557 2019-05-08  Tom Tromey  <tom@tromey.com>
6558
6559         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6560         (fbsd_pspace_data_handle): Move lower.  Change type.
6561         (get_fbsd_pspace_data): Update.
6562         (fbsd_pspace_data_cleanup): Remove.
6563         (_initialize_fbsd_tdep): Update.
6564
6565 2019-05-08  Tom Tromey  <tom@tromey.com>
6566
6567         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6568         (get_ada_tasks_pspace_data): Update.
6569         (ada_tasks_pspace_data_cleanup): Remove.
6570         (_initialize_tasks): Update.
6571         (ada_tasks_inferior_data_handle): Change type.
6572         (get_ada_tasks_inferior_data): Update.
6573         (ada_tasks_inferior_data_cleanup): Remove.
6574         (struct ada_tasks_pspace_data): Add initializers.
6575
6576 2019-05-08  Tom Tromey  <tom@tromey.com>
6577
6578         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6579         * symfile-debug.c (debug_sym_get_probes): Change type.
6580         * stap-probe.c (handle_stap_probe):
6581         (stap_static_probe_ops::get_probes): Change type.
6582         * probe.h (class static_probe_ops) <get_probes>: Change type.
6583         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6584         (parse_probes_in_pspace): Update.
6585         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6586         Update.
6587         (any_static_probe_ops::get_probes): Change type.
6588         * elfread.c (elfread_data): New typedef.
6589         (probe_key): Change type.
6590         (elf_get_probes): Likewise.  Update.
6591         (probe_key_free): Remove.
6592         (_initialize_elfread): Update.
6593         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6594         Change type.
6595         (dtrace_process_dof_probe, dtrace_process_dof)
6596         (dtrace_static_probe_ops::get_probe): Change type.
6597
6598 2019-05-08  Tom Tromey  <tom@tromey.com>
6599
6600         * xcoffread.c (struct xcoff_symfile_info): Rename from
6601         coff_symfile_info.  Add initializers.
6602         (xcoff_objfile_data_key): Move lower.  Change type.
6603         (XCOFF_DATA): Rewrite.
6604         (xcoff_free_info): Remove.
6605         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6606         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6607         (xcoff_initial_scan): Update.
6608
6609 2019-05-08  Tom Tromey  <tom@tromey.com>
6610
6611         * solib-svr4.c (struct svr4_info): Add initializers and
6612         destructor.
6613         <probes_table>: Now an htab_up.
6614         (solib_svr4_pspace_data): Change type.
6615         (free_probes_table): Simplify.
6616         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6617         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6618         (probes_table_remove_objfile_probes, register_solib_event_probe)
6619         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6620         (_initialize_svr4_solib): Update.
6621
6622 2019-05-08  Tom Tromey  <tom@tromey.com>
6623
6624         * remote.c (remote_pspace_data): Change type.
6625         (remote_pspace_data_cleanup): Remove.
6626         (get_remote_exec_file, set_pspace_remote_exec_file)
6627         (_initialize_remote): Update.
6628
6629 2019-05-08  Tom Tromey  <tom@tromey.com>
6630
6631         * breakpoint.c (breakpoint_objfile_key): Change type.
6632         (get_breakpoint_objfile_data): Update.
6633         (free_breakpoint_objfile_data): Remove.
6634         (_initialize_breakpoint): Update.
6635
6636 2019-05-08  Tom Tromey  <tom@tromey.com>
6637
6638         * linux-tdep.c (struct linux_info): Add initializers.
6639         (linux_inferior_data): Move.  Change type.
6640         (invalidate_linux_cache_inf): Update.
6641         (linux_inferior_data_cleanup): Remove.
6642         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6643
6644 2019-05-08  Tom Tromey  <tom@tromey.com>
6645
6646         * auxv.c (auxv_inferior_data): Move.  Change type.
6647         (auxv_inferior_data_cleanup): Remove.
6648         (invalidate_auxv_cache_inf): Rewrite.
6649         (get_auxv_inferior_data, _initialize_auxv): Update.
6650
6651 2019-05-08  Tom Tromey  <tom@tromey.com>
6652
6653         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6654         (symfile_debug_objfile_data_key): Change type.
6655         (symfile_debug_installed, debug_qf_has_symbols)
6656         (debug_qf_find_last_source_symtab)
6657         (debug_qf_forget_cached_source_info)
6658         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6659         (debug_qf_print_stats, debug_qf_dump)
6660         (debug_qf_expand_symtabs_for_function)
6661         (debug_qf_expand_all_symtabs)
6662         (debug_qf_expand_symtabs_with_fullname)
6663         (debug_qf_map_matching_symbols)
6664         (debug_qf_expand_symtabs_matching)
6665         (debug_qf_find_pc_sect_compunit_symtab)
6666         (debug_qf_map_symbol_filenames)
6667         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6668         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6669         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6670         (debug_sym_read_linetable, debug_sym_relocate): Update.
6671         (symfile_debug_free_objfile): Remove.
6672         (install_symfile_debug_logging, _initialize_symfile_debug):
6673         Update.
6674
6675 2019-05-08  Tom Tromey  <tom@tromey.com>
6676
6677         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6678         allocate_on_obstack.
6679         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6680         (get_dwarf2_per_objfile): Update.
6681         (set_dwarf2_per_objfile): Remove.
6682         (dwarf2_has_info, dwarf2_get_section_info): Update.
6683         (dwarf2_free_objfile): Remove.
6684         (_initialize_dwarf2_read): Update.
6685
6686 2019-05-08  Tom Tromey  <tom@tromey.com>
6687
6688         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6689         initializers.
6690         <unsupported_script_warning_printed,
6691         script_not_found_warning_printed>: Now bool.
6692         (auto_load_pspace_data): Change type.
6693         (~auto_load_pspace_info): Rename from
6694         auto_load_pspace_data_cleanup.
6695         (get_auto_load_pspace_data, init_loaded_scripts_info)
6696         (clear_section_scripts, maybe_print_unsupported_script_warning)
6697         (maybe_print_script_not_found_warning, _initialize_auto_load):
6698         Update.
6699
6700 2019-05-08  Tom Tromey  <tom@tromey.com>
6701
6702         * objfiles.c (objfile_pspace_info): Add destructor and
6703         initializers.
6704         (objfiles_pspace_data): Change type.
6705         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6706         (get_objfile_pspace_data): Update.
6707         (objfiles_bfd_data): Change type.
6708         (get_objfile_bfd_data): Update.
6709         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6710
6711 2019-05-08  Tom Tromey  <tom@tromey.com>
6712
6713         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6714         Change type.
6715         (get_catch_syscall_inferior_data): Update.
6716         (catch_syscall_inferior_data_cleanup): Remove.
6717         (_initialize_break_catch_syscall): Update.
6718
6719 2019-05-08  Tom Tromey  <tom@tromey.com>
6720
6721         * inflow.c (struct terminal_info): Add destructor and
6722         initializers.
6723         (inflow_inferior_data): Change type.
6724         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6725         (get_inflow_inferior_data, inflow_inferior_exit)
6726         (swap_terminal_info, _initialize_inflow): Update.
6727
6728 2019-05-08  Tom Tromey  <tom@tromey.com>
6729
6730         * target-dcache.c (target_dcache_cleanup): Remove.
6731         (target_dcache_aspace_key): Change type.
6732         (target_dcache_init_p, target_dcache_invalidate)
6733         (target_dcache_get, target_dcache_get_or_init)
6734         (_initialize_target_dcache): Update.
6735         * dcache.h (struct dcache_deleter): New.
6736
6737 2019-05-08  Tom Tromey  <tom@tromey.com>
6738
6739         * symtab.c (struct symbol_cache): Add destructor and
6740         initializers.
6741         (symbol_cache_key): Move.  Change type.
6742         (make_symbol_cache, free_symbol_cache): Remove.
6743         (get_symbol_cache): Update.
6744         (symbol_cache_cleanup): Remove.
6745         (ALL_PSPACES, symbol_cache_flush)
6746         (maintenance_print_symbol_cache)
6747         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6748         Update.
6749
6750 2019-05-08  Tom Tromey  <tom@tromey.com>
6751
6752         * symtab.c (struct main_info): Add destructor and initializers.
6753         (main_progspace_key): Move.  Change type.
6754         (get_main_info): Update.
6755         (main_info_cleanup): Remove.
6756         (_initialize_symtab): Update.
6757
6758 2019-05-08  Tom Tromey  <tom@tromey.com>
6759
6760         * registry.h (DECLARE_REGISTRY): Define the _key class.
6761
6762 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * NEWS: Merge two 'New commands' sections.
6765
6766 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6767
6768         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6769         parameter and use Ada language definition instead.
6770         (ada_val_print_ptr): Remove unused language parameter.
6771         (ada_val_print_num): Remove language parameter and use Ada language
6772         definition instead.
6773         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6774         parameter.
6775         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6776         parameter and use Ada language definition instead.
6777         (ada_val_print_1): Update all ada_val_print_xxx calls.
6778         Remove language parameter.
6779         (ada_val_print): Update ada_val_print_1 call.
6780
6781 2019-05-08  Tom Tromey  <tromey@adacore.com>
6782
6783         * remote.c (remote_hw_watchpoint_limit)
6784         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6785         Now static.
6786
6787 2019-05-08  Tom Tromey  <tromey@adacore.com>
6788
6789         * maint.c (_initialize_maint_cmds): Move initialization code to
6790         remote.c.
6791         (watchdog, show_watchdog): Move to remote.c.
6792         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6793         "watchdog" static.
6794         (_initialize_remote): Move initialization code from maint.c.
6795         * defs.h (watchdog): Don't declare.
6796
6797 2019-05-08  Tom Tromey  <tromey@adacore.com>
6798
6799         * tui/tui-interp.c: Include main.h.
6800         * interps.c: Include main.h.
6801         * main.h (interpreter_p): Declare.
6802         * defs.h (interpreter_p): Don't declare.
6803
6804 2019-05-08  Tom Tromey  <tromey@adacore.com>
6805
6806         * dwarf2loc.c: Include dwarf2read.h.
6807         * defs.h (read_unsigned_leb128): Don't declare.
6808         * dwarf2read.h (read_unsigned_leb128): Declare.
6809
6810 2019-05-08  Tom Tromey  <tromey@adacore.com>
6811
6812         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6813         method.
6814
6815 2019-05-08  Tom Tromey  <tromey@adacore.com>
6816
6817         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6818         when no wrap column is set.
6819
6820 2019-05-08  Tom Tromey  <tromey@adacore.com>
6821
6822         * c-lang.c (c_get_string): Handle non-C-style arrays.
6823
6824 2019-05-08  Tom Tromey  <tromey@adacore.com>
6825
6826         * typeprint.c (print_offset_data::update): Print the bit offset,
6827         not the number of bits remaining.
6828
6829 2019-05-08  Tom Tromey  <tromey@adacore.com>
6830
6831         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6832         padding at end of comment.
6833
6834 2019-05-08  Tom Tromey  <tromey@adacore.com>
6835
6836         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6837         Compare main types.
6838
6839 2019-05-06  Tom Tromey  <tom@tromey.com>
6840
6841         * common/scoped_mmap.c: Include common-defs.h.
6842         * common/scoped_mmap.h: Don't include config.h.
6843
6844 2019-05-04  Tom Tromey  <tom@tromey.com>
6845
6846         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6847         (struct aarch64_call_info): Add initializers.
6848         <si>: Now a std::vector.
6849         (pass_on_stack, aarch64_push_dummy_call): Update.
6850
6851 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6852             Tom Tromey  <tom@tromey.com>
6853
6854         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6855         (ppc_threads): Now a std::vector.  Now static.
6856         (hwdebug_find_thread_points_by_tid)
6857         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6858         Update.
6859
6860 2019-05-04  Tom Tromey  <tom@tromey.com>
6861
6862         * arc-tdep.c (arc_tdesc_init): Return bool.
6863
6864 2019-05-04  Tom Tromey  <tom@tromey.com>
6865
6866         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6867         Use gdb_assert_not_reached.
6868
6869 2019-05-04  Tom Tromey  <tom@tromey.com>
6870
6871         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6872         "false".
6873
6874 2019-05-04  Tom Tromey  <tom@tromey.com>
6875
6876         * arc-tdep.c (arc_tdesc_init): Use bool.
6877
6878 2019-05-04  Tom Tromey  <tom@tromey.com>
6879
6880         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6881
6882 2019-05-04  Tom Tromey  <tom@tromey.com>
6883
6884         * cli/cli-cmds.c (valid_command_p): Return bool.
6885
6886 2019-05-04  Tom Tromey  <tom@tromey.com>
6887
6888         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6889         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6890
6891 2019-05-04  Raul Tambre  <raul@tambre.ee>
6892
6893         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6894         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6895         operator for comparison.
6896
6897 2019-05-04  Tom Tromey  <tom@tromey.com>
6898
6899         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6900         (lookup_partial_symbol, print_partial_symbols)
6901         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6902         (psymbol_compare): Update.
6903         (add_psymbol_to_bcache): Clear the entire psymbol.
6904         (maintenance_check_psymtabs): Update.
6905         * psympriv.h (struct partial_symbol): Don't derive from
6906         general_symbol_info.
6907         <obj_section, unrelocated_address, address,
6908         set_unrelocated_address>: Update.
6909         <ginfo>: New member.
6910         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6911         (debug_names::write_psymbols): Update.
6912
6913 2019-05-04  Tom de Vries  <tdevries@suse.de>
6914
6915         * contrib/cc-with-tweaks.sh: Support -n arg.
6916
6917 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6918
6919         * corelow.c (core_target::detach): Ensure frame cache and
6920         register caches are cleared.
6921         inferior.c (exit_inferior_1): Likewise.
6922
6923 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6924             Tom Tromey  <tom@tromey.com>
6925
6926         * dictionary.c (collate_pending_symbols_by_language): Remove
6927         "struct" from foreach.
6928         * symtab.c (lookup_global_symbol_from_objfile)
6929         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6930         foreach.
6931         * ser-tcp.c (net_open): Remove "struct" from foreach.
6932         * objfiles.c (objfile_relocate, objfile_rebase)
6933         (objfile_has_symbols): Remove "struct" from foreach.
6934         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6935         from foreach.
6936         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6937         foreach.
6938         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6939         "struct" from foreach.
6940         * ada-lang.c (create_excep_cond_exprs)
6941         (ada_exception_catchpoint_cond_string): Remove "struct" from
6942         foreach.
6943
6944 2019-05-03  Tom Tromey  <tromey@adacore.com>
6945
6946         * ada-exp.y (convert_char_literal): Check suffix of each
6947         enumerator.
6948
6949 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6950
6951         PR ada/21406:
6952         * ada-exp.y (yywrap): Don't define.
6953         * ada-lex.l (%option): Add noyywrap
6954         (yywrap): Remove.
6955
6956 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6957
6958         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6959         _WIN32_WINNT to the XP level, unless already defined to a higher
6960         level.
6961
6962         * unittests/parse-connection-spec-selftests.c:
6963         * ser-tcp.c:
6964         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6965         override.
6966
6967         * symfile.c (find_separate_debug_file): Remove colon from the
6968         drive spec of DOS/Windows file names of the target, so that the
6969         file name produced from DEBUGDIR and the target's directory will
6970         be valid on DOS/Windows systems.
6971
6972 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * rust-lang.c (val_print_struct): Handle printing structures
6975         containing strings.
6976
6977 2019-05-02  Tom Tromey  <tromey@adacore.com>
6978
6979         * valarith.c (_initialize_valarith): Remove.
6980
6981 2019-05-01  Tom Tromey  <tromey@adacore.com>
6982
6983         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6984         bitfields.
6985
6986 2019-05-01  Tom Tromey  <tromey@adacore.com>
6987
6988         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6989         for big-endian copies.
6990
6991 2019-04-30  Ali Tamur  <tamur@google.com>
6992         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6993         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6994         (read_3_bytes): New function.
6995
6996 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6997
6998         * windows-nat.c (main_thread_id): Delete.
6999         (handle_output_debug_string): Replace main_thread_id by
7000         current_event.dwThreadId.
7001         (fake_create_process): Likewise.
7002         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7003         Do not set main_thread_id.
7004         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7005         current_event.dwThreadId.
7006         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7007
7008 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7009
7010         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7011         Use current_event.dwThreadId instead of main_thread_id.
7012
7013 2019-04-30  Tom Tromey  <tromey@adacore.com>
7014
7015         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7016         (create_excep_cond_exprs): Iterate over program spaces.
7017         (ada_exception_catchpoint_cond_string): Examine all minimal
7018         symbols for exception types.
7019
7020 2019-04-30  Tom Tromey  <tromey@adacore.com>
7021
7022         PR c++/24470:
7023         * dwarf2read.c (process_structure_scope): Handle case where type
7024         has template parameters but no symbol was created.
7025
7026 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7027             Chris January  <chris.january@arm.com>
7028
7029         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7030         qualifier.
7031         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7032
7033 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7034
7035         * f-typeprint.c (f_print_type): Update rules for printing
7036         whitespace.
7037         (f_type_print_varspec_suffix): Likewise.
7038
7039 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7040             Chris January  <chris.january@arm.com>
7041
7042         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7043         function arguments.
7044
7045 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * f-lang.c (build_fortran_types): Change name of void type to
7048         lower case.
7049         * f-typeprint.c (f_type_print_base): Print the name of the void
7050         type, rather than a fixed string.
7051         * f-valprint.c (f_decorations): Use lower case void string.
7052
7053 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7054             Chris January  <chris.january@arm.com>
7055
7056         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7057         types for Fortran.
7058
7059 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7060             Chris January  <chris.january@arm.com>
7061             David Lecomber  <david.lecomber@arm.com>
7062
7063         * f-exp.y (BINOP_INTRINSIC): New token.
7064         (exp): New parser rule handling BINOP_INTRINSIC.
7065         (f77_keywords): Add new builtin procedures.
7066         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7067         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7068         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7069         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7070         (print_unop_subexp_f): New function.
7071         (print_binop_subexp_f): New function.
7072         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7073         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7074         (dump_subexp_body_f): Likewise.
7075         (operator_check_f): Likewise.
7076         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7077         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7078
7079 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7082         UNOP_KIND.
7083         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7084         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7085         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7086         (operator_length_f): New fuction.
7087         (print_subexp_f): New function.
7088         (op_name_f): New function.
7089         (dump_subexp_body_f): New function.
7090         (operator_check_f): New function.
7091         (exp_descriptor_f): Replace standard expression handling functions
7092         with new functions.
7093         * gdb/fortran-operator.def: New file.
7094         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7095         * gdb/std-operator.def: Remove UNOP_KIND.
7096
7097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7098
7099         * std-operator.def: Remove unbalanced, stray double quote
7100         character.
7101
7102 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7103             Chris January  <chris.january@arm.com>
7104             Daniel Everett  <daniel.everett@arm.com>
7105             Nick Forrington  <nick.forrington@arm.com>
7106             Richard Bunt  <richard.bunt@arm.com>
7107
7108         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7109         of depth when printing anonymous structs or unions.
7110         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7111         Don't print either the top-level value, or the children if the
7112         max-depth is exceeded.
7113         (ppscm_print_children): When printing the key of a map, allow one
7114         extra level of depth.
7115         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7116         print either the top-level value, or the children if the max-depth
7117         is exceeded.
7118         (print_children): When printing the key of a map, allow one extra
7119         level of depth.
7120         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7121         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7122         (user_print_options): Initialise max_depth field.
7123         (val_print_scalar_or_string_type_p): New function.
7124         (val_print): Check to see if the max depth has been reached.
7125         (val_print_check_max_depth): Define new function.
7126         (show_print_max_depth): New function.
7127         (_initialize_valprint): Add 'print max-depth' option.
7128         * valprint.h (struct value_print_options) <max_depth>: New field.
7129         (val_print_check_max_depth): Declare new function.
7130         * NEWS: Document new feature.
7131
7132 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7133
7134         * ada-lang.c (ada_language_defn): Initialise new field.
7135         * c-lang.c (c_is_string_type_p): New function.
7136         (c_language_defn): Initialise new field.
7137         (cplus_language_defn): Initialise new field.
7138         (asm_language_defn): Initialise new field.
7139         (minimal_language_defn): Initialise new field.
7140         * c-lang.h (c_is_string_type_p): Declare new function.
7141         * d-lang.c (d_language_defn): Initialise new field.
7142         * f-lang.c (f_is_string_type_p): New function.
7143         (f_language_defn): Initialise new field.
7144         * go-lang.c (go_is_string_type_p): New function.
7145         (go_language_defn): Initialise new field.
7146         * language.c (default_is_string_type_p): New function.
7147         (unknown_language_defn): Initialise new field.
7148         (auto_language_defn): Initialise new field.
7149         * language.h (struct language_defn) <la_is_string_type_p>: New
7150         member variable.
7151         (default_is_string_type_p): Declare new function.
7152         * m2-lang.c (m2_language_defn): Initialise new field.
7153         * objc-lang.c (objc_language_defn): Initialise new field.
7154         * opencl-lang.c (opencl_language_defn): Initialise new field.
7155         * p-lang.c (pascal_is_string_type_p): New function.
7156         (pascal_language_defn): Initialise new field.
7157         * rust-lang.c (rust_is_string_type_p): New function.
7158         (rust_language_defn): Initialise new field.
7159
7160 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7161
7162         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7163         New field.
7164         * ada-lang.c (ada_language_defn): Initialise new field.
7165         * c-lang.c (c_language_defn): Likewise.
7166         (cplus_language_defn): Likewise.
7167         (asm_language_defn): Likewise.
7168         (minimal_language_defn): Likewise.
7169         * d-lang.c (d_language_defn): Likewise.
7170         * f-lang.c (f_language_defn): Likewise.
7171         * go-lang.c (go_language_defn): Likewise.
7172         * language.c (unknown_language_defn): Likewise.
7173         (auto_language_defn): Likewise.
7174         * m2-lang.c (m2_language_defn): Likewise.
7175         * objc-lang.c (objc_language_defn): Likewise.
7176         * opencl-lang.c (opencl_language_defn): Likewise.
7177         * p-lang.c (pascal_language_defn): Likewise.
7178         * rust-lang.c (rust_language_defn): Likewise.
7179
7180 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7181
7182         * ada-lang.c (ada_is_character_type): Change return type to bool.
7183         (ada_is_string_type): Likewise.
7184         * ada-lang.h (ada_is_character_type): Update declaration
7185         (ada_is_string_type): Likewise.
7186
7187 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7188
7189         Support style in 'frame|thread apply'
7190
7191         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7192         * record.c (record_start, record_stop): Update callers of
7193         execute_command_to_string with false.
7194         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7195         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7196         methods.
7197         (class string_file): New constructor with term_out parameter.
7198         Override methods term_out and can_emit_style_escape.  New member
7199         term_out.
7200         (class stdio_file): Override can_emit_style_escape.
7201         (class tee_file): Override term_out and can_emit_style_escape.
7202         * utils.h (can_emit_style_escape): Remove.
7203         * utils.c (can_emit_style_escape): Likewise.
7204         Update all callers of can_emit_style_escape (SOMESTREAM) to
7205         SOMESTREAM->can_emit_style_escape.
7206         * source-cache.c (source_cache::get_source_lines): Likewise.
7207         * stack.c (frame_apply_command_count): Call execute_command_to_string
7208         passing the term_out characteristic of the current gdb_stdout.
7209         * thread.c (thr_try_catch_cmd): Likewise.
7210         * top.c (execute_command_to_string): pass term_out parameter
7211         to construct the string_file for the command output.
7212         * ui-file.c (term_cli_styling): New function (most code moved
7213         from utils.c can_emit_style_escape).
7214         (string_file::string_file, string_file::can_emit_style_escape,
7215         stdio_file::can_emit_style_escape, tee_file::term_out,
7216         tee_file::can_emit_style_escape): New functions.
7217
7218 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7219
7220         * NEWS: Mention the new set|show may-call-functions.
7221         * infcall.c (may_call_functions_p): New variable.
7222         (show_may_call_functions_p): New function.
7223         (call_function_by_hand_dummy): Throws an error if not
7224         may-call-functions.
7225         (_initialize_infcall): Call add_setshow_boolean_cmd for
7226         may-call-functions.
7227
7228 2019-04-25  Keith Seitz  <keiths@redhat.com>
7229
7230         PR c++/24367
7231         * cp-support.c (inspect_type): Don't attempt substitutions
7232         of symbol with the same name.
7233
7234 2019-04-25  Tom Tromey  <tromey@adacore.com>
7235
7236         PR gdb/24475:
7237         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7238         static.
7239
7240 2019-04-25  Tom Tromey  <tromey@adacore.com>
7241
7242         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7243         rvalue reference.
7244         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7245         (gdb_xml_parser::parse): Use std::move.
7246         * python/python-internal.h (gdbpy_convert_exception): Take a const
7247         reference.
7248         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7249         std::move.
7250         * python/py-utils.c (gdbpy_convert_exception): Take a const
7251         reference.
7252         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7253         Use std::move.
7254         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7255         Use std::move.
7256         * mi/mi-main.c (mi_print_exception): Take a const reference.
7257         * main.c (handle_command_errors): Take a const reference.
7258         * linespec.c (parse_linespec): Use std::move.
7259         * infcall.c (run_inferior_call): Use std::move.
7260         (call_function_by_hand_dummy): Use std::move.
7261         * exec.c (try_open_exec_file): Use std::move.
7262         * exceptions.h (exception_print, exception_fprintf)
7263         (exception_print_same): Update.
7264         * exceptions.c (print_exception, exception_print)
7265         (exception_fprintf, exception_print_same): Change parameters to
7266         const reference.
7267         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7268         * common/new-op.c: Use std::move.
7269         * common/common-exceptions.h (struct gdb_exception): Add move
7270         constructor.
7271         (struct gdb_exception_error, struct gdb_exception_quit, struct
7272         gdb_quit_bad_alloc): Change constructor to move constructor.
7273         (throw_exception): Change parameter to rvalue reference.
7274         * common/common-exceptions.c (throw_exception): Take rvalue
7275         reference.
7276         * cli/cli-interp.c (safe_execute_command): Use std::move.
7277         * breakpoint.c (insert_bp_location, location_to_sals): Use
7278         std::move.
7279
7280 2019-04-25  Tom Tromey  <tromey@adacore.com>
7281
7282         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7283         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7284         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7285         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7286         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7287         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7288         guile/scm-value.c: Use unpack.
7289         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7290         gdbscm_gdb_exception.
7291         (gdbscm_throw_gdb_exception): Likewise.
7292         (struct gdbscm_gdb_exception): New.
7293         (unpack): New function.
7294         (gdbscm_wrap): Use unpack.
7295
7296 2019-04-25  Tom Tromey  <tromey@adacore.com>
7297
7298         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7299         (gdb_rl_callback_handler): Use std::move.
7300         * common/common-exceptions.h (struct gdb_exception): Add move
7301         assignment operator.
7302         (throw_exception_sjlj): Change "exception" to const reference.
7303         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7304         (throw_exception_sjlj): Change "exception" to const reference.
7305
7306 2019-04-25  Tom Tromey  <tromey@adacore.com>
7307
7308         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7309         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7310         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7311         Update.
7312         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7313         Update.
7314         * mi/mi-interp.c (mi_interp::exec): Update.
7315         * linespec.c (parse_linespec): Update.
7316         * infcall.c (run_inferior_call): Update.
7317         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7318         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7319         (gdbscm_lookup_global_symbol): Update.
7320         * guile/scm-param.c (gdbscm_parameter_value): Update.
7321         * guile/scm-frame.c (gdbscm_frame_read_register)
7322         (gdbscm_frame_read_var): Update.
7323         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7324         * exec.c (try_open_exec_file): Update.
7325         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7326         (gdb_rl_callback_handler): Update.
7327         * common/common-exceptions.h (exception_none): Don't declare.
7328         * common/common-exceptions.c (exception_none): Don't define.
7329         (struct catcher) <exception>: Update.
7330         * cli/cli-interp.c (safe_execute_command): Update.
7331         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7332
7333 2019-04-25  Ali Tamur  <tamur@google.com>
7334
7335         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7336         (read_attribute_value): Likewise.
7337         (dwarf2_read_addr_index): Update comment.
7338         (read_str_index): Add DW_FORM_strx.
7339         (dwarf2_string_attr): Likewise.
7340         (dwarf2_const_value_attr): Likewise.
7341         (dump_die_shallow): Likewise.
7342         (dwarf2_fetch_constant_bytes): Likewise.
7343         (skip_form_bytes): Likewise.
7344         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7345
7346 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7347
7348         PR corefiles/11608
7349         PR corefiles/18187
7350         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7351         OFFSET.  Verify if current mapping contains an ELF header.
7352         (linux_find_memory_regions_full): Adjust call to
7353         dump_mapping_p.
7354
7355 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7356             Kang Li <kanglictf@gmail.com>
7357
7358         PR gdb/21600
7359
7360         * dwarf2-frame.c (read_initial_length): Be consistent about using
7361         unsigned representation of length.
7362         (decode_frame_entry_1): Likewise.  Check for wraparound of
7363         end pointer as well as buffer overflow.
7364
7365 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7366
7367         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7368         "vq".
7369
7370 2019-04-24  Tom Tromey  <tromey@adacore.com>
7371
7372         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7373
7374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7375
7376         * s12z-tdep.c (s12z_unwind_pc): Delete.
7377         (s12z_unwind_sp): Delete.
7378         (s12z_gdbarch_init): Don't register deleted functions with
7379         gdbarch.
7380
7381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7382
7383         * rl78-tdep.c (rl78_unwind_sp): Delete.
7384         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7385
7386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7387
7388         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7389         (xstormy16_unwind_pc): Delete.
7390         (xstormy16_dummy_id): Delete.
7391         (xstormy16_gdbarch_init): Don't register deleted functions with
7392         gdbarch.
7393
7394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7395
7396         * vax-tdep.c (vax_unwind_pc): Delete.
7397         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7398
7399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7400
7401         * v850-tdep.c (v850_unwind_sp): Delete.
7402         (v850_unwind_pc): Delete.
7403         (v850_dummy_id): Delete.
7404         (v850_gdbarch_init): Don't register deleted functions with
7405         gdbarch.
7406
7407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7410         (tilegx_unwind_pc): Delete.
7411         (tilegx_unwind_dummy_id): Delete.
7412         (tilegx_gdbarch_init): Don't register deleted functions with
7413         gdbarch.
7414
7415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7416
7417         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7418         (tic6x_dummy_id): Delete.
7419         (tic6x_gdbarch_init): Don't register deleted functions with
7420         gdbarch.
7421
7422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7423
7424         * sparc-tdep.c (sparc_unwind_pc): Delete.
7425         (sparc32_gdbarch_init): Don't register deleted function with
7426         gdbarch.
7427
7428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * sh-tdep.c (sh_unwind_sp): Delete.
7431         (sh_unwind_pc): Delete.
7432         (sh_dummy_id): Delete.
7433         (sh_gdbarch_init): Don't register deleted functions with
7434         gdbarch.
7435
7436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7437
7438         * score-tdep.c (score_unwind_sp): Delete.
7439         (score_unwind_pc): Delete.
7440         (score_dummy_id): Delete.
7441         (score_gdbarch_init): Don't register deleted functions with
7442         gdbarch.
7443
7444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * rx-tdep.c (rx_unwind_pc): Delete.
7447         (rx_unwind_sp): Delete.
7448         (rx_dummy_id): Delete.
7449         (rx_gdbarch_init): Don't register deleted functions with
7450         gdbarch.  Update comment.
7451
7452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7453
7454         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7455         (rs6000_dummy_id): Delete.
7456         (rs6000_gdbarch_init): Don't register deleted functions with
7457         gdbarch.
7458
7459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7460
7461         * or1k-tdep.c (or1k_dummy_id): Delete.
7462         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7463
7464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * nios2-tdep.c (nios2_dummy_id): Delete.
7467         (nios2_unwind_sp): Delete.
7468         (nios2_gdbarch_init): Don't register deleted functions with
7469         gdbarch.
7470
7471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7472
7473         * nds32-tdep.c (nds32_dummy_id): Delete.
7474         (nds32_unwind_pc): Delete.
7475         (nds32_unwind_sp): Delete.
7476         (nds32_gdbarch_init): Don't register deleted functions with
7477         gdbarch.
7478
7479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7480
7481         * msp430-tdep.c (msp430_unwind_pc): Delete.
7482         (msp430_unwind_sp): Delete.
7483         (msp430_dummy_id): Delete.
7484         (msp430_gdbarch_init): Don't register deleted functions with
7485         gdbarch.
7486
7487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * moxie-tdep.c (moxie_unwind_sp): Delete.
7490         (moxie_unwind_pc): Delete.
7491         (moxie_dummy_id): Delete.
7492         (moxie_gdbarch_init): Don't register deleted functions with
7493         gdbarch.
7494
7495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7498         (mn10300_unwind_pc): Delete.
7499         (mn10300_unwind_sp): Delete.
7500         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7501         mn10300_unwind_sp.
7502         (mn10300_frame_unwind_init): Don't register deleted functions with
7503         gdbarch.
7504
7505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7506
7507         * mep-tdep.c (mep_unwind_pc): Delete.
7508         (mep_unwind_sp): Delete.
7509         (mep_dummy_id): Delete.
7510         (mep_gdbarch_init): Don't register deleted functions with
7511         gdbarch.
7512
7513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7516         (m68hc11_unwind_sp): Delete.
7517         (m68hc11_gdbarch_init): Don't register deleted functions with
7518         gdbarch.
7519
7520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7521
7522         * m32r-tdep.c (m32r_unwind_sp): Delete.
7523         (m32r_unwind_pc): Delete.
7524         (m32r_dummy_id): Delete.
7525         (m32r_gdbarch_init): Don't register deleted functions with
7526         gdbarch.
7527
7528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * m32c-tdep.c (m32c_unwind_pc): Delete.
7531         (m32c_unwind_sp): Delete.
7532         (m32c_dummy_id): Delete.
7533         (m32c_gdbarch_init): Don't register deleted functions with
7534         gdbarch.
7535
7536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7537
7538         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7539         (lm32_unwind_pc): Delete.
7540         (lm32_dummy_id): Delete.
7541         (lm32_gdbarch_init): Don't register deleted functions with
7542         gdbarch.
7543
7544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7547         (iq2000_unwind_pc): Delete.
7548         (iq2000_dummy_id): Delete.
7549         (iq2000_gdbarch_init): Don't register deleted functions with
7550         gdbarch.
7551
7552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7553
7554         * nds32-tdep.c (nds32_type_align): Delete.
7555         (nds32_push_dummy_call): Use type_align instead.
7556
7557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7558
7559         * arm-tdep.c (arm_type_align): Only handle vector override case.
7560         (arm_push_dummy_call): Use type_align.
7561         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7562
7563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7566         case.
7567         (pass_on_stack): Use type_align.
7568         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7569         function.
7570
7571 2019-04-23  Tom Tromey  <tromey@adacore.com>
7572
7573         * dwarf2read.c (line_header::file_name_at): Remove unused
7574         overload.
7575
7576 2019-04-23  Tom de Vries  <tdevries@suse.de>
7577
7578         PR gdb/24438
7579         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7580         invocation.
7581
7582
7583 2019-03-27  Ali Tamur  <tamur@google.com>
7584
7585         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7586         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7587         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7588         (dwarf_expr_context::get_addr_index): Likewise
7589         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7590         (symbol_needs_eval_context::get_addr_index): Likewise
7591         (disassemble_dwarf_expression): Add DW_OP_addrx
7592         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7593         (read_cutu_die_from_dwo): Update comment
7594         (skip_one_die): Add DW_FORM_addrx
7595         (read_attribute_value): Likewise
7596         (var_decode_location): Add DW_OP_addrx
7597         (dwarf2_const_value_attr): Add DW_FORM_addrx
7598         (dump_die_shallow): Likewise
7599         (dwarf2_fetch_constant_bytes): Likewise
7600         (decode_locdesc): Add DW_OP_addrx
7601         (skip_form_bytes): Add DW_FORM_addrx
7602
7603 2019-04-22  Ali Tamur  <tamur@google.com>
7604
7605         * MAINTAINERS (Write After Approval): Add self.
7606
7607 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7608
7609         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7610         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7611         (open_symbol_file_object): Likewise.
7612         (svr4_default_sos): Add info parameter.
7613         (svr4_read_so_list): Likewise.
7614         (svr4_current_sos_direct): Adjust functions calls to pass down
7615         info.
7616         (svr4_current_sos_1): Add info parameter.
7617         (svr4_current_sos): Call get_svr4_info, pass info down to
7618         svr4_current_sos_1.
7619         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7620         get_svr4_info.
7621         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7622         get_svr4_info.
7623         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7624         to get_svr4_info.
7625         (probes_table_remove_objfile_probes): Likewise.
7626         (register_solib_event_probe): Add info parameter.
7627         (solist_update_incremental): Pass info parameter down to
7628         svr4_read_so_list.
7629         (disable_probes_interface): Add info parameter.
7630         (svr4_handle_solib_event): Pass current_program_space to
7631         get_svr4_info.  Adjust disable_probes_interface cleanup.
7632         (svr4_create_probe_breakpoints): Add info parameter, pass it
7633         down to register_solib_event_probe.
7634         (svr4_create_solib_event_breakpoints): Add info parameter,
7635         pass it down to svr4_create_probe_breakpoints.
7636         (enable_break): Pass info down to
7637         svr4_create_solib_event_breakpoints.
7638         (svr4_solib_create_inferior_hook): Pass current_program_space to
7639         get_svr4_info.
7640         (svr4_clear_solib): Likewise.
7641
7642 2019-04-22  Pedro Alves  <palves@redhat.com>
7643
7644         * solib-svr4.c (svr4_free_objfile_observer): New.
7645         (probe_and_action::objfile): New field.
7646         (probes_table_htab_remove_objfile_probes)
7647         (probes_table_remove_objfile_probes): New functions.
7648         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7649         in the new probe_and_action.  Don't store the probe in 'lookup'.
7650         (svr4_create_probe_breakpoints): Pass objfile to
7651         register_solib_event_probe.
7652         (_initialize_svr4_solib): Register a free_objfile observer.
7653
7654 2019-04-19  Tom Tromey  <tom@tromey.com>
7655
7656         * common/queue.h: Remove.
7657
7658 2019-04-19  Tom Tromey  <tom@tromey.com>
7659
7660         * event-loop.c: Don't include "common/queue.h".
7661
7662 2019-04-19  Tom Tromey  <tom@tromey.com>
7663
7664         * remote.c (remote_target): Use delete.
7665         * remote-notif.h: Include <list>, not "common/queue.h".
7666         (notif_client_p): Remove typedef.
7667         (remote_notif_state): Add constructor, destructor, initializer.
7668         <notif_queue>: Now a std::list.
7669         (remote_notif_state_xfree): Don't declare.
7670         * remote-notif.c (remote_notif_process, handle_notification)
7671         (remote_notif_state_allocate): Update.
7672         (~remote_notif_state): Rename from remote_notif_state_xfree.
7673
7674 2019-04-19  Tom Tromey  <tom@tromey.com>
7675
7676         * symfile.c (reread_symbols): Update.
7677         * objfiles.c (objfile_register_static_link)
7678         (objfile_lookup_static_link): Update
7679         (~objfile) Don't delete static_links.
7680         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7681
7682 2019-04-19  Tom Tromey  <tom@tromey.com>
7683
7684         * type-stack.h (struct type_stack) <insert>: Constify string.
7685         * type-stack.c (type_stack::insert): Constify string.
7686         * gdbtypes.h (lookup_template_type): Update.
7687         (address_space_name_to_int): Update.
7688         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7689         const.
7690         (lookup_template_type): Make name const.
7691         * c-exp.y: Update rules.
7692         (lex_one_token, classify_name, classify_inner_name)
7693         (c_print_token): Update.
7694         * p-exp.y: Update rules.
7695         (yylex): Update.
7696         * f-exp.y: Update rules.
7697         (yylex): Update.
7698         * d-exp.y: Update rules.
7699         (lex_one_token, classify_name, classify_inner_name): Update.
7700         * parse.c (write_dollar_variable, copy_name): Return std::string.
7701         * parser-defs.h (copy_name): Change return type.
7702         * m2-exp.y: Update rules.
7703         (yylex): Update.
7704         * go-exp.y (lex_one_token): Update.
7705         Update rules.
7706         (classify_unsafe_function, classify_packaged_name)
7707         (classify_name, yylex): Update.
7708
7709 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7710
7711         * configure.ac: add --enable-source-highlight switch.
7712         * configure: Regenerate.
7713         * top.c (print_gdb_version): plumb --enable-source-highlight
7714         status to "show configuration".
7715
7716 2019-04-19  Tom Tromey  <tromey@adacore.com>
7717
7718         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7719         Check ADA_TYPE_P.
7720         (empty_record, ada_template_to_fixed_record_type_1)
7721         (template_to_static_fixed_type)
7722         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7723         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7724         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7725         macros.
7726
7727 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7728
7729         PR symtab/24423:
7730         * source.c (print_source_lines_base): Advance "iter" when a
7731         control character is seen.
7732
7733 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7734
7735         * inferior.h (struct infcall_suspend_state_deleter):
7736         Catch exception in destructor to avoid crash.
7737
7738 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7739
7740         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7741         close to the add_com "shell".
7742
7743 2019-04-18  Tom Tromey  <tromey@adacore.com>
7744
7745         * process-stratum-target.h (class process_stratum_target)
7746         <stratum>: Add "final".
7747
7748 2019-04-17  Tom Tromey  <tromey@adacore.com>
7749
7750         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7751         against nullptr before use.
7752
7753 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7754
7755         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7756
7757 2019-04-17  Jim Wilson  <jimw@sifive.com>
7758             Andrew Burgess  <andrew.burgess@embecosm.com>
7759
7760         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7761         code read might fail, assume 4-byte breakpoint in that case.
7762
7763 2019-04-15  Leszek Swirski  <leszeks@google.com>
7764
7765         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7766         rather than a hand-rolled POD check when checking for forced MEMORY
7767         classification.
7768
7769 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7770
7771         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7772         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7773         function.
7774         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7775         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7776         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7777         declaration.
7778
7779 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7780
7781         * aarch64-linux-nat.c
7782         (aarch64_linux_nat_target::thread_architecture): Add override.
7783         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7784         each VQ.
7785
7786 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7787
7788         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7789
7790 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7791
7792         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7793         target types of size 96-bits, add some additional comments, and
7794         check that the builtin type we found was the correct size.
7795
7796 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7797
7798         * utils.c (prompt_for_continue): Don't restore the styling at the
7799         end, as applied_style has the wrong value.  This fixes styling in
7800         long lists of file names that are interrupted by the "Continue?"
7801         prompt.
7802
7803 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7804
7805         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7806         * c-lang.c (c_language_defn): Likewise.
7807         (cplus_language_defn): Likewise.
7808         (asm_language_defn): Likewise.
7809         (minimal_language_defn): Likewise.
7810         * d-lang.c (d_language_defn): Likewise.
7811         * f-lang.c (f_language_defn): Likewise.
7812         * go-lang.c (go_language_defn): Likewise.
7813         * language.c (unknown_language_defn): Likewise.
7814         (auto_language_defn): Likewise.
7815         * language.h (struct language_defn): Remove la_magic field.
7816         (LANG_MAGIC): Delete.
7817         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7818         * objc-lang.c (objc_language_defn): Likewise.
7819         * opencl-lang.c (opencl_language_defn): Likewise.
7820         * p-lang.c (pascal_language_defn): Likewise.
7821         * rust-lang.c (rust_language_defn): Likewise.
7822
7823 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * riscv-tdep.c (riscv_type_align): New function.
7826         (riscv_type_alignment): Delete.
7827         (riscv_arg_location): Use 'type_align'.
7828         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7829
7830 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * gdbtypes.c (type_align): A struct with no non-static fields also
7833         has alignment of 1.
7834
7835 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7838         component to 0.
7839         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7840         member.
7841         (riscv_struct_info::analyse): New implementation using new
7842         analyse_inner member function.
7843         (riscv_struct_info::field_offset): New member function.
7844         (riscv_struct_info::m_offsets): New member variable.
7845         (riscv_struct_info::analyse_inner): New private member function,
7846         takes the old implementation of riscv_struct_info::analyse but
7847         extended to track field offsets.
7848         (riscv_call_arg_struct): Update the struct folding special cases
7849         to handle cases where empty C++ structs, which are non-zero
7850         length, are found.
7851         (riscv_arg_location): Initialise the length of each location, a
7852         non-zero length now indicates the location is in use.
7853         (riscv_push_dummy_call): Allow for the first location having a
7854         non-zero offset when setting up arguments.
7855         (riscv_return_value): Likewise, but for return values.
7856
7857 2019-04-11  Tom Tromey  <tromey@adacore.com>
7858
7859         * utils.c (internal_vproblem): Make "msg" const.
7860
7861 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7862
7863         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7864         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7865         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7866         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7867
7868 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7869
7870         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7871         function.
7872         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7873         of amd64_collect_native_gregset.
7874         (amd64_linux_nat_target::store_registers): Likewise.
7875
7876 2019-04-10  Tom Tromey  <tom@tromey.com>
7877
7878         * symtab.c (lookup_global_symbol_from_objfile)
7879         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7880         * objfiles.h (class separate_debug_iterator): New.
7881         (class separate_debug_range): New.
7882         (struct objfile) <separate_debug_objfiles>: New method.
7883         (objfile_separate_debug_iterate): Don't declare.
7884         * objfiles.c (separate_debug_iterator::operator++): Rename from
7885         objfile_separate_debug_iterate.
7886         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7887         iterator.
7888         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7889         iterator.
7890
7891 2019-04-10  Tom Tromey  <tom@tromey.com>
7892
7893         * symfile.c (reread_symbols): Remove old comment.
7894         * objfiles.c (free_all_objfiles): Fix a typo.
7895
7896 2019-04-10  Tom Tromey  <tom@tromey.com>
7897
7898         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7899         * minsyms.c (lookup_minimal_symbol): Use foreach.
7900         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7901         (lookup_minimal_symbol_solib_trampoline): Likewise.
7902         * symfile.c (reread_symbols): Use foreach.
7903
7904 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7905             Tom Tromey  <tromey@adacore.com>
7906
7907         PR rust/24414:
7908         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7909         (rust_lex_int_test): Change "value" to be LONGEST.
7910         (rust_lex_tests): Add test for long integer literal.
7911
7912 2019-04-09  Tom Tromey  <tromey@adacore.com>
7913
7914         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7915         to bool.
7916         (extended_remote_target::attach): Update.
7917         (remote_target::remote_notice_new_inferior): Update.
7918         (remote_target::add_current_inferior_and_thread): Update.
7919         * inferior.c (exit_inferior_1): Use "false".
7920         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7921
7922 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7923
7924         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7925         the "start" command.
7926
7927 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7928
7929         * python/py-inferior.c (infpy_thread_from_thread_handle):
7930         Adjust comments to reflect renaming of thread_from_thread_handle
7931         to thread_from_handle.  Adjust keywords.  Fix type error message.
7932         (inferior_object_methods): Add thread_from_handle.  Retain
7933         thread_from_thread_handle, but mark it as deprecated.
7934
7935 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7936
7937         * gdbthread.h (find_thread_by_handle): Revise declaration.
7938         * thread.c (find_thread_by_handle): Likewise.  Adjust
7939         implementation too.
7940         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7941         support for buffer objects as handles.
7942
7943 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7944
7945         * python/py-infthread.c (thpy_thread_handle): New function.
7946         (thread_object_methods): Register thpy_thread_handle.
7947
7948 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7949
7950         * gdbthread.h (thread_to_thread_handle): Declare.
7951         * thread.c (gdbtypes.h): Include.
7952         (thread_to_thread_handle): New function.
7953
7954         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7955         (target_thread_info_to_thread_handle): Declare.
7956         * target.c (target_thread_info_to_thread_handle): New function.
7957         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7958         * target-delegates.c: Regenerate.
7959
7960         * linux-thread-db.c (class thread_db_target): Add method
7961         thread_info_to_thread_handle.
7962         (thread_db_target::thread_info_to_thread_handle): Define.
7963         * remote.c (class remote_target): Add new method
7964         thread_info_to_thread_handle.
7965         (remote_target::thread_info_to_thread_handle): Define.
7966
7967 2019-04-08  Pedro Alves  <palves@redhat.com>
7968
7969         * common/common-exceptions.c (throw_exception): Don't create
7970         named object to throw; throw directly.
7971         (throw_it): Likewise.  Don't initialize gdb_exception::message
7972         here, with new; pass FMT and AP to the ctor instead.
7973         * common/common-exceptions.h: Include <string>.
7974         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7975         const char *, va_list)): New ctor.  Use std::make_shared.
7976         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7977         errors)): Delete.
7978         (gdb_exception_error::gdb_exception_error(enum errors, const char
7979         *, va_list)): New.
7980         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7981         Add assertion.
7982         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7983         errors)): Delete.
7984         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7985         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7986         Add assertion.
7987
7988 2019-04-08  Tom Tromey  <tom@tromey.com>
7989
7990         * valops.c (value_rtti_indirect_type): Replace throw_exception
7991         with throw.
7992         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7993         with throw.
7994         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7995         throw.
7996         * target.c (target_translate_tls_address): Replace throw_exception
7997         with throw.
7998         * stack.c (frame_apply_command_count): Replace throw_exception
7999         with throw.
8000         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8001         throw.
8002         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8003         with throw.
8004         * rs6000-tdep.c (rs6000_frame_cache)
8005         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8006         * remote.c: Replace throw_exception with throw.
8007         * record-full.c (record_full_message, record_full_wait_1)
8008         (record_full_restore): Replace throw_exception with throw.
8009         * record-btrace.c:
8010         (get_thread_current_frame_id, record_btrace_start_replaying)
8011         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8012         (cmd_record_btrace_start): Replace throw_exception with throw.
8013         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8014         throw.
8015         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8016         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8017         * linespec.c:
8018         (find_linespec_symbols): Replace throw_exception with throw.
8019         * infrun.c (displaced_step_prepare, resume): Replace
8020         throw_exception with throw.
8021         * infcmd.c (post_create_inferior): Replace throw_exception with
8022         throw.
8023         * inf-loop.c (inferior_event_handler): Replace throw_exception
8024         with throw.
8025         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8026         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8027         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8028         (get_prev_frame_always, get_frame_pc_if_available)
8029         (get_frame_address_in_block_if_available, get_frame_language):
8030         Replace throw_exception with throw.
8031         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8032         throw_exception with throw.
8033         * eval.c (fetch_subexp_value, evaluate_var_value)
8034         (evaluate_funcall, evaluate_subexp_standard): Replace
8035         throw_exception with throw.
8036         * dwarf2loc.c (call_site_find_chain)
8037         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8038         Replace throw_exception with throw.
8039         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8040         with throw.
8041         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8042         throw.
8043         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8044         * completer.c (complete_line_internal): Replace throw_exception
8045         with throw.
8046         * compile/compile-object-run.c (compile_object_run): Replace
8047         throw_exception with throw.
8048         * cli/cli-script.c (process_next_line): Replace throw_exception
8049         with throw.
8050         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8051         (btrace_enable, btrace_maint_update_pt_packets): Replace
8052         throw_exception with throw.
8053         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8054         throw_exception with throw.
8055         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8056         throw_exception with throw.
8057         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8058         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8059         * aarch64-tdep.c (aarch64_make_prologue_cache)
8060         (aarch64_make_stub_cache): Replace throw_exception with throw.
8061
8062 2019-04-08  Tom Tromey  <tom@tromey.com>
8063
8064         * common/common-exceptions.c (throw_exception): Rename from
8065         throw_exception_cxx.  Remove old copy.  Make argument const.
8066         (throw_it): Create and throw exception objects directly.
8067         * common/common-exceptions.h (throw_exception): Make argument
8068         const.
8069         (struct gdb_exception_error): Add constructor.
8070         (struct gdb_exception_quit): Add constructor.
8071
8072 2019-04-08  Tom Tromey  <tom@tromey.com>
8073
8074         * common/common-exceptions.h (exception_rethrow): Don't declare.
8075         (TRY_SJLJ): Update comment.
8076         (TRY, CATCH, END_CATCH): Remove.
8077         * common/common-exceptions.c (exception_rethrow): Remove.
8078
8079 2019-04-08  Tom Tromey  <tom@tromey.com>
8080
8081         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8082         Remove.
8083         (gdb_exception_error): Rename from
8084         gdb_exception_RETURN_MASK_ERROR.
8085         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8086         (gdb_quit_bad_alloc): Update.
8087         * aarch64-tdep.c: Update.
8088         * ada-lang.c: Update.
8089         * ada-typeprint.c: Update.
8090         * ada-valprint.c: Update.
8091         * amd64-tdep.c: Update.
8092         * arch-utils.c: Update.
8093         * break-catch-throw.c: Update.
8094         * breakpoint.c: Update.
8095         * btrace.c: Update.
8096         * c-varobj.c: Update.
8097         * cli/cli-cmds.c: Update.
8098         * cli/cli-interp.c: Update.
8099         * cli/cli-script.c: Update.
8100         * common/common-exceptions.c: Update.
8101         * common/new-op.c: Update.
8102         * common/selftest.c: Update.
8103         * compile/compile-c-symbols.c: Update.
8104         * compile/compile-cplus-symbols.c: Update.
8105         * compile/compile-object-load.c: Update.
8106         * compile/compile-object-run.c: Update.
8107         * completer.c: Update.
8108         * corelow.c: Update.
8109         * cp-abi.c: Update.
8110         * cp-support.c: Update.
8111         * cp-valprint.c: Update.
8112         * darwin-nat.c: Update.
8113         * disasm-selftests.c: Update.
8114         * dtrace-probe.c: Update.
8115         * dwarf-index-cache.c: Update.
8116         * dwarf-index-write.c: Update.
8117         * dwarf2-frame-tailcall.c: Update.
8118         * dwarf2-frame.c: Update.
8119         * dwarf2loc.c: Update.
8120         * dwarf2read.c: Update.
8121         * eval.c: Update.
8122         * event-loop.c: Update.
8123         * event-top.c: Update.
8124         * exec.c: Update.
8125         * f-valprint.c: Update.
8126         * fbsd-tdep.c: Update.
8127         * frame-unwind.c: Update.
8128         * frame.c: Update.
8129         * gdbtypes.c: Update.
8130         * gnu-v3-abi.c: Update.
8131         * guile/guile-internal.h: Update.
8132         * guile/scm-block.c: Update.
8133         * guile/scm-breakpoint.c: Update.
8134         * guile/scm-cmd.c: Update.
8135         * guile/scm-disasm.c: Update.
8136         * guile/scm-frame.c: Update.
8137         * guile/scm-lazy-string.c: Update.
8138         * guile/scm-math.c: Update.
8139         * guile/scm-param.c: Update.
8140         * guile/scm-ports.c: Update.
8141         * guile/scm-pretty-print.c: Update.
8142         * guile/scm-symbol.c: Update.
8143         * guile/scm-symtab.c: Update.
8144         * guile/scm-type.c: Update.
8145         * guile/scm-value.c: Update.
8146         * i386-linux-tdep.c: Update.
8147         * i386-tdep.c: Update.
8148         * inf-loop.c: Update.
8149         * infcall.c: Update.
8150         * infcmd.c: Update.
8151         * infrun.c: Update.
8152         * jit.c: Update.
8153         * language.c: Update.
8154         * linespec.c: Update.
8155         * linux-fork.c: Update.
8156         * linux-nat.c: Update.
8157         * linux-tdep.c: Update.
8158         * linux-thread-db.c: Update.
8159         * main.c: Update.
8160         * mi/mi-cmd-break.c: Update.
8161         * mi/mi-cmd-stack.c: Update.
8162         * mi/mi-interp.c: Update.
8163         * mi/mi-main.c: Update.
8164         * objc-lang.c: Update.
8165         * p-valprint.c: Update.
8166         * parse.c: Update.
8167         * ppc-linux-tdep.c: Update.
8168         * printcmd.c: Update.
8169         * python/py-arch.c: Update.
8170         * python/py-breakpoint.c: Update.
8171         * python/py-cmd.c: Update.
8172         * python/py-finishbreakpoint.c: Update.
8173         * python/py-frame.c: Update.
8174         * python/py-framefilter.c: Update.
8175         * python/py-gdb-readline.c: Update.
8176         * python/py-inferior.c: Update.
8177         * python/py-infthread.c: Update.
8178         * python/py-lazy-string.c: Update.
8179         * python/py-linetable.c: Update.
8180         * python/py-objfile.c: Update.
8181         * python/py-param.c: Update.
8182         * python/py-prettyprint.c: Update.
8183         * python/py-progspace.c: Update.
8184         * python/py-record-btrace.c: Update.
8185         * python/py-record.c: Update.
8186         * python/py-symbol.c: Update.
8187         * python/py-type.c: Update.
8188         * python/py-unwind.c: Update.
8189         * python/py-utils.c: Update.
8190         * python/py-value.c: Update.
8191         * python/python.c: Update.
8192         * record-btrace.c: Update.
8193         * record-full.c: Update.
8194         * remote-fileio.c: Update.
8195         * remote.c: Update.
8196         * riscv-tdep.c: Update.
8197         * rs6000-aix-tdep.c: Update.
8198         * rs6000-tdep.c: Update.
8199         * rust-exp.y: Update.
8200         * rust-lang.c: Update.
8201         * s390-tdep.c: Update.
8202         * selftest-arch.c: Update.
8203         * solib-dsbt.c: Update.
8204         * solib-frv.c: Update.
8205         * solib-spu.c: Update.
8206         * solib-svr4.c: Update.
8207         * solib.c: Update.
8208         * sparc64-linux-tdep.c: Update.
8209         * stack.c: Update.
8210         * symfile-mem.c: Update.
8211         * symmisc.c: Update.
8212         * target.c: Update.
8213         * thread.c: Update.
8214         * top.c: Update.
8215         * tracefile-tfile.c: Update.
8216         * tui/tui.c: Update.
8217         * typeprint.c: Update.
8218         * unittests/cli-utils-selftests.c: Update.
8219         * unittests/parse-connection-spec-selftests.c: Update.
8220         * valops.c: Update.
8221         * valprint.c: Update.
8222         * value.c: Update.
8223         * varobj.c: Update.
8224         * windows-nat.c: Update.
8225         * x86-linux-nat.c: Update.
8226         * xml-support.c: Update.
8227
8228 2019-04-08  Tom Tromey  <tom@tromey.com>
8229
8230         * xml-support.c: Use C++ exception handling.
8231         * x86-linux-nat.c: Use C++ exception handling.
8232         * windows-nat.c: Use C++ exception handling.
8233         * varobj.c: Use C++ exception handling.
8234         * value.c: Use C++ exception handling.
8235         * valprint.c: Use C++ exception handling.
8236         * valops.c: Use C++ exception handling.
8237         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8238         handling.
8239         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8240         * typeprint.c: Use C++ exception handling.
8241         * tui/tui.c: Use C++ exception handling.
8242         * tracefile-tfile.c: Use C++ exception handling.
8243         * top.c: Use C++ exception handling.
8244         * thread.c: Use C++ exception handling.
8245         * target.c: Use C++ exception handling.
8246         * symmisc.c: Use C++ exception handling.
8247         * symfile-mem.c: Use C++ exception handling.
8248         * stack.c: Use C++ exception handling.
8249         * sparc64-linux-tdep.c: Use C++ exception handling.
8250         * solib.c: Use C++ exception handling.
8251         * solib-svr4.c: Use C++ exception handling.
8252         * solib-spu.c: Use C++ exception handling.
8253         * solib-frv.c: Use C++ exception handling.
8254         * solib-dsbt.c: Use C++ exception handling.
8255         * selftest-arch.c: Use C++ exception handling.
8256         * s390-tdep.c: Use C++ exception handling.
8257         * rust-lang.c: Use C++ exception handling.
8258         * rust-exp.y: Use C++ exception handling.
8259         * rs6000-tdep.c: Use C++ exception handling.
8260         * rs6000-aix-tdep.c: Use C++ exception handling.
8261         * riscv-tdep.c: Use C++ exception handling.
8262         * remote.c: Use C++ exception handling.
8263         * remote-fileio.c: Use C++ exception handling.
8264         * record-full.c: Use C++ exception handling.
8265         * record-btrace.c: Use C++ exception handling.
8266         * python/python.c: Use C++ exception handling.
8267         * python/py-value.c: Use C++ exception handling.
8268         * python/py-utils.c: Use C++ exception handling.
8269         * python/py-unwind.c: Use C++ exception handling.
8270         * python/py-type.c: Use C++ exception handling.
8271         * python/py-symbol.c: Use C++ exception handling.
8272         * python/py-record.c: Use C++ exception handling.
8273         * python/py-record-btrace.c: Use C++ exception handling.
8274         * python/py-progspace.c: Use C++ exception handling.
8275         * python/py-prettyprint.c: Use C++ exception handling.
8276         * python/py-param.c: Use C++ exception handling.
8277         * python/py-objfile.c: Use C++ exception handling.
8278         * python/py-linetable.c: Use C++ exception handling.
8279         * python/py-lazy-string.c: Use C++ exception handling.
8280         * python/py-infthread.c: Use C++ exception handling.
8281         * python/py-inferior.c: Use C++ exception handling.
8282         * python/py-gdb-readline.c: Use C++ exception handling.
8283         * python/py-framefilter.c: Use C++ exception handling.
8284         * python/py-frame.c: Use C++ exception handling.
8285         * python/py-finishbreakpoint.c: Use C++ exception handling.
8286         * python/py-cmd.c: Use C++ exception handling.
8287         * python/py-breakpoint.c: Use C++ exception handling.
8288         * python/py-arch.c: Use C++ exception handling.
8289         * printcmd.c: Use C++ exception handling.
8290         * ppc-linux-tdep.c: Use C++ exception handling.
8291         * parse.c: Use C++ exception handling.
8292         * p-valprint.c: Use C++ exception handling.
8293         * objc-lang.c: Use C++ exception handling.
8294         * mi/mi-main.c: Use C++ exception handling.
8295         * mi/mi-interp.c: Use C++ exception handling.
8296         * mi/mi-cmd-stack.c: Use C++ exception handling.
8297         * mi/mi-cmd-break.c: Use C++ exception handling.
8298         * main.c: Use C++ exception handling.
8299         * linux-thread-db.c: Use C++ exception handling.
8300         * linux-tdep.c: Use C++ exception handling.
8301         * linux-nat.c: Use C++ exception handling.
8302         * linux-fork.c: Use C++ exception handling.
8303         * linespec.c: Use C++ exception handling.
8304         * language.c: Use C++ exception handling.
8305         * jit.c: Use C++ exception handling.
8306         * infrun.c: Use C++ exception handling.
8307         * infcmd.c: Use C++ exception handling.
8308         * infcall.c: Use C++ exception handling.
8309         * inf-loop.c: Use C++ exception handling.
8310         * i386-tdep.c: Use C++ exception handling.
8311         * i386-linux-tdep.c: Use C++ exception handling.
8312         * guile/scm-value.c: Use C++ exception handling.
8313         * guile/scm-type.c: Use C++ exception handling.
8314         * guile/scm-symtab.c: Use C++ exception handling.
8315         * guile/scm-symbol.c: Use C++ exception handling.
8316         * guile/scm-pretty-print.c: Use C++ exception handling.
8317         * guile/scm-ports.c: Use C++ exception handling.
8318         * guile/scm-param.c: Use C++ exception handling.
8319         * guile/scm-math.c: Use C++ exception handling.
8320         * guile/scm-lazy-string.c: Use C++ exception handling.
8321         * guile/scm-frame.c: Use C++ exception handling.
8322         * guile/scm-disasm.c: Use C++ exception handling.
8323         * guile/scm-cmd.c: Use C++ exception handling.
8324         * guile/scm-breakpoint.c: Use C++ exception handling.
8325         * guile/scm-block.c: Use C++ exception handling.
8326         * guile/guile-internal.h: Use C++ exception handling.
8327         * gnu-v3-abi.c: Use C++ exception handling.
8328         * gdbtypes.c: Use C++ exception handling.
8329         * frame.c: Use C++ exception handling.
8330         * frame-unwind.c: Use C++ exception handling.
8331         * fbsd-tdep.c: Use C++ exception handling.
8332         * f-valprint.c: Use C++ exception handling.
8333         * exec.c: Use C++ exception handling.
8334         * event-top.c: Use C++ exception handling.
8335         * event-loop.c: Use C++ exception handling.
8336         * eval.c: Use C++ exception handling.
8337         * dwarf2read.c: Use C++ exception handling.
8338         * dwarf2loc.c: Use C++ exception handling.
8339         * dwarf2-frame.c: Use C++ exception handling.
8340         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8341         * dwarf-index-write.c: Use C++ exception handling.
8342         * dwarf-index-cache.c: Use C++ exception handling.
8343         * dtrace-probe.c: Use C++ exception handling.
8344         * disasm-selftests.c: Use C++ exception handling.
8345         * darwin-nat.c: Use C++ exception handling.
8346         * cp-valprint.c: Use C++ exception handling.
8347         * cp-support.c: Use C++ exception handling.
8348         * cp-abi.c: Use C++ exception handling.
8349         * corelow.c: Use C++ exception handling.
8350         * completer.c: Use C++ exception handling.
8351         * compile/compile-object-run.c: Use C++ exception handling.
8352         * compile/compile-object-load.c: Use C++ exception handling.
8353         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8354         * compile/compile-c-symbols.c: Use C++ exception handling.
8355         * common/selftest.c: Use C++ exception handling.
8356         * common/new-op.c: Use C++ exception handling.
8357         * cli/cli-script.c: Use C++ exception handling.
8358         * cli/cli-interp.c: Use C++ exception handling.
8359         * cli/cli-cmds.c: Use C++ exception handling.
8360         * c-varobj.c: Use C++ exception handling.
8361         * btrace.c: Use C++ exception handling.
8362         * breakpoint.c: Use C++ exception handling.
8363         * break-catch-throw.c: Use C++ exception handling.
8364         * arch-utils.c: Use C++ exception handling.
8365         * amd64-tdep.c: Use C++ exception handling.
8366         * ada-valprint.c: Use C++ exception handling.
8367         * ada-typeprint.c: Use C++ exception handling.
8368         * ada-lang.c: Use C++ exception handling.
8369         * aarch64-tdep.c: Use C++ exception handling.
8370
8371 2019-04-08  Tom Tromey  <tom@tromey.com>
8372
8373         * xml-support.c (gdb_xml_parser::parse): Update.
8374         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8375         * value.c (show_convenience): Update.
8376         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8377         (test_parse_flags_qcs): Update.
8378         * thread.c (thr_try_catch_cmd): Update.
8379         * target.c (target_translate_tls_address): Update.
8380         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8381         (info_frame_command_core, frame_apply_command_count): Update.
8382         * rust-exp.y (rust_lex_exception_test): Update.
8383         * riscv-tdep.c (riscv_print_one_register_info): Update.
8384         * remote.c (remote_target::enable_btrace): Update.
8385         * record-btrace.c (record_btrace_enable_warn): Update.
8386         * python/py-utils.c (gdbpy_convert_exception): Update.
8387         * printcmd.c (do_one_display, print_variable_and_value): Update.
8388         * mi/mi-main.c (mi_print_exception): Update.
8389         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8390         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8391         * linux-nat.c (linux_nat_target::attach): Update.
8392         * linux-fork.c (class scoped_switch_fork_info): Update.
8393         * infrun.c (displaced_step_prepare): Update.
8394         * infcall.c (call_function_by_hand_dummy): Update.
8395         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8396         * gnu-v3-abi.c (print_one_vtable): Update.
8397         * frame.c (get_prev_frame_always): Update.
8398         * f-valprint.c (info_common_command_for_block): Update.
8399         * exec.c (try_open_exec_file): Update.
8400         * exceptions.c (print_exception, exception_print)
8401         (exception_fprintf, exception_print_same): Update.
8402         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8403         * dwarf-index-cache.c (index_cache::store)
8404         (index_cache::lookup_gdb_index): Update.
8405         * darwin-nat.c (maybe_cache_shell): Update.
8406         * cp-valprint.c (cp_print_value_fields): Update.
8407         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8408         (gcc_cplus_symbol_address): Update.
8409         * compile/compile-c-symbols.c (gcc_convert_symbol)
8410         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8411         * common/selftest.c: Update.
8412         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8413         a std::string.
8414         (exception_try_scope_entry, exception_try_scope_exit): Don't
8415         declare.
8416         (struct exception_try_scope): Remove.
8417         (TRY): Don't use exception_try_scope.
8418         (struct gdb_exception): Add constructor, operator=.
8419         <what>: New method.
8420         (struct gdb_exception_RETURN_MASK_ALL)
8421         (struct gdb_exception_RETURN_MASK_ERROR)
8422         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8423         (struct gdb_quit_bad_alloc): Update.
8424         * common/common-exceptions.c (exception_none): Change
8425         initializer.
8426         (struct catcher) <state, exception>: Initialize inline.
8427         <prev>: Remove member.
8428         (current_catcher): Remove.
8429         (catchers): New global.
8430         (exceptions_state_mc_init): Simplify.
8431         (catcher_pop): Remove.
8432         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8433         (try_scope_depth, exception_try_scope_entry)
8434         (exception_try_scope_exit): Remove.
8435         (throw_exception_sjlj): Update.
8436         (exception_messages, exception_messages_size): Remove.
8437         (throw_it): Simplify.
8438         (gdb_exception_sliced_copy): Remove.
8439         (throw_exception_cxx): Update.
8440         * cli/cli-script.c (script_from_file): Update.
8441         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8442         Update.
8443         * ada-valprint.c (ada_val_print): Update.
8444         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8445         (create_excep_cond_exprs): Update.
8446
8447 2019-04-08  Tom Tromey  <tom@tromey.com>
8448
8449         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8450         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8451         (TRY, CATCH, END_CATCH): Remove some definitions.
8452         * common/common-exceptions.c: Don't use GDB_XCPT.
8453         (catcher_list_size): Remove.
8454         (throw_exception, throw_it): Simplify.
8455
8456 2019-04-05  Tom Tromey  <tom@tromey.com>
8457
8458         Revert the header-sorting patch.
8459         * ft32-tdep.c: Revert.
8460         * frv-tdep.c: Revert.
8461         * frv-linux-tdep.c: Revert.
8462         * frame.c: Revert.
8463         * frame-unwind.c: Revert.
8464         * frame-base.c: Revert.
8465         * fork-child.c: Revert.
8466         * findvar.c: Revert.
8467         * findcmd.c: Revert.
8468         * filesystem.c: Revert.
8469         * filename-seen-cache.h: Revert.
8470         * filename-seen-cache.c: Revert.
8471         * fbsd-tdep.c: Revert.
8472         * fbsd-nat.h: Revert.
8473         * fbsd-nat.c: Revert.
8474         * f-valprint.c: Revert.
8475         * f-typeprint.c: Revert.
8476         * f-lang.c: Revert.
8477         * extension.h: Revert.
8478         * extension.c: Revert.
8479         * extension-priv.h: Revert.
8480         * expprint.c: Revert.
8481         * exec.h: Revert.
8482         * exec.c: Revert.
8483         * exceptions.c: Revert.
8484         * event-top.c: Revert.
8485         * event-loop.c: Revert.
8486         * eval.c: Revert.
8487         * elfread.c: Revert.
8488         * dwarf2read.h: Revert.
8489         * dwarf2read.c: Revert.
8490         * dwarf2loc.c: Revert.
8491         * dwarf2expr.h: Revert.
8492         * dwarf2expr.c: Revert.
8493         * dwarf2-frame.c: Revert.
8494         * dwarf2-frame-tailcall.c: Revert.
8495         * dwarf-index-write.h: Revert.
8496         * dwarf-index-write.c: Revert.
8497         * dwarf-index-common.c: Revert.
8498         * dwarf-index-cache.h: Revert.
8499         * dwarf-index-cache.c: Revert.
8500         * dummy-frame.c: Revert.
8501         * dtrace-probe.c: Revert.
8502         * disasm.h: Revert.
8503         * disasm.c: Revert.
8504         * disasm-selftests.c: Revert.
8505         * dictionary.c: Revert.
8506         * dicos-tdep.c: Revert.
8507         * demangle.c: Revert.
8508         * dcache.h: Revert.
8509         * dcache.c: Revert.
8510         * darwin-nat.h: Revert.
8511         * darwin-nat.c: Revert.
8512         * darwin-nat-info.c: Revert.
8513         * d-valprint.c: Revert.
8514         * d-namespace.c: Revert.
8515         * d-lang.c: Revert.
8516         * ctf.c: Revert.
8517         * csky-tdep.c: Revert.
8518         * csky-linux-tdep.c: Revert.
8519         * cris-tdep.c: Revert.
8520         * cris-linux-tdep.c: Revert.
8521         * cp-valprint.c: Revert.
8522         * cp-support.c: Revert.
8523         * cp-namespace.c: Revert.
8524         * cp-abi.c: Revert.
8525         * corelow.c: Revert.
8526         * corefile.c: Revert.
8527         * continuations.c: Revert.
8528         * completer.h: Revert.
8529         * completer.c: Revert.
8530         * complaints.c: Revert.
8531         * coffread.c: Revert.
8532         * coff-pe-read.c: Revert.
8533         * cli-out.h: Revert.
8534         * cli-out.c: Revert.
8535         * charset.c: Revert.
8536         * c-varobj.c: Revert.
8537         * c-valprint.c: Revert.
8538         * c-typeprint.c: Revert.
8539         * c-lang.c: Revert.
8540         * buildsym.c: Revert.
8541         * buildsym-legacy.c: Revert.
8542         * build-id.h: Revert.
8543         * build-id.c: Revert.
8544         * btrace.c: Revert.
8545         * bsd-uthread.c: Revert.
8546         * breakpoint.h: Revert.
8547         * breakpoint.c: Revert.
8548         * break-catch-throw.c: Revert.
8549         * break-catch-syscall.c: Revert.
8550         * break-catch-sig.c: Revert.
8551         * blockframe.c: Revert.
8552         * block.c: Revert.
8553         * bfin-tdep.c: Revert.
8554         * bfin-linux-tdep.c: Revert.
8555         * bfd-target.c: Revert.
8556         * bcache.c: Revert.
8557         * ax-general.c: Revert.
8558         * ax-gdb.h: Revert.
8559         * ax-gdb.c: Revert.
8560         * avr-tdep.c: Revert.
8561         * auxv.c: Revert.
8562         * auto-load.c: Revert.
8563         * arm-wince-tdep.c: Revert.
8564         * arm-tdep.c: Revert.
8565         * arm-symbian-tdep.c: Revert.
8566         * arm-pikeos-tdep.c: Revert.
8567         * arm-obsd-tdep.c: Revert.
8568         * arm-nbsd-tdep.c: Revert.
8569         * arm-nbsd-nat.c: Revert.
8570         * arm-linux-tdep.c: Revert.
8571         * arm-linux-nat.c: Revert.
8572         * arm-fbsd-tdep.c: Revert.
8573         * arm-fbsd-nat.c: Revert.
8574         * arm-bsd-tdep.c: Revert.
8575         * arch-utils.c: Revert.
8576         * arc-tdep.c: Revert.
8577         * arc-newlib-tdep.c: Revert.
8578         * annotate.h: Revert.
8579         * annotate.c: Revert.
8580         * amd64-windows-tdep.c: Revert.
8581         * amd64-windows-nat.c: Revert.
8582         * amd64-tdep.c: Revert.
8583         * amd64-sol2-tdep.c: Revert.
8584         * amd64-obsd-tdep.c: Revert.
8585         * amd64-obsd-nat.c: Revert.
8586         * amd64-nbsd-tdep.c: Revert.
8587         * amd64-nbsd-nat.c: Revert.
8588         * amd64-nat.c: Revert.
8589         * amd64-linux-tdep.c: Revert.
8590         * amd64-linux-nat.c: Revert.
8591         * amd64-fbsd-tdep.c: Revert.
8592         * amd64-fbsd-nat.c: Revert.
8593         * amd64-dicos-tdep.c: Revert.
8594         * amd64-darwin-tdep.c: Revert.
8595         * amd64-bsd-nat.c: Revert.
8596         * alpha-tdep.c: Revert.
8597         * alpha-obsd-tdep.c: Revert.
8598         * alpha-nbsd-tdep.c: Revert.
8599         * alpha-mdebug-tdep.c: Revert.
8600         * alpha-linux-tdep.c: Revert.
8601         * alpha-linux-nat.c: Revert.
8602         * alpha-bsd-tdep.c: Revert.
8603         * alpha-bsd-nat.c: Revert.
8604         * aix-thread.c: Revert.
8605         * agent.c: Revert.
8606         * addrmap.c: Revert.
8607         * ada-varobj.c: Revert.
8608         * ada-valprint.c: Revert.
8609         * ada-typeprint.c: Revert.
8610         * ada-tasks.c: Revert.
8611         * ada-lang.c: Revert.
8612         * aarch64-tdep.c: Revert.
8613         * aarch64-ravenscar-thread.c: Revert.
8614         * aarch64-newlib-tdep.c: Revert.
8615         * aarch64-linux-tdep.c: Revert.
8616         * aarch64-linux-nat.c: Revert.
8617         * aarch64-fbsd-tdep.c: Revert.
8618         * aarch64-fbsd-nat.c: Revert.
8619         * aarch32-linux-nat.c: Revert.
8620
8621 2019-04-05  Tom Tromey  <tom@tromey.com>
8622
8623         * ft32-tdep.c: Sort headers.
8624         * frv-tdep.c: Sort headers.
8625         * frv-linux-tdep.c: Sort headers.
8626         * frame.c: Sort headers.
8627         * frame-unwind.c: Sort headers.
8628         * frame-base.c: Sort headers.
8629         * fork-child.c: Sort headers.
8630         * findvar.c: Sort headers.
8631         * findcmd.c: Sort headers.
8632         * filesystem.c: Sort headers.
8633         * filename-seen-cache.h: Sort headers.
8634         * filename-seen-cache.c: Sort headers.
8635         * fbsd-tdep.c: Sort headers.
8636         * fbsd-nat.h: Sort headers.
8637         * fbsd-nat.c: Sort headers.
8638         * f-valprint.c: Sort headers.
8639         * f-typeprint.c: Sort headers.
8640         * f-lang.c: Sort headers.
8641         * extension.h: Sort headers.
8642         * extension.c: Sort headers.
8643         * extension-priv.h: Sort headers.
8644         * expprint.c: Sort headers.
8645         * exec.h: Sort headers.
8646         * exec.c: Sort headers.
8647         * exceptions.c: Sort headers.
8648         * event-top.c: Sort headers.
8649         * event-loop.c: Sort headers.
8650         * eval.c: Sort headers.
8651         * elfread.c: Sort headers.
8652         * dwarf2read.h: Sort headers.
8653         * dwarf2read.c: Sort headers.
8654         * dwarf2loc.c: Sort headers.
8655         * dwarf2expr.h: Sort headers.
8656         * dwarf2expr.c: Sort headers.
8657         * dwarf2-frame.c: Sort headers.
8658         * dwarf2-frame-tailcall.c: Sort headers.
8659         * dwarf-index-write.h: Sort headers.
8660         * dwarf-index-write.c: Sort headers.
8661         * dwarf-index-common.c: Sort headers.
8662         * dwarf-index-cache.h: Sort headers.
8663         * dwarf-index-cache.c: Sort headers.
8664         * dummy-frame.c: Sort headers.
8665         * dtrace-probe.c: Sort headers.
8666         * disasm.h: Sort headers.
8667         * disasm.c: Sort headers.
8668         * disasm-selftests.c: Sort headers.
8669         * dictionary.c: Sort headers.
8670         * dicos-tdep.c: Sort headers.
8671         * demangle.c: Sort headers.
8672         * dcache.h: Sort headers.
8673         * dcache.c: Sort headers.
8674         * darwin-nat.h: Sort headers.
8675         * darwin-nat.c: Sort headers.
8676         * darwin-nat-info.c: Sort headers.
8677         * d-valprint.c: Sort headers.
8678         * d-namespace.c: Sort headers.
8679         * d-lang.c: Sort headers.
8680         * ctf.c: Sort headers.
8681         * csky-tdep.c: Sort headers.
8682         * csky-linux-tdep.c: Sort headers.
8683         * cris-tdep.c: Sort headers.
8684         * cris-linux-tdep.c: Sort headers.
8685         * cp-valprint.c: Sort headers.
8686         * cp-support.c: Sort headers.
8687         * cp-namespace.c: Sort headers.
8688         * cp-abi.c: Sort headers.
8689         * corelow.c: Sort headers.
8690         * corefile.c: Sort headers.
8691         * continuations.c: Sort headers.
8692         * completer.h: Sort headers.
8693         * completer.c: Sort headers.
8694         * complaints.c: Sort headers.
8695         * coffread.c: Sort headers.
8696         * coff-pe-read.c: Sort headers.
8697         * cli-out.h: Sort headers.
8698         * cli-out.c: Sort headers.
8699         * charset.c: Sort headers.
8700         * c-varobj.c: Sort headers.
8701         * c-valprint.c: Sort headers.
8702         * c-typeprint.c: Sort headers.
8703         * c-lang.c: Sort headers.
8704         * buildsym.c: Sort headers.
8705         * buildsym-legacy.c: Sort headers.
8706         * build-id.h: Sort headers.
8707         * build-id.c: Sort headers.
8708         * btrace.c: Sort headers.
8709         * bsd-uthread.c: Sort headers.
8710         * breakpoint.h: Sort headers.
8711         * breakpoint.c: Sort headers.
8712         * break-catch-throw.c: Sort headers.
8713         * break-catch-syscall.c: Sort headers.
8714         * break-catch-sig.c: Sort headers.
8715         * blockframe.c: Sort headers.
8716         * block.c: Sort headers.
8717         * bfin-tdep.c: Sort headers.
8718         * bfin-linux-tdep.c: Sort headers.
8719         * bfd-target.c: Sort headers.
8720         * bcache.c: Sort headers.
8721         * ax-general.c: Sort headers.
8722         * ax-gdb.h: Sort headers.
8723         * ax-gdb.c: Sort headers.
8724         * avr-tdep.c: Sort headers.
8725         * auxv.c: Sort headers.
8726         * auto-load.c: Sort headers.
8727         * arm-wince-tdep.c: Sort headers.
8728         * arm-tdep.c: Sort headers.
8729         * arm-symbian-tdep.c: Sort headers.
8730         * arm-pikeos-tdep.c: Sort headers.
8731         * arm-obsd-tdep.c: Sort headers.
8732         * arm-nbsd-tdep.c: Sort headers.
8733         * arm-nbsd-nat.c: Sort headers.
8734         * arm-linux-tdep.c: Sort headers.
8735         * arm-linux-nat.c: Sort headers.
8736         * arm-fbsd-tdep.c: Sort headers.
8737         * arm-fbsd-nat.c: Sort headers.
8738         * arm-bsd-tdep.c: Sort headers.
8739         * arch-utils.c: Sort headers.
8740         * arc-tdep.c: Sort headers.
8741         * arc-newlib-tdep.c: Sort headers.
8742         * annotate.h: Sort headers.
8743         * annotate.c: Sort headers.
8744         * amd64-windows-tdep.c: Sort headers.
8745         * amd64-windows-nat.c: Sort headers.
8746         * amd64-tdep.c: Sort headers.
8747         * amd64-sol2-tdep.c: Sort headers.
8748         * amd64-obsd-tdep.c: Sort headers.
8749         * amd64-obsd-nat.c: Sort headers.
8750         * amd64-nbsd-tdep.c: Sort headers.
8751         * amd64-nbsd-nat.c: Sort headers.
8752         * amd64-nat.c: Sort headers.
8753         * amd64-linux-tdep.c: Sort headers.
8754         * amd64-linux-nat.c: Sort headers.
8755         * amd64-fbsd-tdep.c: Sort headers.
8756         * amd64-fbsd-nat.c: Sort headers.
8757         * amd64-dicos-tdep.c: Sort headers.
8758         * amd64-darwin-tdep.c: Sort headers.
8759         * amd64-bsd-nat.c: Sort headers.
8760         * alpha-tdep.c: Sort headers.
8761         * alpha-obsd-tdep.c: Sort headers.
8762         * alpha-nbsd-tdep.c: Sort headers.
8763         * alpha-mdebug-tdep.c: Sort headers.
8764         * alpha-linux-tdep.c: Sort headers.
8765         * alpha-linux-nat.c: Sort headers.
8766         * alpha-bsd-tdep.c: Sort headers.
8767         * alpha-bsd-nat.c: Sort headers.
8768         * aix-thread.c: Sort headers.
8769         * agent.c: Sort headers.
8770         * addrmap.c: Sort headers.
8771         * ada-varobj.c: Sort headers.
8772         * ada-valprint.c: Sort headers.
8773         * ada-typeprint.c: Sort headers.
8774         * ada-tasks.c: Sort headers.
8775         * ada-lang.c: Sort headers.
8776         * aarch64-tdep.c: Sort headers.
8777         * aarch64-ravenscar-thread.c: Sort headers.
8778         * aarch64-newlib-tdep.c: Sort headers.
8779         * aarch64-linux-tdep.c: Sort headers.
8780         * aarch64-linux-nat.c: Sort headers.
8781         * aarch64-fbsd-tdep.c: Sort headers.
8782         * aarch64-fbsd-nat.c: Sort headers.
8783         * aarch32-linux-nat.c: Sort headers.
8784
8785 2019-04-04  Tom Tromey  <tom@tromey.com>
8786
8787         * varobj.c (varobj_create): Update.
8788         * rust-exp.y (struct rust_parser) <update_innermost_block,
8789         lookup_symbol>: New methods.
8790         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8791         Rename.
8792         (rust_parser::rust_lookup_type)
8793         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8794         * printcmd.c (display_command, do_one_display): Update.
8795         * parser-defs.h (struct parser_state) <parser_state>: Add
8796         "tracker" parameter.
8797         (block_tracker): New member.
8798         (class innermost_block_tracker) <innermost_block_tracker>: Add
8799         "types" parameter.
8800         <reset>: Remove method.
8801         (innermost_block): Don't declare.
8802         (null_post_parser): Update.
8803         * parse.c (innermost_block): Remove global.
8804         (write_dollar_variable): Update.
8805         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8806         Remove "tracker_types" parameter.
8807         (parse_expression): Add "tracker" parameter.
8808         (parse_expression_for_completion): Update.
8809         (null_post_parser): Add "tracker" parameter.
8810         * p-exp.y: Update rules.
8811         * m2-exp.y: Update rules.
8812         * language.h (struct language_defn) <la_post_parser>: Add
8813         "tracker" parameter.
8814         * go-exp.y: Update rules.
8815         * f-exp.y: Update rules.
8816         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8817         parameter.
8818         * d-exp.y: Update rules.
8819         * c-exp.y: Update rules.
8820         * breakpoint.c (set_breakpoint_condition): Create an
8821         innermost_block_tracker.
8822         (watch_command_1): Likewise.
8823         * ada-lang.c (resolve): Add "tracker" parameter.
8824         (resolve_subexp): Likewise.
8825         * ada-exp.y (write_var_from_sym): Update.
8826
8827 2019-04-04  Tom Tromey  <tom@tromey.com>
8828
8829         * type-stack.h: New file.
8830         * type-stack.c: New file.
8831         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8832         type-stack.h.
8833         (insert_into_type_stack, insert_type, push_type, push_type_int)
8834         (insert_type_address_space, pop_type, pop_type_int)
8835         (pop_typelist, pop_type_stack, append_type_stack)
8836         (push_type_stack, get_type_stack, push_typelist)
8837         (follow_type_instance_flags, follow_types): Don't declare.
8838         * parse.c (type_stack): Remove global.
8839         (parse_exp_in_context): Update.
8840         (insert_into_type_stack, insert_type, push_type, push_type_int)
8841         (insert_type_address_space, pop_type, pop_type_int)
8842         (pop_typelist, pop_type_stack, append_type_stack)
8843         (push_type_stack, get_type_stack, push_typelist)
8844         (follow_type_instance_flags, follow_types): Remove (moved to
8845         type-stack.c).
8846         * f-exp.y (type_stack): New global.
8847         Update rules.
8848         (push_kind_type, f_parse): Update.
8849         * d-exp.y (type_stack): New global.
8850         Update rules.
8851         (d_parse): Update.
8852         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8853         Update rules.
8854         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8855         (HFILES_NO_SRCDIR): Add type-stack.h.
8856
8857 2019-04-04  Tom Tromey  <tom@tromey.com>
8858
8859         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8860         (rust_parser::convert_ast_to_expression, rust_parse)
8861         (rust_lex_test_completion, rust_lex_tests): Update.
8862         * parser-defs.h (struct expr_completion_state): New.
8863         (struct parser_state) <parser_state>: Add completion parameter.
8864         <mark_struct_expression, mark_completion_tag>: New methods.
8865         <parse_completion, m_completion_state>: New members.
8866         (prefixify_expression, null_post_parser): Update.
8867         (mark_struct_expression, mark_completion_tag): Don't declare.
8868         * parse.c (parse_completion, expout_last_struct)
8869         (expout_tag_completion_type, expout_completion_name): Remove
8870         globals.
8871         (parser_state::mark_struct_expression)
8872         (parser_state::mark_completion_tag): Now methods.
8873         (prefixify_expression): Add last_struct parameter.
8874         (prefixify_subexp): Likewise.
8875         (parse_exp_1): Update.
8876         (parse_exp_in_context): Add cstate parameter.  Update.
8877         (parse_expression_for_completion): Create an
8878         expr_completion_state.
8879         (null_post_parser): Add "completion" parameter.
8880         * p-exp.y: Update rules.
8881         (yylex): Update.
8882         * language.h (struct language_defn) <la_post_parser>: Add
8883         "completing" parameter.
8884         * go-exp.y: Update rules.
8885         (lex_one_token): Update.
8886         * expression.h (parse_completion): Don't declare.
8887         * d-exp.y: Update rules.
8888         (lex_one_token): Update rules.
8889         * c-exp.y: Update rules.
8890         (lex_one_token): Update.
8891         * ada-lang.c (resolve): Add "parse_completion" parameter.
8892         (resolve_subexp): Likewise.
8893         (ada_resolve_function): Likewise.
8894
8895 2019-04-04  Tom Tromey  <tom@tromey.com>
8896
8897         * parser-defs.h (struct parser_state) <start_arglist,
8898         end_arglist>: New methods.
8899         <arglist_len, m_funcall_chain>: New members.
8900         (arglist_len, start_arglist, end_arglist): Don't declare.
8901         * parse.c (arglist_len, funcall_chain): Remove global.
8902         (start_arglist, end_arglist): Remove functions.
8903         (parse_exp_in_context): Update.
8904         * p-exp.y: Update rules.
8905         * m2-exp.y: Update rules.
8906         * go-exp.y: Update rules.
8907         * f-exp.y: Update rules.
8908         * d-exp.y: Update rules.
8909         * c-exp.y: Update rules.
8910
8911 2019-04-04  Tom Tromey  <tom@tromey.com>
8912
8913         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8914         lex_operator, push_back>: New methods.
8915         Update all rules.
8916         (rust_parser::lex_hex, lex_escape): Rename and update.
8917         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8918         (rust_parser::lex_operator): Rename and update.
8919         (rust_parser::lex_number, rustyylex, rustyyerror)
8920         (rust_lex_test_init, rust_lex_test_sequence)
8921         (rust_lex_test_push_back, rust_lex_tests): Update.
8922         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8923         parameter.
8924         <lexptr, prev_lexptr>: New members.
8925         (lexptr, prev_lexptr): Don't declare.
8926         * parse.c (lexptr, prev_lexptr): Remove globals.
8927         (parse_exp_in_context): Update.
8928         * p-exp.y (yylex, yyerror): Update.
8929         * m2-exp.y (parse_number, yylex, yyerror): Update.
8930         * go-exp.y (lex_one_token, yyerror): Update.
8931         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8932         * d-exp.y (lex_one_token, yyerror): Update.
8933         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8934         (lex_one_token, yyerror): Update.
8935         * ada-lex.l (YY_INPUT): Update.
8936         (rewind_to_char): Update.
8937         * ada-exp.y (yyerror): Update.
8938
8939 2019-04-04  Tom Tromey  <tom@tromey.com>
8940
8941         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8942         * parser-defs.h (struct parser_state) <parser_state>: Add new
8943         parameter.
8944         <comma_terminates>: New member.
8945         (comma_terminates): Don't declare global.
8946         * parse.c (comma_terminates): Remove global.
8947         (parse_exp_in_context): Update.
8948         * p-exp.y (yylex): Update.
8949         * m2-exp.y (yylex): Update.
8950         * go-exp.y (lex_one_token): Update.
8951         * f-exp.y (yylex): Update.
8952         * d-exp.y (lex_one_token): Update.
8953         * c-exp.y (lex_one_token): Update.
8954         * ada-lex.l: Update.
8955
8956 2019-04-04  Tom Tromey  <tom@tromey.com>
8957
8958         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8959         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8960         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8961         * parser-defs.h (paren_depth): Don't declare.
8962         * parse.c (paren_depth): Remove global.
8963         (parse_exp_in_context): Update.
8964         * p-exp.y (paren_depth): New global.
8965         (pascal_parse): Initialize it.
8966         * m2-exp.y (paren_depth): New global.
8967         (m2_parse): Initialize it.
8968         * go-exp.y (paren_depth): New global.
8969         (go_parse): Initialize it.
8970         * f-exp.y (paren_depth): New global.
8971         (f_parse): Initialize it.
8972         * d-exp.y (paren_depth): New global.
8973         (d_parse): Initialize it.
8974         * c-exp.y (paren_depth): New global.
8975         (c_parse): Initialize it.
8976         * ada-lex.l (paren_depth): New global.
8977         (lexer_init): Initialize it.
8978
8979 2019-04-04  Tom Tromey  <tom@tromey.com>
8980
8981         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8982         (rust_parser::convert_ast_to_type)
8983         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8984         * parser-defs.h (struct parser_state) <parser_state>: Add
8985         parameters.  Initialize new members.
8986         <expression_context_block, expression_context_pc>: New members.
8987         * parse.c (expression_context_block, expression_context_pc):
8988         Remove globals.
8989         (parse_exp_in_context): Update.
8990         * p-exp.y: Update all rules.
8991         (yylex): Update.
8992         * m2-exp.y: Update all rules.
8993         (yylex): Update.
8994         * go-exp.y (yylex): Update.
8995         * f-exp.y (yylex): Update.
8996         * d-exp.y: Update all rules.
8997         (yylex): Update.
8998         * c-exp.y: Update all rules.
8999         (lex_one_token, classify_name, yylex, c_parse): Update.
9000         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9001
9002 2019-04-04  Tom Tromey  <tom@tromey.com>
9003
9004         * gdbarch.h, gdbarch.c: Rebuild.
9005         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9006         * stap-probe.h:
9007         (struct stap_parse_info): Replace "parser_state" with
9008         "expr_builder".
9009         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9010         (parser_state): New class.
9011         * parse.c (expr_builder): Rename.
9012         (expr_builder::release): Rename.
9013         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9014         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9015         (write_exp_elt_longcst, write_exp_elt_floatcst)
9016         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9017         (write_exp_string_vector, write_exp_bitstring)
9018         (write_exp_msymbol, mark_struct_expression)
9019         (write_dollar_variable)
9020         (insert_type_address_space, increase_expout_size): Replace
9021         "parser_state" with "expr_builder".
9022         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9023         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9024         "parser_state" with "expr_builder".
9025
9026 2019-04-04  Tom Tromey  <tom@tromey.com>
9027
9028         * rust-exp.y: Replace "parse_language" with method call.
9029         * p-exp.y:
9030         (yylex): Replace "parse_language" with method call.
9031         * m2-exp.y:
9032         (yylex): Replace "parse_language" with method call.
9033         * go-exp.y (classify_name): Replace "parse_language" with method
9034         call.
9035         * f-exp.y (yylex): Replace "parse_language" with method call.
9036         * d-exp.y (lex_one_token): Replace "parse_language" with method
9037         call.
9038         * c-exp.y:
9039         (lex_one_token, classify_name, yylex): Replace "parse_language"
9040         with method call.
9041         * ada-exp.y (find_primitive_type, type_char)
9042         (type_system_address): Replace "parse_language" with method call.
9043
9044 2019-04-04  Tom Tromey  <tom@tromey.com>
9045
9046         * rust-exp.y: Replace "parse_gdbarch" with method call.
9047         * parse.c (write_dollar_variable, insert_type_address_space):
9048         Replace "parse_gdbarch" with method call.
9049         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9050         call.
9051         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9052         call.
9053         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9054         "parse_gdbarch" with method call.
9055         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9056         with method call.
9057         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9058         "parse_gdbarch" with method call.
9059         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9060         "parse_gdbarch" with method call.
9061         * c-exp.y (parse_type, parse_number, classify_name): Replace
9062         "parse_gdbarch" with method call.
9063         * ada-lex.l: Replace "parse_gdbarch" with method call.
9064         * ada-exp.y (parse_type, find_primitive_type, type_char)
9065         (type_system_address): Replace "parse_gdbarch" with method call.
9066
9067 2019-04-04  Tom Tromey  <tom@tromey.com>
9068
9069         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9070         * stap-probe.c (stap_parse_argument): Update.
9071         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9072         initial_size parameter.
9073         * rust-exp.y (rust_lex_tests): Update.
9074         * parse.c (parser_state): Update.
9075         (parse_exp_in_context): Update.
9076         * parser-defs.h (struct parser_state) <parser_state>: Remove
9077         "initial_size" parameter.
9078
9079 2019-04-04  Tom Tromey  <tom@tromey.com>
9080
9081         * parser-defs.h (increase_expout_size): Don't declare.
9082         * parse.c (increase_expout_size): Now static.
9083
9084 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9085
9086         * gnu-nat.c (gnu_nat_target::wait): Fix
9087         target_waitstatus_to_string call.
9088
9089 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9090
9091         * eval.c (evaluate_subexp_standard): Handle internal functions
9092         during Fortran function call handling.
9093
9094 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * NEWS: Mention new internal functions.
9097         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9098         (read_base_type): Use dwarf2_init_complex_target_type.
9099         * value.c (creal_internal_fn): New function.
9100         (cimag_internal_fn): New function.
9101         (_initialize_values): Register new internal functions.
9102
9103 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9104
9105         * infrun.c (stop_all_threads): If debug_infrun, always
9106         trace the wait status after wait_one, using
9107         target_waitstatus_to_string and target_pid_to_str.
9108         (handle_inferior_event): Replace various trace of
9109         wait status kind by a single trace.
9110         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9111         wait status kind image by target_waitstatus_to_string.
9112         * target/waitstatus.c (target_waitstatus_to_string): Fix
9113         obsolete comment.
9114
9115 2019-04-01  Tom Tromey  <tromey@adacore.com>
9116
9117         PR symtab/23331:
9118         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9119
9120 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9121             Pedro Alves  <palves@redhat.com>
9122
9123         * top.c (quit_force): Call 'finalize_values'.
9124         * value.c (finalize_values): New function.
9125         * value.h (finalize_values): Declare.
9126
9127 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9128
9129         * NEWS: Announce $_gdb_major and $_gdb_minor.
9130
9131         * top.c (init_gdb_version_vars): New function.
9132         (gdb_init): Call init_gdb_version_vars.
9133
9134 2019-03-29  Tom Tromey  <tromey@adacore.com>
9135
9136         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9137         help text.  Remove dead code.
9138
9139 2019-03-29  Keith Seitz  <keiths@redhat.com>
9140
9141         From Siddhesh Poyarekar:
9142         * f-lang.h (f77_get_upperbound): Return LONGEST.
9143         (f77_get_lowerbound): Likewise.
9144         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9145         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9146         print them.
9147         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9148         plongest to format print it.
9149         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9150         (f77_get_upperbound): Likewise.
9151         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9152         LOWER_BOUND to LONGEST.
9153         (f77_create_arrayprint_offset_tbl): Likewise.
9154
9155 2019-03-29  Keith Seitz  <keiths@redhat.com>
9156
9157         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9158         %s/pulongest for TYPE_LENGTH instead of %d in format
9159         strings.
9160         * ada-typerint.c (ada_print_type): Likewise.
9161         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9162         * compile/compile-c-support.c (generate_register_struct): Likewise.
9163         * gdbtypes.c (recursive_dump_type): Likewise.
9164         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9165         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9166         instead of %d in format strings.
9167         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9168         to std::min to ULONGEST.
9169         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9170         instead of %d in format strings.
9171         * tracepoint.c (info_scope_command): Likewise.
9172         * typeprint.c (print_offset_data::update)
9173         (print_offset_data::finish): Likewise.
9174         * xtensa-tdep.c (xtensa_store_return_value)
9175         (xtensa_push_dummy_call): Likewise.
9176
9177 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9178
9179         * windows-nat.c (display_selector): Fixed format specifications
9180         for 64-bit Cygwin.
9181
9182 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9183
9184         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9185
9186 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9187
9188         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9189         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9190         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9191         (nios2_linux_init_abi): Install it.
9192
9193 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9194
9195         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9196
9197 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9198
9199         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9200
9201 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9202             Tom Tromey  <tromey@adacore.com>
9203
9204         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9205
9206 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9207
9208         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9209         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9210         method to compute the bounds of range types. Also print "[evaluated]"
9211         if the bounds' values come from a dynamic evaluation.
9212
9213 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9216         whitespace when pretty printing is on.
9217
9218 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9219
9220         * ppc-linux-nat.c: Add include.
9221
9222 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9223
9224         * NEWS: Mention AArch64 Pointer Authentication.
9225
9226 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9227
9228         * arm-linux-nat.c: Add include.
9229
9230 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9231
9232         * source-cache.c (source_cache::get_source_lines): Re-read
9233         fullname after calling open_source_file.
9234
9235 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9236
9237         * NEWS: Mention TLS support for FreeBSD.
9238
9239 2019-03-25  Tom Tromey  <tromey@adacore.com>
9240
9241         * minsyms.c (BUNCH_SIZE): Update comment.
9242         (~minimal_symbol_reader): Remove old comment.
9243         (compact_minimal_symbols): Update comment.
9244         (minimal_symbol_reader::install): Remove old comment.  Update
9245         other comments.
9246
9247 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9248
9249         * s390-linux-nat.c: Add include.
9250
9251 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9252
9253         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9254         Call linux_get_hwcap.
9255         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9256         Likewise.
9257         (aarch64_linux_get_hwcap): Remove function.
9258         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9259         declaration.
9260         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9261         linux_get_hwcap.
9262         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9263         * linux-tdep.c (linux_get_hwcap): Add function.
9264         (linux_get_hwcap2): Likewise.
9265         * linux-tdep.h (linux_get_hwcap): Add declaration.
9266         (linux_get_hwcap2): Likewise.
9267         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9268         (ppc_linux_get_hwcap2): Likewise.
9269         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9270         linux_get_hwcap.
9271         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9272         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9273         (ppc_linux_nat_target::read_description): Likewise.
9274         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9275         * s390-linux-nat.c: Likewise.
9276         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9277
9278 2019-03-24  Tom Tromey  <tom@tromey.com>
9279
9280         * ada-lang.c (standard_lookup): Simplify initialization.
9281         (ada_lookup_symbol_nonlocal): Simplify return.
9282         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9283         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9284         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9285         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9286         initialization.
9287         * solib.c (solib_global_lookup): Simplify.
9288         * symtab.c (null_block_symbol): Remove.
9289         (symbol_cache_lookup): Simplify returns.
9290         (lookup_language_this): Simplify returns.
9291         (lookup_symbol_aux): Simplify return.
9292         (lookup_local_symbol): Simplify returns.
9293         (lookup_global_symbol_from_objfile): Simplify return.
9294         (lookup_symbol_in_objfile_symtabs)
9295         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9296         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9297         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9298         * cp-namespace.c (cp_lookup_bare_symbol)
9299         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9300         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9301         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9302         (cp_lookup_symbol_via_imports): Simplify initialization.
9303         (find_symbol_in_baseclass): Likewise.
9304         * symtab.h (null_block_symbol): Remove.
9305         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9306         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9307         (d_lookup_symbol_module): Likewise.
9308         (find_symbol_in_baseclass): Simplify initialization.
9309
9310 2019-03-24  Tom Tromey  <tom@tromey.com>
9311
9312         * expression.h: Don't include symtab.h.
9313         (struct block): Forward declare.
9314
9315 2019-03-24  Tom Tromey  <tom@tromey.com>
9316
9317         * c-exp.y (typebase): Remove casts.
9318         * gdbtypes.c (lookup_unsigned_typename, )
9319         (lookup_signed_typename): Remove cast.
9320         * eval.c (parse_to_comma_and_eval): Remove cast.
9321         * parse.c (write_dollar_variable): Remove cast.
9322         * block.h (struct block) <superblock>: Now const.
9323         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9324         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9325         (map_block): Make "block" const.
9326         * symfile.h (struct quick_symbol_functions)
9327         <map_matching_symbols>: Constify block argument to "callback".
9328         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9329         const.
9330         (find_pc_sect_compunit_symtab): Make "b" const.
9331         (find_symbol_at_address): Likewise.
9332         (search_symbols): Likewise.
9333         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9334         (dw2_debug_names_lookup_symbol): Likewise.
9335         (dw2_map_matching_symbols): Update.
9336         * p-valprint.c (pascal_val_print): Remove "block".
9337         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9338         (aux_add_nonlocal_symbols): Make "block" const.
9339         (resolve_subexp): Remove cast.
9340         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9341         const.
9342         (iterate_over_file_blocks): Likewise.
9343         * f-exp.y (%union) <bval>: Remove.
9344         * coffread.c (patch_opaque_types): Make "b" const.
9345         * spu-tdep.c (spu_catch_start): Make "block" const.
9346         * c-valprint.c (print_unpacked_pointer): Remove "block".
9347         * symmisc.c (dump_symtab_1): Make "b" const.
9348         (block_depth): Make "block" const.
9349         * d-exp.y (%union) <bval>: Remove.
9350         * cp-support.h (cp_lookup_rtti_type): Update.
9351         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9352         * psymtab.c (psym_lookup_symbol): Make "block" const.
9353         (maintenance_check_psymtabs): Make "b" const.
9354         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9355         (enumerate_locals, enumerate_args): Update.
9356         * python/py-symtab.c (stpy_global_block): Make "block" const.
9357         (stpy_static_block): Likewise.
9358         * inline-frame.c (block_starting_point_at): Make "new_block"
9359         const.
9360         * block.c (find_block_in_blockvector): Make return type const.
9361         (blockvector_for_pc_sect): Make "b" const.
9362         (find_block_in_blockvector): Make "b" const.
9363
9364 2019-03-23  Tom Tromey  <tom@tromey.com>
9365
9366         * varobj.c (varobj_create): Update.
9367         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9368         * printcmd.c (display_command, do_one_display): Don't reset
9369         innermost_block.
9370         * parser-defs.h (enum innermost_block_tracker_type): Move to
9371         expression.h.
9372         (innermost_block): Update comment.
9373         * parse.c (parse_exp_1): Add tracker_types parameter.
9374         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9375         tracker_types parameter.  Reset innermost_block.
9376         (parse_exp_in_context): Remove.
9377         (parse_expression_for_completion): Update.
9378         * objfiles.c (~objfile): Don't reset expression_context_block or
9379         innermost_block.
9380         * expression.h (enum innermost_block_tracker_type): Move from
9381         parser-defs.h.
9382         (parse_exp_1): Add tracker_types parameter.
9383         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9384         reset innermost_block.
9385
9386 2019-03-23  Tom Tromey  <tom@tromey.com>
9387
9388         * objfiles.h: Include bcache.h.
9389
9390 2019-03-23  Tom Tromey  <tom@tromey.com>
9391
9392         * linespec.c (get_current_search_block): Use
9393         scoped_restore_current_language.
9394         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9395
9396 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9397             Jiong Wang  <jiong.wang@arm.com>
9398
9399         * aarch64-linux-tdep.c
9400         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9401         section.
9402         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9403
9404 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9405             Jiong Wang  <jiong.wang@arm.com>
9406
9407         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9408         instructions.
9409         (aarch64_analyze_prologue_test): Add PACIASP test.
9410         (aarch64_prologue_prev_register): Unmask PC value.
9411
9412 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9413             Jiong Wang  <jiong.wang@arm.com>
9414
9415         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9416         (aarch64_dwarf2_prev_register): Unmask PC value.
9417         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9418         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9419         DW_CFA_AARCH64_negate_ra_state.
9420         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9421
9422 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9423             Jiong Wang  <jiong.wang@arm.com>
9424
9425         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9426         registers.
9427         (aarch64_pseudo_register_name): Likewise.
9428         (aarch64_pseudo_register_type): Likewise.
9429         (aarch64_pseudo_register_reggroup_p): Likewise.
9430         (aarch64_gdbarch_init): Add pauth registers.
9431         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9432         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9433         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9434         (struct gdbarch_tdep): Add regnum for ra_state.
9435
9436 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9437             Jiong Wang  <jiong.wang@arm.com>
9438
9439         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9440
9441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9442             Jiong Wang  <jiong.wang@arm.com>
9443
9444         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9445         function.
9446         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9447         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9448         (aarch64_gdbarch_init): Add puth registers.
9449         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9450         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9451         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9452
9453 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9454             Jiong Wang  <jiong.wang@arm.com>
9455
9456         * aarch64-linux-nat.c
9457         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9458         * aarch64-linux-tdep.c
9459         (aarch64_linux_core_read_description): Likewise.
9460         (aarch64_linux_get_hwcap): New function.
9461         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9462         (aarch64_linux_get_hwcap): New declaration.
9463
9464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9465             Jiong Wang  <jiong.wang@arm.com>
9466
9467         * aarch64-linux-nat.c
9468         (aarch64_linux_nat_target::read_description): Add pauth param.
9469         * aarch64-linux-tdep.c
9470         (aarch64_linux_core_read_description): Likewise.
9471         * aarch64-tdep.c (struct target_desc): Add in pauth.
9472         (aarch64_read_description): Add pauth param.
9473         (aarch64_gdbarch_init): Likewise.
9474         * aarch64-tdep.h (aarch64_read_description): Likewise.
9475         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9476         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9477         * features/Makefile: Add new files.
9478         * features/aarch64-pauth.c: New file.
9479         * features/aarch64-pauth.xml: New file.
9480
9481 2019-03-20  Tom Tromey  <tromey@adacore.com>
9482
9483         * infrun.c (handle_inferior_event): Rename from
9484         handle_inferior_event_1.  Create a scoped_value_mark.
9485         (handle_inferior_event): Remove.
9486
9487 2019-03-19  Tom Tromey  <tromey@adacore.com>
9488
9489         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9490         * infrun.h (print_stop_event): Add "displays" parameter.
9491         * infrun.c (print_stop_event): Add "displays" parameter.
9492
9493 2019-03-19  Pedro Alves  <palves@redhat.com>
9494
9495         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9496         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9497         to -1.  Fix TABs vs spaces.
9498         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9499         * tui/tui-out.h (tui_ui_out) Add intro comments.
9500         <m_line, m_start_of_line>: In-class initialize, and add describing
9501         comment.
9502
9503 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9504
9505         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9506         variable names.
9507         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9508
9509 2019-03-18  Pedro Alves  <palves@redhat.com>
9510             Eli Zaretskii <eliz@gnu.org>
9511
9512         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9513         m_line and m_start_of_line.
9514
9515 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9516
9517         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9518         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9519         it returns a newline.  This fixes a regression in TU mode, whereby
9520         the next line is output on the same screen line as the user input.
9521
9522 2019-03-18  Tom Tromey  <tromey@adacore.com>
9523
9524         * minsyms.c (minimal_symbol_reader::install): Remove call to
9525         obstack_blank.
9526
9527 2019-03-18  Pedro Alves  <palves@redhat.com>
9528
9529         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9530         New globals.
9531         (apply_style): New, factored out from ...
9532         (apply_ansi_escape): ... this.  Handle reverse video mode.
9533         (tui_set_reverse_mode): New function.
9534         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9535         * tui/tui-winsource.c (tui_show_source_line): Use
9536         tui_set_reverse_mode instead of setting A_STANDOUT.
9537         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9538         New setter methods.
9539
9540 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9541
9542         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9543         Handle tabs.
9544
9545 2019-03-18  Tom Tromey  <tromey@adacore.com>
9546
9547         * ada-lang.c (empty_array): Add "high" parameter.
9548         (ada_evaluate_subexp): Update.
9549
9550 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9551
9552         * unittests/string_view-selftests.c: Define
9553         _initialize_string_view_selftests unconditionally.
9554
9555 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9556
9557         PR gdb/24350
9558         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9559
9560 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9561
9562         PR gdb/24351
9563         * windows-nat.c (display_selector): Fix format specifiers.
9564
9565 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9566
9567         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9568         tui_refill_source_window instead of tui_refresh_win, to update the
9569         current execution line.  This fixes redisplay of the current line
9570         when stepping through the code with "next" or "step".
9571
9572 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9573
9574         * source-cache.c (source_cache::get_source_lines): Call
9575         find_source_lines to initialize s->nlines.  This fixes vertical
9576         scrolling of TUI source window when the DOWN arrow is pressed.
9577
9578 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9579
9580         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9581         linux-thread-db.c (_initialize_thread_db): Likewise.
9582
9583 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9584
9585         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9586         wclrtoeol in tui_show_source_line".  This reverts changes made in
9587         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9588
9589 2019-03-15  Tom Tromey  <tom@tromey.com>
9590
9591         * symtab.h (struct minimal_symbol): Derive from
9592         general_symbol_info.
9593         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9594         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9595         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9596         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9597         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9598         (MSYMBOL_SEARCH_NAME): Update.
9599         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9600         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9601         * minsyms.c (minimal_symbol_reader::record_full): Update.
9602
9603 2019-03-15  Tom Tromey  <tom@tromey.com>
9604
9605         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9606
9607 2019-03-15  Tom Tromey  <tom@tromey.com>
9608
9609         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9610         unique_xmalloc_ptr.
9611         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9612         Update.
9613         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9614         (build_minimal_symbol_hash_tables)
9615         (minimal_symbol_reader::install): Update.
9616
9617 2019-03-15  Tom Tromey  <tom@tromey.com>
9618
9619         * symtab.c (create_demangled_names_hash): Update.
9620         (symbol_set_names): Update.
9621         * objfiles.h (struct objfile_per_bfd_storage)
9622         <demangled_names_hash>: Now an htab_up.
9623         * objfiles.c (objfile_per_bfd_storage): Simplify.
9624
9625 2019-03-15  Tom Tromey  <tom@tromey.com>
9626
9627         * objfiles.h (struct objfile_per_bfd_storage): Declare
9628         destructor.
9629         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9630         New.
9631         (get_objfile_bfd_data): Use new.  Don't initialize
9632         language_of_main.
9633         (free_objfile_per_bfd_storage): Remove.
9634         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9635
9636 2019-03-15  Tom Tromey  <tom@tromey.com>
9637
9638         * symfile.c (reread_symbols): Update.
9639         * objfiles.c (objfile::objfile): Update.
9640         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9641         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9642         comment.
9643         (minimal_symbol_reader::install): Update.
9644         (terminate_minimal_symbol_table): Remove.
9645         * jit.c (jit_object_close_impl): Update.
9646
9647 2019-03-15  Tom Tromey  <tom@tromey.com>
9648
9649         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9650         initializations.
9651
9652 2019-03-15  Tom Tromey  <tom@tromey.com>
9653
9654         * objfiles.h (struct objfile_per_bfd_storage)
9655         <demangled_hash_languages>: Now a bitset.
9656         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9657         (lookup_minimal_symbol): Update.
9658
9659 2019-03-15  Tom Tromey  <tom@tromey.com>
9660
9661         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9662         Don't return the symbol.
9663         * coffread.c (record_minimal_symbol): Use record_full.
9664
9665 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9666
9667         The MS-Windows port of ncurses fails to switch to a color pair if
9668         one or both of the colors are the implicit default colors.  This
9669         change records the default colors when TUI is initialized, and
9670         then specifies them explicitly when a color pair uses the default
9671         colors.  This allows color styling in TUI mode on MS-Windows.
9672
9673         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9674         ncurses_norm_attr.
9675         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9676         colors in ncurses_norm_attr.
9677         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9678         "none", replace it with the default color recorded in
9679         ncurses_norm_attr.
9680
9681 2019-03-14  Tom Tromey  <tromey@adacore.com>
9682
9683         * source-cache.h (class source_cache) <get_source_lines>: Return
9684         std::string.
9685         * source-cache.c (source_cache::extract_lines): Handle case where
9686         first_pos==npos.  Return std::string.
9687         (source_cache::get_source_lines): Update.
9688
9689 2019-03-14  Tom Tromey  <tromey@adacore.com>
9690
9691         * NEWS: Add item for "style sources" commands.
9692         * source-cache.c (source_cache::get_source_lines): Check
9693         source_styling.
9694         * cli/cli-style.c (source_styling): New global.
9695         (_initialize_cli_style): Add "style sources" commands.
9696         (show_style_sources): New function.
9697         * cli/cli-style.h (source_styling): Declare.
9698
9699 2019-03-14  Pedro Alves  <palves@redhat.com>
9700             Tom Tromey  <tromey@adacore.com>
9701
9702         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9703         * tui/tui-winsource.c (tui_refill_source_window): New function,
9704         from...
9705         (tui_horizontal_source_scroll): ... here.  Move some logic.
9706         * cli/cli-style.c (set_style_enabled): Notify new observable.
9707         * tui/tui-hooks.c (tui_redisplay_source): New function.
9708         (tui_attach_detach_observers): Attach or detach
9709         tui_redisplay_source.
9710         * observable.h (source_styling_changed): New observable.
9711         * observable.c: Define source_styling_changed observable.
9712
9713 2019-03-13  Tom Tromey  <tromey@adacore.com>
9714
9715         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9716         (i386_gnu_nat_target::store_registers): Update.
9717         * target-debug.h (target_debug_print_std_string): New macro.
9718         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9719         * windows-tdep.c (display_one_tib): Update.
9720         * tui/tui-stack.c (tui_make_status_line): Update.
9721         * top.c (print_inferior_quit_action): Update.
9722         * thread.c (thr_try_catch_cmd): Update.
9723         (add_thread_with_info): Update.
9724         (thread_target_id_str): Update.
9725         (thr_try_catch_cmd): Update.
9726         (thread_command): Update.
9727         (thread_find_command): Update.
9728         * record-btrace.c (record_btrace_target::info_record)
9729         (record_btrace_resume_thread, record_btrace_target::resume)
9730         (record_btrace_cancel_resume, record_btrace_step_thread)
9731         (record_btrace_target::wait, record_btrace_target::wait)
9732         (record_btrace_target::wait, record_btrace_target::stop): Update.
9733         * progspace.c (print_program_space): Update.
9734         * process-stratum-target.c
9735         (process_stratum_target::thread_address_space): Update.
9736         * linux-fork.c (linux_fork_mourn_inferior)
9737         (detach_checkpoint_command, info_checkpoints_command)
9738         (linux_fork_context): Update.
9739         (linux_fork_detach): Update.
9740         (class scoped_switch_fork_info): Update.
9741         (delete_checkpoint_command): Update.
9742         * infrun.c (follow_fork_inferior): Update.
9743         (follow_fork_inferior): Update.
9744         (proceed_after_vfork_done): Update.
9745         (handle_vfork_child_exec_or_exit): Update.
9746         (follow_exec): Update.
9747         (displaced_step_prepare_throw): Update.
9748         (displaced_step_restore): Update.
9749         (start_step_over): Update.
9750         (resume_1): Update.
9751         (clear_proceed_status_thread): Update.
9752         (proceed): Update.
9753         (print_target_wait_results): Update.
9754         (do_target_wait): Update.
9755         (context_switch): Update.
9756         (stop_all_threads): Update.
9757         (restart_threads): Update.
9758         (finish_step_over): Update.
9759         (handle_signal_stop): Update.
9760         (switch_back_to_stepped_thread): Update.
9761         (keep_going_pass_signal): Update.
9762         (print_exited_reason): Update.
9763         (normal_stop): Update.
9764         * inferior.c (inferior_pid_to_str): Change return type.
9765         (print_selected_inferior): Update.
9766         (add_inferior): Update.
9767         (detach_inferior): Update.
9768         * dummy-frame.c (fprint_dummy_frames): Update.
9769         * dcache.c (dcache_info_1): Update.
9770         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9771         (btrace_fetch, btrace_clear): Update.
9772         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9773         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9774         type.
9775         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9776         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9777         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9778         * gdbarch.c, gdbarch.h: Rebuild.
9779         * gdbarch.sh (core_pid_to_str): Change return type.
9780         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9781         return type.
9782         (windows_nat_target::pid_to_str): Change return type.
9783         (windows_delete_thread): Update.
9784         (windows_nat_target::attach): Update.
9785         (windows_nat_target::files_info): Update.
9786         * target-delegates.c: Rebuild.
9787         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9788         return type.
9789         (sol_thread_target::pid_to_str): Change return type.
9790         * remote.c (class remote_target) <pid_to_str>: Change return
9791         type.
9792         (remote_target::pid_to_str): Change return type.
9793         (extended_remote_target::attach, remote_target::remote_stop_ns)
9794         (remote_target::remote_notif_remove_queued_reply)
9795         (remote_target::push_stop_reply, remote_target::disable_btrace):
9796         Update.
9797         (extended_remote_target::attach): Update.
9798         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9799         type.
9800         (gdbsim_target::pid_to_str): Change return type.
9801         * ravenscar-thread.c (struct ravenscar_thread_target)
9802         <pid_to_str>: Change return type.
9803         (ravenscar_thread_target::pid_to_str): Change return type.
9804         * procfs.c (class procfs_target) <pid_to_str>: Change return
9805         type.
9806         (procfs_target::pid_to_str): Change return type.
9807         (procfs_target::attach): Update.
9808         (procfs_target::detach): Update.
9809         (procfs_target::fetch_registers): Update.
9810         (procfs_target::store_registers): Update.
9811         (procfs_target::wait): Update.
9812         (procfs_target::files_info): Update.
9813         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9814         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9815         return type.
9816         (nto_procfs_target::pid_to_str): Change return type.
9817         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9818         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9819         return type.
9820         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9821         (exit_lwp): Update.
9822         (attach_proc_task_lwp_callback, get_detach_signal)
9823         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9824         (linux_nat_target::resume, wait_lwp, stop_callback)
9825         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9826         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9827         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9828         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9829         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9830         type.
9831         (inf_ptrace_target::attach): Update.
9832         (inf_ptrace_target::files_info): Update.
9833         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9834         type.
9835         (go32_nat_target::pid_to_str): Change return type.
9836         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9837         (gnu_nat_target::wait): Update.
9838         (gnu_nat_target::wait): Update.
9839         (gnu_nat_target::resume): Update.
9840         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9841         (fbsd_nat_target::wait): Update.
9842         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9843         type.
9844         (darwin_nat_target::attach): Update.
9845         * corelow.c (class core_target) <pid_to_str>: Change return type.
9846         (core_target::pid_to_str): Change return type.
9847         * target.c (normal_pid_to_str): Change return type.
9848         (default_pid_to_str): Likewise.
9849         (target_pid_to_str): Change return type.
9850         (target_translate_tls_address): Update.
9851         (target_announce_detach): Update.
9852         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9853         return type.
9854         (bsd_uthread_target::pid_to_str): Change return type.
9855         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9856         type.
9857         (bsd_kvm_target::pid_to_str): Change return type.
9858         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9859         return type.
9860         (aix_thread_target::pid_to_str): Change return type.
9861         * target.h (struct target_ops) <pid_to_str>: Change return type.
9862         (target_pid_to_str, normal_pid_to_str): Likewise.
9863         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9864         type.
9865         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9866         type.
9867         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9868         return type.
9869         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9870         type.
9871         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9872         type.
9873         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9874         return type.
9875
9876 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9877
9878         * NEWS: Mention that the new default MI version is 3.  Mention
9879         changes to the output of commands and events that deal with
9880         multi-location breakpoints.
9881         * breakpoint.c: Include "mi/mi-out.h".
9882         (print_one_breakpoint): Change output syntax if using MI version
9883         >= 3.
9884         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9885         New.
9886         (mi_multi_location_breakpoint_output_fixed): New.
9887         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9888         (mi_cmd_fix_multi_location_breakpoint_output): New.
9889         (mi_multi_location_breakpoint_output_fixed): New.
9890         * mi/mi-cmds.c (mi_cmds): Register command
9891         -fix-multi-location-breakpoint-output.
9892         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9893         interpreter "mi".
9894
9895 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9896
9897         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9898         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9899         instantiate mi_ui_out based on interpreter name.
9900         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9901         * mi/mi-main.c (mi_load_progress): Likewise.
9902
9903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9904
9905         * NEWS: Combine separate "New targets" sections for 8.3.
9906
9907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9908
9909         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9910         (ppcfbsd_init_abi): Install gdbarch
9911         "fetch_tls_load_module_address" and "get_thread_local_address"
9912         methods.
9913
9914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9915
9916         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9917         (riscv_fbsd_init_abi): Install gdbarch
9918         "fetch_tls_load_module_address" and "get_thread_local_address"
9919         methods.
9920
9921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9922
9923         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9924         (i386fbsd_init_abi): Install gdbarch
9925         "fetch_tls_load_module_address" and "get_thread_local_address"
9926         methods.
9927
9928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9929
9930         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9931         (amd64fbsd_init_abi): Install gdbarch
9932         "fetch_tls_load_module_address" and "get_thread_local_address"
9933         methods.
9934
9935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9936
9937         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9938         (struct fbsd_pspace_data): New type.
9939         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9940         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9941         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9942         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9943         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9944
9945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9946
9947         * gdbtypes.c (lookup_struct_elt): New function.
9948         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9949         * gdbtypes.h (struct struct_elt): New type.
9950         (lookup_struct_elt): New prototype.
9951
9952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9953
9954         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9955         remove disabled code block.
9956
9957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9958
9959         * gdbarch.sh (get_thread_local_address): New method.
9960         * gdbarch.h, gdbarch.c: Regenerate.
9961         * target.c (target_translate_tls_address): Use
9962         gdbarch_get_thread_local_address if present instead of
9963         target::get_thread_local_address.
9964
9965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9966
9967         * target.h (target::get_thread_local_address): Update comment.
9968
9969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9970
9971         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9972         objfile->separate_debug_objfile_backlink if not NULL.
9973
9974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9975
9976         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9977         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9978         (amd64bsd_store_inferior_registers): Likewise.
9979         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9980         Enable segment base registers.
9981         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9982         PT_GETFSBASE and PT_GETGSBASE.
9983         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9984         PT_SETGSBASE.
9985         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9986         segment base registers.
9987         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9988
9989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9990
9991         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9992         Update calls to i386_target_description to add 'segments'
9993         parameter.
9994         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9995         add segment base registers.
9996         * arch/i386.c (i386_create_target_description): Add 'segments'
9997         parameter to enable segment base registers.
9998         * arch/i386.h (i386_create_target_description): Likewise.
9999         * features/i386/32bit-segments.xml: New file.
10000         * features/i386/32bit-segments.c: Generate.
10001         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10002         call to i386_target_description to add 'segments' parameter.
10003         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10004         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10005         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10006         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10007         if feature is present.
10008         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10009         Add 'segments' parameter to call to i386_target_description.
10010         (i386_target_description): Add 'segments' parameter to enable
10011         segment base registers.
10012         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10013         to call to i386_target_description.
10014         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10015         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10016         Define I386_NUM_REGS.
10017         (i386_target_description): Add 'segments' parameter to enable
10018         segment base registers.
10019
10020 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10021
10022         PR/24325
10023         * source-cache.c: #undef open and close, to avoid unresolved
10024         externals during linking.
10025
10026 2019-03-12  Tom Tromey  <tromey@adacore.com>
10027
10028         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10029         const.  Add initializers.
10030         (_initialize_remote): Don't initialize ptid globals.
10031
10032 2019-03-12  Pedro Alves  <palves@redhat.com>
10033
10034         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10035
10036 2019-03-12  Pedro Alves  <palves@redhat.com>
10037
10038         * cp-name-parser.y (main): Remove unused 'len' variable.
10039
10040 2019-03-12  Tom Tromey  <tromey@adacore.com>
10041
10042         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10043         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10044
10045 2019-03-12  Tom Tromey  <tromey@adacore.com>
10046
10047         * linux-nat.c (iterate_over_lwps): Update.
10048         (stop_callback): Remove parameter.
10049         (stop_wait_callback, detach_callback, resume_set_callback)
10050         (select_singlestep_lwp_callback, set_ignore_sigint)
10051         (status_callback, resumed_callback, resume_clear_callback)
10052         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10053         data parameter.
10054         (linux_nat_target::detach, linux_nat_target::resume)
10055         (linux_stop_and_wait_all_lwps, select_event_lwp)
10056         (linux_nat_filter_event, linux_nat_wait_1)
10057         (linux_nat_target::kill, linux_nat_target::stop)
10058         (linux_nat_target::stop): Update.
10059         (linux_nat_resume_callback): Change type.
10060         (resume_stopped_resumed_lwps, count_events_callback)
10061         (select_event_lwp_callback): Likewise.
10062         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10063         * arm-linux-nat.c (struct update_registers_data): Remove.
10064         (update_registers_callback): Change type.
10065         (arm_linux_insert_hw_breakpoint1): Update.
10066         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10067         parameter.
10068         (x86_linux_dr_set_addr): Update.
10069         (x86_linux_dr_set_control): Update.
10070         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10071         (iterate_over_lwps): Use gdb::function_view.
10072         * nat/aarch64-linux-hw-point.c (struct
10073         aarch64_dr_update_callback_param): Remove.
10074         (debug_reg_change_callback): Change type.
10075         (aarch64_notify_debug_reg_change): Update.
10076         * s390-linux-nat.c (s390_refresh_per_info): Update.
10077
10078 2019-03-11  Tom Tromey  <tromey@adacore.com>
10079
10080         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10081         redundant assignment to "this_cu".
10082
10083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10084
10085         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10086
10087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10088
10089         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10090         from...
10091         (rank_one_type): ... this.
10092
10093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10094
10095         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10096         from...
10097         (rank_one_type): ... this.
10098
10099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10100
10101         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10102         from...
10103         (rank_one_type): ... this.
10104
10105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10106
10107         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10108         from...
10109         (rank_one_type): ... this.
10110
10111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10112
10113         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10114         from...
10115         (rank_one_type): ... this.
10116
10117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10118
10119         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10120         from...
10121         (rank_one_type): ... this.
10122
10123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10124
10125         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10126         from...
10127         (rank_one_type): ... this.
10128
10129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10130
10131         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10132         from...
10133         (rank_one_type): ... this.
10134
10135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10136
10137         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10138         from...
10139         (rank_one_type): ... this.
10140
10141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10142
10143         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10144         from...
10145         (rank_one_type): ... this.
10146
10147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10148
10149         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10150         from...
10151         (rank_one_type): ... this.
10152
10153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10154
10155         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10156         from...
10157         (rank_one_type): ... this.
10158
10159 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10160
10161         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10162         inferior-events' shows the example events.
10163
10164 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10165
10166         Support styling on native MS-Windows console
10167
10168         PR/24315
10169         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10170         on MS-Windows if $TERM is not defined.
10171
10172         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10173
10174         * posix-hdep.c (gdb_console_fputs):
10175         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10176         functions.
10177         * ui-file.h (gdb_console_fputs): Add prototype.
10178
10179         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10180         back to fputs only if the former returns zero.
10181
10182 2019-03-07  Tom Tromey  <tom@tromey.com>
10183
10184         * symmisc.c (print_symbol_bcache_statistics): Update.
10185         (print_objfile_statistics): Update.
10186         * symfile.c (allocate_symtab): Update.
10187         * stabsread.c: Don't include bcache.h.
10188         * psymtab.h (struct psymbol_bcache): Don't declare.
10189         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10190         (psymbol_bcache_init, psymbol_bcache_free)
10191         (psymbol_bcache_get_bcache): Don't declare.
10192         * psymtab.c (struct psymbol_bcache): Remove.
10193         (psymtab_storage::psymtab_storage): Update.
10194         (psymtab_storage::~psymtab_storage): Update.
10195         (psymbol_bcache_init, psymbol_bcache_free)
10196         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10197         (add_psymbol_to_bcache): Update.
10198         (allocate_psymtab): Update.
10199         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10200         macro_cache>: No longer pointers.
10201         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10202         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10203         * macrotab.c (macro_bcache): Update.
10204         * macroexp.c: Don't include bcache.h.
10205         * gdbtypes.c (check_types_worklist): Update.
10206         (types_deeply_equal): Remove TRY/CATCH.  Update.
10207         * elfread.c (elf_symtab_read): Update.
10208         * dwarf2read.c: Don't include bcache.h.
10209         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10210         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10211         (print_bcache_statistics, bcache_memory_used): Don't declare.
10212         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10213         methods.  Rename all data members.
10214         * bcache.c (struct bcache): Move to bcache.h.
10215         (bcache::expand_hash_table): Rename from expand_hash_table.
10216         (bcache): Remove.
10217         (bcache::insert): Rename from bcache_full.
10218         (bcache::compare): Rename from bcache_compare.
10219         (bcache_xmalloc): Remove.
10220         (bcache::~bcache): Rename from bcache_xfree.
10221         (bcache::print_statistics): Rename from print_bcache_statistics.
10222         (bcache::memory_used): Rename from bcache_memory_used.
10223
10224 2019-03-07  Pedro Alves  <palves@redhat.com>
10225
10226         * infrun.c (normal_stop): Also check for
10227         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10228
10229 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10230
10231         * f-lang.c (value_from_host_double): Moved to...
10232         * value.c (value_from_host_double): ...here.
10233         * value.h (value_from_host_double): Declare.
10234         * guile/scm-math.c (vlscm_convert_typed_number): Use
10235         value_from_host_double.
10236         (vlscm_convert_number): Likewise.
10237         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10238         * python/py-value.c (convert_value_from_python): Likewise.
10239
10240 2019-03-06  Tom Tromey  <tom@tromey.com>
10241
10242         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10243
10244 2019-03-06  Tom Tromey  <tom@tromey.com>
10245
10246         * utils.h (free_current_contents): Don't declare.
10247         * utils.c (free_current_contents): Remove.
10248
10249 2019-03-06  Tom Tromey  <tom@tromey.com>
10250
10251         * top.c (quit_force): Update.
10252         * main.c (captured_command_loop): Update.
10253         * common/new-op.c (operator new): Update.
10254         * common/common-exceptions.c (struct catcher)
10255         <save_cleanup_chain>: Remove member.
10256         (exceptions_state_mc_init): Update.
10257         (exception_try_scope_entry): Return nullptr.
10258         (exception_try_scope_exit, exception_rethrow)
10259         (throw_exception_sjlj, throw_exception_cxx): Update.
10260         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10261         (all_cleanups, do_cleanups, discard_cleanups)
10262         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10263         (restore_cleanups, restore_final_cleanups): Don't declare.
10264         (do_final_cleanups): Remove parameter.
10265         * common/cleanups.c (cleanup_chain, make_cleanup)
10266         (make_cleanup_dtor, all_cleanups, do_cleanups)
10267         (discard_my_cleanups, discard_cleanups)
10268         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10269         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10270         (null_cleanup): Remove.
10271         (do_final_cleanups): Remove parameter.
10272
10273 2019-03-06  Tom Tromey  <tom@tromey.com>
10274
10275         * remote.c (remote_target::remote_parse_stop_reply): Use
10276         unique_xmalloc_ptr.
10277
10278 2019-03-06  Tom Tromey  <tom@tromey.com>
10279
10280         * stabsread.c (struct stabs_field_info): Rename from field_info.
10281         <list, fnlist>: Add initializers.
10282         <obstack>: New member.
10283         (read_member_functions, read_struct_fields, read_baseclasses):
10284         Allocate on obstack.  Don't use cleanups.
10285         (read_one_struct_field, read_member_functions, read_struct_fields)
10286         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10287         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10288         (read_struct_type): Update.
10289
10290 2019-03-06  Tom Tromey  <tom@tromey.com>
10291
10292         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10293         * common/filestuff.h (make_cleanup_close): Don't declare.
10294         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10295         Remove.
10296
10297 2019-03-06  Tom Tromey  <tom@tromey.com>
10298
10299         * solib-aix.c: Use make_scope_exit.
10300
10301 2019-03-06  Tom Tromey  <tom@tromey.com>
10302
10303         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10304         Use make_scope_exit.
10305
10306 2019-03-06  Tom Tromey  <tom@tromey.com>
10307
10308         * solib-svr4.c (disable_probes_interface): Remove parameter.
10309         (svr4_handle_solib_event): Use make_scope_exit.
10310
10311 2019-03-06  Tom Tromey  <tom@tromey.com>
10312
10313         * remote.c (struct stop_reply_deleter): Remove.
10314         (stop_reply_up): Update.
10315         (struct stop_reply): Derive from notif_event.  Don't typedef.
10316         <regcache>: Now a std::vector.
10317         (stop_reply_xfree): Remove.
10318         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10319         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10320         (remote_target::discard_pending_stop_replies): Use delete.
10321         (remote_target::remote_parse_stop_reply): Update.
10322         (remote_target::process_stop_reply): Update.
10323         * remote-notif.h (struct notif_event): Add virtual destructor.
10324         Remove "dtr" member.
10325         (struct notif_client) <alloc_event>: Return a unique_ptr.
10326         (notif_event_xfree): Don't declare.
10327         (notif_event_up): New typedef.
10328         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10329         (notif_event_xfree, do_notif_event_xfree): Remove.
10330         (remote_notif_state_xfree): Update.
10331
10332 2019-03-06  Tom Tromey  <tom@tromey.com>
10333
10334         * infrun.c (displaced_step_clear_cleanup): Now a
10335         forward_scope_exit type.
10336         (displaced_step_prepare_throw): Update.
10337         (displaced_step_fixup): Update.
10338
10339 2019-03-06  Tom Tromey  <tom@tromey.com>
10340
10341         * inferior.h (class inferior): Update comment.
10342         * gdbthread.h (class thread_info): Update comment.
10343
10344 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10345             Tom Tromey  <tom@tromey.com>
10346
10347         * stabsread.h (struct stab_section_list): Remove.
10348         (coffstab_build_psymtabs): Update.
10349         * dbxread.c (symbuf_sections): Now a std::vector.
10350         (sect_idx): New global.
10351         (fill_symbuf): Update.
10352         (coffstab_build_psymtabs): Change type of stabsects parameter.
10353         Update.
10354         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10355         std::vector.
10356         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10357         (coff_locate_sections): Update.
10358         (coff_symfile_read): Remove cleanups.  Update.
10359         (init_stringtab): Add storage parameter.
10360         (free_stringtab, free_stringtab_cleanup): Remove.
10361         (init_lineno): Add storage parameter.
10362         (free_linetab, free_linetab_cleanup): Remove.
10363
10364 2019-03-06  Pedro Alves  <palves@redhat.com>
10365
10366         * linux-fork.c (fork_info::clobber_regs): Delete.
10367         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10368         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10369         comment.  Adjust.
10370         (scoped_switch_fork_info::scoped_switch_fork_info)
10371         (checkpoint_command, linux_fork_context): Adjust
10372         fork_save_infrun_state calls.
10373
10374 2019-03-06  Pedro Alves  <palves@redhat.com>
10375
10376         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10377         (inf_has_multiple_threads): Return 'bool' and rewrite using
10378         inferior_info::threads().
10379
10380 2019-03-06  Pedro Alves  <palves@redhat.com>
10381
10382         * linux-fork.c: Include <list>.
10383         (fork_list): Now a std::list instance.
10384         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10385         (forks_exist_p, find_last_fork): Adjust.
10386         (new_fork): Delete.
10387         (one_fork_p): New.
10388         (add_fork): Adjust.
10389         (free_fork): Delete, folded into fork_info::~fork_info().
10390         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10391         Adjust.
10392         (init_fork_list): Delete.
10393         (linux_fork_killall, linux_fork_mourn_inferior)
10394         (linux_fork_detach, info_checkpoints_command): Adjust.
10395         (_initialize_linux_fork): No longer call init_fork_list.
10396
10397 2019-03-06  Pedro Alves  <palves@redhat.com>
10398
10399         * linux-fork.c (new_fork): New, split out of ...
10400         (add_fork): ... this.  Return void.  Move "first fork" special
10401         case from here, to ...
10402         (checkpoint_command): ... here.
10403         * linux-linux.h (add_fork): Return void.
10404
10405 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10406
10407         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10408
10409 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10410             Chris January  <chris.january@arm.com>
10411             David Lecomber  <david.lecomber@arm.com>
10412
10413         * f-exp.y: New token, UNOP_INTRINSIC.
10414         (exp): New pattern using UNOP_INTRINSIC token.
10415         (f77_keywords): Add 'abs' keyword.
10416         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10417         (value_from_host_double): New function.
10418         (evaluate_subexp_f): Support UNOP_ABS.
10419
10420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10421
10422         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10423         types.
10424
10425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10428         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10429         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10430
10431 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10432
10433         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10434
10435 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10436             Chris January  <chris.january@arm.com>
10437
10438         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10439         * f-exp.y: Define 'KIND' token.
10440         (exp): New pattern for KIND expressions.
10441         (ptype): Handle types with a kind extension.
10442         (direct_abs_decl): Extend to spot kind extensions.
10443         (f77_keywords): Add 'kind' to the list.
10444         (push_kind_type): New function.
10445         (convert_to_kind_type): New function.
10446         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10447         * parse.c (operator_length_standard): Likewise.
10448         * parser-defs.h (enum type_pieces): Add tp_kind.
10449         * std-operator.def: Add UNOP_KIND.
10450
10451 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10452
10453         * f-exp.y (f_parse): Set yydebug.
10454
10455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10456
10457         * f-lang.c (evaluate_subexp_f): New function.
10458         (exp_descriptor_f): New global.
10459         (f_language_defn): Use exp_descriptor_f instead of
10460         exp_descriptor_standard.
10461
10462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10463
10464         * f-exp.y (struct token): Add comments.
10465         (dot_ops): Remove uppercase versions and the end marker.
10466         (f77_keywords): Likewise.
10467         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10468         entries in the dot_ops array are case insensitive, and use
10469         strncasecmp to compare strings.  Also some whitespace cleanup in
10470         this area.  Similar for the f77_keywords array, except entries in
10471         this list might be case sensitive.
10472
10473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10474
10475         * f-exp.y (struct f77_boolean_val): Add comments.
10476         (boolean_values): Remove uppercase versions, and end marker.
10477         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10478         and use strncasecmp to achieve case insensitivity.  Additionally,
10479         perform whitespace cleanup around this code.
10480
10481 2019-03-06  Tom Tromey  <tromey@adacore.com>
10482
10483         * remote-sim.c (gdbsim_target_open): Use result of
10484         gdb_argv::release.
10485
10486 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10487         Dirk Schubert  <dirk.schubert@arm.com>
10488         Chris January  <chris.january@arm.com>
10489
10490         * eval.c (evaluate_subexp_standard): Call Fortran argument
10491         wrapping logic.
10492         * f-lang.c (struct value): A value which can be passed into a
10493         Fortran function call.
10494         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10495         where appropriate.
10496         (struct type): Value ready for a Fortran function call.
10497         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10498         is needed.
10499         * f-lang.h (fortran_argument_convert): Declaration.
10500         (fortran_preserve_arg_pointer): Declaration.
10501         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10502
10503 2019-03-05  Tom Tromey  <tromey@adacore.com>
10504
10505         * python/py-prettyprint.c (print_string_repr): Remove #if.
10506         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10507
10508 2019-03-05  Tom Tromey  <tromey@adacore.com>
10509
10510         * target.c (the_dummy_target): Move later.  Change type to
10511         "dummy_target".
10512         (initialize_targets): Don't initialize the_dummy_target.
10513
10514 2019-03-05  Tom Tromey  <tromey@adacore.com>
10515
10516         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10517         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10518
10519 2019-03-05  Tom Tromey  <tromey@adacore.com>
10520
10521         * windows-nat.c (windows_nat_target::attach)
10522         (windows_nat_target::detach): Don't call gdb_flush.
10523         * valprint.c (generic_val_print, val_print, val_print_string):
10524         Don't call gdb_flush.
10525         * utils.c (defaulted_query): Don't call gdb_flush.
10526         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10527         * target.c (target_announce_detach): Don't call gdb_flush.
10528         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10529         * remote.c (extended_remote_target::attach): Don't call
10530         gdb_flush.
10531         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10532         * printcmd.c (do_examine): Don't call gdb_flush.
10533         (info_display_command): Don't call gdb_flush.
10534         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10535         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10536         * memattr.c (info_mem_command): Don't call gdb_flush.
10537         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10538         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10539         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10540         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10541         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10542         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10543         (gnu_nat_target::detach): Don't call gdb_flush.
10544         * f-valprint.c (f_val_print): Don't call gdb_flush.
10545         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10546         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10547         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10548         gdb_flush.
10549         * c-valprint.c (c_val_print): Don't call gdb_flush.
10550         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10551
10552 2019-03-05  Tom Tromey  <tromey@adacore.com>
10553
10554         * varobj.c (update_dynamic_varobj_children): Update.
10555         (install_default_visualizer): Use reset, not release.
10556         * value.c (set_internalvar): Update.
10557         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10558         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10559         ATTRIBUTE_UNUSED_RESULT.
10560
10561 2019-03-05  Tom Tromey  <tromey@adacore.com>
10562
10563         * remote.c (class scoped_remote_fd) <release>: Add
10564         ATTRIBUTE_UNUSED_RESULT.
10565
10566 2019-03-05  Tom Tromey  <tromey@adacore.com>
10567
10568         * macroexp.c (struct macro_buffer) <release>: Add
10569         ATTRIBUTE_UNUSED_RESULT.
10570
10571 2019-03-05  Tom Tromey  <tromey@adacore.com>
10572
10573         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10574         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10575         ATTRIBUTE_UNUSED_RESULT.
10576
10577 2019-03-05  Tom Tromey  <tromey@adacore.com>
10578
10579         * common/scoped_fd.h (class scoped_fd) <release>: Add
10580         ATTRIBUTE_UNUSED_RESULT.
10581
10582 2019-03-05  Tom Tromey  <tromey@adacore.com>
10583
10584         * parser-defs.h (struct parser_state) <release>: Add
10585         ATTRIBUTE_UNUSED_RESULT.
10586
10587 2019-03-05  Tom Tromey  <tromey@adacore.com>
10588
10589         * utils.h (class gdb_argv) <release>: Add
10590         ATTRIBUTE_UNUSED_RESULT.
10591         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10592
10593 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10594
10595         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10596         for-loop range, to avoid compiler warnings.
10597
10598         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10599         avoid compiler warnings about unused variables.
10600
10601         * NEWS: Mention end of support for native debugging on MS-Windows
10602         before XP.
10603
10604         PR gdb/24292
10605         * common/netstuff.c:
10606         * gdbserver/gdbreplay.c
10607         * gdbserver/remote-utils.c:
10608         * ser-tcp.c:
10609         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10610         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10611         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10612         'getaddrinfo' and 'freeaddrinfo' were not available before
10613         Windows XP, and mingw.org's MinGW headers by default define
10614         _WIN32_WINNT to 0x500.
10615
10616 2019-03-01  Gary Benson <gbenson@redhat.com>
10617
10618         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10619
10620 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10621             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10622
10623         PR gdb/8527
10624         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10625         set_sigint_trap, clear_sigint_trap.
10626
10627 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10628
10629         * target.c (target_detach): Clear the regcache and the
10630         frame cache.
10631
10632 2019-02-27  Pedro Alves  <palves@redhat.com>
10633
10634         * utils.c (set_screen_size): When we cap the height/width sizes,
10635         tweak the corresponding command variable to show "unlimited":
10636
10637 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10638             Pedro Alves  <palves@redhat.com>
10639
10640         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10641         before calling rl_set_screen_size.
10642
10643 2019-02-27  Tom Tromey  <tromey@adacore.com>
10644
10645         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10646         define.
10647         * python/py-value.c: Remove Python 2.4 workaround.
10648         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10649         workaround.
10650         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10651         Python 2.4 workaround.
10652         * python/python-internal.h: Remove Python 2.4 comment.
10653         (Py_ssize_t): Don't define.
10654         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10655         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10656         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10657         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10658         * python/python.c (do_start_initialization): Remove Python 2.4
10659         workaround.
10660         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10661         (print_children): Remove Python 2.4 workaround.
10662         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10663         workaround.
10664         (CHARBUFFERPROC_NAME): Remove.
10665         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10666         Python 2.4 workaround.
10667
10668 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10669
10670         * NEWS: Note minimum Python version.
10671
10672 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10673
10674         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10675         code from these functions.  Remove corresponding ifdefs.  Use
10676         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10677         Remove gotos and target of gotos.
10678         (infpy_search_memory): Likewise.
10679
10680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10681
10682         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10683         (hppa_gdbarch_init): Don't register deleted functions with
10684         gdbarch.
10685
10686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10687
10688         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10689         (h8300_unwind_sp): Delete.
10690         (h8300_dummy_id): Delete.
10691         (h8300_gdbarch_init): Don't register deleted functions with
10692         gdbarch.
10693
10694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10695
10696         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10697         (ft32_unwind_pc): Delete.
10698         (ft32_unwind_sp): Delete.
10699         (ft32_gdbarch_init): Don't register deleted functions with
10700         gdbarch.
10701
10702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10703
10704         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10705         (frv_unwind_pc): Delete.
10706         (frv_unwind_sp): Delete.
10707         (frv_gdbarch_init): Don't register deleted functions with
10708         gdbarch.
10709
10710 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10711
10712         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10713         (riscv_unwind_pc): Delete.
10714         (riscv_unwind_sp): Delete.
10715         (riscv_gdbarch_init): Don't register deleted functions with
10716         gdbarch.
10717
10718 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10719
10720         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10721         (csky_unwind_pc): Delete.
10722         (csky_unwind_sp): Delete.
10723         (csky_gdbarch_init): Don't register deleted functions with
10724         gdbarch.
10725
10726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10727
10728         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10729         (cris_unwind_pc): Delete.
10730         (cris_unwind_sp): Delete.
10731         (cris_gdbarch_init): Don't register deleted functions with
10732         gdbarch.
10733
10734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10735
10736         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10737         (bfin_unwind_pc): Delete.
10738         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10739
10740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10741
10742         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10743         (arm_unwind_pc): Delete.
10744         (arm_unwind_sp): Delete.
10745         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10746
10747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10748
10749         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10750         (arc_unwind_pc): Delete.
10751         (arc_unwind_sp): Delete.
10752         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10753
10754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10755
10756         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10757         (alpha_unwind_pc): Delete.
10758         (alpha_gdbarch_init): Don't register deleted functions with
10759         gdbarch.
10760
10761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10762
10763         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10764         (aarch64_unwind_pc): Delete.
10765         (aarch64_unwind_sp): Delete.
10766         (aarch64_gdbarch_init): Don't register deleted functions with
10767         gdbarch.
10768
10769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10770
10771         * gdbtypes.c (type_align): Don't consider static members when
10772         computing structure alignment.
10773
10774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10775
10776         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10777         return 0 for other types.
10778         * arch-utils.c (default_type_align): Always return 0.
10779         * gdbarch.h: Regenerate.
10780         * gdbarch.sh (type_align): Extend comment.
10781         * gdbtypes.c (type_align): Add additional comments, always call
10782         gdbarch_type_align before applying the default rules.
10783         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10784         generic code will then apply a suitable default.
10785         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10786         types, return 0 for other types.
10787
10788 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10789
10790         * NEWS: Create a new section for the next release branch.
10791         Rename the section of the current branch, now that it has
10792         been cut.
10793
10794 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10795
10796         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10797         * version.in: Bump version to 8.3.50.DATE-git.
10798
10799 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10800
10801         * aix-thread.c (ptid_cmp): Remove unused variable.
10802         (get_signaled_thread): Likewise.
10803         (store_regs_user_thread): Likewise.
10804         (store_regs_kernel_thread): Likewise.
10805         (fetch_regs_kernel_thread): Remove shadowed variable.
10806
10807 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * features/riscv/32bit-cpu.xml: Add register numbers.
10810         * features/riscv/32bit-fpu.c: Regenerate.
10811         * features/riscv/32bit-fpu.xml: Add register numbers.
10812         * features/riscv/64bit-cpu.xml: Add register numbers.
10813         * features/riscv/64bit-fpu.c: Regenerate.
10814         * features/riscv/64bit-fpu.xml: Add register numbers.
10815
10816 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10817
10818         * NEWS: Mention two argument form of gdb.Value constructor.
10819         * python/py-value.c (convert_buffer_and_type_to_value): New
10820         function.
10821         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10822         Add support for handling an optional second argument.  Call
10823         convert_buffer_and_type_to_value as appropriate.
10824         * python/python-internal.h (Py_buffer_deleter): New struct.
10825         (Py_buffer_up): New typedef.
10826
10827 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10828
10829         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10830         instead of releasing ownership.
10831
10832 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10833
10834         * dwarf2read.c (open_and_init_dwp_file): Call
10835         elf_numsections instead of bfd_count_sections to initialize
10836         dwp_file->num_sections.
10837
10838 2019-02-25  Tom Tromey  <tromey@adacore.com>
10839
10840         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10841
10842 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10843
10844         * gcore.in: Add '--readnever' option when invoking GDB.
10845
10846 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10847
10848         * MAINTAINERS: Update my email address.
10849
10850 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10851
10852         * build-id.c (build_id_to_debug_bfd_1): New function.
10853         (build_id_to_debug_bfd): Look for separate debug file in
10854         sysroot.
10855
10856 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10857
10858         * gdbarch.sh: Update the copyright year range that is placed into
10859         generated files.
10860
10861 2019-02-22  Keith Seitz  <keiths@redhat.com>
10862
10863         PR symtab/23853
10864         * linespec.c (create_sals_line_offset): Search for the default
10865         symtab's filename instead of its fullname.
10866
10867 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10868
10869         * NEWS: Update style defaults.
10870
10871 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10872
10873         * main.c (captured_main_1): Disable styling in batch mode.
10874
10875 2019-02-20  Tom Tromey  <tom@tromey.com>
10876
10877         * symtab.c (symtab_symbol_info): Fix typos.
10878
10879 2019-02-20  Tom Tromey  <tromey@adacore.com>
10880
10881         * findcmd.c (_initialize_mem_search): Use upper case for
10882         metasyntactic variables.
10883
10884 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10885
10886         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10887         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10888
10889 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10890
10891         * top.h (source_file_name): Change to std::string.
10892         * top.c (source_file_name): Likewise.
10893         (command_line_input): Adjust.
10894         * cli/cli-script.c (script_from_file): Adjust.
10895
10896 2019-02-19  Tom Tromey  <tromey@adacore.com>
10897
10898         * ravenscar-thread.c
10899         (ravenscar_thread_target::update_thread_list): Don't call
10900         ada_build_task_list.
10901         * ada-lang.h (ada_build_task_list): Don't declare.
10902         * ada-tasks.c (struct ada_tasks_inferior_data)
10903         <task_list_valid_p>: Now bool.
10904         (read_known_tasks, ada_task_list_changed)
10905         (ada_tasks_invalidate_inferior_data): Update.
10906         (read_known_tasks_array): Return bool.
10907         (read_known_tasks_list): Likewise.
10908         (read_known_tasks): Return void.
10909         (ada_build_task_list): Now static.
10910
10911 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10912
10913         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10914         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10915
10916 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10917
10918         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10919         variant for ada_tasks_pspace_data_handle and
10920         ada_tasks_inferior_data_handle.
10921         (ada_tasks_pspace_data_cleanup): New function.
10922         (ada_tasks_inferior_data_cleanup): New function.
10923
10924 2019-02-17  Tom Tromey  <tom@tromey.com>
10925
10926         * macrotab.h (macro_source_fullname): Return a std::string.
10927         * macrotab.c (macro_include, check_for_redefinition)
10928         (macro_undef, macro_lookup_definition, foreach_macro)
10929         (foreach_macro_in_scope): Update.
10930         (macro_source_fullname): Return a std::string.
10931         * macrocmd.c (show_pp_source_pos): Update.
10932
10933 2019-02-17  Tom Tromey  <tom@tromey.com>
10934
10935         * macrocmd.c (show_pp_source_pos): Style the file names.
10936
10937 2019-02-17  Tom Tromey  <tom@tromey.com>
10938
10939         PR tui/24197:
10940         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10941
10942 2019-02-17  Tom Tromey  <tom@tromey.com>
10943
10944         * ada-lang.c (user_select_syms): Use filtered printing.
10945         * utils.c (wrap_style): New global.
10946         (desired_style): Remove.
10947         (emit_style_escape): Add stream parameter.
10948         (set_output_style, reset_terminal_style, prompt_for_continue):
10949         Update.
10950         (flush_wrap_buffer): Only flush gdb_stdout.
10951         (wrap_here): Set wrap_style.
10952         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10953         treat escape sequences as a character.  Change when wrap buffer is
10954         flushed.
10955         (fputs_styled): Do not set the output style when the default is
10956         requested.
10957         * ui-style.h (struct ui_file_style) <is_default>: New method.
10958         * source.c (print_source_lines_base): Emit escape sequences in one
10959         piece.
10960
10961 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10962
10963         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10964         integers and enumeration types.
10965
10966 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10967
10968         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10969         instead of lookup_symbol_in_language
10970         (do_exact_match): New function.
10971         (ada_get_symbol_name_matcher): Return do_exact_match when
10972         doing a verbatim match.
10973
10974 2019-02-15  Tom Tromey  <tromey@adacore.com>
10975
10976         * ravenscar-thread.c (ravenscar_thread_target::resume)
10977         (ravenscar_thread_target::wait): Special case wildcard requests.
10978
10979 2019-02-15  Tom Tromey  <tromey@adacore.com>
10980
10981         * ravenscar-thread.c (base_ptid): Remove.
10982         (struct ravenscar_thread_target) <close>: New method.
10983         <m_base_ptid>: New member.
10984         <update_inferior_ptid, active_task, task_is_currently_active,
10985         runtime_initialized>: Declare methods.
10986         <ravenscar_thread_target>: Add constructor.
10987         (ravenscar_thread_target::task_is_currently_active)
10988         (ravenscar_thread_target::update_inferior_ptid)
10989         (ravenscar_runtime_initialized): Rename.  Now methods.
10990         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10991         (ravenscar_thread_target::update_thread_list): Update.
10992         (ravenscar_thread_target::active_task): Now method.
10993         (ravenscar_thread_target::store_registers)
10994         (ravenscar_thread_target::prepare_to_store)
10995         (ravenscar_thread_target::prepare_to_store)
10996         (ravenscar_thread_target::mourn_inferior): Update.
10997         (ravenscar_inferior_created): Use "new" to create target.
10998         (ravenscar_thread_target::get_ada_task_ptid): Update.
10999         (_initialize_ravenscar): Don't initialize base_ptid.
11000         (ravenscar_ops): Remove global.
11001
11002 2019-02-15  Tom Tromey  <tromey@adacore.com>
11003
11004         * target.h (push_target): Declare new overload.
11005         * target.c (push_target): New overload, taking an rvalue reference.
11006         * remote.c (remote_target::open_1): Use push_target overload.
11007         * corelow.c (core_target_open): Use push_target overload.
11008
11009 2019-02-15  Tom Tromey  <tromey@adacore.com>
11010
11011         * ravenscar-thread.c (is_ravenscar_task)
11012         (ravenscar_task_is_currently_active): Return bool.
11013         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11014         (_initialize_ravenscar): Remove "(void)".
11015         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11016         Return bool.
11017
11018 2019-02-15  Tom Tromey  <tromey@adacore.com>
11019
11020         * ravenscar-thread.c (ravenscar_runtime_initializer)
11021         (has_ravenscar_runtime, get_running_thread_id)
11022         (ravenscar_thread_target::resume): Fix indentation.
11023
11024 2019-02-15  Tom Tromey  <tromey@adacore.com>
11025
11026         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11027         from ravenscar_arch_ops.
11028         (sparc_ravenscar_ops::fetch_registers)
11029         (sparc_ravenscar_ops::store_registers): Now methods.
11030         (sparc_ravenscar_prepare_to_store): Remove.
11031         (sparc_ravenscar_ops): Redefine.
11032         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11033         methods and destructor.  Remove members.
11034         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11035         (ravenscar_thread_target::store_registers)
11036         (ravenscar_thread_target::prepare_to_store): Update.
11037         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11038         Remove.
11039         (struct ppc_ravenscar_powerpc_ops): Derive from
11040         ravenscar_arch_ops.
11041         (ppc_ravenscar_powerpc_ops::fetch_registers)
11042         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11043         (ppc_ravenscar_powerpc_ops): Redefine.
11044         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11045         (ppc_ravenscar_e500_ops::fetch_registers)
11046         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11047         (ppc_ravenscar_e500_ops): Redefine.
11048         * aarch64-ravenscar-thread.c
11049         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11050         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11051         (aarch64_ravenscar_fetch_registers)
11052         (aarch64_ravenscar_store_registers): Now methods.
11053         (aarch64_ravenscar_ops): Redefine.
11054
11055 2019-02-15  Tom Tromey  <tromey@adacore.com>
11056
11057         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11058         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11059         (ravenscar_thread_target::stopped_by_watchpoint)
11060         (ravenscar_thread_target::stopped_data_address)
11061         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11062
11063 2019-02-15  Tom Tromey  <tromey@adacore.com>
11064
11065         * ravenscar-thread.c: Fix some typos.
11066
11067 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11068             Tom Tromey  <tromey@adacore.com>
11069
11070         * ada-lang.c (ada_exception_sal): Change addr_string to a
11071         std::string.
11072         (create_ada_exception_catchpoint): Update.
11073
11074 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11075             Tom Tromey  <tromey@adacore.com>
11076
11077         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11078         (bp_location_ops): Remove.
11079         (base_breakpoint_allocate_location): Update.
11080         (free_bp_location): Update.
11081         * ada-lang.c (class ada_catchpoint_location)
11082         <ada_catchpoint_location>: Remove ops parameter.
11083         (ada_catchpoint_location_dtor): Remove.
11084         (ada_catchpoint_location_ops): Remove.
11085         (allocate_location_exception): Update.
11086         * breakpoint.h (struct bp_location_ops): Remove.
11087         (class bp_location) <bp_location>: Remove bp_location_ops
11088         parameter.
11089         <~bp_location>: Add destructor.
11090         <ops>: Remove.
11091
11092 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11093             Pedro Alves  <palves@redhat.com>
11094
11095         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11096         'PATH_MAX'.
11097
11098 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11099             Samuel Thibault  <samuel.thibault@gnu.org>
11100             Thomas Schwinge  <thomas@codesourcery.com>
11101
11102         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11103         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11104
11105 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11106
11107         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11108         (check_empty): Use "const char *".
11109
11110         * gnu-nat.c (gnu_nat_target::detach): Instead of
11111         'detach_inferior (pid)' call
11112         'detach_inferior (find_inferior_pid (pid))'.
11113
11114         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11115         'nat/fork-inferior.o'.
11116         * gnu-nat.c: #include "nat/fork-inferior.h".
11117
11118         * gnu-nat.c (gnu_nat_target::detach): Instead of
11119         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11120         * gnu-nat.h: #include "inf-child.h".
11121         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11122         'i386_gnu_nat_target::fetch_registers'.
11123         (gnu_store_registers): Rename/move to
11124         'i386_gnu_nat_target::store_registers'.
11125
11126         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11127         * gnu-nat.h (mach_thread_info): New function.
11128         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11129
11130         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11131
11132 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11133
11134         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11135
11136 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11137
11138         * windows-nat.c (windows_add_thread): Add new parameter
11139         "main_thread_p" with default value set to false.  Update
11140         function documentation as well as all callers.
11141         (windows_delete_thread): Likewise.
11142         (fake_create_process): Update call to windows_add_thread.
11143         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11144         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11145         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11146         call to windows_delete_thread.
11147
11148 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11149
11150         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11151
11152 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11153
11154         * symfile.c (find_separate_debug_file): Use canonical path of
11155         sysroot with child_path instead of gdb_sysroot if it is valid.
11156
11157 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11158
11159         * symfile.c (find_separate_debug_file): Use child_path to
11160         determine if an object file is under a sysroot.
11161
11162 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11163
11164         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11165         unittests/child-path-selftests.c.
11166         * common/pathstuff.c (child_path): New function.
11167         * common/pathstuff.h (child_path): New prototype.
11168         * unittests/child-path-selftests.c: New file.
11169
11170 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11171
11172         * symfile.c (find_separate_debug_file): Look for separate debug
11173         files in debug directories under the sysroot.
11174
11175 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11176
11177         * symtab.h (struct minimal_symbol data_p): New const method.
11178         (struct minimal_symbol text_p): Likewise.
11179         * symtab.c (output_source_filename): Use file name style
11180         to print file name.
11181         (print_symbol_info): Likewise.
11182         (print_msymbol_info): Use address style to print addresses.
11183         Use function name style to print executable text symbols.
11184         (expand_symtab_containing_pc): Use data_p.
11185         (find_pc_sect_compunit_symtab): Likewise.
11186
11187 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11188
11189         * breakpoint.c (describe_other_breakpoints): Use address style
11190         to print addresses.
11191         (say_where): Likewise.
11192
11193 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11194
11195         * ada-typeprint.c (print_func_type): Print function name
11196         style to print function name.
11197         * c-typeprint.c (c_print_type_1): Likewise.
11198
11199 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11200
11201         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11202         for execve.
11203
11204 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11205
11206         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11207         type_stack.
11208
11209 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11210
11211         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11212         TYPE_CODE_REF types.
11213
11214 2019-02-08  Jim Wilson  <jimw@sifive.com>
11215
11216         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11217         (riscv_linux_fregset): New.
11218         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11219
11220 2019-02-07  Tom Tromey  <tom@tromey.com>
11221
11222         * thread.c (thread_cancel_execution_command): Update.
11223         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11224         methods.
11225         (struct thread_fsm_ops): Remove.
11226         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11227         (thread_fsm_should_stop, thread_fsm_return_value)
11228         (thread_fsm_set_finished, thread_fsm_finished_p)
11229         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11230         Don't declare.
11231         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11232         * infrun.c (clear_proceed_status_thread)
11233         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11234         (print_stop_event): Update.
11235         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11236         Add constructor.
11237         (step_command_fsm_ops): Remove.
11238         (new_step_command_fsm): Remove.
11239         (step_1): Update.
11240         (step_command_fsm::should_stop): Rename from
11241         step_command_fsm_should_stop.
11242         (step_command_fsm::clean_up): Rename from
11243         step_command_fsm_clean_up.
11244         (step_command_fsm::do_async_reply_reason): Rename from
11245         step_command_fsm_async_reply_reason.
11246         (struct until_next_fsm): Inherit from thread_fsm.  Add
11247         constructor.
11248         (until_next_fsm_ops): Remove.
11249         (new_until_next_fsm): Remove.
11250         (until_next_fsm::should_stop): Rename from
11251         until_next_fsm_should_stop.
11252         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11253         (until_next_fsm::do_async_reply_reason): Rename from
11254         until_next_fsm_async_reply_reason.
11255         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11256         constructor.  Change type of breakpoint.
11257         (finish_command_fsm_ops): Remove.
11258         (new_finish_command_fsm): Remove.
11259         (finish_command_fsm::should_stop): Rename from
11260         finish_command_fsm_should_stop.
11261         (finish_command_fsm::clean_up): Rename from
11262         finish_command_fsm_clean_up.
11263         (finish_command_fsm::return_value): Rename from
11264         finish_command_fsm_return_value.
11265         (finish_command_fsm::do_async_reply_reason): Rename from
11266         finish_command_fsm_async_reply_reason.
11267         (finish_command): Update.
11268         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11269         Add constructor.
11270         (call_thread_fsm_ops): Remove.
11271         (call_thread_fsm::call_thread_fsm): Rename from
11272         new_call_thread_fsm.
11273         (call_thread_fsm::should_stop): Rename from
11274         call_thread_fsm_should_stop.
11275         (call_thread_fsm::should_notify_stop): Rename from
11276         call_thread_fsm_should_notify_stop.
11277         (run_inferior_call, call_function_by_hand_dummy): Update.
11278         * cli/cli-interp.c (should_print_stop_to_console): Update.
11279         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11280         Add constructor.  Change type of location_breakpoint,
11281         caller_breakpoint.
11282         (until_break_fsm_ops): Remove.
11283         (new_until_break_fsm): Remove.
11284         (until_break_fsm::should_stop): Rename from
11285         until_break_fsm_should_stop.
11286         (until_break_fsm::clean_up): Rename from
11287         until_break_fsm_clean_up.
11288         (until_break_fsm::do_async_reply_reason): Rename from
11289         until_break_fsm_async_reply_reason.
11290         (until_break_command): Update.
11291         * thread-fsm.c: Remove.
11292         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11293
11294 2019-02-07  Tom Tromey  <tom@tromey.com>
11295
11296         * yy-remap.h: Add include guard.
11297         * xtensa-tdep.h: Add include guard.
11298         * xcoffread.h: Rename include guard.
11299         * varobj-iter.h: Add include guard.
11300         * tui/tui.h: Rename include guard.
11301         * tui/tui-winsource.h: Rename include guard.
11302         * tui/tui-wingeneral.h: Rename include guard.
11303         * tui/tui-windata.h: Rename include guard.
11304         * tui/tui-win.h: Rename include guard.
11305         * tui/tui-stack.h: Rename include guard.
11306         * tui/tui-source.h: Rename include guard.
11307         * tui/tui-regs.h: Rename include guard.
11308         * tui/tui-out.h: Rename include guard.
11309         * tui/tui-layout.h: Rename include guard.
11310         * tui/tui-io.h: Rename include guard.
11311         * tui/tui-hooks.h: Rename include guard.
11312         * tui/tui-file.h: Rename include guard.
11313         * tui/tui-disasm.h: Rename include guard.
11314         * tui/tui-data.h: Rename include guard.
11315         * tui/tui-command.h: Rename include guard.
11316         * tic6x-tdep.h: Add include guard.
11317         * target/waitstatus.h: Rename include guard.
11318         * target/wait.h: Rename include guard.
11319         * target/target.h: Rename include guard.
11320         * target/resume.h: Rename include guard.
11321         * target-float.h: Rename include guard.
11322         * stabsread.h: Add include guard.
11323         * rs6000-tdep.h: Add include guard.
11324         * riscv-fbsd-tdep.h: Add include guard.
11325         * regformats/regdef.h: Rename include guard.
11326         * record.h: Rename include guard.
11327         * python/python.h: Rename include guard.
11328         * python/python-internal.h: Rename include guard.
11329         * python/py-stopevent.h: Rename include guard.
11330         * python/py-ref.h: Rename include guard.
11331         * python/py-record.h: Rename include guard.
11332         * python/py-record-full.h: Rename include guard.
11333         * python/py-record-btrace.h: Rename include guard.
11334         * python/py-instruction.h: Rename include guard.
11335         * python/py-events.h: Rename include guard.
11336         * python/py-event.h: Rename include guard.
11337         * procfs.h: Add include guard.
11338         * proc-utils.h: Add include guard.
11339         * p-lang.h: Add include guard.
11340         * or1k-tdep.h: Rename include guard.
11341         * observable.h: Rename include guard.
11342         * nto-tdep.h: Rename include guard.
11343         * nat/x86-linux.h: Rename include guard.
11344         * nat/x86-linux-dregs.h: Rename include guard.
11345         * nat/x86-gcc-cpuid.h: Add include guard.
11346         * nat/x86-dregs.h: Rename include guard.
11347         * nat/x86-cpuid.h: Rename include guard.
11348         * nat/ppc-linux.h: Rename include guard.
11349         * nat/mips-linux-watch.h: Rename include guard.
11350         * nat/linux-waitpid.h: Rename include guard.
11351         * nat/linux-ptrace.h: Rename include guard.
11352         * nat/linux-procfs.h: Rename include guard.
11353         * nat/linux-osdata.h: Rename include guard.
11354         * nat/linux-nat.h: Rename include guard.
11355         * nat/linux-namespaces.h: Rename include guard.
11356         * nat/linux-btrace.h: Rename include guard.
11357         * nat/glibc_thread_db.h: Rename include guard.
11358         * nat/gdb_thread_db.h: Rename include guard.
11359         * nat/gdb_ptrace.h: Rename include guard.
11360         * nat/fork-inferior.h: Rename include guard.
11361         * nat/amd64-linux-siginfo.h: Rename include guard.
11362         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11363         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11364         * nat/aarch64-linux.h: Rename include guard.
11365         * nat/aarch64-linux-hw-point.h: Rename include guard.
11366         * mn10300-tdep.h: Add include guard.
11367         * mips-linux-tdep.h: Add include guard.
11368         * mi/mi-parse.h: Rename include guard.
11369         * mi/mi-out.h: Rename include guard.
11370         * mi/mi-main.h: Rename include guard.
11371         * mi/mi-interp.h: Rename include guard.
11372         * mi/mi-getopt.h: Rename include guard.
11373         * mi/mi-console.h: Rename include guard.
11374         * mi/mi-common.h: Rename include guard.
11375         * mi/mi-cmds.h: Rename include guard.
11376         * mi/mi-cmd-break.h: Rename include guard.
11377         * m2-lang.h: Add include guard.
11378         * location.h: Rename include guard.
11379         * linux-record.h: Rename include guard.
11380         * linux-nat.h: Add include guard.
11381         * linux-fork.h: Add include guard.
11382         * i386-darwin-tdep.h: Rename include guard.
11383         * hppa-linux-offsets.h: Add include guard.
11384         * guile/guile.h: Rename include guard.
11385         * guile/guile-internal.h: Rename include guard.
11386         * gnu-nat.h: Rename include guard.
11387         * gdb-stabs.h: Rename include guard.
11388         * frv-tdep.h: Add include guard.
11389         * f-lang.h: Add include guard.
11390         * event-loop.h: Add include guard.
11391         * darwin-nat.h: Rename include guard.
11392         * cp-abi.h: Rename include guard.
11393         * config/sparc/nm-sol2.h: Rename include guard.
11394         * config/nm-nto.h: Rename include guard.
11395         * config/nm-linux.h: Add include guard.
11396         * config/i386/nm-i386gnu.h: Rename include guard.
11397         * config/djgpp/nl_types.h: Rename include guard.
11398         * config/djgpp/langinfo.h: Rename include guard.
11399         * compile/gcc-cp-plugin.h: Add include guard.
11400         * compile/gcc-c-plugin.h: Add include guard.
11401         * compile/compile.h: Rename include guard.
11402         * compile/compile-object-run.h: Rename include guard.
11403         * compile/compile-object-load.h: Rename include guard.
11404         * compile/compile-internal.h: Rename include guard.
11405         * compile/compile-cplus.h: Rename include guard.
11406         * compile/compile-c.h: Rename include guard.
11407         * common/xml-utils.h: Rename include guard.
11408         * common/x86-xstate.h: Rename include guard.
11409         * common/version.h: Rename include guard.
11410         * common/vec.h: Rename include guard.
11411         * common/tdesc.h: Rename include guard.
11412         * common/selftest.h: Rename include guard.
11413         * common/scoped_restore.h: Rename include guard.
11414         * common/scoped_mmap.h: Rename include guard.
11415         * common/scoped_fd.h: Rename include guard.
11416         * common/safe-iterator.h: Rename include guard.
11417         * common/run-time-clock.h: Rename include guard.
11418         * common/refcounted-object.h: Rename include guard.
11419         * common/queue.h: Rename include guard.
11420         * common/ptid.h: Rename include guard.
11421         * common/print-utils.h: Rename include guard.
11422         * common/preprocessor.h: Rename include guard.
11423         * common/pathstuff.h: Rename include guard.
11424         * common/observable.h: Rename include guard.
11425         * common/netstuff.h: Rename include guard.
11426         * common/job-control.h: Rename include guard.
11427         * common/host-defs.h: Rename include guard.
11428         * common/gdb_wait.h: Rename include guard.
11429         * common/gdb_vecs.h: Rename include guard.
11430         * common/gdb_unlinker.h: Rename include guard.
11431         * common/gdb_unique_ptr.h: Rename include guard.
11432         * common/gdb_tilde_expand.h: Rename include guard.
11433         * common/gdb_sys_time.h: Rename include guard.
11434         * common/gdb_string_view.h: Rename include guard.
11435         * common/gdb_splay_tree.h: Rename include guard.
11436         * common/gdb_setjmp.h: Rename include guard.
11437         * common/gdb_ref_ptr.h: Rename include guard.
11438         * common/gdb_optional.h: Rename include guard.
11439         * common/gdb_locale.h: Rename include guard.
11440         * common/gdb_assert.h: Rename include guard.
11441         * common/filtered-iterator.h: Rename include guard.
11442         * common/filestuff.h: Rename include guard.
11443         * common/fileio.h: Rename include guard.
11444         * common/environ.h: Rename include guard.
11445         * common/common-utils.h: Rename include guard.
11446         * common/common-types.h: Rename include guard.
11447         * common/common-regcache.h: Rename include guard.
11448         * common/common-inferior.h: Rename include guard.
11449         * common/common-gdbthread.h: Rename include guard.
11450         * common/common-exceptions.h: Rename include guard.
11451         * common/common-defs.h: Rename include guard.
11452         * common/common-debug.h: Rename include guard.
11453         * common/cleanups.h: Rename include guard.
11454         * common/buffer.h: Rename include guard.
11455         * common/btrace-common.h: Rename include guard.
11456         * common/break-common.h: Rename include guard.
11457         * cli/cli-utils.h: Rename include guard.
11458         * cli/cli-style.h: Rename include guard.
11459         * cli/cli-setshow.h: Rename include guard.
11460         * cli/cli-script.h: Rename include guard.
11461         * cli/cli-interp.h: Rename include guard.
11462         * cli/cli-decode.h: Rename include guard.
11463         * cli/cli-cmds.h: Rename include guard.
11464         * charset-list.h: Add include guard.
11465         * buildsym-legacy.h: Rename include guard.
11466         * bfin-tdep.h: Add include guard.
11467         * ax.h: Rename include guard.
11468         * arm-linux-tdep.h: Add include guard.
11469         * arm-fbsd-tdep.h: Add include guard.
11470         * arch/xtensa.h: Rename include guard.
11471         * arch/tic6x.h: Add include guard.
11472         * arch/i386.h: Add include guard.
11473         * arch/arm.h: Rename include guard.
11474         * arch/arm-linux.h: Rename include guard.
11475         * arch/arm-get-next-pcs.h: Rename include guard.
11476         * arch/amd64.h: Add include guard.
11477         * arch/aarch64-insn.h: Rename include guard.
11478         * arch-utils.h: Rename include guard.
11479         * annotate.h: Add include guard.
11480         * amd64-darwin-tdep.h: Rename include guard.
11481         * aarch64-linux-tdep.h: Add include guard.
11482         * aarch64-fbsd-tdep.h: Add include guard.
11483         * aarch32-linux-nat.h: Add include guard.
11484
11485 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11486
11487         * macrotab.c (macro_define_internal): New function that
11488         factorizes macro_define_object_internal and macro_define_function
11489         code.
11490         (macro_define_object_internal): Use macro_define_internal.
11491         (macro_define_function): Likewise.
11492
11493 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11494
11495         * macrocmd.c (extract_identifier): Return
11496         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11497         callers.
11498
11499 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11500
11501         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11502
11503 2019-02-05  Tom Tromey  <tom@tromey.com>
11504
11505         * target.c (target_stack::unpush): Move assertion earlier.
11506
11507 2019-01-30  Tom Tromey  <tom@tromey.com>
11508
11509         PR python/23615:
11510         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11511         (gdbpy_parse_and_eval): Likewise.
11512         * python/python-internal.h (gdbpy_allow_threads): New class.
11513
11514 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11515
11516         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11517         (aarch64_fbsd_fpregmap): Move earlier.
11518         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11519         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11520         instead of individual calls to trad_frame_set_reg_addr.
11521         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11522         earlier.
11523         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11524         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11525         instead of individual calls to trad_frame_set_reg_addr.
11526
11527 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11528
11529         * CONTRIBUTE: Replace contribution list with wiki link.
11530
11531 2019-01-25  Tom Tromey  <tom@tromey.com>
11532
11533         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11534
11535 2019-01-25  Tom Tromey  <tom@tromey.com>
11536
11537         * xtensa-linux-nat.c: Fix common/ includes.
11538         * xml-support.h: Fix common/ includes.
11539         * xml-support.c: Fix common/ includes.
11540         * x86-linux-nat.c: Fix common/ includes.
11541         * windows-nat.c: Fix common/ includes.
11542         * varobj.h: Fix common/ includes.
11543         * varobj.c: Fix common/ includes.
11544         * value.c: Fix common/ includes.
11545         * valops.c: Fix common/ includes.
11546         * utils.c: Fix common/ includes.
11547         * unittests/xml-utils-selftests.c: Fix common/ includes.
11548         * unittests/utils-selftests.c: Fix common/ includes.
11549         * unittests/unpack-selftests.c: Fix common/ includes.
11550         * unittests/tracepoint-selftests.c: Fix common/ includes.
11551         * unittests/style-selftests.c: Fix common/ includes.
11552         * unittests/string_view-selftests.c: Fix common/ includes.
11553         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11554         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11555         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11556         * unittests/rsp-low-selftests.c: Fix common/ includes.
11557         * unittests/parse-connection-spec-selftests.c: Fix common/
11558         includes.
11559         * unittests/optional-selftests.c: Fix common/ includes.
11560         * unittests/offset-type-selftests.c: Fix common/ includes.
11561         * unittests/observable-selftests.c: Fix common/ includes.
11562         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11563         * unittests/memrange-selftests.c: Fix common/ includes.
11564         * unittests/memory-map-selftests.c: Fix common/ includes.
11565         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11566         * unittests/function-view-selftests.c: Fix common/ includes.
11567         * unittests/environ-selftests.c: Fix common/ includes.
11568         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11569         * unittests/common-utils-selftests.c: Fix common/ includes.
11570         * unittests/cli-utils-selftests.c: Fix common/ includes.
11571         * unittests/array-view-selftests.c: Fix common/ includes.
11572         * ui-file.c: Fix common/ includes.
11573         * tui/tui-io.c: Fix common/ includes.
11574         * tracepoint.h: Fix common/ includes.
11575         * tracepoint.c: Fix common/ includes.
11576         * tracefile-tfile.c: Fix common/ includes.
11577         * top.h: Fix common/ includes.
11578         * top.c: Fix common/ includes.
11579         * thread.c: Fix common/ includes.
11580         * target/waitstatus.h: Fix common/ includes.
11581         * target/waitstatus.c: Fix common/ includes.
11582         * target.h: Fix common/ includes.
11583         * target.c: Fix common/ includes.
11584         * target-memory.c: Fix common/ includes.
11585         * target-descriptions.c: Fix common/ includes.
11586         * symtab.h: Fix common/ includes.
11587         * symfile.c: Fix common/ includes.
11588         * stap-probe.c: Fix common/ includes.
11589         * spu-linux-nat.c: Fix common/ includes.
11590         * sparc-nat.c: Fix common/ includes.
11591         * source.c: Fix common/ includes.
11592         * solib.c: Fix common/ includes.
11593         * solib-target.c: Fix common/ includes.
11594         * ser-unix.c: Fix common/ includes.
11595         * ser-tcp.c: Fix common/ includes.
11596         * ser-pipe.c: Fix common/ includes.
11597         * ser-base.c: Fix common/ includes.
11598         * selftest-arch.c: Fix common/ includes.
11599         * s12z-tdep.c: Fix common/ includes.
11600         * rust-exp.y: Fix common/ includes.
11601         * rs6000-aix-tdep.c: Fix common/ includes.
11602         * riscv-tdep.c: Fix common/ includes.
11603         * remote.c: Fix common/ includes.
11604         * remote-notif.h: Fix common/ includes.
11605         * remote-fileio.h: Fix common/ includes.
11606         * remote-fileio.c: Fix common/ includes.
11607         * regcache.h: Fix common/ includes.
11608         * regcache.c: Fix common/ includes.
11609         * record-btrace.c: Fix common/ includes.
11610         * python/python.c: Fix common/ includes.
11611         * python/py-type.c: Fix common/ includes.
11612         * python/py-inferior.c: Fix common/ includes.
11613         * progspace.h: Fix common/ includes.
11614         * producer.c: Fix common/ includes.
11615         * procfs.c: Fix common/ includes.
11616         * proc-api.c: Fix common/ includes.
11617         * printcmd.c: Fix common/ includes.
11618         * ppc-linux-nat.c: Fix common/ includes.
11619         * parser-defs.h: Fix common/ includes.
11620         * osdata.c: Fix common/ includes.
11621         * obsd-nat.c: Fix common/ includes.
11622         * nat/x86-linux.c: Fix common/ includes.
11623         * nat/x86-linux-dregs.c: Fix common/ includes.
11624         * nat/x86-dregs.h: Fix common/ includes.
11625         * nat/x86-dregs.c: Fix common/ includes.
11626         * nat/ppc-linux.c: Fix common/ includes.
11627         * nat/mips-linux-watch.h: Fix common/ includes.
11628         * nat/mips-linux-watch.c: Fix common/ includes.
11629         * nat/linux-waitpid.c: Fix common/ includes.
11630         * nat/linux-ptrace.h: Fix common/ includes.
11631         * nat/linux-ptrace.c: Fix common/ includes.
11632         * nat/linux-procfs.c: Fix common/ includes.
11633         * nat/linux-personality.c: Fix common/ includes.
11634         * nat/linux-osdata.c: Fix common/ includes.
11635         * nat/linux-namespaces.c: Fix common/ includes.
11636         * nat/linux-btrace.h: Fix common/ includes.
11637         * nat/linux-btrace.c: Fix common/ includes.
11638         * nat/fork-inferior.c: Fix common/ includes.
11639         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11640         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11641         * nat/aarch64-linux.c: Fix common/ includes.
11642         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11643         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11644         * namespace.h: Fix common/ includes.
11645         * mips-linux-tdep.c: Fix common/ includes.
11646         * minsyms.c: Fix common/ includes.
11647         * mi/mi-parse.h: Fix common/ includes.
11648         * mi/mi-main.c: Fix common/ includes.
11649         * mi/mi-cmd-env.c: Fix common/ includes.
11650         * memrange.h: Fix common/ includes.
11651         * memattr.c: Fix common/ includes.
11652         * maint.h: Fix common/ includes.
11653         * maint.c: Fix common/ includes.
11654         * main.c: Fix common/ includes.
11655         * machoread.c: Fix common/ includes.
11656         * location.c: Fix common/ includes.
11657         * linux-thread-db.c: Fix common/ includes.
11658         * linux-nat.c: Fix common/ includes.
11659         * linux-fork.c: Fix common/ includes.
11660         * inline-frame.c: Fix common/ includes.
11661         * infrun.c: Fix common/ includes.
11662         * inflow.c: Fix common/ includes.
11663         * inferior.h: Fix common/ includes.
11664         * inferior.c: Fix common/ includes.
11665         * infcmd.c: Fix common/ includes.
11666         * inf-ptrace.c: Fix common/ includes.
11667         * inf-child.c: Fix common/ includes.
11668         * ia64-linux-nat.c: Fix common/ includes.
11669         * i387-tdep.c: Fix common/ includes.
11670         * i386-tdep.c: Fix common/ includes.
11671         * i386-linux-tdep.c: Fix common/ includes.
11672         * i386-linux-nat.c: Fix common/ includes.
11673         * i386-go32-tdep.c: Fix common/ includes.
11674         * i386-fbsd-tdep.c: Fix common/ includes.
11675         * i386-fbsd-nat.c: Fix common/ includes.
11676         * guile/scm-type.c: Fix common/ includes.
11677         * guile/guile.c: Fix common/ includes.
11678         * go32-nat.c: Fix common/ includes.
11679         * gnu-nat.c: Fix common/ includes.
11680         * gdbthread.h: Fix common/ includes.
11681         * gdbarch-selftests.c: Fix common/ includes.
11682         * gdb_usleep.c: Fix common/ includes.
11683         * gdb_select.h: Fix common/ includes.
11684         * gdb_bfd.c: Fix common/ includes.
11685         * gcore.c: Fix common/ includes.
11686         * fork-child.c: Fix common/ includes.
11687         * findvar.c: Fix common/ includes.
11688         * fbsd-nat.c: Fix common/ includes.
11689         * event-top.c: Fix common/ includes.
11690         * event-loop.c: Fix common/ includes.
11691         * dwarf2read.c: Fix common/ includes.
11692         * dwarf2loc.c: Fix common/ includes.
11693         * dwarf2-frame.c: Fix common/ includes.
11694         * dwarf-index-cache.c: Fix common/ includes.
11695         * dtrace-probe.c: Fix common/ includes.
11696         * disasm-selftests.c: Fix common/ includes.
11697         * defs.h: Fix common/ includes.
11698         * csky-tdep.c: Fix common/ includes.
11699         * cp-valprint.c: Fix common/ includes.
11700         * cp-support.h: Fix common/ includes.
11701         * cp-support.c: Fix common/ includes.
11702         * corelow.c: Fix common/ includes.
11703         * completer.h: Fix common/ includes.
11704         * completer.c: Fix common/ includes.
11705         * compile/compile.c: Fix common/ includes.
11706         * compile/compile-loc2c.c: Fix common/ includes.
11707         * compile/compile-cplus-types.c: Fix common/ includes.
11708         * compile/compile-cplus-symbols.c: Fix common/ includes.
11709         * command.h: Fix common/ includes.
11710         * cli/cli-dump.c: Fix common/ includes.
11711         * cli/cli-cmds.c: Fix common/ includes.
11712         * charset.c: Fix common/ includes.
11713         * build-id.c: Fix common/ includes.
11714         * btrace.h: Fix common/ includes.
11715         * btrace.c: Fix common/ includes.
11716         * breakpoint.h: Fix common/ includes.
11717         * breakpoint.c: Fix common/ includes.
11718         * ax.h:
11719         (enum agent_op): Fix common/ includes.
11720         * ax-general.c (struct aop_map): Fix common/ includes.
11721         * ax-gdb.c: Fix common/ includes.
11722         * auxv.c: Fix common/ includes.
11723         * auto-load.c: Fix common/ includes.
11724         * arm-tdep.c: Fix common/ includes.
11725         * arch/riscv.c: Fix common/ includes.
11726         * arch/ppc-linux-common.c: Fix common/ includes.
11727         * arch/i386.c: Fix common/ includes.
11728         * arch/arm.c: Fix common/ includes.
11729         * arch/arm-linux.c: Fix common/ includes.
11730         * arch/arm-get-next-pcs.c: Fix common/ includes.
11731         * arch/amd64.c: Fix common/ includes.
11732         * arch/aarch64.c: Fix common/ includes.
11733         * arch/aarch64-insn.c: Fix common/ includes.
11734         * arch-utils.c: Fix common/ includes.
11735         * amd64-windows-tdep.c: Fix common/ includes.
11736         * amd64-tdep.c: Fix common/ includes.
11737         * amd64-sol2-tdep.c: Fix common/ includes.
11738         * amd64-obsd-tdep.c: Fix common/ includes.
11739         * amd64-nbsd-tdep.c: Fix common/ includes.
11740         * amd64-linux-tdep.c: Fix common/ includes.
11741         * amd64-linux-nat.c: Fix common/ includes.
11742         * amd64-fbsd-tdep.c: Fix common/ includes.
11743         * amd64-fbsd-nat.c: Fix common/ includes.
11744         * amd64-dicos-tdep.c: Fix common/ includes.
11745         * amd64-darwin-tdep.c: Fix common/ includes.
11746         * agent.c: Fix common/ includes.
11747         * ada-lang.h: Fix common/ includes.
11748         * ada-lang.c: Fix common/ includes.
11749         * aarch64-tdep.c: Fix common/ includes.
11750
11751 2019-01-25  Tom Tromey  <tom@tromey.com>
11752
11753         * common/create-version.sh: Use common/version.h.
11754
11755 2019-01-24  Pedro Alves  <palves@redhat.com>
11756
11757         * infrun.c (signal_stop, signal_print, signal_program)
11758         (signal_catch, signal_pass): Now arrays instead of pointers.
11759         (update_signals_program_target, do_target_resume)
11760         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11761         * linux-nat.c (linux_nat_target::pass_signals)
11762         (linux_nat_target::create_inferior, linux_nat_target::attach):
11763         Adjust.
11764         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11765         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11766         * procfs.c (procfs_target::pass_signals): Adjust.
11767         * record-full.c (record_full_target::resume): Adjust.
11768         * remote.c (remote_target::pass_signals)
11769         (remote_target::program_signals): Adjust.
11770         * target-debug.h (target_debug_print_signals): Now takes a
11771         gdb::array_view as parameter.  Adjust.
11772         * target.h (target_ops) <pass_signals, program_signals>: Replace
11773         pointer and length parameters with gdb::array_view.
11774         (target_pass_signals, target_program_signals): Likewise.
11775         * target-delegates.c: Regenerate.
11776
11777 2019-01-24  Pedro Alves  <palves@redhat.com>
11778
11779         * common/forward-scope-exit.h
11780         (forward_scope_exit::forward_scope_exit): Pass arguments to
11781         m_bind_function directly, instead of creating a std::bind and
11782         copying that.
11783
11784 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11785
11786         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11787         for static members.
11788         (pass_in_v_vfp_candidate): Likewise.
11789
11790 2019-01-23  Tom Tromey  <tom@tromey.com>
11791             Pedro Alves  <palves@redhat.com>
11792
11793         * regcache.c (class regcache_invalidator): Remove.
11794         (regcache::raw_write): Use make_scope_exit.
11795
11796 2019-01-23  Tom Tromey  <tom@tromey.com>
11797
11798         * ui-out.h (class ui_out_emit_type): Update comment.
11799
11800 2019-01-23  Tom Tromey  <tom@tromey.com>
11801
11802         * infrun.c (fetch_inferior_event): Update comment.
11803
11804 2019-01-23  Tom Tromey  <tom@tromey.com>
11805             Pedro Alves  <palves@redhat.com>
11806
11807         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11808         parameter.
11809         (fetch_inferior_event): Use SCOPE_EXIT.
11810
11811
11812 2019-01-23  Tom Tromey  <tom@tromey.com>
11813             Pedro Alves  <palves@redhat.com>
11814
11815         * infrun.c (disable_thread_events): Delete.
11816         (stop_all_threads): Use SCOPE_EXIT.
11817
11818 2019-01-23  Tom Tromey  <tom@tromey.com>
11819             Pedro Alves  <palves@redhat.com>
11820
11821         * symfile.c: Include forward-scope-exit.h.
11822         (clear_symtab_users_cleanup): Replace forward declaration with
11823         a FORWARD_SCOPE_EXIT.
11824         (syms_from_objfile_1): Use the forward_scope_exit and
11825         gdb::optional instead of cleanup_function.
11826         (reread_symbols): Use the forward_scope_exit instead of
11827         cleanup_function.
11828         (clear_symtab_users_cleanup): Remove function.
11829
11830 2019-01-23  Tom Tromey  <tom@tromey.com>
11831             Pedro Alves  <palves@redhat.com>
11832
11833         * linux-nat.c: Include scope-exit.h.
11834         (cleanup_target_stop): Remove.
11835         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11836         SCOPE_EXIT.
11837
11838 2019-01-23  Tom Tromey  <tom@tromey.com>
11839             Pedro Alves  <palves@redhat.com>
11840
11841         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11842         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11843
11844 2019-01-23  Tom Tromey  <tom@tromey.com>
11845             Andrew Burgess  <andrew.burgess@embecosm.com>
11846             Pedro Alves  <palves@redhat.com>
11847
11848         * infrun.c (fetch_inferior_event): Use scope_exit.
11849         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11850         * top.c (execute_command): Use scope_exit.
11851         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11852         * utils.c (do_bpstat_clear_actions_cleanup)
11853         (make_bpstat_clear_actions_cleanup): Remove.
11854
11855 2019-01-23  Tom Tromey  <tom@tromey.com>
11856             Pedro Alves  <palves@redhat.com>
11857
11858         * infrun.c: Include "common/scope-exit.h"
11859         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11860         (wait_for_inferior): Use SCOPE_EXIT.
11861         (fetch_inferior_event): Use scope_exit.
11862
11863 2019-01-23  Tom Tromey  <tom@tromey.com>
11864             Pedro Alves  <palves@redhat.com>
11865
11866         * breakpoint.c (create_breakpoint): Remove cleanup.
11867
11868 2019-01-23  Tom Tromey  <tom@tromey.com>
11869             Andrew Burgess  <andrew.burgess@embecosm.com>
11870             Pedro Alves  <palves@redhat.com>
11871
11872 2019-01-23  Pedro Alves  <palves@redhat.com>
11873
11874         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11875
11876 2019-01-23  Pedro Alves  <palves@redhat.com>
11877             Andrew Burgess  <andrew.burgess@embecosm.com>
11878
11879         * gdbthread.h: Include "common/forward-scope-exit.h".
11880         (scoped_finish_thread_state): Redefine custom class in terms of
11881         forward_scope_exit.
11882
11883 2019-01-23  Pedro Alves  <palves@redhat.com>
11884             Andrew Burgess  <andrew.burgess@embecosm.com>
11885
11886         * common/forward-scope-exit.h: New file.
11887
11888 2019-01-23  Pedro Alves  <palves@redhat.com>
11889             Andrew Burgess  <andrew.burgess@embecosm.com>
11890             Tom Tromey  <tom@tromey.com>
11891
11892         * common/scope-exit.h: New file.
11893
11894 2019-01-23  Pedro Alves  <palves@redhat.com>
11895
11896         * common/preprocessor.h (ESC): Rename to ...
11897         (ESC_PARENS): ... this.
11898         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11899         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11900
11901 2019-01-23  Tom Tromey  <tom@tromey.com>
11902
11903         * language.h (class scoped_switch_to_sym_language_if_auto):
11904         Initialize m_lang in both cases.
11905
11906 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11907
11908         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11909         with XCNEW.
11910
11911 2019-01-22  Tom Tromey  <tom@tromey.com>
11912
11913         * corelow.c: Do not include sys/file.h.
11914
11915 2019-01-22  Tom Tromey  <tom@tromey.com>
11916
11917         * tui/tui-wingeneral.h: Include gdb_curses.h.
11918
11919 2019-01-22  Tom Tromey  <tom@tromey.com>
11920
11921         * source-cache.h (class source_cache) <get_source_lines,
11922         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11923
11924 2019-01-22  Tom Tromey  <tom@tromey.com>
11925
11926         * remote-fileio.h (struct remote_target): Declare.
11927
11928 2019-01-22  Tom Tromey  <tom@tromey.com>
11929
11930         * python/py-arch.c: Do not include py-ref.h.
11931         * python/py-bpevent.c: Do not include py-ref.h.
11932         * python/py-cmd.c: Do not include py-ref.h.
11933         * python/py-continueevent.c: Do not include py-ref.h.
11934         * python/py-event.h: Do not include py-ref.h.
11935         * python/py-evtregistry.c: Do not include py-ref.h.
11936         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11937         * python/py-frame.c: Do not include py-ref.h.
11938         * python/py-framefilter.c: Do not include py-ref.h.
11939         * python/py-function.c: Do not include py-ref.h.
11940         * python/py-infevents.c: Do not include py-ref.h.
11941         * python/py-linetable.c: Do not include py-ref.h.
11942         * python/py-objfile.c: Do not include py-ref.h.
11943         * python/py-param.c: Do not include py-ref.h.
11944         * python/py-prettyprint.c: Do not include py-ref.h.
11945         * python/py-progspace.c: Do not include py-ref.h.
11946         * python/py-symbol.c: Do not include py-ref.h.
11947         * python/py-symtab.c: Do not include py-ref.h.
11948         * python/py-type.c: Do not include py-ref.h.
11949         * python/py-unwind.c: Do not include py-ref.h.
11950         * python/py-utils.c: Do not include py-ref.h.
11951         * python/py-value.c: Do not include py-ref.h.
11952         * python/py-varobj.c: Do not include py-ref.h.
11953         * python/py-xmethods.c: Do not include py-ref.h.
11954         * python/python.c: Do not include py-ref.h.
11955         * varobj.c: Do not include py-ref.h.
11956
11957 2019-01-22  Tom Tromey  <tom@tromey.com>
11958
11959         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11960         keyword for bcache.
11961
11962 2019-01-22  Tom Tromey  <tom@tromey.com>
11963
11964         * compile/compile-cplus-types.c: Remove a comment by #include.
11965
11966 2019-01-22  Tom Tromey  <tom@tromey.com>
11967
11968         * compile/gcc-c-plugin.h: Include compile-internal.h.
11969
11970 2019-01-22  Tom Tromey  <tom@tromey.com>
11971
11972         * stabsread.c (EXTERN): Do not define.
11973         (symnum, next_symbol_text_func, processing_gcc_compilation)
11974         (within_function, global_sym_chain, global_stabs)
11975         (previous_stab_code, this_object_header_files)
11976         (n_this_object_header_files)
11977         (n_allocated_this_object_header_files): Define.
11978         * stabsread.h (EXTERN): Never define.  Use "extern".
11979
11980 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11981
11982         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11983         history_value.
11984
11985 2019-01-21  Tom Tromey  <tom@tromey.com>
11986
11987         * ui-out.c: Fix includes.
11988         * tui/tui-source.c: Fix includes.
11989         * target.c: Fix includes.
11990         * remote.c: Fix includes.
11991         * regcache.c: Fix includes.
11992         * python/py-block.c: Fix includes.
11993         * printcmd.c: Fix includes.
11994         * or1k-tdep.c: Fix includes.
11995         * mi/mi-main.c: Fix includes.
11996         * m32r-tdep.c: Fix includes.
11997         * csky-tdep.c: Fix includes.
11998         * compile/compile-cplus-types.c: Fix includes.
11999         * cli/cli-interp.c: Fix includes.
12000
12001 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12002
12003         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12004         for padding.
12005
12006 2019-01-16  Tom Tromey  <tom@tromey.com>
12007
12008         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12009         earlier.
12010         (struct objfile) <msymbols_range>: Move from top level.
12011         <msymbols>: New method.
12012         (class objfile_msymbols): Remove.
12013         * symtab.c (default_collect_symbol_completion_matches_break_on):
12014         Update.
12015         * symmisc.c (dump_msymbols): Update.
12016         * stabsread.c (scan_file_globals): Update.
12017         * objc-lang.c (info_selectors_command, info_classes_command)
12018         (find_methods): Update.
12019         * minsyms.c (find_solib_trampoline_target): Update.
12020         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12021         * coffread.c (coff_symfile_read): Update.
12022         * ada-lang.c (ada_lookup_simple_minsym)
12023         (ada_collect_symbol_completion_matches): Update.
12024
12025 2019-01-16  Tom Tromey  <tom@tromey.com>
12026
12027         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12028         type.  Remove no-argument constructor.
12029         <iterator::operator++>: Simplify.
12030         <begin>: Update.
12031         <end>: Use minimal_symbol_count.
12032
12033 2019-01-16  Tom Tromey  <tom@tromey.com>
12034
12035         * objfiles.h (struct objfile) <psymtabs>: New method.
12036         (class objfile_psymtabs): Remove.
12037         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12038         typedef.
12039         <range>: New method.
12040         (require_partial_symbols): Change return type.
12041         * psymtab.c (require_partial_symbols)
12042         (psym_expand_symtabs_matching): Update.
12043         * mdebugread.c (parse_partial_symbols): Update.
12044         * dbxread.c (dbx_end_psymtab): Update.
12045
12046 2019-01-15  Tom Tromey  <tom@tromey.com>
12047
12048         * symtab.c (lookup_objfile_from_block)
12049         (lookup_symbol_in_objfile_symtabs)
12050         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12051         (find_line_symtab, info_sources_command)
12052         (default_collect_symbol_completion_matches_break_on)
12053         (make_source_files_completion_list): Update.
12054         * symmisc.c (print_objfile_statistics, dump_objfile)
12055         (maintenance_print_symbols, maintenance_info_symtabs)
12056         (maintenance_check_symtabs, maintenance_info_line_tables):
12057         Update.
12058         * source.c (select_source_symtab)
12059         (forget_cached_source_info_for_objfile): Update.
12060         * objfiles.h (class objfile_compunits): Remove.
12061         (struct objfile) <compunits_range>: New typedef.
12062         (compunits): New method.
12063         * objfiles.c (objfile_relocate1): Update.
12064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12065         * maint.c (count_symtabs_and_blocks): Update.
12066         * linespec.c (iterate_over_all_matching_symtabs): Update.
12067         * cp-support.c (add_symbol_overload_list_qualified): Update.
12068         * coffread.c (coff_symtab_read): Update.
12069         * ada-lang.c (add_nonlocal_symbols)
12070         (ada_collect_symbol_completion_matches)
12071         (ada_add_global_exceptions): Update.
12072
12073 2019-01-15  Tom Tromey  <tom@tromey.com>
12074
12075         * progspace.h (program_space) <objfiles_safe_range>: New
12076         typedef.
12077         <objfiles_safe>: New method.
12078         * objfiles.h (class all_objfiles_safe): Remove.
12079         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12080         * jit.c (jit_inferior_exit_hook): Update.
12081
12082 2019-01-17  Tom Tromey  <tom@tromey.com>
12083
12084         * progspace.h (program_space) <objfiles_range>: New typedef.
12085         <objfiles>: New method.
12086         <objfiles_head>: Rename from objfiles.
12087         (object_files): Update.
12088         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12089         * guile/scm-pretty-print.c
12090         (ppscm_find_pretty_printer_from_objfiles): Update.
12091         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12092         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12093         Update.
12094         * python/py-progspace.c (pspy_get_objfiles): Update.
12095         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12096         Update.
12097         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12098         (objfpy_lookup_objfile_by_build_id): Update.
12099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12100         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12101         Update.
12102         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12103         (expand_symtab_containing_pc, lookup_objfile_from_block)
12104         (lookup_static_symbol, basic_lookup_transparent_type)
12105         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12106         (find_line_symtab, info_sources_command)
12107         (default_collect_symbol_completion_matches_break_on)
12108         (make_source_files_completion_list, find_main_name): Update.
12109         * symmisc.c (print_symbol_bcache_statistics)
12110         (print_objfile_statistics, maintenance_print_symbols)
12111         (maintenance_print_msymbols, maintenance_print_objfiles)
12112         (maintenance_info_symtabs, maintenance_check_symtabs)
12113         (maintenance_expand_symtabs, maintenance_info_line_tables):
12114         Update.
12115         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12116         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12117         (map_overlay_command, unmap_overlay_command)
12118         (simple_overlay_update, expand_symtabs_matching)
12119         (map_symbol_filenames): Update.
12120         * symfile-debug.c (set_debug_symfile): Update.
12121         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12122         Update.
12123         * source.c (select_source_symtab, forget_cached_source_info):
12124         Update.
12125         * solib.c (solib_read_symbols): Update.
12126         * solib-spu.c (append_ocl_sos): Update.
12127         * psymtab.c (maintenance_print_psymbols)
12128         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12129         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12130         * printcmd.c (info_symbol_command): Update.
12131         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12132         Update.
12133         * objfiles.h (class all_objfiles): Remove.
12134         * objfiles.c (have_partial_symbols, have_full_symbols)
12135         (have_minimal_symbols, qsort_cmp, update_section_map)
12136         (shared_objfile_contains_address_p)
12137         (default_iterate_over_objfiles_in_search_order): Update.
12138         * objc-lang.c (info_selectors_command, info_classes_command)
12139         (find_methods): Update.
12140         * minsyms.c (find_solib_trampoline_target): Update.
12141         * maint.c (maintenance_info_sections)
12142         (maintenance_translate_address, count_symtabs_and_blocks):
12143         Update.
12144         * main.c (captured_main_1): Update.
12145         * linux-thread-db.c (try_thread_db_load_from_pdir)
12146         (has_libpthread): Update.
12147         * linespec.c (iterate_over_all_matching_symtabs)
12148         (search_minsyms_for_name): Update.
12149         * jit.c (jit_find_objf_with_entry_addr): Update.
12150         * hppa-tdep.c (find_unwind_entry)
12151         (hppa_lookup_stub_minimal_symbol): Update.
12152         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12153         Update.
12154         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12155         (elf_gnu_ifunc_resolve_by_got): Update.
12156         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12157         * dwarf-index-write.c (save_gdb_index_command): Update.
12158         * cp-support.c (add_symbol_overload_list_qualified): Update.
12159         * breakpoint.c (create_overlay_event_breakpoint)
12160         (create_longjmp_master_breakpoint)
12161         (create_std_terminate_master_breakpoint)
12162         (create_exception_master_breakpoint): Update.
12163         * blockframe.c (find_pc_partial_function): Update.
12164         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12165         (ada_collect_symbol_completion_matches)
12166         (ada_add_global_exceptions): Update.
12167
12168 2019-01-17  Tom Tromey  <tom@tromey.com>
12169
12170         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12171         declare VEC.
12172         (solib_target_parse_libraries): Change return type.
12173         (library_list_start_segment, library_list_start_section)
12174         (library_list_end_library, library_list_start_library); Update.
12175         (solib_target_free_library_list): Remove.
12176         (solib_target_parse_libraries): Remove cleanup.  Change return
12177         type.
12178         (solib_target_current_sos): Update.
12179
12180 2019-01-17  Tom Tromey  <tromey@bapiya>
12181
12182         * valprint.c: Replace "the the" with "the".
12183         * symtab.c: Replace "the the" with "the".
12184         * solib.c: Replace "the the" with "the".
12185         * solib-dsbt.c: Replace "the the" with "the".
12186         * linespec.c: Replace "the the" with "the".
12187         * dwarf2loc.h: Replace "the the" with "the".
12188         * amd64-windows-tdep.c: Replace "the the" with "the".
12189         * aarch64-tdep.c: Replace "the the" with "the".
12190
12191 2019-01-16  Keith Seitz  <keiths@redhat.com>
12192
12193         PR gdb/23773
12194         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12195         <builder>: Rename to ..
12196         <m_builder>: ... this and make private.
12197         (dwarf2_cu::get_builder): New method.  Change all users of
12198         `builder' to use this method.
12199         (dwarf2_start_symtab): Move to ...
12200         (dwarf2_cu::start_symtab): ... here.  Update all callers
12201         (setup_type_unit_groups): Move to ...
12202         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12203         callers.
12204         (dwarf2_cu::reset_builder): New method.
12205         (process_full_compunit, process_full_type_unit): Use
12206         dwarf2_cu::reset_builder.
12207         (follow_die_offset): Record the ancestor CU if it is different
12208         from the followed DIE's CU.
12209         (follow_die_sig_1): Likewise.
12210
12211 2019-01-15  Tom Tromey  <tom@tromey.com>
12212
12213         * remote.c (class remote_state) <buf>: Now a char_vector.
12214         <buf_size>: Remove.
12215         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12216         parameter.
12217         (remote_target::getpkt_or_notif_sane_1)
12218         (remote_target::getpkt_sane)
12219         (remote_target::getpkt_or_notif_sane): Likewise.
12220         (class remote_target) <putpkt>: New overload.
12221         (remote_target::read_frame): Change type of "buf_p".  Remove
12222         sizeof_p parameter.
12223         (packet_ok): New overload.
12224         (packet_check_result): New overload.
12225         Update all uses.
12226
12227 2019-01-14  Tom Tromey  <tom@tromey.com>
12228
12229         * remote-notif.c (handle_notification, remote_notif_ack)
12230         (remote_notif_parse): Make "buf" const.
12231         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12232         const.
12233         (remote_notif_parse, remote_notif_ack, handle_notification):
12234         Likewise.
12235         * remote.c (remote_notif_stop_parse): Make "buf" const.
12236         (remote_target::remote_parse_stop_reply): Make "buf" const.
12237         (remote_notif_stop_ack): Make "buf" const.
12238
12239 2019-01-14  Tom Tromey  <tom@tromey.com>
12240
12241         * remote.c (remote_console_output): Make parameter const.
12242
12243 2019-01-14  Tom Tromey  <tom@tromey.com>
12244
12245         * target-debug.h (target_debug_print_signals): Constify.
12246         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12247         * procfs.c (procfs_target::pass_signals): Update.
12248         * linux-nat.c (linux_nat_target::pass_signals): Update.
12249         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12250         * target-delegates.c: Rebuild.
12251         * remote.c (remote_target::program_signals): Update.
12252         (remote_target::pass_signals): Update.
12253         * target.c (target_pass_signals): Constify argument.
12254         (target_program_signals): Likewise.
12255         * target.h (struct target_ops) <pass_signals, program_signals>:
12256         Constify argument.
12257         (target_pass_signals, target_program_signals): Constify argument.
12258
12259 2019-01-14  Tom Tromey  <tom@tromey.com>
12260
12261         PR tui/28819:
12262         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12263
12264 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12265
12266         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12267         field.
12268         * rs6000-tdep.c: Include reggroups.h.
12269         (IS_V_ALIAS_PSEUDOREG): Define.
12270         (rs6000_register_name): Return names for the "vX" aliases.
12271         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12272         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12273         aliases.  Call default_register_reggroup_p for all other
12274         pseudo-registers.
12275         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12276         New functions.
12277         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12278         Handle "vX" aliases.
12279         (v_alias_pseudo_register_collect): New function.
12280         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12281         (rs6000_gdbarch_init): Initialize "vX" aliases as
12282         pseudo-registers.  Restore registration of
12283         rs6000_pseudo_register_reggroup_p with
12284         set_tdesc_pseudo_register_reggroup_p.
12285
12286 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12287
12288         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12289         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12290         set_gdbarch_num_pseudo_regs.
12291
12292 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12293
12294         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12295         Remove arg prefixname, add do_set and do_show.
12296         Add member functions set_list and show_list.
12297         * cli/cli-style.c (class cli_style_option): Update accordingly.
12298         (style_set_list): Move to file scope.
12299         (style_show_list): Likewise.
12300         (set_style): Call help_list.
12301         (show_style): Call cmd_show_list.
12302         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12303         Update to use the new macro.
12304
12305 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12306
12307         * ada-lang.c (_initialize_ada_language): Expand the help text
12308         for the "catch exception" command.
12309
12310 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12311
12312         * symtab.c (matching_obj_sections): Initialize obj,
12313         declare it closer to its usage.
12314
12315 2019-01-10  Tom Tromey  <tom@tromey.com>
12316
12317         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12318         (basic_inf_threads_range): Remove.
12319         (inf_threads_range, inf_non_exited_threads_range)
12320         (safe_inf_threads_range): Use next_adapter.
12321
12322 2019-01-10  Keith Seitz  <keiths@redhat.com>
12323
12324         PR gdb/23712
12325         PR symtab/23010
12326         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12327         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12328
12329 2019-01-10  Keith Seitz  <keiths@redhat.com>
12330
12331         PR gdb/23712
12332         PR symtab/23010
12333         * dictionary.c (pending_to_vector): Remove.
12334         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12335         Remove _1 suffix, replacing functions of the same name.  Update
12336         all callers.
12337         (dict_create_hashed, dict_create_hashed_expandable)
12338         (dict_create_linear, dict_create_linear_expandable, dict_free)
12339         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12340         Make functions static.
12341
12342 2019-01-10  Keith Seitz  <keiths@redhat.com>
12343
12344         PR gdb/23712
12345         PR symtab/23010
12346         * dictionary.h (struct dictionary): Replace declaration with
12347         multidictionary.
12348         (dict_create_hashed, dict_create_hashed_expandable)
12349         (dict_create_linear, dict_create_linear_expandable)
12350         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12351         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12352         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12353         taking multidictionary argument.
12354         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12355         * block.h (struct block) <dict>: Change to multidictionary
12356         and rename `multidict'.
12357         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12358         symmisc.c: Update all dictionary references to multidictionary.
12359
12360 2019-01-10  Keith Seitz  <keiths@redhat.com>
12361
12362         PR gdb/23712
12363         PR symtab/23010
12364         * dictionary.c: Include unordered_map.
12365         (pending_to_vector): New function.
12366         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12367         Rewrite the non-"_1" functions to take vector instead
12368         of linked list.
12369         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12370         "new" _1 versions of the same name.
12371         (multidictionary): Define.
12372         (std::hash<enum language): New definition.
12373         (collate_pending_symbols_by_language, mdict_create_hashed)
12374         (mdict_create_hashed_expandable, mdict_create_linear)
12375         (mdict_create_linear_expandable, mdict_free)
12376         (find_language_dictionary, create_new_language_dictionary)
12377         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12378         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12379         (mdict_size, mdict_empty): New functions.
12380         * dictionary.h (mdict_iterator): Define.
12381
12382 2019-01-10  Pedro Alves  <palves@redhat.com>
12383
12384         * breakpoint.c (read_uploaded_action)
12385         (create_tracepoint_from_upload): Adjust to use
12386         gdb::unique_xmalloc_ptr.
12387         * ctf.c (ctf_write_uploaded_tp):
12388         (SET_ARRAY_FIELD): Use emplace_back.
12389         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12390         * tracefile-tfile.c (tfile_write_uploaded_tp):
12391         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12392         gdb::unique_xmalloc_ptr.
12393         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12394         at_string, cond_string, cmd_strings>: Replace char pointers
12395         with gdb::unique_xmalloc_ptr.
12396
12397 2019-01-10  Pedro Alves  <palves@redhat.com>
12398
12399         * solib-target.c (library_list_start_library): Don't xstrdup name.
12400
12401 2019-01-10  Pedro Alves  <palves@redhat.com>
12402
12403         * mdebugread.c (parse_partial_symbols): Use
12404         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12405
12406 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12407
12408         * linux-fork.c (scoped_switch_fork_info)
12409         <~scoped_switch_fork_info>: Fix incorrect variable name.
12410
12411 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12412
12413         * linux-fork.c (scoped_switch_fork_info)
12414         <scoped_switch_fork_info>: Make explicit.
12415         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12416
12417 2019-01-10  Tom Tromey  <tom@tromey.com>
12418
12419         * objfiles.h (objfile::reset_psymtabs): Update.
12420         * objfiles.c (objfile::objfile): Update.
12421         * psymtab.h (psymtab_storage::obstack): Update.
12422         (psymtab_storage::m_obstack): Use gdb::optional.
12423         (class psymtab_storage): Update comment.  Remove objfile
12424         parameter.
12425         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12426
12427 2019-01-10  Tom Tromey  <tom@tromey.com>
12428
12429         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12430         <free_psymtabs>: Now private.
12431         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12432         (allocate_psymtab): Use new method.
12433
12434 2019-01-10  Tom Tromey  <tom@tromey.com>
12435
12436         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12437         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12438         * mdebugread.c (parse_partial_symbols): Use
12439         allocate_dependencies.
12440         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12441         allocate_dependencies.
12442         (process_psymtab_comp_unit_reader)
12443         (build_type_psymtab_dependencies): Likewise.
12444         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12445
12446 2019-01-10  Tom Tromey  <tom@tromey.com>
12447
12448         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12449         PSYMBOL_SET_LANGUAGE.
12450         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12451
12452 2019-01-10  Tom Tromey  <tom@tromey.com>
12453
12454         * psymtab.h (psymtab_storage::obstack): New method.
12455         <m_obstack>: Rename from obstack; now private.
12456         * psymtab.c (psymtab_storage): Update.
12457         * dwarf2read.c (create_addrmap_from_index)
12458         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12459         Update.
12460
12461 2019-01-10  Tom Tromey  <tom@tromey.com>
12462
12463         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12464         * objfiles.h (objfile::reset_psymtabs): New method.
12465
12466 2019-01-10  Tom Tromey  <tom@tromey.com>
12467
12468         * symmisc.c (print_symbol_bcache_statistics): Update.
12469         (print_objfile_statistics): Update.
12470         * symfile.c (reread_symbols): Update.
12471         * psymtab.h (class psymtab_storage): New.
12472         * psymtab.c (psymtab_storage): New constructor.
12473         (~psymtab_storage): New destructor.
12474         (require_partial_symbols): Update.
12475         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12476         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12477         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12478         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12479         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12480         (start_psymtab_common, end_psymtab_common)
12481         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12482         (allocate_psymtab): Update.
12483         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12484         Update.
12485         (dump_psymtab_addrmap, maintenance_print_psymbols)
12486         (maintenance_check_psymtabs): Update.
12487         (class objfile_psymtabs): Move to objfiles.h.
12488         * psympriv.h (discard_psymtab): Now inline.
12489         (psymtab_discarder::psymtab_discarder): Update.
12490         (psymtab_discarder::~psymtab_discarder): Update.
12491         (ALL_OBJFILE_PSYMTABS): Rewrite.
12492         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12493         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12494         Remove fields.
12495         <partial_symtabs>: New field.
12496         (class objfile_psymtabs): Move from psymtab.h.  Update.
12497         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12498         psymbol_cache.
12499         (objfile::~objfile): Don't destroy psymbol_cache.
12500         * mdebugread.c (parse_partial_symbols): Update.
12501         * dwarf2read.c (create_addrmap_from_index)
12502         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12503         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12504         (add_partial_subprogram, dwarf2_ranges_read): Update.
12505         * dwarf-index-write.c (write_address_map)
12506         (write_one_signatured_type, recursively_write_psymbols)
12507         (class debug_names, class debug_names, write_psymtabs_to_index):
12508         Update.
12509
12510 2019-01-10  Tom Tromey  <tom@tromey.com>
12511
12512         * symtab.h (SYMBOL_SET_NAMES): Update.
12513         (symbol_set_names): Update.
12514         (MSYMBOL_SET_NAMES): Update.
12515         * symtab.c (symbol_set_names): Change argument to be an
12516         objfile_per_bfd_storage.
12517         * psymtab.c (add_psymbol_to_bcache): Update.
12518         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12519
12520 2019-01-10  Tom Tromey  <tom@tromey.com>
12521
12522         * symtab.c (create_demangled_names_hash): Change argument to be an
12523         objfile_per_bfd_storage.
12524         (symbol_set_names): Update.
12525
12526 2019-01-10  Tom Tromey  <tom@tromey.com>
12527
12528         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12529         init_psymbol_list.
12530         * psymtab.c (init_psymbol_list): Do nothing if already called.
12531         * psympriv.h (init_psymbol_list): Add comment.
12532         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12533         init_psymbol_list.
12534         * dbxread.c (dbx_symfile_read): Unconditionally call
12535         init_psymbol_list.
12536
12537 2019-01-10  Tom Tromey  <tom@tromey.com>
12538
12539         * xcoffread.c (scan_xcoff_symtab): Update.
12540         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12541         "where".
12542         * mdebugread.c (parse_partial_symbols)
12543         (handle_psymbol_enumerators): Update.
12544         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12545         * dbxread.c (read_dbx_symtab): Update.
12546         * psympriv.h (psymbol_placement): New enum.
12547         (add_psymbol_to_list): Update.
12548
12549 2019-01-10  Tom Tromey  <tom@tromey.com>
12550
12551         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12552         static_psymbols parameters.
12553         (scan_xcoff_symtab): Update.
12554         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12555         static_psymbols parameters.
12556         * psympriv.h (start_psymtab_common): Update.
12557         * mdebugread.c (parse_partial_symbols): Update.
12558         * dwarf2read.c (create_partial_symtab): Update.
12559         * dbxread.c (read_dbx_symtab): Update.
12560         (start_psymtab): Remove global_psymbols and static_psymbols
12561         parameters.
12562
12563 2019-01-10  Tom Tromey  <tom@tromey.com>
12564
12565         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12566         * psymtab.c (allocate_psymtab): Add comment.
12567         * psympriv.h (allocate_psymtab): Add comment.
12568         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12569         initializations.
12570         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12571
12572 2019-01-10  Tom Tromey  <tom@tromey.com>
12573
12574         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12575         Don't declare.
12576         * mipsread.c: Include mdebugread.h.
12577         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12578         Declare.
12579         * elfread.c: Include mdebugread.h.
12580
12581 2019-01-09  Tom Tromey  <tom@tromey.com>
12582
12583         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12584         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12585         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12586         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12587         (psym_lookup_symbol, psym_find_last_source_symtab)
12588         (psym_forget_cached_source_info, psym_print_stats)
12589         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12590         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12591         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12592         (psym_find_compunit_symtab_by_address)
12593         (maintenance_print_psymbols, maintenance_info_psymtabs)
12594         (maintenance_check_psymtabs): Use ranged for.
12595         * psymtab.h (class objfile_psymtabs): New.
12596         (require_partial_symbols): Return objfile_psymtabs.
12597         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12598
12599 2019-01-09  Tom Tromey  <tom@tromey.com>
12600
12601         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12602         (find_pc_mapped_section, list_overlays_command)
12603         (map_overlay_command, unmap_overlay_command)
12604         (simple_overlay_update): Use all_objfiles.
12605         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12606         * printcmd.c (info_symbol_command): Use all_objfiles.
12607         * objfiles.h (ALL_OBJSECTIONS): Remove.
12608         * maint.c (maintenance_translate_address): Use all_objfiles.
12609         * gcore.c (gcore_create_callback): Use all_objfiles.
12610         (objfile_find_memory_regions): Likewise.
12611
12612 2019-01-09  Tom Tromey  <tom@tromey.com>
12613
12614         * symtab.c (find_line_symtab, info_sources_command)
12615         (make_source_files_completion_list): Use objfile_compunits.
12616         * source.c (select_source_symtab): Use objfile_compunits.
12617         * objfiles.h (struct objfile): Update comment.
12618         (ALL_OBJFILES): Remove.
12619         (ALL_FILETABS): Remove.
12620         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12621         objfile_compunits.
12622
12623 2019-01-09  Tom Tromey  <tom@tromey.com>
12624
12625         * symmisc.c (print_objfile_statistics, dump_objfile)
12626         (maintenance_print_symbols): Use compunit_filetabs.
12627         * source.c (forget_cached_source_info_for_objfile): Use
12628         compunit_filetabs.
12629         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12630         (ALL_FILETABS): Use compunit_filetabs.
12631         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12632         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12633
12634 2019-01-09  Tom Tromey  <tom@tromey.com>
12635
12636         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12637         (compunit_filetabs): New.
12638         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12639         compunit_filetabs.
12640         (info_sources_command, make_source_files_completion_list): Remove
12641         declaration.
12642         * symmisc.c (print_objfile_statistics, dump_objfile)
12643         (maintenance_print_symbols): Remove declaration.
12644         (maintenance_info_symtabs): Use compunit_filetabs.
12645         (maintenance_info_line_tables): Likewise.
12646         * source.c (select_source_symtab): Change local variable name.
12647         (forget_cached_source_info_for_objfile): Remove declaration.
12648         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12649         * objfiles.c (objfile_relocate1): Remove declaration.
12650         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12651         declaration.
12652         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12653         * coffread.c (coff_symtab_read): Remove declaration.
12654         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12655         compunit_filetabs.
12656
12657 2019-01-09  Tom Tromey  <tom@tromey.com>
12658
12659         * symtab.c (lookup_objfile_from_block)
12660         (find_pc_sect_compunit_symtab, search_symbols)
12661         (default_collect_symbol_completion_matches_break_on): Use
12662         objfile_compunits.
12663         * objfiles.h (ALL_COMPUNITS): Remove.
12664         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12665         * cp-support.c (add_symbol_overload_list_qualified): Use
12666         objfile_compunits.
12667         * ada-lang.c (ada_collect_symbol_completion_matches)
12668         (ada_add_global_exceptions): Use objfile_compunits.
12669
12670 2019-01-09  Tom Tromey  <tom@tromey.com>
12671
12672         * source.c (select_source_symtab)
12673         (forget_cached_source_info_for_objfile): Remove declaration.
12674         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12675         declaration.
12676         * maint.c (count_symtabs_and_blocks): Remove declaration.
12677         * cp-support.c (add_symbol_overload_list_qualified): Remove
12678         declaration.
12679         * coffread.c (coff_symtab_read): Remove declaration.
12680         * symtab.c (lookup_symbol_in_objfile_symtabs)
12681         (basic_lookup_transparent_type_1): Use objfile_compunits.
12682         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12683         (info_sources_command, search_symbols)
12684         (default_collect_symbol_completion_matches_break_on)
12685         (make_source_files_completion_list): Remove declaration.
12686         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12687         (ada_collect_symbol_completion_matches)
12688         (ada_add_global_exceptions): Remove declaration.
12689         * linespec.c (iterate_over_all_matching_symtabs): Use
12690         objfile_compunits.
12691         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12692         (class objfile_compunits): New.
12693         (ALL_COMPUNITS): Use objfile_compunits.
12694         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12695         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12696         objfile_compunits.
12697         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12698
12699 2019-01-09  Tom Tromey  <tom@tromey.com>
12700
12701         * symtab.c (search_symbols)
12702         (default_collect_symbol_completion_matches_break_on): Use
12703         objfile_msymbols.
12704         * ada-lang.c (ada_lookup_simple_minsym)
12705         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12706         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12707         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12708         objfile_msymbols.
12709         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12710         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12711         * objc-lang.c (find_methods): Use objfile_msymbols.
12712         (info_selectors_command, info_classes_command): Likewise.
12713         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12714         * objfiles.h (class objfile_msymbols): New.
12715         (ALL_OBJFILE_MSYMBOLS): Remove.
12716         (ALL_MSYMBOLS): Remove.
12717
12718 2019-01-09  Tom Tromey  <tom@tromey.com>
12719
12720         * common/next-iterator.h (next_adapter): Add Iterator template
12721         parameter.
12722         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12723         (class all_objfiles_safe): New.
12724         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12725         * objfiles.c (put_objfile_before): Update comment.
12726         (add_separate_debug_objfile): Likewise.
12727         (free_all_objfiles): Use all_objfiles_safe.
12728         (objfile_purge_solibs): Likewise.
12729
12730 2019-01-09  Tom Tromey  <tom@tromey.com>
12731
12732         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12733         (expand_symtab_containing_pc, lookup_static_symbol)
12734         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12735         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12736         all_objfiles.
12737         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12738         * breakpoint.c (create_overlay_event_breakpoint)
12739         (create_longjmp_master_breakpoint)
12740         (create_std_terminate_master_breakpoint)
12741         (create_exception_master_breakpoint): Use all_objfiles.
12742         * linux-thread-db.c (try_thread_db_load_from_pdir)
12743         (has_libpthread): Use all_objfiles.
12744         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12745         * linespec.c (iterate_over_all_matching_symtabs)
12746         (search_minsyms_for_name): Use all_objfiles.
12747         * maint.c (maintenance_info_sections): Use all_objfiles.
12748         * main.c (captured_main_1): Use all_objfiles.
12749         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12750         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12751         * guile/scm-pretty-print.c
12752         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12753         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12754         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12755         (maintenance_print_msymbols): Use all_objfiles.
12756         * source.c (select_source_symtab): Use all_objfiles.
12757         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12758         * symfile.c (remove_symbol_file_command)
12759         (expand_symtabs_matching, map_symbol_filenames): Use
12760         all_objfiles.
12761         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12762         all_objfiles.
12763         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12764         * objc-lang.c (find_methods): Use all_objfiles.
12765         * objfiles.c (have_partial_symbols, have_full_symbols)
12766         (have_minimal_symbols, qsort_cmp)
12767         (default_iterate_over_objfiles_in_search_order): Use
12768         all_objfiles.
12769         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12770         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12771         (maintenance_check_psymtabs): Use all_objfiles.
12772         (ALL_PSYMTABS): Remove.
12773         * compile/compile-object-run.c (do_module_cleanup): Use
12774         all_objfiles.
12775         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12776         * cp-support.c (add_symbol_overload_list_qualified): Use
12777         all_objfiles.
12778         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12779         Use all_objfiles.
12780         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12781         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12782         all_objfiles.
12783         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12784         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12785         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12786         Uses all_objfiles.
12787         * solib.c (solib_read_symbols): Use all_objfiles
12788
12789 2019-01-09  Tom Tromey  <tom@tromey.com>
12790
12791         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12792         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12793         all_objfiles.
12794         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12795         * symmisc.c (print_symbol_bcache_statistics)
12796         (print_objfile_statistics, maintenance_print_objfiles)
12797         (maintenance_info_symtabs, maintenance_check_symtabs)
12798         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12799         all_objfiles.
12800         * source.c (forget_cached_source_info): Use all_objfiles.
12801         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12802         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12803         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12804         * objfiles.c (update_section_map): Use all_objfiles.
12805         (shared_objfile_contains_address_p): Likewise.
12806         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12807         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12808
12809 2019-01-09  Tom Tromey  <tom@tromey.com>
12810
12811         * common/next-iterator.h: New file.
12812         * objfiles.h (class all_objfiles): New.
12813         (struct objfile_iterator): New.
12814
12815 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12816
12817         * NEWS: Move the description of the changed "frame", "select-frame",
12818          and "info frame" commands to the Changed commands section.
12819
12820 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12821
12822         * gdbtypes.c (check_stub_method_group): Remove handling of old
12823         mangling schemes.
12824         * linespec.c (find_methods): Likewise.
12825         * stabsread.c (read_member_functions): Likewise.
12826         * valops.c (search_struct_method): Likewise.
12827         (value_struct_elt_for_reference): Likewise.
12828         * NEWS: Mention this change.
12829
12830 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12831
12832         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12833         print_source_lines.
12834         * source.c (print_source_lines_base): Update line number check.
12835         (print_source_lines): New function.
12836         (source_lines_range::source_lines_range): New function.
12837         * source.h (class source_lines_range): New class.
12838         (print_source_lines): New declaration.
12839
12840 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12841
12842         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12843
12844 2019-01-08  Tom Tromey  <tom@tromey.com>
12845             Simon Marchi  <simon.marchi@ericsson.com>
12846
12847         PR gdb/24060
12848         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12849         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12850         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12851         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12852         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12853         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12854
12855 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12856
12857         * source.c (select_source_symtab): Move header comment to
12858         declaration in source.h.
12859         (forget_cached_source_info_for_objfile): Likewise.
12860         (forget_cached_source_info): Likewise.
12861         (identify_source_line): Likewise.
12862         * source.h (identify_source_line): Move declaration from symtab.h
12863         and add comment from source.c
12864         (print_source_lines): Likewise.
12865         (forget_cached_source_info_for_objfile): Likewise.
12866         (forget_cached_source_info): Likewise.
12867         (select_source_symtab): Likewise.
12868         (enum print_source_lines_flag): Move definition from symtab.h.
12869         * symtab.h (identify_source_line): Move declaration to source.h.
12870         (print_source_lines): Likewise.
12871         (forget_cached_source_info_for_objfile): Likewise.
12872         (forget_cached_source_info): Likewise.
12873         (select_source_symtab): Likewise.
12874         (enum print_source_lines_flag): Move definition to source.h.
12875         * tui/tui-hooks.c: Add 'source.h' include.
12876
12877 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12878
12879         * source.c (print_source_lines_base): Handle requests to print
12880         reverse line number sequences, and guard against empty lines
12881         string.
12882
12883 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12884
12885         * source.c (print_source_lines_base): Fix skip of '\r' if next
12886         character is '\n'.
12887
12888 2019-01-06  Tom Tromey  <tom@tromey.com>
12889
12890         * c-exp.y (struct c_parse_state) <macro_original_text,
12891         expansion_obstack>: New member.
12892         (macro_original_text, expansion_obstack): Remove globals.
12893         (scan_macro_expansion, scanning_macro_expansion)
12894         (finished_macro_expansion): Update.
12895         (scan_macro_cleanup): Remove.
12896         (yylex, c_parse): Update.
12897
12898 2019-01-06  Tom Tromey  <tom@tromey.com>
12899
12900         * c-exp.y (struct c_parse_state) <strings>: New member.
12901         (operator_stoken): Update.
12902
12903 2019-01-06  Tom Tromey  <tom@tromey.com>
12904
12905         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12906         (union type_stack_elt) <typelist_val>: Now a pointer to
12907         std::vector.
12908         (type_stack_cleanup): Don't declare.
12909         (push_typelist): Update.
12910         * parse.c (pop_typelist): Return a std::vector.
12911         (push_typelist): Take a std::vector.
12912         (follow_types): Update.  Do not free args.
12913         (type_stack_cleanup): Remove.
12914         * c-exp.y (struct c_parse_state): New.
12915         (cpstate): New global.
12916         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12917         (nonempty_typelist): Update.
12918         (func_mod): Create a new vector.
12919         (c_parse): Create a c_parse_state.
12920         (check_parameter_typelist): Do not delete params.
12921         (function_method): Update.  Do not delete type_list.
12922
12923 2019-01-06  Tom Tromey  <tom@tromey.com>
12924
12925         PR gdb/28155:
12926         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12927         check_typedef.
12928         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12929         (print_return_value): Likewise.
12930
12931 2019-01-05  Tom Tromey  <tom@tromey.com>
12932
12933         * contrib/cleanup_check.py: Remove.
12934         * contrib/gcc-with-excheck: Remove.
12935         * contrib/exsummary.py: Remove.
12936         * contrib/excheck.py: Remove.
12937
12938 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12939
12940         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12941         NULL. Initialize tpprev to NULL instead of assigning it
12942         to NULL on the next statement.
12943         * windows-nat.c (windows_delete_thread): Remove check for
12944         main_thread_id before printing thread exit notifications.
12945         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12946         Remove thread ID check against main_thread_id.
12947         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12948         windows_delete_thread.
12949         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12950
12951 2019-01-04  Tom Tromey  <tom@tromey.com>
12952
12953         * compile/compile.c (_initialize_compile): Use upper case for
12954         metasyntactic variables.
12955         * symmisc.c (_initialize_symmisc): Use upper case for
12956         metasyntactic variables.
12957         * psymtab.c (_initialize_psymtab): Use upper case for
12958         metasyntactic variables.
12959         * demangle.c (demangle_command): Use upper case for metasyntactic
12960         variables.
12961         (_initialize_demangler): Likewise.
12962         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12963         variables.
12964
12965 2019-01-03  Tom Tromey  <tom@tromey.com>
12966
12967         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12968
12969 2019-01-03  Tom Tromey  <tom@tromey.com>
12970
12971         * python/py-symtab.c (salpy_str): Update.
12972         (struct salpy_sal_object) <symtab>: Now a PyObject.
12973         (salpy_dealloc): Update.
12974         (del_objfile_sal): Use gdbpy_ref.
12975
12976 2019-01-03  Tom Tromey  <tom@tromey.com>
12977
12978         * python/py-type.c (convert_field): Use new_reference.  Return
12979         gdbpy_ref.
12980         (make_fielditem): Return gdbpy_ref.
12981         (typy_fields): Update.
12982         (typy_getitem): Update.
12983         (field_name): Return gdbpy_ref.  Use new_reference.
12984         (typy_iterator_iternext): Update.
12985
12986 2019-01-03  Tom Tromey  <tom@tromey.com>
12987
12988         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12989
12990 2019-01-03  Tom Tromey  <tom@tromey.com>
12991
12992         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12993         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12994         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12995         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12996         (pspy_set_type_printers): Likewise.
12997         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12998         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12999         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13000         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13001         (objfpy_set_type_printers): Likewise.
13002
13003 2019-01-03  Tom Tromey  <tom@tromey.com>
13004
13005         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13006         (gdbpy_print_stack): Use gdbpy_err_fetch.
13007         * python/python-internal.h (class gdbpy_err_fetch): New class.
13008         (class gdbpy_enter) <m_error_type, m_error_value,
13009         m_error_traceback>: Remove.
13010         <m_error>: New member.
13011         (gdbpy_exception_to_string): Don't declare.
13012         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13013         * python/py-value.c (convert_value_from_python): Use
13014         gdbpy_err_fetch.
13015         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13016         gdbpy_exception_to_string.
13017         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13018         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13019         gdbpy_err_fetch.
13020
13021 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13022
13023         * linux-nat.c (delete_lwp_cleanup): Delete.
13024         (struct lwp_deleter): New struct.
13025         (lwp_info_up): New typedef.
13026         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13027         lwp_info_up.
13028
13029 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13030
13031         * linux-fork.c (class scoped_switch_fork_info): New class.
13032         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13033
13034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13035
13036         * valops.c (find_overload_match): Remove use of null_cleanup, and
13037         calls to do_cleanups.
13038
13039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13040
13041         * compile/compile-cplus-types.c
13042         (compile_cplus_instance::decl_name): Handle changes to
13043         cp_func_name.
13044         * cp-support.c (cp_func_name): Update header comment, update
13045         return type.
13046         * cp-support.h (cp_func_name): Update return type in declaration.
13047         * valops.c (find_overload_match): Move temp_func local to top
13048         level of function and change its type.  Use temp_func to hold and
13049         delete temporary string obtained from cp_func_name.
13050
13051 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13052
13053         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13054         gdb::char_vector, remove cleanup, and update uses of `msg`.
13055
13056 2019-01-03  Jim Wilson  <jimw@sifive.com>
13057
13058         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13059
13060 2019-01-02  Tom Tromey  <tom@tromey.com>
13061
13062         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13063         (tdesc_parse_xml): Remove cleanups.
13064         * target-descriptions.h (make_cleanup_free_target_description):
13065         Don't declare.
13066         (target_desc_deleter): New struct.
13067         (target_desc_up): New typedef.
13068         * target-descriptions.c (target_desc_deleter::operator()): Rename
13069         from free_target_description.
13070         (make_cleanup_free_target_description): Remove.
13071
13072 2019-01-02  Tom Tromey  <tom@tromey.com>
13073
13074         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13075         constructor, destructor.
13076         (linespec_parser): Remove typedef.
13077         (~linespec_parser): Rename from linespec_parser_delete.
13078         (linespec_lex_to_end, linespec_complete_label)
13079         (linespec_complete): Update.
13080         (decode_line_full): Remove cleanups.
13081         (decode_line_1): Update.
13082
13083 2019-01-02  Tom Tromey  <tom@tromey.com>
13084
13085         * python/python-internal.h (inferior_to_inferior_object): Change
13086         return type.
13087         * python/py-exitedevent.c (create_exited_event_object): Update.
13088         * python/py-inferior.c (inferior_to_inferior_object): Return
13089         gdbpy_ref.
13090         (python_new_inferior, python_inferior_deleted)
13091         (thread_to_thread_object, delete_thread_object)
13092         (build_inferior_list, gdbpy_selected_inferior): Update.
13093         * python/py-infthread.c (create_thread_object): Update.  Also fail
13094         if inferior_to_inferior_object fails.
13095
13096 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13097
13098         * inferior.h (class inferior) <displaced_step_state>: New field.
13099         * infrun.h (struct displaced_step_state): Move here from
13100         infrun.c.  Initialize fields, add constructor.
13101         <inf>: Remove field.
13102         <reset>: New method.
13103         * infrun.c (struct displaced_step_inferior_state): Move to
13104         infrun.h.
13105         (displaced_step_inferior_states): Remove.
13106         (get_displaced_stepping_state): Adust.
13107         (displaced_step_in_progress_any_inferior): Adjust.
13108         (displaced_step_in_progress_thread): Adjust.
13109         (displaced_step_in_progress): Adjust.
13110         (add_displaced_stepping_state): Remove.
13111         (get_displaced_step_closure_by_addr): Adjust.
13112         (remove_displaced_stepping_state): Remove.
13113         (infrun_inferior_exit): Call displaced_step_state.reset.
13114         (use_displaced_stepping): Don't check for NULL.
13115         (displaced_step_prepare_throw): Call
13116         get_displaced_stepping_state.
13117         (displaced_step_fixup): Don't check for NULL.
13118         (prepare_for_detach): Don't check for NULL.
13119
13120 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13121
13122         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13123          in case of call that did not complete.
13124
13125 2019-01-02  Andrey Utkin  <autkin@undo.io>
13126
13127         * symfile.c (find_separate_debug_file): Fix search of debug files for
13128         remote debuggee.
13129
13130 2019-01-02  Tom Tromey  <tom@tromey.com>
13131
13132         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13133         indentation.
13134         * python/py-frame.c (frapy_older): Remove cast.
13135         (frapy_newer): Likewise.
13136         * python/py-breakpoint.c (local_setattro): Remove cast.
13137         * python/py-arch.c (archpy_name): Remove local variable.
13138         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13139
13140 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13141
13142         * unittests/basic_string_view/element_access/char/empty.cc:
13143         Fix year range in copyright header.
13144
13145 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13146
13147         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13148         Delete.
13149         <operator==>: Update with for removed field.
13150         <hash>: Likewise.
13151         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13152         <isa_features>: ...this.
13153         <abi_features>: New field.
13154         (riscv_isa_flen): Update comment.
13155         (riscv_abi_xlen): New declaration.
13156         (riscv_abi_flen): New declaration.
13157         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13158         isa_features.
13159         (riscv_abi_xlen): New function.
13160         (riscv_isa_flen): Update to get answer from isa_features.
13161         (riscv_abi_flen): New function.
13162         (riscv_has_fp_abi): Update to get answer from abi_features.
13163         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13164         xlen and flen.
13165         (riscv_call_info) <xlen, flen>: Update comment.
13166         (riscv_call_arg_struct): Remove invalid assertions
13167         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13168         is removed.
13169         (riscv_gdbarch_init): Gather isa features and abi features
13170         separately, ensure both match on the gdbarch when reusing an old
13171         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13172         a target with 64-bit float hardware.
13173
13174 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13175
13176         * source.c (search_command_helper): Stop reverse search
13177         when line 1 has been searched.
13178
13179 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13180
13181         * record-full.c (record_full_base_target::close): Rewrite
13182         record_full_core_buf_list free logic.
13183
13184 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13185
13186         * break-catch-syscall.c (print_one_catch_syscall): xfree
13187         the last text.
13188
13189 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13190
13191         * top.c (print_gdb_version): Update Copyright year in version
13192         message.
13193
13194 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13195
13196         Update copyright year range in all GDB files.
13197
13198 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13199
13200         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13201
13202 For older changes see ChangeLog-2018.
13203 \f
13204 Local Variables:
13205 mode: change-log
13206 left-margin: 8
13207 fill-column: 74
13208 version-control: never
13209 coding: utf-8
13210 End:
13211