gdb/ChangeLog

   1 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
   4         variant for ada_tasks_pspace_data_handle and
   5         ada_tasks_inferior_data_handle.
   6         (ada_tasks_pspace_data_cleanup): New function.
   7         (ada_tasks_inferior_data_cleanup): New function.
   8
   9 2019-02-17  Tom Tromey  <tom@tromey.com>
  10
  11         * macrotab.h (macro_source_fullname): Return a std::string.
  12         * macrotab.c (macro_include, check_for_redefinition)
  13         (macro_undef, macro_lookup_definition, foreach_macro)
  14         (foreach_macro_in_scope): Update.
  15         (macro_source_fullname): Return a std::string.
  16         * macrocmd.c (show_pp_source_pos): Update.
  17
  18 2019-02-17  Tom Tromey  <tom@tromey.com>
  19
  20         * macrocmd.c (show_pp_source_pos): Style the file names.
  21
  22 2019-02-17  Tom Tromey  <tom@tromey.com>
  23
  24         PR tui/24197:
  25         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  26
  27 2019-02-17  Tom Tromey  <tom@tromey.com>
  28
  29         * ada-lang.c (user_select_syms): Use filtered printing.
  30         * utils.c (wrap_style): New global.
  31         (desired_style): Remove.
  32         (emit_style_escape): Add stream parameter.
  33         (set_output_style, reset_terminal_style, prompt_for_continue):
  34         Update.
  35         (flush_wrap_buffer): Only flush gdb_stdout.
  36         (wrap_here): Set wrap_style.
  37         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  38         treat escape sequences as a character.  Change when wrap buffer is
  39         flushed.
  40         (fputs_styled): Do not set the output style when the default is
  41         requested.
  42         * ui-style.h (struct ui_file_style) <is_default>: New method.
  43         * source.c (print_source_lines_base): Emit escape sequences in one
  44         piece.
  45
  46 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  47
  48         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  49         integers and enumeration types.
  50
  51 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  52
  53         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  54         instead of lookup_symbol_in_language
  55         (do_exact_match): New function.
  56         (ada_get_symbol_name_matcher): Return do_exact_match when
  57         doing a verbatim match.
  58
  59 2019-02-15  Tom Tromey  <tromey@adacore.com>
  60
  61         * ravenscar-thread.c (ravenscar_thread_target::resume)
  62         (ravenscar_thread_target::wait): Special case wildcard requests.
  63
  64 2019-02-15  Tom Tromey  <tromey@adacore.com>
  65
  66         * ravenscar-thread.c (base_ptid): Remove.
  67         (struct ravenscar_thread_target) <close>: New method.
  68         <m_base_ptid>: New member.
  69         <update_inferior_ptid, active_task, task_is_currently_active,
  70         runtime_initialized>: Declare methods.
  71         <ravenscar_thread_target>: Add constructor.
  72         (ravenscar_thread_target::task_is_currently_active)
  73         (ravenscar_thread_target::update_inferior_ptid)
  74         (ravenscar_runtime_initialized): Rename.  Now methods.
  75         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  76         (ravenscar_thread_target::update_thread_list): Update.
  77         (ravenscar_thread_target::active_task): Now method.
  78         (ravenscar_thread_target::store_registers)
  79         (ravenscar_thread_target::prepare_to_store)
  80         (ravenscar_thread_target::prepare_to_store)
  81         (ravenscar_thread_target::mourn_inferior): Update.
  82         (ravenscar_inferior_created): Use "new" to create target.
  83         (ravenscar_thread_target::get_ada_task_ptid): Update.
  84         (_initialize_ravenscar): Don't initialize base_ptid.
  85         (ravenscar_ops): Remove global.
  86
  87 2019-02-15  Tom Tromey  <tromey@adacore.com>
  88
  89         * target.h (push_target): Declare new overload.
  90         * target.c (push_target): New overload, taking an rvalue reference.
  91         * remote.c (remote_target::open_1): Use push_target overload.
  92         * corelow.c (core_target_open): Use push_target overload.
  93
  94 2019-02-15  Tom Tromey  <tromey@adacore.com>
  95
  96         * ravenscar-thread.c (is_ravenscar_task)
  97         (ravenscar_task_is_currently_active): Return bool.
  98         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  99         (_initialize_ravenscar): Remove "(void)".
 100         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 101         Return bool.
 102
 103 2019-02-15  Tom Tromey  <tromey@adacore.com>
 104
 105         * ravenscar-thread.c (ravenscar_runtime_initializer)
 106         (has_ravenscar_runtime, get_running_thread_id)
 107         (ravenscar_thread_target::resume): Fix indentation.
 108
 109 2019-02-15  Tom Tromey  <tromey@adacore.com>
 110
 111         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 112         from ravenscar_arch_ops.
 113         (sparc_ravenscar_ops::fetch_registers)
 114         (sparc_ravenscar_ops::store_registers): Now methods.
 115         (sparc_ravenscar_prepare_to_store): Remove.
 116         (sparc_ravenscar_ops): Redefine.
 117         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 118         methods and destructor.  Remove members.
 119         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 120         (ravenscar_thread_target::store_registers)
 121         (ravenscar_thread_target::prepare_to_store): Update.
 122         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 123         Remove.
 124         (struct ppc_ravenscar_powerpc_ops): Derive from
 125         ravenscar_arch_ops.
 126         (ppc_ravenscar_powerpc_ops::fetch_registers)
 127         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 128         (ppc_ravenscar_powerpc_ops): Redefine.
 129         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 130         (ppc_ravenscar_e500_ops::fetch_registers)
 131         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 132         (ppc_ravenscar_e500_ops): Redefine.
 133         * aarch64-ravenscar-thread.c
 134         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 135         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 136         (aarch64_ravenscar_fetch_registers)
 137         (aarch64_ravenscar_store_registers): Now methods.
 138         (aarch64_ravenscar_ops): Redefine.
 139
 140 2019-02-15  Tom Tromey  <tromey@adacore.com>
 141
 142         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 143         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 144         (ravenscar_thread_target::stopped_by_watchpoint)
 145         (ravenscar_thread_target::stopped_data_address)
 146         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 147
 148 2019-02-15  Tom Tromey  <tromey@adacore.com>
 149
 150         * ravenscar-thread.c: Fix some typos.
 151
 152 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 153             Tom Tromey  <tromey@adacore.com>
 154
 155         * ada-lang.c (ada_exception_sal): Change addr_string to a
 156         std::string.
 157         (create_ada_exception_catchpoint): Update.
 158
 159 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 160             Tom Tromey  <tromey@adacore.com>
 161
 162         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 163         (bp_location_ops): Remove.
 164         (base_breakpoint_allocate_location): Update.
 165         (free_bp_location): Update.
 166         * ada-lang.c (class ada_catchpoint_location)
 167         <ada_catchpoint_location>: Remove ops parameter.
 168         (ada_catchpoint_location_dtor): Remove.
 169         (ada_catchpoint_location_ops): Remove.
 170         (allocate_location_exception): Update.
 171         * breakpoint.h (struct bp_location_ops): Remove.
 172         (class bp_location) <bp_location>: Remove bp_location_ops
 173         parameter.
 174         <~bp_location>: Add destructor.
 175         <ops>: Remove.
 176
 177 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 178             Pedro Alves  <palves@redhat.com>
 179
 180         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 181         'PATH_MAX'.
 182
 183 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 184             Samuel Thibault  <samuel.thibault@gnu.org>
 185             Thomas Schwinge  <thomas@codesourcery.com>
 186
 187         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 188         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 189
 190 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 191
 192         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 193         (check_empty): Use "const char *".
 194
 195         * gnu-nat.c (gnu_nat_target::detach): Instead of
 196         'detach_inferior (pid)' call
 197         'detach_inferior (find_inferior_pid (pid))'.
 198
 199         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 200         'nat/fork-inferior.o'.
 201         * gnu-nat.c: #include "nat/fork-inferior.h".
 202
 203         * gnu-nat.c (gnu_nat_target::detach): Instead of
 204         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 205         * gnu-nat.h: #include "inf-child.h".
 206         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 207         'i386_gnu_nat_target::fetch_registers'.
 208         (gnu_store_registers): Rename/move to
 209         'i386_gnu_nat_target::store_registers'.
 210
 211         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 212         * gnu-nat.h (mach_thread_info): New function.
 213         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 214
 215         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 216
 217 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 218
 219         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 220
 221 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 222
 223         * windows-nat.c (windows_add_thread): Add new parameter
 224         "main_thread_p" with default value set to false.  Update
 225         function documentation as well as all callers.
 226         (windows_delete_thread): Likewise.
 227         (fake_create_process): Update call to windows_add_thread.
 228         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 229         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 230         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 231         call to windows_delete_thread.
 232
 233 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 234
 235         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 236
 237 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 238
 239         * symfile.c (find_separate_debug_file): Use canonical path of
 240         sysroot with child_path instead of gdb_sysroot if it is valid.
 241
 242 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 243
 244         * symfile.c (find_separate_debug_file): Use child_path to
 245         determine if an object file is under a sysroot.
 246
 247 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 248
 249         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 250         unittests/child-path-selftests.c.
 251         * common/pathstuff.c (child_path): New function.
 252         * common/pathstuff.h (child_path): New prototype.
 253         * unittests/child-path-selftests.c: New file.
 254
 255 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 256
 257         * symfile.c (find_separate_debug_file): Look for separate debug
 258         files in debug directories under the sysroot.
 259
 260 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 261
 262         * symtab.h (struct minimal_symbol data_p): New const method.
 263         (struct minimal_symbol text_p): Likewise.
 264         * symtab.c (output_source_filename): Use file name style
 265         to print file name.
 266         (print_symbol_info): Likewise.
 267         (print_msymbol_info): Use address style to print addresses.
 268         Use function name style to print executable text symbols.
 269         (expand_symtab_containing_pc): Use data_p.
 270         (find_pc_sect_compunit_symtab): Likewise.
 271
 272 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 273
 274         * breakpoint.c (describe_other_breakpoints): Use address style
 275         to print addresses.
 276         (say_where): Likewise.
 277
 278 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 279
 280         * ada-typeprint.c (print_func_type): Print function name
 281         style to print function name.
 282         * c-typeprint.c (c_print_type_1): Likewise.
 283
 284 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 285
 286         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 287         for execve.
 288
 289 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 290
 291         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 292         type_stack.
 293
 294 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 295
 296         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 297         TYPE_CODE_REF types.
 298
 299 2019-02-08  Jim Wilson  <jimw@sifive.com>
 300
 301         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 302         (riscv_linux_fregset): New.
 303         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 304
 305 2019-02-07  Tom Tromey  <tom@tromey.com>
 306
 307         * thread.c (thread_cancel_execution_command): Update.
 308         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 309         methods.
 310         (struct thread_fsm_ops): Remove.
 311         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 312         (thread_fsm_should_stop, thread_fsm_return_value)
 313         (thread_fsm_set_finished, thread_fsm_finished_p)
 314         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 315         Don't declare.
 316         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 317         * infrun.c (clear_proceed_status_thread)
 318         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 319         (print_stop_event): Update.
 320         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 321         Add constructor.
 322         (step_command_fsm_ops): Remove.
 323         (new_step_command_fsm): Remove.
 324         (step_1): Update.
 325         (step_command_fsm::should_stop): Rename from
 326         step_command_fsm_should_stop.
 327         (step_command_fsm::clean_up): Rename from
 328         step_command_fsm_clean_up.
 329         (step_command_fsm::do_async_reply_reason): Rename from
 330         step_command_fsm_async_reply_reason.
 331         (struct until_next_fsm): Inherit from thread_fsm.  Add
 332         constructor.
 333         (until_next_fsm_ops): Remove.
 334         (new_until_next_fsm): Remove.
 335         (until_next_fsm::should_stop): Rename from
 336         until_next_fsm_should_stop.
 337         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 338         (until_next_fsm::do_async_reply_reason): Rename from
 339         until_next_fsm_async_reply_reason.
 340         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 341         constructor.  Change type of breakpoint.
 342         (finish_command_fsm_ops): Remove.
 343         (new_finish_command_fsm): Remove.
 344         (finish_command_fsm::should_stop): Rename from
 345         finish_command_fsm_should_stop.
 346         (finish_command_fsm::clean_up): Rename from
 347         finish_command_fsm_clean_up.
 348         (finish_command_fsm::return_value): Rename from
 349         finish_command_fsm_return_value.
 350         (finish_command_fsm::do_async_reply_reason): Rename from
 351         finish_command_fsm_async_reply_reason.
 352         (finish_command): Update.
 353         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 354         Add constructor.
 355         (call_thread_fsm_ops): Remove.
 356         (call_thread_fsm::call_thread_fsm): Rename from
 357         new_call_thread_fsm.
 358         (call_thread_fsm::should_stop): Rename from
 359         call_thread_fsm_should_stop.
 360         (call_thread_fsm::should_notify_stop): Rename from
 361         call_thread_fsm_should_notify_stop.
 362         (run_inferior_call, call_function_by_hand_dummy): Update.
 363         * cli/cli-interp.c (should_print_stop_to_console): Update.
 364         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 365         Add constructor.  Change type of location_breakpoint,
 366         caller_breakpoint.
 367         (until_break_fsm_ops): Remove.
 368         (new_until_break_fsm): Remove.
 369         (until_break_fsm::should_stop): Rename from
 370         until_break_fsm_should_stop.
 371         (until_break_fsm::clean_up): Rename from
 372         until_break_fsm_clean_up.
 373         (until_break_fsm::do_async_reply_reason): Rename from
 374         until_break_fsm_async_reply_reason.
 375         (until_break_command): Update.
 376         * thread-fsm.c: Remove.
 377         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 378
 379 2019-02-07  Tom Tromey  <tom@tromey.com>
 380
 381         * yy-remap.h: Add include guard.
 382         * xtensa-tdep.h: Add include guard.
 383         * xcoffread.h: Rename include guard.
 384         * varobj-iter.h: Add include guard.
 385         * tui/tui.h: Rename include guard.
 386         * tui/tui-winsource.h: Rename include guard.
 387         * tui/tui-wingeneral.h: Rename include guard.
 388         * tui/tui-windata.h: Rename include guard.
 389         * tui/tui-win.h: Rename include guard.
 390         * tui/tui-stack.h: Rename include guard.
 391         * tui/tui-source.h: Rename include guard.
 392         * tui/tui-regs.h: Rename include guard.
 393         * tui/tui-out.h: Rename include guard.
 394         * tui/tui-layout.h: Rename include guard.
 395         * tui/tui-io.h: Rename include guard.
 396         * tui/tui-hooks.h: Rename include guard.
 397         * tui/tui-file.h: Rename include guard.
 398         * tui/tui-disasm.h: Rename include guard.
 399         * tui/tui-data.h: Rename include guard.
 400         * tui/tui-command.h: Rename include guard.
 401         * tic6x-tdep.h: Add include guard.
 402         * target/waitstatus.h: Rename include guard.
 403         * target/wait.h: Rename include guard.
 404         * target/target.h: Rename include guard.
 405         * target/resume.h: Rename include guard.
 406         * target-float.h: Rename include guard.
 407         * stabsread.h: Add include guard.
 408         * rs6000-tdep.h: Add include guard.
 409         * riscv-fbsd-tdep.h: Add include guard.
 410         * regformats/regdef.h: Rename include guard.
 411         * record.h: Rename include guard.
 412         * python/python.h: Rename include guard.
 413         * python/python-internal.h: Rename include guard.
 414         * python/py-stopevent.h: Rename include guard.
 415         * python/py-ref.h: Rename include guard.
 416         * python/py-record.h: Rename include guard.
 417         * python/py-record-full.h: Rename include guard.
 418         * python/py-record-btrace.h: Rename include guard.
 419         * python/py-instruction.h: Rename include guard.
 420         * python/py-events.h: Rename include guard.
 421         * python/py-event.h: Rename include guard.
 422         * procfs.h: Add include guard.
 423         * proc-utils.h: Add include guard.
 424         * p-lang.h: Add include guard.
 425         * or1k-tdep.h: Rename include guard.
 426         * observable.h: Rename include guard.
 427         * nto-tdep.h: Rename include guard.
 428         * nat/x86-linux.h: Rename include guard.
 429         * nat/x86-linux-dregs.h: Rename include guard.
 430         * nat/x86-gcc-cpuid.h: Add include guard.
 431         * nat/x86-dregs.h: Rename include guard.
 432         * nat/x86-cpuid.h: Rename include guard.
 433         * nat/ppc-linux.h: Rename include guard.
 434         * nat/mips-linux-watch.h: Rename include guard.
 435         * nat/linux-waitpid.h: Rename include guard.
 436         * nat/linux-ptrace.h: Rename include guard.
 437         * nat/linux-procfs.h: Rename include guard.
 438         * nat/linux-osdata.h: Rename include guard.
 439         * nat/linux-nat.h: Rename include guard.
 440         * nat/linux-namespaces.h: Rename include guard.
 441         * nat/linux-btrace.h: Rename include guard.
 442         * nat/glibc_thread_db.h: Rename include guard.
 443         * nat/gdb_thread_db.h: Rename include guard.
 444         * nat/gdb_ptrace.h: Rename include guard.
 445         * nat/fork-inferior.h: Rename include guard.
 446         * nat/amd64-linux-siginfo.h: Rename include guard.
 447         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 448         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 449         * nat/aarch64-linux.h: Rename include guard.
 450         * nat/aarch64-linux-hw-point.h: Rename include guard.
 451         * mn10300-tdep.h: Add include guard.
 452         * mips-linux-tdep.h: Add include guard.
 453         * mi/mi-parse.h: Rename include guard.
 454         * mi/mi-out.h: Rename include guard.
 455         * mi/mi-main.h: Rename include guard.
 456         * mi/mi-interp.h: Rename include guard.
 457         * mi/mi-getopt.h: Rename include guard.
 458         * mi/mi-console.h: Rename include guard.
 459         * mi/mi-common.h: Rename include guard.
 460         * mi/mi-cmds.h: Rename include guard.
 461         * mi/mi-cmd-break.h: Rename include guard.
 462         * m2-lang.h: Add include guard.
 463         * location.h: Rename include guard.
 464         * linux-record.h: Rename include guard.
 465         * linux-nat.h: Add include guard.
 466         * linux-fork.h: Add include guard.
 467         * i386-darwin-tdep.h: Rename include guard.
 468         * hppa-linux-offsets.h: Add include guard.
 469         * guile/guile.h: Rename include guard.
 470         * guile/guile-internal.h: Rename include guard.
 471         * gnu-nat.h: Rename include guard.
 472         * gdb-stabs.h: Rename include guard.
 473         * frv-tdep.h: Add include guard.
 474         * f-lang.h: Add include guard.
 475         * event-loop.h: Add include guard.
 476         * darwin-nat.h: Rename include guard.
 477         * cp-abi.h: Rename include guard.
 478         * config/sparc/nm-sol2.h: Rename include guard.
 479         * config/nm-nto.h: Rename include guard.
 480         * config/nm-linux.h: Add include guard.
 481         * config/i386/nm-i386gnu.h: Rename include guard.
 482         * config/djgpp/nl_types.h: Rename include guard.
 483         * config/djgpp/langinfo.h: Rename include guard.
 484         * compile/gcc-cp-plugin.h: Add include guard.
 485         * compile/gcc-c-plugin.h: Add include guard.
 486         * compile/compile.h: Rename include guard.
 487         * compile/compile-object-run.h: Rename include guard.
 488         * compile/compile-object-load.h: Rename include guard.
 489         * compile/compile-internal.h: Rename include guard.
 490         * compile/compile-cplus.h: Rename include guard.
 491         * compile/compile-c.h: Rename include guard.
 492         * common/xml-utils.h: Rename include guard.
 493         * common/x86-xstate.h: Rename include guard.
 494         * common/version.h: Rename include guard.
 495         * common/vec.h: Rename include guard.
 496         * common/tdesc.h: Rename include guard.
 497         * common/selftest.h: Rename include guard.
 498         * common/scoped_restore.h: Rename include guard.
 499         * common/scoped_mmap.h: Rename include guard.
 500         * common/scoped_fd.h: Rename include guard.
 501         * common/safe-iterator.h: Rename include guard.
 502         * common/run-time-clock.h: Rename include guard.
 503         * common/refcounted-object.h: Rename include guard.
 504         * common/queue.h: Rename include guard.
 505         * common/ptid.h: Rename include guard.
 506         * common/print-utils.h: Rename include guard.
 507         * common/preprocessor.h: Rename include guard.
 508         * common/pathstuff.h: Rename include guard.
 509         * common/observable.h: Rename include guard.
 510         * common/netstuff.h: Rename include guard.
 511         * common/job-control.h: Rename include guard.
 512         * common/host-defs.h: Rename include guard.
 513         * common/gdb_wait.h: Rename include guard.
 514         * common/gdb_vecs.h: Rename include guard.
 515         * common/gdb_unlinker.h: Rename include guard.
 516         * common/gdb_unique_ptr.h: Rename include guard.
 517         * common/gdb_tilde_expand.h: Rename include guard.
 518         * common/gdb_sys_time.h: Rename include guard.
 519         * common/gdb_string_view.h: Rename include guard.
 520         * common/gdb_splay_tree.h: Rename include guard.
 521         * common/gdb_setjmp.h: Rename include guard.
 522         * common/gdb_ref_ptr.h: Rename include guard.
 523         * common/gdb_optional.h: Rename include guard.
 524         * common/gdb_locale.h: Rename include guard.
 525         * common/gdb_assert.h: Rename include guard.
 526         * common/filtered-iterator.h: Rename include guard.
 527         * common/filestuff.h: Rename include guard.
 528         * common/fileio.h: Rename include guard.
 529         * common/environ.h: Rename include guard.
 530         * common/common-utils.h: Rename include guard.
 531         * common/common-types.h: Rename include guard.
 532         * common/common-regcache.h: Rename include guard.
 533         * common/common-inferior.h: Rename include guard.
 534         * common/common-gdbthread.h: Rename include guard.
 535         * common/common-exceptions.h: Rename include guard.
 536         * common/common-defs.h: Rename include guard.
 537         * common/common-debug.h: Rename include guard.
 538         * common/cleanups.h: Rename include guard.
 539         * common/buffer.h: Rename include guard.
 540         * common/btrace-common.h: Rename include guard.
 541         * common/break-common.h: Rename include guard.
 542         * cli/cli-utils.h: Rename include guard.
 543         * cli/cli-style.h: Rename include guard.
 544         * cli/cli-setshow.h: Rename include guard.
 545         * cli/cli-script.h: Rename include guard.
 546         * cli/cli-interp.h: Rename include guard.
 547         * cli/cli-decode.h: Rename include guard.
 548         * cli/cli-cmds.h: Rename include guard.
 549         * charset-list.h: Add include guard.
 550         * buildsym-legacy.h: Rename include guard.
 551         * bfin-tdep.h: Add include guard.
 552         * ax.h: Rename include guard.
 553         * arm-linux-tdep.h: Add include guard.
 554         * arm-fbsd-tdep.h: Add include guard.
 555         * arch/xtensa.h: Rename include guard.
 556         * arch/tic6x.h: Add include guard.
 557         * arch/i386.h: Add include guard.
 558         * arch/arm.h: Rename include guard.
 559         * arch/arm-linux.h: Rename include guard.
 560         * arch/arm-get-next-pcs.h: Rename include guard.
 561         * arch/amd64.h: Add include guard.
 562         * arch/aarch64-insn.h: Rename include guard.
 563         * arch-utils.h: Rename include guard.
 564         * annotate.h: Add include guard.
 565         * amd64-darwin-tdep.h: Rename include guard.
 566         * aarch64-linux-tdep.h: Add include guard.
 567         * aarch64-fbsd-tdep.h: Add include guard.
 568         * aarch32-linux-nat.h: Add include guard.
 569
 570 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 571
 572         * macrotab.c (macro_define_internal): New function that
 573         factorizes macro_define_object_internal and macro_define_function
 574         code.
 575         (macro_define_object_internal): Use macro_define_internal.
 576         (macro_define_function): Likewise.
 577
 578 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 579
 580         * macrocmd.c (extract_identifier): Return
 581         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 582         callers.
 583
 584 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 585
 586         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 587
 588 2019-02-05  Tom Tromey  <tom@tromey.com>
 589
 590         * target.c (target_stack::unpush): Move assertion earlier.
 591
 592 2019-01-30  Tom Tromey  <tom@tromey.com>
 593
 594         PR python/23615:
 595         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 596         (gdbpy_parse_and_eval): Likewise.
 597         * python/python-internal.h (gdbpy_allow_threads): New class.
 598
 599 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 600
 601         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 602         (aarch64_fbsd_fpregmap): Move earlier.
 603         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 604         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 605         instead of individual calls to trad_frame_set_reg_addr.
 606         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 607         earlier.
 608         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 609         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 610         instead of individual calls to trad_frame_set_reg_addr.
 611
 612 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 613
 614         * CONTRIBUTE: Replace contribution list with wiki link.
 615
 616 2019-01-25  Tom Tromey  <tom@tromey.com>
 617
 618         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 619
 620 2019-01-25  Tom Tromey  <tom@tromey.com>
 621
 622         * xtensa-linux-nat.c: Fix common/ includes.
 623         * xml-support.h: Fix common/ includes.
 624         * xml-support.c: Fix common/ includes.
 625         * x86-linux-nat.c: Fix common/ includes.
 626         * windows-nat.c: Fix common/ includes.
 627         * varobj.h: Fix common/ includes.
 628         * varobj.c: Fix common/ includes.
 629         * value.c: Fix common/ includes.
 630         * valops.c: Fix common/ includes.
 631         * utils.c: Fix common/ includes.
 632         * unittests/xml-utils-selftests.c: Fix common/ includes.
 633         * unittests/utils-selftests.c: Fix common/ includes.
 634         * unittests/unpack-selftests.c: Fix common/ includes.
 635         * unittests/tracepoint-selftests.c: Fix common/ includes.
 636         * unittests/style-selftests.c: Fix common/ includes.
 637         * unittests/string_view-selftests.c: Fix common/ includes.
 638         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 639         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 640         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 641         * unittests/rsp-low-selftests.c: Fix common/ includes.
 642         * unittests/parse-connection-spec-selftests.c: Fix common/
 643         includes.
 644         * unittests/optional-selftests.c: Fix common/ includes.
 645         * unittests/offset-type-selftests.c: Fix common/ includes.
 646         * unittests/observable-selftests.c: Fix common/ includes.
 647         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 648         * unittests/memrange-selftests.c: Fix common/ includes.
 649         * unittests/memory-map-selftests.c: Fix common/ includes.
 650         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 651         * unittests/function-view-selftests.c: Fix common/ includes.
 652         * unittests/environ-selftests.c: Fix common/ includes.
 653         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 654         * unittests/common-utils-selftests.c: Fix common/ includes.
 655         * unittests/cli-utils-selftests.c: Fix common/ includes.
 656         * unittests/array-view-selftests.c: Fix common/ includes.
 657         * ui-file.c: Fix common/ includes.
 658         * tui/tui-io.c: Fix common/ includes.
 659         * tracepoint.h: Fix common/ includes.
 660         * tracepoint.c: Fix common/ includes.
 661         * tracefile-tfile.c: Fix common/ includes.
 662         * top.h: Fix common/ includes.
 663         * top.c: Fix common/ includes.
 664         * thread.c: Fix common/ includes.
 665         * target/waitstatus.h: Fix common/ includes.
 666         * target/waitstatus.c: Fix common/ includes.
 667         * target.h: Fix common/ includes.
 668         * target.c: Fix common/ includes.
 669         * target-memory.c: Fix common/ includes.
 670         * target-descriptions.c: Fix common/ includes.
 671         * symtab.h: Fix common/ includes.
 672         * symfile.c: Fix common/ includes.
 673         * stap-probe.c: Fix common/ includes.
 674         * spu-linux-nat.c: Fix common/ includes.
 675         * sparc-nat.c: Fix common/ includes.
 676         * source.c: Fix common/ includes.
 677         * solib.c: Fix common/ includes.
 678         * solib-target.c: Fix common/ includes.
 679         * ser-unix.c: Fix common/ includes.
 680         * ser-tcp.c: Fix common/ includes.
 681         * ser-pipe.c: Fix common/ includes.
 682         * ser-base.c: Fix common/ includes.
 683         * selftest-arch.c: Fix common/ includes.
 684         * s12z-tdep.c: Fix common/ includes.
 685         * rust-exp.y: Fix common/ includes.
 686         * rs6000-aix-tdep.c: Fix common/ includes.
 687         * riscv-tdep.c: Fix common/ includes.
 688         * remote.c: Fix common/ includes.
 689         * remote-notif.h: Fix common/ includes.
 690         * remote-fileio.h: Fix common/ includes.
 691         * remote-fileio.c: Fix common/ includes.
 692         * regcache.h: Fix common/ includes.
 693         * regcache.c: Fix common/ includes.
 694         * record-btrace.c: Fix common/ includes.
 695         * python/python.c: Fix common/ includes.
 696         * python/py-type.c: Fix common/ includes.
 697         * python/py-inferior.c: Fix common/ includes.
 698         * progspace.h: Fix common/ includes.
 699         * producer.c: Fix common/ includes.
 700         * procfs.c: Fix common/ includes.
 701         * proc-api.c: Fix common/ includes.
 702         * printcmd.c: Fix common/ includes.
 703         * ppc-linux-nat.c: Fix common/ includes.
 704         * parser-defs.h: Fix common/ includes.
 705         * osdata.c: Fix common/ includes.
 706         * obsd-nat.c: Fix common/ includes.
 707         * nat/x86-linux.c: Fix common/ includes.
 708         * nat/x86-linux-dregs.c: Fix common/ includes.
 709         * nat/x86-dregs.h: Fix common/ includes.
 710         * nat/x86-dregs.c: Fix common/ includes.
 711         * nat/ppc-linux.c: Fix common/ includes.
 712         * nat/mips-linux-watch.h: Fix common/ includes.
 713         * nat/mips-linux-watch.c: Fix common/ includes.
 714         * nat/linux-waitpid.c: Fix common/ includes.
 715         * nat/linux-ptrace.h: Fix common/ includes.
 716         * nat/linux-ptrace.c: Fix common/ includes.
 717         * nat/linux-procfs.c: Fix common/ includes.
 718         * nat/linux-personality.c: Fix common/ includes.
 719         * nat/linux-osdata.c: Fix common/ includes.
 720         * nat/linux-namespaces.c: Fix common/ includes.
 721         * nat/linux-btrace.h: Fix common/ includes.
 722         * nat/linux-btrace.c: Fix common/ includes.
 723         * nat/fork-inferior.c: Fix common/ includes.
 724         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 725         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 726         * nat/aarch64-linux.c: Fix common/ includes.
 727         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 728         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 729         * namespace.h: Fix common/ includes.
 730         * mips-linux-tdep.c: Fix common/ includes.
 731         * minsyms.c: Fix common/ includes.
 732         * mi/mi-parse.h: Fix common/ includes.
 733         * mi/mi-main.c: Fix common/ includes.
 734         * mi/mi-cmd-env.c: Fix common/ includes.
 735         * memrange.h: Fix common/ includes.
 736         * memattr.c: Fix common/ includes.
 737         * maint.h: Fix common/ includes.
 738         * maint.c: Fix common/ includes.
 739         * main.c: Fix common/ includes.
 740         * machoread.c: Fix common/ includes.
 741         * location.c: Fix common/ includes.
 742         * linux-thread-db.c: Fix common/ includes.
 743         * linux-nat.c: Fix common/ includes.
 744         * linux-fork.c: Fix common/ includes.
 745         * inline-frame.c: Fix common/ includes.
 746         * infrun.c: Fix common/ includes.
 747         * inflow.c: Fix common/ includes.
 748         * inferior.h: Fix common/ includes.
 749         * inferior.c: Fix common/ includes.
 750         * infcmd.c: Fix common/ includes.
 751         * inf-ptrace.c: Fix common/ includes.
 752         * inf-child.c: Fix common/ includes.
 753         * ia64-linux-nat.c: Fix common/ includes.
 754         * i387-tdep.c: Fix common/ includes.
 755         * i386-tdep.c: Fix common/ includes.
 756         * i386-linux-tdep.c: Fix common/ includes.
 757         * i386-linux-nat.c: Fix common/ includes.
 758         * i386-go32-tdep.c: Fix common/ includes.
 759         * i386-fbsd-tdep.c: Fix common/ includes.
 760         * i386-fbsd-nat.c: Fix common/ includes.
 761         * guile/scm-type.c: Fix common/ includes.
 762         * guile/guile.c: Fix common/ includes.
 763         * go32-nat.c: Fix common/ includes.
 764         * gnu-nat.c: Fix common/ includes.
 765         * gdbthread.h: Fix common/ includes.
 766         * gdbarch-selftests.c: Fix common/ includes.
 767         * gdb_usleep.c: Fix common/ includes.
 768         * gdb_select.h: Fix common/ includes.
 769         * gdb_bfd.c: Fix common/ includes.
 770         * gcore.c: Fix common/ includes.
 771         * fork-child.c: Fix common/ includes.
 772         * findvar.c: Fix common/ includes.
 773         * fbsd-nat.c: Fix common/ includes.
 774         * event-top.c: Fix common/ includes.
 775         * event-loop.c: Fix common/ includes.
 776         * dwarf2read.c: Fix common/ includes.
 777         * dwarf2loc.c: Fix common/ includes.
 778         * dwarf2-frame.c: Fix common/ includes.
 779         * dwarf-index-cache.c: Fix common/ includes.
 780         * dtrace-probe.c: Fix common/ includes.
 781         * disasm-selftests.c: Fix common/ includes.
 782         * defs.h: Fix common/ includes.
 783         * csky-tdep.c: Fix common/ includes.
 784         * cp-valprint.c: Fix common/ includes.
 785         * cp-support.h: Fix common/ includes.
 786         * cp-support.c: Fix common/ includes.
 787         * corelow.c: Fix common/ includes.
 788         * completer.h: Fix common/ includes.
 789         * completer.c: Fix common/ includes.
 790         * compile/compile.c: Fix common/ includes.
 791         * compile/compile-loc2c.c: Fix common/ includes.
 792         * compile/compile-cplus-types.c: Fix common/ includes.
 793         * compile/compile-cplus-symbols.c: Fix common/ includes.
 794         * command.h: Fix common/ includes.
 795         * cli/cli-dump.c: Fix common/ includes.
 796         * cli/cli-cmds.c: Fix common/ includes.
 797         * charset.c: Fix common/ includes.
 798         * build-id.c: Fix common/ includes.
 799         * btrace.h: Fix common/ includes.
 800         * btrace.c: Fix common/ includes.
 801         * breakpoint.h: Fix common/ includes.
 802         * breakpoint.c: Fix common/ includes.
 803         * ax.h:
 804         (enum agent_op): Fix common/ includes.
 805         * ax-general.c (struct aop_map): Fix common/ includes.
 806         * ax-gdb.c: Fix common/ includes.
 807         * auxv.c: Fix common/ includes.
 808         * auto-load.c: Fix common/ includes.
 809         * arm-tdep.c: Fix common/ includes.
 810         * arch/riscv.c: Fix common/ includes.
 811         * arch/ppc-linux-common.c: Fix common/ includes.
 812         * arch/i386.c: Fix common/ includes.
 813         * arch/arm.c: Fix common/ includes.
 814         * arch/arm-linux.c: Fix common/ includes.
 815         * arch/arm-get-next-pcs.c: Fix common/ includes.
 816         * arch/amd64.c: Fix common/ includes.
 817         * arch/aarch64.c: Fix common/ includes.
 818         * arch/aarch64-insn.c: Fix common/ includes.
 819         * arch-utils.c: Fix common/ includes.
 820         * amd64-windows-tdep.c: Fix common/ includes.
 821         * amd64-tdep.c: Fix common/ includes.
 822         * amd64-sol2-tdep.c: Fix common/ includes.
 823         * amd64-obsd-tdep.c: Fix common/ includes.
 824         * amd64-nbsd-tdep.c: Fix common/ includes.
 825         * amd64-linux-tdep.c: Fix common/ includes.
 826         * amd64-linux-nat.c: Fix common/ includes.
 827         * amd64-fbsd-tdep.c: Fix common/ includes.
 828         * amd64-fbsd-nat.c: Fix common/ includes.
 829         * amd64-dicos-tdep.c: Fix common/ includes.
 830         * amd64-darwin-tdep.c: Fix common/ includes.
 831         * agent.c: Fix common/ includes.
 832         * ada-lang.h: Fix common/ includes.
 833         * ada-lang.c: Fix common/ includes.
 834         * aarch64-tdep.c: Fix common/ includes.
 835
 836 2019-01-25  Tom Tromey  <tom@tromey.com>
 837
 838         * common/create-version.sh: Use common/version.h.
 839
 840 2019-01-24  Pedro Alves  <palves@redhat.com>
 841
 842         * infrun.c (signal_stop, signal_print, signal_program)
 843         (signal_catch, signal_pass): Now arrays instead of pointers.
 844         (update_signals_program_target, do_target_resume)
 845         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 846         * linux-nat.c (linux_nat_target::pass_signals)
 847         (linux_nat_target::create_inferior, linux_nat_target::attach):
 848         Adjust.
 849         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 850         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 851         * procfs.c (procfs_target::pass_signals): Adjust.
 852         * record-full.c (record_full_target::resume): Adjust.
 853         * remote.c (remote_target::pass_signals)
 854         (remote_target::program_signals): Adjust.
 855         * target-debug.h (target_debug_print_signals): Now takes a
 856         gdb::array_view as parameter.  Adjust.
 857         * target.h (target_ops) <pass_signals, program_signals>: Replace
 858         pointer and length parameters with gdb::array_view.
 859         (target_pass_signals, target_program_signals): Likewise.
 860         * target-delegates.c: Regenerate.
 861
 862 2019-01-24  Pedro Alves  <palves@redhat.com>
 863
 864         * common/forward-scope-exit.h
 865         (forward_scope_exit::forward_scope_exit): Pass arguments to
 866         m_bind_function directly, instead of creating a std::bind and
 867         copying that.
 868
 869 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 870
 871         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 872         for static members.
 873         (pass_in_v_vfp_candidate): Likewise.
 874
 875 2019-01-23  Tom Tromey  <tom@tromey.com>
 876             Pedro Alves  <palves@redhat.com>
 877
 878         * regcache.c (class regcache_invalidator): Remove.
 879         (regcache::raw_write): Use make_scope_exit.
 880
 881 2019-01-23  Tom Tromey  <tom@tromey.com>
 882
 883         * ui-out.h (class ui_out_emit_type): Update comment.
 884
 885 2019-01-23  Tom Tromey  <tom@tromey.com>
 886
 887         * infrun.c (fetch_inferior_event): Update comment.
 888
 889 2019-01-23  Tom Tromey  <tom@tromey.com>
 890             Pedro Alves  <palves@redhat.com>
 891
 892         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 893         parameter.
 894         (fetch_inferior_event): Use SCOPE_EXIT.
 895
 896
 897 2019-01-23  Tom Tromey  <tom@tromey.com>
 898             Pedro Alves  <palves@redhat.com>
 899
 900         * infrun.c (disable_thread_events): Delete.
 901         (stop_all_threads): Use SCOPE_EXIT.
 902
 903 2019-01-23  Tom Tromey  <tom@tromey.com>
 904             Pedro Alves  <palves@redhat.com>
 905
 906         * symfile.c: Include forward-scope-exit.h.
 907         (clear_symtab_users_cleanup): Replace forward declaration with
 908         a FORWARD_SCOPE_EXIT.
 909         (syms_from_objfile_1): Use the forward_scope_exit and
 910         gdb::optional instead of cleanup_function.
 911         (reread_symbols): Use the forward_scope_exit instead of
 912         cleanup_function.
 913         (clear_symtab_users_cleanup): Remove function.
 914
 915 2019-01-23  Tom Tromey  <tom@tromey.com>
 916             Pedro Alves  <palves@redhat.com>
 917
 918         * linux-nat.c: Include scope-exit.h.
 919         (cleanup_target_stop): Remove.
 920         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 921         SCOPE_EXIT.
 922
 923 2019-01-23  Tom Tromey  <tom@tromey.com>
 924             Pedro Alves  <palves@redhat.com>
 925
 926         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 927         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 928
 929 2019-01-23  Tom Tromey  <tom@tromey.com>
 930             Andrew Burgess  <andrew.burgess@embecosm.com>
 931             Pedro Alves  <palves@redhat.com>
 932
 933         * infrun.c (fetch_inferior_event): Use scope_exit.
 934         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 935         * top.c (execute_command): Use scope_exit.
 936         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 937         * utils.c (do_bpstat_clear_actions_cleanup)
 938         (make_bpstat_clear_actions_cleanup): Remove.
 939
 940 2019-01-23  Tom Tromey  <tom@tromey.com>
 941             Pedro Alves  <palves@redhat.com>
 942
 943         * infrun.c: Include "common/scope-exit.h"
 944         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 945         (wait_for_inferior): Use SCOPE_EXIT.
 946         (fetch_inferior_event): Use scope_exit.
 947
 948 2019-01-23  Tom Tromey  <tom@tromey.com>
 949             Pedro Alves  <palves@redhat.com>
 950
 951         * breakpoint.c (create_breakpoint): Remove cleanup.
 952
 953 2019-01-23  Tom Tromey  <tom@tromey.com>
 954             Andrew Burgess  <andrew.burgess@embecosm.com>
 955             Pedro Alves  <palves@redhat.com>
 956
 957 2019-01-23  Pedro Alves  <palves@redhat.com>
 958
 959         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 960
 961 2019-01-23  Pedro Alves  <palves@redhat.com>
 962             Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * gdbthread.h: Include "common/forward-scope-exit.h".
 965         (scoped_finish_thread_state): Redefine custom class in terms of
 966         forward_scope_exit.
 967
 968 2019-01-23  Pedro Alves  <palves@redhat.com>
 969             Andrew Burgess  <andrew.burgess@embecosm.com>
 970
 971         * common/forward-scope-exit.h: New file.
 972
 973 2019-01-23  Pedro Alves  <palves@redhat.com>
 974             Andrew Burgess  <andrew.burgess@embecosm.com>
 975             Tom Tromey  <tom@tromey.com>
 976
 977         * common/scope-exit.h: New file.
 978
 979 2019-01-23  Pedro Alves  <palves@redhat.com>
 980
 981         * common/preprocessor.h (ESC): Rename to ...
 982         (ESC_PARENS): ... this.
 983         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 984         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 985
 986 2019-01-23  Tom Tromey  <tom@tromey.com>
 987
 988         * language.h (class scoped_switch_to_sym_language_if_auto):
 989         Initialize m_lang in both cases.
 990
 991 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 992
 993         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 994         with XCNEW.
 995
 996 2019-01-22  Tom Tromey  <tom@tromey.com>
 997
 998         * corelow.c: Do not include sys/file.h.
 999
1000 2019-01-22  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-wingeneral.h: Include gdb_curses.h.
1003
1004 2019-01-22  Tom Tromey  <tom@tromey.com>
1005
1006         * source-cache.h (class source_cache) <get_source_lines,
1007         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1008
1009 2019-01-22  Tom Tromey  <tom@tromey.com>
1010
1011         * remote-fileio.h (struct remote_target): Declare.
1012
1013 2019-01-22  Tom Tromey  <tom@tromey.com>
1014
1015         * python/py-arch.c: Do not include py-ref.h.
1016         * python/py-bpevent.c: Do not include py-ref.h.
1017         * python/py-cmd.c: Do not include py-ref.h.
1018         * python/py-continueevent.c: Do not include py-ref.h.
1019         * python/py-event.h: Do not include py-ref.h.
1020         * python/py-evtregistry.c: Do not include py-ref.h.
1021         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1022         * python/py-frame.c: Do not include py-ref.h.
1023         * python/py-framefilter.c: Do not include py-ref.h.
1024         * python/py-function.c: Do not include py-ref.h.
1025         * python/py-infevents.c: Do not include py-ref.h.
1026         * python/py-linetable.c: Do not include py-ref.h.
1027         * python/py-objfile.c: Do not include py-ref.h.
1028         * python/py-param.c: Do not include py-ref.h.
1029         * python/py-prettyprint.c: Do not include py-ref.h.
1030         * python/py-progspace.c: Do not include py-ref.h.
1031         * python/py-symbol.c: Do not include py-ref.h.
1032         * python/py-symtab.c: Do not include py-ref.h.
1033         * python/py-type.c: Do not include py-ref.h.
1034         * python/py-unwind.c: Do not include py-ref.h.
1035         * python/py-utils.c: Do not include py-ref.h.
1036         * python/py-value.c: Do not include py-ref.h.
1037         * python/py-varobj.c: Do not include py-ref.h.
1038         * python/py-xmethods.c: Do not include py-ref.h.
1039         * python/python.c: Do not include py-ref.h.
1040         * varobj.c: Do not include py-ref.h.
1041
1042 2019-01-22  Tom Tromey  <tom@tromey.com>
1043
1044         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1045         keyword for bcache.
1046
1047 2019-01-22  Tom Tromey  <tom@tromey.com>
1048
1049         * compile/compile-cplus-types.c: Remove a comment by #include.
1050
1051 2019-01-22  Tom Tromey  <tom@tromey.com>
1052
1053         * compile/gcc-c-plugin.h: Include compile-internal.h.
1054
1055 2019-01-22  Tom Tromey  <tom@tromey.com>
1056
1057         * stabsread.c (EXTERN): Do not define.
1058         (symnum, next_symbol_text_func, processing_gcc_compilation)
1059         (within_function, global_sym_chain, global_stabs)
1060         (previous_stab_code, this_object_header_files)
1061         (n_this_object_header_files)
1062         (n_allocated_this_object_header_files): Define.
1063         * stabsread.h (EXTERN): Never define.  Use "extern".
1064
1065 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1066
1067         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1068         history_value.
1069
1070 2019-01-21  Tom Tromey  <tom@tromey.com>
1071
1072         * ui-out.c: Fix includes.
1073         * tui/tui-source.c: Fix includes.
1074         * target.c: Fix includes.
1075         * remote.c: Fix includes.
1076         * regcache.c: Fix includes.
1077         * python/py-block.c: Fix includes.
1078         * printcmd.c: Fix includes.
1079         * or1k-tdep.c: Fix includes.
1080         * mi/mi-main.c: Fix includes.
1081         * m32r-tdep.c: Fix includes.
1082         * csky-tdep.c: Fix includes.
1083         * compile/compile-cplus-types.c: Fix includes.
1084         * cli/cli-interp.c: Fix includes.
1085
1086 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1087
1088         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1089         for padding.
1090
1091 2019-01-16  Tom Tromey  <tom@tromey.com>
1092
1093         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1094         earlier.
1095         (struct objfile) <msymbols_range>: Move from top level.
1096         <msymbols>: New method.
1097         (class objfile_msymbols): Remove.
1098         * symtab.c (default_collect_symbol_completion_matches_break_on):
1099         Update.
1100         * symmisc.c (dump_msymbols): Update.
1101         * stabsread.c (scan_file_globals): Update.
1102         * objc-lang.c (info_selectors_command, info_classes_command)
1103         (find_methods): Update.
1104         * minsyms.c (find_solib_trampoline_target): Update.
1105         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1106         * coffread.c (coff_symfile_read): Update.
1107         * ada-lang.c (ada_lookup_simple_minsym)
1108         (ada_collect_symbol_completion_matches): Update.
1109
1110 2019-01-16  Tom Tromey  <tom@tromey.com>
1111
1112         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1113         type.  Remove no-argument constructor.
1114         <iterator::operator++>: Simplify.
1115         <begin>: Update.
1116         <end>: Use minimal_symbol_count.
1117
1118 2019-01-16  Tom Tromey  <tom@tromey.com>
1119
1120         * objfiles.h (struct objfile) <psymtabs>: New method.
1121         (class objfile_psymtabs): Remove.
1122         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1123         typedef.
1124         <range>: New method.
1125         (require_partial_symbols): Change return type.
1126         * psymtab.c (require_partial_symbols)
1127         (psym_expand_symtabs_matching): Update.
1128         * mdebugread.c (parse_partial_symbols): Update.
1129         * dbxread.c (dbx_end_psymtab): Update.
1130
1131 2019-01-15  Tom Tromey  <tom@tromey.com>
1132
1133         * symtab.c (lookup_objfile_from_block)
1134         (lookup_symbol_in_objfile_symtabs)
1135         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1136         (find_line_symtab, info_sources_command)
1137         (default_collect_symbol_completion_matches_break_on)
1138         (make_source_files_completion_list): Update.
1139         * symmisc.c (print_objfile_statistics, dump_objfile)
1140         (maintenance_print_symbols, maintenance_info_symtabs)
1141         (maintenance_check_symtabs, maintenance_info_line_tables):
1142         Update.
1143         * source.c (select_source_symtab)
1144         (forget_cached_source_info_for_objfile): Update.
1145         * objfiles.h (class objfile_compunits): Remove.
1146         (struct objfile) <compunits_range>: New typedef.
1147         (compunits): New method.
1148         * objfiles.c (objfile_relocate1): Update.
1149         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1150         * maint.c (count_symtabs_and_blocks): Update.
1151         * linespec.c (iterate_over_all_matching_symtabs): Update.
1152         * cp-support.c (add_symbol_overload_list_qualified): Update.
1153         * coffread.c (coff_symtab_read): Update.
1154         * ada-lang.c (add_nonlocal_symbols)
1155         (ada_collect_symbol_completion_matches)
1156         (ada_add_global_exceptions): Update.
1157
1158 2019-01-15  Tom Tromey  <tom@tromey.com>
1159
1160         * progspace.h (program_space) <objfiles_safe_range>: New
1161         typedef.
1162         <objfiles_safe>: New method.
1163         * objfiles.h (class all_objfiles_safe): Remove.
1164         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1165         * jit.c (jit_inferior_exit_hook): Update.
1166
1167 2019-01-17  Tom Tromey  <tom@tromey.com>
1168
1169         * progspace.h (program_space) <objfiles_range>: New typedef.
1170         <objfiles>: New method.
1171         <objfiles_head>: Rename from objfiles.
1172         (object_files): Update.
1173         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1174         * guile/scm-pretty-print.c
1175         (ppscm_find_pretty_printer_from_objfiles): Update.
1176         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1177         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1178         Update.
1179         * python/py-progspace.c (pspy_get_objfiles): Update.
1180         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1181         Update.
1182         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1183         (objfpy_lookup_objfile_by_build_id): Update.
1184         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1185         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1186         Update.
1187         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1188         (expand_symtab_containing_pc, lookup_objfile_from_block)
1189         (lookup_static_symbol, basic_lookup_transparent_type)
1190         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1191         (find_line_symtab, info_sources_command)
1192         (default_collect_symbol_completion_matches_break_on)
1193         (make_source_files_completion_list, find_main_name): Update.
1194         * symmisc.c (print_symbol_bcache_statistics)
1195         (print_objfile_statistics, maintenance_print_symbols)
1196         (maintenance_print_msymbols, maintenance_print_objfiles)
1197         (maintenance_info_symtabs, maintenance_check_symtabs)
1198         (maintenance_expand_symtabs, maintenance_info_line_tables):
1199         Update.
1200         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1201         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1202         (map_overlay_command, unmap_overlay_command)
1203         (simple_overlay_update, expand_symtabs_matching)
1204         (map_symbol_filenames): Update.
1205         * symfile-debug.c (set_debug_symfile): Update.
1206         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1207         Update.
1208         * source.c (select_source_symtab, forget_cached_source_info):
1209         Update.
1210         * solib.c (solib_read_symbols): Update.
1211         * solib-spu.c (append_ocl_sos): Update.
1212         * psymtab.c (maintenance_print_psymbols)
1213         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1214         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1215         * printcmd.c (info_symbol_command): Update.
1216         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1217         Update.
1218         * objfiles.h (class all_objfiles): Remove.
1219         * objfiles.c (have_partial_symbols, have_full_symbols)
1220         (have_minimal_symbols, qsort_cmp, update_section_map)
1221         (shared_objfile_contains_address_p)
1222         (default_iterate_over_objfiles_in_search_order): Update.
1223         * objc-lang.c (info_selectors_command, info_classes_command)
1224         (find_methods): Update.
1225         * minsyms.c (find_solib_trampoline_target): Update.
1226         * maint.c (maintenance_info_sections)
1227         (maintenance_translate_address, count_symtabs_and_blocks):
1228         Update.
1229         * main.c (captured_main_1): Update.
1230         * linux-thread-db.c (try_thread_db_load_from_pdir)
1231         (has_libpthread): Update.
1232         * linespec.c (iterate_over_all_matching_symtabs)
1233         (search_minsyms_for_name): Update.
1234         * jit.c (jit_find_objf_with_entry_addr): Update.
1235         * hppa-tdep.c (find_unwind_entry)
1236         (hppa_lookup_stub_minimal_symbol): Update.
1237         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1238         Update.
1239         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1240         (elf_gnu_ifunc_resolve_by_got): Update.
1241         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1242         * dwarf-index-write.c (save_gdb_index_command): Update.
1243         * cp-support.c (add_symbol_overload_list_qualified): Update.
1244         * breakpoint.c (create_overlay_event_breakpoint)
1245         (create_longjmp_master_breakpoint)
1246         (create_std_terminate_master_breakpoint)
1247         (create_exception_master_breakpoint): Update.
1248         * blockframe.c (find_pc_partial_function): Update.
1249         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1250         (ada_collect_symbol_completion_matches)
1251         (ada_add_global_exceptions): Update.
1252
1253 2019-01-17  Tom Tromey  <tom@tromey.com>
1254
1255         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1256         declare VEC.
1257         (solib_target_parse_libraries): Change return type.
1258         (library_list_start_segment, library_list_start_section)
1259         (library_list_end_library, library_list_start_library); Update.
1260         (solib_target_free_library_list): Remove.
1261         (solib_target_parse_libraries): Remove cleanup.  Change return
1262         type.
1263         (solib_target_current_sos): Update.
1264
1265 2019-01-17  Tom Tromey  <tromey@bapiya>
1266
1267         * valprint.c: Replace "the the" with "the".
1268         * symtab.c: Replace "the the" with "the".
1269         * solib.c: Replace "the the" with "the".
1270         * solib-dsbt.c: Replace "the the" with "the".
1271         * linespec.c: Replace "the the" with "the".
1272         * dwarf2loc.h: Replace "the the" with "the".
1273         * amd64-windows-tdep.c: Replace "the the" with "the".
1274         * aarch64-tdep.c: Replace "the the" with "the".
1275
1276 2019-01-16  Keith Seitz  <keiths@redhat.com>
1277
1278         PR gdb/23773
1279         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1280         <builder>: Rename to ..
1281         <m_builder>: ... this and make private.
1282         (dwarf2_cu::get_builder): New method.  Change all users of
1283         `builder' to use this method.
1284         (dwarf2_start_symtab): Move to ...
1285         (dwarf2_cu::start_symtab): ... here.  Update all callers
1286         (setup_type_unit_groups): Move to ...
1287         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1288         callers.
1289         (dwarf2_cu::reset_builder): New method.
1290         (process_full_compunit, process_full_type_unit): Use
1291         dwarf2_cu::reset_builder.
1292         (follow_die_offset): Record the ancestor CU if it is different
1293         from the followed DIE's CU.
1294         (follow_die_sig_1): Likewise.
1295
1296 2019-01-15  Tom Tromey  <tom@tromey.com>
1297
1298         * remote.c (class remote_state) <buf>: Now a char_vector.
1299         <buf_size>: Remove.
1300         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1301         parameter.
1302         (remote_target::getpkt_or_notif_sane_1)
1303         (remote_target::getpkt_sane)
1304         (remote_target::getpkt_or_notif_sane): Likewise.
1305         (class remote_target) <putpkt>: New overload.
1306         (remote_target::read_frame): Change type of "buf_p".  Remove
1307         sizeof_p parameter.
1308         (packet_ok): New overload.
1309         (packet_check_result): New overload.
1310         Update all uses.
1311
1312 2019-01-14  Tom Tromey  <tom@tromey.com>
1313
1314         * remote-notif.c (handle_notification, remote_notif_ack)
1315         (remote_notif_parse): Make "buf" const.
1316         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1317         const.
1318         (remote_notif_parse, remote_notif_ack, handle_notification):
1319         Likewise.
1320         * remote.c (remote_notif_stop_parse): Make "buf" const.
1321         (remote_target::remote_parse_stop_reply): Make "buf" const.
1322         (remote_notif_stop_ack): Make "buf" const.
1323
1324 2019-01-14  Tom Tromey  <tom@tromey.com>
1325
1326         * remote.c (remote_console_output): Make parameter const.
1327
1328 2019-01-14  Tom Tromey  <tom@tromey.com>
1329
1330         * target-debug.h (target_debug_print_signals): Constify.
1331         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1332         * procfs.c (procfs_target::pass_signals): Update.
1333         * linux-nat.c (linux_nat_target::pass_signals): Update.
1334         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1335         * target-delegates.c: Rebuild.
1336         * remote.c (remote_target::program_signals): Update.
1337         (remote_target::pass_signals): Update.
1338         * target.c (target_pass_signals): Constify argument.
1339         (target_program_signals): Likewise.
1340         * target.h (struct target_ops) <pass_signals, program_signals>:
1341         Constify argument.
1342         (target_pass_signals, target_program_signals): Constify argument.
1343
1344 2019-01-14  Tom Tromey  <tom@tromey.com>
1345
1346         PR tui/28819:
1347         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1348
1349 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1350
1351         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1352         field.
1353         * rs6000-tdep.c: Include reggroups.h.
1354         (IS_V_ALIAS_PSEUDOREG): Define.
1355         (rs6000_register_name): Return names for the "vX" aliases.
1356         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1357         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1358         aliases.  Call default_register_reggroup_p for all other
1359         pseudo-registers.
1360         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1361         New functions.
1362         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1363         Handle "vX" aliases.
1364         (v_alias_pseudo_register_collect): New function.
1365         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1366         (rs6000_gdbarch_init): Initialize "vX" aliases as
1367         pseudo-registers.  Restore registration of
1368         rs6000_pseudo_register_reggroup_p with
1369         set_tdesc_pseudo_register_reggroup_p.
1370
1371 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1372
1373         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1374         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1375         set_gdbarch_num_pseudo_regs.
1376
1377 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1378
1379         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1380         Remove arg prefixname, add do_set and do_show.
1381         Add member functions set_list and show_list.
1382         * cli/cli-style.c (class cli_style_option): Update accordingly.
1383         (style_set_list): Move to file scope.
1384         (style_show_list): Likewise.
1385         (set_style): Call help_list.
1386         (show_style): Call cmd_show_list.
1387         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1388         Update to use the new macro.
1389
1390 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1391
1392         * ada-lang.c (_initialize_ada_language): Expand the help text
1393         for the "catch exception" command.
1394
1395 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1396
1397         * symtab.c (matching_obj_sections): Initialize obj,
1398         declare it closer to its usage.
1399
1400 2019-01-10  Tom Tromey  <tom@tromey.com>
1401
1402         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1403         (basic_inf_threads_range): Remove.
1404         (inf_threads_range, inf_non_exited_threads_range)
1405         (safe_inf_threads_range): Use next_adapter.
1406
1407 2019-01-10  Keith Seitz  <keiths@redhat.com>
1408
1409         PR gdb/23712
1410         PR symtab/23010
1411         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1412         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1413
1414 2019-01-10  Keith Seitz  <keiths@redhat.com>
1415
1416         PR gdb/23712
1417         PR symtab/23010
1418         * dictionary.c (pending_to_vector): Remove.
1419         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1420         Remove _1 suffix, replacing functions of the same name.  Update
1421         all callers.
1422         (dict_create_hashed, dict_create_hashed_expandable)
1423         (dict_create_linear, dict_create_linear_expandable, dict_free)
1424         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1425         Make functions static.
1426
1427 2019-01-10  Keith Seitz  <keiths@redhat.com>
1428
1429         PR gdb/23712
1430         PR symtab/23010
1431         * dictionary.h (struct dictionary): Replace declaration with
1432         multidictionary.
1433         (dict_create_hashed, dict_create_hashed_expandable)
1434         (dict_create_linear, dict_create_linear_expandable)
1435         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1436         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1437         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1438         taking multidictionary argument.
1439         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1440         * block.h (struct block) <dict>: Change to multidictionary
1441         and rename `multidict'.
1442         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1443         symmisc.c: Update all dictionary references to multidictionary.
1444
1445 2019-01-10  Keith Seitz  <keiths@redhat.com>
1446
1447         PR gdb/23712
1448         PR symtab/23010
1449         * dictionary.c: Include unordered_map.
1450         (pending_to_vector): New function.
1451         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1452         Rewrite the non-"_1" functions to take vector instead
1453         of linked list.
1454         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1455         "new" _1 versions of the same name.
1456         (multidictionary): Define.
1457         (std::hash<enum language): New definition.
1458         (collate_pending_symbols_by_language, mdict_create_hashed)
1459         (mdict_create_hashed_expandable, mdict_create_linear)
1460         (mdict_create_linear_expandable, mdict_free)
1461         (find_language_dictionary, create_new_language_dictionary)
1462         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1463         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1464         (mdict_size, mdict_empty): New functions.
1465         * dictionary.h (mdict_iterator): Define.
1466
1467 2019-01-10  Pedro Alves  <palves@redhat.com>
1468
1469         * breakpoint.c (read_uploaded_action)
1470         (create_tracepoint_from_upload): Adjust to use
1471         gdb::unique_xmalloc_ptr.
1472         * ctf.c (ctf_write_uploaded_tp):
1473         (SET_ARRAY_FIELD): Use emplace_back.
1474         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1475         * tracefile-tfile.c (tfile_write_uploaded_tp):
1476         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1477         gdb::unique_xmalloc_ptr.
1478         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1479         at_string, cond_string, cmd_strings>: Replace char pointers
1480         with gdb::unique_xmalloc_ptr.
1481
1482 2019-01-10  Pedro Alves  <palves@redhat.com>
1483
1484         * solib-target.c (library_list_start_library): Don't xstrdup name.
1485
1486 2019-01-10  Pedro Alves  <palves@redhat.com>
1487
1488         * mdebugread.c (parse_partial_symbols): Use
1489         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1490
1491 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * linux-fork.c (scoped_switch_fork_info)
1494         <~scoped_switch_fork_info>: Fix incorrect variable name.
1495
1496 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * linux-fork.c (scoped_switch_fork_info)
1499         <scoped_switch_fork_info>: Make explicit.
1500         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1501
1502 2019-01-10  Tom Tromey  <tom@tromey.com>
1503
1504         * objfiles.h (objfile::reset_psymtabs): Update.
1505         * objfiles.c (objfile::objfile): Update.
1506         * psymtab.h (psymtab_storage::obstack): Update.
1507         (psymtab_storage::m_obstack): Use gdb::optional.
1508         (class psymtab_storage): Update comment.  Remove objfile
1509         parameter.
1510         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1511
1512 2019-01-10  Tom Tromey  <tom@tromey.com>
1513
1514         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1515         <free_psymtabs>: Now private.
1516         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1517         (allocate_psymtab): Use new method.
1518
1519 2019-01-10  Tom Tromey  <tom@tromey.com>
1520
1521         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1522         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1523         * mdebugread.c (parse_partial_symbols): Use
1524         allocate_dependencies.
1525         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1526         allocate_dependencies.
1527         (process_psymtab_comp_unit_reader)
1528         (build_type_psymtab_dependencies): Likewise.
1529         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1530
1531 2019-01-10  Tom Tromey  <tom@tromey.com>
1532
1533         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1534         PSYMBOL_SET_LANGUAGE.
1535         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1536
1537 2019-01-10  Tom Tromey  <tom@tromey.com>
1538
1539         * psymtab.h (psymtab_storage::obstack): New method.
1540         <m_obstack>: Rename from obstack; now private.
1541         * psymtab.c (psymtab_storage): Update.
1542         * dwarf2read.c (create_addrmap_from_index)
1543         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1544         Update.
1545
1546 2019-01-10  Tom Tromey  <tom@tromey.com>
1547
1548         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1549         * objfiles.h (objfile::reset_psymtabs): New method.
1550
1551 2019-01-10  Tom Tromey  <tom@tromey.com>
1552
1553         * symmisc.c (print_symbol_bcache_statistics): Update.
1554         (print_objfile_statistics): Update.
1555         * symfile.c (reread_symbols): Update.
1556         * psymtab.h (class psymtab_storage): New.
1557         * psymtab.c (psymtab_storage): New constructor.
1558         (~psymtab_storage): New destructor.
1559         (require_partial_symbols): Update.
1560         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1561         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1562         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1563         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1564         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1565         (start_psymtab_common, end_psymtab_common)
1566         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1567         (allocate_psymtab): Update.
1568         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1569         Update.
1570         (dump_psymtab_addrmap, maintenance_print_psymbols)
1571         (maintenance_check_psymtabs): Update.
1572         (class objfile_psymtabs): Move to objfiles.h.
1573         * psympriv.h (discard_psymtab): Now inline.
1574         (psymtab_discarder::psymtab_discarder): Update.
1575         (psymtab_discarder::~psymtab_discarder): Update.
1576         (ALL_OBJFILE_PSYMTABS): Rewrite.
1577         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1578         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1579         Remove fields.
1580         <partial_symtabs>: New field.
1581         (class objfile_psymtabs): Move from psymtab.h.  Update.
1582         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1583         psymbol_cache.
1584         (objfile::~objfile): Don't destroy psymbol_cache.
1585         * mdebugread.c (parse_partial_symbols): Update.
1586         * dwarf2read.c (create_addrmap_from_index)
1587         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1588         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1589         (add_partial_subprogram, dwarf2_ranges_read): Update.
1590         * dwarf-index-write.c (write_address_map)
1591         (write_one_signatured_type, recursively_write_psymbols)
1592         (class debug_names, class debug_names, write_psymtabs_to_index):
1593         Update.
1594
1595 2019-01-10  Tom Tromey  <tom@tromey.com>
1596
1597         * symtab.h (SYMBOL_SET_NAMES): Update.
1598         (symbol_set_names): Update.
1599         (MSYMBOL_SET_NAMES): Update.
1600         * symtab.c (symbol_set_names): Change argument to be an
1601         objfile_per_bfd_storage.
1602         * psymtab.c (add_psymbol_to_bcache): Update.
1603         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1604
1605 2019-01-10  Tom Tromey  <tom@tromey.com>
1606
1607         * symtab.c (create_demangled_names_hash): Change argument to be an
1608         objfile_per_bfd_storage.
1609         (symbol_set_names): Update.
1610
1611 2019-01-10  Tom Tromey  <tom@tromey.com>
1612
1613         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1614         init_psymbol_list.
1615         * psymtab.c (init_psymbol_list): Do nothing if already called.
1616         * psympriv.h (init_psymbol_list): Add comment.
1617         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1618         init_psymbol_list.
1619         * dbxread.c (dbx_symfile_read): Unconditionally call
1620         init_psymbol_list.
1621
1622 2019-01-10  Tom Tromey  <tom@tromey.com>
1623
1624         * xcoffread.c (scan_xcoff_symtab): Update.
1625         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1626         "where".
1627         * mdebugread.c (parse_partial_symbols)
1628         (handle_psymbol_enumerators): Update.
1629         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1630         * dbxread.c (read_dbx_symtab): Update.
1631         * psympriv.h (psymbol_placement): New enum.
1632         (add_psymbol_to_list): Update.
1633
1634 2019-01-10  Tom Tromey  <tom@tromey.com>
1635
1636         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1637         static_psymbols parameters.
1638         (scan_xcoff_symtab): Update.
1639         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1640         static_psymbols parameters.
1641         * psympriv.h (start_psymtab_common): Update.
1642         * mdebugread.c (parse_partial_symbols): Update.
1643         * dwarf2read.c (create_partial_symtab): Update.
1644         * dbxread.c (read_dbx_symtab): Update.
1645         (start_psymtab): Remove global_psymbols and static_psymbols
1646         parameters.
1647
1648 2019-01-10  Tom Tromey  <tom@tromey.com>
1649
1650         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1651         * psymtab.c (allocate_psymtab): Add comment.
1652         * psympriv.h (allocate_psymtab): Add comment.
1653         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1654         initializations.
1655         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1656
1657 2019-01-10  Tom Tromey  <tom@tromey.com>
1658
1659         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1660         Don't declare.
1661         * mipsread.c: Include mdebugread.h.
1662         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1663         Declare.
1664         * elfread.c: Include mdebugread.h.
1665
1666 2019-01-09  Tom Tromey  <tom@tromey.com>
1667
1668         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1669         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1670         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1671         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1672         (psym_lookup_symbol, psym_find_last_source_symtab)
1673         (psym_forget_cached_source_info, psym_print_stats)
1674         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1675         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1676         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1677         (psym_find_compunit_symtab_by_address)
1678         (maintenance_print_psymbols, maintenance_info_psymtabs)
1679         (maintenance_check_psymtabs): Use ranged for.
1680         * psymtab.h (class objfile_psymtabs): New.
1681         (require_partial_symbols): Return objfile_psymtabs.
1682         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1683
1684 2019-01-09  Tom Tromey  <tom@tromey.com>
1685
1686         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1687         (find_pc_mapped_section, list_overlays_command)
1688         (map_overlay_command, unmap_overlay_command)
1689         (simple_overlay_update): Use all_objfiles.
1690         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1691         * printcmd.c (info_symbol_command): Use all_objfiles.
1692         * objfiles.h (ALL_OBJSECTIONS): Remove.
1693         * maint.c (maintenance_translate_address): Use all_objfiles.
1694         * gcore.c (gcore_create_callback): Use all_objfiles.
1695         (objfile_find_memory_regions): Likewise.
1696
1697 2019-01-09  Tom Tromey  <tom@tromey.com>
1698
1699         * symtab.c (find_line_symtab, info_sources_command)
1700         (make_source_files_completion_list): Use objfile_compunits.
1701         * source.c (select_source_symtab): Use objfile_compunits.
1702         * objfiles.h (struct objfile): Update comment.
1703         (ALL_OBJFILES): Remove.
1704         (ALL_FILETABS): Remove.
1705         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1706         objfile_compunits.
1707
1708 2019-01-09  Tom Tromey  <tom@tromey.com>
1709
1710         * symmisc.c (print_objfile_statistics, dump_objfile)
1711         (maintenance_print_symbols): Use compunit_filetabs.
1712         * source.c (forget_cached_source_info_for_objfile): Use
1713         compunit_filetabs.
1714         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1715         (ALL_FILETABS): Use compunit_filetabs.
1716         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1717         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1718
1719 2019-01-09  Tom Tromey  <tom@tromey.com>
1720
1721         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1722         (compunit_filetabs): New.
1723         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1724         compunit_filetabs.
1725         (info_sources_command, make_source_files_completion_list): Remove
1726         declaration.
1727         * symmisc.c (print_objfile_statistics, dump_objfile)
1728         (maintenance_print_symbols): Remove declaration.
1729         (maintenance_info_symtabs): Use compunit_filetabs.
1730         (maintenance_info_line_tables): Likewise.
1731         * source.c (select_source_symtab): Change local variable name.
1732         (forget_cached_source_info_for_objfile): Remove declaration.
1733         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1734         * objfiles.c (objfile_relocate1): Remove declaration.
1735         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1736         declaration.
1737         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1738         * coffread.c (coff_symtab_read): Remove declaration.
1739         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1740         compunit_filetabs.
1741
1742 2019-01-09  Tom Tromey  <tom@tromey.com>
1743
1744         * symtab.c (lookup_objfile_from_block)
1745         (find_pc_sect_compunit_symtab, search_symbols)
1746         (default_collect_symbol_completion_matches_break_on): Use
1747         objfile_compunits.
1748         * objfiles.h (ALL_COMPUNITS): Remove.
1749         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1750         * cp-support.c (add_symbol_overload_list_qualified): Use
1751         objfile_compunits.
1752         * ada-lang.c (ada_collect_symbol_completion_matches)
1753         (ada_add_global_exceptions): Use objfile_compunits.
1754
1755 2019-01-09  Tom Tromey  <tom@tromey.com>
1756
1757         * source.c (select_source_symtab)
1758         (forget_cached_source_info_for_objfile): Remove declaration.
1759         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1760         declaration.
1761         * maint.c (count_symtabs_and_blocks): Remove declaration.
1762         * cp-support.c (add_symbol_overload_list_qualified): Remove
1763         declaration.
1764         * coffread.c (coff_symtab_read): Remove declaration.
1765         * symtab.c (lookup_symbol_in_objfile_symtabs)
1766         (basic_lookup_transparent_type_1): Use objfile_compunits.
1767         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1768         (info_sources_command, search_symbols)
1769         (default_collect_symbol_completion_matches_break_on)
1770         (make_source_files_completion_list): Remove declaration.
1771         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1772         (ada_collect_symbol_completion_matches)
1773         (ada_add_global_exceptions): Remove declaration.
1774         * linespec.c (iterate_over_all_matching_symtabs): Use
1775         objfile_compunits.
1776         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1777         (class objfile_compunits): New.
1778         (ALL_COMPUNITS): Use objfile_compunits.
1779         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1780         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1781         objfile_compunits.
1782         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1783
1784 2019-01-09  Tom Tromey  <tom@tromey.com>
1785
1786         * symtab.c (search_symbols)
1787         (default_collect_symbol_completion_matches_break_on): Use
1788         objfile_msymbols.
1789         * ada-lang.c (ada_lookup_simple_minsym)
1790         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1791         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1792         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1793         objfile_msymbols.
1794         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1795         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1796         * objc-lang.c (find_methods): Use objfile_msymbols.
1797         (info_selectors_command, info_classes_command): Likewise.
1798         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1799         * objfiles.h (class objfile_msymbols): New.
1800         (ALL_OBJFILE_MSYMBOLS): Remove.
1801         (ALL_MSYMBOLS): Remove.
1802
1803 2019-01-09  Tom Tromey  <tom@tromey.com>
1804
1805         * common/next-iterator.h (next_adapter): Add Iterator template
1806         parameter.
1807         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1808         (class all_objfiles_safe): New.
1809         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1810         * objfiles.c (put_objfile_before): Update comment.
1811         (add_separate_debug_objfile): Likewise.
1812         (free_all_objfiles): Use all_objfiles_safe.
1813         (objfile_purge_solibs): Likewise.
1814
1815 2019-01-09  Tom Tromey  <tom@tromey.com>
1816
1817         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1818         (expand_symtab_containing_pc, lookup_static_symbol)
1819         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1820         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1821         all_objfiles.
1822         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1823         * breakpoint.c (create_overlay_event_breakpoint)
1824         (create_longjmp_master_breakpoint)
1825         (create_std_terminate_master_breakpoint)
1826         (create_exception_master_breakpoint): Use all_objfiles.
1827         * linux-thread-db.c (try_thread_db_load_from_pdir)
1828         (has_libpthread): Use all_objfiles.
1829         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1830         * linespec.c (iterate_over_all_matching_symtabs)
1831         (search_minsyms_for_name): Use all_objfiles.
1832         * maint.c (maintenance_info_sections): Use all_objfiles.
1833         * main.c (captured_main_1): Use all_objfiles.
1834         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1835         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1836         * guile/scm-pretty-print.c
1837         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1838         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1839         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1840         (maintenance_print_msymbols): Use all_objfiles.
1841         * source.c (select_source_symtab): Use all_objfiles.
1842         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1843         * symfile.c (remove_symbol_file_command)
1844         (expand_symtabs_matching, map_symbol_filenames): Use
1845         all_objfiles.
1846         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1847         all_objfiles.
1848         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1849         * objc-lang.c (find_methods): Use all_objfiles.
1850         * objfiles.c (have_partial_symbols, have_full_symbols)
1851         (have_minimal_symbols, qsort_cmp)
1852         (default_iterate_over_objfiles_in_search_order): Use
1853         all_objfiles.
1854         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1855         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1856         (maintenance_check_psymtabs): Use all_objfiles.
1857         (ALL_PSYMTABS): Remove.
1858         * compile/compile-object-run.c (do_module_cleanup): Use
1859         all_objfiles.
1860         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1861         * cp-support.c (add_symbol_overload_list_qualified): Use
1862         all_objfiles.
1863         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1864         Use all_objfiles.
1865         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1866         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1867         all_objfiles.
1868         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1869         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1870         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1871         Uses all_objfiles.
1872         * solib.c (solib_read_symbols): Use all_objfiles
1873
1874 2019-01-09  Tom Tromey  <tom@tromey.com>
1875
1876         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1877         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1878         all_objfiles.
1879         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1880         * symmisc.c (print_symbol_bcache_statistics)
1881         (print_objfile_statistics, maintenance_print_objfiles)
1882         (maintenance_info_symtabs, maintenance_check_symtabs)
1883         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1884         all_objfiles.
1885         * source.c (forget_cached_source_info): Use all_objfiles.
1886         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1887         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1888         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1889         * objfiles.c (update_section_map): Use all_objfiles.
1890         (shared_objfile_contains_address_p): Likewise.
1891         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1892         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1893
1894 2019-01-09  Tom Tromey  <tom@tromey.com>
1895
1896         * common/next-iterator.h: New file.
1897         * objfiles.h (class all_objfiles): New.
1898         (struct objfile_iterator): New.
1899
1900 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1901
1902         * NEWS: Move the description of the changed "frame", "select-frame",
1903          and "info frame" commands to the Changed commands section.
1904
1905 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1906
1907         * gdbtypes.c (check_stub_method_group): Remove handling of old
1908         mangling schemes.
1909         * linespec.c (find_methods): Likewise.
1910         * stabsread.c (read_member_functions): Likewise.
1911         * valops.c (search_struct_method): Likewise.
1912         (value_struct_elt_for_reference): Likewise.
1913         * NEWS: Mention this change.
1914
1915 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1916
1917         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1918         print_source_lines.
1919         * source.c (print_source_lines_base): Update line number check.
1920         (print_source_lines): New function.
1921         (source_lines_range::source_lines_range): New function.
1922         * source.h (class source_lines_range): New class.
1923         (print_source_lines): New declaration.
1924
1925 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1926
1927         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1928
1929 2019-01-08  Tom Tromey  <tom@tromey.com>
1930             Simon Marchi  <simon.marchi@ericsson.com>
1931
1932         PR gdb/24060
1933         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1934         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1935         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1936         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1937         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1938         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1939
1940 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * source.c (select_source_symtab): Move header comment to
1943         declaration in source.h.
1944         (forget_cached_source_info_for_objfile): Likewise.
1945         (forget_cached_source_info): Likewise.
1946         (identify_source_line): Likewise.
1947         * source.h (identify_source_line): Move declaration from symtab.h
1948         and add comment from source.c
1949         (print_source_lines): Likewise.
1950         (forget_cached_source_info_for_objfile): Likewise.
1951         (forget_cached_source_info): Likewise.
1952         (select_source_symtab): Likewise.
1953         (enum print_source_lines_flag): Move definition from symtab.h.
1954         * symtab.h (identify_source_line): Move declaration to source.h.
1955         (print_source_lines): Likewise.
1956         (forget_cached_source_info_for_objfile): Likewise.
1957         (forget_cached_source_info): Likewise.
1958         (select_source_symtab): Likewise.
1959         (enum print_source_lines_flag): Move definition to source.h.
1960         * tui/tui-hooks.c: Add 'source.h' include.
1961
1962 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * source.c (print_source_lines_base): Handle requests to print
1965         reverse line number sequences, and guard against empty lines
1966         string.
1967
1968 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * source.c (print_source_lines_base): Fix skip of '\r' if next
1971         character is '\n'.
1972
1973 2019-01-06  Tom Tromey  <tom@tromey.com>
1974
1975         * c-exp.y (struct c_parse_state) <macro_original_text,
1976         expansion_obstack>: New member.
1977         (macro_original_text, expansion_obstack): Remove globals.
1978         (scan_macro_expansion, scanning_macro_expansion)
1979         (finished_macro_expansion): Update.
1980         (scan_macro_cleanup): Remove.
1981         (yylex, c_parse): Update.
1982
1983 2019-01-06  Tom Tromey  <tom@tromey.com>
1984
1985         * c-exp.y (struct c_parse_state) <strings>: New member.
1986         (operator_stoken): Update.
1987
1988 2019-01-06  Tom Tromey  <tom@tromey.com>
1989
1990         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1991         (union type_stack_elt) <typelist_val>: Now a pointer to
1992         std::vector.
1993         (type_stack_cleanup): Don't declare.
1994         (push_typelist): Update.
1995         * parse.c (pop_typelist): Return a std::vector.
1996         (push_typelist): Take a std::vector.
1997         (follow_types): Update.  Do not free args.
1998         (type_stack_cleanup): Remove.
1999         * c-exp.y (struct c_parse_state): New.
2000         (cpstate): New global.
2001         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2002         (nonempty_typelist): Update.
2003         (func_mod): Create a new vector.
2004         (c_parse): Create a c_parse_state.
2005         (check_parameter_typelist): Do not delete params.
2006         (function_method): Update.  Do not delete type_list.
2007
2008 2019-01-06  Tom Tromey  <tom@tromey.com>
2009
2010         PR gdb/28155:
2011         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2012         check_typedef.
2013         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2014         (print_return_value): Likewise.
2015
2016 2019-01-05  Tom Tromey  <tom@tromey.com>
2017
2018         * contrib/cleanup_check.py: Remove.
2019         * contrib/gcc-with-excheck: Remove.
2020         * contrib/exsummary.py: Remove.
2021         * contrib/excheck.py: Remove.
2022
2023 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2024
2025         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2026         NULL. Initialize tpprev to NULL instead of assigning it
2027         to NULL on the next statement.
2028         * windows-nat.c (windows_delete_thread): Remove check for
2029         main_thread_id before printing thread exit notifications.
2030         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2031         Remove thread ID check against main_thread_id.
2032         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2033         windows_delete_thread.
2034         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2035
2036 2019-01-04  Tom Tromey  <tom@tromey.com>
2037
2038         * compile/compile.c (_initialize_compile): Use upper case for
2039         metasyntactic variables.
2040         * symmisc.c (_initialize_symmisc): Use upper case for
2041         metasyntactic variables.
2042         * psymtab.c (_initialize_psymtab): Use upper case for
2043         metasyntactic variables.
2044         * demangle.c (demangle_command): Use upper case for metasyntactic
2045         variables.
2046         (_initialize_demangler): Likewise.
2047         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2048         variables.
2049
2050 2019-01-03  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2053
2054 2019-01-03  Tom Tromey  <tom@tromey.com>
2055
2056         * python/py-symtab.c (salpy_str): Update.
2057         (struct salpy_sal_object) <symtab>: Now a PyObject.
2058         (salpy_dealloc): Update.
2059         (del_objfile_sal): Use gdbpy_ref.
2060
2061 2019-01-03  Tom Tromey  <tom@tromey.com>
2062
2063         * python/py-type.c (convert_field): Use new_reference.  Return
2064         gdbpy_ref.
2065         (make_fielditem): Return gdbpy_ref.
2066         (typy_fields): Update.
2067         (typy_getitem): Update.
2068         (field_name): Return gdbpy_ref.  Use new_reference.
2069         (typy_iterator_iternext): Update.
2070
2071 2019-01-03  Tom Tromey  <tom@tromey.com>
2072
2073         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2074
2075 2019-01-03  Tom Tromey  <tom@tromey.com>
2076
2077         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2078         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2079         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2080         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2081         (pspy_set_type_printers): Likewise.
2082         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2083         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2084         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2085         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2086         (objfpy_set_type_printers): Likewise.
2087
2088 2019-01-03  Tom Tromey  <tom@tromey.com>
2089
2090         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2091         (gdbpy_print_stack): Use gdbpy_err_fetch.
2092         * python/python-internal.h (class gdbpy_err_fetch): New class.
2093         (class gdbpy_enter) <m_error_type, m_error_value,
2094         m_error_traceback>: Remove.
2095         <m_error>: New member.
2096         (gdbpy_exception_to_string): Don't declare.
2097         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2098         * python/py-value.c (convert_value_from_python): Use
2099         gdbpy_err_fetch.
2100         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2101         gdbpy_exception_to_string.
2102         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2103         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2104         gdbpy_err_fetch.
2105
2106 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2107
2108         * linux-nat.c (delete_lwp_cleanup): Delete.
2109         (struct lwp_deleter): New struct.
2110         (lwp_info_up): New typedef.
2111         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2112         lwp_info_up.
2113
2114 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * linux-fork.c (class scoped_switch_fork_info): New class.
2117         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2118
2119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2120
2121         * valops.c (find_overload_match): Remove use of null_cleanup, and
2122         calls to do_cleanups.
2123
2124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2125
2126         * compile/compile-cplus-types.c
2127         (compile_cplus_instance::decl_name): Handle changes to
2128         cp_func_name.
2129         * cp-support.c (cp_func_name): Update header comment, update
2130         return type.
2131         * cp-support.h (cp_func_name): Update return type in declaration.
2132         * valops.c (find_overload_match): Move temp_func local to top
2133         level of function and change its type.  Use temp_func to hold and
2134         delete temporary string obtained from cp_func_name.
2135
2136 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2139         gdb::char_vector, remove cleanup, and update uses of `msg`.
2140
2141 2019-01-03  Jim Wilson  <jimw@sifive.com>
2142
2143         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2144
2145 2019-01-02  Tom Tromey  <tom@tromey.com>
2146
2147         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2148         (tdesc_parse_xml): Remove cleanups.
2149         * target-descriptions.h (make_cleanup_free_target_description):
2150         Don't declare.
2151         (target_desc_deleter): New struct.
2152         (target_desc_up): New typedef.
2153         * target-descriptions.c (target_desc_deleter::operator()): Rename
2154         from free_target_description.
2155         (make_cleanup_free_target_description): Remove.
2156
2157 2019-01-02  Tom Tromey  <tom@tromey.com>
2158
2159         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2160         constructor, destructor.
2161         (linespec_parser): Remove typedef.
2162         (~linespec_parser): Rename from linespec_parser_delete.
2163         (linespec_lex_to_end, linespec_complete_label)
2164         (linespec_complete): Update.
2165         (decode_line_full): Remove cleanups.
2166         (decode_line_1): Update.
2167
2168 2019-01-02  Tom Tromey  <tom@tromey.com>
2169
2170         * python/python-internal.h (inferior_to_inferior_object): Change
2171         return type.
2172         * python/py-exitedevent.c (create_exited_event_object): Update.
2173         * python/py-inferior.c (inferior_to_inferior_object): Return
2174         gdbpy_ref.
2175         (python_new_inferior, python_inferior_deleted)
2176         (thread_to_thread_object, delete_thread_object)
2177         (build_inferior_list, gdbpy_selected_inferior): Update.
2178         * python/py-infthread.c (create_thread_object): Update.  Also fail
2179         if inferior_to_inferior_object fails.
2180
2181 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2182
2183         * inferior.h (class inferior) <displaced_step_state>: New field.
2184         * infrun.h (struct displaced_step_state): Move here from
2185         infrun.c.  Initialize fields, add constructor.
2186         <inf>: Remove field.
2187         <reset>: New method.
2188         * infrun.c (struct displaced_step_inferior_state): Move to
2189         infrun.h.
2190         (displaced_step_inferior_states): Remove.
2191         (get_displaced_stepping_state): Adust.
2192         (displaced_step_in_progress_any_inferior): Adjust.
2193         (displaced_step_in_progress_thread): Adjust.
2194         (displaced_step_in_progress): Adjust.
2195         (add_displaced_stepping_state): Remove.
2196         (get_displaced_step_closure_by_addr): Adjust.
2197         (remove_displaced_stepping_state): Remove.
2198         (infrun_inferior_exit): Call displaced_step_state.reset.
2199         (use_displaced_stepping): Don't check for NULL.
2200         (displaced_step_prepare_throw): Call
2201         get_displaced_stepping_state.
2202         (displaced_step_fixup): Don't check for NULL.
2203         (prepare_for_detach): Don't check for NULL.
2204
2205 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2206
2207         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2208          in case of call that did not complete.
2209
2210 2019-01-02  Andrey Utkin  <autkin@undo.io>
2211
2212         * symfile.c (find_separate_debug_file): Fix search of debug files for
2213         remote debuggee.
2214
2215 2019-01-02  Tom Tromey  <tom@tromey.com>
2216
2217         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2218         indentation.
2219         * python/py-frame.c (frapy_older): Remove cast.
2220         (frapy_newer): Likewise.
2221         * python/py-breakpoint.c (local_setattro): Remove cast.
2222         * python/py-arch.c (archpy_name): Remove local variable.
2223         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2224
2225 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2226
2227         * unittests/basic_string_view/element_access/char/empty.cc:
2228         Fix year range in copyright header.
2229
2230 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2233         Delete.
2234         <operator==>: Update with for removed field.
2235         <hash>: Likewise.
2236         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2237         <isa_features>: ...this.
2238         <abi_features>: New field.
2239         (riscv_isa_flen): Update comment.
2240         (riscv_abi_xlen): New declaration.
2241         (riscv_abi_flen): New declaration.
2242         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2243         isa_features.
2244         (riscv_abi_xlen): New function.
2245         (riscv_isa_flen): Update to get answer from isa_features.
2246         (riscv_abi_flen): New function.
2247         (riscv_has_fp_abi): Update to get answer from abi_features.
2248         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2249         xlen and flen.
2250         (riscv_call_info) <xlen, flen>: Update comment.
2251         (riscv_call_arg_struct): Remove invalid assertions
2252         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2253         is removed.
2254         (riscv_gdbarch_init): Gather isa features and abi features
2255         separately, ensure both match on the gdbarch when reusing an old
2256         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2257         a target with 64-bit float hardware.
2258
2259 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2260
2261         * source.c (search_command_helper): Stop reverse search
2262         when line 1 has been searched.
2263
2264 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2265
2266         * record-full.c (record_full_base_target::close): Rewrite
2267         record_full_core_buf_list free logic.
2268
2269 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2270
2271         * break-catch-syscall.c (print_one_catch_syscall): xfree
2272         the last text.
2273
2274 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2275
2276         * top.c (print_gdb_version): Update Copyright year in version
2277         message.
2278
2279 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2280
2281         Update copyright year range in all GDB files.
2282
2283 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2284
2285         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2286
2287 For older changes see ChangeLog-2018.
2288 \f
2289 Local Variables:
2290 mode: change-log
2291 left-margin: 8
2292 fill-column: 74
2293 version-control: never
2294 coding: utf-8
2295 End:
2296