gdb/ChangeLog

   1 2019-05-15  John Darrington <john@darrington.wattle.id.au>
   2
   3         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
   4         (advance, posn, abstract_read_memory): New functions.
   5         [struct mem_read_abstraction]: New struct.
   6         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
   7
   8 2019-05-14  Tom Tromey  <tromey@adacore.com>
   9
  10         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
  11         value is not lval_memory.
  12
  13 2019-05-14  Tom Tromey  <tromey@adacore.com>
  14
  15         * solib.c (info_sharedlibrary_command): Style the file name.
  16
  17 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
  18
  19         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
  20         (aarch64_vnv_type): Likewise.
  21         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
  22         * common/tdesc.c: Likewise.
  23         * common/tdesc.h (enum tdesc_type_kind): Likewise.
  24         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
  25         * features/aarch64-fpu.xml: Add ieee half view.
  26         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
  27         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
  28         * gdbtypes.h (struct builtin_type): Likewise.
  29         (struct objfile_type): Likewise.
  30
  31 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
  32
  33         * language.c (language_sniff_from_mangled_name): Fix "langauge"
  34         typo.
  35         * location.h (string_to_event_location): Likewise.
  36
  37 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  38
  39         GDB 8.3 released.
  40
  41 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  42
  43         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
  44         New variable declaration.
  45         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
  46         New variable.
  47         (print_one_breakpoint): Use ui_out::test_flags and new global
  48         variable to compute use_fixed_output.
  49         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
  50         Remove.
  51         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
  52         (mi_multi_location_breakpoint_output_fixed): Remove.
  53         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
  54         new variable.
  55         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
  56         fix_multi_location_breakpoint_output flag if version >= 3.
  57         * ui-out.h (enum ui_out_flag)
  58         <fix_multi_location_breakpoint_output>: New enumerator.
  59
  60 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  61
  62         * contrib/cc-with-tweaks.sh: Validate dwz's work.
  63
  64 2019-05-10  Tom Tromey  <tromey@adacore.com>
  65
  66         * ada-lang.c (catch_ada_completer): New function.
  67         (_initialize_ada_language): Use it.
  68
  69 2019-05-10  Tom Tromey  <tromey@adacore.com>
  70
  71         * thread.c (print_thread_info): Make "requested_threads" const.
  72         * gdbthread.h (print_thread_info): Make "requested_threads"
  73         const.
  74         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
  75         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
  76
  77 2019-05-08  Tom Tromey  <tom@tromey.com>
  78
  79         * gdbtypes.c (objfile_type_data): Change type.
  80         (objfile_type, _initialize_gdbtypes): Update.
  81
  82 2019-05-08  Tom Tromey  <tom@tromey.com>
  83
  84         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
  85         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
  86         (_initialize_dwarf2_frame): Update.
  87
  88 2019-05-08  Tom Tromey  <tom@tromey.com>
  89
  90         * objc-lang.c (objc_objfile_data): Change type.
  91         (find_methods): Update.
  92         (_initialize_objc_lang): Remove.
  93
  94 2019-05-08  Tom Tromey  <tom@tromey.com>
  95
  96         * stabsread.c (rs6000_builtin_type_data): Change type.
  97         (rs6000_builtin_type, _initialize_stabsread): Update.
  98
  99 2019-05-08  Tom Tromey  <tom@tromey.com>
 100
 101         * mips-tdep.c (mips_pdr_data): Remove.
 102         (_initialize_mips_tdep): Update.
 103
 104 2019-05-08  Tom Tromey  <tom@tromey.com>
 105
 106         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 107         (hppa_init_objfile_priv_data, read_unwind_info)
 108         (find_unwind_entry, _initialize_hppa_tdep): Update.
 109
 110 2019-05-08  Tom Tromey  <tom@tromey.com>
 111
 112         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 113         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 114         on obstack.
 115         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 116
 117 2019-05-08  Tom Tromey  <tom@tromey.com>
 118
 119         * mdebugread.c (basic_type_data): Change type.
 120         (basic_type, _initialize_mdebugread): Update.
 121
 122 2019-05-08  Tom Tromey  <tom@tromey.com>
 123
 124         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 125
 126 2019-05-08  Tom Tromey  <tom@tromey.com>
 127
 128         * nto-tdep.c (nto_inferior_data_reg): Change type.
 129         (nto_inferior_data): Update.
 130         (nto_inferior_data_cleanup, nto_new_inferior_data)
 131         (_initialize_nto_tdep): Remove.
 132         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 133
 134 2019-05-08  Tom Tromey  <tom@tromey.com>
 135
 136         * ada-lang.c (struct ada_inferior_data): Add initializers.
 137         (ada_inferior_data): Change type.
 138         (ada_inferior_data_cleanup): Remove.
 139         (get_ada_inferior_data, ada_inferior_exit)
 140         (struct ada_pspace_data): Add initializers, destructor.
 141         (ada_pspace_data_handle): Change type.
 142         (get_ada_pspace_data): Update.
 143         (ada_pspace_data_cleanup): Remove.
 144
 145 2019-05-08  Tom Tromey  <tom@tromey.com>
 146
 147         * coffread.c (struct coff_symfile_info): Add initializers.
 148         (coff_objfile_data_key): Move lower.  Change type.
 149         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 150         Update.
 151         (coff_free_info): Remove.
 152
 153 2019-05-08  Tom Tromey  <tom@tromey.com>
 154
 155         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 156         (fbsd_pspace_data_handle): Move lower.  Change type.
 157         (get_fbsd_pspace_data): Update.
 158         (fbsd_pspace_data_cleanup): Remove.
 159         (_initialize_fbsd_tdep): Update.
 160
 161 2019-05-08  Tom Tromey  <tom@tromey.com>
 162
 163         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 164         (get_ada_tasks_pspace_data): Update.
 165         (ada_tasks_pspace_data_cleanup): Remove.
 166         (_initialize_tasks): Update.
 167         (ada_tasks_inferior_data_handle): Change type.
 168         (get_ada_tasks_inferior_data): Update.
 169         (ada_tasks_inferior_data_cleanup): Remove.
 170         (struct ada_tasks_pspace_data): Add initializers.
 171
 172 2019-05-08  Tom Tromey  <tom@tromey.com>
 173
 174         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 175         * symfile-debug.c (debug_sym_get_probes): Change type.
 176         * stap-probe.c (handle_stap_probe):
 177         (stap_static_probe_ops::get_probes): Change type.
 178         * probe.h (class static_probe_ops) <get_probes>: Change type.
 179         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 180         (parse_probes_in_pspace): Update.
 181         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 182         Update.
 183         (any_static_probe_ops::get_probes): Change type.
 184         * elfread.c (elfread_data): New typedef.
 185         (probe_key): Change type.
 186         (elf_get_probes): Likewise.  Update.
 187         (probe_key_free): Remove.
 188         (_initialize_elfread): Update.
 189         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 190         Change type.
 191         (dtrace_process_dof_probe, dtrace_process_dof)
 192         (dtrace_static_probe_ops::get_probe): Change type.
 193
 194 2019-05-08  Tom Tromey  <tom@tromey.com>
 195
 196         * xcoffread.c (struct xcoff_symfile_info): Rename from
 197         coff_symfile_info.  Add initializers.
 198         (xcoff_objfile_data_key): Move lower.  Change type.
 199         (XCOFF_DATA): Rewrite.
 200         (xcoff_free_info): Remove.
 201         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 202         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 203         (xcoff_initial_scan): Update.
 204
 205 2019-05-08  Tom Tromey  <tom@tromey.com>
 206
 207         * solib-svr4.c (struct svr4_info): Add initializers and
 208         destructor.
 209         <probes_table>: Now an htab_up.
 210         (solib_svr4_pspace_data): Change type.
 211         (free_probes_table): Simplify.
 212         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 213         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 214         (probes_table_remove_objfile_probes, register_solib_event_probe)
 215         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 216         (_initialize_svr4_solib): Update.
 217
 218 2019-05-08  Tom Tromey  <tom@tromey.com>
 219
 220         * remote.c (remote_pspace_data): Change type.
 221         (remote_pspace_data_cleanup): Remove.
 222         (get_remote_exec_file, set_pspace_remote_exec_file)
 223         (_initialize_remote): Update.
 224
 225 2019-05-08  Tom Tromey  <tom@tromey.com>
 226
 227         * breakpoint.c (breakpoint_objfile_key): Change type.
 228         (get_breakpoint_objfile_data): Update.
 229         (free_breakpoint_objfile_data): Remove.
 230         (_initialize_breakpoint): Update.
 231
 232 2019-05-08  Tom Tromey  <tom@tromey.com>
 233
 234         * linux-tdep.c (struct linux_info): Add initializers.
 235         (linux_inferior_data): Move.  Change type.
 236         (invalidate_linux_cache_inf): Update.
 237         (linux_inferior_data_cleanup): Remove.
 238         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 239
 240 2019-05-08  Tom Tromey  <tom@tromey.com>
 241
 242         * auxv.c (auxv_inferior_data): Move.  Change type.
 243         (auxv_inferior_data_cleanup): Remove.
 244         (invalidate_auxv_cache_inf): Rewrite.
 245         (get_auxv_inferior_data, _initialize_auxv): Update.
 246
 247 2019-05-08  Tom Tromey  <tom@tromey.com>
 248
 249         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 250         (symfile_debug_objfile_data_key): Change type.
 251         (symfile_debug_installed, debug_qf_has_symbols)
 252         (debug_qf_find_last_source_symtab)
 253         (debug_qf_forget_cached_source_info)
 254         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 255         (debug_qf_print_stats, debug_qf_dump)
 256         (debug_qf_expand_symtabs_for_function)
 257         (debug_qf_expand_all_symtabs)
 258         (debug_qf_expand_symtabs_with_fullname)
 259         (debug_qf_map_matching_symbols)
 260         (debug_qf_expand_symtabs_matching)
 261         (debug_qf_find_pc_sect_compunit_symtab)
 262         (debug_qf_map_symbol_filenames)
 263         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 264         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 265         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 266         (debug_sym_read_linetable, debug_sym_relocate): Update.
 267         (symfile_debug_free_objfile): Remove.
 268         (install_symfile_debug_logging, _initialize_symfile_debug):
 269         Update.
 270
 271 2019-05-08  Tom Tromey  <tom@tromey.com>
 272
 273         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 274         allocate_on_obstack.
 275         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 276         (get_dwarf2_per_objfile): Update.
 277         (set_dwarf2_per_objfile): Remove.
 278         (dwarf2_has_info, dwarf2_get_section_info): Update.
 279         (dwarf2_free_objfile): Remove.
 280         (_initialize_dwarf2_read): Update.
 281
 282 2019-05-08  Tom Tromey  <tom@tromey.com>
 283
 284         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 285         initializers.
 286         <unsupported_script_warning_printed,
 287         script_not_found_warning_printed>: Now bool.
 288         (auto_load_pspace_data): Change type.
 289         (~auto_load_pspace_info): Rename from
 290         auto_load_pspace_data_cleanup.
 291         (get_auto_load_pspace_data, init_loaded_scripts_info)
 292         (clear_section_scripts, maybe_print_unsupported_script_warning)
 293         (maybe_print_script_not_found_warning, _initialize_auto_load):
 294         Update.
 295
 296 2019-05-08  Tom Tromey  <tom@tromey.com>
 297
 298         * objfiles.c (objfile_pspace_info): Add destructor and
 299         initializers.
 300         (objfiles_pspace_data): Change type.
 301         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 302         (get_objfile_pspace_data): Update.
 303         (objfiles_bfd_data): Change type.
 304         (get_objfile_bfd_data): Update.
 305         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 306
 307 2019-05-08  Tom Tromey  <tom@tromey.com>
 308
 309         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 310         Change type.
 311         (get_catch_syscall_inferior_data): Update.
 312         (catch_syscall_inferior_data_cleanup): Remove.
 313         (_initialize_break_catch_syscall): Update.
 314
 315 2019-05-08  Tom Tromey  <tom@tromey.com>
 316
 317         * inflow.c (struct terminal_info): Add destructor and
 318         initializers.
 319         (inflow_inferior_data): Change type.
 320         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 321         (get_inflow_inferior_data, inflow_inferior_exit)
 322         (swap_terminal_info, _initialize_inflow): Update.
 323
 324 2019-05-08  Tom Tromey  <tom@tromey.com>
 325
 326         * target-dcache.c (target_dcache_cleanup): Remove.
 327         (target_dcache_aspace_key): Change type.
 328         (target_dcache_init_p, target_dcache_invalidate)
 329         (target_dcache_get, target_dcache_get_or_init)
 330         (_initialize_target_dcache): Update.
 331         * dcache.h (struct dcache_deleter): New.
 332
 333 2019-05-08  Tom Tromey  <tom@tromey.com>
 334
 335         * symtab.c (struct symbol_cache): Add destructor and
 336         initializers.
 337         (symbol_cache_key): Move.  Change type.
 338         (make_symbol_cache, free_symbol_cache): Remove.
 339         (get_symbol_cache): Update.
 340         (symbol_cache_cleanup): Remove.
 341         (ALL_PSPACES, symbol_cache_flush)
 342         (maintenance_print_symbol_cache)
 343         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 344         Update.
 345
 346 2019-05-08  Tom Tromey  <tom@tromey.com>
 347
 348         * symtab.c (struct main_info): Add destructor and initializers.
 349         (main_progspace_key): Move.  Change type.
 350         (get_main_info): Update.
 351         (main_info_cleanup): Remove.
 352         (_initialize_symtab): Update.
 353
 354 2019-05-08  Tom Tromey  <tom@tromey.com>
 355
 356         * registry.h (DECLARE_REGISTRY): Define the _key class.
 357
 358 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * NEWS: Merge two 'New commands' sections.
 361
 362 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 363
 364         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 365         parameter and use Ada language definition instead.
 366         (ada_val_print_ptr): Remove unused language parameter.
 367         (ada_val_print_num): Remove language parameter and use Ada language
 368         definition instead.
 369         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 370         parameter.
 371         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 372         parameter and use Ada language definition instead.
 373         (ada_val_print_1): Update all ada_val_print_xxx calls.
 374         Remove language parameter.
 375         (ada_val_print): Update ada_val_print_1 call.
 376
 377 2019-05-08  Tom Tromey  <tromey@adacore.com>
 378
 379         * remote.c (remote_hw_watchpoint_limit)
 380         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 381         Now static.
 382
 383 2019-05-08  Tom Tromey  <tromey@adacore.com>
 384
 385         * maint.c (_initialize_maint_cmds): Move initialization code to
 386         remote.c.
 387         (watchdog, show_watchdog): Move to remote.c.
 388         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 389         "watchdog" static.
 390         (_initialize_remote): Move initialization code from maint.c.
 391         * defs.h (watchdog): Don't declare.
 392
 393 2019-05-08  Tom Tromey  <tromey@adacore.com>
 394
 395         * tui/tui-interp.c: Include main.h.
 396         * interps.c: Include main.h.
 397         * main.h (interpreter_p): Declare.
 398         * defs.h (interpreter_p): Don't declare.
 399
 400 2019-05-08  Tom Tromey  <tromey@adacore.com>
 401
 402         * dwarf2loc.c: Include dwarf2read.h.
 403         * defs.h (read_unsigned_leb128): Don't declare.
 404         * dwarf2read.h (read_unsigned_leb128): Declare.
 405
 406 2019-05-08  Tom Tromey  <tromey@adacore.com>
 407
 408         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 409         method.
 410
 411 2019-05-08  Tom Tromey  <tromey@adacore.com>
 412
 413         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 414         when no wrap column is set.
 415
 416 2019-05-08  Tom Tromey  <tromey@adacore.com>
 417
 418         * c-lang.c (c_get_string): Handle non-C-style arrays.
 419
 420 2019-05-08  Tom Tromey  <tromey@adacore.com>
 421
 422         * typeprint.c (print_offset_data::update): Print the bit offset,
 423         not the number of bits remaining.
 424
 425 2019-05-08  Tom Tromey  <tromey@adacore.com>
 426
 427         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 428         padding at end of comment.
 429
 430 2019-05-08  Tom Tromey  <tromey@adacore.com>
 431
 432         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 433         Compare main types.
 434
 435 2019-05-06  Tom Tromey  <tom@tromey.com>
 436
 437         * common/scoped_mmap.c: Include common-defs.h.
 438         * common/scoped_mmap.h: Don't include config.h.
 439
 440 2019-05-04  Tom Tromey  <tom@tromey.com>
 441
 442         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 443         (struct aarch64_call_info): Add initializers.
 444         <si>: Now a std::vector.
 445         (pass_on_stack, aarch64_push_dummy_call): Update.
 446
 447 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 448             Tom Tromey  <tom@tromey.com>
 449
 450         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 451         (ppc_threads): Now a std::vector.  Now static.
 452         (hwdebug_find_thread_points_by_tid)
 453         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 454         Update.
 455
 456 2019-05-04  Tom Tromey  <tom@tromey.com>
 457
 458         * arc-tdep.c (arc_tdesc_init): Return bool.
 459
 460 2019-05-04  Tom Tromey  <tom@tromey.com>
 461
 462         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 463         Use gdb_assert_not_reached.
 464
 465 2019-05-04  Tom Tromey  <tom@tromey.com>
 466
 467         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 468         "false".
 469
 470 2019-05-04  Tom Tromey  <tom@tromey.com>
 471
 472         * arc-tdep.c (arc_tdesc_init): Use bool.
 473
 474 2019-05-04  Tom Tromey  <tom@tromey.com>
 475
 476         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 477
 478 2019-05-04  Tom Tromey  <tom@tromey.com>
 479
 480         * cli/cli-cmds.c (valid_command_p): Return bool.
 481
 482 2019-05-04  Tom Tromey  <tom@tromey.com>
 483
 484         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 485         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 486
 487 2019-05-04  Raul Tambre  <raul@tambre.ee>
 488
 489         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 490         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 491         operator for comparison.
 492
 493 2019-05-04  Tom Tromey  <tom@tromey.com>
 494
 495         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 496         (lookup_partial_symbol, print_partial_symbols)
 497         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 498         (psymbol_compare): Update.
 499         (add_psymbol_to_bcache): Clear the entire psymbol.
 500         (maintenance_check_psymtabs): Update.
 501         * psympriv.h (struct partial_symbol): Don't derive from
 502         general_symbol_info.
 503         <obj_section, unrelocated_address, address,
 504         set_unrelocated_address>: Update.
 505         <ginfo>: New member.
 506         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 507         (debug_names::write_psymbols): Update.
 508
 509 2019-05-04  Tom de Vries  <tdevries@suse.de>
 510
 511         * contrib/cc-with-tweaks.sh: Support -n arg.
 512
 513 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 514
 515         * corelow.c (core_target::detach): Ensure frame cache and
 516         register caches are cleared.
 517         inferior.c (exit_inferior_1): Likewise.
 518
 519 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 520             Tom Tromey  <tom@tromey.com>
 521
 522         * dictionary.c (collate_pending_symbols_by_language): Remove
 523         "struct" from foreach.
 524         * symtab.c (lookup_global_symbol_from_objfile)
 525         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 526         foreach.
 527         * ser-tcp.c (net_open): Remove "struct" from foreach.
 528         * objfiles.c (objfile_relocate, objfile_rebase)
 529         (objfile_has_symbols): Remove "struct" from foreach.
 530         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 531         from foreach.
 532         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 533         foreach.
 534         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 535         "struct" from foreach.
 536         * ada-lang.c (create_excep_cond_exprs)
 537         (ada_exception_catchpoint_cond_string): Remove "struct" from
 538         foreach.
 539
 540 2019-05-03  Tom Tromey  <tromey@adacore.com>
 541
 542         * ada-exp.y (convert_char_literal): Check suffix of each
 543         enumerator.
 544
 545 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 546
 547         PR ada/21406:
 548         * ada-exp.y (yywrap): Don't define.
 549         * ada-lex.l (%option): Add noyywrap
 550         (yywrap): Remove.
 551
 552 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 553
 554         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 555         _WIN32_WINNT to the XP level, unless already defined to a higher
 556         level.
 557
 558         * unittests/parse-connection-spec-selftests.c:
 559         * ser-tcp.c:
 560         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 561         override.
 562
 563         * symfile.c (find_separate_debug_file): Remove colon from the
 564         drive spec of DOS/Windows file names of the target, so that the
 565         file name produced from DEBUGDIR and the target's directory will
 566         be valid on DOS/Windows systems.
 567
 568 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * rust-lang.c (val_print_struct): Handle printing structures
 571         containing strings.
 572
 573 2019-05-02  Tom Tromey  <tromey@adacore.com>
 574
 575         * valarith.c (_initialize_valarith): Remove.
 576
 577 2019-05-01  Tom Tromey  <tromey@adacore.com>
 578
 579         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 580         bitfields.
 581
 582 2019-05-01  Tom Tromey  <tromey@adacore.com>
 583
 584         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 585         for big-endian copies.
 586
 587 2019-04-30  Ali Tamur  <tamur@google.com>
 588         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 589         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 590         (read_3_bytes): New function.
 591
 592 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 593
 594         * windows-nat.c (main_thread_id): Delete.
 595         (handle_output_debug_string): Replace main_thread_id by
 596         current_event.dwThreadId.
 597         (fake_create_process): Likewise.
 598         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 599         Do not set main_thread_id.
 600         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 601         current_event.dwThreadId.
 602         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 603
 604 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 605
 606         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 607         Use current_event.dwThreadId instead of main_thread_id.
 608
 609 2019-04-30  Tom Tromey  <tromey@adacore.com>
 610
 611         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 612         (create_excep_cond_exprs): Iterate over program spaces.
 613         (ada_exception_catchpoint_cond_string): Examine all minimal
 614         symbols for exception types.
 615
 616 2019-04-30  Tom Tromey  <tromey@adacore.com>
 617
 618         PR c++/24470:
 619         * dwarf2read.c (process_structure_scope): Handle case where type
 620         has template parameters but no symbol was created.
 621
 622 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 623             Chris January  <chris.january@arm.com>
 624
 625         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 626         qualifier.
 627         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 628
 629 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * f-typeprint.c (f_print_type): Update rules for printing
 632         whitespace.
 633         (f_type_print_varspec_suffix): Likewise.
 634
 635 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 636             Chris January  <chris.january@arm.com>
 637
 638         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 639         function arguments.
 640
 641 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * f-lang.c (build_fortran_types): Change name of void type to
 644         lower case.
 645         * f-typeprint.c (f_type_print_base): Print the name of the void
 646         type, rather than a fixed string.
 647         * f-valprint.c (f_decorations): Use lower case void string.
 648
 649 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 650             Chris January  <chris.january@arm.com>
 651
 652         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 653         types for Fortran.
 654
 655 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 656             Chris January  <chris.january@arm.com>
 657             David Lecomber  <david.lecomber@arm.com>
 658
 659         * f-exp.y (BINOP_INTRINSIC): New token.
 660         (exp): New parser rule handling BINOP_INTRINSIC.
 661         (f77_keywords): Add new builtin procedures.
 662         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 663         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 664         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 665         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 666         (print_unop_subexp_f): New function.
 667         (print_binop_subexp_f): New function.
 668         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 669         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 670         (dump_subexp_body_f): Likewise.
 671         (operator_check_f): Likewise.
 672         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 673         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 674
 675 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 676
 677         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 678         UNOP_KIND.
 679         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 680         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 681         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 682         (operator_length_f): New fuction.
 683         (print_subexp_f): New function.
 684         (op_name_f): New function.
 685         (dump_subexp_body_f): New function.
 686         (operator_check_f): New function.
 687         (exp_descriptor_f): Replace standard expression handling functions
 688         with new functions.
 689         * gdb/fortran-operator.def: New file.
 690         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 691         * gdb/std-operator.def: Remove UNOP_KIND.
 692
 693 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 694
 695         * std-operator.def: Remove unbalanced, stray double quote
 696         character.
 697
 698 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 699             Chris January  <chris.january@arm.com>
 700             Daniel Everett  <daniel.everett@arm.com>
 701             Nick Forrington  <nick.forrington@arm.com>
 702             Richard Bunt  <richard.bunt@arm.com>
 703
 704         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 705         of depth when printing anonymous structs or unions.
 706         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 707         Don't print either the top-level value, or the children if the
 708         max-depth is exceeded.
 709         (ppscm_print_children): When printing the key of a map, allow one
 710         extra level of depth.
 711         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 712         print either the top-level value, or the children if the max-depth
 713         is exceeded.
 714         (print_children): When printing the key of a map, allow one extra
 715         level of depth.
 716         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 717         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 718         (user_print_options): Initialise max_depth field.
 719         (val_print_scalar_or_string_type_p): New function.
 720         (val_print): Check to see if the max depth has been reached.
 721         (val_print_check_max_depth): Define new function.
 722         (show_print_max_depth): New function.
 723         (_initialize_valprint): Add 'print max-depth' option.
 724         * valprint.h (struct value_print_options) <max_depth>: New field.
 725         (val_print_check_max_depth): Declare new function.
 726         * NEWS: Document new feature.
 727
 728 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 729
 730         * ada-lang.c (ada_language_defn): Initialise new field.
 731         * c-lang.c (c_is_string_type_p): New function.
 732         (c_language_defn): Initialise new field.
 733         (cplus_language_defn): Initialise new field.
 734         (asm_language_defn): Initialise new field.
 735         (minimal_language_defn): Initialise new field.
 736         * c-lang.h (c_is_string_type_p): Declare new function.
 737         * d-lang.c (d_language_defn): Initialise new field.
 738         * f-lang.c (f_is_string_type_p): New function.
 739         (f_language_defn): Initialise new field.
 740         * go-lang.c (go_is_string_type_p): New function.
 741         (go_language_defn): Initialise new field.
 742         * language.c (default_is_string_type_p): New function.
 743         (unknown_language_defn): Initialise new field.
 744         (auto_language_defn): Initialise new field.
 745         * language.h (struct language_defn) <la_is_string_type_p>: New
 746         member variable.
 747         (default_is_string_type_p): Declare new function.
 748         * m2-lang.c (m2_language_defn): Initialise new field.
 749         * objc-lang.c (objc_language_defn): Initialise new field.
 750         * opencl-lang.c (opencl_language_defn): Initialise new field.
 751         * p-lang.c (pascal_is_string_type_p): New function.
 752         (pascal_language_defn): Initialise new field.
 753         * rust-lang.c (rust_is_string_type_p): New function.
 754         (rust_language_defn): Initialise new field.
 755
 756 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 759         New field.
 760         * ada-lang.c (ada_language_defn): Initialise new field.
 761         * c-lang.c (c_language_defn): Likewise.
 762         (cplus_language_defn): Likewise.
 763         (asm_language_defn): Likewise.
 764         (minimal_language_defn): Likewise.
 765         * d-lang.c (d_language_defn): Likewise.
 766         * f-lang.c (f_language_defn): Likewise.
 767         * go-lang.c (go_language_defn): Likewise.
 768         * language.c (unknown_language_defn): Likewise.
 769         (auto_language_defn): Likewise.
 770         * m2-lang.c (m2_language_defn): Likewise.
 771         * objc-lang.c (objc_language_defn): Likewise.
 772         * opencl-lang.c (opencl_language_defn): Likewise.
 773         * p-lang.c (pascal_language_defn): Likewise.
 774         * rust-lang.c (rust_language_defn): Likewise.
 775
 776 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * ada-lang.c (ada_is_character_type): Change return type to bool.
 779         (ada_is_string_type): Likewise.
 780         * ada-lang.h (ada_is_character_type): Update declaration
 781         (ada_is_string_type): Likewise.
 782
 783 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 784
 785         Support style in 'frame|thread apply'
 786
 787         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 788         * record.c (record_start, record_stop): Update callers of
 789         execute_command_to_string with false.
 790         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 791         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 792         methods.
 793         (class string_file): New constructor with term_out parameter.
 794         Override methods term_out and can_emit_style_escape.  New member
 795         term_out.
 796         (class stdio_file): Override can_emit_style_escape.
 797         (class tee_file): Override term_out and can_emit_style_escape.
 798         * utils.h (can_emit_style_escape): Remove.
 799         * utils.c (can_emit_style_escape): Likewise.
 800         Update all callers of can_emit_style_escape (SOMESTREAM) to
 801         SOMESTREAM->can_emit_style_escape.
 802         * source-cache.c (source_cache::get_source_lines): Likewise.
 803         * stack.c (frame_apply_command_count): Call execute_command_to_string
 804         passing the term_out characteristic of the current gdb_stdout.
 805         * thread.c (thr_try_catch_cmd): Likewise.
 806         * top.c (execute_command_to_string): pass term_out parameter
 807         to construct the string_file for the command output.
 808         * ui-file.c (term_cli_styling): New function (most code moved
 809         from utils.c can_emit_style_escape).
 810         (string_file::string_file, string_file::can_emit_style_escape,
 811         stdio_file::can_emit_style_escape, tee_file::term_out,
 812         tee_file::can_emit_style_escape): New functions.
 813
 814 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 815
 816         * NEWS: Mention the new set|show may-call-functions.
 817         * infcall.c (may_call_functions_p): New variable.
 818         (show_may_call_functions_p): New function.
 819         (call_function_by_hand_dummy): Throws an error if not
 820         may-call-functions.
 821         (_initialize_infcall): Call add_setshow_boolean_cmd for
 822         may-call-functions.
 823
 824 2019-04-25  Keith Seitz  <keiths@redhat.com>
 825
 826         PR c++/24367
 827         * cp-support.c (inspect_type): Don't attempt substitutions
 828         of symbol with the same name.
 829
 830 2019-04-25  Tom Tromey  <tromey@adacore.com>
 831
 832         PR gdb/24475:
 833         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 834         static.
 835
 836 2019-04-25  Tom Tromey  <tromey@adacore.com>
 837
 838         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 839         rvalue reference.
 840         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 841         (gdb_xml_parser::parse): Use std::move.
 842         * python/python-internal.h (gdbpy_convert_exception): Take a const
 843         reference.
 844         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 845         std::move.
 846         * python/py-utils.c (gdbpy_convert_exception): Take a const
 847         reference.
 848         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 849         Use std::move.
 850         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 851         Use std::move.
 852         * mi/mi-main.c (mi_print_exception): Take a const reference.
 853         * main.c (handle_command_errors): Take a const reference.
 854         * linespec.c (parse_linespec): Use std::move.
 855         * infcall.c (run_inferior_call): Use std::move.
 856         (call_function_by_hand_dummy): Use std::move.
 857         * exec.c (try_open_exec_file): Use std::move.
 858         * exceptions.h (exception_print, exception_fprintf)
 859         (exception_print_same): Update.
 860         * exceptions.c (print_exception, exception_print)
 861         (exception_fprintf, exception_print_same): Change parameters to
 862         const reference.
 863         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 864         * common/new-op.c: Use std::move.
 865         * common/common-exceptions.h (struct gdb_exception): Add move
 866         constructor.
 867         (struct gdb_exception_error, struct gdb_exception_quit, struct
 868         gdb_quit_bad_alloc): Change constructor to move constructor.
 869         (throw_exception): Change parameter to rvalue reference.
 870         * common/common-exceptions.c (throw_exception): Take rvalue
 871         reference.
 872         * cli/cli-interp.c (safe_execute_command): Use std::move.
 873         * breakpoint.c (insert_bp_location, location_to_sals): Use
 874         std::move.
 875
 876 2019-04-25  Tom Tromey  <tromey@adacore.com>
 877
 878         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 879         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 880         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 881         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 882         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 883         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 884         guile/scm-value.c: Use unpack.
 885         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 886         gdbscm_gdb_exception.
 887         (gdbscm_throw_gdb_exception): Likewise.
 888         (struct gdbscm_gdb_exception): New.
 889         (unpack): New function.
 890         (gdbscm_wrap): Use unpack.
 891
 892 2019-04-25  Tom Tromey  <tromey@adacore.com>
 893
 894         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 895         (gdb_rl_callback_handler): Use std::move.
 896         * common/common-exceptions.h (struct gdb_exception): Add move
 897         assignment operator.
 898         (throw_exception_sjlj): Change "exception" to const reference.
 899         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 900         (throw_exception_sjlj): Change "exception" to const reference.
 901
 902 2019-04-25  Tom Tromey  <tromey@adacore.com>
 903
 904         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 905         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 906         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 907         Update.
 908         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 909         Update.
 910         * mi/mi-interp.c (mi_interp::exec): Update.
 911         * linespec.c (parse_linespec): Update.
 912         * infcall.c (run_inferior_call): Update.
 913         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 914         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 915         (gdbscm_lookup_global_symbol): Update.
 916         * guile/scm-param.c (gdbscm_parameter_value): Update.
 917         * guile/scm-frame.c (gdbscm_frame_read_register)
 918         (gdbscm_frame_read_var): Update.
 919         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 920         * exec.c (try_open_exec_file): Update.
 921         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 922         (gdb_rl_callback_handler): Update.
 923         * common/common-exceptions.h (exception_none): Don't declare.
 924         * common/common-exceptions.c (exception_none): Don't define.
 925         (struct catcher) <exception>: Update.
 926         * cli/cli-interp.c (safe_execute_command): Update.
 927         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 928
 929 2019-04-25  Ali Tamur  <tamur@google.com>
 930
 931         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 932         (read_attribute_value): Likewise.
 933         (dwarf2_read_addr_index): Update comment.
 934         (read_str_index): Add DW_FORM_strx.
 935         (dwarf2_string_attr): Likewise.
 936         (dwarf2_const_value_attr): Likewise.
 937         (dump_die_shallow): Likewise.
 938         (dwarf2_fetch_constant_bytes): Likewise.
 939         (skip_form_bytes): Likewise.
 940         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 941
 942 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 943
 944         PR corefiles/11608
 945         PR corefiles/18187
 946         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 947         OFFSET.  Verify if current mapping contains an ELF header.
 948         (linux_find_memory_regions_full): Adjust call to
 949         dump_mapping_p.
 950
 951 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 952             Kang Li <kanglictf@gmail.com>
 953
 954         PR gdb/21600
 955
 956         * dwarf2-frame.c (read_initial_length): Be consistent about using
 957         unsigned representation of length.
 958         (decode_frame_entry_1): Likewise.  Check for wraparound of
 959         end pointer as well as buffer overflow.
 960
 961 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 962
 963         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 964         "vq".
 965
 966 2019-04-24  Tom Tromey  <tromey@adacore.com>
 967
 968         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 969
 970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * s12z-tdep.c (s12z_unwind_pc): Delete.
 973         (s12z_unwind_sp): Delete.
 974         (s12z_gdbarch_init): Don't register deleted functions with
 975         gdbarch.
 976
 977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * rl78-tdep.c (rl78_unwind_sp): Delete.
 980         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 981
 982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 985         (xstormy16_unwind_pc): Delete.
 986         (xstormy16_dummy_id): Delete.
 987         (xstormy16_gdbarch_init): Don't register deleted functions with
 988         gdbarch.
 989
 990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * vax-tdep.c (vax_unwind_pc): Delete.
 993         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 994
 995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * v850-tdep.c (v850_unwind_sp): Delete.
 998         (v850_unwind_pc): Delete.
 999         (v850_dummy_id): Delete.
1000         (v850_gdbarch_init): Don't register deleted functions with
1001         gdbarch.
1002
1003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1006         (tilegx_unwind_pc): Delete.
1007         (tilegx_unwind_dummy_id): Delete.
1008         (tilegx_gdbarch_init): Don't register deleted functions with
1009         gdbarch.
1010
1011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1014         (tic6x_dummy_id): Delete.
1015         (tic6x_gdbarch_init): Don't register deleted functions with
1016         gdbarch.
1017
1018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * sparc-tdep.c (sparc_unwind_pc): Delete.
1021         (sparc32_gdbarch_init): Don't register deleted function with
1022         gdbarch.
1023
1024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * sh-tdep.c (sh_unwind_sp): Delete.
1027         (sh_unwind_pc): Delete.
1028         (sh_dummy_id): Delete.
1029         (sh_gdbarch_init): Don't register deleted functions with
1030         gdbarch.
1031
1032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * score-tdep.c (score_unwind_sp): Delete.
1035         (score_unwind_pc): Delete.
1036         (score_dummy_id): Delete.
1037         (score_gdbarch_init): Don't register deleted functions with
1038         gdbarch.
1039
1040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * rx-tdep.c (rx_unwind_pc): Delete.
1043         (rx_unwind_sp): Delete.
1044         (rx_dummy_id): Delete.
1045         (rx_gdbarch_init): Don't register deleted functions with
1046         gdbarch.  Update comment.
1047
1048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1051         (rs6000_dummy_id): Delete.
1052         (rs6000_gdbarch_init): Don't register deleted functions with
1053         gdbarch.
1054
1055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * or1k-tdep.c (or1k_dummy_id): Delete.
1058         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1059
1060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * nios2-tdep.c (nios2_dummy_id): Delete.
1063         (nios2_unwind_sp): Delete.
1064         (nios2_gdbarch_init): Don't register deleted functions with
1065         gdbarch.
1066
1067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * nds32-tdep.c (nds32_dummy_id): Delete.
1070         (nds32_unwind_pc): Delete.
1071         (nds32_unwind_sp): Delete.
1072         (nds32_gdbarch_init): Don't register deleted functions with
1073         gdbarch.
1074
1075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * msp430-tdep.c (msp430_unwind_pc): Delete.
1078         (msp430_unwind_sp): Delete.
1079         (msp430_dummy_id): Delete.
1080         (msp430_gdbarch_init): Don't register deleted functions with
1081         gdbarch.
1082
1083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * moxie-tdep.c (moxie_unwind_sp): Delete.
1086         (moxie_unwind_pc): Delete.
1087         (moxie_dummy_id): Delete.
1088         (moxie_gdbarch_init): Don't register deleted functions with
1089         gdbarch.
1090
1091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1094         (mn10300_unwind_pc): Delete.
1095         (mn10300_unwind_sp): Delete.
1096         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1097         mn10300_unwind_sp.
1098         (mn10300_frame_unwind_init): Don't register deleted functions with
1099         gdbarch.
1100
1101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * mep-tdep.c (mep_unwind_pc): Delete.
1104         (mep_unwind_sp): Delete.
1105         (mep_dummy_id): Delete.
1106         (mep_gdbarch_init): Don't register deleted functions with
1107         gdbarch.
1108
1109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1112         (m68hc11_unwind_sp): Delete.
1113         (m68hc11_gdbarch_init): Don't register deleted functions with
1114         gdbarch.
1115
1116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * m32r-tdep.c (m32r_unwind_sp): Delete.
1119         (m32r_unwind_pc): Delete.
1120         (m32r_dummy_id): Delete.
1121         (m32r_gdbarch_init): Don't register deleted functions with
1122         gdbarch.
1123
1124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * m32c-tdep.c (m32c_unwind_pc): Delete.
1127         (m32c_unwind_sp): Delete.
1128         (m32c_dummy_id): Delete.
1129         (m32c_gdbarch_init): Don't register deleted functions with
1130         gdbarch.
1131
1132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1133
1134         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1135         (lm32_unwind_pc): Delete.
1136         (lm32_dummy_id): Delete.
1137         (lm32_gdbarch_init): Don't register deleted functions with
1138         gdbarch.
1139
1140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1143         (iq2000_unwind_pc): Delete.
1144         (iq2000_dummy_id): Delete.
1145         (iq2000_gdbarch_init): Don't register deleted functions with
1146         gdbarch.
1147
1148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * nds32-tdep.c (nds32_type_align): Delete.
1151         (nds32_push_dummy_call): Use type_align instead.
1152
1153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * arm-tdep.c (arm_type_align): Only handle vector override case.
1156         (arm_push_dummy_call): Use type_align.
1157         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1158
1159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1162         case.
1163         (pass_on_stack): Use type_align.
1164         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1165         function.
1166
1167 2019-04-23  Tom Tromey  <tromey@adacore.com>
1168
1169         * dwarf2read.c (line_header::file_name_at): Remove unused
1170         overload.
1171
1172 2019-04-23  Tom de Vries  <tdevries@suse.de>
1173
1174         PR gdb/24438
1175         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1176         invocation.
1177
1178
1179 2019-03-27  Ali Tamur  <tamur@google.com>
1180
1181         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1182         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1183         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1184         (dwarf_expr_context::get_addr_index): Likewise
1185         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1186         (symbol_needs_eval_context::get_addr_index): Likewise
1187         (disassemble_dwarf_expression): Add DW_OP_addrx
1188         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1189         (read_cutu_die_from_dwo): Update comment
1190         (skip_one_die): Add DW_FORM_addrx
1191         (read_attribute_value): Likewise
1192         (var_decode_location): Add DW_OP_addrx
1193         (dwarf2_const_value_attr): Add DW_FORM_addrx
1194         (dump_die_shallow): Likewise
1195         (dwarf2_fetch_constant_bytes): Likewise
1196         (decode_locdesc): Add DW_OP_addrx
1197         (skip_form_bytes): Add DW_FORM_addrx
1198
1199 2019-04-22  Ali Tamur  <tamur@google.com>
1200
1201         * MAINTAINERS (Write After Approval): Add self.
1202
1203 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1204
1205         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1206         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1207         (open_symbol_file_object): Likewise.
1208         (svr4_default_sos): Add info parameter.
1209         (svr4_read_so_list): Likewise.
1210         (svr4_current_sos_direct): Adjust functions calls to pass down
1211         info.
1212         (svr4_current_sos_1): Add info parameter.
1213         (svr4_current_sos): Call get_svr4_info, pass info down to
1214         svr4_current_sos_1.
1215         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1216         get_svr4_info.
1217         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1218         get_svr4_info.
1219         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1220         to get_svr4_info.
1221         (probes_table_remove_objfile_probes): Likewise.
1222         (register_solib_event_probe): Add info parameter.
1223         (solist_update_incremental): Pass info parameter down to
1224         svr4_read_so_list.
1225         (disable_probes_interface): Add info parameter.
1226         (svr4_handle_solib_event): Pass current_program_space to
1227         get_svr4_info.  Adjust disable_probes_interface cleanup.
1228         (svr4_create_probe_breakpoints): Add info parameter, pass it
1229         down to register_solib_event_probe.
1230         (svr4_create_solib_event_breakpoints): Add info parameter,
1231         pass it down to svr4_create_probe_breakpoints.
1232         (enable_break): Pass info down to
1233         svr4_create_solib_event_breakpoints.
1234         (svr4_solib_create_inferior_hook): Pass current_program_space to
1235         get_svr4_info.
1236         (svr4_clear_solib): Likewise.
1237
1238 2019-04-22  Pedro Alves  <palves@redhat.com>
1239
1240         * solib-svr4.c (svr4_free_objfile_observer): New.
1241         (probe_and_action::objfile): New field.
1242         (probes_table_htab_remove_objfile_probes)
1243         (probes_table_remove_objfile_probes): New functions.
1244         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1245         in the new probe_and_action.  Don't store the probe in 'lookup'.
1246         (svr4_create_probe_breakpoints): Pass objfile to
1247         register_solib_event_probe.
1248         (_initialize_svr4_solib): Register a free_objfile observer.
1249
1250 2019-04-19  Tom Tromey  <tom@tromey.com>
1251
1252         * common/queue.h: Remove.
1253
1254 2019-04-19  Tom Tromey  <tom@tromey.com>
1255
1256         * event-loop.c: Don't include "common/queue.h".
1257
1258 2019-04-19  Tom Tromey  <tom@tromey.com>
1259
1260         * remote.c (remote_target): Use delete.
1261         * remote-notif.h: Include <list>, not "common/queue.h".
1262         (notif_client_p): Remove typedef.
1263         (remote_notif_state): Add constructor, destructor, initializer.
1264         <notif_queue>: Now a std::list.
1265         (remote_notif_state_xfree): Don't declare.
1266         * remote-notif.c (remote_notif_process, handle_notification)
1267         (remote_notif_state_allocate): Update.
1268         (~remote_notif_state): Rename from remote_notif_state_xfree.
1269
1270 2019-04-19  Tom Tromey  <tom@tromey.com>
1271
1272         * symfile.c (reread_symbols): Update.
1273         * objfiles.c (objfile_register_static_link)
1274         (objfile_lookup_static_link): Update
1275         (~objfile) Don't delete static_links.
1276         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1277
1278 2019-04-19  Tom Tromey  <tom@tromey.com>
1279
1280         * type-stack.h (struct type_stack) <insert>: Constify string.
1281         * type-stack.c (type_stack::insert): Constify string.
1282         * gdbtypes.h (lookup_template_type): Update.
1283         (address_space_name_to_int): Update.
1284         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1285         const.
1286         (lookup_template_type): Make name const.
1287         * c-exp.y: Update rules.
1288         (lex_one_token, classify_name, classify_inner_name)
1289         (c_print_token): Update.
1290         * p-exp.y: Update rules.
1291         (yylex): Update.
1292         * f-exp.y: Update rules.
1293         (yylex): Update.
1294         * d-exp.y: Update rules.
1295         (lex_one_token, classify_name, classify_inner_name): Update.
1296         * parse.c (write_dollar_variable, copy_name): Return std::string.
1297         * parser-defs.h (copy_name): Change return type.
1298         * m2-exp.y: Update rules.
1299         (yylex): Update.
1300         * go-exp.y (lex_one_token): Update.
1301         Update rules.
1302         (classify_unsafe_function, classify_packaged_name)
1303         (classify_name, yylex): Update.
1304
1305 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1306
1307         * configure.ac: add --enable-source-highlight switch.
1308         * configure: Regenerate.
1309         * top.c (print_gdb_version): plumb --enable-source-highlight
1310         status to "show configuration".
1311
1312 2019-04-19  Tom Tromey  <tromey@adacore.com>
1313
1314         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1315         Check ADA_TYPE_P.
1316         (empty_record, ada_template_to_fixed_record_type_1)
1317         (template_to_static_fixed_type)
1318         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1319         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1320         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1321         macros.
1322
1323 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1324
1325         PR symtab/24423:
1326         * source.c (print_source_lines_base): Advance "iter" when a
1327         control character is seen.
1328
1329 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1330
1331         * inferior.h (struct infcall_suspend_state_deleter):
1332         Catch exception in destructor to avoid crash.
1333
1334 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1335
1336         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1337         close to the add_com "shell".
1338
1339 2019-04-18  Tom Tromey  <tromey@adacore.com>
1340
1341         * process-stratum-target.h (class process_stratum_target)
1342         <stratum>: Add "final".
1343
1344 2019-04-17  Tom Tromey  <tromey@adacore.com>
1345
1346         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1347         against nullptr before use.
1348
1349 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1350
1351         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1352
1353 2019-04-17  Jim Wilson  <jimw@sifive.com>
1354             Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1357         code read might fail, assume 4-byte breakpoint in that case.
1358
1359 2019-04-15  Leszek Swirski  <leszeks@google.com>
1360
1361         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1362         rather than a hand-rolled POD check when checking for forced MEMORY
1363         classification.
1364
1365 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1366
1367         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1368         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1369         function.
1370         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1371         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1372         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1373         declaration.
1374
1375 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * aarch64-linux-nat.c
1378         (aarch64_linux_nat_target::thread_architecture): Add override.
1379         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1380         each VQ.
1381
1382 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1383
1384         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1385
1386 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1387
1388         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1389         target types of size 96-bits, add some additional comments, and
1390         check that the builtin type we found was the correct size.
1391
1392 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1393
1394         * utils.c (prompt_for_continue): Don't restore the styling at the
1395         end, as applied_style has the wrong value.  This fixes styling in
1396         long lists of file names that are interrupted by the "Continue?"
1397         prompt.
1398
1399 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1402         * c-lang.c (c_language_defn): Likewise.
1403         (cplus_language_defn): Likewise.
1404         (asm_language_defn): Likewise.
1405         (minimal_language_defn): Likewise.
1406         * d-lang.c (d_language_defn): Likewise.
1407         * f-lang.c (f_language_defn): Likewise.
1408         * go-lang.c (go_language_defn): Likewise.
1409         * language.c (unknown_language_defn): Likewise.
1410         (auto_language_defn): Likewise.
1411         * language.h (struct language_defn): Remove la_magic field.
1412         (LANG_MAGIC): Delete.
1413         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1414         * objc-lang.c (objc_language_defn): Likewise.
1415         * opencl-lang.c (opencl_language_defn): Likewise.
1416         * p-lang.c (pascal_language_defn): Likewise.
1417         * rust-lang.c (rust_language_defn): Likewise.
1418
1419 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * riscv-tdep.c (riscv_type_align): New function.
1422         (riscv_type_alignment): Delete.
1423         (riscv_arg_location): Use 'type_align'.
1424         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1425
1426 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1427
1428         * gdbtypes.c (type_align): A struct with no non-static fields also
1429         has alignment of 1.
1430
1431 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1432
1433         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1434         component to 0.
1435         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1436         member.
1437         (riscv_struct_info::analyse): New implementation using new
1438         analyse_inner member function.
1439         (riscv_struct_info::field_offset): New member function.
1440         (riscv_struct_info::m_offsets): New member variable.
1441         (riscv_struct_info::analyse_inner): New private member function,
1442         takes the old implementation of riscv_struct_info::analyse but
1443         extended to track field offsets.
1444         (riscv_call_arg_struct): Update the struct folding special cases
1445         to handle cases where empty C++ structs, which are non-zero
1446         length, are found.
1447         (riscv_arg_location): Initialise the length of each location, a
1448         non-zero length now indicates the location is in use.
1449         (riscv_push_dummy_call): Allow for the first location having a
1450         non-zero offset when setting up arguments.
1451         (riscv_return_value): Likewise, but for return values.
1452
1453 2019-04-11  Tom Tromey  <tromey@adacore.com>
1454
1455         * utils.c (internal_vproblem): Make "msg" const.
1456
1457 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1458
1459         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1460         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1461         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1462         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1463
1464 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1465
1466         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1467         function.
1468         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1469         of amd64_collect_native_gregset.
1470         (amd64_linux_nat_target::store_registers): Likewise.
1471
1472 2019-04-10  Tom Tromey  <tom@tromey.com>
1473
1474         * symtab.c (lookup_global_symbol_from_objfile)
1475         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1476         * objfiles.h (class separate_debug_iterator): New.
1477         (class separate_debug_range): New.
1478         (struct objfile) <separate_debug_objfiles>: New method.
1479         (objfile_separate_debug_iterate): Don't declare.
1480         * objfiles.c (separate_debug_iterator::operator++): Rename from
1481         objfile_separate_debug_iterate.
1482         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1483         iterator.
1484         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1485         iterator.
1486
1487 2019-04-10  Tom Tromey  <tom@tromey.com>
1488
1489         * symfile.c (reread_symbols): Remove old comment.
1490         * objfiles.c (free_all_objfiles): Fix a typo.
1491
1492 2019-04-10  Tom Tromey  <tom@tromey.com>
1493
1494         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1495         * minsyms.c (lookup_minimal_symbol): Use foreach.
1496         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1497         (lookup_minimal_symbol_solib_trampoline): Likewise.
1498         * symfile.c (reread_symbols): Use foreach.
1499
1500 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1501             Tom Tromey  <tromey@adacore.com>
1502
1503         PR rust/24414:
1504         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1505         (rust_lex_int_test): Change "value" to be LONGEST.
1506         (rust_lex_tests): Add test for long integer literal.
1507
1508 2019-04-09  Tom Tromey  <tromey@adacore.com>
1509
1510         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1511         to bool.
1512         (extended_remote_target::attach): Update.
1513         (remote_target::remote_notice_new_inferior): Update.
1514         (remote_target::add_current_inferior_and_thread): Update.
1515         * inferior.c (exit_inferior_1): Use "false".
1516         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1517
1518 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1519
1520         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1521         the "start" command.
1522
1523 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1524
1525         * python/py-inferior.c (infpy_thread_from_thread_handle):
1526         Adjust comments to reflect renaming of thread_from_thread_handle
1527         to thread_from_handle.  Adjust keywords.  Fix type error message.
1528         (inferior_object_methods): Add thread_from_handle.  Retain
1529         thread_from_thread_handle, but mark it as deprecated.
1530
1531 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1532
1533         * gdbthread.h (find_thread_by_handle): Revise declaration.
1534         * thread.c (find_thread_by_handle): Likewise.  Adjust
1535         implementation too.
1536         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1537         support for buffer objects as handles.
1538
1539 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1540
1541         * python/py-infthread.c (thpy_thread_handle): New function.
1542         (thread_object_methods): Register thpy_thread_handle.
1543
1544 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1545
1546         * gdbthread.h (thread_to_thread_handle): Declare.
1547         * thread.c (gdbtypes.h): Include.
1548         (thread_to_thread_handle): New function.
1549
1550         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1551         (target_thread_info_to_thread_handle): Declare.
1552         * target.c (target_thread_info_to_thread_handle): New function.
1553         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1554         * target-delegates.c: Regenerate.
1555
1556         * linux-thread-db.c (class thread_db_target): Add method
1557         thread_info_to_thread_handle.
1558         (thread_db_target::thread_info_to_thread_handle): Define.
1559         * remote.c (class remote_target): Add new method
1560         thread_info_to_thread_handle.
1561         (remote_target::thread_info_to_thread_handle): Define.
1562
1563 2019-04-08  Pedro Alves  <palves@redhat.com>
1564
1565         * common/common-exceptions.c (throw_exception): Don't create
1566         named object to throw; throw directly.
1567         (throw_it): Likewise.  Don't initialize gdb_exception::message
1568         here, with new; pass FMT and AP to the ctor instead.
1569         * common/common-exceptions.h: Include <string>.
1570         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1571         const char *, va_list)): New ctor.  Use std::make_shared.
1572         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1573         errors)): Delete.
1574         (gdb_exception_error::gdb_exception_error(enum errors, const char
1575         *, va_list)): New.
1576         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1577         Add assertion.
1578         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1579         errors)): Delete.
1580         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1581         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1582         Add assertion.
1583
1584 2019-04-08  Tom Tromey  <tom@tromey.com>
1585
1586         * valops.c (value_rtti_indirect_type): Replace throw_exception
1587         with throw.
1588         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1589         with throw.
1590         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1591         throw.
1592         * target.c (target_translate_tls_address): Replace throw_exception
1593         with throw.
1594         * stack.c (frame_apply_command_count): Replace throw_exception
1595         with throw.
1596         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1597         throw.
1598         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1599         with throw.
1600         * rs6000-tdep.c (rs6000_frame_cache)
1601         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1602         * remote.c: Replace throw_exception with throw.
1603         * record-full.c (record_full_message, record_full_wait_1)
1604         (record_full_restore): Replace throw_exception with throw.
1605         * record-btrace.c:
1606         (get_thread_current_frame_id, record_btrace_start_replaying)
1607         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1608         (cmd_record_btrace_start): Replace throw_exception with throw.
1609         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1610         throw.
1611         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1612         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1613         * linespec.c:
1614         (find_linespec_symbols): Replace throw_exception with throw.
1615         * infrun.c (displaced_step_prepare, resume): Replace
1616         throw_exception with throw.
1617         * infcmd.c (post_create_inferior): Replace throw_exception with
1618         throw.
1619         * inf-loop.c (inferior_event_handler): Replace throw_exception
1620         with throw.
1621         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1622         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1623         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1624         (get_prev_frame_always, get_frame_pc_if_available)
1625         (get_frame_address_in_block_if_available, get_frame_language):
1626         Replace throw_exception with throw.
1627         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1628         throw_exception with throw.
1629         * eval.c (fetch_subexp_value, evaluate_var_value)
1630         (evaluate_funcall, evaluate_subexp_standard): Replace
1631         throw_exception with throw.
1632         * dwarf2loc.c (call_site_find_chain)
1633         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1634         Replace throw_exception with throw.
1635         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1636         with throw.
1637         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1638         throw.
1639         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1640         * completer.c (complete_line_internal): Replace throw_exception
1641         with throw.
1642         * compile/compile-object-run.c (compile_object_run): Replace
1643         throw_exception with throw.
1644         * cli/cli-script.c (process_next_line): Replace throw_exception
1645         with throw.
1646         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1647         (btrace_enable, btrace_maint_update_pt_packets): Replace
1648         throw_exception with throw.
1649         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1650         throw_exception with throw.
1651         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1652         throw_exception with throw.
1653         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1654         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1655         * aarch64-tdep.c (aarch64_make_prologue_cache)
1656         (aarch64_make_stub_cache): Replace throw_exception with throw.
1657
1658 2019-04-08  Tom Tromey  <tom@tromey.com>
1659
1660         * common/common-exceptions.c (throw_exception): Rename from
1661         throw_exception_cxx.  Remove old copy.  Make argument const.
1662         (throw_it): Create and throw exception objects directly.
1663         * common/common-exceptions.h (throw_exception): Make argument
1664         const.
1665         (struct gdb_exception_error): Add constructor.
1666         (struct gdb_exception_quit): Add constructor.
1667
1668 2019-04-08  Tom Tromey  <tom@tromey.com>
1669
1670         * common/common-exceptions.h (exception_rethrow): Don't declare.
1671         (TRY_SJLJ): Update comment.
1672         (TRY, CATCH, END_CATCH): Remove.
1673         * common/common-exceptions.c (exception_rethrow): Remove.
1674
1675 2019-04-08  Tom Tromey  <tom@tromey.com>
1676
1677         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1678         Remove.
1679         (gdb_exception_error): Rename from
1680         gdb_exception_RETURN_MASK_ERROR.
1681         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1682         (gdb_quit_bad_alloc): Update.
1683         * aarch64-tdep.c: Update.
1684         * ada-lang.c: Update.
1685         * ada-typeprint.c: Update.
1686         * ada-valprint.c: Update.
1687         * amd64-tdep.c: Update.
1688         * arch-utils.c: Update.
1689         * break-catch-throw.c: Update.
1690         * breakpoint.c: Update.
1691         * btrace.c: Update.
1692         * c-varobj.c: Update.
1693         * cli/cli-cmds.c: Update.
1694         * cli/cli-interp.c: Update.
1695         * cli/cli-script.c: Update.
1696         * common/common-exceptions.c: Update.
1697         * common/new-op.c: Update.
1698         * common/selftest.c: Update.
1699         * compile/compile-c-symbols.c: Update.
1700         * compile/compile-cplus-symbols.c: Update.
1701         * compile/compile-object-load.c: Update.
1702         * compile/compile-object-run.c: Update.
1703         * completer.c: Update.
1704         * corelow.c: Update.
1705         * cp-abi.c: Update.
1706         * cp-support.c: Update.
1707         * cp-valprint.c: Update.
1708         * darwin-nat.c: Update.
1709         * disasm-selftests.c: Update.
1710         * dtrace-probe.c: Update.
1711         * dwarf-index-cache.c: Update.
1712         * dwarf-index-write.c: Update.
1713         * dwarf2-frame-tailcall.c: Update.
1714         * dwarf2-frame.c: Update.
1715         * dwarf2loc.c: Update.
1716         * dwarf2read.c: Update.
1717         * eval.c: Update.
1718         * event-loop.c: Update.
1719         * event-top.c: Update.
1720         * exec.c: Update.
1721         * f-valprint.c: Update.
1722         * fbsd-tdep.c: Update.
1723         * frame-unwind.c: Update.
1724         * frame.c: Update.
1725         * gdbtypes.c: Update.
1726         * gnu-v3-abi.c: Update.
1727         * guile/guile-internal.h: Update.
1728         * guile/scm-block.c: Update.
1729         * guile/scm-breakpoint.c: Update.
1730         * guile/scm-cmd.c: Update.
1731         * guile/scm-disasm.c: Update.
1732         * guile/scm-frame.c: Update.
1733         * guile/scm-lazy-string.c: Update.
1734         * guile/scm-math.c: Update.
1735         * guile/scm-param.c: Update.
1736         * guile/scm-ports.c: Update.
1737         * guile/scm-pretty-print.c: Update.
1738         * guile/scm-symbol.c: Update.
1739         * guile/scm-symtab.c: Update.
1740         * guile/scm-type.c: Update.
1741         * guile/scm-value.c: Update.
1742         * i386-linux-tdep.c: Update.
1743         * i386-tdep.c: Update.
1744         * inf-loop.c: Update.
1745         * infcall.c: Update.
1746         * infcmd.c: Update.
1747         * infrun.c: Update.
1748         * jit.c: Update.
1749         * language.c: Update.
1750         * linespec.c: Update.
1751         * linux-fork.c: Update.
1752         * linux-nat.c: Update.
1753         * linux-tdep.c: Update.
1754         * linux-thread-db.c: Update.
1755         * main.c: Update.
1756         * mi/mi-cmd-break.c: Update.
1757         * mi/mi-cmd-stack.c: Update.
1758         * mi/mi-interp.c: Update.
1759         * mi/mi-main.c: Update.
1760         * objc-lang.c: Update.
1761         * p-valprint.c: Update.
1762         * parse.c: Update.
1763         * ppc-linux-tdep.c: Update.
1764         * printcmd.c: Update.
1765         * python/py-arch.c: Update.
1766         * python/py-breakpoint.c: Update.
1767         * python/py-cmd.c: Update.
1768         * python/py-finishbreakpoint.c: Update.
1769         * python/py-frame.c: Update.
1770         * python/py-framefilter.c: Update.
1771         * python/py-gdb-readline.c: Update.
1772         * python/py-inferior.c: Update.
1773         * python/py-infthread.c: Update.
1774         * python/py-lazy-string.c: Update.
1775         * python/py-linetable.c: Update.
1776         * python/py-objfile.c: Update.
1777         * python/py-param.c: Update.
1778         * python/py-prettyprint.c: Update.
1779         * python/py-progspace.c: Update.
1780         * python/py-record-btrace.c: Update.
1781         * python/py-record.c: Update.
1782         * python/py-symbol.c: Update.
1783         * python/py-type.c: Update.
1784         * python/py-unwind.c: Update.
1785         * python/py-utils.c: Update.
1786         * python/py-value.c: Update.
1787         * python/python.c: Update.
1788         * record-btrace.c: Update.
1789         * record-full.c: Update.
1790         * remote-fileio.c: Update.
1791         * remote.c: Update.
1792         * riscv-tdep.c: Update.
1793         * rs6000-aix-tdep.c: Update.
1794         * rs6000-tdep.c: Update.
1795         * rust-exp.y: Update.
1796         * rust-lang.c: Update.
1797         * s390-tdep.c: Update.
1798         * selftest-arch.c: Update.
1799         * solib-dsbt.c: Update.
1800         * solib-frv.c: Update.
1801         * solib-spu.c: Update.
1802         * solib-svr4.c: Update.
1803         * solib.c: Update.
1804         * sparc64-linux-tdep.c: Update.
1805         * stack.c: Update.
1806         * symfile-mem.c: Update.
1807         * symmisc.c: Update.
1808         * target.c: Update.
1809         * thread.c: Update.
1810         * top.c: Update.
1811         * tracefile-tfile.c: Update.
1812         * tui/tui.c: Update.
1813         * typeprint.c: Update.
1814         * unittests/cli-utils-selftests.c: Update.
1815         * unittests/parse-connection-spec-selftests.c: Update.
1816         * valops.c: Update.
1817         * valprint.c: Update.
1818         * value.c: Update.
1819         * varobj.c: Update.
1820         * windows-nat.c: Update.
1821         * x86-linux-nat.c: Update.
1822         * xml-support.c: Update.
1823
1824 2019-04-08  Tom Tromey  <tom@tromey.com>
1825
1826         * xml-support.c: Use C++ exception handling.
1827         * x86-linux-nat.c: Use C++ exception handling.
1828         * windows-nat.c: Use C++ exception handling.
1829         * varobj.c: Use C++ exception handling.
1830         * value.c: Use C++ exception handling.
1831         * valprint.c: Use C++ exception handling.
1832         * valops.c: Use C++ exception handling.
1833         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1834         handling.
1835         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1836         * typeprint.c: Use C++ exception handling.
1837         * tui/tui.c: Use C++ exception handling.
1838         * tracefile-tfile.c: Use C++ exception handling.
1839         * top.c: Use C++ exception handling.
1840         * thread.c: Use C++ exception handling.
1841         * target.c: Use C++ exception handling.
1842         * symmisc.c: Use C++ exception handling.
1843         * symfile-mem.c: Use C++ exception handling.
1844         * stack.c: Use C++ exception handling.
1845         * sparc64-linux-tdep.c: Use C++ exception handling.
1846         * solib.c: Use C++ exception handling.
1847         * solib-svr4.c: Use C++ exception handling.
1848         * solib-spu.c: Use C++ exception handling.
1849         * solib-frv.c: Use C++ exception handling.
1850         * solib-dsbt.c: Use C++ exception handling.
1851         * selftest-arch.c: Use C++ exception handling.
1852         * s390-tdep.c: Use C++ exception handling.
1853         * rust-lang.c: Use C++ exception handling.
1854         * rust-exp.y: Use C++ exception handling.
1855         * rs6000-tdep.c: Use C++ exception handling.
1856         * rs6000-aix-tdep.c: Use C++ exception handling.
1857         * riscv-tdep.c: Use C++ exception handling.
1858         * remote.c: Use C++ exception handling.
1859         * remote-fileio.c: Use C++ exception handling.
1860         * record-full.c: Use C++ exception handling.
1861         * record-btrace.c: Use C++ exception handling.
1862         * python/python.c: Use C++ exception handling.
1863         * python/py-value.c: Use C++ exception handling.
1864         * python/py-utils.c: Use C++ exception handling.
1865         * python/py-unwind.c: Use C++ exception handling.
1866         * python/py-type.c: Use C++ exception handling.
1867         * python/py-symbol.c: Use C++ exception handling.
1868         * python/py-record.c: Use C++ exception handling.
1869         * python/py-record-btrace.c: Use C++ exception handling.
1870         * python/py-progspace.c: Use C++ exception handling.
1871         * python/py-prettyprint.c: Use C++ exception handling.
1872         * python/py-param.c: Use C++ exception handling.
1873         * python/py-objfile.c: Use C++ exception handling.
1874         * python/py-linetable.c: Use C++ exception handling.
1875         * python/py-lazy-string.c: Use C++ exception handling.
1876         * python/py-infthread.c: Use C++ exception handling.
1877         * python/py-inferior.c: Use C++ exception handling.
1878         * python/py-gdb-readline.c: Use C++ exception handling.
1879         * python/py-framefilter.c: Use C++ exception handling.
1880         * python/py-frame.c: Use C++ exception handling.
1881         * python/py-finishbreakpoint.c: Use C++ exception handling.
1882         * python/py-cmd.c: Use C++ exception handling.
1883         * python/py-breakpoint.c: Use C++ exception handling.
1884         * python/py-arch.c: Use C++ exception handling.
1885         * printcmd.c: Use C++ exception handling.
1886         * ppc-linux-tdep.c: Use C++ exception handling.
1887         * parse.c: Use C++ exception handling.
1888         * p-valprint.c: Use C++ exception handling.
1889         * objc-lang.c: Use C++ exception handling.
1890         * mi/mi-main.c: Use C++ exception handling.
1891         * mi/mi-interp.c: Use C++ exception handling.
1892         * mi/mi-cmd-stack.c: Use C++ exception handling.
1893         * mi/mi-cmd-break.c: Use C++ exception handling.
1894         * main.c: Use C++ exception handling.
1895         * linux-thread-db.c: Use C++ exception handling.
1896         * linux-tdep.c: Use C++ exception handling.
1897         * linux-nat.c: Use C++ exception handling.
1898         * linux-fork.c: Use C++ exception handling.
1899         * linespec.c: Use C++ exception handling.
1900         * language.c: Use C++ exception handling.
1901         * jit.c: Use C++ exception handling.
1902         * infrun.c: Use C++ exception handling.
1903         * infcmd.c: Use C++ exception handling.
1904         * infcall.c: Use C++ exception handling.
1905         * inf-loop.c: Use C++ exception handling.
1906         * i386-tdep.c: Use C++ exception handling.
1907         * i386-linux-tdep.c: Use C++ exception handling.
1908         * guile/scm-value.c: Use C++ exception handling.
1909         * guile/scm-type.c: Use C++ exception handling.
1910         * guile/scm-symtab.c: Use C++ exception handling.
1911         * guile/scm-symbol.c: Use C++ exception handling.
1912         * guile/scm-pretty-print.c: Use C++ exception handling.
1913         * guile/scm-ports.c: Use C++ exception handling.
1914         * guile/scm-param.c: Use C++ exception handling.
1915         * guile/scm-math.c: Use C++ exception handling.
1916         * guile/scm-lazy-string.c: Use C++ exception handling.
1917         * guile/scm-frame.c: Use C++ exception handling.
1918         * guile/scm-disasm.c: Use C++ exception handling.
1919         * guile/scm-cmd.c: Use C++ exception handling.
1920         * guile/scm-breakpoint.c: Use C++ exception handling.
1921         * guile/scm-block.c: Use C++ exception handling.
1922         * guile/guile-internal.h: Use C++ exception handling.
1923         * gnu-v3-abi.c: Use C++ exception handling.
1924         * gdbtypes.c: Use C++ exception handling.
1925         * frame.c: Use C++ exception handling.
1926         * frame-unwind.c: Use C++ exception handling.
1927         * fbsd-tdep.c: Use C++ exception handling.
1928         * f-valprint.c: Use C++ exception handling.
1929         * exec.c: Use C++ exception handling.
1930         * event-top.c: Use C++ exception handling.
1931         * event-loop.c: Use C++ exception handling.
1932         * eval.c: Use C++ exception handling.
1933         * dwarf2read.c: Use C++ exception handling.
1934         * dwarf2loc.c: Use C++ exception handling.
1935         * dwarf2-frame.c: Use C++ exception handling.
1936         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1937         * dwarf-index-write.c: Use C++ exception handling.
1938         * dwarf-index-cache.c: Use C++ exception handling.
1939         * dtrace-probe.c: Use C++ exception handling.
1940         * disasm-selftests.c: Use C++ exception handling.
1941         * darwin-nat.c: Use C++ exception handling.
1942         * cp-valprint.c: Use C++ exception handling.
1943         * cp-support.c: Use C++ exception handling.
1944         * cp-abi.c: Use C++ exception handling.
1945         * corelow.c: Use C++ exception handling.
1946         * completer.c: Use C++ exception handling.
1947         * compile/compile-object-run.c: Use C++ exception handling.
1948         * compile/compile-object-load.c: Use C++ exception handling.
1949         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1950         * compile/compile-c-symbols.c: Use C++ exception handling.
1951         * common/selftest.c: Use C++ exception handling.
1952         * common/new-op.c: Use C++ exception handling.
1953         * cli/cli-script.c: Use C++ exception handling.
1954         * cli/cli-interp.c: Use C++ exception handling.
1955         * cli/cli-cmds.c: Use C++ exception handling.
1956         * c-varobj.c: Use C++ exception handling.
1957         * btrace.c: Use C++ exception handling.
1958         * breakpoint.c: Use C++ exception handling.
1959         * break-catch-throw.c: Use C++ exception handling.
1960         * arch-utils.c: Use C++ exception handling.
1961         * amd64-tdep.c: Use C++ exception handling.
1962         * ada-valprint.c: Use C++ exception handling.
1963         * ada-typeprint.c: Use C++ exception handling.
1964         * ada-lang.c: Use C++ exception handling.
1965         * aarch64-tdep.c: Use C++ exception handling.
1966
1967 2019-04-08  Tom Tromey  <tom@tromey.com>
1968
1969         * xml-support.c (gdb_xml_parser::parse): Update.
1970         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1971         * value.c (show_convenience): Update.
1972         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1973         (test_parse_flags_qcs): Update.
1974         * thread.c (thr_try_catch_cmd): Update.
1975         * target.c (target_translate_tls_address): Update.
1976         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1977         (info_frame_command_core, frame_apply_command_count): Update.
1978         * rust-exp.y (rust_lex_exception_test): Update.
1979         * riscv-tdep.c (riscv_print_one_register_info): Update.
1980         * remote.c (remote_target::enable_btrace): Update.
1981         * record-btrace.c (record_btrace_enable_warn): Update.
1982         * python/py-utils.c (gdbpy_convert_exception): Update.
1983         * printcmd.c (do_one_display, print_variable_and_value): Update.
1984         * mi/mi-main.c (mi_print_exception): Update.
1985         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1986         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1987         * linux-nat.c (linux_nat_target::attach): Update.
1988         * linux-fork.c (class scoped_switch_fork_info): Update.
1989         * infrun.c (displaced_step_prepare): Update.
1990         * infcall.c (call_function_by_hand_dummy): Update.
1991         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1992         * gnu-v3-abi.c (print_one_vtable): Update.
1993         * frame.c (get_prev_frame_always): Update.
1994         * f-valprint.c (info_common_command_for_block): Update.
1995         * exec.c (try_open_exec_file): Update.
1996         * exceptions.c (print_exception, exception_print)
1997         (exception_fprintf, exception_print_same): Update.
1998         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1999         * dwarf-index-cache.c (index_cache::store)
2000         (index_cache::lookup_gdb_index): Update.
2001         * darwin-nat.c (maybe_cache_shell): Update.
2002         * cp-valprint.c (cp_print_value_fields): Update.
2003         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2004         (gcc_cplus_symbol_address): Update.
2005         * compile/compile-c-symbols.c (gcc_convert_symbol)
2006         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2007         * common/selftest.c: Update.
2008         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2009         a std::string.
2010         (exception_try_scope_entry, exception_try_scope_exit): Don't
2011         declare.
2012         (struct exception_try_scope): Remove.
2013         (TRY): Don't use exception_try_scope.
2014         (struct gdb_exception): Add constructor, operator=.
2015         <what>: New method.
2016         (struct gdb_exception_RETURN_MASK_ALL)
2017         (struct gdb_exception_RETURN_MASK_ERROR)
2018         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2019         (struct gdb_quit_bad_alloc): Update.
2020         * common/common-exceptions.c (exception_none): Change
2021         initializer.
2022         (struct catcher) <state, exception>: Initialize inline.
2023         <prev>: Remove member.
2024         (current_catcher): Remove.
2025         (catchers): New global.
2026         (exceptions_state_mc_init): Simplify.
2027         (catcher_pop): Remove.
2028         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2029         (try_scope_depth, exception_try_scope_entry)
2030         (exception_try_scope_exit): Remove.
2031         (throw_exception_sjlj): Update.
2032         (exception_messages, exception_messages_size): Remove.
2033         (throw_it): Simplify.
2034         (gdb_exception_sliced_copy): Remove.
2035         (throw_exception_cxx): Update.
2036         * cli/cli-script.c (script_from_file): Update.
2037         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2038         Update.
2039         * ada-valprint.c (ada_val_print): Update.
2040         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2041         (create_excep_cond_exprs): Update.
2042
2043 2019-04-08  Tom Tromey  <tom@tromey.com>
2044
2045         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2046         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2047         (TRY, CATCH, END_CATCH): Remove some definitions.
2048         * common/common-exceptions.c: Don't use GDB_XCPT.
2049         (catcher_list_size): Remove.
2050         (throw_exception, throw_it): Simplify.
2051
2052 2019-04-05  Tom Tromey  <tom@tromey.com>
2053
2054         Revert the header-sorting patch.
2055         * ft32-tdep.c: Revert.
2056         * frv-tdep.c: Revert.
2057         * frv-linux-tdep.c: Revert.
2058         * frame.c: Revert.
2059         * frame-unwind.c: Revert.
2060         * frame-base.c: Revert.
2061         * fork-child.c: Revert.
2062         * findvar.c: Revert.
2063         * findcmd.c: Revert.
2064         * filesystem.c: Revert.
2065         * filename-seen-cache.h: Revert.
2066         * filename-seen-cache.c: Revert.
2067         * fbsd-tdep.c: Revert.
2068         * fbsd-nat.h: Revert.
2069         * fbsd-nat.c: Revert.
2070         * f-valprint.c: Revert.
2071         * f-typeprint.c: Revert.
2072         * f-lang.c: Revert.
2073         * extension.h: Revert.
2074         * extension.c: Revert.
2075         * extension-priv.h: Revert.
2076         * expprint.c: Revert.
2077         * exec.h: Revert.
2078         * exec.c: Revert.
2079         * exceptions.c: Revert.
2080         * event-top.c: Revert.
2081         * event-loop.c: Revert.
2082         * eval.c: Revert.
2083         * elfread.c: Revert.
2084         * dwarf2read.h: Revert.
2085         * dwarf2read.c: Revert.
2086         * dwarf2loc.c: Revert.
2087         * dwarf2expr.h: Revert.
2088         * dwarf2expr.c: Revert.
2089         * dwarf2-frame.c: Revert.
2090         * dwarf2-frame-tailcall.c: Revert.
2091         * dwarf-index-write.h: Revert.
2092         * dwarf-index-write.c: Revert.
2093         * dwarf-index-common.c: Revert.
2094         * dwarf-index-cache.h: Revert.
2095         * dwarf-index-cache.c: Revert.
2096         * dummy-frame.c: Revert.
2097         * dtrace-probe.c: Revert.
2098         * disasm.h: Revert.
2099         * disasm.c: Revert.
2100         * disasm-selftests.c: Revert.
2101         * dictionary.c: Revert.
2102         * dicos-tdep.c: Revert.
2103         * demangle.c: Revert.
2104         * dcache.h: Revert.
2105         * dcache.c: Revert.
2106         * darwin-nat.h: Revert.
2107         * darwin-nat.c: Revert.
2108         * darwin-nat-info.c: Revert.
2109         * d-valprint.c: Revert.
2110         * d-namespace.c: Revert.
2111         * d-lang.c: Revert.
2112         * ctf.c: Revert.
2113         * csky-tdep.c: Revert.
2114         * csky-linux-tdep.c: Revert.
2115         * cris-tdep.c: Revert.
2116         * cris-linux-tdep.c: Revert.
2117         * cp-valprint.c: Revert.
2118         * cp-support.c: Revert.
2119         * cp-namespace.c: Revert.
2120         * cp-abi.c: Revert.
2121         * corelow.c: Revert.
2122         * corefile.c: Revert.
2123         * continuations.c: Revert.
2124         * completer.h: Revert.
2125         * completer.c: Revert.
2126         * complaints.c: Revert.
2127         * coffread.c: Revert.
2128         * coff-pe-read.c: Revert.
2129         * cli-out.h: Revert.
2130         * cli-out.c: Revert.
2131         * charset.c: Revert.
2132         * c-varobj.c: Revert.
2133         * c-valprint.c: Revert.
2134         * c-typeprint.c: Revert.
2135         * c-lang.c: Revert.
2136         * buildsym.c: Revert.
2137         * buildsym-legacy.c: Revert.
2138         * build-id.h: Revert.
2139         * build-id.c: Revert.
2140         * btrace.c: Revert.
2141         * bsd-uthread.c: Revert.
2142         * breakpoint.h: Revert.
2143         * breakpoint.c: Revert.
2144         * break-catch-throw.c: Revert.
2145         * break-catch-syscall.c: Revert.
2146         * break-catch-sig.c: Revert.
2147         * blockframe.c: Revert.
2148         * block.c: Revert.
2149         * bfin-tdep.c: Revert.
2150         * bfin-linux-tdep.c: Revert.
2151         * bfd-target.c: Revert.
2152         * bcache.c: Revert.
2153         * ax-general.c: Revert.
2154         * ax-gdb.h: Revert.
2155         * ax-gdb.c: Revert.
2156         * avr-tdep.c: Revert.
2157         * auxv.c: Revert.
2158         * auto-load.c: Revert.
2159         * arm-wince-tdep.c: Revert.
2160         * arm-tdep.c: Revert.
2161         * arm-symbian-tdep.c: Revert.
2162         * arm-pikeos-tdep.c: Revert.
2163         * arm-obsd-tdep.c: Revert.
2164         * arm-nbsd-tdep.c: Revert.
2165         * arm-nbsd-nat.c: Revert.
2166         * arm-linux-tdep.c: Revert.
2167         * arm-linux-nat.c: Revert.
2168         * arm-fbsd-tdep.c: Revert.
2169         * arm-fbsd-nat.c: Revert.
2170         * arm-bsd-tdep.c: Revert.
2171         * arch-utils.c: Revert.
2172         * arc-tdep.c: Revert.
2173         * arc-newlib-tdep.c: Revert.
2174         * annotate.h: Revert.
2175         * annotate.c: Revert.
2176         * amd64-windows-tdep.c: Revert.
2177         * amd64-windows-nat.c: Revert.
2178         * amd64-tdep.c: Revert.
2179         * amd64-sol2-tdep.c: Revert.
2180         * amd64-obsd-tdep.c: Revert.
2181         * amd64-obsd-nat.c: Revert.
2182         * amd64-nbsd-tdep.c: Revert.
2183         * amd64-nbsd-nat.c: Revert.
2184         * amd64-nat.c: Revert.
2185         * amd64-linux-tdep.c: Revert.
2186         * amd64-linux-nat.c: Revert.
2187         * amd64-fbsd-tdep.c: Revert.
2188         * amd64-fbsd-nat.c: Revert.
2189         * amd64-dicos-tdep.c: Revert.
2190         * amd64-darwin-tdep.c: Revert.
2191         * amd64-bsd-nat.c: Revert.
2192         * alpha-tdep.c: Revert.
2193         * alpha-obsd-tdep.c: Revert.
2194         * alpha-nbsd-tdep.c: Revert.
2195         * alpha-mdebug-tdep.c: Revert.
2196         * alpha-linux-tdep.c: Revert.
2197         * alpha-linux-nat.c: Revert.
2198         * alpha-bsd-tdep.c: Revert.
2199         * alpha-bsd-nat.c: Revert.
2200         * aix-thread.c: Revert.
2201         * agent.c: Revert.
2202         * addrmap.c: Revert.
2203         * ada-varobj.c: Revert.
2204         * ada-valprint.c: Revert.
2205         * ada-typeprint.c: Revert.
2206         * ada-tasks.c: Revert.
2207         * ada-lang.c: Revert.
2208         * aarch64-tdep.c: Revert.
2209         * aarch64-ravenscar-thread.c: Revert.
2210         * aarch64-newlib-tdep.c: Revert.
2211         * aarch64-linux-tdep.c: Revert.
2212         * aarch64-linux-nat.c: Revert.
2213         * aarch64-fbsd-tdep.c: Revert.
2214         * aarch64-fbsd-nat.c: Revert.
2215         * aarch32-linux-nat.c: Revert.
2216
2217 2019-04-05  Tom Tromey  <tom@tromey.com>
2218
2219         * ft32-tdep.c: Sort headers.
2220         * frv-tdep.c: Sort headers.
2221         * frv-linux-tdep.c: Sort headers.
2222         * frame.c: Sort headers.
2223         * frame-unwind.c: Sort headers.
2224         * frame-base.c: Sort headers.
2225         * fork-child.c: Sort headers.
2226         * findvar.c: Sort headers.
2227         * findcmd.c: Sort headers.
2228         * filesystem.c: Sort headers.
2229         * filename-seen-cache.h: Sort headers.
2230         * filename-seen-cache.c: Sort headers.
2231         * fbsd-tdep.c: Sort headers.
2232         * fbsd-nat.h: Sort headers.
2233         * fbsd-nat.c: Sort headers.
2234         * f-valprint.c: Sort headers.
2235         * f-typeprint.c: Sort headers.
2236         * f-lang.c: Sort headers.
2237         * extension.h: Sort headers.
2238         * extension.c: Sort headers.
2239         * extension-priv.h: Sort headers.
2240         * expprint.c: Sort headers.
2241         * exec.h: Sort headers.
2242         * exec.c: Sort headers.
2243         * exceptions.c: Sort headers.
2244         * event-top.c: Sort headers.
2245         * event-loop.c: Sort headers.
2246         * eval.c: Sort headers.
2247         * elfread.c: Sort headers.
2248         * dwarf2read.h: Sort headers.
2249         * dwarf2read.c: Sort headers.
2250         * dwarf2loc.c: Sort headers.
2251         * dwarf2expr.h: Sort headers.
2252         * dwarf2expr.c: Sort headers.
2253         * dwarf2-frame.c: Sort headers.
2254         * dwarf2-frame-tailcall.c: Sort headers.
2255         * dwarf-index-write.h: Sort headers.
2256         * dwarf-index-write.c: Sort headers.
2257         * dwarf-index-common.c: Sort headers.
2258         * dwarf-index-cache.h: Sort headers.
2259         * dwarf-index-cache.c: Sort headers.
2260         * dummy-frame.c: Sort headers.
2261         * dtrace-probe.c: Sort headers.
2262         * disasm.h: Sort headers.
2263         * disasm.c: Sort headers.
2264         * disasm-selftests.c: Sort headers.
2265         * dictionary.c: Sort headers.
2266         * dicos-tdep.c: Sort headers.
2267         * demangle.c: Sort headers.
2268         * dcache.h: Sort headers.
2269         * dcache.c: Sort headers.
2270         * darwin-nat.h: Sort headers.
2271         * darwin-nat.c: Sort headers.
2272         * darwin-nat-info.c: Sort headers.
2273         * d-valprint.c: Sort headers.
2274         * d-namespace.c: Sort headers.
2275         * d-lang.c: Sort headers.
2276         * ctf.c: Sort headers.
2277         * csky-tdep.c: Sort headers.
2278         * csky-linux-tdep.c: Sort headers.
2279         * cris-tdep.c: Sort headers.
2280         * cris-linux-tdep.c: Sort headers.
2281         * cp-valprint.c: Sort headers.
2282         * cp-support.c: Sort headers.
2283         * cp-namespace.c: Sort headers.
2284         * cp-abi.c: Sort headers.
2285         * corelow.c: Sort headers.
2286         * corefile.c: Sort headers.
2287         * continuations.c: Sort headers.
2288         * completer.h: Sort headers.
2289         * completer.c: Sort headers.
2290         * complaints.c: Sort headers.
2291         * coffread.c: Sort headers.
2292         * coff-pe-read.c: Sort headers.
2293         * cli-out.h: Sort headers.
2294         * cli-out.c: Sort headers.
2295         * charset.c: Sort headers.
2296         * c-varobj.c: Sort headers.
2297         * c-valprint.c: Sort headers.
2298         * c-typeprint.c: Sort headers.
2299         * c-lang.c: Sort headers.
2300         * buildsym.c: Sort headers.
2301         * buildsym-legacy.c: Sort headers.
2302         * build-id.h: Sort headers.
2303         * build-id.c: Sort headers.
2304         * btrace.c: Sort headers.
2305         * bsd-uthread.c: Sort headers.
2306         * breakpoint.h: Sort headers.
2307         * breakpoint.c: Sort headers.
2308         * break-catch-throw.c: Sort headers.
2309         * break-catch-syscall.c: Sort headers.
2310         * break-catch-sig.c: Sort headers.
2311         * blockframe.c: Sort headers.
2312         * block.c: Sort headers.
2313         * bfin-tdep.c: Sort headers.
2314         * bfin-linux-tdep.c: Sort headers.
2315         * bfd-target.c: Sort headers.
2316         * bcache.c: Sort headers.
2317         * ax-general.c: Sort headers.
2318         * ax-gdb.h: Sort headers.
2319         * ax-gdb.c: Sort headers.
2320         * avr-tdep.c: Sort headers.
2321         * auxv.c: Sort headers.
2322         * auto-load.c: Sort headers.
2323         * arm-wince-tdep.c: Sort headers.
2324         * arm-tdep.c: Sort headers.
2325         * arm-symbian-tdep.c: Sort headers.
2326         * arm-pikeos-tdep.c: Sort headers.
2327         * arm-obsd-tdep.c: Sort headers.
2328         * arm-nbsd-tdep.c: Sort headers.
2329         * arm-nbsd-nat.c: Sort headers.
2330         * arm-linux-tdep.c: Sort headers.
2331         * arm-linux-nat.c: Sort headers.
2332         * arm-fbsd-tdep.c: Sort headers.
2333         * arm-fbsd-nat.c: Sort headers.
2334         * arm-bsd-tdep.c: Sort headers.
2335         * arch-utils.c: Sort headers.
2336         * arc-tdep.c: Sort headers.
2337         * arc-newlib-tdep.c: Sort headers.
2338         * annotate.h: Sort headers.
2339         * annotate.c: Sort headers.
2340         * amd64-windows-tdep.c: Sort headers.
2341         * amd64-windows-nat.c: Sort headers.
2342         * amd64-tdep.c: Sort headers.
2343         * amd64-sol2-tdep.c: Sort headers.
2344         * amd64-obsd-tdep.c: Sort headers.
2345         * amd64-obsd-nat.c: Sort headers.
2346         * amd64-nbsd-tdep.c: Sort headers.
2347         * amd64-nbsd-nat.c: Sort headers.
2348         * amd64-nat.c: Sort headers.
2349         * amd64-linux-tdep.c: Sort headers.
2350         * amd64-linux-nat.c: Sort headers.
2351         * amd64-fbsd-tdep.c: Sort headers.
2352         * amd64-fbsd-nat.c: Sort headers.
2353         * amd64-dicos-tdep.c: Sort headers.
2354         * amd64-darwin-tdep.c: Sort headers.
2355         * amd64-bsd-nat.c: Sort headers.
2356         * alpha-tdep.c: Sort headers.
2357         * alpha-obsd-tdep.c: Sort headers.
2358         * alpha-nbsd-tdep.c: Sort headers.
2359         * alpha-mdebug-tdep.c: Sort headers.
2360         * alpha-linux-tdep.c: Sort headers.
2361         * alpha-linux-nat.c: Sort headers.
2362         * alpha-bsd-tdep.c: Sort headers.
2363         * alpha-bsd-nat.c: Sort headers.
2364         * aix-thread.c: Sort headers.
2365         * agent.c: Sort headers.
2366         * addrmap.c: Sort headers.
2367         * ada-varobj.c: Sort headers.
2368         * ada-valprint.c: Sort headers.
2369         * ada-typeprint.c: Sort headers.
2370         * ada-tasks.c: Sort headers.
2371         * ada-lang.c: Sort headers.
2372         * aarch64-tdep.c: Sort headers.
2373         * aarch64-ravenscar-thread.c: Sort headers.
2374         * aarch64-newlib-tdep.c: Sort headers.
2375         * aarch64-linux-tdep.c: Sort headers.
2376         * aarch64-linux-nat.c: Sort headers.
2377         * aarch64-fbsd-tdep.c: Sort headers.
2378         * aarch64-fbsd-nat.c: Sort headers.
2379         * aarch32-linux-nat.c: Sort headers.
2380
2381 2019-04-04  Tom Tromey  <tom@tromey.com>
2382
2383         * varobj.c (varobj_create): Update.
2384         * rust-exp.y (struct rust_parser) <update_innermost_block,
2385         lookup_symbol>: New methods.
2386         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2387         Rename.
2388         (rust_parser::rust_lookup_type)
2389         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2390         * printcmd.c (display_command, do_one_display): Update.
2391         * parser-defs.h (struct parser_state) <parser_state>: Add
2392         "tracker" parameter.
2393         (block_tracker): New member.
2394         (class innermost_block_tracker) <innermost_block_tracker>: Add
2395         "types" parameter.
2396         <reset>: Remove method.
2397         (innermost_block): Don't declare.
2398         (null_post_parser): Update.
2399         * parse.c (innermost_block): Remove global.
2400         (write_dollar_variable): Update.
2401         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2402         Remove "tracker_types" parameter.
2403         (parse_expression): Add "tracker" parameter.
2404         (parse_expression_for_completion): Update.
2405         (null_post_parser): Add "tracker" parameter.
2406         * p-exp.y: Update rules.
2407         * m2-exp.y: Update rules.
2408         * language.h (struct language_defn) <la_post_parser>: Add
2409         "tracker" parameter.
2410         * go-exp.y: Update rules.
2411         * f-exp.y: Update rules.
2412         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2413         parameter.
2414         * d-exp.y: Update rules.
2415         * c-exp.y: Update rules.
2416         * breakpoint.c (set_breakpoint_condition): Create an
2417         innermost_block_tracker.
2418         (watch_command_1): Likewise.
2419         * ada-lang.c (resolve): Add "tracker" parameter.
2420         (resolve_subexp): Likewise.
2421         * ada-exp.y (write_var_from_sym): Update.
2422
2423 2019-04-04  Tom Tromey  <tom@tromey.com>
2424
2425         * type-stack.h: New file.
2426         * type-stack.c: New file.
2427         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2428         type-stack.h.
2429         (insert_into_type_stack, insert_type, push_type, push_type_int)
2430         (insert_type_address_space, pop_type, pop_type_int)
2431         (pop_typelist, pop_type_stack, append_type_stack)
2432         (push_type_stack, get_type_stack, push_typelist)
2433         (follow_type_instance_flags, follow_types): Don't declare.
2434         * parse.c (type_stack): Remove global.
2435         (parse_exp_in_context): Update.
2436         (insert_into_type_stack, insert_type, push_type, push_type_int)
2437         (insert_type_address_space, pop_type, pop_type_int)
2438         (pop_typelist, pop_type_stack, append_type_stack)
2439         (push_type_stack, get_type_stack, push_typelist)
2440         (follow_type_instance_flags, follow_types): Remove (moved to
2441         type-stack.c).
2442         * f-exp.y (type_stack): New global.
2443         Update rules.
2444         (push_kind_type, f_parse): Update.
2445         * d-exp.y (type_stack): New global.
2446         Update rules.
2447         (d_parse): Update.
2448         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2449         Update rules.
2450         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2451         (HFILES_NO_SRCDIR): Add type-stack.h.
2452
2453 2019-04-04  Tom Tromey  <tom@tromey.com>
2454
2455         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2456         (rust_parser::convert_ast_to_expression, rust_parse)
2457         (rust_lex_test_completion, rust_lex_tests): Update.
2458         * parser-defs.h (struct expr_completion_state): New.
2459         (struct parser_state) <parser_state>: Add completion parameter.
2460         <mark_struct_expression, mark_completion_tag>: New methods.
2461         <parse_completion, m_completion_state>: New members.
2462         (prefixify_expression, null_post_parser): Update.
2463         (mark_struct_expression, mark_completion_tag): Don't declare.
2464         * parse.c (parse_completion, expout_last_struct)
2465         (expout_tag_completion_type, expout_completion_name): Remove
2466         globals.
2467         (parser_state::mark_struct_expression)
2468         (parser_state::mark_completion_tag): Now methods.
2469         (prefixify_expression): Add last_struct parameter.
2470         (prefixify_subexp): Likewise.
2471         (parse_exp_1): Update.
2472         (parse_exp_in_context): Add cstate parameter.  Update.
2473         (parse_expression_for_completion): Create an
2474         expr_completion_state.
2475         (null_post_parser): Add "completion" parameter.
2476         * p-exp.y: Update rules.
2477         (yylex): Update.
2478         * language.h (struct language_defn) <la_post_parser>: Add
2479         "completing" parameter.
2480         * go-exp.y: Update rules.
2481         (lex_one_token): Update.
2482         * expression.h (parse_completion): Don't declare.
2483         * d-exp.y: Update rules.
2484         (lex_one_token): Update rules.
2485         * c-exp.y: Update rules.
2486         (lex_one_token): Update.
2487         * ada-lang.c (resolve): Add "parse_completion" parameter.
2488         (resolve_subexp): Likewise.
2489         (ada_resolve_function): Likewise.
2490
2491 2019-04-04  Tom Tromey  <tom@tromey.com>
2492
2493         * parser-defs.h (struct parser_state) <start_arglist,
2494         end_arglist>: New methods.
2495         <arglist_len, m_funcall_chain>: New members.
2496         (arglist_len, start_arglist, end_arglist): Don't declare.
2497         * parse.c (arglist_len, funcall_chain): Remove global.
2498         (start_arglist, end_arglist): Remove functions.
2499         (parse_exp_in_context): Update.
2500         * p-exp.y: Update rules.
2501         * m2-exp.y: Update rules.
2502         * go-exp.y: Update rules.
2503         * f-exp.y: Update rules.
2504         * d-exp.y: Update rules.
2505         * c-exp.y: Update rules.
2506
2507 2019-04-04  Tom Tromey  <tom@tromey.com>
2508
2509         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2510         lex_operator, push_back>: New methods.
2511         Update all rules.
2512         (rust_parser::lex_hex, lex_escape): Rename and update.
2513         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2514         (rust_parser::lex_operator): Rename and update.
2515         (rust_parser::lex_number, rustyylex, rustyyerror)
2516         (rust_lex_test_init, rust_lex_test_sequence)
2517         (rust_lex_test_push_back, rust_lex_tests): Update.
2518         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2519         parameter.
2520         <lexptr, prev_lexptr>: New members.
2521         (lexptr, prev_lexptr): Don't declare.
2522         * parse.c (lexptr, prev_lexptr): Remove globals.
2523         (parse_exp_in_context): Update.
2524         * p-exp.y (yylex, yyerror): Update.
2525         * m2-exp.y (parse_number, yylex, yyerror): Update.
2526         * go-exp.y (lex_one_token, yyerror): Update.
2527         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2528         * d-exp.y (lex_one_token, yyerror): Update.
2529         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2530         (lex_one_token, yyerror): Update.
2531         * ada-lex.l (YY_INPUT): Update.
2532         (rewind_to_char): Update.
2533         * ada-exp.y (yyerror): Update.
2534
2535 2019-04-04  Tom Tromey  <tom@tromey.com>
2536
2537         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2538         * parser-defs.h (struct parser_state) <parser_state>: Add new
2539         parameter.
2540         <comma_terminates>: New member.
2541         (comma_terminates): Don't declare global.
2542         * parse.c (comma_terminates): Remove global.
2543         (parse_exp_in_context): Update.
2544         * p-exp.y (yylex): Update.
2545         * m2-exp.y (yylex): Update.
2546         * go-exp.y (lex_one_token): Update.
2547         * f-exp.y (yylex): Update.
2548         * d-exp.y (lex_one_token): Update.
2549         * c-exp.y (lex_one_token): Update.
2550         * ada-lex.l: Update.
2551
2552 2019-04-04  Tom Tromey  <tom@tromey.com>
2553
2554         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2555         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2556         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2557         * parser-defs.h (paren_depth): Don't declare.
2558         * parse.c (paren_depth): Remove global.
2559         (parse_exp_in_context): Update.
2560         * p-exp.y (paren_depth): New global.
2561         (pascal_parse): Initialize it.
2562         * m2-exp.y (paren_depth): New global.
2563         (m2_parse): Initialize it.
2564         * go-exp.y (paren_depth): New global.
2565         (go_parse): Initialize it.
2566         * f-exp.y (paren_depth): New global.
2567         (f_parse): Initialize it.
2568         * d-exp.y (paren_depth): New global.
2569         (d_parse): Initialize it.
2570         * c-exp.y (paren_depth): New global.
2571         (c_parse): Initialize it.
2572         * ada-lex.l (paren_depth): New global.
2573         (lexer_init): Initialize it.
2574
2575 2019-04-04  Tom Tromey  <tom@tromey.com>
2576
2577         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2578         (rust_parser::convert_ast_to_type)
2579         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2580         * parser-defs.h (struct parser_state) <parser_state>: Add
2581         parameters.  Initialize new members.
2582         <expression_context_block, expression_context_pc>: New members.
2583         * parse.c (expression_context_block, expression_context_pc):
2584         Remove globals.
2585         (parse_exp_in_context): Update.
2586         * p-exp.y: Update all rules.
2587         (yylex): Update.
2588         * m2-exp.y: Update all rules.
2589         (yylex): Update.
2590         * go-exp.y (yylex): Update.
2591         * f-exp.y (yylex): Update.
2592         * d-exp.y: Update all rules.
2593         (yylex): Update.
2594         * c-exp.y: Update all rules.
2595         (lex_one_token, classify_name, yylex, c_parse): Update.
2596         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2597
2598 2019-04-04  Tom Tromey  <tom@tromey.com>
2599
2600         * gdbarch.h, gdbarch.c: Rebuild.
2601         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2602         * stap-probe.h:
2603         (struct stap_parse_info): Replace "parser_state" with
2604         "expr_builder".
2605         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2606         (parser_state): New class.
2607         * parse.c (expr_builder): Rename.
2608         (expr_builder::release): Rename.
2609         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2610         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2611         (write_exp_elt_longcst, write_exp_elt_floatcst)
2612         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2613         (write_exp_string_vector, write_exp_bitstring)
2614         (write_exp_msymbol, mark_struct_expression)
2615         (write_dollar_variable)
2616         (insert_type_address_space, increase_expout_size): Replace
2617         "parser_state" with "expr_builder".
2618         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2619         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2620         "parser_state" with "expr_builder".
2621
2622 2019-04-04  Tom Tromey  <tom@tromey.com>
2623
2624         * rust-exp.y: Replace "parse_language" with method call.
2625         * p-exp.y:
2626         (yylex): Replace "parse_language" with method call.
2627         * m2-exp.y:
2628         (yylex): Replace "parse_language" with method call.
2629         * go-exp.y (classify_name): Replace "parse_language" with method
2630         call.
2631         * f-exp.y (yylex): Replace "parse_language" with method call.
2632         * d-exp.y (lex_one_token): Replace "parse_language" with method
2633         call.
2634         * c-exp.y:
2635         (lex_one_token, classify_name, yylex): Replace "parse_language"
2636         with method call.
2637         * ada-exp.y (find_primitive_type, type_char)
2638         (type_system_address): Replace "parse_language" with method call.
2639
2640 2019-04-04  Tom Tromey  <tom@tromey.com>
2641
2642         * rust-exp.y: Replace "parse_gdbarch" with method call.
2643         * parse.c (write_dollar_variable, insert_type_address_space):
2644         Replace "parse_gdbarch" with method call.
2645         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2646         call.
2647         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2648         call.
2649         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2650         "parse_gdbarch" with method call.
2651         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2652         with method call.
2653         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2654         "parse_gdbarch" with method call.
2655         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2656         "parse_gdbarch" with method call.
2657         * c-exp.y (parse_type, parse_number, classify_name): Replace
2658         "parse_gdbarch" with method call.
2659         * ada-lex.l: Replace "parse_gdbarch" with method call.
2660         * ada-exp.y (parse_type, find_primitive_type, type_char)
2661         (type_system_address): Replace "parse_gdbarch" with method call.
2662
2663 2019-04-04  Tom Tromey  <tom@tromey.com>
2664
2665         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2666         * stap-probe.c (stap_parse_argument): Update.
2667         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2668         initial_size parameter.
2669         * rust-exp.y (rust_lex_tests): Update.
2670         * parse.c (parser_state): Update.
2671         (parse_exp_in_context): Update.
2672         * parser-defs.h (struct parser_state) <parser_state>: Remove
2673         "initial_size" parameter.
2674
2675 2019-04-04  Tom Tromey  <tom@tromey.com>
2676
2677         * parser-defs.h (increase_expout_size): Don't declare.
2678         * parse.c (increase_expout_size): Now static.
2679
2680 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2681
2682         * gnu-nat.c (gnu_nat_target::wait): Fix
2683         target_waitstatus_to_string call.
2684
2685 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * eval.c (evaluate_subexp_standard): Handle internal functions
2688         during Fortran function call handling.
2689
2690 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2691
2692         * NEWS: Mention new internal functions.
2693         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2694         (read_base_type): Use dwarf2_init_complex_target_type.
2695         * value.c (creal_internal_fn): New function.
2696         (cimag_internal_fn): New function.
2697         (_initialize_values): Register new internal functions.
2698
2699 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2700
2701         * infrun.c (stop_all_threads): If debug_infrun, always
2702         trace the wait status after wait_one, using
2703         target_waitstatus_to_string and target_pid_to_str.
2704         (handle_inferior_event): Replace various trace of
2705         wait status kind by a single trace.
2706         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2707         wait status kind image by target_waitstatus_to_string.
2708         * target/waitstatus.c (target_waitstatus_to_string): Fix
2709         obsolete comment.
2710
2711 2019-04-01  Tom Tromey  <tromey@adacore.com>
2712
2713         PR symtab/23331:
2714         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2715
2716 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2717             Pedro Alves  <palves@redhat.com>
2718
2719         * top.c (quit_force): Call 'finalize_values'.
2720         * value.c (finalize_values): New function.
2721         * value.h (finalize_values): Declare.
2722
2723 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2724
2725         * NEWS: Announce $_gdb_major and $_gdb_minor.
2726
2727         * top.c (init_gdb_version_vars): New function.
2728         (gdb_init): Call init_gdb_version_vars.
2729
2730 2019-03-29  Tom Tromey  <tromey@adacore.com>
2731
2732         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2733         help text.  Remove dead code.
2734
2735 2019-03-29  Keith Seitz  <keiths@redhat.com>
2736
2737         From Siddhesh Poyarekar:
2738         * f-lang.h (f77_get_upperbound): Return LONGEST.
2739         (f77_get_lowerbound): Likewise.
2740         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2741         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2742         print them.
2743         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2744         plongest to format print it.
2745         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2746         (f77_get_upperbound): Likewise.
2747         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2748         LOWER_BOUND to LONGEST.
2749         (f77_create_arrayprint_offset_tbl): Likewise.
2750
2751 2019-03-29  Keith Seitz  <keiths@redhat.com>
2752
2753         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2754         %s/pulongest for TYPE_LENGTH instead of %d in format
2755         strings.
2756         * ada-typerint.c (ada_print_type): Likewise.
2757         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2758         * compile/compile-c-support.c (generate_register_struct): Likewise.
2759         * gdbtypes.c (recursive_dump_type): Likewise.
2760         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2761         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2762         instead of %d in format strings.
2763         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2764         to std::min to ULONGEST.
2765         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2766         instead of %d in format strings.
2767         * tracepoint.c (info_scope_command): Likewise.
2768         * typeprint.c (print_offset_data::update)
2769         (print_offset_data::finish): Likewise.
2770         * xtensa-tdep.c (xtensa_store_return_value)
2771         (xtensa_push_dummy_call): Likewise.
2772
2773 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2774
2775         * windows-nat.c (display_selector): Fixed format specifications
2776         for 64-bit Cygwin.
2777
2778 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2779
2780         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2781
2782 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2783
2784         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2785         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2786         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2787         (nios2_linux_init_abi): Install it.
2788
2789 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2790
2791         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2792
2793 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2794
2795         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2796
2797 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2798             Tom Tromey  <tromey@adacore.com>
2799
2800         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2801
2802 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2803
2804         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2805         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2806         method to compute the bounds of range types. Also print "[evaluated]"
2807         if the bounds' values come from a dynamic evaluation.
2808
2809 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2812         whitespace when pretty printing is on.
2813
2814 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2815
2816         * ppc-linux-nat.c: Add include.
2817
2818 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2819
2820         * NEWS: Mention AArch64 Pointer Authentication.
2821
2822 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2823
2824         * arm-linux-nat.c: Add include.
2825
2826 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2827
2828         * source-cache.c (source_cache::get_source_lines): Re-read
2829         fullname after calling open_source_file.
2830
2831 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2832
2833         * NEWS: Mention TLS support for FreeBSD.
2834
2835 2019-03-25  Tom Tromey  <tromey@adacore.com>
2836
2837         * minsyms.c (BUNCH_SIZE): Update comment.
2838         (~minimal_symbol_reader): Remove old comment.
2839         (compact_minimal_symbols): Update comment.
2840         (minimal_symbol_reader::install): Remove old comment.  Update
2841         other comments.
2842
2843 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2844
2845         * s390-linux-nat.c: Add include.
2846
2847 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2850         Call linux_get_hwcap.
2851         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2852         Likewise.
2853         (aarch64_linux_get_hwcap): Remove function.
2854         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2855         declaration.
2856         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2857         linux_get_hwcap.
2858         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2859         * linux-tdep.c (linux_get_hwcap): Add function.
2860         (linux_get_hwcap2): Likewise.
2861         * linux-tdep.h (linux_get_hwcap): Add declaration.
2862         (linux_get_hwcap2): Likewise.
2863         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2864         (ppc_linux_get_hwcap2): Likewise.
2865         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2866         linux_get_hwcap.
2867         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2868         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2869         (ppc_linux_nat_target::read_description): Likewise.
2870         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2871         * s390-linux-nat.c: Likewise.
2872         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2873
2874 2019-03-24  Tom Tromey  <tom@tromey.com>
2875
2876         * ada-lang.c (standard_lookup): Simplify initialization.
2877         (ada_lookup_symbol_nonlocal): Simplify return.
2878         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2879         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2880         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2881         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2882         initialization.
2883         * solib.c (solib_global_lookup): Simplify.
2884         * symtab.c (null_block_symbol): Remove.
2885         (symbol_cache_lookup): Simplify returns.
2886         (lookup_language_this): Simplify returns.
2887         (lookup_symbol_aux): Simplify return.
2888         (lookup_local_symbol): Simplify returns.
2889         (lookup_global_symbol_from_objfile): Simplify return.
2890         (lookup_symbol_in_objfile_symtabs)
2891         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2892         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2893         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2894         * cp-namespace.c (cp_lookup_bare_symbol)
2895         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2896         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2897         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2898         (cp_lookup_symbol_via_imports): Simplify initialization.
2899         (find_symbol_in_baseclass): Likewise.
2900         * symtab.h (null_block_symbol): Remove.
2901         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2902         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2903         (d_lookup_symbol_module): Likewise.
2904         (find_symbol_in_baseclass): Simplify initialization.
2905
2906 2019-03-24  Tom Tromey  <tom@tromey.com>
2907
2908         * expression.h: Don't include symtab.h.
2909         (struct block): Forward declare.
2910
2911 2019-03-24  Tom Tromey  <tom@tromey.com>
2912
2913         * c-exp.y (typebase): Remove casts.
2914         * gdbtypes.c (lookup_unsigned_typename, )
2915         (lookup_signed_typename): Remove cast.
2916         * eval.c (parse_to_comma_and_eval): Remove cast.
2917         * parse.c (write_dollar_variable): Remove cast.
2918         * block.h (struct block) <superblock>: Now const.
2919         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2920         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2921         (map_block): Make "block" const.
2922         * symfile.h (struct quick_symbol_functions)
2923         <map_matching_symbols>: Constify block argument to "callback".
2924         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2925         const.
2926         (find_pc_sect_compunit_symtab): Make "b" const.
2927         (find_symbol_at_address): Likewise.
2928         (search_symbols): Likewise.
2929         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2930         (dw2_debug_names_lookup_symbol): Likewise.
2931         (dw2_map_matching_symbols): Update.
2932         * p-valprint.c (pascal_val_print): Remove "block".
2933         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2934         (aux_add_nonlocal_symbols): Make "block" const.
2935         (resolve_subexp): Remove cast.
2936         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2937         const.
2938         (iterate_over_file_blocks): Likewise.
2939         * f-exp.y (%union) <bval>: Remove.
2940         * coffread.c (patch_opaque_types): Make "b" const.
2941         * spu-tdep.c (spu_catch_start): Make "block" const.
2942         * c-valprint.c (print_unpacked_pointer): Remove "block".
2943         * symmisc.c (dump_symtab_1): Make "b" const.
2944         (block_depth): Make "block" const.
2945         * d-exp.y (%union) <bval>: Remove.
2946         * cp-support.h (cp_lookup_rtti_type): Update.
2947         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2948         * psymtab.c (psym_lookup_symbol): Make "block" const.
2949         (maintenance_check_psymtabs): Make "b" const.
2950         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2951         (enumerate_locals, enumerate_args): Update.
2952         * python/py-symtab.c (stpy_global_block): Make "block" const.
2953         (stpy_static_block): Likewise.
2954         * inline-frame.c (block_starting_point_at): Make "new_block"
2955         const.
2956         * block.c (find_block_in_blockvector): Make return type const.
2957         (blockvector_for_pc_sect): Make "b" const.
2958         (find_block_in_blockvector): Make "b" const.
2959
2960 2019-03-23  Tom Tromey  <tom@tromey.com>
2961
2962         * varobj.c (varobj_create): Update.
2963         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2964         * printcmd.c (display_command, do_one_display): Don't reset
2965         innermost_block.
2966         * parser-defs.h (enum innermost_block_tracker_type): Move to
2967         expression.h.
2968         (innermost_block): Update comment.
2969         * parse.c (parse_exp_1): Add tracker_types parameter.
2970         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2971         tracker_types parameter.  Reset innermost_block.
2972         (parse_exp_in_context): Remove.
2973         (parse_expression_for_completion): Update.
2974         * objfiles.c (~objfile): Don't reset expression_context_block or
2975         innermost_block.
2976         * expression.h (enum innermost_block_tracker_type): Move from
2977         parser-defs.h.
2978         (parse_exp_1): Add tracker_types parameter.
2979         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2980         reset innermost_block.
2981
2982 2019-03-23  Tom Tromey  <tom@tromey.com>
2983
2984         * objfiles.h: Include bcache.h.
2985
2986 2019-03-23  Tom Tromey  <tom@tromey.com>
2987
2988         * linespec.c (get_current_search_block): Use
2989         scoped_restore_current_language.
2990         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2991
2992 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2993             Jiong Wang  <jiong.wang@arm.com>
2994
2995         * aarch64-linux-tdep.c
2996         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2997         section.
2998         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2999
3000 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3001             Jiong Wang  <jiong.wang@arm.com>
3002
3003         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3004         instructions.
3005         (aarch64_analyze_prologue_test): Add PACIASP test.
3006         (aarch64_prologue_prev_register): Unmask PC value.
3007
3008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3009             Jiong Wang  <jiong.wang@arm.com>
3010
3011         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3012         (aarch64_dwarf2_prev_register): Unmask PC value.
3013         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3014         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3015         DW_CFA_AARCH64_negate_ra_state.
3016         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3017
3018 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3019             Jiong Wang  <jiong.wang@arm.com>
3020
3021         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3022         registers.
3023         (aarch64_pseudo_register_name): Likewise.
3024         (aarch64_pseudo_register_type): Likewise.
3025         (aarch64_pseudo_register_reggroup_p): Likewise.
3026         (aarch64_gdbarch_init): Add pauth registers.
3027         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3028         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3029         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3030         (struct gdbarch_tdep): Add regnum for ra_state.
3031
3032 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3033             Jiong Wang  <jiong.wang@arm.com>
3034
3035         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3036
3037 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3038             Jiong Wang  <jiong.wang@arm.com>
3039
3040         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3041         function.
3042         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3043         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3044         (aarch64_gdbarch_init): Add puth registers.
3045         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3046         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3047         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3048
3049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3050             Jiong Wang  <jiong.wang@arm.com>
3051
3052         * aarch64-linux-nat.c
3053         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3054         * aarch64-linux-tdep.c
3055         (aarch64_linux_core_read_description): Likewise.
3056         (aarch64_linux_get_hwcap): New function.
3057         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3058         (aarch64_linux_get_hwcap): New declaration.
3059
3060 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3061             Jiong Wang  <jiong.wang@arm.com>
3062
3063         * aarch64-linux-nat.c
3064         (aarch64_linux_nat_target::read_description): Add pauth param.
3065         * aarch64-linux-tdep.c
3066         (aarch64_linux_core_read_description): Likewise.
3067         * aarch64-tdep.c (struct target_desc): Add in pauth.
3068         (aarch64_read_description): Add pauth param.
3069         (aarch64_gdbarch_init): Likewise.
3070         * aarch64-tdep.h (aarch64_read_description): Likewise.
3071         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3072         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3073         * features/Makefile: Add new files.
3074         * features/aarch64-pauth.c: New file.
3075         * features/aarch64-pauth.xml: New file.
3076
3077 2019-03-20  Tom Tromey  <tromey@adacore.com>
3078
3079         * infrun.c (handle_inferior_event): Rename from
3080         handle_inferior_event_1.  Create a scoped_value_mark.
3081         (handle_inferior_event): Remove.
3082
3083 2019-03-19  Tom Tromey  <tromey@adacore.com>
3084
3085         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3086         * infrun.h (print_stop_event): Add "displays" parameter.
3087         * infrun.c (print_stop_event): Add "displays" parameter.
3088
3089 2019-03-19  Pedro Alves  <palves@redhat.com>
3090
3091         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3092         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3093         to -1.  Fix TABs vs spaces.
3094         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3095         * tui/tui-out.h (tui_ui_out) Add intro comments.
3096         <m_line, m_start_of_line>: In-class initialize, and add describing
3097         comment.
3098
3099 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3100
3101         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3102         variable names.
3103         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3104
3105 2019-03-18  Pedro Alves  <palves@redhat.com>
3106             Eli Zaretskii <eliz@gnu.org>
3107
3108         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3109         m_line and m_start_of_line.
3110
3111 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3112
3113         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3114         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3115         it returns a newline.  This fixes a regression in TU mode, whereby
3116         the next line is output on the same screen line as the user input.
3117
3118 2019-03-18  Tom Tromey  <tromey@adacore.com>
3119
3120         * minsyms.c (minimal_symbol_reader::install): Remove call to
3121         obstack_blank.
3122
3123 2019-03-18  Pedro Alves  <palves@redhat.com>
3124
3125         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3126         New globals.
3127         (apply_style): New, factored out from ...
3128         (apply_ansi_escape): ... this.  Handle reverse video mode.
3129         (tui_set_reverse_mode): New function.
3130         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3131         * tui/tui-winsource.c (tui_show_source_line): Use
3132         tui_set_reverse_mode instead of setting A_STANDOUT.
3133         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3134         New setter methods.
3135
3136 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3137
3138         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3139         Handle tabs.
3140
3141 2019-03-18  Tom Tromey  <tromey@adacore.com>
3142
3143         * ada-lang.c (empty_array): Add "high" parameter.
3144         (ada_evaluate_subexp): Update.
3145
3146 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3147
3148         * unittests/string_view-selftests.c: Define
3149         _initialize_string_view_selftests unconditionally.
3150
3151 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3152
3153         PR gdb/24350
3154         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3155
3156 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3157
3158         PR gdb/24351
3159         * windows-nat.c (display_selector): Fix format specifiers.
3160
3161 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3162
3163         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3164         tui_refill_source_window instead of tui_refresh_win, to update the
3165         current execution line.  This fixes redisplay of the current line
3166         when stepping through the code with "next" or "step".
3167
3168 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3169
3170         * source-cache.c (source_cache::get_source_lines): Call
3171         find_source_lines to initialize s->nlines.  This fixes vertical
3172         scrolling of TUI source window when the DOWN arrow is pressed.
3173
3174 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3175
3176         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3177         linux-thread-db.c (_initialize_thread_db): Likewise.
3178
3179 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3180
3181         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3182         wclrtoeol in tui_show_source_line".  This reverts changes made in
3183         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3184
3185 2019-03-15  Tom Tromey  <tom@tromey.com>
3186
3187         * symtab.h (struct minimal_symbol): Derive from
3188         general_symbol_info.
3189         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3190         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3191         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3192         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3193         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3194         (MSYMBOL_SEARCH_NAME): Update.
3195         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3196         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3197         * minsyms.c (minimal_symbol_reader::record_full): Update.
3198
3199 2019-03-15  Tom Tromey  <tom@tromey.com>
3200
3201         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3202
3203 2019-03-15  Tom Tromey  <tom@tromey.com>
3204
3205         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3206         unique_xmalloc_ptr.
3207         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3208         Update.
3209         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3210         (build_minimal_symbol_hash_tables)
3211         (minimal_symbol_reader::install): Update.
3212
3213 2019-03-15  Tom Tromey  <tom@tromey.com>
3214
3215         * symtab.c (create_demangled_names_hash): Update.
3216         (symbol_set_names): Update.
3217         * objfiles.h (struct objfile_per_bfd_storage)
3218         <demangled_names_hash>: Now an htab_up.
3219         * objfiles.c (objfile_per_bfd_storage): Simplify.
3220
3221 2019-03-15  Tom Tromey  <tom@tromey.com>
3222
3223         * objfiles.h (struct objfile_per_bfd_storage): Declare
3224         destructor.
3225         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3226         New.
3227         (get_objfile_bfd_data): Use new.  Don't initialize
3228         language_of_main.
3229         (free_objfile_per_bfd_storage): Remove.
3230         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3231
3232 2019-03-15  Tom Tromey  <tom@tromey.com>
3233
3234         * symfile.c (reread_symbols): Update.
3235         * objfiles.c (objfile::objfile): Update.
3236         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3237         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3238         comment.
3239         (minimal_symbol_reader::install): Update.
3240         (terminate_minimal_symbol_table): Remove.
3241         * jit.c (jit_object_close_impl): Update.
3242
3243 2019-03-15  Tom Tromey  <tom@tromey.com>
3244
3245         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3246         initializations.
3247
3248 2019-03-15  Tom Tromey  <tom@tromey.com>
3249
3250         * objfiles.h (struct objfile_per_bfd_storage)
3251         <demangled_hash_languages>: Now a bitset.
3252         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3253         (lookup_minimal_symbol): Update.
3254
3255 2019-03-15  Tom Tromey  <tom@tromey.com>
3256
3257         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3258         Don't return the symbol.
3259         * coffread.c (record_minimal_symbol): Use record_full.
3260
3261 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3262
3263         The MS-Windows port of ncurses fails to switch to a color pair if
3264         one or both of the colors are the implicit default colors.  This
3265         change records the default colors when TUI is initialized, and
3266         then specifies them explicitly when a color pair uses the default
3267         colors.  This allows color styling in TUI mode on MS-Windows.
3268
3269         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3270         ncurses_norm_attr.
3271         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3272         colors in ncurses_norm_attr.
3273         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3274         "none", replace it with the default color recorded in
3275         ncurses_norm_attr.
3276
3277 2019-03-14  Tom Tromey  <tromey@adacore.com>
3278
3279         * source-cache.h (class source_cache) <get_source_lines>: Return
3280         std::string.
3281         * source-cache.c (source_cache::extract_lines): Handle case where
3282         first_pos==npos.  Return std::string.
3283         (source_cache::get_source_lines): Update.
3284
3285 2019-03-14  Tom Tromey  <tromey@adacore.com>
3286
3287         * NEWS: Add item for "style sources" commands.
3288         * source-cache.c (source_cache::get_source_lines): Check
3289         source_styling.
3290         * cli/cli-style.c (source_styling): New global.
3291         (_initialize_cli_style): Add "style sources" commands.
3292         (show_style_sources): New function.
3293         * cli/cli-style.h (source_styling): Declare.
3294
3295 2019-03-14  Pedro Alves  <palves@redhat.com>
3296             Tom Tromey  <tromey@adacore.com>
3297
3298         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3299         * tui/tui-winsource.c (tui_refill_source_window): New function,
3300         from...
3301         (tui_horizontal_source_scroll): ... here.  Move some logic.
3302         * cli/cli-style.c (set_style_enabled): Notify new observable.
3303         * tui/tui-hooks.c (tui_redisplay_source): New function.
3304         (tui_attach_detach_observers): Attach or detach
3305         tui_redisplay_source.
3306         * observable.h (source_styling_changed): New observable.
3307         * observable.c: Define source_styling_changed observable.
3308
3309 2019-03-13  Tom Tromey  <tromey@adacore.com>
3310
3311         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3312         (i386_gnu_nat_target::store_registers): Update.
3313         * target-debug.h (target_debug_print_std_string): New macro.
3314         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3315         * windows-tdep.c (display_one_tib): Update.
3316         * tui/tui-stack.c (tui_make_status_line): Update.
3317         * top.c (print_inferior_quit_action): Update.
3318         * thread.c (thr_try_catch_cmd): Update.
3319         (add_thread_with_info): Update.
3320         (thread_target_id_str): Update.
3321         (thr_try_catch_cmd): Update.
3322         (thread_command): Update.
3323         (thread_find_command): Update.
3324         * record-btrace.c (record_btrace_target::info_record)
3325         (record_btrace_resume_thread, record_btrace_target::resume)
3326         (record_btrace_cancel_resume, record_btrace_step_thread)
3327         (record_btrace_target::wait, record_btrace_target::wait)
3328         (record_btrace_target::wait, record_btrace_target::stop): Update.
3329         * progspace.c (print_program_space): Update.
3330         * process-stratum-target.c
3331         (process_stratum_target::thread_address_space): Update.
3332         * linux-fork.c (linux_fork_mourn_inferior)
3333         (detach_checkpoint_command, info_checkpoints_command)
3334         (linux_fork_context): Update.
3335         (linux_fork_detach): Update.
3336         (class scoped_switch_fork_info): Update.
3337         (delete_checkpoint_command): Update.
3338         * infrun.c (follow_fork_inferior): Update.
3339         (follow_fork_inferior): Update.
3340         (proceed_after_vfork_done): Update.
3341         (handle_vfork_child_exec_or_exit): Update.
3342         (follow_exec): Update.
3343         (displaced_step_prepare_throw): Update.
3344         (displaced_step_restore): Update.
3345         (start_step_over): Update.
3346         (resume_1): Update.
3347         (clear_proceed_status_thread): Update.
3348         (proceed): Update.
3349         (print_target_wait_results): Update.
3350         (do_target_wait): Update.
3351         (context_switch): Update.
3352         (stop_all_threads): Update.
3353         (restart_threads): Update.
3354         (finish_step_over): Update.
3355         (handle_signal_stop): Update.
3356         (switch_back_to_stepped_thread): Update.
3357         (keep_going_pass_signal): Update.
3358         (print_exited_reason): Update.
3359         (normal_stop): Update.
3360         * inferior.c (inferior_pid_to_str): Change return type.
3361         (print_selected_inferior): Update.
3362         (add_inferior): Update.
3363         (detach_inferior): Update.
3364         * dummy-frame.c (fprint_dummy_frames): Update.
3365         * dcache.c (dcache_info_1): Update.
3366         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3367         (btrace_fetch, btrace_clear): Update.
3368         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3369         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3370         type.
3371         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3372         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3373         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3374         * gdbarch.c, gdbarch.h: Rebuild.
3375         * gdbarch.sh (core_pid_to_str): Change return type.
3376         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3377         return type.
3378         (windows_nat_target::pid_to_str): Change return type.
3379         (windows_delete_thread): Update.
3380         (windows_nat_target::attach): Update.
3381         (windows_nat_target::files_info): Update.
3382         * target-delegates.c: Rebuild.
3383         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3384         return type.
3385         (sol_thread_target::pid_to_str): Change return type.
3386         * remote.c (class remote_target) <pid_to_str>: Change return
3387         type.
3388         (remote_target::pid_to_str): Change return type.
3389         (extended_remote_target::attach, remote_target::remote_stop_ns)
3390         (remote_target::remote_notif_remove_queued_reply)
3391         (remote_target::push_stop_reply, remote_target::disable_btrace):
3392         Update.
3393         (extended_remote_target::attach): Update.
3394         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3395         type.
3396         (gdbsim_target::pid_to_str): Change return type.
3397         * ravenscar-thread.c (struct ravenscar_thread_target)
3398         <pid_to_str>: Change return type.
3399         (ravenscar_thread_target::pid_to_str): Change return type.
3400         * procfs.c (class procfs_target) <pid_to_str>: Change return
3401         type.
3402         (procfs_target::pid_to_str): Change return type.
3403         (procfs_target::attach): Update.
3404         (procfs_target::detach): Update.
3405         (procfs_target::fetch_registers): Update.
3406         (procfs_target::store_registers): Update.
3407         (procfs_target::wait): Update.
3408         (procfs_target::files_info): Update.
3409         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3410         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3411         return type.
3412         (nto_procfs_target::pid_to_str): Change return type.
3413         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3414         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3415         return type.
3416         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3417         (exit_lwp): Update.
3418         (attach_proc_task_lwp_callback, get_detach_signal)
3419         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3420         (linux_nat_target::resume, wait_lwp, stop_callback)
3421         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3422         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3423         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3424         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3425         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3426         type.
3427         (inf_ptrace_target::attach): Update.
3428         (inf_ptrace_target::files_info): Update.
3429         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3430         type.
3431         (go32_nat_target::pid_to_str): Change return type.
3432         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3433         (gnu_nat_target::wait): Update.
3434         (gnu_nat_target::wait): Update.
3435         (gnu_nat_target::resume): Update.
3436         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3437         (fbsd_nat_target::wait): Update.
3438         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3439         type.
3440         (darwin_nat_target::attach): Update.
3441         * corelow.c (class core_target) <pid_to_str>: Change return type.
3442         (core_target::pid_to_str): Change return type.
3443         * target.c (normal_pid_to_str): Change return type.
3444         (default_pid_to_str): Likewise.
3445         (target_pid_to_str): Change return type.
3446         (target_translate_tls_address): Update.
3447         (target_announce_detach): Update.
3448         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3449         return type.
3450         (bsd_uthread_target::pid_to_str): Change return type.
3451         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3452         type.
3453         (bsd_kvm_target::pid_to_str): Change return type.
3454         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3455         return type.
3456         (aix_thread_target::pid_to_str): Change return type.
3457         * target.h (struct target_ops) <pid_to_str>: Change return type.
3458         (target_pid_to_str, normal_pid_to_str): Likewise.
3459         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3460         type.
3461         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3462         type.
3463         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3464         return type.
3465         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3466         type.
3467         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3468         type.
3469         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3470         return type.
3471
3472 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3473
3474         * NEWS: Mention that the new default MI version is 3.  Mention
3475         changes to the output of commands and events that deal with
3476         multi-location breakpoints.
3477         * breakpoint.c: Include "mi/mi-out.h".
3478         (print_one_breakpoint): Change output syntax if using MI version
3479         >= 3.
3480         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3481         New.
3482         (mi_multi_location_breakpoint_output_fixed): New.
3483         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3484         (mi_cmd_fix_multi_location_breakpoint_output): New.
3485         (mi_multi_location_breakpoint_output_fixed): New.
3486         * mi/mi-cmds.c (mi_cmds): Register command
3487         -fix-multi-location-breakpoint-output.
3488         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3489         interpreter "mi".
3490
3491 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3492
3493         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3494         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3495         instantiate mi_ui_out based on interpreter name.
3496         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3497         * mi/mi-main.c (mi_load_progress): Likewise.
3498
3499 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3500
3501         * NEWS: Combine separate "New targets" sections for 8.3.
3502
3503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3504
3505         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3506         (ppcfbsd_init_abi): Install gdbarch
3507         "fetch_tls_load_module_address" and "get_thread_local_address"
3508         methods.
3509
3510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3511
3512         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3513         (riscv_fbsd_init_abi): Install gdbarch
3514         "fetch_tls_load_module_address" and "get_thread_local_address"
3515         methods.
3516
3517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3518
3519         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3520         (i386fbsd_init_abi): Install gdbarch
3521         "fetch_tls_load_module_address" and "get_thread_local_address"
3522         methods.
3523
3524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3525
3526         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3527         (amd64fbsd_init_abi): Install gdbarch
3528         "fetch_tls_load_module_address" and "get_thread_local_address"
3529         methods.
3530
3531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3532
3533         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3534         (struct fbsd_pspace_data): New type.
3535         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3536         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3537         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3538         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3539         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3540
3541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3542
3543         * gdbtypes.c (lookup_struct_elt): New function.
3544         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3545         * gdbtypes.h (struct struct_elt): New type.
3546         (lookup_struct_elt): New prototype.
3547
3548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3549
3550         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3551         remove disabled code block.
3552
3553 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3554
3555         * gdbarch.sh (get_thread_local_address): New method.
3556         * gdbarch.h, gdbarch.c: Regenerate.
3557         * target.c (target_translate_tls_address): Use
3558         gdbarch_get_thread_local_address if present instead of
3559         target::get_thread_local_address.
3560
3561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3562
3563         * target.h (target::get_thread_local_address): Update comment.
3564
3565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3566
3567         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3568         objfile->separate_debug_objfile_backlink if not NULL.
3569
3570 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3571
3572         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3573         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3574         (amd64bsd_store_inferior_registers): Likewise.
3575         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3576         Enable segment base registers.
3577         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3578         PT_GETFSBASE and PT_GETGSBASE.
3579         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3580         PT_SETGSBASE.
3581         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3582         segment base registers.
3583         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3584
3585 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3586
3587         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3588         Update calls to i386_target_description to add 'segments'
3589         parameter.
3590         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3591         add segment base registers.
3592         * arch/i386.c (i386_create_target_description): Add 'segments'
3593         parameter to enable segment base registers.
3594         * arch/i386.h (i386_create_target_description): Likewise.
3595         * features/i386/32bit-segments.xml: New file.
3596         * features/i386/32bit-segments.c: Generate.
3597         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3598         call to i386_target_description to add 'segments' parameter.
3599         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3600         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3601         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3602         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3603         if feature is present.
3604         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3605         Add 'segments' parameter to call to i386_target_description.
3606         (i386_target_description): Add 'segments' parameter to enable
3607         segment base registers.
3608         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3609         to call to i386_target_description.
3610         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3611         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3612         Define I386_NUM_REGS.
3613         (i386_target_description): Add 'segments' parameter to enable
3614         segment base registers.
3615
3616 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3617
3618         PR/24325
3619         * source-cache.c: #undef open and close, to avoid unresolved
3620         externals during linking.
3621
3622 2019-03-12  Tom Tromey  <tromey@adacore.com>
3623
3624         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3625         const.  Add initializers.
3626         (_initialize_remote): Don't initialize ptid globals.
3627
3628 2019-03-12  Pedro Alves  <palves@redhat.com>
3629
3630         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3631
3632 2019-03-12  Pedro Alves  <palves@redhat.com>
3633
3634         * cp-name-parser.y (main): Remove unused 'len' variable.
3635
3636 2019-03-12  Tom Tromey  <tromey@adacore.com>
3637
3638         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3639         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3640
3641 2019-03-12  Tom Tromey  <tromey@adacore.com>
3642
3643         * linux-nat.c (iterate_over_lwps): Update.
3644         (stop_callback): Remove parameter.
3645         (stop_wait_callback, detach_callback, resume_set_callback)
3646         (select_singlestep_lwp_callback, set_ignore_sigint)
3647         (status_callback, resumed_callback, resume_clear_callback)
3648         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3649         data parameter.
3650         (linux_nat_target::detach, linux_nat_target::resume)
3651         (linux_stop_and_wait_all_lwps, select_event_lwp)
3652         (linux_nat_filter_event, linux_nat_wait_1)
3653         (linux_nat_target::kill, linux_nat_target::stop)
3654         (linux_nat_target::stop): Update.
3655         (linux_nat_resume_callback): Change type.
3656         (resume_stopped_resumed_lwps, count_events_callback)
3657         (select_event_lwp_callback): Likewise.
3658         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3659         * arm-linux-nat.c (struct update_registers_data): Remove.
3660         (update_registers_callback): Change type.
3661         (arm_linux_insert_hw_breakpoint1): Update.
3662         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3663         parameter.
3664         (x86_linux_dr_set_addr): Update.
3665         (x86_linux_dr_set_control): Update.
3666         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3667         (iterate_over_lwps): Use gdb::function_view.
3668         * nat/aarch64-linux-hw-point.c (struct
3669         aarch64_dr_update_callback_param): Remove.
3670         (debug_reg_change_callback): Change type.
3671         (aarch64_notify_debug_reg_change): Update.
3672         * s390-linux-nat.c (s390_refresh_per_info): Update.
3673
3674 2019-03-11  Tom Tromey  <tromey@adacore.com>
3675
3676         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3677         redundant assignment to "this_cu".
3678
3679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3680
3681         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3682
3683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3684
3685         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3686         from...
3687         (rank_one_type): ... this.
3688
3689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3690
3691         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3692         from...
3693         (rank_one_type): ... this.
3694
3695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3696
3697         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3698         from...
3699         (rank_one_type): ... this.
3700
3701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3702
3703         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3704         from...
3705         (rank_one_type): ... this.
3706
3707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3708
3709         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3710         from...
3711         (rank_one_type): ... this.
3712
3713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3714
3715         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3716         from...
3717         (rank_one_type): ... this.
3718
3719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3720
3721         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3722         from...
3723         (rank_one_type): ... this.
3724
3725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3726
3727         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3728         from...
3729         (rank_one_type): ... this.
3730
3731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3732
3733         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3734         from...
3735         (rank_one_type): ... this.
3736
3737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3738
3739         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3740         from...
3741         (rank_one_type): ... this.
3742
3743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3744
3745         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3746         from...
3747         (rank_one_type): ... this.
3748
3749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3750
3751         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3752         from...
3753         (rank_one_type): ... this.
3754
3755 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3756
3757         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3758         inferior-events' shows the example events.
3759
3760 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3761
3762         Support styling on native MS-Windows console
3763
3764         PR/24315
3765         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3766         on MS-Windows if $TERM is not defined.
3767
3768         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3769
3770         * posix-hdep.c (gdb_console_fputs):
3771         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3772         functions.
3773         * ui-file.h (gdb_console_fputs): Add prototype.
3774
3775         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3776         back to fputs only if the former returns zero.
3777
3778 2019-03-07  Tom Tromey  <tom@tromey.com>
3779
3780         * symmisc.c (print_symbol_bcache_statistics): Update.
3781         (print_objfile_statistics): Update.
3782         * symfile.c (allocate_symtab): Update.
3783         * stabsread.c: Don't include bcache.h.
3784         * psymtab.h (struct psymbol_bcache): Don't declare.
3785         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3786         (psymbol_bcache_init, psymbol_bcache_free)
3787         (psymbol_bcache_get_bcache): Don't declare.
3788         * psymtab.c (struct psymbol_bcache): Remove.
3789         (psymtab_storage::psymtab_storage): Update.
3790         (psymtab_storage::~psymtab_storage): Update.
3791         (psymbol_bcache_init, psymbol_bcache_free)
3792         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3793         (add_psymbol_to_bcache): Update.
3794         (allocate_psymtab): Update.
3795         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3796         macro_cache>: No longer pointers.
3797         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3798         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3799         * macrotab.c (macro_bcache): Update.
3800         * macroexp.c: Don't include bcache.h.
3801         * gdbtypes.c (check_types_worklist): Update.
3802         (types_deeply_equal): Remove TRY/CATCH.  Update.
3803         * elfread.c (elf_symtab_read): Update.
3804         * dwarf2read.c: Don't include bcache.h.
3805         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3806         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3807         (print_bcache_statistics, bcache_memory_used): Don't declare.
3808         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3809         methods.  Rename all data members.
3810         * bcache.c (struct bcache): Move to bcache.h.
3811         (bcache::expand_hash_table): Rename from expand_hash_table.
3812         (bcache): Remove.
3813         (bcache::insert): Rename from bcache_full.
3814         (bcache::compare): Rename from bcache_compare.
3815         (bcache_xmalloc): Remove.
3816         (bcache::~bcache): Rename from bcache_xfree.
3817         (bcache::print_statistics): Rename from print_bcache_statistics.
3818         (bcache::memory_used): Rename from bcache_memory_used.
3819
3820 2019-03-07  Pedro Alves  <palves@redhat.com>
3821
3822         * infrun.c (normal_stop): Also check for
3823         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3824
3825 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * f-lang.c (value_from_host_double): Moved to...
3828         * value.c (value_from_host_double): ...here.
3829         * value.h (value_from_host_double): Declare.
3830         * guile/scm-math.c (vlscm_convert_typed_number): Use
3831         value_from_host_double.
3832         (vlscm_convert_number): Likewise.
3833         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3834         * python/py-value.c (convert_value_from_python): Likewise.
3835
3836 2019-03-06  Tom Tromey  <tom@tromey.com>
3837
3838         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3839
3840 2019-03-06  Tom Tromey  <tom@tromey.com>
3841
3842         * utils.h (free_current_contents): Don't declare.
3843         * utils.c (free_current_contents): Remove.
3844
3845 2019-03-06  Tom Tromey  <tom@tromey.com>
3846
3847         * top.c (quit_force): Update.
3848         * main.c (captured_command_loop): Update.
3849         * common/new-op.c (operator new): Update.
3850         * common/common-exceptions.c (struct catcher)
3851         <save_cleanup_chain>: Remove member.
3852         (exceptions_state_mc_init): Update.
3853         (exception_try_scope_entry): Return nullptr.
3854         (exception_try_scope_exit, exception_rethrow)
3855         (throw_exception_sjlj, throw_exception_cxx): Update.
3856         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3857         (all_cleanups, do_cleanups, discard_cleanups)
3858         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3859         (restore_cleanups, restore_final_cleanups): Don't declare.
3860         (do_final_cleanups): Remove parameter.
3861         * common/cleanups.c (cleanup_chain, make_cleanup)
3862         (make_cleanup_dtor, all_cleanups, do_cleanups)
3863         (discard_my_cleanups, discard_cleanups)
3864         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3865         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3866         (null_cleanup): Remove.
3867         (do_final_cleanups): Remove parameter.
3868
3869 2019-03-06  Tom Tromey  <tom@tromey.com>
3870
3871         * remote.c (remote_target::remote_parse_stop_reply): Use
3872         unique_xmalloc_ptr.
3873
3874 2019-03-06  Tom Tromey  <tom@tromey.com>
3875
3876         * stabsread.c (struct stabs_field_info): Rename from field_info.
3877         <list, fnlist>: Add initializers.
3878         <obstack>: New member.
3879         (read_member_functions, read_struct_fields, read_baseclasses):
3880         Allocate on obstack.  Don't use cleanups.
3881         (read_one_struct_field, read_member_functions, read_struct_fields)
3882         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3883         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3884         (read_struct_type): Update.
3885
3886 2019-03-06  Tom Tromey  <tom@tromey.com>
3887
3888         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3889         * common/filestuff.h (make_cleanup_close): Don't declare.
3890         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3891         Remove.
3892
3893 2019-03-06  Tom Tromey  <tom@tromey.com>
3894
3895         * solib-aix.c: Use make_scope_exit.
3896
3897 2019-03-06  Tom Tromey  <tom@tromey.com>
3898
3899         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3900         Use make_scope_exit.
3901
3902 2019-03-06  Tom Tromey  <tom@tromey.com>
3903
3904         * solib-svr4.c (disable_probes_interface): Remove parameter.
3905         (svr4_handle_solib_event): Use make_scope_exit.
3906
3907 2019-03-06  Tom Tromey  <tom@tromey.com>
3908
3909         * remote.c (struct stop_reply_deleter): Remove.
3910         (stop_reply_up): Update.
3911         (struct stop_reply): Derive from notif_event.  Don't typedef.
3912         <regcache>: Now a std::vector.
3913         (stop_reply_xfree): Remove.
3914         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3915         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3916         (remote_target::discard_pending_stop_replies): Use delete.
3917         (remote_target::remote_parse_stop_reply): Update.
3918         (remote_target::process_stop_reply): Update.
3919         * remote-notif.h (struct notif_event): Add virtual destructor.
3920         Remove "dtr" member.
3921         (struct notif_client) <alloc_event>: Return a unique_ptr.
3922         (notif_event_xfree): Don't declare.
3923         (notif_event_up): New typedef.
3924         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3925         (notif_event_xfree, do_notif_event_xfree): Remove.
3926         (remote_notif_state_xfree): Update.
3927
3928 2019-03-06  Tom Tromey  <tom@tromey.com>
3929
3930         * infrun.c (displaced_step_clear_cleanup): Now a
3931         forward_scope_exit type.
3932         (displaced_step_prepare_throw): Update.
3933         (displaced_step_fixup): Update.
3934
3935 2019-03-06  Tom Tromey  <tom@tromey.com>
3936
3937         * inferior.h (class inferior): Update comment.
3938         * gdbthread.h (class thread_info): Update comment.
3939
3940 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3941             Tom Tromey  <tom@tromey.com>
3942
3943         * stabsread.h (struct stab_section_list): Remove.
3944         (coffstab_build_psymtabs): Update.
3945         * dbxread.c (symbuf_sections): Now a std::vector.
3946         (sect_idx): New global.
3947         (fill_symbuf): Update.
3948         (coffstab_build_psymtabs): Change type of stabsects parameter.
3949         Update.
3950         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3951         std::vector.
3952         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3953         (coff_locate_sections): Update.
3954         (coff_symfile_read): Remove cleanups.  Update.
3955         (init_stringtab): Add storage parameter.
3956         (free_stringtab, free_stringtab_cleanup): Remove.
3957         (init_lineno): Add storage parameter.
3958         (free_linetab, free_linetab_cleanup): Remove.
3959
3960 2019-03-06  Pedro Alves  <palves@redhat.com>
3961
3962         * linux-fork.c (fork_info::clobber_regs): Delete.
3963         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3964         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3965         comment.  Adjust.
3966         (scoped_switch_fork_info::scoped_switch_fork_info)
3967         (checkpoint_command, linux_fork_context): Adjust
3968         fork_save_infrun_state calls.
3969
3970 2019-03-06  Pedro Alves  <palves@redhat.com>
3971
3972         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3973         (inf_has_multiple_threads): Return 'bool' and rewrite using
3974         inferior_info::threads().
3975
3976 2019-03-06  Pedro Alves  <palves@redhat.com>
3977
3978         * linux-fork.c: Include <list>.
3979         (fork_list): Now a std::list instance.
3980         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3981         (forks_exist_p, find_last_fork): Adjust.
3982         (new_fork): Delete.
3983         (one_fork_p): New.
3984         (add_fork): Adjust.
3985         (free_fork): Delete, folded into fork_info::~fork_info().
3986         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3987         Adjust.
3988         (init_fork_list): Delete.
3989         (linux_fork_killall, linux_fork_mourn_inferior)
3990         (linux_fork_detach, info_checkpoints_command): Adjust.
3991         (_initialize_linux_fork): No longer call init_fork_list.
3992
3993 2019-03-06  Pedro Alves  <palves@redhat.com>
3994
3995         * linux-fork.c (new_fork): New, split out of ...
3996         (add_fork): ... this.  Return void.  Move "first fork" special
3997         case from here, to ...
3998         (checkpoint_command): ... here.
3999         * linux-linux.h (add_fork): Return void.
4000
4001 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4004
4005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4006             Chris January  <chris.january@arm.com>
4007             David Lecomber  <david.lecomber@arm.com>
4008
4009         * f-exp.y: New token, UNOP_INTRINSIC.
4010         (exp): New pattern using UNOP_INTRINSIC token.
4011         (f77_keywords): Add 'abs' keyword.
4012         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4013         (value_from_host_double): New function.
4014         (evaluate_subexp_f): Support UNOP_ABS.
4015
4016 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4017
4018         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4019         types.
4020
4021 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4024         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4025         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4026
4027 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4030
4031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4032             Chris January  <chris.january@arm.com>
4033
4034         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4035         * f-exp.y: Define 'KIND' token.
4036         (exp): New pattern for KIND expressions.
4037         (ptype): Handle types with a kind extension.
4038         (direct_abs_decl): Extend to spot kind extensions.
4039         (f77_keywords): Add 'kind' to the list.
4040         (push_kind_type): New function.
4041         (convert_to_kind_type): New function.
4042         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4043         * parse.c (operator_length_standard): Likewise.
4044         * parser-defs.h (enum type_pieces): Add tp_kind.
4045         * std-operator.def: Add UNOP_KIND.
4046
4047 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * f-exp.y (f_parse): Set yydebug.
4050
4051 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * f-lang.c (evaluate_subexp_f): New function.
4054         (exp_descriptor_f): New global.
4055         (f_language_defn): Use exp_descriptor_f instead of
4056         exp_descriptor_standard.
4057
4058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * f-exp.y (struct token): Add comments.
4061         (dot_ops): Remove uppercase versions and the end marker.
4062         (f77_keywords): Likewise.
4063         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4064         entries in the dot_ops array are case insensitive, and use
4065         strncasecmp to compare strings.  Also some whitespace cleanup in
4066         this area.  Similar for the f77_keywords array, except entries in
4067         this list might be case sensitive.
4068
4069 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * f-exp.y (struct f77_boolean_val): Add comments.
4072         (boolean_values): Remove uppercase versions, and end marker.
4073         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4074         and use strncasecmp to achieve case insensitivity.  Additionally,
4075         perform whitespace cleanup around this code.
4076
4077 2019-03-06  Tom Tromey  <tromey@adacore.com>
4078
4079         * remote-sim.c (gdbsim_target_open): Use result of
4080         gdb_argv::release.
4081
4082 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4083         Dirk Schubert  <dirk.schubert@arm.com>
4084         Chris January  <chris.january@arm.com>
4085
4086         * eval.c (evaluate_subexp_standard): Call Fortran argument
4087         wrapping logic.
4088         * f-lang.c (struct value): A value which can be passed into a
4089         Fortran function call.
4090         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4091         where appropriate.
4092         (struct type): Value ready for a Fortran function call.
4093         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4094         is needed.
4095         * f-lang.h (fortran_argument_convert): Declaration.
4096         (fortran_preserve_arg_pointer): Declaration.
4097         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4098
4099 2019-03-05  Tom Tromey  <tromey@adacore.com>
4100
4101         * python/py-prettyprint.c (print_string_repr): Remove #if.
4102         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4103
4104 2019-03-05  Tom Tromey  <tromey@adacore.com>
4105
4106         * target.c (the_dummy_target): Move later.  Change type to
4107         "dummy_target".
4108         (initialize_targets): Don't initialize the_dummy_target.
4109
4110 2019-03-05  Tom Tromey  <tromey@adacore.com>
4111
4112         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4113         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4114
4115 2019-03-05  Tom Tromey  <tromey@adacore.com>
4116
4117         * windows-nat.c (windows_nat_target::attach)
4118         (windows_nat_target::detach): Don't call gdb_flush.
4119         * valprint.c (generic_val_print, val_print, val_print_string):
4120         Don't call gdb_flush.
4121         * utils.c (defaulted_query): Don't call gdb_flush.
4122         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4123         * target.c (target_announce_detach): Don't call gdb_flush.
4124         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4125         * remote.c (extended_remote_target::attach): Don't call
4126         gdb_flush.
4127         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4128         * printcmd.c (do_examine): Don't call gdb_flush.
4129         (info_display_command): Don't call gdb_flush.
4130         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4131         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4132         * memattr.c (info_mem_command): Don't call gdb_flush.
4133         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4134         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4135         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4136         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4137         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4138         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4139         (gnu_nat_target::detach): Don't call gdb_flush.
4140         * f-valprint.c (f_val_print): Don't call gdb_flush.
4141         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4142         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4143         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4144         gdb_flush.
4145         * c-valprint.c (c_val_print): Don't call gdb_flush.
4146         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4147
4148 2019-03-05  Tom Tromey  <tromey@adacore.com>
4149
4150         * varobj.c (update_dynamic_varobj_children): Update.
4151         (install_default_visualizer): Use reset, not release.
4152         * value.c (set_internalvar): Update.
4153         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4154         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4155         ATTRIBUTE_UNUSED_RESULT.
4156
4157 2019-03-05  Tom Tromey  <tromey@adacore.com>
4158
4159         * remote.c (class scoped_remote_fd) <release>: Add
4160         ATTRIBUTE_UNUSED_RESULT.
4161
4162 2019-03-05  Tom Tromey  <tromey@adacore.com>
4163
4164         * macroexp.c (struct macro_buffer) <release>: Add
4165         ATTRIBUTE_UNUSED_RESULT.
4166
4167 2019-03-05  Tom Tromey  <tromey@adacore.com>
4168
4169         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4170         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4171         ATTRIBUTE_UNUSED_RESULT.
4172
4173 2019-03-05  Tom Tromey  <tromey@adacore.com>
4174
4175         * common/scoped_fd.h (class scoped_fd) <release>: Add
4176         ATTRIBUTE_UNUSED_RESULT.
4177
4178 2019-03-05  Tom Tromey  <tromey@adacore.com>
4179
4180         * parser-defs.h (struct parser_state) <release>: Add
4181         ATTRIBUTE_UNUSED_RESULT.
4182
4183 2019-03-05  Tom Tromey  <tromey@adacore.com>
4184
4185         * utils.h (class gdb_argv) <release>: Add
4186         ATTRIBUTE_UNUSED_RESULT.
4187         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4188
4189 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4190
4191         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4192         for-loop range, to avoid compiler warnings.
4193
4194         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4195         avoid compiler warnings about unused variables.
4196
4197         * NEWS: Mention end of support for native debugging on MS-Windows
4198         before XP.
4199
4200         PR gdb/24292
4201         * common/netstuff.c:
4202         * gdbserver/gdbreplay.c
4203         * gdbserver/remote-utils.c:
4204         * ser-tcp.c:
4205         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4206         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4207         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4208         'getaddrinfo' and 'freeaddrinfo' were not available before
4209         Windows XP, and mingw.org's MinGW headers by default define
4210         _WIN32_WINNT to 0x500.
4211
4212 2019-03-01  Gary Benson <gbenson@redhat.com>
4213
4214         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4215
4216 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4217             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4218
4219         PR gdb/8527
4220         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4221         set_sigint_trap, clear_sigint_trap.
4222
4223 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4224
4225         * target.c (target_detach): Clear the regcache and the
4226         frame cache.
4227
4228 2019-02-27  Pedro Alves  <palves@redhat.com>
4229
4230         * utils.c (set_screen_size): When we cap the height/width sizes,
4231         tweak the corresponding command variable to show "unlimited":
4232
4233 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4234             Pedro Alves  <palves@redhat.com>
4235
4236         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4237         before calling rl_set_screen_size.
4238
4239 2019-02-27  Tom Tromey  <tromey@adacore.com>
4240
4241         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4242         define.
4243         * python/py-value.c: Remove Python 2.4 workaround.
4244         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4245         workaround.
4246         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4247         Python 2.4 workaround.
4248         * python/python-internal.h: Remove Python 2.4 comment.
4249         (Py_ssize_t): Don't define.
4250         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4251         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4252         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4253         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4254         * python/python.c (do_start_initialization): Remove Python 2.4
4255         workaround.
4256         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4257         (print_children): Remove Python 2.4 workaround.
4258         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4259         workaround.
4260         (CHARBUFFERPROC_NAME): Remove.
4261         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4262         Python 2.4 workaround.
4263
4264 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4265
4266         * NEWS: Note minimum Python version.
4267
4268 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4269
4270         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4271         code from these functions.  Remove corresponding ifdefs.  Use
4272         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4273         Remove gotos and target of gotos.
4274         (infpy_search_memory): Likewise.
4275
4276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4277
4278         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4279         (hppa_gdbarch_init): Don't register deleted functions with
4280         gdbarch.
4281
4282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4285         (h8300_unwind_sp): Delete.
4286         (h8300_dummy_id): Delete.
4287         (h8300_gdbarch_init): Don't register deleted functions with
4288         gdbarch.
4289
4290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4293         (ft32_unwind_pc): Delete.
4294         (ft32_unwind_sp): Delete.
4295         (ft32_gdbarch_init): Don't register deleted functions with
4296         gdbarch.
4297
4298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4301         (frv_unwind_pc): Delete.
4302         (frv_unwind_sp): Delete.
4303         (frv_gdbarch_init): Don't register deleted functions with
4304         gdbarch.
4305
4306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4309         (riscv_unwind_pc): Delete.
4310         (riscv_unwind_sp): Delete.
4311         (riscv_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4317         (csky_unwind_pc): Delete.
4318         (csky_unwind_sp): Delete.
4319         (csky_gdbarch_init): Don't register deleted functions with
4320         gdbarch.
4321
4322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4325         (cris_unwind_pc): Delete.
4326         (cris_unwind_sp): Delete.
4327         (cris_gdbarch_init): Don't register deleted functions with
4328         gdbarch.
4329
4330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4333         (bfin_unwind_pc): Delete.
4334         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4335
4336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4339         (arm_unwind_pc): Delete.
4340         (arm_unwind_sp): Delete.
4341         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4342
4343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4346         (arc_unwind_pc): Delete.
4347         (arc_unwind_sp): Delete.
4348         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4349
4350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4353         (alpha_unwind_pc): Delete.
4354         (alpha_gdbarch_init): Don't register deleted functions with
4355         gdbarch.
4356
4357 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4358
4359         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4360         (aarch64_unwind_pc): Delete.
4361         (aarch64_unwind_sp): Delete.
4362         (aarch64_gdbarch_init): Don't register deleted functions with
4363         gdbarch.
4364
4365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * gdbtypes.c (type_align): Don't consider static members when
4368         computing structure alignment.
4369
4370 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4373         return 0 for other types.
4374         * arch-utils.c (default_type_align): Always return 0.
4375         * gdbarch.h: Regenerate.
4376         * gdbarch.sh (type_align): Extend comment.
4377         * gdbtypes.c (type_align): Add additional comments, always call
4378         gdbarch_type_align before applying the default rules.
4379         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4380         generic code will then apply a suitable default.
4381         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4382         types, return 0 for other types.
4383
4384 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4385
4386         * NEWS: Create a new section for the next release branch.
4387         Rename the section of the current branch, now that it has
4388         been cut.
4389
4390 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4391
4392         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4393         * version.in: Bump version to 8.3.50.DATE-git.
4394
4395 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4396
4397         * aix-thread.c (ptid_cmp): Remove unused variable.
4398         (get_signaled_thread): Likewise.
4399         (store_regs_user_thread): Likewise.
4400         (store_regs_kernel_thread): Likewise.
4401         (fetch_regs_kernel_thread): Remove shadowed variable.
4402
4403 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4404
4405         * features/riscv/32bit-cpu.xml: Add register numbers.
4406         * features/riscv/32bit-fpu.c: Regenerate.
4407         * features/riscv/32bit-fpu.xml: Add register numbers.
4408         * features/riscv/64bit-cpu.xml: Add register numbers.
4409         * features/riscv/64bit-fpu.c: Regenerate.
4410         * features/riscv/64bit-fpu.xml: Add register numbers.
4411
4412 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4413
4414         * NEWS: Mention two argument form of gdb.Value constructor.
4415         * python/py-value.c (convert_buffer_and_type_to_value): New
4416         function.
4417         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4418         Add support for handling an optional second argument.  Call
4419         convert_buffer_and_type_to_value as appropriate.
4420         * python/python-internal.h (Py_buffer_deleter): New struct.
4421         (Py_buffer_up): New typedef.
4422
4423 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4424
4425         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4426         instead of releasing ownership.
4427
4428 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4429
4430         * dwarf2read.c (open_and_init_dwp_file): Call
4431         elf_numsections instead of bfd_count_sections to initialize
4432         dwp_file->num_sections.
4433
4434 2019-02-25  Tom Tromey  <tromey@adacore.com>
4435
4436         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4437
4438 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4439
4440         * gcore.in: Add '--readnever' option when invoking GDB.
4441
4442 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4443
4444         * MAINTAINERS: Update my email address.
4445
4446 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4447
4448         * build-id.c (build_id_to_debug_bfd_1): New function.
4449         (build_id_to_debug_bfd): Look for separate debug file in
4450         sysroot.
4451
4452 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4453
4454         * gdbarch.sh: Update the copyright year range that is placed into
4455         generated files.
4456
4457 2019-02-22  Keith Seitz  <keiths@redhat.com>
4458
4459         PR symtab/23853
4460         * linespec.c (create_sals_line_offset): Search for the default
4461         symtab's filename instead of its fullname.
4462
4463 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4464
4465         * NEWS: Update style defaults.
4466
4467 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4468
4469         * main.c (captured_main_1): Disable styling in batch mode.
4470
4471 2019-02-20  Tom Tromey  <tom@tromey.com>
4472
4473         * symtab.c (symtab_symbol_info): Fix typos.
4474
4475 2019-02-20  Tom Tromey  <tromey@adacore.com>
4476
4477         * findcmd.c (_initialize_mem_search): Use upper case for
4478         metasyntactic variables.
4479
4480 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4481
4482         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4483         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4484
4485 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4486
4487         * top.h (source_file_name): Change to std::string.
4488         * top.c (source_file_name): Likewise.
4489         (command_line_input): Adjust.
4490         * cli/cli-script.c (script_from_file): Adjust.
4491
4492 2019-02-19  Tom Tromey  <tromey@adacore.com>
4493
4494         * ravenscar-thread.c
4495         (ravenscar_thread_target::update_thread_list): Don't call
4496         ada_build_task_list.
4497         * ada-lang.h (ada_build_task_list): Don't declare.
4498         * ada-tasks.c (struct ada_tasks_inferior_data)
4499         <task_list_valid_p>: Now bool.
4500         (read_known_tasks, ada_task_list_changed)
4501         (ada_tasks_invalidate_inferior_data): Update.
4502         (read_known_tasks_array): Return bool.
4503         (read_known_tasks_list): Likewise.
4504         (read_known_tasks): Return void.
4505         (ada_build_task_list): Now static.
4506
4507 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4510         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4511
4512 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4513
4514         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4515         variant for ada_tasks_pspace_data_handle and
4516         ada_tasks_inferior_data_handle.
4517         (ada_tasks_pspace_data_cleanup): New function.
4518         (ada_tasks_inferior_data_cleanup): New function.
4519
4520 2019-02-17  Tom Tromey  <tom@tromey.com>
4521
4522         * macrotab.h (macro_source_fullname): Return a std::string.
4523         * macrotab.c (macro_include, check_for_redefinition)
4524         (macro_undef, macro_lookup_definition, foreach_macro)
4525         (foreach_macro_in_scope): Update.
4526         (macro_source_fullname): Return a std::string.
4527         * macrocmd.c (show_pp_source_pos): Update.
4528
4529 2019-02-17  Tom Tromey  <tom@tromey.com>
4530
4531         * macrocmd.c (show_pp_source_pos): Style the file names.
4532
4533 2019-02-17  Tom Tromey  <tom@tromey.com>
4534
4535         PR tui/24197:
4536         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4537
4538 2019-02-17  Tom Tromey  <tom@tromey.com>
4539
4540         * ada-lang.c (user_select_syms): Use filtered printing.
4541         * utils.c (wrap_style): New global.
4542         (desired_style): Remove.
4543         (emit_style_escape): Add stream parameter.
4544         (set_output_style, reset_terminal_style, prompt_for_continue):
4545         Update.
4546         (flush_wrap_buffer): Only flush gdb_stdout.
4547         (wrap_here): Set wrap_style.
4548         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4549         treat escape sequences as a character.  Change when wrap buffer is
4550         flushed.
4551         (fputs_styled): Do not set the output style when the default is
4552         requested.
4553         * ui-style.h (struct ui_file_style) <is_default>: New method.
4554         * source.c (print_source_lines_base): Emit escape sequences in one
4555         piece.
4556
4557 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4558
4559         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4560         integers and enumeration types.
4561
4562 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4563
4564         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4565         instead of lookup_symbol_in_language
4566         (do_exact_match): New function.
4567         (ada_get_symbol_name_matcher): Return do_exact_match when
4568         doing a verbatim match.
4569
4570 2019-02-15  Tom Tromey  <tromey@adacore.com>
4571
4572         * ravenscar-thread.c (ravenscar_thread_target::resume)
4573         (ravenscar_thread_target::wait): Special case wildcard requests.
4574
4575 2019-02-15  Tom Tromey  <tromey@adacore.com>
4576
4577         * ravenscar-thread.c (base_ptid): Remove.
4578         (struct ravenscar_thread_target) <close>: New method.
4579         <m_base_ptid>: New member.
4580         <update_inferior_ptid, active_task, task_is_currently_active,
4581         runtime_initialized>: Declare methods.
4582         <ravenscar_thread_target>: Add constructor.
4583         (ravenscar_thread_target::task_is_currently_active)
4584         (ravenscar_thread_target::update_inferior_ptid)
4585         (ravenscar_runtime_initialized): Rename.  Now methods.
4586         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4587         (ravenscar_thread_target::update_thread_list): Update.
4588         (ravenscar_thread_target::active_task): Now method.
4589         (ravenscar_thread_target::store_registers)
4590         (ravenscar_thread_target::prepare_to_store)
4591         (ravenscar_thread_target::prepare_to_store)
4592         (ravenscar_thread_target::mourn_inferior): Update.
4593         (ravenscar_inferior_created): Use "new" to create target.
4594         (ravenscar_thread_target::get_ada_task_ptid): Update.
4595         (_initialize_ravenscar): Don't initialize base_ptid.
4596         (ravenscar_ops): Remove global.
4597
4598 2019-02-15  Tom Tromey  <tromey@adacore.com>
4599
4600         * target.h (push_target): Declare new overload.
4601         * target.c (push_target): New overload, taking an rvalue reference.
4602         * remote.c (remote_target::open_1): Use push_target overload.
4603         * corelow.c (core_target_open): Use push_target overload.
4604
4605 2019-02-15  Tom Tromey  <tromey@adacore.com>
4606
4607         * ravenscar-thread.c (is_ravenscar_task)
4608         (ravenscar_task_is_currently_active): Return bool.
4609         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4610         (_initialize_ravenscar): Remove "(void)".
4611         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4612         Return bool.
4613
4614 2019-02-15  Tom Tromey  <tromey@adacore.com>
4615
4616         * ravenscar-thread.c (ravenscar_runtime_initializer)
4617         (has_ravenscar_runtime, get_running_thread_id)
4618         (ravenscar_thread_target::resume): Fix indentation.
4619
4620 2019-02-15  Tom Tromey  <tromey@adacore.com>
4621
4622         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4623         from ravenscar_arch_ops.
4624         (sparc_ravenscar_ops::fetch_registers)
4625         (sparc_ravenscar_ops::store_registers): Now methods.
4626         (sparc_ravenscar_prepare_to_store): Remove.
4627         (sparc_ravenscar_ops): Redefine.
4628         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4629         methods and destructor.  Remove members.
4630         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4631         (ravenscar_thread_target::store_registers)
4632         (ravenscar_thread_target::prepare_to_store): Update.
4633         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4634         Remove.
4635         (struct ppc_ravenscar_powerpc_ops): Derive from
4636         ravenscar_arch_ops.
4637         (ppc_ravenscar_powerpc_ops::fetch_registers)
4638         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4639         (ppc_ravenscar_powerpc_ops): Redefine.
4640         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4641         (ppc_ravenscar_e500_ops::fetch_registers)
4642         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4643         (ppc_ravenscar_e500_ops): Redefine.
4644         * aarch64-ravenscar-thread.c
4645         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4646         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4647         (aarch64_ravenscar_fetch_registers)
4648         (aarch64_ravenscar_store_registers): Now methods.
4649         (aarch64_ravenscar_ops): Redefine.
4650
4651 2019-02-15  Tom Tromey  <tromey@adacore.com>
4652
4653         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4654         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4655         (ravenscar_thread_target::stopped_by_watchpoint)
4656         (ravenscar_thread_target::stopped_data_address)
4657         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4658
4659 2019-02-15  Tom Tromey  <tromey@adacore.com>
4660
4661         * ravenscar-thread.c: Fix some typos.
4662
4663 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4664             Tom Tromey  <tromey@adacore.com>
4665
4666         * ada-lang.c (ada_exception_sal): Change addr_string to a
4667         std::string.
4668         (create_ada_exception_catchpoint): Update.
4669
4670 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4671             Tom Tromey  <tromey@adacore.com>
4672
4673         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4674         (bp_location_ops): Remove.
4675         (base_breakpoint_allocate_location): Update.
4676         (free_bp_location): Update.
4677         * ada-lang.c (class ada_catchpoint_location)
4678         <ada_catchpoint_location>: Remove ops parameter.
4679         (ada_catchpoint_location_dtor): Remove.
4680         (ada_catchpoint_location_ops): Remove.
4681         (allocate_location_exception): Update.
4682         * breakpoint.h (struct bp_location_ops): Remove.
4683         (class bp_location) <bp_location>: Remove bp_location_ops
4684         parameter.
4685         <~bp_location>: Add destructor.
4686         <ops>: Remove.
4687
4688 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4689             Pedro Alves  <palves@redhat.com>
4690
4691         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4692         'PATH_MAX'.
4693
4694 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4695             Samuel Thibault  <samuel.thibault@gnu.org>
4696             Thomas Schwinge  <thomas@codesourcery.com>
4697
4698         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4699         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4700
4701 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4702
4703         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4704         (check_empty): Use "const char *".
4705
4706         * gnu-nat.c (gnu_nat_target::detach): Instead of
4707         'detach_inferior (pid)' call
4708         'detach_inferior (find_inferior_pid (pid))'.
4709
4710         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4711         'nat/fork-inferior.o'.
4712         * gnu-nat.c: #include "nat/fork-inferior.h".
4713
4714         * gnu-nat.c (gnu_nat_target::detach): Instead of
4715         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4716         * gnu-nat.h: #include "inf-child.h".
4717         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4718         'i386_gnu_nat_target::fetch_registers'.
4719         (gnu_store_registers): Rename/move to
4720         'i386_gnu_nat_target::store_registers'.
4721
4722         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4723         * gnu-nat.h (mach_thread_info): New function.
4724         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4725
4726         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4727
4728 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4729
4730         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4731
4732 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4733
4734         * windows-nat.c (windows_add_thread): Add new parameter
4735         "main_thread_p" with default value set to false.  Update
4736         function documentation as well as all callers.
4737         (windows_delete_thread): Likewise.
4738         (fake_create_process): Update call to windows_add_thread.
4739         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4740         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4741         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4742         call to windows_delete_thread.
4743
4744 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4745
4746         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4747
4748 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4749
4750         * symfile.c (find_separate_debug_file): Use canonical path of
4751         sysroot with child_path instead of gdb_sysroot if it is valid.
4752
4753 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4754
4755         * symfile.c (find_separate_debug_file): Use child_path to
4756         determine if an object file is under a sysroot.
4757
4758 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4759
4760         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4761         unittests/child-path-selftests.c.
4762         * common/pathstuff.c (child_path): New function.
4763         * common/pathstuff.h (child_path): New prototype.
4764         * unittests/child-path-selftests.c: New file.
4765
4766 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4767
4768         * symfile.c (find_separate_debug_file): Look for separate debug
4769         files in debug directories under the sysroot.
4770
4771 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4772
4773         * symtab.h (struct minimal_symbol data_p): New const method.
4774         (struct minimal_symbol text_p): Likewise.
4775         * symtab.c (output_source_filename): Use file name style
4776         to print file name.
4777         (print_symbol_info): Likewise.
4778         (print_msymbol_info): Use address style to print addresses.
4779         Use function name style to print executable text symbols.
4780         (expand_symtab_containing_pc): Use data_p.
4781         (find_pc_sect_compunit_symtab): Likewise.
4782
4783 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4784
4785         * breakpoint.c (describe_other_breakpoints): Use address style
4786         to print addresses.
4787         (say_where): Likewise.
4788
4789 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4790
4791         * ada-typeprint.c (print_func_type): Print function name
4792         style to print function name.
4793         * c-typeprint.c (c_print_type_1): Likewise.
4794
4795 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4796
4797         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4798         for execve.
4799
4800 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4801
4802         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4803         type_stack.
4804
4805 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4806
4807         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4808         TYPE_CODE_REF types.
4809
4810 2019-02-08  Jim Wilson  <jimw@sifive.com>
4811
4812         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4813         (riscv_linux_fregset): New.
4814         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4815
4816 2019-02-07  Tom Tromey  <tom@tromey.com>
4817
4818         * thread.c (thread_cancel_execution_command): Update.
4819         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4820         methods.
4821         (struct thread_fsm_ops): Remove.
4822         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4823         (thread_fsm_should_stop, thread_fsm_return_value)
4824         (thread_fsm_set_finished, thread_fsm_finished_p)
4825         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4826         Don't declare.
4827         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4828         * infrun.c (clear_proceed_status_thread)
4829         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4830         (print_stop_event): Update.
4831         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4832         Add constructor.
4833         (step_command_fsm_ops): Remove.
4834         (new_step_command_fsm): Remove.
4835         (step_1): Update.
4836         (step_command_fsm::should_stop): Rename from
4837         step_command_fsm_should_stop.
4838         (step_command_fsm::clean_up): Rename from
4839         step_command_fsm_clean_up.
4840         (step_command_fsm::do_async_reply_reason): Rename from
4841         step_command_fsm_async_reply_reason.
4842         (struct until_next_fsm): Inherit from thread_fsm.  Add
4843         constructor.
4844         (until_next_fsm_ops): Remove.
4845         (new_until_next_fsm): Remove.
4846         (until_next_fsm::should_stop): Rename from
4847         until_next_fsm_should_stop.
4848         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4849         (until_next_fsm::do_async_reply_reason): Rename from
4850         until_next_fsm_async_reply_reason.
4851         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4852         constructor.  Change type of breakpoint.
4853         (finish_command_fsm_ops): Remove.
4854         (new_finish_command_fsm): Remove.
4855         (finish_command_fsm::should_stop): Rename from
4856         finish_command_fsm_should_stop.
4857         (finish_command_fsm::clean_up): Rename from
4858         finish_command_fsm_clean_up.
4859         (finish_command_fsm::return_value): Rename from
4860         finish_command_fsm_return_value.
4861         (finish_command_fsm::do_async_reply_reason): Rename from
4862         finish_command_fsm_async_reply_reason.
4863         (finish_command): Update.
4864         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4865         Add constructor.
4866         (call_thread_fsm_ops): Remove.
4867         (call_thread_fsm::call_thread_fsm): Rename from
4868         new_call_thread_fsm.
4869         (call_thread_fsm::should_stop): Rename from
4870         call_thread_fsm_should_stop.
4871         (call_thread_fsm::should_notify_stop): Rename from
4872         call_thread_fsm_should_notify_stop.
4873         (run_inferior_call, call_function_by_hand_dummy): Update.
4874         * cli/cli-interp.c (should_print_stop_to_console): Update.
4875         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4876         Add constructor.  Change type of location_breakpoint,
4877         caller_breakpoint.
4878         (until_break_fsm_ops): Remove.
4879         (new_until_break_fsm): Remove.
4880         (until_break_fsm::should_stop): Rename from
4881         until_break_fsm_should_stop.
4882         (until_break_fsm::clean_up): Rename from
4883         until_break_fsm_clean_up.
4884         (until_break_fsm::do_async_reply_reason): Rename from
4885         until_break_fsm_async_reply_reason.
4886         (until_break_command): Update.
4887         * thread-fsm.c: Remove.
4888         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4889
4890 2019-02-07  Tom Tromey  <tom@tromey.com>
4891
4892         * yy-remap.h: Add include guard.
4893         * xtensa-tdep.h: Add include guard.
4894         * xcoffread.h: Rename include guard.
4895         * varobj-iter.h: Add include guard.
4896         * tui/tui.h: Rename include guard.
4897         * tui/tui-winsource.h: Rename include guard.
4898         * tui/tui-wingeneral.h: Rename include guard.
4899         * tui/tui-windata.h: Rename include guard.
4900         * tui/tui-win.h: Rename include guard.
4901         * tui/tui-stack.h: Rename include guard.
4902         * tui/tui-source.h: Rename include guard.
4903         * tui/tui-regs.h: Rename include guard.
4904         * tui/tui-out.h: Rename include guard.
4905         * tui/tui-layout.h: Rename include guard.
4906         * tui/tui-io.h: Rename include guard.
4907         * tui/tui-hooks.h: Rename include guard.
4908         * tui/tui-file.h: Rename include guard.
4909         * tui/tui-disasm.h: Rename include guard.
4910         * tui/tui-data.h: Rename include guard.
4911         * tui/tui-command.h: Rename include guard.
4912         * tic6x-tdep.h: Add include guard.
4913         * target/waitstatus.h: Rename include guard.
4914         * target/wait.h: Rename include guard.
4915         * target/target.h: Rename include guard.
4916         * target/resume.h: Rename include guard.
4917         * target-float.h: Rename include guard.
4918         * stabsread.h: Add include guard.
4919         * rs6000-tdep.h: Add include guard.
4920         * riscv-fbsd-tdep.h: Add include guard.
4921         * regformats/regdef.h: Rename include guard.
4922         * record.h: Rename include guard.
4923         * python/python.h: Rename include guard.
4924         * python/python-internal.h: Rename include guard.
4925         * python/py-stopevent.h: Rename include guard.
4926         * python/py-ref.h: Rename include guard.
4927         * python/py-record.h: Rename include guard.
4928         * python/py-record-full.h: Rename include guard.
4929         * python/py-record-btrace.h: Rename include guard.
4930         * python/py-instruction.h: Rename include guard.
4931         * python/py-events.h: Rename include guard.
4932         * python/py-event.h: Rename include guard.
4933         * procfs.h: Add include guard.
4934         * proc-utils.h: Add include guard.
4935         * p-lang.h: Add include guard.
4936         * or1k-tdep.h: Rename include guard.
4937         * observable.h: Rename include guard.
4938         * nto-tdep.h: Rename include guard.
4939         * nat/x86-linux.h: Rename include guard.
4940         * nat/x86-linux-dregs.h: Rename include guard.
4941         * nat/x86-gcc-cpuid.h: Add include guard.
4942         * nat/x86-dregs.h: Rename include guard.
4943         * nat/x86-cpuid.h: Rename include guard.
4944         * nat/ppc-linux.h: Rename include guard.
4945         * nat/mips-linux-watch.h: Rename include guard.
4946         * nat/linux-waitpid.h: Rename include guard.
4947         * nat/linux-ptrace.h: Rename include guard.
4948         * nat/linux-procfs.h: Rename include guard.
4949         * nat/linux-osdata.h: Rename include guard.
4950         * nat/linux-nat.h: Rename include guard.
4951         * nat/linux-namespaces.h: Rename include guard.
4952         * nat/linux-btrace.h: Rename include guard.
4953         * nat/glibc_thread_db.h: Rename include guard.
4954         * nat/gdb_thread_db.h: Rename include guard.
4955         * nat/gdb_ptrace.h: Rename include guard.
4956         * nat/fork-inferior.h: Rename include guard.
4957         * nat/amd64-linux-siginfo.h: Rename include guard.
4958         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4959         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4960         * nat/aarch64-linux.h: Rename include guard.
4961         * nat/aarch64-linux-hw-point.h: Rename include guard.
4962         * mn10300-tdep.h: Add include guard.
4963         * mips-linux-tdep.h: Add include guard.
4964         * mi/mi-parse.h: Rename include guard.
4965         * mi/mi-out.h: Rename include guard.
4966         * mi/mi-main.h: Rename include guard.
4967         * mi/mi-interp.h: Rename include guard.
4968         * mi/mi-getopt.h: Rename include guard.
4969         * mi/mi-console.h: Rename include guard.
4970         * mi/mi-common.h: Rename include guard.
4971         * mi/mi-cmds.h: Rename include guard.
4972         * mi/mi-cmd-break.h: Rename include guard.
4973         * m2-lang.h: Add include guard.
4974         * location.h: Rename include guard.
4975         * linux-record.h: Rename include guard.
4976         * linux-nat.h: Add include guard.
4977         * linux-fork.h: Add include guard.
4978         * i386-darwin-tdep.h: Rename include guard.
4979         * hppa-linux-offsets.h: Add include guard.
4980         * guile/guile.h: Rename include guard.
4981         * guile/guile-internal.h: Rename include guard.
4982         * gnu-nat.h: Rename include guard.
4983         * gdb-stabs.h: Rename include guard.
4984         * frv-tdep.h: Add include guard.
4985         * f-lang.h: Add include guard.
4986         * event-loop.h: Add include guard.
4987         * darwin-nat.h: Rename include guard.
4988         * cp-abi.h: Rename include guard.
4989         * config/sparc/nm-sol2.h: Rename include guard.
4990         * config/nm-nto.h: Rename include guard.
4991         * config/nm-linux.h: Add include guard.
4992         * config/i386/nm-i386gnu.h: Rename include guard.
4993         * config/djgpp/nl_types.h: Rename include guard.
4994         * config/djgpp/langinfo.h: Rename include guard.
4995         * compile/gcc-cp-plugin.h: Add include guard.
4996         * compile/gcc-c-plugin.h: Add include guard.
4997         * compile/compile.h: Rename include guard.
4998         * compile/compile-object-run.h: Rename include guard.
4999         * compile/compile-object-load.h: Rename include guard.
5000         * compile/compile-internal.h: Rename include guard.
5001         * compile/compile-cplus.h: Rename include guard.
5002         * compile/compile-c.h: Rename include guard.
5003         * common/xml-utils.h: Rename include guard.
5004         * common/x86-xstate.h: Rename include guard.
5005         * common/version.h: Rename include guard.
5006         * common/vec.h: Rename include guard.
5007         * common/tdesc.h: Rename include guard.
5008         * common/selftest.h: Rename include guard.
5009         * common/scoped_restore.h: Rename include guard.
5010         * common/scoped_mmap.h: Rename include guard.
5011         * common/scoped_fd.h: Rename include guard.
5012         * common/safe-iterator.h: Rename include guard.
5013         * common/run-time-clock.h: Rename include guard.
5014         * common/refcounted-object.h: Rename include guard.
5015         * common/queue.h: Rename include guard.
5016         * common/ptid.h: Rename include guard.
5017         * common/print-utils.h: Rename include guard.
5018         * common/preprocessor.h: Rename include guard.
5019         * common/pathstuff.h: Rename include guard.
5020         * common/observable.h: Rename include guard.
5021         * common/netstuff.h: Rename include guard.
5022         * common/job-control.h: Rename include guard.
5023         * common/host-defs.h: Rename include guard.
5024         * common/gdb_wait.h: Rename include guard.
5025         * common/gdb_vecs.h: Rename include guard.
5026         * common/gdb_unlinker.h: Rename include guard.
5027         * common/gdb_unique_ptr.h: Rename include guard.
5028         * common/gdb_tilde_expand.h: Rename include guard.
5029         * common/gdb_sys_time.h: Rename include guard.
5030         * common/gdb_string_view.h: Rename include guard.
5031         * common/gdb_splay_tree.h: Rename include guard.
5032         * common/gdb_setjmp.h: Rename include guard.
5033         * common/gdb_ref_ptr.h: Rename include guard.
5034         * common/gdb_optional.h: Rename include guard.
5035         * common/gdb_locale.h: Rename include guard.
5036         * common/gdb_assert.h: Rename include guard.
5037         * common/filtered-iterator.h: Rename include guard.
5038         * common/filestuff.h: Rename include guard.
5039         * common/fileio.h: Rename include guard.
5040         * common/environ.h: Rename include guard.
5041         * common/common-utils.h: Rename include guard.
5042         * common/common-types.h: Rename include guard.
5043         * common/common-regcache.h: Rename include guard.
5044         * common/common-inferior.h: Rename include guard.
5045         * common/common-gdbthread.h: Rename include guard.
5046         * common/common-exceptions.h: Rename include guard.
5047         * common/common-defs.h: Rename include guard.
5048         * common/common-debug.h: Rename include guard.
5049         * common/cleanups.h: Rename include guard.
5050         * common/buffer.h: Rename include guard.
5051         * common/btrace-common.h: Rename include guard.
5052         * common/break-common.h: Rename include guard.
5053         * cli/cli-utils.h: Rename include guard.
5054         * cli/cli-style.h: Rename include guard.
5055         * cli/cli-setshow.h: Rename include guard.
5056         * cli/cli-script.h: Rename include guard.
5057         * cli/cli-interp.h: Rename include guard.
5058         * cli/cli-decode.h: Rename include guard.
5059         * cli/cli-cmds.h: Rename include guard.
5060         * charset-list.h: Add include guard.
5061         * buildsym-legacy.h: Rename include guard.
5062         * bfin-tdep.h: Add include guard.
5063         * ax.h: Rename include guard.
5064         * arm-linux-tdep.h: Add include guard.
5065         * arm-fbsd-tdep.h: Add include guard.
5066         * arch/xtensa.h: Rename include guard.
5067         * arch/tic6x.h: Add include guard.
5068         * arch/i386.h: Add include guard.
5069         * arch/arm.h: Rename include guard.
5070         * arch/arm-linux.h: Rename include guard.
5071         * arch/arm-get-next-pcs.h: Rename include guard.
5072         * arch/amd64.h: Add include guard.
5073         * arch/aarch64-insn.h: Rename include guard.
5074         * arch-utils.h: Rename include guard.
5075         * annotate.h: Add include guard.
5076         * amd64-darwin-tdep.h: Rename include guard.
5077         * aarch64-linux-tdep.h: Add include guard.
5078         * aarch64-fbsd-tdep.h: Add include guard.
5079         * aarch32-linux-nat.h: Add include guard.
5080
5081 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5082
5083         * macrotab.c (macro_define_internal): New function that
5084         factorizes macro_define_object_internal and macro_define_function
5085         code.
5086         (macro_define_object_internal): Use macro_define_internal.
5087         (macro_define_function): Likewise.
5088
5089 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5090
5091         * macrocmd.c (extract_identifier): Return
5092         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5093         callers.
5094
5095 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5096
5097         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5098
5099 2019-02-05  Tom Tromey  <tom@tromey.com>
5100
5101         * target.c (target_stack::unpush): Move assertion earlier.
5102
5103 2019-01-30  Tom Tromey  <tom@tromey.com>
5104
5105         PR python/23615:
5106         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5107         (gdbpy_parse_and_eval): Likewise.
5108         * python/python-internal.h (gdbpy_allow_threads): New class.
5109
5110 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5111
5112         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5113         (aarch64_fbsd_fpregmap): Move earlier.
5114         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5115         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5116         instead of individual calls to trad_frame_set_reg_addr.
5117         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5118         earlier.
5119         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5120         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5121         instead of individual calls to trad_frame_set_reg_addr.
5122
5123 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5124
5125         * CONTRIBUTE: Replace contribution list with wiki link.
5126
5127 2019-01-25  Tom Tromey  <tom@tromey.com>
5128
5129         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5130
5131 2019-01-25  Tom Tromey  <tom@tromey.com>
5132
5133         * xtensa-linux-nat.c: Fix common/ includes.
5134         * xml-support.h: Fix common/ includes.
5135         * xml-support.c: Fix common/ includes.
5136         * x86-linux-nat.c: Fix common/ includes.
5137         * windows-nat.c: Fix common/ includes.
5138         * varobj.h: Fix common/ includes.
5139         * varobj.c: Fix common/ includes.
5140         * value.c: Fix common/ includes.
5141         * valops.c: Fix common/ includes.
5142         * utils.c: Fix common/ includes.
5143         * unittests/xml-utils-selftests.c: Fix common/ includes.
5144         * unittests/utils-selftests.c: Fix common/ includes.
5145         * unittests/unpack-selftests.c: Fix common/ includes.
5146         * unittests/tracepoint-selftests.c: Fix common/ includes.
5147         * unittests/style-selftests.c: Fix common/ includes.
5148         * unittests/string_view-selftests.c: Fix common/ includes.
5149         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5150         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5151         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5152         * unittests/rsp-low-selftests.c: Fix common/ includes.
5153         * unittests/parse-connection-spec-selftests.c: Fix common/
5154         includes.
5155         * unittests/optional-selftests.c: Fix common/ includes.
5156         * unittests/offset-type-selftests.c: Fix common/ includes.
5157         * unittests/observable-selftests.c: Fix common/ includes.
5158         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5159         * unittests/memrange-selftests.c: Fix common/ includes.
5160         * unittests/memory-map-selftests.c: Fix common/ includes.
5161         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5162         * unittests/function-view-selftests.c: Fix common/ includes.
5163         * unittests/environ-selftests.c: Fix common/ includes.
5164         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5165         * unittests/common-utils-selftests.c: Fix common/ includes.
5166         * unittests/cli-utils-selftests.c: Fix common/ includes.
5167         * unittests/array-view-selftests.c: Fix common/ includes.
5168         * ui-file.c: Fix common/ includes.
5169         * tui/tui-io.c: Fix common/ includes.
5170         * tracepoint.h: Fix common/ includes.
5171         * tracepoint.c: Fix common/ includes.
5172         * tracefile-tfile.c: Fix common/ includes.
5173         * top.h: Fix common/ includes.
5174         * top.c: Fix common/ includes.
5175         * thread.c: Fix common/ includes.
5176         * target/waitstatus.h: Fix common/ includes.
5177         * target/waitstatus.c: Fix common/ includes.
5178         * target.h: Fix common/ includes.
5179         * target.c: Fix common/ includes.
5180         * target-memory.c: Fix common/ includes.
5181         * target-descriptions.c: Fix common/ includes.
5182         * symtab.h: Fix common/ includes.
5183         * symfile.c: Fix common/ includes.
5184         * stap-probe.c: Fix common/ includes.
5185         * spu-linux-nat.c: Fix common/ includes.
5186         * sparc-nat.c: Fix common/ includes.
5187         * source.c: Fix common/ includes.
5188         * solib.c: Fix common/ includes.
5189         * solib-target.c: Fix common/ includes.
5190         * ser-unix.c: Fix common/ includes.
5191         * ser-tcp.c: Fix common/ includes.
5192         * ser-pipe.c: Fix common/ includes.
5193         * ser-base.c: Fix common/ includes.
5194         * selftest-arch.c: Fix common/ includes.
5195         * s12z-tdep.c: Fix common/ includes.
5196         * rust-exp.y: Fix common/ includes.
5197         * rs6000-aix-tdep.c: Fix common/ includes.
5198         * riscv-tdep.c: Fix common/ includes.
5199         * remote.c: Fix common/ includes.
5200         * remote-notif.h: Fix common/ includes.
5201         * remote-fileio.h: Fix common/ includes.
5202         * remote-fileio.c: Fix common/ includes.
5203         * regcache.h: Fix common/ includes.
5204         * regcache.c: Fix common/ includes.
5205         * record-btrace.c: Fix common/ includes.
5206         * python/python.c: Fix common/ includes.
5207         * python/py-type.c: Fix common/ includes.
5208         * python/py-inferior.c: Fix common/ includes.
5209         * progspace.h: Fix common/ includes.
5210         * producer.c: Fix common/ includes.
5211         * procfs.c: Fix common/ includes.
5212         * proc-api.c: Fix common/ includes.
5213         * printcmd.c: Fix common/ includes.
5214         * ppc-linux-nat.c: Fix common/ includes.
5215         * parser-defs.h: Fix common/ includes.
5216         * osdata.c: Fix common/ includes.
5217         * obsd-nat.c: Fix common/ includes.
5218         * nat/x86-linux.c: Fix common/ includes.
5219         * nat/x86-linux-dregs.c: Fix common/ includes.
5220         * nat/x86-dregs.h: Fix common/ includes.
5221         * nat/x86-dregs.c: Fix common/ includes.
5222         * nat/ppc-linux.c: Fix common/ includes.
5223         * nat/mips-linux-watch.h: Fix common/ includes.
5224         * nat/mips-linux-watch.c: Fix common/ includes.
5225         * nat/linux-waitpid.c: Fix common/ includes.
5226         * nat/linux-ptrace.h: Fix common/ includes.
5227         * nat/linux-ptrace.c: Fix common/ includes.
5228         * nat/linux-procfs.c: Fix common/ includes.
5229         * nat/linux-personality.c: Fix common/ includes.
5230         * nat/linux-osdata.c: Fix common/ includes.
5231         * nat/linux-namespaces.c: Fix common/ includes.
5232         * nat/linux-btrace.h: Fix common/ includes.
5233         * nat/linux-btrace.c: Fix common/ includes.
5234         * nat/fork-inferior.c: Fix common/ includes.
5235         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5236         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5237         * nat/aarch64-linux.c: Fix common/ includes.
5238         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5239         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5240         * namespace.h: Fix common/ includes.
5241         * mips-linux-tdep.c: Fix common/ includes.
5242         * minsyms.c: Fix common/ includes.
5243         * mi/mi-parse.h: Fix common/ includes.
5244         * mi/mi-main.c: Fix common/ includes.
5245         * mi/mi-cmd-env.c: Fix common/ includes.
5246         * memrange.h: Fix common/ includes.
5247         * memattr.c: Fix common/ includes.
5248         * maint.h: Fix common/ includes.
5249         * maint.c: Fix common/ includes.
5250         * main.c: Fix common/ includes.
5251         * machoread.c: Fix common/ includes.
5252         * location.c: Fix common/ includes.
5253         * linux-thread-db.c: Fix common/ includes.
5254         * linux-nat.c: Fix common/ includes.
5255         * linux-fork.c: Fix common/ includes.
5256         * inline-frame.c: Fix common/ includes.
5257         * infrun.c: Fix common/ includes.
5258         * inflow.c: Fix common/ includes.
5259         * inferior.h: Fix common/ includes.
5260         * inferior.c: Fix common/ includes.
5261         * infcmd.c: Fix common/ includes.
5262         * inf-ptrace.c: Fix common/ includes.
5263         * inf-child.c: Fix common/ includes.
5264         * ia64-linux-nat.c: Fix common/ includes.
5265         * i387-tdep.c: Fix common/ includes.
5266         * i386-tdep.c: Fix common/ includes.
5267         * i386-linux-tdep.c: Fix common/ includes.
5268         * i386-linux-nat.c: Fix common/ includes.
5269         * i386-go32-tdep.c: Fix common/ includes.
5270         * i386-fbsd-tdep.c: Fix common/ includes.
5271         * i386-fbsd-nat.c: Fix common/ includes.
5272         * guile/scm-type.c: Fix common/ includes.
5273         * guile/guile.c: Fix common/ includes.
5274         * go32-nat.c: Fix common/ includes.
5275         * gnu-nat.c: Fix common/ includes.
5276         * gdbthread.h: Fix common/ includes.
5277         * gdbarch-selftests.c: Fix common/ includes.
5278         * gdb_usleep.c: Fix common/ includes.
5279         * gdb_select.h: Fix common/ includes.
5280         * gdb_bfd.c: Fix common/ includes.
5281         * gcore.c: Fix common/ includes.
5282         * fork-child.c: Fix common/ includes.
5283         * findvar.c: Fix common/ includes.
5284         * fbsd-nat.c: Fix common/ includes.
5285         * event-top.c: Fix common/ includes.
5286         * event-loop.c: Fix common/ includes.
5287         * dwarf2read.c: Fix common/ includes.
5288         * dwarf2loc.c: Fix common/ includes.
5289         * dwarf2-frame.c: Fix common/ includes.
5290         * dwarf-index-cache.c: Fix common/ includes.
5291         * dtrace-probe.c: Fix common/ includes.
5292         * disasm-selftests.c: Fix common/ includes.
5293         * defs.h: Fix common/ includes.
5294         * csky-tdep.c: Fix common/ includes.
5295         * cp-valprint.c: Fix common/ includes.
5296         * cp-support.h: Fix common/ includes.
5297         * cp-support.c: Fix common/ includes.
5298         * corelow.c: Fix common/ includes.
5299         * completer.h: Fix common/ includes.
5300         * completer.c: Fix common/ includes.
5301         * compile/compile.c: Fix common/ includes.
5302         * compile/compile-loc2c.c: Fix common/ includes.
5303         * compile/compile-cplus-types.c: Fix common/ includes.
5304         * compile/compile-cplus-symbols.c: Fix common/ includes.
5305         * command.h: Fix common/ includes.
5306         * cli/cli-dump.c: Fix common/ includes.
5307         * cli/cli-cmds.c: Fix common/ includes.
5308         * charset.c: Fix common/ includes.
5309         * build-id.c: Fix common/ includes.
5310         * btrace.h: Fix common/ includes.
5311         * btrace.c: Fix common/ includes.
5312         * breakpoint.h: Fix common/ includes.
5313         * breakpoint.c: Fix common/ includes.
5314         * ax.h:
5315         (enum agent_op): Fix common/ includes.
5316         * ax-general.c (struct aop_map): Fix common/ includes.
5317         * ax-gdb.c: Fix common/ includes.
5318         * auxv.c: Fix common/ includes.
5319         * auto-load.c: Fix common/ includes.
5320         * arm-tdep.c: Fix common/ includes.
5321         * arch/riscv.c: Fix common/ includes.
5322         * arch/ppc-linux-common.c: Fix common/ includes.
5323         * arch/i386.c: Fix common/ includes.
5324         * arch/arm.c: Fix common/ includes.
5325         * arch/arm-linux.c: Fix common/ includes.
5326         * arch/arm-get-next-pcs.c: Fix common/ includes.
5327         * arch/amd64.c: Fix common/ includes.
5328         * arch/aarch64.c: Fix common/ includes.
5329         * arch/aarch64-insn.c: Fix common/ includes.
5330         * arch-utils.c: Fix common/ includes.
5331         * amd64-windows-tdep.c: Fix common/ includes.
5332         * amd64-tdep.c: Fix common/ includes.
5333         * amd64-sol2-tdep.c: Fix common/ includes.
5334         * amd64-obsd-tdep.c: Fix common/ includes.
5335         * amd64-nbsd-tdep.c: Fix common/ includes.
5336         * amd64-linux-tdep.c: Fix common/ includes.
5337         * amd64-linux-nat.c: Fix common/ includes.
5338         * amd64-fbsd-tdep.c: Fix common/ includes.
5339         * amd64-fbsd-nat.c: Fix common/ includes.
5340         * amd64-dicos-tdep.c: Fix common/ includes.
5341         * amd64-darwin-tdep.c: Fix common/ includes.
5342         * agent.c: Fix common/ includes.
5343         * ada-lang.h: Fix common/ includes.
5344         * ada-lang.c: Fix common/ includes.
5345         * aarch64-tdep.c: Fix common/ includes.
5346
5347 2019-01-25  Tom Tromey  <tom@tromey.com>
5348
5349         * common/create-version.sh: Use common/version.h.
5350
5351 2019-01-24  Pedro Alves  <palves@redhat.com>
5352
5353         * infrun.c (signal_stop, signal_print, signal_program)
5354         (signal_catch, signal_pass): Now arrays instead of pointers.
5355         (update_signals_program_target, do_target_resume)
5356         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5357         * linux-nat.c (linux_nat_target::pass_signals)
5358         (linux_nat_target::create_inferior, linux_nat_target::attach):
5359         Adjust.
5360         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5361         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5362         * procfs.c (procfs_target::pass_signals): Adjust.
5363         * record-full.c (record_full_target::resume): Adjust.
5364         * remote.c (remote_target::pass_signals)
5365         (remote_target::program_signals): Adjust.
5366         * target-debug.h (target_debug_print_signals): Now takes a
5367         gdb::array_view as parameter.  Adjust.
5368         * target.h (target_ops) <pass_signals, program_signals>: Replace
5369         pointer and length parameters with gdb::array_view.
5370         (target_pass_signals, target_program_signals): Likewise.
5371         * target-delegates.c: Regenerate.
5372
5373 2019-01-24  Pedro Alves  <palves@redhat.com>
5374
5375         * common/forward-scope-exit.h
5376         (forward_scope_exit::forward_scope_exit): Pass arguments to
5377         m_bind_function directly, instead of creating a std::bind and
5378         copying that.
5379
5380 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5381
5382         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5383         for static members.
5384         (pass_in_v_vfp_candidate): Likewise.
5385
5386 2019-01-23  Tom Tromey  <tom@tromey.com>
5387             Pedro Alves  <palves@redhat.com>
5388
5389         * regcache.c (class regcache_invalidator): Remove.
5390         (regcache::raw_write): Use make_scope_exit.
5391
5392 2019-01-23  Tom Tromey  <tom@tromey.com>
5393
5394         * ui-out.h (class ui_out_emit_type): Update comment.
5395
5396 2019-01-23  Tom Tromey  <tom@tromey.com>
5397
5398         * infrun.c (fetch_inferior_event): Update comment.
5399
5400 2019-01-23  Tom Tromey  <tom@tromey.com>
5401             Pedro Alves  <palves@redhat.com>
5402
5403         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5404         parameter.
5405         (fetch_inferior_event): Use SCOPE_EXIT.
5406
5407
5408 2019-01-23  Tom Tromey  <tom@tromey.com>
5409             Pedro Alves  <palves@redhat.com>
5410
5411         * infrun.c (disable_thread_events): Delete.
5412         (stop_all_threads): Use SCOPE_EXIT.
5413
5414 2019-01-23  Tom Tromey  <tom@tromey.com>
5415             Pedro Alves  <palves@redhat.com>
5416
5417         * symfile.c: Include forward-scope-exit.h.
5418         (clear_symtab_users_cleanup): Replace forward declaration with
5419         a FORWARD_SCOPE_EXIT.
5420         (syms_from_objfile_1): Use the forward_scope_exit and
5421         gdb::optional instead of cleanup_function.
5422         (reread_symbols): Use the forward_scope_exit instead of
5423         cleanup_function.
5424         (clear_symtab_users_cleanup): Remove function.
5425
5426 2019-01-23  Tom Tromey  <tom@tromey.com>
5427             Pedro Alves  <palves@redhat.com>
5428
5429         * linux-nat.c: Include scope-exit.h.
5430         (cleanup_target_stop): Remove.
5431         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5432         SCOPE_EXIT.
5433
5434 2019-01-23  Tom Tromey  <tom@tromey.com>
5435             Pedro Alves  <palves@redhat.com>
5436
5437         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5438         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5439
5440 2019-01-23  Tom Tromey  <tom@tromey.com>
5441             Andrew Burgess  <andrew.burgess@embecosm.com>
5442             Pedro Alves  <palves@redhat.com>
5443
5444         * infrun.c (fetch_inferior_event): Use scope_exit.
5445         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5446         * top.c (execute_command): Use scope_exit.
5447         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5448         * utils.c (do_bpstat_clear_actions_cleanup)
5449         (make_bpstat_clear_actions_cleanup): Remove.
5450
5451 2019-01-23  Tom Tromey  <tom@tromey.com>
5452             Pedro Alves  <palves@redhat.com>
5453
5454         * infrun.c: Include "common/scope-exit.h"
5455         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5456         (wait_for_inferior): Use SCOPE_EXIT.
5457         (fetch_inferior_event): Use scope_exit.
5458
5459 2019-01-23  Tom Tromey  <tom@tromey.com>
5460             Pedro Alves  <palves@redhat.com>
5461
5462         * breakpoint.c (create_breakpoint): Remove cleanup.
5463
5464 2019-01-23  Tom Tromey  <tom@tromey.com>
5465             Andrew Burgess  <andrew.burgess@embecosm.com>
5466             Pedro Alves  <palves@redhat.com>
5467
5468 2019-01-23  Pedro Alves  <palves@redhat.com>
5469
5470         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5471
5472 2019-01-23  Pedro Alves  <palves@redhat.com>
5473             Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * gdbthread.h: Include "common/forward-scope-exit.h".
5476         (scoped_finish_thread_state): Redefine custom class in terms of
5477         forward_scope_exit.
5478
5479 2019-01-23  Pedro Alves  <palves@redhat.com>
5480             Andrew Burgess  <andrew.burgess@embecosm.com>
5481
5482         * common/forward-scope-exit.h: New file.
5483
5484 2019-01-23  Pedro Alves  <palves@redhat.com>
5485             Andrew Burgess  <andrew.burgess@embecosm.com>
5486             Tom Tromey  <tom@tromey.com>
5487
5488         * common/scope-exit.h: New file.
5489
5490 2019-01-23  Pedro Alves  <palves@redhat.com>
5491
5492         * common/preprocessor.h (ESC): Rename to ...
5493         (ESC_PARENS): ... this.
5494         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5495         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5496
5497 2019-01-23  Tom Tromey  <tom@tromey.com>
5498
5499         * language.h (class scoped_switch_to_sym_language_if_auto):
5500         Initialize m_lang in both cases.
5501
5502 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5503
5504         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5505         with XCNEW.
5506
5507 2019-01-22  Tom Tromey  <tom@tromey.com>
5508
5509         * corelow.c: Do not include sys/file.h.
5510
5511 2019-01-22  Tom Tromey  <tom@tromey.com>
5512
5513         * tui/tui-wingeneral.h: Include gdb_curses.h.
5514
5515 2019-01-22  Tom Tromey  <tom@tromey.com>
5516
5517         * source-cache.h (class source_cache) <get_source_lines,
5518         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5519
5520 2019-01-22  Tom Tromey  <tom@tromey.com>
5521
5522         * remote-fileio.h (struct remote_target): Declare.
5523
5524 2019-01-22  Tom Tromey  <tom@tromey.com>
5525
5526         * python/py-arch.c: Do not include py-ref.h.
5527         * python/py-bpevent.c: Do not include py-ref.h.
5528         * python/py-cmd.c: Do not include py-ref.h.
5529         * python/py-continueevent.c: Do not include py-ref.h.
5530         * python/py-event.h: Do not include py-ref.h.
5531         * python/py-evtregistry.c: Do not include py-ref.h.
5532         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5533         * python/py-frame.c: Do not include py-ref.h.
5534         * python/py-framefilter.c: Do not include py-ref.h.
5535         * python/py-function.c: Do not include py-ref.h.
5536         * python/py-infevents.c: Do not include py-ref.h.
5537         * python/py-linetable.c: Do not include py-ref.h.
5538         * python/py-objfile.c: Do not include py-ref.h.
5539         * python/py-param.c: Do not include py-ref.h.
5540         * python/py-prettyprint.c: Do not include py-ref.h.
5541         * python/py-progspace.c: Do not include py-ref.h.
5542         * python/py-symbol.c: Do not include py-ref.h.
5543         * python/py-symtab.c: Do not include py-ref.h.
5544         * python/py-type.c: Do not include py-ref.h.
5545         * python/py-unwind.c: Do not include py-ref.h.
5546         * python/py-utils.c: Do not include py-ref.h.
5547         * python/py-value.c: Do not include py-ref.h.
5548         * python/py-varobj.c: Do not include py-ref.h.
5549         * python/py-xmethods.c: Do not include py-ref.h.
5550         * python/python.c: Do not include py-ref.h.
5551         * varobj.c: Do not include py-ref.h.
5552
5553 2019-01-22  Tom Tromey  <tom@tromey.com>
5554
5555         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5556         keyword for bcache.
5557
5558 2019-01-22  Tom Tromey  <tom@tromey.com>
5559
5560         * compile/compile-cplus-types.c: Remove a comment by #include.
5561
5562 2019-01-22  Tom Tromey  <tom@tromey.com>
5563
5564         * compile/gcc-c-plugin.h: Include compile-internal.h.
5565
5566 2019-01-22  Tom Tromey  <tom@tromey.com>
5567
5568         * stabsread.c (EXTERN): Do not define.
5569         (symnum, next_symbol_text_func, processing_gcc_compilation)
5570         (within_function, global_sym_chain, global_stabs)
5571         (previous_stab_code, this_object_header_files)
5572         (n_this_object_header_files)
5573         (n_allocated_this_object_header_files): Define.
5574         * stabsread.h (EXTERN): Never define.  Use "extern".
5575
5576 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5577
5578         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5579         history_value.
5580
5581 2019-01-21  Tom Tromey  <tom@tromey.com>
5582
5583         * ui-out.c: Fix includes.
5584         * tui/tui-source.c: Fix includes.
5585         * target.c: Fix includes.
5586         * remote.c: Fix includes.
5587         * regcache.c: Fix includes.
5588         * python/py-block.c: Fix includes.
5589         * printcmd.c: Fix includes.
5590         * or1k-tdep.c: Fix includes.
5591         * mi/mi-main.c: Fix includes.
5592         * m32r-tdep.c: Fix includes.
5593         * csky-tdep.c: Fix includes.
5594         * compile/compile-cplus-types.c: Fix includes.
5595         * cli/cli-interp.c: Fix includes.
5596
5597 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5598
5599         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5600         for padding.
5601
5602 2019-01-16  Tom Tromey  <tom@tromey.com>
5603
5604         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5605         earlier.
5606         (struct objfile) <msymbols_range>: Move from top level.
5607         <msymbols>: New method.
5608         (class objfile_msymbols): Remove.
5609         * symtab.c (default_collect_symbol_completion_matches_break_on):
5610         Update.
5611         * symmisc.c (dump_msymbols): Update.
5612         * stabsread.c (scan_file_globals): Update.
5613         * objc-lang.c (info_selectors_command, info_classes_command)
5614         (find_methods): Update.
5615         * minsyms.c (find_solib_trampoline_target): Update.
5616         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5617         * coffread.c (coff_symfile_read): Update.
5618         * ada-lang.c (ada_lookup_simple_minsym)
5619         (ada_collect_symbol_completion_matches): Update.
5620
5621 2019-01-16  Tom Tromey  <tom@tromey.com>
5622
5623         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5624         type.  Remove no-argument constructor.
5625         <iterator::operator++>: Simplify.
5626         <begin>: Update.
5627         <end>: Use minimal_symbol_count.
5628
5629 2019-01-16  Tom Tromey  <tom@tromey.com>
5630
5631         * objfiles.h (struct objfile) <psymtabs>: New method.
5632         (class objfile_psymtabs): Remove.
5633         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5634         typedef.
5635         <range>: New method.
5636         (require_partial_symbols): Change return type.
5637         * psymtab.c (require_partial_symbols)
5638         (psym_expand_symtabs_matching): Update.
5639         * mdebugread.c (parse_partial_symbols): Update.
5640         * dbxread.c (dbx_end_psymtab): Update.
5641
5642 2019-01-15  Tom Tromey  <tom@tromey.com>
5643
5644         * symtab.c (lookup_objfile_from_block)
5645         (lookup_symbol_in_objfile_symtabs)
5646         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5647         (find_line_symtab, info_sources_command)
5648         (default_collect_symbol_completion_matches_break_on)
5649         (make_source_files_completion_list): Update.
5650         * symmisc.c (print_objfile_statistics, dump_objfile)
5651         (maintenance_print_symbols, maintenance_info_symtabs)
5652         (maintenance_check_symtabs, maintenance_info_line_tables):
5653         Update.
5654         * source.c (select_source_symtab)
5655         (forget_cached_source_info_for_objfile): Update.
5656         * objfiles.h (class objfile_compunits): Remove.
5657         (struct objfile) <compunits_range>: New typedef.
5658         (compunits): New method.
5659         * objfiles.c (objfile_relocate1): Update.
5660         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5661         * maint.c (count_symtabs_and_blocks): Update.
5662         * linespec.c (iterate_over_all_matching_symtabs): Update.
5663         * cp-support.c (add_symbol_overload_list_qualified): Update.
5664         * coffread.c (coff_symtab_read): Update.
5665         * ada-lang.c (add_nonlocal_symbols)
5666         (ada_collect_symbol_completion_matches)
5667         (ada_add_global_exceptions): Update.
5668
5669 2019-01-15  Tom Tromey  <tom@tromey.com>
5670
5671         * progspace.h (program_space) <objfiles_safe_range>: New
5672         typedef.
5673         <objfiles_safe>: New method.
5674         * objfiles.h (class all_objfiles_safe): Remove.
5675         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5676         * jit.c (jit_inferior_exit_hook): Update.
5677
5678 2019-01-17  Tom Tromey  <tom@tromey.com>
5679
5680         * progspace.h (program_space) <objfiles_range>: New typedef.
5681         <objfiles>: New method.
5682         <objfiles_head>: Rename from objfiles.
5683         (object_files): Update.
5684         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5685         * guile/scm-pretty-print.c
5686         (ppscm_find_pretty_printer_from_objfiles): Update.
5687         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5688         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5689         Update.
5690         * python/py-progspace.c (pspy_get_objfiles): Update.
5691         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5692         Update.
5693         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5694         (objfpy_lookup_objfile_by_build_id): Update.
5695         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5696         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5697         Update.
5698         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5699         (expand_symtab_containing_pc, lookup_objfile_from_block)
5700         (lookup_static_symbol, basic_lookup_transparent_type)
5701         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5702         (find_line_symtab, info_sources_command)
5703         (default_collect_symbol_completion_matches_break_on)
5704         (make_source_files_completion_list, find_main_name): Update.
5705         * symmisc.c (print_symbol_bcache_statistics)
5706         (print_objfile_statistics, maintenance_print_symbols)
5707         (maintenance_print_msymbols, maintenance_print_objfiles)
5708         (maintenance_info_symtabs, maintenance_check_symtabs)
5709         (maintenance_expand_symtabs, maintenance_info_line_tables):
5710         Update.
5711         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5712         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5713         (map_overlay_command, unmap_overlay_command)
5714         (simple_overlay_update, expand_symtabs_matching)
5715         (map_symbol_filenames): Update.
5716         * symfile-debug.c (set_debug_symfile): Update.
5717         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5718         Update.
5719         * source.c (select_source_symtab, forget_cached_source_info):
5720         Update.
5721         * solib.c (solib_read_symbols): Update.
5722         * solib-spu.c (append_ocl_sos): Update.
5723         * psymtab.c (maintenance_print_psymbols)
5724         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5725         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5726         * printcmd.c (info_symbol_command): Update.
5727         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5728         Update.
5729         * objfiles.h (class all_objfiles): Remove.
5730         * objfiles.c (have_partial_symbols, have_full_symbols)
5731         (have_minimal_symbols, qsort_cmp, update_section_map)
5732         (shared_objfile_contains_address_p)
5733         (default_iterate_over_objfiles_in_search_order): Update.
5734         * objc-lang.c (info_selectors_command, info_classes_command)
5735         (find_methods): Update.
5736         * minsyms.c (find_solib_trampoline_target): Update.
5737         * maint.c (maintenance_info_sections)
5738         (maintenance_translate_address, count_symtabs_and_blocks):
5739         Update.
5740         * main.c (captured_main_1): Update.
5741         * linux-thread-db.c (try_thread_db_load_from_pdir)
5742         (has_libpthread): Update.
5743         * linespec.c (iterate_over_all_matching_symtabs)
5744         (search_minsyms_for_name): Update.
5745         * jit.c (jit_find_objf_with_entry_addr): Update.
5746         * hppa-tdep.c (find_unwind_entry)
5747         (hppa_lookup_stub_minimal_symbol): Update.
5748         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5749         Update.
5750         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5751         (elf_gnu_ifunc_resolve_by_got): Update.
5752         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5753         * dwarf-index-write.c (save_gdb_index_command): Update.
5754         * cp-support.c (add_symbol_overload_list_qualified): Update.
5755         * breakpoint.c (create_overlay_event_breakpoint)
5756         (create_longjmp_master_breakpoint)
5757         (create_std_terminate_master_breakpoint)
5758         (create_exception_master_breakpoint): Update.
5759         * blockframe.c (find_pc_partial_function): Update.
5760         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5761         (ada_collect_symbol_completion_matches)
5762         (ada_add_global_exceptions): Update.
5763
5764 2019-01-17  Tom Tromey  <tom@tromey.com>
5765
5766         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5767         declare VEC.
5768         (solib_target_parse_libraries): Change return type.
5769         (library_list_start_segment, library_list_start_section)
5770         (library_list_end_library, library_list_start_library); Update.
5771         (solib_target_free_library_list): Remove.
5772         (solib_target_parse_libraries): Remove cleanup.  Change return
5773         type.
5774         (solib_target_current_sos): Update.
5775
5776 2019-01-17  Tom Tromey  <tromey@bapiya>
5777
5778         * valprint.c: Replace "the the" with "the".
5779         * symtab.c: Replace "the the" with "the".
5780         * solib.c: Replace "the the" with "the".
5781         * solib-dsbt.c: Replace "the the" with "the".
5782         * linespec.c: Replace "the the" with "the".
5783         * dwarf2loc.h: Replace "the the" with "the".
5784         * amd64-windows-tdep.c: Replace "the the" with "the".
5785         * aarch64-tdep.c: Replace "the the" with "the".
5786
5787 2019-01-16  Keith Seitz  <keiths@redhat.com>
5788
5789         PR gdb/23773
5790         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5791         <builder>: Rename to ..
5792         <m_builder>: ... this and make private.
5793         (dwarf2_cu::get_builder): New method.  Change all users of
5794         `builder' to use this method.
5795         (dwarf2_start_symtab): Move to ...
5796         (dwarf2_cu::start_symtab): ... here.  Update all callers
5797         (setup_type_unit_groups): Move to ...
5798         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5799         callers.
5800         (dwarf2_cu::reset_builder): New method.
5801         (process_full_compunit, process_full_type_unit): Use
5802         dwarf2_cu::reset_builder.
5803         (follow_die_offset): Record the ancestor CU if it is different
5804         from the followed DIE's CU.
5805         (follow_die_sig_1): Likewise.
5806
5807 2019-01-15  Tom Tromey  <tom@tromey.com>
5808
5809         * remote.c (class remote_state) <buf>: Now a char_vector.
5810         <buf_size>: Remove.
5811         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5812         parameter.
5813         (remote_target::getpkt_or_notif_sane_1)
5814         (remote_target::getpkt_sane)
5815         (remote_target::getpkt_or_notif_sane): Likewise.
5816         (class remote_target) <putpkt>: New overload.
5817         (remote_target::read_frame): Change type of "buf_p".  Remove
5818         sizeof_p parameter.
5819         (packet_ok): New overload.
5820         (packet_check_result): New overload.
5821         Update all uses.
5822
5823 2019-01-14  Tom Tromey  <tom@tromey.com>
5824
5825         * remote-notif.c (handle_notification, remote_notif_ack)
5826         (remote_notif_parse): Make "buf" const.
5827         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5828         const.
5829         (remote_notif_parse, remote_notif_ack, handle_notification):
5830         Likewise.
5831         * remote.c (remote_notif_stop_parse): Make "buf" const.
5832         (remote_target::remote_parse_stop_reply): Make "buf" const.
5833         (remote_notif_stop_ack): Make "buf" const.
5834
5835 2019-01-14  Tom Tromey  <tom@tromey.com>
5836
5837         * remote.c (remote_console_output): Make parameter const.
5838
5839 2019-01-14  Tom Tromey  <tom@tromey.com>
5840
5841         * target-debug.h (target_debug_print_signals): Constify.
5842         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5843         * procfs.c (procfs_target::pass_signals): Update.
5844         * linux-nat.c (linux_nat_target::pass_signals): Update.
5845         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5846         * target-delegates.c: Rebuild.
5847         * remote.c (remote_target::program_signals): Update.
5848         (remote_target::pass_signals): Update.
5849         * target.c (target_pass_signals): Constify argument.
5850         (target_program_signals): Likewise.
5851         * target.h (struct target_ops) <pass_signals, program_signals>:
5852         Constify argument.
5853         (target_pass_signals, target_program_signals): Constify argument.
5854
5855 2019-01-14  Tom Tromey  <tom@tromey.com>
5856
5857         PR tui/28819:
5858         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5859
5860 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5861
5862         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5863         field.
5864         * rs6000-tdep.c: Include reggroups.h.
5865         (IS_V_ALIAS_PSEUDOREG): Define.
5866         (rs6000_register_name): Return names for the "vX" aliases.
5867         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5868         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5869         aliases.  Call default_register_reggroup_p for all other
5870         pseudo-registers.
5871         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5872         New functions.
5873         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5874         Handle "vX" aliases.
5875         (v_alias_pseudo_register_collect): New function.
5876         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5877         (rs6000_gdbarch_init): Initialize "vX" aliases as
5878         pseudo-registers.  Restore registration of
5879         rs6000_pseudo_register_reggroup_p with
5880         set_tdesc_pseudo_register_reggroup_p.
5881
5882 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5883
5884         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5885         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5886         set_gdbarch_num_pseudo_regs.
5887
5888 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889
5890         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5891         Remove arg prefixname, add do_set and do_show.
5892         Add member functions set_list and show_list.
5893         * cli/cli-style.c (class cli_style_option): Update accordingly.
5894         (style_set_list): Move to file scope.
5895         (style_show_list): Likewise.
5896         (set_style): Call help_list.
5897         (show_style): Call cmd_show_list.
5898         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5899         Update to use the new macro.
5900
5901 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5902
5903         * ada-lang.c (_initialize_ada_language): Expand the help text
5904         for the "catch exception" command.
5905
5906 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5907
5908         * symtab.c (matching_obj_sections): Initialize obj,
5909         declare it closer to its usage.
5910
5911 2019-01-10  Tom Tromey  <tom@tromey.com>
5912
5913         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5914         (basic_inf_threads_range): Remove.
5915         (inf_threads_range, inf_non_exited_threads_range)
5916         (safe_inf_threads_range): Use next_adapter.
5917
5918 2019-01-10  Keith Seitz  <keiths@redhat.com>
5919
5920         PR gdb/23712
5921         PR symtab/23010
5922         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5923         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5924
5925 2019-01-10  Keith Seitz  <keiths@redhat.com>
5926
5927         PR gdb/23712
5928         PR symtab/23010
5929         * dictionary.c (pending_to_vector): Remove.
5930         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5931         Remove _1 suffix, replacing functions of the same name.  Update
5932         all callers.
5933         (dict_create_hashed, dict_create_hashed_expandable)
5934         (dict_create_linear, dict_create_linear_expandable, dict_free)
5935         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5936         Make functions static.
5937
5938 2019-01-10  Keith Seitz  <keiths@redhat.com>
5939
5940         PR gdb/23712
5941         PR symtab/23010
5942         * dictionary.h (struct dictionary): Replace declaration with
5943         multidictionary.
5944         (dict_create_hashed, dict_create_hashed_expandable)
5945         (dict_create_linear, dict_create_linear_expandable)
5946         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5947         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5948         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5949         taking multidictionary argument.
5950         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5951         * block.h (struct block) <dict>: Change to multidictionary
5952         and rename `multidict'.
5953         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5954         symmisc.c: Update all dictionary references to multidictionary.
5955
5956 2019-01-10  Keith Seitz  <keiths@redhat.com>
5957
5958         PR gdb/23712
5959         PR symtab/23010
5960         * dictionary.c: Include unordered_map.
5961         (pending_to_vector): New function.
5962         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5963         Rewrite the non-"_1" functions to take vector instead
5964         of linked list.
5965         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5966         "new" _1 versions of the same name.
5967         (multidictionary): Define.
5968         (std::hash<enum language): New definition.
5969         (collate_pending_symbols_by_language, mdict_create_hashed)
5970         (mdict_create_hashed_expandable, mdict_create_linear)
5971         (mdict_create_linear_expandable, mdict_free)
5972         (find_language_dictionary, create_new_language_dictionary)
5973         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5974         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5975         (mdict_size, mdict_empty): New functions.
5976         * dictionary.h (mdict_iterator): Define.
5977
5978 2019-01-10  Pedro Alves  <palves@redhat.com>
5979
5980         * breakpoint.c (read_uploaded_action)
5981         (create_tracepoint_from_upload): Adjust to use
5982         gdb::unique_xmalloc_ptr.
5983         * ctf.c (ctf_write_uploaded_tp):
5984         (SET_ARRAY_FIELD): Use emplace_back.
5985         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5986         * tracefile-tfile.c (tfile_write_uploaded_tp):
5987         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5988         gdb::unique_xmalloc_ptr.
5989         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5990         at_string, cond_string, cmd_strings>: Replace char pointers
5991         with gdb::unique_xmalloc_ptr.
5992
5993 2019-01-10  Pedro Alves  <palves@redhat.com>
5994
5995         * solib-target.c (library_list_start_library): Don't xstrdup name.
5996
5997 2019-01-10  Pedro Alves  <palves@redhat.com>
5998
5999         * mdebugread.c (parse_partial_symbols): Use
6000         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6001
6002 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * linux-fork.c (scoped_switch_fork_info)
6005         <~scoped_switch_fork_info>: Fix incorrect variable name.
6006
6007 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * linux-fork.c (scoped_switch_fork_info)
6010         <scoped_switch_fork_info>: Make explicit.
6011         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6012
6013 2019-01-10  Tom Tromey  <tom@tromey.com>
6014
6015         * objfiles.h (objfile::reset_psymtabs): Update.
6016         * objfiles.c (objfile::objfile): Update.
6017         * psymtab.h (psymtab_storage::obstack): Update.
6018         (psymtab_storage::m_obstack): Use gdb::optional.
6019         (class psymtab_storage): Update comment.  Remove objfile
6020         parameter.
6021         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6022
6023 2019-01-10  Tom Tromey  <tom@tromey.com>
6024
6025         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6026         <free_psymtabs>: Now private.
6027         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6028         (allocate_psymtab): Use new method.
6029
6030 2019-01-10  Tom Tromey  <tom@tromey.com>
6031
6032         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6033         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6034         * mdebugread.c (parse_partial_symbols): Use
6035         allocate_dependencies.
6036         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6037         allocate_dependencies.
6038         (process_psymtab_comp_unit_reader)
6039         (build_type_psymtab_dependencies): Likewise.
6040         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6041
6042 2019-01-10  Tom Tromey  <tom@tromey.com>
6043
6044         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6045         PSYMBOL_SET_LANGUAGE.
6046         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6047
6048 2019-01-10  Tom Tromey  <tom@tromey.com>
6049
6050         * psymtab.h (psymtab_storage::obstack): New method.
6051         <m_obstack>: Rename from obstack; now private.
6052         * psymtab.c (psymtab_storage): Update.
6053         * dwarf2read.c (create_addrmap_from_index)
6054         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6055         Update.
6056
6057 2019-01-10  Tom Tromey  <tom@tromey.com>
6058
6059         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6060         * objfiles.h (objfile::reset_psymtabs): New method.
6061
6062 2019-01-10  Tom Tromey  <tom@tromey.com>
6063
6064         * symmisc.c (print_symbol_bcache_statistics): Update.
6065         (print_objfile_statistics): Update.
6066         * symfile.c (reread_symbols): Update.
6067         * psymtab.h (class psymtab_storage): New.
6068         * psymtab.c (psymtab_storage): New constructor.
6069         (~psymtab_storage): New destructor.
6070         (require_partial_symbols): Update.
6071         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6072         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6073         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6074         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6075         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6076         (start_psymtab_common, end_psymtab_common)
6077         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6078         (allocate_psymtab): Update.
6079         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6080         Update.
6081         (dump_psymtab_addrmap, maintenance_print_psymbols)
6082         (maintenance_check_psymtabs): Update.
6083         (class objfile_psymtabs): Move to objfiles.h.
6084         * psympriv.h (discard_psymtab): Now inline.
6085         (psymtab_discarder::psymtab_discarder): Update.
6086         (psymtab_discarder::~psymtab_discarder): Update.
6087         (ALL_OBJFILE_PSYMTABS): Rewrite.
6088         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6089         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6090         Remove fields.
6091         <partial_symtabs>: New field.
6092         (class objfile_psymtabs): Move from psymtab.h.  Update.
6093         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6094         psymbol_cache.
6095         (objfile::~objfile): Don't destroy psymbol_cache.
6096         * mdebugread.c (parse_partial_symbols): Update.
6097         * dwarf2read.c (create_addrmap_from_index)
6098         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6099         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6100         (add_partial_subprogram, dwarf2_ranges_read): Update.
6101         * dwarf-index-write.c (write_address_map)
6102         (write_one_signatured_type, recursively_write_psymbols)
6103         (class debug_names, class debug_names, write_psymtabs_to_index):
6104         Update.
6105
6106 2019-01-10  Tom Tromey  <tom@tromey.com>
6107
6108         * symtab.h (SYMBOL_SET_NAMES): Update.
6109         (symbol_set_names): Update.
6110         (MSYMBOL_SET_NAMES): Update.
6111         * symtab.c (symbol_set_names): Change argument to be an
6112         objfile_per_bfd_storage.
6113         * psymtab.c (add_psymbol_to_bcache): Update.
6114         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6115
6116 2019-01-10  Tom Tromey  <tom@tromey.com>
6117
6118         * symtab.c (create_demangled_names_hash): Change argument to be an
6119         objfile_per_bfd_storage.
6120         (symbol_set_names): Update.
6121
6122 2019-01-10  Tom Tromey  <tom@tromey.com>
6123
6124         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6125         init_psymbol_list.
6126         * psymtab.c (init_psymbol_list): Do nothing if already called.
6127         * psympriv.h (init_psymbol_list): Add comment.
6128         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6129         init_psymbol_list.
6130         * dbxread.c (dbx_symfile_read): Unconditionally call
6131         init_psymbol_list.
6132
6133 2019-01-10  Tom Tromey  <tom@tromey.com>
6134
6135         * xcoffread.c (scan_xcoff_symtab): Update.
6136         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6137         "where".
6138         * mdebugread.c (parse_partial_symbols)
6139         (handle_psymbol_enumerators): Update.
6140         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6141         * dbxread.c (read_dbx_symtab): Update.
6142         * psympriv.h (psymbol_placement): New enum.
6143         (add_psymbol_to_list): Update.
6144
6145 2019-01-10  Tom Tromey  <tom@tromey.com>
6146
6147         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6148         static_psymbols parameters.
6149         (scan_xcoff_symtab): Update.
6150         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6151         static_psymbols parameters.
6152         * psympriv.h (start_psymtab_common): Update.
6153         * mdebugread.c (parse_partial_symbols): Update.
6154         * dwarf2read.c (create_partial_symtab): Update.
6155         * dbxread.c (read_dbx_symtab): Update.
6156         (start_psymtab): Remove global_psymbols and static_psymbols
6157         parameters.
6158
6159 2019-01-10  Tom Tromey  <tom@tromey.com>
6160
6161         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6162         * psymtab.c (allocate_psymtab): Add comment.
6163         * psympriv.h (allocate_psymtab): Add comment.
6164         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6165         initializations.
6166         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6167
6168 2019-01-10  Tom Tromey  <tom@tromey.com>
6169
6170         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6171         Don't declare.
6172         * mipsread.c: Include mdebugread.h.
6173         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6174         Declare.
6175         * elfread.c: Include mdebugread.h.
6176
6177 2019-01-09  Tom Tromey  <tom@tromey.com>
6178
6179         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6180         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6181         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6182         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6183         (psym_lookup_symbol, psym_find_last_source_symtab)
6184         (psym_forget_cached_source_info, psym_print_stats)
6185         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6186         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6187         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6188         (psym_find_compunit_symtab_by_address)
6189         (maintenance_print_psymbols, maintenance_info_psymtabs)
6190         (maintenance_check_psymtabs): Use ranged for.
6191         * psymtab.h (class objfile_psymtabs): New.
6192         (require_partial_symbols): Return objfile_psymtabs.
6193         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6194
6195 2019-01-09  Tom Tromey  <tom@tromey.com>
6196
6197         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6198         (find_pc_mapped_section, list_overlays_command)
6199         (map_overlay_command, unmap_overlay_command)
6200         (simple_overlay_update): Use all_objfiles.
6201         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6202         * printcmd.c (info_symbol_command): Use all_objfiles.
6203         * objfiles.h (ALL_OBJSECTIONS): Remove.
6204         * maint.c (maintenance_translate_address): Use all_objfiles.
6205         * gcore.c (gcore_create_callback): Use all_objfiles.
6206         (objfile_find_memory_regions): Likewise.
6207
6208 2019-01-09  Tom Tromey  <tom@tromey.com>
6209
6210         * symtab.c (find_line_symtab, info_sources_command)
6211         (make_source_files_completion_list): Use objfile_compunits.
6212         * source.c (select_source_symtab): Use objfile_compunits.
6213         * objfiles.h (struct objfile): Update comment.
6214         (ALL_OBJFILES): Remove.
6215         (ALL_FILETABS): Remove.
6216         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6217         objfile_compunits.
6218
6219 2019-01-09  Tom Tromey  <tom@tromey.com>
6220
6221         * symmisc.c (print_objfile_statistics, dump_objfile)
6222         (maintenance_print_symbols): Use compunit_filetabs.
6223         * source.c (forget_cached_source_info_for_objfile): Use
6224         compunit_filetabs.
6225         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6226         (ALL_FILETABS): Use compunit_filetabs.
6227         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6228         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6229
6230 2019-01-09  Tom Tromey  <tom@tromey.com>
6231
6232         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6233         (compunit_filetabs): New.
6234         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6235         compunit_filetabs.
6236         (info_sources_command, make_source_files_completion_list): Remove
6237         declaration.
6238         * symmisc.c (print_objfile_statistics, dump_objfile)
6239         (maintenance_print_symbols): Remove declaration.
6240         (maintenance_info_symtabs): Use compunit_filetabs.
6241         (maintenance_info_line_tables): Likewise.
6242         * source.c (select_source_symtab): Change local variable name.
6243         (forget_cached_source_info_for_objfile): Remove declaration.
6244         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6245         * objfiles.c (objfile_relocate1): Remove declaration.
6246         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6247         declaration.
6248         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6249         * coffread.c (coff_symtab_read): Remove declaration.
6250         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6251         compunit_filetabs.
6252
6253 2019-01-09  Tom Tromey  <tom@tromey.com>
6254
6255         * symtab.c (lookup_objfile_from_block)
6256         (find_pc_sect_compunit_symtab, search_symbols)
6257         (default_collect_symbol_completion_matches_break_on): Use
6258         objfile_compunits.
6259         * objfiles.h (ALL_COMPUNITS): Remove.
6260         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6261         * cp-support.c (add_symbol_overload_list_qualified): Use
6262         objfile_compunits.
6263         * ada-lang.c (ada_collect_symbol_completion_matches)
6264         (ada_add_global_exceptions): Use objfile_compunits.
6265
6266 2019-01-09  Tom Tromey  <tom@tromey.com>
6267
6268         * source.c (select_source_symtab)
6269         (forget_cached_source_info_for_objfile): Remove declaration.
6270         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6271         declaration.
6272         * maint.c (count_symtabs_and_blocks): Remove declaration.
6273         * cp-support.c (add_symbol_overload_list_qualified): Remove
6274         declaration.
6275         * coffread.c (coff_symtab_read): Remove declaration.
6276         * symtab.c (lookup_symbol_in_objfile_symtabs)
6277         (basic_lookup_transparent_type_1): Use objfile_compunits.
6278         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6279         (info_sources_command, search_symbols)
6280         (default_collect_symbol_completion_matches_break_on)
6281         (make_source_files_completion_list): Remove declaration.
6282         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6283         (ada_collect_symbol_completion_matches)
6284         (ada_add_global_exceptions): Remove declaration.
6285         * linespec.c (iterate_over_all_matching_symtabs): Use
6286         objfile_compunits.
6287         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6288         (class objfile_compunits): New.
6289         (ALL_COMPUNITS): Use objfile_compunits.
6290         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6291         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6292         objfile_compunits.
6293         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6294
6295 2019-01-09  Tom Tromey  <tom@tromey.com>
6296
6297         * symtab.c (search_symbols)
6298         (default_collect_symbol_completion_matches_break_on): Use
6299         objfile_msymbols.
6300         * ada-lang.c (ada_lookup_simple_minsym)
6301         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6302         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6303         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6304         objfile_msymbols.
6305         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6306         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6307         * objc-lang.c (find_methods): Use objfile_msymbols.
6308         (info_selectors_command, info_classes_command): Likewise.
6309         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6310         * objfiles.h (class objfile_msymbols): New.
6311         (ALL_OBJFILE_MSYMBOLS): Remove.
6312         (ALL_MSYMBOLS): Remove.
6313
6314 2019-01-09  Tom Tromey  <tom@tromey.com>
6315
6316         * common/next-iterator.h (next_adapter): Add Iterator template
6317         parameter.
6318         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6319         (class all_objfiles_safe): New.
6320         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6321         * objfiles.c (put_objfile_before): Update comment.
6322         (add_separate_debug_objfile): Likewise.
6323         (free_all_objfiles): Use all_objfiles_safe.
6324         (objfile_purge_solibs): Likewise.
6325
6326 2019-01-09  Tom Tromey  <tom@tromey.com>
6327
6328         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6329         (expand_symtab_containing_pc, lookup_static_symbol)
6330         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6331         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6332         all_objfiles.
6333         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6334         * breakpoint.c (create_overlay_event_breakpoint)
6335         (create_longjmp_master_breakpoint)
6336         (create_std_terminate_master_breakpoint)
6337         (create_exception_master_breakpoint): Use all_objfiles.
6338         * linux-thread-db.c (try_thread_db_load_from_pdir)
6339         (has_libpthread): Use all_objfiles.
6340         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6341         * linespec.c (iterate_over_all_matching_symtabs)
6342         (search_minsyms_for_name): Use all_objfiles.
6343         * maint.c (maintenance_info_sections): Use all_objfiles.
6344         * main.c (captured_main_1): Use all_objfiles.
6345         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6346         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6347         * guile/scm-pretty-print.c
6348         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6349         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6350         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6351         (maintenance_print_msymbols): Use all_objfiles.
6352         * source.c (select_source_symtab): Use all_objfiles.
6353         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6354         * symfile.c (remove_symbol_file_command)
6355         (expand_symtabs_matching, map_symbol_filenames): Use
6356         all_objfiles.
6357         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6358         all_objfiles.
6359         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6360         * objc-lang.c (find_methods): Use all_objfiles.
6361         * objfiles.c (have_partial_symbols, have_full_symbols)
6362         (have_minimal_symbols, qsort_cmp)
6363         (default_iterate_over_objfiles_in_search_order): Use
6364         all_objfiles.
6365         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6366         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6367         (maintenance_check_psymtabs): Use all_objfiles.
6368         (ALL_PSYMTABS): Remove.
6369         * compile/compile-object-run.c (do_module_cleanup): Use
6370         all_objfiles.
6371         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6372         * cp-support.c (add_symbol_overload_list_qualified): Use
6373         all_objfiles.
6374         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6375         Use all_objfiles.
6376         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6377         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6378         all_objfiles.
6379         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6380         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6381         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6382         Uses all_objfiles.
6383         * solib.c (solib_read_symbols): Use all_objfiles
6384
6385 2019-01-09  Tom Tromey  <tom@tromey.com>
6386
6387         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6388         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6389         all_objfiles.
6390         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6391         * symmisc.c (print_symbol_bcache_statistics)
6392         (print_objfile_statistics, maintenance_print_objfiles)
6393         (maintenance_info_symtabs, maintenance_check_symtabs)
6394         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6395         all_objfiles.
6396         * source.c (forget_cached_source_info): Use all_objfiles.
6397         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6398         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6399         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6400         * objfiles.c (update_section_map): Use all_objfiles.
6401         (shared_objfile_contains_address_p): Likewise.
6402         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6403         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6404
6405 2019-01-09  Tom Tromey  <tom@tromey.com>
6406
6407         * common/next-iterator.h: New file.
6408         * objfiles.h (class all_objfiles): New.
6409         (struct objfile_iterator): New.
6410
6411 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6412
6413         * NEWS: Move the description of the changed "frame", "select-frame",
6414          and "info frame" commands to the Changed commands section.
6415
6416 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6417
6418         * gdbtypes.c (check_stub_method_group): Remove handling of old
6419         mangling schemes.
6420         * linespec.c (find_methods): Likewise.
6421         * stabsread.c (read_member_functions): Likewise.
6422         * valops.c (search_struct_method): Likewise.
6423         (value_struct_elt_for_reference): Likewise.
6424         * NEWS: Mention this change.
6425
6426 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6429         print_source_lines.
6430         * source.c (print_source_lines_base): Update line number check.
6431         (print_source_lines): New function.
6432         (source_lines_range::source_lines_range): New function.
6433         * source.h (class source_lines_range): New class.
6434         (print_source_lines): New declaration.
6435
6436 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6437
6438         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6439
6440 2019-01-08  Tom Tromey  <tom@tromey.com>
6441             Simon Marchi  <simon.marchi@ericsson.com>
6442
6443         PR gdb/24060
6444         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6445         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6446         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6447         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6448         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6449         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6450
6451 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * source.c (select_source_symtab): Move header comment to
6454         declaration in source.h.
6455         (forget_cached_source_info_for_objfile): Likewise.
6456         (forget_cached_source_info): Likewise.
6457         (identify_source_line): Likewise.
6458         * source.h (identify_source_line): Move declaration from symtab.h
6459         and add comment from source.c
6460         (print_source_lines): Likewise.
6461         (forget_cached_source_info_for_objfile): Likewise.
6462         (forget_cached_source_info): Likewise.
6463         (select_source_symtab): Likewise.
6464         (enum print_source_lines_flag): Move definition from symtab.h.
6465         * symtab.h (identify_source_line): Move declaration to source.h.
6466         (print_source_lines): Likewise.
6467         (forget_cached_source_info_for_objfile): Likewise.
6468         (forget_cached_source_info): Likewise.
6469         (select_source_symtab): Likewise.
6470         (enum print_source_lines_flag): Move definition to source.h.
6471         * tui/tui-hooks.c: Add 'source.h' include.
6472
6473 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * source.c (print_source_lines_base): Handle requests to print
6476         reverse line number sequences, and guard against empty lines
6477         string.
6478
6479 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * source.c (print_source_lines_base): Fix skip of '\r' if next
6482         character is '\n'.
6483
6484 2019-01-06  Tom Tromey  <tom@tromey.com>
6485
6486         * c-exp.y (struct c_parse_state) <macro_original_text,
6487         expansion_obstack>: New member.
6488         (macro_original_text, expansion_obstack): Remove globals.
6489         (scan_macro_expansion, scanning_macro_expansion)
6490         (finished_macro_expansion): Update.
6491         (scan_macro_cleanup): Remove.
6492         (yylex, c_parse): Update.
6493
6494 2019-01-06  Tom Tromey  <tom@tromey.com>
6495
6496         * c-exp.y (struct c_parse_state) <strings>: New member.
6497         (operator_stoken): Update.
6498
6499 2019-01-06  Tom Tromey  <tom@tromey.com>
6500
6501         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6502         (union type_stack_elt) <typelist_val>: Now a pointer to
6503         std::vector.
6504         (type_stack_cleanup): Don't declare.
6505         (push_typelist): Update.
6506         * parse.c (pop_typelist): Return a std::vector.
6507         (push_typelist): Take a std::vector.
6508         (follow_types): Update.  Do not free args.
6509         (type_stack_cleanup): Remove.
6510         * c-exp.y (struct c_parse_state): New.
6511         (cpstate): New global.
6512         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6513         (nonempty_typelist): Update.
6514         (func_mod): Create a new vector.
6515         (c_parse): Create a c_parse_state.
6516         (check_parameter_typelist): Do not delete params.
6517         (function_method): Update.  Do not delete type_list.
6518
6519 2019-01-06  Tom Tromey  <tom@tromey.com>
6520
6521         PR gdb/28155:
6522         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6523         check_typedef.
6524         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6525         (print_return_value): Likewise.
6526
6527 2019-01-05  Tom Tromey  <tom@tromey.com>
6528
6529         * contrib/cleanup_check.py: Remove.
6530         * contrib/gcc-with-excheck: Remove.
6531         * contrib/exsummary.py: Remove.
6532         * contrib/excheck.py: Remove.
6533
6534 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6535
6536         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6537         NULL. Initialize tpprev to NULL instead of assigning it
6538         to NULL on the next statement.
6539         * windows-nat.c (windows_delete_thread): Remove check for
6540         main_thread_id before printing thread exit notifications.
6541         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6542         Remove thread ID check against main_thread_id.
6543         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6544         windows_delete_thread.
6545         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6546
6547 2019-01-04  Tom Tromey  <tom@tromey.com>
6548
6549         * compile/compile.c (_initialize_compile): Use upper case for
6550         metasyntactic variables.
6551         * symmisc.c (_initialize_symmisc): Use upper case for
6552         metasyntactic variables.
6553         * psymtab.c (_initialize_psymtab): Use upper case for
6554         metasyntactic variables.
6555         * demangle.c (demangle_command): Use upper case for metasyntactic
6556         variables.
6557         (_initialize_demangler): Likewise.
6558         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6559         variables.
6560
6561 2019-01-03  Tom Tromey  <tom@tromey.com>
6562
6563         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6564
6565 2019-01-03  Tom Tromey  <tom@tromey.com>
6566
6567         * python/py-symtab.c (salpy_str): Update.
6568         (struct salpy_sal_object) <symtab>: Now a PyObject.
6569         (salpy_dealloc): Update.
6570         (del_objfile_sal): Use gdbpy_ref.
6571
6572 2019-01-03  Tom Tromey  <tom@tromey.com>
6573
6574         * python/py-type.c (convert_field): Use new_reference.  Return
6575         gdbpy_ref.
6576         (make_fielditem): Return gdbpy_ref.
6577         (typy_fields): Update.
6578         (typy_getitem): Update.
6579         (field_name): Return gdbpy_ref.  Use new_reference.
6580         (typy_iterator_iternext): Update.
6581
6582 2019-01-03  Tom Tromey  <tom@tromey.com>
6583
6584         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6585
6586 2019-01-03  Tom Tromey  <tom@tromey.com>
6587
6588         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6589         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6590         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6591         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6592         (pspy_set_type_printers): Likewise.
6593         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6594         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6595         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6596         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6597         (objfpy_set_type_printers): Likewise.
6598
6599 2019-01-03  Tom Tromey  <tom@tromey.com>
6600
6601         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6602         (gdbpy_print_stack): Use gdbpy_err_fetch.
6603         * python/python-internal.h (class gdbpy_err_fetch): New class.
6604         (class gdbpy_enter) <m_error_type, m_error_value,
6605         m_error_traceback>: Remove.
6606         <m_error>: New member.
6607         (gdbpy_exception_to_string): Don't declare.
6608         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6609         * python/py-value.c (convert_value_from_python): Use
6610         gdbpy_err_fetch.
6611         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6612         gdbpy_exception_to_string.
6613         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6614         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6615         gdbpy_err_fetch.
6616
6617 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * linux-nat.c (delete_lwp_cleanup): Delete.
6620         (struct lwp_deleter): New struct.
6621         (lwp_info_up): New typedef.
6622         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6623         lwp_info_up.
6624
6625 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * linux-fork.c (class scoped_switch_fork_info): New class.
6628         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6629
6630 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6631
6632         * valops.c (find_overload_match): Remove use of null_cleanup, and
6633         calls to do_cleanups.
6634
6635 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         * compile/compile-cplus-types.c
6638         (compile_cplus_instance::decl_name): Handle changes to
6639         cp_func_name.
6640         * cp-support.c (cp_func_name): Update header comment, update
6641         return type.
6642         * cp-support.h (cp_func_name): Update return type in declaration.
6643         * valops.c (find_overload_match): Move temp_func local to top
6644         level of function and change its type.  Use temp_func to hold and
6645         delete temporary string obtained from cp_func_name.
6646
6647 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6650         gdb::char_vector, remove cleanup, and update uses of `msg`.
6651
6652 2019-01-03  Jim Wilson  <jimw@sifive.com>
6653
6654         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6655
6656 2019-01-02  Tom Tromey  <tom@tromey.com>
6657
6658         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6659         (tdesc_parse_xml): Remove cleanups.
6660         * target-descriptions.h (make_cleanup_free_target_description):
6661         Don't declare.
6662         (target_desc_deleter): New struct.
6663         (target_desc_up): New typedef.
6664         * target-descriptions.c (target_desc_deleter::operator()): Rename
6665         from free_target_description.
6666         (make_cleanup_free_target_description): Remove.
6667
6668 2019-01-02  Tom Tromey  <tom@tromey.com>
6669
6670         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6671         constructor, destructor.
6672         (linespec_parser): Remove typedef.
6673         (~linespec_parser): Rename from linespec_parser_delete.
6674         (linespec_lex_to_end, linespec_complete_label)
6675         (linespec_complete): Update.
6676         (decode_line_full): Remove cleanups.
6677         (decode_line_1): Update.
6678
6679 2019-01-02  Tom Tromey  <tom@tromey.com>
6680
6681         * python/python-internal.h (inferior_to_inferior_object): Change
6682         return type.
6683         * python/py-exitedevent.c (create_exited_event_object): Update.
6684         * python/py-inferior.c (inferior_to_inferior_object): Return
6685         gdbpy_ref.
6686         (python_new_inferior, python_inferior_deleted)
6687         (thread_to_thread_object, delete_thread_object)
6688         (build_inferior_list, gdbpy_selected_inferior): Update.
6689         * python/py-infthread.c (create_thread_object): Update.  Also fail
6690         if inferior_to_inferior_object fails.
6691
6692 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6693
6694         * inferior.h (class inferior) <displaced_step_state>: New field.
6695         * infrun.h (struct displaced_step_state): Move here from
6696         infrun.c.  Initialize fields, add constructor.
6697         <inf>: Remove field.
6698         <reset>: New method.
6699         * infrun.c (struct displaced_step_inferior_state): Move to
6700         infrun.h.
6701         (displaced_step_inferior_states): Remove.
6702         (get_displaced_stepping_state): Adust.
6703         (displaced_step_in_progress_any_inferior): Adjust.
6704         (displaced_step_in_progress_thread): Adjust.
6705         (displaced_step_in_progress): Adjust.
6706         (add_displaced_stepping_state): Remove.
6707         (get_displaced_step_closure_by_addr): Adjust.
6708         (remove_displaced_stepping_state): Remove.
6709         (infrun_inferior_exit): Call displaced_step_state.reset.
6710         (use_displaced_stepping): Don't check for NULL.
6711         (displaced_step_prepare_throw): Call
6712         get_displaced_stepping_state.
6713         (displaced_step_fixup): Don't check for NULL.
6714         (prepare_for_detach): Don't check for NULL.
6715
6716 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6717
6718         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6719          in case of call that did not complete.
6720
6721 2019-01-02  Andrey Utkin  <autkin@undo.io>
6722
6723         * symfile.c (find_separate_debug_file): Fix search of debug files for
6724         remote debuggee.
6725
6726 2019-01-02  Tom Tromey  <tom@tromey.com>
6727
6728         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6729         indentation.
6730         * python/py-frame.c (frapy_older): Remove cast.
6731         (frapy_newer): Likewise.
6732         * python/py-breakpoint.c (local_setattro): Remove cast.
6733         * python/py-arch.c (archpy_name): Remove local variable.
6734         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6735
6736 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6737
6738         * unittests/basic_string_view/element_access/char/empty.cc:
6739         Fix year range in copyright header.
6740
6741 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6744         Delete.
6745         <operator==>: Update with for removed field.
6746         <hash>: Likewise.
6747         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6748         <isa_features>: ...this.
6749         <abi_features>: New field.
6750         (riscv_isa_flen): Update comment.
6751         (riscv_abi_xlen): New declaration.
6752         (riscv_abi_flen): New declaration.
6753         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6754         isa_features.
6755         (riscv_abi_xlen): New function.
6756         (riscv_isa_flen): Update to get answer from isa_features.
6757         (riscv_abi_flen): New function.
6758         (riscv_has_fp_abi): Update to get answer from abi_features.
6759         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6760         xlen and flen.
6761         (riscv_call_info) <xlen, flen>: Update comment.
6762         (riscv_call_arg_struct): Remove invalid assertions
6763         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6764         is removed.
6765         (riscv_gdbarch_init): Gather isa features and abi features
6766         separately, ensure both match on the gdbarch when reusing an old
6767         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6768         a target with 64-bit float hardware.
6769
6770 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6771
6772         * source.c (search_command_helper): Stop reverse search
6773         when line 1 has been searched.
6774
6775 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6776
6777         * record-full.c (record_full_base_target::close): Rewrite
6778         record_full_core_buf_list free logic.
6779
6780 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6781
6782         * break-catch-syscall.c (print_one_catch_syscall): xfree
6783         the last text.
6784
6785 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6786
6787         * top.c (print_gdb_version): Update Copyright year in version
6788         message.
6789
6790 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6791
6792         Update copyright year range in all GDB files.
6793
6794 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6795
6796         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6797
6798 For older changes see ChangeLog-2018.
6799 \f
6800 Local Variables:
6801 mode: change-log
6802 left-margin: 8
6803 fill-column: 74
6804 version-control: never
6805 coding: utf-8
6806 End:
6807