gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tromey@adacore.com>
   2
   3         * tracepoint.c: Don't include readline.h or history.h.
   4
   5 2019-08-12  Tom Tromey  <tom@tromey.com>
   6
   7         * configure: Rebuild.
   8         * configure.ac: Check for readline 7.
   9         * NEWS: Mention readline 7 requirement.
  10         * README: Update.
  11
  12 2019-08-12  Tom Tromey  <tom@tromey.com>
  13
  14         * mingw-hdep.c (gdb_select): Remove readline hack.
  15
  16 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
  17
  18         * blockframe.c (find_pc_partial_function): Set *block to nullptr
  19         when the function fails.
  20
  21 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
  22
  23         * s390-tdep.c (s390_type_align): New function.
  24         (s390_gdbarch_init): Set it as type_align gdbarch method.
  25
  26 2019-08-09  Tom de Vries  <tdevries@suse.de>
  27
  28         PR gdb/24591
  29         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  30         pc_low with relocation offset.
  31
  32 2019-08-07  Tom Tromey  <tromey@adacore.com>
  33
  34         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  35         (print_frame_args): Update.
  36         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  37         Update.
  38         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  39         * frame.h (struct frame_arg): Add initializers.
  40         <error>: Now a unique_xmalloc_ptr.
  41
  42 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
  43
  44         * NEWS: Expand the Pointer Authentication entry.
  45         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
  46         (aarch64_frame_unmask_lr): ... to this.
  47         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
  48         Call aarch64_frame_unmask_lr.
  49         * frame.c (struct frame_info): Add "masked" variable.
  50         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  51         (fprint_frame): Check for masked pc.
  52         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  53         declarations.
  54         * python/py-framefilter.c (py_print_frame): Check for masked pc.
  55         * stack.c (print_frame): Check for masked pc.
  56
  57 2019-08-06  Tom Tromey  <tom@tromey.com>
  58
  59         * stabsread.c (patch_block_stabs, read_one_struct_field)
  60         (read_enum_type): Use obstack_strndup.
  61         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
  62         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
  63         * dwarf2read.c (guess_full_die_structure_name)
  64         (anonymous_struct_prefix): Use obstack_strndup.
  65         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
  66         * c-exp.y (yylex): Use obstack_strndup.
  67         * ada-exp.y (write_object_renaming, write_ambiguous_var)
  68         (write_var_or_type): Use obstack_strndup.
  69
  70 2019-08-06  Tom Tromey  <tom@tromey.com>
  71
  72         * symfile.c (reread_symbols): Use obstack_strdup.
  73         * stabsread.c (read_type): Use obstack_strdup.
  74         * gdb_obstack.h (obstack_strdup): New overload.
  75         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
  76         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
  77         (dwarf2_canonicalize_name): Use obstack_strdup.
  78         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
  79         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
  80         Use obstack_strdup.
  81
  82 2019-08-06  Tom Tromey  <tom@tromey.com>
  83
  84         * gdb_obstack.h (obstack_strdup): Define.
  85         * gdb_obstack.c (obstack_strdup): Don't define.
  86
  87 2019-08-06  Tom Tromey  <tom@tromey.com>
  88
  89         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
  90         obstack_strdup.
  91         * typeprint.c (typedef_hash_table::find_global_typedef): Use
  92         obstack_strdup.
  93         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
  94         * stabsread.c (common_block_start): Use obstack_strdup.
  95         * objfiles.c (set_objfile_main_name, objfile): Use
  96         obstack_strdup.
  97         * namespace.c (add_using_directive): Use obstack_strdup.
  98         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
  99         * jit.c (finalize_symtab): Use obstack_strdup.
 100         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 101         (guess_partial_die_structure_name, partial_die_info::fixup)
 102         (dwarf2_name): Use obstack_strdup.
 103         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 104         obstack_strdup.
 105         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 106         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 107         obstack_strdup.
 108         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 109
 110 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 111
 112         * unittests/help-doc-selftests.c: New file.
 113         * Makefile.in: Add the new file.
 114
 115 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 116
 117         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 118         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 119         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 120         the trailing '.' is not output, and the first character is uppercased.
 121         (print_help_for_command): Update call to print_doc_line.
 122         (print_doc_of_command): Likewise.
 123         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 124         * cli/cli-option.c (append_indented_doc): Do not append newline.
 125         (build_help_option): Append newline after first appended_indented_doc
 126         only if a second call is done.
 127         (build_help): Append 2 new lines before each option, except the first
 128         one.
 129         * compile/compile.c (_initialize_compile): Add new lines after
 130         %OPTIONS%, when not at the end of the help.
 131         Change help doc or code
 132         producing the help doc to respect the invariants.
 133         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 134         Also removed the new line after 'Options:', as all other commands
 135         do not put an empty line between 'Options:' and the first option.
 136         * printcmd.c (_initialize_printcmd): Likewise.
 137         * stack.c (_initialize_stack): Likewise.
 138         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 139         incorrectly telling COMMAND is optional.
 140         * ada-lang.c (_initialize_ada_language): Change help doc or code
 141         producing the help doc to respect the invariants.
 142         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 143         * breakpoint.c (_initialize_breakpoint): Likewise.
 144         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 145         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 146         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 147         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 148         _initialize_cli_style): Likewise.
 149         * corelow.c (core_target_info): Likewise.
 150         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 151         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 152         * filesystem.c (_initialize_filesystem): Likewise.
 153         * frame.c (_initialize_frame): Likewise.
 154         * gnu-nat.c (add_task_commands): Likewise.
 155         * infcall.c (_initialize_infcall): Likewise.
 156         * infcmd.c (_initialize_infcmd): Likewise.
 157         * interps.c (_initialize_interpreter): Likewise.
 158         * language.c (_initialize_language): Likewise.
 159         * linux-fork.c (_initialize_linux_fork): Likewise.
 160         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 161         * maint.c (_initialize_maint_cmds): Likewise.
 162         * memattr.c (_initialize_mem): Likewise.
 163         * printcmd.c (_initialize_printcmd): Likewise.
 164         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 165         _RegEx): Likewise.
 166         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 167         * record-btrace.c (_initialize_record_btrace): Likewise.
 168         * record-full.c (_initialize_record_full): Likewise.
 169         * record.c (_initialize_record): Likewise.
 170         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 171         * regcache.c (_initialize_regcache): Likewise.
 172         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 173         _initialize_remote): Likewise.
 174         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 175         * serial.c (_initialize_serial): Likewise.
 176         * skip.c (_initialize_step_skip): Likewise.
 177         * source.c (_initialize_source): Likewise.
 178         * stack.c (_initialize_stack): Likewise.
 179         * symfile.c (_initialize_symfile): Likewise.
 180         * symtab.c (_initialize_symtab): Likewise.
 181         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 182         * top.c (init_main): Likewise.
 183         * tracefile-tfile.c (tfile_target_info): Likewise.
 184         * tracepoint.c (_initialize_tracepoint): Likewise.
 185         * tui/tui-win.c (_initialize_tui_win): Likewise.
 186         * utils.c (add_internal_problem_command): Likewise.
 187         * valprint.c (value_print_option_defs): Likewise.
 188
 189 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 190
 191         PR build/24886
 192         * configure.ac: Drop enable-libmcheck support.
 193         * configure, config.in: Rebuild.
 194         * libmcheck.m4: Remove.
 195         * acinclude.m4: Don't include it.
 196         * Makefile.in: Don't distribute it.
 197         * top.c (print_gdb_configuration): Don't mention it.
 198
 199 2019-08-06  Tom Tromey  <tom@tromey.com>
 200
 201         * utils.c (set_output_style): Sometimes pass stream to
 202         emit_style_escape.
 203         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 204         * record-btrace.c (btrace_insn_history): Update.
 205         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 206         method.
 207         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 208         Update initializers.
 209         <m_uiout>: New field.
 210         <m_di>: Move lower.
 211         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 212         Remove "uiout" parameter.
 213         (dump_insns): Update.
 214         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 215         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 216
 217 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 218
 219         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 220         (error_in_psymtab_expansion): Likewise.
 221         (lookup_symbol_via_quick_fns): Likewise.
 222         (basic_lookup_transparent_type_quick): Likewise.
 223         (basic_lookup_transparent_type_1): Likewise.
 224
 225 2019-08-06  Tom Tromey  <tromey@adacore.com>
 226
 227         * source.c (last_source_error): Now bool.
 228         (print_source_lines_base): Make "noprint" bool.  Only open
 229         source file when last_source_visited changes.
 230
 231 2019-08-06  Tom Tromey  <tromey@adacore.com>
 232
 233         * annotate.c (annotate_source_line): Use g_source_cache.
 234         * source-cache.c (source_cache::get_plain_source_lines): Change
 235         parameters.  Populate m_offset_cache.
 236         (source_cache::ensure): New method.
 237         (source_cache::get_line_charpos): New method.
 238         (extract_lines): Move lower.  Change parameters.
 239         (source_cache::get_source_lines): Move lower.
 240         * source-cache.h (class source_cache): Update comment.
 241         <get_line_charpos>: New method.
 242         <get_source_lines>: Update comment.
 243         <clear>: Clear m_offset_cache.
 244         <get_plain_source_lines>: Change parameters.
 245         <ensure>: New method
 246         <m_offset_cache>: New member.
 247         * source.c (forget_cached_source_info_for_objfile): Update.
 248         (info_source_command): Use g_source_cache.
 249         (find_source_lines, open_source_file_with_line_charpos): Remove.
 250         (print_source_lines_base, search_command_helper): Use g_source_cache.
 251         * source.h (open_source_file_with_line_charpos): Don't declare.
 252         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 253         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 254         Use g_source_cache.
 255
 256 2019-08-06  Tom Tromey  <tromey@adacore.com>
 257
 258         * source-cache.c (source_cache::get_plain_source_lines):
 259         Remove "first_line" and "last_line" parameters.
 260         (source_cache::get_source_lines): Cache plain text.
 261         * source-cache.h (class source_cache)
 262         <get_plain_source_lines>: Update.
 263
 264 2019-08-06  Tom Tromey  <tromey@adacore.com>
 265
 266         * source-cache.c (extract_lines): No longer a method.
 267         Changed type of parameter.  Include final newline.
 268         (selftests::extract_lines_test): New function.
 269         (_initialize_source_cache): Likewise.
 270         * source-cache.h (class source_cache)
 271         <extract_lines>: Don't declare.
 272
 273 2019-08-06  Tom Tromey  <tromey@adacore.com>
 274
 275         * breakpoint.c (init_breakpoint_sal): Update.
 276         (breakpoint): Update.
 277         * breakpoint.h (struct breakpoint) <filter>: Now a
 278         unique_xmalloc_ptr.
 279
 280 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * NEWS: Mention dictionary access on blocks.
 283         * python/py-block.c (blpy_getitem): New function.
 284         (block_object_as_mapping): New struct.
 285         (block_object_type): Use new struct for tp_as_mapping field.
 286
 287 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 288
 289         * objfiles.h (objfile): Add a comment describing partial symbols.
 290
 291 2019-08-05  Tom Tromey  <tromey@adacore.com>
 292
 293         * compile/compile.c (_initialize_compile): Use _(), not N_().
 294         * thread.c (_initialize_thread): Use _(), not N_().
 295         * stack.c (_initialize_stack): Use _(), not N_().
 296         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 297
 298 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 299
 300         * dwarf2read.c (struct dw2_symtab_iterator):
 301         <want_specific_block>: Remove.
 302         <block_index>: Change type to gdb::optional.
 303         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 304         change type of BLOCK_INDEX parameter to gdb::optional.
 305         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 306         (dw2_lookup_symbol): Don't pass argument for
 307         WANT_SPECIFIC_BLOCK.
 308         (dw2_expand_symtabs_for_function): Don't pass argument for
 309         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 310         (class dw2_debug_names_iterator)
 311         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 312         parameter, change BLOCK_INDEX type to gdb::optional.
 313         <m_want_specific_block>: Remove.
 314         <m_block_index>: Change type to gdb::optional.
 315         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 316         gdb::optional.  Re-write in function of gdb::optional.
 317         (dw2_debug_names_lookup_symbol): Don't pass argument for
 318         WANT_SPECIFIC_BLOCK.
 319         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 320         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 321         BLOCK_INDEX.
 322
 323 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 324
 325         * NEWS: Mention changes to "info sources" command.
 326
 327 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 328
 329         * symtab.c (filename_partial_match_opts): New struct type.
 330         (struct output_source_filename_data): New members
 331         regexp, c_regexp, partial_match.
 332         (output_source_filename): Use new members to decide to print file.
 333         (info_sources_option_defs): New variable.
 334         (make_info_sources_options_def_group, print_info_sources_header,
 335         info_sources_command_completer):
 336         New functions.
 337         (info_sources_command): Read new optional arguments.
 338         (_initialize_symtab): Update info sources help.
 339
 340 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 341
 342         * ada-lang.c (exception_support_info_v0): Renamed from...
 343         (default_exception_support_info): ... this.  Create new
 344         definition for v1.
 345         (ada_has_this_exception_support): Look up catch_handlers_sym.
 346         (ada_exception_support_info_sniffer): Try v0 after default.
 347
 348 2019-08-01  Tom Tromey  <tromey@adacore.com>
 349
 350         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 351         gdbarch.h.
 352
 353 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 354
 355         * s12z-tdep.c: Fix include path for s12z-opc.h.
 356
 357 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 358
 359         * NEWS: Require GNU make 3.82.
 360
 361 2019-07-16  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 364         declare.
 365
 366 2019-07-30  Tom Tromey  <tromey@adacore.com>
 367
 368         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 369
 370 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 371
 372         * printcmd.c (print_address_symbolic): Print negative offsets.
 373         (build_address_symbolic): Force signed arithmetic when computing
 374         offset.
 375
 376 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 377
 378         PR/24474: Add a function to lookup static variables.
 379         * NEWS: Mention this new function.
 380         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 381         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 382         * python/python.c (python_GdbMethods): Add new function.
 383
 384 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 385
 386         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 387         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 388         (objfpy_lookup_static_symbol): New function.
 389         (objfile_object_methods): Add new functions.
 390
 391 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 392
 393         * NEWS: Mention 'set|show print frame-info'.  Mention new
 394         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 395         backtrace argument.  Mention that python frame filtering code
 396         is now consistent with what 'backtrace' command prints.
 397
 398 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 399
 400         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 401         comments.
 402         (print_frame_info_auto, print_frame_info_source_line,
 403         print_frame_info_location, print_frame_info_source_and_location,
 404         print_frame_info_location_and_address, print_frame_info_short_location):
 405         New declarations.
 406         (struct frame_print_options): New member print_frame_info.
 407         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 408         * stack.h (get_user_print_what_frame_info): New declaration.
 409         (frame_show_address): New declaration.
 410         * stack.c (print_frame_arguments_choices): New value 'presence'.
 411         (print_frame_info_auto, print_frame_info_source_line,
 412         print_frame_info_location, print_frame_info_source_and_location,
 413         print_frame_info_location_and_address, print_frame_info_short_location,
 414         print_frame_info_choices, print_frame_info_print_what): New definitions.
 415         (print_frame_args): Only print dots for args if print frame-arguments
 416         is 'presence'.
 417         (frame_print_option_defs): New element for "frame-info".
 418         (get_user_print_what_frame_info): New function.
 419         (frame_show_address): Make non static.  Move comment to stack.h.
 420         (print_frame_info_to_print_what): New function.
 421         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 422         to decide what to print.
 423         (backtrace_command_1): Handle the new print_frame_arguments_presence
 424         value.
 425         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 426         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 427         (py_print_frame): In non-mi mode, use LOCATION as default for
 428         print_what, similarly to frame information printed directly by
 429         backtrace command. Handle frame-info user option in non MI mode.
 430
 431 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 432
 433         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 434         Add case for debugging 32-bit target on 64-bit host.  Revise
 435         comment.
 436
 437 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 438
 439         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 440         instead of find_function_entry_range_from_pc.
 441
 442 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 443
 444         * stack.c (find_frame_funname): Remove code which preferred
 445         minsym over symtab sym in "certain pathological cases".
 446
 447         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 448         parameter.  Change type of "do_demangle" to bool.
 449         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 450         Pass suitable "prefer_sym_over_minsym" flag to
 451         build_address_symbolic().  Don't output "+" for negative offsets.
 452         * printcmd.c (print_address_symbolic): Update invocation of
 453         build_address_symbolic to include a "prefer_sym_over_minsym"
 454         flag.
 455         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 456         Restrict cases in which use of minimal symbol is preferred to that
 457         of a found symbol.  Update comments.
 458
 459         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 460         for entry pc when entry pc is out of range for that FDE.
 461
 462 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 463
 464         PR gdb/24839:
 465         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 466         type.
 467
 468 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 469
 470         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 471         this function's Python signature.
 472
 473
 474 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 475
 476         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 477         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 478         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 479         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 480         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 481
 482
 483 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 484
 485         * h8300-tdep.c (h8300_register_name_common): New.
 486         h8300_register_name): Use h8300_register_name_common.
 487         (h8300s_register_name): Likewise.
 488         (h8300sx_register_name): Likewise.
 489         (h8300h_register_nam): New.
 490         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 491
 492
 493 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 494
 495         * arm-tdep.c (arm_skip_cmse_entry): New function.
 496         (arm_is_sgstubs_section): New function.
 497         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 498
 499 2019-07-22  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 502         Don't self-assign.
 503
 504 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 507         type_print.
 508
 509 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 512         so that GDB doesn't match any msymbols when searching in the
 513         TYPES_DOMAIN.
 514         (print_symbol_info): Print using typedef_print or type_print based
 515         on the type of the symbol.  Add updated FIXME comment moved from...
 516         (_initialize_symtab): ... move and update FIXME comment to above.
 517
 518 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * NEWS: Mention adding -q option to "info types".
 521         * symtab.c (struct info_types_options): New struct.
 522         (info_types_options_defs): New variable.
 523         (make_info_types_options_def_group): New function.
 524         (info_types_command): Use gdb::option framework to parse options.
 525         (info_types_command_completer): New function.
 526         (_initialize_symtab): Extend the help text on "info types" and
 527         register command completer.
 528
 529 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 530
 531         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 532         (lookup_symbol_in_objfile): Change int to block_enum and add a
 533         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 534
 535 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 536
 537         * MAINTAINERS (Write After Approval): Add self.
 538
 539 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 542         instruction to the dummy code region.
 543
 544 2019-07-19  Tom Tromey  <tromey@adacore.com>
 545
 546         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 547         (ARGSUSED, PARAMS, __func__): Remove rules.
 548
 549 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 550
 551         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 552         * features/arm/arm-with-iwmmxt.c: Remove.
 553         * features/arm/arm-with-iwmmxt.xml: Remove.
 554         * features/arm/arm-with-m-fpa-layout.c: Remove.
 555         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 556         * features/arm/arm-with-m-vfp-d16.c: Remove.
 557         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 558         * features/arm/arm-with-m.c: Remove.
 559         * features/arm/arm-with-m.xml: Remove.
 560         * features/arm/arm-with-neon.c: Remove.
 561         * features/arm/arm-with-neon.xml: Remove.
 562         * features/arm/arm-with-vfpv2.c: Remove.
 563         * features/arm/arm-with-vfpv2.xml: Remove.
 564         * features/arm/arm-with-vfpv3.c: Remove.
 565         * features/arm/arm-with-vfpv3.xml: Remove.
 566
 567 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 568
 569         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 570
 571 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 572
 573         * arch/aarch32.c (aarch32_create_target_description): Create
 574         target descriptions using features.
 575         * arch/arm.c (arm_create_target_description)
 576         (arm_create_mprofile_target_description): Likewise.
 577         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 578
 579 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 580
 581         * Makefile.in: Add new files.
 582         * aarch32-tdep.c: New file.
 583         * aarch32-tdep.h: New file.
 584         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 585         Call aarch32_read_description.
 586         * arch/aarch32.c: New file.
 587         * arch/aarch32.h: New file.
 588         * arch/arm.c (arm_create_target_description)
 589         (arm_create_mprofile_target_description): New function.
 590         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 591         (arm_create_target_description)
 592         (arm_create_mprofile_target_description): New declaration.
 593         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 594         read_description functions.
 595         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 596         Likewise.
 597         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 598         * arm-tdep.c (tdesc_arm_list): New variable.
 599         (arm_register_g_packet_guesses): Call create description functions.
 600         (arm_read_description) (arm_read_mprofile_description): New
 601         function.
 602         * arm-tdep.h (arm_read_description)
 603         (arm_read_mprofile_description): Add declaration.
 604         * configure.tgt: Add new files.
 605
 606 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 607
 608         * top.c (new_ui_command): Open specified terminal just once.
 609
 610 2019-07-18  Tom Tromey  <tromey@adacore.com>
 611
 612         * symtab.c (main_name): Constify return type.
 613         * symfile.c (set_initial_language): Update.
 614         * symtab.h (main_name): Constify return type.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-winsource.c (tui_update_source_window)
 619         (tui_update_source_window_as_is)
 620         (tui_update_source_windows_with_line): Remove return.
 621         * tui/tui-disasm.c (tui_show_disassem)
 622         (tui_show_disassem_and_update_source): Remove return.
 623         * tui/tui.c (tui_reset): Remove return.
 624         * tui/tui-wingeneral.c
 625         (tui_check_and_display_highlight_if_needed): Remove return.
 626
 627 2019-07-17  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-winsource.h (struct tui_exec_info_window)
 634         (struct tui_source_window_base): Move from tui-data.h.
 635         * tui/tui-winsource.c: Move many method definitions from
 636         elsewhere.  Remove "structuring" comments.
 637         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 638         (tui_source_window_base::refresh_window): Move to
 639         tui-winsource.c.
 640         * tui/tui-win.c (tui_source_window_base::refresh_all)
 641         (tui_source_window_base::update_tab_width)
 642         (tui_source_window_base::set_new_height)
 643         (tui_source_window_base::do_make_visible_with_new_height): Move to
 644         tui-winsource.c.
 645         * tui/tui-source.h: Update.
 646         * tui/tui-source.c (tui_source_window_base::reset): Move to
 647         tui-winsource.c.
 648         * tui/tui-disasm.h: Update.
 649         * tui/tui-data.h (struct tui_exec_info_window): Move to
 650         tui-winsource.h.
 651         (struct tui_source_window_base): Likewise.
 652         * tui/tui-data.c (tui_source_window_base::clear_detail)
 653         (tui_source_window_base, ~tui_source_window_base): Move to
 654         tui-winsource.c.
 655
 656 2019-07-17  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-win.c (tui_resize_all)
 659         (tui_source_window_base::update_tab_width)
 660         (tui_adjust_win_heights): Update.
 661         (tui_win_info::make_invisible_and_set_new_height): Rename from
 662         make_invisible_and_set_new_height.
 663         * tui/tui-data.h (struct tui_win_info)
 664         <make_invisible_and_set_new_height>: New method.
 665
 666 2019-07-17  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui.c: Update.
 669         * tui/tui-source.h (struct tui_source_window): Move from
 670         tui-data.h.
 671         * tui/tui-layout.c: Update.
 672         * tui/tui-disasm.c: Update.
 673         * tui/tui-data.h (struct tui_source_window): Move to
 674         tui-source.h.
 675
 676 2019-07-17  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 679         tui-data.h.
 680         * tui/tui-data.h (struct tui_disasm_window): Move to
 681         tui-disasm.h.
 682
 683 2019-07-17  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-regs.h (struct tui_data_item_window): Move from
 686         tui-data.h.
 687         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 688         * tui/tui-data.h (struct tui_data_item_window): Move to
 689         tui-regs.h.
 690         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 691
 692 2019-07-17  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui.c: Update.
 695         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 696         (tui_cmd_window::max_height): Move to tui-command.c.
 697         * tui/tui-layout.c: Update.
 698         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 699         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 700         tui-command.c.
 701         * tui/tui-command.h (struct tui_cmd_window): Move from
 702         tui-data.h.
 703         * tui/tui-command.c: Remove "structuring" comments.
 704         (tui_cmd_window::clear_detail)
 705         (tui_cmd_window::do_make_visible_with_new_height)
 706         (tui_cmd_window::max_height): Move from elsewhere.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 711         Now static.
 712         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 713         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 714
 715 2019-07-17  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui.c: Update.
 718         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 719         tui-regs.c.
 720         * tui/tui-windata.h: Remove file.
 721         * tui/tui-windata.c: Remove file.
 722         * tui/tui-win.c (tui_data_window::set_new_height)
 723         (tui_data_window::do_make_visible_with_new_height): Move to
 724         tui-regs.c.
 725         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 726         * tui/tui-regs.c: Remove "structuring" comments.
 727         (tui_data_window::first_data_item_displayed)
 728         (tui_data_window::delete_data_content_windows)
 729         (tui_data_window::erase_data_content)
 730         (tui_data_window::display_all_data)
 731         (tui_data_window::refresh_all)
 732         (tui_data_window::do_scroll_vertical)
 733         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 734         (tui_data_window::do_make_visible_with_new_height)
 735         (tui_data_window::refresh_window): Move from elsewhere.
 736         (_initialize_tui_regs): Move to end of file.
 737         * tui/tui-layout.c: Update.
 738         * tui/tui-hooks.c: Update.
 739         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 740         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 741         tui-regs.c.
 742         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 747         seen.
 748
 749 2019-07-17  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-win.c (tui_source_window_base::set_new_height)
 752         (tui_source_window_base::do_make_visible_with_new_height): Use
 753         m_has_locator field directly.
 754         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 755         method.
 756         (struct tui_source_window_base) <has_locator>: Likewise.
 757
 758 2019-07-17  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 761         Don't declare.
 762         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 763         Remove.
 764         * tui/tui-win.c (tui_source_window_base::set_new_height)
 765         (tui_source_window_base::set_new_height)
 766         (make_invisible_and_set_new_height)
 767         (tui_source_window_base::do_make_visible_with_new_height)
 768         (tui_source_window_base::do_make_visible_with_new_height):
 769         Update.
 770         * tui/tui-layout.c (show_source_disasm_command, show_data)
 771         (show_source_or_disasm_and_command): Update.
 772         * tui/tui-layout.c (show_layout): Update.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-layout.c (make_data_window): Remove.
 777         (show_data): Unify creation and re-initialization cases.
 778
 779 2019-07-17  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-layout.c (make_source_window, make_disasm_window):
 782         Remove.
 783         (show_data): Unify creation and re-initialization cases.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-layout.c (make_command_window): Remove.
 788         (show_source_disasm_command, show_source_or_disasm_and_command):
 789         Unify creation and re-initialization cases.
 790
 791 2019-07-17  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 794         creation and re-initialization cases.
 795
 796 2019-07-17  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-regs.c (tui_get_register): Return void.
 799
 800 2019-07-17  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 803         Simplify.
 804
 805 2019-07-17  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 808         resetting.
 809
 810 2019-07-17  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 813         * tui/tui-regs.c (tui_reg_layout): New function.
 814         (tui_show_registers, tui_reg_command): Use it.
 815         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 816         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 817         parameters.
 818         (tui_layout_command): Remove.
 819
 820 2019-07-17  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-layout.h (tui/tui-layout): Return void.
 823         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 824
 825 2019-07-17  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-layout.c (show_source_disasm_command, show_data):
 828         Update.
 829         (reset_locator): Remove.
 830         (show_source_or_disasm_and_command): Update.
 831
 832 2019-07-17  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-source.c (tui_source_window_base::reset): Remove
 835         win_type parameter.
 836         * tui/tui-layout.c (make_command_window, make_source_window)
 837         (make_disasm_window, make_data_window)
 838         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 839         (reset_locator, show_source_or_disasm_and_command): Update.
 840         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 841         win_type parameter.
 842         (struct tui_source_window_base) <reset>: Likewise.
 843
 844 2019-07-17  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-layout.c (show_source_disasm_command): Use
 847         reset_locator.
 848         (reset_locator): New function.
 849         (init_and_make_win): Remove.
 850         (show_source_or_disasm_and_command): Use reset_locator.
 851
 852 2019-07-17  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 855         condition.
 856         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 857         Remove condition.
 858         * tui/tui-source.c (tui_source_window_base::reset): New method.
 859         * tui/tui-layout.c (make_command_window): Don't call
 860         init_and_make_win.
 861         (make_source_window, make_disasm_window): Don't call
 862         make_source_or_disasm_window.
 863         (make_data_window): Don't call init_and_make_win.  Change calling
 864         convention.
 865         (show_source_disasm_command, show_data): Simplify.
 866         (make_source_or_disasm_window): Remove.
 867         (show_source_or_disasm_and_command): Simplify.
 868         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 869         (struct tui_source_window_base) <reset>: Likewise.
 870         <execution_info>: Remove initializer.
 871         * tui/tui-data.c (tui_source_window_base): Initialize
 872         execution_info.
 873
 874 2019-07-17  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 877         variable.
 878
 879 2019-07-17  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui.c (tui_rl_other_window): Update.
 882         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 883         superclass method first.  Always iterate over regs_content.
 884         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 885         method.
 886         * tui/tui-win.c (tui_set_focus_command): Update.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-win.c (tui_set_focus_command): Rename from
 891         tui_set_focus.  Call tui_enable.
 892         (tui_set_focus_command): Remove.
 893
 894 2019-07-17  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 897         refresh_window.
 898         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 899         touchwin.
 900         (tui_data_window::refresh_window): Call refresh_window on data
 901         items.  Always call superclass refresh_window.
 902         (tui_win_info::refresh): Remove.
 903         (tui_source_window_base::refresh_window): Update.
 904         (tui_refresh_all): Update.
 905         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 906         refresh_window.
 907         (show_source_or_disasm_and_command): Likewise.
 908         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 909         (struct tui_source_window_base) <refresh>: Likewise.
 910
 911 2019-07-17  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.c (tui_clear_source_content)
 914         (tui_show_source_content): Update.
 915         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 916         whether content is empty.
 917         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 918         Remove.
 919
 920 2019-07-17  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 923         window's contents.
 924         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 925         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 926
 927 2019-07-17  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 930         (struct tui_data_item_window): Update.
 931
 932 2019-07-17  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 935         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 936         defines.
 937
 938 2019-07-17  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-winsource.h (tui_erase_source_content)
 941         (tui_clear_source_content): Remove "display_prompt" parameter.
 942         * tui/tui-winsource.c (tui_update_source_window_as_is)
 943         (tui_update_source_windows_with_addr): Update.
 944         (tui_clear_source_content): Remove "display_prompt" parameter.
 945         (tui_erase_source_content): Likewise.  Simplify.
 946         (tui_show_source_content): Update.
 947         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 948         * tui/tui-stack.c (tui_show_frame_info): Update.
 949         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 950         Remove defines.
 951
 952 2019-07-17  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 955         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 956         parameter.
 957         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 958         parameter.
 959
 960 2019-07-17  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-winsource.c (tui_clear_source_content)
 963         (tui_show_source_content, tui_show_exec_info_content)
 964         (tui_clear_exec_info_content): Update.
 965         * tui/tui-stack.c (tui_show_locator_content): Update.
 966         (tui_show_frame_info): Update.
 967         * tui/tui-source.h (tui_source_window): Don't declare.
 968         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 969         from tui_source_is_displayed.
 970         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 971         Remove field.
 972         (struct tui_source_window_base) <content_in_use>: New field.  Now
 973         bool.
 974         (struct tui_source_window) <showing_source_p>: New method.
 975         (TUI_SRC_WIN): Change cast.
 976         * tui/tui-data.c (tui_initialize_static_data): Update.
 977
 978 2019-07-17  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 981         location_matches_p.
 982         * tui/tui-source.c (tui_source_window::location_matches_p): New
 983         method.
 984         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 985         method.
 986         * tui/tui-data.h (struct tui_source_window_base)
 987         <location_matches_p>: New method.
 988         (struct tui_source_window, struct tui_disasm_window)
 989         <location_matches_p>: Likewise.
 990
 991 2019-07-17  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-win.c (tui_set_win_height_command): Rename from
 994         tui_set_win_height.
 995         (tui_set_win_height_command): Remove.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-source.c (tui_source_window): New constructor.  Add
1000         observer.
1001         (~tui_source_window): New destructor.
1002         (tui_source_window::style_changed): New method.
1003         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1004         (tui_attach_detach_observers): Update.
1005         * tui/tui-data.h (struct tui_source_window): Make constructor not
1006         inline.  Add destructor.
1007         (struct tui_source_window) <style_changed>: New method.
1008         <m_observable>: New member.
1009
1010 2019-07-17  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1013         * tui/tui-win.c (tui_resize_all): Fix typo.
1014
1015 2019-07-17  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1018         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1019         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1020         * tui/tui-win.c (window_name_completer): Use foreach.
1021         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1022         (update_tab_width): Likewise.
1023         * tui/tui-layout.c (show_layout): Update.
1024         * tui/tui-data.h (class tui_window_iterator): New.
1025         (struct all_tui_windows): New.
1026         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1027
1028 2019-07-17  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1031         parameter.  Don't reference globals.
1032         (tui_reg_command): Update.
1033
1034 2019-07-17  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-regs.c (tui_show_registers): Simplify.
1037
1038 2019-07-17  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-regs.c (tui_show_registers): Update.
1041         (tui_show_register_group): Add win_info parameter.
1042
1043 2019-07-17  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1046         Rename from tui_display_reg_element_at_line.
1047         (tui_data_window::display_registers_from_line): Update.
1048         * tui/tui-data.h (struct tui_data_window)
1049         <display_reg_element_at_line>: New method.
1050
1051 2019-07-17  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-regs.h (tui_display_registers_from)
1054         (tui_display_registers_from_line): Don't declare.
1055         * tui/tui-windata.c (tui_data_window::display_all_data)
1056         (tui_data_window::refresh_all)
1057         (tui_data_window::do_scroll_vertical): Update.
1058         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1059         from tui_display_registers_from.
1060         (tui_display_reg_element_at_line): Update.
1061         (tui_data_window::display_registers_from_line): Rename from
1062         tui_display_registers_from_line.
1063         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1064         display_registers_from_line>: New methods.
1065
1066 2019-07-17  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1069         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1070         from tui_erase_data_content.
1071         (tui_data_window::display_all_data)
1072         (tui_data_window::refresh_all)
1073         (tui_data_window::do_scroll_vertical): Update.
1074         * tui/tui-regs.c (tui_show_registers): Update.
1075         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1076         New method.
1077
1078 2019-07-17  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1081         declare.
1082         * tui/tui-windata.c
1083         (tui_data_window::delete_data_content_windows): Rename from
1084         tui_delete_data_content_windows.
1085         (tui_data_window::display_all_data)
1086         (tui_data_window::do_scroll_vertical): Update.
1087         * tui/tui-data.h (struct tui_data_window)
1088         <delete_data_content_windows>: New method.
1089
1090 2019-07-17  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1093         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1094
1095 2019-07-17  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1098         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1099         from tui_display_all_data.
1100         * tui/tui-win.c
1101         (tui_data_window::do_make_visible_with_new_height): Update.
1102         * tui/tui-regs.c (tui_show_registers): Update.
1103         * tui/tui-layout.c (tui_set_layout): Update.
1104         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1105         method.
1106
1107 2019-07-17  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1110         * tui/tui-windata.c (tui_display_data_from): Remove.
1111         (tui_data_window::refresh_all): Update.
1112
1113 2019-07-17  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1116         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1117         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1118         tui_display_registers_from_line.
1119         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1120         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1121         "force_display" parameter.
1122
1123 2019-07-17  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1126         declare.
1127         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1128         Rename from tui_first_reg_element_no_inline.
1129         (tui_display_reg_element_at_line)
1130         (tui_display_registers_from_line): Update.
1131         * tui/tui-data.h (struct tui_data_window)
1132         <first_reg_element_no_inline>: New method.
1133
1134 2019-07-17  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-windata.c (tui_display_data_from)
1137         (tui_data_window::do_scroll_vertical): Update.
1138         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1139         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1140         Rename from tui_line_from_reg_element_no.
1141         (tui_display_registers_from_line): Update.
1142         * tui/tui-data.h (struct tui_data_window)
1143         <line_from_reg_element_no>: New method.
1144
1145 2019-07-17  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1148         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1149         tui_last_regs_line_no.
1150         (tui_display_reg_element_at_line)
1151         (tui_display_registers_from_line): Update.
1152         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1153         method.
1154
1155 2019-07-17  Tom Tromey  <tom@tromey.com>
1156
1157         PR tui/24722:
1158         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1159         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1160         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1161         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1162         (tui_update_breakpoint_info): Likewise.
1163         * tui/tui-hooks.c (tui_event_create_breakpoint)
1164         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1165         Update.
1166
1167 2019-07-17  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-winsource.c (tui_update_source_window_as_is)
1174         (tui_update_source_windows_with_addr): Update.
1175         * tui/tui-source.h (tui_set_source_content)
1176         (tui_show_symtab_source): Add "win_info" parameter.
1177         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1178         parameter.
1179         (tui_show_symtab_source): Likewise.
1180
1181 2019-07-17  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-wingeneral.c
1184         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1185
1186 2019-07-17  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1189         (struct tui_cmd_window) <can_scroll>: New method.
1190         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1191         method.
1192
1193 2019-07-17  Tom Tromey  <tromey@adacore.com>
1194
1195         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1196         do_field_signed>: Rename.  Change type of "value".
1197         * ui-out.c (ui_out::field_signed): Rename from field_int.
1198         Change type of "value".
1199         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1200         type of "value".
1201         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1202         do_field_int.  Change type of "value".
1203         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1204         do_field_int.  Change type of "value".
1205         * tracepoint.c (trace_status_mi, tfind_1)
1206         (print_one_static_tracepoint_marker): Update.
1207         * thread.c (print_thread_info_1, print_selected_thread_frame):
1208         Update.
1209         * stack.c (print_frame, print_frame_info): Update.
1210         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1211         Update.
1212         * source.c (print_source_lines_base): Update.
1213         * skip.c (info_skip_command): Update.
1214         * record-btrace.c (btrace_ui_out_decode_error)
1215         (btrace_call_history_src_line): Update.
1216         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1217         Update.
1218         * progspace.c (print_program_space): Update.
1219         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1220         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1221         do_field_int.  Change type of "value".
1222         * mi/mi-out.c (mi_ui_out::do_table_begin)
1223         (mi_ui_out::do_table_header): Update.
1224         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1225         type of "value".
1226         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1227         (mi_cmd_data_list_changed_registers, output_register)
1228         (mi_cmd_data_read_memory, mi_load_progress)
1229         (mi_cmd_trace_frame_collected): Update.
1230         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1231         Update.
1232         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1233         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1234         (mi_cmd_var_list_children, varobj_update_one): Update.
1235         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1236         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1237         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1238         * inferior.c (print_inferior): Update.
1239         * gdb_bfd.c (print_one_bfd): Update.
1240         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1241         Update.
1242         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1243         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1244         do_field_int.  Change type of "value".
1245         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1246         do_field_int.  Change type of "value".
1247         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1248         (print_one_breakpoint_location, print_it_catch_fork)
1249         (print_one_catch_fork, print_it_catch_vfork)
1250         (print_one_catch_vfork, print_it_catch_solib)
1251         (print_it_catch_exec, print_it_ranged_breakpoint)
1252         (print_mention_watchpoint, print_mention_masked_watchpoint)
1253         (bkpt_print_it, update_static_tracepoint): Update.
1254         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1255         * break-catch-syscall.c (print_it_catch_syscall): Update.
1256         * ada-tasks.c (print_ada_task_info): Update.
1257         * ada-lang.c (print_it_exception, print_mention_exception):
1258         Update.
1259
1260 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         PR breakpoints/24541
1263         * gdbarch.c: Regenerate.
1264         * gdbarch.h: Regenerate.
1265         * gdbarch.sh: Adjust return type and parameter types for
1266         'stap_adjust_register'.
1267         (i386_stap_adjust_register): Adjust signature and return new
1268         register name.
1269         * stap-probe.c (stap_parse_register_operand): Adjust use of
1270         'gdbarch_stap_adjust_register'.
1271
1272 2019-07-17  Tom Tromey  <tromey@adacore.com>
1273
1274         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1275         declare VEC.
1276         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1277         std::vector.
1278         (struct s390_process_info): Add initializers.
1279         (s390_add_process): Use new.
1280         (s390_linux_nat_target::low_forget_process): Use delete.
1281         (s390_linux_nat_target::low_new_fork)
1282         (s390_linux_nat_target::stopped_by_watchpoint)
1283         (s390_linux_nat_target::low_prepare_to_resume)
1284         (s390_linux_nat_target::insert_watchpoint)
1285         (s390_linux_nat_target::insert_hw_breakpoint)
1286         (s390_linux_nat_target::remove_watchpoint)
1287         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1288
1289 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1290
1291         * aarch64-fbsd-nat.c: Include regcache.h.
1292         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1293         argument.
1294         (aarch64_fbsd_nat_target::fetch_registers)
1295         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1296         variable.
1297         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1298
1299 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1300
1301         * fbsd-nat.c: Include gdbarch.h.
1302
1303 2019-07-15  Tom Tromey  <tromey@adacore.com>
1304
1305         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1306
1307 2019-07-15  Tom Tromey  <tromey@adacore.com>
1308
1309         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1310         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1311         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1312         * cli-out.c (cli_ui_out::do_field_int): New method.
1313         * ui-out.c (ui_out::field_unsigned): New method.
1314         * symfile.c (generic_load): Use field_unsigned.
1315         (print_transfer_performance): Likewise.
1316         * record-btrace.c (ui_out_field_uint): Remove.
1317         (btrace_call_history_insn_range, btrace_call_history): Use
1318         field_unsigned.
1319         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1320         field_unsigned.
1321         * ui-out.h (class ui_out) <field_unsigned>: New method.
1322         <do_field_unsigned>: Likewise.
1323
1324 2019-07-15  Tom Tromey  <tromey@adacore.com>
1325
1326         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1327         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1328         * target.c (flash_erase_command): Use field_string.
1329         * infrun.c (print_signal_received_reason): Use field_string.
1330         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1331         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1332         field_string.
1333         * ada-tasks.c (print_ada_task_info): Use field_string.
1334
1335 2019-07-15  Tom Tromey  <tromey@adacore.com>
1336
1337         * target.c (flash_erase_command): Use field_core_addr.
1338         * symfile.c (generic_load): Use field_core_addr.
1339         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1340         Use field_core_addr.
1341         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1342         field_core_addr.
1343
1344 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1347         value if its desired type is smaller than a CORE_ADDR and signed.
1348
1349 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1352         of changes to field names, and use new is_reference field to
1353         decide if a property is a reference or not.
1354         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1355         field.
1356         (struct dwarf2_property_baton): Update header comment, rename
1357         'referenced_type' to 'property_type' and update comments.
1358         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1359         default property type, store in property baton, update to take
1360         accound of renamed field.
1361         (read_func_scope): Update call to attr_to_dynamic_prop.
1362         (read_array_type): Likewise.
1363         (dwarf2_per_cu_addr_sized_int_type): New function.
1364         (read_subrange_index_type): Move type finding code to
1365         dwarf2_per_cu_addr_sized_int_type.
1366         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1367         (dwarf2_per_cu_addr_type): New function.
1368         (set_die_type): Update calls to attr_to_dynamic_prop.
1369
1370 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * dwarf2read.c (read_subrange_index_type): New function.
1373         (read_subrange_type): Move code into new function and call it.
1374         * gdbtypes.c (create_range_type): Add some asserts.
1375
1376 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1379         update return statements.
1380         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1381         declaration, and update comment to match.
1382         * gdbtypes.c (resolve_dynamic_array): Update call to
1383         dwarf2_evaluate_property to match new return type.
1384
1385 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * valarith.c (value_subscripted_rvalue): Change lowerbound
1388         parameter type from int to LONGEST.
1389         * value.h (value_subscripted_rvalue): Likewise in declaration.
1390
1391 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * cli/cli-utils.c (info_print_command_completer): New function.
1394         * cli/cli-utils.h: Add 'completer.h' include, and forward
1395         declaration for 'struct cmd_list_element'.
1396         (info_print_command_completer): Declare.
1397         * stack.c (_initialize_stack): Add completer for 'info locals' and
1398         'info args'.
1399         * symtab.c (_initialize_symtab): Add completer for 'info
1400         variables' and 'info functions'.
1401         * NEWS: Mention completion for additional info commands.
1402
1403 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * cli/cli-utils.c (extract_info_print_args): Delete.
1406         (extract_arg_maybe_quoted): Delete.
1407         (info_print_options_defs): New variable.
1408         (make_info_print_options_def_group): New function.
1409         (extract_info_print_options): Define new function.
1410         * cli/cli-utils.h (extract_info_print_args): Delete.
1411         (struct info_print_options): New structure.
1412         (extract_info_print_options): Declare new function.
1413         * stack.c (info_locals_command): Update to use new
1414         extract_info_print_options, also add a header comment.
1415         (info_args_command): Likewise.
1416         * symtab.c (info_variables_command): Likewise.
1417         (info_functions_command): Likewise.
1418
1419 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1422         to extract string arguments.
1423         * common/common-utils.c (extract_string_maybe_quoted): New function.
1424         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1425
1426 2019-07-11  Tom Tromey  <tromey@adacore.com>
1427
1428         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1429         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1430         * top.h (gdbinit): Don't declare.
1431         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1432         into...
1433         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1434         * top.c (gdb_init): Don't call init_cli_cmds.
1435         (gdbinit): Remove.
1436         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1437
1438 2019-07-11  Tom Tromey  <tromey@adacore.com>
1439
1440         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1441         after it has been moved.
1442
1443 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1444
1445         * valops.c (value_must_coerce_to_target): Change return type to
1446         bool.
1447         * value.h (value_must_coerce_to_target): Likewise.
1448
1449 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1450
1451         * breakpoint.c (is_hardware_watchpoint): Remove
1452         forward-declaration.
1453         (is_masked_watchpoint): Change return type to bool.
1454         (is_tracepoint): Likewise.
1455         (is_breakpoint): Likewise.
1456         (is_hardware_watchpoint): Likewise.
1457         (is_watchpoint): Likewise.
1458         (is_no_memory_software_watchpoint): Likewise.
1459         (is_catchpoint): Likewise.
1460         (breakpoint_1): Make FILTER parameter's return type bool.
1461         is_masked_watchpoint): Change return type to bool.
1462         (save_breakpoints): Make FILTER parameter's return type bool.
1463         * breakpoint.h (is_breakpoint): Change return type to bool.
1464         (is_watchpoint): Likewise.
1465         (is_catchpoint): Likewise.
1466         (is_tracepoint): Likewise.
1467
1468 2019-07-10  Tom Tromey  <tom@tromey.com>
1469
1470         * defs.h: Don't include gdbarch.h.
1471         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1472         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1473         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1474         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1475         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1476         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1477         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1478         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1479         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1480         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1481         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1482         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1483         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1484         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1485         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1486         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1487         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1488         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1489         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1490         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1491         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1492         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1493         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1494         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1495         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1496         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1497         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1498
1499 2019-07-10  Tom Tromey  <tromey@adacore.com>
1500
1501         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1502         * breakpoint.c (init_ada_exception_breakpoint): Register as
1503         bp_catchpoint.
1504         (print_one_breakpoint_location, print_one_breakpoint): Use
1505         is_ada_exception_catchpoint.
1506         * ada-lang.c (class ada_catchpoint_location): Pass
1507         bp_loc_software_breakpoint to bp_location constructor.
1508         (is_ada_exception_catchpoint): New function.
1509
1510 2019-07-10  Tom Tromey  <tromey@adacore.com>
1511
1512         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1513         VEC.
1514         (struct arm_exidx_entry): New method operator<.
1515         (struct arm_exidx_data) <section_maps>: Change type.
1516         (arm_exidx_data_free): Remove.
1517         (arm_exidx_data_key): Change type.  Move lower.
1518         (arm_exidx_new_objfile): Update.
1519         (arm_compare_exidx_entries): Remove.
1520         (arm_find_exidx_entry, _initialize_arm_tdep)
1521
1522 2019-07-10  Tom Tromey  <tromey@adacore.com>
1523
1524         * solib-spu.c (ocl_program_data_key): Change type.
1525         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1526         Update.
1527
1528 2019-07-10  Tom Tromey  <tromey@adacore.com>
1529
1530         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1531         (struct solib_aix_inferior_data) <library_list>: Change type.
1532         (solib_aix_inferior_data_handle): Change type.
1533         (get_solib_aix_inferior_data): Update.
1534         (solib_aix_free_library_list): Remove.
1535         (library_list_start_library): Update.
1536         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1537         return type.
1538         (solib_aix_get_library_list)
1539         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1540         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1541
1542 2019-07-10  Tom Tromey  <tromey@adacore.com>
1543
1544         * solib-dsbt.c (struct dsbt_info): Add initializers.
1545         (solib_dsbt_pspace_data): Change type.
1546         (dsbt_pspace_data_cleanup): Remove.
1547         (get_dsbt_info, _initialize_dsbt_solib): Update.
1548
1549 2019-07-10  Tom Tromey  <tromey@adacore.com>
1550
1551         * spu-tdep.c (spu_overlay_data): Change type.
1552         (spu_get_overlay_table, spu_overlay_new_objfile)
1553         (_initialize_spu_tdep): Update.
1554
1555 2019-07-10  Tom Tromey  <tromey@adacore.com>
1556
1557         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1558         destructor.
1559         (dbx_objfile_data_key): Change type and declare later.
1560         (DBX_SYMFILE_INFO): Rewrite.
1561         * dbxread.c (dbx_objfile_data_key): Change type.
1562         (dbx_symfile_init): Update.
1563         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1564         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1565         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1566
1567 2019-07-10  Tom Tromey  <tromey@adacore.com>
1568
1569         * jit.c (jit_program_space_key): Change type.  Move lower.
1570         (get_jit_program_space_data): Update.
1571         (jit_program_space_data_cleanup): Remove.
1572         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1573         Update.
1574         (struct jit_program_space_data): Add initializers.
1575
1576 2019-07-10  Tom Tromey  <tromey@adacore.com>
1577
1578         * solib-darwin.c (struct darwin_info): Add initializers.
1579         (solib_darwin_pspace_data): Change type.
1580         (darwin_pspace_data_cleanup): Remove.
1581         (get_darwin_info, _initialize_darwin_solib): Update.
1582
1583 2019-07-10  Tom Tromey  <tromey@adacore.com>
1584
1585         * remote-sim.c (struct sim_inferior_data): Add initializers,
1586         constructor, and destructor.
1587         (sim_inferior_data_key): Change type.  Move lower.
1588         (check_for_duplicate_sim_descriptor): Update.
1589         (get_sim_inferior_data): Use new.  Update.
1590         (~sim_inferior_data_cleanup): Rename from
1591         sim_inferior_data_cleanup.  Simplify.
1592         (gdbsim_close_inferior, simulator_command)
1593         (sim_command_completer, _initialize_remote_sim): Update.
1594         (next_pid, INITIAL_PID): Move earlier.
1595
1596 2019-07-10  Tom Tromey  <tromey@adacore.com>
1597
1598         * python/python-internal.h (create_thread_object): Return
1599         gdbpy_ref.
1600         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1601         * python/py-inferior.c (struct threadlist_entry): Add
1602         constructor.
1603         <thread_obj>: Now a gdbpy_ref.
1604         (thread_to_thread_object): Update.
1605         (add_thread_object): Use new.
1606         (delete_thread_object): Use delete.
1607         (infpy_threads): Update.
1608         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1609         GIL.
1610
1611 2019-07-10  Tom Tromey  <tromey@adacore.com>
1612
1613         * valops.c (value_cast): Specialize error message for Ada.
1614
1615 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1616
1617         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1618
1619 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1620
1621         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1622         bpstat_should_step): Return bool, adjust comments.
1623         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1624         bpstat_should_step): Likewise.
1625
1626 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1627
1628         * features/Makefile: Use feature target descriptions for Arm.
1629         * features/arm/arm-core.c: Generate new file.
1630         * features/arm/arm-fpa.c: Likewise.
1631         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1632         * features/arm/arm-m-profile.c: Likewise.
1633         * features/arm/arm-vfpv2.c: Likewise.
1634         * features/arm/arm-vfpv3.c: Likewise.
1635         * features/arm/xscale-iwmmxt.c: Likewise.
1636         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1637
1638 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1641         ptrace earlier.
1642
1643 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1644
1645         * features/aarch64-pauth.c: Regenerate.
1646
1647 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1648
1649         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1650         bool.
1651         (bpstat_what): Use false instead of 0.
1652
1653 2019-07-09  Pedro Alves  <palves@redhat.com>
1654
1655         * break-catch-throw.c (is_exception_catchpoint): New.
1656         * breakpoint.c (print_one_breakpoint_location): New parameter
1657         'raw_loc'.  Handle it.  Use
1658         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1659         looking at the breakpoint's type.
1660         (print_one_breakpoint): If handling "maint info breakpoints", also
1661         print locations of exception catchpoints.
1662         * breakpoint.h (is_exception_catchpoint): Declare.
1663
1664 2019-07-09  Pedro Alves  <palves@redhat.com>
1665
1666         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1667         "addr" field.
1668         (allocate_location_exception_catchpoint): New.
1669         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1670         (initialize_throw_catchpoint_ops): Install
1671         allocate_location_exception_catchpoint as allocate_location
1672         method.
1673         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1674         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1675         bp_loc_other.
1676         (breakpoint_address_is_meaningful): Delete.
1677         (bl_address_is_meaningful): New.
1678         (breakpoint_locations_match): Adjust comment.
1679         (bp_location_from_bp_type): New, factored out of...
1680         (bp_location::bp_location(breakpoint *)): ... this.
1681         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1682         factored out of...
1683         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1684         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1685         breakpoint_address_is_meaningful.
1686         (bp_locations_compare): Adjust comment.
1687         (update_global_location_list): Use bl_address_is_meaningful
1688         instead of breakpoint_address_is_meaningful.
1689         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1690         explicit.
1691         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1692         * python/py-breakpoint.c (bppy_get_location): No longer check
1693         whether location is null.
1694
1695 2019-07-09  Pedro Alves  <palves@redhat.com>
1696
1697         PR c++/15468
1698         * breakpoint.c (print_one_breakpoint_location): Remove
1699         single-location assert.
1700
1701 2019-07-09  Tom Tromey  <tom@tromey.com>
1702
1703         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1704         * configure: Rebuild.
1705         * configure.ac: Change common to gdbsupport.
1706         * gdbsupport: Rename from common.
1707         * acinclude.m4: Change common to gdbsupport.
1708         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1709         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1710         gdbsupport.
1711         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1712         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1713         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1714         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1715         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1716         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1717         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1718         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1719         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1720         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1721         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1722         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1723         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1724         coff-pe-read.c, command.h, compile/compile-c-support.c,
1725         compile/compile-c.h, compile/compile-cplus-symbols.c,
1726         compile/compile-cplus-types.c, compile/compile-cplus.h,
1727         compile/compile-loc2c.c, compile/compile.c, completer.c,
1728         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1729         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1730         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1731         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1732         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1733         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1734         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1735         features/aarch64-core.c, features/aarch64-fpu.c,
1736         features/aarch64-pauth.c, features/aarch64-sve.c,
1737         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1738         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1739         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1740         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1741         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1742         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1743         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1744         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1745         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1746         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1747         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1748         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1749         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1750         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1751         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1752         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1753         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1754         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1755         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1756         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1757         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1758         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1759         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1760         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1761         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1762         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1763         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1764         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1765         minsyms.c, mips-linux-tdep.c, namespace.h,
1766         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1767         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1768         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1769         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1770         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1771         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1772         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1773         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1774         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1775         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1776         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1777         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1778         procfs.c, producer.c, progspace.h, psymtab.h,
1779         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1780         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1781         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1782         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1783         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1784         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1785         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1786         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1787         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1788         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1789         target-memory.c, target.c, target.h, target/waitstatus.c,
1790         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1791         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1792         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1793         unittests/array-view-selftests.c,
1794         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1795         unittests/common-utils-selftests.c,
1796         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1797         unittests/format_pieces-selftests.c,
1798         unittests/function-view-selftests.c,
1799         unittests/lookup_name_info-selftests.c,
1800         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1801         unittests/mkdir-recursive-selftests.c,
1802         unittests/observable-selftests.c,
1803         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1804         unittests/parse-connection-spec-selftests.c,
1805         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1806         unittests/scoped_fd-selftests.c,
1807         unittests/scoped_mmap-selftests.c,
1808         unittests/scoped_restore-selftests.c,
1809         unittests/string_view-selftests.c, unittests/style-selftests.c,
1810         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1811         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1812         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1813         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1814         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1815         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1816
1817 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1820         bool value.
1821         (decode_digits_ordinary): Set explicit_line field in sal.
1822         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1823         symtab_and_line that was set on an explicit line number in
1824         assembler code.  Do always update the recorded symtab and line if
1825         we do skip the prologue.
1826
1827 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1828
1829         * breakpoint.c (set_breakpoint_location_function): Remove
1830         explicit_loc parameter.
1831         (momentary_breakpoint_from_master): Update call to
1832         set_breakpoint_location_function.
1833         (add_location_to_breakpoint): Likewise.
1834
1835 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1838         required features based on default bfd type when no specific bfd
1839         is present.
1840
1841 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1842
1843         * NEWS: Mention that GDB printf and eval commands can now print
1844         C-style and Ada-style convenience var strings without
1845         calling the inferior.
1846         * printcmd.c (printf_c_string): Locally print GDB internal var
1847         instead of transiting via the inferior.
1848         (printf_wide_c_string): Likewise.
1849
1850 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1851
1852         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1853
1854 2019-07-04  Tom Tromey  <tom@tromey.com>
1855
1856         PR tui/24724:
1857         * tui/tui-winsource.c (tui_clear_source_content): Update.
1858         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1859         (tui_update_breakpoint_info): Update.
1860         (tui_set_exec_info_content): Update.
1861         * tui/tui-source.c (tui_set_source_content_nil): Update.
1862         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1863         has_break.
1864         * tui/tui-data.h (enum tui_bp_flag): New.
1865         (tui_bp_flags): New enum flags type.
1866         (struct tui_source_element) <break_mode>: Change type.  Rename
1867         from has_break.
1868         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1869         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1870         constants.
1871         * tui/tui-winsource.h: Fix comment.
1872
1873 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1874
1875         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1876         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1877         (store_fpregs_to_thread)
1878         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1879         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1880         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1881         (IWMMXT_REGS_SIZE): Add define.
1882         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1883         (fetch_vfp_regs, store_vfp_regs)
1884         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1885         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1886
1887 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1888
1889         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1890         defines.
1891         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1892         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1893         (ARM_INT_REGISTER_SIZE): ...to this.
1894         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1895         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1896         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1897         (arm_linux_collect_gregset, supply_nwfpe_register)
1898         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1899         defines.
1900         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1901         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1902         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1903         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1904         (arm_return_in_memory, arm_store_return_value)
1905         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1906         (arm_record_ld_st_multiple): Likewise.
1907         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1908         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1909
1910 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1911
1912         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1913         AARCH64_DISPLACED_MODIFIED_INSNS.
1914         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1915         (aarch64_displaced_step_copy_insn): Likewise.
1916         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1917         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1918         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1919         ARM_DISPLACED_MODIFIED_INSNS.
1920         * arm-tdep.c (arm_gdbarch_init): Likewise.
1921         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1922         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1923         (struct arm_displaced_step_closure): Use
1924         ARM_DISPLACED_MODIFIED_INSNS.
1925
1926 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1927
1928         * features/Makefile: Remove unused xml files.
1929         * features/aarch64.xml: Remove.
1930         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1931         * features/i386/amd64-avx-avx512.xml: Remove.
1932         * features/i386/amd64-avx-linux.xml: Remove.
1933         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1934         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1935         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1936         * features/i386/amd64-avx-mpx.xml: Remove.
1937         * features/i386/amd64-avx.xml: Remove.
1938         * features/i386/amd64-linux.xml: Remove.
1939         * features/i386/amd64-mpx-linux.xml: Remove.
1940         * features/i386/amd64-mpx.xml: Remove.
1941         * features/i386/amd64.xml: Remove.
1942         * features/i386/i386-avx-avx512-linux.xml: Remove.
1943         * features/i386/i386-avx-avx512.xml: Remove.
1944         * features/i386/i386-avx-linux.xml: Remove.
1945         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1946         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1947         * features/i386/i386-avx-mpx-linux.xml: Remove.
1948         * features/i386/i386-avx-mpx.xml: Remove.
1949         * features/i386/i386-avx.xml: Remove.
1950         * features/i386/i386-linux.xml: Remove.
1951         * features/i386/i386-mmx-linux.xml: Remove.
1952         * features/i386/i386-mmx.xml: Remove.
1953         * features/i386/i386-mpx-linux.xml: Remove.
1954         * features/i386/i386-mpx.xml: Remove.
1955         * features/i386/i386.xml: Remove.
1956         * features/i386/x32-avx-avx512-linux.xml: Remove.
1957         * features/i386/x32-avx-linux.xml: Remove.
1958         * features/i386/x32-linux.xml: Remove.
1959
1960 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1961
1962         * regformats/aarch64.dat: Remove.
1963         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1964         * regformats/i386/amd64-avx-linux.dat: Remove.
1965         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1966         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1967         * regformats/i386/amd64-linux.dat: Remove.
1968         * regformats/i386/amd64-mpx-linux.dat: Remove.
1969         * regformats/i386/amd64.dat: Remove.
1970         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1971         * regformats/i386/i386-avx-linux.dat: Remove.
1972         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1973         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1974         * regformats/i386/i386-linux.dat: Remove.
1975         * regformats/i386/i386-mmx-linux.dat: Remove.
1976         * regformats/i386/i386-mpx-linux.dat: Remove.
1977         * regformats/i386/i386.dat: Remove.
1978         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1979         * regformats/i386/x32-avx-linux.dat: Remove.
1980         * regformats/i386/x32-linux.dat: Remove.
1981
1982 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1983
1984         * aarch64-tdep.c: Remove xml self tests.
1985         * amd64-linux-tdep.c: Likewise.
1986         * amd64-tdep.c: Likewise.
1987         * i386-linux-tdep.c: Likewise.
1988         * i386-tdep.c: Likewise.
1989
1990 2019-07-03  Pedro Alves  <palves@redhat.com>
1991
1992         PR cli/24732
1993         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1994         (pipe_cmd_option_defs): New.
1995         (make_pipe_cmd_options_def_group): New.
1996         (pipe_command): Use gdb::option::process_options.
1997         (pipe_command_completer): New function.
1998         (_initialize_cli_cmds): Install completer for "pipe" command.
1999
2000 2019-07-03  Pedro Alves  <palves@redhat.com>
2001
2002         * cli/cli-option.c (union option_value) <string>: New field.
2003         (struct option_def_and_value): Add ctor, move ctor, dtor and
2004         use DISABLE_COPY_AND_ASSIGN.
2005         (option_def_and_value::clear_value): New.
2006         (parse_option, save_option_value_in_ctx, get_val_type_str)
2007         (add_setshow_cmds_for_options): Handle var_string.
2008         * cli-option.h (union option_def::var_address) <string>: New
2009         field.
2010         (struct string_option_def): New.
2011         * maint-test-options.c (struct test_options_opts): Add default
2012         ctor and use DISABLE_COPY_AND_ASSIGN.
2013         <string_opt>: New field.
2014         (test_options_opts::~test_options_opts): New.
2015         (test_options_opts::dump): Also dump "-string".
2016         (test_options_option_defs): Install "string.
2017
2018 2019-07-03  Pedro Alves  <palves@redhat.com>
2019
2020         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2021         option_value with a null enumeration.
2022         (complete_options): Save the option values in the context.
2023         (save_option_value_in_ctx): New, factored out from ...
2024         (process_options): ... here.
2025         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2026         of the function.
2027         * maint-test-options.c (test_options_opts::dump): New, factored
2028         out from ...
2029         (maintenance_test_options_command_mode): ... here.
2030         (maintenance_test_options_command_completion_result): Delete.
2031         (maintenance_test_options_command_completion_text): Update
2032         comment.
2033         (maintenance_show_test_options_completion_result): Change
2034         prototype.  Just print
2035         maintenance_test_options_command_completion_text.
2036         (save_completion_result): New.
2037         (maintenance_test_options_completer_mode): Pass options context to
2038         complete_options, and then save a dump.
2039         (_initialize_maint_test_options): Use add_cmd to install "maint
2040         show test-options-completion-result".
2041
2042 2019-07-03  Pedro Alves  <palves@redhat.com>
2043
2044         * NEWS (New commands): Mention "with" and "maint with".
2045         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2046         (with_command, with_command_completer): New.
2047         (pipe_command): Adjust to new repeat_previous
2048         interface.
2049         (_initialize_cli_cmds): Install the "with" command and its "w"
2050         alias.
2051         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2052         declarations.
2053         * cli/cli-setshow.c (parse_cli_var_uinteger)
2054         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2055         argument strings for all var_types.
2056         (get_setshow_command_value_string): New, factored out from ...
2057         (do_show_command): ... this.
2058         * cli/cli-setshow.h: Include <string>.
2059         (get_setshow_command_value_string): Declare.
2060         * command.h (repeat_previous): Now returns const char *.  Adjust
2061         comment.
2062         * maint.c: Include "cli/cli-cmds.h".
2063         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2064         (_initialize_maint_cmds): Register the "maintenance with" command.
2065         * top.c (repeat_previous): Move bits from pipe_command here:
2066         Return the saved command line, if any; error out if there's no
2067         command to relaunch.
2068
2069 2019-07-03  Pedro Alves  <palves@redhat.com>
2070
2071         * NEWS (New commands): Mention "maint set/show test-settings"
2072         instead of "maint test-settings".
2073         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2074         (maintenance_test_settings_set_list): Rename to ...
2075         (maintenance_set_test_settings_list): ... this.
2076         (maintenance_test_settings_show_list): Rename to  ...
2077         (maintenance_show_test_settings_list): ... this.
2078         (maintenance_test_settings_cmd): Delete.
2079         (maintenance_test_settings_set_cmd): ...
2080         (maintenance_set_test_settings_cmd): ... this.
2081         (maintenance_test_settings_show_cmd): ...
2082         (maintenance_show_test_settings_cmd): ... this.
2083         (maintenance_test_settings_show_value_cmd):
2084         (maintenance_show_test_settings_value_cmd): ... this.
2085         (_initialize_maint_test_settings): No longer install the "maint
2086         test-settings" prefix command.  Rename "maint test-settings set"
2087         to "maint set test-settings", and "maint test-settings show" to
2088         "maint show test-settings".  Adjust all subcommands.
2089
2090 2019-07-03  Pedro Alves  <palves@redhat.com>
2091
2092         * maint-test-settings.c: Fix file's intro comment.  Replace all
2093         references to "test-options" with references to "test-settings",
2094         in comments.
2095
2096 2019-07-03  Pedro Alves  <palves@redhat.com>
2097
2098         * maint-test-settings.c (maintenance_test_settings_xxx)
2099         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2100         New.
2101         (maintenance_test_settings_enums): Use them.
2102         (maintenance_test_settings_enum): Default to
2103         maintenance_test_settings_xxx.
2104         (_initialize_maint_test_settings): Initialize
2105         MAINTENANCE_TEST_SETTINGS_FILENAME.
2106
2107 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2108
2109         * breakpoint.h (remove_breakpoints_inf): Change return type to
2110         void, move function documentation here.
2111         * breakpoint.c (remove_breakpoints_inf): Change return type to
2112         void, move function documentation to header.
2113
2114 2019-07-02  Pedro Alves  <palves@redhat.com>
2115
2116         * NEWS (Completion improvements): Mention "info threads".
2117         * thread.c (struct info_threads_opts, info_threads_option_defs)
2118         (make_info_threads_options_def_group): New.
2119         (info_threads_command): Use gdb::option::process_options.
2120         (info_threads_command_completer): New.
2121         (_initialize_thread): Use gdb::option::build_help to build the
2122         help text for "info threads".
2123
2124 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2125
2126         * defs.h (generic_load): Move from here...
2127         * symfile.h (generic_load): ... to here.  Rename name parameter
2128         to args.
2129         * symfile.c (generic_load): Add comment.
2130
2131 2019-07-01  Tom Tromey  <tromey@adacore.com>
2132
2133         * dwarf2read.c
2134         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2135         declaration of without_params.  Fix formatting.
2136
2137 2019-07-01  Tom Tromey  <tromey@adacore.com>
2138
2139         * ada-exp.y (find_primitive_type): Update.
2140         * ada-lang.h (ada_lookup_symbol): Update.
2141         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2142         parameter.
2143         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2144
2145 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2146
2147         PR breakpoints/24541
2148         * gdbarch.c: Regenerate.
2149         * gdbarch.h: Regenerate.
2150         * gdbarch.sh: Add 'stap_adjust_register'.
2151         * i386-tdep.c: Include '<unordered_set>'.
2152         (i386_stap_adjust_register): New function.
2153         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2154         * stap-probe.c (stap_parse_register_operand): Call
2155         'gdbarch_stap_adjust_register'.
2156
2157 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2158
2159         PR python/24742
2160         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2161         * python/python.c (do_start_initialization): Use 'xmalloc'
2162         instead of 'PyMem_Malloc'.
2163
2164 2019-06-28  Tom Tromey  <tromey@adacore.com>
2165
2166         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2167         for Ada.
2168
2169 2019-06-27  Tom Tromey  <tromey@adacore.com>
2170
2171         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2172         objfile_key.
2173         (arm_find_mapping_symbol, arm_record_special_symbol)
2174         (_initialize_arm_tdep): Update.
2175         (arm_objfile_data_free): Remove.
2176
2177 2019-06-27  Tom Tromey  <tromey@adacore.com>
2178
2179         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2180         to cp_print_static_field.
2181
2182 2019-06-26  Tom Tromey  <tromey@adacore.com>
2183
2184         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2185         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2186         declare.
2187
2188 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2189
2190         * features/aarch64-core.c (create_feature_aarch64_core):
2191         Regenerate.
2192         * features/aarch64-core.xml: Add cpsr flags.
2193
2194 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2197         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2198
2199 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2200
2201         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2202         field.
2203         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2204         use.
2205         (arm_record_special_symbol): Don't insert new symbol in sorted
2206         position, push it at the end.
2207
2208 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2209
2210         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2211         (arm_mapping_symbol_s): Remove.
2212         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2213         (arm_mapping_symbol_vec): New typedef.
2214         (struct arm_per_objfile): Add constructor.
2215         <section_maps>: Change type to
2216         std::unique_ptr<arm_mapping_symbol_vec[]>.
2217         (arm_compare_mapping_symbols): Remove.
2218         (arm_find_mapping_symbol): Adjust to section_maps type change.
2219         (arm_objfile_data_free): Call delete on arm_per_objfile.
2220         (arm_record_special_symbol): Adjust to section_maps type change.
2221         Allocate arm_per_objfile with new.
2222
2223 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2224
2225         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2226         with the command prefix.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2231         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2236         type.
2237         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2238         protected.
2239
2240 2019-06-25  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-winsource.c
2243         (tui_source_window_base::set_is_exec_point_at): Add check against
2244         LOA_ADDRESS.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-source.c (tui_set_source_content): Don't check before
2249         xfree.
2250         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-winsource.h (tui_update_source_window_as_is)
2255         (tui_alloc_source_buffer, tui_line_is_displayed)
2256         (tui_addr_is_displayed): Change type of win_info.
2257         * tui/tui-winsource.c (tui_update_source_window_as_is)
2258         (tui_clear_source_content, tui_show_source_line)
2259         (tui_show_source_content, tui_source_window_base::refill)
2260         (tui_source_window_base::set_is_exec_point_at)
2261         (tui_source_window_base::set_is_exec_point_at)
2262         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2263         (tui_alloc_source_buffer, tui_line_is_displayed)
2264         (tui_addr_is_displayed): Change type of win_info.  Update.
2265         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2266         (tui_source_window_base::do_make_visible_with_new_height):
2267         Update.
2268         * tui/tui-source.c (tui_set_source_content)
2269         (tui_set_source_content_nil)
2270         (tui_source_window::do_scroll_vertical): Update.
2271         * tui/tui-layout.c (show_layout): Update.
2272         * tui/tui-disasm.c (tui_set_disassem_content)
2273         (tui_disasm_window::do_scroll_vertical): Update.
2274         * tui/tui-data.h (tui_win_content): Remove.
2275         (struct tui_gen_win_info) <content, content_size>: Remove.
2276         (struct tui_source_element): Add initializers and destructor.
2277         (union tui_which_element, struct tui_win_element): Remove.
2278         (struct tui_source_window_base) <content>: New field.
2279         (struct tui_data_window): Remove destructor.
2280         (tui_alloc_content, tui_free_win_content)
2281         (tui_free_all_source_wins_content): Don't declare.
2282         * tui/tui-data.c (tui_initialize_static_data): Update.
2283         (init_content_element, tui_alloc_content): Remove.
2284         (~tui_gen_win_info): Update.
2285         (~tui_data_window, tui_free_all_source_wins_content)
2286         (tui_free_win_content, free_content, free_content_elements):
2287         Remove.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-winsource.h (tui_clear_source_content)
2292         (tui_erase_source_content, tui_show_source_content): Change type
2293         of win_info.
2294         * tui/tui-winsource.c (tui_clear_source_content)
2295         (tui_erase_source_content, tui_show_source_content): Change type
2296         of win_info.
2297         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2298         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2299         win_info.
2300         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2301         win_info.
2302         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2303
2304 2019-06-25  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-winsource.c (tui_clear_source_content)
2307         (tui_source_window_base::set_is_exec_point_at): Update.
2308         * tui/tui-source.c (tui_set_source_content_nil): Update.
2309         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2310         a bool.
2311         * tui/tui-data.c (init_content_element): Update.
2312
2313 2019-06-25  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2316         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2317         * tui/tui-layout.c (init_and_make_win): Update.
2318         * tui/tui.h (enum tui_win_type): Update.
2319         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2320         tui_win_is_auxillary.
2321         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2322         tui_win_is_auxillary.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2327         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2328         (tui_delete_data_content_windows, tui_display_all_data)
2329         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2330         Update.
2331         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2332         * tui/tui-regs.c (tui_last_regs_line_no)
2333         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2334         (tui_show_registers): Update.
2335         (tui_show_register_group): Return void.  Update.
2336         (tui_display_registers_from, tui_display_reg_element_at_line)
2337         (tui_display_registers_from_line, tui_check_register_values):
2338         Update.
2339         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2340         member.
2341         (struct tui_data_window) <regs_content>: Now a std::vector.
2342         <regs_content_count>: Remove.
2343         (tui_add_content_elements, tui_free_data_content): Don't declare.
2344         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2345         (init_content_element): Remove DATA_WIN case.  Add assert.
2346         (tui_add_content_elements): Remove.
2347         (tui_data_window): Update.
2348         (tui_free_data_content): Remove.
2349         (free_content_elements): Remove DATA_WIN case.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-data.c (tui_data_item_window): Update.
2354         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2355         * tui/tui-windata.c (tui_display_all_data)
2356         (tui_display_data_from_line): Update.
2357         (tui_check_data_values): Remove.
2358         * tui/tui-regs.c (tui_show_register_group)
2359         (tui_display_reg_element_at_line): Update.
2360         * tui/tui-hooks.c (tui_register_changed)
2361         (tui_refresh_frame_and_register_information): Call
2362         tui_check_register_values.
2363         * tui/tui-data.h (struct tui_data_window) <data_content,
2364         data_content_count, data_type>: Remove.
2365         (enum tui_data_type): Remove.
2366
2367         * tui/tui-data.c (tui_data_window::clear_detail)
2368         (~tui_data_window): Update.
2369
2370 2019-06-25  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2373         declare.
2374         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2375         Rename from tui_first_data_item_displayed.  Update.
2376         (tui_data_window::refresh_all)
2377         (tui_data_window::do_scroll_vertical): Update.
2378         * tui/tui-data.h (struct tui_data_window)
2379         <first_data_item_displayed>: Declare new method.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2384         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2385         contents...
2386         (tui_initialize_static_data): ...here.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2391         (tui_display_registers_from, tui_check_register_values): Update.
2392         (tui_display_register): Remove win_info parameter; update.
2393         (tui_get_register): Change type of parameters.
2394         * tui/tui-data.h (struct tui_data_element): Remove.
2395         (union tui_which_element) <data>: Remove.
2396         <data_window>: Change type.
2397         (struct tui_data_item_window): New.
2398         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2399         case.  Add assert.
2400         (~tui_data_item_window): New destructor.
2401         (free_content_elements): Remove DATA_ITEM_WIN case.
2402
2403 2019-06-25  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2406         Remove.
2407
2408 2019-06-25  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-data.h (struct tui_command_element): Remove.
2411         (union tui_which_element) <command>: Remove.
2412         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2413         assert.
2414         (free_content_elements): Remove CMD_WIN case.
2415
2416 2019-06-25  Tom Tromey  <tom@tromey.com>
2417
2418         * tui/tui-layout.c (tui_set_layout): Update.
2419         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2420         * tui/tui-data.c (layout_def): Update.
2421
2422 2019-06-25  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2425         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2426         (tui_source_window_base::set_new_height): Update.
2427         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2428         Update.
2429         (tui_set_locator_fullname, tui_set_locator_info)
2430         (tui_show_frame_info): Update.
2431         * tui/tui-source.c (tui_set_source_content)
2432         (tui_source_is_displayed): Update.
2433         * tui/tui-layout.c (show_source_disasm_command, show_data)
2434         (show_source_or_disasm_and_command): Update.
2435         * tui/tui-disasm.c (tui_set_disassem_content)
2436         (tui_get_begin_asm_address): Update.
2437         * tui/tui-data.h (struct tui_locator_element): Remove.
2438         (union tui_which_element) <locator>: Remove.
2439         (struct tui_locator_window): New.
2440         (tui_locator_win_info_ptr): Change return type.
2441         * tui/tui-data.c (_locator): Change type.
2442         (tui_locator_win_info_ptr): Change return type.
2443         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2444         (tui_alloc_content): Add assert.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-winsource.c
2449         (tui_exec_info_window::maybe_allocate_content): New method.
2450         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2451         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2452         (make_source_or_disasm_window): Add cast.
2453         * tui/tui-data.h (union tui_which_element) <simple_string>:
2454         Remove.
2455         (struct tui_source_info): New.
2456         (struct tui_source_window_base) <execution_info>: Change type.
2457         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2458         case, and add assert.
2459         (tui_alloc_content): Add assert.
2460
2461 2019-06-25  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2464         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2465         * tui/tui-data.c (tui_alloc_win_info): Remove.
2466
2467 2019-06-25  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2470         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2471         can_highlight.
2472
2473 2019-06-25  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2476         make_visible_with_new_height method.
2477         (tui_win_info::make_visible_with_new_height): New method.
2478         (tui_source_window_base::do_make_visible_with_new_height)
2479         (tui_data_window::do_make_visible_with_new_height)
2480         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2481         (make_visible_with_new_height): Remove.
2482         (tui_resize_all, tui_adjust_win_heights): Use
2483         make_visible_with_new_height method.
2484         * tui/tui-data.h (struct tui_win_info)
2485         <do_make_visible_with_new_height, make_visible_with_new_height>:
2486         New methods.
2487         (struct tui_source_window_base, struct tui_data_window)
2488         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2489         methods.
2490
2491 2019-06-25  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2494         method.
2495         (update_tab_width): Call update_tab_width method.
2496         * tui/tui-data.h (struct tui_win_info)
2497         (struct tui_source_window_base) <update_tab_width>: New methods.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2502         parameter.
2503         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2504         parameter.
2505         (tui_gen_win_info::make_visible): Update.
2506         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2507         parameter.
2508         * tui/tui-data.h (enum tui_box): New enum.
2509         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2510
2511 2019-06-25  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2514         init_and_make_win for EXEC_INFO_WIN.
2515         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2516         longer inline.
2517         (struct tui_win_info) <~tui_win_info>: Inline.
2518         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2519         Don't declare.
2520         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2521         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2522         Remove.
2523         (tui_initialize_static_data): Update.
2524         (~tui_gen_win_info): Handle more cleanup here.
2525         (~tui_source_window_base): Delete "execution_info".
2526         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2527
2528 2019-06-25  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-layout.c (make_command_window): Don't set
2531         can_highlight.
2532         (show_source_disasm_command): Call the reset method.
2533         (show_data): Don't set can_highlight.  Call the reset method.
2534         (tui_gen_win_info::reset): Rename from init_gen_win_info
2535         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2536         (show_source_or_disasm_and_command): Call the reset method.
2537         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2538         (struct tui_cmd_window): Set can_highlight.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2543         from make_visible.
2544         (tui_make_visible, tui_make_invisible): Rewrite.
2545         (tui_win_info::make_visible): Remove.
2546         (tui_source_window_base::make_visible): Update.
2547         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2548         method.  Moved from...
2549         (struct tui_win_info) <make_visible>: ...here.
2550
2551 2019-06-25  Tom Tromey  <tom@tromey.com>
2552
2553         * tui/tui-winsource.c
2554         (tui_source_window_base::do_scroll_horizontal): Remove direction
2555         parameter.
2556         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2557         direction parameter.
2558         * tui/tui-win.c (tui_win_info::forward_scroll)
2559         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2560         (tui_win_info::right_scroll): Update.
2561         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2562         direction parameter.
2563         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2564         direction parameter.
2565         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2566         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2567         Remove direction parameter.
2568         (struct tui_source_window_base, struct tui_source_window)
2569         (struct tui_disasm_window, struct tui_data_window)
2570         (struct tui_cmd_window): Update.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-winsource.h (tui_set_exec_info_content)
2575         (tui_show_exec_info_content, tui_erase_exec_info_content)
2576         (tui_clear_exec_info_content, tui_update_exec_info): Change
2577         argument to tui_source_window_base.
2578         * tui/tui-winsource.c (tui_set_exec_info_content)
2579         (tui_show_exec_info_content, tui_erase_exec_info_content)
2580         (tui_clear_exec_info_content, tui_update_exec_info): Change
2581         argument to tui_source_window_base.
2582
2583 2019-06-25  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2586         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2591         check.
2592
2593 2019-06-25  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2596         type to void.
2597         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2598         type to void.
2599         * tui/tui-source.c (tui_set_source_content): Update.
2600         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-win.c (window_name_completer, tui_set_focus)
2605         (tui_all_windows_info): Use name method.
2606         * tui/tui-data.h (struct tui_gen_win_info)
2607         (struct tui_source_window, struct tui_disasm_window)
2608         (struct tui_data_window, struct tui_cmd_window) <name>: New
2609         method.
2610         (tui_win_name): Don't declare.
2611         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2612         (tui_win_name): Remove.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-winsource.h (tui_update_source_window)
2617         (tui_update_source_window_as_is): Change parameter type.
2618         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2619         to be a tui_source_window_base.
2620         (tui_update_source_window_as_is): Likewise.
2621         * tui/tui-win.c (make_visible_with_new_height): Update.
2622
2623 2019-06-25  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-winsource.c (tui_erase_source_content)
2626         (tui_show_source_content, tui_show_exec_info_content)
2627         (tui_erase_exec_info_content): Use refresh_window method.
2628         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2629         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2630         from tui_refresh_win.
2631         (tui_data_window::refresh_window): New method.
2632         (tui_win_info::refresh, tui_source_window_base::refresh)
2633         (tui_refresh_all): Use refresh_window method.
2634         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2635         method.
2636         * tui/tui-regs.c (tui_display_register): Call refresh_window
2637         method.
2638         * tui/tui-layout.c (show_source_disasm_command)
2639         (show_source_or_disasm_and_command): Call refresh_window method.
2640         * tui/tui-data.h (struct tui_gen_win_info)
2641         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2642         New method.
2643
2644 2019-06-25  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui.c (tui_rl_other_window, tui_enable)
2647         (tui_is_window_visible, tui_get_command_dimension): Update.
2648         * tui/tui-winsource.c (tui_update_source_window_as_is)
2649         (tui_clear_source_content, tui_erase_source_content)
2650         (tui_show_source_line, tui_source_window_base::refill)
2651         (tui_source_window_base::do_scroll_horizontal)
2652         (tui_source_window_base::set_is_exec_point_at)
2653         (tui_update_breakpoint_info, tui_set_exec_info_content)
2654         (tui_alloc_source_buffer, tui_line_is_displayed)
2655         (tui_addr_is_displayed): Update.
2656         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2657         (tui_check_and_display_highlight_if_needed)
2658         (tui_win_info::make_visible, tui_win_info::refresh)
2659         (tui_refresh_all): Update.
2660         * tui/tui-windata.c (tui_first_data_item_displayed)
2661         (tui_delete_data_content_windows, tui_erase_data_content)
2662         (tui_display_all_data, tui_data_window::refresh_all)
2663         (tui_check_data_values): Update.
2664         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2665         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2666         (tui_win_info::backward_scroll, tui_refresh_all_win)
2667         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2668         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2669         (tui_source_window_base::set_new_height)
2670         (tui_data_window::set_new_height)
2671         (make_invisible_and_set_new_height)
2672         (make_visible_with_new_height, new_height_ok)
2673         (parse_scrolling_args): Update.
2674         * tui/tui-stack.c (tui_show_frame_info): Update.
2675         * tui/tui-source.c (tui_set_source_content)
2676         (tui_set_source_content_nil, tui_source_is_displayed)
2677         (tui_source_window::do_scroll_vertical): Update.
2678         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2679         (tui_display_registers_from, tui_display_reg_element_at_line)
2680         (tui_check_register_values, tui_reg_command): Update.
2681         * tui/tui-layout.c (tui_default_win_height)
2682         (show_source_disasm_command, show_data, init_and_make_win)
2683         (show_source_or_disasm_and_command): Update.
2684         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2685         (tui_redisplay_readline, tui_mld_flush)
2686         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2687         (tui_getc): Update.
2688         * tui/tui-disasm.c (tui_set_disassem_content)
2689         (tui_disasm_window::do_scroll_vertical): Update.
2690         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2691         Now virtual.
2692         (struct tui_win_info): Derive from tui_gen_win_info.
2693         <~tui_win_info>: Mark as override.
2694         <generic>: Remove member.
2695         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2696         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2697         (~tui_data_window, ~tui_win_info)
2698         (tui_free_all_source_wins_content): Update.
2699         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2700
2701 2019-06-25  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-layout.c (init_and_make_win): Use new.
2704         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2705         destructor, initializers.
2706         (tui_alloc_generic_win_info): Don't declare.
2707         * tui/tui-data.c (_locator): Add argument to constructor.
2708         (source_win, disasm_win): New globals.
2709         (exec_info): Remove.
2710         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2711         Update.
2712         (tui_alloc_generic_win_info): Remove.
2713         (init_content_element): Use new.
2714         (tui_win_info::tui_win_info): Update.
2715         (free_content_elements) <case DATA_WIN>: Use delete.
2716
2717 2019-06-25  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2720         * tui/tui-windata.c (tui_first_data_item_displayed)
2721         (tui_delete_data_content_windows): Update.
2722         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2723         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2724         (tui_display_registers_from, tui_check_register_values): Update.
2725         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2726         pointer.
2727         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2728         window.
2729         (tui_free_data_content): Update.
2730         (free_content_elements) <case DATA_WIN>: Free the window.
2731
2732 2019-06-25  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2735         Update.
2736         * tui/tui-layout.c (make_command_window)
2737         (show_source_disasm_command, show_data, init_and_make_win)
2738         (show_source_or_disasm_and_command): Update.
2739         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2740         method.
2741         <can_highight, is_highlighted>: Now bool.
2742         (tui_set_win_highlight): Don't declare.
2743         * tui/tui-data.c (tui_set_win_highlight): Remove.
2744
2745 2019-06-25  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-wingeneral.c (make_visible): Remove check of window
2748         type.
2749
2750 2019-06-25  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-win.c (tui_win_info::max_height)
2753         (tui_cmd_window::max_height): New methods.
2754         (new_height_ok): Call max_height.
2755         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2756         <max_height>: New method.
2757
2758 2019-06-25  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-win.c (tui_source_window_base::set_new_height)
2761         (tui_data_window::set_new_height): New methods.
2762         (make_invisible_and_set_new_height): Call set_new_height method.
2763         * tui/tui-data.h (struct tui_win_info)
2764         (struct tui_source_window_base, struct tui_data_window)
2765         <set_new_height>: New method.
2766
2767 2019-06-25  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2770         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2771         tui_refresh_data_win.
2772         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2773         method.
2774         (tui_refresh_all_win): Call the refresh_all method.
2775         (tui_set_focus): Likewise.
2776         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2777         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2778         Likewise.
2779
2780 2019-06-25  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-winsource.h (tui_refill_source_window)
2783         (tui_set_is_exec_point_at): Don't declare.
2784         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2785         (tui_source_window_base::refill): Rename from
2786         tui_refill_source_window.
2787         (tui_source_window_base::do_scroll_horizontal): Update.
2788         (tui_source_window_base::set_is_exec_point_at): Rename from
2789         tui_set_is_exec_point_at.
2790         (tui_update_all_breakpoint_info): Update.
2791         * tui/tui-stack.c (tui_show_frame_info): Update.
2792         * tui/tui-layout.c (show_data): Add cast.
2793         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2794         * tui/tui-data.h (struct tui_source_window_base) <refill,
2795         set_is_exec_point_at>: New methods.
2796         (tui_source_windows, tui_add_to_source_windows): Update types.
2797         (tui_add_to_source_windows): Remove redundant declaration.
2798         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2799         (tui_source_windows): Change return type.
2800         (tui_clear_source_windows_detail): Update.
2801         (tui_add_to_source_windows): Change type of parameter.
2802         (tui_free_all_source_wins_content): Update.
2803
2804 2019-06-25  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-wingeneral.c (tui_win_info::refresh)
2807         (tui_source_window_base::refresh): New methods.
2808         (tui_refresh_all): Call the refresh method.
2809         * tui/tui-data.h (struct tui_win_info)
2810         (struct tui_source_window_base) <refresh>: New method.
2811
2812 2019-06-25  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui.h (tui_is_window_visible): Return bool.
2815         * tui/tui.c (tui_is_window_visible): Return bool.
2816         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2817         (tui_make_visible, tui_make_invisible)
2818         (tui_win_info::make_visible)
2819         (tui_source_window_base::make_visible, make_all_visible)
2820         (tui_make_all_visible, tui_make_all_invisible): Update.
2821         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2822         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2823         bool.
2824         (struct tui_win_info, struct tui_source_window_base)
2825         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2826         * tui/tui-data.c (tui_init_generic_part): Update.
2827
2828 2019-06-25  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2831         (tui_source_window_base::make_visible): New methods.
2832         (make_all_visible): Make method call.
2833         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2834         (struct tui_source_window_base, struct tui_cmd_window): Override
2835         make_visible.
2836         (tui_win_is_source_type): Don't declare.
2837         * tui/tui-data.c (tui_win_is_source_type): Remove.
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2842         NULL check.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2847         Inline constructor.  Add initializers for members.
2848         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2849         constructors; now inline in class.
2850
2851 2019-06-25  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-regs.c (tui_show_registers): Update.
2854         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2855         bool.
2856         * tui/tui-data.c (tui_data_window::clear_detail)
2857         (tui_data_window): Update.
2858
2859 2019-06-25  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-windata.c (tui_display_all_data)
2862         (tui_display_data_from_line, tui_display_data_from)
2863         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2864         Update.
2865         * tui/tui-regs.c (tui_last_regs_line_no)
2866         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2867         (tui_show_registers, tui_show_register_group)
2868         (tui_display_registers_from, tui_display_reg_element_at_line)
2869         (tui_display_registers_from_line, tui_check_register_values)
2870         (tui_reg_next, tui_reg_prev): Update.
2871         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2872         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2873         tui_data_window.
2874         (struct tui_win_info) <detail>: Remove.  Add new fields from
2875         tui_data_info.
2876         (TUI_DATA_WIN): Add cast.
2877         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2878         (~tui_data_window): Simplify.
2879
2880 2019-06-25  Tom Tromey  <tom@tromey.com>
2881
2882         * tui/tui-layout.c (show_source_disasm_command)
2883         (show_source_or_disasm_and_command): Update.
2884         * tui/tui-io.c (update_cmdwin_start_line)
2885         (tui_redisplay_readline): Update.
2886         * tui/tui-data.h (struct tui_command_info): Remove.
2887         (struct tui_win_info) <detail>: Remove command_info member.
2888         (struct tui_data_window) <start_line>: New member, from
2889         tui_command_info.
2890         (TUI_CMD_WIN): Add casts.
2891
2892 2019-06-25  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-winsource.c (tui_update_source_window)
2895         (tui_refill_source_window)
2896         (tui_source_window_base::do_scroll_horizontal)
2897         (tui_update_breakpoint_info, tui_set_exec_info_content)
2898         (tui_show_exec_info_content, tui_erase_exec_info_content)
2899         (tui_clear_exec_info_content): Update.
2900         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2901         Update.
2902         * tui/tui-win.c (make_invisible_and_set_new_height)
2903         (make_visible_with_new_height): Update.
2904         * tui/tui-source.c (tui_set_source_content)
2905         (tui_show_symtab_source): Update.
2906         * tui/tui-layout.c (extract_display_start_addr)
2907         (show_source_disasm_command, show_data)
2908         (make_source_or_disasm_window)
2909         (show_source_or_disasm_and_command): Update.
2910         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2911         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2912         "gdbarch".
2913         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2914         to tui_source_window_base.
2915         (struct tui_win_info) <detail>: Remove source_info member.
2916         (struct tui_source_window_base) <has_locator>: Inline.
2917         Move contents from tui_source_info; rename has_locator member to
2918         m_has_locator.
2919         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2920         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2921         header file.
2922         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2923         Simplify.
2924         (tui_free_all_source_wins_content): Cast to
2925         tui_source_window_base.
2926
2927 2019-06-25  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-win.c (make_invisible_and_set_new_height)
2930         (make_visible_with_new_height): Call has_locator method.
2931         * tui/tui-layout.c (show_source_disasm_command, show_data)
2932         (show_source_or_disasm_and_command): Update for bool change.
2933         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2934         (tui_win_info) <has_locator>: New method.
2935         (struct tui_source_window_base) <has_locator>: New method.
2936         (tui_win_has_locator): Don't declare.
2937         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2938         from tui_win_has_locator.
2939         (tui_source_window_base): Use false, not FALSE.
2940
2941 2019-06-25  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2944         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2945         clear_detail method directly.
2946         (tui_clear_win_detail): Remove.
2947
2948 2019-06-25  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2951         "this", not TUI_DISASM_WIN.
2952
2953 2019-06-25  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2956         declare.
2957         * tui/tui-winsource.c
2958         (tui_source_window_base::do_scroll_horizontal): Rename from
2959         tui_horizontal_source_scroll.
2960         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2961         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2962         from tui_vertical_data_scroll.
2963         * tui/tui-win.h (tui_scroll): Don't declare.
2964         * tui/tui-win.c (tui_win_info::forward_scroll)
2965         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2966         (tui_win_info::right_scroll): Rename and update.
2967         (tui_scroll_forward_command, tui_scroll_backward_command)
2968         (tui_scroll_left_command, tui_scroll_right_command): Update.
2969         (tui_scroll): Remove.
2970         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2971         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2972         from tui_vertical_source_scroll.
2973         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2974         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2975         from tui_vertical_disassem_scroll.
2976         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2977         do_scroll_horizontal>: New methods.
2978         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2979         Likewise.
2980         (struct tui_source_window_base): Add do_scroll_horizontal.
2981         (struct tui_source_window, struct tui_disasm_window): Add
2982         do_scroll_vertical.
2983         (struct tui_data_window, struct tui_cmd_window): Add
2984         do_scroll_horizontal and do_scroll_vertical.
2985         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-data.h (struct tui_source_window_base): New struct.
2990         (struct tui_source_window): Derive from tui_source_window_base.
2991         (struct tui_disasm_window): New struct.
2992         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2993         from tui_source_window::clear_detail.
2994         (tui_source_window_base): Rename from tui_source_window.
2995         (~tui_source_window_base): Rename from ~tui_source_window.
2996         (tui_alloc_win_info): Create a tui_disasm_window.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-data.h (struct tui_source_window)
3001         (struct tui_data_window): Declare destructors.
3002         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3003         destructors.
3004         (tui_win_info): Simplify.
3005
3006 2019-06-25  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-winsource.c (tui_display_main)
3009         (tui_update_source_windows_with_addr)
3010         (tui_update_all_breakpoint_info): Update.
3011         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3012         (new_height_ok, parse_scrolling_args): Update.
3013         * tui/tui-stack.c (tui_show_frame_info): Update.
3014         * tui/tui-data.h (struct tui_list): Remove.
3015         (tui_source_windows): Return a reference to a std::vector.
3016         * tui/tui-data.c (source_windows): Now a std::vector.
3017         (tui_source_windows): Change return type.
3018         (tui_clear_source_windows): Rewrite.
3019         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3020         (tui_free_all_source_wins_content): Rewrite.
3021
3022 2019-06-25  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3025         (struct tui_data_window, struct tui_cmd_window): Declare
3026         clear_detail method.
3027         * tui/tui-data.c (tui_source_window::clear_detail)
3028         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3029         methods.
3030         (tui_clear_win_detail): Simplify.
3031
3032 2019-06-25  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-layout.c (make_source_window, make_disasm_window)
3035         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3036         Return the new window.
3037         (show_source_disasm_command, show_data)
3038         (show_source_or_disasm_and_command): Update.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3043         parameter.  Return the new window.
3044         (show_source_disasm_command): Update and remove NULL check.
3045         (show_source_or_disasm_and_command): Update.
3046
3047 2019-06-25  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-data.h (struct tui_win_info): Make constructor
3054         protected.  Make destructor virtual.  Add initializers.
3055         (tui_source_window, tui_data_window, tui_cmd_window): New
3056         classes.
3057         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3058         constructor.  Add "type" parameter.
3059         (tui_source_window, tui_data_window, tui_cmd_window): New
3060         constructors.
3061         (tui_alloc_win_info): Instantiate the appropriate subclass.
3062
3063 2019-06-25  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-win.c (tui_resize_all): Use delete.
3066         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3067         destructor.
3068         (tui_free_window): Don't declare.
3069         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3070         Update.
3071
3072 2019-06-25  Tom Tromey  <tom@tromey.com>
3073
3074         * tui/tui-data.h (struct tui_win_info): Add constructor.
3075         * tui/tui-data.c (tui_alloc_win_info): Use new.
3076         (tui_free_window): Use delete.
3077
3078 2019-06-22  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3081         declare.
3082         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3083
3084 2019-06-22  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3087         declare.
3088         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3089
3090 2019-06-22  Tom de Vries  <tdevries@suse.de>
3091
3092         * dwarf2read.c (create_addrmap_from_aranges)
3093         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3094         instead of '%zu'.
3095
3096 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3097
3098         * dwarf2read.h (dwarf2_section_info_def): Remove.
3099         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3100         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3101         std::vector<dwarf2_section_info>.
3102         (struct dwo_file) <~dwo_file>: Remove.
3103         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3104         types field.
3105         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3106         (dwarf2_read_debug_names): Likewise.
3107         (create_debug_types_hash_table): Change parameter type to
3108         array_view, adjust code accordingly.
3109         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3110         (partial_die_info::fixup): Likewise.
3111         (determine_prefix): Likewise.
3112         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3113
3114 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3115
3116         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3117         gdb_bfd_ref_ptr.
3118         <~dwo_file>: Remove call to gdb_bfd_unref.
3119         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3120         gdb_bfd_ref_ptr::get.
3121
3122 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3123
3124         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3125         type to htab_up.
3126         * dwarf2read.c (struct dwo_file): Initialize fields.
3127         <~dwo_file>: New.
3128         (free_dwo_file): Remove, move content to ~dwo_file.
3129         (struct dwo_file_deleter): Remove.
3130         (dwo_file_up>: Remove custom deleter.
3131         (free_dwo_files): Remove.
3132         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3133         dwo_files.
3134         (process_skeletonless_type_units): Call unique_ptr::get.
3135         (allocate_dwo_file_hash_table): Add deleter to created hash
3136         table.  Change return type to htab_up.
3137         (lookup_dwo_file_slot): Don't memset dwo_file, call
3138         unique_ptr::get.
3139         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3140         (create_dwo_unit_in_dwp_v2): Likewise.
3141         (open_and_init_dwo_file): Likewise.
3142         (free_dwo_file_from_slot): Remove.
3143
3144 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3145
3146         * dwarf2read.h (struct dwarf2_section_info) <readin,
3147         is_virtual>: Change type to bool.
3148         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3149         true instead of 1.
3150
3151 2019-06-19  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-data.h (tui_init_content_element): Don't declare.
3154
3155 2019-06-19  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-data.h (tui_init_win_info): Don't declare.
3158
3159 2019-06-19  Tom de Vries  <tdevries@suse.de>
3160
3161         * dwarf2read.h (abstract_to_concrete): Change type to
3162         std::unordered_map<sect_offset, std::vector<sect_offset>,
3163         gdb::hash_enum<sect_offset>>.
3164
3165 2019-06-19  Tom Tromey  <tromey@adacore.com>
3166
3167         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3168         EVAL_AVOID_SIDE_EFFECTS specially.
3169
3170 2019-06-19  Tom Tromey  <tromey@adacore.com>
3171
3172         * source-cache.c (highlighter): New global.
3173         (source_cache::get_source_lines): Create a highlighter on demand.
3174
3175 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * defs.h (deprecated_interactive_hook): Delete declaration.
3178         * interps.c (clear_interpreter_hooks): Remove use of
3179         deprecated_interactive_hook.
3180         * top.c (deprecated_interactive_hook): Delete definition.
3181         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3182
3183 2019-06-18  Tom de Vries  <tdevries@suse.de>
3184
3185         PR gdb/24515
3186         * dwarf2read.h (abstract_to_concrete): Change type from
3187         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3188         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3189         * dwarf2read.c (read_variable): Update.
3190         (dwarf2_fetch_die_loc_sect_off): Update.
3191
3192 2019-06-17  Tom de Vries  <tdevries@suse.de>
3193
3194         PR gdb/24617
3195         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3196         accessing parent[parent_len - 1].
3197
3198 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3199
3200         PR gdb/24364
3201         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3202         call dtrace_process_dof with NULL dof.
3203
3204 2019-06-16  Tom de Vries  <tdevries@suse.de>
3205
3206         PR gdb/24445
3207         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3208
3209 2019-06-16  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3212         (make_all_visible): Use address of member.
3213
3214 2019-06-16  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3217         (tui_free_window, free_content, free_content_elements): Remove
3218         unnecessary cast.
3219         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3220         cast.
3221         * tui/tui-regs.c (tui_show_register_group)
3222         (tui_display_registers_from, tui_display_reg_element_at_line):
3223         Remove unnecessary cast.
3224
3225 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * linux-nat.c (normal_mask): Delete.
3228         (_initialize_linux_nat): Don't initialise normal_mask.
3229
3230 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3231
3232         PR gdb/24445
3233         * dwarf-index-write.h (write_psymtabs_to_index): Add
3234         dwz_basename parameter.
3235         * dwarf-index-write.c (write_gdbindex): Move file writing to
3236         write_gdbindex_1.  Change return type void.
3237         (assert_file_size): Move up, remove filename parameter.
3238         (write_gdbindex_1): New function.
3239         (write_debug_names): Change return type to void, call
3240         assert_file_size.
3241         (struct index_wip_file): New struct.
3242         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3243         file logic to index_wip_file.  Write index for dwz file if
3244         needed.
3245         (save_gdb_index_command): Pass basename of dwz file, if present.
3246         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3247         build-id of dwz file, if present.
3248         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3249         (dwarf2_get_dwz_file): Likewise.
3250         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3251         (dwarf2_get_dwz_file): Likewise.
3252
3253 2019-06-16  Tom Tromey  <tom@tromey.com>
3254
3255         * coffread.c (process_coff_symbol): Use xstrdup.
3256         * value.c (create_internalvar): Use xstrdup.
3257
3258 2019-06-16  Tom Tromey  <tom@tromey.com>
3259
3260         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3261         * breakpoint.c (stopin_command, stopat_command)
3262         (until_break_command, decode_location_default): Remove unnecessary
3263         cast.
3264         * utils.c (subset_compare): Remove unnecessary cast.
3265         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3266         cast.
3267         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3268         cast.
3269         * infcmd.c (path_command): Remove unnecessary cast.
3270         * coffread.c (decode_type): Remove unnecessary cast.
3271         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3272         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3273         * tui/tui-stack.c (tui_show_locator_content)
3274         (tui_show_frame_info): Remove unnecessary cast.
3275         * tui/tui-win.c (tui_scroll_forward_command)
3276         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3277         (parse_scrolling_args): Remove unnecessary cast.
3278         * tui/tui-data.c (init_win_info, tui_del_window)
3279         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3280         (free_content_elements): Remove unnecessary cast.
3281         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3282         unnecessary cast.
3283         * tui/tui-source.c (tui_set_source_content)
3284         (tui_vertical_source_scroll): Remove unnecessary cast.
3285         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3286         cast.
3287         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3288         * tui/tui-regs.c (tui_display_registers_from)
3289         (tui_display_register): Remove unnecessary cast.
3290         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3291         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3292         (make_visible): Remove unnecessary cast.
3293         * tui/tui-winsource.c (tui_erase_source_content)
3294         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3295         unnecessary cast.
3296         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3297         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3298         * stabsread.c (read_type, read_array_type, read_range_type):
3299         Remove unnecessary cast.
3300         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3301         (parse_symbol, parse_type, upgrade_type, parse_external)
3302         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3303         unnecessary cast.
3304         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3305
3306 2019-06-16  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-data.c (tui_alloc_generic_win_info)
3309         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3310         checks.
3311
3312 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3313             Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * f-typeprint.c (f_print_type): Don't return early for not
3316         associated or not allocated types.
3317         (f_type_print_varspec_suffix): Add print_rank parameter and print
3318         ranks of array types in case they dangling.
3319         (f_type_print_base): Add print_rank parameter.
3320
3321 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3322
3323         * NEWS: Mention new MI commands.
3324         * break-catch-throw.c (enum exception_event_kind): Move to
3325         breakpoint.h.
3326         (print_mention_exception_catchpoint): Output text as a single
3327         message.
3328         (catch_exception_command_1): Rename to...
3329         (catch_exception_event): ...this, make non-static, update header
3330         command, and change some parameter types.
3331         (catch_catch_command): Update for changes to
3332         catch_exception_command_1.
3333         (catch_throw_command): Likewise.
3334         (catch_rethrow_command): Likewise.
3335         * breakpoint.c (enum exception_event_kind): Delete.
3336         * breakpoint.h (enum exception_event_kind): Moved here from
3337         break-catch-throw.c.
3338         (catch_exception_event): Declare.
3339         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3340         (mi_cmd_catch_throw): New function.
3341         (mi_cmd_catch_rethrow): New function.
3342         (mi_cmd_catch_catch): New function.
3343         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3344         'catch-catch' entries.
3345         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3346         (mi_cmd_catch_rethrow): Declare.
3347         (mi_cmd_catch_catch): Declare.
3348
3349 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3350
3351         * annotate.c (annotate_source_line): Change return type to void,
3352         update implementation to match.
3353         * annotate.h (annotate_source_line): Change return type to void,
3354         update header comment.
3355         * stack.c (print_frame_info): Don't change what frame information
3356         is printed based on whether annotations are on or not.
3357
3358 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3359
3360         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3361         (annotate_source): Make static.
3362         (annotate_source_line): Moved from source.c and renamed from
3363         identify_source_line.  Update the return type.
3364         * annotate.h (annotate_source): Delete declaration.
3365         (annotate_source_line): Declaration moved from source.h, and
3366         renamed from identify_source_line.  Return type updated.
3367         * source.c (identify_source_line): Moved to annotate.c and renamed
3368         to annotate_source_line.
3369         (info_line_command): Remove check of annotation_level.
3370         * source.h (identify_source_line): Move declaration to annotate.h
3371         and rename to annotate_source_line.
3372         * stack.c: Add 'annotate.h' include.
3373         (print_frame_info): Remove check of annotation_level before
3374         calling annotate_source_line.
3375
3376 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * source-cache.c (source_cache::get_plain_source_lines): Use
3379         open_source_file_with_line_charpos instead of just
3380         open_source_file, remove call to find_source_lines.
3381         (source_cache::get_source_lines): Likewise.
3382         * source.c (find_source_lines): Make static.
3383         (get_filename_and_charpos): Renamed into...
3384         (open_source_file_with_line_charpos): ..this along with changes to
3385         return a scoped_fd, and some other minor clean ups.
3386         (identify_source_line): Use open_source_file_with_line_charpos.
3387         (search_command_helper): Use open_source_file_with_line_charpos
3388         instead of just open_source_file, remove call to
3389         find_source_lines.
3390         * source.h (open_source_file_with_line_charpos): Declare new
3391         function.
3392         (find_source_lines): Delete declaration.
3393
3394 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * source.c (get_filename_and_charpos): Remove fullname
3397         parameter.
3398         (identify_source_line): Update call to get_filename_and_charpos.
3399
3400 2019-06-14  Tom Tromey  <tromey@adacore.com>
3401
3402         PR gdb/24502:
3403         * ui-style.h (skip_ansi_escape): Update comment.
3404         * ui-file.h (class no_terminal_escape_file): New class.
3405         * ui-file.c (no_terminal_escape_file::write)
3406         (no_terminal_escape_file::puts): New methods.
3407         * cli/cli-logging.c (handle_redirections): Use
3408         no_terminal_escape_file.
3409
3410 2019-06-14  Tom Tromey  <tromey@adacore.com>
3411
3412         * NEWS: Move convenience variable news above Python news.
3413
3414 2019-06-14  Tom Tromey  <tom@tromey.com>
3415
3416         * gnulib: Move directory to top-level.
3417         * configure.ac: Don't configure gnulib.
3418         * configure: Rebuild.
3419         * common/common-defs.h: Use new path to gnulib.
3420         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3421         (GNULIB_H): Remove.
3422         (INCGNU): Look in new gnulib location.
3423         (HFILES_NO_SRCDIR): Remove gnulib files.
3424         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3425         (generated_files): Remove GNULIB_H.
3426         ($(LIBGNU), all-lib): Remove targets.
3427         (distclean): Don't mention GNULIB_BUILDDIR.
3428         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3429
3430 2019-06-14  Tom Tromey  <tromey@adacore.com>
3431
3432         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3433         Warn if symbol file does not provide any symbols.
3434
3435 2019-06-14  Tom Tromey  <tromey@adacore.com>
3436
3437         * source.c (find_and_open_source): Respect basenames_may_differ.
3438
3439 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * annotate.c (annotate_breakpoints_invalid): Make use of
3442         scoped_restore_terminal_state.
3443         (annotate_frames_invalid): Likewise.
3444
3445 2019-06-14  Tom Tromey  <tromey@adacore.com>
3446
3447         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3448         allow assignment to an internalvar.
3449
3450 2019-06-14  Tom Tromey  <tromey@adacore.com>
3451
3452         * ada-lex.l: Allow "_" in attribute names.
3453
3454 2019-06-14  Tom Tromey  <tromey@adacore.com>
3455
3456         PR gdb/24653:
3457         * regcache.c (registers_changed): Don't call alloca.
3458         * top.c (execute_command): Don't call alloca.
3459
3460 2019-06-13  Pedro Alves  <palves@redhat.com>
3461
3462         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3463         'expression'.  When parsing an expression, error out if there's
3464         junk after "unlimited".
3465         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3466         (do_set_command): Adjust calls to is_unlimited_literal.
3467
3468 2019-06-13  Pedro Alves  <palves@redhat.com>
3469
3470         * compile/compile.c (make_compile_options_def_group): Add braces
3471         around array_view initializer.
3472         * thread.c (make_thread_apply_all_options_def_group)
3473         (make_thread_apply_all_options_def_group): Likewise.
3474
3475 2019-06-13  Pedro Alves  <palves@redhat.com>
3476
3477         * NEWS (New commands): Mention "maint test-options
3478         require-delimiter", "maint test-options unknown-is-error", "maint
3479         test-options unknown-is-operand" and "maint show
3480         test-options-completion-result".
3481         (New command options, command completion): New section.
3482         (Completion improvements): New section.
3483         Mention that you can abbreviate "unlimited".
3484
3485 2019-06-13  Pedro Alves  <palves@redhat.com>
3486
3487         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3488         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3489         * unittests/cli-utils-selftests.c (test_parse_flags)
3490         (test_parse_flags_qcs): Delete.
3491         (test_cli_utils): Don't call deleted functions.
3492
3493 2019-06-13  Pedro Alves  <palves@redhat.com>
3494
3495         * thread.c: Include "cli/cli-option.h".
3496         (tp_array_compar_ascending): Global.
3497         (tp_array_compar): Delete function.
3498         (tp_array_compar_ascending, tp_array_compar_descending): New
3499         functions.
3500         (ascending_option_def, qcs_flag_option_def)
3501         (thr_qcs_flags_option_defs)
3502         (make_thread_apply_all_options_def_group)
3503         (make_thread_apply_options_def_group): New.
3504         (thread_apply_all_command): Use gdb::option::process_options.
3505         (thread_apply_command_completer)
3506         (thread_apply_all_command_completer): New.
3507         (thread_apply_command): Use gdb::option::process_options.
3508         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3509         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3510         to generate help text of "thread apply".  Adjust "taas"'s help.
3511         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3512         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3513
3514 2019-06-13  Pedro Alves  <palves@redhat.com>
3515
3516         * thread.c (thread_apply_command): Check for invalid TID with
3517         isdigit instead of !isalpha.
3518
3519 2019-06-13  Pedro Alves  <palves@redhat.com>
3520
3521         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3522         (validate_flags_qcs): New.
3523         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3524         (validate_flags_qcs): Declare.
3525         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3526         (make_frame_apply_options_def_group): New.
3527         (frame_apply_command_count): Process options with
3528         gdb::option::process_options.
3529         (frame_apply_completer): New.
3530         (frame_apply_level_completer, frame_apply_all_completer)
3531         (frame_apply_completer): New.
3532         (_initialize_stack): Update help of "frame apply", "frame apply
3533         level", "frame apply all" and "faas" to mention supported options
3534         and install command completers.
3535         * stack.h (frame_apply_all_completer): Declare.
3536         * thread.c: Include "stack.h".
3537         (tfaas_command): Add "--".
3538         (_initialize_thread): Update help "tfaas" to mention supported
3539         options and install command completer.
3540
3541 2019-06-13  Pedro Alves  <palves@redhat.com>
3542
3543         * completer.c (complete_nested_command_line): New.
3544         (gdb_completion_word_break_characters_throw): Add assertion.
3545         * completer.h (complete_nested_command_line): Declare.
3546
3547 2019-06-13  Pedro Alves  <palves@redhat.com>
3548
3549         * stack.c (parse_backtrace_qualifiers): New.
3550         (backtrace_command): Use it.
3551         (backtrace_command_completer): Complete on qualifiers.
3552
3553 2019-06-13  Pedro Alves  <palves@redhat.com>
3554
3555         * frame.c: Include "cli/cli-option.h.
3556         (user_set_backtrace_options): New.
3557         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3558         Delete.
3559         (get_prev_frame): Adjust.
3560         (boolean_option_def, uinteger_option_def)
3561         (set_backtrace_option_defs): New.
3562         (_initialize_frame): Adjust and use
3563         gdb::option::add_setshow_cmds_for_options to install "set
3564         backtrace past-main" and "set backtrace past-entry".
3565         * frame.h: Include "cli/cli-option.h".
3566         (struct frame_print_options): Forward declare.
3567         (print_frame_arguments_all, print_frame_arguments_scalars)
3568         (print_frame_arguments_none): Declare.
3569         (print_entry_values): Delete declaration.
3570         (struct frame_print_options, user_frame_print_options): New.
3571         (struct set_backtrace_options): New.
3572         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3573         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3574         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3575         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3576         (list_args_or_locals): Add frame_print_options parameter.
3577         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3578         * python/py-framefilter.c (enumerate_args): Pass down
3579         USER_FRAME_PRINT_OPTIONS.
3580         * stack.c: Include "cli/cli-option.h".
3581         (print_frame_arguments_all, print_frame_arguments_scalars)
3582         (print_frame_arguments_none): Declare.
3583         (print_raw_frame_arguments, print_entry_values): Delete.
3584         (user_frame_print_options): New.
3585         (boolean_option_def, enum_option_def, frame_print_option_defs):
3586         New.
3587         (struct backtrace_cmd_options): New.
3588         (bt_flag_option_def): New.
3589         (backtrace_command_option_defs): New.
3590         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3591         (print_frame_arg, read_frame_arg, print_frame_args)
3592         (print_frame_info, print_frame): Add frame_print_options parameter
3593         and use it.
3594         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3595         (backtrace_command_1): Add frame_print_options and
3596         backtrace_cmd_options parameters and use them.
3597         (make_backtrace_options_def_group): New.
3598         (backtrace_command): Process command options with
3599         gdb::option::process_options.
3600         (backtrace_command_completer): New.
3601         (_initialize_stack): Extend "backtrace"'s help to mention
3602         supported options.  Install completer for "backtrace".
3603         Install some settings commands with add_setshow_cmds_for_options.
3604
3605 2019-06-13  Pedro Alves  <palves@redhat.com>
3606
3607         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3608         and that "set/show print raw frame-arguments" are now deprecated.
3609
3610         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3611         command.
3612         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3613         * stack.c (_initialize_stack): Install "set/show print
3614         raw-frame-arguments", and deprecate "set/show print raw
3615         frame-arguments".
3616         * valprint.c (_initialize_valprint): Deprecate "set/show print
3617         raw".
3618
3619 2019-06-13  Pedro Alves  <palves@redhat.com>
3620
3621         * compile/compile.c (struct compile_options): New.
3622         (compile_flag_option_def, compile_command_option_defs)
3623         (make_compile_options_def_group): New.
3624         (compile_file_command): Handle options with
3625         gdb::option::process_options.
3626         (compile_file_command_completer): New function.
3627         (compile_code_command): Handle options with
3628         gdb::option::process_options.
3629         (compile_code_command_completer): New function.
3630         (_initialize_compiler): Install completers for "compile code" and
3631         "compile file".  Mention available options in "compile code" and
3632         "compile code"'s help.
3633         * completer.c (advance_to_completion_word): New, factored out from
3634         ...
3635         (advance_to_expression_complete_word_point): ... this.
3636         (advance_to_filename_complete_word_point): New.
3637         * completer.h (advance_to_filename_complete_word_point): New
3638         declaration.
3639
3640 2019-06-13  Pedro Alves  <palves@redhat.com>
3641
3642         * compile/compile.c: Include "cli/cli-option.h".
3643         (compile_print_value): Scope data pointer is now a
3644         value_print_options pointer; adjust.
3645         (compile_print_command): Process options.  Scope data pointer is
3646         now a value_print_options pointer; adjust.
3647         (_initialize_compile): Update "compile print"'s help to include
3648         supported options.  Install a completer for "compile print".
3649         * cp-valprint.c (show_vtblprint, show_objectprint)
3650         (show_static_field_print): Delete.
3651         (_initialize_cp_valprint): Don't install "set print
3652         static-members", "set print vtbl", "set print object" here.
3653         * printcmd.c: Include "cli/cli-option.h" and
3654         "common/gdb_optional.h".
3655         (print_command_parse_format): Rework to fill in a
3656         value_print_options instead of a format_data.
3657         (print_value): Change parameter type from format_data pointer to
3658         value_print_options reference.  Adjust.
3659         (print_command_1): Process options.  Adjust to pass down a
3660         value_print_options.
3661         (print_command_completer): New.
3662         (_initialize_printcmd): Install print_command_completer as
3663         handle_brkchars completer for the "print" command.  Update
3664         "print"'s help to include supported options.
3665         * valprint.c: Include "cli/cli-option.h".
3666         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3667         here from cp-valprint.c.
3668         (boolean_option_def, uinteger_option_def)
3669         (value_print_option_defs, make_value_print_options_def_group):
3670         New.  Use gdb::option::add_setshow_cmds_for_options to install
3671         "set print elements", "set print null-stop", "set print repeats",
3672         "set print pretty", "set print union", "set print array", "set
3673         print address", "set print symbol", "set print array-indexes".
3674         * valprint.h: Include <string> and "cli/cli-option.h".
3675         (make_value_print_options_def_group): Declare.
3676         (print_value): Change parameter type from format_data pointer to
3677         value_print_options reference.
3678         (print_command_completer): Declare.
3679
3680 2019-06-13  Pedro Alves  <palves@redhat.com>
3681
3682         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3683         (COMMON_SFILES): Add maint-test-settings.c.
3684         * cli/cli-decode.c (boolean_enums): New global, factored out from
3685         ...
3686         (add_setshow_boolean_cmd): ... here.
3687         * cli/cli-decode.h (boolean_enums): Declare.
3688         * cli/cli-option.c: New file.
3689         * cli/cli-option.h: New file.
3690         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3691         factored out from ...
3692         (parse_cli_boolean_value(const char *)): ... this.
3693         (is_unlimited_literal): Change parameter type to pointer to
3694         pointer.  Adjust and advance ARG pointer.
3695         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3696         (parse_cli_var_enum): New, factored out from ...
3697         (do_set_command): ... this.  Adjust.
3698         * cli/cli-setshow.h (parse_cli_boolean_value)
3699         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3700         (parse_cli_var_enum): Declare.
3701         * cli/cli-utils.c: Include "cli/cli-option.h".
3702         (get_ulongest): New.
3703         * cli/cli-utils.h (get_ulongest): Declare.
3704         (check_for_argument): New overloads.
3705         * maint-test-options.c: New file.
3706
3707 2019-06-13  Pedro Alves  <palves@redhat.com>
3708
3709         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3710         parse a range if "-" is at the end of the string.
3711
3712 2019-06-13  Pedro Alves  <palves@redhat.com>
3713
3714         * cli/cli-setshow.c (parse_auto_binary_operation)
3715         (parse_cli_boolean_value): Don't allow "o".
3716
3717 2019-06-13  Pedro Alves  <palves@redhat.com>
3718
3719         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3720         * NEWS: Mention maint test-settings KIND.
3721         * maint-test-settings.c: New file.
3722
3723 2019-06-13  Pedro Alves  <palves@redhat.com>
3724
3725         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3726         completer.
3727         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3728         "set" completers.
3729
3730 2019-06-13  Pedro Alves  <palves@redhat.com>
3731
3732         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3733         after item.
3734
3735 2019-06-13  Pedro Alves  <palves@redhat.com>
3736
3737         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3738
3739 2019-06-13  Pedro Alves <palves@redhat.com>
3740
3741         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3742         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3743         call.
3744         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3745         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3746         calls.
3747         (check_for_argument): Skip spaces after argument.
3748
3749 2019-06-13  Pedro Alves  <palves@redhat.com>
3750
3751         * thread.c (thread_apply_command): Adjust TID parsing.
3752         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3753         detected before end of string.
3754         (tid_is_in_list): Error out if LIST is invalid.
3755
3756 2019-06-13  Pedro Alves  <palves@redhat.com>
3757
3758         * completer.c (complete_line_internal_1): Rewind completion word
3759         point.
3760         (completion_tracker::advance_custom_word_point_by): Change
3761         parameter type to int.
3762         * completer.h (completion_tracker::advance_custom_word_point_by):
3763         Likewise.
3764
3765 2019-06-13  Pedro Alves  <palves@redhat.com>
3766
3767         * completer.c (advance_to_completion_word): Handle delimiters.
3768
3769 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3770
3771         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3772
3773 2019-06-11  Tom Tromey  <tom@tromey.com>
3774
3775         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3776         (xmalloc_failed): Move to alloc.c.
3777         * alloc.c: New file.
3778         * Makefile.in (COMMON_SFILES): Add alloc.c.
3779
3780 2019-06-11  Tom Tromey  <tom@tromey.com>
3781
3782         * nat/linux-waitpid.c: Don't include server.h.
3783         (linux_debug): Remove.
3784         (my_waitpid): Update.
3785
3786 2019-06-11  Tom Tromey  <tromey@adacore.com>
3787
3788         * infcall.c (_initialize_infcall): Remove trailing newline from
3789         help.
3790         * user-regs.c (_initialize_user_regs): Remove trailing newline
3791         from help.
3792         * typeprint.c (_initialize_typeprint): Remove trailing newline
3793         from help.
3794         * reverse.c (_initialize_reverse): Remove trailing newlines from
3795         help.
3796         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3797         from help.
3798         * language.c (add_set_language_command): Remove trailing newline
3799         from help.
3800         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3801         help.
3802         * disasm.c (_initialize_disasm): Remove trailing newline from
3803         help.
3804         * top.c (init_main): Remove trailing newline from help.
3805         * interps.c (_initialize_interpreter): Remove trailing newline
3806         from help.
3807         * btrace.c (_initialize_btrace): Remove trailing newlines from
3808         help.
3809         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3810         from help.
3811         * python/python.c (_initialize_python): Remove trailing newline
3812         from help.
3813         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3814         help.
3815         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3816         from help.  Reformat some text.
3817         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3818         from help.
3819         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3820         newline from help.
3821
3822 2019-06-11  Tom Tromey  <tromey@adacore.com>
3823
3824         * darwin-nat.c (darwin_decode_exception_message)
3825         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3826
3827 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * valops.c (value_slice): Check for not allocated or not
3830         associated values.
3831
3832 2019-06-10  Tom de Vries  <tdevries@suse.de>
3833
3834         PR gdb/24618
3835         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3836         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3837         invalid.
3838
3839 2019-06-10  Tom de Vries  <tdevries@suse.de>
3840
3841         PR gdb/24611
3842         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3843         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3844
3845 2019-06-10  Tom de Vries  <tdevries@suse.de>
3846
3847         PR symtab/24545
3848         * symtab.c (struct demangled_name_entry): Add language field.
3849         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3850         static minimal symbol".  Set and use language field.
3851
3852 2019-06-10  Tom Tromey  <tromey@adacore.com>
3853
3854         * ada-lang.c (_initialize_ada_language): Update help text.
3855
3856 2019-06-10  Tom Tromey  <tromey@adacore.com>
3857
3858         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3859         with a newline.
3860         * guile/guile.c (handle_boot_error): Don't end warning with a
3861         newline.
3862         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3863         warning with a newline.
3864         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3865         newline.
3866         (s12z_frame_cache): Likewise.
3867         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3868         a newline.
3869         * solib-svr4.c (disable_probes_interface): Don't end warning with
3870         a newline.
3871         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3872         newline.
3873         * python/python.c (do_finish_initialization): Don't end warning
3874         with a newline.
3875
3876 2019-06-10  Tom Tromey  <tom@tromey.com>
3877
3878         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3879         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3880         gdbpy_enter.
3881
3882 2019-06-10  Tom Tromey  <tromey@adacore.com>
3883
3884         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3885         data.
3886         (elf_new_init): Don't call stabsread_new_init.
3887         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3888         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3889         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3890
3891 2019-06-10  Tom de Vries  <tdevries@suse.de>
3892
3893         PR symtab/16264
3894         PR symtab/24517
3895         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3896
3897 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3898
3899         * source.c (find_and_open_source): Also rewrite relative file
3900         names.
3901
3902 2019-04-26  Amos Bird  <amosbird@gmail.com>
3903
3904         * annotate.c (annotate_thread_exited): Add "thread-exited"
3905         annotation.
3906
3907 2019-06-06  Tom Tromey  <tromey@adacore.com>
3908
3909         * maint.h (class scoped_command_stats): Use
3910         DISABLE_COPY_AND_ASSIGN.
3911         <print_time>: New method.
3912         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3913         print_time.
3914         (scoped_command_stats::print_time): New method.
3915
3916 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3919         instructions of lengths 6 or 8 bytes.
3920
3921 2019-06-04  Pedro Alves  <palves@redhat.com>
3922
3923         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3924
3925         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3926         * breakpoint.c (condition_completer): Likewise.
3927         * cli/cli-dump.c (scan_expression): Likewise.
3928         * common/filestuff.c (mkdir_recursive): Likewise.
3929         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3930         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3931         (gdb_abspath): Likewise.
3932         * compile/compile-cplus-types.c
3933         (compile_cplus_instance::decl_name): Likewise.
3934         * completer.c (complete_explicit_location):
3935         (signal_completer, reg_or_group_completer_1): Likewise.
3936         * cp-support.c (cp_remove_params_if_any): Likewise.
3937         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3938         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3939         * infcmd.c (strip_bg_char): Likewise.
3940         * linespec.c (copy_token_string): Likewise.
3941         * mi/mi-main.c (output_cores): Likewise.
3942         * psymtab.c (psymtab_search_name):
3943         * symfile.c (test_set_ext_lang_command): Likewise.
3944         * target.c (target_fileio_read_stralloc): Likewise.
3945         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3946         * value.c (complete_internalvar): Likewise.
3947
3948 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3949
3950         Add objfile property to gdb.Type.
3951         * NEWS: Mention Python API addition.
3952         * python/py-type.c (typy_get_objfile): New method.
3953
3954 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3955
3956         * NEWS: Mention the new set|show style [title|highlight].
3957         Mention changes to "show style", "help" and "apropos".
3958
3959 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3960
3961         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3962         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3963         instead of print_help_for_command.
3964         (print_doc_of_command): New function.
3965         (help_list): Add 'apropos -v word' suggestion.
3966         (print_help_for_command): Style the command name using title style.
3967         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3968         (_initialize_cli_cmds): Describe -v in apropos_command help.
3969
3970 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3971
3972         * cli/cli-style.h (cli_style_option): Add name in constructor,
3973         add m_name class member, add constructor with intensity,
3974         add name class function.
3975         (cli_style_option::add_setshow_commands): Remove name argument.
3976         (highlight_style, title_style): New styles.
3977         * cli/cli-style.c (do_show): New function that shows a style
3978         characteristic styling the style name with itself.
3979         (set_style_name): New function.
3980         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3981         Update all callers according to the changes in cli/cli-style.h.
3982         * utils.h (fputs_highlighted): New function.
3983         * utils.c (fputs_highlighted): Likewise.
3984
3985 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3986
3987         * NEWS: Mention new pipe command and new convenience variables.
3988
3989 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3990
3991         * cli/cli-cmds.c (pipe_command): New function.
3992         (_initialize_cli_cmds): Call add_com for pipe_command.
3993         Define | as an alias for pipe.
3994         (exit_status_set_internal_vars): New function.
3995         (shell_escape): Call exit_status_set_internal_vars.
3996         cli/cli-decode.c (find_command_name_length): Recognize | as
3997         a single character command.
3998
3999 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4000
4001         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4002         top.c (execute_command_to_ui_file): New function, mostly a copy
4003         of execute_command_to_string.
4004         (execute_command_to_string): Implement by calling
4005         execute_command_to_ui_file.
4006
4007 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4008
4009         * top.h (saved_command_line): Remove declaration.
4010         * top.c (previous_saved_command_line, previous_repeat_arguments):
4011         New variables.
4012         (saved_command_line): Make static, define together with other
4013         'repeat variables'.
4014         (dont_repeat): Clear repeat_arguments.
4015         (repeat_previous, get_saved_command_line, save_command_line):
4016         New functions.
4017         (gdb_init): Initialize saved_command_line
4018         and previous_saved_command_line.
4019         * main.c (captured_main_1): Remove saved_command_line initialization.
4020         * event-top.c (handle_line_of_input): Update to use
4021         the new 'repeat' related functions instead of direct access to
4022         saved_command_line.
4023         * command.h (repeat_previous, get_saved_command_line,
4024         save_command_line): New declarations.
4025         (dont_repeat): Add comment.
4026
4027 2019-05-30  Tom Tromey  <tromey@adacore.com>
4028
4029         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4030         Fix comment.
4031         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4032
4033 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4034
4035         PR cli/24587
4036         * completer.c (complete): Initialize variable word.
4037
4038 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4039
4040         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4041         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4042         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4043         'body' is NULL to the outter 'if', protecting the '!is_define'
4044         situation as well.
4045
4046 2019-05-29  Tom Tromey  <tromey@adacore.com>
4047
4048         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4049         (dwarf_unknown): New function.
4050         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4051         (dwarf_type_encoding_name): Use dwarf_unknown.
4052
4053 2019-05-29  Tom Tromey  <tromey@adacore.com>
4054
4055         PR c++/20020:
4056         * cp-valprint.c (cp_print_value_fields): Call
4057         cp_print_static_field inside "try".
4058
4059 2019-05-29  Tom Tromey  <tromey@adacore.com>
4060
4061         * inflow.c (struct terminal_info): Add default operator=.
4062         * configure: Rebuild.
4063         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4064         -Wdeprecated-copy-dtor, -Wredundant-move.
4065
4066 2019-05-29  Tom Tromey  <tromey@adacore.com>
4067
4068         * NEWS: Add entry.
4069         * infcmd.c (print_return_value_1): Handle finish_print
4070         option.
4071         (show_print_finish): New function.
4072         (_initialize_infcmd): Add "set/show print finish" commands.
4073         * valprint.c (user_print_options): Initialize new member.
4074         * valprint.h (struct value_print_options) <finish_print>: New
4075         member.
4076
4077 2019-05-28  Tom Tromey  <tromey@adacore.com>
4078
4079         * ada-lang.c (ada_remove_Xbn_suffix)
4080         (find_old_style_renaming_symbol)
4081         (parse_old_style_renaming): Remove.
4082         (ada_find_renaming_symbol): Don't call
4083         find_old_style_renaming_symbol.
4084         (ada_is_renaming_symbol): Rename from
4085         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4086         bool.  Now static.
4087         (ada_read_var_value): Update and simplify.
4088         * ada-exp.y (write_var_or_type): Remove old code.
4089
4090 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4091
4092         * event-top.c: Remove include comment.
4093         * inflow.c (class scoped_ignore_sigttou): Move from here...
4094         * inflow.h (class scoped_ignore_sigttou): ...to here.
4095         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4096         * top.c:  Remove include comment.
4097
4098 2019-05-27  Tom Tromey  <tom@tromey.com>
4099
4100         * NEWS: Fix typo.
4101
4102 2019-05-22  Tom Tromey  <tromey@adacore.com>
4103
4104         * target.c (target_follow_exec): Constify parameter.
4105         * target-delegates.c: Rebuild.
4106         * remote.c (remote_target::follow_exec): Constify parameter.
4107         * infrun.c (follow_exec): Constify parameter.
4108         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4109         (target_follow_exec): Likewise.
4110
4111 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4114         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4115
4116 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4117
4118         * NEWS: Add debugredirect and testsuite sections.
4119
4120 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4121
4122         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4123         target descriptions using exclusively floating point register name
4124         aliases.
4125
4126 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         PR gdb/18644:
4129         * f-lang.c (build_fortran_types): Handle the case where
4130         gdbarch_floatformat_for_type returns a nullptr.
4131
4132 2019-05-21  Tom de Vries  <tdevries@suse.de>
4133
4134         PR cli/24587
4135         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4136
4137 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         PR gdb/18644:
4140         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4141         16-byte floats.
4142         * i386-tdep.c (i386_floatformat_for_type): Use
4143         floatformats_ia64_quad for the 16-byte floating point component
4144         within a fortran 32-byte complex number.
4145
4146 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4149         delete default constructor.
4150         (find_partial_die): Update to return const struct.
4151         (partial_die_parent_scope): Move variable declaration into scope
4152         of its use and change its type to auto.
4153         (guess_partial_die_structure_name): Likewise.
4154         (partial_die_info::fixup): Likewise.
4155
4156 2019-05-17  Tom Tromey  <tromey@adacore.com>
4157
4158         * source.c (find_and_open_source): Remove cast.
4159
4160 2019-05-17  Tom Tromey  <tromey@adacore.com>
4161
4162         * annotate.c (annotate_source): Make "filename" const.
4163         * annotate.h (annotate_source): Use const.
4164
4165 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4166
4167         * disasm.c (set_disassembler_options): Send errors to stderr.
4168
4169 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4170
4171         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4172         (cli_interp_base::set_logging): Check debug_redirect.
4173         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4174         * cli/cli-logging.c (debug_redirect): Add static variable.
4175         (pop_output_files): Add default param.
4176         (handle_redirections): Print debug setting.
4177         (show_logging_command): Likewise.
4178         (_initialize_cli_logging): Add debugredirect command.
4179         * interps.c (current_interp_set_logging): Add debug_redirect
4180         parameter.
4181         * interps.h (set_logging): Add debug_redirect parameter.
4182         (current_interp_set_logging): Likewise.
4183         * mi/mi-common.h: Likewise.
4184         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4185
4186 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4187             Tom Tromey  <tromey@adacore.com>
4188
4189         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4190         directly.
4191         * cli/cli-interp.h (make_logging_output): Remove declaration.
4192         * cli/cli-logging.c (make_logging_output): Remove function.
4193         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4194         directly.
4195         * ui-file.c (tee_file::tee_file): Remove bools.
4196         (tee_file::~tee_file): Remove deletes.
4197         * ui-file.h (tee_file): Remove bools.
4198
4199 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4200
4201         * mi/mi-cmds.h (mi_cmd_complete): New function.
4202         * mi/mi-main.c (mi_cmd_complete): Likewise.
4203         * mi/mi-cmds.c: Define new MI command -complete.
4204         * NEWS: Mention new -complete command.
4205
4206 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4207
4208         * completer.h (complete): New function.
4209         * completer.c (complete): Likewise.
4210         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4211         function defined in completer.h.
4212
4213 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4214
4215         * MAINTAINERS (Write After Approval): Add myself.
4216
4217 2019-05-17  Tom de Vries  <tdevries@suse.de>
4218
4219         PR gdb/24094
4220         * dwarf2read.c (struct cu_partial_die_info): New struct.
4221         (find_partial_die): Return cu_partial_die_info.
4222         (partial_die_parent_scope, guess_partial_die_structure_name)
4223         (partial_die_info::fixup): Handle new return type of find_partial_die.
4224
4225 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4226
4227         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4228         "std::string", simplifying the algorithm.
4229
4230 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4231
4232         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4233         (stap_static_probe_ops::get_probes): Likewise.
4234
4235 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4236
4237         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4238         '-')" and "else if".
4239         (stap_parse_single_operand): Join checks for
4240         "gdbarch_stap_parse_special_token_p" and
4241         "gdbarch_stap_parse_special_token" in the same "if" statement.
4242         Invert check when verifying for operation on register
4243         displacement.
4244
4245 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4246
4247         * stap-probe.c (stap_get_opcode): Update comment.
4248         (stap_get_expected_argument_type): Likewise.
4249         (handle_stap_probe): Likewise.
4250
4251 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4252
4253         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4254         return type to 'bool'.  Adjust comment.  Use 'bool' when
4255         appropriate.
4256         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4257         * stap-probe.c (stap_parse_argument_1): Likewise.
4258         (stap_is_operator): Likewise.
4259         (stap_is_generic_prefix): Likewise.
4260         (stap_is_register_prefix): Likewise.
4261         (stap_is_register_indirection_prefix): Likewise.
4262         (stap_is_integer_prefix): Likewise.
4263         (stap_generic_check_suffix): Likewise.
4264         (stap_check_integer_suffix): Likewise.
4265         (stap_check_register_suffix): Likewise.
4266         (stap_check_register_indirection_suffix): Likewise.
4267         (stap_parse_register_operand): Likewise.
4268         (stap_parse_single_operand): Likewise.
4269         (stap_parse_argument_1): Likewise.
4270         (stap_probe::get_argument_count): Likewise.
4271         (stap_is_operator): Likewise.
4272
4273 2019-05-16  Tom Tromey  <tromey@adacore.com>
4274
4275         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4276         keyword to foreach.
4277
4278 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4279
4280         * linux-thread-db.c (try_thread_db_load_1): Change return type
4281         to bool.
4282         (try_thread_db_load): Likewise.
4283         (try_thread_db_load_from_pdir_1): Likewise.
4284         (try_thread_db_load_from_pdir): Likewise.
4285         (try_thread_db_load_from_sdir): Likewise.
4286         (try_thread_db_load_from_dir): Likewise.
4287         (thread_db_load_search): Likewise.
4288         (has_libpthread): Likewise.
4289         (thread_db_load): Likewise.
4290
4291 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4292
4293         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4294         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4295         NULL, and complain/return if that's the case.
4296
4297 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4298
4299         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4300         (advance, posn, abstract_read_memory): New functions.
4301         [struct mem_read_abstraction]: New struct.
4302         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4303
4304 2019-05-14  Tom Tromey  <tromey@adacore.com>
4305
4306         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4307         value is not lval_memory.
4308
4309 2019-05-14  Tom Tromey  <tromey@adacore.com>
4310
4311         * solib.c (info_sharedlibrary_command): Style the file name.
4312
4313 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4314
4315         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4316         (aarch64_vnv_type): Likewise.
4317         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4318         * common/tdesc.c: Likewise.
4319         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4320         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4321         * features/aarch64-fpu.xml: Add ieee half view.
4322         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4323         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4324         * gdbtypes.h (struct builtin_type): Likewise.
4325         (struct objfile_type): Likewise.
4326
4327 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4328
4329         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4330         typo.
4331         * location.h (string_to_event_location): Likewise.
4332
4333 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4334
4335         GDB 8.3 released.
4336
4337 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4338
4339         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4340         New variable declaration.
4341         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4342         New variable.
4343         (print_one_breakpoint): Use ui_out::test_flags and new global
4344         variable to compute use_fixed_output.
4345         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4346         Remove.
4347         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4348         (mi_multi_location_breakpoint_output_fixed): Remove.
4349         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4350         new variable.
4351         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4352         fix_multi_location_breakpoint_output flag if version >= 3.
4353         * ui-out.h (enum ui_out_flag)
4354         <fix_multi_location_breakpoint_output>: New enumerator.
4355
4356 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4357
4358         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4359
4360 2019-05-10  Tom Tromey  <tromey@adacore.com>
4361
4362         * ada-lang.c (catch_ada_completer): New function.
4363         (_initialize_ada_language): Use it.
4364
4365 2019-05-10  Tom Tromey  <tromey@adacore.com>
4366
4367         * thread.c (print_thread_info): Make "requested_threads" const.
4368         * gdbthread.h (print_thread_info): Make "requested_threads"
4369         const.
4370         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4371         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4372
4373 2019-05-08  Tom Tromey  <tom@tromey.com>
4374
4375         * gdbtypes.c (objfile_type_data): Change type.
4376         (objfile_type, _initialize_gdbtypes): Update.
4377
4378 2019-05-08  Tom Tromey  <tom@tromey.com>
4379
4380         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4381         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4382         (_initialize_dwarf2_frame): Update.
4383
4384 2019-05-08  Tom Tromey  <tom@tromey.com>
4385
4386         * objc-lang.c (objc_objfile_data): Change type.
4387         (find_methods): Update.
4388         (_initialize_objc_lang): Remove.
4389
4390 2019-05-08  Tom Tromey  <tom@tromey.com>
4391
4392         * stabsread.c (rs6000_builtin_type_data): Change type.
4393         (rs6000_builtin_type, _initialize_stabsread): Update.
4394
4395 2019-05-08  Tom Tromey  <tom@tromey.com>
4396
4397         * mips-tdep.c (mips_pdr_data): Remove.
4398         (_initialize_mips_tdep): Update.
4399
4400 2019-05-08  Tom Tromey  <tom@tromey.com>
4401
4402         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4403         (hppa_init_objfile_priv_data, read_unwind_info)
4404         (find_unwind_entry, _initialize_hppa_tdep): Update.
4405
4406 2019-05-08  Tom Tromey  <tom@tromey.com>
4407
4408         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4409         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4410         on obstack.
4411         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4412
4413 2019-05-08  Tom Tromey  <tom@tromey.com>
4414
4415         * mdebugread.c (basic_type_data): Change type.
4416         (basic_type, _initialize_mdebugread): Update.
4417
4418 2019-05-08  Tom Tromey  <tom@tromey.com>
4419
4420         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4421
4422 2019-05-08  Tom Tromey  <tom@tromey.com>
4423
4424         * nto-tdep.c (nto_inferior_data_reg): Change type.
4425         (nto_inferior_data): Update.
4426         (nto_inferior_data_cleanup, nto_new_inferior_data)
4427         (_initialize_nto_tdep): Remove.
4428         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4429
4430 2019-05-08  Tom Tromey  <tom@tromey.com>
4431
4432         * ada-lang.c (struct ada_inferior_data): Add initializers.
4433         (ada_inferior_data): Change type.
4434         (ada_inferior_data_cleanup): Remove.
4435         (get_ada_inferior_data, ada_inferior_exit)
4436         (struct ada_pspace_data): Add initializers, destructor.
4437         (ada_pspace_data_handle): Change type.
4438         (get_ada_pspace_data): Update.
4439         (ada_pspace_data_cleanup): Remove.
4440
4441 2019-05-08  Tom Tromey  <tom@tromey.com>
4442
4443         * coffread.c (struct coff_symfile_info): Add initializers.
4444         (coff_objfile_data_key): Move lower.  Change type.
4445         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4446         Update.
4447         (coff_free_info): Remove.
4448
4449 2019-05-08  Tom Tromey  <tom@tromey.com>
4450
4451         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4452         (fbsd_pspace_data_handle): Move lower.  Change type.
4453         (get_fbsd_pspace_data): Update.
4454         (fbsd_pspace_data_cleanup): Remove.
4455         (_initialize_fbsd_tdep): Update.
4456
4457 2019-05-08  Tom Tromey  <tom@tromey.com>
4458
4459         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4460         (get_ada_tasks_pspace_data): Update.
4461         (ada_tasks_pspace_data_cleanup): Remove.
4462         (_initialize_tasks): Update.
4463         (ada_tasks_inferior_data_handle): Change type.
4464         (get_ada_tasks_inferior_data): Update.
4465         (ada_tasks_inferior_data_cleanup): Remove.
4466         (struct ada_tasks_pspace_data): Add initializers.
4467
4468 2019-05-08  Tom Tromey  <tom@tromey.com>
4469
4470         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4471         * symfile-debug.c (debug_sym_get_probes): Change type.
4472         * stap-probe.c (handle_stap_probe):
4473         (stap_static_probe_ops::get_probes): Change type.
4474         * probe.h (class static_probe_ops) <get_probes>: Change type.
4475         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4476         (parse_probes_in_pspace): Update.
4477         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4478         Update.
4479         (any_static_probe_ops::get_probes): Change type.
4480         * elfread.c (elfread_data): New typedef.
4481         (probe_key): Change type.
4482         (elf_get_probes): Likewise.  Update.
4483         (probe_key_free): Remove.
4484         (_initialize_elfread): Update.
4485         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4486         Change type.
4487         (dtrace_process_dof_probe, dtrace_process_dof)
4488         (dtrace_static_probe_ops::get_probe): Change type.
4489
4490 2019-05-08  Tom Tromey  <tom@tromey.com>
4491
4492         * xcoffread.c (struct xcoff_symfile_info): Rename from
4493         coff_symfile_info.  Add initializers.
4494         (xcoff_objfile_data_key): Move lower.  Change type.
4495         (XCOFF_DATA): Rewrite.
4496         (xcoff_free_info): Remove.
4497         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4498         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4499         (xcoff_initial_scan): Update.
4500
4501 2019-05-08  Tom Tromey  <tom@tromey.com>
4502
4503         * solib-svr4.c (struct svr4_info): Add initializers and
4504         destructor.
4505         <probes_table>: Now an htab_up.
4506         (solib_svr4_pspace_data): Change type.
4507         (free_probes_table): Simplify.
4508         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4509         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4510         (probes_table_remove_objfile_probes, register_solib_event_probe)
4511         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4512         (_initialize_svr4_solib): Update.
4513
4514 2019-05-08  Tom Tromey  <tom@tromey.com>
4515
4516         * remote.c (remote_pspace_data): Change type.
4517         (remote_pspace_data_cleanup): Remove.
4518         (get_remote_exec_file, set_pspace_remote_exec_file)
4519         (_initialize_remote): Update.
4520
4521 2019-05-08  Tom Tromey  <tom@tromey.com>
4522
4523         * breakpoint.c (breakpoint_objfile_key): Change type.
4524         (get_breakpoint_objfile_data): Update.
4525         (free_breakpoint_objfile_data): Remove.
4526         (_initialize_breakpoint): Update.
4527
4528 2019-05-08  Tom Tromey  <tom@tromey.com>
4529
4530         * linux-tdep.c (struct linux_info): Add initializers.
4531         (linux_inferior_data): Move.  Change type.
4532         (invalidate_linux_cache_inf): Update.
4533         (linux_inferior_data_cleanup): Remove.
4534         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4535
4536 2019-05-08  Tom Tromey  <tom@tromey.com>
4537
4538         * auxv.c (auxv_inferior_data): Move.  Change type.
4539         (auxv_inferior_data_cleanup): Remove.
4540         (invalidate_auxv_cache_inf): Rewrite.
4541         (get_auxv_inferior_data, _initialize_auxv): Update.
4542
4543 2019-05-08  Tom Tromey  <tom@tromey.com>
4544
4545         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4546         (symfile_debug_objfile_data_key): Change type.
4547         (symfile_debug_installed, debug_qf_has_symbols)
4548         (debug_qf_find_last_source_symtab)
4549         (debug_qf_forget_cached_source_info)
4550         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4551         (debug_qf_print_stats, debug_qf_dump)
4552         (debug_qf_expand_symtabs_for_function)
4553         (debug_qf_expand_all_symtabs)
4554         (debug_qf_expand_symtabs_with_fullname)
4555         (debug_qf_map_matching_symbols)
4556         (debug_qf_expand_symtabs_matching)
4557         (debug_qf_find_pc_sect_compunit_symtab)
4558         (debug_qf_map_symbol_filenames)
4559         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4560         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4561         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4562         (debug_sym_read_linetable, debug_sym_relocate): Update.
4563         (symfile_debug_free_objfile): Remove.
4564         (install_symfile_debug_logging, _initialize_symfile_debug):
4565         Update.
4566
4567 2019-05-08  Tom Tromey  <tom@tromey.com>
4568
4569         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4570         allocate_on_obstack.
4571         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4572         (get_dwarf2_per_objfile): Update.
4573         (set_dwarf2_per_objfile): Remove.
4574         (dwarf2_has_info, dwarf2_get_section_info): Update.
4575         (dwarf2_free_objfile): Remove.
4576         (_initialize_dwarf2_read): Update.
4577
4578 2019-05-08  Tom Tromey  <tom@tromey.com>
4579
4580         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4581         initializers.
4582         <unsupported_script_warning_printed,
4583         script_not_found_warning_printed>: Now bool.
4584         (auto_load_pspace_data): Change type.
4585         (~auto_load_pspace_info): Rename from
4586         auto_load_pspace_data_cleanup.
4587         (get_auto_load_pspace_data, init_loaded_scripts_info)
4588         (clear_section_scripts, maybe_print_unsupported_script_warning)
4589         (maybe_print_script_not_found_warning, _initialize_auto_load):
4590         Update.
4591
4592 2019-05-08  Tom Tromey  <tom@tromey.com>
4593
4594         * objfiles.c (objfile_pspace_info): Add destructor and
4595         initializers.
4596         (objfiles_pspace_data): Change type.
4597         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4598         (get_objfile_pspace_data): Update.
4599         (objfiles_bfd_data): Change type.
4600         (get_objfile_bfd_data): Update.
4601         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4602
4603 2019-05-08  Tom Tromey  <tom@tromey.com>
4604
4605         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4606         Change type.
4607         (get_catch_syscall_inferior_data): Update.
4608         (catch_syscall_inferior_data_cleanup): Remove.
4609         (_initialize_break_catch_syscall): Update.
4610
4611 2019-05-08  Tom Tromey  <tom@tromey.com>
4612
4613         * inflow.c (struct terminal_info): Add destructor and
4614         initializers.
4615         (inflow_inferior_data): Change type.
4616         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4617         (get_inflow_inferior_data, inflow_inferior_exit)
4618         (swap_terminal_info, _initialize_inflow): Update.
4619
4620 2019-05-08  Tom Tromey  <tom@tromey.com>
4621
4622         * target-dcache.c (target_dcache_cleanup): Remove.
4623         (target_dcache_aspace_key): Change type.
4624         (target_dcache_init_p, target_dcache_invalidate)
4625         (target_dcache_get, target_dcache_get_or_init)
4626         (_initialize_target_dcache): Update.
4627         * dcache.h (struct dcache_deleter): New.
4628
4629 2019-05-08  Tom Tromey  <tom@tromey.com>
4630
4631         * symtab.c (struct symbol_cache): Add destructor and
4632         initializers.
4633         (symbol_cache_key): Move.  Change type.
4634         (make_symbol_cache, free_symbol_cache): Remove.
4635         (get_symbol_cache): Update.
4636         (symbol_cache_cleanup): Remove.
4637         (ALL_PSPACES, symbol_cache_flush)
4638         (maintenance_print_symbol_cache)
4639         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4640         Update.
4641
4642 2019-05-08  Tom Tromey  <tom@tromey.com>
4643
4644         * symtab.c (struct main_info): Add destructor and initializers.
4645         (main_progspace_key): Move.  Change type.
4646         (get_main_info): Update.
4647         (main_info_cleanup): Remove.
4648         (_initialize_symtab): Update.
4649
4650 2019-05-08  Tom Tromey  <tom@tromey.com>
4651
4652         * registry.h (DECLARE_REGISTRY): Define the _key class.
4653
4654 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * NEWS: Merge two 'New commands' sections.
4657
4658 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4659
4660         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4661         parameter and use Ada language definition instead.
4662         (ada_val_print_ptr): Remove unused language parameter.
4663         (ada_val_print_num): Remove language parameter and use Ada language
4664         definition instead.
4665         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4666         parameter.
4667         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4668         parameter and use Ada language definition instead.
4669         (ada_val_print_1): Update all ada_val_print_xxx calls.
4670         Remove language parameter.
4671         (ada_val_print): Update ada_val_print_1 call.
4672
4673 2019-05-08  Tom Tromey  <tromey@adacore.com>
4674
4675         * remote.c (remote_hw_watchpoint_limit)
4676         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4677         Now static.
4678
4679 2019-05-08  Tom Tromey  <tromey@adacore.com>
4680
4681         * maint.c (_initialize_maint_cmds): Move initialization code to
4682         remote.c.
4683         (watchdog, show_watchdog): Move to remote.c.
4684         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4685         "watchdog" static.
4686         (_initialize_remote): Move initialization code from maint.c.
4687         * defs.h (watchdog): Don't declare.
4688
4689 2019-05-08  Tom Tromey  <tromey@adacore.com>
4690
4691         * tui/tui-interp.c: Include main.h.
4692         * interps.c: Include main.h.
4693         * main.h (interpreter_p): Declare.
4694         * defs.h (interpreter_p): Don't declare.
4695
4696 2019-05-08  Tom Tromey  <tromey@adacore.com>
4697
4698         * dwarf2loc.c: Include dwarf2read.h.
4699         * defs.h (read_unsigned_leb128): Don't declare.
4700         * dwarf2read.h (read_unsigned_leb128): Declare.
4701
4702 2019-05-08  Tom Tromey  <tromey@adacore.com>
4703
4704         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4705         method.
4706
4707 2019-05-08  Tom Tromey  <tromey@adacore.com>
4708
4709         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4710         when no wrap column is set.
4711
4712 2019-05-08  Tom Tromey  <tromey@adacore.com>
4713
4714         * c-lang.c (c_get_string): Handle non-C-style arrays.
4715
4716 2019-05-08  Tom Tromey  <tromey@adacore.com>
4717
4718         * typeprint.c (print_offset_data::update): Print the bit offset,
4719         not the number of bits remaining.
4720
4721 2019-05-08  Tom Tromey  <tromey@adacore.com>
4722
4723         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4724         padding at end of comment.
4725
4726 2019-05-08  Tom Tromey  <tromey@adacore.com>
4727
4728         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4729         Compare main types.
4730
4731 2019-05-06  Tom Tromey  <tom@tromey.com>
4732
4733         * common/scoped_mmap.c: Include common-defs.h.
4734         * common/scoped_mmap.h: Don't include config.h.
4735
4736 2019-05-04  Tom Tromey  <tom@tromey.com>
4737
4738         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4739         (struct aarch64_call_info): Add initializers.
4740         <si>: Now a std::vector.
4741         (pass_on_stack, aarch64_push_dummy_call): Update.
4742
4743 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4744             Tom Tromey  <tom@tromey.com>
4745
4746         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4747         (ppc_threads): Now a std::vector.  Now static.
4748         (hwdebug_find_thread_points_by_tid)
4749         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4750         Update.
4751
4752 2019-05-04  Tom Tromey  <tom@tromey.com>
4753
4754         * arc-tdep.c (arc_tdesc_init): Return bool.
4755
4756 2019-05-04  Tom Tromey  <tom@tromey.com>
4757
4758         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4759         Use gdb_assert_not_reached.
4760
4761 2019-05-04  Tom Tromey  <tom@tromey.com>
4762
4763         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4764         "false".
4765
4766 2019-05-04  Tom Tromey  <tom@tromey.com>
4767
4768         * arc-tdep.c (arc_tdesc_init): Use bool.
4769
4770 2019-05-04  Tom Tromey  <tom@tromey.com>
4771
4772         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4773
4774 2019-05-04  Tom Tromey  <tom@tromey.com>
4775
4776         * cli/cli-cmds.c (valid_command_p): Return bool.
4777
4778 2019-05-04  Tom Tromey  <tom@tromey.com>
4779
4780         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4781         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4782
4783 2019-05-04  Raul Tambre  <raul@tambre.ee>
4784
4785         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4786         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4787         operator for comparison.
4788
4789 2019-05-04  Tom Tromey  <tom@tromey.com>
4790
4791         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4792         (lookup_partial_symbol, print_partial_symbols)
4793         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4794         (psymbol_compare): Update.
4795         (add_psymbol_to_bcache): Clear the entire psymbol.
4796         (maintenance_check_psymtabs): Update.
4797         * psympriv.h (struct partial_symbol): Don't derive from
4798         general_symbol_info.
4799         <obj_section, unrelocated_address, address,
4800         set_unrelocated_address>: Update.
4801         <ginfo>: New member.
4802         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4803         (debug_names::write_psymbols): Update.
4804
4805 2019-05-04  Tom de Vries  <tdevries@suse.de>
4806
4807         * contrib/cc-with-tweaks.sh: Support -n arg.
4808
4809 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4810
4811         * corelow.c (core_target::detach): Ensure frame cache and
4812         register caches are cleared.
4813         inferior.c (exit_inferior_1): Likewise.
4814
4815 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4816             Tom Tromey  <tom@tromey.com>
4817
4818         * dictionary.c (collate_pending_symbols_by_language): Remove
4819         "struct" from foreach.
4820         * symtab.c (lookup_global_symbol_from_objfile)
4821         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4822         foreach.
4823         * ser-tcp.c (net_open): Remove "struct" from foreach.
4824         * objfiles.c (objfile_relocate, objfile_rebase)
4825         (objfile_has_symbols): Remove "struct" from foreach.
4826         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4827         from foreach.
4828         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4829         foreach.
4830         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4831         "struct" from foreach.
4832         * ada-lang.c (create_excep_cond_exprs)
4833         (ada_exception_catchpoint_cond_string): Remove "struct" from
4834         foreach.
4835
4836 2019-05-03  Tom Tromey  <tromey@adacore.com>
4837
4838         * ada-exp.y (convert_char_literal): Check suffix of each
4839         enumerator.
4840
4841 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4842
4843         PR ada/21406:
4844         * ada-exp.y (yywrap): Don't define.
4845         * ada-lex.l (%option): Add noyywrap
4846         (yywrap): Remove.
4847
4848 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4849
4850         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4851         _WIN32_WINNT to the XP level, unless already defined to a higher
4852         level.
4853
4854         * unittests/parse-connection-spec-selftests.c:
4855         * ser-tcp.c:
4856         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4857         override.
4858
4859         * symfile.c (find_separate_debug_file): Remove colon from the
4860         drive spec of DOS/Windows file names of the target, so that the
4861         file name produced from DEBUGDIR and the target's directory will
4862         be valid on DOS/Windows systems.
4863
4864 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * rust-lang.c (val_print_struct): Handle printing structures
4867         containing strings.
4868
4869 2019-05-02  Tom Tromey  <tromey@adacore.com>
4870
4871         * valarith.c (_initialize_valarith): Remove.
4872
4873 2019-05-01  Tom Tromey  <tromey@adacore.com>
4874
4875         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4876         bitfields.
4877
4878 2019-05-01  Tom Tromey  <tromey@adacore.com>
4879
4880         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4881         for big-endian copies.
4882
4883 2019-04-30  Ali Tamur  <tamur@google.com>
4884         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4885         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4886         (read_3_bytes): New function.
4887
4888 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4889
4890         * windows-nat.c (main_thread_id): Delete.
4891         (handle_output_debug_string): Replace main_thread_id by
4892         current_event.dwThreadId.
4893         (fake_create_process): Likewise.
4894         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4895         Do not set main_thread_id.
4896         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4897         current_event.dwThreadId.
4898         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4899
4900 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4901
4902         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4903         Use current_event.dwThreadId instead of main_thread_id.
4904
4905 2019-04-30  Tom Tromey  <tromey@adacore.com>
4906
4907         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4908         (create_excep_cond_exprs): Iterate over program spaces.
4909         (ada_exception_catchpoint_cond_string): Examine all minimal
4910         symbols for exception types.
4911
4912 2019-04-30  Tom Tromey  <tromey@adacore.com>
4913
4914         PR c++/24470:
4915         * dwarf2read.c (process_structure_scope): Handle case where type
4916         has template parameters but no symbol was created.
4917
4918 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4919             Chris January  <chris.january@arm.com>
4920
4921         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4922         qualifier.
4923         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4924
4925 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         * f-typeprint.c (f_print_type): Update rules for printing
4928         whitespace.
4929         (f_type_print_varspec_suffix): Likewise.
4930
4931 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4932             Chris January  <chris.january@arm.com>
4933
4934         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4935         function arguments.
4936
4937 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * f-lang.c (build_fortran_types): Change name of void type to
4940         lower case.
4941         * f-typeprint.c (f_type_print_base): Print the name of the void
4942         type, rather than a fixed string.
4943         * f-valprint.c (f_decorations): Use lower case void string.
4944
4945 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4946             Chris January  <chris.january@arm.com>
4947
4948         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4949         types for Fortran.
4950
4951 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4952             Chris January  <chris.january@arm.com>
4953             David Lecomber  <david.lecomber@arm.com>
4954
4955         * f-exp.y (BINOP_INTRINSIC): New token.
4956         (exp): New parser rule handling BINOP_INTRINSIC.
4957         (f77_keywords): Add new builtin procedures.
4958         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4959         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4960         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4961         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4962         (print_unop_subexp_f): New function.
4963         (print_binop_subexp_f): New function.
4964         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4965         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4966         (dump_subexp_body_f): Likewise.
4967         (operator_check_f): Likewise.
4968         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4969         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4970
4971 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4974         UNOP_KIND.
4975         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4976         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4977         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4978         (operator_length_f): New fuction.
4979         (print_subexp_f): New function.
4980         (op_name_f): New function.
4981         (dump_subexp_body_f): New function.
4982         (operator_check_f): New function.
4983         (exp_descriptor_f): Replace standard expression handling functions
4984         with new functions.
4985         * gdb/fortran-operator.def: New file.
4986         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4987         * gdb/std-operator.def: Remove UNOP_KIND.
4988
4989 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4990
4991         * std-operator.def: Remove unbalanced, stray double quote
4992         character.
4993
4994 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4995             Chris January  <chris.january@arm.com>
4996             Daniel Everett  <daniel.everett@arm.com>
4997             Nick Forrington  <nick.forrington@arm.com>
4998             Richard Bunt  <richard.bunt@arm.com>
4999
5000         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5001         of depth when printing anonymous structs or unions.
5002         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5003         Don't print either the top-level value, or the children if the
5004         max-depth is exceeded.
5005         (ppscm_print_children): When printing the key of a map, allow one
5006         extra level of depth.
5007         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5008         print either the top-level value, or the children if the max-depth
5009         is exceeded.
5010         (print_children): When printing the key of a map, allow one extra
5011         level of depth.
5012         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5013         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5014         (user_print_options): Initialise max_depth field.
5015         (val_print_scalar_or_string_type_p): New function.
5016         (val_print): Check to see if the max depth has been reached.
5017         (val_print_check_max_depth): Define new function.
5018         (show_print_max_depth): New function.
5019         (_initialize_valprint): Add 'print max-depth' option.
5020         * valprint.h (struct value_print_options) <max_depth>: New field.
5021         (val_print_check_max_depth): Declare new function.
5022         * NEWS: Document new feature.
5023
5024 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * ada-lang.c (ada_language_defn): Initialise new field.
5027         * c-lang.c (c_is_string_type_p): New function.
5028         (c_language_defn): Initialise new field.
5029         (cplus_language_defn): Initialise new field.
5030         (asm_language_defn): Initialise new field.
5031         (minimal_language_defn): Initialise new field.
5032         * c-lang.h (c_is_string_type_p): Declare new function.
5033         * d-lang.c (d_language_defn): Initialise new field.
5034         * f-lang.c (f_is_string_type_p): New function.
5035         (f_language_defn): Initialise new field.
5036         * go-lang.c (go_is_string_type_p): New function.
5037         (go_language_defn): Initialise new field.
5038         * language.c (default_is_string_type_p): New function.
5039         (unknown_language_defn): Initialise new field.
5040         (auto_language_defn): Initialise new field.
5041         * language.h (struct language_defn) <la_is_string_type_p>: New
5042         member variable.
5043         (default_is_string_type_p): Declare new function.
5044         * m2-lang.c (m2_language_defn): Initialise new field.
5045         * objc-lang.c (objc_language_defn): Initialise new field.
5046         * opencl-lang.c (opencl_language_defn): Initialise new field.
5047         * p-lang.c (pascal_is_string_type_p): New function.
5048         (pascal_language_defn): Initialise new field.
5049         * rust-lang.c (rust_is_string_type_p): New function.
5050         (rust_language_defn): Initialise new field.
5051
5052 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5055         New field.
5056         * ada-lang.c (ada_language_defn): Initialise new field.
5057         * c-lang.c (c_language_defn): Likewise.
5058         (cplus_language_defn): Likewise.
5059         (asm_language_defn): Likewise.
5060         (minimal_language_defn): Likewise.
5061         * d-lang.c (d_language_defn): Likewise.
5062         * f-lang.c (f_language_defn): Likewise.
5063         * go-lang.c (go_language_defn): Likewise.
5064         * language.c (unknown_language_defn): Likewise.
5065         (auto_language_defn): Likewise.
5066         * m2-lang.c (m2_language_defn): Likewise.
5067         * objc-lang.c (objc_language_defn): Likewise.
5068         * opencl-lang.c (opencl_language_defn): Likewise.
5069         * p-lang.c (pascal_language_defn): Likewise.
5070         * rust-lang.c (rust_language_defn): Likewise.
5071
5072 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * ada-lang.c (ada_is_character_type): Change return type to bool.
5075         (ada_is_string_type): Likewise.
5076         * ada-lang.h (ada_is_character_type): Update declaration
5077         (ada_is_string_type): Likewise.
5078
5079 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5080
5081         Support style in 'frame|thread apply'
5082
5083         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5084         * record.c (record_start, record_stop): Update callers of
5085         execute_command_to_string with false.
5086         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5087         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5088         methods.
5089         (class string_file): New constructor with term_out parameter.
5090         Override methods term_out and can_emit_style_escape.  New member
5091         term_out.
5092         (class stdio_file): Override can_emit_style_escape.
5093         (class tee_file): Override term_out and can_emit_style_escape.
5094         * utils.h (can_emit_style_escape): Remove.
5095         * utils.c (can_emit_style_escape): Likewise.
5096         Update all callers of can_emit_style_escape (SOMESTREAM) to
5097         SOMESTREAM->can_emit_style_escape.
5098         * source-cache.c (source_cache::get_source_lines): Likewise.
5099         * stack.c (frame_apply_command_count): Call execute_command_to_string
5100         passing the term_out characteristic of the current gdb_stdout.
5101         * thread.c (thr_try_catch_cmd): Likewise.
5102         * top.c (execute_command_to_string): pass term_out parameter
5103         to construct the string_file for the command output.
5104         * ui-file.c (term_cli_styling): New function (most code moved
5105         from utils.c can_emit_style_escape).
5106         (string_file::string_file, string_file::can_emit_style_escape,
5107         stdio_file::can_emit_style_escape, tee_file::term_out,
5108         tee_file::can_emit_style_escape): New functions.
5109
5110 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5111
5112         * NEWS: Mention the new set|show may-call-functions.
5113         * infcall.c (may_call_functions_p): New variable.
5114         (show_may_call_functions_p): New function.
5115         (call_function_by_hand_dummy): Throws an error if not
5116         may-call-functions.
5117         (_initialize_infcall): Call add_setshow_boolean_cmd for
5118         may-call-functions.
5119
5120 2019-04-25  Keith Seitz  <keiths@redhat.com>
5121
5122         PR c++/24367
5123         * cp-support.c (inspect_type): Don't attempt substitutions
5124         of symbol with the same name.
5125
5126 2019-04-25  Tom Tromey  <tromey@adacore.com>
5127
5128         PR gdb/24475:
5129         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5130         static.
5131
5132 2019-04-25  Tom Tromey  <tromey@adacore.com>
5133
5134         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5135         rvalue reference.
5136         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5137         (gdb_xml_parser::parse): Use std::move.
5138         * python/python-internal.h (gdbpy_convert_exception): Take a const
5139         reference.
5140         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5141         std::move.
5142         * python/py-utils.c (gdbpy_convert_exception): Take a const
5143         reference.
5144         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5145         Use std::move.
5146         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5147         Use std::move.
5148         * mi/mi-main.c (mi_print_exception): Take a const reference.
5149         * main.c (handle_command_errors): Take a const reference.
5150         * linespec.c (parse_linespec): Use std::move.
5151         * infcall.c (run_inferior_call): Use std::move.
5152         (call_function_by_hand_dummy): Use std::move.
5153         * exec.c (try_open_exec_file): Use std::move.
5154         * exceptions.h (exception_print, exception_fprintf)
5155         (exception_print_same): Update.
5156         * exceptions.c (print_exception, exception_print)
5157         (exception_fprintf, exception_print_same): Change parameters to
5158         const reference.
5159         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5160         * common/new-op.c: Use std::move.
5161         * common/common-exceptions.h (struct gdb_exception): Add move
5162         constructor.
5163         (struct gdb_exception_error, struct gdb_exception_quit, struct
5164         gdb_quit_bad_alloc): Change constructor to move constructor.
5165         (throw_exception): Change parameter to rvalue reference.
5166         * common/common-exceptions.c (throw_exception): Take rvalue
5167         reference.
5168         * cli/cli-interp.c (safe_execute_command): Use std::move.
5169         * breakpoint.c (insert_bp_location, location_to_sals): Use
5170         std::move.
5171
5172 2019-04-25  Tom Tromey  <tromey@adacore.com>
5173
5174         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5175         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5176         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5177         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5178         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5179         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5180         guile/scm-value.c: Use unpack.
5181         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5182         gdbscm_gdb_exception.
5183         (gdbscm_throw_gdb_exception): Likewise.
5184         (struct gdbscm_gdb_exception): New.
5185         (unpack): New function.
5186         (gdbscm_wrap): Use unpack.
5187
5188 2019-04-25  Tom Tromey  <tromey@adacore.com>
5189
5190         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5191         (gdb_rl_callback_handler): Use std::move.
5192         * common/common-exceptions.h (struct gdb_exception): Add move
5193         assignment operator.
5194         (throw_exception_sjlj): Change "exception" to const reference.
5195         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5196         (throw_exception_sjlj): Change "exception" to const reference.
5197
5198 2019-04-25  Tom Tromey  <tromey@adacore.com>
5199
5200         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5201         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5202         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5203         Update.
5204         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5205         Update.
5206         * mi/mi-interp.c (mi_interp::exec): Update.
5207         * linespec.c (parse_linespec): Update.
5208         * infcall.c (run_inferior_call): Update.
5209         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5210         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5211         (gdbscm_lookup_global_symbol): Update.
5212         * guile/scm-param.c (gdbscm_parameter_value): Update.
5213         * guile/scm-frame.c (gdbscm_frame_read_register)
5214         (gdbscm_frame_read_var): Update.
5215         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5216         * exec.c (try_open_exec_file): Update.
5217         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5218         (gdb_rl_callback_handler): Update.
5219         * common/common-exceptions.h (exception_none): Don't declare.
5220         * common/common-exceptions.c (exception_none): Don't define.
5221         (struct catcher) <exception>: Update.
5222         * cli/cli-interp.c (safe_execute_command): Update.
5223         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5224
5225 2019-04-25  Ali Tamur  <tamur@google.com>
5226
5227         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5228         (read_attribute_value): Likewise.
5229         (dwarf2_read_addr_index): Update comment.
5230         (read_str_index): Add DW_FORM_strx.
5231         (dwarf2_string_attr): Likewise.
5232         (dwarf2_const_value_attr): Likewise.
5233         (dump_die_shallow): Likewise.
5234         (dwarf2_fetch_constant_bytes): Likewise.
5235         (skip_form_bytes): Likewise.
5236         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5237
5238 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5239
5240         PR corefiles/11608
5241         PR corefiles/18187
5242         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5243         OFFSET.  Verify if current mapping contains an ELF header.
5244         (linux_find_memory_regions_full): Adjust call to
5245         dump_mapping_p.
5246
5247 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5248             Kang Li <kanglictf@gmail.com>
5249
5250         PR gdb/21600
5251
5252         * dwarf2-frame.c (read_initial_length): Be consistent about using
5253         unsigned representation of length.
5254         (decode_frame_entry_1): Likewise.  Check for wraparound of
5255         end pointer as well as buffer overflow.
5256
5257 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5258
5259         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5260         "vq".
5261
5262 2019-04-24  Tom Tromey  <tromey@adacore.com>
5263
5264         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5265
5266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * s12z-tdep.c (s12z_unwind_pc): Delete.
5269         (s12z_unwind_sp): Delete.
5270         (s12z_gdbarch_init): Don't register deleted functions with
5271         gdbarch.
5272
5273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * rl78-tdep.c (rl78_unwind_sp): Delete.
5276         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5277
5278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5281         (xstormy16_unwind_pc): Delete.
5282         (xstormy16_dummy_id): Delete.
5283         (xstormy16_gdbarch_init): Don't register deleted functions with
5284         gdbarch.
5285
5286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5287
5288         * vax-tdep.c (vax_unwind_pc): Delete.
5289         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5290
5291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * v850-tdep.c (v850_unwind_sp): Delete.
5294         (v850_unwind_pc): Delete.
5295         (v850_dummy_id): Delete.
5296         (v850_gdbarch_init): Don't register deleted functions with
5297         gdbarch.
5298
5299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5302         (tilegx_unwind_pc): Delete.
5303         (tilegx_unwind_dummy_id): Delete.
5304         (tilegx_gdbarch_init): Don't register deleted functions with
5305         gdbarch.
5306
5307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5308
5309         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5310         (tic6x_dummy_id): Delete.
5311         (tic6x_gdbarch_init): Don't register deleted functions with
5312         gdbarch.
5313
5314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * sparc-tdep.c (sparc_unwind_pc): Delete.
5317         (sparc32_gdbarch_init): Don't register deleted function with
5318         gdbarch.
5319
5320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5321
5322         * sh-tdep.c (sh_unwind_sp): Delete.
5323         (sh_unwind_pc): Delete.
5324         (sh_dummy_id): Delete.
5325         (sh_gdbarch_init): Don't register deleted functions with
5326         gdbarch.
5327
5328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * score-tdep.c (score_unwind_sp): Delete.
5331         (score_unwind_pc): Delete.
5332         (score_dummy_id): Delete.
5333         (score_gdbarch_init): Don't register deleted functions with
5334         gdbarch.
5335
5336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * rx-tdep.c (rx_unwind_pc): Delete.
5339         (rx_unwind_sp): Delete.
5340         (rx_dummy_id): Delete.
5341         (rx_gdbarch_init): Don't register deleted functions with
5342         gdbarch.  Update comment.
5343
5344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5347         (rs6000_dummy_id): Delete.
5348         (rs6000_gdbarch_init): Don't register deleted functions with
5349         gdbarch.
5350
5351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5352
5353         * or1k-tdep.c (or1k_dummy_id): Delete.
5354         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5355
5356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * nios2-tdep.c (nios2_dummy_id): Delete.
5359         (nios2_unwind_sp): Delete.
5360         (nios2_gdbarch_init): Don't register deleted functions with
5361         gdbarch.
5362
5363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5364
5365         * nds32-tdep.c (nds32_dummy_id): Delete.
5366         (nds32_unwind_pc): Delete.
5367         (nds32_unwind_sp): Delete.
5368         (nds32_gdbarch_init): Don't register deleted functions with
5369         gdbarch.
5370
5371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * msp430-tdep.c (msp430_unwind_pc): Delete.
5374         (msp430_unwind_sp): Delete.
5375         (msp430_dummy_id): Delete.
5376         (msp430_gdbarch_init): Don't register deleted functions with
5377         gdbarch.
5378
5379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * moxie-tdep.c (moxie_unwind_sp): Delete.
5382         (moxie_unwind_pc): Delete.
5383         (moxie_dummy_id): Delete.
5384         (moxie_gdbarch_init): Don't register deleted functions with
5385         gdbarch.
5386
5387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5388
5389         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5390         (mn10300_unwind_pc): Delete.
5391         (mn10300_unwind_sp): Delete.
5392         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5393         mn10300_unwind_sp.
5394         (mn10300_frame_unwind_init): Don't register deleted functions with
5395         gdbarch.
5396
5397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * mep-tdep.c (mep_unwind_pc): Delete.
5400         (mep_unwind_sp): Delete.
5401         (mep_dummy_id): Delete.
5402         (mep_gdbarch_init): Don't register deleted functions with
5403         gdbarch.
5404
5405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5408         (m68hc11_unwind_sp): Delete.
5409         (m68hc11_gdbarch_init): Don't register deleted functions with
5410         gdbarch.
5411
5412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5413
5414         * m32r-tdep.c (m32r_unwind_sp): Delete.
5415         (m32r_unwind_pc): Delete.
5416         (m32r_dummy_id): Delete.
5417         (m32r_gdbarch_init): Don't register deleted functions with
5418         gdbarch.
5419
5420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * m32c-tdep.c (m32c_unwind_pc): Delete.
5423         (m32c_unwind_sp): Delete.
5424         (m32c_dummy_id): Delete.
5425         (m32c_gdbarch_init): Don't register deleted functions with
5426         gdbarch.
5427
5428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5431         (lm32_unwind_pc): Delete.
5432         (lm32_dummy_id): Delete.
5433         (lm32_gdbarch_init): Don't register deleted functions with
5434         gdbarch.
5435
5436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5439         (iq2000_unwind_pc): Delete.
5440         (iq2000_dummy_id): Delete.
5441         (iq2000_gdbarch_init): Don't register deleted functions with
5442         gdbarch.
5443
5444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * nds32-tdep.c (nds32_type_align): Delete.
5447         (nds32_push_dummy_call): Use type_align instead.
5448
5449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5450
5451         * arm-tdep.c (arm_type_align): Only handle vector override case.
5452         (arm_push_dummy_call): Use type_align.
5453         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5454
5455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5456
5457         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5458         case.
5459         (pass_on_stack): Use type_align.
5460         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5461         function.
5462
5463 2019-04-23  Tom Tromey  <tromey@adacore.com>
5464
5465         * dwarf2read.c (line_header::file_name_at): Remove unused
5466         overload.
5467
5468 2019-04-23  Tom de Vries  <tdevries@suse.de>
5469
5470         PR gdb/24438
5471         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5472         invocation.
5473
5474
5475 2019-03-27  Ali Tamur  <tamur@google.com>
5476
5477         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5478         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5479         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5480         (dwarf_expr_context::get_addr_index): Likewise
5481         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5482         (symbol_needs_eval_context::get_addr_index): Likewise
5483         (disassemble_dwarf_expression): Add DW_OP_addrx
5484         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5485         (read_cutu_die_from_dwo): Update comment
5486         (skip_one_die): Add DW_FORM_addrx
5487         (read_attribute_value): Likewise
5488         (var_decode_location): Add DW_OP_addrx
5489         (dwarf2_const_value_attr): Add DW_FORM_addrx
5490         (dump_die_shallow): Likewise
5491         (dwarf2_fetch_constant_bytes): Likewise
5492         (decode_locdesc): Add DW_OP_addrx
5493         (skip_form_bytes): Add DW_FORM_addrx
5494
5495 2019-04-22  Ali Tamur  <tamur@google.com>
5496
5497         * MAINTAINERS (Write After Approval): Add self.
5498
5499 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5500
5501         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5502         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5503         (open_symbol_file_object): Likewise.
5504         (svr4_default_sos): Add info parameter.
5505         (svr4_read_so_list): Likewise.
5506         (svr4_current_sos_direct): Adjust functions calls to pass down
5507         info.
5508         (svr4_current_sos_1): Add info parameter.
5509         (svr4_current_sos): Call get_svr4_info, pass info down to
5510         svr4_current_sos_1.
5511         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5512         get_svr4_info.
5513         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5514         get_svr4_info.
5515         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5516         to get_svr4_info.
5517         (probes_table_remove_objfile_probes): Likewise.
5518         (register_solib_event_probe): Add info parameter.
5519         (solist_update_incremental): Pass info parameter down to
5520         svr4_read_so_list.
5521         (disable_probes_interface): Add info parameter.
5522         (svr4_handle_solib_event): Pass current_program_space to
5523         get_svr4_info.  Adjust disable_probes_interface cleanup.
5524         (svr4_create_probe_breakpoints): Add info parameter, pass it
5525         down to register_solib_event_probe.
5526         (svr4_create_solib_event_breakpoints): Add info parameter,
5527         pass it down to svr4_create_probe_breakpoints.
5528         (enable_break): Pass info down to
5529         svr4_create_solib_event_breakpoints.
5530         (svr4_solib_create_inferior_hook): Pass current_program_space to
5531         get_svr4_info.
5532         (svr4_clear_solib): Likewise.
5533
5534 2019-04-22  Pedro Alves  <palves@redhat.com>
5535
5536         * solib-svr4.c (svr4_free_objfile_observer): New.
5537         (probe_and_action::objfile): New field.
5538         (probes_table_htab_remove_objfile_probes)
5539         (probes_table_remove_objfile_probes): New functions.
5540         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5541         in the new probe_and_action.  Don't store the probe in 'lookup'.
5542         (svr4_create_probe_breakpoints): Pass objfile to
5543         register_solib_event_probe.
5544         (_initialize_svr4_solib): Register a free_objfile observer.
5545
5546 2019-04-19  Tom Tromey  <tom@tromey.com>
5547
5548         * common/queue.h: Remove.
5549
5550 2019-04-19  Tom Tromey  <tom@tromey.com>
5551
5552         * event-loop.c: Don't include "common/queue.h".
5553
5554 2019-04-19  Tom Tromey  <tom@tromey.com>
5555
5556         * remote.c (remote_target): Use delete.
5557         * remote-notif.h: Include <list>, not "common/queue.h".
5558         (notif_client_p): Remove typedef.
5559         (remote_notif_state): Add constructor, destructor, initializer.
5560         <notif_queue>: Now a std::list.
5561         (remote_notif_state_xfree): Don't declare.
5562         * remote-notif.c (remote_notif_process, handle_notification)
5563         (remote_notif_state_allocate): Update.
5564         (~remote_notif_state): Rename from remote_notif_state_xfree.
5565
5566 2019-04-19  Tom Tromey  <tom@tromey.com>
5567
5568         * symfile.c (reread_symbols): Update.
5569         * objfiles.c (objfile_register_static_link)
5570         (objfile_lookup_static_link): Update
5571         (~objfile) Don't delete static_links.
5572         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5573
5574 2019-04-19  Tom Tromey  <tom@tromey.com>
5575
5576         * type-stack.h (struct type_stack) <insert>: Constify string.
5577         * type-stack.c (type_stack::insert): Constify string.
5578         * gdbtypes.h (lookup_template_type): Update.
5579         (address_space_name_to_int): Update.
5580         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5581         const.
5582         (lookup_template_type): Make name const.
5583         * c-exp.y: Update rules.
5584         (lex_one_token, classify_name, classify_inner_name)
5585         (c_print_token): Update.
5586         * p-exp.y: Update rules.
5587         (yylex): Update.
5588         * f-exp.y: Update rules.
5589         (yylex): Update.
5590         * d-exp.y: Update rules.
5591         (lex_one_token, classify_name, classify_inner_name): Update.
5592         * parse.c (write_dollar_variable, copy_name): Return std::string.
5593         * parser-defs.h (copy_name): Change return type.
5594         * m2-exp.y: Update rules.
5595         (yylex): Update.
5596         * go-exp.y (lex_one_token): Update.
5597         Update rules.
5598         (classify_unsafe_function, classify_packaged_name)
5599         (classify_name, yylex): Update.
5600
5601 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5602
5603         * configure.ac: add --enable-source-highlight switch.
5604         * configure: Regenerate.
5605         * top.c (print_gdb_version): plumb --enable-source-highlight
5606         status to "show configuration".
5607
5608 2019-04-19  Tom Tromey  <tromey@adacore.com>
5609
5610         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5611         Check ADA_TYPE_P.
5612         (empty_record, ada_template_to_fixed_record_type_1)
5613         (template_to_static_fixed_type)
5614         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5615         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5616         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5617         macros.
5618
5619 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5620
5621         PR symtab/24423:
5622         * source.c (print_source_lines_base): Advance "iter" when a
5623         control character is seen.
5624
5625 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5626
5627         * inferior.h (struct infcall_suspend_state_deleter):
5628         Catch exception in destructor to avoid crash.
5629
5630 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5631
5632         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5633         close to the add_com "shell".
5634
5635 2019-04-18  Tom Tromey  <tromey@adacore.com>
5636
5637         * process-stratum-target.h (class process_stratum_target)
5638         <stratum>: Add "final".
5639
5640 2019-04-17  Tom Tromey  <tromey@adacore.com>
5641
5642         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5643         against nullptr before use.
5644
5645 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5646
5647         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5648
5649 2019-04-17  Jim Wilson  <jimw@sifive.com>
5650             Andrew Burgess  <andrew.burgess@embecosm.com>
5651
5652         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5653         code read might fail, assume 4-byte breakpoint in that case.
5654
5655 2019-04-15  Leszek Swirski  <leszeks@google.com>
5656
5657         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5658         rather than a hand-rolled POD check when checking for forced MEMORY
5659         classification.
5660
5661 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5662
5663         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5664         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5665         function.
5666         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5667         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5668         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5669         declaration.
5670
5671 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5672
5673         * aarch64-linux-nat.c
5674         (aarch64_linux_nat_target::thread_architecture): Add override.
5675         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5676         each VQ.
5677
5678 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5679
5680         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5681
5682 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5683
5684         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5685         target types of size 96-bits, add some additional comments, and
5686         check that the builtin type we found was the correct size.
5687
5688 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5689
5690         * utils.c (prompt_for_continue): Don't restore the styling at the
5691         end, as applied_style has the wrong value.  This fixes styling in
5692         long lists of file names that are interrupted by the "Continue?"
5693         prompt.
5694
5695 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5698         * c-lang.c (c_language_defn): Likewise.
5699         (cplus_language_defn): Likewise.
5700         (asm_language_defn): Likewise.
5701         (minimal_language_defn): Likewise.
5702         * d-lang.c (d_language_defn): Likewise.
5703         * f-lang.c (f_language_defn): Likewise.
5704         * go-lang.c (go_language_defn): Likewise.
5705         * language.c (unknown_language_defn): Likewise.
5706         (auto_language_defn): Likewise.
5707         * language.h (struct language_defn): Remove la_magic field.
5708         (LANG_MAGIC): Delete.
5709         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5710         * objc-lang.c (objc_language_defn): Likewise.
5711         * opencl-lang.c (opencl_language_defn): Likewise.
5712         * p-lang.c (pascal_language_defn): Likewise.
5713         * rust-lang.c (rust_language_defn): Likewise.
5714
5715 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * riscv-tdep.c (riscv_type_align): New function.
5718         (riscv_type_alignment): Delete.
5719         (riscv_arg_location): Use 'type_align'.
5720         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5721
5722 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5723
5724         * gdbtypes.c (type_align): A struct with no non-static fields also
5725         has alignment of 1.
5726
5727 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5730         component to 0.
5731         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5732         member.
5733         (riscv_struct_info::analyse): New implementation using new
5734         analyse_inner member function.
5735         (riscv_struct_info::field_offset): New member function.
5736         (riscv_struct_info::m_offsets): New member variable.
5737         (riscv_struct_info::analyse_inner): New private member function,
5738         takes the old implementation of riscv_struct_info::analyse but
5739         extended to track field offsets.
5740         (riscv_call_arg_struct): Update the struct folding special cases
5741         to handle cases where empty C++ structs, which are non-zero
5742         length, are found.
5743         (riscv_arg_location): Initialise the length of each location, a
5744         non-zero length now indicates the location is in use.
5745         (riscv_push_dummy_call): Allow for the first location having a
5746         non-zero offset when setting up arguments.
5747         (riscv_return_value): Likewise, but for return values.
5748
5749 2019-04-11  Tom Tromey  <tromey@adacore.com>
5750
5751         * utils.c (internal_vproblem): Make "msg" const.
5752
5753 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5754
5755         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5756         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5757         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5758         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5759
5760 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5761
5762         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5763         function.
5764         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5765         of amd64_collect_native_gregset.
5766         (amd64_linux_nat_target::store_registers): Likewise.
5767
5768 2019-04-10  Tom Tromey  <tom@tromey.com>
5769
5770         * symtab.c (lookup_global_symbol_from_objfile)
5771         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5772         * objfiles.h (class separate_debug_iterator): New.
5773         (class separate_debug_range): New.
5774         (struct objfile) <separate_debug_objfiles>: New method.
5775         (objfile_separate_debug_iterate): Don't declare.
5776         * objfiles.c (separate_debug_iterator::operator++): Rename from
5777         objfile_separate_debug_iterate.
5778         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5779         iterator.
5780         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5781         iterator.
5782
5783 2019-04-10  Tom Tromey  <tom@tromey.com>
5784
5785         * symfile.c (reread_symbols): Remove old comment.
5786         * objfiles.c (free_all_objfiles): Fix a typo.
5787
5788 2019-04-10  Tom Tromey  <tom@tromey.com>
5789
5790         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5791         * minsyms.c (lookup_minimal_symbol): Use foreach.
5792         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5793         (lookup_minimal_symbol_solib_trampoline): Likewise.
5794         * symfile.c (reread_symbols): Use foreach.
5795
5796 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5797             Tom Tromey  <tromey@adacore.com>
5798
5799         PR rust/24414:
5800         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5801         (rust_lex_int_test): Change "value" to be LONGEST.
5802         (rust_lex_tests): Add test for long integer literal.
5803
5804 2019-04-09  Tom Tromey  <tromey@adacore.com>
5805
5806         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5807         to bool.
5808         (extended_remote_target::attach): Update.
5809         (remote_target::remote_notice_new_inferior): Update.
5810         (remote_target::add_current_inferior_and_thread): Update.
5811         * inferior.c (exit_inferior_1): Use "false".
5812         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5813
5814 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5815
5816         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5817         the "start" command.
5818
5819 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5820
5821         * python/py-inferior.c (infpy_thread_from_thread_handle):
5822         Adjust comments to reflect renaming of thread_from_thread_handle
5823         to thread_from_handle.  Adjust keywords.  Fix type error message.
5824         (inferior_object_methods): Add thread_from_handle.  Retain
5825         thread_from_thread_handle, but mark it as deprecated.
5826
5827 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5828
5829         * gdbthread.h (find_thread_by_handle): Revise declaration.
5830         * thread.c (find_thread_by_handle): Likewise.  Adjust
5831         implementation too.
5832         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5833         support for buffer objects as handles.
5834
5835 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5836
5837         * python/py-infthread.c (thpy_thread_handle): New function.
5838         (thread_object_methods): Register thpy_thread_handle.
5839
5840 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5841
5842         * gdbthread.h (thread_to_thread_handle): Declare.
5843         * thread.c (gdbtypes.h): Include.
5844         (thread_to_thread_handle): New function.
5845
5846         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5847         (target_thread_info_to_thread_handle): Declare.
5848         * target.c (target_thread_info_to_thread_handle): New function.
5849         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5850         * target-delegates.c: Regenerate.
5851
5852         * linux-thread-db.c (class thread_db_target): Add method
5853         thread_info_to_thread_handle.
5854         (thread_db_target::thread_info_to_thread_handle): Define.
5855         * remote.c (class remote_target): Add new method
5856         thread_info_to_thread_handle.
5857         (remote_target::thread_info_to_thread_handle): Define.
5858
5859 2019-04-08  Pedro Alves  <palves@redhat.com>
5860
5861         * common/common-exceptions.c (throw_exception): Don't create
5862         named object to throw; throw directly.
5863         (throw_it): Likewise.  Don't initialize gdb_exception::message
5864         here, with new; pass FMT and AP to the ctor instead.
5865         * common/common-exceptions.h: Include <string>.
5866         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5867         const char *, va_list)): New ctor.  Use std::make_shared.
5868         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5869         errors)): Delete.
5870         (gdb_exception_error::gdb_exception_error(enum errors, const char
5871         *, va_list)): New.
5872         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5873         Add assertion.
5874         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5875         errors)): Delete.
5876         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5877         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5878         Add assertion.
5879
5880 2019-04-08  Tom Tromey  <tom@tromey.com>
5881
5882         * valops.c (value_rtti_indirect_type): Replace throw_exception
5883         with throw.
5884         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5885         with throw.
5886         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5887         throw.
5888         * target.c (target_translate_tls_address): Replace throw_exception
5889         with throw.
5890         * stack.c (frame_apply_command_count): Replace throw_exception
5891         with throw.
5892         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5893         throw.
5894         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5895         with throw.
5896         * rs6000-tdep.c (rs6000_frame_cache)
5897         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5898         * remote.c: Replace throw_exception with throw.
5899         * record-full.c (record_full_message, record_full_wait_1)
5900         (record_full_restore): Replace throw_exception with throw.
5901         * record-btrace.c:
5902         (get_thread_current_frame_id, record_btrace_start_replaying)
5903         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5904         (cmd_record_btrace_start): Replace throw_exception with throw.
5905         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5906         throw.
5907         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5908         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5909         * linespec.c:
5910         (find_linespec_symbols): Replace throw_exception with throw.
5911         * infrun.c (displaced_step_prepare, resume): Replace
5912         throw_exception with throw.
5913         * infcmd.c (post_create_inferior): Replace throw_exception with
5914         throw.
5915         * inf-loop.c (inferior_event_handler): Replace throw_exception
5916         with throw.
5917         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5918         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5919         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5920         (get_prev_frame_always, get_frame_pc_if_available)
5921         (get_frame_address_in_block_if_available, get_frame_language):
5922         Replace throw_exception with throw.
5923         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5924         throw_exception with throw.
5925         * eval.c (fetch_subexp_value, evaluate_var_value)
5926         (evaluate_funcall, evaluate_subexp_standard): Replace
5927         throw_exception with throw.
5928         * dwarf2loc.c (call_site_find_chain)
5929         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5930         Replace throw_exception with throw.
5931         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5932         with throw.
5933         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5934         throw.
5935         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5936         * completer.c (complete_line_internal): Replace throw_exception
5937         with throw.
5938         * compile/compile-object-run.c (compile_object_run): Replace
5939         throw_exception with throw.
5940         * cli/cli-script.c (process_next_line): Replace throw_exception
5941         with throw.
5942         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5943         (btrace_enable, btrace_maint_update_pt_packets): Replace
5944         throw_exception with throw.
5945         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5946         throw_exception with throw.
5947         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5948         throw_exception with throw.
5949         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5950         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5951         * aarch64-tdep.c (aarch64_make_prologue_cache)
5952         (aarch64_make_stub_cache): Replace throw_exception with throw.
5953
5954 2019-04-08  Tom Tromey  <tom@tromey.com>
5955
5956         * common/common-exceptions.c (throw_exception): Rename from
5957         throw_exception_cxx.  Remove old copy.  Make argument const.
5958         (throw_it): Create and throw exception objects directly.
5959         * common/common-exceptions.h (throw_exception): Make argument
5960         const.
5961         (struct gdb_exception_error): Add constructor.
5962         (struct gdb_exception_quit): Add constructor.
5963
5964 2019-04-08  Tom Tromey  <tom@tromey.com>
5965
5966         * common/common-exceptions.h (exception_rethrow): Don't declare.
5967         (TRY_SJLJ): Update comment.
5968         (TRY, CATCH, END_CATCH): Remove.
5969         * common/common-exceptions.c (exception_rethrow): Remove.
5970
5971 2019-04-08  Tom Tromey  <tom@tromey.com>
5972
5973         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5974         Remove.
5975         (gdb_exception_error): Rename from
5976         gdb_exception_RETURN_MASK_ERROR.
5977         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5978         (gdb_quit_bad_alloc): Update.
5979         * aarch64-tdep.c: Update.
5980         * ada-lang.c: Update.
5981         * ada-typeprint.c: Update.
5982         * ada-valprint.c: Update.
5983         * amd64-tdep.c: Update.
5984         * arch-utils.c: Update.
5985         * break-catch-throw.c: Update.
5986         * breakpoint.c: Update.
5987         * btrace.c: Update.
5988         * c-varobj.c: Update.
5989         * cli/cli-cmds.c: Update.
5990         * cli/cli-interp.c: Update.
5991         * cli/cli-script.c: Update.
5992         * common/common-exceptions.c: Update.
5993         * common/new-op.c: Update.
5994         * common/selftest.c: Update.
5995         * compile/compile-c-symbols.c: Update.
5996         * compile/compile-cplus-symbols.c: Update.
5997         * compile/compile-object-load.c: Update.
5998         * compile/compile-object-run.c: Update.
5999         * completer.c: Update.
6000         * corelow.c: Update.
6001         * cp-abi.c: Update.
6002         * cp-support.c: Update.
6003         * cp-valprint.c: Update.
6004         * darwin-nat.c: Update.
6005         * disasm-selftests.c: Update.
6006         * dtrace-probe.c: Update.
6007         * dwarf-index-cache.c: Update.
6008         * dwarf-index-write.c: Update.
6009         * dwarf2-frame-tailcall.c: Update.
6010         * dwarf2-frame.c: Update.
6011         * dwarf2loc.c: Update.
6012         * dwarf2read.c: Update.
6013         * eval.c: Update.
6014         * event-loop.c: Update.
6015         * event-top.c: Update.
6016         * exec.c: Update.
6017         * f-valprint.c: Update.
6018         * fbsd-tdep.c: Update.
6019         * frame-unwind.c: Update.
6020         * frame.c: Update.
6021         * gdbtypes.c: Update.
6022         * gnu-v3-abi.c: Update.
6023         * guile/guile-internal.h: Update.
6024         * guile/scm-block.c: Update.
6025         * guile/scm-breakpoint.c: Update.
6026         * guile/scm-cmd.c: Update.
6027         * guile/scm-disasm.c: Update.
6028         * guile/scm-frame.c: Update.
6029         * guile/scm-lazy-string.c: Update.
6030         * guile/scm-math.c: Update.
6031         * guile/scm-param.c: Update.
6032         * guile/scm-ports.c: Update.
6033         * guile/scm-pretty-print.c: Update.
6034         * guile/scm-symbol.c: Update.
6035         * guile/scm-symtab.c: Update.
6036         * guile/scm-type.c: Update.
6037         * guile/scm-value.c: Update.
6038         * i386-linux-tdep.c: Update.
6039         * i386-tdep.c: Update.
6040         * inf-loop.c: Update.
6041         * infcall.c: Update.
6042         * infcmd.c: Update.
6043         * infrun.c: Update.
6044         * jit.c: Update.
6045         * language.c: Update.
6046         * linespec.c: Update.
6047         * linux-fork.c: Update.
6048         * linux-nat.c: Update.
6049         * linux-tdep.c: Update.
6050         * linux-thread-db.c: Update.
6051         * main.c: Update.
6052         * mi/mi-cmd-break.c: Update.
6053         * mi/mi-cmd-stack.c: Update.
6054         * mi/mi-interp.c: Update.
6055         * mi/mi-main.c: Update.
6056         * objc-lang.c: Update.
6057         * p-valprint.c: Update.
6058         * parse.c: Update.
6059         * ppc-linux-tdep.c: Update.
6060         * printcmd.c: Update.
6061         * python/py-arch.c: Update.
6062         * python/py-breakpoint.c: Update.
6063         * python/py-cmd.c: Update.
6064         * python/py-finishbreakpoint.c: Update.
6065         * python/py-frame.c: Update.
6066         * python/py-framefilter.c: Update.
6067         * python/py-gdb-readline.c: Update.
6068         * python/py-inferior.c: Update.
6069         * python/py-infthread.c: Update.
6070         * python/py-lazy-string.c: Update.
6071         * python/py-linetable.c: Update.
6072         * python/py-objfile.c: Update.
6073         * python/py-param.c: Update.
6074         * python/py-prettyprint.c: Update.
6075         * python/py-progspace.c: Update.
6076         * python/py-record-btrace.c: Update.
6077         * python/py-record.c: Update.
6078         * python/py-symbol.c: Update.
6079         * python/py-type.c: Update.
6080         * python/py-unwind.c: Update.
6081         * python/py-utils.c: Update.
6082         * python/py-value.c: Update.
6083         * python/python.c: Update.
6084         * record-btrace.c: Update.
6085         * record-full.c: Update.
6086         * remote-fileio.c: Update.
6087         * remote.c: Update.
6088         * riscv-tdep.c: Update.
6089         * rs6000-aix-tdep.c: Update.
6090         * rs6000-tdep.c: Update.
6091         * rust-exp.y: Update.
6092         * rust-lang.c: Update.
6093         * s390-tdep.c: Update.
6094         * selftest-arch.c: Update.
6095         * solib-dsbt.c: Update.
6096         * solib-frv.c: Update.
6097         * solib-spu.c: Update.
6098         * solib-svr4.c: Update.
6099         * solib.c: Update.
6100         * sparc64-linux-tdep.c: Update.
6101         * stack.c: Update.
6102         * symfile-mem.c: Update.
6103         * symmisc.c: Update.
6104         * target.c: Update.
6105         * thread.c: Update.
6106         * top.c: Update.
6107         * tracefile-tfile.c: Update.
6108         * tui/tui.c: Update.
6109         * typeprint.c: Update.
6110         * unittests/cli-utils-selftests.c: Update.
6111         * unittests/parse-connection-spec-selftests.c: Update.
6112         * valops.c: Update.
6113         * valprint.c: Update.
6114         * value.c: Update.
6115         * varobj.c: Update.
6116         * windows-nat.c: Update.
6117         * x86-linux-nat.c: Update.
6118         * xml-support.c: Update.
6119
6120 2019-04-08  Tom Tromey  <tom@tromey.com>
6121
6122         * xml-support.c: Use C++ exception handling.
6123         * x86-linux-nat.c: Use C++ exception handling.
6124         * windows-nat.c: Use C++ exception handling.
6125         * varobj.c: Use C++ exception handling.
6126         * value.c: Use C++ exception handling.
6127         * valprint.c: Use C++ exception handling.
6128         * valops.c: Use C++ exception handling.
6129         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6130         handling.
6131         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6132         * typeprint.c: Use C++ exception handling.
6133         * tui/tui.c: Use C++ exception handling.
6134         * tracefile-tfile.c: Use C++ exception handling.
6135         * top.c: Use C++ exception handling.
6136         * thread.c: Use C++ exception handling.
6137         * target.c: Use C++ exception handling.
6138         * symmisc.c: Use C++ exception handling.
6139         * symfile-mem.c: Use C++ exception handling.
6140         * stack.c: Use C++ exception handling.
6141         * sparc64-linux-tdep.c: Use C++ exception handling.
6142         * solib.c: Use C++ exception handling.
6143         * solib-svr4.c: Use C++ exception handling.
6144         * solib-spu.c: Use C++ exception handling.
6145         * solib-frv.c: Use C++ exception handling.
6146         * solib-dsbt.c: Use C++ exception handling.
6147         * selftest-arch.c: Use C++ exception handling.
6148         * s390-tdep.c: Use C++ exception handling.
6149         * rust-lang.c: Use C++ exception handling.
6150         * rust-exp.y: Use C++ exception handling.
6151         * rs6000-tdep.c: Use C++ exception handling.
6152         * rs6000-aix-tdep.c: Use C++ exception handling.
6153         * riscv-tdep.c: Use C++ exception handling.
6154         * remote.c: Use C++ exception handling.
6155         * remote-fileio.c: Use C++ exception handling.
6156         * record-full.c: Use C++ exception handling.
6157         * record-btrace.c: Use C++ exception handling.
6158         * python/python.c: Use C++ exception handling.
6159         * python/py-value.c: Use C++ exception handling.
6160         * python/py-utils.c: Use C++ exception handling.
6161         * python/py-unwind.c: Use C++ exception handling.
6162         * python/py-type.c: Use C++ exception handling.
6163         * python/py-symbol.c: Use C++ exception handling.
6164         * python/py-record.c: Use C++ exception handling.
6165         * python/py-record-btrace.c: Use C++ exception handling.
6166         * python/py-progspace.c: Use C++ exception handling.
6167         * python/py-prettyprint.c: Use C++ exception handling.
6168         * python/py-param.c: Use C++ exception handling.
6169         * python/py-objfile.c: Use C++ exception handling.
6170         * python/py-linetable.c: Use C++ exception handling.
6171         * python/py-lazy-string.c: Use C++ exception handling.
6172         * python/py-infthread.c: Use C++ exception handling.
6173         * python/py-inferior.c: Use C++ exception handling.
6174         * python/py-gdb-readline.c: Use C++ exception handling.
6175         * python/py-framefilter.c: Use C++ exception handling.
6176         * python/py-frame.c: Use C++ exception handling.
6177         * python/py-finishbreakpoint.c: Use C++ exception handling.
6178         * python/py-cmd.c: Use C++ exception handling.
6179         * python/py-breakpoint.c: Use C++ exception handling.
6180         * python/py-arch.c: Use C++ exception handling.
6181         * printcmd.c: Use C++ exception handling.
6182         * ppc-linux-tdep.c: Use C++ exception handling.
6183         * parse.c: Use C++ exception handling.
6184         * p-valprint.c: Use C++ exception handling.
6185         * objc-lang.c: Use C++ exception handling.
6186         * mi/mi-main.c: Use C++ exception handling.
6187         * mi/mi-interp.c: Use C++ exception handling.
6188         * mi/mi-cmd-stack.c: Use C++ exception handling.
6189         * mi/mi-cmd-break.c: Use C++ exception handling.
6190         * main.c: Use C++ exception handling.
6191         * linux-thread-db.c: Use C++ exception handling.
6192         * linux-tdep.c: Use C++ exception handling.
6193         * linux-nat.c: Use C++ exception handling.
6194         * linux-fork.c: Use C++ exception handling.
6195         * linespec.c: Use C++ exception handling.
6196         * language.c: Use C++ exception handling.
6197         * jit.c: Use C++ exception handling.
6198         * infrun.c: Use C++ exception handling.
6199         * infcmd.c: Use C++ exception handling.
6200         * infcall.c: Use C++ exception handling.
6201         * inf-loop.c: Use C++ exception handling.
6202         * i386-tdep.c: Use C++ exception handling.
6203         * i386-linux-tdep.c: Use C++ exception handling.
6204         * guile/scm-value.c: Use C++ exception handling.
6205         * guile/scm-type.c: Use C++ exception handling.
6206         * guile/scm-symtab.c: Use C++ exception handling.
6207         * guile/scm-symbol.c: Use C++ exception handling.
6208         * guile/scm-pretty-print.c: Use C++ exception handling.
6209         * guile/scm-ports.c: Use C++ exception handling.
6210         * guile/scm-param.c: Use C++ exception handling.
6211         * guile/scm-math.c: Use C++ exception handling.
6212         * guile/scm-lazy-string.c: Use C++ exception handling.
6213         * guile/scm-frame.c: Use C++ exception handling.
6214         * guile/scm-disasm.c: Use C++ exception handling.
6215         * guile/scm-cmd.c: Use C++ exception handling.
6216         * guile/scm-breakpoint.c: Use C++ exception handling.
6217         * guile/scm-block.c: Use C++ exception handling.
6218         * guile/guile-internal.h: Use C++ exception handling.
6219         * gnu-v3-abi.c: Use C++ exception handling.
6220         * gdbtypes.c: Use C++ exception handling.
6221         * frame.c: Use C++ exception handling.
6222         * frame-unwind.c: Use C++ exception handling.
6223         * fbsd-tdep.c: Use C++ exception handling.
6224         * f-valprint.c: Use C++ exception handling.
6225         * exec.c: Use C++ exception handling.
6226         * event-top.c: Use C++ exception handling.
6227         * event-loop.c: Use C++ exception handling.
6228         * eval.c: Use C++ exception handling.
6229         * dwarf2read.c: Use C++ exception handling.
6230         * dwarf2loc.c: Use C++ exception handling.
6231         * dwarf2-frame.c: Use C++ exception handling.
6232         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6233         * dwarf-index-write.c: Use C++ exception handling.
6234         * dwarf-index-cache.c: Use C++ exception handling.
6235         * dtrace-probe.c: Use C++ exception handling.
6236         * disasm-selftests.c: Use C++ exception handling.
6237         * darwin-nat.c: Use C++ exception handling.
6238         * cp-valprint.c: Use C++ exception handling.
6239         * cp-support.c: Use C++ exception handling.
6240         * cp-abi.c: Use C++ exception handling.
6241         * corelow.c: Use C++ exception handling.
6242         * completer.c: Use C++ exception handling.
6243         * compile/compile-object-run.c: Use C++ exception handling.
6244         * compile/compile-object-load.c: Use C++ exception handling.
6245         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6246         * compile/compile-c-symbols.c: Use C++ exception handling.
6247         * common/selftest.c: Use C++ exception handling.
6248         * common/new-op.c: Use C++ exception handling.
6249         * cli/cli-script.c: Use C++ exception handling.
6250         * cli/cli-interp.c: Use C++ exception handling.
6251         * cli/cli-cmds.c: Use C++ exception handling.
6252         * c-varobj.c: Use C++ exception handling.
6253         * btrace.c: Use C++ exception handling.
6254         * breakpoint.c: Use C++ exception handling.
6255         * break-catch-throw.c: Use C++ exception handling.
6256         * arch-utils.c: Use C++ exception handling.
6257         * amd64-tdep.c: Use C++ exception handling.
6258         * ada-valprint.c: Use C++ exception handling.
6259         * ada-typeprint.c: Use C++ exception handling.
6260         * ada-lang.c: Use C++ exception handling.
6261         * aarch64-tdep.c: Use C++ exception handling.
6262
6263 2019-04-08  Tom Tromey  <tom@tromey.com>
6264
6265         * xml-support.c (gdb_xml_parser::parse): Update.
6266         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6267         * value.c (show_convenience): Update.
6268         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6269         (test_parse_flags_qcs): Update.
6270         * thread.c (thr_try_catch_cmd): Update.
6271         * target.c (target_translate_tls_address): Update.
6272         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6273         (info_frame_command_core, frame_apply_command_count): Update.
6274         * rust-exp.y (rust_lex_exception_test): Update.
6275         * riscv-tdep.c (riscv_print_one_register_info): Update.
6276         * remote.c (remote_target::enable_btrace): Update.
6277         * record-btrace.c (record_btrace_enable_warn): Update.
6278         * python/py-utils.c (gdbpy_convert_exception): Update.
6279         * printcmd.c (do_one_display, print_variable_and_value): Update.
6280         * mi/mi-main.c (mi_print_exception): Update.
6281         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6282         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6283         * linux-nat.c (linux_nat_target::attach): Update.
6284         * linux-fork.c (class scoped_switch_fork_info): Update.
6285         * infrun.c (displaced_step_prepare): Update.
6286         * infcall.c (call_function_by_hand_dummy): Update.
6287         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6288         * gnu-v3-abi.c (print_one_vtable): Update.
6289         * frame.c (get_prev_frame_always): Update.
6290         * f-valprint.c (info_common_command_for_block): Update.
6291         * exec.c (try_open_exec_file): Update.
6292         * exceptions.c (print_exception, exception_print)
6293         (exception_fprintf, exception_print_same): Update.
6294         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6295         * dwarf-index-cache.c (index_cache::store)
6296         (index_cache::lookup_gdb_index): Update.
6297         * darwin-nat.c (maybe_cache_shell): Update.
6298         * cp-valprint.c (cp_print_value_fields): Update.
6299         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6300         (gcc_cplus_symbol_address): Update.
6301         * compile/compile-c-symbols.c (gcc_convert_symbol)
6302         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6303         * common/selftest.c: Update.
6304         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6305         a std::string.
6306         (exception_try_scope_entry, exception_try_scope_exit): Don't
6307         declare.
6308         (struct exception_try_scope): Remove.
6309         (TRY): Don't use exception_try_scope.
6310         (struct gdb_exception): Add constructor, operator=.
6311         <what>: New method.
6312         (struct gdb_exception_RETURN_MASK_ALL)
6313         (struct gdb_exception_RETURN_MASK_ERROR)
6314         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6315         (struct gdb_quit_bad_alloc): Update.
6316         * common/common-exceptions.c (exception_none): Change
6317         initializer.
6318         (struct catcher) <state, exception>: Initialize inline.
6319         <prev>: Remove member.
6320         (current_catcher): Remove.
6321         (catchers): New global.
6322         (exceptions_state_mc_init): Simplify.
6323         (catcher_pop): Remove.
6324         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6325         (try_scope_depth, exception_try_scope_entry)
6326         (exception_try_scope_exit): Remove.
6327         (throw_exception_sjlj): Update.
6328         (exception_messages, exception_messages_size): Remove.
6329         (throw_it): Simplify.
6330         (gdb_exception_sliced_copy): Remove.
6331         (throw_exception_cxx): Update.
6332         * cli/cli-script.c (script_from_file): Update.
6333         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6334         Update.
6335         * ada-valprint.c (ada_val_print): Update.
6336         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6337         (create_excep_cond_exprs): Update.
6338
6339 2019-04-08  Tom Tromey  <tom@tromey.com>
6340
6341         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6342         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6343         (TRY, CATCH, END_CATCH): Remove some definitions.
6344         * common/common-exceptions.c: Don't use GDB_XCPT.
6345         (catcher_list_size): Remove.
6346         (throw_exception, throw_it): Simplify.
6347
6348 2019-04-05  Tom Tromey  <tom@tromey.com>
6349
6350         Revert the header-sorting patch.
6351         * ft32-tdep.c: Revert.
6352         * frv-tdep.c: Revert.
6353         * frv-linux-tdep.c: Revert.
6354         * frame.c: Revert.
6355         * frame-unwind.c: Revert.
6356         * frame-base.c: Revert.
6357         * fork-child.c: Revert.
6358         * findvar.c: Revert.
6359         * findcmd.c: Revert.
6360         * filesystem.c: Revert.
6361         * filename-seen-cache.h: Revert.
6362         * filename-seen-cache.c: Revert.
6363         * fbsd-tdep.c: Revert.
6364         * fbsd-nat.h: Revert.
6365         * fbsd-nat.c: Revert.
6366         * f-valprint.c: Revert.
6367         * f-typeprint.c: Revert.
6368         * f-lang.c: Revert.
6369         * extension.h: Revert.
6370         * extension.c: Revert.
6371         * extension-priv.h: Revert.
6372         * expprint.c: Revert.
6373         * exec.h: Revert.
6374         * exec.c: Revert.
6375         * exceptions.c: Revert.
6376         * event-top.c: Revert.
6377         * event-loop.c: Revert.
6378         * eval.c: Revert.
6379         * elfread.c: Revert.
6380         * dwarf2read.h: Revert.
6381         * dwarf2read.c: Revert.
6382         * dwarf2loc.c: Revert.
6383         * dwarf2expr.h: Revert.
6384         * dwarf2expr.c: Revert.
6385         * dwarf2-frame.c: Revert.
6386         * dwarf2-frame-tailcall.c: Revert.
6387         * dwarf-index-write.h: Revert.
6388         * dwarf-index-write.c: Revert.
6389         * dwarf-index-common.c: Revert.
6390         * dwarf-index-cache.h: Revert.
6391         * dwarf-index-cache.c: Revert.
6392         * dummy-frame.c: Revert.
6393         * dtrace-probe.c: Revert.
6394         * disasm.h: Revert.
6395         * disasm.c: Revert.
6396         * disasm-selftests.c: Revert.
6397         * dictionary.c: Revert.
6398         * dicos-tdep.c: Revert.
6399         * demangle.c: Revert.
6400         * dcache.h: Revert.
6401         * dcache.c: Revert.
6402         * darwin-nat.h: Revert.
6403         * darwin-nat.c: Revert.
6404         * darwin-nat-info.c: Revert.
6405         * d-valprint.c: Revert.
6406         * d-namespace.c: Revert.
6407         * d-lang.c: Revert.
6408         * ctf.c: Revert.
6409         * csky-tdep.c: Revert.
6410         * csky-linux-tdep.c: Revert.
6411         * cris-tdep.c: Revert.
6412         * cris-linux-tdep.c: Revert.
6413         * cp-valprint.c: Revert.
6414         * cp-support.c: Revert.
6415         * cp-namespace.c: Revert.
6416         * cp-abi.c: Revert.
6417         * corelow.c: Revert.
6418         * corefile.c: Revert.
6419         * continuations.c: Revert.
6420         * completer.h: Revert.
6421         * completer.c: Revert.
6422         * complaints.c: Revert.
6423         * coffread.c: Revert.
6424         * coff-pe-read.c: Revert.
6425         * cli-out.h: Revert.
6426         * cli-out.c: Revert.
6427         * charset.c: Revert.
6428         * c-varobj.c: Revert.
6429         * c-valprint.c: Revert.
6430         * c-typeprint.c: Revert.
6431         * c-lang.c: Revert.
6432         * buildsym.c: Revert.
6433         * buildsym-legacy.c: Revert.
6434         * build-id.h: Revert.
6435         * build-id.c: Revert.
6436         * btrace.c: Revert.
6437         * bsd-uthread.c: Revert.
6438         * breakpoint.h: Revert.
6439         * breakpoint.c: Revert.
6440         * break-catch-throw.c: Revert.
6441         * break-catch-syscall.c: Revert.
6442         * break-catch-sig.c: Revert.
6443         * blockframe.c: Revert.
6444         * block.c: Revert.
6445         * bfin-tdep.c: Revert.
6446         * bfin-linux-tdep.c: Revert.
6447         * bfd-target.c: Revert.
6448         * bcache.c: Revert.
6449         * ax-general.c: Revert.
6450         * ax-gdb.h: Revert.
6451         * ax-gdb.c: Revert.
6452         * avr-tdep.c: Revert.
6453         * auxv.c: Revert.
6454         * auto-load.c: Revert.
6455         * arm-wince-tdep.c: Revert.
6456         * arm-tdep.c: Revert.
6457         * arm-symbian-tdep.c: Revert.
6458         * arm-pikeos-tdep.c: Revert.
6459         * arm-obsd-tdep.c: Revert.
6460         * arm-nbsd-tdep.c: Revert.
6461         * arm-nbsd-nat.c: Revert.
6462         * arm-linux-tdep.c: Revert.
6463         * arm-linux-nat.c: Revert.
6464         * arm-fbsd-tdep.c: Revert.
6465         * arm-fbsd-nat.c: Revert.
6466         * arm-bsd-tdep.c: Revert.
6467         * arch-utils.c: Revert.
6468         * arc-tdep.c: Revert.
6469         * arc-newlib-tdep.c: Revert.
6470         * annotate.h: Revert.
6471         * annotate.c: Revert.
6472         * amd64-windows-tdep.c: Revert.
6473         * amd64-windows-nat.c: Revert.
6474         * amd64-tdep.c: Revert.
6475         * amd64-sol2-tdep.c: Revert.
6476         * amd64-obsd-tdep.c: Revert.
6477         * amd64-obsd-nat.c: Revert.
6478         * amd64-nbsd-tdep.c: Revert.
6479         * amd64-nbsd-nat.c: Revert.
6480         * amd64-nat.c: Revert.
6481         * amd64-linux-tdep.c: Revert.
6482         * amd64-linux-nat.c: Revert.
6483         * amd64-fbsd-tdep.c: Revert.
6484         * amd64-fbsd-nat.c: Revert.
6485         * amd64-dicos-tdep.c: Revert.
6486         * amd64-darwin-tdep.c: Revert.
6487         * amd64-bsd-nat.c: Revert.
6488         * alpha-tdep.c: Revert.
6489         * alpha-obsd-tdep.c: Revert.
6490         * alpha-nbsd-tdep.c: Revert.
6491         * alpha-mdebug-tdep.c: Revert.
6492         * alpha-linux-tdep.c: Revert.
6493         * alpha-linux-nat.c: Revert.
6494         * alpha-bsd-tdep.c: Revert.
6495         * alpha-bsd-nat.c: Revert.
6496         * aix-thread.c: Revert.
6497         * agent.c: Revert.
6498         * addrmap.c: Revert.
6499         * ada-varobj.c: Revert.
6500         * ada-valprint.c: Revert.
6501         * ada-typeprint.c: Revert.
6502         * ada-tasks.c: Revert.
6503         * ada-lang.c: Revert.
6504         * aarch64-tdep.c: Revert.
6505         * aarch64-ravenscar-thread.c: Revert.
6506         * aarch64-newlib-tdep.c: Revert.
6507         * aarch64-linux-tdep.c: Revert.
6508         * aarch64-linux-nat.c: Revert.
6509         * aarch64-fbsd-tdep.c: Revert.
6510         * aarch64-fbsd-nat.c: Revert.
6511         * aarch32-linux-nat.c: Revert.
6512
6513 2019-04-05  Tom Tromey  <tom@tromey.com>
6514
6515         * ft32-tdep.c: Sort headers.
6516         * frv-tdep.c: Sort headers.
6517         * frv-linux-tdep.c: Sort headers.
6518         * frame.c: Sort headers.
6519         * frame-unwind.c: Sort headers.
6520         * frame-base.c: Sort headers.
6521         * fork-child.c: Sort headers.
6522         * findvar.c: Sort headers.
6523         * findcmd.c: Sort headers.
6524         * filesystem.c: Sort headers.
6525         * filename-seen-cache.h: Sort headers.
6526         * filename-seen-cache.c: Sort headers.
6527         * fbsd-tdep.c: Sort headers.
6528         * fbsd-nat.h: Sort headers.
6529         * fbsd-nat.c: Sort headers.
6530         * f-valprint.c: Sort headers.
6531         * f-typeprint.c: Sort headers.
6532         * f-lang.c: Sort headers.
6533         * extension.h: Sort headers.
6534         * extension.c: Sort headers.
6535         * extension-priv.h: Sort headers.
6536         * expprint.c: Sort headers.
6537         * exec.h: Sort headers.
6538         * exec.c: Sort headers.
6539         * exceptions.c: Sort headers.
6540         * event-top.c: Sort headers.
6541         * event-loop.c: Sort headers.
6542         * eval.c: Sort headers.
6543         * elfread.c: Sort headers.
6544         * dwarf2read.h: Sort headers.
6545         * dwarf2read.c: Sort headers.
6546         * dwarf2loc.c: Sort headers.
6547         * dwarf2expr.h: Sort headers.
6548         * dwarf2expr.c: Sort headers.
6549         * dwarf2-frame.c: Sort headers.
6550         * dwarf2-frame-tailcall.c: Sort headers.
6551         * dwarf-index-write.h: Sort headers.
6552         * dwarf-index-write.c: Sort headers.
6553         * dwarf-index-common.c: Sort headers.
6554         * dwarf-index-cache.h: Sort headers.
6555         * dwarf-index-cache.c: Sort headers.
6556         * dummy-frame.c: Sort headers.
6557         * dtrace-probe.c: Sort headers.
6558         * disasm.h: Sort headers.
6559         * disasm.c: Sort headers.
6560         * disasm-selftests.c: Sort headers.
6561         * dictionary.c: Sort headers.
6562         * dicos-tdep.c: Sort headers.
6563         * demangle.c: Sort headers.
6564         * dcache.h: Sort headers.
6565         * dcache.c: Sort headers.
6566         * darwin-nat.h: Sort headers.
6567         * darwin-nat.c: Sort headers.
6568         * darwin-nat-info.c: Sort headers.
6569         * d-valprint.c: Sort headers.
6570         * d-namespace.c: Sort headers.
6571         * d-lang.c: Sort headers.
6572         * ctf.c: Sort headers.
6573         * csky-tdep.c: Sort headers.
6574         * csky-linux-tdep.c: Sort headers.
6575         * cris-tdep.c: Sort headers.
6576         * cris-linux-tdep.c: Sort headers.
6577         * cp-valprint.c: Sort headers.
6578         * cp-support.c: Sort headers.
6579         * cp-namespace.c: Sort headers.
6580         * cp-abi.c: Sort headers.
6581         * corelow.c: Sort headers.
6582         * corefile.c: Sort headers.
6583         * continuations.c: Sort headers.
6584         * completer.h: Sort headers.
6585         * completer.c: Sort headers.
6586         * complaints.c: Sort headers.
6587         * coffread.c: Sort headers.
6588         * coff-pe-read.c: Sort headers.
6589         * cli-out.h: Sort headers.
6590         * cli-out.c: Sort headers.
6591         * charset.c: Sort headers.
6592         * c-varobj.c: Sort headers.
6593         * c-valprint.c: Sort headers.
6594         * c-typeprint.c: Sort headers.
6595         * c-lang.c: Sort headers.
6596         * buildsym.c: Sort headers.
6597         * buildsym-legacy.c: Sort headers.
6598         * build-id.h: Sort headers.
6599         * build-id.c: Sort headers.
6600         * btrace.c: Sort headers.
6601         * bsd-uthread.c: Sort headers.
6602         * breakpoint.h: Sort headers.
6603         * breakpoint.c: Sort headers.
6604         * break-catch-throw.c: Sort headers.
6605         * break-catch-syscall.c: Sort headers.
6606         * break-catch-sig.c: Sort headers.
6607         * blockframe.c: Sort headers.
6608         * block.c: Sort headers.
6609         * bfin-tdep.c: Sort headers.
6610         * bfin-linux-tdep.c: Sort headers.
6611         * bfd-target.c: Sort headers.
6612         * bcache.c: Sort headers.
6613         * ax-general.c: Sort headers.
6614         * ax-gdb.h: Sort headers.
6615         * ax-gdb.c: Sort headers.
6616         * avr-tdep.c: Sort headers.
6617         * auxv.c: Sort headers.
6618         * auto-load.c: Sort headers.
6619         * arm-wince-tdep.c: Sort headers.
6620         * arm-tdep.c: Sort headers.
6621         * arm-symbian-tdep.c: Sort headers.
6622         * arm-pikeos-tdep.c: Sort headers.
6623         * arm-obsd-tdep.c: Sort headers.
6624         * arm-nbsd-tdep.c: Sort headers.
6625         * arm-nbsd-nat.c: Sort headers.
6626         * arm-linux-tdep.c: Sort headers.
6627         * arm-linux-nat.c: Sort headers.
6628         * arm-fbsd-tdep.c: Sort headers.
6629         * arm-fbsd-nat.c: Sort headers.
6630         * arm-bsd-tdep.c: Sort headers.
6631         * arch-utils.c: Sort headers.
6632         * arc-tdep.c: Sort headers.
6633         * arc-newlib-tdep.c: Sort headers.
6634         * annotate.h: Sort headers.
6635         * annotate.c: Sort headers.
6636         * amd64-windows-tdep.c: Sort headers.
6637         * amd64-windows-nat.c: Sort headers.
6638         * amd64-tdep.c: Sort headers.
6639         * amd64-sol2-tdep.c: Sort headers.
6640         * amd64-obsd-tdep.c: Sort headers.
6641         * amd64-obsd-nat.c: Sort headers.
6642         * amd64-nbsd-tdep.c: Sort headers.
6643         * amd64-nbsd-nat.c: Sort headers.
6644         * amd64-nat.c: Sort headers.
6645         * amd64-linux-tdep.c: Sort headers.
6646         * amd64-linux-nat.c: Sort headers.
6647         * amd64-fbsd-tdep.c: Sort headers.
6648         * amd64-fbsd-nat.c: Sort headers.
6649         * amd64-dicos-tdep.c: Sort headers.
6650         * amd64-darwin-tdep.c: Sort headers.
6651         * amd64-bsd-nat.c: Sort headers.
6652         * alpha-tdep.c: Sort headers.
6653         * alpha-obsd-tdep.c: Sort headers.
6654         * alpha-nbsd-tdep.c: Sort headers.
6655         * alpha-mdebug-tdep.c: Sort headers.
6656         * alpha-linux-tdep.c: Sort headers.
6657         * alpha-linux-nat.c: Sort headers.
6658         * alpha-bsd-tdep.c: Sort headers.
6659         * alpha-bsd-nat.c: Sort headers.
6660         * aix-thread.c: Sort headers.
6661         * agent.c: Sort headers.
6662         * addrmap.c: Sort headers.
6663         * ada-varobj.c: Sort headers.
6664         * ada-valprint.c: Sort headers.
6665         * ada-typeprint.c: Sort headers.
6666         * ada-tasks.c: Sort headers.
6667         * ada-lang.c: Sort headers.
6668         * aarch64-tdep.c: Sort headers.
6669         * aarch64-ravenscar-thread.c: Sort headers.
6670         * aarch64-newlib-tdep.c: Sort headers.
6671         * aarch64-linux-tdep.c: Sort headers.
6672         * aarch64-linux-nat.c: Sort headers.
6673         * aarch64-fbsd-tdep.c: Sort headers.
6674         * aarch64-fbsd-nat.c: Sort headers.
6675         * aarch32-linux-nat.c: Sort headers.
6676
6677 2019-04-04  Tom Tromey  <tom@tromey.com>
6678
6679         * varobj.c (varobj_create): Update.
6680         * rust-exp.y (struct rust_parser) <update_innermost_block,
6681         lookup_symbol>: New methods.
6682         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6683         Rename.
6684         (rust_parser::rust_lookup_type)
6685         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6686         * printcmd.c (display_command, do_one_display): Update.
6687         * parser-defs.h (struct parser_state) <parser_state>: Add
6688         "tracker" parameter.
6689         (block_tracker): New member.
6690         (class innermost_block_tracker) <innermost_block_tracker>: Add
6691         "types" parameter.
6692         <reset>: Remove method.
6693         (innermost_block): Don't declare.
6694         (null_post_parser): Update.
6695         * parse.c (innermost_block): Remove global.
6696         (write_dollar_variable): Update.
6697         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6698         Remove "tracker_types" parameter.
6699         (parse_expression): Add "tracker" parameter.
6700         (parse_expression_for_completion): Update.
6701         (null_post_parser): Add "tracker" parameter.
6702         * p-exp.y: Update rules.
6703         * m2-exp.y: Update rules.
6704         * language.h (struct language_defn) <la_post_parser>: Add
6705         "tracker" parameter.
6706         * go-exp.y: Update rules.
6707         * f-exp.y: Update rules.
6708         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6709         parameter.
6710         * d-exp.y: Update rules.
6711         * c-exp.y: Update rules.
6712         * breakpoint.c (set_breakpoint_condition): Create an
6713         innermost_block_tracker.
6714         (watch_command_1): Likewise.
6715         * ada-lang.c (resolve): Add "tracker" parameter.
6716         (resolve_subexp): Likewise.
6717         * ada-exp.y (write_var_from_sym): Update.
6718
6719 2019-04-04  Tom Tromey  <tom@tromey.com>
6720
6721         * type-stack.h: New file.
6722         * type-stack.c: New file.
6723         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6724         type-stack.h.
6725         (insert_into_type_stack, insert_type, push_type, push_type_int)
6726         (insert_type_address_space, pop_type, pop_type_int)
6727         (pop_typelist, pop_type_stack, append_type_stack)
6728         (push_type_stack, get_type_stack, push_typelist)
6729         (follow_type_instance_flags, follow_types): Don't declare.
6730         * parse.c (type_stack): Remove global.
6731         (parse_exp_in_context): Update.
6732         (insert_into_type_stack, insert_type, push_type, push_type_int)
6733         (insert_type_address_space, pop_type, pop_type_int)
6734         (pop_typelist, pop_type_stack, append_type_stack)
6735         (push_type_stack, get_type_stack, push_typelist)
6736         (follow_type_instance_flags, follow_types): Remove (moved to
6737         type-stack.c).
6738         * f-exp.y (type_stack): New global.
6739         Update rules.
6740         (push_kind_type, f_parse): Update.
6741         * d-exp.y (type_stack): New global.
6742         Update rules.
6743         (d_parse): Update.
6744         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6745         Update rules.
6746         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6747         (HFILES_NO_SRCDIR): Add type-stack.h.
6748
6749 2019-04-04  Tom Tromey  <tom@tromey.com>
6750
6751         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6752         (rust_parser::convert_ast_to_expression, rust_parse)
6753         (rust_lex_test_completion, rust_lex_tests): Update.
6754         * parser-defs.h (struct expr_completion_state): New.
6755         (struct parser_state) <parser_state>: Add completion parameter.
6756         <mark_struct_expression, mark_completion_tag>: New methods.
6757         <parse_completion, m_completion_state>: New members.
6758         (prefixify_expression, null_post_parser): Update.
6759         (mark_struct_expression, mark_completion_tag): Don't declare.
6760         * parse.c (parse_completion, expout_last_struct)
6761         (expout_tag_completion_type, expout_completion_name): Remove
6762         globals.
6763         (parser_state::mark_struct_expression)
6764         (parser_state::mark_completion_tag): Now methods.
6765         (prefixify_expression): Add last_struct parameter.
6766         (prefixify_subexp): Likewise.
6767         (parse_exp_1): Update.
6768         (parse_exp_in_context): Add cstate parameter.  Update.
6769         (parse_expression_for_completion): Create an
6770         expr_completion_state.
6771         (null_post_parser): Add "completion" parameter.
6772         * p-exp.y: Update rules.
6773         (yylex): Update.
6774         * language.h (struct language_defn) <la_post_parser>: Add
6775         "completing" parameter.
6776         * go-exp.y: Update rules.
6777         (lex_one_token): Update.
6778         * expression.h (parse_completion): Don't declare.
6779         * d-exp.y: Update rules.
6780         (lex_one_token): Update rules.
6781         * c-exp.y: Update rules.
6782         (lex_one_token): Update.
6783         * ada-lang.c (resolve): Add "parse_completion" parameter.
6784         (resolve_subexp): Likewise.
6785         (ada_resolve_function): Likewise.
6786
6787 2019-04-04  Tom Tromey  <tom@tromey.com>
6788
6789         * parser-defs.h (struct parser_state) <start_arglist,
6790         end_arglist>: New methods.
6791         <arglist_len, m_funcall_chain>: New members.
6792         (arglist_len, start_arglist, end_arglist): Don't declare.
6793         * parse.c (arglist_len, funcall_chain): Remove global.
6794         (start_arglist, end_arglist): Remove functions.
6795         (parse_exp_in_context): Update.
6796         * p-exp.y: Update rules.
6797         * m2-exp.y: Update rules.
6798         * go-exp.y: Update rules.
6799         * f-exp.y: Update rules.
6800         * d-exp.y: Update rules.
6801         * c-exp.y: Update rules.
6802
6803 2019-04-04  Tom Tromey  <tom@tromey.com>
6804
6805         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6806         lex_operator, push_back>: New methods.
6807         Update all rules.
6808         (rust_parser::lex_hex, lex_escape): Rename and update.
6809         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6810         (rust_parser::lex_operator): Rename and update.
6811         (rust_parser::lex_number, rustyylex, rustyyerror)
6812         (rust_lex_test_init, rust_lex_test_sequence)
6813         (rust_lex_test_push_back, rust_lex_tests): Update.
6814         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6815         parameter.
6816         <lexptr, prev_lexptr>: New members.
6817         (lexptr, prev_lexptr): Don't declare.
6818         * parse.c (lexptr, prev_lexptr): Remove globals.
6819         (parse_exp_in_context): Update.
6820         * p-exp.y (yylex, yyerror): Update.
6821         * m2-exp.y (parse_number, yylex, yyerror): Update.
6822         * go-exp.y (lex_one_token, yyerror): Update.
6823         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6824         * d-exp.y (lex_one_token, yyerror): Update.
6825         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6826         (lex_one_token, yyerror): Update.
6827         * ada-lex.l (YY_INPUT): Update.
6828         (rewind_to_char): Update.
6829         * ada-exp.y (yyerror): Update.
6830
6831 2019-04-04  Tom Tromey  <tom@tromey.com>
6832
6833         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6834         * parser-defs.h (struct parser_state) <parser_state>: Add new
6835         parameter.
6836         <comma_terminates>: New member.
6837         (comma_terminates): Don't declare global.
6838         * parse.c (comma_terminates): Remove global.
6839         (parse_exp_in_context): Update.
6840         * p-exp.y (yylex): Update.
6841         * m2-exp.y (yylex): Update.
6842         * go-exp.y (lex_one_token): Update.
6843         * f-exp.y (yylex): Update.
6844         * d-exp.y (lex_one_token): Update.
6845         * c-exp.y (lex_one_token): Update.
6846         * ada-lex.l: Update.
6847
6848 2019-04-04  Tom Tromey  <tom@tromey.com>
6849
6850         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6851         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6852         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6853         * parser-defs.h (paren_depth): Don't declare.
6854         * parse.c (paren_depth): Remove global.
6855         (parse_exp_in_context): Update.
6856         * p-exp.y (paren_depth): New global.
6857         (pascal_parse): Initialize it.
6858         * m2-exp.y (paren_depth): New global.
6859         (m2_parse): Initialize it.
6860         * go-exp.y (paren_depth): New global.
6861         (go_parse): Initialize it.
6862         * f-exp.y (paren_depth): New global.
6863         (f_parse): Initialize it.
6864         * d-exp.y (paren_depth): New global.
6865         (d_parse): Initialize it.
6866         * c-exp.y (paren_depth): New global.
6867         (c_parse): Initialize it.
6868         * ada-lex.l (paren_depth): New global.
6869         (lexer_init): Initialize it.
6870
6871 2019-04-04  Tom Tromey  <tom@tromey.com>
6872
6873         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6874         (rust_parser::convert_ast_to_type)
6875         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6876         * parser-defs.h (struct parser_state) <parser_state>: Add
6877         parameters.  Initialize new members.
6878         <expression_context_block, expression_context_pc>: New members.
6879         * parse.c (expression_context_block, expression_context_pc):
6880         Remove globals.
6881         (parse_exp_in_context): Update.
6882         * p-exp.y: Update all rules.
6883         (yylex): Update.
6884         * m2-exp.y: Update all rules.
6885         (yylex): Update.
6886         * go-exp.y (yylex): Update.
6887         * f-exp.y (yylex): Update.
6888         * d-exp.y: Update all rules.
6889         (yylex): Update.
6890         * c-exp.y: Update all rules.
6891         (lex_one_token, classify_name, yylex, c_parse): Update.
6892         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6893
6894 2019-04-04  Tom Tromey  <tom@tromey.com>
6895
6896         * gdbarch.h, gdbarch.c: Rebuild.
6897         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6898         * stap-probe.h:
6899         (struct stap_parse_info): Replace "parser_state" with
6900         "expr_builder".
6901         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6902         (parser_state): New class.
6903         * parse.c (expr_builder): Rename.
6904         (expr_builder::release): Rename.
6905         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6906         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6907         (write_exp_elt_longcst, write_exp_elt_floatcst)
6908         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6909         (write_exp_string_vector, write_exp_bitstring)
6910         (write_exp_msymbol, mark_struct_expression)
6911         (write_dollar_variable)
6912         (insert_type_address_space, increase_expout_size): Replace
6913         "parser_state" with "expr_builder".
6914         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6915         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6916         "parser_state" with "expr_builder".
6917
6918 2019-04-04  Tom Tromey  <tom@tromey.com>
6919
6920         * rust-exp.y: Replace "parse_language" with method call.
6921         * p-exp.y:
6922         (yylex): Replace "parse_language" with method call.
6923         * m2-exp.y:
6924         (yylex): Replace "parse_language" with method call.
6925         * go-exp.y (classify_name): Replace "parse_language" with method
6926         call.
6927         * f-exp.y (yylex): Replace "parse_language" with method call.
6928         * d-exp.y (lex_one_token): Replace "parse_language" with method
6929         call.
6930         * c-exp.y:
6931         (lex_one_token, classify_name, yylex): Replace "parse_language"
6932         with method call.
6933         * ada-exp.y (find_primitive_type, type_char)
6934         (type_system_address): Replace "parse_language" with method call.
6935
6936 2019-04-04  Tom Tromey  <tom@tromey.com>
6937
6938         * rust-exp.y: Replace "parse_gdbarch" with method call.
6939         * parse.c (write_dollar_variable, insert_type_address_space):
6940         Replace "parse_gdbarch" with method call.
6941         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6942         call.
6943         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6944         call.
6945         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6946         "parse_gdbarch" with method call.
6947         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6948         with method call.
6949         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6950         "parse_gdbarch" with method call.
6951         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6952         "parse_gdbarch" with method call.
6953         * c-exp.y (parse_type, parse_number, classify_name): Replace
6954         "parse_gdbarch" with method call.
6955         * ada-lex.l: Replace "parse_gdbarch" with method call.
6956         * ada-exp.y (parse_type, find_primitive_type, type_char)
6957         (type_system_address): Replace "parse_gdbarch" with method call.
6958
6959 2019-04-04  Tom Tromey  <tom@tromey.com>
6960
6961         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6962         * stap-probe.c (stap_parse_argument): Update.
6963         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6964         initial_size parameter.
6965         * rust-exp.y (rust_lex_tests): Update.
6966         * parse.c (parser_state): Update.
6967         (parse_exp_in_context): Update.
6968         * parser-defs.h (struct parser_state) <parser_state>: Remove
6969         "initial_size" parameter.
6970
6971 2019-04-04  Tom Tromey  <tom@tromey.com>
6972
6973         * parser-defs.h (increase_expout_size): Don't declare.
6974         * parse.c (increase_expout_size): Now static.
6975
6976 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6977
6978         * gnu-nat.c (gnu_nat_target::wait): Fix
6979         target_waitstatus_to_string call.
6980
6981 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6982
6983         * eval.c (evaluate_subexp_standard): Handle internal functions
6984         during Fortran function call handling.
6985
6986 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6987
6988         * NEWS: Mention new internal functions.
6989         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6990         (read_base_type): Use dwarf2_init_complex_target_type.
6991         * value.c (creal_internal_fn): New function.
6992         (cimag_internal_fn): New function.
6993         (_initialize_values): Register new internal functions.
6994
6995 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6996
6997         * infrun.c (stop_all_threads): If debug_infrun, always
6998         trace the wait status after wait_one, using
6999         target_waitstatus_to_string and target_pid_to_str.
7000         (handle_inferior_event): Replace various trace of
7001         wait status kind by a single trace.
7002         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7003         wait status kind image by target_waitstatus_to_string.
7004         * target/waitstatus.c (target_waitstatus_to_string): Fix
7005         obsolete comment.
7006
7007 2019-04-01  Tom Tromey  <tromey@adacore.com>
7008
7009         PR symtab/23331:
7010         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7011
7012 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7013             Pedro Alves  <palves@redhat.com>
7014
7015         * top.c (quit_force): Call 'finalize_values'.
7016         * value.c (finalize_values): New function.
7017         * value.h (finalize_values): Declare.
7018
7019 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7020
7021         * NEWS: Announce $_gdb_major and $_gdb_minor.
7022
7023         * top.c (init_gdb_version_vars): New function.
7024         (gdb_init): Call init_gdb_version_vars.
7025
7026 2019-03-29  Tom Tromey  <tromey@adacore.com>
7027
7028         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7029         help text.  Remove dead code.
7030
7031 2019-03-29  Keith Seitz  <keiths@redhat.com>
7032
7033         From Siddhesh Poyarekar:
7034         * f-lang.h (f77_get_upperbound): Return LONGEST.
7035         (f77_get_lowerbound): Likewise.
7036         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7037         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7038         print them.
7039         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7040         plongest to format print it.
7041         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7042         (f77_get_upperbound): Likewise.
7043         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7044         LOWER_BOUND to LONGEST.
7045         (f77_create_arrayprint_offset_tbl): Likewise.
7046
7047 2019-03-29  Keith Seitz  <keiths@redhat.com>
7048
7049         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7050         %s/pulongest for TYPE_LENGTH instead of %d in format
7051         strings.
7052         * ada-typerint.c (ada_print_type): Likewise.
7053         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7054         * compile/compile-c-support.c (generate_register_struct): Likewise.
7055         * gdbtypes.c (recursive_dump_type): Likewise.
7056         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7057         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7058         instead of %d in format strings.
7059         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7060         to std::min to ULONGEST.
7061         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7062         instead of %d in format strings.
7063         * tracepoint.c (info_scope_command): Likewise.
7064         * typeprint.c (print_offset_data::update)
7065         (print_offset_data::finish): Likewise.
7066         * xtensa-tdep.c (xtensa_store_return_value)
7067         (xtensa_push_dummy_call): Likewise.
7068
7069 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7070
7071         * windows-nat.c (display_selector): Fixed format specifications
7072         for 64-bit Cygwin.
7073
7074 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7075
7076         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7077
7078 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7079
7080         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7081         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7082         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7083         (nios2_linux_init_abi): Install it.
7084
7085 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7086
7087         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7088
7089 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7090
7091         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7092
7093 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7094             Tom Tromey  <tromey@adacore.com>
7095
7096         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7097
7098 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7099
7100         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7101         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7102         method to compute the bounds of range types. Also print "[evaluated]"
7103         if the bounds' values come from a dynamic evaluation.
7104
7105 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7108         whitespace when pretty printing is on.
7109
7110 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7111
7112         * ppc-linux-nat.c: Add include.
7113
7114 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7115
7116         * NEWS: Mention AArch64 Pointer Authentication.
7117
7118 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7119
7120         * arm-linux-nat.c: Add include.
7121
7122 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7123
7124         * source-cache.c (source_cache::get_source_lines): Re-read
7125         fullname after calling open_source_file.
7126
7127 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7128
7129         * NEWS: Mention TLS support for FreeBSD.
7130
7131 2019-03-25  Tom Tromey  <tromey@adacore.com>
7132
7133         * minsyms.c (BUNCH_SIZE): Update comment.
7134         (~minimal_symbol_reader): Remove old comment.
7135         (compact_minimal_symbols): Update comment.
7136         (minimal_symbol_reader::install): Remove old comment.  Update
7137         other comments.
7138
7139 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7140
7141         * s390-linux-nat.c: Add include.
7142
7143 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7144
7145         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7146         Call linux_get_hwcap.
7147         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7148         Likewise.
7149         (aarch64_linux_get_hwcap): Remove function.
7150         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7151         declaration.
7152         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7153         linux_get_hwcap.
7154         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7155         * linux-tdep.c (linux_get_hwcap): Add function.
7156         (linux_get_hwcap2): Likewise.
7157         * linux-tdep.h (linux_get_hwcap): Add declaration.
7158         (linux_get_hwcap2): Likewise.
7159         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7160         (ppc_linux_get_hwcap2): Likewise.
7161         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7162         linux_get_hwcap.
7163         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7164         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7165         (ppc_linux_nat_target::read_description): Likewise.
7166         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7167         * s390-linux-nat.c: Likewise.
7168         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7169
7170 2019-03-24  Tom Tromey  <tom@tromey.com>
7171
7172         * ada-lang.c (standard_lookup): Simplify initialization.
7173         (ada_lookup_symbol_nonlocal): Simplify return.
7174         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7175         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7176         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7177         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7178         initialization.
7179         * solib.c (solib_global_lookup): Simplify.
7180         * symtab.c (null_block_symbol): Remove.
7181         (symbol_cache_lookup): Simplify returns.
7182         (lookup_language_this): Simplify returns.
7183         (lookup_symbol_aux): Simplify return.
7184         (lookup_local_symbol): Simplify returns.
7185         (lookup_global_symbol_from_objfile): Simplify return.
7186         (lookup_symbol_in_objfile_symtabs)
7187         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7188         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7189         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7190         * cp-namespace.c (cp_lookup_bare_symbol)
7191         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7192         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7193         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7194         (cp_lookup_symbol_via_imports): Simplify initialization.
7195         (find_symbol_in_baseclass): Likewise.
7196         * symtab.h (null_block_symbol): Remove.
7197         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7198         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7199         (d_lookup_symbol_module): Likewise.
7200         (find_symbol_in_baseclass): Simplify initialization.
7201
7202 2019-03-24  Tom Tromey  <tom@tromey.com>
7203
7204         * expression.h: Don't include symtab.h.
7205         (struct block): Forward declare.
7206
7207 2019-03-24  Tom Tromey  <tom@tromey.com>
7208
7209         * c-exp.y (typebase): Remove casts.
7210         * gdbtypes.c (lookup_unsigned_typename, )
7211         (lookup_signed_typename): Remove cast.
7212         * eval.c (parse_to_comma_and_eval): Remove cast.
7213         * parse.c (write_dollar_variable): Remove cast.
7214         * block.h (struct block) <superblock>: Now const.
7215         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7216         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7217         (map_block): Make "block" const.
7218         * symfile.h (struct quick_symbol_functions)
7219         <map_matching_symbols>: Constify block argument to "callback".
7220         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7221         const.
7222         (find_pc_sect_compunit_symtab): Make "b" const.
7223         (find_symbol_at_address): Likewise.
7224         (search_symbols): Likewise.
7225         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7226         (dw2_debug_names_lookup_symbol): Likewise.
7227         (dw2_map_matching_symbols): Update.
7228         * p-valprint.c (pascal_val_print): Remove "block".
7229         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7230         (aux_add_nonlocal_symbols): Make "block" const.
7231         (resolve_subexp): Remove cast.
7232         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7233         const.
7234         (iterate_over_file_blocks): Likewise.
7235         * f-exp.y (%union) <bval>: Remove.
7236         * coffread.c (patch_opaque_types): Make "b" const.
7237         * spu-tdep.c (spu_catch_start): Make "block" const.
7238         * c-valprint.c (print_unpacked_pointer): Remove "block".
7239         * symmisc.c (dump_symtab_1): Make "b" const.
7240         (block_depth): Make "block" const.
7241         * d-exp.y (%union) <bval>: Remove.
7242         * cp-support.h (cp_lookup_rtti_type): Update.
7243         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7244         * psymtab.c (psym_lookup_symbol): Make "block" const.
7245         (maintenance_check_psymtabs): Make "b" const.
7246         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7247         (enumerate_locals, enumerate_args): Update.
7248         * python/py-symtab.c (stpy_global_block): Make "block" const.
7249         (stpy_static_block): Likewise.
7250         * inline-frame.c (block_starting_point_at): Make "new_block"
7251         const.
7252         * block.c (find_block_in_blockvector): Make return type const.
7253         (blockvector_for_pc_sect): Make "b" const.
7254         (find_block_in_blockvector): Make "b" const.
7255
7256 2019-03-23  Tom Tromey  <tom@tromey.com>
7257
7258         * varobj.c (varobj_create): Update.
7259         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7260         * printcmd.c (display_command, do_one_display): Don't reset
7261         innermost_block.
7262         * parser-defs.h (enum innermost_block_tracker_type): Move to
7263         expression.h.
7264         (innermost_block): Update comment.
7265         * parse.c (parse_exp_1): Add tracker_types parameter.
7266         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7267         tracker_types parameter.  Reset innermost_block.
7268         (parse_exp_in_context): Remove.
7269         (parse_expression_for_completion): Update.
7270         * objfiles.c (~objfile): Don't reset expression_context_block or
7271         innermost_block.
7272         * expression.h (enum innermost_block_tracker_type): Move from
7273         parser-defs.h.
7274         (parse_exp_1): Add tracker_types parameter.
7275         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7276         reset innermost_block.
7277
7278 2019-03-23  Tom Tromey  <tom@tromey.com>
7279
7280         * objfiles.h: Include bcache.h.
7281
7282 2019-03-23  Tom Tromey  <tom@tromey.com>
7283
7284         * linespec.c (get_current_search_block): Use
7285         scoped_restore_current_language.
7286         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7287
7288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7289             Jiong Wang  <jiong.wang@arm.com>
7290
7291         * aarch64-linux-tdep.c
7292         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7293         section.
7294         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7295
7296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7297             Jiong Wang  <jiong.wang@arm.com>
7298
7299         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7300         instructions.
7301         (aarch64_analyze_prologue_test): Add PACIASP test.
7302         (aarch64_prologue_prev_register): Unmask PC value.
7303
7304 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7305             Jiong Wang  <jiong.wang@arm.com>
7306
7307         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7308         (aarch64_dwarf2_prev_register): Unmask PC value.
7309         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7310         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7311         DW_CFA_AARCH64_negate_ra_state.
7312         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7313
7314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7315             Jiong Wang  <jiong.wang@arm.com>
7316
7317         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7318         registers.
7319         (aarch64_pseudo_register_name): Likewise.
7320         (aarch64_pseudo_register_type): Likewise.
7321         (aarch64_pseudo_register_reggroup_p): Likewise.
7322         (aarch64_gdbarch_init): Add pauth registers.
7323         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7324         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7325         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7326         (struct gdbarch_tdep): Add regnum for ra_state.
7327
7328 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7329             Jiong Wang  <jiong.wang@arm.com>
7330
7331         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7332
7333 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7334             Jiong Wang  <jiong.wang@arm.com>
7335
7336         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7337         function.
7338         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7339         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7340         (aarch64_gdbarch_init): Add puth registers.
7341         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7342         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7343         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7344
7345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7346             Jiong Wang  <jiong.wang@arm.com>
7347
7348         * aarch64-linux-nat.c
7349         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7350         * aarch64-linux-tdep.c
7351         (aarch64_linux_core_read_description): Likewise.
7352         (aarch64_linux_get_hwcap): New function.
7353         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7354         (aarch64_linux_get_hwcap): New declaration.
7355
7356 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7357             Jiong Wang  <jiong.wang@arm.com>
7358
7359         * aarch64-linux-nat.c
7360         (aarch64_linux_nat_target::read_description): Add pauth param.
7361         * aarch64-linux-tdep.c
7362         (aarch64_linux_core_read_description): Likewise.
7363         * aarch64-tdep.c (struct target_desc): Add in pauth.
7364         (aarch64_read_description): Add pauth param.
7365         (aarch64_gdbarch_init): Likewise.
7366         * aarch64-tdep.h (aarch64_read_description): Likewise.
7367         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7368         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7369         * features/Makefile: Add new files.
7370         * features/aarch64-pauth.c: New file.
7371         * features/aarch64-pauth.xml: New file.
7372
7373 2019-03-20  Tom Tromey  <tromey@adacore.com>
7374
7375         * infrun.c (handle_inferior_event): Rename from
7376         handle_inferior_event_1.  Create a scoped_value_mark.
7377         (handle_inferior_event): Remove.
7378
7379 2019-03-19  Tom Tromey  <tromey@adacore.com>
7380
7381         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7382         * infrun.h (print_stop_event): Add "displays" parameter.
7383         * infrun.c (print_stop_event): Add "displays" parameter.
7384
7385 2019-03-19  Pedro Alves  <palves@redhat.com>
7386
7387         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7388         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7389         to -1.  Fix TABs vs spaces.
7390         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7391         * tui/tui-out.h (tui_ui_out) Add intro comments.
7392         <m_line, m_start_of_line>: In-class initialize, and add describing
7393         comment.
7394
7395 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7396
7397         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7398         variable names.
7399         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7400
7401 2019-03-18  Pedro Alves  <palves@redhat.com>
7402             Eli Zaretskii <eliz@gnu.org>
7403
7404         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7405         m_line and m_start_of_line.
7406
7407 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7408
7409         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7410         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7411         it returns a newline.  This fixes a regression in TU mode, whereby
7412         the next line is output on the same screen line as the user input.
7413
7414 2019-03-18  Tom Tromey  <tromey@adacore.com>
7415
7416         * minsyms.c (minimal_symbol_reader::install): Remove call to
7417         obstack_blank.
7418
7419 2019-03-18  Pedro Alves  <palves@redhat.com>
7420
7421         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7422         New globals.
7423         (apply_style): New, factored out from ...
7424         (apply_ansi_escape): ... this.  Handle reverse video mode.
7425         (tui_set_reverse_mode): New function.
7426         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7427         * tui/tui-winsource.c (tui_show_source_line): Use
7428         tui_set_reverse_mode instead of setting A_STANDOUT.
7429         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7430         New setter methods.
7431
7432 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7433
7434         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7435         Handle tabs.
7436
7437 2019-03-18  Tom Tromey  <tromey@adacore.com>
7438
7439         * ada-lang.c (empty_array): Add "high" parameter.
7440         (ada_evaluate_subexp): Update.
7441
7442 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7443
7444         * unittests/string_view-selftests.c: Define
7445         _initialize_string_view_selftests unconditionally.
7446
7447 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7448
7449         PR gdb/24350
7450         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7451
7452 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7453
7454         PR gdb/24351
7455         * windows-nat.c (display_selector): Fix format specifiers.
7456
7457 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7458
7459         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7460         tui_refill_source_window instead of tui_refresh_win, to update the
7461         current execution line.  This fixes redisplay of the current line
7462         when stepping through the code with "next" or "step".
7463
7464 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7465
7466         * source-cache.c (source_cache::get_source_lines): Call
7467         find_source_lines to initialize s->nlines.  This fixes vertical
7468         scrolling of TUI source window when the DOWN arrow is pressed.
7469
7470 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7471
7472         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7473         linux-thread-db.c (_initialize_thread_db): Likewise.
7474
7475 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7476
7477         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7478         wclrtoeol in tui_show_source_line".  This reverts changes made in
7479         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7480
7481 2019-03-15  Tom Tromey  <tom@tromey.com>
7482
7483         * symtab.h (struct minimal_symbol): Derive from
7484         general_symbol_info.
7485         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7486         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7487         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7488         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7489         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7490         (MSYMBOL_SEARCH_NAME): Update.
7491         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7492         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7493         * minsyms.c (minimal_symbol_reader::record_full): Update.
7494
7495 2019-03-15  Tom Tromey  <tom@tromey.com>
7496
7497         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7498
7499 2019-03-15  Tom Tromey  <tom@tromey.com>
7500
7501         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7502         unique_xmalloc_ptr.
7503         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7504         Update.
7505         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7506         (build_minimal_symbol_hash_tables)
7507         (minimal_symbol_reader::install): Update.
7508
7509 2019-03-15  Tom Tromey  <tom@tromey.com>
7510
7511         * symtab.c (create_demangled_names_hash): Update.
7512         (symbol_set_names): Update.
7513         * objfiles.h (struct objfile_per_bfd_storage)
7514         <demangled_names_hash>: Now an htab_up.
7515         * objfiles.c (objfile_per_bfd_storage): Simplify.
7516
7517 2019-03-15  Tom Tromey  <tom@tromey.com>
7518
7519         * objfiles.h (struct objfile_per_bfd_storage): Declare
7520         destructor.
7521         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7522         New.
7523         (get_objfile_bfd_data): Use new.  Don't initialize
7524         language_of_main.
7525         (free_objfile_per_bfd_storage): Remove.
7526         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7527
7528 2019-03-15  Tom Tromey  <tom@tromey.com>
7529
7530         * symfile.c (reread_symbols): Update.
7531         * objfiles.c (objfile::objfile): Update.
7532         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7533         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7534         comment.
7535         (minimal_symbol_reader::install): Update.
7536         (terminate_minimal_symbol_table): Remove.
7537         * jit.c (jit_object_close_impl): Update.
7538
7539 2019-03-15  Tom Tromey  <tom@tromey.com>
7540
7541         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7542         initializations.
7543
7544 2019-03-15  Tom Tromey  <tom@tromey.com>
7545
7546         * objfiles.h (struct objfile_per_bfd_storage)
7547         <demangled_hash_languages>: Now a bitset.
7548         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7549         (lookup_minimal_symbol): Update.
7550
7551 2019-03-15  Tom Tromey  <tom@tromey.com>
7552
7553         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7554         Don't return the symbol.
7555         * coffread.c (record_minimal_symbol): Use record_full.
7556
7557 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7558
7559         The MS-Windows port of ncurses fails to switch to a color pair if
7560         one or both of the colors are the implicit default colors.  This
7561         change records the default colors when TUI is initialized, and
7562         then specifies them explicitly when a color pair uses the default
7563         colors.  This allows color styling in TUI mode on MS-Windows.
7564
7565         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7566         ncurses_norm_attr.
7567         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7568         colors in ncurses_norm_attr.
7569         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7570         "none", replace it with the default color recorded in
7571         ncurses_norm_attr.
7572
7573 2019-03-14  Tom Tromey  <tromey@adacore.com>
7574
7575         * source-cache.h (class source_cache) <get_source_lines>: Return
7576         std::string.
7577         * source-cache.c (source_cache::extract_lines): Handle case where
7578         first_pos==npos.  Return std::string.
7579         (source_cache::get_source_lines): Update.
7580
7581 2019-03-14  Tom Tromey  <tromey@adacore.com>
7582
7583         * NEWS: Add item for "style sources" commands.
7584         * source-cache.c (source_cache::get_source_lines): Check
7585         source_styling.
7586         * cli/cli-style.c (source_styling): New global.
7587         (_initialize_cli_style): Add "style sources" commands.
7588         (show_style_sources): New function.
7589         * cli/cli-style.h (source_styling): Declare.
7590
7591 2019-03-14  Pedro Alves  <palves@redhat.com>
7592             Tom Tromey  <tromey@adacore.com>
7593
7594         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7595         * tui/tui-winsource.c (tui_refill_source_window): New function,
7596         from...
7597         (tui_horizontal_source_scroll): ... here.  Move some logic.
7598         * cli/cli-style.c (set_style_enabled): Notify new observable.
7599         * tui/tui-hooks.c (tui_redisplay_source): New function.
7600         (tui_attach_detach_observers): Attach or detach
7601         tui_redisplay_source.
7602         * observable.h (source_styling_changed): New observable.
7603         * observable.c: Define source_styling_changed observable.
7604
7605 2019-03-13  Tom Tromey  <tromey@adacore.com>
7606
7607         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7608         (i386_gnu_nat_target::store_registers): Update.
7609         * target-debug.h (target_debug_print_std_string): New macro.
7610         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7611         * windows-tdep.c (display_one_tib): Update.
7612         * tui/tui-stack.c (tui_make_status_line): Update.
7613         * top.c (print_inferior_quit_action): Update.
7614         * thread.c (thr_try_catch_cmd): Update.
7615         (add_thread_with_info): Update.
7616         (thread_target_id_str): Update.
7617         (thr_try_catch_cmd): Update.
7618         (thread_command): Update.
7619         (thread_find_command): Update.
7620         * record-btrace.c (record_btrace_target::info_record)
7621         (record_btrace_resume_thread, record_btrace_target::resume)
7622         (record_btrace_cancel_resume, record_btrace_step_thread)
7623         (record_btrace_target::wait, record_btrace_target::wait)
7624         (record_btrace_target::wait, record_btrace_target::stop): Update.
7625         * progspace.c (print_program_space): Update.
7626         * process-stratum-target.c
7627         (process_stratum_target::thread_address_space): Update.
7628         * linux-fork.c (linux_fork_mourn_inferior)
7629         (detach_checkpoint_command, info_checkpoints_command)
7630         (linux_fork_context): Update.
7631         (linux_fork_detach): Update.
7632         (class scoped_switch_fork_info): Update.
7633         (delete_checkpoint_command): Update.
7634         * infrun.c (follow_fork_inferior): Update.
7635         (follow_fork_inferior): Update.
7636         (proceed_after_vfork_done): Update.
7637         (handle_vfork_child_exec_or_exit): Update.
7638         (follow_exec): Update.
7639         (displaced_step_prepare_throw): Update.
7640         (displaced_step_restore): Update.
7641         (start_step_over): Update.
7642         (resume_1): Update.
7643         (clear_proceed_status_thread): Update.
7644         (proceed): Update.
7645         (print_target_wait_results): Update.
7646         (do_target_wait): Update.
7647         (context_switch): Update.
7648         (stop_all_threads): Update.
7649         (restart_threads): Update.
7650         (finish_step_over): Update.
7651         (handle_signal_stop): Update.
7652         (switch_back_to_stepped_thread): Update.
7653         (keep_going_pass_signal): Update.
7654         (print_exited_reason): Update.
7655         (normal_stop): Update.
7656         * inferior.c (inferior_pid_to_str): Change return type.
7657         (print_selected_inferior): Update.
7658         (add_inferior): Update.
7659         (detach_inferior): Update.
7660         * dummy-frame.c (fprint_dummy_frames): Update.
7661         * dcache.c (dcache_info_1): Update.
7662         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7663         (btrace_fetch, btrace_clear): Update.
7664         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7665         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7666         type.
7667         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7668         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7669         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7670         * gdbarch.c, gdbarch.h: Rebuild.
7671         * gdbarch.sh (core_pid_to_str): Change return type.
7672         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7673         return type.
7674         (windows_nat_target::pid_to_str): Change return type.
7675         (windows_delete_thread): Update.
7676         (windows_nat_target::attach): Update.
7677         (windows_nat_target::files_info): Update.
7678         * target-delegates.c: Rebuild.
7679         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7680         return type.
7681         (sol_thread_target::pid_to_str): Change return type.
7682         * remote.c (class remote_target) <pid_to_str>: Change return
7683         type.
7684         (remote_target::pid_to_str): Change return type.
7685         (extended_remote_target::attach, remote_target::remote_stop_ns)
7686         (remote_target::remote_notif_remove_queued_reply)
7687         (remote_target::push_stop_reply, remote_target::disable_btrace):
7688         Update.
7689         (extended_remote_target::attach): Update.
7690         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7691         type.
7692         (gdbsim_target::pid_to_str): Change return type.
7693         * ravenscar-thread.c (struct ravenscar_thread_target)
7694         <pid_to_str>: Change return type.
7695         (ravenscar_thread_target::pid_to_str): Change return type.
7696         * procfs.c (class procfs_target) <pid_to_str>: Change return
7697         type.
7698         (procfs_target::pid_to_str): Change return type.
7699         (procfs_target::attach): Update.
7700         (procfs_target::detach): Update.
7701         (procfs_target::fetch_registers): Update.
7702         (procfs_target::store_registers): Update.
7703         (procfs_target::wait): Update.
7704         (procfs_target::files_info): Update.
7705         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7706         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7707         return type.
7708         (nto_procfs_target::pid_to_str): Change return type.
7709         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7710         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7711         return type.
7712         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7713         (exit_lwp): Update.
7714         (attach_proc_task_lwp_callback, get_detach_signal)
7715         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7716         (linux_nat_target::resume, wait_lwp, stop_callback)
7717         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7718         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7719         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7720         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7721         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7722         type.
7723         (inf_ptrace_target::attach): Update.
7724         (inf_ptrace_target::files_info): Update.
7725         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7726         type.
7727         (go32_nat_target::pid_to_str): Change return type.
7728         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7729         (gnu_nat_target::wait): Update.
7730         (gnu_nat_target::wait): Update.
7731         (gnu_nat_target::resume): Update.
7732         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7733         (fbsd_nat_target::wait): Update.
7734         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7735         type.
7736         (darwin_nat_target::attach): Update.
7737         * corelow.c (class core_target) <pid_to_str>: Change return type.
7738         (core_target::pid_to_str): Change return type.
7739         * target.c (normal_pid_to_str): Change return type.
7740         (default_pid_to_str): Likewise.
7741         (target_pid_to_str): Change return type.
7742         (target_translate_tls_address): Update.
7743         (target_announce_detach): Update.
7744         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7745         return type.
7746         (bsd_uthread_target::pid_to_str): Change return type.
7747         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7748         type.
7749         (bsd_kvm_target::pid_to_str): Change return type.
7750         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7751         return type.
7752         (aix_thread_target::pid_to_str): Change return type.
7753         * target.h (struct target_ops) <pid_to_str>: Change return type.
7754         (target_pid_to_str, normal_pid_to_str): Likewise.
7755         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7756         type.
7757         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7758         type.
7759         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7760         return type.
7761         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7762         type.
7763         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7764         type.
7765         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7766         return type.
7767
7768 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7769
7770         * NEWS: Mention that the new default MI version is 3.  Mention
7771         changes to the output of commands and events that deal with
7772         multi-location breakpoints.
7773         * breakpoint.c: Include "mi/mi-out.h".
7774         (print_one_breakpoint): Change output syntax if using MI version
7775         >= 3.
7776         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7777         New.
7778         (mi_multi_location_breakpoint_output_fixed): New.
7779         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7780         (mi_cmd_fix_multi_location_breakpoint_output): New.
7781         (mi_multi_location_breakpoint_output_fixed): New.
7782         * mi/mi-cmds.c (mi_cmds): Register command
7783         -fix-multi-location-breakpoint-output.
7784         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7785         interpreter "mi".
7786
7787 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7788
7789         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7790         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7791         instantiate mi_ui_out based on interpreter name.
7792         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7793         * mi/mi-main.c (mi_load_progress): Likewise.
7794
7795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7796
7797         * NEWS: Combine separate "New targets" sections for 8.3.
7798
7799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7800
7801         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7802         (ppcfbsd_init_abi): Install gdbarch
7803         "fetch_tls_load_module_address" and "get_thread_local_address"
7804         methods.
7805
7806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7807
7808         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7809         (riscv_fbsd_init_abi): Install gdbarch
7810         "fetch_tls_load_module_address" and "get_thread_local_address"
7811         methods.
7812
7813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7814
7815         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7816         (i386fbsd_init_abi): Install gdbarch
7817         "fetch_tls_load_module_address" and "get_thread_local_address"
7818         methods.
7819
7820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7821
7822         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7823         (amd64fbsd_init_abi): Install gdbarch
7824         "fetch_tls_load_module_address" and "get_thread_local_address"
7825         methods.
7826
7827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7828
7829         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7830         (struct fbsd_pspace_data): New type.
7831         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7832         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7833         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7834         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7835         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7836
7837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7838
7839         * gdbtypes.c (lookup_struct_elt): New function.
7840         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7841         * gdbtypes.h (struct struct_elt): New type.
7842         (lookup_struct_elt): New prototype.
7843
7844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7845
7846         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7847         remove disabled code block.
7848
7849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7850
7851         * gdbarch.sh (get_thread_local_address): New method.
7852         * gdbarch.h, gdbarch.c: Regenerate.
7853         * target.c (target_translate_tls_address): Use
7854         gdbarch_get_thread_local_address if present instead of
7855         target::get_thread_local_address.
7856
7857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7858
7859         * target.h (target::get_thread_local_address): Update comment.
7860
7861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7862
7863         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7864         objfile->separate_debug_objfile_backlink if not NULL.
7865
7866 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7867
7868         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7869         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7870         (amd64bsd_store_inferior_registers): Likewise.
7871         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7872         Enable segment base registers.
7873         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7874         PT_GETFSBASE and PT_GETGSBASE.
7875         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7876         PT_SETGSBASE.
7877         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7878         segment base registers.
7879         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7880
7881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7882
7883         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7884         Update calls to i386_target_description to add 'segments'
7885         parameter.
7886         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7887         add segment base registers.
7888         * arch/i386.c (i386_create_target_description): Add 'segments'
7889         parameter to enable segment base registers.
7890         * arch/i386.h (i386_create_target_description): Likewise.
7891         * features/i386/32bit-segments.xml: New file.
7892         * features/i386/32bit-segments.c: Generate.
7893         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7894         call to i386_target_description to add 'segments' parameter.
7895         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7896         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7897         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7898         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7899         if feature is present.
7900         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7901         Add 'segments' parameter to call to i386_target_description.
7902         (i386_target_description): Add 'segments' parameter to enable
7903         segment base registers.
7904         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7905         to call to i386_target_description.
7906         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7907         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7908         Define I386_NUM_REGS.
7909         (i386_target_description): Add 'segments' parameter to enable
7910         segment base registers.
7911
7912 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7913
7914         PR/24325
7915         * source-cache.c: #undef open and close, to avoid unresolved
7916         externals during linking.
7917
7918 2019-03-12  Tom Tromey  <tromey@adacore.com>
7919
7920         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7921         const.  Add initializers.
7922         (_initialize_remote): Don't initialize ptid globals.
7923
7924 2019-03-12  Pedro Alves  <palves@redhat.com>
7925
7926         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7927
7928 2019-03-12  Pedro Alves  <palves@redhat.com>
7929
7930         * cp-name-parser.y (main): Remove unused 'len' variable.
7931
7932 2019-03-12  Tom Tromey  <tromey@adacore.com>
7933
7934         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7935         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7936
7937 2019-03-12  Tom Tromey  <tromey@adacore.com>
7938
7939         * linux-nat.c (iterate_over_lwps): Update.
7940         (stop_callback): Remove parameter.
7941         (stop_wait_callback, detach_callback, resume_set_callback)
7942         (select_singlestep_lwp_callback, set_ignore_sigint)
7943         (status_callback, resumed_callback, resume_clear_callback)
7944         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7945         data parameter.
7946         (linux_nat_target::detach, linux_nat_target::resume)
7947         (linux_stop_and_wait_all_lwps, select_event_lwp)
7948         (linux_nat_filter_event, linux_nat_wait_1)
7949         (linux_nat_target::kill, linux_nat_target::stop)
7950         (linux_nat_target::stop): Update.
7951         (linux_nat_resume_callback): Change type.
7952         (resume_stopped_resumed_lwps, count_events_callback)
7953         (select_event_lwp_callback): Likewise.
7954         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7955         * arm-linux-nat.c (struct update_registers_data): Remove.
7956         (update_registers_callback): Change type.
7957         (arm_linux_insert_hw_breakpoint1): Update.
7958         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7959         parameter.
7960         (x86_linux_dr_set_addr): Update.
7961         (x86_linux_dr_set_control): Update.
7962         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7963         (iterate_over_lwps): Use gdb::function_view.
7964         * nat/aarch64-linux-hw-point.c (struct
7965         aarch64_dr_update_callback_param): Remove.
7966         (debug_reg_change_callback): Change type.
7967         (aarch64_notify_debug_reg_change): Update.
7968         * s390-linux-nat.c (s390_refresh_per_info): Update.
7969
7970 2019-03-11  Tom Tromey  <tromey@adacore.com>
7971
7972         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7973         redundant assignment to "this_cu".
7974
7975 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7976
7977         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7978
7979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7980
7981         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7982         from...
7983         (rank_one_type): ... this.
7984
7985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7986
7987         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7988         from...
7989         (rank_one_type): ... this.
7990
7991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7992
7993         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7994         from...
7995         (rank_one_type): ... this.
7996
7997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7998
7999         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8000         from...
8001         (rank_one_type): ... this.
8002
8003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8004
8005         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8006         from...
8007         (rank_one_type): ... this.
8008
8009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8010
8011         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8012         from...
8013         (rank_one_type): ... this.
8014
8015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8016
8017         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8018         from...
8019         (rank_one_type): ... this.
8020
8021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8022
8023         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8024         from...
8025         (rank_one_type): ... this.
8026
8027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8028
8029         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8030         from...
8031         (rank_one_type): ... this.
8032
8033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8034
8035         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8036         from...
8037         (rank_one_type): ... this.
8038
8039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8040
8041         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8042         from...
8043         (rank_one_type): ... this.
8044
8045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8046
8047         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8048         from...
8049         (rank_one_type): ... this.
8050
8051 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8052
8053         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8054         inferior-events' shows the example events.
8055
8056 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8057
8058         Support styling on native MS-Windows console
8059
8060         PR/24315
8061         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8062         on MS-Windows if $TERM is not defined.
8063
8064         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8065
8066         * posix-hdep.c (gdb_console_fputs):
8067         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8068         functions.
8069         * ui-file.h (gdb_console_fputs): Add prototype.
8070
8071         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8072         back to fputs only if the former returns zero.
8073
8074 2019-03-07  Tom Tromey  <tom@tromey.com>
8075
8076         * symmisc.c (print_symbol_bcache_statistics): Update.
8077         (print_objfile_statistics): Update.
8078         * symfile.c (allocate_symtab): Update.
8079         * stabsread.c: Don't include bcache.h.
8080         * psymtab.h (struct psymbol_bcache): Don't declare.
8081         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8082         (psymbol_bcache_init, psymbol_bcache_free)
8083         (psymbol_bcache_get_bcache): Don't declare.
8084         * psymtab.c (struct psymbol_bcache): Remove.
8085         (psymtab_storage::psymtab_storage): Update.
8086         (psymtab_storage::~psymtab_storage): Update.
8087         (psymbol_bcache_init, psymbol_bcache_free)
8088         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8089         (add_psymbol_to_bcache): Update.
8090         (allocate_psymtab): Update.
8091         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8092         macro_cache>: No longer pointers.
8093         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8094         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8095         * macrotab.c (macro_bcache): Update.
8096         * macroexp.c: Don't include bcache.h.
8097         * gdbtypes.c (check_types_worklist): Update.
8098         (types_deeply_equal): Remove TRY/CATCH.  Update.
8099         * elfread.c (elf_symtab_read): Update.
8100         * dwarf2read.c: Don't include bcache.h.
8101         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8102         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8103         (print_bcache_statistics, bcache_memory_used): Don't declare.
8104         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8105         methods.  Rename all data members.
8106         * bcache.c (struct bcache): Move to bcache.h.
8107         (bcache::expand_hash_table): Rename from expand_hash_table.
8108         (bcache): Remove.
8109         (bcache::insert): Rename from bcache_full.
8110         (bcache::compare): Rename from bcache_compare.
8111         (bcache_xmalloc): Remove.
8112         (bcache::~bcache): Rename from bcache_xfree.
8113         (bcache::print_statistics): Rename from print_bcache_statistics.
8114         (bcache::memory_used): Rename from bcache_memory_used.
8115
8116 2019-03-07  Pedro Alves  <palves@redhat.com>
8117
8118         * infrun.c (normal_stop): Also check for
8119         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8120
8121 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * f-lang.c (value_from_host_double): Moved to...
8124         * value.c (value_from_host_double): ...here.
8125         * value.h (value_from_host_double): Declare.
8126         * guile/scm-math.c (vlscm_convert_typed_number): Use
8127         value_from_host_double.
8128         (vlscm_convert_number): Likewise.
8129         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8130         * python/py-value.c (convert_value_from_python): Likewise.
8131
8132 2019-03-06  Tom Tromey  <tom@tromey.com>
8133
8134         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8135
8136 2019-03-06  Tom Tromey  <tom@tromey.com>
8137
8138         * utils.h (free_current_contents): Don't declare.
8139         * utils.c (free_current_contents): Remove.
8140
8141 2019-03-06  Tom Tromey  <tom@tromey.com>
8142
8143         * top.c (quit_force): Update.
8144         * main.c (captured_command_loop): Update.
8145         * common/new-op.c (operator new): Update.
8146         * common/common-exceptions.c (struct catcher)
8147         <save_cleanup_chain>: Remove member.
8148         (exceptions_state_mc_init): Update.
8149         (exception_try_scope_entry): Return nullptr.
8150         (exception_try_scope_exit, exception_rethrow)
8151         (throw_exception_sjlj, throw_exception_cxx): Update.
8152         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8153         (all_cleanups, do_cleanups, discard_cleanups)
8154         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8155         (restore_cleanups, restore_final_cleanups): Don't declare.
8156         (do_final_cleanups): Remove parameter.
8157         * common/cleanups.c (cleanup_chain, make_cleanup)
8158         (make_cleanup_dtor, all_cleanups, do_cleanups)
8159         (discard_my_cleanups, discard_cleanups)
8160         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8161         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8162         (null_cleanup): Remove.
8163         (do_final_cleanups): Remove parameter.
8164
8165 2019-03-06  Tom Tromey  <tom@tromey.com>
8166
8167         * remote.c (remote_target::remote_parse_stop_reply): Use
8168         unique_xmalloc_ptr.
8169
8170 2019-03-06  Tom Tromey  <tom@tromey.com>
8171
8172         * stabsread.c (struct stabs_field_info): Rename from field_info.
8173         <list, fnlist>: Add initializers.
8174         <obstack>: New member.
8175         (read_member_functions, read_struct_fields, read_baseclasses):
8176         Allocate on obstack.  Don't use cleanups.
8177         (read_one_struct_field, read_member_functions, read_struct_fields)
8178         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8179         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8180         (read_struct_type): Update.
8181
8182 2019-03-06  Tom Tromey  <tom@tromey.com>
8183
8184         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8185         * common/filestuff.h (make_cleanup_close): Don't declare.
8186         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8187         Remove.
8188
8189 2019-03-06  Tom Tromey  <tom@tromey.com>
8190
8191         * solib-aix.c: Use make_scope_exit.
8192
8193 2019-03-06  Tom Tromey  <tom@tromey.com>
8194
8195         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8196         Use make_scope_exit.
8197
8198 2019-03-06  Tom Tromey  <tom@tromey.com>
8199
8200         * solib-svr4.c (disable_probes_interface): Remove parameter.
8201         (svr4_handle_solib_event): Use make_scope_exit.
8202
8203 2019-03-06  Tom Tromey  <tom@tromey.com>
8204
8205         * remote.c (struct stop_reply_deleter): Remove.
8206         (stop_reply_up): Update.
8207         (struct stop_reply): Derive from notif_event.  Don't typedef.
8208         <regcache>: Now a std::vector.
8209         (stop_reply_xfree): Remove.
8210         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8211         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8212         (remote_target::discard_pending_stop_replies): Use delete.
8213         (remote_target::remote_parse_stop_reply): Update.
8214         (remote_target::process_stop_reply): Update.
8215         * remote-notif.h (struct notif_event): Add virtual destructor.
8216         Remove "dtr" member.
8217         (struct notif_client) <alloc_event>: Return a unique_ptr.
8218         (notif_event_xfree): Don't declare.
8219         (notif_event_up): New typedef.
8220         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8221         (notif_event_xfree, do_notif_event_xfree): Remove.
8222         (remote_notif_state_xfree): Update.
8223
8224 2019-03-06  Tom Tromey  <tom@tromey.com>
8225
8226         * infrun.c (displaced_step_clear_cleanup): Now a
8227         forward_scope_exit type.
8228         (displaced_step_prepare_throw): Update.
8229         (displaced_step_fixup): Update.
8230
8231 2019-03-06  Tom Tromey  <tom@tromey.com>
8232
8233         * inferior.h (class inferior): Update comment.
8234         * gdbthread.h (class thread_info): Update comment.
8235
8236 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8237             Tom Tromey  <tom@tromey.com>
8238
8239         * stabsread.h (struct stab_section_list): Remove.
8240         (coffstab_build_psymtabs): Update.
8241         * dbxread.c (symbuf_sections): Now a std::vector.
8242         (sect_idx): New global.
8243         (fill_symbuf): Update.
8244         (coffstab_build_psymtabs): Change type of stabsects parameter.
8245         Update.
8246         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8247         std::vector.
8248         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8249         (coff_locate_sections): Update.
8250         (coff_symfile_read): Remove cleanups.  Update.
8251         (init_stringtab): Add storage parameter.
8252         (free_stringtab, free_stringtab_cleanup): Remove.
8253         (init_lineno): Add storage parameter.
8254         (free_linetab, free_linetab_cleanup): Remove.
8255
8256 2019-03-06  Pedro Alves  <palves@redhat.com>
8257
8258         * linux-fork.c (fork_info::clobber_regs): Delete.
8259         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8260         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8261         comment.  Adjust.
8262         (scoped_switch_fork_info::scoped_switch_fork_info)
8263         (checkpoint_command, linux_fork_context): Adjust
8264         fork_save_infrun_state calls.
8265
8266 2019-03-06  Pedro Alves  <palves@redhat.com>
8267
8268         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8269         (inf_has_multiple_threads): Return 'bool' and rewrite using
8270         inferior_info::threads().
8271
8272 2019-03-06  Pedro Alves  <palves@redhat.com>
8273
8274         * linux-fork.c: Include <list>.
8275         (fork_list): Now a std::list instance.
8276         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8277         (forks_exist_p, find_last_fork): Adjust.
8278         (new_fork): Delete.
8279         (one_fork_p): New.
8280         (add_fork): Adjust.
8281         (free_fork): Delete, folded into fork_info::~fork_info().
8282         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8283         Adjust.
8284         (init_fork_list): Delete.
8285         (linux_fork_killall, linux_fork_mourn_inferior)
8286         (linux_fork_detach, info_checkpoints_command): Adjust.
8287         (_initialize_linux_fork): No longer call init_fork_list.
8288
8289 2019-03-06  Pedro Alves  <palves@redhat.com>
8290
8291         * linux-fork.c (new_fork): New, split out of ...
8292         (add_fork): ... this.  Return void.  Move "first fork" special
8293         case from here, to ...
8294         (checkpoint_command): ... here.
8295         * linux-linux.h (add_fork): Return void.
8296
8297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8300
8301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8302             Chris January  <chris.january@arm.com>
8303             David Lecomber  <david.lecomber@arm.com>
8304
8305         * f-exp.y: New token, UNOP_INTRINSIC.
8306         (exp): New pattern using UNOP_INTRINSIC token.
8307         (f77_keywords): Add 'abs' keyword.
8308         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8309         (value_from_host_double): New function.
8310         (evaluate_subexp_f): Support UNOP_ABS.
8311
8312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8315         types.
8316
8317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8318
8319         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8320         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8321         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8322
8323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8326
8327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8328             Chris January  <chris.january@arm.com>
8329
8330         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8331         * f-exp.y: Define 'KIND' token.
8332         (exp): New pattern for KIND expressions.
8333         (ptype): Handle types with a kind extension.
8334         (direct_abs_decl): Extend to spot kind extensions.
8335         (f77_keywords): Add 'kind' to the list.
8336         (push_kind_type): New function.
8337         (convert_to_kind_type): New function.
8338         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8339         * parse.c (operator_length_standard): Likewise.
8340         * parser-defs.h (enum type_pieces): Add tp_kind.
8341         * std-operator.def: Add UNOP_KIND.
8342
8343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8344
8345         * f-exp.y (f_parse): Set yydebug.
8346
8347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * f-lang.c (evaluate_subexp_f): New function.
8350         (exp_descriptor_f): New global.
8351         (f_language_defn): Use exp_descriptor_f instead of
8352         exp_descriptor_standard.
8353
8354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * f-exp.y (struct token): Add comments.
8357         (dot_ops): Remove uppercase versions and the end marker.
8358         (f77_keywords): Likewise.
8359         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8360         entries in the dot_ops array are case insensitive, and use
8361         strncasecmp to compare strings.  Also some whitespace cleanup in
8362         this area.  Similar for the f77_keywords array, except entries in
8363         this list might be case sensitive.
8364
8365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8366
8367         * f-exp.y (struct f77_boolean_val): Add comments.
8368         (boolean_values): Remove uppercase versions, and end marker.
8369         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8370         and use strncasecmp to achieve case insensitivity.  Additionally,
8371         perform whitespace cleanup around this code.
8372
8373 2019-03-06  Tom Tromey  <tromey@adacore.com>
8374
8375         * remote-sim.c (gdbsim_target_open): Use result of
8376         gdb_argv::release.
8377
8378 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8379         Dirk Schubert  <dirk.schubert@arm.com>
8380         Chris January  <chris.january@arm.com>
8381
8382         * eval.c (evaluate_subexp_standard): Call Fortran argument
8383         wrapping logic.
8384         * f-lang.c (struct value): A value which can be passed into a
8385         Fortran function call.
8386         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8387         where appropriate.
8388         (struct type): Value ready for a Fortran function call.
8389         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8390         is needed.
8391         * f-lang.h (fortran_argument_convert): Declaration.
8392         (fortran_preserve_arg_pointer): Declaration.
8393         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8394
8395 2019-03-05  Tom Tromey  <tromey@adacore.com>
8396
8397         * python/py-prettyprint.c (print_string_repr): Remove #if.
8398         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8399
8400 2019-03-05  Tom Tromey  <tromey@adacore.com>
8401
8402         * target.c (the_dummy_target): Move later.  Change type to
8403         "dummy_target".
8404         (initialize_targets): Don't initialize the_dummy_target.
8405
8406 2019-03-05  Tom Tromey  <tromey@adacore.com>
8407
8408         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8409         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8410
8411 2019-03-05  Tom Tromey  <tromey@adacore.com>
8412
8413         * windows-nat.c (windows_nat_target::attach)
8414         (windows_nat_target::detach): Don't call gdb_flush.
8415         * valprint.c (generic_val_print, val_print, val_print_string):
8416         Don't call gdb_flush.
8417         * utils.c (defaulted_query): Don't call gdb_flush.
8418         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8419         * target.c (target_announce_detach): Don't call gdb_flush.
8420         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8421         * remote.c (extended_remote_target::attach): Don't call
8422         gdb_flush.
8423         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8424         * printcmd.c (do_examine): Don't call gdb_flush.
8425         (info_display_command): Don't call gdb_flush.
8426         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8427         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8428         * memattr.c (info_mem_command): Don't call gdb_flush.
8429         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8430         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8431         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8432         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8433         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8434         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8435         (gnu_nat_target::detach): Don't call gdb_flush.
8436         * f-valprint.c (f_val_print): Don't call gdb_flush.
8437         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8438         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8439         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8440         gdb_flush.
8441         * c-valprint.c (c_val_print): Don't call gdb_flush.
8442         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8443
8444 2019-03-05  Tom Tromey  <tromey@adacore.com>
8445
8446         * varobj.c (update_dynamic_varobj_children): Update.
8447         (install_default_visualizer): Use reset, not release.
8448         * value.c (set_internalvar): Update.
8449         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8450         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8451         ATTRIBUTE_UNUSED_RESULT.
8452
8453 2019-03-05  Tom Tromey  <tromey@adacore.com>
8454
8455         * remote.c (class scoped_remote_fd) <release>: Add
8456         ATTRIBUTE_UNUSED_RESULT.
8457
8458 2019-03-05  Tom Tromey  <tromey@adacore.com>
8459
8460         * macroexp.c (struct macro_buffer) <release>: Add
8461         ATTRIBUTE_UNUSED_RESULT.
8462
8463 2019-03-05  Tom Tromey  <tromey@adacore.com>
8464
8465         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8466         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8467         ATTRIBUTE_UNUSED_RESULT.
8468
8469 2019-03-05  Tom Tromey  <tromey@adacore.com>
8470
8471         * common/scoped_fd.h (class scoped_fd) <release>: Add
8472         ATTRIBUTE_UNUSED_RESULT.
8473
8474 2019-03-05  Tom Tromey  <tromey@adacore.com>
8475
8476         * parser-defs.h (struct parser_state) <release>: Add
8477         ATTRIBUTE_UNUSED_RESULT.
8478
8479 2019-03-05  Tom Tromey  <tromey@adacore.com>
8480
8481         * utils.h (class gdb_argv) <release>: Add
8482         ATTRIBUTE_UNUSED_RESULT.
8483         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8484
8485 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8486
8487         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8488         for-loop range, to avoid compiler warnings.
8489
8490         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8491         avoid compiler warnings about unused variables.
8492
8493         * NEWS: Mention end of support for native debugging on MS-Windows
8494         before XP.
8495
8496         PR gdb/24292
8497         * common/netstuff.c:
8498         * gdbserver/gdbreplay.c
8499         * gdbserver/remote-utils.c:
8500         * ser-tcp.c:
8501         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8502         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8503         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8504         'getaddrinfo' and 'freeaddrinfo' were not available before
8505         Windows XP, and mingw.org's MinGW headers by default define
8506         _WIN32_WINNT to 0x500.
8507
8508 2019-03-01  Gary Benson <gbenson@redhat.com>
8509
8510         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8511
8512 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8513             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8514
8515         PR gdb/8527
8516         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8517         set_sigint_trap, clear_sigint_trap.
8518
8519 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8520
8521         * target.c (target_detach): Clear the regcache and the
8522         frame cache.
8523
8524 2019-02-27  Pedro Alves  <palves@redhat.com>
8525
8526         * utils.c (set_screen_size): When we cap the height/width sizes,
8527         tweak the corresponding command variable to show "unlimited":
8528
8529 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8530             Pedro Alves  <palves@redhat.com>
8531
8532         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8533         before calling rl_set_screen_size.
8534
8535 2019-02-27  Tom Tromey  <tromey@adacore.com>
8536
8537         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8538         define.
8539         * python/py-value.c: Remove Python 2.4 workaround.
8540         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8541         workaround.
8542         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8543         Python 2.4 workaround.
8544         * python/python-internal.h: Remove Python 2.4 comment.
8545         (Py_ssize_t): Don't define.
8546         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8547         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8548         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8549         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8550         * python/python.c (do_start_initialization): Remove Python 2.4
8551         workaround.
8552         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8553         (print_children): Remove Python 2.4 workaround.
8554         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8555         workaround.
8556         (CHARBUFFERPROC_NAME): Remove.
8557         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8558         Python 2.4 workaround.
8559
8560 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8561
8562         * NEWS: Note minimum Python version.
8563
8564 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8565
8566         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8567         code from these functions.  Remove corresponding ifdefs.  Use
8568         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8569         Remove gotos and target of gotos.
8570         (infpy_search_memory): Likewise.
8571
8572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8573
8574         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8575         (hppa_gdbarch_init): Don't register deleted functions with
8576         gdbarch.
8577
8578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8579
8580         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8581         (h8300_unwind_sp): Delete.
8582         (h8300_dummy_id): Delete.
8583         (h8300_gdbarch_init): Don't register deleted functions with
8584         gdbarch.
8585
8586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8587
8588         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8589         (ft32_unwind_pc): Delete.
8590         (ft32_unwind_sp): Delete.
8591         (ft32_gdbarch_init): Don't register deleted functions with
8592         gdbarch.
8593
8594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8595
8596         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8597         (frv_unwind_pc): Delete.
8598         (frv_unwind_sp): Delete.
8599         (frv_gdbarch_init): Don't register deleted functions with
8600         gdbarch.
8601
8602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8603
8604         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8605         (riscv_unwind_pc): Delete.
8606         (riscv_unwind_sp): Delete.
8607         (riscv_gdbarch_init): Don't register deleted functions with
8608         gdbarch.
8609
8610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8611
8612         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8613         (csky_unwind_pc): Delete.
8614         (csky_unwind_sp): Delete.
8615         (csky_gdbarch_init): Don't register deleted functions with
8616         gdbarch.
8617
8618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8619
8620         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8621         (cris_unwind_pc): Delete.
8622         (cris_unwind_sp): Delete.
8623         (cris_gdbarch_init): Don't register deleted functions with
8624         gdbarch.
8625
8626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8627
8628         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8629         (bfin_unwind_pc): Delete.
8630         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8631
8632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8633
8634         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8635         (arm_unwind_pc): Delete.
8636         (arm_unwind_sp): Delete.
8637         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8638
8639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8640
8641         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8642         (arc_unwind_pc): Delete.
8643         (arc_unwind_sp): Delete.
8644         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8645
8646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8649         (alpha_unwind_pc): Delete.
8650         (alpha_gdbarch_init): Don't register deleted functions with
8651         gdbarch.
8652
8653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8654
8655         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8656         (aarch64_unwind_pc): Delete.
8657         (aarch64_unwind_sp): Delete.
8658         (aarch64_gdbarch_init): Don't register deleted functions with
8659         gdbarch.
8660
8661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8662
8663         * gdbtypes.c (type_align): Don't consider static members when
8664         computing structure alignment.
8665
8666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8667
8668         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8669         return 0 for other types.
8670         * arch-utils.c (default_type_align): Always return 0.
8671         * gdbarch.h: Regenerate.
8672         * gdbarch.sh (type_align): Extend comment.
8673         * gdbtypes.c (type_align): Add additional comments, always call
8674         gdbarch_type_align before applying the default rules.
8675         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8676         generic code will then apply a suitable default.
8677         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8678         types, return 0 for other types.
8679
8680 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8681
8682         * NEWS: Create a new section for the next release branch.
8683         Rename the section of the current branch, now that it has
8684         been cut.
8685
8686 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8687
8688         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8689         * version.in: Bump version to 8.3.50.DATE-git.
8690
8691 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8692
8693         * aix-thread.c (ptid_cmp): Remove unused variable.
8694         (get_signaled_thread): Likewise.
8695         (store_regs_user_thread): Likewise.
8696         (store_regs_kernel_thread): Likewise.
8697         (fetch_regs_kernel_thread): Remove shadowed variable.
8698
8699 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * features/riscv/32bit-cpu.xml: Add register numbers.
8702         * features/riscv/32bit-fpu.c: Regenerate.
8703         * features/riscv/32bit-fpu.xml: Add register numbers.
8704         * features/riscv/64bit-cpu.xml: Add register numbers.
8705         * features/riscv/64bit-fpu.c: Regenerate.
8706         * features/riscv/64bit-fpu.xml: Add register numbers.
8707
8708 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8709
8710         * NEWS: Mention two argument form of gdb.Value constructor.
8711         * python/py-value.c (convert_buffer_and_type_to_value): New
8712         function.
8713         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8714         Add support for handling an optional second argument.  Call
8715         convert_buffer_and_type_to_value as appropriate.
8716         * python/python-internal.h (Py_buffer_deleter): New struct.
8717         (Py_buffer_up): New typedef.
8718
8719 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8720
8721         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8722         instead of releasing ownership.
8723
8724 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8725
8726         * dwarf2read.c (open_and_init_dwp_file): Call
8727         elf_numsections instead of bfd_count_sections to initialize
8728         dwp_file->num_sections.
8729
8730 2019-02-25  Tom Tromey  <tromey@adacore.com>
8731
8732         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8733
8734 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8735
8736         * gcore.in: Add '--readnever' option when invoking GDB.
8737
8738 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8739
8740         * MAINTAINERS: Update my email address.
8741
8742 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8743
8744         * build-id.c (build_id_to_debug_bfd_1): New function.
8745         (build_id_to_debug_bfd): Look for separate debug file in
8746         sysroot.
8747
8748 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8749
8750         * gdbarch.sh: Update the copyright year range that is placed into
8751         generated files.
8752
8753 2019-02-22  Keith Seitz  <keiths@redhat.com>
8754
8755         PR symtab/23853
8756         * linespec.c (create_sals_line_offset): Search for the default
8757         symtab's filename instead of its fullname.
8758
8759 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8760
8761         * NEWS: Update style defaults.
8762
8763 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8764
8765         * main.c (captured_main_1): Disable styling in batch mode.
8766
8767 2019-02-20  Tom Tromey  <tom@tromey.com>
8768
8769         * symtab.c (symtab_symbol_info): Fix typos.
8770
8771 2019-02-20  Tom Tromey  <tromey@adacore.com>
8772
8773         * findcmd.c (_initialize_mem_search): Use upper case for
8774         metasyntactic variables.
8775
8776 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8777
8778         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8779         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8780
8781 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8782
8783         * top.h (source_file_name): Change to std::string.
8784         * top.c (source_file_name): Likewise.
8785         (command_line_input): Adjust.
8786         * cli/cli-script.c (script_from_file): Adjust.
8787
8788 2019-02-19  Tom Tromey  <tromey@adacore.com>
8789
8790         * ravenscar-thread.c
8791         (ravenscar_thread_target::update_thread_list): Don't call
8792         ada_build_task_list.
8793         * ada-lang.h (ada_build_task_list): Don't declare.
8794         * ada-tasks.c (struct ada_tasks_inferior_data)
8795         <task_list_valid_p>: Now bool.
8796         (read_known_tasks, ada_task_list_changed)
8797         (ada_tasks_invalidate_inferior_data): Update.
8798         (read_known_tasks_array): Return bool.
8799         (read_known_tasks_list): Likewise.
8800         (read_known_tasks): Return void.
8801         (ada_build_task_list): Now static.
8802
8803 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8804
8805         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8806         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8807
8808 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8809
8810         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8811         variant for ada_tasks_pspace_data_handle and
8812         ada_tasks_inferior_data_handle.
8813         (ada_tasks_pspace_data_cleanup): New function.
8814         (ada_tasks_inferior_data_cleanup): New function.
8815
8816 2019-02-17  Tom Tromey  <tom@tromey.com>
8817
8818         * macrotab.h (macro_source_fullname): Return a std::string.
8819         * macrotab.c (macro_include, check_for_redefinition)
8820         (macro_undef, macro_lookup_definition, foreach_macro)
8821         (foreach_macro_in_scope): Update.
8822         (macro_source_fullname): Return a std::string.
8823         * macrocmd.c (show_pp_source_pos): Update.
8824
8825 2019-02-17  Tom Tromey  <tom@tromey.com>
8826
8827         * macrocmd.c (show_pp_source_pos): Style the file names.
8828
8829 2019-02-17  Tom Tromey  <tom@tromey.com>
8830
8831         PR tui/24197:
8832         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8833
8834 2019-02-17  Tom Tromey  <tom@tromey.com>
8835
8836         * ada-lang.c (user_select_syms): Use filtered printing.
8837         * utils.c (wrap_style): New global.
8838         (desired_style): Remove.
8839         (emit_style_escape): Add stream parameter.
8840         (set_output_style, reset_terminal_style, prompt_for_continue):
8841         Update.
8842         (flush_wrap_buffer): Only flush gdb_stdout.
8843         (wrap_here): Set wrap_style.
8844         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8845         treat escape sequences as a character.  Change when wrap buffer is
8846         flushed.
8847         (fputs_styled): Do not set the output style when the default is
8848         requested.
8849         * ui-style.h (struct ui_file_style) <is_default>: New method.
8850         * source.c (print_source_lines_base): Emit escape sequences in one
8851         piece.
8852
8853 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8854
8855         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8856         integers and enumeration types.
8857
8858 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8859
8860         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8861         instead of lookup_symbol_in_language
8862         (do_exact_match): New function.
8863         (ada_get_symbol_name_matcher): Return do_exact_match when
8864         doing a verbatim match.
8865
8866 2019-02-15  Tom Tromey  <tromey@adacore.com>
8867
8868         * ravenscar-thread.c (ravenscar_thread_target::resume)
8869         (ravenscar_thread_target::wait): Special case wildcard requests.
8870
8871 2019-02-15  Tom Tromey  <tromey@adacore.com>
8872
8873         * ravenscar-thread.c (base_ptid): Remove.
8874         (struct ravenscar_thread_target) <close>: New method.
8875         <m_base_ptid>: New member.
8876         <update_inferior_ptid, active_task, task_is_currently_active,
8877         runtime_initialized>: Declare methods.
8878         <ravenscar_thread_target>: Add constructor.
8879         (ravenscar_thread_target::task_is_currently_active)
8880         (ravenscar_thread_target::update_inferior_ptid)
8881         (ravenscar_runtime_initialized): Rename.  Now methods.
8882         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8883         (ravenscar_thread_target::update_thread_list): Update.
8884         (ravenscar_thread_target::active_task): Now method.
8885         (ravenscar_thread_target::store_registers)
8886         (ravenscar_thread_target::prepare_to_store)
8887         (ravenscar_thread_target::prepare_to_store)
8888         (ravenscar_thread_target::mourn_inferior): Update.
8889         (ravenscar_inferior_created): Use "new" to create target.
8890         (ravenscar_thread_target::get_ada_task_ptid): Update.
8891         (_initialize_ravenscar): Don't initialize base_ptid.
8892         (ravenscar_ops): Remove global.
8893
8894 2019-02-15  Tom Tromey  <tromey@adacore.com>
8895
8896         * target.h (push_target): Declare new overload.
8897         * target.c (push_target): New overload, taking an rvalue reference.
8898         * remote.c (remote_target::open_1): Use push_target overload.
8899         * corelow.c (core_target_open): Use push_target overload.
8900
8901 2019-02-15  Tom Tromey  <tromey@adacore.com>
8902
8903         * ravenscar-thread.c (is_ravenscar_task)
8904         (ravenscar_task_is_currently_active): Return bool.
8905         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8906         (_initialize_ravenscar): Remove "(void)".
8907         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8908         Return bool.
8909
8910 2019-02-15  Tom Tromey  <tromey@adacore.com>
8911
8912         * ravenscar-thread.c (ravenscar_runtime_initializer)
8913         (has_ravenscar_runtime, get_running_thread_id)
8914         (ravenscar_thread_target::resume): Fix indentation.
8915
8916 2019-02-15  Tom Tromey  <tromey@adacore.com>
8917
8918         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8919         from ravenscar_arch_ops.
8920         (sparc_ravenscar_ops::fetch_registers)
8921         (sparc_ravenscar_ops::store_registers): Now methods.
8922         (sparc_ravenscar_prepare_to_store): Remove.
8923         (sparc_ravenscar_ops): Redefine.
8924         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8925         methods and destructor.  Remove members.
8926         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8927         (ravenscar_thread_target::store_registers)
8928         (ravenscar_thread_target::prepare_to_store): Update.
8929         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8930         Remove.
8931         (struct ppc_ravenscar_powerpc_ops): Derive from
8932         ravenscar_arch_ops.
8933         (ppc_ravenscar_powerpc_ops::fetch_registers)
8934         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8935         (ppc_ravenscar_powerpc_ops): Redefine.
8936         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8937         (ppc_ravenscar_e500_ops::fetch_registers)
8938         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8939         (ppc_ravenscar_e500_ops): Redefine.
8940         * aarch64-ravenscar-thread.c
8941         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8942         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8943         (aarch64_ravenscar_fetch_registers)
8944         (aarch64_ravenscar_store_registers): Now methods.
8945         (aarch64_ravenscar_ops): Redefine.
8946
8947 2019-02-15  Tom Tromey  <tromey@adacore.com>
8948
8949         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8950         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8951         (ravenscar_thread_target::stopped_by_watchpoint)
8952         (ravenscar_thread_target::stopped_data_address)
8953         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8954
8955 2019-02-15  Tom Tromey  <tromey@adacore.com>
8956
8957         * ravenscar-thread.c: Fix some typos.
8958
8959 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8960             Tom Tromey  <tromey@adacore.com>
8961
8962         * ada-lang.c (ada_exception_sal): Change addr_string to a
8963         std::string.
8964         (create_ada_exception_catchpoint): Update.
8965
8966 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8967             Tom Tromey  <tromey@adacore.com>
8968
8969         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8970         (bp_location_ops): Remove.
8971         (base_breakpoint_allocate_location): Update.
8972         (free_bp_location): Update.
8973         * ada-lang.c (class ada_catchpoint_location)
8974         <ada_catchpoint_location>: Remove ops parameter.
8975         (ada_catchpoint_location_dtor): Remove.
8976         (ada_catchpoint_location_ops): Remove.
8977         (allocate_location_exception): Update.
8978         * breakpoint.h (struct bp_location_ops): Remove.
8979         (class bp_location) <bp_location>: Remove bp_location_ops
8980         parameter.
8981         <~bp_location>: Add destructor.
8982         <ops>: Remove.
8983
8984 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8985             Pedro Alves  <palves@redhat.com>
8986
8987         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8988         'PATH_MAX'.
8989
8990 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8991             Samuel Thibault  <samuel.thibault@gnu.org>
8992             Thomas Schwinge  <thomas@codesourcery.com>
8993
8994         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8995         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8996
8997 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8998
8999         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9000         (check_empty): Use "const char *".
9001
9002         * gnu-nat.c (gnu_nat_target::detach): Instead of
9003         'detach_inferior (pid)' call
9004         'detach_inferior (find_inferior_pid (pid))'.
9005
9006         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9007         'nat/fork-inferior.o'.
9008         * gnu-nat.c: #include "nat/fork-inferior.h".
9009
9010         * gnu-nat.c (gnu_nat_target::detach): Instead of
9011         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9012         * gnu-nat.h: #include "inf-child.h".
9013         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9014         'i386_gnu_nat_target::fetch_registers'.
9015         (gnu_store_registers): Rename/move to
9016         'i386_gnu_nat_target::store_registers'.
9017
9018         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9019         * gnu-nat.h (mach_thread_info): New function.
9020         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9021
9022         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9023
9024 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9025
9026         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9027
9028 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9029
9030         * windows-nat.c (windows_add_thread): Add new parameter
9031         "main_thread_p" with default value set to false.  Update
9032         function documentation as well as all callers.
9033         (windows_delete_thread): Likewise.
9034         (fake_create_process): Update call to windows_add_thread.
9035         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9036         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9037         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9038         call to windows_delete_thread.
9039
9040 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9041
9042         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9043
9044 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9045
9046         * symfile.c (find_separate_debug_file): Use canonical path of
9047         sysroot with child_path instead of gdb_sysroot if it is valid.
9048
9049 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9050
9051         * symfile.c (find_separate_debug_file): Use child_path to
9052         determine if an object file is under a sysroot.
9053
9054 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9055
9056         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9057         unittests/child-path-selftests.c.
9058         * common/pathstuff.c (child_path): New function.
9059         * common/pathstuff.h (child_path): New prototype.
9060         * unittests/child-path-selftests.c: New file.
9061
9062 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9063
9064         * symfile.c (find_separate_debug_file): Look for separate debug
9065         files in debug directories under the sysroot.
9066
9067 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9068
9069         * symtab.h (struct minimal_symbol data_p): New const method.
9070         (struct minimal_symbol text_p): Likewise.
9071         * symtab.c (output_source_filename): Use file name style
9072         to print file name.
9073         (print_symbol_info): Likewise.
9074         (print_msymbol_info): Use address style to print addresses.
9075         Use function name style to print executable text symbols.
9076         (expand_symtab_containing_pc): Use data_p.
9077         (find_pc_sect_compunit_symtab): Likewise.
9078
9079 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9080
9081         * breakpoint.c (describe_other_breakpoints): Use address style
9082         to print addresses.
9083         (say_where): Likewise.
9084
9085 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9086
9087         * ada-typeprint.c (print_func_type): Print function name
9088         style to print function name.
9089         * c-typeprint.c (c_print_type_1): Likewise.
9090
9091 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9092
9093         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9094         for execve.
9095
9096 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9097
9098         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9099         type_stack.
9100
9101 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9102
9103         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9104         TYPE_CODE_REF types.
9105
9106 2019-02-08  Jim Wilson  <jimw@sifive.com>
9107
9108         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9109         (riscv_linux_fregset): New.
9110         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9111
9112 2019-02-07  Tom Tromey  <tom@tromey.com>
9113
9114         * thread.c (thread_cancel_execution_command): Update.
9115         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9116         methods.
9117         (struct thread_fsm_ops): Remove.
9118         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9119         (thread_fsm_should_stop, thread_fsm_return_value)
9120         (thread_fsm_set_finished, thread_fsm_finished_p)
9121         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9122         Don't declare.
9123         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9124         * infrun.c (clear_proceed_status_thread)
9125         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9126         (print_stop_event): Update.
9127         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9128         Add constructor.
9129         (step_command_fsm_ops): Remove.
9130         (new_step_command_fsm): Remove.
9131         (step_1): Update.
9132         (step_command_fsm::should_stop): Rename from
9133         step_command_fsm_should_stop.
9134         (step_command_fsm::clean_up): Rename from
9135         step_command_fsm_clean_up.
9136         (step_command_fsm::do_async_reply_reason): Rename from
9137         step_command_fsm_async_reply_reason.
9138         (struct until_next_fsm): Inherit from thread_fsm.  Add
9139         constructor.
9140         (until_next_fsm_ops): Remove.
9141         (new_until_next_fsm): Remove.
9142         (until_next_fsm::should_stop): Rename from
9143         until_next_fsm_should_stop.
9144         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9145         (until_next_fsm::do_async_reply_reason): Rename from
9146         until_next_fsm_async_reply_reason.
9147         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9148         constructor.  Change type of breakpoint.
9149         (finish_command_fsm_ops): Remove.
9150         (new_finish_command_fsm): Remove.
9151         (finish_command_fsm::should_stop): Rename from
9152         finish_command_fsm_should_stop.
9153         (finish_command_fsm::clean_up): Rename from
9154         finish_command_fsm_clean_up.
9155         (finish_command_fsm::return_value): Rename from
9156         finish_command_fsm_return_value.
9157         (finish_command_fsm::do_async_reply_reason): Rename from
9158         finish_command_fsm_async_reply_reason.
9159         (finish_command): Update.
9160         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9161         Add constructor.
9162         (call_thread_fsm_ops): Remove.
9163         (call_thread_fsm::call_thread_fsm): Rename from
9164         new_call_thread_fsm.
9165         (call_thread_fsm::should_stop): Rename from
9166         call_thread_fsm_should_stop.
9167         (call_thread_fsm::should_notify_stop): Rename from
9168         call_thread_fsm_should_notify_stop.
9169         (run_inferior_call, call_function_by_hand_dummy): Update.
9170         * cli/cli-interp.c (should_print_stop_to_console): Update.
9171         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9172         Add constructor.  Change type of location_breakpoint,
9173         caller_breakpoint.
9174         (until_break_fsm_ops): Remove.
9175         (new_until_break_fsm): Remove.
9176         (until_break_fsm::should_stop): Rename from
9177         until_break_fsm_should_stop.
9178         (until_break_fsm::clean_up): Rename from
9179         until_break_fsm_clean_up.
9180         (until_break_fsm::do_async_reply_reason): Rename from
9181         until_break_fsm_async_reply_reason.
9182         (until_break_command): Update.
9183         * thread-fsm.c: Remove.
9184         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9185
9186 2019-02-07  Tom Tromey  <tom@tromey.com>
9187
9188         * yy-remap.h: Add include guard.
9189         * xtensa-tdep.h: Add include guard.
9190         * xcoffread.h: Rename include guard.
9191         * varobj-iter.h: Add include guard.
9192         * tui/tui.h: Rename include guard.
9193         * tui/tui-winsource.h: Rename include guard.
9194         * tui/tui-wingeneral.h: Rename include guard.
9195         * tui/tui-windata.h: Rename include guard.
9196         * tui/tui-win.h: Rename include guard.
9197         * tui/tui-stack.h: Rename include guard.
9198         * tui/tui-source.h: Rename include guard.
9199         * tui/tui-regs.h: Rename include guard.
9200         * tui/tui-out.h: Rename include guard.
9201         * tui/tui-layout.h: Rename include guard.
9202         * tui/tui-io.h: Rename include guard.
9203         * tui/tui-hooks.h: Rename include guard.
9204         * tui/tui-file.h: Rename include guard.
9205         * tui/tui-disasm.h: Rename include guard.
9206         * tui/tui-data.h: Rename include guard.
9207         * tui/tui-command.h: Rename include guard.
9208         * tic6x-tdep.h: Add include guard.
9209         * target/waitstatus.h: Rename include guard.
9210         * target/wait.h: Rename include guard.
9211         * target/target.h: Rename include guard.
9212         * target/resume.h: Rename include guard.
9213         * target-float.h: Rename include guard.
9214         * stabsread.h: Add include guard.
9215         * rs6000-tdep.h: Add include guard.
9216         * riscv-fbsd-tdep.h: Add include guard.
9217         * regformats/regdef.h: Rename include guard.
9218         * record.h: Rename include guard.
9219         * python/python.h: Rename include guard.
9220         * python/python-internal.h: Rename include guard.
9221         * python/py-stopevent.h: Rename include guard.
9222         * python/py-ref.h: Rename include guard.
9223         * python/py-record.h: Rename include guard.
9224         * python/py-record-full.h: Rename include guard.
9225         * python/py-record-btrace.h: Rename include guard.
9226         * python/py-instruction.h: Rename include guard.
9227         * python/py-events.h: Rename include guard.
9228         * python/py-event.h: Rename include guard.
9229         * procfs.h: Add include guard.
9230         * proc-utils.h: Add include guard.
9231         * p-lang.h: Add include guard.
9232         * or1k-tdep.h: Rename include guard.
9233         * observable.h: Rename include guard.
9234         * nto-tdep.h: Rename include guard.
9235         * nat/x86-linux.h: Rename include guard.
9236         * nat/x86-linux-dregs.h: Rename include guard.
9237         * nat/x86-gcc-cpuid.h: Add include guard.
9238         * nat/x86-dregs.h: Rename include guard.
9239         * nat/x86-cpuid.h: Rename include guard.
9240         * nat/ppc-linux.h: Rename include guard.
9241         * nat/mips-linux-watch.h: Rename include guard.
9242         * nat/linux-waitpid.h: Rename include guard.
9243         * nat/linux-ptrace.h: Rename include guard.
9244         * nat/linux-procfs.h: Rename include guard.
9245         * nat/linux-osdata.h: Rename include guard.
9246         * nat/linux-nat.h: Rename include guard.
9247         * nat/linux-namespaces.h: Rename include guard.
9248         * nat/linux-btrace.h: Rename include guard.
9249         * nat/glibc_thread_db.h: Rename include guard.
9250         * nat/gdb_thread_db.h: Rename include guard.
9251         * nat/gdb_ptrace.h: Rename include guard.
9252         * nat/fork-inferior.h: Rename include guard.
9253         * nat/amd64-linux-siginfo.h: Rename include guard.
9254         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9255         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9256         * nat/aarch64-linux.h: Rename include guard.
9257         * nat/aarch64-linux-hw-point.h: Rename include guard.
9258         * mn10300-tdep.h: Add include guard.
9259         * mips-linux-tdep.h: Add include guard.
9260         * mi/mi-parse.h: Rename include guard.
9261         * mi/mi-out.h: Rename include guard.
9262         * mi/mi-main.h: Rename include guard.
9263         * mi/mi-interp.h: Rename include guard.
9264         * mi/mi-getopt.h: Rename include guard.
9265         * mi/mi-console.h: Rename include guard.
9266         * mi/mi-common.h: Rename include guard.
9267         * mi/mi-cmds.h: Rename include guard.
9268         * mi/mi-cmd-break.h: Rename include guard.
9269         * m2-lang.h: Add include guard.
9270         * location.h: Rename include guard.
9271         * linux-record.h: Rename include guard.
9272         * linux-nat.h: Add include guard.
9273         * linux-fork.h: Add include guard.
9274         * i386-darwin-tdep.h: Rename include guard.
9275         * hppa-linux-offsets.h: Add include guard.
9276         * guile/guile.h: Rename include guard.
9277         * guile/guile-internal.h: Rename include guard.
9278         * gnu-nat.h: Rename include guard.
9279         * gdb-stabs.h: Rename include guard.
9280         * frv-tdep.h: Add include guard.
9281         * f-lang.h: Add include guard.
9282         * event-loop.h: Add include guard.
9283         * darwin-nat.h: Rename include guard.
9284         * cp-abi.h: Rename include guard.
9285         * config/sparc/nm-sol2.h: Rename include guard.
9286         * config/nm-nto.h: Rename include guard.
9287         * config/nm-linux.h: Add include guard.
9288         * config/i386/nm-i386gnu.h: Rename include guard.
9289         * config/djgpp/nl_types.h: Rename include guard.
9290         * config/djgpp/langinfo.h: Rename include guard.
9291         * compile/gcc-cp-plugin.h: Add include guard.
9292         * compile/gcc-c-plugin.h: Add include guard.
9293         * compile/compile.h: Rename include guard.
9294         * compile/compile-object-run.h: Rename include guard.
9295         * compile/compile-object-load.h: Rename include guard.
9296         * compile/compile-internal.h: Rename include guard.
9297         * compile/compile-cplus.h: Rename include guard.
9298         * compile/compile-c.h: Rename include guard.
9299         * common/xml-utils.h: Rename include guard.
9300         * common/x86-xstate.h: Rename include guard.
9301         * common/version.h: Rename include guard.
9302         * common/vec.h: Rename include guard.
9303         * common/tdesc.h: Rename include guard.
9304         * common/selftest.h: Rename include guard.
9305         * common/scoped_restore.h: Rename include guard.
9306         * common/scoped_mmap.h: Rename include guard.
9307         * common/scoped_fd.h: Rename include guard.
9308         * common/safe-iterator.h: Rename include guard.
9309         * common/run-time-clock.h: Rename include guard.
9310         * common/refcounted-object.h: Rename include guard.
9311         * common/queue.h: Rename include guard.
9312         * common/ptid.h: Rename include guard.
9313         * common/print-utils.h: Rename include guard.
9314         * common/preprocessor.h: Rename include guard.
9315         * common/pathstuff.h: Rename include guard.
9316         * common/observable.h: Rename include guard.
9317         * common/netstuff.h: Rename include guard.
9318         * common/job-control.h: Rename include guard.
9319         * common/host-defs.h: Rename include guard.
9320         * common/gdb_wait.h: Rename include guard.
9321         * common/gdb_vecs.h: Rename include guard.
9322         * common/gdb_unlinker.h: Rename include guard.
9323         * common/gdb_unique_ptr.h: Rename include guard.
9324         * common/gdb_tilde_expand.h: Rename include guard.
9325         * common/gdb_sys_time.h: Rename include guard.
9326         * common/gdb_string_view.h: Rename include guard.
9327         * common/gdb_splay_tree.h: Rename include guard.
9328         * common/gdb_setjmp.h: Rename include guard.
9329         * common/gdb_ref_ptr.h: Rename include guard.
9330         * common/gdb_optional.h: Rename include guard.
9331         * common/gdb_locale.h: Rename include guard.
9332         * common/gdb_assert.h: Rename include guard.
9333         * common/filtered-iterator.h: Rename include guard.
9334         * common/filestuff.h: Rename include guard.
9335         * common/fileio.h: Rename include guard.
9336         * common/environ.h: Rename include guard.
9337         * common/common-utils.h: Rename include guard.
9338         * common/common-types.h: Rename include guard.
9339         * common/common-regcache.h: Rename include guard.
9340         * common/common-inferior.h: Rename include guard.
9341         * common/common-gdbthread.h: Rename include guard.
9342         * common/common-exceptions.h: Rename include guard.
9343         * common/common-defs.h: Rename include guard.
9344         * common/common-debug.h: Rename include guard.
9345         * common/cleanups.h: Rename include guard.
9346         * common/buffer.h: Rename include guard.
9347         * common/btrace-common.h: Rename include guard.
9348         * common/break-common.h: Rename include guard.
9349         * cli/cli-utils.h: Rename include guard.
9350         * cli/cli-style.h: Rename include guard.
9351         * cli/cli-setshow.h: Rename include guard.
9352         * cli/cli-script.h: Rename include guard.
9353         * cli/cli-interp.h: Rename include guard.
9354         * cli/cli-decode.h: Rename include guard.
9355         * cli/cli-cmds.h: Rename include guard.
9356         * charset-list.h: Add include guard.
9357         * buildsym-legacy.h: Rename include guard.
9358         * bfin-tdep.h: Add include guard.
9359         * ax.h: Rename include guard.
9360         * arm-linux-tdep.h: Add include guard.
9361         * arm-fbsd-tdep.h: Add include guard.
9362         * arch/xtensa.h: Rename include guard.
9363         * arch/tic6x.h: Add include guard.
9364         * arch/i386.h: Add include guard.
9365         * arch/arm.h: Rename include guard.
9366         * arch/arm-linux.h: Rename include guard.
9367         * arch/arm-get-next-pcs.h: Rename include guard.
9368         * arch/amd64.h: Add include guard.
9369         * arch/aarch64-insn.h: Rename include guard.
9370         * arch-utils.h: Rename include guard.
9371         * annotate.h: Add include guard.
9372         * amd64-darwin-tdep.h: Rename include guard.
9373         * aarch64-linux-tdep.h: Add include guard.
9374         * aarch64-fbsd-tdep.h: Add include guard.
9375         * aarch32-linux-nat.h: Add include guard.
9376
9377 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9378
9379         * macrotab.c (macro_define_internal): New function that
9380         factorizes macro_define_object_internal and macro_define_function
9381         code.
9382         (macro_define_object_internal): Use macro_define_internal.
9383         (macro_define_function): Likewise.
9384
9385 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9386
9387         * macrocmd.c (extract_identifier): Return
9388         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9389         callers.
9390
9391 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9392
9393         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9394
9395 2019-02-05  Tom Tromey  <tom@tromey.com>
9396
9397         * target.c (target_stack::unpush): Move assertion earlier.
9398
9399 2019-01-30  Tom Tromey  <tom@tromey.com>
9400
9401         PR python/23615:
9402         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9403         (gdbpy_parse_and_eval): Likewise.
9404         * python/python-internal.h (gdbpy_allow_threads): New class.
9405
9406 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9407
9408         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9409         (aarch64_fbsd_fpregmap): Move earlier.
9410         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9411         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9412         instead of individual calls to trad_frame_set_reg_addr.
9413         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9414         earlier.
9415         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9416         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9417         instead of individual calls to trad_frame_set_reg_addr.
9418
9419 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9420
9421         * CONTRIBUTE: Replace contribution list with wiki link.
9422
9423 2019-01-25  Tom Tromey  <tom@tromey.com>
9424
9425         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9426
9427 2019-01-25  Tom Tromey  <tom@tromey.com>
9428
9429         * xtensa-linux-nat.c: Fix common/ includes.
9430         * xml-support.h: Fix common/ includes.
9431         * xml-support.c: Fix common/ includes.
9432         * x86-linux-nat.c: Fix common/ includes.
9433         * windows-nat.c: Fix common/ includes.
9434         * varobj.h: Fix common/ includes.
9435         * varobj.c: Fix common/ includes.
9436         * value.c: Fix common/ includes.
9437         * valops.c: Fix common/ includes.
9438         * utils.c: Fix common/ includes.
9439         * unittests/xml-utils-selftests.c: Fix common/ includes.
9440         * unittests/utils-selftests.c: Fix common/ includes.
9441         * unittests/unpack-selftests.c: Fix common/ includes.
9442         * unittests/tracepoint-selftests.c: Fix common/ includes.
9443         * unittests/style-selftests.c: Fix common/ includes.
9444         * unittests/string_view-selftests.c: Fix common/ includes.
9445         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9446         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9447         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9448         * unittests/rsp-low-selftests.c: Fix common/ includes.
9449         * unittests/parse-connection-spec-selftests.c: Fix common/
9450         includes.
9451         * unittests/optional-selftests.c: Fix common/ includes.
9452         * unittests/offset-type-selftests.c: Fix common/ includes.
9453         * unittests/observable-selftests.c: Fix common/ includes.
9454         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9455         * unittests/memrange-selftests.c: Fix common/ includes.
9456         * unittests/memory-map-selftests.c: Fix common/ includes.
9457         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9458         * unittests/function-view-selftests.c: Fix common/ includes.
9459         * unittests/environ-selftests.c: Fix common/ includes.
9460         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9461         * unittests/common-utils-selftests.c: Fix common/ includes.
9462         * unittests/cli-utils-selftests.c: Fix common/ includes.
9463         * unittests/array-view-selftests.c: Fix common/ includes.
9464         * ui-file.c: Fix common/ includes.
9465         * tui/tui-io.c: Fix common/ includes.
9466         * tracepoint.h: Fix common/ includes.
9467         * tracepoint.c: Fix common/ includes.
9468         * tracefile-tfile.c: Fix common/ includes.
9469         * top.h: Fix common/ includes.
9470         * top.c: Fix common/ includes.
9471         * thread.c: Fix common/ includes.
9472         * target/waitstatus.h: Fix common/ includes.
9473         * target/waitstatus.c: Fix common/ includes.
9474         * target.h: Fix common/ includes.
9475         * target.c: Fix common/ includes.
9476         * target-memory.c: Fix common/ includes.
9477         * target-descriptions.c: Fix common/ includes.
9478         * symtab.h: Fix common/ includes.
9479         * symfile.c: Fix common/ includes.
9480         * stap-probe.c: Fix common/ includes.
9481         * spu-linux-nat.c: Fix common/ includes.
9482         * sparc-nat.c: Fix common/ includes.
9483         * source.c: Fix common/ includes.
9484         * solib.c: Fix common/ includes.
9485         * solib-target.c: Fix common/ includes.
9486         * ser-unix.c: Fix common/ includes.
9487         * ser-tcp.c: Fix common/ includes.
9488         * ser-pipe.c: Fix common/ includes.
9489         * ser-base.c: Fix common/ includes.
9490         * selftest-arch.c: Fix common/ includes.
9491         * s12z-tdep.c: Fix common/ includes.
9492         * rust-exp.y: Fix common/ includes.
9493         * rs6000-aix-tdep.c: Fix common/ includes.
9494         * riscv-tdep.c: Fix common/ includes.
9495         * remote.c: Fix common/ includes.
9496         * remote-notif.h: Fix common/ includes.
9497         * remote-fileio.h: Fix common/ includes.
9498         * remote-fileio.c: Fix common/ includes.
9499         * regcache.h: Fix common/ includes.
9500         * regcache.c: Fix common/ includes.
9501         * record-btrace.c: Fix common/ includes.
9502         * python/python.c: Fix common/ includes.
9503         * python/py-type.c: Fix common/ includes.
9504         * python/py-inferior.c: Fix common/ includes.
9505         * progspace.h: Fix common/ includes.
9506         * producer.c: Fix common/ includes.
9507         * procfs.c: Fix common/ includes.
9508         * proc-api.c: Fix common/ includes.
9509         * printcmd.c: Fix common/ includes.
9510         * ppc-linux-nat.c: Fix common/ includes.
9511         * parser-defs.h: Fix common/ includes.
9512         * osdata.c: Fix common/ includes.
9513         * obsd-nat.c: Fix common/ includes.
9514         * nat/x86-linux.c: Fix common/ includes.
9515         * nat/x86-linux-dregs.c: Fix common/ includes.
9516         * nat/x86-dregs.h: Fix common/ includes.
9517         * nat/x86-dregs.c: Fix common/ includes.
9518         * nat/ppc-linux.c: Fix common/ includes.
9519         * nat/mips-linux-watch.h: Fix common/ includes.
9520         * nat/mips-linux-watch.c: Fix common/ includes.
9521         * nat/linux-waitpid.c: Fix common/ includes.
9522         * nat/linux-ptrace.h: Fix common/ includes.
9523         * nat/linux-ptrace.c: Fix common/ includes.
9524         * nat/linux-procfs.c: Fix common/ includes.
9525         * nat/linux-personality.c: Fix common/ includes.
9526         * nat/linux-osdata.c: Fix common/ includes.
9527         * nat/linux-namespaces.c: Fix common/ includes.
9528         * nat/linux-btrace.h: Fix common/ includes.
9529         * nat/linux-btrace.c: Fix common/ includes.
9530         * nat/fork-inferior.c: Fix common/ includes.
9531         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9532         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9533         * nat/aarch64-linux.c: Fix common/ includes.
9534         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9535         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9536         * namespace.h: Fix common/ includes.
9537         * mips-linux-tdep.c: Fix common/ includes.
9538         * minsyms.c: Fix common/ includes.
9539         * mi/mi-parse.h: Fix common/ includes.
9540         * mi/mi-main.c: Fix common/ includes.
9541         * mi/mi-cmd-env.c: Fix common/ includes.
9542         * memrange.h: Fix common/ includes.
9543         * memattr.c: Fix common/ includes.
9544         * maint.h: Fix common/ includes.
9545         * maint.c: Fix common/ includes.
9546         * main.c: Fix common/ includes.
9547         * machoread.c: Fix common/ includes.
9548         * location.c: Fix common/ includes.
9549         * linux-thread-db.c: Fix common/ includes.
9550         * linux-nat.c: Fix common/ includes.
9551         * linux-fork.c: Fix common/ includes.
9552         * inline-frame.c: Fix common/ includes.
9553         * infrun.c: Fix common/ includes.
9554         * inflow.c: Fix common/ includes.
9555         * inferior.h: Fix common/ includes.
9556         * inferior.c: Fix common/ includes.
9557         * infcmd.c: Fix common/ includes.
9558         * inf-ptrace.c: Fix common/ includes.
9559         * inf-child.c: Fix common/ includes.
9560         * ia64-linux-nat.c: Fix common/ includes.
9561         * i387-tdep.c: Fix common/ includes.
9562         * i386-tdep.c: Fix common/ includes.
9563         * i386-linux-tdep.c: Fix common/ includes.
9564         * i386-linux-nat.c: Fix common/ includes.
9565         * i386-go32-tdep.c: Fix common/ includes.
9566         * i386-fbsd-tdep.c: Fix common/ includes.
9567         * i386-fbsd-nat.c: Fix common/ includes.
9568         * guile/scm-type.c: Fix common/ includes.
9569         * guile/guile.c: Fix common/ includes.
9570         * go32-nat.c: Fix common/ includes.
9571         * gnu-nat.c: Fix common/ includes.
9572         * gdbthread.h: Fix common/ includes.
9573         * gdbarch-selftests.c: Fix common/ includes.
9574         * gdb_usleep.c: Fix common/ includes.
9575         * gdb_select.h: Fix common/ includes.
9576         * gdb_bfd.c: Fix common/ includes.
9577         * gcore.c: Fix common/ includes.
9578         * fork-child.c: Fix common/ includes.
9579         * findvar.c: Fix common/ includes.
9580         * fbsd-nat.c: Fix common/ includes.
9581         * event-top.c: Fix common/ includes.
9582         * event-loop.c: Fix common/ includes.
9583         * dwarf2read.c: Fix common/ includes.
9584         * dwarf2loc.c: Fix common/ includes.
9585         * dwarf2-frame.c: Fix common/ includes.
9586         * dwarf-index-cache.c: Fix common/ includes.
9587         * dtrace-probe.c: Fix common/ includes.
9588         * disasm-selftests.c: Fix common/ includes.
9589         * defs.h: Fix common/ includes.
9590         * csky-tdep.c: Fix common/ includes.
9591         * cp-valprint.c: Fix common/ includes.
9592         * cp-support.h: Fix common/ includes.
9593         * cp-support.c: Fix common/ includes.
9594         * corelow.c: Fix common/ includes.
9595         * completer.h: Fix common/ includes.
9596         * completer.c: Fix common/ includes.
9597         * compile/compile.c: Fix common/ includes.
9598         * compile/compile-loc2c.c: Fix common/ includes.
9599         * compile/compile-cplus-types.c: Fix common/ includes.
9600         * compile/compile-cplus-symbols.c: Fix common/ includes.
9601         * command.h: Fix common/ includes.
9602         * cli/cli-dump.c: Fix common/ includes.
9603         * cli/cli-cmds.c: Fix common/ includes.
9604         * charset.c: Fix common/ includes.
9605         * build-id.c: Fix common/ includes.
9606         * btrace.h: Fix common/ includes.
9607         * btrace.c: Fix common/ includes.
9608         * breakpoint.h: Fix common/ includes.
9609         * breakpoint.c: Fix common/ includes.
9610         * ax.h:
9611         (enum agent_op): Fix common/ includes.
9612         * ax-general.c (struct aop_map): Fix common/ includes.
9613         * ax-gdb.c: Fix common/ includes.
9614         * auxv.c: Fix common/ includes.
9615         * auto-load.c: Fix common/ includes.
9616         * arm-tdep.c: Fix common/ includes.
9617         * arch/riscv.c: Fix common/ includes.
9618         * arch/ppc-linux-common.c: Fix common/ includes.
9619         * arch/i386.c: Fix common/ includes.
9620         * arch/arm.c: Fix common/ includes.
9621         * arch/arm-linux.c: Fix common/ includes.
9622         * arch/arm-get-next-pcs.c: Fix common/ includes.
9623         * arch/amd64.c: Fix common/ includes.
9624         * arch/aarch64.c: Fix common/ includes.
9625         * arch/aarch64-insn.c: Fix common/ includes.
9626         * arch-utils.c: Fix common/ includes.
9627         * amd64-windows-tdep.c: Fix common/ includes.
9628         * amd64-tdep.c: Fix common/ includes.
9629         * amd64-sol2-tdep.c: Fix common/ includes.
9630         * amd64-obsd-tdep.c: Fix common/ includes.
9631         * amd64-nbsd-tdep.c: Fix common/ includes.
9632         * amd64-linux-tdep.c: Fix common/ includes.
9633         * amd64-linux-nat.c: Fix common/ includes.
9634         * amd64-fbsd-tdep.c: Fix common/ includes.
9635         * amd64-fbsd-nat.c: Fix common/ includes.
9636         * amd64-dicos-tdep.c: Fix common/ includes.
9637         * amd64-darwin-tdep.c: Fix common/ includes.
9638         * agent.c: Fix common/ includes.
9639         * ada-lang.h: Fix common/ includes.
9640         * ada-lang.c: Fix common/ includes.
9641         * aarch64-tdep.c: Fix common/ includes.
9642
9643 2019-01-25  Tom Tromey  <tom@tromey.com>
9644
9645         * common/create-version.sh: Use common/version.h.
9646
9647 2019-01-24  Pedro Alves  <palves@redhat.com>
9648
9649         * infrun.c (signal_stop, signal_print, signal_program)
9650         (signal_catch, signal_pass): Now arrays instead of pointers.
9651         (update_signals_program_target, do_target_resume)
9652         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9653         * linux-nat.c (linux_nat_target::pass_signals)
9654         (linux_nat_target::create_inferior, linux_nat_target::attach):
9655         Adjust.
9656         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9657         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9658         * procfs.c (procfs_target::pass_signals): Adjust.
9659         * record-full.c (record_full_target::resume): Adjust.
9660         * remote.c (remote_target::pass_signals)
9661         (remote_target::program_signals): Adjust.
9662         * target-debug.h (target_debug_print_signals): Now takes a
9663         gdb::array_view as parameter.  Adjust.
9664         * target.h (target_ops) <pass_signals, program_signals>: Replace
9665         pointer and length parameters with gdb::array_view.
9666         (target_pass_signals, target_program_signals): Likewise.
9667         * target-delegates.c: Regenerate.
9668
9669 2019-01-24  Pedro Alves  <palves@redhat.com>
9670
9671         * common/forward-scope-exit.h
9672         (forward_scope_exit::forward_scope_exit): Pass arguments to
9673         m_bind_function directly, instead of creating a std::bind and
9674         copying that.
9675
9676 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9677
9678         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9679         for static members.
9680         (pass_in_v_vfp_candidate): Likewise.
9681
9682 2019-01-23  Tom Tromey  <tom@tromey.com>
9683             Pedro Alves  <palves@redhat.com>
9684
9685         * regcache.c (class regcache_invalidator): Remove.
9686         (regcache::raw_write): Use make_scope_exit.
9687
9688 2019-01-23  Tom Tromey  <tom@tromey.com>
9689
9690         * ui-out.h (class ui_out_emit_type): Update comment.
9691
9692 2019-01-23  Tom Tromey  <tom@tromey.com>
9693
9694         * infrun.c (fetch_inferior_event): Update comment.
9695
9696 2019-01-23  Tom Tromey  <tom@tromey.com>
9697             Pedro Alves  <palves@redhat.com>
9698
9699         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9700         parameter.
9701         (fetch_inferior_event): Use SCOPE_EXIT.
9702
9703
9704 2019-01-23  Tom Tromey  <tom@tromey.com>
9705             Pedro Alves  <palves@redhat.com>
9706
9707         * infrun.c (disable_thread_events): Delete.
9708         (stop_all_threads): Use SCOPE_EXIT.
9709
9710 2019-01-23  Tom Tromey  <tom@tromey.com>
9711             Pedro Alves  <palves@redhat.com>
9712
9713         * symfile.c: Include forward-scope-exit.h.
9714         (clear_symtab_users_cleanup): Replace forward declaration with
9715         a FORWARD_SCOPE_EXIT.
9716         (syms_from_objfile_1): Use the forward_scope_exit and
9717         gdb::optional instead of cleanup_function.
9718         (reread_symbols): Use the forward_scope_exit instead of
9719         cleanup_function.
9720         (clear_symtab_users_cleanup): Remove function.
9721
9722 2019-01-23  Tom Tromey  <tom@tromey.com>
9723             Pedro Alves  <palves@redhat.com>
9724
9725         * linux-nat.c: Include scope-exit.h.
9726         (cleanup_target_stop): Remove.
9727         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9728         SCOPE_EXIT.
9729
9730 2019-01-23  Tom Tromey  <tom@tromey.com>
9731             Pedro Alves  <palves@redhat.com>
9732
9733         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9734         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9735
9736 2019-01-23  Tom Tromey  <tom@tromey.com>
9737             Andrew Burgess  <andrew.burgess@embecosm.com>
9738             Pedro Alves  <palves@redhat.com>
9739
9740         * infrun.c (fetch_inferior_event): Use scope_exit.
9741         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9742         * top.c (execute_command): Use scope_exit.
9743         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9744         * utils.c (do_bpstat_clear_actions_cleanup)
9745         (make_bpstat_clear_actions_cleanup): Remove.
9746
9747 2019-01-23  Tom Tromey  <tom@tromey.com>
9748             Pedro Alves  <palves@redhat.com>
9749
9750         * infrun.c: Include "common/scope-exit.h"
9751         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9752         (wait_for_inferior): Use SCOPE_EXIT.
9753         (fetch_inferior_event): Use scope_exit.
9754
9755 2019-01-23  Tom Tromey  <tom@tromey.com>
9756             Pedro Alves  <palves@redhat.com>
9757
9758         * breakpoint.c (create_breakpoint): Remove cleanup.
9759
9760 2019-01-23  Tom Tromey  <tom@tromey.com>
9761             Andrew Burgess  <andrew.burgess@embecosm.com>
9762             Pedro Alves  <palves@redhat.com>
9763
9764 2019-01-23  Pedro Alves  <palves@redhat.com>
9765
9766         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9767
9768 2019-01-23  Pedro Alves  <palves@redhat.com>
9769             Andrew Burgess  <andrew.burgess@embecosm.com>
9770
9771         * gdbthread.h: Include "common/forward-scope-exit.h".
9772         (scoped_finish_thread_state): Redefine custom class in terms of
9773         forward_scope_exit.
9774
9775 2019-01-23  Pedro Alves  <palves@redhat.com>
9776             Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * common/forward-scope-exit.h: New file.
9779
9780 2019-01-23  Pedro Alves  <palves@redhat.com>
9781             Andrew Burgess  <andrew.burgess@embecosm.com>
9782             Tom Tromey  <tom@tromey.com>
9783
9784         * common/scope-exit.h: New file.
9785
9786 2019-01-23  Pedro Alves  <palves@redhat.com>
9787
9788         * common/preprocessor.h (ESC): Rename to ...
9789         (ESC_PARENS): ... this.
9790         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9791         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9792
9793 2019-01-23  Tom Tromey  <tom@tromey.com>
9794
9795         * language.h (class scoped_switch_to_sym_language_if_auto):
9796         Initialize m_lang in both cases.
9797
9798 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9799
9800         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9801         with XCNEW.
9802
9803 2019-01-22  Tom Tromey  <tom@tromey.com>
9804
9805         * corelow.c: Do not include sys/file.h.
9806
9807 2019-01-22  Tom Tromey  <tom@tromey.com>
9808
9809         * tui/tui-wingeneral.h: Include gdb_curses.h.
9810
9811 2019-01-22  Tom Tromey  <tom@tromey.com>
9812
9813         * source-cache.h (class source_cache) <get_source_lines,
9814         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9815
9816 2019-01-22  Tom Tromey  <tom@tromey.com>
9817
9818         * remote-fileio.h (struct remote_target): Declare.
9819
9820 2019-01-22  Tom Tromey  <tom@tromey.com>
9821
9822         * python/py-arch.c: Do not include py-ref.h.
9823         * python/py-bpevent.c: Do not include py-ref.h.
9824         * python/py-cmd.c: Do not include py-ref.h.
9825         * python/py-continueevent.c: Do not include py-ref.h.
9826         * python/py-event.h: Do not include py-ref.h.
9827         * python/py-evtregistry.c: Do not include py-ref.h.
9828         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9829         * python/py-frame.c: Do not include py-ref.h.
9830         * python/py-framefilter.c: Do not include py-ref.h.
9831         * python/py-function.c: Do not include py-ref.h.
9832         * python/py-infevents.c: Do not include py-ref.h.
9833         * python/py-linetable.c: Do not include py-ref.h.
9834         * python/py-objfile.c: Do not include py-ref.h.
9835         * python/py-param.c: Do not include py-ref.h.
9836         * python/py-prettyprint.c: Do not include py-ref.h.
9837         * python/py-progspace.c: Do not include py-ref.h.
9838         * python/py-symbol.c: Do not include py-ref.h.
9839         * python/py-symtab.c: Do not include py-ref.h.
9840         * python/py-type.c: Do not include py-ref.h.
9841         * python/py-unwind.c: Do not include py-ref.h.
9842         * python/py-utils.c: Do not include py-ref.h.
9843         * python/py-value.c: Do not include py-ref.h.
9844         * python/py-varobj.c: Do not include py-ref.h.
9845         * python/py-xmethods.c: Do not include py-ref.h.
9846         * python/python.c: Do not include py-ref.h.
9847         * varobj.c: Do not include py-ref.h.
9848
9849 2019-01-22  Tom Tromey  <tom@tromey.com>
9850
9851         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9852         keyword for bcache.
9853
9854 2019-01-22  Tom Tromey  <tom@tromey.com>
9855
9856         * compile/compile-cplus-types.c: Remove a comment by #include.
9857
9858 2019-01-22  Tom Tromey  <tom@tromey.com>
9859
9860         * compile/gcc-c-plugin.h: Include compile-internal.h.
9861
9862 2019-01-22  Tom Tromey  <tom@tromey.com>
9863
9864         * stabsread.c (EXTERN): Do not define.
9865         (symnum, next_symbol_text_func, processing_gcc_compilation)
9866         (within_function, global_sym_chain, global_stabs)
9867         (previous_stab_code, this_object_header_files)
9868         (n_this_object_header_files)
9869         (n_allocated_this_object_header_files): Define.
9870         * stabsread.h (EXTERN): Never define.  Use "extern".
9871
9872 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9873
9874         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9875         history_value.
9876
9877 2019-01-21  Tom Tromey  <tom@tromey.com>
9878
9879         * ui-out.c: Fix includes.
9880         * tui/tui-source.c: Fix includes.
9881         * target.c: Fix includes.
9882         * remote.c: Fix includes.
9883         * regcache.c: Fix includes.
9884         * python/py-block.c: Fix includes.
9885         * printcmd.c: Fix includes.
9886         * or1k-tdep.c: Fix includes.
9887         * mi/mi-main.c: Fix includes.
9888         * m32r-tdep.c: Fix includes.
9889         * csky-tdep.c: Fix includes.
9890         * compile/compile-cplus-types.c: Fix includes.
9891         * cli/cli-interp.c: Fix includes.
9892
9893 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9894
9895         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9896         for padding.
9897
9898 2019-01-16  Tom Tromey  <tom@tromey.com>
9899
9900         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9901         earlier.
9902         (struct objfile) <msymbols_range>: Move from top level.
9903         <msymbols>: New method.
9904         (class objfile_msymbols): Remove.
9905         * symtab.c (default_collect_symbol_completion_matches_break_on):
9906         Update.
9907         * symmisc.c (dump_msymbols): Update.
9908         * stabsread.c (scan_file_globals): Update.
9909         * objc-lang.c (info_selectors_command, info_classes_command)
9910         (find_methods): Update.
9911         * minsyms.c (find_solib_trampoline_target): Update.
9912         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9913         * coffread.c (coff_symfile_read): Update.
9914         * ada-lang.c (ada_lookup_simple_minsym)
9915         (ada_collect_symbol_completion_matches): Update.
9916
9917 2019-01-16  Tom Tromey  <tom@tromey.com>
9918
9919         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9920         type.  Remove no-argument constructor.
9921         <iterator::operator++>: Simplify.
9922         <begin>: Update.
9923         <end>: Use minimal_symbol_count.
9924
9925 2019-01-16  Tom Tromey  <tom@tromey.com>
9926
9927         * objfiles.h (struct objfile) <psymtabs>: New method.
9928         (class objfile_psymtabs): Remove.
9929         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9930         typedef.
9931         <range>: New method.
9932         (require_partial_symbols): Change return type.
9933         * psymtab.c (require_partial_symbols)
9934         (psym_expand_symtabs_matching): Update.
9935         * mdebugread.c (parse_partial_symbols): Update.
9936         * dbxread.c (dbx_end_psymtab): Update.
9937
9938 2019-01-15  Tom Tromey  <tom@tromey.com>
9939
9940         * symtab.c (lookup_objfile_from_block)
9941         (lookup_symbol_in_objfile_symtabs)
9942         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9943         (find_line_symtab, info_sources_command)
9944         (default_collect_symbol_completion_matches_break_on)
9945         (make_source_files_completion_list): Update.
9946         * symmisc.c (print_objfile_statistics, dump_objfile)
9947         (maintenance_print_symbols, maintenance_info_symtabs)
9948         (maintenance_check_symtabs, maintenance_info_line_tables):
9949         Update.
9950         * source.c (select_source_symtab)
9951         (forget_cached_source_info_for_objfile): Update.
9952         * objfiles.h (class objfile_compunits): Remove.
9953         (struct objfile) <compunits_range>: New typedef.
9954         (compunits): New method.
9955         * objfiles.c (objfile_relocate1): Update.
9956         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9957         * maint.c (count_symtabs_and_blocks): Update.
9958         * linespec.c (iterate_over_all_matching_symtabs): Update.
9959         * cp-support.c (add_symbol_overload_list_qualified): Update.
9960         * coffread.c (coff_symtab_read): Update.
9961         * ada-lang.c (add_nonlocal_symbols)
9962         (ada_collect_symbol_completion_matches)
9963         (ada_add_global_exceptions): Update.
9964
9965 2019-01-15  Tom Tromey  <tom@tromey.com>
9966
9967         * progspace.h (program_space) <objfiles_safe_range>: New
9968         typedef.
9969         <objfiles_safe>: New method.
9970         * objfiles.h (class all_objfiles_safe): Remove.
9971         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9972         * jit.c (jit_inferior_exit_hook): Update.
9973
9974 2019-01-17  Tom Tromey  <tom@tromey.com>
9975
9976         * progspace.h (program_space) <objfiles_range>: New typedef.
9977         <objfiles>: New method.
9978         <objfiles_head>: Rename from objfiles.
9979         (object_files): Update.
9980         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9981         * guile/scm-pretty-print.c
9982         (ppscm_find_pretty_printer_from_objfiles): Update.
9983         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9984         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9985         Update.
9986         * python/py-progspace.c (pspy_get_objfiles): Update.
9987         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9988         Update.
9989         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9990         (objfpy_lookup_objfile_by_build_id): Update.
9991         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9992         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9993         Update.
9994         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9995         (expand_symtab_containing_pc, lookup_objfile_from_block)
9996         (lookup_static_symbol, basic_lookup_transparent_type)
9997         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9998         (find_line_symtab, info_sources_command)
9999         (default_collect_symbol_completion_matches_break_on)
10000         (make_source_files_completion_list, find_main_name): Update.
10001         * symmisc.c (print_symbol_bcache_statistics)
10002         (print_objfile_statistics, maintenance_print_symbols)
10003         (maintenance_print_msymbols, maintenance_print_objfiles)
10004         (maintenance_info_symtabs, maintenance_check_symtabs)
10005         (maintenance_expand_symtabs, maintenance_info_line_tables):
10006         Update.
10007         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10008         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10009         (map_overlay_command, unmap_overlay_command)
10010         (simple_overlay_update, expand_symtabs_matching)
10011         (map_symbol_filenames): Update.
10012         * symfile-debug.c (set_debug_symfile): Update.
10013         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10014         Update.
10015         * source.c (select_source_symtab, forget_cached_source_info):
10016         Update.
10017         * solib.c (solib_read_symbols): Update.
10018         * solib-spu.c (append_ocl_sos): Update.
10019         * psymtab.c (maintenance_print_psymbols)
10020         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10021         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10022         * printcmd.c (info_symbol_command): Update.
10023         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10024         Update.
10025         * objfiles.h (class all_objfiles): Remove.
10026         * objfiles.c (have_partial_symbols, have_full_symbols)
10027         (have_minimal_symbols, qsort_cmp, update_section_map)
10028         (shared_objfile_contains_address_p)
10029         (default_iterate_over_objfiles_in_search_order): Update.
10030         * objc-lang.c (info_selectors_command, info_classes_command)
10031         (find_methods): Update.
10032         * minsyms.c (find_solib_trampoline_target): Update.
10033         * maint.c (maintenance_info_sections)
10034         (maintenance_translate_address, count_symtabs_and_blocks):
10035         Update.
10036         * main.c (captured_main_1): Update.
10037         * linux-thread-db.c (try_thread_db_load_from_pdir)
10038         (has_libpthread): Update.
10039         * linespec.c (iterate_over_all_matching_symtabs)
10040         (search_minsyms_for_name): Update.
10041         * jit.c (jit_find_objf_with_entry_addr): Update.
10042         * hppa-tdep.c (find_unwind_entry)
10043         (hppa_lookup_stub_minimal_symbol): Update.
10044         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10045         Update.
10046         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10047         (elf_gnu_ifunc_resolve_by_got): Update.
10048         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10049         * dwarf-index-write.c (save_gdb_index_command): Update.
10050         * cp-support.c (add_symbol_overload_list_qualified): Update.
10051         * breakpoint.c (create_overlay_event_breakpoint)
10052         (create_longjmp_master_breakpoint)
10053         (create_std_terminate_master_breakpoint)
10054         (create_exception_master_breakpoint): Update.
10055         * blockframe.c (find_pc_partial_function): Update.
10056         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10057         (ada_collect_symbol_completion_matches)
10058         (ada_add_global_exceptions): Update.
10059
10060 2019-01-17  Tom Tromey  <tom@tromey.com>
10061
10062         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10063         declare VEC.
10064         (solib_target_parse_libraries): Change return type.
10065         (library_list_start_segment, library_list_start_section)
10066         (library_list_end_library, library_list_start_library); Update.
10067         (solib_target_free_library_list): Remove.
10068         (solib_target_parse_libraries): Remove cleanup.  Change return
10069         type.
10070         (solib_target_current_sos): Update.
10071
10072 2019-01-17  Tom Tromey  <tromey@bapiya>
10073
10074         * valprint.c: Replace "the the" with "the".
10075         * symtab.c: Replace "the the" with "the".
10076         * solib.c: Replace "the the" with "the".
10077         * solib-dsbt.c: Replace "the the" with "the".
10078         * linespec.c: Replace "the the" with "the".
10079         * dwarf2loc.h: Replace "the the" with "the".
10080         * amd64-windows-tdep.c: Replace "the the" with "the".
10081         * aarch64-tdep.c: Replace "the the" with "the".
10082
10083 2019-01-16  Keith Seitz  <keiths@redhat.com>
10084
10085         PR gdb/23773
10086         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10087         <builder>: Rename to ..
10088         <m_builder>: ... this and make private.
10089         (dwarf2_cu::get_builder): New method.  Change all users of
10090         `builder' to use this method.
10091         (dwarf2_start_symtab): Move to ...
10092         (dwarf2_cu::start_symtab): ... here.  Update all callers
10093         (setup_type_unit_groups): Move to ...
10094         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10095         callers.
10096         (dwarf2_cu::reset_builder): New method.
10097         (process_full_compunit, process_full_type_unit): Use
10098         dwarf2_cu::reset_builder.
10099         (follow_die_offset): Record the ancestor CU if it is different
10100         from the followed DIE's CU.
10101         (follow_die_sig_1): Likewise.
10102
10103 2019-01-15  Tom Tromey  <tom@tromey.com>
10104
10105         * remote.c (class remote_state) <buf>: Now a char_vector.
10106         <buf_size>: Remove.
10107         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10108         parameter.
10109         (remote_target::getpkt_or_notif_sane_1)
10110         (remote_target::getpkt_sane)
10111         (remote_target::getpkt_or_notif_sane): Likewise.
10112         (class remote_target) <putpkt>: New overload.
10113         (remote_target::read_frame): Change type of "buf_p".  Remove
10114         sizeof_p parameter.
10115         (packet_ok): New overload.
10116         (packet_check_result): New overload.
10117         Update all uses.
10118
10119 2019-01-14  Tom Tromey  <tom@tromey.com>
10120
10121         * remote-notif.c (handle_notification, remote_notif_ack)
10122         (remote_notif_parse): Make "buf" const.
10123         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10124         const.
10125         (remote_notif_parse, remote_notif_ack, handle_notification):
10126         Likewise.
10127         * remote.c (remote_notif_stop_parse): Make "buf" const.
10128         (remote_target::remote_parse_stop_reply): Make "buf" const.
10129         (remote_notif_stop_ack): Make "buf" const.
10130
10131 2019-01-14  Tom Tromey  <tom@tromey.com>
10132
10133         * remote.c (remote_console_output): Make parameter const.
10134
10135 2019-01-14  Tom Tromey  <tom@tromey.com>
10136
10137         * target-debug.h (target_debug_print_signals): Constify.
10138         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10139         * procfs.c (procfs_target::pass_signals): Update.
10140         * linux-nat.c (linux_nat_target::pass_signals): Update.
10141         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10142         * target-delegates.c: Rebuild.
10143         * remote.c (remote_target::program_signals): Update.
10144         (remote_target::pass_signals): Update.
10145         * target.c (target_pass_signals): Constify argument.
10146         (target_program_signals): Likewise.
10147         * target.h (struct target_ops) <pass_signals, program_signals>:
10148         Constify argument.
10149         (target_pass_signals, target_program_signals): Constify argument.
10150
10151 2019-01-14  Tom Tromey  <tom@tromey.com>
10152
10153         PR tui/28819:
10154         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10155
10156 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10157
10158         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10159         field.
10160         * rs6000-tdep.c: Include reggroups.h.
10161         (IS_V_ALIAS_PSEUDOREG): Define.
10162         (rs6000_register_name): Return names for the "vX" aliases.
10163         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10164         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10165         aliases.  Call default_register_reggroup_p for all other
10166         pseudo-registers.
10167         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10168         New functions.
10169         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10170         Handle "vX" aliases.
10171         (v_alias_pseudo_register_collect): New function.
10172         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10173         (rs6000_gdbarch_init): Initialize "vX" aliases as
10174         pseudo-registers.  Restore registration of
10175         rs6000_pseudo_register_reggroup_p with
10176         set_tdesc_pseudo_register_reggroup_p.
10177
10178 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10179
10180         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10181         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10182         set_gdbarch_num_pseudo_regs.
10183
10184 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10185
10186         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10187         Remove arg prefixname, add do_set and do_show.
10188         Add member functions set_list and show_list.
10189         * cli/cli-style.c (class cli_style_option): Update accordingly.
10190         (style_set_list): Move to file scope.
10191         (style_show_list): Likewise.
10192         (set_style): Call help_list.
10193         (show_style): Call cmd_show_list.
10194         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10195         Update to use the new macro.
10196
10197 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10198
10199         * ada-lang.c (_initialize_ada_language): Expand the help text
10200         for the "catch exception" command.
10201
10202 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10203
10204         * symtab.c (matching_obj_sections): Initialize obj,
10205         declare it closer to its usage.
10206
10207 2019-01-10  Tom Tromey  <tom@tromey.com>
10208
10209         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10210         (basic_inf_threads_range): Remove.
10211         (inf_threads_range, inf_non_exited_threads_range)
10212         (safe_inf_threads_range): Use next_adapter.
10213
10214 2019-01-10  Keith Seitz  <keiths@redhat.com>
10215
10216         PR gdb/23712
10217         PR symtab/23010
10218         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10219         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10220
10221 2019-01-10  Keith Seitz  <keiths@redhat.com>
10222
10223         PR gdb/23712
10224         PR symtab/23010
10225         * dictionary.c (pending_to_vector): Remove.
10226         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10227         Remove _1 suffix, replacing functions of the same name.  Update
10228         all callers.
10229         (dict_create_hashed, dict_create_hashed_expandable)
10230         (dict_create_linear, dict_create_linear_expandable, dict_free)
10231         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10232         Make functions static.
10233
10234 2019-01-10  Keith Seitz  <keiths@redhat.com>
10235
10236         PR gdb/23712
10237         PR symtab/23010
10238         * dictionary.h (struct dictionary): Replace declaration with
10239         multidictionary.
10240         (dict_create_hashed, dict_create_hashed_expandable)
10241         (dict_create_linear, dict_create_linear_expandable)
10242         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10243         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10244         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10245         taking multidictionary argument.
10246         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10247         * block.h (struct block) <dict>: Change to multidictionary
10248         and rename `multidict'.
10249         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10250         symmisc.c: Update all dictionary references to multidictionary.
10251
10252 2019-01-10  Keith Seitz  <keiths@redhat.com>
10253
10254         PR gdb/23712
10255         PR symtab/23010
10256         * dictionary.c: Include unordered_map.
10257         (pending_to_vector): New function.
10258         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10259         Rewrite the non-"_1" functions to take vector instead
10260         of linked list.
10261         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10262         "new" _1 versions of the same name.
10263         (multidictionary): Define.
10264         (std::hash<enum language): New definition.
10265         (collate_pending_symbols_by_language, mdict_create_hashed)
10266         (mdict_create_hashed_expandable, mdict_create_linear)
10267         (mdict_create_linear_expandable, mdict_free)
10268         (find_language_dictionary, create_new_language_dictionary)
10269         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10270         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10271         (mdict_size, mdict_empty): New functions.
10272         * dictionary.h (mdict_iterator): Define.
10273
10274 2019-01-10  Pedro Alves  <palves@redhat.com>
10275
10276         * breakpoint.c (read_uploaded_action)
10277         (create_tracepoint_from_upload): Adjust to use
10278         gdb::unique_xmalloc_ptr.
10279         * ctf.c (ctf_write_uploaded_tp):
10280         (SET_ARRAY_FIELD): Use emplace_back.
10281         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10282         * tracefile-tfile.c (tfile_write_uploaded_tp):
10283         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10284         gdb::unique_xmalloc_ptr.
10285         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10286         at_string, cond_string, cmd_strings>: Replace char pointers
10287         with gdb::unique_xmalloc_ptr.
10288
10289 2019-01-10  Pedro Alves  <palves@redhat.com>
10290
10291         * solib-target.c (library_list_start_library): Don't xstrdup name.
10292
10293 2019-01-10  Pedro Alves  <palves@redhat.com>
10294
10295         * mdebugread.c (parse_partial_symbols): Use
10296         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10297
10298 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10299
10300         * linux-fork.c (scoped_switch_fork_info)
10301         <~scoped_switch_fork_info>: Fix incorrect variable name.
10302
10303 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10304
10305         * linux-fork.c (scoped_switch_fork_info)
10306         <scoped_switch_fork_info>: Make explicit.
10307         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10308
10309 2019-01-10  Tom Tromey  <tom@tromey.com>
10310
10311         * objfiles.h (objfile::reset_psymtabs): Update.
10312         * objfiles.c (objfile::objfile): Update.
10313         * psymtab.h (psymtab_storage::obstack): Update.
10314         (psymtab_storage::m_obstack): Use gdb::optional.
10315         (class psymtab_storage): Update comment.  Remove objfile
10316         parameter.
10317         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10318
10319 2019-01-10  Tom Tromey  <tom@tromey.com>
10320
10321         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10322         <free_psymtabs>: Now private.
10323         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10324         (allocate_psymtab): Use new method.
10325
10326 2019-01-10  Tom Tromey  <tom@tromey.com>
10327
10328         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10329         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10330         * mdebugread.c (parse_partial_symbols): Use
10331         allocate_dependencies.
10332         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10333         allocate_dependencies.
10334         (process_psymtab_comp_unit_reader)
10335         (build_type_psymtab_dependencies): Likewise.
10336         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10337
10338 2019-01-10  Tom Tromey  <tom@tromey.com>
10339
10340         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10341         PSYMBOL_SET_LANGUAGE.
10342         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10343
10344 2019-01-10  Tom Tromey  <tom@tromey.com>
10345
10346         * psymtab.h (psymtab_storage::obstack): New method.
10347         <m_obstack>: Rename from obstack; now private.
10348         * psymtab.c (psymtab_storage): Update.
10349         * dwarf2read.c (create_addrmap_from_index)
10350         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10351         Update.
10352
10353 2019-01-10  Tom Tromey  <tom@tromey.com>
10354
10355         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10356         * objfiles.h (objfile::reset_psymtabs): New method.
10357
10358 2019-01-10  Tom Tromey  <tom@tromey.com>
10359
10360         * symmisc.c (print_symbol_bcache_statistics): Update.
10361         (print_objfile_statistics): Update.
10362         * symfile.c (reread_symbols): Update.
10363         * psymtab.h (class psymtab_storage): New.
10364         * psymtab.c (psymtab_storage): New constructor.
10365         (~psymtab_storage): New destructor.
10366         (require_partial_symbols): Update.
10367         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10368         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10369         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10370         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10371         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10372         (start_psymtab_common, end_psymtab_common)
10373         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10374         (allocate_psymtab): Update.
10375         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10376         Update.
10377         (dump_psymtab_addrmap, maintenance_print_psymbols)
10378         (maintenance_check_psymtabs): Update.
10379         (class objfile_psymtabs): Move to objfiles.h.
10380         * psympriv.h (discard_psymtab): Now inline.
10381         (psymtab_discarder::psymtab_discarder): Update.
10382         (psymtab_discarder::~psymtab_discarder): Update.
10383         (ALL_OBJFILE_PSYMTABS): Rewrite.
10384         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10385         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10386         Remove fields.
10387         <partial_symtabs>: New field.
10388         (class objfile_psymtabs): Move from psymtab.h.  Update.
10389         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10390         psymbol_cache.
10391         (objfile::~objfile): Don't destroy psymbol_cache.
10392         * mdebugread.c (parse_partial_symbols): Update.
10393         * dwarf2read.c (create_addrmap_from_index)
10394         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10395         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10396         (add_partial_subprogram, dwarf2_ranges_read): Update.
10397         * dwarf-index-write.c (write_address_map)
10398         (write_one_signatured_type, recursively_write_psymbols)
10399         (class debug_names, class debug_names, write_psymtabs_to_index):
10400         Update.
10401
10402 2019-01-10  Tom Tromey  <tom@tromey.com>
10403
10404         * symtab.h (SYMBOL_SET_NAMES): Update.
10405         (symbol_set_names): Update.
10406         (MSYMBOL_SET_NAMES): Update.
10407         * symtab.c (symbol_set_names): Change argument to be an
10408         objfile_per_bfd_storage.
10409         * psymtab.c (add_psymbol_to_bcache): Update.
10410         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10411
10412 2019-01-10  Tom Tromey  <tom@tromey.com>
10413
10414         * symtab.c (create_demangled_names_hash): Change argument to be an
10415         objfile_per_bfd_storage.
10416         (symbol_set_names): Update.
10417
10418 2019-01-10  Tom Tromey  <tom@tromey.com>
10419
10420         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10421         init_psymbol_list.
10422         * psymtab.c (init_psymbol_list): Do nothing if already called.
10423         * psympriv.h (init_psymbol_list): Add comment.
10424         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10425         init_psymbol_list.
10426         * dbxread.c (dbx_symfile_read): Unconditionally call
10427         init_psymbol_list.
10428
10429 2019-01-10  Tom Tromey  <tom@tromey.com>
10430
10431         * xcoffread.c (scan_xcoff_symtab): Update.
10432         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10433         "where".
10434         * mdebugread.c (parse_partial_symbols)
10435         (handle_psymbol_enumerators): Update.
10436         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10437         * dbxread.c (read_dbx_symtab): Update.
10438         * psympriv.h (psymbol_placement): New enum.
10439         (add_psymbol_to_list): Update.
10440
10441 2019-01-10  Tom Tromey  <tom@tromey.com>
10442
10443         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10444         static_psymbols parameters.
10445         (scan_xcoff_symtab): Update.
10446         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10447         static_psymbols parameters.
10448         * psympriv.h (start_psymtab_common): Update.
10449         * mdebugread.c (parse_partial_symbols): Update.
10450         * dwarf2read.c (create_partial_symtab): Update.
10451         * dbxread.c (read_dbx_symtab): Update.
10452         (start_psymtab): Remove global_psymbols and static_psymbols
10453         parameters.
10454
10455 2019-01-10  Tom Tromey  <tom@tromey.com>
10456
10457         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10458         * psymtab.c (allocate_psymtab): Add comment.
10459         * psympriv.h (allocate_psymtab): Add comment.
10460         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10461         initializations.
10462         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10463
10464 2019-01-10  Tom Tromey  <tom@tromey.com>
10465
10466         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10467         Don't declare.
10468         * mipsread.c: Include mdebugread.h.
10469         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10470         Declare.
10471         * elfread.c: Include mdebugread.h.
10472
10473 2019-01-09  Tom Tromey  <tom@tromey.com>
10474
10475         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10476         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10477         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10478         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10479         (psym_lookup_symbol, psym_find_last_source_symtab)
10480         (psym_forget_cached_source_info, psym_print_stats)
10481         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10482         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10483         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10484         (psym_find_compunit_symtab_by_address)
10485         (maintenance_print_psymbols, maintenance_info_psymtabs)
10486         (maintenance_check_psymtabs): Use ranged for.
10487         * psymtab.h (class objfile_psymtabs): New.
10488         (require_partial_symbols): Return objfile_psymtabs.
10489         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10490
10491 2019-01-09  Tom Tromey  <tom@tromey.com>
10492
10493         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10494         (find_pc_mapped_section, list_overlays_command)
10495         (map_overlay_command, unmap_overlay_command)
10496         (simple_overlay_update): Use all_objfiles.
10497         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10498         * printcmd.c (info_symbol_command): Use all_objfiles.
10499         * objfiles.h (ALL_OBJSECTIONS): Remove.
10500         * maint.c (maintenance_translate_address): Use all_objfiles.
10501         * gcore.c (gcore_create_callback): Use all_objfiles.
10502         (objfile_find_memory_regions): Likewise.
10503
10504 2019-01-09  Tom Tromey  <tom@tromey.com>
10505
10506         * symtab.c (find_line_symtab, info_sources_command)
10507         (make_source_files_completion_list): Use objfile_compunits.
10508         * source.c (select_source_symtab): Use objfile_compunits.
10509         * objfiles.h (struct objfile): Update comment.
10510         (ALL_OBJFILES): Remove.
10511         (ALL_FILETABS): Remove.
10512         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10513         objfile_compunits.
10514
10515 2019-01-09  Tom Tromey  <tom@tromey.com>
10516
10517         * symmisc.c (print_objfile_statistics, dump_objfile)
10518         (maintenance_print_symbols): Use compunit_filetabs.
10519         * source.c (forget_cached_source_info_for_objfile): Use
10520         compunit_filetabs.
10521         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10522         (ALL_FILETABS): Use compunit_filetabs.
10523         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10524         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10525
10526 2019-01-09  Tom Tromey  <tom@tromey.com>
10527
10528         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10529         (compunit_filetabs): New.
10530         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10531         compunit_filetabs.
10532         (info_sources_command, make_source_files_completion_list): Remove
10533         declaration.
10534         * symmisc.c (print_objfile_statistics, dump_objfile)
10535         (maintenance_print_symbols): Remove declaration.
10536         (maintenance_info_symtabs): Use compunit_filetabs.
10537         (maintenance_info_line_tables): Likewise.
10538         * source.c (select_source_symtab): Change local variable name.
10539         (forget_cached_source_info_for_objfile): Remove declaration.
10540         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10541         * objfiles.c (objfile_relocate1): Remove declaration.
10542         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10543         declaration.
10544         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10545         * coffread.c (coff_symtab_read): Remove declaration.
10546         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10547         compunit_filetabs.
10548
10549 2019-01-09  Tom Tromey  <tom@tromey.com>
10550
10551         * symtab.c (lookup_objfile_from_block)
10552         (find_pc_sect_compunit_symtab, search_symbols)
10553         (default_collect_symbol_completion_matches_break_on): Use
10554         objfile_compunits.
10555         * objfiles.h (ALL_COMPUNITS): Remove.
10556         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10557         * cp-support.c (add_symbol_overload_list_qualified): Use
10558         objfile_compunits.
10559         * ada-lang.c (ada_collect_symbol_completion_matches)
10560         (ada_add_global_exceptions): Use objfile_compunits.
10561
10562 2019-01-09  Tom Tromey  <tom@tromey.com>
10563
10564         * source.c (select_source_symtab)
10565         (forget_cached_source_info_for_objfile): Remove declaration.
10566         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10567         declaration.
10568         * maint.c (count_symtabs_and_blocks): Remove declaration.
10569         * cp-support.c (add_symbol_overload_list_qualified): Remove
10570         declaration.
10571         * coffread.c (coff_symtab_read): Remove declaration.
10572         * symtab.c (lookup_symbol_in_objfile_symtabs)
10573         (basic_lookup_transparent_type_1): Use objfile_compunits.
10574         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10575         (info_sources_command, search_symbols)
10576         (default_collect_symbol_completion_matches_break_on)
10577         (make_source_files_completion_list): Remove declaration.
10578         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10579         (ada_collect_symbol_completion_matches)
10580         (ada_add_global_exceptions): Remove declaration.
10581         * linespec.c (iterate_over_all_matching_symtabs): Use
10582         objfile_compunits.
10583         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10584         (class objfile_compunits): New.
10585         (ALL_COMPUNITS): Use objfile_compunits.
10586         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10587         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10588         objfile_compunits.
10589         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10590
10591 2019-01-09  Tom Tromey  <tom@tromey.com>
10592
10593         * symtab.c (search_symbols)
10594         (default_collect_symbol_completion_matches_break_on): Use
10595         objfile_msymbols.
10596         * ada-lang.c (ada_lookup_simple_minsym)
10597         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10598         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10599         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10600         objfile_msymbols.
10601         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10602         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10603         * objc-lang.c (find_methods): Use objfile_msymbols.
10604         (info_selectors_command, info_classes_command): Likewise.
10605         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10606         * objfiles.h (class objfile_msymbols): New.
10607         (ALL_OBJFILE_MSYMBOLS): Remove.
10608         (ALL_MSYMBOLS): Remove.
10609
10610 2019-01-09  Tom Tromey  <tom@tromey.com>
10611
10612         * common/next-iterator.h (next_adapter): Add Iterator template
10613         parameter.
10614         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10615         (class all_objfiles_safe): New.
10616         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10617         * objfiles.c (put_objfile_before): Update comment.
10618         (add_separate_debug_objfile): Likewise.
10619         (free_all_objfiles): Use all_objfiles_safe.
10620         (objfile_purge_solibs): Likewise.
10621
10622 2019-01-09  Tom Tromey  <tom@tromey.com>
10623
10624         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10625         (expand_symtab_containing_pc, lookup_static_symbol)
10626         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10627         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10628         all_objfiles.
10629         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10630         * breakpoint.c (create_overlay_event_breakpoint)
10631         (create_longjmp_master_breakpoint)
10632         (create_std_terminate_master_breakpoint)
10633         (create_exception_master_breakpoint): Use all_objfiles.
10634         * linux-thread-db.c (try_thread_db_load_from_pdir)
10635         (has_libpthread): Use all_objfiles.
10636         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10637         * linespec.c (iterate_over_all_matching_symtabs)
10638         (search_minsyms_for_name): Use all_objfiles.
10639         * maint.c (maintenance_info_sections): Use all_objfiles.
10640         * main.c (captured_main_1): Use all_objfiles.
10641         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10642         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10643         * guile/scm-pretty-print.c
10644         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10645         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10646         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10647         (maintenance_print_msymbols): Use all_objfiles.
10648         * source.c (select_source_symtab): Use all_objfiles.
10649         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10650         * symfile.c (remove_symbol_file_command)
10651         (expand_symtabs_matching, map_symbol_filenames): Use
10652         all_objfiles.
10653         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10654         all_objfiles.
10655         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10656         * objc-lang.c (find_methods): Use all_objfiles.
10657         * objfiles.c (have_partial_symbols, have_full_symbols)
10658         (have_minimal_symbols, qsort_cmp)
10659         (default_iterate_over_objfiles_in_search_order): Use
10660         all_objfiles.
10661         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10662         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10663         (maintenance_check_psymtabs): Use all_objfiles.
10664         (ALL_PSYMTABS): Remove.
10665         * compile/compile-object-run.c (do_module_cleanup): Use
10666         all_objfiles.
10667         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10668         * cp-support.c (add_symbol_overload_list_qualified): Use
10669         all_objfiles.
10670         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10671         Use all_objfiles.
10672         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10673         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10674         all_objfiles.
10675         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10676         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10677         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10678         Uses all_objfiles.
10679         * solib.c (solib_read_symbols): Use all_objfiles
10680
10681 2019-01-09  Tom Tromey  <tom@tromey.com>
10682
10683         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10684         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10685         all_objfiles.
10686         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10687         * symmisc.c (print_symbol_bcache_statistics)
10688         (print_objfile_statistics, maintenance_print_objfiles)
10689         (maintenance_info_symtabs, maintenance_check_symtabs)
10690         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10691         all_objfiles.
10692         * source.c (forget_cached_source_info): Use all_objfiles.
10693         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10694         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10695         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10696         * objfiles.c (update_section_map): Use all_objfiles.
10697         (shared_objfile_contains_address_p): Likewise.
10698         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10699         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10700
10701 2019-01-09  Tom Tromey  <tom@tromey.com>
10702
10703         * common/next-iterator.h: New file.
10704         * objfiles.h (class all_objfiles): New.
10705         (struct objfile_iterator): New.
10706
10707 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10708
10709         * NEWS: Move the description of the changed "frame", "select-frame",
10710          and "info frame" commands to the Changed commands section.
10711
10712 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10713
10714         * gdbtypes.c (check_stub_method_group): Remove handling of old
10715         mangling schemes.
10716         * linespec.c (find_methods): Likewise.
10717         * stabsread.c (read_member_functions): Likewise.
10718         * valops.c (search_struct_method): Likewise.
10719         (value_struct_elt_for_reference): Likewise.
10720         * NEWS: Mention this change.
10721
10722 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10723
10724         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10725         print_source_lines.
10726         * source.c (print_source_lines_base): Update line number check.
10727         (print_source_lines): New function.
10728         (source_lines_range::source_lines_range): New function.
10729         * source.h (class source_lines_range): New class.
10730         (print_source_lines): New declaration.
10731
10732 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10733
10734         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10735
10736 2019-01-08  Tom Tromey  <tom@tromey.com>
10737             Simon Marchi  <simon.marchi@ericsson.com>
10738
10739         PR gdb/24060
10740         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10741         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10742         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10743         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10744         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10745         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10746
10747 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10748
10749         * source.c (select_source_symtab): Move header comment to
10750         declaration in source.h.
10751         (forget_cached_source_info_for_objfile): Likewise.
10752         (forget_cached_source_info): Likewise.
10753         (identify_source_line): Likewise.
10754         * source.h (identify_source_line): Move declaration from symtab.h
10755         and add comment from source.c
10756         (print_source_lines): Likewise.
10757         (forget_cached_source_info_for_objfile): Likewise.
10758         (forget_cached_source_info): Likewise.
10759         (select_source_symtab): Likewise.
10760         (enum print_source_lines_flag): Move definition from symtab.h.
10761         * symtab.h (identify_source_line): Move declaration to source.h.
10762         (print_source_lines): Likewise.
10763         (forget_cached_source_info_for_objfile): Likewise.
10764         (forget_cached_source_info): Likewise.
10765         (select_source_symtab): Likewise.
10766         (enum print_source_lines_flag): Move definition to source.h.
10767         * tui/tui-hooks.c: Add 'source.h' include.
10768
10769 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10770
10771         * source.c (print_source_lines_base): Handle requests to print
10772         reverse line number sequences, and guard against empty lines
10773         string.
10774
10775 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10776
10777         * source.c (print_source_lines_base): Fix skip of '\r' if next
10778         character is '\n'.
10779
10780 2019-01-06  Tom Tromey  <tom@tromey.com>
10781
10782         * c-exp.y (struct c_parse_state) <macro_original_text,
10783         expansion_obstack>: New member.
10784         (macro_original_text, expansion_obstack): Remove globals.
10785         (scan_macro_expansion, scanning_macro_expansion)
10786         (finished_macro_expansion): Update.
10787         (scan_macro_cleanup): Remove.
10788         (yylex, c_parse): Update.
10789
10790 2019-01-06  Tom Tromey  <tom@tromey.com>
10791
10792         * c-exp.y (struct c_parse_state) <strings>: New member.
10793         (operator_stoken): Update.
10794
10795 2019-01-06  Tom Tromey  <tom@tromey.com>
10796
10797         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10798         (union type_stack_elt) <typelist_val>: Now a pointer to
10799         std::vector.
10800         (type_stack_cleanup): Don't declare.
10801         (push_typelist): Update.
10802         * parse.c (pop_typelist): Return a std::vector.
10803         (push_typelist): Take a std::vector.
10804         (follow_types): Update.  Do not free args.
10805         (type_stack_cleanup): Remove.
10806         * c-exp.y (struct c_parse_state): New.
10807         (cpstate): New global.
10808         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10809         (nonempty_typelist): Update.
10810         (func_mod): Create a new vector.
10811         (c_parse): Create a c_parse_state.
10812         (check_parameter_typelist): Do not delete params.
10813         (function_method): Update.  Do not delete type_list.
10814
10815 2019-01-06  Tom Tromey  <tom@tromey.com>
10816
10817         PR gdb/28155:
10818         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10819         check_typedef.
10820         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10821         (print_return_value): Likewise.
10822
10823 2019-01-05  Tom Tromey  <tom@tromey.com>
10824
10825         * contrib/cleanup_check.py: Remove.
10826         * contrib/gcc-with-excheck: Remove.
10827         * contrib/exsummary.py: Remove.
10828         * contrib/excheck.py: Remove.
10829
10830 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10831
10832         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10833         NULL. Initialize tpprev to NULL instead of assigning it
10834         to NULL on the next statement.
10835         * windows-nat.c (windows_delete_thread): Remove check for
10836         main_thread_id before printing thread exit notifications.
10837         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10838         Remove thread ID check against main_thread_id.
10839         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10840         windows_delete_thread.
10841         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10842
10843 2019-01-04  Tom Tromey  <tom@tromey.com>
10844
10845         * compile/compile.c (_initialize_compile): Use upper case for
10846         metasyntactic variables.
10847         * symmisc.c (_initialize_symmisc): Use upper case for
10848         metasyntactic variables.
10849         * psymtab.c (_initialize_psymtab): Use upper case for
10850         metasyntactic variables.
10851         * demangle.c (demangle_command): Use upper case for metasyntactic
10852         variables.
10853         (_initialize_demangler): Likewise.
10854         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10855         variables.
10856
10857 2019-01-03  Tom Tromey  <tom@tromey.com>
10858
10859         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10860
10861 2019-01-03  Tom Tromey  <tom@tromey.com>
10862
10863         * python/py-symtab.c (salpy_str): Update.
10864         (struct salpy_sal_object) <symtab>: Now a PyObject.
10865         (salpy_dealloc): Update.
10866         (del_objfile_sal): Use gdbpy_ref.
10867
10868 2019-01-03  Tom Tromey  <tom@tromey.com>
10869
10870         * python/py-type.c (convert_field): Use new_reference.  Return
10871         gdbpy_ref.
10872         (make_fielditem): Return gdbpy_ref.
10873         (typy_fields): Update.
10874         (typy_getitem): Update.
10875         (field_name): Return gdbpy_ref.  Use new_reference.
10876         (typy_iterator_iternext): Update.
10877
10878 2019-01-03  Tom Tromey  <tom@tromey.com>
10879
10880         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10881
10882 2019-01-03  Tom Tromey  <tom@tromey.com>
10883
10884         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10885         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10886         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10887         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10888         (pspy_set_type_printers): Likewise.
10889         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10890         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10891         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10892         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10893         (objfpy_set_type_printers): Likewise.
10894
10895 2019-01-03  Tom Tromey  <tom@tromey.com>
10896
10897         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10898         (gdbpy_print_stack): Use gdbpy_err_fetch.
10899         * python/python-internal.h (class gdbpy_err_fetch): New class.
10900         (class gdbpy_enter) <m_error_type, m_error_value,
10901         m_error_traceback>: Remove.
10902         <m_error>: New member.
10903         (gdbpy_exception_to_string): Don't declare.
10904         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10905         * python/py-value.c (convert_value_from_python): Use
10906         gdbpy_err_fetch.
10907         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10908         gdbpy_exception_to_string.
10909         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10910         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10911         gdbpy_err_fetch.
10912
10913 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10914
10915         * linux-nat.c (delete_lwp_cleanup): Delete.
10916         (struct lwp_deleter): New struct.
10917         (lwp_info_up): New typedef.
10918         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10919         lwp_info_up.
10920
10921 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10922
10923         * linux-fork.c (class scoped_switch_fork_info): New class.
10924         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10925
10926 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10927
10928         * valops.c (find_overload_match): Remove use of null_cleanup, and
10929         calls to do_cleanups.
10930
10931 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10932
10933         * compile/compile-cplus-types.c
10934         (compile_cplus_instance::decl_name): Handle changes to
10935         cp_func_name.
10936         * cp-support.c (cp_func_name): Update header comment, update
10937         return type.
10938         * cp-support.h (cp_func_name): Update return type in declaration.
10939         * valops.c (find_overload_match): Move temp_func local to top
10940         level of function and change its type.  Use temp_func to hold and
10941         delete temporary string obtained from cp_func_name.
10942
10943 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10944
10945         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10946         gdb::char_vector, remove cleanup, and update uses of `msg`.
10947
10948 2019-01-03  Jim Wilson  <jimw@sifive.com>
10949
10950         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10951
10952 2019-01-02  Tom Tromey  <tom@tromey.com>
10953
10954         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10955         (tdesc_parse_xml): Remove cleanups.
10956         * target-descriptions.h (make_cleanup_free_target_description):
10957         Don't declare.
10958         (target_desc_deleter): New struct.
10959         (target_desc_up): New typedef.
10960         * target-descriptions.c (target_desc_deleter::operator()): Rename
10961         from free_target_description.
10962         (make_cleanup_free_target_description): Remove.
10963
10964 2019-01-02  Tom Tromey  <tom@tromey.com>
10965
10966         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10967         constructor, destructor.
10968         (linespec_parser): Remove typedef.
10969         (~linespec_parser): Rename from linespec_parser_delete.
10970         (linespec_lex_to_end, linespec_complete_label)
10971         (linespec_complete): Update.
10972         (decode_line_full): Remove cleanups.
10973         (decode_line_1): Update.
10974
10975 2019-01-02  Tom Tromey  <tom@tromey.com>
10976
10977         * python/python-internal.h (inferior_to_inferior_object): Change
10978         return type.
10979         * python/py-exitedevent.c (create_exited_event_object): Update.
10980         * python/py-inferior.c (inferior_to_inferior_object): Return
10981         gdbpy_ref.
10982         (python_new_inferior, python_inferior_deleted)
10983         (thread_to_thread_object, delete_thread_object)
10984         (build_inferior_list, gdbpy_selected_inferior): Update.
10985         * python/py-infthread.c (create_thread_object): Update.  Also fail
10986         if inferior_to_inferior_object fails.
10987
10988 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10989
10990         * inferior.h (class inferior) <displaced_step_state>: New field.
10991         * infrun.h (struct displaced_step_state): Move here from
10992         infrun.c.  Initialize fields, add constructor.
10993         <inf>: Remove field.
10994         <reset>: New method.
10995         * infrun.c (struct displaced_step_inferior_state): Move to
10996         infrun.h.
10997         (displaced_step_inferior_states): Remove.
10998         (get_displaced_stepping_state): Adust.
10999         (displaced_step_in_progress_any_inferior): Adjust.
11000         (displaced_step_in_progress_thread): Adjust.
11001         (displaced_step_in_progress): Adjust.
11002         (add_displaced_stepping_state): Remove.
11003         (get_displaced_step_closure_by_addr): Adjust.
11004         (remove_displaced_stepping_state): Remove.
11005         (infrun_inferior_exit): Call displaced_step_state.reset.
11006         (use_displaced_stepping): Don't check for NULL.
11007         (displaced_step_prepare_throw): Call
11008         get_displaced_stepping_state.
11009         (displaced_step_fixup): Don't check for NULL.
11010         (prepare_for_detach): Don't check for NULL.
11011
11012 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11013
11014         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11015          in case of call that did not complete.
11016
11017 2019-01-02  Andrey Utkin  <autkin@undo.io>
11018
11019         * symfile.c (find_separate_debug_file): Fix search of debug files for
11020         remote debuggee.
11021
11022 2019-01-02  Tom Tromey  <tom@tromey.com>
11023
11024         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11025         indentation.
11026         * python/py-frame.c (frapy_older): Remove cast.
11027         (frapy_newer): Likewise.
11028         * python/py-breakpoint.c (local_setattro): Remove cast.
11029         * python/py-arch.c (archpy_name): Remove local variable.
11030         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11031
11032 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11033
11034         * unittests/basic_string_view/element_access/char/empty.cc:
11035         Fix year range in copyright header.
11036
11037 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11038
11039         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11040         Delete.
11041         <operator==>: Update with for removed field.
11042         <hash>: Likewise.
11043         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11044         <isa_features>: ...this.
11045         <abi_features>: New field.
11046         (riscv_isa_flen): Update comment.
11047         (riscv_abi_xlen): New declaration.
11048         (riscv_abi_flen): New declaration.
11049         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11050         isa_features.
11051         (riscv_abi_xlen): New function.
11052         (riscv_isa_flen): Update to get answer from isa_features.
11053         (riscv_abi_flen): New function.
11054         (riscv_has_fp_abi): Update to get answer from abi_features.
11055         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11056         xlen and flen.
11057         (riscv_call_info) <xlen, flen>: Update comment.
11058         (riscv_call_arg_struct): Remove invalid assertions
11059         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11060         is removed.
11061         (riscv_gdbarch_init): Gather isa features and abi features
11062         separately, ensure both match on the gdbarch when reusing an old
11063         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11064         a target with 64-bit float hardware.
11065
11066 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11067
11068         * source.c (search_command_helper): Stop reverse search
11069         when line 1 has been searched.
11070
11071 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11072
11073         * record-full.c (record_full_base_target::close): Rewrite
11074         record_full_core_buf_list free logic.
11075
11076 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11077
11078         * break-catch-syscall.c (print_one_catch_syscall): xfree
11079         the last text.
11080
11081 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11082
11083         * top.c (print_gdb_version): Update Copyright year in version
11084         message.
11085
11086 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11087
11088         Update copyright year range in all GDB files.
11089
11090 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11091
11092         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11093
11094 For older changes see ChangeLog-2018.
11095 \f
11096 Local Variables:
11097 mode: change-log
11098 left-margin: 8
11099 fill-column: 74
11100 version-control: never
11101 coding: utf-8
11102 End:
11103