gdb/ChangeLog

   1 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
   4         conversion of gdb_datadir.
   5         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
   6         remove not needed c_str ().
   7
   8 2019-09-30  Ali Tamur <tamur@google.com>
   9
  10         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
  11         (dwarf2_string_attr): Likewise.
  12
  13 2019-09-30  Ali Tamur <tamur@google.com>
  14
  15         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
  16         (process_full_type_unit): Likewise.
  17         (dump_die_shallow): Likewise.
  18         (cu_debug_loc_section): Likewise.
  19
  20 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
  21
  22         * minsyms.c (compare_minimal_symbols): Rename to...
  23         (minimal_symbol_is_less_than): ...this, and adjust to STL
  24         conventions (return bool, take arguments as references)
  25         (minimal_symbol_reader::install): Call std::sort instead
  26         of qsort.
  27
  28 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
  31         hash and why.
  32         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
  33         msymbol_hash, msymbol_demangled_hash>: Improve comments.
  34
  35 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
  36
  37         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
  38         * psympriv.h (add_psymbol_to_list): Move comment here and update
  39         it.
  40
  41 2019-09-29  Tom de Vries  <tdevries@suse.de>
  42
  43         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  44         Use $tmpdir/$(basename "$output_file").dwz instead of
  45         "${output_file}.dwz".
  46
  47 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  48
  49         PR gdb/25045
  50         * hppa-linux-nat.c: Include gdbarch.h.
  51
  52 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  53
  54         * blockframe.c (find_pc_partial_function): Change return type to bool.
  55         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  56         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  57         (stub_gnu_ifunc_resolve_name): Likewise.
  58         * symtab.c (compare_filenames_for_search): Likewise.
  59         (compare_glob_filenames_for_search): Likewise.
  60         (matching_obj_sections): Likewise.
  61         (symbol_matches_domain): Likewise.
  62         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  63         (find_line_pc): Change return type to bool.
  64         (find_line_pc_range): Likewise.
  65         (producer_is_realview): Likewise.
  66         * symtab.h (symbol_matches_domain): Likewise.
  67         (find_pc_partial_function): Likewise.
  68         (find_pc_line_pc_range): Likewise.
  69         (in_gnu_ifunc_stub): Likewise.
  70         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
  71         (find_line_pc): Likewise.
  72         (find_line_pc_range): Likewise.
  73         (matching_obj_sections): Likewise.
  74         (find_line_symtab): Change out parameter to bool.
  75         (producer_is_realview): Change return type to bool.
  76         (compare_filenames_for_search): Likewise.
  77         (compare_glob_filenames_for_search): Likewise.
  78
  79 2019-09-26  Tom Tromey  <tom@tromey.com>
  80
  81         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
  82         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
  83         * gdb_usleep.h: Remove.
  84         * gdb_usleep.c: Remove.
  85         * utils.c: Don't include gdb_usleep.h.
  86
  87 2019-09-26  Tom Tromey  <tromey@adacore.com>
  88
  89         * python/py-type.c (type_to_type_object): Call check_typedef
  90         for stub types.
  91
  92 2019-09-26  Tom Tromey  <tom@tromey.com>
  93
  94         * utils.h (initialize_utils): Don't declare.
  95         * top.c (gdb_init): Don't call initialize_utils.
  96         * utils.c (initialize_utils): Remove.  Move contents...
  97         (_initialize_utils): ... here.
  98
  99 2019-09-25  Tom Tromey  <tom@tromey.com>
 100
 101         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 102         * utils.h (make_hex_string): Don't declare.
 103         * utils.c (make_hex_string): Remove.
 104
 105 2019-09-24  Tom de Vries  <tdevries@suse.de>
 106
 107         PR gdb/23815
 108         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 109         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 110
 111 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 112
 113         * NEWS: Mention new simulator port for PRU.
 114
 115 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * ada-exp.y (write_object_remaining): Update.
 118         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 119         and eliminate the static buffer.
 120         (ada_decode_symbol): Update.
 121         (ada_la_decode): Update.
 122         (ada_sniff_from_mangled_name): Update.
 123         (is_valid_name_for_wild_match): Update.
 124         (ada_lookup_name_info::matches): Update and simplify.
 125         (name_matches_regex): Update.
 126         (ada_add_global_exceptions): Update.
 127         * ada-lang.h (ada_decode): Update signature.
 128         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 129         * dwarf-index-write.c (debug_names::insert): Update.
 130
 131 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 132
 133         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 134         formatting.
 135
 136 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 137
 138         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 139         Change "nonzero" to "true" in documentation.
 140
 141 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 142
 143         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 144         (_initialize_darwin_solib): Don't set
 145         darwin_so_ops.lookup_lib_global_symbol.
 146         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 147         set_gdbarch_iterate_over_objfiles_in_search_order.
 148         (elf_lookup_lib_symbol): Rename to...
 149         (svr4_iterate_over_objfiles_in_search_order): this, and update
 150         to iterate semantics.
 151         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 152         * solib.c (solib_global_lookup): Remove.
 153         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 154         (solib_global_lookup): Remove.
 155         * symtab.c (lookup_global_or_static_symbol): Remove call to
 156         solib_global_lookup.
 157
 158 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 159
 160         * NEWS: Move entries about default MI version now being
 161         version 3, and about the GDB/MI fix for multi-location
 162         breakpoints to the "since GDB 8.3" section.
 163
 164 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 165
 166         GDB 8.3.1 released.
 167
 168 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 169
 170         * NEWS: Mention that Cell/B.E. debugging support was removed.
 171         * MAINTAINERS: Remove spu target.
 172
 173         * config/djgpp/fnchange.lst: Remove entries for removed files.
 174
 175         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 176         spu-multiarch.o, and spu-tdep.o.
 177         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 178         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 179         spu-multiarch.c, and spu-tdep.c.
 180         * spu-linux-nat.c: Remove file.
 181         * spu-multiarch.c: Remove file.
 182         * spu-tdep.c: Remove file.
 183         * spu-tdep.h: Remove file.
 184         * solib-spu.c: Remove file.
 185         * solib-spu.h: Remove file.
 186
 187         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 188         * configure.nat (spu-linux): Remove.
 189         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 190         solib-multiarch.o from gdb_target_obs.
 191         (spu*-*-*): Remove.
 192
 193         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 194         feature flag.
 195         (ppc_linux_no_features): Update.
 196         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 197         Cell/B.E. support.
 198         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 199         (tdesc_powerpc_cell64l): Likewise.
 200         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 201         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 202         Cell/B.E. support.
 203         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 204         Do not include "features/rs6000/powerpc-cell32l.c" or
 205         "features/rs6000/powerpc-cell64l.c".
 206         (ppc_linux_spu_section): Remove.
 207         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 208         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 209         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 210         (ppc_linux_spe_context_lookup): Remove.
 211         (ppc_linux_spe_context_inferior_created): Remove.
 212         (ppc_linux_spe_context_solib_loaded): Remove.
 213         (ppc_linux_spe_context_solib_unloaded): Remove.
 214         (ppc_linux_spe_context): Remove.
 215         (struct ppu2spu_cache): Remove.
 216         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 217         (struct ppu2spu_data): Remove.
 218         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 219         ppu2spu_unwind): Remove.
 220         (ppc_linux_init_abi): Remove Cell/B.E. support.
 221         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 222
 223         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 224         (rs6000/powerpc-cell64l-expedite): Likewise
 225         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 226         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 227         rs6000/powerpc-cell64l.xml.
 228         * features/rs6000/powerpc-cell32l.xml: Remove.
 229         * features/rs6000/powerpc-cell64l.xml: Likewise.
 230         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 231         * features/rs6000/powerpc-cell64l.c: Likewise.
 232         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 233         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 234         * regformats/reg-spu.dat: Remove.
 235
 236         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 237         * corelow.c (struct spuid_list): Remove.
 238         (add_to_spuid_list): Remove.
 239         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 240         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 241         (remote_protocol_features): Remove associated entries.
 242         (_initialize_remote): No longer initialize them.
 243         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 244         * linux-nat.c (SPUFS_MAGIC): Remove.
 245         (linux_proc_xfer_spu): Remove.
 246         (spu_enumerate_spu_ids): Remove.
 247         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 248         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 249         (linux_make_corefile_notes): No longer call it.
 250
 251         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 252         (cooked_write_test): Likewise.
 253
 254 2019-09-20  Tom Tromey  <tom@tromey.com>
 255
 256         * NEWS: Mention case-sensitivity of TUI commands.
 257         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 258         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 259         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 260
 261 2019-09-20  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-source.c (tui_source_window::set_contents): Use
 264         make_unique_xstrdup.
 265         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 266         make_unique_xstrdup.
 267
 268 2019-09-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-data.c: Remove separator comments.
 271         * tui/tui-layout.c: Remove separator comments.
 272         * tui/tui-win.c: Remove separator comments.
 273         * tui/tui-wingeneral.c: Remove separator comments.
 274
 275 2019-09-20  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui.h (strcat_to_buf): Don't declare.
 278         * tui/tui.c (strcat_to_buf): Remove.
 279
 280 2019-09-20  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 283         from "fullname".
 284         * tui/tui-source.c (tui_source_window::set_contents)
 285         (tui_source_window::location_matches_p)
 286         (tui_source_window::maybe_update): Update.
 287
 288 2019-09-20  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 291         Update.
 292         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 293         prefix.
 294         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 295         (tui_data_window::line_from_reg_element_no)
 296         (tui_data_window::first_reg_element_no_inline)
 297         (tui_data_window::show_registers)
 298         (tui_data_window::show_register_group)
 299         (tui_data_window::display_registers_from)
 300         (tui_data_window::display_registers_from_line)
 301         (tui_data_window::first_data_item_displayed)
 302         (tui_data_window::delete_data_content_windows)
 303         (tui_data_window::erase_data_content)
 304         (tui_data_window::do_scroll_vertical)
 305         (tui_data_window::refresh_window)
 306         (tui_data_window::check_register_values): Update.
 307
 308 2019-09-20  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 311         (struct tui_locator_window) <full_name, proc_name>: Now
 312         std::string.
 313         * tui/tui-stack.c (tui_locator_window::make_status_line)
 314         (tui_locator_window::set_locator_fullname)
 315         (tui_locator_window::set_locator_info): Update.
 316         * tui/tui-source.c (tui_source_window::set_contents)
 317         (tui_source_window::showing_source_p): Update.
 318
 319 2019-09-20  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 322         Don't call tui_locator_win_info_ptr.
 323
 324 2019-09-20  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 327
 328 2019-09-20  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 331         height for locator.
 332         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 333         * tui/tui-layout.c (show_source_disasm_command, show_data)
 334         (show_source_or_disasm_and_command): Use 1 as height for locator.
 335
 336 2019-09-20  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui.c (tui_enable): Update.
 339         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 340         Update.
 341         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 342         Update.
 343         * tui/tui-data.c (win_resized): Now bool.
 344         (tui_win_resized): Return bool.
 345         (tui_set_win_resized_to): Accept a bool.
 346
 347 2019-09-20  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 350         Change type of "refresh_values_only".
 351         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 352         type of "refresh_values_only".
 353
 354 2019-09-20  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 357         std::string.
 358         (tui_disassemble): Add "pos" parameter.
 359         (tui_disasm_window::set_contents): Simplify.
 360
 361 2019-09-20  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-winsource.h (struct tui_source_window_base)
 364         <show_source_content>: Now private.
 365         * tui/tui-winsource.c
 366         (tui_source_window_base::show_source_content): Don't handle empty
 367         content case.
 368
 369 2019-09-20  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-layout.c (show_source_disasm_command)
 372         (show_source_or_disasm_and_command): Don't call
 373         show_source_content.
 374
 375 2019-09-20  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 378         Declare.
 379         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 380         from tui_make_status_line.
 381         (tui_locator_window::rerender): Update.
 382
 383 2019-09-20  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 386         (tui_locator_window::rerender): Update.
 387
 388 2019-09-20  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-winsource.h (struct tui_source_window_base)
 391         <~tui_source_window_base>: Don't declare.
 392         <fullname>: Remove.
 393         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 394         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 395         member.
 396         * tui/tui-source.c (tui_source_window::set_contents): Update.
 397         (tui_source_window::location_matches_p)
 398         (tui_source_window::maybe_update): Update.
 399
 400 2019-09-20  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.h (~tui_source_element): Remove.
 403         (tui_source_element): Update.
 404         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 405         * tui/tui-winsource.c (tui_show_source_line): Update.
 406         * tui/tui-source.c (tui_source_window::set_contents): Update.
 407         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 408
 409 2019-09-20  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 412         declare.
 413         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 414         tui_clear_source_windows_detail.
 415         * tui/tui-winsource.h (struct tui_source_window_base)
 416         <clear_detail>: Don't declare.
 417         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 418         Remove.
 419         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 420
 421 2019-09-20  Tom Tromey  <tromey@adacore.com>
 422
 423         PR ada/24919:
 424         * block.c (contained_in): Fix final return value.
 425
 426 2019-09-20  Alan Modra  <amodra@gmail.com>
 427
 428         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 429         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 430         (read_indirect_string_from_dwz): Use bfd accessor.
 431         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 432         * machoread.c (macho_symfile_read_all_oso): Likewise.
 433         * solib.c (solib_bfd_open): Likewise.
 434
 435 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 436
 437         * eval.c: Move declaration of overload_resolution to...
 438         * value.h: ...here.
 439
 440 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 441
 442         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 443         * arm-linux-tdep.c: Likewise.
 444         * arm-nbsd-nat.c: Likewise.
 445         * arm-tdep.h: Declare arm_apcs_32.
 446         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 447
 448 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 451         * dwarf2read.h: Declare dwarf_always_disassemble.
 452
 453 2019-09-19  Tom de Vries  <tdevries@suse.de>
 454
 455         PR gdb/25009
 456         * source-cache.c (source_cache::ensure): Catch exception thrown during
 457         construction of the highlighter.
 458
 459 2019-09-18  Alan Modra  <amodra@gmail.com>
 460
 461         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 462         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 463         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 464         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 465         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 466         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 467         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 468         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 469         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 470         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 471         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 472         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 473         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 474         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 475         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 476         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 477         * mi/mi-interp.c: Update throughout for bfd section macro and
 478         function changes.
 479         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 480         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 481
 482 2019-09-18  Tom Tromey  <tom@tromey.com>
 483
 484         * NEWS: Add entry.
 485         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 486         call rl_initialize.
 487         (tui_enable): Do not call rl_initialize.
 488
 489 2019-09-18  Christian Groessler  <chris@groessler.org>
 490
 491         * alpha-linux-nat.c: Include gdbarch.h.
 492
 493 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 494
 495         * ui-file.c: Include cli/cli-style.h.
 496         (term_cli_styling): Remove cli_styling declaration.
 497
 498 2019-09-18  Alan Modra  <amodra@gmail.com>
 499
 500         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 501         to bfd_asymbol_section.
 502
 503 2019-09-18  Alan Modra  <amodra@gmail.com>
 504
 505         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 506         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 507         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 508
 509 2019-09-18  Alan Modra  <amodra@gmail.com>
 510
 511         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 512         * spu-linux-nat.c (spu_bfd_open): Likewise.
 513
 514 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 515
 516         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 517         to bool to match definition in dwarf2read.c.
 518
 519 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 520
 521         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 522         (print_signatures): Likewise.
 523         (trust_pad_over_xvs): Likewise.
 524         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 525         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 526         * arm-linux-nat.c (arm_apcs_32): Likewise.
 527         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 528         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 529         * arm-tdep.c (arm_debug): Likewise.
 530         (arm_apcs_32): Likewise.
 531         * auto-load.c (debug_auto_load): Likewise.
 532         (auto_load_gdb_scripts): Likewise.
 533         (global_auto_load): Likewise.
 534         (auto_load_local_gdbinit): Likewise.
 535         (auto_load_local_gdbinit_loaded): Likewise.
 536         * auto-load.h (global_auto_load): Likewise.
 537         (auto_load_local_gdbinit): Likewise.
 538         (auto_load_local_gdbinit_loaded): Likewise.
 539         * breakpoint.c (disconnected_dprintf): Likewise.
 540         (breakpoint_proceeded): Likewise.
 541         (automatic_hardware_breakpoints): Likewise.
 542         (always_inserted_mode): Likewise.
 543         (target_exact_watchpoints): Likewise.
 544         (_initialize_breakpoint): Update.
 545         * breakpoint.h (target_exact_watchpoints): Change to bool.
 546         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 547         * cli/cli-cmds.c (trace_commands): Likewise.
 548         * cli/cli-cmds.h (trace_commands): Likewise.
 549         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 550         to bool*.
 551         * cli/cli-logging.c (logging_overwrite): Change to bool.
 552         (logging_redirect): Likewise.
 553         (debug_redirect): Likewise.
 554         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 555         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 556         to bool.
 557         <boolean_option_def>: Update.
 558         (struct flag_option_def): Change default type of Context to bool
 559         from int.
 560         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 561         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 562         (get_setshow_command_value_string): Likewise.
 563         * cli/cli-style.c (cli_styling): Change to bool.
 564         (source_styling): Likewise.
 565         * cli/cli-style.h (source_styling): Likewise.
 566         (cli_styling): Likewise.
 567         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 568         to bool.
 569         * command.h (var_types): Update comment.
 570         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 571         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 572         bool.
 573         (debug_compile_cplus_scopes): Likewise.
 574         * compile/compile-internal.h (compile_debug): Likewise.
 575         * compile/compile.c (compile_debug): Likewise.
 576         (struct compile_options) <raw>: Likewise.
 577         * cp-support.c (catch_demangler_crashes): Likewise.
 578         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 579         (usr_cmd_cris_dwarf2_cfi): Likewise.
 580         * csky-tdep.c (csky_debug): Likewise.
 581         * darwin-nat.c (enable_mach_exceptions): Likewise.
 582         * dcache.c (dcache_enabled_p): Likewise.
 583         * defs.h (info_verbose): Likewise.
 584         * demangle.c (demangle): Likewise.
 585         (asm_demangle): Likewise.
 586         * dwarf-index-cache.c (debug_index_cache): Likewise.
 587         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 588         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 589         * dwarf2read.c (check_physname): Likewise.
 590         (use_deprecated_index_sections): Likewise.
 591         (dwarf_always_disassemble): Likewise.
 592         * eval.c (overload_resolution): Likewise.
 593         * event-top.c (set_editing_cmd_var): Likewise.
 594         (exec_done_display_p): Likewise.
 595         * event-top.h (set_editing_cmd_var): Likewise.
 596         (exec_done_display_p): Likewise.
 597         * exec.c (write_files): Likewise.
 598         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 599         (debug_fbsd_nat): Likewise.
 600         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 601         Likewise.
 602         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 603         <backtrace_past_entry> Likewise.
 604         * gdb-demangle.h (demangle): Likewise.
 605         (asm_demangle): Likewise.
 606         * gdb_bfd.c (bfd_sharing): Likewise.
 607         * gdbcore.h (write_files): Likewise.
 608         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 609         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 610         * gdbthread.h (print_thread_events): Likewise.
 611         * gdbtypes.c (opaque_type_resolution): Likewise.
 612         (strict_type_checking): Likewise.
 613         * gnu-nat.c (gnu_debug_flag): Likewise.
 614         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 615         * guile/scm-param.c (pascm_variable): Add boolval.
 616         (add_setshow_generic): Update.
 617         (pascm_param_value): Update.
 618         (pascm_set_param_value_x): Update.
 619         * hppa-tdep.c (hppa_debug): Change to bool..
 620         * infcall.c (may_call_functions_p): Likewise.
 621         (coerce_float_to_double_p): Likewise.
 622         (unwind_on_signal_p): Likewise.
 623         (unwind_on_terminating_exception_p): Likewise.
 624         * infcmd.c (startup_with_shell): Likewise.
 625         * inferior.c (print_inferior_events): Likewise.
 626         * inferior.h (startup_with_shell): Likewise.
 627         (print_inferior_events): Likewise.
 628         * infrun.c (step_stop_if_no_debug): Likewise.
 629         (detach_fork): Likewise.
 630         (debug_displaced): Likewise.
 631         (disable_randomization): Likewise.
 632         (non_stop): Likewise.
 633         (non_stop_1): Likewise.
 634         (observer_mode): Likewise.
 635         (observer_mode_1): Likewise.
 636         (set_observer_mode): Update.
 637         (sched_multi): Change to bool.
 638         * infrun.h (debug_displaced): Likewise.
 639         (sched_multi): Likewise.
 640         (step_stop_if_no_debug): Likewise.
 641         (non_stop): Likewise.
 642         (disable_randomization): Likewise.
 643         * linux-tdep.c (use_coredump_filter): Likewise.
 644         (dump_excluded_mappings): Likewise.
 645         * linux-thread-db.c (auto_load_thread_db): Likewise.
 646         (check_thread_db_on_load): Likewise.
 647         * main.c (captured_main_1): Update.
 648         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 649         xx2_opt, boolean_opt>: Change to bool.
 650         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 651         * maint.c (maintenance_profile_p): Likewise.
 652         (per_command_time): Likewise.
 653         (per_command_space): Likewise.
 654         (per_command_symtab): Likewise.
 655         * memattr.c (inaccessible_by_default): Likewise.
 656         * mi/mi-main.c (mi_async): Likewise.
 657         (mi_async_1): Likewise.
 658         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 659         * nat/fork-inferior.h (startup_with_shell): Likewise.
 660         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 661         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 662         * nios2-tdep.c (nios2_debug): Likewise.
 663         * or1k-tdep.c (or1k_debug): Likewise.
 664         * parse.c (parser_debug): Likewise.
 665         * parser-defs.h (parser_debug): Likewise.
 666         * printcmd.c (print_symbol_filename): Likewise.
 667         * proc-api.c (procfs_trace): Likewise.
 668         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 669         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 670         (set_parameter_value): Update.
 671         (add_setshow_generic): Update.
 672         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 673         to bool*.
 674         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 675         int*.
 676         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 677         * record-btrace.c (record_btrace_target::store_registers): Update.
 678         * record-full.c (record_full_memory_query): Change to bool.
 679         (record_full_stop_at_limit): Likewise.
 680         * record-full.h (record_full_memory_query): Likewise.
 681         * remote-notif.c (notif_debug): Likewise.
 682         * remote-notif.h (notif_debug): Likewise.
 683         * remote.c (use_range_stepping): Likewise.
 684         (interrupt_on_connect): Likewise.
 685         (remote_break): Likewise.
 686         * ser-tcp.c (tcp_auto_retry): Likewise.
 687         * ser-unix.c (serial_hwflow): Likewise.
 688         * skip.c (debug_skip): Likewise.
 689         * solib-aix.c (solib_aix_debug): Likewise.
 690         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 691         (spu_auto_flush_cache_p): Likewise.
 692         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 693         Likewise.
 694         (struct info_print_options) <quiet>: Likewise.
 695         * symfile-debug.c (debug_symfile): Likewise.
 696         * symfile.c (auto_solib_add): Likewise.
 697         (separate_debug_file_debug): Likewise.
 698         * symfile.h (auto_solib_add): Likewise.
 699         (separate_debug_file_debug): Likewise.
 700         * symtab.c (basenames_may_differ): Likewise.
 701         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 702         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 703         (struct info_types_options) <quiet>: Likewise.
 704         * symtab.h (demangle): Likewise.
 705         (basenames_may_differ): Likewise.
 706         * target-dcache.c (stack_cache_enabled_1): Likewise.
 707         (code_cache_enabled_1): Likewise.
 708         * target.c (trust_readonly): Likewise.
 709         (may_write_registers): Likewise.
 710         (may_write_memory): Likewise.
 711         (may_insert_breakpoints): Likewise.
 712         (may_insert_tracepoints): Likewise.
 713         (may_insert_fast_tracepoints): Likewise.
 714         (may_stop): Likewise.
 715         (auto_connect_native_target): Likewise.
 716         (target_stop_and_wait): Update.
 717         (target_async_permitted): Change to bool.
 718         (target_async_permitted_1): Likewise.
 719         (may_write_registers_1): Likewise.
 720         (may_write_memory_1): Likewise.
 721         (may_insert_breakpoints_1): Likewise.
 722         (may_insert_tracepoints_1): Likewise.
 723         (may_insert_fast_tracepoints_1): Likewise.
 724         (may_stop_1): Likewise.
 725         * target.h (target_async_permitted): Likewise.
 726         (may_write_registers): Likewise.
 727         (may_write_memory): Likewise.
 728         (may_insert_breakpoints): Likewise.
 729         (may_insert_tracepoints): Likewise.
 730         (may_insert_fast_tracepoints): Likewise.
 731         (may_stop): Likewise.
 732         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 733         (make_thread_apply_all_options_def_group): Change argument from int*
 734         to bool*.
 735         (thread_apply_all_command): Update.
 736         (print_thread_events): Change to bool.
 737         * top.c (confirm): Likewise.
 738         (command_editing_p): Likewise.
 739         (history_expansion_p): Likewise.
 740         (write_history_p): Likewise.
 741         (info_verbose): Likewise.
 742         * top.h (confirm): Likewise.
 743         (history_expansion_p): Likewise.
 744         * tracepoint.c (disconnected_tracing): Likewise.
 745         (circular_trace_buffer): Likewise.
 746         * typeprint.c (print_methods): Likewise.
 747         (print_typedefs): Likewise.
 748         * utils.c (debug_timestamp): Likewise.
 749         (sevenbit_strings): Likewise.
 750         (pagination_enabled): Likewise.
 751         * utils.h (sevenbit_strings): Likewise.
 752         (pagination_enabled): Likewise.
 753         * valops.c (overload_resolution): Likewise.
 754         * valprint.h (struct value_print_options) <prettyformat_arrays,
 755         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 756         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 757         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 758         Likewise.
 759         * windows-nat.c (new_console): Likewise.
 760         (cygwin_exceptions): Likewise.
 761         (new_group): Likewise.
 762         (debug_exec): Likewise.
 763         (debug_events): Likewise.
 764         (debug_memory): Likewise.
 765         (debug_exceptions): Likewise.
 766         (useshell): Likewise.
 767         * windows-tdep.c (maint_display_all_tib): Likewise.
 768         * xml-support.c (debug_xml): Likewise.
 769
 770 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 771
 772         * source.c (prepare_path_for_appending): New function.
 773         (openp): Make use of new function.
 774         (find_and_open_source): Search for the compilation directory and
 775         source file as a relative path beneath the directory search path.
 776
 777 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * source-cache.c (source_cache::get_line_charpos): Catch
 780         exceptions and return false, this matches the behaviour documented
 781         in the header file.
 782
 783 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 784
 785         * ada-tasks.c (info_task): Remove quoting of the task's name.
 786
 787 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 788
 789         * symfile.c (auto_solib_add): Replace comment with a reference
 790         to the header file.
 791
 792 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 793
 794         * NEWS: Mention that gdb can now be compiled with Python 3
 795         on Windows.
 796
 797 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * maint.c (maint_print_section_data::maint_print_section_data):
 800         Force use of 'float log10 (float)' by casting the argument to
 801         float.
 802
 803 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * maint.c: Add 'cmath' include.
 806         (struct maint_print_section_data): New structure.
 807         (print_section_index): New function.
 808         (print_bfd_section_info): Add header comment, small whitespace
 809         cleanup, and update to call new print_section_index function.
 810         (print_objfile_section_info): Likewise.
 811         (maint_obj_section_from_bfd_section): New function.
 812         (print_bfd_section_info_maybe_relocated): New function.
 813         (maintenance_info_sections): Add header comment, always use
 814         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 815
 816 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 819         inner scope, add check that the objfile has psymtabs before
 820         checking psymtabs_addrmap.
 821         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 822
 823 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 824
 825         * NEWS: Announce that Ada task names are now shown at more places,
 826         and between quotes (except in info task output).
 827         * gdb/ada-tasks.c (task_to_str): New function.
 828         (display_current_task_id): Call task_to_str.
 829         (task_command_1): Likewise.
 830         (print_ada_task_info): In non-mi mode, Properly align headers and data
 831         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 832
 833 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 834
 835         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 836         prstatus.pr_lwp.pr_info instead of making it up.
 837
 838 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 839
 840         * auto-load.c (auto_load_expand_dir_vars): Update.
 841         * defs.h (gdb_datadir): Change to std::string.
 842         (python_libdir): Likewise.
 843         (relocate_gdb_directory): Change return type to std::string.
 844         * guile/guile.c (gdbscm_data_directory): Update.
 845         (initialize_scheme_side): Update.
 846         * jit.c (jit_reader_dir): Change to std::string.
 847         (jit_reader_load_command): Update.
 848         * main.c (gdb_datadir): Change to std::string.
 849         (python_libdir): Likewise.
 850         (set_gdb_data_directory): Update.
 851         (relocate_path): Change to return std::string.
 852         (relocate_gdb_directory): Change to return std::string.
 853         (relocate_gdbinit_path_maybe_in_datadir): Update.
 854         (captured_main_1): Update.
 855         * python/python.c (do_start_initialization): Update.
 856         * top.c (show_gdb_datadir): Update.
 857         * xml-syscall.c (xml_init_syscalls_info): Update.
 858         (init_syscalls_info): Update.
 859
 860 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 861
 862         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 863         out of get_init_files.
 864         (get_init_files): Update.
 865
 866 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 867
 868         * main.c (get_init_files): Change to use std::string.
 869         (captured_main_1): Update.
 870         (print_gdb_help): Update.
 871
 872 2019-09-11  Ali Tamur  <tamur@google.com>
 873
 874         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 875         implementation.
 876
 877 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 878
 879         * dbxread.c (read_dbx_symtab): Update.
 880         * dwarf2read.c (load_partial_dies): Update.
 881         * mdebugread.c (parse_partial_symbols): Update.
 882         (handle_psymbol_enumerators): Update.
 883         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 884         * psymtab.c (add_psymbol_to_bcache): Likewise.
 885         (add_psymbol_to_list): Likewise.
 886         * symtab.c (symbol_set_names): Likewise.
 887         * symtab.h (symbol_set_names): Likewise.
 888         * xcoffread.c (scan_xcoff_symtab): Update.
 889
 890 2019-09-11  Tom Tromey  <tom@tromey.com>
 891
 892         * symfile-mem.c (symbol_file_add_from_memory): Use
 893         bfd_set_filename.
 894         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 895         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 896
 897 2019-09-10  Tom Tromey  <tromey@adacore.com>
 898
 899         * dwarf-index-write.c (write_psymbols): Extend error message.
 900         (debug_names::insert): Add Ada code.
 901         (debug_names::write_psymbols): Remove Ada check.
 902         (debug_names) <m_string_obstack>: New member.
 903         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 904         (gdb_index_symbol_name_matcher::matches): Remove.
 905         (mapped_index_base::find_name_components_bounds): Add "lang"
 906         parameter.
 907         (mapped_index_base::build_name_components): Also split names
 908         according to Ada syntax.
 909         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 910         type of "match_callback".
 911         (check_match, check_find_bounds_finds)
 912         (dw2_expand_symtabs_matching): Update.
 913         (dw2_debug_names_iterator): Add new constructor.
 914         (dw2_debug_names_map_matching_symbols): New function.
 915         (dw2_debug_names_expand_symtabs_matching): Update.
 916         (dwarf2_debug_names_functions): Use
 917         dw2_debug_names_map_matching_symbols.
 918
 919 2019-09-10  Tom Tromey  <tromey@adacore.com>
 920
 921         * dwarf2read.c (dw2_get_file_names_reader): Add the
 922         CU's file name to the results.
 923
 924 2019-09-10  Tom Tromey  <tromey@adacore.com>
 925
 926         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 927         map_matching_symbols.  Update.
 928         * dwarf2read.c (dw2_map_matching_symbols): Update.
 929         * psymtab.c (match_partial_symbol): Change type; update.
 930         (psym_map_matching_symbols): Likewise.
 931         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 932         type; update.
 933         * symfile.h (struct quick_symbol_functions)
 934         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 935         Remove "match".
 936
 937 2019-09-10  Tom Tromey  <tromey@adacore.com>
 938
 939         * psymtab.c (map_block): Remove.
 940         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 941         * symtab.c (iterate_over_symbols_terminated): New function.
 942         * symtab.c (iterate_over_symbols_terminated): Declare.
 943
 944 2019-09-10  Tom Tromey  <tromey@adacore.com>
 945
 946         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 947         * language.h (struct language_defn) <la_iterate_over_symbols>:
 948         Return bool.
 949         * symtab.c (iterate_over_symbols): Return bool.
 950         * symtab.h (iterate_over_symbols): Return bool.
 951
 952 2019-09-10  Tom Tromey  <tromey@adacore.com>
 953
 954         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 955         (add_nonlocal_symbols): Update.
 956         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 957         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 958         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 959         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 960         Change type of "callback".  Remove "data".
 961
 962
 963 2019-09-09  Ali Tamur  <tamur@google.com>
 964
 965         * dwarf2read.c (comp_unit_head): Update comment.
 966         (dwarf2_dwo_name): New function declaration.
 967         (dwarf_unit_type_name): New function declaration.
 968         (read_comp_unit_head): Add support for new compilation units,
 969         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 970         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 971         (currently named as "signature") in their header. Also clarify error
 972         messages.
 973         (lookup_dwo_id): New function. Returns the dwo id of the given
 974         compile unit.
 975         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 976         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 977         functions.
 978         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 979         (dwarf2_dwo_name): Get the dwo name if present.
 980         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 981         purposes.
 982
 983 2019-09-09  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 986
 987 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 988
 989         * python/python.c (do_start_initialization): Make progname_copy static,
 990         to avoid a leak report.
 991
 992 2019-09-08  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 995
 996 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 997
 998         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 999         Change type to gdb::optional<block_enum>.
1000         (dw2_symtab_iter_init): Change block_index parameter type
1001         to gdb::optional<block_enum>.
1002         (dw2_lookup_symbol): Change block_index parameter
1003         type to block_enum.c
1004         (dw2_debug_names_lookup_symbol): Likewise.
1005         * psymtab.c (psym_lookup_symbol): Likewise.
1006         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1007         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1008         Likewise.
1009
1010 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1011
1012         * defs.h (relocate_gdb_directory): Change int to bool in
1013         signature and rename flag to relocatable.
1014         * main.c (relocate_path): Likewise.
1015         (relocate_gdb_directory): Likewise.
1016
1017 2019-09-06  Alan Modra  <amodra@gmail.com>
1018
1019         * coffread.c (coff_symfile_read): Constify filename variable.
1020         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1021         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1022         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1023         * solib.c (reload_shared_libraries_1): Likewise.
1024         * symfile.c (reread_symbols): Likewise.
1025         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1026         * solib-darwin.c (darwin_bfd_open): Likewise.
1027         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1028
1029 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1032         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1033
1034 2019-09-03  Tom Tromey  <tromey@adacore.com>
1035
1036         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1037         types.
1038         (has_negatives): Unbias a range type bound.
1039         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1040         * gdbtypes.c (operator==): Handle new field.
1041         (create_range_type): Add "bias" parameter.
1042         (create_static_range_type, resolve_dynamic_range): Update.
1043         * gdbtypes.h (struct range_bounds) <bias>: New member.
1044         (create_range_type): Add bias parameter.
1045         * printcmd.c (print_scalar_formatted): Unbias range types.
1046         * value.c (unpack_long): Unbias range types.
1047         (pack_long): Bias range types.
1048
1049 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1050
1051         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1052         probe arguments.
1053
1054 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1055
1056         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1057         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1058         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1059         (compile_probe_arg): Likewise.
1060         * probe.h (get_argument_count): Likewise.
1061         * solib-svr4.c (solib_event_probe_action): Likewise.
1062         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1063
1064 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1065
1066         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1067         code to here...
1068         (svr4_create_solib_event_breakpoints): ...from here.
1069
1070 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1071
1072         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1073         suffix from warning message.
1074
1075 2019-08-30  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-winsource.h (struct tui_source_window_base)
1078         <refresh_all>: Don't declare.
1079         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1080         Remove.
1081         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1082         tui_show_locator_content.
1083         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1084         declare.
1085         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1086         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1087         declare.
1088
1089 2019-08-30  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1092
1093 2019-08-30  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1096         Remove unnecessary forward declarations.
1097
1098 2019-08-30  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1101         rerender.
1102         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1103         tui_show_locator_content.
1104
1105 2019-08-30  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1108         (tui_locator_window::rerender): Rewrite using body of previous
1109         tui_show_locator_content.
1110
1111 2019-08-30  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1114         set_locator_fullname>: New methods.
1115         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1116         Rename from tui_set_locator_fullname.
1117         (tui_locator_window::set_locator_info): Rename from
1118         tui_set_locator_info.  Return bool.
1119         (tui_update_locator_fullname, tui_show_frame_info): Update.
1120
1121 2019-08-30  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1124
1125 2019-08-30  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1128         call touchwin.
1129
1130 2019-08-30  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-wingeneral.c (box_win): Assume win_info and
1133         win_info->handle cannot be NULL.
1134
1135 2019-08-30  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1138         refresh_window>: Declare.
1139         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1140         resize.
1141         (tui_data_item_window::rerender): Rename from
1142         tui_display_register.
1143         (tui_data_item_window::refresh_window): New method.
1144         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1145         no-op.
1146
1147 2019-08-30  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1150         regs_column_count, current_group>: Move later.  Now private.
1151         <get_current_group>: New method.
1152         * tui/tui-regs.c (tui_reg_command): Update.
1153         * tui/tui-layout.c (tui_set_layout): Update.
1154
1155 2019-08-30  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1158         (tui_data_window::rerender): Don't call
1159         check_and_display_highlight_if_needed.
1160         (tui_data_window::refresh_all): Remove call to
1161         erase_data_content.
1162
1163 2019-08-30  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1166         (tui_data_window::display_registers_from)
1167         (tui_data_window::display_reg_element_at_line)
1168         (tui_data_window::display_registers_from_line): Remove checks of
1169         "empty".
1170
1171 2019-08-30  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1174         Don't declare.
1175         * tui/tui-regs.c (tui_data_window::show_registers): Call
1176         rerender.
1177         (tui_data_window::rerender): Rename from display_all_data.
1178         (tui_data_window::rerender): Remove old implementation.
1179
1180 2019-08-30  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1183         text.
1184         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1185
1186 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1187             Sergio Durigan Junior  <sergiodj@redhat.com>
1188
1189         PR win32/24284
1190         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1191
1192 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1195         when searching for types.
1196
1197 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * f-lang.c (f_language_defn): Use f_print_typedef.
1200         * f-lang.h (f_print_typedef): Declare.
1201         * f-typeprint.c (f_print_typedef): Define.
1202
1203 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1204
1205         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1206
1207 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * cli/cli-utils.c (info_print_options_defs): Delete.
1210         (make_info_print_options_def_group): Delete.
1211         (extract_info_print_options): Delete.
1212         (info_print_command_completer): Delete.
1213         (info_print_args_help): Add extra parameter, and optionally
1214         include text about -n flag.
1215         * cli/cli-utils.h (struct info_print_options): Delete.
1216         (extract_info_print_options): Delete declaration.
1217         (info_print_command_completer): Delete declaration.
1218         (info_print_args_help): Add extra parameter, extend header
1219         comment.
1220         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1221         search_symbols.
1222         * stack.c (struct info_print_options): New type.
1223         (info_print_options_defs): New file scoped variable.
1224         (make_info_print_options_def_group): New static function.
1225         (info_print_command_completer): New static function.
1226         (info_locals_command): Update to use new local functions.
1227         (info_args_command): Likewise.
1228         (_initialize_stack): Add extra parameter to calls to
1229         info_print_args_help.
1230         * symtab.c (search_symbols): Add extra parameter, use this to
1231         possibly excluse non-debug symbols.
1232         (symtab_symbol_info): Add extra parameter, which is passed on to
1233         search_symbols.
1234         (struct info_print_options): New type.
1235         (info_print_options_defs): New file scoped variable.
1236         (make_info_print_options_def_group): New static function.
1237         (info_print_command_completer): New static function.
1238         (info_variables_command): Update to use local functions, and pass
1239         extra parameter through to symtab_symbol_info.
1240         (info_functions_command): Likewise.
1241         (info_types_command): Pass additional argument through to
1242         symtab_symbol_info.
1243         (rbreak_command): Pass extra argument to search_symbols.
1244         (_initialize_symtab): Add extra arguments for calls to
1245         info_print_args_help, and update help text for 'info variables',
1246         'whereis', and 'info functions' commands.
1247         * symtab.h (search_symbols): Add extra argument to declaration.
1248         * NEWS: Mention new flags.
1249
1250 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1251
1252         * symtab.c (lookup_static_symbol): Call the new function (and move
1253         it down to be next to lookup_global_symbol).
1254         (struct global_sym_lookup_data): Add block_enum member and rename to...
1255         (struct global_or_static_sym_lookup_data): ...this.
1256         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1257         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1258         (lookup_symbol_global_or_static_iterator_cb): ...this.
1259         (lookup_global_or_static_symbol): New function.
1260         (lookup_global_symbol): Call new function.
1261
1262 2019-08-26  Tom de Vries  <tdevries@suse.de>
1263
1264         PR c++/24852
1265         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1266         when pc_probe.prob == NULL.
1267
1268 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1269
1270         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1271         variable symbol_linkage to symbol_linkage_.
1272
1273 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1274
1275         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1276         represent whether the symbol is static, dynamic, or we don't
1277         know.
1278
1279 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1280
1281         * gdb/rx-tdep.c (rx_register_names): New.
1282         (rx_register_name): Delete.
1283         (rx_psw_type): Delete.
1284         (rx_fpsw_type): Delete.
1285         (rx_register_type): Delete.
1286         (rx_gdbarch_init): Convert target-descriptions.
1287         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1288         * gdb/features/Makefile: Add rx.xml.
1289         * gdb/features/rx.xml: New.
1290         * gdb/features/rx.c: Generated.
1291         * gdb/NEWS: Mention target description support.
1292
1293 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1294
1295         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1296         *slot_ptr.
1297
1298 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1299
1300         * configure.ac: Don't check for 'dlfcn.h' (moved to
1301         gdbsupport/common.m4).
1302         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1303         'gdbsupport/'.
1304         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1305         * compile/compile-c-support.c: Include
1306         'gdbsupport/gdb-dlfcn.h'.
1307         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1308         * gdb-dlfcn.c: Move to...
1309         * gdbsupport/gdb-dlfcn.c: ... here.
1310         * gdb-dlfcn.h: Move to...
1311         * gdbsupport/gdb-dlfcn.h: ... here.
1312
1313 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1314
1315         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1316         the offset field signed.
1317
1318 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1319
1320         * python/lib/gdb/__init__.py (_execute_file): New function.
1321         * python/python.c (python_run_simple_file): Call gdb._execute_file
1322         on Windows.
1323
1324 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1327         all uses as this was never set to anything but a zero value.
1328
1329 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1330
1331         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1332
1333 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1334
1335         * tui/tui-data.h (tui_gen_win_info): Add an =default
1336         move constructor, required by some GCC versions.
1337
1338 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1339
1340         * go32-nat.c (go32_sysinfo): Add hygon_p.
1341
1342 2019-08-20  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1345         line_from_reg_element_no, first_reg_element_no_inline,
1346         display_all_data, delete_data_content_windows,
1347         erase_data_content>: Now private.
1348
1349 2019-08-20  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1352         (tui_unhighlight_win, tui_highlight_win)
1353         (tui_win_info::make_window): Update.
1354         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1355
1356 2019-08-20  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1359         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1360         (MAX_PID_WIDTH): Move to tui-stack.c.
1361         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1362         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1363         (MAX_PID_WIDTH): Move from tui-data.h.
1364
1365 2019-08-20  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1368         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1369         (box_win): Update.
1370         (tui_gen_win_info::make_window): Rename from tui_make_window.
1371         (tui_win_info::make_window): New method.
1372         (tui_gen_win_info::make_visible): Update.
1373         * tui/tui-source.c (tui_source_window::set_contents): Update.
1374         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1375         (tui_data_window::display_registers_from): Update.
1376         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1377         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1378         Declare.
1379         <can_box>: Remove.
1380         <title>: Remove.
1381         (struct tui_win_info) <make_window>: Declare.
1382         <can_box>: Now virtual.
1383         <title>: New member.
1384         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1385         * tui/tui-command.c (tui_cmd_window::resize): Update.
1386
1387 2019-08-20  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1390         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1391         (tui_data_window::check_register_values): Update.
1392
1393 2019-08-20  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-regs.h (struct tui_data_window): Use
1396         DISABLE_COPY_AND_ASSIGN.
1397         <regs_content>: Change type, removing unique_ptr.
1398         <tui_data_window>: Add move constructor.
1399         * tui/tui-regs.c (tui_data_window::show_registers)
1400         (tui_data_window::show_register_group)
1401         (tui_data_window::display_registers_from)
1402         (tui_data_window::display_registers_from)
1403         (tui_data_window::first_data_item_displayed)
1404         (tui_data_window::delete_data_content_windows)
1405         (tui_data_window::rerender, tui_data_window::refresh_window)
1406         (tui_data_window::check_register_values): Update.
1407
1408 2019-08-20  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1411         show_register_group>: Declare.
1412         (tui_show_register_group): Don't declare.
1413         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1414         tui_show_registers.
1415         (tui_data_window::show_register_group): Rename from
1416         tui_show_register_group.
1417         (tui_data_window::check_register_values, tui_reg_command):
1418         Update.
1419         * tui/tui-layout.c (tui_set_layout): Update.
1420
1421 2019-08-20  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1424         Declare.
1425         (tui_check_register_values): Don't declare.
1426         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1427         from tui_check_register_values.
1428         * tui/tui-hooks.c (tui_register_changed): Update.
1429
1430 2019-08-20  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-regs.c (tui_reg_layout): Move later.
1433         (tui_show_registers): Don't enable TUI mode or change layout.
1434
1435 2019-08-20  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-regs.h (struct tui_data_item_window)
1438         <~tui_data_item_window>: Remove.
1439         <content>: Now a unique_xmalloc_ptr.
1440         * tui/tui-regs.c (tui_register_format): Return a
1441         unique_xmalloc_ptr.
1442         (tui_get_register): Update.
1443         (~tui_data_item_window): Remove.
1444         (tui_data_window::display_registers_from, tui_display_register):
1445         Update.
1446         * tui/tui-io.h (tui_expand_tabs): Update.
1447         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1448         Remove "col" parameter.
1449
1450 2019-08-20  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1453         field.
1454         * tui/tui-regs.c (~tui_data_item_window): Update.
1455
1456 2019-08-20  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1459         earlier.
1460
1461 2019-08-20  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1464
1465 2019-08-20  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-source.h (struct tui_source_window): Update.
1468         * tui/tui-regs.c (tui_show_registers): Update.
1469         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1470         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1471         (NO_REGS_STRING): Remove defines.
1472
1473 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1474
1475         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1476         unnecessary thread walk if remote doesn't support the packet.
1477
1478 2019-08-19  Tom Tromey  <tromey@adacore.com>
1479
1480         * python/py-value.c (value_has_field): Fix indentation.
1481
1482 2019-08-19  Tom Tromey  <tromey@adacore.com>
1483
1484         * printcmd.c (do_one_display, info_display_command): Update.
1485         * block.h (contained_in): Return bool.  Add allow_nested
1486         parameter.
1487         * block.c (contained_in): Return bool.  Add allow_nested
1488         parameter.
1489
1490 2019-08-19  Tom Tromey  <tom@tromey.com>
1491
1492         * configure: Rebuild.
1493         * configure.ac: Disallow the combination of -static-libstdc++ and
1494         source highlight.
1495         * source-cache.c (get_language_name): Handle rust.
1496         (source_cache::get_source_lines): Ignore highlighting exceptions.
1497
1498 2019-08-16  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1501         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1502         (struct tui_source_window_base) <make_visible, refresh_window,
1503         resize>: Remove methods.
1504         <execution_info>: Remove field.
1505         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1506         (tui_show_source_line, tui_source_window_base)
1507         (~tui_source_window_base): Update.
1508         (tui_source_window_base::resize)
1509         (tui_source_window_base::make_visible)
1510         (tui_source_window_base::refresh_window): Remove.
1511         (tui_source_window_base::update_exec_info): Update.
1512         * tui/tui-source.c (tui_source_window::set_contents): Update.
1513         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1514
1515 2019-08-16  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1518         deprecated_query_hook.
1519
1520 2019-08-16  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1523         (tui_update_source_windows_with_line): Update.
1524         * tui/tui-source.h (struct tui_source_window)
1525         <show_symtab_source>: Declare.
1526         (tui_show_symtab_source): Don't declare.
1527         * tui/tui-source.c (tui_show_symtab_source): Rename from
1528         tui_show_symtab_source.
1529
1530 2019-08-16  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-winsource.h (struct tui_source_window_base)
1533         <set_contents>: Declare.
1534         * tui/tui-winsource.c
1535         (tui_source_window_base::update_source_window_as_is): Update.
1536         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1537         Declare.
1538         (tui_set_source_content): Don't declare.
1539         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1540         tui_set_source_content.
1541         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1542         Declare.
1543         (tui_set_disassem_content): Don't declare.
1544         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1545         tui_set_disassem_content.
1546
1547 2019-08-16  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-winsource.h (struct tui_source_window_base)
1550         <update_breakpoint_info>: Declare.
1551         (tui_update_breakpoint_info): Don't declare.
1552         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1553         (tui_update_all_breakpoint_info): Update.
1554         (tui_source_window_base::update_breakpoint_info): Rename from
1555         tui_update_breakpoint_info.
1556         (tui_source_window_base::update_exec_info): Update.
1557
1558 2019-08-16  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.h (struct tui_source_window_base)
1561         <update_source_window>: Declare.
1562         (tui_update_source_window): Don't declare.
1563         * tui/tui-winsource.c
1564         (tui_source_window_base::update_source_window): Rename from
1565         tui_update_source_window.
1566         (tui_source_window_base::rerender): Update.
1567         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1568         * tui/tui-disasm.c (tui_show_disassem)
1569         (tui_show_disassem_and_update_source)
1570         (tui_disasm_window::maybe_update): Update.
1571
1572 2019-08-16  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-winsource.h (struct tui_source_window_base)
1575         <update_source_window_as_is>: Declare.
1576         (tui_update_source_window_as_is): Don't declare.
1577         * tui/tui-winsource.c (tui_update_source_window): Update
1578         (tui_source_window_base::update_source_window_as_is): Rename from
1579         tui_update_source_window_as_is.
1580         (tui_source_window_base::refill): Update.
1581         * tui/tui-source.c (tui_show_symtab_source): Update.
1582         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1583         Update.
1584
1585 2019-08-16  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-winsource.h (tui_update_source_window)
1588         (tui_update_source_window_as_is): Remove "noerror" parameter.
1589         * tui/tui-winsource.c (tui_update_source_window)
1590         (tui_update_source_window_as_is): Remove "noerror" parameter.
1591         (tui_update_source_windows_with_addr)
1592         (tui_update_source_windows_with_line)
1593         (tui_source_window_base::rerender)
1594         (tui_source_window_base::refill): Update.
1595         * tui/tui-source.h (tui_set_source_content)
1596         (tui_show_symtab_source): Remove "noerror" parameter.
1597         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1598         parameter.
1599         (tui_show_symtab_source): Likewise.
1600         (tui_source_window::maybe_update): Update.
1601         * tui/tui-disasm.c (tui_show_disassem)
1602         (tui_show_disassem_and_update_source)
1603         (tui_disasm_window::do_scroll_vertical)
1604         (tui_disasm_window::maybe_update): Update.
1605
1606 2019-08-16  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui.c (tui_is_window_visible): Update.
1609         * tui/tui-wingeneral.c (tui_make_window)
1610         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1611         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1612         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1613         (tui_set_win_height_command, parse_scrolling_args): Update.
1614         * tui/tui-source.c (tui_source_window::style_changed): Update.
1615         * tui/tui-regs.c (tui_show_registers)
1616         (tui_data_window::first_data_item_displayed)
1617         (tui_data_window::delete_data_content_windows)
1618         (tui_check_register_values, tui_reg_command): Update.
1619         * tui/tui-disasm.c (tui_show_disassem): Update.
1620         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1621         method.
1622         <is_visible>: Remove field.
1623         * tui/tui-data.c (tui_next_win, tui_prev_win)
1624         (tui_delete_invisible_windows): Update.
1625
1626 2019-08-16  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.h (struct tui_source_window_base)
1629         <m_has_locator>: Remove.
1630         * tui/tui-layout.c (show_source_disasm_command, show_data)
1631         (show_source_or_disasm_and_command): Update.
1632
1633 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1634
1635         * NEWS (Other MI changes): New subsection.
1636         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1637         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1638         * arch-utils.c (default_get_pc_address_flags): New function.
1639         * arch-utils.h (default_get_pc_address_flags): New declaration.
1640         * gdbarch.sh: Add get_pc_address_flags.
1641         * gdbarch.c: Regenerate.
1642         * gdbarch.h: Likewise.
1643         * stack.c (print_pc): New function.
1644         (print_frame_info) (print_frame): Call print_pc.
1645
1646 2019-08-16  Tom de Vries  <tdevries@suse.de>
1647
1648         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1649         print_objfile_section_info.
1650
1651 2019-08-15  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1654         calling update_cmdwin_start_line.
1655         * tui/tui-winsource.h (struct tui_source_window_base)
1656         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1657         <rerender>: Declare.
1658         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1659         Call rerender.
1660         (tui_source_window_base::set_new_height): Remove.
1661         (tui_source_window_base::rerender): Rename from
1662         do_make_visible_with_new_height.
1663         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1664         resize method.
1665         (tui_win_info::make_invisible_and_set_new_height)
1666         (tui_win_info::make_visible_with_new_height): Remove.
1667         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1668         Declare.
1669         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1670         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1671         do_make_visible_with_new_height>: Don't declare.
1672         <rerender>: Declare.
1673         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1674         set_new_height.
1675         (tui_data_window::do_make_visible_with_new_height): Remove.
1676         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1677         call tui_show_locator_content.
1678         (tui_gen_win_info::resize): Call rerender.
1679         (show_source_or_disasm_and_command): Don't call
1680         tui_show_locator_content.
1681         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1682         method.
1683         (struct tui_win_info) <rerender>: Declare.
1684         <set_new_height, make_invisible_and_set_new_height,
1685         make_visible_with_new_height>: Don't declare.
1686         * tui/tui-data.c (tui_win_list::rerender): New method.
1687         * tui/tui-command.h (struct tui_cmd_window)
1688         <do_make_visible_with_new_height>: Don't declare.
1689         * tui/tui-command.c
1690         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1691
1692 2019-08-15  Tom Tromey  <tromey@adacore.com>
1693
1694         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1695         * ada-lang.c (ada_enum_name): Likewise.
1696
1697 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1698
1699         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1700         leading underscore.
1701         (GdbOutputErrorFile): Likewise.
1702         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1703         accordingly.
1704         (execute_unwinders): Rename to have a leading underscore.
1705         (auto_load_packages): Likewise.
1706         (global scope): Adjust call to auto_load_packages accordingly.
1707         (GdbSetPythonDirectory): Likewise.
1708         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1709         instead of execute_unwinders.
1710
1711 2019-08-15  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1714         (show_data): Don't change window visibility.
1715         (tui_gen_win_info::resize): Remove special case for command
1716         window.  Use wresize, when available.
1717         (show_source_or_disasm_and_command): Don't change window
1718         visibility.
1719         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1720         <make_visible>: New method.
1721         * tui/tui-command.c (tui_cmd_window::resize): New method.
1722
1723 2019-08-15  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1726         (struct tui_source_windows): New.
1727         * tui/tui-winsource.c (tui_display_main): Update.
1728         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1729         (new_height_ok, parse_scrolling_args): Update.
1730         * tui/tui-layout.c (show_layout, show_data): Update.
1731         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1732         (tui_add_to_source_windows): Don't declare.
1733         * tui/tui-data.c (source_windows, tui_source_windows)
1734         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1735
1736 2019-08-15  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1739         Rename from reset.
1740         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1741         * tui/tui-layout.c (show_source_disasm_command, show_data):
1742         Update.
1743         (tui_gen_win_info::resize): Rename.
1744         (show_source_or_disasm_and_command): Update.
1745         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1746         reset.
1747
1748 2019-08-15  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1751         * tui/tui-interp.c (tui_interp::init): Don't call
1752         tui_initialize_static_data.
1753         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1754
1755 2019-08-15  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1758         examine tui_win_list.
1759
1760 2019-08-15  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1763         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1764         tui_clear_source_content.
1765         (tui_clear_source_content): Remove.
1766         (tui_source_window_base::do_erase_source_content): Hoist call to
1767         content.clear().
1768         * tui/tui-stack.c (tui_show_frame_info): Don't call
1769         tui_clear_source_content.
1770
1771 2019-08-15  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-winsource.h (struct tui_source_window_base)
1774         <do_erase_source_content>: New method.
1775         <erase_source_content>: New method.
1776         (tui_erase_source_content): Don't declare.
1777         * tui/tui-winsource.c (tui_clear_source_content): Update.
1778         (tui_source_window_base::do_erase_source_content): Rename from
1779         tui_erase_source_content.
1780         (tui_source_window_base::show_source_content): Update.
1781         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1782         * tui/tui-source.h (struct tui_source_window)
1783         <erase_source_content>: New method.
1784         * tui/tui-disasm.h (struct tui_disasm_window)
1785         <erase_source_content>: New method.
1786
1787 2019-08-15  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1790         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1791         constructor.
1792         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1793         * tui/tui-source.c (tui_set_source_content): Update.
1794         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1795
1796 2019-08-15  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1799         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1800         tui-source.c.
1801         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1802         Declare.
1803         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1804         method.
1805         (tui_source_window::maybe_update): Update.
1806
1807 2019-08-15  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1810         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1811         tui-disasm.c.
1812         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1813         Declare.
1814         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1815         method.
1816         (tui_disasm_window::maybe_update): Update.
1817
1818 2019-08-15  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-winsource.h (struct tui_source_window_base)
1821         <maybe_update>: Declare.
1822         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1823         method.
1824         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1825         Declare.
1826         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1827         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1828         Declare.
1829         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1830
1831 2019-08-15  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1834
1835 2019-08-15  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-wingeneral.c: Include tui-stack.h.
1838         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1839         (struct tui_locator_window): Move from tui-data.h.
1840         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1841         (tui_initialize_static_data): Move from tui-data.c.
1842         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1843         (struct tui_locator_window): Move to tui-stack.c.
1844         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1845         (tui_initialize_static_data): Move to tui-stack.c.
1846
1847 2019-08-15  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-layout.c (show_source_disasm_command)
1850         (show_source_or_disasm_and_command): Use make_visible method, not
1851         tui_make_window.
1852         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1853         Remove.
1854
1855 2019-08-15  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-wingeneral.h (tui_make_window): Update.
1858         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1859         parameter.
1860         (tui_gen_win_info::make_visible): Update.
1861         * tui/tui-regs.c (tui_data_window::display_registers_from):
1862         Update.
1863         * tui/tui-layout.c (show_source_disasm_command)
1864         (show_source_or_disasm_and_command): Update.
1865         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1866         (enum tui_box): Remove.
1867         (struct tui_win_info) <can_box>: New method.
1868         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1869         method.
1870
1871 2019-08-15  Tom de Vries  <tdevries@suse.de>
1872
1873         * linux-nat-trad.c: Include gdbarch.h.
1874
1875 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1876
1877         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1878         register sizes.
1879
1880 2019-08-14  Tom Tromey  <tromey@adacore.com>
1881
1882         * darwin-nat.c: Include gdbarch.h.
1883         * darwin-nat-info.c: Include gdbarch.h.
1884
1885 2019-08-13  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1888         Remove.
1889         * tui/tui-data.c (tui_initialize_static_data): Update.
1890
1891 2019-08-13  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-winsource.h (struct tui_exec_info_window)
1894         <~tui_exec_info_window, maybe_allocate_content, get_content,
1895         m_content>: Remove.
1896         (struct tui_source_window_base) <set_exec_info_content,
1897         show_exec_info_content>: Don't declare.
1898         * tui/tui-winsource.c
1899         (tui_exec_info_window::maybe_allocate_content): Remove.
1900         (tui_source_window_base::update_exec_info): Rename from
1901         set_exec_info_content.
1902         (tui_source_window_base::show_exec_info_content)
1903         (tui_source_window_base::update_exec_info): Remove.
1904
1905 2019-08-13  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1908         declare.
1909         * tui/tui-winsource.c (tui_update_source_window_as_is)
1910         (tui_update_source_windows_with_addr, tui_erase_source_content):
1911         Update.
1912         (tui_clear_exec_info_content): Remove.
1913
1914 2019-08-13  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1917         declare.
1918         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1919         call tui_erase_exec_info_content.
1920         (tui_clear_exec_info_content): Rename from
1921         tui_erase_exec_info_content.
1922         (tui_clear_exec_info_content): Delete.
1923
1924 2019-08-13  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-winsource.h (struct tui_source_window_base)
1927         <show_exec_info_content>: Declare.
1928         (tui_show_exec_info_content): Don't declare.
1929         * tui/tui-winsource.c
1930         (tui_source_window_base::show_exec_info_content): Rename from
1931         tui_show_exec_info_content.
1932         (tui_source_window_base::update_exec_info): Update.
1933
1934 2019-08-13  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1937         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1938         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1939         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1940         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1941         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1942         ... here.
1943
1944 2019-08-13  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.h (struct tui_source_window_base)
1947         <update_exec_info>: Declare.
1948         (tui_update_exec_info): Don't declare.
1949         * tui/tui-winsource.c (tui_update_source_window_as_is)
1950         (tui_source_window_base::refresh_all)
1951         (tui_update_all_breakpoint_info): Update.
1952         (tui_source_window_base::update_exec_info): Rename from
1953         tui_update_exec_info.
1954         * tui/tui-stack.c (tui_show_frame_info): Update.
1955
1956 2019-08-13  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-winsource.h (struct tui_source_window_base)
1959         <set_exec_info_content>: Declare.
1960         (tui_set_exec_info_content): Don't declare.
1961         * tui/tui-winsource.c
1962         (tui_source_window_base::set_exec_info_content): Rename from
1963         tui_set_exec_info_content.
1964         (tui_update_exec_info): Update.
1965
1966 2019-08-13  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-winsource.h (struct tui_source_window_base)
1969         <show_source_content>: Declare.
1970         (tui_show_source_content): Don't declare.
1971         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1972         (tui_source_window_base::show_source_content): Rename from
1973         tui_show_source_content.
1974         (tui_source_window_base::refresh_all): Update.
1975         * tui/tui-layout.c (show_source_disasm_command)
1976         (show_source_or_disasm_and_command): Update.
1977
1978 2019-08-13  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.c (tui_erase_source_content)
1981         (tui_show_source_content, tui_source_window_base::refresh_all):
1982         Update.
1983         * tui/tui-wingeneral.h
1984         (tui_check_and_display_highlight_if_needed): Don't declare.
1985         * tui/tui-wingeneral.c
1986         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1987         check_and_display_highlight_if_needed.
1988         * tui/tui-win.c (tui_rehighlight_all)
1989         (tui_win_info::make_visible_with_new_height): Update.
1990         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1991         (tui_data_window::erase_data_content)
1992         (tui_data_window::display_all_data): Update.
1993         * tui/tui-data.h (struct tui_win_info)
1994         <check_and_display_highlight_if_needed>: Declare.
1995
1996 2019-08-13  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-win.c (tui_resize_all): Call
1999         tui_delete_invisible_windows.
2000         * tui/tui-layout.c (show_layout): Call
2001         tui_delete_invisible_windows.
2002         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2003         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2004
2005 2019-08-13  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2008         tui_add_win_to_layout.
2009
2010 2019-08-13  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2013         * tui/tui-layout.c (tui_default_win_height): Now static.
2014
2015 2019-08-13  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2018         single switch.
2019         (show_source_disasm_command, show_source_or_disasm_and_command):
2020         Don't check current layout.
2021
2022 2019-08-13  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-wingeneral.c (make_all_visible): Remove.
2025         (tui_make_all_invisible): Simplify.
2026         * tui/tui-layout.c (tui_make_all_invisible): Move from
2027         tui-wingeneral.c; simplify.
2028         (show_layout): Hoist call to tui_make_all_invisible.
2029         (show_data): Don't call tui_make_all_invisible.
2030
2031 2019-08-13  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2034         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2035
2036 2019-08-13  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2039         tui-data.c.
2040         (show_source_disasm_command, show_data)
2041         (show_source_or_disasm_and_command): Don't use
2042         tui_set_current_layout_to.
2043         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2044         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2045         tui-layout.c.
2046         (tui_set_current_layout_to): Remove.
2047
2048 2019-08-13  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-layout.c (tui_set_layout): Update.
2051         * tui/tui-data.h (struct tui_layout_def): Remove.
2052         (tui_layout_def): Don't declare.
2053         * tui/tui-data.c (layout_def): Remove.
2054         (tui_layout_def): Remove.
2055
2056 2019-08-13  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-winsource.h (struct tui_source_window_base)
2059         <clear_detail>: No longer "override".
2060         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2061         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2062         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2063         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2064         Remove.
2065         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2066
2067 2019-08-13  Tom Tromey  <tromey@adacore.com>
2068
2069         * tracepoint.c: Don't include readline.h or history.h.
2070
2071 2019-08-12  Tom Tromey  <tom@tromey.com>
2072
2073         * configure: Rebuild.
2074         * configure.ac: Check for readline 7.
2075         * NEWS: Mention readline 7 requirement.
2076         * README: Update.
2077
2078 2019-08-12  Tom Tromey  <tom@tromey.com>
2079
2080         * mingw-hdep.c (gdb_select): Remove readline hack.
2081
2082 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2083
2084         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2085         when the function fails.
2086
2087 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2088
2089         * s390-tdep.c (s390_type_align): New function.
2090         (s390_gdbarch_init): Set it as type_align gdbarch method.
2091
2092 2019-08-09  Tom de Vries  <tdevries@suse.de>
2093
2094         PR gdb/24591
2095         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2096         pc_low with relocation offset.
2097
2098 2019-08-07  Tom Tromey  <tromey@adacore.com>
2099
2100         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2101         (print_frame_args): Update.
2102         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2103         Update.
2104         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2105         * frame.h (struct frame_arg): Add initializers.
2106         <error>: Now a unique_xmalloc_ptr.
2107
2108 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2109
2110         * NEWS: Expand the Pointer Authentication entry.
2111         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2112         (aarch64_frame_unmask_lr): ... to this.
2113         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2114         Call aarch64_frame_unmask_lr.
2115         * frame.c (struct frame_info): Add "masked" variable.
2116         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2117         (fprint_frame): Check for masked pc.
2118         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2119         declarations.
2120         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2121         * stack.c (print_frame): Check for masked pc.
2122
2123 2019-08-06  Tom Tromey  <tom@tromey.com>
2124
2125         * stabsread.c (patch_block_stabs, read_one_struct_field)
2126         (read_enum_type): Use obstack_strndup.
2127         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2128         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2129         * dwarf2read.c (guess_full_die_structure_name)
2130         (anonymous_struct_prefix): Use obstack_strndup.
2131         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2132         * c-exp.y (yylex): Use obstack_strndup.
2133         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2134         (write_var_or_type): Use obstack_strndup.
2135
2136 2019-08-06  Tom Tromey  <tom@tromey.com>
2137
2138         * symfile.c (reread_symbols): Use obstack_strdup.
2139         * stabsread.c (read_type): Use obstack_strdup.
2140         * gdb_obstack.h (obstack_strdup): New overload.
2141         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2142         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2143         (dwarf2_canonicalize_name): Use obstack_strdup.
2144         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2145         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2146         Use obstack_strdup.
2147
2148 2019-08-06  Tom Tromey  <tom@tromey.com>
2149
2150         * gdb_obstack.h (obstack_strdup): Define.
2151         * gdb_obstack.c (obstack_strdup): Don't define.
2152
2153 2019-08-06  Tom Tromey  <tom@tromey.com>
2154
2155         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2156         obstack_strdup.
2157         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2158         obstack_strdup.
2159         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2160         * stabsread.c (common_block_start): Use obstack_strdup.
2161         * objfiles.c (set_objfile_main_name, objfile): Use
2162         obstack_strdup.
2163         * namespace.c (add_using_directive): Use obstack_strdup.
2164         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2165         * jit.c (finalize_symtab): Use obstack_strdup.
2166         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2167         (guess_partial_die_structure_name, partial_die_info::fixup)
2168         (dwarf2_name): Use obstack_strdup.
2169         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2170         obstack_strdup.
2171         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2172         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2173         obstack_strdup.
2174         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2175
2176 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2177
2178         * unittests/help-doc-selftests.c: New file.
2179         * Makefile.in: Add the new file.
2180
2181 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2182
2183         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2184         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2185         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2186         the trailing '.' is not output, and the first character is uppercased.
2187         (print_help_for_command): Update call to print_doc_line.
2188         (print_doc_of_command): Likewise.
2189         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2190         * cli/cli-option.c (append_indented_doc): Do not append newline.
2191         (build_help_option): Append newline after first appended_indented_doc
2192         only if a second call is done.
2193         (build_help): Append 2 new lines before each option, except the first
2194         one.
2195         * compile/compile.c (_initialize_compile): Add new lines after
2196         %OPTIONS%, when not at the end of the help.
2197         Change help doc or code
2198         producing the help doc to respect the invariants.
2199         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2200         Also removed the new line after 'Options:', as all other commands
2201         do not put an empty line between 'Options:' and the first option.
2202         * printcmd.c (_initialize_printcmd): Likewise.
2203         * stack.c (_initialize_stack): Likewise.
2204         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2205         incorrectly telling COMMAND is optional.
2206         * ada-lang.c (_initialize_ada_language): Change help doc or code
2207         producing the help doc to respect the invariants.
2208         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2209         * breakpoint.c (_initialize_breakpoint): Likewise.
2210         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2211         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2212         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2213         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2214         _initialize_cli_style): Likewise.
2215         * corelow.c (core_target_info): Likewise.
2216         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2217         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2218         * filesystem.c (_initialize_filesystem): Likewise.
2219         * frame.c (_initialize_frame): Likewise.
2220         * gnu-nat.c (add_task_commands): Likewise.
2221         * infcall.c (_initialize_infcall): Likewise.
2222         * infcmd.c (_initialize_infcmd): Likewise.
2223         * interps.c (_initialize_interpreter): Likewise.
2224         * language.c (_initialize_language): Likewise.
2225         * linux-fork.c (_initialize_linux_fork): Likewise.
2226         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2227         * maint.c (_initialize_maint_cmds): Likewise.
2228         * memattr.c (_initialize_mem): Likewise.
2229         * printcmd.c (_initialize_printcmd): Likewise.
2230         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2231         _RegEx): Likewise.
2232         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2233         * record-btrace.c (_initialize_record_btrace): Likewise.
2234         * record-full.c (_initialize_record_full): Likewise.
2235         * record.c (_initialize_record): Likewise.
2236         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2237         * regcache.c (_initialize_regcache): Likewise.
2238         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2239         _initialize_remote): Likewise.
2240         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2241         * serial.c (_initialize_serial): Likewise.
2242         * skip.c (_initialize_step_skip): Likewise.
2243         * source.c (_initialize_source): Likewise.
2244         * stack.c (_initialize_stack): Likewise.
2245         * symfile.c (_initialize_symfile): Likewise.
2246         * symtab.c (_initialize_symtab): Likewise.
2247         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2248         * top.c (init_main): Likewise.
2249         * tracefile-tfile.c (tfile_target_info): Likewise.
2250         * tracepoint.c (_initialize_tracepoint): Likewise.
2251         * tui/tui-win.c (_initialize_tui_win): Likewise.
2252         * utils.c (add_internal_problem_command): Likewise.
2253         * valprint.c (value_print_option_defs): Likewise.
2254
2255 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2256
2257         PR build/24886
2258         * configure.ac: Drop enable-libmcheck support.
2259         * configure, config.in: Rebuild.
2260         * libmcheck.m4: Remove.
2261         * acinclude.m4: Don't include it.
2262         * Makefile.in: Don't distribute it.
2263         * top.c (print_gdb_configuration): Don't mention it.
2264
2265 2019-08-06  Tom Tromey  <tom@tromey.com>
2266
2267         * utils.c (set_output_style): Sometimes pass stream to
2268         emit_style_escape.
2269         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2270         * record-btrace.c (btrace_insn_history): Update.
2271         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2272         method.
2273         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2274         Update initializers.
2275         <m_uiout>: New field.
2276         <m_di>: Move lower.
2277         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2278         Remove "uiout" parameter.
2279         (dump_insns): Update.
2280         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2281         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2282
2283 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2286         (error_in_psymtab_expansion): Likewise.
2287         (lookup_symbol_via_quick_fns): Likewise.
2288         (basic_lookup_transparent_type_quick): Likewise.
2289         (basic_lookup_transparent_type_1): Likewise.
2290
2291 2019-08-06  Tom Tromey  <tromey@adacore.com>
2292
2293         * source.c (last_source_error): Now bool.
2294         (print_source_lines_base): Make "noprint" bool.  Only open
2295         source file when last_source_visited changes.
2296
2297 2019-08-06  Tom Tromey  <tromey@adacore.com>
2298
2299         * annotate.c (annotate_source_line): Use g_source_cache.
2300         * source-cache.c (source_cache::get_plain_source_lines): Change
2301         parameters.  Populate m_offset_cache.
2302         (source_cache::ensure): New method.
2303         (source_cache::get_line_charpos): New method.
2304         (extract_lines): Move lower.  Change parameters.
2305         (source_cache::get_source_lines): Move lower.
2306         * source-cache.h (class source_cache): Update comment.
2307         <get_line_charpos>: New method.
2308         <get_source_lines>: Update comment.
2309         <clear>: Clear m_offset_cache.
2310         <get_plain_source_lines>: Change parameters.
2311         <ensure>: New method
2312         <m_offset_cache>: New member.
2313         * source.c (forget_cached_source_info_for_objfile): Update.
2314         (info_source_command): Use g_source_cache.
2315         (find_source_lines, open_source_file_with_line_charpos): Remove.
2316         (print_source_lines_base, search_command_helper): Use g_source_cache.
2317         * source.h (open_source_file_with_line_charpos): Don't declare.
2318         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2319         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2320         Use g_source_cache.
2321
2322 2019-08-06  Tom Tromey  <tromey@adacore.com>
2323
2324         * source-cache.c (source_cache::get_plain_source_lines):
2325         Remove "first_line" and "last_line" parameters.
2326         (source_cache::get_source_lines): Cache plain text.
2327         * source-cache.h (class source_cache)
2328         <get_plain_source_lines>: Update.
2329
2330 2019-08-06  Tom Tromey  <tromey@adacore.com>
2331
2332         * source-cache.c (extract_lines): No longer a method.
2333         Changed type of parameter.  Include final newline.
2334         (selftests::extract_lines_test): New function.
2335         (_initialize_source_cache): Likewise.
2336         * source-cache.h (class source_cache)
2337         <extract_lines>: Don't declare.
2338
2339 2019-08-06  Tom Tromey  <tromey@adacore.com>
2340
2341         * breakpoint.c (init_breakpoint_sal): Update.
2342         (breakpoint): Update.
2343         * breakpoint.h (struct breakpoint) <filter>: Now a
2344         unique_xmalloc_ptr.
2345
2346 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2347
2348         * NEWS: Mention dictionary access on blocks.
2349         * python/py-block.c (blpy_getitem): New function.
2350         (block_object_as_mapping): New struct.
2351         (block_object_type): Use new struct for tp_as_mapping field.
2352
2353 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2354
2355         * objfiles.h (objfile): Add a comment describing partial symbols.
2356
2357 2019-08-05  Tom Tromey  <tromey@adacore.com>
2358
2359         * compile/compile.c (_initialize_compile): Use _(), not N_().
2360         * thread.c (_initialize_thread): Use _(), not N_().
2361         * stack.c (_initialize_stack): Use _(), not N_().
2362         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2363
2364 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2365
2366         * dwarf2read.c (struct dw2_symtab_iterator):
2367         <want_specific_block>: Remove.
2368         <block_index>: Change type to gdb::optional.
2369         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2370         change type of BLOCK_INDEX parameter to gdb::optional.
2371         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2372         (dw2_lookup_symbol): Don't pass argument for
2373         WANT_SPECIFIC_BLOCK.
2374         (dw2_expand_symtabs_for_function): Don't pass argument for
2375         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2376         (class dw2_debug_names_iterator)
2377         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2378         parameter, change BLOCK_INDEX type to gdb::optional.
2379         <m_want_specific_block>: Remove.
2380         <m_block_index>: Change type to gdb::optional.
2381         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2382         gdb::optional.  Re-write in function of gdb::optional.
2383         (dw2_debug_names_lookup_symbol): Don't pass argument for
2384         WANT_SPECIFIC_BLOCK.
2385         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2386         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2387         BLOCK_INDEX.
2388
2389 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2390
2391         * NEWS: Mention changes to "info sources" command.
2392
2393 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2394
2395         * symtab.c (filename_partial_match_opts): New struct type.
2396         (struct output_source_filename_data): New members
2397         regexp, c_regexp, partial_match.
2398         (output_source_filename): Use new members to decide to print file.
2399         (info_sources_option_defs): New variable.
2400         (make_info_sources_options_def_group, print_info_sources_header,
2401         info_sources_command_completer):
2402         New functions.
2403         (info_sources_command): Read new optional arguments.
2404         (_initialize_symtab): Update info sources help.
2405
2406 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2407
2408         * ada-lang.c (exception_support_info_v0): Renamed from...
2409         (default_exception_support_info): ... this.  Create new
2410         definition for v1.
2411         (ada_has_this_exception_support): Look up catch_handlers_sym.
2412         (ada_exception_support_info_sniffer): Try v0 after default.
2413
2414 2019-08-01  Tom Tromey  <tromey@adacore.com>
2415
2416         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2417         gdbarch.h.
2418
2419 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2420
2421         * s12z-tdep.c: Fix include path for s12z-opc.h.
2422
2423 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2424
2425         * NEWS: Require GNU make 3.82.
2426
2427 2019-07-16  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2430         declare.
2431
2432 2019-07-30  Tom Tromey  <tromey@adacore.com>
2433
2434         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2435
2436 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2437
2438         * printcmd.c (print_address_symbolic): Print negative offsets.
2439         (build_address_symbolic): Force signed arithmetic when computing
2440         offset.
2441
2442 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2443
2444         PR/24474: Add a function to lookup static variables.
2445         * NEWS: Mention this new function.
2446         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2447         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2448         * python/python.c (python_GdbMethods): Add new function.
2449
2450 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2451
2452         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2453         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2454         (objfpy_lookup_static_symbol): New function.
2455         (objfile_object_methods): Add new functions.
2456
2457 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2458
2459         * NEWS: Mention 'set|show print frame-info'.  Mention new
2460         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2461         backtrace argument.  Mention that python frame filtering code
2462         is now consistent with what 'backtrace' command prints.
2463
2464 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2465
2466         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2467         comments.
2468         (print_frame_info_auto, print_frame_info_source_line,
2469         print_frame_info_location, print_frame_info_source_and_location,
2470         print_frame_info_location_and_address, print_frame_info_short_location):
2471         New declarations.
2472         (struct frame_print_options): New member print_frame_info.
2473         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2474         * stack.h (get_user_print_what_frame_info): New declaration.
2475         (frame_show_address): New declaration.
2476         * stack.c (print_frame_arguments_choices): New value 'presence'.
2477         (print_frame_info_auto, print_frame_info_source_line,
2478         print_frame_info_location, print_frame_info_source_and_location,
2479         print_frame_info_location_and_address, print_frame_info_short_location,
2480         print_frame_info_choices, print_frame_info_print_what): New definitions.
2481         (print_frame_args): Only print dots for args if print frame-arguments
2482         is 'presence'.
2483         (frame_print_option_defs): New element for "frame-info".
2484         (get_user_print_what_frame_info): New function.
2485         (frame_show_address): Make non static.  Move comment to stack.h.
2486         (print_frame_info_to_print_what): New function.
2487         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2488         to decide what to print.
2489         (backtrace_command_1): Handle the new print_frame_arguments_presence
2490         value.
2491         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2492         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2493         (py_print_frame): In non-mi mode, use LOCATION as default for
2494         print_what, similarly to frame information printed directly by
2495         backtrace command. Handle frame-info user option in non MI mode.
2496
2497 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2498
2499         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2500         Add case for debugging 32-bit target on 64-bit host.  Revise
2501         comment.
2502
2503 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2504
2505         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2506         instead of find_function_entry_range_from_pc.
2507
2508 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2509
2510         * stack.c (find_frame_funname): Remove code which preferred
2511         minsym over symtab sym in "certain pathological cases".
2512
2513         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2514         parameter.  Change type of "do_demangle" to bool.
2515         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2516         Pass suitable "prefer_sym_over_minsym" flag to
2517         build_address_symbolic().  Don't output "+" for negative offsets.
2518         * printcmd.c (print_address_symbolic): Update invocation of
2519         build_address_symbolic to include a "prefer_sym_over_minsym"
2520         flag.
2521         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2522         Restrict cases in which use of minimal symbol is preferred to that
2523         of a found symbol.  Update comments.
2524
2525         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2526         for entry pc when entry pc is out of range for that FDE.
2527
2528 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2529
2530         PR gdb/24839:
2531         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2532         type.
2533
2534 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2535
2536         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2537         this function's Python signature.
2538
2539
2540 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2541
2542         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2543         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2544         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2545         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2546         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2547
2548
2549 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2550
2551         * h8300-tdep.c (h8300_register_name_common): New.
2552         h8300_register_name): Use h8300_register_name_common.
2553         (h8300s_register_name): Likewise.
2554         (h8300sx_register_name): Likewise.
2555         (h8300h_register_nam): New.
2556         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2557
2558
2559 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2560
2561         * arm-tdep.c (arm_skip_cmse_entry): New function.
2562         (arm_is_sgstubs_section): New function.
2563         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2564
2565 2019-07-22  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2568         Don't self-assign.
2569
2570 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2573         type_print.
2574
2575 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2578         so that GDB doesn't match any msymbols when searching in the
2579         TYPES_DOMAIN.
2580         (print_symbol_info): Print using typedef_print or type_print based
2581         on the type of the symbol.  Add updated FIXME comment moved from...
2582         (_initialize_symtab): ... move and update FIXME comment to above.
2583
2584 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2585
2586         * NEWS: Mention adding -q option to "info types".
2587         * symtab.c (struct info_types_options): New struct.
2588         (info_types_options_defs): New variable.
2589         (make_info_types_options_def_group): New function.
2590         (info_types_command): Use gdb::option framework to parse options.
2591         (info_types_command_completer): New function.
2592         (_initialize_symtab): Extend the help text on "info types" and
2593         register command completer.
2594
2595 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2596
2597         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2598         (lookup_symbol_in_objfile): Change int to block_enum and add a
2599         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2600
2601 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2602
2603         * MAINTAINERS (Write After Approval): Add self.
2604
2605 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2608         instruction to the dummy code region.
2609
2610 2019-07-19  Tom Tromey  <tromey@adacore.com>
2611
2612         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2613         (ARGSUSED, PARAMS, __func__): Remove rules.
2614
2615 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2616
2617         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2618         * features/arm/arm-with-iwmmxt.c: Remove.
2619         * features/arm/arm-with-iwmmxt.xml: Remove.
2620         * features/arm/arm-with-m-fpa-layout.c: Remove.
2621         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2622         * features/arm/arm-with-m-vfp-d16.c: Remove.
2623         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2624         * features/arm/arm-with-m.c: Remove.
2625         * features/arm/arm-with-m.xml: Remove.
2626         * features/arm/arm-with-neon.c: Remove.
2627         * features/arm/arm-with-neon.xml: Remove.
2628         * features/arm/arm-with-vfpv2.c: Remove.
2629         * features/arm/arm-with-vfpv2.xml: Remove.
2630         * features/arm/arm-with-vfpv3.c: Remove.
2631         * features/arm/arm-with-vfpv3.xml: Remove.
2632
2633 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2634
2635         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2636
2637 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2638
2639         * arch/aarch32.c (aarch32_create_target_description): Create
2640         target descriptions using features.
2641         * arch/arm.c (arm_create_target_description)
2642         (arm_create_mprofile_target_description): Likewise.
2643         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2644
2645 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2646
2647         * Makefile.in: Add new files.
2648         * aarch32-tdep.c: New file.
2649         * aarch32-tdep.h: New file.
2650         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2651         Call aarch32_read_description.
2652         * arch/aarch32.c: New file.
2653         * arch/aarch32.h: New file.
2654         * arch/arm.c (arm_create_target_description)
2655         (arm_create_mprofile_target_description): New function.
2656         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2657         (arm_create_target_description)
2658         (arm_create_mprofile_target_description): New declaration.
2659         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2660         read_description functions.
2661         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2662         Likewise.
2663         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2664         * arm-tdep.c (tdesc_arm_list): New variable.
2665         (arm_register_g_packet_guesses): Call create description functions.
2666         (arm_read_description) (arm_read_mprofile_description): New
2667         function.
2668         * arm-tdep.h (arm_read_description)
2669         (arm_read_mprofile_description): Add declaration.
2670         * configure.tgt: Add new files.
2671
2672 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2673
2674         * top.c (new_ui_command): Open specified terminal just once.
2675
2676 2019-07-18  Tom Tromey  <tromey@adacore.com>
2677
2678         * symtab.c (main_name): Constify return type.
2679         * symfile.c (set_initial_language): Update.
2680         * symtab.h (main_name): Constify return type.
2681
2682 2019-07-17  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-winsource.c (tui_update_source_window)
2685         (tui_update_source_window_as_is)
2686         (tui_update_source_windows_with_line): Remove return.
2687         * tui/tui-disasm.c (tui_show_disassem)
2688         (tui_show_disassem_and_update_source): Remove return.
2689         * tui/tui.c (tui_reset): Remove return.
2690         * tui/tui-wingeneral.c
2691         (tui_check_and_display_highlight_if_needed): Remove return.
2692
2693 2019-07-17  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2696
2697 2019-07-17  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-winsource.h (struct tui_exec_info_window)
2700         (struct tui_source_window_base): Move from tui-data.h.
2701         * tui/tui-winsource.c: Move many method definitions from
2702         elsewhere.  Remove "structuring" comments.
2703         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2704         (tui_source_window_base::refresh_window): Move to
2705         tui-winsource.c.
2706         * tui/tui-win.c (tui_source_window_base::refresh_all)
2707         (tui_source_window_base::update_tab_width)
2708         (tui_source_window_base::set_new_height)
2709         (tui_source_window_base::do_make_visible_with_new_height): Move to
2710         tui-winsource.c.
2711         * tui/tui-source.h: Update.
2712         * tui/tui-source.c (tui_source_window_base::reset): Move to
2713         tui-winsource.c.
2714         * tui/tui-disasm.h: Update.
2715         * tui/tui-data.h (struct tui_exec_info_window): Move to
2716         tui-winsource.h.
2717         (struct tui_source_window_base): Likewise.
2718         * tui/tui-data.c (tui_source_window_base::clear_detail)
2719         (tui_source_window_base, ~tui_source_window_base): Move to
2720         tui-winsource.c.
2721
2722 2019-07-17  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-win.c (tui_resize_all)
2725         (tui_source_window_base::update_tab_width)
2726         (tui_adjust_win_heights): Update.
2727         (tui_win_info::make_invisible_and_set_new_height): Rename from
2728         make_invisible_and_set_new_height.
2729         * tui/tui-data.h (struct tui_win_info)
2730         <make_invisible_and_set_new_height>: New method.
2731
2732 2019-07-17  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui.c: Update.
2735         * tui/tui-source.h (struct tui_source_window): Move from
2736         tui-data.h.
2737         * tui/tui-layout.c: Update.
2738         * tui/tui-disasm.c: Update.
2739         * tui/tui-data.h (struct tui_source_window): Move to
2740         tui-source.h.
2741
2742 2019-07-17  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2745         tui-data.h.
2746         * tui/tui-data.h (struct tui_disasm_window): Move to
2747         tui-disasm.h.
2748
2749 2019-07-17  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-regs.h (struct tui_data_item_window): Move from
2752         tui-data.h.
2753         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2754         * tui/tui-data.h (struct tui_data_item_window): Move to
2755         tui-regs.h.
2756         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2757
2758 2019-07-17  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui.c: Update.
2761         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2762         (tui_cmd_window::max_height): Move to tui-command.c.
2763         * tui/tui-layout.c: Update.
2764         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2765         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2766         tui-command.c.
2767         * tui/tui-command.h (struct tui_cmd_window): Move from
2768         tui-data.h.
2769         * tui/tui-command.c: Remove "structuring" comments.
2770         (tui_cmd_window::clear_detail)
2771         (tui_cmd_window::do_make_visible_with_new_height)
2772         (tui_cmd_window::max_height): Move from elsewhere.
2773
2774 2019-07-17  Tom Tromey  <tom@tromey.com>
2775
2776         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2777         Now static.
2778         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2779         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2780
2781 2019-07-17  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui.c: Update.
2784         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2785         tui-regs.c.
2786         * tui/tui-windata.h: Remove file.
2787         * tui/tui-windata.c: Remove file.
2788         * tui/tui-win.c (tui_data_window::set_new_height)
2789         (tui_data_window::do_make_visible_with_new_height): Move to
2790         tui-regs.c.
2791         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2792         * tui/tui-regs.c: Remove "structuring" comments.
2793         (tui_data_window::first_data_item_displayed)
2794         (tui_data_window::delete_data_content_windows)
2795         (tui_data_window::erase_data_content)
2796         (tui_data_window::display_all_data)
2797         (tui_data_window::refresh_all)
2798         (tui_data_window::do_scroll_vertical)
2799         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2800         (tui_data_window::do_make_visible_with_new_height)
2801         (tui_data_window::refresh_window): Move from elsewhere.
2802         (_initialize_tui_regs): Move to end of file.
2803         * tui/tui-layout.c: Update.
2804         * tui/tui-hooks.c: Update.
2805         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2806         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2807         tui-regs.c.
2808         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2809
2810 2019-07-17  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2813         seen.
2814
2815 2019-07-17  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-win.c (tui_source_window_base::set_new_height)
2818         (tui_source_window_base::do_make_visible_with_new_height): Use
2819         m_has_locator field directly.
2820         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2821         method.
2822         (struct tui_source_window_base) <has_locator>: Likewise.
2823
2824 2019-07-17  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2827         Don't declare.
2828         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2829         Remove.
2830         * tui/tui-win.c (tui_source_window_base::set_new_height)
2831         (tui_source_window_base::set_new_height)
2832         (make_invisible_and_set_new_height)
2833         (tui_source_window_base::do_make_visible_with_new_height)
2834         (tui_source_window_base::do_make_visible_with_new_height):
2835         Update.
2836         * tui/tui-layout.c (show_source_disasm_command, show_data)
2837         (show_source_or_disasm_and_command): Update.
2838         * tui/tui-layout.c (show_layout): Update.
2839
2840 2019-07-17  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-layout.c (make_data_window): Remove.
2843         (show_data): Unify creation and re-initialization cases.
2844
2845 2019-07-17  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-layout.c (make_source_window, make_disasm_window):
2848         Remove.
2849         (show_data): Unify creation and re-initialization cases.
2850
2851 2019-07-17  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-layout.c (make_command_window): Remove.
2854         (show_source_disasm_command, show_source_or_disasm_and_command):
2855         Unify creation and re-initialization cases.
2856
2857 2019-07-17  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2860         creation and re-initialization cases.
2861
2862 2019-07-17  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-regs.c (tui_get_register): Return void.
2865
2866 2019-07-17  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2869         Simplify.
2870
2871 2019-07-17  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2874         resetting.
2875
2876 2019-07-17  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2879         * tui/tui-regs.c (tui_reg_layout): New function.
2880         (tui_show_registers, tui_reg_command): Use it.
2881         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2882         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2883         parameters.
2884         (tui_layout_command): Remove.
2885
2886 2019-07-17  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-layout.h (tui/tui-layout): Return void.
2889         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2890
2891 2019-07-17  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-layout.c (show_source_disasm_command, show_data):
2894         Update.
2895         (reset_locator): Remove.
2896         (show_source_or_disasm_and_command): Update.
2897
2898 2019-07-17  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-source.c (tui_source_window_base::reset): Remove
2901         win_type parameter.
2902         * tui/tui-layout.c (make_command_window, make_source_window)
2903         (make_disasm_window, make_data_window)
2904         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2905         (reset_locator, show_source_or_disasm_and_command): Update.
2906         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2907         win_type parameter.
2908         (struct tui_source_window_base) <reset>: Likewise.
2909
2910 2019-07-17  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-layout.c (show_source_disasm_command): Use
2913         reset_locator.
2914         (reset_locator): New function.
2915         (init_and_make_win): Remove.
2916         (show_source_or_disasm_and_command): Use reset_locator.
2917
2918 2019-07-17  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2921         condition.
2922         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2923         Remove condition.
2924         * tui/tui-source.c (tui_source_window_base::reset): New method.
2925         * tui/tui-layout.c (make_command_window): Don't call
2926         init_and_make_win.
2927         (make_source_window, make_disasm_window): Don't call
2928         make_source_or_disasm_window.
2929         (make_data_window): Don't call init_and_make_win.  Change calling
2930         convention.
2931         (show_source_disasm_command, show_data): Simplify.
2932         (make_source_or_disasm_window): Remove.
2933         (show_source_or_disasm_and_command): Simplify.
2934         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2935         (struct tui_source_window_base) <reset>: Likewise.
2936         <execution_info>: Remove initializer.
2937         * tui/tui-data.c (tui_source_window_base): Initialize
2938         execution_info.
2939
2940 2019-07-17  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2943         variable.
2944
2945 2019-07-17  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui.c (tui_rl_other_window): Update.
2948         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2949         superclass method first.  Always iterate over regs_content.
2950         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2951         method.
2952         * tui/tui-win.c (tui_set_focus_command): Update.
2953
2954 2019-07-17  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-win.c (tui_set_focus_command): Rename from
2957         tui_set_focus.  Call tui_enable.
2958         (tui_set_focus_command): Remove.
2959
2960 2019-07-17  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2963         refresh_window.
2964         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2965         touchwin.
2966         (tui_data_window::refresh_window): Call refresh_window on data
2967         items.  Always call superclass refresh_window.
2968         (tui_win_info::refresh): Remove.
2969         (tui_source_window_base::refresh_window): Update.
2970         (tui_refresh_all): Update.
2971         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2972         refresh_window.
2973         (show_source_or_disasm_and_command): Likewise.
2974         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2975         (struct tui_source_window_base) <refresh>: Likewise.
2976
2977 2019-07-17  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-winsource.c (tui_clear_source_content)
2980         (tui_show_source_content): Update.
2981         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2982         whether content is empty.
2983         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2984         Remove.
2985
2986 2019-07-17  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2989         window's contents.
2990         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2991         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2992
2993 2019-07-17  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2996         (struct tui_data_item_window): Update.
2997
2998 2019-07-17  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3001         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3002         defines.
3003
3004 2019-07-17  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-winsource.h (tui_erase_source_content)
3007         (tui_clear_source_content): Remove "display_prompt" parameter.
3008         * tui/tui-winsource.c (tui_update_source_window_as_is)
3009         (tui_update_source_windows_with_addr): Update.
3010         (tui_clear_source_content): Remove "display_prompt" parameter.
3011         (tui_erase_source_content): Likewise.  Simplify.
3012         (tui_show_source_content): Update.
3013         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3014         * tui/tui-stack.c (tui_show_frame_info): Update.
3015         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3016         Remove defines.
3017
3018 2019-07-17  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3021         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3022         parameter.
3023         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3024         parameter.
3025
3026 2019-07-17  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-winsource.c (tui_clear_source_content)
3029         (tui_show_source_content, tui_show_exec_info_content)
3030         (tui_clear_exec_info_content): Update.
3031         * tui/tui-stack.c (tui_show_locator_content): Update.
3032         (tui_show_frame_info): Update.
3033         * tui/tui-source.h (tui_source_window): Don't declare.
3034         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3035         from tui_source_is_displayed.
3036         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3037         Remove field.
3038         (struct tui_source_window_base) <content_in_use>: New field.  Now
3039         bool.
3040         (struct tui_source_window) <showing_source_p>: New method.
3041         (TUI_SRC_WIN): Change cast.
3042         * tui/tui-data.c (tui_initialize_static_data): Update.
3043
3044 2019-07-17  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3047         location_matches_p.
3048         * tui/tui-source.c (tui_source_window::location_matches_p): New
3049         method.
3050         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3051         method.
3052         * tui/tui-data.h (struct tui_source_window_base)
3053         <location_matches_p>: New method.
3054         (struct tui_source_window, struct tui_disasm_window)
3055         <location_matches_p>: Likewise.
3056
3057 2019-07-17  Tom Tromey  <tom@tromey.com>
3058
3059         * tui/tui-win.c (tui_set_win_height_command): Rename from
3060         tui_set_win_height.
3061         (tui_set_win_height_command): Remove.
3062
3063 2019-07-17  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-source.c (tui_source_window): New constructor.  Add
3066         observer.
3067         (~tui_source_window): New destructor.
3068         (tui_source_window::style_changed): New method.
3069         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3070         (tui_attach_detach_observers): Update.
3071         * tui/tui-data.h (struct tui_source_window): Make constructor not
3072         inline.  Add destructor.
3073         (struct tui_source_window) <style_changed>: New method.
3074         <m_observable>: New member.
3075
3076 2019-07-17  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3079         * tui/tui-win.c (tui_resize_all): Fix typo.
3080
3081 2019-07-17  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3084         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3085         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3086         * tui/tui-win.c (window_name_completer): Use foreach.
3087         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3088         (update_tab_width): Likewise.
3089         * tui/tui-layout.c (show_layout): Update.
3090         * tui/tui-data.h (class tui_window_iterator): New.
3091         (struct all_tui_windows): New.
3092         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3093
3094 2019-07-17  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3097         parameter.  Don't reference globals.
3098         (tui_reg_command): Update.
3099
3100 2019-07-17  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-regs.c (tui_show_registers): Simplify.
3103
3104 2019-07-17  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-regs.c (tui_show_registers): Update.
3107         (tui_show_register_group): Add win_info parameter.
3108
3109 2019-07-17  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3112         Rename from tui_display_reg_element_at_line.
3113         (tui_data_window::display_registers_from_line): Update.
3114         * tui/tui-data.h (struct tui_data_window)
3115         <display_reg_element_at_line>: New method.
3116
3117 2019-07-17  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-regs.h (tui_display_registers_from)
3120         (tui_display_registers_from_line): Don't declare.
3121         * tui/tui-windata.c (tui_data_window::display_all_data)
3122         (tui_data_window::refresh_all)
3123         (tui_data_window::do_scroll_vertical): Update.
3124         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3125         from tui_display_registers_from.
3126         (tui_display_reg_element_at_line): Update.
3127         (tui_data_window::display_registers_from_line): Rename from
3128         tui_display_registers_from_line.
3129         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3130         display_registers_from_line>: New methods.
3131
3132 2019-07-17  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3135         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3136         from tui_erase_data_content.
3137         (tui_data_window::display_all_data)
3138         (tui_data_window::refresh_all)
3139         (tui_data_window::do_scroll_vertical): Update.
3140         * tui/tui-regs.c (tui_show_registers): Update.
3141         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3142         New method.
3143
3144 2019-07-17  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3147         declare.
3148         * tui/tui-windata.c
3149         (tui_data_window::delete_data_content_windows): Rename from
3150         tui_delete_data_content_windows.
3151         (tui_data_window::display_all_data)
3152         (tui_data_window::do_scroll_vertical): Update.
3153         * tui/tui-data.h (struct tui_data_window)
3154         <delete_data_content_windows>: New method.
3155
3156 2019-07-17  Tom Tromey  <tom@tromey.com>
3157
3158         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3159         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3160
3161 2019-07-17  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3164         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3165         from tui_display_all_data.
3166         * tui/tui-win.c
3167         (tui_data_window::do_make_visible_with_new_height): Update.
3168         * tui/tui-regs.c (tui_show_registers): Update.
3169         * tui/tui-layout.c (tui_set_layout): Update.
3170         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3171         method.
3172
3173 2019-07-17  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3176         * tui/tui-windata.c (tui_display_data_from): Remove.
3177         (tui_data_window::refresh_all): Update.
3178
3179 2019-07-17  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3182         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3183         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3184         tui_display_registers_from_line.
3185         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3186         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3187         "force_display" parameter.
3188
3189 2019-07-17  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3192         declare.
3193         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3194         Rename from tui_first_reg_element_no_inline.
3195         (tui_display_reg_element_at_line)
3196         (tui_display_registers_from_line): Update.
3197         * tui/tui-data.h (struct tui_data_window)
3198         <first_reg_element_no_inline>: New method.
3199
3200 2019-07-17  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-windata.c (tui_display_data_from)
3203         (tui_data_window::do_scroll_vertical): Update.
3204         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3205         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3206         Rename from tui_line_from_reg_element_no.
3207         (tui_display_registers_from_line): Update.
3208         * tui/tui-data.h (struct tui_data_window)
3209         <line_from_reg_element_no>: New method.
3210
3211 2019-07-17  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3214         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3215         tui_last_regs_line_no.
3216         (tui_display_reg_element_at_line)
3217         (tui_display_registers_from_line): Update.
3218         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3219         method.
3220
3221 2019-07-17  Tom Tromey  <tom@tromey.com>
3222
3223         PR tui/24722:
3224         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3225         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3226         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3227         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3228         (tui_update_breakpoint_info): Likewise.
3229         * tui/tui-hooks.c (tui_event_create_breakpoint)
3230         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3231         Update.
3232
3233 2019-07-17  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3236
3237 2019-07-17  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-winsource.c (tui_update_source_window_as_is)
3240         (tui_update_source_windows_with_addr): Update.
3241         * tui/tui-source.h (tui_set_source_content)
3242         (tui_show_symtab_source): Add "win_info" parameter.
3243         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3244         parameter.
3245         (tui_show_symtab_source): Likewise.
3246
3247 2019-07-17  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-wingeneral.c
3250         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3251
3252 2019-07-17  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3255         (struct tui_cmd_window) <can_scroll>: New method.
3256         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3257         method.
3258
3259 2019-07-17  Tom Tromey  <tromey@adacore.com>
3260
3261         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3262         do_field_signed>: Rename.  Change type of "value".
3263         * ui-out.c (ui_out::field_signed): Rename from field_int.
3264         Change type of "value".
3265         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3266         type of "value".
3267         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3268         do_field_int.  Change type of "value".
3269         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3270         do_field_int.  Change type of "value".
3271         * tracepoint.c (trace_status_mi, tfind_1)
3272         (print_one_static_tracepoint_marker): Update.
3273         * thread.c (print_thread_info_1, print_selected_thread_frame):
3274         Update.
3275         * stack.c (print_frame, print_frame_info): Update.
3276         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3277         Update.
3278         * source.c (print_source_lines_base): Update.
3279         * skip.c (info_skip_command): Update.
3280         * record-btrace.c (btrace_ui_out_decode_error)
3281         (btrace_call_history_src_line): Update.
3282         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3283         Update.
3284         * progspace.c (print_program_space): Update.
3285         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3286         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3287         do_field_int.  Change type of "value".
3288         * mi/mi-out.c (mi_ui_out::do_table_begin)
3289         (mi_ui_out::do_table_header): Update.
3290         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3291         type of "value".
3292         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3293         (mi_cmd_data_list_changed_registers, output_register)
3294         (mi_cmd_data_read_memory, mi_load_progress)
3295         (mi_cmd_trace_frame_collected): Update.
3296         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3297         Update.
3298         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3299         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3300         (mi_cmd_var_list_children, varobj_update_one): Update.
3301         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3302         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3303         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3304         * inferior.c (print_inferior): Update.
3305         * gdb_bfd.c (print_one_bfd): Update.
3306         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3307         Update.
3308         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3309         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3310         do_field_int.  Change type of "value".
3311         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3312         do_field_int.  Change type of "value".
3313         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3314         (print_one_breakpoint_location, print_it_catch_fork)
3315         (print_one_catch_fork, print_it_catch_vfork)
3316         (print_one_catch_vfork, print_it_catch_solib)
3317         (print_it_catch_exec, print_it_ranged_breakpoint)
3318         (print_mention_watchpoint, print_mention_masked_watchpoint)
3319         (bkpt_print_it, update_static_tracepoint): Update.
3320         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3321         * break-catch-syscall.c (print_it_catch_syscall): Update.
3322         * ada-tasks.c (print_ada_task_info): Update.
3323         * ada-lang.c (print_it_exception, print_mention_exception):
3324         Update.
3325
3326 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3327
3328         PR breakpoints/24541
3329         * gdbarch.c: Regenerate.
3330         * gdbarch.h: Regenerate.
3331         * gdbarch.sh: Adjust return type and parameter types for
3332         'stap_adjust_register'.
3333         (i386_stap_adjust_register): Adjust signature and return new
3334         register name.
3335         * stap-probe.c (stap_parse_register_operand): Adjust use of
3336         'gdbarch_stap_adjust_register'.
3337
3338 2019-07-17  Tom Tromey  <tromey@adacore.com>
3339
3340         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3341         declare VEC.
3342         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3343         std::vector.
3344         (struct s390_process_info): Add initializers.
3345         (s390_add_process): Use new.
3346         (s390_linux_nat_target::low_forget_process): Use delete.
3347         (s390_linux_nat_target::low_new_fork)
3348         (s390_linux_nat_target::stopped_by_watchpoint)
3349         (s390_linux_nat_target::low_prepare_to_resume)
3350         (s390_linux_nat_target::insert_watchpoint)
3351         (s390_linux_nat_target::insert_hw_breakpoint)
3352         (s390_linux_nat_target::remove_watchpoint)
3353         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3354
3355 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3356
3357         * aarch64-fbsd-nat.c: Include regcache.h.
3358         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3359         argument.
3360         (aarch64_fbsd_nat_target::fetch_registers)
3361         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3362         variable.
3363         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3364
3365 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3366
3367         * fbsd-nat.c: Include gdbarch.h.
3368
3369 2019-07-15  Tom Tromey  <tromey@adacore.com>
3370
3371         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3372
3373 2019-07-15  Tom Tromey  <tromey@adacore.com>
3374
3375         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3376         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3377         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3378         * cli-out.c (cli_ui_out::do_field_int): New method.
3379         * ui-out.c (ui_out::field_unsigned): New method.
3380         * symfile.c (generic_load): Use field_unsigned.
3381         (print_transfer_performance): Likewise.
3382         * record-btrace.c (ui_out_field_uint): Remove.
3383         (btrace_call_history_insn_range, btrace_call_history): Use
3384         field_unsigned.
3385         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3386         field_unsigned.
3387         * ui-out.h (class ui_out) <field_unsigned>: New method.
3388         <do_field_unsigned>: Likewise.
3389
3390 2019-07-15  Tom Tromey  <tromey@adacore.com>
3391
3392         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3393         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3394         * target.c (flash_erase_command): Use field_string.
3395         * infrun.c (print_signal_received_reason): Use field_string.
3396         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3397         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3398         field_string.
3399         * ada-tasks.c (print_ada_task_info): Use field_string.
3400
3401 2019-07-15  Tom Tromey  <tromey@adacore.com>
3402
3403         * target.c (flash_erase_command): Use field_core_addr.
3404         * symfile.c (generic_load): Use field_core_addr.
3405         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3406         Use field_core_addr.
3407         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3408         field_core_addr.
3409
3410 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3413         value if its desired type is smaller than a CORE_ADDR and signed.
3414
3415 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3416
3417         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3418         of changes to field names, and use new is_reference field to
3419         decide if a property is a reference or not.
3420         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3421         field.
3422         (struct dwarf2_property_baton): Update header comment, rename
3423         'referenced_type' to 'property_type' and update comments.
3424         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3425         default property type, store in property baton, update to take
3426         accound of renamed field.
3427         (read_func_scope): Update call to attr_to_dynamic_prop.
3428         (read_array_type): Likewise.
3429         (dwarf2_per_cu_addr_sized_int_type): New function.
3430         (read_subrange_index_type): Move type finding code to
3431         dwarf2_per_cu_addr_sized_int_type.
3432         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3433         (dwarf2_per_cu_addr_type): New function.
3434         (set_die_type): Update calls to attr_to_dynamic_prop.
3435
3436 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3437
3438         * dwarf2read.c (read_subrange_index_type): New function.
3439         (read_subrange_type): Move code into new function and call it.
3440         * gdbtypes.c (create_range_type): Add some asserts.
3441
3442 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3445         update return statements.
3446         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3447         declaration, and update comment to match.
3448         * gdbtypes.c (resolve_dynamic_array): Update call to
3449         dwarf2_evaluate_property to match new return type.
3450
3451 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * valarith.c (value_subscripted_rvalue): Change lowerbound
3454         parameter type from int to LONGEST.
3455         * value.h (value_subscripted_rvalue): Likewise in declaration.
3456
3457 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * cli/cli-utils.c (info_print_command_completer): New function.
3460         * cli/cli-utils.h: Add 'completer.h' include, and forward
3461         declaration for 'struct cmd_list_element'.
3462         (info_print_command_completer): Declare.
3463         * stack.c (_initialize_stack): Add completer for 'info locals' and
3464         'info args'.
3465         * symtab.c (_initialize_symtab): Add completer for 'info
3466         variables' and 'info functions'.
3467         * NEWS: Mention completion for additional info commands.
3468
3469 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3470
3471         * cli/cli-utils.c (extract_info_print_args): Delete.
3472         (extract_arg_maybe_quoted): Delete.
3473         (info_print_options_defs): New variable.
3474         (make_info_print_options_def_group): New function.
3475         (extract_info_print_options): Define new function.
3476         * cli/cli-utils.h (extract_info_print_args): Delete.
3477         (struct info_print_options): New structure.
3478         (extract_info_print_options): Declare new function.
3479         * stack.c (info_locals_command): Update to use new
3480         extract_info_print_options, also add a header comment.
3481         (info_args_command): Likewise.
3482         * symtab.c (info_variables_command): Likewise.
3483         (info_functions_command): Likewise.
3484
3485 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3486
3487         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3488         to extract string arguments.
3489         * common/common-utils.c (extract_string_maybe_quoted): New function.
3490         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3491
3492 2019-07-11  Tom Tromey  <tromey@adacore.com>
3493
3494         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3495         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3496         * top.h (gdbinit): Don't declare.
3497         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3498         into...
3499         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3500         * top.c (gdb_init): Don't call init_cli_cmds.
3501         (gdbinit): Remove.
3502         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3503
3504 2019-07-11  Tom Tromey  <tromey@adacore.com>
3505
3506         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3507         after it has been moved.
3508
3509 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3510
3511         * valops.c (value_must_coerce_to_target): Change return type to
3512         bool.
3513         * value.h (value_must_coerce_to_target): Likewise.
3514
3515 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3516
3517         * breakpoint.c (is_hardware_watchpoint): Remove
3518         forward-declaration.
3519         (is_masked_watchpoint): Change return type to bool.
3520         (is_tracepoint): Likewise.
3521         (is_breakpoint): Likewise.
3522         (is_hardware_watchpoint): Likewise.
3523         (is_watchpoint): Likewise.
3524         (is_no_memory_software_watchpoint): Likewise.
3525         (is_catchpoint): Likewise.
3526         (breakpoint_1): Make FILTER parameter's return type bool.
3527         is_masked_watchpoint): Change return type to bool.
3528         (save_breakpoints): Make FILTER parameter's return type bool.
3529         * breakpoint.h (is_breakpoint): Change return type to bool.
3530         (is_watchpoint): Likewise.
3531         (is_catchpoint): Likewise.
3532         (is_tracepoint): Likewise.
3533
3534 2019-07-10  Tom Tromey  <tom@tromey.com>
3535
3536         * defs.h: Don't include gdbarch.h.
3537         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3538         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3539         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3540         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3541         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3542         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3543         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3544         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3545         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3546         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3547         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3548         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3549         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3550         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3551         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3552         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3553         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3554         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3555         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3556         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3557         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3558         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3559         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3560         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3561         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3562         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3563         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3564
3565 2019-07-10  Tom Tromey  <tromey@adacore.com>
3566
3567         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3568         * breakpoint.c (init_ada_exception_breakpoint): Register as
3569         bp_catchpoint.
3570         (print_one_breakpoint_location, print_one_breakpoint): Use
3571         is_ada_exception_catchpoint.
3572         * ada-lang.c (class ada_catchpoint_location): Pass
3573         bp_loc_software_breakpoint to bp_location constructor.
3574         (is_ada_exception_catchpoint): New function.
3575
3576 2019-07-10  Tom Tromey  <tromey@adacore.com>
3577
3578         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3579         VEC.
3580         (struct arm_exidx_entry): New method operator<.
3581         (struct arm_exidx_data) <section_maps>: Change type.
3582         (arm_exidx_data_free): Remove.
3583         (arm_exidx_data_key): Change type.  Move lower.
3584         (arm_exidx_new_objfile): Update.
3585         (arm_compare_exidx_entries): Remove.
3586         (arm_find_exidx_entry, _initialize_arm_tdep)
3587
3588 2019-07-10  Tom Tromey  <tromey@adacore.com>
3589
3590         * solib-spu.c (ocl_program_data_key): Change type.
3591         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3592         Update.
3593
3594 2019-07-10  Tom Tromey  <tromey@adacore.com>
3595
3596         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3597         (struct solib_aix_inferior_data) <library_list>: Change type.
3598         (solib_aix_inferior_data_handle): Change type.
3599         (get_solib_aix_inferior_data): Update.
3600         (solib_aix_free_library_list): Remove.
3601         (library_list_start_library): Update.
3602         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3603         return type.
3604         (solib_aix_get_library_list)
3605         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3606         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3607
3608 2019-07-10  Tom Tromey  <tromey@adacore.com>
3609
3610         * solib-dsbt.c (struct dsbt_info): Add initializers.
3611         (solib_dsbt_pspace_data): Change type.
3612         (dsbt_pspace_data_cleanup): Remove.
3613         (get_dsbt_info, _initialize_dsbt_solib): Update.
3614
3615 2019-07-10  Tom Tromey  <tromey@adacore.com>
3616
3617         * spu-tdep.c (spu_overlay_data): Change type.
3618         (spu_get_overlay_table, spu_overlay_new_objfile)
3619         (_initialize_spu_tdep): Update.
3620
3621 2019-07-10  Tom Tromey  <tromey@adacore.com>
3622
3623         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3624         destructor.
3625         (dbx_objfile_data_key): Change type and declare later.
3626         (DBX_SYMFILE_INFO): Rewrite.
3627         * dbxread.c (dbx_objfile_data_key): Change type.
3628         (dbx_symfile_init): Update.
3629         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3630         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3631         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3632
3633 2019-07-10  Tom Tromey  <tromey@adacore.com>
3634
3635         * jit.c (jit_program_space_key): Change type.  Move lower.
3636         (get_jit_program_space_data): Update.
3637         (jit_program_space_data_cleanup): Remove.
3638         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3639         Update.
3640         (struct jit_program_space_data): Add initializers.
3641
3642 2019-07-10  Tom Tromey  <tromey@adacore.com>
3643
3644         * solib-darwin.c (struct darwin_info): Add initializers.
3645         (solib_darwin_pspace_data): Change type.
3646         (darwin_pspace_data_cleanup): Remove.
3647         (get_darwin_info, _initialize_darwin_solib): Update.
3648
3649 2019-07-10  Tom Tromey  <tromey@adacore.com>
3650
3651         * remote-sim.c (struct sim_inferior_data): Add initializers,
3652         constructor, and destructor.
3653         (sim_inferior_data_key): Change type.  Move lower.
3654         (check_for_duplicate_sim_descriptor): Update.
3655         (get_sim_inferior_data): Use new.  Update.
3656         (~sim_inferior_data_cleanup): Rename from
3657         sim_inferior_data_cleanup.  Simplify.
3658         (gdbsim_close_inferior, simulator_command)
3659         (sim_command_completer, _initialize_remote_sim): Update.
3660         (next_pid, INITIAL_PID): Move earlier.
3661
3662 2019-07-10  Tom Tromey  <tromey@adacore.com>
3663
3664         * python/python-internal.h (create_thread_object): Return
3665         gdbpy_ref.
3666         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3667         * python/py-inferior.c (struct threadlist_entry): Add
3668         constructor.
3669         <thread_obj>: Now a gdbpy_ref.
3670         (thread_to_thread_object): Update.
3671         (add_thread_object): Use new.
3672         (delete_thread_object): Use delete.
3673         (infpy_threads): Update.
3674         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3675         GIL.
3676
3677 2019-07-10  Tom Tromey  <tromey@adacore.com>
3678
3679         * valops.c (value_cast): Specialize error message for Ada.
3680
3681 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3682
3683         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3684
3685 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3686
3687         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3688         bpstat_should_step): Return bool, adjust comments.
3689         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3690         bpstat_should_step): Likewise.
3691
3692 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3693
3694         * features/Makefile: Use feature target descriptions for Arm.
3695         * features/arm/arm-core.c: Generate new file.
3696         * features/arm/arm-fpa.c: Likewise.
3697         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3698         * features/arm/arm-m-profile.c: Likewise.
3699         * features/arm/arm-vfpv2.c: Likewise.
3700         * features/arm/arm-vfpv3.c: Likewise.
3701         * features/arm/xscale-iwmmxt.c: Likewise.
3702         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3703
3704 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3705
3706         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3707         ptrace earlier.
3708
3709 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3710
3711         * features/aarch64-pauth.c: Regenerate.
3712
3713 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3714
3715         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3716         bool.
3717         (bpstat_what): Use false instead of 0.
3718
3719 2019-07-09  Pedro Alves  <palves@redhat.com>
3720
3721         * break-catch-throw.c (is_exception_catchpoint): New.
3722         * breakpoint.c (print_one_breakpoint_location): New parameter
3723         'raw_loc'.  Handle it.  Use
3724         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3725         looking at the breakpoint's type.
3726         (print_one_breakpoint): If handling "maint info breakpoints", also
3727         print locations of exception catchpoints.
3728         * breakpoint.h (is_exception_catchpoint): Declare.
3729
3730 2019-07-09  Pedro Alves  <palves@redhat.com>
3731
3732         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3733         "addr" field.
3734         (allocate_location_exception_catchpoint): New.
3735         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3736         (initialize_throw_catchpoint_ops): Install
3737         allocate_location_exception_catchpoint as allocate_location
3738         method.
3739         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3740         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3741         bp_loc_other.
3742         (breakpoint_address_is_meaningful): Delete.
3743         (bl_address_is_meaningful): New.
3744         (breakpoint_locations_match): Adjust comment.
3745         (bp_location_from_bp_type): New, factored out of...
3746         (bp_location::bp_location(breakpoint *)): ... this.
3747         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3748         factored out of...
3749         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3750         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3751         breakpoint_address_is_meaningful.
3752         (bp_locations_compare): Adjust comment.
3753         (update_global_location_list): Use bl_address_is_meaningful
3754         instead of breakpoint_address_is_meaningful.
3755         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3756         explicit.
3757         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3758         * python/py-breakpoint.c (bppy_get_location): No longer check
3759         whether location is null.
3760
3761 2019-07-09  Pedro Alves  <palves@redhat.com>
3762
3763         PR c++/15468
3764         * breakpoint.c (print_one_breakpoint_location): Remove
3765         single-location assert.
3766
3767 2019-07-09  Tom Tromey  <tom@tromey.com>
3768
3769         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3770         * configure: Rebuild.
3771         * configure.ac: Change common to gdbsupport.
3772         * gdbsupport: Rename from common.
3773         * acinclude.m4: Change common to gdbsupport.
3774         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3775         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3776         gdbsupport.
3777         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3778         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3779         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3780         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3781         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3782         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3783         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3784         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3785         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3786         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3787         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3788         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3789         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3790         coff-pe-read.c, command.h, compile/compile-c-support.c,
3791         compile/compile-c.h, compile/compile-cplus-symbols.c,
3792         compile/compile-cplus-types.c, compile/compile-cplus.h,
3793         compile/compile-loc2c.c, compile/compile.c, completer.c,
3794         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3795         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3796         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3797         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3798         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3799         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3800         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3801         features/aarch64-core.c, features/aarch64-fpu.c,
3802         features/aarch64-pauth.c, features/aarch64-sve.c,
3803         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3804         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3805         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3806         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3807         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3808         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3809         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3810         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3811         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3812         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3813         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3814         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3815         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3816         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3817         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3818         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3819         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3820         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3821         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3822         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3823         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3824         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3825         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3826         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3827         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3828         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3829         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3830         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3831         minsyms.c, mips-linux-tdep.c, namespace.h,
3832         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3833         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3834         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3835         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3836         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3837         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3838         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3839         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3840         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3841         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3842         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3843         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3844         procfs.c, producer.c, progspace.h, psymtab.h,
3845         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3846         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3847         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3848         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3849         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3850         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3851         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3852         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3853         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3854         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3855         target-memory.c, target.c, target.h, target/waitstatus.c,
3856         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3857         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3858         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3859         unittests/array-view-selftests.c,
3860         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3861         unittests/common-utils-selftests.c,
3862         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3863         unittests/format_pieces-selftests.c,
3864         unittests/function-view-selftests.c,
3865         unittests/lookup_name_info-selftests.c,
3866         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3867         unittests/mkdir-recursive-selftests.c,
3868         unittests/observable-selftests.c,
3869         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3870         unittests/parse-connection-spec-selftests.c,
3871         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3872         unittests/scoped_fd-selftests.c,
3873         unittests/scoped_mmap-selftests.c,
3874         unittests/scoped_restore-selftests.c,
3875         unittests/string_view-selftests.c, unittests/style-selftests.c,
3876         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3877         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3878         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3879         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3880         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3881         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3882
3883 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3886         bool value.
3887         (decode_digits_ordinary): Set explicit_line field in sal.
3888         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3889         symtab_and_line that was set on an explicit line number in
3890         assembler code.  Do always update the recorded symtab and line if
3891         we do skip the prologue.
3892
3893 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * breakpoint.c (set_breakpoint_location_function): Remove
3896         explicit_loc parameter.
3897         (momentary_breakpoint_from_master): Update call to
3898         set_breakpoint_location_function.
3899         (add_location_to_breakpoint): Likewise.
3900
3901 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3904         required features based on default bfd type when no specific bfd
3905         is present.
3906
3907 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3908
3909         * NEWS: Mention that GDB printf and eval commands can now print
3910         C-style and Ada-style convenience var strings without
3911         calling the inferior.
3912         * printcmd.c (printf_c_string): Locally print GDB internal var
3913         instead of transiting via the inferior.
3914         (printf_wide_c_string): Likewise.
3915
3916 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3917
3918         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3919
3920 2019-07-04  Tom Tromey  <tom@tromey.com>
3921
3922         PR tui/24724:
3923         * tui/tui-winsource.c (tui_clear_source_content): Update.
3924         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3925         (tui_update_breakpoint_info): Update.
3926         (tui_set_exec_info_content): Update.
3927         * tui/tui-source.c (tui_set_source_content_nil): Update.
3928         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3929         has_break.
3930         * tui/tui-data.h (enum tui_bp_flag): New.
3931         (tui_bp_flags): New enum flags type.
3932         (struct tui_source_element) <break_mode>: Change type.  Rename
3933         from has_break.
3934         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3935         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3936         constants.
3937         * tui/tui-winsource.h: Fix comment.
3938
3939 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3940
3941         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3942         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3943         (store_fpregs_to_thread)
3944         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3945         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3946         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3947         (IWMMXT_REGS_SIZE): Add define.
3948         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3949         (fetch_vfp_regs, store_vfp_regs)
3950         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3951         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3952
3953 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3954
3955         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3956         defines.
3957         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3958         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3959         (ARM_INT_REGISTER_SIZE): ...to this.
3960         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3961         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3962         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3963         (arm_linux_collect_gregset, supply_nwfpe_register)
3964         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3965         defines.
3966         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3967         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3968         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3969         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3970         (arm_return_in_memory, arm_store_return_value)
3971         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3972         (arm_record_ld_st_multiple): Likewise.
3973         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3974         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3975
3976 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3977
3978         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3979         AARCH64_DISPLACED_MODIFIED_INSNS.
3980         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3981         (aarch64_displaced_step_copy_insn): Likewise.
3982         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3983         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3984         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3985         ARM_DISPLACED_MODIFIED_INSNS.
3986         * arm-tdep.c (arm_gdbarch_init): Likewise.
3987         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3988         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3989         (struct arm_displaced_step_closure): Use
3990         ARM_DISPLACED_MODIFIED_INSNS.
3991
3992 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3993
3994         * features/Makefile: Remove unused xml files.
3995         * features/aarch64.xml: Remove.
3996         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3997         * features/i386/amd64-avx-avx512.xml: Remove.
3998         * features/i386/amd64-avx-linux.xml: Remove.
3999         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4000         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4001         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4002         * features/i386/amd64-avx-mpx.xml: Remove.
4003         * features/i386/amd64-avx.xml: Remove.
4004         * features/i386/amd64-linux.xml: Remove.
4005         * features/i386/amd64-mpx-linux.xml: Remove.
4006         * features/i386/amd64-mpx.xml: Remove.
4007         * features/i386/amd64.xml: Remove.
4008         * features/i386/i386-avx-avx512-linux.xml: Remove.
4009         * features/i386/i386-avx-avx512.xml: Remove.
4010         * features/i386/i386-avx-linux.xml: Remove.
4011         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4012         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4013         * features/i386/i386-avx-mpx-linux.xml: Remove.
4014         * features/i386/i386-avx-mpx.xml: Remove.
4015         * features/i386/i386-avx.xml: Remove.
4016         * features/i386/i386-linux.xml: Remove.
4017         * features/i386/i386-mmx-linux.xml: Remove.
4018         * features/i386/i386-mmx.xml: Remove.
4019         * features/i386/i386-mpx-linux.xml: Remove.
4020         * features/i386/i386-mpx.xml: Remove.
4021         * features/i386/i386.xml: Remove.
4022         * features/i386/x32-avx-avx512-linux.xml: Remove.
4023         * features/i386/x32-avx-linux.xml: Remove.
4024         * features/i386/x32-linux.xml: Remove.
4025
4026 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4027
4028         * regformats/aarch64.dat: Remove.
4029         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4030         * regformats/i386/amd64-avx-linux.dat: Remove.
4031         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4032         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4033         * regformats/i386/amd64-linux.dat: Remove.
4034         * regformats/i386/amd64-mpx-linux.dat: Remove.
4035         * regformats/i386/amd64.dat: Remove.
4036         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4037         * regformats/i386/i386-avx-linux.dat: Remove.
4038         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4039         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4040         * regformats/i386/i386-linux.dat: Remove.
4041         * regformats/i386/i386-mmx-linux.dat: Remove.
4042         * regformats/i386/i386-mpx-linux.dat: Remove.
4043         * regformats/i386/i386.dat: Remove.
4044         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4045         * regformats/i386/x32-avx-linux.dat: Remove.
4046         * regformats/i386/x32-linux.dat: Remove.
4047
4048 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4049
4050         * aarch64-tdep.c: Remove xml self tests.
4051         * amd64-linux-tdep.c: Likewise.
4052         * amd64-tdep.c: Likewise.
4053         * i386-linux-tdep.c: Likewise.
4054         * i386-tdep.c: Likewise.
4055
4056 2019-07-03  Pedro Alves  <palves@redhat.com>
4057
4058         PR cli/24732
4059         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4060         (pipe_cmd_option_defs): New.
4061         (make_pipe_cmd_options_def_group): New.
4062         (pipe_command): Use gdb::option::process_options.
4063         (pipe_command_completer): New function.
4064         (_initialize_cli_cmds): Install completer for "pipe" command.
4065
4066 2019-07-03  Pedro Alves  <palves@redhat.com>
4067
4068         * cli/cli-option.c (union option_value) <string>: New field.
4069         (struct option_def_and_value): Add ctor, move ctor, dtor and
4070         use DISABLE_COPY_AND_ASSIGN.
4071         (option_def_and_value::clear_value): New.
4072         (parse_option, save_option_value_in_ctx, get_val_type_str)
4073         (add_setshow_cmds_for_options): Handle var_string.
4074         * cli-option.h (union option_def::var_address) <string>: New
4075         field.
4076         (struct string_option_def): New.
4077         * maint-test-options.c (struct test_options_opts): Add default
4078         ctor and use DISABLE_COPY_AND_ASSIGN.
4079         <string_opt>: New field.
4080         (test_options_opts::~test_options_opts): New.
4081         (test_options_opts::dump): Also dump "-string".
4082         (test_options_option_defs): Install "string.
4083
4084 2019-07-03  Pedro Alves  <palves@redhat.com>
4085
4086         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4087         option_value with a null enumeration.
4088         (complete_options): Save the option values in the context.
4089         (save_option_value_in_ctx): New, factored out from ...
4090         (process_options): ... here.
4091         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4092         of the function.
4093         * maint-test-options.c (test_options_opts::dump): New, factored
4094         out from ...
4095         (maintenance_test_options_command_mode): ... here.
4096         (maintenance_test_options_command_completion_result): Delete.
4097         (maintenance_test_options_command_completion_text): Update
4098         comment.
4099         (maintenance_show_test_options_completion_result): Change
4100         prototype.  Just print
4101         maintenance_test_options_command_completion_text.
4102         (save_completion_result): New.
4103         (maintenance_test_options_completer_mode): Pass options context to
4104         complete_options, and then save a dump.
4105         (_initialize_maint_test_options): Use add_cmd to install "maint
4106         show test-options-completion-result".
4107
4108 2019-07-03  Pedro Alves  <palves@redhat.com>
4109
4110         * NEWS (New commands): Mention "with" and "maint with".
4111         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4112         (with_command, with_command_completer): New.
4113         (pipe_command): Adjust to new repeat_previous
4114         interface.
4115         (_initialize_cli_cmds): Install the "with" command and its "w"
4116         alias.
4117         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4118         declarations.
4119         * cli/cli-setshow.c (parse_cli_var_uinteger)
4120         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4121         argument strings for all var_types.
4122         (get_setshow_command_value_string): New, factored out from ...
4123         (do_show_command): ... this.
4124         * cli/cli-setshow.h: Include <string>.
4125         (get_setshow_command_value_string): Declare.
4126         * command.h (repeat_previous): Now returns const char *.  Adjust
4127         comment.
4128         * maint.c: Include "cli/cli-cmds.h".
4129         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4130         (_initialize_maint_cmds): Register the "maintenance with" command.
4131         * top.c (repeat_previous): Move bits from pipe_command here:
4132         Return the saved command line, if any; error out if there's no
4133         command to relaunch.
4134
4135 2019-07-03  Pedro Alves  <palves@redhat.com>
4136
4137         * NEWS (New commands): Mention "maint set/show test-settings"
4138         instead of "maint test-settings".
4139         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4140         (maintenance_test_settings_set_list): Rename to ...
4141         (maintenance_set_test_settings_list): ... this.
4142         (maintenance_test_settings_show_list): Rename to  ...
4143         (maintenance_show_test_settings_list): ... this.
4144         (maintenance_test_settings_cmd): Delete.
4145         (maintenance_test_settings_set_cmd): ...
4146         (maintenance_set_test_settings_cmd): ... this.
4147         (maintenance_test_settings_show_cmd): ...
4148         (maintenance_show_test_settings_cmd): ... this.
4149         (maintenance_test_settings_show_value_cmd):
4150         (maintenance_show_test_settings_value_cmd): ... this.
4151         (_initialize_maint_test_settings): No longer install the "maint
4152         test-settings" prefix command.  Rename "maint test-settings set"
4153         to "maint set test-settings", and "maint test-settings show" to
4154         "maint show test-settings".  Adjust all subcommands.
4155
4156 2019-07-03  Pedro Alves  <palves@redhat.com>
4157
4158         * maint-test-settings.c: Fix file's intro comment.  Replace all
4159         references to "test-options" with references to "test-settings",
4160         in comments.
4161
4162 2019-07-03  Pedro Alves  <palves@redhat.com>
4163
4164         * maint-test-settings.c (maintenance_test_settings_xxx)
4165         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4166         New.
4167         (maintenance_test_settings_enums): Use them.
4168         (maintenance_test_settings_enum): Default to
4169         maintenance_test_settings_xxx.
4170         (_initialize_maint_test_settings): Initialize
4171         MAINTENANCE_TEST_SETTINGS_FILENAME.
4172
4173 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4174
4175         * breakpoint.h (remove_breakpoints_inf): Change return type to
4176         void, move function documentation here.
4177         * breakpoint.c (remove_breakpoints_inf): Change return type to
4178         void, move function documentation to header.
4179
4180 2019-07-02  Pedro Alves  <palves@redhat.com>
4181
4182         * NEWS (Completion improvements): Mention "info threads".
4183         * thread.c (struct info_threads_opts, info_threads_option_defs)
4184         (make_info_threads_options_def_group): New.
4185         (info_threads_command): Use gdb::option::process_options.
4186         (info_threads_command_completer): New.
4187         (_initialize_thread): Use gdb::option::build_help to build the
4188         help text for "info threads".
4189
4190 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4191
4192         * defs.h (generic_load): Move from here...
4193         * symfile.h (generic_load): ... to here.  Rename name parameter
4194         to args.
4195         * symfile.c (generic_load): Add comment.
4196
4197 2019-07-01  Tom Tromey  <tromey@adacore.com>
4198
4199         * dwarf2read.c
4200         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4201         declaration of without_params.  Fix formatting.
4202
4203 2019-07-01  Tom Tromey  <tromey@adacore.com>
4204
4205         * ada-exp.y (find_primitive_type): Update.
4206         * ada-lang.h (ada_lookup_symbol): Update.
4207         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4208         parameter.
4209         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4210
4211 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4212
4213         PR breakpoints/24541
4214         * gdbarch.c: Regenerate.
4215         * gdbarch.h: Regenerate.
4216         * gdbarch.sh: Add 'stap_adjust_register'.
4217         * i386-tdep.c: Include '<unordered_set>'.
4218         (i386_stap_adjust_register): New function.
4219         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4220         * stap-probe.c (stap_parse_register_operand): Call
4221         'gdbarch_stap_adjust_register'.
4222
4223 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4224
4225         PR python/24742
4226         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4227         * python/python.c (do_start_initialization): Use 'xmalloc'
4228         instead of 'PyMem_Malloc'.
4229
4230 2019-06-28  Tom Tromey  <tromey@adacore.com>
4231
4232         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4233         for Ada.
4234
4235 2019-06-27  Tom Tromey  <tromey@adacore.com>
4236
4237         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4238         objfile_key.
4239         (arm_find_mapping_symbol, arm_record_special_symbol)
4240         (_initialize_arm_tdep): Update.
4241         (arm_objfile_data_free): Remove.
4242
4243 2019-06-27  Tom Tromey  <tromey@adacore.com>
4244
4245         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4246         to cp_print_static_field.
4247
4248 2019-06-26  Tom Tromey  <tromey@adacore.com>
4249
4250         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4251         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4252         declare.
4253
4254 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4255
4256         * features/aarch64-core.c (create_feature_aarch64_core):
4257         Regenerate.
4258         * features/aarch64-core.xml: Add cpsr flags.
4259
4260 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4263         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4264
4265 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4266
4267         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4268         field.
4269         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4270         use.
4271         (arm_record_special_symbol): Don't insert new symbol in sorted
4272         position, push it at the end.
4273
4274 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4275
4276         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4277         (arm_mapping_symbol_s): Remove.
4278         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4279         (arm_mapping_symbol_vec): New typedef.
4280         (struct arm_per_objfile): Add constructor.
4281         <section_maps>: Change type to
4282         std::unique_ptr<arm_mapping_symbol_vec[]>.
4283         (arm_compare_mapping_symbols): Remove.
4284         (arm_find_mapping_symbol): Adjust to section_maps type change.
4285         (arm_objfile_data_free): Call delete on arm_per_objfile.
4286         (arm_record_special_symbol): Adjust to section_maps type change.
4287         Allocate arm_per_objfile with new.
4288
4289 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4290
4291         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4292         with the command prefix.
4293
4294 2019-06-25  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4297         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4298
4299 2019-06-25  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4302         type.
4303         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4304         protected.
4305
4306 2019-06-25  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-winsource.c
4309         (tui_source_window_base::set_is_exec_point_at): Add check against
4310         LOA_ADDRESS.
4311
4312 2019-06-25  Tom Tromey  <tom@tromey.com>
4313
4314         * tui/tui-source.c (tui_set_source_content): Don't check before
4315         xfree.
4316         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4317
4318 2019-06-25  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-winsource.h (tui_update_source_window_as_is)
4321         (tui_alloc_source_buffer, tui_line_is_displayed)
4322         (tui_addr_is_displayed): Change type of win_info.
4323         * tui/tui-winsource.c (tui_update_source_window_as_is)
4324         (tui_clear_source_content, tui_show_source_line)
4325         (tui_show_source_content, tui_source_window_base::refill)
4326         (tui_source_window_base::set_is_exec_point_at)
4327         (tui_source_window_base::set_is_exec_point_at)
4328         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4329         (tui_alloc_source_buffer, tui_line_is_displayed)
4330         (tui_addr_is_displayed): Change type of win_info.  Update.
4331         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4332         (tui_source_window_base::do_make_visible_with_new_height):
4333         Update.
4334         * tui/tui-source.c (tui_set_source_content)
4335         (tui_set_source_content_nil)
4336         (tui_source_window::do_scroll_vertical): Update.
4337         * tui/tui-layout.c (show_layout): Update.
4338         * tui/tui-disasm.c (tui_set_disassem_content)
4339         (tui_disasm_window::do_scroll_vertical): Update.
4340         * tui/tui-data.h (tui_win_content): Remove.
4341         (struct tui_gen_win_info) <content, content_size>: Remove.
4342         (struct tui_source_element): Add initializers and destructor.
4343         (union tui_which_element, struct tui_win_element): Remove.
4344         (struct tui_source_window_base) <content>: New field.
4345         (struct tui_data_window): Remove destructor.
4346         (tui_alloc_content, tui_free_win_content)
4347         (tui_free_all_source_wins_content): Don't declare.
4348         * tui/tui-data.c (tui_initialize_static_data): Update.
4349         (init_content_element, tui_alloc_content): Remove.
4350         (~tui_gen_win_info): Update.
4351         (~tui_data_window, tui_free_all_source_wins_content)
4352         (tui_free_win_content, free_content, free_content_elements):
4353         Remove.
4354
4355 2019-06-25  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui-winsource.h (tui_clear_source_content)
4358         (tui_erase_source_content, tui_show_source_content): Change type
4359         of win_info.
4360         * tui/tui-winsource.c (tui_clear_source_content)
4361         (tui_erase_source_content, tui_show_source_content): Change type
4362         of win_info.
4363         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4364         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4365         win_info.
4366         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4367         win_info.
4368         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4369
4370 2019-06-25  Tom Tromey  <tom@tromey.com>
4371
4372         * tui/tui-winsource.c (tui_clear_source_content)
4373         (tui_source_window_base::set_is_exec_point_at): Update.
4374         * tui/tui-source.c (tui_set_source_content_nil): Update.
4375         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4376         a bool.
4377         * tui/tui-data.c (init_content_element): Update.
4378
4379 2019-06-25  Tom Tromey  <tom@tromey.com>
4380
4381         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4382         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4383         * tui/tui-layout.c (init_and_make_win): Update.
4384         * tui/tui.h (enum tui_win_type): Update.
4385         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4386         tui_win_is_auxillary.
4387         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4388         tui_win_is_auxillary.
4389
4390 2019-06-25  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4393         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4394         (tui_delete_data_content_windows, tui_display_all_data)
4395         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4396         Update.
4397         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4398         * tui/tui-regs.c (tui_last_regs_line_no)
4399         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4400         (tui_show_registers): Update.
4401         (tui_show_register_group): Return void.  Update.
4402         (tui_display_registers_from, tui_display_reg_element_at_line)
4403         (tui_display_registers_from_line, tui_check_register_values):
4404         Update.
4405         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4406         member.
4407         (struct tui_data_window) <regs_content>: Now a std::vector.
4408         <regs_content_count>: Remove.
4409         (tui_add_content_elements, tui_free_data_content): Don't declare.
4410         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4411         (init_content_element): Remove DATA_WIN case.  Add assert.
4412         (tui_add_content_elements): Remove.
4413         (tui_data_window): Update.
4414         (tui_free_data_content): Remove.
4415         (free_content_elements): Remove DATA_WIN case.
4416
4417 2019-06-25  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-data.c (tui_data_item_window): Update.
4420         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4421         * tui/tui-windata.c (tui_display_all_data)
4422         (tui_display_data_from_line): Update.
4423         (tui_check_data_values): Remove.
4424         * tui/tui-regs.c (tui_show_register_group)
4425         (tui_display_reg_element_at_line): Update.
4426         * tui/tui-hooks.c (tui_register_changed)
4427         (tui_refresh_frame_and_register_information): Call
4428         tui_check_register_values.
4429         * tui/tui-data.h (struct tui_data_window) <data_content,
4430         data_content_count, data_type>: Remove.
4431         (enum tui_data_type): Remove.
4432
4433         * tui/tui-data.c (tui_data_window::clear_detail)
4434         (~tui_data_window): Update.
4435
4436 2019-06-25  Tom Tromey  <tom@tromey.com>
4437
4438         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4439         declare.
4440         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4441         Rename from tui_first_data_item_displayed.  Update.
4442         (tui_data_window::refresh_all)
4443         (tui_data_window::do_scroll_vertical): Update.
4444         * tui/tui-data.h (struct tui_data_window)
4445         <first_data_item_displayed>: Declare new method.
4446
4447 2019-06-25  Tom Tromey  <tom@tromey.com>
4448
4449         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4450         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4451         contents...
4452         (tui_initialize_static_data): ...here.
4453
4454 2019-06-25  Tom Tromey  <tom@tromey.com>
4455
4456         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4457         (tui_display_registers_from, tui_check_register_values): Update.
4458         (tui_display_register): Remove win_info parameter; update.
4459         (tui_get_register): Change type of parameters.
4460         * tui/tui-data.h (struct tui_data_element): Remove.
4461         (union tui_which_element) <data>: Remove.
4462         <data_window>: Change type.
4463         (struct tui_data_item_window): New.
4464         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4465         case.  Add assert.
4466         (~tui_data_item_window): New destructor.
4467         (free_content_elements): Remove DATA_ITEM_WIN case.
4468
4469 2019-06-25  Tom Tromey  <tom@tromey.com>
4470
4471         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4472         Remove.
4473
4474 2019-06-25  Tom Tromey  <tom@tromey.com>
4475
4476         * tui/tui-data.h (struct tui_command_element): Remove.
4477         (union tui_which_element) <command>: Remove.
4478         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4479         assert.
4480         (free_content_elements): Remove CMD_WIN case.
4481
4482 2019-06-25  Tom Tromey  <tom@tromey.com>
4483
4484         * tui/tui-layout.c (tui_set_layout): Update.
4485         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4486         * tui/tui-data.c (layout_def): Update.
4487
4488 2019-06-25  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4491         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4492         (tui_source_window_base::set_new_height): Update.
4493         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4494         Update.
4495         (tui_set_locator_fullname, tui_set_locator_info)
4496         (tui_show_frame_info): Update.
4497         * tui/tui-source.c (tui_set_source_content)
4498         (tui_source_is_displayed): Update.
4499         * tui/tui-layout.c (show_source_disasm_command, show_data)
4500         (show_source_or_disasm_and_command): Update.
4501         * tui/tui-disasm.c (tui_set_disassem_content)
4502         (tui_get_begin_asm_address): Update.
4503         * tui/tui-data.h (struct tui_locator_element): Remove.
4504         (union tui_which_element) <locator>: Remove.
4505         (struct tui_locator_window): New.
4506         (tui_locator_win_info_ptr): Change return type.
4507         * tui/tui-data.c (_locator): Change type.
4508         (tui_locator_win_info_ptr): Change return type.
4509         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4510         (tui_alloc_content): Add assert.
4511
4512 2019-06-25  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-winsource.c
4515         (tui_exec_info_window::maybe_allocate_content): New method.
4516         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4517         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4518         (make_source_or_disasm_window): Add cast.
4519         * tui/tui-data.h (union tui_which_element) <simple_string>:
4520         Remove.
4521         (struct tui_source_info): New.
4522         (struct tui_source_window_base) <execution_info>: Change type.
4523         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4524         case, and add assert.
4525         (tui_alloc_content): Add assert.
4526
4527 2019-06-25  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4530         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4531         * tui/tui-data.c (tui_alloc_win_info): Remove.
4532
4533 2019-06-25  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4536         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4537         can_highlight.
4538
4539 2019-06-25  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4542         make_visible_with_new_height method.
4543         (tui_win_info::make_visible_with_new_height): New method.
4544         (tui_source_window_base::do_make_visible_with_new_height)
4545         (tui_data_window::do_make_visible_with_new_height)
4546         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4547         (make_visible_with_new_height): Remove.
4548         (tui_resize_all, tui_adjust_win_heights): Use
4549         make_visible_with_new_height method.
4550         * tui/tui-data.h (struct tui_win_info)
4551         <do_make_visible_with_new_height, make_visible_with_new_height>:
4552         New methods.
4553         (struct tui_source_window_base, struct tui_data_window)
4554         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4555         methods.
4556
4557 2019-06-25  Tom Tromey  <tom@tromey.com>
4558
4559         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4560         method.
4561         (update_tab_width): Call update_tab_width method.
4562         * tui/tui-data.h (struct tui_win_info)
4563         (struct tui_source_window_base) <update_tab_width>: New methods.
4564
4565 2019-06-25  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4568         parameter.
4569         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4570         parameter.
4571         (tui_gen_win_info::make_visible): Update.
4572         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4573         parameter.
4574         * tui/tui-data.h (enum tui_box): New enum.
4575         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4576
4577 2019-06-25  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4580         init_and_make_win for EXEC_INFO_WIN.
4581         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4582         longer inline.
4583         (struct tui_win_info) <~tui_win_info>: Inline.
4584         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4585         Don't declare.
4586         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4587         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4588         Remove.
4589         (tui_initialize_static_data): Update.
4590         (~tui_gen_win_info): Handle more cleanup here.
4591         (~tui_source_window_base): Delete "execution_info".
4592         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4593
4594 2019-06-25  Tom Tromey  <tom@tromey.com>
4595
4596         * tui/tui-layout.c (make_command_window): Don't set
4597         can_highlight.
4598         (show_source_disasm_command): Call the reset method.
4599         (show_data): Don't set can_highlight.  Call the reset method.
4600         (tui_gen_win_info::reset): Rename from init_gen_win_info
4601         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4602         (show_source_or_disasm_and_command): Call the reset method.
4603         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4604         (struct tui_cmd_window): Set can_highlight.
4605
4606 2019-06-25  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4609         from make_visible.
4610         (tui_make_visible, tui_make_invisible): Rewrite.
4611         (tui_win_info::make_visible): Remove.
4612         (tui_source_window_base::make_visible): Update.
4613         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4614         method.  Moved from...
4615         (struct tui_win_info) <make_visible>: ...here.
4616
4617 2019-06-25  Tom Tromey  <tom@tromey.com>
4618
4619         * tui/tui-winsource.c
4620         (tui_source_window_base::do_scroll_horizontal): Remove direction
4621         parameter.
4622         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4623         direction parameter.
4624         * tui/tui-win.c (tui_win_info::forward_scroll)
4625         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4626         (tui_win_info::right_scroll): Update.
4627         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4628         direction parameter.
4629         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4630         direction parameter.
4631         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4632         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4633         Remove direction parameter.
4634         (struct tui_source_window_base, struct tui_source_window)
4635         (struct tui_disasm_window, struct tui_data_window)
4636         (struct tui_cmd_window): Update.
4637
4638 2019-06-25  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-winsource.h (tui_set_exec_info_content)
4641         (tui_show_exec_info_content, tui_erase_exec_info_content)
4642         (tui_clear_exec_info_content, tui_update_exec_info): Change
4643         argument to tui_source_window_base.
4644         * tui/tui-winsource.c (tui_set_exec_info_content)
4645         (tui_show_exec_info_content, tui_erase_exec_info_content)
4646         (tui_clear_exec_info_content, tui_update_exec_info): Change
4647         argument to tui_source_window_base.
4648
4649 2019-06-25  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4652         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4653
4654 2019-06-25  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4657         check.
4658
4659 2019-06-25  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4662         type to void.
4663         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4664         type to void.
4665         * tui/tui-source.c (tui_set_source_content): Update.
4666         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4667
4668 2019-06-25  Tom Tromey  <tom@tromey.com>
4669
4670         * tui/tui-win.c (window_name_completer, tui_set_focus)
4671         (tui_all_windows_info): Use name method.
4672         * tui/tui-data.h (struct tui_gen_win_info)
4673         (struct tui_source_window, struct tui_disasm_window)
4674         (struct tui_data_window, struct tui_cmd_window) <name>: New
4675         method.
4676         (tui_win_name): Don't declare.
4677         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4678         (tui_win_name): Remove.
4679
4680 2019-06-25  Tom Tromey  <tom@tromey.com>
4681
4682         * tui/tui-winsource.h (tui_update_source_window)
4683         (tui_update_source_window_as_is): Change parameter type.
4684         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4685         to be a tui_source_window_base.
4686         (tui_update_source_window_as_is): Likewise.
4687         * tui/tui-win.c (make_visible_with_new_height): Update.
4688
4689 2019-06-25  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-winsource.c (tui_erase_source_content)
4692         (tui_show_source_content, tui_show_exec_info_content)
4693         (tui_erase_exec_info_content): Use refresh_window method.
4694         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4695         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4696         from tui_refresh_win.
4697         (tui_data_window::refresh_window): New method.
4698         (tui_win_info::refresh, tui_source_window_base::refresh)
4699         (tui_refresh_all): Use refresh_window method.
4700         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4701         method.
4702         * tui/tui-regs.c (tui_display_register): Call refresh_window
4703         method.
4704         * tui/tui-layout.c (show_source_disasm_command)
4705         (show_source_or_disasm_and_command): Call refresh_window method.
4706         * tui/tui-data.h (struct tui_gen_win_info)
4707         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4708         New method.
4709
4710 2019-06-25  Tom Tromey  <tom@tromey.com>
4711
4712         * tui/tui.c (tui_rl_other_window, tui_enable)
4713         (tui_is_window_visible, tui_get_command_dimension): Update.
4714         * tui/tui-winsource.c (tui_update_source_window_as_is)
4715         (tui_clear_source_content, tui_erase_source_content)
4716         (tui_show_source_line, tui_source_window_base::refill)
4717         (tui_source_window_base::do_scroll_horizontal)
4718         (tui_source_window_base::set_is_exec_point_at)
4719         (tui_update_breakpoint_info, tui_set_exec_info_content)
4720         (tui_alloc_source_buffer, tui_line_is_displayed)
4721         (tui_addr_is_displayed): Update.
4722         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4723         (tui_check_and_display_highlight_if_needed)
4724         (tui_win_info::make_visible, tui_win_info::refresh)
4725         (tui_refresh_all): Update.
4726         * tui/tui-windata.c (tui_first_data_item_displayed)
4727         (tui_delete_data_content_windows, tui_erase_data_content)
4728         (tui_display_all_data, tui_data_window::refresh_all)
4729         (tui_check_data_values): Update.
4730         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4731         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4732         (tui_win_info::backward_scroll, tui_refresh_all_win)
4733         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4734         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4735         (tui_source_window_base::set_new_height)
4736         (tui_data_window::set_new_height)
4737         (make_invisible_and_set_new_height)
4738         (make_visible_with_new_height, new_height_ok)
4739         (parse_scrolling_args): Update.
4740         * tui/tui-stack.c (tui_show_frame_info): Update.
4741         * tui/tui-source.c (tui_set_source_content)
4742         (tui_set_source_content_nil, tui_source_is_displayed)
4743         (tui_source_window::do_scroll_vertical): Update.
4744         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4745         (tui_display_registers_from, tui_display_reg_element_at_line)
4746         (tui_check_register_values, tui_reg_command): Update.
4747         * tui/tui-layout.c (tui_default_win_height)
4748         (show_source_disasm_command, show_data, init_and_make_win)
4749         (show_source_or_disasm_and_command): Update.
4750         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4751         (tui_redisplay_readline, tui_mld_flush)
4752         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4753         (tui_getc): Update.
4754         * tui/tui-disasm.c (tui_set_disassem_content)
4755         (tui_disasm_window::do_scroll_vertical): Update.
4756         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4757         Now virtual.
4758         (struct tui_win_info): Derive from tui_gen_win_info.
4759         <~tui_win_info>: Mark as override.
4760         <generic>: Remove member.
4761         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4762         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4763         (~tui_data_window, ~tui_win_info)
4764         (tui_free_all_source_wins_content): Update.
4765         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4766
4767 2019-06-25  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-layout.c (init_and_make_win): Use new.
4770         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4771         destructor, initializers.
4772         (tui_alloc_generic_win_info): Don't declare.
4773         * tui/tui-data.c (_locator): Add argument to constructor.
4774         (source_win, disasm_win): New globals.
4775         (exec_info): Remove.
4776         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4777         Update.
4778         (tui_alloc_generic_win_info): Remove.
4779         (init_content_element): Use new.
4780         (tui_win_info::tui_win_info): Update.
4781         (free_content_elements) <case DATA_WIN>: Use delete.
4782
4783 2019-06-25  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4786         * tui/tui-windata.c (tui_first_data_item_displayed)
4787         (tui_delete_data_content_windows): Update.
4788         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4789         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4790         (tui_display_registers_from, tui_check_register_values): Update.
4791         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4792         pointer.
4793         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4794         window.
4795         (tui_free_data_content): Update.
4796         (free_content_elements) <case DATA_WIN>: Free the window.
4797
4798 2019-06-25  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4801         Update.
4802         * tui/tui-layout.c (make_command_window)
4803         (show_source_disasm_command, show_data, init_and_make_win)
4804         (show_source_or_disasm_and_command): Update.
4805         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4806         method.
4807         <can_highight, is_highlighted>: Now bool.
4808         (tui_set_win_highlight): Don't declare.
4809         * tui/tui-data.c (tui_set_win_highlight): Remove.
4810
4811 2019-06-25  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-wingeneral.c (make_visible): Remove check of window
4814         type.
4815
4816 2019-06-25  Tom Tromey  <tom@tromey.com>
4817
4818         * tui/tui-win.c (tui_win_info::max_height)
4819         (tui_cmd_window::max_height): New methods.
4820         (new_height_ok): Call max_height.
4821         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4822         <max_height>: New method.
4823
4824 2019-06-25  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-win.c (tui_source_window_base::set_new_height)
4827         (tui_data_window::set_new_height): New methods.
4828         (make_invisible_and_set_new_height): Call set_new_height method.
4829         * tui/tui-data.h (struct tui_win_info)
4830         (struct tui_source_window_base, struct tui_data_window)
4831         <set_new_height>: New method.
4832
4833 2019-06-25  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4836         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4837         tui_refresh_data_win.
4838         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4839         method.
4840         (tui_refresh_all_win): Call the refresh_all method.
4841         (tui_set_focus): Likewise.
4842         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4843         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4844         Likewise.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-winsource.h (tui_refill_source_window)
4849         (tui_set_is_exec_point_at): Don't declare.
4850         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4851         (tui_source_window_base::refill): Rename from
4852         tui_refill_source_window.
4853         (tui_source_window_base::do_scroll_horizontal): Update.
4854         (tui_source_window_base::set_is_exec_point_at): Rename from
4855         tui_set_is_exec_point_at.
4856         (tui_update_all_breakpoint_info): Update.
4857         * tui/tui-stack.c (tui_show_frame_info): Update.
4858         * tui/tui-layout.c (show_data): Add cast.
4859         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4860         * tui/tui-data.h (struct tui_source_window_base) <refill,
4861         set_is_exec_point_at>: New methods.
4862         (tui_source_windows, tui_add_to_source_windows): Update types.
4863         (tui_add_to_source_windows): Remove redundant declaration.
4864         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4865         (tui_source_windows): Change return type.
4866         (tui_clear_source_windows_detail): Update.
4867         (tui_add_to_source_windows): Change type of parameter.
4868         (tui_free_all_source_wins_content): Update.
4869
4870 2019-06-25  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-wingeneral.c (tui_win_info::refresh)
4873         (tui_source_window_base::refresh): New methods.
4874         (tui_refresh_all): Call the refresh method.
4875         * tui/tui-data.h (struct tui_win_info)
4876         (struct tui_source_window_base) <refresh>: New method.
4877
4878 2019-06-25  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui.h (tui_is_window_visible): Return bool.
4881         * tui/tui.c (tui_is_window_visible): Return bool.
4882         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4883         (tui_make_visible, tui_make_invisible)
4884         (tui_win_info::make_visible)
4885         (tui_source_window_base::make_visible, make_all_visible)
4886         (tui_make_all_visible, tui_make_all_invisible): Update.
4887         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4888         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4889         bool.
4890         (struct tui_win_info, struct tui_source_window_base)
4891         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4892         * tui/tui-data.c (tui_init_generic_part): Update.
4893
4894 2019-06-25  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4897         (tui_source_window_base::make_visible): New methods.
4898         (make_all_visible): Make method call.
4899         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4900         (struct tui_source_window_base, struct tui_cmd_window): Override
4901         make_visible.
4902         (tui_win_is_source_type): Don't declare.
4903         * tui/tui-data.c (tui_win_is_source_type): Remove.
4904
4905 2019-06-25  Tom Tromey  <tom@tromey.com>
4906
4907         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4908         NULL check.
4909
4910 2019-06-25  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4913         Inline constructor.  Add initializers for members.
4914         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4915         constructors; now inline in class.
4916
4917 2019-06-25  Tom Tromey  <tom@tromey.com>
4918
4919         * tui/tui-regs.c (tui_show_registers): Update.
4920         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4921         bool.
4922         * tui/tui-data.c (tui_data_window::clear_detail)
4923         (tui_data_window): Update.
4924
4925 2019-06-25  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-windata.c (tui_display_all_data)
4928         (tui_display_data_from_line, tui_display_data_from)
4929         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4930         Update.
4931         * tui/tui-regs.c (tui_last_regs_line_no)
4932         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4933         (tui_show_registers, tui_show_register_group)
4934         (tui_display_registers_from, tui_display_reg_element_at_line)
4935         (tui_display_registers_from_line, tui_check_register_values)
4936         (tui_reg_next, tui_reg_prev): Update.
4937         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4938         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4939         tui_data_window.
4940         (struct tui_win_info) <detail>: Remove.  Add new fields from
4941         tui_data_info.
4942         (TUI_DATA_WIN): Add cast.
4943         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4944         (~tui_data_window): Simplify.
4945
4946 2019-06-25  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-layout.c (show_source_disasm_command)
4949         (show_source_or_disasm_and_command): Update.
4950         * tui/tui-io.c (update_cmdwin_start_line)
4951         (tui_redisplay_readline): Update.
4952         * tui/tui-data.h (struct tui_command_info): Remove.
4953         (struct tui_win_info) <detail>: Remove command_info member.
4954         (struct tui_data_window) <start_line>: New member, from
4955         tui_command_info.
4956         (TUI_CMD_WIN): Add casts.
4957
4958 2019-06-25  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-winsource.c (tui_update_source_window)
4961         (tui_refill_source_window)
4962         (tui_source_window_base::do_scroll_horizontal)
4963         (tui_update_breakpoint_info, tui_set_exec_info_content)
4964         (tui_show_exec_info_content, tui_erase_exec_info_content)
4965         (tui_clear_exec_info_content): Update.
4966         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4967         Update.
4968         * tui/tui-win.c (make_invisible_and_set_new_height)
4969         (make_visible_with_new_height): Update.
4970         * tui/tui-source.c (tui_set_source_content)
4971         (tui_show_symtab_source): Update.
4972         * tui/tui-layout.c (extract_display_start_addr)
4973         (show_source_disasm_command, show_data)
4974         (make_source_or_disasm_window)
4975         (show_source_or_disasm_and_command): Update.
4976         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4977         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4978         "gdbarch".
4979         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4980         to tui_source_window_base.
4981         (struct tui_win_info) <detail>: Remove source_info member.
4982         (struct tui_source_window_base) <has_locator>: Inline.
4983         Move contents from tui_source_info; rename has_locator member to
4984         m_has_locator.
4985         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4986         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4987         header file.
4988         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4989         Simplify.
4990         (tui_free_all_source_wins_content): Cast to
4991         tui_source_window_base.
4992
4993 2019-06-25  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-win.c (make_invisible_and_set_new_height)
4996         (make_visible_with_new_height): Call has_locator method.
4997         * tui/tui-layout.c (show_source_disasm_command, show_data)
4998         (show_source_or_disasm_and_command): Update for bool change.
4999         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5000         (tui_win_info) <has_locator>: New method.
5001         (struct tui_source_window_base) <has_locator>: New method.
5002         (tui_win_has_locator): Don't declare.
5003         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5004         from tui_win_has_locator.
5005         (tui_source_window_base): Use false, not FALSE.
5006
5007 2019-06-25  Tom Tromey  <tom@tromey.com>
5008
5009         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5010         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5011         clear_detail method directly.
5012         (tui_clear_win_detail): Remove.
5013
5014 2019-06-25  Tom Tromey  <tom@tromey.com>
5015
5016         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5017         "this", not TUI_DISASM_WIN.
5018
5019 2019-06-25  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5022         declare.
5023         * tui/tui-winsource.c
5024         (tui_source_window_base::do_scroll_horizontal): Rename from
5025         tui_horizontal_source_scroll.
5026         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5027         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5028         from tui_vertical_data_scroll.
5029         * tui/tui-win.h (tui_scroll): Don't declare.
5030         * tui/tui-win.c (tui_win_info::forward_scroll)
5031         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5032         (tui_win_info::right_scroll): Rename and update.
5033         (tui_scroll_forward_command, tui_scroll_backward_command)
5034         (tui_scroll_left_command, tui_scroll_right_command): Update.
5035         (tui_scroll): Remove.
5036         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5037         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5038         from tui_vertical_source_scroll.
5039         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5040         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5041         from tui_vertical_disassem_scroll.
5042         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5043         do_scroll_horizontal>: New methods.
5044         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5045         Likewise.
5046         (struct tui_source_window_base): Add do_scroll_horizontal.
5047         (struct tui_source_window, struct tui_disasm_window): Add
5048         do_scroll_vertical.
5049         (struct tui_data_window, struct tui_cmd_window): Add
5050         do_scroll_horizontal and do_scroll_vertical.
5051         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5052
5053 2019-06-25  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-data.h (struct tui_source_window_base): New struct.
5056         (struct tui_source_window): Derive from tui_source_window_base.
5057         (struct tui_disasm_window): New struct.
5058         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5059         from tui_source_window::clear_detail.
5060         (tui_source_window_base): Rename from tui_source_window.
5061         (~tui_source_window_base): Rename from ~tui_source_window.
5062         (tui_alloc_win_info): Create a tui_disasm_window.
5063
5064 2019-06-25  Tom Tromey  <tom@tromey.com>
5065
5066         * tui/tui-data.h (struct tui_source_window)
5067         (struct tui_data_window): Declare destructors.
5068         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5069         destructors.
5070         (tui_win_info): Simplify.
5071
5072 2019-06-25  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-winsource.c (tui_display_main)
5075         (tui_update_source_windows_with_addr)
5076         (tui_update_all_breakpoint_info): Update.
5077         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5078         (new_height_ok, parse_scrolling_args): Update.
5079         * tui/tui-stack.c (tui_show_frame_info): Update.
5080         * tui/tui-data.h (struct tui_list): Remove.
5081         (tui_source_windows): Return a reference to a std::vector.
5082         * tui/tui-data.c (source_windows): Now a std::vector.
5083         (tui_source_windows): Change return type.
5084         (tui_clear_source_windows): Rewrite.
5085         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5086         (tui_free_all_source_wins_content): Rewrite.
5087
5088 2019-06-25  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5091         (struct tui_data_window, struct tui_cmd_window): Declare
5092         clear_detail method.
5093         * tui/tui-data.c (tui_source_window::clear_detail)
5094         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5095         methods.
5096         (tui_clear_win_detail): Simplify.
5097
5098 2019-06-25  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui-layout.c (make_source_window, make_disasm_window)
5101         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5102         Return the new window.
5103         (show_source_disasm_command, show_data)
5104         (show_source_or_disasm_and_command): Update.
5105
5106 2019-06-25  Tom Tromey  <tom@tromey.com>
5107
5108         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5109         parameter.  Return the new window.
5110         (show_source_disasm_command): Update and remove NULL check.
5111         (show_source_or_disasm_and_command): Update.
5112
5113 2019-06-25  Tom Tromey  <tom@tromey.com>
5114
5115         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5116
5117 2019-06-25  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-data.h (struct tui_win_info): Make constructor
5120         protected.  Make destructor virtual.  Add initializers.
5121         (tui_source_window, tui_data_window, tui_cmd_window): New
5122         classes.
5123         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5124         constructor.  Add "type" parameter.
5125         (tui_source_window, tui_data_window, tui_cmd_window): New
5126         constructors.
5127         (tui_alloc_win_info): Instantiate the appropriate subclass.
5128
5129 2019-06-25  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-win.c (tui_resize_all): Use delete.
5132         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5133         destructor.
5134         (tui_free_window): Don't declare.
5135         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5136         Update.
5137
5138 2019-06-25  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-data.h (struct tui_win_info): Add constructor.
5141         * tui/tui-data.c (tui_alloc_win_info): Use new.
5142         (tui_free_window): Use delete.
5143
5144 2019-06-22  Tom Tromey  <tom@tromey.com>
5145
5146         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5147         declare.
5148         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5149
5150 2019-06-22  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5153         declare.
5154         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5155
5156 2019-06-22  Tom de Vries  <tdevries@suse.de>
5157
5158         * dwarf2read.c (create_addrmap_from_aranges)
5159         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5160         instead of '%zu'.
5161
5162 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5163
5164         * dwarf2read.h (dwarf2_section_info_def): Remove.
5165         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5166         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5167         std::vector<dwarf2_section_info>.
5168         (struct dwo_file) <~dwo_file>: Remove.
5169         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5170         types field.
5171         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5172         (dwarf2_read_debug_names): Likewise.
5173         (create_debug_types_hash_table): Change parameter type to
5174         array_view, adjust code accordingly.
5175         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5176         (partial_die_info::fixup): Likewise.
5177         (determine_prefix): Likewise.
5178         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5179
5180 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5181
5182         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5183         gdb_bfd_ref_ptr.
5184         <~dwo_file>: Remove call to gdb_bfd_unref.
5185         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5186         gdb_bfd_ref_ptr::get.
5187
5188 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5189
5190         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5191         type to htab_up.
5192         * dwarf2read.c (struct dwo_file): Initialize fields.
5193         <~dwo_file>: New.
5194         (free_dwo_file): Remove, move content to ~dwo_file.
5195         (struct dwo_file_deleter): Remove.
5196         (dwo_file_up>: Remove custom deleter.
5197         (free_dwo_files): Remove.
5198         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5199         dwo_files.
5200         (process_skeletonless_type_units): Call unique_ptr::get.
5201         (allocate_dwo_file_hash_table): Add deleter to created hash
5202         table.  Change return type to htab_up.
5203         (lookup_dwo_file_slot): Don't memset dwo_file, call
5204         unique_ptr::get.
5205         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5206         (create_dwo_unit_in_dwp_v2): Likewise.
5207         (open_and_init_dwo_file): Likewise.
5208         (free_dwo_file_from_slot): Remove.
5209
5210 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5211
5212         * dwarf2read.h (struct dwarf2_section_info) <readin,
5213         is_virtual>: Change type to bool.
5214         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5215         true instead of 1.
5216
5217 2019-06-19  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-data.h (tui_init_content_element): Don't declare.
5220
5221 2019-06-19  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-data.h (tui_init_win_info): Don't declare.
5224
5225 2019-06-19  Tom de Vries  <tdevries@suse.de>
5226
5227         * dwarf2read.h (abstract_to_concrete): Change type to
5228         std::unordered_map<sect_offset, std::vector<sect_offset>,
5229         gdb::hash_enum<sect_offset>>.
5230
5231 2019-06-19  Tom Tromey  <tromey@adacore.com>
5232
5233         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5234         EVAL_AVOID_SIDE_EFFECTS specially.
5235
5236 2019-06-19  Tom Tromey  <tromey@adacore.com>
5237
5238         * source-cache.c (highlighter): New global.
5239         (source_cache::get_source_lines): Create a highlighter on demand.
5240
5241 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5242
5243         * defs.h (deprecated_interactive_hook): Delete declaration.
5244         * interps.c (clear_interpreter_hooks): Remove use of
5245         deprecated_interactive_hook.
5246         * top.c (deprecated_interactive_hook): Delete definition.
5247         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5248
5249 2019-06-18  Tom de Vries  <tdevries@suse.de>
5250
5251         PR gdb/24515
5252         * dwarf2read.h (abstract_to_concrete): Change type from
5253         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5254         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5255         * dwarf2read.c (read_variable): Update.
5256         (dwarf2_fetch_die_loc_sect_off): Update.
5257
5258 2019-06-17  Tom de Vries  <tdevries@suse.de>
5259
5260         PR gdb/24617
5261         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5262         accessing parent[parent_len - 1].
5263
5264 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5265
5266         PR gdb/24364
5267         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5268         call dtrace_process_dof with NULL dof.
5269
5270 2019-06-16  Tom de Vries  <tdevries@suse.de>
5271
5272         PR gdb/24445
5273         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5274
5275 2019-06-16  Tom Tromey  <tom@tromey.com>
5276
5277         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5278         (make_all_visible): Use address of member.
5279
5280 2019-06-16  Tom Tromey  <tom@tromey.com>
5281
5282         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5283         (tui_free_window, free_content, free_content_elements): Remove
5284         unnecessary cast.
5285         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5286         cast.
5287         * tui/tui-regs.c (tui_show_register_group)
5288         (tui_display_registers_from, tui_display_reg_element_at_line):
5289         Remove unnecessary cast.
5290
5291 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * linux-nat.c (normal_mask): Delete.
5294         (_initialize_linux_nat): Don't initialise normal_mask.
5295
5296 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5297
5298         PR gdb/24445
5299         * dwarf-index-write.h (write_psymtabs_to_index): Add
5300         dwz_basename parameter.
5301         * dwarf-index-write.c (write_gdbindex): Move file writing to
5302         write_gdbindex_1.  Change return type void.
5303         (assert_file_size): Move up, remove filename parameter.
5304         (write_gdbindex_1): New function.
5305         (write_debug_names): Change return type to void, call
5306         assert_file_size.
5307         (struct index_wip_file): New struct.
5308         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5309         file logic to index_wip_file.  Write index for dwz file if
5310         needed.
5311         (save_gdb_index_command): Pass basename of dwz file, if present.
5312         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5313         build-id of dwz file, if present.
5314         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5315         (dwarf2_get_dwz_file): Likewise.
5316         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5317         (dwarf2_get_dwz_file): Likewise.
5318
5319 2019-06-16  Tom Tromey  <tom@tromey.com>
5320
5321         * coffread.c (process_coff_symbol): Use xstrdup.
5322         * value.c (create_internalvar): Use xstrdup.
5323
5324 2019-06-16  Tom Tromey  <tom@tromey.com>
5325
5326         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5327         * breakpoint.c (stopin_command, stopat_command)
5328         (until_break_command, decode_location_default): Remove unnecessary
5329         cast.
5330         * utils.c (subset_compare): Remove unnecessary cast.
5331         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5332         cast.
5333         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5334         cast.
5335         * infcmd.c (path_command): Remove unnecessary cast.
5336         * coffread.c (decode_type): Remove unnecessary cast.
5337         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5338         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5339         * tui/tui-stack.c (tui_show_locator_content)
5340         (tui_show_frame_info): Remove unnecessary cast.
5341         * tui/tui-win.c (tui_scroll_forward_command)
5342         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5343         (parse_scrolling_args): Remove unnecessary cast.
5344         * tui/tui-data.c (init_win_info, tui_del_window)
5345         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5346         (free_content_elements): Remove unnecessary cast.
5347         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5348         unnecessary cast.
5349         * tui/tui-source.c (tui_set_source_content)
5350         (tui_vertical_source_scroll): Remove unnecessary cast.
5351         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5352         cast.
5353         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5354         * tui/tui-regs.c (tui_display_registers_from)
5355         (tui_display_register): Remove unnecessary cast.
5356         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5357         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5358         (make_visible): Remove unnecessary cast.
5359         * tui/tui-winsource.c (tui_erase_source_content)
5360         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5361         unnecessary cast.
5362         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5363         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5364         * stabsread.c (read_type, read_array_type, read_range_type):
5365         Remove unnecessary cast.
5366         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5367         (parse_symbol, parse_type, upgrade_type, parse_external)
5368         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5369         unnecessary cast.
5370         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5371
5372 2019-06-16  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-data.c (tui_alloc_generic_win_info)
5375         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5376         checks.
5377
5378 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5379             Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * f-typeprint.c (f_print_type): Don't return early for not
5382         associated or not allocated types.
5383         (f_type_print_varspec_suffix): Add print_rank parameter and print
5384         ranks of array types in case they dangling.
5385         (f_type_print_base): Add print_rank parameter.
5386
5387 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5388
5389         * NEWS: Mention new MI commands.
5390         * break-catch-throw.c (enum exception_event_kind): Move to
5391         breakpoint.h.
5392         (print_mention_exception_catchpoint): Output text as a single
5393         message.
5394         (catch_exception_command_1): Rename to...
5395         (catch_exception_event): ...this, make non-static, update header
5396         command, and change some parameter types.
5397         (catch_catch_command): Update for changes to
5398         catch_exception_command_1.
5399         (catch_throw_command): Likewise.
5400         (catch_rethrow_command): Likewise.
5401         * breakpoint.c (enum exception_event_kind): Delete.
5402         * breakpoint.h (enum exception_event_kind): Moved here from
5403         break-catch-throw.c.
5404         (catch_exception_event): Declare.
5405         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5406         (mi_cmd_catch_throw): New function.
5407         (mi_cmd_catch_rethrow): New function.
5408         (mi_cmd_catch_catch): New function.
5409         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5410         'catch-catch' entries.
5411         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5412         (mi_cmd_catch_rethrow): Declare.
5413         (mi_cmd_catch_catch): Declare.
5414
5415 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5416
5417         * annotate.c (annotate_source_line): Change return type to void,
5418         update implementation to match.
5419         * annotate.h (annotate_source_line): Change return type to void,
5420         update header comment.
5421         * stack.c (print_frame_info): Don't change what frame information
5422         is printed based on whether annotations are on or not.
5423
5424 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5425
5426         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5427         (annotate_source): Make static.
5428         (annotate_source_line): Moved from source.c and renamed from
5429         identify_source_line.  Update the return type.
5430         * annotate.h (annotate_source): Delete declaration.
5431         (annotate_source_line): Declaration moved from source.h, and
5432         renamed from identify_source_line.  Return type updated.
5433         * source.c (identify_source_line): Moved to annotate.c and renamed
5434         to annotate_source_line.
5435         (info_line_command): Remove check of annotation_level.
5436         * source.h (identify_source_line): Move declaration to annotate.h
5437         and rename to annotate_source_line.
5438         * stack.c: Add 'annotate.h' include.
5439         (print_frame_info): Remove check of annotation_level before
5440         calling annotate_source_line.
5441
5442 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * source-cache.c (source_cache::get_plain_source_lines): Use
5445         open_source_file_with_line_charpos instead of just
5446         open_source_file, remove call to find_source_lines.
5447         (source_cache::get_source_lines): Likewise.
5448         * source.c (find_source_lines): Make static.
5449         (get_filename_and_charpos): Renamed into...
5450         (open_source_file_with_line_charpos): ..this along with changes to
5451         return a scoped_fd, and some other minor clean ups.
5452         (identify_source_line): Use open_source_file_with_line_charpos.
5453         (search_command_helper): Use open_source_file_with_line_charpos
5454         instead of just open_source_file, remove call to
5455         find_source_lines.
5456         * source.h (open_source_file_with_line_charpos): Declare new
5457         function.
5458         (find_source_lines): Delete declaration.
5459
5460 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * source.c (get_filename_and_charpos): Remove fullname
5463         parameter.
5464         (identify_source_line): Update call to get_filename_and_charpos.
5465
5466 2019-06-14  Tom Tromey  <tromey@adacore.com>
5467
5468         PR gdb/24502:
5469         * ui-style.h (skip_ansi_escape): Update comment.
5470         * ui-file.h (class no_terminal_escape_file): New class.
5471         * ui-file.c (no_terminal_escape_file::write)
5472         (no_terminal_escape_file::puts): New methods.
5473         * cli/cli-logging.c (handle_redirections): Use
5474         no_terminal_escape_file.
5475
5476 2019-06-14  Tom Tromey  <tromey@adacore.com>
5477
5478         * NEWS: Move convenience variable news above Python news.
5479
5480 2019-06-14  Tom Tromey  <tom@tromey.com>
5481
5482         * gnulib: Move directory to top-level.
5483         * configure.ac: Don't configure gnulib.
5484         * configure: Rebuild.
5485         * common/common-defs.h: Use new path to gnulib.
5486         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5487         (GNULIB_H): Remove.
5488         (INCGNU): Look in new gnulib location.
5489         (HFILES_NO_SRCDIR): Remove gnulib files.
5490         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5491         (generated_files): Remove GNULIB_H.
5492         ($(LIBGNU), all-lib): Remove targets.
5493         (distclean): Don't mention GNULIB_BUILDDIR.
5494         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5495
5496 2019-06-14  Tom Tromey  <tromey@adacore.com>
5497
5498         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5499         Warn if symbol file does not provide any symbols.
5500
5501 2019-06-14  Tom Tromey  <tromey@adacore.com>
5502
5503         * source.c (find_and_open_source): Respect basenames_may_differ.
5504
5505 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * annotate.c (annotate_breakpoints_invalid): Make use of
5508         scoped_restore_terminal_state.
5509         (annotate_frames_invalid): Likewise.
5510
5511 2019-06-14  Tom Tromey  <tromey@adacore.com>
5512
5513         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5514         allow assignment to an internalvar.
5515
5516 2019-06-14  Tom Tromey  <tromey@adacore.com>
5517
5518         * ada-lex.l: Allow "_" in attribute names.
5519
5520 2019-06-14  Tom Tromey  <tromey@adacore.com>
5521
5522         PR gdb/24653:
5523         * regcache.c (registers_changed): Don't call alloca.
5524         * top.c (execute_command): Don't call alloca.
5525
5526 2019-06-13  Pedro Alves  <palves@redhat.com>
5527
5528         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5529         'expression'.  When parsing an expression, error out if there's
5530         junk after "unlimited".
5531         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5532         (do_set_command): Adjust calls to is_unlimited_literal.
5533
5534 2019-06-13  Pedro Alves  <palves@redhat.com>
5535
5536         * compile/compile.c (make_compile_options_def_group): Add braces
5537         around array_view initializer.
5538         * thread.c (make_thread_apply_all_options_def_group)
5539         (make_thread_apply_all_options_def_group): Likewise.
5540
5541 2019-06-13  Pedro Alves  <palves@redhat.com>
5542
5543         * NEWS (New commands): Mention "maint test-options
5544         require-delimiter", "maint test-options unknown-is-error", "maint
5545         test-options unknown-is-operand" and "maint show
5546         test-options-completion-result".
5547         (New command options, command completion): New section.
5548         (Completion improvements): New section.
5549         Mention that you can abbreviate "unlimited".
5550
5551 2019-06-13  Pedro Alves  <palves@redhat.com>
5552
5553         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5554         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5555         * unittests/cli-utils-selftests.c (test_parse_flags)
5556         (test_parse_flags_qcs): Delete.
5557         (test_cli_utils): Don't call deleted functions.
5558
5559 2019-06-13  Pedro Alves  <palves@redhat.com>
5560
5561         * thread.c: Include "cli/cli-option.h".
5562         (tp_array_compar_ascending): Global.
5563         (tp_array_compar): Delete function.
5564         (tp_array_compar_ascending, tp_array_compar_descending): New
5565         functions.
5566         (ascending_option_def, qcs_flag_option_def)
5567         (thr_qcs_flags_option_defs)
5568         (make_thread_apply_all_options_def_group)
5569         (make_thread_apply_options_def_group): New.
5570         (thread_apply_all_command): Use gdb::option::process_options.
5571         (thread_apply_command_completer)
5572         (thread_apply_all_command_completer): New.
5573         (thread_apply_command): Use gdb::option::process_options.
5574         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5575         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5576         to generate help text of "thread apply".  Adjust "taas"'s help.
5577         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5578         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5579
5580 2019-06-13  Pedro Alves  <palves@redhat.com>
5581
5582         * thread.c (thread_apply_command): Check for invalid TID with
5583         isdigit instead of !isalpha.
5584
5585 2019-06-13  Pedro Alves  <palves@redhat.com>
5586
5587         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5588         (validate_flags_qcs): New.
5589         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5590         (validate_flags_qcs): Declare.
5591         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5592         (make_frame_apply_options_def_group): New.
5593         (frame_apply_command_count): Process options with
5594         gdb::option::process_options.
5595         (frame_apply_completer): New.
5596         (frame_apply_level_completer, frame_apply_all_completer)
5597         (frame_apply_completer): New.
5598         (_initialize_stack): Update help of "frame apply", "frame apply
5599         level", "frame apply all" and "faas" to mention supported options
5600         and install command completers.
5601         * stack.h (frame_apply_all_completer): Declare.
5602         * thread.c: Include "stack.h".
5603         (tfaas_command): Add "--".
5604         (_initialize_thread): Update help "tfaas" to mention supported
5605         options and install command completer.
5606
5607 2019-06-13  Pedro Alves  <palves@redhat.com>
5608
5609         * completer.c (complete_nested_command_line): New.
5610         (gdb_completion_word_break_characters_throw): Add assertion.
5611         * completer.h (complete_nested_command_line): Declare.
5612
5613 2019-06-13  Pedro Alves  <palves@redhat.com>
5614
5615         * stack.c (parse_backtrace_qualifiers): New.
5616         (backtrace_command): Use it.
5617         (backtrace_command_completer): Complete on qualifiers.
5618
5619 2019-06-13  Pedro Alves  <palves@redhat.com>
5620
5621         * frame.c: Include "cli/cli-option.h.
5622         (user_set_backtrace_options): New.
5623         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5624         Delete.
5625         (get_prev_frame): Adjust.
5626         (boolean_option_def, uinteger_option_def)
5627         (set_backtrace_option_defs): New.
5628         (_initialize_frame): Adjust and use
5629         gdb::option::add_setshow_cmds_for_options to install "set
5630         backtrace past-main" and "set backtrace past-entry".
5631         * frame.h: Include "cli/cli-option.h".
5632         (struct frame_print_options): Forward declare.
5633         (print_frame_arguments_all, print_frame_arguments_scalars)
5634         (print_frame_arguments_none): Declare.
5635         (print_entry_values): Delete declaration.
5636         (struct frame_print_options, user_frame_print_options): New.
5637         (struct set_backtrace_options): New.
5638         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5639         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5640         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5641         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5642         (list_args_or_locals): Add frame_print_options parameter.
5643         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5644         * python/py-framefilter.c (enumerate_args): Pass down
5645         USER_FRAME_PRINT_OPTIONS.
5646         * stack.c: Include "cli/cli-option.h".
5647         (print_frame_arguments_all, print_frame_arguments_scalars)
5648         (print_frame_arguments_none): Declare.
5649         (print_raw_frame_arguments, print_entry_values): Delete.
5650         (user_frame_print_options): New.
5651         (boolean_option_def, enum_option_def, frame_print_option_defs):
5652         New.
5653         (struct backtrace_cmd_options): New.
5654         (bt_flag_option_def): New.
5655         (backtrace_command_option_defs): New.
5656         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5657         (print_frame_arg, read_frame_arg, print_frame_args)
5658         (print_frame_info, print_frame): Add frame_print_options parameter
5659         and use it.
5660         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5661         (backtrace_command_1): Add frame_print_options and
5662         backtrace_cmd_options parameters and use them.
5663         (make_backtrace_options_def_group): New.
5664         (backtrace_command): Process command options with
5665         gdb::option::process_options.
5666         (backtrace_command_completer): New.
5667         (_initialize_stack): Extend "backtrace"'s help to mention
5668         supported options.  Install completer for "backtrace".
5669         Install some settings commands with add_setshow_cmds_for_options.
5670
5671 2019-06-13  Pedro Alves  <palves@redhat.com>
5672
5673         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5674         and that "set/show print raw frame-arguments" are now deprecated.
5675
5676         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5677         command.
5678         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5679         * stack.c (_initialize_stack): Install "set/show print
5680         raw-frame-arguments", and deprecate "set/show print raw
5681         frame-arguments".
5682         * valprint.c (_initialize_valprint): Deprecate "set/show print
5683         raw".
5684
5685 2019-06-13  Pedro Alves  <palves@redhat.com>
5686
5687         * compile/compile.c (struct compile_options): New.
5688         (compile_flag_option_def, compile_command_option_defs)
5689         (make_compile_options_def_group): New.
5690         (compile_file_command): Handle options with
5691         gdb::option::process_options.
5692         (compile_file_command_completer): New function.
5693         (compile_code_command): Handle options with
5694         gdb::option::process_options.
5695         (compile_code_command_completer): New function.
5696         (_initialize_compiler): Install completers for "compile code" and
5697         "compile file".  Mention available options in "compile code" and
5698         "compile code"'s help.
5699         * completer.c (advance_to_completion_word): New, factored out from
5700         ...
5701         (advance_to_expression_complete_word_point): ... this.
5702         (advance_to_filename_complete_word_point): New.
5703         * completer.h (advance_to_filename_complete_word_point): New
5704         declaration.
5705
5706 2019-06-13  Pedro Alves  <palves@redhat.com>
5707
5708         * compile/compile.c: Include "cli/cli-option.h".
5709         (compile_print_value): Scope data pointer is now a
5710         value_print_options pointer; adjust.
5711         (compile_print_command): Process options.  Scope data pointer is
5712         now a value_print_options pointer; adjust.
5713         (_initialize_compile): Update "compile print"'s help to include
5714         supported options.  Install a completer for "compile print".
5715         * cp-valprint.c (show_vtblprint, show_objectprint)
5716         (show_static_field_print): Delete.
5717         (_initialize_cp_valprint): Don't install "set print
5718         static-members", "set print vtbl", "set print object" here.
5719         * printcmd.c: Include "cli/cli-option.h" and
5720         "common/gdb_optional.h".
5721         (print_command_parse_format): Rework to fill in a
5722         value_print_options instead of a format_data.
5723         (print_value): Change parameter type from format_data pointer to
5724         value_print_options reference.  Adjust.
5725         (print_command_1): Process options.  Adjust to pass down a
5726         value_print_options.
5727         (print_command_completer): New.
5728         (_initialize_printcmd): Install print_command_completer as
5729         handle_brkchars completer for the "print" command.  Update
5730         "print"'s help to include supported options.
5731         * valprint.c: Include "cli/cli-option.h".
5732         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5733         here from cp-valprint.c.
5734         (boolean_option_def, uinteger_option_def)
5735         (value_print_option_defs, make_value_print_options_def_group):
5736         New.  Use gdb::option::add_setshow_cmds_for_options to install
5737         "set print elements", "set print null-stop", "set print repeats",
5738         "set print pretty", "set print union", "set print array", "set
5739         print address", "set print symbol", "set print array-indexes".
5740         * valprint.h: Include <string> and "cli/cli-option.h".
5741         (make_value_print_options_def_group): Declare.
5742         (print_value): Change parameter type from format_data pointer to
5743         value_print_options reference.
5744         (print_command_completer): Declare.
5745
5746 2019-06-13  Pedro Alves  <palves@redhat.com>
5747
5748         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5749         (COMMON_SFILES): Add maint-test-settings.c.
5750         * cli/cli-decode.c (boolean_enums): New global, factored out from
5751         ...
5752         (add_setshow_boolean_cmd): ... here.
5753         * cli/cli-decode.h (boolean_enums): Declare.
5754         * cli/cli-option.c: New file.
5755         * cli/cli-option.h: New file.
5756         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5757         factored out from ...
5758         (parse_cli_boolean_value(const char *)): ... this.
5759         (is_unlimited_literal): Change parameter type to pointer to
5760         pointer.  Adjust and advance ARG pointer.
5761         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5762         (parse_cli_var_enum): New, factored out from ...
5763         (do_set_command): ... this.  Adjust.
5764         * cli/cli-setshow.h (parse_cli_boolean_value)
5765         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5766         (parse_cli_var_enum): Declare.
5767         * cli/cli-utils.c: Include "cli/cli-option.h".
5768         (get_ulongest): New.
5769         * cli/cli-utils.h (get_ulongest): Declare.
5770         (check_for_argument): New overloads.
5771         * maint-test-options.c: New file.
5772
5773 2019-06-13  Pedro Alves  <palves@redhat.com>
5774
5775         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5776         parse a range if "-" is at the end of the string.
5777
5778 2019-06-13  Pedro Alves  <palves@redhat.com>
5779
5780         * cli/cli-setshow.c (parse_auto_binary_operation)
5781         (parse_cli_boolean_value): Don't allow "o".
5782
5783 2019-06-13  Pedro Alves  <palves@redhat.com>
5784
5785         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5786         * NEWS: Mention maint test-settings KIND.
5787         * maint-test-settings.c: New file.
5788
5789 2019-06-13  Pedro Alves  <palves@redhat.com>
5790
5791         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5792         completer.
5793         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5794         "set" completers.
5795
5796 2019-06-13  Pedro Alves  <palves@redhat.com>
5797
5798         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5799         after item.
5800
5801 2019-06-13  Pedro Alves  <palves@redhat.com>
5802
5803         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5804
5805 2019-06-13  Pedro Alves <palves@redhat.com>
5806
5807         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5808         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5809         call.
5810         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5811         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5812         calls.
5813         (check_for_argument): Skip spaces after argument.
5814
5815 2019-06-13  Pedro Alves  <palves@redhat.com>
5816
5817         * thread.c (thread_apply_command): Adjust TID parsing.
5818         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5819         detected before end of string.
5820         (tid_is_in_list): Error out if LIST is invalid.
5821
5822 2019-06-13  Pedro Alves  <palves@redhat.com>
5823
5824         * completer.c (complete_line_internal_1): Rewind completion word
5825         point.
5826         (completion_tracker::advance_custom_word_point_by): Change
5827         parameter type to int.
5828         * completer.h (completion_tracker::advance_custom_word_point_by):
5829         Likewise.
5830
5831 2019-06-13  Pedro Alves  <palves@redhat.com>
5832
5833         * completer.c (advance_to_completion_word): Handle delimiters.
5834
5835 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5836
5837         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5838
5839 2019-06-11  Tom Tromey  <tom@tromey.com>
5840
5841         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5842         (xmalloc_failed): Move to alloc.c.
5843         * alloc.c: New file.
5844         * Makefile.in (COMMON_SFILES): Add alloc.c.
5845
5846 2019-06-11  Tom Tromey  <tom@tromey.com>
5847
5848         * nat/linux-waitpid.c: Don't include server.h.
5849         (linux_debug): Remove.
5850         (my_waitpid): Update.
5851
5852 2019-06-11  Tom Tromey  <tromey@adacore.com>
5853
5854         * infcall.c (_initialize_infcall): Remove trailing newline from
5855         help.
5856         * user-regs.c (_initialize_user_regs): Remove trailing newline
5857         from help.
5858         * typeprint.c (_initialize_typeprint): Remove trailing newline
5859         from help.
5860         * reverse.c (_initialize_reverse): Remove trailing newlines from
5861         help.
5862         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5863         from help.
5864         * language.c (add_set_language_command): Remove trailing newline
5865         from help.
5866         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5867         help.
5868         * disasm.c (_initialize_disasm): Remove trailing newline from
5869         help.
5870         * top.c (init_main): Remove trailing newline from help.
5871         * interps.c (_initialize_interpreter): Remove trailing newline
5872         from help.
5873         * btrace.c (_initialize_btrace): Remove trailing newlines from
5874         help.
5875         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5876         from help.
5877         * python/python.c (_initialize_python): Remove trailing newline
5878         from help.
5879         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5880         help.
5881         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5882         from help.  Reformat some text.
5883         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5884         from help.
5885         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5886         newline from help.
5887
5888 2019-06-11  Tom Tromey  <tromey@adacore.com>
5889
5890         * darwin-nat.c (darwin_decode_exception_message)
5891         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5892
5893 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * valops.c (value_slice): Check for not allocated or not
5896         associated values.
5897
5898 2019-06-10  Tom de Vries  <tdevries@suse.de>
5899
5900         PR gdb/24618
5901         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5902         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5903         invalid.
5904
5905 2019-06-10  Tom de Vries  <tdevries@suse.de>
5906
5907         PR gdb/24611
5908         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5909         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5910
5911 2019-06-10  Tom de Vries  <tdevries@suse.de>
5912
5913         PR symtab/24545
5914         * symtab.c (struct demangled_name_entry): Add language field.
5915         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5916         static minimal symbol".  Set and use language field.
5917
5918 2019-06-10  Tom Tromey  <tromey@adacore.com>
5919
5920         * ada-lang.c (_initialize_ada_language): Update help text.
5921
5922 2019-06-10  Tom Tromey  <tromey@adacore.com>
5923
5924         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5925         with a newline.
5926         * guile/guile.c (handle_boot_error): Don't end warning with a
5927         newline.
5928         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5929         warning with a newline.
5930         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5931         newline.
5932         (s12z_frame_cache): Likewise.
5933         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5934         a newline.
5935         * solib-svr4.c (disable_probes_interface): Don't end warning with
5936         a newline.
5937         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5938         newline.
5939         * python/python.c (do_finish_initialization): Don't end warning
5940         with a newline.
5941
5942 2019-06-10  Tom Tromey  <tom@tromey.com>
5943
5944         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5945         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5946         gdbpy_enter.
5947
5948 2019-06-10  Tom Tromey  <tromey@adacore.com>
5949
5950         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5951         data.
5952         (elf_new_init): Don't call stabsread_new_init.
5953         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5954         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5955         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5956
5957 2019-06-10  Tom de Vries  <tdevries@suse.de>
5958
5959         PR symtab/16264
5960         PR symtab/24517
5961         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5962
5963 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5964
5965         * source.c (find_and_open_source): Also rewrite relative file
5966         names.
5967
5968 2019-04-26  Amos Bird  <amosbird@gmail.com>
5969
5970         * annotate.c (annotate_thread_exited): Add "thread-exited"
5971         annotation.
5972
5973 2019-06-06  Tom Tromey  <tromey@adacore.com>
5974
5975         * maint.h (class scoped_command_stats): Use
5976         DISABLE_COPY_AND_ASSIGN.
5977         <print_time>: New method.
5978         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5979         print_time.
5980         (scoped_command_stats::print_time): New method.
5981
5982 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5985         instructions of lengths 6 or 8 bytes.
5986
5987 2019-06-04  Pedro Alves  <palves@redhat.com>
5988
5989         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5990
5991         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5992         * breakpoint.c (condition_completer): Likewise.
5993         * cli/cli-dump.c (scan_expression): Likewise.
5994         * common/filestuff.c (mkdir_recursive): Likewise.
5995         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5996         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5997         (gdb_abspath): Likewise.
5998         * compile/compile-cplus-types.c
5999         (compile_cplus_instance::decl_name): Likewise.
6000         * completer.c (complete_explicit_location):
6001         (signal_completer, reg_or_group_completer_1): Likewise.
6002         * cp-support.c (cp_remove_params_if_any): Likewise.
6003         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6004         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6005         * infcmd.c (strip_bg_char): Likewise.
6006         * linespec.c (copy_token_string): Likewise.
6007         * mi/mi-main.c (output_cores): Likewise.
6008         * psymtab.c (psymtab_search_name):
6009         * symfile.c (test_set_ext_lang_command): Likewise.
6010         * target.c (target_fileio_read_stralloc): Likewise.
6011         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6012         * value.c (complete_internalvar): Likewise.
6013
6014 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6015
6016         Add objfile property to gdb.Type.
6017         * NEWS: Mention Python API addition.
6018         * python/py-type.c (typy_get_objfile): New method.
6019
6020 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6021
6022         * NEWS: Mention the new set|show style [title|highlight].
6023         Mention changes to "show style", "help" and "apropos".
6024
6025 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6026
6027         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6028         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6029         instead of print_help_for_command.
6030         (print_doc_of_command): New function.
6031         (help_list): Add 'apropos -v word' suggestion.
6032         (print_help_for_command): Style the command name using title style.
6033         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6034         (_initialize_cli_cmds): Describe -v in apropos_command help.
6035
6036 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6037
6038         * cli/cli-style.h (cli_style_option): Add name in constructor,
6039         add m_name class member, add constructor with intensity,
6040         add name class function.
6041         (cli_style_option::add_setshow_commands): Remove name argument.
6042         (highlight_style, title_style): New styles.
6043         * cli/cli-style.c (do_show): New function that shows a style
6044         characteristic styling the style name with itself.
6045         (set_style_name): New function.
6046         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6047         Update all callers according to the changes in cli/cli-style.h.
6048         * utils.h (fputs_highlighted): New function.
6049         * utils.c (fputs_highlighted): Likewise.
6050
6051 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6052
6053         * NEWS: Mention new pipe command and new convenience variables.
6054
6055 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6056
6057         * cli/cli-cmds.c (pipe_command): New function.
6058         (_initialize_cli_cmds): Call add_com for pipe_command.
6059         Define | as an alias for pipe.
6060         (exit_status_set_internal_vars): New function.
6061         (shell_escape): Call exit_status_set_internal_vars.
6062         cli/cli-decode.c (find_command_name_length): Recognize | as
6063         a single character command.
6064
6065 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6066
6067         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6068         top.c (execute_command_to_ui_file): New function, mostly a copy
6069         of execute_command_to_string.
6070         (execute_command_to_string): Implement by calling
6071         execute_command_to_ui_file.
6072
6073 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6074
6075         * top.h (saved_command_line): Remove declaration.
6076         * top.c (previous_saved_command_line, previous_repeat_arguments):
6077         New variables.
6078         (saved_command_line): Make static, define together with other
6079         'repeat variables'.
6080         (dont_repeat): Clear repeat_arguments.
6081         (repeat_previous, get_saved_command_line, save_command_line):
6082         New functions.
6083         (gdb_init): Initialize saved_command_line
6084         and previous_saved_command_line.
6085         * main.c (captured_main_1): Remove saved_command_line initialization.
6086         * event-top.c (handle_line_of_input): Update to use
6087         the new 'repeat' related functions instead of direct access to
6088         saved_command_line.
6089         * command.h (repeat_previous, get_saved_command_line,
6090         save_command_line): New declarations.
6091         (dont_repeat): Add comment.
6092
6093 2019-05-30  Tom Tromey  <tromey@adacore.com>
6094
6095         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6096         Fix comment.
6097         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6098
6099 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6100
6101         PR cli/24587
6102         * completer.c (complete): Initialize variable word.
6103
6104 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6105
6106         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6107         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6108         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6109         'body' is NULL to the outter 'if', protecting the '!is_define'
6110         situation as well.
6111
6112 2019-05-29  Tom Tromey  <tromey@adacore.com>
6113
6114         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6115         (dwarf_unknown): New function.
6116         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6117         (dwarf_type_encoding_name): Use dwarf_unknown.
6118
6119 2019-05-29  Tom Tromey  <tromey@adacore.com>
6120
6121         PR c++/20020:
6122         * cp-valprint.c (cp_print_value_fields): Call
6123         cp_print_static_field inside "try".
6124
6125 2019-05-29  Tom Tromey  <tromey@adacore.com>
6126
6127         * inflow.c (struct terminal_info): Add default operator=.
6128         * configure: Rebuild.
6129         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6130         -Wdeprecated-copy-dtor, -Wredundant-move.
6131
6132 2019-05-29  Tom Tromey  <tromey@adacore.com>
6133
6134         * NEWS: Add entry.
6135         * infcmd.c (print_return_value_1): Handle finish_print
6136         option.
6137         (show_print_finish): New function.
6138         (_initialize_infcmd): Add "set/show print finish" commands.
6139         * valprint.c (user_print_options): Initialize new member.
6140         * valprint.h (struct value_print_options) <finish_print>: New
6141         member.
6142
6143 2019-05-28  Tom Tromey  <tromey@adacore.com>
6144
6145         * ada-lang.c (ada_remove_Xbn_suffix)
6146         (find_old_style_renaming_symbol)
6147         (parse_old_style_renaming): Remove.
6148         (ada_find_renaming_symbol): Don't call
6149         find_old_style_renaming_symbol.
6150         (ada_is_renaming_symbol): Rename from
6151         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6152         bool.  Now static.
6153         (ada_read_var_value): Update and simplify.
6154         * ada-exp.y (write_var_or_type): Remove old code.
6155
6156 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6157
6158         * event-top.c: Remove include comment.
6159         * inflow.c (class scoped_ignore_sigttou): Move from here...
6160         * inflow.h (class scoped_ignore_sigttou): ...to here.
6161         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6162         * top.c:  Remove include comment.
6163
6164 2019-05-27  Tom Tromey  <tom@tromey.com>
6165
6166         * NEWS: Fix typo.
6167
6168 2019-05-22  Tom Tromey  <tromey@adacore.com>
6169
6170         * target.c (target_follow_exec): Constify parameter.
6171         * target-delegates.c: Rebuild.
6172         * remote.c (remote_target::follow_exec): Constify parameter.
6173         * infrun.c (follow_exec): Constify parameter.
6174         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6175         (target_follow_exec): Likewise.
6176
6177 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6178
6179         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6180         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6181
6182 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6183
6184         * NEWS: Add debugredirect and testsuite sections.
6185
6186 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6187
6188         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6189         target descriptions using exclusively floating point register name
6190         aliases.
6191
6192 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6193
6194         PR gdb/18644:
6195         * f-lang.c (build_fortran_types): Handle the case where
6196         gdbarch_floatformat_for_type returns a nullptr.
6197
6198 2019-05-21  Tom de Vries  <tdevries@suse.de>
6199
6200         PR cli/24587
6201         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6202
6203 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         PR gdb/18644:
6206         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6207         16-byte floats.
6208         * i386-tdep.c (i386_floatformat_for_type): Use
6209         floatformats_ia64_quad for the 16-byte floating point component
6210         within a fortran 32-byte complex number.
6211
6212 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6215         delete default constructor.
6216         (find_partial_die): Update to return const struct.
6217         (partial_die_parent_scope): Move variable declaration into scope
6218         of its use and change its type to auto.
6219         (guess_partial_die_structure_name): Likewise.
6220         (partial_die_info::fixup): Likewise.
6221
6222 2019-05-17  Tom Tromey  <tromey@adacore.com>
6223
6224         * source.c (find_and_open_source): Remove cast.
6225
6226 2019-05-17  Tom Tromey  <tromey@adacore.com>
6227
6228         * annotate.c (annotate_source): Make "filename" const.
6229         * annotate.h (annotate_source): Use const.
6230
6231 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6232
6233         * disasm.c (set_disassembler_options): Send errors to stderr.
6234
6235 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6236
6237         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6238         (cli_interp_base::set_logging): Check debug_redirect.
6239         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6240         * cli/cli-logging.c (debug_redirect): Add static variable.
6241         (pop_output_files): Add default param.
6242         (handle_redirections): Print debug setting.
6243         (show_logging_command): Likewise.
6244         (_initialize_cli_logging): Add debugredirect command.
6245         * interps.c (current_interp_set_logging): Add debug_redirect
6246         parameter.
6247         * interps.h (set_logging): Add debug_redirect parameter.
6248         (current_interp_set_logging): Likewise.
6249         * mi/mi-common.h: Likewise.
6250         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6251
6252 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6253             Tom Tromey  <tromey@adacore.com>
6254
6255         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6256         directly.
6257         * cli/cli-interp.h (make_logging_output): Remove declaration.
6258         * cli/cli-logging.c (make_logging_output): Remove function.
6259         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6260         directly.
6261         * ui-file.c (tee_file::tee_file): Remove bools.
6262         (tee_file::~tee_file): Remove deletes.
6263         * ui-file.h (tee_file): Remove bools.
6264
6265 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6266
6267         * mi/mi-cmds.h (mi_cmd_complete): New function.
6268         * mi/mi-main.c (mi_cmd_complete): Likewise.
6269         * mi/mi-cmds.c: Define new MI command -complete.
6270         * NEWS: Mention new -complete command.
6271
6272 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6273
6274         * completer.h (complete): New function.
6275         * completer.c (complete): Likewise.
6276         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6277         function defined in completer.h.
6278
6279 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6280
6281         * MAINTAINERS (Write After Approval): Add myself.
6282
6283 2019-05-17  Tom de Vries  <tdevries@suse.de>
6284
6285         PR gdb/24094
6286         * dwarf2read.c (struct cu_partial_die_info): New struct.
6287         (find_partial_die): Return cu_partial_die_info.
6288         (partial_die_parent_scope, guess_partial_die_structure_name)
6289         (partial_die_info::fixup): Handle new return type of find_partial_die.
6290
6291 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6292
6293         PR breakpoints/24541
6294         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6295         "std::string", simplifying the algorithm.
6296
6297 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6298
6299         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6300         (stap_static_probe_ops::get_probes): Likewise.
6301
6302 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6303
6304         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6305         '-')" and "else if".
6306         (stap_parse_single_operand): Join checks for
6307         "gdbarch_stap_parse_special_token_p" and
6308         "gdbarch_stap_parse_special_token" in the same "if" statement.
6309         Invert check when verifying for operation on register
6310         displacement.
6311
6312 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6313
6314         * stap-probe.c (stap_get_opcode): Update comment.
6315         (stap_get_expected_argument_type): Likewise.
6316         (handle_stap_probe): Likewise.
6317
6318 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6319
6320         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6321         return type to 'bool'.  Adjust comment.  Use 'bool' when
6322         appropriate.
6323         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6324         * stap-probe.c (stap_parse_argument_1): Likewise.
6325         (stap_is_operator): Likewise.
6326         (stap_is_generic_prefix): Likewise.
6327         (stap_is_register_prefix): Likewise.
6328         (stap_is_register_indirection_prefix): Likewise.
6329         (stap_is_integer_prefix): Likewise.
6330         (stap_generic_check_suffix): Likewise.
6331         (stap_check_integer_suffix): Likewise.
6332         (stap_check_register_suffix): Likewise.
6333         (stap_check_register_indirection_suffix): Likewise.
6334         (stap_parse_register_operand): Likewise.
6335         (stap_parse_single_operand): Likewise.
6336         (stap_parse_argument_1): Likewise.
6337         (stap_probe::get_argument_count): Likewise.
6338         (stap_is_operator): Likewise.
6339
6340 2019-05-16  Tom Tromey  <tromey@adacore.com>
6341
6342         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6343         keyword to foreach.
6344
6345 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6346
6347         * linux-thread-db.c (try_thread_db_load_1): Change return type
6348         to bool.
6349         (try_thread_db_load): Likewise.
6350         (try_thread_db_load_from_pdir_1): Likewise.
6351         (try_thread_db_load_from_pdir): Likewise.
6352         (try_thread_db_load_from_sdir): Likewise.
6353         (try_thread_db_load_from_dir): Likewise.
6354         (thread_db_load_search): Likewise.
6355         (has_libpthread): Likewise.
6356         (thread_db_load): Likewise.
6357
6358 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6359
6360         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6361         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6362         NULL, and complain/return if that's the case.
6363
6364 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6365
6366         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6367         (advance, posn, abstract_read_memory): New functions.
6368         [struct mem_read_abstraction]: New struct.
6369         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6370
6371 2019-05-14  Tom Tromey  <tromey@adacore.com>
6372
6373         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6374         value is not lval_memory.
6375
6376 2019-05-14  Tom Tromey  <tromey@adacore.com>
6377
6378         * solib.c (info_sharedlibrary_command): Style the file name.
6379
6380 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6381
6382         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6383         (aarch64_vnv_type): Likewise.
6384         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6385         * common/tdesc.c: Likewise.
6386         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6387         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6388         * features/aarch64-fpu.xml: Add ieee half view.
6389         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6390         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6391         * gdbtypes.h (struct builtin_type): Likewise.
6392         (struct objfile_type): Likewise.
6393
6394 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6395
6396         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6397         typo.
6398         * location.h (string_to_event_location): Likewise.
6399
6400 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6401
6402         GDB 8.3 released.
6403
6404 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6405
6406         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6407         New variable declaration.
6408         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6409         New variable.
6410         (print_one_breakpoint): Use ui_out::test_flags and new global
6411         variable to compute use_fixed_output.
6412         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6413         Remove.
6414         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6415         (mi_multi_location_breakpoint_output_fixed): Remove.
6416         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6417         new variable.
6418         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6419         fix_multi_location_breakpoint_output flag if version >= 3.
6420         * ui-out.h (enum ui_out_flag)
6421         <fix_multi_location_breakpoint_output>: New enumerator.
6422
6423 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6424
6425         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6426
6427 2019-05-10  Tom Tromey  <tromey@adacore.com>
6428
6429         * ada-lang.c (catch_ada_completer): New function.
6430         (_initialize_ada_language): Use it.
6431
6432 2019-05-10  Tom Tromey  <tromey@adacore.com>
6433
6434         * thread.c (print_thread_info): Make "requested_threads" const.
6435         * gdbthread.h (print_thread_info): Make "requested_threads"
6436         const.
6437         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6438         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6439
6440 2019-05-08  Tom Tromey  <tom@tromey.com>
6441
6442         * gdbtypes.c (objfile_type_data): Change type.
6443         (objfile_type, _initialize_gdbtypes): Update.
6444
6445 2019-05-08  Tom Tromey  <tom@tromey.com>
6446
6447         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6448         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6449         (_initialize_dwarf2_frame): Update.
6450
6451 2019-05-08  Tom Tromey  <tom@tromey.com>
6452
6453         * objc-lang.c (objc_objfile_data): Change type.
6454         (find_methods): Update.
6455         (_initialize_objc_lang): Remove.
6456
6457 2019-05-08  Tom Tromey  <tom@tromey.com>
6458
6459         * stabsread.c (rs6000_builtin_type_data): Change type.
6460         (rs6000_builtin_type, _initialize_stabsread): Update.
6461
6462 2019-05-08  Tom Tromey  <tom@tromey.com>
6463
6464         * mips-tdep.c (mips_pdr_data): Remove.
6465         (_initialize_mips_tdep): Update.
6466
6467 2019-05-08  Tom Tromey  <tom@tromey.com>
6468
6469         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6470         (hppa_init_objfile_priv_data, read_unwind_info)
6471         (find_unwind_entry, _initialize_hppa_tdep): Update.
6472
6473 2019-05-08  Tom Tromey  <tom@tromey.com>
6474
6475         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6476         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6477         on obstack.
6478         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6479
6480 2019-05-08  Tom Tromey  <tom@tromey.com>
6481
6482         * mdebugread.c (basic_type_data): Change type.
6483         (basic_type, _initialize_mdebugread): Update.
6484
6485 2019-05-08  Tom Tromey  <tom@tromey.com>
6486
6487         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6488
6489 2019-05-08  Tom Tromey  <tom@tromey.com>
6490
6491         * nto-tdep.c (nto_inferior_data_reg): Change type.
6492         (nto_inferior_data): Update.
6493         (nto_inferior_data_cleanup, nto_new_inferior_data)
6494         (_initialize_nto_tdep): Remove.
6495         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6496
6497 2019-05-08  Tom Tromey  <tom@tromey.com>
6498
6499         * ada-lang.c (struct ada_inferior_data): Add initializers.
6500         (ada_inferior_data): Change type.
6501         (ada_inferior_data_cleanup): Remove.
6502         (get_ada_inferior_data, ada_inferior_exit)
6503         (struct ada_pspace_data): Add initializers, destructor.
6504         (ada_pspace_data_handle): Change type.
6505         (get_ada_pspace_data): Update.
6506         (ada_pspace_data_cleanup): Remove.
6507
6508 2019-05-08  Tom Tromey  <tom@tromey.com>
6509
6510         * coffread.c (struct coff_symfile_info): Add initializers.
6511         (coff_objfile_data_key): Move lower.  Change type.
6512         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6513         Update.
6514         (coff_free_info): Remove.
6515
6516 2019-05-08  Tom Tromey  <tom@tromey.com>
6517
6518         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6519         (fbsd_pspace_data_handle): Move lower.  Change type.
6520         (get_fbsd_pspace_data): Update.
6521         (fbsd_pspace_data_cleanup): Remove.
6522         (_initialize_fbsd_tdep): Update.
6523
6524 2019-05-08  Tom Tromey  <tom@tromey.com>
6525
6526         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6527         (get_ada_tasks_pspace_data): Update.
6528         (ada_tasks_pspace_data_cleanup): Remove.
6529         (_initialize_tasks): Update.
6530         (ada_tasks_inferior_data_handle): Change type.
6531         (get_ada_tasks_inferior_data): Update.
6532         (ada_tasks_inferior_data_cleanup): Remove.
6533         (struct ada_tasks_pspace_data): Add initializers.
6534
6535 2019-05-08  Tom Tromey  <tom@tromey.com>
6536
6537         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6538         * symfile-debug.c (debug_sym_get_probes): Change type.
6539         * stap-probe.c (handle_stap_probe):
6540         (stap_static_probe_ops::get_probes): Change type.
6541         * probe.h (class static_probe_ops) <get_probes>: Change type.
6542         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6543         (parse_probes_in_pspace): Update.
6544         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6545         Update.
6546         (any_static_probe_ops::get_probes): Change type.
6547         * elfread.c (elfread_data): New typedef.
6548         (probe_key): Change type.
6549         (elf_get_probes): Likewise.  Update.
6550         (probe_key_free): Remove.
6551         (_initialize_elfread): Update.
6552         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6553         Change type.
6554         (dtrace_process_dof_probe, dtrace_process_dof)
6555         (dtrace_static_probe_ops::get_probe): Change type.
6556
6557 2019-05-08  Tom Tromey  <tom@tromey.com>
6558
6559         * xcoffread.c (struct xcoff_symfile_info): Rename from
6560         coff_symfile_info.  Add initializers.
6561         (xcoff_objfile_data_key): Move lower.  Change type.
6562         (XCOFF_DATA): Rewrite.
6563         (xcoff_free_info): Remove.
6564         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6565         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6566         (xcoff_initial_scan): Update.
6567
6568 2019-05-08  Tom Tromey  <tom@tromey.com>
6569
6570         * solib-svr4.c (struct svr4_info): Add initializers and
6571         destructor.
6572         <probes_table>: Now an htab_up.
6573         (solib_svr4_pspace_data): Change type.
6574         (free_probes_table): Simplify.
6575         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6576         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6577         (probes_table_remove_objfile_probes, register_solib_event_probe)
6578         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6579         (_initialize_svr4_solib): Update.
6580
6581 2019-05-08  Tom Tromey  <tom@tromey.com>
6582
6583         * remote.c (remote_pspace_data): Change type.
6584         (remote_pspace_data_cleanup): Remove.
6585         (get_remote_exec_file, set_pspace_remote_exec_file)
6586         (_initialize_remote): Update.
6587
6588 2019-05-08  Tom Tromey  <tom@tromey.com>
6589
6590         * breakpoint.c (breakpoint_objfile_key): Change type.
6591         (get_breakpoint_objfile_data): Update.
6592         (free_breakpoint_objfile_data): Remove.
6593         (_initialize_breakpoint): Update.
6594
6595 2019-05-08  Tom Tromey  <tom@tromey.com>
6596
6597         * linux-tdep.c (struct linux_info): Add initializers.
6598         (linux_inferior_data): Move.  Change type.
6599         (invalidate_linux_cache_inf): Update.
6600         (linux_inferior_data_cleanup): Remove.
6601         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6602
6603 2019-05-08  Tom Tromey  <tom@tromey.com>
6604
6605         * auxv.c (auxv_inferior_data): Move.  Change type.
6606         (auxv_inferior_data_cleanup): Remove.
6607         (invalidate_auxv_cache_inf): Rewrite.
6608         (get_auxv_inferior_data, _initialize_auxv): Update.
6609
6610 2019-05-08  Tom Tromey  <tom@tromey.com>
6611
6612         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6613         (symfile_debug_objfile_data_key): Change type.
6614         (symfile_debug_installed, debug_qf_has_symbols)
6615         (debug_qf_find_last_source_symtab)
6616         (debug_qf_forget_cached_source_info)
6617         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6618         (debug_qf_print_stats, debug_qf_dump)
6619         (debug_qf_expand_symtabs_for_function)
6620         (debug_qf_expand_all_symtabs)
6621         (debug_qf_expand_symtabs_with_fullname)
6622         (debug_qf_map_matching_symbols)
6623         (debug_qf_expand_symtabs_matching)
6624         (debug_qf_find_pc_sect_compunit_symtab)
6625         (debug_qf_map_symbol_filenames)
6626         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6627         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6628         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6629         (debug_sym_read_linetable, debug_sym_relocate): Update.
6630         (symfile_debug_free_objfile): Remove.
6631         (install_symfile_debug_logging, _initialize_symfile_debug):
6632         Update.
6633
6634 2019-05-08  Tom Tromey  <tom@tromey.com>
6635
6636         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6637         allocate_on_obstack.
6638         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6639         (get_dwarf2_per_objfile): Update.
6640         (set_dwarf2_per_objfile): Remove.
6641         (dwarf2_has_info, dwarf2_get_section_info): Update.
6642         (dwarf2_free_objfile): Remove.
6643         (_initialize_dwarf2_read): Update.
6644
6645 2019-05-08  Tom Tromey  <tom@tromey.com>
6646
6647         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6648         initializers.
6649         <unsupported_script_warning_printed,
6650         script_not_found_warning_printed>: Now bool.
6651         (auto_load_pspace_data): Change type.
6652         (~auto_load_pspace_info): Rename from
6653         auto_load_pspace_data_cleanup.
6654         (get_auto_load_pspace_data, init_loaded_scripts_info)
6655         (clear_section_scripts, maybe_print_unsupported_script_warning)
6656         (maybe_print_script_not_found_warning, _initialize_auto_load):
6657         Update.
6658
6659 2019-05-08  Tom Tromey  <tom@tromey.com>
6660
6661         * objfiles.c (objfile_pspace_info): Add destructor and
6662         initializers.
6663         (objfiles_pspace_data): Change type.
6664         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6665         (get_objfile_pspace_data): Update.
6666         (objfiles_bfd_data): Change type.
6667         (get_objfile_bfd_data): Update.
6668         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6669
6670 2019-05-08  Tom Tromey  <tom@tromey.com>
6671
6672         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6673         Change type.
6674         (get_catch_syscall_inferior_data): Update.
6675         (catch_syscall_inferior_data_cleanup): Remove.
6676         (_initialize_break_catch_syscall): Update.
6677
6678 2019-05-08  Tom Tromey  <tom@tromey.com>
6679
6680         * inflow.c (struct terminal_info): Add destructor and
6681         initializers.
6682         (inflow_inferior_data): Change type.
6683         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6684         (get_inflow_inferior_data, inflow_inferior_exit)
6685         (swap_terminal_info, _initialize_inflow): Update.
6686
6687 2019-05-08  Tom Tromey  <tom@tromey.com>
6688
6689         * target-dcache.c (target_dcache_cleanup): Remove.
6690         (target_dcache_aspace_key): Change type.
6691         (target_dcache_init_p, target_dcache_invalidate)
6692         (target_dcache_get, target_dcache_get_or_init)
6693         (_initialize_target_dcache): Update.
6694         * dcache.h (struct dcache_deleter): New.
6695
6696 2019-05-08  Tom Tromey  <tom@tromey.com>
6697
6698         * symtab.c (struct symbol_cache): Add destructor and
6699         initializers.
6700         (symbol_cache_key): Move.  Change type.
6701         (make_symbol_cache, free_symbol_cache): Remove.
6702         (get_symbol_cache): Update.
6703         (symbol_cache_cleanup): Remove.
6704         (ALL_PSPACES, symbol_cache_flush)
6705         (maintenance_print_symbol_cache)
6706         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6707         Update.
6708
6709 2019-05-08  Tom Tromey  <tom@tromey.com>
6710
6711         * symtab.c (struct main_info): Add destructor and initializers.
6712         (main_progspace_key): Move.  Change type.
6713         (get_main_info): Update.
6714         (main_info_cleanup): Remove.
6715         (_initialize_symtab): Update.
6716
6717 2019-05-08  Tom Tromey  <tom@tromey.com>
6718
6719         * registry.h (DECLARE_REGISTRY): Define the _key class.
6720
6721 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6722
6723         * NEWS: Merge two 'New commands' sections.
6724
6725 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6726
6727         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6728         parameter and use Ada language definition instead.
6729         (ada_val_print_ptr): Remove unused language parameter.
6730         (ada_val_print_num): Remove language parameter and use Ada language
6731         definition instead.
6732         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6733         parameter.
6734         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6735         parameter and use Ada language definition instead.
6736         (ada_val_print_1): Update all ada_val_print_xxx calls.
6737         Remove language parameter.
6738         (ada_val_print): Update ada_val_print_1 call.
6739
6740 2019-05-08  Tom Tromey  <tromey@adacore.com>
6741
6742         * remote.c (remote_hw_watchpoint_limit)
6743         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6744         Now static.
6745
6746 2019-05-08  Tom Tromey  <tromey@adacore.com>
6747
6748         * maint.c (_initialize_maint_cmds): Move initialization code to
6749         remote.c.
6750         (watchdog, show_watchdog): Move to remote.c.
6751         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6752         "watchdog" static.
6753         (_initialize_remote): Move initialization code from maint.c.
6754         * defs.h (watchdog): Don't declare.
6755
6756 2019-05-08  Tom Tromey  <tromey@adacore.com>
6757
6758         * tui/tui-interp.c: Include main.h.
6759         * interps.c: Include main.h.
6760         * main.h (interpreter_p): Declare.
6761         * defs.h (interpreter_p): Don't declare.
6762
6763 2019-05-08  Tom Tromey  <tromey@adacore.com>
6764
6765         * dwarf2loc.c: Include dwarf2read.h.
6766         * defs.h (read_unsigned_leb128): Don't declare.
6767         * dwarf2read.h (read_unsigned_leb128): Declare.
6768
6769 2019-05-08  Tom Tromey  <tromey@adacore.com>
6770
6771         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6772         method.
6773
6774 2019-05-08  Tom Tromey  <tromey@adacore.com>
6775
6776         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6777         when no wrap column is set.
6778
6779 2019-05-08  Tom Tromey  <tromey@adacore.com>
6780
6781         * c-lang.c (c_get_string): Handle non-C-style arrays.
6782
6783 2019-05-08  Tom Tromey  <tromey@adacore.com>
6784
6785         * typeprint.c (print_offset_data::update): Print the bit offset,
6786         not the number of bits remaining.
6787
6788 2019-05-08  Tom Tromey  <tromey@adacore.com>
6789
6790         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6791         padding at end of comment.
6792
6793 2019-05-08  Tom Tromey  <tromey@adacore.com>
6794
6795         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6796         Compare main types.
6797
6798 2019-05-06  Tom Tromey  <tom@tromey.com>
6799
6800         * common/scoped_mmap.c: Include common-defs.h.
6801         * common/scoped_mmap.h: Don't include config.h.
6802
6803 2019-05-04  Tom Tromey  <tom@tromey.com>
6804
6805         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6806         (struct aarch64_call_info): Add initializers.
6807         <si>: Now a std::vector.
6808         (pass_on_stack, aarch64_push_dummy_call): Update.
6809
6810 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6811             Tom Tromey  <tom@tromey.com>
6812
6813         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6814         (ppc_threads): Now a std::vector.  Now static.
6815         (hwdebug_find_thread_points_by_tid)
6816         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6817         Update.
6818
6819 2019-05-04  Tom Tromey  <tom@tromey.com>
6820
6821         * arc-tdep.c (arc_tdesc_init): Return bool.
6822
6823 2019-05-04  Tom Tromey  <tom@tromey.com>
6824
6825         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6826         Use gdb_assert_not_reached.
6827
6828 2019-05-04  Tom Tromey  <tom@tromey.com>
6829
6830         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6831         "false".
6832
6833 2019-05-04  Tom Tromey  <tom@tromey.com>
6834
6835         * arc-tdep.c (arc_tdesc_init): Use bool.
6836
6837 2019-05-04  Tom Tromey  <tom@tromey.com>
6838
6839         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6840
6841 2019-05-04  Tom Tromey  <tom@tromey.com>
6842
6843         * cli/cli-cmds.c (valid_command_p): Return bool.
6844
6845 2019-05-04  Tom Tromey  <tom@tromey.com>
6846
6847         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6848         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6849
6850 2019-05-04  Raul Tambre  <raul@tambre.ee>
6851
6852         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6853         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6854         operator for comparison.
6855
6856 2019-05-04  Tom Tromey  <tom@tromey.com>
6857
6858         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6859         (lookup_partial_symbol, print_partial_symbols)
6860         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6861         (psymbol_compare): Update.
6862         (add_psymbol_to_bcache): Clear the entire psymbol.
6863         (maintenance_check_psymtabs): Update.
6864         * psympriv.h (struct partial_symbol): Don't derive from
6865         general_symbol_info.
6866         <obj_section, unrelocated_address, address,
6867         set_unrelocated_address>: Update.
6868         <ginfo>: New member.
6869         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6870         (debug_names::write_psymbols): Update.
6871
6872 2019-05-04  Tom de Vries  <tdevries@suse.de>
6873
6874         * contrib/cc-with-tweaks.sh: Support -n arg.
6875
6876 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6877
6878         * corelow.c (core_target::detach): Ensure frame cache and
6879         register caches are cleared.
6880         inferior.c (exit_inferior_1): Likewise.
6881
6882 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6883             Tom Tromey  <tom@tromey.com>
6884
6885         * dictionary.c (collate_pending_symbols_by_language): Remove
6886         "struct" from foreach.
6887         * symtab.c (lookup_global_symbol_from_objfile)
6888         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6889         foreach.
6890         * ser-tcp.c (net_open): Remove "struct" from foreach.
6891         * objfiles.c (objfile_relocate, objfile_rebase)
6892         (objfile_has_symbols): Remove "struct" from foreach.
6893         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6894         from foreach.
6895         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6896         foreach.
6897         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6898         "struct" from foreach.
6899         * ada-lang.c (create_excep_cond_exprs)
6900         (ada_exception_catchpoint_cond_string): Remove "struct" from
6901         foreach.
6902
6903 2019-05-03  Tom Tromey  <tromey@adacore.com>
6904
6905         * ada-exp.y (convert_char_literal): Check suffix of each
6906         enumerator.
6907
6908 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6909
6910         PR ada/21406:
6911         * ada-exp.y (yywrap): Don't define.
6912         * ada-lex.l (%option): Add noyywrap
6913         (yywrap): Remove.
6914
6915 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6916
6917         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6918         _WIN32_WINNT to the XP level, unless already defined to a higher
6919         level.
6920
6921         * unittests/parse-connection-spec-selftests.c:
6922         * ser-tcp.c:
6923         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6924         override.
6925
6926         * symfile.c (find_separate_debug_file): Remove colon from the
6927         drive spec of DOS/Windows file names of the target, so that the
6928         file name produced from DEBUGDIR and the target's directory will
6929         be valid on DOS/Windows systems.
6930
6931 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * rust-lang.c (val_print_struct): Handle printing structures
6934         containing strings.
6935
6936 2019-05-02  Tom Tromey  <tromey@adacore.com>
6937
6938         * valarith.c (_initialize_valarith): Remove.
6939
6940 2019-05-01  Tom Tromey  <tromey@adacore.com>
6941
6942         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6943         bitfields.
6944
6945 2019-05-01  Tom Tromey  <tromey@adacore.com>
6946
6947         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6948         for big-endian copies.
6949
6950 2019-04-30  Ali Tamur  <tamur@google.com>
6951         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6952         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6953         (read_3_bytes): New function.
6954
6955 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6956
6957         * windows-nat.c (main_thread_id): Delete.
6958         (handle_output_debug_string): Replace main_thread_id by
6959         current_event.dwThreadId.
6960         (fake_create_process): Likewise.
6961         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6962         Do not set main_thread_id.
6963         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6964         current_event.dwThreadId.
6965         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6966
6967 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6968
6969         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6970         Use current_event.dwThreadId instead of main_thread_id.
6971
6972 2019-04-30  Tom Tromey  <tromey@adacore.com>
6973
6974         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6975         (create_excep_cond_exprs): Iterate over program spaces.
6976         (ada_exception_catchpoint_cond_string): Examine all minimal
6977         symbols for exception types.
6978
6979 2019-04-30  Tom Tromey  <tromey@adacore.com>
6980
6981         PR c++/24470:
6982         * dwarf2read.c (process_structure_scope): Handle case where type
6983         has template parameters but no symbol was created.
6984
6985 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6986             Chris January  <chris.january@arm.com>
6987
6988         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6989         qualifier.
6990         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6991
6992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * f-typeprint.c (f_print_type): Update rules for printing
6995         whitespace.
6996         (f_type_print_varspec_suffix): Likewise.
6997
6998 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6999             Chris January  <chris.january@arm.com>
7000
7001         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7002         function arguments.
7003
7004 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * f-lang.c (build_fortran_types): Change name of void type to
7007         lower case.
7008         * f-typeprint.c (f_type_print_base): Print the name of the void
7009         type, rather than a fixed string.
7010         * f-valprint.c (f_decorations): Use lower case void string.
7011
7012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7013             Chris January  <chris.january@arm.com>
7014
7015         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7016         types for Fortran.
7017
7018 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7019             Chris January  <chris.january@arm.com>
7020             David Lecomber  <david.lecomber@arm.com>
7021
7022         * f-exp.y (BINOP_INTRINSIC): New token.
7023         (exp): New parser rule handling BINOP_INTRINSIC.
7024         (f77_keywords): Add new builtin procedures.
7025         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7026         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7027         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7028         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7029         (print_unop_subexp_f): New function.
7030         (print_binop_subexp_f): New function.
7031         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7032         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7033         (dump_subexp_body_f): Likewise.
7034         (operator_check_f): Likewise.
7035         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7036         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7037
7038 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7039
7040         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7041         UNOP_KIND.
7042         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7043         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7044         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7045         (operator_length_f): New fuction.
7046         (print_subexp_f): New function.
7047         (op_name_f): New function.
7048         (dump_subexp_body_f): New function.
7049         (operator_check_f): New function.
7050         (exp_descriptor_f): Replace standard expression handling functions
7051         with new functions.
7052         * gdb/fortran-operator.def: New file.
7053         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7054         * gdb/std-operator.def: Remove UNOP_KIND.
7055
7056 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * std-operator.def: Remove unbalanced, stray double quote
7059         character.
7060
7061 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7062             Chris January  <chris.january@arm.com>
7063             Daniel Everett  <daniel.everett@arm.com>
7064             Nick Forrington  <nick.forrington@arm.com>
7065             Richard Bunt  <richard.bunt@arm.com>
7066
7067         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7068         of depth when printing anonymous structs or unions.
7069         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7070         Don't print either the top-level value, or the children if the
7071         max-depth is exceeded.
7072         (ppscm_print_children): When printing the key of a map, allow one
7073         extra level of depth.
7074         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7075         print either the top-level value, or the children if the max-depth
7076         is exceeded.
7077         (print_children): When printing the key of a map, allow one extra
7078         level of depth.
7079         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7080         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7081         (user_print_options): Initialise max_depth field.
7082         (val_print_scalar_or_string_type_p): New function.
7083         (val_print): Check to see if the max depth has been reached.
7084         (val_print_check_max_depth): Define new function.
7085         (show_print_max_depth): New function.
7086         (_initialize_valprint): Add 'print max-depth' option.
7087         * valprint.h (struct value_print_options) <max_depth>: New field.
7088         (val_print_check_max_depth): Declare new function.
7089         * NEWS: Document new feature.
7090
7091 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * ada-lang.c (ada_language_defn): Initialise new field.
7094         * c-lang.c (c_is_string_type_p): New function.
7095         (c_language_defn): Initialise new field.
7096         (cplus_language_defn): Initialise new field.
7097         (asm_language_defn): Initialise new field.
7098         (minimal_language_defn): Initialise new field.
7099         * c-lang.h (c_is_string_type_p): Declare new function.
7100         * d-lang.c (d_language_defn): Initialise new field.
7101         * f-lang.c (f_is_string_type_p): New function.
7102         (f_language_defn): Initialise new field.
7103         * go-lang.c (go_is_string_type_p): New function.
7104         (go_language_defn): Initialise new field.
7105         * language.c (default_is_string_type_p): New function.
7106         (unknown_language_defn): Initialise new field.
7107         (auto_language_defn): Initialise new field.
7108         * language.h (struct language_defn) <la_is_string_type_p>: New
7109         member variable.
7110         (default_is_string_type_p): Declare new function.
7111         * m2-lang.c (m2_language_defn): Initialise new field.
7112         * objc-lang.c (objc_language_defn): Initialise new field.
7113         * opencl-lang.c (opencl_language_defn): Initialise new field.
7114         * p-lang.c (pascal_is_string_type_p): New function.
7115         (pascal_language_defn): Initialise new field.
7116         * rust-lang.c (rust_is_string_type_p): New function.
7117         (rust_language_defn): Initialise new field.
7118
7119 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7120
7121         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7122         New field.
7123         * ada-lang.c (ada_language_defn): Initialise new field.
7124         * c-lang.c (c_language_defn): Likewise.
7125         (cplus_language_defn): Likewise.
7126         (asm_language_defn): Likewise.
7127         (minimal_language_defn): Likewise.
7128         * d-lang.c (d_language_defn): Likewise.
7129         * f-lang.c (f_language_defn): Likewise.
7130         * go-lang.c (go_language_defn): Likewise.
7131         * language.c (unknown_language_defn): Likewise.
7132         (auto_language_defn): Likewise.
7133         * m2-lang.c (m2_language_defn): Likewise.
7134         * objc-lang.c (objc_language_defn): Likewise.
7135         * opencl-lang.c (opencl_language_defn): Likewise.
7136         * p-lang.c (pascal_language_defn): Likewise.
7137         * rust-lang.c (rust_language_defn): Likewise.
7138
7139 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7140
7141         * ada-lang.c (ada_is_character_type): Change return type to bool.
7142         (ada_is_string_type): Likewise.
7143         * ada-lang.h (ada_is_character_type): Update declaration
7144         (ada_is_string_type): Likewise.
7145
7146 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7147
7148         Support style in 'frame|thread apply'
7149
7150         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7151         * record.c (record_start, record_stop): Update callers of
7152         execute_command_to_string with false.
7153         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7154         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7155         methods.
7156         (class string_file): New constructor with term_out parameter.
7157         Override methods term_out and can_emit_style_escape.  New member
7158         term_out.
7159         (class stdio_file): Override can_emit_style_escape.
7160         (class tee_file): Override term_out and can_emit_style_escape.
7161         * utils.h (can_emit_style_escape): Remove.
7162         * utils.c (can_emit_style_escape): Likewise.
7163         Update all callers of can_emit_style_escape (SOMESTREAM) to
7164         SOMESTREAM->can_emit_style_escape.
7165         * source-cache.c (source_cache::get_source_lines): Likewise.
7166         * stack.c (frame_apply_command_count): Call execute_command_to_string
7167         passing the term_out characteristic of the current gdb_stdout.
7168         * thread.c (thr_try_catch_cmd): Likewise.
7169         * top.c (execute_command_to_string): pass term_out parameter
7170         to construct the string_file for the command output.
7171         * ui-file.c (term_cli_styling): New function (most code moved
7172         from utils.c can_emit_style_escape).
7173         (string_file::string_file, string_file::can_emit_style_escape,
7174         stdio_file::can_emit_style_escape, tee_file::term_out,
7175         tee_file::can_emit_style_escape): New functions.
7176
7177 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7178
7179         * NEWS: Mention the new set|show may-call-functions.
7180         * infcall.c (may_call_functions_p): New variable.
7181         (show_may_call_functions_p): New function.
7182         (call_function_by_hand_dummy): Throws an error if not
7183         may-call-functions.
7184         (_initialize_infcall): Call add_setshow_boolean_cmd for
7185         may-call-functions.
7186
7187 2019-04-25  Keith Seitz  <keiths@redhat.com>
7188
7189         PR c++/24367
7190         * cp-support.c (inspect_type): Don't attempt substitutions
7191         of symbol with the same name.
7192
7193 2019-04-25  Tom Tromey  <tromey@adacore.com>
7194
7195         PR gdb/24475:
7196         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7197         static.
7198
7199 2019-04-25  Tom Tromey  <tromey@adacore.com>
7200
7201         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7202         rvalue reference.
7203         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7204         (gdb_xml_parser::parse): Use std::move.
7205         * python/python-internal.h (gdbpy_convert_exception): Take a const
7206         reference.
7207         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7208         std::move.
7209         * python/py-utils.c (gdbpy_convert_exception): Take a const
7210         reference.
7211         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7212         Use std::move.
7213         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7214         Use std::move.
7215         * mi/mi-main.c (mi_print_exception): Take a const reference.
7216         * main.c (handle_command_errors): Take a const reference.
7217         * linespec.c (parse_linespec): Use std::move.
7218         * infcall.c (run_inferior_call): Use std::move.
7219         (call_function_by_hand_dummy): Use std::move.
7220         * exec.c (try_open_exec_file): Use std::move.
7221         * exceptions.h (exception_print, exception_fprintf)
7222         (exception_print_same): Update.
7223         * exceptions.c (print_exception, exception_print)
7224         (exception_fprintf, exception_print_same): Change parameters to
7225         const reference.
7226         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7227         * common/new-op.c: Use std::move.
7228         * common/common-exceptions.h (struct gdb_exception): Add move
7229         constructor.
7230         (struct gdb_exception_error, struct gdb_exception_quit, struct
7231         gdb_quit_bad_alloc): Change constructor to move constructor.
7232         (throw_exception): Change parameter to rvalue reference.
7233         * common/common-exceptions.c (throw_exception): Take rvalue
7234         reference.
7235         * cli/cli-interp.c (safe_execute_command): Use std::move.
7236         * breakpoint.c (insert_bp_location, location_to_sals): Use
7237         std::move.
7238
7239 2019-04-25  Tom Tromey  <tromey@adacore.com>
7240
7241         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7242         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7243         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7244         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7245         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7246         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7247         guile/scm-value.c: Use unpack.
7248         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7249         gdbscm_gdb_exception.
7250         (gdbscm_throw_gdb_exception): Likewise.
7251         (struct gdbscm_gdb_exception): New.
7252         (unpack): New function.
7253         (gdbscm_wrap): Use unpack.
7254
7255 2019-04-25  Tom Tromey  <tromey@adacore.com>
7256
7257         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7258         (gdb_rl_callback_handler): Use std::move.
7259         * common/common-exceptions.h (struct gdb_exception): Add move
7260         assignment operator.
7261         (throw_exception_sjlj): Change "exception" to const reference.
7262         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7263         (throw_exception_sjlj): Change "exception" to const reference.
7264
7265 2019-04-25  Tom Tromey  <tromey@adacore.com>
7266
7267         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7268         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7269         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7270         Update.
7271         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7272         Update.
7273         * mi/mi-interp.c (mi_interp::exec): Update.
7274         * linespec.c (parse_linespec): Update.
7275         * infcall.c (run_inferior_call): Update.
7276         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7277         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7278         (gdbscm_lookup_global_symbol): Update.
7279         * guile/scm-param.c (gdbscm_parameter_value): Update.
7280         * guile/scm-frame.c (gdbscm_frame_read_register)
7281         (gdbscm_frame_read_var): Update.
7282         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7283         * exec.c (try_open_exec_file): Update.
7284         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7285         (gdb_rl_callback_handler): Update.
7286         * common/common-exceptions.h (exception_none): Don't declare.
7287         * common/common-exceptions.c (exception_none): Don't define.
7288         (struct catcher) <exception>: Update.
7289         * cli/cli-interp.c (safe_execute_command): Update.
7290         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7291
7292 2019-04-25  Ali Tamur  <tamur@google.com>
7293
7294         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7295         (read_attribute_value): Likewise.
7296         (dwarf2_read_addr_index): Update comment.
7297         (read_str_index): Add DW_FORM_strx.
7298         (dwarf2_string_attr): Likewise.
7299         (dwarf2_const_value_attr): Likewise.
7300         (dump_die_shallow): Likewise.
7301         (dwarf2_fetch_constant_bytes): Likewise.
7302         (skip_form_bytes): Likewise.
7303         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7304
7305 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7306
7307         PR corefiles/11608
7308         PR corefiles/18187
7309         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7310         OFFSET.  Verify if current mapping contains an ELF header.
7311         (linux_find_memory_regions_full): Adjust call to
7312         dump_mapping_p.
7313
7314 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7315             Kang Li <kanglictf@gmail.com>
7316
7317         PR gdb/21600
7318
7319         * dwarf2-frame.c (read_initial_length): Be consistent about using
7320         unsigned representation of length.
7321         (decode_frame_entry_1): Likewise.  Check for wraparound of
7322         end pointer as well as buffer overflow.
7323
7324 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7325
7326         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7327         "vq".
7328
7329 2019-04-24  Tom Tromey  <tromey@adacore.com>
7330
7331         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7332
7333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * s12z-tdep.c (s12z_unwind_pc): Delete.
7336         (s12z_unwind_sp): Delete.
7337         (s12z_gdbarch_init): Don't register deleted functions with
7338         gdbarch.
7339
7340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * rl78-tdep.c (rl78_unwind_sp): Delete.
7343         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7344
7345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7346
7347         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7348         (xstormy16_unwind_pc): Delete.
7349         (xstormy16_dummy_id): Delete.
7350         (xstormy16_gdbarch_init): Don't register deleted functions with
7351         gdbarch.
7352
7353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7354
7355         * vax-tdep.c (vax_unwind_pc): Delete.
7356         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7357
7358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * v850-tdep.c (v850_unwind_sp): Delete.
7361         (v850_unwind_pc): Delete.
7362         (v850_dummy_id): Delete.
7363         (v850_gdbarch_init): Don't register deleted functions with
7364         gdbarch.
7365
7366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7369         (tilegx_unwind_pc): Delete.
7370         (tilegx_unwind_dummy_id): Delete.
7371         (tilegx_gdbarch_init): Don't register deleted functions with
7372         gdbarch.
7373
7374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7375
7376         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7377         (tic6x_dummy_id): Delete.
7378         (tic6x_gdbarch_init): Don't register deleted functions with
7379         gdbarch.
7380
7381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7382
7383         * sparc-tdep.c (sparc_unwind_pc): Delete.
7384         (sparc32_gdbarch_init): Don't register deleted function with
7385         gdbarch.
7386
7387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7388
7389         * sh-tdep.c (sh_unwind_sp): Delete.
7390         (sh_unwind_pc): Delete.
7391         (sh_dummy_id): Delete.
7392         (sh_gdbarch_init): Don't register deleted functions with
7393         gdbarch.
7394
7395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7396
7397         * score-tdep.c (score_unwind_sp): Delete.
7398         (score_unwind_pc): Delete.
7399         (score_dummy_id): Delete.
7400         (score_gdbarch_init): Don't register deleted functions with
7401         gdbarch.
7402
7403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7404
7405         * rx-tdep.c (rx_unwind_pc): Delete.
7406         (rx_unwind_sp): Delete.
7407         (rx_dummy_id): Delete.
7408         (rx_gdbarch_init): Don't register deleted functions with
7409         gdbarch.  Update comment.
7410
7411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7414         (rs6000_dummy_id): Delete.
7415         (rs6000_gdbarch_init): Don't register deleted functions with
7416         gdbarch.
7417
7418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7419
7420         * or1k-tdep.c (or1k_dummy_id): Delete.
7421         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7422
7423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7424
7425         * nios2-tdep.c (nios2_dummy_id): Delete.
7426         (nios2_unwind_sp): Delete.
7427         (nios2_gdbarch_init): Don't register deleted functions with
7428         gdbarch.
7429
7430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * nds32-tdep.c (nds32_dummy_id): Delete.
7433         (nds32_unwind_pc): Delete.
7434         (nds32_unwind_sp): Delete.
7435         (nds32_gdbarch_init): Don't register deleted functions with
7436         gdbarch.
7437
7438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7439
7440         * msp430-tdep.c (msp430_unwind_pc): Delete.
7441         (msp430_unwind_sp): Delete.
7442         (msp430_dummy_id): Delete.
7443         (msp430_gdbarch_init): Don't register deleted functions with
7444         gdbarch.
7445
7446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * moxie-tdep.c (moxie_unwind_sp): Delete.
7449         (moxie_unwind_pc): Delete.
7450         (moxie_dummy_id): Delete.
7451         (moxie_gdbarch_init): Don't register deleted functions with
7452         gdbarch.
7453
7454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7457         (mn10300_unwind_pc): Delete.
7458         (mn10300_unwind_sp): Delete.
7459         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7460         mn10300_unwind_sp.
7461         (mn10300_frame_unwind_init): Don't register deleted functions with
7462         gdbarch.
7463
7464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * mep-tdep.c (mep_unwind_pc): Delete.
7467         (mep_unwind_sp): Delete.
7468         (mep_dummy_id): Delete.
7469         (mep_gdbarch_init): Don't register deleted functions with
7470         gdbarch.
7471
7472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7473
7474         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7475         (m68hc11_unwind_sp): Delete.
7476         (m68hc11_gdbarch_init): Don't register deleted functions with
7477         gdbarch.
7478
7479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7480
7481         * m32r-tdep.c (m32r_unwind_sp): Delete.
7482         (m32r_unwind_pc): Delete.
7483         (m32r_dummy_id): Delete.
7484         (m32r_gdbarch_init): Don't register deleted functions with
7485         gdbarch.
7486
7487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * m32c-tdep.c (m32c_unwind_pc): Delete.
7490         (m32c_unwind_sp): Delete.
7491         (m32c_dummy_id): Delete.
7492         (m32c_gdbarch_init): Don't register deleted functions with
7493         gdbarch.
7494
7495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7498         (lm32_unwind_pc): Delete.
7499         (lm32_dummy_id): Delete.
7500         (lm32_gdbarch_init): Don't register deleted functions with
7501         gdbarch.
7502
7503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7506         (iq2000_unwind_pc): Delete.
7507         (iq2000_dummy_id): Delete.
7508         (iq2000_gdbarch_init): Don't register deleted functions with
7509         gdbarch.
7510
7511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7512
7513         * nds32-tdep.c (nds32_type_align): Delete.
7514         (nds32_push_dummy_call): Use type_align instead.
7515
7516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7517
7518         * arm-tdep.c (arm_type_align): Only handle vector override case.
7519         (arm_push_dummy_call): Use type_align.
7520         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7521
7522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7525         case.
7526         (pass_on_stack): Use type_align.
7527         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7528         function.
7529
7530 2019-04-23  Tom Tromey  <tromey@adacore.com>
7531
7532         * dwarf2read.c (line_header::file_name_at): Remove unused
7533         overload.
7534
7535 2019-04-23  Tom de Vries  <tdevries@suse.de>
7536
7537         PR gdb/24438
7538         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7539         invocation.
7540
7541
7542 2019-03-27  Ali Tamur  <tamur@google.com>
7543
7544         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7545         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7546         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7547         (dwarf_expr_context::get_addr_index): Likewise
7548         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7549         (symbol_needs_eval_context::get_addr_index): Likewise
7550         (disassemble_dwarf_expression): Add DW_OP_addrx
7551         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7552         (read_cutu_die_from_dwo): Update comment
7553         (skip_one_die): Add DW_FORM_addrx
7554         (read_attribute_value): Likewise
7555         (var_decode_location): Add DW_OP_addrx
7556         (dwarf2_const_value_attr): Add DW_FORM_addrx
7557         (dump_die_shallow): Likewise
7558         (dwarf2_fetch_constant_bytes): Likewise
7559         (decode_locdesc): Add DW_OP_addrx
7560         (skip_form_bytes): Add DW_FORM_addrx
7561
7562 2019-04-22  Ali Tamur  <tamur@google.com>
7563
7564         * MAINTAINERS (Write After Approval): Add self.
7565
7566 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7567
7568         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7569         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7570         (open_symbol_file_object): Likewise.
7571         (svr4_default_sos): Add info parameter.
7572         (svr4_read_so_list): Likewise.
7573         (svr4_current_sos_direct): Adjust functions calls to pass down
7574         info.
7575         (svr4_current_sos_1): Add info parameter.
7576         (svr4_current_sos): Call get_svr4_info, pass info down to
7577         svr4_current_sos_1.
7578         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7579         get_svr4_info.
7580         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7581         get_svr4_info.
7582         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7583         to get_svr4_info.
7584         (probes_table_remove_objfile_probes): Likewise.
7585         (register_solib_event_probe): Add info parameter.
7586         (solist_update_incremental): Pass info parameter down to
7587         svr4_read_so_list.
7588         (disable_probes_interface): Add info parameter.
7589         (svr4_handle_solib_event): Pass current_program_space to
7590         get_svr4_info.  Adjust disable_probes_interface cleanup.
7591         (svr4_create_probe_breakpoints): Add info parameter, pass it
7592         down to register_solib_event_probe.
7593         (svr4_create_solib_event_breakpoints): Add info parameter,
7594         pass it down to svr4_create_probe_breakpoints.
7595         (enable_break): Pass info down to
7596         svr4_create_solib_event_breakpoints.
7597         (svr4_solib_create_inferior_hook): Pass current_program_space to
7598         get_svr4_info.
7599         (svr4_clear_solib): Likewise.
7600
7601 2019-04-22  Pedro Alves  <palves@redhat.com>
7602
7603         * solib-svr4.c (svr4_free_objfile_observer): New.
7604         (probe_and_action::objfile): New field.
7605         (probes_table_htab_remove_objfile_probes)
7606         (probes_table_remove_objfile_probes): New functions.
7607         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7608         in the new probe_and_action.  Don't store the probe in 'lookup'.
7609         (svr4_create_probe_breakpoints): Pass objfile to
7610         register_solib_event_probe.
7611         (_initialize_svr4_solib): Register a free_objfile observer.
7612
7613 2019-04-19  Tom Tromey  <tom@tromey.com>
7614
7615         * common/queue.h: Remove.
7616
7617 2019-04-19  Tom Tromey  <tom@tromey.com>
7618
7619         * event-loop.c: Don't include "common/queue.h".
7620
7621 2019-04-19  Tom Tromey  <tom@tromey.com>
7622
7623         * remote.c (remote_target): Use delete.
7624         * remote-notif.h: Include <list>, not "common/queue.h".
7625         (notif_client_p): Remove typedef.
7626         (remote_notif_state): Add constructor, destructor, initializer.
7627         <notif_queue>: Now a std::list.
7628         (remote_notif_state_xfree): Don't declare.
7629         * remote-notif.c (remote_notif_process, handle_notification)
7630         (remote_notif_state_allocate): Update.
7631         (~remote_notif_state): Rename from remote_notif_state_xfree.
7632
7633 2019-04-19  Tom Tromey  <tom@tromey.com>
7634
7635         * symfile.c (reread_symbols): Update.
7636         * objfiles.c (objfile_register_static_link)
7637         (objfile_lookup_static_link): Update
7638         (~objfile) Don't delete static_links.
7639         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7640
7641 2019-04-19  Tom Tromey  <tom@tromey.com>
7642
7643         * type-stack.h (struct type_stack) <insert>: Constify string.
7644         * type-stack.c (type_stack::insert): Constify string.
7645         * gdbtypes.h (lookup_template_type): Update.
7646         (address_space_name_to_int): Update.
7647         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7648         const.
7649         (lookup_template_type): Make name const.
7650         * c-exp.y: Update rules.
7651         (lex_one_token, classify_name, classify_inner_name)
7652         (c_print_token): Update.
7653         * p-exp.y: Update rules.
7654         (yylex): Update.
7655         * f-exp.y: Update rules.
7656         (yylex): Update.
7657         * d-exp.y: Update rules.
7658         (lex_one_token, classify_name, classify_inner_name): Update.
7659         * parse.c (write_dollar_variable, copy_name): Return std::string.
7660         * parser-defs.h (copy_name): Change return type.
7661         * m2-exp.y: Update rules.
7662         (yylex): Update.
7663         * go-exp.y (lex_one_token): Update.
7664         Update rules.
7665         (classify_unsafe_function, classify_packaged_name)
7666         (classify_name, yylex): Update.
7667
7668 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7669
7670         * configure.ac: add --enable-source-highlight switch.
7671         * configure: Regenerate.
7672         * top.c (print_gdb_version): plumb --enable-source-highlight
7673         status to "show configuration".
7674
7675 2019-04-19  Tom Tromey  <tromey@adacore.com>
7676
7677         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7678         Check ADA_TYPE_P.
7679         (empty_record, ada_template_to_fixed_record_type_1)
7680         (template_to_static_fixed_type)
7681         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7682         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7683         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7684         macros.
7685
7686 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7687
7688         PR symtab/24423:
7689         * source.c (print_source_lines_base): Advance "iter" when a
7690         control character is seen.
7691
7692 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7693
7694         * inferior.h (struct infcall_suspend_state_deleter):
7695         Catch exception in destructor to avoid crash.
7696
7697 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7698
7699         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7700         close to the add_com "shell".
7701
7702 2019-04-18  Tom Tromey  <tromey@adacore.com>
7703
7704         * process-stratum-target.h (class process_stratum_target)
7705         <stratum>: Add "final".
7706
7707 2019-04-17  Tom Tromey  <tromey@adacore.com>
7708
7709         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7710         against nullptr before use.
7711
7712 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7713
7714         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7715
7716 2019-04-17  Jim Wilson  <jimw@sifive.com>
7717             Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7720         code read might fail, assume 4-byte breakpoint in that case.
7721
7722 2019-04-15  Leszek Swirski  <leszeks@google.com>
7723
7724         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7725         rather than a hand-rolled POD check when checking for forced MEMORY
7726         classification.
7727
7728 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7729
7730         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7731         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7732         function.
7733         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7734         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7735         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7736         declaration.
7737
7738 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7739
7740         * aarch64-linux-nat.c
7741         (aarch64_linux_nat_target::thread_architecture): Add override.
7742         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7743         each VQ.
7744
7745 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7746
7747         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7748
7749 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7752         target types of size 96-bits, add some additional comments, and
7753         check that the builtin type we found was the correct size.
7754
7755 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7756
7757         * utils.c (prompt_for_continue): Don't restore the styling at the
7758         end, as applied_style has the wrong value.  This fixes styling in
7759         long lists of file names that are interrupted by the "Continue?"
7760         prompt.
7761
7762 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7765         * c-lang.c (c_language_defn): Likewise.
7766         (cplus_language_defn): Likewise.
7767         (asm_language_defn): Likewise.
7768         (minimal_language_defn): Likewise.
7769         * d-lang.c (d_language_defn): Likewise.
7770         * f-lang.c (f_language_defn): Likewise.
7771         * go-lang.c (go_language_defn): Likewise.
7772         * language.c (unknown_language_defn): Likewise.
7773         (auto_language_defn): Likewise.
7774         * language.h (struct language_defn): Remove la_magic field.
7775         (LANG_MAGIC): Delete.
7776         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7777         * objc-lang.c (objc_language_defn): Likewise.
7778         * opencl-lang.c (opencl_language_defn): Likewise.
7779         * p-lang.c (pascal_language_defn): Likewise.
7780         * rust-lang.c (rust_language_defn): Likewise.
7781
7782 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * riscv-tdep.c (riscv_type_align): New function.
7785         (riscv_type_alignment): Delete.
7786         (riscv_arg_location): Use 'type_align'.
7787         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7788
7789 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * gdbtypes.c (type_align): A struct with no non-static fields also
7792         has alignment of 1.
7793
7794 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7797         component to 0.
7798         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7799         member.
7800         (riscv_struct_info::analyse): New implementation using new
7801         analyse_inner member function.
7802         (riscv_struct_info::field_offset): New member function.
7803         (riscv_struct_info::m_offsets): New member variable.
7804         (riscv_struct_info::analyse_inner): New private member function,
7805         takes the old implementation of riscv_struct_info::analyse but
7806         extended to track field offsets.
7807         (riscv_call_arg_struct): Update the struct folding special cases
7808         to handle cases where empty C++ structs, which are non-zero
7809         length, are found.
7810         (riscv_arg_location): Initialise the length of each location, a
7811         non-zero length now indicates the location is in use.
7812         (riscv_push_dummy_call): Allow for the first location having a
7813         non-zero offset when setting up arguments.
7814         (riscv_return_value): Likewise, but for return values.
7815
7816 2019-04-11  Tom Tromey  <tromey@adacore.com>
7817
7818         * utils.c (internal_vproblem): Make "msg" const.
7819
7820 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7821
7822         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7823         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7824         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7825         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7826
7827 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7828
7829         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7830         function.
7831         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7832         of amd64_collect_native_gregset.
7833         (amd64_linux_nat_target::store_registers): Likewise.
7834
7835 2019-04-10  Tom Tromey  <tom@tromey.com>
7836
7837         * symtab.c (lookup_global_symbol_from_objfile)
7838         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7839         * objfiles.h (class separate_debug_iterator): New.
7840         (class separate_debug_range): New.
7841         (struct objfile) <separate_debug_objfiles>: New method.
7842         (objfile_separate_debug_iterate): Don't declare.
7843         * objfiles.c (separate_debug_iterator::operator++): Rename from
7844         objfile_separate_debug_iterate.
7845         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7846         iterator.
7847         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7848         iterator.
7849
7850 2019-04-10  Tom Tromey  <tom@tromey.com>
7851
7852         * symfile.c (reread_symbols): Remove old comment.
7853         * objfiles.c (free_all_objfiles): Fix a typo.
7854
7855 2019-04-10  Tom Tromey  <tom@tromey.com>
7856
7857         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7858         * minsyms.c (lookup_minimal_symbol): Use foreach.
7859         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7860         (lookup_minimal_symbol_solib_trampoline): Likewise.
7861         * symfile.c (reread_symbols): Use foreach.
7862
7863 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7864             Tom Tromey  <tromey@adacore.com>
7865
7866         PR rust/24414:
7867         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7868         (rust_lex_int_test): Change "value" to be LONGEST.
7869         (rust_lex_tests): Add test for long integer literal.
7870
7871 2019-04-09  Tom Tromey  <tromey@adacore.com>
7872
7873         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7874         to bool.
7875         (extended_remote_target::attach): Update.
7876         (remote_target::remote_notice_new_inferior): Update.
7877         (remote_target::add_current_inferior_and_thread): Update.
7878         * inferior.c (exit_inferior_1): Use "false".
7879         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7880
7881 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7882
7883         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7884         the "start" command.
7885
7886 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7887
7888         * python/py-inferior.c (infpy_thread_from_thread_handle):
7889         Adjust comments to reflect renaming of thread_from_thread_handle
7890         to thread_from_handle.  Adjust keywords.  Fix type error message.
7891         (inferior_object_methods): Add thread_from_handle.  Retain
7892         thread_from_thread_handle, but mark it as deprecated.
7893
7894 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7895
7896         * gdbthread.h (find_thread_by_handle): Revise declaration.
7897         * thread.c (find_thread_by_handle): Likewise.  Adjust
7898         implementation too.
7899         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7900         support for buffer objects as handles.
7901
7902 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7903
7904         * python/py-infthread.c (thpy_thread_handle): New function.
7905         (thread_object_methods): Register thpy_thread_handle.
7906
7907 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7908
7909         * gdbthread.h (thread_to_thread_handle): Declare.
7910         * thread.c (gdbtypes.h): Include.
7911         (thread_to_thread_handle): New function.
7912
7913         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7914         (target_thread_info_to_thread_handle): Declare.
7915         * target.c (target_thread_info_to_thread_handle): New function.
7916         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7917         * target-delegates.c: Regenerate.
7918
7919         * linux-thread-db.c (class thread_db_target): Add method
7920         thread_info_to_thread_handle.
7921         (thread_db_target::thread_info_to_thread_handle): Define.
7922         * remote.c (class remote_target): Add new method
7923         thread_info_to_thread_handle.
7924         (remote_target::thread_info_to_thread_handle): Define.
7925
7926 2019-04-08  Pedro Alves  <palves@redhat.com>
7927
7928         * common/common-exceptions.c (throw_exception): Don't create
7929         named object to throw; throw directly.
7930         (throw_it): Likewise.  Don't initialize gdb_exception::message
7931         here, with new; pass FMT and AP to the ctor instead.
7932         * common/common-exceptions.h: Include <string>.
7933         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7934         const char *, va_list)): New ctor.  Use std::make_shared.
7935         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7936         errors)): Delete.
7937         (gdb_exception_error::gdb_exception_error(enum errors, const char
7938         *, va_list)): New.
7939         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7940         Add assertion.
7941         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7942         errors)): Delete.
7943         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7944         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7945         Add assertion.
7946
7947 2019-04-08  Tom Tromey  <tom@tromey.com>
7948
7949         * valops.c (value_rtti_indirect_type): Replace throw_exception
7950         with throw.
7951         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7952         with throw.
7953         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7954         throw.
7955         * target.c (target_translate_tls_address): Replace throw_exception
7956         with throw.
7957         * stack.c (frame_apply_command_count): Replace throw_exception
7958         with throw.
7959         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7960         throw.
7961         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7962         with throw.
7963         * rs6000-tdep.c (rs6000_frame_cache)
7964         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7965         * remote.c: Replace throw_exception with throw.
7966         * record-full.c (record_full_message, record_full_wait_1)
7967         (record_full_restore): Replace throw_exception with throw.
7968         * record-btrace.c:
7969         (get_thread_current_frame_id, record_btrace_start_replaying)
7970         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7971         (cmd_record_btrace_start): Replace throw_exception with throw.
7972         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7973         throw.
7974         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7975         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7976         * linespec.c:
7977         (find_linespec_symbols): Replace throw_exception with throw.
7978         * infrun.c (displaced_step_prepare, resume): Replace
7979         throw_exception with throw.
7980         * infcmd.c (post_create_inferior): Replace throw_exception with
7981         throw.
7982         * inf-loop.c (inferior_event_handler): Replace throw_exception
7983         with throw.
7984         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7985         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7986         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7987         (get_prev_frame_always, get_frame_pc_if_available)
7988         (get_frame_address_in_block_if_available, get_frame_language):
7989         Replace throw_exception with throw.
7990         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7991         throw_exception with throw.
7992         * eval.c (fetch_subexp_value, evaluate_var_value)
7993         (evaluate_funcall, evaluate_subexp_standard): Replace
7994         throw_exception with throw.
7995         * dwarf2loc.c (call_site_find_chain)
7996         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7997         Replace throw_exception with throw.
7998         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7999         with throw.
8000         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8001         throw.
8002         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8003         * completer.c (complete_line_internal): Replace throw_exception
8004         with throw.
8005         * compile/compile-object-run.c (compile_object_run): Replace
8006         throw_exception with throw.
8007         * cli/cli-script.c (process_next_line): Replace throw_exception
8008         with throw.
8009         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8010         (btrace_enable, btrace_maint_update_pt_packets): Replace
8011         throw_exception with throw.
8012         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8013         throw_exception with throw.
8014         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8015         throw_exception with throw.
8016         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8017         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8018         * aarch64-tdep.c (aarch64_make_prologue_cache)
8019         (aarch64_make_stub_cache): Replace throw_exception with throw.
8020
8021 2019-04-08  Tom Tromey  <tom@tromey.com>
8022
8023         * common/common-exceptions.c (throw_exception): Rename from
8024         throw_exception_cxx.  Remove old copy.  Make argument const.
8025         (throw_it): Create and throw exception objects directly.
8026         * common/common-exceptions.h (throw_exception): Make argument
8027         const.
8028         (struct gdb_exception_error): Add constructor.
8029         (struct gdb_exception_quit): Add constructor.
8030
8031 2019-04-08  Tom Tromey  <tom@tromey.com>
8032
8033         * common/common-exceptions.h (exception_rethrow): Don't declare.
8034         (TRY_SJLJ): Update comment.
8035         (TRY, CATCH, END_CATCH): Remove.
8036         * common/common-exceptions.c (exception_rethrow): Remove.
8037
8038 2019-04-08  Tom Tromey  <tom@tromey.com>
8039
8040         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8041         Remove.
8042         (gdb_exception_error): Rename from
8043         gdb_exception_RETURN_MASK_ERROR.
8044         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8045         (gdb_quit_bad_alloc): Update.
8046         * aarch64-tdep.c: Update.
8047         * ada-lang.c: Update.
8048         * ada-typeprint.c: Update.
8049         * ada-valprint.c: Update.
8050         * amd64-tdep.c: Update.
8051         * arch-utils.c: Update.
8052         * break-catch-throw.c: Update.
8053         * breakpoint.c: Update.
8054         * btrace.c: Update.
8055         * c-varobj.c: Update.
8056         * cli/cli-cmds.c: Update.
8057         * cli/cli-interp.c: Update.
8058         * cli/cli-script.c: Update.
8059         * common/common-exceptions.c: Update.
8060         * common/new-op.c: Update.
8061         * common/selftest.c: Update.
8062         * compile/compile-c-symbols.c: Update.
8063         * compile/compile-cplus-symbols.c: Update.
8064         * compile/compile-object-load.c: Update.
8065         * compile/compile-object-run.c: Update.
8066         * completer.c: Update.
8067         * corelow.c: Update.
8068         * cp-abi.c: Update.
8069         * cp-support.c: Update.
8070         * cp-valprint.c: Update.
8071         * darwin-nat.c: Update.
8072         * disasm-selftests.c: Update.
8073         * dtrace-probe.c: Update.
8074         * dwarf-index-cache.c: Update.
8075         * dwarf-index-write.c: Update.
8076         * dwarf2-frame-tailcall.c: Update.
8077         * dwarf2-frame.c: Update.
8078         * dwarf2loc.c: Update.
8079         * dwarf2read.c: Update.
8080         * eval.c: Update.
8081         * event-loop.c: Update.
8082         * event-top.c: Update.
8083         * exec.c: Update.
8084         * f-valprint.c: Update.
8085         * fbsd-tdep.c: Update.
8086         * frame-unwind.c: Update.
8087         * frame.c: Update.
8088         * gdbtypes.c: Update.
8089         * gnu-v3-abi.c: Update.
8090         * guile/guile-internal.h: Update.
8091         * guile/scm-block.c: Update.
8092         * guile/scm-breakpoint.c: Update.
8093         * guile/scm-cmd.c: Update.
8094         * guile/scm-disasm.c: Update.
8095         * guile/scm-frame.c: Update.
8096         * guile/scm-lazy-string.c: Update.
8097         * guile/scm-math.c: Update.
8098         * guile/scm-param.c: Update.
8099         * guile/scm-ports.c: Update.
8100         * guile/scm-pretty-print.c: Update.
8101         * guile/scm-symbol.c: Update.
8102         * guile/scm-symtab.c: Update.
8103         * guile/scm-type.c: Update.
8104         * guile/scm-value.c: Update.
8105         * i386-linux-tdep.c: Update.
8106         * i386-tdep.c: Update.
8107         * inf-loop.c: Update.
8108         * infcall.c: Update.
8109         * infcmd.c: Update.
8110         * infrun.c: Update.
8111         * jit.c: Update.
8112         * language.c: Update.
8113         * linespec.c: Update.
8114         * linux-fork.c: Update.
8115         * linux-nat.c: Update.
8116         * linux-tdep.c: Update.
8117         * linux-thread-db.c: Update.
8118         * main.c: Update.
8119         * mi/mi-cmd-break.c: Update.
8120         * mi/mi-cmd-stack.c: Update.
8121         * mi/mi-interp.c: Update.
8122         * mi/mi-main.c: Update.
8123         * objc-lang.c: Update.
8124         * p-valprint.c: Update.
8125         * parse.c: Update.
8126         * ppc-linux-tdep.c: Update.
8127         * printcmd.c: Update.
8128         * python/py-arch.c: Update.
8129         * python/py-breakpoint.c: Update.
8130         * python/py-cmd.c: Update.
8131         * python/py-finishbreakpoint.c: Update.
8132         * python/py-frame.c: Update.
8133         * python/py-framefilter.c: Update.
8134         * python/py-gdb-readline.c: Update.
8135         * python/py-inferior.c: Update.
8136         * python/py-infthread.c: Update.
8137         * python/py-lazy-string.c: Update.
8138         * python/py-linetable.c: Update.
8139         * python/py-objfile.c: Update.
8140         * python/py-param.c: Update.
8141         * python/py-prettyprint.c: Update.
8142         * python/py-progspace.c: Update.
8143         * python/py-record-btrace.c: Update.
8144         * python/py-record.c: Update.
8145         * python/py-symbol.c: Update.
8146         * python/py-type.c: Update.
8147         * python/py-unwind.c: Update.
8148         * python/py-utils.c: Update.
8149         * python/py-value.c: Update.
8150         * python/python.c: Update.
8151         * record-btrace.c: Update.
8152         * record-full.c: Update.
8153         * remote-fileio.c: Update.
8154         * remote.c: Update.
8155         * riscv-tdep.c: Update.
8156         * rs6000-aix-tdep.c: Update.
8157         * rs6000-tdep.c: Update.
8158         * rust-exp.y: Update.
8159         * rust-lang.c: Update.
8160         * s390-tdep.c: Update.
8161         * selftest-arch.c: Update.
8162         * solib-dsbt.c: Update.
8163         * solib-frv.c: Update.
8164         * solib-spu.c: Update.
8165         * solib-svr4.c: Update.
8166         * solib.c: Update.
8167         * sparc64-linux-tdep.c: Update.
8168         * stack.c: Update.
8169         * symfile-mem.c: Update.
8170         * symmisc.c: Update.
8171         * target.c: Update.
8172         * thread.c: Update.
8173         * top.c: Update.
8174         * tracefile-tfile.c: Update.
8175         * tui/tui.c: Update.
8176         * typeprint.c: Update.
8177         * unittests/cli-utils-selftests.c: Update.
8178         * unittests/parse-connection-spec-selftests.c: Update.
8179         * valops.c: Update.
8180         * valprint.c: Update.
8181         * value.c: Update.
8182         * varobj.c: Update.
8183         * windows-nat.c: Update.
8184         * x86-linux-nat.c: Update.
8185         * xml-support.c: Update.
8186
8187 2019-04-08  Tom Tromey  <tom@tromey.com>
8188
8189         * xml-support.c: Use C++ exception handling.
8190         * x86-linux-nat.c: Use C++ exception handling.
8191         * windows-nat.c: Use C++ exception handling.
8192         * varobj.c: Use C++ exception handling.
8193         * value.c: Use C++ exception handling.
8194         * valprint.c: Use C++ exception handling.
8195         * valops.c: Use C++ exception handling.
8196         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8197         handling.
8198         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8199         * typeprint.c: Use C++ exception handling.
8200         * tui/tui.c: Use C++ exception handling.
8201         * tracefile-tfile.c: Use C++ exception handling.
8202         * top.c: Use C++ exception handling.
8203         * thread.c: Use C++ exception handling.
8204         * target.c: Use C++ exception handling.
8205         * symmisc.c: Use C++ exception handling.
8206         * symfile-mem.c: Use C++ exception handling.
8207         * stack.c: Use C++ exception handling.
8208         * sparc64-linux-tdep.c: Use C++ exception handling.
8209         * solib.c: Use C++ exception handling.
8210         * solib-svr4.c: Use C++ exception handling.
8211         * solib-spu.c: Use C++ exception handling.
8212         * solib-frv.c: Use C++ exception handling.
8213         * solib-dsbt.c: Use C++ exception handling.
8214         * selftest-arch.c: Use C++ exception handling.
8215         * s390-tdep.c: Use C++ exception handling.
8216         * rust-lang.c: Use C++ exception handling.
8217         * rust-exp.y: Use C++ exception handling.
8218         * rs6000-tdep.c: Use C++ exception handling.
8219         * rs6000-aix-tdep.c: Use C++ exception handling.
8220         * riscv-tdep.c: Use C++ exception handling.
8221         * remote.c: Use C++ exception handling.
8222         * remote-fileio.c: Use C++ exception handling.
8223         * record-full.c: Use C++ exception handling.
8224         * record-btrace.c: Use C++ exception handling.
8225         * python/python.c: Use C++ exception handling.
8226         * python/py-value.c: Use C++ exception handling.
8227         * python/py-utils.c: Use C++ exception handling.
8228         * python/py-unwind.c: Use C++ exception handling.
8229         * python/py-type.c: Use C++ exception handling.
8230         * python/py-symbol.c: Use C++ exception handling.
8231         * python/py-record.c: Use C++ exception handling.
8232         * python/py-record-btrace.c: Use C++ exception handling.
8233         * python/py-progspace.c: Use C++ exception handling.
8234         * python/py-prettyprint.c: Use C++ exception handling.
8235         * python/py-param.c: Use C++ exception handling.
8236         * python/py-objfile.c: Use C++ exception handling.
8237         * python/py-linetable.c: Use C++ exception handling.
8238         * python/py-lazy-string.c: Use C++ exception handling.
8239         * python/py-infthread.c: Use C++ exception handling.
8240         * python/py-inferior.c: Use C++ exception handling.
8241         * python/py-gdb-readline.c: Use C++ exception handling.
8242         * python/py-framefilter.c: Use C++ exception handling.
8243         * python/py-frame.c: Use C++ exception handling.
8244         * python/py-finishbreakpoint.c: Use C++ exception handling.
8245         * python/py-cmd.c: Use C++ exception handling.
8246         * python/py-breakpoint.c: Use C++ exception handling.
8247         * python/py-arch.c: Use C++ exception handling.
8248         * printcmd.c: Use C++ exception handling.
8249         * ppc-linux-tdep.c: Use C++ exception handling.
8250         * parse.c: Use C++ exception handling.
8251         * p-valprint.c: Use C++ exception handling.
8252         * objc-lang.c: Use C++ exception handling.
8253         * mi/mi-main.c: Use C++ exception handling.
8254         * mi/mi-interp.c: Use C++ exception handling.
8255         * mi/mi-cmd-stack.c: Use C++ exception handling.
8256         * mi/mi-cmd-break.c: Use C++ exception handling.
8257         * main.c: Use C++ exception handling.
8258         * linux-thread-db.c: Use C++ exception handling.
8259         * linux-tdep.c: Use C++ exception handling.
8260         * linux-nat.c: Use C++ exception handling.
8261         * linux-fork.c: Use C++ exception handling.
8262         * linespec.c: Use C++ exception handling.
8263         * language.c: Use C++ exception handling.
8264         * jit.c: Use C++ exception handling.
8265         * infrun.c: Use C++ exception handling.
8266         * infcmd.c: Use C++ exception handling.
8267         * infcall.c: Use C++ exception handling.
8268         * inf-loop.c: Use C++ exception handling.
8269         * i386-tdep.c: Use C++ exception handling.
8270         * i386-linux-tdep.c: Use C++ exception handling.
8271         * guile/scm-value.c: Use C++ exception handling.
8272         * guile/scm-type.c: Use C++ exception handling.
8273         * guile/scm-symtab.c: Use C++ exception handling.
8274         * guile/scm-symbol.c: Use C++ exception handling.
8275         * guile/scm-pretty-print.c: Use C++ exception handling.
8276         * guile/scm-ports.c: Use C++ exception handling.
8277         * guile/scm-param.c: Use C++ exception handling.
8278         * guile/scm-math.c: Use C++ exception handling.
8279         * guile/scm-lazy-string.c: Use C++ exception handling.
8280         * guile/scm-frame.c: Use C++ exception handling.
8281         * guile/scm-disasm.c: Use C++ exception handling.
8282         * guile/scm-cmd.c: Use C++ exception handling.
8283         * guile/scm-breakpoint.c: Use C++ exception handling.
8284         * guile/scm-block.c: Use C++ exception handling.
8285         * guile/guile-internal.h: Use C++ exception handling.
8286         * gnu-v3-abi.c: Use C++ exception handling.
8287         * gdbtypes.c: Use C++ exception handling.
8288         * frame.c: Use C++ exception handling.
8289         * frame-unwind.c: Use C++ exception handling.
8290         * fbsd-tdep.c: Use C++ exception handling.
8291         * f-valprint.c: Use C++ exception handling.
8292         * exec.c: Use C++ exception handling.
8293         * event-top.c: Use C++ exception handling.
8294         * event-loop.c: Use C++ exception handling.
8295         * eval.c: Use C++ exception handling.
8296         * dwarf2read.c: Use C++ exception handling.
8297         * dwarf2loc.c: Use C++ exception handling.
8298         * dwarf2-frame.c: Use C++ exception handling.
8299         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8300         * dwarf-index-write.c: Use C++ exception handling.
8301         * dwarf-index-cache.c: Use C++ exception handling.
8302         * dtrace-probe.c: Use C++ exception handling.
8303         * disasm-selftests.c: Use C++ exception handling.
8304         * darwin-nat.c: Use C++ exception handling.
8305         * cp-valprint.c: Use C++ exception handling.
8306         * cp-support.c: Use C++ exception handling.
8307         * cp-abi.c: Use C++ exception handling.
8308         * corelow.c: Use C++ exception handling.
8309         * completer.c: Use C++ exception handling.
8310         * compile/compile-object-run.c: Use C++ exception handling.
8311         * compile/compile-object-load.c: Use C++ exception handling.
8312         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8313         * compile/compile-c-symbols.c: Use C++ exception handling.
8314         * common/selftest.c: Use C++ exception handling.
8315         * common/new-op.c: Use C++ exception handling.
8316         * cli/cli-script.c: Use C++ exception handling.
8317         * cli/cli-interp.c: Use C++ exception handling.
8318         * cli/cli-cmds.c: Use C++ exception handling.
8319         * c-varobj.c: Use C++ exception handling.
8320         * btrace.c: Use C++ exception handling.
8321         * breakpoint.c: Use C++ exception handling.
8322         * break-catch-throw.c: Use C++ exception handling.
8323         * arch-utils.c: Use C++ exception handling.
8324         * amd64-tdep.c: Use C++ exception handling.
8325         * ada-valprint.c: Use C++ exception handling.
8326         * ada-typeprint.c: Use C++ exception handling.
8327         * ada-lang.c: Use C++ exception handling.
8328         * aarch64-tdep.c: Use C++ exception handling.
8329
8330 2019-04-08  Tom Tromey  <tom@tromey.com>
8331
8332         * xml-support.c (gdb_xml_parser::parse): Update.
8333         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8334         * value.c (show_convenience): Update.
8335         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8336         (test_parse_flags_qcs): Update.
8337         * thread.c (thr_try_catch_cmd): Update.
8338         * target.c (target_translate_tls_address): Update.
8339         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8340         (info_frame_command_core, frame_apply_command_count): Update.
8341         * rust-exp.y (rust_lex_exception_test): Update.
8342         * riscv-tdep.c (riscv_print_one_register_info): Update.
8343         * remote.c (remote_target::enable_btrace): Update.
8344         * record-btrace.c (record_btrace_enable_warn): Update.
8345         * python/py-utils.c (gdbpy_convert_exception): Update.
8346         * printcmd.c (do_one_display, print_variable_and_value): Update.
8347         * mi/mi-main.c (mi_print_exception): Update.
8348         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8349         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8350         * linux-nat.c (linux_nat_target::attach): Update.
8351         * linux-fork.c (class scoped_switch_fork_info): Update.
8352         * infrun.c (displaced_step_prepare): Update.
8353         * infcall.c (call_function_by_hand_dummy): Update.
8354         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8355         * gnu-v3-abi.c (print_one_vtable): Update.
8356         * frame.c (get_prev_frame_always): Update.
8357         * f-valprint.c (info_common_command_for_block): Update.
8358         * exec.c (try_open_exec_file): Update.
8359         * exceptions.c (print_exception, exception_print)
8360         (exception_fprintf, exception_print_same): Update.
8361         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8362         * dwarf-index-cache.c (index_cache::store)
8363         (index_cache::lookup_gdb_index): Update.
8364         * darwin-nat.c (maybe_cache_shell): Update.
8365         * cp-valprint.c (cp_print_value_fields): Update.
8366         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8367         (gcc_cplus_symbol_address): Update.
8368         * compile/compile-c-symbols.c (gcc_convert_symbol)
8369         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8370         * common/selftest.c: Update.
8371         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8372         a std::string.
8373         (exception_try_scope_entry, exception_try_scope_exit): Don't
8374         declare.
8375         (struct exception_try_scope): Remove.
8376         (TRY): Don't use exception_try_scope.
8377         (struct gdb_exception): Add constructor, operator=.
8378         <what>: New method.
8379         (struct gdb_exception_RETURN_MASK_ALL)
8380         (struct gdb_exception_RETURN_MASK_ERROR)
8381         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8382         (struct gdb_quit_bad_alloc): Update.
8383         * common/common-exceptions.c (exception_none): Change
8384         initializer.
8385         (struct catcher) <state, exception>: Initialize inline.
8386         <prev>: Remove member.
8387         (current_catcher): Remove.
8388         (catchers): New global.
8389         (exceptions_state_mc_init): Simplify.
8390         (catcher_pop): Remove.
8391         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8392         (try_scope_depth, exception_try_scope_entry)
8393         (exception_try_scope_exit): Remove.
8394         (throw_exception_sjlj): Update.
8395         (exception_messages, exception_messages_size): Remove.
8396         (throw_it): Simplify.
8397         (gdb_exception_sliced_copy): Remove.
8398         (throw_exception_cxx): Update.
8399         * cli/cli-script.c (script_from_file): Update.
8400         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8401         Update.
8402         * ada-valprint.c (ada_val_print): Update.
8403         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8404         (create_excep_cond_exprs): Update.
8405
8406 2019-04-08  Tom Tromey  <tom@tromey.com>
8407
8408         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8409         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8410         (TRY, CATCH, END_CATCH): Remove some definitions.
8411         * common/common-exceptions.c: Don't use GDB_XCPT.
8412         (catcher_list_size): Remove.
8413         (throw_exception, throw_it): Simplify.
8414
8415 2019-04-05  Tom Tromey  <tom@tromey.com>
8416
8417         Revert the header-sorting patch.
8418         * ft32-tdep.c: Revert.
8419         * frv-tdep.c: Revert.
8420         * frv-linux-tdep.c: Revert.
8421         * frame.c: Revert.
8422         * frame-unwind.c: Revert.
8423         * frame-base.c: Revert.
8424         * fork-child.c: Revert.
8425         * findvar.c: Revert.
8426         * findcmd.c: Revert.
8427         * filesystem.c: Revert.
8428         * filename-seen-cache.h: Revert.
8429         * filename-seen-cache.c: Revert.
8430         * fbsd-tdep.c: Revert.
8431         * fbsd-nat.h: Revert.
8432         * fbsd-nat.c: Revert.
8433         * f-valprint.c: Revert.
8434         * f-typeprint.c: Revert.
8435         * f-lang.c: Revert.
8436         * extension.h: Revert.
8437         * extension.c: Revert.
8438         * extension-priv.h: Revert.
8439         * expprint.c: Revert.
8440         * exec.h: Revert.
8441         * exec.c: Revert.
8442         * exceptions.c: Revert.
8443         * event-top.c: Revert.
8444         * event-loop.c: Revert.
8445         * eval.c: Revert.
8446         * elfread.c: Revert.
8447         * dwarf2read.h: Revert.
8448         * dwarf2read.c: Revert.
8449         * dwarf2loc.c: Revert.
8450         * dwarf2expr.h: Revert.
8451         * dwarf2expr.c: Revert.
8452         * dwarf2-frame.c: Revert.
8453         * dwarf2-frame-tailcall.c: Revert.
8454         * dwarf-index-write.h: Revert.
8455         * dwarf-index-write.c: Revert.
8456         * dwarf-index-common.c: Revert.
8457         * dwarf-index-cache.h: Revert.
8458         * dwarf-index-cache.c: Revert.
8459         * dummy-frame.c: Revert.
8460         * dtrace-probe.c: Revert.
8461         * disasm.h: Revert.
8462         * disasm.c: Revert.
8463         * disasm-selftests.c: Revert.
8464         * dictionary.c: Revert.
8465         * dicos-tdep.c: Revert.
8466         * demangle.c: Revert.
8467         * dcache.h: Revert.
8468         * dcache.c: Revert.
8469         * darwin-nat.h: Revert.
8470         * darwin-nat.c: Revert.
8471         * darwin-nat-info.c: Revert.
8472         * d-valprint.c: Revert.
8473         * d-namespace.c: Revert.
8474         * d-lang.c: Revert.
8475         * ctf.c: Revert.
8476         * csky-tdep.c: Revert.
8477         * csky-linux-tdep.c: Revert.
8478         * cris-tdep.c: Revert.
8479         * cris-linux-tdep.c: Revert.
8480         * cp-valprint.c: Revert.
8481         * cp-support.c: Revert.
8482         * cp-namespace.c: Revert.
8483         * cp-abi.c: Revert.
8484         * corelow.c: Revert.
8485         * corefile.c: Revert.
8486         * continuations.c: Revert.
8487         * completer.h: Revert.
8488         * completer.c: Revert.
8489         * complaints.c: Revert.
8490         * coffread.c: Revert.
8491         * coff-pe-read.c: Revert.
8492         * cli-out.h: Revert.
8493         * cli-out.c: Revert.
8494         * charset.c: Revert.
8495         * c-varobj.c: Revert.
8496         * c-valprint.c: Revert.
8497         * c-typeprint.c: Revert.
8498         * c-lang.c: Revert.
8499         * buildsym.c: Revert.
8500         * buildsym-legacy.c: Revert.
8501         * build-id.h: Revert.
8502         * build-id.c: Revert.
8503         * btrace.c: Revert.
8504         * bsd-uthread.c: Revert.
8505         * breakpoint.h: Revert.
8506         * breakpoint.c: Revert.
8507         * break-catch-throw.c: Revert.
8508         * break-catch-syscall.c: Revert.
8509         * break-catch-sig.c: Revert.
8510         * blockframe.c: Revert.
8511         * block.c: Revert.
8512         * bfin-tdep.c: Revert.
8513         * bfin-linux-tdep.c: Revert.
8514         * bfd-target.c: Revert.
8515         * bcache.c: Revert.
8516         * ax-general.c: Revert.
8517         * ax-gdb.h: Revert.
8518         * ax-gdb.c: Revert.
8519         * avr-tdep.c: Revert.
8520         * auxv.c: Revert.
8521         * auto-load.c: Revert.
8522         * arm-wince-tdep.c: Revert.
8523         * arm-tdep.c: Revert.
8524         * arm-symbian-tdep.c: Revert.
8525         * arm-pikeos-tdep.c: Revert.
8526         * arm-obsd-tdep.c: Revert.
8527         * arm-nbsd-tdep.c: Revert.
8528         * arm-nbsd-nat.c: Revert.
8529         * arm-linux-tdep.c: Revert.
8530         * arm-linux-nat.c: Revert.
8531         * arm-fbsd-tdep.c: Revert.
8532         * arm-fbsd-nat.c: Revert.
8533         * arm-bsd-tdep.c: Revert.
8534         * arch-utils.c: Revert.
8535         * arc-tdep.c: Revert.
8536         * arc-newlib-tdep.c: Revert.
8537         * annotate.h: Revert.
8538         * annotate.c: Revert.
8539         * amd64-windows-tdep.c: Revert.
8540         * amd64-windows-nat.c: Revert.
8541         * amd64-tdep.c: Revert.
8542         * amd64-sol2-tdep.c: Revert.
8543         * amd64-obsd-tdep.c: Revert.
8544         * amd64-obsd-nat.c: Revert.
8545         * amd64-nbsd-tdep.c: Revert.
8546         * amd64-nbsd-nat.c: Revert.
8547         * amd64-nat.c: Revert.
8548         * amd64-linux-tdep.c: Revert.
8549         * amd64-linux-nat.c: Revert.
8550         * amd64-fbsd-tdep.c: Revert.
8551         * amd64-fbsd-nat.c: Revert.
8552         * amd64-dicos-tdep.c: Revert.
8553         * amd64-darwin-tdep.c: Revert.
8554         * amd64-bsd-nat.c: Revert.
8555         * alpha-tdep.c: Revert.
8556         * alpha-obsd-tdep.c: Revert.
8557         * alpha-nbsd-tdep.c: Revert.
8558         * alpha-mdebug-tdep.c: Revert.
8559         * alpha-linux-tdep.c: Revert.
8560         * alpha-linux-nat.c: Revert.
8561         * alpha-bsd-tdep.c: Revert.
8562         * alpha-bsd-nat.c: Revert.
8563         * aix-thread.c: Revert.
8564         * agent.c: Revert.
8565         * addrmap.c: Revert.
8566         * ada-varobj.c: Revert.
8567         * ada-valprint.c: Revert.
8568         * ada-typeprint.c: Revert.
8569         * ada-tasks.c: Revert.
8570         * ada-lang.c: Revert.
8571         * aarch64-tdep.c: Revert.
8572         * aarch64-ravenscar-thread.c: Revert.
8573         * aarch64-newlib-tdep.c: Revert.
8574         * aarch64-linux-tdep.c: Revert.
8575         * aarch64-linux-nat.c: Revert.
8576         * aarch64-fbsd-tdep.c: Revert.
8577         * aarch64-fbsd-nat.c: Revert.
8578         * aarch32-linux-nat.c: Revert.
8579
8580 2019-04-05  Tom Tromey  <tom@tromey.com>
8581
8582         * ft32-tdep.c: Sort headers.
8583         * frv-tdep.c: Sort headers.
8584         * frv-linux-tdep.c: Sort headers.
8585         * frame.c: Sort headers.
8586         * frame-unwind.c: Sort headers.
8587         * frame-base.c: Sort headers.
8588         * fork-child.c: Sort headers.
8589         * findvar.c: Sort headers.
8590         * findcmd.c: Sort headers.
8591         * filesystem.c: Sort headers.
8592         * filename-seen-cache.h: Sort headers.
8593         * filename-seen-cache.c: Sort headers.
8594         * fbsd-tdep.c: Sort headers.
8595         * fbsd-nat.h: Sort headers.
8596         * fbsd-nat.c: Sort headers.
8597         * f-valprint.c: Sort headers.
8598         * f-typeprint.c: Sort headers.
8599         * f-lang.c: Sort headers.
8600         * extension.h: Sort headers.
8601         * extension.c: Sort headers.
8602         * extension-priv.h: Sort headers.
8603         * expprint.c: Sort headers.
8604         * exec.h: Sort headers.
8605         * exec.c: Sort headers.
8606         * exceptions.c: Sort headers.
8607         * event-top.c: Sort headers.
8608         * event-loop.c: Sort headers.
8609         * eval.c: Sort headers.
8610         * elfread.c: Sort headers.
8611         * dwarf2read.h: Sort headers.
8612         * dwarf2read.c: Sort headers.
8613         * dwarf2loc.c: Sort headers.
8614         * dwarf2expr.h: Sort headers.
8615         * dwarf2expr.c: Sort headers.
8616         * dwarf2-frame.c: Sort headers.
8617         * dwarf2-frame-tailcall.c: Sort headers.
8618         * dwarf-index-write.h: Sort headers.
8619         * dwarf-index-write.c: Sort headers.
8620         * dwarf-index-common.c: Sort headers.
8621         * dwarf-index-cache.h: Sort headers.
8622         * dwarf-index-cache.c: Sort headers.
8623         * dummy-frame.c: Sort headers.
8624         * dtrace-probe.c: Sort headers.
8625         * disasm.h: Sort headers.
8626         * disasm.c: Sort headers.
8627         * disasm-selftests.c: Sort headers.
8628         * dictionary.c: Sort headers.
8629         * dicos-tdep.c: Sort headers.
8630         * demangle.c: Sort headers.
8631         * dcache.h: Sort headers.
8632         * dcache.c: Sort headers.
8633         * darwin-nat.h: Sort headers.
8634         * darwin-nat.c: Sort headers.
8635         * darwin-nat-info.c: Sort headers.
8636         * d-valprint.c: Sort headers.
8637         * d-namespace.c: Sort headers.
8638         * d-lang.c: Sort headers.
8639         * ctf.c: Sort headers.
8640         * csky-tdep.c: Sort headers.
8641         * csky-linux-tdep.c: Sort headers.
8642         * cris-tdep.c: Sort headers.
8643         * cris-linux-tdep.c: Sort headers.
8644         * cp-valprint.c: Sort headers.
8645         * cp-support.c: Sort headers.
8646         * cp-namespace.c: Sort headers.
8647         * cp-abi.c: Sort headers.
8648         * corelow.c: Sort headers.
8649         * corefile.c: Sort headers.
8650         * continuations.c: Sort headers.
8651         * completer.h: Sort headers.
8652         * completer.c: Sort headers.
8653         * complaints.c: Sort headers.
8654         * coffread.c: Sort headers.
8655         * coff-pe-read.c: Sort headers.
8656         * cli-out.h: Sort headers.
8657         * cli-out.c: Sort headers.
8658         * charset.c: Sort headers.
8659         * c-varobj.c: Sort headers.
8660         * c-valprint.c: Sort headers.
8661         * c-typeprint.c: Sort headers.
8662         * c-lang.c: Sort headers.
8663         * buildsym.c: Sort headers.
8664         * buildsym-legacy.c: Sort headers.
8665         * build-id.h: Sort headers.
8666         * build-id.c: Sort headers.
8667         * btrace.c: Sort headers.
8668         * bsd-uthread.c: Sort headers.
8669         * breakpoint.h: Sort headers.
8670         * breakpoint.c: Sort headers.
8671         * break-catch-throw.c: Sort headers.
8672         * break-catch-syscall.c: Sort headers.
8673         * break-catch-sig.c: Sort headers.
8674         * blockframe.c: Sort headers.
8675         * block.c: Sort headers.
8676         * bfin-tdep.c: Sort headers.
8677         * bfin-linux-tdep.c: Sort headers.
8678         * bfd-target.c: Sort headers.
8679         * bcache.c: Sort headers.
8680         * ax-general.c: Sort headers.
8681         * ax-gdb.h: Sort headers.
8682         * ax-gdb.c: Sort headers.
8683         * avr-tdep.c: Sort headers.
8684         * auxv.c: Sort headers.
8685         * auto-load.c: Sort headers.
8686         * arm-wince-tdep.c: Sort headers.
8687         * arm-tdep.c: Sort headers.
8688         * arm-symbian-tdep.c: Sort headers.
8689         * arm-pikeos-tdep.c: Sort headers.
8690         * arm-obsd-tdep.c: Sort headers.
8691         * arm-nbsd-tdep.c: Sort headers.
8692         * arm-nbsd-nat.c: Sort headers.
8693         * arm-linux-tdep.c: Sort headers.
8694         * arm-linux-nat.c: Sort headers.
8695         * arm-fbsd-tdep.c: Sort headers.
8696         * arm-fbsd-nat.c: Sort headers.
8697         * arm-bsd-tdep.c: Sort headers.
8698         * arch-utils.c: Sort headers.
8699         * arc-tdep.c: Sort headers.
8700         * arc-newlib-tdep.c: Sort headers.
8701         * annotate.h: Sort headers.
8702         * annotate.c: Sort headers.
8703         * amd64-windows-tdep.c: Sort headers.
8704         * amd64-windows-nat.c: Sort headers.
8705         * amd64-tdep.c: Sort headers.
8706         * amd64-sol2-tdep.c: Sort headers.
8707         * amd64-obsd-tdep.c: Sort headers.
8708         * amd64-obsd-nat.c: Sort headers.
8709         * amd64-nbsd-tdep.c: Sort headers.
8710         * amd64-nbsd-nat.c: Sort headers.
8711         * amd64-nat.c: Sort headers.
8712         * amd64-linux-tdep.c: Sort headers.
8713         * amd64-linux-nat.c: Sort headers.
8714         * amd64-fbsd-tdep.c: Sort headers.
8715         * amd64-fbsd-nat.c: Sort headers.
8716         * amd64-dicos-tdep.c: Sort headers.
8717         * amd64-darwin-tdep.c: Sort headers.
8718         * amd64-bsd-nat.c: Sort headers.
8719         * alpha-tdep.c: Sort headers.
8720         * alpha-obsd-tdep.c: Sort headers.
8721         * alpha-nbsd-tdep.c: Sort headers.
8722         * alpha-mdebug-tdep.c: Sort headers.
8723         * alpha-linux-tdep.c: Sort headers.
8724         * alpha-linux-nat.c: Sort headers.
8725         * alpha-bsd-tdep.c: Sort headers.
8726         * alpha-bsd-nat.c: Sort headers.
8727         * aix-thread.c: Sort headers.
8728         * agent.c: Sort headers.
8729         * addrmap.c: Sort headers.
8730         * ada-varobj.c: Sort headers.
8731         * ada-valprint.c: Sort headers.
8732         * ada-typeprint.c: Sort headers.
8733         * ada-tasks.c: Sort headers.
8734         * ada-lang.c: Sort headers.
8735         * aarch64-tdep.c: Sort headers.
8736         * aarch64-ravenscar-thread.c: Sort headers.
8737         * aarch64-newlib-tdep.c: Sort headers.
8738         * aarch64-linux-tdep.c: Sort headers.
8739         * aarch64-linux-nat.c: Sort headers.
8740         * aarch64-fbsd-tdep.c: Sort headers.
8741         * aarch64-fbsd-nat.c: Sort headers.
8742         * aarch32-linux-nat.c: Sort headers.
8743
8744 2019-04-04  Tom Tromey  <tom@tromey.com>
8745
8746         * varobj.c (varobj_create): Update.
8747         * rust-exp.y (struct rust_parser) <update_innermost_block,
8748         lookup_symbol>: New methods.
8749         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8750         Rename.
8751         (rust_parser::rust_lookup_type)
8752         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8753         * printcmd.c (display_command, do_one_display): Update.
8754         * parser-defs.h (struct parser_state) <parser_state>: Add
8755         "tracker" parameter.
8756         (block_tracker): New member.
8757         (class innermost_block_tracker) <innermost_block_tracker>: Add
8758         "types" parameter.
8759         <reset>: Remove method.
8760         (innermost_block): Don't declare.
8761         (null_post_parser): Update.
8762         * parse.c (innermost_block): Remove global.
8763         (write_dollar_variable): Update.
8764         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8765         Remove "tracker_types" parameter.
8766         (parse_expression): Add "tracker" parameter.
8767         (parse_expression_for_completion): Update.
8768         (null_post_parser): Add "tracker" parameter.
8769         * p-exp.y: Update rules.
8770         * m2-exp.y: Update rules.
8771         * language.h (struct language_defn) <la_post_parser>: Add
8772         "tracker" parameter.
8773         * go-exp.y: Update rules.
8774         * f-exp.y: Update rules.
8775         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8776         parameter.
8777         * d-exp.y: Update rules.
8778         * c-exp.y: Update rules.
8779         * breakpoint.c (set_breakpoint_condition): Create an
8780         innermost_block_tracker.
8781         (watch_command_1): Likewise.
8782         * ada-lang.c (resolve): Add "tracker" parameter.
8783         (resolve_subexp): Likewise.
8784         * ada-exp.y (write_var_from_sym): Update.
8785
8786 2019-04-04  Tom Tromey  <tom@tromey.com>
8787
8788         * type-stack.h: New file.
8789         * type-stack.c: New file.
8790         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8791         type-stack.h.
8792         (insert_into_type_stack, insert_type, push_type, push_type_int)
8793         (insert_type_address_space, pop_type, pop_type_int)
8794         (pop_typelist, pop_type_stack, append_type_stack)
8795         (push_type_stack, get_type_stack, push_typelist)
8796         (follow_type_instance_flags, follow_types): Don't declare.
8797         * parse.c (type_stack): Remove global.
8798         (parse_exp_in_context): Update.
8799         (insert_into_type_stack, insert_type, push_type, push_type_int)
8800         (insert_type_address_space, pop_type, pop_type_int)
8801         (pop_typelist, pop_type_stack, append_type_stack)
8802         (push_type_stack, get_type_stack, push_typelist)
8803         (follow_type_instance_flags, follow_types): Remove (moved to
8804         type-stack.c).
8805         * f-exp.y (type_stack): New global.
8806         Update rules.
8807         (push_kind_type, f_parse): Update.
8808         * d-exp.y (type_stack): New global.
8809         Update rules.
8810         (d_parse): Update.
8811         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8812         Update rules.
8813         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8814         (HFILES_NO_SRCDIR): Add type-stack.h.
8815
8816 2019-04-04  Tom Tromey  <tom@tromey.com>
8817
8818         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8819         (rust_parser::convert_ast_to_expression, rust_parse)
8820         (rust_lex_test_completion, rust_lex_tests): Update.
8821         * parser-defs.h (struct expr_completion_state): New.
8822         (struct parser_state) <parser_state>: Add completion parameter.
8823         <mark_struct_expression, mark_completion_tag>: New methods.
8824         <parse_completion, m_completion_state>: New members.
8825         (prefixify_expression, null_post_parser): Update.
8826         (mark_struct_expression, mark_completion_tag): Don't declare.
8827         * parse.c (parse_completion, expout_last_struct)
8828         (expout_tag_completion_type, expout_completion_name): Remove
8829         globals.
8830         (parser_state::mark_struct_expression)
8831         (parser_state::mark_completion_tag): Now methods.
8832         (prefixify_expression): Add last_struct parameter.
8833         (prefixify_subexp): Likewise.
8834         (parse_exp_1): Update.
8835         (parse_exp_in_context): Add cstate parameter.  Update.
8836         (parse_expression_for_completion): Create an
8837         expr_completion_state.
8838         (null_post_parser): Add "completion" parameter.
8839         * p-exp.y: Update rules.
8840         (yylex): Update.
8841         * language.h (struct language_defn) <la_post_parser>: Add
8842         "completing" parameter.
8843         * go-exp.y: Update rules.
8844         (lex_one_token): Update.
8845         * expression.h (parse_completion): Don't declare.
8846         * d-exp.y: Update rules.
8847         (lex_one_token): Update rules.
8848         * c-exp.y: Update rules.
8849         (lex_one_token): Update.
8850         * ada-lang.c (resolve): Add "parse_completion" parameter.
8851         (resolve_subexp): Likewise.
8852         (ada_resolve_function): Likewise.
8853
8854 2019-04-04  Tom Tromey  <tom@tromey.com>
8855
8856         * parser-defs.h (struct parser_state) <start_arglist,
8857         end_arglist>: New methods.
8858         <arglist_len, m_funcall_chain>: New members.
8859         (arglist_len, start_arglist, end_arglist): Don't declare.
8860         * parse.c (arglist_len, funcall_chain): Remove global.
8861         (start_arglist, end_arglist): Remove functions.
8862         (parse_exp_in_context): Update.
8863         * p-exp.y: Update rules.
8864         * m2-exp.y: Update rules.
8865         * go-exp.y: Update rules.
8866         * f-exp.y: Update rules.
8867         * d-exp.y: Update rules.
8868         * c-exp.y: Update rules.
8869
8870 2019-04-04  Tom Tromey  <tom@tromey.com>
8871
8872         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8873         lex_operator, push_back>: New methods.
8874         Update all rules.
8875         (rust_parser::lex_hex, lex_escape): Rename and update.
8876         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8877         (rust_parser::lex_operator): Rename and update.
8878         (rust_parser::lex_number, rustyylex, rustyyerror)
8879         (rust_lex_test_init, rust_lex_test_sequence)
8880         (rust_lex_test_push_back, rust_lex_tests): Update.
8881         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8882         parameter.
8883         <lexptr, prev_lexptr>: New members.
8884         (lexptr, prev_lexptr): Don't declare.
8885         * parse.c (lexptr, prev_lexptr): Remove globals.
8886         (parse_exp_in_context): Update.
8887         * p-exp.y (yylex, yyerror): Update.
8888         * m2-exp.y (parse_number, yylex, yyerror): Update.
8889         * go-exp.y (lex_one_token, yyerror): Update.
8890         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8891         * d-exp.y (lex_one_token, yyerror): Update.
8892         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8893         (lex_one_token, yyerror): Update.
8894         * ada-lex.l (YY_INPUT): Update.
8895         (rewind_to_char): Update.
8896         * ada-exp.y (yyerror): Update.
8897
8898 2019-04-04  Tom Tromey  <tom@tromey.com>
8899
8900         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8901         * parser-defs.h (struct parser_state) <parser_state>: Add new
8902         parameter.
8903         <comma_terminates>: New member.
8904         (comma_terminates): Don't declare global.
8905         * parse.c (comma_terminates): Remove global.
8906         (parse_exp_in_context): Update.
8907         * p-exp.y (yylex): Update.
8908         * m2-exp.y (yylex): Update.
8909         * go-exp.y (lex_one_token): Update.
8910         * f-exp.y (yylex): Update.
8911         * d-exp.y (lex_one_token): Update.
8912         * c-exp.y (lex_one_token): Update.
8913         * ada-lex.l: Update.
8914
8915 2019-04-04  Tom Tromey  <tom@tromey.com>
8916
8917         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8918         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8919         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8920         * parser-defs.h (paren_depth): Don't declare.
8921         * parse.c (paren_depth): Remove global.
8922         (parse_exp_in_context): Update.
8923         * p-exp.y (paren_depth): New global.
8924         (pascal_parse): Initialize it.
8925         * m2-exp.y (paren_depth): New global.
8926         (m2_parse): Initialize it.
8927         * go-exp.y (paren_depth): New global.
8928         (go_parse): Initialize it.
8929         * f-exp.y (paren_depth): New global.
8930         (f_parse): Initialize it.
8931         * d-exp.y (paren_depth): New global.
8932         (d_parse): Initialize it.
8933         * c-exp.y (paren_depth): New global.
8934         (c_parse): Initialize it.
8935         * ada-lex.l (paren_depth): New global.
8936         (lexer_init): Initialize it.
8937
8938 2019-04-04  Tom Tromey  <tom@tromey.com>
8939
8940         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8941         (rust_parser::convert_ast_to_type)
8942         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8943         * parser-defs.h (struct parser_state) <parser_state>: Add
8944         parameters.  Initialize new members.
8945         <expression_context_block, expression_context_pc>: New members.
8946         * parse.c (expression_context_block, expression_context_pc):
8947         Remove globals.
8948         (parse_exp_in_context): Update.
8949         * p-exp.y: Update all rules.
8950         (yylex): Update.
8951         * m2-exp.y: Update all rules.
8952         (yylex): Update.
8953         * go-exp.y (yylex): Update.
8954         * f-exp.y (yylex): Update.
8955         * d-exp.y: Update all rules.
8956         (yylex): Update.
8957         * c-exp.y: Update all rules.
8958         (lex_one_token, classify_name, yylex, c_parse): Update.
8959         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8960
8961 2019-04-04  Tom Tromey  <tom@tromey.com>
8962
8963         * gdbarch.h, gdbarch.c: Rebuild.
8964         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8965         * stap-probe.h:
8966         (struct stap_parse_info): Replace "parser_state" with
8967         "expr_builder".
8968         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8969         (parser_state): New class.
8970         * parse.c (expr_builder): Rename.
8971         (expr_builder::release): Rename.
8972         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8973         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8974         (write_exp_elt_longcst, write_exp_elt_floatcst)
8975         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8976         (write_exp_string_vector, write_exp_bitstring)
8977         (write_exp_msymbol, mark_struct_expression)
8978         (write_dollar_variable)
8979         (insert_type_address_space, increase_expout_size): Replace
8980         "parser_state" with "expr_builder".
8981         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8982         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8983         "parser_state" with "expr_builder".
8984
8985 2019-04-04  Tom Tromey  <tom@tromey.com>
8986
8987         * rust-exp.y: Replace "parse_language" with method call.
8988         * p-exp.y:
8989         (yylex): Replace "parse_language" with method call.
8990         * m2-exp.y:
8991         (yylex): Replace "parse_language" with method call.
8992         * go-exp.y (classify_name): Replace "parse_language" with method
8993         call.
8994         * f-exp.y (yylex): Replace "parse_language" with method call.
8995         * d-exp.y (lex_one_token): Replace "parse_language" with method
8996         call.
8997         * c-exp.y:
8998         (lex_one_token, classify_name, yylex): Replace "parse_language"
8999         with method call.
9000         * ada-exp.y (find_primitive_type, type_char)
9001         (type_system_address): Replace "parse_language" with method call.
9002
9003 2019-04-04  Tom Tromey  <tom@tromey.com>
9004
9005         * rust-exp.y: Replace "parse_gdbarch" with method call.
9006         * parse.c (write_dollar_variable, insert_type_address_space):
9007         Replace "parse_gdbarch" with method call.
9008         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9009         call.
9010         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9011         call.
9012         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9013         "parse_gdbarch" with method call.
9014         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9015         with method call.
9016         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9017         "parse_gdbarch" with method call.
9018         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9019         "parse_gdbarch" with method call.
9020         * c-exp.y (parse_type, parse_number, classify_name): Replace
9021         "parse_gdbarch" with method call.
9022         * ada-lex.l: Replace "parse_gdbarch" with method call.
9023         * ada-exp.y (parse_type, find_primitive_type, type_char)
9024         (type_system_address): Replace "parse_gdbarch" with method call.
9025
9026 2019-04-04  Tom Tromey  <tom@tromey.com>
9027
9028         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9029         * stap-probe.c (stap_parse_argument): Update.
9030         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9031         initial_size parameter.
9032         * rust-exp.y (rust_lex_tests): Update.
9033         * parse.c (parser_state): Update.
9034         (parse_exp_in_context): Update.
9035         * parser-defs.h (struct parser_state) <parser_state>: Remove
9036         "initial_size" parameter.
9037
9038 2019-04-04  Tom Tromey  <tom@tromey.com>
9039
9040         * parser-defs.h (increase_expout_size): Don't declare.
9041         * parse.c (increase_expout_size): Now static.
9042
9043 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9044
9045         * gnu-nat.c (gnu_nat_target::wait): Fix
9046         target_waitstatus_to_string call.
9047
9048 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         * eval.c (evaluate_subexp_standard): Handle internal functions
9051         during Fortran function call handling.
9052
9053 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9054
9055         * NEWS: Mention new internal functions.
9056         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9057         (read_base_type): Use dwarf2_init_complex_target_type.
9058         * value.c (creal_internal_fn): New function.
9059         (cimag_internal_fn): New function.
9060         (_initialize_values): Register new internal functions.
9061
9062 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9063
9064         * infrun.c (stop_all_threads): If debug_infrun, always
9065         trace the wait status after wait_one, using
9066         target_waitstatus_to_string and target_pid_to_str.
9067         (handle_inferior_event): Replace various trace of
9068         wait status kind by a single trace.
9069         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9070         wait status kind image by target_waitstatus_to_string.
9071         * target/waitstatus.c (target_waitstatus_to_string): Fix
9072         obsolete comment.
9073
9074 2019-04-01  Tom Tromey  <tromey@adacore.com>
9075
9076         PR symtab/23331:
9077         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9078
9079 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9080             Pedro Alves  <palves@redhat.com>
9081
9082         * top.c (quit_force): Call 'finalize_values'.
9083         * value.c (finalize_values): New function.
9084         * value.h (finalize_values): Declare.
9085
9086 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9087
9088         * NEWS: Announce $_gdb_major and $_gdb_minor.
9089
9090         * top.c (init_gdb_version_vars): New function.
9091         (gdb_init): Call init_gdb_version_vars.
9092
9093 2019-03-29  Tom Tromey  <tromey@adacore.com>
9094
9095         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9096         help text.  Remove dead code.
9097
9098 2019-03-29  Keith Seitz  <keiths@redhat.com>
9099
9100         From Siddhesh Poyarekar:
9101         * f-lang.h (f77_get_upperbound): Return LONGEST.
9102         (f77_get_lowerbound): Likewise.
9103         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9104         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9105         print them.
9106         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9107         plongest to format print it.
9108         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9109         (f77_get_upperbound): Likewise.
9110         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9111         LOWER_BOUND to LONGEST.
9112         (f77_create_arrayprint_offset_tbl): Likewise.
9113
9114 2019-03-29  Keith Seitz  <keiths@redhat.com>
9115
9116         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9117         %s/pulongest for TYPE_LENGTH instead of %d in format
9118         strings.
9119         * ada-typerint.c (ada_print_type): Likewise.
9120         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9121         * compile/compile-c-support.c (generate_register_struct): Likewise.
9122         * gdbtypes.c (recursive_dump_type): Likewise.
9123         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9124         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9125         instead of %d in format strings.
9126         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9127         to std::min to ULONGEST.
9128         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9129         instead of %d in format strings.
9130         * tracepoint.c (info_scope_command): Likewise.
9131         * typeprint.c (print_offset_data::update)
9132         (print_offset_data::finish): Likewise.
9133         * xtensa-tdep.c (xtensa_store_return_value)
9134         (xtensa_push_dummy_call): Likewise.
9135
9136 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9137
9138         * windows-nat.c (display_selector): Fixed format specifications
9139         for 64-bit Cygwin.
9140
9141 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9142
9143         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9144
9145 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9146
9147         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9148         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9149         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9150         (nios2_linux_init_abi): Install it.
9151
9152 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9153
9154         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9155
9156 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9157
9158         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9159
9160 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9161             Tom Tromey  <tromey@adacore.com>
9162
9163         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9164
9165 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9166
9167         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9168         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9169         method to compute the bounds of range types. Also print "[evaluated]"
9170         if the bounds' values come from a dynamic evaluation.
9171
9172 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9173
9174         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9175         whitespace when pretty printing is on.
9176
9177 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9178
9179         * ppc-linux-nat.c: Add include.
9180
9181 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9182
9183         * NEWS: Mention AArch64 Pointer Authentication.
9184
9185 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9186
9187         * arm-linux-nat.c: Add include.
9188
9189 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9190
9191         * source-cache.c (source_cache::get_source_lines): Re-read
9192         fullname after calling open_source_file.
9193
9194 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9195
9196         * NEWS: Mention TLS support for FreeBSD.
9197
9198 2019-03-25  Tom Tromey  <tromey@adacore.com>
9199
9200         * minsyms.c (BUNCH_SIZE): Update comment.
9201         (~minimal_symbol_reader): Remove old comment.
9202         (compact_minimal_symbols): Update comment.
9203         (minimal_symbol_reader::install): Remove old comment.  Update
9204         other comments.
9205
9206 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9207
9208         * s390-linux-nat.c: Add include.
9209
9210 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9211
9212         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9213         Call linux_get_hwcap.
9214         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9215         Likewise.
9216         (aarch64_linux_get_hwcap): Remove function.
9217         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9218         declaration.
9219         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9220         linux_get_hwcap.
9221         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9222         * linux-tdep.c (linux_get_hwcap): Add function.
9223         (linux_get_hwcap2): Likewise.
9224         * linux-tdep.h (linux_get_hwcap): Add declaration.
9225         (linux_get_hwcap2): Likewise.
9226         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9227         (ppc_linux_get_hwcap2): Likewise.
9228         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9229         linux_get_hwcap.
9230         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9231         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9232         (ppc_linux_nat_target::read_description): Likewise.
9233         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9234         * s390-linux-nat.c: Likewise.
9235         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9236
9237 2019-03-24  Tom Tromey  <tom@tromey.com>
9238
9239         * ada-lang.c (standard_lookup): Simplify initialization.
9240         (ada_lookup_symbol_nonlocal): Simplify return.
9241         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9242         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9243         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9244         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9245         initialization.
9246         * solib.c (solib_global_lookup): Simplify.
9247         * symtab.c (null_block_symbol): Remove.
9248         (symbol_cache_lookup): Simplify returns.
9249         (lookup_language_this): Simplify returns.
9250         (lookup_symbol_aux): Simplify return.
9251         (lookup_local_symbol): Simplify returns.
9252         (lookup_global_symbol_from_objfile): Simplify return.
9253         (lookup_symbol_in_objfile_symtabs)
9254         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9255         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9256         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9257         * cp-namespace.c (cp_lookup_bare_symbol)
9258         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9259         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9260         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9261         (cp_lookup_symbol_via_imports): Simplify initialization.
9262         (find_symbol_in_baseclass): Likewise.
9263         * symtab.h (null_block_symbol): Remove.
9264         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9265         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9266         (d_lookup_symbol_module): Likewise.
9267         (find_symbol_in_baseclass): Simplify initialization.
9268
9269 2019-03-24  Tom Tromey  <tom@tromey.com>
9270
9271         * expression.h: Don't include symtab.h.
9272         (struct block): Forward declare.
9273
9274 2019-03-24  Tom Tromey  <tom@tromey.com>
9275
9276         * c-exp.y (typebase): Remove casts.
9277         * gdbtypes.c (lookup_unsigned_typename, )
9278         (lookup_signed_typename): Remove cast.
9279         * eval.c (parse_to_comma_and_eval): Remove cast.
9280         * parse.c (write_dollar_variable): Remove cast.
9281         * block.h (struct block) <superblock>: Now const.
9282         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9283         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9284         (map_block): Make "block" const.
9285         * symfile.h (struct quick_symbol_functions)
9286         <map_matching_symbols>: Constify block argument to "callback".
9287         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9288         const.
9289         (find_pc_sect_compunit_symtab): Make "b" const.
9290         (find_symbol_at_address): Likewise.
9291         (search_symbols): Likewise.
9292         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9293         (dw2_debug_names_lookup_symbol): Likewise.
9294         (dw2_map_matching_symbols): Update.
9295         * p-valprint.c (pascal_val_print): Remove "block".
9296         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9297         (aux_add_nonlocal_symbols): Make "block" const.
9298         (resolve_subexp): Remove cast.
9299         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9300         const.
9301         (iterate_over_file_blocks): Likewise.
9302         * f-exp.y (%union) <bval>: Remove.
9303         * coffread.c (patch_opaque_types): Make "b" const.
9304         * spu-tdep.c (spu_catch_start): Make "block" const.
9305         * c-valprint.c (print_unpacked_pointer): Remove "block".
9306         * symmisc.c (dump_symtab_1): Make "b" const.
9307         (block_depth): Make "block" const.
9308         * d-exp.y (%union) <bval>: Remove.
9309         * cp-support.h (cp_lookup_rtti_type): Update.
9310         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9311         * psymtab.c (psym_lookup_symbol): Make "block" const.
9312         (maintenance_check_psymtabs): Make "b" const.
9313         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9314         (enumerate_locals, enumerate_args): Update.
9315         * python/py-symtab.c (stpy_global_block): Make "block" const.
9316         (stpy_static_block): Likewise.
9317         * inline-frame.c (block_starting_point_at): Make "new_block"
9318         const.
9319         * block.c (find_block_in_blockvector): Make return type const.
9320         (blockvector_for_pc_sect): Make "b" const.
9321         (find_block_in_blockvector): Make "b" const.
9322
9323 2019-03-23  Tom Tromey  <tom@tromey.com>
9324
9325         * varobj.c (varobj_create): Update.
9326         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9327         * printcmd.c (display_command, do_one_display): Don't reset
9328         innermost_block.
9329         * parser-defs.h (enum innermost_block_tracker_type): Move to
9330         expression.h.
9331         (innermost_block): Update comment.
9332         * parse.c (parse_exp_1): Add tracker_types parameter.
9333         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9334         tracker_types parameter.  Reset innermost_block.
9335         (parse_exp_in_context): Remove.
9336         (parse_expression_for_completion): Update.
9337         * objfiles.c (~objfile): Don't reset expression_context_block or
9338         innermost_block.
9339         * expression.h (enum innermost_block_tracker_type): Move from
9340         parser-defs.h.
9341         (parse_exp_1): Add tracker_types parameter.
9342         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9343         reset innermost_block.
9344
9345 2019-03-23  Tom Tromey  <tom@tromey.com>
9346
9347         * objfiles.h: Include bcache.h.
9348
9349 2019-03-23  Tom Tromey  <tom@tromey.com>
9350
9351         * linespec.c (get_current_search_block): Use
9352         scoped_restore_current_language.
9353         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9354
9355 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9356             Jiong Wang  <jiong.wang@arm.com>
9357
9358         * aarch64-linux-tdep.c
9359         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9360         section.
9361         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9362
9363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9364             Jiong Wang  <jiong.wang@arm.com>
9365
9366         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9367         instructions.
9368         (aarch64_analyze_prologue_test): Add PACIASP test.
9369         (aarch64_prologue_prev_register): Unmask PC value.
9370
9371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9372             Jiong Wang  <jiong.wang@arm.com>
9373
9374         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9375         (aarch64_dwarf2_prev_register): Unmask PC value.
9376         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9377         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9378         DW_CFA_AARCH64_negate_ra_state.
9379         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9380
9381 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9382             Jiong Wang  <jiong.wang@arm.com>
9383
9384         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9385         registers.
9386         (aarch64_pseudo_register_name): Likewise.
9387         (aarch64_pseudo_register_type): Likewise.
9388         (aarch64_pseudo_register_reggroup_p): Likewise.
9389         (aarch64_gdbarch_init): Add pauth registers.
9390         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9391         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9392         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9393         (struct gdbarch_tdep): Add regnum for ra_state.
9394
9395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9396             Jiong Wang  <jiong.wang@arm.com>
9397
9398         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9399
9400 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9401             Jiong Wang  <jiong.wang@arm.com>
9402
9403         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9404         function.
9405         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9406         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9407         (aarch64_gdbarch_init): Add puth registers.
9408         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9409         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9410         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9411
9412 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9413             Jiong Wang  <jiong.wang@arm.com>
9414
9415         * aarch64-linux-nat.c
9416         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9417         * aarch64-linux-tdep.c
9418         (aarch64_linux_core_read_description): Likewise.
9419         (aarch64_linux_get_hwcap): New function.
9420         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9421         (aarch64_linux_get_hwcap): New declaration.
9422
9423 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9424             Jiong Wang  <jiong.wang@arm.com>
9425
9426         * aarch64-linux-nat.c
9427         (aarch64_linux_nat_target::read_description): Add pauth param.
9428         * aarch64-linux-tdep.c
9429         (aarch64_linux_core_read_description): Likewise.
9430         * aarch64-tdep.c (struct target_desc): Add in pauth.
9431         (aarch64_read_description): Add pauth param.
9432         (aarch64_gdbarch_init): Likewise.
9433         * aarch64-tdep.h (aarch64_read_description): Likewise.
9434         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9435         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9436         * features/Makefile: Add new files.
9437         * features/aarch64-pauth.c: New file.
9438         * features/aarch64-pauth.xml: New file.
9439
9440 2019-03-20  Tom Tromey  <tromey@adacore.com>
9441
9442         * infrun.c (handle_inferior_event): Rename from
9443         handle_inferior_event_1.  Create a scoped_value_mark.
9444         (handle_inferior_event): Remove.
9445
9446 2019-03-19  Tom Tromey  <tromey@adacore.com>
9447
9448         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9449         * infrun.h (print_stop_event): Add "displays" parameter.
9450         * infrun.c (print_stop_event): Add "displays" parameter.
9451
9452 2019-03-19  Pedro Alves  <palves@redhat.com>
9453
9454         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9455         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9456         to -1.  Fix TABs vs spaces.
9457         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9458         * tui/tui-out.h (tui_ui_out) Add intro comments.
9459         <m_line, m_start_of_line>: In-class initialize, and add describing
9460         comment.
9461
9462 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9463
9464         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9465         variable names.
9466         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9467
9468 2019-03-18  Pedro Alves  <palves@redhat.com>
9469             Eli Zaretskii <eliz@gnu.org>
9470
9471         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9472         m_line and m_start_of_line.
9473
9474 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9475
9476         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9477         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9478         it returns a newline.  This fixes a regression in TU mode, whereby
9479         the next line is output on the same screen line as the user input.
9480
9481 2019-03-18  Tom Tromey  <tromey@adacore.com>
9482
9483         * minsyms.c (minimal_symbol_reader::install): Remove call to
9484         obstack_blank.
9485
9486 2019-03-18  Pedro Alves  <palves@redhat.com>
9487
9488         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9489         New globals.
9490         (apply_style): New, factored out from ...
9491         (apply_ansi_escape): ... this.  Handle reverse video mode.
9492         (tui_set_reverse_mode): New function.
9493         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9494         * tui/tui-winsource.c (tui_show_source_line): Use
9495         tui_set_reverse_mode instead of setting A_STANDOUT.
9496         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9497         New setter methods.
9498
9499 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9500
9501         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9502         Handle tabs.
9503
9504 2019-03-18  Tom Tromey  <tromey@adacore.com>
9505
9506         * ada-lang.c (empty_array): Add "high" parameter.
9507         (ada_evaluate_subexp): Update.
9508
9509 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9510
9511         * unittests/string_view-selftests.c: Define
9512         _initialize_string_view_selftests unconditionally.
9513
9514 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9515
9516         PR gdb/24350
9517         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9518
9519 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9520
9521         PR gdb/24351
9522         * windows-nat.c (display_selector): Fix format specifiers.
9523
9524 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9525
9526         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9527         tui_refill_source_window instead of tui_refresh_win, to update the
9528         current execution line.  This fixes redisplay of the current line
9529         when stepping through the code with "next" or "step".
9530
9531 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9532
9533         * source-cache.c (source_cache::get_source_lines): Call
9534         find_source_lines to initialize s->nlines.  This fixes vertical
9535         scrolling of TUI source window when the DOWN arrow is pressed.
9536
9537 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9538
9539         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9540         linux-thread-db.c (_initialize_thread_db): Likewise.
9541
9542 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9543
9544         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9545         wclrtoeol in tui_show_source_line".  This reverts changes made in
9546         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9547
9548 2019-03-15  Tom Tromey  <tom@tromey.com>
9549
9550         * symtab.h (struct minimal_symbol): Derive from
9551         general_symbol_info.
9552         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9553         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9554         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9555         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9556         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9557         (MSYMBOL_SEARCH_NAME): Update.
9558         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9559         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9560         * minsyms.c (minimal_symbol_reader::record_full): Update.
9561
9562 2019-03-15  Tom Tromey  <tom@tromey.com>
9563
9564         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9565
9566 2019-03-15  Tom Tromey  <tom@tromey.com>
9567
9568         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9569         unique_xmalloc_ptr.
9570         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9571         Update.
9572         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9573         (build_minimal_symbol_hash_tables)
9574         (minimal_symbol_reader::install): Update.
9575
9576 2019-03-15  Tom Tromey  <tom@tromey.com>
9577
9578         * symtab.c (create_demangled_names_hash): Update.
9579         (symbol_set_names): Update.
9580         * objfiles.h (struct objfile_per_bfd_storage)
9581         <demangled_names_hash>: Now an htab_up.
9582         * objfiles.c (objfile_per_bfd_storage): Simplify.
9583
9584 2019-03-15  Tom Tromey  <tom@tromey.com>
9585
9586         * objfiles.h (struct objfile_per_bfd_storage): Declare
9587         destructor.
9588         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9589         New.
9590         (get_objfile_bfd_data): Use new.  Don't initialize
9591         language_of_main.
9592         (free_objfile_per_bfd_storage): Remove.
9593         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9594
9595 2019-03-15  Tom Tromey  <tom@tromey.com>
9596
9597         * symfile.c (reread_symbols): Update.
9598         * objfiles.c (objfile::objfile): Update.
9599         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9600         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9601         comment.
9602         (minimal_symbol_reader::install): Update.
9603         (terminate_minimal_symbol_table): Remove.
9604         * jit.c (jit_object_close_impl): Update.
9605
9606 2019-03-15  Tom Tromey  <tom@tromey.com>
9607
9608         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9609         initializations.
9610
9611 2019-03-15  Tom Tromey  <tom@tromey.com>
9612
9613         * objfiles.h (struct objfile_per_bfd_storage)
9614         <demangled_hash_languages>: Now a bitset.
9615         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9616         (lookup_minimal_symbol): Update.
9617
9618 2019-03-15  Tom Tromey  <tom@tromey.com>
9619
9620         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9621         Don't return the symbol.
9622         * coffread.c (record_minimal_symbol): Use record_full.
9623
9624 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9625
9626         The MS-Windows port of ncurses fails to switch to a color pair if
9627         one or both of the colors are the implicit default colors.  This
9628         change records the default colors when TUI is initialized, and
9629         then specifies them explicitly when a color pair uses the default
9630         colors.  This allows color styling in TUI mode on MS-Windows.
9631
9632         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9633         ncurses_norm_attr.
9634         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9635         colors in ncurses_norm_attr.
9636         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9637         "none", replace it with the default color recorded in
9638         ncurses_norm_attr.
9639
9640 2019-03-14  Tom Tromey  <tromey@adacore.com>
9641
9642         * source-cache.h (class source_cache) <get_source_lines>: Return
9643         std::string.
9644         * source-cache.c (source_cache::extract_lines): Handle case where
9645         first_pos==npos.  Return std::string.
9646         (source_cache::get_source_lines): Update.
9647
9648 2019-03-14  Tom Tromey  <tromey@adacore.com>
9649
9650         * NEWS: Add item for "style sources" commands.
9651         * source-cache.c (source_cache::get_source_lines): Check
9652         source_styling.
9653         * cli/cli-style.c (source_styling): New global.
9654         (_initialize_cli_style): Add "style sources" commands.
9655         (show_style_sources): New function.
9656         * cli/cli-style.h (source_styling): Declare.
9657
9658 2019-03-14  Pedro Alves  <palves@redhat.com>
9659             Tom Tromey  <tromey@adacore.com>
9660
9661         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9662         * tui/tui-winsource.c (tui_refill_source_window): New function,
9663         from...
9664         (tui_horizontal_source_scroll): ... here.  Move some logic.
9665         * cli/cli-style.c (set_style_enabled): Notify new observable.
9666         * tui/tui-hooks.c (tui_redisplay_source): New function.
9667         (tui_attach_detach_observers): Attach or detach
9668         tui_redisplay_source.
9669         * observable.h (source_styling_changed): New observable.
9670         * observable.c: Define source_styling_changed observable.
9671
9672 2019-03-13  Tom Tromey  <tromey@adacore.com>
9673
9674         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9675         (i386_gnu_nat_target::store_registers): Update.
9676         * target-debug.h (target_debug_print_std_string): New macro.
9677         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9678         * windows-tdep.c (display_one_tib): Update.
9679         * tui/tui-stack.c (tui_make_status_line): Update.
9680         * top.c (print_inferior_quit_action): Update.
9681         * thread.c (thr_try_catch_cmd): Update.
9682         (add_thread_with_info): Update.
9683         (thread_target_id_str): Update.
9684         (thr_try_catch_cmd): Update.
9685         (thread_command): Update.
9686         (thread_find_command): Update.
9687         * record-btrace.c (record_btrace_target::info_record)
9688         (record_btrace_resume_thread, record_btrace_target::resume)
9689         (record_btrace_cancel_resume, record_btrace_step_thread)
9690         (record_btrace_target::wait, record_btrace_target::wait)
9691         (record_btrace_target::wait, record_btrace_target::stop): Update.
9692         * progspace.c (print_program_space): Update.
9693         * process-stratum-target.c
9694         (process_stratum_target::thread_address_space): Update.
9695         * linux-fork.c (linux_fork_mourn_inferior)
9696         (detach_checkpoint_command, info_checkpoints_command)
9697         (linux_fork_context): Update.
9698         (linux_fork_detach): Update.
9699         (class scoped_switch_fork_info): Update.
9700         (delete_checkpoint_command): Update.
9701         * infrun.c (follow_fork_inferior): Update.
9702         (follow_fork_inferior): Update.
9703         (proceed_after_vfork_done): Update.
9704         (handle_vfork_child_exec_or_exit): Update.
9705         (follow_exec): Update.
9706         (displaced_step_prepare_throw): Update.
9707         (displaced_step_restore): Update.
9708         (start_step_over): Update.
9709         (resume_1): Update.
9710         (clear_proceed_status_thread): Update.
9711         (proceed): Update.
9712         (print_target_wait_results): Update.
9713         (do_target_wait): Update.
9714         (context_switch): Update.
9715         (stop_all_threads): Update.
9716         (restart_threads): Update.
9717         (finish_step_over): Update.
9718         (handle_signal_stop): Update.
9719         (switch_back_to_stepped_thread): Update.
9720         (keep_going_pass_signal): Update.
9721         (print_exited_reason): Update.
9722         (normal_stop): Update.
9723         * inferior.c (inferior_pid_to_str): Change return type.
9724         (print_selected_inferior): Update.
9725         (add_inferior): Update.
9726         (detach_inferior): Update.
9727         * dummy-frame.c (fprint_dummy_frames): Update.
9728         * dcache.c (dcache_info_1): Update.
9729         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9730         (btrace_fetch, btrace_clear): Update.
9731         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9732         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9733         type.
9734         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9735         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9736         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9737         * gdbarch.c, gdbarch.h: Rebuild.
9738         * gdbarch.sh (core_pid_to_str): Change return type.
9739         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9740         return type.
9741         (windows_nat_target::pid_to_str): Change return type.
9742         (windows_delete_thread): Update.
9743         (windows_nat_target::attach): Update.
9744         (windows_nat_target::files_info): Update.
9745         * target-delegates.c: Rebuild.
9746         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9747         return type.
9748         (sol_thread_target::pid_to_str): Change return type.
9749         * remote.c (class remote_target) <pid_to_str>: Change return
9750         type.
9751         (remote_target::pid_to_str): Change return type.
9752         (extended_remote_target::attach, remote_target::remote_stop_ns)
9753         (remote_target::remote_notif_remove_queued_reply)
9754         (remote_target::push_stop_reply, remote_target::disable_btrace):
9755         Update.
9756         (extended_remote_target::attach): Update.
9757         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9758         type.
9759         (gdbsim_target::pid_to_str): Change return type.
9760         * ravenscar-thread.c (struct ravenscar_thread_target)
9761         <pid_to_str>: Change return type.
9762         (ravenscar_thread_target::pid_to_str): Change return type.
9763         * procfs.c (class procfs_target) <pid_to_str>: Change return
9764         type.
9765         (procfs_target::pid_to_str): Change return type.
9766         (procfs_target::attach): Update.
9767         (procfs_target::detach): Update.
9768         (procfs_target::fetch_registers): Update.
9769         (procfs_target::store_registers): Update.
9770         (procfs_target::wait): Update.
9771         (procfs_target::files_info): Update.
9772         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9773         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9774         return type.
9775         (nto_procfs_target::pid_to_str): Change return type.
9776         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9777         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9778         return type.
9779         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9780         (exit_lwp): Update.
9781         (attach_proc_task_lwp_callback, get_detach_signal)
9782         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9783         (linux_nat_target::resume, wait_lwp, stop_callback)
9784         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9785         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9786         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9787         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9788         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9789         type.
9790         (inf_ptrace_target::attach): Update.
9791         (inf_ptrace_target::files_info): Update.
9792         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9793         type.
9794         (go32_nat_target::pid_to_str): Change return type.
9795         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9796         (gnu_nat_target::wait): Update.
9797         (gnu_nat_target::wait): Update.
9798         (gnu_nat_target::resume): Update.
9799         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9800         (fbsd_nat_target::wait): Update.
9801         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9802         type.
9803         (darwin_nat_target::attach): Update.
9804         * corelow.c (class core_target) <pid_to_str>: Change return type.
9805         (core_target::pid_to_str): Change return type.
9806         * target.c (normal_pid_to_str): Change return type.
9807         (default_pid_to_str): Likewise.
9808         (target_pid_to_str): Change return type.
9809         (target_translate_tls_address): Update.
9810         (target_announce_detach): Update.
9811         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9812         return type.
9813         (bsd_uthread_target::pid_to_str): Change return type.
9814         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9815         type.
9816         (bsd_kvm_target::pid_to_str): Change return type.
9817         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9818         return type.
9819         (aix_thread_target::pid_to_str): Change return type.
9820         * target.h (struct target_ops) <pid_to_str>: Change return type.
9821         (target_pid_to_str, normal_pid_to_str): Likewise.
9822         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9823         type.
9824         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9825         type.
9826         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9827         return type.
9828         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9829         type.
9830         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9831         type.
9832         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9833         return type.
9834
9835 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9836
9837         * NEWS: Mention that the new default MI version is 3.  Mention
9838         changes to the output of commands and events that deal with
9839         multi-location breakpoints.
9840         * breakpoint.c: Include "mi/mi-out.h".
9841         (print_one_breakpoint): Change output syntax if using MI version
9842         >= 3.
9843         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9844         New.
9845         (mi_multi_location_breakpoint_output_fixed): New.
9846         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9847         (mi_cmd_fix_multi_location_breakpoint_output): New.
9848         (mi_multi_location_breakpoint_output_fixed): New.
9849         * mi/mi-cmds.c (mi_cmds): Register command
9850         -fix-multi-location-breakpoint-output.
9851         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9852         interpreter "mi".
9853
9854 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9855
9856         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9857         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9858         instantiate mi_ui_out based on interpreter name.
9859         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9860         * mi/mi-main.c (mi_load_progress): Likewise.
9861
9862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9863
9864         * NEWS: Combine separate "New targets" sections for 8.3.
9865
9866 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9867
9868         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9869         (ppcfbsd_init_abi): Install gdbarch
9870         "fetch_tls_load_module_address" and "get_thread_local_address"
9871         methods.
9872
9873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9874
9875         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9876         (riscv_fbsd_init_abi): Install gdbarch
9877         "fetch_tls_load_module_address" and "get_thread_local_address"
9878         methods.
9879
9880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9881
9882         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9883         (i386fbsd_init_abi): Install gdbarch
9884         "fetch_tls_load_module_address" and "get_thread_local_address"
9885         methods.
9886
9887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9888
9889         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9890         (amd64fbsd_init_abi): Install gdbarch
9891         "fetch_tls_load_module_address" and "get_thread_local_address"
9892         methods.
9893
9894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9895
9896         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9897         (struct fbsd_pspace_data): New type.
9898         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9899         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9900         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9901         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9902         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9903
9904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9905
9906         * gdbtypes.c (lookup_struct_elt): New function.
9907         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9908         * gdbtypes.h (struct struct_elt): New type.
9909         (lookup_struct_elt): New prototype.
9910
9911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9912
9913         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9914         remove disabled code block.
9915
9916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9917
9918         * gdbarch.sh (get_thread_local_address): New method.
9919         * gdbarch.h, gdbarch.c: Regenerate.
9920         * target.c (target_translate_tls_address): Use
9921         gdbarch_get_thread_local_address if present instead of
9922         target::get_thread_local_address.
9923
9924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9925
9926         * target.h (target::get_thread_local_address): Update comment.
9927
9928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9929
9930         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9931         objfile->separate_debug_objfile_backlink if not NULL.
9932
9933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9934
9935         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9936         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9937         (amd64bsd_store_inferior_registers): Likewise.
9938         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9939         Enable segment base registers.
9940         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9941         PT_GETFSBASE and PT_GETGSBASE.
9942         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9943         PT_SETGSBASE.
9944         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9945         segment base registers.
9946         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9947
9948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9949
9950         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9951         Update calls to i386_target_description to add 'segments'
9952         parameter.
9953         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9954         add segment base registers.
9955         * arch/i386.c (i386_create_target_description): Add 'segments'
9956         parameter to enable segment base registers.
9957         * arch/i386.h (i386_create_target_description): Likewise.
9958         * features/i386/32bit-segments.xml: New file.
9959         * features/i386/32bit-segments.c: Generate.
9960         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9961         call to i386_target_description to add 'segments' parameter.
9962         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9963         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9964         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9965         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9966         if feature is present.
9967         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9968         Add 'segments' parameter to call to i386_target_description.
9969         (i386_target_description): Add 'segments' parameter to enable
9970         segment base registers.
9971         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9972         to call to i386_target_description.
9973         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9974         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9975         Define I386_NUM_REGS.
9976         (i386_target_description): Add 'segments' parameter to enable
9977         segment base registers.
9978
9979 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9980
9981         PR/24325
9982         * source-cache.c: #undef open and close, to avoid unresolved
9983         externals during linking.
9984
9985 2019-03-12  Tom Tromey  <tromey@adacore.com>
9986
9987         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9988         const.  Add initializers.
9989         (_initialize_remote): Don't initialize ptid globals.
9990
9991 2019-03-12  Pedro Alves  <palves@redhat.com>
9992
9993         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9994
9995 2019-03-12  Pedro Alves  <palves@redhat.com>
9996
9997         * cp-name-parser.y (main): Remove unused 'len' variable.
9998
9999 2019-03-12  Tom Tromey  <tromey@adacore.com>
10000
10001         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10002         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10003
10004 2019-03-12  Tom Tromey  <tromey@adacore.com>
10005
10006         * linux-nat.c (iterate_over_lwps): Update.
10007         (stop_callback): Remove parameter.
10008         (stop_wait_callback, detach_callback, resume_set_callback)
10009         (select_singlestep_lwp_callback, set_ignore_sigint)
10010         (status_callback, resumed_callback, resume_clear_callback)
10011         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10012         data parameter.
10013         (linux_nat_target::detach, linux_nat_target::resume)
10014         (linux_stop_and_wait_all_lwps, select_event_lwp)
10015         (linux_nat_filter_event, linux_nat_wait_1)
10016         (linux_nat_target::kill, linux_nat_target::stop)
10017         (linux_nat_target::stop): Update.
10018         (linux_nat_resume_callback): Change type.
10019         (resume_stopped_resumed_lwps, count_events_callback)
10020         (select_event_lwp_callback): Likewise.
10021         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10022         * arm-linux-nat.c (struct update_registers_data): Remove.
10023         (update_registers_callback): Change type.
10024         (arm_linux_insert_hw_breakpoint1): Update.
10025         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10026         parameter.
10027         (x86_linux_dr_set_addr): Update.
10028         (x86_linux_dr_set_control): Update.
10029         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10030         (iterate_over_lwps): Use gdb::function_view.
10031         * nat/aarch64-linux-hw-point.c (struct
10032         aarch64_dr_update_callback_param): Remove.
10033         (debug_reg_change_callback): Change type.
10034         (aarch64_notify_debug_reg_change): Update.
10035         * s390-linux-nat.c (s390_refresh_per_info): Update.
10036
10037 2019-03-11  Tom Tromey  <tromey@adacore.com>
10038
10039         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10040         redundant assignment to "this_cu".
10041
10042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10043
10044         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10045
10046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10047
10048         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10049         from...
10050         (rank_one_type): ... this.
10051
10052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10053
10054         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10055         from...
10056         (rank_one_type): ... this.
10057
10058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10059
10060         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10061         from...
10062         (rank_one_type): ... this.
10063
10064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10065
10066         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10067         from...
10068         (rank_one_type): ... this.
10069
10070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10071
10072         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10073         from...
10074         (rank_one_type): ... this.
10075
10076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10077
10078         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10079         from...
10080         (rank_one_type): ... this.
10081
10082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10083
10084         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10085         from...
10086         (rank_one_type): ... this.
10087
10088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10089
10090         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10091         from...
10092         (rank_one_type): ... this.
10093
10094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10095
10096         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10097         from...
10098         (rank_one_type): ... this.
10099
10100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10101
10102         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10103         from...
10104         (rank_one_type): ... this.
10105
10106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10107
10108         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10109         from...
10110         (rank_one_type): ... this.
10111
10112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10113
10114         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10115         from...
10116         (rank_one_type): ... this.
10117
10118 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10119
10120         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10121         inferior-events' shows the example events.
10122
10123 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10124
10125         Support styling on native MS-Windows console
10126
10127         PR/24315
10128         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10129         on MS-Windows if $TERM is not defined.
10130
10131         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10132
10133         * posix-hdep.c (gdb_console_fputs):
10134         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10135         functions.
10136         * ui-file.h (gdb_console_fputs): Add prototype.
10137
10138         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10139         back to fputs only if the former returns zero.
10140
10141 2019-03-07  Tom Tromey  <tom@tromey.com>
10142
10143         * symmisc.c (print_symbol_bcache_statistics): Update.
10144         (print_objfile_statistics): Update.
10145         * symfile.c (allocate_symtab): Update.
10146         * stabsread.c: Don't include bcache.h.
10147         * psymtab.h (struct psymbol_bcache): Don't declare.
10148         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10149         (psymbol_bcache_init, psymbol_bcache_free)
10150         (psymbol_bcache_get_bcache): Don't declare.
10151         * psymtab.c (struct psymbol_bcache): Remove.
10152         (psymtab_storage::psymtab_storage): Update.
10153         (psymtab_storage::~psymtab_storage): Update.
10154         (psymbol_bcache_init, psymbol_bcache_free)
10155         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10156         (add_psymbol_to_bcache): Update.
10157         (allocate_psymtab): Update.
10158         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10159         macro_cache>: No longer pointers.
10160         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10161         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10162         * macrotab.c (macro_bcache): Update.
10163         * macroexp.c: Don't include bcache.h.
10164         * gdbtypes.c (check_types_worklist): Update.
10165         (types_deeply_equal): Remove TRY/CATCH.  Update.
10166         * elfread.c (elf_symtab_read): Update.
10167         * dwarf2read.c: Don't include bcache.h.
10168         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10169         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10170         (print_bcache_statistics, bcache_memory_used): Don't declare.
10171         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10172         methods.  Rename all data members.
10173         * bcache.c (struct bcache): Move to bcache.h.
10174         (bcache::expand_hash_table): Rename from expand_hash_table.
10175         (bcache): Remove.
10176         (bcache::insert): Rename from bcache_full.
10177         (bcache::compare): Rename from bcache_compare.
10178         (bcache_xmalloc): Remove.
10179         (bcache::~bcache): Rename from bcache_xfree.
10180         (bcache::print_statistics): Rename from print_bcache_statistics.
10181         (bcache::memory_used): Rename from bcache_memory_used.
10182
10183 2019-03-07  Pedro Alves  <palves@redhat.com>
10184
10185         * infrun.c (normal_stop): Also check for
10186         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10187
10188 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10189
10190         * f-lang.c (value_from_host_double): Moved to...
10191         * value.c (value_from_host_double): ...here.
10192         * value.h (value_from_host_double): Declare.
10193         * guile/scm-math.c (vlscm_convert_typed_number): Use
10194         value_from_host_double.
10195         (vlscm_convert_number): Likewise.
10196         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10197         * python/py-value.c (convert_value_from_python): Likewise.
10198
10199 2019-03-06  Tom Tromey  <tom@tromey.com>
10200
10201         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10202
10203 2019-03-06  Tom Tromey  <tom@tromey.com>
10204
10205         * utils.h (free_current_contents): Don't declare.
10206         * utils.c (free_current_contents): Remove.
10207
10208 2019-03-06  Tom Tromey  <tom@tromey.com>
10209
10210         * top.c (quit_force): Update.
10211         * main.c (captured_command_loop): Update.
10212         * common/new-op.c (operator new): Update.
10213         * common/common-exceptions.c (struct catcher)
10214         <save_cleanup_chain>: Remove member.
10215         (exceptions_state_mc_init): Update.
10216         (exception_try_scope_entry): Return nullptr.
10217         (exception_try_scope_exit, exception_rethrow)
10218         (throw_exception_sjlj, throw_exception_cxx): Update.
10219         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10220         (all_cleanups, do_cleanups, discard_cleanups)
10221         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10222         (restore_cleanups, restore_final_cleanups): Don't declare.
10223         (do_final_cleanups): Remove parameter.
10224         * common/cleanups.c (cleanup_chain, make_cleanup)
10225         (make_cleanup_dtor, all_cleanups, do_cleanups)
10226         (discard_my_cleanups, discard_cleanups)
10227         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10228         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10229         (null_cleanup): Remove.
10230         (do_final_cleanups): Remove parameter.
10231
10232 2019-03-06  Tom Tromey  <tom@tromey.com>
10233
10234         * remote.c (remote_target::remote_parse_stop_reply): Use
10235         unique_xmalloc_ptr.
10236
10237 2019-03-06  Tom Tromey  <tom@tromey.com>
10238
10239         * stabsread.c (struct stabs_field_info): Rename from field_info.
10240         <list, fnlist>: Add initializers.
10241         <obstack>: New member.
10242         (read_member_functions, read_struct_fields, read_baseclasses):
10243         Allocate on obstack.  Don't use cleanups.
10244         (read_one_struct_field, read_member_functions, read_struct_fields)
10245         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10246         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10247         (read_struct_type): Update.
10248
10249 2019-03-06  Tom Tromey  <tom@tromey.com>
10250
10251         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10252         * common/filestuff.h (make_cleanup_close): Don't declare.
10253         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10254         Remove.
10255
10256 2019-03-06  Tom Tromey  <tom@tromey.com>
10257
10258         * solib-aix.c: Use make_scope_exit.
10259
10260 2019-03-06  Tom Tromey  <tom@tromey.com>
10261
10262         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10263         Use make_scope_exit.
10264
10265 2019-03-06  Tom Tromey  <tom@tromey.com>
10266
10267         * solib-svr4.c (disable_probes_interface): Remove parameter.
10268         (svr4_handle_solib_event): Use make_scope_exit.
10269
10270 2019-03-06  Tom Tromey  <tom@tromey.com>
10271
10272         * remote.c (struct stop_reply_deleter): Remove.
10273         (stop_reply_up): Update.
10274         (struct stop_reply): Derive from notif_event.  Don't typedef.
10275         <regcache>: Now a std::vector.
10276         (stop_reply_xfree): Remove.
10277         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10278         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10279         (remote_target::discard_pending_stop_replies): Use delete.
10280         (remote_target::remote_parse_stop_reply): Update.
10281         (remote_target::process_stop_reply): Update.
10282         * remote-notif.h (struct notif_event): Add virtual destructor.
10283         Remove "dtr" member.
10284         (struct notif_client) <alloc_event>: Return a unique_ptr.
10285         (notif_event_xfree): Don't declare.
10286         (notif_event_up): New typedef.
10287         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10288         (notif_event_xfree, do_notif_event_xfree): Remove.
10289         (remote_notif_state_xfree): Update.
10290
10291 2019-03-06  Tom Tromey  <tom@tromey.com>
10292
10293         * infrun.c (displaced_step_clear_cleanup): Now a
10294         forward_scope_exit type.
10295         (displaced_step_prepare_throw): Update.
10296         (displaced_step_fixup): Update.
10297
10298 2019-03-06  Tom Tromey  <tom@tromey.com>
10299
10300         * inferior.h (class inferior): Update comment.
10301         * gdbthread.h (class thread_info): Update comment.
10302
10303 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10304             Tom Tromey  <tom@tromey.com>
10305
10306         * stabsread.h (struct stab_section_list): Remove.
10307         (coffstab_build_psymtabs): Update.
10308         * dbxread.c (symbuf_sections): Now a std::vector.
10309         (sect_idx): New global.
10310         (fill_symbuf): Update.
10311         (coffstab_build_psymtabs): Change type of stabsects parameter.
10312         Update.
10313         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10314         std::vector.
10315         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10316         (coff_locate_sections): Update.
10317         (coff_symfile_read): Remove cleanups.  Update.
10318         (init_stringtab): Add storage parameter.
10319         (free_stringtab, free_stringtab_cleanup): Remove.
10320         (init_lineno): Add storage parameter.
10321         (free_linetab, free_linetab_cleanup): Remove.
10322
10323 2019-03-06  Pedro Alves  <palves@redhat.com>
10324
10325         * linux-fork.c (fork_info::clobber_regs): Delete.
10326         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10327         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10328         comment.  Adjust.
10329         (scoped_switch_fork_info::scoped_switch_fork_info)
10330         (checkpoint_command, linux_fork_context): Adjust
10331         fork_save_infrun_state calls.
10332
10333 2019-03-06  Pedro Alves  <palves@redhat.com>
10334
10335         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10336         (inf_has_multiple_threads): Return 'bool' and rewrite using
10337         inferior_info::threads().
10338
10339 2019-03-06  Pedro Alves  <palves@redhat.com>
10340
10341         * linux-fork.c: Include <list>.
10342         (fork_list): Now a std::list instance.
10343         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10344         (forks_exist_p, find_last_fork): Adjust.
10345         (new_fork): Delete.
10346         (one_fork_p): New.
10347         (add_fork): Adjust.
10348         (free_fork): Delete, folded into fork_info::~fork_info().
10349         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10350         Adjust.
10351         (init_fork_list): Delete.
10352         (linux_fork_killall, linux_fork_mourn_inferior)
10353         (linux_fork_detach, info_checkpoints_command): Adjust.
10354         (_initialize_linux_fork): No longer call init_fork_list.
10355
10356 2019-03-06  Pedro Alves  <palves@redhat.com>
10357
10358         * linux-fork.c (new_fork): New, split out of ...
10359         (add_fork): ... this.  Return void.  Move "first fork" special
10360         case from here, to ...
10361         (checkpoint_command): ... here.
10362         * linux-linux.h (add_fork): Return void.
10363
10364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10365
10366         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10367
10368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10369             Chris January  <chris.january@arm.com>
10370             David Lecomber  <david.lecomber@arm.com>
10371
10372         * f-exp.y: New token, UNOP_INTRINSIC.
10373         (exp): New pattern using UNOP_INTRINSIC token.
10374         (f77_keywords): Add 'abs' keyword.
10375         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10376         (value_from_host_double): New function.
10377         (evaluate_subexp_f): Support UNOP_ABS.
10378
10379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10380
10381         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10382         types.
10383
10384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10385
10386         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10387         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10388         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10389
10390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10391
10392         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10393
10394 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10395             Chris January  <chris.january@arm.com>
10396
10397         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10398         * f-exp.y: Define 'KIND' token.
10399         (exp): New pattern for KIND expressions.
10400         (ptype): Handle types with a kind extension.
10401         (direct_abs_decl): Extend to spot kind extensions.
10402         (f77_keywords): Add 'kind' to the list.
10403         (push_kind_type): New function.
10404         (convert_to_kind_type): New function.
10405         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10406         * parse.c (operator_length_standard): Likewise.
10407         * parser-defs.h (enum type_pieces): Add tp_kind.
10408         * std-operator.def: Add UNOP_KIND.
10409
10410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10411
10412         * f-exp.y (f_parse): Set yydebug.
10413
10414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10415
10416         * f-lang.c (evaluate_subexp_f): New function.
10417         (exp_descriptor_f): New global.
10418         (f_language_defn): Use exp_descriptor_f instead of
10419         exp_descriptor_standard.
10420
10421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10422
10423         * f-exp.y (struct token): Add comments.
10424         (dot_ops): Remove uppercase versions and the end marker.
10425         (f77_keywords): Likewise.
10426         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10427         entries in the dot_ops array are case insensitive, and use
10428         strncasecmp to compare strings.  Also some whitespace cleanup in
10429         this area.  Similar for the f77_keywords array, except entries in
10430         this list might be case sensitive.
10431
10432 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10433
10434         * f-exp.y (struct f77_boolean_val): Add comments.
10435         (boolean_values): Remove uppercase versions, and end marker.
10436         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10437         and use strncasecmp to achieve case insensitivity.  Additionally,
10438         perform whitespace cleanup around this code.
10439
10440 2019-03-06  Tom Tromey  <tromey@adacore.com>
10441
10442         * remote-sim.c (gdbsim_target_open): Use result of
10443         gdb_argv::release.
10444
10445 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10446         Dirk Schubert  <dirk.schubert@arm.com>
10447         Chris January  <chris.january@arm.com>
10448
10449         * eval.c (evaluate_subexp_standard): Call Fortran argument
10450         wrapping logic.
10451         * f-lang.c (struct value): A value which can be passed into a
10452         Fortran function call.
10453         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10454         where appropriate.
10455         (struct type): Value ready for a Fortran function call.
10456         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10457         is needed.
10458         * f-lang.h (fortran_argument_convert): Declaration.
10459         (fortran_preserve_arg_pointer): Declaration.
10460         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10461
10462 2019-03-05  Tom Tromey  <tromey@adacore.com>
10463
10464         * python/py-prettyprint.c (print_string_repr): Remove #if.
10465         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10466
10467 2019-03-05  Tom Tromey  <tromey@adacore.com>
10468
10469         * target.c (the_dummy_target): Move later.  Change type to
10470         "dummy_target".
10471         (initialize_targets): Don't initialize the_dummy_target.
10472
10473 2019-03-05  Tom Tromey  <tromey@adacore.com>
10474
10475         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10476         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10477
10478 2019-03-05  Tom Tromey  <tromey@adacore.com>
10479
10480         * windows-nat.c (windows_nat_target::attach)
10481         (windows_nat_target::detach): Don't call gdb_flush.
10482         * valprint.c (generic_val_print, val_print, val_print_string):
10483         Don't call gdb_flush.
10484         * utils.c (defaulted_query): Don't call gdb_flush.
10485         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10486         * target.c (target_announce_detach): Don't call gdb_flush.
10487         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10488         * remote.c (extended_remote_target::attach): Don't call
10489         gdb_flush.
10490         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10491         * printcmd.c (do_examine): Don't call gdb_flush.
10492         (info_display_command): Don't call gdb_flush.
10493         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10494         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10495         * memattr.c (info_mem_command): Don't call gdb_flush.
10496         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10497         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10498         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10499         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10500         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10501         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10502         (gnu_nat_target::detach): Don't call gdb_flush.
10503         * f-valprint.c (f_val_print): Don't call gdb_flush.
10504         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10505         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10506         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10507         gdb_flush.
10508         * c-valprint.c (c_val_print): Don't call gdb_flush.
10509         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10510
10511 2019-03-05  Tom Tromey  <tromey@adacore.com>
10512
10513         * varobj.c (update_dynamic_varobj_children): Update.
10514         (install_default_visualizer): Use reset, not release.
10515         * value.c (set_internalvar): Update.
10516         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10517         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10518         ATTRIBUTE_UNUSED_RESULT.
10519
10520 2019-03-05  Tom Tromey  <tromey@adacore.com>
10521
10522         * remote.c (class scoped_remote_fd) <release>: Add
10523         ATTRIBUTE_UNUSED_RESULT.
10524
10525 2019-03-05  Tom Tromey  <tromey@adacore.com>
10526
10527         * macroexp.c (struct macro_buffer) <release>: Add
10528         ATTRIBUTE_UNUSED_RESULT.
10529
10530 2019-03-05  Tom Tromey  <tromey@adacore.com>
10531
10532         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10533         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10534         ATTRIBUTE_UNUSED_RESULT.
10535
10536 2019-03-05  Tom Tromey  <tromey@adacore.com>
10537
10538         * common/scoped_fd.h (class scoped_fd) <release>: Add
10539         ATTRIBUTE_UNUSED_RESULT.
10540
10541 2019-03-05  Tom Tromey  <tromey@adacore.com>
10542
10543         * parser-defs.h (struct parser_state) <release>: Add
10544         ATTRIBUTE_UNUSED_RESULT.
10545
10546 2019-03-05  Tom Tromey  <tromey@adacore.com>
10547
10548         * utils.h (class gdb_argv) <release>: Add
10549         ATTRIBUTE_UNUSED_RESULT.
10550         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10551
10552 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10553
10554         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10555         for-loop range, to avoid compiler warnings.
10556
10557         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10558         avoid compiler warnings about unused variables.
10559
10560         * NEWS: Mention end of support for native debugging on MS-Windows
10561         before XP.
10562
10563         PR gdb/24292
10564         * common/netstuff.c:
10565         * gdbserver/gdbreplay.c
10566         * gdbserver/remote-utils.c:
10567         * ser-tcp.c:
10568         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10569         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10570         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10571         'getaddrinfo' and 'freeaddrinfo' were not available before
10572         Windows XP, and mingw.org's MinGW headers by default define
10573         _WIN32_WINNT to 0x500.
10574
10575 2019-03-01  Gary Benson <gbenson@redhat.com>
10576
10577         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10578
10579 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10580             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10581
10582         PR gdb/8527
10583         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10584         set_sigint_trap, clear_sigint_trap.
10585
10586 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10587
10588         * target.c (target_detach): Clear the regcache and the
10589         frame cache.
10590
10591 2019-02-27  Pedro Alves  <palves@redhat.com>
10592
10593         * utils.c (set_screen_size): When we cap the height/width sizes,
10594         tweak the corresponding command variable to show "unlimited":
10595
10596 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10597             Pedro Alves  <palves@redhat.com>
10598
10599         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10600         before calling rl_set_screen_size.
10601
10602 2019-02-27  Tom Tromey  <tromey@adacore.com>
10603
10604         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10605         define.
10606         * python/py-value.c: Remove Python 2.4 workaround.
10607         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10608         workaround.
10609         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10610         Python 2.4 workaround.
10611         * python/python-internal.h: Remove Python 2.4 comment.
10612         (Py_ssize_t): Don't define.
10613         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10614         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10615         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10616         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10617         * python/python.c (do_start_initialization): Remove Python 2.4
10618         workaround.
10619         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10620         (print_children): Remove Python 2.4 workaround.
10621         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10622         workaround.
10623         (CHARBUFFERPROC_NAME): Remove.
10624         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10625         Python 2.4 workaround.
10626
10627 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10628
10629         * NEWS: Note minimum Python version.
10630
10631 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10632
10633         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10634         code from these functions.  Remove corresponding ifdefs.  Use
10635         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10636         Remove gotos and target of gotos.
10637         (infpy_search_memory): Likewise.
10638
10639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10640
10641         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10642         (hppa_gdbarch_init): Don't register deleted functions with
10643         gdbarch.
10644
10645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10646
10647         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10648         (h8300_unwind_sp): Delete.
10649         (h8300_dummy_id): Delete.
10650         (h8300_gdbarch_init): Don't register deleted functions with
10651         gdbarch.
10652
10653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10654
10655         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10656         (ft32_unwind_pc): Delete.
10657         (ft32_unwind_sp): Delete.
10658         (ft32_gdbarch_init): Don't register deleted functions with
10659         gdbarch.
10660
10661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10662
10663         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10664         (frv_unwind_pc): Delete.
10665         (frv_unwind_sp): Delete.
10666         (frv_gdbarch_init): Don't register deleted functions with
10667         gdbarch.
10668
10669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10670
10671         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10672         (riscv_unwind_pc): Delete.
10673         (riscv_unwind_sp): Delete.
10674         (riscv_gdbarch_init): Don't register deleted functions with
10675         gdbarch.
10676
10677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10678
10679         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10680         (csky_unwind_pc): Delete.
10681         (csky_unwind_sp): Delete.
10682         (csky_gdbarch_init): Don't register deleted functions with
10683         gdbarch.
10684
10685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10686
10687         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10688         (cris_unwind_pc): Delete.
10689         (cris_unwind_sp): Delete.
10690         (cris_gdbarch_init): Don't register deleted functions with
10691         gdbarch.
10692
10693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10694
10695         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10696         (bfin_unwind_pc): Delete.
10697         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10698
10699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10700
10701         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10702         (arm_unwind_pc): Delete.
10703         (arm_unwind_sp): Delete.
10704         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10705
10706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10707
10708         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10709         (arc_unwind_pc): Delete.
10710         (arc_unwind_sp): Delete.
10711         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10712
10713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10714
10715         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10716         (alpha_unwind_pc): Delete.
10717         (alpha_gdbarch_init): Don't register deleted functions with
10718         gdbarch.
10719
10720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10721
10722         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10723         (aarch64_unwind_pc): Delete.
10724         (aarch64_unwind_sp): Delete.
10725         (aarch64_gdbarch_init): Don't register deleted functions with
10726         gdbarch.
10727
10728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10729
10730         * gdbtypes.c (type_align): Don't consider static members when
10731         computing structure alignment.
10732
10733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10734
10735         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10736         return 0 for other types.
10737         * arch-utils.c (default_type_align): Always return 0.
10738         * gdbarch.h: Regenerate.
10739         * gdbarch.sh (type_align): Extend comment.
10740         * gdbtypes.c (type_align): Add additional comments, always call
10741         gdbarch_type_align before applying the default rules.
10742         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10743         generic code will then apply a suitable default.
10744         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10745         types, return 0 for other types.
10746
10747 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10748
10749         * NEWS: Create a new section for the next release branch.
10750         Rename the section of the current branch, now that it has
10751         been cut.
10752
10753 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10754
10755         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10756         * version.in: Bump version to 8.3.50.DATE-git.
10757
10758 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10759
10760         * aix-thread.c (ptid_cmp): Remove unused variable.
10761         (get_signaled_thread): Likewise.
10762         (store_regs_user_thread): Likewise.
10763         (store_regs_kernel_thread): Likewise.
10764         (fetch_regs_kernel_thread): Remove shadowed variable.
10765
10766 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10767
10768         * features/riscv/32bit-cpu.xml: Add register numbers.
10769         * features/riscv/32bit-fpu.c: Regenerate.
10770         * features/riscv/32bit-fpu.xml: Add register numbers.
10771         * features/riscv/64bit-cpu.xml: Add register numbers.
10772         * features/riscv/64bit-fpu.c: Regenerate.
10773         * features/riscv/64bit-fpu.xml: Add register numbers.
10774
10775 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10776
10777         * NEWS: Mention two argument form of gdb.Value constructor.
10778         * python/py-value.c (convert_buffer_and_type_to_value): New
10779         function.
10780         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10781         Add support for handling an optional second argument.  Call
10782         convert_buffer_and_type_to_value as appropriate.
10783         * python/python-internal.h (Py_buffer_deleter): New struct.
10784         (Py_buffer_up): New typedef.
10785
10786 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10787
10788         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10789         instead of releasing ownership.
10790
10791 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10792
10793         * dwarf2read.c (open_and_init_dwp_file): Call
10794         elf_numsections instead of bfd_count_sections to initialize
10795         dwp_file->num_sections.
10796
10797 2019-02-25  Tom Tromey  <tromey@adacore.com>
10798
10799         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10800
10801 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10802
10803         * gcore.in: Add '--readnever' option when invoking GDB.
10804
10805 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10806
10807         * MAINTAINERS: Update my email address.
10808
10809 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10810
10811         * build-id.c (build_id_to_debug_bfd_1): New function.
10812         (build_id_to_debug_bfd): Look for separate debug file in
10813         sysroot.
10814
10815 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10816
10817         * gdbarch.sh: Update the copyright year range that is placed into
10818         generated files.
10819
10820 2019-02-22  Keith Seitz  <keiths@redhat.com>
10821
10822         PR symtab/23853
10823         * linespec.c (create_sals_line_offset): Search for the default
10824         symtab's filename instead of its fullname.
10825
10826 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10827
10828         * NEWS: Update style defaults.
10829
10830 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10831
10832         * main.c (captured_main_1): Disable styling in batch mode.
10833
10834 2019-02-20  Tom Tromey  <tom@tromey.com>
10835
10836         * symtab.c (symtab_symbol_info): Fix typos.
10837
10838 2019-02-20  Tom Tromey  <tromey@adacore.com>
10839
10840         * findcmd.c (_initialize_mem_search): Use upper case for
10841         metasyntactic variables.
10842
10843 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10844
10845         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10846         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10847
10848 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10849
10850         * top.h (source_file_name): Change to std::string.
10851         * top.c (source_file_name): Likewise.
10852         (command_line_input): Adjust.
10853         * cli/cli-script.c (script_from_file): Adjust.
10854
10855 2019-02-19  Tom Tromey  <tromey@adacore.com>
10856
10857         * ravenscar-thread.c
10858         (ravenscar_thread_target::update_thread_list): Don't call
10859         ada_build_task_list.
10860         * ada-lang.h (ada_build_task_list): Don't declare.
10861         * ada-tasks.c (struct ada_tasks_inferior_data)
10862         <task_list_valid_p>: Now bool.
10863         (read_known_tasks, ada_task_list_changed)
10864         (ada_tasks_invalidate_inferior_data): Update.
10865         (read_known_tasks_array): Return bool.
10866         (read_known_tasks_list): Likewise.
10867         (read_known_tasks): Return void.
10868         (ada_build_task_list): Now static.
10869
10870 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10871
10872         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10873         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10874
10875 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10876
10877         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10878         variant for ada_tasks_pspace_data_handle and
10879         ada_tasks_inferior_data_handle.
10880         (ada_tasks_pspace_data_cleanup): New function.
10881         (ada_tasks_inferior_data_cleanup): New function.
10882
10883 2019-02-17  Tom Tromey  <tom@tromey.com>
10884
10885         * macrotab.h (macro_source_fullname): Return a std::string.
10886         * macrotab.c (macro_include, check_for_redefinition)
10887         (macro_undef, macro_lookup_definition, foreach_macro)
10888         (foreach_macro_in_scope): Update.
10889         (macro_source_fullname): Return a std::string.
10890         * macrocmd.c (show_pp_source_pos): Update.
10891
10892 2019-02-17  Tom Tromey  <tom@tromey.com>
10893
10894         * macrocmd.c (show_pp_source_pos): Style the file names.
10895
10896 2019-02-17  Tom Tromey  <tom@tromey.com>
10897
10898         PR tui/24197:
10899         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10900
10901 2019-02-17  Tom Tromey  <tom@tromey.com>
10902
10903         * ada-lang.c (user_select_syms): Use filtered printing.
10904         * utils.c (wrap_style): New global.
10905         (desired_style): Remove.
10906         (emit_style_escape): Add stream parameter.
10907         (set_output_style, reset_terminal_style, prompt_for_continue):
10908         Update.
10909         (flush_wrap_buffer): Only flush gdb_stdout.
10910         (wrap_here): Set wrap_style.
10911         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10912         treat escape sequences as a character.  Change when wrap buffer is
10913         flushed.
10914         (fputs_styled): Do not set the output style when the default is
10915         requested.
10916         * ui-style.h (struct ui_file_style) <is_default>: New method.
10917         * source.c (print_source_lines_base): Emit escape sequences in one
10918         piece.
10919
10920 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10921
10922         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10923         integers and enumeration types.
10924
10925 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10926
10927         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10928         instead of lookup_symbol_in_language
10929         (do_exact_match): New function.
10930         (ada_get_symbol_name_matcher): Return do_exact_match when
10931         doing a verbatim match.
10932
10933 2019-02-15  Tom Tromey  <tromey@adacore.com>
10934
10935         * ravenscar-thread.c (ravenscar_thread_target::resume)
10936         (ravenscar_thread_target::wait): Special case wildcard requests.
10937
10938 2019-02-15  Tom Tromey  <tromey@adacore.com>
10939
10940         * ravenscar-thread.c (base_ptid): Remove.
10941         (struct ravenscar_thread_target) <close>: New method.
10942         <m_base_ptid>: New member.
10943         <update_inferior_ptid, active_task, task_is_currently_active,
10944         runtime_initialized>: Declare methods.
10945         <ravenscar_thread_target>: Add constructor.
10946         (ravenscar_thread_target::task_is_currently_active)
10947         (ravenscar_thread_target::update_inferior_ptid)
10948         (ravenscar_runtime_initialized): Rename.  Now methods.
10949         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10950         (ravenscar_thread_target::update_thread_list): Update.
10951         (ravenscar_thread_target::active_task): Now method.
10952         (ravenscar_thread_target::store_registers)
10953         (ravenscar_thread_target::prepare_to_store)
10954         (ravenscar_thread_target::prepare_to_store)
10955         (ravenscar_thread_target::mourn_inferior): Update.
10956         (ravenscar_inferior_created): Use "new" to create target.
10957         (ravenscar_thread_target::get_ada_task_ptid): Update.
10958         (_initialize_ravenscar): Don't initialize base_ptid.
10959         (ravenscar_ops): Remove global.
10960
10961 2019-02-15  Tom Tromey  <tromey@adacore.com>
10962
10963         * target.h (push_target): Declare new overload.
10964         * target.c (push_target): New overload, taking an rvalue reference.
10965         * remote.c (remote_target::open_1): Use push_target overload.
10966         * corelow.c (core_target_open): Use push_target overload.
10967
10968 2019-02-15  Tom Tromey  <tromey@adacore.com>
10969
10970         * ravenscar-thread.c (is_ravenscar_task)
10971         (ravenscar_task_is_currently_active): Return bool.
10972         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10973         (_initialize_ravenscar): Remove "(void)".
10974         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10975         Return bool.
10976
10977 2019-02-15  Tom Tromey  <tromey@adacore.com>
10978
10979         * ravenscar-thread.c (ravenscar_runtime_initializer)
10980         (has_ravenscar_runtime, get_running_thread_id)
10981         (ravenscar_thread_target::resume): Fix indentation.
10982
10983 2019-02-15  Tom Tromey  <tromey@adacore.com>
10984
10985         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10986         from ravenscar_arch_ops.
10987         (sparc_ravenscar_ops::fetch_registers)
10988         (sparc_ravenscar_ops::store_registers): Now methods.
10989         (sparc_ravenscar_prepare_to_store): Remove.
10990         (sparc_ravenscar_ops): Redefine.
10991         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10992         methods and destructor.  Remove members.
10993         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10994         (ravenscar_thread_target::store_registers)
10995         (ravenscar_thread_target::prepare_to_store): Update.
10996         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10997         Remove.
10998         (struct ppc_ravenscar_powerpc_ops): Derive from
10999         ravenscar_arch_ops.
11000         (ppc_ravenscar_powerpc_ops::fetch_registers)
11001         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11002         (ppc_ravenscar_powerpc_ops): Redefine.
11003         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11004         (ppc_ravenscar_e500_ops::fetch_registers)
11005         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11006         (ppc_ravenscar_e500_ops): Redefine.
11007         * aarch64-ravenscar-thread.c
11008         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11009         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11010         (aarch64_ravenscar_fetch_registers)
11011         (aarch64_ravenscar_store_registers): Now methods.
11012         (aarch64_ravenscar_ops): Redefine.
11013
11014 2019-02-15  Tom Tromey  <tromey@adacore.com>
11015
11016         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11017         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11018         (ravenscar_thread_target::stopped_by_watchpoint)
11019         (ravenscar_thread_target::stopped_data_address)
11020         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11021
11022 2019-02-15  Tom Tromey  <tromey@adacore.com>
11023
11024         * ravenscar-thread.c: Fix some typos.
11025
11026 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11027             Tom Tromey  <tromey@adacore.com>
11028
11029         * ada-lang.c (ada_exception_sal): Change addr_string to a
11030         std::string.
11031         (create_ada_exception_catchpoint): Update.
11032
11033 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11034             Tom Tromey  <tromey@adacore.com>
11035
11036         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11037         (bp_location_ops): Remove.
11038         (base_breakpoint_allocate_location): Update.
11039         (free_bp_location): Update.
11040         * ada-lang.c (class ada_catchpoint_location)
11041         <ada_catchpoint_location>: Remove ops parameter.
11042         (ada_catchpoint_location_dtor): Remove.
11043         (ada_catchpoint_location_ops): Remove.
11044         (allocate_location_exception): Update.
11045         * breakpoint.h (struct bp_location_ops): Remove.
11046         (class bp_location) <bp_location>: Remove bp_location_ops
11047         parameter.
11048         <~bp_location>: Add destructor.
11049         <ops>: Remove.
11050
11051 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11052             Pedro Alves  <palves@redhat.com>
11053
11054         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11055         'PATH_MAX'.
11056
11057 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11058             Samuel Thibault  <samuel.thibault@gnu.org>
11059             Thomas Schwinge  <thomas@codesourcery.com>
11060
11061         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11062         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11063
11064 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11065
11066         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11067         (check_empty): Use "const char *".
11068
11069         * gnu-nat.c (gnu_nat_target::detach): Instead of
11070         'detach_inferior (pid)' call
11071         'detach_inferior (find_inferior_pid (pid))'.
11072
11073         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11074         'nat/fork-inferior.o'.
11075         * gnu-nat.c: #include "nat/fork-inferior.h".
11076
11077         * gnu-nat.c (gnu_nat_target::detach): Instead of
11078         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11079         * gnu-nat.h: #include "inf-child.h".
11080         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11081         'i386_gnu_nat_target::fetch_registers'.
11082         (gnu_store_registers): Rename/move to
11083         'i386_gnu_nat_target::store_registers'.
11084
11085         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11086         * gnu-nat.h (mach_thread_info): New function.
11087         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11088
11089         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11090
11091 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11092
11093         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11094
11095 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11096
11097         * windows-nat.c (windows_add_thread): Add new parameter
11098         "main_thread_p" with default value set to false.  Update
11099         function documentation as well as all callers.
11100         (windows_delete_thread): Likewise.
11101         (fake_create_process): Update call to windows_add_thread.
11102         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11103         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11104         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11105         call to windows_delete_thread.
11106
11107 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11108
11109         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11110
11111 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11112
11113         * symfile.c (find_separate_debug_file): Use canonical path of
11114         sysroot with child_path instead of gdb_sysroot if it is valid.
11115
11116 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11117
11118         * symfile.c (find_separate_debug_file): Use child_path to
11119         determine if an object file is under a sysroot.
11120
11121 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11122
11123         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11124         unittests/child-path-selftests.c.
11125         * common/pathstuff.c (child_path): New function.
11126         * common/pathstuff.h (child_path): New prototype.
11127         * unittests/child-path-selftests.c: New file.
11128
11129 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11130
11131         * symfile.c (find_separate_debug_file): Look for separate debug
11132         files in debug directories under the sysroot.
11133
11134 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11135
11136         * symtab.h (struct minimal_symbol data_p): New const method.
11137         (struct minimal_symbol text_p): Likewise.
11138         * symtab.c (output_source_filename): Use file name style
11139         to print file name.
11140         (print_symbol_info): Likewise.
11141         (print_msymbol_info): Use address style to print addresses.
11142         Use function name style to print executable text symbols.
11143         (expand_symtab_containing_pc): Use data_p.
11144         (find_pc_sect_compunit_symtab): Likewise.
11145
11146 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11147
11148         * breakpoint.c (describe_other_breakpoints): Use address style
11149         to print addresses.
11150         (say_where): Likewise.
11151
11152 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11153
11154         * ada-typeprint.c (print_func_type): Print function name
11155         style to print function name.
11156         * c-typeprint.c (c_print_type_1): Likewise.
11157
11158 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11159
11160         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11161         for execve.
11162
11163 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11164
11165         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11166         type_stack.
11167
11168 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11169
11170         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11171         TYPE_CODE_REF types.
11172
11173 2019-02-08  Jim Wilson  <jimw@sifive.com>
11174
11175         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11176         (riscv_linux_fregset): New.
11177         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11178
11179 2019-02-07  Tom Tromey  <tom@tromey.com>
11180
11181         * thread.c (thread_cancel_execution_command): Update.
11182         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11183         methods.
11184         (struct thread_fsm_ops): Remove.
11185         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11186         (thread_fsm_should_stop, thread_fsm_return_value)
11187         (thread_fsm_set_finished, thread_fsm_finished_p)
11188         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11189         Don't declare.
11190         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11191         * infrun.c (clear_proceed_status_thread)
11192         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11193         (print_stop_event): Update.
11194         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11195         Add constructor.
11196         (step_command_fsm_ops): Remove.
11197         (new_step_command_fsm): Remove.
11198         (step_1): Update.
11199         (step_command_fsm::should_stop): Rename from
11200         step_command_fsm_should_stop.
11201         (step_command_fsm::clean_up): Rename from
11202         step_command_fsm_clean_up.
11203         (step_command_fsm::do_async_reply_reason): Rename from
11204         step_command_fsm_async_reply_reason.
11205         (struct until_next_fsm): Inherit from thread_fsm.  Add
11206         constructor.
11207         (until_next_fsm_ops): Remove.
11208         (new_until_next_fsm): Remove.
11209         (until_next_fsm::should_stop): Rename from
11210         until_next_fsm_should_stop.
11211         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11212         (until_next_fsm::do_async_reply_reason): Rename from
11213         until_next_fsm_async_reply_reason.
11214         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11215         constructor.  Change type of breakpoint.
11216         (finish_command_fsm_ops): Remove.
11217         (new_finish_command_fsm): Remove.
11218         (finish_command_fsm::should_stop): Rename from
11219         finish_command_fsm_should_stop.
11220         (finish_command_fsm::clean_up): Rename from
11221         finish_command_fsm_clean_up.
11222         (finish_command_fsm::return_value): Rename from
11223         finish_command_fsm_return_value.
11224         (finish_command_fsm::do_async_reply_reason): Rename from
11225         finish_command_fsm_async_reply_reason.
11226         (finish_command): Update.
11227         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11228         Add constructor.
11229         (call_thread_fsm_ops): Remove.
11230         (call_thread_fsm::call_thread_fsm): Rename from
11231         new_call_thread_fsm.
11232         (call_thread_fsm::should_stop): Rename from
11233         call_thread_fsm_should_stop.
11234         (call_thread_fsm::should_notify_stop): Rename from
11235         call_thread_fsm_should_notify_stop.
11236         (run_inferior_call, call_function_by_hand_dummy): Update.
11237         * cli/cli-interp.c (should_print_stop_to_console): Update.
11238         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11239         Add constructor.  Change type of location_breakpoint,
11240         caller_breakpoint.
11241         (until_break_fsm_ops): Remove.
11242         (new_until_break_fsm): Remove.
11243         (until_break_fsm::should_stop): Rename from
11244         until_break_fsm_should_stop.
11245         (until_break_fsm::clean_up): Rename from
11246         until_break_fsm_clean_up.
11247         (until_break_fsm::do_async_reply_reason): Rename from
11248         until_break_fsm_async_reply_reason.
11249         (until_break_command): Update.
11250         * thread-fsm.c: Remove.
11251         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11252
11253 2019-02-07  Tom Tromey  <tom@tromey.com>
11254
11255         * yy-remap.h: Add include guard.
11256         * xtensa-tdep.h: Add include guard.
11257         * xcoffread.h: Rename include guard.
11258         * varobj-iter.h: Add include guard.
11259         * tui/tui.h: Rename include guard.
11260         * tui/tui-winsource.h: Rename include guard.
11261         * tui/tui-wingeneral.h: Rename include guard.
11262         * tui/tui-windata.h: Rename include guard.
11263         * tui/tui-win.h: Rename include guard.
11264         * tui/tui-stack.h: Rename include guard.
11265         * tui/tui-source.h: Rename include guard.
11266         * tui/tui-regs.h: Rename include guard.
11267         * tui/tui-out.h: Rename include guard.
11268         * tui/tui-layout.h: Rename include guard.
11269         * tui/tui-io.h: Rename include guard.
11270         * tui/tui-hooks.h: Rename include guard.
11271         * tui/tui-file.h: Rename include guard.
11272         * tui/tui-disasm.h: Rename include guard.
11273         * tui/tui-data.h: Rename include guard.
11274         * tui/tui-command.h: Rename include guard.
11275         * tic6x-tdep.h: Add include guard.
11276         * target/waitstatus.h: Rename include guard.
11277         * target/wait.h: Rename include guard.
11278         * target/target.h: Rename include guard.
11279         * target/resume.h: Rename include guard.
11280         * target-float.h: Rename include guard.
11281         * stabsread.h: Add include guard.
11282         * rs6000-tdep.h: Add include guard.
11283         * riscv-fbsd-tdep.h: Add include guard.
11284         * regformats/regdef.h: Rename include guard.
11285         * record.h: Rename include guard.
11286         * python/python.h: Rename include guard.
11287         * python/python-internal.h: Rename include guard.
11288         * python/py-stopevent.h: Rename include guard.
11289         * python/py-ref.h: Rename include guard.
11290         * python/py-record.h: Rename include guard.
11291         * python/py-record-full.h: Rename include guard.
11292         * python/py-record-btrace.h: Rename include guard.
11293         * python/py-instruction.h: Rename include guard.
11294         * python/py-events.h: Rename include guard.
11295         * python/py-event.h: Rename include guard.
11296         * procfs.h: Add include guard.
11297         * proc-utils.h: Add include guard.
11298         * p-lang.h: Add include guard.
11299         * or1k-tdep.h: Rename include guard.
11300         * observable.h: Rename include guard.
11301         * nto-tdep.h: Rename include guard.
11302         * nat/x86-linux.h: Rename include guard.
11303         * nat/x86-linux-dregs.h: Rename include guard.
11304         * nat/x86-gcc-cpuid.h: Add include guard.
11305         * nat/x86-dregs.h: Rename include guard.
11306         * nat/x86-cpuid.h: Rename include guard.
11307         * nat/ppc-linux.h: Rename include guard.
11308         * nat/mips-linux-watch.h: Rename include guard.
11309         * nat/linux-waitpid.h: Rename include guard.
11310         * nat/linux-ptrace.h: Rename include guard.
11311         * nat/linux-procfs.h: Rename include guard.
11312         * nat/linux-osdata.h: Rename include guard.
11313         * nat/linux-nat.h: Rename include guard.
11314         * nat/linux-namespaces.h: Rename include guard.
11315         * nat/linux-btrace.h: Rename include guard.
11316         * nat/glibc_thread_db.h: Rename include guard.
11317         * nat/gdb_thread_db.h: Rename include guard.
11318         * nat/gdb_ptrace.h: Rename include guard.
11319         * nat/fork-inferior.h: Rename include guard.
11320         * nat/amd64-linux-siginfo.h: Rename include guard.
11321         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11322         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11323         * nat/aarch64-linux.h: Rename include guard.
11324         * nat/aarch64-linux-hw-point.h: Rename include guard.
11325         * mn10300-tdep.h: Add include guard.
11326         * mips-linux-tdep.h: Add include guard.
11327         * mi/mi-parse.h: Rename include guard.
11328         * mi/mi-out.h: Rename include guard.
11329         * mi/mi-main.h: Rename include guard.
11330         * mi/mi-interp.h: Rename include guard.
11331         * mi/mi-getopt.h: Rename include guard.
11332         * mi/mi-console.h: Rename include guard.
11333         * mi/mi-common.h: Rename include guard.
11334         * mi/mi-cmds.h: Rename include guard.
11335         * mi/mi-cmd-break.h: Rename include guard.
11336         * m2-lang.h: Add include guard.
11337         * location.h: Rename include guard.
11338         * linux-record.h: Rename include guard.
11339         * linux-nat.h: Add include guard.
11340         * linux-fork.h: Add include guard.
11341         * i386-darwin-tdep.h: Rename include guard.
11342         * hppa-linux-offsets.h: Add include guard.
11343         * guile/guile.h: Rename include guard.
11344         * guile/guile-internal.h: Rename include guard.
11345         * gnu-nat.h: Rename include guard.
11346         * gdb-stabs.h: Rename include guard.
11347         * frv-tdep.h: Add include guard.
11348         * f-lang.h: Add include guard.
11349         * event-loop.h: Add include guard.
11350         * darwin-nat.h: Rename include guard.
11351         * cp-abi.h: Rename include guard.
11352         * config/sparc/nm-sol2.h: Rename include guard.
11353         * config/nm-nto.h: Rename include guard.
11354         * config/nm-linux.h: Add include guard.
11355         * config/i386/nm-i386gnu.h: Rename include guard.
11356         * config/djgpp/nl_types.h: Rename include guard.
11357         * config/djgpp/langinfo.h: Rename include guard.
11358         * compile/gcc-cp-plugin.h: Add include guard.
11359         * compile/gcc-c-plugin.h: Add include guard.
11360         * compile/compile.h: Rename include guard.
11361         * compile/compile-object-run.h: Rename include guard.
11362         * compile/compile-object-load.h: Rename include guard.
11363         * compile/compile-internal.h: Rename include guard.
11364         * compile/compile-cplus.h: Rename include guard.
11365         * compile/compile-c.h: Rename include guard.
11366         * common/xml-utils.h: Rename include guard.
11367         * common/x86-xstate.h: Rename include guard.
11368         * common/version.h: Rename include guard.
11369         * common/vec.h: Rename include guard.
11370         * common/tdesc.h: Rename include guard.
11371         * common/selftest.h: Rename include guard.
11372         * common/scoped_restore.h: Rename include guard.
11373         * common/scoped_mmap.h: Rename include guard.
11374         * common/scoped_fd.h: Rename include guard.
11375         * common/safe-iterator.h: Rename include guard.
11376         * common/run-time-clock.h: Rename include guard.
11377         * common/refcounted-object.h: Rename include guard.
11378         * common/queue.h: Rename include guard.
11379         * common/ptid.h: Rename include guard.
11380         * common/print-utils.h: Rename include guard.
11381         * common/preprocessor.h: Rename include guard.
11382         * common/pathstuff.h: Rename include guard.
11383         * common/observable.h: Rename include guard.
11384         * common/netstuff.h: Rename include guard.
11385         * common/job-control.h: Rename include guard.
11386         * common/host-defs.h: Rename include guard.
11387         * common/gdb_wait.h: Rename include guard.
11388         * common/gdb_vecs.h: Rename include guard.
11389         * common/gdb_unlinker.h: Rename include guard.
11390         * common/gdb_unique_ptr.h: Rename include guard.
11391         * common/gdb_tilde_expand.h: Rename include guard.
11392         * common/gdb_sys_time.h: Rename include guard.
11393         * common/gdb_string_view.h: Rename include guard.
11394         * common/gdb_splay_tree.h: Rename include guard.
11395         * common/gdb_setjmp.h: Rename include guard.
11396         * common/gdb_ref_ptr.h: Rename include guard.
11397         * common/gdb_optional.h: Rename include guard.
11398         * common/gdb_locale.h: Rename include guard.
11399         * common/gdb_assert.h: Rename include guard.
11400         * common/filtered-iterator.h: Rename include guard.
11401         * common/filestuff.h: Rename include guard.
11402         * common/fileio.h: Rename include guard.
11403         * common/environ.h: Rename include guard.
11404         * common/common-utils.h: Rename include guard.
11405         * common/common-types.h: Rename include guard.
11406         * common/common-regcache.h: Rename include guard.
11407         * common/common-inferior.h: Rename include guard.
11408         * common/common-gdbthread.h: Rename include guard.
11409         * common/common-exceptions.h: Rename include guard.
11410         * common/common-defs.h: Rename include guard.
11411         * common/common-debug.h: Rename include guard.
11412         * common/cleanups.h: Rename include guard.
11413         * common/buffer.h: Rename include guard.
11414         * common/btrace-common.h: Rename include guard.
11415         * common/break-common.h: Rename include guard.
11416         * cli/cli-utils.h: Rename include guard.
11417         * cli/cli-style.h: Rename include guard.
11418         * cli/cli-setshow.h: Rename include guard.
11419         * cli/cli-script.h: Rename include guard.
11420         * cli/cli-interp.h: Rename include guard.
11421         * cli/cli-decode.h: Rename include guard.
11422         * cli/cli-cmds.h: Rename include guard.
11423         * charset-list.h: Add include guard.
11424         * buildsym-legacy.h: Rename include guard.
11425         * bfin-tdep.h: Add include guard.
11426         * ax.h: Rename include guard.
11427         * arm-linux-tdep.h: Add include guard.
11428         * arm-fbsd-tdep.h: Add include guard.
11429         * arch/xtensa.h: Rename include guard.
11430         * arch/tic6x.h: Add include guard.
11431         * arch/i386.h: Add include guard.
11432         * arch/arm.h: Rename include guard.
11433         * arch/arm-linux.h: Rename include guard.
11434         * arch/arm-get-next-pcs.h: Rename include guard.
11435         * arch/amd64.h: Add include guard.
11436         * arch/aarch64-insn.h: Rename include guard.
11437         * arch-utils.h: Rename include guard.
11438         * annotate.h: Add include guard.
11439         * amd64-darwin-tdep.h: Rename include guard.
11440         * aarch64-linux-tdep.h: Add include guard.
11441         * aarch64-fbsd-tdep.h: Add include guard.
11442         * aarch32-linux-nat.h: Add include guard.
11443
11444 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11445
11446         * macrotab.c (macro_define_internal): New function that
11447         factorizes macro_define_object_internal and macro_define_function
11448         code.
11449         (macro_define_object_internal): Use macro_define_internal.
11450         (macro_define_function): Likewise.
11451
11452 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11453
11454         * macrocmd.c (extract_identifier): Return
11455         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11456         callers.
11457
11458 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11459
11460         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11461
11462 2019-02-05  Tom Tromey  <tom@tromey.com>
11463
11464         * target.c (target_stack::unpush): Move assertion earlier.
11465
11466 2019-01-30  Tom Tromey  <tom@tromey.com>
11467
11468         PR python/23615:
11469         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11470         (gdbpy_parse_and_eval): Likewise.
11471         * python/python-internal.h (gdbpy_allow_threads): New class.
11472
11473 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11474
11475         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11476         (aarch64_fbsd_fpregmap): Move earlier.
11477         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11478         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11479         instead of individual calls to trad_frame_set_reg_addr.
11480         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11481         earlier.
11482         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11483         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11484         instead of individual calls to trad_frame_set_reg_addr.
11485
11486 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11487
11488         * CONTRIBUTE: Replace contribution list with wiki link.
11489
11490 2019-01-25  Tom Tromey  <tom@tromey.com>
11491
11492         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11493
11494 2019-01-25  Tom Tromey  <tom@tromey.com>
11495
11496         * xtensa-linux-nat.c: Fix common/ includes.
11497         * xml-support.h: Fix common/ includes.
11498         * xml-support.c: Fix common/ includes.
11499         * x86-linux-nat.c: Fix common/ includes.
11500         * windows-nat.c: Fix common/ includes.
11501         * varobj.h: Fix common/ includes.
11502         * varobj.c: Fix common/ includes.
11503         * value.c: Fix common/ includes.
11504         * valops.c: Fix common/ includes.
11505         * utils.c: Fix common/ includes.
11506         * unittests/xml-utils-selftests.c: Fix common/ includes.
11507         * unittests/utils-selftests.c: Fix common/ includes.
11508         * unittests/unpack-selftests.c: Fix common/ includes.
11509         * unittests/tracepoint-selftests.c: Fix common/ includes.
11510         * unittests/style-selftests.c: Fix common/ includes.
11511         * unittests/string_view-selftests.c: Fix common/ includes.
11512         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11513         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11514         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11515         * unittests/rsp-low-selftests.c: Fix common/ includes.
11516         * unittests/parse-connection-spec-selftests.c: Fix common/
11517         includes.
11518         * unittests/optional-selftests.c: Fix common/ includes.
11519         * unittests/offset-type-selftests.c: Fix common/ includes.
11520         * unittests/observable-selftests.c: Fix common/ includes.
11521         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11522         * unittests/memrange-selftests.c: Fix common/ includes.
11523         * unittests/memory-map-selftests.c: Fix common/ includes.
11524         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11525         * unittests/function-view-selftests.c: Fix common/ includes.
11526         * unittests/environ-selftests.c: Fix common/ includes.
11527         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11528         * unittests/common-utils-selftests.c: Fix common/ includes.
11529         * unittests/cli-utils-selftests.c: Fix common/ includes.
11530         * unittests/array-view-selftests.c: Fix common/ includes.
11531         * ui-file.c: Fix common/ includes.
11532         * tui/tui-io.c: Fix common/ includes.
11533         * tracepoint.h: Fix common/ includes.
11534         * tracepoint.c: Fix common/ includes.
11535         * tracefile-tfile.c: Fix common/ includes.
11536         * top.h: Fix common/ includes.
11537         * top.c: Fix common/ includes.
11538         * thread.c: Fix common/ includes.
11539         * target/waitstatus.h: Fix common/ includes.
11540         * target/waitstatus.c: Fix common/ includes.
11541         * target.h: Fix common/ includes.
11542         * target.c: Fix common/ includes.
11543         * target-memory.c: Fix common/ includes.
11544         * target-descriptions.c: Fix common/ includes.
11545         * symtab.h: Fix common/ includes.
11546         * symfile.c: Fix common/ includes.
11547         * stap-probe.c: Fix common/ includes.
11548         * spu-linux-nat.c: Fix common/ includes.
11549         * sparc-nat.c: Fix common/ includes.
11550         * source.c: Fix common/ includes.
11551         * solib.c: Fix common/ includes.
11552         * solib-target.c: Fix common/ includes.
11553         * ser-unix.c: Fix common/ includes.
11554         * ser-tcp.c: Fix common/ includes.
11555         * ser-pipe.c: Fix common/ includes.
11556         * ser-base.c: Fix common/ includes.
11557         * selftest-arch.c: Fix common/ includes.
11558         * s12z-tdep.c: Fix common/ includes.
11559         * rust-exp.y: Fix common/ includes.
11560         * rs6000-aix-tdep.c: Fix common/ includes.
11561         * riscv-tdep.c: Fix common/ includes.
11562         * remote.c: Fix common/ includes.
11563         * remote-notif.h: Fix common/ includes.
11564         * remote-fileio.h: Fix common/ includes.
11565         * remote-fileio.c: Fix common/ includes.
11566         * regcache.h: Fix common/ includes.
11567         * regcache.c: Fix common/ includes.
11568         * record-btrace.c: Fix common/ includes.
11569         * python/python.c: Fix common/ includes.
11570         * python/py-type.c: Fix common/ includes.
11571         * python/py-inferior.c: Fix common/ includes.
11572         * progspace.h: Fix common/ includes.
11573         * producer.c: Fix common/ includes.
11574         * procfs.c: Fix common/ includes.
11575         * proc-api.c: Fix common/ includes.
11576         * printcmd.c: Fix common/ includes.
11577         * ppc-linux-nat.c: Fix common/ includes.
11578         * parser-defs.h: Fix common/ includes.
11579         * osdata.c: Fix common/ includes.
11580         * obsd-nat.c: Fix common/ includes.
11581         * nat/x86-linux.c: Fix common/ includes.
11582         * nat/x86-linux-dregs.c: Fix common/ includes.
11583         * nat/x86-dregs.h: Fix common/ includes.
11584         * nat/x86-dregs.c: Fix common/ includes.
11585         * nat/ppc-linux.c: Fix common/ includes.
11586         * nat/mips-linux-watch.h: Fix common/ includes.
11587         * nat/mips-linux-watch.c: Fix common/ includes.
11588         * nat/linux-waitpid.c: Fix common/ includes.
11589         * nat/linux-ptrace.h: Fix common/ includes.
11590         * nat/linux-ptrace.c: Fix common/ includes.
11591         * nat/linux-procfs.c: Fix common/ includes.
11592         * nat/linux-personality.c: Fix common/ includes.
11593         * nat/linux-osdata.c: Fix common/ includes.
11594         * nat/linux-namespaces.c: Fix common/ includes.
11595         * nat/linux-btrace.h: Fix common/ includes.
11596         * nat/linux-btrace.c: Fix common/ includes.
11597         * nat/fork-inferior.c: Fix common/ includes.
11598         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11599         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11600         * nat/aarch64-linux.c: Fix common/ includes.
11601         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11602         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11603         * namespace.h: Fix common/ includes.
11604         * mips-linux-tdep.c: Fix common/ includes.
11605         * minsyms.c: Fix common/ includes.
11606         * mi/mi-parse.h: Fix common/ includes.
11607         * mi/mi-main.c: Fix common/ includes.
11608         * mi/mi-cmd-env.c: Fix common/ includes.
11609         * memrange.h: Fix common/ includes.
11610         * memattr.c: Fix common/ includes.
11611         * maint.h: Fix common/ includes.
11612         * maint.c: Fix common/ includes.
11613         * main.c: Fix common/ includes.
11614         * machoread.c: Fix common/ includes.
11615         * location.c: Fix common/ includes.
11616         * linux-thread-db.c: Fix common/ includes.
11617         * linux-nat.c: Fix common/ includes.
11618         * linux-fork.c: Fix common/ includes.
11619         * inline-frame.c: Fix common/ includes.
11620         * infrun.c: Fix common/ includes.
11621         * inflow.c: Fix common/ includes.
11622         * inferior.h: Fix common/ includes.
11623         * inferior.c: Fix common/ includes.
11624         * infcmd.c: Fix common/ includes.
11625         * inf-ptrace.c: Fix common/ includes.
11626         * inf-child.c: Fix common/ includes.
11627         * ia64-linux-nat.c: Fix common/ includes.
11628         * i387-tdep.c: Fix common/ includes.
11629         * i386-tdep.c: Fix common/ includes.
11630         * i386-linux-tdep.c: Fix common/ includes.
11631         * i386-linux-nat.c: Fix common/ includes.
11632         * i386-go32-tdep.c: Fix common/ includes.
11633         * i386-fbsd-tdep.c: Fix common/ includes.
11634         * i386-fbsd-nat.c: Fix common/ includes.
11635         * guile/scm-type.c: Fix common/ includes.
11636         * guile/guile.c: Fix common/ includes.
11637         * go32-nat.c: Fix common/ includes.
11638         * gnu-nat.c: Fix common/ includes.
11639         * gdbthread.h: Fix common/ includes.
11640         * gdbarch-selftests.c: Fix common/ includes.
11641         * gdb_usleep.c: Fix common/ includes.
11642         * gdb_select.h: Fix common/ includes.
11643         * gdb_bfd.c: Fix common/ includes.
11644         * gcore.c: Fix common/ includes.
11645         * fork-child.c: Fix common/ includes.
11646         * findvar.c: Fix common/ includes.
11647         * fbsd-nat.c: Fix common/ includes.
11648         * event-top.c: Fix common/ includes.
11649         * event-loop.c: Fix common/ includes.
11650         * dwarf2read.c: Fix common/ includes.
11651         * dwarf2loc.c: Fix common/ includes.
11652         * dwarf2-frame.c: Fix common/ includes.
11653         * dwarf-index-cache.c: Fix common/ includes.
11654         * dtrace-probe.c: Fix common/ includes.
11655         * disasm-selftests.c: Fix common/ includes.
11656         * defs.h: Fix common/ includes.
11657         * csky-tdep.c: Fix common/ includes.
11658         * cp-valprint.c: Fix common/ includes.
11659         * cp-support.h: Fix common/ includes.
11660         * cp-support.c: Fix common/ includes.
11661         * corelow.c: Fix common/ includes.
11662         * completer.h: Fix common/ includes.
11663         * completer.c: Fix common/ includes.
11664         * compile/compile.c: Fix common/ includes.
11665         * compile/compile-loc2c.c: Fix common/ includes.
11666         * compile/compile-cplus-types.c: Fix common/ includes.
11667         * compile/compile-cplus-symbols.c: Fix common/ includes.
11668         * command.h: Fix common/ includes.
11669         * cli/cli-dump.c: Fix common/ includes.
11670         * cli/cli-cmds.c: Fix common/ includes.
11671         * charset.c: Fix common/ includes.
11672         * build-id.c: Fix common/ includes.
11673         * btrace.h: Fix common/ includes.
11674         * btrace.c: Fix common/ includes.
11675         * breakpoint.h: Fix common/ includes.
11676         * breakpoint.c: Fix common/ includes.
11677         * ax.h:
11678         (enum agent_op): Fix common/ includes.
11679         * ax-general.c (struct aop_map): Fix common/ includes.
11680         * ax-gdb.c: Fix common/ includes.
11681         * auxv.c: Fix common/ includes.
11682         * auto-load.c: Fix common/ includes.
11683         * arm-tdep.c: Fix common/ includes.
11684         * arch/riscv.c: Fix common/ includes.
11685         * arch/ppc-linux-common.c: Fix common/ includes.
11686         * arch/i386.c: Fix common/ includes.
11687         * arch/arm.c: Fix common/ includes.
11688         * arch/arm-linux.c: Fix common/ includes.
11689         * arch/arm-get-next-pcs.c: Fix common/ includes.
11690         * arch/amd64.c: Fix common/ includes.
11691         * arch/aarch64.c: Fix common/ includes.
11692         * arch/aarch64-insn.c: Fix common/ includes.
11693         * arch-utils.c: Fix common/ includes.
11694         * amd64-windows-tdep.c: Fix common/ includes.
11695         * amd64-tdep.c: Fix common/ includes.
11696         * amd64-sol2-tdep.c: Fix common/ includes.
11697         * amd64-obsd-tdep.c: Fix common/ includes.
11698         * amd64-nbsd-tdep.c: Fix common/ includes.
11699         * amd64-linux-tdep.c: Fix common/ includes.
11700         * amd64-linux-nat.c: Fix common/ includes.
11701         * amd64-fbsd-tdep.c: Fix common/ includes.
11702         * amd64-fbsd-nat.c: Fix common/ includes.
11703         * amd64-dicos-tdep.c: Fix common/ includes.
11704         * amd64-darwin-tdep.c: Fix common/ includes.
11705         * agent.c: Fix common/ includes.
11706         * ada-lang.h: Fix common/ includes.
11707         * ada-lang.c: Fix common/ includes.
11708         * aarch64-tdep.c: Fix common/ includes.
11709
11710 2019-01-25  Tom Tromey  <tom@tromey.com>
11711
11712         * common/create-version.sh: Use common/version.h.
11713
11714 2019-01-24  Pedro Alves  <palves@redhat.com>
11715
11716         * infrun.c (signal_stop, signal_print, signal_program)
11717         (signal_catch, signal_pass): Now arrays instead of pointers.
11718         (update_signals_program_target, do_target_resume)
11719         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11720         * linux-nat.c (linux_nat_target::pass_signals)
11721         (linux_nat_target::create_inferior, linux_nat_target::attach):
11722         Adjust.
11723         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11724         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11725         * procfs.c (procfs_target::pass_signals): Adjust.
11726         * record-full.c (record_full_target::resume): Adjust.
11727         * remote.c (remote_target::pass_signals)
11728         (remote_target::program_signals): Adjust.
11729         * target-debug.h (target_debug_print_signals): Now takes a
11730         gdb::array_view as parameter.  Adjust.
11731         * target.h (target_ops) <pass_signals, program_signals>: Replace
11732         pointer and length parameters with gdb::array_view.
11733         (target_pass_signals, target_program_signals): Likewise.
11734         * target-delegates.c: Regenerate.
11735
11736 2019-01-24  Pedro Alves  <palves@redhat.com>
11737
11738         * common/forward-scope-exit.h
11739         (forward_scope_exit::forward_scope_exit): Pass arguments to
11740         m_bind_function directly, instead of creating a std::bind and
11741         copying that.
11742
11743 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11744
11745         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11746         for static members.
11747         (pass_in_v_vfp_candidate): Likewise.
11748
11749 2019-01-23  Tom Tromey  <tom@tromey.com>
11750             Pedro Alves  <palves@redhat.com>
11751
11752         * regcache.c (class regcache_invalidator): Remove.
11753         (regcache::raw_write): Use make_scope_exit.
11754
11755 2019-01-23  Tom Tromey  <tom@tromey.com>
11756
11757         * ui-out.h (class ui_out_emit_type): Update comment.
11758
11759 2019-01-23  Tom Tromey  <tom@tromey.com>
11760
11761         * infrun.c (fetch_inferior_event): Update comment.
11762
11763 2019-01-23  Tom Tromey  <tom@tromey.com>
11764             Pedro Alves  <palves@redhat.com>
11765
11766         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11767         parameter.
11768         (fetch_inferior_event): Use SCOPE_EXIT.
11769
11770
11771 2019-01-23  Tom Tromey  <tom@tromey.com>
11772             Pedro Alves  <palves@redhat.com>
11773
11774         * infrun.c (disable_thread_events): Delete.
11775         (stop_all_threads): Use SCOPE_EXIT.
11776
11777 2019-01-23  Tom Tromey  <tom@tromey.com>
11778             Pedro Alves  <palves@redhat.com>
11779
11780         * symfile.c: Include forward-scope-exit.h.
11781         (clear_symtab_users_cleanup): Replace forward declaration with
11782         a FORWARD_SCOPE_EXIT.
11783         (syms_from_objfile_1): Use the forward_scope_exit and
11784         gdb::optional instead of cleanup_function.
11785         (reread_symbols): Use the forward_scope_exit instead of
11786         cleanup_function.
11787         (clear_symtab_users_cleanup): Remove function.
11788
11789 2019-01-23  Tom Tromey  <tom@tromey.com>
11790             Pedro Alves  <palves@redhat.com>
11791
11792         * linux-nat.c: Include scope-exit.h.
11793         (cleanup_target_stop): Remove.
11794         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11795         SCOPE_EXIT.
11796
11797 2019-01-23  Tom Tromey  <tom@tromey.com>
11798             Pedro Alves  <palves@redhat.com>
11799
11800         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11801         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11802
11803 2019-01-23  Tom Tromey  <tom@tromey.com>
11804             Andrew Burgess  <andrew.burgess@embecosm.com>
11805             Pedro Alves  <palves@redhat.com>
11806
11807         * infrun.c (fetch_inferior_event): Use scope_exit.
11808         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11809         * top.c (execute_command): Use scope_exit.
11810         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11811         * utils.c (do_bpstat_clear_actions_cleanup)
11812         (make_bpstat_clear_actions_cleanup): Remove.
11813
11814 2019-01-23  Tom Tromey  <tom@tromey.com>
11815             Pedro Alves  <palves@redhat.com>
11816
11817         * infrun.c: Include "common/scope-exit.h"
11818         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11819         (wait_for_inferior): Use SCOPE_EXIT.
11820         (fetch_inferior_event): Use scope_exit.
11821
11822 2019-01-23  Tom Tromey  <tom@tromey.com>
11823             Pedro Alves  <palves@redhat.com>
11824
11825         * breakpoint.c (create_breakpoint): Remove cleanup.
11826
11827 2019-01-23  Tom Tromey  <tom@tromey.com>
11828             Andrew Burgess  <andrew.burgess@embecosm.com>
11829             Pedro Alves  <palves@redhat.com>
11830
11831 2019-01-23  Pedro Alves  <palves@redhat.com>
11832
11833         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11834
11835 2019-01-23  Pedro Alves  <palves@redhat.com>
11836             Andrew Burgess  <andrew.burgess@embecosm.com>
11837
11838         * gdbthread.h: Include "common/forward-scope-exit.h".
11839         (scoped_finish_thread_state): Redefine custom class in terms of
11840         forward_scope_exit.
11841
11842 2019-01-23  Pedro Alves  <palves@redhat.com>
11843             Andrew Burgess  <andrew.burgess@embecosm.com>
11844
11845         * common/forward-scope-exit.h: New file.
11846
11847 2019-01-23  Pedro Alves  <palves@redhat.com>
11848             Andrew Burgess  <andrew.burgess@embecosm.com>
11849             Tom Tromey  <tom@tromey.com>
11850
11851         * common/scope-exit.h: New file.
11852
11853 2019-01-23  Pedro Alves  <palves@redhat.com>
11854
11855         * common/preprocessor.h (ESC): Rename to ...
11856         (ESC_PARENS): ... this.
11857         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11858         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11859
11860 2019-01-23  Tom Tromey  <tom@tromey.com>
11861
11862         * language.h (class scoped_switch_to_sym_language_if_auto):
11863         Initialize m_lang in both cases.
11864
11865 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11866
11867         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11868         with XCNEW.
11869
11870 2019-01-22  Tom Tromey  <tom@tromey.com>
11871
11872         * corelow.c: Do not include sys/file.h.
11873
11874 2019-01-22  Tom Tromey  <tom@tromey.com>
11875
11876         * tui/tui-wingeneral.h: Include gdb_curses.h.
11877
11878 2019-01-22  Tom Tromey  <tom@tromey.com>
11879
11880         * source-cache.h (class source_cache) <get_source_lines,
11881         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11882
11883 2019-01-22  Tom Tromey  <tom@tromey.com>
11884
11885         * remote-fileio.h (struct remote_target): Declare.
11886
11887 2019-01-22  Tom Tromey  <tom@tromey.com>
11888
11889         * python/py-arch.c: Do not include py-ref.h.
11890         * python/py-bpevent.c: Do not include py-ref.h.
11891         * python/py-cmd.c: Do not include py-ref.h.
11892         * python/py-continueevent.c: Do not include py-ref.h.
11893         * python/py-event.h: Do not include py-ref.h.
11894         * python/py-evtregistry.c: Do not include py-ref.h.
11895         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11896         * python/py-frame.c: Do not include py-ref.h.
11897         * python/py-framefilter.c: Do not include py-ref.h.
11898         * python/py-function.c: Do not include py-ref.h.
11899         * python/py-infevents.c: Do not include py-ref.h.
11900         * python/py-linetable.c: Do not include py-ref.h.
11901         * python/py-objfile.c: Do not include py-ref.h.
11902         * python/py-param.c: Do not include py-ref.h.
11903         * python/py-prettyprint.c: Do not include py-ref.h.
11904         * python/py-progspace.c: Do not include py-ref.h.
11905         * python/py-symbol.c: Do not include py-ref.h.
11906         * python/py-symtab.c: Do not include py-ref.h.
11907         * python/py-type.c: Do not include py-ref.h.
11908         * python/py-unwind.c: Do not include py-ref.h.
11909         * python/py-utils.c: Do not include py-ref.h.
11910         * python/py-value.c: Do not include py-ref.h.
11911         * python/py-varobj.c: Do not include py-ref.h.
11912         * python/py-xmethods.c: Do not include py-ref.h.
11913         * python/python.c: Do not include py-ref.h.
11914         * varobj.c: Do not include py-ref.h.
11915
11916 2019-01-22  Tom Tromey  <tom@tromey.com>
11917
11918         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11919         keyword for bcache.
11920
11921 2019-01-22  Tom Tromey  <tom@tromey.com>
11922
11923         * compile/compile-cplus-types.c: Remove a comment by #include.
11924
11925 2019-01-22  Tom Tromey  <tom@tromey.com>
11926
11927         * compile/gcc-c-plugin.h: Include compile-internal.h.
11928
11929 2019-01-22  Tom Tromey  <tom@tromey.com>
11930
11931         * stabsread.c (EXTERN): Do not define.
11932         (symnum, next_symbol_text_func, processing_gcc_compilation)
11933         (within_function, global_sym_chain, global_stabs)
11934         (previous_stab_code, this_object_header_files)
11935         (n_this_object_header_files)
11936         (n_allocated_this_object_header_files): Define.
11937         * stabsread.h (EXTERN): Never define.  Use "extern".
11938
11939 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11940
11941         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11942         history_value.
11943
11944 2019-01-21  Tom Tromey  <tom@tromey.com>
11945
11946         * ui-out.c: Fix includes.
11947         * tui/tui-source.c: Fix includes.
11948         * target.c: Fix includes.
11949         * remote.c: Fix includes.
11950         * regcache.c: Fix includes.
11951         * python/py-block.c: Fix includes.
11952         * printcmd.c: Fix includes.
11953         * or1k-tdep.c: Fix includes.
11954         * mi/mi-main.c: Fix includes.
11955         * m32r-tdep.c: Fix includes.
11956         * csky-tdep.c: Fix includes.
11957         * compile/compile-cplus-types.c: Fix includes.
11958         * cli/cli-interp.c: Fix includes.
11959
11960 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11961
11962         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11963         for padding.
11964
11965 2019-01-16  Tom Tromey  <tom@tromey.com>
11966
11967         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11968         earlier.
11969         (struct objfile) <msymbols_range>: Move from top level.
11970         <msymbols>: New method.
11971         (class objfile_msymbols): Remove.
11972         * symtab.c (default_collect_symbol_completion_matches_break_on):
11973         Update.
11974         * symmisc.c (dump_msymbols): Update.
11975         * stabsread.c (scan_file_globals): Update.
11976         * objc-lang.c (info_selectors_command, info_classes_command)
11977         (find_methods): Update.
11978         * minsyms.c (find_solib_trampoline_target): Update.
11979         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11980         * coffread.c (coff_symfile_read): Update.
11981         * ada-lang.c (ada_lookup_simple_minsym)
11982         (ada_collect_symbol_completion_matches): Update.
11983
11984 2019-01-16  Tom Tromey  <tom@tromey.com>
11985
11986         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11987         type.  Remove no-argument constructor.
11988         <iterator::operator++>: Simplify.
11989         <begin>: Update.
11990         <end>: Use minimal_symbol_count.
11991
11992 2019-01-16  Tom Tromey  <tom@tromey.com>
11993
11994         * objfiles.h (struct objfile) <psymtabs>: New method.
11995         (class objfile_psymtabs): Remove.
11996         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11997         typedef.
11998         <range>: New method.
11999         (require_partial_symbols): Change return type.
12000         * psymtab.c (require_partial_symbols)
12001         (psym_expand_symtabs_matching): Update.
12002         * mdebugread.c (parse_partial_symbols): Update.
12003         * dbxread.c (dbx_end_psymtab): Update.
12004
12005 2019-01-15  Tom Tromey  <tom@tromey.com>
12006
12007         * symtab.c (lookup_objfile_from_block)
12008         (lookup_symbol_in_objfile_symtabs)
12009         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12010         (find_line_symtab, info_sources_command)
12011         (default_collect_symbol_completion_matches_break_on)
12012         (make_source_files_completion_list): Update.
12013         * symmisc.c (print_objfile_statistics, dump_objfile)
12014         (maintenance_print_symbols, maintenance_info_symtabs)
12015         (maintenance_check_symtabs, maintenance_info_line_tables):
12016         Update.
12017         * source.c (select_source_symtab)
12018         (forget_cached_source_info_for_objfile): Update.
12019         * objfiles.h (class objfile_compunits): Remove.
12020         (struct objfile) <compunits_range>: New typedef.
12021         (compunits): New method.
12022         * objfiles.c (objfile_relocate1): Update.
12023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12024         * maint.c (count_symtabs_and_blocks): Update.
12025         * linespec.c (iterate_over_all_matching_symtabs): Update.
12026         * cp-support.c (add_symbol_overload_list_qualified): Update.
12027         * coffread.c (coff_symtab_read): Update.
12028         * ada-lang.c (add_nonlocal_symbols)
12029         (ada_collect_symbol_completion_matches)
12030         (ada_add_global_exceptions): Update.
12031
12032 2019-01-15  Tom Tromey  <tom@tromey.com>
12033
12034         * progspace.h (program_space) <objfiles_safe_range>: New
12035         typedef.
12036         <objfiles_safe>: New method.
12037         * objfiles.h (class all_objfiles_safe): Remove.
12038         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12039         * jit.c (jit_inferior_exit_hook): Update.
12040
12041 2019-01-17  Tom Tromey  <tom@tromey.com>
12042
12043         * progspace.h (program_space) <objfiles_range>: New typedef.
12044         <objfiles>: New method.
12045         <objfiles_head>: Rename from objfiles.
12046         (object_files): Update.
12047         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12048         * guile/scm-pretty-print.c
12049         (ppscm_find_pretty_printer_from_objfiles): Update.
12050         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12051         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12052         Update.
12053         * python/py-progspace.c (pspy_get_objfiles): Update.
12054         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12055         Update.
12056         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12057         (objfpy_lookup_objfile_by_build_id): Update.
12058         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12059         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12060         Update.
12061         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12062         (expand_symtab_containing_pc, lookup_objfile_from_block)
12063         (lookup_static_symbol, basic_lookup_transparent_type)
12064         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12065         (find_line_symtab, info_sources_command)
12066         (default_collect_symbol_completion_matches_break_on)
12067         (make_source_files_completion_list, find_main_name): Update.
12068         * symmisc.c (print_symbol_bcache_statistics)
12069         (print_objfile_statistics, maintenance_print_symbols)
12070         (maintenance_print_msymbols, maintenance_print_objfiles)
12071         (maintenance_info_symtabs, maintenance_check_symtabs)
12072         (maintenance_expand_symtabs, maintenance_info_line_tables):
12073         Update.
12074         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12075         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12076         (map_overlay_command, unmap_overlay_command)
12077         (simple_overlay_update, expand_symtabs_matching)
12078         (map_symbol_filenames): Update.
12079         * symfile-debug.c (set_debug_symfile): Update.
12080         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12081         Update.
12082         * source.c (select_source_symtab, forget_cached_source_info):
12083         Update.
12084         * solib.c (solib_read_symbols): Update.
12085         * solib-spu.c (append_ocl_sos): Update.
12086         * psymtab.c (maintenance_print_psymbols)
12087         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12088         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12089         * printcmd.c (info_symbol_command): Update.
12090         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12091         Update.
12092         * objfiles.h (class all_objfiles): Remove.
12093         * objfiles.c (have_partial_symbols, have_full_symbols)
12094         (have_minimal_symbols, qsort_cmp, update_section_map)
12095         (shared_objfile_contains_address_p)
12096         (default_iterate_over_objfiles_in_search_order): Update.
12097         * objc-lang.c (info_selectors_command, info_classes_command)
12098         (find_methods): Update.
12099         * minsyms.c (find_solib_trampoline_target): Update.
12100         * maint.c (maintenance_info_sections)
12101         (maintenance_translate_address, count_symtabs_and_blocks):
12102         Update.
12103         * main.c (captured_main_1): Update.
12104         * linux-thread-db.c (try_thread_db_load_from_pdir)
12105         (has_libpthread): Update.
12106         * linespec.c (iterate_over_all_matching_symtabs)
12107         (search_minsyms_for_name): Update.
12108         * jit.c (jit_find_objf_with_entry_addr): Update.
12109         * hppa-tdep.c (find_unwind_entry)
12110         (hppa_lookup_stub_minimal_symbol): Update.
12111         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12112         Update.
12113         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12114         (elf_gnu_ifunc_resolve_by_got): Update.
12115         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12116         * dwarf-index-write.c (save_gdb_index_command): Update.
12117         * cp-support.c (add_symbol_overload_list_qualified): Update.
12118         * breakpoint.c (create_overlay_event_breakpoint)
12119         (create_longjmp_master_breakpoint)
12120         (create_std_terminate_master_breakpoint)
12121         (create_exception_master_breakpoint): Update.
12122         * blockframe.c (find_pc_partial_function): Update.
12123         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12124         (ada_collect_symbol_completion_matches)
12125         (ada_add_global_exceptions): Update.
12126
12127 2019-01-17  Tom Tromey  <tom@tromey.com>
12128
12129         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12130         declare VEC.
12131         (solib_target_parse_libraries): Change return type.
12132         (library_list_start_segment, library_list_start_section)
12133         (library_list_end_library, library_list_start_library); Update.
12134         (solib_target_free_library_list): Remove.
12135         (solib_target_parse_libraries): Remove cleanup.  Change return
12136         type.
12137         (solib_target_current_sos): Update.
12138
12139 2019-01-17  Tom Tromey  <tromey@bapiya>
12140
12141         * valprint.c: Replace "the the" with "the".
12142         * symtab.c: Replace "the the" with "the".
12143         * solib.c: Replace "the the" with "the".
12144         * solib-dsbt.c: Replace "the the" with "the".
12145         * linespec.c: Replace "the the" with "the".
12146         * dwarf2loc.h: Replace "the the" with "the".
12147         * amd64-windows-tdep.c: Replace "the the" with "the".
12148         * aarch64-tdep.c: Replace "the the" with "the".
12149
12150 2019-01-16  Keith Seitz  <keiths@redhat.com>
12151
12152         PR gdb/23773
12153         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12154         <builder>: Rename to ..
12155         <m_builder>: ... this and make private.
12156         (dwarf2_cu::get_builder): New method.  Change all users of
12157         `builder' to use this method.
12158         (dwarf2_start_symtab): Move to ...
12159         (dwarf2_cu::start_symtab): ... here.  Update all callers
12160         (setup_type_unit_groups): Move to ...
12161         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12162         callers.
12163         (dwarf2_cu::reset_builder): New method.
12164         (process_full_compunit, process_full_type_unit): Use
12165         dwarf2_cu::reset_builder.
12166         (follow_die_offset): Record the ancestor CU if it is different
12167         from the followed DIE's CU.
12168         (follow_die_sig_1): Likewise.
12169
12170 2019-01-15  Tom Tromey  <tom@tromey.com>
12171
12172         * remote.c (class remote_state) <buf>: Now a char_vector.
12173         <buf_size>: Remove.
12174         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12175         parameter.
12176         (remote_target::getpkt_or_notif_sane_1)
12177         (remote_target::getpkt_sane)
12178         (remote_target::getpkt_or_notif_sane): Likewise.
12179         (class remote_target) <putpkt>: New overload.
12180         (remote_target::read_frame): Change type of "buf_p".  Remove
12181         sizeof_p parameter.
12182         (packet_ok): New overload.
12183         (packet_check_result): New overload.
12184         Update all uses.
12185
12186 2019-01-14  Tom Tromey  <tom@tromey.com>
12187
12188         * remote-notif.c (handle_notification, remote_notif_ack)
12189         (remote_notif_parse): Make "buf" const.
12190         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12191         const.
12192         (remote_notif_parse, remote_notif_ack, handle_notification):
12193         Likewise.
12194         * remote.c (remote_notif_stop_parse): Make "buf" const.
12195         (remote_target::remote_parse_stop_reply): Make "buf" const.
12196         (remote_notif_stop_ack): Make "buf" const.
12197
12198 2019-01-14  Tom Tromey  <tom@tromey.com>
12199
12200         * remote.c (remote_console_output): Make parameter const.
12201
12202 2019-01-14  Tom Tromey  <tom@tromey.com>
12203
12204         * target-debug.h (target_debug_print_signals): Constify.
12205         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12206         * procfs.c (procfs_target::pass_signals): Update.
12207         * linux-nat.c (linux_nat_target::pass_signals): Update.
12208         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12209         * target-delegates.c: Rebuild.
12210         * remote.c (remote_target::program_signals): Update.
12211         (remote_target::pass_signals): Update.
12212         * target.c (target_pass_signals): Constify argument.
12213         (target_program_signals): Likewise.
12214         * target.h (struct target_ops) <pass_signals, program_signals>:
12215         Constify argument.
12216         (target_pass_signals, target_program_signals): Constify argument.
12217
12218 2019-01-14  Tom Tromey  <tom@tromey.com>
12219
12220         PR tui/28819:
12221         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12222
12223 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12224
12225         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12226         field.
12227         * rs6000-tdep.c: Include reggroups.h.
12228         (IS_V_ALIAS_PSEUDOREG): Define.
12229         (rs6000_register_name): Return names for the "vX" aliases.
12230         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12231         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12232         aliases.  Call default_register_reggroup_p for all other
12233         pseudo-registers.
12234         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12235         New functions.
12236         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12237         Handle "vX" aliases.
12238         (v_alias_pseudo_register_collect): New function.
12239         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12240         (rs6000_gdbarch_init): Initialize "vX" aliases as
12241         pseudo-registers.  Restore registration of
12242         rs6000_pseudo_register_reggroup_p with
12243         set_tdesc_pseudo_register_reggroup_p.
12244
12245 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12246
12247         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12248         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12249         set_gdbarch_num_pseudo_regs.
12250
12251 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12252
12253         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12254         Remove arg prefixname, add do_set and do_show.
12255         Add member functions set_list and show_list.
12256         * cli/cli-style.c (class cli_style_option): Update accordingly.
12257         (style_set_list): Move to file scope.
12258         (style_show_list): Likewise.
12259         (set_style): Call help_list.
12260         (show_style): Call cmd_show_list.
12261         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12262         Update to use the new macro.
12263
12264 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12265
12266         * ada-lang.c (_initialize_ada_language): Expand the help text
12267         for the "catch exception" command.
12268
12269 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12270
12271         * symtab.c (matching_obj_sections): Initialize obj,
12272         declare it closer to its usage.
12273
12274 2019-01-10  Tom Tromey  <tom@tromey.com>
12275
12276         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12277         (basic_inf_threads_range): Remove.
12278         (inf_threads_range, inf_non_exited_threads_range)
12279         (safe_inf_threads_range): Use next_adapter.
12280
12281 2019-01-10  Keith Seitz  <keiths@redhat.com>
12282
12283         PR gdb/23712
12284         PR symtab/23010
12285         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12286         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12287
12288 2019-01-10  Keith Seitz  <keiths@redhat.com>
12289
12290         PR gdb/23712
12291         PR symtab/23010
12292         * dictionary.c (pending_to_vector): Remove.
12293         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12294         Remove _1 suffix, replacing functions of the same name.  Update
12295         all callers.
12296         (dict_create_hashed, dict_create_hashed_expandable)
12297         (dict_create_linear, dict_create_linear_expandable, dict_free)
12298         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12299         Make functions static.
12300
12301 2019-01-10  Keith Seitz  <keiths@redhat.com>
12302
12303         PR gdb/23712
12304         PR symtab/23010
12305         * dictionary.h (struct dictionary): Replace declaration with
12306         multidictionary.
12307         (dict_create_hashed, dict_create_hashed_expandable)
12308         (dict_create_linear, dict_create_linear_expandable)
12309         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12310         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12311         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12312         taking multidictionary argument.
12313         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12314         * block.h (struct block) <dict>: Change to multidictionary
12315         and rename `multidict'.
12316         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12317         symmisc.c: Update all dictionary references to multidictionary.
12318
12319 2019-01-10  Keith Seitz  <keiths@redhat.com>
12320
12321         PR gdb/23712
12322         PR symtab/23010
12323         * dictionary.c: Include unordered_map.
12324         (pending_to_vector): New function.
12325         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12326         Rewrite the non-"_1" functions to take vector instead
12327         of linked list.
12328         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12329         "new" _1 versions of the same name.
12330         (multidictionary): Define.
12331         (std::hash<enum language): New definition.
12332         (collate_pending_symbols_by_language, mdict_create_hashed)
12333         (mdict_create_hashed_expandable, mdict_create_linear)
12334         (mdict_create_linear_expandable, mdict_free)
12335         (find_language_dictionary, create_new_language_dictionary)
12336         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12337         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12338         (mdict_size, mdict_empty): New functions.
12339         * dictionary.h (mdict_iterator): Define.
12340
12341 2019-01-10  Pedro Alves  <palves@redhat.com>
12342
12343         * breakpoint.c (read_uploaded_action)
12344         (create_tracepoint_from_upload): Adjust to use
12345         gdb::unique_xmalloc_ptr.
12346         * ctf.c (ctf_write_uploaded_tp):
12347         (SET_ARRAY_FIELD): Use emplace_back.
12348         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12349         * tracefile-tfile.c (tfile_write_uploaded_tp):
12350         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12351         gdb::unique_xmalloc_ptr.
12352         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12353         at_string, cond_string, cmd_strings>: Replace char pointers
12354         with gdb::unique_xmalloc_ptr.
12355
12356 2019-01-10  Pedro Alves  <palves@redhat.com>
12357
12358         * solib-target.c (library_list_start_library): Don't xstrdup name.
12359
12360 2019-01-10  Pedro Alves  <palves@redhat.com>
12361
12362         * mdebugread.c (parse_partial_symbols): Use
12363         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12364
12365 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12366
12367         * linux-fork.c (scoped_switch_fork_info)
12368         <~scoped_switch_fork_info>: Fix incorrect variable name.
12369
12370 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12371
12372         * linux-fork.c (scoped_switch_fork_info)
12373         <scoped_switch_fork_info>: Make explicit.
12374         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12375
12376 2019-01-10  Tom Tromey  <tom@tromey.com>
12377
12378         * objfiles.h (objfile::reset_psymtabs): Update.
12379         * objfiles.c (objfile::objfile): Update.
12380         * psymtab.h (psymtab_storage::obstack): Update.
12381         (psymtab_storage::m_obstack): Use gdb::optional.
12382         (class psymtab_storage): Update comment.  Remove objfile
12383         parameter.
12384         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12385
12386 2019-01-10  Tom Tromey  <tom@tromey.com>
12387
12388         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12389         <free_psymtabs>: Now private.
12390         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12391         (allocate_psymtab): Use new method.
12392
12393 2019-01-10  Tom Tromey  <tom@tromey.com>
12394
12395         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12396         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12397         * mdebugread.c (parse_partial_symbols): Use
12398         allocate_dependencies.
12399         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12400         allocate_dependencies.
12401         (process_psymtab_comp_unit_reader)
12402         (build_type_psymtab_dependencies): Likewise.
12403         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12404
12405 2019-01-10  Tom Tromey  <tom@tromey.com>
12406
12407         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12408         PSYMBOL_SET_LANGUAGE.
12409         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12410
12411 2019-01-10  Tom Tromey  <tom@tromey.com>
12412
12413         * psymtab.h (psymtab_storage::obstack): New method.
12414         <m_obstack>: Rename from obstack; now private.
12415         * psymtab.c (psymtab_storage): Update.
12416         * dwarf2read.c (create_addrmap_from_index)
12417         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12418         Update.
12419
12420 2019-01-10  Tom Tromey  <tom@tromey.com>
12421
12422         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12423         * objfiles.h (objfile::reset_psymtabs): New method.
12424
12425 2019-01-10  Tom Tromey  <tom@tromey.com>
12426
12427         * symmisc.c (print_symbol_bcache_statistics): Update.
12428         (print_objfile_statistics): Update.
12429         * symfile.c (reread_symbols): Update.
12430         * psymtab.h (class psymtab_storage): New.
12431         * psymtab.c (psymtab_storage): New constructor.
12432         (~psymtab_storage): New destructor.
12433         (require_partial_symbols): Update.
12434         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12435         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12436         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12437         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12438         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12439         (start_psymtab_common, end_psymtab_common)
12440         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12441         (allocate_psymtab): Update.
12442         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12443         Update.
12444         (dump_psymtab_addrmap, maintenance_print_psymbols)
12445         (maintenance_check_psymtabs): Update.
12446         (class objfile_psymtabs): Move to objfiles.h.
12447         * psympriv.h (discard_psymtab): Now inline.
12448         (psymtab_discarder::psymtab_discarder): Update.
12449         (psymtab_discarder::~psymtab_discarder): Update.
12450         (ALL_OBJFILE_PSYMTABS): Rewrite.
12451         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12452         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12453         Remove fields.
12454         <partial_symtabs>: New field.
12455         (class objfile_psymtabs): Move from psymtab.h.  Update.
12456         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12457         psymbol_cache.
12458         (objfile::~objfile): Don't destroy psymbol_cache.
12459         * mdebugread.c (parse_partial_symbols): Update.
12460         * dwarf2read.c (create_addrmap_from_index)
12461         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12462         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12463         (add_partial_subprogram, dwarf2_ranges_read): Update.
12464         * dwarf-index-write.c (write_address_map)
12465         (write_one_signatured_type, recursively_write_psymbols)
12466         (class debug_names, class debug_names, write_psymtabs_to_index):
12467         Update.
12468
12469 2019-01-10  Tom Tromey  <tom@tromey.com>
12470
12471         * symtab.h (SYMBOL_SET_NAMES): Update.
12472         (symbol_set_names): Update.
12473         (MSYMBOL_SET_NAMES): Update.
12474         * symtab.c (symbol_set_names): Change argument to be an
12475         objfile_per_bfd_storage.
12476         * psymtab.c (add_psymbol_to_bcache): Update.
12477         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12478
12479 2019-01-10  Tom Tromey  <tom@tromey.com>
12480
12481         * symtab.c (create_demangled_names_hash): Change argument to be an
12482         objfile_per_bfd_storage.
12483         (symbol_set_names): Update.
12484
12485 2019-01-10  Tom Tromey  <tom@tromey.com>
12486
12487         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12488         init_psymbol_list.
12489         * psymtab.c (init_psymbol_list): Do nothing if already called.
12490         * psympriv.h (init_psymbol_list): Add comment.
12491         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12492         init_psymbol_list.
12493         * dbxread.c (dbx_symfile_read): Unconditionally call
12494         init_psymbol_list.
12495
12496 2019-01-10  Tom Tromey  <tom@tromey.com>
12497
12498         * xcoffread.c (scan_xcoff_symtab): Update.
12499         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12500         "where".
12501         * mdebugread.c (parse_partial_symbols)
12502         (handle_psymbol_enumerators): Update.
12503         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12504         * dbxread.c (read_dbx_symtab): Update.
12505         * psympriv.h (psymbol_placement): New enum.
12506         (add_psymbol_to_list): Update.
12507
12508 2019-01-10  Tom Tromey  <tom@tromey.com>
12509
12510         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12511         static_psymbols parameters.
12512         (scan_xcoff_symtab): Update.
12513         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12514         static_psymbols parameters.
12515         * psympriv.h (start_psymtab_common): Update.
12516         * mdebugread.c (parse_partial_symbols): Update.
12517         * dwarf2read.c (create_partial_symtab): Update.
12518         * dbxread.c (read_dbx_symtab): Update.
12519         (start_psymtab): Remove global_psymbols and static_psymbols
12520         parameters.
12521
12522 2019-01-10  Tom Tromey  <tom@tromey.com>
12523
12524         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12525         * psymtab.c (allocate_psymtab): Add comment.
12526         * psympriv.h (allocate_psymtab): Add comment.
12527         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12528         initializations.
12529         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12530
12531 2019-01-10  Tom Tromey  <tom@tromey.com>
12532
12533         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12534         Don't declare.
12535         * mipsread.c: Include mdebugread.h.
12536         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12537         Declare.
12538         * elfread.c: Include mdebugread.h.
12539
12540 2019-01-09  Tom Tromey  <tom@tromey.com>
12541
12542         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12543         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12544         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12545         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12546         (psym_lookup_symbol, psym_find_last_source_symtab)
12547         (psym_forget_cached_source_info, psym_print_stats)
12548         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12549         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12550         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12551         (psym_find_compunit_symtab_by_address)
12552         (maintenance_print_psymbols, maintenance_info_psymtabs)
12553         (maintenance_check_psymtabs): Use ranged for.
12554         * psymtab.h (class objfile_psymtabs): New.
12555         (require_partial_symbols): Return objfile_psymtabs.
12556         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12557
12558 2019-01-09  Tom Tromey  <tom@tromey.com>
12559
12560         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12561         (find_pc_mapped_section, list_overlays_command)
12562         (map_overlay_command, unmap_overlay_command)
12563         (simple_overlay_update): Use all_objfiles.
12564         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12565         * printcmd.c (info_symbol_command): Use all_objfiles.
12566         * objfiles.h (ALL_OBJSECTIONS): Remove.
12567         * maint.c (maintenance_translate_address): Use all_objfiles.
12568         * gcore.c (gcore_create_callback): Use all_objfiles.
12569         (objfile_find_memory_regions): Likewise.
12570
12571 2019-01-09  Tom Tromey  <tom@tromey.com>
12572
12573         * symtab.c (find_line_symtab, info_sources_command)
12574         (make_source_files_completion_list): Use objfile_compunits.
12575         * source.c (select_source_symtab): Use objfile_compunits.
12576         * objfiles.h (struct objfile): Update comment.
12577         (ALL_OBJFILES): Remove.
12578         (ALL_FILETABS): Remove.
12579         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12580         objfile_compunits.
12581
12582 2019-01-09  Tom Tromey  <tom@tromey.com>
12583
12584         * symmisc.c (print_objfile_statistics, dump_objfile)
12585         (maintenance_print_symbols): Use compunit_filetabs.
12586         * source.c (forget_cached_source_info_for_objfile): Use
12587         compunit_filetabs.
12588         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12589         (ALL_FILETABS): Use compunit_filetabs.
12590         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12591         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12592
12593 2019-01-09  Tom Tromey  <tom@tromey.com>
12594
12595         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12596         (compunit_filetabs): New.
12597         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12598         compunit_filetabs.
12599         (info_sources_command, make_source_files_completion_list): Remove
12600         declaration.
12601         * symmisc.c (print_objfile_statistics, dump_objfile)
12602         (maintenance_print_symbols): Remove declaration.
12603         (maintenance_info_symtabs): Use compunit_filetabs.
12604         (maintenance_info_line_tables): Likewise.
12605         * source.c (select_source_symtab): Change local variable name.
12606         (forget_cached_source_info_for_objfile): Remove declaration.
12607         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12608         * objfiles.c (objfile_relocate1): Remove declaration.
12609         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12610         declaration.
12611         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12612         * coffread.c (coff_symtab_read): Remove declaration.
12613         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12614         compunit_filetabs.
12615
12616 2019-01-09  Tom Tromey  <tom@tromey.com>
12617
12618         * symtab.c (lookup_objfile_from_block)
12619         (find_pc_sect_compunit_symtab, search_symbols)
12620         (default_collect_symbol_completion_matches_break_on): Use
12621         objfile_compunits.
12622         * objfiles.h (ALL_COMPUNITS): Remove.
12623         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12624         * cp-support.c (add_symbol_overload_list_qualified): Use
12625         objfile_compunits.
12626         * ada-lang.c (ada_collect_symbol_completion_matches)
12627         (ada_add_global_exceptions): Use objfile_compunits.
12628
12629 2019-01-09  Tom Tromey  <tom@tromey.com>
12630
12631         * source.c (select_source_symtab)
12632         (forget_cached_source_info_for_objfile): Remove declaration.
12633         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12634         declaration.
12635         * maint.c (count_symtabs_and_blocks): Remove declaration.
12636         * cp-support.c (add_symbol_overload_list_qualified): Remove
12637         declaration.
12638         * coffread.c (coff_symtab_read): Remove declaration.
12639         * symtab.c (lookup_symbol_in_objfile_symtabs)
12640         (basic_lookup_transparent_type_1): Use objfile_compunits.
12641         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12642         (info_sources_command, search_symbols)
12643         (default_collect_symbol_completion_matches_break_on)
12644         (make_source_files_completion_list): Remove declaration.
12645         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12646         (ada_collect_symbol_completion_matches)
12647         (ada_add_global_exceptions): Remove declaration.
12648         * linespec.c (iterate_over_all_matching_symtabs): Use
12649         objfile_compunits.
12650         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12651         (class objfile_compunits): New.
12652         (ALL_COMPUNITS): Use objfile_compunits.
12653         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12654         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12655         objfile_compunits.
12656         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12657
12658 2019-01-09  Tom Tromey  <tom@tromey.com>
12659
12660         * symtab.c (search_symbols)
12661         (default_collect_symbol_completion_matches_break_on): Use
12662         objfile_msymbols.
12663         * ada-lang.c (ada_lookup_simple_minsym)
12664         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12665         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12666         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12667         objfile_msymbols.
12668         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12669         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12670         * objc-lang.c (find_methods): Use objfile_msymbols.
12671         (info_selectors_command, info_classes_command): Likewise.
12672         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12673         * objfiles.h (class objfile_msymbols): New.
12674         (ALL_OBJFILE_MSYMBOLS): Remove.
12675         (ALL_MSYMBOLS): Remove.
12676
12677 2019-01-09  Tom Tromey  <tom@tromey.com>
12678
12679         * common/next-iterator.h (next_adapter): Add Iterator template
12680         parameter.
12681         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12682         (class all_objfiles_safe): New.
12683         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12684         * objfiles.c (put_objfile_before): Update comment.
12685         (add_separate_debug_objfile): Likewise.
12686         (free_all_objfiles): Use all_objfiles_safe.
12687         (objfile_purge_solibs): Likewise.
12688
12689 2019-01-09  Tom Tromey  <tom@tromey.com>
12690
12691         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12692         (expand_symtab_containing_pc, lookup_static_symbol)
12693         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12694         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12695         all_objfiles.
12696         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12697         * breakpoint.c (create_overlay_event_breakpoint)
12698         (create_longjmp_master_breakpoint)
12699         (create_std_terminate_master_breakpoint)
12700         (create_exception_master_breakpoint): Use all_objfiles.
12701         * linux-thread-db.c (try_thread_db_load_from_pdir)
12702         (has_libpthread): Use all_objfiles.
12703         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12704         * linespec.c (iterate_over_all_matching_symtabs)
12705         (search_minsyms_for_name): Use all_objfiles.
12706         * maint.c (maintenance_info_sections): Use all_objfiles.
12707         * main.c (captured_main_1): Use all_objfiles.
12708         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12709         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12710         * guile/scm-pretty-print.c
12711         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12712         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12713         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12714         (maintenance_print_msymbols): Use all_objfiles.
12715         * source.c (select_source_symtab): Use all_objfiles.
12716         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12717         * symfile.c (remove_symbol_file_command)
12718         (expand_symtabs_matching, map_symbol_filenames): Use
12719         all_objfiles.
12720         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12721         all_objfiles.
12722         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12723         * objc-lang.c (find_methods): Use all_objfiles.
12724         * objfiles.c (have_partial_symbols, have_full_symbols)
12725         (have_minimal_symbols, qsort_cmp)
12726         (default_iterate_over_objfiles_in_search_order): Use
12727         all_objfiles.
12728         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12729         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12730         (maintenance_check_psymtabs): Use all_objfiles.
12731         (ALL_PSYMTABS): Remove.
12732         * compile/compile-object-run.c (do_module_cleanup): Use
12733         all_objfiles.
12734         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12735         * cp-support.c (add_symbol_overload_list_qualified): Use
12736         all_objfiles.
12737         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12738         Use all_objfiles.
12739         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12740         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12741         all_objfiles.
12742         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12743         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12744         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12745         Uses all_objfiles.
12746         * solib.c (solib_read_symbols): Use all_objfiles
12747
12748 2019-01-09  Tom Tromey  <tom@tromey.com>
12749
12750         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12751         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12752         all_objfiles.
12753         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12754         * symmisc.c (print_symbol_bcache_statistics)
12755         (print_objfile_statistics, maintenance_print_objfiles)
12756         (maintenance_info_symtabs, maintenance_check_symtabs)
12757         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12758         all_objfiles.
12759         * source.c (forget_cached_source_info): Use all_objfiles.
12760         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12761         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12762         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12763         * objfiles.c (update_section_map): Use all_objfiles.
12764         (shared_objfile_contains_address_p): Likewise.
12765         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12766         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12767
12768 2019-01-09  Tom Tromey  <tom@tromey.com>
12769
12770         * common/next-iterator.h: New file.
12771         * objfiles.h (class all_objfiles): New.
12772         (struct objfile_iterator): New.
12773
12774 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12775
12776         * NEWS: Move the description of the changed "frame", "select-frame",
12777          and "info frame" commands to the Changed commands section.
12778
12779 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12780
12781         * gdbtypes.c (check_stub_method_group): Remove handling of old
12782         mangling schemes.
12783         * linespec.c (find_methods): Likewise.
12784         * stabsread.c (read_member_functions): Likewise.
12785         * valops.c (search_struct_method): Likewise.
12786         (value_struct_elt_for_reference): Likewise.
12787         * NEWS: Mention this change.
12788
12789 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12790
12791         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12792         print_source_lines.
12793         * source.c (print_source_lines_base): Update line number check.
12794         (print_source_lines): New function.
12795         (source_lines_range::source_lines_range): New function.
12796         * source.h (class source_lines_range): New class.
12797         (print_source_lines): New declaration.
12798
12799 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12800
12801         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12802
12803 2019-01-08  Tom Tromey  <tom@tromey.com>
12804             Simon Marchi  <simon.marchi@ericsson.com>
12805
12806         PR gdb/24060
12807         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12808         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12809         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12810         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12811         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12812         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12813
12814 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12815
12816         * source.c (select_source_symtab): Move header comment to
12817         declaration in source.h.
12818         (forget_cached_source_info_for_objfile): Likewise.
12819         (forget_cached_source_info): Likewise.
12820         (identify_source_line): Likewise.
12821         * source.h (identify_source_line): Move declaration from symtab.h
12822         and add comment from source.c
12823         (print_source_lines): Likewise.
12824         (forget_cached_source_info_for_objfile): Likewise.
12825         (forget_cached_source_info): Likewise.
12826         (select_source_symtab): Likewise.
12827         (enum print_source_lines_flag): Move definition from symtab.h.
12828         * symtab.h (identify_source_line): Move declaration to source.h.
12829         (print_source_lines): Likewise.
12830         (forget_cached_source_info_for_objfile): Likewise.
12831         (forget_cached_source_info): Likewise.
12832         (select_source_symtab): Likewise.
12833         (enum print_source_lines_flag): Move definition to source.h.
12834         * tui/tui-hooks.c: Add 'source.h' include.
12835
12836 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12837
12838         * source.c (print_source_lines_base): Handle requests to print
12839         reverse line number sequences, and guard against empty lines
12840         string.
12841
12842 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12843
12844         * source.c (print_source_lines_base): Fix skip of '\r' if next
12845         character is '\n'.
12846
12847 2019-01-06  Tom Tromey  <tom@tromey.com>
12848
12849         * c-exp.y (struct c_parse_state) <macro_original_text,
12850         expansion_obstack>: New member.
12851         (macro_original_text, expansion_obstack): Remove globals.
12852         (scan_macro_expansion, scanning_macro_expansion)
12853         (finished_macro_expansion): Update.
12854         (scan_macro_cleanup): Remove.
12855         (yylex, c_parse): Update.
12856
12857 2019-01-06  Tom Tromey  <tom@tromey.com>
12858
12859         * c-exp.y (struct c_parse_state) <strings>: New member.
12860         (operator_stoken): Update.
12861
12862 2019-01-06  Tom Tromey  <tom@tromey.com>
12863
12864         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12865         (union type_stack_elt) <typelist_val>: Now a pointer to
12866         std::vector.
12867         (type_stack_cleanup): Don't declare.
12868         (push_typelist): Update.
12869         * parse.c (pop_typelist): Return a std::vector.
12870         (push_typelist): Take a std::vector.
12871         (follow_types): Update.  Do not free args.
12872         (type_stack_cleanup): Remove.
12873         * c-exp.y (struct c_parse_state): New.
12874         (cpstate): New global.
12875         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12876         (nonempty_typelist): Update.
12877         (func_mod): Create a new vector.
12878         (c_parse): Create a c_parse_state.
12879         (check_parameter_typelist): Do not delete params.
12880         (function_method): Update.  Do not delete type_list.
12881
12882 2019-01-06  Tom Tromey  <tom@tromey.com>
12883
12884         PR gdb/28155:
12885         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12886         check_typedef.
12887         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12888         (print_return_value): Likewise.
12889
12890 2019-01-05  Tom Tromey  <tom@tromey.com>
12891
12892         * contrib/cleanup_check.py: Remove.
12893         * contrib/gcc-with-excheck: Remove.
12894         * contrib/exsummary.py: Remove.
12895         * contrib/excheck.py: Remove.
12896
12897 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12898
12899         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12900         NULL. Initialize tpprev to NULL instead of assigning it
12901         to NULL on the next statement.
12902         * windows-nat.c (windows_delete_thread): Remove check for
12903         main_thread_id before printing thread exit notifications.
12904         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12905         Remove thread ID check against main_thread_id.
12906         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12907         windows_delete_thread.
12908         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12909
12910 2019-01-04  Tom Tromey  <tom@tromey.com>
12911
12912         * compile/compile.c (_initialize_compile): Use upper case for
12913         metasyntactic variables.
12914         * symmisc.c (_initialize_symmisc): Use upper case for
12915         metasyntactic variables.
12916         * psymtab.c (_initialize_psymtab): Use upper case for
12917         metasyntactic variables.
12918         * demangle.c (demangle_command): Use upper case for metasyntactic
12919         variables.
12920         (_initialize_demangler): Likewise.
12921         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12922         variables.
12923
12924 2019-01-03  Tom Tromey  <tom@tromey.com>
12925
12926         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12927
12928 2019-01-03  Tom Tromey  <tom@tromey.com>
12929
12930         * python/py-symtab.c (salpy_str): Update.
12931         (struct salpy_sal_object) <symtab>: Now a PyObject.
12932         (salpy_dealloc): Update.
12933         (del_objfile_sal): Use gdbpy_ref.
12934
12935 2019-01-03  Tom Tromey  <tom@tromey.com>
12936
12937         * python/py-type.c (convert_field): Use new_reference.  Return
12938         gdbpy_ref.
12939         (make_fielditem): Return gdbpy_ref.
12940         (typy_fields): Update.
12941         (typy_getitem): Update.
12942         (field_name): Return gdbpy_ref.  Use new_reference.
12943         (typy_iterator_iternext): Update.
12944
12945 2019-01-03  Tom Tromey  <tom@tromey.com>
12946
12947         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12948
12949 2019-01-03  Tom Tromey  <tom@tromey.com>
12950
12951         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12952         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12953         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12954         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12955         (pspy_set_type_printers): Likewise.
12956         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12957         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12958         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12959         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12960         (objfpy_set_type_printers): Likewise.
12961
12962 2019-01-03  Tom Tromey  <tom@tromey.com>
12963
12964         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12965         (gdbpy_print_stack): Use gdbpy_err_fetch.
12966         * python/python-internal.h (class gdbpy_err_fetch): New class.
12967         (class gdbpy_enter) <m_error_type, m_error_value,
12968         m_error_traceback>: Remove.
12969         <m_error>: New member.
12970         (gdbpy_exception_to_string): Don't declare.
12971         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12972         * python/py-value.c (convert_value_from_python): Use
12973         gdbpy_err_fetch.
12974         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12975         gdbpy_exception_to_string.
12976         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12977         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12978         gdbpy_err_fetch.
12979
12980 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12981
12982         * linux-nat.c (delete_lwp_cleanup): Delete.
12983         (struct lwp_deleter): New struct.
12984         (lwp_info_up): New typedef.
12985         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12986         lwp_info_up.
12987
12988 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12989
12990         * linux-fork.c (class scoped_switch_fork_info): New class.
12991         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12992
12993 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12994
12995         * valops.c (find_overload_match): Remove use of null_cleanup, and
12996         calls to do_cleanups.
12997
12998 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12999
13000         * compile/compile-cplus-types.c
13001         (compile_cplus_instance::decl_name): Handle changes to
13002         cp_func_name.
13003         * cp-support.c (cp_func_name): Update header comment, update
13004         return type.
13005         * cp-support.h (cp_func_name): Update return type in declaration.
13006         * valops.c (find_overload_match): Move temp_func local to top
13007         level of function and change its type.  Use temp_func to hold and
13008         delete temporary string obtained from cp_func_name.
13009
13010 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13011
13012         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13013         gdb::char_vector, remove cleanup, and update uses of `msg`.
13014
13015 2019-01-03  Jim Wilson  <jimw@sifive.com>
13016
13017         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13018
13019 2019-01-02  Tom Tromey  <tom@tromey.com>
13020
13021         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13022         (tdesc_parse_xml): Remove cleanups.
13023         * target-descriptions.h (make_cleanup_free_target_description):
13024         Don't declare.
13025         (target_desc_deleter): New struct.
13026         (target_desc_up): New typedef.
13027         * target-descriptions.c (target_desc_deleter::operator()): Rename
13028         from free_target_description.
13029         (make_cleanup_free_target_description): Remove.
13030
13031 2019-01-02  Tom Tromey  <tom@tromey.com>
13032
13033         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13034         constructor, destructor.
13035         (linespec_parser): Remove typedef.
13036         (~linespec_parser): Rename from linespec_parser_delete.
13037         (linespec_lex_to_end, linespec_complete_label)
13038         (linespec_complete): Update.
13039         (decode_line_full): Remove cleanups.
13040         (decode_line_1): Update.
13041
13042 2019-01-02  Tom Tromey  <tom@tromey.com>
13043
13044         * python/python-internal.h (inferior_to_inferior_object): Change
13045         return type.
13046         * python/py-exitedevent.c (create_exited_event_object): Update.
13047         * python/py-inferior.c (inferior_to_inferior_object): Return
13048         gdbpy_ref.
13049         (python_new_inferior, python_inferior_deleted)
13050         (thread_to_thread_object, delete_thread_object)
13051         (build_inferior_list, gdbpy_selected_inferior): Update.
13052         * python/py-infthread.c (create_thread_object): Update.  Also fail
13053         if inferior_to_inferior_object fails.
13054
13055 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13056
13057         * inferior.h (class inferior) <displaced_step_state>: New field.
13058         * infrun.h (struct displaced_step_state): Move here from
13059         infrun.c.  Initialize fields, add constructor.
13060         <inf>: Remove field.
13061         <reset>: New method.
13062         * infrun.c (struct displaced_step_inferior_state): Move to
13063         infrun.h.
13064         (displaced_step_inferior_states): Remove.
13065         (get_displaced_stepping_state): Adust.
13066         (displaced_step_in_progress_any_inferior): Adjust.
13067         (displaced_step_in_progress_thread): Adjust.
13068         (displaced_step_in_progress): Adjust.
13069         (add_displaced_stepping_state): Remove.
13070         (get_displaced_step_closure_by_addr): Adjust.
13071         (remove_displaced_stepping_state): Remove.
13072         (infrun_inferior_exit): Call displaced_step_state.reset.
13073         (use_displaced_stepping): Don't check for NULL.
13074         (displaced_step_prepare_throw): Call
13075         get_displaced_stepping_state.
13076         (displaced_step_fixup): Don't check for NULL.
13077         (prepare_for_detach): Don't check for NULL.
13078
13079 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13080
13081         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13082          in case of call that did not complete.
13083
13084 2019-01-02  Andrey Utkin  <autkin@undo.io>
13085
13086         * symfile.c (find_separate_debug_file): Fix search of debug files for
13087         remote debuggee.
13088
13089 2019-01-02  Tom Tromey  <tom@tromey.com>
13090
13091         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13092         indentation.
13093         * python/py-frame.c (frapy_older): Remove cast.
13094         (frapy_newer): Likewise.
13095         * python/py-breakpoint.c (local_setattro): Remove cast.
13096         * python/py-arch.c (archpy_name): Remove local variable.
13097         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13098
13099 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13100
13101         * unittests/basic_string_view/element_access/char/empty.cc:
13102         Fix year range in copyright header.
13103
13104 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13105
13106         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13107         Delete.
13108         <operator==>: Update with for removed field.
13109         <hash>: Likewise.
13110         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13111         <isa_features>: ...this.
13112         <abi_features>: New field.
13113         (riscv_isa_flen): Update comment.
13114         (riscv_abi_xlen): New declaration.
13115         (riscv_abi_flen): New declaration.
13116         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13117         isa_features.
13118         (riscv_abi_xlen): New function.
13119         (riscv_isa_flen): Update to get answer from isa_features.
13120         (riscv_abi_flen): New function.
13121         (riscv_has_fp_abi): Update to get answer from abi_features.
13122         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13123         xlen and flen.
13124         (riscv_call_info) <xlen, flen>: Update comment.
13125         (riscv_call_arg_struct): Remove invalid assertions
13126         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13127         is removed.
13128         (riscv_gdbarch_init): Gather isa features and abi features
13129         separately, ensure both match on the gdbarch when reusing an old
13130         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13131         a target with 64-bit float hardware.
13132
13133 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13134
13135         * source.c (search_command_helper): Stop reverse search
13136         when line 1 has been searched.
13137
13138 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13139
13140         * record-full.c (record_full_base_target::close): Rewrite
13141         record_full_core_buf_list free logic.
13142
13143 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13144
13145         * break-catch-syscall.c (print_one_catch_syscall): xfree
13146         the last text.
13147
13148 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13149
13150         * top.c (print_gdb_version): Update Copyright year in version
13151         message.
13152
13153 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13154
13155         Update copyright year range in all GDB files.
13156
13157 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13158
13159         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13160
13161 For older changes see ChangeLog-2018.
13162 \f
13163 Local Variables:
13164 mode: change-log
13165 left-margin: 8
13166 fill-column: 74
13167 version-control: never
13168 coding: utf-8
13169 End:
13170